gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tromey@adacore.com>
   2
   3         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
   4         padding at end of comment.
   5
   6 2019-05-08  Tom Tromey  <tromey@adacore.com>
   7
   8         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
   9         Compare main types.
  10
  11 2019-05-06  Tom Tromey  <tom@tromey.com>
  12
  13         * common/scoped_mmap.c: Include common-defs.h.
  14         * common/scoped_mmap.h: Don't include config.h.
  15
  16 2019-05-04  Tom Tromey  <tom@tromey.com>
  17
  18         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
  19         (struct aarch64_call_info): Add initializers.
  20         <si>: Now a std::vector.
  21         (pass_on_stack, aarch64_push_dummy_call): Update.
  22
  23 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
  24             Tom Tromey  <tom@tromey.com>
  25
  26         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
  27         (ppc_threads): Now a std::vector.  Now static.
  28         (hwdebug_find_thread_points_by_tid)
  29         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
  30         Update.
  31
  32 2019-05-04  Tom Tromey  <tom@tromey.com>
  33
  34         * arc-tdep.c (arc_tdesc_init): Return bool.
  35
  36 2019-05-04  Tom Tromey  <tom@tromey.com>
  37
  38         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
  39         Use gdb_assert_not_reached.
  40
  41 2019-05-04  Tom Tromey  <tom@tromey.com>
  42
  43         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
  44         "false".
  45
  46 2019-05-04  Tom Tromey  <tom@tromey.com>
  47
  48         * arc-tdep.c (arc_tdesc_init): Use bool.
  49
  50 2019-05-04  Tom Tromey  <tom@tromey.com>
  51
  52         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
  53
  54 2019-05-04  Tom Tromey  <tom@tromey.com>
  55
  56         * cli/cli-cmds.c (valid_command_p): Return bool.
  57
  58 2019-05-04  Tom Tromey  <tom@tromey.com>
  59
  60         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
  61         * command.h (valid_user_defined_cmd_name_p): Channge return type.
  62
  63 2019-05-04  Raul Tambre  <raul@tambre.ee>
  64
  65         * python/lib/gdb/prompt.py (_ExtendedPrompt)
  66         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
  67         operator for comparison.
  68
  69 2019-05-04  Tom Tromey  <tom@tromey.com>
  70
  71         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  72         (lookup_partial_symbol, print_partial_symbols)
  73         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  74         (psymbol_compare): Update.
  75         (add_psymbol_to_bcache): Clear the entire psymbol.
  76         (maintenance_check_psymtabs): Update.
  77         * psympriv.h (struct partial_symbol): Don't derive from
  78         general_symbol_info.
  79         <obj_section, unrelocated_address, address,
  80         set_unrelocated_address>: Update.
  81         <ginfo>: New member.
  82         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  83         (debug_names::write_psymbols): Update.
  84
  85 2019-05-04  Tom de Vries  <tdevries@suse.de>
  86
  87         * contrib/cc-with-tweaks.sh: Support -n arg.
  88
  89 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  90
  91         * corelow.c (core_target::detach): Ensure frame cache and
  92         register caches are cleared.
  93         inferior.c (exit_inferior_1): Likewise.
  94
  95 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
  96             Tom Tromey  <tom@tromey.com>
  97
  98         * dictionary.c (collate_pending_symbols_by_language): Remove
  99         "struct" from foreach.
 100         * symtab.c (lookup_global_symbol_from_objfile)
 101         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 102         foreach.
 103         * ser-tcp.c (net_open): Remove "struct" from foreach.
 104         * objfiles.c (objfile_relocate, objfile_rebase)
 105         (objfile_has_symbols): Remove "struct" from foreach.
 106         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 107         from foreach.
 108         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 109         foreach.
 110         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 111         "struct" from foreach.
 112         * ada-lang.c (create_excep_cond_exprs)
 113         (ada_exception_catchpoint_cond_string): Remove "struct" from
 114         foreach.
 115
 116 2019-05-03  Tom Tromey  <tromey@adacore.com>
 117
 118         * ada-exp.y (convert_char_literal): Check suffix of each
 119         enumerator.
 120
 121 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 122
 123         PR ada/21406:
 124         * ada-exp.y (yywrap): Don't define.
 125         * ada-lex.l (%option): Add noyywrap
 126         (yywrap): Remove.
 127
 128 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 129
 130         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 131         _WIN32_WINNT to the XP level, unless already defined to a higher
 132         level.
 133
 134         * unittests/parse-connection-spec-selftests.c:
 135         * ser-tcp.c:
 136         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 137         override.
 138
 139         * symfile.c (find_separate_debug_file): Remove colon from the
 140         drive spec of DOS/Windows file names of the target, so that the
 141         file name produced from DEBUGDIR and the target's directory will
 142         be valid on DOS/Windows systems.
 143
 144 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 145
 146         * rust-lang.c (val_print_struct): Handle printing structures
 147         containing strings.
 148
 149 2019-05-02  Tom Tromey  <tromey@adacore.com>
 150
 151         * valarith.c (_initialize_valarith): Remove.
 152
 153 2019-05-01  Tom Tromey  <tromey@adacore.com>
 154
 155         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 156         bitfields.
 157
 158 2019-05-01  Tom Tromey  <tromey@adacore.com>
 159
 160         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 161         for big-endian copies.
 162
 163 2019-04-30  Ali Tamur  <tamur@google.com>
 164         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 165         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 166         (read_3_bytes): New function.
 167
 168 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 169
 170         * windows-nat.c (main_thread_id): Delete.
 171         (handle_output_debug_string): Replace main_thread_id by
 172         current_event.dwThreadId.
 173         (fake_create_process): Likewise.
 174         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 175         Do not set main_thread_id.
 176         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 177         current_event.dwThreadId.
 178         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 179
 180 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 181
 182         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 183         Use current_event.dwThreadId instead of main_thread_id.
 184
 185 2019-04-30  Tom Tromey  <tromey@adacore.com>
 186
 187         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 188         (create_excep_cond_exprs): Iterate over program spaces.
 189         (ada_exception_catchpoint_cond_string): Examine all minimal
 190         symbols for exception types.
 191
 192 2019-04-30  Tom Tromey  <tromey@adacore.com>
 193
 194         PR c++/24470:
 195         * dwarf2read.c (process_structure_scope): Handle case where type
 196         has template parameters but no symbol was created.
 197
 198 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 199             Chris January  <chris.january@arm.com>
 200
 201         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 202         qualifier.
 203         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 204
 205 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 206
 207         * f-typeprint.c (f_print_type): Update rules for printing
 208         whitespace.
 209         (f_type_print_varspec_suffix): Likewise.
 210
 211 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 212             Chris January  <chris.january@arm.com>
 213
 214         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 215         function arguments.
 216
 217 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 218
 219         * f-lang.c (build_fortran_types): Change name of void type to
 220         lower case.
 221         * f-typeprint.c (f_type_print_base): Print the name of the void
 222         type, rather than a fixed string.
 223         * f-valprint.c (f_decorations): Use lower case void string.
 224
 225 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 226             Chris January  <chris.january@arm.com>
 227
 228         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 229         types for Fortran.
 230
 231 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 232             Chris January  <chris.january@arm.com>
 233             David Lecomber  <david.lecomber@arm.com>
 234
 235         * f-exp.y (BINOP_INTRINSIC): New token.
 236         (exp): New parser rule handling BINOP_INTRINSIC.
 237         (f77_keywords): Add new builtin procedures.
 238         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 239         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 240         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 241         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 242         (print_unop_subexp_f): New function.
 243         (print_binop_subexp_f): New function.
 244         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 245         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 246         (dump_subexp_body_f): Likewise.
 247         (operator_check_f): Likewise.
 248         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 249         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 250
 251 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 252
 253         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 254         UNOP_KIND.
 255         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 256         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 257         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 258         (operator_length_f): New fuction.
 259         (print_subexp_f): New function.
 260         (op_name_f): New function.
 261         (dump_subexp_body_f): New function.
 262         (operator_check_f): New function.
 263         (exp_descriptor_f): Replace standard expression handling functions
 264         with new functions.
 265         * gdb/fortran-operator.def: New file.
 266         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 267         * gdb/std-operator.def: Remove UNOP_KIND.
 268
 269 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 270
 271         * std-operator.def: Remove unbalanced, stray double quote
 272         character.
 273
 274 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 275             Chris January  <chris.january@arm.com>
 276             Daniel Everett  <daniel.everett@arm.com>
 277             Nick Forrington  <nick.forrington@arm.com>
 278             Richard Bunt  <richard.bunt@arm.com>
 279
 280         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 281         of depth when printing anonymous structs or unions.
 282         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 283         Don't print either the top-level value, or the children if the
 284         max-depth is exceeded.
 285         (ppscm_print_children): When printing the key of a map, allow one
 286         extra level of depth.
 287         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 288         print either the top-level value, or the children if the max-depth
 289         is exceeded.
 290         (print_children): When printing the key of a map, allow one extra
 291         level of depth.
 292         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 293         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 294         (user_print_options): Initialise max_depth field.
 295         (val_print_scalar_or_string_type_p): New function.
 296         (val_print): Check to see if the max depth has been reached.
 297         (val_print_check_max_depth): Define new function.
 298         (show_print_max_depth): New function.
 299         (_initialize_valprint): Add 'print max-depth' option.
 300         * valprint.h (struct value_print_options) <max_depth>: New field.
 301         (val_print_check_max_depth): Declare new function.
 302         * NEWS: Document new feature.
 303
 304 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 305
 306         * ada-lang.c (ada_language_defn): Initialise new field.
 307         * c-lang.c (c_is_string_type_p): New function.
 308         (c_language_defn): Initialise new field.
 309         (cplus_language_defn): Initialise new field.
 310         (asm_language_defn): Initialise new field.
 311         (minimal_language_defn): Initialise new field.
 312         * c-lang.h (c_is_string_type_p): Declare new function.
 313         * d-lang.c (d_language_defn): Initialise new field.
 314         * f-lang.c (f_is_string_type_p): New function.
 315         (f_language_defn): Initialise new field.
 316         * go-lang.c (go_is_string_type_p): New function.
 317         (go_language_defn): Initialise new field.
 318         * language.c (default_is_string_type_p): New function.
 319         (unknown_language_defn): Initialise new field.
 320         (auto_language_defn): Initialise new field.
 321         * language.h (struct language_defn) <la_is_string_type_p>: New
 322         member variable.
 323         (default_is_string_type_p): Declare new function.
 324         * m2-lang.c (m2_language_defn): Initialise new field.
 325         * objc-lang.c (objc_language_defn): Initialise new field.
 326         * opencl-lang.c (opencl_language_defn): Initialise new field.
 327         * p-lang.c (pascal_is_string_type_p): New function.
 328         (pascal_language_defn): Initialise new field.
 329         * rust-lang.c (rust_is_string_type_p): New function.
 330         (rust_language_defn): Initialise new field.
 331
 332 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 333
 334         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 335         New field.
 336         * ada-lang.c (ada_language_defn): Initialise new field.
 337         * c-lang.c (c_language_defn): Likewise.
 338         (cplus_language_defn): Likewise.
 339         (asm_language_defn): Likewise.
 340         (minimal_language_defn): Likewise.
 341         * d-lang.c (d_language_defn): Likewise.
 342         * f-lang.c (f_language_defn): Likewise.
 343         * go-lang.c (go_language_defn): Likewise.
 344         * language.c (unknown_language_defn): Likewise.
 345         (auto_language_defn): Likewise.
 346         * m2-lang.c (m2_language_defn): Likewise.
 347         * objc-lang.c (objc_language_defn): Likewise.
 348         * opencl-lang.c (opencl_language_defn): Likewise.
 349         * p-lang.c (pascal_language_defn): Likewise.
 350         * rust-lang.c (rust_language_defn): Likewise.
 351
 352 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 353
 354         * ada-lang.c (ada_is_character_type): Change return type to bool.
 355         (ada_is_string_type): Likewise.
 356         * ada-lang.h (ada_is_character_type): Update declaration
 357         (ada_is_string_type): Likewise.
 358
 359 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 360
 361         Support style in 'frame|thread apply'
 362
 363         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 364         * record.c (record_start, record_stop): Update callers of
 365         execute_command_to_string with false.
 366         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 367         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 368         methods.
 369         (class string_file): New constructor with term_out parameter.
 370         Override methods term_out and can_emit_style_escape.  New member
 371         term_out.
 372         (class stdio_file): Override can_emit_style_escape.
 373         (class tee_file): Override term_out and can_emit_style_escape.
 374         * utils.h (can_emit_style_escape): Remove.
 375         * utils.c (can_emit_style_escape): Likewise.
 376         Update all callers of can_emit_style_escape (SOMESTREAM) to
 377         SOMESTREAM->can_emit_style_escape.
 378         * source-cache.c (source_cache::get_source_lines): Likewise.
 379         * stack.c (frame_apply_command_count): Call execute_command_to_string
 380         passing the term_out characteristic of the current gdb_stdout.
 381         * thread.c (thr_try_catch_cmd): Likewise.
 382         * top.c (execute_command_to_string): pass term_out parameter
 383         to construct the string_file for the command output.
 384         * ui-file.c (term_cli_styling): New function (most code moved
 385         from utils.c can_emit_style_escape).
 386         (string_file::string_file, string_file::can_emit_style_escape,
 387         stdio_file::can_emit_style_escape, tee_file::term_out,
 388         tee_file::can_emit_style_escape): New functions.
 389
 390 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 391
 392         * NEWS: Mention the new set|show may-call-functions.
 393         * infcall.c (may_call_functions_p): New variable.
 394         (show_may_call_functions_p): New function.
 395         (call_function_by_hand_dummy): Throws an error if not
 396         may-call-functions.
 397         (_initialize_infcall): Call add_setshow_boolean_cmd for
 398         may-call-functions.
 399
 400 2019-04-25  Keith Seitz  <keiths@redhat.com>
 401
 402         PR c++/24367
 403         * cp-support.c (inspect_type): Don't attempt substitutions
 404         of symbol with the same name.
 405
 406 2019-04-25  Tom Tromey  <tromey@adacore.com>
 407
 408         PR gdb/24475:
 409         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 410         static.
 411
 412 2019-04-25  Tom Tromey  <tromey@adacore.com>
 413
 414         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 415         rvalue reference.
 416         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 417         (gdb_xml_parser::parse): Use std::move.
 418         * python/python-internal.h (gdbpy_convert_exception): Take a const
 419         reference.
 420         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 421         std::move.
 422         * python/py-utils.c (gdbpy_convert_exception): Take a const
 423         reference.
 424         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 425         Use std::move.
 426         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 427         Use std::move.
 428         * mi/mi-main.c (mi_print_exception): Take a const reference.
 429         * main.c (handle_command_errors): Take a const reference.
 430         * linespec.c (parse_linespec): Use std::move.
 431         * infcall.c (run_inferior_call): Use std::move.
 432         (call_function_by_hand_dummy): Use std::move.
 433         * exec.c (try_open_exec_file): Use std::move.
 434         * exceptions.h (exception_print, exception_fprintf)
 435         (exception_print_same): Update.
 436         * exceptions.c (print_exception, exception_print)
 437         (exception_fprintf, exception_print_same): Change parameters to
 438         const reference.
 439         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 440         * common/new-op.c: Use std::move.
 441         * common/common-exceptions.h (struct gdb_exception): Add move
 442         constructor.
 443         (struct gdb_exception_error, struct gdb_exception_quit, struct
 444         gdb_quit_bad_alloc): Change constructor to move constructor.
 445         (throw_exception): Change parameter to rvalue reference.
 446         * common/common-exceptions.c (throw_exception): Take rvalue
 447         reference.
 448         * cli/cli-interp.c (safe_execute_command): Use std::move.
 449         * breakpoint.c (insert_bp_location, location_to_sals): Use
 450         std::move.
 451
 452 2019-04-25  Tom Tromey  <tromey@adacore.com>
 453
 454         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 455         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 456         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 457         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 458         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 459         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 460         guile/scm-value.c: Use unpack.
 461         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 462         gdbscm_gdb_exception.
 463         (gdbscm_throw_gdb_exception): Likewise.
 464         (struct gdbscm_gdb_exception): New.
 465         (unpack): New function.
 466         (gdbscm_wrap): Use unpack.
 467
 468 2019-04-25  Tom Tromey  <tromey@adacore.com>
 469
 470         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 471         (gdb_rl_callback_handler): Use std::move.
 472         * common/common-exceptions.h (struct gdb_exception): Add move
 473         assignment operator.
 474         (throw_exception_sjlj): Change "exception" to const reference.
 475         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 476         (throw_exception_sjlj): Change "exception" to const reference.
 477
 478 2019-04-25  Tom Tromey  <tromey@adacore.com>
 479
 480         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 481         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 482         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 483         Update.
 484         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 485         Update.
 486         * mi/mi-interp.c (mi_interp::exec): Update.
 487         * linespec.c (parse_linespec): Update.
 488         * infcall.c (run_inferior_call): Update.
 489         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 490         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 491         (gdbscm_lookup_global_symbol): Update.
 492         * guile/scm-param.c (gdbscm_parameter_value): Update.
 493         * guile/scm-frame.c (gdbscm_frame_read_register)
 494         (gdbscm_frame_read_var): Update.
 495         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 496         * exec.c (try_open_exec_file): Update.
 497         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 498         (gdb_rl_callback_handler): Update.
 499         * common/common-exceptions.h (exception_none): Don't declare.
 500         * common/common-exceptions.c (exception_none): Don't define.
 501         (struct catcher) <exception>: Update.
 502         * cli/cli-interp.c (safe_execute_command): Update.
 503         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 504
 505 2019-04-25  Ali Tamur  <tamur@google.com>
 506
 507         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 508         (read_attribute_value): Likewise.
 509         (dwarf2_read_addr_index): Update comment.
 510         (read_str_index): Add DW_FORM_strx.
 511         (dwarf2_string_attr): Likewise.
 512         (dwarf2_const_value_attr): Likewise.
 513         (dump_die_shallow): Likewise.
 514         (dwarf2_fetch_constant_bytes): Likewise.
 515         (skip_form_bytes): Likewise.
 516         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 517
 518 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 519
 520         PR corefiles/11608
 521         PR corefiles/18187
 522         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 523         OFFSET.  Verify if current mapping contains an ELF header.
 524         (linux_find_memory_regions_full): Adjust call to
 525         dump_mapping_p.
 526
 527 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 528             Kang Li <kanglictf@gmail.com>
 529
 530         PR gdb/21600
 531
 532         * dwarf2-frame.c (read_initial_length): Be consistent about using
 533         unsigned representation of length.
 534         (decode_frame_entry_1): Likewise.  Check for wraparound of
 535         end pointer as well as buffer overflow.
 536
 537 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 538
 539         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 540         "vq".
 541
 542 2019-04-24  Tom Tromey  <tromey@adacore.com>
 543
 544         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 545
 546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 547
 548         * s12z-tdep.c (s12z_unwind_pc): Delete.
 549         (s12z_unwind_sp): Delete.
 550         (s12z_gdbarch_init): Don't register deleted functions with
 551         gdbarch.
 552
 553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 554
 555         * rl78-tdep.c (rl78_unwind_sp): Delete.
 556         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 557
 558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 559
 560         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 561         (xstormy16_unwind_pc): Delete.
 562         (xstormy16_dummy_id): Delete.
 563         (xstormy16_gdbarch_init): Don't register deleted functions with
 564         gdbarch.
 565
 566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 567
 568         * vax-tdep.c (vax_unwind_pc): Delete.
 569         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 570
 571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 572
 573         * v850-tdep.c (v850_unwind_sp): Delete.
 574         (v850_unwind_pc): Delete.
 575         (v850_dummy_id): Delete.
 576         (v850_gdbarch_init): Don't register deleted functions with
 577         gdbarch.
 578
 579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 580
 581         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 582         (tilegx_unwind_pc): Delete.
 583         (tilegx_unwind_dummy_id): Delete.
 584         (tilegx_gdbarch_init): Don't register deleted functions with
 585         gdbarch.
 586
 587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 588
 589         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 590         (tic6x_dummy_id): Delete.
 591         (tic6x_gdbarch_init): Don't register deleted functions with
 592         gdbarch.
 593
 594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 595
 596         * sparc-tdep.c (sparc_unwind_pc): Delete.
 597         (sparc32_gdbarch_init): Don't register deleted function with
 598         gdbarch.
 599
 600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 601
 602         * sh-tdep.c (sh_unwind_sp): Delete.
 603         (sh_unwind_pc): Delete.
 604         (sh_dummy_id): Delete.
 605         (sh_gdbarch_init): Don't register deleted functions with
 606         gdbarch.
 607
 608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 609
 610         * score-tdep.c (score_unwind_sp): Delete.
 611         (score_unwind_pc): Delete.
 612         (score_dummy_id): Delete.
 613         (score_gdbarch_init): Don't register deleted functions with
 614         gdbarch.
 615
 616 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 617
 618         * rx-tdep.c (rx_unwind_pc): Delete.
 619         (rx_unwind_sp): Delete.
 620         (rx_dummy_id): Delete.
 621         (rx_gdbarch_init): Don't register deleted functions with
 622         gdbarch.  Update comment.
 623
 624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 625
 626         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 627         (rs6000_dummy_id): Delete.
 628         (rs6000_gdbarch_init): Don't register deleted functions with
 629         gdbarch.
 630
 631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 632
 633         * or1k-tdep.c (or1k_dummy_id): Delete.
 634         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 635
 636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 637
 638         * nios2-tdep.c (nios2_dummy_id): Delete.
 639         (nios2_unwind_sp): Delete.
 640         (nios2_gdbarch_init): Don't register deleted functions with
 641         gdbarch.
 642
 643 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 644
 645         * nds32-tdep.c (nds32_dummy_id): Delete.
 646         (nds32_unwind_pc): Delete.
 647         (nds32_unwind_sp): Delete.
 648         (nds32_gdbarch_init): Don't register deleted functions with
 649         gdbarch.
 650
 651 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 652
 653         * msp430-tdep.c (msp430_unwind_pc): Delete.
 654         (msp430_unwind_sp): Delete.
 655         (msp430_dummy_id): Delete.
 656         (msp430_gdbarch_init): Don't register deleted functions with
 657         gdbarch.
 658
 659 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 660
 661         * moxie-tdep.c (moxie_unwind_sp): Delete.
 662         (moxie_unwind_pc): Delete.
 663         (moxie_dummy_id): Delete.
 664         (moxie_gdbarch_init): Don't register deleted functions with
 665         gdbarch.
 666
 667 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 668
 669         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 670         (mn10300_unwind_pc): Delete.
 671         (mn10300_unwind_sp): Delete.
 672         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 673         mn10300_unwind_sp.
 674         (mn10300_frame_unwind_init): Don't register deleted functions with
 675         gdbarch.
 676
 677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 678
 679         * mep-tdep.c (mep_unwind_pc): Delete.
 680         (mep_unwind_sp): Delete.
 681         (mep_dummy_id): Delete.
 682         (mep_gdbarch_init): Don't register deleted functions with
 683         gdbarch.
 684
 685 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 686
 687         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 688         (m68hc11_unwind_sp): Delete.
 689         (m68hc11_gdbarch_init): Don't register deleted functions with
 690         gdbarch.
 691
 692 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 693
 694         * m32r-tdep.c (m32r_unwind_sp): Delete.
 695         (m32r_unwind_pc): Delete.
 696         (m32r_dummy_id): Delete.
 697         (m32r_gdbarch_init): Don't register deleted functions with
 698         gdbarch.
 699
 700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 701
 702         * m32c-tdep.c (m32c_unwind_pc): Delete.
 703         (m32c_unwind_sp): Delete.
 704         (m32c_dummy_id): Delete.
 705         (m32c_gdbarch_init): Don't register deleted functions with
 706         gdbarch.
 707
 708 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 709
 710         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 711         (lm32_unwind_pc): Delete.
 712         (lm32_dummy_id): Delete.
 713         (lm32_gdbarch_init): Don't register deleted functions with
 714         gdbarch.
 715
 716 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 717
 718         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 719         (iq2000_unwind_pc): Delete.
 720         (iq2000_dummy_id): Delete.
 721         (iq2000_gdbarch_init): Don't register deleted functions with
 722         gdbarch.
 723
 724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 725
 726         * nds32-tdep.c (nds32_type_align): Delete.
 727         (nds32_push_dummy_call): Use type_align instead.
 728
 729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 730
 731         * arm-tdep.c (arm_type_align): Only handle vector override case.
 732         (arm_push_dummy_call): Use type_align.
 733         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 734
 735 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 736
 737         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 738         case.
 739         (pass_on_stack): Use type_align.
 740         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 741         function.
 742
 743 2019-04-23  Tom Tromey  <tromey@adacore.com>
 744
 745         * dwarf2read.c (line_header::file_name_at): Remove unused
 746         overload.
 747
 748 2019-04-23  Tom de Vries  <tdevries@suse.de>
 749
 750         PR gdb/24438
 751         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 752         invocation.
 753
 754
 755 2019-03-27  Ali Tamur  <tamur@google.com>
 756
 757         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 758         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 759         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 760         (dwarf_expr_context::get_addr_index): Likewise
 761         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 762         (symbol_needs_eval_context::get_addr_index): Likewise
 763         (disassemble_dwarf_expression): Add DW_OP_addrx
 764         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 765         (read_cutu_die_from_dwo): Update comment
 766         (skip_one_die): Add DW_FORM_addrx
 767         (read_attribute_value): Likewise
 768         (var_decode_location): Add DW_OP_addrx
 769         (dwarf2_const_value_attr): Add DW_FORM_addrx
 770         (dump_die_shallow): Likewise
 771         (dwarf2_fetch_constant_bytes): Likewise
 772         (decode_locdesc): Add DW_OP_addrx
 773         (skip_form_bytes): Add DW_FORM_addrx
 774
 775 2019-04-22  Ali Tamur  <tamur@google.com>
 776
 777         * MAINTAINERS (Write After Approval): Add self.
 778
 779 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 780
 781         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 782         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 783         (open_symbol_file_object): Likewise.
 784         (svr4_default_sos): Add info parameter.
 785         (svr4_read_so_list): Likewise.
 786         (svr4_current_sos_direct): Adjust functions calls to pass down
 787         info.
 788         (svr4_current_sos_1): Add info parameter.
 789         (svr4_current_sos): Call get_svr4_info, pass info down to
 790         svr4_current_sos_1.
 791         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 792         get_svr4_info.
 793         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 794         get_svr4_info.
 795         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 796         to get_svr4_info.
 797         (probes_table_remove_objfile_probes): Likewise.
 798         (register_solib_event_probe): Add info parameter.
 799         (solist_update_incremental): Pass info parameter down to
 800         svr4_read_so_list.
 801         (disable_probes_interface): Add info parameter.
 802         (svr4_handle_solib_event): Pass current_program_space to
 803         get_svr4_info.  Adjust disable_probes_interface cleanup.
 804         (svr4_create_probe_breakpoints): Add info parameter, pass it
 805         down to register_solib_event_probe.
 806         (svr4_create_solib_event_breakpoints): Add info parameter,
 807         pass it down to svr4_create_probe_breakpoints.
 808         (enable_break): Pass info down to
 809         svr4_create_solib_event_breakpoints.
 810         (svr4_solib_create_inferior_hook): Pass current_program_space to
 811         get_svr4_info.
 812         (svr4_clear_solib): Likewise.
 813
 814 2019-04-22  Pedro Alves  <palves@redhat.com>
 815
 816         * solib-svr4.c (svr4_free_objfile_observer): New.
 817         (probe_and_action::objfile): New field.
 818         (probes_table_htab_remove_objfile_probes)
 819         (probes_table_remove_objfile_probes): New functions.
 820         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 821         in the new probe_and_action.  Don't store the probe in 'lookup'.
 822         (svr4_create_probe_breakpoints): Pass objfile to
 823         register_solib_event_probe.
 824         (_initialize_svr4_solib): Register a free_objfile observer.
 825
 826 2019-04-19  Tom Tromey  <tom@tromey.com>
 827
 828         * common/queue.h: Remove.
 829
 830 2019-04-19  Tom Tromey  <tom@tromey.com>
 831
 832         * event-loop.c: Don't include "common/queue.h".
 833
 834 2019-04-19  Tom Tromey  <tom@tromey.com>
 835
 836         * remote.c (remote_target): Use delete.
 837         * remote-notif.h: Include <list>, not "common/queue.h".
 838         (notif_client_p): Remove typedef.
 839         (remote_notif_state): Add constructor, destructor, initializer.
 840         <notif_queue>: Now a std::list.
 841         (remote_notif_state_xfree): Don't declare.
 842         * remote-notif.c (remote_notif_process, handle_notification)
 843         (remote_notif_state_allocate): Update.
 844         (~remote_notif_state): Rename from remote_notif_state_xfree.
 845
 846 2019-04-19  Tom Tromey  <tom@tromey.com>
 847
 848         * symfile.c (reread_symbols): Update.
 849         * objfiles.c (objfile_register_static_link)
 850         (objfile_lookup_static_link): Update
 851         (~objfile) Don't delete static_links.
 852         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 853
 854 2019-04-19  Tom Tromey  <tom@tromey.com>
 855
 856         * type-stack.h (struct type_stack) <insert>: Constify string.
 857         * type-stack.c (type_stack::insert): Constify string.
 858         * gdbtypes.h (lookup_template_type): Update.
 859         (address_space_name_to_int): Update.
 860         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 861         const.
 862         (lookup_template_type): Make name const.
 863         * c-exp.y: Update rules.
 864         (lex_one_token, classify_name, classify_inner_name)
 865         (c_print_token): Update.
 866         * p-exp.y: Update rules.
 867         (yylex): Update.
 868         * f-exp.y: Update rules.
 869         (yylex): Update.
 870         * d-exp.y: Update rules.
 871         (lex_one_token, classify_name, classify_inner_name): Update.
 872         * parse.c (write_dollar_variable, copy_name): Return std::string.
 873         * parser-defs.h (copy_name): Change return type.
 874         * m2-exp.y: Update rules.
 875         (yylex): Update.
 876         * go-exp.y (lex_one_token): Update.
 877         Update rules.
 878         (classify_unsafe_function, classify_packaged_name)
 879         (classify_name, yylex): Update.
 880
 881 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 882
 883         * configure.ac: add --enable-source-highlight switch.
 884         * configure: Regenerate.
 885         * top.c (print_gdb_version): plumb --enable-source-highlight
 886         status to "show configuration".
 887
 888 2019-04-19  Tom Tromey  <tromey@adacore.com>
 889
 890         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 891         Check ADA_TYPE_P.
 892         (empty_record, ada_template_to_fixed_record_type_1)
 893         (template_to_static_fixed_type)
 894         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 895         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 896         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 897         macros.
 898
 899 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 900
 901         PR symtab/24423:
 902         * source.c (print_source_lines_base): Advance "iter" when a
 903         control character is seen.
 904
 905 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 906
 907         * inferior.h (struct infcall_suspend_state_deleter):
 908         Catch exception in destructor to avoid crash.
 909
 910 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 911
 912         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 913         close to the add_com "shell".
 914
 915 2019-04-18  Tom Tromey  <tromey@adacore.com>
 916
 917         * process-stratum-target.h (class process_stratum_target)
 918         <stratum>: Add "final".
 919
 920 2019-04-17  Tom Tromey  <tromey@adacore.com>
 921
 922         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 923         against nullptr before use.
 924
 925 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 926
 927         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 928
 929 2019-04-17  Jim Wilson  <jimw@sifive.com>
 930             Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 933         code read might fail, assume 4-byte breakpoint in that case.
 934
 935 2019-04-15  Leszek Swirski  <leszeks@google.com>
 936
 937         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 938         rather than a hand-rolled POD check when checking for forced MEMORY
 939         classification.
 940
 941 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 942
 943         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 944         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 945         function.
 946         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 947         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 948         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 949         declaration.
 950
 951 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 952
 953         * aarch64-linux-nat.c
 954         (aarch64_linux_nat_target::thread_architecture): Add override.
 955         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 956         each VQ.
 957
 958 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 959
 960         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 961
 962 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 963
 964         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 965         target types of size 96-bits, add some additional comments, and
 966         check that the builtin type we found was the correct size.
 967
 968 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 969
 970         * utils.c (prompt_for_continue): Don't restore the styling at the
 971         end, as applied_style has the wrong value.  This fixes styling in
 972         long lists of file names that are interrupted by the "Continue?"
 973         prompt.
 974
 975 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 976
 977         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 978         * c-lang.c (c_language_defn): Likewise.
 979         (cplus_language_defn): Likewise.
 980         (asm_language_defn): Likewise.
 981         (minimal_language_defn): Likewise.
 982         * d-lang.c (d_language_defn): Likewise.
 983         * f-lang.c (f_language_defn): Likewise.
 984         * go-lang.c (go_language_defn): Likewise.
 985         * language.c (unknown_language_defn): Likewise.
 986         (auto_language_defn): Likewise.
 987         * language.h (struct language_defn): Remove la_magic field.
 988         (LANG_MAGIC): Delete.
 989         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 990         * objc-lang.c (objc_language_defn): Likewise.
 991         * opencl-lang.c (opencl_language_defn): Likewise.
 992         * p-lang.c (pascal_language_defn): Likewise.
 993         * rust-lang.c (rust_language_defn): Likewise.
 994
 995 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 996
 997         * riscv-tdep.c (riscv_type_align): New function.
 998         (riscv_type_alignment): Delete.
 999         (riscv_arg_location): Use 'type_align'.
1000         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1001
1002 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1003
1004         * gdbtypes.c (type_align): A struct with no non-static fields also
1005         has alignment of 1.
1006
1007 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1010         component to 0.
1011         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1012         member.
1013         (riscv_struct_info::analyse): New implementation using new
1014         analyse_inner member function.
1015         (riscv_struct_info::field_offset): New member function.
1016         (riscv_struct_info::m_offsets): New member variable.
1017         (riscv_struct_info::analyse_inner): New private member function,
1018         takes the old implementation of riscv_struct_info::analyse but
1019         extended to track field offsets.
1020         (riscv_call_arg_struct): Update the struct folding special cases
1021         to handle cases where empty C++ structs, which are non-zero
1022         length, are found.
1023         (riscv_arg_location): Initialise the length of each location, a
1024         non-zero length now indicates the location is in use.
1025         (riscv_push_dummy_call): Allow for the first location having a
1026         non-zero offset when setting up arguments.
1027         (riscv_return_value): Likewise, but for return values.
1028
1029 2019-04-11  Tom Tromey  <tromey@adacore.com>
1030
1031         * utils.c (internal_vproblem): Make "msg" const.
1032
1033 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1034
1035         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1036         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1037         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1038         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1039
1040 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1041
1042         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1043         function.
1044         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1045         of amd64_collect_native_gregset.
1046         (amd64_linux_nat_target::store_registers): Likewise.
1047
1048 2019-04-10  Tom Tromey  <tom@tromey.com>
1049
1050         * symtab.c (lookup_global_symbol_from_objfile)
1051         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1052         * objfiles.h (class separate_debug_iterator): New.
1053         (class separate_debug_range): New.
1054         (struct objfile) <separate_debug_objfiles>: New method.
1055         (objfile_separate_debug_iterate): Don't declare.
1056         * objfiles.c (separate_debug_iterator::operator++): Rename from
1057         objfile_separate_debug_iterate.
1058         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1059         iterator.
1060         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1061         iterator.
1062
1063 2019-04-10  Tom Tromey  <tom@tromey.com>
1064
1065         * symfile.c (reread_symbols): Remove old comment.
1066         * objfiles.c (free_all_objfiles): Fix a typo.
1067
1068 2019-04-10  Tom Tromey  <tom@tromey.com>
1069
1070         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1071         * minsyms.c (lookup_minimal_symbol): Use foreach.
1072         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1073         (lookup_minimal_symbol_solib_trampoline): Likewise.
1074         * symfile.c (reread_symbols): Use foreach.
1075
1076 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1077             Tom Tromey  <tromey@adacore.com>
1078
1079         PR rust/24414:
1080         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1081         (rust_lex_int_test): Change "value" to be LONGEST.
1082         (rust_lex_tests): Add test for long integer literal.
1083
1084 2019-04-09  Tom Tromey  <tromey@adacore.com>
1085
1086         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1087         to bool.
1088         (extended_remote_target::attach): Update.
1089         (remote_target::remote_notice_new_inferior): Update.
1090         (remote_target::add_current_inferior_and_thread): Update.
1091         * inferior.c (exit_inferior_1): Use "false".
1092         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1093
1094 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1095
1096         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1097         the "start" command.
1098
1099 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1100
1101         * python/py-inferior.c (infpy_thread_from_thread_handle):
1102         Adjust comments to reflect renaming of thread_from_thread_handle
1103         to thread_from_handle.  Adjust keywords.  Fix type error message.
1104         (inferior_object_methods): Add thread_from_handle.  Retain
1105         thread_from_thread_handle, but mark it as deprecated.
1106
1107 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1108
1109         * gdbthread.h (find_thread_by_handle): Revise declaration.
1110         * thread.c (find_thread_by_handle): Likewise.  Adjust
1111         implementation too.
1112         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1113         support for buffer objects as handles.
1114
1115 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1116
1117         * python/py-infthread.c (thpy_thread_handle): New function.
1118         (thread_object_methods): Register thpy_thread_handle.
1119
1120 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1121
1122         * gdbthread.h (thread_to_thread_handle): Declare.
1123         * thread.c (gdbtypes.h): Include.
1124         (thread_to_thread_handle): New function.
1125
1126         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1127         (target_thread_info_to_thread_handle): Declare.
1128         * target.c (target_thread_info_to_thread_handle): New function.
1129         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1130         * target-delegates.c: Regenerate.
1131
1132         * linux-thread-db.c (class thread_db_target): Add method
1133         thread_info_to_thread_handle.
1134         (thread_db_target::thread_info_to_thread_handle): Define.
1135         * remote.c (class remote_target): Add new method
1136         thread_info_to_thread_handle.
1137         (remote_target::thread_info_to_thread_handle): Define.
1138
1139 2019-04-08  Pedro Alves  <palves@redhat.com>
1140
1141         * common/common-exceptions.c (throw_exception): Don't create
1142         named object to throw; throw directly.
1143         (throw_it): Likewise.  Don't initialize gdb_exception::message
1144         here, with new; pass FMT and AP to the ctor instead.
1145         * common/common-exceptions.h: Include <string>.
1146         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1147         const char *, va_list)): New ctor.  Use std::make_shared.
1148         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1149         errors)): Delete.
1150         (gdb_exception_error::gdb_exception_error(enum errors, const char
1151         *, va_list)): New.
1152         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1153         Add assertion.
1154         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1155         errors)): Delete.
1156         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1157         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1158         Add assertion.
1159
1160 2019-04-08  Tom Tromey  <tom@tromey.com>
1161
1162         * valops.c (value_rtti_indirect_type): Replace throw_exception
1163         with throw.
1164         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1165         with throw.
1166         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1167         throw.
1168         * target.c (target_translate_tls_address): Replace throw_exception
1169         with throw.
1170         * stack.c (frame_apply_command_count): Replace throw_exception
1171         with throw.
1172         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1173         throw.
1174         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1175         with throw.
1176         * rs6000-tdep.c (rs6000_frame_cache)
1177         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1178         * remote.c: Replace throw_exception with throw.
1179         * record-full.c (record_full_message, record_full_wait_1)
1180         (record_full_restore): Replace throw_exception with throw.
1181         * record-btrace.c:
1182         (get_thread_current_frame_id, record_btrace_start_replaying)
1183         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1184         (cmd_record_btrace_start): Replace throw_exception with throw.
1185         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1186         throw.
1187         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1188         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1189         * linespec.c:
1190         (find_linespec_symbols): Replace throw_exception with throw.
1191         * infrun.c (displaced_step_prepare, resume): Replace
1192         throw_exception with throw.
1193         * infcmd.c (post_create_inferior): Replace throw_exception with
1194         throw.
1195         * inf-loop.c (inferior_event_handler): Replace throw_exception
1196         with throw.
1197         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1198         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1199         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1200         (get_prev_frame_always, get_frame_pc_if_available)
1201         (get_frame_address_in_block_if_available, get_frame_language):
1202         Replace throw_exception with throw.
1203         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1204         throw_exception with throw.
1205         * eval.c (fetch_subexp_value, evaluate_var_value)
1206         (evaluate_funcall, evaluate_subexp_standard): Replace
1207         throw_exception with throw.
1208         * dwarf2loc.c (call_site_find_chain)
1209         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1210         Replace throw_exception with throw.
1211         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1212         with throw.
1213         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1214         throw.
1215         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1216         * completer.c (complete_line_internal): Replace throw_exception
1217         with throw.
1218         * compile/compile-object-run.c (compile_object_run): Replace
1219         throw_exception with throw.
1220         * cli/cli-script.c (process_next_line): Replace throw_exception
1221         with throw.
1222         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1223         (btrace_enable, btrace_maint_update_pt_packets): Replace
1224         throw_exception with throw.
1225         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1226         throw_exception with throw.
1227         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1228         throw_exception with throw.
1229         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1230         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1231         * aarch64-tdep.c (aarch64_make_prologue_cache)
1232         (aarch64_make_stub_cache): Replace throw_exception with throw.
1233
1234 2019-04-08  Tom Tromey  <tom@tromey.com>
1235
1236         * common/common-exceptions.c (throw_exception): Rename from
1237         throw_exception_cxx.  Remove old copy.  Make argument const.
1238         (throw_it): Create and throw exception objects directly.
1239         * common/common-exceptions.h (throw_exception): Make argument
1240         const.
1241         (struct gdb_exception_error): Add constructor.
1242         (struct gdb_exception_quit): Add constructor.
1243
1244 2019-04-08  Tom Tromey  <tom@tromey.com>
1245
1246         * common/common-exceptions.h (exception_rethrow): Don't declare.
1247         (TRY_SJLJ): Update comment.
1248         (TRY, CATCH, END_CATCH): Remove.
1249         * common/common-exceptions.c (exception_rethrow): Remove.
1250
1251 2019-04-08  Tom Tromey  <tom@tromey.com>
1252
1253         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1254         Remove.
1255         (gdb_exception_error): Rename from
1256         gdb_exception_RETURN_MASK_ERROR.
1257         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1258         (gdb_quit_bad_alloc): Update.
1259         * aarch64-tdep.c: Update.
1260         * ada-lang.c: Update.
1261         * ada-typeprint.c: Update.
1262         * ada-valprint.c: Update.
1263         * amd64-tdep.c: Update.
1264         * arch-utils.c: Update.
1265         * break-catch-throw.c: Update.
1266         * breakpoint.c: Update.
1267         * btrace.c: Update.
1268         * c-varobj.c: Update.
1269         * cli/cli-cmds.c: Update.
1270         * cli/cli-interp.c: Update.
1271         * cli/cli-script.c: Update.
1272         * common/common-exceptions.c: Update.
1273         * common/new-op.c: Update.
1274         * common/selftest.c: Update.
1275         * compile/compile-c-symbols.c: Update.
1276         * compile/compile-cplus-symbols.c: Update.
1277         * compile/compile-object-load.c: Update.
1278         * compile/compile-object-run.c: Update.
1279         * completer.c: Update.
1280         * corelow.c: Update.
1281         * cp-abi.c: Update.
1282         * cp-support.c: Update.
1283         * cp-valprint.c: Update.
1284         * darwin-nat.c: Update.
1285         * disasm-selftests.c: Update.
1286         * dtrace-probe.c: Update.
1287         * dwarf-index-cache.c: Update.
1288         * dwarf-index-write.c: Update.
1289         * dwarf2-frame-tailcall.c: Update.
1290         * dwarf2-frame.c: Update.
1291         * dwarf2loc.c: Update.
1292         * dwarf2read.c: Update.
1293         * eval.c: Update.
1294         * event-loop.c: Update.
1295         * event-top.c: Update.
1296         * exec.c: Update.
1297         * f-valprint.c: Update.
1298         * fbsd-tdep.c: Update.
1299         * frame-unwind.c: Update.
1300         * frame.c: Update.
1301         * gdbtypes.c: Update.
1302         * gnu-v3-abi.c: Update.
1303         * guile/guile-internal.h: Update.
1304         * guile/scm-block.c: Update.
1305         * guile/scm-breakpoint.c: Update.
1306         * guile/scm-cmd.c: Update.
1307         * guile/scm-disasm.c: Update.
1308         * guile/scm-frame.c: Update.
1309         * guile/scm-lazy-string.c: Update.
1310         * guile/scm-math.c: Update.
1311         * guile/scm-param.c: Update.
1312         * guile/scm-ports.c: Update.
1313         * guile/scm-pretty-print.c: Update.
1314         * guile/scm-symbol.c: Update.
1315         * guile/scm-symtab.c: Update.
1316         * guile/scm-type.c: Update.
1317         * guile/scm-value.c: Update.
1318         * i386-linux-tdep.c: Update.
1319         * i386-tdep.c: Update.
1320         * inf-loop.c: Update.
1321         * infcall.c: Update.
1322         * infcmd.c: Update.
1323         * infrun.c: Update.
1324         * jit.c: Update.
1325         * language.c: Update.
1326         * linespec.c: Update.
1327         * linux-fork.c: Update.
1328         * linux-nat.c: Update.
1329         * linux-tdep.c: Update.
1330         * linux-thread-db.c: Update.
1331         * main.c: Update.
1332         * mi/mi-cmd-break.c: Update.
1333         * mi/mi-cmd-stack.c: Update.
1334         * mi/mi-interp.c: Update.
1335         * mi/mi-main.c: Update.
1336         * objc-lang.c: Update.
1337         * p-valprint.c: Update.
1338         * parse.c: Update.
1339         * ppc-linux-tdep.c: Update.
1340         * printcmd.c: Update.
1341         * python/py-arch.c: Update.
1342         * python/py-breakpoint.c: Update.
1343         * python/py-cmd.c: Update.
1344         * python/py-finishbreakpoint.c: Update.
1345         * python/py-frame.c: Update.
1346         * python/py-framefilter.c: Update.
1347         * python/py-gdb-readline.c: Update.
1348         * python/py-inferior.c: Update.
1349         * python/py-infthread.c: Update.
1350         * python/py-lazy-string.c: Update.
1351         * python/py-linetable.c: Update.
1352         * python/py-objfile.c: Update.
1353         * python/py-param.c: Update.
1354         * python/py-prettyprint.c: Update.
1355         * python/py-progspace.c: Update.
1356         * python/py-record-btrace.c: Update.
1357         * python/py-record.c: Update.
1358         * python/py-symbol.c: Update.
1359         * python/py-type.c: Update.
1360         * python/py-unwind.c: Update.
1361         * python/py-utils.c: Update.
1362         * python/py-value.c: Update.
1363         * python/python.c: Update.
1364         * record-btrace.c: Update.
1365         * record-full.c: Update.
1366         * remote-fileio.c: Update.
1367         * remote.c: Update.
1368         * riscv-tdep.c: Update.
1369         * rs6000-aix-tdep.c: Update.
1370         * rs6000-tdep.c: Update.
1371         * rust-exp.y: Update.
1372         * rust-lang.c: Update.
1373         * s390-tdep.c: Update.
1374         * selftest-arch.c: Update.
1375         * solib-dsbt.c: Update.
1376         * solib-frv.c: Update.
1377         * solib-spu.c: Update.
1378         * solib-svr4.c: Update.
1379         * solib.c: Update.
1380         * sparc64-linux-tdep.c: Update.
1381         * stack.c: Update.
1382         * symfile-mem.c: Update.
1383         * symmisc.c: Update.
1384         * target.c: Update.
1385         * thread.c: Update.
1386         * top.c: Update.
1387         * tracefile-tfile.c: Update.
1388         * tui/tui.c: Update.
1389         * typeprint.c: Update.
1390         * unittests/cli-utils-selftests.c: Update.
1391         * unittests/parse-connection-spec-selftests.c: Update.
1392         * valops.c: Update.
1393         * valprint.c: Update.
1394         * value.c: Update.
1395         * varobj.c: Update.
1396         * windows-nat.c: Update.
1397         * x86-linux-nat.c: Update.
1398         * xml-support.c: Update.
1399
1400 2019-04-08  Tom Tromey  <tom@tromey.com>
1401
1402         * xml-support.c: Use C++ exception handling.
1403         * x86-linux-nat.c: Use C++ exception handling.
1404         * windows-nat.c: Use C++ exception handling.
1405         * varobj.c: Use C++ exception handling.
1406         * value.c: Use C++ exception handling.
1407         * valprint.c: Use C++ exception handling.
1408         * valops.c: Use C++ exception handling.
1409         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1410         handling.
1411         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1412         * typeprint.c: Use C++ exception handling.
1413         * tui/tui.c: Use C++ exception handling.
1414         * tracefile-tfile.c: Use C++ exception handling.
1415         * top.c: Use C++ exception handling.
1416         * thread.c: Use C++ exception handling.
1417         * target.c: Use C++ exception handling.
1418         * symmisc.c: Use C++ exception handling.
1419         * symfile-mem.c: Use C++ exception handling.
1420         * stack.c: Use C++ exception handling.
1421         * sparc64-linux-tdep.c: Use C++ exception handling.
1422         * solib.c: Use C++ exception handling.
1423         * solib-svr4.c: Use C++ exception handling.
1424         * solib-spu.c: Use C++ exception handling.
1425         * solib-frv.c: Use C++ exception handling.
1426         * solib-dsbt.c: Use C++ exception handling.
1427         * selftest-arch.c: Use C++ exception handling.
1428         * s390-tdep.c: Use C++ exception handling.
1429         * rust-lang.c: Use C++ exception handling.
1430         * rust-exp.y: Use C++ exception handling.
1431         * rs6000-tdep.c: Use C++ exception handling.
1432         * rs6000-aix-tdep.c: Use C++ exception handling.
1433         * riscv-tdep.c: Use C++ exception handling.
1434         * remote.c: Use C++ exception handling.
1435         * remote-fileio.c: Use C++ exception handling.
1436         * record-full.c: Use C++ exception handling.
1437         * record-btrace.c: Use C++ exception handling.
1438         * python/python.c: Use C++ exception handling.
1439         * python/py-value.c: Use C++ exception handling.
1440         * python/py-utils.c: Use C++ exception handling.
1441         * python/py-unwind.c: Use C++ exception handling.
1442         * python/py-type.c: Use C++ exception handling.
1443         * python/py-symbol.c: Use C++ exception handling.
1444         * python/py-record.c: Use C++ exception handling.
1445         * python/py-record-btrace.c: Use C++ exception handling.
1446         * python/py-progspace.c: Use C++ exception handling.
1447         * python/py-prettyprint.c: Use C++ exception handling.
1448         * python/py-param.c: Use C++ exception handling.
1449         * python/py-objfile.c: Use C++ exception handling.
1450         * python/py-linetable.c: Use C++ exception handling.
1451         * python/py-lazy-string.c: Use C++ exception handling.
1452         * python/py-infthread.c: Use C++ exception handling.
1453         * python/py-inferior.c: Use C++ exception handling.
1454         * python/py-gdb-readline.c: Use C++ exception handling.
1455         * python/py-framefilter.c: Use C++ exception handling.
1456         * python/py-frame.c: Use C++ exception handling.
1457         * python/py-finishbreakpoint.c: Use C++ exception handling.
1458         * python/py-cmd.c: Use C++ exception handling.
1459         * python/py-breakpoint.c: Use C++ exception handling.
1460         * python/py-arch.c: Use C++ exception handling.
1461         * printcmd.c: Use C++ exception handling.
1462         * ppc-linux-tdep.c: Use C++ exception handling.
1463         * parse.c: Use C++ exception handling.
1464         * p-valprint.c: Use C++ exception handling.
1465         * objc-lang.c: Use C++ exception handling.
1466         * mi/mi-main.c: Use C++ exception handling.
1467         * mi/mi-interp.c: Use C++ exception handling.
1468         * mi/mi-cmd-stack.c: Use C++ exception handling.
1469         * mi/mi-cmd-break.c: Use C++ exception handling.
1470         * main.c: Use C++ exception handling.
1471         * linux-thread-db.c: Use C++ exception handling.
1472         * linux-tdep.c: Use C++ exception handling.
1473         * linux-nat.c: Use C++ exception handling.
1474         * linux-fork.c: Use C++ exception handling.
1475         * linespec.c: Use C++ exception handling.
1476         * language.c: Use C++ exception handling.
1477         * jit.c: Use C++ exception handling.
1478         * infrun.c: Use C++ exception handling.
1479         * infcmd.c: Use C++ exception handling.
1480         * infcall.c: Use C++ exception handling.
1481         * inf-loop.c: Use C++ exception handling.
1482         * i386-tdep.c: Use C++ exception handling.
1483         * i386-linux-tdep.c: Use C++ exception handling.
1484         * guile/scm-value.c: Use C++ exception handling.
1485         * guile/scm-type.c: Use C++ exception handling.
1486         * guile/scm-symtab.c: Use C++ exception handling.
1487         * guile/scm-symbol.c: Use C++ exception handling.
1488         * guile/scm-pretty-print.c: Use C++ exception handling.
1489         * guile/scm-ports.c: Use C++ exception handling.
1490         * guile/scm-param.c: Use C++ exception handling.
1491         * guile/scm-math.c: Use C++ exception handling.
1492         * guile/scm-lazy-string.c: Use C++ exception handling.
1493         * guile/scm-frame.c: Use C++ exception handling.
1494         * guile/scm-disasm.c: Use C++ exception handling.
1495         * guile/scm-cmd.c: Use C++ exception handling.
1496         * guile/scm-breakpoint.c: Use C++ exception handling.
1497         * guile/scm-block.c: Use C++ exception handling.
1498         * guile/guile-internal.h: Use C++ exception handling.
1499         * gnu-v3-abi.c: Use C++ exception handling.
1500         * gdbtypes.c: Use C++ exception handling.
1501         * frame.c: Use C++ exception handling.
1502         * frame-unwind.c: Use C++ exception handling.
1503         * fbsd-tdep.c: Use C++ exception handling.
1504         * f-valprint.c: Use C++ exception handling.
1505         * exec.c: Use C++ exception handling.
1506         * event-top.c: Use C++ exception handling.
1507         * event-loop.c: Use C++ exception handling.
1508         * eval.c: Use C++ exception handling.
1509         * dwarf2read.c: Use C++ exception handling.
1510         * dwarf2loc.c: Use C++ exception handling.
1511         * dwarf2-frame.c: Use C++ exception handling.
1512         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1513         * dwarf-index-write.c: Use C++ exception handling.
1514         * dwarf-index-cache.c: Use C++ exception handling.
1515         * dtrace-probe.c: Use C++ exception handling.
1516         * disasm-selftests.c: Use C++ exception handling.
1517         * darwin-nat.c: Use C++ exception handling.
1518         * cp-valprint.c: Use C++ exception handling.
1519         * cp-support.c: Use C++ exception handling.
1520         * cp-abi.c: Use C++ exception handling.
1521         * corelow.c: Use C++ exception handling.
1522         * completer.c: Use C++ exception handling.
1523         * compile/compile-object-run.c: Use C++ exception handling.
1524         * compile/compile-object-load.c: Use C++ exception handling.
1525         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1526         * compile/compile-c-symbols.c: Use C++ exception handling.
1527         * common/selftest.c: Use C++ exception handling.
1528         * common/new-op.c: Use C++ exception handling.
1529         * cli/cli-script.c: Use C++ exception handling.
1530         * cli/cli-interp.c: Use C++ exception handling.
1531         * cli/cli-cmds.c: Use C++ exception handling.
1532         * c-varobj.c: Use C++ exception handling.
1533         * btrace.c: Use C++ exception handling.
1534         * breakpoint.c: Use C++ exception handling.
1535         * break-catch-throw.c: Use C++ exception handling.
1536         * arch-utils.c: Use C++ exception handling.
1537         * amd64-tdep.c: Use C++ exception handling.
1538         * ada-valprint.c: Use C++ exception handling.
1539         * ada-typeprint.c: Use C++ exception handling.
1540         * ada-lang.c: Use C++ exception handling.
1541         * aarch64-tdep.c: Use C++ exception handling.
1542
1543 2019-04-08  Tom Tromey  <tom@tromey.com>
1544
1545         * xml-support.c (gdb_xml_parser::parse): Update.
1546         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1547         * value.c (show_convenience): Update.
1548         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1549         (test_parse_flags_qcs): Update.
1550         * thread.c (thr_try_catch_cmd): Update.
1551         * target.c (target_translate_tls_address): Update.
1552         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1553         (info_frame_command_core, frame_apply_command_count): Update.
1554         * rust-exp.y (rust_lex_exception_test): Update.
1555         * riscv-tdep.c (riscv_print_one_register_info): Update.
1556         * remote.c (remote_target::enable_btrace): Update.
1557         * record-btrace.c (record_btrace_enable_warn): Update.
1558         * python/py-utils.c (gdbpy_convert_exception): Update.
1559         * printcmd.c (do_one_display, print_variable_and_value): Update.
1560         * mi/mi-main.c (mi_print_exception): Update.
1561         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1562         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1563         * linux-nat.c (linux_nat_target::attach): Update.
1564         * linux-fork.c (class scoped_switch_fork_info): Update.
1565         * infrun.c (displaced_step_prepare): Update.
1566         * infcall.c (call_function_by_hand_dummy): Update.
1567         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1568         * gnu-v3-abi.c (print_one_vtable): Update.
1569         * frame.c (get_prev_frame_always): Update.
1570         * f-valprint.c (info_common_command_for_block): Update.
1571         * exec.c (try_open_exec_file): Update.
1572         * exceptions.c (print_exception, exception_print)
1573         (exception_fprintf, exception_print_same): Update.
1574         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1575         * dwarf-index-cache.c (index_cache::store)
1576         (index_cache::lookup_gdb_index): Update.
1577         * darwin-nat.c (maybe_cache_shell): Update.
1578         * cp-valprint.c (cp_print_value_fields): Update.
1579         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1580         (gcc_cplus_symbol_address): Update.
1581         * compile/compile-c-symbols.c (gcc_convert_symbol)
1582         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1583         * common/selftest.c: Update.
1584         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1585         a std::string.
1586         (exception_try_scope_entry, exception_try_scope_exit): Don't
1587         declare.
1588         (struct exception_try_scope): Remove.
1589         (TRY): Don't use exception_try_scope.
1590         (struct gdb_exception): Add constructor, operator=.
1591         <what>: New method.
1592         (struct gdb_exception_RETURN_MASK_ALL)
1593         (struct gdb_exception_RETURN_MASK_ERROR)
1594         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1595         (struct gdb_quit_bad_alloc): Update.
1596         * common/common-exceptions.c (exception_none): Change
1597         initializer.
1598         (struct catcher) <state, exception>: Initialize inline.
1599         <prev>: Remove member.
1600         (current_catcher): Remove.
1601         (catchers): New global.
1602         (exceptions_state_mc_init): Simplify.
1603         (catcher_pop): Remove.
1604         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1605         (try_scope_depth, exception_try_scope_entry)
1606         (exception_try_scope_exit): Remove.
1607         (throw_exception_sjlj): Update.
1608         (exception_messages, exception_messages_size): Remove.
1609         (throw_it): Simplify.
1610         (gdb_exception_sliced_copy): Remove.
1611         (throw_exception_cxx): Update.
1612         * cli/cli-script.c (script_from_file): Update.
1613         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1614         Update.
1615         * ada-valprint.c (ada_val_print): Update.
1616         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1617         (create_excep_cond_exprs): Update.
1618
1619 2019-04-08  Tom Tromey  <tom@tromey.com>
1620
1621         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1622         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1623         (TRY, CATCH, END_CATCH): Remove some definitions.
1624         * common/common-exceptions.c: Don't use GDB_XCPT.
1625         (catcher_list_size): Remove.
1626         (throw_exception, throw_it): Simplify.
1627
1628 2019-04-05  Tom Tromey  <tom@tromey.com>
1629
1630         Revert the header-sorting patch.
1631         * ft32-tdep.c: Revert.
1632         * frv-tdep.c: Revert.
1633         * frv-linux-tdep.c: Revert.
1634         * frame.c: Revert.
1635         * frame-unwind.c: Revert.
1636         * frame-base.c: Revert.
1637         * fork-child.c: Revert.
1638         * findvar.c: Revert.
1639         * findcmd.c: Revert.
1640         * filesystem.c: Revert.
1641         * filename-seen-cache.h: Revert.
1642         * filename-seen-cache.c: Revert.
1643         * fbsd-tdep.c: Revert.
1644         * fbsd-nat.h: Revert.
1645         * fbsd-nat.c: Revert.
1646         * f-valprint.c: Revert.
1647         * f-typeprint.c: Revert.
1648         * f-lang.c: Revert.
1649         * extension.h: Revert.
1650         * extension.c: Revert.
1651         * extension-priv.h: Revert.
1652         * expprint.c: Revert.
1653         * exec.h: Revert.
1654         * exec.c: Revert.
1655         * exceptions.c: Revert.
1656         * event-top.c: Revert.
1657         * event-loop.c: Revert.
1658         * eval.c: Revert.
1659         * elfread.c: Revert.
1660         * dwarf2read.h: Revert.
1661         * dwarf2read.c: Revert.
1662         * dwarf2loc.c: Revert.
1663         * dwarf2expr.h: Revert.
1664         * dwarf2expr.c: Revert.
1665         * dwarf2-frame.c: Revert.
1666         * dwarf2-frame-tailcall.c: Revert.
1667         * dwarf-index-write.h: Revert.
1668         * dwarf-index-write.c: Revert.
1669         * dwarf-index-common.c: Revert.
1670         * dwarf-index-cache.h: Revert.
1671         * dwarf-index-cache.c: Revert.
1672         * dummy-frame.c: Revert.
1673         * dtrace-probe.c: Revert.
1674         * disasm.h: Revert.
1675         * disasm.c: Revert.
1676         * disasm-selftests.c: Revert.
1677         * dictionary.c: Revert.
1678         * dicos-tdep.c: Revert.
1679         * demangle.c: Revert.
1680         * dcache.h: Revert.
1681         * dcache.c: Revert.
1682         * darwin-nat.h: Revert.
1683         * darwin-nat.c: Revert.
1684         * darwin-nat-info.c: Revert.
1685         * d-valprint.c: Revert.
1686         * d-namespace.c: Revert.
1687         * d-lang.c: Revert.
1688         * ctf.c: Revert.
1689         * csky-tdep.c: Revert.
1690         * csky-linux-tdep.c: Revert.
1691         * cris-tdep.c: Revert.
1692         * cris-linux-tdep.c: Revert.
1693         * cp-valprint.c: Revert.
1694         * cp-support.c: Revert.
1695         * cp-namespace.c: Revert.
1696         * cp-abi.c: Revert.
1697         * corelow.c: Revert.
1698         * corefile.c: Revert.
1699         * continuations.c: Revert.
1700         * completer.h: Revert.
1701         * completer.c: Revert.
1702         * complaints.c: Revert.
1703         * coffread.c: Revert.
1704         * coff-pe-read.c: Revert.
1705         * cli-out.h: Revert.
1706         * cli-out.c: Revert.
1707         * charset.c: Revert.
1708         * c-varobj.c: Revert.
1709         * c-valprint.c: Revert.
1710         * c-typeprint.c: Revert.
1711         * c-lang.c: Revert.
1712         * buildsym.c: Revert.
1713         * buildsym-legacy.c: Revert.
1714         * build-id.h: Revert.
1715         * build-id.c: Revert.
1716         * btrace.c: Revert.
1717         * bsd-uthread.c: Revert.
1718         * breakpoint.h: Revert.
1719         * breakpoint.c: Revert.
1720         * break-catch-throw.c: Revert.
1721         * break-catch-syscall.c: Revert.
1722         * break-catch-sig.c: Revert.
1723         * blockframe.c: Revert.
1724         * block.c: Revert.
1725         * bfin-tdep.c: Revert.
1726         * bfin-linux-tdep.c: Revert.
1727         * bfd-target.c: Revert.
1728         * bcache.c: Revert.
1729         * ax-general.c: Revert.
1730         * ax-gdb.h: Revert.
1731         * ax-gdb.c: Revert.
1732         * avr-tdep.c: Revert.
1733         * auxv.c: Revert.
1734         * auto-load.c: Revert.
1735         * arm-wince-tdep.c: Revert.
1736         * arm-tdep.c: Revert.
1737         * arm-symbian-tdep.c: Revert.
1738         * arm-pikeos-tdep.c: Revert.
1739         * arm-obsd-tdep.c: Revert.
1740         * arm-nbsd-tdep.c: Revert.
1741         * arm-nbsd-nat.c: Revert.
1742         * arm-linux-tdep.c: Revert.
1743         * arm-linux-nat.c: Revert.
1744         * arm-fbsd-tdep.c: Revert.
1745         * arm-fbsd-nat.c: Revert.
1746         * arm-bsd-tdep.c: Revert.
1747         * arch-utils.c: Revert.
1748         * arc-tdep.c: Revert.
1749         * arc-newlib-tdep.c: Revert.
1750         * annotate.h: Revert.
1751         * annotate.c: Revert.
1752         * amd64-windows-tdep.c: Revert.
1753         * amd64-windows-nat.c: Revert.
1754         * amd64-tdep.c: Revert.
1755         * amd64-sol2-tdep.c: Revert.
1756         * amd64-obsd-tdep.c: Revert.
1757         * amd64-obsd-nat.c: Revert.
1758         * amd64-nbsd-tdep.c: Revert.
1759         * amd64-nbsd-nat.c: Revert.
1760         * amd64-nat.c: Revert.
1761         * amd64-linux-tdep.c: Revert.
1762         * amd64-linux-nat.c: Revert.
1763         * amd64-fbsd-tdep.c: Revert.
1764         * amd64-fbsd-nat.c: Revert.
1765         * amd64-dicos-tdep.c: Revert.
1766         * amd64-darwin-tdep.c: Revert.
1767         * amd64-bsd-nat.c: Revert.
1768         * alpha-tdep.c: Revert.
1769         * alpha-obsd-tdep.c: Revert.
1770         * alpha-nbsd-tdep.c: Revert.
1771         * alpha-mdebug-tdep.c: Revert.
1772         * alpha-linux-tdep.c: Revert.
1773         * alpha-linux-nat.c: Revert.
1774         * alpha-bsd-tdep.c: Revert.
1775         * alpha-bsd-nat.c: Revert.
1776         * aix-thread.c: Revert.
1777         * agent.c: Revert.
1778         * addrmap.c: Revert.
1779         * ada-varobj.c: Revert.
1780         * ada-valprint.c: Revert.
1781         * ada-typeprint.c: Revert.
1782         * ada-tasks.c: Revert.
1783         * ada-lang.c: Revert.
1784         * aarch64-tdep.c: Revert.
1785         * aarch64-ravenscar-thread.c: Revert.
1786         * aarch64-newlib-tdep.c: Revert.
1787         * aarch64-linux-tdep.c: Revert.
1788         * aarch64-linux-nat.c: Revert.
1789         * aarch64-fbsd-tdep.c: Revert.
1790         * aarch64-fbsd-nat.c: Revert.
1791         * aarch32-linux-nat.c: Revert.
1792
1793 2019-04-05  Tom Tromey  <tom@tromey.com>
1794
1795         * ft32-tdep.c: Sort headers.
1796         * frv-tdep.c: Sort headers.
1797         * frv-linux-tdep.c: Sort headers.
1798         * frame.c: Sort headers.
1799         * frame-unwind.c: Sort headers.
1800         * frame-base.c: Sort headers.
1801         * fork-child.c: Sort headers.
1802         * findvar.c: Sort headers.
1803         * findcmd.c: Sort headers.
1804         * filesystem.c: Sort headers.
1805         * filename-seen-cache.h: Sort headers.
1806         * filename-seen-cache.c: Sort headers.
1807         * fbsd-tdep.c: Sort headers.
1808         * fbsd-nat.h: Sort headers.
1809         * fbsd-nat.c: Sort headers.
1810         * f-valprint.c: Sort headers.
1811         * f-typeprint.c: Sort headers.
1812         * f-lang.c: Sort headers.
1813         * extension.h: Sort headers.
1814         * extension.c: Sort headers.
1815         * extension-priv.h: Sort headers.
1816         * expprint.c: Sort headers.
1817         * exec.h: Sort headers.
1818         * exec.c: Sort headers.
1819         * exceptions.c: Sort headers.
1820         * event-top.c: Sort headers.
1821         * event-loop.c: Sort headers.
1822         * eval.c: Sort headers.
1823         * elfread.c: Sort headers.
1824         * dwarf2read.h: Sort headers.
1825         * dwarf2read.c: Sort headers.
1826         * dwarf2loc.c: Sort headers.
1827         * dwarf2expr.h: Sort headers.
1828         * dwarf2expr.c: Sort headers.
1829         * dwarf2-frame.c: Sort headers.
1830         * dwarf2-frame-tailcall.c: Sort headers.
1831         * dwarf-index-write.h: Sort headers.
1832         * dwarf-index-write.c: Sort headers.
1833         * dwarf-index-common.c: Sort headers.
1834         * dwarf-index-cache.h: Sort headers.
1835         * dwarf-index-cache.c: Sort headers.
1836         * dummy-frame.c: Sort headers.
1837         * dtrace-probe.c: Sort headers.
1838         * disasm.h: Sort headers.
1839         * disasm.c: Sort headers.
1840         * disasm-selftests.c: Sort headers.
1841         * dictionary.c: Sort headers.
1842         * dicos-tdep.c: Sort headers.
1843         * demangle.c: Sort headers.
1844         * dcache.h: Sort headers.
1845         * dcache.c: Sort headers.
1846         * darwin-nat.h: Sort headers.
1847         * darwin-nat.c: Sort headers.
1848         * darwin-nat-info.c: Sort headers.
1849         * d-valprint.c: Sort headers.
1850         * d-namespace.c: Sort headers.
1851         * d-lang.c: Sort headers.
1852         * ctf.c: Sort headers.
1853         * csky-tdep.c: Sort headers.
1854         * csky-linux-tdep.c: Sort headers.
1855         * cris-tdep.c: Sort headers.
1856         * cris-linux-tdep.c: Sort headers.
1857         * cp-valprint.c: Sort headers.
1858         * cp-support.c: Sort headers.
1859         * cp-namespace.c: Sort headers.
1860         * cp-abi.c: Sort headers.
1861         * corelow.c: Sort headers.
1862         * corefile.c: Sort headers.
1863         * continuations.c: Sort headers.
1864         * completer.h: Sort headers.
1865         * completer.c: Sort headers.
1866         * complaints.c: Sort headers.
1867         * coffread.c: Sort headers.
1868         * coff-pe-read.c: Sort headers.
1869         * cli-out.h: Sort headers.
1870         * cli-out.c: Sort headers.
1871         * charset.c: Sort headers.
1872         * c-varobj.c: Sort headers.
1873         * c-valprint.c: Sort headers.
1874         * c-typeprint.c: Sort headers.
1875         * c-lang.c: Sort headers.
1876         * buildsym.c: Sort headers.
1877         * buildsym-legacy.c: Sort headers.
1878         * build-id.h: Sort headers.
1879         * build-id.c: Sort headers.
1880         * btrace.c: Sort headers.
1881         * bsd-uthread.c: Sort headers.
1882         * breakpoint.h: Sort headers.
1883         * breakpoint.c: Sort headers.
1884         * break-catch-throw.c: Sort headers.
1885         * break-catch-syscall.c: Sort headers.
1886         * break-catch-sig.c: Sort headers.
1887         * blockframe.c: Sort headers.
1888         * block.c: Sort headers.
1889         * bfin-tdep.c: Sort headers.
1890         * bfin-linux-tdep.c: Sort headers.
1891         * bfd-target.c: Sort headers.
1892         * bcache.c: Sort headers.
1893         * ax-general.c: Sort headers.
1894         * ax-gdb.h: Sort headers.
1895         * ax-gdb.c: Sort headers.
1896         * avr-tdep.c: Sort headers.
1897         * auxv.c: Sort headers.
1898         * auto-load.c: Sort headers.
1899         * arm-wince-tdep.c: Sort headers.
1900         * arm-tdep.c: Sort headers.
1901         * arm-symbian-tdep.c: Sort headers.
1902         * arm-pikeos-tdep.c: Sort headers.
1903         * arm-obsd-tdep.c: Sort headers.
1904         * arm-nbsd-tdep.c: Sort headers.
1905         * arm-nbsd-nat.c: Sort headers.
1906         * arm-linux-tdep.c: Sort headers.
1907         * arm-linux-nat.c: Sort headers.
1908         * arm-fbsd-tdep.c: Sort headers.
1909         * arm-fbsd-nat.c: Sort headers.
1910         * arm-bsd-tdep.c: Sort headers.
1911         * arch-utils.c: Sort headers.
1912         * arc-tdep.c: Sort headers.
1913         * arc-newlib-tdep.c: Sort headers.
1914         * annotate.h: Sort headers.
1915         * annotate.c: Sort headers.
1916         * amd64-windows-tdep.c: Sort headers.
1917         * amd64-windows-nat.c: Sort headers.
1918         * amd64-tdep.c: Sort headers.
1919         * amd64-sol2-tdep.c: Sort headers.
1920         * amd64-obsd-tdep.c: Sort headers.
1921         * amd64-obsd-nat.c: Sort headers.
1922         * amd64-nbsd-tdep.c: Sort headers.
1923         * amd64-nbsd-nat.c: Sort headers.
1924         * amd64-nat.c: Sort headers.
1925         * amd64-linux-tdep.c: Sort headers.
1926         * amd64-linux-nat.c: Sort headers.
1927         * amd64-fbsd-tdep.c: Sort headers.
1928         * amd64-fbsd-nat.c: Sort headers.
1929         * amd64-dicos-tdep.c: Sort headers.
1930         * amd64-darwin-tdep.c: Sort headers.
1931         * amd64-bsd-nat.c: Sort headers.
1932         * alpha-tdep.c: Sort headers.
1933         * alpha-obsd-tdep.c: Sort headers.
1934         * alpha-nbsd-tdep.c: Sort headers.
1935         * alpha-mdebug-tdep.c: Sort headers.
1936         * alpha-linux-tdep.c: Sort headers.
1937         * alpha-linux-nat.c: Sort headers.
1938         * alpha-bsd-tdep.c: Sort headers.
1939         * alpha-bsd-nat.c: Sort headers.
1940         * aix-thread.c: Sort headers.
1941         * agent.c: Sort headers.
1942         * addrmap.c: Sort headers.
1943         * ada-varobj.c: Sort headers.
1944         * ada-valprint.c: Sort headers.
1945         * ada-typeprint.c: Sort headers.
1946         * ada-tasks.c: Sort headers.
1947         * ada-lang.c: Sort headers.
1948         * aarch64-tdep.c: Sort headers.
1949         * aarch64-ravenscar-thread.c: Sort headers.
1950         * aarch64-newlib-tdep.c: Sort headers.
1951         * aarch64-linux-tdep.c: Sort headers.
1952         * aarch64-linux-nat.c: Sort headers.
1953         * aarch64-fbsd-tdep.c: Sort headers.
1954         * aarch64-fbsd-nat.c: Sort headers.
1955         * aarch32-linux-nat.c: Sort headers.
1956
1957 2019-04-04  Tom Tromey  <tom@tromey.com>
1958
1959         * varobj.c (varobj_create): Update.
1960         * rust-exp.y (struct rust_parser) <update_innermost_block,
1961         lookup_symbol>: New methods.
1962         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1963         Rename.
1964         (rust_parser::rust_lookup_type)
1965         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1966         * printcmd.c (display_command, do_one_display): Update.
1967         * parser-defs.h (struct parser_state) <parser_state>: Add
1968         "tracker" parameter.
1969         (block_tracker): New member.
1970         (class innermost_block_tracker) <innermost_block_tracker>: Add
1971         "types" parameter.
1972         <reset>: Remove method.
1973         (innermost_block): Don't declare.
1974         (null_post_parser): Update.
1975         * parse.c (innermost_block): Remove global.
1976         (write_dollar_variable): Update.
1977         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1978         Remove "tracker_types" parameter.
1979         (parse_expression): Add "tracker" parameter.
1980         (parse_expression_for_completion): Update.
1981         (null_post_parser): Add "tracker" parameter.
1982         * p-exp.y: Update rules.
1983         * m2-exp.y: Update rules.
1984         * language.h (struct language_defn) <la_post_parser>: Add
1985         "tracker" parameter.
1986         * go-exp.y: Update rules.
1987         * f-exp.y: Update rules.
1988         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1989         parameter.
1990         * d-exp.y: Update rules.
1991         * c-exp.y: Update rules.
1992         * breakpoint.c (set_breakpoint_condition): Create an
1993         innermost_block_tracker.
1994         (watch_command_1): Likewise.
1995         * ada-lang.c (resolve): Add "tracker" parameter.
1996         (resolve_subexp): Likewise.
1997         * ada-exp.y (write_var_from_sym): Update.
1998
1999 2019-04-04  Tom Tromey  <tom@tromey.com>
2000
2001         * type-stack.h: New file.
2002         * type-stack.c: New file.
2003         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2004         type-stack.h.
2005         (insert_into_type_stack, insert_type, push_type, push_type_int)
2006         (insert_type_address_space, pop_type, pop_type_int)
2007         (pop_typelist, pop_type_stack, append_type_stack)
2008         (push_type_stack, get_type_stack, push_typelist)
2009         (follow_type_instance_flags, follow_types): Don't declare.
2010         * parse.c (type_stack): Remove global.
2011         (parse_exp_in_context): Update.
2012         (insert_into_type_stack, insert_type, push_type, push_type_int)
2013         (insert_type_address_space, pop_type, pop_type_int)
2014         (pop_typelist, pop_type_stack, append_type_stack)
2015         (push_type_stack, get_type_stack, push_typelist)
2016         (follow_type_instance_flags, follow_types): Remove (moved to
2017         type-stack.c).
2018         * f-exp.y (type_stack): New global.
2019         Update rules.
2020         (push_kind_type, f_parse): Update.
2021         * d-exp.y (type_stack): New global.
2022         Update rules.
2023         (d_parse): Update.
2024         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2025         Update rules.
2026         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2027         (HFILES_NO_SRCDIR): Add type-stack.h.
2028
2029 2019-04-04  Tom Tromey  <tom@tromey.com>
2030
2031         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2032         (rust_parser::convert_ast_to_expression, rust_parse)
2033         (rust_lex_test_completion, rust_lex_tests): Update.
2034         * parser-defs.h (struct expr_completion_state): New.
2035         (struct parser_state) <parser_state>: Add completion parameter.
2036         <mark_struct_expression, mark_completion_tag>: New methods.
2037         <parse_completion, m_completion_state>: New members.
2038         (prefixify_expression, null_post_parser): Update.
2039         (mark_struct_expression, mark_completion_tag): Don't declare.
2040         * parse.c (parse_completion, expout_last_struct)
2041         (expout_tag_completion_type, expout_completion_name): Remove
2042         globals.
2043         (parser_state::mark_struct_expression)
2044         (parser_state::mark_completion_tag): Now methods.
2045         (prefixify_expression): Add last_struct parameter.
2046         (prefixify_subexp): Likewise.
2047         (parse_exp_1): Update.
2048         (parse_exp_in_context): Add cstate parameter.  Update.
2049         (parse_expression_for_completion): Create an
2050         expr_completion_state.
2051         (null_post_parser): Add "completion" parameter.
2052         * p-exp.y: Update rules.
2053         (yylex): Update.
2054         * language.h (struct language_defn) <la_post_parser>: Add
2055         "completing" parameter.
2056         * go-exp.y: Update rules.
2057         (lex_one_token): Update.
2058         * expression.h (parse_completion): Don't declare.
2059         * d-exp.y: Update rules.
2060         (lex_one_token): Update rules.
2061         * c-exp.y: Update rules.
2062         (lex_one_token): Update.
2063         * ada-lang.c (resolve): Add "parse_completion" parameter.
2064         (resolve_subexp): Likewise.
2065         (ada_resolve_function): Likewise.
2066
2067 2019-04-04  Tom Tromey  <tom@tromey.com>
2068
2069         * parser-defs.h (struct parser_state) <start_arglist,
2070         end_arglist>: New methods.
2071         <arglist_len, m_funcall_chain>: New members.
2072         (arglist_len, start_arglist, end_arglist): Don't declare.
2073         * parse.c (arglist_len, funcall_chain): Remove global.
2074         (start_arglist, end_arglist): Remove functions.
2075         (parse_exp_in_context): Update.
2076         * p-exp.y: Update rules.
2077         * m2-exp.y: Update rules.
2078         * go-exp.y: Update rules.
2079         * f-exp.y: Update rules.
2080         * d-exp.y: Update rules.
2081         * c-exp.y: Update rules.
2082
2083 2019-04-04  Tom Tromey  <tom@tromey.com>
2084
2085         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2086         lex_operator, push_back>: New methods.
2087         Update all rules.
2088         (rust_parser::lex_hex, lex_escape): Rename and update.
2089         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2090         (rust_parser::lex_operator): Rename and update.
2091         (rust_parser::lex_number, rustyylex, rustyyerror)
2092         (rust_lex_test_init, rust_lex_test_sequence)
2093         (rust_lex_test_push_back, rust_lex_tests): Update.
2094         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2095         parameter.
2096         <lexptr, prev_lexptr>: New members.
2097         (lexptr, prev_lexptr): Don't declare.
2098         * parse.c (lexptr, prev_lexptr): Remove globals.
2099         (parse_exp_in_context): Update.
2100         * p-exp.y (yylex, yyerror): Update.
2101         * m2-exp.y (parse_number, yylex, yyerror): Update.
2102         * go-exp.y (lex_one_token, yyerror): Update.
2103         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2104         * d-exp.y (lex_one_token, yyerror): Update.
2105         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2106         (lex_one_token, yyerror): Update.
2107         * ada-lex.l (YY_INPUT): Update.
2108         (rewind_to_char): Update.
2109         * ada-exp.y (yyerror): Update.
2110
2111 2019-04-04  Tom Tromey  <tom@tromey.com>
2112
2113         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2114         * parser-defs.h (struct parser_state) <parser_state>: Add new
2115         parameter.
2116         <comma_terminates>: New member.
2117         (comma_terminates): Don't declare global.
2118         * parse.c (comma_terminates): Remove global.
2119         (parse_exp_in_context): Update.
2120         * p-exp.y (yylex): Update.
2121         * m2-exp.y (yylex): Update.
2122         * go-exp.y (lex_one_token): Update.
2123         * f-exp.y (yylex): Update.
2124         * d-exp.y (lex_one_token): Update.
2125         * c-exp.y (lex_one_token): Update.
2126         * ada-lex.l: Update.
2127
2128 2019-04-04  Tom Tromey  <tom@tromey.com>
2129
2130         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2131         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2132         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2133         * parser-defs.h (paren_depth): Don't declare.
2134         * parse.c (paren_depth): Remove global.
2135         (parse_exp_in_context): Update.
2136         * p-exp.y (paren_depth): New global.
2137         (pascal_parse): Initialize it.
2138         * m2-exp.y (paren_depth): New global.
2139         (m2_parse): Initialize it.
2140         * go-exp.y (paren_depth): New global.
2141         (go_parse): Initialize it.
2142         * f-exp.y (paren_depth): New global.
2143         (f_parse): Initialize it.
2144         * d-exp.y (paren_depth): New global.
2145         (d_parse): Initialize it.
2146         * c-exp.y (paren_depth): New global.
2147         (c_parse): Initialize it.
2148         * ada-lex.l (paren_depth): New global.
2149         (lexer_init): Initialize it.
2150
2151 2019-04-04  Tom Tromey  <tom@tromey.com>
2152
2153         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2154         (rust_parser::convert_ast_to_type)
2155         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2156         * parser-defs.h (struct parser_state) <parser_state>: Add
2157         parameters.  Initialize new members.
2158         <expression_context_block, expression_context_pc>: New members.
2159         * parse.c (expression_context_block, expression_context_pc):
2160         Remove globals.
2161         (parse_exp_in_context): Update.
2162         * p-exp.y: Update all rules.
2163         (yylex): Update.
2164         * m2-exp.y: Update all rules.
2165         (yylex): Update.
2166         * go-exp.y (yylex): Update.
2167         * f-exp.y (yylex): Update.
2168         * d-exp.y: Update all rules.
2169         (yylex): Update.
2170         * c-exp.y: Update all rules.
2171         (lex_one_token, classify_name, yylex, c_parse): Update.
2172         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2173
2174 2019-04-04  Tom Tromey  <tom@tromey.com>
2175
2176         * gdbarch.h, gdbarch.c: Rebuild.
2177         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2178         * stap-probe.h:
2179         (struct stap_parse_info): Replace "parser_state" with
2180         "expr_builder".
2181         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2182         (parser_state): New class.
2183         * parse.c (expr_builder): Rename.
2184         (expr_builder::release): Rename.
2185         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2186         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2187         (write_exp_elt_longcst, write_exp_elt_floatcst)
2188         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2189         (write_exp_string_vector, write_exp_bitstring)
2190         (write_exp_msymbol, mark_struct_expression)
2191         (write_dollar_variable)
2192         (insert_type_address_space, increase_expout_size): Replace
2193         "parser_state" with "expr_builder".
2194         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2195         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2196         "parser_state" with "expr_builder".
2197
2198 2019-04-04  Tom Tromey  <tom@tromey.com>
2199
2200         * rust-exp.y: Replace "parse_language" with method call.
2201         * p-exp.y:
2202         (yylex): Replace "parse_language" with method call.
2203         * m2-exp.y:
2204         (yylex): Replace "parse_language" with method call.
2205         * go-exp.y (classify_name): Replace "parse_language" with method
2206         call.
2207         * f-exp.y (yylex): Replace "parse_language" with method call.
2208         * d-exp.y (lex_one_token): Replace "parse_language" with method
2209         call.
2210         * c-exp.y:
2211         (lex_one_token, classify_name, yylex): Replace "parse_language"
2212         with method call.
2213         * ada-exp.y (find_primitive_type, type_char)
2214         (type_system_address): Replace "parse_language" with method call.
2215
2216 2019-04-04  Tom Tromey  <tom@tromey.com>
2217
2218         * rust-exp.y: Replace "parse_gdbarch" with method call.
2219         * parse.c (write_dollar_variable, insert_type_address_space):
2220         Replace "parse_gdbarch" with method call.
2221         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2222         call.
2223         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2224         call.
2225         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2226         "parse_gdbarch" with method call.
2227         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2228         with method call.
2229         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2230         "parse_gdbarch" with method call.
2231         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2232         "parse_gdbarch" with method call.
2233         * c-exp.y (parse_type, parse_number, classify_name): Replace
2234         "parse_gdbarch" with method call.
2235         * ada-lex.l: Replace "parse_gdbarch" with method call.
2236         * ada-exp.y (parse_type, find_primitive_type, type_char)
2237         (type_system_address): Replace "parse_gdbarch" with method call.
2238
2239 2019-04-04  Tom Tromey  <tom@tromey.com>
2240
2241         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2242         * stap-probe.c (stap_parse_argument): Update.
2243         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2244         initial_size parameter.
2245         * rust-exp.y (rust_lex_tests): Update.
2246         * parse.c (parser_state): Update.
2247         (parse_exp_in_context): Update.
2248         * parser-defs.h (struct parser_state) <parser_state>: Remove
2249         "initial_size" parameter.
2250
2251 2019-04-04  Tom Tromey  <tom@tromey.com>
2252
2253         * parser-defs.h (increase_expout_size): Don't declare.
2254         * parse.c (increase_expout_size): Now static.
2255
2256 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2257
2258         * gnu-nat.c (gnu_nat_target::wait): Fix
2259         target_waitstatus_to_string call.
2260
2261 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2262
2263         * eval.c (evaluate_subexp_standard): Handle internal functions
2264         during Fortran function call handling.
2265
2266 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * NEWS: Mention new internal functions.
2269         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2270         (read_base_type): Use dwarf2_init_complex_target_type.
2271         * value.c (creal_internal_fn): New function.
2272         (cimag_internal_fn): New function.
2273         (_initialize_values): Register new internal functions.
2274
2275 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2276
2277         * infrun.c (stop_all_threads): If debug_infrun, always
2278         trace the wait status after wait_one, using
2279         target_waitstatus_to_string and target_pid_to_str.
2280         (handle_inferior_event): Replace various trace of
2281         wait status kind by a single trace.
2282         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2283         wait status kind image by target_waitstatus_to_string.
2284         * target/waitstatus.c (target_waitstatus_to_string): Fix
2285         obsolete comment.
2286
2287 2019-04-01  Tom Tromey  <tromey@adacore.com>
2288
2289         PR symtab/23331:
2290         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2291
2292 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2293             Pedro Alves  <palves@redhat.com>
2294
2295         * top.c (quit_force): Call 'finalize_values'.
2296         * value.c (finalize_values): New function.
2297         * value.h (finalize_values): Declare.
2298
2299 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2300
2301         * NEWS: Announce $_gdb_major and $_gdb_minor.
2302
2303         * top.c (init_gdb_version_vars): New function.
2304         (gdb_init): Call init_gdb_version_vars.
2305
2306 2019-03-29  Tom Tromey  <tromey@adacore.com>
2307
2308         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2309         help text.  Remove dead code.
2310
2311 2019-03-29  Keith Seitz  <keiths@redhat.com>
2312
2313         From Siddhesh Poyarekar:
2314         * f-lang.h (f77_get_upperbound): Return LONGEST.
2315         (f77_get_lowerbound): Likewise.
2316         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2317         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2318         print them.
2319         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2320         plongest to format print it.
2321         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2322         (f77_get_upperbound): Likewise.
2323         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2324         LOWER_BOUND to LONGEST.
2325         (f77_create_arrayprint_offset_tbl): Likewise.
2326
2327 2019-03-29  Keith Seitz  <keiths@redhat.com>
2328
2329         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2330         %s/pulongest for TYPE_LENGTH instead of %d in format
2331         strings.
2332         * ada-typerint.c (ada_print_type): Likewise.
2333         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2334         * compile/compile-c-support.c (generate_register_struct): Likewise.
2335         * gdbtypes.c (recursive_dump_type): Likewise.
2336         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2337         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2338         instead of %d in format strings.
2339         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2340         to std::min to ULONGEST.
2341         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2342         instead of %d in format strings.
2343         * tracepoint.c (info_scope_command): Likewise.
2344         * typeprint.c (print_offset_data::update)
2345         (print_offset_data::finish): Likewise.
2346         * xtensa-tdep.c (xtensa_store_return_value)
2347         (xtensa_push_dummy_call): Likewise.
2348
2349 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2350
2351         * windows-nat.c (display_selector): Fixed format specifications
2352         for 64-bit Cygwin.
2353
2354 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2355
2356         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2357
2358 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2359
2360         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2361         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2362         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2363         (nios2_linux_init_abi): Install it.
2364
2365 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2366
2367         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2368
2369 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2370
2371         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2372
2373 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2374             Tom Tromey  <tromey@adacore.com>
2375
2376         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2377
2378 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2379
2380         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2381         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2382         method to compute the bounds of range types. Also print "[evaluated]"
2383         if the bounds' values come from a dynamic evaluation.
2384
2385 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2386
2387         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2388         whitespace when pretty printing is on.
2389
2390 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2391
2392         * ppc-linux-nat.c: Add include.
2393
2394 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2395
2396         * NEWS: Mention AArch64 Pointer Authentication.
2397
2398 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2399
2400         * arm-linux-nat.c: Add include.
2401
2402 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2403
2404         * source-cache.c (source_cache::get_source_lines): Re-read
2405         fullname after calling open_source_file.
2406
2407 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2408
2409         * NEWS: Mention TLS support for FreeBSD.
2410
2411 2019-03-25  Tom Tromey  <tromey@adacore.com>
2412
2413         * minsyms.c (BUNCH_SIZE): Update comment.
2414         (~minimal_symbol_reader): Remove old comment.
2415         (compact_minimal_symbols): Update comment.
2416         (minimal_symbol_reader::install): Remove old comment.  Update
2417         other comments.
2418
2419 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2420
2421         * s390-linux-nat.c: Add include.
2422
2423 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2424
2425         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2426         Call linux_get_hwcap.
2427         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2428         Likewise.
2429         (aarch64_linux_get_hwcap): Remove function.
2430         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2431         declaration.
2432         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2433         linux_get_hwcap.
2434         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2435         * linux-tdep.c (linux_get_hwcap): Add function.
2436         (linux_get_hwcap2): Likewise.
2437         * linux-tdep.h (linux_get_hwcap): Add declaration.
2438         (linux_get_hwcap2): Likewise.
2439         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2440         (ppc_linux_get_hwcap2): Likewise.
2441         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2442         linux_get_hwcap.
2443         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2444         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2445         (ppc_linux_nat_target::read_description): Likewise.
2446         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2447         * s390-linux-nat.c: Likewise.
2448         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2449
2450 2019-03-24  Tom Tromey  <tom@tromey.com>
2451
2452         * ada-lang.c (standard_lookup): Simplify initialization.
2453         (ada_lookup_symbol_nonlocal): Simplify return.
2454         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2455         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2456         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2457         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2458         initialization.
2459         * solib.c (solib_global_lookup): Simplify.
2460         * symtab.c (null_block_symbol): Remove.
2461         (symbol_cache_lookup): Simplify returns.
2462         (lookup_language_this): Simplify returns.
2463         (lookup_symbol_aux): Simplify return.
2464         (lookup_local_symbol): Simplify returns.
2465         (lookup_global_symbol_from_objfile): Simplify return.
2466         (lookup_symbol_in_objfile_symtabs)
2467         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2468         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2469         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2470         * cp-namespace.c (cp_lookup_bare_symbol)
2471         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2472         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2473         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2474         (cp_lookup_symbol_via_imports): Simplify initialization.
2475         (find_symbol_in_baseclass): Likewise.
2476         * symtab.h (null_block_symbol): Remove.
2477         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2478         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2479         (d_lookup_symbol_module): Likewise.
2480         (find_symbol_in_baseclass): Simplify initialization.
2481
2482 2019-03-24  Tom Tromey  <tom@tromey.com>
2483
2484         * expression.h: Don't include symtab.h.
2485         (struct block): Forward declare.
2486
2487 2019-03-24  Tom Tromey  <tom@tromey.com>
2488
2489         * c-exp.y (typebase): Remove casts.
2490         * gdbtypes.c (lookup_unsigned_typename, )
2491         (lookup_signed_typename): Remove cast.
2492         * eval.c (parse_to_comma_and_eval): Remove cast.
2493         * parse.c (write_dollar_variable): Remove cast.
2494         * block.h (struct block) <superblock>: Now const.
2495         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2496         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2497         (map_block): Make "block" const.
2498         * symfile.h (struct quick_symbol_functions)
2499         <map_matching_symbols>: Constify block argument to "callback".
2500         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2501         const.
2502         (find_pc_sect_compunit_symtab): Make "b" const.
2503         (find_symbol_at_address): Likewise.
2504         (search_symbols): Likewise.
2505         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2506         (dw2_debug_names_lookup_symbol): Likewise.
2507         (dw2_map_matching_symbols): Update.
2508         * p-valprint.c (pascal_val_print): Remove "block".
2509         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2510         (aux_add_nonlocal_symbols): Make "block" const.
2511         (resolve_subexp): Remove cast.
2512         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2513         const.
2514         (iterate_over_file_blocks): Likewise.
2515         * f-exp.y (%union) <bval>: Remove.
2516         * coffread.c (patch_opaque_types): Make "b" const.
2517         * spu-tdep.c (spu_catch_start): Make "block" const.
2518         * c-valprint.c (print_unpacked_pointer): Remove "block".
2519         * symmisc.c (dump_symtab_1): Make "b" const.
2520         (block_depth): Make "block" const.
2521         * d-exp.y (%union) <bval>: Remove.
2522         * cp-support.h (cp_lookup_rtti_type): Update.
2523         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2524         * psymtab.c (psym_lookup_symbol): Make "block" const.
2525         (maintenance_check_psymtabs): Make "b" const.
2526         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2527         (enumerate_locals, enumerate_args): Update.
2528         * python/py-symtab.c (stpy_global_block): Make "block" const.
2529         (stpy_static_block): Likewise.
2530         * inline-frame.c (block_starting_point_at): Make "new_block"
2531         const.
2532         * block.c (find_block_in_blockvector): Make return type const.
2533         (blockvector_for_pc_sect): Make "b" const.
2534         (find_block_in_blockvector): Make "b" const.
2535
2536 2019-03-23  Tom Tromey  <tom@tromey.com>
2537
2538         * varobj.c (varobj_create): Update.
2539         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2540         * printcmd.c (display_command, do_one_display): Don't reset
2541         innermost_block.
2542         * parser-defs.h (enum innermost_block_tracker_type): Move to
2543         expression.h.
2544         (innermost_block): Update comment.
2545         * parse.c (parse_exp_1): Add tracker_types parameter.
2546         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2547         tracker_types parameter.  Reset innermost_block.
2548         (parse_exp_in_context): Remove.
2549         (parse_expression_for_completion): Update.
2550         * objfiles.c (~objfile): Don't reset expression_context_block or
2551         innermost_block.
2552         * expression.h (enum innermost_block_tracker_type): Move from
2553         parser-defs.h.
2554         (parse_exp_1): Add tracker_types parameter.
2555         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2556         reset innermost_block.
2557
2558 2019-03-23  Tom Tromey  <tom@tromey.com>
2559
2560         * objfiles.h: Include bcache.h.
2561
2562 2019-03-23  Tom Tromey  <tom@tromey.com>
2563
2564         * linespec.c (get_current_search_block): Use
2565         scoped_restore_current_language.
2566         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2567
2568 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2569             Jiong Wang  <jiong.wang@arm.com>
2570
2571         * aarch64-linux-tdep.c
2572         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2573         section.
2574         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2575
2576 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2577             Jiong Wang  <jiong.wang@arm.com>
2578
2579         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2580         instructions.
2581         (aarch64_analyze_prologue_test): Add PACIASP test.
2582         (aarch64_prologue_prev_register): Unmask PC value.
2583
2584 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2585             Jiong Wang  <jiong.wang@arm.com>
2586
2587         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2588         (aarch64_dwarf2_prev_register): Unmask PC value.
2589         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2590         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2591         DW_CFA_AARCH64_negate_ra_state.
2592         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2593
2594 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2595             Jiong Wang  <jiong.wang@arm.com>
2596
2597         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2598         registers.
2599         (aarch64_pseudo_register_name): Likewise.
2600         (aarch64_pseudo_register_type): Likewise.
2601         (aarch64_pseudo_register_reggroup_p): Likewise.
2602         (aarch64_gdbarch_init): Add pauth registers.
2603         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2604         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2605         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2606         (struct gdbarch_tdep): Add regnum for ra_state.
2607
2608 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2609             Jiong Wang  <jiong.wang@arm.com>
2610
2611         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2612
2613 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2614             Jiong Wang  <jiong.wang@arm.com>
2615
2616         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2617         function.
2618         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2619         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2620         (aarch64_gdbarch_init): Add puth registers.
2621         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2622         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2623         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2624
2625 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2626             Jiong Wang  <jiong.wang@arm.com>
2627
2628         * aarch64-linux-nat.c
2629         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2630         * aarch64-linux-tdep.c
2631         (aarch64_linux_core_read_description): Likewise.
2632         (aarch64_linux_get_hwcap): New function.
2633         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2634         (aarch64_linux_get_hwcap): New declaration.
2635
2636 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2637             Jiong Wang  <jiong.wang@arm.com>
2638
2639         * aarch64-linux-nat.c
2640         (aarch64_linux_nat_target::read_description): Add pauth param.
2641         * aarch64-linux-tdep.c
2642         (aarch64_linux_core_read_description): Likewise.
2643         * aarch64-tdep.c (struct target_desc): Add in pauth.
2644         (aarch64_read_description): Add pauth param.
2645         (aarch64_gdbarch_init): Likewise.
2646         * aarch64-tdep.h (aarch64_read_description): Likewise.
2647         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2648         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2649         * features/Makefile: Add new files.
2650         * features/aarch64-pauth.c: New file.
2651         * features/aarch64-pauth.xml: New file.
2652
2653 2019-03-20  Tom Tromey  <tromey@adacore.com>
2654
2655         * infrun.c (handle_inferior_event): Rename from
2656         handle_inferior_event_1.  Create a scoped_value_mark.
2657         (handle_inferior_event): Remove.
2658
2659 2019-03-19  Tom Tromey  <tromey@adacore.com>
2660
2661         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2662         * infrun.h (print_stop_event): Add "displays" parameter.
2663         * infrun.c (print_stop_event): Add "displays" parameter.
2664
2665 2019-03-19  Pedro Alves  <palves@redhat.com>
2666
2667         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2668         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2669         to -1.  Fix TABs vs spaces.
2670         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2671         * tui/tui-out.h (tui_ui_out) Add intro comments.
2672         <m_line, m_start_of_line>: In-class initialize, and add describing
2673         comment.
2674
2675 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2676
2677         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2678         variable names.
2679         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2680
2681 2019-03-18  Pedro Alves  <palves@redhat.com>
2682             Eli Zaretskii <eliz@gnu.org>
2683
2684         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2685         m_line and m_start_of_line.
2686
2687 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2688
2689         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2690         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2691         it returns a newline.  This fixes a regression in TU mode, whereby
2692         the next line is output on the same screen line as the user input.
2693
2694 2019-03-18  Tom Tromey  <tromey@adacore.com>
2695
2696         * minsyms.c (minimal_symbol_reader::install): Remove call to
2697         obstack_blank.
2698
2699 2019-03-18  Pedro Alves  <palves@redhat.com>
2700
2701         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2702         New globals.
2703         (apply_style): New, factored out from ...
2704         (apply_ansi_escape): ... this.  Handle reverse video mode.
2705         (tui_set_reverse_mode): New function.
2706         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2707         * tui/tui-winsource.c (tui_show_source_line): Use
2708         tui_set_reverse_mode instead of setting A_STANDOUT.
2709         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2710         New setter methods.
2711
2712 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2713
2714         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2715         Handle tabs.
2716
2717 2019-03-18  Tom Tromey  <tromey@adacore.com>
2718
2719         * ada-lang.c (empty_array): Add "high" parameter.
2720         (ada_evaluate_subexp): Update.
2721
2722 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2723
2724         * unittests/string_view-selftests.c: Define
2725         _initialize_string_view_selftests unconditionally.
2726
2727 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2728
2729         PR gdb/24350
2730         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2731
2732 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2733
2734         PR gdb/24351
2735         * windows-nat.c (display_selector): Fix format specifiers.
2736
2737 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2738
2739         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2740         tui_refill_source_window instead of tui_refresh_win, to update the
2741         current execution line.  This fixes redisplay of the current line
2742         when stepping through the code with "next" or "step".
2743
2744 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2745
2746         * source-cache.c (source_cache::get_source_lines): Call
2747         find_source_lines to initialize s->nlines.  This fixes vertical
2748         scrolling of TUI source window when the DOWN arrow is pressed.
2749
2750 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2751
2752         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2753         linux-thread-db.c (_initialize_thread_db): Likewise.
2754
2755 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2756
2757         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2758         wclrtoeol in tui_show_source_line".  This reverts changes made in
2759         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2760
2761 2019-03-15  Tom Tromey  <tom@tromey.com>
2762
2763         * symtab.h (struct minimal_symbol): Derive from
2764         general_symbol_info.
2765         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2766         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2767         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2768         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2769         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2770         (MSYMBOL_SEARCH_NAME): Update.
2771         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2772         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2773         * minsyms.c (minimal_symbol_reader::record_full): Update.
2774
2775 2019-03-15  Tom Tromey  <tom@tromey.com>
2776
2777         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2778
2779 2019-03-15  Tom Tromey  <tom@tromey.com>
2780
2781         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2782         unique_xmalloc_ptr.
2783         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2784         Update.
2785         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2786         (build_minimal_symbol_hash_tables)
2787         (minimal_symbol_reader::install): Update.
2788
2789 2019-03-15  Tom Tromey  <tom@tromey.com>
2790
2791         * symtab.c (create_demangled_names_hash): Update.
2792         (symbol_set_names): Update.
2793         * objfiles.h (struct objfile_per_bfd_storage)
2794         <demangled_names_hash>: Now an htab_up.
2795         * objfiles.c (objfile_per_bfd_storage): Simplify.
2796
2797 2019-03-15  Tom Tromey  <tom@tromey.com>
2798
2799         * objfiles.h (struct objfile_per_bfd_storage): Declare
2800         destructor.
2801         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2802         New.
2803         (get_objfile_bfd_data): Use new.  Don't initialize
2804         language_of_main.
2805         (free_objfile_per_bfd_storage): Remove.
2806         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2807
2808 2019-03-15  Tom Tromey  <tom@tromey.com>
2809
2810         * symfile.c (reread_symbols): Update.
2811         * objfiles.c (objfile::objfile): Update.
2812         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2813         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2814         comment.
2815         (minimal_symbol_reader::install): Update.
2816         (terminate_minimal_symbol_table): Remove.
2817         * jit.c (jit_object_close_impl): Update.
2818
2819 2019-03-15  Tom Tromey  <tom@tromey.com>
2820
2821         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2822         initializations.
2823
2824 2019-03-15  Tom Tromey  <tom@tromey.com>
2825
2826         * objfiles.h (struct objfile_per_bfd_storage)
2827         <demangled_hash_languages>: Now a bitset.
2828         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2829         (lookup_minimal_symbol): Update.
2830
2831 2019-03-15  Tom Tromey  <tom@tromey.com>
2832
2833         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2834         Don't return the symbol.
2835         * coffread.c (record_minimal_symbol): Use record_full.
2836
2837 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2838
2839         The MS-Windows port of ncurses fails to switch to a color pair if
2840         one or both of the colors are the implicit default colors.  This
2841         change records the default colors when TUI is initialized, and
2842         then specifies them explicitly when a color pair uses the default
2843         colors.  This allows color styling in TUI mode on MS-Windows.
2844
2845         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2846         ncurses_norm_attr.
2847         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2848         colors in ncurses_norm_attr.
2849         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2850         "none", replace it with the default color recorded in
2851         ncurses_norm_attr.
2852
2853 2019-03-14  Tom Tromey  <tromey@adacore.com>
2854
2855         * source-cache.h (class source_cache) <get_source_lines>: Return
2856         std::string.
2857         * source-cache.c (source_cache::extract_lines): Handle case where
2858         first_pos==npos.  Return std::string.
2859         (source_cache::get_source_lines): Update.
2860
2861 2019-03-14  Tom Tromey  <tromey@adacore.com>
2862
2863         * NEWS: Add item for "style sources" commands.
2864         * source-cache.c (source_cache::get_source_lines): Check
2865         source_styling.
2866         * cli/cli-style.c (source_styling): New global.
2867         (_initialize_cli_style): Add "style sources" commands.
2868         (show_style_sources): New function.
2869         * cli/cli-style.h (source_styling): Declare.
2870
2871 2019-03-14  Pedro Alves  <palves@redhat.com>
2872             Tom Tromey  <tromey@adacore.com>
2873
2874         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2875         * tui/tui-winsource.c (tui_refill_source_window): New function,
2876         from...
2877         (tui_horizontal_source_scroll): ... here.  Move some logic.
2878         * cli/cli-style.c (set_style_enabled): Notify new observable.
2879         * tui/tui-hooks.c (tui_redisplay_source): New function.
2880         (tui_attach_detach_observers): Attach or detach
2881         tui_redisplay_source.
2882         * observable.h (source_styling_changed): New observable.
2883         * observable.c: Define source_styling_changed observable.
2884
2885 2019-03-13  Tom Tromey  <tromey@adacore.com>
2886
2887         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2888         (i386_gnu_nat_target::store_registers): Update.
2889         * target-debug.h (target_debug_print_std_string): New macro.
2890         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2891         * windows-tdep.c (display_one_tib): Update.
2892         * tui/tui-stack.c (tui_make_status_line): Update.
2893         * top.c (print_inferior_quit_action): Update.
2894         * thread.c (thr_try_catch_cmd): Update.
2895         (add_thread_with_info): Update.
2896         (thread_target_id_str): Update.
2897         (thr_try_catch_cmd): Update.
2898         (thread_command): Update.
2899         (thread_find_command): Update.
2900         * record-btrace.c (record_btrace_target::info_record)
2901         (record_btrace_resume_thread, record_btrace_target::resume)
2902         (record_btrace_cancel_resume, record_btrace_step_thread)
2903         (record_btrace_target::wait, record_btrace_target::wait)
2904         (record_btrace_target::wait, record_btrace_target::stop): Update.
2905         * progspace.c (print_program_space): Update.
2906         * process-stratum-target.c
2907         (process_stratum_target::thread_address_space): Update.
2908         * linux-fork.c (linux_fork_mourn_inferior)
2909         (detach_checkpoint_command, info_checkpoints_command)
2910         (linux_fork_context): Update.
2911         (linux_fork_detach): Update.
2912         (class scoped_switch_fork_info): Update.
2913         (delete_checkpoint_command): Update.
2914         * infrun.c (follow_fork_inferior): Update.
2915         (follow_fork_inferior): Update.
2916         (proceed_after_vfork_done): Update.
2917         (handle_vfork_child_exec_or_exit): Update.
2918         (follow_exec): Update.
2919         (displaced_step_prepare_throw): Update.
2920         (displaced_step_restore): Update.
2921         (start_step_over): Update.
2922         (resume_1): Update.
2923         (clear_proceed_status_thread): Update.
2924         (proceed): Update.
2925         (print_target_wait_results): Update.
2926         (do_target_wait): Update.
2927         (context_switch): Update.
2928         (stop_all_threads): Update.
2929         (restart_threads): Update.
2930         (finish_step_over): Update.
2931         (handle_signal_stop): Update.
2932         (switch_back_to_stepped_thread): Update.
2933         (keep_going_pass_signal): Update.
2934         (print_exited_reason): Update.
2935         (normal_stop): Update.
2936         * inferior.c (inferior_pid_to_str): Change return type.
2937         (print_selected_inferior): Update.
2938         (add_inferior): Update.
2939         (detach_inferior): Update.
2940         * dummy-frame.c (fprint_dummy_frames): Update.
2941         * dcache.c (dcache_info_1): Update.
2942         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2943         (btrace_fetch, btrace_clear): Update.
2944         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2945         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2946         type.
2947         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2948         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2949         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2950         * gdbarch.c, gdbarch.h: Rebuild.
2951         * gdbarch.sh (core_pid_to_str): Change return type.
2952         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2953         return type.
2954         (windows_nat_target::pid_to_str): Change return type.
2955         (windows_delete_thread): Update.
2956         (windows_nat_target::attach): Update.
2957         (windows_nat_target::files_info): Update.
2958         * target-delegates.c: Rebuild.
2959         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2960         return type.
2961         (sol_thread_target::pid_to_str): Change return type.
2962         * remote.c (class remote_target) <pid_to_str>: Change return
2963         type.
2964         (remote_target::pid_to_str): Change return type.
2965         (extended_remote_target::attach, remote_target::remote_stop_ns)
2966         (remote_target::remote_notif_remove_queued_reply)
2967         (remote_target::push_stop_reply, remote_target::disable_btrace):
2968         Update.
2969         (extended_remote_target::attach): Update.
2970         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2971         type.
2972         (gdbsim_target::pid_to_str): Change return type.
2973         * ravenscar-thread.c (struct ravenscar_thread_target)
2974         <pid_to_str>: Change return type.
2975         (ravenscar_thread_target::pid_to_str): Change return type.
2976         * procfs.c (class procfs_target) <pid_to_str>: Change return
2977         type.
2978         (procfs_target::pid_to_str): Change return type.
2979         (procfs_target::attach): Update.
2980         (procfs_target::detach): Update.
2981         (procfs_target::fetch_registers): Update.
2982         (procfs_target::store_registers): Update.
2983         (procfs_target::wait): Update.
2984         (procfs_target::files_info): Update.
2985         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2986         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2987         return type.
2988         (nto_procfs_target::pid_to_str): Change return type.
2989         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2990         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2991         return type.
2992         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2993         (exit_lwp): Update.
2994         (attach_proc_task_lwp_callback, get_detach_signal)
2995         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2996         (linux_nat_target::resume, wait_lwp, stop_callback)
2997         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2998         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2999         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3000         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3001         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3002         type.
3003         (inf_ptrace_target::attach): Update.
3004         (inf_ptrace_target::files_info): Update.
3005         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3006         type.
3007         (go32_nat_target::pid_to_str): Change return type.
3008         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3009         (gnu_nat_target::wait): Update.
3010         (gnu_nat_target::wait): Update.
3011         (gnu_nat_target::resume): Update.
3012         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3013         (fbsd_nat_target::wait): Update.
3014         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3015         type.
3016         (darwin_nat_target::attach): Update.
3017         * corelow.c (class core_target) <pid_to_str>: Change return type.
3018         (core_target::pid_to_str): Change return type.
3019         * target.c (normal_pid_to_str): Change return type.
3020         (default_pid_to_str): Likewise.
3021         (target_pid_to_str): Change return type.
3022         (target_translate_tls_address): Update.
3023         (target_announce_detach): Update.
3024         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3025         return type.
3026         (bsd_uthread_target::pid_to_str): Change return type.
3027         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3028         type.
3029         (bsd_kvm_target::pid_to_str): Change return type.
3030         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3031         return type.
3032         (aix_thread_target::pid_to_str): Change return type.
3033         * target.h (struct target_ops) <pid_to_str>: Change return type.
3034         (target_pid_to_str, normal_pid_to_str): Likewise.
3035         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3036         type.
3037         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3038         type.
3039         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3040         return type.
3041         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3042         type.
3043         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3044         type.
3045         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3046         return type.
3047
3048 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3049
3050         * NEWS: Mention that the new default MI version is 3.  Mention
3051         changes to the output of commands and events that deal with
3052         multi-location breakpoints.
3053         * breakpoint.c: Include "mi/mi-out.h".
3054         (print_one_breakpoint): Change output syntax if using MI version
3055         >= 3.
3056         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3057         New.
3058         (mi_multi_location_breakpoint_output_fixed): New.
3059         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3060         (mi_cmd_fix_multi_location_breakpoint_output): New.
3061         (mi_multi_location_breakpoint_output_fixed): New.
3062         * mi/mi-cmds.c (mi_cmds): Register command
3063         -fix-multi-location-breakpoint-output.
3064         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3065         interpreter "mi".
3066
3067 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3068
3069         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3070         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3071         instantiate mi_ui_out based on interpreter name.
3072         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3073         * mi/mi-main.c (mi_load_progress): Likewise.
3074
3075 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3076
3077         * NEWS: Combine separate "New targets" sections for 8.3.
3078
3079 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3080
3081         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3082         (ppcfbsd_init_abi): Install gdbarch
3083         "fetch_tls_load_module_address" and "get_thread_local_address"
3084         methods.
3085
3086 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3087
3088         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3089         (riscv_fbsd_init_abi): Install gdbarch
3090         "fetch_tls_load_module_address" and "get_thread_local_address"
3091         methods.
3092
3093 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3094
3095         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3096         (i386fbsd_init_abi): Install gdbarch
3097         "fetch_tls_load_module_address" and "get_thread_local_address"
3098         methods.
3099
3100 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3101
3102         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3103         (amd64fbsd_init_abi): Install gdbarch
3104         "fetch_tls_load_module_address" and "get_thread_local_address"
3105         methods.
3106
3107 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3108
3109         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3110         (struct fbsd_pspace_data): New type.
3111         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3112         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3113         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3114         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3115         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3116
3117 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3118
3119         * gdbtypes.c (lookup_struct_elt): New function.
3120         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3121         * gdbtypes.h (struct struct_elt): New type.
3122         (lookup_struct_elt): New prototype.
3123
3124 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3125
3126         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3127         remove disabled code block.
3128
3129 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3130
3131         * gdbarch.sh (get_thread_local_address): New method.
3132         * gdbarch.h, gdbarch.c: Regenerate.
3133         * target.c (target_translate_tls_address): Use
3134         gdbarch_get_thread_local_address if present instead of
3135         target::get_thread_local_address.
3136
3137 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3138
3139         * target.h (target::get_thread_local_address): Update comment.
3140
3141 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3142
3143         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3144         objfile->separate_debug_objfile_backlink if not NULL.
3145
3146 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3147
3148         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3149         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3150         (amd64bsd_store_inferior_registers): Likewise.
3151         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3152         Enable segment base registers.
3153         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3154         PT_GETFSBASE and PT_GETGSBASE.
3155         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3156         PT_SETGSBASE.
3157         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3158         segment base registers.
3159         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3160
3161 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3162
3163         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3164         Update calls to i386_target_description to add 'segments'
3165         parameter.
3166         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3167         add segment base registers.
3168         * arch/i386.c (i386_create_target_description): Add 'segments'
3169         parameter to enable segment base registers.
3170         * arch/i386.h (i386_create_target_description): Likewise.
3171         * features/i386/32bit-segments.xml: New file.
3172         * features/i386/32bit-segments.c: Generate.
3173         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3174         call to i386_target_description to add 'segments' parameter.
3175         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3176         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3177         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3178         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3179         if feature is present.
3180         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3181         Add 'segments' parameter to call to i386_target_description.
3182         (i386_target_description): Add 'segments' parameter to enable
3183         segment base registers.
3184         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3185         to call to i386_target_description.
3186         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3187         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3188         Define I386_NUM_REGS.
3189         (i386_target_description): Add 'segments' parameter to enable
3190         segment base registers.
3191
3192 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3193
3194         PR/24325
3195         * source-cache.c: #undef open and close, to avoid unresolved
3196         externals during linking.
3197
3198 2019-03-12  Tom Tromey  <tromey@adacore.com>
3199
3200         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3201         const.  Add initializers.
3202         (_initialize_remote): Don't initialize ptid globals.
3203
3204 2019-03-12  Pedro Alves  <palves@redhat.com>
3205
3206         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3207
3208 2019-03-12  Pedro Alves  <palves@redhat.com>
3209
3210         * cp-name-parser.y (main): Remove unused 'len' variable.
3211
3212 2019-03-12  Tom Tromey  <tromey@adacore.com>
3213
3214         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3215         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3216
3217 2019-03-12  Tom Tromey  <tromey@adacore.com>
3218
3219         * linux-nat.c (iterate_over_lwps): Update.
3220         (stop_callback): Remove parameter.
3221         (stop_wait_callback, detach_callback, resume_set_callback)
3222         (select_singlestep_lwp_callback, set_ignore_sigint)
3223         (status_callback, resumed_callback, resume_clear_callback)
3224         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3225         data parameter.
3226         (linux_nat_target::detach, linux_nat_target::resume)
3227         (linux_stop_and_wait_all_lwps, select_event_lwp)
3228         (linux_nat_filter_event, linux_nat_wait_1)
3229         (linux_nat_target::kill, linux_nat_target::stop)
3230         (linux_nat_target::stop): Update.
3231         (linux_nat_resume_callback): Change type.
3232         (resume_stopped_resumed_lwps, count_events_callback)
3233         (select_event_lwp_callback): Likewise.
3234         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3235         * arm-linux-nat.c (struct update_registers_data): Remove.
3236         (update_registers_callback): Change type.
3237         (arm_linux_insert_hw_breakpoint1): Update.
3238         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3239         parameter.
3240         (x86_linux_dr_set_addr): Update.
3241         (x86_linux_dr_set_control): Update.
3242         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3243         (iterate_over_lwps): Use gdb::function_view.
3244         * nat/aarch64-linux-hw-point.c (struct
3245         aarch64_dr_update_callback_param): Remove.
3246         (debug_reg_change_callback): Change type.
3247         (aarch64_notify_debug_reg_change): Update.
3248         * s390-linux-nat.c (s390_refresh_per_info): Update.
3249
3250 2019-03-11  Tom Tromey  <tromey@adacore.com>
3251
3252         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3253         redundant assignment to "this_cu".
3254
3255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3256
3257         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3258
3259 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3260
3261         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3262         from...
3263         (rank_one_type): ... this.
3264
3265 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3266
3267         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3268         from...
3269         (rank_one_type): ... this.
3270
3271 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3272
3273         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3274         from...
3275         (rank_one_type): ... this.
3276
3277 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3278
3279         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3280         from...
3281         (rank_one_type): ... this.
3282
3283 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3284
3285         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3286         from...
3287         (rank_one_type): ... this.
3288
3289 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3290
3291         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3292         from...
3293         (rank_one_type): ... this.
3294
3295 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3296
3297         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3298         from...
3299         (rank_one_type): ... this.
3300
3301 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3302
3303         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3304         from...
3305         (rank_one_type): ... this.
3306
3307 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3308
3309         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3310         from...
3311         (rank_one_type): ... this.
3312
3313 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3314
3315         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3316         from...
3317         (rank_one_type): ... this.
3318
3319 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3320
3321         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3322         from...
3323         (rank_one_type): ... this.
3324
3325 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3326
3327         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3328         from...
3329         (rank_one_type): ... this.
3330
3331 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3332
3333         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3334         inferior-events' shows the example events.
3335
3336 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3337
3338         Support styling on native MS-Windows console
3339
3340         PR/24315
3341         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3342         on MS-Windows if $TERM is not defined.
3343
3344         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3345
3346         * posix-hdep.c (gdb_console_fputs):
3347         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3348         functions.
3349         * ui-file.h (gdb_console_fputs): Add prototype.
3350
3351         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3352         back to fputs only if the former returns zero.
3353
3354 2019-03-07  Tom Tromey  <tom@tromey.com>
3355
3356         * symmisc.c (print_symbol_bcache_statistics): Update.
3357         (print_objfile_statistics): Update.
3358         * symfile.c (allocate_symtab): Update.
3359         * stabsread.c: Don't include bcache.h.
3360         * psymtab.h (struct psymbol_bcache): Don't declare.
3361         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3362         (psymbol_bcache_init, psymbol_bcache_free)
3363         (psymbol_bcache_get_bcache): Don't declare.
3364         * psymtab.c (struct psymbol_bcache): Remove.
3365         (psymtab_storage::psymtab_storage): Update.
3366         (psymtab_storage::~psymtab_storage): Update.
3367         (psymbol_bcache_init, psymbol_bcache_free)
3368         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3369         (add_psymbol_to_bcache): Update.
3370         (allocate_psymtab): Update.
3371         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3372         macro_cache>: No longer pointers.
3373         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3374         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3375         * macrotab.c (macro_bcache): Update.
3376         * macroexp.c: Don't include bcache.h.
3377         * gdbtypes.c (check_types_worklist): Update.
3378         (types_deeply_equal): Remove TRY/CATCH.  Update.
3379         * elfread.c (elf_symtab_read): Update.
3380         * dwarf2read.c: Don't include bcache.h.
3381         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3382         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3383         (print_bcache_statistics, bcache_memory_used): Don't declare.
3384         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3385         methods.  Rename all data members.
3386         * bcache.c (struct bcache): Move to bcache.h.
3387         (bcache::expand_hash_table): Rename from expand_hash_table.
3388         (bcache): Remove.
3389         (bcache::insert): Rename from bcache_full.
3390         (bcache::compare): Rename from bcache_compare.
3391         (bcache_xmalloc): Remove.
3392         (bcache::~bcache): Rename from bcache_xfree.
3393         (bcache::print_statistics): Rename from print_bcache_statistics.
3394         (bcache::memory_used): Rename from bcache_memory_used.
3395
3396 2019-03-07  Pedro Alves  <palves@redhat.com>
3397
3398         * infrun.c (normal_stop): Also check for
3399         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3400
3401 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3402
3403         * f-lang.c (value_from_host_double): Moved to...
3404         * value.c (value_from_host_double): ...here.
3405         * value.h (value_from_host_double): Declare.
3406         * guile/scm-math.c (vlscm_convert_typed_number): Use
3407         value_from_host_double.
3408         (vlscm_convert_number): Likewise.
3409         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3410         * python/py-value.c (convert_value_from_python): Likewise.
3411
3412 2019-03-06  Tom Tromey  <tom@tromey.com>
3413
3414         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3415
3416 2019-03-06  Tom Tromey  <tom@tromey.com>
3417
3418         * utils.h (free_current_contents): Don't declare.
3419         * utils.c (free_current_contents): Remove.
3420
3421 2019-03-06  Tom Tromey  <tom@tromey.com>
3422
3423         * top.c (quit_force): Update.
3424         * main.c (captured_command_loop): Update.
3425         * common/new-op.c (operator new): Update.
3426         * common/common-exceptions.c (struct catcher)
3427         <save_cleanup_chain>: Remove member.
3428         (exceptions_state_mc_init): Update.
3429         (exception_try_scope_entry): Return nullptr.
3430         (exception_try_scope_exit, exception_rethrow)
3431         (throw_exception_sjlj, throw_exception_cxx): Update.
3432         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3433         (all_cleanups, do_cleanups, discard_cleanups)
3434         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3435         (restore_cleanups, restore_final_cleanups): Don't declare.
3436         (do_final_cleanups): Remove parameter.
3437         * common/cleanups.c (cleanup_chain, make_cleanup)
3438         (make_cleanup_dtor, all_cleanups, do_cleanups)
3439         (discard_my_cleanups, discard_cleanups)
3440         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3441         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3442         (null_cleanup): Remove.
3443         (do_final_cleanups): Remove parameter.
3444
3445 2019-03-06  Tom Tromey  <tom@tromey.com>
3446
3447         * remote.c (remote_target::remote_parse_stop_reply): Use
3448         unique_xmalloc_ptr.
3449
3450 2019-03-06  Tom Tromey  <tom@tromey.com>
3451
3452         * stabsread.c (struct stabs_field_info): Rename from field_info.
3453         <list, fnlist>: Add initializers.
3454         <obstack>: New member.
3455         (read_member_functions, read_struct_fields, read_baseclasses):
3456         Allocate on obstack.  Don't use cleanups.
3457         (read_one_struct_field, read_member_functions, read_struct_fields)
3458         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3459         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3460         (read_struct_type): Update.
3461
3462 2019-03-06  Tom Tromey  <tom@tromey.com>
3463
3464         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3465         * common/filestuff.h (make_cleanup_close): Don't declare.
3466         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3467         Remove.
3468
3469 2019-03-06  Tom Tromey  <tom@tromey.com>
3470
3471         * solib-aix.c: Use make_scope_exit.
3472
3473 2019-03-06  Tom Tromey  <tom@tromey.com>
3474
3475         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3476         Use make_scope_exit.
3477
3478 2019-03-06  Tom Tromey  <tom@tromey.com>
3479
3480         * solib-svr4.c (disable_probes_interface): Remove parameter.
3481         (svr4_handle_solib_event): Use make_scope_exit.
3482
3483 2019-03-06  Tom Tromey  <tom@tromey.com>
3484
3485         * remote.c (struct stop_reply_deleter): Remove.
3486         (stop_reply_up): Update.
3487         (struct stop_reply): Derive from notif_event.  Don't typedef.
3488         <regcache>: Now a std::vector.
3489         (stop_reply_xfree): Remove.
3490         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3491         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3492         (remote_target::discard_pending_stop_replies): Use delete.
3493         (remote_target::remote_parse_stop_reply): Update.
3494         (remote_target::process_stop_reply): Update.
3495         * remote-notif.h (struct notif_event): Add virtual destructor.
3496         Remove "dtr" member.
3497         (struct notif_client) <alloc_event>: Return a unique_ptr.
3498         (notif_event_xfree): Don't declare.
3499         (notif_event_up): New typedef.
3500         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3501         (notif_event_xfree, do_notif_event_xfree): Remove.
3502         (remote_notif_state_xfree): Update.
3503
3504 2019-03-06  Tom Tromey  <tom@tromey.com>
3505
3506         * infrun.c (displaced_step_clear_cleanup): Now a
3507         forward_scope_exit type.
3508         (displaced_step_prepare_throw): Update.
3509         (displaced_step_fixup): Update.
3510
3511 2019-03-06  Tom Tromey  <tom@tromey.com>
3512
3513         * inferior.h (class inferior): Update comment.
3514         * gdbthread.h (class thread_info): Update comment.
3515
3516 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3517             Tom Tromey  <tom@tromey.com>
3518
3519         * stabsread.h (struct stab_section_list): Remove.
3520         (coffstab_build_psymtabs): Update.
3521         * dbxread.c (symbuf_sections): Now a std::vector.
3522         (sect_idx): New global.
3523         (fill_symbuf): Update.
3524         (coffstab_build_psymtabs): Change type of stabsects parameter.
3525         Update.
3526         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3527         std::vector.
3528         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3529         (coff_locate_sections): Update.
3530         (coff_symfile_read): Remove cleanups.  Update.
3531         (init_stringtab): Add storage parameter.
3532         (free_stringtab, free_stringtab_cleanup): Remove.
3533         (init_lineno): Add storage parameter.
3534         (free_linetab, free_linetab_cleanup): Remove.
3535
3536 2019-03-06  Pedro Alves  <palves@redhat.com>
3537
3538         * linux-fork.c (fork_info::clobber_regs): Delete.
3539         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3540         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3541         comment.  Adjust.
3542         (scoped_switch_fork_info::scoped_switch_fork_info)
3543         (checkpoint_command, linux_fork_context): Adjust
3544         fork_save_infrun_state calls.
3545
3546 2019-03-06  Pedro Alves  <palves@redhat.com>
3547
3548         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3549         (inf_has_multiple_threads): Return 'bool' and rewrite using
3550         inferior_info::threads().
3551
3552 2019-03-06  Pedro Alves  <palves@redhat.com>
3553
3554         * linux-fork.c: Include <list>.
3555         (fork_list): Now a std::list instance.
3556         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3557         (forks_exist_p, find_last_fork): Adjust.
3558         (new_fork): Delete.
3559         (one_fork_p): New.
3560         (add_fork): Adjust.
3561         (free_fork): Delete, folded into fork_info::~fork_info().
3562         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3563         Adjust.
3564         (init_fork_list): Delete.
3565         (linux_fork_killall, linux_fork_mourn_inferior)
3566         (linux_fork_detach, info_checkpoints_command): Adjust.
3567         (_initialize_linux_fork): No longer call init_fork_list.
3568
3569 2019-03-06  Pedro Alves  <palves@redhat.com>
3570
3571         * linux-fork.c (new_fork): New, split out of ...
3572         (add_fork): ... this.  Return void.  Move "first fork" special
3573         case from here, to ...
3574         (checkpoint_command): ... here.
3575         * linux-linux.h (add_fork): Return void.
3576
3577 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3578
3579         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3580
3581 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3582             Chris January  <chris.january@arm.com>
3583             David Lecomber  <david.lecomber@arm.com>
3584
3585         * f-exp.y: New token, UNOP_INTRINSIC.
3586         (exp): New pattern using UNOP_INTRINSIC token.
3587         (f77_keywords): Add 'abs' keyword.
3588         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3589         (value_from_host_double): New function.
3590         (evaluate_subexp_f): Support UNOP_ABS.
3591
3592 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3593
3594         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3595         types.
3596
3597 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3598
3599         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3600         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3601         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3602
3603 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3604
3605         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3606
3607 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3608             Chris January  <chris.january@arm.com>
3609
3610         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3611         * f-exp.y: Define 'KIND' token.
3612         (exp): New pattern for KIND expressions.
3613         (ptype): Handle types with a kind extension.
3614         (direct_abs_decl): Extend to spot kind extensions.
3615         (f77_keywords): Add 'kind' to the list.
3616         (push_kind_type): New function.
3617         (convert_to_kind_type): New function.
3618         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3619         * parse.c (operator_length_standard): Likewise.
3620         * parser-defs.h (enum type_pieces): Add tp_kind.
3621         * std-operator.def: Add UNOP_KIND.
3622
3623 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3624
3625         * f-exp.y (f_parse): Set yydebug.
3626
3627 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3628
3629         * f-lang.c (evaluate_subexp_f): New function.
3630         (exp_descriptor_f): New global.
3631         (f_language_defn): Use exp_descriptor_f instead of
3632         exp_descriptor_standard.
3633
3634 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         * f-exp.y (struct token): Add comments.
3637         (dot_ops): Remove uppercase versions and the end marker.
3638         (f77_keywords): Likewise.
3639         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3640         entries in the dot_ops array are case insensitive, and use
3641         strncasecmp to compare strings.  Also some whitespace cleanup in
3642         this area.  Similar for the f77_keywords array, except entries in
3643         this list might be case sensitive.
3644
3645 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3646
3647         * f-exp.y (struct f77_boolean_val): Add comments.
3648         (boolean_values): Remove uppercase versions, and end marker.
3649         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3650         and use strncasecmp to achieve case insensitivity.  Additionally,
3651         perform whitespace cleanup around this code.
3652
3653 2019-03-06  Tom Tromey  <tromey@adacore.com>
3654
3655         * remote-sim.c (gdbsim_target_open): Use result of
3656         gdb_argv::release.
3657
3658 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3659         Dirk Schubert  <dirk.schubert@arm.com>
3660         Chris January  <chris.january@arm.com>
3661
3662         * eval.c (evaluate_subexp_standard): Call Fortran argument
3663         wrapping logic.
3664         * f-lang.c (struct value): A value which can be passed into a
3665         Fortran function call.
3666         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3667         where appropriate.
3668         (struct type): Value ready for a Fortran function call.
3669         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3670         is needed.
3671         * f-lang.h (fortran_argument_convert): Declaration.
3672         (fortran_preserve_arg_pointer): Declaration.
3673         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3674
3675 2019-03-05  Tom Tromey  <tromey@adacore.com>
3676
3677         * python/py-prettyprint.c (print_string_repr): Remove #if.
3678         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3679
3680 2019-03-05  Tom Tromey  <tromey@adacore.com>
3681
3682         * target.c (the_dummy_target): Move later.  Change type to
3683         "dummy_target".
3684         (initialize_targets): Don't initialize the_dummy_target.
3685
3686 2019-03-05  Tom Tromey  <tromey@adacore.com>
3687
3688         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3689         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3690
3691 2019-03-05  Tom Tromey  <tromey@adacore.com>
3692
3693         * windows-nat.c (windows_nat_target::attach)
3694         (windows_nat_target::detach): Don't call gdb_flush.
3695         * valprint.c (generic_val_print, val_print, val_print_string):
3696         Don't call gdb_flush.
3697         * utils.c (defaulted_query): Don't call gdb_flush.
3698         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3699         * target.c (target_announce_detach): Don't call gdb_flush.
3700         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3701         * remote.c (extended_remote_target::attach): Don't call
3702         gdb_flush.
3703         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3704         * printcmd.c (do_examine): Don't call gdb_flush.
3705         (info_display_command): Don't call gdb_flush.
3706         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3707         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3708         * memattr.c (info_mem_command): Don't call gdb_flush.
3709         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3710         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3711         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3712         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3713         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3714         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3715         (gnu_nat_target::detach): Don't call gdb_flush.
3716         * f-valprint.c (f_val_print): Don't call gdb_flush.
3717         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3718         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3719         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3720         gdb_flush.
3721         * c-valprint.c (c_val_print): Don't call gdb_flush.
3722         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3723
3724 2019-03-05  Tom Tromey  <tromey@adacore.com>
3725
3726         * varobj.c (update_dynamic_varobj_children): Update.
3727         (install_default_visualizer): Use reset, not release.
3728         * value.c (set_internalvar): Update.
3729         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3730         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3731         ATTRIBUTE_UNUSED_RESULT.
3732
3733 2019-03-05  Tom Tromey  <tromey@adacore.com>
3734
3735         * remote.c (class scoped_remote_fd) <release>: Add
3736         ATTRIBUTE_UNUSED_RESULT.
3737
3738 2019-03-05  Tom Tromey  <tromey@adacore.com>
3739
3740         * macroexp.c (struct macro_buffer) <release>: Add
3741         ATTRIBUTE_UNUSED_RESULT.
3742
3743 2019-03-05  Tom Tromey  <tromey@adacore.com>
3744
3745         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3746         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3747         ATTRIBUTE_UNUSED_RESULT.
3748
3749 2019-03-05  Tom Tromey  <tromey@adacore.com>
3750
3751         * common/scoped_fd.h (class scoped_fd) <release>: Add
3752         ATTRIBUTE_UNUSED_RESULT.
3753
3754 2019-03-05  Tom Tromey  <tromey@adacore.com>
3755
3756         * parser-defs.h (struct parser_state) <release>: Add
3757         ATTRIBUTE_UNUSED_RESULT.
3758
3759 2019-03-05  Tom Tromey  <tromey@adacore.com>
3760
3761         * utils.h (class gdb_argv) <release>: Add
3762         ATTRIBUTE_UNUSED_RESULT.
3763         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3764
3765 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3766
3767         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3768         for-loop range, to avoid compiler warnings.
3769
3770         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3771         avoid compiler warnings about unused variables.
3772
3773         * NEWS: Mention end of support for native debugging on MS-Windows
3774         before XP.
3775
3776         PR gdb/24292
3777         * common/netstuff.c:
3778         * gdbserver/gdbreplay.c
3779         * gdbserver/remote-utils.c:
3780         * ser-tcp.c:
3781         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3782         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3783         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3784         'getaddrinfo' and 'freeaddrinfo' were not available before
3785         Windows XP, and mingw.org's MinGW headers by default define
3786         _WIN32_WINNT to 0x500.
3787
3788 2019-03-01  Gary Benson <gbenson@redhat.com>
3789
3790         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3791
3792 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3793             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3794
3795         PR gdb/8527
3796         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3797         set_sigint_trap, clear_sigint_trap.
3798
3799 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3800
3801         * target.c (target_detach): Clear the regcache and the
3802         frame cache.
3803
3804 2019-02-27  Pedro Alves  <palves@redhat.com>
3805
3806         * utils.c (set_screen_size): When we cap the height/width sizes,
3807         tweak the corresponding command variable to show "unlimited":
3808
3809 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3810             Pedro Alves  <palves@redhat.com>
3811
3812         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3813         before calling rl_set_screen_size.
3814
3815 2019-02-27  Tom Tromey  <tromey@adacore.com>
3816
3817         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3818         define.
3819         * python/py-value.c: Remove Python 2.4 workaround.
3820         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3821         workaround.
3822         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3823         Python 2.4 workaround.
3824         * python/python-internal.h: Remove Python 2.4 comment.
3825         (Py_ssize_t): Don't define.
3826         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3827         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3828         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3829         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3830         * python/python.c (do_start_initialization): Remove Python 2.4
3831         workaround.
3832         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3833         (print_children): Remove Python 2.4 workaround.
3834         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3835         workaround.
3836         (CHARBUFFERPROC_NAME): Remove.
3837         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3838         Python 2.4 workaround.
3839
3840 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3841
3842         * NEWS: Note minimum Python version.
3843
3844 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3845
3846         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3847         code from these functions.  Remove corresponding ifdefs.  Use
3848         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3849         Remove gotos and target of gotos.
3850         (infpy_search_memory): Likewise.
3851
3852 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3853
3854         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3855         (hppa_gdbarch_init): Don't register deleted functions with
3856         gdbarch.
3857
3858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3861         (h8300_unwind_sp): Delete.
3862         (h8300_dummy_id): Delete.
3863         (h8300_gdbarch_init): Don't register deleted functions with
3864         gdbarch.
3865
3866 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3867
3868         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3869         (ft32_unwind_pc): Delete.
3870         (ft32_unwind_sp): Delete.
3871         (ft32_gdbarch_init): Don't register deleted functions with
3872         gdbarch.
3873
3874 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3875
3876         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3877         (frv_unwind_pc): Delete.
3878         (frv_unwind_sp): Delete.
3879         (frv_gdbarch_init): Don't register deleted functions with
3880         gdbarch.
3881
3882 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3883
3884         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3885         (riscv_unwind_pc): Delete.
3886         (riscv_unwind_sp): Delete.
3887         (riscv_gdbarch_init): Don't register deleted functions with
3888         gdbarch.
3889
3890 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3891
3892         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3893         (csky_unwind_pc): Delete.
3894         (csky_unwind_sp): Delete.
3895         (csky_gdbarch_init): Don't register deleted functions with
3896         gdbarch.
3897
3898 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3899
3900         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3901         (cris_unwind_pc): Delete.
3902         (cris_unwind_sp): Delete.
3903         (cris_gdbarch_init): Don't register deleted functions with
3904         gdbarch.
3905
3906 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3907
3908         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3909         (bfin_unwind_pc): Delete.
3910         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3911
3912 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3913
3914         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3915         (arm_unwind_pc): Delete.
3916         (arm_unwind_sp): Delete.
3917         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3918
3919 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3920
3921         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3922         (arc_unwind_pc): Delete.
3923         (arc_unwind_sp): Delete.
3924         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3925
3926 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3927
3928         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3929         (alpha_unwind_pc): Delete.
3930         (alpha_gdbarch_init): Don't register deleted functions with
3931         gdbarch.
3932
3933 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3934
3935         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3936         (aarch64_unwind_pc): Delete.
3937         (aarch64_unwind_sp): Delete.
3938         (aarch64_gdbarch_init): Don't register deleted functions with
3939         gdbarch.
3940
3941 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3942
3943         * gdbtypes.c (type_align): Don't consider static members when
3944         computing structure alignment.
3945
3946 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3947
3948         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3949         return 0 for other types.
3950         * arch-utils.c (default_type_align): Always return 0.
3951         * gdbarch.h: Regenerate.
3952         * gdbarch.sh (type_align): Extend comment.
3953         * gdbtypes.c (type_align): Add additional comments, always call
3954         gdbarch_type_align before applying the default rules.
3955         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3956         generic code will then apply a suitable default.
3957         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3958         types, return 0 for other types.
3959
3960 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3961
3962         * NEWS: Create a new section for the next release branch.
3963         Rename the section of the current branch, now that it has
3964         been cut.
3965
3966 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3967
3968         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3969         * version.in: Bump version to 8.3.50.DATE-git.
3970
3971 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3972
3973         * aix-thread.c (ptid_cmp): Remove unused variable.
3974         (get_signaled_thread): Likewise.
3975         (store_regs_user_thread): Likewise.
3976         (store_regs_kernel_thread): Likewise.
3977         (fetch_regs_kernel_thread): Remove shadowed variable.
3978
3979 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3980
3981         * features/riscv/32bit-cpu.xml: Add register numbers.
3982         * features/riscv/32bit-fpu.c: Regenerate.
3983         * features/riscv/32bit-fpu.xml: Add register numbers.
3984         * features/riscv/64bit-cpu.xml: Add register numbers.
3985         * features/riscv/64bit-fpu.c: Regenerate.
3986         * features/riscv/64bit-fpu.xml: Add register numbers.
3987
3988 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3989
3990         * NEWS: Mention two argument form of gdb.Value constructor.
3991         * python/py-value.c (convert_buffer_and_type_to_value): New
3992         function.
3993         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3994         Add support for handling an optional second argument.  Call
3995         convert_buffer_and_type_to_value as appropriate.
3996         * python/python-internal.h (Py_buffer_deleter): New struct.
3997         (Py_buffer_up): New typedef.
3998
3999 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4000
4001         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4002         instead of releasing ownership.
4003
4004 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4005
4006         * dwarf2read.c (open_and_init_dwp_file): Call
4007         elf_numsections instead of bfd_count_sections to initialize
4008         dwp_file->num_sections.
4009
4010 2019-02-25  Tom Tromey  <tromey@adacore.com>
4011
4012         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4013
4014 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4015
4016         * gcore.in: Add '--readnever' option when invoking GDB.
4017
4018 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4019
4020         * MAINTAINERS: Update my email address.
4021
4022 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4023
4024         * build-id.c (build_id_to_debug_bfd_1): New function.
4025         (build_id_to_debug_bfd): Look for separate debug file in
4026         sysroot.
4027
4028 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4029
4030         * gdbarch.sh: Update the copyright year range that is placed into
4031         generated files.
4032
4033 2019-02-22  Keith Seitz  <keiths@redhat.com>
4034
4035         PR symtab/23853
4036         * linespec.c (create_sals_line_offset): Search for the default
4037         symtab's filename instead of its fullname.
4038
4039 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4040
4041         * NEWS: Update style defaults.
4042
4043 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4044
4045         * main.c (captured_main_1): Disable styling in batch mode.
4046
4047 2019-02-20  Tom Tromey  <tom@tromey.com>
4048
4049         * symtab.c (symtab_symbol_info): Fix typos.
4050
4051 2019-02-20  Tom Tromey  <tromey@adacore.com>
4052
4053         * findcmd.c (_initialize_mem_search): Use upper case for
4054         metasyntactic variables.
4055
4056 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4057
4058         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4059         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4060
4061 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4062
4063         * top.h (source_file_name): Change to std::string.
4064         * top.c (source_file_name): Likewise.
4065         (command_line_input): Adjust.
4066         * cli/cli-script.c (script_from_file): Adjust.
4067
4068 2019-02-19  Tom Tromey  <tromey@adacore.com>
4069
4070         * ravenscar-thread.c
4071         (ravenscar_thread_target::update_thread_list): Don't call
4072         ada_build_task_list.
4073         * ada-lang.h (ada_build_task_list): Don't declare.
4074         * ada-tasks.c (struct ada_tasks_inferior_data)
4075         <task_list_valid_p>: Now bool.
4076         (read_known_tasks, ada_task_list_changed)
4077         (ada_tasks_invalidate_inferior_data): Update.
4078         (read_known_tasks_array): Return bool.
4079         (read_known_tasks_list): Likewise.
4080         (read_known_tasks): Return void.
4081         (ada_build_task_list): Now static.
4082
4083 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4084
4085         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4086         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4087
4088 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4089
4090         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4091         variant for ada_tasks_pspace_data_handle and
4092         ada_tasks_inferior_data_handle.
4093         (ada_tasks_pspace_data_cleanup): New function.
4094         (ada_tasks_inferior_data_cleanup): New function.
4095
4096 2019-02-17  Tom Tromey  <tom@tromey.com>
4097
4098         * macrotab.h (macro_source_fullname): Return a std::string.
4099         * macrotab.c (macro_include, check_for_redefinition)
4100         (macro_undef, macro_lookup_definition, foreach_macro)
4101         (foreach_macro_in_scope): Update.
4102         (macro_source_fullname): Return a std::string.
4103         * macrocmd.c (show_pp_source_pos): Update.
4104
4105 2019-02-17  Tom Tromey  <tom@tromey.com>
4106
4107         * macrocmd.c (show_pp_source_pos): Style the file names.
4108
4109 2019-02-17  Tom Tromey  <tom@tromey.com>
4110
4111         PR tui/24197:
4112         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4113
4114 2019-02-17  Tom Tromey  <tom@tromey.com>
4115
4116         * ada-lang.c (user_select_syms): Use filtered printing.
4117         * utils.c (wrap_style): New global.
4118         (desired_style): Remove.
4119         (emit_style_escape): Add stream parameter.
4120         (set_output_style, reset_terminal_style, prompt_for_continue):
4121         Update.
4122         (flush_wrap_buffer): Only flush gdb_stdout.
4123         (wrap_here): Set wrap_style.
4124         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4125         treat escape sequences as a character.  Change when wrap buffer is
4126         flushed.
4127         (fputs_styled): Do not set the output style when the default is
4128         requested.
4129         * ui-style.h (struct ui_file_style) <is_default>: New method.
4130         * source.c (print_source_lines_base): Emit escape sequences in one
4131         piece.
4132
4133 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4134
4135         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4136         integers and enumeration types.
4137
4138 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4139
4140         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4141         instead of lookup_symbol_in_language
4142         (do_exact_match): New function.
4143         (ada_get_symbol_name_matcher): Return do_exact_match when
4144         doing a verbatim match.
4145
4146 2019-02-15  Tom Tromey  <tromey@adacore.com>
4147
4148         * ravenscar-thread.c (ravenscar_thread_target::resume)
4149         (ravenscar_thread_target::wait): Special case wildcard requests.
4150
4151 2019-02-15  Tom Tromey  <tromey@adacore.com>
4152
4153         * ravenscar-thread.c (base_ptid): Remove.
4154         (struct ravenscar_thread_target) <close>: New method.
4155         <m_base_ptid>: New member.
4156         <update_inferior_ptid, active_task, task_is_currently_active,
4157         runtime_initialized>: Declare methods.
4158         <ravenscar_thread_target>: Add constructor.
4159         (ravenscar_thread_target::task_is_currently_active)
4160         (ravenscar_thread_target::update_inferior_ptid)
4161         (ravenscar_runtime_initialized): Rename.  Now methods.
4162         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4163         (ravenscar_thread_target::update_thread_list): Update.
4164         (ravenscar_thread_target::active_task): Now method.
4165         (ravenscar_thread_target::store_registers)
4166         (ravenscar_thread_target::prepare_to_store)
4167         (ravenscar_thread_target::prepare_to_store)
4168         (ravenscar_thread_target::mourn_inferior): Update.
4169         (ravenscar_inferior_created): Use "new" to create target.
4170         (ravenscar_thread_target::get_ada_task_ptid): Update.
4171         (_initialize_ravenscar): Don't initialize base_ptid.
4172         (ravenscar_ops): Remove global.
4173
4174 2019-02-15  Tom Tromey  <tromey@adacore.com>
4175
4176         * target.h (push_target): Declare new overload.
4177         * target.c (push_target): New overload, taking an rvalue reference.
4178         * remote.c (remote_target::open_1): Use push_target overload.
4179         * corelow.c (core_target_open): Use push_target overload.
4180
4181 2019-02-15  Tom Tromey  <tromey@adacore.com>
4182
4183         * ravenscar-thread.c (is_ravenscar_task)
4184         (ravenscar_task_is_currently_active): Return bool.
4185         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4186         (_initialize_ravenscar): Remove "(void)".
4187         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4188         Return bool.
4189
4190 2019-02-15  Tom Tromey  <tromey@adacore.com>
4191
4192         * ravenscar-thread.c (ravenscar_runtime_initializer)
4193         (has_ravenscar_runtime, get_running_thread_id)
4194         (ravenscar_thread_target::resume): Fix indentation.
4195
4196 2019-02-15  Tom Tromey  <tromey@adacore.com>
4197
4198         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4199         from ravenscar_arch_ops.
4200         (sparc_ravenscar_ops::fetch_registers)
4201         (sparc_ravenscar_ops::store_registers): Now methods.
4202         (sparc_ravenscar_prepare_to_store): Remove.
4203         (sparc_ravenscar_ops): Redefine.
4204         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4205         methods and destructor.  Remove members.
4206         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4207         (ravenscar_thread_target::store_registers)
4208         (ravenscar_thread_target::prepare_to_store): Update.
4209         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4210         Remove.
4211         (struct ppc_ravenscar_powerpc_ops): Derive from
4212         ravenscar_arch_ops.
4213         (ppc_ravenscar_powerpc_ops::fetch_registers)
4214         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4215         (ppc_ravenscar_powerpc_ops): Redefine.
4216         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4217         (ppc_ravenscar_e500_ops::fetch_registers)
4218         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4219         (ppc_ravenscar_e500_ops): Redefine.
4220         * aarch64-ravenscar-thread.c
4221         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4222         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4223         (aarch64_ravenscar_fetch_registers)
4224         (aarch64_ravenscar_store_registers): Now methods.
4225         (aarch64_ravenscar_ops): Redefine.
4226
4227 2019-02-15  Tom Tromey  <tromey@adacore.com>
4228
4229         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4230         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4231         (ravenscar_thread_target::stopped_by_watchpoint)
4232         (ravenscar_thread_target::stopped_data_address)
4233         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4234
4235 2019-02-15  Tom Tromey  <tromey@adacore.com>
4236
4237         * ravenscar-thread.c: Fix some typos.
4238
4239 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4240             Tom Tromey  <tromey@adacore.com>
4241
4242         * ada-lang.c (ada_exception_sal): Change addr_string to a
4243         std::string.
4244         (create_ada_exception_catchpoint): Update.
4245
4246 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4247             Tom Tromey  <tromey@adacore.com>
4248
4249         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4250         (bp_location_ops): Remove.
4251         (base_breakpoint_allocate_location): Update.
4252         (free_bp_location): Update.
4253         * ada-lang.c (class ada_catchpoint_location)
4254         <ada_catchpoint_location>: Remove ops parameter.
4255         (ada_catchpoint_location_dtor): Remove.
4256         (ada_catchpoint_location_ops): Remove.
4257         (allocate_location_exception): Update.
4258         * breakpoint.h (struct bp_location_ops): Remove.
4259         (class bp_location) <bp_location>: Remove bp_location_ops
4260         parameter.
4261         <~bp_location>: Add destructor.
4262         <ops>: Remove.
4263
4264 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4265             Pedro Alves  <palves@redhat.com>
4266
4267         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4268         'PATH_MAX'.
4269
4270 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4271             Samuel Thibault  <samuel.thibault@gnu.org>
4272             Thomas Schwinge  <thomas@codesourcery.com>
4273
4274         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4275         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4276
4277 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4278
4279         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4280         (check_empty): Use "const char *".
4281
4282         * gnu-nat.c (gnu_nat_target::detach): Instead of
4283         'detach_inferior (pid)' call
4284         'detach_inferior (find_inferior_pid (pid))'.
4285
4286         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4287         'nat/fork-inferior.o'.
4288         * gnu-nat.c: #include "nat/fork-inferior.h".
4289
4290         * gnu-nat.c (gnu_nat_target::detach): Instead of
4291         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4292         * gnu-nat.h: #include "inf-child.h".
4293         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4294         'i386_gnu_nat_target::fetch_registers'.
4295         (gnu_store_registers): Rename/move to
4296         'i386_gnu_nat_target::store_registers'.
4297
4298         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4299         * gnu-nat.h (mach_thread_info): New function.
4300         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4301
4302         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4303
4304 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4305
4306         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4307
4308 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4309
4310         * windows-nat.c (windows_add_thread): Add new parameter
4311         "main_thread_p" with default value set to false.  Update
4312         function documentation as well as all callers.
4313         (windows_delete_thread): Likewise.
4314         (fake_create_process): Update call to windows_add_thread.
4315         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4316         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4317         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4318         call to windows_delete_thread.
4319
4320 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4321
4322         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4323
4324 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4325
4326         * symfile.c (find_separate_debug_file): Use canonical path of
4327         sysroot with child_path instead of gdb_sysroot if it is valid.
4328
4329 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4330
4331         * symfile.c (find_separate_debug_file): Use child_path to
4332         determine if an object file is under a sysroot.
4333
4334 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4335
4336         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4337         unittests/child-path-selftests.c.
4338         * common/pathstuff.c (child_path): New function.
4339         * common/pathstuff.h (child_path): New prototype.
4340         * unittests/child-path-selftests.c: New file.
4341
4342 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4343
4344         * symfile.c (find_separate_debug_file): Look for separate debug
4345         files in debug directories under the sysroot.
4346
4347 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4348
4349         * symtab.h (struct minimal_symbol data_p): New const method.
4350         (struct minimal_symbol text_p): Likewise.
4351         * symtab.c (output_source_filename): Use file name style
4352         to print file name.
4353         (print_symbol_info): Likewise.
4354         (print_msymbol_info): Use address style to print addresses.
4355         Use function name style to print executable text symbols.
4356         (expand_symtab_containing_pc): Use data_p.
4357         (find_pc_sect_compunit_symtab): Likewise.
4358
4359 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4360
4361         * breakpoint.c (describe_other_breakpoints): Use address style
4362         to print addresses.
4363         (say_where): Likewise.
4364
4365 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4366
4367         * ada-typeprint.c (print_func_type): Print function name
4368         style to print function name.
4369         * c-typeprint.c (c_print_type_1): Likewise.
4370
4371 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4372
4373         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4374         for execve.
4375
4376 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4377
4378         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4379         type_stack.
4380
4381 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4382
4383         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4384         TYPE_CODE_REF types.
4385
4386 2019-02-08  Jim Wilson  <jimw@sifive.com>
4387
4388         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4389         (riscv_linux_fregset): New.
4390         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4391
4392 2019-02-07  Tom Tromey  <tom@tromey.com>
4393
4394         * thread.c (thread_cancel_execution_command): Update.
4395         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4396         methods.
4397         (struct thread_fsm_ops): Remove.
4398         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4399         (thread_fsm_should_stop, thread_fsm_return_value)
4400         (thread_fsm_set_finished, thread_fsm_finished_p)
4401         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4402         Don't declare.
4403         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4404         * infrun.c (clear_proceed_status_thread)
4405         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4406         (print_stop_event): Update.
4407         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4408         Add constructor.
4409         (step_command_fsm_ops): Remove.
4410         (new_step_command_fsm): Remove.
4411         (step_1): Update.
4412         (step_command_fsm::should_stop): Rename from
4413         step_command_fsm_should_stop.
4414         (step_command_fsm::clean_up): Rename from
4415         step_command_fsm_clean_up.
4416         (step_command_fsm::do_async_reply_reason): Rename from
4417         step_command_fsm_async_reply_reason.
4418         (struct until_next_fsm): Inherit from thread_fsm.  Add
4419         constructor.
4420         (until_next_fsm_ops): Remove.
4421         (new_until_next_fsm): Remove.
4422         (until_next_fsm::should_stop): Rename from
4423         until_next_fsm_should_stop.
4424         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4425         (until_next_fsm::do_async_reply_reason): Rename from
4426         until_next_fsm_async_reply_reason.
4427         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4428         constructor.  Change type of breakpoint.
4429         (finish_command_fsm_ops): Remove.
4430         (new_finish_command_fsm): Remove.
4431         (finish_command_fsm::should_stop): Rename from
4432         finish_command_fsm_should_stop.
4433         (finish_command_fsm::clean_up): Rename from
4434         finish_command_fsm_clean_up.
4435         (finish_command_fsm::return_value): Rename from
4436         finish_command_fsm_return_value.
4437         (finish_command_fsm::do_async_reply_reason): Rename from
4438         finish_command_fsm_async_reply_reason.
4439         (finish_command): Update.
4440         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4441         Add constructor.
4442         (call_thread_fsm_ops): Remove.
4443         (call_thread_fsm::call_thread_fsm): Rename from
4444         new_call_thread_fsm.
4445         (call_thread_fsm::should_stop): Rename from
4446         call_thread_fsm_should_stop.
4447         (call_thread_fsm::should_notify_stop): Rename from
4448         call_thread_fsm_should_notify_stop.
4449         (run_inferior_call, call_function_by_hand_dummy): Update.
4450         * cli/cli-interp.c (should_print_stop_to_console): Update.
4451         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4452         Add constructor.  Change type of location_breakpoint,
4453         caller_breakpoint.
4454         (until_break_fsm_ops): Remove.
4455         (new_until_break_fsm): Remove.
4456         (until_break_fsm::should_stop): Rename from
4457         until_break_fsm_should_stop.
4458         (until_break_fsm::clean_up): Rename from
4459         until_break_fsm_clean_up.
4460         (until_break_fsm::do_async_reply_reason): Rename from
4461         until_break_fsm_async_reply_reason.
4462         (until_break_command): Update.
4463         * thread-fsm.c: Remove.
4464         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4465
4466 2019-02-07  Tom Tromey  <tom@tromey.com>
4467
4468         * yy-remap.h: Add include guard.
4469         * xtensa-tdep.h: Add include guard.
4470         * xcoffread.h: Rename include guard.
4471         * varobj-iter.h: Add include guard.
4472         * tui/tui.h: Rename include guard.
4473         * tui/tui-winsource.h: Rename include guard.
4474         * tui/tui-wingeneral.h: Rename include guard.
4475         * tui/tui-windata.h: Rename include guard.
4476         * tui/tui-win.h: Rename include guard.
4477         * tui/tui-stack.h: Rename include guard.
4478         * tui/tui-source.h: Rename include guard.
4479         * tui/tui-regs.h: Rename include guard.
4480         * tui/tui-out.h: Rename include guard.
4481         * tui/tui-layout.h: Rename include guard.
4482         * tui/tui-io.h: Rename include guard.
4483         * tui/tui-hooks.h: Rename include guard.
4484         * tui/tui-file.h: Rename include guard.
4485         * tui/tui-disasm.h: Rename include guard.
4486         * tui/tui-data.h: Rename include guard.
4487         * tui/tui-command.h: Rename include guard.
4488         * tic6x-tdep.h: Add include guard.
4489         * target/waitstatus.h: Rename include guard.
4490         * target/wait.h: Rename include guard.
4491         * target/target.h: Rename include guard.
4492         * target/resume.h: Rename include guard.
4493         * target-float.h: Rename include guard.
4494         * stabsread.h: Add include guard.
4495         * rs6000-tdep.h: Add include guard.
4496         * riscv-fbsd-tdep.h: Add include guard.
4497         * regformats/regdef.h: Rename include guard.
4498         * record.h: Rename include guard.
4499         * python/python.h: Rename include guard.
4500         * python/python-internal.h: Rename include guard.
4501         * python/py-stopevent.h: Rename include guard.
4502         * python/py-ref.h: Rename include guard.
4503         * python/py-record.h: Rename include guard.
4504         * python/py-record-full.h: Rename include guard.
4505         * python/py-record-btrace.h: Rename include guard.
4506         * python/py-instruction.h: Rename include guard.
4507         * python/py-events.h: Rename include guard.
4508         * python/py-event.h: Rename include guard.
4509         * procfs.h: Add include guard.
4510         * proc-utils.h: Add include guard.
4511         * p-lang.h: Add include guard.
4512         * or1k-tdep.h: Rename include guard.
4513         * observable.h: Rename include guard.
4514         * nto-tdep.h: Rename include guard.
4515         * nat/x86-linux.h: Rename include guard.
4516         * nat/x86-linux-dregs.h: Rename include guard.
4517         * nat/x86-gcc-cpuid.h: Add include guard.
4518         * nat/x86-dregs.h: Rename include guard.
4519         * nat/x86-cpuid.h: Rename include guard.
4520         * nat/ppc-linux.h: Rename include guard.
4521         * nat/mips-linux-watch.h: Rename include guard.
4522         * nat/linux-waitpid.h: Rename include guard.
4523         * nat/linux-ptrace.h: Rename include guard.
4524         * nat/linux-procfs.h: Rename include guard.
4525         * nat/linux-osdata.h: Rename include guard.
4526         * nat/linux-nat.h: Rename include guard.
4527         * nat/linux-namespaces.h: Rename include guard.
4528         * nat/linux-btrace.h: Rename include guard.
4529         * nat/glibc_thread_db.h: Rename include guard.
4530         * nat/gdb_thread_db.h: Rename include guard.
4531         * nat/gdb_ptrace.h: Rename include guard.
4532         * nat/fork-inferior.h: Rename include guard.
4533         * nat/amd64-linux-siginfo.h: Rename include guard.
4534         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4535         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4536         * nat/aarch64-linux.h: Rename include guard.
4537         * nat/aarch64-linux-hw-point.h: Rename include guard.
4538         * mn10300-tdep.h: Add include guard.
4539         * mips-linux-tdep.h: Add include guard.
4540         * mi/mi-parse.h: Rename include guard.
4541         * mi/mi-out.h: Rename include guard.
4542         * mi/mi-main.h: Rename include guard.
4543         * mi/mi-interp.h: Rename include guard.
4544         * mi/mi-getopt.h: Rename include guard.
4545         * mi/mi-console.h: Rename include guard.
4546         * mi/mi-common.h: Rename include guard.
4547         * mi/mi-cmds.h: Rename include guard.
4548         * mi/mi-cmd-break.h: Rename include guard.
4549         * m2-lang.h: Add include guard.
4550         * location.h: Rename include guard.
4551         * linux-record.h: Rename include guard.
4552         * linux-nat.h: Add include guard.
4553         * linux-fork.h: Add include guard.
4554         * i386-darwin-tdep.h: Rename include guard.
4555         * hppa-linux-offsets.h: Add include guard.
4556         * guile/guile.h: Rename include guard.
4557         * guile/guile-internal.h: Rename include guard.
4558         * gnu-nat.h: Rename include guard.
4559         * gdb-stabs.h: Rename include guard.
4560         * frv-tdep.h: Add include guard.
4561         * f-lang.h: Add include guard.
4562         * event-loop.h: Add include guard.
4563         * darwin-nat.h: Rename include guard.
4564         * cp-abi.h: Rename include guard.
4565         * config/sparc/nm-sol2.h: Rename include guard.
4566         * config/nm-nto.h: Rename include guard.
4567         * config/nm-linux.h: Add include guard.
4568         * config/i386/nm-i386gnu.h: Rename include guard.
4569         * config/djgpp/nl_types.h: Rename include guard.
4570         * config/djgpp/langinfo.h: Rename include guard.
4571         * compile/gcc-cp-plugin.h: Add include guard.
4572         * compile/gcc-c-plugin.h: Add include guard.
4573         * compile/compile.h: Rename include guard.
4574         * compile/compile-object-run.h: Rename include guard.
4575         * compile/compile-object-load.h: Rename include guard.
4576         * compile/compile-internal.h: Rename include guard.
4577         * compile/compile-cplus.h: Rename include guard.
4578         * compile/compile-c.h: Rename include guard.
4579         * common/xml-utils.h: Rename include guard.
4580         * common/x86-xstate.h: Rename include guard.
4581         * common/version.h: Rename include guard.
4582         * common/vec.h: Rename include guard.
4583         * common/tdesc.h: Rename include guard.
4584         * common/selftest.h: Rename include guard.
4585         * common/scoped_restore.h: Rename include guard.
4586         * common/scoped_mmap.h: Rename include guard.
4587         * common/scoped_fd.h: Rename include guard.
4588         * common/safe-iterator.h: Rename include guard.
4589         * common/run-time-clock.h: Rename include guard.
4590         * common/refcounted-object.h: Rename include guard.
4591         * common/queue.h: Rename include guard.
4592         * common/ptid.h: Rename include guard.
4593         * common/print-utils.h: Rename include guard.
4594         * common/preprocessor.h: Rename include guard.
4595         * common/pathstuff.h: Rename include guard.
4596         * common/observable.h: Rename include guard.
4597         * common/netstuff.h: Rename include guard.
4598         * common/job-control.h: Rename include guard.
4599         * common/host-defs.h: Rename include guard.
4600         * common/gdb_wait.h: Rename include guard.
4601         * common/gdb_vecs.h: Rename include guard.
4602         * common/gdb_unlinker.h: Rename include guard.
4603         * common/gdb_unique_ptr.h: Rename include guard.
4604         * common/gdb_tilde_expand.h: Rename include guard.
4605         * common/gdb_sys_time.h: Rename include guard.
4606         * common/gdb_string_view.h: Rename include guard.
4607         * common/gdb_splay_tree.h: Rename include guard.
4608         * common/gdb_setjmp.h: Rename include guard.
4609         * common/gdb_ref_ptr.h: Rename include guard.
4610         * common/gdb_optional.h: Rename include guard.
4611         * common/gdb_locale.h: Rename include guard.
4612         * common/gdb_assert.h: Rename include guard.
4613         * common/filtered-iterator.h: Rename include guard.
4614         * common/filestuff.h: Rename include guard.
4615         * common/fileio.h: Rename include guard.
4616         * common/environ.h: Rename include guard.
4617         * common/common-utils.h: Rename include guard.
4618         * common/common-types.h: Rename include guard.
4619         * common/common-regcache.h: Rename include guard.
4620         * common/common-inferior.h: Rename include guard.
4621         * common/common-gdbthread.h: Rename include guard.
4622         * common/common-exceptions.h: Rename include guard.
4623         * common/common-defs.h: Rename include guard.
4624         * common/common-debug.h: Rename include guard.
4625         * common/cleanups.h: Rename include guard.
4626         * common/buffer.h: Rename include guard.
4627         * common/btrace-common.h: Rename include guard.
4628         * common/break-common.h: Rename include guard.
4629         * cli/cli-utils.h: Rename include guard.
4630         * cli/cli-style.h: Rename include guard.
4631         * cli/cli-setshow.h: Rename include guard.
4632         * cli/cli-script.h: Rename include guard.
4633         * cli/cli-interp.h: Rename include guard.
4634         * cli/cli-decode.h: Rename include guard.
4635         * cli/cli-cmds.h: Rename include guard.
4636         * charset-list.h: Add include guard.
4637         * buildsym-legacy.h: Rename include guard.
4638         * bfin-tdep.h: Add include guard.
4639         * ax.h: Rename include guard.
4640         * arm-linux-tdep.h: Add include guard.
4641         * arm-fbsd-tdep.h: Add include guard.
4642         * arch/xtensa.h: Rename include guard.
4643         * arch/tic6x.h: Add include guard.
4644         * arch/i386.h: Add include guard.
4645         * arch/arm.h: Rename include guard.
4646         * arch/arm-linux.h: Rename include guard.
4647         * arch/arm-get-next-pcs.h: Rename include guard.
4648         * arch/amd64.h: Add include guard.
4649         * arch/aarch64-insn.h: Rename include guard.
4650         * arch-utils.h: Rename include guard.
4651         * annotate.h: Add include guard.
4652         * amd64-darwin-tdep.h: Rename include guard.
4653         * aarch64-linux-tdep.h: Add include guard.
4654         * aarch64-fbsd-tdep.h: Add include guard.
4655         * aarch32-linux-nat.h: Add include guard.
4656
4657 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4658
4659         * macrotab.c (macro_define_internal): New function that
4660         factorizes macro_define_object_internal and macro_define_function
4661         code.
4662         (macro_define_object_internal): Use macro_define_internal.
4663         (macro_define_function): Likewise.
4664
4665 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4666
4667         * macrocmd.c (extract_identifier): Return
4668         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4669         callers.
4670
4671 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4672
4673         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4674
4675 2019-02-05  Tom Tromey  <tom@tromey.com>
4676
4677         * target.c (target_stack::unpush): Move assertion earlier.
4678
4679 2019-01-30  Tom Tromey  <tom@tromey.com>
4680
4681         PR python/23615:
4682         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4683         (gdbpy_parse_and_eval): Likewise.
4684         * python/python-internal.h (gdbpy_allow_threads): New class.
4685
4686 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4687
4688         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4689         (aarch64_fbsd_fpregmap): Move earlier.
4690         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4691         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4692         instead of individual calls to trad_frame_set_reg_addr.
4693         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4694         earlier.
4695         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4696         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4697         instead of individual calls to trad_frame_set_reg_addr.
4698
4699 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4700
4701         * CONTRIBUTE: Replace contribution list with wiki link.
4702
4703 2019-01-25  Tom Tromey  <tom@tromey.com>
4704
4705         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4706
4707 2019-01-25  Tom Tromey  <tom@tromey.com>
4708
4709         * xtensa-linux-nat.c: Fix common/ includes.
4710         * xml-support.h: Fix common/ includes.
4711         * xml-support.c: Fix common/ includes.
4712         * x86-linux-nat.c: Fix common/ includes.
4713         * windows-nat.c: Fix common/ includes.
4714         * varobj.h: Fix common/ includes.
4715         * varobj.c: Fix common/ includes.
4716         * value.c: Fix common/ includes.
4717         * valops.c: Fix common/ includes.
4718         * utils.c: Fix common/ includes.
4719         * unittests/xml-utils-selftests.c: Fix common/ includes.
4720         * unittests/utils-selftests.c: Fix common/ includes.
4721         * unittests/unpack-selftests.c: Fix common/ includes.
4722         * unittests/tracepoint-selftests.c: Fix common/ includes.
4723         * unittests/style-selftests.c: Fix common/ includes.
4724         * unittests/string_view-selftests.c: Fix common/ includes.
4725         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4726         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4727         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4728         * unittests/rsp-low-selftests.c: Fix common/ includes.
4729         * unittests/parse-connection-spec-selftests.c: Fix common/
4730         includes.
4731         * unittests/optional-selftests.c: Fix common/ includes.
4732         * unittests/offset-type-selftests.c: Fix common/ includes.
4733         * unittests/observable-selftests.c: Fix common/ includes.
4734         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4735         * unittests/memrange-selftests.c: Fix common/ includes.
4736         * unittests/memory-map-selftests.c: Fix common/ includes.
4737         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4738         * unittests/function-view-selftests.c: Fix common/ includes.
4739         * unittests/environ-selftests.c: Fix common/ includes.
4740         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4741         * unittests/common-utils-selftests.c: Fix common/ includes.
4742         * unittests/cli-utils-selftests.c: Fix common/ includes.
4743         * unittests/array-view-selftests.c: Fix common/ includes.
4744         * ui-file.c: Fix common/ includes.
4745         * tui/tui-io.c: Fix common/ includes.
4746         * tracepoint.h: Fix common/ includes.
4747         * tracepoint.c: Fix common/ includes.
4748         * tracefile-tfile.c: Fix common/ includes.
4749         * top.h: Fix common/ includes.
4750         * top.c: Fix common/ includes.
4751         * thread.c: Fix common/ includes.
4752         * target/waitstatus.h: Fix common/ includes.
4753         * target/waitstatus.c: Fix common/ includes.
4754         * target.h: Fix common/ includes.
4755         * target.c: Fix common/ includes.
4756         * target-memory.c: Fix common/ includes.
4757         * target-descriptions.c: Fix common/ includes.
4758         * symtab.h: Fix common/ includes.
4759         * symfile.c: Fix common/ includes.
4760         * stap-probe.c: Fix common/ includes.
4761         * spu-linux-nat.c: Fix common/ includes.
4762         * sparc-nat.c: Fix common/ includes.
4763         * source.c: Fix common/ includes.
4764         * solib.c: Fix common/ includes.
4765         * solib-target.c: Fix common/ includes.
4766         * ser-unix.c: Fix common/ includes.
4767         * ser-tcp.c: Fix common/ includes.
4768         * ser-pipe.c: Fix common/ includes.
4769         * ser-base.c: Fix common/ includes.
4770         * selftest-arch.c: Fix common/ includes.
4771         * s12z-tdep.c: Fix common/ includes.
4772         * rust-exp.y: Fix common/ includes.
4773         * rs6000-aix-tdep.c: Fix common/ includes.
4774         * riscv-tdep.c: Fix common/ includes.
4775         * remote.c: Fix common/ includes.
4776         * remote-notif.h: Fix common/ includes.
4777         * remote-fileio.h: Fix common/ includes.
4778         * remote-fileio.c: Fix common/ includes.
4779         * regcache.h: Fix common/ includes.
4780         * regcache.c: Fix common/ includes.
4781         * record-btrace.c: Fix common/ includes.
4782         * python/python.c: Fix common/ includes.
4783         * python/py-type.c: Fix common/ includes.
4784         * python/py-inferior.c: Fix common/ includes.
4785         * progspace.h: Fix common/ includes.
4786         * producer.c: Fix common/ includes.
4787         * procfs.c: Fix common/ includes.
4788         * proc-api.c: Fix common/ includes.
4789         * printcmd.c: Fix common/ includes.
4790         * ppc-linux-nat.c: Fix common/ includes.
4791         * parser-defs.h: Fix common/ includes.
4792         * osdata.c: Fix common/ includes.
4793         * obsd-nat.c: Fix common/ includes.
4794         * nat/x86-linux.c: Fix common/ includes.
4795         * nat/x86-linux-dregs.c: Fix common/ includes.
4796         * nat/x86-dregs.h: Fix common/ includes.
4797         * nat/x86-dregs.c: Fix common/ includes.
4798         * nat/ppc-linux.c: Fix common/ includes.
4799         * nat/mips-linux-watch.h: Fix common/ includes.
4800         * nat/mips-linux-watch.c: Fix common/ includes.
4801         * nat/linux-waitpid.c: Fix common/ includes.
4802         * nat/linux-ptrace.h: Fix common/ includes.
4803         * nat/linux-ptrace.c: Fix common/ includes.
4804         * nat/linux-procfs.c: Fix common/ includes.
4805         * nat/linux-personality.c: Fix common/ includes.
4806         * nat/linux-osdata.c: Fix common/ includes.
4807         * nat/linux-namespaces.c: Fix common/ includes.
4808         * nat/linux-btrace.h: Fix common/ includes.
4809         * nat/linux-btrace.c: Fix common/ includes.
4810         * nat/fork-inferior.c: Fix common/ includes.
4811         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4812         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4813         * nat/aarch64-linux.c: Fix common/ includes.
4814         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4815         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4816         * namespace.h: Fix common/ includes.
4817         * mips-linux-tdep.c: Fix common/ includes.
4818         * minsyms.c: Fix common/ includes.
4819         * mi/mi-parse.h: Fix common/ includes.
4820         * mi/mi-main.c: Fix common/ includes.
4821         * mi/mi-cmd-env.c: Fix common/ includes.
4822         * memrange.h: Fix common/ includes.
4823         * memattr.c: Fix common/ includes.
4824         * maint.h: Fix common/ includes.
4825         * maint.c: Fix common/ includes.
4826         * main.c: Fix common/ includes.
4827         * machoread.c: Fix common/ includes.
4828         * location.c: Fix common/ includes.
4829         * linux-thread-db.c: Fix common/ includes.
4830         * linux-nat.c: Fix common/ includes.
4831         * linux-fork.c: Fix common/ includes.
4832         * inline-frame.c: Fix common/ includes.
4833         * infrun.c: Fix common/ includes.
4834         * inflow.c: Fix common/ includes.
4835         * inferior.h: Fix common/ includes.
4836         * inferior.c: Fix common/ includes.
4837         * infcmd.c: Fix common/ includes.
4838         * inf-ptrace.c: Fix common/ includes.
4839         * inf-child.c: Fix common/ includes.
4840         * ia64-linux-nat.c: Fix common/ includes.
4841         * i387-tdep.c: Fix common/ includes.
4842         * i386-tdep.c: Fix common/ includes.
4843         * i386-linux-tdep.c: Fix common/ includes.
4844         * i386-linux-nat.c: Fix common/ includes.
4845         * i386-go32-tdep.c: Fix common/ includes.
4846         * i386-fbsd-tdep.c: Fix common/ includes.
4847         * i386-fbsd-nat.c: Fix common/ includes.
4848         * guile/scm-type.c: Fix common/ includes.
4849         * guile/guile.c: Fix common/ includes.
4850         * go32-nat.c: Fix common/ includes.
4851         * gnu-nat.c: Fix common/ includes.
4852         * gdbthread.h: Fix common/ includes.
4853         * gdbarch-selftests.c: Fix common/ includes.
4854         * gdb_usleep.c: Fix common/ includes.
4855         * gdb_select.h: Fix common/ includes.
4856         * gdb_bfd.c: Fix common/ includes.
4857         * gcore.c: Fix common/ includes.
4858         * fork-child.c: Fix common/ includes.
4859         * findvar.c: Fix common/ includes.
4860         * fbsd-nat.c: Fix common/ includes.
4861         * event-top.c: Fix common/ includes.
4862         * event-loop.c: Fix common/ includes.
4863         * dwarf2read.c: Fix common/ includes.
4864         * dwarf2loc.c: Fix common/ includes.
4865         * dwarf2-frame.c: Fix common/ includes.
4866         * dwarf-index-cache.c: Fix common/ includes.
4867         * dtrace-probe.c: Fix common/ includes.
4868         * disasm-selftests.c: Fix common/ includes.
4869         * defs.h: Fix common/ includes.
4870         * csky-tdep.c: Fix common/ includes.
4871         * cp-valprint.c: Fix common/ includes.
4872         * cp-support.h: Fix common/ includes.
4873         * cp-support.c: Fix common/ includes.
4874         * corelow.c: Fix common/ includes.
4875         * completer.h: Fix common/ includes.
4876         * completer.c: Fix common/ includes.
4877         * compile/compile.c: Fix common/ includes.
4878         * compile/compile-loc2c.c: Fix common/ includes.
4879         * compile/compile-cplus-types.c: Fix common/ includes.
4880         * compile/compile-cplus-symbols.c: Fix common/ includes.
4881         * command.h: Fix common/ includes.
4882         * cli/cli-dump.c: Fix common/ includes.
4883         * cli/cli-cmds.c: Fix common/ includes.
4884         * charset.c: Fix common/ includes.
4885         * build-id.c: Fix common/ includes.
4886         * btrace.h: Fix common/ includes.
4887         * btrace.c: Fix common/ includes.
4888         * breakpoint.h: Fix common/ includes.
4889         * breakpoint.c: Fix common/ includes.
4890         * ax.h:
4891         (enum agent_op): Fix common/ includes.
4892         * ax-general.c (struct aop_map): Fix common/ includes.
4893         * ax-gdb.c: Fix common/ includes.
4894         * auxv.c: Fix common/ includes.
4895         * auto-load.c: Fix common/ includes.
4896         * arm-tdep.c: Fix common/ includes.
4897         * arch/riscv.c: Fix common/ includes.
4898         * arch/ppc-linux-common.c: Fix common/ includes.
4899         * arch/i386.c: Fix common/ includes.
4900         * arch/arm.c: Fix common/ includes.
4901         * arch/arm-linux.c: Fix common/ includes.
4902         * arch/arm-get-next-pcs.c: Fix common/ includes.
4903         * arch/amd64.c: Fix common/ includes.
4904         * arch/aarch64.c: Fix common/ includes.
4905         * arch/aarch64-insn.c: Fix common/ includes.
4906         * arch-utils.c: Fix common/ includes.
4907         * amd64-windows-tdep.c: Fix common/ includes.
4908         * amd64-tdep.c: Fix common/ includes.
4909         * amd64-sol2-tdep.c: Fix common/ includes.
4910         * amd64-obsd-tdep.c: Fix common/ includes.
4911         * amd64-nbsd-tdep.c: Fix common/ includes.
4912         * amd64-linux-tdep.c: Fix common/ includes.
4913         * amd64-linux-nat.c: Fix common/ includes.
4914         * amd64-fbsd-tdep.c: Fix common/ includes.
4915         * amd64-fbsd-nat.c: Fix common/ includes.
4916         * amd64-dicos-tdep.c: Fix common/ includes.
4917         * amd64-darwin-tdep.c: Fix common/ includes.
4918         * agent.c: Fix common/ includes.
4919         * ada-lang.h: Fix common/ includes.
4920         * ada-lang.c: Fix common/ includes.
4921         * aarch64-tdep.c: Fix common/ includes.
4922
4923 2019-01-25  Tom Tromey  <tom@tromey.com>
4924
4925         * common/create-version.sh: Use common/version.h.
4926
4927 2019-01-24  Pedro Alves  <palves@redhat.com>
4928
4929         * infrun.c (signal_stop, signal_print, signal_program)
4930         (signal_catch, signal_pass): Now arrays instead of pointers.
4931         (update_signals_program_target, do_target_resume)
4932         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4933         * linux-nat.c (linux_nat_target::pass_signals)
4934         (linux_nat_target::create_inferior, linux_nat_target::attach):
4935         Adjust.
4936         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4937         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4938         * procfs.c (procfs_target::pass_signals): Adjust.
4939         * record-full.c (record_full_target::resume): Adjust.
4940         * remote.c (remote_target::pass_signals)
4941         (remote_target::program_signals): Adjust.
4942         * target-debug.h (target_debug_print_signals): Now takes a
4943         gdb::array_view as parameter.  Adjust.
4944         * target.h (target_ops) <pass_signals, program_signals>: Replace
4945         pointer and length parameters with gdb::array_view.
4946         (target_pass_signals, target_program_signals): Likewise.
4947         * target-delegates.c: Regenerate.
4948
4949 2019-01-24  Pedro Alves  <palves@redhat.com>
4950
4951         * common/forward-scope-exit.h
4952         (forward_scope_exit::forward_scope_exit): Pass arguments to
4953         m_bind_function directly, instead of creating a std::bind and
4954         copying that.
4955
4956 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4957
4958         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4959         for static members.
4960         (pass_in_v_vfp_candidate): Likewise.
4961
4962 2019-01-23  Tom Tromey  <tom@tromey.com>
4963             Pedro Alves  <palves@redhat.com>
4964
4965         * regcache.c (class regcache_invalidator): Remove.
4966         (regcache::raw_write): Use make_scope_exit.
4967
4968 2019-01-23  Tom Tromey  <tom@tromey.com>
4969
4970         * ui-out.h (class ui_out_emit_type): Update comment.
4971
4972 2019-01-23  Tom Tromey  <tom@tromey.com>
4973
4974         * infrun.c (fetch_inferior_event): Update comment.
4975
4976 2019-01-23  Tom Tromey  <tom@tromey.com>
4977             Pedro Alves  <palves@redhat.com>
4978
4979         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4980         parameter.
4981         (fetch_inferior_event): Use SCOPE_EXIT.
4982
4983
4984 2019-01-23  Tom Tromey  <tom@tromey.com>
4985             Pedro Alves  <palves@redhat.com>
4986
4987         * infrun.c (disable_thread_events): Delete.
4988         (stop_all_threads): Use SCOPE_EXIT.
4989
4990 2019-01-23  Tom Tromey  <tom@tromey.com>
4991             Pedro Alves  <palves@redhat.com>
4992
4993         * symfile.c: Include forward-scope-exit.h.
4994         (clear_symtab_users_cleanup): Replace forward declaration with
4995         a FORWARD_SCOPE_EXIT.
4996         (syms_from_objfile_1): Use the forward_scope_exit and
4997         gdb::optional instead of cleanup_function.
4998         (reread_symbols): Use the forward_scope_exit instead of
4999         cleanup_function.
5000         (clear_symtab_users_cleanup): Remove function.
5001
5002 2019-01-23  Tom Tromey  <tom@tromey.com>
5003             Pedro Alves  <palves@redhat.com>
5004
5005         * linux-nat.c: Include scope-exit.h.
5006         (cleanup_target_stop): Remove.
5007         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5008         SCOPE_EXIT.
5009
5010 2019-01-23  Tom Tromey  <tom@tromey.com>
5011             Pedro Alves  <palves@redhat.com>
5012
5013         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5014         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5015
5016 2019-01-23  Tom Tromey  <tom@tromey.com>
5017             Andrew Burgess  <andrew.burgess@embecosm.com>
5018             Pedro Alves  <palves@redhat.com>
5019
5020         * infrun.c (fetch_inferior_event): Use scope_exit.
5021         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5022         * top.c (execute_command): Use scope_exit.
5023         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5024         * utils.c (do_bpstat_clear_actions_cleanup)
5025         (make_bpstat_clear_actions_cleanup): Remove.
5026
5027 2019-01-23  Tom Tromey  <tom@tromey.com>
5028             Pedro Alves  <palves@redhat.com>
5029
5030         * infrun.c: Include "common/scope-exit.h"
5031         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5032         (wait_for_inferior): Use SCOPE_EXIT.
5033         (fetch_inferior_event): Use scope_exit.
5034
5035 2019-01-23  Tom Tromey  <tom@tromey.com>
5036             Pedro Alves  <palves@redhat.com>
5037
5038         * breakpoint.c (create_breakpoint): Remove cleanup.
5039
5040 2019-01-23  Tom Tromey  <tom@tromey.com>
5041             Andrew Burgess  <andrew.burgess@embecosm.com>
5042             Pedro Alves  <palves@redhat.com>
5043
5044 2019-01-23  Pedro Alves  <palves@redhat.com>
5045
5046         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5047
5048 2019-01-23  Pedro Alves  <palves@redhat.com>
5049             Andrew Burgess  <andrew.burgess@embecosm.com>
5050
5051         * gdbthread.h: Include "common/forward-scope-exit.h".
5052         (scoped_finish_thread_state): Redefine custom class in terms of
5053         forward_scope_exit.
5054
5055 2019-01-23  Pedro Alves  <palves@redhat.com>
5056             Andrew Burgess  <andrew.burgess@embecosm.com>
5057
5058         * common/forward-scope-exit.h: New file.
5059
5060 2019-01-23  Pedro Alves  <palves@redhat.com>
5061             Andrew Burgess  <andrew.burgess@embecosm.com>
5062             Tom Tromey  <tom@tromey.com>
5063
5064         * common/scope-exit.h: New file.
5065
5066 2019-01-23  Pedro Alves  <palves@redhat.com>
5067
5068         * common/preprocessor.h (ESC): Rename to ...
5069         (ESC_PARENS): ... this.
5070         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5071         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5072
5073 2019-01-23  Tom Tromey  <tom@tromey.com>
5074
5075         * language.h (class scoped_switch_to_sym_language_if_auto):
5076         Initialize m_lang in both cases.
5077
5078 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5079
5080         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5081         with XCNEW.
5082
5083 2019-01-22  Tom Tromey  <tom@tromey.com>
5084
5085         * corelow.c: Do not include sys/file.h.
5086
5087 2019-01-22  Tom Tromey  <tom@tromey.com>
5088
5089         * tui/tui-wingeneral.h: Include gdb_curses.h.
5090
5091 2019-01-22  Tom Tromey  <tom@tromey.com>
5092
5093         * source-cache.h (class source_cache) <get_source_lines,
5094         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5095
5096 2019-01-22  Tom Tromey  <tom@tromey.com>
5097
5098         * remote-fileio.h (struct remote_target): Declare.
5099
5100 2019-01-22  Tom Tromey  <tom@tromey.com>
5101
5102         * python/py-arch.c: Do not include py-ref.h.
5103         * python/py-bpevent.c: Do not include py-ref.h.
5104         * python/py-cmd.c: Do not include py-ref.h.
5105         * python/py-continueevent.c: Do not include py-ref.h.
5106         * python/py-event.h: Do not include py-ref.h.
5107         * python/py-evtregistry.c: Do not include py-ref.h.
5108         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5109         * python/py-frame.c: Do not include py-ref.h.
5110         * python/py-framefilter.c: Do not include py-ref.h.
5111         * python/py-function.c: Do not include py-ref.h.
5112         * python/py-infevents.c: Do not include py-ref.h.
5113         * python/py-linetable.c: Do not include py-ref.h.
5114         * python/py-objfile.c: Do not include py-ref.h.
5115         * python/py-param.c: Do not include py-ref.h.
5116         * python/py-prettyprint.c: Do not include py-ref.h.
5117         * python/py-progspace.c: Do not include py-ref.h.
5118         * python/py-symbol.c: Do not include py-ref.h.
5119         * python/py-symtab.c: Do not include py-ref.h.
5120         * python/py-type.c: Do not include py-ref.h.
5121         * python/py-unwind.c: Do not include py-ref.h.
5122         * python/py-utils.c: Do not include py-ref.h.
5123         * python/py-value.c: Do not include py-ref.h.
5124         * python/py-varobj.c: Do not include py-ref.h.
5125         * python/py-xmethods.c: Do not include py-ref.h.
5126         * python/python.c: Do not include py-ref.h.
5127         * varobj.c: Do not include py-ref.h.
5128
5129 2019-01-22  Tom Tromey  <tom@tromey.com>
5130
5131         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5132         keyword for bcache.
5133
5134 2019-01-22  Tom Tromey  <tom@tromey.com>
5135
5136         * compile/compile-cplus-types.c: Remove a comment by #include.
5137
5138 2019-01-22  Tom Tromey  <tom@tromey.com>
5139
5140         * compile/gcc-c-plugin.h: Include compile-internal.h.
5141
5142 2019-01-22  Tom Tromey  <tom@tromey.com>
5143
5144         * stabsread.c (EXTERN): Do not define.
5145         (symnum, next_symbol_text_func, processing_gcc_compilation)
5146         (within_function, global_sym_chain, global_stabs)
5147         (previous_stab_code, this_object_header_files)
5148         (n_this_object_header_files)
5149         (n_allocated_this_object_header_files): Define.
5150         * stabsread.h (EXTERN): Never define.  Use "extern".
5151
5152 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5153
5154         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5155         history_value.
5156
5157 2019-01-21  Tom Tromey  <tom@tromey.com>
5158
5159         * ui-out.c: Fix includes.
5160         * tui/tui-source.c: Fix includes.
5161         * target.c: Fix includes.
5162         * remote.c: Fix includes.
5163         * regcache.c: Fix includes.
5164         * python/py-block.c: Fix includes.
5165         * printcmd.c: Fix includes.
5166         * or1k-tdep.c: Fix includes.
5167         * mi/mi-main.c: Fix includes.
5168         * m32r-tdep.c: Fix includes.
5169         * csky-tdep.c: Fix includes.
5170         * compile/compile-cplus-types.c: Fix includes.
5171         * cli/cli-interp.c: Fix includes.
5172
5173 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5174
5175         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5176         for padding.
5177
5178 2019-01-16  Tom Tromey  <tom@tromey.com>
5179
5180         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5181         earlier.
5182         (struct objfile) <msymbols_range>: Move from top level.
5183         <msymbols>: New method.
5184         (class objfile_msymbols): Remove.
5185         * symtab.c (default_collect_symbol_completion_matches_break_on):
5186         Update.
5187         * symmisc.c (dump_msymbols): Update.
5188         * stabsread.c (scan_file_globals): Update.
5189         * objc-lang.c (info_selectors_command, info_classes_command)
5190         (find_methods): Update.
5191         * minsyms.c (find_solib_trampoline_target): Update.
5192         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5193         * coffread.c (coff_symfile_read): Update.
5194         * ada-lang.c (ada_lookup_simple_minsym)
5195         (ada_collect_symbol_completion_matches): Update.
5196
5197 2019-01-16  Tom Tromey  <tom@tromey.com>
5198
5199         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5200         type.  Remove no-argument constructor.
5201         <iterator::operator++>: Simplify.
5202         <begin>: Update.
5203         <end>: Use minimal_symbol_count.
5204
5205 2019-01-16  Tom Tromey  <tom@tromey.com>
5206
5207         * objfiles.h (struct objfile) <psymtabs>: New method.
5208         (class objfile_psymtabs): Remove.
5209         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5210         typedef.
5211         <range>: New method.
5212         (require_partial_symbols): Change return type.
5213         * psymtab.c (require_partial_symbols)
5214         (psym_expand_symtabs_matching): Update.
5215         * mdebugread.c (parse_partial_symbols): Update.
5216         * dbxread.c (dbx_end_psymtab): Update.
5217
5218 2019-01-15  Tom Tromey  <tom@tromey.com>
5219
5220         * symtab.c (lookup_objfile_from_block)
5221         (lookup_symbol_in_objfile_symtabs)
5222         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5223         (find_line_symtab, info_sources_command)
5224         (default_collect_symbol_completion_matches_break_on)
5225         (make_source_files_completion_list): Update.
5226         * symmisc.c (print_objfile_statistics, dump_objfile)
5227         (maintenance_print_symbols, maintenance_info_symtabs)
5228         (maintenance_check_symtabs, maintenance_info_line_tables):
5229         Update.
5230         * source.c (select_source_symtab)
5231         (forget_cached_source_info_for_objfile): Update.
5232         * objfiles.h (class objfile_compunits): Remove.
5233         (struct objfile) <compunits_range>: New typedef.
5234         (compunits): New method.
5235         * objfiles.c (objfile_relocate1): Update.
5236         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5237         * maint.c (count_symtabs_and_blocks): Update.
5238         * linespec.c (iterate_over_all_matching_symtabs): Update.
5239         * cp-support.c (add_symbol_overload_list_qualified): Update.
5240         * coffread.c (coff_symtab_read): Update.
5241         * ada-lang.c (add_nonlocal_symbols)
5242         (ada_collect_symbol_completion_matches)
5243         (ada_add_global_exceptions): Update.
5244
5245 2019-01-15  Tom Tromey  <tom@tromey.com>
5246
5247         * progspace.h (program_space) <objfiles_safe_range>: New
5248         typedef.
5249         <objfiles_safe>: New method.
5250         * objfiles.h (class all_objfiles_safe): Remove.
5251         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5252         * jit.c (jit_inferior_exit_hook): Update.
5253
5254 2019-01-17  Tom Tromey  <tom@tromey.com>
5255
5256         * progspace.h (program_space) <objfiles_range>: New typedef.
5257         <objfiles>: New method.
5258         <objfiles_head>: Rename from objfiles.
5259         (object_files): Update.
5260         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5261         * guile/scm-pretty-print.c
5262         (ppscm_find_pretty_printer_from_objfiles): Update.
5263         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5264         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5265         Update.
5266         * python/py-progspace.c (pspy_get_objfiles): Update.
5267         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5268         Update.
5269         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5270         (objfpy_lookup_objfile_by_build_id): Update.
5271         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5272         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5273         Update.
5274         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5275         (expand_symtab_containing_pc, lookup_objfile_from_block)
5276         (lookup_static_symbol, basic_lookup_transparent_type)
5277         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5278         (find_line_symtab, info_sources_command)
5279         (default_collect_symbol_completion_matches_break_on)
5280         (make_source_files_completion_list, find_main_name): Update.
5281         * symmisc.c (print_symbol_bcache_statistics)
5282         (print_objfile_statistics, maintenance_print_symbols)
5283         (maintenance_print_msymbols, maintenance_print_objfiles)
5284         (maintenance_info_symtabs, maintenance_check_symtabs)
5285         (maintenance_expand_symtabs, maintenance_info_line_tables):
5286         Update.
5287         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5288         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5289         (map_overlay_command, unmap_overlay_command)
5290         (simple_overlay_update, expand_symtabs_matching)
5291         (map_symbol_filenames): Update.
5292         * symfile-debug.c (set_debug_symfile): Update.
5293         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5294         Update.
5295         * source.c (select_source_symtab, forget_cached_source_info):
5296         Update.
5297         * solib.c (solib_read_symbols): Update.
5298         * solib-spu.c (append_ocl_sos): Update.
5299         * psymtab.c (maintenance_print_psymbols)
5300         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5301         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5302         * printcmd.c (info_symbol_command): Update.
5303         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5304         Update.
5305         * objfiles.h (class all_objfiles): Remove.
5306         * objfiles.c (have_partial_symbols, have_full_symbols)
5307         (have_minimal_symbols, qsort_cmp, update_section_map)
5308         (shared_objfile_contains_address_p)
5309         (default_iterate_over_objfiles_in_search_order): Update.
5310         * objc-lang.c (info_selectors_command, info_classes_command)
5311         (find_methods): Update.
5312         * minsyms.c (find_solib_trampoline_target): Update.
5313         * maint.c (maintenance_info_sections)
5314         (maintenance_translate_address, count_symtabs_and_blocks):
5315         Update.
5316         * main.c (captured_main_1): Update.
5317         * linux-thread-db.c (try_thread_db_load_from_pdir)
5318         (has_libpthread): Update.
5319         * linespec.c (iterate_over_all_matching_symtabs)
5320         (search_minsyms_for_name): Update.
5321         * jit.c (jit_find_objf_with_entry_addr): Update.
5322         * hppa-tdep.c (find_unwind_entry)
5323         (hppa_lookup_stub_minimal_symbol): Update.
5324         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5325         Update.
5326         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5327         (elf_gnu_ifunc_resolve_by_got): Update.
5328         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5329         * dwarf-index-write.c (save_gdb_index_command): Update.
5330         * cp-support.c (add_symbol_overload_list_qualified): Update.
5331         * breakpoint.c (create_overlay_event_breakpoint)
5332         (create_longjmp_master_breakpoint)
5333         (create_std_terminate_master_breakpoint)
5334         (create_exception_master_breakpoint): Update.
5335         * blockframe.c (find_pc_partial_function): Update.
5336         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5337         (ada_collect_symbol_completion_matches)
5338         (ada_add_global_exceptions): Update.
5339
5340 2019-01-17  Tom Tromey  <tom@tromey.com>
5341
5342         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5343         declare VEC.
5344         (solib_target_parse_libraries): Change return type.
5345         (library_list_start_segment, library_list_start_section)
5346         (library_list_end_library, library_list_start_library); Update.
5347         (solib_target_free_library_list): Remove.
5348         (solib_target_parse_libraries): Remove cleanup.  Change return
5349         type.
5350         (solib_target_current_sos): Update.
5351
5352 2019-01-17  Tom Tromey  <tromey@bapiya>
5353
5354         * valprint.c: Replace "the the" with "the".
5355         * symtab.c: Replace "the the" with "the".
5356         * solib.c: Replace "the the" with "the".
5357         * solib-dsbt.c: Replace "the the" with "the".
5358         * linespec.c: Replace "the the" with "the".
5359         * dwarf2loc.h: Replace "the the" with "the".
5360         * amd64-windows-tdep.c: Replace "the the" with "the".
5361         * aarch64-tdep.c: Replace "the the" with "the".
5362
5363 2019-01-16  Keith Seitz  <keiths@redhat.com>
5364
5365         PR gdb/23773
5366         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5367         <builder>: Rename to ..
5368         <m_builder>: ... this and make private.
5369         (dwarf2_cu::get_builder): New method.  Change all users of
5370         `builder' to use this method.
5371         (dwarf2_start_symtab): Move to ...
5372         (dwarf2_cu::start_symtab): ... here.  Update all callers
5373         (setup_type_unit_groups): Move to ...
5374         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5375         callers.
5376         (dwarf2_cu::reset_builder): New method.
5377         (process_full_compunit, process_full_type_unit): Use
5378         dwarf2_cu::reset_builder.
5379         (follow_die_offset): Record the ancestor CU if it is different
5380         from the followed DIE's CU.
5381         (follow_die_sig_1): Likewise.
5382
5383 2019-01-15  Tom Tromey  <tom@tromey.com>
5384
5385         * remote.c (class remote_state) <buf>: Now a char_vector.
5386         <buf_size>: Remove.
5387         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5388         parameter.
5389         (remote_target::getpkt_or_notif_sane_1)
5390         (remote_target::getpkt_sane)
5391         (remote_target::getpkt_or_notif_sane): Likewise.
5392         (class remote_target) <putpkt>: New overload.
5393         (remote_target::read_frame): Change type of "buf_p".  Remove
5394         sizeof_p parameter.
5395         (packet_ok): New overload.
5396         (packet_check_result): New overload.
5397         Update all uses.
5398
5399 2019-01-14  Tom Tromey  <tom@tromey.com>
5400
5401         * remote-notif.c (handle_notification, remote_notif_ack)
5402         (remote_notif_parse): Make "buf" const.
5403         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5404         const.
5405         (remote_notif_parse, remote_notif_ack, handle_notification):
5406         Likewise.
5407         * remote.c (remote_notif_stop_parse): Make "buf" const.
5408         (remote_target::remote_parse_stop_reply): Make "buf" const.
5409         (remote_notif_stop_ack): Make "buf" const.
5410
5411 2019-01-14  Tom Tromey  <tom@tromey.com>
5412
5413         * remote.c (remote_console_output): Make parameter const.
5414
5415 2019-01-14  Tom Tromey  <tom@tromey.com>
5416
5417         * target-debug.h (target_debug_print_signals): Constify.
5418         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5419         * procfs.c (procfs_target::pass_signals): Update.
5420         * linux-nat.c (linux_nat_target::pass_signals): Update.
5421         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5422         * target-delegates.c: Rebuild.
5423         * remote.c (remote_target::program_signals): Update.
5424         (remote_target::pass_signals): Update.
5425         * target.c (target_pass_signals): Constify argument.
5426         (target_program_signals): Likewise.
5427         * target.h (struct target_ops) <pass_signals, program_signals>:
5428         Constify argument.
5429         (target_pass_signals, target_program_signals): Constify argument.
5430
5431 2019-01-14  Tom Tromey  <tom@tromey.com>
5432
5433         PR tui/28819:
5434         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5435
5436 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5437
5438         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5439         field.
5440         * rs6000-tdep.c: Include reggroups.h.
5441         (IS_V_ALIAS_PSEUDOREG): Define.
5442         (rs6000_register_name): Return names for the "vX" aliases.
5443         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5444         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5445         aliases.  Call default_register_reggroup_p for all other
5446         pseudo-registers.
5447         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5448         New functions.
5449         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5450         Handle "vX" aliases.
5451         (v_alias_pseudo_register_collect): New function.
5452         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5453         (rs6000_gdbarch_init): Initialize "vX" aliases as
5454         pseudo-registers.  Restore registration of
5455         rs6000_pseudo_register_reggroup_p with
5456         set_tdesc_pseudo_register_reggroup_p.
5457
5458 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5459
5460         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5461         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5462         set_gdbarch_num_pseudo_regs.
5463
5464 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5465
5466         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5467         Remove arg prefixname, add do_set and do_show.
5468         Add member functions set_list and show_list.
5469         * cli/cli-style.c (class cli_style_option): Update accordingly.
5470         (style_set_list): Move to file scope.
5471         (style_show_list): Likewise.
5472         (set_style): Call help_list.
5473         (show_style): Call cmd_show_list.
5474         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5475         Update to use the new macro.
5476
5477 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5478
5479         * ada-lang.c (_initialize_ada_language): Expand the help text
5480         for the "catch exception" command.
5481
5482 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5483
5484         * symtab.c (matching_obj_sections): Initialize obj,
5485         declare it closer to its usage.
5486
5487 2019-01-10  Tom Tromey  <tom@tromey.com>
5488
5489         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5490         (basic_inf_threads_range): Remove.
5491         (inf_threads_range, inf_non_exited_threads_range)
5492         (safe_inf_threads_range): Use next_adapter.
5493
5494 2019-01-10  Keith Seitz  <keiths@redhat.com>
5495
5496         PR gdb/23712
5497         PR symtab/23010
5498         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5499         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5500
5501 2019-01-10  Keith Seitz  <keiths@redhat.com>
5502
5503         PR gdb/23712
5504         PR symtab/23010
5505         * dictionary.c (pending_to_vector): Remove.
5506         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5507         Remove _1 suffix, replacing functions of the same name.  Update
5508         all callers.
5509         (dict_create_hashed, dict_create_hashed_expandable)
5510         (dict_create_linear, dict_create_linear_expandable, dict_free)
5511         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5512         Make functions static.
5513
5514 2019-01-10  Keith Seitz  <keiths@redhat.com>
5515
5516         PR gdb/23712
5517         PR symtab/23010
5518         * dictionary.h (struct dictionary): Replace declaration with
5519         multidictionary.
5520         (dict_create_hashed, dict_create_hashed_expandable)
5521         (dict_create_linear, dict_create_linear_expandable)
5522         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5523         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5524         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5525         taking multidictionary argument.
5526         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5527         * block.h (struct block) <dict>: Change to multidictionary
5528         and rename `multidict'.
5529         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5530         symmisc.c: Update all dictionary references to multidictionary.
5531
5532 2019-01-10  Keith Seitz  <keiths@redhat.com>
5533
5534         PR gdb/23712
5535         PR symtab/23010
5536         * dictionary.c: Include unordered_map.
5537         (pending_to_vector): New function.
5538         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5539         Rewrite the non-"_1" functions to take vector instead
5540         of linked list.
5541         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5542         "new" _1 versions of the same name.
5543         (multidictionary): Define.
5544         (std::hash<enum language): New definition.
5545         (collate_pending_symbols_by_language, mdict_create_hashed)
5546         (mdict_create_hashed_expandable, mdict_create_linear)
5547         (mdict_create_linear_expandable, mdict_free)
5548         (find_language_dictionary, create_new_language_dictionary)
5549         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5550         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5551         (mdict_size, mdict_empty): New functions.
5552         * dictionary.h (mdict_iterator): Define.
5553
5554 2019-01-10  Pedro Alves  <palves@redhat.com>
5555
5556         * breakpoint.c (read_uploaded_action)
5557         (create_tracepoint_from_upload): Adjust to use
5558         gdb::unique_xmalloc_ptr.
5559         * ctf.c (ctf_write_uploaded_tp):
5560         (SET_ARRAY_FIELD): Use emplace_back.
5561         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5562         * tracefile-tfile.c (tfile_write_uploaded_tp):
5563         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5564         gdb::unique_xmalloc_ptr.
5565         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5566         at_string, cond_string, cmd_strings>: Replace char pointers
5567         with gdb::unique_xmalloc_ptr.
5568
5569 2019-01-10  Pedro Alves  <palves@redhat.com>
5570
5571         * solib-target.c (library_list_start_library): Don't xstrdup name.
5572
5573 2019-01-10  Pedro Alves  <palves@redhat.com>
5574
5575         * mdebugread.c (parse_partial_symbols): Use
5576         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5577
5578 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5579
5580         * linux-fork.c (scoped_switch_fork_info)
5581         <~scoped_switch_fork_info>: Fix incorrect variable name.
5582
5583 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5584
5585         * linux-fork.c (scoped_switch_fork_info)
5586         <scoped_switch_fork_info>: Make explicit.
5587         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5588
5589 2019-01-10  Tom Tromey  <tom@tromey.com>
5590
5591         * objfiles.h (objfile::reset_psymtabs): Update.
5592         * objfiles.c (objfile::objfile): Update.
5593         * psymtab.h (psymtab_storage::obstack): Update.
5594         (psymtab_storage::m_obstack): Use gdb::optional.
5595         (class psymtab_storage): Update comment.  Remove objfile
5596         parameter.
5597         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5598
5599 2019-01-10  Tom Tromey  <tom@tromey.com>
5600
5601         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5602         <free_psymtabs>: Now private.
5603         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5604         (allocate_psymtab): Use new method.
5605
5606 2019-01-10  Tom Tromey  <tom@tromey.com>
5607
5608         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5609         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5610         * mdebugread.c (parse_partial_symbols): Use
5611         allocate_dependencies.
5612         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5613         allocate_dependencies.
5614         (process_psymtab_comp_unit_reader)
5615         (build_type_psymtab_dependencies): Likewise.
5616         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5617
5618 2019-01-10  Tom Tromey  <tom@tromey.com>
5619
5620         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5621         PSYMBOL_SET_LANGUAGE.
5622         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5623
5624 2019-01-10  Tom Tromey  <tom@tromey.com>
5625
5626         * psymtab.h (psymtab_storage::obstack): New method.
5627         <m_obstack>: Rename from obstack; now private.
5628         * psymtab.c (psymtab_storage): Update.
5629         * dwarf2read.c (create_addrmap_from_index)
5630         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5631         Update.
5632
5633 2019-01-10  Tom Tromey  <tom@tromey.com>
5634
5635         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5636         * objfiles.h (objfile::reset_psymtabs): New method.
5637
5638 2019-01-10  Tom Tromey  <tom@tromey.com>
5639
5640         * symmisc.c (print_symbol_bcache_statistics): Update.
5641         (print_objfile_statistics): Update.
5642         * symfile.c (reread_symbols): Update.
5643         * psymtab.h (class psymtab_storage): New.
5644         * psymtab.c (psymtab_storage): New constructor.
5645         (~psymtab_storage): New destructor.
5646         (require_partial_symbols): Update.
5647         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5648         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5649         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5650         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5651         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5652         (start_psymtab_common, end_psymtab_common)
5653         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5654         (allocate_psymtab): Update.
5655         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5656         Update.
5657         (dump_psymtab_addrmap, maintenance_print_psymbols)
5658         (maintenance_check_psymtabs): Update.
5659         (class objfile_psymtabs): Move to objfiles.h.
5660         * psympriv.h (discard_psymtab): Now inline.
5661         (psymtab_discarder::psymtab_discarder): Update.
5662         (psymtab_discarder::~psymtab_discarder): Update.
5663         (ALL_OBJFILE_PSYMTABS): Rewrite.
5664         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5665         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5666         Remove fields.
5667         <partial_symtabs>: New field.
5668         (class objfile_psymtabs): Move from psymtab.h.  Update.
5669         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5670         psymbol_cache.
5671         (objfile::~objfile): Don't destroy psymbol_cache.
5672         * mdebugread.c (parse_partial_symbols): Update.
5673         * dwarf2read.c (create_addrmap_from_index)
5674         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5675         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5676         (add_partial_subprogram, dwarf2_ranges_read): Update.
5677         * dwarf-index-write.c (write_address_map)
5678         (write_one_signatured_type, recursively_write_psymbols)
5679         (class debug_names, class debug_names, write_psymtabs_to_index):
5680         Update.
5681
5682 2019-01-10  Tom Tromey  <tom@tromey.com>
5683
5684         * symtab.h (SYMBOL_SET_NAMES): Update.
5685         (symbol_set_names): Update.
5686         (MSYMBOL_SET_NAMES): Update.
5687         * symtab.c (symbol_set_names): Change argument to be an
5688         objfile_per_bfd_storage.
5689         * psymtab.c (add_psymbol_to_bcache): Update.
5690         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5691
5692 2019-01-10  Tom Tromey  <tom@tromey.com>
5693
5694         * symtab.c (create_demangled_names_hash): Change argument to be an
5695         objfile_per_bfd_storage.
5696         (symbol_set_names): Update.
5697
5698 2019-01-10  Tom Tromey  <tom@tromey.com>
5699
5700         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5701         init_psymbol_list.
5702         * psymtab.c (init_psymbol_list): Do nothing if already called.
5703         * psympriv.h (init_psymbol_list): Add comment.
5704         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5705         init_psymbol_list.
5706         * dbxread.c (dbx_symfile_read): Unconditionally call
5707         init_psymbol_list.
5708
5709 2019-01-10  Tom Tromey  <tom@tromey.com>
5710
5711         * xcoffread.c (scan_xcoff_symtab): Update.
5712         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5713         "where".
5714         * mdebugread.c (parse_partial_symbols)
5715         (handle_psymbol_enumerators): Update.
5716         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5717         * dbxread.c (read_dbx_symtab): Update.
5718         * psympriv.h (psymbol_placement): New enum.
5719         (add_psymbol_to_list): Update.
5720
5721 2019-01-10  Tom Tromey  <tom@tromey.com>
5722
5723         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5724         static_psymbols parameters.
5725         (scan_xcoff_symtab): Update.
5726         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5727         static_psymbols parameters.
5728         * psympriv.h (start_psymtab_common): Update.
5729         * mdebugread.c (parse_partial_symbols): Update.
5730         * dwarf2read.c (create_partial_symtab): Update.
5731         * dbxread.c (read_dbx_symtab): Update.
5732         (start_psymtab): Remove global_psymbols and static_psymbols
5733         parameters.
5734
5735 2019-01-10  Tom Tromey  <tom@tromey.com>
5736
5737         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5738         * psymtab.c (allocate_psymtab): Add comment.
5739         * psympriv.h (allocate_psymtab): Add comment.
5740         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5741         initializations.
5742         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5743
5744 2019-01-10  Tom Tromey  <tom@tromey.com>
5745
5746         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5747         Don't declare.
5748         * mipsread.c: Include mdebugread.h.
5749         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5750         Declare.
5751         * elfread.c: Include mdebugread.h.
5752
5753 2019-01-09  Tom Tromey  <tom@tromey.com>
5754
5755         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5756         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5757         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5758         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5759         (psym_lookup_symbol, psym_find_last_source_symtab)
5760         (psym_forget_cached_source_info, psym_print_stats)
5761         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5762         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5763         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5764         (psym_find_compunit_symtab_by_address)
5765         (maintenance_print_psymbols, maintenance_info_psymtabs)
5766         (maintenance_check_psymtabs): Use ranged for.
5767         * psymtab.h (class objfile_psymtabs): New.
5768         (require_partial_symbols): Return objfile_psymtabs.
5769         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5770
5771 2019-01-09  Tom Tromey  <tom@tromey.com>
5772
5773         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5774         (find_pc_mapped_section, list_overlays_command)
5775         (map_overlay_command, unmap_overlay_command)
5776         (simple_overlay_update): Use all_objfiles.
5777         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5778         * printcmd.c (info_symbol_command): Use all_objfiles.
5779         * objfiles.h (ALL_OBJSECTIONS): Remove.
5780         * maint.c (maintenance_translate_address): Use all_objfiles.
5781         * gcore.c (gcore_create_callback): Use all_objfiles.
5782         (objfile_find_memory_regions): Likewise.
5783
5784 2019-01-09  Tom Tromey  <tom@tromey.com>
5785
5786         * symtab.c (find_line_symtab, info_sources_command)
5787         (make_source_files_completion_list): Use objfile_compunits.
5788         * source.c (select_source_symtab): Use objfile_compunits.
5789         * objfiles.h (struct objfile): Update comment.
5790         (ALL_OBJFILES): Remove.
5791         (ALL_FILETABS): Remove.
5792         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5793         objfile_compunits.
5794
5795 2019-01-09  Tom Tromey  <tom@tromey.com>
5796
5797         * symmisc.c (print_objfile_statistics, dump_objfile)
5798         (maintenance_print_symbols): Use compunit_filetabs.
5799         * source.c (forget_cached_source_info_for_objfile): Use
5800         compunit_filetabs.
5801         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5802         (ALL_FILETABS): Use compunit_filetabs.
5803         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5804         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5805
5806 2019-01-09  Tom Tromey  <tom@tromey.com>
5807
5808         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5809         (compunit_filetabs): New.
5810         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5811         compunit_filetabs.
5812         (info_sources_command, make_source_files_completion_list): Remove
5813         declaration.
5814         * symmisc.c (print_objfile_statistics, dump_objfile)
5815         (maintenance_print_symbols): Remove declaration.
5816         (maintenance_info_symtabs): Use compunit_filetabs.
5817         (maintenance_info_line_tables): Likewise.
5818         * source.c (select_source_symtab): Change local variable name.
5819         (forget_cached_source_info_for_objfile): Remove declaration.
5820         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5821         * objfiles.c (objfile_relocate1): Remove declaration.
5822         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5823         declaration.
5824         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5825         * coffread.c (coff_symtab_read): Remove declaration.
5826         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5827         compunit_filetabs.
5828
5829 2019-01-09  Tom Tromey  <tom@tromey.com>
5830
5831         * symtab.c (lookup_objfile_from_block)
5832         (find_pc_sect_compunit_symtab, search_symbols)
5833         (default_collect_symbol_completion_matches_break_on): Use
5834         objfile_compunits.
5835         * objfiles.h (ALL_COMPUNITS): Remove.
5836         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5837         * cp-support.c (add_symbol_overload_list_qualified): Use
5838         objfile_compunits.
5839         * ada-lang.c (ada_collect_symbol_completion_matches)
5840         (ada_add_global_exceptions): Use objfile_compunits.
5841
5842 2019-01-09  Tom Tromey  <tom@tromey.com>
5843
5844         * source.c (select_source_symtab)
5845         (forget_cached_source_info_for_objfile): Remove declaration.
5846         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5847         declaration.
5848         * maint.c (count_symtabs_and_blocks): Remove declaration.
5849         * cp-support.c (add_symbol_overload_list_qualified): Remove
5850         declaration.
5851         * coffread.c (coff_symtab_read): Remove declaration.
5852         * symtab.c (lookup_symbol_in_objfile_symtabs)
5853         (basic_lookup_transparent_type_1): Use objfile_compunits.
5854         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5855         (info_sources_command, search_symbols)
5856         (default_collect_symbol_completion_matches_break_on)
5857         (make_source_files_completion_list): Remove declaration.
5858         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5859         (ada_collect_symbol_completion_matches)
5860         (ada_add_global_exceptions): Remove declaration.
5861         * linespec.c (iterate_over_all_matching_symtabs): Use
5862         objfile_compunits.
5863         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5864         (class objfile_compunits): New.
5865         (ALL_COMPUNITS): Use objfile_compunits.
5866         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5867         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5868         objfile_compunits.
5869         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5870
5871 2019-01-09  Tom Tromey  <tom@tromey.com>
5872
5873         * symtab.c (search_symbols)
5874         (default_collect_symbol_completion_matches_break_on): Use
5875         objfile_msymbols.
5876         * ada-lang.c (ada_lookup_simple_minsym)
5877         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5878         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5879         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5880         objfile_msymbols.
5881         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5882         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5883         * objc-lang.c (find_methods): Use objfile_msymbols.
5884         (info_selectors_command, info_classes_command): Likewise.
5885         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5886         * objfiles.h (class objfile_msymbols): New.
5887         (ALL_OBJFILE_MSYMBOLS): Remove.
5888         (ALL_MSYMBOLS): Remove.
5889
5890 2019-01-09  Tom Tromey  <tom@tromey.com>
5891
5892         * common/next-iterator.h (next_adapter): Add Iterator template
5893         parameter.
5894         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5895         (class all_objfiles_safe): New.
5896         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5897         * objfiles.c (put_objfile_before): Update comment.
5898         (add_separate_debug_objfile): Likewise.
5899         (free_all_objfiles): Use all_objfiles_safe.
5900         (objfile_purge_solibs): Likewise.
5901
5902 2019-01-09  Tom Tromey  <tom@tromey.com>
5903
5904         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5905         (expand_symtab_containing_pc, lookup_static_symbol)
5906         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5907         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5908         all_objfiles.
5909         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5910         * breakpoint.c (create_overlay_event_breakpoint)
5911         (create_longjmp_master_breakpoint)
5912         (create_std_terminate_master_breakpoint)
5913         (create_exception_master_breakpoint): Use all_objfiles.
5914         * linux-thread-db.c (try_thread_db_load_from_pdir)
5915         (has_libpthread): Use all_objfiles.
5916         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5917         * linespec.c (iterate_over_all_matching_symtabs)
5918         (search_minsyms_for_name): Use all_objfiles.
5919         * maint.c (maintenance_info_sections): Use all_objfiles.
5920         * main.c (captured_main_1): Use all_objfiles.
5921         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5922         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5923         * guile/scm-pretty-print.c
5924         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5925         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5926         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5927         (maintenance_print_msymbols): Use all_objfiles.
5928         * source.c (select_source_symtab): Use all_objfiles.
5929         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5930         * symfile.c (remove_symbol_file_command)
5931         (expand_symtabs_matching, map_symbol_filenames): Use
5932         all_objfiles.
5933         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5934         all_objfiles.
5935         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5936         * objc-lang.c (find_methods): Use all_objfiles.
5937         * objfiles.c (have_partial_symbols, have_full_symbols)
5938         (have_minimal_symbols, qsort_cmp)
5939         (default_iterate_over_objfiles_in_search_order): Use
5940         all_objfiles.
5941         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5942         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5943         (maintenance_check_psymtabs): Use all_objfiles.
5944         (ALL_PSYMTABS): Remove.
5945         * compile/compile-object-run.c (do_module_cleanup): Use
5946         all_objfiles.
5947         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5948         * cp-support.c (add_symbol_overload_list_qualified): Use
5949         all_objfiles.
5950         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5951         Use all_objfiles.
5952         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5953         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5954         all_objfiles.
5955         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5956         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5957         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5958         Uses all_objfiles.
5959         * solib.c (solib_read_symbols): Use all_objfiles
5960
5961 2019-01-09  Tom Tromey  <tom@tromey.com>
5962
5963         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5964         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5965         all_objfiles.
5966         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5967         * symmisc.c (print_symbol_bcache_statistics)
5968         (print_objfile_statistics, maintenance_print_objfiles)
5969         (maintenance_info_symtabs, maintenance_check_symtabs)
5970         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5971         all_objfiles.
5972         * source.c (forget_cached_source_info): Use all_objfiles.
5973         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5974         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5975         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5976         * objfiles.c (update_section_map): Use all_objfiles.
5977         (shared_objfile_contains_address_p): Likewise.
5978         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5979         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5980
5981 2019-01-09  Tom Tromey  <tom@tromey.com>
5982
5983         * common/next-iterator.h: New file.
5984         * objfiles.h (class all_objfiles): New.
5985         (struct objfile_iterator): New.
5986
5987 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5988
5989         * NEWS: Move the description of the changed "frame", "select-frame",
5990          and "info frame" commands to the Changed commands section.
5991
5992 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5993
5994         * gdbtypes.c (check_stub_method_group): Remove handling of old
5995         mangling schemes.
5996         * linespec.c (find_methods): Likewise.
5997         * stabsread.c (read_member_functions): Likewise.
5998         * valops.c (search_struct_method): Likewise.
5999         (value_struct_elt_for_reference): Likewise.
6000         * NEWS: Mention this change.
6001
6002 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6003
6004         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6005         print_source_lines.
6006         * source.c (print_source_lines_base): Update line number check.
6007         (print_source_lines): New function.
6008         (source_lines_range::source_lines_range): New function.
6009         * source.h (class source_lines_range): New class.
6010         (print_source_lines): New declaration.
6011
6012 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6013
6014         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6015
6016 2019-01-08  Tom Tromey  <tom@tromey.com>
6017             Simon Marchi  <simon.marchi@ericsson.com>
6018
6019         PR gdb/24060
6020         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6021         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6022         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6023         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6024         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6025         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6026
6027 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6028
6029         * source.c (select_source_symtab): Move header comment to
6030         declaration in source.h.
6031         (forget_cached_source_info_for_objfile): Likewise.
6032         (forget_cached_source_info): Likewise.
6033         (identify_source_line): Likewise.
6034         * source.h (identify_source_line): Move declaration from symtab.h
6035         and add comment from source.c
6036         (print_source_lines): Likewise.
6037         (forget_cached_source_info_for_objfile): Likewise.
6038         (forget_cached_source_info): Likewise.
6039         (select_source_symtab): Likewise.
6040         (enum print_source_lines_flag): Move definition from symtab.h.
6041         * symtab.h (identify_source_line): Move declaration to source.h.
6042         (print_source_lines): Likewise.
6043         (forget_cached_source_info_for_objfile): Likewise.
6044         (forget_cached_source_info): Likewise.
6045         (select_source_symtab): Likewise.
6046         (enum print_source_lines_flag): Move definition to source.h.
6047         * tui/tui-hooks.c: Add 'source.h' include.
6048
6049 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6050
6051         * source.c (print_source_lines_base): Handle requests to print
6052         reverse line number sequences, and guard against empty lines
6053         string.
6054
6055 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * source.c (print_source_lines_base): Fix skip of '\r' if next
6058         character is '\n'.
6059
6060 2019-01-06  Tom Tromey  <tom@tromey.com>
6061
6062         * c-exp.y (struct c_parse_state) <macro_original_text,
6063         expansion_obstack>: New member.
6064         (macro_original_text, expansion_obstack): Remove globals.
6065         (scan_macro_expansion, scanning_macro_expansion)
6066         (finished_macro_expansion): Update.
6067         (scan_macro_cleanup): Remove.
6068         (yylex, c_parse): Update.
6069
6070 2019-01-06  Tom Tromey  <tom@tromey.com>
6071
6072         * c-exp.y (struct c_parse_state) <strings>: New member.
6073         (operator_stoken): Update.
6074
6075 2019-01-06  Tom Tromey  <tom@tromey.com>
6076
6077         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6078         (union type_stack_elt) <typelist_val>: Now a pointer to
6079         std::vector.
6080         (type_stack_cleanup): Don't declare.
6081         (push_typelist): Update.
6082         * parse.c (pop_typelist): Return a std::vector.
6083         (push_typelist): Take a std::vector.
6084         (follow_types): Update.  Do not free args.
6085         (type_stack_cleanup): Remove.
6086         * c-exp.y (struct c_parse_state): New.
6087         (cpstate): New global.
6088         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6089         (nonempty_typelist): Update.
6090         (func_mod): Create a new vector.
6091         (c_parse): Create a c_parse_state.
6092         (check_parameter_typelist): Do not delete params.
6093         (function_method): Update.  Do not delete type_list.
6094
6095 2019-01-06  Tom Tromey  <tom@tromey.com>
6096
6097         PR gdb/28155:
6098         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6099         check_typedef.
6100         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6101         (print_return_value): Likewise.
6102
6103 2019-01-05  Tom Tromey  <tom@tromey.com>
6104
6105         * contrib/cleanup_check.py: Remove.
6106         * contrib/gcc-with-excheck: Remove.
6107         * contrib/exsummary.py: Remove.
6108         * contrib/excheck.py: Remove.
6109
6110 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6111
6112         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6113         NULL. Initialize tpprev to NULL instead of assigning it
6114         to NULL on the next statement.
6115         * windows-nat.c (windows_delete_thread): Remove check for
6116         main_thread_id before printing thread exit notifications.
6117         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6118         Remove thread ID check against main_thread_id.
6119         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6120         windows_delete_thread.
6121         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6122
6123 2019-01-04  Tom Tromey  <tom@tromey.com>
6124
6125         * compile/compile.c (_initialize_compile): Use upper case for
6126         metasyntactic variables.
6127         * symmisc.c (_initialize_symmisc): Use upper case for
6128         metasyntactic variables.
6129         * psymtab.c (_initialize_psymtab): Use upper case for
6130         metasyntactic variables.
6131         * demangle.c (demangle_command): Use upper case for metasyntactic
6132         variables.
6133         (_initialize_demangler): Likewise.
6134         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6135         variables.
6136
6137 2019-01-03  Tom Tromey  <tom@tromey.com>
6138
6139         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6140
6141 2019-01-03  Tom Tromey  <tom@tromey.com>
6142
6143         * python/py-symtab.c (salpy_str): Update.
6144         (struct salpy_sal_object) <symtab>: Now a PyObject.
6145         (salpy_dealloc): Update.
6146         (del_objfile_sal): Use gdbpy_ref.
6147
6148 2019-01-03  Tom Tromey  <tom@tromey.com>
6149
6150         * python/py-type.c (convert_field): Use new_reference.  Return
6151         gdbpy_ref.
6152         (make_fielditem): Return gdbpy_ref.
6153         (typy_fields): Update.
6154         (typy_getitem): Update.
6155         (field_name): Return gdbpy_ref.  Use new_reference.
6156         (typy_iterator_iternext): Update.
6157
6158 2019-01-03  Tom Tromey  <tom@tromey.com>
6159
6160         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6161
6162 2019-01-03  Tom Tromey  <tom@tromey.com>
6163
6164         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6165         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6166         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6167         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6168         (pspy_set_type_printers): Likewise.
6169         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6170         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6171         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6172         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6173         (objfpy_set_type_printers): Likewise.
6174
6175 2019-01-03  Tom Tromey  <tom@tromey.com>
6176
6177         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6178         (gdbpy_print_stack): Use gdbpy_err_fetch.
6179         * python/python-internal.h (class gdbpy_err_fetch): New class.
6180         (class gdbpy_enter) <m_error_type, m_error_value,
6181         m_error_traceback>: Remove.
6182         <m_error>: New member.
6183         (gdbpy_exception_to_string): Don't declare.
6184         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6185         * python/py-value.c (convert_value_from_python): Use
6186         gdbpy_err_fetch.
6187         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6188         gdbpy_exception_to_string.
6189         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6190         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6191         gdbpy_err_fetch.
6192
6193 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6194
6195         * linux-nat.c (delete_lwp_cleanup): Delete.
6196         (struct lwp_deleter): New struct.
6197         (lwp_info_up): New typedef.
6198         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6199         lwp_info_up.
6200
6201 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6202
6203         * linux-fork.c (class scoped_switch_fork_info): New class.
6204         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6205
6206 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6207
6208         * valops.c (find_overload_match): Remove use of null_cleanup, and
6209         calls to do_cleanups.
6210
6211 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6212
6213         * compile/compile-cplus-types.c
6214         (compile_cplus_instance::decl_name): Handle changes to
6215         cp_func_name.
6216         * cp-support.c (cp_func_name): Update header comment, update
6217         return type.
6218         * cp-support.h (cp_func_name): Update return type in declaration.
6219         * valops.c (find_overload_match): Move temp_func local to top
6220         level of function and change its type.  Use temp_func to hold and
6221         delete temporary string obtained from cp_func_name.
6222
6223 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6224
6225         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6226         gdb::char_vector, remove cleanup, and update uses of `msg`.
6227
6228 2019-01-03  Jim Wilson  <jimw@sifive.com>
6229
6230         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6231
6232 2019-01-02  Tom Tromey  <tom@tromey.com>
6233
6234         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6235         (tdesc_parse_xml): Remove cleanups.
6236         * target-descriptions.h (make_cleanup_free_target_description):
6237         Don't declare.
6238         (target_desc_deleter): New struct.
6239         (target_desc_up): New typedef.
6240         * target-descriptions.c (target_desc_deleter::operator()): Rename
6241         from free_target_description.
6242         (make_cleanup_free_target_description): Remove.
6243
6244 2019-01-02  Tom Tromey  <tom@tromey.com>
6245
6246         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6247         constructor, destructor.
6248         (linespec_parser): Remove typedef.
6249         (~linespec_parser): Rename from linespec_parser_delete.
6250         (linespec_lex_to_end, linespec_complete_label)
6251         (linespec_complete): Update.
6252         (decode_line_full): Remove cleanups.
6253         (decode_line_1): Update.
6254
6255 2019-01-02  Tom Tromey  <tom@tromey.com>
6256
6257         * python/python-internal.h (inferior_to_inferior_object): Change
6258         return type.
6259         * python/py-exitedevent.c (create_exited_event_object): Update.
6260         * python/py-inferior.c (inferior_to_inferior_object): Return
6261         gdbpy_ref.
6262         (python_new_inferior, python_inferior_deleted)
6263         (thread_to_thread_object, delete_thread_object)
6264         (build_inferior_list, gdbpy_selected_inferior): Update.
6265         * python/py-infthread.c (create_thread_object): Update.  Also fail
6266         if inferior_to_inferior_object fails.
6267
6268 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6269
6270         * inferior.h (class inferior) <displaced_step_state>: New field.
6271         * infrun.h (struct displaced_step_state): Move here from
6272         infrun.c.  Initialize fields, add constructor.
6273         <inf>: Remove field.
6274         <reset>: New method.
6275         * infrun.c (struct displaced_step_inferior_state): Move to
6276         infrun.h.
6277         (displaced_step_inferior_states): Remove.
6278         (get_displaced_stepping_state): Adust.
6279         (displaced_step_in_progress_any_inferior): Adjust.
6280         (displaced_step_in_progress_thread): Adjust.
6281         (displaced_step_in_progress): Adjust.
6282         (add_displaced_stepping_state): Remove.
6283         (get_displaced_step_closure_by_addr): Adjust.
6284         (remove_displaced_stepping_state): Remove.
6285         (infrun_inferior_exit): Call displaced_step_state.reset.
6286         (use_displaced_stepping): Don't check for NULL.
6287         (displaced_step_prepare_throw): Call
6288         get_displaced_stepping_state.
6289         (displaced_step_fixup): Don't check for NULL.
6290         (prepare_for_detach): Don't check for NULL.
6291
6292 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6293
6294         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6295          in case of call that did not complete.
6296
6297 2019-01-02  Andrey Utkin  <autkin@undo.io>
6298
6299         * symfile.c (find_separate_debug_file): Fix search of debug files for
6300         remote debuggee.
6301
6302 2019-01-02  Tom Tromey  <tom@tromey.com>
6303
6304         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6305         indentation.
6306         * python/py-frame.c (frapy_older): Remove cast.
6307         (frapy_newer): Likewise.
6308         * python/py-breakpoint.c (local_setattro): Remove cast.
6309         * python/py-arch.c (archpy_name): Remove local variable.
6310         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6311
6312 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6313
6314         * unittests/basic_string_view/element_access/char/empty.cc:
6315         Fix year range in copyright header.
6316
6317 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6318
6319         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6320         Delete.
6321         <operator==>: Update with for removed field.
6322         <hash>: Likewise.
6323         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6324         <isa_features>: ...this.
6325         <abi_features>: New field.
6326         (riscv_isa_flen): Update comment.
6327         (riscv_abi_xlen): New declaration.
6328         (riscv_abi_flen): New declaration.
6329         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6330         isa_features.
6331         (riscv_abi_xlen): New function.
6332         (riscv_isa_flen): Update to get answer from isa_features.
6333         (riscv_abi_flen): New function.
6334         (riscv_has_fp_abi): Update to get answer from abi_features.
6335         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6336         xlen and flen.
6337         (riscv_call_info) <xlen, flen>: Update comment.
6338         (riscv_call_arg_struct): Remove invalid assertions
6339         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6340         is removed.
6341         (riscv_gdbarch_init): Gather isa features and abi features
6342         separately, ensure both match on the gdbarch when reusing an old
6343         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6344         a target with 64-bit float hardware.
6345
6346 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6347
6348         * source.c (search_command_helper): Stop reverse search
6349         when line 1 has been searched.
6350
6351 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6352
6353         * record-full.c (record_full_base_target::close): Rewrite
6354         record_full_core_buf_list free logic.
6355
6356 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6357
6358         * break-catch-syscall.c (print_one_catch_syscall): xfree
6359         the last text.
6360
6361 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6362
6363         * top.c (print_gdb_version): Update Copyright year in version
6364         message.
6365
6366 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6367
6368         Update copyright year range in all GDB files.
6369
6370 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6371
6372         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6373
6374 For older changes see ChangeLog-2018.
6375 \f
6376 Local Variables:
6377 mode: change-log
6378 left-margin: 8
6379 fill-column: 74
6380 version-control: never
6381 coding: utf-8
6382 End:
6383