gdb/ChangeLog

   1 2019-08-19  Tom Tromey  <tom@tromey.com>
   2
   3         * configure: Rebuild.
   4         * configure.ac: Disallow the combination of -static-libstdc++ and
   5         source highlight.
   6         * source-cache.c (get_language_name): Handle rust.
   7         (source_cache::get_source_lines): Ignore highlighting exceptions.
   8
   9 2019-08-16  Tom Tromey  <tom@tromey.com>
  10
  11         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
  12         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
  13         (struct tui_source_window_base) <make_visible, refresh_window,
  14         resize>: Remove methods.
  15         <execution_info>: Remove field.
  16         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
  17         (tui_show_source_line, tui_source_window_base)
  18         (~tui_source_window_base): Update.
  19         (tui_source_window_base::resize)
  20         (tui_source_window_base::make_visible)
  21         (tui_source_window_base::refresh_window): Remove.
  22         (tui_source_window_base::update_exec_info): Update.
  23         * tui/tui-source.c (tui_source_window::set_contents): Update.
  24         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  25
  26 2019-08-16  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-hooks.c (tui_remove_hooks): Don't set
  29         deprecated_query_hook.
  30
  31 2019-08-16  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  34         (tui_update_source_windows_with_line): Update.
  35         * tui/tui-source.h (struct tui_source_window)
  36         <show_symtab_source>: Declare.
  37         (tui_show_symtab_source): Don't declare.
  38         * tui/tui-source.c (tui_show_symtab_source): Rename from
  39         tui_show_symtab_source.
  40
  41 2019-08-16  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-winsource.h (struct tui_source_window_base)
  44         <set_contents>: Declare.
  45         * tui/tui-winsource.c
  46         (tui_source_window_base::update_source_window_as_is): Update.
  47         * tui/tui-source.h (struct tui_source_window) <set_contents>:
  48         Declare.
  49         (tui_set_source_content): Don't declare.
  50         * tui/tui-source.c (tui_source_window::set_contents): Rename from
  51         tui_set_source_content.
  52         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  53         Declare.
  54         (tui_set_disassem_content): Don't declare.
  55         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
  56         tui_set_disassem_content.
  57
  58 2019-08-16  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-winsource.h (struct tui_source_window_base)
  61         <update_breakpoint_info>: Declare.
  62         (tui_update_breakpoint_info): Don't declare.
  63         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
  64         (tui_update_all_breakpoint_info): Update.
  65         (tui_source_window_base::update_breakpoint_info): Rename from
  66         tui_update_breakpoint_info.
  67         (tui_source_window_base::update_exec_info): Update.
  68
  69 2019-08-16  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-winsource.h (struct tui_source_window_base)
  72         <update_source_window>: Declare.
  73         (tui_update_source_window): Don't declare.
  74         * tui/tui-winsource.c
  75         (tui_source_window_base::update_source_window): Rename from
  76         tui_update_source_window.
  77         (tui_source_window_base::rerender): Update.
  78         * tui/tui-source.c (tui_source_window::maybe_update): Update.
  79         * tui/tui-disasm.c (tui_show_disassem)
  80         (tui_show_disassem_and_update_source)
  81         (tui_disasm_window::maybe_update): Update.
  82
  83 2019-08-16  Tom Tromey  <tom@tromey.com>
  84
  85         * tui/tui-winsource.h (struct tui_source_window_base)
  86         <update_source_window_as_is>: Declare.
  87         (tui_update_source_window_as_is): Don't declare.
  88         * tui/tui-winsource.c (tui_update_source_window): Update
  89         (tui_source_window_base::update_source_window_as_is): Rename from
  90         tui_update_source_window_as_is.
  91         (tui_source_window_base::refill): Update.
  92         * tui/tui-source.c (tui_show_symtab_source): Update.
  93         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
  94         Update.
  95
  96 2019-08-16  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-winsource.h (tui_update_source_window)
  99         (tui_update_source_window_as_is): Remove "noerror" parameter.
 100         * tui/tui-winsource.c (tui_update_source_window)
 101         (tui_update_source_window_as_is): Remove "noerror" parameter.
 102         (tui_update_source_windows_with_addr)
 103         (tui_update_source_windows_with_line)
 104         (tui_source_window_base::rerender)
 105         (tui_source_window_base::refill): Update.
 106         * tui/tui-source.h (tui_set_source_content)
 107         (tui_show_symtab_source): Remove "noerror" parameter.
 108         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 109         parameter.
 110         (tui_show_symtab_source): Likewise.
 111         (tui_source_window::maybe_update): Update.
 112         * tui/tui-disasm.c (tui_show_disassem)
 113         (tui_show_disassem_and_update_source)
 114         (tui_disasm_window::do_scroll_vertical)
 115         (tui_disasm_window::maybe_update): Update.
 116
 117 2019-08-16  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui.c (tui_is_window_visible): Update.
 120         * tui/tui-wingeneral.c (tui_make_window)
 121         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 122         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 123         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 124         (tui_set_win_height_command, parse_scrolling_args): Update.
 125         * tui/tui-source.c (tui_source_window::style_changed): Update.
 126         * tui/tui-regs.c (tui_show_registers)
 127         (tui_data_window::first_data_item_displayed)
 128         (tui_data_window::delete_data_content_windows)
 129         (tui_check_register_values, tui_reg_command): Update.
 130         * tui/tui-disasm.c (tui_show_disassem): Update.
 131         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 132         method.
 133         <is_visible>: Remove field.
 134         * tui/tui-data.c (tui_next_win, tui_prev_win)
 135         (tui_delete_invisible_windows): Update.
 136
 137 2019-08-16  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-winsource.h (struct tui_source_window_base)
 140         <m_has_locator>: Remove.
 141         * tui/tui-layout.c (show_source_disasm_command, show_data)
 142         (show_source_or_disasm_and_command): Update.
 143
 144 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 145
 146         * NEWS (Other MI changes): New subsection.
 147         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 148         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 149         * arch-utils.c (default_get_pc_address_flags): New function.
 150         * arch-utils.h (default_get_pc_address_flags): New declaration.
 151         * gdbarch.sh: Add get_pc_address_flags.
 152         * gdbarch.c: Regenerate.
 153         * gdbarch.h: Likewise.
 154         * stack.c (print_pc): New function.
 155         (print_frame_info) (print_frame): Call print_pc.
 156
 157 2019-08-16  Tom de Vries  <tdevries@suse.de>
 158
 159         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 160         print_objfile_section_info.
 161
 162 2019-08-15  Tom Tromey  <tom@tromey.com>
 163
 164         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 165         calling update_cmdwin_start_line.
 166         * tui/tui-winsource.h (struct tui_source_window_base)
 167         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 168         <rerender>: Declare.
 169         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 170         Call rerender.
 171         (tui_source_window_base::set_new_height): Remove.
 172         (tui_source_window_base::rerender): Rename from
 173         do_make_visible_with_new_height.
 174         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 175         resize method.
 176         (tui_win_info::make_invisible_and_set_new_height)
 177         (tui_win_info::make_visible_with_new_height): Remove.
 178         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 179         Declare.
 180         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 181         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 182         do_make_visible_with_new_height>: Don't declare.
 183         <rerender>: Declare.
 184         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 185         set_new_height.
 186         (tui_data_window::do_make_visible_with_new_height): Remove.
 187         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 188         call tui_show_locator_content.
 189         (tui_gen_win_info::resize): Call rerender.
 190         (show_source_or_disasm_and_command): Don't call
 191         tui_show_locator_content.
 192         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 193         method.
 194         (struct tui_win_info) <rerender>: Declare.
 195         <set_new_height, make_invisible_and_set_new_height,
 196         make_visible_with_new_height>: Don't declare.
 197         * tui/tui-data.c (tui_win_list::rerender): New method.
 198         * tui/tui-command.h (struct tui_cmd_window)
 199         <do_make_visible_with_new_height>: Don't declare.
 200         * tui/tui-command.c
 201         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 202
 203 2019-08-15  Tom Tromey  <tromey@adacore.com>
 204
 205         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 206         * ada-lang.c (ada_enum_name): Likewise.
 207
 208 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 209
 210         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 211         leading underscore.
 212         (GdbOutputErrorFile): Likewise.
 213         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 214         accordingly.
 215         (execute_unwinders): Rename to have a leading underscore.
 216         (auto_load_packages): Likewise.
 217         (global scope): Adjust call to auto_load_packages accordingly.
 218         (GdbSetPythonDirectory): Likewise.
 219         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 220         instead of execute_unwinders.
 221
 222 2019-08-15  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 225         (show_data): Don't change window visibility.
 226         (tui_gen_win_info::resize): Remove special case for command
 227         window.  Use wresize, when available.
 228         (show_source_or_disasm_and_command): Don't change window
 229         visibility.
 230         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 231         <make_visible>: New method.
 232         * tui/tui-command.c (tui_cmd_window::resize): New method.
 233
 234 2019-08-15  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 237         (struct tui_source_windows): New.
 238         * tui/tui-winsource.c (tui_display_main): Update.
 239         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 240         (new_height_ok, parse_scrolling_args): Update.
 241         * tui/tui-layout.c (show_layout, show_data): Update.
 242         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 243         (tui_add_to_source_windows): Don't declare.
 244         * tui/tui-data.c (source_windows, tui_source_windows)
 245         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 246
 247 2019-08-15  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 250         Rename from reset.
 251         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 252         * tui/tui-layout.c (show_source_disasm_command, show_data):
 253         Update.
 254         (tui_gen_win_info::resize): Rename.
 255         (show_source_or_disasm_and_command): Update.
 256         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 257         reset.
 258
 259 2019-08-15  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 262         * tui/tui-interp.c (tui_interp::init): Don't call
 263         tui_initialize_static_data.
 264         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 265
 266 2019-08-15  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 269         examine tui_win_list.
 270
 271 2019-08-15  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 274         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 275         tui_clear_source_content.
 276         (tui_clear_source_content): Remove.
 277         (tui_source_window_base::do_erase_source_content): Hoist call to
 278         content.clear().
 279         * tui/tui-stack.c (tui_show_frame_info): Don't call
 280         tui_clear_source_content.
 281
 282 2019-08-15  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-winsource.h (struct tui_source_window_base)
 285         <do_erase_source_content>: New method.
 286         <erase_source_content>: New method.
 287         (tui_erase_source_content): Don't declare.
 288         * tui/tui-winsource.c (tui_clear_source_content): Update.
 289         (tui_source_window_base::do_erase_source_content): Rename from
 290         tui_erase_source_content.
 291         (tui_source_window_base::show_source_content): Update.
 292         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 293         * tui/tui-source.h (struct tui_source_window)
 294         <erase_source_content>: New method.
 295         * tui/tui-disasm.h (struct tui_disasm_window)
 296         <erase_source_content>: New method.
 297
 298 2019-08-15  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 301         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 302         constructor.
 303         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 304         * tui/tui-source.c (tui_set_source_content): Update.
 305         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 306
 307 2019-08-15  Tom Tromey  <tom@tromey.com>
 308
 309         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 310         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 311         tui-source.c.
 312         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 313         Declare.
 314         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 315         method.
 316         (tui_source_window::maybe_update): Update.
 317
 318 2019-08-15  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 321         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 322         tui-disasm.c.
 323         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 324         Declare.
 325         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 326         method.
 327         (tui_disasm_window::maybe_update): Update.
 328
 329 2019-08-15  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-winsource.h (struct tui_source_window_base)
 332         <maybe_update>: Declare.
 333         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 334         method.
 335         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 336         Declare.
 337         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 338         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 339         Declare.
 340         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 341
 342 2019-08-15  Tom Tromey  <tom@tromey.com>
 343
 344         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 345
 346 2019-08-15  Tom Tromey  <tom@tromey.com>
 347
 348         * tui/tui-wingeneral.c: Include tui-stack.h.
 349         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 350         (struct tui_locator_window): Move from tui-data.h.
 351         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 352         (tui_initialize_static_data): Move from tui-data.c.
 353         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 354         (struct tui_locator_window): Move to tui-stack.c.
 355         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 356         (tui_initialize_static_data): Move to tui-stack.c.
 357
 358 2019-08-15  Tom Tromey  <tom@tromey.com>
 359
 360         * tui/tui-layout.c (show_source_disasm_command)
 361         (show_source_or_disasm_and_command): Use make_visible method, not
 362         tui_make_window.
 363         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 364         Remove.
 365
 366 2019-08-15  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-wingeneral.h (tui_make_window): Update.
 369         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 370         parameter.
 371         (tui_gen_win_info::make_visible): Update.
 372         * tui/tui-regs.c (tui_data_window::display_registers_from):
 373         Update.
 374         * tui/tui-layout.c (show_source_disasm_command)
 375         (show_source_or_disasm_and_command): Update.
 376         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 377         (enum tui_box): Remove.
 378         (struct tui_win_info) <can_box>: New method.
 379         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 380         method.
 381
 382 2019-08-15  Tom de Vries  <tdevries@suse.de>
 383
 384         * linux-nat-trad.c: Include gdbarch.h.
 385
 386 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 387
 388         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 389         register sizes.
 390
 391 2019-08-14  Tom Tromey  <tromey@adacore.com>
 392
 393         * darwin-nat.c: Include gdbarch.h.
 394         * darwin-nat-info.c: Include gdbarch.h.
 395
 396 2019-08-13  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 399         Remove.
 400         * tui/tui-data.c (tui_initialize_static_data): Update.
 401
 402 2019-08-13  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-winsource.h (struct tui_exec_info_window)
 405         <~tui_exec_info_window, maybe_allocate_content, get_content,
 406         m_content>: Remove.
 407         (struct tui_source_window_base) <set_exec_info_content,
 408         show_exec_info_content>: Don't declare.
 409         * tui/tui-winsource.c
 410         (tui_exec_info_window::maybe_allocate_content): Remove.
 411         (tui_source_window_base::update_exec_info): Rename from
 412         set_exec_info_content.
 413         (tui_source_window_base::show_exec_info_content)
 414         (tui_source_window_base::update_exec_info): Remove.
 415
 416 2019-08-13  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 419         declare.
 420         * tui/tui-winsource.c (tui_update_source_window_as_is)
 421         (tui_update_source_windows_with_addr, tui_erase_source_content):
 422         Update.
 423         (tui_clear_exec_info_content): Remove.
 424
 425 2019-08-13  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 428         declare.
 429         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 430         call tui_erase_exec_info_content.
 431         (tui_clear_exec_info_content): Rename from
 432         tui_erase_exec_info_content.
 433         (tui_clear_exec_info_content): Delete.
 434
 435 2019-08-13  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-winsource.h (struct tui_source_window_base)
 438         <show_exec_info_content>: Declare.
 439         (tui_show_exec_info_content): Don't declare.
 440         * tui/tui-winsource.c
 441         (tui_source_window_base::show_exec_info_content): Rename from
 442         tui_show_exec_info_content.
 443         (tui_source_window_base::update_exec_info): Update.
 444
 445 2019-08-13  Tom Tromey  <tom@tromey.com>
 446
 447         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 448         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 449         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 450         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 451         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 452         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 453         ... here.
 454
 455 2019-08-13  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui-winsource.h (struct tui_source_window_base)
 458         <update_exec_info>: Declare.
 459         (tui_update_exec_info): Don't declare.
 460         * tui/tui-winsource.c (tui_update_source_window_as_is)
 461         (tui_source_window_base::refresh_all)
 462         (tui_update_all_breakpoint_info): Update.
 463         (tui_source_window_base::update_exec_info): Rename from
 464         tui_update_exec_info.
 465         * tui/tui-stack.c (tui_show_frame_info): Update.
 466
 467 2019-08-13  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-winsource.h (struct tui_source_window_base)
 470         <set_exec_info_content>: Declare.
 471         (tui_set_exec_info_content): Don't declare.
 472         * tui/tui-winsource.c
 473         (tui_source_window_base::set_exec_info_content): Rename from
 474         tui_set_exec_info_content.
 475         (tui_update_exec_info): Update.
 476
 477 2019-08-13  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-winsource.h (struct tui_source_window_base)
 480         <show_source_content>: Declare.
 481         (tui_show_source_content): Don't declare.
 482         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 483         (tui_source_window_base::show_source_content): Rename from
 484         tui_show_source_content.
 485         (tui_source_window_base::refresh_all): Update.
 486         * tui/tui-layout.c (show_source_disasm_command)
 487         (show_source_or_disasm_and_command): Update.
 488
 489 2019-08-13  Tom Tromey  <tom@tromey.com>
 490
 491         * tui/tui-winsource.c (tui_erase_source_content)
 492         (tui_show_source_content, tui_source_window_base::refresh_all):
 493         Update.
 494         * tui/tui-wingeneral.h
 495         (tui_check_and_display_highlight_if_needed): Don't declare.
 496         * tui/tui-wingeneral.c
 497         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 498         check_and_display_highlight_if_needed.
 499         * tui/tui-win.c (tui_rehighlight_all)
 500         (tui_win_info::make_visible_with_new_height): Update.
 501         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 502         (tui_data_window::erase_data_content)
 503         (tui_data_window::display_all_data): Update.
 504         * tui/tui-data.h (struct tui_win_info)
 505         <check_and_display_highlight_if_needed>: Declare.
 506
 507 2019-08-13  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-win.c (tui_resize_all): Call
 510         tui_delete_invisible_windows.
 511         * tui/tui-layout.c (show_layout): Call
 512         tui_delete_invisible_windows.
 513         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 514         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 515
 516 2019-08-13  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 519         tui_add_win_to_layout.
 520
 521 2019-08-13  Tom Tromey  <tom@tromey.com>
 522
 523         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 524         * tui/tui-layout.c (tui_default_win_height): Now static.
 525
 526 2019-08-13  Tom Tromey  <tom@tromey.com>
 527
 528         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 529         single switch.
 530         (show_source_disasm_command, show_source_or_disasm_and_command):
 531         Don't check current layout.
 532
 533 2019-08-13  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-wingeneral.c (make_all_visible): Remove.
 536         (tui_make_all_invisible): Simplify.
 537         * tui/tui-layout.c (tui_make_all_invisible): Move from
 538         tui-wingeneral.c; simplify.
 539         (show_layout): Hoist call to tui_make_all_invisible.
 540         (show_data): Don't call tui_make_all_invisible.
 541
 542 2019-08-13  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 545         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 546
 547 2019-08-13  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 550         tui-data.c.
 551         (show_source_disasm_command, show_data)
 552         (show_source_or_disasm_and_command): Don't use
 553         tui_set_current_layout_to.
 554         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 555         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 556         tui-layout.c.
 557         (tui_set_current_layout_to): Remove.
 558
 559 2019-08-13  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-layout.c (tui_set_layout): Update.
 562         * tui/tui-data.h (struct tui_layout_def): Remove.
 563         (tui_layout_def): Don't declare.
 564         * tui/tui-data.c (layout_def): Remove.
 565         (tui_layout_def): Remove.
 566
 567 2019-08-13  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-winsource.h (struct tui_source_window_base)
 570         <clear_detail>: No longer "override".
 571         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 572         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 573         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 574         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 575         Remove.
 576         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 577
 578 2019-08-13  Tom Tromey  <tromey@adacore.com>
 579
 580         * tracepoint.c: Don't include readline.h or history.h.
 581
 582 2019-08-12  Tom Tromey  <tom@tromey.com>
 583
 584         * configure: Rebuild.
 585         * configure.ac: Check for readline 7.
 586         * NEWS: Mention readline 7 requirement.
 587         * README: Update.
 588
 589 2019-08-12  Tom Tromey  <tom@tromey.com>
 590
 591         * mingw-hdep.c (gdb_select): Remove readline hack.
 592
 593 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 594
 595         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 596         when the function fails.
 597
 598 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 599
 600         * s390-tdep.c (s390_type_align): New function.
 601         (s390_gdbarch_init): Set it as type_align gdbarch method.
 602
 603 2019-08-09  Tom de Vries  <tdevries@suse.de>
 604
 605         PR gdb/24591
 606         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 607         pc_low with relocation offset.
 608
 609 2019-08-07  Tom Tromey  <tromey@adacore.com>
 610
 611         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 612         (print_frame_args): Update.
 613         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 614         Update.
 615         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 616         * frame.h (struct frame_arg): Add initializers.
 617         <error>: Now a unique_xmalloc_ptr.
 618
 619 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 620
 621         * NEWS: Expand the Pointer Authentication entry.
 622         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 623         (aarch64_frame_unmask_lr): ... to this.
 624         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 625         Call aarch64_frame_unmask_lr.
 626         * frame.c (struct frame_info): Add "masked" variable.
 627         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 628         (fprint_frame): Check for masked pc.
 629         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 630         declarations.
 631         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 632         * stack.c (print_frame): Check for masked pc.
 633
 634 2019-08-06  Tom Tromey  <tom@tromey.com>
 635
 636         * stabsread.c (patch_block_stabs, read_one_struct_field)
 637         (read_enum_type): Use obstack_strndup.
 638         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 639         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 640         * dwarf2read.c (guess_full_die_structure_name)
 641         (anonymous_struct_prefix): Use obstack_strndup.
 642         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 643         * c-exp.y (yylex): Use obstack_strndup.
 644         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 645         (write_var_or_type): Use obstack_strndup.
 646
 647 2019-08-06  Tom Tromey  <tom@tromey.com>
 648
 649         * symfile.c (reread_symbols): Use obstack_strdup.
 650         * stabsread.c (read_type): Use obstack_strdup.
 651         * gdb_obstack.h (obstack_strdup): New overload.
 652         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 653         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 654         (dwarf2_canonicalize_name): Use obstack_strdup.
 655         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 656         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 657         Use obstack_strdup.
 658
 659 2019-08-06  Tom Tromey  <tom@tromey.com>
 660
 661         * gdb_obstack.h (obstack_strdup): Define.
 662         * gdb_obstack.c (obstack_strdup): Don't define.
 663
 664 2019-08-06  Tom Tromey  <tom@tromey.com>
 665
 666         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 667         obstack_strdup.
 668         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 669         obstack_strdup.
 670         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 671         * stabsread.c (common_block_start): Use obstack_strdup.
 672         * objfiles.c (set_objfile_main_name, objfile): Use
 673         obstack_strdup.
 674         * namespace.c (add_using_directive): Use obstack_strdup.
 675         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 676         * jit.c (finalize_symtab): Use obstack_strdup.
 677         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 678         (guess_partial_die_structure_name, partial_die_info::fixup)
 679         (dwarf2_name): Use obstack_strdup.
 680         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 681         obstack_strdup.
 682         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 683         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 684         obstack_strdup.
 685         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 686
 687 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 688
 689         * unittests/help-doc-selftests.c: New file.
 690         * Makefile.in: Add the new file.
 691
 692 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 693
 694         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 695         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 696         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 697         the trailing '.' is not output, and the first character is uppercased.
 698         (print_help_for_command): Update call to print_doc_line.
 699         (print_doc_of_command): Likewise.
 700         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 701         * cli/cli-option.c (append_indented_doc): Do not append newline.
 702         (build_help_option): Append newline after first appended_indented_doc
 703         only if a second call is done.
 704         (build_help): Append 2 new lines before each option, except the first
 705         one.
 706         * compile/compile.c (_initialize_compile): Add new lines after
 707         %OPTIONS%, when not at the end of the help.
 708         Change help doc or code
 709         producing the help doc to respect the invariants.
 710         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 711         Also removed the new line after 'Options:', as all other commands
 712         do not put an empty line between 'Options:' and the first option.
 713         * printcmd.c (_initialize_printcmd): Likewise.
 714         * stack.c (_initialize_stack): Likewise.
 715         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 716         incorrectly telling COMMAND is optional.
 717         * ada-lang.c (_initialize_ada_language): Change help doc or code
 718         producing the help doc to respect the invariants.
 719         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 720         * breakpoint.c (_initialize_breakpoint): Likewise.
 721         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 722         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 723         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 724         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 725         _initialize_cli_style): Likewise.
 726         * corelow.c (core_target_info): Likewise.
 727         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 728         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 729         * filesystem.c (_initialize_filesystem): Likewise.
 730         * frame.c (_initialize_frame): Likewise.
 731         * gnu-nat.c (add_task_commands): Likewise.
 732         * infcall.c (_initialize_infcall): Likewise.
 733         * infcmd.c (_initialize_infcmd): Likewise.
 734         * interps.c (_initialize_interpreter): Likewise.
 735         * language.c (_initialize_language): Likewise.
 736         * linux-fork.c (_initialize_linux_fork): Likewise.
 737         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 738         * maint.c (_initialize_maint_cmds): Likewise.
 739         * memattr.c (_initialize_mem): Likewise.
 740         * printcmd.c (_initialize_printcmd): Likewise.
 741         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 742         _RegEx): Likewise.
 743         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 744         * record-btrace.c (_initialize_record_btrace): Likewise.
 745         * record-full.c (_initialize_record_full): Likewise.
 746         * record.c (_initialize_record): Likewise.
 747         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 748         * regcache.c (_initialize_regcache): Likewise.
 749         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 750         _initialize_remote): Likewise.
 751         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 752         * serial.c (_initialize_serial): Likewise.
 753         * skip.c (_initialize_step_skip): Likewise.
 754         * source.c (_initialize_source): Likewise.
 755         * stack.c (_initialize_stack): Likewise.
 756         * symfile.c (_initialize_symfile): Likewise.
 757         * symtab.c (_initialize_symtab): Likewise.
 758         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 759         * top.c (init_main): Likewise.
 760         * tracefile-tfile.c (tfile_target_info): Likewise.
 761         * tracepoint.c (_initialize_tracepoint): Likewise.
 762         * tui/tui-win.c (_initialize_tui_win): Likewise.
 763         * utils.c (add_internal_problem_command): Likewise.
 764         * valprint.c (value_print_option_defs): Likewise.
 765
 766 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 767
 768         PR build/24886
 769         * configure.ac: Drop enable-libmcheck support.
 770         * configure, config.in: Rebuild.
 771         * libmcheck.m4: Remove.
 772         * acinclude.m4: Don't include it.
 773         * Makefile.in: Don't distribute it.
 774         * top.c (print_gdb_configuration): Don't mention it.
 775
 776 2019-08-06  Tom Tromey  <tom@tromey.com>
 777
 778         * utils.c (set_output_style): Sometimes pass stream to
 779         emit_style_escape.
 780         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 781         * record-btrace.c (btrace_insn_history): Update.
 782         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 783         method.
 784         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 785         Update initializers.
 786         <m_uiout>: New field.
 787         <m_di>: Move lower.
 788         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 789         Remove "uiout" parameter.
 790         (dump_insns): Update.
 791         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 792         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 793
 794 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 795
 796         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 797         (error_in_psymtab_expansion): Likewise.
 798         (lookup_symbol_via_quick_fns): Likewise.
 799         (basic_lookup_transparent_type_quick): Likewise.
 800         (basic_lookup_transparent_type_1): Likewise.
 801
 802 2019-08-06  Tom Tromey  <tromey@adacore.com>
 803
 804         * source.c (last_source_error): Now bool.
 805         (print_source_lines_base): Make "noprint" bool.  Only open
 806         source file when last_source_visited changes.
 807
 808 2019-08-06  Tom Tromey  <tromey@adacore.com>
 809
 810         * annotate.c (annotate_source_line): Use g_source_cache.
 811         * source-cache.c (source_cache::get_plain_source_lines): Change
 812         parameters.  Populate m_offset_cache.
 813         (source_cache::ensure): New method.
 814         (source_cache::get_line_charpos): New method.
 815         (extract_lines): Move lower.  Change parameters.
 816         (source_cache::get_source_lines): Move lower.
 817         * source-cache.h (class source_cache): Update comment.
 818         <get_line_charpos>: New method.
 819         <get_source_lines>: Update comment.
 820         <clear>: Clear m_offset_cache.
 821         <get_plain_source_lines>: Change parameters.
 822         <ensure>: New method
 823         <m_offset_cache>: New member.
 824         * source.c (forget_cached_source_info_for_objfile): Update.
 825         (info_source_command): Use g_source_cache.
 826         (find_source_lines, open_source_file_with_line_charpos): Remove.
 827         (print_source_lines_base, search_command_helper): Use g_source_cache.
 828         * source.h (open_source_file_with_line_charpos): Don't declare.
 829         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 830         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 831         Use g_source_cache.
 832
 833 2019-08-06  Tom Tromey  <tromey@adacore.com>
 834
 835         * source-cache.c (source_cache::get_plain_source_lines):
 836         Remove "first_line" and "last_line" parameters.
 837         (source_cache::get_source_lines): Cache plain text.
 838         * source-cache.h (class source_cache)
 839         <get_plain_source_lines>: Update.
 840
 841 2019-08-06  Tom Tromey  <tromey@adacore.com>
 842
 843         * source-cache.c (extract_lines): No longer a method.
 844         Changed type of parameter.  Include final newline.
 845         (selftests::extract_lines_test): New function.
 846         (_initialize_source_cache): Likewise.
 847         * source-cache.h (class source_cache)
 848         <extract_lines>: Don't declare.
 849
 850 2019-08-06  Tom Tromey  <tromey@adacore.com>
 851
 852         * breakpoint.c (init_breakpoint_sal): Update.
 853         (breakpoint): Update.
 854         * breakpoint.h (struct breakpoint) <filter>: Now a
 855         unique_xmalloc_ptr.
 856
 857 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 858
 859         * NEWS: Mention dictionary access on blocks.
 860         * python/py-block.c (blpy_getitem): New function.
 861         (block_object_as_mapping): New struct.
 862         (block_object_type): Use new struct for tp_as_mapping field.
 863
 864 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 865
 866         * objfiles.h (objfile): Add a comment describing partial symbols.
 867
 868 2019-08-05  Tom Tromey  <tromey@adacore.com>
 869
 870         * compile/compile.c (_initialize_compile): Use _(), not N_().
 871         * thread.c (_initialize_thread): Use _(), not N_().
 872         * stack.c (_initialize_stack): Use _(), not N_().
 873         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 874
 875 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 876
 877         * dwarf2read.c (struct dw2_symtab_iterator):
 878         <want_specific_block>: Remove.
 879         <block_index>: Change type to gdb::optional.
 880         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 881         change type of BLOCK_INDEX parameter to gdb::optional.
 882         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 883         (dw2_lookup_symbol): Don't pass argument for
 884         WANT_SPECIFIC_BLOCK.
 885         (dw2_expand_symtabs_for_function): Don't pass argument for
 886         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 887         (class dw2_debug_names_iterator)
 888         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 889         parameter, change BLOCK_INDEX type to gdb::optional.
 890         <m_want_specific_block>: Remove.
 891         <m_block_index>: Change type to gdb::optional.
 892         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 893         gdb::optional.  Re-write in function of gdb::optional.
 894         (dw2_debug_names_lookup_symbol): Don't pass argument for
 895         WANT_SPECIFIC_BLOCK.
 896         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 897         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 898         BLOCK_INDEX.
 899
 900 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 901
 902         * NEWS: Mention changes to "info sources" command.
 903
 904 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 905
 906         * symtab.c (filename_partial_match_opts): New struct type.
 907         (struct output_source_filename_data): New members
 908         regexp, c_regexp, partial_match.
 909         (output_source_filename): Use new members to decide to print file.
 910         (info_sources_option_defs): New variable.
 911         (make_info_sources_options_def_group, print_info_sources_header,
 912         info_sources_command_completer):
 913         New functions.
 914         (info_sources_command): Read new optional arguments.
 915         (_initialize_symtab): Update info sources help.
 916
 917 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 918
 919         * ada-lang.c (exception_support_info_v0): Renamed from...
 920         (default_exception_support_info): ... this.  Create new
 921         definition for v1.
 922         (ada_has_this_exception_support): Look up catch_handlers_sym.
 923         (ada_exception_support_info_sniffer): Try v0 after default.
 924
 925 2019-08-01  Tom Tromey  <tromey@adacore.com>
 926
 927         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 928         gdbarch.h.
 929
 930 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 931
 932         * s12z-tdep.c: Fix include path for s12z-opc.h.
 933
 934 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 935
 936         * NEWS: Require GNU make 3.82.
 937
 938 2019-07-16  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 941         declare.
 942
 943 2019-07-30  Tom Tromey  <tromey@adacore.com>
 944
 945         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 946
 947 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 948
 949         * printcmd.c (print_address_symbolic): Print negative offsets.
 950         (build_address_symbolic): Force signed arithmetic when computing
 951         offset.
 952
 953 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 954
 955         PR/24474: Add a function to lookup static variables.
 956         * NEWS: Mention this new function.
 957         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 958         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 959         * python/python.c (python_GdbMethods): Add new function.
 960
 961 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 962
 963         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 964         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 965         (objfpy_lookup_static_symbol): New function.
 966         (objfile_object_methods): Add new functions.
 967
 968 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 969
 970         * NEWS: Mention 'set|show print frame-info'.  Mention new
 971         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 972         backtrace argument.  Mention that python frame filtering code
 973         is now consistent with what 'backtrace' command prints.
 974
 975 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 976
 977         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 978         comments.
 979         (print_frame_info_auto, print_frame_info_source_line,
 980         print_frame_info_location, print_frame_info_source_and_location,
 981         print_frame_info_location_and_address, print_frame_info_short_location):
 982         New declarations.
 983         (struct frame_print_options): New member print_frame_info.
 984         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 985         * stack.h (get_user_print_what_frame_info): New declaration.
 986         (frame_show_address): New declaration.
 987         * stack.c (print_frame_arguments_choices): New value 'presence'.
 988         (print_frame_info_auto, print_frame_info_source_line,
 989         print_frame_info_location, print_frame_info_source_and_location,
 990         print_frame_info_location_and_address, print_frame_info_short_location,
 991         print_frame_info_choices, print_frame_info_print_what): New definitions.
 992         (print_frame_args): Only print dots for args if print frame-arguments
 993         is 'presence'.
 994         (frame_print_option_defs): New element for "frame-info".
 995         (get_user_print_what_frame_info): New function.
 996         (frame_show_address): Make non static.  Move comment to stack.h.
 997         (print_frame_info_to_print_what): New function.
 998         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 999         to decide what to print.
1000         (backtrace_command_1): Handle the new print_frame_arguments_presence
1001         value.
1002         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1003         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1004         (py_print_frame): In non-mi mode, use LOCATION as default for
1005         print_what, similarly to frame information printed directly by
1006         backtrace command. Handle frame-info user option in non MI mode.
1007
1008 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1009
1010         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1011         Add case for debugging 32-bit target on 64-bit host.  Revise
1012         comment.
1013
1014 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1015
1016         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1017         instead of find_function_entry_range_from_pc.
1018
1019 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1020
1021         * stack.c (find_frame_funname): Remove code which preferred
1022         minsym over symtab sym in "certain pathological cases".
1023
1024         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1025         parameter.  Change type of "do_demangle" to bool.
1026         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1027         Pass suitable "prefer_sym_over_minsym" flag to
1028         build_address_symbolic().  Don't output "+" for negative offsets.
1029         * printcmd.c (print_address_symbolic): Update invocation of
1030         build_address_symbolic to include a "prefer_sym_over_minsym"
1031         flag.
1032         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1033         Restrict cases in which use of minimal symbol is preferred to that
1034         of a found symbol.  Update comments.
1035
1036         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1037         for entry pc when entry pc is out of range for that FDE.
1038
1039 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1040
1041         PR gdb/24839:
1042         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1043         type.
1044
1045 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1046
1047         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1048         this function's Python signature.
1049
1050
1051 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1052
1053         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1054         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1055         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1056         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1057         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1058
1059
1060 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1061
1062         * h8300-tdep.c (h8300_register_name_common): New.
1063         h8300_register_name): Use h8300_register_name_common.
1064         (h8300s_register_name): Likewise.
1065         (h8300sx_register_name): Likewise.
1066         (h8300h_register_nam): New.
1067         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1068
1069
1070 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1071
1072         * arm-tdep.c (arm_skip_cmse_entry): New function.
1073         (arm_is_sgstubs_section): New function.
1074         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1075
1076 2019-07-22  Tom Tromey  <tom@tromey.com>
1077
1078         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1079         Don't self-assign.
1080
1081 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1082
1083         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1084         type_print.
1085
1086 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1089         so that GDB doesn't match any msymbols when searching in the
1090         TYPES_DOMAIN.
1091         (print_symbol_info): Print using typedef_print or type_print based
1092         on the type of the symbol.  Add updated FIXME comment moved from...
1093         (_initialize_symtab): ... move and update FIXME comment to above.
1094
1095 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1096
1097         * NEWS: Mention adding -q option to "info types".
1098         * symtab.c (struct info_types_options): New struct.
1099         (info_types_options_defs): New variable.
1100         (make_info_types_options_def_group): New function.
1101         (info_types_command): Use gdb::option framework to parse options.
1102         (info_types_command_completer): New function.
1103         (_initialize_symtab): Extend the help text on "info types" and
1104         register command completer.
1105
1106 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1107
1108         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1109         (lookup_symbol_in_objfile): Change int to block_enum and add a
1110         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1111
1112 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1113
1114         * MAINTAINERS (Write After Approval): Add self.
1115
1116 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1119         instruction to the dummy code region.
1120
1121 2019-07-19  Tom Tromey  <tromey@adacore.com>
1122
1123         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1124         (ARGSUSED, PARAMS, __func__): Remove rules.
1125
1126 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1127
1128         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1129         * features/arm/arm-with-iwmmxt.c: Remove.
1130         * features/arm/arm-with-iwmmxt.xml: Remove.
1131         * features/arm/arm-with-m-fpa-layout.c: Remove.
1132         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1133         * features/arm/arm-with-m-vfp-d16.c: Remove.
1134         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1135         * features/arm/arm-with-m.c: Remove.
1136         * features/arm/arm-with-m.xml: Remove.
1137         * features/arm/arm-with-neon.c: Remove.
1138         * features/arm/arm-with-neon.xml: Remove.
1139         * features/arm/arm-with-vfpv2.c: Remove.
1140         * features/arm/arm-with-vfpv2.xml: Remove.
1141         * features/arm/arm-with-vfpv3.c: Remove.
1142         * features/arm/arm-with-vfpv3.xml: Remove.
1143
1144 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1145
1146         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1147
1148 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1149
1150         * arch/aarch32.c (aarch32_create_target_description): Create
1151         target descriptions using features.
1152         * arch/arm.c (arm_create_target_description)
1153         (arm_create_mprofile_target_description): Likewise.
1154         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1155
1156 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1157
1158         * Makefile.in: Add new files.
1159         * aarch32-tdep.c: New file.
1160         * aarch32-tdep.h: New file.
1161         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1162         Call aarch32_read_description.
1163         * arch/aarch32.c: New file.
1164         * arch/aarch32.h: New file.
1165         * arch/arm.c (arm_create_target_description)
1166         (arm_create_mprofile_target_description): New function.
1167         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1168         (arm_create_target_description)
1169         (arm_create_mprofile_target_description): New declaration.
1170         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1171         read_description functions.
1172         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1173         Likewise.
1174         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1175         * arm-tdep.c (tdesc_arm_list): New variable.
1176         (arm_register_g_packet_guesses): Call create description functions.
1177         (arm_read_description) (arm_read_mprofile_description): New
1178         function.
1179         * arm-tdep.h (arm_read_description)
1180         (arm_read_mprofile_description): Add declaration.
1181         * configure.tgt: Add new files.
1182
1183 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1184
1185         * top.c (new_ui_command): Open specified terminal just once.
1186
1187 2019-07-18  Tom Tromey  <tromey@adacore.com>
1188
1189         * symtab.c (main_name): Constify return type.
1190         * symfile.c (set_initial_language): Update.
1191         * symtab.h (main_name): Constify return type.
1192
1193 2019-07-17  Tom Tromey  <tom@tromey.com>
1194
1195         * tui/tui-winsource.c (tui_update_source_window)
1196         (tui_update_source_window_as_is)
1197         (tui_update_source_windows_with_line): Remove return.
1198         * tui/tui-disasm.c (tui_show_disassem)
1199         (tui_show_disassem_and_update_source): Remove return.
1200         * tui/tui.c (tui_reset): Remove return.
1201         * tui/tui-wingeneral.c
1202         (tui_check_and_display_highlight_if_needed): Remove return.
1203
1204 2019-07-17  Tom Tromey  <tom@tromey.com>
1205
1206         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1207
1208 2019-07-17  Tom Tromey  <tom@tromey.com>
1209
1210         * tui/tui-winsource.h (struct tui_exec_info_window)
1211         (struct tui_source_window_base): Move from tui-data.h.
1212         * tui/tui-winsource.c: Move many method definitions from
1213         elsewhere.  Remove "structuring" comments.
1214         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1215         (tui_source_window_base::refresh_window): Move to
1216         tui-winsource.c.
1217         * tui/tui-win.c (tui_source_window_base::refresh_all)
1218         (tui_source_window_base::update_tab_width)
1219         (tui_source_window_base::set_new_height)
1220         (tui_source_window_base::do_make_visible_with_new_height): Move to
1221         tui-winsource.c.
1222         * tui/tui-source.h: Update.
1223         * tui/tui-source.c (tui_source_window_base::reset): Move to
1224         tui-winsource.c.
1225         * tui/tui-disasm.h: Update.
1226         * tui/tui-data.h (struct tui_exec_info_window): Move to
1227         tui-winsource.h.
1228         (struct tui_source_window_base): Likewise.
1229         * tui/tui-data.c (tui_source_window_base::clear_detail)
1230         (tui_source_window_base, ~tui_source_window_base): Move to
1231         tui-winsource.c.
1232
1233 2019-07-17  Tom Tromey  <tom@tromey.com>
1234
1235         * tui/tui-win.c (tui_resize_all)
1236         (tui_source_window_base::update_tab_width)
1237         (tui_adjust_win_heights): Update.
1238         (tui_win_info::make_invisible_and_set_new_height): Rename from
1239         make_invisible_and_set_new_height.
1240         * tui/tui-data.h (struct tui_win_info)
1241         <make_invisible_and_set_new_height>: New method.
1242
1243 2019-07-17  Tom Tromey  <tom@tromey.com>
1244
1245         * tui/tui.c: Update.
1246         * tui/tui-source.h (struct tui_source_window): Move from
1247         tui-data.h.
1248         * tui/tui-layout.c: Update.
1249         * tui/tui-disasm.c: Update.
1250         * tui/tui-data.h (struct tui_source_window): Move to
1251         tui-source.h.
1252
1253 2019-07-17  Tom Tromey  <tom@tromey.com>
1254
1255         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1256         tui-data.h.
1257         * tui/tui-data.h (struct tui_disasm_window): Move to
1258         tui-disasm.h.
1259
1260 2019-07-17  Tom Tromey  <tom@tromey.com>
1261
1262         * tui/tui-regs.h (struct tui_data_item_window): Move from
1263         tui-data.h.
1264         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1265         * tui/tui-data.h (struct tui_data_item_window): Move to
1266         tui-regs.h.
1267         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1268
1269 2019-07-17  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui.c: Update.
1272         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1273         (tui_cmd_window::max_height): Move to tui-command.c.
1274         * tui/tui-layout.c: Update.
1275         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1276         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1277         tui-command.c.
1278         * tui/tui-command.h (struct tui_cmd_window): Move from
1279         tui-data.h.
1280         * tui/tui-command.c: Remove "structuring" comments.
1281         (tui_cmd_window::clear_detail)
1282         (tui_cmd_window::do_make_visible_with_new_height)
1283         (tui_cmd_window::max_height): Move from elsewhere.
1284
1285 2019-07-17  Tom Tromey  <tom@tromey.com>
1286
1287         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1288         Now static.
1289         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1290         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1291
1292 2019-07-17  Tom Tromey  <tom@tromey.com>
1293
1294         * tui/tui.c: Update.
1295         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1296         tui-regs.c.
1297         * tui/tui-windata.h: Remove file.
1298         * tui/tui-windata.c: Remove file.
1299         * tui/tui-win.c (tui_data_window::set_new_height)
1300         (tui_data_window::do_make_visible_with_new_height): Move to
1301         tui-regs.c.
1302         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1303         * tui/tui-regs.c: Remove "structuring" comments.
1304         (tui_data_window::first_data_item_displayed)
1305         (tui_data_window::delete_data_content_windows)
1306         (tui_data_window::erase_data_content)
1307         (tui_data_window::display_all_data)
1308         (tui_data_window::refresh_all)
1309         (tui_data_window::do_scroll_vertical)
1310         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1311         (tui_data_window::do_make_visible_with_new_height)
1312         (tui_data_window::refresh_window): Move from elsewhere.
1313         (_initialize_tui_regs): Move to end of file.
1314         * tui/tui-layout.c: Update.
1315         * tui/tui-hooks.c: Update.
1316         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1317         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1318         tui-regs.c.
1319         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1320
1321 2019-07-17  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1324         seen.
1325
1326 2019-07-17  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-win.c (tui_source_window_base::set_new_height)
1329         (tui_source_window_base::do_make_visible_with_new_height): Use
1330         m_has_locator field directly.
1331         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1332         method.
1333         (struct tui_source_window_base) <has_locator>: Likewise.
1334
1335 2019-07-17  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1338         Don't declare.
1339         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1340         Remove.
1341         * tui/tui-win.c (tui_source_window_base::set_new_height)
1342         (tui_source_window_base::set_new_height)
1343         (make_invisible_and_set_new_height)
1344         (tui_source_window_base::do_make_visible_with_new_height)
1345         (tui_source_window_base::do_make_visible_with_new_height):
1346         Update.
1347         * tui/tui-layout.c (show_source_disasm_command, show_data)
1348         (show_source_or_disasm_and_command): Update.
1349         * tui/tui-layout.c (show_layout): Update.
1350
1351 2019-07-17  Tom Tromey  <tom@tromey.com>
1352
1353         * tui/tui-layout.c (make_data_window): Remove.
1354         (show_data): Unify creation and re-initialization cases.
1355
1356 2019-07-17  Tom Tromey  <tom@tromey.com>
1357
1358         * tui/tui-layout.c (make_source_window, make_disasm_window):
1359         Remove.
1360         (show_data): Unify creation and re-initialization cases.
1361
1362 2019-07-17  Tom Tromey  <tom@tromey.com>
1363
1364         * tui/tui-layout.c (make_command_window): Remove.
1365         (show_source_disasm_command, show_source_or_disasm_and_command):
1366         Unify creation and re-initialization cases.
1367
1368 2019-07-17  Tom Tromey  <tom@tromey.com>
1369
1370         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1371         creation and re-initialization cases.
1372
1373 2019-07-17  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-regs.c (tui_get_register): Return void.
1376
1377 2019-07-17  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1380         Simplify.
1381
1382 2019-07-17  Tom Tromey  <tom@tromey.com>
1383
1384         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1385         resetting.
1386
1387 2019-07-17  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1390         * tui/tui-regs.c (tui_reg_layout): New function.
1391         (tui_show_registers, tui_reg_command): Use it.
1392         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1393         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1394         parameters.
1395         (tui_layout_command): Remove.
1396
1397 2019-07-17  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-layout.h (tui/tui-layout): Return void.
1400         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1401
1402 2019-07-17  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-layout.c (show_source_disasm_command, show_data):
1405         Update.
1406         (reset_locator): Remove.
1407         (show_source_or_disasm_and_command): Update.
1408
1409 2019-07-17  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-source.c (tui_source_window_base::reset): Remove
1412         win_type parameter.
1413         * tui/tui-layout.c (make_command_window, make_source_window)
1414         (make_disasm_window, make_data_window)
1415         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1416         (reset_locator, show_source_or_disasm_and_command): Update.
1417         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1418         win_type parameter.
1419         (struct tui_source_window_base) <reset>: Likewise.
1420
1421 2019-07-17  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-layout.c (show_source_disasm_command): Use
1424         reset_locator.
1425         (reset_locator): New function.
1426         (init_and_make_win): Remove.
1427         (show_source_or_disasm_and_command): Use reset_locator.
1428
1429 2019-07-17  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1432         condition.
1433         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1434         Remove condition.
1435         * tui/tui-source.c (tui_source_window_base::reset): New method.
1436         * tui/tui-layout.c (make_command_window): Don't call
1437         init_and_make_win.
1438         (make_source_window, make_disasm_window): Don't call
1439         make_source_or_disasm_window.
1440         (make_data_window): Don't call init_and_make_win.  Change calling
1441         convention.
1442         (show_source_disasm_command, show_data): Simplify.
1443         (make_source_or_disasm_window): Remove.
1444         (show_source_or_disasm_and_command): Simplify.
1445         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1446         (struct tui_source_window_base) <reset>: Likewise.
1447         <execution_info>: Remove initializer.
1448         * tui/tui-data.c (tui_source_window_base): Initialize
1449         execution_info.
1450
1451 2019-07-17  Tom Tromey  <tom@tromey.com>
1452
1453         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1454         variable.
1455
1456 2019-07-17  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui.c (tui_rl_other_window): Update.
1459         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1460         superclass method first.  Always iterate over regs_content.
1461         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1462         method.
1463         * tui/tui-win.c (tui_set_focus_command): Update.
1464
1465 2019-07-17  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui-win.c (tui_set_focus_command): Rename from
1468         tui_set_focus.  Call tui_enable.
1469         (tui_set_focus_command): Remove.
1470
1471 2019-07-17  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1474         refresh_window.
1475         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1476         touchwin.
1477         (tui_data_window::refresh_window): Call refresh_window on data
1478         items.  Always call superclass refresh_window.
1479         (tui_win_info::refresh): Remove.
1480         (tui_source_window_base::refresh_window): Update.
1481         (tui_refresh_all): Update.
1482         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1483         refresh_window.
1484         (show_source_or_disasm_and_command): Likewise.
1485         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1486         (struct tui_source_window_base) <refresh>: Likewise.
1487
1488 2019-07-17  Tom Tromey  <tom@tromey.com>
1489
1490         * tui/tui-winsource.c (tui_clear_source_content)
1491         (tui_show_source_content): Update.
1492         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1493         whether content is empty.
1494         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1495         Remove.
1496
1497 2019-07-17  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1500         window's contents.
1501         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1502         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1503
1504 2019-07-17  Tom Tromey  <tom@tromey.com>
1505
1506         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1507         (struct tui_data_item_window): Update.
1508
1509 2019-07-17  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1512         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1513         defines.
1514
1515 2019-07-17  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-winsource.h (tui_erase_source_content)
1518         (tui_clear_source_content): Remove "display_prompt" parameter.
1519         * tui/tui-winsource.c (tui_update_source_window_as_is)
1520         (tui_update_source_windows_with_addr): Update.
1521         (tui_clear_source_content): Remove "display_prompt" parameter.
1522         (tui_erase_source_content): Likewise.  Simplify.
1523         (tui_show_source_content): Update.
1524         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1525         * tui/tui-stack.c (tui_show_frame_info): Update.
1526         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1527         Remove defines.
1528
1529 2019-07-17  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1532         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1533         parameter.
1534         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1535         parameter.
1536
1537 2019-07-17  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-winsource.c (tui_clear_source_content)
1540         (tui_show_source_content, tui_show_exec_info_content)
1541         (tui_clear_exec_info_content): Update.
1542         * tui/tui-stack.c (tui_show_locator_content): Update.
1543         (tui_show_frame_info): Update.
1544         * tui/tui-source.h (tui_source_window): Don't declare.
1545         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1546         from tui_source_is_displayed.
1547         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1548         Remove field.
1549         (struct tui_source_window_base) <content_in_use>: New field.  Now
1550         bool.
1551         (struct tui_source_window) <showing_source_p>: New method.
1552         (TUI_SRC_WIN): Change cast.
1553         * tui/tui-data.c (tui_initialize_static_data): Update.
1554
1555 2019-07-17  Tom Tromey  <tom@tromey.com>
1556
1557         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1558         location_matches_p.
1559         * tui/tui-source.c (tui_source_window::location_matches_p): New
1560         method.
1561         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1562         method.
1563         * tui/tui-data.h (struct tui_source_window_base)
1564         <location_matches_p>: New method.
1565         (struct tui_source_window, struct tui_disasm_window)
1566         <location_matches_p>: Likewise.
1567
1568 2019-07-17  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-win.c (tui_set_win_height_command): Rename from
1571         tui_set_win_height.
1572         (tui_set_win_height_command): Remove.
1573
1574 2019-07-17  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-source.c (tui_source_window): New constructor.  Add
1577         observer.
1578         (~tui_source_window): New destructor.
1579         (tui_source_window::style_changed): New method.
1580         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1581         (tui_attach_detach_observers): Update.
1582         * tui/tui-data.h (struct tui_source_window): Make constructor not
1583         inline.  Add destructor.
1584         (struct tui_source_window) <style_changed>: New method.
1585         <m_observable>: New member.
1586
1587 2019-07-17  Tom Tromey  <tom@tromey.com>
1588
1589         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1590         * tui/tui-win.c (tui_resize_all): Fix typo.
1591
1592 2019-07-17  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1595         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1596         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1597         * tui/tui-win.c (window_name_completer): Use foreach.
1598         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1599         (update_tab_width): Likewise.
1600         * tui/tui-layout.c (show_layout): Update.
1601         * tui/tui-data.h (class tui_window_iterator): New.
1602         (struct all_tui_windows): New.
1603         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1604
1605 2019-07-17  Tom Tromey  <tom@tromey.com>
1606
1607         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1608         parameter.  Don't reference globals.
1609         (tui_reg_command): Update.
1610
1611 2019-07-17  Tom Tromey  <tom@tromey.com>
1612
1613         * tui/tui-regs.c (tui_show_registers): Simplify.
1614
1615 2019-07-17  Tom Tromey  <tom@tromey.com>
1616
1617         * tui/tui-regs.c (tui_show_registers): Update.
1618         (tui_show_register_group): Add win_info parameter.
1619
1620 2019-07-17  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1623         Rename from tui_display_reg_element_at_line.
1624         (tui_data_window::display_registers_from_line): Update.
1625         * tui/tui-data.h (struct tui_data_window)
1626         <display_reg_element_at_line>: New method.
1627
1628 2019-07-17  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui-regs.h (tui_display_registers_from)
1631         (tui_display_registers_from_line): Don't declare.
1632         * tui/tui-windata.c (tui_data_window::display_all_data)
1633         (tui_data_window::refresh_all)
1634         (tui_data_window::do_scroll_vertical): Update.
1635         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1636         from tui_display_registers_from.
1637         (tui_display_reg_element_at_line): Update.
1638         (tui_data_window::display_registers_from_line): Rename from
1639         tui_display_registers_from_line.
1640         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1641         display_registers_from_line>: New methods.
1642
1643 2019-07-17  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1646         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1647         from tui_erase_data_content.
1648         (tui_data_window::display_all_data)
1649         (tui_data_window::refresh_all)
1650         (tui_data_window::do_scroll_vertical): Update.
1651         * tui/tui-regs.c (tui_show_registers): Update.
1652         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1653         New method.
1654
1655 2019-07-17  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1658         declare.
1659         * tui/tui-windata.c
1660         (tui_data_window::delete_data_content_windows): Rename from
1661         tui_delete_data_content_windows.
1662         (tui_data_window::display_all_data)
1663         (tui_data_window::do_scroll_vertical): Update.
1664         * tui/tui-data.h (struct tui_data_window)
1665         <delete_data_content_windows>: New method.
1666
1667 2019-07-17  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1670         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1671
1672 2019-07-17  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1675         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1676         from tui_display_all_data.
1677         * tui/tui-win.c
1678         (tui_data_window::do_make_visible_with_new_height): Update.
1679         * tui/tui-regs.c (tui_show_registers): Update.
1680         * tui/tui-layout.c (tui_set_layout): Update.
1681         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1682         method.
1683
1684 2019-07-17  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1687         * tui/tui-windata.c (tui_display_data_from): Remove.
1688         (tui_data_window::refresh_all): Update.
1689
1690 2019-07-17  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1693         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1694         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1695         tui_display_registers_from_line.
1696         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1697         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1698         "force_display" parameter.
1699
1700 2019-07-17  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1703         declare.
1704         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1705         Rename from tui_first_reg_element_no_inline.
1706         (tui_display_reg_element_at_line)
1707         (tui_display_registers_from_line): Update.
1708         * tui/tui-data.h (struct tui_data_window)
1709         <first_reg_element_no_inline>: New method.
1710
1711 2019-07-17  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-windata.c (tui_display_data_from)
1714         (tui_data_window::do_scroll_vertical): Update.
1715         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1716         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1717         Rename from tui_line_from_reg_element_no.
1718         (tui_display_registers_from_line): Update.
1719         * tui/tui-data.h (struct tui_data_window)
1720         <line_from_reg_element_no>: New method.
1721
1722 2019-07-17  Tom Tromey  <tom@tromey.com>
1723
1724         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1725         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1726         tui_last_regs_line_no.
1727         (tui_display_reg_element_at_line)
1728         (tui_display_registers_from_line): Update.
1729         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1730         method.
1731
1732 2019-07-17  Tom Tromey  <tom@tromey.com>
1733
1734         PR tui/24722:
1735         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1736         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1737         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1738         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1739         (tui_update_breakpoint_info): Likewise.
1740         * tui/tui-hooks.c (tui_event_create_breakpoint)
1741         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1742         Update.
1743
1744 2019-07-17  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1747
1748 2019-07-17  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-winsource.c (tui_update_source_window_as_is)
1751         (tui_update_source_windows_with_addr): Update.
1752         * tui/tui-source.h (tui_set_source_content)
1753         (tui_show_symtab_source): Add "win_info" parameter.
1754         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1755         parameter.
1756         (tui_show_symtab_source): Likewise.
1757
1758 2019-07-17  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-wingeneral.c
1761         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1762
1763 2019-07-17  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1766         (struct tui_cmd_window) <can_scroll>: New method.
1767         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1768         method.
1769
1770 2019-07-17  Tom Tromey  <tromey@adacore.com>
1771
1772         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1773         do_field_signed>: Rename.  Change type of "value".
1774         * ui-out.c (ui_out::field_signed): Rename from field_int.
1775         Change type of "value".
1776         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1777         type of "value".
1778         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1779         do_field_int.  Change type of "value".
1780         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1781         do_field_int.  Change type of "value".
1782         * tracepoint.c (trace_status_mi, tfind_1)
1783         (print_one_static_tracepoint_marker): Update.
1784         * thread.c (print_thread_info_1, print_selected_thread_frame):
1785         Update.
1786         * stack.c (print_frame, print_frame_info): Update.
1787         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1788         Update.
1789         * source.c (print_source_lines_base): Update.
1790         * skip.c (info_skip_command): Update.
1791         * record-btrace.c (btrace_ui_out_decode_error)
1792         (btrace_call_history_src_line): Update.
1793         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1794         Update.
1795         * progspace.c (print_program_space): Update.
1796         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1797         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1798         do_field_int.  Change type of "value".
1799         * mi/mi-out.c (mi_ui_out::do_table_begin)
1800         (mi_ui_out::do_table_header): Update.
1801         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1802         type of "value".
1803         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1804         (mi_cmd_data_list_changed_registers, output_register)
1805         (mi_cmd_data_read_memory, mi_load_progress)
1806         (mi_cmd_trace_frame_collected): Update.
1807         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1808         Update.
1809         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1810         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1811         (mi_cmd_var_list_children, varobj_update_one): Update.
1812         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1813         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1814         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1815         * inferior.c (print_inferior): Update.
1816         * gdb_bfd.c (print_one_bfd): Update.
1817         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1818         Update.
1819         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1820         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1821         do_field_int.  Change type of "value".
1822         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1823         do_field_int.  Change type of "value".
1824         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1825         (print_one_breakpoint_location, print_it_catch_fork)
1826         (print_one_catch_fork, print_it_catch_vfork)
1827         (print_one_catch_vfork, print_it_catch_solib)
1828         (print_it_catch_exec, print_it_ranged_breakpoint)
1829         (print_mention_watchpoint, print_mention_masked_watchpoint)
1830         (bkpt_print_it, update_static_tracepoint): Update.
1831         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1832         * break-catch-syscall.c (print_it_catch_syscall): Update.
1833         * ada-tasks.c (print_ada_task_info): Update.
1834         * ada-lang.c (print_it_exception, print_mention_exception):
1835         Update.
1836
1837 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1838
1839         PR breakpoints/24541
1840         * gdbarch.c: Regenerate.
1841         * gdbarch.h: Regenerate.
1842         * gdbarch.sh: Adjust return type and parameter types for
1843         'stap_adjust_register'.
1844         (i386_stap_adjust_register): Adjust signature and return new
1845         register name.
1846         * stap-probe.c (stap_parse_register_operand): Adjust use of
1847         'gdbarch_stap_adjust_register'.
1848
1849 2019-07-17  Tom Tromey  <tromey@adacore.com>
1850
1851         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1852         declare VEC.
1853         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1854         std::vector.
1855         (struct s390_process_info): Add initializers.
1856         (s390_add_process): Use new.
1857         (s390_linux_nat_target::low_forget_process): Use delete.
1858         (s390_linux_nat_target::low_new_fork)
1859         (s390_linux_nat_target::stopped_by_watchpoint)
1860         (s390_linux_nat_target::low_prepare_to_resume)
1861         (s390_linux_nat_target::insert_watchpoint)
1862         (s390_linux_nat_target::insert_hw_breakpoint)
1863         (s390_linux_nat_target::remove_watchpoint)
1864         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1865
1866 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1867
1868         * aarch64-fbsd-nat.c: Include regcache.h.
1869         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1870         argument.
1871         (aarch64_fbsd_nat_target::fetch_registers)
1872         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1873         variable.
1874         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1875
1876 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1877
1878         * fbsd-nat.c: Include gdbarch.h.
1879
1880 2019-07-15  Tom Tromey  <tromey@adacore.com>
1881
1882         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1883
1884 2019-07-15  Tom Tromey  <tromey@adacore.com>
1885
1886         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1887         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1888         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1889         * cli-out.c (cli_ui_out::do_field_int): New method.
1890         * ui-out.c (ui_out::field_unsigned): New method.
1891         * symfile.c (generic_load): Use field_unsigned.
1892         (print_transfer_performance): Likewise.
1893         * record-btrace.c (ui_out_field_uint): Remove.
1894         (btrace_call_history_insn_range, btrace_call_history): Use
1895         field_unsigned.
1896         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1897         field_unsigned.
1898         * ui-out.h (class ui_out) <field_unsigned>: New method.
1899         <do_field_unsigned>: Likewise.
1900
1901 2019-07-15  Tom Tromey  <tromey@adacore.com>
1902
1903         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1904         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1905         * target.c (flash_erase_command): Use field_string.
1906         * infrun.c (print_signal_received_reason): Use field_string.
1907         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1908         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1909         field_string.
1910         * ada-tasks.c (print_ada_task_info): Use field_string.
1911
1912 2019-07-15  Tom Tromey  <tromey@adacore.com>
1913
1914         * target.c (flash_erase_command): Use field_core_addr.
1915         * symfile.c (generic_load): Use field_core_addr.
1916         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1917         Use field_core_addr.
1918         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1919         field_core_addr.
1920
1921 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1922
1923         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1924         value if its desired type is smaller than a CORE_ADDR and signed.
1925
1926 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1927
1928         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1929         of changes to field names, and use new is_reference field to
1930         decide if a property is a reference or not.
1931         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1932         field.
1933         (struct dwarf2_property_baton): Update header comment, rename
1934         'referenced_type' to 'property_type' and update comments.
1935         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1936         default property type, store in property baton, update to take
1937         accound of renamed field.
1938         (read_func_scope): Update call to attr_to_dynamic_prop.
1939         (read_array_type): Likewise.
1940         (dwarf2_per_cu_addr_sized_int_type): New function.
1941         (read_subrange_index_type): Move type finding code to
1942         dwarf2_per_cu_addr_sized_int_type.
1943         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1944         (dwarf2_per_cu_addr_type): New function.
1945         (set_die_type): Update calls to attr_to_dynamic_prop.
1946
1947 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1948
1949         * dwarf2read.c (read_subrange_index_type): New function.
1950         (read_subrange_type): Move code into new function and call it.
1951         * gdbtypes.c (create_range_type): Add some asserts.
1952
1953 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1954
1955         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1956         update return statements.
1957         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1958         declaration, and update comment to match.
1959         * gdbtypes.c (resolve_dynamic_array): Update call to
1960         dwarf2_evaluate_property to match new return type.
1961
1962 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1963
1964         * valarith.c (value_subscripted_rvalue): Change lowerbound
1965         parameter type from int to LONGEST.
1966         * value.h (value_subscripted_rvalue): Likewise in declaration.
1967
1968 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1969
1970         * cli/cli-utils.c (info_print_command_completer): New function.
1971         * cli/cli-utils.h: Add 'completer.h' include, and forward
1972         declaration for 'struct cmd_list_element'.
1973         (info_print_command_completer): Declare.
1974         * stack.c (_initialize_stack): Add completer for 'info locals' and
1975         'info args'.
1976         * symtab.c (_initialize_symtab): Add completer for 'info
1977         variables' and 'info functions'.
1978         * NEWS: Mention completion for additional info commands.
1979
1980 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1981
1982         * cli/cli-utils.c (extract_info_print_args): Delete.
1983         (extract_arg_maybe_quoted): Delete.
1984         (info_print_options_defs): New variable.
1985         (make_info_print_options_def_group): New function.
1986         (extract_info_print_options): Define new function.
1987         * cli/cli-utils.h (extract_info_print_args): Delete.
1988         (struct info_print_options): New structure.
1989         (extract_info_print_options): Declare new function.
1990         * stack.c (info_locals_command): Update to use new
1991         extract_info_print_options, also add a header comment.
1992         (info_args_command): Likewise.
1993         * symtab.c (info_variables_command): Likewise.
1994         (info_functions_command): Likewise.
1995
1996 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1997
1998         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1999         to extract string arguments.
2000         * common/common-utils.c (extract_string_maybe_quoted): New function.
2001         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2002
2003 2019-07-11  Tom Tromey  <tromey@adacore.com>
2004
2005         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2006         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2007         * top.h (gdbinit): Don't declare.
2008         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2009         into...
2010         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2011         * top.c (gdb_init): Don't call init_cli_cmds.
2012         (gdbinit): Remove.
2013         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2014
2015 2019-07-11  Tom Tromey  <tromey@adacore.com>
2016
2017         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2018         after it has been moved.
2019
2020 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2021
2022         * valops.c (value_must_coerce_to_target): Change return type to
2023         bool.
2024         * value.h (value_must_coerce_to_target): Likewise.
2025
2026 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2027
2028         * breakpoint.c (is_hardware_watchpoint): Remove
2029         forward-declaration.
2030         (is_masked_watchpoint): Change return type to bool.
2031         (is_tracepoint): Likewise.
2032         (is_breakpoint): Likewise.
2033         (is_hardware_watchpoint): Likewise.
2034         (is_watchpoint): Likewise.
2035         (is_no_memory_software_watchpoint): Likewise.
2036         (is_catchpoint): Likewise.
2037         (breakpoint_1): Make FILTER parameter's return type bool.
2038         is_masked_watchpoint): Change return type to bool.
2039         (save_breakpoints): Make FILTER parameter's return type bool.
2040         * breakpoint.h (is_breakpoint): Change return type to bool.
2041         (is_watchpoint): Likewise.
2042         (is_catchpoint): Likewise.
2043         (is_tracepoint): Likewise.
2044
2045 2019-07-10  Tom Tromey  <tom@tromey.com>
2046
2047         * defs.h: Don't include gdbarch.h.
2048         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2049         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2050         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2051         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2052         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2053         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2054         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2055         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2056         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2057         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2058         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2059         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2060         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2061         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2062         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2063         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2064         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2065         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2066         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2067         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2068         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2069         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2070         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2071         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2072         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2073         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2074         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2075
2076 2019-07-10  Tom Tromey  <tromey@adacore.com>
2077
2078         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2079         * breakpoint.c (init_ada_exception_breakpoint): Register as
2080         bp_catchpoint.
2081         (print_one_breakpoint_location, print_one_breakpoint): Use
2082         is_ada_exception_catchpoint.
2083         * ada-lang.c (class ada_catchpoint_location): Pass
2084         bp_loc_software_breakpoint to bp_location constructor.
2085         (is_ada_exception_catchpoint): New function.
2086
2087 2019-07-10  Tom Tromey  <tromey@adacore.com>
2088
2089         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2090         VEC.
2091         (struct arm_exidx_entry): New method operator<.
2092         (struct arm_exidx_data) <section_maps>: Change type.
2093         (arm_exidx_data_free): Remove.
2094         (arm_exidx_data_key): Change type.  Move lower.
2095         (arm_exidx_new_objfile): Update.
2096         (arm_compare_exidx_entries): Remove.
2097         (arm_find_exidx_entry, _initialize_arm_tdep)
2098
2099 2019-07-10  Tom Tromey  <tromey@adacore.com>
2100
2101         * solib-spu.c (ocl_program_data_key): Change type.
2102         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2103         Update.
2104
2105 2019-07-10  Tom Tromey  <tromey@adacore.com>
2106
2107         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2108         (struct solib_aix_inferior_data) <library_list>: Change type.
2109         (solib_aix_inferior_data_handle): Change type.
2110         (get_solib_aix_inferior_data): Update.
2111         (solib_aix_free_library_list): Remove.
2112         (library_list_start_library): Update.
2113         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2114         return type.
2115         (solib_aix_get_library_list)
2116         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2117         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2118
2119 2019-07-10  Tom Tromey  <tromey@adacore.com>
2120
2121         * solib-dsbt.c (struct dsbt_info): Add initializers.
2122         (solib_dsbt_pspace_data): Change type.
2123         (dsbt_pspace_data_cleanup): Remove.
2124         (get_dsbt_info, _initialize_dsbt_solib): Update.
2125
2126 2019-07-10  Tom Tromey  <tromey@adacore.com>
2127
2128         * spu-tdep.c (spu_overlay_data): Change type.
2129         (spu_get_overlay_table, spu_overlay_new_objfile)
2130         (_initialize_spu_tdep): Update.
2131
2132 2019-07-10  Tom Tromey  <tromey@adacore.com>
2133
2134         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2135         destructor.
2136         (dbx_objfile_data_key): Change type and declare later.
2137         (DBX_SYMFILE_INFO): Rewrite.
2138         * dbxread.c (dbx_objfile_data_key): Change type.
2139         (dbx_symfile_init): Update.
2140         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2141         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2142         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2143
2144 2019-07-10  Tom Tromey  <tromey@adacore.com>
2145
2146         * jit.c (jit_program_space_key): Change type.  Move lower.
2147         (get_jit_program_space_data): Update.
2148         (jit_program_space_data_cleanup): Remove.
2149         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2150         Update.
2151         (struct jit_program_space_data): Add initializers.
2152
2153 2019-07-10  Tom Tromey  <tromey@adacore.com>
2154
2155         * solib-darwin.c (struct darwin_info): Add initializers.
2156         (solib_darwin_pspace_data): Change type.
2157         (darwin_pspace_data_cleanup): Remove.
2158         (get_darwin_info, _initialize_darwin_solib): Update.
2159
2160 2019-07-10  Tom Tromey  <tromey@adacore.com>
2161
2162         * remote-sim.c (struct sim_inferior_data): Add initializers,
2163         constructor, and destructor.
2164         (sim_inferior_data_key): Change type.  Move lower.
2165         (check_for_duplicate_sim_descriptor): Update.
2166         (get_sim_inferior_data): Use new.  Update.
2167         (~sim_inferior_data_cleanup): Rename from
2168         sim_inferior_data_cleanup.  Simplify.
2169         (gdbsim_close_inferior, simulator_command)
2170         (sim_command_completer, _initialize_remote_sim): Update.
2171         (next_pid, INITIAL_PID): Move earlier.
2172
2173 2019-07-10  Tom Tromey  <tromey@adacore.com>
2174
2175         * python/python-internal.h (create_thread_object): Return
2176         gdbpy_ref.
2177         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2178         * python/py-inferior.c (struct threadlist_entry): Add
2179         constructor.
2180         <thread_obj>: Now a gdbpy_ref.
2181         (thread_to_thread_object): Update.
2182         (add_thread_object): Use new.
2183         (delete_thread_object): Use delete.
2184         (infpy_threads): Update.
2185         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2186         GIL.
2187
2188 2019-07-10  Tom Tromey  <tromey@adacore.com>
2189
2190         * valops.c (value_cast): Specialize error message for Ada.
2191
2192 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2193
2194         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2195
2196 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2197
2198         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2199         bpstat_should_step): Return bool, adjust comments.
2200         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2201         bpstat_should_step): Likewise.
2202
2203 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2204
2205         * features/Makefile: Use feature target descriptions for Arm.
2206         * features/arm/arm-core.c: Generate new file.
2207         * features/arm/arm-fpa.c: Likewise.
2208         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2209         * features/arm/arm-m-profile.c: Likewise.
2210         * features/arm/arm-vfpv2.c: Likewise.
2211         * features/arm/arm-vfpv3.c: Likewise.
2212         * features/arm/xscale-iwmmxt.c: Likewise.
2213         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2214
2215 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2216
2217         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2218         ptrace earlier.
2219
2220 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2221
2222         * features/aarch64-pauth.c: Regenerate.
2223
2224 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2225
2226         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2227         bool.
2228         (bpstat_what): Use false instead of 0.
2229
2230 2019-07-09  Pedro Alves  <palves@redhat.com>
2231
2232         * break-catch-throw.c (is_exception_catchpoint): New.
2233         * breakpoint.c (print_one_breakpoint_location): New parameter
2234         'raw_loc'.  Handle it.  Use
2235         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2236         looking at the breakpoint's type.
2237         (print_one_breakpoint): If handling "maint info breakpoints", also
2238         print locations of exception catchpoints.
2239         * breakpoint.h (is_exception_catchpoint): Declare.
2240
2241 2019-07-09  Pedro Alves  <palves@redhat.com>
2242
2243         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2244         "addr" field.
2245         (allocate_location_exception_catchpoint): New.
2246         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2247         (initialize_throw_catchpoint_ops): Install
2248         allocate_location_exception_catchpoint as allocate_location
2249         method.
2250         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2251         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2252         bp_loc_other.
2253         (breakpoint_address_is_meaningful): Delete.
2254         (bl_address_is_meaningful): New.
2255         (breakpoint_locations_match): Adjust comment.
2256         (bp_location_from_bp_type): New, factored out of...
2257         (bp_location::bp_location(breakpoint *)): ... this.
2258         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2259         factored out of...
2260         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2261         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2262         breakpoint_address_is_meaningful.
2263         (bp_locations_compare): Adjust comment.
2264         (update_global_location_list): Use bl_address_is_meaningful
2265         instead of breakpoint_address_is_meaningful.
2266         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2267         explicit.
2268         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2269         * python/py-breakpoint.c (bppy_get_location): No longer check
2270         whether location is null.
2271
2272 2019-07-09  Pedro Alves  <palves@redhat.com>
2273
2274         PR c++/15468
2275         * breakpoint.c (print_one_breakpoint_location): Remove
2276         single-location assert.
2277
2278 2019-07-09  Tom Tromey  <tom@tromey.com>
2279
2280         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2281         * configure: Rebuild.
2282         * configure.ac: Change common to gdbsupport.
2283         * gdbsupport: Rename from common.
2284         * acinclude.m4: Change common to gdbsupport.
2285         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2286         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2287         gdbsupport.
2288         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2289         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2290         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2291         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2292         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2293         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2294         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2295         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2296         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2297         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2298         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2299         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2300         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2301         coff-pe-read.c, command.h, compile/compile-c-support.c,
2302         compile/compile-c.h, compile/compile-cplus-symbols.c,
2303         compile/compile-cplus-types.c, compile/compile-cplus.h,
2304         compile/compile-loc2c.c, compile/compile.c, completer.c,
2305         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2306         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2307         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2308         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2309         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2310         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2311         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2312         features/aarch64-core.c, features/aarch64-fpu.c,
2313         features/aarch64-pauth.c, features/aarch64-sve.c,
2314         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2315         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2316         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2317         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2318         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2319         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2320         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2321         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2322         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2323         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2324         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2325         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2326         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2327         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2328         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2329         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2330         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2331         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2332         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2333         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2334         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2335         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2336         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2337         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2338         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2339         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2340         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2341         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2342         minsyms.c, mips-linux-tdep.c, namespace.h,
2343         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2344         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2345         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2346         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2347         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2348         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2349         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2350         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2351         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2352         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2353         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2354         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2355         procfs.c, producer.c, progspace.h, psymtab.h,
2356         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2357         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2358         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2359         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2360         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2361         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2362         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2363         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2364         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2365         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2366         target-memory.c, target.c, target.h, target/waitstatus.c,
2367         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2368         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2369         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2370         unittests/array-view-selftests.c,
2371         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2372         unittests/common-utils-selftests.c,
2373         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2374         unittests/format_pieces-selftests.c,
2375         unittests/function-view-selftests.c,
2376         unittests/lookup_name_info-selftests.c,
2377         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2378         unittests/mkdir-recursive-selftests.c,
2379         unittests/observable-selftests.c,
2380         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2381         unittests/parse-connection-spec-selftests.c,
2382         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2383         unittests/scoped_fd-selftests.c,
2384         unittests/scoped_mmap-selftests.c,
2385         unittests/scoped_restore-selftests.c,
2386         unittests/string_view-selftests.c, unittests/style-selftests.c,
2387         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2388         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2389         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2390         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2391         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2392         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2393
2394 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2395
2396         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2397         bool value.
2398         (decode_digits_ordinary): Set explicit_line field in sal.
2399         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2400         symtab_and_line that was set on an explicit line number in
2401         assembler code.  Do always update the recorded symtab and line if
2402         we do skip the prologue.
2403
2404 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2405
2406         * breakpoint.c (set_breakpoint_location_function): Remove
2407         explicit_loc parameter.
2408         (momentary_breakpoint_from_master): Update call to
2409         set_breakpoint_location_function.
2410         (add_location_to_breakpoint): Likewise.
2411
2412 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2413
2414         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2415         required features based on default bfd type when no specific bfd
2416         is present.
2417
2418 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2419
2420         * NEWS: Mention that GDB printf and eval commands can now print
2421         C-style and Ada-style convenience var strings without
2422         calling the inferior.
2423         * printcmd.c (printf_c_string): Locally print GDB internal var
2424         instead of transiting via the inferior.
2425         (printf_wide_c_string): Likewise.
2426
2427 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2428
2429         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2430
2431 2019-07-04  Tom Tromey  <tom@tromey.com>
2432
2433         PR tui/24724:
2434         * tui/tui-winsource.c (tui_clear_source_content): Update.
2435         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2436         (tui_update_breakpoint_info): Update.
2437         (tui_set_exec_info_content): Update.
2438         * tui/tui-source.c (tui_set_source_content_nil): Update.
2439         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2440         has_break.
2441         * tui/tui-data.h (enum tui_bp_flag): New.
2442         (tui_bp_flags): New enum flags type.
2443         (struct tui_source_element) <break_mode>: Change type.  Rename
2444         from has_break.
2445         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2446         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2447         constants.
2448         * tui/tui-winsource.h: Fix comment.
2449
2450 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2451
2452         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2453         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2454         (store_fpregs_to_thread)
2455         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2456         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2457         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2458         (IWMMXT_REGS_SIZE): Add define.
2459         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2460         (fetch_vfp_regs, store_vfp_regs)
2461         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2462         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2463
2464 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2465
2466         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2467         defines.
2468         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2469         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2470         (ARM_INT_REGISTER_SIZE): ...to this.
2471         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2472         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2473         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2474         (arm_linux_collect_gregset, supply_nwfpe_register)
2475         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2476         defines.
2477         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2478         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2479         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2480         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2481         (arm_return_in_memory, arm_store_return_value)
2482         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2483         (arm_record_ld_st_multiple): Likewise.
2484         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2485         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2486
2487 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2488
2489         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2490         AARCH64_DISPLACED_MODIFIED_INSNS.
2491         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2492         (aarch64_displaced_step_copy_insn): Likewise.
2493         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2494         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2495         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2496         ARM_DISPLACED_MODIFIED_INSNS.
2497         * arm-tdep.c (arm_gdbarch_init): Likewise.
2498         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2499         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2500         (struct arm_displaced_step_closure): Use
2501         ARM_DISPLACED_MODIFIED_INSNS.
2502
2503 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2504
2505         * features/Makefile: Remove unused xml files.
2506         * features/aarch64.xml: Remove.
2507         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2508         * features/i386/amd64-avx-avx512.xml: Remove.
2509         * features/i386/amd64-avx-linux.xml: Remove.
2510         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2511         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2512         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2513         * features/i386/amd64-avx-mpx.xml: Remove.
2514         * features/i386/amd64-avx.xml: Remove.
2515         * features/i386/amd64-linux.xml: Remove.
2516         * features/i386/amd64-mpx-linux.xml: Remove.
2517         * features/i386/amd64-mpx.xml: Remove.
2518         * features/i386/amd64.xml: Remove.
2519         * features/i386/i386-avx-avx512-linux.xml: Remove.
2520         * features/i386/i386-avx-avx512.xml: Remove.
2521         * features/i386/i386-avx-linux.xml: Remove.
2522         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2523         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2524         * features/i386/i386-avx-mpx-linux.xml: Remove.
2525         * features/i386/i386-avx-mpx.xml: Remove.
2526         * features/i386/i386-avx.xml: Remove.
2527         * features/i386/i386-linux.xml: Remove.
2528         * features/i386/i386-mmx-linux.xml: Remove.
2529         * features/i386/i386-mmx.xml: Remove.
2530         * features/i386/i386-mpx-linux.xml: Remove.
2531         * features/i386/i386-mpx.xml: Remove.
2532         * features/i386/i386.xml: Remove.
2533         * features/i386/x32-avx-avx512-linux.xml: Remove.
2534         * features/i386/x32-avx-linux.xml: Remove.
2535         * features/i386/x32-linux.xml: Remove.
2536
2537 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2538
2539         * regformats/aarch64.dat: Remove.
2540         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2541         * regformats/i386/amd64-avx-linux.dat: Remove.
2542         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2543         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2544         * regformats/i386/amd64-linux.dat: Remove.
2545         * regformats/i386/amd64-mpx-linux.dat: Remove.
2546         * regformats/i386/amd64.dat: Remove.
2547         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2548         * regformats/i386/i386-avx-linux.dat: Remove.
2549         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2550         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2551         * regformats/i386/i386-linux.dat: Remove.
2552         * regformats/i386/i386-mmx-linux.dat: Remove.
2553         * regformats/i386/i386-mpx-linux.dat: Remove.
2554         * regformats/i386/i386.dat: Remove.
2555         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2556         * regformats/i386/x32-avx-linux.dat: Remove.
2557         * regformats/i386/x32-linux.dat: Remove.
2558
2559 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2560
2561         * aarch64-tdep.c: Remove xml self tests.
2562         * amd64-linux-tdep.c: Likewise.
2563         * amd64-tdep.c: Likewise.
2564         * i386-linux-tdep.c: Likewise.
2565         * i386-tdep.c: Likewise.
2566
2567 2019-07-03  Pedro Alves  <palves@redhat.com>
2568
2569         PR cli/24732
2570         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2571         (pipe_cmd_option_defs): New.
2572         (make_pipe_cmd_options_def_group): New.
2573         (pipe_command): Use gdb::option::process_options.
2574         (pipe_command_completer): New function.
2575         (_initialize_cli_cmds): Install completer for "pipe" command.
2576
2577 2019-07-03  Pedro Alves  <palves@redhat.com>
2578
2579         * cli/cli-option.c (union option_value) <string>: New field.
2580         (struct option_def_and_value): Add ctor, move ctor, dtor and
2581         use DISABLE_COPY_AND_ASSIGN.
2582         (option_def_and_value::clear_value): New.
2583         (parse_option, save_option_value_in_ctx, get_val_type_str)
2584         (add_setshow_cmds_for_options): Handle var_string.
2585         * cli-option.h (union option_def::var_address) <string>: New
2586         field.
2587         (struct string_option_def): New.
2588         * maint-test-options.c (struct test_options_opts): Add default
2589         ctor and use DISABLE_COPY_AND_ASSIGN.
2590         <string_opt>: New field.
2591         (test_options_opts::~test_options_opts): New.
2592         (test_options_opts::dump): Also dump "-string".
2593         (test_options_option_defs): Install "string.
2594
2595 2019-07-03  Pedro Alves  <palves@redhat.com>
2596
2597         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2598         option_value with a null enumeration.
2599         (complete_options): Save the option values in the context.
2600         (save_option_value_in_ctx): New, factored out from ...
2601         (process_options): ... here.
2602         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2603         of the function.
2604         * maint-test-options.c (test_options_opts::dump): New, factored
2605         out from ...
2606         (maintenance_test_options_command_mode): ... here.
2607         (maintenance_test_options_command_completion_result): Delete.
2608         (maintenance_test_options_command_completion_text): Update
2609         comment.
2610         (maintenance_show_test_options_completion_result): Change
2611         prototype.  Just print
2612         maintenance_test_options_command_completion_text.
2613         (save_completion_result): New.
2614         (maintenance_test_options_completer_mode): Pass options context to
2615         complete_options, and then save a dump.
2616         (_initialize_maint_test_options): Use add_cmd to install "maint
2617         show test-options-completion-result".
2618
2619 2019-07-03  Pedro Alves  <palves@redhat.com>
2620
2621         * NEWS (New commands): Mention "with" and "maint with".
2622         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2623         (with_command, with_command_completer): New.
2624         (pipe_command): Adjust to new repeat_previous
2625         interface.
2626         (_initialize_cli_cmds): Install the "with" command and its "w"
2627         alias.
2628         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2629         declarations.
2630         * cli/cli-setshow.c (parse_cli_var_uinteger)
2631         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2632         argument strings for all var_types.
2633         (get_setshow_command_value_string): New, factored out from ...
2634         (do_show_command): ... this.
2635         * cli/cli-setshow.h: Include <string>.
2636         (get_setshow_command_value_string): Declare.
2637         * command.h (repeat_previous): Now returns const char *.  Adjust
2638         comment.
2639         * maint.c: Include "cli/cli-cmds.h".
2640         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2641         (_initialize_maint_cmds): Register the "maintenance with" command.
2642         * top.c (repeat_previous): Move bits from pipe_command here:
2643         Return the saved command line, if any; error out if there's no
2644         command to relaunch.
2645
2646 2019-07-03  Pedro Alves  <palves@redhat.com>
2647
2648         * NEWS (New commands): Mention "maint set/show test-settings"
2649         instead of "maint test-settings".
2650         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2651         (maintenance_test_settings_set_list): Rename to ...
2652         (maintenance_set_test_settings_list): ... this.
2653         (maintenance_test_settings_show_list): Rename to  ...
2654         (maintenance_show_test_settings_list): ... this.
2655         (maintenance_test_settings_cmd): Delete.
2656         (maintenance_test_settings_set_cmd): ...
2657         (maintenance_set_test_settings_cmd): ... this.
2658         (maintenance_test_settings_show_cmd): ...
2659         (maintenance_show_test_settings_cmd): ... this.
2660         (maintenance_test_settings_show_value_cmd):
2661         (maintenance_show_test_settings_value_cmd): ... this.
2662         (_initialize_maint_test_settings): No longer install the "maint
2663         test-settings" prefix command.  Rename "maint test-settings set"
2664         to "maint set test-settings", and "maint test-settings show" to
2665         "maint show test-settings".  Adjust all subcommands.
2666
2667 2019-07-03  Pedro Alves  <palves@redhat.com>
2668
2669         * maint-test-settings.c: Fix file's intro comment.  Replace all
2670         references to "test-options" with references to "test-settings",
2671         in comments.
2672
2673 2019-07-03  Pedro Alves  <palves@redhat.com>
2674
2675         * maint-test-settings.c (maintenance_test_settings_xxx)
2676         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2677         New.
2678         (maintenance_test_settings_enums): Use them.
2679         (maintenance_test_settings_enum): Default to
2680         maintenance_test_settings_xxx.
2681         (_initialize_maint_test_settings): Initialize
2682         MAINTENANCE_TEST_SETTINGS_FILENAME.
2683
2684 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2685
2686         * breakpoint.h (remove_breakpoints_inf): Change return type to
2687         void, move function documentation here.
2688         * breakpoint.c (remove_breakpoints_inf): Change return type to
2689         void, move function documentation to header.
2690
2691 2019-07-02  Pedro Alves  <palves@redhat.com>
2692
2693         * NEWS (Completion improvements): Mention "info threads".
2694         * thread.c (struct info_threads_opts, info_threads_option_defs)
2695         (make_info_threads_options_def_group): New.
2696         (info_threads_command): Use gdb::option::process_options.
2697         (info_threads_command_completer): New.
2698         (_initialize_thread): Use gdb::option::build_help to build the
2699         help text for "info threads".
2700
2701 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2702
2703         * defs.h (generic_load): Move from here...
2704         * symfile.h (generic_load): ... to here.  Rename name parameter
2705         to args.
2706         * symfile.c (generic_load): Add comment.
2707
2708 2019-07-01  Tom Tromey  <tromey@adacore.com>
2709
2710         * dwarf2read.c
2711         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2712         declaration of without_params.  Fix formatting.
2713
2714 2019-07-01  Tom Tromey  <tromey@adacore.com>
2715
2716         * ada-exp.y (find_primitive_type): Update.
2717         * ada-lang.h (ada_lookup_symbol): Update.
2718         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2719         parameter.
2720         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2721
2722 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2723
2724         PR breakpoints/24541
2725         * gdbarch.c: Regenerate.
2726         * gdbarch.h: Regenerate.
2727         * gdbarch.sh: Add 'stap_adjust_register'.
2728         * i386-tdep.c: Include '<unordered_set>'.
2729         (i386_stap_adjust_register): New function.
2730         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2731         * stap-probe.c (stap_parse_register_operand): Call
2732         'gdbarch_stap_adjust_register'.
2733
2734 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2735
2736         PR python/24742
2737         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2738         * python/python.c (do_start_initialization): Use 'xmalloc'
2739         instead of 'PyMem_Malloc'.
2740
2741 2019-06-28  Tom Tromey  <tromey@adacore.com>
2742
2743         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2744         for Ada.
2745
2746 2019-06-27  Tom Tromey  <tromey@adacore.com>
2747
2748         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2749         objfile_key.
2750         (arm_find_mapping_symbol, arm_record_special_symbol)
2751         (_initialize_arm_tdep): Update.
2752         (arm_objfile_data_free): Remove.
2753
2754 2019-06-27  Tom Tromey  <tromey@adacore.com>
2755
2756         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2757         to cp_print_static_field.
2758
2759 2019-06-26  Tom Tromey  <tromey@adacore.com>
2760
2761         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2762         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2763         declare.
2764
2765 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2766
2767         * features/aarch64-core.c (create_feature_aarch64_core):
2768         Regenerate.
2769         * features/aarch64-core.xml: Add cpsr flags.
2770
2771 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2772
2773         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2774         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2775
2776 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2777
2778         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2779         field.
2780         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2781         use.
2782         (arm_record_special_symbol): Don't insert new symbol in sorted
2783         position, push it at the end.
2784
2785 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2786
2787         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2788         (arm_mapping_symbol_s): Remove.
2789         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2790         (arm_mapping_symbol_vec): New typedef.
2791         (struct arm_per_objfile): Add constructor.
2792         <section_maps>: Change type to
2793         std::unique_ptr<arm_mapping_symbol_vec[]>.
2794         (arm_compare_mapping_symbols): Remove.
2795         (arm_find_mapping_symbol): Adjust to section_maps type change.
2796         (arm_objfile_data_free): Call delete on arm_per_objfile.
2797         (arm_record_special_symbol): Adjust to section_maps type change.
2798         Allocate arm_per_objfile with new.
2799
2800 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2801
2802         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2803         with the command prefix.
2804
2805 2019-06-25  Tom Tromey  <tom@tromey.com>
2806
2807         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2808         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2809
2810 2019-06-25  Tom Tromey  <tom@tromey.com>
2811
2812         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2813         type.
2814         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2815         protected.
2816
2817 2019-06-25  Tom Tromey  <tom@tromey.com>
2818
2819         * tui/tui-winsource.c
2820         (tui_source_window_base::set_is_exec_point_at): Add check against
2821         LOA_ADDRESS.
2822
2823 2019-06-25  Tom Tromey  <tom@tromey.com>
2824
2825         * tui/tui-source.c (tui_set_source_content): Don't check before
2826         xfree.
2827         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2828
2829 2019-06-25  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui-winsource.h (tui_update_source_window_as_is)
2832         (tui_alloc_source_buffer, tui_line_is_displayed)
2833         (tui_addr_is_displayed): Change type of win_info.
2834         * tui/tui-winsource.c (tui_update_source_window_as_is)
2835         (tui_clear_source_content, tui_show_source_line)
2836         (tui_show_source_content, tui_source_window_base::refill)
2837         (tui_source_window_base::set_is_exec_point_at)
2838         (tui_source_window_base::set_is_exec_point_at)
2839         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2840         (tui_alloc_source_buffer, tui_line_is_displayed)
2841         (tui_addr_is_displayed): Change type of win_info.  Update.
2842         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2843         (tui_source_window_base::do_make_visible_with_new_height):
2844         Update.
2845         * tui/tui-source.c (tui_set_source_content)
2846         (tui_set_source_content_nil)
2847         (tui_source_window::do_scroll_vertical): Update.
2848         * tui/tui-layout.c (show_layout): Update.
2849         * tui/tui-disasm.c (tui_set_disassem_content)
2850         (tui_disasm_window::do_scroll_vertical): Update.
2851         * tui/tui-data.h (tui_win_content): Remove.
2852         (struct tui_gen_win_info) <content, content_size>: Remove.
2853         (struct tui_source_element): Add initializers and destructor.
2854         (union tui_which_element, struct tui_win_element): Remove.
2855         (struct tui_source_window_base) <content>: New field.
2856         (struct tui_data_window): Remove destructor.
2857         (tui_alloc_content, tui_free_win_content)
2858         (tui_free_all_source_wins_content): Don't declare.
2859         * tui/tui-data.c (tui_initialize_static_data): Update.
2860         (init_content_element, tui_alloc_content): Remove.
2861         (~tui_gen_win_info): Update.
2862         (~tui_data_window, tui_free_all_source_wins_content)
2863         (tui_free_win_content, free_content, free_content_elements):
2864         Remove.
2865
2866 2019-06-25  Tom Tromey  <tom@tromey.com>
2867
2868         * tui/tui-winsource.h (tui_clear_source_content)
2869         (tui_erase_source_content, tui_show_source_content): Change type
2870         of win_info.
2871         * tui/tui-winsource.c (tui_clear_source_content)
2872         (tui_erase_source_content, tui_show_source_content): Change type
2873         of win_info.
2874         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2875         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2876         win_info.
2877         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2878         win_info.
2879         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2880
2881 2019-06-25  Tom Tromey  <tom@tromey.com>
2882
2883         * tui/tui-winsource.c (tui_clear_source_content)
2884         (tui_source_window_base::set_is_exec_point_at): Update.
2885         * tui/tui-source.c (tui_set_source_content_nil): Update.
2886         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2887         a bool.
2888         * tui/tui-data.c (init_content_element): Update.
2889
2890 2019-06-25  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2893         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2894         * tui/tui-layout.c (init_and_make_win): Update.
2895         * tui/tui.h (enum tui_win_type): Update.
2896         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2897         tui_win_is_auxillary.
2898         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2899         tui_win_is_auxillary.
2900
2901 2019-06-25  Tom Tromey  <tom@tromey.com>
2902
2903         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2904         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2905         (tui_delete_data_content_windows, tui_display_all_data)
2906         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2907         Update.
2908         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2909         * tui/tui-regs.c (tui_last_regs_line_no)
2910         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2911         (tui_show_registers): Update.
2912         (tui_show_register_group): Return void.  Update.
2913         (tui_display_registers_from, tui_display_reg_element_at_line)
2914         (tui_display_registers_from_line, tui_check_register_values):
2915         Update.
2916         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2917         member.
2918         (struct tui_data_window) <regs_content>: Now a std::vector.
2919         <regs_content_count>: Remove.
2920         (tui_add_content_elements, tui_free_data_content): Don't declare.
2921         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2922         (init_content_element): Remove DATA_WIN case.  Add assert.
2923         (tui_add_content_elements): Remove.
2924         (tui_data_window): Update.
2925         (tui_free_data_content): Remove.
2926         (free_content_elements): Remove DATA_WIN case.
2927
2928 2019-06-25  Tom Tromey  <tom@tromey.com>
2929
2930         * tui/tui-data.c (tui_data_item_window): Update.
2931         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2932         * tui/tui-windata.c (tui_display_all_data)
2933         (tui_display_data_from_line): Update.
2934         (tui_check_data_values): Remove.
2935         * tui/tui-regs.c (tui_show_register_group)
2936         (tui_display_reg_element_at_line): Update.
2937         * tui/tui-hooks.c (tui_register_changed)
2938         (tui_refresh_frame_and_register_information): Call
2939         tui_check_register_values.
2940         * tui/tui-data.h (struct tui_data_window) <data_content,
2941         data_content_count, data_type>: Remove.
2942         (enum tui_data_type): Remove.
2943
2944         * tui/tui-data.c (tui_data_window::clear_detail)
2945         (~tui_data_window): Update.
2946
2947 2019-06-25  Tom Tromey  <tom@tromey.com>
2948
2949         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2950         declare.
2951         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2952         Rename from tui_first_data_item_displayed.  Update.
2953         (tui_data_window::refresh_all)
2954         (tui_data_window::do_scroll_vertical): Update.
2955         * tui/tui-data.h (struct tui_data_window)
2956         <first_data_item_displayed>: Declare new method.
2957
2958 2019-06-25  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2961         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2962         contents...
2963         (tui_initialize_static_data): ...here.
2964
2965 2019-06-25  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2968         (tui_display_registers_from, tui_check_register_values): Update.
2969         (tui_display_register): Remove win_info parameter; update.
2970         (tui_get_register): Change type of parameters.
2971         * tui/tui-data.h (struct tui_data_element): Remove.
2972         (union tui_which_element) <data>: Remove.
2973         <data_window>: Change type.
2974         (struct tui_data_item_window): New.
2975         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2976         case.  Add assert.
2977         (~tui_data_item_window): New destructor.
2978         (free_content_elements): Remove DATA_ITEM_WIN case.
2979
2980 2019-06-25  Tom Tromey  <tom@tromey.com>
2981
2982         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2983         Remove.
2984
2985 2019-06-25  Tom Tromey  <tom@tromey.com>
2986
2987         * tui/tui-data.h (struct tui_command_element): Remove.
2988         (union tui_which_element) <command>: Remove.
2989         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2990         assert.
2991         (free_content_elements): Remove CMD_WIN case.
2992
2993 2019-06-25  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-layout.c (tui_set_layout): Update.
2996         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2997         * tui/tui-data.c (layout_def): Update.
2998
2999 2019-06-25  Tom Tromey  <tom@tromey.com>
3000
3001         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3002         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3003         (tui_source_window_base::set_new_height): Update.
3004         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3005         Update.
3006         (tui_set_locator_fullname, tui_set_locator_info)
3007         (tui_show_frame_info): Update.
3008         * tui/tui-source.c (tui_set_source_content)
3009         (tui_source_is_displayed): Update.
3010         * tui/tui-layout.c (show_source_disasm_command, show_data)
3011         (show_source_or_disasm_and_command): Update.
3012         * tui/tui-disasm.c (tui_set_disassem_content)
3013         (tui_get_begin_asm_address): Update.
3014         * tui/tui-data.h (struct tui_locator_element): Remove.
3015         (union tui_which_element) <locator>: Remove.
3016         (struct tui_locator_window): New.
3017         (tui_locator_win_info_ptr): Change return type.
3018         * tui/tui-data.c (_locator): Change type.
3019         (tui_locator_win_info_ptr): Change return type.
3020         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3021         (tui_alloc_content): Add assert.
3022
3023 2019-06-25  Tom Tromey  <tom@tromey.com>
3024
3025         * tui/tui-winsource.c
3026         (tui_exec_info_window::maybe_allocate_content): New method.
3027         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3028         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3029         (make_source_or_disasm_window): Add cast.
3030         * tui/tui-data.h (union tui_which_element) <simple_string>:
3031         Remove.
3032         (struct tui_source_info): New.
3033         (struct tui_source_window_base) <execution_info>: Change type.
3034         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3035         case, and add assert.
3036         (tui_alloc_content): Add assert.
3037
3038 2019-06-25  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3041         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3042         * tui/tui-data.c (tui_alloc_win_info): Remove.
3043
3044 2019-06-25  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3047         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3048         can_highlight.
3049
3050 2019-06-25  Tom Tromey  <tom@tromey.com>
3051
3052         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3053         make_visible_with_new_height method.
3054         (tui_win_info::make_visible_with_new_height): New method.
3055         (tui_source_window_base::do_make_visible_with_new_height)
3056         (tui_data_window::do_make_visible_with_new_height)
3057         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3058         (make_visible_with_new_height): Remove.
3059         (tui_resize_all, tui_adjust_win_heights): Use
3060         make_visible_with_new_height method.
3061         * tui/tui-data.h (struct tui_win_info)
3062         <do_make_visible_with_new_height, make_visible_with_new_height>:
3063         New methods.
3064         (struct tui_source_window_base, struct tui_data_window)
3065         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3066         methods.
3067
3068 2019-06-25  Tom Tromey  <tom@tromey.com>
3069
3070         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3071         method.
3072         (update_tab_width): Call update_tab_width method.
3073         * tui/tui-data.h (struct tui_win_info)
3074         (struct tui_source_window_base) <update_tab_width>: New methods.
3075
3076 2019-06-25  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3079         parameter.
3080         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3081         parameter.
3082         (tui_gen_win_info::make_visible): Update.
3083         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3084         parameter.
3085         * tui/tui-data.h (enum tui_box): New enum.
3086         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3087
3088 2019-06-25  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3091         init_and_make_win for EXEC_INFO_WIN.
3092         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3093         longer inline.
3094         (struct tui_win_info) <~tui_win_info>: Inline.
3095         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3096         Don't declare.
3097         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3098         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3099         Remove.
3100         (tui_initialize_static_data): Update.
3101         (~tui_gen_win_info): Handle more cleanup here.
3102         (~tui_source_window_base): Delete "execution_info".
3103         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3104
3105 2019-06-25  Tom Tromey  <tom@tromey.com>
3106
3107         * tui/tui-layout.c (make_command_window): Don't set
3108         can_highlight.
3109         (show_source_disasm_command): Call the reset method.
3110         (show_data): Don't set can_highlight.  Call the reset method.
3111         (tui_gen_win_info::reset): Rename from init_gen_win_info
3112         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3113         (show_source_or_disasm_and_command): Call the reset method.
3114         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3115         (struct tui_cmd_window): Set can_highlight.
3116
3117 2019-06-25  Tom Tromey  <tom@tromey.com>
3118
3119         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3120         from make_visible.
3121         (tui_make_visible, tui_make_invisible): Rewrite.
3122         (tui_win_info::make_visible): Remove.
3123         (tui_source_window_base::make_visible): Update.
3124         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3125         method.  Moved from...
3126         (struct tui_win_info) <make_visible>: ...here.
3127
3128 2019-06-25  Tom Tromey  <tom@tromey.com>
3129
3130         * tui/tui-winsource.c
3131         (tui_source_window_base::do_scroll_horizontal): Remove direction
3132         parameter.
3133         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3134         direction parameter.
3135         * tui/tui-win.c (tui_win_info::forward_scroll)
3136         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3137         (tui_win_info::right_scroll): Update.
3138         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3139         direction parameter.
3140         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3141         direction parameter.
3142         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3143         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3144         Remove direction parameter.
3145         (struct tui_source_window_base, struct tui_source_window)
3146         (struct tui_disasm_window, struct tui_data_window)
3147         (struct tui_cmd_window): Update.
3148
3149 2019-06-25  Tom Tromey  <tom@tromey.com>
3150
3151         * tui/tui-winsource.h (tui_set_exec_info_content)
3152         (tui_show_exec_info_content, tui_erase_exec_info_content)
3153         (tui_clear_exec_info_content, tui_update_exec_info): Change
3154         argument to tui_source_window_base.
3155         * tui/tui-winsource.c (tui_set_exec_info_content)
3156         (tui_show_exec_info_content, tui_erase_exec_info_content)
3157         (tui_clear_exec_info_content, tui_update_exec_info): Change
3158         argument to tui_source_window_base.
3159
3160 2019-06-25  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3163         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3164
3165 2019-06-25  Tom Tromey  <tom@tromey.com>
3166
3167         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3168         check.
3169
3170 2019-06-25  Tom Tromey  <tom@tromey.com>
3171
3172         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3173         type to void.
3174         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3175         type to void.
3176         * tui/tui-source.c (tui_set_source_content): Update.
3177         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3178
3179 2019-06-25  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui-win.c (window_name_completer, tui_set_focus)
3182         (tui_all_windows_info): Use name method.
3183         * tui/tui-data.h (struct tui_gen_win_info)
3184         (struct tui_source_window, struct tui_disasm_window)
3185         (struct tui_data_window, struct tui_cmd_window) <name>: New
3186         method.
3187         (tui_win_name): Don't declare.
3188         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3189         (tui_win_name): Remove.
3190
3191 2019-06-25  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-winsource.h (tui_update_source_window)
3194         (tui_update_source_window_as_is): Change parameter type.
3195         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3196         to be a tui_source_window_base.
3197         (tui_update_source_window_as_is): Likewise.
3198         * tui/tui-win.c (make_visible_with_new_height): Update.
3199
3200 2019-06-25  Tom Tromey  <tom@tromey.com>
3201
3202         * tui/tui-winsource.c (tui_erase_source_content)
3203         (tui_show_source_content, tui_show_exec_info_content)
3204         (tui_erase_exec_info_content): Use refresh_window method.
3205         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3206         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3207         from tui_refresh_win.
3208         (tui_data_window::refresh_window): New method.
3209         (tui_win_info::refresh, tui_source_window_base::refresh)
3210         (tui_refresh_all): Use refresh_window method.
3211         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3212         method.
3213         * tui/tui-regs.c (tui_display_register): Call refresh_window
3214         method.
3215         * tui/tui-layout.c (show_source_disasm_command)
3216         (show_source_or_disasm_and_command): Call refresh_window method.
3217         * tui/tui-data.h (struct tui_gen_win_info)
3218         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3219         New method.
3220
3221 2019-06-25  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui.c (tui_rl_other_window, tui_enable)
3224         (tui_is_window_visible, tui_get_command_dimension): Update.
3225         * tui/tui-winsource.c (tui_update_source_window_as_is)
3226         (tui_clear_source_content, tui_erase_source_content)
3227         (tui_show_source_line, tui_source_window_base::refill)
3228         (tui_source_window_base::do_scroll_horizontal)
3229         (tui_source_window_base::set_is_exec_point_at)
3230         (tui_update_breakpoint_info, tui_set_exec_info_content)
3231         (tui_alloc_source_buffer, tui_line_is_displayed)
3232         (tui_addr_is_displayed): Update.
3233         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3234         (tui_check_and_display_highlight_if_needed)
3235         (tui_win_info::make_visible, tui_win_info::refresh)
3236         (tui_refresh_all): Update.
3237         * tui/tui-windata.c (tui_first_data_item_displayed)
3238         (tui_delete_data_content_windows, tui_erase_data_content)
3239         (tui_display_all_data, tui_data_window::refresh_all)
3240         (tui_check_data_values): Update.
3241         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3242         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3243         (tui_win_info::backward_scroll, tui_refresh_all_win)
3244         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3245         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3246         (tui_source_window_base::set_new_height)
3247         (tui_data_window::set_new_height)
3248         (make_invisible_and_set_new_height)
3249         (make_visible_with_new_height, new_height_ok)
3250         (parse_scrolling_args): Update.
3251         * tui/tui-stack.c (tui_show_frame_info): Update.
3252         * tui/tui-source.c (tui_set_source_content)
3253         (tui_set_source_content_nil, tui_source_is_displayed)
3254         (tui_source_window::do_scroll_vertical): Update.
3255         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3256         (tui_display_registers_from, tui_display_reg_element_at_line)
3257         (tui_check_register_values, tui_reg_command): Update.
3258         * tui/tui-layout.c (tui_default_win_height)
3259         (show_source_disasm_command, show_data, init_and_make_win)
3260         (show_source_or_disasm_and_command): Update.
3261         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3262         (tui_redisplay_readline, tui_mld_flush)
3263         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3264         (tui_getc): Update.
3265         * tui/tui-disasm.c (tui_set_disassem_content)
3266         (tui_disasm_window::do_scroll_vertical): Update.
3267         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3268         Now virtual.
3269         (struct tui_win_info): Derive from tui_gen_win_info.
3270         <~tui_win_info>: Mark as override.
3271         <generic>: Remove member.
3272         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3273         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3274         (~tui_data_window, ~tui_win_info)
3275         (tui_free_all_source_wins_content): Update.
3276         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3277
3278 2019-06-25  Tom Tromey  <tom@tromey.com>
3279
3280         * tui/tui-layout.c (init_and_make_win): Use new.
3281         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3282         destructor, initializers.
3283         (tui_alloc_generic_win_info): Don't declare.
3284         * tui/tui-data.c (_locator): Add argument to constructor.
3285         (source_win, disasm_win): New globals.
3286         (exec_info): Remove.
3287         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3288         Update.
3289         (tui_alloc_generic_win_info): Remove.
3290         (init_content_element): Use new.
3291         (tui_win_info::tui_win_info): Update.
3292         (free_content_elements) <case DATA_WIN>: Use delete.
3293
3294 2019-06-25  Tom Tromey  <tom@tromey.com>
3295
3296         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3297         * tui/tui-windata.c (tui_first_data_item_displayed)
3298         (tui_delete_data_content_windows): Update.
3299         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3300         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3301         (tui_display_registers_from, tui_check_register_values): Update.
3302         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3303         pointer.
3304         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3305         window.
3306         (tui_free_data_content): Update.
3307         (free_content_elements) <case DATA_WIN>: Free the window.
3308
3309 2019-06-25  Tom Tromey  <tom@tromey.com>
3310
3311         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3312         Update.
3313         * tui/tui-layout.c (make_command_window)
3314         (show_source_disasm_command, show_data, init_and_make_win)
3315         (show_source_or_disasm_and_command): Update.
3316         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3317         method.
3318         <can_highight, is_highlighted>: Now bool.
3319         (tui_set_win_highlight): Don't declare.
3320         * tui/tui-data.c (tui_set_win_highlight): Remove.
3321
3322 2019-06-25  Tom Tromey  <tom@tromey.com>
3323
3324         * tui/tui-wingeneral.c (make_visible): Remove check of window
3325         type.
3326
3327 2019-06-25  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui-win.c (tui_win_info::max_height)
3330         (tui_cmd_window::max_height): New methods.
3331         (new_height_ok): Call max_height.
3332         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3333         <max_height>: New method.
3334
3335 2019-06-25  Tom Tromey  <tom@tromey.com>
3336
3337         * tui/tui-win.c (tui_source_window_base::set_new_height)
3338         (tui_data_window::set_new_height): New methods.
3339         (make_invisible_and_set_new_height): Call set_new_height method.
3340         * tui/tui-data.h (struct tui_win_info)
3341         (struct tui_source_window_base, struct tui_data_window)
3342         <set_new_height>: New method.
3343
3344 2019-06-25  Tom Tromey  <tom@tromey.com>
3345
3346         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3347         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3348         tui_refresh_data_win.
3349         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3350         method.
3351         (tui_refresh_all_win): Call the refresh_all method.
3352         (tui_set_focus): Likewise.
3353         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3354         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3355         Likewise.
3356
3357 2019-06-25  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-winsource.h (tui_refill_source_window)
3360         (tui_set_is_exec_point_at): Don't declare.
3361         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3362         (tui_source_window_base::refill): Rename from
3363         tui_refill_source_window.
3364         (tui_source_window_base::do_scroll_horizontal): Update.
3365         (tui_source_window_base::set_is_exec_point_at): Rename from
3366         tui_set_is_exec_point_at.
3367         (tui_update_all_breakpoint_info): Update.
3368         * tui/tui-stack.c (tui_show_frame_info): Update.
3369         * tui/tui-layout.c (show_data): Add cast.
3370         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3371         * tui/tui-data.h (struct tui_source_window_base) <refill,
3372         set_is_exec_point_at>: New methods.
3373         (tui_source_windows, tui_add_to_source_windows): Update types.
3374         (tui_add_to_source_windows): Remove redundant declaration.
3375         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3376         (tui_source_windows): Change return type.
3377         (tui_clear_source_windows_detail): Update.
3378         (tui_add_to_source_windows): Change type of parameter.
3379         (tui_free_all_source_wins_content): Update.
3380
3381 2019-06-25  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui-wingeneral.c (tui_win_info::refresh)
3384         (tui_source_window_base::refresh): New methods.
3385         (tui_refresh_all): Call the refresh method.
3386         * tui/tui-data.h (struct tui_win_info)
3387         (struct tui_source_window_base) <refresh>: New method.
3388
3389 2019-06-25  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui.h (tui_is_window_visible): Return bool.
3392         * tui/tui.c (tui_is_window_visible): Return bool.
3393         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3394         (tui_make_visible, tui_make_invisible)
3395         (tui_win_info::make_visible)
3396         (tui_source_window_base::make_visible, make_all_visible)
3397         (tui_make_all_visible, tui_make_all_invisible): Update.
3398         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3399         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3400         bool.
3401         (struct tui_win_info, struct tui_source_window_base)
3402         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3403         * tui/tui-data.c (tui_init_generic_part): Update.
3404
3405 2019-06-25  Tom Tromey  <tom@tromey.com>
3406
3407         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3408         (tui_source_window_base::make_visible): New methods.
3409         (make_all_visible): Make method call.
3410         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3411         (struct tui_source_window_base, struct tui_cmd_window): Override
3412         make_visible.
3413         (tui_win_is_source_type): Don't declare.
3414         * tui/tui-data.c (tui_win_is_source_type): Remove.
3415
3416 2019-06-25  Tom Tromey  <tom@tromey.com>
3417
3418         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3419         NULL check.
3420
3421 2019-06-25  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3424         Inline constructor.  Add initializers for members.
3425         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3426         constructors; now inline in class.
3427
3428 2019-06-25  Tom Tromey  <tom@tromey.com>
3429
3430         * tui/tui-regs.c (tui_show_registers): Update.
3431         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3432         bool.
3433         * tui/tui-data.c (tui_data_window::clear_detail)
3434         (tui_data_window): Update.
3435
3436 2019-06-25  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-windata.c (tui_display_all_data)
3439         (tui_display_data_from_line, tui_display_data_from)
3440         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3441         Update.
3442         * tui/tui-regs.c (tui_last_regs_line_no)
3443         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3444         (tui_show_registers, tui_show_register_group)
3445         (tui_display_registers_from, tui_display_reg_element_at_line)
3446         (tui_display_registers_from_line, tui_check_register_values)
3447         (tui_reg_next, tui_reg_prev): Update.
3448         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3449         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3450         tui_data_window.
3451         (struct tui_win_info) <detail>: Remove.  Add new fields from
3452         tui_data_info.
3453         (TUI_DATA_WIN): Add cast.
3454         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3455         (~tui_data_window): Simplify.
3456
3457 2019-06-25  Tom Tromey  <tom@tromey.com>
3458
3459         * tui/tui-layout.c (show_source_disasm_command)
3460         (show_source_or_disasm_and_command): Update.
3461         * tui/tui-io.c (update_cmdwin_start_line)
3462         (tui_redisplay_readline): Update.
3463         * tui/tui-data.h (struct tui_command_info): Remove.
3464         (struct tui_win_info) <detail>: Remove command_info member.
3465         (struct tui_data_window) <start_line>: New member, from
3466         tui_command_info.
3467         (TUI_CMD_WIN): Add casts.
3468
3469 2019-06-25  Tom Tromey  <tom@tromey.com>
3470
3471         * tui/tui-winsource.c (tui_update_source_window)
3472         (tui_refill_source_window)
3473         (tui_source_window_base::do_scroll_horizontal)
3474         (tui_update_breakpoint_info, tui_set_exec_info_content)
3475         (tui_show_exec_info_content, tui_erase_exec_info_content)
3476         (tui_clear_exec_info_content): Update.
3477         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3478         Update.
3479         * tui/tui-win.c (make_invisible_and_set_new_height)
3480         (make_visible_with_new_height): Update.
3481         * tui/tui-source.c (tui_set_source_content)
3482         (tui_show_symtab_source): Update.
3483         * tui/tui-layout.c (extract_display_start_addr)
3484         (show_source_disasm_command, show_data)
3485         (make_source_or_disasm_window)
3486         (show_source_or_disasm_and_command): Update.
3487         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3488         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3489         "gdbarch".
3490         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3491         to tui_source_window_base.
3492         (struct tui_win_info) <detail>: Remove source_info member.
3493         (struct tui_source_window_base) <has_locator>: Inline.
3494         Move contents from tui_source_info; rename has_locator member to
3495         m_has_locator.
3496         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3497         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3498         header file.
3499         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3500         Simplify.
3501         (tui_free_all_source_wins_content): Cast to
3502         tui_source_window_base.
3503
3504 2019-06-25  Tom Tromey  <tom@tromey.com>
3505
3506         * tui/tui-win.c (make_invisible_and_set_new_height)
3507         (make_visible_with_new_height): Call has_locator method.
3508         * tui/tui-layout.c (show_source_disasm_command, show_data)
3509         (show_source_or_disasm_and_command): Update for bool change.
3510         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3511         (tui_win_info) <has_locator>: New method.
3512         (struct tui_source_window_base) <has_locator>: New method.
3513         (tui_win_has_locator): Don't declare.
3514         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3515         from tui_win_has_locator.
3516         (tui_source_window_base): Use false, not FALSE.
3517
3518 2019-06-25  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3521         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3522         clear_detail method directly.
3523         (tui_clear_win_detail): Remove.
3524
3525 2019-06-25  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3528         "this", not TUI_DISASM_WIN.
3529
3530 2019-06-25  Tom Tromey  <tom@tromey.com>
3531
3532         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3533         declare.
3534         * tui/tui-winsource.c
3535         (tui_source_window_base::do_scroll_horizontal): Rename from
3536         tui_horizontal_source_scroll.
3537         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3538         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3539         from tui_vertical_data_scroll.
3540         * tui/tui-win.h (tui_scroll): Don't declare.
3541         * tui/tui-win.c (tui_win_info::forward_scroll)
3542         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3543         (tui_win_info::right_scroll): Rename and update.
3544         (tui_scroll_forward_command, tui_scroll_backward_command)
3545         (tui_scroll_left_command, tui_scroll_right_command): Update.
3546         (tui_scroll): Remove.
3547         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3548         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3549         from tui_vertical_source_scroll.
3550         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3551         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3552         from tui_vertical_disassem_scroll.
3553         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3554         do_scroll_horizontal>: New methods.
3555         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3556         Likewise.
3557         (struct tui_source_window_base): Add do_scroll_horizontal.
3558         (struct tui_source_window, struct tui_disasm_window): Add
3559         do_scroll_vertical.
3560         (struct tui_data_window, struct tui_cmd_window): Add
3561         do_scroll_horizontal and do_scroll_vertical.
3562         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3563
3564 2019-06-25  Tom Tromey  <tom@tromey.com>
3565
3566         * tui/tui-data.h (struct tui_source_window_base): New struct.
3567         (struct tui_source_window): Derive from tui_source_window_base.
3568         (struct tui_disasm_window): New struct.
3569         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3570         from tui_source_window::clear_detail.
3571         (tui_source_window_base): Rename from tui_source_window.
3572         (~tui_source_window_base): Rename from ~tui_source_window.
3573         (tui_alloc_win_info): Create a tui_disasm_window.
3574
3575 2019-06-25  Tom Tromey  <tom@tromey.com>
3576
3577         * tui/tui-data.h (struct tui_source_window)
3578         (struct tui_data_window): Declare destructors.
3579         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3580         destructors.
3581         (tui_win_info): Simplify.
3582
3583 2019-06-25  Tom Tromey  <tom@tromey.com>
3584
3585         * tui/tui-winsource.c (tui_display_main)
3586         (tui_update_source_windows_with_addr)
3587         (tui_update_all_breakpoint_info): Update.
3588         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3589         (new_height_ok, parse_scrolling_args): Update.
3590         * tui/tui-stack.c (tui_show_frame_info): Update.
3591         * tui/tui-data.h (struct tui_list): Remove.
3592         (tui_source_windows): Return a reference to a std::vector.
3593         * tui/tui-data.c (source_windows): Now a std::vector.
3594         (tui_source_windows): Change return type.
3595         (tui_clear_source_windows): Rewrite.
3596         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3597         (tui_free_all_source_wins_content): Rewrite.
3598
3599 2019-06-25  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3602         (struct tui_data_window, struct tui_cmd_window): Declare
3603         clear_detail method.
3604         * tui/tui-data.c (tui_source_window::clear_detail)
3605         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3606         methods.
3607         (tui_clear_win_detail): Simplify.
3608
3609 2019-06-25  Tom Tromey  <tom@tromey.com>
3610
3611         * tui/tui-layout.c (make_source_window, make_disasm_window)
3612         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3613         Return the new window.
3614         (show_source_disasm_command, show_data)
3615         (show_source_or_disasm_and_command): Update.
3616
3617 2019-06-25  Tom Tromey  <tom@tromey.com>
3618
3619         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3620         parameter.  Return the new window.
3621         (show_source_disasm_command): Update and remove NULL check.
3622         (show_source_or_disasm_and_command): Update.
3623
3624 2019-06-25  Tom Tromey  <tom@tromey.com>
3625
3626         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3627
3628 2019-06-25  Tom Tromey  <tom@tromey.com>
3629
3630         * tui/tui-data.h (struct tui_win_info): Make constructor
3631         protected.  Make destructor virtual.  Add initializers.
3632         (tui_source_window, tui_data_window, tui_cmd_window): New
3633         classes.
3634         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3635         constructor.  Add "type" parameter.
3636         (tui_source_window, tui_data_window, tui_cmd_window): New
3637         constructors.
3638         (tui_alloc_win_info): Instantiate the appropriate subclass.
3639
3640 2019-06-25  Tom Tromey  <tom@tromey.com>
3641
3642         * tui/tui-win.c (tui_resize_all): Use delete.
3643         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3644         destructor.
3645         (tui_free_window): Don't declare.
3646         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3647         Update.
3648
3649 2019-06-25  Tom Tromey  <tom@tromey.com>
3650
3651         * tui/tui-data.h (struct tui_win_info): Add constructor.
3652         * tui/tui-data.c (tui_alloc_win_info): Use new.
3653         (tui_free_window): Use delete.
3654
3655 2019-06-22  Tom Tromey  <tom@tromey.com>
3656
3657         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3658         declare.
3659         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3660
3661 2019-06-22  Tom Tromey  <tom@tromey.com>
3662
3663         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3664         declare.
3665         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3666
3667 2019-06-22  Tom de Vries  <tdevries@suse.de>
3668
3669         * dwarf2read.c (create_addrmap_from_aranges)
3670         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3671         instead of '%zu'.
3672
3673 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3674
3675         * dwarf2read.h (dwarf2_section_info_def): Remove.
3676         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3677         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3678         std::vector<dwarf2_section_info>.
3679         (struct dwo_file) <~dwo_file>: Remove.
3680         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3681         types field.
3682         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3683         (dwarf2_read_debug_names): Likewise.
3684         (create_debug_types_hash_table): Change parameter type to
3685         array_view, adjust code accordingly.
3686         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3687         (partial_die_info::fixup): Likewise.
3688         (determine_prefix): Likewise.
3689         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3690
3691 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3692
3693         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3694         gdb_bfd_ref_ptr.
3695         <~dwo_file>: Remove call to gdb_bfd_unref.
3696         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3697         gdb_bfd_ref_ptr::get.
3698
3699 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3700
3701         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3702         type to htab_up.
3703         * dwarf2read.c (struct dwo_file): Initialize fields.
3704         <~dwo_file>: New.
3705         (free_dwo_file): Remove, move content to ~dwo_file.
3706         (struct dwo_file_deleter): Remove.
3707         (dwo_file_up>: Remove custom deleter.
3708         (free_dwo_files): Remove.
3709         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3710         dwo_files.
3711         (process_skeletonless_type_units): Call unique_ptr::get.
3712         (allocate_dwo_file_hash_table): Add deleter to created hash
3713         table.  Change return type to htab_up.
3714         (lookup_dwo_file_slot): Don't memset dwo_file, call
3715         unique_ptr::get.
3716         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3717         (create_dwo_unit_in_dwp_v2): Likewise.
3718         (open_and_init_dwo_file): Likewise.
3719         (free_dwo_file_from_slot): Remove.
3720
3721 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3722
3723         * dwarf2read.h (struct dwarf2_section_info) <readin,
3724         is_virtual>: Change type to bool.
3725         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3726         true instead of 1.
3727
3728 2019-06-19  Tom Tromey  <tom@tromey.com>
3729
3730         * tui/tui-data.h (tui_init_content_element): Don't declare.
3731
3732 2019-06-19  Tom Tromey  <tom@tromey.com>
3733
3734         * tui/tui-data.h (tui_init_win_info): Don't declare.
3735
3736 2019-06-19  Tom de Vries  <tdevries@suse.de>
3737
3738         * dwarf2read.h (abstract_to_concrete): Change type to
3739         std::unordered_map<sect_offset, std::vector<sect_offset>,
3740         gdb::hash_enum<sect_offset>>.
3741
3742 2019-06-19  Tom Tromey  <tromey@adacore.com>
3743
3744         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3745         EVAL_AVOID_SIDE_EFFECTS specially.
3746
3747 2019-06-19  Tom Tromey  <tromey@adacore.com>
3748
3749         * source-cache.c (highlighter): New global.
3750         (source_cache::get_source_lines): Create a highlighter on demand.
3751
3752 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3753
3754         * defs.h (deprecated_interactive_hook): Delete declaration.
3755         * interps.c (clear_interpreter_hooks): Remove use of
3756         deprecated_interactive_hook.
3757         * top.c (deprecated_interactive_hook): Delete definition.
3758         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3759
3760 2019-06-18  Tom de Vries  <tdevries@suse.de>
3761
3762         PR gdb/24515
3763         * dwarf2read.h (abstract_to_concrete): Change type from
3764         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3765         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3766         * dwarf2read.c (read_variable): Update.
3767         (dwarf2_fetch_die_loc_sect_off): Update.
3768
3769 2019-06-17  Tom de Vries  <tdevries@suse.de>
3770
3771         PR gdb/24617
3772         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3773         accessing parent[parent_len - 1].
3774
3775 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3776
3777         PR gdb/24364
3778         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3779         call dtrace_process_dof with NULL dof.
3780
3781 2019-06-16  Tom de Vries  <tdevries@suse.de>
3782
3783         PR gdb/24445
3784         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3785
3786 2019-06-16  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3789         (make_all_visible): Use address of member.
3790
3791 2019-06-16  Tom Tromey  <tom@tromey.com>
3792
3793         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3794         (tui_free_window, free_content, free_content_elements): Remove
3795         unnecessary cast.
3796         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3797         cast.
3798         * tui/tui-regs.c (tui_show_register_group)
3799         (tui_display_registers_from, tui_display_reg_element_at_line):
3800         Remove unnecessary cast.
3801
3802 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3803
3804         * linux-nat.c (normal_mask): Delete.
3805         (_initialize_linux_nat): Don't initialise normal_mask.
3806
3807 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3808
3809         PR gdb/24445
3810         * dwarf-index-write.h (write_psymtabs_to_index): Add
3811         dwz_basename parameter.
3812         * dwarf-index-write.c (write_gdbindex): Move file writing to
3813         write_gdbindex_1.  Change return type void.
3814         (assert_file_size): Move up, remove filename parameter.
3815         (write_gdbindex_1): New function.
3816         (write_debug_names): Change return type to void, call
3817         assert_file_size.
3818         (struct index_wip_file): New struct.
3819         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3820         file logic to index_wip_file.  Write index for dwz file if
3821         needed.
3822         (save_gdb_index_command): Pass basename of dwz file, if present.
3823         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3824         build-id of dwz file, if present.
3825         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3826         (dwarf2_get_dwz_file): Likewise.
3827         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3828         (dwarf2_get_dwz_file): Likewise.
3829
3830 2019-06-16  Tom Tromey  <tom@tromey.com>
3831
3832         * coffread.c (process_coff_symbol): Use xstrdup.
3833         * value.c (create_internalvar): Use xstrdup.
3834
3835 2019-06-16  Tom Tromey  <tom@tromey.com>
3836
3837         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3838         * breakpoint.c (stopin_command, stopat_command)
3839         (until_break_command, decode_location_default): Remove unnecessary
3840         cast.
3841         * utils.c (subset_compare): Remove unnecessary cast.
3842         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3843         cast.
3844         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3845         cast.
3846         * infcmd.c (path_command): Remove unnecessary cast.
3847         * coffread.c (decode_type): Remove unnecessary cast.
3848         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3849         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3850         * tui/tui-stack.c (tui_show_locator_content)
3851         (tui_show_frame_info): Remove unnecessary cast.
3852         * tui/tui-win.c (tui_scroll_forward_command)
3853         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3854         (parse_scrolling_args): Remove unnecessary cast.
3855         * tui/tui-data.c (init_win_info, tui_del_window)
3856         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3857         (free_content_elements): Remove unnecessary cast.
3858         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3859         unnecessary cast.
3860         * tui/tui-source.c (tui_set_source_content)
3861         (tui_vertical_source_scroll): Remove unnecessary cast.
3862         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3863         cast.
3864         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3865         * tui/tui-regs.c (tui_display_registers_from)
3866         (tui_display_register): Remove unnecessary cast.
3867         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3868         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3869         (make_visible): Remove unnecessary cast.
3870         * tui/tui-winsource.c (tui_erase_source_content)
3871         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3872         unnecessary cast.
3873         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3874         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3875         * stabsread.c (read_type, read_array_type, read_range_type):
3876         Remove unnecessary cast.
3877         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3878         (parse_symbol, parse_type, upgrade_type, parse_external)
3879         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3880         unnecessary cast.
3881         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3882
3883 2019-06-16  Tom Tromey  <tom@tromey.com>
3884
3885         * tui/tui-data.c (tui_alloc_generic_win_info)
3886         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3887         checks.
3888
3889 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3890             Andrew Burgess  <andrew.burgess@embecosm.com>
3891
3892         * f-typeprint.c (f_print_type): Don't return early for not
3893         associated or not allocated types.
3894         (f_type_print_varspec_suffix): Add print_rank parameter and print
3895         ranks of array types in case they dangling.
3896         (f_type_print_base): Add print_rank parameter.
3897
3898 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3899
3900         * NEWS: Mention new MI commands.
3901         * break-catch-throw.c (enum exception_event_kind): Move to
3902         breakpoint.h.
3903         (print_mention_exception_catchpoint): Output text as a single
3904         message.
3905         (catch_exception_command_1): Rename to...
3906         (catch_exception_event): ...this, make non-static, update header
3907         command, and change some parameter types.
3908         (catch_catch_command): Update for changes to
3909         catch_exception_command_1.
3910         (catch_throw_command): Likewise.
3911         (catch_rethrow_command): Likewise.
3912         * breakpoint.c (enum exception_event_kind): Delete.
3913         * breakpoint.h (enum exception_event_kind): Moved here from
3914         break-catch-throw.c.
3915         (catch_exception_event): Declare.
3916         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3917         (mi_cmd_catch_throw): New function.
3918         (mi_cmd_catch_rethrow): New function.
3919         (mi_cmd_catch_catch): New function.
3920         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3921         'catch-catch' entries.
3922         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3923         (mi_cmd_catch_rethrow): Declare.
3924         (mi_cmd_catch_catch): Declare.
3925
3926 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3927
3928         * annotate.c (annotate_source_line): Change return type to void,
3929         update implementation to match.
3930         * annotate.h (annotate_source_line): Change return type to void,
3931         update header comment.
3932         * stack.c (print_frame_info): Don't change what frame information
3933         is printed based on whether annotations are on or not.
3934
3935 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3936
3937         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3938         (annotate_source): Make static.
3939         (annotate_source_line): Moved from source.c and renamed from
3940         identify_source_line.  Update the return type.
3941         * annotate.h (annotate_source): Delete declaration.
3942         (annotate_source_line): Declaration moved from source.h, and
3943         renamed from identify_source_line.  Return type updated.
3944         * source.c (identify_source_line): Moved to annotate.c and renamed
3945         to annotate_source_line.
3946         (info_line_command): Remove check of annotation_level.
3947         * source.h (identify_source_line): Move declaration to annotate.h
3948         and rename to annotate_source_line.
3949         * stack.c: Add 'annotate.h' include.
3950         (print_frame_info): Remove check of annotation_level before
3951         calling annotate_source_line.
3952
3953 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3954
3955         * source-cache.c (source_cache::get_plain_source_lines): Use
3956         open_source_file_with_line_charpos instead of just
3957         open_source_file, remove call to find_source_lines.
3958         (source_cache::get_source_lines): Likewise.
3959         * source.c (find_source_lines): Make static.
3960         (get_filename_and_charpos): Renamed into...
3961         (open_source_file_with_line_charpos): ..this along with changes to
3962         return a scoped_fd, and some other minor clean ups.
3963         (identify_source_line): Use open_source_file_with_line_charpos.
3964         (search_command_helper): Use open_source_file_with_line_charpos
3965         instead of just open_source_file, remove call to
3966         find_source_lines.
3967         * source.h (open_source_file_with_line_charpos): Declare new
3968         function.
3969         (find_source_lines): Delete declaration.
3970
3971 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3972
3973         * source.c (get_filename_and_charpos): Remove fullname
3974         parameter.
3975         (identify_source_line): Update call to get_filename_and_charpos.
3976
3977 2019-06-14  Tom Tromey  <tromey@adacore.com>
3978
3979         PR gdb/24502:
3980         * ui-style.h (skip_ansi_escape): Update comment.
3981         * ui-file.h (class no_terminal_escape_file): New class.
3982         * ui-file.c (no_terminal_escape_file::write)
3983         (no_terminal_escape_file::puts): New methods.
3984         * cli/cli-logging.c (handle_redirections): Use
3985         no_terminal_escape_file.
3986
3987 2019-06-14  Tom Tromey  <tromey@adacore.com>
3988
3989         * NEWS: Move convenience variable news above Python news.
3990
3991 2019-06-14  Tom Tromey  <tom@tromey.com>
3992
3993         * gnulib: Move directory to top-level.
3994         * configure.ac: Don't configure gnulib.
3995         * configure: Rebuild.
3996         * common/common-defs.h: Use new path to gnulib.
3997         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3998         (GNULIB_H): Remove.
3999         (INCGNU): Look in new gnulib location.
4000         (HFILES_NO_SRCDIR): Remove gnulib files.
4001         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4002         (generated_files): Remove GNULIB_H.
4003         ($(LIBGNU), all-lib): Remove targets.
4004         (distclean): Don't mention GNULIB_BUILDDIR.
4005         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4006
4007 2019-06-14  Tom Tromey  <tromey@adacore.com>
4008
4009         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4010         Warn if symbol file does not provide any symbols.
4011
4012 2019-06-14  Tom Tromey  <tromey@adacore.com>
4013
4014         * source.c (find_and_open_source): Respect basenames_may_differ.
4015
4016 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4017
4018         * annotate.c (annotate_breakpoints_invalid): Make use of
4019         scoped_restore_terminal_state.
4020         (annotate_frames_invalid): Likewise.
4021
4022 2019-06-14  Tom Tromey  <tromey@adacore.com>
4023
4024         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4025         allow assignment to an internalvar.
4026
4027 2019-06-14  Tom Tromey  <tromey@adacore.com>
4028
4029         * ada-lex.l: Allow "_" in attribute names.
4030
4031 2019-06-14  Tom Tromey  <tromey@adacore.com>
4032
4033         PR gdb/24653:
4034         * regcache.c (registers_changed): Don't call alloca.
4035         * top.c (execute_command): Don't call alloca.
4036
4037 2019-06-13  Pedro Alves  <palves@redhat.com>
4038
4039         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4040         'expression'.  When parsing an expression, error out if there's
4041         junk after "unlimited".
4042         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4043         (do_set_command): Adjust calls to is_unlimited_literal.
4044
4045 2019-06-13  Pedro Alves  <palves@redhat.com>
4046
4047         * compile/compile.c (make_compile_options_def_group): Add braces
4048         around array_view initializer.
4049         * thread.c (make_thread_apply_all_options_def_group)
4050         (make_thread_apply_all_options_def_group): Likewise.
4051
4052 2019-06-13  Pedro Alves  <palves@redhat.com>
4053
4054         * NEWS (New commands): Mention "maint test-options
4055         require-delimiter", "maint test-options unknown-is-error", "maint
4056         test-options unknown-is-operand" and "maint show
4057         test-options-completion-result".
4058         (New command options, command completion): New section.
4059         (Completion improvements): New section.
4060         Mention that you can abbreviate "unlimited".
4061
4062 2019-06-13  Pedro Alves  <palves@redhat.com>
4063
4064         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4065         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4066         * unittests/cli-utils-selftests.c (test_parse_flags)
4067         (test_parse_flags_qcs): Delete.
4068         (test_cli_utils): Don't call deleted functions.
4069
4070 2019-06-13  Pedro Alves  <palves@redhat.com>
4071
4072         * thread.c: Include "cli/cli-option.h".
4073         (tp_array_compar_ascending): Global.
4074         (tp_array_compar): Delete function.
4075         (tp_array_compar_ascending, tp_array_compar_descending): New
4076         functions.
4077         (ascending_option_def, qcs_flag_option_def)
4078         (thr_qcs_flags_option_defs)
4079         (make_thread_apply_all_options_def_group)
4080         (make_thread_apply_options_def_group): New.
4081         (thread_apply_all_command): Use gdb::option::process_options.
4082         (thread_apply_command_completer)
4083         (thread_apply_all_command_completer): New.
4084         (thread_apply_command): Use gdb::option::process_options.
4085         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4086         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4087         to generate help text of "thread apply".  Adjust "taas"'s help.
4088         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4089         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4090
4091 2019-06-13  Pedro Alves  <palves@redhat.com>
4092
4093         * thread.c (thread_apply_command): Check for invalid TID with
4094         isdigit instead of !isalpha.
4095
4096 2019-06-13  Pedro Alves  <palves@redhat.com>
4097
4098         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4099         (validate_flags_qcs): New.
4100         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4101         (validate_flags_qcs): Declare.
4102         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4103         (make_frame_apply_options_def_group): New.
4104         (frame_apply_command_count): Process options with
4105         gdb::option::process_options.
4106         (frame_apply_completer): New.
4107         (frame_apply_level_completer, frame_apply_all_completer)
4108         (frame_apply_completer): New.
4109         (_initialize_stack): Update help of "frame apply", "frame apply
4110         level", "frame apply all" and "faas" to mention supported options
4111         and install command completers.
4112         * stack.h (frame_apply_all_completer): Declare.
4113         * thread.c: Include "stack.h".
4114         (tfaas_command): Add "--".
4115         (_initialize_thread): Update help "tfaas" to mention supported
4116         options and install command completer.
4117
4118 2019-06-13  Pedro Alves  <palves@redhat.com>
4119
4120         * completer.c (complete_nested_command_line): New.
4121         (gdb_completion_word_break_characters_throw): Add assertion.
4122         * completer.h (complete_nested_command_line): Declare.
4123
4124 2019-06-13  Pedro Alves  <palves@redhat.com>
4125
4126         * stack.c (parse_backtrace_qualifiers): New.
4127         (backtrace_command): Use it.
4128         (backtrace_command_completer): Complete on qualifiers.
4129
4130 2019-06-13  Pedro Alves  <palves@redhat.com>
4131
4132         * frame.c: Include "cli/cli-option.h.
4133         (user_set_backtrace_options): New.
4134         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4135         Delete.
4136         (get_prev_frame): Adjust.
4137         (boolean_option_def, uinteger_option_def)
4138         (set_backtrace_option_defs): New.
4139         (_initialize_frame): Adjust and use
4140         gdb::option::add_setshow_cmds_for_options to install "set
4141         backtrace past-main" and "set backtrace past-entry".
4142         * frame.h: Include "cli/cli-option.h".
4143         (struct frame_print_options): Forward declare.
4144         (print_frame_arguments_all, print_frame_arguments_scalars)
4145         (print_frame_arguments_none): Declare.
4146         (print_entry_values): Delete declaration.
4147         (struct frame_print_options, user_frame_print_options): New.
4148         (struct set_backtrace_options): New.
4149         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4150         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4151         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4152         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4153         (list_args_or_locals): Add frame_print_options parameter.
4154         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4155         * python/py-framefilter.c (enumerate_args): Pass down
4156         USER_FRAME_PRINT_OPTIONS.
4157         * stack.c: Include "cli/cli-option.h".
4158         (print_frame_arguments_all, print_frame_arguments_scalars)
4159         (print_frame_arguments_none): Declare.
4160         (print_raw_frame_arguments, print_entry_values): Delete.
4161         (user_frame_print_options): New.
4162         (boolean_option_def, enum_option_def, frame_print_option_defs):
4163         New.
4164         (struct backtrace_cmd_options): New.
4165         (bt_flag_option_def): New.
4166         (backtrace_command_option_defs): New.
4167         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4168         (print_frame_arg, read_frame_arg, print_frame_args)
4169         (print_frame_info, print_frame): Add frame_print_options parameter
4170         and use it.
4171         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4172         (backtrace_command_1): Add frame_print_options and
4173         backtrace_cmd_options parameters and use them.
4174         (make_backtrace_options_def_group): New.
4175         (backtrace_command): Process command options with
4176         gdb::option::process_options.
4177         (backtrace_command_completer): New.
4178         (_initialize_stack): Extend "backtrace"'s help to mention
4179         supported options.  Install completer for "backtrace".
4180         Install some settings commands with add_setshow_cmds_for_options.
4181
4182 2019-06-13  Pedro Alves  <palves@redhat.com>
4183
4184         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4185         and that "set/show print raw frame-arguments" are now deprecated.
4186
4187         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4188         command.
4189         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4190         * stack.c (_initialize_stack): Install "set/show print
4191         raw-frame-arguments", and deprecate "set/show print raw
4192         frame-arguments".
4193         * valprint.c (_initialize_valprint): Deprecate "set/show print
4194         raw".
4195
4196 2019-06-13  Pedro Alves  <palves@redhat.com>
4197
4198         * compile/compile.c (struct compile_options): New.
4199         (compile_flag_option_def, compile_command_option_defs)
4200         (make_compile_options_def_group): New.
4201         (compile_file_command): Handle options with
4202         gdb::option::process_options.
4203         (compile_file_command_completer): New function.
4204         (compile_code_command): Handle options with
4205         gdb::option::process_options.
4206         (compile_code_command_completer): New function.
4207         (_initialize_compiler): Install completers for "compile code" and
4208         "compile file".  Mention available options in "compile code" and
4209         "compile code"'s help.
4210         * completer.c (advance_to_completion_word): New, factored out from
4211         ...
4212         (advance_to_expression_complete_word_point): ... this.
4213         (advance_to_filename_complete_word_point): New.
4214         * completer.h (advance_to_filename_complete_word_point): New
4215         declaration.
4216
4217 2019-06-13  Pedro Alves  <palves@redhat.com>
4218
4219         * compile/compile.c: Include "cli/cli-option.h".
4220         (compile_print_value): Scope data pointer is now a
4221         value_print_options pointer; adjust.
4222         (compile_print_command): Process options.  Scope data pointer is
4223         now a value_print_options pointer; adjust.
4224         (_initialize_compile): Update "compile print"'s help to include
4225         supported options.  Install a completer for "compile print".
4226         * cp-valprint.c (show_vtblprint, show_objectprint)
4227         (show_static_field_print): Delete.
4228         (_initialize_cp_valprint): Don't install "set print
4229         static-members", "set print vtbl", "set print object" here.
4230         * printcmd.c: Include "cli/cli-option.h" and
4231         "common/gdb_optional.h".
4232         (print_command_parse_format): Rework to fill in a
4233         value_print_options instead of a format_data.
4234         (print_value): Change parameter type from format_data pointer to
4235         value_print_options reference.  Adjust.
4236         (print_command_1): Process options.  Adjust to pass down a
4237         value_print_options.
4238         (print_command_completer): New.
4239         (_initialize_printcmd): Install print_command_completer as
4240         handle_brkchars completer for the "print" command.  Update
4241         "print"'s help to include supported options.
4242         * valprint.c: Include "cli/cli-option.h".
4243         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4244         here from cp-valprint.c.
4245         (boolean_option_def, uinteger_option_def)
4246         (value_print_option_defs, make_value_print_options_def_group):
4247         New.  Use gdb::option::add_setshow_cmds_for_options to install
4248         "set print elements", "set print null-stop", "set print repeats",
4249         "set print pretty", "set print union", "set print array", "set
4250         print address", "set print symbol", "set print array-indexes".
4251         * valprint.h: Include <string> and "cli/cli-option.h".
4252         (make_value_print_options_def_group): Declare.
4253         (print_value): Change parameter type from format_data pointer to
4254         value_print_options reference.
4255         (print_command_completer): Declare.
4256
4257 2019-06-13  Pedro Alves  <palves@redhat.com>
4258
4259         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4260         (COMMON_SFILES): Add maint-test-settings.c.
4261         * cli/cli-decode.c (boolean_enums): New global, factored out from
4262         ...
4263         (add_setshow_boolean_cmd): ... here.
4264         * cli/cli-decode.h (boolean_enums): Declare.
4265         * cli/cli-option.c: New file.
4266         * cli/cli-option.h: New file.
4267         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4268         factored out from ...
4269         (parse_cli_boolean_value(const char *)): ... this.
4270         (is_unlimited_literal): Change parameter type to pointer to
4271         pointer.  Adjust and advance ARG pointer.
4272         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4273         (parse_cli_var_enum): New, factored out from ...
4274         (do_set_command): ... this.  Adjust.
4275         * cli/cli-setshow.h (parse_cli_boolean_value)
4276         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4277         (parse_cli_var_enum): Declare.
4278         * cli/cli-utils.c: Include "cli/cli-option.h".
4279         (get_ulongest): New.
4280         * cli/cli-utils.h (get_ulongest): Declare.
4281         (check_for_argument): New overloads.
4282         * maint-test-options.c: New file.
4283
4284 2019-06-13  Pedro Alves  <palves@redhat.com>
4285
4286         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4287         parse a range if "-" is at the end of the string.
4288
4289 2019-06-13  Pedro Alves  <palves@redhat.com>
4290
4291         * cli/cli-setshow.c (parse_auto_binary_operation)
4292         (parse_cli_boolean_value): Don't allow "o".
4293
4294 2019-06-13  Pedro Alves  <palves@redhat.com>
4295
4296         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4297         * NEWS: Mention maint test-settings KIND.
4298         * maint-test-settings.c: New file.
4299
4300 2019-06-13  Pedro Alves  <palves@redhat.com>
4301
4302         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4303         completer.
4304         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4305         "set" completers.
4306
4307 2019-06-13  Pedro Alves  <palves@redhat.com>
4308
4309         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4310         after item.
4311
4312 2019-06-13  Pedro Alves  <palves@redhat.com>
4313
4314         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4315
4316 2019-06-13  Pedro Alves <palves@redhat.com>
4317
4318         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4319         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4320         call.
4321         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4322         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4323         calls.
4324         (check_for_argument): Skip spaces after argument.
4325
4326 2019-06-13  Pedro Alves  <palves@redhat.com>
4327
4328         * thread.c (thread_apply_command): Adjust TID parsing.
4329         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4330         detected before end of string.
4331         (tid_is_in_list): Error out if LIST is invalid.
4332
4333 2019-06-13  Pedro Alves  <palves@redhat.com>
4334
4335         * completer.c (complete_line_internal_1): Rewind completion word
4336         point.
4337         (completion_tracker::advance_custom_word_point_by): Change
4338         parameter type to int.
4339         * completer.h (completion_tracker::advance_custom_word_point_by):
4340         Likewise.
4341
4342 2019-06-13  Pedro Alves  <palves@redhat.com>
4343
4344         * completer.c (advance_to_completion_word): Handle delimiters.
4345
4346 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4347
4348         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4349
4350 2019-06-11  Tom Tromey  <tom@tromey.com>
4351
4352         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4353         (xmalloc_failed): Move to alloc.c.
4354         * alloc.c: New file.
4355         * Makefile.in (COMMON_SFILES): Add alloc.c.
4356
4357 2019-06-11  Tom Tromey  <tom@tromey.com>
4358
4359         * nat/linux-waitpid.c: Don't include server.h.
4360         (linux_debug): Remove.
4361         (my_waitpid): Update.
4362
4363 2019-06-11  Tom Tromey  <tromey@adacore.com>
4364
4365         * infcall.c (_initialize_infcall): Remove trailing newline from
4366         help.
4367         * user-regs.c (_initialize_user_regs): Remove trailing newline
4368         from help.
4369         * typeprint.c (_initialize_typeprint): Remove trailing newline
4370         from help.
4371         * reverse.c (_initialize_reverse): Remove trailing newlines from
4372         help.
4373         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4374         from help.
4375         * language.c (add_set_language_command): Remove trailing newline
4376         from help.
4377         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4378         help.
4379         * disasm.c (_initialize_disasm): Remove trailing newline from
4380         help.
4381         * top.c (init_main): Remove trailing newline from help.
4382         * interps.c (_initialize_interpreter): Remove trailing newline
4383         from help.
4384         * btrace.c (_initialize_btrace): Remove trailing newlines from
4385         help.
4386         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4387         from help.
4388         * python/python.c (_initialize_python): Remove trailing newline
4389         from help.
4390         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4391         help.
4392         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4393         from help.  Reformat some text.
4394         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4395         from help.
4396         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4397         newline from help.
4398
4399 2019-06-11  Tom Tromey  <tromey@adacore.com>
4400
4401         * darwin-nat.c (darwin_decode_exception_message)
4402         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4403
4404 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4405
4406         * valops.c (value_slice): Check for not allocated or not
4407         associated values.
4408
4409 2019-06-10  Tom de Vries  <tdevries@suse.de>
4410
4411         PR gdb/24618
4412         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4413         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4414         invalid.
4415
4416 2019-06-10  Tom de Vries  <tdevries@suse.de>
4417
4418         PR gdb/24611
4419         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4420         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4421
4422 2019-06-10  Tom de Vries  <tdevries@suse.de>
4423
4424         PR symtab/24545
4425         * symtab.c (struct demangled_name_entry): Add language field.
4426         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4427         static minimal symbol".  Set and use language field.
4428
4429 2019-06-10  Tom Tromey  <tromey@adacore.com>
4430
4431         * ada-lang.c (_initialize_ada_language): Update help text.
4432
4433 2019-06-10  Tom Tromey  <tromey@adacore.com>
4434
4435         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4436         with a newline.
4437         * guile/guile.c (handle_boot_error): Don't end warning with a
4438         newline.
4439         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4440         warning with a newline.
4441         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4442         newline.
4443         (s12z_frame_cache): Likewise.
4444         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4445         a newline.
4446         * solib-svr4.c (disable_probes_interface): Don't end warning with
4447         a newline.
4448         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4449         newline.
4450         * python/python.c (do_finish_initialization): Don't end warning
4451         with a newline.
4452
4453 2019-06-10  Tom Tromey  <tom@tromey.com>
4454
4455         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4456         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4457         gdbpy_enter.
4458
4459 2019-06-10  Tom Tromey  <tromey@adacore.com>
4460
4461         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4462         data.
4463         (elf_new_init): Don't call stabsread_new_init.
4464         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4465         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4466         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4467
4468 2019-06-10  Tom de Vries  <tdevries@suse.de>
4469
4470         PR symtab/16264
4471         PR symtab/24517
4472         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4473
4474 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4475
4476         * source.c (find_and_open_source): Also rewrite relative file
4477         names.
4478
4479 2019-04-26  Amos Bird  <amosbird@gmail.com>
4480
4481         * annotate.c (annotate_thread_exited): Add "thread-exited"
4482         annotation.
4483
4484 2019-06-06  Tom Tromey  <tromey@adacore.com>
4485
4486         * maint.h (class scoped_command_stats): Use
4487         DISABLE_COPY_AND_ASSIGN.
4488         <print_time>: New method.
4489         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4490         print_time.
4491         (scoped_command_stats::print_time): New method.
4492
4493 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4494
4495         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4496         instructions of lengths 6 or 8 bytes.
4497
4498 2019-06-04  Pedro Alves  <palves@redhat.com>
4499
4500         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4501
4502         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4503         * breakpoint.c (condition_completer): Likewise.
4504         * cli/cli-dump.c (scan_expression): Likewise.
4505         * common/filestuff.c (mkdir_recursive): Likewise.
4506         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4507         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4508         (gdb_abspath): Likewise.
4509         * compile/compile-cplus-types.c
4510         (compile_cplus_instance::decl_name): Likewise.
4511         * completer.c (complete_explicit_location):
4512         (signal_completer, reg_or_group_completer_1): Likewise.
4513         * cp-support.c (cp_remove_params_if_any): Likewise.
4514         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4515         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4516         * infcmd.c (strip_bg_char): Likewise.
4517         * linespec.c (copy_token_string): Likewise.
4518         * mi/mi-main.c (output_cores): Likewise.
4519         * psymtab.c (psymtab_search_name):
4520         * symfile.c (test_set_ext_lang_command): Likewise.
4521         * target.c (target_fileio_read_stralloc): Likewise.
4522         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4523         * value.c (complete_internalvar): Likewise.
4524
4525 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4526
4527         Add objfile property to gdb.Type.
4528         * NEWS: Mention Python API addition.
4529         * python/py-type.c (typy_get_objfile): New method.
4530
4531 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4532
4533         * NEWS: Mention the new set|show style [title|highlight].
4534         Mention changes to "show style", "help" and "apropos".
4535
4536 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4537
4538         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4539         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4540         instead of print_help_for_command.
4541         (print_doc_of_command): New function.
4542         (help_list): Add 'apropos -v word' suggestion.
4543         (print_help_for_command): Style the command name using title style.
4544         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4545         (_initialize_cli_cmds): Describe -v in apropos_command help.
4546
4547 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4548
4549         * cli/cli-style.h (cli_style_option): Add name in constructor,
4550         add m_name class member, add constructor with intensity,
4551         add name class function.
4552         (cli_style_option::add_setshow_commands): Remove name argument.
4553         (highlight_style, title_style): New styles.
4554         * cli/cli-style.c (do_show): New function that shows a style
4555         characteristic styling the style name with itself.
4556         (set_style_name): New function.
4557         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4558         Update all callers according to the changes in cli/cli-style.h.
4559         * utils.h (fputs_highlighted): New function.
4560         * utils.c (fputs_highlighted): Likewise.
4561
4562 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4563
4564         * NEWS: Mention new pipe command and new convenience variables.
4565
4566 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4567
4568         * cli/cli-cmds.c (pipe_command): New function.
4569         (_initialize_cli_cmds): Call add_com for pipe_command.
4570         Define | as an alias for pipe.
4571         (exit_status_set_internal_vars): New function.
4572         (shell_escape): Call exit_status_set_internal_vars.
4573         cli/cli-decode.c (find_command_name_length): Recognize | as
4574         a single character command.
4575
4576 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4577
4578         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4579         top.c (execute_command_to_ui_file): New function, mostly a copy
4580         of execute_command_to_string.
4581         (execute_command_to_string): Implement by calling
4582         execute_command_to_ui_file.
4583
4584 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4585
4586         * top.h (saved_command_line): Remove declaration.
4587         * top.c (previous_saved_command_line, previous_repeat_arguments):
4588         New variables.
4589         (saved_command_line): Make static, define together with other
4590         'repeat variables'.
4591         (dont_repeat): Clear repeat_arguments.
4592         (repeat_previous, get_saved_command_line, save_command_line):
4593         New functions.
4594         (gdb_init): Initialize saved_command_line
4595         and previous_saved_command_line.
4596         * main.c (captured_main_1): Remove saved_command_line initialization.
4597         * event-top.c (handle_line_of_input): Update to use
4598         the new 'repeat' related functions instead of direct access to
4599         saved_command_line.
4600         * command.h (repeat_previous, get_saved_command_line,
4601         save_command_line): New declarations.
4602         (dont_repeat): Add comment.
4603
4604 2019-05-30  Tom Tromey  <tromey@adacore.com>
4605
4606         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4607         Fix comment.
4608         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4609
4610 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4611
4612         PR cli/24587
4613         * completer.c (complete): Initialize variable word.
4614
4615 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4616
4617         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4618         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4619         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4620         'body' is NULL to the outter 'if', protecting the '!is_define'
4621         situation as well.
4622
4623 2019-05-29  Tom Tromey  <tromey@adacore.com>
4624
4625         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4626         (dwarf_unknown): New function.
4627         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4628         (dwarf_type_encoding_name): Use dwarf_unknown.
4629
4630 2019-05-29  Tom Tromey  <tromey@adacore.com>
4631
4632         PR c++/20020:
4633         * cp-valprint.c (cp_print_value_fields): Call
4634         cp_print_static_field inside "try".
4635
4636 2019-05-29  Tom Tromey  <tromey@adacore.com>
4637
4638         * inflow.c (struct terminal_info): Add default operator=.
4639         * configure: Rebuild.
4640         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4641         -Wdeprecated-copy-dtor, -Wredundant-move.
4642
4643 2019-05-29  Tom Tromey  <tromey@adacore.com>
4644
4645         * NEWS: Add entry.
4646         * infcmd.c (print_return_value_1): Handle finish_print
4647         option.
4648         (show_print_finish): New function.
4649         (_initialize_infcmd): Add "set/show print finish" commands.
4650         * valprint.c (user_print_options): Initialize new member.
4651         * valprint.h (struct value_print_options) <finish_print>: New
4652         member.
4653
4654 2019-05-28  Tom Tromey  <tromey@adacore.com>
4655
4656         * ada-lang.c (ada_remove_Xbn_suffix)
4657         (find_old_style_renaming_symbol)
4658         (parse_old_style_renaming): Remove.
4659         (ada_find_renaming_symbol): Don't call
4660         find_old_style_renaming_symbol.
4661         (ada_is_renaming_symbol): Rename from
4662         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4663         bool.  Now static.
4664         (ada_read_var_value): Update and simplify.
4665         * ada-exp.y (write_var_or_type): Remove old code.
4666
4667 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4668
4669         * event-top.c: Remove include comment.
4670         * inflow.c (class scoped_ignore_sigttou): Move from here...
4671         * inflow.h (class scoped_ignore_sigttou): ...to here.
4672         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4673         * top.c:  Remove include comment.
4674
4675 2019-05-27  Tom Tromey  <tom@tromey.com>
4676
4677         * NEWS: Fix typo.
4678
4679 2019-05-22  Tom Tromey  <tromey@adacore.com>
4680
4681         * target.c (target_follow_exec): Constify parameter.
4682         * target-delegates.c: Rebuild.
4683         * remote.c (remote_target::follow_exec): Constify parameter.
4684         * infrun.c (follow_exec): Constify parameter.
4685         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4686         (target_follow_exec): Likewise.
4687
4688 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4689
4690         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4691         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4692
4693 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4694
4695         * NEWS: Add debugredirect and testsuite sections.
4696
4697 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4698
4699         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4700         target descriptions using exclusively floating point register name
4701         aliases.
4702
4703 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4704
4705         PR gdb/18644:
4706         * f-lang.c (build_fortran_types): Handle the case where
4707         gdbarch_floatformat_for_type returns a nullptr.
4708
4709 2019-05-21  Tom de Vries  <tdevries@suse.de>
4710
4711         PR cli/24587
4712         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4713
4714 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4715
4716         PR gdb/18644:
4717         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4718         16-byte floats.
4719         * i386-tdep.c (i386_floatformat_for_type): Use
4720         floatformats_ia64_quad for the 16-byte floating point component
4721         within a fortran 32-byte complex number.
4722
4723 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4724
4725         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4726         delete default constructor.
4727         (find_partial_die): Update to return const struct.
4728         (partial_die_parent_scope): Move variable declaration into scope
4729         of its use and change its type to auto.
4730         (guess_partial_die_structure_name): Likewise.
4731         (partial_die_info::fixup): Likewise.
4732
4733 2019-05-17  Tom Tromey  <tromey@adacore.com>
4734
4735         * source.c (find_and_open_source): Remove cast.
4736
4737 2019-05-17  Tom Tromey  <tromey@adacore.com>
4738
4739         * annotate.c (annotate_source): Make "filename" const.
4740         * annotate.h (annotate_source): Use const.
4741
4742 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4743
4744         * disasm.c (set_disassembler_options): Send errors to stderr.
4745
4746 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4747
4748         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4749         (cli_interp_base::set_logging): Check debug_redirect.
4750         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4751         * cli/cli-logging.c (debug_redirect): Add static variable.
4752         (pop_output_files): Add default param.
4753         (handle_redirections): Print debug setting.
4754         (show_logging_command): Likewise.
4755         (_initialize_cli_logging): Add debugredirect command.
4756         * interps.c (current_interp_set_logging): Add debug_redirect
4757         parameter.
4758         * interps.h (set_logging): Add debug_redirect parameter.
4759         (current_interp_set_logging): Likewise.
4760         * mi/mi-common.h: Likewise.
4761         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4762
4763 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4764             Tom Tromey  <tromey@adacore.com>
4765
4766         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4767         directly.
4768         * cli/cli-interp.h (make_logging_output): Remove declaration.
4769         * cli/cli-logging.c (make_logging_output): Remove function.
4770         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4771         directly.
4772         * ui-file.c (tee_file::tee_file): Remove bools.
4773         (tee_file::~tee_file): Remove deletes.
4774         * ui-file.h (tee_file): Remove bools.
4775
4776 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4777
4778         * mi/mi-cmds.h (mi_cmd_complete): New function.
4779         * mi/mi-main.c (mi_cmd_complete): Likewise.
4780         * mi/mi-cmds.c: Define new MI command -complete.
4781         * NEWS: Mention new -complete command.
4782
4783 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4784
4785         * completer.h (complete): New function.
4786         * completer.c (complete): Likewise.
4787         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4788         function defined in completer.h.
4789
4790 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4791
4792         * MAINTAINERS (Write After Approval): Add myself.
4793
4794 2019-05-17  Tom de Vries  <tdevries@suse.de>
4795
4796         PR gdb/24094
4797         * dwarf2read.c (struct cu_partial_die_info): New struct.
4798         (find_partial_die): Return cu_partial_die_info.
4799         (partial_die_parent_scope, guess_partial_die_structure_name)
4800         (partial_die_info::fixup): Handle new return type of find_partial_die.
4801
4802 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4803
4804         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4805         "std::string", simplifying the algorithm.
4806
4807 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4808
4809         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4810         (stap_static_probe_ops::get_probes): Likewise.
4811
4812 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4813
4814         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4815         '-')" and "else if".
4816         (stap_parse_single_operand): Join checks for
4817         "gdbarch_stap_parse_special_token_p" and
4818         "gdbarch_stap_parse_special_token" in the same "if" statement.
4819         Invert check when verifying for operation on register
4820         displacement.
4821
4822 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4823
4824         * stap-probe.c (stap_get_opcode): Update comment.
4825         (stap_get_expected_argument_type): Likewise.
4826         (handle_stap_probe): Likewise.
4827
4828 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4829
4830         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4831         return type to 'bool'.  Adjust comment.  Use 'bool' when
4832         appropriate.
4833         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4834         * stap-probe.c (stap_parse_argument_1): Likewise.
4835         (stap_is_operator): Likewise.
4836         (stap_is_generic_prefix): Likewise.
4837         (stap_is_register_prefix): Likewise.
4838         (stap_is_register_indirection_prefix): Likewise.
4839         (stap_is_integer_prefix): Likewise.
4840         (stap_generic_check_suffix): Likewise.
4841         (stap_check_integer_suffix): Likewise.
4842         (stap_check_register_suffix): Likewise.
4843         (stap_check_register_indirection_suffix): Likewise.
4844         (stap_parse_register_operand): Likewise.
4845         (stap_parse_single_operand): Likewise.
4846         (stap_parse_argument_1): Likewise.
4847         (stap_probe::get_argument_count): Likewise.
4848         (stap_is_operator): Likewise.
4849
4850 2019-05-16  Tom Tromey  <tromey@adacore.com>
4851
4852         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4853         keyword to foreach.
4854
4855 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4856
4857         * linux-thread-db.c (try_thread_db_load_1): Change return type
4858         to bool.
4859         (try_thread_db_load): Likewise.
4860         (try_thread_db_load_from_pdir_1): Likewise.
4861         (try_thread_db_load_from_pdir): Likewise.
4862         (try_thread_db_load_from_sdir): Likewise.
4863         (try_thread_db_load_from_dir): Likewise.
4864         (thread_db_load_search): Likewise.
4865         (has_libpthread): Likewise.
4866         (thread_db_load): Likewise.
4867
4868 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4869
4870         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4871         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4872         NULL, and complain/return if that's the case.
4873
4874 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4875
4876         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4877         (advance, posn, abstract_read_memory): New functions.
4878         [struct mem_read_abstraction]: New struct.
4879         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4880
4881 2019-05-14  Tom Tromey  <tromey@adacore.com>
4882
4883         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4884         value is not lval_memory.
4885
4886 2019-05-14  Tom Tromey  <tromey@adacore.com>
4887
4888         * solib.c (info_sharedlibrary_command): Style the file name.
4889
4890 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4891
4892         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4893         (aarch64_vnv_type): Likewise.
4894         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4895         * common/tdesc.c: Likewise.
4896         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4897         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4898         * features/aarch64-fpu.xml: Add ieee half view.
4899         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4900         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4901         * gdbtypes.h (struct builtin_type): Likewise.
4902         (struct objfile_type): Likewise.
4903
4904 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4905
4906         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4907         typo.
4908         * location.h (string_to_event_location): Likewise.
4909
4910 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4911
4912         GDB 8.3 released.
4913
4914 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4915
4916         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4917         New variable declaration.
4918         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4919         New variable.
4920         (print_one_breakpoint): Use ui_out::test_flags and new global
4921         variable to compute use_fixed_output.
4922         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4923         Remove.
4924         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4925         (mi_multi_location_breakpoint_output_fixed): Remove.
4926         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4927         new variable.
4928         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4929         fix_multi_location_breakpoint_output flag if version >= 3.
4930         * ui-out.h (enum ui_out_flag)
4931         <fix_multi_location_breakpoint_output>: New enumerator.
4932
4933 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4934
4935         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4936
4937 2019-05-10  Tom Tromey  <tromey@adacore.com>
4938
4939         * ada-lang.c (catch_ada_completer): New function.
4940         (_initialize_ada_language): Use it.
4941
4942 2019-05-10  Tom Tromey  <tromey@adacore.com>
4943
4944         * thread.c (print_thread_info): Make "requested_threads" const.
4945         * gdbthread.h (print_thread_info): Make "requested_threads"
4946         const.
4947         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4948         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4949
4950 2019-05-08  Tom Tromey  <tom@tromey.com>
4951
4952         * gdbtypes.c (objfile_type_data): Change type.
4953         (objfile_type, _initialize_gdbtypes): Update.
4954
4955 2019-05-08  Tom Tromey  <tom@tromey.com>
4956
4957         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4958         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4959         (_initialize_dwarf2_frame): Update.
4960
4961 2019-05-08  Tom Tromey  <tom@tromey.com>
4962
4963         * objc-lang.c (objc_objfile_data): Change type.
4964         (find_methods): Update.
4965         (_initialize_objc_lang): Remove.
4966
4967 2019-05-08  Tom Tromey  <tom@tromey.com>
4968
4969         * stabsread.c (rs6000_builtin_type_data): Change type.
4970         (rs6000_builtin_type, _initialize_stabsread): Update.
4971
4972 2019-05-08  Tom Tromey  <tom@tromey.com>
4973
4974         * mips-tdep.c (mips_pdr_data): Remove.
4975         (_initialize_mips_tdep): Update.
4976
4977 2019-05-08  Tom Tromey  <tom@tromey.com>
4978
4979         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4980         (hppa_init_objfile_priv_data, read_unwind_info)
4981         (find_unwind_entry, _initialize_hppa_tdep): Update.
4982
4983 2019-05-08  Tom Tromey  <tom@tromey.com>
4984
4985         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4986         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4987         on obstack.
4988         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4989
4990 2019-05-08  Tom Tromey  <tom@tromey.com>
4991
4992         * mdebugread.c (basic_type_data): Change type.
4993         (basic_type, _initialize_mdebugread): Update.
4994
4995 2019-05-08  Tom Tromey  <tom@tromey.com>
4996
4997         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4998
4999 2019-05-08  Tom Tromey  <tom@tromey.com>
5000
5001         * nto-tdep.c (nto_inferior_data_reg): Change type.
5002         (nto_inferior_data): Update.
5003         (nto_inferior_data_cleanup, nto_new_inferior_data)
5004         (_initialize_nto_tdep): Remove.
5005         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5006
5007 2019-05-08  Tom Tromey  <tom@tromey.com>
5008
5009         * ada-lang.c (struct ada_inferior_data): Add initializers.
5010         (ada_inferior_data): Change type.
5011         (ada_inferior_data_cleanup): Remove.
5012         (get_ada_inferior_data, ada_inferior_exit)
5013         (struct ada_pspace_data): Add initializers, destructor.
5014         (ada_pspace_data_handle): Change type.
5015         (get_ada_pspace_data): Update.
5016         (ada_pspace_data_cleanup): Remove.
5017
5018 2019-05-08  Tom Tromey  <tom@tromey.com>
5019
5020         * coffread.c (struct coff_symfile_info): Add initializers.
5021         (coff_objfile_data_key): Move lower.  Change type.
5022         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5023         Update.
5024         (coff_free_info): Remove.
5025
5026 2019-05-08  Tom Tromey  <tom@tromey.com>
5027
5028         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5029         (fbsd_pspace_data_handle): Move lower.  Change type.
5030         (get_fbsd_pspace_data): Update.
5031         (fbsd_pspace_data_cleanup): Remove.
5032         (_initialize_fbsd_tdep): Update.
5033
5034 2019-05-08  Tom Tromey  <tom@tromey.com>
5035
5036         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5037         (get_ada_tasks_pspace_data): Update.
5038         (ada_tasks_pspace_data_cleanup): Remove.
5039         (_initialize_tasks): Update.
5040         (ada_tasks_inferior_data_handle): Change type.
5041         (get_ada_tasks_inferior_data): Update.
5042         (ada_tasks_inferior_data_cleanup): Remove.
5043         (struct ada_tasks_pspace_data): Add initializers.
5044
5045 2019-05-08  Tom Tromey  <tom@tromey.com>
5046
5047         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5048         * symfile-debug.c (debug_sym_get_probes): Change type.
5049         * stap-probe.c (handle_stap_probe):
5050         (stap_static_probe_ops::get_probes): Change type.
5051         * probe.h (class static_probe_ops) <get_probes>: Change type.
5052         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5053         (parse_probes_in_pspace): Update.
5054         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5055         Update.
5056         (any_static_probe_ops::get_probes): Change type.
5057         * elfread.c (elfread_data): New typedef.
5058         (probe_key): Change type.
5059         (elf_get_probes): Likewise.  Update.
5060         (probe_key_free): Remove.
5061         (_initialize_elfread): Update.
5062         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5063         Change type.
5064         (dtrace_process_dof_probe, dtrace_process_dof)
5065         (dtrace_static_probe_ops::get_probe): Change type.
5066
5067 2019-05-08  Tom Tromey  <tom@tromey.com>
5068
5069         * xcoffread.c (struct xcoff_symfile_info): Rename from
5070         coff_symfile_info.  Add initializers.
5071         (xcoff_objfile_data_key): Move lower.  Change type.
5072         (XCOFF_DATA): Rewrite.
5073         (xcoff_free_info): Remove.
5074         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5075         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5076         (xcoff_initial_scan): Update.
5077
5078 2019-05-08  Tom Tromey  <tom@tromey.com>
5079
5080         * solib-svr4.c (struct svr4_info): Add initializers and
5081         destructor.
5082         <probes_table>: Now an htab_up.
5083         (solib_svr4_pspace_data): Change type.
5084         (free_probes_table): Simplify.
5085         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5086         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5087         (probes_table_remove_objfile_probes, register_solib_event_probe)
5088         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5089         (_initialize_svr4_solib): Update.
5090
5091 2019-05-08  Tom Tromey  <tom@tromey.com>
5092
5093         * remote.c (remote_pspace_data): Change type.
5094         (remote_pspace_data_cleanup): Remove.
5095         (get_remote_exec_file, set_pspace_remote_exec_file)
5096         (_initialize_remote): Update.
5097
5098 2019-05-08  Tom Tromey  <tom@tromey.com>
5099
5100         * breakpoint.c (breakpoint_objfile_key): Change type.
5101         (get_breakpoint_objfile_data): Update.
5102         (free_breakpoint_objfile_data): Remove.
5103         (_initialize_breakpoint): Update.
5104
5105 2019-05-08  Tom Tromey  <tom@tromey.com>
5106
5107         * linux-tdep.c (struct linux_info): Add initializers.
5108         (linux_inferior_data): Move.  Change type.
5109         (invalidate_linux_cache_inf): Update.
5110         (linux_inferior_data_cleanup): Remove.
5111         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5112
5113 2019-05-08  Tom Tromey  <tom@tromey.com>
5114
5115         * auxv.c (auxv_inferior_data): Move.  Change type.
5116         (auxv_inferior_data_cleanup): Remove.
5117         (invalidate_auxv_cache_inf): Rewrite.
5118         (get_auxv_inferior_data, _initialize_auxv): Update.
5119
5120 2019-05-08  Tom Tromey  <tom@tromey.com>
5121
5122         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5123         (symfile_debug_objfile_data_key): Change type.
5124         (symfile_debug_installed, debug_qf_has_symbols)
5125         (debug_qf_find_last_source_symtab)
5126         (debug_qf_forget_cached_source_info)
5127         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5128         (debug_qf_print_stats, debug_qf_dump)
5129         (debug_qf_expand_symtabs_for_function)
5130         (debug_qf_expand_all_symtabs)
5131         (debug_qf_expand_symtabs_with_fullname)
5132         (debug_qf_map_matching_symbols)
5133         (debug_qf_expand_symtabs_matching)
5134         (debug_qf_find_pc_sect_compunit_symtab)
5135         (debug_qf_map_symbol_filenames)
5136         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5137         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5138         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5139         (debug_sym_read_linetable, debug_sym_relocate): Update.
5140         (symfile_debug_free_objfile): Remove.
5141         (install_symfile_debug_logging, _initialize_symfile_debug):
5142         Update.
5143
5144 2019-05-08  Tom Tromey  <tom@tromey.com>
5145
5146         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5147         allocate_on_obstack.
5148         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5149         (get_dwarf2_per_objfile): Update.
5150         (set_dwarf2_per_objfile): Remove.
5151         (dwarf2_has_info, dwarf2_get_section_info): Update.
5152         (dwarf2_free_objfile): Remove.
5153         (_initialize_dwarf2_read): Update.
5154
5155 2019-05-08  Tom Tromey  <tom@tromey.com>
5156
5157         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5158         initializers.
5159         <unsupported_script_warning_printed,
5160         script_not_found_warning_printed>: Now bool.
5161         (auto_load_pspace_data): Change type.
5162         (~auto_load_pspace_info): Rename from
5163         auto_load_pspace_data_cleanup.
5164         (get_auto_load_pspace_data, init_loaded_scripts_info)
5165         (clear_section_scripts, maybe_print_unsupported_script_warning)
5166         (maybe_print_script_not_found_warning, _initialize_auto_load):
5167         Update.
5168
5169 2019-05-08  Tom Tromey  <tom@tromey.com>
5170
5171         * objfiles.c (objfile_pspace_info): Add destructor and
5172         initializers.
5173         (objfiles_pspace_data): Change type.
5174         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5175         (get_objfile_pspace_data): Update.
5176         (objfiles_bfd_data): Change type.
5177         (get_objfile_bfd_data): Update.
5178         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5179
5180 2019-05-08  Tom Tromey  <tom@tromey.com>
5181
5182         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5183         Change type.
5184         (get_catch_syscall_inferior_data): Update.
5185         (catch_syscall_inferior_data_cleanup): Remove.
5186         (_initialize_break_catch_syscall): Update.
5187
5188 2019-05-08  Tom Tromey  <tom@tromey.com>
5189
5190         * inflow.c (struct terminal_info): Add destructor and
5191         initializers.
5192         (inflow_inferior_data): Change type.
5193         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5194         (get_inflow_inferior_data, inflow_inferior_exit)
5195         (swap_terminal_info, _initialize_inflow): Update.
5196
5197 2019-05-08  Tom Tromey  <tom@tromey.com>
5198
5199         * target-dcache.c (target_dcache_cleanup): Remove.
5200         (target_dcache_aspace_key): Change type.
5201         (target_dcache_init_p, target_dcache_invalidate)
5202         (target_dcache_get, target_dcache_get_or_init)
5203         (_initialize_target_dcache): Update.
5204         * dcache.h (struct dcache_deleter): New.
5205
5206 2019-05-08  Tom Tromey  <tom@tromey.com>
5207
5208         * symtab.c (struct symbol_cache): Add destructor and
5209         initializers.
5210         (symbol_cache_key): Move.  Change type.
5211         (make_symbol_cache, free_symbol_cache): Remove.
5212         (get_symbol_cache): Update.
5213         (symbol_cache_cleanup): Remove.
5214         (ALL_PSPACES, symbol_cache_flush)
5215         (maintenance_print_symbol_cache)
5216         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5217         Update.
5218
5219 2019-05-08  Tom Tromey  <tom@tromey.com>
5220
5221         * symtab.c (struct main_info): Add destructor and initializers.
5222         (main_progspace_key): Move.  Change type.
5223         (get_main_info): Update.
5224         (main_info_cleanup): Remove.
5225         (_initialize_symtab): Update.
5226
5227 2019-05-08  Tom Tromey  <tom@tromey.com>
5228
5229         * registry.h (DECLARE_REGISTRY): Define the _key class.
5230
5231 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5232
5233         * NEWS: Merge two 'New commands' sections.
5234
5235 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5236
5237         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5238         parameter and use Ada language definition instead.
5239         (ada_val_print_ptr): Remove unused language parameter.
5240         (ada_val_print_num): Remove language parameter and use Ada language
5241         definition instead.
5242         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5243         parameter.
5244         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5245         parameter and use Ada language definition instead.
5246         (ada_val_print_1): Update all ada_val_print_xxx calls.
5247         Remove language parameter.
5248         (ada_val_print): Update ada_val_print_1 call.
5249
5250 2019-05-08  Tom Tromey  <tromey@adacore.com>
5251
5252         * remote.c (remote_hw_watchpoint_limit)
5253         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5254         Now static.
5255
5256 2019-05-08  Tom Tromey  <tromey@adacore.com>
5257
5258         * maint.c (_initialize_maint_cmds): Move initialization code to
5259         remote.c.
5260         (watchdog, show_watchdog): Move to remote.c.
5261         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5262         "watchdog" static.
5263         (_initialize_remote): Move initialization code from maint.c.
5264         * defs.h (watchdog): Don't declare.
5265
5266 2019-05-08  Tom Tromey  <tromey@adacore.com>
5267
5268         * tui/tui-interp.c: Include main.h.
5269         * interps.c: Include main.h.
5270         * main.h (interpreter_p): Declare.
5271         * defs.h (interpreter_p): Don't declare.
5272
5273 2019-05-08  Tom Tromey  <tromey@adacore.com>
5274
5275         * dwarf2loc.c: Include dwarf2read.h.
5276         * defs.h (read_unsigned_leb128): Don't declare.
5277         * dwarf2read.h (read_unsigned_leb128): Declare.
5278
5279 2019-05-08  Tom Tromey  <tromey@adacore.com>
5280
5281         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5282         method.
5283
5284 2019-05-08  Tom Tromey  <tromey@adacore.com>
5285
5286         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5287         when no wrap column is set.
5288
5289 2019-05-08  Tom Tromey  <tromey@adacore.com>
5290
5291         * c-lang.c (c_get_string): Handle non-C-style arrays.
5292
5293 2019-05-08  Tom Tromey  <tromey@adacore.com>
5294
5295         * typeprint.c (print_offset_data::update): Print the bit offset,
5296         not the number of bits remaining.
5297
5298 2019-05-08  Tom Tromey  <tromey@adacore.com>
5299
5300         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5301         padding at end of comment.
5302
5303 2019-05-08  Tom Tromey  <tromey@adacore.com>
5304
5305         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5306         Compare main types.
5307
5308 2019-05-06  Tom Tromey  <tom@tromey.com>
5309
5310         * common/scoped_mmap.c: Include common-defs.h.
5311         * common/scoped_mmap.h: Don't include config.h.
5312
5313 2019-05-04  Tom Tromey  <tom@tromey.com>
5314
5315         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5316         (struct aarch64_call_info): Add initializers.
5317         <si>: Now a std::vector.
5318         (pass_on_stack, aarch64_push_dummy_call): Update.
5319
5320 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5321             Tom Tromey  <tom@tromey.com>
5322
5323         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5324         (ppc_threads): Now a std::vector.  Now static.
5325         (hwdebug_find_thread_points_by_tid)
5326         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5327         Update.
5328
5329 2019-05-04  Tom Tromey  <tom@tromey.com>
5330
5331         * arc-tdep.c (arc_tdesc_init): Return bool.
5332
5333 2019-05-04  Tom Tromey  <tom@tromey.com>
5334
5335         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5336         Use gdb_assert_not_reached.
5337
5338 2019-05-04  Tom Tromey  <tom@tromey.com>
5339
5340         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5341         "false".
5342
5343 2019-05-04  Tom Tromey  <tom@tromey.com>
5344
5345         * arc-tdep.c (arc_tdesc_init): Use bool.
5346
5347 2019-05-04  Tom Tromey  <tom@tromey.com>
5348
5349         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5350
5351 2019-05-04  Tom Tromey  <tom@tromey.com>
5352
5353         * cli/cli-cmds.c (valid_command_p): Return bool.
5354
5355 2019-05-04  Tom Tromey  <tom@tromey.com>
5356
5357         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5358         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5359
5360 2019-05-04  Raul Tambre  <raul@tambre.ee>
5361
5362         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5363         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5364         operator for comparison.
5365
5366 2019-05-04  Tom Tromey  <tom@tromey.com>
5367
5368         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5369         (lookup_partial_symbol, print_partial_symbols)
5370         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5371         (psymbol_compare): Update.
5372         (add_psymbol_to_bcache): Clear the entire psymbol.
5373         (maintenance_check_psymtabs): Update.
5374         * psympriv.h (struct partial_symbol): Don't derive from
5375         general_symbol_info.
5376         <obj_section, unrelocated_address, address,
5377         set_unrelocated_address>: Update.
5378         <ginfo>: New member.
5379         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5380         (debug_names::write_psymbols): Update.
5381
5382 2019-05-04  Tom de Vries  <tdevries@suse.de>
5383
5384         * contrib/cc-with-tweaks.sh: Support -n arg.
5385
5386 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5387
5388         * corelow.c (core_target::detach): Ensure frame cache and
5389         register caches are cleared.
5390         inferior.c (exit_inferior_1): Likewise.
5391
5392 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5393             Tom Tromey  <tom@tromey.com>
5394
5395         * dictionary.c (collate_pending_symbols_by_language): Remove
5396         "struct" from foreach.
5397         * symtab.c (lookup_global_symbol_from_objfile)
5398         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5399         foreach.
5400         * ser-tcp.c (net_open): Remove "struct" from foreach.
5401         * objfiles.c (objfile_relocate, objfile_rebase)
5402         (objfile_has_symbols): Remove "struct" from foreach.
5403         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5404         from foreach.
5405         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5406         foreach.
5407         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5408         "struct" from foreach.
5409         * ada-lang.c (create_excep_cond_exprs)
5410         (ada_exception_catchpoint_cond_string): Remove "struct" from
5411         foreach.
5412
5413 2019-05-03  Tom Tromey  <tromey@adacore.com>
5414
5415         * ada-exp.y (convert_char_literal): Check suffix of each
5416         enumerator.
5417
5418 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5419
5420         PR ada/21406:
5421         * ada-exp.y (yywrap): Don't define.
5422         * ada-lex.l (%option): Add noyywrap
5423         (yywrap): Remove.
5424
5425 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5426
5427         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5428         _WIN32_WINNT to the XP level, unless already defined to a higher
5429         level.
5430
5431         * unittests/parse-connection-spec-selftests.c:
5432         * ser-tcp.c:
5433         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5434         override.
5435
5436         * symfile.c (find_separate_debug_file): Remove colon from the
5437         drive spec of DOS/Windows file names of the target, so that the
5438         file name produced from DEBUGDIR and the target's directory will
5439         be valid on DOS/Windows systems.
5440
5441 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5442
5443         * rust-lang.c (val_print_struct): Handle printing structures
5444         containing strings.
5445
5446 2019-05-02  Tom Tromey  <tromey@adacore.com>
5447
5448         * valarith.c (_initialize_valarith): Remove.
5449
5450 2019-05-01  Tom Tromey  <tromey@adacore.com>
5451
5452         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5453         bitfields.
5454
5455 2019-05-01  Tom Tromey  <tromey@adacore.com>
5456
5457         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5458         for big-endian copies.
5459
5460 2019-04-30  Ali Tamur  <tamur@google.com>
5461         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5462         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5463         (read_3_bytes): New function.
5464
5465 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5466
5467         * windows-nat.c (main_thread_id): Delete.
5468         (handle_output_debug_string): Replace main_thread_id by
5469         current_event.dwThreadId.
5470         (fake_create_process): Likewise.
5471         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5472         Do not set main_thread_id.
5473         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5474         current_event.dwThreadId.
5475         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5476
5477 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5478
5479         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5480         Use current_event.dwThreadId instead of main_thread_id.
5481
5482 2019-04-30  Tom Tromey  <tromey@adacore.com>
5483
5484         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5485         (create_excep_cond_exprs): Iterate over program spaces.
5486         (ada_exception_catchpoint_cond_string): Examine all minimal
5487         symbols for exception types.
5488
5489 2019-04-30  Tom Tromey  <tromey@adacore.com>
5490
5491         PR c++/24470:
5492         * dwarf2read.c (process_structure_scope): Handle case where type
5493         has template parameters but no symbol was created.
5494
5495 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5496             Chris January  <chris.january@arm.com>
5497
5498         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5499         qualifier.
5500         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5501
5502 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5503
5504         * f-typeprint.c (f_print_type): Update rules for printing
5505         whitespace.
5506         (f_type_print_varspec_suffix): Likewise.
5507
5508 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5509             Chris January  <chris.january@arm.com>
5510
5511         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5512         function arguments.
5513
5514 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5515
5516         * f-lang.c (build_fortran_types): Change name of void type to
5517         lower case.
5518         * f-typeprint.c (f_type_print_base): Print the name of the void
5519         type, rather than a fixed string.
5520         * f-valprint.c (f_decorations): Use lower case void string.
5521
5522 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5523             Chris January  <chris.january@arm.com>
5524
5525         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5526         types for Fortran.
5527
5528 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5529             Chris January  <chris.january@arm.com>
5530             David Lecomber  <david.lecomber@arm.com>
5531
5532         * f-exp.y (BINOP_INTRINSIC): New token.
5533         (exp): New parser rule handling BINOP_INTRINSIC.
5534         (f77_keywords): Add new builtin procedures.
5535         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5536         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5537         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5538         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5539         (print_unop_subexp_f): New function.
5540         (print_binop_subexp_f): New function.
5541         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5542         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5543         (dump_subexp_body_f): Likewise.
5544         (operator_check_f): Likewise.
5545         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5546         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5547
5548 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5549
5550         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5551         UNOP_KIND.
5552         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5553         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5554         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5555         (operator_length_f): New fuction.
5556         (print_subexp_f): New function.
5557         (op_name_f): New function.
5558         (dump_subexp_body_f): New function.
5559         (operator_check_f): New function.
5560         (exp_descriptor_f): Replace standard expression handling functions
5561         with new functions.
5562         * gdb/fortran-operator.def: New file.
5563         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5564         * gdb/std-operator.def: Remove UNOP_KIND.
5565
5566 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5567
5568         * std-operator.def: Remove unbalanced, stray double quote
5569         character.
5570
5571 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5572             Chris January  <chris.january@arm.com>
5573             Daniel Everett  <daniel.everett@arm.com>
5574             Nick Forrington  <nick.forrington@arm.com>
5575             Richard Bunt  <richard.bunt@arm.com>
5576
5577         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5578         of depth when printing anonymous structs or unions.
5579         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5580         Don't print either the top-level value, or the children if the
5581         max-depth is exceeded.
5582         (ppscm_print_children): When printing the key of a map, allow one
5583         extra level of depth.
5584         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5585         print either the top-level value, or the children if the max-depth
5586         is exceeded.
5587         (print_children): When printing the key of a map, allow one extra
5588         level of depth.
5589         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5590         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5591         (user_print_options): Initialise max_depth field.
5592         (val_print_scalar_or_string_type_p): New function.
5593         (val_print): Check to see if the max depth has been reached.
5594         (val_print_check_max_depth): Define new function.
5595         (show_print_max_depth): New function.
5596         (_initialize_valprint): Add 'print max-depth' option.
5597         * valprint.h (struct value_print_options) <max_depth>: New field.
5598         (val_print_check_max_depth): Declare new function.
5599         * NEWS: Document new feature.
5600
5601 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5602
5603         * ada-lang.c (ada_language_defn): Initialise new field.
5604         * c-lang.c (c_is_string_type_p): New function.
5605         (c_language_defn): Initialise new field.
5606         (cplus_language_defn): Initialise new field.
5607         (asm_language_defn): Initialise new field.
5608         (minimal_language_defn): Initialise new field.
5609         * c-lang.h (c_is_string_type_p): Declare new function.
5610         * d-lang.c (d_language_defn): Initialise new field.
5611         * f-lang.c (f_is_string_type_p): New function.
5612         (f_language_defn): Initialise new field.
5613         * go-lang.c (go_is_string_type_p): New function.
5614         (go_language_defn): Initialise new field.
5615         * language.c (default_is_string_type_p): New function.
5616         (unknown_language_defn): Initialise new field.
5617         (auto_language_defn): Initialise new field.
5618         * language.h (struct language_defn) <la_is_string_type_p>: New
5619         member variable.
5620         (default_is_string_type_p): Declare new function.
5621         * m2-lang.c (m2_language_defn): Initialise new field.
5622         * objc-lang.c (objc_language_defn): Initialise new field.
5623         * opencl-lang.c (opencl_language_defn): Initialise new field.
5624         * p-lang.c (pascal_is_string_type_p): New function.
5625         (pascal_language_defn): Initialise new field.
5626         * rust-lang.c (rust_is_string_type_p): New function.
5627         (rust_language_defn): Initialise new field.
5628
5629 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5630
5631         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5632         New field.
5633         * ada-lang.c (ada_language_defn): Initialise new field.
5634         * c-lang.c (c_language_defn): Likewise.
5635         (cplus_language_defn): Likewise.
5636         (asm_language_defn): Likewise.
5637         (minimal_language_defn): Likewise.
5638         * d-lang.c (d_language_defn): Likewise.
5639         * f-lang.c (f_language_defn): Likewise.
5640         * go-lang.c (go_language_defn): Likewise.
5641         * language.c (unknown_language_defn): Likewise.
5642         (auto_language_defn): Likewise.
5643         * m2-lang.c (m2_language_defn): Likewise.
5644         * objc-lang.c (objc_language_defn): Likewise.
5645         * opencl-lang.c (opencl_language_defn): Likewise.
5646         * p-lang.c (pascal_language_defn): Likewise.
5647         * rust-lang.c (rust_language_defn): Likewise.
5648
5649 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5650
5651         * ada-lang.c (ada_is_character_type): Change return type to bool.
5652         (ada_is_string_type): Likewise.
5653         * ada-lang.h (ada_is_character_type): Update declaration
5654         (ada_is_string_type): Likewise.
5655
5656 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5657
5658         Support style in 'frame|thread apply'
5659
5660         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5661         * record.c (record_start, record_stop): Update callers of
5662         execute_command_to_string with false.
5663         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5664         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5665         methods.
5666         (class string_file): New constructor with term_out parameter.
5667         Override methods term_out and can_emit_style_escape.  New member
5668         term_out.
5669         (class stdio_file): Override can_emit_style_escape.
5670         (class tee_file): Override term_out and can_emit_style_escape.
5671         * utils.h (can_emit_style_escape): Remove.
5672         * utils.c (can_emit_style_escape): Likewise.
5673         Update all callers of can_emit_style_escape (SOMESTREAM) to
5674         SOMESTREAM->can_emit_style_escape.
5675         * source-cache.c (source_cache::get_source_lines): Likewise.
5676         * stack.c (frame_apply_command_count): Call execute_command_to_string
5677         passing the term_out characteristic of the current gdb_stdout.
5678         * thread.c (thr_try_catch_cmd): Likewise.
5679         * top.c (execute_command_to_string): pass term_out parameter
5680         to construct the string_file for the command output.
5681         * ui-file.c (term_cli_styling): New function (most code moved
5682         from utils.c can_emit_style_escape).
5683         (string_file::string_file, string_file::can_emit_style_escape,
5684         stdio_file::can_emit_style_escape, tee_file::term_out,
5685         tee_file::can_emit_style_escape): New functions.
5686
5687 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5688
5689         * NEWS: Mention the new set|show may-call-functions.
5690         * infcall.c (may_call_functions_p): New variable.
5691         (show_may_call_functions_p): New function.
5692         (call_function_by_hand_dummy): Throws an error if not
5693         may-call-functions.
5694         (_initialize_infcall): Call add_setshow_boolean_cmd for
5695         may-call-functions.
5696
5697 2019-04-25  Keith Seitz  <keiths@redhat.com>
5698
5699         PR c++/24367
5700         * cp-support.c (inspect_type): Don't attempt substitutions
5701         of symbol with the same name.
5702
5703 2019-04-25  Tom Tromey  <tromey@adacore.com>
5704
5705         PR gdb/24475:
5706         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5707         static.
5708
5709 2019-04-25  Tom Tromey  <tromey@adacore.com>
5710
5711         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5712         rvalue reference.
5713         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5714         (gdb_xml_parser::parse): Use std::move.
5715         * python/python-internal.h (gdbpy_convert_exception): Take a const
5716         reference.
5717         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5718         std::move.
5719         * python/py-utils.c (gdbpy_convert_exception): Take a const
5720         reference.
5721         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5722         Use std::move.
5723         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5724         Use std::move.
5725         * mi/mi-main.c (mi_print_exception): Take a const reference.
5726         * main.c (handle_command_errors): Take a const reference.
5727         * linespec.c (parse_linespec): Use std::move.
5728         * infcall.c (run_inferior_call): Use std::move.
5729         (call_function_by_hand_dummy): Use std::move.
5730         * exec.c (try_open_exec_file): Use std::move.
5731         * exceptions.h (exception_print, exception_fprintf)
5732         (exception_print_same): Update.
5733         * exceptions.c (print_exception, exception_print)
5734         (exception_fprintf, exception_print_same): Change parameters to
5735         const reference.
5736         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5737         * common/new-op.c: Use std::move.
5738         * common/common-exceptions.h (struct gdb_exception): Add move
5739         constructor.
5740         (struct gdb_exception_error, struct gdb_exception_quit, struct
5741         gdb_quit_bad_alloc): Change constructor to move constructor.
5742         (throw_exception): Change parameter to rvalue reference.
5743         * common/common-exceptions.c (throw_exception): Take rvalue
5744         reference.
5745         * cli/cli-interp.c (safe_execute_command): Use std::move.
5746         * breakpoint.c (insert_bp_location, location_to_sals): Use
5747         std::move.
5748
5749 2019-04-25  Tom Tromey  <tromey@adacore.com>
5750
5751         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5752         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5753         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5754         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5755         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5756         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5757         guile/scm-value.c: Use unpack.
5758         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5759         gdbscm_gdb_exception.
5760         (gdbscm_throw_gdb_exception): Likewise.
5761         (struct gdbscm_gdb_exception): New.
5762         (unpack): New function.
5763         (gdbscm_wrap): Use unpack.
5764
5765 2019-04-25  Tom Tromey  <tromey@adacore.com>
5766
5767         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5768         (gdb_rl_callback_handler): Use std::move.
5769         * common/common-exceptions.h (struct gdb_exception): Add move
5770         assignment operator.
5771         (throw_exception_sjlj): Change "exception" to const reference.
5772         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5773         (throw_exception_sjlj): Change "exception" to const reference.
5774
5775 2019-04-25  Tom Tromey  <tromey@adacore.com>
5776
5777         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5778         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5779         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5780         Update.
5781         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5782         Update.
5783         * mi/mi-interp.c (mi_interp::exec): Update.
5784         * linespec.c (parse_linespec): Update.
5785         * infcall.c (run_inferior_call): Update.
5786         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5787         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5788         (gdbscm_lookup_global_symbol): Update.
5789         * guile/scm-param.c (gdbscm_parameter_value): Update.
5790         * guile/scm-frame.c (gdbscm_frame_read_register)
5791         (gdbscm_frame_read_var): Update.
5792         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5793         * exec.c (try_open_exec_file): Update.
5794         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5795         (gdb_rl_callback_handler): Update.
5796         * common/common-exceptions.h (exception_none): Don't declare.
5797         * common/common-exceptions.c (exception_none): Don't define.
5798         (struct catcher) <exception>: Update.
5799         * cli/cli-interp.c (safe_execute_command): Update.
5800         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5801
5802 2019-04-25  Ali Tamur  <tamur@google.com>
5803
5804         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5805         (read_attribute_value): Likewise.
5806         (dwarf2_read_addr_index): Update comment.
5807         (read_str_index): Add DW_FORM_strx.
5808         (dwarf2_string_attr): Likewise.
5809         (dwarf2_const_value_attr): Likewise.
5810         (dump_die_shallow): Likewise.
5811         (dwarf2_fetch_constant_bytes): Likewise.
5812         (skip_form_bytes): Likewise.
5813         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5814
5815 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5816
5817         PR corefiles/11608
5818         PR corefiles/18187
5819         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5820         OFFSET.  Verify if current mapping contains an ELF header.
5821         (linux_find_memory_regions_full): Adjust call to
5822         dump_mapping_p.
5823
5824 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5825             Kang Li <kanglictf@gmail.com>
5826
5827         PR gdb/21600
5828
5829         * dwarf2-frame.c (read_initial_length): Be consistent about using
5830         unsigned representation of length.
5831         (decode_frame_entry_1): Likewise.  Check for wraparound of
5832         end pointer as well as buffer overflow.
5833
5834 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5835
5836         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5837         "vq".
5838
5839 2019-04-24  Tom Tromey  <tromey@adacore.com>
5840
5841         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5842
5843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5844
5845         * s12z-tdep.c (s12z_unwind_pc): Delete.
5846         (s12z_unwind_sp): Delete.
5847         (s12z_gdbarch_init): Don't register deleted functions with
5848         gdbarch.
5849
5850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5851
5852         * rl78-tdep.c (rl78_unwind_sp): Delete.
5853         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5854
5855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5856
5857         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5858         (xstormy16_unwind_pc): Delete.
5859         (xstormy16_dummy_id): Delete.
5860         (xstormy16_gdbarch_init): Don't register deleted functions with
5861         gdbarch.
5862
5863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5864
5865         * vax-tdep.c (vax_unwind_pc): Delete.
5866         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5867
5868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5869
5870         * v850-tdep.c (v850_unwind_sp): Delete.
5871         (v850_unwind_pc): Delete.
5872         (v850_dummy_id): Delete.
5873         (v850_gdbarch_init): Don't register deleted functions with
5874         gdbarch.
5875
5876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5877
5878         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5879         (tilegx_unwind_pc): Delete.
5880         (tilegx_unwind_dummy_id): Delete.
5881         (tilegx_gdbarch_init): Don't register deleted functions with
5882         gdbarch.
5883
5884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5885
5886         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5887         (tic6x_dummy_id): Delete.
5888         (tic6x_gdbarch_init): Don't register deleted functions with
5889         gdbarch.
5890
5891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5892
5893         * sparc-tdep.c (sparc_unwind_pc): Delete.
5894         (sparc32_gdbarch_init): Don't register deleted function with
5895         gdbarch.
5896
5897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5898
5899         * sh-tdep.c (sh_unwind_sp): Delete.
5900         (sh_unwind_pc): Delete.
5901         (sh_dummy_id): Delete.
5902         (sh_gdbarch_init): Don't register deleted functions with
5903         gdbarch.
5904
5905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5906
5907         * score-tdep.c (score_unwind_sp): Delete.
5908         (score_unwind_pc): Delete.
5909         (score_dummy_id): Delete.
5910         (score_gdbarch_init): Don't register deleted functions with
5911         gdbarch.
5912
5913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5914
5915         * rx-tdep.c (rx_unwind_pc): Delete.
5916         (rx_unwind_sp): Delete.
5917         (rx_dummy_id): Delete.
5918         (rx_gdbarch_init): Don't register deleted functions with
5919         gdbarch.  Update comment.
5920
5921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5922
5923         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5924         (rs6000_dummy_id): Delete.
5925         (rs6000_gdbarch_init): Don't register deleted functions with
5926         gdbarch.
5927
5928 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5929
5930         * or1k-tdep.c (or1k_dummy_id): Delete.
5931         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5932
5933 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5934
5935         * nios2-tdep.c (nios2_dummy_id): Delete.
5936         (nios2_unwind_sp): Delete.
5937         (nios2_gdbarch_init): Don't register deleted functions with
5938         gdbarch.
5939
5940 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5941
5942         * nds32-tdep.c (nds32_dummy_id): Delete.
5943         (nds32_unwind_pc): Delete.
5944         (nds32_unwind_sp): Delete.
5945         (nds32_gdbarch_init): Don't register deleted functions with
5946         gdbarch.
5947
5948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5949
5950         * msp430-tdep.c (msp430_unwind_pc): Delete.
5951         (msp430_unwind_sp): Delete.
5952         (msp430_dummy_id): Delete.
5953         (msp430_gdbarch_init): Don't register deleted functions with
5954         gdbarch.
5955
5956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5957
5958         * moxie-tdep.c (moxie_unwind_sp): Delete.
5959         (moxie_unwind_pc): Delete.
5960         (moxie_dummy_id): Delete.
5961         (moxie_gdbarch_init): Don't register deleted functions with
5962         gdbarch.
5963
5964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5965
5966         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5967         (mn10300_unwind_pc): Delete.
5968         (mn10300_unwind_sp): Delete.
5969         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5970         mn10300_unwind_sp.
5971         (mn10300_frame_unwind_init): Don't register deleted functions with
5972         gdbarch.
5973
5974 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5975
5976         * mep-tdep.c (mep_unwind_pc): Delete.
5977         (mep_unwind_sp): Delete.
5978         (mep_dummy_id): Delete.
5979         (mep_gdbarch_init): Don't register deleted functions with
5980         gdbarch.
5981
5982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5983
5984         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5985         (m68hc11_unwind_sp): Delete.
5986         (m68hc11_gdbarch_init): Don't register deleted functions with
5987         gdbarch.
5988
5989 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5990
5991         * m32r-tdep.c (m32r_unwind_sp): Delete.
5992         (m32r_unwind_pc): Delete.
5993         (m32r_dummy_id): Delete.
5994         (m32r_gdbarch_init): Don't register deleted functions with
5995         gdbarch.
5996
5997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5998
5999         * m32c-tdep.c (m32c_unwind_pc): Delete.
6000         (m32c_unwind_sp): Delete.
6001         (m32c_dummy_id): Delete.
6002         (m32c_gdbarch_init): Don't register deleted functions with
6003         gdbarch.
6004
6005 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6006
6007         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6008         (lm32_unwind_pc): Delete.
6009         (lm32_dummy_id): Delete.
6010         (lm32_gdbarch_init): Don't register deleted functions with
6011         gdbarch.
6012
6013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6014
6015         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6016         (iq2000_unwind_pc): Delete.
6017         (iq2000_dummy_id): Delete.
6018         (iq2000_gdbarch_init): Don't register deleted functions with
6019         gdbarch.
6020
6021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6022
6023         * nds32-tdep.c (nds32_type_align): Delete.
6024         (nds32_push_dummy_call): Use type_align instead.
6025
6026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6027
6028         * arm-tdep.c (arm_type_align): Only handle vector override case.
6029         (arm_push_dummy_call): Use type_align.
6030         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6031
6032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6033
6034         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6035         case.
6036         (pass_on_stack): Use type_align.
6037         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6038         function.
6039
6040 2019-04-23  Tom Tromey  <tromey@adacore.com>
6041
6042         * dwarf2read.c (line_header::file_name_at): Remove unused
6043         overload.
6044
6045 2019-04-23  Tom de Vries  <tdevries@suse.de>
6046
6047         PR gdb/24438
6048         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6049         invocation.
6050
6051
6052 2019-03-27  Ali Tamur  <tamur@google.com>
6053
6054         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6055         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6056         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6057         (dwarf_expr_context::get_addr_index): Likewise
6058         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6059         (symbol_needs_eval_context::get_addr_index): Likewise
6060         (disassemble_dwarf_expression): Add DW_OP_addrx
6061         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6062         (read_cutu_die_from_dwo): Update comment
6063         (skip_one_die): Add DW_FORM_addrx
6064         (read_attribute_value): Likewise
6065         (var_decode_location): Add DW_OP_addrx
6066         (dwarf2_const_value_attr): Add DW_FORM_addrx
6067         (dump_die_shallow): Likewise
6068         (dwarf2_fetch_constant_bytes): Likewise
6069         (decode_locdesc): Add DW_OP_addrx
6070         (skip_form_bytes): Add DW_FORM_addrx
6071
6072 2019-04-22  Ali Tamur  <tamur@google.com>
6073
6074         * MAINTAINERS (Write After Approval): Add self.
6075
6076 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6077
6078         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6079         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6080         (open_symbol_file_object): Likewise.
6081         (svr4_default_sos): Add info parameter.
6082         (svr4_read_so_list): Likewise.
6083         (svr4_current_sos_direct): Adjust functions calls to pass down
6084         info.
6085         (svr4_current_sos_1): Add info parameter.
6086         (svr4_current_sos): Call get_svr4_info, pass info down to
6087         svr4_current_sos_1.
6088         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6089         get_svr4_info.
6090         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6091         get_svr4_info.
6092         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6093         to get_svr4_info.
6094         (probes_table_remove_objfile_probes): Likewise.
6095         (register_solib_event_probe): Add info parameter.
6096         (solist_update_incremental): Pass info parameter down to
6097         svr4_read_so_list.
6098         (disable_probes_interface): Add info parameter.
6099         (svr4_handle_solib_event): Pass current_program_space to
6100         get_svr4_info.  Adjust disable_probes_interface cleanup.
6101         (svr4_create_probe_breakpoints): Add info parameter, pass it
6102         down to register_solib_event_probe.
6103         (svr4_create_solib_event_breakpoints): Add info parameter,
6104         pass it down to svr4_create_probe_breakpoints.
6105         (enable_break): Pass info down to
6106         svr4_create_solib_event_breakpoints.
6107         (svr4_solib_create_inferior_hook): Pass current_program_space to
6108         get_svr4_info.
6109         (svr4_clear_solib): Likewise.
6110
6111 2019-04-22  Pedro Alves  <palves@redhat.com>
6112
6113         * solib-svr4.c (svr4_free_objfile_observer): New.
6114         (probe_and_action::objfile): New field.
6115         (probes_table_htab_remove_objfile_probes)
6116         (probes_table_remove_objfile_probes): New functions.
6117         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6118         in the new probe_and_action.  Don't store the probe in 'lookup'.
6119         (svr4_create_probe_breakpoints): Pass objfile to
6120         register_solib_event_probe.
6121         (_initialize_svr4_solib): Register a free_objfile observer.
6122
6123 2019-04-19  Tom Tromey  <tom@tromey.com>
6124
6125         * common/queue.h: Remove.
6126
6127 2019-04-19  Tom Tromey  <tom@tromey.com>
6128
6129         * event-loop.c: Don't include "common/queue.h".
6130
6131 2019-04-19  Tom Tromey  <tom@tromey.com>
6132
6133         * remote.c (remote_target): Use delete.
6134         * remote-notif.h: Include <list>, not "common/queue.h".
6135         (notif_client_p): Remove typedef.
6136         (remote_notif_state): Add constructor, destructor, initializer.
6137         <notif_queue>: Now a std::list.
6138         (remote_notif_state_xfree): Don't declare.
6139         * remote-notif.c (remote_notif_process, handle_notification)
6140         (remote_notif_state_allocate): Update.
6141         (~remote_notif_state): Rename from remote_notif_state_xfree.
6142
6143 2019-04-19  Tom Tromey  <tom@tromey.com>
6144
6145         * symfile.c (reread_symbols): Update.
6146         * objfiles.c (objfile_register_static_link)
6147         (objfile_lookup_static_link): Update
6148         (~objfile) Don't delete static_links.
6149         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6150
6151 2019-04-19  Tom Tromey  <tom@tromey.com>
6152
6153         * type-stack.h (struct type_stack) <insert>: Constify string.
6154         * type-stack.c (type_stack::insert): Constify string.
6155         * gdbtypes.h (lookup_template_type): Update.
6156         (address_space_name_to_int): Update.
6157         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6158         const.
6159         (lookup_template_type): Make name const.
6160         * c-exp.y: Update rules.
6161         (lex_one_token, classify_name, classify_inner_name)
6162         (c_print_token): Update.
6163         * p-exp.y: Update rules.
6164         (yylex): Update.
6165         * f-exp.y: Update rules.
6166         (yylex): Update.
6167         * d-exp.y: Update rules.
6168         (lex_one_token, classify_name, classify_inner_name): Update.
6169         * parse.c (write_dollar_variable, copy_name): Return std::string.
6170         * parser-defs.h (copy_name): Change return type.
6171         * m2-exp.y: Update rules.
6172         (yylex): Update.
6173         * go-exp.y (lex_one_token): Update.
6174         Update rules.
6175         (classify_unsafe_function, classify_packaged_name)
6176         (classify_name, yylex): Update.
6177
6178 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6179
6180         * configure.ac: add --enable-source-highlight switch.
6181         * configure: Regenerate.
6182         * top.c (print_gdb_version): plumb --enable-source-highlight
6183         status to "show configuration".
6184
6185 2019-04-19  Tom Tromey  <tromey@adacore.com>
6186
6187         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6188         Check ADA_TYPE_P.
6189         (empty_record, ada_template_to_fixed_record_type_1)
6190         (template_to_static_fixed_type)
6191         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6192         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6193         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6194         macros.
6195
6196 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6197
6198         PR symtab/24423:
6199         * source.c (print_source_lines_base): Advance "iter" when a
6200         control character is seen.
6201
6202 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6203
6204         * inferior.h (struct infcall_suspend_state_deleter):
6205         Catch exception in destructor to avoid crash.
6206
6207 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6208
6209         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6210         close to the add_com "shell".
6211
6212 2019-04-18  Tom Tromey  <tromey@adacore.com>
6213
6214         * process-stratum-target.h (class process_stratum_target)
6215         <stratum>: Add "final".
6216
6217 2019-04-17  Tom Tromey  <tromey@adacore.com>
6218
6219         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6220         against nullptr before use.
6221
6222 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6223
6224         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6225
6226 2019-04-17  Jim Wilson  <jimw@sifive.com>
6227             Andrew Burgess  <andrew.burgess@embecosm.com>
6228
6229         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6230         code read might fail, assume 4-byte breakpoint in that case.
6231
6232 2019-04-15  Leszek Swirski  <leszeks@google.com>
6233
6234         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6235         rather than a hand-rolled POD check when checking for forced MEMORY
6236         classification.
6237
6238 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6239
6240         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6241         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6242         function.
6243         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6244         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6245         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6246         declaration.
6247
6248 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6249
6250         * aarch64-linux-nat.c
6251         (aarch64_linux_nat_target::thread_architecture): Add override.
6252         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6253         each VQ.
6254
6255 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6256
6257         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6258
6259 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6260
6261         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6262         target types of size 96-bits, add some additional comments, and
6263         check that the builtin type we found was the correct size.
6264
6265 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6266
6267         * utils.c (prompt_for_continue): Don't restore the styling at the
6268         end, as applied_style has the wrong value.  This fixes styling in
6269         long lists of file names that are interrupted by the "Continue?"
6270         prompt.
6271
6272 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6273
6274         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6275         * c-lang.c (c_language_defn): Likewise.
6276         (cplus_language_defn): Likewise.
6277         (asm_language_defn): Likewise.
6278         (minimal_language_defn): Likewise.
6279         * d-lang.c (d_language_defn): Likewise.
6280         * f-lang.c (f_language_defn): Likewise.
6281         * go-lang.c (go_language_defn): Likewise.
6282         * language.c (unknown_language_defn): Likewise.
6283         (auto_language_defn): Likewise.
6284         * language.h (struct language_defn): Remove la_magic field.
6285         (LANG_MAGIC): Delete.
6286         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6287         * objc-lang.c (objc_language_defn): Likewise.
6288         * opencl-lang.c (opencl_language_defn): Likewise.
6289         * p-lang.c (pascal_language_defn): Likewise.
6290         * rust-lang.c (rust_language_defn): Likewise.
6291
6292 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6293
6294         * riscv-tdep.c (riscv_type_align): New function.
6295         (riscv_type_alignment): Delete.
6296         (riscv_arg_location): Use 'type_align'.
6297         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6298
6299 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6300
6301         * gdbtypes.c (type_align): A struct with no non-static fields also
6302         has alignment of 1.
6303
6304 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6305
6306         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6307         component to 0.
6308         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6309         member.
6310         (riscv_struct_info::analyse): New implementation using new
6311         analyse_inner member function.
6312         (riscv_struct_info::field_offset): New member function.
6313         (riscv_struct_info::m_offsets): New member variable.
6314         (riscv_struct_info::analyse_inner): New private member function,
6315         takes the old implementation of riscv_struct_info::analyse but
6316         extended to track field offsets.
6317         (riscv_call_arg_struct): Update the struct folding special cases
6318         to handle cases where empty C++ structs, which are non-zero
6319         length, are found.
6320         (riscv_arg_location): Initialise the length of each location, a
6321         non-zero length now indicates the location is in use.
6322         (riscv_push_dummy_call): Allow for the first location having a
6323         non-zero offset when setting up arguments.
6324         (riscv_return_value): Likewise, but for return values.
6325
6326 2019-04-11  Tom Tromey  <tromey@adacore.com>
6327
6328         * utils.c (internal_vproblem): Make "msg" const.
6329
6330 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6331
6332         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6333         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6334         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6335         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6336
6337 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6338
6339         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6340         function.
6341         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6342         of amd64_collect_native_gregset.
6343         (amd64_linux_nat_target::store_registers): Likewise.
6344
6345 2019-04-10  Tom Tromey  <tom@tromey.com>
6346
6347         * symtab.c (lookup_global_symbol_from_objfile)
6348         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6349         * objfiles.h (class separate_debug_iterator): New.
6350         (class separate_debug_range): New.
6351         (struct objfile) <separate_debug_objfiles>: New method.
6352         (objfile_separate_debug_iterate): Don't declare.
6353         * objfiles.c (separate_debug_iterator::operator++): Rename from
6354         objfile_separate_debug_iterate.
6355         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6356         iterator.
6357         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6358         iterator.
6359
6360 2019-04-10  Tom Tromey  <tom@tromey.com>
6361
6362         * symfile.c (reread_symbols): Remove old comment.
6363         * objfiles.c (free_all_objfiles): Fix a typo.
6364
6365 2019-04-10  Tom Tromey  <tom@tromey.com>
6366
6367         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6368         * minsyms.c (lookup_minimal_symbol): Use foreach.
6369         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6370         (lookup_minimal_symbol_solib_trampoline): Likewise.
6371         * symfile.c (reread_symbols): Use foreach.
6372
6373 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6374             Tom Tromey  <tromey@adacore.com>
6375
6376         PR rust/24414:
6377         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6378         (rust_lex_int_test): Change "value" to be LONGEST.
6379         (rust_lex_tests): Add test for long integer literal.
6380
6381 2019-04-09  Tom Tromey  <tromey@adacore.com>
6382
6383         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6384         to bool.
6385         (extended_remote_target::attach): Update.
6386         (remote_target::remote_notice_new_inferior): Update.
6387         (remote_target::add_current_inferior_and_thread): Update.
6388         * inferior.c (exit_inferior_1): Use "false".
6389         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6390
6391 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6392
6393         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6394         the "start" command.
6395
6396 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6397
6398         * python/py-inferior.c (infpy_thread_from_thread_handle):
6399         Adjust comments to reflect renaming of thread_from_thread_handle
6400         to thread_from_handle.  Adjust keywords.  Fix type error message.
6401         (inferior_object_methods): Add thread_from_handle.  Retain
6402         thread_from_thread_handle, but mark it as deprecated.
6403
6404 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6405
6406         * gdbthread.h (find_thread_by_handle): Revise declaration.
6407         * thread.c (find_thread_by_handle): Likewise.  Adjust
6408         implementation too.
6409         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6410         support for buffer objects as handles.
6411
6412 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6413
6414         * python/py-infthread.c (thpy_thread_handle): New function.
6415         (thread_object_methods): Register thpy_thread_handle.
6416
6417 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6418
6419         * gdbthread.h (thread_to_thread_handle): Declare.
6420         * thread.c (gdbtypes.h): Include.
6421         (thread_to_thread_handle): New function.
6422
6423         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6424         (target_thread_info_to_thread_handle): Declare.
6425         * target.c (target_thread_info_to_thread_handle): New function.
6426         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6427         * target-delegates.c: Regenerate.
6428
6429         * linux-thread-db.c (class thread_db_target): Add method
6430         thread_info_to_thread_handle.
6431         (thread_db_target::thread_info_to_thread_handle): Define.
6432         * remote.c (class remote_target): Add new method
6433         thread_info_to_thread_handle.
6434         (remote_target::thread_info_to_thread_handle): Define.
6435
6436 2019-04-08  Pedro Alves  <palves@redhat.com>
6437
6438         * common/common-exceptions.c (throw_exception): Don't create
6439         named object to throw; throw directly.
6440         (throw_it): Likewise.  Don't initialize gdb_exception::message
6441         here, with new; pass FMT and AP to the ctor instead.
6442         * common/common-exceptions.h: Include <string>.
6443         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6444         const char *, va_list)): New ctor.  Use std::make_shared.
6445         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6446         errors)): Delete.
6447         (gdb_exception_error::gdb_exception_error(enum errors, const char
6448         *, va_list)): New.
6449         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6450         Add assertion.
6451         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6452         errors)): Delete.
6453         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6454         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6455         Add assertion.
6456
6457 2019-04-08  Tom Tromey  <tom@tromey.com>
6458
6459         * valops.c (value_rtti_indirect_type): Replace throw_exception
6460         with throw.
6461         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6462         with throw.
6463         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6464         throw.
6465         * target.c (target_translate_tls_address): Replace throw_exception
6466         with throw.
6467         * stack.c (frame_apply_command_count): Replace throw_exception
6468         with throw.
6469         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6470         throw.
6471         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6472         with throw.
6473         * rs6000-tdep.c (rs6000_frame_cache)
6474         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6475         * remote.c: Replace throw_exception with throw.
6476         * record-full.c (record_full_message, record_full_wait_1)
6477         (record_full_restore): Replace throw_exception with throw.
6478         * record-btrace.c:
6479         (get_thread_current_frame_id, record_btrace_start_replaying)
6480         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6481         (cmd_record_btrace_start): Replace throw_exception with throw.
6482         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6483         throw.
6484         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6485         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6486         * linespec.c:
6487         (find_linespec_symbols): Replace throw_exception with throw.
6488         * infrun.c (displaced_step_prepare, resume): Replace
6489         throw_exception with throw.
6490         * infcmd.c (post_create_inferior): Replace throw_exception with
6491         throw.
6492         * inf-loop.c (inferior_event_handler): Replace throw_exception
6493         with throw.
6494         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6495         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6496         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6497         (get_prev_frame_always, get_frame_pc_if_available)
6498         (get_frame_address_in_block_if_available, get_frame_language):
6499         Replace throw_exception with throw.
6500         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6501         throw_exception with throw.
6502         * eval.c (fetch_subexp_value, evaluate_var_value)
6503         (evaluate_funcall, evaluate_subexp_standard): Replace
6504         throw_exception with throw.
6505         * dwarf2loc.c (call_site_find_chain)
6506         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6507         Replace throw_exception with throw.
6508         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6509         with throw.
6510         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6511         throw.
6512         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6513         * completer.c (complete_line_internal): Replace throw_exception
6514         with throw.
6515         * compile/compile-object-run.c (compile_object_run): Replace
6516         throw_exception with throw.
6517         * cli/cli-script.c (process_next_line): Replace throw_exception
6518         with throw.
6519         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6520         (btrace_enable, btrace_maint_update_pt_packets): Replace
6521         throw_exception with throw.
6522         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6523         throw_exception with throw.
6524         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6525         throw_exception with throw.
6526         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6527         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6528         * aarch64-tdep.c (aarch64_make_prologue_cache)
6529         (aarch64_make_stub_cache): Replace throw_exception with throw.
6530
6531 2019-04-08  Tom Tromey  <tom@tromey.com>
6532
6533         * common/common-exceptions.c (throw_exception): Rename from
6534         throw_exception_cxx.  Remove old copy.  Make argument const.
6535         (throw_it): Create and throw exception objects directly.
6536         * common/common-exceptions.h (throw_exception): Make argument
6537         const.
6538         (struct gdb_exception_error): Add constructor.
6539         (struct gdb_exception_quit): Add constructor.
6540
6541 2019-04-08  Tom Tromey  <tom@tromey.com>
6542
6543         * common/common-exceptions.h (exception_rethrow): Don't declare.
6544         (TRY_SJLJ): Update comment.
6545         (TRY, CATCH, END_CATCH): Remove.
6546         * common/common-exceptions.c (exception_rethrow): Remove.
6547
6548 2019-04-08  Tom Tromey  <tom@tromey.com>
6549
6550         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6551         Remove.
6552         (gdb_exception_error): Rename from
6553         gdb_exception_RETURN_MASK_ERROR.
6554         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6555         (gdb_quit_bad_alloc): Update.
6556         * aarch64-tdep.c: Update.
6557         * ada-lang.c: Update.
6558         * ada-typeprint.c: Update.
6559         * ada-valprint.c: Update.
6560         * amd64-tdep.c: Update.
6561         * arch-utils.c: Update.
6562         * break-catch-throw.c: Update.
6563         * breakpoint.c: Update.
6564         * btrace.c: Update.
6565         * c-varobj.c: Update.
6566         * cli/cli-cmds.c: Update.
6567         * cli/cli-interp.c: Update.
6568         * cli/cli-script.c: Update.
6569         * common/common-exceptions.c: Update.
6570         * common/new-op.c: Update.
6571         * common/selftest.c: Update.
6572         * compile/compile-c-symbols.c: Update.
6573         * compile/compile-cplus-symbols.c: Update.
6574         * compile/compile-object-load.c: Update.
6575         * compile/compile-object-run.c: Update.
6576         * completer.c: Update.
6577         * corelow.c: Update.
6578         * cp-abi.c: Update.
6579         * cp-support.c: Update.
6580         * cp-valprint.c: Update.
6581         * darwin-nat.c: Update.
6582         * disasm-selftests.c: Update.
6583         * dtrace-probe.c: Update.
6584         * dwarf-index-cache.c: Update.
6585         * dwarf-index-write.c: Update.
6586         * dwarf2-frame-tailcall.c: Update.
6587         * dwarf2-frame.c: Update.
6588         * dwarf2loc.c: Update.
6589         * dwarf2read.c: Update.
6590         * eval.c: Update.
6591         * event-loop.c: Update.
6592         * event-top.c: Update.
6593         * exec.c: Update.
6594         * f-valprint.c: Update.
6595         * fbsd-tdep.c: Update.
6596         * frame-unwind.c: Update.
6597         * frame.c: Update.
6598         * gdbtypes.c: Update.
6599         * gnu-v3-abi.c: Update.
6600         * guile/guile-internal.h: Update.
6601         * guile/scm-block.c: Update.
6602         * guile/scm-breakpoint.c: Update.
6603         * guile/scm-cmd.c: Update.
6604         * guile/scm-disasm.c: Update.
6605         * guile/scm-frame.c: Update.
6606         * guile/scm-lazy-string.c: Update.
6607         * guile/scm-math.c: Update.
6608         * guile/scm-param.c: Update.
6609         * guile/scm-ports.c: Update.
6610         * guile/scm-pretty-print.c: Update.
6611         * guile/scm-symbol.c: Update.
6612         * guile/scm-symtab.c: Update.
6613         * guile/scm-type.c: Update.
6614         * guile/scm-value.c: Update.
6615         * i386-linux-tdep.c: Update.
6616         * i386-tdep.c: Update.
6617         * inf-loop.c: Update.
6618         * infcall.c: Update.
6619         * infcmd.c: Update.
6620         * infrun.c: Update.
6621         * jit.c: Update.
6622         * language.c: Update.
6623         * linespec.c: Update.
6624         * linux-fork.c: Update.
6625         * linux-nat.c: Update.
6626         * linux-tdep.c: Update.
6627         * linux-thread-db.c: Update.
6628         * main.c: Update.
6629         * mi/mi-cmd-break.c: Update.
6630         * mi/mi-cmd-stack.c: Update.
6631         * mi/mi-interp.c: Update.
6632         * mi/mi-main.c: Update.
6633         * objc-lang.c: Update.
6634         * p-valprint.c: Update.
6635         * parse.c: Update.
6636         * ppc-linux-tdep.c: Update.
6637         * printcmd.c: Update.
6638         * python/py-arch.c: Update.
6639         * python/py-breakpoint.c: Update.
6640         * python/py-cmd.c: Update.
6641         * python/py-finishbreakpoint.c: Update.
6642         * python/py-frame.c: Update.
6643         * python/py-framefilter.c: Update.
6644         * python/py-gdb-readline.c: Update.
6645         * python/py-inferior.c: Update.
6646         * python/py-infthread.c: Update.
6647         * python/py-lazy-string.c: Update.
6648         * python/py-linetable.c: Update.
6649         * python/py-objfile.c: Update.
6650         * python/py-param.c: Update.
6651         * python/py-prettyprint.c: Update.
6652         * python/py-progspace.c: Update.
6653         * python/py-record-btrace.c: Update.
6654         * python/py-record.c: Update.
6655         * python/py-symbol.c: Update.
6656         * python/py-type.c: Update.
6657         * python/py-unwind.c: Update.
6658         * python/py-utils.c: Update.
6659         * python/py-value.c: Update.
6660         * python/python.c: Update.
6661         * record-btrace.c: Update.
6662         * record-full.c: Update.
6663         * remote-fileio.c: Update.
6664         * remote.c: Update.
6665         * riscv-tdep.c: Update.
6666         * rs6000-aix-tdep.c: Update.
6667         * rs6000-tdep.c: Update.
6668         * rust-exp.y: Update.
6669         * rust-lang.c: Update.
6670         * s390-tdep.c: Update.
6671         * selftest-arch.c: Update.
6672         * solib-dsbt.c: Update.
6673         * solib-frv.c: Update.
6674         * solib-spu.c: Update.
6675         * solib-svr4.c: Update.
6676         * solib.c: Update.
6677         * sparc64-linux-tdep.c: Update.
6678         * stack.c: Update.
6679         * symfile-mem.c: Update.
6680         * symmisc.c: Update.
6681         * target.c: Update.
6682         * thread.c: Update.
6683         * top.c: Update.
6684         * tracefile-tfile.c: Update.
6685         * tui/tui.c: Update.
6686         * typeprint.c: Update.
6687         * unittests/cli-utils-selftests.c: Update.
6688         * unittests/parse-connection-spec-selftests.c: Update.
6689         * valops.c: Update.
6690         * valprint.c: Update.
6691         * value.c: Update.
6692         * varobj.c: Update.
6693         * windows-nat.c: Update.
6694         * x86-linux-nat.c: Update.
6695         * xml-support.c: Update.
6696
6697 2019-04-08  Tom Tromey  <tom@tromey.com>
6698
6699         * xml-support.c: Use C++ exception handling.
6700         * x86-linux-nat.c: Use C++ exception handling.
6701         * windows-nat.c: Use C++ exception handling.
6702         * varobj.c: Use C++ exception handling.
6703         * value.c: Use C++ exception handling.
6704         * valprint.c: Use C++ exception handling.
6705         * valops.c: Use C++ exception handling.
6706         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6707         handling.
6708         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6709         * typeprint.c: Use C++ exception handling.
6710         * tui/tui.c: Use C++ exception handling.
6711         * tracefile-tfile.c: Use C++ exception handling.
6712         * top.c: Use C++ exception handling.
6713         * thread.c: Use C++ exception handling.
6714         * target.c: Use C++ exception handling.
6715         * symmisc.c: Use C++ exception handling.
6716         * symfile-mem.c: Use C++ exception handling.
6717         * stack.c: Use C++ exception handling.
6718         * sparc64-linux-tdep.c: Use C++ exception handling.
6719         * solib.c: Use C++ exception handling.
6720         * solib-svr4.c: Use C++ exception handling.
6721         * solib-spu.c: Use C++ exception handling.
6722         * solib-frv.c: Use C++ exception handling.
6723         * solib-dsbt.c: Use C++ exception handling.
6724         * selftest-arch.c: Use C++ exception handling.
6725         * s390-tdep.c: Use C++ exception handling.
6726         * rust-lang.c: Use C++ exception handling.
6727         * rust-exp.y: Use C++ exception handling.
6728         * rs6000-tdep.c: Use C++ exception handling.
6729         * rs6000-aix-tdep.c: Use C++ exception handling.
6730         * riscv-tdep.c: Use C++ exception handling.
6731         * remote.c: Use C++ exception handling.
6732         * remote-fileio.c: Use C++ exception handling.
6733         * record-full.c: Use C++ exception handling.
6734         * record-btrace.c: Use C++ exception handling.
6735         * python/python.c: Use C++ exception handling.
6736         * python/py-value.c: Use C++ exception handling.
6737         * python/py-utils.c: Use C++ exception handling.
6738         * python/py-unwind.c: Use C++ exception handling.
6739         * python/py-type.c: Use C++ exception handling.
6740         * python/py-symbol.c: Use C++ exception handling.
6741         * python/py-record.c: Use C++ exception handling.
6742         * python/py-record-btrace.c: Use C++ exception handling.
6743         * python/py-progspace.c: Use C++ exception handling.
6744         * python/py-prettyprint.c: Use C++ exception handling.
6745         * python/py-param.c: Use C++ exception handling.
6746         * python/py-objfile.c: Use C++ exception handling.
6747         * python/py-linetable.c: Use C++ exception handling.
6748         * python/py-lazy-string.c: Use C++ exception handling.
6749         * python/py-infthread.c: Use C++ exception handling.
6750         * python/py-inferior.c: Use C++ exception handling.
6751         * python/py-gdb-readline.c: Use C++ exception handling.
6752         * python/py-framefilter.c: Use C++ exception handling.
6753         * python/py-frame.c: Use C++ exception handling.
6754         * python/py-finishbreakpoint.c: Use C++ exception handling.
6755         * python/py-cmd.c: Use C++ exception handling.
6756         * python/py-breakpoint.c: Use C++ exception handling.
6757         * python/py-arch.c: Use C++ exception handling.
6758         * printcmd.c: Use C++ exception handling.
6759         * ppc-linux-tdep.c: Use C++ exception handling.
6760         * parse.c: Use C++ exception handling.
6761         * p-valprint.c: Use C++ exception handling.
6762         * objc-lang.c: Use C++ exception handling.
6763         * mi/mi-main.c: Use C++ exception handling.
6764         * mi/mi-interp.c: Use C++ exception handling.
6765         * mi/mi-cmd-stack.c: Use C++ exception handling.
6766         * mi/mi-cmd-break.c: Use C++ exception handling.
6767         * main.c: Use C++ exception handling.
6768         * linux-thread-db.c: Use C++ exception handling.
6769         * linux-tdep.c: Use C++ exception handling.
6770         * linux-nat.c: Use C++ exception handling.
6771         * linux-fork.c: Use C++ exception handling.
6772         * linespec.c: Use C++ exception handling.
6773         * language.c: Use C++ exception handling.
6774         * jit.c: Use C++ exception handling.
6775         * infrun.c: Use C++ exception handling.
6776         * infcmd.c: Use C++ exception handling.
6777         * infcall.c: Use C++ exception handling.
6778         * inf-loop.c: Use C++ exception handling.
6779         * i386-tdep.c: Use C++ exception handling.
6780         * i386-linux-tdep.c: Use C++ exception handling.
6781         * guile/scm-value.c: Use C++ exception handling.
6782         * guile/scm-type.c: Use C++ exception handling.
6783         * guile/scm-symtab.c: Use C++ exception handling.
6784         * guile/scm-symbol.c: Use C++ exception handling.
6785         * guile/scm-pretty-print.c: Use C++ exception handling.
6786         * guile/scm-ports.c: Use C++ exception handling.
6787         * guile/scm-param.c: Use C++ exception handling.
6788         * guile/scm-math.c: Use C++ exception handling.
6789         * guile/scm-lazy-string.c: Use C++ exception handling.
6790         * guile/scm-frame.c: Use C++ exception handling.
6791         * guile/scm-disasm.c: Use C++ exception handling.
6792         * guile/scm-cmd.c: Use C++ exception handling.
6793         * guile/scm-breakpoint.c: Use C++ exception handling.
6794         * guile/scm-block.c: Use C++ exception handling.
6795         * guile/guile-internal.h: Use C++ exception handling.
6796         * gnu-v3-abi.c: Use C++ exception handling.
6797         * gdbtypes.c: Use C++ exception handling.
6798         * frame.c: Use C++ exception handling.
6799         * frame-unwind.c: Use C++ exception handling.
6800         * fbsd-tdep.c: Use C++ exception handling.
6801         * f-valprint.c: Use C++ exception handling.
6802         * exec.c: Use C++ exception handling.
6803         * event-top.c: Use C++ exception handling.
6804         * event-loop.c: Use C++ exception handling.
6805         * eval.c: Use C++ exception handling.
6806         * dwarf2read.c: Use C++ exception handling.
6807         * dwarf2loc.c: Use C++ exception handling.
6808         * dwarf2-frame.c: Use C++ exception handling.
6809         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6810         * dwarf-index-write.c: Use C++ exception handling.
6811         * dwarf-index-cache.c: Use C++ exception handling.
6812         * dtrace-probe.c: Use C++ exception handling.
6813         * disasm-selftests.c: Use C++ exception handling.
6814         * darwin-nat.c: Use C++ exception handling.
6815         * cp-valprint.c: Use C++ exception handling.
6816         * cp-support.c: Use C++ exception handling.
6817         * cp-abi.c: Use C++ exception handling.
6818         * corelow.c: Use C++ exception handling.
6819         * completer.c: Use C++ exception handling.
6820         * compile/compile-object-run.c: Use C++ exception handling.
6821         * compile/compile-object-load.c: Use C++ exception handling.
6822         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6823         * compile/compile-c-symbols.c: Use C++ exception handling.
6824         * common/selftest.c: Use C++ exception handling.
6825         * common/new-op.c: Use C++ exception handling.
6826         * cli/cli-script.c: Use C++ exception handling.
6827         * cli/cli-interp.c: Use C++ exception handling.
6828         * cli/cli-cmds.c: Use C++ exception handling.
6829         * c-varobj.c: Use C++ exception handling.
6830         * btrace.c: Use C++ exception handling.
6831         * breakpoint.c: Use C++ exception handling.
6832         * break-catch-throw.c: Use C++ exception handling.
6833         * arch-utils.c: Use C++ exception handling.
6834         * amd64-tdep.c: Use C++ exception handling.
6835         * ada-valprint.c: Use C++ exception handling.
6836         * ada-typeprint.c: Use C++ exception handling.
6837         * ada-lang.c: Use C++ exception handling.
6838         * aarch64-tdep.c: Use C++ exception handling.
6839
6840 2019-04-08  Tom Tromey  <tom@tromey.com>
6841
6842         * xml-support.c (gdb_xml_parser::parse): Update.
6843         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6844         * value.c (show_convenience): Update.
6845         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6846         (test_parse_flags_qcs): Update.
6847         * thread.c (thr_try_catch_cmd): Update.
6848         * target.c (target_translate_tls_address): Update.
6849         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6850         (info_frame_command_core, frame_apply_command_count): Update.
6851         * rust-exp.y (rust_lex_exception_test): Update.
6852         * riscv-tdep.c (riscv_print_one_register_info): Update.
6853         * remote.c (remote_target::enable_btrace): Update.
6854         * record-btrace.c (record_btrace_enable_warn): Update.
6855         * python/py-utils.c (gdbpy_convert_exception): Update.
6856         * printcmd.c (do_one_display, print_variable_and_value): Update.
6857         * mi/mi-main.c (mi_print_exception): Update.
6858         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6859         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6860         * linux-nat.c (linux_nat_target::attach): Update.
6861         * linux-fork.c (class scoped_switch_fork_info): Update.
6862         * infrun.c (displaced_step_prepare): Update.
6863         * infcall.c (call_function_by_hand_dummy): Update.
6864         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6865         * gnu-v3-abi.c (print_one_vtable): Update.
6866         * frame.c (get_prev_frame_always): Update.
6867         * f-valprint.c (info_common_command_for_block): Update.
6868         * exec.c (try_open_exec_file): Update.
6869         * exceptions.c (print_exception, exception_print)
6870         (exception_fprintf, exception_print_same): Update.
6871         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6872         * dwarf-index-cache.c (index_cache::store)
6873         (index_cache::lookup_gdb_index): Update.
6874         * darwin-nat.c (maybe_cache_shell): Update.
6875         * cp-valprint.c (cp_print_value_fields): Update.
6876         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6877         (gcc_cplus_symbol_address): Update.
6878         * compile/compile-c-symbols.c (gcc_convert_symbol)
6879         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6880         * common/selftest.c: Update.
6881         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6882         a std::string.
6883         (exception_try_scope_entry, exception_try_scope_exit): Don't
6884         declare.
6885         (struct exception_try_scope): Remove.
6886         (TRY): Don't use exception_try_scope.
6887         (struct gdb_exception): Add constructor, operator=.
6888         <what>: New method.
6889         (struct gdb_exception_RETURN_MASK_ALL)
6890         (struct gdb_exception_RETURN_MASK_ERROR)
6891         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6892         (struct gdb_quit_bad_alloc): Update.
6893         * common/common-exceptions.c (exception_none): Change
6894         initializer.
6895         (struct catcher) <state, exception>: Initialize inline.
6896         <prev>: Remove member.
6897         (current_catcher): Remove.
6898         (catchers): New global.
6899         (exceptions_state_mc_init): Simplify.
6900         (catcher_pop): Remove.
6901         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6902         (try_scope_depth, exception_try_scope_entry)
6903         (exception_try_scope_exit): Remove.
6904         (throw_exception_sjlj): Update.
6905         (exception_messages, exception_messages_size): Remove.
6906         (throw_it): Simplify.
6907         (gdb_exception_sliced_copy): Remove.
6908         (throw_exception_cxx): Update.
6909         * cli/cli-script.c (script_from_file): Update.
6910         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6911         Update.
6912         * ada-valprint.c (ada_val_print): Update.
6913         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6914         (create_excep_cond_exprs): Update.
6915
6916 2019-04-08  Tom Tromey  <tom@tromey.com>
6917
6918         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6919         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6920         (TRY, CATCH, END_CATCH): Remove some definitions.
6921         * common/common-exceptions.c: Don't use GDB_XCPT.
6922         (catcher_list_size): Remove.
6923         (throw_exception, throw_it): Simplify.
6924
6925 2019-04-05  Tom Tromey  <tom@tromey.com>
6926
6927         Revert the header-sorting patch.
6928         * ft32-tdep.c: Revert.
6929         * frv-tdep.c: Revert.
6930         * frv-linux-tdep.c: Revert.
6931         * frame.c: Revert.
6932         * frame-unwind.c: Revert.
6933         * frame-base.c: Revert.
6934         * fork-child.c: Revert.
6935         * findvar.c: Revert.
6936         * findcmd.c: Revert.
6937         * filesystem.c: Revert.
6938         * filename-seen-cache.h: Revert.
6939         * filename-seen-cache.c: Revert.
6940         * fbsd-tdep.c: Revert.
6941         * fbsd-nat.h: Revert.
6942         * fbsd-nat.c: Revert.
6943         * f-valprint.c: Revert.
6944         * f-typeprint.c: Revert.
6945         * f-lang.c: Revert.
6946         * extension.h: Revert.
6947         * extension.c: Revert.
6948         * extension-priv.h: Revert.
6949         * expprint.c: Revert.
6950         * exec.h: Revert.
6951         * exec.c: Revert.
6952         * exceptions.c: Revert.
6953         * event-top.c: Revert.
6954         * event-loop.c: Revert.
6955         * eval.c: Revert.
6956         * elfread.c: Revert.
6957         * dwarf2read.h: Revert.
6958         * dwarf2read.c: Revert.
6959         * dwarf2loc.c: Revert.
6960         * dwarf2expr.h: Revert.
6961         * dwarf2expr.c: Revert.
6962         * dwarf2-frame.c: Revert.
6963         * dwarf2-frame-tailcall.c: Revert.
6964         * dwarf-index-write.h: Revert.
6965         * dwarf-index-write.c: Revert.
6966         * dwarf-index-common.c: Revert.
6967         * dwarf-index-cache.h: Revert.
6968         * dwarf-index-cache.c: Revert.
6969         * dummy-frame.c: Revert.
6970         * dtrace-probe.c: Revert.
6971         * disasm.h: Revert.
6972         * disasm.c: Revert.
6973         * disasm-selftests.c: Revert.
6974         * dictionary.c: Revert.
6975         * dicos-tdep.c: Revert.
6976         * demangle.c: Revert.
6977         * dcache.h: Revert.
6978         * dcache.c: Revert.
6979         * darwin-nat.h: Revert.
6980         * darwin-nat.c: Revert.
6981         * darwin-nat-info.c: Revert.
6982         * d-valprint.c: Revert.
6983         * d-namespace.c: Revert.
6984         * d-lang.c: Revert.
6985         * ctf.c: Revert.
6986         * csky-tdep.c: Revert.
6987         * csky-linux-tdep.c: Revert.
6988         * cris-tdep.c: Revert.
6989         * cris-linux-tdep.c: Revert.
6990         * cp-valprint.c: Revert.
6991         * cp-support.c: Revert.
6992         * cp-namespace.c: Revert.
6993         * cp-abi.c: Revert.
6994         * corelow.c: Revert.
6995         * corefile.c: Revert.
6996         * continuations.c: Revert.
6997         * completer.h: Revert.
6998         * completer.c: Revert.
6999         * complaints.c: Revert.
7000         * coffread.c: Revert.
7001         * coff-pe-read.c: Revert.
7002         * cli-out.h: Revert.
7003         * cli-out.c: Revert.
7004         * charset.c: Revert.
7005         * c-varobj.c: Revert.
7006         * c-valprint.c: Revert.
7007         * c-typeprint.c: Revert.
7008         * c-lang.c: Revert.
7009         * buildsym.c: Revert.
7010         * buildsym-legacy.c: Revert.
7011         * build-id.h: Revert.
7012         * build-id.c: Revert.
7013         * btrace.c: Revert.
7014         * bsd-uthread.c: Revert.
7015         * breakpoint.h: Revert.
7016         * breakpoint.c: Revert.
7017         * break-catch-throw.c: Revert.
7018         * break-catch-syscall.c: Revert.
7019         * break-catch-sig.c: Revert.
7020         * blockframe.c: Revert.
7021         * block.c: Revert.
7022         * bfin-tdep.c: Revert.
7023         * bfin-linux-tdep.c: Revert.
7024         * bfd-target.c: Revert.
7025         * bcache.c: Revert.
7026         * ax-general.c: Revert.
7027         * ax-gdb.h: Revert.
7028         * ax-gdb.c: Revert.
7029         * avr-tdep.c: Revert.
7030         * auxv.c: Revert.
7031         * auto-load.c: Revert.
7032         * arm-wince-tdep.c: Revert.
7033         * arm-tdep.c: Revert.
7034         * arm-symbian-tdep.c: Revert.
7035         * arm-pikeos-tdep.c: Revert.
7036         * arm-obsd-tdep.c: Revert.
7037         * arm-nbsd-tdep.c: Revert.
7038         * arm-nbsd-nat.c: Revert.
7039         * arm-linux-tdep.c: Revert.
7040         * arm-linux-nat.c: Revert.
7041         * arm-fbsd-tdep.c: Revert.
7042         * arm-fbsd-nat.c: Revert.
7043         * arm-bsd-tdep.c: Revert.
7044         * arch-utils.c: Revert.
7045         * arc-tdep.c: Revert.
7046         * arc-newlib-tdep.c: Revert.
7047         * annotate.h: Revert.
7048         * annotate.c: Revert.
7049         * amd64-windows-tdep.c: Revert.
7050         * amd64-windows-nat.c: Revert.
7051         * amd64-tdep.c: Revert.
7052         * amd64-sol2-tdep.c: Revert.
7053         * amd64-obsd-tdep.c: Revert.
7054         * amd64-obsd-nat.c: Revert.
7055         * amd64-nbsd-tdep.c: Revert.
7056         * amd64-nbsd-nat.c: Revert.
7057         * amd64-nat.c: Revert.
7058         * amd64-linux-tdep.c: Revert.
7059         * amd64-linux-nat.c: Revert.
7060         * amd64-fbsd-tdep.c: Revert.
7061         * amd64-fbsd-nat.c: Revert.
7062         * amd64-dicos-tdep.c: Revert.
7063         * amd64-darwin-tdep.c: Revert.
7064         * amd64-bsd-nat.c: Revert.
7065         * alpha-tdep.c: Revert.
7066         * alpha-obsd-tdep.c: Revert.
7067         * alpha-nbsd-tdep.c: Revert.
7068         * alpha-mdebug-tdep.c: Revert.
7069         * alpha-linux-tdep.c: Revert.
7070         * alpha-linux-nat.c: Revert.
7071         * alpha-bsd-tdep.c: Revert.
7072         * alpha-bsd-nat.c: Revert.
7073         * aix-thread.c: Revert.
7074         * agent.c: Revert.
7075         * addrmap.c: Revert.
7076         * ada-varobj.c: Revert.
7077         * ada-valprint.c: Revert.
7078         * ada-typeprint.c: Revert.
7079         * ada-tasks.c: Revert.
7080         * ada-lang.c: Revert.
7081         * aarch64-tdep.c: Revert.
7082         * aarch64-ravenscar-thread.c: Revert.
7083         * aarch64-newlib-tdep.c: Revert.
7084         * aarch64-linux-tdep.c: Revert.
7085         * aarch64-linux-nat.c: Revert.
7086         * aarch64-fbsd-tdep.c: Revert.
7087         * aarch64-fbsd-nat.c: Revert.
7088         * aarch32-linux-nat.c: Revert.
7089
7090 2019-04-05  Tom Tromey  <tom@tromey.com>
7091
7092         * ft32-tdep.c: Sort headers.
7093         * frv-tdep.c: Sort headers.
7094         * frv-linux-tdep.c: Sort headers.
7095         * frame.c: Sort headers.
7096         * frame-unwind.c: Sort headers.
7097         * frame-base.c: Sort headers.
7098         * fork-child.c: Sort headers.
7099         * findvar.c: Sort headers.
7100         * findcmd.c: Sort headers.
7101         * filesystem.c: Sort headers.
7102         * filename-seen-cache.h: Sort headers.
7103         * filename-seen-cache.c: Sort headers.
7104         * fbsd-tdep.c: Sort headers.
7105         * fbsd-nat.h: Sort headers.
7106         * fbsd-nat.c: Sort headers.
7107         * f-valprint.c: Sort headers.
7108         * f-typeprint.c: Sort headers.
7109         * f-lang.c: Sort headers.
7110         * extension.h: Sort headers.
7111         * extension.c: Sort headers.
7112         * extension-priv.h: Sort headers.
7113         * expprint.c: Sort headers.
7114         * exec.h: Sort headers.
7115         * exec.c: Sort headers.
7116         * exceptions.c: Sort headers.
7117         * event-top.c: Sort headers.
7118         * event-loop.c: Sort headers.
7119         * eval.c: Sort headers.
7120         * elfread.c: Sort headers.
7121         * dwarf2read.h: Sort headers.
7122         * dwarf2read.c: Sort headers.
7123         * dwarf2loc.c: Sort headers.
7124         * dwarf2expr.h: Sort headers.
7125         * dwarf2expr.c: Sort headers.
7126         * dwarf2-frame.c: Sort headers.
7127         * dwarf2-frame-tailcall.c: Sort headers.
7128         * dwarf-index-write.h: Sort headers.
7129         * dwarf-index-write.c: Sort headers.
7130         * dwarf-index-common.c: Sort headers.
7131         * dwarf-index-cache.h: Sort headers.
7132         * dwarf-index-cache.c: Sort headers.
7133         * dummy-frame.c: Sort headers.
7134         * dtrace-probe.c: Sort headers.
7135         * disasm.h: Sort headers.
7136         * disasm.c: Sort headers.
7137         * disasm-selftests.c: Sort headers.
7138         * dictionary.c: Sort headers.
7139         * dicos-tdep.c: Sort headers.
7140         * demangle.c: Sort headers.
7141         * dcache.h: Sort headers.
7142         * dcache.c: Sort headers.
7143         * darwin-nat.h: Sort headers.
7144         * darwin-nat.c: Sort headers.
7145         * darwin-nat-info.c: Sort headers.
7146         * d-valprint.c: Sort headers.
7147         * d-namespace.c: Sort headers.
7148         * d-lang.c: Sort headers.
7149         * ctf.c: Sort headers.
7150         * csky-tdep.c: Sort headers.
7151         * csky-linux-tdep.c: Sort headers.
7152         * cris-tdep.c: Sort headers.
7153         * cris-linux-tdep.c: Sort headers.
7154         * cp-valprint.c: Sort headers.
7155         * cp-support.c: Sort headers.
7156         * cp-namespace.c: Sort headers.
7157         * cp-abi.c: Sort headers.
7158         * corelow.c: Sort headers.
7159         * corefile.c: Sort headers.
7160         * continuations.c: Sort headers.
7161         * completer.h: Sort headers.
7162         * completer.c: Sort headers.
7163         * complaints.c: Sort headers.
7164         * coffread.c: Sort headers.
7165         * coff-pe-read.c: Sort headers.
7166         * cli-out.h: Sort headers.
7167         * cli-out.c: Sort headers.
7168         * charset.c: Sort headers.
7169         * c-varobj.c: Sort headers.
7170         * c-valprint.c: Sort headers.
7171         * c-typeprint.c: Sort headers.
7172         * c-lang.c: Sort headers.
7173         * buildsym.c: Sort headers.
7174         * buildsym-legacy.c: Sort headers.
7175         * build-id.h: Sort headers.
7176         * build-id.c: Sort headers.
7177         * btrace.c: Sort headers.
7178         * bsd-uthread.c: Sort headers.
7179         * breakpoint.h: Sort headers.
7180         * breakpoint.c: Sort headers.
7181         * break-catch-throw.c: Sort headers.
7182         * break-catch-syscall.c: Sort headers.
7183         * break-catch-sig.c: Sort headers.
7184         * blockframe.c: Sort headers.
7185         * block.c: Sort headers.
7186         * bfin-tdep.c: Sort headers.
7187         * bfin-linux-tdep.c: Sort headers.
7188         * bfd-target.c: Sort headers.
7189         * bcache.c: Sort headers.
7190         * ax-general.c: Sort headers.
7191         * ax-gdb.h: Sort headers.
7192         * ax-gdb.c: Sort headers.
7193         * avr-tdep.c: Sort headers.
7194         * auxv.c: Sort headers.
7195         * auto-load.c: Sort headers.
7196         * arm-wince-tdep.c: Sort headers.
7197         * arm-tdep.c: Sort headers.
7198         * arm-symbian-tdep.c: Sort headers.
7199         * arm-pikeos-tdep.c: Sort headers.
7200         * arm-obsd-tdep.c: Sort headers.
7201         * arm-nbsd-tdep.c: Sort headers.
7202         * arm-nbsd-nat.c: Sort headers.
7203         * arm-linux-tdep.c: Sort headers.
7204         * arm-linux-nat.c: Sort headers.
7205         * arm-fbsd-tdep.c: Sort headers.
7206         * arm-fbsd-nat.c: Sort headers.
7207         * arm-bsd-tdep.c: Sort headers.
7208         * arch-utils.c: Sort headers.
7209         * arc-tdep.c: Sort headers.
7210         * arc-newlib-tdep.c: Sort headers.
7211         * annotate.h: Sort headers.
7212         * annotate.c: Sort headers.
7213         * amd64-windows-tdep.c: Sort headers.
7214         * amd64-windows-nat.c: Sort headers.
7215         * amd64-tdep.c: Sort headers.
7216         * amd64-sol2-tdep.c: Sort headers.
7217         * amd64-obsd-tdep.c: Sort headers.
7218         * amd64-obsd-nat.c: Sort headers.
7219         * amd64-nbsd-tdep.c: Sort headers.
7220         * amd64-nbsd-nat.c: Sort headers.
7221         * amd64-nat.c: Sort headers.
7222         * amd64-linux-tdep.c: Sort headers.
7223         * amd64-linux-nat.c: Sort headers.
7224         * amd64-fbsd-tdep.c: Sort headers.
7225         * amd64-fbsd-nat.c: Sort headers.
7226         * amd64-dicos-tdep.c: Sort headers.
7227         * amd64-darwin-tdep.c: Sort headers.
7228         * amd64-bsd-nat.c: Sort headers.
7229         * alpha-tdep.c: Sort headers.
7230         * alpha-obsd-tdep.c: Sort headers.
7231         * alpha-nbsd-tdep.c: Sort headers.
7232         * alpha-mdebug-tdep.c: Sort headers.
7233         * alpha-linux-tdep.c: Sort headers.
7234         * alpha-linux-nat.c: Sort headers.
7235         * alpha-bsd-tdep.c: Sort headers.
7236         * alpha-bsd-nat.c: Sort headers.
7237         * aix-thread.c: Sort headers.
7238         * agent.c: Sort headers.
7239         * addrmap.c: Sort headers.
7240         * ada-varobj.c: Sort headers.
7241         * ada-valprint.c: Sort headers.
7242         * ada-typeprint.c: Sort headers.
7243         * ada-tasks.c: Sort headers.
7244         * ada-lang.c: Sort headers.
7245         * aarch64-tdep.c: Sort headers.
7246         * aarch64-ravenscar-thread.c: Sort headers.
7247         * aarch64-newlib-tdep.c: Sort headers.
7248         * aarch64-linux-tdep.c: Sort headers.
7249         * aarch64-linux-nat.c: Sort headers.
7250         * aarch64-fbsd-tdep.c: Sort headers.
7251         * aarch64-fbsd-nat.c: Sort headers.
7252         * aarch32-linux-nat.c: Sort headers.
7253
7254 2019-04-04  Tom Tromey  <tom@tromey.com>
7255
7256         * varobj.c (varobj_create): Update.
7257         * rust-exp.y (struct rust_parser) <update_innermost_block,
7258         lookup_symbol>: New methods.
7259         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7260         Rename.
7261         (rust_parser::rust_lookup_type)
7262         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7263         * printcmd.c (display_command, do_one_display): Update.
7264         * parser-defs.h (struct parser_state) <parser_state>: Add
7265         "tracker" parameter.
7266         (block_tracker): New member.
7267         (class innermost_block_tracker) <innermost_block_tracker>: Add
7268         "types" parameter.
7269         <reset>: Remove method.
7270         (innermost_block): Don't declare.
7271         (null_post_parser): Update.
7272         * parse.c (innermost_block): Remove global.
7273         (write_dollar_variable): Update.
7274         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7275         Remove "tracker_types" parameter.
7276         (parse_expression): Add "tracker" parameter.
7277         (parse_expression_for_completion): Update.
7278         (null_post_parser): Add "tracker" parameter.
7279         * p-exp.y: Update rules.
7280         * m2-exp.y: Update rules.
7281         * language.h (struct language_defn) <la_post_parser>: Add
7282         "tracker" parameter.
7283         * go-exp.y: Update rules.
7284         * f-exp.y: Update rules.
7285         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7286         parameter.
7287         * d-exp.y: Update rules.
7288         * c-exp.y: Update rules.
7289         * breakpoint.c (set_breakpoint_condition): Create an
7290         innermost_block_tracker.
7291         (watch_command_1): Likewise.
7292         * ada-lang.c (resolve): Add "tracker" parameter.
7293         (resolve_subexp): Likewise.
7294         * ada-exp.y (write_var_from_sym): Update.
7295
7296 2019-04-04  Tom Tromey  <tom@tromey.com>
7297
7298         * type-stack.h: New file.
7299         * type-stack.c: New file.
7300         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7301         type-stack.h.
7302         (insert_into_type_stack, insert_type, push_type, push_type_int)
7303         (insert_type_address_space, pop_type, pop_type_int)
7304         (pop_typelist, pop_type_stack, append_type_stack)
7305         (push_type_stack, get_type_stack, push_typelist)
7306         (follow_type_instance_flags, follow_types): Don't declare.
7307         * parse.c (type_stack): Remove global.
7308         (parse_exp_in_context): Update.
7309         (insert_into_type_stack, insert_type, push_type, push_type_int)
7310         (insert_type_address_space, pop_type, pop_type_int)
7311         (pop_typelist, pop_type_stack, append_type_stack)
7312         (push_type_stack, get_type_stack, push_typelist)
7313         (follow_type_instance_flags, follow_types): Remove (moved to
7314         type-stack.c).
7315         * f-exp.y (type_stack): New global.
7316         Update rules.
7317         (push_kind_type, f_parse): Update.
7318         * d-exp.y (type_stack): New global.
7319         Update rules.
7320         (d_parse): Update.
7321         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7322         Update rules.
7323         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7324         (HFILES_NO_SRCDIR): Add type-stack.h.
7325
7326 2019-04-04  Tom Tromey  <tom@tromey.com>
7327
7328         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7329         (rust_parser::convert_ast_to_expression, rust_parse)
7330         (rust_lex_test_completion, rust_lex_tests): Update.
7331         * parser-defs.h (struct expr_completion_state): New.
7332         (struct parser_state) <parser_state>: Add completion parameter.
7333         <mark_struct_expression, mark_completion_tag>: New methods.
7334         <parse_completion, m_completion_state>: New members.
7335         (prefixify_expression, null_post_parser): Update.
7336         (mark_struct_expression, mark_completion_tag): Don't declare.
7337         * parse.c (parse_completion, expout_last_struct)
7338         (expout_tag_completion_type, expout_completion_name): Remove
7339         globals.
7340         (parser_state::mark_struct_expression)
7341         (parser_state::mark_completion_tag): Now methods.
7342         (prefixify_expression): Add last_struct parameter.
7343         (prefixify_subexp): Likewise.
7344         (parse_exp_1): Update.
7345         (parse_exp_in_context): Add cstate parameter.  Update.
7346         (parse_expression_for_completion): Create an
7347         expr_completion_state.
7348         (null_post_parser): Add "completion" parameter.
7349         * p-exp.y: Update rules.
7350         (yylex): Update.
7351         * language.h (struct language_defn) <la_post_parser>: Add
7352         "completing" parameter.
7353         * go-exp.y: Update rules.
7354         (lex_one_token): Update.
7355         * expression.h (parse_completion): Don't declare.
7356         * d-exp.y: Update rules.
7357         (lex_one_token): Update rules.
7358         * c-exp.y: Update rules.
7359         (lex_one_token): Update.
7360         * ada-lang.c (resolve): Add "parse_completion" parameter.
7361         (resolve_subexp): Likewise.
7362         (ada_resolve_function): Likewise.
7363
7364 2019-04-04  Tom Tromey  <tom@tromey.com>
7365
7366         * parser-defs.h (struct parser_state) <start_arglist,
7367         end_arglist>: New methods.
7368         <arglist_len, m_funcall_chain>: New members.
7369         (arglist_len, start_arglist, end_arglist): Don't declare.
7370         * parse.c (arglist_len, funcall_chain): Remove global.
7371         (start_arglist, end_arglist): Remove functions.
7372         (parse_exp_in_context): Update.
7373         * p-exp.y: Update rules.
7374         * m2-exp.y: Update rules.
7375         * go-exp.y: Update rules.
7376         * f-exp.y: Update rules.
7377         * d-exp.y: Update rules.
7378         * c-exp.y: Update rules.
7379
7380 2019-04-04  Tom Tromey  <tom@tromey.com>
7381
7382         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7383         lex_operator, push_back>: New methods.
7384         Update all rules.
7385         (rust_parser::lex_hex, lex_escape): Rename and update.
7386         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7387         (rust_parser::lex_operator): Rename and update.
7388         (rust_parser::lex_number, rustyylex, rustyyerror)
7389         (rust_lex_test_init, rust_lex_test_sequence)
7390         (rust_lex_test_push_back, rust_lex_tests): Update.
7391         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7392         parameter.
7393         <lexptr, prev_lexptr>: New members.
7394         (lexptr, prev_lexptr): Don't declare.
7395         * parse.c (lexptr, prev_lexptr): Remove globals.
7396         (parse_exp_in_context): Update.
7397         * p-exp.y (yylex, yyerror): Update.
7398         * m2-exp.y (parse_number, yylex, yyerror): Update.
7399         * go-exp.y (lex_one_token, yyerror): Update.
7400         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7401         * d-exp.y (lex_one_token, yyerror): Update.
7402         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7403         (lex_one_token, yyerror): Update.
7404         * ada-lex.l (YY_INPUT): Update.
7405         (rewind_to_char): Update.
7406         * ada-exp.y (yyerror): Update.
7407
7408 2019-04-04  Tom Tromey  <tom@tromey.com>
7409
7410         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7411         * parser-defs.h (struct parser_state) <parser_state>: Add new
7412         parameter.
7413         <comma_terminates>: New member.
7414         (comma_terminates): Don't declare global.
7415         * parse.c (comma_terminates): Remove global.
7416         (parse_exp_in_context): Update.
7417         * p-exp.y (yylex): Update.
7418         * m2-exp.y (yylex): Update.
7419         * go-exp.y (lex_one_token): Update.
7420         * f-exp.y (yylex): Update.
7421         * d-exp.y (lex_one_token): Update.
7422         * c-exp.y (lex_one_token): Update.
7423         * ada-lex.l: Update.
7424
7425 2019-04-04  Tom Tromey  <tom@tromey.com>
7426
7427         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7428         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7429         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7430         * parser-defs.h (paren_depth): Don't declare.
7431         * parse.c (paren_depth): Remove global.
7432         (parse_exp_in_context): Update.
7433         * p-exp.y (paren_depth): New global.
7434         (pascal_parse): Initialize it.
7435         * m2-exp.y (paren_depth): New global.
7436         (m2_parse): Initialize it.
7437         * go-exp.y (paren_depth): New global.
7438         (go_parse): Initialize it.
7439         * f-exp.y (paren_depth): New global.
7440         (f_parse): Initialize it.
7441         * d-exp.y (paren_depth): New global.
7442         (d_parse): Initialize it.
7443         * c-exp.y (paren_depth): New global.
7444         (c_parse): Initialize it.
7445         * ada-lex.l (paren_depth): New global.
7446         (lexer_init): Initialize it.
7447
7448 2019-04-04  Tom Tromey  <tom@tromey.com>
7449
7450         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7451         (rust_parser::convert_ast_to_type)
7452         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7453         * parser-defs.h (struct parser_state) <parser_state>: Add
7454         parameters.  Initialize new members.
7455         <expression_context_block, expression_context_pc>: New members.
7456         * parse.c (expression_context_block, expression_context_pc):
7457         Remove globals.
7458         (parse_exp_in_context): Update.
7459         * p-exp.y: Update all rules.
7460         (yylex): Update.
7461         * m2-exp.y: Update all rules.
7462         (yylex): Update.
7463         * go-exp.y (yylex): Update.
7464         * f-exp.y (yylex): Update.
7465         * d-exp.y: Update all rules.
7466         (yylex): Update.
7467         * c-exp.y: Update all rules.
7468         (lex_one_token, classify_name, yylex, c_parse): Update.
7469         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7470
7471 2019-04-04  Tom Tromey  <tom@tromey.com>
7472
7473         * gdbarch.h, gdbarch.c: Rebuild.
7474         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7475         * stap-probe.h:
7476         (struct stap_parse_info): Replace "parser_state" with
7477         "expr_builder".
7478         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7479         (parser_state): New class.
7480         * parse.c (expr_builder): Rename.
7481         (expr_builder::release): Rename.
7482         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7483         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7484         (write_exp_elt_longcst, write_exp_elt_floatcst)
7485         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7486         (write_exp_string_vector, write_exp_bitstring)
7487         (write_exp_msymbol, mark_struct_expression)
7488         (write_dollar_variable)
7489         (insert_type_address_space, increase_expout_size): Replace
7490         "parser_state" with "expr_builder".
7491         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7492         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7493         "parser_state" with "expr_builder".
7494
7495 2019-04-04  Tom Tromey  <tom@tromey.com>
7496
7497         * rust-exp.y: Replace "parse_language" with method call.
7498         * p-exp.y:
7499         (yylex): Replace "parse_language" with method call.
7500         * m2-exp.y:
7501         (yylex): Replace "parse_language" with method call.
7502         * go-exp.y (classify_name): Replace "parse_language" with method
7503         call.
7504         * f-exp.y (yylex): Replace "parse_language" with method call.
7505         * d-exp.y (lex_one_token): Replace "parse_language" with method
7506         call.
7507         * c-exp.y:
7508         (lex_one_token, classify_name, yylex): Replace "parse_language"
7509         with method call.
7510         * ada-exp.y (find_primitive_type, type_char)
7511         (type_system_address): Replace "parse_language" with method call.
7512
7513 2019-04-04  Tom Tromey  <tom@tromey.com>
7514
7515         * rust-exp.y: Replace "parse_gdbarch" with method call.
7516         * parse.c (write_dollar_variable, insert_type_address_space):
7517         Replace "parse_gdbarch" with method call.
7518         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7519         call.
7520         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7521         call.
7522         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7523         "parse_gdbarch" with method call.
7524         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7525         with method call.
7526         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7527         "parse_gdbarch" with method call.
7528         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7529         "parse_gdbarch" with method call.
7530         * c-exp.y (parse_type, parse_number, classify_name): Replace
7531         "parse_gdbarch" with method call.
7532         * ada-lex.l: Replace "parse_gdbarch" with method call.
7533         * ada-exp.y (parse_type, find_primitive_type, type_char)
7534         (type_system_address): Replace "parse_gdbarch" with method call.
7535
7536 2019-04-04  Tom Tromey  <tom@tromey.com>
7537
7538         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7539         * stap-probe.c (stap_parse_argument): Update.
7540         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7541         initial_size parameter.
7542         * rust-exp.y (rust_lex_tests): Update.
7543         * parse.c (parser_state): Update.
7544         (parse_exp_in_context): Update.
7545         * parser-defs.h (struct parser_state) <parser_state>: Remove
7546         "initial_size" parameter.
7547
7548 2019-04-04  Tom Tromey  <tom@tromey.com>
7549
7550         * parser-defs.h (increase_expout_size): Don't declare.
7551         * parse.c (increase_expout_size): Now static.
7552
7553 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7554
7555         * gnu-nat.c (gnu_nat_target::wait): Fix
7556         target_waitstatus_to_string call.
7557
7558 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7559
7560         * eval.c (evaluate_subexp_standard): Handle internal functions
7561         during Fortran function call handling.
7562
7563 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7564
7565         * NEWS: Mention new internal functions.
7566         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7567         (read_base_type): Use dwarf2_init_complex_target_type.
7568         * value.c (creal_internal_fn): New function.
7569         (cimag_internal_fn): New function.
7570         (_initialize_values): Register new internal functions.
7571
7572 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7573
7574         * infrun.c (stop_all_threads): If debug_infrun, always
7575         trace the wait status after wait_one, using
7576         target_waitstatus_to_string and target_pid_to_str.
7577         (handle_inferior_event): Replace various trace of
7578         wait status kind by a single trace.
7579         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7580         wait status kind image by target_waitstatus_to_string.
7581         * target/waitstatus.c (target_waitstatus_to_string): Fix
7582         obsolete comment.
7583
7584 2019-04-01  Tom Tromey  <tromey@adacore.com>
7585
7586         PR symtab/23331:
7587         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7588
7589 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7590             Pedro Alves  <palves@redhat.com>
7591
7592         * top.c (quit_force): Call 'finalize_values'.
7593         * value.c (finalize_values): New function.
7594         * value.h (finalize_values): Declare.
7595
7596 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7597
7598         * NEWS: Announce $_gdb_major and $_gdb_minor.
7599
7600         * top.c (init_gdb_version_vars): New function.
7601         (gdb_init): Call init_gdb_version_vars.
7602
7603 2019-03-29  Tom Tromey  <tromey@adacore.com>
7604
7605         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7606         help text.  Remove dead code.
7607
7608 2019-03-29  Keith Seitz  <keiths@redhat.com>
7609
7610         From Siddhesh Poyarekar:
7611         * f-lang.h (f77_get_upperbound): Return LONGEST.
7612         (f77_get_lowerbound): Likewise.
7613         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7614         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7615         print them.
7616         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7617         plongest to format print it.
7618         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7619         (f77_get_upperbound): Likewise.
7620         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7621         LOWER_BOUND to LONGEST.
7622         (f77_create_arrayprint_offset_tbl): Likewise.
7623
7624 2019-03-29  Keith Seitz  <keiths@redhat.com>
7625
7626         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7627         %s/pulongest for TYPE_LENGTH instead of %d in format
7628         strings.
7629         * ada-typerint.c (ada_print_type): Likewise.
7630         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7631         * compile/compile-c-support.c (generate_register_struct): Likewise.
7632         * gdbtypes.c (recursive_dump_type): Likewise.
7633         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7634         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7635         instead of %d in format strings.
7636         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7637         to std::min to ULONGEST.
7638         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7639         instead of %d in format strings.
7640         * tracepoint.c (info_scope_command): Likewise.
7641         * typeprint.c (print_offset_data::update)
7642         (print_offset_data::finish): Likewise.
7643         * xtensa-tdep.c (xtensa_store_return_value)
7644         (xtensa_push_dummy_call): Likewise.
7645
7646 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7647
7648         * windows-nat.c (display_selector): Fixed format specifications
7649         for 64-bit Cygwin.
7650
7651 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7652
7653         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7654
7655 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7656
7657         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7658         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7659         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7660         (nios2_linux_init_abi): Install it.
7661
7662 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7663
7664         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7665
7666 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7667
7668         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7669
7670 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7671             Tom Tromey  <tromey@adacore.com>
7672
7673         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7674
7675 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7676
7677         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7678         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7679         method to compute the bounds of range types. Also print "[evaluated]"
7680         if the bounds' values come from a dynamic evaluation.
7681
7682 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7683
7684         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7685         whitespace when pretty printing is on.
7686
7687 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7688
7689         * ppc-linux-nat.c: Add include.
7690
7691 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7692
7693         * NEWS: Mention AArch64 Pointer Authentication.
7694
7695 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7696
7697         * arm-linux-nat.c: Add include.
7698
7699 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7700
7701         * source-cache.c (source_cache::get_source_lines): Re-read
7702         fullname after calling open_source_file.
7703
7704 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7705
7706         * NEWS: Mention TLS support for FreeBSD.
7707
7708 2019-03-25  Tom Tromey  <tromey@adacore.com>
7709
7710         * minsyms.c (BUNCH_SIZE): Update comment.
7711         (~minimal_symbol_reader): Remove old comment.
7712         (compact_minimal_symbols): Update comment.
7713         (minimal_symbol_reader::install): Remove old comment.  Update
7714         other comments.
7715
7716 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7717
7718         * s390-linux-nat.c: Add include.
7719
7720 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7721
7722         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7723         Call linux_get_hwcap.
7724         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7725         Likewise.
7726         (aarch64_linux_get_hwcap): Remove function.
7727         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7728         declaration.
7729         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7730         linux_get_hwcap.
7731         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7732         * linux-tdep.c (linux_get_hwcap): Add function.
7733         (linux_get_hwcap2): Likewise.
7734         * linux-tdep.h (linux_get_hwcap): Add declaration.
7735         (linux_get_hwcap2): Likewise.
7736         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7737         (ppc_linux_get_hwcap2): Likewise.
7738         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7739         linux_get_hwcap.
7740         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7741         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7742         (ppc_linux_nat_target::read_description): Likewise.
7743         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7744         * s390-linux-nat.c: Likewise.
7745         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7746
7747 2019-03-24  Tom Tromey  <tom@tromey.com>
7748
7749         * ada-lang.c (standard_lookup): Simplify initialization.
7750         (ada_lookup_symbol_nonlocal): Simplify return.
7751         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7752         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7753         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7754         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7755         initialization.
7756         * solib.c (solib_global_lookup): Simplify.
7757         * symtab.c (null_block_symbol): Remove.
7758         (symbol_cache_lookup): Simplify returns.
7759         (lookup_language_this): Simplify returns.
7760         (lookup_symbol_aux): Simplify return.
7761         (lookup_local_symbol): Simplify returns.
7762         (lookup_global_symbol_from_objfile): Simplify return.
7763         (lookup_symbol_in_objfile_symtabs)
7764         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7765         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7766         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7767         * cp-namespace.c (cp_lookup_bare_symbol)
7768         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7769         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7770         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7771         (cp_lookup_symbol_via_imports): Simplify initialization.
7772         (find_symbol_in_baseclass): Likewise.
7773         * symtab.h (null_block_symbol): Remove.
7774         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7775         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7776         (d_lookup_symbol_module): Likewise.
7777         (find_symbol_in_baseclass): Simplify initialization.
7778
7779 2019-03-24  Tom Tromey  <tom@tromey.com>
7780
7781         * expression.h: Don't include symtab.h.
7782         (struct block): Forward declare.
7783
7784 2019-03-24  Tom Tromey  <tom@tromey.com>
7785
7786         * c-exp.y (typebase): Remove casts.
7787         * gdbtypes.c (lookup_unsigned_typename, )
7788         (lookup_signed_typename): Remove cast.
7789         * eval.c (parse_to_comma_and_eval): Remove cast.
7790         * parse.c (write_dollar_variable): Remove cast.
7791         * block.h (struct block) <superblock>: Now const.
7792         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7793         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7794         (map_block): Make "block" const.
7795         * symfile.h (struct quick_symbol_functions)
7796         <map_matching_symbols>: Constify block argument to "callback".
7797         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7798         const.
7799         (find_pc_sect_compunit_symtab): Make "b" const.
7800         (find_symbol_at_address): Likewise.
7801         (search_symbols): Likewise.
7802         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7803         (dw2_debug_names_lookup_symbol): Likewise.
7804         (dw2_map_matching_symbols): Update.
7805         * p-valprint.c (pascal_val_print): Remove "block".
7806         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7807         (aux_add_nonlocal_symbols): Make "block" const.
7808         (resolve_subexp): Remove cast.
7809         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7810         const.
7811         (iterate_over_file_blocks): Likewise.
7812         * f-exp.y (%union) <bval>: Remove.
7813         * coffread.c (patch_opaque_types): Make "b" const.
7814         * spu-tdep.c (spu_catch_start): Make "block" const.
7815         * c-valprint.c (print_unpacked_pointer): Remove "block".
7816         * symmisc.c (dump_symtab_1): Make "b" const.
7817         (block_depth): Make "block" const.
7818         * d-exp.y (%union) <bval>: Remove.
7819         * cp-support.h (cp_lookup_rtti_type): Update.
7820         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7821         * psymtab.c (psym_lookup_symbol): Make "block" const.
7822         (maintenance_check_psymtabs): Make "b" const.
7823         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7824         (enumerate_locals, enumerate_args): Update.
7825         * python/py-symtab.c (stpy_global_block): Make "block" const.
7826         (stpy_static_block): Likewise.
7827         * inline-frame.c (block_starting_point_at): Make "new_block"
7828         const.
7829         * block.c (find_block_in_blockvector): Make return type const.
7830         (blockvector_for_pc_sect): Make "b" const.
7831         (find_block_in_blockvector): Make "b" const.
7832
7833 2019-03-23  Tom Tromey  <tom@tromey.com>
7834
7835         * varobj.c (varobj_create): Update.
7836         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7837         * printcmd.c (display_command, do_one_display): Don't reset
7838         innermost_block.
7839         * parser-defs.h (enum innermost_block_tracker_type): Move to
7840         expression.h.
7841         (innermost_block): Update comment.
7842         * parse.c (parse_exp_1): Add tracker_types parameter.
7843         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7844         tracker_types parameter.  Reset innermost_block.
7845         (parse_exp_in_context): Remove.
7846         (parse_expression_for_completion): Update.
7847         * objfiles.c (~objfile): Don't reset expression_context_block or
7848         innermost_block.
7849         * expression.h (enum innermost_block_tracker_type): Move from
7850         parser-defs.h.
7851         (parse_exp_1): Add tracker_types parameter.
7852         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7853         reset innermost_block.
7854
7855 2019-03-23  Tom Tromey  <tom@tromey.com>
7856
7857         * objfiles.h: Include bcache.h.
7858
7859 2019-03-23  Tom Tromey  <tom@tromey.com>
7860
7861         * linespec.c (get_current_search_block): Use
7862         scoped_restore_current_language.
7863         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7864
7865 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7866             Jiong Wang  <jiong.wang@arm.com>
7867
7868         * aarch64-linux-tdep.c
7869         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7870         section.
7871         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7872
7873 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7874             Jiong Wang  <jiong.wang@arm.com>
7875
7876         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7877         instructions.
7878         (aarch64_analyze_prologue_test): Add PACIASP test.
7879         (aarch64_prologue_prev_register): Unmask PC value.
7880
7881 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7882             Jiong Wang  <jiong.wang@arm.com>
7883
7884         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7885         (aarch64_dwarf2_prev_register): Unmask PC value.
7886         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7887         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7888         DW_CFA_AARCH64_negate_ra_state.
7889         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7890
7891 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7892             Jiong Wang  <jiong.wang@arm.com>
7893
7894         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7895         registers.
7896         (aarch64_pseudo_register_name): Likewise.
7897         (aarch64_pseudo_register_type): Likewise.
7898         (aarch64_pseudo_register_reggroup_p): Likewise.
7899         (aarch64_gdbarch_init): Add pauth registers.
7900         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7901         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7902         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7903         (struct gdbarch_tdep): Add regnum for ra_state.
7904
7905 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7906             Jiong Wang  <jiong.wang@arm.com>
7907
7908         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7909
7910 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7911             Jiong Wang  <jiong.wang@arm.com>
7912
7913         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7914         function.
7915         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7916         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7917         (aarch64_gdbarch_init): Add puth registers.
7918         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7919         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7920         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7921
7922 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7923             Jiong Wang  <jiong.wang@arm.com>
7924
7925         * aarch64-linux-nat.c
7926         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7927         * aarch64-linux-tdep.c
7928         (aarch64_linux_core_read_description): Likewise.
7929         (aarch64_linux_get_hwcap): New function.
7930         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7931         (aarch64_linux_get_hwcap): New declaration.
7932
7933 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7934             Jiong Wang  <jiong.wang@arm.com>
7935
7936         * aarch64-linux-nat.c
7937         (aarch64_linux_nat_target::read_description): Add pauth param.
7938         * aarch64-linux-tdep.c
7939         (aarch64_linux_core_read_description): Likewise.
7940         * aarch64-tdep.c (struct target_desc): Add in pauth.
7941         (aarch64_read_description): Add pauth param.
7942         (aarch64_gdbarch_init): Likewise.
7943         * aarch64-tdep.h (aarch64_read_description): Likewise.
7944         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7945         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7946         * features/Makefile: Add new files.
7947         * features/aarch64-pauth.c: New file.
7948         * features/aarch64-pauth.xml: New file.
7949
7950 2019-03-20  Tom Tromey  <tromey@adacore.com>
7951
7952         * infrun.c (handle_inferior_event): Rename from
7953         handle_inferior_event_1.  Create a scoped_value_mark.
7954         (handle_inferior_event): Remove.
7955
7956 2019-03-19  Tom Tromey  <tromey@adacore.com>
7957
7958         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7959         * infrun.h (print_stop_event): Add "displays" parameter.
7960         * infrun.c (print_stop_event): Add "displays" parameter.
7961
7962 2019-03-19  Pedro Alves  <palves@redhat.com>
7963
7964         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7965         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7966         to -1.  Fix TABs vs spaces.
7967         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7968         * tui/tui-out.h (tui_ui_out) Add intro comments.
7969         <m_line, m_start_of_line>: In-class initialize, and add describing
7970         comment.
7971
7972 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7973
7974         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7975         variable names.
7976         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7977
7978 2019-03-18  Pedro Alves  <palves@redhat.com>
7979             Eli Zaretskii <eliz@gnu.org>
7980
7981         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7982         m_line and m_start_of_line.
7983
7984 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7985
7986         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7987         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7988         it returns a newline.  This fixes a regression in TU mode, whereby
7989         the next line is output on the same screen line as the user input.
7990
7991 2019-03-18  Tom Tromey  <tromey@adacore.com>
7992
7993         * minsyms.c (minimal_symbol_reader::install): Remove call to
7994         obstack_blank.
7995
7996 2019-03-18  Pedro Alves  <palves@redhat.com>
7997
7998         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7999         New globals.
8000         (apply_style): New, factored out from ...
8001         (apply_ansi_escape): ... this.  Handle reverse video mode.
8002         (tui_set_reverse_mode): New function.
8003         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8004         * tui/tui-winsource.c (tui_show_source_line): Use
8005         tui_set_reverse_mode instead of setting A_STANDOUT.
8006         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8007         New setter methods.
8008
8009 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8010
8011         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8012         Handle tabs.
8013
8014 2019-03-18  Tom Tromey  <tromey@adacore.com>
8015
8016         * ada-lang.c (empty_array): Add "high" parameter.
8017         (ada_evaluate_subexp): Update.
8018
8019 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8020
8021         * unittests/string_view-selftests.c: Define
8022         _initialize_string_view_selftests unconditionally.
8023
8024 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8025
8026         PR gdb/24350
8027         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8028
8029 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8030
8031         PR gdb/24351
8032         * windows-nat.c (display_selector): Fix format specifiers.
8033
8034 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8035
8036         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8037         tui_refill_source_window instead of tui_refresh_win, to update the
8038         current execution line.  This fixes redisplay of the current line
8039         when stepping through the code with "next" or "step".
8040
8041 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8042
8043         * source-cache.c (source_cache::get_source_lines): Call
8044         find_source_lines to initialize s->nlines.  This fixes vertical
8045         scrolling of TUI source window when the DOWN arrow is pressed.
8046
8047 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8048
8049         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8050         linux-thread-db.c (_initialize_thread_db): Likewise.
8051
8052 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8053
8054         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8055         wclrtoeol in tui_show_source_line".  This reverts changes made in
8056         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8057
8058 2019-03-15  Tom Tromey  <tom@tromey.com>
8059
8060         * symtab.h (struct minimal_symbol): Derive from
8061         general_symbol_info.
8062         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8063         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8064         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8065         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8066         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8067         (MSYMBOL_SEARCH_NAME): Update.
8068         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8069         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8070         * minsyms.c (minimal_symbol_reader::record_full): Update.
8071
8072 2019-03-15  Tom Tromey  <tom@tromey.com>
8073
8074         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8075
8076 2019-03-15  Tom Tromey  <tom@tromey.com>
8077
8078         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8079         unique_xmalloc_ptr.
8080         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8081         Update.
8082         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8083         (build_minimal_symbol_hash_tables)
8084         (minimal_symbol_reader::install): Update.
8085
8086 2019-03-15  Tom Tromey  <tom@tromey.com>
8087
8088         * symtab.c (create_demangled_names_hash): Update.
8089         (symbol_set_names): Update.
8090         * objfiles.h (struct objfile_per_bfd_storage)
8091         <demangled_names_hash>: Now an htab_up.
8092         * objfiles.c (objfile_per_bfd_storage): Simplify.
8093
8094 2019-03-15  Tom Tromey  <tom@tromey.com>
8095
8096         * objfiles.h (struct objfile_per_bfd_storage): Declare
8097         destructor.
8098         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8099         New.
8100         (get_objfile_bfd_data): Use new.  Don't initialize
8101         language_of_main.
8102         (free_objfile_per_bfd_storage): Remove.
8103         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8104
8105 2019-03-15  Tom Tromey  <tom@tromey.com>
8106
8107         * symfile.c (reread_symbols): Update.
8108         * objfiles.c (objfile::objfile): Update.
8109         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8110         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8111         comment.
8112         (minimal_symbol_reader::install): Update.
8113         (terminate_minimal_symbol_table): Remove.
8114         * jit.c (jit_object_close_impl): Update.
8115
8116 2019-03-15  Tom Tromey  <tom@tromey.com>
8117
8118         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8119         initializations.
8120
8121 2019-03-15  Tom Tromey  <tom@tromey.com>
8122
8123         * objfiles.h (struct objfile_per_bfd_storage)
8124         <demangled_hash_languages>: Now a bitset.
8125         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8126         (lookup_minimal_symbol): Update.
8127
8128 2019-03-15  Tom Tromey  <tom@tromey.com>
8129
8130         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8131         Don't return the symbol.
8132         * coffread.c (record_minimal_symbol): Use record_full.
8133
8134 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8135
8136         The MS-Windows port of ncurses fails to switch to a color pair if
8137         one or both of the colors are the implicit default colors.  This
8138         change records the default colors when TUI is initialized, and
8139         then specifies them explicitly when a color pair uses the default
8140         colors.  This allows color styling in TUI mode on MS-Windows.
8141
8142         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8143         ncurses_norm_attr.
8144         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8145         colors in ncurses_norm_attr.
8146         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8147         "none", replace it with the default color recorded in
8148         ncurses_norm_attr.
8149
8150 2019-03-14  Tom Tromey  <tromey@adacore.com>
8151
8152         * source-cache.h (class source_cache) <get_source_lines>: Return
8153         std::string.
8154         * source-cache.c (source_cache::extract_lines): Handle case where
8155         first_pos==npos.  Return std::string.
8156         (source_cache::get_source_lines): Update.
8157
8158 2019-03-14  Tom Tromey  <tromey@adacore.com>
8159
8160         * NEWS: Add item for "style sources" commands.
8161         * source-cache.c (source_cache::get_source_lines): Check
8162         source_styling.
8163         * cli/cli-style.c (source_styling): New global.
8164         (_initialize_cli_style): Add "style sources" commands.
8165         (show_style_sources): New function.
8166         * cli/cli-style.h (source_styling): Declare.
8167
8168 2019-03-14  Pedro Alves  <palves@redhat.com>
8169             Tom Tromey  <tromey@adacore.com>
8170
8171         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8172         * tui/tui-winsource.c (tui_refill_source_window): New function,
8173         from...
8174         (tui_horizontal_source_scroll): ... here.  Move some logic.
8175         * cli/cli-style.c (set_style_enabled): Notify new observable.
8176         * tui/tui-hooks.c (tui_redisplay_source): New function.
8177         (tui_attach_detach_observers): Attach or detach
8178         tui_redisplay_source.
8179         * observable.h (source_styling_changed): New observable.
8180         * observable.c: Define source_styling_changed observable.
8181
8182 2019-03-13  Tom Tromey  <tromey@adacore.com>
8183
8184         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8185         (i386_gnu_nat_target::store_registers): Update.
8186         * target-debug.h (target_debug_print_std_string): New macro.
8187         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8188         * windows-tdep.c (display_one_tib): Update.
8189         * tui/tui-stack.c (tui_make_status_line): Update.
8190         * top.c (print_inferior_quit_action): Update.
8191         * thread.c (thr_try_catch_cmd): Update.
8192         (add_thread_with_info): Update.
8193         (thread_target_id_str): Update.
8194         (thr_try_catch_cmd): Update.
8195         (thread_command): Update.
8196         (thread_find_command): Update.
8197         * record-btrace.c (record_btrace_target::info_record)
8198         (record_btrace_resume_thread, record_btrace_target::resume)
8199         (record_btrace_cancel_resume, record_btrace_step_thread)
8200         (record_btrace_target::wait, record_btrace_target::wait)
8201         (record_btrace_target::wait, record_btrace_target::stop): Update.
8202         * progspace.c (print_program_space): Update.
8203         * process-stratum-target.c
8204         (process_stratum_target::thread_address_space): Update.
8205         * linux-fork.c (linux_fork_mourn_inferior)
8206         (detach_checkpoint_command, info_checkpoints_command)
8207         (linux_fork_context): Update.
8208         (linux_fork_detach): Update.
8209         (class scoped_switch_fork_info): Update.
8210         (delete_checkpoint_command): Update.
8211         * infrun.c (follow_fork_inferior): Update.
8212         (follow_fork_inferior): Update.
8213         (proceed_after_vfork_done): Update.
8214         (handle_vfork_child_exec_or_exit): Update.
8215         (follow_exec): Update.
8216         (displaced_step_prepare_throw): Update.
8217         (displaced_step_restore): Update.
8218         (start_step_over): Update.
8219         (resume_1): Update.
8220         (clear_proceed_status_thread): Update.
8221         (proceed): Update.
8222         (print_target_wait_results): Update.
8223         (do_target_wait): Update.
8224         (context_switch): Update.
8225         (stop_all_threads): Update.
8226         (restart_threads): Update.
8227         (finish_step_over): Update.
8228         (handle_signal_stop): Update.
8229         (switch_back_to_stepped_thread): Update.
8230         (keep_going_pass_signal): Update.
8231         (print_exited_reason): Update.
8232         (normal_stop): Update.
8233         * inferior.c (inferior_pid_to_str): Change return type.
8234         (print_selected_inferior): Update.
8235         (add_inferior): Update.
8236         (detach_inferior): Update.
8237         * dummy-frame.c (fprint_dummy_frames): Update.
8238         * dcache.c (dcache_info_1): Update.
8239         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8240         (btrace_fetch, btrace_clear): Update.
8241         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8242         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8243         type.
8244         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8245         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8246         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8247         * gdbarch.c, gdbarch.h: Rebuild.
8248         * gdbarch.sh (core_pid_to_str): Change return type.
8249         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8250         return type.
8251         (windows_nat_target::pid_to_str): Change return type.
8252         (windows_delete_thread): Update.
8253         (windows_nat_target::attach): Update.
8254         (windows_nat_target::files_info): Update.
8255         * target-delegates.c: Rebuild.
8256         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8257         return type.
8258         (sol_thread_target::pid_to_str): Change return type.
8259         * remote.c (class remote_target) <pid_to_str>: Change return
8260         type.
8261         (remote_target::pid_to_str): Change return type.
8262         (extended_remote_target::attach, remote_target::remote_stop_ns)
8263         (remote_target::remote_notif_remove_queued_reply)
8264         (remote_target::push_stop_reply, remote_target::disable_btrace):
8265         Update.
8266         (extended_remote_target::attach): Update.
8267         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8268         type.
8269         (gdbsim_target::pid_to_str): Change return type.
8270         * ravenscar-thread.c (struct ravenscar_thread_target)
8271         <pid_to_str>: Change return type.
8272         (ravenscar_thread_target::pid_to_str): Change return type.
8273         * procfs.c (class procfs_target) <pid_to_str>: Change return
8274         type.
8275         (procfs_target::pid_to_str): Change return type.
8276         (procfs_target::attach): Update.
8277         (procfs_target::detach): Update.
8278         (procfs_target::fetch_registers): Update.
8279         (procfs_target::store_registers): Update.
8280         (procfs_target::wait): Update.
8281         (procfs_target::files_info): Update.
8282         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8283         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8284         return type.
8285         (nto_procfs_target::pid_to_str): Change return type.
8286         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8287         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8288         return type.
8289         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8290         (exit_lwp): Update.
8291         (attach_proc_task_lwp_callback, get_detach_signal)
8292         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8293         (linux_nat_target::resume, wait_lwp, stop_callback)
8294         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8295         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8296         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8297         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8298         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8299         type.
8300         (inf_ptrace_target::attach): Update.
8301         (inf_ptrace_target::files_info): Update.
8302         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8303         type.
8304         (go32_nat_target::pid_to_str): Change return type.
8305         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8306         (gnu_nat_target::wait): Update.
8307         (gnu_nat_target::wait): Update.
8308         (gnu_nat_target::resume): Update.
8309         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8310         (fbsd_nat_target::wait): Update.
8311         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8312         type.
8313         (darwin_nat_target::attach): Update.
8314         * corelow.c (class core_target) <pid_to_str>: Change return type.
8315         (core_target::pid_to_str): Change return type.
8316         * target.c (normal_pid_to_str): Change return type.
8317         (default_pid_to_str): Likewise.
8318         (target_pid_to_str): Change return type.
8319         (target_translate_tls_address): Update.
8320         (target_announce_detach): Update.
8321         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8322         return type.
8323         (bsd_uthread_target::pid_to_str): Change return type.
8324         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8325         type.
8326         (bsd_kvm_target::pid_to_str): Change return type.
8327         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8328         return type.
8329         (aix_thread_target::pid_to_str): Change return type.
8330         * target.h (struct target_ops) <pid_to_str>: Change return type.
8331         (target_pid_to_str, normal_pid_to_str): Likewise.
8332         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8333         type.
8334         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8335         type.
8336         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8337         return type.
8338         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8339         type.
8340         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8341         type.
8342         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8343         return type.
8344
8345 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8346
8347         * NEWS: Mention that the new default MI version is 3.  Mention
8348         changes to the output of commands and events that deal with
8349         multi-location breakpoints.
8350         * breakpoint.c: Include "mi/mi-out.h".
8351         (print_one_breakpoint): Change output syntax if using MI version
8352         >= 3.
8353         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8354         New.
8355         (mi_multi_location_breakpoint_output_fixed): New.
8356         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8357         (mi_cmd_fix_multi_location_breakpoint_output): New.
8358         (mi_multi_location_breakpoint_output_fixed): New.
8359         * mi/mi-cmds.c (mi_cmds): Register command
8360         -fix-multi-location-breakpoint-output.
8361         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8362         interpreter "mi".
8363
8364 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8365
8366         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8367         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8368         instantiate mi_ui_out based on interpreter name.
8369         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8370         * mi/mi-main.c (mi_load_progress): Likewise.
8371
8372 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8373
8374         * NEWS: Combine separate "New targets" sections for 8.3.
8375
8376 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8377
8378         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8379         (ppcfbsd_init_abi): Install gdbarch
8380         "fetch_tls_load_module_address" and "get_thread_local_address"
8381         methods.
8382
8383 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8384
8385         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8386         (riscv_fbsd_init_abi): Install gdbarch
8387         "fetch_tls_load_module_address" and "get_thread_local_address"
8388         methods.
8389
8390 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8391
8392         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8393         (i386fbsd_init_abi): Install gdbarch
8394         "fetch_tls_load_module_address" and "get_thread_local_address"
8395         methods.
8396
8397 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8398
8399         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8400         (amd64fbsd_init_abi): Install gdbarch
8401         "fetch_tls_load_module_address" and "get_thread_local_address"
8402         methods.
8403
8404 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8405
8406         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8407         (struct fbsd_pspace_data): New type.
8408         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8409         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8410         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8411         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8412         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8413
8414 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8415
8416         * gdbtypes.c (lookup_struct_elt): New function.
8417         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8418         * gdbtypes.h (struct struct_elt): New type.
8419         (lookup_struct_elt): New prototype.
8420
8421 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8422
8423         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8424         remove disabled code block.
8425
8426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8427
8428         * gdbarch.sh (get_thread_local_address): New method.
8429         * gdbarch.h, gdbarch.c: Regenerate.
8430         * target.c (target_translate_tls_address): Use
8431         gdbarch_get_thread_local_address if present instead of
8432         target::get_thread_local_address.
8433
8434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8435
8436         * target.h (target::get_thread_local_address): Update comment.
8437
8438 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8439
8440         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8441         objfile->separate_debug_objfile_backlink if not NULL.
8442
8443 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8444
8445         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8446         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8447         (amd64bsd_store_inferior_registers): Likewise.
8448         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8449         Enable segment base registers.
8450         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8451         PT_GETFSBASE and PT_GETGSBASE.
8452         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8453         PT_SETGSBASE.
8454         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8455         segment base registers.
8456         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8457
8458 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8459
8460         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8461         Update calls to i386_target_description to add 'segments'
8462         parameter.
8463         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8464         add segment base registers.
8465         * arch/i386.c (i386_create_target_description): Add 'segments'
8466         parameter to enable segment base registers.
8467         * arch/i386.h (i386_create_target_description): Likewise.
8468         * features/i386/32bit-segments.xml: New file.
8469         * features/i386/32bit-segments.c: Generate.
8470         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8471         call to i386_target_description to add 'segments' parameter.
8472         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8473         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8474         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8475         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8476         if feature is present.
8477         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8478         Add 'segments' parameter to call to i386_target_description.
8479         (i386_target_description): Add 'segments' parameter to enable
8480         segment base registers.
8481         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8482         to call to i386_target_description.
8483         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8484         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8485         Define I386_NUM_REGS.
8486         (i386_target_description): Add 'segments' parameter to enable
8487         segment base registers.
8488
8489 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8490
8491         PR/24325
8492         * source-cache.c: #undef open and close, to avoid unresolved
8493         externals during linking.
8494
8495 2019-03-12  Tom Tromey  <tromey@adacore.com>
8496
8497         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8498         const.  Add initializers.
8499         (_initialize_remote): Don't initialize ptid globals.
8500
8501 2019-03-12  Pedro Alves  <palves@redhat.com>
8502
8503         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8504
8505 2019-03-12  Pedro Alves  <palves@redhat.com>
8506
8507         * cp-name-parser.y (main): Remove unused 'len' variable.
8508
8509 2019-03-12  Tom Tromey  <tromey@adacore.com>
8510
8511         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8512         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8513
8514 2019-03-12  Tom Tromey  <tromey@adacore.com>
8515
8516         * linux-nat.c (iterate_over_lwps): Update.
8517         (stop_callback): Remove parameter.
8518         (stop_wait_callback, detach_callback, resume_set_callback)
8519         (select_singlestep_lwp_callback, set_ignore_sigint)
8520         (status_callback, resumed_callback, resume_clear_callback)
8521         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8522         data parameter.
8523         (linux_nat_target::detach, linux_nat_target::resume)
8524         (linux_stop_and_wait_all_lwps, select_event_lwp)
8525         (linux_nat_filter_event, linux_nat_wait_1)
8526         (linux_nat_target::kill, linux_nat_target::stop)
8527         (linux_nat_target::stop): Update.
8528         (linux_nat_resume_callback): Change type.
8529         (resume_stopped_resumed_lwps, count_events_callback)
8530         (select_event_lwp_callback): Likewise.
8531         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8532         * arm-linux-nat.c (struct update_registers_data): Remove.
8533         (update_registers_callback): Change type.
8534         (arm_linux_insert_hw_breakpoint1): Update.
8535         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8536         parameter.
8537         (x86_linux_dr_set_addr): Update.
8538         (x86_linux_dr_set_control): Update.
8539         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8540         (iterate_over_lwps): Use gdb::function_view.
8541         * nat/aarch64-linux-hw-point.c (struct
8542         aarch64_dr_update_callback_param): Remove.
8543         (debug_reg_change_callback): Change type.
8544         (aarch64_notify_debug_reg_change): Update.
8545         * s390-linux-nat.c (s390_refresh_per_info): Update.
8546
8547 2019-03-11  Tom Tromey  <tromey@adacore.com>
8548
8549         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8550         redundant assignment to "this_cu".
8551
8552 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8553
8554         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8555
8556 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8557
8558         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8559         from...
8560         (rank_one_type): ... this.
8561
8562 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8563
8564         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8565         from...
8566         (rank_one_type): ... this.
8567
8568 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8569
8570         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8571         from...
8572         (rank_one_type): ... this.
8573
8574 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8575
8576         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8577         from...
8578         (rank_one_type): ... this.
8579
8580 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8581
8582         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8583         from...
8584         (rank_one_type): ... this.
8585
8586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8587
8588         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8589         from...
8590         (rank_one_type): ... this.
8591
8592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8593
8594         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8595         from...
8596         (rank_one_type): ... this.
8597
8598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8599
8600         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8601         from...
8602         (rank_one_type): ... this.
8603
8604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8605
8606         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8607         from...
8608         (rank_one_type): ... this.
8609
8610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8611
8612         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8613         from...
8614         (rank_one_type): ... this.
8615
8616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8617
8618         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8619         from...
8620         (rank_one_type): ... this.
8621
8622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8623
8624         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8625         from...
8626         (rank_one_type): ... this.
8627
8628 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8629
8630         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8631         inferior-events' shows the example events.
8632
8633 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8634
8635         Support styling on native MS-Windows console
8636
8637         PR/24315
8638         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8639         on MS-Windows if $TERM is not defined.
8640
8641         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8642
8643         * posix-hdep.c (gdb_console_fputs):
8644         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8645         functions.
8646         * ui-file.h (gdb_console_fputs): Add prototype.
8647
8648         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8649         back to fputs only if the former returns zero.
8650
8651 2019-03-07  Tom Tromey  <tom@tromey.com>
8652
8653         * symmisc.c (print_symbol_bcache_statistics): Update.
8654         (print_objfile_statistics): Update.
8655         * symfile.c (allocate_symtab): Update.
8656         * stabsread.c: Don't include bcache.h.
8657         * psymtab.h (struct psymbol_bcache): Don't declare.
8658         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8659         (psymbol_bcache_init, psymbol_bcache_free)
8660         (psymbol_bcache_get_bcache): Don't declare.
8661         * psymtab.c (struct psymbol_bcache): Remove.
8662         (psymtab_storage::psymtab_storage): Update.
8663         (psymtab_storage::~psymtab_storage): Update.
8664         (psymbol_bcache_init, psymbol_bcache_free)
8665         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8666         (add_psymbol_to_bcache): Update.
8667         (allocate_psymtab): Update.
8668         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8669         macro_cache>: No longer pointers.
8670         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8671         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8672         * macrotab.c (macro_bcache): Update.
8673         * macroexp.c: Don't include bcache.h.
8674         * gdbtypes.c (check_types_worklist): Update.
8675         (types_deeply_equal): Remove TRY/CATCH.  Update.
8676         * elfread.c (elf_symtab_read): Update.
8677         * dwarf2read.c: Don't include bcache.h.
8678         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8679         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8680         (print_bcache_statistics, bcache_memory_used): Don't declare.
8681         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8682         methods.  Rename all data members.
8683         * bcache.c (struct bcache): Move to bcache.h.
8684         (bcache::expand_hash_table): Rename from expand_hash_table.
8685         (bcache): Remove.
8686         (bcache::insert): Rename from bcache_full.
8687         (bcache::compare): Rename from bcache_compare.
8688         (bcache_xmalloc): Remove.
8689         (bcache::~bcache): Rename from bcache_xfree.
8690         (bcache::print_statistics): Rename from print_bcache_statistics.
8691         (bcache::memory_used): Rename from bcache_memory_used.
8692
8693 2019-03-07  Pedro Alves  <palves@redhat.com>
8694
8695         * infrun.c (normal_stop): Also check for
8696         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8697
8698 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8699
8700         * f-lang.c (value_from_host_double): Moved to...
8701         * value.c (value_from_host_double): ...here.
8702         * value.h (value_from_host_double): Declare.
8703         * guile/scm-math.c (vlscm_convert_typed_number): Use
8704         value_from_host_double.
8705         (vlscm_convert_number): Likewise.
8706         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8707         * python/py-value.c (convert_value_from_python): Likewise.
8708
8709 2019-03-06  Tom Tromey  <tom@tromey.com>
8710
8711         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8712
8713 2019-03-06  Tom Tromey  <tom@tromey.com>
8714
8715         * utils.h (free_current_contents): Don't declare.
8716         * utils.c (free_current_contents): Remove.
8717
8718 2019-03-06  Tom Tromey  <tom@tromey.com>
8719
8720         * top.c (quit_force): Update.
8721         * main.c (captured_command_loop): Update.
8722         * common/new-op.c (operator new): Update.
8723         * common/common-exceptions.c (struct catcher)
8724         <save_cleanup_chain>: Remove member.
8725         (exceptions_state_mc_init): Update.
8726         (exception_try_scope_entry): Return nullptr.
8727         (exception_try_scope_exit, exception_rethrow)
8728         (throw_exception_sjlj, throw_exception_cxx): Update.
8729         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8730         (all_cleanups, do_cleanups, discard_cleanups)
8731         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8732         (restore_cleanups, restore_final_cleanups): Don't declare.
8733         (do_final_cleanups): Remove parameter.
8734         * common/cleanups.c (cleanup_chain, make_cleanup)
8735         (make_cleanup_dtor, all_cleanups, do_cleanups)
8736         (discard_my_cleanups, discard_cleanups)
8737         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8738         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8739         (null_cleanup): Remove.
8740         (do_final_cleanups): Remove parameter.
8741
8742 2019-03-06  Tom Tromey  <tom@tromey.com>
8743
8744         * remote.c (remote_target::remote_parse_stop_reply): Use
8745         unique_xmalloc_ptr.
8746
8747 2019-03-06  Tom Tromey  <tom@tromey.com>
8748
8749         * stabsread.c (struct stabs_field_info): Rename from field_info.
8750         <list, fnlist>: Add initializers.
8751         <obstack>: New member.
8752         (read_member_functions, read_struct_fields, read_baseclasses):
8753         Allocate on obstack.  Don't use cleanups.
8754         (read_one_struct_field, read_member_functions, read_struct_fields)
8755         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8756         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8757         (read_struct_type): Update.
8758
8759 2019-03-06  Tom Tromey  <tom@tromey.com>
8760
8761         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8762         * common/filestuff.h (make_cleanup_close): Don't declare.
8763         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8764         Remove.
8765
8766 2019-03-06  Tom Tromey  <tom@tromey.com>
8767
8768         * solib-aix.c: Use make_scope_exit.
8769
8770 2019-03-06  Tom Tromey  <tom@tromey.com>
8771
8772         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8773         Use make_scope_exit.
8774
8775 2019-03-06  Tom Tromey  <tom@tromey.com>
8776
8777         * solib-svr4.c (disable_probes_interface): Remove parameter.
8778         (svr4_handle_solib_event): Use make_scope_exit.
8779
8780 2019-03-06  Tom Tromey  <tom@tromey.com>
8781
8782         * remote.c (struct stop_reply_deleter): Remove.
8783         (stop_reply_up): Update.
8784         (struct stop_reply): Derive from notif_event.  Don't typedef.
8785         <regcache>: Now a std::vector.
8786         (stop_reply_xfree): Remove.
8787         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8788         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8789         (remote_target::discard_pending_stop_replies): Use delete.
8790         (remote_target::remote_parse_stop_reply): Update.
8791         (remote_target::process_stop_reply): Update.
8792         * remote-notif.h (struct notif_event): Add virtual destructor.
8793         Remove "dtr" member.
8794         (struct notif_client) <alloc_event>: Return a unique_ptr.
8795         (notif_event_xfree): Don't declare.
8796         (notif_event_up): New typedef.
8797         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8798         (notif_event_xfree, do_notif_event_xfree): Remove.
8799         (remote_notif_state_xfree): Update.
8800
8801 2019-03-06  Tom Tromey  <tom@tromey.com>
8802
8803         * infrun.c (displaced_step_clear_cleanup): Now a
8804         forward_scope_exit type.
8805         (displaced_step_prepare_throw): Update.
8806         (displaced_step_fixup): Update.
8807
8808 2019-03-06  Tom Tromey  <tom@tromey.com>
8809
8810         * inferior.h (class inferior): Update comment.
8811         * gdbthread.h (class thread_info): Update comment.
8812
8813 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8814             Tom Tromey  <tom@tromey.com>
8815
8816         * stabsread.h (struct stab_section_list): Remove.
8817         (coffstab_build_psymtabs): Update.
8818         * dbxread.c (symbuf_sections): Now a std::vector.
8819         (sect_idx): New global.
8820         (fill_symbuf): Update.
8821         (coffstab_build_psymtabs): Change type of stabsects parameter.
8822         Update.
8823         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8824         std::vector.
8825         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8826         (coff_locate_sections): Update.
8827         (coff_symfile_read): Remove cleanups.  Update.
8828         (init_stringtab): Add storage parameter.
8829         (free_stringtab, free_stringtab_cleanup): Remove.
8830         (init_lineno): Add storage parameter.
8831         (free_linetab, free_linetab_cleanup): Remove.
8832
8833 2019-03-06  Pedro Alves  <palves@redhat.com>
8834
8835         * linux-fork.c (fork_info::clobber_regs): Delete.
8836         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8837         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8838         comment.  Adjust.
8839         (scoped_switch_fork_info::scoped_switch_fork_info)
8840         (checkpoint_command, linux_fork_context): Adjust
8841         fork_save_infrun_state calls.
8842
8843 2019-03-06  Pedro Alves  <palves@redhat.com>
8844
8845         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8846         (inf_has_multiple_threads): Return 'bool' and rewrite using
8847         inferior_info::threads().
8848
8849 2019-03-06  Pedro Alves  <palves@redhat.com>
8850
8851         * linux-fork.c: Include <list>.
8852         (fork_list): Now a std::list instance.
8853         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8854         (forks_exist_p, find_last_fork): Adjust.
8855         (new_fork): Delete.
8856         (one_fork_p): New.
8857         (add_fork): Adjust.
8858         (free_fork): Delete, folded into fork_info::~fork_info().
8859         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8860         Adjust.
8861         (init_fork_list): Delete.
8862         (linux_fork_killall, linux_fork_mourn_inferior)
8863         (linux_fork_detach, info_checkpoints_command): Adjust.
8864         (_initialize_linux_fork): No longer call init_fork_list.
8865
8866 2019-03-06  Pedro Alves  <palves@redhat.com>
8867
8868         * linux-fork.c (new_fork): New, split out of ...
8869         (add_fork): ... this.  Return void.  Move "first fork" special
8870         case from here, to ...
8871         (checkpoint_command): ... here.
8872         * linux-linux.h (add_fork): Return void.
8873
8874 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8875
8876         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8877
8878 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8879             Chris January  <chris.january@arm.com>
8880             David Lecomber  <david.lecomber@arm.com>
8881
8882         * f-exp.y: New token, UNOP_INTRINSIC.
8883         (exp): New pattern using UNOP_INTRINSIC token.
8884         (f77_keywords): Add 'abs' keyword.
8885         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8886         (value_from_host_double): New function.
8887         (evaluate_subexp_f): Support UNOP_ABS.
8888
8889 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8890
8891         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8892         types.
8893
8894 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8895
8896         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8897         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8898         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8899
8900 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8901
8902         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8903
8904 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8905             Chris January  <chris.january@arm.com>
8906
8907         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8908         * f-exp.y: Define 'KIND' token.
8909         (exp): New pattern for KIND expressions.
8910         (ptype): Handle types with a kind extension.
8911         (direct_abs_decl): Extend to spot kind extensions.
8912         (f77_keywords): Add 'kind' to the list.
8913         (push_kind_type): New function.
8914         (convert_to_kind_type): New function.
8915         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8916         * parse.c (operator_length_standard): Likewise.
8917         * parser-defs.h (enum type_pieces): Add tp_kind.
8918         * std-operator.def: Add UNOP_KIND.
8919
8920 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8921
8922         * f-exp.y (f_parse): Set yydebug.
8923
8924 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8925
8926         * f-lang.c (evaluate_subexp_f): New function.
8927         (exp_descriptor_f): New global.
8928         (f_language_defn): Use exp_descriptor_f instead of
8929         exp_descriptor_standard.
8930
8931 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8932
8933         * f-exp.y (struct token): Add comments.
8934         (dot_ops): Remove uppercase versions and the end marker.
8935         (f77_keywords): Likewise.
8936         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8937         entries in the dot_ops array are case insensitive, and use
8938         strncasecmp to compare strings.  Also some whitespace cleanup in
8939         this area.  Similar for the f77_keywords array, except entries in
8940         this list might be case sensitive.
8941
8942 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8943
8944         * f-exp.y (struct f77_boolean_val): Add comments.
8945         (boolean_values): Remove uppercase versions, and end marker.
8946         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8947         and use strncasecmp to achieve case insensitivity.  Additionally,
8948         perform whitespace cleanup around this code.
8949
8950 2019-03-06  Tom Tromey  <tromey@adacore.com>
8951
8952         * remote-sim.c (gdbsim_target_open): Use result of
8953         gdb_argv::release.
8954
8955 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8956         Dirk Schubert  <dirk.schubert@arm.com>
8957         Chris January  <chris.january@arm.com>
8958
8959         * eval.c (evaluate_subexp_standard): Call Fortran argument
8960         wrapping logic.
8961         * f-lang.c (struct value): A value which can be passed into a
8962         Fortran function call.
8963         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8964         where appropriate.
8965         (struct type): Value ready for a Fortran function call.
8966         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8967         is needed.
8968         * f-lang.h (fortran_argument_convert): Declaration.
8969         (fortran_preserve_arg_pointer): Declaration.
8970         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8971
8972 2019-03-05  Tom Tromey  <tromey@adacore.com>
8973
8974         * python/py-prettyprint.c (print_string_repr): Remove #if.
8975         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8976
8977 2019-03-05  Tom Tromey  <tromey@adacore.com>
8978
8979         * target.c (the_dummy_target): Move later.  Change type to
8980         "dummy_target".
8981         (initialize_targets): Don't initialize the_dummy_target.
8982
8983 2019-03-05  Tom Tromey  <tromey@adacore.com>
8984
8985         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8986         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8987
8988 2019-03-05  Tom Tromey  <tromey@adacore.com>
8989
8990         * windows-nat.c (windows_nat_target::attach)
8991         (windows_nat_target::detach): Don't call gdb_flush.
8992         * valprint.c (generic_val_print, val_print, val_print_string):
8993         Don't call gdb_flush.
8994         * utils.c (defaulted_query): Don't call gdb_flush.
8995         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8996         * target.c (target_announce_detach): Don't call gdb_flush.
8997         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8998         * remote.c (extended_remote_target::attach): Don't call
8999         gdb_flush.
9000         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9001         * printcmd.c (do_examine): Don't call gdb_flush.
9002         (info_display_command): Don't call gdb_flush.
9003         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9004         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9005         * memattr.c (info_mem_command): Don't call gdb_flush.
9006         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9007         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9008         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9009         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9010         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9011         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9012         (gnu_nat_target::detach): Don't call gdb_flush.
9013         * f-valprint.c (f_val_print): Don't call gdb_flush.
9014         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9015         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9016         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9017         gdb_flush.
9018         * c-valprint.c (c_val_print): Don't call gdb_flush.
9019         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9020
9021 2019-03-05  Tom Tromey  <tromey@adacore.com>
9022
9023         * varobj.c (update_dynamic_varobj_children): Update.
9024         (install_default_visualizer): Use reset, not release.
9025         * value.c (set_internalvar): Update.
9026         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9027         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9028         ATTRIBUTE_UNUSED_RESULT.
9029
9030 2019-03-05  Tom Tromey  <tromey@adacore.com>
9031
9032         * remote.c (class scoped_remote_fd) <release>: Add
9033         ATTRIBUTE_UNUSED_RESULT.
9034
9035 2019-03-05  Tom Tromey  <tromey@adacore.com>
9036
9037         * macroexp.c (struct macro_buffer) <release>: Add
9038         ATTRIBUTE_UNUSED_RESULT.
9039
9040 2019-03-05  Tom Tromey  <tromey@adacore.com>
9041
9042         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9043         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9044         ATTRIBUTE_UNUSED_RESULT.
9045
9046 2019-03-05  Tom Tromey  <tromey@adacore.com>
9047
9048         * common/scoped_fd.h (class scoped_fd) <release>: Add
9049         ATTRIBUTE_UNUSED_RESULT.
9050
9051 2019-03-05  Tom Tromey  <tromey@adacore.com>
9052
9053         * parser-defs.h (struct parser_state) <release>: Add
9054         ATTRIBUTE_UNUSED_RESULT.
9055
9056 2019-03-05  Tom Tromey  <tromey@adacore.com>
9057
9058         * utils.h (class gdb_argv) <release>: Add
9059         ATTRIBUTE_UNUSED_RESULT.
9060         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9061
9062 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9063
9064         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9065         for-loop range, to avoid compiler warnings.
9066
9067         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9068         avoid compiler warnings about unused variables.
9069
9070         * NEWS: Mention end of support for native debugging on MS-Windows
9071         before XP.
9072
9073         PR gdb/24292
9074         * common/netstuff.c:
9075         * gdbserver/gdbreplay.c
9076         * gdbserver/remote-utils.c:
9077         * ser-tcp.c:
9078         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9079         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9080         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9081         'getaddrinfo' and 'freeaddrinfo' were not available before
9082         Windows XP, and mingw.org's MinGW headers by default define
9083         _WIN32_WINNT to 0x500.
9084
9085 2019-03-01  Gary Benson <gbenson@redhat.com>
9086
9087         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9088
9089 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9090             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9091
9092         PR gdb/8527
9093         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9094         set_sigint_trap, clear_sigint_trap.
9095
9096 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9097
9098         * target.c (target_detach): Clear the regcache and the
9099         frame cache.
9100
9101 2019-02-27  Pedro Alves  <palves@redhat.com>
9102
9103         * utils.c (set_screen_size): When we cap the height/width sizes,
9104         tweak the corresponding command variable to show "unlimited":
9105
9106 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9107             Pedro Alves  <palves@redhat.com>
9108
9109         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9110         before calling rl_set_screen_size.
9111
9112 2019-02-27  Tom Tromey  <tromey@adacore.com>
9113
9114         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9115         define.
9116         * python/py-value.c: Remove Python 2.4 workaround.
9117         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9118         workaround.
9119         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9120         Python 2.4 workaround.
9121         * python/python-internal.h: Remove Python 2.4 comment.
9122         (Py_ssize_t): Don't define.
9123         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9124         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9125         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9126         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9127         * python/python.c (do_start_initialization): Remove Python 2.4
9128         workaround.
9129         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9130         (print_children): Remove Python 2.4 workaround.
9131         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9132         workaround.
9133         (CHARBUFFERPROC_NAME): Remove.
9134         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9135         Python 2.4 workaround.
9136
9137 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9138
9139         * NEWS: Note minimum Python version.
9140
9141 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9142
9143         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9144         code from these functions.  Remove corresponding ifdefs.  Use
9145         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9146         Remove gotos and target of gotos.
9147         (infpy_search_memory): Likewise.
9148
9149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9150
9151         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9152         (hppa_gdbarch_init): Don't register deleted functions with
9153         gdbarch.
9154
9155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9156
9157         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9158         (h8300_unwind_sp): Delete.
9159         (h8300_dummy_id): Delete.
9160         (h8300_gdbarch_init): Don't register deleted functions with
9161         gdbarch.
9162
9163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9164
9165         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9166         (ft32_unwind_pc): Delete.
9167         (ft32_unwind_sp): Delete.
9168         (ft32_gdbarch_init): Don't register deleted functions with
9169         gdbarch.
9170
9171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9172
9173         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9174         (frv_unwind_pc): Delete.
9175         (frv_unwind_sp): Delete.
9176         (frv_gdbarch_init): Don't register deleted functions with
9177         gdbarch.
9178
9179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9180
9181         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9182         (riscv_unwind_pc): Delete.
9183         (riscv_unwind_sp): Delete.
9184         (riscv_gdbarch_init): Don't register deleted functions with
9185         gdbarch.
9186
9187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9188
9189         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9190         (csky_unwind_pc): Delete.
9191         (csky_unwind_sp): Delete.
9192         (csky_gdbarch_init): Don't register deleted functions with
9193         gdbarch.
9194
9195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9196
9197         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9198         (cris_unwind_pc): Delete.
9199         (cris_unwind_sp): Delete.
9200         (cris_gdbarch_init): Don't register deleted functions with
9201         gdbarch.
9202
9203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9204
9205         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9206         (bfin_unwind_pc): Delete.
9207         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9208
9209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9210
9211         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9212         (arm_unwind_pc): Delete.
9213         (arm_unwind_sp): Delete.
9214         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9215
9216 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9217
9218         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9219         (arc_unwind_pc): Delete.
9220         (arc_unwind_sp): Delete.
9221         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9222
9223 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9224
9225         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9226         (alpha_unwind_pc): Delete.
9227         (alpha_gdbarch_init): Don't register deleted functions with
9228         gdbarch.
9229
9230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9231
9232         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9233         (aarch64_unwind_pc): Delete.
9234         (aarch64_unwind_sp): Delete.
9235         (aarch64_gdbarch_init): Don't register deleted functions with
9236         gdbarch.
9237
9238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9239
9240         * gdbtypes.c (type_align): Don't consider static members when
9241         computing structure alignment.
9242
9243 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9244
9245         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9246         return 0 for other types.
9247         * arch-utils.c (default_type_align): Always return 0.
9248         * gdbarch.h: Regenerate.
9249         * gdbarch.sh (type_align): Extend comment.
9250         * gdbtypes.c (type_align): Add additional comments, always call
9251         gdbarch_type_align before applying the default rules.
9252         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9253         generic code will then apply a suitable default.
9254         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9255         types, return 0 for other types.
9256
9257 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9258
9259         * NEWS: Create a new section for the next release branch.
9260         Rename the section of the current branch, now that it has
9261         been cut.
9262
9263 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9264
9265         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9266         * version.in: Bump version to 8.3.50.DATE-git.
9267
9268 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9269
9270         * aix-thread.c (ptid_cmp): Remove unused variable.
9271         (get_signaled_thread): Likewise.
9272         (store_regs_user_thread): Likewise.
9273         (store_regs_kernel_thread): Likewise.
9274         (fetch_regs_kernel_thread): Remove shadowed variable.
9275
9276 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9277
9278         * features/riscv/32bit-cpu.xml: Add register numbers.
9279         * features/riscv/32bit-fpu.c: Regenerate.
9280         * features/riscv/32bit-fpu.xml: Add register numbers.
9281         * features/riscv/64bit-cpu.xml: Add register numbers.
9282         * features/riscv/64bit-fpu.c: Regenerate.
9283         * features/riscv/64bit-fpu.xml: Add register numbers.
9284
9285 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9286
9287         * NEWS: Mention two argument form of gdb.Value constructor.
9288         * python/py-value.c (convert_buffer_and_type_to_value): New
9289         function.
9290         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9291         Add support for handling an optional second argument.  Call
9292         convert_buffer_and_type_to_value as appropriate.
9293         * python/python-internal.h (Py_buffer_deleter): New struct.
9294         (Py_buffer_up): New typedef.
9295
9296 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9297
9298         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9299         instead of releasing ownership.
9300
9301 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9302
9303         * dwarf2read.c (open_and_init_dwp_file): Call
9304         elf_numsections instead of bfd_count_sections to initialize
9305         dwp_file->num_sections.
9306
9307 2019-02-25  Tom Tromey  <tromey@adacore.com>
9308
9309         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9310
9311 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9312
9313         * gcore.in: Add '--readnever' option when invoking GDB.
9314
9315 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9316
9317         * MAINTAINERS: Update my email address.
9318
9319 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9320
9321         * build-id.c (build_id_to_debug_bfd_1): New function.
9322         (build_id_to_debug_bfd): Look for separate debug file in
9323         sysroot.
9324
9325 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9326
9327         * gdbarch.sh: Update the copyright year range that is placed into
9328         generated files.
9329
9330 2019-02-22  Keith Seitz  <keiths@redhat.com>
9331
9332         PR symtab/23853
9333         * linespec.c (create_sals_line_offset): Search for the default
9334         symtab's filename instead of its fullname.
9335
9336 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9337
9338         * NEWS: Update style defaults.
9339
9340 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9341
9342         * main.c (captured_main_1): Disable styling in batch mode.
9343
9344 2019-02-20  Tom Tromey  <tom@tromey.com>
9345
9346         * symtab.c (symtab_symbol_info): Fix typos.
9347
9348 2019-02-20  Tom Tromey  <tromey@adacore.com>
9349
9350         * findcmd.c (_initialize_mem_search): Use upper case for
9351         metasyntactic variables.
9352
9353 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9354
9355         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9356         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9357
9358 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9359
9360         * top.h (source_file_name): Change to std::string.
9361         * top.c (source_file_name): Likewise.
9362         (command_line_input): Adjust.
9363         * cli/cli-script.c (script_from_file): Adjust.
9364
9365 2019-02-19  Tom Tromey  <tromey@adacore.com>
9366
9367         * ravenscar-thread.c
9368         (ravenscar_thread_target::update_thread_list): Don't call
9369         ada_build_task_list.
9370         * ada-lang.h (ada_build_task_list): Don't declare.
9371         * ada-tasks.c (struct ada_tasks_inferior_data)
9372         <task_list_valid_p>: Now bool.
9373         (read_known_tasks, ada_task_list_changed)
9374         (ada_tasks_invalidate_inferior_data): Update.
9375         (read_known_tasks_array): Return bool.
9376         (read_known_tasks_list): Likewise.
9377         (read_known_tasks): Return void.
9378         (ada_build_task_list): Now static.
9379
9380 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9381
9382         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9383         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9384
9385 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9386
9387         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9388         variant for ada_tasks_pspace_data_handle and
9389         ada_tasks_inferior_data_handle.
9390         (ada_tasks_pspace_data_cleanup): New function.
9391         (ada_tasks_inferior_data_cleanup): New function.
9392
9393 2019-02-17  Tom Tromey  <tom@tromey.com>
9394
9395         * macrotab.h (macro_source_fullname): Return a std::string.
9396         * macrotab.c (macro_include, check_for_redefinition)
9397         (macro_undef, macro_lookup_definition, foreach_macro)
9398         (foreach_macro_in_scope): Update.
9399         (macro_source_fullname): Return a std::string.
9400         * macrocmd.c (show_pp_source_pos): Update.
9401
9402 2019-02-17  Tom Tromey  <tom@tromey.com>
9403
9404         * macrocmd.c (show_pp_source_pos): Style the file names.
9405
9406 2019-02-17  Tom Tromey  <tom@tromey.com>
9407
9408         PR tui/24197:
9409         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9410
9411 2019-02-17  Tom Tromey  <tom@tromey.com>
9412
9413         * ada-lang.c (user_select_syms): Use filtered printing.
9414         * utils.c (wrap_style): New global.
9415         (desired_style): Remove.
9416         (emit_style_escape): Add stream parameter.
9417         (set_output_style, reset_terminal_style, prompt_for_continue):
9418         Update.
9419         (flush_wrap_buffer): Only flush gdb_stdout.
9420         (wrap_here): Set wrap_style.
9421         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9422         treat escape sequences as a character.  Change when wrap buffer is
9423         flushed.
9424         (fputs_styled): Do not set the output style when the default is
9425         requested.
9426         * ui-style.h (struct ui_file_style) <is_default>: New method.
9427         * source.c (print_source_lines_base): Emit escape sequences in one
9428         piece.
9429
9430 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9431
9432         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9433         integers and enumeration types.
9434
9435 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9436
9437         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9438         instead of lookup_symbol_in_language
9439         (do_exact_match): New function.
9440         (ada_get_symbol_name_matcher): Return do_exact_match when
9441         doing a verbatim match.
9442
9443 2019-02-15  Tom Tromey  <tromey@adacore.com>
9444
9445         * ravenscar-thread.c (ravenscar_thread_target::resume)
9446         (ravenscar_thread_target::wait): Special case wildcard requests.
9447
9448 2019-02-15  Tom Tromey  <tromey@adacore.com>
9449
9450         * ravenscar-thread.c (base_ptid): Remove.
9451         (struct ravenscar_thread_target) <close>: New method.
9452         <m_base_ptid>: New member.
9453         <update_inferior_ptid, active_task, task_is_currently_active,
9454         runtime_initialized>: Declare methods.
9455         <ravenscar_thread_target>: Add constructor.
9456         (ravenscar_thread_target::task_is_currently_active)
9457         (ravenscar_thread_target::update_inferior_ptid)
9458         (ravenscar_runtime_initialized): Rename.  Now methods.
9459         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9460         (ravenscar_thread_target::update_thread_list): Update.
9461         (ravenscar_thread_target::active_task): Now method.
9462         (ravenscar_thread_target::store_registers)
9463         (ravenscar_thread_target::prepare_to_store)
9464         (ravenscar_thread_target::prepare_to_store)
9465         (ravenscar_thread_target::mourn_inferior): Update.
9466         (ravenscar_inferior_created): Use "new" to create target.
9467         (ravenscar_thread_target::get_ada_task_ptid): Update.
9468         (_initialize_ravenscar): Don't initialize base_ptid.
9469         (ravenscar_ops): Remove global.
9470
9471 2019-02-15  Tom Tromey  <tromey@adacore.com>
9472
9473         * target.h (push_target): Declare new overload.
9474         * target.c (push_target): New overload, taking an rvalue reference.
9475         * remote.c (remote_target::open_1): Use push_target overload.
9476         * corelow.c (core_target_open): Use push_target overload.
9477
9478 2019-02-15  Tom Tromey  <tromey@adacore.com>
9479
9480         * ravenscar-thread.c (is_ravenscar_task)
9481         (ravenscar_task_is_currently_active): Return bool.
9482         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9483         (_initialize_ravenscar): Remove "(void)".
9484         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9485         Return bool.
9486
9487 2019-02-15  Tom Tromey  <tromey@adacore.com>
9488
9489         * ravenscar-thread.c (ravenscar_runtime_initializer)
9490         (has_ravenscar_runtime, get_running_thread_id)
9491         (ravenscar_thread_target::resume): Fix indentation.
9492
9493 2019-02-15  Tom Tromey  <tromey@adacore.com>
9494
9495         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9496         from ravenscar_arch_ops.
9497         (sparc_ravenscar_ops::fetch_registers)
9498         (sparc_ravenscar_ops::store_registers): Now methods.
9499         (sparc_ravenscar_prepare_to_store): Remove.
9500         (sparc_ravenscar_ops): Redefine.
9501         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9502         methods and destructor.  Remove members.
9503         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9504         (ravenscar_thread_target::store_registers)
9505         (ravenscar_thread_target::prepare_to_store): Update.
9506         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9507         Remove.
9508         (struct ppc_ravenscar_powerpc_ops): Derive from
9509         ravenscar_arch_ops.
9510         (ppc_ravenscar_powerpc_ops::fetch_registers)
9511         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9512         (ppc_ravenscar_powerpc_ops): Redefine.
9513         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9514         (ppc_ravenscar_e500_ops::fetch_registers)
9515         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9516         (ppc_ravenscar_e500_ops): Redefine.
9517         * aarch64-ravenscar-thread.c
9518         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9519         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9520         (aarch64_ravenscar_fetch_registers)
9521         (aarch64_ravenscar_store_registers): Now methods.
9522         (aarch64_ravenscar_ops): Redefine.
9523
9524 2019-02-15  Tom Tromey  <tromey@adacore.com>
9525
9526         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9527         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9528         (ravenscar_thread_target::stopped_by_watchpoint)
9529         (ravenscar_thread_target::stopped_data_address)
9530         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9531
9532 2019-02-15  Tom Tromey  <tromey@adacore.com>
9533
9534         * ravenscar-thread.c: Fix some typos.
9535
9536 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9537             Tom Tromey  <tromey@adacore.com>
9538
9539         * ada-lang.c (ada_exception_sal): Change addr_string to a
9540         std::string.
9541         (create_ada_exception_catchpoint): Update.
9542
9543 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9544             Tom Tromey  <tromey@adacore.com>
9545
9546         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9547         (bp_location_ops): Remove.
9548         (base_breakpoint_allocate_location): Update.
9549         (free_bp_location): Update.
9550         * ada-lang.c (class ada_catchpoint_location)
9551         <ada_catchpoint_location>: Remove ops parameter.
9552         (ada_catchpoint_location_dtor): Remove.
9553         (ada_catchpoint_location_ops): Remove.
9554         (allocate_location_exception): Update.
9555         * breakpoint.h (struct bp_location_ops): Remove.
9556         (class bp_location) <bp_location>: Remove bp_location_ops
9557         parameter.
9558         <~bp_location>: Add destructor.
9559         <ops>: Remove.
9560
9561 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9562             Pedro Alves  <palves@redhat.com>
9563
9564         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9565         'PATH_MAX'.
9566
9567 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9568             Samuel Thibault  <samuel.thibault@gnu.org>
9569             Thomas Schwinge  <thomas@codesourcery.com>
9570
9571         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9572         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9573
9574 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9575
9576         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9577         (check_empty): Use "const char *".
9578
9579         * gnu-nat.c (gnu_nat_target::detach): Instead of
9580         'detach_inferior (pid)' call
9581         'detach_inferior (find_inferior_pid (pid))'.
9582
9583         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9584         'nat/fork-inferior.o'.
9585         * gnu-nat.c: #include "nat/fork-inferior.h".
9586
9587         * gnu-nat.c (gnu_nat_target::detach): Instead of
9588         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9589         * gnu-nat.h: #include "inf-child.h".
9590         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9591         'i386_gnu_nat_target::fetch_registers'.
9592         (gnu_store_registers): Rename/move to
9593         'i386_gnu_nat_target::store_registers'.
9594
9595         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9596         * gnu-nat.h (mach_thread_info): New function.
9597         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9598
9599         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9600
9601 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9602
9603         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9604
9605 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9606
9607         * windows-nat.c (windows_add_thread): Add new parameter
9608         "main_thread_p" with default value set to false.  Update
9609         function documentation as well as all callers.
9610         (windows_delete_thread): Likewise.
9611         (fake_create_process): Update call to windows_add_thread.
9612         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9613         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9614         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9615         call to windows_delete_thread.
9616
9617 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9618
9619         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9620
9621 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9622
9623         * symfile.c (find_separate_debug_file): Use canonical path of
9624         sysroot with child_path instead of gdb_sysroot if it is valid.
9625
9626 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9627
9628         * symfile.c (find_separate_debug_file): Use child_path to
9629         determine if an object file is under a sysroot.
9630
9631 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9632
9633         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9634         unittests/child-path-selftests.c.
9635         * common/pathstuff.c (child_path): New function.
9636         * common/pathstuff.h (child_path): New prototype.
9637         * unittests/child-path-selftests.c: New file.
9638
9639 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9640
9641         * symfile.c (find_separate_debug_file): Look for separate debug
9642         files in debug directories under the sysroot.
9643
9644 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9645
9646         * symtab.h (struct minimal_symbol data_p): New const method.
9647         (struct minimal_symbol text_p): Likewise.
9648         * symtab.c (output_source_filename): Use file name style
9649         to print file name.
9650         (print_symbol_info): Likewise.
9651         (print_msymbol_info): Use address style to print addresses.
9652         Use function name style to print executable text symbols.
9653         (expand_symtab_containing_pc): Use data_p.
9654         (find_pc_sect_compunit_symtab): Likewise.
9655
9656 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9657
9658         * breakpoint.c (describe_other_breakpoints): Use address style
9659         to print addresses.
9660         (say_where): Likewise.
9661
9662 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9663
9664         * ada-typeprint.c (print_func_type): Print function name
9665         style to print function name.
9666         * c-typeprint.c (c_print_type_1): Likewise.
9667
9668 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9669
9670         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9671         for execve.
9672
9673 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9674
9675         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9676         type_stack.
9677
9678 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9679
9680         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9681         TYPE_CODE_REF types.
9682
9683 2019-02-08  Jim Wilson  <jimw@sifive.com>
9684
9685         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9686         (riscv_linux_fregset): New.
9687         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9688
9689 2019-02-07  Tom Tromey  <tom@tromey.com>
9690
9691         * thread.c (thread_cancel_execution_command): Update.
9692         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9693         methods.
9694         (struct thread_fsm_ops): Remove.
9695         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9696         (thread_fsm_should_stop, thread_fsm_return_value)
9697         (thread_fsm_set_finished, thread_fsm_finished_p)
9698         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9699         Don't declare.
9700         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9701         * infrun.c (clear_proceed_status_thread)
9702         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9703         (print_stop_event): Update.
9704         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9705         Add constructor.
9706         (step_command_fsm_ops): Remove.
9707         (new_step_command_fsm): Remove.
9708         (step_1): Update.
9709         (step_command_fsm::should_stop): Rename from
9710         step_command_fsm_should_stop.
9711         (step_command_fsm::clean_up): Rename from
9712         step_command_fsm_clean_up.
9713         (step_command_fsm::do_async_reply_reason): Rename from
9714         step_command_fsm_async_reply_reason.
9715         (struct until_next_fsm): Inherit from thread_fsm.  Add
9716         constructor.
9717         (until_next_fsm_ops): Remove.
9718         (new_until_next_fsm): Remove.
9719         (until_next_fsm::should_stop): Rename from
9720         until_next_fsm_should_stop.
9721         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9722         (until_next_fsm::do_async_reply_reason): Rename from
9723         until_next_fsm_async_reply_reason.
9724         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9725         constructor.  Change type of breakpoint.
9726         (finish_command_fsm_ops): Remove.
9727         (new_finish_command_fsm): Remove.
9728         (finish_command_fsm::should_stop): Rename from
9729         finish_command_fsm_should_stop.
9730         (finish_command_fsm::clean_up): Rename from
9731         finish_command_fsm_clean_up.
9732         (finish_command_fsm::return_value): Rename from
9733         finish_command_fsm_return_value.
9734         (finish_command_fsm::do_async_reply_reason): Rename from
9735         finish_command_fsm_async_reply_reason.
9736         (finish_command): Update.
9737         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9738         Add constructor.
9739         (call_thread_fsm_ops): Remove.
9740         (call_thread_fsm::call_thread_fsm): Rename from
9741         new_call_thread_fsm.
9742         (call_thread_fsm::should_stop): Rename from
9743         call_thread_fsm_should_stop.
9744         (call_thread_fsm::should_notify_stop): Rename from
9745         call_thread_fsm_should_notify_stop.
9746         (run_inferior_call, call_function_by_hand_dummy): Update.
9747         * cli/cli-interp.c (should_print_stop_to_console): Update.
9748         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9749         Add constructor.  Change type of location_breakpoint,
9750         caller_breakpoint.
9751         (until_break_fsm_ops): Remove.
9752         (new_until_break_fsm): Remove.
9753         (until_break_fsm::should_stop): Rename from
9754         until_break_fsm_should_stop.
9755         (until_break_fsm::clean_up): Rename from
9756         until_break_fsm_clean_up.
9757         (until_break_fsm::do_async_reply_reason): Rename from
9758         until_break_fsm_async_reply_reason.
9759         (until_break_command): Update.
9760         * thread-fsm.c: Remove.
9761         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9762
9763 2019-02-07  Tom Tromey  <tom@tromey.com>
9764
9765         * yy-remap.h: Add include guard.
9766         * xtensa-tdep.h: Add include guard.
9767         * xcoffread.h: Rename include guard.
9768         * varobj-iter.h: Add include guard.
9769         * tui/tui.h: Rename include guard.
9770         * tui/tui-winsource.h: Rename include guard.
9771         * tui/tui-wingeneral.h: Rename include guard.
9772         * tui/tui-windata.h: Rename include guard.
9773         * tui/tui-win.h: Rename include guard.
9774         * tui/tui-stack.h: Rename include guard.
9775         * tui/tui-source.h: Rename include guard.
9776         * tui/tui-regs.h: Rename include guard.
9777         * tui/tui-out.h: Rename include guard.
9778         * tui/tui-layout.h: Rename include guard.
9779         * tui/tui-io.h: Rename include guard.
9780         * tui/tui-hooks.h: Rename include guard.
9781         * tui/tui-file.h: Rename include guard.
9782         * tui/tui-disasm.h: Rename include guard.
9783         * tui/tui-data.h: Rename include guard.
9784         * tui/tui-command.h: Rename include guard.
9785         * tic6x-tdep.h: Add include guard.
9786         * target/waitstatus.h: Rename include guard.
9787         * target/wait.h: Rename include guard.
9788         * target/target.h: Rename include guard.
9789         * target/resume.h: Rename include guard.
9790         * target-float.h: Rename include guard.
9791         * stabsread.h: Add include guard.
9792         * rs6000-tdep.h: Add include guard.
9793         * riscv-fbsd-tdep.h: Add include guard.
9794         * regformats/regdef.h: Rename include guard.
9795         * record.h: Rename include guard.
9796         * python/python.h: Rename include guard.
9797         * python/python-internal.h: Rename include guard.
9798         * python/py-stopevent.h: Rename include guard.
9799         * python/py-ref.h: Rename include guard.
9800         * python/py-record.h: Rename include guard.
9801         * python/py-record-full.h: Rename include guard.
9802         * python/py-record-btrace.h: Rename include guard.
9803         * python/py-instruction.h: Rename include guard.
9804         * python/py-events.h: Rename include guard.
9805         * python/py-event.h: Rename include guard.
9806         * procfs.h: Add include guard.
9807         * proc-utils.h: Add include guard.
9808         * p-lang.h: Add include guard.
9809         * or1k-tdep.h: Rename include guard.
9810         * observable.h: Rename include guard.
9811         * nto-tdep.h: Rename include guard.
9812         * nat/x86-linux.h: Rename include guard.
9813         * nat/x86-linux-dregs.h: Rename include guard.
9814         * nat/x86-gcc-cpuid.h: Add include guard.
9815         * nat/x86-dregs.h: Rename include guard.
9816         * nat/x86-cpuid.h: Rename include guard.
9817         * nat/ppc-linux.h: Rename include guard.
9818         * nat/mips-linux-watch.h: Rename include guard.
9819         * nat/linux-waitpid.h: Rename include guard.
9820         * nat/linux-ptrace.h: Rename include guard.
9821         * nat/linux-procfs.h: Rename include guard.
9822         * nat/linux-osdata.h: Rename include guard.
9823         * nat/linux-nat.h: Rename include guard.
9824         * nat/linux-namespaces.h: Rename include guard.
9825         * nat/linux-btrace.h: Rename include guard.
9826         * nat/glibc_thread_db.h: Rename include guard.
9827         * nat/gdb_thread_db.h: Rename include guard.
9828         * nat/gdb_ptrace.h: Rename include guard.
9829         * nat/fork-inferior.h: Rename include guard.
9830         * nat/amd64-linux-siginfo.h: Rename include guard.
9831         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9832         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9833         * nat/aarch64-linux.h: Rename include guard.
9834         * nat/aarch64-linux-hw-point.h: Rename include guard.
9835         * mn10300-tdep.h: Add include guard.
9836         * mips-linux-tdep.h: Add include guard.
9837         * mi/mi-parse.h: Rename include guard.
9838         * mi/mi-out.h: Rename include guard.
9839         * mi/mi-main.h: Rename include guard.
9840         * mi/mi-interp.h: Rename include guard.
9841         * mi/mi-getopt.h: Rename include guard.
9842         * mi/mi-console.h: Rename include guard.
9843         * mi/mi-common.h: Rename include guard.
9844         * mi/mi-cmds.h: Rename include guard.
9845         * mi/mi-cmd-break.h: Rename include guard.
9846         * m2-lang.h: Add include guard.
9847         * location.h: Rename include guard.
9848         * linux-record.h: Rename include guard.
9849         * linux-nat.h: Add include guard.
9850         * linux-fork.h: Add include guard.
9851         * i386-darwin-tdep.h: Rename include guard.
9852         * hppa-linux-offsets.h: Add include guard.
9853         * guile/guile.h: Rename include guard.
9854         * guile/guile-internal.h: Rename include guard.
9855         * gnu-nat.h: Rename include guard.
9856         * gdb-stabs.h: Rename include guard.
9857         * frv-tdep.h: Add include guard.
9858         * f-lang.h: Add include guard.
9859         * event-loop.h: Add include guard.
9860         * darwin-nat.h: Rename include guard.
9861         * cp-abi.h: Rename include guard.
9862         * config/sparc/nm-sol2.h: Rename include guard.
9863         * config/nm-nto.h: Rename include guard.
9864         * config/nm-linux.h: Add include guard.
9865         * config/i386/nm-i386gnu.h: Rename include guard.
9866         * config/djgpp/nl_types.h: Rename include guard.
9867         * config/djgpp/langinfo.h: Rename include guard.
9868         * compile/gcc-cp-plugin.h: Add include guard.
9869         * compile/gcc-c-plugin.h: Add include guard.
9870         * compile/compile.h: Rename include guard.
9871         * compile/compile-object-run.h: Rename include guard.
9872         * compile/compile-object-load.h: Rename include guard.
9873         * compile/compile-internal.h: Rename include guard.
9874         * compile/compile-cplus.h: Rename include guard.
9875         * compile/compile-c.h: Rename include guard.
9876         * common/xml-utils.h: Rename include guard.
9877         * common/x86-xstate.h: Rename include guard.
9878         * common/version.h: Rename include guard.
9879         * common/vec.h: Rename include guard.
9880         * common/tdesc.h: Rename include guard.
9881         * common/selftest.h: Rename include guard.
9882         * common/scoped_restore.h: Rename include guard.
9883         * common/scoped_mmap.h: Rename include guard.
9884         * common/scoped_fd.h: Rename include guard.
9885         * common/safe-iterator.h: Rename include guard.
9886         * common/run-time-clock.h: Rename include guard.
9887         * common/refcounted-object.h: Rename include guard.
9888         * common/queue.h: Rename include guard.
9889         * common/ptid.h: Rename include guard.
9890         * common/print-utils.h: Rename include guard.
9891         * common/preprocessor.h: Rename include guard.
9892         * common/pathstuff.h: Rename include guard.
9893         * common/observable.h: Rename include guard.
9894         * common/netstuff.h: Rename include guard.
9895         * common/job-control.h: Rename include guard.
9896         * common/host-defs.h: Rename include guard.
9897         * common/gdb_wait.h: Rename include guard.
9898         * common/gdb_vecs.h: Rename include guard.
9899         * common/gdb_unlinker.h: Rename include guard.
9900         * common/gdb_unique_ptr.h: Rename include guard.
9901         * common/gdb_tilde_expand.h: Rename include guard.
9902         * common/gdb_sys_time.h: Rename include guard.
9903         * common/gdb_string_view.h: Rename include guard.
9904         * common/gdb_splay_tree.h: Rename include guard.
9905         * common/gdb_setjmp.h: Rename include guard.
9906         * common/gdb_ref_ptr.h: Rename include guard.
9907         * common/gdb_optional.h: Rename include guard.
9908         * common/gdb_locale.h: Rename include guard.
9909         * common/gdb_assert.h: Rename include guard.
9910         * common/filtered-iterator.h: Rename include guard.
9911         * common/filestuff.h: Rename include guard.
9912         * common/fileio.h: Rename include guard.
9913         * common/environ.h: Rename include guard.
9914         * common/common-utils.h: Rename include guard.
9915         * common/common-types.h: Rename include guard.
9916         * common/common-regcache.h: Rename include guard.
9917         * common/common-inferior.h: Rename include guard.
9918         * common/common-gdbthread.h: Rename include guard.
9919         * common/common-exceptions.h: Rename include guard.
9920         * common/common-defs.h: Rename include guard.
9921         * common/common-debug.h: Rename include guard.
9922         * common/cleanups.h: Rename include guard.
9923         * common/buffer.h: Rename include guard.
9924         * common/btrace-common.h: Rename include guard.
9925         * common/break-common.h: Rename include guard.
9926         * cli/cli-utils.h: Rename include guard.
9927         * cli/cli-style.h: Rename include guard.
9928         * cli/cli-setshow.h: Rename include guard.
9929         * cli/cli-script.h: Rename include guard.
9930         * cli/cli-interp.h: Rename include guard.
9931         * cli/cli-decode.h: Rename include guard.
9932         * cli/cli-cmds.h: Rename include guard.
9933         * charset-list.h: Add include guard.
9934         * buildsym-legacy.h: Rename include guard.
9935         * bfin-tdep.h: Add include guard.
9936         * ax.h: Rename include guard.
9937         * arm-linux-tdep.h: Add include guard.
9938         * arm-fbsd-tdep.h: Add include guard.
9939         * arch/xtensa.h: Rename include guard.
9940         * arch/tic6x.h: Add include guard.
9941         * arch/i386.h: Add include guard.
9942         * arch/arm.h: Rename include guard.
9943         * arch/arm-linux.h: Rename include guard.
9944         * arch/arm-get-next-pcs.h: Rename include guard.
9945         * arch/amd64.h: Add include guard.
9946         * arch/aarch64-insn.h: Rename include guard.
9947         * arch-utils.h: Rename include guard.
9948         * annotate.h: Add include guard.
9949         * amd64-darwin-tdep.h: Rename include guard.
9950         * aarch64-linux-tdep.h: Add include guard.
9951         * aarch64-fbsd-tdep.h: Add include guard.
9952         * aarch32-linux-nat.h: Add include guard.
9953
9954 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9955
9956         * macrotab.c (macro_define_internal): New function that
9957         factorizes macro_define_object_internal and macro_define_function
9958         code.
9959         (macro_define_object_internal): Use macro_define_internal.
9960         (macro_define_function): Likewise.
9961
9962 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9963
9964         * macrocmd.c (extract_identifier): Return
9965         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9966         callers.
9967
9968 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9969
9970         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9971
9972 2019-02-05  Tom Tromey  <tom@tromey.com>
9973
9974         * target.c (target_stack::unpush): Move assertion earlier.
9975
9976 2019-01-30  Tom Tromey  <tom@tromey.com>
9977
9978         PR python/23615:
9979         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9980         (gdbpy_parse_and_eval): Likewise.
9981         * python/python-internal.h (gdbpy_allow_threads): New class.
9982
9983 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9984
9985         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9986         (aarch64_fbsd_fpregmap): Move earlier.
9987         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9988         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9989         instead of individual calls to trad_frame_set_reg_addr.
9990         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9991         earlier.
9992         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9993         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9994         instead of individual calls to trad_frame_set_reg_addr.
9995
9996 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9997
9998         * CONTRIBUTE: Replace contribution list with wiki link.
9999
10000 2019-01-25  Tom Tromey  <tom@tromey.com>
10001
10002         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10003
10004 2019-01-25  Tom Tromey  <tom@tromey.com>
10005
10006         * xtensa-linux-nat.c: Fix common/ includes.
10007         * xml-support.h: Fix common/ includes.
10008         * xml-support.c: Fix common/ includes.
10009         * x86-linux-nat.c: Fix common/ includes.
10010         * windows-nat.c: Fix common/ includes.
10011         * varobj.h: Fix common/ includes.
10012         * varobj.c: Fix common/ includes.
10013         * value.c: Fix common/ includes.
10014         * valops.c: Fix common/ includes.
10015         * utils.c: Fix common/ includes.
10016         * unittests/xml-utils-selftests.c: Fix common/ includes.
10017         * unittests/utils-selftests.c: Fix common/ includes.
10018         * unittests/unpack-selftests.c: Fix common/ includes.
10019         * unittests/tracepoint-selftests.c: Fix common/ includes.
10020         * unittests/style-selftests.c: Fix common/ includes.
10021         * unittests/string_view-selftests.c: Fix common/ includes.
10022         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10023         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10024         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10025         * unittests/rsp-low-selftests.c: Fix common/ includes.
10026         * unittests/parse-connection-spec-selftests.c: Fix common/
10027         includes.
10028         * unittests/optional-selftests.c: Fix common/ includes.
10029         * unittests/offset-type-selftests.c: Fix common/ includes.
10030         * unittests/observable-selftests.c: Fix common/ includes.
10031         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10032         * unittests/memrange-selftests.c: Fix common/ includes.
10033         * unittests/memory-map-selftests.c: Fix common/ includes.
10034         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10035         * unittests/function-view-selftests.c: Fix common/ includes.
10036         * unittests/environ-selftests.c: Fix common/ includes.
10037         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10038         * unittests/common-utils-selftests.c: Fix common/ includes.
10039         * unittests/cli-utils-selftests.c: Fix common/ includes.
10040         * unittests/array-view-selftests.c: Fix common/ includes.
10041         * ui-file.c: Fix common/ includes.
10042         * tui/tui-io.c: Fix common/ includes.
10043         * tracepoint.h: Fix common/ includes.
10044         * tracepoint.c: Fix common/ includes.
10045         * tracefile-tfile.c: Fix common/ includes.
10046         * top.h: Fix common/ includes.
10047         * top.c: Fix common/ includes.
10048         * thread.c: Fix common/ includes.
10049         * target/waitstatus.h: Fix common/ includes.
10050         * target/waitstatus.c: Fix common/ includes.
10051         * target.h: Fix common/ includes.
10052         * target.c: Fix common/ includes.
10053         * target-memory.c: Fix common/ includes.
10054         * target-descriptions.c: Fix common/ includes.
10055         * symtab.h: Fix common/ includes.
10056         * symfile.c: Fix common/ includes.
10057         * stap-probe.c: Fix common/ includes.
10058         * spu-linux-nat.c: Fix common/ includes.
10059         * sparc-nat.c: Fix common/ includes.
10060         * source.c: Fix common/ includes.
10061         * solib.c: Fix common/ includes.
10062         * solib-target.c: Fix common/ includes.
10063         * ser-unix.c: Fix common/ includes.
10064         * ser-tcp.c: Fix common/ includes.
10065         * ser-pipe.c: Fix common/ includes.
10066         * ser-base.c: Fix common/ includes.
10067         * selftest-arch.c: Fix common/ includes.
10068         * s12z-tdep.c: Fix common/ includes.
10069         * rust-exp.y: Fix common/ includes.
10070         * rs6000-aix-tdep.c: Fix common/ includes.
10071         * riscv-tdep.c: Fix common/ includes.
10072         * remote.c: Fix common/ includes.
10073         * remote-notif.h: Fix common/ includes.
10074         * remote-fileio.h: Fix common/ includes.
10075         * remote-fileio.c: Fix common/ includes.
10076         * regcache.h: Fix common/ includes.
10077         * regcache.c: Fix common/ includes.
10078         * record-btrace.c: Fix common/ includes.
10079         * python/python.c: Fix common/ includes.
10080         * python/py-type.c: Fix common/ includes.
10081         * python/py-inferior.c: Fix common/ includes.
10082         * progspace.h: Fix common/ includes.
10083         * producer.c: Fix common/ includes.
10084         * procfs.c: Fix common/ includes.
10085         * proc-api.c: Fix common/ includes.
10086         * printcmd.c: Fix common/ includes.
10087         * ppc-linux-nat.c: Fix common/ includes.
10088         * parser-defs.h: Fix common/ includes.
10089         * osdata.c: Fix common/ includes.
10090         * obsd-nat.c: Fix common/ includes.
10091         * nat/x86-linux.c: Fix common/ includes.
10092         * nat/x86-linux-dregs.c: Fix common/ includes.
10093         * nat/x86-dregs.h: Fix common/ includes.
10094         * nat/x86-dregs.c: Fix common/ includes.
10095         * nat/ppc-linux.c: Fix common/ includes.
10096         * nat/mips-linux-watch.h: Fix common/ includes.
10097         * nat/mips-linux-watch.c: Fix common/ includes.
10098         * nat/linux-waitpid.c: Fix common/ includes.
10099         * nat/linux-ptrace.h: Fix common/ includes.
10100         * nat/linux-ptrace.c: Fix common/ includes.
10101         * nat/linux-procfs.c: Fix common/ includes.
10102         * nat/linux-personality.c: Fix common/ includes.
10103         * nat/linux-osdata.c: Fix common/ includes.
10104         * nat/linux-namespaces.c: Fix common/ includes.
10105         * nat/linux-btrace.h: Fix common/ includes.
10106         * nat/linux-btrace.c: Fix common/ includes.
10107         * nat/fork-inferior.c: Fix common/ includes.
10108         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10109         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10110         * nat/aarch64-linux.c: Fix common/ includes.
10111         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10112         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10113         * namespace.h: Fix common/ includes.
10114         * mips-linux-tdep.c: Fix common/ includes.
10115         * minsyms.c: Fix common/ includes.
10116         * mi/mi-parse.h: Fix common/ includes.
10117         * mi/mi-main.c: Fix common/ includes.
10118         * mi/mi-cmd-env.c: Fix common/ includes.
10119         * memrange.h: Fix common/ includes.
10120         * memattr.c: Fix common/ includes.
10121         * maint.h: Fix common/ includes.
10122         * maint.c: Fix common/ includes.
10123         * main.c: Fix common/ includes.
10124         * machoread.c: Fix common/ includes.
10125         * location.c: Fix common/ includes.
10126         * linux-thread-db.c: Fix common/ includes.
10127         * linux-nat.c: Fix common/ includes.
10128         * linux-fork.c: Fix common/ includes.
10129         * inline-frame.c: Fix common/ includes.
10130         * infrun.c: Fix common/ includes.
10131         * inflow.c: Fix common/ includes.
10132         * inferior.h: Fix common/ includes.
10133         * inferior.c: Fix common/ includes.
10134         * infcmd.c: Fix common/ includes.
10135         * inf-ptrace.c: Fix common/ includes.
10136         * inf-child.c: Fix common/ includes.
10137         * ia64-linux-nat.c: Fix common/ includes.
10138         * i387-tdep.c: Fix common/ includes.
10139         * i386-tdep.c: Fix common/ includes.
10140         * i386-linux-tdep.c: Fix common/ includes.
10141         * i386-linux-nat.c: Fix common/ includes.
10142         * i386-go32-tdep.c: Fix common/ includes.
10143         * i386-fbsd-tdep.c: Fix common/ includes.
10144         * i386-fbsd-nat.c: Fix common/ includes.
10145         * guile/scm-type.c: Fix common/ includes.
10146         * guile/guile.c: Fix common/ includes.
10147         * go32-nat.c: Fix common/ includes.
10148         * gnu-nat.c: Fix common/ includes.
10149         * gdbthread.h: Fix common/ includes.
10150         * gdbarch-selftests.c: Fix common/ includes.
10151         * gdb_usleep.c: Fix common/ includes.
10152         * gdb_select.h: Fix common/ includes.
10153         * gdb_bfd.c: Fix common/ includes.
10154         * gcore.c: Fix common/ includes.
10155         * fork-child.c: Fix common/ includes.
10156         * findvar.c: Fix common/ includes.
10157         * fbsd-nat.c: Fix common/ includes.
10158         * event-top.c: Fix common/ includes.
10159         * event-loop.c: Fix common/ includes.
10160         * dwarf2read.c: Fix common/ includes.
10161         * dwarf2loc.c: Fix common/ includes.
10162         * dwarf2-frame.c: Fix common/ includes.
10163         * dwarf-index-cache.c: Fix common/ includes.
10164         * dtrace-probe.c: Fix common/ includes.
10165         * disasm-selftests.c: Fix common/ includes.
10166         * defs.h: Fix common/ includes.
10167         * csky-tdep.c: Fix common/ includes.
10168         * cp-valprint.c: Fix common/ includes.
10169         * cp-support.h: Fix common/ includes.
10170         * cp-support.c: Fix common/ includes.
10171         * corelow.c: Fix common/ includes.
10172         * completer.h: Fix common/ includes.
10173         * completer.c: Fix common/ includes.
10174         * compile/compile.c: Fix common/ includes.
10175         * compile/compile-loc2c.c: Fix common/ includes.
10176         * compile/compile-cplus-types.c: Fix common/ includes.
10177         * compile/compile-cplus-symbols.c: Fix common/ includes.
10178         * command.h: Fix common/ includes.
10179         * cli/cli-dump.c: Fix common/ includes.
10180         * cli/cli-cmds.c: Fix common/ includes.
10181         * charset.c: Fix common/ includes.
10182         * build-id.c: Fix common/ includes.
10183         * btrace.h: Fix common/ includes.
10184         * btrace.c: Fix common/ includes.
10185         * breakpoint.h: Fix common/ includes.
10186         * breakpoint.c: Fix common/ includes.
10187         * ax.h:
10188         (enum agent_op): Fix common/ includes.
10189         * ax-general.c (struct aop_map): Fix common/ includes.
10190         * ax-gdb.c: Fix common/ includes.
10191         * auxv.c: Fix common/ includes.
10192         * auto-load.c: Fix common/ includes.
10193         * arm-tdep.c: Fix common/ includes.
10194         * arch/riscv.c: Fix common/ includes.
10195         * arch/ppc-linux-common.c: Fix common/ includes.
10196         * arch/i386.c: Fix common/ includes.
10197         * arch/arm.c: Fix common/ includes.
10198         * arch/arm-linux.c: Fix common/ includes.
10199         * arch/arm-get-next-pcs.c: Fix common/ includes.
10200         * arch/amd64.c: Fix common/ includes.
10201         * arch/aarch64.c: Fix common/ includes.
10202         * arch/aarch64-insn.c: Fix common/ includes.
10203         * arch-utils.c: Fix common/ includes.
10204         * amd64-windows-tdep.c: Fix common/ includes.
10205         * amd64-tdep.c: Fix common/ includes.
10206         * amd64-sol2-tdep.c: Fix common/ includes.
10207         * amd64-obsd-tdep.c: Fix common/ includes.
10208         * amd64-nbsd-tdep.c: Fix common/ includes.
10209         * amd64-linux-tdep.c: Fix common/ includes.
10210         * amd64-linux-nat.c: Fix common/ includes.
10211         * amd64-fbsd-tdep.c: Fix common/ includes.
10212         * amd64-fbsd-nat.c: Fix common/ includes.
10213         * amd64-dicos-tdep.c: Fix common/ includes.
10214         * amd64-darwin-tdep.c: Fix common/ includes.
10215         * agent.c: Fix common/ includes.
10216         * ada-lang.h: Fix common/ includes.
10217         * ada-lang.c: Fix common/ includes.
10218         * aarch64-tdep.c: Fix common/ includes.
10219
10220 2019-01-25  Tom Tromey  <tom@tromey.com>
10221
10222         * common/create-version.sh: Use common/version.h.
10223
10224 2019-01-24  Pedro Alves  <palves@redhat.com>
10225
10226         * infrun.c (signal_stop, signal_print, signal_program)
10227         (signal_catch, signal_pass): Now arrays instead of pointers.
10228         (update_signals_program_target, do_target_resume)
10229         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10230         * linux-nat.c (linux_nat_target::pass_signals)
10231         (linux_nat_target::create_inferior, linux_nat_target::attach):
10232         Adjust.
10233         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10234         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10235         * procfs.c (procfs_target::pass_signals): Adjust.
10236         * record-full.c (record_full_target::resume): Adjust.
10237         * remote.c (remote_target::pass_signals)
10238         (remote_target::program_signals): Adjust.
10239         * target-debug.h (target_debug_print_signals): Now takes a
10240         gdb::array_view as parameter.  Adjust.
10241         * target.h (target_ops) <pass_signals, program_signals>: Replace
10242         pointer and length parameters with gdb::array_view.
10243         (target_pass_signals, target_program_signals): Likewise.
10244         * target-delegates.c: Regenerate.
10245
10246 2019-01-24  Pedro Alves  <palves@redhat.com>
10247
10248         * common/forward-scope-exit.h
10249         (forward_scope_exit::forward_scope_exit): Pass arguments to
10250         m_bind_function directly, instead of creating a std::bind and
10251         copying that.
10252
10253 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10254
10255         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10256         for static members.
10257         (pass_in_v_vfp_candidate): Likewise.
10258
10259 2019-01-23  Tom Tromey  <tom@tromey.com>
10260             Pedro Alves  <palves@redhat.com>
10261
10262         * regcache.c (class regcache_invalidator): Remove.
10263         (regcache::raw_write): Use make_scope_exit.
10264
10265 2019-01-23  Tom Tromey  <tom@tromey.com>
10266
10267         * ui-out.h (class ui_out_emit_type): Update comment.
10268
10269 2019-01-23  Tom Tromey  <tom@tromey.com>
10270
10271         * infrun.c (fetch_inferior_event): Update comment.
10272
10273 2019-01-23  Tom Tromey  <tom@tromey.com>
10274             Pedro Alves  <palves@redhat.com>
10275
10276         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10277         parameter.
10278         (fetch_inferior_event): Use SCOPE_EXIT.
10279
10280
10281 2019-01-23  Tom Tromey  <tom@tromey.com>
10282             Pedro Alves  <palves@redhat.com>
10283
10284         * infrun.c (disable_thread_events): Delete.
10285         (stop_all_threads): Use SCOPE_EXIT.
10286
10287 2019-01-23  Tom Tromey  <tom@tromey.com>
10288             Pedro Alves  <palves@redhat.com>
10289
10290         * symfile.c: Include forward-scope-exit.h.
10291         (clear_symtab_users_cleanup): Replace forward declaration with
10292         a FORWARD_SCOPE_EXIT.
10293         (syms_from_objfile_1): Use the forward_scope_exit and
10294         gdb::optional instead of cleanup_function.
10295         (reread_symbols): Use the forward_scope_exit instead of
10296         cleanup_function.
10297         (clear_symtab_users_cleanup): Remove function.
10298
10299 2019-01-23  Tom Tromey  <tom@tromey.com>
10300             Pedro Alves  <palves@redhat.com>
10301
10302         * linux-nat.c: Include scope-exit.h.
10303         (cleanup_target_stop): Remove.
10304         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10305         SCOPE_EXIT.
10306
10307 2019-01-23  Tom Tromey  <tom@tromey.com>
10308             Pedro Alves  <palves@redhat.com>
10309
10310         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10311         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10312
10313 2019-01-23  Tom Tromey  <tom@tromey.com>
10314             Andrew Burgess  <andrew.burgess@embecosm.com>
10315             Pedro Alves  <palves@redhat.com>
10316
10317         * infrun.c (fetch_inferior_event): Use scope_exit.
10318         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10319         * top.c (execute_command): Use scope_exit.
10320         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10321         * utils.c (do_bpstat_clear_actions_cleanup)
10322         (make_bpstat_clear_actions_cleanup): Remove.
10323
10324 2019-01-23  Tom Tromey  <tom@tromey.com>
10325             Pedro Alves  <palves@redhat.com>
10326
10327         * infrun.c: Include "common/scope-exit.h"
10328         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10329         (wait_for_inferior): Use SCOPE_EXIT.
10330         (fetch_inferior_event): Use scope_exit.
10331
10332 2019-01-23  Tom Tromey  <tom@tromey.com>
10333             Pedro Alves  <palves@redhat.com>
10334
10335         * breakpoint.c (create_breakpoint): Remove cleanup.
10336
10337 2019-01-23  Tom Tromey  <tom@tromey.com>
10338             Andrew Burgess  <andrew.burgess@embecosm.com>
10339             Pedro Alves  <palves@redhat.com>
10340
10341 2019-01-23  Pedro Alves  <palves@redhat.com>
10342
10343         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10344
10345 2019-01-23  Pedro Alves  <palves@redhat.com>
10346             Andrew Burgess  <andrew.burgess@embecosm.com>
10347
10348         * gdbthread.h: Include "common/forward-scope-exit.h".
10349         (scoped_finish_thread_state): Redefine custom class in terms of
10350         forward_scope_exit.
10351
10352 2019-01-23  Pedro Alves  <palves@redhat.com>
10353             Andrew Burgess  <andrew.burgess@embecosm.com>
10354
10355         * common/forward-scope-exit.h: New file.
10356
10357 2019-01-23  Pedro Alves  <palves@redhat.com>
10358             Andrew Burgess  <andrew.burgess@embecosm.com>
10359             Tom Tromey  <tom@tromey.com>
10360
10361         * common/scope-exit.h: New file.
10362
10363 2019-01-23  Pedro Alves  <palves@redhat.com>
10364
10365         * common/preprocessor.h (ESC): Rename to ...
10366         (ESC_PARENS): ... this.
10367         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10368         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10369
10370 2019-01-23  Tom Tromey  <tom@tromey.com>
10371
10372         * language.h (class scoped_switch_to_sym_language_if_auto):
10373         Initialize m_lang in both cases.
10374
10375 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10376
10377         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10378         with XCNEW.
10379
10380 2019-01-22  Tom Tromey  <tom@tromey.com>
10381
10382         * corelow.c: Do not include sys/file.h.
10383
10384 2019-01-22  Tom Tromey  <tom@tromey.com>
10385
10386         * tui/tui-wingeneral.h: Include gdb_curses.h.
10387
10388 2019-01-22  Tom Tromey  <tom@tromey.com>
10389
10390         * source-cache.h (class source_cache) <get_source_lines,
10391         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10392
10393 2019-01-22  Tom Tromey  <tom@tromey.com>
10394
10395         * remote-fileio.h (struct remote_target): Declare.
10396
10397 2019-01-22  Tom Tromey  <tom@tromey.com>
10398
10399         * python/py-arch.c: Do not include py-ref.h.
10400         * python/py-bpevent.c: Do not include py-ref.h.
10401         * python/py-cmd.c: Do not include py-ref.h.
10402         * python/py-continueevent.c: Do not include py-ref.h.
10403         * python/py-event.h: Do not include py-ref.h.
10404         * python/py-evtregistry.c: Do not include py-ref.h.
10405         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10406         * python/py-frame.c: Do not include py-ref.h.
10407         * python/py-framefilter.c: Do not include py-ref.h.
10408         * python/py-function.c: Do not include py-ref.h.
10409         * python/py-infevents.c: Do not include py-ref.h.
10410         * python/py-linetable.c: Do not include py-ref.h.
10411         * python/py-objfile.c: Do not include py-ref.h.
10412         * python/py-param.c: Do not include py-ref.h.
10413         * python/py-prettyprint.c: Do not include py-ref.h.
10414         * python/py-progspace.c: Do not include py-ref.h.
10415         * python/py-symbol.c: Do not include py-ref.h.
10416         * python/py-symtab.c: Do not include py-ref.h.
10417         * python/py-type.c: Do not include py-ref.h.
10418         * python/py-unwind.c: Do not include py-ref.h.
10419         * python/py-utils.c: Do not include py-ref.h.
10420         * python/py-value.c: Do not include py-ref.h.
10421         * python/py-varobj.c: Do not include py-ref.h.
10422         * python/py-xmethods.c: Do not include py-ref.h.
10423         * python/python.c: Do not include py-ref.h.
10424         * varobj.c: Do not include py-ref.h.
10425
10426 2019-01-22  Tom Tromey  <tom@tromey.com>
10427
10428         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10429         keyword for bcache.
10430
10431 2019-01-22  Tom Tromey  <tom@tromey.com>
10432
10433         * compile/compile-cplus-types.c: Remove a comment by #include.
10434
10435 2019-01-22  Tom Tromey  <tom@tromey.com>
10436
10437         * compile/gcc-c-plugin.h: Include compile-internal.h.
10438
10439 2019-01-22  Tom Tromey  <tom@tromey.com>
10440
10441         * stabsread.c (EXTERN): Do not define.
10442         (symnum, next_symbol_text_func, processing_gcc_compilation)
10443         (within_function, global_sym_chain, global_stabs)
10444         (previous_stab_code, this_object_header_files)
10445         (n_this_object_header_files)
10446         (n_allocated_this_object_header_files): Define.
10447         * stabsread.h (EXTERN): Never define.  Use "extern".
10448
10449 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10450
10451         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10452         history_value.
10453
10454 2019-01-21  Tom Tromey  <tom@tromey.com>
10455
10456         * ui-out.c: Fix includes.
10457         * tui/tui-source.c: Fix includes.
10458         * target.c: Fix includes.
10459         * remote.c: Fix includes.
10460         * regcache.c: Fix includes.
10461         * python/py-block.c: Fix includes.
10462         * printcmd.c: Fix includes.
10463         * or1k-tdep.c: Fix includes.
10464         * mi/mi-main.c: Fix includes.
10465         * m32r-tdep.c: Fix includes.
10466         * csky-tdep.c: Fix includes.
10467         * compile/compile-cplus-types.c: Fix includes.
10468         * cli/cli-interp.c: Fix includes.
10469
10470 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10471
10472         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10473         for padding.
10474
10475 2019-01-16  Tom Tromey  <tom@tromey.com>
10476
10477         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10478         earlier.
10479         (struct objfile) <msymbols_range>: Move from top level.
10480         <msymbols>: New method.
10481         (class objfile_msymbols): Remove.
10482         * symtab.c (default_collect_symbol_completion_matches_break_on):
10483         Update.
10484         * symmisc.c (dump_msymbols): Update.
10485         * stabsread.c (scan_file_globals): Update.
10486         * objc-lang.c (info_selectors_command, info_classes_command)
10487         (find_methods): Update.
10488         * minsyms.c (find_solib_trampoline_target): Update.
10489         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10490         * coffread.c (coff_symfile_read): Update.
10491         * ada-lang.c (ada_lookup_simple_minsym)
10492         (ada_collect_symbol_completion_matches): Update.
10493
10494 2019-01-16  Tom Tromey  <tom@tromey.com>
10495
10496         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10497         type.  Remove no-argument constructor.
10498         <iterator::operator++>: Simplify.
10499         <begin>: Update.
10500         <end>: Use minimal_symbol_count.
10501
10502 2019-01-16  Tom Tromey  <tom@tromey.com>
10503
10504         * objfiles.h (struct objfile) <psymtabs>: New method.
10505         (class objfile_psymtabs): Remove.
10506         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10507         typedef.
10508         <range>: New method.
10509         (require_partial_symbols): Change return type.
10510         * psymtab.c (require_partial_symbols)
10511         (psym_expand_symtabs_matching): Update.
10512         * mdebugread.c (parse_partial_symbols): Update.
10513         * dbxread.c (dbx_end_psymtab): Update.
10514
10515 2019-01-15  Tom Tromey  <tom@tromey.com>
10516
10517         * symtab.c (lookup_objfile_from_block)
10518         (lookup_symbol_in_objfile_symtabs)
10519         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10520         (find_line_symtab, info_sources_command)
10521         (default_collect_symbol_completion_matches_break_on)
10522         (make_source_files_completion_list): Update.
10523         * symmisc.c (print_objfile_statistics, dump_objfile)
10524         (maintenance_print_symbols, maintenance_info_symtabs)
10525         (maintenance_check_symtabs, maintenance_info_line_tables):
10526         Update.
10527         * source.c (select_source_symtab)
10528         (forget_cached_source_info_for_objfile): Update.
10529         * objfiles.h (class objfile_compunits): Remove.
10530         (struct objfile) <compunits_range>: New typedef.
10531         (compunits): New method.
10532         * objfiles.c (objfile_relocate1): Update.
10533         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10534         * maint.c (count_symtabs_and_blocks): Update.
10535         * linespec.c (iterate_over_all_matching_symtabs): Update.
10536         * cp-support.c (add_symbol_overload_list_qualified): Update.
10537         * coffread.c (coff_symtab_read): Update.
10538         * ada-lang.c (add_nonlocal_symbols)
10539         (ada_collect_symbol_completion_matches)
10540         (ada_add_global_exceptions): Update.
10541
10542 2019-01-15  Tom Tromey  <tom@tromey.com>
10543
10544         * progspace.h (program_space) <objfiles_safe_range>: New
10545         typedef.
10546         <objfiles_safe>: New method.
10547         * objfiles.h (class all_objfiles_safe): Remove.
10548         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10549         * jit.c (jit_inferior_exit_hook): Update.
10550
10551 2019-01-17  Tom Tromey  <tom@tromey.com>
10552
10553         * progspace.h (program_space) <objfiles_range>: New typedef.
10554         <objfiles>: New method.
10555         <objfiles_head>: Rename from objfiles.
10556         (object_files): Update.
10557         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10558         * guile/scm-pretty-print.c
10559         (ppscm_find_pretty_printer_from_objfiles): Update.
10560         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10561         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10562         Update.
10563         * python/py-progspace.c (pspy_get_objfiles): Update.
10564         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10565         Update.
10566         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10567         (objfpy_lookup_objfile_by_build_id): Update.
10568         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10569         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10570         Update.
10571         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10572         (expand_symtab_containing_pc, lookup_objfile_from_block)
10573         (lookup_static_symbol, basic_lookup_transparent_type)
10574         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10575         (find_line_symtab, info_sources_command)
10576         (default_collect_symbol_completion_matches_break_on)
10577         (make_source_files_completion_list, find_main_name): Update.
10578         * symmisc.c (print_symbol_bcache_statistics)
10579         (print_objfile_statistics, maintenance_print_symbols)
10580         (maintenance_print_msymbols, maintenance_print_objfiles)
10581         (maintenance_info_symtabs, maintenance_check_symtabs)
10582         (maintenance_expand_symtabs, maintenance_info_line_tables):
10583         Update.
10584         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10585         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10586         (map_overlay_command, unmap_overlay_command)
10587         (simple_overlay_update, expand_symtabs_matching)
10588         (map_symbol_filenames): Update.
10589         * symfile-debug.c (set_debug_symfile): Update.
10590         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10591         Update.
10592         * source.c (select_source_symtab, forget_cached_source_info):
10593         Update.
10594         * solib.c (solib_read_symbols): Update.
10595         * solib-spu.c (append_ocl_sos): Update.
10596         * psymtab.c (maintenance_print_psymbols)
10597         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10598         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10599         * printcmd.c (info_symbol_command): Update.
10600         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10601         Update.
10602         * objfiles.h (class all_objfiles): Remove.
10603         * objfiles.c (have_partial_symbols, have_full_symbols)
10604         (have_minimal_symbols, qsort_cmp, update_section_map)
10605         (shared_objfile_contains_address_p)
10606         (default_iterate_over_objfiles_in_search_order): Update.
10607         * objc-lang.c (info_selectors_command, info_classes_command)
10608         (find_methods): Update.
10609         * minsyms.c (find_solib_trampoline_target): Update.
10610         * maint.c (maintenance_info_sections)
10611         (maintenance_translate_address, count_symtabs_and_blocks):
10612         Update.
10613         * main.c (captured_main_1): Update.
10614         * linux-thread-db.c (try_thread_db_load_from_pdir)
10615         (has_libpthread): Update.
10616         * linespec.c (iterate_over_all_matching_symtabs)
10617         (search_minsyms_for_name): Update.
10618         * jit.c (jit_find_objf_with_entry_addr): Update.
10619         * hppa-tdep.c (find_unwind_entry)
10620         (hppa_lookup_stub_minimal_symbol): Update.
10621         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10622         Update.
10623         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10624         (elf_gnu_ifunc_resolve_by_got): Update.
10625         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10626         * dwarf-index-write.c (save_gdb_index_command): Update.
10627         * cp-support.c (add_symbol_overload_list_qualified): Update.
10628         * breakpoint.c (create_overlay_event_breakpoint)
10629         (create_longjmp_master_breakpoint)
10630         (create_std_terminate_master_breakpoint)
10631         (create_exception_master_breakpoint): Update.
10632         * blockframe.c (find_pc_partial_function): Update.
10633         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10634         (ada_collect_symbol_completion_matches)
10635         (ada_add_global_exceptions): Update.
10636
10637 2019-01-17  Tom Tromey  <tom@tromey.com>
10638
10639         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10640         declare VEC.
10641         (solib_target_parse_libraries): Change return type.
10642         (library_list_start_segment, library_list_start_section)
10643         (library_list_end_library, library_list_start_library); Update.
10644         (solib_target_free_library_list): Remove.
10645         (solib_target_parse_libraries): Remove cleanup.  Change return
10646         type.
10647         (solib_target_current_sos): Update.
10648
10649 2019-01-17  Tom Tromey  <tromey@bapiya>
10650
10651         * valprint.c: Replace "the the" with "the".
10652         * symtab.c: Replace "the the" with "the".
10653         * solib.c: Replace "the the" with "the".
10654         * solib-dsbt.c: Replace "the the" with "the".
10655         * linespec.c: Replace "the the" with "the".
10656         * dwarf2loc.h: Replace "the the" with "the".
10657         * amd64-windows-tdep.c: Replace "the the" with "the".
10658         * aarch64-tdep.c: Replace "the the" with "the".
10659
10660 2019-01-16  Keith Seitz  <keiths@redhat.com>
10661
10662         PR gdb/23773
10663         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10664         <builder>: Rename to ..
10665         <m_builder>: ... this and make private.
10666         (dwarf2_cu::get_builder): New method.  Change all users of
10667         `builder' to use this method.
10668         (dwarf2_start_symtab): Move to ...
10669         (dwarf2_cu::start_symtab): ... here.  Update all callers
10670         (setup_type_unit_groups): Move to ...
10671         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10672         callers.
10673         (dwarf2_cu::reset_builder): New method.
10674         (process_full_compunit, process_full_type_unit): Use
10675         dwarf2_cu::reset_builder.
10676         (follow_die_offset): Record the ancestor CU if it is different
10677         from the followed DIE's CU.
10678         (follow_die_sig_1): Likewise.
10679
10680 2019-01-15  Tom Tromey  <tom@tromey.com>
10681
10682         * remote.c (class remote_state) <buf>: Now a char_vector.
10683         <buf_size>: Remove.
10684         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10685         parameter.
10686         (remote_target::getpkt_or_notif_sane_1)
10687         (remote_target::getpkt_sane)
10688         (remote_target::getpkt_or_notif_sane): Likewise.
10689         (class remote_target) <putpkt>: New overload.
10690         (remote_target::read_frame): Change type of "buf_p".  Remove
10691         sizeof_p parameter.
10692         (packet_ok): New overload.
10693         (packet_check_result): New overload.
10694         Update all uses.
10695
10696 2019-01-14  Tom Tromey  <tom@tromey.com>
10697
10698         * remote-notif.c (handle_notification, remote_notif_ack)
10699         (remote_notif_parse): Make "buf" const.
10700         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10701         const.
10702         (remote_notif_parse, remote_notif_ack, handle_notification):
10703         Likewise.
10704         * remote.c (remote_notif_stop_parse): Make "buf" const.
10705         (remote_target::remote_parse_stop_reply): Make "buf" const.
10706         (remote_notif_stop_ack): Make "buf" const.
10707
10708 2019-01-14  Tom Tromey  <tom@tromey.com>
10709
10710         * remote.c (remote_console_output): Make parameter const.
10711
10712 2019-01-14  Tom Tromey  <tom@tromey.com>
10713
10714         * target-debug.h (target_debug_print_signals): Constify.
10715         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10716         * procfs.c (procfs_target::pass_signals): Update.
10717         * linux-nat.c (linux_nat_target::pass_signals): Update.
10718         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10719         * target-delegates.c: Rebuild.
10720         * remote.c (remote_target::program_signals): Update.
10721         (remote_target::pass_signals): Update.
10722         * target.c (target_pass_signals): Constify argument.
10723         (target_program_signals): Likewise.
10724         * target.h (struct target_ops) <pass_signals, program_signals>:
10725         Constify argument.
10726         (target_pass_signals, target_program_signals): Constify argument.
10727
10728 2019-01-14  Tom Tromey  <tom@tromey.com>
10729
10730         PR tui/28819:
10731         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10732
10733 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10734
10735         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10736         field.
10737         * rs6000-tdep.c: Include reggroups.h.
10738         (IS_V_ALIAS_PSEUDOREG): Define.
10739         (rs6000_register_name): Return names for the "vX" aliases.
10740         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10741         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10742         aliases.  Call default_register_reggroup_p for all other
10743         pseudo-registers.
10744         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10745         New functions.
10746         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10747         Handle "vX" aliases.
10748         (v_alias_pseudo_register_collect): New function.
10749         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10750         (rs6000_gdbarch_init): Initialize "vX" aliases as
10751         pseudo-registers.  Restore registration of
10752         rs6000_pseudo_register_reggroup_p with
10753         set_tdesc_pseudo_register_reggroup_p.
10754
10755 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10756
10757         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10758         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10759         set_gdbarch_num_pseudo_regs.
10760
10761 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10762
10763         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10764         Remove arg prefixname, add do_set and do_show.
10765         Add member functions set_list and show_list.
10766         * cli/cli-style.c (class cli_style_option): Update accordingly.
10767         (style_set_list): Move to file scope.
10768         (style_show_list): Likewise.
10769         (set_style): Call help_list.
10770         (show_style): Call cmd_show_list.
10771         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10772         Update to use the new macro.
10773
10774 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10775
10776         * ada-lang.c (_initialize_ada_language): Expand the help text
10777         for the "catch exception" command.
10778
10779 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10780
10781         * symtab.c (matching_obj_sections): Initialize obj,
10782         declare it closer to its usage.
10783
10784 2019-01-10  Tom Tromey  <tom@tromey.com>
10785
10786         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10787         (basic_inf_threads_range): Remove.
10788         (inf_threads_range, inf_non_exited_threads_range)
10789         (safe_inf_threads_range): Use next_adapter.
10790
10791 2019-01-10  Keith Seitz  <keiths@redhat.com>
10792
10793         PR gdb/23712
10794         PR symtab/23010
10795         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10796         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10797
10798 2019-01-10  Keith Seitz  <keiths@redhat.com>
10799
10800         PR gdb/23712
10801         PR symtab/23010
10802         * dictionary.c (pending_to_vector): Remove.
10803         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10804         Remove _1 suffix, replacing functions of the same name.  Update
10805         all callers.
10806         (dict_create_hashed, dict_create_hashed_expandable)
10807         (dict_create_linear, dict_create_linear_expandable, dict_free)
10808         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10809         Make functions static.
10810
10811 2019-01-10  Keith Seitz  <keiths@redhat.com>
10812
10813         PR gdb/23712
10814         PR symtab/23010
10815         * dictionary.h (struct dictionary): Replace declaration with
10816         multidictionary.
10817         (dict_create_hashed, dict_create_hashed_expandable)
10818         (dict_create_linear, dict_create_linear_expandable)
10819         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10820         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10821         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10822         taking multidictionary argument.
10823         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10824         * block.h (struct block) <dict>: Change to multidictionary
10825         and rename `multidict'.
10826         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10827         symmisc.c: Update all dictionary references to multidictionary.
10828
10829 2019-01-10  Keith Seitz  <keiths@redhat.com>
10830
10831         PR gdb/23712
10832         PR symtab/23010
10833         * dictionary.c: Include unordered_map.
10834         (pending_to_vector): New function.
10835         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10836         Rewrite the non-"_1" functions to take vector instead
10837         of linked list.
10838         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10839         "new" _1 versions of the same name.
10840         (multidictionary): Define.
10841         (std::hash<enum language): New definition.
10842         (collate_pending_symbols_by_language, mdict_create_hashed)
10843         (mdict_create_hashed_expandable, mdict_create_linear)
10844         (mdict_create_linear_expandable, mdict_free)
10845         (find_language_dictionary, create_new_language_dictionary)
10846         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10847         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10848         (mdict_size, mdict_empty): New functions.
10849         * dictionary.h (mdict_iterator): Define.
10850
10851 2019-01-10  Pedro Alves  <palves@redhat.com>
10852
10853         * breakpoint.c (read_uploaded_action)
10854         (create_tracepoint_from_upload): Adjust to use
10855         gdb::unique_xmalloc_ptr.
10856         * ctf.c (ctf_write_uploaded_tp):
10857         (SET_ARRAY_FIELD): Use emplace_back.
10858         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10859         * tracefile-tfile.c (tfile_write_uploaded_tp):
10860         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10861         gdb::unique_xmalloc_ptr.
10862         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10863         at_string, cond_string, cmd_strings>: Replace char pointers
10864         with gdb::unique_xmalloc_ptr.
10865
10866 2019-01-10  Pedro Alves  <palves@redhat.com>
10867
10868         * solib-target.c (library_list_start_library): Don't xstrdup name.
10869
10870 2019-01-10  Pedro Alves  <palves@redhat.com>
10871
10872         * mdebugread.c (parse_partial_symbols): Use
10873         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10874
10875 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10876
10877         * linux-fork.c (scoped_switch_fork_info)
10878         <~scoped_switch_fork_info>: Fix incorrect variable name.
10879
10880 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10881
10882         * linux-fork.c (scoped_switch_fork_info)
10883         <scoped_switch_fork_info>: Make explicit.
10884         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10885
10886 2019-01-10  Tom Tromey  <tom@tromey.com>
10887
10888         * objfiles.h (objfile::reset_psymtabs): Update.
10889         * objfiles.c (objfile::objfile): Update.
10890         * psymtab.h (psymtab_storage::obstack): Update.
10891         (psymtab_storage::m_obstack): Use gdb::optional.
10892         (class psymtab_storage): Update comment.  Remove objfile
10893         parameter.
10894         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10895
10896 2019-01-10  Tom Tromey  <tom@tromey.com>
10897
10898         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10899         <free_psymtabs>: Now private.
10900         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10901         (allocate_psymtab): Use new method.
10902
10903 2019-01-10  Tom Tromey  <tom@tromey.com>
10904
10905         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10906         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10907         * mdebugread.c (parse_partial_symbols): Use
10908         allocate_dependencies.
10909         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10910         allocate_dependencies.
10911         (process_psymtab_comp_unit_reader)
10912         (build_type_psymtab_dependencies): Likewise.
10913         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10914
10915 2019-01-10  Tom Tromey  <tom@tromey.com>
10916
10917         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10918         PSYMBOL_SET_LANGUAGE.
10919         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10920
10921 2019-01-10  Tom Tromey  <tom@tromey.com>
10922
10923         * psymtab.h (psymtab_storage::obstack): New method.
10924         <m_obstack>: Rename from obstack; now private.
10925         * psymtab.c (psymtab_storage): Update.
10926         * dwarf2read.c (create_addrmap_from_index)
10927         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10928         Update.
10929
10930 2019-01-10  Tom Tromey  <tom@tromey.com>
10931
10932         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10933         * objfiles.h (objfile::reset_psymtabs): New method.
10934
10935 2019-01-10  Tom Tromey  <tom@tromey.com>
10936
10937         * symmisc.c (print_symbol_bcache_statistics): Update.
10938         (print_objfile_statistics): Update.
10939         * symfile.c (reread_symbols): Update.
10940         * psymtab.h (class psymtab_storage): New.
10941         * psymtab.c (psymtab_storage): New constructor.
10942         (~psymtab_storage): New destructor.
10943         (require_partial_symbols): Update.
10944         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10945         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10946         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10947         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10948         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10949         (start_psymtab_common, end_psymtab_common)
10950         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10951         (allocate_psymtab): Update.
10952         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10953         Update.
10954         (dump_psymtab_addrmap, maintenance_print_psymbols)
10955         (maintenance_check_psymtabs): Update.
10956         (class objfile_psymtabs): Move to objfiles.h.
10957         * psympriv.h (discard_psymtab): Now inline.
10958         (psymtab_discarder::psymtab_discarder): Update.
10959         (psymtab_discarder::~psymtab_discarder): Update.
10960         (ALL_OBJFILE_PSYMTABS): Rewrite.
10961         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10962         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10963         Remove fields.
10964         <partial_symtabs>: New field.
10965         (class objfile_psymtabs): Move from psymtab.h.  Update.
10966         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10967         psymbol_cache.
10968         (objfile::~objfile): Don't destroy psymbol_cache.
10969         * mdebugread.c (parse_partial_symbols): Update.
10970         * dwarf2read.c (create_addrmap_from_index)
10971         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10972         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10973         (add_partial_subprogram, dwarf2_ranges_read): Update.
10974         * dwarf-index-write.c (write_address_map)
10975         (write_one_signatured_type, recursively_write_psymbols)
10976         (class debug_names, class debug_names, write_psymtabs_to_index):
10977         Update.
10978
10979 2019-01-10  Tom Tromey  <tom@tromey.com>
10980
10981         * symtab.h (SYMBOL_SET_NAMES): Update.
10982         (symbol_set_names): Update.
10983         (MSYMBOL_SET_NAMES): Update.
10984         * symtab.c (symbol_set_names): Change argument to be an
10985         objfile_per_bfd_storage.
10986         * psymtab.c (add_psymbol_to_bcache): Update.
10987         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10988
10989 2019-01-10  Tom Tromey  <tom@tromey.com>
10990
10991         * symtab.c (create_demangled_names_hash): Change argument to be an
10992         objfile_per_bfd_storage.
10993         (symbol_set_names): Update.
10994
10995 2019-01-10  Tom Tromey  <tom@tromey.com>
10996
10997         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10998         init_psymbol_list.
10999         * psymtab.c (init_psymbol_list): Do nothing if already called.
11000         * psympriv.h (init_psymbol_list): Add comment.
11001         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11002         init_psymbol_list.
11003         * dbxread.c (dbx_symfile_read): Unconditionally call
11004         init_psymbol_list.
11005
11006 2019-01-10  Tom Tromey  <tom@tromey.com>
11007
11008         * xcoffread.c (scan_xcoff_symtab): Update.
11009         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11010         "where".
11011         * mdebugread.c (parse_partial_symbols)
11012         (handle_psymbol_enumerators): Update.
11013         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11014         * dbxread.c (read_dbx_symtab): Update.
11015         * psympriv.h (psymbol_placement): New enum.
11016         (add_psymbol_to_list): Update.
11017
11018 2019-01-10  Tom Tromey  <tom@tromey.com>
11019
11020         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11021         static_psymbols parameters.
11022         (scan_xcoff_symtab): Update.
11023         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11024         static_psymbols parameters.
11025         * psympriv.h (start_psymtab_common): Update.
11026         * mdebugread.c (parse_partial_symbols): Update.
11027         * dwarf2read.c (create_partial_symtab): Update.
11028         * dbxread.c (read_dbx_symtab): Update.
11029         (start_psymtab): Remove global_psymbols and static_psymbols
11030         parameters.
11031
11032 2019-01-10  Tom Tromey  <tom@tromey.com>
11033
11034         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11035         * psymtab.c (allocate_psymtab): Add comment.
11036         * psympriv.h (allocate_psymtab): Add comment.
11037         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11038         initializations.
11039         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11040
11041 2019-01-10  Tom Tromey  <tom@tromey.com>
11042
11043         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11044         Don't declare.
11045         * mipsread.c: Include mdebugread.h.
11046         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11047         Declare.
11048         * elfread.c: Include mdebugread.h.
11049
11050 2019-01-09  Tom Tromey  <tom@tromey.com>
11051
11052         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11053         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11054         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11055         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11056         (psym_lookup_symbol, psym_find_last_source_symtab)
11057         (psym_forget_cached_source_info, psym_print_stats)
11058         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11059         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11060         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11061         (psym_find_compunit_symtab_by_address)
11062         (maintenance_print_psymbols, maintenance_info_psymtabs)
11063         (maintenance_check_psymtabs): Use ranged for.
11064         * psymtab.h (class objfile_psymtabs): New.
11065         (require_partial_symbols): Return objfile_psymtabs.
11066         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11067
11068 2019-01-09  Tom Tromey  <tom@tromey.com>
11069
11070         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11071         (find_pc_mapped_section, list_overlays_command)
11072         (map_overlay_command, unmap_overlay_command)
11073         (simple_overlay_update): Use all_objfiles.
11074         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11075         * printcmd.c (info_symbol_command): Use all_objfiles.
11076         * objfiles.h (ALL_OBJSECTIONS): Remove.
11077         * maint.c (maintenance_translate_address): Use all_objfiles.
11078         * gcore.c (gcore_create_callback): Use all_objfiles.
11079         (objfile_find_memory_regions): Likewise.
11080
11081 2019-01-09  Tom Tromey  <tom@tromey.com>
11082
11083         * symtab.c (find_line_symtab, info_sources_command)
11084         (make_source_files_completion_list): Use objfile_compunits.
11085         * source.c (select_source_symtab): Use objfile_compunits.
11086         * objfiles.h (struct objfile): Update comment.
11087         (ALL_OBJFILES): Remove.
11088         (ALL_FILETABS): Remove.
11089         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11090         objfile_compunits.
11091
11092 2019-01-09  Tom Tromey  <tom@tromey.com>
11093
11094         * symmisc.c (print_objfile_statistics, dump_objfile)
11095         (maintenance_print_symbols): Use compunit_filetabs.
11096         * source.c (forget_cached_source_info_for_objfile): Use
11097         compunit_filetabs.
11098         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11099         (ALL_FILETABS): Use compunit_filetabs.
11100         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11101         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11102
11103 2019-01-09  Tom Tromey  <tom@tromey.com>
11104
11105         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11106         (compunit_filetabs): New.
11107         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11108         compunit_filetabs.
11109         (info_sources_command, make_source_files_completion_list): Remove
11110         declaration.
11111         * symmisc.c (print_objfile_statistics, dump_objfile)
11112         (maintenance_print_symbols): Remove declaration.
11113         (maintenance_info_symtabs): Use compunit_filetabs.
11114         (maintenance_info_line_tables): Likewise.
11115         * source.c (select_source_symtab): Change local variable name.
11116         (forget_cached_source_info_for_objfile): Remove declaration.
11117         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11118         * objfiles.c (objfile_relocate1): Remove declaration.
11119         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11120         declaration.
11121         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11122         * coffread.c (coff_symtab_read): Remove declaration.
11123         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11124         compunit_filetabs.
11125
11126 2019-01-09  Tom Tromey  <tom@tromey.com>
11127
11128         * symtab.c (lookup_objfile_from_block)
11129         (find_pc_sect_compunit_symtab, search_symbols)
11130         (default_collect_symbol_completion_matches_break_on): Use
11131         objfile_compunits.
11132         * objfiles.h (ALL_COMPUNITS): Remove.
11133         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11134         * cp-support.c (add_symbol_overload_list_qualified): Use
11135         objfile_compunits.
11136         * ada-lang.c (ada_collect_symbol_completion_matches)
11137         (ada_add_global_exceptions): Use objfile_compunits.
11138
11139 2019-01-09  Tom Tromey  <tom@tromey.com>
11140
11141         * source.c (select_source_symtab)
11142         (forget_cached_source_info_for_objfile): Remove declaration.
11143         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11144         declaration.
11145         * maint.c (count_symtabs_and_blocks): Remove declaration.
11146         * cp-support.c (add_symbol_overload_list_qualified): Remove
11147         declaration.
11148         * coffread.c (coff_symtab_read): Remove declaration.
11149         * symtab.c (lookup_symbol_in_objfile_symtabs)
11150         (basic_lookup_transparent_type_1): Use objfile_compunits.
11151         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11152         (info_sources_command, search_symbols)
11153         (default_collect_symbol_completion_matches_break_on)
11154         (make_source_files_completion_list): Remove declaration.
11155         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11156         (ada_collect_symbol_completion_matches)
11157         (ada_add_global_exceptions): Remove declaration.
11158         * linespec.c (iterate_over_all_matching_symtabs): Use
11159         objfile_compunits.
11160         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11161         (class objfile_compunits): New.
11162         (ALL_COMPUNITS): Use objfile_compunits.
11163         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11164         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11165         objfile_compunits.
11166         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11167
11168 2019-01-09  Tom Tromey  <tom@tromey.com>
11169
11170         * symtab.c (search_symbols)
11171         (default_collect_symbol_completion_matches_break_on): Use
11172         objfile_msymbols.
11173         * ada-lang.c (ada_lookup_simple_minsym)
11174         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11175         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11176         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11177         objfile_msymbols.
11178         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11179         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11180         * objc-lang.c (find_methods): Use objfile_msymbols.
11181         (info_selectors_command, info_classes_command): Likewise.
11182         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11183         * objfiles.h (class objfile_msymbols): New.
11184         (ALL_OBJFILE_MSYMBOLS): Remove.
11185         (ALL_MSYMBOLS): Remove.
11186
11187 2019-01-09  Tom Tromey  <tom@tromey.com>
11188
11189         * common/next-iterator.h (next_adapter): Add Iterator template
11190         parameter.
11191         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11192         (class all_objfiles_safe): New.
11193         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11194         * objfiles.c (put_objfile_before): Update comment.
11195         (add_separate_debug_objfile): Likewise.
11196         (free_all_objfiles): Use all_objfiles_safe.
11197         (objfile_purge_solibs): Likewise.
11198
11199 2019-01-09  Tom Tromey  <tom@tromey.com>
11200
11201         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11202         (expand_symtab_containing_pc, lookup_static_symbol)
11203         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11204         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11205         all_objfiles.
11206         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11207         * breakpoint.c (create_overlay_event_breakpoint)
11208         (create_longjmp_master_breakpoint)
11209         (create_std_terminate_master_breakpoint)
11210         (create_exception_master_breakpoint): Use all_objfiles.
11211         * linux-thread-db.c (try_thread_db_load_from_pdir)
11212         (has_libpthread): Use all_objfiles.
11213         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11214         * linespec.c (iterate_over_all_matching_symtabs)
11215         (search_minsyms_for_name): Use all_objfiles.
11216         * maint.c (maintenance_info_sections): Use all_objfiles.
11217         * main.c (captured_main_1): Use all_objfiles.
11218         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11219         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11220         * guile/scm-pretty-print.c
11221         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11222         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11223         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11224         (maintenance_print_msymbols): Use all_objfiles.
11225         * source.c (select_source_symtab): Use all_objfiles.
11226         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11227         * symfile.c (remove_symbol_file_command)
11228         (expand_symtabs_matching, map_symbol_filenames): Use
11229         all_objfiles.
11230         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11231         all_objfiles.
11232         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11233         * objc-lang.c (find_methods): Use all_objfiles.
11234         * objfiles.c (have_partial_symbols, have_full_symbols)
11235         (have_minimal_symbols, qsort_cmp)
11236         (default_iterate_over_objfiles_in_search_order): Use
11237         all_objfiles.
11238         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11239         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11240         (maintenance_check_psymtabs): Use all_objfiles.
11241         (ALL_PSYMTABS): Remove.
11242         * compile/compile-object-run.c (do_module_cleanup): Use
11243         all_objfiles.
11244         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11245         * cp-support.c (add_symbol_overload_list_qualified): Use
11246         all_objfiles.
11247         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11248         Use all_objfiles.
11249         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11250         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11251         all_objfiles.
11252         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11253         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11254         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11255         Uses all_objfiles.
11256         * solib.c (solib_read_symbols): Use all_objfiles
11257
11258 2019-01-09  Tom Tromey  <tom@tromey.com>
11259
11260         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11261         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11262         all_objfiles.
11263         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11264         * symmisc.c (print_symbol_bcache_statistics)
11265         (print_objfile_statistics, maintenance_print_objfiles)
11266         (maintenance_info_symtabs, maintenance_check_symtabs)
11267         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11268         all_objfiles.
11269         * source.c (forget_cached_source_info): Use all_objfiles.
11270         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11271         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11272         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11273         * objfiles.c (update_section_map): Use all_objfiles.
11274         (shared_objfile_contains_address_p): Likewise.
11275         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11276         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11277
11278 2019-01-09  Tom Tromey  <tom@tromey.com>
11279
11280         * common/next-iterator.h: New file.
11281         * objfiles.h (class all_objfiles): New.
11282         (struct objfile_iterator): New.
11283
11284 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11285
11286         * NEWS: Move the description of the changed "frame", "select-frame",
11287          and "info frame" commands to the Changed commands section.
11288
11289 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11290
11291         * gdbtypes.c (check_stub_method_group): Remove handling of old
11292         mangling schemes.
11293         * linespec.c (find_methods): Likewise.
11294         * stabsread.c (read_member_functions): Likewise.
11295         * valops.c (search_struct_method): Likewise.
11296         (value_struct_elt_for_reference): Likewise.
11297         * NEWS: Mention this change.
11298
11299 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11300
11301         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11302         print_source_lines.
11303         * source.c (print_source_lines_base): Update line number check.
11304         (print_source_lines): New function.
11305         (source_lines_range::source_lines_range): New function.
11306         * source.h (class source_lines_range): New class.
11307         (print_source_lines): New declaration.
11308
11309 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11310
11311         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11312
11313 2019-01-08  Tom Tromey  <tom@tromey.com>
11314             Simon Marchi  <simon.marchi@ericsson.com>
11315
11316         PR gdb/24060
11317         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11318         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11319         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11320         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11321         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11322         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11323
11324 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11325
11326         * source.c (select_source_symtab): Move header comment to
11327         declaration in source.h.
11328         (forget_cached_source_info_for_objfile): Likewise.
11329         (forget_cached_source_info): Likewise.
11330         (identify_source_line): Likewise.
11331         * source.h (identify_source_line): Move declaration from symtab.h
11332         and add comment from source.c
11333         (print_source_lines): Likewise.
11334         (forget_cached_source_info_for_objfile): Likewise.
11335         (forget_cached_source_info): Likewise.
11336         (select_source_symtab): Likewise.
11337         (enum print_source_lines_flag): Move definition from symtab.h.
11338         * symtab.h (identify_source_line): Move declaration to source.h.
11339         (print_source_lines): Likewise.
11340         (forget_cached_source_info_for_objfile): Likewise.
11341         (forget_cached_source_info): Likewise.
11342         (select_source_symtab): Likewise.
11343         (enum print_source_lines_flag): Move definition to source.h.
11344         * tui/tui-hooks.c: Add 'source.h' include.
11345
11346 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11347
11348         * source.c (print_source_lines_base): Handle requests to print
11349         reverse line number sequences, and guard against empty lines
11350         string.
11351
11352 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11353
11354         * source.c (print_source_lines_base): Fix skip of '\r' if next
11355         character is '\n'.
11356
11357 2019-01-06  Tom Tromey  <tom@tromey.com>
11358
11359         * c-exp.y (struct c_parse_state) <macro_original_text,
11360         expansion_obstack>: New member.
11361         (macro_original_text, expansion_obstack): Remove globals.
11362         (scan_macro_expansion, scanning_macro_expansion)
11363         (finished_macro_expansion): Update.
11364         (scan_macro_cleanup): Remove.
11365         (yylex, c_parse): Update.
11366
11367 2019-01-06  Tom Tromey  <tom@tromey.com>
11368
11369         * c-exp.y (struct c_parse_state) <strings>: New member.
11370         (operator_stoken): Update.
11371
11372 2019-01-06  Tom Tromey  <tom@tromey.com>
11373
11374         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11375         (union type_stack_elt) <typelist_val>: Now a pointer to
11376         std::vector.
11377         (type_stack_cleanup): Don't declare.
11378         (push_typelist): Update.
11379         * parse.c (pop_typelist): Return a std::vector.
11380         (push_typelist): Take a std::vector.
11381         (follow_types): Update.  Do not free args.
11382         (type_stack_cleanup): Remove.
11383         * c-exp.y (struct c_parse_state): New.
11384         (cpstate): New global.
11385         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11386         (nonempty_typelist): Update.
11387         (func_mod): Create a new vector.
11388         (c_parse): Create a c_parse_state.
11389         (check_parameter_typelist): Do not delete params.
11390         (function_method): Update.  Do not delete type_list.
11391
11392 2019-01-06  Tom Tromey  <tom@tromey.com>
11393
11394         PR gdb/28155:
11395         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11396         check_typedef.
11397         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11398         (print_return_value): Likewise.
11399
11400 2019-01-05  Tom Tromey  <tom@tromey.com>
11401
11402         * contrib/cleanup_check.py: Remove.
11403         * contrib/gcc-with-excheck: Remove.
11404         * contrib/exsummary.py: Remove.
11405         * contrib/excheck.py: Remove.
11406
11407 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11408
11409         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11410         NULL. Initialize tpprev to NULL instead of assigning it
11411         to NULL on the next statement.
11412         * windows-nat.c (windows_delete_thread): Remove check for
11413         main_thread_id before printing thread exit notifications.
11414         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11415         Remove thread ID check against main_thread_id.
11416         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11417         windows_delete_thread.
11418         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11419
11420 2019-01-04  Tom Tromey  <tom@tromey.com>
11421
11422         * compile/compile.c (_initialize_compile): Use upper case for
11423         metasyntactic variables.
11424         * symmisc.c (_initialize_symmisc): Use upper case for
11425         metasyntactic variables.
11426         * psymtab.c (_initialize_psymtab): Use upper case for
11427         metasyntactic variables.
11428         * demangle.c (demangle_command): Use upper case for metasyntactic
11429         variables.
11430         (_initialize_demangler): Likewise.
11431         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11432         variables.
11433
11434 2019-01-03  Tom Tromey  <tom@tromey.com>
11435
11436         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11437
11438 2019-01-03  Tom Tromey  <tom@tromey.com>
11439
11440         * python/py-symtab.c (salpy_str): Update.
11441         (struct salpy_sal_object) <symtab>: Now a PyObject.
11442         (salpy_dealloc): Update.
11443         (del_objfile_sal): Use gdbpy_ref.
11444
11445 2019-01-03  Tom Tromey  <tom@tromey.com>
11446
11447         * python/py-type.c (convert_field): Use new_reference.  Return
11448         gdbpy_ref.
11449         (make_fielditem): Return gdbpy_ref.
11450         (typy_fields): Update.
11451         (typy_getitem): Update.
11452         (field_name): Return gdbpy_ref.  Use new_reference.
11453         (typy_iterator_iternext): Update.
11454
11455 2019-01-03  Tom Tromey  <tom@tromey.com>
11456
11457         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11458
11459 2019-01-03  Tom Tromey  <tom@tromey.com>
11460
11461         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11462         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11463         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11464         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11465         (pspy_set_type_printers): Likewise.
11466         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11467         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11468         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11469         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11470         (objfpy_set_type_printers): Likewise.
11471
11472 2019-01-03  Tom Tromey  <tom@tromey.com>
11473
11474         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11475         (gdbpy_print_stack): Use gdbpy_err_fetch.
11476         * python/python-internal.h (class gdbpy_err_fetch): New class.
11477         (class gdbpy_enter) <m_error_type, m_error_value,
11478         m_error_traceback>: Remove.
11479         <m_error>: New member.
11480         (gdbpy_exception_to_string): Don't declare.
11481         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11482         * python/py-value.c (convert_value_from_python): Use
11483         gdbpy_err_fetch.
11484         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11485         gdbpy_exception_to_string.
11486         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11487         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11488         gdbpy_err_fetch.
11489
11490 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11491
11492         * linux-nat.c (delete_lwp_cleanup): Delete.
11493         (struct lwp_deleter): New struct.
11494         (lwp_info_up): New typedef.
11495         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11496         lwp_info_up.
11497
11498 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11499
11500         * linux-fork.c (class scoped_switch_fork_info): New class.
11501         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11502
11503 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11504
11505         * valops.c (find_overload_match): Remove use of null_cleanup, and
11506         calls to do_cleanups.
11507
11508 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11509
11510         * compile/compile-cplus-types.c
11511         (compile_cplus_instance::decl_name): Handle changes to
11512         cp_func_name.
11513         * cp-support.c (cp_func_name): Update header comment, update
11514         return type.
11515         * cp-support.h (cp_func_name): Update return type in declaration.
11516         * valops.c (find_overload_match): Move temp_func local to top
11517         level of function and change its type.  Use temp_func to hold and
11518         delete temporary string obtained from cp_func_name.
11519
11520 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11521
11522         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11523         gdb::char_vector, remove cleanup, and update uses of `msg`.
11524
11525 2019-01-03  Jim Wilson  <jimw@sifive.com>
11526
11527         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11528
11529 2019-01-02  Tom Tromey  <tom@tromey.com>
11530
11531         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11532         (tdesc_parse_xml): Remove cleanups.
11533         * target-descriptions.h (make_cleanup_free_target_description):
11534         Don't declare.
11535         (target_desc_deleter): New struct.
11536         (target_desc_up): New typedef.
11537         * target-descriptions.c (target_desc_deleter::operator()): Rename
11538         from free_target_description.
11539         (make_cleanup_free_target_description): Remove.
11540
11541 2019-01-02  Tom Tromey  <tom@tromey.com>
11542
11543         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11544         constructor, destructor.
11545         (linespec_parser): Remove typedef.
11546         (~linespec_parser): Rename from linespec_parser_delete.
11547         (linespec_lex_to_end, linespec_complete_label)
11548         (linespec_complete): Update.
11549         (decode_line_full): Remove cleanups.
11550         (decode_line_1): Update.
11551
11552 2019-01-02  Tom Tromey  <tom@tromey.com>
11553
11554         * python/python-internal.h (inferior_to_inferior_object): Change
11555         return type.
11556         * python/py-exitedevent.c (create_exited_event_object): Update.
11557         * python/py-inferior.c (inferior_to_inferior_object): Return
11558         gdbpy_ref.
11559         (python_new_inferior, python_inferior_deleted)
11560         (thread_to_thread_object, delete_thread_object)
11561         (build_inferior_list, gdbpy_selected_inferior): Update.
11562         * python/py-infthread.c (create_thread_object): Update.  Also fail
11563         if inferior_to_inferior_object fails.
11564
11565 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11566
11567         * inferior.h (class inferior) <displaced_step_state>: New field.
11568         * infrun.h (struct displaced_step_state): Move here from
11569         infrun.c.  Initialize fields, add constructor.
11570         <inf>: Remove field.
11571         <reset>: New method.
11572         * infrun.c (struct displaced_step_inferior_state): Move to
11573         infrun.h.
11574         (displaced_step_inferior_states): Remove.
11575         (get_displaced_stepping_state): Adust.
11576         (displaced_step_in_progress_any_inferior): Adjust.
11577         (displaced_step_in_progress_thread): Adjust.
11578         (displaced_step_in_progress): Adjust.
11579         (add_displaced_stepping_state): Remove.
11580         (get_displaced_step_closure_by_addr): Adjust.
11581         (remove_displaced_stepping_state): Remove.
11582         (infrun_inferior_exit): Call displaced_step_state.reset.
11583         (use_displaced_stepping): Don't check for NULL.
11584         (displaced_step_prepare_throw): Call
11585         get_displaced_stepping_state.
11586         (displaced_step_fixup): Don't check for NULL.
11587         (prepare_for_detach): Don't check for NULL.
11588
11589 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11590
11591         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11592          in case of call that did not complete.
11593
11594 2019-01-02  Andrey Utkin  <autkin@undo.io>
11595
11596         * symfile.c (find_separate_debug_file): Fix search of debug files for
11597         remote debuggee.
11598
11599 2019-01-02  Tom Tromey  <tom@tromey.com>
11600
11601         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11602         indentation.
11603         * python/py-frame.c (frapy_older): Remove cast.
11604         (frapy_newer): Likewise.
11605         * python/py-breakpoint.c (local_setattro): Remove cast.
11606         * python/py-arch.c (archpy_name): Remove local variable.
11607         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11608
11609 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11610
11611         * unittests/basic_string_view/element_access/char/empty.cc:
11612         Fix year range in copyright header.
11613
11614 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11615
11616         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11617         Delete.
11618         <operator==>: Update with for removed field.
11619         <hash>: Likewise.
11620         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11621         <isa_features>: ...this.
11622         <abi_features>: New field.
11623         (riscv_isa_flen): Update comment.
11624         (riscv_abi_xlen): New declaration.
11625         (riscv_abi_flen): New declaration.
11626         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11627         isa_features.
11628         (riscv_abi_xlen): New function.
11629         (riscv_isa_flen): Update to get answer from isa_features.
11630         (riscv_abi_flen): New function.
11631         (riscv_has_fp_abi): Update to get answer from abi_features.
11632         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11633         xlen and flen.
11634         (riscv_call_info) <xlen, flen>: Update comment.
11635         (riscv_call_arg_struct): Remove invalid assertions
11636         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11637         is removed.
11638         (riscv_gdbarch_init): Gather isa features and abi features
11639         separately, ensure both match on the gdbarch when reusing an old
11640         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11641         a target with 64-bit float hardware.
11642
11643 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11644
11645         * source.c (search_command_helper): Stop reverse search
11646         when line 1 has been searched.
11647
11648 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11649
11650         * record-full.c (record_full_base_target::close): Rewrite
11651         record_full_core_buf_list free logic.
11652
11653 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11654
11655         * break-catch-syscall.c (print_one_catch_syscall): xfree
11656         the last text.
11657
11658 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11659
11660         * top.c (print_gdb_version): Update Copyright year in version
11661         message.
11662
11663 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11664
11665         Update copyright year range in all GDB files.
11666
11667 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11668
11669         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11670
11671 For older changes see ChangeLog-2018.
11672 \f
11673 Local Variables:
11674 mode: change-log
11675 left-margin: 8
11676 fill-column: 74
11677 version-control: never
11678 coding: utf-8
11679 End:
11680