gdb/ChangeLog

   1 2015-01-17  Wei-cheng Wang  <cole945@gmail.com>
   2
   3         * ppc-linux-tdep.c (ppc_skip_trampoline_code):
   4         Scan PLT stub backward for reverse debugging.
   5         * ppc64-tdep.c (ppc64_skip_trampoline_code): Likewise.
   6
   7 2015-01-17  Wei-cheng Wang  <cole945@gmail.com>
   8             Ulrich Weigand  <uweigand@de.ibm.com>
   9
  10         * configure.tgt (powerpc*-*-linux): Add linux-record.o to
  11         gdb_target_obs.
  12         (ppc_linux_record_tdep, ppc64_linux_record_tdep): New for linux syscall
  13         record.
  14         (ppc_canonicalize_syscall, ppc_linux_syscall_record,
  15         ppc_linux_record_signal, ppc_init_linux_record_tdep): New functions.
  16         (ppc_linux_init_abi): Set process_record, process_record_signal.
  17         * ppc-tdep.h (struct gdbarch_tdep): Add ppc_syscall_record and
  18         ppc_linux_record_tdep to gdbarch_tdep.
  19         (ppc_process_record): New declaration.
  20         * rs6000-tdep.c (ppc_record_vsr, ppc_process_record_op4,
  21         ppc_process_record_op19, ppc_process_record_op31,
  22         ppc_process_record_op59, ppc_process_record_op60,
  23         ppc_process_record_op63, ppc_process_record): New functions.
  24
  25 2015-01-17  Wei-cheng Wang  <cole945@gmail.com>
  26
  27         * rs6000-tdep.c (rs6000_in_function_epilogue_p): Rename to
  28         rs6000_in_function_epilogue_frame_p and add an argument
  29         for frame_info.
  30         (rs6000_epilogue_frame_cache, rs6000_epilogue_frame_this_id,
  31         rs6000_epilogue_frame_prev_register, rs6000_epilogue_frame_sniffer):
  32         New functions.
  33         (rs6000_epilogue_frame_unwind): New.
  34         (rs6000_gdbarch_init): Append epilogue unwinder.
  35
  36 2015-01-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  37
  38         * nat/linux-personality.c: Replace "#ifndef
  39         HAVE_DECL_ADDR_NO_RANDOMIZE" by "#if
  40         !HAVE_DECL_ADDR_NO_RANDOMIZE", fixing a regression in RHEL-5
  41         systems.
  42
  43 2015-01-16  Eli Zaretskii  <eliz@gnu.org>
  44
  45         * tui/tui-win.c (tui_rehighlight_all, tui_set_var_cmd): New
  46         functions.
  47         (_initialize_tui_win) <border-kind, border-mode>:
  48         <active-border-mode>: Use tui_set_var_cmd as the "set" function.
  49         (tui_set_tab_width_command): Fix the commentary.
  50
  51         * tui/tui-win.h: Add prototype for tui_rehighlight_all.
  52
  53         * tui/tui-win.c (tui_scroll_left_command, tui_scroll_right_command):
  54         Doc fix.
  55         (tui_set_tab_width_command): Delete and recreate the source and
  56         the disassembly windows, to show the effect of the changed tab
  57         size immediately.
  58
  59         * tui/tui-data.h (LINE_PREFIX): Make shorter
  60         (MAX_PID_WIDTH): Enlarge from 14 to 19, to leave enough space for
  61         "Thread NNNNN.XXXX" thread ID notation on Windows.
  62
  63 2015-01-16  Jan Kratochvil  <jan.kratochvil@redhat.com>
  64
  65         Fix gcc-5 compilation.
  66         * hppa-tdep.c (inst_saves_gr): Fix parentheses typo.
  67
  68 2015-01-15  Sergio Durigan Junior  <sergiodj@redhat.com>
  69
  70         * Makefile.in (HFILES_NO_SRCDIR): Add nat/linux-personality.h.
  71         (linux-personality.o): New rule.
  72         * common/common-defs.h: Include <stdint.h>.
  73         * config/aarch64/linux.mh (NATDEPFILES): Include
  74         linux-personality.o.
  75         * config/alpha/alpha-linux.mh (NATDEPFILES): Likewise.
  76         * config/arm/linux.mh (NATDEPFILES): Likewise.
  77         * config/i386/linux64.mh (NATDEPFILES): Likewise.
  78         * config/i386/linux.mh (NATDEPFILES): Likewise.
  79         * config/ia64/linux.mh (NATDEPFILES): Likewise.
  80         * config/m32r/linux.mh (NATDEPFILES): Likewise.
  81         * config/m68k/linux.mh (NATDEPFILES): Likewise.
  82         * config/mips/linux.mh (NATDEPFILES): Likewise.
  83         * config/pa/linux.mh (NATDEPFILES): Likewise.
  84         * config/powerpc/linux.mh (NATDEPFILES): Likewise.
  85         * config/powerpc/ppc64-linux.mh (NATDEPFILES): Likewise.
  86         * config/powerpc/spu-linux.mh (NATDEPFILES): Likewise.
  87         * config/s390/linux.mh (NATDEPFILES): Likewise.
  88         * config/sparc/linux64.mh (NATDEPFILES): Likewise.
  89         * config/sparc/linux.mh (NATDEPFILES): Likewise.
  90         * config/tilegx/linux.mh (NATDEPFILES): Likewise.
  91         * config/xtensa/linux.mh (NATDEPFILES): Likewise.
  92         * defs.h: Remove #include <stdint.h> (moved to
  93         common/common-defs.h).
  94         * linux-nat.c: Include nat/linux-personality.h.  Remove #include
  95         <sys/personality.h>; do not define ADDR_NO_RANDOMIZE (moved to
  96         nat/linux-personality.c).
  97         (linux_nat_create_inferior): Remove code to disable address space
  98         randomization (moved to nat/linux-personality.c).  Create cleanup
  99         to disable address space randomization.
 100         * nat/linux-personality.c: New file.
 101         * nat/linux-personality.h: Likewise.
 102
 103 2015-01-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 104
 105         * Makefile.in (ALLDEPFILES): Including common/mingw-strerror.c and
 106         common/posix-strerror.c.
 107         (posix-strerror.o): New rule.
 108         (mingw-strerror.o): Likewise.
 109         * common/common-utils.h (safe_strerror): Move prototype to here,
 110         from utils.h.
 111         * common/common.host: New file.
 112         * common/mingw-strerror.c: Likewise.
 113         * common/posix-strerror.c: Likewise.
 114         * configure: Regenerated.
 115         * configure.ac: Source common/common.host.  Add variable
 116         common_host_obs to gdb_host_obs.
 117         * contrib/ari/gdb_ari.sh: Mention gdb/common/mingw-strerror.c and
 118         gdb/common/posix-strerror.c when warning about the use of
 119         strerror.
 120         * mingw-hdep.c (safe_strerror): Remove definition; move it to
 121         common/mingw-strerror.c.
 122         * posix-hdep.c (safe_strerror): Remove definition; move it to
 123         common/posix-hdep.c.
 124         * utils.h (safe_strerror): Remove prototype; move to
 125         common/common-utils.h.
 126
 127 2015-01-15  Joel Brobecker  <brobecker@adacore.com>
 128
 129         GDB 7.8.2 released.
 130
 131 2015-01-15  Joel Brobecker  <brobecker@adacore.com>
 132
 133         * ada-lang.c (ada_array_bound_from_type): Ignore array's parallel
 134         ___XA type if the array has already been fixed.
 135
 136 2015-01-14  Yao Qi  <yao@codesourcery.com>
 137
 138         * Makefile.in (ppc-linux.o): New rule.
 139         * config/powerpc/ppc64-linux.mh (NATDEPFILES): Add ppc-linux.o.
 140         * configure.ac: AC_CHECK_FUNCS(getauxval).
 141         * config.in: Re-generated.
 142         * configure: Re-generated.
 143         * nat/ppc-linux.h [__powerpc64__] (ppc64_64bit_inferior_p):
 144         Declare.
 145         * nat/ppc-linux.c: New file.
 146         * ppc-linux-nat.c (ppc_linux_target_wordsize) [__powerpc64__]:
 147         Call ppc64_64bit_inferior_p.
 148
 149 2015-01-14  Yao Qi  <yao@codesourcery.com>
 150
 151         * ppc-linux-nat.c (PT_ORIG_R3, PT_TRAP): Move to
 152         nat/ppc-linux.h.
 153         (PPC_FEATURE_CELL, PPC_FEATURE_BOOKE): Likewise.
 154         (PPC_FEATURE_HAS_DFP): Likewise.
 155         (PTRACE_GETVRREGS, PTRACE_SETVRREGS): Likewise.
 156         (PTRACE_GETVSXREGS, PTRACE_SETVSXREGS): Likewise.
 157         (PTRACE_GETEVRREGS, PTRACE_SETEVRREGS): Likewise.
 158         Include "nat/ppc-linux.h".
 159         * nat/ppc-linux.h: New file.
 160         * Makefile.in (HFILES_NO_SRCDIR): Add nat/ppc-linux.h.
 161
 162 2015-01-14  Pedro Alves  <palves@redhat.com>
 163
 164         PR gdb/17525
 165         * breakpoint.c: Include "interps.h".
 166         (bpstat_do_actions_1): Also check whether the interpreter is
 167         async.
 168
 169 2015-01-14  Pedro Alves  <palves@redhat.com>
 170
 171         PR cli/17828
 172         * infrun.c (reinstall_readline_callback_handler_cleanup): Don't
 173         reinstall if the interpreter is sync.
 174
 175 2015-01-13  Doug Evans  <dje@google.com>
 176
 177         * objfiles.c (objfile_filename): New function.
 178         * objfiles.h (objfile_filename): Declare it.
 179         (objfile_name): Add function comment.
 180         * python/py-objfile.c (objfpy_lookup_objfile_by_name): Try both the
 181         bfd file name (which may be realpath'd), and the original name.
 182
 183 2015-01-13  Joel Brobecker  <brobecker@adacore.com>
 184
 185         * NEWS: Create a new section for the next release branch.
 186         Rename the section of the current branch, now that it has
 187         been cut.
 188
 189 2015-01-13  Joel Brobecker  <brobecker@adacore.com>
 190
 191         GDB 7.9 branch created (92fc2e6978d9a7c8324c7e851dbee59e22ec7a37):
 192         * version.in: Bump version to 7.9.50.DATE-cvs.
 193
 194 2015-01-13  Joel Brobecker  <brobecker@adacore.com>
 195
 196         * nat/linux-procfs.c (linux_proc_attach_tgid_threads):
 197         Remove trailing new-line in argument of call to warning.
 198
 199 2015-01-13  Joel Brobecker  <brobecker@adacore.com>
 200
 201         * linux-nat.c (attach_proc_task_lwp_callback): Remove trailing
 202         new-line in argument of call to "warning".
 203
 204 2015-01-13  Joel Brobecker  <brobecker@adacore.com>
 205
 206         * ada-lang.c (ada_lookup_symbol_nonlocal): If name not found
 207         in static block, then try searching for primitive types.
 208
 209 2015-01-12  Patrick Palka  <patrick@parcs.ath.cx>
 210
 211         * top.h (gdb_add_history): Declare.
 212         * top.c (command_count): New variable.
 213         (gdb_add_history): New function.
 214         (gdb_safe_append_history): New static function.
 215         (quit_force): Call it.
 216         (command_line_input): Use gdb_add_history instead of
 217         add_history.
 218         * event-top.c (command_line_handler): Likewise.
 219
 220 2015-01-12  James Clarke  <jrtc27@jrtc27.com>  (tiny patch)
 221
 222         PR gdb/17046
 223         * darwin-nat.c: Replace <machine/setjmp.h> #include by
 224         <setjmp.h> #include.
 225
 226 2015-01-11  Doug Evans  <xdje42@gmail.com>
 227
 228         * dwarf2read.c (compute_delayed_physnames): Use TYPE_FN_FIELD_PHYSNAME.
 229
 230 2015-01-11  Doug Evans  <xdje42@gmail.com>
 231
 232         PR gdb/15830
 233         * NEWS: The "maint demangle" command is renamed as "demangle".
 234         * demangle.c: #include cli/cli-utils.h, language.h.
 235         (demangle_command): New function.
 236         (_initialize_demangle): Add new command "demangle".
 237         * maint.c (maintenance_demangle): Stub out.
 238         (_initialize_maint_cmds): Update help text for "maint demangle",
 239         and mark as deprecated.
 240
 241 2015-01-11  Mark Kettenis  <kettenis@gnu.org>
 242
 243         * inf-ptrace.c (inf_ptrace_follow_fork): Adjust now that
 244         inferior_thread is a function.
 245
 246 2015-01-09  Patrick Palka  <patrick@parcs.ath.cx>
 247
 248         * Makefile.in (.y.c): Don't munge yacc's #line
 249         directives.
 250
 251 2015-01-09  Patrick Palka  <patrick@parcs.ath.cx>
 252
 253         * utils.c (defaulted_query): Rewrite to use gdb_readline_wrapper
 254         to prompt for input.
 255         * tui/tui-hooks.c (tui_query_hook): Remove.
 256         (tui_install_hooks): Don't set deprecated_query_hook.
 257         * tui/tui-io.c (tui_redisplay_readline): Fix off-by-one error in
 258         height calculation.  Always update the command window's cur_line.
 259
 260 2015-01-09  Pedro Alves  <palves@redhat.com>
 261
 262         * breakpoint.c (hardware_breakpoint_inserted_here_p): New
 263         function.
 264         * breakpoint.h (hardware_breakpoint_inserted_here_p): New
 265         declaration.
 266         * linux-nat.c (linux_nat_status_is_event): Move higher up in file.
 267         (linux_resume_one_lwp): Store the thread's PC.  Adjust to clear
 268         stop_reason.
 269         (check_stopped_by_watchpoint): New function.
 270         (save_sigtrap): Reimplement.
 271         (linux_nat_stopped_by_watchpoint): Adjust.
 272         (linux_nat_lp_status_is_event): Delete.
 273         (stop_wait_callback): Only call save_sigtrap after storing the
 274         pending status.
 275         (status_callback): If the thread had been stopped for a breakpoint
 276         that has since been removed, discard the event and resume the LWP.
 277         (count_events_callback, select_event_lwp_callback): Use
 278         lwp_status_pending_p instead of linux_nat_lp_status_is_event.
 279         (cancel_breakpoint): Rename to ...
 280         (check_stopped_by_breakpoint): ... this.  Record whether the LWP
 281         stopped for a software breakpoint or hardware breakpoint.
 282         (select_event_lwp): Only give preference to the stepping LWP in
 283         all-stop mode.  Adjust comments.
 284         (stop_and_resume_callback): Remove references to new_pending_p.
 285         (linux_nat_filter_event): Likewise.  Leave exit events of the
 286         leader thread pending here.  Handle signal short circuiting here.
 287         Only call save_sigtrap after storing the pending waitstatus.
 288         (linux_nat_wait_1): Remove 'retry' label.  Remove references to
 289         new_pending.  Don't handle leaving events the caller is not
 290         interested in pending here, nor handle signal short-circuiting
 291         here.  Also give equal priority to all LWPs that have had events
 292         in non-stop mode.  If reporting a software breakpoint event,
 293         unadjust the LWP's PC.
 294         * linux-nat.h (enum lwp_stop_reason): New.
 295         (struct lwp_info) <stop_pc>: New field.
 296         (struct lwp_info) <stopped_by_watchpoint>: Delete field.
 297         (struct lwp_info) <stop_reason>: New field.
 298         * x86-linux-nat.c (x86_linux_prepare_to_resume): Adjust.
 299
 300 2015-01-09  Pedro Alves  <palves@redhat.com>
 301
 302         * linux-nat.c (linux_handle_extended_wait) <PTRACE_EVENT_EXEC>:
 303         Set the LWP's 'resumed' flag.
 304
 305 2015-01-09  Pedro Alves  <palves@redhat.com>
 306
 307         * linux-nat.c (linux_resume_one_lwp): New function.
 308         (resume_lwp): Use lwp_status_pending_p and linux_resume_one_lwp.
 309         (linux_nat_resume): Use lwp_status_pending_p and
 310         linux_resume_one_lwp.
 311         (linux_handle_syscall_trap): Use linux_resume_one_lwp.
 312         (linux_handle_extended_wait): Use linux_resume_one_lwp.
 313         (status_callback, running_callback): Use lwp_status_pending_p.
 314         (lwp_status_pending_p): New function.
 315         (stop_and_resume_callback): Use lwp_status_pending_p.
 316         (linux_nat_filter_event): Use linux_resume_one_lwp.
 317         (linux_nat_wait_1): Always use status_callback to look for an LWP
 318         with a pending status.  Use linux_resume_one_lwp.
 319         (resume_stopped_resumed_lwps): Use lwp_status_pending_p and
 320         linux_resume_one_lwp.
 321
 322 2015-01-09  Pedro Alves  <palves@redhat.com>
 323
 324         * breakpoint.c (bp_location_inserted_here_p): New function,
 325         factored out from ...
 326         (breakpoint_inserted_here_p): ... here.  Use
 327         ALL_BP_LOCATIONS_AT_ADDR.
 328         (software_breakpoint_inserted_here_p): Use
 329         bp_location_inserted_here_p and ALL_BP_LOCATIONS_AT_ADDR.
 330
 331 2014-01-09  Pedro Alves  <palves@redhat.com>
 332
 333         Skip enabling event reporting if the kernel supports
 334         PTRACE_EVENT_CLONE.
 335         * linux-thread-db.c: Include "nat/linux-ptrace.h".
 336         (thread_db_use_events): New function.
 337         (try_thread_db_load_1): Check thread_db_use_events before enabling
 338         event reporting.
 339         (update_thread_state): New function.
 340         (attach_thread): Use it.  Check thread_db_use_events before
 341         enabling event reporting.
 342         (thread_db_detach): Check thread_db_use_events before disabling
 343         event reporting.
 344         (find_new_threads_callback): Check thread_db_use_events before
 345         enabling event reporting.  Update the thread's state if not using
 346         libthread_db events.
 347
 348 2015-01-09  Pedro Alves  <palves@redhat.com>
 349
 350         * linux-nat.c (lin_lwp_attach_lwp): Assert that the lwp id we're
 351         about to wait for is > 0.
 352         * linux-thread-db.c (find_new_threads_callback): Ignore thread if
 353         the kernel thread ID is -1.
 354
 355 2015-01-09  Pedro Alves  <palves@redhat.com>
 356
 357         * linux-nat.c (attach_proc_task_lwp_callback): New function.
 358         (linux_nat_attach): Use linux_proc_attach_tgid_threads.
 359         (wait_lwp, linux_nat_filter_event): If not set yet, set the lwp's
 360         ptrace option flags.
 361         * linux-nat.h (struct lwp_info) <must_set_ptrace_flags>: New
 362         field.
 363         * nat/linux-procfs.c: Include <dirent.h>.
 364         (linux_proc_get_int): New parameter "warn".  Handle it.
 365         (linux_proc_get_tgid): Adjust.
 366         (linux_proc_get_tracerpid): Rename to ...
 367         (linux_proc_get_tracerpid_nowarn): ... this.
 368         (linux_proc_pid_get_state): New function, factored out from
 369         (linux_proc_pid_has_state): ... this.  Add new parameter "warn"
 370         and handle it.
 371         (linux_proc_pid_is_gone): New function.
 372         (linux_proc_pid_is_stopped): Adjust.
 373         (linux_proc_pid_is_zombie_maybe_warn)
 374         (linux_proc_pid_is_zombie_nowarn): New functions.
 375         (linux_proc_pid_is_zombie): Use
 376         linux_proc_pid_is_zombie_maybe_warn.
 377         (linux_proc_attach_tgid_threads): New function.
 378         * nat/linux-procfs.h (linux_proc_get_tgid): Update comment.
 379         (linux_proc_get_tracerpid): Rename to ...
 380         (linux_proc_get_tracerpid_nowarn): ... this, and update comment.
 381         (linux_proc_pid_is_gone): New declaration.
 382         (linux_proc_pid_is_zombie): Update comment.
 383         (linux_proc_pid_is_zombie_nowarn): New declaration.
 384         (linux_proc_attach_lwp_func): New typedef.
 385         (linux_proc_attach_tgid_threads): New declaration.
 386         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason): Adjust to
 387         use nowarn functions.
 388         (linux_ptrace_attach_fail_reason_string): Move here from
 389         gdbserver/linux-low.c and rename.
 390         (ptrace_supports_feature): If the current ptrace options are not
 391         known yet, check them now, instead of asserting.
 392         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason_string):
 393         Declare.
 394
 395 2015-01-09  Pedro Alves  <palves@redhat.com>
 396
 397         * linux-thread-db.c (thread_db_find_new_threads_silently)
 398         (try_thread_db_load_1, try_thread_db_load, thread_db_load_search)
 399         (find_new_threads_once): Print debug output on gdb_stdlog.
 400
 401 2015-01-09  Chen Gang  <gang.chen.5i5j@gmail.com>
 402             Pedro Alves  <palves@redhat.com>
 403
 404         * compile/compile.c: Include "gdb_wait.h".
 405         (do_rmdir): Check return value, and free 'zap'.
 406
 407 2015-01-08  Pedro Alves  <palves@redhat.com>
 408             Yao Qi  <yao@codesourcery.com>
 409
 410         * dwarf2loc.c (indirect_pieced_value): Don't call
 411         gdb_sign_extend.  Call extract_signed_integer instead.
 412         * utils.c (gdb_sign_extend): Remove.
 413         * utils.h (gdb_sign_extend): Remove declaration.
 414
 415 2015-01-07  Pierre Muller  <muller@sourceware.org>
 416
 417         PR symtab/17811
 418         * stabsread.c (define_symbol): Set language for C++ special symbols.
 419
 420 2015-01-07  Patrick Palka  <patrick@parcs.ath.cx>
 421
 422         * inflow.c (initial_gdb_ttystate): Tweak comment.
 423
 424 2015-01-07  Joel Brobecker  <brobecker@adacore.com>
 425
 426         * inflow.c (set_initial_gdb_ttystate): Add empty line after
 427         comment documenting function.
 428
 429 2015-01-07  Patrick Palka  <patrick@parcs.ath.cx>
 430
 431         * terminal.h (set_initial_gdb_ttystate): Declare.
 432         * inflow.c (initial_gdb_ttystate): New static variable.
 433         (set_initial_gdb_ttystate): New setter.
 434         (child_terminal_init_with_pgrp): Copy initial_gdb_ttystate
 435         instead of our current terminal state.
 436         * top.c (gdb_init): Call set_initial_gdb_ttystate.
 437
 438 2015-01-07  Joel Brobecker  <brobecker@adacore.com>
 439
 440         * guile/scm-type.c (tyscm_array_1): Add comment.
 441         * python/py-type.c (typy_array_1): Add comment.
 442
 443 2015-01-06  Joel Brobecker  <brobecker@adacore.com>
 444
 445         * guile/scm-type.c (tyscm_array_1): Do not raise out-of-range
 446         error if N2 is equal to N1 - 1.
 447
 448 2015-01-06  Joel Brobecker  <brobecker@adacore.com>
 449
 450         * python/py-type.c (typy_array_1): Do not raise negative-length
 451         exception if N2 is equal to N1 - 1.
 452
 453 2015-01-03  Doug Evans  <xdje42@gmail.com>
 454
 455         * c-exp.y: Whitespace cleanup.
 456         (classify_inner_name): Remove extra ;.
 457
 458 2015-01-02  Maciej W. Rozycki  <macro@codesourcery.com>
 459
 460         * mips-tdep.c (mips32_scan_prologue): Keep the extracted stack
 461         offset signed.
 462
 463 2015-01-02  Doug Evans  <dje@google.com>
 464
 465         * dwarf2read.c (setup_type_unit_groups): Remove outdated comment.
 466
 467 2015-01-02  Doug Evans  <dje@google.com>
 468
 469         * symtab.h (struct symbol): Fix typo in comment.
 470
 471 2015-01-01  Joel Brobecker  <brobecker@adacore.com>
 472
 473         Update year range in copyright notice of all files.
 474
 475 2015-01-01  Joel Brobecker  <brobecker@adacore.com>
 476
 477         * top.c (print_gdb_version): Update copyright year to 2015.
 478
 479 2015-01-01  Joel Brobecker  <brobecker@adacore.com>
 480
 481         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2014.
 482
 483 For older changes see ChangeLog-2014.
 484 \f
 485 Local Variables:
 486 mode: change-log
 487 left-margin: 8
 488 fill-column: 74
 489 version-control: never
 490 coding: utf-8
 491 End: