gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (make_source_or_disasm_window): Always use
   4         init_and_make_win for EXEC_INFO_WIN.
   5         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
   6         longer inline.
   7         (struct tui_win_info) <~tui_win_info>: Inline.
   8         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
   9         Don't declare.
  10         * tui/tui-data.c (source_win, disasm_win): Remove globals.
  11         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
  12         Remove.
  13         (tui_initialize_static_data): Update.
  14         (~tui_gen_win_info): Handle more cleanup here.
  15         (~tui_source_window_base): Delete "execution_info".
  16         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
  17
  18 2019-06-25  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-layout.c (make_command_window): Don't set
  21         can_highlight.
  22         (show_source_disasm_command): Call the reset method.
  23         (show_data): Don't set can_highlight.  Call the reset method.
  24         (tui_gen_win_info::reset): Rename from init_gen_win_info
  25         (init_and_make_win): Simplify.  Return tui_gen_win_info.
  26         (show_source_or_disasm_and_command): Call the reset method.
  27         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
  28         (struct tui_cmd_window): Set can_highlight.
  29
  30 2019-06-25  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
  33         from make_visible.
  34         (tui_make_visible, tui_make_invisible): Rewrite.
  35         (tui_win_info::make_visible): Remove.
  36         (tui_source_window_base::make_visible): Update.
  37         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
  38         method.  Moved from...
  39         (struct tui_win_info) <make_visible>: ...here.
  40
  41 2019-06-25  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-winsource.c
  44         (tui_source_window_base::do_scroll_horizontal): Remove direction
  45         parameter.
  46         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
  47         direction parameter.
  48         * tui/tui-win.c (tui_win_info::forward_scroll)
  49         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
  50         (tui_win_info::right_scroll): Update.
  51         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
  52         direction parameter.
  53         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
  54         direction parameter.
  55         * tui/tui-data.h (enum tui_scroll_direction): Remove.
  56         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
  57         Remove direction parameter.
  58         (struct tui_source_window_base, struct tui_source_window)
  59         (struct tui_disasm_window, struct tui_data_window)
  60         (struct tui_cmd_window): Update.
  61
  62 2019-06-25  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-winsource.h (tui_set_exec_info_content)
  65         (tui_show_exec_info_content, tui_erase_exec_info_content)
  66         (tui_clear_exec_info_content, tui_update_exec_info): Change
  67         argument to tui_source_window_base.
  68         * tui/tui-winsource.c (tui_set_exec_info_content)
  69         (tui_show_exec_info_content, tui_erase_exec_info_content)
  70         (tui_clear_exec_info_content, tui_update_exec_info): Change
  71         argument to tui_source_window_base.
  72
  73 2019-06-25  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
  76         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
  77
  78 2019-06-25  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
  81         check.
  82
  83 2019-06-25  Tom Tromey  <tom@tromey.com>
  84
  85         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
  86         type to void.
  87         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
  88         type to void.
  89         * tui/tui-source.c (tui_set_source_content): Update.
  90         * tui/tui-disasm.c (tui_set_disassem_content): Update.
  91
  92 2019-06-25  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-win.c (window_name_completer, tui_set_focus)
  95         (tui_all_windows_info): Use name method.
  96         * tui/tui-data.h (struct tui_gen_win_info)
  97         (struct tui_source_window, struct tui_disasm_window)
  98         (struct tui_data_window, struct tui_cmd_window) <name>: New
  99         method.
 100         (tui_win_name): Don't declare.
 101         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 102         (tui_win_name): Remove.
 103
 104 2019-06-25  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-winsource.h (tui_update_source_window)
 107         (tui_update_source_window_as_is): Change parameter type.
 108         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 109         to be a tui_source_window_base.
 110         (tui_update_source_window_as_is): Likewise.
 111         * tui/tui-win.c (make_visible_with_new_height): Update.
 112
 113 2019-06-25  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-winsource.c (tui_erase_source_content)
 116         (tui_show_source_content, tui_show_exec_info_content)
 117         (tui_erase_exec_info_content): Use refresh_window method.
 118         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 119         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 120         from tui_refresh_win.
 121         (tui_data_window::refresh_window): New method.
 122         (tui_win_info::refresh, tui_source_window_base::refresh)
 123         (tui_refresh_all): Use refresh_window method.
 124         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 125         method.
 126         * tui/tui-regs.c (tui_display_register): Call refresh_window
 127         method.
 128         * tui/tui-layout.c (show_source_disasm_command)
 129         (show_source_or_disasm_and_command): Call refresh_window method.
 130         * tui/tui-data.h (struct tui_gen_win_info)
 131         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 132         New method.
 133
 134 2019-06-25  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui.c (tui_rl_other_window, tui_enable)
 137         (tui_is_window_visible, tui_get_command_dimension): Update.
 138         * tui/tui-winsource.c (tui_update_source_window_as_is)
 139         (tui_clear_source_content, tui_erase_source_content)
 140         (tui_show_source_line, tui_source_window_base::refill)
 141         (tui_source_window_base::do_scroll_horizontal)
 142         (tui_source_window_base::set_is_exec_point_at)
 143         (tui_update_breakpoint_info, tui_set_exec_info_content)
 144         (tui_alloc_source_buffer, tui_line_is_displayed)
 145         (tui_addr_is_displayed): Update.
 146         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 147         (tui_check_and_display_highlight_if_needed)
 148         (tui_win_info::make_visible, tui_win_info::refresh)
 149         (tui_refresh_all): Update.
 150         * tui/tui-windata.c (tui_first_data_item_displayed)
 151         (tui_delete_data_content_windows, tui_erase_data_content)
 152         (tui_display_all_data, tui_data_window::refresh_all)
 153         (tui_check_data_values): Update.
 154         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 155         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 156         (tui_win_info::backward_scroll, tui_refresh_all_win)
 157         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 158         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 159         (tui_source_window_base::set_new_height)
 160         (tui_data_window::set_new_height)
 161         (make_invisible_and_set_new_height)
 162         (make_visible_with_new_height, new_height_ok)
 163         (parse_scrolling_args): Update.
 164         * tui/tui-stack.c (tui_show_frame_info): Update.
 165         * tui/tui-source.c (tui_set_source_content)
 166         (tui_set_source_content_nil, tui_source_is_displayed)
 167         (tui_source_window::do_scroll_vertical): Update.
 168         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 169         (tui_display_registers_from, tui_display_reg_element_at_line)
 170         (tui_check_register_values, tui_reg_command): Update.
 171         * tui/tui-layout.c (tui_default_win_height)
 172         (show_source_disasm_command, show_data, init_and_make_win)
 173         (show_source_or_disasm_and_command): Update.
 174         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 175         (tui_redisplay_readline, tui_mld_flush)
 176         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 177         (tui_getc): Update.
 178         * tui/tui-disasm.c (tui_set_disassem_content)
 179         (tui_disasm_window::do_scroll_vertical): Update.
 180         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 181         Now virtual.
 182         (struct tui_win_info): Derive from tui_gen_win_info.
 183         <~tui_win_info>: Mark as override.
 184         <generic>: Remove member.
 185         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 186         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 187         (~tui_data_window, ~tui_win_info)
 188         (tui_free_all_source_wins_content): Update.
 189         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 190
 191 2019-06-25  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-layout.c (init_and_make_win): Use new.
 194         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 195         destructor, initializers.
 196         (tui_alloc_generic_win_info): Don't declare.
 197         * tui/tui-data.c (_locator): Add argument to constructor.
 198         (source_win, disasm_win): New globals.
 199         (exec_info): Remove.
 200         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 201         Update.
 202         (tui_alloc_generic_win_info): Remove.
 203         (init_content_element): Use new.
 204         (tui_win_info::tui_win_info): Update.
 205         (free_content_elements) <case DATA_WIN>: Use delete.
 206
 207 2019-06-25  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 210         * tui/tui-windata.c (tui_first_data_item_displayed)
 211         (tui_delete_data_content_windows): Update.
 212         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 213         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 214         (tui_display_registers_from, tui_check_register_values): Update.
 215         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 216         pointer.
 217         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 218         window.
 219         (tui_free_data_content): Update.
 220         (free_content_elements) <case DATA_WIN>: Free the window.
 221
 222 2019-06-25  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 225         Update.
 226         * tui/tui-layout.c (make_command_window)
 227         (show_source_disasm_command, show_data, init_and_make_win)
 228         (show_source_or_disasm_and_command): Update.
 229         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 230         method.
 231         <can_highight, is_highlighted>: Now bool.
 232         (tui_set_win_highlight): Don't declare.
 233         * tui/tui-data.c (tui_set_win_highlight): Remove.
 234
 235 2019-06-25  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-wingeneral.c (make_visible): Remove check of window
 238         type.
 239
 240 2019-06-25  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-win.c (tui_win_info::max_height)
 243         (tui_cmd_window::max_height): New methods.
 244         (new_height_ok): Call max_height.
 245         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 246         <max_height>: New method.
 247
 248 2019-06-25  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-win.c (tui_source_window_base::set_new_height)
 251         (tui_data_window::set_new_height): New methods.
 252         (make_invisible_and_set_new_height): Call set_new_height method.
 253         * tui/tui-data.h (struct tui_win_info)
 254         (struct tui_source_window_base, struct tui_data_window)
 255         <set_new_height>: New method.
 256
 257 2019-06-25  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 260         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 261         tui_refresh_data_win.
 262         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 263         method.
 264         (tui_refresh_all_win): Call the refresh_all method.
 265         (tui_set_focus): Likewise.
 266         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 267         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 268         Likewise.
 269
 270 2019-06-25  Tom Tromey  <tom@tromey.com>
 271
 272         * tui/tui-winsource.h (tui_refill_source_window)
 273         (tui_set_is_exec_point_at): Don't declare.
 274         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 275         (tui_source_window_base::refill): Rename from
 276         tui_refill_source_window.
 277         (tui_source_window_base::do_scroll_horizontal): Update.
 278         (tui_source_window_base::set_is_exec_point_at): Rename from
 279         tui_set_is_exec_point_at.
 280         (tui_update_all_breakpoint_info): Update.
 281         * tui/tui-stack.c (tui_show_frame_info): Update.
 282         * tui/tui-layout.c (show_data): Add cast.
 283         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 284         * tui/tui-data.h (struct tui_source_window_base) <refill,
 285         set_is_exec_point_at>: New methods.
 286         (tui_source_windows, tui_add_to_source_windows): Update types.
 287         (tui_add_to_source_windows): Remove redundant declaration.
 288         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 289         (tui_source_windows): Change return type.
 290         (tui_clear_source_windows_detail): Update.
 291         (tui_add_to_source_windows): Change type of parameter.
 292         (tui_free_all_source_wins_content): Update.
 293
 294 2019-06-25  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-wingeneral.c (tui_win_info::refresh)
 297         (tui_source_window_base::refresh): New methods.
 298         (tui_refresh_all): Call the refresh method.
 299         * tui/tui-data.h (struct tui_win_info)
 300         (struct tui_source_window_base) <refresh>: New method.
 301
 302 2019-06-25  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui.h (tui_is_window_visible): Return bool.
 305         * tui/tui.c (tui_is_window_visible): Return bool.
 306         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 307         (tui_make_visible, tui_make_invisible)
 308         (tui_win_info::make_visible)
 309         (tui_source_window_base::make_visible, make_all_visible)
 310         (tui_make_all_visible, tui_make_all_invisible): Update.
 311         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 312         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 313         bool.
 314         (struct tui_win_info, struct tui_source_window_base)
 315         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 316         * tui/tui-data.c (tui_init_generic_part): Update.
 317
 318 2019-06-25  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 321         (tui_source_window_base::make_visible): New methods.
 322         (make_all_visible): Make method call.
 323         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 324         (struct tui_source_window_base, struct tui_cmd_window): Override
 325         make_visible.
 326         (tui_win_is_source_type): Don't declare.
 327         * tui/tui-data.c (tui_win_is_source_type): Remove.
 328
 329 2019-06-25  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 332         NULL check.
 333
 334 2019-06-25  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 337         Inline constructor.  Add initializers for members.
 338         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 339         constructors; now inline in class.
 340
 341 2019-06-25  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-regs.c (tui_show_registers): Update.
 344         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 345         bool.
 346         * tui/tui-data.c (tui_data_window::clear_detail)
 347         (tui_data_window): Update.
 348
 349 2019-06-25  Tom Tromey  <tom@tromey.com>
 350
 351         * tui/tui-windata.c (tui_display_all_data)
 352         (tui_display_data_from_line, tui_display_data_from)
 353         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 354         Update.
 355         * tui/tui-regs.c (tui_last_regs_line_no)
 356         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 357         (tui_show_registers, tui_show_register_group)
 358         (tui_display_registers_from, tui_display_reg_element_at_line)
 359         (tui_display_registers_from_line, tui_check_register_values)
 360         (tui_reg_next, tui_reg_prev): Update.
 361         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 362         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 363         tui_data_window.
 364         (struct tui_win_info) <detail>: Remove.  Add new fields from
 365         tui_data_info.
 366         (TUI_DATA_WIN): Add cast.
 367         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 368         (~tui_data_window): Simplify.
 369
 370 2019-06-25  Tom Tromey  <tom@tromey.com>
 371
 372         * tui/tui-layout.c (show_source_disasm_command)
 373         (show_source_or_disasm_and_command): Update.
 374         * tui/tui-io.c (update_cmdwin_start_line)
 375         (tui_redisplay_readline): Update.
 376         * tui/tui-data.h (struct tui_command_info): Remove.
 377         (struct tui_win_info) <detail>: Remove command_info member.
 378         (struct tui_data_window) <start_line>: New member, from
 379         tui_command_info.
 380         (TUI_CMD_WIN): Add casts.
 381
 382 2019-06-25  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-winsource.c (tui_update_source_window)
 385         (tui_refill_source_window)
 386         (tui_source_window_base::do_scroll_horizontal)
 387         (tui_update_breakpoint_info, tui_set_exec_info_content)
 388         (tui_show_exec_info_content, tui_erase_exec_info_content)
 389         (tui_clear_exec_info_content): Update.
 390         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 391         Update.
 392         * tui/tui-win.c (make_invisible_and_set_new_height)
 393         (make_visible_with_new_height): Update.
 394         * tui/tui-source.c (tui_set_source_content)
 395         (tui_show_symtab_source): Update.
 396         * tui/tui-layout.c (extract_display_start_addr)
 397         (show_source_disasm_command, show_data)
 398         (make_source_or_disasm_window)
 399         (show_source_or_disasm_and_command): Update.
 400         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 401         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 402         "gdbarch".
 403         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 404         to tui_source_window_base.
 405         (struct tui_win_info) <detail>: Remove source_info member.
 406         (struct tui_source_window_base) <has_locator>: Inline.
 407         Move contents from tui_source_info; rename has_locator member to
 408         m_has_locator.
 409         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 410         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 411         header file.
 412         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 413         Simplify.
 414         (tui_free_all_source_wins_content): Cast to
 415         tui_source_window_base.
 416
 417 2019-06-25  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-win.c (make_invisible_and_set_new_height)
 420         (make_visible_with_new_height): Call has_locator method.
 421         * tui/tui-layout.c (show_source_disasm_command, show_data)
 422         (show_source_or_disasm_and_command): Update for bool change.
 423         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 424         (tui_win_info) <has_locator>: New method.
 425         (struct tui_source_window_base) <has_locator>: New method.
 426         (tui_win_has_locator): Don't declare.
 427         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 428         from tui_win_has_locator.
 429         (tui_source_window_base): Use false, not FALSE.
 430
 431 2019-06-25  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 434         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 435         clear_detail method directly.
 436         (tui_clear_win_detail): Remove.
 437
 438 2019-06-25  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 441         "this", not TUI_DISASM_WIN.
 442
 443 2019-06-25  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 446         declare.
 447         * tui/tui-winsource.c
 448         (tui_source_window_base::do_scroll_horizontal): Rename from
 449         tui_horizontal_source_scroll.
 450         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 451         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 452         from tui_vertical_data_scroll.
 453         * tui/tui-win.h (tui_scroll): Don't declare.
 454         * tui/tui-win.c (tui_win_info::forward_scroll)
 455         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 456         (tui_win_info::right_scroll): Rename and update.
 457         (tui_scroll_forward_command, tui_scroll_backward_command)
 458         (tui_scroll_left_command, tui_scroll_right_command): Update.
 459         (tui_scroll): Remove.
 460         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 461         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 462         from tui_vertical_source_scroll.
 463         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 464         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 465         from tui_vertical_disassem_scroll.
 466         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 467         do_scroll_horizontal>: New methods.
 468         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 469         Likewise.
 470         (struct tui_source_window_base): Add do_scroll_horizontal.
 471         (struct tui_source_window, struct tui_disasm_window): Add
 472         do_scroll_vertical.
 473         (struct tui_data_window, struct tui_cmd_window): Add
 474         do_scroll_horizontal and do_scroll_vertical.
 475         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 476
 477 2019-06-25  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-data.h (struct tui_source_window_base): New struct.
 480         (struct tui_source_window): Derive from tui_source_window_base.
 481         (struct tui_disasm_window): New struct.
 482         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 483         from tui_source_window::clear_detail.
 484         (tui_source_window_base): Rename from tui_source_window.
 485         (~tui_source_window_base): Rename from ~tui_source_window.
 486         (tui_alloc_win_info): Create a tui_disasm_window.
 487
 488 2019-06-25  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-data.h (struct tui_source_window)
 491         (struct tui_data_window): Declare destructors.
 492         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 493         destructors.
 494         (tui_win_info): Simplify.
 495
 496 2019-06-25  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-winsource.c (tui_display_main)
 499         (tui_update_source_windows_with_addr)
 500         (tui_update_all_breakpoint_info): Update.
 501         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 502         (new_height_ok, parse_scrolling_args): Update.
 503         * tui/tui-stack.c (tui_show_frame_info): Update.
 504         * tui/tui-data.h (struct tui_list): Remove.
 505         (tui_source_windows): Return a reference to a std::vector.
 506         * tui/tui-data.c (source_windows): Now a std::vector.
 507         (tui_source_windows): Change return type.
 508         (tui_clear_source_windows): Rewrite.
 509         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 510         (tui_free_all_source_wins_content): Rewrite.
 511
 512 2019-06-25  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 515         (struct tui_data_window, struct tui_cmd_window): Declare
 516         clear_detail method.
 517         * tui/tui-data.c (tui_source_window::clear_detail)
 518         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 519         methods.
 520         (tui_clear_win_detail): Simplify.
 521
 522 2019-06-25  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-layout.c (make_source_window, make_disasm_window)
 525         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 526         Return the new window.
 527         (show_source_disasm_command, show_data)
 528         (show_source_or_disasm_and_command): Update.
 529
 530 2019-06-25  Tom Tromey  <tom@tromey.com>
 531
 532         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 533         parameter.  Return the new window.
 534         (show_source_disasm_command): Update and remove NULL check.
 535         (show_source_or_disasm_and_command): Update.
 536
 537 2019-06-25  Tom Tromey  <tom@tromey.com>
 538
 539         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 540
 541 2019-06-25  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-data.h (struct tui_win_info): Make constructor
 544         protected.  Make destructor virtual.  Add initializers.
 545         (tui_source_window, tui_data_window, tui_cmd_window): New
 546         classes.
 547         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 548         constructor.  Add "type" parameter.
 549         (tui_source_window, tui_data_window, tui_cmd_window): New
 550         constructors.
 551         (tui_alloc_win_info): Instantiate the appropriate subclass.
 552
 553 2019-06-25  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-win.c (tui_resize_all): Use delete.
 556         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 557         destructor.
 558         (tui_free_window): Don't declare.
 559         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 560         Update.
 561
 562 2019-06-25  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-data.h (struct tui_win_info): Add constructor.
 565         * tui/tui-data.c (tui_alloc_win_info): Use new.
 566         (tui_free_window): Use delete.
 567
 568 2019-06-22  Tom Tromey  <tom@tromey.com>
 569
 570         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 571         declare.
 572         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 573
 574 2019-06-22  Tom Tromey  <tom@tromey.com>
 575
 576         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 577         declare.
 578         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 579
 580 2019-06-22  Tom de Vries  <tdevries@suse.de>
 581
 582         * dwarf2read.c (create_addrmap_from_aranges)
 583         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 584         instead of '%zu'.
 585
 586 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 587
 588         * dwarf2read.h (dwarf2_section_info_def): Remove.
 589         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 590         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 591         std::vector<dwarf2_section_info>.
 592         (struct dwo_file) <~dwo_file>: Remove.
 593         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 594         types field.
 595         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 596         (dwarf2_read_debug_names): Likewise.
 597         (create_debug_types_hash_table): Change parameter type to
 598         array_view, adjust code accordingly.
 599         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 600         (partial_die_info::fixup): Likewise.
 601         (determine_prefix): Likewise.
 602         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 603
 604 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 605
 606         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 607         gdb_bfd_ref_ptr.
 608         <~dwo_file>: Remove call to gdb_bfd_unref.
 609         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 610         gdb_bfd_ref_ptr::get.
 611
 612 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 613
 614         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 615         type to htab_up.
 616         * dwarf2read.c (struct dwo_file): Initialize fields.
 617         <~dwo_file>: New.
 618         (free_dwo_file): Remove, move content to ~dwo_file.
 619         (struct dwo_file_deleter): Remove.
 620         (dwo_file_up>: Remove custom deleter.
 621         (free_dwo_files): Remove.
 622         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 623         dwo_files.
 624         (process_skeletonless_type_units): Call unique_ptr::get.
 625         (allocate_dwo_file_hash_table): Add deleter to created hash
 626         table.  Change return type to htab_up.
 627         (lookup_dwo_file_slot): Don't memset dwo_file, call
 628         unique_ptr::get.
 629         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 630         (create_dwo_unit_in_dwp_v2): Likewise.
 631         (open_and_init_dwo_file): Likewise.
 632         (free_dwo_file_from_slot): Remove.
 633
 634 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 635
 636         * dwarf2read.h (struct dwarf2_section_info) <readin,
 637         is_virtual>: Change type to bool.
 638         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 639         true instead of 1.
 640
 641 2019-06-19  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-data.h (tui_init_content_element): Don't declare.
 644
 645 2019-06-19  Tom Tromey  <tom@tromey.com>
 646
 647         * tui/tui-data.h (tui_init_win_info): Don't declare.
 648
 649 2019-06-19  Tom de Vries  <tdevries@suse.de>
 650
 651         * dwarf2read.h (abstract_to_concrete): Change type to
 652         std::unordered_map<sect_offset, std::vector<sect_offset>,
 653         gdb::hash_enum<sect_offset>>.
 654
 655 2019-06-19  Tom Tromey  <tromey@adacore.com>
 656
 657         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 658         EVAL_AVOID_SIDE_EFFECTS specially.
 659
 660 2019-06-19  Tom Tromey  <tromey@adacore.com>
 661
 662         * source-cache.c (highlighter): New global.
 663         (source_cache::get_source_lines): Create a highlighter on demand.
 664
 665 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 666
 667         * defs.h (deprecated_interactive_hook): Delete declaration.
 668         * interps.c (clear_interpreter_hooks): Remove use of
 669         deprecated_interactive_hook.
 670         * top.c (deprecated_interactive_hook): Delete definition.
 671         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 672
 673 2019-06-18  Tom de Vries  <tdevries@suse.de>
 674
 675         PR gdb/24515
 676         * dwarf2read.h (abstract_to_concrete): Change type from
 677         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 678         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 679         * dwarf2read.c (read_variable): Update.
 680         (dwarf2_fetch_die_loc_sect_off): Update.
 681
 682 2019-06-17  Tom de Vries  <tdevries@suse.de>
 683
 684         PR gdb/24617
 685         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 686         accessing parent[parent_len - 1].
 687
 688 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 689
 690         PR gdb/24364
 691         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 692         call dtrace_process_dof with NULL dof.
 693
 694 2019-06-16  Tom de Vries  <tdevries@suse.de>
 695
 696         PR gdb/24445
 697         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 698
 699 2019-06-16  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 702         (make_all_visible): Use address of member.
 703
 704 2019-06-16  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 707         (tui_free_window, free_content, free_content_elements): Remove
 708         unnecessary cast.
 709         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 710         cast.
 711         * tui/tui-regs.c (tui_show_register_group)
 712         (tui_display_registers_from, tui_display_reg_element_at_line):
 713         Remove unnecessary cast.
 714
 715 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 716
 717         * linux-nat.c (normal_mask): Delete.
 718         (_initialize_linux_nat): Don't initialise normal_mask.
 719
 720 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 721
 722         PR gdb/24445
 723         * dwarf-index-write.h (write_psymtabs_to_index): Add
 724         dwz_basename parameter.
 725         * dwarf-index-write.c (write_gdbindex): Move file writing to
 726         write_gdbindex_1.  Change return type void.
 727         (assert_file_size): Move up, remove filename parameter.
 728         (write_gdbindex_1): New function.
 729         (write_debug_names): Change return type to void, call
 730         assert_file_size.
 731         (struct index_wip_file): New struct.
 732         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 733         file logic to index_wip_file.  Write index for dwz file if
 734         needed.
 735         (save_gdb_index_command): Pass basename of dwz file, if present.
 736         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 737         build-id of dwz file, if present.
 738         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 739         (dwarf2_get_dwz_file): Likewise.
 740         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 741         (dwarf2_get_dwz_file): Likewise.
 742
 743 2019-06-16  Tom Tromey  <tom@tromey.com>
 744
 745         * coffread.c (process_coff_symbol): Use xstrdup.
 746         * value.c (create_internalvar): Use xstrdup.
 747
 748 2019-06-16  Tom Tromey  <tom@tromey.com>
 749
 750         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 751         * breakpoint.c (stopin_command, stopat_command)
 752         (until_break_command, decode_location_default): Remove unnecessary
 753         cast.
 754         * utils.c (subset_compare): Remove unnecessary cast.
 755         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 756         cast.
 757         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 758         cast.
 759         * infcmd.c (path_command): Remove unnecessary cast.
 760         * coffread.c (decode_type): Remove unnecessary cast.
 761         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 762         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 763         * tui/tui-stack.c (tui_show_locator_content)
 764         (tui_show_frame_info): Remove unnecessary cast.
 765         * tui/tui-win.c (tui_scroll_forward_command)
 766         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 767         (parse_scrolling_args): Remove unnecessary cast.
 768         * tui/tui-data.c (init_win_info, tui_del_window)
 769         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 770         (free_content_elements): Remove unnecessary cast.
 771         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 772         unnecessary cast.
 773         * tui/tui-source.c (tui_set_source_content)
 774         (tui_vertical_source_scroll): Remove unnecessary cast.
 775         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 776         cast.
 777         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 778         * tui/tui-regs.c (tui_display_registers_from)
 779         (tui_display_register): Remove unnecessary cast.
 780         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 781         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 782         (make_visible): Remove unnecessary cast.
 783         * tui/tui-winsource.c (tui_erase_source_content)
 784         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 785         unnecessary cast.
 786         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 787         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 788         * stabsread.c (read_type, read_array_type, read_range_type):
 789         Remove unnecessary cast.
 790         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 791         (parse_symbol, parse_type, upgrade_type, parse_external)
 792         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 793         unnecessary cast.
 794         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 795
 796 2019-06-16  Tom Tromey  <tom@tromey.com>
 797
 798         * tui/tui-data.c (tui_alloc_generic_win_info)
 799         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 800         checks.
 801
 802 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 803             Andrew Burgess  <andrew.burgess@embecosm.com>
 804
 805         * f-typeprint.c (f_print_type): Don't return early for not
 806         associated or not allocated types.
 807         (f_type_print_varspec_suffix): Add print_rank parameter and print
 808         ranks of array types in case they dangling.
 809         (f_type_print_base): Add print_rank parameter.
 810
 811 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 812
 813         * NEWS: Mention new MI commands.
 814         * break-catch-throw.c (enum exception_event_kind): Move to
 815         breakpoint.h.
 816         (print_mention_exception_catchpoint): Output text as a single
 817         message.
 818         (catch_exception_command_1): Rename to...
 819         (catch_exception_event): ...this, make non-static, update header
 820         command, and change some parameter types.
 821         (catch_catch_command): Update for changes to
 822         catch_exception_command_1.
 823         (catch_throw_command): Likewise.
 824         (catch_rethrow_command): Likewise.
 825         * breakpoint.c (enum exception_event_kind): Delete.
 826         * breakpoint.h (enum exception_event_kind): Moved here from
 827         break-catch-throw.c.
 828         (catch_exception_event): Declare.
 829         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 830         (mi_cmd_catch_throw): New function.
 831         (mi_cmd_catch_rethrow): New function.
 832         (mi_cmd_catch_catch): New function.
 833         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 834         'catch-catch' entries.
 835         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 836         (mi_cmd_catch_rethrow): Declare.
 837         (mi_cmd_catch_catch): Declare.
 838
 839 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 840
 841         * annotate.c (annotate_source_line): Change return type to void,
 842         update implementation to match.
 843         * annotate.h (annotate_source_line): Change return type to void,
 844         update header comment.
 845         * stack.c (print_frame_info): Don't change what frame information
 846         is printed based on whether annotations are on or not.
 847
 848 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 849
 850         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 851         (annotate_source): Make static.
 852         (annotate_source_line): Moved from source.c and renamed from
 853         identify_source_line.  Update the return type.
 854         * annotate.h (annotate_source): Delete declaration.
 855         (annotate_source_line): Declaration moved from source.h, and
 856         renamed from identify_source_line.  Return type updated.
 857         * source.c (identify_source_line): Moved to annotate.c and renamed
 858         to annotate_source_line.
 859         (info_line_command): Remove check of annotation_level.
 860         * source.h (identify_source_line): Move declaration to annotate.h
 861         and rename to annotate_source_line.
 862         * stack.c: Add 'annotate.h' include.
 863         (print_frame_info): Remove check of annotation_level before
 864         calling annotate_source_line.
 865
 866 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 867
 868         * source-cache.c (source_cache::get_plain_source_lines): Use
 869         open_source_file_with_line_charpos instead of just
 870         open_source_file, remove call to find_source_lines.
 871         (source_cache::get_source_lines): Likewise.
 872         * source.c (find_source_lines): Make static.
 873         (get_filename_and_charpos): Renamed into...
 874         (open_source_file_with_line_charpos): ..this along with changes to
 875         return a scoped_fd, and some other minor clean ups.
 876         (identify_source_line): Use open_source_file_with_line_charpos.
 877         (search_command_helper): Use open_source_file_with_line_charpos
 878         instead of just open_source_file, remove call to
 879         find_source_lines.
 880         * source.h (open_source_file_with_line_charpos): Declare new
 881         function.
 882         (find_source_lines): Delete declaration.
 883
 884 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 885
 886         * source.c (get_filename_and_charpos): Remove fullname
 887         parameter.
 888         (identify_source_line): Update call to get_filename_and_charpos.
 889
 890 2019-06-14  Tom Tromey  <tromey@adacore.com>
 891
 892         PR gdb/24502:
 893         * ui-style.h (skip_ansi_escape): Update comment.
 894         * ui-file.h (class no_terminal_escape_file): New class.
 895         * ui-file.c (no_terminal_escape_file::write)
 896         (no_terminal_escape_file::puts): New methods.
 897         * cli/cli-logging.c (handle_redirections): Use
 898         no_terminal_escape_file.
 899
 900 2019-06-14  Tom Tromey  <tromey@adacore.com>
 901
 902         * NEWS: Move convenience variable news above Python news.
 903
 904 2019-06-14  Tom Tromey  <tom@tromey.com>
 905
 906         * gnulib: Move directory to top-level.
 907         * configure.ac: Don't configure gnulib.
 908         * configure: Rebuild.
 909         * common/common-defs.h: Use new path to gnulib.
 910         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 911         (GNULIB_H): Remove.
 912         (INCGNU): Look in new gnulib location.
 913         (HFILES_NO_SRCDIR): Remove gnulib files.
 914         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 915         (generated_files): Remove GNULIB_H.
 916         ($(LIBGNU), all-lib): Remove targets.
 917         (distclean): Don't mention GNULIB_BUILDDIR.
 918         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 919
 920 2019-06-14  Tom Tromey  <tromey@adacore.com>
 921
 922         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 923         Warn if symbol file does not provide any symbols.
 924
 925 2019-06-14  Tom Tromey  <tromey@adacore.com>
 926
 927         * source.c (find_and_open_source): Respect basenames_may_differ.
 928
 929 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 930
 931         * annotate.c (annotate_breakpoints_invalid): Make use of
 932         scoped_restore_terminal_state.
 933         (annotate_frames_invalid): Likewise.
 934
 935 2019-06-14  Tom Tromey  <tromey@adacore.com>
 936
 937         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 938         allow assignment to an internalvar.
 939
 940 2019-06-14  Tom Tromey  <tromey@adacore.com>
 941
 942         * ada-lex.l: Allow "_" in attribute names.
 943
 944 2019-06-14  Tom Tromey  <tromey@adacore.com>
 945
 946         PR gdb/24653:
 947         * regcache.c (registers_changed): Don't call alloca.
 948         * top.c (execute_command): Don't call alloca.
 949
 950 2019-06-13  Pedro Alves  <palves@redhat.com>
 951
 952         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 953         'expression'.  When parsing an expression, error out if there's
 954         junk after "unlimited".
 955         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 956         (do_set_command): Adjust calls to is_unlimited_literal.
 957
 958 2019-06-13  Pedro Alves  <palves@redhat.com>
 959
 960         * compile/compile.c (make_compile_options_def_group): Add braces
 961         around array_view initializer.
 962         * thread.c (make_thread_apply_all_options_def_group)
 963         (make_thread_apply_all_options_def_group): Likewise.
 964
 965 2019-06-13  Pedro Alves  <palves@redhat.com>
 966
 967         * NEWS (New commands): Mention "maint test-options
 968         require-delimiter", "maint test-options unknown-is-error", "maint
 969         test-options unknown-is-operand" and "maint show
 970         test-options-completion-result".
 971         (New command options, command completion): New section.
 972         (Completion improvements): New section.
 973         Mention that you can abbreviate "unlimited".
 974
 975 2019-06-13  Pedro Alves  <palves@redhat.com>
 976
 977         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 978         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 979         * unittests/cli-utils-selftests.c (test_parse_flags)
 980         (test_parse_flags_qcs): Delete.
 981         (test_cli_utils): Don't call deleted functions.
 982
 983 2019-06-13  Pedro Alves  <palves@redhat.com>
 984
 985         * thread.c: Include "cli/cli-option.h".
 986         (tp_array_compar_ascending): Global.
 987         (tp_array_compar): Delete function.
 988         (tp_array_compar_ascending, tp_array_compar_descending): New
 989         functions.
 990         (ascending_option_def, qcs_flag_option_def)
 991         (thr_qcs_flags_option_defs)
 992         (make_thread_apply_all_options_def_group)
 993         (make_thread_apply_options_def_group): New.
 994         (thread_apply_all_command): Use gdb::option::process_options.
 995         (thread_apply_command_completer)
 996         (thread_apply_all_command_completer): New.
 997         (thread_apply_command): Use gdb::option::process_options.
 998         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 999         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1000         to generate help text of "thread apply".  Adjust "taas"'s help.
1001         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1002         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1003
1004 2019-06-13  Pedro Alves  <palves@redhat.com>
1005
1006         * thread.c (thread_apply_command): Check for invalid TID with
1007         isdigit instead of !isalpha.
1008
1009 2019-06-13  Pedro Alves  <palves@redhat.com>
1010
1011         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1012         (validate_flags_qcs): New.
1013         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1014         (validate_flags_qcs): Declare.
1015         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1016         (make_frame_apply_options_def_group): New.
1017         (frame_apply_command_count): Process options with
1018         gdb::option::process_options.
1019         (frame_apply_completer): New.
1020         (frame_apply_level_completer, frame_apply_all_completer)
1021         (frame_apply_completer): New.
1022         (_initialize_stack): Update help of "frame apply", "frame apply
1023         level", "frame apply all" and "faas" to mention supported options
1024         and install command completers.
1025         * stack.h (frame_apply_all_completer): Declare.
1026         * thread.c: Include "stack.h".
1027         (tfaas_command): Add "--".
1028         (_initialize_thread): Update help "tfaas" to mention supported
1029         options and install command completer.
1030
1031 2019-06-13  Pedro Alves  <palves@redhat.com>
1032
1033         * completer.c (complete_nested_command_line): New.
1034         (gdb_completion_word_break_characters_throw): Add assertion.
1035         * completer.h (complete_nested_command_line): Declare.
1036
1037 2019-06-13  Pedro Alves  <palves@redhat.com>
1038
1039         * stack.c (parse_backtrace_qualifiers): New.
1040         (backtrace_command): Use it.
1041         (backtrace_command_completer): Complete on qualifiers.
1042
1043 2019-06-13  Pedro Alves  <palves@redhat.com>
1044
1045         * frame.c: Include "cli/cli-option.h.
1046         (user_set_backtrace_options): New.
1047         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1048         Delete.
1049         (get_prev_frame): Adjust.
1050         (boolean_option_def, uinteger_option_def)
1051         (set_backtrace_option_defs): New.
1052         (_initialize_frame): Adjust and use
1053         gdb::option::add_setshow_cmds_for_options to install "set
1054         backtrace past-main" and "set backtrace past-entry".
1055         * frame.h: Include "cli/cli-option.h".
1056         (struct frame_print_options): Forward declare.
1057         (print_frame_arguments_all, print_frame_arguments_scalars)
1058         (print_frame_arguments_none): Declare.
1059         (print_entry_values): Delete declaration.
1060         (struct frame_print_options, user_frame_print_options): New.
1061         (struct set_backtrace_options): New.
1062         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1063         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1064         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1065         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1066         (list_args_or_locals): Add frame_print_options parameter.
1067         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1068         * python/py-framefilter.c (enumerate_args): Pass down
1069         USER_FRAME_PRINT_OPTIONS.
1070         * stack.c: Include "cli/cli-option.h".
1071         (print_frame_arguments_all, print_frame_arguments_scalars)
1072         (print_frame_arguments_none): Declare.
1073         (print_raw_frame_arguments, print_entry_values): Delete.
1074         (user_frame_print_options): New.
1075         (boolean_option_def, enum_option_def, frame_print_option_defs):
1076         New.
1077         (struct backtrace_cmd_options): New.
1078         (bt_flag_option_def): New.
1079         (backtrace_command_option_defs): New.
1080         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1081         (print_frame_arg, read_frame_arg, print_frame_args)
1082         (print_frame_info, print_frame): Add frame_print_options parameter
1083         and use it.
1084         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1085         (backtrace_command_1): Add frame_print_options and
1086         backtrace_cmd_options parameters and use them.
1087         (make_backtrace_options_def_group): New.
1088         (backtrace_command): Process command options with
1089         gdb::option::process_options.
1090         (backtrace_command_completer): New.
1091         (_initialize_stack): Extend "backtrace"'s help to mention
1092         supported options.  Install completer for "backtrace".
1093         Install some settings commands with add_setshow_cmds_for_options.
1094
1095 2019-06-13  Pedro Alves  <palves@redhat.com>
1096
1097         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1098         and that "set/show print raw frame-arguments" are now deprecated.
1099
1100         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1101         command.
1102         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1103         * stack.c (_initialize_stack): Install "set/show print
1104         raw-frame-arguments", and deprecate "set/show print raw
1105         frame-arguments".
1106         * valprint.c (_initialize_valprint): Deprecate "set/show print
1107         raw".
1108
1109 2019-06-13  Pedro Alves  <palves@redhat.com>
1110
1111         * compile/compile.c (struct compile_options): New.
1112         (compile_flag_option_def, compile_command_option_defs)
1113         (make_compile_options_def_group): New.
1114         (compile_file_command): Handle options with
1115         gdb::option::process_options.
1116         (compile_file_command_completer): New function.
1117         (compile_code_command): Handle options with
1118         gdb::option::process_options.
1119         (compile_code_command_completer): New function.
1120         (_initialize_compiler): Install completers for "compile code" and
1121         "compile file".  Mention available options in "compile code" and
1122         "compile code"'s help.
1123         * completer.c (advance_to_completion_word): New, factored out from
1124         ...
1125         (advance_to_expression_complete_word_point): ... this.
1126         (advance_to_filename_complete_word_point): New.
1127         * completer.h (advance_to_filename_complete_word_point): New
1128         declaration.
1129
1130 2019-06-13  Pedro Alves  <palves@redhat.com>
1131
1132         * compile/compile.c: Include "cli/cli-option.h".
1133         (compile_print_value): Scope data pointer is now a
1134         value_print_options pointer; adjust.
1135         (compile_print_command): Process options.  Scope data pointer is
1136         now a value_print_options pointer; adjust.
1137         (_initialize_compile): Update "compile print"'s help to include
1138         supported options.  Install a completer for "compile print".
1139         * cp-valprint.c (show_vtblprint, show_objectprint)
1140         (show_static_field_print): Delete.
1141         (_initialize_cp_valprint): Don't install "set print
1142         static-members", "set print vtbl", "set print object" here.
1143         * printcmd.c: Include "cli/cli-option.h" and
1144         "common/gdb_optional.h".
1145         (print_command_parse_format): Rework to fill in a
1146         value_print_options instead of a format_data.
1147         (print_value): Change parameter type from format_data pointer to
1148         value_print_options reference.  Adjust.
1149         (print_command_1): Process options.  Adjust to pass down a
1150         value_print_options.
1151         (print_command_completer): New.
1152         (_initialize_printcmd): Install print_command_completer as
1153         handle_brkchars completer for the "print" command.  Update
1154         "print"'s help to include supported options.
1155         * valprint.c: Include "cli/cli-option.h".
1156         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1157         here from cp-valprint.c.
1158         (boolean_option_def, uinteger_option_def)
1159         (value_print_option_defs, make_value_print_options_def_group):
1160         New.  Use gdb::option::add_setshow_cmds_for_options to install
1161         "set print elements", "set print null-stop", "set print repeats",
1162         "set print pretty", "set print union", "set print array", "set
1163         print address", "set print symbol", "set print array-indexes".
1164         * valprint.h: Include <string> and "cli/cli-option.h".
1165         (make_value_print_options_def_group): Declare.
1166         (print_value): Change parameter type from format_data pointer to
1167         value_print_options reference.
1168         (print_command_completer): Declare.
1169
1170 2019-06-13  Pedro Alves  <palves@redhat.com>
1171
1172         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1173         (COMMON_SFILES): Add maint-test-settings.c.
1174         * cli/cli-decode.c (boolean_enums): New global, factored out from
1175         ...
1176         (add_setshow_boolean_cmd): ... here.
1177         * cli/cli-decode.h (boolean_enums): Declare.
1178         * cli/cli-option.c: New file.
1179         * cli/cli-option.h: New file.
1180         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1181         factored out from ...
1182         (parse_cli_boolean_value(const char *)): ... this.
1183         (is_unlimited_literal): Change parameter type to pointer to
1184         pointer.  Adjust and advance ARG pointer.
1185         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1186         (parse_cli_var_enum): New, factored out from ...
1187         (do_set_command): ... this.  Adjust.
1188         * cli/cli-setshow.h (parse_cli_boolean_value)
1189         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1190         (parse_cli_var_enum): Declare.
1191         * cli/cli-utils.c: Include "cli/cli-option.h".
1192         (get_ulongest): New.
1193         * cli/cli-utils.h (get_ulongest): Declare.
1194         (check_for_argument): New overloads.
1195         * maint-test-options.c: New file.
1196
1197 2019-06-13  Pedro Alves  <palves@redhat.com>
1198
1199         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1200         parse a range if "-" is at the end of the string.
1201
1202 2019-06-13  Pedro Alves  <palves@redhat.com>
1203
1204         * cli/cli-setshow.c (parse_auto_binary_operation)
1205         (parse_cli_boolean_value): Don't allow "o".
1206
1207 2019-06-13  Pedro Alves  <palves@redhat.com>
1208
1209         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1210         * NEWS: Mention maint test-settings KIND.
1211         * maint-test-settings.c: New file.
1212
1213 2019-06-13  Pedro Alves  <palves@redhat.com>
1214
1215         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1216         completer.
1217         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1218         "set" completers.
1219
1220 2019-06-13  Pedro Alves  <palves@redhat.com>
1221
1222         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1223         after item.
1224
1225 2019-06-13  Pedro Alves  <palves@redhat.com>
1226
1227         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1228
1229 2019-06-13  Pedro Alves <palves@redhat.com>
1230
1231         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1232         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1233         call.
1234         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1235         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1236         calls.
1237         (check_for_argument): Skip spaces after argument.
1238
1239 2019-06-13  Pedro Alves  <palves@redhat.com>
1240
1241         * thread.c (thread_apply_command): Adjust TID parsing.
1242         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1243         detected before end of string.
1244         (tid_is_in_list): Error out if LIST is invalid.
1245
1246 2019-06-13  Pedro Alves  <palves@redhat.com>
1247
1248         * completer.c (complete_line_internal_1): Rewind completion word
1249         point.
1250         (completion_tracker::advance_custom_word_point_by): Change
1251         parameter type to int.
1252         * completer.h (completion_tracker::advance_custom_word_point_by):
1253         Likewise.
1254
1255 2019-06-13  Pedro Alves  <palves@redhat.com>
1256
1257         * completer.c (advance_to_completion_word): Handle delimiters.
1258
1259 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1260
1261         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1262
1263 2019-06-11  Tom Tromey  <tom@tromey.com>
1264
1265         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1266         (xmalloc_failed): Move to alloc.c.
1267         * alloc.c: New file.
1268         * Makefile.in (COMMON_SFILES): Add alloc.c.
1269
1270 2019-06-11  Tom Tromey  <tom@tromey.com>
1271
1272         * nat/linux-waitpid.c: Don't include server.h.
1273         (linux_debug): Remove.
1274         (my_waitpid): Update.
1275
1276 2019-06-11  Tom Tromey  <tromey@adacore.com>
1277
1278         * infcall.c (_initialize_infcall): Remove trailing newline from
1279         help.
1280         * user-regs.c (_initialize_user_regs): Remove trailing newline
1281         from help.
1282         * typeprint.c (_initialize_typeprint): Remove trailing newline
1283         from help.
1284         * reverse.c (_initialize_reverse): Remove trailing newlines from
1285         help.
1286         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1287         from help.
1288         * language.c (add_set_language_command): Remove trailing newline
1289         from help.
1290         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1291         help.
1292         * disasm.c (_initialize_disasm): Remove trailing newline from
1293         help.
1294         * top.c (init_main): Remove trailing newline from help.
1295         * interps.c (_initialize_interpreter): Remove trailing newline
1296         from help.
1297         * btrace.c (_initialize_btrace): Remove trailing newlines from
1298         help.
1299         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1300         from help.
1301         * python/python.c (_initialize_python): Remove trailing newline
1302         from help.
1303         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1304         help.
1305         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1306         from help.  Reformat some text.
1307         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1308         from help.
1309         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1310         newline from help.
1311
1312 2019-06-11  Tom Tromey  <tromey@adacore.com>
1313
1314         * darwin-nat.c (darwin_decode_exception_message)
1315         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1316
1317 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * valops.c (value_slice): Check for not allocated or not
1320         associated values.
1321
1322 2019-06-10  Tom de Vries  <tdevries@suse.de>
1323
1324         PR gdb/24618
1325         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1326         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1327         invalid.
1328
1329 2019-06-10  Tom de Vries  <tdevries@suse.de>
1330
1331         PR gdb/24611
1332         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1333         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1334
1335 2019-06-10  Tom de Vries  <tdevries@suse.de>
1336
1337         PR symtab/24545
1338         * symtab.c (struct demangled_name_entry): Add language field.
1339         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1340         static minimal symbol".  Set and use language field.
1341
1342 2019-06-10  Tom Tromey  <tromey@adacore.com>
1343
1344         * ada-lang.c (_initialize_ada_language): Update help text.
1345
1346 2019-06-10  Tom Tromey  <tromey@adacore.com>
1347
1348         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1349         with a newline.
1350         * guile/guile.c (handle_boot_error): Don't end warning with a
1351         newline.
1352         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1353         warning with a newline.
1354         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1355         newline.
1356         (s12z_frame_cache): Likewise.
1357         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1358         a newline.
1359         * solib-svr4.c (disable_probes_interface): Don't end warning with
1360         a newline.
1361         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1362         newline.
1363         * python/python.c (do_finish_initialization): Don't end warning
1364         with a newline.
1365
1366 2019-06-10  Tom Tromey  <tom@tromey.com>
1367
1368         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1369         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1370         gdbpy_enter.
1371
1372 2019-06-10  Tom Tromey  <tromey@adacore.com>
1373
1374         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1375         data.
1376         (elf_new_init): Don't call stabsread_new_init.
1377         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1378         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1379         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1380
1381 2019-06-10  Tom de Vries  <tdevries@suse.de>
1382
1383         PR symtab/16264
1384         PR symtab/24517
1385         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1386
1387 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1388
1389         * source.c (find_and_open_source): Also rewrite relative file
1390         names.
1391
1392 2019-04-26  Amos Bird  <amosbird@gmail.com>
1393
1394         * annotate.c (annotate_thread_exited): Add "thread-exited"
1395         annotation.
1396
1397 2019-06-06  Tom Tromey  <tromey@adacore.com>
1398
1399         * maint.h (class scoped_command_stats): Use
1400         DISABLE_COPY_AND_ASSIGN.
1401         <print_time>: New method.
1402         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1403         print_time.
1404         (scoped_command_stats::print_time): New method.
1405
1406 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1407
1408         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1409         instructions of lengths 6 or 8 bytes.
1410
1411 2019-06-04  Pedro Alves  <palves@redhat.com>
1412
1413         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1414
1415         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1416         * breakpoint.c (condition_completer): Likewise.
1417         * cli/cli-dump.c (scan_expression): Likewise.
1418         * common/filestuff.c (mkdir_recursive): Likewise.
1419         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1420         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1421         (gdb_abspath): Likewise.
1422         * compile/compile-cplus-types.c
1423         (compile_cplus_instance::decl_name): Likewise.
1424         * completer.c (complete_explicit_location):
1425         (signal_completer, reg_or_group_completer_1): Likewise.
1426         * cp-support.c (cp_remove_params_if_any): Likewise.
1427         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1428         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1429         * infcmd.c (strip_bg_char): Likewise.
1430         * linespec.c (copy_token_string): Likewise.
1431         * mi/mi-main.c (output_cores): Likewise.
1432         * psymtab.c (psymtab_search_name):
1433         * symfile.c (test_set_ext_lang_command): Likewise.
1434         * target.c (target_fileio_read_stralloc): Likewise.
1435         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1436         * value.c (complete_internalvar): Likewise.
1437
1438 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1439
1440         Add objfile property to gdb.Type.
1441         * NEWS: Mention Python API addition.
1442         * python/py-type.c (typy_get_objfile): New method.
1443
1444 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1445
1446         * NEWS: Mention the new set|show style [title|highlight].
1447         Mention changes to "show style", "help" and "apropos".
1448
1449 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1450
1451         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1452         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1453         instead of print_help_for_command.
1454         (print_doc_of_command): New function.
1455         (help_list): Add 'apropos -v word' suggestion.
1456         (print_help_for_command): Style the command name using title style.
1457         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1458         (_initialize_cli_cmds): Describe -v in apropos_command help.
1459
1460 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1461
1462         * cli/cli-style.h (cli_style_option): Add name in constructor,
1463         add m_name class member, add constructor with intensity,
1464         add name class function.
1465         (cli_style_option::add_setshow_commands): Remove name argument.
1466         (highlight_style, title_style): New styles.
1467         * cli/cli-style.c (do_show): New function that shows a style
1468         characteristic styling the style name with itself.
1469         (set_style_name): New function.
1470         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1471         Update all callers according to the changes in cli/cli-style.h.
1472         * utils.h (fputs_highlighted): New function.
1473         * utils.c (fputs_highlighted): Likewise.
1474
1475 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1476
1477         * NEWS: Mention new pipe command and new convenience variables.
1478
1479 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1480
1481         * cli/cli-cmds.c (pipe_command): New function.
1482         (_initialize_cli_cmds): Call add_com for pipe_command.
1483         Define | as an alias for pipe.
1484         (exit_status_set_internal_vars): New function.
1485         (shell_escape): Call exit_status_set_internal_vars.
1486         cli/cli-decode.c (find_command_name_length): Recognize | as
1487         a single character command.
1488
1489 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1490
1491         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1492         top.c (execute_command_to_ui_file): New function, mostly a copy
1493         of execute_command_to_string.
1494         (execute_command_to_string): Implement by calling
1495         execute_command_to_ui_file.
1496
1497 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1498
1499         * top.h (saved_command_line): Remove declaration.
1500         * top.c (previous_saved_command_line, previous_repeat_arguments):
1501         New variables.
1502         (saved_command_line): Make static, define together with other
1503         'repeat variables'.
1504         (dont_repeat): Clear repeat_arguments.
1505         (repeat_previous, get_saved_command_line, save_command_line):
1506         New functions.
1507         (gdb_init): Initialize saved_command_line
1508         and previous_saved_command_line.
1509         * main.c (captured_main_1): Remove saved_command_line initialization.
1510         * event-top.c (handle_line_of_input): Update to use
1511         the new 'repeat' related functions instead of direct access to
1512         saved_command_line.
1513         * command.h (repeat_previous, get_saved_command_line,
1514         save_command_line): New declarations.
1515         (dont_repeat): Add comment.
1516
1517 2019-05-30  Tom Tromey  <tromey@adacore.com>
1518
1519         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1520         Fix comment.
1521         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1522
1523 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1524
1525         PR cli/24587
1526         * completer.c (complete): Initialize variable word.
1527
1528 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1529
1530         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1531         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1532         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1533         'body' is NULL to the outter 'if', protecting the '!is_define'
1534         situation as well.
1535
1536 2019-05-29  Tom Tromey  <tromey@adacore.com>
1537
1538         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1539         (dwarf_unknown): New function.
1540         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1541         (dwarf_type_encoding_name): Use dwarf_unknown.
1542
1543 2019-05-29  Tom Tromey  <tromey@adacore.com>
1544
1545         PR c++/20020:
1546         * cp-valprint.c (cp_print_value_fields): Call
1547         cp_print_static_field inside "try".
1548
1549 2019-05-29  Tom Tromey  <tromey@adacore.com>
1550
1551         * inflow.c (struct terminal_info): Add default operator=.
1552         * configure: Rebuild.
1553         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1554         -Wdeprecated-copy-dtor, -Wredundant-move.
1555
1556 2019-05-29  Tom Tromey  <tromey@adacore.com>
1557
1558         * NEWS: Add entry.
1559         * infcmd.c (print_return_value_1): Handle finish_print
1560         option.
1561         (show_print_finish): New function.
1562         (_initialize_infcmd): Add "set/show print finish" commands.
1563         * valprint.c (user_print_options): Initialize new member.
1564         * valprint.h (struct value_print_options) <finish_print>: New
1565         member.
1566
1567 2019-05-28  Tom Tromey  <tromey@adacore.com>
1568
1569         * ada-lang.c (ada_remove_Xbn_suffix)
1570         (find_old_style_renaming_symbol)
1571         (parse_old_style_renaming): Remove.
1572         (ada_find_renaming_symbol): Don't call
1573         find_old_style_renaming_symbol.
1574         (ada_is_renaming_symbol): Rename from
1575         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1576         bool.  Now static.
1577         (ada_read_var_value): Update and simplify.
1578         * ada-exp.y (write_var_or_type): Remove old code.
1579
1580 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1581
1582         * event-top.c: Remove include comment.
1583         * inflow.c (class scoped_ignore_sigttou): Move from here...
1584         * inflow.h (class scoped_ignore_sigttou): ...to here.
1585         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1586         * top.c:  Remove include comment.
1587
1588 2019-05-27  Tom Tromey  <tom@tromey.com>
1589
1590         * NEWS: Fix typo.
1591
1592 2019-05-22  Tom Tromey  <tromey@adacore.com>
1593
1594         * target.c (target_follow_exec): Constify parameter.
1595         * target-delegates.c: Rebuild.
1596         * remote.c (remote_target::follow_exec): Constify parameter.
1597         * infrun.c (follow_exec): Constify parameter.
1598         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1599         (target_follow_exec): Likewise.
1600
1601 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1602
1603         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1604         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1605
1606 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1607
1608         * NEWS: Add debugredirect and testsuite sections.
1609
1610 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1611
1612         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1613         target descriptions using exclusively floating point register name
1614         aliases.
1615
1616 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1617
1618         PR gdb/18644:
1619         * f-lang.c (build_fortran_types): Handle the case where
1620         gdbarch_floatformat_for_type returns a nullptr.
1621
1622 2019-05-21  Tom de Vries  <tdevries@suse.de>
1623
1624         PR cli/24587
1625         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1626
1627 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1628
1629         PR gdb/18644:
1630         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1631         16-byte floats.
1632         * i386-tdep.c (i386_floatformat_for_type): Use
1633         floatformats_ia64_quad for the 16-byte floating point component
1634         within a fortran 32-byte complex number.
1635
1636 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1637
1638         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1639         delete default constructor.
1640         (find_partial_die): Update to return const struct.
1641         (partial_die_parent_scope): Move variable declaration into scope
1642         of its use and change its type to auto.
1643         (guess_partial_die_structure_name): Likewise.
1644         (partial_die_info::fixup): Likewise.
1645
1646 2019-05-17  Tom Tromey  <tromey@adacore.com>
1647
1648         * source.c (find_and_open_source): Remove cast.
1649
1650 2019-05-17  Tom Tromey  <tromey@adacore.com>
1651
1652         * annotate.c (annotate_source): Make "filename" const.
1653         * annotate.h (annotate_source): Use const.
1654
1655 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1656
1657         * disasm.c (set_disassembler_options): Send errors to stderr.
1658
1659 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1660
1661         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1662         (cli_interp_base::set_logging): Check debug_redirect.
1663         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1664         * cli/cli-logging.c (debug_redirect): Add static variable.
1665         (pop_output_files): Add default param.
1666         (handle_redirections): Print debug setting.
1667         (show_logging_command): Likewise.
1668         (_initialize_cli_logging): Add debugredirect command.
1669         * interps.c (current_interp_set_logging): Add debug_redirect
1670         parameter.
1671         * interps.h (set_logging): Add debug_redirect parameter.
1672         (current_interp_set_logging): Likewise.
1673         * mi/mi-common.h: Likewise.
1674         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1675
1676 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1677             Tom Tromey  <tromey@adacore.com>
1678
1679         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1680         directly.
1681         * cli/cli-interp.h (make_logging_output): Remove declaration.
1682         * cli/cli-logging.c (make_logging_output): Remove function.
1683         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1684         directly.
1685         * ui-file.c (tee_file::tee_file): Remove bools.
1686         (tee_file::~tee_file): Remove deletes.
1687         * ui-file.h (tee_file): Remove bools.
1688
1689 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1690
1691         * mi/mi-cmds.h (mi_cmd_complete): New function.
1692         * mi/mi-main.c (mi_cmd_complete): Likewise.
1693         * mi/mi-cmds.c: Define new MI command -complete.
1694         * NEWS: Mention new -complete command.
1695
1696 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1697
1698         * completer.h (complete): New function.
1699         * completer.c (complete): Likewise.
1700         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1701         function defined in completer.h.
1702
1703 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1704
1705         * MAINTAINERS (Write After Approval): Add myself.
1706
1707 2019-05-17  Tom de Vries  <tdevries@suse.de>
1708
1709         PR gdb/24094
1710         * dwarf2read.c (struct cu_partial_die_info): New struct.
1711         (find_partial_die): Return cu_partial_die_info.
1712         (partial_die_parent_scope, guess_partial_die_structure_name)
1713         (partial_die_info::fixup): Handle new return type of find_partial_die.
1714
1715 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1716
1717         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1718         "std::string", simplifying the algorithm.
1719
1720 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1721
1722         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1723         (stap_static_probe_ops::get_probes): Likewise.
1724
1725 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1726
1727         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1728         '-')" and "else if".
1729         (stap_parse_single_operand): Join checks for
1730         "gdbarch_stap_parse_special_token_p" and
1731         "gdbarch_stap_parse_special_token" in the same "if" statement.
1732         Invert check when verifying for operation on register
1733         displacement.
1734
1735 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1736
1737         * stap-probe.c (stap_get_opcode): Update comment.
1738         (stap_get_expected_argument_type): Likewise.
1739         (handle_stap_probe): Likewise.
1740
1741 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1742
1743         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1744         return type to 'bool'.  Adjust comment.  Use 'bool' when
1745         appropriate.
1746         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1747         * stap-probe.c (stap_parse_argument_1): Likewise.
1748         (stap_is_operator): Likewise.
1749         (stap_is_generic_prefix): Likewise.
1750         (stap_is_register_prefix): Likewise.
1751         (stap_is_register_indirection_prefix): Likewise.
1752         (stap_is_integer_prefix): Likewise.
1753         (stap_generic_check_suffix): Likewise.
1754         (stap_check_integer_suffix): Likewise.
1755         (stap_check_register_suffix): Likewise.
1756         (stap_check_register_indirection_suffix): Likewise.
1757         (stap_parse_register_operand): Likewise.
1758         (stap_parse_single_operand): Likewise.
1759         (stap_parse_argument_1): Likewise.
1760         (stap_probe::get_argument_count): Likewise.
1761         (stap_is_operator): Likewise.
1762
1763 2019-05-16  Tom Tromey  <tromey@adacore.com>
1764
1765         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1766         keyword to foreach.
1767
1768 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1769
1770         * linux-thread-db.c (try_thread_db_load_1): Change return type
1771         to bool.
1772         (try_thread_db_load): Likewise.
1773         (try_thread_db_load_from_pdir_1): Likewise.
1774         (try_thread_db_load_from_pdir): Likewise.
1775         (try_thread_db_load_from_sdir): Likewise.
1776         (try_thread_db_load_from_dir): Likewise.
1777         (thread_db_load_search): Likewise.
1778         (has_libpthread): Likewise.
1779         (thread_db_load): Likewise.
1780
1781 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1782
1783         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1784         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1785         NULL, and complain/return if that's the case.
1786
1787 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1788
1789         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1790         (advance, posn, abstract_read_memory): New functions.
1791         [struct mem_read_abstraction]: New struct.
1792         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1793
1794 2019-05-14  Tom Tromey  <tromey@adacore.com>
1795
1796         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1797         value is not lval_memory.
1798
1799 2019-05-14  Tom Tromey  <tromey@adacore.com>
1800
1801         * solib.c (info_sharedlibrary_command): Style the file name.
1802
1803 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1804
1805         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1806         (aarch64_vnv_type): Likewise.
1807         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1808         * common/tdesc.c: Likewise.
1809         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1810         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1811         * features/aarch64-fpu.xml: Add ieee half view.
1812         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1813         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1814         * gdbtypes.h (struct builtin_type): Likewise.
1815         (struct objfile_type): Likewise.
1816
1817 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1818
1819         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1820         typo.
1821         * location.h (string_to_event_location): Likewise.
1822
1823 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1824
1825         GDB 8.3 released.
1826
1827 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1828
1829         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1830         New variable declaration.
1831         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1832         New variable.
1833         (print_one_breakpoint): Use ui_out::test_flags and new global
1834         variable to compute use_fixed_output.
1835         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1836         Remove.
1837         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1838         (mi_multi_location_breakpoint_output_fixed): Remove.
1839         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1840         new variable.
1841         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1842         fix_multi_location_breakpoint_output flag if version >= 3.
1843         * ui-out.h (enum ui_out_flag)
1844         <fix_multi_location_breakpoint_output>: New enumerator.
1845
1846 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1847
1848         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1849
1850 2019-05-10  Tom Tromey  <tromey@adacore.com>
1851
1852         * ada-lang.c (catch_ada_completer): New function.
1853         (_initialize_ada_language): Use it.
1854
1855 2019-05-10  Tom Tromey  <tromey@adacore.com>
1856
1857         * thread.c (print_thread_info): Make "requested_threads" const.
1858         * gdbthread.h (print_thread_info): Make "requested_threads"
1859         const.
1860         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1861         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1862
1863 2019-05-08  Tom Tromey  <tom@tromey.com>
1864
1865         * gdbtypes.c (objfile_type_data): Change type.
1866         (objfile_type, _initialize_gdbtypes): Update.
1867
1868 2019-05-08  Tom Tromey  <tom@tromey.com>
1869
1870         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1871         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1872         (_initialize_dwarf2_frame): Update.
1873
1874 2019-05-08  Tom Tromey  <tom@tromey.com>
1875
1876         * objc-lang.c (objc_objfile_data): Change type.
1877         (find_methods): Update.
1878         (_initialize_objc_lang): Remove.
1879
1880 2019-05-08  Tom Tromey  <tom@tromey.com>
1881
1882         * stabsread.c (rs6000_builtin_type_data): Change type.
1883         (rs6000_builtin_type, _initialize_stabsread): Update.
1884
1885 2019-05-08  Tom Tromey  <tom@tromey.com>
1886
1887         * mips-tdep.c (mips_pdr_data): Remove.
1888         (_initialize_mips_tdep): Update.
1889
1890 2019-05-08  Tom Tromey  <tom@tromey.com>
1891
1892         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1893         (hppa_init_objfile_priv_data, read_unwind_info)
1894         (find_unwind_entry, _initialize_hppa_tdep): Update.
1895
1896 2019-05-08  Tom Tromey  <tom@tromey.com>
1897
1898         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1899         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1900         on obstack.
1901         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1902
1903 2019-05-08  Tom Tromey  <tom@tromey.com>
1904
1905         * mdebugread.c (basic_type_data): Change type.
1906         (basic_type, _initialize_mdebugread): Update.
1907
1908 2019-05-08  Tom Tromey  <tom@tromey.com>
1909
1910         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1911
1912 2019-05-08  Tom Tromey  <tom@tromey.com>
1913
1914         * nto-tdep.c (nto_inferior_data_reg): Change type.
1915         (nto_inferior_data): Update.
1916         (nto_inferior_data_cleanup, nto_new_inferior_data)
1917         (_initialize_nto_tdep): Remove.
1918         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1919
1920 2019-05-08  Tom Tromey  <tom@tromey.com>
1921
1922         * ada-lang.c (struct ada_inferior_data): Add initializers.
1923         (ada_inferior_data): Change type.
1924         (ada_inferior_data_cleanup): Remove.
1925         (get_ada_inferior_data, ada_inferior_exit)
1926         (struct ada_pspace_data): Add initializers, destructor.
1927         (ada_pspace_data_handle): Change type.
1928         (get_ada_pspace_data): Update.
1929         (ada_pspace_data_cleanup): Remove.
1930
1931 2019-05-08  Tom Tromey  <tom@tromey.com>
1932
1933         * coffread.c (struct coff_symfile_info): Add initializers.
1934         (coff_objfile_data_key): Move lower.  Change type.
1935         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1936         Update.
1937         (coff_free_info): Remove.
1938
1939 2019-05-08  Tom Tromey  <tom@tromey.com>
1940
1941         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1942         (fbsd_pspace_data_handle): Move lower.  Change type.
1943         (get_fbsd_pspace_data): Update.
1944         (fbsd_pspace_data_cleanup): Remove.
1945         (_initialize_fbsd_tdep): Update.
1946
1947 2019-05-08  Tom Tromey  <tom@tromey.com>
1948
1949         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1950         (get_ada_tasks_pspace_data): Update.
1951         (ada_tasks_pspace_data_cleanup): Remove.
1952         (_initialize_tasks): Update.
1953         (ada_tasks_inferior_data_handle): Change type.
1954         (get_ada_tasks_inferior_data): Update.
1955         (ada_tasks_inferior_data_cleanup): Remove.
1956         (struct ada_tasks_pspace_data): Add initializers.
1957
1958 2019-05-08  Tom Tromey  <tom@tromey.com>
1959
1960         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1961         * symfile-debug.c (debug_sym_get_probes): Change type.
1962         * stap-probe.c (handle_stap_probe):
1963         (stap_static_probe_ops::get_probes): Change type.
1964         * probe.h (class static_probe_ops) <get_probes>: Change type.
1965         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1966         (parse_probes_in_pspace): Update.
1967         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1968         Update.
1969         (any_static_probe_ops::get_probes): Change type.
1970         * elfread.c (elfread_data): New typedef.
1971         (probe_key): Change type.
1972         (elf_get_probes): Likewise.  Update.
1973         (probe_key_free): Remove.
1974         (_initialize_elfread): Update.
1975         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1976         Change type.
1977         (dtrace_process_dof_probe, dtrace_process_dof)
1978         (dtrace_static_probe_ops::get_probe): Change type.
1979
1980 2019-05-08  Tom Tromey  <tom@tromey.com>
1981
1982         * xcoffread.c (struct xcoff_symfile_info): Rename from
1983         coff_symfile_info.  Add initializers.
1984         (xcoff_objfile_data_key): Move lower.  Change type.
1985         (XCOFF_DATA): Rewrite.
1986         (xcoff_free_info): Remove.
1987         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1988         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1989         (xcoff_initial_scan): Update.
1990
1991 2019-05-08  Tom Tromey  <tom@tromey.com>
1992
1993         * solib-svr4.c (struct svr4_info): Add initializers and
1994         destructor.
1995         <probes_table>: Now an htab_up.
1996         (solib_svr4_pspace_data): Change type.
1997         (free_probes_table): Simplify.
1998         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1999         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2000         (probes_table_remove_objfile_probes, register_solib_event_probe)
2001         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2002         (_initialize_svr4_solib): Update.
2003
2004 2019-05-08  Tom Tromey  <tom@tromey.com>
2005
2006         * remote.c (remote_pspace_data): Change type.
2007         (remote_pspace_data_cleanup): Remove.
2008         (get_remote_exec_file, set_pspace_remote_exec_file)
2009         (_initialize_remote): Update.
2010
2011 2019-05-08  Tom Tromey  <tom@tromey.com>
2012
2013         * breakpoint.c (breakpoint_objfile_key): Change type.
2014         (get_breakpoint_objfile_data): Update.
2015         (free_breakpoint_objfile_data): Remove.
2016         (_initialize_breakpoint): Update.
2017
2018 2019-05-08  Tom Tromey  <tom@tromey.com>
2019
2020         * linux-tdep.c (struct linux_info): Add initializers.
2021         (linux_inferior_data): Move.  Change type.
2022         (invalidate_linux_cache_inf): Update.
2023         (linux_inferior_data_cleanup): Remove.
2024         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2025
2026 2019-05-08  Tom Tromey  <tom@tromey.com>
2027
2028         * auxv.c (auxv_inferior_data): Move.  Change type.
2029         (auxv_inferior_data_cleanup): Remove.
2030         (invalidate_auxv_cache_inf): Rewrite.
2031         (get_auxv_inferior_data, _initialize_auxv): Update.
2032
2033 2019-05-08  Tom Tromey  <tom@tromey.com>
2034
2035         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2036         (symfile_debug_objfile_data_key): Change type.
2037         (symfile_debug_installed, debug_qf_has_symbols)
2038         (debug_qf_find_last_source_symtab)
2039         (debug_qf_forget_cached_source_info)
2040         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2041         (debug_qf_print_stats, debug_qf_dump)
2042         (debug_qf_expand_symtabs_for_function)
2043         (debug_qf_expand_all_symtabs)
2044         (debug_qf_expand_symtabs_with_fullname)
2045         (debug_qf_map_matching_symbols)
2046         (debug_qf_expand_symtabs_matching)
2047         (debug_qf_find_pc_sect_compunit_symtab)
2048         (debug_qf_map_symbol_filenames)
2049         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2050         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2051         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2052         (debug_sym_read_linetable, debug_sym_relocate): Update.
2053         (symfile_debug_free_objfile): Remove.
2054         (install_symfile_debug_logging, _initialize_symfile_debug):
2055         Update.
2056
2057 2019-05-08  Tom Tromey  <tom@tromey.com>
2058
2059         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2060         allocate_on_obstack.
2061         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2062         (get_dwarf2_per_objfile): Update.
2063         (set_dwarf2_per_objfile): Remove.
2064         (dwarf2_has_info, dwarf2_get_section_info): Update.
2065         (dwarf2_free_objfile): Remove.
2066         (_initialize_dwarf2_read): Update.
2067
2068 2019-05-08  Tom Tromey  <tom@tromey.com>
2069
2070         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2071         initializers.
2072         <unsupported_script_warning_printed,
2073         script_not_found_warning_printed>: Now bool.
2074         (auto_load_pspace_data): Change type.
2075         (~auto_load_pspace_info): Rename from
2076         auto_load_pspace_data_cleanup.
2077         (get_auto_load_pspace_data, init_loaded_scripts_info)
2078         (clear_section_scripts, maybe_print_unsupported_script_warning)
2079         (maybe_print_script_not_found_warning, _initialize_auto_load):
2080         Update.
2081
2082 2019-05-08  Tom Tromey  <tom@tromey.com>
2083
2084         * objfiles.c (objfile_pspace_info): Add destructor and
2085         initializers.
2086         (objfiles_pspace_data): Change type.
2087         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2088         (get_objfile_pspace_data): Update.
2089         (objfiles_bfd_data): Change type.
2090         (get_objfile_bfd_data): Update.
2091         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2092
2093 2019-05-08  Tom Tromey  <tom@tromey.com>
2094
2095         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2096         Change type.
2097         (get_catch_syscall_inferior_data): Update.
2098         (catch_syscall_inferior_data_cleanup): Remove.
2099         (_initialize_break_catch_syscall): Update.
2100
2101 2019-05-08  Tom Tromey  <tom@tromey.com>
2102
2103         * inflow.c (struct terminal_info): Add destructor and
2104         initializers.
2105         (inflow_inferior_data): Change type.
2106         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2107         (get_inflow_inferior_data, inflow_inferior_exit)
2108         (swap_terminal_info, _initialize_inflow): Update.
2109
2110 2019-05-08  Tom Tromey  <tom@tromey.com>
2111
2112         * target-dcache.c (target_dcache_cleanup): Remove.
2113         (target_dcache_aspace_key): Change type.
2114         (target_dcache_init_p, target_dcache_invalidate)
2115         (target_dcache_get, target_dcache_get_or_init)
2116         (_initialize_target_dcache): Update.
2117         * dcache.h (struct dcache_deleter): New.
2118
2119 2019-05-08  Tom Tromey  <tom@tromey.com>
2120
2121         * symtab.c (struct symbol_cache): Add destructor and
2122         initializers.
2123         (symbol_cache_key): Move.  Change type.
2124         (make_symbol_cache, free_symbol_cache): Remove.
2125         (get_symbol_cache): Update.
2126         (symbol_cache_cleanup): Remove.
2127         (ALL_PSPACES, symbol_cache_flush)
2128         (maintenance_print_symbol_cache)
2129         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2130         Update.
2131
2132 2019-05-08  Tom Tromey  <tom@tromey.com>
2133
2134         * symtab.c (struct main_info): Add destructor and initializers.
2135         (main_progspace_key): Move.  Change type.
2136         (get_main_info): Update.
2137         (main_info_cleanup): Remove.
2138         (_initialize_symtab): Update.
2139
2140 2019-05-08  Tom Tromey  <tom@tromey.com>
2141
2142         * registry.h (DECLARE_REGISTRY): Define the _key class.
2143
2144 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2145
2146         * NEWS: Merge two 'New commands' sections.
2147
2148 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2149
2150         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2151         parameter and use Ada language definition instead.
2152         (ada_val_print_ptr): Remove unused language parameter.
2153         (ada_val_print_num): Remove language parameter and use Ada language
2154         definition instead.
2155         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2156         parameter.
2157         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2158         parameter and use Ada language definition instead.
2159         (ada_val_print_1): Update all ada_val_print_xxx calls.
2160         Remove language parameter.
2161         (ada_val_print): Update ada_val_print_1 call.
2162
2163 2019-05-08  Tom Tromey  <tromey@adacore.com>
2164
2165         * remote.c (remote_hw_watchpoint_limit)
2166         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2167         Now static.
2168
2169 2019-05-08  Tom Tromey  <tromey@adacore.com>
2170
2171         * maint.c (_initialize_maint_cmds): Move initialization code to
2172         remote.c.
2173         (watchdog, show_watchdog): Move to remote.c.
2174         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2175         "watchdog" static.
2176         (_initialize_remote): Move initialization code from maint.c.
2177         * defs.h (watchdog): Don't declare.
2178
2179 2019-05-08  Tom Tromey  <tromey@adacore.com>
2180
2181         * tui/tui-interp.c: Include main.h.
2182         * interps.c: Include main.h.
2183         * main.h (interpreter_p): Declare.
2184         * defs.h (interpreter_p): Don't declare.
2185
2186 2019-05-08  Tom Tromey  <tromey@adacore.com>
2187
2188         * dwarf2loc.c: Include dwarf2read.h.
2189         * defs.h (read_unsigned_leb128): Don't declare.
2190         * dwarf2read.h (read_unsigned_leb128): Declare.
2191
2192 2019-05-08  Tom Tromey  <tromey@adacore.com>
2193
2194         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2195         method.
2196
2197 2019-05-08  Tom Tromey  <tromey@adacore.com>
2198
2199         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2200         when no wrap column is set.
2201
2202 2019-05-08  Tom Tromey  <tromey@adacore.com>
2203
2204         * c-lang.c (c_get_string): Handle non-C-style arrays.
2205
2206 2019-05-08  Tom Tromey  <tromey@adacore.com>
2207
2208         * typeprint.c (print_offset_data::update): Print the bit offset,
2209         not the number of bits remaining.
2210
2211 2019-05-08  Tom Tromey  <tromey@adacore.com>
2212
2213         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2214         padding at end of comment.
2215
2216 2019-05-08  Tom Tromey  <tromey@adacore.com>
2217
2218         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2219         Compare main types.
2220
2221 2019-05-06  Tom Tromey  <tom@tromey.com>
2222
2223         * common/scoped_mmap.c: Include common-defs.h.
2224         * common/scoped_mmap.h: Don't include config.h.
2225
2226 2019-05-04  Tom Tromey  <tom@tromey.com>
2227
2228         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2229         (struct aarch64_call_info): Add initializers.
2230         <si>: Now a std::vector.
2231         (pass_on_stack, aarch64_push_dummy_call): Update.
2232
2233 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2234             Tom Tromey  <tom@tromey.com>
2235
2236         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2237         (ppc_threads): Now a std::vector.  Now static.
2238         (hwdebug_find_thread_points_by_tid)
2239         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2240         Update.
2241
2242 2019-05-04  Tom Tromey  <tom@tromey.com>
2243
2244         * arc-tdep.c (arc_tdesc_init): Return bool.
2245
2246 2019-05-04  Tom Tromey  <tom@tromey.com>
2247
2248         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2249         Use gdb_assert_not_reached.
2250
2251 2019-05-04  Tom Tromey  <tom@tromey.com>
2252
2253         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2254         "false".
2255
2256 2019-05-04  Tom Tromey  <tom@tromey.com>
2257
2258         * arc-tdep.c (arc_tdesc_init): Use bool.
2259
2260 2019-05-04  Tom Tromey  <tom@tromey.com>
2261
2262         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2263
2264 2019-05-04  Tom Tromey  <tom@tromey.com>
2265
2266         * cli/cli-cmds.c (valid_command_p): Return bool.
2267
2268 2019-05-04  Tom Tromey  <tom@tromey.com>
2269
2270         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2271         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2272
2273 2019-05-04  Raul Tambre  <raul@tambre.ee>
2274
2275         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2276         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2277         operator for comparison.
2278
2279 2019-05-04  Tom Tromey  <tom@tromey.com>
2280
2281         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2282         (lookup_partial_symbol, print_partial_symbols)
2283         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2284         (psymbol_compare): Update.
2285         (add_psymbol_to_bcache): Clear the entire psymbol.
2286         (maintenance_check_psymtabs): Update.
2287         * psympriv.h (struct partial_symbol): Don't derive from
2288         general_symbol_info.
2289         <obj_section, unrelocated_address, address,
2290         set_unrelocated_address>: Update.
2291         <ginfo>: New member.
2292         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2293         (debug_names::write_psymbols): Update.
2294
2295 2019-05-04  Tom de Vries  <tdevries@suse.de>
2296
2297         * contrib/cc-with-tweaks.sh: Support -n arg.
2298
2299 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2300
2301         * corelow.c (core_target::detach): Ensure frame cache and
2302         register caches are cleared.
2303         inferior.c (exit_inferior_1): Likewise.
2304
2305 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2306             Tom Tromey  <tom@tromey.com>
2307
2308         * dictionary.c (collate_pending_symbols_by_language): Remove
2309         "struct" from foreach.
2310         * symtab.c (lookup_global_symbol_from_objfile)
2311         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2312         foreach.
2313         * ser-tcp.c (net_open): Remove "struct" from foreach.
2314         * objfiles.c (objfile_relocate, objfile_rebase)
2315         (objfile_has_symbols): Remove "struct" from foreach.
2316         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2317         from foreach.
2318         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2319         foreach.
2320         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2321         "struct" from foreach.
2322         * ada-lang.c (create_excep_cond_exprs)
2323         (ada_exception_catchpoint_cond_string): Remove "struct" from
2324         foreach.
2325
2326 2019-05-03  Tom Tromey  <tromey@adacore.com>
2327
2328         * ada-exp.y (convert_char_literal): Check suffix of each
2329         enumerator.
2330
2331 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2332
2333         PR ada/21406:
2334         * ada-exp.y (yywrap): Don't define.
2335         * ada-lex.l (%option): Add noyywrap
2336         (yywrap): Remove.
2337
2338 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2339
2340         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2341         _WIN32_WINNT to the XP level, unless already defined to a higher
2342         level.
2343
2344         * unittests/parse-connection-spec-selftests.c:
2345         * ser-tcp.c:
2346         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2347         override.
2348
2349         * symfile.c (find_separate_debug_file): Remove colon from the
2350         drive spec of DOS/Windows file names of the target, so that the
2351         file name produced from DEBUGDIR and the target's directory will
2352         be valid on DOS/Windows systems.
2353
2354 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2355
2356         * rust-lang.c (val_print_struct): Handle printing structures
2357         containing strings.
2358
2359 2019-05-02  Tom Tromey  <tromey@adacore.com>
2360
2361         * valarith.c (_initialize_valarith): Remove.
2362
2363 2019-05-01  Tom Tromey  <tromey@adacore.com>
2364
2365         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2366         bitfields.
2367
2368 2019-05-01  Tom Tromey  <tromey@adacore.com>
2369
2370         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2371         for big-endian copies.
2372
2373 2019-04-30  Ali Tamur  <tamur@google.com>
2374         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2375         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2376         (read_3_bytes): New function.
2377
2378 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2379
2380         * windows-nat.c (main_thread_id): Delete.
2381         (handle_output_debug_string): Replace main_thread_id by
2382         current_event.dwThreadId.
2383         (fake_create_process): Likewise.
2384         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2385         Do not set main_thread_id.
2386         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2387         current_event.dwThreadId.
2388         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2389
2390 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2391
2392         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2393         Use current_event.dwThreadId instead of main_thread_id.
2394
2395 2019-04-30  Tom Tromey  <tromey@adacore.com>
2396
2397         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2398         (create_excep_cond_exprs): Iterate over program spaces.
2399         (ada_exception_catchpoint_cond_string): Examine all minimal
2400         symbols for exception types.
2401
2402 2019-04-30  Tom Tromey  <tromey@adacore.com>
2403
2404         PR c++/24470:
2405         * dwarf2read.c (process_structure_scope): Handle case where type
2406         has template parameters but no symbol was created.
2407
2408 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2409             Chris January  <chris.january@arm.com>
2410
2411         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2412         qualifier.
2413         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2414
2415 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2416
2417         * f-typeprint.c (f_print_type): Update rules for printing
2418         whitespace.
2419         (f_type_print_varspec_suffix): Likewise.
2420
2421 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2422             Chris January  <chris.january@arm.com>
2423
2424         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2425         function arguments.
2426
2427 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2428
2429         * f-lang.c (build_fortran_types): Change name of void type to
2430         lower case.
2431         * f-typeprint.c (f_type_print_base): Print the name of the void
2432         type, rather than a fixed string.
2433         * f-valprint.c (f_decorations): Use lower case void string.
2434
2435 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2436             Chris January  <chris.january@arm.com>
2437
2438         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2439         types for Fortran.
2440
2441 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2442             Chris January  <chris.january@arm.com>
2443             David Lecomber  <david.lecomber@arm.com>
2444
2445         * f-exp.y (BINOP_INTRINSIC): New token.
2446         (exp): New parser rule handling BINOP_INTRINSIC.
2447         (f77_keywords): Add new builtin procedures.
2448         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2449         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2450         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2451         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2452         (print_unop_subexp_f): New function.
2453         (print_binop_subexp_f): New function.
2454         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2455         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2456         (dump_subexp_body_f): Likewise.
2457         (operator_check_f): Likewise.
2458         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2459         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2460
2461 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2462
2463         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2464         UNOP_KIND.
2465         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2466         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2467         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2468         (operator_length_f): New fuction.
2469         (print_subexp_f): New function.
2470         (op_name_f): New function.
2471         (dump_subexp_body_f): New function.
2472         (operator_check_f): New function.
2473         (exp_descriptor_f): Replace standard expression handling functions
2474         with new functions.
2475         * gdb/fortran-operator.def: New file.
2476         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2477         * gdb/std-operator.def: Remove UNOP_KIND.
2478
2479 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2480
2481         * std-operator.def: Remove unbalanced, stray double quote
2482         character.
2483
2484 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2485             Chris January  <chris.january@arm.com>
2486             Daniel Everett  <daniel.everett@arm.com>
2487             Nick Forrington  <nick.forrington@arm.com>
2488             Richard Bunt  <richard.bunt@arm.com>
2489
2490         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2491         of depth when printing anonymous structs or unions.
2492         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2493         Don't print either the top-level value, or the children if the
2494         max-depth is exceeded.
2495         (ppscm_print_children): When printing the key of a map, allow one
2496         extra level of depth.
2497         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2498         print either the top-level value, or the children if the max-depth
2499         is exceeded.
2500         (print_children): When printing the key of a map, allow one extra
2501         level of depth.
2502         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2503         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2504         (user_print_options): Initialise max_depth field.
2505         (val_print_scalar_or_string_type_p): New function.
2506         (val_print): Check to see if the max depth has been reached.
2507         (val_print_check_max_depth): Define new function.
2508         (show_print_max_depth): New function.
2509         (_initialize_valprint): Add 'print max-depth' option.
2510         * valprint.h (struct value_print_options) <max_depth>: New field.
2511         (val_print_check_max_depth): Declare new function.
2512         * NEWS: Document new feature.
2513
2514 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * ada-lang.c (ada_language_defn): Initialise new field.
2517         * c-lang.c (c_is_string_type_p): New function.
2518         (c_language_defn): Initialise new field.
2519         (cplus_language_defn): Initialise new field.
2520         (asm_language_defn): Initialise new field.
2521         (minimal_language_defn): Initialise new field.
2522         * c-lang.h (c_is_string_type_p): Declare new function.
2523         * d-lang.c (d_language_defn): Initialise new field.
2524         * f-lang.c (f_is_string_type_p): New function.
2525         (f_language_defn): Initialise new field.
2526         * go-lang.c (go_is_string_type_p): New function.
2527         (go_language_defn): Initialise new field.
2528         * language.c (default_is_string_type_p): New function.
2529         (unknown_language_defn): Initialise new field.
2530         (auto_language_defn): Initialise new field.
2531         * language.h (struct language_defn) <la_is_string_type_p>: New
2532         member variable.
2533         (default_is_string_type_p): Declare new function.
2534         * m2-lang.c (m2_language_defn): Initialise new field.
2535         * objc-lang.c (objc_language_defn): Initialise new field.
2536         * opencl-lang.c (opencl_language_defn): Initialise new field.
2537         * p-lang.c (pascal_is_string_type_p): New function.
2538         (pascal_language_defn): Initialise new field.
2539         * rust-lang.c (rust_is_string_type_p): New function.
2540         (rust_language_defn): Initialise new field.
2541
2542 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2543
2544         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2545         New field.
2546         * ada-lang.c (ada_language_defn): Initialise new field.
2547         * c-lang.c (c_language_defn): Likewise.
2548         (cplus_language_defn): Likewise.
2549         (asm_language_defn): Likewise.
2550         (minimal_language_defn): Likewise.
2551         * d-lang.c (d_language_defn): Likewise.
2552         * f-lang.c (f_language_defn): Likewise.
2553         * go-lang.c (go_language_defn): Likewise.
2554         * language.c (unknown_language_defn): Likewise.
2555         (auto_language_defn): Likewise.
2556         * m2-lang.c (m2_language_defn): Likewise.
2557         * objc-lang.c (objc_language_defn): Likewise.
2558         * opencl-lang.c (opencl_language_defn): Likewise.
2559         * p-lang.c (pascal_language_defn): Likewise.
2560         * rust-lang.c (rust_language_defn): Likewise.
2561
2562 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2563
2564         * ada-lang.c (ada_is_character_type): Change return type to bool.
2565         (ada_is_string_type): Likewise.
2566         * ada-lang.h (ada_is_character_type): Update declaration
2567         (ada_is_string_type): Likewise.
2568
2569 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2570
2571         Support style in 'frame|thread apply'
2572
2573         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2574         * record.c (record_start, record_stop): Update callers of
2575         execute_command_to_string with false.
2576         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2577         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2578         methods.
2579         (class string_file): New constructor with term_out parameter.
2580         Override methods term_out and can_emit_style_escape.  New member
2581         term_out.
2582         (class stdio_file): Override can_emit_style_escape.
2583         (class tee_file): Override term_out and can_emit_style_escape.
2584         * utils.h (can_emit_style_escape): Remove.
2585         * utils.c (can_emit_style_escape): Likewise.
2586         Update all callers of can_emit_style_escape (SOMESTREAM) to
2587         SOMESTREAM->can_emit_style_escape.
2588         * source-cache.c (source_cache::get_source_lines): Likewise.
2589         * stack.c (frame_apply_command_count): Call execute_command_to_string
2590         passing the term_out characteristic of the current gdb_stdout.
2591         * thread.c (thr_try_catch_cmd): Likewise.
2592         * top.c (execute_command_to_string): pass term_out parameter
2593         to construct the string_file for the command output.
2594         * ui-file.c (term_cli_styling): New function (most code moved
2595         from utils.c can_emit_style_escape).
2596         (string_file::string_file, string_file::can_emit_style_escape,
2597         stdio_file::can_emit_style_escape, tee_file::term_out,
2598         tee_file::can_emit_style_escape): New functions.
2599
2600 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2601
2602         * NEWS: Mention the new set|show may-call-functions.
2603         * infcall.c (may_call_functions_p): New variable.
2604         (show_may_call_functions_p): New function.
2605         (call_function_by_hand_dummy): Throws an error if not
2606         may-call-functions.
2607         (_initialize_infcall): Call add_setshow_boolean_cmd for
2608         may-call-functions.
2609
2610 2019-04-25  Keith Seitz  <keiths@redhat.com>
2611
2612         PR c++/24367
2613         * cp-support.c (inspect_type): Don't attempt substitutions
2614         of symbol with the same name.
2615
2616 2019-04-25  Tom Tromey  <tromey@adacore.com>
2617
2618         PR gdb/24475:
2619         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2620         static.
2621
2622 2019-04-25  Tom Tromey  <tromey@adacore.com>
2623
2624         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2625         rvalue reference.
2626         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2627         (gdb_xml_parser::parse): Use std::move.
2628         * python/python-internal.h (gdbpy_convert_exception): Take a const
2629         reference.
2630         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2631         std::move.
2632         * python/py-utils.c (gdbpy_convert_exception): Take a const
2633         reference.
2634         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2635         Use std::move.
2636         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2637         Use std::move.
2638         * mi/mi-main.c (mi_print_exception): Take a const reference.
2639         * main.c (handle_command_errors): Take a const reference.
2640         * linespec.c (parse_linespec): Use std::move.
2641         * infcall.c (run_inferior_call): Use std::move.
2642         (call_function_by_hand_dummy): Use std::move.
2643         * exec.c (try_open_exec_file): Use std::move.
2644         * exceptions.h (exception_print, exception_fprintf)
2645         (exception_print_same): Update.
2646         * exceptions.c (print_exception, exception_print)
2647         (exception_fprintf, exception_print_same): Change parameters to
2648         const reference.
2649         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2650         * common/new-op.c: Use std::move.
2651         * common/common-exceptions.h (struct gdb_exception): Add move
2652         constructor.
2653         (struct gdb_exception_error, struct gdb_exception_quit, struct
2654         gdb_quit_bad_alloc): Change constructor to move constructor.
2655         (throw_exception): Change parameter to rvalue reference.
2656         * common/common-exceptions.c (throw_exception): Take rvalue
2657         reference.
2658         * cli/cli-interp.c (safe_execute_command): Use std::move.
2659         * breakpoint.c (insert_bp_location, location_to_sals): Use
2660         std::move.
2661
2662 2019-04-25  Tom Tromey  <tromey@adacore.com>
2663
2664         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2665         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2666         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2667         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2668         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2669         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2670         guile/scm-value.c: Use unpack.
2671         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2672         gdbscm_gdb_exception.
2673         (gdbscm_throw_gdb_exception): Likewise.
2674         (struct gdbscm_gdb_exception): New.
2675         (unpack): New function.
2676         (gdbscm_wrap): Use unpack.
2677
2678 2019-04-25  Tom Tromey  <tromey@adacore.com>
2679
2680         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2681         (gdb_rl_callback_handler): Use std::move.
2682         * common/common-exceptions.h (struct gdb_exception): Add move
2683         assignment operator.
2684         (throw_exception_sjlj): Change "exception" to const reference.
2685         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2686         (throw_exception_sjlj): Change "exception" to const reference.
2687
2688 2019-04-25  Tom Tromey  <tromey@adacore.com>
2689
2690         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2691         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2692         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2693         Update.
2694         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2695         Update.
2696         * mi/mi-interp.c (mi_interp::exec): Update.
2697         * linespec.c (parse_linespec): Update.
2698         * infcall.c (run_inferior_call): Update.
2699         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2700         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2701         (gdbscm_lookup_global_symbol): Update.
2702         * guile/scm-param.c (gdbscm_parameter_value): Update.
2703         * guile/scm-frame.c (gdbscm_frame_read_register)
2704         (gdbscm_frame_read_var): Update.
2705         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2706         * exec.c (try_open_exec_file): Update.
2707         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2708         (gdb_rl_callback_handler): Update.
2709         * common/common-exceptions.h (exception_none): Don't declare.
2710         * common/common-exceptions.c (exception_none): Don't define.
2711         (struct catcher) <exception>: Update.
2712         * cli/cli-interp.c (safe_execute_command): Update.
2713         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2714
2715 2019-04-25  Ali Tamur  <tamur@google.com>
2716
2717         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2718         (read_attribute_value): Likewise.
2719         (dwarf2_read_addr_index): Update comment.
2720         (read_str_index): Add DW_FORM_strx.
2721         (dwarf2_string_attr): Likewise.
2722         (dwarf2_const_value_attr): Likewise.
2723         (dump_die_shallow): Likewise.
2724         (dwarf2_fetch_constant_bytes): Likewise.
2725         (skip_form_bytes): Likewise.
2726         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2727
2728 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2729
2730         PR corefiles/11608
2731         PR corefiles/18187
2732         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2733         OFFSET.  Verify if current mapping contains an ELF header.
2734         (linux_find_memory_regions_full): Adjust call to
2735         dump_mapping_p.
2736
2737 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2738             Kang Li <kanglictf@gmail.com>
2739
2740         PR gdb/21600
2741
2742         * dwarf2-frame.c (read_initial_length): Be consistent about using
2743         unsigned representation of length.
2744         (decode_frame_entry_1): Likewise.  Check for wraparound of
2745         end pointer as well as buffer overflow.
2746
2747 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2748
2749         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2750         "vq".
2751
2752 2019-04-24  Tom Tromey  <tromey@adacore.com>
2753
2754         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2755
2756 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2757
2758         * s12z-tdep.c (s12z_unwind_pc): Delete.
2759         (s12z_unwind_sp): Delete.
2760         (s12z_gdbarch_init): Don't register deleted functions with
2761         gdbarch.
2762
2763 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2764
2765         * rl78-tdep.c (rl78_unwind_sp): Delete.
2766         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2767
2768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2769
2770         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2771         (xstormy16_unwind_pc): Delete.
2772         (xstormy16_dummy_id): Delete.
2773         (xstormy16_gdbarch_init): Don't register deleted functions with
2774         gdbarch.
2775
2776 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2777
2778         * vax-tdep.c (vax_unwind_pc): Delete.
2779         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2780
2781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2782
2783         * v850-tdep.c (v850_unwind_sp): Delete.
2784         (v850_unwind_pc): Delete.
2785         (v850_dummy_id): Delete.
2786         (v850_gdbarch_init): Don't register deleted functions with
2787         gdbarch.
2788
2789 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2790
2791         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2792         (tilegx_unwind_pc): Delete.
2793         (tilegx_unwind_dummy_id): Delete.
2794         (tilegx_gdbarch_init): Don't register deleted functions with
2795         gdbarch.
2796
2797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2798
2799         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2800         (tic6x_dummy_id): Delete.
2801         (tic6x_gdbarch_init): Don't register deleted functions with
2802         gdbarch.
2803
2804 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2805
2806         * sparc-tdep.c (sparc_unwind_pc): Delete.
2807         (sparc32_gdbarch_init): Don't register deleted function with
2808         gdbarch.
2809
2810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2811
2812         * sh-tdep.c (sh_unwind_sp): Delete.
2813         (sh_unwind_pc): Delete.
2814         (sh_dummy_id): Delete.
2815         (sh_gdbarch_init): Don't register deleted functions with
2816         gdbarch.
2817
2818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2819
2820         * score-tdep.c (score_unwind_sp): Delete.
2821         (score_unwind_pc): Delete.
2822         (score_dummy_id): Delete.
2823         (score_gdbarch_init): Don't register deleted functions with
2824         gdbarch.
2825
2826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2827
2828         * rx-tdep.c (rx_unwind_pc): Delete.
2829         (rx_unwind_sp): Delete.
2830         (rx_dummy_id): Delete.
2831         (rx_gdbarch_init): Don't register deleted functions with
2832         gdbarch.  Update comment.
2833
2834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2835
2836         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2837         (rs6000_dummy_id): Delete.
2838         (rs6000_gdbarch_init): Don't register deleted functions with
2839         gdbarch.
2840
2841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2842
2843         * or1k-tdep.c (or1k_dummy_id): Delete.
2844         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2845
2846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2847
2848         * nios2-tdep.c (nios2_dummy_id): Delete.
2849         (nios2_unwind_sp): Delete.
2850         (nios2_gdbarch_init): Don't register deleted functions with
2851         gdbarch.
2852
2853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2854
2855         * nds32-tdep.c (nds32_dummy_id): Delete.
2856         (nds32_unwind_pc): Delete.
2857         (nds32_unwind_sp): Delete.
2858         (nds32_gdbarch_init): Don't register deleted functions with
2859         gdbarch.
2860
2861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2862
2863         * msp430-tdep.c (msp430_unwind_pc): Delete.
2864         (msp430_unwind_sp): Delete.
2865         (msp430_dummy_id): Delete.
2866         (msp430_gdbarch_init): Don't register deleted functions with
2867         gdbarch.
2868
2869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2870
2871         * moxie-tdep.c (moxie_unwind_sp): Delete.
2872         (moxie_unwind_pc): Delete.
2873         (moxie_dummy_id): Delete.
2874         (moxie_gdbarch_init): Don't register deleted functions with
2875         gdbarch.
2876
2877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2878
2879         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2880         (mn10300_unwind_pc): Delete.
2881         (mn10300_unwind_sp): Delete.
2882         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2883         mn10300_unwind_sp.
2884         (mn10300_frame_unwind_init): Don't register deleted functions with
2885         gdbarch.
2886
2887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2888
2889         * mep-tdep.c (mep_unwind_pc): Delete.
2890         (mep_unwind_sp): Delete.
2891         (mep_dummy_id): Delete.
2892         (mep_gdbarch_init): Don't register deleted functions with
2893         gdbarch.
2894
2895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2896
2897         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2898         (m68hc11_unwind_sp): Delete.
2899         (m68hc11_gdbarch_init): Don't register deleted functions with
2900         gdbarch.
2901
2902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2903
2904         * m32r-tdep.c (m32r_unwind_sp): Delete.
2905         (m32r_unwind_pc): Delete.
2906         (m32r_dummy_id): Delete.
2907         (m32r_gdbarch_init): Don't register deleted functions with
2908         gdbarch.
2909
2910 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2911
2912         * m32c-tdep.c (m32c_unwind_pc): Delete.
2913         (m32c_unwind_sp): Delete.
2914         (m32c_dummy_id): Delete.
2915         (m32c_gdbarch_init): Don't register deleted functions with
2916         gdbarch.
2917
2918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2919
2920         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2921         (lm32_unwind_pc): Delete.
2922         (lm32_dummy_id): Delete.
2923         (lm32_gdbarch_init): Don't register deleted functions with
2924         gdbarch.
2925
2926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2927
2928         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2929         (iq2000_unwind_pc): Delete.
2930         (iq2000_dummy_id): Delete.
2931         (iq2000_gdbarch_init): Don't register deleted functions with
2932         gdbarch.
2933
2934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2935
2936         * nds32-tdep.c (nds32_type_align): Delete.
2937         (nds32_push_dummy_call): Use type_align instead.
2938
2939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2940
2941         * arm-tdep.c (arm_type_align): Only handle vector override case.
2942         (arm_push_dummy_call): Use type_align.
2943         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2944
2945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2946
2947         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2948         case.
2949         (pass_on_stack): Use type_align.
2950         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2951         function.
2952
2953 2019-04-23  Tom Tromey  <tromey@adacore.com>
2954
2955         * dwarf2read.c (line_header::file_name_at): Remove unused
2956         overload.
2957
2958 2019-04-23  Tom de Vries  <tdevries@suse.de>
2959
2960         PR gdb/24438
2961         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2962         invocation.
2963
2964
2965 2019-03-27  Ali Tamur  <tamur@google.com>
2966
2967         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2968         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2969         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2970         (dwarf_expr_context::get_addr_index): Likewise
2971         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2972         (symbol_needs_eval_context::get_addr_index): Likewise
2973         (disassemble_dwarf_expression): Add DW_OP_addrx
2974         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2975         (read_cutu_die_from_dwo): Update comment
2976         (skip_one_die): Add DW_FORM_addrx
2977         (read_attribute_value): Likewise
2978         (var_decode_location): Add DW_OP_addrx
2979         (dwarf2_const_value_attr): Add DW_FORM_addrx
2980         (dump_die_shallow): Likewise
2981         (dwarf2_fetch_constant_bytes): Likewise
2982         (decode_locdesc): Add DW_OP_addrx
2983         (skip_form_bytes): Add DW_FORM_addrx
2984
2985 2019-04-22  Ali Tamur  <tamur@google.com>
2986
2987         * MAINTAINERS (Write After Approval): Add self.
2988
2989 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2990
2991         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2992         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2993         (open_symbol_file_object): Likewise.
2994         (svr4_default_sos): Add info parameter.
2995         (svr4_read_so_list): Likewise.
2996         (svr4_current_sos_direct): Adjust functions calls to pass down
2997         info.
2998         (svr4_current_sos_1): Add info parameter.
2999         (svr4_current_sos): Call get_svr4_info, pass info down to
3000         svr4_current_sos_1.
3001         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3002         get_svr4_info.
3003         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3004         get_svr4_info.
3005         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3006         to get_svr4_info.
3007         (probes_table_remove_objfile_probes): Likewise.
3008         (register_solib_event_probe): Add info parameter.
3009         (solist_update_incremental): Pass info parameter down to
3010         svr4_read_so_list.
3011         (disable_probes_interface): Add info parameter.
3012         (svr4_handle_solib_event): Pass current_program_space to
3013         get_svr4_info.  Adjust disable_probes_interface cleanup.
3014         (svr4_create_probe_breakpoints): Add info parameter, pass it
3015         down to register_solib_event_probe.
3016         (svr4_create_solib_event_breakpoints): Add info parameter,
3017         pass it down to svr4_create_probe_breakpoints.
3018         (enable_break): Pass info down to
3019         svr4_create_solib_event_breakpoints.
3020         (svr4_solib_create_inferior_hook): Pass current_program_space to
3021         get_svr4_info.
3022         (svr4_clear_solib): Likewise.
3023
3024 2019-04-22  Pedro Alves  <palves@redhat.com>
3025
3026         * solib-svr4.c (svr4_free_objfile_observer): New.
3027         (probe_and_action::objfile): New field.
3028         (probes_table_htab_remove_objfile_probes)
3029         (probes_table_remove_objfile_probes): New functions.
3030         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3031         in the new probe_and_action.  Don't store the probe in 'lookup'.
3032         (svr4_create_probe_breakpoints): Pass objfile to
3033         register_solib_event_probe.
3034         (_initialize_svr4_solib): Register a free_objfile observer.
3035
3036 2019-04-19  Tom Tromey  <tom@tromey.com>
3037
3038         * common/queue.h: Remove.
3039
3040 2019-04-19  Tom Tromey  <tom@tromey.com>
3041
3042         * event-loop.c: Don't include "common/queue.h".
3043
3044 2019-04-19  Tom Tromey  <tom@tromey.com>
3045
3046         * remote.c (remote_target): Use delete.
3047         * remote-notif.h: Include <list>, not "common/queue.h".
3048         (notif_client_p): Remove typedef.
3049         (remote_notif_state): Add constructor, destructor, initializer.
3050         <notif_queue>: Now a std::list.
3051         (remote_notif_state_xfree): Don't declare.
3052         * remote-notif.c (remote_notif_process, handle_notification)
3053         (remote_notif_state_allocate): Update.
3054         (~remote_notif_state): Rename from remote_notif_state_xfree.
3055
3056 2019-04-19  Tom Tromey  <tom@tromey.com>
3057
3058         * symfile.c (reread_symbols): Update.
3059         * objfiles.c (objfile_register_static_link)
3060         (objfile_lookup_static_link): Update
3061         (~objfile) Don't delete static_links.
3062         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3063
3064 2019-04-19  Tom Tromey  <tom@tromey.com>
3065
3066         * type-stack.h (struct type_stack) <insert>: Constify string.
3067         * type-stack.c (type_stack::insert): Constify string.
3068         * gdbtypes.h (lookup_template_type): Update.
3069         (address_space_name_to_int): Update.
3070         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3071         const.
3072         (lookup_template_type): Make name const.
3073         * c-exp.y: Update rules.
3074         (lex_one_token, classify_name, classify_inner_name)
3075         (c_print_token): Update.
3076         * p-exp.y: Update rules.
3077         (yylex): Update.
3078         * f-exp.y: Update rules.
3079         (yylex): Update.
3080         * d-exp.y: Update rules.
3081         (lex_one_token, classify_name, classify_inner_name): Update.
3082         * parse.c (write_dollar_variable, copy_name): Return std::string.
3083         * parser-defs.h (copy_name): Change return type.
3084         * m2-exp.y: Update rules.
3085         (yylex): Update.
3086         * go-exp.y (lex_one_token): Update.
3087         Update rules.
3088         (classify_unsafe_function, classify_packaged_name)
3089         (classify_name, yylex): Update.
3090
3091 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3092
3093         * configure.ac: add --enable-source-highlight switch.
3094         * configure: Regenerate.
3095         * top.c (print_gdb_version): plumb --enable-source-highlight
3096         status to "show configuration".
3097
3098 2019-04-19  Tom Tromey  <tromey@adacore.com>
3099
3100         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3101         Check ADA_TYPE_P.
3102         (empty_record, ada_template_to_fixed_record_type_1)
3103         (template_to_static_fixed_type)
3104         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3105         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3106         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3107         macros.
3108
3109 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3110
3111         PR symtab/24423:
3112         * source.c (print_source_lines_base): Advance "iter" when a
3113         control character is seen.
3114
3115 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3116
3117         * inferior.h (struct infcall_suspend_state_deleter):
3118         Catch exception in destructor to avoid crash.
3119
3120 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3121
3122         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3123         close to the add_com "shell".
3124
3125 2019-04-18  Tom Tromey  <tromey@adacore.com>
3126
3127         * process-stratum-target.h (class process_stratum_target)
3128         <stratum>: Add "final".
3129
3130 2019-04-17  Tom Tromey  <tromey@adacore.com>
3131
3132         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3133         against nullptr before use.
3134
3135 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3136
3137         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3138
3139 2019-04-17  Jim Wilson  <jimw@sifive.com>
3140             Andrew Burgess  <andrew.burgess@embecosm.com>
3141
3142         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3143         code read might fail, assume 4-byte breakpoint in that case.
3144
3145 2019-04-15  Leszek Swirski  <leszeks@google.com>
3146
3147         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3148         rather than a hand-rolled POD check when checking for forced MEMORY
3149         classification.
3150
3151 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3152
3153         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3154         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3155         function.
3156         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3157         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3158         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3159         declaration.
3160
3161 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3162
3163         * aarch64-linux-nat.c
3164         (aarch64_linux_nat_target::thread_architecture): Add override.
3165         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3166         each VQ.
3167
3168 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3169
3170         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3171
3172 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3173
3174         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3175         target types of size 96-bits, add some additional comments, and
3176         check that the builtin type we found was the correct size.
3177
3178 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3179
3180         * utils.c (prompt_for_continue): Don't restore the styling at the
3181         end, as applied_style has the wrong value.  This fixes styling in
3182         long lists of file names that are interrupted by the "Continue?"
3183         prompt.
3184
3185 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3186
3187         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3188         * c-lang.c (c_language_defn): Likewise.
3189         (cplus_language_defn): Likewise.
3190         (asm_language_defn): Likewise.
3191         (minimal_language_defn): Likewise.
3192         * d-lang.c (d_language_defn): Likewise.
3193         * f-lang.c (f_language_defn): Likewise.
3194         * go-lang.c (go_language_defn): Likewise.
3195         * language.c (unknown_language_defn): Likewise.
3196         (auto_language_defn): Likewise.
3197         * language.h (struct language_defn): Remove la_magic field.
3198         (LANG_MAGIC): Delete.
3199         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3200         * objc-lang.c (objc_language_defn): Likewise.
3201         * opencl-lang.c (opencl_language_defn): Likewise.
3202         * p-lang.c (pascal_language_defn): Likewise.
3203         * rust-lang.c (rust_language_defn): Likewise.
3204
3205 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3206
3207         * riscv-tdep.c (riscv_type_align): New function.
3208         (riscv_type_alignment): Delete.
3209         (riscv_arg_location): Use 'type_align'.
3210         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3211
3212 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3213
3214         * gdbtypes.c (type_align): A struct with no non-static fields also
3215         has alignment of 1.
3216
3217 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3218
3219         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3220         component to 0.
3221         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3222         member.
3223         (riscv_struct_info::analyse): New implementation using new
3224         analyse_inner member function.
3225         (riscv_struct_info::field_offset): New member function.
3226         (riscv_struct_info::m_offsets): New member variable.
3227         (riscv_struct_info::analyse_inner): New private member function,
3228         takes the old implementation of riscv_struct_info::analyse but
3229         extended to track field offsets.
3230         (riscv_call_arg_struct): Update the struct folding special cases
3231         to handle cases where empty C++ structs, which are non-zero
3232         length, are found.
3233         (riscv_arg_location): Initialise the length of each location, a
3234         non-zero length now indicates the location is in use.
3235         (riscv_push_dummy_call): Allow for the first location having a
3236         non-zero offset when setting up arguments.
3237         (riscv_return_value): Likewise, but for return values.
3238
3239 2019-04-11  Tom Tromey  <tromey@adacore.com>
3240
3241         * utils.c (internal_vproblem): Make "msg" const.
3242
3243 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3244
3245         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3246         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3247         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3248         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3249
3250 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3251
3252         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3253         function.
3254         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3255         of amd64_collect_native_gregset.
3256         (amd64_linux_nat_target::store_registers): Likewise.
3257
3258 2019-04-10  Tom Tromey  <tom@tromey.com>
3259
3260         * symtab.c (lookup_global_symbol_from_objfile)
3261         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3262         * objfiles.h (class separate_debug_iterator): New.
3263         (class separate_debug_range): New.
3264         (struct objfile) <separate_debug_objfiles>: New method.
3265         (objfile_separate_debug_iterate): Don't declare.
3266         * objfiles.c (separate_debug_iterator::operator++): Rename from
3267         objfile_separate_debug_iterate.
3268         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3269         iterator.
3270         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3271         iterator.
3272
3273 2019-04-10  Tom Tromey  <tom@tromey.com>
3274
3275         * symfile.c (reread_symbols): Remove old comment.
3276         * objfiles.c (free_all_objfiles): Fix a typo.
3277
3278 2019-04-10  Tom Tromey  <tom@tromey.com>
3279
3280         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3281         * minsyms.c (lookup_minimal_symbol): Use foreach.
3282         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3283         (lookup_minimal_symbol_solib_trampoline): Likewise.
3284         * symfile.c (reread_symbols): Use foreach.
3285
3286 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3287             Tom Tromey  <tromey@adacore.com>
3288
3289         PR rust/24414:
3290         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3291         (rust_lex_int_test): Change "value" to be LONGEST.
3292         (rust_lex_tests): Add test for long integer literal.
3293
3294 2019-04-09  Tom Tromey  <tromey@adacore.com>
3295
3296         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3297         to bool.
3298         (extended_remote_target::attach): Update.
3299         (remote_target::remote_notice_new_inferior): Update.
3300         (remote_target::add_current_inferior_and_thread): Update.
3301         * inferior.c (exit_inferior_1): Use "false".
3302         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3303
3304 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3305
3306         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3307         the "start" command.
3308
3309 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3310
3311         * python/py-inferior.c (infpy_thread_from_thread_handle):
3312         Adjust comments to reflect renaming of thread_from_thread_handle
3313         to thread_from_handle.  Adjust keywords.  Fix type error message.
3314         (inferior_object_methods): Add thread_from_handle.  Retain
3315         thread_from_thread_handle, but mark it as deprecated.
3316
3317 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3318
3319         * gdbthread.h (find_thread_by_handle): Revise declaration.
3320         * thread.c (find_thread_by_handle): Likewise.  Adjust
3321         implementation too.
3322         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3323         support for buffer objects as handles.
3324
3325 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3326
3327         * python/py-infthread.c (thpy_thread_handle): New function.
3328         (thread_object_methods): Register thpy_thread_handle.
3329
3330 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3331
3332         * gdbthread.h (thread_to_thread_handle): Declare.
3333         * thread.c (gdbtypes.h): Include.
3334         (thread_to_thread_handle): New function.
3335
3336         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3337         (target_thread_info_to_thread_handle): Declare.
3338         * target.c (target_thread_info_to_thread_handle): New function.
3339         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3340         * target-delegates.c: Regenerate.
3341
3342         * linux-thread-db.c (class thread_db_target): Add method
3343         thread_info_to_thread_handle.
3344         (thread_db_target::thread_info_to_thread_handle): Define.
3345         * remote.c (class remote_target): Add new method
3346         thread_info_to_thread_handle.
3347         (remote_target::thread_info_to_thread_handle): Define.
3348
3349 2019-04-08  Pedro Alves  <palves@redhat.com>
3350
3351         * common/common-exceptions.c (throw_exception): Don't create
3352         named object to throw; throw directly.
3353         (throw_it): Likewise.  Don't initialize gdb_exception::message
3354         here, with new; pass FMT and AP to the ctor instead.
3355         * common/common-exceptions.h: Include <string>.
3356         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3357         const char *, va_list)): New ctor.  Use std::make_shared.
3358         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3359         errors)): Delete.
3360         (gdb_exception_error::gdb_exception_error(enum errors, const char
3361         *, va_list)): New.
3362         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3363         Add assertion.
3364         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3365         errors)): Delete.
3366         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3367         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3368         Add assertion.
3369
3370 2019-04-08  Tom Tromey  <tom@tromey.com>
3371
3372         * valops.c (value_rtti_indirect_type): Replace throw_exception
3373         with throw.
3374         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3375         with throw.
3376         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3377         throw.
3378         * target.c (target_translate_tls_address): Replace throw_exception
3379         with throw.
3380         * stack.c (frame_apply_command_count): Replace throw_exception
3381         with throw.
3382         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3383         throw.
3384         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3385         with throw.
3386         * rs6000-tdep.c (rs6000_frame_cache)
3387         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3388         * remote.c: Replace throw_exception with throw.
3389         * record-full.c (record_full_message, record_full_wait_1)
3390         (record_full_restore): Replace throw_exception with throw.
3391         * record-btrace.c:
3392         (get_thread_current_frame_id, record_btrace_start_replaying)
3393         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3394         (cmd_record_btrace_start): Replace throw_exception with throw.
3395         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3396         throw.
3397         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3398         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3399         * linespec.c:
3400         (find_linespec_symbols): Replace throw_exception with throw.
3401         * infrun.c (displaced_step_prepare, resume): Replace
3402         throw_exception with throw.
3403         * infcmd.c (post_create_inferior): Replace throw_exception with
3404         throw.
3405         * inf-loop.c (inferior_event_handler): Replace throw_exception
3406         with throw.
3407         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3408         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3409         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3410         (get_prev_frame_always, get_frame_pc_if_available)
3411         (get_frame_address_in_block_if_available, get_frame_language):
3412         Replace throw_exception with throw.
3413         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3414         throw_exception with throw.
3415         * eval.c (fetch_subexp_value, evaluate_var_value)
3416         (evaluate_funcall, evaluate_subexp_standard): Replace
3417         throw_exception with throw.
3418         * dwarf2loc.c (call_site_find_chain)
3419         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3420         Replace throw_exception with throw.
3421         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3422         with throw.
3423         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3424         throw.
3425         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3426         * completer.c (complete_line_internal): Replace throw_exception
3427         with throw.
3428         * compile/compile-object-run.c (compile_object_run): Replace
3429         throw_exception with throw.
3430         * cli/cli-script.c (process_next_line): Replace throw_exception
3431         with throw.
3432         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3433         (btrace_enable, btrace_maint_update_pt_packets): Replace
3434         throw_exception with throw.
3435         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3436         throw_exception with throw.
3437         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3438         throw_exception with throw.
3439         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3440         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3441         * aarch64-tdep.c (aarch64_make_prologue_cache)
3442         (aarch64_make_stub_cache): Replace throw_exception with throw.
3443
3444 2019-04-08  Tom Tromey  <tom@tromey.com>
3445
3446         * common/common-exceptions.c (throw_exception): Rename from
3447         throw_exception_cxx.  Remove old copy.  Make argument const.
3448         (throw_it): Create and throw exception objects directly.
3449         * common/common-exceptions.h (throw_exception): Make argument
3450         const.
3451         (struct gdb_exception_error): Add constructor.
3452         (struct gdb_exception_quit): Add constructor.
3453
3454 2019-04-08  Tom Tromey  <tom@tromey.com>
3455
3456         * common/common-exceptions.h (exception_rethrow): Don't declare.
3457         (TRY_SJLJ): Update comment.
3458         (TRY, CATCH, END_CATCH): Remove.
3459         * common/common-exceptions.c (exception_rethrow): Remove.
3460
3461 2019-04-08  Tom Tromey  <tom@tromey.com>
3462
3463         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3464         Remove.
3465         (gdb_exception_error): Rename from
3466         gdb_exception_RETURN_MASK_ERROR.
3467         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3468         (gdb_quit_bad_alloc): Update.
3469         * aarch64-tdep.c: Update.
3470         * ada-lang.c: Update.
3471         * ada-typeprint.c: Update.
3472         * ada-valprint.c: Update.
3473         * amd64-tdep.c: Update.
3474         * arch-utils.c: Update.
3475         * break-catch-throw.c: Update.
3476         * breakpoint.c: Update.
3477         * btrace.c: Update.
3478         * c-varobj.c: Update.
3479         * cli/cli-cmds.c: Update.
3480         * cli/cli-interp.c: Update.
3481         * cli/cli-script.c: Update.
3482         * common/common-exceptions.c: Update.
3483         * common/new-op.c: Update.
3484         * common/selftest.c: Update.
3485         * compile/compile-c-symbols.c: Update.
3486         * compile/compile-cplus-symbols.c: Update.
3487         * compile/compile-object-load.c: Update.
3488         * compile/compile-object-run.c: Update.
3489         * completer.c: Update.
3490         * corelow.c: Update.
3491         * cp-abi.c: Update.
3492         * cp-support.c: Update.
3493         * cp-valprint.c: Update.
3494         * darwin-nat.c: Update.
3495         * disasm-selftests.c: Update.
3496         * dtrace-probe.c: Update.
3497         * dwarf-index-cache.c: Update.
3498         * dwarf-index-write.c: Update.
3499         * dwarf2-frame-tailcall.c: Update.
3500         * dwarf2-frame.c: Update.
3501         * dwarf2loc.c: Update.
3502         * dwarf2read.c: Update.
3503         * eval.c: Update.
3504         * event-loop.c: Update.
3505         * event-top.c: Update.
3506         * exec.c: Update.
3507         * f-valprint.c: Update.
3508         * fbsd-tdep.c: Update.
3509         * frame-unwind.c: Update.
3510         * frame.c: Update.
3511         * gdbtypes.c: Update.
3512         * gnu-v3-abi.c: Update.
3513         * guile/guile-internal.h: Update.
3514         * guile/scm-block.c: Update.
3515         * guile/scm-breakpoint.c: Update.
3516         * guile/scm-cmd.c: Update.
3517         * guile/scm-disasm.c: Update.
3518         * guile/scm-frame.c: Update.
3519         * guile/scm-lazy-string.c: Update.
3520         * guile/scm-math.c: Update.
3521         * guile/scm-param.c: Update.
3522         * guile/scm-ports.c: Update.
3523         * guile/scm-pretty-print.c: Update.
3524         * guile/scm-symbol.c: Update.
3525         * guile/scm-symtab.c: Update.
3526         * guile/scm-type.c: Update.
3527         * guile/scm-value.c: Update.
3528         * i386-linux-tdep.c: Update.
3529         * i386-tdep.c: Update.
3530         * inf-loop.c: Update.
3531         * infcall.c: Update.
3532         * infcmd.c: Update.
3533         * infrun.c: Update.
3534         * jit.c: Update.
3535         * language.c: Update.
3536         * linespec.c: Update.
3537         * linux-fork.c: Update.
3538         * linux-nat.c: Update.
3539         * linux-tdep.c: Update.
3540         * linux-thread-db.c: Update.
3541         * main.c: Update.
3542         * mi/mi-cmd-break.c: Update.
3543         * mi/mi-cmd-stack.c: Update.
3544         * mi/mi-interp.c: Update.
3545         * mi/mi-main.c: Update.
3546         * objc-lang.c: Update.
3547         * p-valprint.c: Update.
3548         * parse.c: Update.
3549         * ppc-linux-tdep.c: Update.
3550         * printcmd.c: Update.
3551         * python/py-arch.c: Update.
3552         * python/py-breakpoint.c: Update.
3553         * python/py-cmd.c: Update.
3554         * python/py-finishbreakpoint.c: Update.
3555         * python/py-frame.c: Update.
3556         * python/py-framefilter.c: Update.
3557         * python/py-gdb-readline.c: Update.
3558         * python/py-inferior.c: Update.
3559         * python/py-infthread.c: Update.
3560         * python/py-lazy-string.c: Update.
3561         * python/py-linetable.c: Update.
3562         * python/py-objfile.c: Update.
3563         * python/py-param.c: Update.
3564         * python/py-prettyprint.c: Update.
3565         * python/py-progspace.c: Update.
3566         * python/py-record-btrace.c: Update.
3567         * python/py-record.c: Update.
3568         * python/py-symbol.c: Update.
3569         * python/py-type.c: Update.
3570         * python/py-unwind.c: Update.
3571         * python/py-utils.c: Update.
3572         * python/py-value.c: Update.
3573         * python/python.c: Update.
3574         * record-btrace.c: Update.
3575         * record-full.c: Update.
3576         * remote-fileio.c: Update.
3577         * remote.c: Update.
3578         * riscv-tdep.c: Update.
3579         * rs6000-aix-tdep.c: Update.
3580         * rs6000-tdep.c: Update.
3581         * rust-exp.y: Update.
3582         * rust-lang.c: Update.
3583         * s390-tdep.c: Update.
3584         * selftest-arch.c: Update.
3585         * solib-dsbt.c: Update.
3586         * solib-frv.c: Update.
3587         * solib-spu.c: Update.
3588         * solib-svr4.c: Update.
3589         * solib.c: Update.
3590         * sparc64-linux-tdep.c: Update.
3591         * stack.c: Update.
3592         * symfile-mem.c: Update.
3593         * symmisc.c: Update.
3594         * target.c: Update.
3595         * thread.c: Update.
3596         * top.c: Update.
3597         * tracefile-tfile.c: Update.
3598         * tui/tui.c: Update.
3599         * typeprint.c: Update.
3600         * unittests/cli-utils-selftests.c: Update.
3601         * unittests/parse-connection-spec-selftests.c: Update.
3602         * valops.c: Update.
3603         * valprint.c: Update.
3604         * value.c: Update.
3605         * varobj.c: Update.
3606         * windows-nat.c: Update.
3607         * x86-linux-nat.c: Update.
3608         * xml-support.c: Update.
3609
3610 2019-04-08  Tom Tromey  <tom@tromey.com>
3611
3612         * xml-support.c: Use C++ exception handling.
3613         * x86-linux-nat.c: Use C++ exception handling.
3614         * windows-nat.c: Use C++ exception handling.
3615         * varobj.c: Use C++ exception handling.
3616         * value.c: Use C++ exception handling.
3617         * valprint.c: Use C++ exception handling.
3618         * valops.c: Use C++ exception handling.
3619         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3620         handling.
3621         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3622         * typeprint.c: Use C++ exception handling.
3623         * tui/tui.c: Use C++ exception handling.
3624         * tracefile-tfile.c: Use C++ exception handling.
3625         * top.c: Use C++ exception handling.
3626         * thread.c: Use C++ exception handling.
3627         * target.c: Use C++ exception handling.
3628         * symmisc.c: Use C++ exception handling.
3629         * symfile-mem.c: Use C++ exception handling.
3630         * stack.c: Use C++ exception handling.
3631         * sparc64-linux-tdep.c: Use C++ exception handling.
3632         * solib.c: Use C++ exception handling.
3633         * solib-svr4.c: Use C++ exception handling.
3634         * solib-spu.c: Use C++ exception handling.
3635         * solib-frv.c: Use C++ exception handling.
3636         * solib-dsbt.c: Use C++ exception handling.
3637         * selftest-arch.c: Use C++ exception handling.
3638         * s390-tdep.c: Use C++ exception handling.
3639         * rust-lang.c: Use C++ exception handling.
3640         * rust-exp.y: Use C++ exception handling.
3641         * rs6000-tdep.c: Use C++ exception handling.
3642         * rs6000-aix-tdep.c: Use C++ exception handling.
3643         * riscv-tdep.c: Use C++ exception handling.
3644         * remote.c: Use C++ exception handling.
3645         * remote-fileio.c: Use C++ exception handling.
3646         * record-full.c: Use C++ exception handling.
3647         * record-btrace.c: Use C++ exception handling.
3648         * python/python.c: Use C++ exception handling.
3649         * python/py-value.c: Use C++ exception handling.
3650         * python/py-utils.c: Use C++ exception handling.
3651         * python/py-unwind.c: Use C++ exception handling.
3652         * python/py-type.c: Use C++ exception handling.
3653         * python/py-symbol.c: Use C++ exception handling.
3654         * python/py-record.c: Use C++ exception handling.
3655         * python/py-record-btrace.c: Use C++ exception handling.
3656         * python/py-progspace.c: Use C++ exception handling.
3657         * python/py-prettyprint.c: Use C++ exception handling.
3658         * python/py-param.c: Use C++ exception handling.
3659         * python/py-objfile.c: Use C++ exception handling.
3660         * python/py-linetable.c: Use C++ exception handling.
3661         * python/py-lazy-string.c: Use C++ exception handling.
3662         * python/py-infthread.c: Use C++ exception handling.
3663         * python/py-inferior.c: Use C++ exception handling.
3664         * python/py-gdb-readline.c: Use C++ exception handling.
3665         * python/py-framefilter.c: Use C++ exception handling.
3666         * python/py-frame.c: Use C++ exception handling.
3667         * python/py-finishbreakpoint.c: Use C++ exception handling.
3668         * python/py-cmd.c: Use C++ exception handling.
3669         * python/py-breakpoint.c: Use C++ exception handling.
3670         * python/py-arch.c: Use C++ exception handling.
3671         * printcmd.c: Use C++ exception handling.
3672         * ppc-linux-tdep.c: Use C++ exception handling.
3673         * parse.c: Use C++ exception handling.
3674         * p-valprint.c: Use C++ exception handling.
3675         * objc-lang.c: Use C++ exception handling.
3676         * mi/mi-main.c: Use C++ exception handling.
3677         * mi/mi-interp.c: Use C++ exception handling.
3678         * mi/mi-cmd-stack.c: Use C++ exception handling.
3679         * mi/mi-cmd-break.c: Use C++ exception handling.
3680         * main.c: Use C++ exception handling.
3681         * linux-thread-db.c: Use C++ exception handling.
3682         * linux-tdep.c: Use C++ exception handling.
3683         * linux-nat.c: Use C++ exception handling.
3684         * linux-fork.c: Use C++ exception handling.
3685         * linespec.c: Use C++ exception handling.
3686         * language.c: Use C++ exception handling.
3687         * jit.c: Use C++ exception handling.
3688         * infrun.c: Use C++ exception handling.
3689         * infcmd.c: Use C++ exception handling.
3690         * infcall.c: Use C++ exception handling.
3691         * inf-loop.c: Use C++ exception handling.
3692         * i386-tdep.c: Use C++ exception handling.
3693         * i386-linux-tdep.c: Use C++ exception handling.
3694         * guile/scm-value.c: Use C++ exception handling.
3695         * guile/scm-type.c: Use C++ exception handling.
3696         * guile/scm-symtab.c: Use C++ exception handling.
3697         * guile/scm-symbol.c: Use C++ exception handling.
3698         * guile/scm-pretty-print.c: Use C++ exception handling.
3699         * guile/scm-ports.c: Use C++ exception handling.
3700         * guile/scm-param.c: Use C++ exception handling.
3701         * guile/scm-math.c: Use C++ exception handling.
3702         * guile/scm-lazy-string.c: Use C++ exception handling.
3703         * guile/scm-frame.c: Use C++ exception handling.
3704         * guile/scm-disasm.c: Use C++ exception handling.
3705         * guile/scm-cmd.c: Use C++ exception handling.
3706         * guile/scm-breakpoint.c: Use C++ exception handling.
3707         * guile/scm-block.c: Use C++ exception handling.
3708         * guile/guile-internal.h: Use C++ exception handling.
3709         * gnu-v3-abi.c: Use C++ exception handling.
3710         * gdbtypes.c: Use C++ exception handling.
3711         * frame.c: Use C++ exception handling.
3712         * frame-unwind.c: Use C++ exception handling.
3713         * fbsd-tdep.c: Use C++ exception handling.
3714         * f-valprint.c: Use C++ exception handling.
3715         * exec.c: Use C++ exception handling.
3716         * event-top.c: Use C++ exception handling.
3717         * event-loop.c: Use C++ exception handling.
3718         * eval.c: Use C++ exception handling.
3719         * dwarf2read.c: Use C++ exception handling.
3720         * dwarf2loc.c: Use C++ exception handling.
3721         * dwarf2-frame.c: Use C++ exception handling.
3722         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3723         * dwarf-index-write.c: Use C++ exception handling.
3724         * dwarf-index-cache.c: Use C++ exception handling.
3725         * dtrace-probe.c: Use C++ exception handling.
3726         * disasm-selftests.c: Use C++ exception handling.
3727         * darwin-nat.c: Use C++ exception handling.
3728         * cp-valprint.c: Use C++ exception handling.
3729         * cp-support.c: Use C++ exception handling.
3730         * cp-abi.c: Use C++ exception handling.
3731         * corelow.c: Use C++ exception handling.
3732         * completer.c: Use C++ exception handling.
3733         * compile/compile-object-run.c: Use C++ exception handling.
3734         * compile/compile-object-load.c: Use C++ exception handling.
3735         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3736         * compile/compile-c-symbols.c: Use C++ exception handling.
3737         * common/selftest.c: Use C++ exception handling.
3738         * common/new-op.c: Use C++ exception handling.
3739         * cli/cli-script.c: Use C++ exception handling.
3740         * cli/cli-interp.c: Use C++ exception handling.
3741         * cli/cli-cmds.c: Use C++ exception handling.
3742         * c-varobj.c: Use C++ exception handling.
3743         * btrace.c: Use C++ exception handling.
3744         * breakpoint.c: Use C++ exception handling.
3745         * break-catch-throw.c: Use C++ exception handling.
3746         * arch-utils.c: Use C++ exception handling.
3747         * amd64-tdep.c: Use C++ exception handling.
3748         * ada-valprint.c: Use C++ exception handling.
3749         * ada-typeprint.c: Use C++ exception handling.
3750         * ada-lang.c: Use C++ exception handling.
3751         * aarch64-tdep.c: Use C++ exception handling.
3752
3753 2019-04-08  Tom Tromey  <tom@tromey.com>
3754
3755         * xml-support.c (gdb_xml_parser::parse): Update.
3756         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3757         * value.c (show_convenience): Update.
3758         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3759         (test_parse_flags_qcs): Update.
3760         * thread.c (thr_try_catch_cmd): Update.
3761         * target.c (target_translate_tls_address): Update.
3762         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3763         (info_frame_command_core, frame_apply_command_count): Update.
3764         * rust-exp.y (rust_lex_exception_test): Update.
3765         * riscv-tdep.c (riscv_print_one_register_info): Update.
3766         * remote.c (remote_target::enable_btrace): Update.
3767         * record-btrace.c (record_btrace_enable_warn): Update.
3768         * python/py-utils.c (gdbpy_convert_exception): Update.
3769         * printcmd.c (do_one_display, print_variable_and_value): Update.
3770         * mi/mi-main.c (mi_print_exception): Update.
3771         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3772         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3773         * linux-nat.c (linux_nat_target::attach): Update.
3774         * linux-fork.c (class scoped_switch_fork_info): Update.
3775         * infrun.c (displaced_step_prepare): Update.
3776         * infcall.c (call_function_by_hand_dummy): Update.
3777         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3778         * gnu-v3-abi.c (print_one_vtable): Update.
3779         * frame.c (get_prev_frame_always): Update.
3780         * f-valprint.c (info_common_command_for_block): Update.
3781         * exec.c (try_open_exec_file): Update.
3782         * exceptions.c (print_exception, exception_print)
3783         (exception_fprintf, exception_print_same): Update.
3784         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3785         * dwarf-index-cache.c (index_cache::store)
3786         (index_cache::lookup_gdb_index): Update.
3787         * darwin-nat.c (maybe_cache_shell): Update.
3788         * cp-valprint.c (cp_print_value_fields): Update.
3789         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3790         (gcc_cplus_symbol_address): Update.
3791         * compile/compile-c-symbols.c (gcc_convert_symbol)
3792         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3793         * common/selftest.c: Update.
3794         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3795         a std::string.
3796         (exception_try_scope_entry, exception_try_scope_exit): Don't
3797         declare.
3798         (struct exception_try_scope): Remove.
3799         (TRY): Don't use exception_try_scope.
3800         (struct gdb_exception): Add constructor, operator=.
3801         <what>: New method.
3802         (struct gdb_exception_RETURN_MASK_ALL)
3803         (struct gdb_exception_RETURN_MASK_ERROR)
3804         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3805         (struct gdb_quit_bad_alloc): Update.
3806         * common/common-exceptions.c (exception_none): Change
3807         initializer.
3808         (struct catcher) <state, exception>: Initialize inline.
3809         <prev>: Remove member.
3810         (current_catcher): Remove.
3811         (catchers): New global.
3812         (exceptions_state_mc_init): Simplify.
3813         (catcher_pop): Remove.
3814         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3815         (try_scope_depth, exception_try_scope_entry)
3816         (exception_try_scope_exit): Remove.
3817         (throw_exception_sjlj): Update.
3818         (exception_messages, exception_messages_size): Remove.
3819         (throw_it): Simplify.
3820         (gdb_exception_sliced_copy): Remove.
3821         (throw_exception_cxx): Update.
3822         * cli/cli-script.c (script_from_file): Update.
3823         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3824         Update.
3825         * ada-valprint.c (ada_val_print): Update.
3826         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3827         (create_excep_cond_exprs): Update.
3828
3829 2019-04-08  Tom Tromey  <tom@tromey.com>
3830
3831         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3832         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3833         (TRY, CATCH, END_CATCH): Remove some definitions.
3834         * common/common-exceptions.c: Don't use GDB_XCPT.
3835         (catcher_list_size): Remove.
3836         (throw_exception, throw_it): Simplify.
3837
3838 2019-04-05  Tom Tromey  <tom@tromey.com>
3839
3840         Revert the header-sorting patch.
3841         * ft32-tdep.c: Revert.
3842         * frv-tdep.c: Revert.
3843         * frv-linux-tdep.c: Revert.
3844         * frame.c: Revert.
3845         * frame-unwind.c: Revert.
3846         * frame-base.c: Revert.
3847         * fork-child.c: Revert.
3848         * findvar.c: Revert.
3849         * findcmd.c: Revert.
3850         * filesystem.c: Revert.
3851         * filename-seen-cache.h: Revert.
3852         * filename-seen-cache.c: Revert.
3853         * fbsd-tdep.c: Revert.
3854         * fbsd-nat.h: Revert.
3855         * fbsd-nat.c: Revert.
3856         * f-valprint.c: Revert.
3857         * f-typeprint.c: Revert.
3858         * f-lang.c: Revert.
3859         * extension.h: Revert.
3860         * extension.c: Revert.
3861         * extension-priv.h: Revert.
3862         * expprint.c: Revert.
3863         * exec.h: Revert.
3864         * exec.c: Revert.
3865         * exceptions.c: Revert.
3866         * event-top.c: Revert.
3867         * event-loop.c: Revert.
3868         * eval.c: Revert.
3869         * elfread.c: Revert.
3870         * dwarf2read.h: Revert.
3871         * dwarf2read.c: Revert.
3872         * dwarf2loc.c: Revert.
3873         * dwarf2expr.h: Revert.
3874         * dwarf2expr.c: Revert.
3875         * dwarf2-frame.c: Revert.
3876         * dwarf2-frame-tailcall.c: Revert.
3877         * dwarf-index-write.h: Revert.
3878         * dwarf-index-write.c: Revert.
3879         * dwarf-index-common.c: Revert.
3880         * dwarf-index-cache.h: Revert.
3881         * dwarf-index-cache.c: Revert.
3882         * dummy-frame.c: Revert.
3883         * dtrace-probe.c: Revert.
3884         * disasm.h: Revert.
3885         * disasm.c: Revert.
3886         * disasm-selftests.c: Revert.
3887         * dictionary.c: Revert.
3888         * dicos-tdep.c: Revert.
3889         * demangle.c: Revert.
3890         * dcache.h: Revert.
3891         * dcache.c: Revert.
3892         * darwin-nat.h: Revert.
3893         * darwin-nat.c: Revert.
3894         * darwin-nat-info.c: Revert.
3895         * d-valprint.c: Revert.
3896         * d-namespace.c: Revert.
3897         * d-lang.c: Revert.
3898         * ctf.c: Revert.
3899         * csky-tdep.c: Revert.
3900         * csky-linux-tdep.c: Revert.
3901         * cris-tdep.c: Revert.
3902         * cris-linux-tdep.c: Revert.
3903         * cp-valprint.c: Revert.
3904         * cp-support.c: Revert.
3905         * cp-namespace.c: Revert.
3906         * cp-abi.c: Revert.
3907         * corelow.c: Revert.
3908         * corefile.c: Revert.
3909         * continuations.c: Revert.
3910         * completer.h: Revert.
3911         * completer.c: Revert.
3912         * complaints.c: Revert.
3913         * coffread.c: Revert.
3914         * coff-pe-read.c: Revert.
3915         * cli-out.h: Revert.
3916         * cli-out.c: Revert.
3917         * charset.c: Revert.
3918         * c-varobj.c: Revert.
3919         * c-valprint.c: Revert.
3920         * c-typeprint.c: Revert.
3921         * c-lang.c: Revert.
3922         * buildsym.c: Revert.
3923         * buildsym-legacy.c: Revert.
3924         * build-id.h: Revert.
3925         * build-id.c: Revert.
3926         * btrace.c: Revert.
3927         * bsd-uthread.c: Revert.
3928         * breakpoint.h: Revert.
3929         * breakpoint.c: Revert.
3930         * break-catch-throw.c: Revert.
3931         * break-catch-syscall.c: Revert.
3932         * break-catch-sig.c: Revert.
3933         * blockframe.c: Revert.
3934         * block.c: Revert.
3935         * bfin-tdep.c: Revert.
3936         * bfin-linux-tdep.c: Revert.
3937         * bfd-target.c: Revert.
3938         * bcache.c: Revert.
3939         * ax-general.c: Revert.
3940         * ax-gdb.h: Revert.
3941         * ax-gdb.c: Revert.
3942         * avr-tdep.c: Revert.
3943         * auxv.c: Revert.
3944         * auto-load.c: Revert.
3945         * arm-wince-tdep.c: Revert.
3946         * arm-tdep.c: Revert.
3947         * arm-symbian-tdep.c: Revert.
3948         * arm-pikeos-tdep.c: Revert.
3949         * arm-obsd-tdep.c: Revert.
3950         * arm-nbsd-tdep.c: Revert.
3951         * arm-nbsd-nat.c: Revert.
3952         * arm-linux-tdep.c: Revert.
3953         * arm-linux-nat.c: Revert.
3954         * arm-fbsd-tdep.c: Revert.
3955         * arm-fbsd-nat.c: Revert.
3956         * arm-bsd-tdep.c: Revert.
3957         * arch-utils.c: Revert.
3958         * arc-tdep.c: Revert.
3959         * arc-newlib-tdep.c: Revert.
3960         * annotate.h: Revert.
3961         * annotate.c: Revert.
3962         * amd64-windows-tdep.c: Revert.
3963         * amd64-windows-nat.c: Revert.
3964         * amd64-tdep.c: Revert.
3965         * amd64-sol2-tdep.c: Revert.
3966         * amd64-obsd-tdep.c: Revert.
3967         * amd64-obsd-nat.c: Revert.
3968         * amd64-nbsd-tdep.c: Revert.
3969         * amd64-nbsd-nat.c: Revert.
3970         * amd64-nat.c: Revert.
3971         * amd64-linux-tdep.c: Revert.
3972         * amd64-linux-nat.c: Revert.
3973         * amd64-fbsd-tdep.c: Revert.
3974         * amd64-fbsd-nat.c: Revert.
3975         * amd64-dicos-tdep.c: Revert.
3976         * amd64-darwin-tdep.c: Revert.
3977         * amd64-bsd-nat.c: Revert.
3978         * alpha-tdep.c: Revert.
3979         * alpha-obsd-tdep.c: Revert.
3980         * alpha-nbsd-tdep.c: Revert.
3981         * alpha-mdebug-tdep.c: Revert.
3982         * alpha-linux-tdep.c: Revert.
3983         * alpha-linux-nat.c: Revert.
3984         * alpha-bsd-tdep.c: Revert.
3985         * alpha-bsd-nat.c: Revert.
3986         * aix-thread.c: Revert.
3987         * agent.c: Revert.
3988         * addrmap.c: Revert.
3989         * ada-varobj.c: Revert.
3990         * ada-valprint.c: Revert.
3991         * ada-typeprint.c: Revert.
3992         * ada-tasks.c: Revert.
3993         * ada-lang.c: Revert.
3994         * aarch64-tdep.c: Revert.
3995         * aarch64-ravenscar-thread.c: Revert.
3996         * aarch64-newlib-tdep.c: Revert.
3997         * aarch64-linux-tdep.c: Revert.
3998         * aarch64-linux-nat.c: Revert.
3999         * aarch64-fbsd-tdep.c: Revert.
4000         * aarch64-fbsd-nat.c: Revert.
4001         * aarch32-linux-nat.c: Revert.
4002
4003 2019-04-05  Tom Tromey  <tom@tromey.com>
4004
4005         * ft32-tdep.c: Sort headers.
4006         * frv-tdep.c: Sort headers.
4007         * frv-linux-tdep.c: Sort headers.
4008         * frame.c: Sort headers.
4009         * frame-unwind.c: Sort headers.
4010         * frame-base.c: Sort headers.
4011         * fork-child.c: Sort headers.
4012         * findvar.c: Sort headers.
4013         * findcmd.c: Sort headers.
4014         * filesystem.c: Sort headers.
4015         * filename-seen-cache.h: Sort headers.
4016         * filename-seen-cache.c: Sort headers.
4017         * fbsd-tdep.c: Sort headers.
4018         * fbsd-nat.h: Sort headers.
4019         * fbsd-nat.c: Sort headers.
4020         * f-valprint.c: Sort headers.
4021         * f-typeprint.c: Sort headers.
4022         * f-lang.c: Sort headers.
4023         * extension.h: Sort headers.
4024         * extension.c: Sort headers.
4025         * extension-priv.h: Sort headers.
4026         * expprint.c: Sort headers.
4027         * exec.h: Sort headers.
4028         * exec.c: Sort headers.
4029         * exceptions.c: Sort headers.
4030         * event-top.c: Sort headers.
4031         * event-loop.c: Sort headers.
4032         * eval.c: Sort headers.
4033         * elfread.c: Sort headers.
4034         * dwarf2read.h: Sort headers.
4035         * dwarf2read.c: Sort headers.
4036         * dwarf2loc.c: Sort headers.
4037         * dwarf2expr.h: Sort headers.
4038         * dwarf2expr.c: Sort headers.
4039         * dwarf2-frame.c: Sort headers.
4040         * dwarf2-frame-tailcall.c: Sort headers.
4041         * dwarf-index-write.h: Sort headers.
4042         * dwarf-index-write.c: Sort headers.
4043         * dwarf-index-common.c: Sort headers.
4044         * dwarf-index-cache.h: Sort headers.
4045         * dwarf-index-cache.c: Sort headers.
4046         * dummy-frame.c: Sort headers.
4047         * dtrace-probe.c: Sort headers.
4048         * disasm.h: Sort headers.
4049         * disasm.c: Sort headers.
4050         * disasm-selftests.c: Sort headers.
4051         * dictionary.c: Sort headers.
4052         * dicos-tdep.c: Sort headers.
4053         * demangle.c: Sort headers.
4054         * dcache.h: Sort headers.
4055         * dcache.c: Sort headers.
4056         * darwin-nat.h: Sort headers.
4057         * darwin-nat.c: Sort headers.
4058         * darwin-nat-info.c: Sort headers.
4059         * d-valprint.c: Sort headers.
4060         * d-namespace.c: Sort headers.
4061         * d-lang.c: Sort headers.
4062         * ctf.c: Sort headers.
4063         * csky-tdep.c: Sort headers.
4064         * csky-linux-tdep.c: Sort headers.
4065         * cris-tdep.c: Sort headers.
4066         * cris-linux-tdep.c: Sort headers.
4067         * cp-valprint.c: Sort headers.
4068         * cp-support.c: Sort headers.
4069         * cp-namespace.c: Sort headers.
4070         * cp-abi.c: Sort headers.
4071         * corelow.c: Sort headers.
4072         * corefile.c: Sort headers.
4073         * continuations.c: Sort headers.
4074         * completer.h: Sort headers.
4075         * completer.c: Sort headers.
4076         * complaints.c: Sort headers.
4077         * coffread.c: Sort headers.
4078         * coff-pe-read.c: Sort headers.
4079         * cli-out.h: Sort headers.
4080         * cli-out.c: Sort headers.
4081         * charset.c: Sort headers.
4082         * c-varobj.c: Sort headers.
4083         * c-valprint.c: Sort headers.
4084         * c-typeprint.c: Sort headers.
4085         * c-lang.c: Sort headers.
4086         * buildsym.c: Sort headers.
4087         * buildsym-legacy.c: Sort headers.
4088         * build-id.h: Sort headers.
4089         * build-id.c: Sort headers.
4090         * btrace.c: Sort headers.
4091         * bsd-uthread.c: Sort headers.
4092         * breakpoint.h: Sort headers.
4093         * breakpoint.c: Sort headers.
4094         * break-catch-throw.c: Sort headers.
4095         * break-catch-syscall.c: Sort headers.
4096         * break-catch-sig.c: Sort headers.
4097         * blockframe.c: Sort headers.
4098         * block.c: Sort headers.
4099         * bfin-tdep.c: Sort headers.
4100         * bfin-linux-tdep.c: Sort headers.
4101         * bfd-target.c: Sort headers.
4102         * bcache.c: Sort headers.
4103         * ax-general.c: Sort headers.
4104         * ax-gdb.h: Sort headers.
4105         * ax-gdb.c: Sort headers.
4106         * avr-tdep.c: Sort headers.
4107         * auxv.c: Sort headers.
4108         * auto-load.c: Sort headers.
4109         * arm-wince-tdep.c: Sort headers.
4110         * arm-tdep.c: Sort headers.
4111         * arm-symbian-tdep.c: Sort headers.
4112         * arm-pikeos-tdep.c: Sort headers.
4113         * arm-obsd-tdep.c: Sort headers.
4114         * arm-nbsd-tdep.c: Sort headers.
4115         * arm-nbsd-nat.c: Sort headers.
4116         * arm-linux-tdep.c: Sort headers.
4117         * arm-linux-nat.c: Sort headers.
4118         * arm-fbsd-tdep.c: Sort headers.
4119         * arm-fbsd-nat.c: Sort headers.
4120         * arm-bsd-tdep.c: Sort headers.
4121         * arch-utils.c: Sort headers.
4122         * arc-tdep.c: Sort headers.
4123         * arc-newlib-tdep.c: Sort headers.
4124         * annotate.h: Sort headers.
4125         * annotate.c: Sort headers.
4126         * amd64-windows-tdep.c: Sort headers.
4127         * amd64-windows-nat.c: Sort headers.
4128         * amd64-tdep.c: Sort headers.
4129         * amd64-sol2-tdep.c: Sort headers.
4130         * amd64-obsd-tdep.c: Sort headers.
4131         * amd64-obsd-nat.c: Sort headers.
4132         * amd64-nbsd-tdep.c: Sort headers.
4133         * amd64-nbsd-nat.c: Sort headers.
4134         * amd64-nat.c: Sort headers.
4135         * amd64-linux-tdep.c: Sort headers.
4136         * amd64-linux-nat.c: Sort headers.
4137         * amd64-fbsd-tdep.c: Sort headers.
4138         * amd64-fbsd-nat.c: Sort headers.
4139         * amd64-dicos-tdep.c: Sort headers.
4140         * amd64-darwin-tdep.c: Sort headers.
4141         * amd64-bsd-nat.c: Sort headers.
4142         * alpha-tdep.c: Sort headers.
4143         * alpha-obsd-tdep.c: Sort headers.
4144         * alpha-nbsd-tdep.c: Sort headers.
4145         * alpha-mdebug-tdep.c: Sort headers.
4146         * alpha-linux-tdep.c: Sort headers.
4147         * alpha-linux-nat.c: Sort headers.
4148         * alpha-bsd-tdep.c: Sort headers.
4149         * alpha-bsd-nat.c: Sort headers.
4150         * aix-thread.c: Sort headers.
4151         * agent.c: Sort headers.
4152         * addrmap.c: Sort headers.
4153         * ada-varobj.c: Sort headers.
4154         * ada-valprint.c: Sort headers.
4155         * ada-typeprint.c: Sort headers.
4156         * ada-tasks.c: Sort headers.
4157         * ada-lang.c: Sort headers.
4158         * aarch64-tdep.c: Sort headers.
4159         * aarch64-ravenscar-thread.c: Sort headers.
4160         * aarch64-newlib-tdep.c: Sort headers.
4161         * aarch64-linux-tdep.c: Sort headers.
4162         * aarch64-linux-nat.c: Sort headers.
4163         * aarch64-fbsd-tdep.c: Sort headers.
4164         * aarch64-fbsd-nat.c: Sort headers.
4165         * aarch32-linux-nat.c: Sort headers.
4166
4167 2019-04-04  Tom Tromey  <tom@tromey.com>
4168
4169         * varobj.c (varobj_create): Update.
4170         * rust-exp.y (struct rust_parser) <update_innermost_block,
4171         lookup_symbol>: New methods.
4172         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4173         Rename.
4174         (rust_parser::rust_lookup_type)
4175         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4176         * printcmd.c (display_command, do_one_display): Update.
4177         * parser-defs.h (struct parser_state) <parser_state>: Add
4178         "tracker" parameter.
4179         (block_tracker): New member.
4180         (class innermost_block_tracker) <innermost_block_tracker>: Add
4181         "types" parameter.
4182         <reset>: Remove method.
4183         (innermost_block): Don't declare.
4184         (null_post_parser): Update.
4185         * parse.c (innermost_block): Remove global.
4186         (write_dollar_variable): Update.
4187         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4188         Remove "tracker_types" parameter.
4189         (parse_expression): Add "tracker" parameter.
4190         (parse_expression_for_completion): Update.
4191         (null_post_parser): Add "tracker" parameter.
4192         * p-exp.y: Update rules.
4193         * m2-exp.y: Update rules.
4194         * language.h (struct language_defn) <la_post_parser>: Add
4195         "tracker" parameter.
4196         * go-exp.y: Update rules.
4197         * f-exp.y: Update rules.
4198         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4199         parameter.
4200         * d-exp.y: Update rules.
4201         * c-exp.y: Update rules.
4202         * breakpoint.c (set_breakpoint_condition): Create an
4203         innermost_block_tracker.
4204         (watch_command_1): Likewise.
4205         * ada-lang.c (resolve): Add "tracker" parameter.
4206         (resolve_subexp): Likewise.
4207         * ada-exp.y (write_var_from_sym): Update.
4208
4209 2019-04-04  Tom Tromey  <tom@tromey.com>
4210
4211         * type-stack.h: New file.
4212         * type-stack.c: New file.
4213         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4214         type-stack.h.
4215         (insert_into_type_stack, insert_type, push_type, push_type_int)
4216         (insert_type_address_space, pop_type, pop_type_int)
4217         (pop_typelist, pop_type_stack, append_type_stack)
4218         (push_type_stack, get_type_stack, push_typelist)
4219         (follow_type_instance_flags, follow_types): Don't declare.
4220         * parse.c (type_stack): Remove global.
4221         (parse_exp_in_context): Update.
4222         (insert_into_type_stack, insert_type, push_type, push_type_int)
4223         (insert_type_address_space, pop_type, pop_type_int)
4224         (pop_typelist, pop_type_stack, append_type_stack)
4225         (push_type_stack, get_type_stack, push_typelist)
4226         (follow_type_instance_flags, follow_types): Remove (moved to
4227         type-stack.c).
4228         * f-exp.y (type_stack): New global.
4229         Update rules.
4230         (push_kind_type, f_parse): Update.
4231         * d-exp.y (type_stack): New global.
4232         Update rules.
4233         (d_parse): Update.
4234         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4235         Update rules.
4236         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4237         (HFILES_NO_SRCDIR): Add type-stack.h.
4238
4239 2019-04-04  Tom Tromey  <tom@tromey.com>
4240
4241         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4242         (rust_parser::convert_ast_to_expression, rust_parse)
4243         (rust_lex_test_completion, rust_lex_tests): Update.
4244         * parser-defs.h (struct expr_completion_state): New.
4245         (struct parser_state) <parser_state>: Add completion parameter.
4246         <mark_struct_expression, mark_completion_tag>: New methods.
4247         <parse_completion, m_completion_state>: New members.
4248         (prefixify_expression, null_post_parser): Update.
4249         (mark_struct_expression, mark_completion_tag): Don't declare.
4250         * parse.c (parse_completion, expout_last_struct)
4251         (expout_tag_completion_type, expout_completion_name): Remove
4252         globals.
4253         (parser_state::mark_struct_expression)
4254         (parser_state::mark_completion_tag): Now methods.
4255         (prefixify_expression): Add last_struct parameter.
4256         (prefixify_subexp): Likewise.
4257         (parse_exp_1): Update.
4258         (parse_exp_in_context): Add cstate parameter.  Update.
4259         (parse_expression_for_completion): Create an
4260         expr_completion_state.
4261         (null_post_parser): Add "completion" parameter.
4262         * p-exp.y: Update rules.
4263         (yylex): Update.
4264         * language.h (struct language_defn) <la_post_parser>: Add
4265         "completing" parameter.
4266         * go-exp.y: Update rules.
4267         (lex_one_token): Update.
4268         * expression.h (parse_completion): Don't declare.
4269         * d-exp.y: Update rules.
4270         (lex_one_token): Update rules.
4271         * c-exp.y: Update rules.
4272         (lex_one_token): Update.
4273         * ada-lang.c (resolve): Add "parse_completion" parameter.
4274         (resolve_subexp): Likewise.
4275         (ada_resolve_function): Likewise.
4276
4277 2019-04-04  Tom Tromey  <tom@tromey.com>
4278
4279         * parser-defs.h (struct parser_state) <start_arglist,
4280         end_arglist>: New methods.
4281         <arglist_len, m_funcall_chain>: New members.
4282         (arglist_len, start_arglist, end_arglist): Don't declare.
4283         * parse.c (arglist_len, funcall_chain): Remove global.
4284         (start_arglist, end_arglist): Remove functions.
4285         (parse_exp_in_context): Update.
4286         * p-exp.y: Update rules.
4287         * m2-exp.y: Update rules.
4288         * go-exp.y: Update rules.
4289         * f-exp.y: Update rules.
4290         * d-exp.y: Update rules.
4291         * c-exp.y: Update rules.
4292
4293 2019-04-04  Tom Tromey  <tom@tromey.com>
4294
4295         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4296         lex_operator, push_back>: New methods.
4297         Update all rules.
4298         (rust_parser::lex_hex, lex_escape): Rename and update.
4299         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4300         (rust_parser::lex_operator): Rename and update.
4301         (rust_parser::lex_number, rustyylex, rustyyerror)
4302         (rust_lex_test_init, rust_lex_test_sequence)
4303         (rust_lex_test_push_back, rust_lex_tests): Update.
4304         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4305         parameter.
4306         <lexptr, prev_lexptr>: New members.
4307         (lexptr, prev_lexptr): Don't declare.
4308         * parse.c (lexptr, prev_lexptr): Remove globals.
4309         (parse_exp_in_context): Update.
4310         * p-exp.y (yylex, yyerror): Update.
4311         * m2-exp.y (parse_number, yylex, yyerror): Update.
4312         * go-exp.y (lex_one_token, yyerror): Update.
4313         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4314         * d-exp.y (lex_one_token, yyerror): Update.
4315         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4316         (lex_one_token, yyerror): Update.
4317         * ada-lex.l (YY_INPUT): Update.
4318         (rewind_to_char): Update.
4319         * ada-exp.y (yyerror): Update.
4320
4321 2019-04-04  Tom Tromey  <tom@tromey.com>
4322
4323         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4324         * parser-defs.h (struct parser_state) <parser_state>: Add new
4325         parameter.
4326         <comma_terminates>: New member.
4327         (comma_terminates): Don't declare global.
4328         * parse.c (comma_terminates): Remove global.
4329         (parse_exp_in_context): Update.
4330         * p-exp.y (yylex): Update.
4331         * m2-exp.y (yylex): Update.
4332         * go-exp.y (lex_one_token): Update.
4333         * f-exp.y (yylex): Update.
4334         * d-exp.y (lex_one_token): Update.
4335         * c-exp.y (lex_one_token): Update.
4336         * ada-lex.l: Update.
4337
4338 2019-04-04  Tom Tromey  <tom@tromey.com>
4339
4340         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4341         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4342         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4343         * parser-defs.h (paren_depth): Don't declare.
4344         * parse.c (paren_depth): Remove global.
4345         (parse_exp_in_context): Update.
4346         * p-exp.y (paren_depth): New global.
4347         (pascal_parse): Initialize it.
4348         * m2-exp.y (paren_depth): New global.
4349         (m2_parse): Initialize it.
4350         * go-exp.y (paren_depth): New global.
4351         (go_parse): Initialize it.
4352         * f-exp.y (paren_depth): New global.
4353         (f_parse): Initialize it.
4354         * d-exp.y (paren_depth): New global.
4355         (d_parse): Initialize it.
4356         * c-exp.y (paren_depth): New global.
4357         (c_parse): Initialize it.
4358         * ada-lex.l (paren_depth): New global.
4359         (lexer_init): Initialize it.
4360
4361 2019-04-04  Tom Tromey  <tom@tromey.com>
4362
4363         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4364         (rust_parser::convert_ast_to_type)
4365         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4366         * parser-defs.h (struct parser_state) <parser_state>: Add
4367         parameters.  Initialize new members.
4368         <expression_context_block, expression_context_pc>: New members.
4369         * parse.c (expression_context_block, expression_context_pc):
4370         Remove globals.
4371         (parse_exp_in_context): Update.
4372         * p-exp.y: Update all rules.
4373         (yylex): Update.
4374         * m2-exp.y: Update all rules.
4375         (yylex): Update.
4376         * go-exp.y (yylex): Update.
4377         * f-exp.y (yylex): Update.
4378         * d-exp.y: Update all rules.
4379         (yylex): Update.
4380         * c-exp.y: Update all rules.
4381         (lex_one_token, classify_name, yylex, c_parse): Update.
4382         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4383
4384 2019-04-04  Tom Tromey  <tom@tromey.com>
4385
4386         * gdbarch.h, gdbarch.c: Rebuild.
4387         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4388         * stap-probe.h:
4389         (struct stap_parse_info): Replace "parser_state" with
4390         "expr_builder".
4391         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4392         (parser_state): New class.
4393         * parse.c (expr_builder): Rename.
4394         (expr_builder::release): Rename.
4395         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4396         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4397         (write_exp_elt_longcst, write_exp_elt_floatcst)
4398         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4399         (write_exp_string_vector, write_exp_bitstring)
4400         (write_exp_msymbol, mark_struct_expression)
4401         (write_dollar_variable)
4402         (insert_type_address_space, increase_expout_size): Replace
4403         "parser_state" with "expr_builder".
4404         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4405         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4406         "parser_state" with "expr_builder".
4407
4408 2019-04-04  Tom Tromey  <tom@tromey.com>
4409
4410         * rust-exp.y: Replace "parse_language" with method call.
4411         * p-exp.y:
4412         (yylex): Replace "parse_language" with method call.
4413         * m2-exp.y:
4414         (yylex): Replace "parse_language" with method call.
4415         * go-exp.y (classify_name): Replace "parse_language" with method
4416         call.
4417         * f-exp.y (yylex): Replace "parse_language" with method call.
4418         * d-exp.y (lex_one_token): Replace "parse_language" with method
4419         call.
4420         * c-exp.y:
4421         (lex_one_token, classify_name, yylex): Replace "parse_language"
4422         with method call.
4423         * ada-exp.y (find_primitive_type, type_char)
4424         (type_system_address): Replace "parse_language" with method call.
4425
4426 2019-04-04  Tom Tromey  <tom@tromey.com>
4427
4428         * rust-exp.y: Replace "parse_gdbarch" with method call.
4429         * parse.c (write_dollar_variable, insert_type_address_space):
4430         Replace "parse_gdbarch" with method call.
4431         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4432         call.
4433         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4434         call.
4435         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4436         "parse_gdbarch" with method call.
4437         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4438         with method call.
4439         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4440         "parse_gdbarch" with method call.
4441         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4442         "parse_gdbarch" with method call.
4443         * c-exp.y (parse_type, parse_number, classify_name): Replace
4444         "parse_gdbarch" with method call.
4445         * ada-lex.l: Replace "parse_gdbarch" with method call.
4446         * ada-exp.y (parse_type, find_primitive_type, type_char)
4447         (type_system_address): Replace "parse_gdbarch" with method call.
4448
4449 2019-04-04  Tom Tromey  <tom@tromey.com>
4450
4451         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4452         * stap-probe.c (stap_parse_argument): Update.
4453         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4454         initial_size parameter.
4455         * rust-exp.y (rust_lex_tests): Update.
4456         * parse.c (parser_state): Update.
4457         (parse_exp_in_context): Update.
4458         * parser-defs.h (struct parser_state) <parser_state>: Remove
4459         "initial_size" parameter.
4460
4461 2019-04-04  Tom Tromey  <tom@tromey.com>
4462
4463         * parser-defs.h (increase_expout_size): Don't declare.
4464         * parse.c (increase_expout_size): Now static.
4465
4466 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4467
4468         * gnu-nat.c (gnu_nat_target::wait): Fix
4469         target_waitstatus_to_string call.
4470
4471 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4472
4473         * eval.c (evaluate_subexp_standard): Handle internal functions
4474         during Fortran function call handling.
4475
4476 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4477
4478         * NEWS: Mention new internal functions.
4479         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4480         (read_base_type): Use dwarf2_init_complex_target_type.
4481         * value.c (creal_internal_fn): New function.
4482         (cimag_internal_fn): New function.
4483         (_initialize_values): Register new internal functions.
4484
4485 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4486
4487         * infrun.c (stop_all_threads): If debug_infrun, always
4488         trace the wait status after wait_one, using
4489         target_waitstatus_to_string and target_pid_to_str.
4490         (handle_inferior_event): Replace various trace of
4491         wait status kind by a single trace.
4492         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4493         wait status kind image by target_waitstatus_to_string.
4494         * target/waitstatus.c (target_waitstatus_to_string): Fix
4495         obsolete comment.
4496
4497 2019-04-01  Tom Tromey  <tromey@adacore.com>
4498
4499         PR symtab/23331:
4500         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4501
4502 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4503             Pedro Alves  <palves@redhat.com>
4504
4505         * top.c (quit_force): Call 'finalize_values'.
4506         * value.c (finalize_values): New function.
4507         * value.h (finalize_values): Declare.
4508
4509 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4510
4511         * NEWS: Announce $_gdb_major and $_gdb_minor.
4512
4513         * top.c (init_gdb_version_vars): New function.
4514         (gdb_init): Call init_gdb_version_vars.
4515
4516 2019-03-29  Tom Tromey  <tromey@adacore.com>
4517
4518         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4519         help text.  Remove dead code.
4520
4521 2019-03-29  Keith Seitz  <keiths@redhat.com>
4522
4523         From Siddhesh Poyarekar:
4524         * f-lang.h (f77_get_upperbound): Return LONGEST.
4525         (f77_get_lowerbound): Likewise.
4526         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4527         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4528         print them.
4529         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4530         plongest to format print it.
4531         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4532         (f77_get_upperbound): Likewise.
4533         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4534         LOWER_BOUND to LONGEST.
4535         (f77_create_arrayprint_offset_tbl): Likewise.
4536
4537 2019-03-29  Keith Seitz  <keiths@redhat.com>
4538
4539         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4540         %s/pulongest for TYPE_LENGTH instead of %d in format
4541         strings.
4542         * ada-typerint.c (ada_print_type): Likewise.
4543         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4544         * compile/compile-c-support.c (generate_register_struct): Likewise.
4545         * gdbtypes.c (recursive_dump_type): Likewise.
4546         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4547         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4548         instead of %d in format strings.
4549         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4550         to std::min to ULONGEST.
4551         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4552         instead of %d in format strings.
4553         * tracepoint.c (info_scope_command): Likewise.
4554         * typeprint.c (print_offset_data::update)
4555         (print_offset_data::finish): Likewise.
4556         * xtensa-tdep.c (xtensa_store_return_value)
4557         (xtensa_push_dummy_call): Likewise.
4558
4559 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4560
4561         * windows-nat.c (display_selector): Fixed format specifications
4562         for 64-bit Cygwin.
4563
4564 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4565
4566         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4567
4568 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4569
4570         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4571         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4572         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4573         (nios2_linux_init_abi): Install it.
4574
4575 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4576
4577         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4578
4579 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4580
4581         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4582
4583 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4584             Tom Tromey  <tromey@adacore.com>
4585
4586         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4587
4588 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4589
4590         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4591         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4592         method to compute the bounds of range types. Also print "[evaluated]"
4593         if the bounds' values come from a dynamic evaluation.
4594
4595 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4596
4597         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4598         whitespace when pretty printing is on.
4599
4600 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4601
4602         * ppc-linux-nat.c: Add include.
4603
4604 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4605
4606         * NEWS: Mention AArch64 Pointer Authentication.
4607
4608 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4609
4610         * arm-linux-nat.c: Add include.
4611
4612 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4613
4614         * source-cache.c (source_cache::get_source_lines): Re-read
4615         fullname after calling open_source_file.
4616
4617 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4618
4619         * NEWS: Mention TLS support for FreeBSD.
4620
4621 2019-03-25  Tom Tromey  <tromey@adacore.com>
4622
4623         * minsyms.c (BUNCH_SIZE): Update comment.
4624         (~minimal_symbol_reader): Remove old comment.
4625         (compact_minimal_symbols): Update comment.
4626         (minimal_symbol_reader::install): Remove old comment.  Update
4627         other comments.
4628
4629 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4630
4631         * s390-linux-nat.c: Add include.
4632
4633 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4634
4635         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4636         Call linux_get_hwcap.
4637         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4638         Likewise.
4639         (aarch64_linux_get_hwcap): Remove function.
4640         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4641         declaration.
4642         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4643         linux_get_hwcap.
4644         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4645         * linux-tdep.c (linux_get_hwcap): Add function.
4646         (linux_get_hwcap2): Likewise.
4647         * linux-tdep.h (linux_get_hwcap): Add declaration.
4648         (linux_get_hwcap2): Likewise.
4649         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4650         (ppc_linux_get_hwcap2): Likewise.
4651         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4652         linux_get_hwcap.
4653         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4654         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4655         (ppc_linux_nat_target::read_description): Likewise.
4656         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4657         * s390-linux-nat.c: Likewise.
4658         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4659
4660 2019-03-24  Tom Tromey  <tom@tromey.com>
4661
4662         * ada-lang.c (standard_lookup): Simplify initialization.
4663         (ada_lookup_symbol_nonlocal): Simplify return.
4664         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4665         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4666         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4667         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4668         initialization.
4669         * solib.c (solib_global_lookup): Simplify.
4670         * symtab.c (null_block_symbol): Remove.
4671         (symbol_cache_lookup): Simplify returns.
4672         (lookup_language_this): Simplify returns.
4673         (lookup_symbol_aux): Simplify return.
4674         (lookup_local_symbol): Simplify returns.
4675         (lookup_global_symbol_from_objfile): Simplify return.
4676         (lookup_symbol_in_objfile_symtabs)
4677         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4678         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4679         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4680         * cp-namespace.c (cp_lookup_bare_symbol)
4681         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4682         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4683         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4684         (cp_lookup_symbol_via_imports): Simplify initialization.
4685         (find_symbol_in_baseclass): Likewise.
4686         * symtab.h (null_block_symbol): Remove.
4687         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4688         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4689         (d_lookup_symbol_module): Likewise.
4690         (find_symbol_in_baseclass): Simplify initialization.
4691
4692 2019-03-24  Tom Tromey  <tom@tromey.com>
4693
4694         * expression.h: Don't include symtab.h.
4695         (struct block): Forward declare.
4696
4697 2019-03-24  Tom Tromey  <tom@tromey.com>
4698
4699         * c-exp.y (typebase): Remove casts.
4700         * gdbtypes.c (lookup_unsigned_typename, )
4701         (lookup_signed_typename): Remove cast.
4702         * eval.c (parse_to_comma_and_eval): Remove cast.
4703         * parse.c (write_dollar_variable): Remove cast.
4704         * block.h (struct block) <superblock>: Now const.
4705         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4706         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4707         (map_block): Make "block" const.
4708         * symfile.h (struct quick_symbol_functions)
4709         <map_matching_symbols>: Constify block argument to "callback".
4710         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4711         const.
4712         (find_pc_sect_compunit_symtab): Make "b" const.
4713         (find_symbol_at_address): Likewise.
4714         (search_symbols): Likewise.
4715         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4716         (dw2_debug_names_lookup_symbol): Likewise.
4717         (dw2_map_matching_symbols): Update.
4718         * p-valprint.c (pascal_val_print): Remove "block".
4719         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4720         (aux_add_nonlocal_symbols): Make "block" const.
4721         (resolve_subexp): Remove cast.
4722         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4723         const.
4724         (iterate_over_file_blocks): Likewise.
4725         * f-exp.y (%union) <bval>: Remove.
4726         * coffread.c (patch_opaque_types): Make "b" const.
4727         * spu-tdep.c (spu_catch_start): Make "block" const.
4728         * c-valprint.c (print_unpacked_pointer): Remove "block".
4729         * symmisc.c (dump_symtab_1): Make "b" const.
4730         (block_depth): Make "block" const.
4731         * d-exp.y (%union) <bval>: Remove.
4732         * cp-support.h (cp_lookup_rtti_type): Update.
4733         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4734         * psymtab.c (psym_lookup_symbol): Make "block" const.
4735         (maintenance_check_psymtabs): Make "b" const.
4736         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4737         (enumerate_locals, enumerate_args): Update.
4738         * python/py-symtab.c (stpy_global_block): Make "block" const.
4739         (stpy_static_block): Likewise.
4740         * inline-frame.c (block_starting_point_at): Make "new_block"
4741         const.
4742         * block.c (find_block_in_blockvector): Make return type const.
4743         (blockvector_for_pc_sect): Make "b" const.
4744         (find_block_in_blockvector): Make "b" const.
4745
4746 2019-03-23  Tom Tromey  <tom@tromey.com>
4747
4748         * varobj.c (varobj_create): Update.
4749         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4750         * printcmd.c (display_command, do_one_display): Don't reset
4751         innermost_block.
4752         * parser-defs.h (enum innermost_block_tracker_type): Move to
4753         expression.h.
4754         (innermost_block): Update comment.
4755         * parse.c (parse_exp_1): Add tracker_types parameter.
4756         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4757         tracker_types parameter.  Reset innermost_block.
4758         (parse_exp_in_context): Remove.
4759         (parse_expression_for_completion): Update.
4760         * objfiles.c (~objfile): Don't reset expression_context_block or
4761         innermost_block.
4762         * expression.h (enum innermost_block_tracker_type): Move from
4763         parser-defs.h.
4764         (parse_exp_1): Add tracker_types parameter.
4765         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4766         reset innermost_block.
4767
4768 2019-03-23  Tom Tromey  <tom@tromey.com>
4769
4770         * objfiles.h: Include bcache.h.
4771
4772 2019-03-23  Tom Tromey  <tom@tromey.com>
4773
4774         * linespec.c (get_current_search_block): Use
4775         scoped_restore_current_language.
4776         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4777
4778 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4779             Jiong Wang  <jiong.wang@arm.com>
4780
4781         * aarch64-linux-tdep.c
4782         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4783         section.
4784         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4785
4786 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4787             Jiong Wang  <jiong.wang@arm.com>
4788
4789         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4790         instructions.
4791         (aarch64_analyze_prologue_test): Add PACIASP test.
4792         (aarch64_prologue_prev_register): Unmask PC value.
4793
4794 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4795             Jiong Wang  <jiong.wang@arm.com>
4796
4797         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4798         (aarch64_dwarf2_prev_register): Unmask PC value.
4799         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4800         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4801         DW_CFA_AARCH64_negate_ra_state.
4802         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4803
4804 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4805             Jiong Wang  <jiong.wang@arm.com>
4806
4807         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4808         registers.
4809         (aarch64_pseudo_register_name): Likewise.
4810         (aarch64_pseudo_register_type): Likewise.
4811         (aarch64_pseudo_register_reggroup_p): Likewise.
4812         (aarch64_gdbarch_init): Add pauth registers.
4813         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4814         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4815         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4816         (struct gdbarch_tdep): Add regnum for ra_state.
4817
4818 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4819             Jiong Wang  <jiong.wang@arm.com>
4820
4821         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4822
4823 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4824             Jiong Wang  <jiong.wang@arm.com>
4825
4826         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4827         function.
4828         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4829         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4830         (aarch64_gdbarch_init): Add puth registers.
4831         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4832         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4833         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4834
4835 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4836             Jiong Wang  <jiong.wang@arm.com>
4837
4838         * aarch64-linux-nat.c
4839         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4840         * aarch64-linux-tdep.c
4841         (aarch64_linux_core_read_description): Likewise.
4842         (aarch64_linux_get_hwcap): New function.
4843         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4844         (aarch64_linux_get_hwcap): New declaration.
4845
4846 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4847             Jiong Wang  <jiong.wang@arm.com>
4848
4849         * aarch64-linux-nat.c
4850         (aarch64_linux_nat_target::read_description): Add pauth param.
4851         * aarch64-linux-tdep.c
4852         (aarch64_linux_core_read_description): Likewise.
4853         * aarch64-tdep.c (struct target_desc): Add in pauth.
4854         (aarch64_read_description): Add pauth param.
4855         (aarch64_gdbarch_init): Likewise.
4856         * aarch64-tdep.h (aarch64_read_description): Likewise.
4857         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4858         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4859         * features/Makefile: Add new files.
4860         * features/aarch64-pauth.c: New file.
4861         * features/aarch64-pauth.xml: New file.
4862
4863 2019-03-20  Tom Tromey  <tromey@adacore.com>
4864
4865         * infrun.c (handle_inferior_event): Rename from
4866         handle_inferior_event_1.  Create a scoped_value_mark.
4867         (handle_inferior_event): Remove.
4868
4869 2019-03-19  Tom Tromey  <tromey@adacore.com>
4870
4871         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4872         * infrun.h (print_stop_event): Add "displays" parameter.
4873         * infrun.c (print_stop_event): Add "displays" parameter.
4874
4875 2019-03-19  Pedro Alves  <palves@redhat.com>
4876
4877         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4878         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4879         to -1.  Fix TABs vs spaces.
4880         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4881         * tui/tui-out.h (tui_ui_out) Add intro comments.
4882         <m_line, m_start_of_line>: In-class initialize, and add describing
4883         comment.
4884
4885 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4886
4887         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4888         variable names.
4889         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4890
4891 2019-03-18  Pedro Alves  <palves@redhat.com>
4892             Eli Zaretskii <eliz@gnu.org>
4893
4894         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4895         m_line and m_start_of_line.
4896
4897 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4898
4899         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4900         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4901         it returns a newline.  This fixes a regression in TU mode, whereby
4902         the next line is output on the same screen line as the user input.
4903
4904 2019-03-18  Tom Tromey  <tromey@adacore.com>
4905
4906         * minsyms.c (minimal_symbol_reader::install): Remove call to
4907         obstack_blank.
4908
4909 2019-03-18  Pedro Alves  <palves@redhat.com>
4910
4911         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4912         New globals.
4913         (apply_style): New, factored out from ...
4914         (apply_ansi_escape): ... this.  Handle reverse video mode.
4915         (tui_set_reverse_mode): New function.
4916         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4917         * tui/tui-winsource.c (tui_show_source_line): Use
4918         tui_set_reverse_mode instead of setting A_STANDOUT.
4919         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4920         New setter methods.
4921
4922 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4923
4924         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4925         Handle tabs.
4926
4927 2019-03-18  Tom Tromey  <tromey@adacore.com>
4928
4929         * ada-lang.c (empty_array): Add "high" parameter.
4930         (ada_evaluate_subexp): Update.
4931
4932 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4933
4934         * unittests/string_view-selftests.c: Define
4935         _initialize_string_view_selftests unconditionally.
4936
4937 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4938
4939         PR gdb/24350
4940         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4941
4942 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4943
4944         PR gdb/24351
4945         * windows-nat.c (display_selector): Fix format specifiers.
4946
4947 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4948
4949         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4950         tui_refill_source_window instead of tui_refresh_win, to update the
4951         current execution line.  This fixes redisplay of the current line
4952         when stepping through the code with "next" or "step".
4953
4954 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4955
4956         * source-cache.c (source_cache::get_source_lines): Call
4957         find_source_lines to initialize s->nlines.  This fixes vertical
4958         scrolling of TUI source window when the DOWN arrow is pressed.
4959
4960 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4961
4962         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4963         linux-thread-db.c (_initialize_thread_db): Likewise.
4964
4965 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4966
4967         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4968         wclrtoeol in tui_show_source_line".  This reverts changes made in
4969         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4970
4971 2019-03-15  Tom Tromey  <tom@tromey.com>
4972
4973         * symtab.h (struct minimal_symbol): Derive from
4974         general_symbol_info.
4975         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4976         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4977         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4978         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4979         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4980         (MSYMBOL_SEARCH_NAME): Update.
4981         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4982         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4983         * minsyms.c (minimal_symbol_reader::record_full): Update.
4984
4985 2019-03-15  Tom Tromey  <tom@tromey.com>
4986
4987         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4988
4989 2019-03-15  Tom Tromey  <tom@tromey.com>
4990
4991         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4992         unique_xmalloc_ptr.
4993         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4994         Update.
4995         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4996         (build_minimal_symbol_hash_tables)
4997         (minimal_symbol_reader::install): Update.
4998
4999 2019-03-15  Tom Tromey  <tom@tromey.com>
5000
5001         * symtab.c (create_demangled_names_hash): Update.
5002         (symbol_set_names): Update.
5003         * objfiles.h (struct objfile_per_bfd_storage)
5004         <demangled_names_hash>: Now an htab_up.
5005         * objfiles.c (objfile_per_bfd_storage): Simplify.
5006
5007 2019-03-15  Tom Tromey  <tom@tromey.com>
5008
5009         * objfiles.h (struct objfile_per_bfd_storage): Declare
5010         destructor.
5011         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5012         New.
5013         (get_objfile_bfd_data): Use new.  Don't initialize
5014         language_of_main.
5015         (free_objfile_per_bfd_storage): Remove.
5016         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5017
5018 2019-03-15  Tom Tromey  <tom@tromey.com>
5019
5020         * symfile.c (reread_symbols): Update.
5021         * objfiles.c (objfile::objfile): Update.
5022         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5023         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5024         comment.
5025         (minimal_symbol_reader::install): Update.
5026         (terminate_minimal_symbol_table): Remove.
5027         * jit.c (jit_object_close_impl): Update.
5028
5029 2019-03-15  Tom Tromey  <tom@tromey.com>
5030
5031         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5032         initializations.
5033
5034 2019-03-15  Tom Tromey  <tom@tromey.com>
5035
5036         * objfiles.h (struct objfile_per_bfd_storage)
5037         <demangled_hash_languages>: Now a bitset.
5038         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5039         (lookup_minimal_symbol): Update.
5040
5041 2019-03-15  Tom Tromey  <tom@tromey.com>
5042
5043         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5044         Don't return the symbol.
5045         * coffread.c (record_minimal_symbol): Use record_full.
5046
5047 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5048
5049         The MS-Windows port of ncurses fails to switch to a color pair if
5050         one or both of the colors are the implicit default colors.  This
5051         change records the default colors when TUI is initialized, and
5052         then specifies them explicitly when a color pair uses the default
5053         colors.  This allows color styling in TUI mode on MS-Windows.
5054
5055         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5056         ncurses_norm_attr.
5057         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5058         colors in ncurses_norm_attr.
5059         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5060         "none", replace it with the default color recorded in
5061         ncurses_norm_attr.
5062
5063 2019-03-14  Tom Tromey  <tromey@adacore.com>
5064
5065         * source-cache.h (class source_cache) <get_source_lines>: Return
5066         std::string.
5067         * source-cache.c (source_cache::extract_lines): Handle case where
5068         first_pos==npos.  Return std::string.
5069         (source_cache::get_source_lines): Update.
5070
5071 2019-03-14  Tom Tromey  <tromey@adacore.com>
5072
5073         * NEWS: Add item for "style sources" commands.
5074         * source-cache.c (source_cache::get_source_lines): Check
5075         source_styling.
5076         * cli/cli-style.c (source_styling): New global.
5077         (_initialize_cli_style): Add "style sources" commands.
5078         (show_style_sources): New function.
5079         * cli/cli-style.h (source_styling): Declare.
5080
5081 2019-03-14  Pedro Alves  <palves@redhat.com>
5082             Tom Tromey  <tromey@adacore.com>
5083
5084         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5085         * tui/tui-winsource.c (tui_refill_source_window): New function,
5086         from...
5087         (tui_horizontal_source_scroll): ... here.  Move some logic.
5088         * cli/cli-style.c (set_style_enabled): Notify new observable.
5089         * tui/tui-hooks.c (tui_redisplay_source): New function.
5090         (tui_attach_detach_observers): Attach or detach
5091         tui_redisplay_source.
5092         * observable.h (source_styling_changed): New observable.
5093         * observable.c: Define source_styling_changed observable.
5094
5095 2019-03-13  Tom Tromey  <tromey@adacore.com>
5096
5097         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5098         (i386_gnu_nat_target::store_registers): Update.
5099         * target-debug.h (target_debug_print_std_string): New macro.
5100         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5101         * windows-tdep.c (display_one_tib): Update.
5102         * tui/tui-stack.c (tui_make_status_line): Update.
5103         * top.c (print_inferior_quit_action): Update.
5104         * thread.c (thr_try_catch_cmd): Update.
5105         (add_thread_with_info): Update.
5106         (thread_target_id_str): Update.
5107         (thr_try_catch_cmd): Update.
5108         (thread_command): Update.
5109         (thread_find_command): Update.
5110         * record-btrace.c (record_btrace_target::info_record)
5111         (record_btrace_resume_thread, record_btrace_target::resume)
5112         (record_btrace_cancel_resume, record_btrace_step_thread)
5113         (record_btrace_target::wait, record_btrace_target::wait)
5114         (record_btrace_target::wait, record_btrace_target::stop): Update.
5115         * progspace.c (print_program_space): Update.
5116         * process-stratum-target.c
5117         (process_stratum_target::thread_address_space): Update.
5118         * linux-fork.c (linux_fork_mourn_inferior)
5119         (detach_checkpoint_command, info_checkpoints_command)
5120         (linux_fork_context): Update.
5121         (linux_fork_detach): Update.
5122         (class scoped_switch_fork_info): Update.
5123         (delete_checkpoint_command): Update.
5124         * infrun.c (follow_fork_inferior): Update.
5125         (follow_fork_inferior): Update.
5126         (proceed_after_vfork_done): Update.
5127         (handle_vfork_child_exec_or_exit): Update.
5128         (follow_exec): Update.
5129         (displaced_step_prepare_throw): Update.
5130         (displaced_step_restore): Update.
5131         (start_step_over): Update.
5132         (resume_1): Update.
5133         (clear_proceed_status_thread): Update.
5134         (proceed): Update.
5135         (print_target_wait_results): Update.
5136         (do_target_wait): Update.
5137         (context_switch): Update.
5138         (stop_all_threads): Update.
5139         (restart_threads): Update.
5140         (finish_step_over): Update.
5141         (handle_signal_stop): Update.
5142         (switch_back_to_stepped_thread): Update.
5143         (keep_going_pass_signal): Update.
5144         (print_exited_reason): Update.
5145         (normal_stop): Update.
5146         * inferior.c (inferior_pid_to_str): Change return type.
5147         (print_selected_inferior): Update.
5148         (add_inferior): Update.
5149         (detach_inferior): Update.
5150         * dummy-frame.c (fprint_dummy_frames): Update.
5151         * dcache.c (dcache_info_1): Update.
5152         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5153         (btrace_fetch, btrace_clear): Update.
5154         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5155         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5156         type.
5157         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5158         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5159         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5160         * gdbarch.c, gdbarch.h: Rebuild.
5161         * gdbarch.sh (core_pid_to_str): Change return type.
5162         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5163         return type.
5164         (windows_nat_target::pid_to_str): Change return type.
5165         (windows_delete_thread): Update.
5166         (windows_nat_target::attach): Update.
5167         (windows_nat_target::files_info): Update.
5168         * target-delegates.c: Rebuild.
5169         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5170         return type.
5171         (sol_thread_target::pid_to_str): Change return type.
5172         * remote.c (class remote_target) <pid_to_str>: Change return
5173         type.
5174         (remote_target::pid_to_str): Change return type.
5175         (extended_remote_target::attach, remote_target::remote_stop_ns)
5176         (remote_target::remote_notif_remove_queued_reply)
5177         (remote_target::push_stop_reply, remote_target::disable_btrace):
5178         Update.
5179         (extended_remote_target::attach): Update.
5180         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5181         type.
5182         (gdbsim_target::pid_to_str): Change return type.
5183         * ravenscar-thread.c (struct ravenscar_thread_target)
5184         <pid_to_str>: Change return type.
5185         (ravenscar_thread_target::pid_to_str): Change return type.
5186         * procfs.c (class procfs_target) <pid_to_str>: Change return
5187         type.
5188         (procfs_target::pid_to_str): Change return type.
5189         (procfs_target::attach): Update.
5190         (procfs_target::detach): Update.
5191         (procfs_target::fetch_registers): Update.
5192         (procfs_target::store_registers): Update.
5193         (procfs_target::wait): Update.
5194         (procfs_target::files_info): Update.
5195         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5196         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5197         return type.
5198         (nto_procfs_target::pid_to_str): Change return type.
5199         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5200         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5201         return type.
5202         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5203         (exit_lwp): Update.
5204         (attach_proc_task_lwp_callback, get_detach_signal)
5205         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5206         (linux_nat_target::resume, wait_lwp, stop_callback)
5207         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5208         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5209         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5210         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5211         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5212         type.
5213         (inf_ptrace_target::attach): Update.
5214         (inf_ptrace_target::files_info): Update.
5215         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5216         type.
5217         (go32_nat_target::pid_to_str): Change return type.
5218         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5219         (gnu_nat_target::wait): Update.
5220         (gnu_nat_target::wait): Update.
5221         (gnu_nat_target::resume): Update.
5222         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5223         (fbsd_nat_target::wait): Update.
5224         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5225         type.
5226         (darwin_nat_target::attach): Update.
5227         * corelow.c (class core_target) <pid_to_str>: Change return type.
5228         (core_target::pid_to_str): Change return type.
5229         * target.c (normal_pid_to_str): Change return type.
5230         (default_pid_to_str): Likewise.
5231         (target_pid_to_str): Change return type.
5232         (target_translate_tls_address): Update.
5233         (target_announce_detach): Update.
5234         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5235         return type.
5236         (bsd_uthread_target::pid_to_str): Change return type.
5237         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5238         type.
5239         (bsd_kvm_target::pid_to_str): Change return type.
5240         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5241         return type.
5242         (aix_thread_target::pid_to_str): Change return type.
5243         * target.h (struct target_ops) <pid_to_str>: Change return type.
5244         (target_pid_to_str, normal_pid_to_str): Likewise.
5245         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5246         type.
5247         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5248         type.
5249         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5250         return type.
5251         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5252         type.
5253         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5254         type.
5255         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5256         return type.
5257
5258 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5259
5260         * NEWS: Mention that the new default MI version is 3.  Mention
5261         changes to the output of commands and events that deal with
5262         multi-location breakpoints.
5263         * breakpoint.c: Include "mi/mi-out.h".
5264         (print_one_breakpoint): Change output syntax if using MI version
5265         >= 3.
5266         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5267         New.
5268         (mi_multi_location_breakpoint_output_fixed): New.
5269         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5270         (mi_cmd_fix_multi_location_breakpoint_output): New.
5271         (mi_multi_location_breakpoint_output_fixed): New.
5272         * mi/mi-cmds.c (mi_cmds): Register command
5273         -fix-multi-location-breakpoint-output.
5274         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5275         interpreter "mi".
5276
5277 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5278
5279         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5280         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5281         instantiate mi_ui_out based on interpreter name.
5282         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5283         * mi/mi-main.c (mi_load_progress): Likewise.
5284
5285 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5286
5287         * NEWS: Combine separate "New targets" sections for 8.3.
5288
5289 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5290
5291         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5292         (ppcfbsd_init_abi): Install gdbarch
5293         "fetch_tls_load_module_address" and "get_thread_local_address"
5294         methods.
5295
5296 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5297
5298         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5299         (riscv_fbsd_init_abi): Install gdbarch
5300         "fetch_tls_load_module_address" and "get_thread_local_address"
5301         methods.
5302
5303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5304
5305         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5306         (i386fbsd_init_abi): Install gdbarch
5307         "fetch_tls_load_module_address" and "get_thread_local_address"
5308         methods.
5309
5310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5311
5312         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5313         (amd64fbsd_init_abi): Install gdbarch
5314         "fetch_tls_load_module_address" and "get_thread_local_address"
5315         methods.
5316
5317 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5318
5319         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5320         (struct fbsd_pspace_data): New type.
5321         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5322         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5323         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5324         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5325         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5326
5327 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5328
5329         * gdbtypes.c (lookup_struct_elt): New function.
5330         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5331         * gdbtypes.h (struct struct_elt): New type.
5332         (lookup_struct_elt): New prototype.
5333
5334 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5335
5336         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5337         remove disabled code block.
5338
5339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5340
5341         * gdbarch.sh (get_thread_local_address): New method.
5342         * gdbarch.h, gdbarch.c: Regenerate.
5343         * target.c (target_translate_tls_address): Use
5344         gdbarch_get_thread_local_address if present instead of
5345         target::get_thread_local_address.
5346
5347 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5348
5349         * target.h (target::get_thread_local_address): Update comment.
5350
5351 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5352
5353         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5354         objfile->separate_debug_objfile_backlink if not NULL.
5355
5356 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5357
5358         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5359         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5360         (amd64bsd_store_inferior_registers): Likewise.
5361         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5362         Enable segment base registers.
5363         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5364         PT_GETFSBASE and PT_GETGSBASE.
5365         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5366         PT_SETGSBASE.
5367         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5368         segment base registers.
5369         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5370
5371 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5372
5373         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5374         Update calls to i386_target_description to add 'segments'
5375         parameter.
5376         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5377         add segment base registers.
5378         * arch/i386.c (i386_create_target_description): Add 'segments'
5379         parameter to enable segment base registers.
5380         * arch/i386.h (i386_create_target_description): Likewise.
5381         * features/i386/32bit-segments.xml: New file.
5382         * features/i386/32bit-segments.c: Generate.
5383         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5384         call to i386_target_description to add 'segments' parameter.
5385         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5386         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5387         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5388         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5389         if feature is present.
5390         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5391         Add 'segments' parameter to call to i386_target_description.
5392         (i386_target_description): Add 'segments' parameter to enable
5393         segment base registers.
5394         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5395         to call to i386_target_description.
5396         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5397         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5398         Define I386_NUM_REGS.
5399         (i386_target_description): Add 'segments' parameter to enable
5400         segment base registers.
5401
5402 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5403
5404         PR/24325
5405         * source-cache.c: #undef open and close, to avoid unresolved
5406         externals during linking.
5407
5408 2019-03-12  Tom Tromey  <tromey@adacore.com>
5409
5410         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5411         const.  Add initializers.
5412         (_initialize_remote): Don't initialize ptid globals.
5413
5414 2019-03-12  Pedro Alves  <palves@redhat.com>
5415
5416         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5417
5418 2019-03-12  Pedro Alves  <palves@redhat.com>
5419
5420         * cp-name-parser.y (main): Remove unused 'len' variable.
5421
5422 2019-03-12  Tom Tromey  <tromey@adacore.com>
5423
5424         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5425         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5426
5427 2019-03-12  Tom Tromey  <tromey@adacore.com>
5428
5429         * linux-nat.c (iterate_over_lwps): Update.
5430         (stop_callback): Remove parameter.
5431         (stop_wait_callback, detach_callback, resume_set_callback)
5432         (select_singlestep_lwp_callback, set_ignore_sigint)
5433         (status_callback, resumed_callback, resume_clear_callback)
5434         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5435         data parameter.
5436         (linux_nat_target::detach, linux_nat_target::resume)
5437         (linux_stop_and_wait_all_lwps, select_event_lwp)
5438         (linux_nat_filter_event, linux_nat_wait_1)
5439         (linux_nat_target::kill, linux_nat_target::stop)
5440         (linux_nat_target::stop): Update.
5441         (linux_nat_resume_callback): Change type.
5442         (resume_stopped_resumed_lwps, count_events_callback)
5443         (select_event_lwp_callback): Likewise.
5444         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5445         * arm-linux-nat.c (struct update_registers_data): Remove.
5446         (update_registers_callback): Change type.
5447         (arm_linux_insert_hw_breakpoint1): Update.
5448         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5449         parameter.
5450         (x86_linux_dr_set_addr): Update.
5451         (x86_linux_dr_set_control): Update.
5452         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5453         (iterate_over_lwps): Use gdb::function_view.
5454         * nat/aarch64-linux-hw-point.c (struct
5455         aarch64_dr_update_callback_param): Remove.
5456         (debug_reg_change_callback): Change type.
5457         (aarch64_notify_debug_reg_change): Update.
5458         * s390-linux-nat.c (s390_refresh_per_info): Update.
5459
5460 2019-03-11  Tom Tromey  <tromey@adacore.com>
5461
5462         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5463         redundant assignment to "this_cu".
5464
5465 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5466
5467         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5468
5469 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5470
5471         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5472         from...
5473         (rank_one_type): ... this.
5474
5475 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5476
5477         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5478         from...
5479         (rank_one_type): ... this.
5480
5481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5482
5483         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5484         from...
5485         (rank_one_type): ... this.
5486
5487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5488
5489         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5490         from...
5491         (rank_one_type): ... this.
5492
5493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5494
5495         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5496         from...
5497         (rank_one_type): ... this.
5498
5499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5500
5501         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5502         from...
5503         (rank_one_type): ... this.
5504
5505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5506
5507         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5508         from...
5509         (rank_one_type): ... this.
5510
5511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5512
5513         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5514         from...
5515         (rank_one_type): ... this.
5516
5517 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5518
5519         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5520         from...
5521         (rank_one_type): ... this.
5522
5523 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5524
5525         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5526         from...
5527         (rank_one_type): ... this.
5528
5529 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5530
5531         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5532         from...
5533         (rank_one_type): ... this.
5534
5535 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5536
5537         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5538         from...
5539         (rank_one_type): ... this.
5540
5541 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5542
5543         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5544         inferior-events' shows the example events.
5545
5546 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5547
5548         Support styling on native MS-Windows console
5549
5550         PR/24315
5551         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5552         on MS-Windows if $TERM is not defined.
5553
5554         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5555
5556         * posix-hdep.c (gdb_console_fputs):
5557         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5558         functions.
5559         * ui-file.h (gdb_console_fputs): Add prototype.
5560
5561         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5562         back to fputs only if the former returns zero.
5563
5564 2019-03-07  Tom Tromey  <tom@tromey.com>
5565
5566         * symmisc.c (print_symbol_bcache_statistics): Update.
5567         (print_objfile_statistics): Update.
5568         * symfile.c (allocate_symtab): Update.
5569         * stabsread.c: Don't include bcache.h.
5570         * psymtab.h (struct psymbol_bcache): Don't declare.
5571         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5572         (psymbol_bcache_init, psymbol_bcache_free)
5573         (psymbol_bcache_get_bcache): Don't declare.
5574         * psymtab.c (struct psymbol_bcache): Remove.
5575         (psymtab_storage::psymtab_storage): Update.
5576         (psymtab_storage::~psymtab_storage): Update.
5577         (psymbol_bcache_init, psymbol_bcache_free)
5578         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5579         (add_psymbol_to_bcache): Update.
5580         (allocate_psymtab): Update.
5581         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5582         macro_cache>: No longer pointers.
5583         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5584         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5585         * macrotab.c (macro_bcache): Update.
5586         * macroexp.c: Don't include bcache.h.
5587         * gdbtypes.c (check_types_worklist): Update.
5588         (types_deeply_equal): Remove TRY/CATCH.  Update.
5589         * elfread.c (elf_symtab_read): Update.
5590         * dwarf2read.c: Don't include bcache.h.
5591         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5592         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5593         (print_bcache_statistics, bcache_memory_used): Don't declare.
5594         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5595         methods.  Rename all data members.
5596         * bcache.c (struct bcache): Move to bcache.h.
5597         (bcache::expand_hash_table): Rename from expand_hash_table.
5598         (bcache): Remove.
5599         (bcache::insert): Rename from bcache_full.
5600         (bcache::compare): Rename from bcache_compare.
5601         (bcache_xmalloc): Remove.
5602         (bcache::~bcache): Rename from bcache_xfree.
5603         (bcache::print_statistics): Rename from print_bcache_statistics.
5604         (bcache::memory_used): Rename from bcache_memory_used.
5605
5606 2019-03-07  Pedro Alves  <palves@redhat.com>
5607
5608         * infrun.c (normal_stop): Also check for
5609         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5610
5611 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5612
5613         * f-lang.c (value_from_host_double): Moved to...
5614         * value.c (value_from_host_double): ...here.
5615         * value.h (value_from_host_double): Declare.
5616         * guile/scm-math.c (vlscm_convert_typed_number): Use
5617         value_from_host_double.
5618         (vlscm_convert_number): Likewise.
5619         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5620         * python/py-value.c (convert_value_from_python): Likewise.
5621
5622 2019-03-06  Tom Tromey  <tom@tromey.com>
5623
5624         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5625
5626 2019-03-06  Tom Tromey  <tom@tromey.com>
5627
5628         * utils.h (free_current_contents): Don't declare.
5629         * utils.c (free_current_contents): Remove.
5630
5631 2019-03-06  Tom Tromey  <tom@tromey.com>
5632
5633         * top.c (quit_force): Update.
5634         * main.c (captured_command_loop): Update.
5635         * common/new-op.c (operator new): Update.
5636         * common/common-exceptions.c (struct catcher)
5637         <save_cleanup_chain>: Remove member.
5638         (exceptions_state_mc_init): Update.
5639         (exception_try_scope_entry): Return nullptr.
5640         (exception_try_scope_exit, exception_rethrow)
5641         (throw_exception_sjlj, throw_exception_cxx): Update.
5642         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5643         (all_cleanups, do_cleanups, discard_cleanups)
5644         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5645         (restore_cleanups, restore_final_cleanups): Don't declare.
5646         (do_final_cleanups): Remove parameter.
5647         * common/cleanups.c (cleanup_chain, make_cleanup)
5648         (make_cleanup_dtor, all_cleanups, do_cleanups)
5649         (discard_my_cleanups, discard_cleanups)
5650         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5651         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5652         (null_cleanup): Remove.
5653         (do_final_cleanups): Remove parameter.
5654
5655 2019-03-06  Tom Tromey  <tom@tromey.com>
5656
5657         * remote.c (remote_target::remote_parse_stop_reply): Use
5658         unique_xmalloc_ptr.
5659
5660 2019-03-06  Tom Tromey  <tom@tromey.com>
5661
5662         * stabsread.c (struct stabs_field_info): Rename from field_info.
5663         <list, fnlist>: Add initializers.
5664         <obstack>: New member.
5665         (read_member_functions, read_struct_fields, read_baseclasses):
5666         Allocate on obstack.  Don't use cleanups.
5667         (read_one_struct_field, read_member_functions, read_struct_fields)
5668         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5669         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5670         (read_struct_type): Update.
5671
5672 2019-03-06  Tom Tromey  <tom@tromey.com>
5673
5674         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5675         * common/filestuff.h (make_cleanup_close): Don't declare.
5676         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5677         Remove.
5678
5679 2019-03-06  Tom Tromey  <tom@tromey.com>
5680
5681         * solib-aix.c: Use make_scope_exit.
5682
5683 2019-03-06  Tom Tromey  <tom@tromey.com>
5684
5685         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5686         Use make_scope_exit.
5687
5688 2019-03-06  Tom Tromey  <tom@tromey.com>
5689
5690         * solib-svr4.c (disable_probes_interface): Remove parameter.
5691         (svr4_handle_solib_event): Use make_scope_exit.
5692
5693 2019-03-06  Tom Tromey  <tom@tromey.com>
5694
5695         * remote.c (struct stop_reply_deleter): Remove.
5696         (stop_reply_up): Update.
5697         (struct stop_reply): Derive from notif_event.  Don't typedef.
5698         <regcache>: Now a std::vector.
5699         (stop_reply_xfree): Remove.
5700         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5701         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5702         (remote_target::discard_pending_stop_replies): Use delete.
5703         (remote_target::remote_parse_stop_reply): Update.
5704         (remote_target::process_stop_reply): Update.
5705         * remote-notif.h (struct notif_event): Add virtual destructor.
5706         Remove "dtr" member.
5707         (struct notif_client) <alloc_event>: Return a unique_ptr.
5708         (notif_event_xfree): Don't declare.
5709         (notif_event_up): New typedef.
5710         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5711         (notif_event_xfree, do_notif_event_xfree): Remove.
5712         (remote_notif_state_xfree): Update.
5713
5714 2019-03-06  Tom Tromey  <tom@tromey.com>
5715
5716         * infrun.c (displaced_step_clear_cleanup): Now a
5717         forward_scope_exit type.
5718         (displaced_step_prepare_throw): Update.
5719         (displaced_step_fixup): Update.
5720
5721 2019-03-06  Tom Tromey  <tom@tromey.com>
5722
5723         * inferior.h (class inferior): Update comment.
5724         * gdbthread.h (class thread_info): Update comment.
5725
5726 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5727             Tom Tromey  <tom@tromey.com>
5728
5729         * stabsread.h (struct stab_section_list): Remove.
5730         (coffstab_build_psymtabs): Update.
5731         * dbxread.c (symbuf_sections): Now a std::vector.
5732         (sect_idx): New global.
5733         (fill_symbuf): Update.
5734         (coffstab_build_psymtabs): Change type of stabsects parameter.
5735         Update.
5736         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5737         std::vector.
5738         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5739         (coff_locate_sections): Update.
5740         (coff_symfile_read): Remove cleanups.  Update.
5741         (init_stringtab): Add storage parameter.
5742         (free_stringtab, free_stringtab_cleanup): Remove.
5743         (init_lineno): Add storage parameter.
5744         (free_linetab, free_linetab_cleanup): Remove.
5745
5746 2019-03-06  Pedro Alves  <palves@redhat.com>
5747
5748         * linux-fork.c (fork_info::clobber_regs): Delete.
5749         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5750         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5751         comment.  Adjust.
5752         (scoped_switch_fork_info::scoped_switch_fork_info)
5753         (checkpoint_command, linux_fork_context): Adjust
5754         fork_save_infrun_state calls.
5755
5756 2019-03-06  Pedro Alves  <palves@redhat.com>
5757
5758         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5759         (inf_has_multiple_threads): Return 'bool' and rewrite using
5760         inferior_info::threads().
5761
5762 2019-03-06  Pedro Alves  <palves@redhat.com>
5763
5764         * linux-fork.c: Include <list>.
5765         (fork_list): Now a std::list instance.
5766         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5767         (forks_exist_p, find_last_fork): Adjust.
5768         (new_fork): Delete.
5769         (one_fork_p): New.
5770         (add_fork): Adjust.
5771         (free_fork): Delete, folded into fork_info::~fork_info().
5772         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5773         Adjust.
5774         (init_fork_list): Delete.
5775         (linux_fork_killall, linux_fork_mourn_inferior)
5776         (linux_fork_detach, info_checkpoints_command): Adjust.
5777         (_initialize_linux_fork): No longer call init_fork_list.
5778
5779 2019-03-06  Pedro Alves  <palves@redhat.com>
5780
5781         * linux-fork.c (new_fork): New, split out of ...
5782         (add_fork): ... this.  Return void.  Move "first fork" special
5783         case from here, to ...
5784         (checkpoint_command): ... here.
5785         * linux-linux.h (add_fork): Return void.
5786
5787 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5788
5789         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5790
5791 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5792             Chris January  <chris.january@arm.com>
5793             David Lecomber  <david.lecomber@arm.com>
5794
5795         * f-exp.y: New token, UNOP_INTRINSIC.
5796         (exp): New pattern using UNOP_INTRINSIC token.
5797         (f77_keywords): Add 'abs' keyword.
5798         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5799         (value_from_host_double): New function.
5800         (evaluate_subexp_f): Support UNOP_ABS.
5801
5802 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5803
5804         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5805         types.
5806
5807 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5808
5809         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5810         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5811         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5812
5813 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5814
5815         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5816
5817 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5818             Chris January  <chris.january@arm.com>
5819
5820         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5821         * f-exp.y: Define 'KIND' token.
5822         (exp): New pattern for KIND expressions.
5823         (ptype): Handle types with a kind extension.
5824         (direct_abs_decl): Extend to spot kind extensions.
5825         (f77_keywords): Add 'kind' to the list.
5826         (push_kind_type): New function.
5827         (convert_to_kind_type): New function.
5828         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5829         * parse.c (operator_length_standard): Likewise.
5830         * parser-defs.h (enum type_pieces): Add tp_kind.
5831         * std-operator.def: Add UNOP_KIND.
5832
5833 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5834
5835         * f-exp.y (f_parse): Set yydebug.
5836
5837 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5838
5839         * f-lang.c (evaluate_subexp_f): New function.
5840         (exp_descriptor_f): New global.
5841         (f_language_defn): Use exp_descriptor_f instead of
5842         exp_descriptor_standard.
5843
5844 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5845
5846         * f-exp.y (struct token): Add comments.
5847         (dot_ops): Remove uppercase versions and the end marker.
5848         (f77_keywords): Likewise.
5849         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5850         entries in the dot_ops array are case insensitive, and use
5851         strncasecmp to compare strings.  Also some whitespace cleanup in
5852         this area.  Similar for the f77_keywords array, except entries in
5853         this list might be case sensitive.
5854
5855 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5856
5857         * f-exp.y (struct f77_boolean_val): Add comments.
5858         (boolean_values): Remove uppercase versions, and end marker.
5859         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5860         and use strncasecmp to achieve case insensitivity.  Additionally,
5861         perform whitespace cleanup around this code.
5862
5863 2019-03-06  Tom Tromey  <tromey@adacore.com>
5864
5865         * remote-sim.c (gdbsim_target_open): Use result of
5866         gdb_argv::release.
5867
5868 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5869         Dirk Schubert  <dirk.schubert@arm.com>
5870         Chris January  <chris.january@arm.com>
5871
5872         * eval.c (evaluate_subexp_standard): Call Fortran argument
5873         wrapping logic.
5874         * f-lang.c (struct value): A value which can be passed into a
5875         Fortran function call.
5876         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5877         where appropriate.
5878         (struct type): Value ready for a Fortran function call.
5879         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5880         is needed.
5881         * f-lang.h (fortran_argument_convert): Declaration.
5882         (fortran_preserve_arg_pointer): Declaration.
5883         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5884
5885 2019-03-05  Tom Tromey  <tromey@adacore.com>
5886
5887         * python/py-prettyprint.c (print_string_repr): Remove #if.
5888         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5889
5890 2019-03-05  Tom Tromey  <tromey@adacore.com>
5891
5892         * target.c (the_dummy_target): Move later.  Change type to
5893         "dummy_target".
5894         (initialize_targets): Don't initialize the_dummy_target.
5895
5896 2019-03-05  Tom Tromey  <tromey@adacore.com>
5897
5898         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5899         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5900
5901 2019-03-05  Tom Tromey  <tromey@adacore.com>
5902
5903         * windows-nat.c (windows_nat_target::attach)
5904         (windows_nat_target::detach): Don't call gdb_flush.
5905         * valprint.c (generic_val_print, val_print, val_print_string):
5906         Don't call gdb_flush.
5907         * utils.c (defaulted_query): Don't call gdb_flush.
5908         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5909         * target.c (target_announce_detach): Don't call gdb_flush.
5910         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5911         * remote.c (extended_remote_target::attach): Don't call
5912         gdb_flush.
5913         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5914         * printcmd.c (do_examine): Don't call gdb_flush.
5915         (info_display_command): Don't call gdb_flush.
5916         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5917         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5918         * memattr.c (info_mem_command): Don't call gdb_flush.
5919         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5920         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5921         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5922         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5923         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5924         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5925         (gnu_nat_target::detach): Don't call gdb_flush.
5926         * f-valprint.c (f_val_print): Don't call gdb_flush.
5927         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5928         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5929         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5930         gdb_flush.
5931         * c-valprint.c (c_val_print): Don't call gdb_flush.
5932         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5933
5934 2019-03-05  Tom Tromey  <tromey@adacore.com>
5935
5936         * varobj.c (update_dynamic_varobj_children): Update.
5937         (install_default_visualizer): Use reset, not release.
5938         * value.c (set_internalvar): Update.
5939         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5940         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5941         ATTRIBUTE_UNUSED_RESULT.
5942
5943 2019-03-05  Tom Tromey  <tromey@adacore.com>
5944
5945         * remote.c (class scoped_remote_fd) <release>: Add
5946         ATTRIBUTE_UNUSED_RESULT.
5947
5948 2019-03-05  Tom Tromey  <tromey@adacore.com>
5949
5950         * macroexp.c (struct macro_buffer) <release>: Add
5951         ATTRIBUTE_UNUSED_RESULT.
5952
5953 2019-03-05  Tom Tromey  <tromey@adacore.com>
5954
5955         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5956         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5957         ATTRIBUTE_UNUSED_RESULT.
5958
5959 2019-03-05  Tom Tromey  <tromey@adacore.com>
5960
5961         * common/scoped_fd.h (class scoped_fd) <release>: Add
5962         ATTRIBUTE_UNUSED_RESULT.
5963
5964 2019-03-05  Tom Tromey  <tromey@adacore.com>
5965
5966         * parser-defs.h (struct parser_state) <release>: Add
5967         ATTRIBUTE_UNUSED_RESULT.
5968
5969 2019-03-05  Tom Tromey  <tromey@adacore.com>
5970
5971         * utils.h (class gdb_argv) <release>: Add
5972         ATTRIBUTE_UNUSED_RESULT.
5973         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5974
5975 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5976
5977         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5978         for-loop range, to avoid compiler warnings.
5979
5980         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5981         avoid compiler warnings about unused variables.
5982
5983         * NEWS: Mention end of support for native debugging on MS-Windows
5984         before XP.
5985
5986         PR gdb/24292
5987         * common/netstuff.c:
5988         * gdbserver/gdbreplay.c
5989         * gdbserver/remote-utils.c:
5990         * ser-tcp.c:
5991         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5992         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5993         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5994         'getaddrinfo' and 'freeaddrinfo' were not available before
5995         Windows XP, and mingw.org's MinGW headers by default define
5996         _WIN32_WINNT to 0x500.
5997
5998 2019-03-01  Gary Benson <gbenson@redhat.com>
5999
6000         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6001
6002 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6003             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6004
6005         PR gdb/8527
6006         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6007         set_sigint_trap, clear_sigint_trap.
6008
6009 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6010
6011         * target.c (target_detach): Clear the regcache and the
6012         frame cache.
6013
6014 2019-02-27  Pedro Alves  <palves@redhat.com>
6015
6016         * utils.c (set_screen_size): When we cap the height/width sizes,
6017         tweak the corresponding command variable to show "unlimited":
6018
6019 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6020             Pedro Alves  <palves@redhat.com>
6021
6022         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6023         before calling rl_set_screen_size.
6024
6025 2019-02-27  Tom Tromey  <tromey@adacore.com>
6026
6027         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6028         define.
6029         * python/py-value.c: Remove Python 2.4 workaround.
6030         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6031         workaround.
6032         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6033         Python 2.4 workaround.
6034         * python/python-internal.h: Remove Python 2.4 comment.
6035         (Py_ssize_t): Don't define.
6036         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6037         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6038         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6039         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6040         * python/python.c (do_start_initialization): Remove Python 2.4
6041         workaround.
6042         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6043         (print_children): Remove Python 2.4 workaround.
6044         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6045         workaround.
6046         (CHARBUFFERPROC_NAME): Remove.
6047         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6048         Python 2.4 workaround.
6049
6050 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6051
6052         * NEWS: Note minimum Python version.
6053
6054 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6055
6056         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6057         code from these functions.  Remove corresponding ifdefs.  Use
6058         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6059         Remove gotos and target of gotos.
6060         (infpy_search_memory): Likewise.
6061
6062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6063
6064         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6065         (hppa_gdbarch_init): Don't register deleted functions with
6066         gdbarch.
6067
6068 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6069
6070         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6071         (h8300_unwind_sp): Delete.
6072         (h8300_dummy_id): Delete.
6073         (h8300_gdbarch_init): Don't register deleted functions with
6074         gdbarch.
6075
6076 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6077
6078         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6079         (ft32_unwind_pc): Delete.
6080         (ft32_unwind_sp): Delete.
6081         (ft32_gdbarch_init): Don't register deleted functions with
6082         gdbarch.
6083
6084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6085
6086         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6087         (frv_unwind_pc): Delete.
6088         (frv_unwind_sp): Delete.
6089         (frv_gdbarch_init): Don't register deleted functions with
6090         gdbarch.
6091
6092 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6093
6094         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6095         (riscv_unwind_pc): Delete.
6096         (riscv_unwind_sp): Delete.
6097         (riscv_gdbarch_init): Don't register deleted functions with
6098         gdbarch.
6099
6100 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6101
6102         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6103         (csky_unwind_pc): Delete.
6104         (csky_unwind_sp): Delete.
6105         (csky_gdbarch_init): Don't register deleted functions with
6106         gdbarch.
6107
6108 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6109
6110         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6111         (cris_unwind_pc): Delete.
6112         (cris_unwind_sp): Delete.
6113         (cris_gdbarch_init): Don't register deleted functions with
6114         gdbarch.
6115
6116 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6117
6118         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6119         (bfin_unwind_pc): Delete.
6120         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6121
6122 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6123
6124         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6125         (arm_unwind_pc): Delete.
6126         (arm_unwind_sp): Delete.
6127         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6128
6129 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6130
6131         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6132         (arc_unwind_pc): Delete.
6133         (arc_unwind_sp): Delete.
6134         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6135
6136 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6137
6138         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6139         (alpha_unwind_pc): Delete.
6140         (alpha_gdbarch_init): Don't register deleted functions with
6141         gdbarch.
6142
6143 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6144
6145         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6146         (aarch64_unwind_pc): Delete.
6147         (aarch64_unwind_sp): Delete.
6148         (aarch64_gdbarch_init): Don't register deleted functions with
6149         gdbarch.
6150
6151 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6152
6153         * gdbtypes.c (type_align): Don't consider static members when
6154         computing structure alignment.
6155
6156 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6157
6158         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6159         return 0 for other types.
6160         * arch-utils.c (default_type_align): Always return 0.
6161         * gdbarch.h: Regenerate.
6162         * gdbarch.sh (type_align): Extend comment.
6163         * gdbtypes.c (type_align): Add additional comments, always call
6164         gdbarch_type_align before applying the default rules.
6165         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6166         generic code will then apply a suitable default.
6167         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6168         types, return 0 for other types.
6169
6170 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6171
6172         * NEWS: Create a new section for the next release branch.
6173         Rename the section of the current branch, now that it has
6174         been cut.
6175
6176 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6177
6178         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6179         * version.in: Bump version to 8.3.50.DATE-git.
6180
6181 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6182
6183         * aix-thread.c (ptid_cmp): Remove unused variable.
6184         (get_signaled_thread): Likewise.
6185         (store_regs_user_thread): Likewise.
6186         (store_regs_kernel_thread): Likewise.
6187         (fetch_regs_kernel_thread): Remove shadowed variable.
6188
6189 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6190
6191         * features/riscv/32bit-cpu.xml: Add register numbers.
6192         * features/riscv/32bit-fpu.c: Regenerate.
6193         * features/riscv/32bit-fpu.xml: Add register numbers.
6194         * features/riscv/64bit-cpu.xml: Add register numbers.
6195         * features/riscv/64bit-fpu.c: Regenerate.
6196         * features/riscv/64bit-fpu.xml: Add register numbers.
6197
6198 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6199
6200         * NEWS: Mention two argument form of gdb.Value constructor.
6201         * python/py-value.c (convert_buffer_and_type_to_value): New
6202         function.
6203         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6204         Add support for handling an optional second argument.  Call
6205         convert_buffer_and_type_to_value as appropriate.
6206         * python/python-internal.h (Py_buffer_deleter): New struct.
6207         (Py_buffer_up): New typedef.
6208
6209 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6210
6211         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6212         instead of releasing ownership.
6213
6214 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6215
6216         * dwarf2read.c (open_and_init_dwp_file): Call
6217         elf_numsections instead of bfd_count_sections to initialize
6218         dwp_file->num_sections.
6219
6220 2019-02-25  Tom Tromey  <tromey@adacore.com>
6221
6222         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6223
6224 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6225
6226         * gcore.in: Add '--readnever' option when invoking GDB.
6227
6228 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6229
6230         * MAINTAINERS: Update my email address.
6231
6232 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6233
6234         * build-id.c (build_id_to_debug_bfd_1): New function.
6235         (build_id_to_debug_bfd): Look for separate debug file in
6236         sysroot.
6237
6238 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6239
6240         * gdbarch.sh: Update the copyright year range that is placed into
6241         generated files.
6242
6243 2019-02-22  Keith Seitz  <keiths@redhat.com>
6244
6245         PR symtab/23853
6246         * linespec.c (create_sals_line_offset): Search for the default
6247         symtab's filename instead of its fullname.
6248
6249 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6250
6251         * NEWS: Update style defaults.
6252
6253 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6254
6255         * main.c (captured_main_1): Disable styling in batch mode.
6256
6257 2019-02-20  Tom Tromey  <tom@tromey.com>
6258
6259         * symtab.c (symtab_symbol_info): Fix typos.
6260
6261 2019-02-20  Tom Tromey  <tromey@adacore.com>
6262
6263         * findcmd.c (_initialize_mem_search): Use upper case for
6264         metasyntactic variables.
6265
6266 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6267
6268         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6269         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6270
6271 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6272
6273         * top.h (source_file_name): Change to std::string.
6274         * top.c (source_file_name): Likewise.
6275         (command_line_input): Adjust.
6276         * cli/cli-script.c (script_from_file): Adjust.
6277
6278 2019-02-19  Tom Tromey  <tromey@adacore.com>
6279
6280         * ravenscar-thread.c
6281         (ravenscar_thread_target::update_thread_list): Don't call
6282         ada_build_task_list.
6283         * ada-lang.h (ada_build_task_list): Don't declare.
6284         * ada-tasks.c (struct ada_tasks_inferior_data)
6285         <task_list_valid_p>: Now bool.
6286         (read_known_tasks, ada_task_list_changed)
6287         (ada_tasks_invalidate_inferior_data): Update.
6288         (read_known_tasks_array): Return bool.
6289         (read_known_tasks_list): Likewise.
6290         (read_known_tasks): Return void.
6291         (ada_build_task_list): Now static.
6292
6293 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6294
6295         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6296         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6297
6298 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6299
6300         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6301         variant for ada_tasks_pspace_data_handle and
6302         ada_tasks_inferior_data_handle.
6303         (ada_tasks_pspace_data_cleanup): New function.
6304         (ada_tasks_inferior_data_cleanup): New function.
6305
6306 2019-02-17  Tom Tromey  <tom@tromey.com>
6307
6308         * macrotab.h (macro_source_fullname): Return a std::string.
6309         * macrotab.c (macro_include, check_for_redefinition)
6310         (macro_undef, macro_lookup_definition, foreach_macro)
6311         (foreach_macro_in_scope): Update.
6312         (macro_source_fullname): Return a std::string.
6313         * macrocmd.c (show_pp_source_pos): Update.
6314
6315 2019-02-17  Tom Tromey  <tom@tromey.com>
6316
6317         * macrocmd.c (show_pp_source_pos): Style the file names.
6318
6319 2019-02-17  Tom Tromey  <tom@tromey.com>
6320
6321         PR tui/24197:
6322         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6323
6324 2019-02-17  Tom Tromey  <tom@tromey.com>
6325
6326         * ada-lang.c (user_select_syms): Use filtered printing.
6327         * utils.c (wrap_style): New global.
6328         (desired_style): Remove.
6329         (emit_style_escape): Add stream parameter.
6330         (set_output_style, reset_terminal_style, prompt_for_continue):
6331         Update.
6332         (flush_wrap_buffer): Only flush gdb_stdout.
6333         (wrap_here): Set wrap_style.
6334         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6335         treat escape sequences as a character.  Change when wrap buffer is
6336         flushed.
6337         (fputs_styled): Do not set the output style when the default is
6338         requested.
6339         * ui-style.h (struct ui_file_style) <is_default>: New method.
6340         * source.c (print_source_lines_base): Emit escape sequences in one
6341         piece.
6342
6343 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6344
6345         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6346         integers and enumeration types.
6347
6348 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6349
6350         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6351         instead of lookup_symbol_in_language
6352         (do_exact_match): New function.
6353         (ada_get_symbol_name_matcher): Return do_exact_match when
6354         doing a verbatim match.
6355
6356 2019-02-15  Tom Tromey  <tromey@adacore.com>
6357
6358         * ravenscar-thread.c (ravenscar_thread_target::resume)
6359         (ravenscar_thread_target::wait): Special case wildcard requests.
6360
6361 2019-02-15  Tom Tromey  <tromey@adacore.com>
6362
6363         * ravenscar-thread.c (base_ptid): Remove.
6364         (struct ravenscar_thread_target) <close>: New method.
6365         <m_base_ptid>: New member.
6366         <update_inferior_ptid, active_task, task_is_currently_active,
6367         runtime_initialized>: Declare methods.
6368         <ravenscar_thread_target>: Add constructor.
6369         (ravenscar_thread_target::task_is_currently_active)
6370         (ravenscar_thread_target::update_inferior_ptid)
6371         (ravenscar_runtime_initialized): Rename.  Now methods.
6372         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6373         (ravenscar_thread_target::update_thread_list): Update.
6374         (ravenscar_thread_target::active_task): Now method.
6375         (ravenscar_thread_target::store_registers)
6376         (ravenscar_thread_target::prepare_to_store)
6377         (ravenscar_thread_target::prepare_to_store)
6378         (ravenscar_thread_target::mourn_inferior): Update.
6379         (ravenscar_inferior_created): Use "new" to create target.
6380         (ravenscar_thread_target::get_ada_task_ptid): Update.
6381         (_initialize_ravenscar): Don't initialize base_ptid.
6382         (ravenscar_ops): Remove global.
6383
6384 2019-02-15  Tom Tromey  <tromey@adacore.com>
6385
6386         * target.h (push_target): Declare new overload.
6387         * target.c (push_target): New overload, taking an rvalue reference.
6388         * remote.c (remote_target::open_1): Use push_target overload.
6389         * corelow.c (core_target_open): Use push_target overload.
6390
6391 2019-02-15  Tom Tromey  <tromey@adacore.com>
6392
6393         * ravenscar-thread.c (is_ravenscar_task)
6394         (ravenscar_task_is_currently_active): Return bool.
6395         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6396         (_initialize_ravenscar): Remove "(void)".
6397         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6398         Return bool.
6399
6400 2019-02-15  Tom Tromey  <tromey@adacore.com>
6401
6402         * ravenscar-thread.c (ravenscar_runtime_initializer)
6403         (has_ravenscar_runtime, get_running_thread_id)
6404         (ravenscar_thread_target::resume): Fix indentation.
6405
6406 2019-02-15  Tom Tromey  <tromey@adacore.com>
6407
6408         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6409         from ravenscar_arch_ops.
6410         (sparc_ravenscar_ops::fetch_registers)
6411         (sparc_ravenscar_ops::store_registers): Now methods.
6412         (sparc_ravenscar_prepare_to_store): Remove.
6413         (sparc_ravenscar_ops): Redefine.
6414         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6415         methods and destructor.  Remove members.
6416         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6417         (ravenscar_thread_target::store_registers)
6418         (ravenscar_thread_target::prepare_to_store): Update.
6419         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6420         Remove.
6421         (struct ppc_ravenscar_powerpc_ops): Derive from
6422         ravenscar_arch_ops.
6423         (ppc_ravenscar_powerpc_ops::fetch_registers)
6424         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6425         (ppc_ravenscar_powerpc_ops): Redefine.
6426         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6427         (ppc_ravenscar_e500_ops::fetch_registers)
6428         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6429         (ppc_ravenscar_e500_ops): Redefine.
6430         * aarch64-ravenscar-thread.c
6431         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6432         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6433         (aarch64_ravenscar_fetch_registers)
6434         (aarch64_ravenscar_store_registers): Now methods.
6435         (aarch64_ravenscar_ops): Redefine.
6436
6437 2019-02-15  Tom Tromey  <tromey@adacore.com>
6438
6439         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6440         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6441         (ravenscar_thread_target::stopped_by_watchpoint)
6442         (ravenscar_thread_target::stopped_data_address)
6443         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6444
6445 2019-02-15  Tom Tromey  <tromey@adacore.com>
6446
6447         * ravenscar-thread.c: Fix some typos.
6448
6449 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6450             Tom Tromey  <tromey@adacore.com>
6451
6452         * ada-lang.c (ada_exception_sal): Change addr_string to a
6453         std::string.
6454         (create_ada_exception_catchpoint): Update.
6455
6456 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6457             Tom Tromey  <tromey@adacore.com>
6458
6459         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6460         (bp_location_ops): Remove.
6461         (base_breakpoint_allocate_location): Update.
6462         (free_bp_location): Update.
6463         * ada-lang.c (class ada_catchpoint_location)
6464         <ada_catchpoint_location>: Remove ops parameter.
6465         (ada_catchpoint_location_dtor): Remove.
6466         (ada_catchpoint_location_ops): Remove.
6467         (allocate_location_exception): Update.
6468         * breakpoint.h (struct bp_location_ops): Remove.
6469         (class bp_location) <bp_location>: Remove bp_location_ops
6470         parameter.
6471         <~bp_location>: Add destructor.
6472         <ops>: Remove.
6473
6474 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6475             Pedro Alves  <palves@redhat.com>
6476
6477         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6478         'PATH_MAX'.
6479
6480 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6481             Samuel Thibault  <samuel.thibault@gnu.org>
6482             Thomas Schwinge  <thomas@codesourcery.com>
6483
6484         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6485         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6486
6487 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6488
6489         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6490         (check_empty): Use "const char *".
6491
6492         * gnu-nat.c (gnu_nat_target::detach): Instead of
6493         'detach_inferior (pid)' call
6494         'detach_inferior (find_inferior_pid (pid))'.
6495
6496         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6497         'nat/fork-inferior.o'.
6498         * gnu-nat.c: #include "nat/fork-inferior.h".
6499
6500         * gnu-nat.c (gnu_nat_target::detach): Instead of
6501         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6502         * gnu-nat.h: #include "inf-child.h".
6503         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6504         'i386_gnu_nat_target::fetch_registers'.
6505         (gnu_store_registers): Rename/move to
6506         'i386_gnu_nat_target::store_registers'.
6507
6508         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6509         * gnu-nat.h (mach_thread_info): New function.
6510         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6511
6512         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6513
6514 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6515
6516         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6517
6518 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6519
6520         * windows-nat.c (windows_add_thread): Add new parameter
6521         "main_thread_p" with default value set to false.  Update
6522         function documentation as well as all callers.
6523         (windows_delete_thread): Likewise.
6524         (fake_create_process): Update call to windows_add_thread.
6525         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6526         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6527         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6528         call to windows_delete_thread.
6529
6530 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6531
6532         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6533
6534 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6535
6536         * symfile.c (find_separate_debug_file): Use canonical path of
6537         sysroot with child_path instead of gdb_sysroot if it is valid.
6538
6539 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6540
6541         * symfile.c (find_separate_debug_file): Use child_path to
6542         determine if an object file is under a sysroot.
6543
6544 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6545
6546         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6547         unittests/child-path-selftests.c.
6548         * common/pathstuff.c (child_path): New function.
6549         * common/pathstuff.h (child_path): New prototype.
6550         * unittests/child-path-selftests.c: New file.
6551
6552 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6553
6554         * symfile.c (find_separate_debug_file): Look for separate debug
6555         files in debug directories under the sysroot.
6556
6557 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6558
6559         * symtab.h (struct minimal_symbol data_p): New const method.
6560         (struct minimal_symbol text_p): Likewise.
6561         * symtab.c (output_source_filename): Use file name style
6562         to print file name.
6563         (print_symbol_info): Likewise.
6564         (print_msymbol_info): Use address style to print addresses.
6565         Use function name style to print executable text symbols.
6566         (expand_symtab_containing_pc): Use data_p.
6567         (find_pc_sect_compunit_symtab): Likewise.
6568
6569 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6570
6571         * breakpoint.c (describe_other_breakpoints): Use address style
6572         to print addresses.
6573         (say_where): Likewise.
6574
6575 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6576
6577         * ada-typeprint.c (print_func_type): Print function name
6578         style to print function name.
6579         * c-typeprint.c (c_print_type_1): Likewise.
6580
6581 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6582
6583         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6584         for execve.
6585
6586 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6587
6588         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6589         type_stack.
6590
6591 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6592
6593         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6594         TYPE_CODE_REF types.
6595
6596 2019-02-08  Jim Wilson  <jimw@sifive.com>
6597
6598         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6599         (riscv_linux_fregset): New.
6600         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6601
6602 2019-02-07  Tom Tromey  <tom@tromey.com>
6603
6604         * thread.c (thread_cancel_execution_command): Update.
6605         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6606         methods.
6607         (struct thread_fsm_ops): Remove.
6608         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6609         (thread_fsm_should_stop, thread_fsm_return_value)
6610         (thread_fsm_set_finished, thread_fsm_finished_p)
6611         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6612         Don't declare.
6613         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6614         * infrun.c (clear_proceed_status_thread)
6615         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6616         (print_stop_event): Update.
6617         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6618         Add constructor.
6619         (step_command_fsm_ops): Remove.
6620         (new_step_command_fsm): Remove.
6621         (step_1): Update.
6622         (step_command_fsm::should_stop): Rename from
6623         step_command_fsm_should_stop.
6624         (step_command_fsm::clean_up): Rename from
6625         step_command_fsm_clean_up.
6626         (step_command_fsm::do_async_reply_reason): Rename from
6627         step_command_fsm_async_reply_reason.
6628         (struct until_next_fsm): Inherit from thread_fsm.  Add
6629         constructor.
6630         (until_next_fsm_ops): Remove.
6631         (new_until_next_fsm): Remove.
6632         (until_next_fsm::should_stop): Rename from
6633         until_next_fsm_should_stop.
6634         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6635         (until_next_fsm::do_async_reply_reason): Rename from
6636         until_next_fsm_async_reply_reason.
6637         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6638         constructor.  Change type of breakpoint.
6639         (finish_command_fsm_ops): Remove.
6640         (new_finish_command_fsm): Remove.
6641         (finish_command_fsm::should_stop): Rename from
6642         finish_command_fsm_should_stop.
6643         (finish_command_fsm::clean_up): Rename from
6644         finish_command_fsm_clean_up.
6645         (finish_command_fsm::return_value): Rename from
6646         finish_command_fsm_return_value.
6647         (finish_command_fsm::do_async_reply_reason): Rename from
6648         finish_command_fsm_async_reply_reason.
6649         (finish_command): Update.
6650         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6651         Add constructor.
6652         (call_thread_fsm_ops): Remove.
6653         (call_thread_fsm::call_thread_fsm): Rename from
6654         new_call_thread_fsm.
6655         (call_thread_fsm::should_stop): Rename from
6656         call_thread_fsm_should_stop.
6657         (call_thread_fsm::should_notify_stop): Rename from
6658         call_thread_fsm_should_notify_stop.
6659         (run_inferior_call, call_function_by_hand_dummy): Update.
6660         * cli/cli-interp.c (should_print_stop_to_console): Update.
6661         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6662         Add constructor.  Change type of location_breakpoint,
6663         caller_breakpoint.
6664         (until_break_fsm_ops): Remove.
6665         (new_until_break_fsm): Remove.
6666         (until_break_fsm::should_stop): Rename from
6667         until_break_fsm_should_stop.
6668         (until_break_fsm::clean_up): Rename from
6669         until_break_fsm_clean_up.
6670         (until_break_fsm::do_async_reply_reason): Rename from
6671         until_break_fsm_async_reply_reason.
6672         (until_break_command): Update.
6673         * thread-fsm.c: Remove.
6674         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6675
6676 2019-02-07  Tom Tromey  <tom@tromey.com>
6677
6678         * yy-remap.h: Add include guard.
6679         * xtensa-tdep.h: Add include guard.
6680         * xcoffread.h: Rename include guard.
6681         * varobj-iter.h: Add include guard.
6682         * tui/tui.h: Rename include guard.
6683         * tui/tui-winsource.h: Rename include guard.
6684         * tui/tui-wingeneral.h: Rename include guard.
6685         * tui/tui-windata.h: Rename include guard.
6686         * tui/tui-win.h: Rename include guard.
6687         * tui/tui-stack.h: Rename include guard.
6688         * tui/tui-source.h: Rename include guard.
6689         * tui/tui-regs.h: Rename include guard.
6690         * tui/tui-out.h: Rename include guard.
6691         * tui/tui-layout.h: Rename include guard.
6692         * tui/tui-io.h: Rename include guard.
6693         * tui/tui-hooks.h: Rename include guard.
6694         * tui/tui-file.h: Rename include guard.
6695         * tui/tui-disasm.h: Rename include guard.
6696         * tui/tui-data.h: Rename include guard.
6697         * tui/tui-command.h: Rename include guard.
6698         * tic6x-tdep.h: Add include guard.
6699         * target/waitstatus.h: Rename include guard.
6700         * target/wait.h: Rename include guard.
6701         * target/target.h: Rename include guard.
6702         * target/resume.h: Rename include guard.
6703         * target-float.h: Rename include guard.
6704         * stabsread.h: Add include guard.
6705         * rs6000-tdep.h: Add include guard.
6706         * riscv-fbsd-tdep.h: Add include guard.
6707         * regformats/regdef.h: Rename include guard.
6708         * record.h: Rename include guard.
6709         * python/python.h: Rename include guard.
6710         * python/python-internal.h: Rename include guard.
6711         * python/py-stopevent.h: Rename include guard.
6712         * python/py-ref.h: Rename include guard.
6713         * python/py-record.h: Rename include guard.
6714         * python/py-record-full.h: Rename include guard.
6715         * python/py-record-btrace.h: Rename include guard.
6716         * python/py-instruction.h: Rename include guard.
6717         * python/py-events.h: Rename include guard.
6718         * python/py-event.h: Rename include guard.
6719         * procfs.h: Add include guard.
6720         * proc-utils.h: Add include guard.
6721         * p-lang.h: Add include guard.
6722         * or1k-tdep.h: Rename include guard.
6723         * observable.h: Rename include guard.
6724         * nto-tdep.h: Rename include guard.
6725         * nat/x86-linux.h: Rename include guard.
6726         * nat/x86-linux-dregs.h: Rename include guard.
6727         * nat/x86-gcc-cpuid.h: Add include guard.
6728         * nat/x86-dregs.h: Rename include guard.
6729         * nat/x86-cpuid.h: Rename include guard.
6730         * nat/ppc-linux.h: Rename include guard.
6731         * nat/mips-linux-watch.h: Rename include guard.
6732         * nat/linux-waitpid.h: Rename include guard.
6733         * nat/linux-ptrace.h: Rename include guard.
6734         * nat/linux-procfs.h: Rename include guard.
6735         * nat/linux-osdata.h: Rename include guard.
6736         * nat/linux-nat.h: Rename include guard.
6737         * nat/linux-namespaces.h: Rename include guard.
6738         * nat/linux-btrace.h: Rename include guard.
6739         * nat/glibc_thread_db.h: Rename include guard.
6740         * nat/gdb_thread_db.h: Rename include guard.
6741         * nat/gdb_ptrace.h: Rename include guard.
6742         * nat/fork-inferior.h: Rename include guard.
6743         * nat/amd64-linux-siginfo.h: Rename include guard.
6744         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6745         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6746         * nat/aarch64-linux.h: Rename include guard.
6747         * nat/aarch64-linux-hw-point.h: Rename include guard.
6748         * mn10300-tdep.h: Add include guard.
6749         * mips-linux-tdep.h: Add include guard.
6750         * mi/mi-parse.h: Rename include guard.
6751         * mi/mi-out.h: Rename include guard.
6752         * mi/mi-main.h: Rename include guard.
6753         * mi/mi-interp.h: Rename include guard.
6754         * mi/mi-getopt.h: Rename include guard.
6755         * mi/mi-console.h: Rename include guard.
6756         * mi/mi-common.h: Rename include guard.
6757         * mi/mi-cmds.h: Rename include guard.
6758         * mi/mi-cmd-break.h: Rename include guard.
6759         * m2-lang.h: Add include guard.
6760         * location.h: Rename include guard.
6761         * linux-record.h: Rename include guard.
6762         * linux-nat.h: Add include guard.
6763         * linux-fork.h: Add include guard.
6764         * i386-darwin-tdep.h: Rename include guard.
6765         * hppa-linux-offsets.h: Add include guard.
6766         * guile/guile.h: Rename include guard.
6767         * guile/guile-internal.h: Rename include guard.
6768         * gnu-nat.h: Rename include guard.
6769         * gdb-stabs.h: Rename include guard.
6770         * frv-tdep.h: Add include guard.
6771         * f-lang.h: Add include guard.
6772         * event-loop.h: Add include guard.
6773         * darwin-nat.h: Rename include guard.
6774         * cp-abi.h: Rename include guard.
6775         * config/sparc/nm-sol2.h: Rename include guard.
6776         * config/nm-nto.h: Rename include guard.
6777         * config/nm-linux.h: Add include guard.
6778         * config/i386/nm-i386gnu.h: Rename include guard.
6779         * config/djgpp/nl_types.h: Rename include guard.
6780         * config/djgpp/langinfo.h: Rename include guard.
6781         * compile/gcc-cp-plugin.h: Add include guard.
6782         * compile/gcc-c-plugin.h: Add include guard.
6783         * compile/compile.h: Rename include guard.
6784         * compile/compile-object-run.h: Rename include guard.
6785         * compile/compile-object-load.h: Rename include guard.
6786         * compile/compile-internal.h: Rename include guard.
6787         * compile/compile-cplus.h: Rename include guard.
6788         * compile/compile-c.h: Rename include guard.
6789         * common/xml-utils.h: Rename include guard.
6790         * common/x86-xstate.h: Rename include guard.
6791         * common/version.h: Rename include guard.
6792         * common/vec.h: Rename include guard.
6793         * common/tdesc.h: Rename include guard.
6794         * common/selftest.h: Rename include guard.
6795         * common/scoped_restore.h: Rename include guard.
6796         * common/scoped_mmap.h: Rename include guard.
6797         * common/scoped_fd.h: Rename include guard.
6798         * common/safe-iterator.h: Rename include guard.
6799         * common/run-time-clock.h: Rename include guard.
6800         * common/refcounted-object.h: Rename include guard.
6801         * common/queue.h: Rename include guard.
6802         * common/ptid.h: Rename include guard.
6803         * common/print-utils.h: Rename include guard.
6804         * common/preprocessor.h: Rename include guard.
6805         * common/pathstuff.h: Rename include guard.
6806         * common/observable.h: Rename include guard.
6807         * common/netstuff.h: Rename include guard.
6808         * common/job-control.h: Rename include guard.
6809         * common/host-defs.h: Rename include guard.
6810         * common/gdb_wait.h: Rename include guard.
6811         * common/gdb_vecs.h: Rename include guard.
6812         * common/gdb_unlinker.h: Rename include guard.
6813         * common/gdb_unique_ptr.h: Rename include guard.
6814         * common/gdb_tilde_expand.h: Rename include guard.
6815         * common/gdb_sys_time.h: Rename include guard.
6816         * common/gdb_string_view.h: Rename include guard.
6817         * common/gdb_splay_tree.h: Rename include guard.
6818         * common/gdb_setjmp.h: Rename include guard.
6819         * common/gdb_ref_ptr.h: Rename include guard.
6820         * common/gdb_optional.h: Rename include guard.
6821         * common/gdb_locale.h: Rename include guard.
6822         * common/gdb_assert.h: Rename include guard.
6823         * common/filtered-iterator.h: Rename include guard.
6824         * common/filestuff.h: Rename include guard.
6825         * common/fileio.h: Rename include guard.
6826         * common/environ.h: Rename include guard.
6827         * common/common-utils.h: Rename include guard.
6828         * common/common-types.h: Rename include guard.
6829         * common/common-regcache.h: Rename include guard.
6830         * common/common-inferior.h: Rename include guard.
6831         * common/common-gdbthread.h: Rename include guard.
6832         * common/common-exceptions.h: Rename include guard.
6833         * common/common-defs.h: Rename include guard.
6834         * common/common-debug.h: Rename include guard.
6835         * common/cleanups.h: Rename include guard.
6836         * common/buffer.h: Rename include guard.
6837         * common/btrace-common.h: Rename include guard.
6838         * common/break-common.h: Rename include guard.
6839         * cli/cli-utils.h: Rename include guard.
6840         * cli/cli-style.h: Rename include guard.
6841         * cli/cli-setshow.h: Rename include guard.
6842         * cli/cli-script.h: Rename include guard.
6843         * cli/cli-interp.h: Rename include guard.
6844         * cli/cli-decode.h: Rename include guard.
6845         * cli/cli-cmds.h: Rename include guard.
6846         * charset-list.h: Add include guard.
6847         * buildsym-legacy.h: Rename include guard.
6848         * bfin-tdep.h: Add include guard.
6849         * ax.h: Rename include guard.
6850         * arm-linux-tdep.h: Add include guard.
6851         * arm-fbsd-tdep.h: Add include guard.
6852         * arch/xtensa.h: Rename include guard.
6853         * arch/tic6x.h: Add include guard.
6854         * arch/i386.h: Add include guard.
6855         * arch/arm.h: Rename include guard.
6856         * arch/arm-linux.h: Rename include guard.
6857         * arch/arm-get-next-pcs.h: Rename include guard.
6858         * arch/amd64.h: Add include guard.
6859         * arch/aarch64-insn.h: Rename include guard.
6860         * arch-utils.h: Rename include guard.
6861         * annotate.h: Add include guard.
6862         * amd64-darwin-tdep.h: Rename include guard.
6863         * aarch64-linux-tdep.h: Add include guard.
6864         * aarch64-fbsd-tdep.h: Add include guard.
6865         * aarch32-linux-nat.h: Add include guard.
6866
6867 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6868
6869         * macrotab.c (macro_define_internal): New function that
6870         factorizes macro_define_object_internal and macro_define_function
6871         code.
6872         (macro_define_object_internal): Use macro_define_internal.
6873         (macro_define_function): Likewise.
6874
6875 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6876
6877         * macrocmd.c (extract_identifier): Return
6878         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6879         callers.
6880
6881 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6882
6883         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6884
6885 2019-02-05  Tom Tromey  <tom@tromey.com>
6886
6887         * target.c (target_stack::unpush): Move assertion earlier.
6888
6889 2019-01-30  Tom Tromey  <tom@tromey.com>
6890
6891         PR python/23615:
6892         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6893         (gdbpy_parse_and_eval): Likewise.
6894         * python/python-internal.h (gdbpy_allow_threads): New class.
6895
6896 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6897
6898         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6899         (aarch64_fbsd_fpregmap): Move earlier.
6900         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6901         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6902         instead of individual calls to trad_frame_set_reg_addr.
6903         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6904         earlier.
6905         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6906         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6907         instead of individual calls to trad_frame_set_reg_addr.
6908
6909 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6910
6911         * CONTRIBUTE: Replace contribution list with wiki link.
6912
6913 2019-01-25  Tom Tromey  <tom@tromey.com>
6914
6915         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6916
6917 2019-01-25  Tom Tromey  <tom@tromey.com>
6918
6919         * xtensa-linux-nat.c: Fix common/ includes.
6920         * xml-support.h: Fix common/ includes.
6921         * xml-support.c: Fix common/ includes.
6922         * x86-linux-nat.c: Fix common/ includes.
6923         * windows-nat.c: Fix common/ includes.
6924         * varobj.h: Fix common/ includes.
6925         * varobj.c: Fix common/ includes.
6926         * value.c: Fix common/ includes.
6927         * valops.c: Fix common/ includes.
6928         * utils.c: Fix common/ includes.
6929         * unittests/xml-utils-selftests.c: Fix common/ includes.
6930         * unittests/utils-selftests.c: Fix common/ includes.
6931         * unittests/unpack-selftests.c: Fix common/ includes.
6932         * unittests/tracepoint-selftests.c: Fix common/ includes.
6933         * unittests/style-selftests.c: Fix common/ includes.
6934         * unittests/string_view-selftests.c: Fix common/ includes.
6935         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6936         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6937         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6938         * unittests/rsp-low-selftests.c: Fix common/ includes.
6939         * unittests/parse-connection-spec-selftests.c: Fix common/
6940         includes.
6941         * unittests/optional-selftests.c: Fix common/ includes.
6942         * unittests/offset-type-selftests.c: Fix common/ includes.
6943         * unittests/observable-selftests.c: Fix common/ includes.
6944         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6945         * unittests/memrange-selftests.c: Fix common/ includes.
6946         * unittests/memory-map-selftests.c: Fix common/ includes.
6947         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6948         * unittests/function-view-selftests.c: Fix common/ includes.
6949         * unittests/environ-selftests.c: Fix common/ includes.
6950         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6951         * unittests/common-utils-selftests.c: Fix common/ includes.
6952         * unittests/cli-utils-selftests.c: Fix common/ includes.
6953         * unittests/array-view-selftests.c: Fix common/ includes.
6954         * ui-file.c: Fix common/ includes.
6955         * tui/tui-io.c: Fix common/ includes.
6956         * tracepoint.h: Fix common/ includes.
6957         * tracepoint.c: Fix common/ includes.
6958         * tracefile-tfile.c: Fix common/ includes.
6959         * top.h: Fix common/ includes.
6960         * top.c: Fix common/ includes.
6961         * thread.c: Fix common/ includes.
6962         * target/waitstatus.h: Fix common/ includes.
6963         * target/waitstatus.c: Fix common/ includes.
6964         * target.h: Fix common/ includes.
6965         * target.c: Fix common/ includes.
6966         * target-memory.c: Fix common/ includes.
6967         * target-descriptions.c: Fix common/ includes.
6968         * symtab.h: Fix common/ includes.
6969         * symfile.c: Fix common/ includes.
6970         * stap-probe.c: Fix common/ includes.
6971         * spu-linux-nat.c: Fix common/ includes.
6972         * sparc-nat.c: Fix common/ includes.
6973         * source.c: Fix common/ includes.
6974         * solib.c: Fix common/ includes.
6975         * solib-target.c: Fix common/ includes.
6976         * ser-unix.c: Fix common/ includes.
6977         * ser-tcp.c: Fix common/ includes.
6978         * ser-pipe.c: Fix common/ includes.
6979         * ser-base.c: Fix common/ includes.
6980         * selftest-arch.c: Fix common/ includes.
6981         * s12z-tdep.c: Fix common/ includes.
6982         * rust-exp.y: Fix common/ includes.
6983         * rs6000-aix-tdep.c: Fix common/ includes.
6984         * riscv-tdep.c: Fix common/ includes.
6985         * remote.c: Fix common/ includes.
6986         * remote-notif.h: Fix common/ includes.
6987         * remote-fileio.h: Fix common/ includes.
6988         * remote-fileio.c: Fix common/ includes.
6989         * regcache.h: Fix common/ includes.
6990         * regcache.c: Fix common/ includes.
6991         * record-btrace.c: Fix common/ includes.
6992         * python/python.c: Fix common/ includes.
6993         * python/py-type.c: Fix common/ includes.
6994         * python/py-inferior.c: Fix common/ includes.
6995         * progspace.h: Fix common/ includes.
6996         * producer.c: Fix common/ includes.
6997         * procfs.c: Fix common/ includes.
6998         * proc-api.c: Fix common/ includes.
6999         * printcmd.c: Fix common/ includes.
7000         * ppc-linux-nat.c: Fix common/ includes.
7001         * parser-defs.h: Fix common/ includes.
7002         * osdata.c: Fix common/ includes.
7003         * obsd-nat.c: Fix common/ includes.
7004         * nat/x86-linux.c: Fix common/ includes.
7005         * nat/x86-linux-dregs.c: Fix common/ includes.
7006         * nat/x86-dregs.h: Fix common/ includes.
7007         * nat/x86-dregs.c: Fix common/ includes.
7008         * nat/ppc-linux.c: Fix common/ includes.
7009         * nat/mips-linux-watch.h: Fix common/ includes.
7010         * nat/mips-linux-watch.c: Fix common/ includes.
7011         * nat/linux-waitpid.c: Fix common/ includes.
7012         * nat/linux-ptrace.h: Fix common/ includes.
7013         * nat/linux-ptrace.c: Fix common/ includes.
7014         * nat/linux-procfs.c: Fix common/ includes.
7015         * nat/linux-personality.c: Fix common/ includes.
7016         * nat/linux-osdata.c: Fix common/ includes.
7017         * nat/linux-namespaces.c: Fix common/ includes.
7018         * nat/linux-btrace.h: Fix common/ includes.
7019         * nat/linux-btrace.c: Fix common/ includes.
7020         * nat/fork-inferior.c: Fix common/ includes.
7021         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7022         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7023         * nat/aarch64-linux.c: Fix common/ includes.
7024         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7025         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7026         * namespace.h: Fix common/ includes.
7027         * mips-linux-tdep.c: Fix common/ includes.
7028         * minsyms.c: Fix common/ includes.
7029         * mi/mi-parse.h: Fix common/ includes.
7030         * mi/mi-main.c: Fix common/ includes.
7031         * mi/mi-cmd-env.c: Fix common/ includes.
7032         * memrange.h: Fix common/ includes.
7033         * memattr.c: Fix common/ includes.
7034         * maint.h: Fix common/ includes.
7035         * maint.c: Fix common/ includes.
7036         * main.c: Fix common/ includes.
7037         * machoread.c: Fix common/ includes.
7038         * location.c: Fix common/ includes.
7039         * linux-thread-db.c: Fix common/ includes.
7040         * linux-nat.c: Fix common/ includes.
7041         * linux-fork.c: Fix common/ includes.
7042         * inline-frame.c: Fix common/ includes.
7043         * infrun.c: Fix common/ includes.
7044         * inflow.c: Fix common/ includes.
7045         * inferior.h: Fix common/ includes.
7046         * inferior.c: Fix common/ includes.
7047         * infcmd.c: Fix common/ includes.
7048         * inf-ptrace.c: Fix common/ includes.
7049         * inf-child.c: Fix common/ includes.
7050         * ia64-linux-nat.c: Fix common/ includes.
7051         * i387-tdep.c: Fix common/ includes.
7052         * i386-tdep.c: Fix common/ includes.
7053         * i386-linux-tdep.c: Fix common/ includes.
7054         * i386-linux-nat.c: Fix common/ includes.
7055         * i386-go32-tdep.c: Fix common/ includes.
7056         * i386-fbsd-tdep.c: Fix common/ includes.
7057         * i386-fbsd-nat.c: Fix common/ includes.
7058         * guile/scm-type.c: Fix common/ includes.
7059         * guile/guile.c: Fix common/ includes.
7060         * go32-nat.c: Fix common/ includes.
7061         * gnu-nat.c: Fix common/ includes.
7062         * gdbthread.h: Fix common/ includes.
7063         * gdbarch-selftests.c: Fix common/ includes.
7064         * gdb_usleep.c: Fix common/ includes.
7065         * gdb_select.h: Fix common/ includes.
7066         * gdb_bfd.c: Fix common/ includes.
7067         * gcore.c: Fix common/ includes.
7068         * fork-child.c: Fix common/ includes.
7069         * findvar.c: Fix common/ includes.
7070         * fbsd-nat.c: Fix common/ includes.
7071         * event-top.c: Fix common/ includes.
7072         * event-loop.c: Fix common/ includes.
7073         * dwarf2read.c: Fix common/ includes.
7074         * dwarf2loc.c: Fix common/ includes.
7075         * dwarf2-frame.c: Fix common/ includes.
7076         * dwarf-index-cache.c: Fix common/ includes.
7077         * dtrace-probe.c: Fix common/ includes.
7078         * disasm-selftests.c: Fix common/ includes.
7079         * defs.h: Fix common/ includes.
7080         * csky-tdep.c: Fix common/ includes.
7081         * cp-valprint.c: Fix common/ includes.
7082         * cp-support.h: Fix common/ includes.
7083         * cp-support.c: Fix common/ includes.
7084         * corelow.c: Fix common/ includes.
7085         * completer.h: Fix common/ includes.
7086         * completer.c: Fix common/ includes.
7087         * compile/compile.c: Fix common/ includes.
7088         * compile/compile-loc2c.c: Fix common/ includes.
7089         * compile/compile-cplus-types.c: Fix common/ includes.
7090         * compile/compile-cplus-symbols.c: Fix common/ includes.
7091         * command.h: Fix common/ includes.
7092         * cli/cli-dump.c: Fix common/ includes.
7093         * cli/cli-cmds.c: Fix common/ includes.
7094         * charset.c: Fix common/ includes.
7095         * build-id.c: Fix common/ includes.
7096         * btrace.h: Fix common/ includes.
7097         * btrace.c: Fix common/ includes.
7098         * breakpoint.h: Fix common/ includes.
7099         * breakpoint.c: Fix common/ includes.
7100         * ax.h:
7101         (enum agent_op): Fix common/ includes.
7102         * ax-general.c (struct aop_map): Fix common/ includes.
7103         * ax-gdb.c: Fix common/ includes.
7104         * auxv.c: Fix common/ includes.
7105         * auto-load.c: Fix common/ includes.
7106         * arm-tdep.c: Fix common/ includes.
7107         * arch/riscv.c: Fix common/ includes.
7108         * arch/ppc-linux-common.c: Fix common/ includes.
7109         * arch/i386.c: Fix common/ includes.
7110         * arch/arm.c: Fix common/ includes.
7111         * arch/arm-linux.c: Fix common/ includes.
7112         * arch/arm-get-next-pcs.c: Fix common/ includes.
7113         * arch/amd64.c: Fix common/ includes.
7114         * arch/aarch64.c: Fix common/ includes.
7115         * arch/aarch64-insn.c: Fix common/ includes.
7116         * arch-utils.c: Fix common/ includes.
7117         * amd64-windows-tdep.c: Fix common/ includes.
7118         * amd64-tdep.c: Fix common/ includes.
7119         * amd64-sol2-tdep.c: Fix common/ includes.
7120         * amd64-obsd-tdep.c: Fix common/ includes.
7121         * amd64-nbsd-tdep.c: Fix common/ includes.
7122         * amd64-linux-tdep.c: Fix common/ includes.
7123         * amd64-linux-nat.c: Fix common/ includes.
7124         * amd64-fbsd-tdep.c: Fix common/ includes.
7125         * amd64-fbsd-nat.c: Fix common/ includes.
7126         * amd64-dicos-tdep.c: Fix common/ includes.
7127         * amd64-darwin-tdep.c: Fix common/ includes.
7128         * agent.c: Fix common/ includes.
7129         * ada-lang.h: Fix common/ includes.
7130         * ada-lang.c: Fix common/ includes.
7131         * aarch64-tdep.c: Fix common/ includes.
7132
7133 2019-01-25  Tom Tromey  <tom@tromey.com>
7134
7135         * common/create-version.sh: Use common/version.h.
7136
7137 2019-01-24  Pedro Alves  <palves@redhat.com>
7138
7139         * infrun.c (signal_stop, signal_print, signal_program)
7140         (signal_catch, signal_pass): Now arrays instead of pointers.
7141         (update_signals_program_target, do_target_resume)
7142         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7143         * linux-nat.c (linux_nat_target::pass_signals)
7144         (linux_nat_target::create_inferior, linux_nat_target::attach):
7145         Adjust.
7146         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7147         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7148         * procfs.c (procfs_target::pass_signals): Adjust.
7149         * record-full.c (record_full_target::resume): Adjust.
7150         * remote.c (remote_target::pass_signals)
7151         (remote_target::program_signals): Adjust.
7152         * target-debug.h (target_debug_print_signals): Now takes a
7153         gdb::array_view as parameter.  Adjust.
7154         * target.h (target_ops) <pass_signals, program_signals>: Replace
7155         pointer and length parameters with gdb::array_view.
7156         (target_pass_signals, target_program_signals): Likewise.
7157         * target-delegates.c: Regenerate.
7158
7159 2019-01-24  Pedro Alves  <palves@redhat.com>
7160
7161         * common/forward-scope-exit.h
7162         (forward_scope_exit::forward_scope_exit): Pass arguments to
7163         m_bind_function directly, instead of creating a std::bind and
7164         copying that.
7165
7166 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7167
7168         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7169         for static members.
7170         (pass_in_v_vfp_candidate): Likewise.
7171
7172 2019-01-23  Tom Tromey  <tom@tromey.com>
7173             Pedro Alves  <palves@redhat.com>
7174
7175         * regcache.c (class regcache_invalidator): Remove.
7176         (regcache::raw_write): Use make_scope_exit.
7177
7178 2019-01-23  Tom Tromey  <tom@tromey.com>
7179
7180         * ui-out.h (class ui_out_emit_type): Update comment.
7181
7182 2019-01-23  Tom Tromey  <tom@tromey.com>
7183
7184         * infrun.c (fetch_inferior_event): Update comment.
7185
7186 2019-01-23  Tom Tromey  <tom@tromey.com>
7187             Pedro Alves  <palves@redhat.com>
7188
7189         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7190         parameter.
7191         (fetch_inferior_event): Use SCOPE_EXIT.
7192
7193
7194 2019-01-23  Tom Tromey  <tom@tromey.com>
7195             Pedro Alves  <palves@redhat.com>
7196
7197         * infrun.c (disable_thread_events): Delete.
7198         (stop_all_threads): Use SCOPE_EXIT.
7199
7200 2019-01-23  Tom Tromey  <tom@tromey.com>
7201             Pedro Alves  <palves@redhat.com>
7202
7203         * symfile.c: Include forward-scope-exit.h.
7204         (clear_symtab_users_cleanup): Replace forward declaration with
7205         a FORWARD_SCOPE_EXIT.
7206         (syms_from_objfile_1): Use the forward_scope_exit and
7207         gdb::optional instead of cleanup_function.
7208         (reread_symbols): Use the forward_scope_exit instead of
7209         cleanup_function.
7210         (clear_symtab_users_cleanup): Remove function.
7211
7212 2019-01-23  Tom Tromey  <tom@tromey.com>
7213             Pedro Alves  <palves@redhat.com>
7214
7215         * linux-nat.c: Include scope-exit.h.
7216         (cleanup_target_stop): Remove.
7217         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7218         SCOPE_EXIT.
7219
7220 2019-01-23  Tom Tromey  <tom@tromey.com>
7221             Pedro Alves  <palves@redhat.com>
7222
7223         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7224         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7225
7226 2019-01-23  Tom Tromey  <tom@tromey.com>
7227             Andrew Burgess  <andrew.burgess@embecosm.com>
7228             Pedro Alves  <palves@redhat.com>
7229
7230         * infrun.c (fetch_inferior_event): Use scope_exit.
7231         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7232         * top.c (execute_command): Use scope_exit.
7233         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7234         * utils.c (do_bpstat_clear_actions_cleanup)
7235         (make_bpstat_clear_actions_cleanup): Remove.
7236
7237 2019-01-23  Tom Tromey  <tom@tromey.com>
7238             Pedro Alves  <palves@redhat.com>
7239
7240         * infrun.c: Include "common/scope-exit.h"
7241         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7242         (wait_for_inferior): Use SCOPE_EXIT.
7243         (fetch_inferior_event): Use scope_exit.
7244
7245 2019-01-23  Tom Tromey  <tom@tromey.com>
7246             Pedro Alves  <palves@redhat.com>
7247
7248         * breakpoint.c (create_breakpoint): Remove cleanup.
7249
7250 2019-01-23  Tom Tromey  <tom@tromey.com>
7251             Andrew Burgess  <andrew.burgess@embecosm.com>
7252             Pedro Alves  <palves@redhat.com>
7253
7254 2019-01-23  Pedro Alves  <palves@redhat.com>
7255
7256         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7257
7258 2019-01-23  Pedro Alves  <palves@redhat.com>
7259             Andrew Burgess  <andrew.burgess@embecosm.com>
7260
7261         * gdbthread.h: Include "common/forward-scope-exit.h".
7262         (scoped_finish_thread_state): Redefine custom class in terms of
7263         forward_scope_exit.
7264
7265 2019-01-23  Pedro Alves  <palves@redhat.com>
7266             Andrew Burgess  <andrew.burgess@embecosm.com>
7267
7268         * common/forward-scope-exit.h: New file.
7269
7270 2019-01-23  Pedro Alves  <palves@redhat.com>
7271             Andrew Burgess  <andrew.burgess@embecosm.com>
7272             Tom Tromey  <tom@tromey.com>
7273
7274         * common/scope-exit.h: New file.
7275
7276 2019-01-23  Pedro Alves  <palves@redhat.com>
7277
7278         * common/preprocessor.h (ESC): Rename to ...
7279         (ESC_PARENS): ... this.
7280         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7281         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7282
7283 2019-01-23  Tom Tromey  <tom@tromey.com>
7284
7285         * language.h (class scoped_switch_to_sym_language_if_auto):
7286         Initialize m_lang in both cases.
7287
7288 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7289
7290         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7291         with XCNEW.
7292
7293 2019-01-22  Tom Tromey  <tom@tromey.com>
7294
7295         * corelow.c: Do not include sys/file.h.
7296
7297 2019-01-22  Tom Tromey  <tom@tromey.com>
7298
7299         * tui/tui-wingeneral.h: Include gdb_curses.h.
7300
7301 2019-01-22  Tom Tromey  <tom@tromey.com>
7302
7303         * source-cache.h (class source_cache) <get_source_lines,
7304         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7305
7306 2019-01-22  Tom Tromey  <tom@tromey.com>
7307
7308         * remote-fileio.h (struct remote_target): Declare.
7309
7310 2019-01-22  Tom Tromey  <tom@tromey.com>
7311
7312         * python/py-arch.c: Do not include py-ref.h.
7313         * python/py-bpevent.c: Do not include py-ref.h.
7314         * python/py-cmd.c: Do not include py-ref.h.
7315         * python/py-continueevent.c: Do not include py-ref.h.
7316         * python/py-event.h: Do not include py-ref.h.
7317         * python/py-evtregistry.c: Do not include py-ref.h.
7318         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7319         * python/py-frame.c: Do not include py-ref.h.
7320         * python/py-framefilter.c: Do not include py-ref.h.
7321         * python/py-function.c: Do not include py-ref.h.
7322         * python/py-infevents.c: Do not include py-ref.h.
7323         * python/py-linetable.c: Do not include py-ref.h.
7324         * python/py-objfile.c: Do not include py-ref.h.
7325         * python/py-param.c: Do not include py-ref.h.
7326         * python/py-prettyprint.c: Do not include py-ref.h.
7327         * python/py-progspace.c: Do not include py-ref.h.
7328         * python/py-symbol.c: Do not include py-ref.h.
7329         * python/py-symtab.c: Do not include py-ref.h.
7330         * python/py-type.c: Do not include py-ref.h.
7331         * python/py-unwind.c: Do not include py-ref.h.
7332         * python/py-utils.c: Do not include py-ref.h.
7333         * python/py-value.c: Do not include py-ref.h.
7334         * python/py-varobj.c: Do not include py-ref.h.
7335         * python/py-xmethods.c: Do not include py-ref.h.
7336         * python/python.c: Do not include py-ref.h.
7337         * varobj.c: Do not include py-ref.h.
7338
7339 2019-01-22  Tom Tromey  <tom@tromey.com>
7340
7341         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7342         keyword for bcache.
7343
7344 2019-01-22  Tom Tromey  <tom@tromey.com>
7345
7346         * compile/compile-cplus-types.c: Remove a comment by #include.
7347
7348 2019-01-22  Tom Tromey  <tom@tromey.com>
7349
7350         * compile/gcc-c-plugin.h: Include compile-internal.h.
7351
7352 2019-01-22  Tom Tromey  <tom@tromey.com>
7353
7354         * stabsread.c (EXTERN): Do not define.
7355         (symnum, next_symbol_text_func, processing_gcc_compilation)
7356         (within_function, global_sym_chain, global_stabs)
7357         (previous_stab_code, this_object_header_files)
7358         (n_this_object_header_files)
7359         (n_allocated_this_object_header_files): Define.
7360         * stabsread.h (EXTERN): Never define.  Use "extern".
7361
7362 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7363
7364         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7365         history_value.
7366
7367 2019-01-21  Tom Tromey  <tom@tromey.com>
7368
7369         * ui-out.c: Fix includes.
7370         * tui/tui-source.c: Fix includes.
7371         * target.c: Fix includes.
7372         * remote.c: Fix includes.
7373         * regcache.c: Fix includes.
7374         * python/py-block.c: Fix includes.
7375         * printcmd.c: Fix includes.
7376         * or1k-tdep.c: Fix includes.
7377         * mi/mi-main.c: Fix includes.
7378         * m32r-tdep.c: Fix includes.
7379         * csky-tdep.c: Fix includes.
7380         * compile/compile-cplus-types.c: Fix includes.
7381         * cli/cli-interp.c: Fix includes.
7382
7383 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7384
7385         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7386         for padding.
7387
7388 2019-01-16  Tom Tromey  <tom@tromey.com>
7389
7390         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7391         earlier.
7392         (struct objfile) <msymbols_range>: Move from top level.
7393         <msymbols>: New method.
7394         (class objfile_msymbols): Remove.
7395         * symtab.c (default_collect_symbol_completion_matches_break_on):
7396         Update.
7397         * symmisc.c (dump_msymbols): Update.
7398         * stabsread.c (scan_file_globals): Update.
7399         * objc-lang.c (info_selectors_command, info_classes_command)
7400         (find_methods): Update.
7401         * minsyms.c (find_solib_trampoline_target): Update.
7402         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7403         * coffread.c (coff_symfile_read): Update.
7404         * ada-lang.c (ada_lookup_simple_minsym)
7405         (ada_collect_symbol_completion_matches): Update.
7406
7407 2019-01-16  Tom Tromey  <tom@tromey.com>
7408
7409         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7410         type.  Remove no-argument constructor.
7411         <iterator::operator++>: Simplify.
7412         <begin>: Update.
7413         <end>: Use minimal_symbol_count.
7414
7415 2019-01-16  Tom Tromey  <tom@tromey.com>
7416
7417         * objfiles.h (struct objfile) <psymtabs>: New method.
7418         (class objfile_psymtabs): Remove.
7419         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7420         typedef.
7421         <range>: New method.
7422         (require_partial_symbols): Change return type.
7423         * psymtab.c (require_partial_symbols)
7424         (psym_expand_symtabs_matching): Update.
7425         * mdebugread.c (parse_partial_symbols): Update.
7426         * dbxread.c (dbx_end_psymtab): Update.
7427
7428 2019-01-15  Tom Tromey  <tom@tromey.com>
7429
7430         * symtab.c (lookup_objfile_from_block)
7431         (lookup_symbol_in_objfile_symtabs)
7432         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7433         (find_line_symtab, info_sources_command)
7434         (default_collect_symbol_completion_matches_break_on)
7435         (make_source_files_completion_list): Update.
7436         * symmisc.c (print_objfile_statistics, dump_objfile)
7437         (maintenance_print_symbols, maintenance_info_symtabs)
7438         (maintenance_check_symtabs, maintenance_info_line_tables):
7439         Update.
7440         * source.c (select_source_symtab)
7441         (forget_cached_source_info_for_objfile): Update.
7442         * objfiles.h (class objfile_compunits): Remove.
7443         (struct objfile) <compunits_range>: New typedef.
7444         (compunits): New method.
7445         * objfiles.c (objfile_relocate1): Update.
7446         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7447         * maint.c (count_symtabs_and_blocks): Update.
7448         * linespec.c (iterate_over_all_matching_symtabs): Update.
7449         * cp-support.c (add_symbol_overload_list_qualified): Update.
7450         * coffread.c (coff_symtab_read): Update.
7451         * ada-lang.c (add_nonlocal_symbols)
7452         (ada_collect_symbol_completion_matches)
7453         (ada_add_global_exceptions): Update.
7454
7455 2019-01-15  Tom Tromey  <tom@tromey.com>
7456
7457         * progspace.h (program_space) <objfiles_safe_range>: New
7458         typedef.
7459         <objfiles_safe>: New method.
7460         * objfiles.h (class all_objfiles_safe): Remove.
7461         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7462         * jit.c (jit_inferior_exit_hook): Update.
7463
7464 2019-01-17  Tom Tromey  <tom@tromey.com>
7465
7466         * progspace.h (program_space) <objfiles_range>: New typedef.
7467         <objfiles>: New method.
7468         <objfiles_head>: Rename from objfiles.
7469         (object_files): Update.
7470         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7471         * guile/scm-pretty-print.c
7472         (ppscm_find_pretty_printer_from_objfiles): Update.
7473         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7474         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7475         Update.
7476         * python/py-progspace.c (pspy_get_objfiles): Update.
7477         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7478         Update.
7479         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7480         (objfpy_lookup_objfile_by_build_id): Update.
7481         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7482         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7483         Update.
7484         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7485         (expand_symtab_containing_pc, lookup_objfile_from_block)
7486         (lookup_static_symbol, basic_lookup_transparent_type)
7487         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7488         (find_line_symtab, info_sources_command)
7489         (default_collect_symbol_completion_matches_break_on)
7490         (make_source_files_completion_list, find_main_name): Update.
7491         * symmisc.c (print_symbol_bcache_statistics)
7492         (print_objfile_statistics, maintenance_print_symbols)
7493         (maintenance_print_msymbols, maintenance_print_objfiles)
7494         (maintenance_info_symtabs, maintenance_check_symtabs)
7495         (maintenance_expand_symtabs, maintenance_info_line_tables):
7496         Update.
7497         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7498         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7499         (map_overlay_command, unmap_overlay_command)
7500         (simple_overlay_update, expand_symtabs_matching)
7501         (map_symbol_filenames): Update.
7502         * symfile-debug.c (set_debug_symfile): Update.
7503         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7504         Update.
7505         * source.c (select_source_symtab, forget_cached_source_info):
7506         Update.
7507         * solib.c (solib_read_symbols): Update.
7508         * solib-spu.c (append_ocl_sos): Update.
7509         * psymtab.c (maintenance_print_psymbols)
7510         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7511         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7512         * printcmd.c (info_symbol_command): Update.
7513         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7514         Update.
7515         * objfiles.h (class all_objfiles): Remove.
7516         * objfiles.c (have_partial_symbols, have_full_symbols)
7517         (have_minimal_symbols, qsort_cmp, update_section_map)
7518         (shared_objfile_contains_address_p)
7519         (default_iterate_over_objfiles_in_search_order): Update.
7520         * objc-lang.c (info_selectors_command, info_classes_command)
7521         (find_methods): Update.
7522         * minsyms.c (find_solib_trampoline_target): Update.
7523         * maint.c (maintenance_info_sections)
7524         (maintenance_translate_address, count_symtabs_and_blocks):
7525         Update.
7526         * main.c (captured_main_1): Update.
7527         * linux-thread-db.c (try_thread_db_load_from_pdir)
7528         (has_libpthread): Update.
7529         * linespec.c (iterate_over_all_matching_symtabs)
7530         (search_minsyms_for_name): Update.
7531         * jit.c (jit_find_objf_with_entry_addr): Update.
7532         * hppa-tdep.c (find_unwind_entry)
7533         (hppa_lookup_stub_minimal_symbol): Update.
7534         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7535         Update.
7536         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7537         (elf_gnu_ifunc_resolve_by_got): Update.
7538         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7539         * dwarf-index-write.c (save_gdb_index_command): Update.
7540         * cp-support.c (add_symbol_overload_list_qualified): Update.
7541         * breakpoint.c (create_overlay_event_breakpoint)
7542         (create_longjmp_master_breakpoint)
7543         (create_std_terminate_master_breakpoint)
7544         (create_exception_master_breakpoint): Update.
7545         * blockframe.c (find_pc_partial_function): Update.
7546         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7547         (ada_collect_symbol_completion_matches)
7548         (ada_add_global_exceptions): Update.
7549
7550 2019-01-17  Tom Tromey  <tom@tromey.com>
7551
7552         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7553         declare VEC.
7554         (solib_target_parse_libraries): Change return type.
7555         (library_list_start_segment, library_list_start_section)
7556         (library_list_end_library, library_list_start_library); Update.
7557         (solib_target_free_library_list): Remove.
7558         (solib_target_parse_libraries): Remove cleanup.  Change return
7559         type.
7560         (solib_target_current_sos): Update.
7561
7562 2019-01-17  Tom Tromey  <tromey@bapiya>
7563
7564         * valprint.c: Replace "the the" with "the".
7565         * symtab.c: Replace "the the" with "the".
7566         * solib.c: Replace "the the" with "the".
7567         * solib-dsbt.c: Replace "the the" with "the".
7568         * linespec.c: Replace "the the" with "the".
7569         * dwarf2loc.h: Replace "the the" with "the".
7570         * amd64-windows-tdep.c: Replace "the the" with "the".
7571         * aarch64-tdep.c: Replace "the the" with "the".
7572
7573 2019-01-16  Keith Seitz  <keiths@redhat.com>
7574
7575         PR gdb/23773
7576         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7577         <builder>: Rename to ..
7578         <m_builder>: ... this and make private.
7579         (dwarf2_cu::get_builder): New method.  Change all users of
7580         `builder' to use this method.
7581         (dwarf2_start_symtab): Move to ...
7582         (dwarf2_cu::start_symtab): ... here.  Update all callers
7583         (setup_type_unit_groups): Move to ...
7584         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7585         callers.
7586         (dwarf2_cu::reset_builder): New method.
7587         (process_full_compunit, process_full_type_unit): Use
7588         dwarf2_cu::reset_builder.
7589         (follow_die_offset): Record the ancestor CU if it is different
7590         from the followed DIE's CU.
7591         (follow_die_sig_1): Likewise.
7592
7593 2019-01-15  Tom Tromey  <tom@tromey.com>
7594
7595         * remote.c (class remote_state) <buf>: Now a char_vector.
7596         <buf_size>: Remove.
7597         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7598         parameter.
7599         (remote_target::getpkt_or_notif_sane_1)
7600         (remote_target::getpkt_sane)
7601         (remote_target::getpkt_or_notif_sane): Likewise.
7602         (class remote_target) <putpkt>: New overload.
7603         (remote_target::read_frame): Change type of "buf_p".  Remove
7604         sizeof_p parameter.
7605         (packet_ok): New overload.
7606         (packet_check_result): New overload.
7607         Update all uses.
7608
7609 2019-01-14  Tom Tromey  <tom@tromey.com>
7610
7611         * remote-notif.c (handle_notification, remote_notif_ack)
7612         (remote_notif_parse): Make "buf" const.
7613         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7614         const.
7615         (remote_notif_parse, remote_notif_ack, handle_notification):
7616         Likewise.
7617         * remote.c (remote_notif_stop_parse): Make "buf" const.
7618         (remote_target::remote_parse_stop_reply): Make "buf" const.
7619         (remote_notif_stop_ack): Make "buf" const.
7620
7621 2019-01-14  Tom Tromey  <tom@tromey.com>
7622
7623         * remote.c (remote_console_output): Make parameter const.
7624
7625 2019-01-14  Tom Tromey  <tom@tromey.com>
7626
7627         * target-debug.h (target_debug_print_signals): Constify.
7628         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7629         * procfs.c (procfs_target::pass_signals): Update.
7630         * linux-nat.c (linux_nat_target::pass_signals): Update.
7631         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7632         * target-delegates.c: Rebuild.
7633         * remote.c (remote_target::program_signals): Update.
7634         (remote_target::pass_signals): Update.
7635         * target.c (target_pass_signals): Constify argument.
7636         (target_program_signals): Likewise.
7637         * target.h (struct target_ops) <pass_signals, program_signals>:
7638         Constify argument.
7639         (target_pass_signals, target_program_signals): Constify argument.
7640
7641 2019-01-14  Tom Tromey  <tom@tromey.com>
7642
7643         PR tui/28819:
7644         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7645
7646 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7647
7648         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7649         field.
7650         * rs6000-tdep.c: Include reggroups.h.
7651         (IS_V_ALIAS_PSEUDOREG): Define.
7652         (rs6000_register_name): Return names for the "vX" aliases.
7653         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7654         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7655         aliases.  Call default_register_reggroup_p for all other
7656         pseudo-registers.
7657         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7658         New functions.
7659         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7660         Handle "vX" aliases.
7661         (v_alias_pseudo_register_collect): New function.
7662         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7663         (rs6000_gdbarch_init): Initialize "vX" aliases as
7664         pseudo-registers.  Restore registration of
7665         rs6000_pseudo_register_reggroup_p with
7666         set_tdesc_pseudo_register_reggroup_p.
7667
7668 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7669
7670         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7671         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7672         set_gdbarch_num_pseudo_regs.
7673
7674 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7675
7676         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7677         Remove arg prefixname, add do_set and do_show.
7678         Add member functions set_list and show_list.
7679         * cli/cli-style.c (class cli_style_option): Update accordingly.
7680         (style_set_list): Move to file scope.
7681         (style_show_list): Likewise.
7682         (set_style): Call help_list.
7683         (show_style): Call cmd_show_list.
7684         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7685         Update to use the new macro.
7686
7687 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7688
7689         * ada-lang.c (_initialize_ada_language): Expand the help text
7690         for the "catch exception" command.
7691
7692 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7693
7694         * symtab.c (matching_obj_sections): Initialize obj,
7695         declare it closer to its usage.
7696
7697 2019-01-10  Tom Tromey  <tom@tromey.com>
7698
7699         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7700         (basic_inf_threads_range): Remove.
7701         (inf_threads_range, inf_non_exited_threads_range)
7702         (safe_inf_threads_range): Use next_adapter.
7703
7704 2019-01-10  Keith Seitz  <keiths@redhat.com>
7705
7706         PR gdb/23712
7707         PR symtab/23010
7708         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7709         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7710
7711 2019-01-10  Keith Seitz  <keiths@redhat.com>
7712
7713         PR gdb/23712
7714         PR symtab/23010
7715         * dictionary.c (pending_to_vector): Remove.
7716         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7717         Remove _1 suffix, replacing functions of the same name.  Update
7718         all callers.
7719         (dict_create_hashed, dict_create_hashed_expandable)
7720         (dict_create_linear, dict_create_linear_expandable, dict_free)
7721         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7722         Make functions static.
7723
7724 2019-01-10  Keith Seitz  <keiths@redhat.com>
7725
7726         PR gdb/23712
7727         PR symtab/23010
7728         * dictionary.h (struct dictionary): Replace declaration with
7729         multidictionary.
7730         (dict_create_hashed, dict_create_hashed_expandable)
7731         (dict_create_linear, dict_create_linear_expandable)
7732         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7733         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7734         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7735         taking multidictionary argument.
7736         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7737         * block.h (struct block) <dict>: Change to multidictionary
7738         and rename `multidict'.
7739         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7740         symmisc.c: Update all dictionary references to multidictionary.
7741
7742 2019-01-10  Keith Seitz  <keiths@redhat.com>
7743
7744         PR gdb/23712
7745         PR symtab/23010
7746         * dictionary.c: Include unordered_map.
7747         (pending_to_vector): New function.
7748         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7749         Rewrite the non-"_1" functions to take vector instead
7750         of linked list.
7751         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7752         "new" _1 versions of the same name.
7753         (multidictionary): Define.
7754         (std::hash<enum language): New definition.
7755         (collate_pending_symbols_by_language, mdict_create_hashed)
7756         (mdict_create_hashed_expandable, mdict_create_linear)
7757         (mdict_create_linear_expandable, mdict_free)
7758         (find_language_dictionary, create_new_language_dictionary)
7759         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7760         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7761         (mdict_size, mdict_empty): New functions.
7762         * dictionary.h (mdict_iterator): Define.
7763
7764 2019-01-10  Pedro Alves  <palves@redhat.com>
7765
7766         * breakpoint.c (read_uploaded_action)
7767         (create_tracepoint_from_upload): Adjust to use
7768         gdb::unique_xmalloc_ptr.
7769         * ctf.c (ctf_write_uploaded_tp):
7770         (SET_ARRAY_FIELD): Use emplace_back.
7771         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7772         * tracefile-tfile.c (tfile_write_uploaded_tp):
7773         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7774         gdb::unique_xmalloc_ptr.
7775         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7776         at_string, cond_string, cmd_strings>: Replace char pointers
7777         with gdb::unique_xmalloc_ptr.
7778
7779 2019-01-10  Pedro Alves  <palves@redhat.com>
7780
7781         * solib-target.c (library_list_start_library): Don't xstrdup name.
7782
7783 2019-01-10  Pedro Alves  <palves@redhat.com>
7784
7785         * mdebugread.c (parse_partial_symbols): Use
7786         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7787
7788 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7789
7790         * linux-fork.c (scoped_switch_fork_info)
7791         <~scoped_switch_fork_info>: Fix incorrect variable name.
7792
7793 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7794
7795         * linux-fork.c (scoped_switch_fork_info)
7796         <scoped_switch_fork_info>: Make explicit.
7797         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7798
7799 2019-01-10  Tom Tromey  <tom@tromey.com>
7800
7801         * objfiles.h (objfile::reset_psymtabs): Update.
7802         * objfiles.c (objfile::objfile): Update.
7803         * psymtab.h (psymtab_storage::obstack): Update.
7804         (psymtab_storage::m_obstack): Use gdb::optional.
7805         (class psymtab_storage): Update comment.  Remove objfile
7806         parameter.
7807         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7808
7809 2019-01-10  Tom Tromey  <tom@tromey.com>
7810
7811         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7812         <free_psymtabs>: Now private.
7813         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7814         (allocate_psymtab): Use new method.
7815
7816 2019-01-10  Tom Tromey  <tom@tromey.com>
7817
7818         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7819         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7820         * mdebugread.c (parse_partial_symbols): Use
7821         allocate_dependencies.
7822         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7823         allocate_dependencies.
7824         (process_psymtab_comp_unit_reader)
7825         (build_type_psymtab_dependencies): Likewise.
7826         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7827
7828 2019-01-10  Tom Tromey  <tom@tromey.com>
7829
7830         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7831         PSYMBOL_SET_LANGUAGE.
7832         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7833
7834 2019-01-10  Tom Tromey  <tom@tromey.com>
7835
7836         * psymtab.h (psymtab_storage::obstack): New method.
7837         <m_obstack>: Rename from obstack; now private.
7838         * psymtab.c (psymtab_storage): Update.
7839         * dwarf2read.c (create_addrmap_from_index)
7840         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7841         Update.
7842
7843 2019-01-10  Tom Tromey  <tom@tromey.com>
7844
7845         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7846         * objfiles.h (objfile::reset_psymtabs): New method.
7847
7848 2019-01-10  Tom Tromey  <tom@tromey.com>
7849
7850         * symmisc.c (print_symbol_bcache_statistics): Update.
7851         (print_objfile_statistics): Update.
7852         * symfile.c (reread_symbols): Update.
7853         * psymtab.h (class psymtab_storage): New.
7854         * psymtab.c (psymtab_storage): New constructor.
7855         (~psymtab_storage): New destructor.
7856         (require_partial_symbols): Update.
7857         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7858         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7859         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7860         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7861         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7862         (start_psymtab_common, end_psymtab_common)
7863         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7864         (allocate_psymtab): Update.
7865         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7866         Update.
7867         (dump_psymtab_addrmap, maintenance_print_psymbols)
7868         (maintenance_check_psymtabs): Update.
7869         (class objfile_psymtabs): Move to objfiles.h.
7870         * psympriv.h (discard_psymtab): Now inline.
7871         (psymtab_discarder::psymtab_discarder): Update.
7872         (psymtab_discarder::~psymtab_discarder): Update.
7873         (ALL_OBJFILE_PSYMTABS): Rewrite.
7874         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7875         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7876         Remove fields.
7877         <partial_symtabs>: New field.
7878         (class objfile_psymtabs): Move from psymtab.h.  Update.
7879         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7880         psymbol_cache.
7881         (objfile::~objfile): Don't destroy psymbol_cache.
7882         * mdebugread.c (parse_partial_symbols): Update.
7883         * dwarf2read.c (create_addrmap_from_index)
7884         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7885         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7886         (add_partial_subprogram, dwarf2_ranges_read): Update.
7887         * dwarf-index-write.c (write_address_map)
7888         (write_one_signatured_type, recursively_write_psymbols)
7889         (class debug_names, class debug_names, write_psymtabs_to_index):
7890         Update.
7891
7892 2019-01-10  Tom Tromey  <tom@tromey.com>
7893
7894         * symtab.h (SYMBOL_SET_NAMES): Update.
7895         (symbol_set_names): Update.
7896         (MSYMBOL_SET_NAMES): Update.
7897         * symtab.c (symbol_set_names): Change argument to be an
7898         objfile_per_bfd_storage.
7899         * psymtab.c (add_psymbol_to_bcache): Update.
7900         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7901
7902 2019-01-10  Tom Tromey  <tom@tromey.com>
7903
7904         * symtab.c (create_demangled_names_hash): Change argument to be an
7905         objfile_per_bfd_storage.
7906         (symbol_set_names): Update.
7907
7908 2019-01-10  Tom Tromey  <tom@tromey.com>
7909
7910         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7911         init_psymbol_list.
7912         * psymtab.c (init_psymbol_list): Do nothing if already called.
7913         * psympriv.h (init_psymbol_list): Add comment.
7914         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7915         init_psymbol_list.
7916         * dbxread.c (dbx_symfile_read): Unconditionally call
7917         init_psymbol_list.
7918
7919 2019-01-10  Tom Tromey  <tom@tromey.com>
7920
7921         * xcoffread.c (scan_xcoff_symtab): Update.
7922         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7923         "where".
7924         * mdebugread.c (parse_partial_symbols)
7925         (handle_psymbol_enumerators): Update.
7926         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7927         * dbxread.c (read_dbx_symtab): Update.
7928         * psympriv.h (psymbol_placement): New enum.
7929         (add_psymbol_to_list): Update.
7930
7931 2019-01-10  Tom Tromey  <tom@tromey.com>
7932
7933         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7934         static_psymbols parameters.
7935         (scan_xcoff_symtab): Update.
7936         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7937         static_psymbols parameters.
7938         * psympriv.h (start_psymtab_common): Update.
7939         * mdebugread.c (parse_partial_symbols): Update.
7940         * dwarf2read.c (create_partial_symtab): Update.
7941         * dbxread.c (read_dbx_symtab): Update.
7942         (start_psymtab): Remove global_psymbols and static_psymbols
7943         parameters.
7944
7945 2019-01-10  Tom Tromey  <tom@tromey.com>
7946
7947         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7948         * psymtab.c (allocate_psymtab): Add comment.
7949         * psympriv.h (allocate_psymtab): Add comment.
7950         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7951         initializations.
7952         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7953
7954 2019-01-10  Tom Tromey  <tom@tromey.com>
7955
7956         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7957         Don't declare.
7958         * mipsread.c: Include mdebugread.h.
7959         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7960         Declare.
7961         * elfread.c: Include mdebugread.h.
7962
7963 2019-01-09  Tom Tromey  <tom@tromey.com>
7964
7965         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7966         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7967         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7968         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7969         (psym_lookup_symbol, psym_find_last_source_symtab)
7970         (psym_forget_cached_source_info, psym_print_stats)
7971         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7972         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7973         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7974         (psym_find_compunit_symtab_by_address)
7975         (maintenance_print_psymbols, maintenance_info_psymtabs)
7976         (maintenance_check_psymtabs): Use ranged for.
7977         * psymtab.h (class objfile_psymtabs): New.
7978         (require_partial_symbols): Return objfile_psymtabs.
7979         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7980
7981 2019-01-09  Tom Tromey  <tom@tromey.com>
7982
7983         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7984         (find_pc_mapped_section, list_overlays_command)
7985         (map_overlay_command, unmap_overlay_command)
7986         (simple_overlay_update): Use all_objfiles.
7987         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7988         * printcmd.c (info_symbol_command): Use all_objfiles.
7989         * objfiles.h (ALL_OBJSECTIONS): Remove.
7990         * maint.c (maintenance_translate_address): Use all_objfiles.
7991         * gcore.c (gcore_create_callback): Use all_objfiles.
7992         (objfile_find_memory_regions): Likewise.
7993
7994 2019-01-09  Tom Tromey  <tom@tromey.com>
7995
7996         * symtab.c (find_line_symtab, info_sources_command)
7997         (make_source_files_completion_list): Use objfile_compunits.
7998         * source.c (select_source_symtab): Use objfile_compunits.
7999         * objfiles.h (struct objfile): Update comment.
8000         (ALL_OBJFILES): Remove.
8001         (ALL_FILETABS): Remove.
8002         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8003         objfile_compunits.
8004
8005 2019-01-09  Tom Tromey  <tom@tromey.com>
8006
8007         * symmisc.c (print_objfile_statistics, dump_objfile)
8008         (maintenance_print_symbols): Use compunit_filetabs.
8009         * source.c (forget_cached_source_info_for_objfile): Use
8010         compunit_filetabs.
8011         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8012         (ALL_FILETABS): Use compunit_filetabs.
8013         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8014         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8015
8016 2019-01-09  Tom Tromey  <tom@tromey.com>
8017
8018         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8019         (compunit_filetabs): New.
8020         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8021         compunit_filetabs.
8022         (info_sources_command, make_source_files_completion_list): Remove
8023         declaration.
8024         * symmisc.c (print_objfile_statistics, dump_objfile)
8025         (maintenance_print_symbols): Remove declaration.
8026         (maintenance_info_symtabs): Use compunit_filetabs.
8027         (maintenance_info_line_tables): Likewise.
8028         * source.c (select_source_symtab): Change local variable name.
8029         (forget_cached_source_info_for_objfile): Remove declaration.
8030         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8031         * objfiles.c (objfile_relocate1): Remove declaration.
8032         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8033         declaration.
8034         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8035         * coffread.c (coff_symtab_read): Remove declaration.
8036         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8037         compunit_filetabs.
8038
8039 2019-01-09  Tom Tromey  <tom@tromey.com>
8040
8041         * symtab.c (lookup_objfile_from_block)
8042         (find_pc_sect_compunit_symtab, search_symbols)
8043         (default_collect_symbol_completion_matches_break_on): Use
8044         objfile_compunits.
8045         * objfiles.h (ALL_COMPUNITS): Remove.
8046         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8047         * cp-support.c (add_symbol_overload_list_qualified): Use
8048         objfile_compunits.
8049         * ada-lang.c (ada_collect_symbol_completion_matches)
8050         (ada_add_global_exceptions): Use objfile_compunits.
8051
8052 2019-01-09  Tom Tromey  <tom@tromey.com>
8053
8054         * source.c (select_source_symtab)
8055         (forget_cached_source_info_for_objfile): Remove declaration.
8056         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8057         declaration.
8058         * maint.c (count_symtabs_and_blocks): Remove declaration.
8059         * cp-support.c (add_symbol_overload_list_qualified): Remove
8060         declaration.
8061         * coffread.c (coff_symtab_read): Remove declaration.
8062         * symtab.c (lookup_symbol_in_objfile_symtabs)
8063         (basic_lookup_transparent_type_1): Use objfile_compunits.
8064         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8065         (info_sources_command, search_symbols)
8066         (default_collect_symbol_completion_matches_break_on)
8067         (make_source_files_completion_list): Remove declaration.
8068         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8069         (ada_collect_symbol_completion_matches)
8070         (ada_add_global_exceptions): Remove declaration.
8071         * linespec.c (iterate_over_all_matching_symtabs): Use
8072         objfile_compunits.
8073         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8074         (class objfile_compunits): New.
8075         (ALL_COMPUNITS): Use objfile_compunits.
8076         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8077         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8078         objfile_compunits.
8079         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8080
8081 2019-01-09  Tom Tromey  <tom@tromey.com>
8082
8083         * symtab.c (search_symbols)
8084         (default_collect_symbol_completion_matches_break_on): Use
8085         objfile_msymbols.
8086         * ada-lang.c (ada_lookup_simple_minsym)
8087         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8088         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8089         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8090         objfile_msymbols.
8091         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8092         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8093         * objc-lang.c (find_methods): Use objfile_msymbols.
8094         (info_selectors_command, info_classes_command): Likewise.
8095         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8096         * objfiles.h (class objfile_msymbols): New.
8097         (ALL_OBJFILE_MSYMBOLS): Remove.
8098         (ALL_MSYMBOLS): Remove.
8099
8100 2019-01-09  Tom Tromey  <tom@tromey.com>
8101
8102         * common/next-iterator.h (next_adapter): Add Iterator template
8103         parameter.
8104         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8105         (class all_objfiles_safe): New.
8106         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8107         * objfiles.c (put_objfile_before): Update comment.
8108         (add_separate_debug_objfile): Likewise.
8109         (free_all_objfiles): Use all_objfiles_safe.
8110         (objfile_purge_solibs): Likewise.
8111
8112 2019-01-09  Tom Tromey  <tom@tromey.com>
8113
8114         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8115         (expand_symtab_containing_pc, lookup_static_symbol)
8116         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8117         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8118         all_objfiles.
8119         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8120         * breakpoint.c (create_overlay_event_breakpoint)
8121         (create_longjmp_master_breakpoint)
8122         (create_std_terminate_master_breakpoint)
8123         (create_exception_master_breakpoint): Use all_objfiles.
8124         * linux-thread-db.c (try_thread_db_load_from_pdir)
8125         (has_libpthread): Use all_objfiles.
8126         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8127         * linespec.c (iterate_over_all_matching_symtabs)
8128         (search_minsyms_for_name): Use all_objfiles.
8129         * maint.c (maintenance_info_sections): Use all_objfiles.
8130         * main.c (captured_main_1): Use all_objfiles.
8131         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8132         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8133         * guile/scm-pretty-print.c
8134         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8135         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8136         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8137         (maintenance_print_msymbols): Use all_objfiles.
8138         * source.c (select_source_symtab): Use all_objfiles.
8139         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8140         * symfile.c (remove_symbol_file_command)
8141         (expand_symtabs_matching, map_symbol_filenames): Use
8142         all_objfiles.
8143         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8144         all_objfiles.
8145         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8146         * objc-lang.c (find_methods): Use all_objfiles.
8147         * objfiles.c (have_partial_symbols, have_full_symbols)
8148         (have_minimal_symbols, qsort_cmp)
8149         (default_iterate_over_objfiles_in_search_order): Use
8150         all_objfiles.
8151         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8152         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8153         (maintenance_check_psymtabs): Use all_objfiles.
8154         (ALL_PSYMTABS): Remove.
8155         * compile/compile-object-run.c (do_module_cleanup): Use
8156         all_objfiles.
8157         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8158         * cp-support.c (add_symbol_overload_list_qualified): Use
8159         all_objfiles.
8160         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8161         Use all_objfiles.
8162         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8163         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8164         all_objfiles.
8165         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8166         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8167         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8168         Uses all_objfiles.
8169         * solib.c (solib_read_symbols): Use all_objfiles
8170
8171 2019-01-09  Tom Tromey  <tom@tromey.com>
8172
8173         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8174         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8175         all_objfiles.
8176         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8177         * symmisc.c (print_symbol_bcache_statistics)
8178         (print_objfile_statistics, maintenance_print_objfiles)
8179         (maintenance_info_symtabs, maintenance_check_symtabs)
8180         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8181         all_objfiles.
8182         * source.c (forget_cached_source_info): Use all_objfiles.
8183         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8184         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8185         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8186         * objfiles.c (update_section_map): Use all_objfiles.
8187         (shared_objfile_contains_address_p): Likewise.
8188         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8189         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8190
8191 2019-01-09  Tom Tromey  <tom@tromey.com>
8192
8193         * common/next-iterator.h: New file.
8194         * objfiles.h (class all_objfiles): New.
8195         (struct objfile_iterator): New.
8196
8197 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8198
8199         * NEWS: Move the description of the changed "frame", "select-frame",
8200          and "info frame" commands to the Changed commands section.
8201
8202 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8203
8204         * gdbtypes.c (check_stub_method_group): Remove handling of old
8205         mangling schemes.
8206         * linespec.c (find_methods): Likewise.
8207         * stabsread.c (read_member_functions): Likewise.
8208         * valops.c (search_struct_method): Likewise.
8209         (value_struct_elt_for_reference): Likewise.
8210         * NEWS: Mention this change.
8211
8212 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8213
8214         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8215         print_source_lines.
8216         * source.c (print_source_lines_base): Update line number check.
8217         (print_source_lines): New function.
8218         (source_lines_range::source_lines_range): New function.
8219         * source.h (class source_lines_range): New class.
8220         (print_source_lines): New declaration.
8221
8222 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8223
8224         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8225
8226 2019-01-08  Tom Tromey  <tom@tromey.com>
8227             Simon Marchi  <simon.marchi@ericsson.com>
8228
8229         PR gdb/24060
8230         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8231         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8232         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8233         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8234         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8235         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8236
8237 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8238
8239         * source.c (select_source_symtab): Move header comment to
8240         declaration in source.h.
8241         (forget_cached_source_info_for_objfile): Likewise.
8242         (forget_cached_source_info): Likewise.
8243         (identify_source_line): Likewise.
8244         * source.h (identify_source_line): Move declaration from symtab.h
8245         and add comment from source.c
8246         (print_source_lines): Likewise.
8247         (forget_cached_source_info_for_objfile): Likewise.
8248         (forget_cached_source_info): Likewise.
8249         (select_source_symtab): Likewise.
8250         (enum print_source_lines_flag): Move definition from symtab.h.
8251         * symtab.h (identify_source_line): Move declaration to source.h.
8252         (print_source_lines): Likewise.
8253         (forget_cached_source_info_for_objfile): Likewise.
8254         (forget_cached_source_info): Likewise.
8255         (select_source_symtab): Likewise.
8256         (enum print_source_lines_flag): Move definition to source.h.
8257         * tui/tui-hooks.c: Add 'source.h' include.
8258
8259 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8260
8261         * source.c (print_source_lines_base): Handle requests to print
8262         reverse line number sequences, and guard against empty lines
8263         string.
8264
8265 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8266
8267         * source.c (print_source_lines_base): Fix skip of '\r' if next
8268         character is '\n'.
8269
8270 2019-01-06  Tom Tromey  <tom@tromey.com>
8271
8272         * c-exp.y (struct c_parse_state) <macro_original_text,
8273         expansion_obstack>: New member.
8274         (macro_original_text, expansion_obstack): Remove globals.
8275         (scan_macro_expansion, scanning_macro_expansion)
8276         (finished_macro_expansion): Update.
8277         (scan_macro_cleanup): Remove.
8278         (yylex, c_parse): Update.
8279
8280 2019-01-06  Tom Tromey  <tom@tromey.com>
8281
8282         * c-exp.y (struct c_parse_state) <strings>: New member.
8283         (operator_stoken): Update.
8284
8285 2019-01-06  Tom Tromey  <tom@tromey.com>
8286
8287         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8288         (union type_stack_elt) <typelist_val>: Now a pointer to
8289         std::vector.
8290         (type_stack_cleanup): Don't declare.
8291         (push_typelist): Update.
8292         * parse.c (pop_typelist): Return a std::vector.
8293         (push_typelist): Take a std::vector.
8294         (follow_types): Update.  Do not free args.
8295         (type_stack_cleanup): Remove.
8296         * c-exp.y (struct c_parse_state): New.
8297         (cpstate): New global.
8298         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8299         (nonempty_typelist): Update.
8300         (func_mod): Create a new vector.
8301         (c_parse): Create a c_parse_state.
8302         (check_parameter_typelist): Do not delete params.
8303         (function_method): Update.  Do not delete type_list.
8304
8305 2019-01-06  Tom Tromey  <tom@tromey.com>
8306
8307         PR gdb/28155:
8308         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8309         check_typedef.
8310         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8311         (print_return_value): Likewise.
8312
8313 2019-01-05  Tom Tromey  <tom@tromey.com>
8314
8315         * contrib/cleanup_check.py: Remove.
8316         * contrib/gcc-with-excheck: Remove.
8317         * contrib/exsummary.py: Remove.
8318         * contrib/excheck.py: Remove.
8319
8320 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8321
8322         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8323         NULL. Initialize tpprev to NULL instead of assigning it
8324         to NULL on the next statement.
8325         * windows-nat.c (windows_delete_thread): Remove check for
8326         main_thread_id before printing thread exit notifications.
8327         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8328         Remove thread ID check against main_thread_id.
8329         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8330         windows_delete_thread.
8331         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8332
8333 2019-01-04  Tom Tromey  <tom@tromey.com>
8334
8335         * compile/compile.c (_initialize_compile): Use upper case for
8336         metasyntactic variables.
8337         * symmisc.c (_initialize_symmisc): Use upper case for
8338         metasyntactic variables.
8339         * psymtab.c (_initialize_psymtab): Use upper case for
8340         metasyntactic variables.
8341         * demangle.c (demangle_command): Use upper case for metasyntactic
8342         variables.
8343         (_initialize_demangler): Likewise.
8344         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8345         variables.
8346
8347 2019-01-03  Tom Tromey  <tom@tromey.com>
8348
8349         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8350
8351 2019-01-03  Tom Tromey  <tom@tromey.com>
8352
8353         * python/py-symtab.c (salpy_str): Update.
8354         (struct salpy_sal_object) <symtab>: Now a PyObject.
8355         (salpy_dealloc): Update.
8356         (del_objfile_sal): Use gdbpy_ref.
8357
8358 2019-01-03  Tom Tromey  <tom@tromey.com>
8359
8360         * python/py-type.c (convert_field): Use new_reference.  Return
8361         gdbpy_ref.
8362         (make_fielditem): Return gdbpy_ref.
8363         (typy_fields): Update.
8364         (typy_getitem): Update.
8365         (field_name): Return gdbpy_ref.  Use new_reference.
8366         (typy_iterator_iternext): Update.
8367
8368 2019-01-03  Tom Tromey  <tom@tromey.com>
8369
8370         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8371
8372 2019-01-03  Tom Tromey  <tom@tromey.com>
8373
8374         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8375         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8376         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8377         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8378         (pspy_set_type_printers): Likewise.
8379         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8380         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8381         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8382         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8383         (objfpy_set_type_printers): Likewise.
8384
8385 2019-01-03  Tom Tromey  <tom@tromey.com>
8386
8387         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8388         (gdbpy_print_stack): Use gdbpy_err_fetch.
8389         * python/python-internal.h (class gdbpy_err_fetch): New class.
8390         (class gdbpy_enter) <m_error_type, m_error_value,
8391         m_error_traceback>: Remove.
8392         <m_error>: New member.
8393         (gdbpy_exception_to_string): Don't declare.
8394         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8395         * python/py-value.c (convert_value_from_python): Use
8396         gdbpy_err_fetch.
8397         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8398         gdbpy_exception_to_string.
8399         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8400         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8401         gdbpy_err_fetch.
8402
8403 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8404
8405         * linux-nat.c (delete_lwp_cleanup): Delete.
8406         (struct lwp_deleter): New struct.
8407         (lwp_info_up): New typedef.
8408         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8409         lwp_info_up.
8410
8411 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8412
8413         * linux-fork.c (class scoped_switch_fork_info): New class.
8414         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8415
8416 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8417
8418         * valops.c (find_overload_match): Remove use of null_cleanup, and
8419         calls to do_cleanups.
8420
8421 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8422
8423         * compile/compile-cplus-types.c
8424         (compile_cplus_instance::decl_name): Handle changes to
8425         cp_func_name.
8426         * cp-support.c (cp_func_name): Update header comment, update
8427         return type.
8428         * cp-support.h (cp_func_name): Update return type in declaration.
8429         * valops.c (find_overload_match): Move temp_func local to top
8430         level of function and change its type.  Use temp_func to hold and
8431         delete temporary string obtained from cp_func_name.
8432
8433 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8434
8435         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8436         gdb::char_vector, remove cleanup, and update uses of `msg`.
8437
8438 2019-01-03  Jim Wilson  <jimw@sifive.com>
8439
8440         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8441
8442 2019-01-02  Tom Tromey  <tom@tromey.com>
8443
8444         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8445         (tdesc_parse_xml): Remove cleanups.
8446         * target-descriptions.h (make_cleanup_free_target_description):
8447         Don't declare.
8448         (target_desc_deleter): New struct.
8449         (target_desc_up): New typedef.
8450         * target-descriptions.c (target_desc_deleter::operator()): Rename
8451         from free_target_description.
8452         (make_cleanup_free_target_description): Remove.
8453
8454 2019-01-02  Tom Tromey  <tom@tromey.com>
8455
8456         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8457         constructor, destructor.
8458         (linespec_parser): Remove typedef.
8459         (~linespec_parser): Rename from linespec_parser_delete.
8460         (linespec_lex_to_end, linespec_complete_label)
8461         (linespec_complete): Update.
8462         (decode_line_full): Remove cleanups.
8463         (decode_line_1): Update.
8464
8465 2019-01-02  Tom Tromey  <tom@tromey.com>
8466
8467         * python/python-internal.h (inferior_to_inferior_object): Change
8468         return type.
8469         * python/py-exitedevent.c (create_exited_event_object): Update.
8470         * python/py-inferior.c (inferior_to_inferior_object): Return
8471         gdbpy_ref.
8472         (python_new_inferior, python_inferior_deleted)
8473         (thread_to_thread_object, delete_thread_object)
8474         (build_inferior_list, gdbpy_selected_inferior): Update.
8475         * python/py-infthread.c (create_thread_object): Update.  Also fail
8476         if inferior_to_inferior_object fails.
8477
8478 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8479
8480         * inferior.h (class inferior) <displaced_step_state>: New field.
8481         * infrun.h (struct displaced_step_state): Move here from
8482         infrun.c.  Initialize fields, add constructor.
8483         <inf>: Remove field.
8484         <reset>: New method.
8485         * infrun.c (struct displaced_step_inferior_state): Move to
8486         infrun.h.
8487         (displaced_step_inferior_states): Remove.
8488         (get_displaced_stepping_state): Adust.
8489         (displaced_step_in_progress_any_inferior): Adjust.
8490         (displaced_step_in_progress_thread): Adjust.
8491         (displaced_step_in_progress): Adjust.
8492         (add_displaced_stepping_state): Remove.
8493         (get_displaced_step_closure_by_addr): Adjust.
8494         (remove_displaced_stepping_state): Remove.
8495         (infrun_inferior_exit): Call displaced_step_state.reset.
8496         (use_displaced_stepping): Don't check for NULL.
8497         (displaced_step_prepare_throw): Call
8498         get_displaced_stepping_state.
8499         (displaced_step_fixup): Don't check for NULL.
8500         (prepare_for_detach): Don't check for NULL.
8501
8502 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8503
8504         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8505          in case of call that did not complete.
8506
8507 2019-01-02  Andrey Utkin  <autkin@undo.io>
8508
8509         * symfile.c (find_separate_debug_file): Fix search of debug files for
8510         remote debuggee.
8511
8512 2019-01-02  Tom Tromey  <tom@tromey.com>
8513
8514         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8515         indentation.
8516         * python/py-frame.c (frapy_older): Remove cast.
8517         (frapy_newer): Likewise.
8518         * python/py-breakpoint.c (local_setattro): Remove cast.
8519         * python/py-arch.c (archpy_name): Remove local variable.
8520         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8521
8522 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8523
8524         * unittests/basic_string_view/element_access/char/empty.cc:
8525         Fix year range in copyright header.
8526
8527 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8528
8529         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8530         Delete.
8531         <operator==>: Update with for removed field.
8532         <hash>: Likewise.
8533         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8534         <isa_features>: ...this.
8535         <abi_features>: New field.
8536         (riscv_isa_flen): Update comment.
8537         (riscv_abi_xlen): New declaration.
8538         (riscv_abi_flen): New declaration.
8539         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8540         isa_features.
8541         (riscv_abi_xlen): New function.
8542         (riscv_isa_flen): Update to get answer from isa_features.
8543         (riscv_abi_flen): New function.
8544         (riscv_has_fp_abi): Update to get answer from abi_features.
8545         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8546         xlen and flen.
8547         (riscv_call_info) <xlen, flen>: Update comment.
8548         (riscv_call_arg_struct): Remove invalid assertions
8549         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8550         is removed.
8551         (riscv_gdbarch_init): Gather isa features and abi features
8552         separately, ensure both match on the gdbarch when reusing an old
8553         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8554         a target with 64-bit float hardware.
8555
8556 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8557
8558         * source.c (search_command_helper): Stop reverse search
8559         when line 1 has been searched.
8560
8561 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8562
8563         * record-full.c (record_full_base_target::close): Rewrite
8564         record_full_core_buf_list free logic.
8565
8566 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8567
8568         * break-catch-syscall.c (print_one_catch_syscall): xfree
8569         the last text.
8570
8571 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8572
8573         * top.c (print_gdb_version): Update Copyright year in version
8574         message.
8575
8576 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8577
8578         Update copyright year range in all GDB files.
8579
8580 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8581
8582         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8583
8584 For older changes see ChangeLog-2018.
8585 \f
8586 Local Variables:
8587 mode: change-log
8588 left-margin: 8
8589 fill-column: 74
8590 version-control: never
8591 coding: utf-8
8592 End:
8593