gdb/ChangeLog

   1 2019-09-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * ada-lang.c (add_nonlocal_symbols): Combine calls to
   4         map_matching_symbols.  Update.
   5         * dwarf2read.c (dw2_map_matching_symbols): Update.
   6         * psymtab.c (match_partial_symbol): Change type; update.
   7         (psym_map_matching_symbols): Likewise.
   8         * symfile-debug.c (debug_qf_map_matching_symbols): Change
   9         type; update.
  10         * symfile.h (struct quick_symbol_functions)
  11         <map_matching_symbols>: Change "name" to be a lookup_name_info.
  12         Remove "match".
  13
  14 2019-09-10  Tom Tromey  <tromey@adacore.com>
  15
  16         * psymtab.c (map_block): Remove.
  17         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
  18         * symtab.c (iterate_over_symbols_terminated): New function.
  19         * symtab.c (iterate_over_symbols_terminated): Declare.
  20
  21 2019-09-10  Tom Tromey  <tromey@adacore.com>
  22
  23         * ada-lang.c (ada_iterate_over_symbols): Return bool.
  24         * language.h (struct language_defn) <la_iterate_over_symbols>:
  25         Return bool.
  26         * symtab.c (iterate_over_symbols): Return bool.
  27         * symtab.h (iterate_over_symbols): Return bool.
  28
  29 2019-09-10  Tom Tromey  <tromey@adacore.com>
  30
  31         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
  32         (add_nonlocal_symbols): Update.
  33         * dwarf2read.c (dw2_map_matching_symbols): Change type.
  34         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
  35         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
  36         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
  37         Change type of "callback".  Remove "data".
  38
  39
  40 2019-09-09  Ali Tamur  <tamur@google.com>
  41
  42         * dwarf2read.c (comp_unit_head): Update comment.
  43         (dwarf2_dwo_name): New function declaration.
  44         (dwarf_unit_type_name): New function declaration.
  45         (read_comp_unit_head): Add support for new compilation units,
  46         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
  47         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
  48         (currently named as "signature") in their header. Also clarify error
  49         messages.
  50         (lookup_dwo_id): New function. Returns the dwo id of the given
  51         compile unit.
  52         (lookup_dwo_unit): Use the new lookup_dwo_id function.
  53         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
  54         functions.
  55         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
  56         (dwarf2_dwo_name): Get the dwo name if present.
  57         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
  58         purposes.
  59
  60 2019-09-09  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
  63
  64 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  65
  66         * python/python.c (do_start_initialization): Make progname_copy static,
  67         to avoid a leak report.
  68
  69 2019-09-08  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
  72
  73 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
  74
  75         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
  76         Change type to gdb::optional<block_enum>.
  77         (dw2_symtab_iter_init): Change block_index parameter type
  78         to gdb::optional<block_enum>.
  79         (dw2_lookup_symbol): Change block_index parameter
  80         type to block_enum.c
  81         (dw2_debug_names_lookup_symbol): Likewise.
  82         * psymtab.c (psym_lookup_symbol): Likewise.
  83         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
  84         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
  85         Likewise.
  86
  87 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
  88
  89         * defs.h (relocate_gdb_directory): Change int to bool in
  90         signature and rename flag to relocatable.
  91         * main.c (relocate_path): Likewise.
  92         (relocate_gdb_directory): Likewise.
  93
  94 2019-09-06  Alan Modra  <amodra@gmail.com>
  95
  96         * coffread.c (coff_symfile_read): Constify filename variable.
  97         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
  98         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
  99         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 100         * solib.c (reload_shared_libraries_1): Likewise.
 101         * symfile.c (reread_symbols): Likewise.
 102         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 103         * solib-darwin.c (darwin_bfd_open): Likewise.
 104         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 105
 106 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 107
 108         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 109         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 110
 111 2019-09-03  Tom Tromey  <tromey@adacore.com>
 112
 113         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 114         types.
 115         (has_negatives): Unbias a range type bound.
 116         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 117         * gdbtypes.c (operator==): Handle new field.
 118         (create_range_type): Add "bias" parameter.
 119         (create_static_range_type, resolve_dynamic_range): Update.
 120         * gdbtypes.h (struct range_bounds) <bias>: New member.
 121         (create_range_type): Add bias parameter.
 122         * printcmd.c (print_scalar_formatted): Unbias range types.
 123         * value.c (unpack_long): Unbias range types.
 124         (pack_long): Bias range types.
 125
 126 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 127
 128         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 129         probe arguments.
 130
 131 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 132
 133         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 134         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 135         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 136         (compile_probe_arg): Likewise.
 137         * probe.h (get_argument_count): Likewise.
 138         * solib-svr4.c (solib_event_probe_action): Likewise.
 139         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 140
 141 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 142
 143         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 144         code to here...
 145         (svr4_create_solib_event_breakpoints): ...from here.
 146
 147 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 148
 149         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 150         suffix from warning message.
 151
 152 2019-08-30  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui-winsource.h (struct tui_source_window_base)
 155         <refresh_all>: Don't declare.
 156         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 157         Remove.
 158         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 159         tui_show_locator_content.
 160         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 161         declare.
 162         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 163         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 164         declare.
 165
 166 2019-08-30  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 169
 170 2019-08-30  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 173         Remove unnecessary forward declarations.
 174
 175 2019-08-30  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 178         rerender.
 179         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 180         tui_show_locator_content.
 181
 182 2019-08-30  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 185         (tui_locator_window::rerender): Rewrite using body of previous
 186         tui_show_locator_content.
 187
 188 2019-08-30  Tom Tromey  <tom@tromey.com>
 189
 190         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 191         set_locator_fullname>: New methods.
 192         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 193         Rename from tui_set_locator_fullname.
 194         (tui_locator_window::set_locator_info): Rename from
 195         tui_set_locator_info.  Return bool.
 196         (tui_update_locator_fullname, tui_show_frame_info): Update.
 197
 198 2019-08-30  Tom Tromey  <tom@tromey.com>
 199
 200         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 201
 202 2019-08-30  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 205         call touchwin.
 206
 207 2019-08-30  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui-wingeneral.c (box_win): Assume win_info and
 210         win_info->handle cannot be NULL.
 211
 212 2019-08-30  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 215         refresh_window>: Declare.
 216         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 217         resize.
 218         (tui_data_item_window::rerender): Rename from
 219         tui_display_register.
 220         (tui_data_item_window::refresh_window): New method.
 221         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 222         no-op.
 223
 224 2019-08-30  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 227         regs_column_count, current_group>: Move later.  Now private.
 228         <get_current_group>: New method.
 229         * tui/tui-regs.c (tui_reg_command): Update.
 230         * tui/tui-layout.c (tui_set_layout): Update.
 231
 232 2019-08-30  Tom Tromey  <tom@tromey.com>
 233
 234         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 235         (tui_data_window::rerender): Don't call
 236         check_and_display_highlight_if_needed.
 237         (tui_data_window::refresh_all): Remove call to
 238         erase_data_content.
 239
 240 2019-08-30  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 243         (tui_data_window::display_registers_from)
 244         (tui_data_window::display_reg_element_at_line)
 245         (tui_data_window::display_registers_from_line): Remove checks of
 246         "empty".
 247
 248 2019-08-30  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 251         Don't declare.
 252         * tui/tui-regs.c (tui_data_window::show_registers): Call
 253         rerender.
 254         (tui_data_window::rerender): Rename from display_all_data.
 255         (tui_data_window::rerender): Remove old implementation.
 256
 257 2019-08-30  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 260         text.
 261         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 262
 263 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 264             Sergio Durigan Junior  <sergiodj@redhat.com>
 265
 266         PR win32/24284
 267         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 268
 269 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 270
 271         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 272         when searching for types.
 273
 274 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 275
 276         * f-lang.c (f_language_defn): Use f_print_typedef.
 277         * f-lang.h (f_print_typedef): Declare.
 278         * f-typeprint.c (f_print_typedef): Define.
 279
 280 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 281
 282         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 283
 284 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 285
 286         * cli/cli-utils.c (info_print_options_defs): Delete.
 287         (make_info_print_options_def_group): Delete.
 288         (extract_info_print_options): Delete.
 289         (info_print_command_completer): Delete.
 290         (info_print_args_help): Add extra parameter, and optionally
 291         include text about -n flag.
 292         * cli/cli-utils.h (struct info_print_options): Delete.
 293         (extract_info_print_options): Delete declaration.
 294         (info_print_command_completer): Delete declaration.
 295         (info_print_args_help): Add extra parameter, extend header
 296         comment.
 297         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 298         search_symbols.
 299         * stack.c (struct info_print_options): New type.
 300         (info_print_options_defs): New file scoped variable.
 301         (make_info_print_options_def_group): New static function.
 302         (info_print_command_completer): New static function.
 303         (info_locals_command): Update to use new local functions.
 304         (info_args_command): Likewise.
 305         (_initialize_stack): Add extra parameter to calls to
 306         info_print_args_help.
 307         * symtab.c (search_symbols): Add extra parameter, use this to
 308         possibly excluse non-debug symbols.
 309         (symtab_symbol_info): Add extra parameter, which is passed on to
 310         search_symbols.
 311         (struct info_print_options): New type.
 312         (info_print_options_defs): New file scoped variable.
 313         (make_info_print_options_def_group): New static function.
 314         (info_print_command_completer): New static function.
 315         (info_variables_command): Update to use local functions, and pass
 316         extra parameter through to symtab_symbol_info.
 317         (info_functions_command): Likewise.
 318         (info_types_command): Pass additional argument through to
 319         symtab_symbol_info.
 320         (rbreak_command): Pass extra argument to search_symbols.
 321         (_initialize_symtab): Add extra arguments for calls to
 322         info_print_args_help, and update help text for 'info variables',
 323         'whereis', and 'info functions' commands.
 324         * symtab.h (search_symbols): Add extra argument to declaration.
 325         * NEWS: Mention new flags.
 326
 327 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 328
 329         * symtab.c (lookup_static_symbol): Call the new function (and move
 330         it down to be next to lookup_global_symbol).
 331         (struct global_sym_lookup_data): Add block_enum member and rename to...
 332         (struct global_or_static_sym_lookup_data): ...this.
 333         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 334         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 335         (lookup_symbol_global_or_static_iterator_cb): ...this.
 336         (lookup_global_or_static_symbol): New function.
 337         (lookup_global_symbol): Call new function.
 338
 339 2019-08-26  Tom de Vries  <tdevries@suse.de>
 340
 341         PR c++/24852
 342         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 343         when pc_probe.prob == NULL.
 344
 345 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 346
 347         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 348         variable symbol_linkage to symbol_linkage_.
 349
 350 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 351
 352         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 353         represent whether the symbol is static, dynamic, or we don't
 354         know.
 355
 356 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 357
 358         * gdb/rx-tdep.c (rx_register_names): New.
 359         (rx_register_name): Delete.
 360         (rx_psw_type): Delete.
 361         (rx_fpsw_type): Delete.
 362         (rx_register_type): Delete.
 363         (rx_gdbarch_init): Convert target-descriptions.
 364         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 365         * gdb/features/Makefile: Add rx.xml.
 366         * gdb/features/rx.xml: New.
 367         * gdb/features/rx.c: Generated.
 368         * gdb/NEWS: Mention target description support.
 369
 370 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 371
 372         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 373         *slot_ptr.
 374
 375 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 376
 377         * configure.ac: Don't check for 'dlfcn.h' (moved to
 378         gdbsupport/common.m4).
 379         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 380         'gdbsupport/'.
 381         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 382         * compile/compile-c-support.c: Include
 383         'gdbsupport/gdb-dlfcn.h'.
 384         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 385         * gdb-dlfcn.c: Move to...
 386         * gdbsupport/gdb-dlfcn.c: ... here.
 387         * gdb-dlfcn.h: Move to...
 388         * gdbsupport/gdb-dlfcn.h: ... here.
 389
 390 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 391
 392         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 393         the offset field signed.
 394
 395 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 396
 397         * python/lib/gdb/__init__.py (_execute_file): New function.
 398         * python/python.c (python_run_simple_file): Call gdb._execute_file
 399         on Windows.
 400
 401 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 402
 403         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 404         all uses as this was never set to anything but a zero value.
 405
 406 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 407
 408         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 409
 410 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 411
 412         * tui/tui-data.h (tui_gen_win_info): Add an =default
 413         move constructor, required by some GCC versions.
 414
 415 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 416
 417         * go32-nat.c (go32_sysinfo): Add hygon_p.
 418
 419 2019-08-20  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 422         line_from_reg_element_no, first_reg_element_no_inline,
 423         display_all_data, delete_data_content_windows,
 424         erase_data_content>: Now private.
 425
 426 2019-08-20  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 429         (tui_unhighlight_win, tui_highlight_win)
 430         (tui_win_info::make_window): Update.
 431         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 432
 433 2019-08-20  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 436         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 437         (MAX_PID_WIDTH): Move to tui-stack.c.
 438         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 439         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 440         (MAX_PID_WIDTH): Move from tui-data.h.
 441
 442 2019-08-20  Tom Tromey  <tom@tromey.com>
 443
 444         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 445         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 446         (box_win): Update.
 447         (tui_gen_win_info::make_window): Rename from tui_make_window.
 448         (tui_win_info::make_window): New method.
 449         (tui_gen_win_info::make_visible): Update.
 450         * tui/tui-source.c (tui_source_window::set_contents): Update.
 451         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 452         (tui_data_window::display_registers_from): Update.
 453         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 454         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 455         Declare.
 456         <can_box>: Remove.
 457         <title>: Remove.
 458         (struct tui_win_info) <make_window>: Declare.
 459         <can_box>: Now virtual.
 460         <title>: New member.
 461         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 462         * tui/tui-command.c (tui_cmd_window::resize): Update.
 463
 464 2019-08-20  Tom Tromey  <tom@tromey.com>
 465
 466         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 467         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 468         (tui_data_window::check_register_values): Update.
 469
 470 2019-08-20  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-regs.h (struct tui_data_window): Use
 473         DISABLE_COPY_AND_ASSIGN.
 474         <regs_content>: Change type, removing unique_ptr.
 475         <tui_data_window>: Add move constructor.
 476         * tui/tui-regs.c (tui_data_window::show_registers)
 477         (tui_data_window::show_register_group)
 478         (tui_data_window::display_registers_from)
 479         (tui_data_window::display_registers_from)
 480         (tui_data_window::first_data_item_displayed)
 481         (tui_data_window::delete_data_content_windows)
 482         (tui_data_window::rerender, tui_data_window::refresh_window)
 483         (tui_data_window::check_register_values): Update.
 484
 485 2019-08-20  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 488         show_register_group>: Declare.
 489         (tui_show_register_group): Don't declare.
 490         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 491         tui_show_registers.
 492         (tui_data_window::show_register_group): Rename from
 493         tui_show_register_group.
 494         (tui_data_window::check_register_values, tui_reg_command):
 495         Update.
 496         * tui/tui-layout.c (tui_set_layout): Update.
 497
 498 2019-08-20  Tom Tromey  <tom@tromey.com>
 499
 500         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 501         Declare.
 502         (tui_check_register_values): Don't declare.
 503         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 504         from tui_check_register_values.
 505         * tui/tui-hooks.c (tui_register_changed): Update.
 506
 507 2019-08-20  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-regs.c (tui_reg_layout): Move later.
 510         (tui_show_registers): Don't enable TUI mode or change layout.
 511
 512 2019-08-20  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-regs.h (struct tui_data_item_window)
 515         <~tui_data_item_window>: Remove.
 516         <content>: Now a unique_xmalloc_ptr.
 517         * tui/tui-regs.c (tui_register_format): Return a
 518         unique_xmalloc_ptr.
 519         (tui_get_register): Update.
 520         (~tui_data_item_window): Remove.
 521         (tui_data_window::display_registers_from, tui_display_register):
 522         Update.
 523         * tui/tui-io.h (tui_expand_tabs): Update.
 524         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 525         Remove "col" parameter.
 526
 527 2019-08-20  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 530         field.
 531         * tui/tui-regs.c (~tui_data_item_window): Update.
 532
 533 2019-08-20  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 536         earlier.
 537
 538 2019-08-20  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 541
 542 2019-08-20  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-source.h (struct tui_source_window): Update.
 545         * tui/tui-regs.c (tui_show_registers): Update.
 546         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 547         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 548         (NO_REGS_STRING): Remove defines.
 549
 550 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 551
 552         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 553         unnecessary thread walk if remote doesn't support the packet.
 554
 555 2019-08-19  Tom Tromey  <tromey@adacore.com>
 556
 557         * python/py-value.c (value_has_field): Fix indentation.
 558
 559 2019-08-19  Tom Tromey  <tromey@adacore.com>
 560
 561         * printcmd.c (do_one_display, info_display_command): Update.
 562         * block.h (contained_in): Return bool.  Add allow_nested
 563         parameter.
 564         * block.c (contained_in): Return bool.  Add allow_nested
 565         parameter.
 566
 567 2019-08-19  Tom Tromey  <tom@tromey.com>
 568
 569         * configure: Rebuild.
 570         * configure.ac: Disallow the combination of -static-libstdc++ and
 571         source highlight.
 572         * source-cache.c (get_language_name): Handle rust.
 573         (source_cache::get_source_lines): Ignore highlighting exceptions.
 574
 575 2019-08-16  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 578         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 579         (struct tui_source_window_base) <make_visible, refresh_window,
 580         resize>: Remove methods.
 581         <execution_info>: Remove field.
 582         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 583         (tui_show_source_line, tui_source_window_base)
 584         (~tui_source_window_base): Update.
 585         (tui_source_window_base::resize)
 586         (tui_source_window_base::make_visible)
 587         (tui_source_window_base::refresh_window): Remove.
 588         (tui_source_window_base::update_exec_info): Update.
 589         * tui/tui-source.c (tui_source_window::set_contents): Update.
 590         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 591
 592 2019-08-16  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 595         deprecated_query_hook.
 596
 597 2019-08-16  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 600         (tui_update_source_windows_with_line): Update.
 601         * tui/tui-source.h (struct tui_source_window)
 602         <show_symtab_source>: Declare.
 603         (tui_show_symtab_source): Don't declare.
 604         * tui/tui-source.c (tui_show_symtab_source): Rename from
 605         tui_show_symtab_source.
 606
 607 2019-08-16  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui-winsource.h (struct tui_source_window_base)
 610         <set_contents>: Declare.
 611         * tui/tui-winsource.c
 612         (tui_source_window_base::update_source_window_as_is): Update.
 613         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 614         Declare.
 615         (tui_set_source_content): Don't declare.
 616         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 617         tui_set_source_content.
 618         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 619         Declare.
 620         (tui_set_disassem_content): Don't declare.
 621         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 622         tui_set_disassem_content.
 623
 624 2019-08-16  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-winsource.h (struct tui_source_window_base)
 627         <update_breakpoint_info>: Declare.
 628         (tui_update_breakpoint_info): Don't declare.
 629         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 630         (tui_update_all_breakpoint_info): Update.
 631         (tui_source_window_base::update_breakpoint_info): Rename from
 632         tui_update_breakpoint_info.
 633         (tui_source_window_base::update_exec_info): Update.
 634
 635 2019-08-16  Tom Tromey  <tom@tromey.com>
 636
 637         * tui/tui-winsource.h (struct tui_source_window_base)
 638         <update_source_window>: Declare.
 639         (tui_update_source_window): Don't declare.
 640         * tui/tui-winsource.c
 641         (tui_source_window_base::update_source_window): Rename from
 642         tui_update_source_window.
 643         (tui_source_window_base::rerender): Update.
 644         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 645         * tui/tui-disasm.c (tui_show_disassem)
 646         (tui_show_disassem_and_update_source)
 647         (tui_disasm_window::maybe_update): Update.
 648
 649 2019-08-16  Tom Tromey  <tom@tromey.com>
 650
 651         * tui/tui-winsource.h (struct tui_source_window_base)
 652         <update_source_window_as_is>: Declare.
 653         (tui_update_source_window_as_is): Don't declare.
 654         * tui/tui-winsource.c (tui_update_source_window): Update
 655         (tui_source_window_base::update_source_window_as_is): Rename from
 656         tui_update_source_window_as_is.
 657         (tui_source_window_base::refill): Update.
 658         * tui/tui-source.c (tui_show_symtab_source): Update.
 659         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 660         Update.
 661
 662 2019-08-16  Tom Tromey  <tom@tromey.com>
 663
 664         * tui/tui-winsource.h (tui_update_source_window)
 665         (tui_update_source_window_as_is): Remove "noerror" parameter.
 666         * tui/tui-winsource.c (tui_update_source_window)
 667         (tui_update_source_window_as_is): Remove "noerror" parameter.
 668         (tui_update_source_windows_with_addr)
 669         (tui_update_source_windows_with_line)
 670         (tui_source_window_base::rerender)
 671         (tui_source_window_base::refill): Update.
 672         * tui/tui-source.h (tui_set_source_content)
 673         (tui_show_symtab_source): Remove "noerror" parameter.
 674         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 675         parameter.
 676         (tui_show_symtab_source): Likewise.
 677         (tui_source_window::maybe_update): Update.
 678         * tui/tui-disasm.c (tui_show_disassem)
 679         (tui_show_disassem_and_update_source)
 680         (tui_disasm_window::do_scroll_vertical)
 681         (tui_disasm_window::maybe_update): Update.
 682
 683 2019-08-16  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui.c (tui_is_window_visible): Update.
 686         * tui/tui-wingeneral.c (tui_make_window)
 687         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 688         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 689         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 690         (tui_set_win_height_command, parse_scrolling_args): Update.
 691         * tui/tui-source.c (tui_source_window::style_changed): Update.
 692         * tui/tui-regs.c (tui_show_registers)
 693         (tui_data_window::first_data_item_displayed)
 694         (tui_data_window::delete_data_content_windows)
 695         (tui_check_register_values, tui_reg_command): Update.
 696         * tui/tui-disasm.c (tui_show_disassem): Update.
 697         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 698         method.
 699         <is_visible>: Remove field.
 700         * tui/tui-data.c (tui_next_win, tui_prev_win)
 701         (tui_delete_invisible_windows): Update.
 702
 703 2019-08-16  Tom Tromey  <tom@tromey.com>
 704
 705         * tui/tui-winsource.h (struct tui_source_window_base)
 706         <m_has_locator>: Remove.
 707         * tui/tui-layout.c (show_source_disasm_command, show_data)
 708         (show_source_or_disasm_and_command): Update.
 709
 710 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 711
 712         * NEWS (Other MI changes): New subsection.
 713         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 714         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 715         * arch-utils.c (default_get_pc_address_flags): New function.
 716         * arch-utils.h (default_get_pc_address_flags): New declaration.
 717         * gdbarch.sh: Add get_pc_address_flags.
 718         * gdbarch.c: Regenerate.
 719         * gdbarch.h: Likewise.
 720         * stack.c (print_pc): New function.
 721         (print_frame_info) (print_frame): Call print_pc.
 722
 723 2019-08-16  Tom de Vries  <tdevries@suse.de>
 724
 725         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 726         print_objfile_section_info.
 727
 728 2019-08-15  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 731         calling update_cmdwin_start_line.
 732         * tui/tui-winsource.h (struct tui_source_window_base)
 733         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 734         <rerender>: Declare.
 735         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 736         Call rerender.
 737         (tui_source_window_base::set_new_height): Remove.
 738         (tui_source_window_base::rerender): Rename from
 739         do_make_visible_with_new_height.
 740         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 741         resize method.
 742         (tui_win_info::make_invisible_and_set_new_height)
 743         (tui_win_info::make_visible_with_new_height): Remove.
 744         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 745         Declare.
 746         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 747         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 748         do_make_visible_with_new_height>: Don't declare.
 749         <rerender>: Declare.
 750         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 751         set_new_height.
 752         (tui_data_window::do_make_visible_with_new_height): Remove.
 753         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 754         call tui_show_locator_content.
 755         (tui_gen_win_info::resize): Call rerender.
 756         (show_source_or_disasm_and_command): Don't call
 757         tui_show_locator_content.
 758         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 759         method.
 760         (struct tui_win_info) <rerender>: Declare.
 761         <set_new_height, make_invisible_and_set_new_height,
 762         make_visible_with_new_height>: Don't declare.
 763         * tui/tui-data.c (tui_win_list::rerender): New method.
 764         * tui/tui-command.h (struct tui_cmd_window)
 765         <do_make_visible_with_new_height>: Don't declare.
 766         * tui/tui-command.c
 767         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 768
 769 2019-08-15  Tom Tromey  <tromey@adacore.com>
 770
 771         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 772         * ada-lang.c (ada_enum_name): Likewise.
 773
 774 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 775
 776         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 777         leading underscore.
 778         (GdbOutputErrorFile): Likewise.
 779         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 780         accordingly.
 781         (execute_unwinders): Rename to have a leading underscore.
 782         (auto_load_packages): Likewise.
 783         (global scope): Adjust call to auto_load_packages accordingly.
 784         (GdbSetPythonDirectory): Likewise.
 785         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 786         instead of execute_unwinders.
 787
 788 2019-08-15  Tom Tromey  <tom@tromey.com>
 789
 790         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 791         (show_data): Don't change window visibility.
 792         (tui_gen_win_info::resize): Remove special case for command
 793         window.  Use wresize, when available.
 794         (show_source_or_disasm_and_command): Don't change window
 795         visibility.
 796         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 797         <make_visible>: New method.
 798         * tui/tui-command.c (tui_cmd_window::resize): New method.
 799
 800 2019-08-15  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 803         (struct tui_source_windows): New.
 804         * tui/tui-winsource.c (tui_display_main): Update.
 805         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 806         (new_height_ok, parse_scrolling_args): Update.
 807         * tui/tui-layout.c (show_layout, show_data): Update.
 808         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 809         (tui_add_to_source_windows): Don't declare.
 810         * tui/tui-data.c (source_windows, tui_source_windows)
 811         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 812
 813 2019-08-15  Tom Tromey  <tom@tromey.com>
 814
 815         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 816         Rename from reset.
 817         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 818         * tui/tui-layout.c (show_source_disasm_command, show_data):
 819         Update.
 820         (tui_gen_win_info::resize): Rename.
 821         (show_source_or_disasm_and_command): Update.
 822         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 823         reset.
 824
 825 2019-08-15  Tom Tromey  <tom@tromey.com>
 826
 827         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 828         * tui/tui-interp.c (tui_interp::init): Don't call
 829         tui_initialize_static_data.
 830         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 831
 832 2019-08-15  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 835         examine tui_win_list.
 836
 837 2019-08-15  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 840         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 841         tui_clear_source_content.
 842         (tui_clear_source_content): Remove.
 843         (tui_source_window_base::do_erase_source_content): Hoist call to
 844         content.clear().
 845         * tui/tui-stack.c (tui_show_frame_info): Don't call
 846         tui_clear_source_content.
 847
 848 2019-08-15  Tom Tromey  <tom@tromey.com>
 849
 850         * tui/tui-winsource.h (struct tui_source_window_base)
 851         <do_erase_source_content>: New method.
 852         <erase_source_content>: New method.
 853         (tui_erase_source_content): Don't declare.
 854         * tui/tui-winsource.c (tui_clear_source_content): Update.
 855         (tui_source_window_base::do_erase_source_content): Rename from
 856         tui_erase_source_content.
 857         (tui_source_window_base::show_source_content): Update.
 858         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 859         * tui/tui-source.h (struct tui_source_window)
 860         <erase_source_content>: New method.
 861         * tui/tui-disasm.h (struct tui_disasm_window)
 862         <erase_source_content>: New method.
 863
 864 2019-08-15  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 867         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 868         constructor.
 869         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 870         * tui/tui-source.c (tui_set_source_content): Update.
 871         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 872
 873 2019-08-15  Tom Tromey  <tom@tromey.com>
 874
 875         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 876         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 877         tui-source.c.
 878         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 879         Declare.
 880         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 881         method.
 882         (tui_source_window::maybe_update): Update.
 883
 884 2019-08-15  Tom Tromey  <tom@tromey.com>
 885
 886         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 887         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 888         tui-disasm.c.
 889         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 890         Declare.
 891         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 892         method.
 893         (tui_disasm_window::maybe_update): Update.
 894
 895 2019-08-15  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-winsource.h (struct tui_source_window_base)
 898         <maybe_update>: Declare.
 899         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 900         method.
 901         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 902         Declare.
 903         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 904         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 905         Declare.
 906         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 907
 908 2019-08-15  Tom Tromey  <tom@tromey.com>
 909
 910         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 911
 912 2019-08-15  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui-wingeneral.c: Include tui-stack.h.
 915         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 916         (struct tui_locator_window): Move from tui-data.h.
 917         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 918         (tui_initialize_static_data): Move from tui-data.c.
 919         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 920         (struct tui_locator_window): Move to tui-stack.c.
 921         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 922         (tui_initialize_static_data): Move to tui-stack.c.
 923
 924 2019-08-15  Tom Tromey  <tom@tromey.com>
 925
 926         * tui/tui-layout.c (show_source_disasm_command)
 927         (show_source_or_disasm_and_command): Use make_visible method, not
 928         tui_make_window.
 929         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 930         Remove.
 931
 932 2019-08-15  Tom Tromey  <tom@tromey.com>
 933
 934         * tui/tui-wingeneral.h (tui_make_window): Update.
 935         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 936         parameter.
 937         (tui_gen_win_info::make_visible): Update.
 938         * tui/tui-regs.c (tui_data_window::display_registers_from):
 939         Update.
 940         * tui/tui-layout.c (show_source_disasm_command)
 941         (show_source_or_disasm_and_command): Update.
 942         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 943         (enum tui_box): Remove.
 944         (struct tui_win_info) <can_box>: New method.
 945         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 946         method.
 947
 948 2019-08-15  Tom de Vries  <tdevries@suse.de>
 949
 950         * linux-nat-trad.c: Include gdbarch.h.
 951
 952 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 953
 954         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 955         register sizes.
 956
 957 2019-08-14  Tom Tromey  <tromey@adacore.com>
 958
 959         * darwin-nat.c: Include gdbarch.h.
 960         * darwin-nat-info.c: Include gdbarch.h.
 961
 962 2019-08-13  Tom Tromey  <tom@tromey.com>
 963
 964         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 965         Remove.
 966         * tui/tui-data.c (tui_initialize_static_data): Update.
 967
 968 2019-08-13  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-winsource.h (struct tui_exec_info_window)
 971         <~tui_exec_info_window, maybe_allocate_content, get_content,
 972         m_content>: Remove.
 973         (struct tui_source_window_base) <set_exec_info_content,
 974         show_exec_info_content>: Don't declare.
 975         * tui/tui-winsource.c
 976         (tui_exec_info_window::maybe_allocate_content): Remove.
 977         (tui_source_window_base::update_exec_info): Rename from
 978         set_exec_info_content.
 979         (tui_source_window_base::show_exec_info_content)
 980         (tui_source_window_base::update_exec_info): Remove.
 981
 982 2019-08-13  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 985         declare.
 986         * tui/tui-winsource.c (tui_update_source_window_as_is)
 987         (tui_update_source_windows_with_addr, tui_erase_source_content):
 988         Update.
 989         (tui_clear_exec_info_content): Remove.
 990
 991 2019-08-13  Tom Tromey  <tom@tromey.com>
 992
 993         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 994         declare.
 995         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 996         call tui_erase_exec_info_content.
 997         (tui_clear_exec_info_content): Rename from
 998         tui_erase_exec_info_content.
 999         (tui_clear_exec_info_content): Delete.
1000
1001 2019-08-13  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui-winsource.h (struct tui_source_window_base)
1004         <show_exec_info_content>: Declare.
1005         (tui_show_exec_info_content): Don't declare.
1006         * tui/tui-winsource.c
1007         (tui_source_window_base::show_exec_info_content): Rename from
1008         tui_show_exec_info_content.
1009         (tui_source_window_base::update_exec_info): Update.
1010
1011 2019-08-13  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1014         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1015         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1016         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1017         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1018         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1019         ... here.
1020
1021 2019-08-13  Tom Tromey  <tom@tromey.com>
1022
1023         * tui/tui-winsource.h (struct tui_source_window_base)
1024         <update_exec_info>: Declare.
1025         (tui_update_exec_info): Don't declare.
1026         * tui/tui-winsource.c (tui_update_source_window_as_is)
1027         (tui_source_window_base::refresh_all)
1028         (tui_update_all_breakpoint_info): Update.
1029         (tui_source_window_base::update_exec_info): Rename from
1030         tui_update_exec_info.
1031         * tui/tui-stack.c (tui_show_frame_info): Update.
1032
1033 2019-08-13  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-winsource.h (struct tui_source_window_base)
1036         <set_exec_info_content>: Declare.
1037         (tui_set_exec_info_content): Don't declare.
1038         * tui/tui-winsource.c
1039         (tui_source_window_base::set_exec_info_content): Rename from
1040         tui_set_exec_info_content.
1041         (tui_update_exec_info): Update.
1042
1043 2019-08-13  Tom Tromey  <tom@tromey.com>
1044
1045         * tui/tui-winsource.h (struct tui_source_window_base)
1046         <show_source_content>: Declare.
1047         (tui_show_source_content): Don't declare.
1048         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1049         (tui_source_window_base::show_source_content): Rename from
1050         tui_show_source_content.
1051         (tui_source_window_base::refresh_all): Update.
1052         * tui/tui-layout.c (show_source_disasm_command)
1053         (show_source_or_disasm_and_command): Update.
1054
1055 2019-08-13  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-winsource.c (tui_erase_source_content)
1058         (tui_show_source_content, tui_source_window_base::refresh_all):
1059         Update.
1060         * tui/tui-wingeneral.h
1061         (tui_check_and_display_highlight_if_needed): Don't declare.
1062         * tui/tui-wingeneral.c
1063         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1064         check_and_display_highlight_if_needed.
1065         * tui/tui-win.c (tui_rehighlight_all)
1066         (tui_win_info::make_visible_with_new_height): Update.
1067         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1068         (tui_data_window::erase_data_content)
1069         (tui_data_window::display_all_data): Update.
1070         * tui/tui-data.h (struct tui_win_info)
1071         <check_and_display_highlight_if_needed>: Declare.
1072
1073 2019-08-13  Tom Tromey  <tom@tromey.com>
1074
1075         * tui/tui-win.c (tui_resize_all): Call
1076         tui_delete_invisible_windows.
1077         * tui/tui-layout.c (show_layout): Call
1078         tui_delete_invisible_windows.
1079         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1080         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1081
1082 2019-08-13  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1085         tui_add_win_to_layout.
1086
1087 2019-08-13  Tom Tromey  <tom@tromey.com>
1088
1089         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1090         * tui/tui-layout.c (tui_default_win_height): Now static.
1091
1092 2019-08-13  Tom Tromey  <tom@tromey.com>
1093
1094         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1095         single switch.
1096         (show_source_disasm_command, show_source_or_disasm_and_command):
1097         Don't check current layout.
1098
1099 2019-08-13  Tom Tromey  <tom@tromey.com>
1100
1101         * tui/tui-wingeneral.c (make_all_visible): Remove.
1102         (tui_make_all_invisible): Simplify.
1103         * tui/tui-layout.c (tui_make_all_invisible): Move from
1104         tui-wingeneral.c; simplify.
1105         (show_layout): Hoist call to tui_make_all_invisible.
1106         (show_data): Don't call tui_make_all_invisible.
1107
1108 2019-08-13  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1111         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1112
1113 2019-08-13  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1116         tui-data.c.
1117         (show_source_disasm_command, show_data)
1118         (show_source_or_disasm_and_command): Don't use
1119         tui_set_current_layout_to.
1120         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1121         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1122         tui-layout.c.
1123         (tui_set_current_layout_to): Remove.
1124
1125 2019-08-13  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui-layout.c (tui_set_layout): Update.
1128         * tui/tui-data.h (struct tui_layout_def): Remove.
1129         (tui_layout_def): Don't declare.
1130         * tui/tui-data.c (layout_def): Remove.
1131         (tui_layout_def): Remove.
1132
1133 2019-08-13  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui-winsource.h (struct tui_source_window_base)
1136         <clear_detail>: No longer "override".
1137         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1138         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1139         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1140         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1141         Remove.
1142         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1143
1144 2019-08-13  Tom Tromey  <tromey@adacore.com>
1145
1146         * tracepoint.c: Don't include readline.h or history.h.
1147
1148 2019-08-12  Tom Tromey  <tom@tromey.com>
1149
1150         * configure: Rebuild.
1151         * configure.ac: Check for readline 7.
1152         * NEWS: Mention readline 7 requirement.
1153         * README: Update.
1154
1155 2019-08-12  Tom Tromey  <tom@tromey.com>
1156
1157         * mingw-hdep.c (gdb_select): Remove readline hack.
1158
1159 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1160
1161         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1162         when the function fails.
1163
1164 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1165
1166         * s390-tdep.c (s390_type_align): New function.
1167         (s390_gdbarch_init): Set it as type_align gdbarch method.
1168
1169 2019-08-09  Tom de Vries  <tdevries@suse.de>
1170
1171         PR gdb/24591
1172         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1173         pc_low with relocation offset.
1174
1175 2019-08-07  Tom Tromey  <tromey@adacore.com>
1176
1177         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1178         (print_frame_args): Update.
1179         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1180         Update.
1181         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1182         * frame.h (struct frame_arg): Add initializers.
1183         <error>: Now a unique_xmalloc_ptr.
1184
1185 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1186
1187         * NEWS: Expand the Pointer Authentication entry.
1188         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1189         (aarch64_frame_unmask_lr): ... to this.
1190         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1191         Call aarch64_frame_unmask_lr.
1192         * frame.c (struct frame_info): Add "masked" variable.
1193         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1194         (fprint_frame): Check for masked pc.
1195         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1196         declarations.
1197         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1198         * stack.c (print_frame): Check for masked pc.
1199
1200 2019-08-06  Tom Tromey  <tom@tromey.com>
1201
1202         * stabsread.c (patch_block_stabs, read_one_struct_field)
1203         (read_enum_type): Use obstack_strndup.
1204         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1205         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1206         * dwarf2read.c (guess_full_die_structure_name)
1207         (anonymous_struct_prefix): Use obstack_strndup.
1208         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1209         * c-exp.y (yylex): Use obstack_strndup.
1210         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1211         (write_var_or_type): Use obstack_strndup.
1212
1213 2019-08-06  Tom Tromey  <tom@tromey.com>
1214
1215         * symfile.c (reread_symbols): Use obstack_strdup.
1216         * stabsread.c (read_type): Use obstack_strdup.
1217         * gdb_obstack.h (obstack_strdup): New overload.
1218         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1219         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1220         (dwarf2_canonicalize_name): Use obstack_strdup.
1221         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1222         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1223         Use obstack_strdup.
1224
1225 2019-08-06  Tom Tromey  <tom@tromey.com>
1226
1227         * gdb_obstack.h (obstack_strdup): Define.
1228         * gdb_obstack.c (obstack_strdup): Don't define.
1229
1230 2019-08-06  Tom Tromey  <tom@tromey.com>
1231
1232         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1233         obstack_strdup.
1234         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1235         obstack_strdup.
1236         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1237         * stabsread.c (common_block_start): Use obstack_strdup.
1238         * objfiles.c (set_objfile_main_name, objfile): Use
1239         obstack_strdup.
1240         * namespace.c (add_using_directive): Use obstack_strdup.
1241         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1242         * jit.c (finalize_symtab): Use obstack_strdup.
1243         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1244         (guess_partial_die_structure_name, partial_die_info::fixup)
1245         (dwarf2_name): Use obstack_strdup.
1246         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1247         obstack_strdup.
1248         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1249         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1250         obstack_strdup.
1251         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1252
1253 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1254
1255         * unittests/help-doc-selftests.c: New file.
1256         * Makefile.in: Add the new file.
1257
1258 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1259
1260         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1261         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1262         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1263         the trailing '.' is not output, and the first character is uppercased.
1264         (print_help_for_command): Update call to print_doc_line.
1265         (print_doc_of_command): Likewise.
1266         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1267         * cli/cli-option.c (append_indented_doc): Do not append newline.
1268         (build_help_option): Append newline after first appended_indented_doc
1269         only if a second call is done.
1270         (build_help): Append 2 new lines before each option, except the first
1271         one.
1272         * compile/compile.c (_initialize_compile): Add new lines after
1273         %OPTIONS%, when not at the end of the help.
1274         Change help doc or code
1275         producing the help doc to respect the invariants.
1276         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1277         Also removed the new line after 'Options:', as all other commands
1278         do not put an empty line between 'Options:' and the first option.
1279         * printcmd.c (_initialize_printcmd): Likewise.
1280         * stack.c (_initialize_stack): Likewise.
1281         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1282         incorrectly telling COMMAND is optional.
1283         * ada-lang.c (_initialize_ada_language): Change help doc or code
1284         producing the help doc to respect the invariants.
1285         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1286         * breakpoint.c (_initialize_breakpoint): Likewise.
1287         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1288         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1289         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1290         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1291         _initialize_cli_style): Likewise.
1292         * corelow.c (core_target_info): Likewise.
1293         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1294         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1295         * filesystem.c (_initialize_filesystem): Likewise.
1296         * frame.c (_initialize_frame): Likewise.
1297         * gnu-nat.c (add_task_commands): Likewise.
1298         * infcall.c (_initialize_infcall): Likewise.
1299         * infcmd.c (_initialize_infcmd): Likewise.
1300         * interps.c (_initialize_interpreter): Likewise.
1301         * language.c (_initialize_language): Likewise.
1302         * linux-fork.c (_initialize_linux_fork): Likewise.
1303         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1304         * maint.c (_initialize_maint_cmds): Likewise.
1305         * memattr.c (_initialize_mem): Likewise.
1306         * printcmd.c (_initialize_printcmd): Likewise.
1307         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1308         _RegEx): Likewise.
1309         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1310         * record-btrace.c (_initialize_record_btrace): Likewise.
1311         * record-full.c (_initialize_record_full): Likewise.
1312         * record.c (_initialize_record): Likewise.
1313         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1314         * regcache.c (_initialize_regcache): Likewise.
1315         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1316         _initialize_remote): Likewise.
1317         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1318         * serial.c (_initialize_serial): Likewise.
1319         * skip.c (_initialize_step_skip): Likewise.
1320         * source.c (_initialize_source): Likewise.
1321         * stack.c (_initialize_stack): Likewise.
1322         * symfile.c (_initialize_symfile): Likewise.
1323         * symtab.c (_initialize_symtab): Likewise.
1324         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1325         * top.c (init_main): Likewise.
1326         * tracefile-tfile.c (tfile_target_info): Likewise.
1327         * tracepoint.c (_initialize_tracepoint): Likewise.
1328         * tui/tui-win.c (_initialize_tui_win): Likewise.
1329         * utils.c (add_internal_problem_command): Likewise.
1330         * valprint.c (value_print_option_defs): Likewise.
1331
1332 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1333
1334         PR build/24886
1335         * configure.ac: Drop enable-libmcheck support.
1336         * configure, config.in: Rebuild.
1337         * libmcheck.m4: Remove.
1338         * acinclude.m4: Don't include it.
1339         * Makefile.in: Don't distribute it.
1340         * top.c (print_gdb_configuration): Don't mention it.
1341
1342 2019-08-06  Tom Tromey  <tom@tromey.com>
1343
1344         * utils.c (set_output_style): Sometimes pass stream to
1345         emit_style_escape.
1346         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1347         * record-btrace.c (btrace_insn_history): Update.
1348         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1349         method.
1350         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1351         Update initializers.
1352         <m_uiout>: New field.
1353         <m_di>: Move lower.
1354         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1355         Remove "uiout" parameter.
1356         (dump_insns): Update.
1357         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1358         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1359
1360 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1361
1362         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1363         (error_in_psymtab_expansion): Likewise.
1364         (lookup_symbol_via_quick_fns): Likewise.
1365         (basic_lookup_transparent_type_quick): Likewise.
1366         (basic_lookup_transparent_type_1): Likewise.
1367
1368 2019-08-06  Tom Tromey  <tromey@adacore.com>
1369
1370         * source.c (last_source_error): Now bool.
1371         (print_source_lines_base): Make "noprint" bool.  Only open
1372         source file when last_source_visited changes.
1373
1374 2019-08-06  Tom Tromey  <tromey@adacore.com>
1375
1376         * annotate.c (annotate_source_line): Use g_source_cache.
1377         * source-cache.c (source_cache::get_plain_source_lines): Change
1378         parameters.  Populate m_offset_cache.
1379         (source_cache::ensure): New method.
1380         (source_cache::get_line_charpos): New method.
1381         (extract_lines): Move lower.  Change parameters.
1382         (source_cache::get_source_lines): Move lower.
1383         * source-cache.h (class source_cache): Update comment.
1384         <get_line_charpos>: New method.
1385         <get_source_lines>: Update comment.
1386         <clear>: Clear m_offset_cache.
1387         <get_plain_source_lines>: Change parameters.
1388         <ensure>: New method
1389         <m_offset_cache>: New member.
1390         * source.c (forget_cached_source_info_for_objfile): Update.
1391         (info_source_command): Use g_source_cache.
1392         (find_source_lines, open_source_file_with_line_charpos): Remove.
1393         (print_source_lines_base, search_command_helper): Use g_source_cache.
1394         * source.h (open_source_file_with_line_charpos): Don't declare.
1395         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1396         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1397         Use g_source_cache.
1398
1399 2019-08-06  Tom Tromey  <tromey@adacore.com>
1400
1401         * source-cache.c (source_cache::get_plain_source_lines):
1402         Remove "first_line" and "last_line" parameters.
1403         (source_cache::get_source_lines): Cache plain text.
1404         * source-cache.h (class source_cache)
1405         <get_plain_source_lines>: Update.
1406
1407 2019-08-06  Tom Tromey  <tromey@adacore.com>
1408
1409         * source-cache.c (extract_lines): No longer a method.
1410         Changed type of parameter.  Include final newline.
1411         (selftests::extract_lines_test): New function.
1412         (_initialize_source_cache): Likewise.
1413         * source-cache.h (class source_cache)
1414         <extract_lines>: Don't declare.
1415
1416 2019-08-06  Tom Tromey  <tromey@adacore.com>
1417
1418         * breakpoint.c (init_breakpoint_sal): Update.
1419         (breakpoint): Update.
1420         * breakpoint.h (struct breakpoint) <filter>: Now a
1421         unique_xmalloc_ptr.
1422
1423 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1424
1425         * NEWS: Mention dictionary access on blocks.
1426         * python/py-block.c (blpy_getitem): New function.
1427         (block_object_as_mapping): New struct.
1428         (block_object_type): Use new struct for tp_as_mapping field.
1429
1430 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1431
1432         * objfiles.h (objfile): Add a comment describing partial symbols.
1433
1434 2019-08-05  Tom Tromey  <tromey@adacore.com>
1435
1436         * compile/compile.c (_initialize_compile): Use _(), not N_().
1437         * thread.c (_initialize_thread): Use _(), not N_().
1438         * stack.c (_initialize_stack): Use _(), not N_().
1439         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1440
1441 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1442
1443         * dwarf2read.c (struct dw2_symtab_iterator):
1444         <want_specific_block>: Remove.
1445         <block_index>: Change type to gdb::optional.
1446         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1447         change type of BLOCK_INDEX parameter to gdb::optional.
1448         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1449         (dw2_lookup_symbol): Don't pass argument for
1450         WANT_SPECIFIC_BLOCK.
1451         (dw2_expand_symtabs_for_function): Don't pass argument for
1452         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1453         (class dw2_debug_names_iterator)
1454         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1455         parameter, change BLOCK_INDEX type to gdb::optional.
1456         <m_want_specific_block>: Remove.
1457         <m_block_index>: Change type to gdb::optional.
1458         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1459         gdb::optional.  Re-write in function of gdb::optional.
1460         (dw2_debug_names_lookup_symbol): Don't pass argument for
1461         WANT_SPECIFIC_BLOCK.
1462         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1463         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1464         BLOCK_INDEX.
1465
1466 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1467
1468         * NEWS: Mention changes to "info sources" command.
1469
1470 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1471
1472         * symtab.c (filename_partial_match_opts): New struct type.
1473         (struct output_source_filename_data): New members
1474         regexp, c_regexp, partial_match.
1475         (output_source_filename): Use new members to decide to print file.
1476         (info_sources_option_defs): New variable.
1477         (make_info_sources_options_def_group, print_info_sources_header,
1478         info_sources_command_completer):
1479         New functions.
1480         (info_sources_command): Read new optional arguments.
1481         (_initialize_symtab): Update info sources help.
1482
1483 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1484
1485         * ada-lang.c (exception_support_info_v0): Renamed from...
1486         (default_exception_support_info): ... this.  Create new
1487         definition for v1.
1488         (ada_has_this_exception_support): Look up catch_handlers_sym.
1489         (ada_exception_support_info_sniffer): Try v0 after default.
1490
1491 2019-08-01  Tom Tromey  <tromey@adacore.com>
1492
1493         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1494         gdbarch.h.
1495
1496 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1497
1498         * s12z-tdep.c: Fix include path for s12z-opc.h.
1499
1500 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1501
1502         * NEWS: Require GNU make 3.82.
1503
1504 2019-07-16  Tom Tromey  <tom@tromey.com>
1505
1506         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1507         declare.
1508
1509 2019-07-30  Tom Tromey  <tromey@adacore.com>
1510
1511         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1512
1513 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1514
1515         * printcmd.c (print_address_symbolic): Print negative offsets.
1516         (build_address_symbolic): Force signed arithmetic when computing
1517         offset.
1518
1519 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1520
1521         PR/24474: Add a function to lookup static variables.
1522         * NEWS: Mention this new function.
1523         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1524         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1525         * python/python.c (python_GdbMethods): Add new function.
1526
1527 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1528
1529         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1530         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1531         (objfpy_lookup_static_symbol): New function.
1532         (objfile_object_methods): Add new functions.
1533
1534 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1535
1536         * NEWS: Mention 'set|show print frame-info'.  Mention new
1537         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1538         backtrace argument.  Mention that python frame filtering code
1539         is now consistent with what 'backtrace' command prints.
1540
1541 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1542
1543         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1544         comments.
1545         (print_frame_info_auto, print_frame_info_source_line,
1546         print_frame_info_location, print_frame_info_source_and_location,
1547         print_frame_info_location_and_address, print_frame_info_short_location):
1548         New declarations.
1549         (struct frame_print_options): New member print_frame_info.
1550         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1551         * stack.h (get_user_print_what_frame_info): New declaration.
1552         (frame_show_address): New declaration.
1553         * stack.c (print_frame_arguments_choices): New value 'presence'.
1554         (print_frame_info_auto, print_frame_info_source_line,
1555         print_frame_info_location, print_frame_info_source_and_location,
1556         print_frame_info_location_and_address, print_frame_info_short_location,
1557         print_frame_info_choices, print_frame_info_print_what): New definitions.
1558         (print_frame_args): Only print dots for args if print frame-arguments
1559         is 'presence'.
1560         (frame_print_option_defs): New element for "frame-info".
1561         (get_user_print_what_frame_info): New function.
1562         (frame_show_address): Make non static.  Move comment to stack.h.
1563         (print_frame_info_to_print_what): New function.
1564         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1565         to decide what to print.
1566         (backtrace_command_1): Handle the new print_frame_arguments_presence
1567         value.
1568         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1569         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1570         (py_print_frame): In non-mi mode, use LOCATION as default for
1571         print_what, similarly to frame information printed directly by
1572         backtrace command. Handle frame-info user option in non MI mode.
1573
1574 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1575
1576         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1577         Add case for debugging 32-bit target on 64-bit host.  Revise
1578         comment.
1579
1580 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1581
1582         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1583         instead of find_function_entry_range_from_pc.
1584
1585 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1586
1587         * stack.c (find_frame_funname): Remove code which preferred
1588         minsym over symtab sym in "certain pathological cases".
1589
1590         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1591         parameter.  Change type of "do_demangle" to bool.
1592         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1593         Pass suitable "prefer_sym_over_minsym" flag to
1594         build_address_symbolic().  Don't output "+" for negative offsets.
1595         * printcmd.c (print_address_symbolic): Update invocation of
1596         build_address_symbolic to include a "prefer_sym_over_minsym"
1597         flag.
1598         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1599         Restrict cases in which use of minimal symbol is preferred to that
1600         of a found symbol.  Update comments.
1601
1602         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1603         for entry pc when entry pc is out of range for that FDE.
1604
1605 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1606
1607         PR gdb/24839:
1608         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1609         type.
1610
1611 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1612
1613         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1614         this function's Python signature.
1615
1616
1617 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1618
1619         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1620         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1621         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1622         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1623         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1624
1625
1626 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1627
1628         * h8300-tdep.c (h8300_register_name_common): New.
1629         h8300_register_name): Use h8300_register_name_common.
1630         (h8300s_register_name): Likewise.
1631         (h8300sx_register_name): Likewise.
1632         (h8300h_register_nam): New.
1633         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1634
1635
1636 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1637
1638         * arm-tdep.c (arm_skip_cmse_entry): New function.
1639         (arm_is_sgstubs_section): New function.
1640         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1641
1642 2019-07-22  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1645         Don't self-assign.
1646
1647 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1648
1649         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1650         type_print.
1651
1652 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1653
1654         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1655         so that GDB doesn't match any msymbols when searching in the
1656         TYPES_DOMAIN.
1657         (print_symbol_info): Print using typedef_print or type_print based
1658         on the type of the symbol.  Add updated FIXME comment moved from...
1659         (_initialize_symtab): ... move and update FIXME comment to above.
1660
1661 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1662
1663         * NEWS: Mention adding -q option to "info types".
1664         * symtab.c (struct info_types_options): New struct.
1665         (info_types_options_defs): New variable.
1666         (make_info_types_options_def_group): New function.
1667         (info_types_command): Use gdb::option framework to parse options.
1668         (info_types_command_completer): New function.
1669         (_initialize_symtab): Extend the help text on "info types" and
1670         register command completer.
1671
1672 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1673
1674         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1675         (lookup_symbol_in_objfile): Change int to block_enum and add a
1676         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1677
1678 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1679
1680         * MAINTAINERS (Write After Approval): Add self.
1681
1682 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1683
1684         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1685         instruction to the dummy code region.
1686
1687 2019-07-19  Tom Tromey  <tromey@adacore.com>
1688
1689         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1690         (ARGSUSED, PARAMS, __func__): Remove rules.
1691
1692 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1693
1694         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1695         * features/arm/arm-with-iwmmxt.c: Remove.
1696         * features/arm/arm-with-iwmmxt.xml: Remove.
1697         * features/arm/arm-with-m-fpa-layout.c: Remove.
1698         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1699         * features/arm/arm-with-m-vfp-d16.c: Remove.
1700         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1701         * features/arm/arm-with-m.c: Remove.
1702         * features/arm/arm-with-m.xml: Remove.
1703         * features/arm/arm-with-neon.c: Remove.
1704         * features/arm/arm-with-neon.xml: Remove.
1705         * features/arm/arm-with-vfpv2.c: Remove.
1706         * features/arm/arm-with-vfpv2.xml: Remove.
1707         * features/arm/arm-with-vfpv3.c: Remove.
1708         * features/arm/arm-with-vfpv3.xml: Remove.
1709
1710 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1711
1712         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1713
1714 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1715
1716         * arch/aarch32.c (aarch32_create_target_description): Create
1717         target descriptions using features.
1718         * arch/arm.c (arm_create_target_description)
1719         (arm_create_mprofile_target_description): Likewise.
1720         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1721
1722 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1723
1724         * Makefile.in: Add new files.
1725         * aarch32-tdep.c: New file.
1726         * aarch32-tdep.h: New file.
1727         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1728         Call aarch32_read_description.
1729         * arch/aarch32.c: New file.
1730         * arch/aarch32.h: New file.
1731         * arch/arm.c (arm_create_target_description)
1732         (arm_create_mprofile_target_description): New function.
1733         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1734         (arm_create_target_description)
1735         (arm_create_mprofile_target_description): New declaration.
1736         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1737         read_description functions.
1738         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1739         Likewise.
1740         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1741         * arm-tdep.c (tdesc_arm_list): New variable.
1742         (arm_register_g_packet_guesses): Call create description functions.
1743         (arm_read_description) (arm_read_mprofile_description): New
1744         function.
1745         * arm-tdep.h (arm_read_description)
1746         (arm_read_mprofile_description): Add declaration.
1747         * configure.tgt: Add new files.
1748
1749 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1750
1751         * top.c (new_ui_command): Open specified terminal just once.
1752
1753 2019-07-18  Tom Tromey  <tromey@adacore.com>
1754
1755         * symtab.c (main_name): Constify return type.
1756         * symfile.c (set_initial_language): Update.
1757         * symtab.h (main_name): Constify return type.
1758
1759 2019-07-17  Tom Tromey  <tom@tromey.com>
1760
1761         * tui/tui-winsource.c (tui_update_source_window)
1762         (tui_update_source_window_as_is)
1763         (tui_update_source_windows_with_line): Remove return.
1764         * tui/tui-disasm.c (tui_show_disassem)
1765         (tui_show_disassem_and_update_source): Remove return.
1766         * tui/tui.c (tui_reset): Remove return.
1767         * tui/tui-wingeneral.c
1768         (tui_check_and_display_highlight_if_needed): Remove return.
1769
1770 2019-07-17  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1773
1774 2019-07-17  Tom Tromey  <tom@tromey.com>
1775
1776         * tui/tui-winsource.h (struct tui_exec_info_window)
1777         (struct tui_source_window_base): Move from tui-data.h.
1778         * tui/tui-winsource.c: Move many method definitions from
1779         elsewhere.  Remove "structuring" comments.
1780         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1781         (tui_source_window_base::refresh_window): Move to
1782         tui-winsource.c.
1783         * tui/tui-win.c (tui_source_window_base::refresh_all)
1784         (tui_source_window_base::update_tab_width)
1785         (tui_source_window_base::set_new_height)
1786         (tui_source_window_base::do_make_visible_with_new_height): Move to
1787         tui-winsource.c.
1788         * tui/tui-source.h: Update.
1789         * tui/tui-source.c (tui_source_window_base::reset): Move to
1790         tui-winsource.c.
1791         * tui/tui-disasm.h: Update.
1792         * tui/tui-data.h (struct tui_exec_info_window): Move to
1793         tui-winsource.h.
1794         (struct tui_source_window_base): Likewise.
1795         * tui/tui-data.c (tui_source_window_base::clear_detail)
1796         (tui_source_window_base, ~tui_source_window_base): Move to
1797         tui-winsource.c.
1798
1799 2019-07-17  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-win.c (tui_resize_all)
1802         (tui_source_window_base::update_tab_width)
1803         (tui_adjust_win_heights): Update.
1804         (tui_win_info::make_invisible_and_set_new_height): Rename from
1805         make_invisible_and_set_new_height.
1806         * tui/tui-data.h (struct tui_win_info)
1807         <make_invisible_and_set_new_height>: New method.
1808
1809 2019-07-17  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui.c: Update.
1812         * tui/tui-source.h (struct tui_source_window): Move from
1813         tui-data.h.
1814         * tui/tui-layout.c: Update.
1815         * tui/tui-disasm.c: Update.
1816         * tui/tui-data.h (struct tui_source_window): Move to
1817         tui-source.h.
1818
1819 2019-07-17  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1822         tui-data.h.
1823         * tui/tui-data.h (struct tui_disasm_window): Move to
1824         tui-disasm.h.
1825
1826 2019-07-17  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-regs.h (struct tui_data_item_window): Move from
1829         tui-data.h.
1830         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1831         * tui/tui-data.h (struct tui_data_item_window): Move to
1832         tui-regs.h.
1833         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1834
1835 2019-07-17  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui.c: Update.
1838         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1839         (tui_cmd_window::max_height): Move to tui-command.c.
1840         * tui/tui-layout.c: Update.
1841         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1842         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1843         tui-command.c.
1844         * tui/tui-command.h (struct tui_cmd_window): Move from
1845         tui-data.h.
1846         * tui/tui-command.c: Remove "structuring" comments.
1847         (tui_cmd_window::clear_detail)
1848         (tui_cmd_window::do_make_visible_with_new_height)
1849         (tui_cmd_window::max_height): Move from elsewhere.
1850
1851 2019-07-17  Tom Tromey  <tom@tromey.com>
1852
1853         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1854         Now static.
1855         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1856         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1857
1858 2019-07-17  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui.c: Update.
1861         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1862         tui-regs.c.
1863         * tui/tui-windata.h: Remove file.
1864         * tui/tui-windata.c: Remove file.
1865         * tui/tui-win.c (tui_data_window::set_new_height)
1866         (tui_data_window::do_make_visible_with_new_height): Move to
1867         tui-regs.c.
1868         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1869         * tui/tui-regs.c: Remove "structuring" comments.
1870         (tui_data_window::first_data_item_displayed)
1871         (tui_data_window::delete_data_content_windows)
1872         (tui_data_window::erase_data_content)
1873         (tui_data_window::display_all_data)
1874         (tui_data_window::refresh_all)
1875         (tui_data_window::do_scroll_vertical)
1876         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1877         (tui_data_window::do_make_visible_with_new_height)
1878         (tui_data_window::refresh_window): Move from elsewhere.
1879         (_initialize_tui_regs): Move to end of file.
1880         * tui/tui-layout.c: Update.
1881         * tui/tui-hooks.c: Update.
1882         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1883         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1884         tui-regs.c.
1885         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1886
1887 2019-07-17  Tom Tromey  <tom@tromey.com>
1888
1889         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1890         seen.
1891
1892 2019-07-17  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-win.c (tui_source_window_base::set_new_height)
1895         (tui_source_window_base::do_make_visible_with_new_height): Use
1896         m_has_locator field directly.
1897         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1898         method.
1899         (struct tui_source_window_base) <has_locator>: Likewise.
1900
1901 2019-07-17  Tom Tromey  <tom@tromey.com>
1902
1903         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1904         Don't declare.
1905         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1906         Remove.
1907         * tui/tui-win.c (tui_source_window_base::set_new_height)
1908         (tui_source_window_base::set_new_height)
1909         (make_invisible_and_set_new_height)
1910         (tui_source_window_base::do_make_visible_with_new_height)
1911         (tui_source_window_base::do_make_visible_with_new_height):
1912         Update.
1913         * tui/tui-layout.c (show_source_disasm_command, show_data)
1914         (show_source_or_disasm_and_command): Update.
1915         * tui/tui-layout.c (show_layout): Update.
1916
1917 2019-07-17  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-layout.c (make_data_window): Remove.
1920         (show_data): Unify creation and re-initialization cases.
1921
1922 2019-07-17  Tom Tromey  <tom@tromey.com>
1923
1924         * tui/tui-layout.c (make_source_window, make_disasm_window):
1925         Remove.
1926         (show_data): Unify creation and re-initialization cases.
1927
1928 2019-07-17  Tom Tromey  <tom@tromey.com>
1929
1930         * tui/tui-layout.c (make_command_window): Remove.
1931         (show_source_disasm_command, show_source_or_disasm_and_command):
1932         Unify creation and re-initialization cases.
1933
1934 2019-07-17  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1937         creation and re-initialization cases.
1938
1939 2019-07-17  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-regs.c (tui_get_register): Return void.
1942
1943 2019-07-17  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1946         Simplify.
1947
1948 2019-07-17  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1951         resetting.
1952
1953 2019-07-17  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1956         * tui/tui-regs.c (tui_reg_layout): New function.
1957         (tui_show_registers, tui_reg_command): Use it.
1958         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1959         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1960         parameters.
1961         (tui_layout_command): Remove.
1962
1963 2019-07-17  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-layout.h (tui/tui-layout): Return void.
1966         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1967
1968 2019-07-17  Tom Tromey  <tom@tromey.com>
1969
1970         * tui/tui-layout.c (show_source_disasm_command, show_data):
1971         Update.
1972         (reset_locator): Remove.
1973         (show_source_or_disasm_and_command): Update.
1974
1975 2019-07-17  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-source.c (tui_source_window_base::reset): Remove
1978         win_type parameter.
1979         * tui/tui-layout.c (make_command_window, make_source_window)
1980         (make_disasm_window, make_data_window)
1981         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1982         (reset_locator, show_source_or_disasm_and_command): Update.
1983         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1984         win_type parameter.
1985         (struct tui_source_window_base) <reset>: Likewise.
1986
1987 2019-07-17  Tom Tromey  <tom@tromey.com>
1988
1989         * tui/tui-layout.c (show_source_disasm_command): Use
1990         reset_locator.
1991         (reset_locator): New function.
1992         (init_and_make_win): Remove.
1993         (show_source_or_disasm_and_command): Use reset_locator.
1994
1995 2019-07-17  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1998         condition.
1999         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2000         Remove condition.
2001         * tui/tui-source.c (tui_source_window_base::reset): New method.
2002         * tui/tui-layout.c (make_command_window): Don't call
2003         init_and_make_win.
2004         (make_source_window, make_disasm_window): Don't call
2005         make_source_or_disasm_window.
2006         (make_data_window): Don't call init_and_make_win.  Change calling
2007         convention.
2008         (show_source_disasm_command, show_data): Simplify.
2009         (make_source_or_disasm_window): Remove.
2010         (show_source_or_disasm_and_command): Simplify.
2011         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2012         (struct tui_source_window_base) <reset>: Likewise.
2013         <execution_info>: Remove initializer.
2014         * tui/tui-data.c (tui_source_window_base): Initialize
2015         execution_info.
2016
2017 2019-07-17  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2020         variable.
2021
2022 2019-07-17  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui.c (tui_rl_other_window): Update.
2025         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2026         superclass method first.  Always iterate over regs_content.
2027         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2028         method.
2029         * tui/tui-win.c (tui_set_focus_command): Update.
2030
2031 2019-07-17  Tom Tromey  <tom@tromey.com>
2032
2033         * tui/tui-win.c (tui_set_focus_command): Rename from
2034         tui_set_focus.  Call tui_enable.
2035         (tui_set_focus_command): Remove.
2036
2037 2019-07-17  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2040         refresh_window.
2041         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2042         touchwin.
2043         (tui_data_window::refresh_window): Call refresh_window on data
2044         items.  Always call superclass refresh_window.
2045         (tui_win_info::refresh): Remove.
2046         (tui_source_window_base::refresh_window): Update.
2047         (tui_refresh_all): Update.
2048         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2049         refresh_window.
2050         (show_source_or_disasm_and_command): Likewise.
2051         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2052         (struct tui_source_window_base) <refresh>: Likewise.
2053
2054 2019-07-17  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-winsource.c (tui_clear_source_content)
2057         (tui_show_source_content): Update.
2058         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2059         whether content is empty.
2060         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2061         Remove.
2062
2063 2019-07-17  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2066         window's contents.
2067         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2068         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2069
2070 2019-07-17  Tom Tromey  <tom@tromey.com>
2071
2072         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2073         (struct tui_data_item_window): Update.
2074
2075 2019-07-17  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2078         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2079         defines.
2080
2081 2019-07-17  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-winsource.h (tui_erase_source_content)
2084         (tui_clear_source_content): Remove "display_prompt" parameter.
2085         * tui/tui-winsource.c (tui_update_source_window_as_is)
2086         (tui_update_source_windows_with_addr): Update.
2087         (tui_clear_source_content): Remove "display_prompt" parameter.
2088         (tui_erase_source_content): Likewise.  Simplify.
2089         (tui_show_source_content): Update.
2090         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2091         * tui/tui-stack.c (tui_show_frame_info): Update.
2092         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2093         Remove defines.
2094
2095 2019-07-17  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2098         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2099         parameter.
2100         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2101         parameter.
2102
2103 2019-07-17  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-winsource.c (tui_clear_source_content)
2106         (tui_show_source_content, tui_show_exec_info_content)
2107         (tui_clear_exec_info_content): Update.
2108         * tui/tui-stack.c (tui_show_locator_content): Update.
2109         (tui_show_frame_info): Update.
2110         * tui/tui-source.h (tui_source_window): Don't declare.
2111         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2112         from tui_source_is_displayed.
2113         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2114         Remove field.
2115         (struct tui_source_window_base) <content_in_use>: New field.  Now
2116         bool.
2117         (struct tui_source_window) <showing_source_p>: New method.
2118         (TUI_SRC_WIN): Change cast.
2119         * tui/tui-data.c (tui_initialize_static_data): Update.
2120
2121 2019-07-17  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2124         location_matches_p.
2125         * tui/tui-source.c (tui_source_window::location_matches_p): New
2126         method.
2127         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2128         method.
2129         * tui/tui-data.h (struct tui_source_window_base)
2130         <location_matches_p>: New method.
2131         (struct tui_source_window, struct tui_disasm_window)
2132         <location_matches_p>: Likewise.
2133
2134 2019-07-17  Tom Tromey  <tom@tromey.com>
2135
2136         * tui/tui-win.c (tui_set_win_height_command): Rename from
2137         tui_set_win_height.
2138         (tui_set_win_height_command): Remove.
2139
2140 2019-07-17  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-source.c (tui_source_window): New constructor.  Add
2143         observer.
2144         (~tui_source_window): New destructor.
2145         (tui_source_window::style_changed): New method.
2146         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2147         (tui_attach_detach_observers): Update.
2148         * tui/tui-data.h (struct tui_source_window): Make constructor not
2149         inline.  Add destructor.
2150         (struct tui_source_window) <style_changed>: New method.
2151         <m_observable>: New member.
2152
2153 2019-07-17  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2156         * tui/tui-win.c (tui_resize_all): Fix typo.
2157
2158 2019-07-17  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2161         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2162         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2163         * tui/tui-win.c (window_name_completer): Use foreach.
2164         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2165         (update_tab_width): Likewise.
2166         * tui/tui-layout.c (show_layout): Update.
2167         * tui/tui-data.h (class tui_window_iterator): New.
2168         (struct all_tui_windows): New.
2169         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2170
2171 2019-07-17  Tom Tromey  <tom@tromey.com>
2172
2173         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2174         parameter.  Don't reference globals.
2175         (tui_reg_command): Update.
2176
2177 2019-07-17  Tom Tromey  <tom@tromey.com>
2178
2179         * tui/tui-regs.c (tui_show_registers): Simplify.
2180
2181 2019-07-17  Tom Tromey  <tom@tromey.com>
2182
2183         * tui/tui-regs.c (tui_show_registers): Update.
2184         (tui_show_register_group): Add win_info parameter.
2185
2186 2019-07-17  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2189         Rename from tui_display_reg_element_at_line.
2190         (tui_data_window::display_registers_from_line): Update.
2191         * tui/tui-data.h (struct tui_data_window)
2192         <display_reg_element_at_line>: New method.
2193
2194 2019-07-17  Tom Tromey  <tom@tromey.com>
2195
2196         * tui/tui-regs.h (tui_display_registers_from)
2197         (tui_display_registers_from_line): Don't declare.
2198         * tui/tui-windata.c (tui_data_window::display_all_data)
2199         (tui_data_window::refresh_all)
2200         (tui_data_window::do_scroll_vertical): Update.
2201         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2202         from tui_display_registers_from.
2203         (tui_display_reg_element_at_line): Update.
2204         (tui_data_window::display_registers_from_line): Rename from
2205         tui_display_registers_from_line.
2206         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2207         display_registers_from_line>: New methods.
2208
2209 2019-07-17  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2212         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2213         from tui_erase_data_content.
2214         (tui_data_window::display_all_data)
2215         (tui_data_window::refresh_all)
2216         (tui_data_window::do_scroll_vertical): Update.
2217         * tui/tui-regs.c (tui_show_registers): Update.
2218         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2219         New method.
2220
2221 2019-07-17  Tom Tromey  <tom@tromey.com>
2222
2223         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2224         declare.
2225         * tui/tui-windata.c
2226         (tui_data_window::delete_data_content_windows): Rename from
2227         tui_delete_data_content_windows.
2228         (tui_data_window::display_all_data)
2229         (tui_data_window::do_scroll_vertical): Update.
2230         * tui/tui-data.h (struct tui_data_window)
2231         <delete_data_content_windows>: New method.
2232
2233 2019-07-17  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2236         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2237
2238 2019-07-17  Tom Tromey  <tom@tromey.com>
2239
2240         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2241         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2242         from tui_display_all_data.
2243         * tui/tui-win.c
2244         (tui_data_window::do_make_visible_with_new_height): Update.
2245         * tui/tui-regs.c (tui_show_registers): Update.
2246         * tui/tui-layout.c (tui_set_layout): Update.
2247         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2248         method.
2249
2250 2019-07-17  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2253         * tui/tui-windata.c (tui_display_data_from): Remove.
2254         (tui_data_window::refresh_all): Update.
2255
2256 2019-07-17  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2259         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2260         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2261         tui_display_registers_from_line.
2262         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2263         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2264         "force_display" parameter.
2265
2266 2019-07-17  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2269         declare.
2270         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2271         Rename from tui_first_reg_element_no_inline.
2272         (tui_display_reg_element_at_line)
2273         (tui_display_registers_from_line): Update.
2274         * tui/tui-data.h (struct tui_data_window)
2275         <first_reg_element_no_inline>: New method.
2276
2277 2019-07-17  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-windata.c (tui_display_data_from)
2280         (tui_data_window::do_scroll_vertical): Update.
2281         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2282         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2283         Rename from tui_line_from_reg_element_no.
2284         (tui_display_registers_from_line): Update.
2285         * tui/tui-data.h (struct tui_data_window)
2286         <line_from_reg_element_no>: New method.
2287
2288 2019-07-17  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2291         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2292         tui_last_regs_line_no.
2293         (tui_display_reg_element_at_line)
2294         (tui_display_registers_from_line): Update.
2295         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2296         method.
2297
2298 2019-07-17  Tom Tromey  <tom@tromey.com>
2299
2300         PR tui/24722:
2301         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2302         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2303         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2304         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2305         (tui_update_breakpoint_info): Likewise.
2306         * tui/tui-hooks.c (tui_event_create_breakpoint)
2307         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2308         Update.
2309
2310 2019-07-17  Tom Tromey  <tom@tromey.com>
2311
2312         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2313
2314 2019-07-17  Tom Tromey  <tom@tromey.com>
2315
2316         * tui/tui-winsource.c (tui_update_source_window_as_is)
2317         (tui_update_source_windows_with_addr): Update.
2318         * tui/tui-source.h (tui_set_source_content)
2319         (tui_show_symtab_source): Add "win_info" parameter.
2320         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2321         parameter.
2322         (tui_show_symtab_source): Likewise.
2323
2324 2019-07-17  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-wingeneral.c
2327         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2328
2329 2019-07-17  Tom Tromey  <tom@tromey.com>
2330
2331         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2332         (struct tui_cmd_window) <can_scroll>: New method.
2333         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2334         method.
2335
2336 2019-07-17  Tom Tromey  <tromey@adacore.com>
2337
2338         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2339         do_field_signed>: Rename.  Change type of "value".
2340         * ui-out.c (ui_out::field_signed): Rename from field_int.
2341         Change type of "value".
2342         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2343         type of "value".
2344         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2345         do_field_int.  Change type of "value".
2346         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2347         do_field_int.  Change type of "value".
2348         * tracepoint.c (trace_status_mi, tfind_1)
2349         (print_one_static_tracepoint_marker): Update.
2350         * thread.c (print_thread_info_1, print_selected_thread_frame):
2351         Update.
2352         * stack.c (print_frame, print_frame_info): Update.
2353         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2354         Update.
2355         * source.c (print_source_lines_base): Update.
2356         * skip.c (info_skip_command): Update.
2357         * record-btrace.c (btrace_ui_out_decode_error)
2358         (btrace_call_history_src_line): Update.
2359         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2360         Update.
2361         * progspace.c (print_program_space): Update.
2362         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2363         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2364         do_field_int.  Change type of "value".
2365         * mi/mi-out.c (mi_ui_out::do_table_begin)
2366         (mi_ui_out::do_table_header): Update.
2367         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2368         type of "value".
2369         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2370         (mi_cmd_data_list_changed_registers, output_register)
2371         (mi_cmd_data_read_memory, mi_load_progress)
2372         (mi_cmd_trace_frame_collected): Update.
2373         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2374         Update.
2375         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2376         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2377         (mi_cmd_var_list_children, varobj_update_one): Update.
2378         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2379         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2380         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2381         * inferior.c (print_inferior): Update.
2382         * gdb_bfd.c (print_one_bfd): Update.
2383         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2384         Update.
2385         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2386         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2387         do_field_int.  Change type of "value".
2388         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2389         do_field_int.  Change type of "value".
2390         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2391         (print_one_breakpoint_location, print_it_catch_fork)
2392         (print_one_catch_fork, print_it_catch_vfork)
2393         (print_one_catch_vfork, print_it_catch_solib)
2394         (print_it_catch_exec, print_it_ranged_breakpoint)
2395         (print_mention_watchpoint, print_mention_masked_watchpoint)
2396         (bkpt_print_it, update_static_tracepoint): Update.
2397         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2398         * break-catch-syscall.c (print_it_catch_syscall): Update.
2399         * ada-tasks.c (print_ada_task_info): Update.
2400         * ada-lang.c (print_it_exception, print_mention_exception):
2401         Update.
2402
2403 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2404
2405         PR breakpoints/24541
2406         * gdbarch.c: Regenerate.
2407         * gdbarch.h: Regenerate.
2408         * gdbarch.sh: Adjust return type and parameter types for
2409         'stap_adjust_register'.
2410         (i386_stap_adjust_register): Adjust signature and return new
2411         register name.
2412         * stap-probe.c (stap_parse_register_operand): Adjust use of
2413         'gdbarch_stap_adjust_register'.
2414
2415 2019-07-17  Tom Tromey  <tromey@adacore.com>
2416
2417         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2418         declare VEC.
2419         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2420         std::vector.
2421         (struct s390_process_info): Add initializers.
2422         (s390_add_process): Use new.
2423         (s390_linux_nat_target::low_forget_process): Use delete.
2424         (s390_linux_nat_target::low_new_fork)
2425         (s390_linux_nat_target::stopped_by_watchpoint)
2426         (s390_linux_nat_target::low_prepare_to_resume)
2427         (s390_linux_nat_target::insert_watchpoint)
2428         (s390_linux_nat_target::insert_hw_breakpoint)
2429         (s390_linux_nat_target::remove_watchpoint)
2430         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2431
2432 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2433
2434         * aarch64-fbsd-nat.c: Include regcache.h.
2435         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2436         argument.
2437         (aarch64_fbsd_nat_target::fetch_registers)
2438         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2439         variable.
2440         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2441
2442 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2443
2444         * fbsd-nat.c: Include gdbarch.h.
2445
2446 2019-07-15  Tom Tromey  <tromey@adacore.com>
2447
2448         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2449
2450 2019-07-15  Tom Tromey  <tromey@adacore.com>
2451
2452         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2453         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2454         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2455         * cli-out.c (cli_ui_out::do_field_int): New method.
2456         * ui-out.c (ui_out::field_unsigned): New method.
2457         * symfile.c (generic_load): Use field_unsigned.
2458         (print_transfer_performance): Likewise.
2459         * record-btrace.c (ui_out_field_uint): Remove.
2460         (btrace_call_history_insn_range, btrace_call_history): Use
2461         field_unsigned.
2462         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2463         field_unsigned.
2464         * ui-out.h (class ui_out) <field_unsigned>: New method.
2465         <do_field_unsigned>: Likewise.
2466
2467 2019-07-15  Tom Tromey  <tromey@adacore.com>
2468
2469         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2470         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2471         * target.c (flash_erase_command): Use field_string.
2472         * infrun.c (print_signal_received_reason): Use field_string.
2473         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2474         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2475         field_string.
2476         * ada-tasks.c (print_ada_task_info): Use field_string.
2477
2478 2019-07-15  Tom Tromey  <tromey@adacore.com>
2479
2480         * target.c (flash_erase_command): Use field_core_addr.
2481         * symfile.c (generic_load): Use field_core_addr.
2482         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2483         Use field_core_addr.
2484         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2485         field_core_addr.
2486
2487 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2488
2489         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2490         value if its desired type is smaller than a CORE_ADDR and signed.
2491
2492 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2493
2494         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2495         of changes to field names, and use new is_reference field to
2496         decide if a property is a reference or not.
2497         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2498         field.
2499         (struct dwarf2_property_baton): Update header comment, rename
2500         'referenced_type' to 'property_type' and update comments.
2501         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2502         default property type, store in property baton, update to take
2503         accound of renamed field.
2504         (read_func_scope): Update call to attr_to_dynamic_prop.
2505         (read_array_type): Likewise.
2506         (dwarf2_per_cu_addr_sized_int_type): New function.
2507         (read_subrange_index_type): Move type finding code to
2508         dwarf2_per_cu_addr_sized_int_type.
2509         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2510         (dwarf2_per_cu_addr_type): New function.
2511         (set_die_type): Update calls to attr_to_dynamic_prop.
2512
2513 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2514
2515         * dwarf2read.c (read_subrange_index_type): New function.
2516         (read_subrange_type): Move code into new function and call it.
2517         * gdbtypes.c (create_range_type): Add some asserts.
2518
2519 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2520
2521         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2522         update return statements.
2523         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2524         declaration, and update comment to match.
2525         * gdbtypes.c (resolve_dynamic_array): Update call to
2526         dwarf2_evaluate_property to match new return type.
2527
2528 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2529
2530         * valarith.c (value_subscripted_rvalue): Change lowerbound
2531         parameter type from int to LONGEST.
2532         * value.h (value_subscripted_rvalue): Likewise in declaration.
2533
2534 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2535
2536         * cli/cli-utils.c (info_print_command_completer): New function.
2537         * cli/cli-utils.h: Add 'completer.h' include, and forward
2538         declaration for 'struct cmd_list_element'.
2539         (info_print_command_completer): Declare.
2540         * stack.c (_initialize_stack): Add completer for 'info locals' and
2541         'info args'.
2542         * symtab.c (_initialize_symtab): Add completer for 'info
2543         variables' and 'info functions'.
2544         * NEWS: Mention completion for additional info commands.
2545
2546 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2547
2548         * cli/cli-utils.c (extract_info_print_args): Delete.
2549         (extract_arg_maybe_quoted): Delete.
2550         (info_print_options_defs): New variable.
2551         (make_info_print_options_def_group): New function.
2552         (extract_info_print_options): Define new function.
2553         * cli/cli-utils.h (extract_info_print_args): Delete.
2554         (struct info_print_options): New structure.
2555         (extract_info_print_options): Declare new function.
2556         * stack.c (info_locals_command): Update to use new
2557         extract_info_print_options, also add a header comment.
2558         (info_args_command): Likewise.
2559         * symtab.c (info_variables_command): Likewise.
2560         (info_functions_command): Likewise.
2561
2562 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2563
2564         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2565         to extract string arguments.
2566         * common/common-utils.c (extract_string_maybe_quoted): New function.
2567         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2568
2569 2019-07-11  Tom Tromey  <tromey@adacore.com>
2570
2571         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2572         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2573         * top.h (gdbinit): Don't declare.
2574         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2575         into...
2576         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2577         * top.c (gdb_init): Don't call init_cli_cmds.
2578         (gdbinit): Remove.
2579         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2580
2581 2019-07-11  Tom Tromey  <tromey@adacore.com>
2582
2583         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2584         after it has been moved.
2585
2586 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2587
2588         * valops.c (value_must_coerce_to_target): Change return type to
2589         bool.
2590         * value.h (value_must_coerce_to_target): Likewise.
2591
2592 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2593
2594         * breakpoint.c (is_hardware_watchpoint): Remove
2595         forward-declaration.
2596         (is_masked_watchpoint): Change return type to bool.
2597         (is_tracepoint): Likewise.
2598         (is_breakpoint): Likewise.
2599         (is_hardware_watchpoint): Likewise.
2600         (is_watchpoint): Likewise.
2601         (is_no_memory_software_watchpoint): Likewise.
2602         (is_catchpoint): Likewise.
2603         (breakpoint_1): Make FILTER parameter's return type bool.
2604         is_masked_watchpoint): Change return type to bool.
2605         (save_breakpoints): Make FILTER parameter's return type bool.
2606         * breakpoint.h (is_breakpoint): Change return type to bool.
2607         (is_watchpoint): Likewise.
2608         (is_catchpoint): Likewise.
2609         (is_tracepoint): Likewise.
2610
2611 2019-07-10  Tom Tromey  <tom@tromey.com>
2612
2613         * defs.h: Don't include gdbarch.h.
2614         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2615         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2616         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2617         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2618         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2619         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2620         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2621         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2622         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2623         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2624         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2625         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2626         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2627         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2628         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2629         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2630         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2631         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2632         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2633         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2634         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2635         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2636         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2637         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2638         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2639         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2640         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2641
2642 2019-07-10  Tom Tromey  <tromey@adacore.com>
2643
2644         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2645         * breakpoint.c (init_ada_exception_breakpoint): Register as
2646         bp_catchpoint.
2647         (print_one_breakpoint_location, print_one_breakpoint): Use
2648         is_ada_exception_catchpoint.
2649         * ada-lang.c (class ada_catchpoint_location): Pass
2650         bp_loc_software_breakpoint to bp_location constructor.
2651         (is_ada_exception_catchpoint): New function.
2652
2653 2019-07-10  Tom Tromey  <tromey@adacore.com>
2654
2655         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2656         VEC.
2657         (struct arm_exidx_entry): New method operator<.
2658         (struct arm_exidx_data) <section_maps>: Change type.
2659         (arm_exidx_data_free): Remove.
2660         (arm_exidx_data_key): Change type.  Move lower.
2661         (arm_exidx_new_objfile): Update.
2662         (arm_compare_exidx_entries): Remove.
2663         (arm_find_exidx_entry, _initialize_arm_tdep)
2664
2665 2019-07-10  Tom Tromey  <tromey@adacore.com>
2666
2667         * solib-spu.c (ocl_program_data_key): Change type.
2668         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2669         Update.
2670
2671 2019-07-10  Tom Tromey  <tromey@adacore.com>
2672
2673         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2674         (struct solib_aix_inferior_data) <library_list>: Change type.
2675         (solib_aix_inferior_data_handle): Change type.
2676         (get_solib_aix_inferior_data): Update.
2677         (solib_aix_free_library_list): Remove.
2678         (library_list_start_library): Update.
2679         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2680         return type.
2681         (solib_aix_get_library_list)
2682         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2683         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2684
2685 2019-07-10  Tom Tromey  <tromey@adacore.com>
2686
2687         * solib-dsbt.c (struct dsbt_info): Add initializers.
2688         (solib_dsbt_pspace_data): Change type.
2689         (dsbt_pspace_data_cleanup): Remove.
2690         (get_dsbt_info, _initialize_dsbt_solib): Update.
2691
2692 2019-07-10  Tom Tromey  <tromey@adacore.com>
2693
2694         * spu-tdep.c (spu_overlay_data): Change type.
2695         (spu_get_overlay_table, spu_overlay_new_objfile)
2696         (_initialize_spu_tdep): Update.
2697
2698 2019-07-10  Tom Tromey  <tromey@adacore.com>
2699
2700         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2701         destructor.
2702         (dbx_objfile_data_key): Change type and declare later.
2703         (DBX_SYMFILE_INFO): Rewrite.
2704         * dbxread.c (dbx_objfile_data_key): Change type.
2705         (dbx_symfile_init): Update.
2706         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2707         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2708         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2709
2710 2019-07-10  Tom Tromey  <tromey@adacore.com>
2711
2712         * jit.c (jit_program_space_key): Change type.  Move lower.
2713         (get_jit_program_space_data): Update.
2714         (jit_program_space_data_cleanup): Remove.
2715         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2716         Update.
2717         (struct jit_program_space_data): Add initializers.
2718
2719 2019-07-10  Tom Tromey  <tromey@adacore.com>
2720
2721         * solib-darwin.c (struct darwin_info): Add initializers.
2722         (solib_darwin_pspace_data): Change type.
2723         (darwin_pspace_data_cleanup): Remove.
2724         (get_darwin_info, _initialize_darwin_solib): Update.
2725
2726 2019-07-10  Tom Tromey  <tromey@adacore.com>
2727
2728         * remote-sim.c (struct sim_inferior_data): Add initializers,
2729         constructor, and destructor.
2730         (sim_inferior_data_key): Change type.  Move lower.
2731         (check_for_duplicate_sim_descriptor): Update.
2732         (get_sim_inferior_data): Use new.  Update.
2733         (~sim_inferior_data_cleanup): Rename from
2734         sim_inferior_data_cleanup.  Simplify.
2735         (gdbsim_close_inferior, simulator_command)
2736         (sim_command_completer, _initialize_remote_sim): Update.
2737         (next_pid, INITIAL_PID): Move earlier.
2738
2739 2019-07-10  Tom Tromey  <tromey@adacore.com>
2740
2741         * python/python-internal.h (create_thread_object): Return
2742         gdbpy_ref.
2743         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2744         * python/py-inferior.c (struct threadlist_entry): Add
2745         constructor.
2746         <thread_obj>: Now a gdbpy_ref.
2747         (thread_to_thread_object): Update.
2748         (add_thread_object): Use new.
2749         (delete_thread_object): Use delete.
2750         (infpy_threads): Update.
2751         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2752         GIL.
2753
2754 2019-07-10  Tom Tromey  <tromey@adacore.com>
2755
2756         * valops.c (value_cast): Specialize error message for Ada.
2757
2758 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2759
2760         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2761
2762 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2763
2764         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2765         bpstat_should_step): Return bool, adjust comments.
2766         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2767         bpstat_should_step): Likewise.
2768
2769 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2770
2771         * features/Makefile: Use feature target descriptions for Arm.
2772         * features/arm/arm-core.c: Generate new file.
2773         * features/arm/arm-fpa.c: Likewise.
2774         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2775         * features/arm/arm-m-profile.c: Likewise.
2776         * features/arm/arm-vfpv2.c: Likewise.
2777         * features/arm/arm-vfpv3.c: Likewise.
2778         * features/arm/xscale-iwmmxt.c: Likewise.
2779         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2780
2781 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2782
2783         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2784         ptrace earlier.
2785
2786 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2787
2788         * features/aarch64-pauth.c: Regenerate.
2789
2790 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2791
2792         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2793         bool.
2794         (bpstat_what): Use false instead of 0.
2795
2796 2019-07-09  Pedro Alves  <palves@redhat.com>
2797
2798         * break-catch-throw.c (is_exception_catchpoint): New.
2799         * breakpoint.c (print_one_breakpoint_location): New parameter
2800         'raw_loc'.  Handle it.  Use
2801         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2802         looking at the breakpoint's type.
2803         (print_one_breakpoint): If handling "maint info breakpoints", also
2804         print locations of exception catchpoints.
2805         * breakpoint.h (is_exception_catchpoint): Declare.
2806
2807 2019-07-09  Pedro Alves  <palves@redhat.com>
2808
2809         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2810         "addr" field.
2811         (allocate_location_exception_catchpoint): New.
2812         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2813         (initialize_throw_catchpoint_ops): Install
2814         allocate_location_exception_catchpoint as allocate_location
2815         method.
2816         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2817         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2818         bp_loc_other.
2819         (breakpoint_address_is_meaningful): Delete.
2820         (bl_address_is_meaningful): New.
2821         (breakpoint_locations_match): Adjust comment.
2822         (bp_location_from_bp_type): New, factored out of...
2823         (bp_location::bp_location(breakpoint *)): ... this.
2824         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2825         factored out of...
2826         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2827         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2828         breakpoint_address_is_meaningful.
2829         (bp_locations_compare): Adjust comment.
2830         (update_global_location_list): Use bl_address_is_meaningful
2831         instead of breakpoint_address_is_meaningful.
2832         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2833         explicit.
2834         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2835         * python/py-breakpoint.c (bppy_get_location): No longer check
2836         whether location is null.
2837
2838 2019-07-09  Pedro Alves  <palves@redhat.com>
2839
2840         PR c++/15468
2841         * breakpoint.c (print_one_breakpoint_location): Remove
2842         single-location assert.
2843
2844 2019-07-09  Tom Tromey  <tom@tromey.com>
2845
2846         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2847         * configure: Rebuild.
2848         * configure.ac: Change common to gdbsupport.
2849         * gdbsupport: Rename from common.
2850         * acinclude.m4: Change common to gdbsupport.
2851         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2852         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2853         gdbsupport.
2854         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2855         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2856         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2857         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2858         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2859         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2860         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2861         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2862         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2863         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2864         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2865         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2866         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2867         coff-pe-read.c, command.h, compile/compile-c-support.c,
2868         compile/compile-c.h, compile/compile-cplus-symbols.c,
2869         compile/compile-cplus-types.c, compile/compile-cplus.h,
2870         compile/compile-loc2c.c, compile/compile.c, completer.c,
2871         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2872         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2873         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2874         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2875         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2876         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2877         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2878         features/aarch64-core.c, features/aarch64-fpu.c,
2879         features/aarch64-pauth.c, features/aarch64-sve.c,
2880         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2881         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2882         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2883         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2884         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2885         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2886         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2887         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2888         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2889         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2890         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2891         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2892         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2893         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2894         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2895         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2896         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2897         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2898         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2899         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2900         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2901         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2902         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2903         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2904         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2905         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2906         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2907         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2908         minsyms.c, mips-linux-tdep.c, namespace.h,
2909         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2910         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2911         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2912         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2913         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2914         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2915         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2916         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2917         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2918         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2919         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2920         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2921         procfs.c, producer.c, progspace.h, psymtab.h,
2922         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2923         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2924         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2925         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2926         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2927         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2928         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2929         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2930         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2931         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2932         target-memory.c, target.c, target.h, target/waitstatus.c,
2933         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2934         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2935         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2936         unittests/array-view-selftests.c,
2937         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2938         unittests/common-utils-selftests.c,
2939         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2940         unittests/format_pieces-selftests.c,
2941         unittests/function-view-selftests.c,
2942         unittests/lookup_name_info-selftests.c,
2943         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2944         unittests/mkdir-recursive-selftests.c,
2945         unittests/observable-selftests.c,
2946         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2947         unittests/parse-connection-spec-selftests.c,
2948         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2949         unittests/scoped_fd-selftests.c,
2950         unittests/scoped_mmap-selftests.c,
2951         unittests/scoped_restore-selftests.c,
2952         unittests/string_view-selftests.c, unittests/style-selftests.c,
2953         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2954         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2955         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2956         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2957         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2958         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2959
2960 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2961
2962         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2963         bool value.
2964         (decode_digits_ordinary): Set explicit_line field in sal.
2965         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2966         symtab_and_line that was set on an explicit line number in
2967         assembler code.  Do always update the recorded symtab and line if
2968         we do skip the prologue.
2969
2970 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2971
2972         * breakpoint.c (set_breakpoint_location_function): Remove
2973         explicit_loc parameter.
2974         (momentary_breakpoint_from_master): Update call to
2975         set_breakpoint_location_function.
2976         (add_location_to_breakpoint): Likewise.
2977
2978 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2979
2980         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2981         required features based on default bfd type when no specific bfd
2982         is present.
2983
2984 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2985
2986         * NEWS: Mention that GDB printf and eval commands can now print
2987         C-style and Ada-style convenience var strings without
2988         calling the inferior.
2989         * printcmd.c (printf_c_string): Locally print GDB internal var
2990         instead of transiting via the inferior.
2991         (printf_wide_c_string): Likewise.
2992
2993 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2994
2995         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2996
2997 2019-07-04  Tom Tromey  <tom@tromey.com>
2998
2999         PR tui/24724:
3000         * tui/tui-winsource.c (tui_clear_source_content): Update.
3001         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3002         (tui_update_breakpoint_info): Update.
3003         (tui_set_exec_info_content): Update.
3004         * tui/tui-source.c (tui_set_source_content_nil): Update.
3005         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3006         has_break.
3007         * tui/tui-data.h (enum tui_bp_flag): New.
3008         (tui_bp_flags): New enum flags type.
3009         (struct tui_source_element) <break_mode>: Change type.  Rename
3010         from has_break.
3011         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3012         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3013         constants.
3014         * tui/tui-winsource.h: Fix comment.
3015
3016 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3017
3018         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3019         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3020         (store_fpregs_to_thread)
3021         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3022         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3023         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3024         (IWMMXT_REGS_SIZE): Add define.
3025         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3026         (fetch_vfp_regs, store_vfp_regs)
3027         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3028         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3029
3030 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3031
3032         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3033         defines.
3034         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3035         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3036         (ARM_INT_REGISTER_SIZE): ...to this.
3037         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3038         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3039         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3040         (arm_linux_collect_gregset, supply_nwfpe_register)
3041         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3042         defines.
3043         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3044         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3045         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3046         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3047         (arm_return_in_memory, arm_store_return_value)
3048         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3049         (arm_record_ld_st_multiple): Likewise.
3050         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3051         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3052
3053 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3054
3055         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3056         AARCH64_DISPLACED_MODIFIED_INSNS.
3057         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3058         (aarch64_displaced_step_copy_insn): Likewise.
3059         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3060         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3061         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3062         ARM_DISPLACED_MODIFIED_INSNS.
3063         * arm-tdep.c (arm_gdbarch_init): Likewise.
3064         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3065         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3066         (struct arm_displaced_step_closure): Use
3067         ARM_DISPLACED_MODIFIED_INSNS.
3068
3069 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3070
3071         * features/Makefile: Remove unused xml files.
3072         * features/aarch64.xml: Remove.
3073         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3074         * features/i386/amd64-avx-avx512.xml: Remove.
3075         * features/i386/amd64-avx-linux.xml: Remove.
3076         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3077         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3078         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3079         * features/i386/amd64-avx-mpx.xml: Remove.
3080         * features/i386/amd64-avx.xml: Remove.
3081         * features/i386/amd64-linux.xml: Remove.
3082         * features/i386/amd64-mpx-linux.xml: Remove.
3083         * features/i386/amd64-mpx.xml: Remove.
3084         * features/i386/amd64.xml: Remove.
3085         * features/i386/i386-avx-avx512-linux.xml: Remove.
3086         * features/i386/i386-avx-avx512.xml: Remove.
3087         * features/i386/i386-avx-linux.xml: Remove.
3088         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3089         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3090         * features/i386/i386-avx-mpx-linux.xml: Remove.
3091         * features/i386/i386-avx-mpx.xml: Remove.
3092         * features/i386/i386-avx.xml: Remove.
3093         * features/i386/i386-linux.xml: Remove.
3094         * features/i386/i386-mmx-linux.xml: Remove.
3095         * features/i386/i386-mmx.xml: Remove.
3096         * features/i386/i386-mpx-linux.xml: Remove.
3097         * features/i386/i386-mpx.xml: Remove.
3098         * features/i386/i386.xml: Remove.
3099         * features/i386/x32-avx-avx512-linux.xml: Remove.
3100         * features/i386/x32-avx-linux.xml: Remove.
3101         * features/i386/x32-linux.xml: Remove.
3102
3103 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3104
3105         * regformats/aarch64.dat: Remove.
3106         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3107         * regformats/i386/amd64-avx-linux.dat: Remove.
3108         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3109         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3110         * regformats/i386/amd64-linux.dat: Remove.
3111         * regformats/i386/amd64-mpx-linux.dat: Remove.
3112         * regformats/i386/amd64.dat: Remove.
3113         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3114         * regformats/i386/i386-avx-linux.dat: Remove.
3115         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3116         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3117         * regformats/i386/i386-linux.dat: Remove.
3118         * regformats/i386/i386-mmx-linux.dat: Remove.
3119         * regformats/i386/i386-mpx-linux.dat: Remove.
3120         * regformats/i386/i386.dat: Remove.
3121         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3122         * regformats/i386/x32-avx-linux.dat: Remove.
3123         * regformats/i386/x32-linux.dat: Remove.
3124
3125 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3126
3127         * aarch64-tdep.c: Remove xml self tests.
3128         * amd64-linux-tdep.c: Likewise.
3129         * amd64-tdep.c: Likewise.
3130         * i386-linux-tdep.c: Likewise.
3131         * i386-tdep.c: Likewise.
3132
3133 2019-07-03  Pedro Alves  <palves@redhat.com>
3134
3135         PR cli/24732
3136         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3137         (pipe_cmd_option_defs): New.
3138         (make_pipe_cmd_options_def_group): New.
3139         (pipe_command): Use gdb::option::process_options.
3140         (pipe_command_completer): New function.
3141         (_initialize_cli_cmds): Install completer for "pipe" command.
3142
3143 2019-07-03  Pedro Alves  <palves@redhat.com>
3144
3145         * cli/cli-option.c (union option_value) <string>: New field.
3146         (struct option_def_and_value): Add ctor, move ctor, dtor and
3147         use DISABLE_COPY_AND_ASSIGN.
3148         (option_def_and_value::clear_value): New.
3149         (parse_option, save_option_value_in_ctx, get_val_type_str)
3150         (add_setshow_cmds_for_options): Handle var_string.
3151         * cli-option.h (union option_def::var_address) <string>: New
3152         field.
3153         (struct string_option_def): New.
3154         * maint-test-options.c (struct test_options_opts): Add default
3155         ctor and use DISABLE_COPY_AND_ASSIGN.
3156         <string_opt>: New field.
3157         (test_options_opts::~test_options_opts): New.
3158         (test_options_opts::dump): Also dump "-string".
3159         (test_options_option_defs): Install "string.
3160
3161 2019-07-03  Pedro Alves  <palves@redhat.com>
3162
3163         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3164         option_value with a null enumeration.
3165         (complete_options): Save the option values in the context.
3166         (save_option_value_in_ctx): New, factored out from ...
3167         (process_options): ... here.
3168         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3169         of the function.
3170         * maint-test-options.c (test_options_opts::dump): New, factored
3171         out from ...
3172         (maintenance_test_options_command_mode): ... here.
3173         (maintenance_test_options_command_completion_result): Delete.
3174         (maintenance_test_options_command_completion_text): Update
3175         comment.
3176         (maintenance_show_test_options_completion_result): Change
3177         prototype.  Just print
3178         maintenance_test_options_command_completion_text.
3179         (save_completion_result): New.
3180         (maintenance_test_options_completer_mode): Pass options context to
3181         complete_options, and then save a dump.
3182         (_initialize_maint_test_options): Use add_cmd to install "maint
3183         show test-options-completion-result".
3184
3185 2019-07-03  Pedro Alves  <palves@redhat.com>
3186
3187         * NEWS (New commands): Mention "with" and "maint with".
3188         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3189         (with_command, with_command_completer): New.
3190         (pipe_command): Adjust to new repeat_previous
3191         interface.
3192         (_initialize_cli_cmds): Install the "with" command and its "w"
3193         alias.
3194         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3195         declarations.
3196         * cli/cli-setshow.c (parse_cli_var_uinteger)
3197         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3198         argument strings for all var_types.
3199         (get_setshow_command_value_string): New, factored out from ...
3200         (do_show_command): ... this.
3201         * cli/cli-setshow.h: Include <string>.
3202         (get_setshow_command_value_string): Declare.
3203         * command.h (repeat_previous): Now returns const char *.  Adjust
3204         comment.
3205         * maint.c: Include "cli/cli-cmds.h".
3206         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3207         (_initialize_maint_cmds): Register the "maintenance with" command.
3208         * top.c (repeat_previous): Move bits from pipe_command here:
3209         Return the saved command line, if any; error out if there's no
3210         command to relaunch.
3211
3212 2019-07-03  Pedro Alves  <palves@redhat.com>
3213
3214         * NEWS (New commands): Mention "maint set/show test-settings"
3215         instead of "maint test-settings".
3216         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3217         (maintenance_test_settings_set_list): Rename to ...
3218         (maintenance_set_test_settings_list): ... this.
3219         (maintenance_test_settings_show_list): Rename to  ...
3220         (maintenance_show_test_settings_list): ... this.
3221         (maintenance_test_settings_cmd): Delete.
3222         (maintenance_test_settings_set_cmd): ...
3223         (maintenance_set_test_settings_cmd): ... this.
3224         (maintenance_test_settings_show_cmd): ...
3225         (maintenance_show_test_settings_cmd): ... this.
3226         (maintenance_test_settings_show_value_cmd):
3227         (maintenance_show_test_settings_value_cmd): ... this.
3228         (_initialize_maint_test_settings): No longer install the "maint
3229         test-settings" prefix command.  Rename "maint test-settings set"
3230         to "maint set test-settings", and "maint test-settings show" to
3231         "maint show test-settings".  Adjust all subcommands.
3232
3233 2019-07-03  Pedro Alves  <palves@redhat.com>
3234
3235         * maint-test-settings.c: Fix file's intro comment.  Replace all
3236         references to "test-options" with references to "test-settings",
3237         in comments.
3238
3239 2019-07-03  Pedro Alves  <palves@redhat.com>
3240
3241         * maint-test-settings.c (maintenance_test_settings_xxx)
3242         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3243         New.
3244         (maintenance_test_settings_enums): Use them.
3245         (maintenance_test_settings_enum): Default to
3246         maintenance_test_settings_xxx.
3247         (_initialize_maint_test_settings): Initialize
3248         MAINTENANCE_TEST_SETTINGS_FILENAME.
3249
3250 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3251
3252         * breakpoint.h (remove_breakpoints_inf): Change return type to
3253         void, move function documentation here.
3254         * breakpoint.c (remove_breakpoints_inf): Change return type to
3255         void, move function documentation to header.
3256
3257 2019-07-02  Pedro Alves  <palves@redhat.com>
3258
3259         * NEWS (Completion improvements): Mention "info threads".
3260         * thread.c (struct info_threads_opts, info_threads_option_defs)
3261         (make_info_threads_options_def_group): New.
3262         (info_threads_command): Use gdb::option::process_options.
3263         (info_threads_command_completer): New.
3264         (_initialize_thread): Use gdb::option::build_help to build the
3265         help text for "info threads".
3266
3267 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3268
3269         * defs.h (generic_load): Move from here...
3270         * symfile.h (generic_load): ... to here.  Rename name parameter
3271         to args.
3272         * symfile.c (generic_load): Add comment.
3273
3274 2019-07-01  Tom Tromey  <tromey@adacore.com>
3275
3276         * dwarf2read.c
3277         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3278         declaration of without_params.  Fix formatting.
3279
3280 2019-07-01  Tom Tromey  <tromey@adacore.com>
3281
3282         * ada-exp.y (find_primitive_type): Update.
3283         * ada-lang.h (ada_lookup_symbol): Update.
3284         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3285         parameter.
3286         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3287
3288 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3289
3290         PR breakpoints/24541
3291         * gdbarch.c: Regenerate.
3292         * gdbarch.h: Regenerate.
3293         * gdbarch.sh: Add 'stap_adjust_register'.
3294         * i386-tdep.c: Include '<unordered_set>'.
3295         (i386_stap_adjust_register): New function.
3296         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3297         * stap-probe.c (stap_parse_register_operand): Call
3298         'gdbarch_stap_adjust_register'.
3299
3300 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3301
3302         PR python/24742
3303         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3304         * python/python.c (do_start_initialization): Use 'xmalloc'
3305         instead of 'PyMem_Malloc'.
3306
3307 2019-06-28  Tom Tromey  <tromey@adacore.com>
3308
3309         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3310         for Ada.
3311
3312 2019-06-27  Tom Tromey  <tromey@adacore.com>
3313
3314         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3315         objfile_key.
3316         (arm_find_mapping_symbol, arm_record_special_symbol)
3317         (_initialize_arm_tdep): Update.
3318         (arm_objfile_data_free): Remove.
3319
3320 2019-06-27  Tom Tromey  <tromey@adacore.com>
3321
3322         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3323         to cp_print_static_field.
3324
3325 2019-06-26  Tom Tromey  <tromey@adacore.com>
3326
3327         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3328         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3329         declare.
3330
3331 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3332
3333         * features/aarch64-core.c (create_feature_aarch64_core):
3334         Regenerate.
3335         * features/aarch64-core.xml: Add cpsr flags.
3336
3337 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3338
3339         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3340         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3341
3342 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3343
3344         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3345         field.
3346         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3347         use.
3348         (arm_record_special_symbol): Don't insert new symbol in sorted
3349         position, push it at the end.
3350
3351 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3352
3353         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3354         (arm_mapping_symbol_s): Remove.
3355         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3356         (arm_mapping_symbol_vec): New typedef.
3357         (struct arm_per_objfile): Add constructor.
3358         <section_maps>: Change type to
3359         std::unique_ptr<arm_mapping_symbol_vec[]>.
3360         (arm_compare_mapping_symbols): Remove.
3361         (arm_find_mapping_symbol): Adjust to section_maps type change.
3362         (arm_objfile_data_free): Call delete on arm_per_objfile.
3363         (arm_record_special_symbol): Adjust to section_maps type change.
3364         Allocate arm_per_objfile with new.
3365
3366 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3367
3368         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3369         with the command prefix.
3370
3371 2019-06-25  Tom Tromey  <tom@tromey.com>
3372
3373         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3374         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3375
3376 2019-06-25  Tom Tromey  <tom@tromey.com>
3377
3378         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3379         type.
3380         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3381         protected.
3382
3383 2019-06-25  Tom Tromey  <tom@tromey.com>
3384
3385         * tui/tui-winsource.c
3386         (tui_source_window_base::set_is_exec_point_at): Add check against
3387         LOA_ADDRESS.
3388
3389 2019-06-25  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-source.c (tui_set_source_content): Don't check before
3392         xfree.
3393         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3394
3395 2019-06-25  Tom Tromey  <tom@tromey.com>
3396
3397         * tui/tui-winsource.h (tui_update_source_window_as_is)
3398         (tui_alloc_source_buffer, tui_line_is_displayed)
3399         (tui_addr_is_displayed): Change type of win_info.
3400         * tui/tui-winsource.c (tui_update_source_window_as_is)
3401         (tui_clear_source_content, tui_show_source_line)
3402         (tui_show_source_content, tui_source_window_base::refill)
3403         (tui_source_window_base::set_is_exec_point_at)
3404         (tui_source_window_base::set_is_exec_point_at)
3405         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3406         (tui_alloc_source_buffer, tui_line_is_displayed)
3407         (tui_addr_is_displayed): Change type of win_info.  Update.
3408         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3409         (tui_source_window_base::do_make_visible_with_new_height):
3410         Update.
3411         * tui/tui-source.c (tui_set_source_content)
3412         (tui_set_source_content_nil)
3413         (tui_source_window::do_scroll_vertical): Update.
3414         * tui/tui-layout.c (show_layout): Update.
3415         * tui/tui-disasm.c (tui_set_disassem_content)
3416         (tui_disasm_window::do_scroll_vertical): Update.
3417         * tui/tui-data.h (tui_win_content): Remove.
3418         (struct tui_gen_win_info) <content, content_size>: Remove.
3419         (struct tui_source_element): Add initializers and destructor.
3420         (union tui_which_element, struct tui_win_element): Remove.
3421         (struct tui_source_window_base) <content>: New field.
3422         (struct tui_data_window): Remove destructor.
3423         (tui_alloc_content, tui_free_win_content)
3424         (tui_free_all_source_wins_content): Don't declare.
3425         * tui/tui-data.c (tui_initialize_static_data): Update.
3426         (init_content_element, tui_alloc_content): Remove.
3427         (~tui_gen_win_info): Update.
3428         (~tui_data_window, tui_free_all_source_wins_content)
3429         (tui_free_win_content, free_content, free_content_elements):
3430         Remove.
3431
3432 2019-06-25  Tom Tromey  <tom@tromey.com>
3433
3434         * tui/tui-winsource.h (tui_clear_source_content)
3435         (tui_erase_source_content, tui_show_source_content): Change type
3436         of win_info.
3437         * tui/tui-winsource.c (tui_clear_source_content)
3438         (tui_erase_source_content, tui_show_source_content): Change type
3439         of win_info.
3440         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3441         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3442         win_info.
3443         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3444         win_info.
3445         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3446
3447 2019-06-25  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-winsource.c (tui_clear_source_content)
3450         (tui_source_window_base::set_is_exec_point_at): Update.
3451         * tui/tui-source.c (tui_set_source_content_nil): Update.
3452         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3453         a bool.
3454         * tui/tui-data.c (init_content_element): Update.
3455
3456 2019-06-25  Tom Tromey  <tom@tromey.com>
3457
3458         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3459         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3460         * tui/tui-layout.c (init_and_make_win): Update.
3461         * tui/tui.h (enum tui_win_type): Update.
3462         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3463         tui_win_is_auxillary.
3464         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3465         tui_win_is_auxillary.
3466
3467 2019-06-25  Tom Tromey  <tom@tromey.com>
3468
3469         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3470         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3471         (tui_delete_data_content_windows, tui_display_all_data)
3472         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3473         Update.
3474         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3475         * tui/tui-regs.c (tui_last_regs_line_no)
3476         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3477         (tui_show_registers): Update.
3478         (tui_show_register_group): Return void.  Update.
3479         (tui_display_registers_from, tui_display_reg_element_at_line)
3480         (tui_display_registers_from_line, tui_check_register_values):
3481         Update.
3482         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3483         member.
3484         (struct tui_data_window) <regs_content>: Now a std::vector.
3485         <regs_content_count>: Remove.
3486         (tui_add_content_elements, tui_free_data_content): Don't declare.
3487         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3488         (init_content_element): Remove DATA_WIN case.  Add assert.
3489         (tui_add_content_elements): Remove.
3490         (tui_data_window): Update.
3491         (tui_free_data_content): Remove.
3492         (free_content_elements): Remove DATA_WIN case.
3493
3494 2019-06-25  Tom Tromey  <tom@tromey.com>
3495
3496         * tui/tui-data.c (tui_data_item_window): Update.
3497         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3498         * tui/tui-windata.c (tui_display_all_data)
3499         (tui_display_data_from_line): Update.
3500         (tui_check_data_values): Remove.
3501         * tui/tui-regs.c (tui_show_register_group)
3502         (tui_display_reg_element_at_line): Update.
3503         * tui/tui-hooks.c (tui_register_changed)
3504         (tui_refresh_frame_and_register_information): Call
3505         tui_check_register_values.
3506         * tui/tui-data.h (struct tui_data_window) <data_content,
3507         data_content_count, data_type>: Remove.
3508         (enum tui_data_type): Remove.
3509
3510         * tui/tui-data.c (tui_data_window::clear_detail)
3511         (~tui_data_window): Update.
3512
3513 2019-06-25  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3516         declare.
3517         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3518         Rename from tui_first_data_item_displayed.  Update.
3519         (tui_data_window::refresh_all)
3520         (tui_data_window::do_scroll_vertical): Update.
3521         * tui/tui-data.h (struct tui_data_window)
3522         <first_data_item_displayed>: Declare new method.
3523
3524 2019-06-25  Tom Tromey  <tom@tromey.com>
3525
3526         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3527         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3528         contents...
3529         (tui_initialize_static_data): ...here.
3530
3531 2019-06-25  Tom Tromey  <tom@tromey.com>
3532
3533         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3534         (tui_display_registers_from, tui_check_register_values): Update.
3535         (tui_display_register): Remove win_info parameter; update.
3536         (tui_get_register): Change type of parameters.
3537         * tui/tui-data.h (struct tui_data_element): Remove.
3538         (union tui_which_element) <data>: Remove.
3539         <data_window>: Change type.
3540         (struct tui_data_item_window): New.
3541         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3542         case.  Add assert.
3543         (~tui_data_item_window): New destructor.
3544         (free_content_elements): Remove DATA_ITEM_WIN case.
3545
3546 2019-06-25  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3549         Remove.
3550
3551 2019-06-25  Tom Tromey  <tom@tromey.com>
3552
3553         * tui/tui-data.h (struct tui_command_element): Remove.
3554         (union tui_which_element) <command>: Remove.
3555         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3556         assert.
3557         (free_content_elements): Remove CMD_WIN case.
3558
3559 2019-06-25  Tom Tromey  <tom@tromey.com>
3560
3561         * tui/tui-layout.c (tui_set_layout): Update.
3562         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3563         * tui/tui-data.c (layout_def): Update.
3564
3565 2019-06-25  Tom Tromey  <tom@tromey.com>
3566
3567         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3568         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3569         (tui_source_window_base::set_new_height): Update.
3570         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3571         Update.
3572         (tui_set_locator_fullname, tui_set_locator_info)
3573         (tui_show_frame_info): Update.
3574         * tui/tui-source.c (tui_set_source_content)
3575         (tui_source_is_displayed): Update.
3576         * tui/tui-layout.c (show_source_disasm_command, show_data)
3577         (show_source_or_disasm_and_command): Update.
3578         * tui/tui-disasm.c (tui_set_disassem_content)
3579         (tui_get_begin_asm_address): Update.
3580         * tui/tui-data.h (struct tui_locator_element): Remove.
3581         (union tui_which_element) <locator>: Remove.
3582         (struct tui_locator_window): New.
3583         (tui_locator_win_info_ptr): Change return type.
3584         * tui/tui-data.c (_locator): Change type.
3585         (tui_locator_win_info_ptr): Change return type.
3586         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3587         (tui_alloc_content): Add assert.
3588
3589 2019-06-25  Tom Tromey  <tom@tromey.com>
3590
3591         * tui/tui-winsource.c
3592         (tui_exec_info_window::maybe_allocate_content): New method.
3593         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3594         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3595         (make_source_or_disasm_window): Add cast.
3596         * tui/tui-data.h (union tui_which_element) <simple_string>:
3597         Remove.
3598         (struct tui_source_info): New.
3599         (struct tui_source_window_base) <execution_info>: Change type.
3600         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3601         case, and add assert.
3602         (tui_alloc_content): Add assert.
3603
3604 2019-06-25  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3607         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3608         * tui/tui-data.c (tui_alloc_win_info): Remove.
3609
3610 2019-06-25  Tom Tromey  <tom@tromey.com>
3611
3612         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3613         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3614         can_highlight.
3615
3616 2019-06-25  Tom Tromey  <tom@tromey.com>
3617
3618         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3619         make_visible_with_new_height method.
3620         (tui_win_info::make_visible_with_new_height): New method.
3621         (tui_source_window_base::do_make_visible_with_new_height)
3622         (tui_data_window::do_make_visible_with_new_height)
3623         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3624         (make_visible_with_new_height): Remove.
3625         (tui_resize_all, tui_adjust_win_heights): Use
3626         make_visible_with_new_height method.
3627         * tui/tui-data.h (struct tui_win_info)
3628         <do_make_visible_with_new_height, make_visible_with_new_height>:
3629         New methods.
3630         (struct tui_source_window_base, struct tui_data_window)
3631         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3632         methods.
3633
3634 2019-06-25  Tom Tromey  <tom@tromey.com>
3635
3636         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3637         method.
3638         (update_tab_width): Call update_tab_width method.
3639         * tui/tui-data.h (struct tui_win_info)
3640         (struct tui_source_window_base) <update_tab_width>: New methods.
3641
3642 2019-06-25  Tom Tromey  <tom@tromey.com>
3643
3644         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3645         parameter.
3646         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3647         parameter.
3648         (tui_gen_win_info::make_visible): Update.
3649         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3650         parameter.
3651         * tui/tui-data.h (enum tui_box): New enum.
3652         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3653
3654 2019-06-25  Tom Tromey  <tom@tromey.com>
3655
3656         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3657         init_and_make_win for EXEC_INFO_WIN.
3658         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3659         longer inline.
3660         (struct tui_win_info) <~tui_win_info>: Inline.
3661         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3662         Don't declare.
3663         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3664         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3665         Remove.
3666         (tui_initialize_static_data): Update.
3667         (~tui_gen_win_info): Handle more cleanup here.
3668         (~tui_source_window_base): Delete "execution_info".
3669         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3670
3671 2019-06-25  Tom Tromey  <tom@tromey.com>
3672
3673         * tui/tui-layout.c (make_command_window): Don't set
3674         can_highlight.
3675         (show_source_disasm_command): Call the reset method.
3676         (show_data): Don't set can_highlight.  Call the reset method.
3677         (tui_gen_win_info::reset): Rename from init_gen_win_info
3678         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3679         (show_source_or_disasm_and_command): Call the reset method.
3680         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3681         (struct tui_cmd_window): Set can_highlight.
3682
3683 2019-06-25  Tom Tromey  <tom@tromey.com>
3684
3685         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3686         from make_visible.
3687         (tui_make_visible, tui_make_invisible): Rewrite.
3688         (tui_win_info::make_visible): Remove.
3689         (tui_source_window_base::make_visible): Update.
3690         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3691         method.  Moved from...
3692         (struct tui_win_info) <make_visible>: ...here.
3693
3694 2019-06-25  Tom Tromey  <tom@tromey.com>
3695
3696         * tui/tui-winsource.c
3697         (tui_source_window_base::do_scroll_horizontal): Remove direction
3698         parameter.
3699         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3700         direction parameter.
3701         * tui/tui-win.c (tui_win_info::forward_scroll)
3702         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3703         (tui_win_info::right_scroll): Update.
3704         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3705         direction parameter.
3706         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3707         direction parameter.
3708         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3709         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3710         Remove direction parameter.
3711         (struct tui_source_window_base, struct tui_source_window)
3712         (struct tui_disasm_window, struct tui_data_window)
3713         (struct tui_cmd_window): Update.
3714
3715 2019-06-25  Tom Tromey  <tom@tromey.com>
3716
3717         * tui/tui-winsource.h (tui_set_exec_info_content)
3718         (tui_show_exec_info_content, tui_erase_exec_info_content)
3719         (tui_clear_exec_info_content, tui_update_exec_info): Change
3720         argument to tui_source_window_base.
3721         * tui/tui-winsource.c (tui_set_exec_info_content)
3722         (tui_show_exec_info_content, tui_erase_exec_info_content)
3723         (tui_clear_exec_info_content, tui_update_exec_info): Change
3724         argument to tui_source_window_base.
3725
3726 2019-06-25  Tom Tromey  <tom@tromey.com>
3727
3728         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3729         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3730
3731 2019-06-25  Tom Tromey  <tom@tromey.com>
3732
3733         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3734         check.
3735
3736 2019-06-25  Tom Tromey  <tom@tromey.com>
3737
3738         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3739         type to void.
3740         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3741         type to void.
3742         * tui/tui-source.c (tui_set_source_content): Update.
3743         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3744
3745 2019-06-25  Tom Tromey  <tom@tromey.com>
3746
3747         * tui/tui-win.c (window_name_completer, tui_set_focus)
3748         (tui_all_windows_info): Use name method.
3749         * tui/tui-data.h (struct tui_gen_win_info)
3750         (struct tui_source_window, struct tui_disasm_window)
3751         (struct tui_data_window, struct tui_cmd_window) <name>: New
3752         method.
3753         (tui_win_name): Don't declare.
3754         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3755         (tui_win_name): Remove.
3756
3757 2019-06-25  Tom Tromey  <tom@tromey.com>
3758
3759         * tui/tui-winsource.h (tui_update_source_window)
3760         (tui_update_source_window_as_is): Change parameter type.
3761         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3762         to be a tui_source_window_base.
3763         (tui_update_source_window_as_is): Likewise.
3764         * tui/tui-win.c (make_visible_with_new_height): Update.
3765
3766 2019-06-25  Tom Tromey  <tom@tromey.com>
3767
3768         * tui/tui-winsource.c (tui_erase_source_content)
3769         (tui_show_source_content, tui_show_exec_info_content)
3770         (tui_erase_exec_info_content): Use refresh_window method.
3771         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3772         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3773         from tui_refresh_win.
3774         (tui_data_window::refresh_window): New method.
3775         (tui_win_info::refresh, tui_source_window_base::refresh)
3776         (tui_refresh_all): Use refresh_window method.
3777         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3778         method.
3779         * tui/tui-regs.c (tui_display_register): Call refresh_window
3780         method.
3781         * tui/tui-layout.c (show_source_disasm_command)
3782         (show_source_or_disasm_and_command): Call refresh_window method.
3783         * tui/tui-data.h (struct tui_gen_win_info)
3784         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3785         New method.
3786
3787 2019-06-25  Tom Tromey  <tom@tromey.com>
3788
3789         * tui/tui.c (tui_rl_other_window, tui_enable)
3790         (tui_is_window_visible, tui_get_command_dimension): Update.
3791         * tui/tui-winsource.c (tui_update_source_window_as_is)
3792         (tui_clear_source_content, tui_erase_source_content)
3793         (tui_show_source_line, tui_source_window_base::refill)
3794         (tui_source_window_base::do_scroll_horizontal)
3795         (tui_source_window_base::set_is_exec_point_at)
3796         (tui_update_breakpoint_info, tui_set_exec_info_content)
3797         (tui_alloc_source_buffer, tui_line_is_displayed)
3798         (tui_addr_is_displayed): Update.
3799         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3800         (tui_check_and_display_highlight_if_needed)
3801         (tui_win_info::make_visible, tui_win_info::refresh)
3802         (tui_refresh_all): Update.
3803         * tui/tui-windata.c (tui_first_data_item_displayed)
3804         (tui_delete_data_content_windows, tui_erase_data_content)
3805         (tui_display_all_data, tui_data_window::refresh_all)
3806         (tui_check_data_values): Update.
3807         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3808         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3809         (tui_win_info::backward_scroll, tui_refresh_all_win)
3810         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3811         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3812         (tui_source_window_base::set_new_height)
3813         (tui_data_window::set_new_height)
3814         (make_invisible_and_set_new_height)
3815         (make_visible_with_new_height, new_height_ok)
3816         (parse_scrolling_args): Update.
3817         * tui/tui-stack.c (tui_show_frame_info): Update.
3818         * tui/tui-source.c (tui_set_source_content)
3819         (tui_set_source_content_nil, tui_source_is_displayed)
3820         (tui_source_window::do_scroll_vertical): Update.
3821         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3822         (tui_display_registers_from, tui_display_reg_element_at_line)
3823         (tui_check_register_values, tui_reg_command): Update.
3824         * tui/tui-layout.c (tui_default_win_height)
3825         (show_source_disasm_command, show_data, init_and_make_win)
3826         (show_source_or_disasm_and_command): Update.
3827         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3828         (tui_redisplay_readline, tui_mld_flush)
3829         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3830         (tui_getc): Update.
3831         * tui/tui-disasm.c (tui_set_disassem_content)
3832         (tui_disasm_window::do_scroll_vertical): Update.
3833         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3834         Now virtual.
3835         (struct tui_win_info): Derive from tui_gen_win_info.
3836         <~tui_win_info>: Mark as override.
3837         <generic>: Remove member.
3838         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3839         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3840         (~tui_data_window, ~tui_win_info)
3841         (tui_free_all_source_wins_content): Update.
3842         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3843
3844 2019-06-25  Tom Tromey  <tom@tromey.com>
3845
3846         * tui/tui-layout.c (init_and_make_win): Use new.
3847         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3848         destructor, initializers.
3849         (tui_alloc_generic_win_info): Don't declare.
3850         * tui/tui-data.c (_locator): Add argument to constructor.
3851         (source_win, disasm_win): New globals.
3852         (exec_info): Remove.
3853         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3854         Update.
3855         (tui_alloc_generic_win_info): Remove.
3856         (init_content_element): Use new.
3857         (tui_win_info::tui_win_info): Update.
3858         (free_content_elements) <case DATA_WIN>: Use delete.
3859
3860 2019-06-25  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3863         * tui/tui-windata.c (tui_first_data_item_displayed)
3864         (tui_delete_data_content_windows): Update.
3865         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3866         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3867         (tui_display_registers_from, tui_check_register_values): Update.
3868         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3869         pointer.
3870         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3871         window.
3872         (tui_free_data_content): Update.
3873         (free_content_elements) <case DATA_WIN>: Free the window.
3874
3875 2019-06-25  Tom Tromey  <tom@tromey.com>
3876
3877         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3878         Update.
3879         * tui/tui-layout.c (make_command_window)
3880         (show_source_disasm_command, show_data, init_and_make_win)
3881         (show_source_or_disasm_and_command): Update.
3882         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3883         method.
3884         <can_highight, is_highlighted>: Now bool.
3885         (tui_set_win_highlight): Don't declare.
3886         * tui/tui-data.c (tui_set_win_highlight): Remove.
3887
3888 2019-06-25  Tom Tromey  <tom@tromey.com>
3889
3890         * tui/tui-wingeneral.c (make_visible): Remove check of window
3891         type.
3892
3893 2019-06-25  Tom Tromey  <tom@tromey.com>
3894
3895         * tui/tui-win.c (tui_win_info::max_height)
3896         (tui_cmd_window::max_height): New methods.
3897         (new_height_ok): Call max_height.
3898         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3899         <max_height>: New method.
3900
3901 2019-06-25  Tom Tromey  <tom@tromey.com>
3902
3903         * tui/tui-win.c (tui_source_window_base::set_new_height)
3904         (tui_data_window::set_new_height): New methods.
3905         (make_invisible_and_set_new_height): Call set_new_height method.
3906         * tui/tui-data.h (struct tui_win_info)
3907         (struct tui_source_window_base, struct tui_data_window)
3908         <set_new_height>: New method.
3909
3910 2019-06-25  Tom Tromey  <tom@tromey.com>
3911
3912         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3913         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3914         tui_refresh_data_win.
3915         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3916         method.
3917         (tui_refresh_all_win): Call the refresh_all method.
3918         (tui_set_focus): Likewise.
3919         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3920         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3921         Likewise.
3922
3923 2019-06-25  Tom Tromey  <tom@tromey.com>
3924
3925         * tui/tui-winsource.h (tui_refill_source_window)
3926         (tui_set_is_exec_point_at): Don't declare.
3927         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3928         (tui_source_window_base::refill): Rename from
3929         tui_refill_source_window.
3930         (tui_source_window_base::do_scroll_horizontal): Update.
3931         (tui_source_window_base::set_is_exec_point_at): Rename from
3932         tui_set_is_exec_point_at.
3933         (tui_update_all_breakpoint_info): Update.
3934         * tui/tui-stack.c (tui_show_frame_info): Update.
3935         * tui/tui-layout.c (show_data): Add cast.
3936         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3937         * tui/tui-data.h (struct tui_source_window_base) <refill,
3938         set_is_exec_point_at>: New methods.
3939         (tui_source_windows, tui_add_to_source_windows): Update types.
3940         (tui_add_to_source_windows): Remove redundant declaration.
3941         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3942         (tui_source_windows): Change return type.
3943         (tui_clear_source_windows_detail): Update.
3944         (tui_add_to_source_windows): Change type of parameter.
3945         (tui_free_all_source_wins_content): Update.
3946
3947 2019-06-25  Tom Tromey  <tom@tromey.com>
3948
3949         * tui/tui-wingeneral.c (tui_win_info::refresh)
3950         (tui_source_window_base::refresh): New methods.
3951         (tui_refresh_all): Call the refresh method.
3952         * tui/tui-data.h (struct tui_win_info)
3953         (struct tui_source_window_base) <refresh>: New method.
3954
3955 2019-06-25  Tom Tromey  <tom@tromey.com>
3956
3957         * tui/tui.h (tui_is_window_visible): Return bool.
3958         * tui/tui.c (tui_is_window_visible): Return bool.
3959         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3960         (tui_make_visible, tui_make_invisible)
3961         (tui_win_info::make_visible)
3962         (tui_source_window_base::make_visible, make_all_visible)
3963         (tui_make_all_visible, tui_make_all_invisible): Update.
3964         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3965         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3966         bool.
3967         (struct tui_win_info, struct tui_source_window_base)
3968         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3969         * tui/tui-data.c (tui_init_generic_part): Update.
3970
3971 2019-06-25  Tom Tromey  <tom@tromey.com>
3972
3973         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3974         (tui_source_window_base::make_visible): New methods.
3975         (make_all_visible): Make method call.
3976         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3977         (struct tui_source_window_base, struct tui_cmd_window): Override
3978         make_visible.
3979         (tui_win_is_source_type): Don't declare.
3980         * tui/tui-data.c (tui_win_is_source_type): Remove.
3981
3982 2019-06-25  Tom Tromey  <tom@tromey.com>
3983
3984         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3985         NULL check.
3986
3987 2019-06-25  Tom Tromey  <tom@tromey.com>
3988
3989         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3990         Inline constructor.  Add initializers for members.
3991         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3992         constructors; now inline in class.
3993
3994 2019-06-25  Tom Tromey  <tom@tromey.com>
3995
3996         * tui/tui-regs.c (tui_show_registers): Update.
3997         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3998         bool.
3999         * tui/tui-data.c (tui_data_window::clear_detail)
4000         (tui_data_window): Update.
4001
4002 2019-06-25  Tom Tromey  <tom@tromey.com>
4003
4004         * tui/tui-windata.c (tui_display_all_data)
4005         (tui_display_data_from_line, tui_display_data_from)
4006         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4007         Update.
4008         * tui/tui-regs.c (tui_last_regs_line_no)
4009         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4010         (tui_show_registers, tui_show_register_group)
4011         (tui_display_registers_from, tui_display_reg_element_at_line)
4012         (tui_display_registers_from_line, tui_check_register_values)
4013         (tui_reg_next, tui_reg_prev): Update.
4014         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4015         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4016         tui_data_window.
4017         (struct tui_win_info) <detail>: Remove.  Add new fields from
4018         tui_data_info.
4019         (TUI_DATA_WIN): Add cast.
4020         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4021         (~tui_data_window): Simplify.
4022
4023 2019-06-25  Tom Tromey  <tom@tromey.com>
4024
4025         * tui/tui-layout.c (show_source_disasm_command)
4026         (show_source_or_disasm_and_command): Update.
4027         * tui/tui-io.c (update_cmdwin_start_line)
4028         (tui_redisplay_readline): Update.
4029         * tui/tui-data.h (struct tui_command_info): Remove.
4030         (struct tui_win_info) <detail>: Remove command_info member.
4031         (struct tui_data_window) <start_line>: New member, from
4032         tui_command_info.
4033         (TUI_CMD_WIN): Add casts.
4034
4035 2019-06-25  Tom Tromey  <tom@tromey.com>
4036
4037         * tui/tui-winsource.c (tui_update_source_window)
4038         (tui_refill_source_window)
4039         (tui_source_window_base::do_scroll_horizontal)
4040         (tui_update_breakpoint_info, tui_set_exec_info_content)
4041         (tui_show_exec_info_content, tui_erase_exec_info_content)
4042         (tui_clear_exec_info_content): Update.
4043         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4044         Update.
4045         * tui/tui-win.c (make_invisible_and_set_new_height)
4046         (make_visible_with_new_height): Update.
4047         * tui/tui-source.c (tui_set_source_content)
4048         (tui_show_symtab_source): Update.
4049         * tui/tui-layout.c (extract_display_start_addr)
4050         (show_source_disasm_command, show_data)
4051         (make_source_or_disasm_window)
4052         (show_source_or_disasm_and_command): Update.
4053         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4054         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4055         "gdbarch".
4056         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4057         to tui_source_window_base.
4058         (struct tui_win_info) <detail>: Remove source_info member.
4059         (struct tui_source_window_base) <has_locator>: Inline.
4060         Move contents from tui_source_info; rename has_locator member to
4061         m_has_locator.
4062         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4063         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4064         header file.
4065         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4066         Simplify.
4067         (tui_free_all_source_wins_content): Cast to
4068         tui_source_window_base.
4069
4070 2019-06-25  Tom Tromey  <tom@tromey.com>
4071
4072         * tui/tui-win.c (make_invisible_and_set_new_height)
4073         (make_visible_with_new_height): Call has_locator method.
4074         * tui/tui-layout.c (show_source_disasm_command, show_data)
4075         (show_source_or_disasm_and_command): Update for bool change.
4076         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4077         (tui_win_info) <has_locator>: New method.
4078         (struct tui_source_window_base) <has_locator>: New method.
4079         (tui_win_has_locator): Don't declare.
4080         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4081         from tui_win_has_locator.
4082         (tui_source_window_base): Use false, not FALSE.
4083
4084 2019-06-25  Tom Tromey  <tom@tromey.com>
4085
4086         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4087         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4088         clear_detail method directly.
4089         (tui_clear_win_detail): Remove.
4090
4091 2019-06-25  Tom Tromey  <tom@tromey.com>
4092
4093         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4094         "this", not TUI_DISASM_WIN.
4095
4096 2019-06-25  Tom Tromey  <tom@tromey.com>
4097
4098         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4099         declare.
4100         * tui/tui-winsource.c
4101         (tui_source_window_base::do_scroll_horizontal): Rename from
4102         tui_horizontal_source_scroll.
4103         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4104         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4105         from tui_vertical_data_scroll.
4106         * tui/tui-win.h (tui_scroll): Don't declare.
4107         * tui/tui-win.c (tui_win_info::forward_scroll)
4108         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4109         (tui_win_info::right_scroll): Rename and update.
4110         (tui_scroll_forward_command, tui_scroll_backward_command)
4111         (tui_scroll_left_command, tui_scroll_right_command): Update.
4112         (tui_scroll): Remove.
4113         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4114         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4115         from tui_vertical_source_scroll.
4116         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4117         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4118         from tui_vertical_disassem_scroll.
4119         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4120         do_scroll_horizontal>: New methods.
4121         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4122         Likewise.
4123         (struct tui_source_window_base): Add do_scroll_horizontal.
4124         (struct tui_source_window, struct tui_disasm_window): Add
4125         do_scroll_vertical.
4126         (struct tui_data_window, struct tui_cmd_window): Add
4127         do_scroll_horizontal and do_scroll_vertical.
4128         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4129
4130 2019-06-25  Tom Tromey  <tom@tromey.com>
4131
4132         * tui/tui-data.h (struct tui_source_window_base): New struct.
4133         (struct tui_source_window): Derive from tui_source_window_base.
4134         (struct tui_disasm_window): New struct.
4135         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4136         from tui_source_window::clear_detail.
4137         (tui_source_window_base): Rename from tui_source_window.
4138         (~tui_source_window_base): Rename from ~tui_source_window.
4139         (tui_alloc_win_info): Create a tui_disasm_window.
4140
4141 2019-06-25  Tom Tromey  <tom@tromey.com>
4142
4143         * tui/tui-data.h (struct tui_source_window)
4144         (struct tui_data_window): Declare destructors.
4145         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4146         destructors.
4147         (tui_win_info): Simplify.
4148
4149 2019-06-25  Tom Tromey  <tom@tromey.com>
4150
4151         * tui/tui-winsource.c (tui_display_main)
4152         (tui_update_source_windows_with_addr)
4153         (tui_update_all_breakpoint_info): Update.
4154         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4155         (new_height_ok, parse_scrolling_args): Update.
4156         * tui/tui-stack.c (tui_show_frame_info): Update.
4157         * tui/tui-data.h (struct tui_list): Remove.
4158         (tui_source_windows): Return a reference to a std::vector.
4159         * tui/tui-data.c (source_windows): Now a std::vector.
4160         (tui_source_windows): Change return type.
4161         (tui_clear_source_windows): Rewrite.
4162         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4163         (tui_free_all_source_wins_content): Rewrite.
4164
4165 2019-06-25  Tom Tromey  <tom@tromey.com>
4166
4167         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4168         (struct tui_data_window, struct tui_cmd_window): Declare
4169         clear_detail method.
4170         * tui/tui-data.c (tui_source_window::clear_detail)
4171         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4172         methods.
4173         (tui_clear_win_detail): Simplify.
4174
4175 2019-06-25  Tom Tromey  <tom@tromey.com>
4176
4177         * tui/tui-layout.c (make_source_window, make_disasm_window)
4178         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4179         Return the new window.
4180         (show_source_disasm_command, show_data)
4181         (show_source_or_disasm_and_command): Update.
4182
4183 2019-06-25  Tom Tromey  <tom@tromey.com>
4184
4185         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4186         parameter.  Return the new window.
4187         (show_source_disasm_command): Update and remove NULL check.
4188         (show_source_or_disasm_and_command): Update.
4189
4190 2019-06-25  Tom Tromey  <tom@tromey.com>
4191
4192         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4193
4194 2019-06-25  Tom Tromey  <tom@tromey.com>
4195
4196         * tui/tui-data.h (struct tui_win_info): Make constructor
4197         protected.  Make destructor virtual.  Add initializers.
4198         (tui_source_window, tui_data_window, tui_cmd_window): New
4199         classes.
4200         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4201         constructor.  Add "type" parameter.
4202         (tui_source_window, tui_data_window, tui_cmd_window): New
4203         constructors.
4204         (tui_alloc_win_info): Instantiate the appropriate subclass.
4205
4206 2019-06-25  Tom Tromey  <tom@tromey.com>
4207
4208         * tui/tui-win.c (tui_resize_all): Use delete.
4209         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4210         destructor.
4211         (tui_free_window): Don't declare.
4212         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4213         Update.
4214
4215 2019-06-25  Tom Tromey  <tom@tromey.com>
4216
4217         * tui/tui-data.h (struct tui_win_info): Add constructor.
4218         * tui/tui-data.c (tui_alloc_win_info): Use new.
4219         (tui_free_window): Use delete.
4220
4221 2019-06-22  Tom Tromey  <tom@tromey.com>
4222
4223         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4224         declare.
4225         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4226
4227 2019-06-22  Tom Tromey  <tom@tromey.com>
4228
4229         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4230         declare.
4231         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4232
4233 2019-06-22  Tom de Vries  <tdevries@suse.de>
4234
4235         * dwarf2read.c (create_addrmap_from_aranges)
4236         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4237         instead of '%zu'.
4238
4239 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4240
4241         * dwarf2read.h (dwarf2_section_info_def): Remove.
4242         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4243         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4244         std::vector<dwarf2_section_info>.
4245         (struct dwo_file) <~dwo_file>: Remove.
4246         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4247         types field.
4248         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4249         (dwarf2_read_debug_names): Likewise.
4250         (create_debug_types_hash_table): Change parameter type to
4251         array_view, adjust code accordingly.
4252         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4253         (partial_die_info::fixup): Likewise.
4254         (determine_prefix): Likewise.
4255         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4256
4257 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4258
4259         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4260         gdb_bfd_ref_ptr.
4261         <~dwo_file>: Remove call to gdb_bfd_unref.
4262         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4263         gdb_bfd_ref_ptr::get.
4264
4265 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4266
4267         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4268         type to htab_up.
4269         * dwarf2read.c (struct dwo_file): Initialize fields.
4270         <~dwo_file>: New.
4271         (free_dwo_file): Remove, move content to ~dwo_file.
4272         (struct dwo_file_deleter): Remove.
4273         (dwo_file_up>: Remove custom deleter.
4274         (free_dwo_files): Remove.
4275         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4276         dwo_files.
4277         (process_skeletonless_type_units): Call unique_ptr::get.
4278         (allocate_dwo_file_hash_table): Add deleter to created hash
4279         table.  Change return type to htab_up.
4280         (lookup_dwo_file_slot): Don't memset dwo_file, call
4281         unique_ptr::get.
4282         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4283         (create_dwo_unit_in_dwp_v2): Likewise.
4284         (open_and_init_dwo_file): Likewise.
4285         (free_dwo_file_from_slot): Remove.
4286
4287 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4288
4289         * dwarf2read.h (struct dwarf2_section_info) <readin,
4290         is_virtual>: Change type to bool.
4291         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4292         true instead of 1.
4293
4294 2019-06-19  Tom Tromey  <tom@tromey.com>
4295
4296         * tui/tui-data.h (tui_init_content_element): Don't declare.
4297
4298 2019-06-19  Tom Tromey  <tom@tromey.com>
4299
4300         * tui/tui-data.h (tui_init_win_info): Don't declare.
4301
4302 2019-06-19  Tom de Vries  <tdevries@suse.de>
4303
4304         * dwarf2read.h (abstract_to_concrete): Change type to
4305         std::unordered_map<sect_offset, std::vector<sect_offset>,
4306         gdb::hash_enum<sect_offset>>.
4307
4308 2019-06-19  Tom Tromey  <tromey@adacore.com>
4309
4310         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4311         EVAL_AVOID_SIDE_EFFECTS specially.
4312
4313 2019-06-19  Tom Tromey  <tromey@adacore.com>
4314
4315         * source-cache.c (highlighter): New global.
4316         (source_cache::get_source_lines): Create a highlighter on demand.
4317
4318 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4319
4320         * defs.h (deprecated_interactive_hook): Delete declaration.
4321         * interps.c (clear_interpreter_hooks): Remove use of
4322         deprecated_interactive_hook.
4323         * top.c (deprecated_interactive_hook): Delete definition.
4324         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4325
4326 2019-06-18  Tom de Vries  <tdevries@suse.de>
4327
4328         PR gdb/24515
4329         * dwarf2read.h (abstract_to_concrete): Change type from
4330         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4331         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4332         * dwarf2read.c (read_variable): Update.
4333         (dwarf2_fetch_die_loc_sect_off): Update.
4334
4335 2019-06-17  Tom de Vries  <tdevries@suse.de>
4336
4337         PR gdb/24617
4338         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4339         accessing parent[parent_len - 1].
4340
4341 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4342
4343         PR gdb/24364
4344         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4345         call dtrace_process_dof with NULL dof.
4346
4347 2019-06-16  Tom de Vries  <tdevries@suse.de>
4348
4349         PR gdb/24445
4350         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4351
4352 2019-06-16  Tom Tromey  <tom@tromey.com>
4353
4354         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4355         (make_all_visible): Use address of member.
4356
4357 2019-06-16  Tom Tromey  <tom@tromey.com>
4358
4359         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4360         (tui_free_window, free_content, free_content_elements): Remove
4361         unnecessary cast.
4362         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4363         cast.
4364         * tui/tui-regs.c (tui_show_register_group)
4365         (tui_display_registers_from, tui_display_reg_element_at_line):
4366         Remove unnecessary cast.
4367
4368 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4369
4370         * linux-nat.c (normal_mask): Delete.
4371         (_initialize_linux_nat): Don't initialise normal_mask.
4372
4373 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4374
4375         PR gdb/24445
4376         * dwarf-index-write.h (write_psymtabs_to_index): Add
4377         dwz_basename parameter.
4378         * dwarf-index-write.c (write_gdbindex): Move file writing to
4379         write_gdbindex_1.  Change return type void.
4380         (assert_file_size): Move up, remove filename parameter.
4381         (write_gdbindex_1): New function.
4382         (write_debug_names): Change return type to void, call
4383         assert_file_size.
4384         (struct index_wip_file): New struct.
4385         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4386         file logic to index_wip_file.  Write index for dwz file if
4387         needed.
4388         (save_gdb_index_command): Pass basename of dwz file, if present.
4389         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4390         build-id of dwz file, if present.
4391         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4392         (dwarf2_get_dwz_file): Likewise.
4393         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4394         (dwarf2_get_dwz_file): Likewise.
4395
4396 2019-06-16  Tom Tromey  <tom@tromey.com>
4397
4398         * coffread.c (process_coff_symbol): Use xstrdup.
4399         * value.c (create_internalvar): Use xstrdup.
4400
4401 2019-06-16  Tom Tromey  <tom@tromey.com>
4402
4403         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4404         * breakpoint.c (stopin_command, stopat_command)
4405         (until_break_command, decode_location_default): Remove unnecessary
4406         cast.
4407         * utils.c (subset_compare): Remove unnecessary cast.
4408         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4409         cast.
4410         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4411         cast.
4412         * infcmd.c (path_command): Remove unnecessary cast.
4413         * coffread.c (decode_type): Remove unnecessary cast.
4414         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4415         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4416         * tui/tui-stack.c (tui_show_locator_content)
4417         (tui_show_frame_info): Remove unnecessary cast.
4418         * tui/tui-win.c (tui_scroll_forward_command)
4419         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4420         (parse_scrolling_args): Remove unnecessary cast.
4421         * tui/tui-data.c (init_win_info, tui_del_window)
4422         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4423         (free_content_elements): Remove unnecessary cast.
4424         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4425         unnecessary cast.
4426         * tui/tui-source.c (tui_set_source_content)
4427         (tui_vertical_source_scroll): Remove unnecessary cast.
4428         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4429         cast.
4430         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4431         * tui/tui-regs.c (tui_display_registers_from)
4432         (tui_display_register): Remove unnecessary cast.
4433         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4434         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4435         (make_visible): Remove unnecessary cast.
4436         * tui/tui-winsource.c (tui_erase_source_content)
4437         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4438         unnecessary cast.
4439         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4440         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4441         * stabsread.c (read_type, read_array_type, read_range_type):
4442         Remove unnecessary cast.
4443         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4444         (parse_symbol, parse_type, upgrade_type, parse_external)
4445         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4446         unnecessary cast.
4447         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4448
4449 2019-06-16  Tom Tromey  <tom@tromey.com>
4450
4451         * tui/tui-data.c (tui_alloc_generic_win_info)
4452         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4453         checks.
4454
4455 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4456             Andrew Burgess  <andrew.burgess@embecosm.com>
4457
4458         * f-typeprint.c (f_print_type): Don't return early for not
4459         associated or not allocated types.
4460         (f_type_print_varspec_suffix): Add print_rank parameter and print
4461         ranks of array types in case they dangling.
4462         (f_type_print_base): Add print_rank parameter.
4463
4464 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4465
4466         * NEWS: Mention new MI commands.
4467         * break-catch-throw.c (enum exception_event_kind): Move to
4468         breakpoint.h.
4469         (print_mention_exception_catchpoint): Output text as a single
4470         message.
4471         (catch_exception_command_1): Rename to...
4472         (catch_exception_event): ...this, make non-static, update header
4473         command, and change some parameter types.
4474         (catch_catch_command): Update for changes to
4475         catch_exception_command_1.
4476         (catch_throw_command): Likewise.
4477         (catch_rethrow_command): Likewise.
4478         * breakpoint.c (enum exception_event_kind): Delete.
4479         * breakpoint.h (enum exception_event_kind): Moved here from
4480         break-catch-throw.c.
4481         (catch_exception_event): Declare.
4482         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4483         (mi_cmd_catch_throw): New function.
4484         (mi_cmd_catch_rethrow): New function.
4485         (mi_cmd_catch_catch): New function.
4486         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4487         'catch-catch' entries.
4488         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4489         (mi_cmd_catch_rethrow): Declare.
4490         (mi_cmd_catch_catch): Declare.
4491
4492 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4493
4494         * annotate.c (annotate_source_line): Change return type to void,
4495         update implementation to match.
4496         * annotate.h (annotate_source_line): Change return type to void,
4497         update header comment.
4498         * stack.c (print_frame_info): Don't change what frame information
4499         is printed based on whether annotations are on or not.
4500
4501 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4502
4503         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4504         (annotate_source): Make static.
4505         (annotate_source_line): Moved from source.c and renamed from
4506         identify_source_line.  Update the return type.
4507         * annotate.h (annotate_source): Delete declaration.
4508         (annotate_source_line): Declaration moved from source.h, and
4509         renamed from identify_source_line.  Return type updated.
4510         * source.c (identify_source_line): Moved to annotate.c and renamed
4511         to annotate_source_line.
4512         (info_line_command): Remove check of annotation_level.
4513         * source.h (identify_source_line): Move declaration to annotate.h
4514         and rename to annotate_source_line.
4515         * stack.c: Add 'annotate.h' include.
4516         (print_frame_info): Remove check of annotation_level before
4517         calling annotate_source_line.
4518
4519 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4520
4521         * source-cache.c (source_cache::get_plain_source_lines): Use
4522         open_source_file_with_line_charpos instead of just
4523         open_source_file, remove call to find_source_lines.
4524         (source_cache::get_source_lines): Likewise.
4525         * source.c (find_source_lines): Make static.
4526         (get_filename_and_charpos): Renamed into...
4527         (open_source_file_with_line_charpos): ..this along with changes to
4528         return a scoped_fd, and some other minor clean ups.
4529         (identify_source_line): Use open_source_file_with_line_charpos.
4530         (search_command_helper): Use open_source_file_with_line_charpos
4531         instead of just open_source_file, remove call to
4532         find_source_lines.
4533         * source.h (open_source_file_with_line_charpos): Declare new
4534         function.
4535         (find_source_lines): Delete declaration.
4536
4537 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4538
4539         * source.c (get_filename_and_charpos): Remove fullname
4540         parameter.
4541         (identify_source_line): Update call to get_filename_and_charpos.
4542
4543 2019-06-14  Tom Tromey  <tromey@adacore.com>
4544
4545         PR gdb/24502:
4546         * ui-style.h (skip_ansi_escape): Update comment.
4547         * ui-file.h (class no_terminal_escape_file): New class.
4548         * ui-file.c (no_terminal_escape_file::write)
4549         (no_terminal_escape_file::puts): New methods.
4550         * cli/cli-logging.c (handle_redirections): Use
4551         no_terminal_escape_file.
4552
4553 2019-06-14  Tom Tromey  <tromey@adacore.com>
4554
4555         * NEWS: Move convenience variable news above Python news.
4556
4557 2019-06-14  Tom Tromey  <tom@tromey.com>
4558
4559         * gnulib: Move directory to top-level.
4560         * configure.ac: Don't configure gnulib.
4561         * configure: Rebuild.
4562         * common/common-defs.h: Use new path to gnulib.
4563         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4564         (GNULIB_H): Remove.
4565         (INCGNU): Look in new gnulib location.
4566         (HFILES_NO_SRCDIR): Remove gnulib files.
4567         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4568         (generated_files): Remove GNULIB_H.
4569         ($(LIBGNU), all-lib): Remove targets.
4570         (distclean): Don't mention GNULIB_BUILDDIR.
4571         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4572
4573 2019-06-14  Tom Tromey  <tromey@adacore.com>
4574
4575         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4576         Warn if symbol file does not provide any symbols.
4577
4578 2019-06-14  Tom Tromey  <tromey@adacore.com>
4579
4580         * source.c (find_and_open_source): Respect basenames_may_differ.
4581
4582 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4583
4584         * annotate.c (annotate_breakpoints_invalid): Make use of
4585         scoped_restore_terminal_state.
4586         (annotate_frames_invalid): Likewise.
4587
4588 2019-06-14  Tom Tromey  <tromey@adacore.com>
4589
4590         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4591         allow assignment to an internalvar.
4592
4593 2019-06-14  Tom Tromey  <tromey@adacore.com>
4594
4595         * ada-lex.l: Allow "_" in attribute names.
4596
4597 2019-06-14  Tom Tromey  <tromey@adacore.com>
4598
4599         PR gdb/24653:
4600         * regcache.c (registers_changed): Don't call alloca.
4601         * top.c (execute_command): Don't call alloca.
4602
4603 2019-06-13  Pedro Alves  <palves@redhat.com>
4604
4605         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4606         'expression'.  When parsing an expression, error out if there's
4607         junk after "unlimited".
4608         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4609         (do_set_command): Adjust calls to is_unlimited_literal.
4610
4611 2019-06-13  Pedro Alves  <palves@redhat.com>
4612
4613         * compile/compile.c (make_compile_options_def_group): Add braces
4614         around array_view initializer.
4615         * thread.c (make_thread_apply_all_options_def_group)
4616         (make_thread_apply_all_options_def_group): Likewise.
4617
4618 2019-06-13  Pedro Alves  <palves@redhat.com>
4619
4620         * NEWS (New commands): Mention "maint test-options
4621         require-delimiter", "maint test-options unknown-is-error", "maint
4622         test-options unknown-is-operand" and "maint show
4623         test-options-completion-result".
4624         (New command options, command completion): New section.
4625         (Completion improvements): New section.
4626         Mention that you can abbreviate "unlimited".
4627
4628 2019-06-13  Pedro Alves  <palves@redhat.com>
4629
4630         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4631         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4632         * unittests/cli-utils-selftests.c (test_parse_flags)
4633         (test_parse_flags_qcs): Delete.
4634         (test_cli_utils): Don't call deleted functions.
4635
4636 2019-06-13  Pedro Alves  <palves@redhat.com>
4637
4638         * thread.c: Include "cli/cli-option.h".
4639         (tp_array_compar_ascending): Global.
4640         (tp_array_compar): Delete function.
4641         (tp_array_compar_ascending, tp_array_compar_descending): New
4642         functions.
4643         (ascending_option_def, qcs_flag_option_def)
4644         (thr_qcs_flags_option_defs)
4645         (make_thread_apply_all_options_def_group)
4646         (make_thread_apply_options_def_group): New.
4647         (thread_apply_all_command): Use gdb::option::process_options.
4648         (thread_apply_command_completer)
4649         (thread_apply_all_command_completer): New.
4650         (thread_apply_command): Use gdb::option::process_options.
4651         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4652         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4653         to generate help text of "thread apply".  Adjust "taas"'s help.
4654         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4655         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4656
4657 2019-06-13  Pedro Alves  <palves@redhat.com>
4658
4659         * thread.c (thread_apply_command): Check for invalid TID with
4660         isdigit instead of !isalpha.
4661
4662 2019-06-13  Pedro Alves  <palves@redhat.com>
4663
4664         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4665         (validate_flags_qcs): New.
4666         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4667         (validate_flags_qcs): Declare.
4668         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4669         (make_frame_apply_options_def_group): New.
4670         (frame_apply_command_count): Process options with
4671         gdb::option::process_options.
4672         (frame_apply_completer): New.
4673         (frame_apply_level_completer, frame_apply_all_completer)
4674         (frame_apply_completer): New.
4675         (_initialize_stack): Update help of "frame apply", "frame apply
4676         level", "frame apply all" and "faas" to mention supported options
4677         and install command completers.
4678         * stack.h (frame_apply_all_completer): Declare.
4679         * thread.c: Include "stack.h".
4680         (tfaas_command): Add "--".
4681         (_initialize_thread): Update help "tfaas" to mention supported
4682         options and install command completer.
4683
4684 2019-06-13  Pedro Alves  <palves@redhat.com>
4685
4686         * completer.c (complete_nested_command_line): New.
4687         (gdb_completion_word_break_characters_throw): Add assertion.
4688         * completer.h (complete_nested_command_line): Declare.
4689
4690 2019-06-13  Pedro Alves  <palves@redhat.com>
4691
4692         * stack.c (parse_backtrace_qualifiers): New.
4693         (backtrace_command): Use it.
4694         (backtrace_command_completer): Complete on qualifiers.
4695
4696 2019-06-13  Pedro Alves  <palves@redhat.com>
4697
4698         * frame.c: Include "cli/cli-option.h.
4699         (user_set_backtrace_options): New.
4700         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4701         Delete.
4702         (get_prev_frame): Adjust.
4703         (boolean_option_def, uinteger_option_def)
4704         (set_backtrace_option_defs): New.
4705         (_initialize_frame): Adjust and use
4706         gdb::option::add_setshow_cmds_for_options to install "set
4707         backtrace past-main" and "set backtrace past-entry".
4708         * frame.h: Include "cli/cli-option.h".
4709         (struct frame_print_options): Forward declare.
4710         (print_frame_arguments_all, print_frame_arguments_scalars)
4711         (print_frame_arguments_none): Declare.
4712         (print_entry_values): Delete declaration.
4713         (struct frame_print_options, user_frame_print_options): New.
4714         (struct set_backtrace_options): New.
4715         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4716         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4717         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4718         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4719         (list_args_or_locals): Add frame_print_options parameter.
4720         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4721         * python/py-framefilter.c (enumerate_args): Pass down
4722         USER_FRAME_PRINT_OPTIONS.
4723         * stack.c: Include "cli/cli-option.h".
4724         (print_frame_arguments_all, print_frame_arguments_scalars)
4725         (print_frame_arguments_none): Declare.
4726         (print_raw_frame_arguments, print_entry_values): Delete.
4727         (user_frame_print_options): New.
4728         (boolean_option_def, enum_option_def, frame_print_option_defs):
4729         New.
4730         (struct backtrace_cmd_options): New.
4731         (bt_flag_option_def): New.
4732         (backtrace_command_option_defs): New.
4733         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4734         (print_frame_arg, read_frame_arg, print_frame_args)
4735         (print_frame_info, print_frame): Add frame_print_options parameter
4736         and use it.
4737         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4738         (backtrace_command_1): Add frame_print_options and
4739         backtrace_cmd_options parameters and use them.
4740         (make_backtrace_options_def_group): New.
4741         (backtrace_command): Process command options with
4742         gdb::option::process_options.
4743         (backtrace_command_completer): New.
4744         (_initialize_stack): Extend "backtrace"'s help to mention
4745         supported options.  Install completer for "backtrace".
4746         Install some settings commands with add_setshow_cmds_for_options.
4747
4748 2019-06-13  Pedro Alves  <palves@redhat.com>
4749
4750         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4751         and that "set/show print raw frame-arguments" are now deprecated.
4752
4753         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4754         command.
4755         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4756         * stack.c (_initialize_stack): Install "set/show print
4757         raw-frame-arguments", and deprecate "set/show print raw
4758         frame-arguments".
4759         * valprint.c (_initialize_valprint): Deprecate "set/show print
4760         raw".
4761
4762 2019-06-13  Pedro Alves  <palves@redhat.com>
4763
4764         * compile/compile.c (struct compile_options): New.
4765         (compile_flag_option_def, compile_command_option_defs)
4766         (make_compile_options_def_group): New.
4767         (compile_file_command): Handle options with
4768         gdb::option::process_options.
4769         (compile_file_command_completer): New function.
4770         (compile_code_command): Handle options with
4771         gdb::option::process_options.
4772         (compile_code_command_completer): New function.
4773         (_initialize_compiler): Install completers for "compile code" and
4774         "compile file".  Mention available options in "compile code" and
4775         "compile code"'s help.
4776         * completer.c (advance_to_completion_word): New, factored out from
4777         ...
4778         (advance_to_expression_complete_word_point): ... this.
4779         (advance_to_filename_complete_word_point): New.
4780         * completer.h (advance_to_filename_complete_word_point): New
4781         declaration.
4782
4783 2019-06-13  Pedro Alves  <palves@redhat.com>
4784
4785         * compile/compile.c: Include "cli/cli-option.h".
4786         (compile_print_value): Scope data pointer is now a
4787         value_print_options pointer; adjust.
4788         (compile_print_command): Process options.  Scope data pointer is
4789         now a value_print_options pointer; adjust.
4790         (_initialize_compile): Update "compile print"'s help to include
4791         supported options.  Install a completer for "compile print".
4792         * cp-valprint.c (show_vtblprint, show_objectprint)
4793         (show_static_field_print): Delete.
4794         (_initialize_cp_valprint): Don't install "set print
4795         static-members", "set print vtbl", "set print object" here.
4796         * printcmd.c: Include "cli/cli-option.h" and
4797         "common/gdb_optional.h".
4798         (print_command_parse_format): Rework to fill in a
4799         value_print_options instead of a format_data.
4800         (print_value): Change parameter type from format_data pointer to
4801         value_print_options reference.  Adjust.
4802         (print_command_1): Process options.  Adjust to pass down a
4803         value_print_options.
4804         (print_command_completer): New.
4805         (_initialize_printcmd): Install print_command_completer as
4806         handle_brkchars completer for the "print" command.  Update
4807         "print"'s help to include supported options.
4808         * valprint.c: Include "cli/cli-option.h".
4809         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4810         here from cp-valprint.c.
4811         (boolean_option_def, uinteger_option_def)
4812         (value_print_option_defs, make_value_print_options_def_group):
4813         New.  Use gdb::option::add_setshow_cmds_for_options to install
4814         "set print elements", "set print null-stop", "set print repeats",
4815         "set print pretty", "set print union", "set print array", "set
4816         print address", "set print symbol", "set print array-indexes".
4817         * valprint.h: Include <string> and "cli/cli-option.h".
4818         (make_value_print_options_def_group): Declare.
4819         (print_value): Change parameter type from format_data pointer to
4820         value_print_options reference.
4821         (print_command_completer): Declare.
4822
4823 2019-06-13  Pedro Alves  <palves@redhat.com>
4824
4825         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4826         (COMMON_SFILES): Add maint-test-settings.c.
4827         * cli/cli-decode.c (boolean_enums): New global, factored out from
4828         ...
4829         (add_setshow_boolean_cmd): ... here.
4830         * cli/cli-decode.h (boolean_enums): Declare.
4831         * cli/cli-option.c: New file.
4832         * cli/cli-option.h: New file.
4833         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4834         factored out from ...
4835         (parse_cli_boolean_value(const char *)): ... this.
4836         (is_unlimited_literal): Change parameter type to pointer to
4837         pointer.  Adjust and advance ARG pointer.
4838         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4839         (parse_cli_var_enum): New, factored out from ...
4840         (do_set_command): ... this.  Adjust.
4841         * cli/cli-setshow.h (parse_cli_boolean_value)
4842         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4843         (parse_cli_var_enum): Declare.
4844         * cli/cli-utils.c: Include "cli/cli-option.h".
4845         (get_ulongest): New.
4846         * cli/cli-utils.h (get_ulongest): Declare.
4847         (check_for_argument): New overloads.
4848         * maint-test-options.c: New file.
4849
4850 2019-06-13  Pedro Alves  <palves@redhat.com>
4851
4852         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4853         parse a range if "-" is at the end of the string.
4854
4855 2019-06-13  Pedro Alves  <palves@redhat.com>
4856
4857         * cli/cli-setshow.c (parse_auto_binary_operation)
4858         (parse_cli_boolean_value): Don't allow "o".
4859
4860 2019-06-13  Pedro Alves  <palves@redhat.com>
4861
4862         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4863         * NEWS: Mention maint test-settings KIND.
4864         * maint-test-settings.c: New file.
4865
4866 2019-06-13  Pedro Alves  <palves@redhat.com>
4867
4868         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4869         completer.
4870         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4871         "set" completers.
4872
4873 2019-06-13  Pedro Alves  <palves@redhat.com>
4874
4875         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4876         after item.
4877
4878 2019-06-13  Pedro Alves  <palves@redhat.com>
4879
4880         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4881
4882 2019-06-13  Pedro Alves <palves@redhat.com>
4883
4884         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4885         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4886         call.
4887         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4888         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4889         calls.
4890         (check_for_argument): Skip spaces after argument.
4891
4892 2019-06-13  Pedro Alves  <palves@redhat.com>
4893
4894         * thread.c (thread_apply_command): Adjust TID parsing.
4895         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4896         detected before end of string.
4897         (tid_is_in_list): Error out if LIST is invalid.
4898
4899 2019-06-13  Pedro Alves  <palves@redhat.com>
4900
4901         * completer.c (complete_line_internal_1): Rewind completion word
4902         point.
4903         (completion_tracker::advance_custom_word_point_by): Change
4904         parameter type to int.
4905         * completer.h (completion_tracker::advance_custom_word_point_by):
4906         Likewise.
4907
4908 2019-06-13  Pedro Alves  <palves@redhat.com>
4909
4910         * completer.c (advance_to_completion_word): Handle delimiters.
4911
4912 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4913
4914         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4915
4916 2019-06-11  Tom Tromey  <tom@tromey.com>
4917
4918         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4919         (xmalloc_failed): Move to alloc.c.
4920         * alloc.c: New file.
4921         * Makefile.in (COMMON_SFILES): Add alloc.c.
4922
4923 2019-06-11  Tom Tromey  <tom@tromey.com>
4924
4925         * nat/linux-waitpid.c: Don't include server.h.
4926         (linux_debug): Remove.
4927         (my_waitpid): Update.
4928
4929 2019-06-11  Tom Tromey  <tromey@adacore.com>
4930
4931         * infcall.c (_initialize_infcall): Remove trailing newline from
4932         help.
4933         * user-regs.c (_initialize_user_regs): Remove trailing newline
4934         from help.
4935         * typeprint.c (_initialize_typeprint): Remove trailing newline
4936         from help.
4937         * reverse.c (_initialize_reverse): Remove trailing newlines from
4938         help.
4939         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4940         from help.
4941         * language.c (add_set_language_command): Remove trailing newline
4942         from help.
4943         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4944         help.
4945         * disasm.c (_initialize_disasm): Remove trailing newline from
4946         help.
4947         * top.c (init_main): Remove trailing newline from help.
4948         * interps.c (_initialize_interpreter): Remove trailing newline
4949         from help.
4950         * btrace.c (_initialize_btrace): Remove trailing newlines from
4951         help.
4952         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4953         from help.
4954         * python/python.c (_initialize_python): Remove trailing newline
4955         from help.
4956         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4957         help.
4958         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4959         from help.  Reformat some text.
4960         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4961         from help.
4962         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4963         newline from help.
4964
4965 2019-06-11  Tom Tromey  <tromey@adacore.com>
4966
4967         * darwin-nat.c (darwin_decode_exception_message)
4968         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4969
4970 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4971
4972         * valops.c (value_slice): Check for not allocated or not
4973         associated values.
4974
4975 2019-06-10  Tom de Vries  <tdevries@suse.de>
4976
4977         PR gdb/24618
4978         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4979         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4980         invalid.
4981
4982 2019-06-10  Tom de Vries  <tdevries@suse.de>
4983
4984         PR gdb/24611
4985         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4986         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4987
4988 2019-06-10  Tom de Vries  <tdevries@suse.de>
4989
4990         PR symtab/24545
4991         * symtab.c (struct demangled_name_entry): Add language field.
4992         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4993         static minimal symbol".  Set and use language field.
4994
4995 2019-06-10  Tom Tromey  <tromey@adacore.com>
4996
4997         * ada-lang.c (_initialize_ada_language): Update help text.
4998
4999 2019-06-10  Tom Tromey  <tromey@adacore.com>
5000
5001         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5002         with a newline.
5003         * guile/guile.c (handle_boot_error): Don't end warning with a
5004         newline.
5005         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5006         warning with a newline.
5007         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5008         newline.
5009         (s12z_frame_cache): Likewise.
5010         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5011         a newline.
5012         * solib-svr4.c (disable_probes_interface): Don't end warning with
5013         a newline.
5014         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5015         newline.
5016         * python/python.c (do_finish_initialization): Don't end warning
5017         with a newline.
5018
5019 2019-06-10  Tom Tromey  <tom@tromey.com>
5020
5021         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5022         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5023         gdbpy_enter.
5024
5025 2019-06-10  Tom Tromey  <tromey@adacore.com>
5026
5027         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5028         data.
5029         (elf_new_init): Don't call stabsread_new_init.
5030         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5031         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5032         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5033
5034 2019-06-10  Tom de Vries  <tdevries@suse.de>
5035
5036         PR symtab/16264
5037         PR symtab/24517
5038         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5039
5040 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5041
5042         * source.c (find_and_open_source): Also rewrite relative file
5043         names.
5044
5045 2019-04-26  Amos Bird  <amosbird@gmail.com>
5046
5047         * annotate.c (annotate_thread_exited): Add "thread-exited"
5048         annotation.
5049
5050 2019-06-06  Tom Tromey  <tromey@adacore.com>
5051
5052         * maint.h (class scoped_command_stats): Use
5053         DISABLE_COPY_AND_ASSIGN.
5054         <print_time>: New method.
5055         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5056         print_time.
5057         (scoped_command_stats::print_time): New method.
5058
5059 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5060
5061         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5062         instructions of lengths 6 or 8 bytes.
5063
5064 2019-06-04  Pedro Alves  <palves@redhat.com>
5065
5066         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5067
5068         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5069         * breakpoint.c (condition_completer): Likewise.
5070         * cli/cli-dump.c (scan_expression): Likewise.
5071         * common/filestuff.c (mkdir_recursive): Likewise.
5072         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5073         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5074         (gdb_abspath): Likewise.
5075         * compile/compile-cplus-types.c
5076         (compile_cplus_instance::decl_name): Likewise.
5077         * completer.c (complete_explicit_location):
5078         (signal_completer, reg_or_group_completer_1): Likewise.
5079         * cp-support.c (cp_remove_params_if_any): Likewise.
5080         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5081         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5082         * infcmd.c (strip_bg_char): Likewise.
5083         * linespec.c (copy_token_string): Likewise.
5084         * mi/mi-main.c (output_cores): Likewise.
5085         * psymtab.c (psymtab_search_name):
5086         * symfile.c (test_set_ext_lang_command): Likewise.
5087         * target.c (target_fileio_read_stralloc): Likewise.
5088         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5089         * value.c (complete_internalvar): Likewise.
5090
5091 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5092
5093         Add objfile property to gdb.Type.
5094         * NEWS: Mention Python API addition.
5095         * python/py-type.c (typy_get_objfile): New method.
5096
5097 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5098
5099         * NEWS: Mention the new set|show style [title|highlight].
5100         Mention changes to "show style", "help" and "apropos".
5101
5102 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5103
5104         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5105         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5106         instead of print_help_for_command.
5107         (print_doc_of_command): New function.
5108         (help_list): Add 'apropos -v word' suggestion.
5109         (print_help_for_command): Style the command name using title style.
5110         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5111         (_initialize_cli_cmds): Describe -v in apropos_command help.
5112
5113 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5114
5115         * cli/cli-style.h (cli_style_option): Add name in constructor,
5116         add m_name class member, add constructor with intensity,
5117         add name class function.
5118         (cli_style_option::add_setshow_commands): Remove name argument.
5119         (highlight_style, title_style): New styles.
5120         * cli/cli-style.c (do_show): New function that shows a style
5121         characteristic styling the style name with itself.
5122         (set_style_name): New function.
5123         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5124         Update all callers according to the changes in cli/cli-style.h.
5125         * utils.h (fputs_highlighted): New function.
5126         * utils.c (fputs_highlighted): Likewise.
5127
5128 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5129
5130         * NEWS: Mention new pipe command and new convenience variables.
5131
5132 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5133
5134         * cli/cli-cmds.c (pipe_command): New function.
5135         (_initialize_cli_cmds): Call add_com for pipe_command.
5136         Define | as an alias for pipe.
5137         (exit_status_set_internal_vars): New function.
5138         (shell_escape): Call exit_status_set_internal_vars.
5139         cli/cli-decode.c (find_command_name_length): Recognize | as
5140         a single character command.
5141
5142 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5143
5144         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5145         top.c (execute_command_to_ui_file): New function, mostly a copy
5146         of execute_command_to_string.
5147         (execute_command_to_string): Implement by calling
5148         execute_command_to_ui_file.
5149
5150 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5151
5152         * top.h (saved_command_line): Remove declaration.
5153         * top.c (previous_saved_command_line, previous_repeat_arguments):
5154         New variables.
5155         (saved_command_line): Make static, define together with other
5156         'repeat variables'.
5157         (dont_repeat): Clear repeat_arguments.
5158         (repeat_previous, get_saved_command_line, save_command_line):
5159         New functions.
5160         (gdb_init): Initialize saved_command_line
5161         and previous_saved_command_line.
5162         * main.c (captured_main_1): Remove saved_command_line initialization.
5163         * event-top.c (handle_line_of_input): Update to use
5164         the new 'repeat' related functions instead of direct access to
5165         saved_command_line.
5166         * command.h (repeat_previous, get_saved_command_line,
5167         save_command_line): New declarations.
5168         (dont_repeat): Add comment.
5169
5170 2019-05-30  Tom Tromey  <tromey@adacore.com>
5171
5172         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5173         Fix comment.
5174         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5175
5176 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5177
5178         PR cli/24587
5179         * completer.c (complete): Initialize variable word.
5180
5181 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5182
5183         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5184         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5185         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5186         'body' is NULL to the outter 'if', protecting the '!is_define'
5187         situation as well.
5188
5189 2019-05-29  Tom Tromey  <tromey@adacore.com>
5190
5191         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5192         (dwarf_unknown): New function.
5193         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5194         (dwarf_type_encoding_name): Use dwarf_unknown.
5195
5196 2019-05-29  Tom Tromey  <tromey@adacore.com>
5197
5198         PR c++/20020:
5199         * cp-valprint.c (cp_print_value_fields): Call
5200         cp_print_static_field inside "try".
5201
5202 2019-05-29  Tom Tromey  <tromey@adacore.com>
5203
5204         * inflow.c (struct terminal_info): Add default operator=.
5205         * configure: Rebuild.
5206         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5207         -Wdeprecated-copy-dtor, -Wredundant-move.
5208
5209 2019-05-29  Tom Tromey  <tromey@adacore.com>
5210
5211         * NEWS: Add entry.
5212         * infcmd.c (print_return_value_1): Handle finish_print
5213         option.
5214         (show_print_finish): New function.
5215         (_initialize_infcmd): Add "set/show print finish" commands.
5216         * valprint.c (user_print_options): Initialize new member.
5217         * valprint.h (struct value_print_options) <finish_print>: New
5218         member.
5219
5220 2019-05-28  Tom Tromey  <tromey@adacore.com>
5221
5222         * ada-lang.c (ada_remove_Xbn_suffix)
5223         (find_old_style_renaming_symbol)
5224         (parse_old_style_renaming): Remove.
5225         (ada_find_renaming_symbol): Don't call
5226         find_old_style_renaming_symbol.
5227         (ada_is_renaming_symbol): Rename from
5228         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5229         bool.  Now static.
5230         (ada_read_var_value): Update and simplify.
5231         * ada-exp.y (write_var_or_type): Remove old code.
5232
5233 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5234
5235         * event-top.c: Remove include comment.
5236         * inflow.c (class scoped_ignore_sigttou): Move from here...
5237         * inflow.h (class scoped_ignore_sigttou): ...to here.
5238         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5239         * top.c:  Remove include comment.
5240
5241 2019-05-27  Tom Tromey  <tom@tromey.com>
5242
5243         * NEWS: Fix typo.
5244
5245 2019-05-22  Tom Tromey  <tromey@adacore.com>
5246
5247         * target.c (target_follow_exec): Constify parameter.
5248         * target-delegates.c: Rebuild.
5249         * remote.c (remote_target::follow_exec): Constify parameter.
5250         * infrun.c (follow_exec): Constify parameter.
5251         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5252         (target_follow_exec): Likewise.
5253
5254 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5255
5256         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5257         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5258
5259 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5260
5261         * NEWS: Add debugredirect and testsuite sections.
5262
5263 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5264
5265         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5266         target descriptions using exclusively floating point register name
5267         aliases.
5268
5269 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5270
5271         PR gdb/18644:
5272         * f-lang.c (build_fortran_types): Handle the case where
5273         gdbarch_floatformat_for_type returns a nullptr.
5274
5275 2019-05-21  Tom de Vries  <tdevries@suse.de>
5276
5277         PR cli/24587
5278         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5279
5280 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5281
5282         PR gdb/18644:
5283         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5284         16-byte floats.
5285         * i386-tdep.c (i386_floatformat_for_type): Use
5286         floatformats_ia64_quad for the 16-byte floating point component
5287         within a fortran 32-byte complex number.
5288
5289 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5290
5291         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5292         delete default constructor.
5293         (find_partial_die): Update to return const struct.
5294         (partial_die_parent_scope): Move variable declaration into scope
5295         of its use and change its type to auto.
5296         (guess_partial_die_structure_name): Likewise.
5297         (partial_die_info::fixup): Likewise.
5298
5299 2019-05-17  Tom Tromey  <tromey@adacore.com>
5300
5301         * source.c (find_and_open_source): Remove cast.
5302
5303 2019-05-17  Tom Tromey  <tromey@adacore.com>
5304
5305         * annotate.c (annotate_source): Make "filename" const.
5306         * annotate.h (annotate_source): Use const.
5307
5308 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5309
5310         * disasm.c (set_disassembler_options): Send errors to stderr.
5311
5312 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5313
5314         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5315         (cli_interp_base::set_logging): Check debug_redirect.
5316         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5317         * cli/cli-logging.c (debug_redirect): Add static variable.
5318         (pop_output_files): Add default param.
5319         (handle_redirections): Print debug setting.
5320         (show_logging_command): Likewise.
5321         (_initialize_cli_logging): Add debugredirect command.
5322         * interps.c (current_interp_set_logging): Add debug_redirect
5323         parameter.
5324         * interps.h (set_logging): Add debug_redirect parameter.
5325         (current_interp_set_logging): Likewise.
5326         * mi/mi-common.h: Likewise.
5327         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5328
5329 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5330             Tom Tromey  <tromey@adacore.com>
5331
5332         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5333         directly.
5334         * cli/cli-interp.h (make_logging_output): Remove declaration.
5335         * cli/cli-logging.c (make_logging_output): Remove function.
5336         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5337         directly.
5338         * ui-file.c (tee_file::tee_file): Remove bools.
5339         (tee_file::~tee_file): Remove deletes.
5340         * ui-file.h (tee_file): Remove bools.
5341
5342 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5343
5344         * mi/mi-cmds.h (mi_cmd_complete): New function.
5345         * mi/mi-main.c (mi_cmd_complete): Likewise.
5346         * mi/mi-cmds.c: Define new MI command -complete.
5347         * NEWS: Mention new -complete command.
5348
5349 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5350
5351         * completer.h (complete): New function.
5352         * completer.c (complete): Likewise.
5353         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5354         function defined in completer.h.
5355
5356 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5357
5358         * MAINTAINERS (Write After Approval): Add myself.
5359
5360 2019-05-17  Tom de Vries  <tdevries@suse.de>
5361
5362         PR gdb/24094
5363         * dwarf2read.c (struct cu_partial_die_info): New struct.
5364         (find_partial_die): Return cu_partial_die_info.
5365         (partial_die_parent_scope, guess_partial_die_structure_name)
5366         (partial_die_info::fixup): Handle new return type of find_partial_die.
5367
5368 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5369
5370         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5371         "std::string", simplifying the algorithm.
5372
5373 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5374
5375         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5376         (stap_static_probe_ops::get_probes): Likewise.
5377
5378 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5379
5380         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5381         '-')" and "else if".
5382         (stap_parse_single_operand): Join checks for
5383         "gdbarch_stap_parse_special_token_p" and
5384         "gdbarch_stap_parse_special_token" in the same "if" statement.
5385         Invert check when verifying for operation on register
5386         displacement.
5387
5388 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5389
5390         * stap-probe.c (stap_get_opcode): Update comment.
5391         (stap_get_expected_argument_type): Likewise.
5392         (handle_stap_probe): Likewise.
5393
5394 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5395
5396         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5397         return type to 'bool'.  Adjust comment.  Use 'bool' when
5398         appropriate.
5399         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5400         * stap-probe.c (stap_parse_argument_1): Likewise.
5401         (stap_is_operator): Likewise.
5402         (stap_is_generic_prefix): Likewise.
5403         (stap_is_register_prefix): Likewise.
5404         (stap_is_register_indirection_prefix): Likewise.
5405         (stap_is_integer_prefix): Likewise.
5406         (stap_generic_check_suffix): Likewise.
5407         (stap_check_integer_suffix): Likewise.
5408         (stap_check_register_suffix): Likewise.
5409         (stap_check_register_indirection_suffix): Likewise.
5410         (stap_parse_register_operand): Likewise.
5411         (stap_parse_single_operand): Likewise.
5412         (stap_parse_argument_1): Likewise.
5413         (stap_probe::get_argument_count): Likewise.
5414         (stap_is_operator): Likewise.
5415
5416 2019-05-16  Tom Tromey  <tromey@adacore.com>
5417
5418         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5419         keyword to foreach.
5420
5421 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5422
5423         * linux-thread-db.c (try_thread_db_load_1): Change return type
5424         to bool.
5425         (try_thread_db_load): Likewise.
5426         (try_thread_db_load_from_pdir_1): Likewise.
5427         (try_thread_db_load_from_pdir): Likewise.
5428         (try_thread_db_load_from_sdir): Likewise.
5429         (try_thread_db_load_from_dir): Likewise.
5430         (thread_db_load_search): Likewise.
5431         (has_libpthread): Likewise.
5432         (thread_db_load): Likewise.
5433
5434 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5435
5436         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5437         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5438         NULL, and complain/return if that's the case.
5439
5440 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5441
5442         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5443         (advance, posn, abstract_read_memory): New functions.
5444         [struct mem_read_abstraction]: New struct.
5445         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5446
5447 2019-05-14  Tom Tromey  <tromey@adacore.com>
5448
5449         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5450         value is not lval_memory.
5451
5452 2019-05-14  Tom Tromey  <tromey@adacore.com>
5453
5454         * solib.c (info_sharedlibrary_command): Style the file name.
5455
5456 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5457
5458         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5459         (aarch64_vnv_type): Likewise.
5460         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5461         * common/tdesc.c: Likewise.
5462         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5463         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5464         * features/aarch64-fpu.xml: Add ieee half view.
5465         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5466         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5467         * gdbtypes.h (struct builtin_type): Likewise.
5468         (struct objfile_type): Likewise.
5469
5470 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5471
5472         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5473         typo.
5474         * location.h (string_to_event_location): Likewise.
5475
5476 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5477
5478         GDB 8.3 released.
5479
5480 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5481
5482         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5483         New variable declaration.
5484         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5485         New variable.
5486         (print_one_breakpoint): Use ui_out::test_flags and new global
5487         variable to compute use_fixed_output.
5488         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5489         Remove.
5490         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5491         (mi_multi_location_breakpoint_output_fixed): Remove.
5492         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5493         new variable.
5494         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5495         fix_multi_location_breakpoint_output flag if version >= 3.
5496         * ui-out.h (enum ui_out_flag)
5497         <fix_multi_location_breakpoint_output>: New enumerator.
5498
5499 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5500
5501         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5502
5503 2019-05-10  Tom Tromey  <tromey@adacore.com>
5504
5505         * ada-lang.c (catch_ada_completer): New function.
5506         (_initialize_ada_language): Use it.
5507
5508 2019-05-10  Tom Tromey  <tromey@adacore.com>
5509
5510         * thread.c (print_thread_info): Make "requested_threads" const.
5511         * gdbthread.h (print_thread_info): Make "requested_threads"
5512         const.
5513         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5514         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5515
5516 2019-05-08  Tom Tromey  <tom@tromey.com>
5517
5518         * gdbtypes.c (objfile_type_data): Change type.
5519         (objfile_type, _initialize_gdbtypes): Update.
5520
5521 2019-05-08  Tom Tromey  <tom@tromey.com>
5522
5523         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5524         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5525         (_initialize_dwarf2_frame): Update.
5526
5527 2019-05-08  Tom Tromey  <tom@tromey.com>
5528
5529         * objc-lang.c (objc_objfile_data): Change type.
5530         (find_methods): Update.
5531         (_initialize_objc_lang): Remove.
5532
5533 2019-05-08  Tom Tromey  <tom@tromey.com>
5534
5535         * stabsread.c (rs6000_builtin_type_data): Change type.
5536         (rs6000_builtin_type, _initialize_stabsread): Update.
5537
5538 2019-05-08  Tom Tromey  <tom@tromey.com>
5539
5540         * mips-tdep.c (mips_pdr_data): Remove.
5541         (_initialize_mips_tdep): Update.
5542
5543 2019-05-08  Tom Tromey  <tom@tromey.com>
5544
5545         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5546         (hppa_init_objfile_priv_data, read_unwind_info)
5547         (find_unwind_entry, _initialize_hppa_tdep): Update.
5548
5549 2019-05-08  Tom Tromey  <tom@tromey.com>
5550
5551         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5552         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5553         on obstack.
5554         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5555
5556 2019-05-08  Tom Tromey  <tom@tromey.com>
5557
5558         * mdebugread.c (basic_type_data): Change type.
5559         (basic_type, _initialize_mdebugread): Update.
5560
5561 2019-05-08  Tom Tromey  <tom@tromey.com>
5562
5563         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5564
5565 2019-05-08  Tom Tromey  <tom@tromey.com>
5566
5567         * nto-tdep.c (nto_inferior_data_reg): Change type.
5568         (nto_inferior_data): Update.
5569         (nto_inferior_data_cleanup, nto_new_inferior_data)
5570         (_initialize_nto_tdep): Remove.
5571         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5572
5573 2019-05-08  Tom Tromey  <tom@tromey.com>
5574
5575         * ada-lang.c (struct ada_inferior_data): Add initializers.
5576         (ada_inferior_data): Change type.
5577         (ada_inferior_data_cleanup): Remove.
5578         (get_ada_inferior_data, ada_inferior_exit)
5579         (struct ada_pspace_data): Add initializers, destructor.
5580         (ada_pspace_data_handle): Change type.
5581         (get_ada_pspace_data): Update.
5582         (ada_pspace_data_cleanup): Remove.
5583
5584 2019-05-08  Tom Tromey  <tom@tromey.com>
5585
5586         * coffread.c (struct coff_symfile_info): Add initializers.
5587         (coff_objfile_data_key): Move lower.  Change type.
5588         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5589         Update.
5590         (coff_free_info): Remove.
5591
5592 2019-05-08  Tom Tromey  <tom@tromey.com>
5593
5594         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5595         (fbsd_pspace_data_handle): Move lower.  Change type.
5596         (get_fbsd_pspace_data): Update.
5597         (fbsd_pspace_data_cleanup): Remove.
5598         (_initialize_fbsd_tdep): Update.
5599
5600 2019-05-08  Tom Tromey  <tom@tromey.com>
5601
5602         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5603         (get_ada_tasks_pspace_data): Update.
5604         (ada_tasks_pspace_data_cleanup): Remove.
5605         (_initialize_tasks): Update.
5606         (ada_tasks_inferior_data_handle): Change type.
5607         (get_ada_tasks_inferior_data): Update.
5608         (ada_tasks_inferior_data_cleanup): Remove.
5609         (struct ada_tasks_pspace_data): Add initializers.
5610
5611 2019-05-08  Tom Tromey  <tom@tromey.com>
5612
5613         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5614         * symfile-debug.c (debug_sym_get_probes): Change type.
5615         * stap-probe.c (handle_stap_probe):
5616         (stap_static_probe_ops::get_probes): Change type.
5617         * probe.h (class static_probe_ops) <get_probes>: Change type.
5618         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5619         (parse_probes_in_pspace): Update.
5620         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5621         Update.
5622         (any_static_probe_ops::get_probes): Change type.
5623         * elfread.c (elfread_data): New typedef.
5624         (probe_key): Change type.
5625         (elf_get_probes): Likewise.  Update.
5626         (probe_key_free): Remove.
5627         (_initialize_elfread): Update.
5628         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5629         Change type.
5630         (dtrace_process_dof_probe, dtrace_process_dof)
5631         (dtrace_static_probe_ops::get_probe): Change type.
5632
5633 2019-05-08  Tom Tromey  <tom@tromey.com>
5634
5635         * xcoffread.c (struct xcoff_symfile_info): Rename from
5636         coff_symfile_info.  Add initializers.
5637         (xcoff_objfile_data_key): Move lower.  Change type.
5638         (XCOFF_DATA): Rewrite.
5639         (xcoff_free_info): Remove.
5640         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5641         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5642         (xcoff_initial_scan): Update.
5643
5644 2019-05-08  Tom Tromey  <tom@tromey.com>
5645
5646         * solib-svr4.c (struct svr4_info): Add initializers and
5647         destructor.
5648         <probes_table>: Now an htab_up.
5649         (solib_svr4_pspace_data): Change type.
5650         (free_probes_table): Simplify.
5651         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5652         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5653         (probes_table_remove_objfile_probes, register_solib_event_probe)
5654         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5655         (_initialize_svr4_solib): Update.
5656
5657 2019-05-08  Tom Tromey  <tom@tromey.com>
5658
5659         * remote.c (remote_pspace_data): Change type.
5660         (remote_pspace_data_cleanup): Remove.
5661         (get_remote_exec_file, set_pspace_remote_exec_file)
5662         (_initialize_remote): Update.
5663
5664 2019-05-08  Tom Tromey  <tom@tromey.com>
5665
5666         * breakpoint.c (breakpoint_objfile_key): Change type.
5667         (get_breakpoint_objfile_data): Update.
5668         (free_breakpoint_objfile_data): Remove.
5669         (_initialize_breakpoint): Update.
5670
5671 2019-05-08  Tom Tromey  <tom@tromey.com>
5672
5673         * linux-tdep.c (struct linux_info): Add initializers.
5674         (linux_inferior_data): Move.  Change type.
5675         (invalidate_linux_cache_inf): Update.
5676         (linux_inferior_data_cleanup): Remove.
5677         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5678
5679 2019-05-08  Tom Tromey  <tom@tromey.com>
5680
5681         * auxv.c (auxv_inferior_data): Move.  Change type.
5682         (auxv_inferior_data_cleanup): Remove.
5683         (invalidate_auxv_cache_inf): Rewrite.
5684         (get_auxv_inferior_data, _initialize_auxv): Update.
5685
5686 2019-05-08  Tom Tromey  <tom@tromey.com>
5687
5688         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5689         (symfile_debug_objfile_data_key): Change type.
5690         (symfile_debug_installed, debug_qf_has_symbols)
5691         (debug_qf_find_last_source_symtab)
5692         (debug_qf_forget_cached_source_info)
5693         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5694         (debug_qf_print_stats, debug_qf_dump)
5695         (debug_qf_expand_symtabs_for_function)
5696         (debug_qf_expand_all_symtabs)
5697         (debug_qf_expand_symtabs_with_fullname)
5698         (debug_qf_map_matching_symbols)
5699         (debug_qf_expand_symtabs_matching)
5700         (debug_qf_find_pc_sect_compunit_symtab)
5701         (debug_qf_map_symbol_filenames)
5702         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5703         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5704         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5705         (debug_sym_read_linetable, debug_sym_relocate): Update.
5706         (symfile_debug_free_objfile): Remove.
5707         (install_symfile_debug_logging, _initialize_symfile_debug):
5708         Update.
5709
5710 2019-05-08  Tom Tromey  <tom@tromey.com>
5711
5712         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5713         allocate_on_obstack.
5714         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5715         (get_dwarf2_per_objfile): Update.
5716         (set_dwarf2_per_objfile): Remove.
5717         (dwarf2_has_info, dwarf2_get_section_info): Update.
5718         (dwarf2_free_objfile): Remove.
5719         (_initialize_dwarf2_read): Update.
5720
5721 2019-05-08  Tom Tromey  <tom@tromey.com>
5722
5723         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5724         initializers.
5725         <unsupported_script_warning_printed,
5726         script_not_found_warning_printed>: Now bool.
5727         (auto_load_pspace_data): Change type.
5728         (~auto_load_pspace_info): Rename from
5729         auto_load_pspace_data_cleanup.
5730         (get_auto_load_pspace_data, init_loaded_scripts_info)
5731         (clear_section_scripts, maybe_print_unsupported_script_warning)
5732         (maybe_print_script_not_found_warning, _initialize_auto_load):
5733         Update.
5734
5735 2019-05-08  Tom Tromey  <tom@tromey.com>
5736
5737         * objfiles.c (objfile_pspace_info): Add destructor and
5738         initializers.
5739         (objfiles_pspace_data): Change type.
5740         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5741         (get_objfile_pspace_data): Update.
5742         (objfiles_bfd_data): Change type.
5743         (get_objfile_bfd_data): Update.
5744         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5745
5746 2019-05-08  Tom Tromey  <tom@tromey.com>
5747
5748         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5749         Change type.
5750         (get_catch_syscall_inferior_data): Update.
5751         (catch_syscall_inferior_data_cleanup): Remove.
5752         (_initialize_break_catch_syscall): Update.
5753
5754 2019-05-08  Tom Tromey  <tom@tromey.com>
5755
5756         * inflow.c (struct terminal_info): Add destructor and
5757         initializers.
5758         (inflow_inferior_data): Change type.
5759         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5760         (get_inflow_inferior_data, inflow_inferior_exit)
5761         (swap_terminal_info, _initialize_inflow): Update.
5762
5763 2019-05-08  Tom Tromey  <tom@tromey.com>
5764
5765         * target-dcache.c (target_dcache_cleanup): Remove.
5766         (target_dcache_aspace_key): Change type.
5767         (target_dcache_init_p, target_dcache_invalidate)
5768         (target_dcache_get, target_dcache_get_or_init)
5769         (_initialize_target_dcache): Update.
5770         * dcache.h (struct dcache_deleter): New.
5771
5772 2019-05-08  Tom Tromey  <tom@tromey.com>
5773
5774         * symtab.c (struct symbol_cache): Add destructor and
5775         initializers.
5776         (symbol_cache_key): Move.  Change type.
5777         (make_symbol_cache, free_symbol_cache): Remove.
5778         (get_symbol_cache): Update.
5779         (symbol_cache_cleanup): Remove.
5780         (ALL_PSPACES, symbol_cache_flush)
5781         (maintenance_print_symbol_cache)
5782         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5783         Update.
5784
5785 2019-05-08  Tom Tromey  <tom@tromey.com>
5786
5787         * symtab.c (struct main_info): Add destructor and initializers.
5788         (main_progspace_key): Move.  Change type.
5789         (get_main_info): Update.
5790         (main_info_cleanup): Remove.
5791         (_initialize_symtab): Update.
5792
5793 2019-05-08  Tom Tromey  <tom@tromey.com>
5794
5795         * registry.h (DECLARE_REGISTRY): Define the _key class.
5796
5797 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5798
5799         * NEWS: Merge two 'New commands' sections.
5800
5801 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5802
5803         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5804         parameter and use Ada language definition instead.
5805         (ada_val_print_ptr): Remove unused language parameter.
5806         (ada_val_print_num): Remove language parameter and use Ada language
5807         definition instead.
5808         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5809         parameter.
5810         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5811         parameter and use Ada language definition instead.
5812         (ada_val_print_1): Update all ada_val_print_xxx calls.
5813         Remove language parameter.
5814         (ada_val_print): Update ada_val_print_1 call.
5815
5816 2019-05-08  Tom Tromey  <tromey@adacore.com>
5817
5818         * remote.c (remote_hw_watchpoint_limit)
5819         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5820         Now static.
5821
5822 2019-05-08  Tom Tromey  <tromey@adacore.com>
5823
5824         * maint.c (_initialize_maint_cmds): Move initialization code to
5825         remote.c.
5826         (watchdog, show_watchdog): Move to remote.c.
5827         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5828         "watchdog" static.
5829         (_initialize_remote): Move initialization code from maint.c.
5830         * defs.h (watchdog): Don't declare.
5831
5832 2019-05-08  Tom Tromey  <tromey@adacore.com>
5833
5834         * tui/tui-interp.c: Include main.h.
5835         * interps.c: Include main.h.
5836         * main.h (interpreter_p): Declare.
5837         * defs.h (interpreter_p): Don't declare.
5838
5839 2019-05-08  Tom Tromey  <tromey@adacore.com>
5840
5841         * dwarf2loc.c: Include dwarf2read.h.
5842         * defs.h (read_unsigned_leb128): Don't declare.
5843         * dwarf2read.h (read_unsigned_leb128): Declare.
5844
5845 2019-05-08  Tom Tromey  <tromey@adacore.com>
5846
5847         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5848         method.
5849
5850 2019-05-08  Tom Tromey  <tromey@adacore.com>
5851
5852         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5853         when no wrap column is set.
5854
5855 2019-05-08  Tom Tromey  <tromey@adacore.com>
5856
5857         * c-lang.c (c_get_string): Handle non-C-style arrays.
5858
5859 2019-05-08  Tom Tromey  <tromey@adacore.com>
5860
5861         * typeprint.c (print_offset_data::update): Print the bit offset,
5862         not the number of bits remaining.
5863
5864 2019-05-08  Tom Tromey  <tromey@adacore.com>
5865
5866         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5867         padding at end of comment.
5868
5869 2019-05-08  Tom Tromey  <tromey@adacore.com>
5870
5871         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5872         Compare main types.
5873
5874 2019-05-06  Tom Tromey  <tom@tromey.com>
5875
5876         * common/scoped_mmap.c: Include common-defs.h.
5877         * common/scoped_mmap.h: Don't include config.h.
5878
5879 2019-05-04  Tom Tromey  <tom@tromey.com>
5880
5881         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5882         (struct aarch64_call_info): Add initializers.
5883         <si>: Now a std::vector.
5884         (pass_on_stack, aarch64_push_dummy_call): Update.
5885
5886 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5887             Tom Tromey  <tom@tromey.com>
5888
5889         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5890         (ppc_threads): Now a std::vector.  Now static.
5891         (hwdebug_find_thread_points_by_tid)
5892         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5893         Update.
5894
5895 2019-05-04  Tom Tromey  <tom@tromey.com>
5896
5897         * arc-tdep.c (arc_tdesc_init): Return bool.
5898
5899 2019-05-04  Tom Tromey  <tom@tromey.com>
5900
5901         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5902         Use gdb_assert_not_reached.
5903
5904 2019-05-04  Tom Tromey  <tom@tromey.com>
5905
5906         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5907         "false".
5908
5909 2019-05-04  Tom Tromey  <tom@tromey.com>
5910
5911         * arc-tdep.c (arc_tdesc_init): Use bool.
5912
5913 2019-05-04  Tom Tromey  <tom@tromey.com>
5914
5915         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5916
5917 2019-05-04  Tom Tromey  <tom@tromey.com>
5918
5919         * cli/cli-cmds.c (valid_command_p): Return bool.
5920
5921 2019-05-04  Tom Tromey  <tom@tromey.com>
5922
5923         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5924         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5925
5926 2019-05-04  Raul Tambre  <raul@tambre.ee>
5927
5928         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5929         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5930         operator for comparison.
5931
5932 2019-05-04  Tom Tromey  <tom@tromey.com>
5933
5934         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5935         (lookup_partial_symbol, print_partial_symbols)
5936         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5937         (psymbol_compare): Update.
5938         (add_psymbol_to_bcache): Clear the entire psymbol.
5939         (maintenance_check_psymtabs): Update.
5940         * psympriv.h (struct partial_symbol): Don't derive from
5941         general_symbol_info.
5942         <obj_section, unrelocated_address, address,
5943         set_unrelocated_address>: Update.
5944         <ginfo>: New member.
5945         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5946         (debug_names::write_psymbols): Update.
5947
5948 2019-05-04  Tom de Vries  <tdevries@suse.de>
5949
5950         * contrib/cc-with-tweaks.sh: Support -n arg.
5951
5952 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5953
5954         * corelow.c (core_target::detach): Ensure frame cache and
5955         register caches are cleared.
5956         inferior.c (exit_inferior_1): Likewise.
5957
5958 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5959             Tom Tromey  <tom@tromey.com>
5960
5961         * dictionary.c (collate_pending_symbols_by_language): Remove
5962         "struct" from foreach.
5963         * symtab.c (lookup_global_symbol_from_objfile)
5964         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5965         foreach.
5966         * ser-tcp.c (net_open): Remove "struct" from foreach.
5967         * objfiles.c (objfile_relocate, objfile_rebase)
5968         (objfile_has_symbols): Remove "struct" from foreach.
5969         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5970         from foreach.
5971         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5972         foreach.
5973         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5974         "struct" from foreach.
5975         * ada-lang.c (create_excep_cond_exprs)
5976         (ada_exception_catchpoint_cond_string): Remove "struct" from
5977         foreach.
5978
5979 2019-05-03  Tom Tromey  <tromey@adacore.com>
5980
5981         * ada-exp.y (convert_char_literal): Check suffix of each
5982         enumerator.
5983
5984 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5985
5986         PR ada/21406:
5987         * ada-exp.y (yywrap): Don't define.
5988         * ada-lex.l (%option): Add noyywrap
5989         (yywrap): Remove.
5990
5991 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5992
5993         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5994         _WIN32_WINNT to the XP level, unless already defined to a higher
5995         level.
5996
5997         * unittests/parse-connection-spec-selftests.c:
5998         * ser-tcp.c:
5999         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6000         override.
6001
6002         * symfile.c (find_separate_debug_file): Remove colon from the
6003         drive spec of DOS/Windows file names of the target, so that the
6004         file name produced from DEBUGDIR and the target's directory will
6005         be valid on DOS/Windows systems.
6006
6007 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6008
6009         * rust-lang.c (val_print_struct): Handle printing structures
6010         containing strings.
6011
6012 2019-05-02  Tom Tromey  <tromey@adacore.com>
6013
6014         * valarith.c (_initialize_valarith): Remove.
6015
6016 2019-05-01  Tom Tromey  <tromey@adacore.com>
6017
6018         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6019         bitfields.
6020
6021 2019-05-01  Tom Tromey  <tromey@adacore.com>
6022
6023         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6024         for big-endian copies.
6025
6026 2019-04-30  Ali Tamur  <tamur@google.com>
6027         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6028         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6029         (read_3_bytes): New function.
6030
6031 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6032
6033         * windows-nat.c (main_thread_id): Delete.
6034         (handle_output_debug_string): Replace main_thread_id by
6035         current_event.dwThreadId.
6036         (fake_create_process): Likewise.
6037         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6038         Do not set main_thread_id.
6039         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6040         current_event.dwThreadId.
6041         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6042
6043 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6044
6045         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6046         Use current_event.dwThreadId instead of main_thread_id.
6047
6048 2019-04-30  Tom Tromey  <tromey@adacore.com>
6049
6050         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6051         (create_excep_cond_exprs): Iterate over program spaces.
6052         (ada_exception_catchpoint_cond_string): Examine all minimal
6053         symbols for exception types.
6054
6055 2019-04-30  Tom Tromey  <tromey@adacore.com>
6056
6057         PR c++/24470:
6058         * dwarf2read.c (process_structure_scope): Handle case where type
6059         has template parameters but no symbol was created.
6060
6061 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6062             Chris January  <chris.january@arm.com>
6063
6064         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6065         qualifier.
6066         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6067
6068 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6069
6070         * f-typeprint.c (f_print_type): Update rules for printing
6071         whitespace.
6072         (f_type_print_varspec_suffix): Likewise.
6073
6074 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6075             Chris January  <chris.january@arm.com>
6076
6077         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6078         function arguments.
6079
6080 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6081
6082         * f-lang.c (build_fortran_types): Change name of void type to
6083         lower case.
6084         * f-typeprint.c (f_type_print_base): Print the name of the void
6085         type, rather than a fixed string.
6086         * f-valprint.c (f_decorations): Use lower case void string.
6087
6088 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6089             Chris January  <chris.january@arm.com>
6090
6091         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6092         types for Fortran.
6093
6094 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6095             Chris January  <chris.january@arm.com>
6096             David Lecomber  <david.lecomber@arm.com>
6097
6098         * f-exp.y (BINOP_INTRINSIC): New token.
6099         (exp): New parser rule handling BINOP_INTRINSIC.
6100         (f77_keywords): Add new builtin procedures.
6101         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6102         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6103         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6104         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6105         (print_unop_subexp_f): New function.
6106         (print_binop_subexp_f): New function.
6107         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6108         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6109         (dump_subexp_body_f): Likewise.
6110         (operator_check_f): Likewise.
6111         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6112         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6113
6114 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6115
6116         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6117         UNOP_KIND.
6118         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6119         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6120         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6121         (operator_length_f): New fuction.
6122         (print_subexp_f): New function.
6123         (op_name_f): New function.
6124         (dump_subexp_body_f): New function.
6125         (operator_check_f): New function.
6126         (exp_descriptor_f): Replace standard expression handling functions
6127         with new functions.
6128         * gdb/fortran-operator.def: New file.
6129         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6130         * gdb/std-operator.def: Remove UNOP_KIND.
6131
6132 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6133
6134         * std-operator.def: Remove unbalanced, stray double quote
6135         character.
6136
6137 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6138             Chris January  <chris.january@arm.com>
6139             Daniel Everett  <daniel.everett@arm.com>
6140             Nick Forrington  <nick.forrington@arm.com>
6141             Richard Bunt  <richard.bunt@arm.com>
6142
6143         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6144         of depth when printing anonymous structs or unions.
6145         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6146         Don't print either the top-level value, or the children if the
6147         max-depth is exceeded.
6148         (ppscm_print_children): When printing the key of a map, allow one
6149         extra level of depth.
6150         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6151         print either the top-level value, or the children if the max-depth
6152         is exceeded.
6153         (print_children): When printing the key of a map, allow one extra
6154         level of depth.
6155         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6156         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6157         (user_print_options): Initialise max_depth field.
6158         (val_print_scalar_or_string_type_p): New function.
6159         (val_print): Check to see if the max depth has been reached.
6160         (val_print_check_max_depth): Define new function.
6161         (show_print_max_depth): New function.
6162         (_initialize_valprint): Add 'print max-depth' option.
6163         * valprint.h (struct value_print_options) <max_depth>: New field.
6164         (val_print_check_max_depth): Declare new function.
6165         * NEWS: Document new feature.
6166
6167 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6168
6169         * ada-lang.c (ada_language_defn): Initialise new field.
6170         * c-lang.c (c_is_string_type_p): New function.
6171         (c_language_defn): Initialise new field.
6172         (cplus_language_defn): Initialise new field.
6173         (asm_language_defn): Initialise new field.
6174         (minimal_language_defn): Initialise new field.
6175         * c-lang.h (c_is_string_type_p): Declare new function.
6176         * d-lang.c (d_language_defn): Initialise new field.
6177         * f-lang.c (f_is_string_type_p): New function.
6178         (f_language_defn): Initialise new field.
6179         * go-lang.c (go_is_string_type_p): New function.
6180         (go_language_defn): Initialise new field.
6181         * language.c (default_is_string_type_p): New function.
6182         (unknown_language_defn): Initialise new field.
6183         (auto_language_defn): Initialise new field.
6184         * language.h (struct language_defn) <la_is_string_type_p>: New
6185         member variable.
6186         (default_is_string_type_p): Declare new function.
6187         * m2-lang.c (m2_language_defn): Initialise new field.
6188         * objc-lang.c (objc_language_defn): Initialise new field.
6189         * opencl-lang.c (opencl_language_defn): Initialise new field.
6190         * p-lang.c (pascal_is_string_type_p): New function.
6191         (pascal_language_defn): Initialise new field.
6192         * rust-lang.c (rust_is_string_type_p): New function.
6193         (rust_language_defn): Initialise new field.
6194
6195 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6196
6197         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6198         New field.
6199         * ada-lang.c (ada_language_defn): Initialise new field.
6200         * c-lang.c (c_language_defn): Likewise.
6201         (cplus_language_defn): Likewise.
6202         (asm_language_defn): Likewise.
6203         (minimal_language_defn): Likewise.
6204         * d-lang.c (d_language_defn): Likewise.
6205         * f-lang.c (f_language_defn): Likewise.
6206         * go-lang.c (go_language_defn): Likewise.
6207         * language.c (unknown_language_defn): Likewise.
6208         (auto_language_defn): Likewise.
6209         * m2-lang.c (m2_language_defn): Likewise.
6210         * objc-lang.c (objc_language_defn): Likewise.
6211         * opencl-lang.c (opencl_language_defn): Likewise.
6212         * p-lang.c (pascal_language_defn): Likewise.
6213         * rust-lang.c (rust_language_defn): Likewise.
6214
6215 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6216
6217         * ada-lang.c (ada_is_character_type): Change return type to bool.
6218         (ada_is_string_type): Likewise.
6219         * ada-lang.h (ada_is_character_type): Update declaration
6220         (ada_is_string_type): Likewise.
6221
6222 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6223
6224         Support style in 'frame|thread apply'
6225
6226         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6227         * record.c (record_start, record_stop): Update callers of
6228         execute_command_to_string with false.
6229         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6230         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6231         methods.
6232         (class string_file): New constructor with term_out parameter.
6233         Override methods term_out and can_emit_style_escape.  New member
6234         term_out.
6235         (class stdio_file): Override can_emit_style_escape.
6236         (class tee_file): Override term_out and can_emit_style_escape.
6237         * utils.h (can_emit_style_escape): Remove.
6238         * utils.c (can_emit_style_escape): Likewise.
6239         Update all callers of can_emit_style_escape (SOMESTREAM) to
6240         SOMESTREAM->can_emit_style_escape.
6241         * source-cache.c (source_cache::get_source_lines): Likewise.
6242         * stack.c (frame_apply_command_count): Call execute_command_to_string
6243         passing the term_out characteristic of the current gdb_stdout.
6244         * thread.c (thr_try_catch_cmd): Likewise.
6245         * top.c (execute_command_to_string): pass term_out parameter
6246         to construct the string_file for the command output.
6247         * ui-file.c (term_cli_styling): New function (most code moved
6248         from utils.c can_emit_style_escape).
6249         (string_file::string_file, string_file::can_emit_style_escape,
6250         stdio_file::can_emit_style_escape, tee_file::term_out,
6251         tee_file::can_emit_style_escape): New functions.
6252
6253 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6254
6255         * NEWS: Mention the new set|show may-call-functions.
6256         * infcall.c (may_call_functions_p): New variable.
6257         (show_may_call_functions_p): New function.
6258         (call_function_by_hand_dummy): Throws an error if not
6259         may-call-functions.
6260         (_initialize_infcall): Call add_setshow_boolean_cmd for
6261         may-call-functions.
6262
6263 2019-04-25  Keith Seitz  <keiths@redhat.com>
6264
6265         PR c++/24367
6266         * cp-support.c (inspect_type): Don't attempt substitutions
6267         of symbol with the same name.
6268
6269 2019-04-25  Tom Tromey  <tromey@adacore.com>
6270
6271         PR gdb/24475:
6272         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6273         static.
6274
6275 2019-04-25  Tom Tromey  <tromey@adacore.com>
6276
6277         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6278         rvalue reference.
6279         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6280         (gdb_xml_parser::parse): Use std::move.
6281         * python/python-internal.h (gdbpy_convert_exception): Take a const
6282         reference.
6283         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6284         std::move.
6285         * python/py-utils.c (gdbpy_convert_exception): Take a const
6286         reference.
6287         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6288         Use std::move.
6289         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6290         Use std::move.
6291         * mi/mi-main.c (mi_print_exception): Take a const reference.
6292         * main.c (handle_command_errors): Take a const reference.
6293         * linespec.c (parse_linespec): Use std::move.
6294         * infcall.c (run_inferior_call): Use std::move.
6295         (call_function_by_hand_dummy): Use std::move.
6296         * exec.c (try_open_exec_file): Use std::move.
6297         * exceptions.h (exception_print, exception_fprintf)
6298         (exception_print_same): Update.
6299         * exceptions.c (print_exception, exception_print)
6300         (exception_fprintf, exception_print_same): Change parameters to
6301         const reference.
6302         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6303         * common/new-op.c: Use std::move.
6304         * common/common-exceptions.h (struct gdb_exception): Add move
6305         constructor.
6306         (struct gdb_exception_error, struct gdb_exception_quit, struct
6307         gdb_quit_bad_alloc): Change constructor to move constructor.
6308         (throw_exception): Change parameter to rvalue reference.
6309         * common/common-exceptions.c (throw_exception): Take rvalue
6310         reference.
6311         * cli/cli-interp.c (safe_execute_command): Use std::move.
6312         * breakpoint.c (insert_bp_location, location_to_sals): Use
6313         std::move.
6314
6315 2019-04-25  Tom Tromey  <tromey@adacore.com>
6316
6317         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6318         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6319         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6320         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6321         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6322         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6323         guile/scm-value.c: Use unpack.
6324         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6325         gdbscm_gdb_exception.
6326         (gdbscm_throw_gdb_exception): Likewise.
6327         (struct gdbscm_gdb_exception): New.
6328         (unpack): New function.
6329         (gdbscm_wrap): Use unpack.
6330
6331 2019-04-25  Tom Tromey  <tromey@adacore.com>
6332
6333         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6334         (gdb_rl_callback_handler): Use std::move.
6335         * common/common-exceptions.h (struct gdb_exception): Add move
6336         assignment operator.
6337         (throw_exception_sjlj): Change "exception" to const reference.
6338         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6339         (throw_exception_sjlj): Change "exception" to const reference.
6340
6341 2019-04-25  Tom Tromey  <tromey@adacore.com>
6342
6343         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6344         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6345         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6346         Update.
6347         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6348         Update.
6349         * mi/mi-interp.c (mi_interp::exec): Update.
6350         * linespec.c (parse_linespec): Update.
6351         * infcall.c (run_inferior_call): Update.
6352         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6353         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6354         (gdbscm_lookup_global_symbol): Update.
6355         * guile/scm-param.c (gdbscm_parameter_value): Update.
6356         * guile/scm-frame.c (gdbscm_frame_read_register)
6357         (gdbscm_frame_read_var): Update.
6358         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6359         * exec.c (try_open_exec_file): Update.
6360         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6361         (gdb_rl_callback_handler): Update.
6362         * common/common-exceptions.h (exception_none): Don't declare.
6363         * common/common-exceptions.c (exception_none): Don't define.
6364         (struct catcher) <exception>: Update.
6365         * cli/cli-interp.c (safe_execute_command): Update.
6366         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6367
6368 2019-04-25  Ali Tamur  <tamur@google.com>
6369
6370         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6371         (read_attribute_value): Likewise.
6372         (dwarf2_read_addr_index): Update comment.
6373         (read_str_index): Add DW_FORM_strx.
6374         (dwarf2_string_attr): Likewise.
6375         (dwarf2_const_value_attr): Likewise.
6376         (dump_die_shallow): Likewise.
6377         (dwarf2_fetch_constant_bytes): Likewise.
6378         (skip_form_bytes): Likewise.
6379         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6380
6381 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6382
6383         PR corefiles/11608
6384         PR corefiles/18187
6385         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6386         OFFSET.  Verify if current mapping contains an ELF header.
6387         (linux_find_memory_regions_full): Adjust call to
6388         dump_mapping_p.
6389
6390 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6391             Kang Li <kanglictf@gmail.com>
6392
6393         PR gdb/21600
6394
6395         * dwarf2-frame.c (read_initial_length): Be consistent about using
6396         unsigned representation of length.
6397         (decode_frame_entry_1): Likewise.  Check for wraparound of
6398         end pointer as well as buffer overflow.
6399
6400 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6401
6402         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6403         "vq".
6404
6405 2019-04-24  Tom Tromey  <tromey@adacore.com>
6406
6407         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6408
6409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6410
6411         * s12z-tdep.c (s12z_unwind_pc): Delete.
6412         (s12z_unwind_sp): Delete.
6413         (s12z_gdbarch_init): Don't register deleted functions with
6414         gdbarch.
6415
6416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6417
6418         * rl78-tdep.c (rl78_unwind_sp): Delete.
6419         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6420
6421 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6422
6423         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6424         (xstormy16_unwind_pc): Delete.
6425         (xstormy16_dummy_id): Delete.
6426         (xstormy16_gdbarch_init): Don't register deleted functions with
6427         gdbarch.
6428
6429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6430
6431         * vax-tdep.c (vax_unwind_pc): Delete.
6432         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6433
6434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6435
6436         * v850-tdep.c (v850_unwind_sp): Delete.
6437         (v850_unwind_pc): Delete.
6438         (v850_dummy_id): Delete.
6439         (v850_gdbarch_init): Don't register deleted functions with
6440         gdbarch.
6441
6442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6443
6444         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6445         (tilegx_unwind_pc): Delete.
6446         (tilegx_unwind_dummy_id): Delete.
6447         (tilegx_gdbarch_init): Don't register deleted functions with
6448         gdbarch.
6449
6450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6451
6452         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6453         (tic6x_dummy_id): Delete.
6454         (tic6x_gdbarch_init): Don't register deleted functions with
6455         gdbarch.
6456
6457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6458
6459         * sparc-tdep.c (sparc_unwind_pc): Delete.
6460         (sparc32_gdbarch_init): Don't register deleted function with
6461         gdbarch.
6462
6463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6464
6465         * sh-tdep.c (sh_unwind_sp): Delete.
6466         (sh_unwind_pc): Delete.
6467         (sh_dummy_id): Delete.
6468         (sh_gdbarch_init): Don't register deleted functions with
6469         gdbarch.
6470
6471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6472
6473         * score-tdep.c (score_unwind_sp): Delete.
6474         (score_unwind_pc): Delete.
6475         (score_dummy_id): Delete.
6476         (score_gdbarch_init): Don't register deleted functions with
6477         gdbarch.
6478
6479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6480
6481         * rx-tdep.c (rx_unwind_pc): Delete.
6482         (rx_unwind_sp): Delete.
6483         (rx_dummy_id): Delete.
6484         (rx_gdbarch_init): Don't register deleted functions with
6485         gdbarch.  Update comment.
6486
6487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6488
6489         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6490         (rs6000_dummy_id): Delete.
6491         (rs6000_gdbarch_init): Don't register deleted functions with
6492         gdbarch.
6493
6494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6495
6496         * or1k-tdep.c (or1k_dummy_id): Delete.
6497         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6498
6499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6500
6501         * nios2-tdep.c (nios2_dummy_id): Delete.
6502         (nios2_unwind_sp): Delete.
6503         (nios2_gdbarch_init): Don't register deleted functions with
6504         gdbarch.
6505
6506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6507
6508         * nds32-tdep.c (nds32_dummy_id): Delete.
6509         (nds32_unwind_pc): Delete.
6510         (nds32_unwind_sp): Delete.
6511         (nds32_gdbarch_init): Don't register deleted functions with
6512         gdbarch.
6513
6514 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6515
6516         * msp430-tdep.c (msp430_unwind_pc): Delete.
6517         (msp430_unwind_sp): Delete.
6518         (msp430_dummy_id): Delete.
6519         (msp430_gdbarch_init): Don't register deleted functions with
6520         gdbarch.
6521
6522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6523
6524         * moxie-tdep.c (moxie_unwind_sp): Delete.
6525         (moxie_unwind_pc): Delete.
6526         (moxie_dummy_id): Delete.
6527         (moxie_gdbarch_init): Don't register deleted functions with
6528         gdbarch.
6529
6530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6531
6532         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6533         (mn10300_unwind_pc): Delete.
6534         (mn10300_unwind_sp): Delete.
6535         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6536         mn10300_unwind_sp.
6537         (mn10300_frame_unwind_init): Don't register deleted functions with
6538         gdbarch.
6539
6540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6541
6542         * mep-tdep.c (mep_unwind_pc): Delete.
6543         (mep_unwind_sp): Delete.
6544         (mep_dummy_id): Delete.
6545         (mep_gdbarch_init): Don't register deleted functions with
6546         gdbarch.
6547
6548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6549
6550         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6551         (m68hc11_unwind_sp): Delete.
6552         (m68hc11_gdbarch_init): Don't register deleted functions with
6553         gdbarch.
6554
6555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6556
6557         * m32r-tdep.c (m32r_unwind_sp): Delete.
6558         (m32r_unwind_pc): Delete.
6559         (m32r_dummy_id): Delete.
6560         (m32r_gdbarch_init): Don't register deleted functions with
6561         gdbarch.
6562
6563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6564
6565         * m32c-tdep.c (m32c_unwind_pc): Delete.
6566         (m32c_unwind_sp): Delete.
6567         (m32c_dummy_id): Delete.
6568         (m32c_gdbarch_init): Don't register deleted functions with
6569         gdbarch.
6570
6571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6572
6573         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6574         (lm32_unwind_pc): Delete.
6575         (lm32_dummy_id): Delete.
6576         (lm32_gdbarch_init): Don't register deleted functions with
6577         gdbarch.
6578
6579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6580
6581         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6582         (iq2000_unwind_pc): Delete.
6583         (iq2000_dummy_id): Delete.
6584         (iq2000_gdbarch_init): Don't register deleted functions with
6585         gdbarch.
6586
6587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6588
6589         * nds32-tdep.c (nds32_type_align): Delete.
6590         (nds32_push_dummy_call): Use type_align instead.
6591
6592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6593
6594         * arm-tdep.c (arm_type_align): Only handle vector override case.
6595         (arm_push_dummy_call): Use type_align.
6596         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6597
6598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6599
6600         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6601         case.
6602         (pass_on_stack): Use type_align.
6603         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6604         function.
6605
6606 2019-04-23  Tom Tromey  <tromey@adacore.com>
6607
6608         * dwarf2read.c (line_header::file_name_at): Remove unused
6609         overload.
6610
6611 2019-04-23  Tom de Vries  <tdevries@suse.de>
6612
6613         PR gdb/24438
6614         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6615         invocation.
6616
6617
6618 2019-03-27  Ali Tamur  <tamur@google.com>
6619
6620         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6621         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6622         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6623         (dwarf_expr_context::get_addr_index): Likewise
6624         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6625         (symbol_needs_eval_context::get_addr_index): Likewise
6626         (disassemble_dwarf_expression): Add DW_OP_addrx
6627         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6628         (read_cutu_die_from_dwo): Update comment
6629         (skip_one_die): Add DW_FORM_addrx
6630         (read_attribute_value): Likewise
6631         (var_decode_location): Add DW_OP_addrx
6632         (dwarf2_const_value_attr): Add DW_FORM_addrx
6633         (dump_die_shallow): Likewise
6634         (dwarf2_fetch_constant_bytes): Likewise
6635         (decode_locdesc): Add DW_OP_addrx
6636         (skip_form_bytes): Add DW_FORM_addrx
6637
6638 2019-04-22  Ali Tamur  <tamur@google.com>
6639
6640         * MAINTAINERS (Write After Approval): Add self.
6641
6642 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6643
6644         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6645         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6646         (open_symbol_file_object): Likewise.
6647         (svr4_default_sos): Add info parameter.
6648         (svr4_read_so_list): Likewise.
6649         (svr4_current_sos_direct): Adjust functions calls to pass down
6650         info.
6651         (svr4_current_sos_1): Add info parameter.
6652         (svr4_current_sos): Call get_svr4_info, pass info down to
6653         svr4_current_sos_1.
6654         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6655         get_svr4_info.
6656         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6657         get_svr4_info.
6658         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6659         to get_svr4_info.
6660         (probes_table_remove_objfile_probes): Likewise.
6661         (register_solib_event_probe): Add info parameter.
6662         (solist_update_incremental): Pass info parameter down to
6663         svr4_read_so_list.
6664         (disable_probes_interface): Add info parameter.
6665         (svr4_handle_solib_event): Pass current_program_space to
6666         get_svr4_info.  Adjust disable_probes_interface cleanup.
6667         (svr4_create_probe_breakpoints): Add info parameter, pass it
6668         down to register_solib_event_probe.
6669         (svr4_create_solib_event_breakpoints): Add info parameter,
6670         pass it down to svr4_create_probe_breakpoints.
6671         (enable_break): Pass info down to
6672         svr4_create_solib_event_breakpoints.
6673         (svr4_solib_create_inferior_hook): Pass current_program_space to
6674         get_svr4_info.
6675         (svr4_clear_solib): Likewise.
6676
6677 2019-04-22  Pedro Alves  <palves@redhat.com>
6678
6679         * solib-svr4.c (svr4_free_objfile_observer): New.
6680         (probe_and_action::objfile): New field.
6681         (probes_table_htab_remove_objfile_probes)
6682         (probes_table_remove_objfile_probes): New functions.
6683         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6684         in the new probe_and_action.  Don't store the probe in 'lookup'.
6685         (svr4_create_probe_breakpoints): Pass objfile to
6686         register_solib_event_probe.
6687         (_initialize_svr4_solib): Register a free_objfile observer.
6688
6689 2019-04-19  Tom Tromey  <tom@tromey.com>
6690
6691         * common/queue.h: Remove.
6692
6693 2019-04-19  Tom Tromey  <tom@tromey.com>
6694
6695         * event-loop.c: Don't include "common/queue.h".
6696
6697 2019-04-19  Tom Tromey  <tom@tromey.com>
6698
6699         * remote.c (remote_target): Use delete.
6700         * remote-notif.h: Include <list>, not "common/queue.h".
6701         (notif_client_p): Remove typedef.
6702         (remote_notif_state): Add constructor, destructor, initializer.
6703         <notif_queue>: Now a std::list.
6704         (remote_notif_state_xfree): Don't declare.
6705         * remote-notif.c (remote_notif_process, handle_notification)
6706         (remote_notif_state_allocate): Update.
6707         (~remote_notif_state): Rename from remote_notif_state_xfree.
6708
6709 2019-04-19  Tom Tromey  <tom@tromey.com>
6710
6711         * symfile.c (reread_symbols): Update.
6712         * objfiles.c (objfile_register_static_link)
6713         (objfile_lookup_static_link): Update
6714         (~objfile) Don't delete static_links.
6715         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6716
6717 2019-04-19  Tom Tromey  <tom@tromey.com>
6718
6719         * type-stack.h (struct type_stack) <insert>: Constify string.
6720         * type-stack.c (type_stack::insert): Constify string.
6721         * gdbtypes.h (lookup_template_type): Update.
6722         (address_space_name_to_int): Update.
6723         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6724         const.
6725         (lookup_template_type): Make name const.
6726         * c-exp.y: Update rules.
6727         (lex_one_token, classify_name, classify_inner_name)
6728         (c_print_token): Update.
6729         * p-exp.y: Update rules.
6730         (yylex): Update.
6731         * f-exp.y: Update rules.
6732         (yylex): Update.
6733         * d-exp.y: Update rules.
6734         (lex_one_token, classify_name, classify_inner_name): Update.
6735         * parse.c (write_dollar_variable, copy_name): Return std::string.
6736         * parser-defs.h (copy_name): Change return type.
6737         * m2-exp.y: Update rules.
6738         (yylex): Update.
6739         * go-exp.y (lex_one_token): Update.
6740         Update rules.
6741         (classify_unsafe_function, classify_packaged_name)
6742         (classify_name, yylex): Update.
6743
6744 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6745
6746         * configure.ac: add --enable-source-highlight switch.
6747         * configure: Regenerate.
6748         * top.c (print_gdb_version): plumb --enable-source-highlight
6749         status to "show configuration".
6750
6751 2019-04-19  Tom Tromey  <tromey@adacore.com>
6752
6753         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6754         Check ADA_TYPE_P.
6755         (empty_record, ada_template_to_fixed_record_type_1)
6756         (template_to_static_fixed_type)
6757         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6758         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6759         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6760         macros.
6761
6762 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6763
6764         PR symtab/24423:
6765         * source.c (print_source_lines_base): Advance "iter" when a
6766         control character is seen.
6767
6768 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6769
6770         * inferior.h (struct infcall_suspend_state_deleter):
6771         Catch exception in destructor to avoid crash.
6772
6773 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6774
6775         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6776         close to the add_com "shell".
6777
6778 2019-04-18  Tom Tromey  <tromey@adacore.com>
6779
6780         * process-stratum-target.h (class process_stratum_target)
6781         <stratum>: Add "final".
6782
6783 2019-04-17  Tom Tromey  <tromey@adacore.com>
6784
6785         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6786         against nullptr before use.
6787
6788 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6789
6790         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6791
6792 2019-04-17  Jim Wilson  <jimw@sifive.com>
6793             Andrew Burgess  <andrew.burgess@embecosm.com>
6794
6795         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6796         code read might fail, assume 4-byte breakpoint in that case.
6797
6798 2019-04-15  Leszek Swirski  <leszeks@google.com>
6799
6800         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6801         rather than a hand-rolled POD check when checking for forced MEMORY
6802         classification.
6803
6804 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6805
6806         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6807         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6808         function.
6809         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6810         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6811         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6812         declaration.
6813
6814 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6815
6816         * aarch64-linux-nat.c
6817         (aarch64_linux_nat_target::thread_architecture): Add override.
6818         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6819         each VQ.
6820
6821 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6822
6823         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6824
6825 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6826
6827         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6828         target types of size 96-bits, add some additional comments, and
6829         check that the builtin type we found was the correct size.
6830
6831 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6832
6833         * utils.c (prompt_for_continue): Don't restore the styling at the
6834         end, as applied_style has the wrong value.  This fixes styling in
6835         long lists of file names that are interrupted by the "Continue?"
6836         prompt.
6837
6838 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6839
6840         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6841         * c-lang.c (c_language_defn): Likewise.
6842         (cplus_language_defn): Likewise.
6843         (asm_language_defn): Likewise.
6844         (minimal_language_defn): Likewise.
6845         * d-lang.c (d_language_defn): Likewise.
6846         * f-lang.c (f_language_defn): Likewise.
6847         * go-lang.c (go_language_defn): Likewise.
6848         * language.c (unknown_language_defn): Likewise.
6849         (auto_language_defn): Likewise.
6850         * language.h (struct language_defn): Remove la_magic field.
6851         (LANG_MAGIC): Delete.
6852         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6853         * objc-lang.c (objc_language_defn): Likewise.
6854         * opencl-lang.c (opencl_language_defn): Likewise.
6855         * p-lang.c (pascal_language_defn): Likewise.
6856         * rust-lang.c (rust_language_defn): Likewise.
6857
6858 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6859
6860         * riscv-tdep.c (riscv_type_align): New function.
6861         (riscv_type_alignment): Delete.
6862         (riscv_arg_location): Use 'type_align'.
6863         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6864
6865 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6866
6867         * gdbtypes.c (type_align): A struct with no non-static fields also
6868         has alignment of 1.
6869
6870 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6871
6872         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6873         component to 0.
6874         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6875         member.
6876         (riscv_struct_info::analyse): New implementation using new
6877         analyse_inner member function.
6878         (riscv_struct_info::field_offset): New member function.
6879         (riscv_struct_info::m_offsets): New member variable.
6880         (riscv_struct_info::analyse_inner): New private member function,
6881         takes the old implementation of riscv_struct_info::analyse but
6882         extended to track field offsets.
6883         (riscv_call_arg_struct): Update the struct folding special cases
6884         to handle cases where empty C++ structs, which are non-zero
6885         length, are found.
6886         (riscv_arg_location): Initialise the length of each location, a
6887         non-zero length now indicates the location is in use.
6888         (riscv_push_dummy_call): Allow for the first location having a
6889         non-zero offset when setting up arguments.
6890         (riscv_return_value): Likewise, but for return values.
6891
6892 2019-04-11  Tom Tromey  <tromey@adacore.com>
6893
6894         * utils.c (internal_vproblem): Make "msg" const.
6895
6896 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6897
6898         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6899         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6900         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6901         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6902
6903 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6904
6905         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6906         function.
6907         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6908         of amd64_collect_native_gregset.
6909         (amd64_linux_nat_target::store_registers): Likewise.
6910
6911 2019-04-10  Tom Tromey  <tom@tromey.com>
6912
6913         * symtab.c (lookup_global_symbol_from_objfile)
6914         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6915         * objfiles.h (class separate_debug_iterator): New.
6916         (class separate_debug_range): New.
6917         (struct objfile) <separate_debug_objfiles>: New method.
6918         (objfile_separate_debug_iterate): Don't declare.
6919         * objfiles.c (separate_debug_iterator::operator++): Rename from
6920         objfile_separate_debug_iterate.
6921         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6922         iterator.
6923         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6924         iterator.
6925
6926 2019-04-10  Tom Tromey  <tom@tromey.com>
6927
6928         * symfile.c (reread_symbols): Remove old comment.
6929         * objfiles.c (free_all_objfiles): Fix a typo.
6930
6931 2019-04-10  Tom Tromey  <tom@tromey.com>
6932
6933         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6934         * minsyms.c (lookup_minimal_symbol): Use foreach.
6935         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6936         (lookup_minimal_symbol_solib_trampoline): Likewise.
6937         * symfile.c (reread_symbols): Use foreach.
6938
6939 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6940             Tom Tromey  <tromey@adacore.com>
6941
6942         PR rust/24414:
6943         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6944         (rust_lex_int_test): Change "value" to be LONGEST.
6945         (rust_lex_tests): Add test for long integer literal.
6946
6947 2019-04-09  Tom Tromey  <tromey@adacore.com>
6948
6949         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6950         to bool.
6951         (extended_remote_target::attach): Update.
6952         (remote_target::remote_notice_new_inferior): Update.
6953         (remote_target::add_current_inferior_and_thread): Update.
6954         * inferior.c (exit_inferior_1): Use "false".
6955         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6956
6957 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6958
6959         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6960         the "start" command.
6961
6962 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6963
6964         * python/py-inferior.c (infpy_thread_from_thread_handle):
6965         Adjust comments to reflect renaming of thread_from_thread_handle
6966         to thread_from_handle.  Adjust keywords.  Fix type error message.
6967         (inferior_object_methods): Add thread_from_handle.  Retain
6968         thread_from_thread_handle, but mark it as deprecated.
6969
6970 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6971
6972         * gdbthread.h (find_thread_by_handle): Revise declaration.
6973         * thread.c (find_thread_by_handle): Likewise.  Adjust
6974         implementation too.
6975         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6976         support for buffer objects as handles.
6977
6978 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6979
6980         * python/py-infthread.c (thpy_thread_handle): New function.
6981         (thread_object_methods): Register thpy_thread_handle.
6982
6983 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6984
6985         * gdbthread.h (thread_to_thread_handle): Declare.
6986         * thread.c (gdbtypes.h): Include.
6987         (thread_to_thread_handle): New function.
6988
6989         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6990         (target_thread_info_to_thread_handle): Declare.
6991         * target.c (target_thread_info_to_thread_handle): New function.
6992         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6993         * target-delegates.c: Regenerate.
6994
6995         * linux-thread-db.c (class thread_db_target): Add method
6996         thread_info_to_thread_handle.
6997         (thread_db_target::thread_info_to_thread_handle): Define.
6998         * remote.c (class remote_target): Add new method
6999         thread_info_to_thread_handle.
7000         (remote_target::thread_info_to_thread_handle): Define.
7001
7002 2019-04-08  Pedro Alves  <palves@redhat.com>
7003
7004         * common/common-exceptions.c (throw_exception): Don't create
7005         named object to throw; throw directly.
7006         (throw_it): Likewise.  Don't initialize gdb_exception::message
7007         here, with new; pass FMT and AP to the ctor instead.
7008         * common/common-exceptions.h: Include <string>.
7009         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7010         const char *, va_list)): New ctor.  Use std::make_shared.
7011         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7012         errors)): Delete.
7013         (gdb_exception_error::gdb_exception_error(enum errors, const char
7014         *, va_list)): New.
7015         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7016         Add assertion.
7017         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7018         errors)): Delete.
7019         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7020         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7021         Add assertion.
7022
7023 2019-04-08  Tom Tromey  <tom@tromey.com>
7024
7025         * valops.c (value_rtti_indirect_type): Replace throw_exception
7026         with throw.
7027         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7028         with throw.
7029         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7030         throw.
7031         * target.c (target_translate_tls_address): Replace throw_exception
7032         with throw.
7033         * stack.c (frame_apply_command_count): Replace throw_exception
7034         with throw.
7035         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7036         throw.
7037         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7038         with throw.
7039         * rs6000-tdep.c (rs6000_frame_cache)
7040         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7041         * remote.c: Replace throw_exception with throw.
7042         * record-full.c (record_full_message, record_full_wait_1)
7043         (record_full_restore): Replace throw_exception with throw.
7044         * record-btrace.c:
7045         (get_thread_current_frame_id, record_btrace_start_replaying)
7046         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7047         (cmd_record_btrace_start): Replace throw_exception with throw.
7048         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7049         throw.
7050         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7051         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7052         * linespec.c:
7053         (find_linespec_symbols): Replace throw_exception with throw.
7054         * infrun.c (displaced_step_prepare, resume): Replace
7055         throw_exception with throw.
7056         * infcmd.c (post_create_inferior): Replace throw_exception with
7057         throw.
7058         * inf-loop.c (inferior_event_handler): Replace throw_exception
7059         with throw.
7060         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7061         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7062         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7063         (get_prev_frame_always, get_frame_pc_if_available)
7064         (get_frame_address_in_block_if_available, get_frame_language):
7065         Replace throw_exception with throw.
7066         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7067         throw_exception with throw.
7068         * eval.c (fetch_subexp_value, evaluate_var_value)
7069         (evaluate_funcall, evaluate_subexp_standard): Replace
7070         throw_exception with throw.
7071         * dwarf2loc.c (call_site_find_chain)
7072         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7073         Replace throw_exception with throw.
7074         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7075         with throw.
7076         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7077         throw.
7078         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7079         * completer.c (complete_line_internal): Replace throw_exception
7080         with throw.
7081         * compile/compile-object-run.c (compile_object_run): Replace
7082         throw_exception with throw.
7083         * cli/cli-script.c (process_next_line): Replace throw_exception
7084         with throw.
7085         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7086         (btrace_enable, btrace_maint_update_pt_packets): Replace
7087         throw_exception with throw.
7088         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7089         throw_exception with throw.
7090         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7091         throw_exception with throw.
7092         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7093         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7094         * aarch64-tdep.c (aarch64_make_prologue_cache)
7095         (aarch64_make_stub_cache): Replace throw_exception with throw.
7096
7097 2019-04-08  Tom Tromey  <tom@tromey.com>
7098
7099         * common/common-exceptions.c (throw_exception): Rename from
7100         throw_exception_cxx.  Remove old copy.  Make argument const.
7101         (throw_it): Create and throw exception objects directly.
7102         * common/common-exceptions.h (throw_exception): Make argument
7103         const.
7104         (struct gdb_exception_error): Add constructor.
7105         (struct gdb_exception_quit): Add constructor.
7106
7107 2019-04-08  Tom Tromey  <tom@tromey.com>
7108
7109         * common/common-exceptions.h (exception_rethrow): Don't declare.
7110         (TRY_SJLJ): Update comment.
7111         (TRY, CATCH, END_CATCH): Remove.
7112         * common/common-exceptions.c (exception_rethrow): Remove.
7113
7114 2019-04-08  Tom Tromey  <tom@tromey.com>
7115
7116         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7117         Remove.
7118         (gdb_exception_error): Rename from
7119         gdb_exception_RETURN_MASK_ERROR.
7120         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7121         (gdb_quit_bad_alloc): Update.
7122         * aarch64-tdep.c: Update.
7123         * ada-lang.c: Update.
7124         * ada-typeprint.c: Update.
7125         * ada-valprint.c: Update.
7126         * amd64-tdep.c: Update.
7127         * arch-utils.c: Update.
7128         * break-catch-throw.c: Update.
7129         * breakpoint.c: Update.
7130         * btrace.c: Update.
7131         * c-varobj.c: Update.
7132         * cli/cli-cmds.c: Update.
7133         * cli/cli-interp.c: Update.
7134         * cli/cli-script.c: Update.
7135         * common/common-exceptions.c: Update.
7136         * common/new-op.c: Update.
7137         * common/selftest.c: Update.
7138         * compile/compile-c-symbols.c: Update.
7139         * compile/compile-cplus-symbols.c: Update.
7140         * compile/compile-object-load.c: Update.
7141         * compile/compile-object-run.c: Update.
7142         * completer.c: Update.
7143         * corelow.c: Update.
7144         * cp-abi.c: Update.
7145         * cp-support.c: Update.
7146         * cp-valprint.c: Update.
7147         * darwin-nat.c: Update.
7148         * disasm-selftests.c: Update.
7149         * dtrace-probe.c: Update.
7150         * dwarf-index-cache.c: Update.
7151         * dwarf-index-write.c: Update.
7152         * dwarf2-frame-tailcall.c: Update.
7153         * dwarf2-frame.c: Update.
7154         * dwarf2loc.c: Update.
7155         * dwarf2read.c: Update.
7156         * eval.c: Update.
7157         * event-loop.c: Update.
7158         * event-top.c: Update.
7159         * exec.c: Update.
7160         * f-valprint.c: Update.
7161         * fbsd-tdep.c: Update.
7162         * frame-unwind.c: Update.
7163         * frame.c: Update.
7164         * gdbtypes.c: Update.
7165         * gnu-v3-abi.c: Update.
7166         * guile/guile-internal.h: Update.
7167         * guile/scm-block.c: Update.
7168         * guile/scm-breakpoint.c: Update.
7169         * guile/scm-cmd.c: Update.
7170         * guile/scm-disasm.c: Update.
7171         * guile/scm-frame.c: Update.
7172         * guile/scm-lazy-string.c: Update.
7173         * guile/scm-math.c: Update.
7174         * guile/scm-param.c: Update.
7175         * guile/scm-ports.c: Update.
7176         * guile/scm-pretty-print.c: Update.
7177         * guile/scm-symbol.c: Update.
7178         * guile/scm-symtab.c: Update.
7179         * guile/scm-type.c: Update.
7180         * guile/scm-value.c: Update.
7181         * i386-linux-tdep.c: Update.
7182         * i386-tdep.c: Update.
7183         * inf-loop.c: Update.
7184         * infcall.c: Update.
7185         * infcmd.c: Update.
7186         * infrun.c: Update.
7187         * jit.c: Update.
7188         * language.c: Update.
7189         * linespec.c: Update.
7190         * linux-fork.c: Update.
7191         * linux-nat.c: Update.
7192         * linux-tdep.c: Update.
7193         * linux-thread-db.c: Update.
7194         * main.c: Update.
7195         * mi/mi-cmd-break.c: Update.
7196         * mi/mi-cmd-stack.c: Update.
7197         * mi/mi-interp.c: Update.
7198         * mi/mi-main.c: Update.
7199         * objc-lang.c: Update.
7200         * p-valprint.c: Update.
7201         * parse.c: Update.
7202         * ppc-linux-tdep.c: Update.
7203         * printcmd.c: Update.
7204         * python/py-arch.c: Update.
7205         * python/py-breakpoint.c: Update.
7206         * python/py-cmd.c: Update.
7207         * python/py-finishbreakpoint.c: Update.
7208         * python/py-frame.c: Update.
7209         * python/py-framefilter.c: Update.
7210         * python/py-gdb-readline.c: Update.
7211         * python/py-inferior.c: Update.
7212         * python/py-infthread.c: Update.
7213         * python/py-lazy-string.c: Update.
7214         * python/py-linetable.c: Update.
7215         * python/py-objfile.c: Update.
7216         * python/py-param.c: Update.
7217         * python/py-prettyprint.c: Update.
7218         * python/py-progspace.c: Update.
7219         * python/py-record-btrace.c: Update.
7220         * python/py-record.c: Update.
7221         * python/py-symbol.c: Update.
7222         * python/py-type.c: Update.
7223         * python/py-unwind.c: Update.
7224         * python/py-utils.c: Update.
7225         * python/py-value.c: Update.
7226         * python/python.c: Update.
7227         * record-btrace.c: Update.
7228         * record-full.c: Update.
7229         * remote-fileio.c: Update.
7230         * remote.c: Update.
7231         * riscv-tdep.c: Update.
7232         * rs6000-aix-tdep.c: Update.
7233         * rs6000-tdep.c: Update.
7234         * rust-exp.y: Update.
7235         * rust-lang.c: Update.
7236         * s390-tdep.c: Update.
7237         * selftest-arch.c: Update.
7238         * solib-dsbt.c: Update.
7239         * solib-frv.c: Update.
7240         * solib-spu.c: Update.
7241         * solib-svr4.c: Update.
7242         * solib.c: Update.
7243         * sparc64-linux-tdep.c: Update.
7244         * stack.c: Update.
7245         * symfile-mem.c: Update.
7246         * symmisc.c: Update.
7247         * target.c: Update.
7248         * thread.c: Update.
7249         * top.c: Update.
7250         * tracefile-tfile.c: Update.
7251         * tui/tui.c: Update.
7252         * typeprint.c: Update.
7253         * unittests/cli-utils-selftests.c: Update.
7254         * unittests/parse-connection-spec-selftests.c: Update.
7255         * valops.c: Update.
7256         * valprint.c: Update.
7257         * value.c: Update.
7258         * varobj.c: Update.
7259         * windows-nat.c: Update.
7260         * x86-linux-nat.c: Update.
7261         * xml-support.c: Update.
7262
7263 2019-04-08  Tom Tromey  <tom@tromey.com>
7264
7265         * xml-support.c: Use C++ exception handling.
7266         * x86-linux-nat.c: Use C++ exception handling.
7267         * windows-nat.c: Use C++ exception handling.
7268         * varobj.c: Use C++ exception handling.
7269         * value.c: Use C++ exception handling.
7270         * valprint.c: Use C++ exception handling.
7271         * valops.c: Use C++ exception handling.
7272         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7273         handling.
7274         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7275         * typeprint.c: Use C++ exception handling.
7276         * tui/tui.c: Use C++ exception handling.
7277         * tracefile-tfile.c: Use C++ exception handling.
7278         * top.c: Use C++ exception handling.
7279         * thread.c: Use C++ exception handling.
7280         * target.c: Use C++ exception handling.
7281         * symmisc.c: Use C++ exception handling.
7282         * symfile-mem.c: Use C++ exception handling.
7283         * stack.c: Use C++ exception handling.
7284         * sparc64-linux-tdep.c: Use C++ exception handling.
7285         * solib.c: Use C++ exception handling.
7286         * solib-svr4.c: Use C++ exception handling.
7287         * solib-spu.c: Use C++ exception handling.
7288         * solib-frv.c: Use C++ exception handling.
7289         * solib-dsbt.c: Use C++ exception handling.
7290         * selftest-arch.c: Use C++ exception handling.
7291         * s390-tdep.c: Use C++ exception handling.
7292         * rust-lang.c: Use C++ exception handling.
7293         * rust-exp.y: Use C++ exception handling.
7294         * rs6000-tdep.c: Use C++ exception handling.
7295         * rs6000-aix-tdep.c: Use C++ exception handling.
7296         * riscv-tdep.c: Use C++ exception handling.
7297         * remote.c: Use C++ exception handling.
7298         * remote-fileio.c: Use C++ exception handling.
7299         * record-full.c: Use C++ exception handling.
7300         * record-btrace.c: Use C++ exception handling.
7301         * python/python.c: Use C++ exception handling.
7302         * python/py-value.c: Use C++ exception handling.
7303         * python/py-utils.c: Use C++ exception handling.
7304         * python/py-unwind.c: Use C++ exception handling.
7305         * python/py-type.c: Use C++ exception handling.
7306         * python/py-symbol.c: Use C++ exception handling.
7307         * python/py-record.c: Use C++ exception handling.
7308         * python/py-record-btrace.c: Use C++ exception handling.
7309         * python/py-progspace.c: Use C++ exception handling.
7310         * python/py-prettyprint.c: Use C++ exception handling.
7311         * python/py-param.c: Use C++ exception handling.
7312         * python/py-objfile.c: Use C++ exception handling.
7313         * python/py-linetable.c: Use C++ exception handling.
7314         * python/py-lazy-string.c: Use C++ exception handling.
7315         * python/py-infthread.c: Use C++ exception handling.
7316         * python/py-inferior.c: Use C++ exception handling.
7317         * python/py-gdb-readline.c: Use C++ exception handling.
7318         * python/py-framefilter.c: Use C++ exception handling.
7319         * python/py-frame.c: Use C++ exception handling.
7320         * python/py-finishbreakpoint.c: Use C++ exception handling.
7321         * python/py-cmd.c: Use C++ exception handling.
7322         * python/py-breakpoint.c: Use C++ exception handling.
7323         * python/py-arch.c: Use C++ exception handling.
7324         * printcmd.c: Use C++ exception handling.
7325         * ppc-linux-tdep.c: Use C++ exception handling.
7326         * parse.c: Use C++ exception handling.
7327         * p-valprint.c: Use C++ exception handling.
7328         * objc-lang.c: Use C++ exception handling.
7329         * mi/mi-main.c: Use C++ exception handling.
7330         * mi/mi-interp.c: Use C++ exception handling.
7331         * mi/mi-cmd-stack.c: Use C++ exception handling.
7332         * mi/mi-cmd-break.c: Use C++ exception handling.
7333         * main.c: Use C++ exception handling.
7334         * linux-thread-db.c: Use C++ exception handling.
7335         * linux-tdep.c: Use C++ exception handling.
7336         * linux-nat.c: Use C++ exception handling.
7337         * linux-fork.c: Use C++ exception handling.
7338         * linespec.c: Use C++ exception handling.
7339         * language.c: Use C++ exception handling.
7340         * jit.c: Use C++ exception handling.
7341         * infrun.c: Use C++ exception handling.
7342         * infcmd.c: Use C++ exception handling.
7343         * infcall.c: Use C++ exception handling.
7344         * inf-loop.c: Use C++ exception handling.
7345         * i386-tdep.c: Use C++ exception handling.
7346         * i386-linux-tdep.c: Use C++ exception handling.
7347         * guile/scm-value.c: Use C++ exception handling.
7348         * guile/scm-type.c: Use C++ exception handling.
7349         * guile/scm-symtab.c: Use C++ exception handling.
7350         * guile/scm-symbol.c: Use C++ exception handling.
7351         * guile/scm-pretty-print.c: Use C++ exception handling.
7352         * guile/scm-ports.c: Use C++ exception handling.
7353         * guile/scm-param.c: Use C++ exception handling.
7354         * guile/scm-math.c: Use C++ exception handling.
7355         * guile/scm-lazy-string.c: Use C++ exception handling.
7356         * guile/scm-frame.c: Use C++ exception handling.
7357         * guile/scm-disasm.c: Use C++ exception handling.
7358         * guile/scm-cmd.c: Use C++ exception handling.
7359         * guile/scm-breakpoint.c: Use C++ exception handling.
7360         * guile/scm-block.c: Use C++ exception handling.
7361         * guile/guile-internal.h: Use C++ exception handling.
7362         * gnu-v3-abi.c: Use C++ exception handling.
7363         * gdbtypes.c: Use C++ exception handling.
7364         * frame.c: Use C++ exception handling.
7365         * frame-unwind.c: Use C++ exception handling.
7366         * fbsd-tdep.c: Use C++ exception handling.
7367         * f-valprint.c: Use C++ exception handling.
7368         * exec.c: Use C++ exception handling.
7369         * event-top.c: Use C++ exception handling.
7370         * event-loop.c: Use C++ exception handling.
7371         * eval.c: Use C++ exception handling.
7372         * dwarf2read.c: Use C++ exception handling.
7373         * dwarf2loc.c: Use C++ exception handling.
7374         * dwarf2-frame.c: Use C++ exception handling.
7375         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7376         * dwarf-index-write.c: Use C++ exception handling.
7377         * dwarf-index-cache.c: Use C++ exception handling.
7378         * dtrace-probe.c: Use C++ exception handling.
7379         * disasm-selftests.c: Use C++ exception handling.
7380         * darwin-nat.c: Use C++ exception handling.
7381         * cp-valprint.c: Use C++ exception handling.
7382         * cp-support.c: Use C++ exception handling.
7383         * cp-abi.c: Use C++ exception handling.
7384         * corelow.c: Use C++ exception handling.
7385         * completer.c: Use C++ exception handling.
7386         * compile/compile-object-run.c: Use C++ exception handling.
7387         * compile/compile-object-load.c: Use C++ exception handling.
7388         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7389         * compile/compile-c-symbols.c: Use C++ exception handling.
7390         * common/selftest.c: Use C++ exception handling.
7391         * common/new-op.c: Use C++ exception handling.
7392         * cli/cli-script.c: Use C++ exception handling.
7393         * cli/cli-interp.c: Use C++ exception handling.
7394         * cli/cli-cmds.c: Use C++ exception handling.
7395         * c-varobj.c: Use C++ exception handling.
7396         * btrace.c: Use C++ exception handling.
7397         * breakpoint.c: Use C++ exception handling.
7398         * break-catch-throw.c: Use C++ exception handling.
7399         * arch-utils.c: Use C++ exception handling.
7400         * amd64-tdep.c: Use C++ exception handling.
7401         * ada-valprint.c: Use C++ exception handling.
7402         * ada-typeprint.c: Use C++ exception handling.
7403         * ada-lang.c: Use C++ exception handling.
7404         * aarch64-tdep.c: Use C++ exception handling.
7405
7406 2019-04-08  Tom Tromey  <tom@tromey.com>
7407
7408         * xml-support.c (gdb_xml_parser::parse): Update.
7409         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7410         * value.c (show_convenience): Update.
7411         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7412         (test_parse_flags_qcs): Update.
7413         * thread.c (thr_try_catch_cmd): Update.
7414         * target.c (target_translate_tls_address): Update.
7415         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7416         (info_frame_command_core, frame_apply_command_count): Update.
7417         * rust-exp.y (rust_lex_exception_test): Update.
7418         * riscv-tdep.c (riscv_print_one_register_info): Update.
7419         * remote.c (remote_target::enable_btrace): Update.
7420         * record-btrace.c (record_btrace_enable_warn): Update.
7421         * python/py-utils.c (gdbpy_convert_exception): Update.
7422         * printcmd.c (do_one_display, print_variable_and_value): Update.
7423         * mi/mi-main.c (mi_print_exception): Update.
7424         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7425         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7426         * linux-nat.c (linux_nat_target::attach): Update.
7427         * linux-fork.c (class scoped_switch_fork_info): Update.
7428         * infrun.c (displaced_step_prepare): Update.
7429         * infcall.c (call_function_by_hand_dummy): Update.
7430         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7431         * gnu-v3-abi.c (print_one_vtable): Update.
7432         * frame.c (get_prev_frame_always): Update.
7433         * f-valprint.c (info_common_command_for_block): Update.
7434         * exec.c (try_open_exec_file): Update.
7435         * exceptions.c (print_exception, exception_print)
7436         (exception_fprintf, exception_print_same): Update.
7437         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7438         * dwarf-index-cache.c (index_cache::store)
7439         (index_cache::lookup_gdb_index): Update.
7440         * darwin-nat.c (maybe_cache_shell): Update.
7441         * cp-valprint.c (cp_print_value_fields): Update.
7442         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7443         (gcc_cplus_symbol_address): Update.
7444         * compile/compile-c-symbols.c (gcc_convert_symbol)
7445         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7446         * common/selftest.c: Update.
7447         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7448         a std::string.
7449         (exception_try_scope_entry, exception_try_scope_exit): Don't
7450         declare.
7451         (struct exception_try_scope): Remove.
7452         (TRY): Don't use exception_try_scope.
7453         (struct gdb_exception): Add constructor, operator=.
7454         <what>: New method.
7455         (struct gdb_exception_RETURN_MASK_ALL)
7456         (struct gdb_exception_RETURN_MASK_ERROR)
7457         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7458         (struct gdb_quit_bad_alloc): Update.
7459         * common/common-exceptions.c (exception_none): Change
7460         initializer.
7461         (struct catcher) <state, exception>: Initialize inline.
7462         <prev>: Remove member.
7463         (current_catcher): Remove.
7464         (catchers): New global.
7465         (exceptions_state_mc_init): Simplify.
7466         (catcher_pop): Remove.
7467         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7468         (try_scope_depth, exception_try_scope_entry)
7469         (exception_try_scope_exit): Remove.
7470         (throw_exception_sjlj): Update.
7471         (exception_messages, exception_messages_size): Remove.
7472         (throw_it): Simplify.
7473         (gdb_exception_sliced_copy): Remove.
7474         (throw_exception_cxx): Update.
7475         * cli/cli-script.c (script_from_file): Update.
7476         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7477         Update.
7478         * ada-valprint.c (ada_val_print): Update.
7479         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7480         (create_excep_cond_exprs): Update.
7481
7482 2019-04-08  Tom Tromey  <tom@tromey.com>
7483
7484         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7485         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7486         (TRY, CATCH, END_CATCH): Remove some definitions.
7487         * common/common-exceptions.c: Don't use GDB_XCPT.
7488         (catcher_list_size): Remove.
7489         (throw_exception, throw_it): Simplify.
7490
7491 2019-04-05  Tom Tromey  <tom@tromey.com>
7492
7493         Revert the header-sorting patch.
7494         * ft32-tdep.c: Revert.
7495         * frv-tdep.c: Revert.
7496         * frv-linux-tdep.c: Revert.
7497         * frame.c: Revert.
7498         * frame-unwind.c: Revert.
7499         * frame-base.c: Revert.
7500         * fork-child.c: Revert.
7501         * findvar.c: Revert.
7502         * findcmd.c: Revert.
7503         * filesystem.c: Revert.
7504         * filename-seen-cache.h: Revert.
7505         * filename-seen-cache.c: Revert.
7506         * fbsd-tdep.c: Revert.
7507         * fbsd-nat.h: Revert.
7508         * fbsd-nat.c: Revert.
7509         * f-valprint.c: Revert.
7510         * f-typeprint.c: Revert.
7511         * f-lang.c: Revert.
7512         * extension.h: Revert.
7513         * extension.c: Revert.
7514         * extension-priv.h: Revert.
7515         * expprint.c: Revert.
7516         * exec.h: Revert.
7517         * exec.c: Revert.
7518         * exceptions.c: Revert.
7519         * event-top.c: Revert.
7520         * event-loop.c: Revert.
7521         * eval.c: Revert.
7522         * elfread.c: Revert.
7523         * dwarf2read.h: Revert.
7524         * dwarf2read.c: Revert.
7525         * dwarf2loc.c: Revert.
7526         * dwarf2expr.h: Revert.
7527         * dwarf2expr.c: Revert.
7528         * dwarf2-frame.c: Revert.
7529         * dwarf2-frame-tailcall.c: Revert.
7530         * dwarf-index-write.h: Revert.
7531         * dwarf-index-write.c: Revert.
7532         * dwarf-index-common.c: Revert.
7533         * dwarf-index-cache.h: Revert.
7534         * dwarf-index-cache.c: Revert.
7535         * dummy-frame.c: Revert.
7536         * dtrace-probe.c: Revert.
7537         * disasm.h: Revert.
7538         * disasm.c: Revert.
7539         * disasm-selftests.c: Revert.
7540         * dictionary.c: Revert.
7541         * dicos-tdep.c: Revert.
7542         * demangle.c: Revert.
7543         * dcache.h: Revert.
7544         * dcache.c: Revert.
7545         * darwin-nat.h: Revert.
7546         * darwin-nat.c: Revert.
7547         * darwin-nat-info.c: Revert.
7548         * d-valprint.c: Revert.
7549         * d-namespace.c: Revert.
7550         * d-lang.c: Revert.
7551         * ctf.c: Revert.
7552         * csky-tdep.c: Revert.
7553         * csky-linux-tdep.c: Revert.
7554         * cris-tdep.c: Revert.
7555         * cris-linux-tdep.c: Revert.
7556         * cp-valprint.c: Revert.
7557         * cp-support.c: Revert.
7558         * cp-namespace.c: Revert.
7559         * cp-abi.c: Revert.
7560         * corelow.c: Revert.
7561         * corefile.c: Revert.
7562         * continuations.c: Revert.
7563         * completer.h: Revert.
7564         * completer.c: Revert.
7565         * complaints.c: Revert.
7566         * coffread.c: Revert.
7567         * coff-pe-read.c: Revert.
7568         * cli-out.h: Revert.
7569         * cli-out.c: Revert.
7570         * charset.c: Revert.
7571         * c-varobj.c: Revert.
7572         * c-valprint.c: Revert.
7573         * c-typeprint.c: Revert.
7574         * c-lang.c: Revert.
7575         * buildsym.c: Revert.
7576         * buildsym-legacy.c: Revert.
7577         * build-id.h: Revert.
7578         * build-id.c: Revert.
7579         * btrace.c: Revert.
7580         * bsd-uthread.c: Revert.
7581         * breakpoint.h: Revert.
7582         * breakpoint.c: Revert.
7583         * break-catch-throw.c: Revert.
7584         * break-catch-syscall.c: Revert.
7585         * break-catch-sig.c: Revert.
7586         * blockframe.c: Revert.
7587         * block.c: Revert.
7588         * bfin-tdep.c: Revert.
7589         * bfin-linux-tdep.c: Revert.
7590         * bfd-target.c: Revert.
7591         * bcache.c: Revert.
7592         * ax-general.c: Revert.
7593         * ax-gdb.h: Revert.
7594         * ax-gdb.c: Revert.
7595         * avr-tdep.c: Revert.
7596         * auxv.c: Revert.
7597         * auto-load.c: Revert.
7598         * arm-wince-tdep.c: Revert.
7599         * arm-tdep.c: Revert.
7600         * arm-symbian-tdep.c: Revert.
7601         * arm-pikeos-tdep.c: Revert.
7602         * arm-obsd-tdep.c: Revert.
7603         * arm-nbsd-tdep.c: Revert.
7604         * arm-nbsd-nat.c: Revert.
7605         * arm-linux-tdep.c: Revert.
7606         * arm-linux-nat.c: Revert.
7607         * arm-fbsd-tdep.c: Revert.
7608         * arm-fbsd-nat.c: Revert.
7609         * arm-bsd-tdep.c: Revert.
7610         * arch-utils.c: Revert.
7611         * arc-tdep.c: Revert.
7612         * arc-newlib-tdep.c: Revert.
7613         * annotate.h: Revert.
7614         * annotate.c: Revert.
7615         * amd64-windows-tdep.c: Revert.
7616         * amd64-windows-nat.c: Revert.
7617         * amd64-tdep.c: Revert.
7618         * amd64-sol2-tdep.c: Revert.
7619         * amd64-obsd-tdep.c: Revert.
7620         * amd64-obsd-nat.c: Revert.
7621         * amd64-nbsd-tdep.c: Revert.
7622         * amd64-nbsd-nat.c: Revert.
7623         * amd64-nat.c: Revert.
7624         * amd64-linux-tdep.c: Revert.
7625         * amd64-linux-nat.c: Revert.
7626         * amd64-fbsd-tdep.c: Revert.
7627         * amd64-fbsd-nat.c: Revert.
7628         * amd64-dicos-tdep.c: Revert.
7629         * amd64-darwin-tdep.c: Revert.
7630         * amd64-bsd-nat.c: Revert.
7631         * alpha-tdep.c: Revert.
7632         * alpha-obsd-tdep.c: Revert.
7633         * alpha-nbsd-tdep.c: Revert.
7634         * alpha-mdebug-tdep.c: Revert.
7635         * alpha-linux-tdep.c: Revert.
7636         * alpha-linux-nat.c: Revert.
7637         * alpha-bsd-tdep.c: Revert.
7638         * alpha-bsd-nat.c: Revert.
7639         * aix-thread.c: Revert.
7640         * agent.c: Revert.
7641         * addrmap.c: Revert.
7642         * ada-varobj.c: Revert.
7643         * ada-valprint.c: Revert.
7644         * ada-typeprint.c: Revert.
7645         * ada-tasks.c: Revert.
7646         * ada-lang.c: Revert.
7647         * aarch64-tdep.c: Revert.
7648         * aarch64-ravenscar-thread.c: Revert.
7649         * aarch64-newlib-tdep.c: Revert.
7650         * aarch64-linux-tdep.c: Revert.
7651         * aarch64-linux-nat.c: Revert.
7652         * aarch64-fbsd-tdep.c: Revert.
7653         * aarch64-fbsd-nat.c: Revert.
7654         * aarch32-linux-nat.c: Revert.
7655
7656 2019-04-05  Tom Tromey  <tom@tromey.com>
7657
7658         * ft32-tdep.c: Sort headers.
7659         * frv-tdep.c: Sort headers.
7660         * frv-linux-tdep.c: Sort headers.
7661         * frame.c: Sort headers.
7662         * frame-unwind.c: Sort headers.
7663         * frame-base.c: Sort headers.
7664         * fork-child.c: Sort headers.
7665         * findvar.c: Sort headers.
7666         * findcmd.c: Sort headers.
7667         * filesystem.c: Sort headers.
7668         * filename-seen-cache.h: Sort headers.
7669         * filename-seen-cache.c: Sort headers.
7670         * fbsd-tdep.c: Sort headers.
7671         * fbsd-nat.h: Sort headers.
7672         * fbsd-nat.c: Sort headers.
7673         * f-valprint.c: Sort headers.
7674         * f-typeprint.c: Sort headers.
7675         * f-lang.c: Sort headers.
7676         * extension.h: Sort headers.
7677         * extension.c: Sort headers.
7678         * extension-priv.h: Sort headers.
7679         * expprint.c: Sort headers.
7680         * exec.h: Sort headers.
7681         * exec.c: Sort headers.
7682         * exceptions.c: Sort headers.
7683         * event-top.c: Sort headers.
7684         * event-loop.c: Sort headers.
7685         * eval.c: Sort headers.
7686         * elfread.c: Sort headers.
7687         * dwarf2read.h: Sort headers.
7688         * dwarf2read.c: Sort headers.
7689         * dwarf2loc.c: Sort headers.
7690         * dwarf2expr.h: Sort headers.
7691         * dwarf2expr.c: Sort headers.
7692         * dwarf2-frame.c: Sort headers.
7693         * dwarf2-frame-tailcall.c: Sort headers.
7694         * dwarf-index-write.h: Sort headers.
7695         * dwarf-index-write.c: Sort headers.
7696         * dwarf-index-common.c: Sort headers.
7697         * dwarf-index-cache.h: Sort headers.
7698         * dwarf-index-cache.c: Sort headers.
7699         * dummy-frame.c: Sort headers.
7700         * dtrace-probe.c: Sort headers.
7701         * disasm.h: Sort headers.
7702         * disasm.c: Sort headers.
7703         * disasm-selftests.c: Sort headers.
7704         * dictionary.c: Sort headers.
7705         * dicos-tdep.c: Sort headers.
7706         * demangle.c: Sort headers.
7707         * dcache.h: Sort headers.
7708         * dcache.c: Sort headers.
7709         * darwin-nat.h: Sort headers.
7710         * darwin-nat.c: Sort headers.
7711         * darwin-nat-info.c: Sort headers.
7712         * d-valprint.c: Sort headers.
7713         * d-namespace.c: Sort headers.
7714         * d-lang.c: Sort headers.
7715         * ctf.c: Sort headers.
7716         * csky-tdep.c: Sort headers.
7717         * csky-linux-tdep.c: Sort headers.
7718         * cris-tdep.c: Sort headers.
7719         * cris-linux-tdep.c: Sort headers.
7720         * cp-valprint.c: Sort headers.
7721         * cp-support.c: Sort headers.
7722         * cp-namespace.c: Sort headers.
7723         * cp-abi.c: Sort headers.
7724         * corelow.c: Sort headers.
7725         * corefile.c: Sort headers.
7726         * continuations.c: Sort headers.
7727         * completer.h: Sort headers.
7728         * completer.c: Sort headers.
7729         * complaints.c: Sort headers.
7730         * coffread.c: Sort headers.
7731         * coff-pe-read.c: Sort headers.
7732         * cli-out.h: Sort headers.
7733         * cli-out.c: Sort headers.
7734         * charset.c: Sort headers.
7735         * c-varobj.c: Sort headers.
7736         * c-valprint.c: Sort headers.
7737         * c-typeprint.c: Sort headers.
7738         * c-lang.c: Sort headers.
7739         * buildsym.c: Sort headers.
7740         * buildsym-legacy.c: Sort headers.
7741         * build-id.h: Sort headers.
7742         * build-id.c: Sort headers.
7743         * btrace.c: Sort headers.
7744         * bsd-uthread.c: Sort headers.
7745         * breakpoint.h: Sort headers.
7746         * breakpoint.c: Sort headers.
7747         * break-catch-throw.c: Sort headers.
7748         * break-catch-syscall.c: Sort headers.
7749         * break-catch-sig.c: Sort headers.
7750         * blockframe.c: Sort headers.
7751         * block.c: Sort headers.
7752         * bfin-tdep.c: Sort headers.
7753         * bfin-linux-tdep.c: Sort headers.
7754         * bfd-target.c: Sort headers.
7755         * bcache.c: Sort headers.
7756         * ax-general.c: Sort headers.
7757         * ax-gdb.h: Sort headers.
7758         * ax-gdb.c: Sort headers.
7759         * avr-tdep.c: Sort headers.
7760         * auxv.c: Sort headers.
7761         * auto-load.c: Sort headers.
7762         * arm-wince-tdep.c: Sort headers.
7763         * arm-tdep.c: Sort headers.
7764         * arm-symbian-tdep.c: Sort headers.
7765         * arm-pikeos-tdep.c: Sort headers.
7766         * arm-obsd-tdep.c: Sort headers.
7767         * arm-nbsd-tdep.c: Sort headers.
7768         * arm-nbsd-nat.c: Sort headers.
7769         * arm-linux-tdep.c: Sort headers.
7770         * arm-linux-nat.c: Sort headers.
7771         * arm-fbsd-tdep.c: Sort headers.
7772         * arm-fbsd-nat.c: Sort headers.
7773         * arm-bsd-tdep.c: Sort headers.
7774         * arch-utils.c: Sort headers.
7775         * arc-tdep.c: Sort headers.
7776         * arc-newlib-tdep.c: Sort headers.
7777         * annotate.h: Sort headers.
7778         * annotate.c: Sort headers.
7779         * amd64-windows-tdep.c: Sort headers.
7780         * amd64-windows-nat.c: Sort headers.
7781         * amd64-tdep.c: Sort headers.
7782         * amd64-sol2-tdep.c: Sort headers.
7783         * amd64-obsd-tdep.c: Sort headers.
7784         * amd64-obsd-nat.c: Sort headers.
7785         * amd64-nbsd-tdep.c: Sort headers.
7786         * amd64-nbsd-nat.c: Sort headers.
7787         * amd64-nat.c: Sort headers.
7788         * amd64-linux-tdep.c: Sort headers.
7789         * amd64-linux-nat.c: Sort headers.
7790         * amd64-fbsd-tdep.c: Sort headers.
7791         * amd64-fbsd-nat.c: Sort headers.
7792         * amd64-dicos-tdep.c: Sort headers.
7793         * amd64-darwin-tdep.c: Sort headers.
7794         * amd64-bsd-nat.c: Sort headers.
7795         * alpha-tdep.c: Sort headers.
7796         * alpha-obsd-tdep.c: Sort headers.
7797         * alpha-nbsd-tdep.c: Sort headers.
7798         * alpha-mdebug-tdep.c: Sort headers.
7799         * alpha-linux-tdep.c: Sort headers.
7800         * alpha-linux-nat.c: Sort headers.
7801         * alpha-bsd-tdep.c: Sort headers.
7802         * alpha-bsd-nat.c: Sort headers.
7803         * aix-thread.c: Sort headers.
7804         * agent.c: Sort headers.
7805         * addrmap.c: Sort headers.
7806         * ada-varobj.c: Sort headers.
7807         * ada-valprint.c: Sort headers.
7808         * ada-typeprint.c: Sort headers.
7809         * ada-tasks.c: Sort headers.
7810         * ada-lang.c: Sort headers.
7811         * aarch64-tdep.c: Sort headers.
7812         * aarch64-ravenscar-thread.c: Sort headers.
7813         * aarch64-newlib-tdep.c: Sort headers.
7814         * aarch64-linux-tdep.c: Sort headers.
7815         * aarch64-linux-nat.c: Sort headers.
7816         * aarch64-fbsd-tdep.c: Sort headers.
7817         * aarch64-fbsd-nat.c: Sort headers.
7818         * aarch32-linux-nat.c: Sort headers.
7819
7820 2019-04-04  Tom Tromey  <tom@tromey.com>
7821
7822         * varobj.c (varobj_create): Update.
7823         * rust-exp.y (struct rust_parser) <update_innermost_block,
7824         lookup_symbol>: New methods.
7825         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7826         Rename.
7827         (rust_parser::rust_lookup_type)
7828         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7829         * printcmd.c (display_command, do_one_display): Update.
7830         * parser-defs.h (struct parser_state) <parser_state>: Add
7831         "tracker" parameter.
7832         (block_tracker): New member.
7833         (class innermost_block_tracker) <innermost_block_tracker>: Add
7834         "types" parameter.
7835         <reset>: Remove method.
7836         (innermost_block): Don't declare.
7837         (null_post_parser): Update.
7838         * parse.c (innermost_block): Remove global.
7839         (write_dollar_variable): Update.
7840         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7841         Remove "tracker_types" parameter.
7842         (parse_expression): Add "tracker" parameter.
7843         (parse_expression_for_completion): Update.
7844         (null_post_parser): Add "tracker" parameter.
7845         * p-exp.y: Update rules.
7846         * m2-exp.y: Update rules.
7847         * language.h (struct language_defn) <la_post_parser>: Add
7848         "tracker" parameter.
7849         * go-exp.y: Update rules.
7850         * f-exp.y: Update rules.
7851         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7852         parameter.
7853         * d-exp.y: Update rules.
7854         * c-exp.y: Update rules.
7855         * breakpoint.c (set_breakpoint_condition): Create an
7856         innermost_block_tracker.
7857         (watch_command_1): Likewise.
7858         * ada-lang.c (resolve): Add "tracker" parameter.
7859         (resolve_subexp): Likewise.
7860         * ada-exp.y (write_var_from_sym): Update.
7861
7862 2019-04-04  Tom Tromey  <tom@tromey.com>
7863
7864         * type-stack.h: New file.
7865         * type-stack.c: New file.
7866         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7867         type-stack.h.
7868         (insert_into_type_stack, insert_type, push_type, push_type_int)
7869         (insert_type_address_space, pop_type, pop_type_int)
7870         (pop_typelist, pop_type_stack, append_type_stack)
7871         (push_type_stack, get_type_stack, push_typelist)
7872         (follow_type_instance_flags, follow_types): Don't declare.
7873         * parse.c (type_stack): Remove global.
7874         (parse_exp_in_context): Update.
7875         (insert_into_type_stack, insert_type, push_type, push_type_int)
7876         (insert_type_address_space, pop_type, pop_type_int)
7877         (pop_typelist, pop_type_stack, append_type_stack)
7878         (push_type_stack, get_type_stack, push_typelist)
7879         (follow_type_instance_flags, follow_types): Remove (moved to
7880         type-stack.c).
7881         * f-exp.y (type_stack): New global.
7882         Update rules.
7883         (push_kind_type, f_parse): Update.
7884         * d-exp.y (type_stack): New global.
7885         Update rules.
7886         (d_parse): Update.
7887         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7888         Update rules.
7889         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7890         (HFILES_NO_SRCDIR): Add type-stack.h.
7891
7892 2019-04-04  Tom Tromey  <tom@tromey.com>
7893
7894         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7895         (rust_parser::convert_ast_to_expression, rust_parse)
7896         (rust_lex_test_completion, rust_lex_tests): Update.
7897         * parser-defs.h (struct expr_completion_state): New.
7898         (struct parser_state) <parser_state>: Add completion parameter.
7899         <mark_struct_expression, mark_completion_tag>: New methods.
7900         <parse_completion, m_completion_state>: New members.
7901         (prefixify_expression, null_post_parser): Update.
7902         (mark_struct_expression, mark_completion_tag): Don't declare.
7903         * parse.c (parse_completion, expout_last_struct)
7904         (expout_tag_completion_type, expout_completion_name): Remove
7905         globals.
7906         (parser_state::mark_struct_expression)
7907         (parser_state::mark_completion_tag): Now methods.
7908         (prefixify_expression): Add last_struct parameter.
7909         (prefixify_subexp): Likewise.
7910         (parse_exp_1): Update.
7911         (parse_exp_in_context): Add cstate parameter.  Update.
7912         (parse_expression_for_completion): Create an
7913         expr_completion_state.
7914         (null_post_parser): Add "completion" parameter.
7915         * p-exp.y: Update rules.
7916         (yylex): Update.
7917         * language.h (struct language_defn) <la_post_parser>: Add
7918         "completing" parameter.
7919         * go-exp.y: Update rules.
7920         (lex_one_token): Update.
7921         * expression.h (parse_completion): Don't declare.
7922         * d-exp.y: Update rules.
7923         (lex_one_token): Update rules.
7924         * c-exp.y: Update rules.
7925         (lex_one_token): Update.
7926         * ada-lang.c (resolve): Add "parse_completion" parameter.
7927         (resolve_subexp): Likewise.
7928         (ada_resolve_function): Likewise.
7929
7930 2019-04-04  Tom Tromey  <tom@tromey.com>
7931
7932         * parser-defs.h (struct parser_state) <start_arglist,
7933         end_arglist>: New methods.
7934         <arglist_len, m_funcall_chain>: New members.
7935         (arglist_len, start_arglist, end_arglist): Don't declare.
7936         * parse.c (arglist_len, funcall_chain): Remove global.
7937         (start_arglist, end_arglist): Remove functions.
7938         (parse_exp_in_context): Update.
7939         * p-exp.y: Update rules.
7940         * m2-exp.y: Update rules.
7941         * go-exp.y: Update rules.
7942         * f-exp.y: Update rules.
7943         * d-exp.y: Update rules.
7944         * c-exp.y: Update rules.
7945
7946 2019-04-04  Tom Tromey  <tom@tromey.com>
7947
7948         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7949         lex_operator, push_back>: New methods.
7950         Update all rules.
7951         (rust_parser::lex_hex, lex_escape): Rename and update.
7952         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7953         (rust_parser::lex_operator): Rename and update.
7954         (rust_parser::lex_number, rustyylex, rustyyerror)
7955         (rust_lex_test_init, rust_lex_test_sequence)
7956         (rust_lex_test_push_back, rust_lex_tests): Update.
7957         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7958         parameter.
7959         <lexptr, prev_lexptr>: New members.
7960         (lexptr, prev_lexptr): Don't declare.
7961         * parse.c (lexptr, prev_lexptr): Remove globals.
7962         (parse_exp_in_context): Update.
7963         * p-exp.y (yylex, yyerror): Update.
7964         * m2-exp.y (parse_number, yylex, yyerror): Update.
7965         * go-exp.y (lex_one_token, yyerror): Update.
7966         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7967         * d-exp.y (lex_one_token, yyerror): Update.
7968         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7969         (lex_one_token, yyerror): Update.
7970         * ada-lex.l (YY_INPUT): Update.
7971         (rewind_to_char): Update.
7972         * ada-exp.y (yyerror): Update.
7973
7974 2019-04-04  Tom Tromey  <tom@tromey.com>
7975
7976         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7977         * parser-defs.h (struct parser_state) <parser_state>: Add new
7978         parameter.
7979         <comma_terminates>: New member.
7980         (comma_terminates): Don't declare global.
7981         * parse.c (comma_terminates): Remove global.
7982         (parse_exp_in_context): Update.
7983         * p-exp.y (yylex): Update.
7984         * m2-exp.y (yylex): Update.
7985         * go-exp.y (lex_one_token): Update.
7986         * f-exp.y (yylex): Update.
7987         * d-exp.y (lex_one_token): Update.
7988         * c-exp.y (lex_one_token): Update.
7989         * ada-lex.l: Update.
7990
7991 2019-04-04  Tom Tromey  <tom@tromey.com>
7992
7993         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7994         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7995         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7996         * parser-defs.h (paren_depth): Don't declare.
7997         * parse.c (paren_depth): Remove global.
7998         (parse_exp_in_context): Update.
7999         * p-exp.y (paren_depth): New global.
8000         (pascal_parse): Initialize it.
8001         * m2-exp.y (paren_depth): New global.
8002         (m2_parse): Initialize it.
8003         * go-exp.y (paren_depth): New global.
8004         (go_parse): Initialize it.
8005         * f-exp.y (paren_depth): New global.
8006         (f_parse): Initialize it.
8007         * d-exp.y (paren_depth): New global.
8008         (d_parse): Initialize it.
8009         * c-exp.y (paren_depth): New global.
8010         (c_parse): Initialize it.
8011         * ada-lex.l (paren_depth): New global.
8012         (lexer_init): Initialize it.
8013
8014 2019-04-04  Tom Tromey  <tom@tromey.com>
8015
8016         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8017         (rust_parser::convert_ast_to_type)
8018         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8019         * parser-defs.h (struct parser_state) <parser_state>: Add
8020         parameters.  Initialize new members.
8021         <expression_context_block, expression_context_pc>: New members.
8022         * parse.c (expression_context_block, expression_context_pc):
8023         Remove globals.
8024         (parse_exp_in_context): Update.
8025         * p-exp.y: Update all rules.
8026         (yylex): Update.
8027         * m2-exp.y: Update all rules.
8028         (yylex): Update.
8029         * go-exp.y (yylex): Update.
8030         * f-exp.y (yylex): Update.
8031         * d-exp.y: Update all rules.
8032         (yylex): Update.
8033         * c-exp.y: Update all rules.
8034         (lex_one_token, classify_name, yylex, c_parse): Update.
8035         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8036
8037 2019-04-04  Tom Tromey  <tom@tromey.com>
8038
8039         * gdbarch.h, gdbarch.c: Rebuild.
8040         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8041         * stap-probe.h:
8042         (struct stap_parse_info): Replace "parser_state" with
8043         "expr_builder".
8044         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8045         (parser_state): New class.
8046         * parse.c (expr_builder): Rename.
8047         (expr_builder::release): Rename.
8048         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8049         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8050         (write_exp_elt_longcst, write_exp_elt_floatcst)
8051         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8052         (write_exp_string_vector, write_exp_bitstring)
8053         (write_exp_msymbol, mark_struct_expression)
8054         (write_dollar_variable)
8055         (insert_type_address_space, increase_expout_size): Replace
8056         "parser_state" with "expr_builder".
8057         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8058         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8059         "parser_state" with "expr_builder".
8060
8061 2019-04-04  Tom Tromey  <tom@tromey.com>
8062
8063         * rust-exp.y: Replace "parse_language" with method call.
8064         * p-exp.y:
8065         (yylex): Replace "parse_language" with method call.
8066         * m2-exp.y:
8067         (yylex): Replace "parse_language" with method call.
8068         * go-exp.y (classify_name): Replace "parse_language" with method
8069         call.
8070         * f-exp.y (yylex): Replace "parse_language" with method call.
8071         * d-exp.y (lex_one_token): Replace "parse_language" with method
8072         call.
8073         * c-exp.y:
8074         (lex_one_token, classify_name, yylex): Replace "parse_language"
8075         with method call.
8076         * ada-exp.y (find_primitive_type, type_char)
8077         (type_system_address): Replace "parse_language" with method call.
8078
8079 2019-04-04  Tom Tromey  <tom@tromey.com>
8080
8081         * rust-exp.y: Replace "parse_gdbarch" with method call.
8082         * parse.c (write_dollar_variable, insert_type_address_space):
8083         Replace "parse_gdbarch" with method call.
8084         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8085         call.
8086         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8087         call.
8088         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8089         "parse_gdbarch" with method call.
8090         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8091         with method call.
8092         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8093         "parse_gdbarch" with method call.
8094         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8095         "parse_gdbarch" with method call.
8096         * c-exp.y (parse_type, parse_number, classify_name): Replace
8097         "parse_gdbarch" with method call.
8098         * ada-lex.l: Replace "parse_gdbarch" with method call.
8099         * ada-exp.y (parse_type, find_primitive_type, type_char)
8100         (type_system_address): Replace "parse_gdbarch" with method call.
8101
8102 2019-04-04  Tom Tromey  <tom@tromey.com>
8103
8104         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8105         * stap-probe.c (stap_parse_argument): Update.
8106         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8107         initial_size parameter.
8108         * rust-exp.y (rust_lex_tests): Update.
8109         * parse.c (parser_state): Update.
8110         (parse_exp_in_context): Update.
8111         * parser-defs.h (struct parser_state) <parser_state>: Remove
8112         "initial_size" parameter.
8113
8114 2019-04-04  Tom Tromey  <tom@tromey.com>
8115
8116         * parser-defs.h (increase_expout_size): Don't declare.
8117         * parse.c (increase_expout_size): Now static.
8118
8119 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8120
8121         * gnu-nat.c (gnu_nat_target::wait): Fix
8122         target_waitstatus_to_string call.
8123
8124 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8125
8126         * eval.c (evaluate_subexp_standard): Handle internal functions
8127         during Fortran function call handling.
8128
8129 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8130
8131         * NEWS: Mention new internal functions.
8132         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8133         (read_base_type): Use dwarf2_init_complex_target_type.
8134         * value.c (creal_internal_fn): New function.
8135         (cimag_internal_fn): New function.
8136         (_initialize_values): Register new internal functions.
8137
8138 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8139
8140         * infrun.c (stop_all_threads): If debug_infrun, always
8141         trace the wait status after wait_one, using
8142         target_waitstatus_to_string and target_pid_to_str.
8143         (handle_inferior_event): Replace various trace of
8144         wait status kind by a single trace.
8145         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8146         wait status kind image by target_waitstatus_to_string.
8147         * target/waitstatus.c (target_waitstatus_to_string): Fix
8148         obsolete comment.
8149
8150 2019-04-01  Tom Tromey  <tromey@adacore.com>
8151
8152         PR symtab/23331:
8153         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8154
8155 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8156             Pedro Alves  <palves@redhat.com>
8157
8158         * top.c (quit_force): Call 'finalize_values'.
8159         * value.c (finalize_values): New function.
8160         * value.h (finalize_values): Declare.
8161
8162 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8163
8164         * NEWS: Announce $_gdb_major and $_gdb_minor.
8165
8166         * top.c (init_gdb_version_vars): New function.
8167         (gdb_init): Call init_gdb_version_vars.
8168
8169 2019-03-29  Tom Tromey  <tromey@adacore.com>
8170
8171         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8172         help text.  Remove dead code.
8173
8174 2019-03-29  Keith Seitz  <keiths@redhat.com>
8175
8176         From Siddhesh Poyarekar:
8177         * f-lang.h (f77_get_upperbound): Return LONGEST.
8178         (f77_get_lowerbound): Likewise.
8179         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8180         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8181         print them.
8182         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8183         plongest to format print it.
8184         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8185         (f77_get_upperbound): Likewise.
8186         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8187         LOWER_BOUND to LONGEST.
8188         (f77_create_arrayprint_offset_tbl): Likewise.
8189
8190 2019-03-29  Keith Seitz  <keiths@redhat.com>
8191
8192         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8193         %s/pulongest for TYPE_LENGTH instead of %d in format
8194         strings.
8195         * ada-typerint.c (ada_print_type): Likewise.
8196         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8197         * compile/compile-c-support.c (generate_register_struct): Likewise.
8198         * gdbtypes.c (recursive_dump_type): Likewise.
8199         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8200         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8201         instead of %d in format strings.
8202         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8203         to std::min to ULONGEST.
8204         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8205         instead of %d in format strings.
8206         * tracepoint.c (info_scope_command): Likewise.
8207         * typeprint.c (print_offset_data::update)
8208         (print_offset_data::finish): Likewise.
8209         * xtensa-tdep.c (xtensa_store_return_value)
8210         (xtensa_push_dummy_call): Likewise.
8211
8212 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8213
8214         * windows-nat.c (display_selector): Fixed format specifications
8215         for 64-bit Cygwin.
8216
8217 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8218
8219         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8220
8221 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8222
8223         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8224         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8225         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8226         (nios2_linux_init_abi): Install it.
8227
8228 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8229
8230         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8231
8232 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8233
8234         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8235
8236 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8237             Tom Tromey  <tromey@adacore.com>
8238
8239         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8240
8241 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8242
8243         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8244         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8245         method to compute the bounds of range types. Also print "[evaluated]"
8246         if the bounds' values come from a dynamic evaluation.
8247
8248 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8249
8250         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8251         whitespace when pretty printing is on.
8252
8253 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8254
8255         * ppc-linux-nat.c: Add include.
8256
8257 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8258
8259         * NEWS: Mention AArch64 Pointer Authentication.
8260
8261 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8262
8263         * arm-linux-nat.c: Add include.
8264
8265 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8266
8267         * source-cache.c (source_cache::get_source_lines): Re-read
8268         fullname after calling open_source_file.
8269
8270 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8271
8272         * NEWS: Mention TLS support for FreeBSD.
8273
8274 2019-03-25  Tom Tromey  <tromey@adacore.com>
8275
8276         * minsyms.c (BUNCH_SIZE): Update comment.
8277         (~minimal_symbol_reader): Remove old comment.
8278         (compact_minimal_symbols): Update comment.
8279         (minimal_symbol_reader::install): Remove old comment.  Update
8280         other comments.
8281
8282 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8283
8284         * s390-linux-nat.c: Add include.
8285
8286 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8287
8288         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8289         Call linux_get_hwcap.
8290         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8291         Likewise.
8292         (aarch64_linux_get_hwcap): Remove function.
8293         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8294         declaration.
8295         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8296         linux_get_hwcap.
8297         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8298         * linux-tdep.c (linux_get_hwcap): Add function.
8299         (linux_get_hwcap2): Likewise.
8300         * linux-tdep.h (linux_get_hwcap): Add declaration.
8301         (linux_get_hwcap2): Likewise.
8302         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8303         (ppc_linux_get_hwcap2): Likewise.
8304         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8305         linux_get_hwcap.
8306         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8307         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8308         (ppc_linux_nat_target::read_description): Likewise.
8309         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8310         * s390-linux-nat.c: Likewise.
8311         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8312
8313 2019-03-24  Tom Tromey  <tom@tromey.com>
8314
8315         * ada-lang.c (standard_lookup): Simplify initialization.
8316         (ada_lookup_symbol_nonlocal): Simplify return.
8317         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8318         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8319         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8320         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8321         initialization.
8322         * solib.c (solib_global_lookup): Simplify.
8323         * symtab.c (null_block_symbol): Remove.
8324         (symbol_cache_lookup): Simplify returns.
8325         (lookup_language_this): Simplify returns.
8326         (lookup_symbol_aux): Simplify return.
8327         (lookup_local_symbol): Simplify returns.
8328         (lookup_global_symbol_from_objfile): Simplify return.
8329         (lookup_symbol_in_objfile_symtabs)
8330         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8331         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8332         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8333         * cp-namespace.c (cp_lookup_bare_symbol)
8334         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8335         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8336         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8337         (cp_lookup_symbol_via_imports): Simplify initialization.
8338         (find_symbol_in_baseclass): Likewise.
8339         * symtab.h (null_block_symbol): Remove.
8340         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8341         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8342         (d_lookup_symbol_module): Likewise.
8343         (find_symbol_in_baseclass): Simplify initialization.
8344
8345 2019-03-24  Tom Tromey  <tom@tromey.com>
8346
8347         * expression.h: Don't include symtab.h.
8348         (struct block): Forward declare.
8349
8350 2019-03-24  Tom Tromey  <tom@tromey.com>
8351
8352         * c-exp.y (typebase): Remove casts.
8353         * gdbtypes.c (lookup_unsigned_typename, )
8354         (lookup_signed_typename): Remove cast.
8355         * eval.c (parse_to_comma_and_eval): Remove cast.
8356         * parse.c (write_dollar_variable): Remove cast.
8357         * block.h (struct block) <superblock>: Now const.
8358         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8359         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8360         (map_block): Make "block" const.
8361         * symfile.h (struct quick_symbol_functions)
8362         <map_matching_symbols>: Constify block argument to "callback".
8363         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8364         const.
8365         (find_pc_sect_compunit_symtab): Make "b" const.
8366         (find_symbol_at_address): Likewise.
8367         (search_symbols): Likewise.
8368         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8369         (dw2_debug_names_lookup_symbol): Likewise.
8370         (dw2_map_matching_symbols): Update.
8371         * p-valprint.c (pascal_val_print): Remove "block".
8372         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8373         (aux_add_nonlocal_symbols): Make "block" const.
8374         (resolve_subexp): Remove cast.
8375         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8376         const.
8377         (iterate_over_file_blocks): Likewise.
8378         * f-exp.y (%union) <bval>: Remove.
8379         * coffread.c (patch_opaque_types): Make "b" const.
8380         * spu-tdep.c (spu_catch_start): Make "block" const.
8381         * c-valprint.c (print_unpacked_pointer): Remove "block".
8382         * symmisc.c (dump_symtab_1): Make "b" const.
8383         (block_depth): Make "block" const.
8384         * d-exp.y (%union) <bval>: Remove.
8385         * cp-support.h (cp_lookup_rtti_type): Update.
8386         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8387         * psymtab.c (psym_lookup_symbol): Make "block" const.
8388         (maintenance_check_psymtabs): Make "b" const.
8389         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8390         (enumerate_locals, enumerate_args): Update.
8391         * python/py-symtab.c (stpy_global_block): Make "block" const.
8392         (stpy_static_block): Likewise.
8393         * inline-frame.c (block_starting_point_at): Make "new_block"
8394         const.
8395         * block.c (find_block_in_blockvector): Make return type const.
8396         (blockvector_for_pc_sect): Make "b" const.
8397         (find_block_in_blockvector): Make "b" const.
8398
8399 2019-03-23  Tom Tromey  <tom@tromey.com>
8400
8401         * varobj.c (varobj_create): Update.
8402         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8403         * printcmd.c (display_command, do_one_display): Don't reset
8404         innermost_block.
8405         * parser-defs.h (enum innermost_block_tracker_type): Move to
8406         expression.h.
8407         (innermost_block): Update comment.
8408         * parse.c (parse_exp_1): Add tracker_types parameter.
8409         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8410         tracker_types parameter.  Reset innermost_block.
8411         (parse_exp_in_context): Remove.
8412         (parse_expression_for_completion): Update.
8413         * objfiles.c (~objfile): Don't reset expression_context_block or
8414         innermost_block.
8415         * expression.h (enum innermost_block_tracker_type): Move from
8416         parser-defs.h.
8417         (parse_exp_1): Add tracker_types parameter.
8418         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8419         reset innermost_block.
8420
8421 2019-03-23  Tom Tromey  <tom@tromey.com>
8422
8423         * objfiles.h: Include bcache.h.
8424
8425 2019-03-23  Tom Tromey  <tom@tromey.com>
8426
8427         * linespec.c (get_current_search_block): Use
8428         scoped_restore_current_language.
8429         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8430
8431 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8432             Jiong Wang  <jiong.wang@arm.com>
8433
8434         * aarch64-linux-tdep.c
8435         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8436         section.
8437         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8438
8439 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8440             Jiong Wang  <jiong.wang@arm.com>
8441
8442         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8443         instructions.
8444         (aarch64_analyze_prologue_test): Add PACIASP test.
8445         (aarch64_prologue_prev_register): Unmask PC value.
8446
8447 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8448             Jiong Wang  <jiong.wang@arm.com>
8449
8450         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8451         (aarch64_dwarf2_prev_register): Unmask PC value.
8452         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8453         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8454         DW_CFA_AARCH64_negate_ra_state.
8455         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8456
8457 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8458             Jiong Wang  <jiong.wang@arm.com>
8459
8460         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8461         registers.
8462         (aarch64_pseudo_register_name): Likewise.
8463         (aarch64_pseudo_register_type): Likewise.
8464         (aarch64_pseudo_register_reggroup_p): Likewise.
8465         (aarch64_gdbarch_init): Add pauth registers.
8466         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8467         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8468         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8469         (struct gdbarch_tdep): Add regnum for ra_state.
8470
8471 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8472             Jiong Wang  <jiong.wang@arm.com>
8473
8474         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8475
8476 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8477             Jiong Wang  <jiong.wang@arm.com>
8478
8479         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8480         function.
8481         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8482         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8483         (aarch64_gdbarch_init): Add puth registers.
8484         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8485         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8486         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8487
8488 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8489             Jiong Wang  <jiong.wang@arm.com>
8490
8491         * aarch64-linux-nat.c
8492         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8493         * aarch64-linux-tdep.c
8494         (aarch64_linux_core_read_description): Likewise.
8495         (aarch64_linux_get_hwcap): New function.
8496         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8497         (aarch64_linux_get_hwcap): New declaration.
8498
8499 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8500             Jiong Wang  <jiong.wang@arm.com>
8501
8502         * aarch64-linux-nat.c
8503         (aarch64_linux_nat_target::read_description): Add pauth param.
8504         * aarch64-linux-tdep.c
8505         (aarch64_linux_core_read_description): Likewise.
8506         * aarch64-tdep.c (struct target_desc): Add in pauth.
8507         (aarch64_read_description): Add pauth param.
8508         (aarch64_gdbarch_init): Likewise.
8509         * aarch64-tdep.h (aarch64_read_description): Likewise.
8510         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8511         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8512         * features/Makefile: Add new files.
8513         * features/aarch64-pauth.c: New file.
8514         * features/aarch64-pauth.xml: New file.
8515
8516 2019-03-20  Tom Tromey  <tromey@adacore.com>
8517
8518         * infrun.c (handle_inferior_event): Rename from
8519         handle_inferior_event_1.  Create a scoped_value_mark.
8520         (handle_inferior_event): Remove.
8521
8522 2019-03-19  Tom Tromey  <tromey@adacore.com>
8523
8524         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8525         * infrun.h (print_stop_event): Add "displays" parameter.
8526         * infrun.c (print_stop_event): Add "displays" parameter.
8527
8528 2019-03-19  Pedro Alves  <palves@redhat.com>
8529
8530         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8531         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8532         to -1.  Fix TABs vs spaces.
8533         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8534         * tui/tui-out.h (tui_ui_out) Add intro comments.
8535         <m_line, m_start_of_line>: In-class initialize, and add describing
8536         comment.
8537
8538 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8539
8540         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8541         variable names.
8542         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8543
8544 2019-03-18  Pedro Alves  <palves@redhat.com>
8545             Eli Zaretskii <eliz@gnu.org>
8546
8547         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8548         m_line and m_start_of_line.
8549
8550 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8551
8552         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8553         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8554         it returns a newline.  This fixes a regression in TU mode, whereby
8555         the next line is output on the same screen line as the user input.
8556
8557 2019-03-18  Tom Tromey  <tromey@adacore.com>
8558
8559         * minsyms.c (minimal_symbol_reader::install): Remove call to
8560         obstack_blank.
8561
8562 2019-03-18  Pedro Alves  <palves@redhat.com>
8563
8564         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8565         New globals.
8566         (apply_style): New, factored out from ...
8567         (apply_ansi_escape): ... this.  Handle reverse video mode.
8568         (tui_set_reverse_mode): New function.
8569         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8570         * tui/tui-winsource.c (tui_show_source_line): Use
8571         tui_set_reverse_mode instead of setting A_STANDOUT.
8572         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8573         New setter methods.
8574
8575 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8576
8577         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8578         Handle tabs.
8579
8580 2019-03-18  Tom Tromey  <tromey@adacore.com>
8581
8582         * ada-lang.c (empty_array): Add "high" parameter.
8583         (ada_evaluate_subexp): Update.
8584
8585 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8586
8587         * unittests/string_view-selftests.c: Define
8588         _initialize_string_view_selftests unconditionally.
8589
8590 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8591
8592         PR gdb/24350
8593         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8594
8595 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8596
8597         PR gdb/24351
8598         * windows-nat.c (display_selector): Fix format specifiers.
8599
8600 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8601
8602         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8603         tui_refill_source_window instead of tui_refresh_win, to update the
8604         current execution line.  This fixes redisplay of the current line
8605         when stepping through the code with "next" or "step".
8606
8607 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8608
8609         * source-cache.c (source_cache::get_source_lines): Call
8610         find_source_lines to initialize s->nlines.  This fixes vertical
8611         scrolling of TUI source window when the DOWN arrow is pressed.
8612
8613 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8614
8615         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8616         linux-thread-db.c (_initialize_thread_db): Likewise.
8617
8618 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8619
8620         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8621         wclrtoeol in tui_show_source_line".  This reverts changes made in
8622         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8623
8624 2019-03-15  Tom Tromey  <tom@tromey.com>
8625
8626         * symtab.h (struct minimal_symbol): Derive from
8627         general_symbol_info.
8628         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8629         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8630         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8631         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8632         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8633         (MSYMBOL_SEARCH_NAME): Update.
8634         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8635         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8636         * minsyms.c (minimal_symbol_reader::record_full): Update.
8637
8638 2019-03-15  Tom Tromey  <tom@tromey.com>
8639
8640         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8641
8642 2019-03-15  Tom Tromey  <tom@tromey.com>
8643
8644         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8645         unique_xmalloc_ptr.
8646         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8647         Update.
8648         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8649         (build_minimal_symbol_hash_tables)
8650         (minimal_symbol_reader::install): Update.
8651
8652 2019-03-15  Tom Tromey  <tom@tromey.com>
8653
8654         * symtab.c (create_demangled_names_hash): Update.
8655         (symbol_set_names): Update.
8656         * objfiles.h (struct objfile_per_bfd_storage)
8657         <demangled_names_hash>: Now an htab_up.
8658         * objfiles.c (objfile_per_bfd_storage): Simplify.
8659
8660 2019-03-15  Tom Tromey  <tom@tromey.com>
8661
8662         * objfiles.h (struct objfile_per_bfd_storage): Declare
8663         destructor.
8664         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8665         New.
8666         (get_objfile_bfd_data): Use new.  Don't initialize
8667         language_of_main.
8668         (free_objfile_per_bfd_storage): Remove.
8669         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8670
8671 2019-03-15  Tom Tromey  <tom@tromey.com>
8672
8673         * symfile.c (reread_symbols): Update.
8674         * objfiles.c (objfile::objfile): Update.
8675         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8676         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8677         comment.
8678         (minimal_symbol_reader::install): Update.
8679         (terminate_minimal_symbol_table): Remove.
8680         * jit.c (jit_object_close_impl): Update.
8681
8682 2019-03-15  Tom Tromey  <tom@tromey.com>
8683
8684         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8685         initializations.
8686
8687 2019-03-15  Tom Tromey  <tom@tromey.com>
8688
8689         * objfiles.h (struct objfile_per_bfd_storage)
8690         <demangled_hash_languages>: Now a bitset.
8691         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8692         (lookup_minimal_symbol): Update.
8693
8694 2019-03-15  Tom Tromey  <tom@tromey.com>
8695
8696         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8697         Don't return the symbol.
8698         * coffread.c (record_minimal_symbol): Use record_full.
8699
8700 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8701
8702         The MS-Windows port of ncurses fails to switch to a color pair if
8703         one or both of the colors are the implicit default colors.  This
8704         change records the default colors when TUI is initialized, and
8705         then specifies them explicitly when a color pair uses the default
8706         colors.  This allows color styling in TUI mode on MS-Windows.
8707
8708         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8709         ncurses_norm_attr.
8710         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8711         colors in ncurses_norm_attr.
8712         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8713         "none", replace it with the default color recorded in
8714         ncurses_norm_attr.
8715
8716 2019-03-14  Tom Tromey  <tromey@adacore.com>
8717
8718         * source-cache.h (class source_cache) <get_source_lines>: Return
8719         std::string.
8720         * source-cache.c (source_cache::extract_lines): Handle case where
8721         first_pos==npos.  Return std::string.
8722         (source_cache::get_source_lines): Update.
8723
8724 2019-03-14  Tom Tromey  <tromey@adacore.com>
8725
8726         * NEWS: Add item for "style sources" commands.
8727         * source-cache.c (source_cache::get_source_lines): Check
8728         source_styling.
8729         * cli/cli-style.c (source_styling): New global.
8730         (_initialize_cli_style): Add "style sources" commands.
8731         (show_style_sources): New function.
8732         * cli/cli-style.h (source_styling): Declare.
8733
8734 2019-03-14  Pedro Alves  <palves@redhat.com>
8735             Tom Tromey  <tromey@adacore.com>
8736
8737         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8738         * tui/tui-winsource.c (tui_refill_source_window): New function,
8739         from...
8740         (tui_horizontal_source_scroll): ... here.  Move some logic.
8741         * cli/cli-style.c (set_style_enabled): Notify new observable.
8742         * tui/tui-hooks.c (tui_redisplay_source): New function.
8743         (tui_attach_detach_observers): Attach or detach
8744         tui_redisplay_source.
8745         * observable.h (source_styling_changed): New observable.
8746         * observable.c: Define source_styling_changed observable.
8747
8748 2019-03-13  Tom Tromey  <tromey@adacore.com>
8749
8750         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8751         (i386_gnu_nat_target::store_registers): Update.
8752         * target-debug.h (target_debug_print_std_string): New macro.
8753         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8754         * windows-tdep.c (display_one_tib): Update.
8755         * tui/tui-stack.c (tui_make_status_line): Update.
8756         * top.c (print_inferior_quit_action): Update.
8757         * thread.c (thr_try_catch_cmd): Update.
8758         (add_thread_with_info): Update.
8759         (thread_target_id_str): Update.
8760         (thr_try_catch_cmd): Update.
8761         (thread_command): Update.
8762         (thread_find_command): Update.
8763         * record-btrace.c (record_btrace_target::info_record)
8764         (record_btrace_resume_thread, record_btrace_target::resume)
8765         (record_btrace_cancel_resume, record_btrace_step_thread)
8766         (record_btrace_target::wait, record_btrace_target::wait)
8767         (record_btrace_target::wait, record_btrace_target::stop): Update.
8768         * progspace.c (print_program_space): Update.
8769         * process-stratum-target.c
8770         (process_stratum_target::thread_address_space): Update.
8771         * linux-fork.c (linux_fork_mourn_inferior)
8772         (detach_checkpoint_command, info_checkpoints_command)
8773         (linux_fork_context): Update.
8774         (linux_fork_detach): Update.
8775         (class scoped_switch_fork_info): Update.
8776         (delete_checkpoint_command): Update.
8777         * infrun.c (follow_fork_inferior): Update.
8778         (follow_fork_inferior): Update.
8779         (proceed_after_vfork_done): Update.
8780         (handle_vfork_child_exec_or_exit): Update.
8781         (follow_exec): Update.
8782         (displaced_step_prepare_throw): Update.
8783         (displaced_step_restore): Update.
8784         (start_step_over): Update.
8785         (resume_1): Update.
8786         (clear_proceed_status_thread): Update.
8787         (proceed): Update.
8788         (print_target_wait_results): Update.
8789         (do_target_wait): Update.
8790         (context_switch): Update.
8791         (stop_all_threads): Update.
8792         (restart_threads): Update.
8793         (finish_step_over): Update.
8794         (handle_signal_stop): Update.
8795         (switch_back_to_stepped_thread): Update.
8796         (keep_going_pass_signal): Update.
8797         (print_exited_reason): Update.
8798         (normal_stop): Update.
8799         * inferior.c (inferior_pid_to_str): Change return type.
8800         (print_selected_inferior): Update.
8801         (add_inferior): Update.
8802         (detach_inferior): Update.
8803         * dummy-frame.c (fprint_dummy_frames): Update.
8804         * dcache.c (dcache_info_1): Update.
8805         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8806         (btrace_fetch, btrace_clear): Update.
8807         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8808         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8809         type.
8810         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8811         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8812         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8813         * gdbarch.c, gdbarch.h: Rebuild.
8814         * gdbarch.sh (core_pid_to_str): Change return type.
8815         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8816         return type.
8817         (windows_nat_target::pid_to_str): Change return type.
8818         (windows_delete_thread): Update.
8819         (windows_nat_target::attach): Update.
8820         (windows_nat_target::files_info): Update.
8821         * target-delegates.c: Rebuild.
8822         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8823         return type.
8824         (sol_thread_target::pid_to_str): Change return type.
8825         * remote.c (class remote_target) <pid_to_str>: Change return
8826         type.
8827         (remote_target::pid_to_str): Change return type.
8828         (extended_remote_target::attach, remote_target::remote_stop_ns)
8829         (remote_target::remote_notif_remove_queued_reply)
8830         (remote_target::push_stop_reply, remote_target::disable_btrace):
8831         Update.
8832         (extended_remote_target::attach): Update.
8833         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8834         type.
8835         (gdbsim_target::pid_to_str): Change return type.
8836         * ravenscar-thread.c (struct ravenscar_thread_target)
8837         <pid_to_str>: Change return type.
8838         (ravenscar_thread_target::pid_to_str): Change return type.
8839         * procfs.c (class procfs_target) <pid_to_str>: Change return
8840         type.
8841         (procfs_target::pid_to_str): Change return type.
8842         (procfs_target::attach): Update.
8843         (procfs_target::detach): Update.
8844         (procfs_target::fetch_registers): Update.
8845         (procfs_target::store_registers): Update.
8846         (procfs_target::wait): Update.
8847         (procfs_target::files_info): Update.
8848         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8849         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8850         return type.
8851         (nto_procfs_target::pid_to_str): Change return type.
8852         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8853         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8854         return type.
8855         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8856         (exit_lwp): Update.
8857         (attach_proc_task_lwp_callback, get_detach_signal)
8858         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8859         (linux_nat_target::resume, wait_lwp, stop_callback)
8860         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8861         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8862         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8863         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8864         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8865         type.
8866         (inf_ptrace_target::attach): Update.
8867         (inf_ptrace_target::files_info): Update.
8868         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8869         type.
8870         (go32_nat_target::pid_to_str): Change return type.
8871         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8872         (gnu_nat_target::wait): Update.
8873         (gnu_nat_target::wait): Update.
8874         (gnu_nat_target::resume): Update.
8875         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8876         (fbsd_nat_target::wait): Update.
8877         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8878         type.
8879         (darwin_nat_target::attach): Update.
8880         * corelow.c (class core_target) <pid_to_str>: Change return type.
8881         (core_target::pid_to_str): Change return type.
8882         * target.c (normal_pid_to_str): Change return type.
8883         (default_pid_to_str): Likewise.
8884         (target_pid_to_str): Change return type.
8885         (target_translate_tls_address): Update.
8886         (target_announce_detach): Update.
8887         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8888         return type.
8889         (bsd_uthread_target::pid_to_str): Change return type.
8890         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8891         type.
8892         (bsd_kvm_target::pid_to_str): Change return type.
8893         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8894         return type.
8895         (aix_thread_target::pid_to_str): Change return type.
8896         * target.h (struct target_ops) <pid_to_str>: Change return type.
8897         (target_pid_to_str, normal_pid_to_str): Likewise.
8898         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8899         type.
8900         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8901         type.
8902         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8903         return type.
8904         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8905         type.
8906         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8907         type.
8908         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8909         return type.
8910
8911 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8912
8913         * NEWS: Mention that the new default MI version is 3.  Mention
8914         changes to the output of commands and events that deal with
8915         multi-location breakpoints.
8916         * breakpoint.c: Include "mi/mi-out.h".
8917         (print_one_breakpoint): Change output syntax if using MI version
8918         >= 3.
8919         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8920         New.
8921         (mi_multi_location_breakpoint_output_fixed): New.
8922         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8923         (mi_cmd_fix_multi_location_breakpoint_output): New.
8924         (mi_multi_location_breakpoint_output_fixed): New.
8925         * mi/mi-cmds.c (mi_cmds): Register command
8926         -fix-multi-location-breakpoint-output.
8927         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8928         interpreter "mi".
8929
8930 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8931
8932         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8933         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8934         instantiate mi_ui_out based on interpreter name.
8935         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8936         * mi/mi-main.c (mi_load_progress): Likewise.
8937
8938 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8939
8940         * NEWS: Combine separate "New targets" sections for 8.3.
8941
8942 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8943
8944         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8945         (ppcfbsd_init_abi): Install gdbarch
8946         "fetch_tls_load_module_address" and "get_thread_local_address"
8947         methods.
8948
8949 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8950
8951         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8952         (riscv_fbsd_init_abi): Install gdbarch
8953         "fetch_tls_load_module_address" and "get_thread_local_address"
8954         methods.
8955
8956 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8957
8958         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8959         (i386fbsd_init_abi): Install gdbarch
8960         "fetch_tls_load_module_address" and "get_thread_local_address"
8961         methods.
8962
8963 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8964
8965         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8966         (amd64fbsd_init_abi): Install gdbarch
8967         "fetch_tls_load_module_address" and "get_thread_local_address"
8968         methods.
8969
8970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8971
8972         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8973         (struct fbsd_pspace_data): New type.
8974         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8975         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8976         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8977         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8978         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8979
8980 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8981
8982         * gdbtypes.c (lookup_struct_elt): New function.
8983         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8984         * gdbtypes.h (struct struct_elt): New type.
8985         (lookup_struct_elt): New prototype.
8986
8987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8988
8989         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8990         remove disabled code block.
8991
8992 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8993
8994         * gdbarch.sh (get_thread_local_address): New method.
8995         * gdbarch.h, gdbarch.c: Regenerate.
8996         * target.c (target_translate_tls_address): Use
8997         gdbarch_get_thread_local_address if present instead of
8998         target::get_thread_local_address.
8999
9000 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9001
9002         * target.h (target::get_thread_local_address): Update comment.
9003
9004 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9005
9006         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9007         objfile->separate_debug_objfile_backlink if not NULL.
9008
9009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9010
9011         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9012         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9013         (amd64bsd_store_inferior_registers): Likewise.
9014         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9015         Enable segment base registers.
9016         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9017         PT_GETFSBASE and PT_GETGSBASE.
9018         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9019         PT_SETGSBASE.
9020         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9021         segment base registers.
9022         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9023
9024 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9025
9026         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9027         Update calls to i386_target_description to add 'segments'
9028         parameter.
9029         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9030         add segment base registers.
9031         * arch/i386.c (i386_create_target_description): Add 'segments'
9032         parameter to enable segment base registers.
9033         * arch/i386.h (i386_create_target_description): Likewise.
9034         * features/i386/32bit-segments.xml: New file.
9035         * features/i386/32bit-segments.c: Generate.
9036         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9037         call to i386_target_description to add 'segments' parameter.
9038         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9039         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9040         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9041         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9042         if feature is present.
9043         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9044         Add 'segments' parameter to call to i386_target_description.
9045         (i386_target_description): Add 'segments' parameter to enable
9046         segment base registers.
9047         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9048         to call to i386_target_description.
9049         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9050         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9051         Define I386_NUM_REGS.
9052         (i386_target_description): Add 'segments' parameter to enable
9053         segment base registers.
9054
9055 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9056
9057         PR/24325
9058         * source-cache.c: #undef open and close, to avoid unresolved
9059         externals during linking.
9060
9061 2019-03-12  Tom Tromey  <tromey@adacore.com>
9062
9063         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9064         const.  Add initializers.
9065         (_initialize_remote): Don't initialize ptid globals.
9066
9067 2019-03-12  Pedro Alves  <palves@redhat.com>
9068
9069         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9070
9071 2019-03-12  Pedro Alves  <palves@redhat.com>
9072
9073         * cp-name-parser.y (main): Remove unused 'len' variable.
9074
9075 2019-03-12  Tom Tromey  <tromey@adacore.com>
9076
9077         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9078         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9079
9080 2019-03-12  Tom Tromey  <tromey@adacore.com>
9081
9082         * linux-nat.c (iterate_over_lwps): Update.
9083         (stop_callback): Remove parameter.
9084         (stop_wait_callback, detach_callback, resume_set_callback)
9085         (select_singlestep_lwp_callback, set_ignore_sigint)
9086         (status_callback, resumed_callback, resume_clear_callback)
9087         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9088         data parameter.
9089         (linux_nat_target::detach, linux_nat_target::resume)
9090         (linux_stop_and_wait_all_lwps, select_event_lwp)
9091         (linux_nat_filter_event, linux_nat_wait_1)
9092         (linux_nat_target::kill, linux_nat_target::stop)
9093         (linux_nat_target::stop): Update.
9094         (linux_nat_resume_callback): Change type.
9095         (resume_stopped_resumed_lwps, count_events_callback)
9096         (select_event_lwp_callback): Likewise.
9097         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9098         * arm-linux-nat.c (struct update_registers_data): Remove.
9099         (update_registers_callback): Change type.
9100         (arm_linux_insert_hw_breakpoint1): Update.
9101         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9102         parameter.
9103         (x86_linux_dr_set_addr): Update.
9104         (x86_linux_dr_set_control): Update.
9105         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9106         (iterate_over_lwps): Use gdb::function_view.
9107         * nat/aarch64-linux-hw-point.c (struct
9108         aarch64_dr_update_callback_param): Remove.
9109         (debug_reg_change_callback): Change type.
9110         (aarch64_notify_debug_reg_change): Update.
9111         * s390-linux-nat.c (s390_refresh_per_info): Update.
9112
9113 2019-03-11  Tom Tromey  <tromey@adacore.com>
9114
9115         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9116         redundant assignment to "this_cu".
9117
9118 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9119
9120         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9121
9122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9123
9124         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9125         from...
9126         (rank_one_type): ... this.
9127
9128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9129
9130         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9131         from...
9132         (rank_one_type): ... this.
9133
9134 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9135
9136         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9137         from...
9138         (rank_one_type): ... this.
9139
9140 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9141
9142         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9143         from...
9144         (rank_one_type): ... this.
9145
9146 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9147
9148         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9149         from...
9150         (rank_one_type): ... this.
9151
9152 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9153
9154         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9155         from...
9156         (rank_one_type): ... this.
9157
9158 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9159
9160         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9161         from...
9162         (rank_one_type): ... this.
9163
9164 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9165
9166         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9167         from...
9168         (rank_one_type): ... this.
9169
9170 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9171
9172         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9173         from...
9174         (rank_one_type): ... this.
9175
9176 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9177
9178         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9179         from...
9180         (rank_one_type): ... this.
9181
9182 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9183
9184         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9185         from...
9186         (rank_one_type): ... this.
9187
9188 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9189
9190         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9191         from...
9192         (rank_one_type): ... this.
9193
9194 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9195
9196         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9197         inferior-events' shows the example events.
9198
9199 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9200
9201         Support styling on native MS-Windows console
9202
9203         PR/24315
9204         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9205         on MS-Windows if $TERM is not defined.
9206
9207         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9208
9209         * posix-hdep.c (gdb_console_fputs):
9210         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9211         functions.
9212         * ui-file.h (gdb_console_fputs): Add prototype.
9213
9214         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9215         back to fputs only if the former returns zero.
9216
9217 2019-03-07  Tom Tromey  <tom@tromey.com>
9218
9219         * symmisc.c (print_symbol_bcache_statistics): Update.
9220         (print_objfile_statistics): Update.
9221         * symfile.c (allocate_symtab): Update.
9222         * stabsread.c: Don't include bcache.h.
9223         * psymtab.h (struct psymbol_bcache): Don't declare.
9224         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9225         (psymbol_bcache_init, psymbol_bcache_free)
9226         (psymbol_bcache_get_bcache): Don't declare.
9227         * psymtab.c (struct psymbol_bcache): Remove.
9228         (psymtab_storage::psymtab_storage): Update.
9229         (psymtab_storage::~psymtab_storage): Update.
9230         (psymbol_bcache_init, psymbol_bcache_free)
9231         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9232         (add_psymbol_to_bcache): Update.
9233         (allocate_psymtab): Update.
9234         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9235         macro_cache>: No longer pointers.
9236         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9237         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9238         * macrotab.c (macro_bcache): Update.
9239         * macroexp.c: Don't include bcache.h.
9240         * gdbtypes.c (check_types_worklist): Update.
9241         (types_deeply_equal): Remove TRY/CATCH.  Update.
9242         * elfread.c (elf_symtab_read): Update.
9243         * dwarf2read.c: Don't include bcache.h.
9244         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9245         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9246         (print_bcache_statistics, bcache_memory_used): Don't declare.
9247         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9248         methods.  Rename all data members.
9249         * bcache.c (struct bcache): Move to bcache.h.
9250         (bcache::expand_hash_table): Rename from expand_hash_table.
9251         (bcache): Remove.
9252         (bcache::insert): Rename from bcache_full.
9253         (bcache::compare): Rename from bcache_compare.
9254         (bcache_xmalloc): Remove.
9255         (bcache::~bcache): Rename from bcache_xfree.
9256         (bcache::print_statistics): Rename from print_bcache_statistics.
9257         (bcache::memory_used): Rename from bcache_memory_used.
9258
9259 2019-03-07  Pedro Alves  <palves@redhat.com>
9260
9261         * infrun.c (normal_stop): Also check for
9262         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9263
9264 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9265
9266         * f-lang.c (value_from_host_double): Moved to...
9267         * value.c (value_from_host_double): ...here.
9268         * value.h (value_from_host_double): Declare.
9269         * guile/scm-math.c (vlscm_convert_typed_number): Use
9270         value_from_host_double.
9271         (vlscm_convert_number): Likewise.
9272         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9273         * python/py-value.c (convert_value_from_python): Likewise.
9274
9275 2019-03-06  Tom Tromey  <tom@tromey.com>
9276
9277         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9278
9279 2019-03-06  Tom Tromey  <tom@tromey.com>
9280
9281         * utils.h (free_current_contents): Don't declare.
9282         * utils.c (free_current_contents): Remove.
9283
9284 2019-03-06  Tom Tromey  <tom@tromey.com>
9285
9286         * top.c (quit_force): Update.
9287         * main.c (captured_command_loop): Update.
9288         * common/new-op.c (operator new): Update.
9289         * common/common-exceptions.c (struct catcher)
9290         <save_cleanup_chain>: Remove member.
9291         (exceptions_state_mc_init): Update.
9292         (exception_try_scope_entry): Return nullptr.
9293         (exception_try_scope_exit, exception_rethrow)
9294         (throw_exception_sjlj, throw_exception_cxx): Update.
9295         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9296         (all_cleanups, do_cleanups, discard_cleanups)
9297         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9298         (restore_cleanups, restore_final_cleanups): Don't declare.
9299         (do_final_cleanups): Remove parameter.
9300         * common/cleanups.c (cleanup_chain, make_cleanup)
9301         (make_cleanup_dtor, all_cleanups, do_cleanups)
9302         (discard_my_cleanups, discard_cleanups)
9303         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9304         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9305         (null_cleanup): Remove.
9306         (do_final_cleanups): Remove parameter.
9307
9308 2019-03-06  Tom Tromey  <tom@tromey.com>
9309
9310         * remote.c (remote_target::remote_parse_stop_reply): Use
9311         unique_xmalloc_ptr.
9312
9313 2019-03-06  Tom Tromey  <tom@tromey.com>
9314
9315         * stabsread.c (struct stabs_field_info): Rename from field_info.
9316         <list, fnlist>: Add initializers.
9317         <obstack>: New member.
9318         (read_member_functions, read_struct_fields, read_baseclasses):
9319         Allocate on obstack.  Don't use cleanups.
9320         (read_one_struct_field, read_member_functions, read_struct_fields)
9321         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9322         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9323         (read_struct_type): Update.
9324
9325 2019-03-06  Tom Tromey  <tom@tromey.com>
9326
9327         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9328         * common/filestuff.h (make_cleanup_close): Don't declare.
9329         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9330         Remove.
9331
9332 2019-03-06  Tom Tromey  <tom@tromey.com>
9333
9334         * solib-aix.c: Use make_scope_exit.
9335
9336 2019-03-06  Tom Tromey  <tom@tromey.com>
9337
9338         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9339         Use make_scope_exit.
9340
9341 2019-03-06  Tom Tromey  <tom@tromey.com>
9342
9343         * solib-svr4.c (disable_probes_interface): Remove parameter.
9344         (svr4_handle_solib_event): Use make_scope_exit.
9345
9346 2019-03-06  Tom Tromey  <tom@tromey.com>
9347
9348         * remote.c (struct stop_reply_deleter): Remove.
9349         (stop_reply_up): Update.
9350         (struct stop_reply): Derive from notif_event.  Don't typedef.
9351         <regcache>: Now a std::vector.
9352         (stop_reply_xfree): Remove.
9353         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9354         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9355         (remote_target::discard_pending_stop_replies): Use delete.
9356         (remote_target::remote_parse_stop_reply): Update.
9357         (remote_target::process_stop_reply): Update.
9358         * remote-notif.h (struct notif_event): Add virtual destructor.
9359         Remove "dtr" member.
9360         (struct notif_client) <alloc_event>: Return a unique_ptr.
9361         (notif_event_xfree): Don't declare.
9362         (notif_event_up): New typedef.
9363         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9364         (notif_event_xfree, do_notif_event_xfree): Remove.
9365         (remote_notif_state_xfree): Update.
9366
9367 2019-03-06  Tom Tromey  <tom@tromey.com>
9368
9369         * infrun.c (displaced_step_clear_cleanup): Now a
9370         forward_scope_exit type.
9371         (displaced_step_prepare_throw): Update.
9372         (displaced_step_fixup): Update.
9373
9374 2019-03-06  Tom Tromey  <tom@tromey.com>
9375
9376         * inferior.h (class inferior): Update comment.
9377         * gdbthread.h (class thread_info): Update comment.
9378
9379 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9380             Tom Tromey  <tom@tromey.com>
9381
9382         * stabsread.h (struct stab_section_list): Remove.
9383         (coffstab_build_psymtabs): Update.
9384         * dbxread.c (symbuf_sections): Now a std::vector.
9385         (sect_idx): New global.
9386         (fill_symbuf): Update.
9387         (coffstab_build_psymtabs): Change type of stabsects parameter.
9388         Update.
9389         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9390         std::vector.
9391         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9392         (coff_locate_sections): Update.
9393         (coff_symfile_read): Remove cleanups.  Update.
9394         (init_stringtab): Add storage parameter.
9395         (free_stringtab, free_stringtab_cleanup): Remove.
9396         (init_lineno): Add storage parameter.
9397         (free_linetab, free_linetab_cleanup): Remove.
9398
9399 2019-03-06  Pedro Alves  <palves@redhat.com>
9400
9401         * linux-fork.c (fork_info::clobber_regs): Delete.
9402         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9403         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9404         comment.  Adjust.
9405         (scoped_switch_fork_info::scoped_switch_fork_info)
9406         (checkpoint_command, linux_fork_context): Adjust
9407         fork_save_infrun_state calls.
9408
9409 2019-03-06  Pedro Alves  <palves@redhat.com>
9410
9411         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9412         (inf_has_multiple_threads): Return 'bool' and rewrite using
9413         inferior_info::threads().
9414
9415 2019-03-06  Pedro Alves  <palves@redhat.com>
9416
9417         * linux-fork.c: Include <list>.
9418         (fork_list): Now a std::list instance.
9419         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9420         (forks_exist_p, find_last_fork): Adjust.
9421         (new_fork): Delete.
9422         (one_fork_p): New.
9423         (add_fork): Adjust.
9424         (free_fork): Delete, folded into fork_info::~fork_info().
9425         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9426         Adjust.
9427         (init_fork_list): Delete.
9428         (linux_fork_killall, linux_fork_mourn_inferior)
9429         (linux_fork_detach, info_checkpoints_command): Adjust.
9430         (_initialize_linux_fork): No longer call init_fork_list.
9431
9432 2019-03-06  Pedro Alves  <palves@redhat.com>
9433
9434         * linux-fork.c (new_fork): New, split out of ...
9435         (add_fork): ... this.  Return void.  Move "first fork" special
9436         case from here, to ...
9437         (checkpoint_command): ... here.
9438         * linux-linux.h (add_fork): Return void.
9439
9440 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9441
9442         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9443
9444 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9445             Chris January  <chris.january@arm.com>
9446             David Lecomber  <david.lecomber@arm.com>
9447
9448         * f-exp.y: New token, UNOP_INTRINSIC.
9449         (exp): New pattern using UNOP_INTRINSIC token.
9450         (f77_keywords): Add 'abs' keyword.
9451         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9452         (value_from_host_double): New function.
9453         (evaluate_subexp_f): Support UNOP_ABS.
9454
9455 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9456
9457         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9458         types.
9459
9460 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9461
9462         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9463         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9464         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9465
9466 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9467
9468         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9469
9470 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9471             Chris January  <chris.january@arm.com>
9472
9473         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9474         * f-exp.y: Define 'KIND' token.
9475         (exp): New pattern for KIND expressions.
9476         (ptype): Handle types with a kind extension.
9477         (direct_abs_decl): Extend to spot kind extensions.
9478         (f77_keywords): Add 'kind' to the list.
9479         (push_kind_type): New function.
9480         (convert_to_kind_type): New function.
9481         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9482         * parse.c (operator_length_standard): Likewise.
9483         * parser-defs.h (enum type_pieces): Add tp_kind.
9484         * std-operator.def: Add UNOP_KIND.
9485
9486 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9487
9488         * f-exp.y (f_parse): Set yydebug.
9489
9490 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9491
9492         * f-lang.c (evaluate_subexp_f): New function.
9493         (exp_descriptor_f): New global.
9494         (f_language_defn): Use exp_descriptor_f instead of
9495         exp_descriptor_standard.
9496
9497 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9498
9499         * f-exp.y (struct token): Add comments.
9500         (dot_ops): Remove uppercase versions and the end marker.
9501         (f77_keywords): Likewise.
9502         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9503         entries in the dot_ops array are case insensitive, and use
9504         strncasecmp to compare strings.  Also some whitespace cleanup in
9505         this area.  Similar for the f77_keywords array, except entries in
9506         this list might be case sensitive.
9507
9508 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9509
9510         * f-exp.y (struct f77_boolean_val): Add comments.
9511         (boolean_values): Remove uppercase versions, and end marker.
9512         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9513         and use strncasecmp to achieve case insensitivity.  Additionally,
9514         perform whitespace cleanup around this code.
9515
9516 2019-03-06  Tom Tromey  <tromey@adacore.com>
9517
9518         * remote-sim.c (gdbsim_target_open): Use result of
9519         gdb_argv::release.
9520
9521 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9522         Dirk Schubert  <dirk.schubert@arm.com>
9523         Chris January  <chris.january@arm.com>
9524
9525         * eval.c (evaluate_subexp_standard): Call Fortran argument
9526         wrapping logic.
9527         * f-lang.c (struct value): A value which can be passed into a
9528         Fortran function call.
9529         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9530         where appropriate.
9531         (struct type): Value ready for a Fortran function call.
9532         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9533         is needed.
9534         * f-lang.h (fortran_argument_convert): Declaration.
9535         (fortran_preserve_arg_pointer): Declaration.
9536         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9537
9538 2019-03-05  Tom Tromey  <tromey@adacore.com>
9539
9540         * python/py-prettyprint.c (print_string_repr): Remove #if.
9541         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9542
9543 2019-03-05  Tom Tromey  <tromey@adacore.com>
9544
9545         * target.c (the_dummy_target): Move later.  Change type to
9546         "dummy_target".
9547         (initialize_targets): Don't initialize the_dummy_target.
9548
9549 2019-03-05  Tom Tromey  <tromey@adacore.com>
9550
9551         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9552         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9553
9554 2019-03-05  Tom Tromey  <tromey@adacore.com>
9555
9556         * windows-nat.c (windows_nat_target::attach)
9557         (windows_nat_target::detach): Don't call gdb_flush.
9558         * valprint.c (generic_val_print, val_print, val_print_string):
9559         Don't call gdb_flush.
9560         * utils.c (defaulted_query): Don't call gdb_flush.
9561         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9562         * target.c (target_announce_detach): Don't call gdb_flush.
9563         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9564         * remote.c (extended_remote_target::attach): Don't call
9565         gdb_flush.
9566         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9567         * printcmd.c (do_examine): Don't call gdb_flush.
9568         (info_display_command): Don't call gdb_flush.
9569         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9570         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9571         * memattr.c (info_mem_command): Don't call gdb_flush.
9572         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9573         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9574         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9575         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9576         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9577         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9578         (gnu_nat_target::detach): Don't call gdb_flush.
9579         * f-valprint.c (f_val_print): Don't call gdb_flush.
9580         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9581         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9582         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9583         gdb_flush.
9584         * c-valprint.c (c_val_print): Don't call gdb_flush.
9585         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9586
9587 2019-03-05  Tom Tromey  <tromey@adacore.com>
9588
9589         * varobj.c (update_dynamic_varobj_children): Update.
9590         (install_default_visualizer): Use reset, not release.
9591         * value.c (set_internalvar): Update.
9592         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9593         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9594         ATTRIBUTE_UNUSED_RESULT.
9595
9596 2019-03-05  Tom Tromey  <tromey@adacore.com>
9597
9598         * remote.c (class scoped_remote_fd) <release>: Add
9599         ATTRIBUTE_UNUSED_RESULT.
9600
9601 2019-03-05  Tom Tromey  <tromey@adacore.com>
9602
9603         * macroexp.c (struct macro_buffer) <release>: Add
9604         ATTRIBUTE_UNUSED_RESULT.
9605
9606 2019-03-05  Tom Tromey  <tromey@adacore.com>
9607
9608         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9609         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9610         ATTRIBUTE_UNUSED_RESULT.
9611
9612 2019-03-05  Tom Tromey  <tromey@adacore.com>
9613
9614         * common/scoped_fd.h (class scoped_fd) <release>: Add
9615         ATTRIBUTE_UNUSED_RESULT.
9616
9617 2019-03-05  Tom Tromey  <tromey@adacore.com>
9618
9619         * parser-defs.h (struct parser_state) <release>: Add
9620         ATTRIBUTE_UNUSED_RESULT.
9621
9622 2019-03-05  Tom Tromey  <tromey@adacore.com>
9623
9624         * utils.h (class gdb_argv) <release>: Add
9625         ATTRIBUTE_UNUSED_RESULT.
9626         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9627
9628 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9629
9630         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9631         for-loop range, to avoid compiler warnings.
9632
9633         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9634         avoid compiler warnings about unused variables.
9635
9636         * NEWS: Mention end of support for native debugging on MS-Windows
9637         before XP.
9638
9639         PR gdb/24292
9640         * common/netstuff.c:
9641         * gdbserver/gdbreplay.c
9642         * gdbserver/remote-utils.c:
9643         * ser-tcp.c:
9644         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9645         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9646         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9647         'getaddrinfo' and 'freeaddrinfo' were not available before
9648         Windows XP, and mingw.org's MinGW headers by default define
9649         _WIN32_WINNT to 0x500.
9650
9651 2019-03-01  Gary Benson <gbenson@redhat.com>
9652
9653         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9654
9655 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9656             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9657
9658         PR gdb/8527
9659         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9660         set_sigint_trap, clear_sigint_trap.
9661
9662 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9663
9664         * target.c (target_detach): Clear the regcache and the
9665         frame cache.
9666
9667 2019-02-27  Pedro Alves  <palves@redhat.com>
9668
9669         * utils.c (set_screen_size): When we cap the height/width sizes,
9670         tweak the corresponding command variable to show "unlimited":
9671
9672 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9673             Pedro Alves  <palves@redhat.com>
9674
9675         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9676         before calling rl_set_screen_size.
9677
9678 2019-02-27  Tom Tromey  <tromey@adacore.com>
9679
9680         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9681         define.
9682         * python/py-value.c: Remove Python 2.4 workaround.
9683         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9684         workaround.
9685         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9686         Python 2.4 workaround.
9687         * python/python-internal.h: Remove Python 2.4 comment.
9688         (Py_ssize_t): Don't define.
9689         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9690         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9691         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9692         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9693         * python/python.c (do_start_initialization): Remove Python 2.4
9694         workaround.
9695         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9696         (print_children): Remove Python 2.4 workaround.
9697         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9698         workaround.
9699         (CHARBUFFERPROC_NAME): Remove.
9700         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9701         Python 2.4 workaround.
9702
9703 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9704
9705         * NEWS: Note minimum Python version.
9706
9707 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9708
9709         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9710         code from these functions.  Remove corresponding ifdefs.  Use
9711         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9712         Remove gotos and target of gotos.
9713         (infpy_search_memory): Likewise.
9714
9715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9716
9717         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9718         (hppa_gdbarch_init): Don't register deleted functions with
9719         gdbarch.
9720
9721 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9722
9723         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9724         (h8300_unwind_sp): Delete.
9725         (h8300_dummy_id): Delete.
9726         (h8300_gdbarch_init): Don't register deleted functions with
9727         gdbarch.
9728
9729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9730
9731         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9732         (ft32_unwind_pc): Delete.
9733         (ft32_unwind_sp): Delete.
9734         (ft32_gdbarch_init): Don't register deleted functions with
9735         gdbarch.
9736
9737 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9738
9739         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9740         (frv_unwind_pc): Delete.
9741         (frv_unwind_sp): Delete.
9742         (frv_gdbarch_init): Don't register deleted functions with
9743         gdbarch.
9744
9745 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9746
9747         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9748         (riscv_unwind_pc): Delete.
9749         (riscv_unwind_sp): Delete.
9750         (riscv_gdbarch_init): Don't register deleted functions with
9751         gdbarch.
9752
9753 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9754
9755         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9756         (csky_unwind_pc): Delete.
9757         (csky_unwind_sp): Delete.
9758         (csky_gdbarch_init): Don't register deleted functions with
9759         gdbarch.
9760
9761 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9762
9763         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9764         (cris_unwind_pc): Delete.
9765         (cris_unwind_sp): Delete.
9766         (cris_gdbarch_init): Don't register deleted functions with
9767         gdbarch.
9768
9769 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9770
9771         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9772         (bfin_unwind_pc): Delete.
9773         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9774
9775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9776
9777         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9778         (arm_unwind_pc): Delete.
9779         (arm_unwind_sp): Delete.
9780         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9781
9782 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9783
9784         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9785         (arc_unwind_pc): Delete.
9786         (arc_unwind_sp): Delete.
9787         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9788
9789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9790
9791         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9792         (alpha_unwind_pc): Delete.
9793         (alpha_gdbarch_init): Don't register deleted functions with
9794         gdbarch.
9795
9796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9797
9798         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9799         (aarch64_unwind_pc): Delete.
9800         (aarch64_unwind_sp): Delete.
9801         (aarch64_gdbarch_init): Don't register deleted functions with
9802         gdbarch.
9803
9804 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9805
9806         * gdbtypes.c (type_align): Don't consider static members when
9807         computing structure alignment.
9808
9809 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9810
9811         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9812         return 0 for other types.
9813         * arch-utils.c (default_type_align): Always return 0.
9814         * gdbarch.h: Regenerate.
9815         * gdbarch.sh (type_align): Extend comment.
9816         * gdbtypes.c (type_align): Add additional comments, always call
9817         gdbarch_type_align before applying the default rules.
9818         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9819         generic code will then apply a suitable default.
9820         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9821         types, return 0 for other types.
9822
9823 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9824
9825         * NEWS: Create a new section for the next release branch.
9826         Rename the section of the current branch, now that it has
9827         been cut.
9828
9829 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9830
9831         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9832         * version.in: Bump version to 8.3.50.DATE-git.
9833
9834 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9835
9836         * aix-thread.c (ptid_cmp): Remove unused variable.
9837         (get_signaled_thread): Likewise.
9838         (store_regs_user_thread): Likewise.
9839         (store_regs_kernel_thread): Likewise.
9840         (fetch_regs_kernel_thread): Remove shadowed variable.
9841
9842 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9843
9844         * features/riscv/32bit-cpu.xml: Add register numbers.
9845         * features/riscv/32bit-fpu.c: Regenerate.
9846         * features/riscv/32bit-fpu.xml: Add register numbers.
9847         * features/riscv/64bit-cpu.xml: Add register numbers.
9848         * features/riscv/64bit-fpu.c: Regenerate.
9849         * features/riscv/64bit-fpu.xml: Add register numbers.
9850
9851 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9852
9853         * NEWS: Mention two argument form of gdb.Value constructor.
9854         * python/py-value.c (convert_buffer_and_type_to_value): New
9855         function.
9856         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9857         Add support for handling an optional second argument.  Call
9858         convert_buffer_and_type_to_value as appropriate.
9859         * python/python-internal.h (Py_buffer_deleter): New struct.
9860         (Py_buffer_up): New typedef.
9861
9862 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9863
9864         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9865         instead of releasing ownership.
9866
9867 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9868
9869         * dwarf2read.c (open_and_init_dwp_file): Call
9870         elf_numsections instead of bfd_count_sections to initialize
9871         dwp_file->num_sections.
9872
9873 2019-02-25  Tom Tromey  <tromey@adacore.com>
9874
9875         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9876
9877 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9878
9879         * gcore.in: Add '--readnever' option when invoking GDB.
9880
9881 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9882
9883         * MAINTAINERS: Update my email address.
9884
9885 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9886
9887         * build-id.c (build_id_to_debug_bfd_1): New function.
9888         (build_id_to_debug_bfd): Look for separate debug file in
9889         sysroot.
9890
9891 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9892
9893         * gdbarch.sh: Update the copyright year range that is placed into
9894         generated files.
9895
9896 2019-02-22  Keith Seitz  <keiths@redhat.com>
9897
9898         PR symtab/23853
9899         * linespec.c (create_sals_line_offset): Search for the default
9900         symtab's filename instead of its fullname.
9901
9902 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9903
9904         * NEWS: Update style defaults.
9905
9906 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9907
9908         * main.c (captured_main_1): Disable styling in batch mode.
9909
9910 2019-02-20  Tom Tromey  <tom@tromey.com>
9911
9912         * symtab.c (symtab_symbol_info): Fix typos.
9913
9914 2019-02-20  Tom Tromey  <tromey@adacore.com>
9915
9916         * findcmd.c (_initialize_mem_search): Use upper case for
9917         metasyntactic variables.
9918
9919 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9920
9921         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9922         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9923
9924 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9925
9926         * top.h (source_file_name): Change to std::string.
9927         * top.c (source_file_name): Likewise.
9928         (command_line_input): Adjust.
9929         * cli/cli-script.c (script_from_file): Adjust.
9930
9931 2019-02-19  Tom Tromey  <tromey@adacore.com>
9932
9933         * ravenscar-thread.c
9934         (ravenscar_thread_target::update_thread_list): Don't call
9935         ada_build_task_list.
9936         * ada-lang.h (ada_build_task_list): Don't declare.
9937         * ada-tasks.c (struct ada_tasks_inferior_data)
9938         <task_list_valid_p>: Now bool.
9939         (read_known_tasks, ada_task_list_changed)
9940         (ada_tasks_invalidate_inferior_data): Update.
9941         (read_known_tasks_array): Return bool.
9942         (read_known_tasks_list): Likewise.
9943         (read_known_tasks): Return void.
9944         (ada_build_task_list): Now static.
9945
9946 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9947
9948         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9949         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9950
9951 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9952
9953         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9954         variant for ada_tasks_pspace_data_handle and
9955         ada_tasks_inferior_data_handle.
9956         (ada_tasks_pspace_data_cleanup): New function.
9957         (ada_tasks_inferior_data_cleanup): New function.
9958
9959 2019-02-17  Tom Tromey  <tom@tromey.com>
9960
9961         * macrotab.h (macro_source_fullname): Return a std::string.
9962         * macrotab.c (macro_include, check_for_redefinition)
9963         (macro_undef, macro_lookup_definition, foreach_macro)
9964         (foreach_macro_in_scope): Update.
9965         (macro_source_fullname): Return a std::string.
9966         * macrocmd.c (show_pp_source_pos): Update.
9967
9968 2019-02-17  Tom Tromey  <tom@tromey.com>
9969
9970         * macrocmd.c (show_pp_source_pos): Style the file names.
9971
9972 2019-02-17  Tom Tromey  <tom@tromey.com>
9973
9974         PR tui/24197:
9975         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9976
9977 2019-02-17  Tom Tromey  <tom@tromey.com>
9978
9979         * ada-lang.c (user_select_syms): Use filtered printing.
9980         * utils.c (wrap_style): New global.
9981         (desired_style): Remove.
9982         (emit_style_escape): Add stream parameter.
9983         (set_output_style, reset_terminal_style, prompt_for_continue):
9984         Update.
9985         (flush_wrap_buffer): Only flush gdb_stdout.
9986         (wrap_here): Set wrap_style.
9987         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9988         treat escape sequences as a character.  Change when wrap buffer is
9989         flushed.
9990         (fputs_styled): Do not set the output style when the default is
9991         requested.
9992         * ui-style.h (struct ui_file_style) <is_default>: New method.
9993         * source.c (print_source_lines_base): Emit escape sequences in one
9994         piece.
9995
9996 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9997
9998         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9999         integers and enumeration types.
10000
10001 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10002
10003         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10004         instead of lookup_symbol_in_language
10005         (do_exact_match): New function.
10006         (ada_get_symbol_name_matcher): Return do_exact_match when
10007         doing a verbatim match.
10008
10009 2019-02-15  Tom Tromey  <tromey@adacore.com>
10010
10011         * ravenscar-thread.c (ravenscar_thread_target::resume)
10012         (ravenscar_thread_target::wait): Special case wildcard requests.
10013
10014 2019-02-15  Tom Tromey  <tromey@adacore.com>
10015
10016         * ravenscar-thread.c (base_ptid): Remove.
10017         (struct ravenscar_thread_target) <close>: New method.
10018         <m_base_ptid>: New member.
10019         <update_inferior_ptid, active_task, task_is_currently_active,
10020         runtime_initialized>: Declare methods.
10021         <ravenscar_thread_target>: Add constructor.
10022         (ravenscar_thread_target::task_is_currently_active)
10023         (ravenscar_thread_target::update_inferior_ptid)
10024         (ravenscar_runtime_initialized): Rename.  Now methods.
10025         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10026         (ravenscar_thread_target::update_thread_list): Update.
10027         (ravenscar_thread_target::active_task): Now method.
10028         (ravenscar_thread_target::store_registers)
10029         (ravenscar_thread_target::prepare_to_store)
10030         (ravenscar_thread_target::prepare_to_store)
10031         (ravenscar_thread_target::mourn_inferior): Update.
10032         (ravenscar_inferior_created): Use "new" to create target.
10033         (ravenscar_thread_target::get_ada_task_ptid): Update.
10034         (_initialize_ravenscar): Don't initialize base_ptid.
10035         (ravenscar_ops): Remove global.
10036
10037 2019-02-15  Tom Tromey  <tromey@adacore.com>
10038
10039         * target.h (push_target): Declare new overload.
10040         * target.c (push_target): New overload, taking an rvalue reference.
10041         * remote.c (remote_target::open_1): Use push_target overload.
10042         * corelow.c (core_target_open): Use push_target overload.
10043
10044 2019-02-15  Tom Tromey  <tromey@adacore.com>
10045
10046         * ravenscar-thread.c (is_ravenscar_task)
10047         (ravenscar_task_is_currently_active): Return bool.
10048         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10049         (_initialize_ravenscar): Remove "(void)".
10050         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10051         Return bool.
10052
10053 2019-02-15  Tom Tromey  <tromey@adacore.com>
10054
10055         * ravenscar-thread.c (ravenscar_runtime_initializer)
10056         (has_ravenscar_runtime, get_running_thread_id)
10057         (ravenscar_thread_target::resume): Fix indentation.
10058
10059 2019-02-15  Tom Tromey  <tromey@adacore.com>
10060
10061         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10062         from ravenscar_arch_ops.
10063         (sparc_ravenscar_ops::fetch_registers)
10064         (sparc_ravenscar_ops::store_registers): Now methods.
10065         (sparc_ravenscar_prepare_to_store): Remove.
10066         (sparc_ravenscar_ops): Redefine.
10067         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10068         methods and destructor.  Remove members.
10069         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10070         (ravenscar_thread_target::store_registers)
10071         (ravenscar_thread_target::prepare_to_store): Update.
10072         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10073         Remove.
10074         (struct ppc_ravenscar_powerpc_ops): Derive from
10075         ravenscar_arch_ops.
10076         (ppc_ravenscar_powerpc_ops::fetch_registers)
10077         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10078         (ppc_ravenscar_powerpc_ops): Redefine.
10079         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10080         (ppc_ravenscar_e500_ops::fetch_registers)
10081         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10082         (ppc_ravenscar_e500_ops): Redefine.
10083         * aarch64-ravenscar-thread.c
10084         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10085         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10086         (aarch64_ravenscar_fetch_registers)
10087         (aarch64_ravenscar_store_registers): Now methods.
10088         (aarch64_ravenscar_ops): Redefine.
10089
10090 2019-02-15  Tom Tromey  <tromey@adacore.com>
10091
10092         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10093         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10094         (ravenscar_thread_target::stopped_by_watchpoint)
10095         (ravenscar_thread_target::stopped_data_address)
10096         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10097
10098 2019-02-15  Tom Tromey  <tromey@adacore.com>
10099
10100         * ravenscar-thread.c: Fix some typos.
10101
10102 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10103             Tom Tromey  <tromey@adacore.com>
10104
10105         * ada-lang.c (ada_exception_sal): Change addr_string to a
10106         std::string.
10107         (create_ada_exception_catchpoint): Update.
10108
10109 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10110             Tom Tromey  <tromey@adacore.com>
10111
10112         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10113         (bp_location_ops): Remove.
10114         (base_breakpoint_allocate_location): Update.
10115         (free_bp_location): Update.
10116         * ada-lang.c (class ada_catchpoint_location)
10117         <ada_catchpoint_location>: Remove ops parameter.
10118         (ada_catchpoint_location_dtor): Remove.
10119         (ada_catchpoint_location_ops): Remove.
10120         (allocate_location_exception): Update.
10121         * breakpoint.h (struct bp_location_ops): Remove.
10122         (class bp_location) <bp_location>: Remove bp_location_ops
10123         parameter.
10124         <~bp_location>: Add destructor.
10125         <ops>: Remove.
10126
10127 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10128             Pedro Alves  <palves@redhat.com>
10129
10130         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10131         'PATH_MAX'.
10132
10133 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10134             Samuel Thibault  <samuel.thibault@gnu.org>
10135             Thomas Schwinge  <thomas@codesourcery.com>
10136
10137         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10138         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10139
10140 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10141
10142         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10143         (check_empty): Use "const char *".
10144
10145         * gnu-nat.c (gnu_nat_target::detach): Instead of
10146         'detach_inferior (pid)' call
10147         'detach_inferior (find_inferior_pid (pid))'.
10148
10149         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10150         'nat/fork-inferior.o'.
10151         * gnu-nat.c: #include "nat/fork-inferior.h".
10152
10153         * gnu-nat.c (gnu_nat_target::detach): Instead of
10154         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10155         * gnu-nat.h: #include "inf-child.h".
10156         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10157         'i386_gnu_nat_target::fetch_registers'.
10158         (gnu_store_registers): Rename/move to
10159         'i386_gnu_nat_target::store_registers'.
10160
10161         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10162         * gnu-nat.h (mach_thread_info): New function.
10163         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10164
10165         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10166
10167 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10168
10169         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10170
10171 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10172
10173         * windows-nat.c (windows_add_thread): Add new parameter
10174         "main_thread_p" with default value set to false.  Update
10175         function documentation as well as all callers.
10176         (windows_delete_thread): Likewise.
10177         (fake_create_process): Update call to windows_add_thread.
10178         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10179         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10180         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10181         call to windows_delete_thread.
10182
10183 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10184
10185         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10186
10187 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10188
10189         * symfile.c (find_separate_debug_file): Use canonical path of
10190         sysroot with child_path instead of gdb_sysroot if it is valid.
10191
10192 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10193
10194         * symfile.c (find_separate_debug_file): Use child_path to
10195         determine if an object file is under a sysroot.
10196
10197 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10198
10199         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10200         unittests/child-path-selftests.c.
10201         * common/pathstuff.c (child_path): New function.
10202         * common/pathstuff.h (child_path): New prototype.
10203         * unittests/child-path-selftests.c: New file.
10204
10205 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10206
10207         * symfile.c (find_separate_debug_file): Look for separate debug
10208         files in debug directories under the sysroot.
10209
10210 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10211
10212         * symtab.h (struct minimal_symbol data_p): New const method.
10213         (struct minimal_symbol text_p): Likewise.
10214         * symtab.c (output_source_filename): Use file name style
10215         to print file name.
10216         (print_symbol_info): Likewise.
10217         (print_msymbol_info): Use address style to print addresses.
10218         Use function name style to print executable text symbols.
10219         (expand_symtab_containing_pc): Use data_p.
10220         (find_pc_sect_compunit_symtab): Likewise.
10221
10222 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10223
10224         * breakpoint.c (describe_other_breakpoints): Use address style
10225         to print addresses.
10226         (say_where): Likewise.
10227
10228 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10229
10230         * ada-typeprint.c (print_func_type): Print function name
10231         style to print function name.
10232         * c-typeprint.c (c_print_type_1): Likewise.
10233
10234 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10235
10236         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10237         for execve.
10238
10239 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10240
10241         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10242         type_stack.
10243
10244 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10245
10246         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10247         TYPE_CODE_REF types.
10248
10249 2019-02-08  Jim Wilson  <jimw@sifive.com>
10250
10251         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10252         (riscv_linux_fregset): New.
10253         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10254
10255 2019-02-07  Tom Tromey  <tom@tromey.com>
10256
10257         * thread.c (thread_cancel_execution_command): Update.
10258         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10259         methods.
10260         (struct thread_fsm_ops): Remove.
10261         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10262         (thread_fsm_should_stop, thread_fsm_return_value)
10263         (thread_fsm_set_finished, thread_fsm_finished_p)
10264         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10265         Don't declare.
10266         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10267         * infrun.c (clear_proceed_status_thread)
10268         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10269         (print_stop_event): Update.
10270         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10271         Add constructor.
10272         (step_command_fsm_ops): Remove.
10273         (new_step_command_fsm): Remove.
10274         (step_1): Update.
10275         (step_command_fsm::should_stop): Rename from
10276         step_command_fsm_should_stop.
10277         (step_command_fsm::clean_up): Rename from
10278         step_command_fsm_clean_up.
10279         (step_command_fsm::do_async_reply_reason): Rename from
10280         step_command_fsm_async_reply_reason.
10281         (struct until_next_fsm): Inherit from thread_fsm.  Add
10282         constructor.
10283         (until_next_fsm_ops): Remove.
10284         (new_until_next_fsm): Remove.
10285         (until_next_fsm::should_stop): Rename from
10286         until_next_fsm_should_stop.
10287         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10288         (until_next_fsm::do_async_reply_reason): Rename from
10289         until_next_fsm_async_reply_reason.
10290         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10291         constructor.  Change type of breakpoint.
10292         (finish_command_fsm_ops): Remove.
10293         (new_finish_command_fsm): Remove.
10294         (finish_command_fsm::should_stop): Rename from
10295         finish_command_fsm_should_stop.
10296         (finish_command_fsm::clean_up): Rename from
10297         finish_command_fsm_clean_up.
10298         (finish_command_fsm::return_value): Rename from
10299         finish_command_fsm_return_value.
10300         (finish_command_fsm::do_async_reply_reason): Rename from
10301         finish_command_fsm_async_reply_reason.
10302         (finish_command): Update.
10303         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10304         Add constructor.
10305         (call_thread_fsm_ops): Remove.
10306         (call_thread_fsm::call_thread_fsm): Rename from
10307         new_call_thread_fsm.
10308         (call_thread_fsm::should_stop): Rename from
10309         call_thread_fsm_should_stop.
10310         (call_thread_fsm::should_notify_stop): Rename from
10311         call_thread_fsm_should_notify_stop.
10312         (run_inferior_call, call_function_by_hand_dummy): Update.
10313         * cli/cli-interp.c (should_print_stop_to_console): Update.
10314         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10315         Add constructor.  Change type of location_breakpoint,
10316         caller_breakpoint.
10317         (until_break_fsm_ops): Remove.
10318         (new_until_break_fsm): Remove.
10319         (until_break_fsm::should_stop): Rename from
10320         until_break_fsm_should_stop.
10321         (until_break_fsm::clean_up): Rename from
10322         until_break_fsm_clean_up.
10323         (until_break_fsm::do_async_reply_reason): Rename from
10324         until_break_fsm_async_reply_reason.
10325         (until_break_command): Update.
10326         * thread-fsm.c: Remove.
10327         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10328
10329 2019-02-07  Tom Tromey  <tom@tromey.com>
10330
10331         * yy-remap.h: Add include guard.
10332         * xtensa-tdep.h: Add include guard.
10333         * xcoffread.h: Rename include guard.
10334         * varobj-iter.h: Add include guard.
10335         * tui/tui.h: Rename include guard.
10336         * tui/tui-winsource.h: Rename include guard.
10337         * tui/tui-wingeneral.h: Rename include guard.
10338         * tui/tui-windata.h: Rename include guard.
10339         * tui/tui-win.h: Rename include guard.
10340         * tui/tui-stack.h: Rename include guard.
10341         * tui/tui-source.h: Rename include guard.
10342         * tui/tui-regs.h: Rename include guard.
10343         * tui/tui-out.h: Rename include guard.
10344         * tui/tui-layout.h: Rename include guard.
10345         * tui/tui-io.h: Rename include guard.
10346         * tui/tui-hooks.h: Rename include guard.
10347         * tui/tui-file.h: Rename include guard.
10348         * tui/tui-disasm.h: Rename include guard.
10349         * tui/tui-data.h: Rename include guard.
10350         * tui/tui-command.h: Rename include guard.
10351         * tic6x-tdep.h: Add include guard.
10352         * target/waitstatus.h: Rename include guard.
10353         * target/wait.h: Rename include guard.
10354         * target/target.h: Rename include guard.
10355         * target/resume.h: Rename include guard.
10356         * target-float.h: Rename include guard.
10357         * stabsread.h: Add include guard.
10358         * rs6000-tdep.h: Add include guard.
10359         * riscv-fbsd-tdep.h: Add include guard.
10360         * regformats/regdef.h: Rename include guard.
10361         * record.h: Rename include guard.
10362         * python/python.h: Rename include guard.
10363         * python/python-internal.h: Rename include guard.
10364         * python/py-stopevent.h: Rename include guard.
10365         * python/py-ref.h: Rename include guard.
10366         * python/py-record.h: Rename include guard.
10367         * python/py-record-full.h: Rename include guard.
10368         * python/py-record-btrace.h: Rename include guard.
10369         * python/py-instruction.h: Rename include guard.
10370         * python/py-events.h: Rename include guard.
10371         * python/py-event.h: Rename include guard.
10372         * procfs.h: Add include guard.
10373         * proc-utils.h: Add include guard.
10374         * p-lang.h: Add include guard.
10375         * or1k-tdep.h: Rename include guard.
10376         * observable.h: Rename include guard.
10377         * nto-tdep.h: Rename include guard.
10378         * nat/x86-linux.h: Rename include guard.
10379         * nat/x86-linux-dregs.h: Rename include guard.
10380         * nat/x86-gcc-cpuid.h: Add include guard.
10381         * nat/x86-dregs.h: Rename include guard.
10382         * nat/x86-cpuid.h: Rename include guard.
10383         * nat/ppc-linux.h: Rename include guard.
10384         * nat/mips-linux-watch.h: Rename include guard.
10385         * nat/linux-waitpid.h: Rename include guard.
10386         * nat/linux-ptrace.h: Rename include guard.
10387         * nat/linux-procfs.h: Rename include guard.
10388         * nat/linux-osdata.h: Rename include guard.
10389         * nat/linux-nat.h: Rename include guard.
10390         * nat/linux-namespaces.h: Rename include guard.
10391         * nat/linux-btrace.h: Rename include guard.
10392         * nat/glibc_thread_db.h: Rename include guard.
10393         * nat/gdb_thread_db.h: Rename include guard.
10394         * nat/gdb_ptrace.h: Rename include guard.
10395         * nat/fork-inferior.h: Rename include guard.
10396         * nat/amd64-linux-siginfo.h: Rename include guard.
10397         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10398         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10399         * nat/aarch64-linux.h: Rename include guard.
10400         * nat/aarch64-linux-hw-point.h: Rename include guard.
10401         * mn10300-tdep.h: Add include guard.
10402         * mips-linux-tdep.h: Add include guard.
10403         * mi/mi-parse.h: Rename include guard.
10404         * mi/mi-out.h: Rename include guard.
10405         * mi/mi-main.h: Rename include guard.
10406         * mi/mi-interp.h: Rename include guard.
10407         * mi/mi-getopt.h: Rename include guard.
10408         * mi/mi-console.h: Rename include guard.
10409         * mi/mi-common.h: Rename include guard.
10410         * mi/mi-cmds.h: Rename include guard.
10411         * mi/mi-cmd-break.h: Rename include guard.
10412         * m2-lang.h: Add include guard.
10413         * location.h: Rename include guard.
10414         * linux-record.h: Rename include guard.
10415         * linux-nat.h: Add include guard.
10416         * linux-fork.h: Add include guard.
10417         * i386-darwin-tdep.h: Rename include guard.
10418         * hppa-linux-offsets.h: Add include guard.
10419         * guile/guile.h: Rename include guard.
10420         * guile/guile-internal.h: Rename include guard.
10421         * gnu-nat.h: Rename include guard.
10422         * gdb-stabs.h: Rename include guard.
10423         * frv-tdep.h: Add include guard.
10424         * f-lang.h: Add include guard.
10425         * event-loop.h: Add include guard.
10426         * darwin-nat.h: Rename include guard.
10427         * cp-abi.h: Rename include guard.
10428         * config/sparc/nm-sol2.h: Rename include guard.
10429         * config/nm-nto.h: Rename include guard.
10430         * config/nm-linux.h: Add include guard.
10431         * config/i386/nm-i386gnu.h: Rename include guard.
10432         * config/djgpp/nl_types.h: Rename include guard.
10433         * config/djgpp/langinfo.h: Rename include guard.
10434         * compile/gcc-cp-plugin.h: Add include guard.
10435         * compile/gcc-c-plugin.h: Add include guard.
10436         * compile/compile.h: Rename include guard.
10437         * compile/compile-object-run.h: Rename include guard.
10438         * compile/compile-object-load.h: Rename include guard.
10439         * compile/compile-internal.h: Rename include guard.
10440         * compile/compile-cplus.h: Rename include guard.
10441         * compile/compile-c.h: Rename include guard.
10442         * common/xml-utils.h: Rename include guard.
10443         * common/x86-xstate.h: Rename include guard.
10444         * common/version.h: Rename include guard.
10445         * common/vec.h: Rename include guard.
10446         * common/tdesc.h: Rename include guard.
10447         * common/selftest.h: Rename include guard.
10448         * common/scoped_restore.h: Rename include guard.
10449         * common/scoped_mmap.h: Rename include guard.
10450         * common/scoped_fd.h: Rename include guard.
10451         * common/safe-iterator.h: Rename include guard.
10452         * common/run-time-clock.h: Rename include guard.
10453         * common/refcounted-object.h: Rename include guard.
10454         * common/queue.h: Rename include guard.
10455         * common/ptid.h: Rename include guard.
10456         * common/print-utils.h: Rename include guard.
10457         * common/preprocessor.h: Rename include guard.
10458         * common/pathstuff.h: Rename include guard.
10459         * common/observable.h: Rename include guard.
10460         * common/netstuff.h: Rename include guard.
10461         * common/job-control.h: Rename include guard.
10462         * common/host-defs.h: Rename include guard.
10463         * common/gdb_wait.h: Rename include guard.
10464         * common/gdb_vecs.h: Rename include guard.
10465         * common/gdb_unlinker.h: Rename include guard.
10466         * common/gdb_unique_ptr.h: Rename include guard.
10467         * common/gdb_tilde_expand.h: Rename include guard.
10468         * common/gdb_sys_time.h: Rename include guard.
10469         * common/gdb_string_view.h: Rename include guard.
10470         * common/gdb_splay_tree.h: Rename include guard.
10471         * common/gdb_setjmp.h: Rename include guard.
10472         * common/gdb_ref_ptr.h: Rename include guard.
10473         * common/gdb_optional.h: Rename include guard.
10474         * common/gdb_locale.h: Rename include guard.
10475         * common/gdb_assert.h: Rename include guard.
10476         * common/filtered-iterator.h: Rename include guard.
10477         * common/filestuff.h: Rename include guard.
10478         * common/fileio.h: Rename include guard.
10479         * common/environ.h: Rename include guard.
10480         * common/common-utils.h: Rename include guard.
10481         * common/common-types.h: Rename include guard.
10482         * common/common-regcache.h: Rename include guard.
10483         * common/common-inferior.h: Rename include guard.
10484         * common/common-gdbthread.h: Rename include guard.
10485         * common/common-exceptions.h: Rename include guard.
10486         * common/common-defs.h: Rename include guard.
10487         * common/common-debug.h: Rename include guard.
10488         * common/cleanups.h: Rename include guard.
10489         * common/buffer.h: Rename include guard.
10490         * common/btrace-common.h: Rename include guard.
10491         * common/break-common.h: Rename include guard.
10492         * cli/cli-utils.h: Rename include guard.
10493         * cli/cli-style.h: Rename include guard.
10494         * cli/cli-setshow.h: Rename include guard.
10495         * cli/cli-script.h: Rename include guard.
10496         * cli/cli-interp.h: Rename include guard.
10497         * cli/cli-decode.h: Rename include guard.
10498         * cli/cli-cmds.h: Rename include guard.
10499         * charset-list.h: Add include guard.
10500         * buildsym-legacy.h: Rename include guard.
10501         * bfin-tdep.h: Add include guard.
10502         * ax.h: Rename include guard.
10503         * arm-linux-tdep.h: Add include guard.
10504         * arm-fbsd-tdep.h: Add include guard.
10505         * arch/xtensa.h: Rename include guard.
10506         * arch/tic6x.h: Add include guard.
10507         * arch/i386.h: Add include guard.
10508         * arch/arm.h: Rename include guard.
10509         * arch/arm-linux.h: Rename include guard.
10510         * arch/arm-get-next-pcs.h: Rename include guard.
10511         * arch/amd64.h: Add include guard.
10512         * arch/aarch64-insn.h: Rename include guard.
10513         * arch-utils.h: Rename include guard.
10514         * annotate.h: Add include guard.
10515         * amd64-darwin-tdep.h: Rename include guard.
10516         * aarch64-linux-tdep.h: Add include guard.
10517         * aarch64-fbsd-tdep.h: Add include guard.
10518         * aarch32-linux-nat.h: Add include guard.
10519
10520 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10521
10522         * macrotab.c (macro_define_internal): New function that
10523         factorizes macro_define_object_internal and macro_define_function
10524         code.
10525         (macro_define_object_internal): Use macro_define_internal.
10526         (macro_define_function): Likewise.
10527
10528 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10529
10530         * macrocmd.c (extract_identifier): Return
10531         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10532         callers.
10533
10534 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10535
10536         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10537
10538 2019-02-05  Tom Tromey  <tom@tromey.com>
10539
10540         * target.c (target_stack::unpush): Move assertion earlier.
10541
10542 2019-01-30  Tom Tromey  <tom@tromey.com>
10543
10544         PR python/23615:
10545         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10546         (gdbpy_parse_and_eval): Likewise.
10547         * python/python-internal.h (gdbpy_allow_threads): New class.
10548
10549 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10550
10551         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10552         (aarch64_fbsd_fpregmap): Move earlier.
10553         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10554         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10555         instead of individual calls to trad_frame_set_reg_addr.
10556         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10557         earlier.
10558         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10559         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10560         instead of individual calls to trad_frame_set_reg_addr.
10561
10562 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10563
10564         * CONTRIBUTE: Replace contribution list with wiki link.
10565
10566 2019-01-25  Tom Tromey  <tom@tromey.com>
10567
10568         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10569
10570 2019-01-25  Tom Tromey  <tom@tromey.com>
10571
10572         * xtensa-linux-nat.c: Fix common/ includes.
10573         * xml-support.h: Fix common/ includes.
10574         * xml-support.c: Fix common/ includes.
10575         * x86-linux-nat.c: Fix common/ includes.
10576         * windows-nat.c: Fix common/ includes.
10577         * varobj.h: Fix common/ includes.
10578         * varobj.c: Fix common/ includes.
10579         * value.c: Fix common/ includes.
10580         * valops.c: Fix common/ includes.
10581         * utils.c: Fix common/ includes.
10582         * unittests/xml-utils-selftests.c: Fix common/ includes.
10583         * unittests/utils-selftests.c: Fix common/ includes.
10584         * unittests/unpack-selftests.c: Fix common/ includes.
10585         * unittests/tracepoint-selftests.c: Fix common/ includes.
10586         * unittests/style-selftests.c: Fix common/ includes.
10587         * unittests/string_view-selftests.c: Fix common/ includes.
10588         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10589         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10590         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10591         * unittests/rsp-low-selftests.c: Fix common/ includes.
10592         * unittests/parse-connection-spec-selftests.c: Fix common/
10593         includes.
10594         * unittests/optional-selftests.c: Fix common/ includes.
10595         * unittests/offset-type-selftests.c: Fix common/ includes.
10596         * unittests/observable-selftests.c: Fix common/ includes.
10597         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10598         * unittests/memrange-selftests.c: Fix common/ includes.
10599         * unittests/memory-map-selftests.c: Fix common/ includes.
10600         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10601         * unittests/function-view-selftests.c: Fix common/ includes.
10602         * unittests/environ-selftests.c: Fix common/ includes.
10603         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10604         * unittests/common-utils-selftests.c: Fix common/ includes.
10605         * unittests/cli-utils-selftests.c: Fix common/ includes.
10606         * unittests/array-view-selftests.c: Fix common/ includes.
10607         * ui-file.c: Fix common/ includes.
10608         * tui/tui-io.c: Fix common/ includes.
10609         * tracepoint.h: Fix common/ includes.
10610         * tracepoint.c: Fix common/ includes.
10611         * tracefile-tfile.c: Fix common/ includes.
10612         * top.h: Fix common/ includes.
10613         * top.c: Fix common/ includes.
10614         * thread.c: Fix common/ includes.
10615         * target/waitstatus.h: Fix common/ includes.
10616         * target/waitstatus.c: Fix common/ includes.
10617         * target.h: Fix common/ includes.
10618         * target.c: Fix common/ includes.
10619         * target-memory.c: Fix common/ includes.
10620         * target-descriptions.c: Fix common/ includes.
10621         * symtab.h: Fix common/ includes.
10622         * symfile.c: Fix common/ includes.
10623         * stap-probe.c: Fix common/ includes.
10624         * spu-linux-nat.c: Fix common/ includes.
10625         * sparc-nat.c: Fix common/ includes.
10626         * source.c: Fix common/ includes.
10627         * solib.c: Fix common/ includes.
10628         * solib-target.c: Fix common/ includes.
10629         * ser-unix.c: Fix common/ includes.
10630         * ser-tcp.c: Fix common/ includes.
10631         * ser-pipe.c: Fix common/ includes.
10632         * ser-base.c: Fix common/ includes.
10633         * selftest-arch.c: Fix common/ includes.
10634         * s12z-tdep.c: Fix common/ includes.
10635         * rust-exp.y: Fix common/ includes.
10636         * rs6000-aix-tdep.c: Fix common/ includes.
10637         * riscv-tdep.c: Fix common/ includes.
10638         * remote.c: Fix common/ includes.
10639         * remote-notif.h: Fix common/ includes.
10640         * remote-fileio.h: Fix common/ includes.
10641         * remote-fileio.c: Fix common/ includes.
10642         * regcache.h: Fix common/ includes.
10643         * regcache.c: Fix common/ includes.
10644         * record-btrace.c: Fix common/ includes.
10645         * python/python.c: Fix common/ includes.
10646         * python/py-type.c: Fix common/ includes.
10647         * python/py-inferior.c: Fix common/ includes.
10648         * progspace.h: Fix common/ includes.
10649         * producer.c: Fix common/ includes.
10650         * procfs.c: Fix common/ includes.
10651         * proc-api.c: Fix common/ includes.
10652         * printcmd.c: Fix common/ includes.
10653         * ppc-linux-nat.c: Fix common/ includes.
10654         * parser-defs.h: Fix common/ includes.
10655         * osdata.c: Fix common/ includes.
10656         * obsd-nat.c: Fix common/ includes.
10657         * nat/x86-linux.c: Fix common/ includes.
10658         * nat/x86-linux-dregs.c: Fix common/ includes.
10659         * nat/x86-dregs.h: Fix common/ includes.
10660         * nat/x86-dregs.c: Fix common/ includes.
10661         * nat/ppc-linux.c: Fix common/ includes.
10662         * nat/mips-linux-watch.h: Fix common/ includes.
10663         * nat/mips-linux-watch.c: Fix common/ includes.
10664         * nat/linux-waitpid.c: Fix common/ includes.
10665         * nat/linux-ptrace.h: Fix common/ includes.
10666         * nat/linux-ptrace.c: Fix common/ includes.
10667         * nat/linux-procfs.c: Fix common/ includes.
10668         * nat/linux-personality.c: Fix common/ includes.
10669         * nat/linux-osdata.c: Fix common/ includes.
10670         * nat/linux-namespaces.c: Fix common/ includes.
10671         * nat/linux-btrace.h: Fix common/ includes.
10672         * nat/linux-btrace.c: Fix common/ includes.
10673         * nat/fork-inferior.c: Fix common/ includes.
10674         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10675         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10676         * nat/aarch64-linux.c: Fix common/ includes.
10677         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10678         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10679         * namespace.h: Fix common/ includes.
10680         * mips-linux-tdep.c: Fix common/ includes.
10681         * minsyms.c: Fix common/ includes.
10682         * mi/mi-parse.h: Fix common/ includes.
10683         * mi/mi-main.c: Fix common/ includes.
10684         * mi/mi-cmd-env.c: Fix common/ includes.
10685         * memrange.h: Fix common/ includes.
10686         * memattr.c: Fix common/ includes.
10687         * maint.h: Fix common/ includes.
10688         * maint.c: Fix common/ includes.
10689         * main.c: Fix common/ includes.
10690         * machoread.c: Fix common/ includes.
10691         * location.c: Fix common/ includes.
10692         * linux-thread-db.c: Fix common/ includes.
10693         * linux-nat.c: Fix common/ includes.
10694         * linux-fork.c: Fix common/ includes.
10695         * inline-frame.c: Fix common/ includes.
10696         * infrun.c: Fix common/ includes.
10697         * inflow.c: Fix common/ includes.
10698         * inferior.h: Fix common/ includes.
10699         * inferior.c: Fix common/ includes.
10700         * infcmd.c: Fix common/ includes.
10701         * inf-ptrace.c: Fix common/ includes.
10702         * inf-child.c: Fix common/ includes.
10703         * ia64-linux-nat.c: Fix common/ includes.
10704         * i387-tdep.c: Fix common/ includes.
10705         * i386-tdep.c: Fix common/ includes.
10706         * i386-linux-tdep.c: Fix common/ includes.
10707         * i386-linux-nat.c: Fix common/ includes.
10708         * i386-go32-tdep.c: Fix common/ includes.
10709         * i386-fbsd-tdep.c: Fix common/ includes.
10710         * i386-fbsd-nat.c: Fix common/ includes.
10711         * guile/scm-type.c: Fix common/ includes.
10712         * guile/guile.c: Fix common/ includes.
10713         * go32-nat.c: Fix common/ includes.
10714         * gnu-nat.c: Fix common/ includes.
10715         * gdbthread.h: Fix common/ includes.
10716         * gdbarch-selftests.c: Fix common/ includes.
10717         * gdb_usleep.c: Fix common/ includes.
10718         * gdb_select.h: Fix common/ includes.
10719         * gdb_bfd.c: Fix common/ includes.
10720         * gcore.c: Fix common/ includes.
10721         * fork-child.c: Fix common/ includes.
10722         * findvar.c: Fix common/ includes.
10723         * fbsd-nat.c: Fix common/ includes.
10724         * event-top.c: Fix common/ includes.
10725         * event-loop.c: Fix common/ includes.
10726         * dwarf2read.c: Fix common/ includes.
10727         * dwarf2loc.c: Fix common/ includes.
10728         * dwarf2-frame.c: Fix common/ includes.
10729         * dwarf-index-cache.c: Fix common/ includes.
10730         * dtrace-probe.c: Fix common/ includes.
10731         * disasm-selftests.c: Fix common/ includes.
10732         * defs.h: Fix common/ includes.
10733         * csky-tdep.c: Fix common/ includes.
10734         * cp-valprint.c: Fix common/ includes.
10735         * cp-support.h: Fix common/ includes.
10736         * cp-support.c: Fix common/ includes.
10737         * corelow.c: Fix common/ includes.
10738         * completer.h: Fix common/ includes.
10739         * completer.c: Fix common/ includes.
10740         * compile/compile.c: Fix common/ includes.
10741         * compile/compile-loc2c.c: Fix common/ includes.
10742         * compile/compile-cplus-types.c: Fix common/ includes.
10743         * compile/compile-cplus-symbols.c: Fix common/ includes.
10744         * command.h: Fix common/ includes.
10745         * cli/cli-dump.c: Fix common/ includes.
10746         * cli/cli-cmds.c: Fix common/ includes.
10747         * charset.c: Fix common/ includes.
10748         * build-id.c: Fix common/ includes.
10749         * btrace.h: Fix common/ includes.
10750         * btrace.c: Fix common/ includes.
10751         * breakpoint.h: Fix common/ includes.
10752         * breakpoint.c: Fix common/ includes.
10753         * ax.h:
10754         (enum agent_op): Fix common/ includes.
10755         * ax-general.c (struct aop_map): Fix common/ includes.
10756         * ax-gdb.c: Fix common/ includes.
10757         * auxv.c: Fix common/ includes.
10758         * auto-load.c: Fix common/ includes.
10759         * arm-tdep.c: Fix common/ includes.
10760         * arch/riscv.c: Fix common/ includes.
10761         * arch/ppc-linux-common.c: Fix common/ includes.
10762         * arch/i386.c: Fix common/ includes.
10763         * arch/arm.c: Fix common/ includes.
10764         * arch/arm-linux.c: Fix common/ includes.
10765         * arch/arm-get-next-pcs.c: Fix common/ includes.
10766         * arch/amd64.c: Fix common/ includes.
10767         * arch/aarch64.c: Fix common/ includes.
10768         * arch/aarch64-insn.c: Fix common/ includes.
10769         * arch-utils.c: Fix common/ includes.
10770         * amd64-windows-tdep.c: Fix common/ includes.
10771         * amd64-tdep.c: Fix common/ includes.
10772         * amd64-sol2-tdep.c: Fix common/ includes.
10773         * amd64-obsd-tdep.c: Fix common/ includes.
10774         * amd64-nbsd-tdep.c: Fix common/ includes.
10775         * amd64-linux-tdep.c: Fix common/ includes.
10776         * amd64-linux-nat.c: Fix common/ includes.
10777         * amd64-fbsd-tdep.c: Fix common/ includes.
10778         * amd64-fbsd-nat.c: Fix common/ includes.
10779         * amd64-dicos-tdep.c: Fix common/ includes.
10780         * amd64-darwin-tdep.c: Fix common/ includes.
10781         * agent.c: Fix common/ includes.
10782         * ada-lang.h: Fix common/ includes.
10783         * ada-lang.c: Fix common/ includes.
10784         * aarch64-tdep.c: Fix common/ includes.
10785
10786 2019-01-25  Tom Tromey  <tom@tromey.com>
10787
10788         * common/create-version.sh: Use common/version.h.
10789
10790 2019-01-24  Pedro Alves  <palves@redhat.com>
10791
10792         * infrun.c (signal_stop, signal_print, signal_program)
10793         (signal_catch, signal_pass): Now arrays instead of pointers.
10794         (update_signals_program_target, do_target_resume)
10795         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10796         * linux-nat.c (linux_nat_target::pass_signals)
10797         (linux_nat_target::create_inferior, linux_nat_target::attach):
10798         Adjust.
10799         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10800         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10801         * procfs.c (procfs_target::pass_signals): Adjust.
10802         * record-full.c (record_full_target::resume): Adjust.
10803         * remote.c (remote_target::pass_signals)
10804         (remote_target::program_signals): Adjust.
10805         * target-debug.h (target_debug_print_signals): Now takes a
10806         gdb::array_view as parameter.  Adjust.
10807         * target.h (target_ops) <pass_signals, program_signals>: Replace
10808         pointer and length parameters with gdb::array_view.
10809         (target_pass_signals, target_program_signals): Likewise.
10810         * target-delegates.c: Regenerate.
10811
10812 2019-01-24  Pedro Alves  <palves@redhat.com>
10813
10814         * common/forward-scope-exit.h
10815         (forward_scope_exit::forward_scope_exit): Pass arguments to
10816         m_bind_function directly, instead of creating a std::bind and
10817         copying that.
10818
10819 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10820
10821         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10822         for static members.
10823         (pass_in_v_vfp_candidate): Likewise.
10824
10825 2019-01-23  Tom Tromey  <tom@tromey.com>
10826             Pedro Alves  <palves@redhat.com>
10827
10828         * regcache.c (class regcache_invalidator): Remove.
10829         (regcache::raw_write): Use make_scope_exit.
10830
10831 2019-01-23  Tom Tromey  <tom@tromey.com>
10832
10833         * ui-out.h (class ui_out_emit_type): Update comment.
10834
10835 2019-01-23  Tom Tromey  <tom@tromey.com>
10836
10837         * infrun.c (fetch_inferior_event): Update comment.
10838
10839 2019-01-23  Tom Tromey  <tom@tromey.com>
10840             Pedro Alves  <palves@redhat.com>
10841
10842         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10843         parameter.
10844         (fetch_inferior_event): Use SCOPE_EXIT.
10845
10846
10847 2019-01-23  Tom Tromey  <tom@tromey.com>
10848             Pedro Alves  <palves@redhat.com>
10849
10850         * infrun.c (disable_thread_events): Delete.
10851         (stop_all_threads): Use SCOPE_EXIT.
10852
10853 2019-01-23  Tom Tromey  <tom@tromey.com>
10854             Pedro Alves  <palves@redhat.com>
10855
10856         * symfile.c: Include forward-scope-exit.h.
10857         (clear_symtab_users_cleanup): Replace forward declaration with
10858         a FORWARD_SCOPE_EXIT.
10859         (syms_from_objfile_1): Use the forward_scope_exit and
10860         gdb::optional instead of cleanup_function.
10861         (reread_symbols): Use the forward_scope_exit instead of
10862         cleanup_function.
10863         (clear_symtab_users_cleanup): Remove function.
10864
10865 2019-01-23  Tom Tromey  <tom@tromey.com>
10866             Pedro Alves  <palves@redhat.com>
10867
10868         * linux-nat.c: Include scope-exit.h.
10869         (cleanup_target_stop): Remove.
10870         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10871         SCOPE_EXIT.
10872
10873 2019-01-23  Tom Tromey  <tom@tromey.com>
10874             Pedro Alves  <palves@redhat.com>
10875
10876         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10877         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10878
10879 2019-01-23  Tom Tromey  <tom@tromey.com>
10880             Andrew Burgess  <andrew.burgess@embecosm.com>
10881             Pedro Alves  <palves@redhat.com>
10882
10883         * infrun.c (fetch_inferior_event): Use scope_exit.
10884         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10885         * top.c (execute_command): Use scope_exit.
10886         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10887         * utils.c (do_bpstat_clear_actions_cleanup)
10888         (make_bpstat_clear_actions_cleanup): Remove.
10889
10890 2019-01-23  Tom Tromey  <tom@tromey.com>
10891             Pedro Alves  <palves@redhat.com>
10892
10893         * infrun.c: Include "common/scope-exit.h"
10894         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10895         (wait_for_inferior): Use SCOPE_EXIT.
10896         (fetch_inferior_event): Use scope_exit.
10897
10898 2019-01-23  Tom Tromey  <tom@tromey.com>
10899             Pedro Alves  <palves@redhat.com>
10900
10901         * breakpoint.c (create_breakpoint): Remove cleanup.
10902
10903 2019-01-23  Tom Tromey  <tom@tromey.com>
10904             Andrew Burgess  <andrew.burgess@embecosm.com>
10905             Pedro Alves  <palves@redhat.com>
10906
10907 2019-01-23  Pedro Alves  <palves@redhat.com>
10908
10909         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10910
10911 2019-01-23  Pedro Alves  <palves@redhat.com>
10912             Andrew Burgess  <andrew.burgess@embecosm.com>
10913
10914         * gdbthread.h: Include "common/forward-scope-exit.h".
10915         (scoped_finish_thread_state): Redefine custom class in terms of
10916         forward_scope_exit.
10917
10918 2019-01-23  Pedro Alves  <palves@redhat.com>
10919             Andrew Burgess  <andrew.burgess@embecosm.com>
10920
10921         * common/forward-scope-exit.h: New file.
10922
10923 2019-01-23  Pedro Alves  <palves@redhat.com>
10924             Andrew Burgess  <andrew.burgess@embecosm.com>
10925             Tom Tromey  <tom@tromey.com>
10926
10927         * common/scope-exit.h: New file.
10928
10929 2019-01-23  Pedro Alves  <palves@redhat.com>
10930
10931         * common/preprocessor.h (ESC): Rename to ...
10932         (ESC_PARENS): ... this.
10933         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10934         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10935
10936 2019-01-23  Tom Tromey  <tom@tromey.com>
10937
10938         * language.h (class scoped_switch_to_sym_language_if_auto):
10939         Initialize m_lang in both cases.
10940
10941 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10942
10943         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10944         with XCNEW.
10945
10946 2019-01-22  Tom Tromey  <tom@tromey.com>
10947
10948         * corelow.c: Do not include sys/file.h.
10949
10950 2019-01-22  Tom Tromey  <tom@tromey.com>
10951
10952         * tui/tui-wingeneral.h: Include gdb_curses.h.
10953
10954 2019-01-22  Tom Tromey  <tom@tromey.com>
10955
10956         * source-cache.h (class source_cache) <get_source_lines,
10957         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10958
10959 2019-01-22  Tom Tromey  <tom@tromey.com>
10960
10961         * remote-fileio.h (struct remote_target): Declare.
10962
10963 2019-01-22  Tom Tromey  <tom@tromey.com>
10964
10965         * python/py-arch.c: Do not include py-ref.h.
10966         * python/py-bpevent.c: Do not include py-ref.h.
10967         * python/py-cmd.c: Do not include py-ref.h.
10968         * python/py-continueevent.c: Do not include py-ref.h.
10969         * python/py-event.h: Do not include py-ref.h.
10970         * python/py-evtregistry.c: Do not include py-ref.h.
10971         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10972         * python/py-frame.c: Do not include py-ref.h.
10973         * python/py-framefilter.c: Do not include py-ref.h.
10974         * python/py-function.c: Do not include py-ref.h.
10975         * python/py-infevents.c: Do not include py-ref.h.
10976         * python/py-linetable.c: Do not include py-ref.h.
10977         * python/py-objfile.c: Do not include py-ref.h.
10978         * python/py-param.c: Do not include py-ref.h.
10979         * python/py-prettyprint.c: Do not include py-ref.h.
10980         * python/py-progspace.c: Do not include py-ref.h.
10981         * python/py-symbol.c: Do not include py-ref.h.
10982         * python/py-symtab.c: Do not include py-ref.h.
10983         * python/py-type.c: Do not include py-ref.h.
10984         * python/py-unwind.c: Do not include py-ref.h.
10985         * python/py-utils.c: Do not include py-ref.h.
10986         * python/py-value.c: Do not include py-ref.h.
10987         * python/py-varobj.c: Do not include py-ref.h.
10988         * python/py-xmethods.c: Do not include py-ref.h.
10989         * python/python.c: Do not include py-ref.h.
10990         * varobj.c: Do not include py-ref.h.
10991
10992 2019-01-22  Tom Tromey  <tom@tromey.com>
10993
10994         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10995         keyword for bcache.
10996
10997 2019-01-22  Tom Tromey  <tom@tromey.com>
10998
10999         * compile/compile-cplus-types.c: Remove a comment by #include.
11000
11001 2019-01-22  Tom Tromey  <tom@tromey.com>
11002
11003         * compile/gcc-c-plugin.h: Include compile-internal.h.
11004
11005 2019-01-22  Tom Tromey  <tom@tromey.com>
11006
11007         * stabsread.c (EXTERN): Do not define.
11008         (symnum, next_symbol_text_func, processing_gcc_compilation)
11009         (within_function, global_sym_chain, global_stabs)
11010         (previous_stab_code, this_object_header_files)
11011         (n_this_object_header_files)
11012         (n_allocated_this_object_header_files): Define.
11013         * stabsread.h (EXTERN): Never define.  Use "extern".
11014
11015 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11016
11017         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11018         history_value.
11019
11020 2019-01-21  Tom Tromey  <tom@tromey.com>
11021
11022         * ui-out.c: Fix includes.
11023         * tui/tui-source.c: Fix includes.
11024         * target.c: Fix includes.
11025         * remote.c: Fix includes.
11026         * regcache.c: Fix includes.
11027         * python/py-block.c: Fix includes.
11028         * printcmd.c: Fix includes.
11029         * or1k-tdep.c: Fix includes.
11030         * mi/mi-main.c: Fix includes.
11031         * m32r-tdep.c: Fix includes.
11032         * csky-tdep.c: Fix includes.
11033         * compile/compile-cplus-types.c: Fix includes.
11034         * cli/cli-interp.c: Fix includes.
11035
11036 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11037
11038         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11039         for padding.
11040
11041 2019-01-16  Tom Tromey  <tom@tromey.com>
11042
11043         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11044         earlier.
11045         (struct objfile) <msymbols_range>: Move from top level.
11046         <msymbols>: New method.
11047         (class objfile_msymbols): Remove.
11048         * symtab.c (default_collect_symbol_completion_matches_break_on):
11049         Update.
11050         * symmisc.c (dump_msymbols): Update.
11051         * stabsread.c (scan_file_globals): Update.
11052         * objc-lang.c (info_selectors_command, info_classes_command)
11053         (find_methods): Update.
11054         * minsyms.c (find_solib_trampoline_target): Update.
11055         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11056         * coffread.c (coff_symfile_read): Update.
11057         * ada-lang.c (ada_lookup_simple_minsym)
11058         (ada_collect_symbol_completion_matches): Update.
11059
11060 2019-01-16  Tom Tromey  <tom@tromey.com>
11061
11062         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11063         type.  Remove no-argument constructor.
11064         <iterator::operator++>: Simplify.
11065         <begin>: Update.
11066         <end>: Use minimal_symbol_count.
11067
11068 2019-01-16  Tom Tromey  <tom@tromey.com>
11069
11070         * objfiles.h (struct objfile) <psymtabs>: New method.
11071         (class objfile_psymtabs): Remove.
11072         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11073         typedef.
11074         <range>: New method.
11075         (require_partial_symbols): Change return type.
11076         * psymtab.c (require_partial_symbols)
11077         (psym_expand_symtabs_matching): Update.
11078         * mdebugread.c (parse_partial_symbols): Update.
11079         * dbxread.c (dbx_end_psymtab): Update.
11080
11081 2019-01-15  Tom Tromey  <tom@tromey.com>
11082
11083         * symtab.c (lookup_objfile_from_block)
11084         (lookup_symbol_in_objfile_symtabs)
11085         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11086         (find_line_symtab, info_sources_command)
11087         (default_collect_symbol_completion_matches_break_on)
11088         (make_source_files_completion_list): Update.
11089         * symmisc.c (print_objfile_statistics, dump_objfile)
11090         (maintenance_print_symbols, maintenance_info_symtabs)
11091         (maintenance_check_symtabs, maintenance_info_line_tables):
11092         Update.
11093         * source.c (select_source_symtab)
11094         (forget_cached_source_info_for_objfile): Update.
11095         * objfiles.h (class objfile_compunits): Remove.
11096         (struct objfile) <compunits_range>: New typedef.
11097         (compunits): New method.
11098         * objfiles.c (objfile_relocate1): Update.
11099         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11100         * maint.c (count_symtabs_and_blocks): Update.
11101         * linespec.c (iterate_over_all_matching_symtabs): Update.
11102         * cp-support.c (add_symbol_overload_list_qualified): Update.
11103         * coffread.c (coff_symtab_read): Update.
11104         * ada-lang.c (add_nonlocal_symbols)
11105         (ada_collect_symbol_completion_matches)
11106         (ada_add_global_exceptions): Update.
11107
11108 2019-01-15  Tom Tromey  <tom@tromey.com>
11109
11110         * progspace.h (program_space) <objfiles_safe_range>: New
11111         typedef.
11112         <objfiles_safe>: New method.
11113         * objfiles.h (class all_objfiles_safe): Remove.
11114         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11115         * jit.c (jit_inferior_exit_hook): Update.
11116
11117 2019-01-17  Tom Tromey  <tom@tromey.com>
11118
11119         * progspace.h (program_space) <objfiles_range>: New typedef.
11120         <objfiles>: New method.
11121         <objfiles_head>: Rename from objfiles.
11122         (object_files): Update.
11123         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11124         * guile/scm-pretty-print.c
11125         (ppscm_find_pretty_printer_from_objfiles): Update.
11126         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11127         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11128         Update.
11129         * python/py-progspace.c (pspy_get_objfiles): Update.
11130         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11131         Update.
11132         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11133         (objfpy_lookup_objfile_by_build_id): Update.
11134         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11135         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11136         Update.
11137         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11138         (expand_symtab_containing_pc, lookup_objfile_from_block)
11139         (lookup_static_symbol, basic_lookup_transparent_type)
11140         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11141         (find_line_symtab, info_sources_command)
11142         (default_collect_symbol_completion_matches_break_on)
11143         (make_source_files_completion_list, find_main_name): Update.
11144         * symmisc.c (print_symbol_bcache_statistics)
11145         (print_objfile_statistics, maintenance_print_symbols)
11146         (maintenance_print_msymbols, maintenance_print_objfiles)
11147         (maintenance_info_symtabs, maintenance_check_symtabs)
11148         (maintenance_expand_symtabs, maintenance_info_line_tables):
11149         Update.
11150         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11151         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11152         (map_overlay_command, unmap_overlay_command)
11153         (simple_overlay_update, expand_symtabs_matching)
11154         (map_symbol_filenames): Update.
11155         * symfile-debug.c (set_debug_symfile): Update.
11156         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11157         Update.
11158         * source.c (select_source_symtab, forget_cached_source_info):
11159         Update.
11160         * solib.c (solib_read_symbols): Update.
11161         * solib-spu.c (append_ocl_sos): Update.
11162         * psymtab.c (maintenance_print_psymbols)
11163         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11164         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11165         * printcmd.c (info_symbol_command): Update.
11166         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11167         Update.
11168         * objfiles.h (class all_objfiles): Remove.
11169         * objfiles.c (have_partial_symbols, have_full_symbols)
11170         (have_minimal_symbols, qsort_cmp, update_section_map)
11171         (shared_objfile_contains_address_p)
11172         (default_iterate_over_objfiles_in_search_order): Update.
11173         * objc-lang.c (info_selectors_command, info_classes_command)
11174         (find_methods): Update.
11175         * minsyms.c (find_solib_trampoline_target): Update.
11176         * maint.c (maintenance_info_sections)
11177         (maintenance_translate_address, count_symtabs_and_blocks):
11178         Update.
11179         * main.c (captured_main_1): Update.
11180         * linux-thread-db.c (try_thread_db_load_from_pdir)
11181         (has_libpthread): Update.
11182         * linespec.c (iterate_over_all_matching_symtabs)
11183         (search_minsyms_for_name): Update.
11184         * jit.c (jit_find_objf_with_entry_addr): Update.
11185         * hppa-tdep.c (find_unwind_entry)
11186         (hppa_lookup_stub_minimal_symbol): Update.
11187         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11188         Update.
11189         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11190         (elf_gnu_ifunc_resolve_by_got): Update.
11191         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11192         * dwarf-index-write.c (save_gdb_index_command): Update.
11193         * cp-support.c (add_symbol_overload_list_qualified): Update.
11194         * breakpoint.c (create_overlay_event_breakpoint)
11195         (create_longjmp_master_breakpoint)
11196         (create_std_terminate_master_breakpoint)
11197         (create_exception_master_breakpoint): Update.
11198         * blockframe.c (find_pc_partial_function): Update.
11199         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11200         (ada_collect_symbol_completion_matches)
11201         (ada_add_global_exceptions): Update.
11202
11203 2019-01-17  Tom Tromey  <tom@tromey.com>
11204
11205         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11206         declare VEC.
11207         (solib_target_parse_libraries): Change return type.
11208         (library_list_start_segment, library_list_start_section)
11209         (library_list_end_library, library_list_start_library); Update.
11210         (solib_target_free_library_list): Remove.
11211         (solib_target_parse_libraries): Remove cleanup.  Change return
11212         type.
11213         (solib_target_current_sos): Update.
11214
11215 2019-01-17  Tom Tromey  <tromey@bapiya>
11216
11217         * valprint.c: Replace "the the" with "the".
11218         * symtab.c: Replace "the the" with "the".
11219         * solib.c: Replace "the the" with "the".
11220         * solib-dsbt.c: Replace "the the" with "the".
11221         * linespec.c: Replace "the the" with "the".
11222         * dwarf2loc.h: Replace "the the" with "the".
11223         * amd64-windows-tdep.c: Replace "the the" with "the".
11224         * aarch64-tdep.c: Replace "the the" with "the".
11225
11226 2019-01-16  Keith Seitz  <keiths@redhat.com>
11227
11228         PR gdb/23773
11229         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11230         <builder>: Rename to ..
11231         <m_builder>: ... this and make private.
11232         (dwarf2_cu::get_builder): New method.  Change all users of
11233         `builder' to use this method.
11234         (dwarf2_start_symtab): Move to ...
11235         (dwarf2_cu::start_symtab): ... here.  Update all callers
11236         (setup_type_unit_groups): Move to ...
11237         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11238         callers.
11239         (dwarf2_cu::reset_builder): New method.
11240         (process_full_compunit, process_full_type_unit): Use
11241         dwarf2_cu::reset_builder.
11242         (follow_die_offset): Record the ancestor CU if it is different
11243         from the followed DIE's CU.
11244         (follow_die_sig_1): Likewise.
11245
11246 2019-01-15  Tom Tromey  <tom@tromey.com>
11247
11248         * remote.c (class remote_state) <buf>: Now a char_vector.
11249         <buf_size>: Remove.
11250         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11251         parameter.
11252         (remote_target::getpkt_or_notif_sane_1)
11253         (remote_target::getpkt_sane)
11254         (remote_target::getpkt_or_notif_sane): Likewise.
11255         (class remote_target) <putpkt>: New overload.
11256         (remote_target::read_frame): Change type of "buf_p".  Remove
11257         sizeof_p parameter.
11258         (packet_ok): New overload.
11259         (packet_check_result): New overload.
11260         Update all uses.
11261
11262 2019-01-14  Tom Tromey  <tom@tromey.com>
11263
11264         * remote-notif.c (handle_notification, remote_notif_ack)
11265         (remote_notif_parse): Make "buf" const.
11266         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11267         const.
11268         (remote_notif_parse, remote_notif_ack, handle_notification):
11269         Likewise.
11270         * remote.c (remote_notif_stop_parse): Make "buf" const.
11271         (remote_target::remote_parse_stop_reply): Make "buf" const.
11272         (remote_notif_stop_ack): Make "buf" const.
11273
11274 2019-01-14  Tom Tromey  <tom@tromey.com>
11275
11276         * remote.c (remote_console_output): Make parameter const.
11277
11278 2019-01-14  Tom Tromey  <tom@tromey.com>
11279
11280         * target-debug.h (target_debug_print_signals): Constify.
11281         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11282         * procfs.c (procfs_target::pass_signals): Update.
11283         * linux-nat.c (linux_nat_target::pass_signals): Update.
11284         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11285         * target-delegates.c: Rebuild.
11286         * remote.c (remote_target::program_signals): Update.
11287         (remote_target::pass_signals): Update.
11288         * target.c (target_pass_signals): Constify argument.
11289         (target_program_signals): Likewise.
11290         * target.h (struct target_ops) <pass_signals, program_signals>:
11291         Constify argument.
11292         (target_pass_signals, target_program_signals): Constify argument.
11293
11294 2019-01-14  Tom Tromey  <tom@tromey.com>
11295
11296         PR tui/28819:
11297         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11298
11299 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11300
11301         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11302         field.
11303         * rs6000-tdep.c: Include reggroups.h.
11304         (IS_V_ALIAS_PSEUDOREG): Define.
11305         (rs6000_register_name): Return names for the "vX" aliases.
11306         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11307         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11308         aliases.  Call default_register_reggroup_p for all other
11309         pseudo-registers.
11310         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11311         New functions.
11312         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11313         Handle "vX" aliases.
11314         (v_alias_pseudo_register_collect): New function.
11315         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11316         (rs6000_gdbarch_init): Initialize "vX" aliases as
11317         pseudo-registers.  Restore registration of
11318         rs6000_pseudo_register_reggroup_p with
11319         set_tdesc_pseudo_register_reggroup_p.
11320
11321 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11322
11323         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11324         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11325         set_gdbarch_num_pseudo_regs.
11326
11327 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11328
11329         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11330         Remove arg prefixname, add do_set and do_show.
11331         Add member functions set_list and show_list.
11332         * cli/cli-style.c (class cli_style_option): Update accordingly.
11333         (style_set_list): Move to file scope.
11334         (style_show_list): Likewise.
11335         (set_style): Call help_list.
11336         (show_style): Call cmd_show_list.
11337         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11338         Update to use the new macro.
11339
11340 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11341
11342         * ada-lang.c (_initialize_ada_language): Expand the help text
11343         for the "catch exception" command.
11344
11345 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11346
11347         * symtab.c (matching_obj_sections): Initialize obj,
11348         declare it closer to its usage.
11349
11350 2019-01-10  Tom Tromey  <tom@tromey.com>
11351
11352         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11353         (basic_inf_threads_range): Remove.
11354         (inf_threads_range, inf_non_exited_threads_range)
11355         (safe_inf_threads_range): Use next_adapter.
11356
11357 2019-01-10  Keith Seitz  <keiths@redhat.com>
11358
11359         PR gdb/23712
11360         PR symtab/23010
11361         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11362         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11363
11364 2019-01-10  Keith Seitz  <keiths@redhat.com>
11365
11366         PR gdb/23712
11367         PR symtab/23010
11368         * dictionary.c (pending_to_vector): Remove.
11369         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11370         Remove _1 suffix, replacing functions of the same name.  Update
11371         all callers.
11372         (dict_create_hashed, dict_create_hashed_expandable)
11373         (dict_create_linear, dict_create_linear_expandable, dict_free)
11374         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11375         Make functions static.
11376
11377 2019-01-10  Keith Seitz  <keiths@redhat.com>
11378
11379         PR gdb/23712
11380         PR symtab/23010
11381         * dictionary.h (struct dictionary): Replace declaration with
11382         multidictionary.
11383         (dict_create_hashed, dict_create_hashed_expandable)
11384         (dict_create_linear, dict_create_linear_expandable)
11385         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11386         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11387         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11388         taking multidictionary argument.
11389         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11390         * block.h (struct block) <dict>: Change to multidictionary
11391         and rename `multidict'.
11392         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11393         symmisc.c: Update all dictionary references to multidictionary.
11394
11395 2019-01-10  Keith Seitz  <keiths@redhat.com>
11396
11397         PR gdb/23712
11398         PR symtab/23010
11399         * dictionary.c: Include unordered_map.
11400         (pending_to_vector): New function.
11401         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11402         Rewrite the non-"_1" functions to take vector instead
11403         of linked list.
11404         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11405         "new" _1 versions of the same name.
11406         (multidictionary): Define.
11407         (std::hash<enum language): New definition.
11408         (collate_pending_symbols_by_language, mdict_create_hashed)
11409         (mdict_create_hashed_expandable, mdict_create_linear)
11410         (mdict_create_linear_expandable, mdict_free)
11411         (find_language_dictionary, create_new_language_dictionary)
11412         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11413         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11414         (mdict_size, mdict_empty): New functions.
11415         * dictionary.h (mdict_iterator): Define.
11416
11417 2019-01-10  Pedro Alves  <palves@redhat.com>
11418
11419         * breakpoint.c (read_uploaded_action)
11420         (create_tracepoint_from_upload): Adjust to use
11421         gdb::unique_xmalloc_ptr.
11422         * ctf.c (ctf_write_uploaded_tp):
11423         (SET_ARRAY_FIELD): Use emplace_back.
11424         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11425         * tracefile-tfile.c (tfile_write_uploaded_tp):
11426         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11427         gdb::unique_xmalloc_ptr.
11428         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11429         at_string, cond_string, cmd_strings>: Replace char pointers
11430         with gdb::unique_xmalloc_ptr.
11431
11432 2019-01-10  Pedro Alves  <palves@redhat.com>
11433
11434         * solib-target.c (library_list_start_library): Don't xstrdup name.
11435
11436 2019-01-10  Pedro Alves  <palves@redhat.com>
11437
11438         * mdebugread.c (parse_partial_symbols): Use
11439         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11440
11441 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11442
11443         * linux-fork.c (scoped_switch_fork_info)
11444         <~scoped_switch_fork_info>: Fix incorrect variable name.
11445
11446 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11447
11448         * linux-fork.c (scoped_switch_fork_info)
11449         <scoped_switch_fork_info>: Make explicit.
11450         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11451
11452 2019-01-10  Tom Tromey  <tom@tromey.com>
11453
11454         * objfiles.h (objfile::reset_psymtabs): Update.
11455         * objfiles.c (objfile::objfile): Update.
11456         * psymtab.h (psymtab_storage::obstack): Update.
11457         (psymtab_storage::m_obstack): Use gdb::optional.
11458         (class psymtab_storage): Update comment.  Remove objfile
11459         parameter.
11460         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11461
11462 2019-01-10  Tom Tromey  <tom@tromey.com>
11463
11464         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11465         <free_psymtabs>: Now private.
11466         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11467         (allocate_psymtab): Use new method.
11468
11469 2019-01-10  Tom Tromey  <tom@tromey.com>
11470
11471         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11472         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11473         * mdebugread.c (parse_partial_symbols): Use
11474         allocate_dependencies.
11475         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11476         allocate_dependencies.
11477         (process_psymtab_comp_unit_reader)
11478         (build_type_psymtab_dependencies): Likewise.
11479         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11480
11481 2019-01-10  Tom Tromey  <tom@tromey.com>
11482
11483         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11484         PSYMBOL_SET_LANGUAGE.
11485         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11486
11487 2019-01-10  Tom Tromey  <tom@tromey.com>
11488
11489         * psymtab.h (psymtab_storage::obstack): New method.
11490         <m_obstack>: Rename from obstack; now private.
11491         * psymtab.c (psymtab_storage): Update.
11492         * dwarf2read.c (create_addrmap_from_index)
11493         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11494         Update.
11495
11496 2019-01-10  Tom Tromey  <tom@tromey.com>
11497
11498         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11499         * objfiles.h (objfile::reset_psymtabs): New method.
11500
11501 2019-01-10  Tom Tromey  <tom@tromey.com>
11502
11503         * symmisc.c (print_symbol_bcache_statistics): Update.
11504         (print_objfile_statistics): Update.
11505         * symfile.c (reread_symbols): Update.
11506         * psymtab.h (class psymtab_storage): New.
11507         * psymtab.c (psymtab_storage): New constructor.
11508         (~psymtab_storage): New destructor.
11509         (require_partial_symbols): Update.
11510         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11511         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11512         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11513         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11514         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11515         (start_psymtab_common, end_psymtab_common)
11516         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11517         (allocate_psymtab): Update.
11518         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11519         Update.
11520         (dump_psymtab_addrmap, maintenance_print_psymbols)
11521         (maintenance_check_psymtabs): Update.
11522         (class objfile_psymtabs): Move to objfiles.h.
11523         * psympriv.h (discard_psymtab): Now inline.
11524         (psymtab_discarder::psymtab_discarder): Update.
11525         (psymtab_discarder::~psymtab_discarder): Update.
11526         (ALL_OBJFILE_PSYMTABS): Rewrite.
11527         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11528         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11529         Remove fields.
11530         <partial_symtabs>: New field.
11531         (class objfile_psymtabs): Move from psymtab.h.  Update.
11532         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11533         psymbol_cache.
11534         (objfile::~objfile): Don't destroy psymbol_cache.
11535         * mdebugread.c (parse_partial_symbols): Update.
11536         * dwarf2read.c (create_addrmap_from_index)
11537         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11538         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11539         (add_partial_subprogram, dwarf2_ranges_read): Update.
11540         * dwarf-index-write.c (write_address_map)
11541         (write_one_signatured_type, recursively_write_psymbols)
11542         (class debug_names, class debug_names, write_psymtabs_to_index):
11543         Update.
11544
11545 2019-01-10  Tom Tromey  <tom@tromey.com>
11546
11547         * symtab.h (SYMBOL_SET_NAMES): Update.
11548         (symbol_set_names): Update.
11549         (MSYMBOL_SET_NAMES): Update.
11550         * symtab.c (symbol_set_names): Change argument to be an
11551         objfile_per_bfd_storage.
11552         * psymtab.c (add_psymbol_to_bcache): Update.
11553         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11554
11555 2019-01-10  Tom Tromey  <tom@tromey.com>
11556
11557         * symtab.c (create_demangled_names_hash): Change argument to be an
11558         objfile_per_bfd_storage.
11559         (symbol_set_names): Update.
11560
11561 2019-01-10  Tom Tromey  <tom@tromey.com>
11562
11563         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11564         init_psymbol_list.
11565         * psymtab.c (init_psymbol_list): Do nothing if already called.
11566         * psympriv.h (init_psymbol_list): Add comment.
11567         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11568         init_psymbol_list.
11569         * dbxread.c (dbx_symfile_read): Unconditionally call
11570         init_psymbol_list.
11571
11572 2019-01-10  Tom Tromey  <tom@tromey.com>
11573
11574         * xcoffread.c (scan_xcoff_symtab): Update.
11575         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11576         "where".
11577         * mdebugread.c (parse_partial_symbols)
11578         (handle_psymbol_enumerators): Update.
11579         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11580         * dbxread.c (read_dbx_symtab): Update.
11581         * psympriv.h (psymbol_placement): New enum.
11582         (add_psymbol_to_list): Update.
11583
11584 2019-01-10  Tom Tromey  <tom@tromey.com>
11585
11586         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11587         static_psymbols parameters.
11588         (scan_xcoff_symtab): Update.
11589         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11590         static_psymbols parameters.
11591         * psympriv.h (start_psymtab_common): Update.
11592         * mdebugread.c (parse_partial_symbols): Update.
11593         * dwarf2read.c (create_partial_symtab): Update.
11594         * dbxread.c (read_dbx_symtab): Update.
11595         (start_psymtab): Remove global_psymbols and static_psymbols
11596         parameters.
11597
11598 2019-01-10  Tom Tromey  <tom@tromey.com>
11599
11600         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11601         * psymtab.c (allocate_psymtab): Add comment.
11602         * psympriv.h (allocate_psymtab): Add comment.
11603         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11604         initializations.
11605         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11606
11607 2019-01-10  Tom Tromey  <tom@tromey.com>
11608
11609         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11610         Don't declare.
11611         * mipsread.c: Include mdebugread.h.
11612         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11613         Declare.
11614         * elfread.c: Include mdebugread.h.
11615
11616 2019-01-09  Tom Tromey  <tom@tromey.com>
11617
11618         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11619         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11620         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11621         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11622         (psym_lookup_symbol, psym_find_last_source_symtab)
11623         (psym_forget_cached_source_info, psym_print_stats)
11624         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11625         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11626         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11627         (psym_find_compunit_symtab_by_address)
11628         (maintenance_print_psymbols, maintenance_info_psymtabs)
11629         (maintenance_check_psymtabs): Use ranged for.
11630         * psymtab.h (class objfile_psymtabs): New.
11631         (require_partial_symbols): Return objfile_psymtabs.
11632         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11633
11634 2019-01-09  Tom Tromey  <tom@tromey.com>
11635
11636         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11637         (find_pc_mapped_section, list_overlays_command)
11638         (map_overlay_command, unmap_overlay_command)
11639         (simple_overlay_update): Use all_objfiles.
11640         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11641         * printcmd.c (info_symbol_command): Use all_objfiles.
11642         * objfiles.h (ALL_OBJSECTIONS): Remove.
11643         * maint.c (maintenance_translate_address): Use all_objfiles.
11644         * gcore.c (gcore_create_callback): Use all_objfiles.
11645         (objfile_find_memory_regions): Likewise.
11646
11647 2019-01-09  Tom Tromey  <tom@tromey.com>
11648
11649         * symtab.c (find_line_symtab, info_sources_command)
11650         (make_source_files_completion_list): Use objfile_compunits.
11651         * source.c (select_source_symtab): Use objfile_compunits.
11652         * objfiles.h (struct objfile): Update comment.
11653         (ALL_OBJFILES): Remove.
11654         (ALL_FILETABS): Remove.
11655         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11656         objfile_compunits.
11657
11658 2019-01-09  Tom Tromey  <tom@tromey.com>
11659
11660         * symmisc.c (print_objfile_statistics, dump_objfile)
11661         (maintenance_print_symbols): Use compunit_filetabs.
11662         * source.c (forget_cached_source_info_for_objfile): Use
11663         compunit_filetabs.
11664         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11665         (ALL_FILETABS): Use compunit_filetabs.
11666         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11667         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11668
11669 2019-01-09  Tom Tromey  <tom@tromey.com>
11670
11671         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11672         (compunit_filetabs): New.
11673         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11674         compunit_filetabs.
11675         (info_sources_command, make_source_files_completion_list): Remove
11676         declaration.
11677         * symmisc.c (print_objfile_statistics, dump_objfile)
11678         (maintenance_print_symbols): Remove declaration.
11679         (maintenance_info_symtabs): Use compunit_filetabs.
11680         (maintenance_info_line_tables): Likewise.
11681         * source.c (select_source_symtab): Change local variable name.
11682         (forget_cached_source_info_for_objfile): Remove declaration.
11683         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11684         * objfiles.c (objfile_relocate1): Remove declaration.
11685         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11686         declaration.
11687         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11688         * coffread.c (coff_symtab_read): Remove declaration.
11689         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11690         compunit_filetabs.
11691
11692 2019-01-09  Tom Tromey  <tom@tromey.com>
11693
11694         * symtab.c (lookup_objfile_from_block)
11695         (find_pc_sect_compunit_symtab, search_symbols)
11696         (default_collect_symbol_completion_matches_break_on): Use
11697         objfile_compunits.
11698         * objfiles.h (ALL_COMPUNITS): Remove.
11699         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11700         * cp-support.c (add_symbol_overload_list_qualified): Use
11701         objfile_compunits.
11702         * ada-lang.c (ada_collect_symbol_completion_matches)
11703         (ada_add_global_exceptions): Use objfile_compunits.
11704
11705 2019-01-09  Tom Tromey  <tom@tromey.com>
11706
11707         * source.c (select_source_symtab)
11708         (forget_cached_source_info_for_objfile): Remove declaration.
11709         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11710         declaration.
11711         * maint.c (count_symtabs_and_blocks): Remove declaration.
11712         * cp-support.c (add_symbol_overload_list_qualified): Remove
11713         declaration.
11714         * coffread.c (coff_symtab_read): Remove declaration.
11715         * symtab.c (lookup_symbol_in_objfile_symtabs)
11716         (basic_lookup_transparent_type_1): Use objfile_compunits.
11717         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11718         (info_sources_command, search_symbols)
11719         (default_collect_symbol_completion_matches_break_on)
11720         (make_source_files_completion_list): Remove declaration.
11721         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11722         (ada_collect_symbol_completion_matches)
11723         (ada_add_global_exceptions): Remove declaration.
11724         * linespec.c (iterate_over_all_matching_symtabs): Use
11725         objfile_compunits.
11726         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11727         (class objfile_compunits): New.
11728         (ALL_COMPUNITS): Use objfile_compunits.
11729         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11730         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11731         objfile_compunits.
11732         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11733
11734 2019-01-09  Tom Tromey  <tom@tromey.com>
11735
11736         * symtab.c (search_symbols)
11737         (default_collect_symbol_completion_matches_break_on): Use
11738         objfile_msymbols.
11739         * ada-lang.c (ada_lookup_simple_minsym)
11740         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11741         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11742         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11743         objfile_msymbols.
11744         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11745         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11746         * objc-lang.c (find_methods): Use objfile_msymbols.
11747         (info_selectors_command, info_classes_command): Likewise.
11748         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11749         * objfiles.h (class objfile_msymbols): New.
11750         (ALL_OBJFILE_MSYMBOLS): Remove.
11751         (ALL_MSYMBOLS): Remove.
11752
11753 2019-01-09  Tom Tromey  <tom@tromey.com>
11754
11755         * common/next-iterator.h (next_adapter): Add Iterator template
11756         parameter.
11757         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11758         (class all_objfiles_safe): New.
11759         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11760         * objfiles.c (put_objfile_before): Update comment.
11761         (add_separate_debug_objfile): Likewise.
11762         (free_all_objfiles): Use all_objfiles_safe.
11763         (objfile_purge_solibs): Likewise.
11764
11765 2019-01-09  Tom Tromey  <tom@tromey.com>
11766
11767         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11768         (expand_symtab_containing_pc, lookup_static_symbol)
11769         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11770         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11771         all_objfiles.
11772         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11773         * breakpoint.c (create_overlay_event_breakpoint)
11774         (create_longjmp_master_breakpoint)
11775         (create_std_terminate_master_breakpoint)
11776         (create_exception_master_breakpoint): Use all_objfiles.
11777         * linux-thread-db.c (try_thread_db_load_from_pdir)
11778         (has_libpthread): Use all_objfiles.
11779         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11780         * linespec.c (iterate_over_all_matching_symtabs)
11781         (search_minsyms_for_name): Use all_objfiles.
11782         * maint.c (maintenance_info_sections): Use all_objfiles.
11783         * main.c (captured_main_1): Use all_objfiles.
11784         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11785         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11786         * guile/scm-pretty-print.c
11787         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11788         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11789         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11790         (maintenance_print_msymbols): Use all_objfiles.
11791         * source.c (select_source_symtab): Use all_objfiles.
11792         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11793         * symfile.c (remove_symbol_file_command)
11794         (expand_symtabs_matching, map_symbol_filenames): Use
11795         all_objfiles.
11796         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11797         all_objfiles.
11798         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11799         * objc-lang.c (find_methods): Use all_objfiles.
11800         * objfiles.c (have_partial_symbols, have_full_symbols)
11801         (have_minimal_symbols, qsort_cmp)
11802         (default_iterate_over_objfiles_in_search_order): Use
11803         all_objfiles.
11804         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11805         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11806         (maintenance_check_psymtabs): Use all_objfiles.
11807         (ALL_PSYMTABS): Remove.
11808         * compile/compile-object-run.c (do_module_cleanup): Use
11809         all_objfiles.
11810         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11811         * cp-support.c (add_symbol_overload_list_qualified): Use
11812         all_objfiles.
11813         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11814         Use all_objfiles.
11815         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11816         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11817         all_objfiles.
11818         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11819         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11820         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11821         Uses all_objfiles.
11822         * solib.c (solib_read_symbols): Use all_objfiles
11823
11824 2019-01-09  Tom Tromey  <tom@tromey.com>
11825
11826         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11827         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11828         all_objfiles.
11829         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11830         * symmisc.c (print_symbol_bcache_statistics)
11831         (print_objfile_statistics, maintenance_print_objfiles)
11832         (maintenance_info_symtabs, maintenance_check_symtabs)
11833         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11834         all_objfiles.
11835         * source.c (forget_cached_source_info): Use all_objfiles.
11836         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11837         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11838         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11839         * objfiles.c (update_section_map): Use all_objfiles.
11840         (shared_objfile_contains_address_p): Likewise.
11841         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11842         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11843
11844 2019-01-09  Tom Tromey  <tom@tromey.com>
11845
11846         * common/next-iterator.h: New file.
11847         * objfiles.h (class all_objfiles): New.
11848         (struct objfile_iterator): New.
11849
11850 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11851
11852         * NEWS: Move the description of the changed "frame", "select-frame",
11853          and "info frame" commands to the Changed commands section.
11854
11855 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11856
11857         * gdbtypes.c (check_stub_method_group): Remove handling of old
11858         mangling schemes.
11859         * linespec.c (find_methods): Likewise.
11860         * stabsread.c (read_member_functions): Likewise.
11861         * valops.c (search_struct_method): Likewise.
11862         (value_struct_elt_for_reference): Likewise.
11863         * NEWS: Mention this change.
11864
11865 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11866
11867         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11868         print_source_lines.
11869         * source.c (print_source_lines_base): Update line number check.
11870         (print_source_lines): New function.
11871         (source_lines_range::source_lines_range): New function.
11872         * source.h (class source_lines_range): New class.
11873         (print_source_lines): New declaration.
11874
11875 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11876
11877         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11878
11879 2019-01-08  Tom Tromey  <tom@tromey.com>
11880             Simon Marchi  <simon.marchi@ericsson.com>
11881
11882         PR gdb/24060
11883         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11884         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11885         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11886         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11887         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11888         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11889
11890 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11891
11892         * source.c (select_source_symtab): Move header comment to
11893         declaration in source.h.
11894         (forget_cached_source_info_for_objfile): Likewise.
11895         (forget_cached_source_info): Likewise.
11896         (identify_source_line): Likewise.
11897         * source.h (identify_source_line): Move declaration from symtab.h
11898         and add comment from source.c
11899         (print_source_lines): Likewise.
11900         (forget_cached_source_info_for_objfile): Likewise.
11901         (forget_cached_source_info): Likewise.
11902         (select_source_symtab): Likewise.
11903         (enum print_source_lines_flag): Move definition from symtab.h.
11904         * symtab.h (identify_source_line): Move declaration to source.h.
11905         (print_source_lines): Likewise.
11906         (forget_cached_source_info_for_objfile): Likewise.
11907         (forget_cached_source_info): Likewise.
11908         (select_source_symtab): Likewise.
11909         (enum print_source_lines_flag): Move definition to source.h.
11910         * tui/tui-hooks.c: Add 'source.h' include.
11911
11912 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11913
11914         * source.c (print_source_lines_base): Handle requests to print
11915         reverse line number sequences, and guard against empty lines
11916         string.
11917
11918 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11919
11920         * source.c (print_source_lines_base): Fix skip of '\r' if next
11921         character is '\n'.
11922
11923 2019-01-06  Tom Tromey  <tom@tromey.com>
11924
11925         * c-exp.y (struct c_parse_state) <macro_original_text,
11926         expansion_obstack>: New member.
11927         (macro_original_text, expansion_obstack): Remove globals.
11928         (scan_macro_expansion, scanning_macro_expansion)
11929         (finished_macro_expansion): Update.
11930         (scan_macro_cleanup): Remove.
11931         (yylex, c_parse): Update.
11932
11933 2019-01-06  Tom Tromey  <tom@tromey.com>
11934
11935         * c-exp.y (struct c_parse_state) <strings>: New member.
11936         (operator_stoken): Update.
11937
11938 2019-01-06  Tom Tromey  <tom@tromey.com>
11939
11940         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11941         (union type_stack_elt) <typelist_val>: Now a pointer to
11942         std::vector.
11943         (type_stack_cleanup): Don't declare.
11944         (push_typelist): Update.
11945         * parse.c (pop_typelist): Return a std::vector.
11946         (push_typelist): Take a std::vector.
11947         (follow_types): Update.  Do not free args.
11948         (type_stack_cleanup): Remove.
11949         * c-exp.y (struct c_parse_state): New.
11950         (cpstate): New global.
11951         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11952         (nonempty_typelist): Update.
11953         (func_mod): Create a new vector.
11954         (c_parse): Create a c_parse_state.
11955         (check_parameter_typelist): Do not delete params.
11956         (function_method): Update.  Do not delete type_list.
11957
11958 2019-01-06  Tom Tromey  <tom@tromey.com>
11959
11960         PR gdb/28155:
11961         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11962         check_typedef.
11963         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11964         (print_return_value): Likewise.
11965
11966 2019-01-05  Tom Tromey  <tom@tromey.com>
11967
11968         * contrib/cleanup_check.py: Remove.
11969         * contrib/gcc-with-excheck: Remove.
11970         * contrib/exsummary.py: Remove.
11971         * contrib/excheck.py: Remove.
11972
11973 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11974
11975         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11976         NULL. Initialize tpprev to NULL instead of assigning it
11977         to NULL on the next statement.
11978         * windows-nat.c (windows_delete_thread): Remove check for
11979         main_thread_id before printing thread exit notifications.
11980         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11981         Remove thread ID check against main_thread_id.
11982         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11983         windows_delete_thread.
11984         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11985
11986 2019-01-04  Tom Tromey  <tom@tromey.com>
11987
11988         * compile/compile.c (_initialize_compile): Use upper case for
11989         metasyntactic variables.
11990         * symmisc.c (_initialize_symmisc): Use upper case for
11991         metasyntactic variables.
11992         * psymtab.c (_initialize_psymtab): Use upper case for
11993         metasyntactic variables.
11994         * demangle.c (demangle_command): Use upper case for metasyntactic
11995         variables.
11996         (_initialize_demangler): Likewise.
11997         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11998         variables.
11999
12000 2019-01-03  Tom Tromey  <tom@tromey.com>
12001
12002         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12003
12004 2019-01-03  Tom Tromey  <tom@tromey.com>
12005
12006         * python/py-symtab.c (salpy_str): Update.
12007         (struct salpy_sal_object) <symtab>: Now a PyObject.
12008         (salpy_dealloc): Update.
12009         (del_objfile_sal): Use gdbpy_ref.
12010
12011 2019-01-03  Tom Tromey  <tom@tromey.com>
12012
12013         * python/py-type.c (convert_field): Use new_reference.  Return
12014         gdbpy_ref.
12015         (make_fielditem): Return gdbpy_ref.
12016         (typy_fields): Update.
12017         (typy_getitem): Update.
12018         (field_name): Return gdbpy_ref.  Use new_reference.
12019         (typy_iterator_iternext): Update.
12020
12021 2019-01-03  Tom Tromey  <tom@tromey.com>
12022
12023         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12024
12025 2019-01-03  Tom Tromey  <tom@tromey.com>
12026
12027         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12028         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12029         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12030         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12031         (pspy_set_type_printers): Likewise.
12032         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12033         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12034         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12035         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12036         (objfpy_set_type_printers): Likewise.
12037
12038 2019-01-03  Tom Tromey  <tom@tromey.com>
12039
12040         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12041         (gdbpy_print_stack): Use gdbpy_err_fetch.
12042         * python/python-internal.h (class gdbpy_err_fetch): New class.
12043         (class gdbpy_enter) <m_error_type, m_error_value,
12044         m_error_traceback>: Remove.
12045         <m_error>: New member.
12046         (gdbpy_exception_to_string): Don't declare.
12047         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12048         * python/py-value.c (convert_value_from_python): Use
12049         gdbpy_err_fetch.
12050         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12051         gdbpy_exception_to_string.
12052         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12053         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12054         gdbpy_err_fetch.
12055
12056 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12057
12058         * linux-nat.c (delete_lwp_cleanup): Delete.
12059         (struct lwp_deleter): New struct.
12060         (lwp_info_up): New typedef.
12061         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12062         lwp_info_up.
12063
12064 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12065
12066         * linux-fork.c (class scoped_switch_fork_info): New class.
12067         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12068
12069 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12070
12071         * valops.c (find_overload_match): Remove use of null_cleanup, and
12072         calls to do_cleanups.
12073
12074 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12075
12076         * compile/compile-cplus-types.c
12077         (compile_cplus_instance::decl_name): Handle changes to
12078         cp_func_name.
12079         * cp-support.c (cp_func_name): Update header comment, update
12080         return type.
12081         * cp-support.h (cp_func_name): Update return type in declaration.
12082         * valops.c (find_overload_match): Move temp_func local to top
12083         level of function and change its type.  Use temp_func to hold and
12084         delete temporary string obtained from cp_func_name.
12085
12086 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12087
12088         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12089         gdb::char_vector, remove cleanup, and update uses of `msg`.
12090
12091 2019-01-03  Jim Wilson  <jimw@sifive.com>
12092
12093         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12094
12095 2019-01-02  Tom Tromey  <tom@tromey.com>
12096
12097         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12098         (tdesc_parse_xml): Remove cleanups.
12099         * target-descriptions.h (make_cleanup_free_target_description):
12100         Don't declare.
12101         (target_desc_deleter): New struct.
12102         (target_desc_up): New typedef.
12103         * target-descriptions.c (target_desc_deleter::operator()): Rename
12104         from free_target_description.
12105         (make_cleanup_free_target_description): Remove.
12106
12107 2019-01-02  Tom Tromey  <tom@tromey.com>
12108
12109         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12110         constructor, destructor.
12111         (linespec_parser): Remove typedef.
12112         (~linespec_parser): Rename from linespec_parser_delete.
12113         (linespec_lex_to_end, linespec_complete_label)
12114         (linespec_complete): Update.
12115         (decode_line_full): Remove cleanups.
12116         (decode_line_1): Update.
12117
12118 2019-01-02  Tom Tromey  <tom@tromey.com>
12119
12120         * python/python-internal.h (inferior_to_inferior_object): Change
12121         return type.
12122         * python/py-exitedevent.c (create_exited_event_object): Update.
12123         * python/py-inferior.c (inferior_to_inferior_object): Return
12124         gdbpy_ref.
12125         (python_new_inferior, python_inferior_deleted)
12126         (thread_to_thread_object, delete_thread_object)
12127         (build_inferior_list, gdbpy_selected_inferior): Update.
12128         * python/py-infthread.c (create_thread_object): Update.  Also fail
12129         if inferior_to_inferior_object fails.
12130
12131 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12132
12133         * inferior.h (class inferior) <displaced_step_state>: New field.
12134         * infrun.h (struct displaced_step_state): Move here from
12135         infrun.c.  Initialize fields, add constructor.
12136         <inf>: Remove field.
12137         <reset>: New method.
12138         * infrun.c (struct displaced_step_inferior_state): Move to
12139         infrun.h.
12140         (displaced_step_inferior_states): Remove.
12141         (get_displaced_stepping_state): Adust.
12142         (displaced_step_in_progress_any_inferior): Adjust.
12143         (displaced_step_in_progress_thread): Adjust.
12144         (displaced_step_in_progress): Adjust.
12145         (add_displaced_stepping_state): Remove.
12146         (get_displaced_step_closure_by_addr): Adjust.
12147         (remove_displaced_stepping_state): Remove.
12148         (infrun_inferior_exit): Call displaced_step_state.reset.
12149         (use_displaced_stepping): Don't check for NULL.
12150         (displaced_step_prepare_throw): Call
12151         get_displaced_stepping_state.
12152         (displaced_step_fixup): Don't check for NULL.
12153         (prepare_for_detach): Don't check for NULL.
12154
12155 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12156
12157         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12158          in case of call that did not complete.
12159
12160 2019-01-02  Andrey Utkin  <autkin@undo.io>
12161
12162         * symfile.c (find_separate_debug_file): Fix search of debug files for
12163         remote debuggee.
12164
12165 2019-01-02  Tom Tromey  <tom@tromey.com>
12166
12167         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12168         indentation.
12169         * python/py-frame.c (frapy_older): Remove cast.
12170         (frapy_newer): Likewise.
12171         * python/py-breakpoint.c (local_setattro): Remove cast.
12172         * python/py-arch.c (archpy_name): Remove local variable.
12173         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12174
12175 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12176
12177         * unittests/basic_string_view/element_access/char/empty.cc:
12178         Fix year range in copyright header.
12179
12180 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12181
12182         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12183         Delete.
12184         <operator==>: Update with for removed field.
12185         <hash>: Likewise.
12186         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12187         <isa_features>: ...this.
12188         <abi_features>: New field.
12189         (riscv_isa_flen): Update comment.
12190         (riscv_abi_xlen): New declaration.
12191         (riscv_abi_flen): New declaration.
12192         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12193         isa_features.
12194         (riscv_abi_xlen): New function.
12195         (riscv_isa_flen): Update to get answer from isa_features.
12196         (riscv_abi_flen): New function.
12197         (riscv_has_fp_abi): Update to get answer from abi_features.
12198         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12199         xlen and flen.
12200         (riscv_call_info) <xlen, flen>: Update comment.
12201         (riscv_call_arg_struct): Remove invalid assertions
12202         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12203         is removed.
12204         (riscv_gdbarch_init): Gather isa features and abi features
12205         separately, ensure both match on the gdbarch when reusing an old
12206         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12207         a target with 64-bit float hardware.
12208
12209 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12210
12211         * source.c (search_command_helper): Stop reverse search
12212         when line 1 has been searched.
12213
12214 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12215
12216         * record-full.c (record_full_base_target::close): Rewrite
12217         record_full_core_buf_list free logic.
12218
12219 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12220
12221         * break-catch-syscall.c (print_one_catch_syscall): xfree
12222         the last text.
12223
12224 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12225
12226         * top.c (print_gdb_version): Update Copyright year in version
12227         message.
12228
12229 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12230
12231         Update copyright year range in all GDB files.
12232
12233 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12234
12235         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12236
12237 For older changes see ChangeLog-2018.
12238 \f
12239 Local Variables:
12240 mode: change-log
12241 left-margin: 8
12242 fill-column: 74
12243 version-control: never
12244 coding: utf-8
12245 End:
12246