gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (tui_clear_source_content)
   4         (tui_erase_source_content, tui_show_source_content): Change type
   5         of win_info.
   6         * tui/tui-winsource.c (tui_clear_source_content)
   7         (tui_erase_source_content, tui_show_source_content): Change type
   8         of win_info.
   9         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  10         * tui/tui-source.h (tui_set_source_content_nil): Change type of
  11         win_info.
  12         * tui/tui-source.c (tui_set_source_content_nil): Change type of
  13         win_info.
  14         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
  15
  16 2019-06-25  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-winsource.c (tui_clear_source_content)
  19         (tui_source_window_base::set_is_exec_point_at): Update.
  20         * tui/tui-source.c (tui_set_source_content_nil): Update.
  21         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
  22         a bool.
  23         * tui/tui-data.c (init_content_element): Update.
  24
  25 2019-06-25  Tom Tromey  <tom@tromey.com>
  26
  27         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
  28         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
  29         * tui/tui-layout.c (init_and_make_win): Update.
  30         * tui/tui.h (enum tui_win_type): Update.
  31         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
  32         tui_win_is_auxillary.
  33         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
  34         tui_win_is_auxillary.
  35
  36 2019-06-25  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
  39         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
  40         (tui_delete_data_content_windows, tui_display_all_data)
  41         (tui_data_window::do_scroll_vertical, tui_display_data_from):
  42         Update.
  43         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
  44         * tui/tui-regs.c (tui_last_regs_line_no)
  45         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
  46         (tui_show_registers): Update.
  47         (tui_show_register_group): Return void.  Update.
  48         (tui_display_registers_from, tui_display_reg_element_at_line)
  49         (tui_display_registers_from_line, tui_check_register_values):
  50         Update.
  51         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
  52         member.
  53         (struct tui_data_window) <regs_content>: Now a std::vector.
  54         <regs_content_count>: Remove.
  55         (tui_add_content_elements, tui_free_data_content): Don't declare.
  56         * tui/tui-data.c (tui_data_window::clear_detail): Update.
  57         (init_content_element): Remove DATA_WIN case.  Add assert.
  58         (tui_add_content_elements): Remove.
  59         (tui_data_window): Update.
  60         (tui_free_data_content): Remove.
  61         (free_content_elements): Remove DATA_WIN case.
  62
  63 2019-06-25  Tom Tromey  <tom@tromey.com>
  64
  65         * tui/tui-data.c (tui_data_item_window): Update.
  66         * tui/tui-windata.h (tui_check_data_values): Don't declare.
  67         * tui/tui-windata.c (tui_display_all_data)
  68         (tui_display_data_from_line): Update.
  69         (tui_check_data_values): Remove.
  70         * tui/tui-regs.c (tui_show_register_group)
  71         (tui_display_reg_element_at_line): Update.
  72         * tui/tui-hooks.c (tui_register_changed)
  73         (tui_refresh_frame_and_register_information): Call
  74         tui_check_register_values.
  75         * tui/tui-data.h (struct tui_data_window) <data_content,
  76         data_content_count, data_type>: Remove.
  77         (enum tui_data_type): Remove.
  78
  79         * tui/tui-data.c (tui_data_window::clear_detail)
  80         (~tui_data_window): Update.
  81
  82 2019-06-25  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
  85         declare.
  86         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
  87         Rename from tui_first_data_item_displayed.  Update.
  88         (tui_data_window::refresh_all)
  89         (tui_data_window::do_scroll_vertical): Update.
  90         * tui/tui-data.h (struct tui_data_window)
  91         <first_data_item_displayed>: Declare new method.
  92
  93 2019-06-25  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-data.h (tui_init_generic_part): Don't declare.
  96         * tui/tui-data.c (tui_init_generic_part): Remove, moving
  97         contents...
  98         (tui_initialize_static_data): ...here.
  99
 100 2019-06-25  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 103         (tui_display_registers_from, tui_check_register_values): Update.
 104         (tui_display_register): Remove win_info parameter; update.
 105         (tui_get_register): Change type of parameters.
 106         * tui/tui-data.h (struct tui_data_element): Remove.
 107         (union tui_which_element) <data>: Remove.
 108         <data_window>: Change type.
 109         (struct tui_data_item_window): New.
 110         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 111         case.  Add assert.
 112         (~tui_data_item_window): New destructor.
 113         (free_content_elements): Remove DATA_ITEM_WIN case.
 114
 115 2019-06-25  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 118         Remove.
 119
 120 2019-06-25  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-data.h (struct tui_command_element): Remove.
 123         (union tui_which_element) <command>: Remove.
 124         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 125         assert.
 126         (free_content_elements): Remove CMD_WIN case.
 127
 128 2019-06-25  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-layout.c (tui_set_layout): Update.
 131         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 132         * tui/tui-data.c (layout_def): Update.
 133
 134 2019-06-25  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 137         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 138         (tui_source_window_base::set_new_height): Update.
 139         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 140         Update.
 141         (tui_set_locator_fullname, tui_set_locator_info)
 142         (tui_show_frame_info): Update.
 143         * tui/tui-source.c (tui_set_source_content)
 144         (tui_source_is_displayed): Update.
 145         * tui/tui-layout.c (show_source_disasm_command, show_data)
 146         (show_source_or_disasm_and_command): Update.
 147         * tui/tui-disasm.c (tui_set_disassem_content)
 148         (tui_get_begin_asm_address): Update.
 149         * tui/tui-data.h (struct tui_locator_element): Remove.
 150         (union tui_which_element) <locator>: Remove.
 151         (struct tui_locator_window): New.
 152         (tui_locator_win_info_ptr): Change return type.
 153         * tui/tui-data.c (_locator): Change type.
 154         (tui_locator_win_info_ptr): Change return type.
 155         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 156         (tui_alloc_content): Add assert.
 157
 158 2019-06-25  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-winsource.c
 161         (tui_exec_info_window::maybe_allocate_content): New method.
 162         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 163         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 164         (make_source_or_disasm_window): Add cast.
 165         * tui/tui-data.h (union tui_which_element) <simple_string>:
 166         Remove.
 167         (struct tui_source_info): New.
 168         (struct tui_source_window_base) <execution_info>: Change type.
 169         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 170         case, and add assert.
 171         (tui_alloc_content): Add assert.
 172
 173 2019-06-25  Tom Tromey  <tom@tromey.com>
 174
 175         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 176         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 177         * tui/tui-data.c (tui_alloc_win_info): Remove.
 178
 179 2019-06-25  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 182         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 183         can_highlight.
 184
 185 2019-06-25  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 188         make_visible_with_new_height method.
 189         (tui_win_info::make_visible_with_new_height): New method.
 190         (tui_source_window_base::do_make_visible_with_new_height)
 191         (tui_data_window::do_make_visible_with_new_height)
 192         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 193         (make_visible_with_new_height): Remove.
 194         (tui_resize_all, tui_adjust_win_heights): Use
 195         make_visible_with_new_height method.
 196         * tui/tui-data.h (struct tui_win_info)
 197         <do_make_visible_with_new_height, make_visible_with_new_height>:
 198         New methods.
 199         (struct tui_source_window_base, struct tui_data_window)
 200         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 201         methods.
 202
 203 2019-06-25  Tom Tromey  <tom@tromey.com>
 204
 205         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 206         method.
 207         (update_tab_width): Call update_tab_width method.
 208         * tui/tui-data.h (struct tui_win_info)
 209         (struct tui_source_window_base) <update_tab_width>: New methods.
 210
 211 2019-06-25  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 214         parameter.
 215         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 216         parameter.
 217         (tui_gen_win_info::make_visible): Update.
 218         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 219         parameter.
 220         * tui/tui-data.h (enum tui_box): New enum.
 221         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 222
 223 2019-06-25  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 226         init_and_make_win for EXEC_INFO_WIN.
 227         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 228         longer inline.
 229         (struct tui_win_info) <~tui_win_info>: Inline.
 230         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 231         Don't declare.
 232         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 233         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 234         Remove.
 235         (tui_initialize_static_data): Update.
 236         (~tui_gen_win_info): Handle more cleanup here.
 237         (~tui_source_window_base): Delete "execution_info".
 238         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 239
 240 2019-06-25  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-layout.c (make_command_window): Don't set
 243         can_highlight.
 244         (show_source_disasm_command): Call the reset method.
 245         (show_data): Don't set can_highlight.  Call the reset method.
 246         (tui_gen_win_info::reset): Rename from init_gen_win_info
 247         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 248         (show_source_or_disasm_and_command): Call the reset method.
 249         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 250         (struct tui_cmd_window): Set can_highlight.
 251
 252 2019-06-25  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 255         from make_visible.
 256         (tui_make_visible, tui_make_invisible): Rewrite.
 257         (tui_win_info::make_visible): Remove.
 258         (tui_source_window_base::make_visible): Update.
 259         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 260         method.  Moved from...
 261         (struct tui_win_info) <make_visible>: ...here.
 262
 263 2019-06-25  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-winsource.c
 266         (tui_source_window_base::do_scroll_horizontal): Remove direction
 267         parameter.
 268         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 269         direction parameter.
 270         * tui/tui-win.c (tui_win_info::forward_scroll)
 271         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 272         (tui_win_info::right_scroll): Update.
 273         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 274         direction parameter.
 275         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 276         direction parameter.
 277         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 278         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 279         Remove direction parameter.
 280         (struct tui_source_window_base, struct tui_source_window)
 281         (struct tui_disasm_window, struct tui_data_window)
 282         (struct tui_cmd_window): Update.
 283
 284 2019-06-25  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-winsource.h (tui_set_exec_info_content)
 287         (tui_show_exec_info_content, tui_erase_exec_info_content)
 288         (tui_clear_exec_info_content, tui_update_exec_info): Change
 289         argument to tui_source_window_base.
 290         * tui/tui-winsource.c (tui_set_exec_info_content)
 291         (tui_show_exec_info_content, tui_erase_exec_info_content)
 292         (tui_clear_exec_info_content, tui_update_exec_info): Change
 293         argument to tui_source_window_base.
 294
 295 2019-06-25  Tom Tromey  <tom@tromey.com>
 296
 297         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 298         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 299
 300 2019-06-25  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 303         check.
 304
 305 2019-06-25  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 308         type to void.
 309         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 310         type to void.
 311         * tui/tui-source.c (tui_set_source_content): Update.
 312         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 313
 314 2019-06-25  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-win.c (window_name_completer, tui_set_focus)
 317         (tui_all_windows_info): Use name method.
 318         * tui/tui-data.h (struct tui_gen_win_info)
 319         (struct tui_source_window, struct tui_disasm_window)
 320         (struct tui_data_window, struct tui_cmd_window) <name>: New
 321         method.
 322         (tui_win_name): Don't declare.
 323         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 324         (tui_win_name): Remove.
 325
 326 2019-06-25  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-winsource.h (tui_update_source_window)
 329         (tui_update_source_window_as_is): Change parameter type.
 330         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 331         to be a tui_source_window_base.
 332         (tui_update_source_window_as_is): Likewise.
 333         * tui/tui-win.c (make_visible_with_new_height): Update.
 334
 335 2019-06-25  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-winsource.c (tui_erase_source_content)
 338         (tui_show_source_content, tui_show_exec_info_content)
 339         (tui_erase_exec_info_content): Use refresh_window method.
 340         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 341         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 342         from tui_refresh_win.
 343         (tui_data_window::refresh_window): New method.
 344         (tui_win_info::refresh, tui_source_window_base::refresh)
 345         (tui_refresh_all): Use refresh_window method.
 346         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 347         method.
 348         * tui/tui-regs.c (tui_display_register): Call refresh_window
 349         method.
 350         * tui/tui-layout.c (show_source_disasm_command)
 351         (show_source_or_disasm_and_command): Call refresh_window method.
 352         * tui/tui-data.h (struct tui_gen_win_info)
 353         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 354         New method.
 355
 356 2019-06-25  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui.c (tui_rl_other_window, tui_enable)
 359         (tui_is_window_visible, tui_get_command_dimension): Update.
 360         * tui/tui-winsource.c (tui_update_source_window_as_is)
 361         (tui_clear_source_content, tui_erase_source_content)
 362         (tui_show_source_line, tui_source_window_base::refill)
 363         (tui_source_window_base::do_scroll_horizontal)
 364         (tui_source_window_base::set_is_exec_point_at)
 365         (tui_update_breakpoint_info, tui_set_exec_info_content)
 366         (tui_alloc_source_buffer, tui_line_is_displayed)
 367         (tui_addr_is_displayed): Update.
 368         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 369         (tui_check_and_display_highlight_if_needed)
 370         (tui_win_info::make_visible, tui_win_info::refresh)
 371         (tui_refresh_all): Update.
 372         * tui/tui-windata.c (tui_first_data_item_displayed)
 373         (tui_delete_data_content_windows, tui_erase_data_content)
 374         (tui_display_all_data, tui_data_window::refresh_all)
 375         (tui_check_data_values): Update.
 376         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 377         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 378         (tui_win_info::backward_scroll, tui_refresh_all_win)
 379         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 380         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 381         (tui_source_window_base::set_new_height)
 382         (tui_data_window::set_new_height)
 383         (make_invisible_and_set_new_height)
 384         (make_visible_with_new_height, new_height_ok)
 385         (parse_scrolling_args): Update.
 386         * tui/tui-stack.c (tui_show_frame_info): Update.
 387         * tui/tui-source.c (tui_set_source_content)
 388         (tui_set_source_content_nil, tui_source_is_displayed)
 389         (tui_source_window::do_scroll_vertical): Update.
 390         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 391         (tui_display_registers_from, tui_display_reg_element_at_line)
 392         (tui_check_register_values, tui_reg_command): Update.
 393         * tui/tui-layout.c (tui_default_win_height)
 394         (show_source_disasm_command, show_data, init_and_make_win)
 395         (show_source_or_disasm_and_command): Update.
 396         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 397         (tui_redisplay_readline, tui_mld_flush)
 398         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 399         (tui_getc): Update.
 400         * tui/tui-disasm.c (tui_set_disassem_content)
 401         (tui_disasm_window::do_scroll_vertical): Update.
 402         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 403         Now virtual.
 404         (struct tui_win_info): Derive from tui_gen_win_info.
 405         <~tui_win_info>: Mark as override.
 406         <generic>: Remove member.
 407         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 408         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 409         (~tui_data_window, ~tui_win_info)
 410         (tui_free_all_source_wins_content): Update.
 411         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 412
 413 2019-06-25  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-layout.c (init_and_make_win): Use new.
 416         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 417         destructor, initializers.
 418         (tui_alloc_generic_win_info): Don't declare.
 419         * tui/tui-data.c (_locator): Add argument to constructor.
 420         (source_win, disasm_win): New globals.
 421         (exec_info): Remove.
 422         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 423         Update.
 424         (tui_alloc_generic_win_info): Remove.
 425         (init_content_element): Use new.
 426         (tui_win_info::tui_win_info): Update.
 427         (free_content_elements) <case DATA_WIN>: Use delete.
 428
 429 2019-06-25  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 432         * tui/tui-windata.c (tui_first_data_item_displayed)
 433         (tui_delete_data_content_windows): Update.
 434         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 435         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 436         (tui_display_registers_from, tui_check_register_values): Update.
 437         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 438         pointer.
 439         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 440         window.
 441         (tui_free_data_content): Update.
 442         (free_content_elements) <case DATA_WIN>: Free the window.
 443
 444 2019-06-25  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 447         Update.
 448         * tui/tui-layout.c (make_command_window)
 449         (show_source_disasm_command, show_data, init_and_make_win)
 450         (show_source_or_disasm_and_command): Update.
 451         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 452         method.
 453         <can_highight, is_highlighted>: Now bool.
 454         (tui_set_win_highlight): Don't declare.
 455         * tui/tui-data.c (tui_set_win_highlight): Remove.
 456
 457 2019-06-25  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-wingeneral.c (make_visible): Remove check of window
 460         type.
 461
 462 2019-06-25  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-win.c (tui_win_info::max_height)
 465         (tui_cmd_window::max_height): New methods.
 466         (new_height_ok): Call max_height.
 467         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 468         <max_height>: New method.
 469
 470 2019-06-25  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-win.c (tui_source_window_base::set_new_height)
 473         (tui_data_window::set_new_height): New methods.
 474         (make_invisible_and_set_new_height): Call set_new_height method.
 475         * tui/tui-data.h (struct tui_win_info)
 476         (struct tui_source_window_base, struct tui_data_window)
 477         <set_new_height>: New method.
 478
 479 2019-06-25  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 482         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 483         tui_refresh_data_win.
 484         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 485         method.
 486         (tui_refresh_all_win): Call the refresh_all method.
 487         (tui_set_focus): Likewise.
 488         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 489         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 490         Likewise.
 491
 492 2019-06-25  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-winsource.h (tui_refill_source_window)
 495         (tui_set_is_exec_point_at): Don't declare.
 496         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 497         (tui_source_window_base::refill): Rename from
 498         tui_refill_source_window.
 499         (tui_source_window_base::do_scroll_horizontal): Update.
 500         (tui_source_window_base::set_is_exec_point_at): Rename from
 501         tui_set_is_exec_point_at.
 502         (tui_update_all_breakpoint_info): Update.
 503         * tui/tui-stack.c (tui_show_frame_info): Update.
 504         * tui/tui-layout.c (show_data): Add cast.
 505         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 506         * tui/tui-data.h (struct tui_source_window_base) <refill,
 507         set_is_exec_point_at>: New methods.
 508         (tui_source_windows, tui_add_to_source_windows): Update types.
 509         (tui_add_to_source_windows): Remove redundant declaration.
 510         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 511         (tui_source_windows): Change return type.
 512         (tui_clear_source_windows_detail): Update.
 513         (tui_add_to_source_windows): Change type of parameter.
 514         (tui_free_all_source_wins_content): Update.
 515
 516 2019-06-25  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-wingeneral.c (tui_win_info::refresh)
 519         (tui_source_window_base::refresh): New methods.
 520         (tui_refresh_all): Call the refresh method.
 521         * tui/tui-data.h (struct tui_win_info)
 522         (struct tui_source_window_base) <refresh>: New method.
 523
 524 2019-06-25  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui.h (tui_is_window_visible): Return bool.
 527         * tui/tui.c (tui_is_window_visible): Return bool.
 528         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 529         (tui_make_visible, tui_make_invisible)
 530         (tui_win_info::make_visible)
 531         (tui_source_window_base::make_visible, make_all_visible)
 532         (tui_make_all_visible, tui_make_all_invisible): Update.
 533         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 534         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 535         bool.
 536         (struct tui_win_info, struct tui_source_window_base)
 537         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 538         * tui/tui-data.c (tui_init_generic_part): Update.
 539
 540 2019-06-25  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 543         (tui_source_window_base::make_visible): New methods.
 544         (make_all_visible): Make method call.
 545         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 546         (struct tui_source_window_base, struct tui_cmd_window): Override
 547         make_visible.
 548         (tui_win_is_source_type): Don't declare.
 549         * tui/tui-data.c (tui_win_is_source_type): Remove.
 550
 551 2019-06-25  Tom Tromey  <tom@tromey.com>
 552
 553         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 554         NULL check.
 555
 556 2019-06-25  Tom Tromey  <tom@tromey.com>
 557
 558         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 559         Inline constructor.  Add initializers for members.
 560         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 561         constructors; now inline in class.
 562
 563 2019-06-25  Tom Tromey  <tom@tromey.com>
 564
 565         * tui/tui-regs.c (tui_show_registers): Update.
 566         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 567         bool.
 568         * tui/tui-data.c (tui_data_window::clear_detail)
 569         (tui_data_window): Update.
 570
 571 2019-06-25  Tom Tromey  <tom@tromey.com>
 572
 573         * tui/tui-windata.c (tui_display_all_data)
 574         (tui_display_data_from_line, tui_display_data_from)
 575         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 576         Update.
 577         * tui/tui-regs.c (tui_last_regs_line_no)
 578         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 579         (tui_show_registers, tui_show_register_group)
 580         (tui_display_registers_from, tui_display_reg_element_at_line)
 581         (tui_display_registers_from_line, tui_check_register_values)
 582         (tui_reg_next, tui_reg_prev): Update.
 583         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 584         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 585         tui_data_window.
 586         (struct tui_win_info) <detail>: Remove.  Add new fields from
 587         tui_data_info.
 588         (TUI_DATA_WIN): Add cast.
 589         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 590         (~tui_data_window): Simplify.
 591
 592 2019-06-25  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-layout.c (show_source_disasm_command)
 595         (show_source_or_disasm_and_command): Update.
 596         * tui/tui-io.c (update_cmdwin_start_line)
 597         (tui_redisplay_readline): Update.
 598         * tui/tui-data.h (struct tui_command_info): Remove.
 599         (struct tui_win_info) <detail>: Remove command_info member.
 600         (struct tui_data_window) <start_line>: New member, from
 601         tui_command_info.
 602         (TUI_CMD_WIN): Add casts.
 603
 604 2019-06-25  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui-winsource.c (tui_update_source_window)
 607         (tui_refill_source_window)
 608         (tui_source_window_base::do_scroll_horizontal)
 609         (tui_update_breakpoint_info, tui_set_exec_info_content)
 610         (tui_show_exec_info_content, tui_erase_exec_info_content)
 611         (tui_clear_exec_info_content): Update.
 612         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 613         Update.
 614         * tui/tui-win.c (make_invisible_and_set_new_height)
 615         (make_visible_with_new_height): Update.
 616         * tui/tui-source.c (tui_set_source_content)
 617         (tui_show_symtab_source): Update.
 618         * tui/tui-layout.c (extract_display_start_addr)
 619         (show_source_disasm_command, show_data)
 620         (make_source_or_disasm_window)
 621         (show_source_or_disasm_and_command): Update.
 622         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 623         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 624         "gdbarch".
 625         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 626         to tui_source_window_base.
 627         (struct tui_win_info) <detail>: Remove source_info member.
 628         (struct tui_source_window_base) <has_locator>: Inline.
 629         Move contents from tui_source_info; rename has_locator member to
 630         m_has_locator.
 631         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 632         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 633         header file.
 634         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 635         Simplify.
 636         (tui_free_all_source_wins_content): Cast to
 637         tui_source_window_base.
 638
 639 2019-06-25  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-win.c (make_invisible_and_set_new_height)
 642         (make_visible_with_new_height): Call has_locator method.
 643         * tui/tui-layout.c (show_source_disasm_command, show_data)
 644         (show_source_or_disasm_and_command): Update for bool change.
 645         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 646         (tui_win_info) <has_locator>: New method.
 647         (struct tui_source_window_base) <has_locator>: New method.
 648         (tui_win_has_locator): Don't declare.
 649         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 650         from tui_win_has_locator.
 651         (tui_source_window_base): Use false, not FALSE.
 652
 653 2019-06-25  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 656         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 657         clear_detail method directly.
 658         (tui_clear_win_detail): Remove.
 659
 660 2019-06-25  Tom Tromey  <tom@tromey.com>
 661
 662         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 663         "this", not TUI_DISASM_WIN.
 664
 665 2019-06-25  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 668         declare.
 669         * tui/tui-winsource.c
 670         (tui_source_window_base::do_scroll_horizontal): Rename from
 671         tui_horizontal_source_scroll.
 672         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 673         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 674         from tui_vertical_data_scroll.
 675         * tui/tui-win.h (tui_scroll): Don't declare.
 676         * tui/tui-win.c (tui_win_info::forward_scroll)
 677         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 678         (tui_win_info::right_scroll): Rename and update.
 679         (tui_scroll_forward_command, tui_scroll_backward_command)
 680         (tui_scroll_left_command, tui_scroll_right_command): Update.
 681         (tui_scroll): Remove.
 682         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 683         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 684         from tui_vertical_source_scroll.
 685         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 686         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 687         from tui_vertical_disassem_scroll.
 688         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 689         do_scroll_horizontal>: New methods.
 690         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 691         Likewise.
 692         (struct tui_source_window_base): Add do_scroll_horizontal.
 693         (struct tui_source_window, struct tui_disasm_window): Add
 694         do_scroll_vertical.
 695         (struct tui_data_window, struct tui_cmd_window): Add
 696         do_scroll_horizontal and do_scroll_vertical.
 697         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 698
 699 2019-06-25  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-data.h (struct tui_source_window_base): New struct.
 702         (struct tui_source_window): Derive from tui_source_window_base.
 703         (struct tui_disasm_window): New struct.
 704         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 705         from tui_source_window::clear_detail.
 706         (tui_source_window_base): Rename from tui_source_window.
 707         (~tui_source_window_base): Rename from ~tui_source_window.
 708         (tui_alloc_win_info): Create a tui_disasm_window.
 709
 710 2019-06-25  Tom Tromey  <tom@tromey.com>
 711
 712         * tui/tui-data.h (struct tui_source_window)
 713         (struct tui_data_window): Declare destructors.
 714         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 715         destructors.
 716         (tui_win_info): Simplify.
 717
 718 2019-06-25  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-winsource.c (tui_display_main)
 721         (tui_update_source_windows_with_addr)
 722         (tui_update_all_breakpoint_info): Update.
 723         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 724         (new_height_ok, parse_scrolling_args): Update.
 725         * tui/tui-stack.c (tui_show_frame_info): Update.
 726         * tui/tui-data.h (struct tui_list): Remove.
 727         (tui_source_windows): Return a reference to a std::vector.
 728         * tui/tui-data.c (source_windows): Now a std::vector.
 729         (tui_source_windows): Change return type.
 730         (tui_clear_source_windows): Rewrite.
 731         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 732         (tui_free_all_source_wins_content): Rewrite.
 733
 734 2019-06-25  Tom Tromey  <tom@tromey.com>
 735
 736         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 737         (struct tui_data_window, struct tui_cmd_window): Declare
 738         clear_detail method.
 739         * tui/tui-data.c (tui_source_window::clear_detail)
 740         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 741         methods.
 742         (tui_clear_win_detail): Simplify.
 743
 744 2019-06-25  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-layout.c (make_source_window, make_disasm_window)
 747         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 748         Return the new window.
 749         (show_source_disasm_command, show_data)
 750         (show_source_or_disasm_and_command): Update.
 751
 752 2019-06-25  Tom Tromey  <tom@tromey.com>
 753
 754         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 755         parameter.  Return the new window.
 756         (show_source_disasm_command): Update and remove NULL check.
 757         (show_source_or_disasm_and_command): Update.
 758
 759 2019-06-25  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 762
 763 2019-06-25  Tom Tromey  <tom@tromey.com>
 764
 765         * tui/tui-data.h (struct tui_win_info): Make constructor
 766         protected.  Make destructor virtual.  Add initializers.
 767         (tui_source_window, tui_data_window, tui_cmd_window): New
 768         classes.
 769         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 770         constructor.  Add "type" parameter.
 771         (tui_source_window, tui_data_window, tui_cmd_window): New
 772         constructors.
 773         (tui_alloc_win_info): Instantiate the appropriate subclass.
 774
 775 2019-06-25  Tom Tromey  <tom@tromey.com>
 776
 777         * tui/tui-win.c (tui_resize_all): Use delete.
 778         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 779         destructor.
 780         (tui_free_window): Don't declare.
 781         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 782         Update.
 783
 784 2019-06-25  Tom Tromey  <tom@tromey.com>
 785
 786         * tui/tui-data.h (struct tui_win_info): Add constructor.
 787         * tui/tui-data.c (tui_alloc_win_info): Use new.
 788         (tui_free_window): Use delete.
 789
 790 2019-06-22  Tom Tromey  <tom@tromey.com>
 791
 792         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 793         declare.
 794         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 795
 796 2019-06-22  Tom Tromey  <tom@tromey.com>
 797
 798         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 799         declare.
 800         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 801
 802 2019-06-22  Tom de Vries  <tdevries@suse.de>
 803
 804         * dwarf2read.c (create_addrmap_from_aranges)
 805         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 806         instead of '%zu'.
 807
 808 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 809
 810         * dwarf2read.h (dwarf2_section_info_def): Remove.
 811         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 812         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 813         std::vector<dwarf2_section_info>.
 814         (struct dwo_file) <~dwo_file>: Remove.
 815         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 816         types field.
 817         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 818         (dwarf2_read_debug_names): Likewise.
 819         (create_debug_types_hash_table): Change parameter type to
 820         array_view, adjust code accordingly.
 821         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 822         (partial_die_info::fixup): Likewise.
 823         (determine_prefix): Likewise.
 824         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 825
 826 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 827
 828         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 829         gdb_bfd_ref_ptr.
 830         <~dwo_file>: Remove call to gdb_bfd_unref.
 831         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 832         gdb_bfd_ref_ptr::get.
 833
 834 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 835
 836         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 837         type to htab_up.
 838         * dwarf2read.c (struct dwo_file): Initialize fields.
 839         <~dwo_file>: New.
 840         (free_dwo_file): Remove, move content to ~dwo_file.
 841         (struct dwo_file_deleter): Remove.
 842         (dwo_file_up>: Remove custom deleter.
 843         (free_dwo_files): Remove.
 844         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 845         dwo_files.
 846         (process_skeletonless_type_units): Call unique_ptr::get.
 847         (allocate_dwo_file_hash_table): Add deleter to created hash
 848         table.  Change return type to htab_up.
 849         (lookup_dwo_file_slot): Don't memset dwo_file, call
 850         unique_ptr::get.
 851         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 852         (create_dwo_unit_in_dwp_v2): Likewise.
 853         (open_and_init_dwo_file): Likewise.
 854         (free_dwo_file_from_slot): Remove.
 855
 856 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 857
 858         * dwarf2read.h (struct dwarf2_section_info) <readin,
 859         is_virtual>: Change type to bool.
 860         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 861         true instead of 1.
 862
 863 2019-06-19  Tom Tromey  <tom@tromey.com>
 864
 865         * tui/tui-data.h (tui_init_content_element): Don't declare.
 866
 867 2019-06-19  Tom Tromey  <tom@tromey.com>
 868
 869         * tui/tui-data.h (tui_init_win_info): Don't declare.
 870
 871 2019-06-19  Tom de Vries  <tdevries@suse.de>
 872
 873         * dwarf2read.h (abstract_to_concrete): Change type to
 874         std::unordered_map<sect_offset, std::vector<sect_offset>,
 875         gdb::hash_enum<sect_offset>>.
 876
 877 2019-06-19  Tom Tromey  <tromey@adacore.com>
 878
 879         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 880         EVAL_AVOID_SIDE_EFFECTS specially.
 881
 882 2019-06-19  Tom Tromey  <tromey@adacore.com>
 883
 884         * source-cache.c (highlighter): New global.
 885         (source_cache::get_source_lines): Create a highlighter on demand.
 886
 887 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 888
 889         * defs.h (deprecated_interactive_hook): Delete declaration.
 890         * interps.c (clear_interpreter_hooks): Remove use of
 891         deprecated_interactive_hook.
 892         * top.c (deprecated_interactive_hook): Delete definition.
 893         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 894
 895 2019-06-18  Tom de Vries  <tdevries@suse.de>
 896
 897         PR gdb/24515
 898         * dwarf2read.h (abstract_to_concrete): Change type from
 899         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 900         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 901         * dwarf2read.c (read_variable): Update.
 902         (dwarf2_fetch_die_loc_sect_off): Update.
 903
 904 2019-06-17  Tom de Vries  <tdevries@suse.de>
 905
 906         PR gdb/24617
 907         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 908         accessing parent[parent_len - 1].
 909
 910 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 911
 912         PR gdb/24364
 913         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 914         call dtrace_process_dof with NULL dof.
 915
 916 2019-06-16  Tom de Vries  <tdevries@suse.de>
 917
 918         PR gdb/24445
 919         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 920
 921 2019-06-16  Tom Tromey  <tom@tromey.com>
 922
 923         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 924         (make_all_visible): Use address of member.
 925
 926 2019-06-16  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 929         (tui_free_window, free_content, free_content_elements): Remove
 930         unnecessary cast.
 931         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 932         cast.
 933         * tui/tui-regs.c (tui_show_register_group)
 934         (tui_display_registers_from, tui_display_reg_element_at_line):
 935         Remove unnecessary cast.
 936
 937 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 938
 939         * linux-nat.c (normal_mask): Delete.
 940         (_initialize_linux_nat): Don't initialise normal_mask.
 941
 942 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 943
 944         PR gdb/24445
 945         * dwarf-index-write.h (write_psymtabs_to_index): Add
 946         dwz_basename parameter.
 947         * dwarf-index-write.c (write_gdbindex): Move file writing to
 948         write_gdbindex_1.  Change return type void.
 949         (assert_file_size): Move up, remove filename parameter.
 950         (write_gdbindex_1): New function.
 951         (write_debug_names): Change return type to void, call
 952         assert_file_size.
 953         (struct index_wip_file): New struct.
 954         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 955         file logic to index_wip_file.  Write index for dwz file if
 956         needed.
 957         (save_gdb_index_command): Pass basename of dwz file, if present.
 958         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 959         build-id of dwz file, if present.
 960         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 961         (dwarf2_get_dwz_file): Likewise.
 962         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 963         (dwarf2_get_dwz_file): Likewise.
 964
 965 2019-06-16  Tom Tromey  <tom@tromey.com>
 966
 967         * coffread.c (process_coff_symbol): Use xstrdup.
 968         * value.c (create_internalvar): Use xstrdup.
 969
 970 2019-06-16  Tom Tromey  <tom@tromey.com>
 971
 972         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 973         * breakpoint.c (stopin_command, stopat_command)
 974         (until_break_command, decode_location_default): Remove unnecessary
 975         cast.
 976         * utils.c (subset_compare): Remove unnecessary cast.
 977         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 978         cast.
 979         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 980         cast.
 981         * infcmd.c (path_command): Remove unnecessary cast.
 982         * coffread.c (decode_type): Remove unnecessary cast.
 983         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 984         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 985         * tui/tui-stack.c (tui_show_locator_content)
 986         (tui_show_frame_info): Remove unnecessary cast.
 987         * tui/tui-win.c (tui_scroll_forward_command)
 988         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 989         (parse_scrolling_args): Remove unnecessary cast.
 990         * tui/tui-data.c (init_win_info, tui_del_window)
 991         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 992         (free_content_elements): Remove unnecessary cast.
 993         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 994         unnecessary cast.
 995         * tui/tui-source.c (tui_set_source_content)
 996         (tui_vertical_source_scroll): Remove unnecessary cast.
 997         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 998         cast.
 999         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1000         * tui/tui-regs.c (tui_display_registers_from)
1001         (tui_display_register): Remove unnecessary cast.
1002         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1003         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1004         (make_visible): Remove unnecessary cast.
1005         * tui/tui-winsource.c (tui_erase_source_content)
1006         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1007         unnecessary cast.
1008         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1009         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1010         * stabsread.c (read_type, read_array_type, read_range_type):
1011         Remove unnecessary cast.
1012         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1013         (parse_symbol, parse_type, upgrade_type, parse_external)
1014         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1015         unnecessary cast.
1016         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1017
1018 2019-06-16  Tom Tromey  <tom@tromey.com>
1019
1020         * tui/tui-data.c (tui_alloc_generic_win_info)
1021         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1022         checks.
1023
1024 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1025             Andrew Burgess  <andrew.burgess@embecosm.com>
1026
1027         * f-typeprint.c (f_print_type): Don't return early for not
1028         associated or not allocated types.
1029         (f_type_print_varspec_suffix): Add print_rank parameter and print
1030         ranks of array types in case they dangling.
1031         (f_type_print_base): Add print_rank parameter.
1032
1033 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * NEWS: Mention new MI commands.
1036         * break-catch-throw.c (enum exception_event_kind): Move to
1037         breakpoint.h.
1038         (print_mention_exception_catchpoint): Output text as a single
1039         message.
1040         (catch_exception_command_1): Rename to...
1041         (catch_exception_event): ...this, make non-static, update header
1042         command, and change some parameter types.
1043         (catch_catch_command): Update for changes to
1044         catch_exception_command_1.
1045         (catch_throw_command): Likewise.
1046         (catch_rethrow_command): Likewise.
1047         * breakpoint.c (enum exception_event_kind): Delete.
1048         * breakpoint.h (enum exception_event_kind): Moved here from
1049         break-catch-throw.c.
1050         (catch_exception_event): Declare.
1051         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1052         (mi_cmd_catch_throw): New function.
1053         (mi_cmd_catch_rethrow): New function.
1054         (mi_cmd_catch_catch): New function.
1055         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1056         'catch-catch' entries.
1057         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1058         (mi_cmd_catch_rethrow): Declare.
1059         (mi_cmd_catch_catch): Declare.
1060
1061 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1062
1063         * annotate.c (annotate_source_line): Change return type to void,
1064         update implementation to match.
1065         * annotate.h (annotate_source_line): Change return type to void,
1066         update header comment.
1067         * stack.c (print_frame_info): Don't change what frame information
1068         is printed based on whether annotations are on or not.
1069
1070 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1073         (annotate_source): Make static.
1074         (annotate_source_line): Moved from source.c and renamed from
1075         identify_source_line.  Update the return type.
1076         * annotate.h (annotate_source): Delete declaration.
1077         (annotate_source_line): Declaration moved from source.h, and
1078         renamed from identify_source_line.  Return type updated.
1079         * source.c (identify_source_line): Moved to annotate.c and renamed
1080         to annotate_source_line.
1081         (info_line_command): Remove check of annotation_level.
1082         * source.h (identify_source_line): Move declaration to annotate.h
1083         and rename to annotate_source_line.
1084         * stack.c: Add 'annotate.h' include.
1085         (print_frame_info): Remove check of annotation_level before
1086         calling annotate_source_line.
1087
1088 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1089
1090         * source-cache.c (source_cache::get_plain_source_lines): Use
1091         open_source_file_with_line_charpos instead of just
1092         open_source_file, remove call to find_source_lines.
1093         (source_cache::get_source_lines): Likewise.
1094         * source.c (find_source_lines): Make static.
1095         (get_filename_and_charpos): Renamed into...
1096         (open_source_file_with_line_charpos): ..this along with changes to
1097         return a scoped_fd, and some other minor clean ups.
1098         (identify_source_line): Use open_source_file_with_line_charpos.
1099         (search_command_helper): Use open_source_file_with_line_charpos
1100         instead of just open_source_file, remove call to
1101         find_source_lines.
1102         * source.h (open_source_file_with_line_charpos): Declare new
1103         function.
1104         (find_source_lines): Delete declaration.
1105
1106 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1107
1108         * source.c (get_filename_and_charpos): Remove fullname
1109         parameter.
1110         (identify_source_line): Update call to get_filename_and_charpos.
1111
1112 2019-06-14  Tom Tromey  <tromey@adacore.com>
1113
1114         PR gdb/24502:
1115         * ui-style.h (skip_ansi_escape): Update comment.
1116         * ui-file.h (class no_terminal_escape_file): New class.
1117         * ui-file.c (no_terminal_escape_file::write)
1118         (no_terminal_escape_file::puts): New methods.
1119         * cli/cli-logging.c (handle_redirections): Use
1120         no_terminal_escape_file.
1121
1122 2019-06-14  Tom Tromey  <tromey@adacore.com>
1123
1124         * NEWS: Move convenience variable news above Python news.
1125
1126 2019-06-14  Tom Tromey  <tom@tromey.com>
1127
1128         * gnulib: Move directory to top-level.
1129         * configure.ac: Don't configure gnulib.
1130         * configure: Rebuild.
1131         * common/common-defs.h: Use new path to gnulib.
1132         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1133         (GNULIB_H): Remove.
1134         (INCGNU): Look in new gnulib location.
1135         (HFILES_NO_SRCDIR): Remove gnulib files.
1136         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1137         (generated_files): Remove GNULIB_H.
1138         ($(LIBGNU), all-lib): Remove targets.
1139         (distclean): Don't mention GNULIB_BUILDDIR.
1140         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1141
1142 2019-06-14  Tom Tromey  <tromey@adacore.com>
1143
1144         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1145         Warn if symbol file does not provide any symbols.
1146
1147 2019-06-14  Tom Tromey  <tromey@adacore.com>
1148
1149         * source.c (find_and_open_source): Respect basenames_may_differ.
1150
1151 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1152
1153         * annotate.c (annotate_breakpoints_invalid): Make use of
1154         scoped_restore_terminal_state.
1155         (annotate_frames_invalid): Likewise.
1156
1157 2019-06-14  Tom Tromey  <tromey@adacore.com>
1158
1159         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1160         allow assignment to an internalvar.
1161
1162 2019-06-14  Tom Tromey  <tromey@adacore.com>
1163
1164         * ada-lex.l: Allow "_" in attribute names.
1165
1166 2019-06-14  Tom Tromey  <tromey@adacore.com>
1167
1168         PR gdb/24653:
1169         * regcache.c (registers_changed): Don't call alloca.
1170         * top.c (execute_command): Don't call alloca.
1171
1172 2019-06-13  Pedro Alves  <palves@redhat.com>
1173
1174         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1175         'expression'.  When parsing an expression, error out if there's
1176         junk after "unlimited".
1177         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1178         (do_set_command): Adjust calls to is_unlimited_literal.
1179
1180 2019-06-13  Pedro Alves  <palves@redhat.com>
1181
1182         * compile/compile.c (make_compile_options_def_group): Add braces
1183         around array_view initializer.
1184         * thread.c (make_thread_apply_all_options_def_group)
1185         (make_thread_apply_all_options_def_group): Likewise.
1186
1187 2019-06-13  Pedro Alves  <palves@redhat.com>
1188
1189         * NEWS (New commands): Mention "maint test-options
1190         require-delimiter", "maint test-options unknown-is-error", "maint
1191         test-options unknown-is-operand" and "maint show
1192         test-options-completion-result".
1193         (New command options, command completion): New section.
1194         (Completion improvements): New section.
1195         Mention that you can abbreviate "unlimited".
1196
1197 2019-06-13  Pedro Alves  <palves@redhat.com>
1198
1199         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1200         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1201         * unittests/cli-utils-selftests.c (test_parse_flags)
1202         (test_parse_flags_qcs): Delete.
1203         (test_cli_utils): Don't call deleted functions.
1204
1205 2019-06-13  Pedro Alves  <palves@redhat.com>
1206
1207         * thread.c: Include "cli/cli-option.h".
1208         (tp_array_compar_ascending): Global.
1209         (tp_array_compar): Delete function.
1210         (tp_array_compar_ascending, tp_array_compar_descending): New
1211         functions.
1212         (ascending_option_def, qcs_flag_option_def)
1213         (thr_qcs_flags_option_defs)
1214         (make_thread_apply_all_options_def_group)
1215         (make_thread_apply_options_def_group): New.
1216         (thread_apply_all_command): Use gdb::option::process_options.
1217         (thread_apply_command_completer)
1218         (thread_apply_all_command_completer): New.
1219         (thread_apply_command): Use gdb::option::process_options.
1220         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1221         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1222         to generate help text of "thread apply".  Adjust "taas"'s help.
1223         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1224         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1225
1226 2019-06-13  Pedro Alves  <palves@redhat.com>
1227
1228         * thread.c (thread_apply_command): Check for invalid TID with
1229         isdigit instead of !isalpha.
1230
1231 2019-06-13  Pedro Alves  <palves@redhat.com>
1232
1233         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1234         (validate_flags_qcs): New.
1235         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1236         (validate_flags_qcs): Declare.
1237         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1238         (make_frame_apply_options_def_group): New.
1239         (frame_apply_command_count): Process options with
1240         gdb::option::process_options.
1241         (frame_apply_completer): New.
1242         (frame_apply_level_completer, frame_apply_all_completer)
1243         (frame_apply_completer): New.
1244         (_initialize_stack): Update help of "frame apply", "frame apply
1245         level", "frame apply all" and "faas" to mention supported options
1246         and install command completers.
1247         * stack.h (frame_apply_all_completer): Declare.
1248         * thread.c: Include "stack.h".
1249         (tfaas_command): Add "--".
1250         (_initialize_thread): Update help "tfaas" to mention supported
1251         options and install command completer.
1252
1253 2019-06-13  Pedro Alves  <palves@redhat.com>
1254
1255         * completer.c (complete_nested_command_line): New.
1256         (gdb_completion_word_break_characters_throw): Add assertion.
1257         * completer.h (complete_nested_command_line): Declare.
1258
1259 2019-06-13  Pedro Alves  <palves@redhat.com>
1260
1261         * stack.c (parse_backtrace_qualifiers): New.
1262         (backtrace_command): Use it.
1263         (backtrace_command_completer): Complete on qualifiers.
1264
1265 2019-06-13  Pedro Alves  <palves@redhat.com>
1266
1267         * frame.c: Include "cli/cli-option.h.
1268         (user_set_backtrace_options): New.
1269         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1270         Delete.
1271         (get_prev_frame): Adjust.
1272         (boolean_option_def, uinteger_option_def)
1273         (set_backtrace_option_defs): New.
1274         (_initialize_frame): Adjust and use
1275         gdb::option::add_setshow_cmds_for_options to install "set
1276         backtrace past-main" and "set backtrace past-entry".
1277         * frame.h: Include "cli/cli-option.h".
1278         (struct frame_print_options): Forward declare.
1279         (print_frame_arguments_all, print_frame_arguments_scalars)
1280         (print_frame_arguments_none): Declare.
1281         (print_entry_values): Delete declaration.
1282         (struct frame_print_options, user_frame_print_options): New.
1283         (struct set_backtrace_options): New.
1284         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1285         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1286         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1287         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1288         (list_args_or_locals): Add frame_print_options parameter.
1289         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1290         * python/py-framefilter.c (enumerate_args): Pass down
1291         USER_FRAME_PRINT_OPTIONS.
1292         * stack.c: Include "cli/cli-option.h".
1293         (print_frame_arguments_all, print_frame_arguments_scalars)
1294         (print_frame_arguments_none): Declare.
1295         (print_raw_frame_arguments, print_entry_values): Delete.
1296         (user_frame_print_options): New.
1297         (boolean_option_def, enum_option_def, frame_print_option_defs):
1298         New.
1299         (struct backtrace_cmd_options): New.
1300         (bt_flag_option_def): New.
1301         (backtrace_command_option_defs): New.
1302         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1303         (print_frame_arg, read_frame_arg, print_frame_args)
1304         (print_frame_info, print_frame): Add frame_print_options parameter
1305         and use it.
1306         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1307         (backtrace_command_1): Add frame_print_options and
1308         backtrace_cmd_options parameters and use them.
1309         (make_backtrace_options_def_group): New.
1310         (backtrace_command): Process command options with
1311         gdb::option::process_options.
1312         (backtrace_command_completer): New.
1313         (_initialize_stack): Extend "backtrace"'s help to mention
1314         supported options.  Install completer for "backtrace".
1315         Install some settings commands with add_setshow_cmds_for_options.
1316
1317 2019-06-13  Pedro Alves  <palves@redhat.com>
1318
1319         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1320         and that "set/show print raw frame-arguments" are now deprecated.
1321
1322         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1323         command.
1324         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1325         * stack.c (_initialize_stack): Install "set/show print
1326         raw-frame-arguments", and deprecate "set/show print raw
1327         frame-arguments".
1328         * valprint.c (_initialize_valprint): Deprecate "set/show print
1329         raw".
1330
1331 2019-06-13  Pedro Alves  <palves@redhat.com>
1332
1333         * compile/compile.c (struct compile_options): New.
1334         (compile_flag_option_def, compile_command_option_defs)
1335         (make_compile_options_def_group): New.
1336         (compile_file_command): Handle options with
1337         gdb::option::process_options.
1338         (compile_file_command_completer): New function.
1339         (compile_code_command): Handle options with
1340         gdb::option::process_options.
1341         (compile_code_command_completer): New function.
1342         (_initialize_compiler): Install completers for "compile code" and
1343         "compile file".  Mention available options in "compile code" and
1344         "compile code"'s help.
1345         * completer.c (advance_to_completion_word): New, factored out from
1346         ...
1347         (advance_to_expression_complete_word_point): ... this.
1348         (advance_to_filename_complete_word_point): New.
1349         * completer.h (advance_to_filename_complete_word_point): New
1350         declaration.
1351
1352 2019-06-13  Pedro Alves  <palves@redhat.com>
1353
1354         * compile/compile.c: Include "cli/cli-option.h".
1355         (compile_print_value): Scope data pointer is now a
1356         value_print_options pointer; adjust.
1357         (compile_print_command): Process options.  Scope data pointer is
1358         now a value_print_options pointer; adjust.
1359         (_initialize_compile): Update "compile print"'s help to include
1360         supported options.  Install a completer for "compile print".
1361         * cp-valprint.c (show_vtblprint, show_objectprint)
1362         (show_static_field_print): Delete.
1363         (_initialize_cp_valprint): Don't install "set print
1364         static-members", "set print vtbl", "set print object" here.
1365         * printcmd.c: Include "cli/cli-option.h" and
1366         "common/gdb_optional.h".
1367         (print_command_parse_format): Rework to fill in a
1368         value_print_options instead of a format_data.
1369         (print_value): Change parameter type from format_data pointer to
1370         value_print_options reference.  Adjust.
1371         (print_command_1): Process options.  Adjust to pass down a
1372         value_print_options.
1373         (print_command_completer): New.
1374         (_initialize_printcmd): Install print_command_completer as
1375         handle_brkchars completer for the "print" command.  Update
1376         "print"'s help to include supported options.
1377         * valprint.c: Include "cli/cli-option.h".
1378         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1379         here from cp-valprint.c.
1380         (boolean_option_def, uinteger_option_def)
1381         (value_print_option_defs, make_value_print_options_def_group):
1382         New.  Use gdb::option::add_setshow_cmds_for_options to install
1383         "set print elements", "set print null-stop", "set print repeats",
1384         "set print pretty", "set print union", "set print array", "set
1385         print address", "set print symbol", "set print array-indexes".
1386         * valprint.h: Include <string> and "cli/cli-option.h".
1387         (make_value_print_options_def_group): Declare.
1388         (print_value): Change parameter type from format_data pointer to
1389         value_print_options reference.
1390         (print_command_completer): Declare.
1391
1392 2019-06-13  Pedro Alves  <palves@redhat.com>
1393
1394         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1395         (COMMON_SFILES): Add maint-test-settings.c.
1396         * cli/cli-decode.c (boolean_enums): New global, factored out from
1397         ...
1398         (add_setshow_boolean_cmd): ... here.
1399         * cli/cli-decode.h (boolean_enums): Declare.
1400         * cli/cli-option.c: New file.
1401         * cli/cli-option.h: New file.
1402         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1403         factored out from ...
1404         (parse_cli_boolean_value(const char *)): ... this.
1405         (is_unlimited_literal): Change parameter type to pointer to
1406         pointer.  Adjust and advance ARG pointer.
1407         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1408         (parse_cli_var_enum): New, factored out from ...
1409         (do_set_command): ... this.  Adjust.
1410         * cli/cli-setshow.h (parse_cli_boolean_value)
1411         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1412         (parse_cli_var_enum): Declare.
1413         * cli/cli-utils.c: Include "cli/cli-option.h".
1414         (get_ulongest): New.
1415         * cli/cli-utils.h (get_ulongest): Declare.
1416         (check_for_argument): New overloads.
1417         * maint-test-options.c: New file.
1418
1419 2019-06-13  Pedro Alves  <palves@redhat.com>
1420
1421         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1422         parse a range if "-" is at the end of the string.
1423
1424 2019-06-13  Pedro Alves  <palves@redhat.com>
1425
1426         * cli/cli-setshow.c (parse_auto_binary_operation)
1427         (parse_cli_boolean_value): Don't allow "o".
1428
1429 2019-06-13  Pedro Alves  <palves@redhat.com>
1430
1431         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1432         * NEWS: Mention maint test-settings KIND.
1433         * maint-test-settings.c: New file.
1434
1435 2019-06-13  Pedro Alves  <palves@redhat.com>
1436
1437         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1438         completer.
1439         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1440         "set" completers.
1441
1442 2019-06-13  Pedro Alves  <palves@redhat.com>
1443
1444         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1445         after item.
1446
1447 2019-06-13  Pedro Alves  <palves@redhat.com>
1448
1449         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1450
1451 2019-06-13  Pedro Alves <palves@redhat.com>
1452
1453         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1454         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1455         call.
1456         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1457         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1458         calls.
1459         (check_for_argument): Skip spaces after argument.
1460
1461 2019-06-13  Pedro Alves  <palves@redhat.com>
1462
1463         * thread.c (thread_apply_command): Adjust TID parsing.
1464         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1465         detected before end of string.
1466         (tid_is_in_list): Error out if LIST is invalid.
1467
1468 2019-06-13  Pedro Alves  <palves@redhat.com>
1469
1470         * completer.c (complete_line_internal_1): Rewind completion word
1471         point.
1472         (completion_tracker::advance_custom_word_point_by): Change
1473         parameter type to int.
1474         * completer.h (completion_tracker::advance_custom_word_point_by):
1475         Likewise.
1476
1477 2019-06-13  Pedro Alves  <palves@redhat.com>
1478
1479         * completer.c (advance_to_completion_word): Handle delimiters.
1480
1481 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1482
1483         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1484
1485 2019-06-11  Tom Tromey  <tom@tromey.com>
1486
1487         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1488         (xmalloc_failed): Move to alloc.c.
1489         * alloc.c: New file.
1490         * Makefile.in (COMMON_SFILES): Add alloc.c.
1491
1492 2019-06-11  Tom Tromey  <tom@tromey.com>
1493
1494         * nat/linux-waitpid.c: Don't include server.h.
1495         (linux_debug): Remove.
1496         (my_waitpid): Update.
1497
1498 2019-06-11  Tom Tromey  <tromey@adacore.com>
1499
1500         * infcall.c (_initialize_infcall): Remove trailing newline from
1501         help.
1502         * user-regs.c (_initialize_user_regs): Remove trailing newline
1503         from help.
1504         * typeprint.c (_initialize_typeprint): Remove trailing newline
1505         from help.
1506         * reverse.c (_initialize_reverse): Remove trailing newlines from
1507         help.
1508         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1509         from help.
1510         * language.c (add_set_language_command): Remove trailing newline
1511         from help.
1512         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1513         help.
1514         * disasm.c (_initialize_disasm): Remove trailing newline from
1515         help.
1516         * top.c (init_main): Remove trailing newline from help.
1517         * interps.c (_initialize_interpreter): Remove trailing newline
1518         from help.
1519         * btrace.c (_initialize_btrace): Remove trailing newlines from
1520         help.
1521         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1522         from help.
1523         * python/python.c (_initialize_python): Remove trailing newline
1524         from help.
1525         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1526         help.
1527         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1528         from help.  Reformat some text.
1529         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1530         from help.
1531         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1532         newline from help.
1533
1534 2019-06-11  Tom Tromey  <tromey@adacore.com>
1535
1536         * darwin-nat.c (darwin_decode_exception_message)
1537         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1538
1539 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1540
1541         * valops.c (value_slice): Check for not allocated or not
1542         associated values.
1543
1544 2019-06-10  Tom de Vries  <tdevries@suse.de>
1545
1546         PR gdb/24618
1547         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1548         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1549         invalid.
1550
1551 2019-06-10  Tom de Vries  <tdevries@suse.de>
1552
1553         PR gdb/24611
1554         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1555         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1556
1557 2019-06-10  Tom de Vries  <tdevries@suse.de>
1558
1559         PR symtab/24545
1560         * symtab.c (struct demangled_name_entry): Add language field.
1561         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1562         static minimal symbol".  Set and use language field.
1563
1564 2019-06-10  Tom Tromey  <tromey@adacore.com>
1565
1566         * ada-lang.c (_initialize_ada_language): Update help text.
1567
1568 2019-06-10  Tom Tromey  <tromey@adacore.com>
1569
1570         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1571         with a newline.
1572         * guile/guile.c (handle_boot_error): Don't end warning with a
1573         newline.
1574         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1575         warning with a newline.
1576         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1577         newline.
1578         (s12z_frame_cache): Likewise.
1579         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1580         a newline.
1581         * solib-svr4.c (disable_probes_interface): Don't end warning with
1582         a newline.
1583         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1584         newline.
1585         * python/python.c (do_finish_initialization): Don't end warning
1586         with a newline.
1587
1588 2019-06-10  Tom Tromey  <tom@tromey.com>
1589
1590         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1591         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1592         gdbpy_enter.
1593
1594 2019-06-10  Tom Tromey  <tromey@adacore.com>
1595
1596         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1597         data.
1598         (elf_new_init): Don't call stabsread_new_init.
1599         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1600         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1601         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1602
1603 2019-06-10  Tom de Vries  <tdevries@suse.de>
1604
1605         PR symtab/16264
1606         PR symtab/24517
1607         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1608
1609 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1610
1611         * source.c (find_and_open_source): Also rewrite relative file
1612         names.
1613
1614 2019-04-26  Amos Bird  <amosbird@gmail.com>
1615
1616         * annotate.c (annotate_thread_exited): Add "thread-exited"
1617         annotation.
1618
1619 2019-06-06  Tom Tromey  <tromey@adacore.com>
1620
1621         * maint.h (class scoped_command_stats): Use
1622         DISABLE_COPY_AND_ASSIGN.
1623         <print_time>: New method.
1624         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1625         print_time.
1626         (scoped_command_stats::print_time): New method.
1627
1628 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1629
1630         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1631         instructions of lengths 6 or 8 bytes.
1632
1633 2019-06-04  Pedro Alves  <palves@redhat.com>
1634
1635         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1636
1637         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1638         * breakpoint.c (condition_completer): Likewise.
1639         * cli/cli-dump.c (scan_expression): Likewise.
1640         * common/filestuff.c (mkdir_recursive): Likewise.
1641         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1642         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1643         (gdb_abspath): Likewise.
1644         * compile/compile-cplus-types.c
1645         (compile_cplus_instance::decl_name): Likewise.
1646         * completer.c (complete_explicit_location):
1647         (signal_completer, reg_or_group_completer_1): Likewise.
1648         * cp-support.c (cp_remove_params_if_any): Likewise.
1649         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1650         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1651         * infcmd.c (strip_bg_char): Likewise.
1652         * linespec.c (copy_token_string): Likewise.
1653         * mi/mi-main.c (output_cores): Likewise.
1654         * psymtab.c (psymtab_search_name):
1655         * symfile.c (test_set_ext_lang_command): Likewise.
1656         * target.c (target_fileio_read_stralloc): Likewise.
1657         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1658         * value.c (complete_internalvar): Likewise.
1659
1660 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1661
1662         Add objfile property to gdb.Type.
1663         * NEWS: Mention Python API addition.
1664         * python/py-type.c (typy_get_objfile): New method.
1665
1666 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1667
1668         * NEWS: Mention the new set|show style [title|highlight].
1669         Mention changes to "show style", "help" and "apropos".
1670
1671 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1672
1673         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1674         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1675         instead of print_help_for_command.
1676         (print_doc_of_command): New function.
1677         (help_list): Add 'apropos -v word' suggestion.
1678         (print_help_for_command): Style the command name using title style.
1679         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1680         (_initialize_cli_cmds): Describe -v in apropos_command help.
1681
1682 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1683
1684         * cli/cli-style.h (cli_style_option): Add name in constructor,
1685         add m_name class member, add constructor with intensity,
1686         add name class function.
1687         (cli_style_option::add_setshow_commands): Remove name argument.
1688         (highlight_style, title_style): New styles.
1689         * cli/cli-style.c (do_show): New function that shows a style
1690         characteristic styling the style name with itself.
1691         (set_style_name): New function.
1692         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1693         Update all callers according to the changes in cli/cli-style.h.
1694         * utils.h (fputs_highlighted): New function.
1695         * utils.c (fputs_highlighted): Likewise.
1696
1697 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1698
1699         * NEWS: Mention new pipe command and new convenience variables.
1700
1701 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1702
1703         * cli/cli-cmds.c (pipe_command): New function.
1704         (_initialize_cli_cmds): Call add_com for pipe_command.
1705         Define | as an alias for pipe.
1706         (exit_status_set_internal_vars): New function.
1707         (shell_escape): Call exit_status_set_internal_vars.
1708         cli/cli-decode.c (find_command_name_length): Recognize | as
1709         a single character command.
1710
1711 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1712
1713         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1714         top.c (execute_command_to_ui_file): New function, mostly a copy
1715         of execute_command_to_string.
1716         (execute_command_to_string): Implement by calling
1717         execute_command_to_ui_file.
1718
1719 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1720
1721         * top.h (saved_command_line): Remove declaration.
1722         * top.c (previous_saved_command_line, previous_repeat_arguments):
1723         New variables.
1724         (saved_command_line): Make static, define together with other
1725         'repeat variables'.
1726         (dont_repeat): Clear repeat_arguments.
1727         (repeat_previous, get_saved_command_line, save_command_line):
1728         New functions.
1729         (gdb_init): Initialize saved_command_line
1730         and previous_saved_command_line.
1731         * main.c (captured_main_1): Remove saved_command_line initialization.
1732         * event-top.c (handle_line_of_input): Update to use
1733         the new 'repeat' related functions instead of direct access to
1734         saved_command_line.
1735         * command.h (repeat_previous, get_saved_command_line,
1736         save_command_line): New declarations.
1737         (dont_repeat): Add comment.
1738
1739 2019-05-30  Tom Tromey  <tromey@adacore.com>
1740
1741         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1742         Fix comment.
1743         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1744
1745 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1746
1747         PR cli/24587
1748         * completer.c (complete): Initialize variable word.
1749
1750 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1751
1752         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1753         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1754         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1755         'body' is NULL to the outter 'if', protecting the '!is_define'
1756         situation as well.
1757
1758 2019-05-29  Tom Tromey  <tromey@adacore.com>
1759
1760         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1761         (dwarf_unknown): New function.
1762         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1763         (dwarf_type_encoding_name): Use dwarf_unknown.
1764
1765 2019-05-29  Tom Tromey  <tromey@adacore.com>
1766
1767         PR c++/20020:
1768         * cp-valprint.c (cp_print_value_fields): Call
1769         cp_print_static_field inside "try".
1770
1771 2019-05-29  Tom Tromey  <tromey@adacore.com>
1772
1773         * inflow.c (struct terminal_info): Add default operator=.
1774         * configure: Rebuild.
1775         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1776         -Wdeprecated-copy-dtor, -Wredundant-move.
1777
1778 2019-05-29  Tom Tromey  <tromey@adacore.com>
1779
1780         * NEWS: Add entry.
1781         * infcmd.c (print_return_value_1): Handle finish_print
1782         option.
1783         (show_print_finish): New function.
1784         (_initialize_infcmd): Add "set/show print finish" commands.
1785         * valprint.c (user_print_options): Initialize new member.
1786         * valprint.h (struct value_print_options) <finish_print>: New
1787         member.
1788
1789 2019-05-28  Tom Tromey  <tromey@adacore.com>
1790
1791         * ada-lang.c (ada_remove_Xbn_suffix)
1792         (find_old_style_renaming_symbol)
1793         (parse_old_style_renaming): Remove.
1794         (ada_find_renaming_symbol): Don't call
1795         find_old_style_renaming_symbol.
1796         (ada_is_renaming_symbol): Rename from
1797         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1798         bool.  Now static.
1799         (ada_read_var_value): Update and simplify.
1800         * ada-exp.y (write_var_or_type): Remove old code.
1801
1802 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1803
1804         * event-top.c: Remove include comment.
1805         * inflow.c (class scoped_ignore_sigttou): Move from here...
1806         * inflow.h (class scoped_ignore_sigttou): ...to here.
1807         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1808         * top.c:  Remove include comment.
1809
1810 2019-05-27  Tom Tromey  <tom@tromey.com>
1811
1812         * NEWS: Fix typo.
1813
1814 2019-05-22  Tom Tromey  <tromey@adacore.com>
1815
1816         * target.c (target_follow_exec): Constify parameter.
1817         * target-delegates.c: Rebuild.
1818         * remote.c (remote_target::follow_exec): Constify parameter.
1819         * infrun.c (follow_exec): Constify parameter.
1820         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1821         (target_follow_exec): Likewise.
1822
1823 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1824
1825         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1826         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1827
1828 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1829
1830         * NEWS: Add debugredirect and testsuite sections.
1831
1832 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1833
1834         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1835         target descriptions using exclusively floating point register name
1836         aliases.
1837
1838 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1839
1840         PR gdb/18644:
1841         * f-lang.c (build_fortran_types): Handle the case where
1842         gdbarch_floatformat_for_type returns a nullptr.
1843
1844 2019-05-21  Tom de Vries  <tdevries@suse.de>
1845
1846         PR cli/24587
1847         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1848
1849 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1850
1851         PR gdb/18644:
1852         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1853         16-byte floats.
1854         * i386-tdep.c (i386_floatformat_for_type): Use
1855         floatformats_ia64_quad for the 16-byte floating point component
1856         within a fortran 32-byte complex number.
1857
1858 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1859
1860         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1861         delete default constructor.
1862         (find_partial_die): Update to return const struct.
1863         (partial_die_parent_scope): Move variable declaration into scope
1864         of its use and change its type to auto.
1865         (guess_partial_die_structure_name): Likewise.
1866         (partial_die_info::fixup): Likewise.
1867
1868 2019-05-17  Tom Tromey  <tromey@adacore.com>
1869
1870         * source.c (find_and_open_source): Remove cast.
1871
1872 2019-05-17  Tom Tromey  <tromey@adacore.com>
1873
1874         * annotate.c (annotate_source): Make "filename" const.
1875         * annotate.h (annotate_source): Use const.
1876
1877 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1878
1879         * disasm.c (set_disassembler_options): Send errors to stderr.
1880
1881 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1882
1883         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1884         (cli_interp_base::set_logging): Check debug_redirect.
1885         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1886         * cli/cli-logging.c (debug_redirect): Add static variable.
1887         (pop_output_files): Add default param.
1888         (handle_redirections): Print debug setting.
1889         (show_logging_command): Likewise.
1890         (_initialize_cli_logging): Add debugredirect command.
1891         * interps.c (current_interp_set_logging): Add debug_redirect
1892         parameter.
1893         * interps.h (set_logging): Add debug_redirect parameter.
1894         (current_interp_set_logging): Likewise.
1895         * mi/mi-common.h: Likewise.
1896         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1897
1898 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1899             Tom Tromey  <tromey@adacore.com>
1900
1901         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1902         directly.
1903         * cli/cli-interp.h (make_logging_output): Remove declaration.
1904         * cli/cli-logging.c (make_logging_output): Remove function.
1905         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1906         directly.
1907         * ui-file.c (tee_file::tee_file): Remove bools.
1908         (tee_file::~tee_file): Remove deletes.
1909         * ui-file.h (tee_file): Remove bools.
1910
1911 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1912
1913         * mi/mi-cmds.h (mi_cmd_complete): New function.
1914         * mi/mi-main.c (mi_cmd_complete): Likewise.
1915         * mi/mi-cmds.c: Define new MI command -complete.
1916         * NEWS: Mention new -complete command.
1917
1918 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1919
1920         * completer.h (complete): New function.
1921         * completer.c (complete): Likewise.
1922         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1923         function defined in completer.h.
1924
1925 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1926
1927         * MAINTAINERS (Write After Approval): Add myself.
1928
1929 2019-05-17  Tom de Vries  <tdevries@suse.de>
1930
1931         PR gdb/24094
1932         * dwarf2read.c (struct cu_partial_die_info): New struct.
1933         (find_partial_die): Return cu_partial_die_info.
1934         (partial_die_parent_scope, guess_partial_die_structure_name)
1935         (partial_die_info::fixup): Handle new return type of find_partial_die.
1936
1937 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1938
1939         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1940         "std::string", simplifying the algorithm.
1941
1942 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1943
1944         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1945         (stap_static_probe_ops::get_probes): Likewise.
1946
1947 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1948
1949         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1950         '-')" and "else if".
1951         (stap_parse_single_operand): Join checks for
1952         "gdbarch_stap_parse_special_token_p" and
1953         "gdbarch_stap_parse_special_token" in the same "if" statement.
1954         Invert check when verifying for operation on register
1955         displacement.
1956
1957 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1958
1959         * stap-probe.c (stap_get_opcode): Update comment.
1960         (stap_get_expected_argument_type): Likewise.
1961         (handle_stap_probe): Likewise.
1962
1963 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1964
1965         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1966         return type to 'bool'.  Adjust comment.  Use 'bool' when
1967         appropriate.
1968         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1969         * stap-probe.c (stap_parse_argument_1): Likewise.
1970         (stap_is_operator): Likewise.
1971         (stap_is_generic_prefix): Likewise.
1972         (stap_is_register_prefix): Likewise.
1973         (stap_is_register_indirection_prefix): Likewise.
1974         (stap_is_integer_prefix): Likewise.
1975         (stap_generic_check_suffix): Likewise.
1976         (stap_check_integer_suffix): Likewise.
1977         (stap_check_register_suffix): Likewise.
1978         (stap_check_register_indirection_suffix): Likewise.
1979         (stap_parse_register_operand): Likewise.
1980         (stap_parse_single_operand): Likewise.
1981         (stap_parse_argument_1): Likewise.
1982         (stap_probe::get_argument_count): Likewise.
1983         (stap_is_operator): Likewise.
1984
1985 2019-05-16  Tom Tromey  <tromey@adacore.com>
1986
1987         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1988         keyword to foreach.
1989
1990 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1991
1992         * linux-thread-db.c (try_thread_db_load_1): Change return type
1993         to bool.
1994         (try_thread_db_load): Likewise.
1995         (try_thread_db_load_from_pdir_1): Likewise.
1996         (try_thread_db_load_from_pdir): Likewise.
1997         (try_thread_db_load_from_sdir): Likewise.
1998         (try_thread_db_load_from_dir): Likewise.
1999         (thread_db_load_search): Likewise.
2000         (has_libpthread): Likewise.
2001         (thread_db_load): Likewise.
2002
2003 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2004
2005         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2006         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2007         NULL, and complain/return if that's the case.
2008
2009 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2010
2011         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2012         (advance, posn, abstract_read_memory): New functions.
2013         [struct mem_read_abstraction]: New struct.
2014         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2015
2016 2019-05-14  Tom Tromey  <tromey@adacore.com>
2017
2018         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2019         value is not lval_memory.
2020
2021 2019-05-14  Tom Tromey  <tromey@adacore.com>
2022
2023         * solib.c (info_sharedlibrary_command): Style the file name.
2024
2025 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2026
2027         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2028         (aarch64_vnv_type): Likewise.
2029         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2030         * common/tdesc.c: Likewise.
2031         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2032         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2033         * features/aarch64-fpu.xml: Add ieee half view.
2034         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2035         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2036         * gdbtypes.h (struct builtin_type): Likewise.
2037         (struct objfile_type): Likewise.
2038
2039 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2040
2041         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2042         typo.
2043         * location.h (string_to_event_location): Likewise.
2044
2045 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2046
2047         GDB 8.3 released.
2048
2049 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2050
2051         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2052         New variable declaration.
2053         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2054         New variable.
2055         (print_one_breakpoint): Use ui_out::test_flags and new global
2056         variable to compute use_fixed_output.
2057         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2058         Remove.
2059         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2060         (mi_multi_location_breakpoint_output_fixed): Remove.
2061         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2062         new variable.
2063         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2064         fix_multi_location_breakpoint_output flag if version >= 3.
2065         * ui-out.h (enum ui_out_flag)
2066         <fix_multi_location_breakpoint_output>: New enumerator.
2067
2068 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2069
2070         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2071
2072 2019-05-10  Tom Tromey  <tromey@adacore.com>
2073
2074         * ada-lang.c (catch_ada_completer): New function.
2075         (_initialize_ada_language): Use it.
2076
2077 2019-05-10  Tom Tromey  <tromey@adacore.com>
2078
2079         * thread.c (print_thread_info): Make "requested_threads" const.
2080         * gdbthread.h (print_thread_info): Make "requested_threads"
2081         const.
2082         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2083         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2084
2085 2019-05-08  Tom Tromey  <tom@tromey.com>
2086
2087         * gdbtypes.c (objfile_type_data): Change type.
2088         (objfile_type, _initialize_gdbtypes): Update.
2089
2090 2019-05-08  Tom Tromey  <tom@tromey.com>
2091
2092         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2093         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2094         (_initialize_dwarf2_frame): Update.
2095
2096 2019-05-08  Tom Tromey  <tom@tromey.com>
2097
2098         * objc-lang.c (objc_objfile_data): Change type.
2099         (find_methods): Update.
2100         (_initialize_objc_lang): Remove.
2101
2102 2019-05-08  Tom Tromey  <tom@tromey.com>
2103
2104         * stabsread.c (rs6000_builtin_type_data): Change type.
2105         (rs6000_builtin_type, _initialize_stabsread): Update.
2106
2107 2019-05-08  Tom Tromey  <tom@tromey.com>
2108
2109         * mips-tdep.c (mips_pdr_data): Remove.
2110         (_initialize_mips_tdep): Update.
2111
2112 2019-05-08  Tom Tromey  <tom@tromey.com>
2113
2114         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2115         (hppa_init_objfile_priv_data, read_unwind_info)
2116         (find_unwind_entry, _initialize_hppa_tdep): Update.
2117
2118 2019-05-08  Tom Tromey  <tom@tromey.com>
2119
2120         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2121         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2122         on obstack.
2123         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2124
2125 2019-05-08  Tom Tromey  <tom@tromey.com>
2126
2127         * mdebugread.c (basic_type_data): Change type.
2128         (basic_type, _initialize_mdebugread): Update.
2129
2130 2019-05-08  Tom Tromey  <tom@tromey.com>
2131
2132         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2133
2134 2019-05-08  Tom Tromey  <tom@tromey.com>
2135
2136         * nto-tdep.c (nto_inferior_data_reg): Change type.
2137         (nto_inferior_data): Update.
2138         (nto_inferior_data_cleanup, nto_new_inferior_data)
2139         (_initialize_nto_tdep): Remove.
2140         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2141
2142 2019-05-08  Tom Tromey  <tom@tromey.com>
2143
2144         * ada-lang.c (struct ada_inferior_data): Add initializers.
2145         (ada_inferior_data): Change type.
2146         (ada_inferior_data_cleanup): Remove.
2147         (get_ada_inferior_data, ada_inferior_exit)
2148         (struct ada_pspace_data): Add initializers, destructor.
2149         (ada_pspace_data_handle): Change type.
2150         (get_ada_pspace_data): Update.
2151         (ada_pspace_data_cleanup): Remove.
2152
2153 2019-05-08  Tom Tromey  <tom@tromey.com>
2154
2155         * coffread.c (struct coff_symfile_info): Add initializers.
2156         (coff_objfile_data_key): Move lower.  Change type.
2157         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2158         Update.
2159         (coff_free_info): Remove.
2160
2161 2019-05-08  Tom Tromey  <tom@tromey.com>
2162
2163         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2164         (fbsd_pspace_data_handle): Move lower.  Change type.
2165         (get_fbsd_pspace_data): Update.
2166         (fbsd_pspace_data_cleanup): Remove.
2167         (_initialize_fbsd_tdep): Update.
2168
2169 2019-05-08  Tom Tromey  <tom@tromey.com>
2170
2171         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2172         (get_ada_tasks_pspace_data): Update.
2173         (ada_tasks_pspace_data_cleanup): Remove.
2174         (_initialize_tasks): Update.
2175         (ada_tasks_inferior_data_handle): Change type.
2176         (get_ada_tasks_inferior_data): Update.
2177         (ada_tasks_inferior_data_cleanup): Remove.
2178         (struct ada_tasks_pspace_data): Add initializers.
2179
2180 2019-05-08  Tom Tromey  <tom@tromey.com>
2181
2182         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2183         * symfile-debug.c (debug_sym_get_probes): Change type.
2184         * stap-probe.c (handle_stap_probe):
2185         (stap_static_probe_ops::get_probes): Change type.
2186         * probe.h (class static_probe_ops) <get_probes>: Change type.
2187         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2188         (parse_probes_in_pspace): Update.
2189         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2190         Update.
2191         (any_static_probe_ops::get_probes): Change type.
2192         * elfread.c (elfread_data): New typedef.
2193         (probe_key): Change type.
2194         (elf_get_probes): Likewise.  Update.
2195         (probe_key_free): Remove.
2196         (_initialize_elfread): Update.
2197         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2198         Change type.
2199         (dtrace_process_dof_probe, dtrace_process_dof)
2200         (dtrace_static_probe_ops::get_probe): Change type.
2201
2202 2019-05-08  Tom Tromey  <tom@tromey.com>
2203
2204         * xcoffread.c (struct xcoff_symfile_info): Rename from
2205         coff_symfile_info.  Add initializers.
2206         (xcoff_objfile_data_key): Move lower.  Change type.
2207         (XCOFF_DATA): Rewrite.
2208         (xcoff_free_info): Remove.
2209         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2210         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2211         (xcoff_initial_scan): Update.
2212
2213 2019-05-08  Tom Tromey  <tom@tromey.com>
2214
2215         * solib-svr4.c (struct svr4_info): Add initializers and
2216         destructor.
2217         <probes_table>: Now an htab_up.
2218         (solib_svr4_pspace_data): Change type.
2219         (free_probes_table): Simplify.
2220         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2221         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2222         (probes_table_remove_objfile_probes, register_solib_event_probe)
2223         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2224         (_initialize_svr4_solib): Update.
2225
2226 2019-05-08  Tom Tromey  <tom@tromey.com>
2227
2228         * remote.c (remote_pspace_data): Change type.
2229         (remote_pspace_data_cleanup): Remove.
2230         (get_remote_exec_file, set_pspace_remote_exec_file)
2231         (_initialize_remote): Update.
2232
2233 2019-05-08  Tom Tromey  <tom@tromey.com>
2234
2235         * breakpoint.c (breakpoint_objfile_key): Change type.
2236         (get_breakpoint_objfile_data): Update.
2237         (free_breakpoint_objfile_data): Remove.
2238         (_initialize_breakpoint): Update.
2239
2240 2019-05-08  Tom Tromey  <tom@tromey.com>
2241
2242         * linux-tdep.c (struct linux_info): Add initializers.
2243         (linux_inferior_data): Move.  Change type.
2244         (invalidate_linux_cache_inf): Update.
2245         (linux_inferior_data_cleanup): Remove.
2246         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2247
2248 2019-05-08  Tom Tromey  <tom@tromey.com>
2249
2250         * auxv.c (auxv_inferior_data): Move.  Change type.
2251         (auxv_inferior_data_cleanup): Remove.
2252         (invalidate_auxv_cache_inf): Rewrite.
2253         (get_auxv_inferior_data, _initialize_auxv): Update.
2254
2255 2019-05-08  Tom Tromey  <tom@tromey.com>
2256
2257         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2258         (symfile_debug_objfile_data_key): Change type.
2259         (symfile_debug_installed, debug_qf_has_symbols)
2260         (debug_qf_find_last_source_symtab)
2261         (debug_qf_forget_cached_source_info)
2262         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2263         (debug_qf_print_stats, debug_qf_dump)
2264         (debug_qf_expand_symtabs_for_function)
2265         (debug_qf_expand_all_symtabs)
2266         (debug_qf_expand_symtabs_with_fullname)
2267         (debug_qf_map_matching_symbols)
2268         (debug_qf_expand_symtabs_matching)
2269         (debug_qf_find_pc_sect_compunit_symtab)
2270         (debug_qf_map_symbol_filenames)
2271         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2272         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2273         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2274         (debug_sym_read_linetable, debug_sym_relocate): Update.
2275         (symfile_debug_free_objfile): Remove.
2276         (install_symfile_debug_logging, _initialize_symfile_debug):
2277         Update.
2278
2279 2019-05-08  Tom Tromey  <tom@tromey.com>
2280
2281         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2282         allocate_on_obstack.
2283         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2284         (get_dwarf2_per_objfile): Update.
2285         (set_dwarf2_per_objfile): Remove.
2286         (dwarf2_has_info, dwarf2_get_section_info): Update.
2287         (dwarf2_free_objfile): Remove.
2288         (_initialize_dwarf2_read): Update.
2289
2290 2019-05-08  Tom Tromey  <tom@tromey.com>
2291
2292         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2293         initializers.
2294         <unsupported_script_warning_printed,
2295         script_not_found_warning_printed>: Now bool.
2296         (auto_load_pspace_data): Change type.
2297         (~auto_load_pspace_info): Rename from
2298         auto_load_pspace_data_cleanup.
2299         (get_auto_load_pspace_data, init_loaded_scripts_info)
2300         (clear_section_scripts, maybe_print_unsupported_script_warning)
2301         (maybe_print_script_not_found_warning, _initialize_auto_load):
2302         Update.
2303
2304 2019-05-08  Tom Tromey  <tom@tromey.com>
2305
2306         * objfiles.c (objfile_pspace_info): Add destructor and
2307         initializers.
2308         (objfiles_pspace_data): Change type.
2309         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2310         (get_objfile_pspace_data): Update.
2311         (objfiles_bfd_data): Change type.
2312         (get_objfile_bfd_data): Update.
2313         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2314
2315 2019-05-08  Tom Tromey  <tom@tromey.com>
2316
2317         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2318         Change type.
2319         (get_catch_syscall_inferior_data): Update.
2320         (catch_syscall_inferior_data_cleanup): Remove.
2321         (_initialize_break_catch_syscall): Update.
2322
2323 2019-05-08  Tom Tromey  <tom@tromey.com>
2324
2325         * inflow.c (struct terminal_info): Add destructor and
2326         initializers.
2327         (inflow_inferior_data): Change type.
2328         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2329         (get_inflow_inferior_data, inflow_inferior_exit)
2330         (swap_terminal_info, _initialize_inflow): Update.
2331
2332 2019-05-08  Tom Tromey  <tom@tromey.com>
2333
2334         * target-dcache.c (target_dcache_cleanup): Remove.
2335         (target_dcache_aspace_key): Change type.
2336         (target_dcache_init_p, target_dcache_invalidate)
2337         (target_dcache_get, target_dcache_get_or_init)
2338         (_initialize_target_dcache): Update.
2339         * dcache.h (struct dcache_deleter): New.
2340
2341 2019-05-08  Tom Tromey  <tom@tromey.com>
2342
2343         * symtab.c (struct symbol_cache): Add destructor and
2344         initializers.
2345         (symbol_cache_key): Move.  Change type.
2346         (make_symbol_cache, free_symbol_cache): Remove.
2347         (get_symbol_cache): Update.
2348         (symbol_cache_cleanup): Remove.
2349         (ALL_PSPACES, symbol_cache_flush)
2350         (maintenance_print_symbol_cache)
2351         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2352         Update.
2353
2354 2019-05-08  Tom Tromey  <tom@tromey.com>
2355
2356         * symtab.c (struct main_info): Add destructor and initializers.
2357         (main_progspace_key): Move.  Change type.
2358         (get_main_info): Update.
2359         (main_info_cleanup): Remove.
2360         (_initialize_symtab): Update.
2361
2362 2019-05-08  Tom Tromey  <tom@tromey.com>
2363
2364         * registry.h (DECLARE_REGISTRY): Define the _key class.
2365
2366 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2367
2368         * NEWS: Merge two 'New commands' sections.
2369
2370 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2371
2372         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2373         parameter and use Ada language definition instead.
2374         (ada_val_print_ptr): Remove unused language parameter.
2375         (ada_val_print_num): Remove language parameter and use Ada language
2376         definition instead.
2377         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2378         parameter.
2379         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2380         parameter and use Ada language definition instead.
2381         (ada_val_print_1): Update all ada_val_print_xxx calls.
2382         Remove language parameter.
2383         (ada_val_print): Update ada_val_print_1 call.
2384
2385 2019-05-08  Tom Tromey  <tromey@adacore.com>
2386
2387         * remote.c (remote_hw_watchpoint_limit)
2388         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2389         Now static.
2390
2391 2019-05-08  Tom Tromey  <tromey@adacore.com>
2392
2393         * maint.c (_initialize_maint_cmds): Move initialization code to
2394         remote.c.
2395         (watchdog, show_watchdog): Move to remote.c.
2396         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2397         "watchdog" static.
2398         (_initialize_remote): Move initialization code from maint.c.
2399         * defs.h (watchdog): Don't declare.
2400
2401 2019-05-08  Tom Tromey  <tromey@adacore.com>
2402
2403         * tui/tui-interp.c: Include main.h.
2404         * interps.c: Include main.h.
2405         * main.h (interpreter_p): Declare.
2406         * defs.h (interpreter_p): Don't declare.
2407
2408 2019-05-08  Tom Tromey  <tromey@adacore.com>
2409
2410         * dwarf2loc.c: Include dwarf2read.h.
2411         * defs.h (read_unsigned_leb128): Don't declare.
2412         * dwarf2read.h (read_unsigned_leb128): Declare.
2413
2414 2019-05-08  Tom Tromey  <tromey@adacore.com>
2415
2416         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2417         method.
2418
2419 2019-05-08  Tom Tromey  <tromey@adacore.com>
2420
2421         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2422         when no wrap column is set.
2423
2424 2019-05-08  Tom Tromey  <tromey@adacore.com>
2425
2426         * c-lang.c (c_get_string): Handle non-C-style arrays.
2427
2428 2019-05-08  Tom Tromey  <tromey@adacore.com>
2429
2430         * typeprint.c (print_offset_data::update): Print the bit offset,
2431         not the number of bits remaining.
2432
2433 2019-05-08  Tom Tromey  <tromey@adacore.com>
2434
2435         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2436         padding at end of comment.
2437
2438 2019-05-08  Tom Tromey  <tromey@adacore.com>
2439
2440         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2441         Compare main types.
2442
2443 2019-05-06  Tom Tromey  <tom@tromey.com>
2444
2445         * common/scoped_mmap.c: Include common-defs.h.
2446         * common/scoped_mmap.h: Don't include config.h.
2447
2448 2019-05-04  Tom Tromey  <tom@tromey.com>
2449
2450         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2451         (struct aarch64_call_info): Add initializers.
2452         <si>: Now a std::vector.
2453         (pass_on_stack, aarch64_push_dummy_call): Update.
2454
2455 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2456             Tom Tromey  <tom@tromey.com>
2457
2458         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2459         (ppc_threads): Now a std::vector.  Now static.
2460         (hwdebug_find_thread_points_by_tid)
2461         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2462         Update.
2463
2464 2019-05-04  Tom Tromey  <tom@tromey.com>
2465
2466         * arc-tdep.c (arc_tdesc_init): Return bool.
2467
2468 2019-05-04  Tom Tromey  <tom@tromey.com>
2469
2470         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2471         Use gdb_assert_not_reached.
2472
2473 2019-05-04  Tom Tromey  <tom@tromey.com>
2474
2475         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2476         "false".
2477
2478 2019-05-04  Tom Tromey  <tom@tromey.com>
2479
2480         * arc-tdep.c (arc_tdesc_init): Use bool.
2481
2482 2019-05-04  Tom Tromey  <tom@tromey.com>
2483
2484         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2485
2486 2019-05-04  Tom Tromey  <tom@tromey.com>
2487
2488         * cli/cli-cmds.c (valid_command_p): Return bool.
2489
2490 2019-05-04  Tom Tromey  <tom@tromey.com>
2491
2492         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2493         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2494
2495 2019-05-04  Raul Tambre  <raul@tambre.ee>
2496
2497         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2498         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2499         operator for comparison.
2500
2501 2019-05-04  Tom Tromey  <tom@tromey.com>
2502
2503         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2504         (lookup_partial_symbol, print_partial_symbols)
2505         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2506         (psymbol_compare): Update.
2507         (add_psymbol_to_bcache): Clear the entire psymbol.
2508         (maintenance_check_psymtabs): Update.
2509         * psympriv.h (struct partial_symbol): Don't derive from
2510         general_symbol_info.
2511         <obj_section, unrelocated_address, address,
2512         set_unrelocated_address>: Update.
2513         <ginfo>: New member.
2514         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2515         (debug_names::write_psymbols): Update.
2516
2517 2019-05-04  Tom de Vries  <tdevries@suse.de>
2518
2519         * contrib/cc-with-tweaks.sh: Support -n arg.
2520
2521 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2522
2523         * corelow.c (core_target::detach): Ensure frame cache and
2524         register caches are cleared.
2525         inferior.c (exit_inferior_1): Likewise.
2526
2527 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2528             Tom Tromey  <tom@tromey.com>
2529
2530         * dictionary.c (collate_pending_symbols_by_language): Remove
2531         "struct" from foreach.
2532         * symtab.c (lookup_global_symbol_from_objfile)
2533         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2534         foreach.
2535         * ser-tcp.c (net_open): Remove "struct" from foreach.
2536         * objfiles.c (objfile_relocate, objfile_rebase)
2537         (objfile_has_symbols): Remove "struct" from foreach.
2538         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2539         from foreach.
2540         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2541         foreach.
2542         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2543         "struct" from foreach.
2544         * ada-lang.c (create_excep_cond_exprs)
2545         (ada_exception_catchpoint_cond_string): Remove "struct" from
2546         foreach.
2547
2548 2019-05-03  Tom Tromey  <tromey@adacore.com>
2549
2550         * ada-exp.y (convert_char_literal): Check suffix of each
2551         enumerator.
2552
2553 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2554
2555         PR ada/21406:
2556         * ada-exp.y (yywrap): Don't define.
2557         * ada-lex.l (%option): Add noyywrap
2558         (yywrap): Remove.
2559
2560 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2561
2562         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2563         _WIN32_WINNT to the XP level, unless already defined to a higher
2564         level.
2565
2566         * unittests/parse-connection-spec-selftests.c:
2567         * ser-tcp.c:
2568         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2569         override.
2570
2571         * symfile.c (find_separate_debug_file): Remove colon from the
2572         drive spec of DOS/Windows file names of the target, so that the
2573         file name produced from DEBUGDIR and the target's directory will
2574         be valid on DOS/Windows systems.
2575
2576 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2577
2578         * rust-lang.c (val_print_struct): Handle printing structures
2579         containing strings.
2580
2581 2019-05-02  Tom Tromey  <tromey@adacore.com>
2582
2583         * valarith.c (_initialize_valarith): Remove.
2584
2585 2019-05-01  Tom Tromey  <tromey@adacore.com>
2586
2587         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2588         bitfields.
2589
2590 2019-05-01  Tom Tromey  <tromey@adacore.com>
2591
2592         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2593         for big-endian copies.
2594
2595 2019-04-30  Ali Tamur  <tamur@google.com>
2596         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2597         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2598         (read_3_bytes): New function.
2599
2600 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2601
2602         * windows-nat.c (main_thread_id): Delete.
2603         (handle_output_debug_string): Replace main_thread_id by
2604         current_event.dwThreadId.
2605         (fake_create_process): Likewise.
2606         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2607         Do not set main_thread_id.
2608         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2609         current_event.dwThreadId.
2610         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2611
2612 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2613
2614         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2615         Use current_event.dwThreadId instead of main_thread_id.
2616
2617 2019-04-30  Tom Tromey  <tromey@adacore.com>
2618
2619         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2620         (create_excep_cond_exprs): Iterate over program spaces.
2621         (ada_exception_catchpoint_cond_string): Examine all minimal
2622         symbols for exception types.
2623
2624 2019-04-30  Tom Tromey  <tromey@adacore.com>
2625
2626         PR c++/24470:
2627         * dwarf2read.c (process_structure_scope): Handle case where type
2628         has template parameters but no symbol was created.
2629
2630 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2631             Chris January  <chris.january@arm.com>
2632
2633         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2634         qualifier.
2635         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2636
2637 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2638
2639         * f-typeprint.c (f_print_type): Update rules for printing
2640         whitespace.
2641         (f_type_print_varspec_suffix): Likewise.
2642
2643 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2644             Chris January  <chris.january@arm.com>
2645
2646         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2647         function arguments.
2648
2649 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2650
2651         * f-lang.c (build_fortran_types): Change name of void type to
2652         lower case.
2653         * f-typeprint.c (f_type_print_base): Print the name of the void
2654         type, rather than a fixed string.
2655         * f-valprint.c (f_decorations): Use lower case void string.
2656
2657 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2658             Chris January  <chris.january@arm.com>
2659
2660         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2661         types for Fortran.
2662
2663 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2664             Chris January  <chris.january@arm.com>
2665             David Lecomber  <david.lecomber@arm.com>
2666
2667         * f-exp.y (BINOP_INTRINSIC): New token.
2668         (exp): New parser rule handling BINOP_INTRINSIC.
2669         (f77_keywords): Add new builtin procedures.
2670         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2671         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2672         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2673         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2674         (print_unop_subexp_f): New function.
2675         (print_binop_subexp_f): New function.
2676         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2677         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2678         (dump_subexp_body_f): Likewise.
2679         (operator_check_f): Likewise.
2680         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2681         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2682
2683 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2686         UNOP_KIND.
2687         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2688         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2689         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2690         (operator_length_f): New fuction.
2691         (print_subexp_f): New function.
2692         (op_name_f): New function.
2693         (dump_subexp_body_f): New function.
2694         (operator_check_f): New function.
2695         (exp_descriptor_f): Replace standard expression handling functions
2696         with new functions.
2697         * gdb/fortran-operator.def: New file.
2698         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2699         * gdb/std-operator.def: Remove UNOP_KIND.
2700
2701 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2702
2703         * std-operator.def: Remove unbalanced, stray double quote
2704         character.
2705
2706 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2707             Chris January  <chris.january@arm.com>
2708             Daniel Everett  <daniel.everett@arm.com>
2709             Nick Forrington  <nick.forrington@arm.com>
2710             Richard Bunt  <richard.bunt@arm.com>
2711
2712         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2713         of depth when printing anonymous structs or unions.
2714         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2715         Don't print either the top-level value, or the children if the
2716         max-depth is exceeded.
2717         (ppscm_print_children): When printing the key of a map, allow one
2718         extra level of depth.
2719         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2720         print either the top-level value, or the children if the max-depth
2721         is exceeded.
2722         (print_children): When printing the key of a map, allow one extra
2723         level of depth.
2724         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2725         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2726         (user_print_options): Initialise max_depth field.
2727         (val_print_scalar_or_string_type_p): New function.
2728         (val_print): Check to see if the max depth has been reached.
2729         (val_print_check_max_depth): Define new function.
2730         (show_print_max_depth): New function.
2731         (_initialize_valprint): Add 'print max-depth' option.
2732         * valprint.h (struct value_print_options) <max_depth>: New field.
2733         (val_print_check_max_depth): Declare new function.
2734         * NEWS: Document new feature.
2735
2736 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2737
2738         * ada-lang.c (ada_language_defn): Initialise new field.
2739         * c-lang.c (c_is_string_type_p): New function.
2740         (c_language_defn): Initialise new field.
2741         (cplus_language_defn): Initialise new field.
2742         (asm_language_defn): Initialise new field.
2743         (minimal_language_defn): Initialise new field.
2744         * c-lang.h (c_is_string_type_p): Declare new function.
2745         * d-lang.c (d_language_defn): Initialise new field.
2746         * f-lang.c (f_is_string_type_p): New function.
2747         (f_language_defn): Initialise new field.
2748         * go-lang.c (go_is_string_type_p): New function.
2749         (go_language_defn): Initialise new field.
2750         * language.c (default_is_string_type_p): New function.
2751         (unknown_language_defn): Initialise new field.
2752         (auto_language_defn): Initialise new field.
2753         * language.h (struct language_defn) <la_is_string_type_p>: New
2754         member variable.
2755         (default_is_string_type_p): Declare new function.
2756         * m2-lang.c (m2_language_defn): Initialise new field.
2757         * objc-lang.c (objc_language_defn): Initialise new field.
2758         * opencl-lang.c (opencl_language_defn): Initialise new field.
2759         * p-lang.c (pascal_is_string_type_p): New function.
2760         (pascal_language_defn): Initialise new field.
2761         * rust-lang.c (rust_is_string_type_p): New function.
2762         (rust_language_defn): Initialise new field.
2763
2764 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2765
2766         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2767         New field.
2768         * ada-lang.c (ada_language_defn): Initialise new field.
2769         * c-lang.c (c_language_defn): Likewise.
2770         (cplus_language_defn): Likewise.
2771         (asm_language_defn): Likewise.
2772         (minimal_language_defn): Likewise.
2773         * d-lang.c (d_language_defn): Likewise.
2774         * f-lang.c (f_language_defn): Likewise.
2775         * go-lang.c (go_language_defn): Likewise.
2776         * language.c (unknown_language_defn): Likewise.
2777         (auto_language_defn): Likewise.
2778         * m2-lang.c (m2_language_defn): Likewise.
2779         * objc-lang.c (objc_language_defn): Likewise.
2780         * opencl-lang.c (opencl_language_defn): Likewise.
2781         * p-lang.c (pascal_language_defn): Likewise.
2782         * rust-lang.c (rust_language_defn): Likewise.
2783
2784 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2785
2786         * ada-lang.c (ada_is_character_type): Change return type to bool.
2787         (ada_is_string_type): Likewise.
2788         * ada-lang.h (ada_is_character_type): Update declaration
2789         (ada_is_string_type): Likewise.
2790
2791 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2792
2793         Support style in 'frame|thread apply'
2794
2795         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2796         * record.c (record_start, record_stop): Update callers of
2797         execute_command_to_string with false.
2798         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2799         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2800         methods.
2801         (class string_file): New constructor with term_out parameter.
2802         Override methods term_out and can_emit_style_escape.  New member
2803         term_out.
2804         (class stdio_file): Override can_emit_style_escape.
2805         (class tee_file): Override term_out and can_emit_style_escape.
2806         * utils.h (can_emit_style_escape): Remove.
2807         * utils.c (can_emit_style_escape): Likewise.
2808         Update all callers of can_emit_style_escape (SOMESTREAM) to
2809         SOMESTREAM->can_emit_style_escape.
2810         * source-cache.c (source_cache::get_source_lines): Likewise.
2811         * stack.c (frame_apply_command_count): Call execute_command_to_string
2812         passing the term_out characteristic of the current gdb_stdout.
2813         * thread.c (thr_try_catch_cmd): Likewise.
2814         * top.c (execute_command_to_string): pass term_out parameter
2815         to construct the string_file for the command output.
2816         * ui-file.c (term_cli_styling): New function (most code moved
2817         from utils.c can_emit_style_escape).
2818         (string_file::string_file, string_file::can_emit_style_escape,
2819         stdio_file::can_emit_style_escape, tee_file::term_out,
2820         tee_file::can_emit_style_escape): New functions.
2821
2822 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2823
2824         * NEWS: Mention the new set|show may-call-functions.
2825         * infcall.c (may_call_functions_p): New variable.
2826         (show_may_call_functions_p): New function.
2827         (call_function_by_hand_dummy): Throws an error if not
2828         may-call-functions.
2829         (_initialize_infcall): Call add_setshow_boolean_cmd for
2830         may-call-functions.
2831
2832 2019-04-25  Keith Seitz  <keiths@redhat.com>
2833
2834         PR c++/24367
2835         * cp-support.c (inspect_type): Don't attempt substitutions
2836         of symbol with the same name.
2837
2838 2019-04-25  Tom Tromey  <tromey@adacore.com>
2839
2840         PR gdb/24475:
2841         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2842         static.
2843
2844 2019-04-25  Tom Tromey  <tromey@adacore.com>
2845
2846         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2847         rvalue reference.
2848         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2849         (gdb_xml_parser::parse): Use std::move.
2850         * python/python-internal.h (gdbpy_convert_exception): Take a const
2851         reference.
2852         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2853         std::move.
2854         * python/py-utils.c (gdbpy_convert_exception): Take a const
2855         reference.
2856         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2857         Use std::move.
2858         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2859         Use std::move.
2860         * mi/mi-main.c (mi_print_exception): Take a const reference.
2861         * main.c (handle_command_errors): Take a const reference.
2862         * linespec.c (parse_linespec): Use std::move.
2863         * infcall.c (run_inferior_call): Use std::move.
2864         (call_function_by_hand_dummy): Use std::move.
2865         * exec.c (try_open_exec_file): Use std::move.
2866         * exceptions.h (exception_print, exception_fprintf)
2867         (exception_print_same): Update.
2868         * exceptions.c (print_exception, exception_print)
2869         (exception_fprintf, exception_print_same): Change parameters to
2870         const reference.
2871         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2872         * common/new-op.c: Use std::move.
2873         * common/common-exceptions.h (struct gdb_exception): Add move
2874         constructor.
2875         (struct gdb_exception_error, struct gdb_exception_quit, struct
2876         gdb_quit_bad_alloc): Change constructor to move constructor.
2877         (throw_exception): Change parameter to rvalue reference.
2878         * common/common-exceptions.c (throw_exception): Take rvalue
2879         reference.
2880         * cli/cli-interp.c (safe_execute_command): Use std::move.
2881         * breakpoint.c (insert_bp_location, location_to_sals): Use
2882         std::move.
2883
2884 2019-04-25  Tom Tromey  <tromey@adacore.com>
2885
2886         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2887         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2888         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2889         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2890         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2891         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2892         guile/scm-value.c: Use unpack.
2893         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2894         gdbscm_gdb_exception.
2895         (gdbscm_throw_gdb_exception): Likewise.
2896         (struct gdbscm_gdb_exception): New.
2897         (unpack): New function.
2898         (gdbscm_wrap): Use unpack.
2899
2900 2019-04-25  Tom Tromey  <tromey@adacore.com>
2901
2902         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2903         (gdb_rl_callback_handler): Use std::move.
2904         * common/common-exceptions.h (struct gdb_exception): Add move
2905         assignment operator.
2906         (throw_exception_sjlj): Change "exception" to const reference.
2907         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2908         (throw_exception_sjlj): Change "exception" to const reference.
2909
2910 2019-04-25  Tom Tromey  <tromey@adacore.com>
2911
2912         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2913         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2914         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2915         Update.
2916         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2917         Update.
2918         * mi/mi-interp.c (mi_interp::exec): Update.
2919         * linespec.c (parse_linespec): Update.
2920         * infcall.c (run_inferior_call): Update.
2921         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2922         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2923         (gdbscm_lookup_global_symbol): Update.
2924         * guile/scm-param.c (gdbscm_parameter_value): Update.
2925         * guile/scm-frame.c (gdbscm_frame_read_register)
2926         (gdbscm_frame_read_var): Update.
2927         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2928         * exec.c (try_open_exec_file): Update.
2929         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2930         (gdb_rl_callback_handler): Update.
2931         * common/common-exceptions.h (exception_none): Don't declare.
2932         * common/common-exceptions.c (exception_none): Don't define.
2933         (struct catcher) <exception>: Update.
2934         * cli/cli-interp.c (safe_execute_command): Update.
2935         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2936
2937 2019-04-25  Ali Tamur  <tamur@google.com>
2938
2939         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2940         (read_attribute_value): Likewise.
2941         (dwarf2_read_addr_index): Update comment.
2942         (read_str_index): Add DW_FORM_strx.
2943         (dwarf2_string_attr): Likewise.
2944         (dwarf2_const_value_attr): Likewise.
2945         (dump_die_shallow): Likewise.
2946         (dwarf2_fetch_constant_bytes): Likewise.
2947         (skip_form_bytes): Likewise.
2948         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2949
2950 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2951
2952         PR corefiles/11608
2953         PR corefiles/18187
2954         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2955         OFFSET.  Verify if current mapping contains an ELF header.
2956         (linux_find_memory_regions_full): Adjust call to
2957         dump_mapping_p.
2958
2959 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2960             Kang Li <kanglictf@gmail.com>
2961
2962         PR gdb/21600
2963
2964         * dwarf2-frame.c (read_initial_length): Be consistent about using
2965         unsigned representation of length.
2966         (decode_frame_entry_1): Likewise.  Check for wraparound of
2967         end pointer as well as buffer overflow.
2968
2969 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2970
2971         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2972         "vq".
2973
2974 2019-04-24  Tom Tromey  <tromey@adacore.com>
2975
2976         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2977
2978 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2979
2980         * s12z-tdep.c (s12z_unwind_pc): Delete.
2981         (s12z_unwind_sp): Delete.
2982         (s12z_gdbarch_init): Don't register deleted functions with
2983         gdbarch.
2984
2985 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2986
2987         * rl78-tdep.c (rl78_unwind_sp): Delete.
2988         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2989
2990 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2991
2992         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2993         (xstormy16_unwind_pc): Delete.
2994         (xstormy16_dummy_id): Delete.
2995         (xstormy16_gdbarch_init): Don't register deleted functions with
2996         gdbarch.
2997
2998 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2999
3000         * vax-tdep.c (vax_unwind_pc): Delete.
3001         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3002
3003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3004
3005         * v850-tdep.c (v850_unwind_sp): Delete.
3006         (v850_unwind_pc): Delete.
3007         (v850_dummy_id): Delete.
3008         (v850_gdbarch_init): Don't register deleted functions with
3009         gdbarch.
3010
3011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3012
3013         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3014         (tilegx_unwind_pc): Delete.
3015         (tilegx_unwind_dummy_id): Delete.
3016         (tilegx_gdbarch_init): Don't register deleted functions with
3017         gdbarch.
3018
3019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3020
3021         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3022         (tic6x_dummy_id): Delete.
3023         (tic6x_gdbarch_init): Don't register deleted functions with
3024         gdbarch.
3025
3026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3027
3028         * sparc-tdep.c (sparc_unwind_pc): Delete.
3029         (sparc32_gdbarch_init): Don't register deleted function with
3030         gdbarch.
3031
3032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3033
3034         * sh-tdep.c (sh_unwind_sp): Delete.
3035         (sh_unwind_pc): Delete.
3036         (sh_dummy_id): Delete.
3037         (sh_gdbarch_init): Don't register deleted functions with
3038         gdbarch.
3039
3040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3041
3042         * score-tdep.c (score_unwind_sp): Delete.
3043         (score_unwind_pc): Delete.
3044         (score_dummy_id): Delete.
3045         (score_gdbarch_init): Don't register deleted functions with
3046         gdbarch.
3047
3048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3049
3050         * rx-tdep.c (rx_unwind_pc): Delete.
3051         (rx_unwind_sp): Delete.
3052         (rx_dummy_id): Delete.
3053         (rx_gdbarch_init): Don't register deleted functions with
3054         gdbarch.  Update comment.
3055
3056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3057
3058         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3059         (rs6000_dummy_id): Delete.
3060         (rs6000_gdbarch_init): Don't register deleted functions with
3061         gdbarch.
3062
3063 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3064
3065         * or1k-tdep.c (or1k_dummy_id): Delete.
3066         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3067
3068 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3069
3070         * nios2-tdep.c (nios2_dummy_id): Delete.
3071         (nios2_unwind_sp): Delete.
3072         (nios2_gdbarch_init): Don't register deleted functions with
3073         gdbarch.
3074
3075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3076
3077         * nds32-tdep.c (nds32_dummy_id): Delete.
3078         (nds32_unwind_pc): Delete.
3079         (nds32_unwind_sp): Delete.
3080         (nds32_gdbarch_init): Don't register deleted functions with
3081         gdbarch.
3082
3083 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3084
3085         * msp430-tdep.c (msp430_unwind_pc): Delete.
3086         (msp430_unwind_sp): Delete.
3087         (msp430_dummy_id): Delete.
3088         (msp430_gdbarch_init): Don't register deleted functions with
3089         gdbarch.
3090
3091 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3092
3093         * moxie-tdep.c (moxie_unwind_sp): Delete.
3094         (moxie_unwind_pc): Delete.
3095         (moxie_dummy_id): Delete.
3096         (moxie_gdbarch_init): Don't register deleted functions with
3097         gdbarch.
3098
3099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3100
3101         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3102         (mn10300_unwind_pc): Delete.
3103         (mn10300_unwind_sp): Delete.
3104         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3105         mn10300_unwind_sp.
3106         (mn10300_frame_unwind_init): Don't register deleted functions with
3107         gdbarch.
3108
3109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3110
3111         * mep-tdep.c (mep_unwind_pc): Delete.
3112         (mep_unwind_sp): Delete.
3113         (mep_dummy_id): Delete.
3114         (mep_gdbarch_init): Don't register deleted functions with
3115         gdbarch.
3116
3117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3118
3119         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3120         (m68hc11_unwind_sp): Delete.
3121         (m68hc11_gdbarch_init): Don't register deleted functions with
3122         gdbarch.
3123
3124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3125
3126         * m32r-tdep.c (m32r_unwind_sp): Delete.
3127         (m32r_unwind_pc): Delete.
3128         (m32r_dummy_id): Delete.
3129         (m32r_gdbarch_init): Don't register deleted functions with
3130         gdbarch.
3131
3132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3133
3134         * m32c-tdep.c (m32c_unwind_pc): Delete.
3135         (m32c_unwind_sp): Delete.
3136         (m32c_dummy_id): Delete.
3137         (m32c_gdbarch_init): Don't register deleted functions with
3138         gdbarch.
3139
3140 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3141
3142         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3143         (lm32_unwind_pc): Delete.
3144         (lm32_dummy_id): Delete.
3145         (lm32_gdbarch_init): Don't register deleted functions with
3146         gdbarch.
3147
3148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3149
3150         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3151         (iq2000_unwind_pc): Delete.
3152         (iq2000_dummy_id): Delete.
3153         (iq2000_gdbarch_init): Don't register deleted functions with
3154         gdbarch.
3155
3156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3157
3158         * nds32-tdep.c (nds32_type_align): Delete.
3159         (nds32_push_dummy_call): Use type_align instead.
3160
3161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3162
3163         * arm-tdep.c (arm_type_align): Only handle vector override case.
3164         (arm_push_dummy_call): Use type_align.
3165         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3166
3167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3168
3169         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3170         case.
3171         (pass_on_stack): Use type_align.
3172         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3173         function.
3174
3175 2019-04-23  Tom Tromey  <tromey@adacore.com>
3176
3177         * dwarf2read.c (line_header::file_name_at): Remove unused
3178         overload.
3179
3180 2019-04-23  Tom de Vries  <tdevries@suse.de>
3181
3182         PR gdb/24438
3183         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3184         invocation.
3185
3186
3187 2019-03-27  Ali Tamur  <tamur@google.com>
3188
3189         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3190         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3191         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3192         (dwarf_expr_context::get_addr_index): Likewise
3193         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3194         (symbol_needs_eval_context::get_addr_index): Likewise
3195         (disassemble_dwarf_expression): Add DW_OP_addrx
3196         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3197         (read_cutu_die_from_dwo): Update comment
3198         (skip_one_die): Add DW_FORM_addrx
3199         (read_attribute_value): Likewise
3200         (var_decode_location): Add DW_OP_addrx
3201         (dwarf2_const_value_attr): Add DW_FORM_addrx
3202         (dump_die_shallow): Likewise
3203         (dwarf2_fetch_constant_bytes): Likewise
3204         (decode_locdesc): Add DW_OP_addrx
3205         (skip_form_bytes): Add DW_FORM_addrx
3206
3207 2019-04-22  Ali Tamur  <tamur@google.com>
3208
3209         * MAINTAINERS (Write After Approval): Add self.
3210
3211 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3212
3213         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3214         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3215         (open_symbol_file_object): Likewise.
3216         (svr4_default_sos): Add info parameter.
3217         (svr4_read_so_list): Likewise.
3218         (svr4_current_sos_direct): Adjust functions calls to pass down
3219         info.
3220         (svr4_current_sos_1): Add info parameter.
3221         (svr4_current_sos): Call get_svr4_info, pass info down to
3222         svr4_current_sos_1.
3223         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3224         get_svr4_info.
3225         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3226         get_svr4_info.
3227         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3228         to get_svr4_info.
3229         (probes_table_remove_objfile_probes): Likewise.
3230         (register_solib_event_probe): Add info parameter.
3231         (solist_update_incremental): Pass info parameter down to
3232         svr4_read_so_list.
3233         (disable_probes_interface): Add info parameter.
3234         (svr4_handle_solib_event): Pass current_program_space to
3235         get_svr4_info.  Adjust disable_probes_interface cleanup.
3236         (svr4_create_probe_breakpoints): Add info parameter, pass it
3237         down to register_solib_event_probe.
3238         (svr4_create_solib_event_breakpoints): Add info parameter,
3239         pass it down to svr4_create_probe_breakpoints.
3240         (enable_break): Pass info down to
3241         svr4_create_solib_event_breakpoints.
3242         (svr4_solib_create_inferior_hook): Pass current_program_space to
3243         get_svr4_info.
3244         (svr4_clear_solib): Likewise.
3245
3246 2019-04-22  Pedro Alves  <palves@redhat.com>
3247
3248         * solib-svr4.c (svr4_free_objfile_observer): New.
3249         (probe_and_action::objfile): New field.
3250         (probes_table_htab_remove_objfile_probes)
3251         (probes_table_remove_objfile_probes): New functions.
3252         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3253         in the new probe_and_action.  Don't store the probe in 'lookup'.
3254         (svr4_create_probe_breakpoints): Pass objfile to
3255         register_solib_event_probe.
3256         (_initialize_svr4_solib): Register a free_objfile observer.
3257
3258 2019-04-19  Tom Tromey  <tom@tromey.com>
3259
3260         * common/queue.h: Remove.
3261
3262 2019-04-19  Tom Tromey  <tom@tromey.com>
3263
3264         * event-loop.c: Don't include "common/queue.h".
3265
3266 2019-04-19  Tom Tromey  <tom@tromey.com>
3267
3268         * remote.c (remote_target): Use delete.
3269         * remote-notif.h: Include <list>, not "common/queue.h".
3270         (notif_client_p): Remove typedef.
3271         (remote_notif_state): Add constructor, destructor, initializer.
3272         <notif_queue>: Now a std::list.
3273         (remote_notif_state_xfree): Don't declare.
3274         * remote-notif.c (remote_notif_process, handle_notification)
3275         (remote_notif_state_allocate): Update.
3276         (~remote_notif_state): Rename from remote_notif_state_xfree.
3277
3278 2019-04-19  Tom Tromey  <tom@tromey.com>
3279
3280         * symfile.c (reread_symbols): Update.
3281         * objfiles.c (objfile_register_static_link)
3282         (objfile_lookup_static_link): Update
3283         (~objfile) Don't delete static_links.
3284         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3285
3286 2019-04-19  Tom Tromey  <tom@tromey.com>
3287
3288         * type-stack.h (struct type_stack) <insert>: Constify string.
3289         * type-stack.c (type_stack::insert): Constify string.
3290         * gdbtypes.h (lookup_template_type): Update.
3291         (address_space_name_to_int): Update.
3292         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3293         const.
3294         (lookup_template_type): Make name const.
3295         * c-exp.y: Update rules.
3296         (lex_one_token, classify_name, classify_inner_name)
3297         (c_print_token): Update.
3298         * p-exp.y: Update rules.
3299         (yylex): Update.
3300         * f-exp.y: Update rules.
3301         (yylex): Update.
3302         * d-exp.y: Update rules.
3303         (lex_one_token, classify_name, classify_inner_name): Update.
3304         * parse.c (write_dollar_variable, copy_name): Return std::string.
3305         * parser-defs.h (copy_name): Change return type.
3306         * m2-exp.y: Update rules.
3307         (yylex): Update.
3308         * go-exp.y (lex_one_token): Update.
3309         Update rules.
3310         (classify_unsafe_function, classify_packaged_name)
3311         (classify_name, yylex): Update.
3312
3313 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3314
3315         * configure.ac: add --enable-source-highlight switch.
3316         * configure: Regenerate.
3317         * top.c (print_gdb_version): plumb --enable-source-highlight
3318         status to "show configuration".
3319
3320 2019-04-19  Tom Tromey  <tromey@adacore.com>
3321
3322         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3323         Check ADA_TYPE_P.
3324         (empty_record, ada_template_to_fixed_record_type_1)
3325         (template_to_static_fixed_type)
3326         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3327         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3328         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3329         macros.
3330
3331 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3332
3333         PR symtab/24423:
3334         * source.c (print_source_lines_base): Advance "iter" when a
3335         control character is seen.
3336
3337 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3338
3339         * inferior.h (struct infcall_suspend_state_deleter):
3340         Catch exception in destructor to avoid crash.
3341
3342 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3343
3344         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3345         close to the add_com "shell".
3346
3347 2019-04-18  Tom Tromey  <tromey@adacore.com>
3348
3349         * process-stratum-target.h (class process_stratum_target)
3350         <stratum>: Add "final".
3351
3352 2019-04-17  Tom Tromey  <tromey@adacore.com>
3353
3354         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3355         against nullptr before use.
3356
3357 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3358
3359         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3360
3361 2019-04-17  Jim Wilson  <jimw@sifive.com>
3362             Andrew Burgess  <andrew.burgess@embecosm.com>
3363
3364         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3365         code read might fail, assume 4-byte breakpoint in that case.
3366
3367 2019-04-15  Leszek Swirski  <leszeks@google.com>
3368
3369         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3370         rather than a hand-rolled POD check when checking for forced MEMORY
3371         classification.
3372
3373 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3374
3375         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3376         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3377         function.
3378         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3379         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3380         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3381         declaration.
3382
3383 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3384
3385         * aarch64-linux-nat.c
3386         (aarch64_linux_nat_target::thread_architecture): Add override.
3387         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3388         each VQ.
3389
3390 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3391
3392         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3393
3394 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3395
3396         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3397         target types of size 96-bits, add some additional comments, and
3398         check that the builtin type we found was the correct size.
3399
3400 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3401
3402         * utils.c (prompt_for_continue): Don't restore the styling at the
3403         end, as applied_style has the wrong value.  This fixes styling in
3404         long lists of file names that are interrupted by the "Continue?"
3405         prompt.
3406
3407 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3408
3409         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3410         * c-lang.c (c_language_defn): Likewise.
3411         (cplus_language_defn): Likewise.
3412         (asm_language_defn): Likewise.
3413         (minimal_language_defn): Likewise.
3414         * d-lang.c (d_language_defn): Likewise.
3415         * f-lang.c (f_language_defn): Likewise.
3416         * go-lang.c (go_language_defn): Likewise.
3417         * language.c (unknown_language_defn): Likewise.
3418         (auto_language_defn): Likewise.
3419         * language.h (struct language_defn): Remove la_magic field.
3420         (LANG_MAGIC): Delete.
3421         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3422         * objc-lang.c (objc_language_defn): Likewise.
3423         * opencl-lang.c (opencl_language_defn): Likewise.
3424         * p-lang.c (pascal_language_defn): Likewise.
3425         * rust-lang.c (rust_language_defn): Likewise.
3426
3427 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3428
3429         * riscv-tdep.c (riscv_type_align): New function.
3430         (riscv_type_alignment): Delete.
3431         (riscv_arg_location): Use 'type_align'.
3432         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3433
3434 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3435
3436         * gdbtypes.c (type_align): A struct with no non-static fields also
3437         has alignment of 1.
3438
3439 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3440
3441         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3442         component to 0.
3443         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3444         member.
3445         (riscv_struct_info::analyse): New implementation using new
3446         analyse_inner member function.
3447         (riscv_struct_info::field_offset): New member function.
3448         (riscv_struct_info::m_offsets): New member variable.
3449         (riscv_struct_info::analyse_inner): New private member function,
3450         takes the old implementation of riscv_struct_info::analyse but
3451         extended to track field offsets.
3452         (riscv_call_arg_struct): Update the struct folding special cases
3453         to handle cases where empty C++ structs, which are non-zero
3454         length, are found.
3455         (riscv_arg_location): Initialise the length of each location, a
3456         non-zero length now indicates the location is in use.
3457         (riscv_push_dummy_call): Allow for the first location having a
3458         non-zero offset when setting up arguments.
3459         (riscv_return_value): Likewise, but for return values.
3460
3461 2019-04-11  Tom Tromey  <tromey@adacore.com>
3462
3463         * utils.c (internal_vproblem): Make "msg" const.
3464
3465 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3466
3467         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3468         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3469         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3470         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3471
3472 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3473
3474         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3475         function.
3476         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3477         of amd64_collect_native_gregset.
3478         (amd64_linux_nat_target::store_registers): Likewise.
3479
3480 2019-04-10  Tom Tromey  <tom@tromey.com>
3481
3482         * symtab.c (lookup_global_symbol_from_objfile)
3483         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3484         * objfiles.h (class separate_debug_iterator): New.
3485         (class separate_debug_range): New.
3486         (struct objfile) <separate_debug_objfiles>: New method.
3487         (objfile_separate_debug_iterate): Don't declare.
3488         * objfiles.c (separate_debug_iterator::operator++): Rename from
3489         objfile_separate_debug_iterate.
3490         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3491         iterator.
3492         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3493         iterator.
3494
3495 2019-04-10  Tom Tromey  <tom@tromey.com>
3496
3497         * symfile.c (reread_symbols): Remove old comment.
3498         * objfiles.c (free_all_objfiles): Fix a typo.
3499
3500 2019-04-10  Tom Tromey  <tom@tromey.com>
3501
3502         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3503         * minsyms.c (lookup_minimal_symbol): Use foreach.
3504         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3505         (lookup_minimal_symbol_solib_trampoline): Likewise.
3506         * symfile.c (reread_symbols): Use foreach.
3507
3508 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3509             Tom Tromey  <tromey@adacore.com>
3510
3511         PR rust/24414:
3512         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3513         (rust_lex_int_test): Change "value" to be LONGEST.
3514         (rust_lex_tests): Add test for long integer literal.
3515
3516 2019-04-09  Tom Tromey  <tromey@adacore.com>
3517
3518         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3519         to bool.
3520         (extended_remote_target::attach): Update.
3521         (remote_target::remote_notice_new_inferior): Update.
3522         (remote_target::add_current_inferior_and_thread): Update.
3523         * inferior.c (exit_inferior_1): Use "false".
3524         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3525
3526 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3527
3528         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3529         the "start" command.
3530
3531 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3532
3533         * python/py-inferior.c (infpy_thread_from_thread_handle):
3534         Adjust comments to reflect renaming of thread_from_thread_handle
3535         to thread_from_handle.  Adjust keywords.  Fix type error message.
3536         (inferior_object_methods): Add thread_from_handle.  Retain
3537         thread_from_thread_handle, but mark it as deprecated.
3538
3539 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3540
3541         * gdbthread.h (find_thread_by_handle): Revise declaration.
3542         * thread.c (find_thread_by_handle): Likewise.  Adjust
3543         implementation too.
3544         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3545         support for buffer objects as handles.
3546
3547 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3548
3549         * python/py-infthread.c (thpy_thread_handle): New function.
3550         (thread_object_methods): Register thpy_thread_handle.
3551
3552 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3553
3554         * gdbthread.h (thread_to_thread_handle): Declare.
3555         * thread.c (gdbtypes.h): Include.
3556         (thread_to_thread_handle): New function.
3557
3558         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3559         (target_thread_info_to_thread_handle): Declare.
3560         * target.c (target_thread_info_to_thread_handle): New function.
3561         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3562         * target-delegates.c: Regenerate.
3563
3564         * linux-thread-db.c (class thread_db_target): Add method
3565         thread_info_to_thread_handle.
3566         (thread_db_target::thread_info_to_thread_handle): Define.
3567         * remote.c (class remote_target): Add new method
3568         thread_info_to_thread_handle.
3569         (remote_target::thread_info_to_thread_handle): Define.
3570
3571 2019-04-08  Pedro Alves  <palves@redhat.com>
3572
3573         * common/common-exceptions.c (throw_exception): Don't create
3574         named object to throw; throw directly.
3575         (throw_it): Likewise.  Don't initialize gdb_exception::message
3576         here, with new; pass FMT and AP to the ctor instead.
3577         * common/common-exceptions.h: Include <string>.
3578         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3579         const char *, va_list)): New ctor.  Use std::make_shared.
3580         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3581         errors)): Delete.
3582         (gdb_exception_error::gdb_exception_error(enum errors, const char
3583         *, va_list)): New.
3584         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3585         Add assertion.
3586         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3587         errors)): Delete.
3588         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3589         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3590         Add assertion.
3591
3592 2019-04-08  Tom Tromey  <tom@tromey.com>
3593
3594         * valops.c (value_rtti_indirect_type): Replace throw_exception
3595         with throw.
3596         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3597         with throw.
3598         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3599         throw.
3600         * target.c (target_translate_tls_address): Replace throw_exception
3601         with throw.
3602         * stack.c (frame_apply_command_count): Replace throw_exception
3603         with throw.
3604         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3605         throw.
3606         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3607         with throw.
3608         * rs6000-tdep.c (rs6000_frame_cache)
3609         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3610         * remote.c: Replace throw_exception with throw.
3611         * record-full.c (record_full_message, record_full_wait_1)
3612         (record_full_restore): Replace throw_exception with throw.
3613         * record-btrace.c:
3614         (get_thread_current_frame_id, record_btrace_start_replaying)
3615         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3616         (cmd_record_btrace_start): Replace throw_exception with throw.
3617         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3618         throw.
3619         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3620         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3621         * linespec.c:
3622         (find_linespec_symbols): Replace throw_exception with throw.
3623         * infrun.c (displaced_step_prepare, resume): Replace
3624         throw_exception with throw.
3625         * infcmd.c (post_create_inferior): Replace throw_exception with
3626         throw.
3627         * inf-loop.c (inferior_event_handler): Replace throw_exception
3628         with throw.
3629         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3630         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3631         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3632         (get_prev_frame_always, get_frame_pc_if_available)
3633         (get_frame_address_in_block_if_available, get_frame_language):
3634         Replace throw_exception with throw.
3635         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3636         throw_exception with throw.
3637         * eval.c (fetch_subexp_value, evaluate_var_value)
3638         (evaluate_funcall, evaluate_subexp_standard): Replace
3639         throw_exception with throw.
3640         * dwarf2loc.c (call_site_find_chain)
3641         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3642         Replace throw_exception with throw.
3643         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3644         with throw.
3645         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3646         throw.
3647         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3648         * completer.c (complete_line_internal): Replace throw_exception
3649         with throw.
3650         * compile/compile-object-run.c (compile_object_run): Replace
3651         throw_exception with throw.
3652         * cli/cli-script.c (process_next_line): Replace throw_exception
3653         with throw.
3654         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3655         (btrace_enable, btrace_maint_update_pt_packets): Replace
3656         throw_exception with throw.
3657         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3658         throw_exception with throw.
3659         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3660         throw_exception with throw.
3661         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3662         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3663         * aarch64-tdep.c (aarch64_make_prologue_cache)
3664         (aarch64_make_stub_cache): Replace throw_exception with throw.
3665
3666 2019-04-08  Tom Tromey  <tom@tromey.com>
3667
3668         * common/common-exceptions.c (throw_exception): Rename from
3669         throw_exception_cxx.  Remove old copy.  Make argument const.
3670         (throw_it): Create and throw exception objects directly.
3671         * common/common-exceptions.h (throw_exception): Make argument
3672         const.
3673         (struct gdb_exception_error): Add constructor.
3674         (struct gdb_exception_quit): Add constructor.
3675
3676 2019-04-08  Tom Tromey  <tom@tromey.com>
3677
3678         * common/common-exceptions.h (exception_rethrow): Don't declare.
3679         (TRY_SJLJ): Update comment.
3680         (TRY, CATCH, END_CATCH): Remove.
3681         * common/common-exceptions.c (exception_rethrow): Remove.
3682
3683 2019-04-08  Tom Tromey  <tom@tromey.com>
3684
3685         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3686         Remove.
3687         (gdb_exception_error): Rename from
3688         gdb_exception_RETURN_MASK_ERROR.
3689         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3690         (gdb_quit_bad_alloc): Update.
3691         * aarch64-tdep.c: Update.
3692         * ada-lang.c: Update.
3693         * ada-typeprint.c: Update.
3694         * ada-valprint.c: Update.
3695         * amd64-tdep.c: Update.
3696         * arch-utils.c: Update.
3697         * break-catch-throw.c: Update.
3698         * breakpoint.c: Update.
3699         * btrace.c: Update.
3700         * c-varobj.c: Update.
3701         * cli/cli-cmds.c: Update.
3702         * cli/cli-interp.c: Update.
3703         * cli/cli-script.c: Update.
3704         * common/common-exceptions.c: Update.
3705         * common/new-op.c: Update.
3706         * common/selftest.c: Update.
3707         * compile/compile-c-symbols.c: Update.
3708         * compile/compile-cplus-symbols.c: Update.
3709         * compile/compile-object-load.c: Update.
3710         * compile/compile-object-run.c: Update.
3711         * completer.c: Update.
3712         * corelow.c: Update.
3713         * cp-abi.c: Update.
3714         * cp-support.c: Update.
3715         * cp-valprint.c: Update.
3716         * darwin-nat.c: Update.
3717         * disasm-selftests.c: Update.
3718         * dtrace-probe.c: Update.
3719         * dwarf-index-cache.c: Update.
3720         * dwarf-index-write.c: Update.
3721         * dwarf2-frame-tailcall.c: Update.
3722         * dwarf2-frame.c: Update.
3723         * dwarf2loc.c: Update.
3724         * dwarf2read.c: Update.
3725         * eval.c: Update.
3726         * event-loop.c: Update.
3727         * event-top.c: Update.
3728         * exec.c: Update.
3729         * f-valprint.c: Update.
3730         * fbsd-tdep.c: Update.
3731         * frame-unwind.c: Update.
3732         * frame.c: Update.
3733         * gdbtypes.c: Update.
3734         * gnu-v3-abi.c: Update.
3735         * guile/guile-internal.h: Update.
3736         * guile/scm-block.c: Update.
3737         * guile/scm-breakpoint.c: Update.
3738         * guile/scm-cmd.c: Update.
3739         * guile/scm-disasm.c: Update.
3740         * guile/scm-frame.c: Update.
3741         * guile/scm-lazy-string.c: Update.
3742         * guile/scm-math.c: Update.
3743         * guile/scm-param.c: Update.
3744         * guile/scm-ports.c: Update.
3745         * guile/scm-pretty-print.c: Update.
3746         * guile/scm-symbol.c: Update.
3747         * guile/scm-symtab.c: Update.
3748         * guile/scm-type.c: Update.
3749         * guile/scm-value.c: Update.
3750         * i386-linux-tdep.c: Update.
3751         * i386-tdep.c: Update.
3752         * inf-loop.c: Update.
3753         * infcall.c: Update.
3754         * infcmd.c: Update.
3755         * infrun.c: Update.
3756         * jit.c: Update.
3757         * language.c: Update.
3758         * linespec.c: Update.
3759         * linux-fork.c: Update.
3760         * linux-nat.c: Update.
3761         * linux-tdep.c: Update.
3762         * linux-thread-db.c: Update.
3763         * main.c: Update.
3764         * mi/mi-cmd-break.c: Update.
3765         * mi/mi-cmd-stack.c: Update.
3766         * mi/mi-interp.c: Update.
3767         * mi/mi-main.c: Update.
3768         * objc-lang.c: Update.
3769         * p-valprint.c: Update.
3770         * parse.c: Update.
3771         * ppc-linux-tdep.c: Update.
3772         * printcmd.c: Update.
3773         * python/py-arch.c: Update.
3774         * python/py-breakpoint.c: Update.
3775         * python/py-cmd.c: Update.
3776         * python/py-finishbreakpoint.c: Update.
3777         * python/py-frame.c: Update.
3778         * python/py-framefilter.c: Update.
3779         * python/py-gdb-readline.c: Update.
3780         * python/py-inferior.c: Update.
3781         * python/py-infthread.c: Update.
3782         * python/py-lazy-string.c: Update.
3783         * python/py-linetable.c: Update.
3784         * python/py-objfile.c: Update.
3785         * python/py-param.c: Update.
3786         * python/py-prettyprint.c: Update.
3787         * python/py-progspace.c: Update.
3788         * python/py-record-btrace.c: Update.
3789         * python/py-record.c: Update.
3790         * python/py-symbol.c: Update.
3791         * python/py-type.c: Update.
3792         * python/py-unwind.c: Update.
3793         * python/py-utils.c: Update.
3794         * python/py-value.c: Update.
3795         * python/python.c: Update.
3796         * record-btrace.c: Update.
3797         * record-full.c: Update.
3798         * remote-fileio.c: Update.
3799         * remote.c: Update.
3800         * riscv-tdep.c: Update.
3801         * rs6000-aix-tdep.c: Update.
3802         * rs6000-tdep.c: Update.
3803         * rust-exp.y: Update.
3804         * rust-lang.c: Update.
3805         * s390-tdep.c: Update.
3806         * selftest-arch.c: Update.
3807         * solib-dsbt.c: Update.
3808         * solib-frv.c: Update.
3809         * solib-spu.c: Update.
3810         * solib-svr4.c: Update.
3811         * solib.c: Update.
3812         * sparc64-linux-tdep.c: Update.
3813         * stack.c: Update.
3814         * symfile-mem.c: Update.
3815         * symmisc.c: Update.
3816         * target.c: Update.
3817         * thread.c: Update.
3818         * top.c: Update.
3819         * tracefile-tfile.c: Update.
3820         * tui/tui.c: Update.
3821         * typeprint.c: Update.
3822         * unittests/cli-utils-selftests.c: Update.
3823         * unittests/parse-connection-spec-selftests.c: Update.
3824         * valops.c: Update.
3825         * valprint.c: Update.
3826         * value.c: Update.
3827         * varobj.c: Update.
3828         * windows-nat.c: Update.
3829         * x86-linux-nat.c: Update.
3830         * xml-support.c: Update.
3831
3832 2019-04-08  Tom Tromey  <tom@tromey.com>
3833
3834         * xml-support.c: Use C++ exception handling.
3835         * x86-linux-nat.c: Use C++ exception handling.
3836         * windows-nat.c: Use C++ exception handling.
3837         * varobj.c: Use C++ exception handling.
3838         * value.c: Use C++ exception handling.
3839         * valprint.c: Use C++ exception handling.
3840         * valops.c: Use C++ exception handling.
3841         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3842         handling.
3843         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3844         * typeprint.c: Use C++ exception handling.
3845         * tui/tui.c: Use C++ exception handling.
3846         * tracefile-tfile.c: Use C++ exception handling.
3847         * top.c: Use C++ exception handling.
3848         * thread.c: Use C++ exception handling.
3849         * target.c: Use C++ exception handling.
3850         * symmisc.c: Use C++ exception handling.
3851         * symfile-mem.c: Use C++ exception handling.
3852         * stack.c: Use C++ exception handling.
3853         * sparc64-linux-tdep.c: Use C++ exception handling.
3854         * solib.c: Use C++ exception handling.
3855         * solib-svr4.c: Use C++ exception handling.
3856         * solib-spu.c: Use C++ exception handling.
3857         * solib-frv.c: Use C++ exception handling.
3858         * solib-dsbt.c: Use C++ exception handling.
3859         * selftest-arch.c: Use C++ exception handling.
3860         * s390-tdep.c: Use C++ exception handling.
3861         * rust-lang.c: Use C++ exception handling.
3862         * rust-exp.y: Use C++ exception handling.
3863         * rs6000-tdep.c: Use C++ exception handling.
3864         * rs6000-aix-tdep.c: Use C++ exception handling.
3865         * riscv-tdep.c: Use C++ exception handling.
3866         * remote.c: Use C++ exception handling.
3867         * remote-fileio.c: Use C++ exception handling.
3868         * record-full.c: Use C++ exception handling.
3869         * record-btrace.c: Use C++ exception handling.
3870         * python/python.c: Use C++ exception handling.
3871         * python/py-value.c: Use C++ exception handling.
3872         * python/py-utils.c: Use C++ exception handling.
3873         * python/py-unwind.c: Use C++ exception handling.
3874         * python/py-type.c: Use C++ exception handling.
3875         * python/py-symbol.c: Use C++ exception handling.
3876         * python/py-record.c: Use C++ exception handling.
3877         * python/py-record-btrace.c: Use C++ exception handling.
3878         * python/py-progspace.c: Use C++ exception handling.
3879         * python/py-prettyprint.c: Use C++ exception handling.
3880         * python/py-param.c: Use C++ exception handling.
3881         * python/py-objfile.c: Use C++ exception handling.
3882         * python/py-linetable.c: Use C++ exception handling.
3883         * python/py-lazy-string.c: Use C++ exception handling.
3884         * python/py-infthread.c: Use C++ exception handling.
3885         * python/py-inferior.c: Use C++ exception handling.
3886         * python/py-gdb-readline.c: Use C++ exception handling.
3887         * python/py-framefilter.c: Use C++ exception handling.
3888         * python/py-frame.c: Use C++ exception handling.
3889         * python/py-finishbreakpoint.c: Use C++ exception handling.
3890         * python/py-cmd.c: Use C++ exception handling.
3891         * python/py-breakpoint.c: Use C++ exception handling.
3892         * python/py-arch.c: Use C++ exception handling.
3893         * printcmd.c: Use C++ exception handling.
3894         * ppc-linux-tdep.c: Use C++ exception handling.
3895         * parse.c: Use C++ exception handling.
3896         * p-valprint.c: Use C++ exception handling.
3897         * objc-lang.c: Use C++ exception handling.
3898         * mi/mi-main.c: Use C++ exception handling.
3899         * mi/mi-interp.c: Use C++ exception handling.
3900         * mi/mi-cmd-stack.c: Use C++ exception handling.
3901         * mi/mi-cmd-break.c: Use C++ exception handling.
3902         * main.c: Use C++ exception handling.
3903         * linux-thread-db.c: Use C++ exception handling.
3904         * linux-tdep.c: Use C++ exception handling.
3905         * linux-nat.c: Use C++ exception handling.
3906         * linux-fork.c: Use C++ exception handling.
3907         * linespec.c: Use C++ exception handling.
3908         * language.c: Use C++ exception handling.
3909         * jit.c: Use C++ exception handling.
3910         * infrun.c: Use C++ exception handling.
3911         * infcmd.c: Use C++ exception handling.
3912         * infcall.c: Use C++ exception handling.
3913         * inf-loop.c: Use C++ exception handling.
3914         * i386-tdep.c: Use C++ exception handling.
3915         * i386-linux-tdep.c: Use C++ exception handling.
3916         * guile/scm-value.c: Use C++ exception handling.
3917         * guile/scm-type.c: Use C++ exception handling.
3918         * guile/scm-symtab.c: Use C++ exception handling.
3919         * guile/scm-symbol.c: Use C++ exception handling.
3920         * guile/scm-pretty-print.c: Use C++ exception handling.
3921         * guile/scm-ports.c: Use C++ exception handling.
3922         * guile/scm-param.c: Use C++ exception handling.
3923         * guile/scm-math.c: Use C++ exception handling.
3924         * guile/scm-lazy-string.c: Use C++ exception handling.
3925         * guile/scm-frame.c: Use C++ exception handling.
3926         * guile/scm-disasm.c: Use C++ exception handling.
3927         * guile/scm-cmd.c: Use C++ exception handling.
3928         * guile/scm-breakpoint.c: Use C++ exception handling.
3929         * guile/scm-block.c: Use C++ exception handling.
3930         * guile/guile-internal.h: Use C++ exception handling.
3931         * gnu-v3-abi.c: Use C++ exception handling.
3932         * gdbtypes.c: Use C++ exception handling.
3933         * frame.c: Use C++ exception handling.
3934         * frame-unwind.c: Use C++ exception handling.
3935         * fbsd-tdep.c: Use C++ exception handling.
3936         * f-valprint.c: Use C++ exception handling.
3937         * exec.c: Use C++ exception handling.
3938         * event-top.c: Use C++ exception handling.
3939         * event-loop.c: Use C++ exception handling.
3940         * eval.c: Use C++ exception handling.
3941         * dwarf2read.c: Use C++ exception handling.
3942         * dwarf2loc.c: Use C++ exception handling.
3943         * dwarf2-frame.c: Use C++ exception handling.
3944         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3945         * dwarf-index-write.c: Use C++ exception handling.
3946         * dwarf-index-cache.c: Use C++ exception handling.
3947         * dtrace-probe.c: Use C++ exception handling.
3948         * disasm-selftests.c: Use C++ exception handling.
3949         * darwin-nat.c: Use C++ exception handling.
3950         * cp-valprint.c: Use C++ exception handling.
3951         * cp-support.c: Use C++ exception handling.
3952         * cp-abi.c: Use C++ exception handling.
3953         * corelow.c: Use C++ exception handling.
3954         * completer.c: Use C++ exception handling.
3955         * compile/compile-object-run.c: Use C++ exception handling.
3956         * compile/compile-object-load.c: Use C++ exception handling.
3957         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3958         * compile/compile-c-symbols.c: Use C++ exception handling.
3959         * common/selftest.c: Use C++ exception handling.
3960         * common/new-op.c: Use C++ exception handling.
3961         * cli/cli-script.c: Use C++ exception handling.
3962         * cli/cli-interp.c: Use C++ exception handling.
3963         * cli/cli-cmds.c: Use C++ exception handling.
3964         * c-varobj.c: Use C++ exception handling.
3965         * btrace.c: Use C++ exception handling.
3966         * breakpoint.c: Use C++ exception handling.
3967         * break-catch-throw.c: Use C++ exception handling.
3968         * arch-utils.c: Use C++ exception handling.
3969         * amd64-tdep.c: Use C++ exception handling.
3970         * ada-valprint.c: Use C++ exception handling.
3971         * ada-typeprint.c: Use C++ exception handling.
3972         * ada-lang.c: Use C++ exception handling.
3973         * aarch64-tdep.c: Use C++ exception handling.
3974
3975 2019-04-08  Tom Tromey  <tom@tromey.com>
3976
3977         * xml-support.c (gdb_xml_parser::parse): Update.
3978         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3979         * value.c (show_convenience): Update.
3980         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3981         (test_parse_flags_qcs): Update.
3982         * thread.c (thr_try_catch_cmd): Update.
3983         * target.c (target_translate_tls_address): Update.
3984         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3985         (info_frame_command_core, frame_apply_command_count): Update.
3986         * rust-exp.y (rust_lex_exception_test): Update.
3987         * riscv-tdep.c (riscv_print_one_register_info): Update.
3988         * remote.c (remote_target::enable_btrace): Update.
3989         * record-btrace.c (record_btrace_enable_warn): Update.
3990         * python/py-utils.c (gdbpy_convert_exception): Update.
3991         * printcmd.c (do_one_display, print_variable_and_value): Update.
3992         * mi/mi-main.c (mi_print_exception): Update.
3993         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3994         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3995         * linux-nat.c (linux_nat_target::attach): Update.
3996         * linux-fork.c (class scoped_switch_fork_info): Update.
3997         * infrun.c (displaced_step_prepare): Update.
3998         * infcall.c (call_function_by_hand_dummy): Update.
3999         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4000         * gnu-v3-abi.c (print_one_vtable): Update.
4001         * frame.c (get_prev_frame_always): Update.
4002         * f-valprint.c (info_common_command_for_block): Update.
4003         * exec.c (try_open_exec_file): Update.
4004         * exceptions.c (print_exception, exception_print)
4005         (exception_fprintf, exception_print_same): Update.
4006         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4007         * dwarf-index-cache.c (index_cache::store)
4008         (index_cache::lookup_gdb_index): Update.
4009         * darwin-nat.c (maybe_cache_shell): Update.
4010         * cp-valprint.c (cp_print_value_fields): Update.
4011         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4012         (gcc_cplus_symbol_address): Update.
4013         * compile/compile-c-symbols.c (gcc_convert_symbol)
4014         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4015         * common/selftest.c: Update.
4016         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4017         a std::string.
4018         (exception_try_scope_entry, exception_try_scope_exit): Don't
4019         declare.
4020         (struct exception_try_scope): Remove.
4021         (TRY): Don't use exception_try_scope.
4022         (struct gdb_exception): Add constructor, operator=.
4023         <what>: New method.
4024         (struct gdb_exception_RETURN_MASK_ALL)
4025         (struct gdb_exception_RETURN_MASK_ERROR)
4026         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4027         (struct gdb_quit_bad_alloc): Update.
4028         * common/common-exceptions.c (exception_none): Change
4029         initializer.
4030         (struct catcher) <state, exception>: Initialize inline.
4031         <prev>: Remove member.
4032         (current_catcher): Remove.
4033         (catchers): New global.
4034         (exceptions_state_mc_init): Simplify.
4035         (catcher_pop): Remove.
4036         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4037         (try_scope_depth, exception_try_scope_entry)
4038         (exception_try_scope_exit): Remove.
4039         (throw_exception_sjlj): Update.
4040         (exception_messages, exception_messages_size): Remove.
4041         (throw_it): Simplify.
4042         (gdb_exception_sliced_copy): Remove.
4043         (throw_exception_cxx): Update.
4044         * cli/cli-script.c (script_from_file): Update.
4045         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4046         Update.
4047         * ada-valprint.c (ada_val_print): Update.
4048         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4049         (create_excep_cond_exprs): Update.
4050
4051 2019-04-08  Tom Tromey  <tom@tromey.com>
4052
4053         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4054         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4055         (TRY, CATCH, END_CATCH): Remove some definitions.
4056         * common/common-exceptions.c: Don't use GDB_XCPT.
4057         (catcher_list_size): Remove.
4058         (throw_exception, throw_it): Simplify.
4059
4060 2019-04-05  Tom Tromey  <tom@tromey.com>
4061
4062         Revert the header-sorting patch.
4063         * ft32-tdep.c: Revert.
4064         * frv-tdep.c: Revert.
4065         * frv-linux-tdep.c: Revert.
4066         * frame.c: Revert.
4067         * frame-unwind.c: Revert.
4068         * frame-base.c: Revert.
4069         * fork-child.c: Revert.
4070         * findvar.c: Revert.
4071         * findcmd.c: Revert.
4072         * filesystem.c: Revert.
4073         * filename-seen-cache.h: Revert.
4074         * filename-seen-cache.c: Revert.
4075         * fbsd-tdep.c: Revert.
4076         * fbsd-nat.h: Revert.
4077         * fbsd-nat.c: Revert.
4078         * f-valprint.c: Revert.
4079         * f-typeprint.c: Revert.
4080         * f-lang.c: Revert.
4081         * extension.h: Revert.
4082         * extension.c: Revert.
4083         * extension-priv.h: Revert.
4084         * expprint.c: Revert.
4085         * exec.h: Revert.
4086         * exec.c: Revert.
4087         * exceptions.c: Revert.
4088         * event-top.c: Revert.
4089         * event-loop.c: Revert.
4090         * eval.c: Revert.
4091         * elfread.c: Revert.
4092         * dwarf2read.h: Revert.
4093         * dwarf2read.c: Revert.
4094         * dwarf2loc.c: Revert.
4095         * dwarf2expr.h: Revert.
4096         * dwarf2expr.c: Revert.
4097         * dwarf2-frame.c: Revert.
4098         * dwarf2-frame-tailcall.c: Revert.
4099         * dwarf-index-write.h: Revert.
4100         * dwarf-index-write.c: Revert.
4101         * dwarf-index-common.c: Revert.
4102         * dwarf-index-cache.h: Revert.
4103         * dwarf-index-cache.c: Revert.
4104         * dummy-frame.c: Revert.
4105         * dtrace-probe.c: Revert.
4106         * disasm.h: Revert.
4107         * disasm.c: Revert.
4108         * disasm-selftests.c: Revert.
4109         * dictionary.c: Revert.
4110         * dicos-tdep.c: Revert.
4111         * demangle.c: Revert.
4112         * dcache.h: Revert.
4113         * dcache.c: Revert.
4114         * darwin-nat.h: Revert.
4115         * darwin-nat.c: Revert.
4116         * darwin-nat-info.c: Revert.
4117         * d-valprint.c: Revert.
4118         * d-namespace.c: Revert.
4119         * d-lang.c: Revert.
4120         * ctf.c: Revert.
4121         * csky-tdep.c: Revert.
4122         * csky-linux-tdep.c: Revert.
4123         * cris-tdep.c: Revert.
4124         * cris-linux-tdep.c: Revert.
4125         * cp-valprint.c: Revert.
4126         * cp-support.c: Revert.
4127         * cp-namespace.c: Revert.
4128         * cp-abi.c: Revert.
4129         * corelow.c: Revert.
4130         * corefile.c: Revert.
4131         * continuations.c: Revert.
4132         * completer.h: Revert.
4133         * completer.c: Revert.
4134         * complaints.c: Revert.
4135         * coffread.c: Revert.
4136         * coff-pe-read.c: Revert.
4137         * cli-out.h: Revert.
4138         * cli-out.c: Revert.
4139         * charset.c: Revert.
4140         * c-varobj.c: Revert.
4141         * c-valprint.c: Revert.
4142         * c-typeprint.c: Revert.
4143         * c-lang.c: Revert.
4144         * buildsym.c: Revert.
4145         * buildsym-legacy.c: Revert.
4146         * build-id.h: Revert.
4147         * build-id.c: Revert.
4148         * btrace.c: Revert.
4149         * bsd-uthread.c: Revert.
4150         * breakpoint.h: Revert.
4151         * breakpoint.c: Revert.
4152         * break-catch-throw.c: Revert.
4153         * break-catch-syscall.c: Revert.
4154         * break-catch-sig.c: Revert.
4155         * blockframe.c: Revert.
4156         * block.c: Revert.
4157         * bfin-tdep.c: Revert.
4158         * bfin-linux-tdep.c: Revert.
4159         * bfd-target.c: Revert.
4160         * bcache.c: Revert.
4161         * ax-general.c: Revert.
4162         * ax-gdb.h: Revert.
4163         * ax-gdb.c: Revert.
4164         * avr-tdep.c: Revert.
4165         * auxv.c: Revert.
4166         * auto-load.c: Revert.
4167         * arm-wince-tdep.c: Revert.
4168         * arm-tdep.c: Revert.
4169         * arm-symbian-tdep.c: Revert.
4170         * arm-pikeos-tdep.c: Revert.
4171         * arm-obsd-tdep.c: Revert.
4172         * arm-nbsd-tdep.c: Revert.
4173         * arm-nbsd-nat.c: Revert.
4174         * arm-linux-tdep.c: Revert.
4175         * arm-linux-nat.c: Revert.
4176         * arm-fbsd-tdep.c: Revert.
4177         * arm-fbsd-nat.c: Revert.
4178         * arm-bsd-tdep.c: Revert.
4179         * arch-utils.c: Revert.
4180         * arc-tdep.c: Revert.
4181         * arc-newlib-tdep.c: Revert.
4182         * annotate.h: Revert.
4183         * annotate.c: Revert.
4184         * amd64-windows-tdep.c: Revert.
4185         * amd64-windows-nat.c: Revert.
4186         * amd64-tdep.c: Revert.
4187         * amd64-sol2-tdep.c: Revert.
4188         * amd64-obsd-tdep.c: Revert.
4189         * amd64-obsd-nat.c: Revert.
4190         * amd64-nbsd-tdep.c: Revert.
4191         * amd64-nbsd-nat.c: Revert.
4192         * amd64-nat.c: Revert.
4193         * amd64-linux-tdep.c: Revert.
4194         * amd64-linux-nat.c: Revert.
4195         * amd64-fbsd-tdep.c: Revert.
4196         * amd64-fbsd-nat.c: Revert.
4197         * amd64-dicos-tdep.c: Revert.
4198         * amd64-darwin-tdep.c: Revert.
4199         * amd64-bsd-nat.c: Revert.
4200         * alpha-tdep.c: Revert.
4201         * alpha-obsd-tdep.c: Revert.
4202         * alpha-nbsd-tdep.c: Revert.
4203         * alpha-mdebug-tdep.c: Revert.
4204         * alpha-linux-tdep.c: Revert.
4205         * alpha-linux-nat.c: Revert.
4206         * alpha-bsd-tdep.c: Revert.
4207         * alpha-bsd-nat.c: Revert.
4208         * aix-thread.c: Revert.
4209         * agent.c: Revert.
4210         * addrmap.c: Revert.
4211         * ada-varobj.c: Revert.
4212         * ada-valprint.c: Revert.
4213         * ada-typeprint.c: Revert.
4214         * ada-tasks.c: Revert.
4215         * ada-lang.c: Revert.
4216         * aarch64-tdep.c: Revert.
4217         * aarch64-ravenscar-thread.c: Revert.
4218         * aarch64-newlib-tdep.c: Revert.
4219         * aarch64-linux-tdep.c: Revert.
4220         * aarch64-linux-nat.c: Revert.
4221         * aarch64-fbsd-tdep.c: Revert.
4222         * aarch64-fbsd-nat.c: Revert.
4223         * aarch32-linux-nat.c: Revert.
4224
4225 2019-04-05  Tom Tromey  <tom@tromey.com>
4226
4227         * ft32-tdep.c: Sort headers.
4228         * frv-tdep.c: Sort headers.
4229         * frv-linux-tdep.c: Sort headers.
4230         * frame.c: Sort headers.
4231         * frame-unwind.c: Sort headers.
4232         * frame-base.c: Sort headers.
4233         * fork-child.c: Sort headers.
4234         * findvar.c: Sort headers.
4235         * findcmd.c: Sort headers.
4236         * filesystem.c: Sort headers.
4237         * filename-seen-cache.h: Sort headers.
4238         * filename-seen-cache.c: Sort headers.
4239         * fbsd-tdep.c: Sort headers.
4240         * fbsd-nat.h: Sort headers.
4241         * fbsd-nat.c: Sort headers.
4242         * f-valprint.c: Sort headers.
4243         * f-typeprint.c: Sort headers.
4244         * f-lang.c: Sort headers.
4245         * extension.h: Sort headers.
4246         * extension.c: Sort headers.
4247         * extension-priv.h: Sort headers.
4248         * expprint.c: Sort headers.
4249         * exec.h: Sort headers.
4250         * exec.c: Sort headers.
4251         * exceptions.c: Sort headers.
4252         * event-top.c: Sort headers.
4253         * event-loop.c: Sort headers.
4254         * eval.c: Sort headers.
4255         * elfread.c: Sort headers.
4256         * dwarf2read.h: Sort headers.
4257         * dwarf2read.c: Sort headers.
4258         * dwarf2loc.c: Sort headers.
4259         * dwarf2expr.h: Sort headers.
4260         * dwarf2expr.c: Sort headers.
4261         * dwarf2-frame.c: Sort headers.
4262         * dwarf2-frame-tailcall.c: Sort headers.
4263         * dwarf-index-write.h: Sort headers.
4264         * dwarf-index-write.c: Sort headers.
4265         * dwarf-index-common.c: Sort headers.
4266         * dwarf-index-cache.h: Sort headers.
4267         * dwarf-index-cache.c: Sort headers.
4268         * dummy-frame.c: Sort headers.
4269         * dtrace-probe.c: Sort headers.
4270         * disasm.h: Sort headers.
4271         * disasm.c: Sort headers.
4272         * disasm-selftests.c: Sort headers.
4273         * dictionary.c: Sort headers.
4274         * dicos-tdep.c: Sort headers.
4275         * demangle.c: Sort headers.
4276         * dcache.h: Sort headers.
4277         * dcache.c: Sort headers.
4278         * darwin-nat.h: Sort headers.
4279         * darwin-nat.c: Sort headers.
4280         * darwin-nat-info.c: Sort headers.
4281         * d-valprint.c: Sort headers.
4282         * d-namespace.c: Sort headers.
4283         * d-lang.c: Sort headers.
4284         * ctf.c: Sort headers.
4285         * csky-tdep.c: Sort headers.
4286         * csky-linux-tdep.c: Sort headers.
4287         * cris-tdep.c: Sort headers.
4288         * cris-linux-tdep.c: Sort headers.
4289         * cp-valprint.c: Sort headers.
4290         * cp-support.c: Sort headers.
4291         * cp-namespace.c: Sort headers.
4292         * cp-abi.c: Sort headers.
4293         * corelow.c: Sort headers.
4294         * corefile.c: Sort headers.
4295         * continuations.c: Sort headers.
4296         * completer.h: Sort headers.
4297         * completer.c: Sort headers.
4298         * complaints.c: Sort headers.
4299         * coffread.c: Sort headers.
4300         * coff-pe-read.c: Sort headers.
4301         * cli-out.h: Sort headers.
4302         * cli-out.c: Sort headers.
4303         * charset.c: Sort headers.
4304         * c-varobj.c: Sort headers.
4305         * c-valprint.c: Sort headers.
4306         * c-typeprint.c: Sort headers.
4307         * c-lang.c: Sort headers.
4308         * buildsym.c: Sort headers.
4309         * buildsym-legacy.c: Sort headers.
4310         * build-id.h: Sort headers.
4311         * build-id.c: Sort headers.
4312         * btrace.c: Sort headers.
4313         * bsd-uthread.c: Sort headers.
4314         * breakpoint.h: Sort headers.
4315         * breakpoint.c: Sort headers.
4316         * break-catch-throw.c: Sort headers.
4317         * break-catch-syscall.c: Sort headers.
4318         * break-catch-sig.c: Sort headers.
4319         * blockframe.c: Sort headers.
4320         * block.c: Sort headers.
4321         * bfin-tdep.c: Sort headers.
4322         * bfin-linux-tdep.c: Sort headers.
4323         * bfd-target.c: Sort headers.
4324         * bcache.c: Sort headers.
4325         * ax-general.c: Sort headers.
4326         * ax-gdb.h: Sort headers.
4327         * ax-gdb.c: Sort headers.
4328         * avr-tdep.c: Sort headers.
4329         * auxv.c: Sort headers.
4330         * auto-load.c: Sort headers.
4331         * arm-wince-tdep.c: Sort headers.
4332         * arm-tdep.c: Sort headers.
4333         * arm-symbian-tdep.c: Sort headers.
4334         * arm-pikeos-tdep.c: Sort headers.
4335         * arm-obsd-tdep.c: Sort headers.
4336         * arm-nbsd-tdep.c: Sort headers.
4337         * arm-nbsd-nat.c: Sort headers.
4338         * arm-linux-tdep.c: Sort headers.
4339         * arm-linux-nat.c: Sort headers.
4340         * arm-fbsd-tdep.c: Sort headers.
4341         * arm-fbsd-nat.c: Sort headers.
4342         * arm-bsd-tdep.c: Sort headers.
4343         * arch-utils.c: Sort headers.
4344         * arc-tdep.c: Sort headers.
4345         * arc-newlib-tdep.c: Sort headers.
4346         * annotate.h: Sort headers.
4347         * annotate.c: Sort headers.
4348         * amd64-windows-tdep.c: Sort headers.
4349         * amd64-windows-nat.c: Sort headers.
4350         * amd64-tdep.c: Sort headers.
4351         * amd64-sol2-tdep.c: Sort headers.
4352         * amd64-obsd-tdep.c: Sort headers.
4353         * amd64-obsd-nat.c: Sort headers.
4354         * amd64-nbsd-tdep.c: Sort headers.
4355         * amd64-nbsd-nat.c: Sort headers.
4356         * amd64-nat.c: Sort headers.
4357         * amd64-linux-tdep.c: Sort headers.
4358         * amd64-linux-nat.c: Sort headers.
4359         * amd64-fbsd-tdep.c: Sort headers.
4360         * amd64-fbsd-nat.c: Sort headers.
4361         * amd64-dicos-tdep.c: Sort headers.
4362         * amd64-darwin-tdep.c: Sort headers.
4363         * amd64-bsd-nat.c: Sort headers.
4364         * alpha-tdep.c: Sort headers.
4365         * alpha-obsd-tdep.c: Sort headers.
4366         * alpha-nbsd-tdep.c: Sort headers.
4367         * alpha-mdebug-tdep.c: Sort headers.
4368         * alpha-linux-tdep.c: Sort headers.
4369         * alpha-linux-nat.c: Sort headers.
4370         * alpha-bsd-tdep.c: Sort headers.
4371         * alpha-bsd-nat.c: Sort headers.
4372         * aix-thread.c: Sort headers.
4373         * agent.c: Sort headers.
4374         * addrmap.c: Sort headers.
4375         * ada-varobj.c: Sort headers.
4376         * ada-valprint.c: Sort headers.
4377         * ada-typeprint.c: Sort headers.
4378         * ada-tasks.c: Sort headers.
4379         * ada-lang.c: Sort headers.
4380         * aarch64-tdep.c: Sort headers.
4381         * aarch64-ravenscar-thread.c: Sort headers.
4382         * aarch64-newlib-tdep.c: Sort headers.
4383         * aarch64-linux-tdep.c: Sort headers.
4384         * aarch64-linux-nat.c: Sort headers.
4385         * aarch64-fbsd-tdep.c: Sort headers.
4386         * aarch64-fbsd-nat.c: Sort headers.
4387         * aarch32-linux-nat.c: Sort headers.
4388
4389 2019-04-04  Tom Tromey  <tom@tromey.com>
4390
4391         * varobj.c (varobj_create): Update.
4392         * rust-exp.y (struct rust_parser) <update_innermost_block,
4393         lookup_symbol>: New methods.
4394         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4395         Rename.
4396         (rust_parser::rust_lookup_type)
4397         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4398         * printcmd.c (display_command, do_one_display): Update.
4399         * parser-defs.h (struct parser_state) <parser_state>: Add
4400         "tracker" parameter.
4401         (block_tracker): New member.
4402         (class innermost_block_tracker) <innermost_block_tracker>: Add
4403         "types" parameter.
4404         <reset>: Remove method.
4405         (innermost_block): Don't declare.
4406         (null_post_parser): Update.
4407         * parse.c (innermost_block): Remove global.
4408         (write_dollar_variable): Update.
4409         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4410         Remove "tracker_types" parameter.
4411         (parse_expression): Add "tracker" parameter.
4412         (parse_expression_for_completion): Update.
4413         (null_post_parser): Add "tracker" parameter.
4414         * p-exp.y: Update rules.
4415         * m2-exp.y: Update rules.
4416         * language.h (struct language_defn) <la_post_parser>: Add
4417         "tracker" parameter.
4418         * go-exp.y: Update rules.
4419         * f-exp.y: Update rules.
4420         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4421         parameter.
4422         * d-exp.y: Update rules.
4423         * c-exp.y: Update rules.
4424         * breakpoint.c (set_breakpoint_condition): Create an
4425         innermost_block_tracker.
4426         (watch_command_1): Likewise.
4427         * ada-lang.c (resolve): Add "tracker" parameter.
4428         (resolve_subexp): Likewise.
4429         * ada-exp.y (write_var_from_sym): Update.
4430
4431 2019-04-04  Tom Tromey  <tom@tromey.com>
4432
4433         * type-stack.h: New file.
4434         * type-stack.c: New file.
4435         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4436         type-stack.h.
4437         (insert_into_type_stack, insert_type, push_type, push_type_int)
4438         (insert_type_address_space, pop_type, pop_type_int)
4439         (pop_typelist, pop_type_stack, append_type_stack)
4440         (push_type_stack, get_type_stack, push_typelist)
4441         (follow_type_instance_flags, follow_types): Don't declare.
4442         * parse.c (type_stack): Remove global.
4443         (parse_exp_in_context): Update.
4444         (insert_into_type_stack, insert_type, push_type, push_type_int)
4445         (insert_type_address_space, pop_type, pop_type_int)
4446         (pop_typelist, pop_type_stack, append_type_stack)
4447         (push_type_stack, get_type_stack, push_typelist)
4448         (follow_type_instance_flags, follow_types): Remove (moved to
4449         type-stack.c).
4450         * f-exp.y (type_stack): New global.
4451         Update rules.
4452         (push_kind_type, f_parse): Update.
4453         * d-exp.y (type_stack): New global.
4454         Update rules.
4455         (d_parse): Update.
4456         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4457         Update rules.
4458         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4459         (HFILES_NO_SRCDIR): Add type-stack.h.
4460
4461 2019-04-04  Tom Tromey  <tom@tromey.com>
4462
4463         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4464         (rust_parser::convert_ast_to_expression, rust_parse)
4465         (rust_lex_test_completion, rust_lex_tests): Update.
4466         * parser-defs.h (struct expr_completion_state): New.
4467         (struct parser_state) <parser_state>: Add completion parameter.
4468         <mark_struct_expression, mark_completion_tag>: New methods.
4469         <parse_completion, m_completion_state>: New members.
4470         (prefixify_expression, null_post_parser): Update.
4471         (mark_struct_expression, mark_completion_tag): Don't declare.
4472         * parse.c (parse_completion, expout_last_struct)
4473         (expout_tag_completion_type, expout_completion_name): Remove
4474         globals.
4475         (parser_state::mark_struct_expression)
4476         (parser_state::mark_completion_tag): Now methods.
4477         (prefixify_expression): Add last_struct parameter.
4478         (prefixify_subexp): Likewise.
4479         (parse_exp_1): Update.
4480         (parse_exp_in_context): Add cstate parameter.  Update.
4481         (parse_expression_for_completion): Create an
4482         expr_completion_state.
4483         (null_post_parser): Add "completion" parameter.
4484         * p-exp.y: Update rules.
4485         (yylex): Update.
4486         * language.h (struct language_defn) <la_post_parser>: Add
4487         "completing" parameter.
4488         * go-exp.y: Update rules.
4489         (lex_one_token): Update.
4490         * expression.h (parse_completion): Don't declare.
4491         * d-exp.y: Update rules.
4492         (lex_one_token): Update rules.
4493         * c-exp.y: Update rules.
4494         (lex_one_token): Update.
4495         * ada-lang.c (resolve): Add "parse_completion" parameter.
4496         (resolve_subexp): Likewise.
4497         (ada_resolve_function): Likewise.
4498
4499 2019-04-04  Tom Tromey  <tom@tromey.com>
4500
4501         * parser-defs.h (struct parser_state) <start_arglist,
4502         end_arglist>: New methods.
4503         <arglist_len, m_funcall_chain>: New members.
4504         (arglist_len, start_arglist, end_arglist): Don't declare.
4505         * parse.c (arglist_len, funcall_chain): Remove global.
4506         (start_arglist, end_arglist): Remove functions.
4507         (parse_exp_in_context): Update.
4508         * p-exp.y: Update rules.
4509         * m2-exp.y: Update rules.
4510         * go-exp.y: Update rules.
4511         * f-exp.y: Update rules.
4512         * d-exp.y: Update rules.
4513         * c-exp.y: Update rules.
4514
4515 2019-04-04  Tom Tromey  <tom@tromey.com>
4516
4517         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4518         lex_operator, push_back>: New methods.
4519         Update all rules.
4520         (rust_parser::lex_hex, lex_escape): Rename and update.
4521         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4522         (rust_parser::lex_operator): Rename and update.
4523         (rust_parser::lex_number, rustyylex, rustyyerror)
4524         (rust_lex_test_init, rust_lex_test_sequence)
4525         (rust_lex_test_push_back, rust_lex_tests): Update.
4526         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4527         parameter.
4528         <lexptr, prev_lexptr>: New members.
4529         (lexptr, prev_lexptr): Don't declare.
4530         * parse.c (lexptr, prev_lexptr): Remove globals.
4531         (parse_exp_in_context): Update.
4532         * p-exp.y (yylex, yyerror): Update.
4533         * m2-exp.y (parse_number, yylex, yyerror): Update.
4534         * go-exp.y (lex_one_token, yyerror): Update.
4535         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4536         * d-exp.y (lex_one_token, yyerror): Update.
4537         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4538         (lex_one_token, yyerror): Update.
4539         * ada-lex.l (YY_INPUT): Update.
4540         (rewind_to_char): Update.
4541         * ada-exp.y (yyerror): Update.
4542
4543 2019-04-04  Tom Tromey  <tom@tromey.com>
4544
4545         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4546         * parser-defs.h (struct parser_state) <parser_state>: Add new
4547         parameter.
4548         <comma_terminates>: New member.
4549         (comma_terminates): Don't declare global.
4550         * parse.c (comma_terminates): Remove global.
4551         (parse_exp_in_context): Update.
4552         * p-exp.y (yylex): Update.
4553         * m2-exp.y (yylex): Update.
4554         * go-exp.y (lex_one_token): Update.
4555         * f-exp.y (yylex): Update.
4556         * d-exp.y (lex_one_token): Update.
4557         * c-exp.y (lex_one_token): Update.
4558         * ada-lex.l: Update.
4559
4560 2019-04-04  Tom Tromey  <tom@tromey.com>
4561
4562         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4563         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4564         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4565         * parser-defs.h (paren_depth): Don't declare.
4566         * parse.c (paren_depth): Remove global.
4567         (parse_exp_in_context): Update.
4568         * p-exp.y (paren_depth): New global.
4569         (pascal_parse): Initialize it.
4570         * m2-exp.y (paren_depth): New global.
4571         (m2_parse): Initialize it.
4572         * go-exp.y (paren_depth): New global.
4573         (go_parse): Initialize it.
4574         * f-exp.y (paren_depth): New global.
4575         (f_parse): Initialize it.
4576         * d-exp.y (paren_depth): New global.
4577         (d_parse): Initialize it.
4578         * c-exp.y (paren_depth): New global.
4579         (c_parse): Initialize it.
4580         * ada-lex.l (paren_depth): New global.
4581         (lexer_init): Initialize it.
4582
4583 2019-04-04  Tom Tromey  <tom@tromey.com>
4584
4585         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4586         (rust_parser::convert_ast_to_type)
4587         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4588         * parser-defs.h (struct parser_state) <parser_state>: Add
4589         parameters.  Initialize new members.
4590         <expression_context_block, expression_context_pc>: New members.
4591         * parse.c (expression_context_block, expression_context_pc):
4592         Remove globals.
4593         (parse_exp_in_context): Update.
4594         * p-exp.y: Update all rules.
4595         (yylex): Update.
4596         * m2-exp.y: Update all rules.
4597         (yylex): Update.
4598         * go-exp.y (yylex): Update.
4599         * f-exp.y (yylex): Update.
4600         * d-exp.y: Update all rules.
4601         (yylex): Update.
4602         * c-exp.y: Update all rules.
4603         (lex_one_token, classify_name, yylex, c_parse): Update.
4604         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4605
4606 2019-04-04  Tom Tromey  <tom@tromey.com>
4607
4608         * gdbarch.h, gdbarch.c: Rebuild.
4609         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4610         * stap-probe.h:
4611         (struct stap_parse_info): Replace "parser_state" with
4612         "expr_builder".
4613         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4614         (parser_state): New class.
4615         * parse.c (expr_builder): Rename.
4616         (expr_builder::release): Rename.
4617         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4618         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4619         (write_exp_elt_longcst, write_exp_elt_floatcst)
4620         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4621         (write_exp_string_vector, write_exp_bitstring)
4622         (write_exp_msymbol, mark_struct_expression)
4623         (write_dollar_variable)
4624         (insert_type_address_space, increase_expout_size): Replace
4625         "parser_state" with "expr_builder".
4626         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4627         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4628         "parser_state" with "expr_builder".
4629
4630 2019-04-04  Tom Tromey  <tom@tromey.com>
4631
4632         * rust-exp.y: Replace "parse_language" with method call.
4633         * p-exp.y:
4634         (yylex): Replace "parse_language" with method call.
4635         * m2-exp.y:
4636         (yylex): Replace "parse_language" with method call.
4637         * go-exp.y (classify_name): Replace "parse_language" with method
4638         call.
4639         * f-exp.y (yylex): Replace "parse_language" with method call.
4640         * d-exp.y (lex_one_token): Replace "parse_language" with method
4641         call.
4642         * c-exp.y:
4643         (lex_one_token, classify_name, yylex): Replace "parse_language"
4644         with method call.
4645         * ada-exp.y (find_primitive_type, type_char)
4646         (type_system_address): Replace "parse_language" with method call.
4647
4648 2019-04-04  Tom Tromey  <tom@tromey.com>
4649
4650         * rust-exp.y: Replace "parse_gdbarch" with method call.
4651         * parse.c (write_dollar_variable, insert_type_address_space):
4652         Replace "parse_gdbarch" with method call.
4653         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4654         call.
4655         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4656         call.
4657         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4658         "parse_gdbarch" with method call.
4659         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4660         with method call.
4661         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4662         "parse_gdbarch" with method call.
4663         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4664         "parse_gdbarch" with method call.
4665         * c-exp.y (parse_type, parse_number, classify_name): Replace
4666         "parse_gdbarch" with method call.
4667         * ada-lex.l: Replace "parse_gdbarch" with method call.
4668         * ada-exp.y (parse_type, find_primitive_type, type_char)
4669         (type_system_address): Replace "parse_gdbarch" with method call.
4670
4671 2019-04-04  Tom Tromey  <tom@tromey.com>
4672
4673         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4674         * stap-probe.c (stap_parse_argument): Update.
4675         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4676         initial_size parameter.
4677         * rust-exp.y (rust_lex_tests): Update.
4678         * parse.c (parser_state): Update.
4679         (parse_exp_in_context): Update.
4680         * parser-defs.h (struct parser_state) <parser_state>: Remove
4681         "initial_size" parameter.
4682
4683 2019-04-04  Tom Tromey  <tom@tromey.com>
4684
4685         * parser-defs.h (increase_expout_size): Don't declare.
4686         * parse.c (increase_expout_size): Now static.
4687
4688 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4689
4690         * gnu-nat.c (gnu_nat_target::wait): Fix
4691         target_waitstatus_to_string call.
4692
4693 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4694
4695         * eval.c (evaluate_subexp_standard): Handle internal functions
4696         during Fortran function call handling.
4697
4698 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4699
4700         * NEWS: Mention new internal functions.
4701         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4702         (read_base_type): Use dwarf2_init_complex_target_type.
4703         * value.c (creal_internal_fn): New function.
4704         (cimag_internal_fn): New function.
4705         (_initialize_values): Register new internal functions.
4706
4707 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4708
4709         * infrun.c (stop_all_threads): If debug_infrun, always
4710         trace the wait status after wait_one, using
4711         target_waitstatus_to_string and target_pid_to_str.
4712         (handle_inferior_event): Replace various trace of
4713         wait status kind by a single trace.
4714         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4715         wait status kind image by target_waitstatus_to_string.
4716         * target/waitstatus.c (target_waitstatus_to_string): Fix
4717         obsolete comment.
4718
4719 2019-04-01  Tom Tromey  <tromey@adacore.com>
4720
4721         PR symtab/23331:
4722         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4723
4724 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4725             Pedro Alves  <palves@redhat.com>
4726
4727         * top.c (quit_force): Call 'finalize_values'.
4728         * value.c (finalize_values): New function.
4729         * value.h (finalize_values): Declare.
4730
4731 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4732
4733         * NEWS: Announce $_gdb_major and $_gdb_minor.
4734
4735         * top.c (init_gdb_version_vars): New function.
4736         (gdb_init): Call init_gdb_version_vars.
4737
4738 2019-03-29  Tom Tromey  <tromey@adacore.com>
4739
4740         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4741         help text.  Remove dead code.
4742
4743 2019-03-29  Keith Seitz  <keiths@redhat.com>
4744
4745         From Siddhesh Poyarekar:
4746         * f-lang.h (f77_get_upperbound): Return LONGEST.
4747         (f77_get_lowerbound): Likewise.
4748         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4749         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4750         print them.
4751         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4752         plongest to format print it.
4753         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4754         (f77_get_upperbound): Likewise.
4755         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4756         LOWER_BOUND to LONGEST.
4757         (f77_create_arrayprint_offset_tbl): Likewise.
4758
4759 2019-03-29  Keith Seitz  <keiths@redhat.com>
4760
4761         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4762         %s/pulongest for TYPE_LENGTH instead of %d in format
4763         strings.
4764         * ada-typerint.c (ada_print_type): Likewise.
4765         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4766         * compile/compile-c-support.c (generate_register_struct): Likewise.
4767         * gdbtypes.c (recursive_dump_type): Likewise.
4768         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4769         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4770         instead of %d in format strings.
4771         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4772         to std::min to ULONGEST.
4773         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4774         instead of %d in format strings.
4775         * tracepoint.c (info_scope_command): Likewise.
4776         * typeprint.c (print_offset_data::update)
4777         (print_offset_data::finish): Likewise.
4778         * xtensa-tdep.c (xtensa_store_return_value)
4779         (xtensa_push_dummy_call): Likewise.
4780
4781 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4782
4783         * windows-nat.c (display_selector): Fixed format specifications
4784         for 64-bit Cygwin.
4785
4786 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4787
4788         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4789
4790 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4791
4792         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4793         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4794         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4795         (nios2_linux_init_abi): Install it.
4796
4797 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4798
4799         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4800
4801 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4802
4803         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4804
4805 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4806             Tom Tromey  <tromey@adacore.com>
4807
4808         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4809
4810 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4811
4812         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4813         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4814         method to compute the bounds of range types. Also print "[evaluated]"
4815         if the bounds' values come from a dynamic evaluation.
4816
4817 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4820         whitespace when pretty printing is on.
4821
4822 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4823
4824         * ppc-linux-nat.c: Add include.
4825
4826 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4827
4828         * NEWS: Mention AArch64 Pointer Authentication.
4829
4830 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4831
4832         * arm-linux-nat.c: Add include.
4833
4834 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4835
4836         * source-cache.c (source_cache::get_source_lines): Re-read
4837         fullname after calling open_source_file.
4838
4839 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4840
4841         * NEWS: Mention TLS support for FreeBSD.
4842
4843 2019-03-25  Tom Tromey  <tromey@adacore.com>
4844
4845         * minsyms.c (BUNCH_SIZE): Update comment.
4846         (~minimal_symbol_reader): Remove old comment.
4847         (compact_minimal_symbols): Update comment.
4848         (minimal_symbol_reader::install): Remove old comment.  Update
4849         other comments.
4850
4851 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4852
4853         * s390-linux-nat.c: Add include.
4854
4855 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4856
4857         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4858         Call linux_get_hwcap.
4859         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4860         Likewise.
4861         (aarch64_linux_get_hwcap): Remove function.
4862         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4863         declaration.
4864         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4865         linux_get_hwcap.
4866         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4867         * linux-tdep.c (linux_get_hwcap): Add function.
4868         (linux_get_hwcap2): Likewise.
4869         * linux-tdep.h (linux_get_hwcap): Add declaration.
4870         (linux_get_hwcap2): Likewise.
4871         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4872         (ppc_linux_get_hwcap2): Likewise.
4873         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4874         linux_get_hwcap.
4875         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4876         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4877         (ppc_linux_nat_target::read_description): Likewise.
4878         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4879         * s390-linux-nat.c: Likewise.
4880         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4881
4882 2019-03-24  Tom Tromey  <tom@tromey.com>
4883
4884         * ada-lang.c (standard_lookup): Simplify initialization.
4885         (ada_lookup_symbol_nonlocal): Simplify return.
4886         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4887         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4888         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4889         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4890         initialization.
4891         * solib.c (solib_global_lookup): Simplify.
4892         * symtab.c (null_block_symbol): Remove.
4893         (symbol_cache_lookup): Simplify returns.
4894         (lookup_language_this): Simplify returns.
4895         (lookup_symbol_aux): Simplify return.
4896         (lookup_local_symbol): Simplify returns.
4897         (lookup_global_symbol_from_objfile): Simplify return.
4898         (lookup_symbol_in_objfile_symtabs)
4899         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4900         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4901         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4902         * cp-namespace.c (cp_lookup_bare_symbol)
4903         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4904         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4905         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4906         (cp_lookup_symbol_via_imports): Simplify initialization.
4907         (find_symbol_in_baseclass): Likewise.
4908         * symtab.h (null_block_symbol): Remove.
4909         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4910         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4911         (d_lookup_symbol_module): Likewise.
4912         (find_symbol_in_baseclass): Simplify initialization.
4913
4914 2019-03-24  Tom Tromey  <tom@tromey.com>
4915
4916         * expression.h: Don't include symtab.h.
4917         (struct block): Forward declare.
4918
4919 2019-03-24  Tom Tromey  <tom@tromey.com>
4920
4921         * c-exp.y (typebase): Remove casts.
4922         * gdbtypes.c (lookup_unsigned_typename, )
4923         (lookup_signed_typename): Remove cast.
4924         * eval.c (parse_to_comma_and_eval): Remove cast.
4925         * parse.c (write_dollar_variable): Remove cast.
4926         * block.h (struct block) <superblock>: Now const.
4927         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4928         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4929         (map_block): Make "block" const.
4930         * symfile.h (struct quick_symbol_functions)
4931         <map_matching_symbols>: Constify block argument to "callback".
4932         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4933         const.
4934         (find_pc_sect_compunit_symtab): Make "b" const.
4935         (find_symbol_at_address): Likewise.
4936         (search_symbols): Likewise.
4937         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4938         (dw2_debug_names_lookup_symbol): Likewise.
4939         (dw2_map_matching_symbols): Update.
4940         * p-valprint.c (pascal_val_print): Remove "block".
4941         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4942         (aux_add_nonlocal_symbols): Make "block" const.
4943         (resolve_subexp): Remove cast.
4944         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4945         const.
4946         (iterate_over_file_blocks): Likewise.
4947         * f-exp.y (%union) <bval>: Remove.
4948         * coffread.c (patch_opaque_types): Make "b" const.
4949         * spu-tdep.c (spu_catch_start): Make "block" const.
4950         * c-valprint.c (print_unpacked_pointer): Remove "block".
4951         * symmisc.c (dump_symtab_1): Make "b" const.
4952         (block_depth): Make "block" const.
4953         * d-exp.y (%union) <bval>: Remove.
4954         * cp-support.h (cp_lookup_rtti_type): Update.
4955         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4956         * psymtab.c (psym_lookup_symbol): Make "block" const.
4957         (maintenance_check_psymtabs): Make "b" const.
4958         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4959         (enumerate_locals, enumerate_args): Update.
4960         * python/py-symtab.c (stpy_global_block): Make "block" const.
4961         (stpy_static_block): Likewise.
4962         * inline-frame.c (block_starting_point_at): Make "new_block"
4963         const.
4964         * block.c (find_block_in_blockvector): Make return type const.
4965         (blockvector_for_pc_sect): Make "b" const.
4966         (find_block_in_blockvector): Make "b" const.
4967
4968 2019-03-23  Tom Tromey  <tom@tromey.com>
4969
4970         * varobj.c (varobj_create): Update.
4971         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4972         * printcmd.c (display_command, do_one_display): Don't reset
4973         innermost_block.
4974         * parser-defs.h (enum innermost_block_tracker_type): Move to
4975         expression.h.
4976         (innermost_block): Update comment.
4977         * parse.c (parse_exp_1): Add tracker_types parameter.
4978         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4979         tracker_types parameter.  Reset innermost_block.
4980         (parse_exp_in_context): Remove.
4981         (parse_expression_for_completion): Update.
4982         * objfiles.c (~objfile): Don't reset expression_context_block or
4983         innermost_block.
4984         * expression.h (enum innermost_block_tracker_type): Move from
4985         parser-defs.h.
4986         (parse_exp_1): Add tracker_types parameter.
4987         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4988         reset innermost_block.
4989
4990 2019-03-23  Tom Tromey  <tom@tromey.com>
4991
4992         * objfiles.h: Include bcache.h.
4993
4994 2019-03-23  Tom Tromey  <tom@tromey.com>
4995
4996         * linespec.c (get_current_search_block): Use
4997         scoped_restore_current_language.
4998         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4999
5000 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5001             Jiong Wang  <jiong.wang@arm.com>
5002
5003         * aarch64-linux-tdep.c
5004         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5005         section.
5006         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5007
5008 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5009             Jiong Wang  <jiong.wang@arm.com>
5010
5011         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5012         instructions.
5013         (aarch64_analyze_prologue_test): Add PACIASP test.
5014         (aarch64_prologue_prev_register): Unmask PC value.
5015
5016 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5017             Jiong Wang  <jiong.wang@arm.com>
5018
5019         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5020         (aarch64_dwarf2_prev_register): Unmask PC value.
5021         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5022         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5023         DW_CFA_AARCH64_negate_ra_state.
5024         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5025
5026 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5027             Jiong Wang  <jiong.wang@arm.com>
5028
5029         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5030         registers.
5031         (aarch64_pseudo_register_name): Likewise.
5032         (aarch64_pseudo_register_type): Likewise.
5033         (aarch64_pseudo_register_reggroup_p): Likewise.
5034         (aarch64_gdbarch_init): Add pauth registers.
5035         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5036         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5037         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5038         (struct gdbarch_tdep): Add regnum for ra_state.
5039
5040 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5041             Jiong Wang  <jiong.wang@arm.com>
5042
5043         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5044
5045 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5046             Jiong Wang  <jiong.wang@arm.com>
5047
5048         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5049         function.
5050         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5051         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5052         (aarch64_gdbarch_init): Add puth registers.
5053         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5054         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5055         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5056
5057 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5058             Jiong Wang  <jiong.wang@arm.com>
5059
5060         * aarch64-linux-nat.c
5061         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5062         * aarch64-linux-tdep.c
5063         (aarch64_linux_core_read_description): Likewise.
5064         (aarch64_linux_get_hwcap): New function.
5065         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5066         (aarch64_linux_get_hwcap): New declaration.
5067
5068 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5069             Jiong Wang  <jiong.wang@arm.com>
5070
5071         * aarch64-linux-nat.c
5072         (aarch64_linux_nat_target::read_description): Add pauth param.
5073         * aarch64-linux-tdep.c
5074         (aarch64_linux_core_read_description): Likewise.
5075         * aarch64-tdep.c (struct target_desc): Add in pauth.
5076         (aarch64_read_description): Add pauth param.
5077         (aarch64_gdbarch_init): Likewise.
5078         * aarch64-tdep.h (aarch64_read_description): Likewise.
5079         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5080         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5081         * features/Makefile: Add new files.
5082         * features/aarch64-pauth.c: New file.
5083         * features/aarch64-pauth.xml: New file.
5084
5085 2019-03-20  Tom Tromey  <tromey@adacore.com>
5086
5087         * infrun.c (handle_inferior_event): Rename from
5088         handle_inferior_event_1.  Create a scoped_value_mark.
5089         (handle_inferior_event): Remove.
5090
5091 2019-03-19  Tom Tromey  <tromey@adacore.com>
5092
5093         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5094         * infrun.h (print_stop_event): Add "displays" parameter.
5095         * infrun.c (print_stop_event): Add "displays" parameter.
5096
5097 2019-03-19  Pedro Alves  <palves@redhat.com>
5098
5099         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5100         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5101         to -1.  Fix TABs vs spaces.
5102         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5103         * tui/tui-out.h (tui_ui_out) Add intro comments.
5104         <m_line, m_start_of_line>: In-class initialize, and add describing
5105         comment.
5106
5107 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5108
5109         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5110         variable names.
5111         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5112
5113 2019-03-18  Pedro Alves  <palves@redhat.com>
5114             Eli Zaretskii <eliz@gnu.org>
5115
5116         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5117         m_line and m_start_of_line.
5118
5119 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5120
5121         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5122         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5123         it returns a newline.  This fixes a regression in TU mode, whereby
5124         the next line is output on the same screen line as the user input.
5125
5126 2019-03-18  Tom Tromey  <tromey@adacore.com>
5127
5128         * minsyms.c (minimal_symbol_reader::install): Remove call to
5129         obstack_blank.
5130
5131 2019-03-18  Pedro Alves  <palves@redhat.com>
5132
5133         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5134         New globals.
5135         (apply_style): New, factored out from ...
5136         (apply_ansi_escape): ... this.  Handle reverse video mode.
5137         (tui_set_reverse_mode): New function.
5138         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5139         * tui/tui-winsource.c (tui_show_source_line): Use
5140         tui_set_reverse_mode instead of setting A_STANDOUT.
5141         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5142         New setter methods.
5143
5144 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5145
5146         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5147         Handle tabs.
5148
5149 2019-03-18  Tom Tromey  <tromey@adacore.com>
5150
5151         * ada-lang.c (empty_array): Add "high" parameter.
5152         (ada_evaluate_subexp): Update.
5153
5154 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5155
5156         * unittests/string_view-selftests.c: Define
5157         _initialize_string_view_selftests unconditionally.
5158
5159 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5160
5161         PR gdb/24350
5162         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5163
5164 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5165
5166         PR gdb/24351
5167         * windows-nat.c (display_selector): Fix format specifiers.
5168
5169 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5170
5171         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5172         tui_refill_source_window instead of tui_refresh_win, to update the
5173         current execution line.  This fixes redisplay of the current line
5174         when stepping through the code with "next" or "step".
5175
5176 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5177
5178         * source-cache.c (source_cache::get_source_lines): Call
5179         find_source_lines to initialize s->nlines.  This fixes vertical
5180         scrolling of TUI source window when the DOWN arrow is pressed.
5181
5182 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5183
5184         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5185         linux-thread-db.c (_initialize_thread_db): Likewise.
5186
5187 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5188
5189         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5190         wclrtoeol in tui_show_source_line".  This reverts changes made in
5191         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5192
5193 2019-03-15  Tom Tromey  <tom@tromey.com>
5194
5195         * symtab.h (struct minimal_symbol): Derive from
5196         general_symbol_info.
5197         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5198         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5199         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5200         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5201         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5202         (MSYMBOL_SEARCH_NAME): Update.
5203         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5204         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5205         * minsyms.c (minimal_symbol_reader::record_full): Update.
5206
5207 2019-03-15  Tom Tromey  <tom@tromey.com>
5208
5209         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5210
5211 2019-03-15  Tom Tromey  <tom@tromey.com>
5212
5213         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5214         unique_xmalloc_ptr.
5215         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5216         Update.
5217         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5218         (build_minimal_symbol_hash_tables)
5219         (minimal_symbol_reader::install): Update.
5220
5221 2019-03-15  Tom Tromey  <tom@tromey.com>
5222
5223         * symtab.c (create_demangled_names_hash): Update.
5224         (symbol_set_names): Update.
5225         * objfiles.h (struct objfile_per_bfd_storage)
5226         <demangled_names_hash>: Now an htab_up.
5227         * objfiles.c (objfile_per_bfd_storage): Simplify.
5228
5229 2019-03-15  Tom Tromey  <tom@tromey.com>
5230
5231         * objfiles.h (struct objfile_per_bfd_storage): Declare
5232         destructor.
5233         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5234         New.
5235         (get_objfile_bfd_data): Use new.  Don't initialize
5236         language_of_main.
5237         (free_objfile_per_bfd_storage): Remove.
5238         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5239
5240 2019-03-15  Tom Tromey  <tom@tromey.com>
5241
5242         * symfile.c (reread_symbols): Update.
5243         * objfiles.c (objfile::objfile): Update.
5244         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5245         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5246         comment.
5247         (minimal_symbol_reader::install): Update.
5248         (terminate_minimal_symbol_table): Remove.
5249         * jit.c (jit_object_close_impl): Update.
5250
5251 2019-03-15  Tom Tromey  <tom@tromey.com>
5252
5253         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5254         initializations.
5255
5256 2019-03-15  Tom Tromey  <tom@tromey.com>
5257
5258         * objfiles.h (struct objfile_per_bfd_storage)
5259         <demangled_hash_languages>: Now a bitset.
5260         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5261         (lookup_minimal_symbol): Update.
5262
5263 2019-03-15  Tom Tromey  <tom@tromey.com>
5264
5265         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5266         Don't return the symbol.
5267         * coffread.c (record_minimal_symbol): Use record_full.
5268
5269 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5270
5271         The MS-Windows port of ncurses fails to switch to a color pair if
5272         one or both of the colors are the implicit default colors.  This
5273         change records the default colors when TUI is initialized, and
5274         then specifies them explicitly when a color pair uses the default
5275         colors.  This allows color styling in TUI mode on MS-Windows.
5276
5277         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5278         ncurses_norm_attr.
5279         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5280         colors in ncurses_norm_attr.
5281         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5282         "none", replace it with the default color recorded in
5283         ncurses_norm_attr.
5284
5285 2019-03-14  Tom Tromey  <tromey@adacore.com>
5286
5287         * source-cache.h (class source_cache) <get_source_lines>: Return
5288         std::string.
5289         * source-cache.c (source_cache::extract_lines): Handle case where
5290         first_pos==npos.  Return std::string.
5291         (source_cache::get_source_lines): Update.
5292
5293 2019-03-14  Tom Tromey  <tromey@adacore.com>
5294
5295         * NEWS: Add item for "style sources" commands.
5296         * source-cache.c (source_cache::get_source_lines): Check
5297         source_styling.
5298         * cli/cli-style.c (source_styling): New global.
5299         (_initialize_cli_style): Add "style sources" commands.
5300         (show_style_sources): New function.
5301         * cli/cli-style.h (source_styling): Declare.
5302
5303 2019-03-14  Pedro Alves  <palves@redhat.com>
5304             Tom Tromey  <tromey@adacore.com>
5305
5306         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5307         * tui/tui-winsource.c (tui_refill_source_window): New function,
5308         from...
5309         (tui_horizontal_source_scroll): ... here.  Move some logic.
5310         * cli/cli-style.c (set_style_enabled): Notify new observable.
5311         * tui/tui-hooks.c (tui_redisplay_source): New function.
5312         (tui_attach_detach_observers): Attach or detach
5313         tui_redisplay_source.
5314         * observable.h (source_styling_changed): New observable.
5315         * observable.c: Define source_styling_changed observable.
5316
5317 2019-03-13  Tom Tromey  <tromey@adacore.com>
5318
5319         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5320         (i386_gnu_nat_target::store_registers): Update.
5321         * target-debug.h (target_debug_print_std_string): New macro.
5322         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5323         * windows-tdep.c (display_one_tib): Update.
5324         * tui/tui-stack.c (tui_make_status_line): Update.
5325         * top.c (print_inferior_quit_action): Update.
5326         * thread.c (thr_try_catch_cmd): Update.
5327         (add_thread_with_info): Update.
5328         (thread_target_id_str): Update.
5329         (thr_try_catch_cmd): Update.
5330         (thread_command): Update.
5331         (thread_find_command): Update.
5332         * record-btrace.c (record_btrace_target::info_record)
5333         (record_btrace_resume_thread, record_btrace_target::resume)
5334         (record_btrace_cancel_resume, record_btrace_step_thread)
5335         (record_btrace_target::wait, record_btrace_target::wait)
5336         (record_btrace_target::wait, record_btrace_target::stop): Update.
5337         * progspace.c (print_program_space): Update.
5338         * process-stratum-target.c
5339         (process_stratum_target::thread_address_space): Update.
5340         * linux-fork.c (linux_fork_mourn_inferior)
5341         (detach_checkpoint_command, info_checkpoints_command)
5342         (linux_fork_context): Update.
5343         (linux_fork_detach): Update.
5344         (class scoped_switch_fork_info): Update.
5345         (delete_checkpoint_command): Update.
5346         * infrun.c (follow_fork_inferior): Update.
5347         (follow_fork_inferior): Update.
5348         (proceed_after_vfork_done): Update.
5349         (handle_vfork_child_exec_or_exit): Update.
5350         (follow_exec): Update.
5351         (displaced_step_prepare_throw): Update.
5352         (displaced_step_restore): Update.
5353         (start_step_over): Update.
5354         (resume_1): Update.
5355         (clear_proceed_status_thread): Update.
5356         (proceed): Update.
5357         (print_target_wait_results): Update.
5358         (do_target_wait): Update.
5359         (context_switch): Update.
5360         (stop_all_threads): Update.
5361         (restart_threads): Update.
5362         (finish_step_over): Update.
5363         (handle_signal_stop): Update.
5364         (switch_back_to_stepped_thread): Update.
5365         (keep_going_pass_signal): Update.
5366         (print_exited_reason): Update.
5367         (normal_stop): Update.
5368         * inferior.c (inferior_pid_to_str): Change return type.
5369         (print_selected_inferior): Update.
5370         (add_inferior): Update.
5371         (detach_inferior): Update.
5372         * dummy-frame.c (fprint_dummy_frames): Update.
5373         * dcache.c (dcache_info_1): Update.
5374         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5375         (btrace_fetch, btrace_clear): Update.
5376         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5377         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5378         type.
5379         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5380         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5381         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5382         * gdbarch.c, gdbarch.h: Rebuild.
5383         * gdbarch.sh (core_pid_to_str): Change return type.
5384         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5385         return type.
5386         (windows_nat_target::pid_to_str): Change return type.
5387         (windows_delete_thread): Update.
5388         (windows_nat_target::attach): Update.
5389         (windows_nat_target::files_info): Update.
5390         * target-delegates.c: Rebuild.
5391         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5392         return type.
5393         (sol_thread_target::pid_to_str): Change return type.
5394         * remote.c (class remote_target) <pid_to_str>: Change return
5395         type.
5396         (remote_target::pid_to_str): Change return type.
5397         (extended_remote_target::attach, remote_target::remote_stop_ns)
5398         (remote_target::remote_notif_remove_queued_reply)
5399         (remote_target::push_stop_reply, remote_target::disable_btrace):
5400         Update.
5401         (extended_remote_target::attach): Update.
5402         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5403         type.
5404         (gdbsim_target::pid_to_str): Change return type.
5405         * ravenscar-thread.c (struct ravenscar_thread_target)
5406         <pid_to_str>: Change return type.
5407         (ravenscar_thread_target::pid_to_str): Change return type.
5408         * procfs.c (class procfs_target) <pid_to_str>: Change return
5409         type.
5410         (procfs_target::pid_to_str): Change return type.
5411         (procfs_target::attach): Update.
5412         (procfs_target::detach): Update.
5413         (procfs_target::fetch_registers): Update.
5414         (procfs_target::store_registers): Update.
5415         (procfs_target::wait): Update.
5416         (procfs_target::files_info): Update.
5417         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5418         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5419         return type.
5420         (nto_procfs_target::pid_to_str): Change return type.
5421         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5422         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5423         return type.
5424         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5425         (exit_lwp): Update.
5426         (attach_proc_task_lwp_callback, get_detach_signal)
5427         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5428         (linux_nat_target::resume, wait_lwp, stop_callback)
5429         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5430         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5431         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5432         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5433         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5434         type.
5435         (inf_ptrace_target::attach): Update.
5436         (inf_ptrace_target::files_info): Update.
5437         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5438         type.
5439         (go32_nat_target::pid_to_str): Change return type.
5440         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5441         (gnu_nat_target::wait): Update.
5442         (gnu_nat_target::wait): Update.
5443         (gnu_nat_target::resume): Update.
5444         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5445         (fbsd_nat_target::wait): Update.
5446         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5447         type.
5448         (darwin_nat_target::attach): Update.
5449         * corelow.c (class core_target) <pid_to_str>: Change return type.
5450         (core_target::pid_to_str): Change return type.
5451         * target.c (normal_pid_to_str): Change return type.
5452         (default_pid_to_str): Likewise.
5453         (target_pid_to_str): Change return type.
5454         (target_translate_tls_address): Update.
5455         (target_announce_detach): Update.
5456         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5457         return type.
5458         (bsd_uthread_target::pid_to_str): Change return type.
5459         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5460         type.
5461         (bsd_kvm_target::pid_to_str): Change return type.
5462         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5463         return type.
5464         (aix_thread_target::pid_to_str): Change return type.
5465         * target.h (struct target_ops) <pid_to_str>: Change return type.
5466         (target_pid_to_str, normal_pid_to_str): Likewise.
5467         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5468         type.
5469         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5470         type.
5471         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5472         return type.
5473         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5474         type.
5475         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5476         type.
5477         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5478         return type.
5479
5480 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5481
5482         * NEWS: Mention that the new default MI version is 3.  Mention
5483         changes to the output of commands and events that deal with
5484         multi-location breakpoints.
5485         * breakpoint.c: Include "mi/mi-out.h".
5486         (print_one_breakpoint): Change output syntax if using MI version
5487         >= 3.
5488         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5489         New.
5490         (mi_multi_location_breakpoint_output_fixed): New.
5491         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5492         (mi_cmd_fix_multi_location_breakpoint_output): New.
5493         (mi_multi_location_breakpoint_output_fixed): New.
5494         * mi/mi-cmds.c (mi_cmds): Register command
5495         -fix-multi-location-breakpoint-output.
5496         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5497         interpreter "mi".
5498
5499 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5500
5501         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5502         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5503         instantiate mi_ui_out based on interpreter name.
5504         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5505         * mi/mi-main.c (mi_load_progress): Likewise.
5506
5507 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5508
5509         * NEWS: Combine separate "New targets" sections for 8.3.
5510
5511 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5512
5513         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5514         (ppcfbsd_init_abi): Install gdbarch
5515         "fetch_tls_load_module_address" and "get_thread_local_address"
5516         methods.
5517
5518 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5519
5520         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5521         (riscv_fbsd_init_abi): Install gdbarch
5522         "fetch_tls_load_module_address" and "get_thread_local_address"
5523         methods.
5524
5525 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5526
5527         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5528         (i386fbsd_init_abi): Install gdbarch
5529         "fetch_tls_load_module_address" and "get_thread_local_address"
5530         methods.
5531
5532 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5533
5534         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5535         (amd64fbsd_init_abi): Install gdbarch
5536         "fetch_tls_load_module_address" and "get_thread_local_address"
5537         methods.
5538
5539 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5540
5541         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5542         (struct fbsd_pspace_data): New type.
5543         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5544         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5545         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5546         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5547         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5548
5549 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5550
5551         * gdbtypes.c (lookup_struct_elt): New function.
5552         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5553         * gdbtypes.h (struct struct_elt): New type.
5554         (lookup_struct_elt): New prototype.
5555
5556 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5557
5558         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5559         remove disabled code block.
5560
5561 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5562
5563         * gdbarch.sh (get_thread_local_address): New method.
5564         * gdbarch.h, gdbarch.c: Regenerate.
5565         * target.c (target_translate_tls_address): Use
5566         gdbarch_get_thread_local_address if present instead of
5567         target::get_thread_local_address.
5568
5569 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5570
5571         * target.h (target::get_thread_local_address): Update comment.
5572
5573 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5574
5575         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5576         objfile->separate_debug_objfile_backlink if not NULL.
5577
5578 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5579
5580         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5581         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5582         (amd64bsd_store_inferior_registers): Likewise.
5583         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5584         Enable segment base registers.
5585         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5586         PT_GETFSBASE and PT_GETGSBASE.
5587         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5588         PT_SETGSBASE.
5589         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5590         segment base registers.
5591         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5592
5593 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5594
5595         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5596         Update calls to i386_target_description to add 'segments'
5597         parameter.
5598         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5599         add segment base registers.
5600         * arch/i386.c (i386_create_target_description): Add 'segments'
5601         parameter to enable segment base registers.
5602         * arch/i386.h (i386_create_target_description): Likewise.
5603         * features/i386/32bit-segments.xml: New file.
5604         * features/i386/32bit-segments.c: Generate.
5605         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5606         call to i386_target_description to add 'segments' parameter.
5607         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5608         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5609         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5610         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5611         if feature is present.
5612         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5613         Add 'segments' parameter to call to i386_target_description.
5614         (i386_target_description): Add 'segments' parameter to enable
5615         segment base registers.
5616         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5617         to call to i386_target_description.
5618         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5619         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5620         Define I386_NUM_REGS.
5621         (i386_target_description): Add 'segments' parameter to enable
5622         segment base registers.
5623
5624 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5625
5626         PR/24325
5627         * source-cache.c: #undef open and close, to avoid unresolved
5628         externals during linking.
5629
5630 2019-03-12  Tom Tromey  <tromey@adacore.com>
5631
5632         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5633         const.  Add initializers.
5634         (_initialize_remote): Don't initialize ptid globals.
5635
5636 2019-03-12  Pedro Alves  <palves@redhat.com>
5637
5638         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5639
5640 2019-03-12  Pedro Alves  <palves@redhat.com>
5641
5642         * cp-name-parser.y (main): Remove unused 'len' variable.
5643
5644 2019-03-12  Tom Tromey  <tromey@adacore.com>
5645
5646         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5647         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5648
5649 2019-03-12  Tom Tromey  <tromey@adacore.com>
5650
5651         * linux-nat.c (iterate_over_lwps): Update.
5652         (stop_callback): Remove parameter.
5653         (stop_wait_callback, detach_callback, resume_set_callback)
5654         (select_singlestep_lwp_callback, set_ignore_sigint)
5655         (status_callback, resumed_callback, resume_clear_callback)
5656         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5657         data parameter.
5658         (linux_nat_target::detach, linux_nat_target::resume)
5659         (linux_stop_and_wait_all_lwps, select_event_lwp)
5660         (linux_nat_filter_event, linux_nat_wait_1)
5661         (linux_nat_target::kill, linux_nat_target::stop)
5662         (linux_nat_target::stop): Update.
5663         (linux_nat_resume_callback): Change type.
5664         (resume_stopped_resumed_lwps, count_events_callback)
5665         (select_event_lwp_callback): Likewise.
5666         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5667         * arm-linux-nat.c (struct update_registers_data): Remove.
5668         (update_registers_callback): Change type.
5669         (arm_linux_insert_hw_breakpoint1): Update.
5670         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5671         parameter.
5672         (x86_linux_dr_set_addr): Update.
5673         (x86_linux_dr_set_control): Update.
5674         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5675         (iterate_over_lwps): Use gdb::function_view.
5676         * nat/aarch64-linux-hw-point.c (struct
5677         aarch64_dr_update_callback_param): Remove.
5678         (debug_reg_change_callback): Change type.
5679         (aarch64_notify_debug_reg_change): Update.
5680         * s390-linux-nat.c (s390_refresh_per_info): Update.
5681
5682 2019-03-11  Tom Tromey  <tromey@adacore.com>
5683
5684         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5685         redundant assignment to "this_cu".
5686
5687 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5688
5689         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5690
5691 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5692
5693         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5694         from...
5695         (rank_one_type): ... this.
5696
5697 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5698
5699         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5700         from...
5701         (rank_one_type): ... this.
5702
5703 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5704
5705         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5706         from...
5707         (rank_one_type): ... this.
5708
5709 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5710
5711         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5712         from...
5713         (rank_one_type): ... this.
5714
5715 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5716
5717         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5718         from...
5719         (rank_one_type): ... this.
5720
5721 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5722
5723         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5724         from...
5725         (rank_one_type): ... this.
5726
5727 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5728
5729         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5730         from...
5731         (rank_one_type): ... this.
5732
5733 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5734
5735         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5736         from...
5737         (rank_one_type): ... this.
5738
5739 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5740
5741         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5742         from...
5743         (rank_one_type): ... this.
5744
5745 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5746
5747         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5748         from...
5749         (rank_one_type): ... this.
5750
5751 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5752
5753         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5754         from...
5755         (rank_one_type): ... this.
5756
5757 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5758
5759         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5760         from...
5761         (rank_one_type): ... this.
5762
5763 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5764
5765         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5766         inferior-events' shows the example events.
5767
5768 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5769
5770         Support styling on native MS-Windows console
5771
5772         PR/24315
5773         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5774         on MS-Windows if $TERM is not defined.
5775
5776         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5777
5778         * posix-hdep.c (gdb_console_fputs):
5779         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5780         functions.
5781         * ui-file.h (gdb_console_fputs): Add prototype.
5782
5783         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5784         back to fputs only if the former returns zero.
5785
5786 2019-03-07  Tom Tromey  <tom@tromey.com>
5787
5788         * symmisc.c (print_symbol_bcache_statistics): Update.
5789         (print_objfile_statistics): Update.
5790         * symfile.c (allocate_symtab): Update.
5791         * stabsread.c: Don't include bcache.h.
5792         * psymtab.h (struct psymbol_bcache): Don't declare.
5793         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5794         (psymbol_bcache_init, psymbol_bcache_free)
5795         (psymbol_bcache_get_bcache): Don't declare.
5796         * psymtab.c (struct psymbol_bcache): Remove.
5797         (psymtab_storage::psymtab_storage): Update.
5798         (psymtab_storage::~psymtab_storage): Update.
5799         (psymbol_bcache_init, psymbol_bcache_free)
5800         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5801         (add_psymbol_to_bcache): Update.
5802         (allocate_psymtab): Update.
5803         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5804         macro_cache>: No longer pointers.
5805         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5806         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5807         * macrotab.c (macro_bcache): Update.
5808         * macroexp.c: Don't include bcache.h.
5809         * gdbtypes.c (check_types_worklist): Update.
5810         (types_deeply_equal): Remove TRY/CATCH.  Update.
5811         * elfread.c (elf_symtab_read): Update.
5812         * dwarf2read.c: Don't include bcache.h.
5813         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5814         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5815         (print_bcache_statistics, bcache_memory_used): Don't declare.
5816         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5817         methods.  Rename all data members.
5818         * bcache.c (struct bcache): Move to bcache.h.
5819         (bcache::expand_hash_table): Rename from expand_hash_table.
5820         (bcache): Remove.
5821         (bcache::insert): Rename from bcache_full.
5822         (bcache::compare): Rename from bcache_compare.
5823         (bcache_xmalloc): Remove.
5824         (bcache::~bcache): Rename from bcache_xfree.
5825         (bcache::print_statistics): Rename from print_bcache_statistics.
5826         (bcache::memory_used): Rename from bcache_memory_used.
5827
5828 2019-03-07  Pedro Alves  <palves@redhat.com>
5829
5830         * infrun.c (normal_stop): Also check for
5831         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5832
5833 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5834
5835         * f-lang.c (value_from_host_double): Moved to...
5836         * value.c (value_from_host_double): ...here.
5837         * value.h (value_from_host_double): Declare.
5838         * guile/scm-math.c (vlscm_convert_typed_number): Use
5839         value_from_host_double.
5840         (vlscm_convert_number): Likewise.
5841         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5842         * python/py-value.c (convert_value_from_python): Likewise.
5843
5844 2019-03-06  Tom Tromey  <tom@tromey.com>
5845
5846         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5847
5848 2019-03-06  Tom Tromey  <tom@tromey.com>
5849
5850         * utils.h (free_current_contents): Don't declare.
5851         * utils.c (free_current_contents): Remove.
5852
5853 2019-03-06  Tom Tromey  <tom@tromey.com>
5854
5855         * top.c (quit_force): Update.
5856         * main.c (captured_command_loop): Update.
5857         * common/new-op.c (operator new): Update.
5858         * common/common-exceptions.c (struct catcher)
5859         <save_cleanup_chain>: Remove member.
5860         (exceptions_state_mc_init): Update.
5861         (exception_try_scope_entry): Return nullptr.
5862         (exception_try_scope_exit, exception_rethrow)
5863         (throw_exception_sjlj, throw_exception_cxx): Update.
5864         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5865         (all_cleanups, do_cleanups, discard_cleanups)
5866         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5867         (restore_cleanups, restore_final_cleanups): Don't declare.
5868         (do_final_cleanups): Remove parameter.
5869         * common/cleanups.c (cleanup_chain, make_cleanup)
5870         (make_cleanup_dtor, all_cleanups, do_cleanups)
5871         (discard_my_cleanups, discard_cleanups)
5872         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5873         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5874         (null_cleanup): Remove.
5875         (do_final_cleanups): Remove parameter.
5876
5877 2019-03-06  Tom Tromey  <tom@tromey.com>
5878
5879         * remote.c (remote_target::remote_parse_stop_reply): Use
5880         unique_xmalloc_ptr.
5881
5882 2019-03-06  Tom Tromey  <tom@tromey.com>
5883
5884         * stabsread.c (struct stabs_field_info): Rename from field_info.
5885         <list, fnlist>: Add initializers.
5886         <obstack>: New member.
5887         (read_member_functions, read_struct_fields, read_baseclasses):
5888         Allocate on obstack.  Don't use cleanups.
5889         (read_one_struct_field, read_member_functions, read_struct_fields)
5890         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5891         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5892         (read_struct_type): Update.
5893
5894 2019-03-06  Tom Tromey  <tom@tromey.com>
5895
5896         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5897         * common/filestuff.h (make_cleanup_close): Don't declare.
5898         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5899         Remove.
5900
5901 2019-03-06  Tom Tromey  <tom@tromey.com>
5902
5903         * solib-aix.c: Use make_scope_exit.
5904
5905 2019-03-06  Tom Tromey  <tom@tromey.com>
5906
5907         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5908         Use make_scope_exit.
5909
5910 2019-03-06  Tom Tromey  <tom@tromey.com>
5911
5912         * solib-svr4.c (disable_probes_interface): Remove parameter.
5913         (svr4_handle_solib_event): Use make_scope_exit.
5914
5915 2019-03-06  Tom Tromey  <tom@tromey.com>
5916
5917         * remote.c (struct stop_reply_deleter): Remove.
5918         (stop_reply_up): Update.
5919         (struct stop_reply): Derive from notif_event.  Don't typedef.
5920         <regcache>: Now a std::vector.
5921         (stop_reply_xfree): Remove.
5922         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5923         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5924         (remote_target::discard_pending_stop_replies): Use delete.
5925         (remote_target::remote_parse_stop_reply): Update.
5926         (remote_target::process_stop_reply): Update.
5927         * remote-notif.h (struct notif_event): Add virtual destructor.
5928         Remove "dtr" member.
5929         (struct notif_client) <alloc_event>: Return a unique_ptr.
5930         (notif_event_xfree): Don't declare.
5931         (notif_event_up): New typedef.
5932         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5933         (notif_event_xfree, do_notif_event_xfree): Remove.
5934         (remote_notif_state_xfree): Update.
5935
5936 2019-03-06  Tom Tromey  <tom@tromey.com>
5937
5938         * infrun.c (displaced_step_clear_cleanup): Now a
5939         forward_scope_exit type.
5940         (displaced_step_prepare_throw): Update.
5941         (displaced_step_fixup): Update.
5942
5943 2019-03-06  Tom Tromey  <tom@tromey.com>
5944
5945         * inferior.h (class inferior): Update comment.
5946         * gdbthread.h (class thread_info): Update comment.
5947
5948 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5949             Tom Tromey  <tom@tromey.com>
5950
5951         * stabsread.h (struct stab_section_list): Remove.
5952         (coffstab_build_psymtabs): Update.
5953         * dbxread.c (symbuf_sections): Now a std::vector.
5954         (sect_idx): New global.
5955         (fill_symbuf): Update.
5956         (coffstab_build_psymtabs): Change type of stabsects parameter.
5957         Update.
5958         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5959         std::vector.
5960         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5961         (coff_locate_sections): Update.
5962         (coff_symfile_read): Remove cleanups.  Update.
5963         (init_stringtab): Add storage parameter.
5964         (free_stringtab, free_stringtab_cleanup): Remove.
5965         (init_lineno): Add storage parameter.
5966         (free_linetab, free_linetab_cleanup): Remove.
5967
5968 2019-03-06  Pedro Alves  <palves@redhat.com>
5969
5970         * linux-fork.c (fork_info::clobber_regs): Delete.
5971         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5972         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5973         comment.  Adjust.
5974         (scoped_switch_fork_info::scoped_switch_fork_info)
5975         (checkpoint_command, linux_fork_context): Adjust
5976         fork_save_infrun_state calls.
5977
5978 2019-03-06  Pedro Alves  <palves@redhat.com>
5979
5980         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5981         (inf_has_multiple_threads): Return 'bool' and rewrite using
5982         inferior_info::threads().
5983
5984 2019-03-06  Pedro Alves  <palves@redhat.com>
5985
5986         * linux-fork.c: Include <list>.
5987         (fork_list): Now a std::list instance.
5988         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5989         (forks_exist_p, find_last_fork): Adjust.
5990         (new_fork): Delete.
5991         (one_fork_p): New.
5992         (add_fork): Adjust.
5993         (free_fork): Delete, folded into fork_info::~fork_info().
5994         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5995         Adjust.
5996         (init_fork_list): Delete.
5997         (linux_fork_killall, linux_fork_mourn_inferior)
5998         (linux_fork_detach, info_checkpoints_command): Adjust.
5999         (_initialize_linux_fork): No longer call init_fork_list.
6000
6001 2019-03-06  Pedro Alves  <palves@redhat.com>
6002
6003         * linux-fork.c (new_fork): New, split out of ...
6004         (add_fork): ... this.  Return void.  Move "first fork" special
6005         case from here, to ...
6006         (checkpoint_command): ... here.
6007         * linux-linux.h (add_fork): Return void.
6008
6009 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6010
6011         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6012
6013 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6014             Chris January  <chris.january@arm.com>
6015             David Lecomber  <david.lecomber@arm.com>
6016
6017         * f-exp.y: New token, UNOP_INTRINSIC.
6018         (exp): New pattern using UNOP_INTRINSIC token.
6019         (f77_keywords): Add 'abs' keyword.
6020         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6021         (value_from_host_double): New function.
6022         (evaluate_subexp_f): Support UNOP_ABS.
6023
6024 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6025
6026         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6027         types.
6028
6029 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6030
6031         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6032         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6033         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6034
6035 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6036
6037         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6038
6039 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6040             Chris January  <chris.january@arm.com>
6041
6042         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6043         * f-exp.y: Define 'KIND' token.
6044         (exp): New pattern for KIND expressions.
6045         (ptype): Handle types with a kind extension.
6046         (direct_abs_decl): Extend to spot kind extensions.
6047         (f77_keywords): Add 'kind' to the list.
6048         (push_kind_type): New function.
6049         (convert_to_kind_type): New function.
6050         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6051         * parse.c (operator_length_standard): Likewise.
6052         * parser-defs.h (enum type_pieces): Add tp_kind.
6053         * std-operator.def: Add UNOP_KIND.
6054
6055 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * f-exp.y (f_parse): Set yydebug.
6058
6059 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6060
6061         * f-lang.c (evaluate_subexp_f): New function.
6062         (exp_descriptor_f): New global.
6063         (f_language_defn): Use exp_descriptor_f instead of
6064         exp_descriptor_standard.
6065
6066 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6067
6068         * f-exp.y (struct token): Add comments.
6069         (dot_ops): Remove uppercase versions and the end marker.
6070         (f77_keywords): Likewise.
6071         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6072         entries in the dot_ops array are case insensitive, and use
6073         strncasecmp to compare strings.  Also some whitespace cleanup in
6074         this area.  Similar for the f77_keywords array, except entries in
6075         this list might be case sensitive.
6076
6077 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6078
6079         * f-exp.y (struct f77_boolean_val): Add comments.
6080         (boolean_values): Remove uppercase versions, and end marker.
6081         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6082         and use strncasecmp to achieve case insensitivity.  Additionally,
6083         perform whitespace cleanup around this code.
6084
6085 2019-03-06  Tom Tromey  <tromey@adacore.com>
6086
6087         * remote-sim.c (gdbsim_target_open): Use result of
6088         gdb_argv::release.
6089
6090 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6091         Dirk Schubert  <dirk.schubert@arm.com>
6092         Chris January  <chris.january@arm.com>
6093
6094         * eval.c (evaluate_subexp_standard): Call Fortran argument
6095         wrapping logic.
6096         * f-lang.c (struct value): A value which can be passed into a
6097         Fortran function call.
6098         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6099         where appropriate.
6100         (struct type): Value ready for a Fortran function call.
6101         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6102         is needed.
6103         * f-lang.h (fortran_argument_convert): Declaration.
6104         (fortran_preserve_arg_pointer): Declaration.
6105         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6106
6107 2019-03-05  Tom Tromey  <tromey@adacore.com>
6108
6109         * python/py-prettyprint.c (print_string_repr): Remove #if.
6110         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6111
6112 2019-03-05  Tom Tromey  <tromey@adacore.com>
6113
6114         * target.c (the_dummy_target): Move later.  Change type to
6115         "dummy_target".
6116         (initialize_targets): Don't initialize the_dummy_target.
6117
6118 2019-03-05  Tom Tromey  <tromey@adacore.com>
6119
6120         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6121         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6122
6123 2019-03-05  Tom Tromey  <tromey@adacore.com>
6124
6125         * windows-nat.c (windows_nat_target::attach)
6126         (windows_nat_target::detach): Don't call gdb_flush.
6127         * valprint.c (generic_val_print, val_print, val_print_string):
6128         Don't call gdb_flush.
6129         * utils.c (defaulted_query): Don't call gdb_flush.
6130         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6131         * target.c (target_announce_detach): Don't call gdb_flush.
6132         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6133         * remote.c (extended_remote_target::attach): Don't call
6134         gdb_flush.
6135         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6136         * printcmd.c (do_examine): Don't call gdb_flush.
6137         (info_display_command): Don't call gdb_flush.
6138         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6139         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6140         * memattr.c (info_mem_command): Don't call gdb_flush.
6141         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6142         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6143         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6144         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6145         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6146         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6147         (gnu_nat_target::detach): Don't call gdb_flush.
6148         * f-valprint.c (f_val_print): Don't call gdb_flush.
6149         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6150         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6151         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6152         gdb_flush.
6153         * c-valprint.c (c_val_print): Don't call gdb_flush.
6154         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6155
6156 2019-03-05  Tom Tromey  <tromey@adacore.com>
6157
6158         * varobj.c (update_dynamic_varobj_children): Update.
6159         (install_default_visualizer): Use reset, not release.
6160         * value.c (set_internalvar): Update.
6161         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6162         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6163         ATTRIBUTE_UNUSED_RESULT.
6164
6165 2019-03-05  Tom Tromey  <tromey@adacore.com>
6166
6167         * remote.c (class scoped_remote_fd) <release>: Add
6168         ATTRIBUTE_UNUSED_RESULT.
6169
6170 2019-03-05  Tom Tromey  <tromey@adacore.com>
6171
6172         * macroexp.c (struct macro_buffer) <release>: Add
6173         ATTRIBUTE_UNUSED_RESULT.
6174
6175 2019-03-05  Tom Tromey  <tromey@adacore.com>
6176
6177         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6178         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6179         ATTRIBUTE_UNUSED_RESULT.
6180
6181 2019-03-05  Tom Tromey  <tromey@adacore.com>
6182
6183         * common/scoped_fd.h (class scoped_fd) <release>: Add
6184         ATTRIBUTE_UNUSED_RESULT.
6185
6186 2019-03-05  Tom Tromey  <tromey@adacore.com>
6187
6188         * parser-defs.h (struct parser_state) <release>: Add
6189         ATTRIBUTE_UNUSED_RESULT.
6190
6191 2019-03-05  Tom Tromey  <tromey@adacore.com>
6192
6193         * utils.h (class gdb_argv) <release>: Add
6194         ATTRIBUTE_UNUSED_RESULT.
6195         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6196
6197 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6198
6199         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6200         for-loop range, to avoid compiler warnings.
6201
6202         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6203         avoid compiler warnings about unused variables.
6204
6205         * NEWS: Mention end of support for native debugging on MS-Windows
6206         before XP.
6207
6208         PR gdb/24292
6209         * common/netstuff.c:
6210         * gdbserver/gdbreplay.c
6211         * gdbserver/remote-utils.c:
6212         * ser-tcp.c:
6213         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6214         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6215         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6216         'getaddrinfo' and 'freeaddrinfo' were not available before
6217         Windows XP, and mingw.org's MinGW headers by default define
6218         _WIN32_WINNT to 0x500.
6219
6220 2019-03-01  Gary Benson <gbenson@redhat.com>
6221
6222         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6223
6224 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6225             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6226
6227         PR gdb/8527
6228         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6229         set_sigint_trap, clear_sigint_trap.
6230
6231 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6232
6233         * target.c (target_detach): Clear the regcache and the
6234         frame cache.
6235
6236 2019-02-27  Pedro Alves  <palves@redhat.com>
6237
6238         * utils.c (set_screen_size): When we cap the height/width sizes,
6239         tweak the corresponding command variable to show "unlimited":
6240
6241 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6242             Pedro Alves  <palves@redhat.com>
6243
6244         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6245         before calling rl_set_screen_size.
6246
6247 2019-02-27  Tom Tromey  <tromey@adacore.com>
6248
6249         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6250         define.
6251         * python/py-value.c: Remove Python 2.4 workaround.
6252         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6253         workaround.
6254         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6255         Python 2.4 workaround.
6256         * python/python-internal.h: Remove Python 2.4 comment.
6257         (Py_ssize_t): Don't define.
6258         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6259         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6260         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6261         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6262         * python/python.c (do_start_initialization): Remove Python 2.4
6263         workaround.
6264         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6265         (print_children): Remove Python 2.4 workaround.
6266         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6267         workaround.
6268         (CHARBUFFERPROC_NAME): Remove.
6269         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6270         Python 2.4 workaround.
6271
6272 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6273
6274         * NEWS: Note minimum Python version.
6275
6276 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6277
6278         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6279         code from these functions.  Remove corresponding ifdefs.  Use
6280         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6281         Remove gotos and target of gotos.
6282         (infpy_search_memory): Likewise.
6283
6284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6285
6286         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6287         (hppa_gdbarch_init): Don't register deleted functions with
6288         gdbarch.
6289
6290 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6291
6292         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6293         (h8300_unwind_sp): Delete.
6294         (h8300_dummy_id): Delete.
6295         (h8300_gdbarch_init): Don't register deleted functions with
6296         gdbarch.
6297
6298 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6299
6300         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6301         (ft32_unwind_pc): Delete.
6302         (ft32_unwind_sp): Delete.
6303         (ft32_gdbarch_init): Don't register deleted functions with
6304         gdbarch.
6305
6306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6307
6308         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6309         (frv_unwind_pc): Delete.
6310         (frv_unwind_sp): Delete.
6311         (frv_gdbarch_init): Don't register deleted functions with
6312         gdbarch.
6313
6314 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6315
6316         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6317         (riscv_unwind_pc): Delete.
6318         (riscv_unwind_sp): Delete.
6319         (riscv_gdbarch_init): Don't register deleted functions with
6320         gdbarch.
6321
6322 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6323
6324         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6325         (csky_unwind_pc): Delete.
6326         (csky_unwind_sp): Delete.
6327         (csky_gdbarch_init): Don't register deleted functions with
6328         gdbarch.
6329
6330 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6331
6332         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6333         (cris_unwind_pc): Delete.
6334         (cris_unwind_sp): Delete.
6335         (cris_gdbarch_init): Don't register deleted functions with
6336         gdbarch.
6337
6338 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6339
6340         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6341         (bfin_unwind_pc): Delete.
6342         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6343
6344 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6345
6346         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6347         (arm_unwind_pc): Delete.
6348         (arm_unwind_sp): Delete.
6349         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6350
6351 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6352
6353         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6354         (arc_unwind_pc): Delete.
6355         (arc_unwind_sp): Delete.
6356         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6357
6358 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6359
6360         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6361         (alpha_unwind_pc): Delete.
6362         (alpha_gdbarch_init): Don't register deleted functions with
6363         gdbarch.
6364
6365 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6366
6367         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6368         (aarch64_unwind_pc): Delete.
6369         (aarch64_unwind_sp): Delete.
6370         (aarch64_gdbarch_init): Don't register deleted functions with
6371         gdbarch.
6372
6373 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6374
6375         * gdbtypes.c (type_align): Don't consider static members when
6376         computing structure alignment.
6377
6378 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6379
6380         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6381         return 0 for other types.
6382         * arch-utils.c (default_type_align): Always return 0.
6383         * gdbarch.h: Regenerate.
6384         * gdbarch.sh (type_align): Extend comment.
6385         * gdbtypes.c (type_align): Add additional comments, always call
6386         gdbarch_type_align before applying the default rules.
6387         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6388         generic code will then apply a suitable default.
6389         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6390         types, return 0 for other types.
6391
6392 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6393
6394         * NEWS: Create a new section for the next release branch.
6395         Rename the section of the current branch, now that it has
6396         been cut.
6397
6398 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6399
6400         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6401         * version.in: Bump version to 8.3.50.DATE-git.
6402
6403 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6404
6405         * aix-thread.c (ptid_cmp): Remove unused variable.
6406         (get_signaled_thread): Likewise.
6407         (store_regs_user_thread): Likewise.
6408         (store_regs_kernel_thread): Likewise.
6409         (fetch_regs_kernel_thread): Remove shadowed variable.
6410
6411 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6412
6413         * features/riscv/32bit-cpu.xml: Add register numbers.
6414         * features/riscv/32bit-fpu.c: Regenerate.
6415         * features/riscv/32bit-fpu.xml: Add register numbers.
6416         * features/riscv/64bit-cpu.xml: Add register numbers.
6417         * features/riscv/64bit-fpu.c: Regenerate.
6418         * features/riscv/64bit-fpu.xml: Add register numbers.
6419
6420 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6421
6422         * NEWS: Mention two argument form of gdb.Value constructor.
6423         * python/py-value.c (convert_buffer_and_type_to_value): New
6424         function.
6425         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6426         Add support for handling an optional second argument.  Call
6427         convert_buffer_and_type_to_value as appropriate.
6428         * python/python-internal.h (Py_buffer_deleter): New struct.
6429         (Py_buffer_up): New typedef.
6430
6431 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6432
6433         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6434         instead of releasing ownership.
6435
6436 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6437
6438         * dwarf2read.c (open_and_init_dwp_file): Call
6439         elf_numsections instead of bfd_count_sections to initialize
6440         dwp_file->num_sections.
6441
6442 2019-02-25  Tom Tromey  <tromey@adacore.com>
6443
6444         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6445
6446 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6447
6448         * gcore.in: Add '--readnever' option when invoking GDB.
6449
6450 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6451
6452         * MAINTAINERS: Update my email address.
6453
6454 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6455
6456         * build-id.c (build_id_to_debug_bfd_1): New function.
6457         (build_id_to_debug_bfd): Look for separate debug file in
6458         sysroot.
6459
6460 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6461
6462         * gdbarch.sh: Update the copyright year range that is placed into
6463         generated files.
6464
6465 2019-02-22  Keith Seitz  <keiths@redhat.com>
6466
6467         PR symtab/23853
6468         * linespec.c (create_sals_line_offset): Search for the default
6469         symtab's filename instead of its fullname.
6470
6471 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6472
6473         * NEWS: Update style defaults.
6474
6475 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6476
6477         * main.c (captured_main_1): Disable styling in batch mode.
6478
6479 2019-02-20  Tom Tromey  <tom@tromey.com>
6480
6481         * symtab.c (symtab_symbol_info): Fix typos.
6482
6483 2019-02-20  Tom Tromey  <tromey@adacore.com>
6484
6485         * findcmd.c (_initialize_mem_search): Use upper case for
6486         metasyntactic variables.
6487
6488 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6489
6490         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6491         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6492
6493 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6494
6495         * top.h (source_file_name): Change to std::string.
6496         * top.c (source_file_name): Likewise.
6497         (command_line_input): Adjust.
6498         * cli/cli-script.c (script_from_file): Adjust.
6499
6500 2019-02-19  Tom Tromey  <tromey@adacore.com>
6501
6502         * ravenscar-thread.c
6503         (ravenscar_thread_target::update_thread_list): Don't call
6504         ada_build_task_list.
6505         * ada-lang.h (ada_build_task_list): Don't declare.
6506         * ada-tasks.c (struct ada_tasks_inferior_data)
6507         <task_list_valid_p>: Now bool.
6508         (read_known_tasks, ada_task_list_changed)
6509         (ada_tasks_invalidate_inferior_data): Update.
6510         (read_known_tasks_array): Return bool.
6511         (read_known_tasks_list): Likewise.
6512         (read_known_tasks): Return void.
6513         (ada_build_task_list): Now static.
6514
6515 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6516
6517         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6518         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6519
6520 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6521
6522         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6523         variant for ada_tasks_pspace_data_handle and
6524         ada_tasks_inferior_data_handle.
6525         (ada_tasks_pspace_data_cleanup): New function.
6526         (ada_tasks_inferior_data_cleanup): New function.
6527
6528 2019-02-17  Tom Tromey  <tom@tromey.com>
6529
6530         * macrotab.h (macro_source_fullname): Return a std::string.
6531         * macrotab.c (macro_include, check_for_redefinition)
6532         (macro_undef, macro_lookup_definition, foreach_macro)
6533         (foreach_macro_in_scope): Update.
6534         (macro_source_fullname): Return a std::string.
6535         * macrocmd.c (show_pp_source_pos): Update.
6536
6537 2019-02-17  Tom Tromey  <tom@tromey.com>
6538
6539         * macrocmd.c (show_pp_source_pos): Style the file names.
6540
6541 2019-02-17  Tom Tromey  <tom@tromey.com>
6542
6543         PR tui/24197:
6544         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6545
6546 2019-02-17  Tom Tromey  <tom@tromey.com>
6547
6548         * ada-lang.c (user_select_syms): Use filtered printing.
6549         * utils.c (wrap_style): New global.
6550         (desired_style): Remove.
6551         (emit_style_escape): Add stream parameter.
6552         (set_output_style, reset_terminal_style, prompt_for_continue):
6553         Update.
6554         (flush_wrap_buffer): Only flush gdb_stdout.
6555         (wrap_here): Set wrap_style.
6556         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6557         treat escape sequences as a character.  Change when wrap buffer is
6558         flushed.
6559         (fputs_styled): Do not set the output style when the default is
6560         requested.
6561         * ui-style.h (struct ui_file_style) <is_default>: New method.
6562         * source.c (print_source_lines_base): Emit escape sequences in one
6563         piece.
6564
6565 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6566
6567         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6568         integers and enumeration types.
6569
6570 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6571
6572         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6573         instead of lookup_symbol_in_language
6574         (do_exact_match): New function.
6575         (ada_get_symbol_name_matcher): Return do_exact_match when
6576         doing a verbatim match.
6577
6578 2019-02-15  Tom Tromey  <tromey@adacore.com>
6579
6580         * ravenscar-thread.c (ravenscar_thread_target::resume)
6581         (ravenscar_thread_target::wait): Special case wildcard requests.
6582
6583 2019-02-15  Tom Tromey  <tromey@adacore.com>
6584
6585         * ravenscar-thread.c (base_ptid): Remove.
6586         (struct ravenscar_thread_target) <close>: New method.
6587         <m_base_ptid>: New member.
6588         <update_inferior_ptid, active_task, task_is_currently_active,
6589         runtime_initialized>: Declare methods.
6590         <ravenscar_thread_target>: Add constructor.
6591         (ravenscar_thread_target::task_is_currently_active)
6592         (ravenscar_thread_target::update_inferior_ptid)
6593         (ravenscar_runtime_initialized): Rename.  Now methods.
6594         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6595         (ravenscar_thread_target::update_thread_list): Update.
6596         (ravenscar_thread_target::active_task): Now method.
6597         (ravenscar_thread_target::store_registers)
6598         (ravenscar_thread_target::prepare_to_store)
6599         (ravenscar_thread_target::prepare_to_store)
6600         (ravenscar_thread_target::mourn_inferior): Update.
6601         (ravenscar_inferior_created): Use "new" to create target.
6602         (ravenscar_thread_target::get_ada_task_ptid): Update.
6603         (_initialize_ravenscar): Don't initialize base_ptid.
6604         (ravenscar_ops): Remove global.
6605
6606 2019-02-15  Tom Tromey  <tromey@adacore.com>
6607
6608         * target.h (push_target): Declare new overload.
6609         * target.c (push_target): New overload, taking an rvalue reference.
6610         * remote.c (remote_target::open_1): Use push_target overload.
6611         * corelow.c (core_target_open): Use push_target overload.
6612
6613 2019-02-15  Tom Tromey  <tromey@adacore.com>
6614
6615         * ravenscar-thread.c (is_ravenscar_task)
6616         (ravenscar_task_is_currently_active): Return bool.
6617         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6618         (_initialize_ravenscar): Remove "(void)".
6619         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6620         Return bool.
6621
6622 2019-02-15  Tom Tromey  <tromey@adacore.com>
6623
6624         * ravenscar-thread.c (ravenscar_runtime_initializer)
6625         (has_ravenscar_runtime, get_running_thread_id)
6626         (ravenscar_thread_target::resume): Fix indentation.
6627
6628 2019-02-15  Tom Tromey  <tromey@adacore.com>
6629
6630         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6631         from ravenscar_arch_ops.
6632         (sparc_ravenscar_ops::fetch_registers)
6633         (sparc_ravenscar_ops::store_registers): Now methods.
6634         (sparc_ravenscar_prepare_to_store): Remove.
6635         (sparc_ravenscar_ops): Redefine.
6636         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6637         methods and destructor.  Remove members.
6638         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6639         (ravenscar_thread_target::store_registers)
6640         (ravenscar_thread_target::prepare_to_store): Update.
6641         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6642         Remove.
6643         (struct ppc_ravenscar_powerpc_ops): Derive from
6644         ravenscar_arch_ops.
6645         (ppc_ravenscar_powerpc_ops::fetch_registers)
6646         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6647         (ppc_ravenscar_powerpc_ops): Redefine.
6648         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6649         (ppc_ravenscar_e500_ops::fetch_registers)
6650         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6651         (ppc_ravenscar_e500_ops): Redefine.
6652         * aarch64-ravenscar-thread.c
6653         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6654         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6655         (aarch64_ravenscar_fetch_registers)
6656         (aarch64_ravenscar_store_registers): Now methods.
6657         (aarch64_ravenscar_ops): Redefine.
6658
6659 2019-02-15  Tom Tromey  <tromey@adacore.com>
6660
6661         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6662         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6663         (ravenscar_thread_target::stopped_by_watchpoint)
6664         (ravenscar_thread_target::stopped_data_address)
6665         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6666
6667 2019-02-15  Tom Tromey  <tromey@adacore.com>
6668
6669         * ravenscar-thread.c: Fix some typos.
6670
6671 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6672             Tom Tromey  <tromey@adacore.com>
6673
6674         * ada-lang.c (ada_exception_sal): Change addr_string to a
6675         std::string.
6676         (create_ada_exception_catchpoint): Update.
6677
6678 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6679             Tom Tromey  <tromey@adacore.com>
6680
6681         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6682         (bp_location_ops): Remove.
6683         (base_breakpoint_allocate_location): Update.
6684         (free_bp_location): Update.
6685         * ada-lang.c (class ada_catchpoint_location)
6686         <ada_catchpoint_location>: Remove ops parameter.
6687         (ada_catchpoint_location_dtor): Remove.
6688         (ada_catchpoint_location_ops): Remove.
6689         (allocate_location_exception): Update.
6690         * breakpoint.h (struct bp_location_ops): Remove.
6691         (class bp_location) <bp_location>: Remove bp_location_ops
6692         parameter.
6693         <~bp_location>: Add destructor.
6694         <ops>: Remove.
6695
6696 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6697             Pedro Alves  <palves@redhat.com>
6698
6699         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6700         'PATH_MAX'.
6701
6702 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6703             Samuel Thibault  <samuel.thibault@gnu.org>
6704             Thomas Schwinge  <thomas@codesourcery.com>
6705
6706         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6707         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6708
6709 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6710
6711         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6712         (check_empty): Use "const char *".
6713
6714         * gnu-nat.c (gnu_nat_target::detach): Instead of
6715         'detach_inferior (pid)' call
6716         'detach_inferior (find_inferior_pid (pid))'.
6717
6718         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6719         'nat/fork-inferior.o'.
6720         * gnu-nat.c: #include "nat/fork-inferior.h".
6721
6722         * gnu-nat.c (gnu_nat_target::detach): Instead of
6723         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6724         * gnu-nat.h: #include "inf-child.h".
6725         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6726         'i386_gnu_nat_target::fetch_registers'.
6727         (gnu_store_registers): Rename/move to
6728         'i386_gnu_nat_target::store_registers'.
6729
6730         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6731         * gnu-nat.h (mach_thread_info): New function.
6732         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6733
6734         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6735
6736 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6737
6738         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6739
6740 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6741
6742         * windows-nat.c (windows_add_thread): Add new parameter
6743         "main_thread_p" with default value set to false.  Update
6744         function documentation as well as all callers.
6745         (windows_delete_thread): Likewise.
6746         (fake_create_process): Update call to windows_add_thread.
6747         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6748         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6749         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6750         call to windows_delete_thread.
6751
6752 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6753
6754         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6755
6756 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6757
6758         * symfile.c (find_separate_debug_file): Use canonical path of
6759         sysroot with child_path instead of gdb_sysroot if it is valid.
6760
6761 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6762
6763         * symfile.c (find_separate_debug_file): Use child_path to
6764         determine if an object file is under a sysroot.
6765
6766 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6767
6768         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6769         unittests/child-path-selftests.c.
6770         * common/pathstuff.c (child_path): New function.
6771         * common/pathstuff.h (child_path): New prototype.
6772         * unittests/child-path-selftests.c: New file.
6773
6774 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6775
6776         * symfile.c (find_separate_debug_file): Look for separate debug
6777         files in debug directories under the sysroot.
6778
6779 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6780
6781         * symtab.h (struct minimal_symbol data_p): New const method.
6782         (struct minimal_symbol text_p): Likewise.
6783         * symtab.c (output_source_filename): Use file name style
6784         to print file name.
6785         (print_symbol_info): Likewise.
6786         (print_msymbol_info): Use address style to print addresses.
6787         Use function name style to print executable text symbols.
6788         (expand_symtab_containing_pc): Use data_p.
6789         (find_pc_sect_compunit_symtab): Likewise.
6790
6791 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6792
6793         * breakpoint.c (describe_other_breakpoints): Use address style
6794         to print addresses.
6795         (say_where): Likewise.
6796
6797 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6798
6799         * ada-typeprint.c (print_func_type): Print function name
6800         style to print function name.
6801         * c-typeprint.c (c_print_type_1): Likewise.
6802
6803 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6804
6805         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6806         for execve.
6807
6808 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6809
6810         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6811         type_stack.
6812
6813 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6814
6815         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6816         TYPE_CODE_REF types.
6817
6818 2019-02-08  Jim Wilson  <jimw@sifive.com>
6819
6820         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6821         (riscv_linux_fregset): New.
6822         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6823
6824 2019-02-07  Tom Tromey  <tom@tromey.com>
6825
6826         * thread.c (thread_cancel_execution_command): Update.
6827         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6828         methods.
6829         (struct thread_fsm_ops): Remove.
6830         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6831         (thread_fsm_should_stop, thread_fsm_return_value)
6832         (thread_fsm_set_finished, thread_fsm_finished_p)
6833         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6834         Don't declare.
6835         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6836         * infrun.c (clear_proceed_status_thread)
6837         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6838         (print_stop_event): Update.
6839         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6840         Add constructor.
6841         (step_command_fsm_ops): Remove.
6842         (new_step_command_fsm): Remove.
6843         (step_1): Update.
6844         (step_command_fsm::should_stop): Rename from
6845         step_command_fsm_should_stop.
6846         (step_command_fsm::clean_up): Rename from
6847         step_command_fsm_clean_up.
6848         (step_command_fsm::do_async_reply_reason): Rename from
6849         step_command_fsm_async_reply_reason.
6850         (struct until_next_fsm): Inherit from thread_fsm.  Add
6851         constructor.
6852         (until_next_fsm_ops): Remove.
6853         (new_until_next_fsm): Remove.
6854         (until_next_fsm::should_stop): Rename from
6855         until_next_fsm_should_stop.
6856         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6857         (until_next_fsm::do_async_reply_reason): Rename from
6858         until_next_fsm_async_reply_reason.
6859         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6860         constructor.  Change type of breakpoint.
6861         (finish_command_fsm_ops): Remove.
6862         (new_finish_command_fsm): Remove.
6863         (finish_command_fsm::should_stop): Rename from
6864         finish_command_fsm_should_stop.
6865         (finish_command_fsm::clean_up): Rename from
6866         finish_command_fsm_clean_up.
6867         (finish_command_fsm::return_value): Rename from
6868         finish_command_fsm_return_value.
6869         (finish_command_fsm::do_async_reply_reason): Rename from
6870         finish_command_fsm_async_reply_reason.
6871         (finish_command): Update.
6872         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6873         Add constructor.
6874         (call_thread_fsm_ops): Remove.
6875         (call_thread_fsm::call_thread_fsm): Rename from
6876         new_call_thread_fsm.
6877         (call_thread_fsm::should_stop): Rename from
6878         call_thread_fsm_should_stop.
6879         (call_thread_fsm::should_notify_stop): Rename from
6880         call_thread_fsm_should_notify_stop.
6881         (run_inferior_call, call_function_by_hand_dummy): Update.
6882         * cli/cli-interp.c (should_print_stop_to_console): Update.
6883         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6884         Add constructor.  Change type of location_breakpoint,
6885         caller_breakpoint.
6886         (until_break_fsm_ops): Remove.
6887         (new_until_break_fsm): Remove.
6888         (until_break_fsm::should_stop): Rename from
6889         until_break_fsm_should_stop.
6890         (until_break_fsm::clean_up): Rename from
6891         until_break_fsm_clean_up.
6892         (until_break_fsm::do_async_reply_reason): Rename from
6893         until_break_fsm_async_reply_reason.
6894         (until_break_command): Update.
6895         * thread-fsm.c: Remove.
6896         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6897
6898 2019-02-07  Tom Tromey  <tom@tromey.com>
6899
6900         * yy-remap.h: Add include guard.
6901         * xtensa-tdep.h: Add include guard.
6902         * xcoffread.h: Rename include guard.
6903         * varobj-iter.h: Add include guard.
6904         * tui/tui.h: Rename include guard.
6905         * tui/tui-winsource.h: Rename include guard.
6906         * tui/tui-wingeneral.h: Rename include guard.
6907         * tui/tui-windata.h: Rename include guard.
6908         * tui/tui-win.h: Rename include guard.
6909         * tui/tui-stack.h: Rename include guard.
6910         * tui/tui-source.h: Rename include guard.
6911         * tui/tui-regs.h: Rename include guard.
6912         * tui/tui-out.h: Rename include guard.
6913         * tui/tui-layout.h: Rename include guard.
6914         * tui/tui-io.h: Rename include guard.
6915         * tui/tui-hooks.h: Rename include guard.
6916         * tui/tui-file.h: Rename include guard.
6917         * tui/tui-disasm.h: Rename include guard.
6918         * tui/tui-data.h: Rename include guard.
6919         * tui/tui-command.h: Rename include guard.
6920         * tic6x-tdep.h: Add include guard.
6921         * target/waitstatus.h: Rename include guard.
6922         * target/wait.h: Rename include guard.
6923         * target/target.h: Rename include guard.
6924         * target/resume.h: Rename include guard.
6925         * target-float.h: Rename include guard.
6926         * stabsread.h: Add include guard.
6927         * rs6000-tdep.h: Add include guard.
6928         * riscv-fbsd-tdep.h: Add include guard.
6929         * regformats/regdef.h: Rename include guard.
6930         * record.h: Rename include guard.
6931         * python/python.h: Rename include guard.
6932         * python/python-internal.h: Rename include guard.
6933         * python/py-stopevent.h: Rename include guard.
6934         * python/py-ref.h: Rename include guard.
6935         * python/py-record.h: Rename include guard.
6936         * python/py-record-full.h: Rename include guard.
6937         * python/py-record-btrace.h: Rename include guard.
6938         * python/py-instruction.h: Rename include guard.
6939         * python/py-events.h: Rename include guard.
6940         * python/py-event.h: Rename include guard.
6941         * procfs.h: Add include guard.
6942         * proc-utils.h: Add include guard.
6943         * p-lang.h: Add include guard.
6944         * or1k-tdep.h: Rename include guard.
6945         * observable.h: Rename include guard.
6946         * nto-tdep.h: Rename include guard.
6947         * nat/x86-linux.h: Rename include guard.
6948         * nat/x86-linux-dregs.h: Rename include guard.
6949         * nat/x86-gcc-cpuid.h: Add include guard.
6950         * nat/x86-dregs.h: Rename include guard.
6951         * nat/x86-cpuid.h: Rename include guard.
6952         * nat/ppc-linux.h: Rename include guard.
6953         * nat/mips-linux-watch.h: Rename include guard.
6954         * nat/linux-waitpid.h: Rename include guard.
6955         * nat/linux-ptrace.h: Rename include guard.
6956         * nat/linux-procfs.h: Rename include guard.
6957         * nat/linux-osdata.h: Rename include guard.
6958         * nat/linux-nat.h: Rename include guard.
6959         * nat/linux-namespaces.h: Rename include guard.
6960         * nat/linux-btrace.h: Rename include guard.
6961         * nat/glibc_thread_db.h: Rename include guard.
6962         * nat/gdb_thread_db.h: Rename include guard.
6963         * nat/gdb_ptrace.h: Rename include guard.
6964         * nat/fork-inferior.h: Rename include guard.
6965         * nat/amd64-linux-siginfo.h: Rename include guard.
6966         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6967         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6968         * nat/aarch64-linux.h: Rename include guard.
6969         * nat/aarch64-linux-hw-point.h: Rename include guard.
6970         * mn10300-tdep.h: Add include guard.
6971         * mips-linux-tdep.h: Add include guard.
6972         * mi/mi-parse.h: Rename include guard.
6973         * mi/mi-out.h: Rename include guard.
6974         * mi/mi-main.h: Rename include guard.
6975         * mi/mi-interp.h: Rename include guard.
6976         * mi/mi-getopt.h: Rename include guard.
6977         * mi/mi-console.h: Rename include guard.
6978         * mi/mi-common.h: Rename include guard.
6979         * mi/mi-cmds.h: Rename include guard.
6980         * mi/mi-cmd-break.h: Rename include guard.
6981         * m2-lang.h: Add include guard.
6982         * location.h: Rename include guard.
6983         * linux-record.h: Rename include guard.
6984         * linux-nat.h: Add include guard.
6985         * linux-fork.h: Add include guard.
6986         * i386-darwin-tdep.h: Rename include guard.
6987         * hppa-linux-offsets.h: Add include guard.
6988         * guile/guile.h: Rename include guard.
6989         * guile/guile-internal.h: Rename include guard.
6990         * gnu-nat.h: Rename include guard.
6991         * gdb-stabs.h: Rename include guard.
6992         * frv-tdep.h: Add include guard.
6993         * f-lang.h: Add include guard.
6994         * event-loop.h: Add include guard.
6995         * darwin-nat.h: Rename include guard.
6996         * cp-abi.h: Rename include guard.
6997         * config/sparc/nm-sol2.h: Rename include guard.
6998         * config/nm-nto.h: Rename include guard.
6999         * config/nm-linux.h: Add include guard.
7000         * config/i386/nm-i386gnu.h: Rename include guard.
7001         * config/djgpp/nl_types.h: Rename include guard.
7002         * config/djgpp/langinfo.h: Rename include guard.
7003         * compile/gcc-cp-plugin.h: Add include guard.
7004         * compile/gcc-c-plugin.h: Add include guard.
7005         * compile/compile.h: Rename include guard.
7006         * compile/compile-object-run.h: Rename include guard.
7007         * compile/compile-object-load.h: Rename include guard.
7008         * compile/compile-internal.h: Rename include guard.
7009         * compile/compile-cplus.h: Rename include guard.
7010         * compile/compile-c.h: Rename include guard.
7011         * common/xml-utils.h: Rename include guard.
7012         * common/x86-xstate.h: Rename include guard.
7013         * common/version.h: Rename include guard.
7014         * common/vec.h: Rename include guard.
7015         * common/tdesc.h: Rename include guard.
7016         * common/selftest.h: Rename include guard.
7017         * common/scoped_restore.h: Rename include guard.
7018         * common/scoped_mmap.h: Rename include guard.
7019         * common/scoped_fd.h: Rename include guard.
7020         * common/safe-iterator.h: Rename include guard.
7021         * common/run-time-clock.h: Rename include guard.
7022         * common/refcounted-object.h: Rename include guard.
7023         * common/queue.h: Rename include guard.
7024         * common/ptid.h: Rename include guard.
7025         * common/print-utils.h: Rename include guard.
7026         * common/preprocessor.h: Rename include guard.
7027         * common/pathstuff.h: Rename include guard.
7028         * common/observable.h: Rename include guard.
7029         * common/netstuff.h: Rename include guard.
7030         * common/job-control.h: Rename include guard.
7031         * common/host-defs.h: Rename include guard.
7032         * common/gdb_wait.h: Rename include guard.
7033         * common/gdb_vecs.h: Rename include guard.
7034         * common/gdb_unlinker.h: Rename include guard.
7035         * common/gdb_unique_ptr.h: Rename include guard.
7036         * common/gdb_tilde_expand.h: Rename include guard.
7037         * common/gdb_sys_time.h: Rename include guard.
7038         * common/gdb_string_view.h: Rename include guard.
7039         * common/gdb_splay_tree.h: Rename include guard.
7040         * common/gdb_setjmp.h: Rename include guard.
7041         * common/gdb_ref_ptr.h: Rename include guard.
7042         * common/gdb_optional.h: Rename include guard.
7043         * common/gdb_locale.h: Rename include guard.
7044         * common/gdb_assert.h: Rename include guard.
7045         * common/filtered-iterator.h: Rename include guard.
7046         * common/filestuff.h: Rename include guard.
7047         * common/fileio.h: Rename include guard.
7048         * common/environ.h: Rename include guard.
7049         * common/common-utils.h: Rename include guard.
7050         * common/common-types.h: Rename include guard.
7051         * common/common-regcache.h: Rename include guard.
7052         * common/common-inferior.h: Rename include guard.
7053         * common/common-gdbthread.h: Rename include guard.
7054         * common/common-exceptions.h: Rename include guard.
7055         * common/common-defs.h: Rename include guard.
7056         * common/common-debug.h: Rename include guard.
7057         * common/cleanups.h: Rename include guard.
7058         * common/buffer.h: Rename include guard.
7059         * common/btrace-common.h: Rename include guard.
7060         * common/break-common.h: Rename include guard.
7061         * cli/cli-utils.h: Rename include guard.
7062         * cli/cli-style.h: Rename include guard.
7063         * cli/cli-setshow.h: Rename include guard.
7064         * cli/cli-script.h: Rename include guard.
7065         * cli/cli-interp.h: Rename include guard.
7066         * cli/cli-decode.h: Rename include guard.
7067         * cli/cli-cmds.h: Rename include guard.
7068         * charset-list.h: Add include guard.
7069         * buildsym-legacy.h: Rename include guard.
7070         * bfin-tdep.h: Add include guard.
7071         * ax.h: Rename include guard.
7072         * arm-linux-tdep.h: Add include guard.
7073         * arm-fbsd-tdep.h: Add include guard.
7074         * arch/xtensa.h: Rename include guard.
7075         * arch/tic6x.h: Add include guard.
7076         * arch/i386.h: Add include guard.
7077         * arch/arm.h: Rename include guard.
7078         * arch/arm-linux.h: Rename include guard.
7079         * arch/arm-get-next-pcs.h: Rename include guard.
7080         * arch/amd64.h: Add include guard.
7081         * arch/aarch64-insn.h: Rename include guard.
7082         * arch-utils.h: Rename include guard.
7083         * annotate.h: Add include guard.
7084         * amd64-darwin-tdep.h: Rename include guard.
7085         * aarch64-linux-tdep.h: Add include guard.
7086         * aarch64-fbsd-tdep.h: Add include guard.
7087         * aarch32-linux-nat.h: Add include guard.
7088
7089 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7090
7091         * macrotab.c (macro_define_internal): New function that
7092         factorizes macro_define_object_internal and macro_define_function
7093         code.
7094         (macro_define_object_internal): Use macro_define_internal.
7095         (macro_define_function): Likewise.
7096
7097 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7098
7099         * macrocmd.c (extract_identifier): Return
7100         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7101         callers.
7102
7103 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7104
7105         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7106
7107 2019-02-05  Tom Tromey  <tom@tromey.com>
7108
7109         * target.c (target_stack::unpush): Move assertion earlier.
7110
7111 2019-01-30  Tom Tromey  <tom@tromey.com>
7112
7113         PR python/23615:
7114         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7115         (gdbpy_parse_and_eval): Likewise.
7116         * python/python-internal.h (gdbpy_allow_threads): New class.
7117
7118 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7119
7120         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7121         (aarch64_fbsd_fpregmap): Move earlier.
7122         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7123         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7124         instead of individual calls to trad_frame_set_reg_addr.
7125         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7126         earlier.
7127         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7128         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7129         instead of individual calls to trad_frame_set_reg_addr.
7130
7131 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7132
7133         * CONTRIBUTE: Replace contribution list with wiki link.
7134
7135 2019-01-25  Tom Tromey  <tom@tromey.com>
7136
7137         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7138
7139 2019-01-25  Tom Tromey  <tom@tromey.com>
7140
7141         * xtensa-linux-nat.c: Fix common/ includes.
7142         * xml-support.h: Fix common/ includes.
7143         * xml-support.c: Fix common/ includes.
7144         * x86-linux-nat.c: Fix common/ includes.
7145         * windows-nat.c: Fix common/ includes.
7146         * varobj.h: Fix common/ includes.
7147         * varobj.c: Fix common/ includes.
7148         * value.c: Fix common/ includes.
7149         * valops.c: Fix common/ includes.
7150         * utils.c: Fix common/ includes.
7151         * unittests/xml-utils-selftests.c: Fix common/ includes.
7152         * unittests/utils-selftests.c: Fix common/ includes.
7153         * unittests/unpack-selftests.c: Fix common/ includes.
7154         * unittests/tracepoint-selftests.c: Fix common/ includes.
7155         * unittests/style-selftests.c: Fix common/ includes.
7156         * unittests/string_view-selftests.c: Fix common/ includes.
7157         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7158         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7159         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7160         * unittests/rsp-low-selftests.c: Fix common/ includes.
7161         * unittests/parse-connection-spec-selftests.c: Fix common/
7162         includes.
7163         * unittests/optional-selftests.c: Fix common/ includes.
7164         * unittests/offset-type-selftests.c: Fix common/ includes.
7165         * unittests/observable-selftests.c: Fix common/ includes.
7166         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7167         * unittests/memrange-selftests.c: Fix common/ includes.
7168         * unittests/memory-map-selftests.c: Fix common/ includes.
7169         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7170         * unittests/function-view-selftests.c: Fix common/ includes.
7171         * unittests/environ-selftests.c: Fix common/ includes.
7172         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7173         * unittests/common-utils-selftests.c: Fix common/ includes.
7174         * unittests/cli-utils-selftests.c: Fix common/ includes.
7175         * unittests/array-view-selftests.c: Fix common/ includes.
7176         * ui-file.c: Fix common/ includes.
7177         * tui/tui-io.c: Fix common/ includes.
7178         * tracepoint.h: Fix common/ includes.
7179         * tracepoint.c: Fix common/ includes.
7180         * tracefile-tfile.c: Fix common/ includes.
7181         * top.h: Fix common/ includes.
7182         * top.c: Fix common/ includes.
7183         * thread.c: Fix common/ includes.
7184         * target/waitstatus.h: Fix common/ includes.
7185         * target/waitstatus.c: Fix common/ includes.
7186         * target.h: Fix common/ includes.
7187         * target.c: Fix common/ includes.
7188         * target-memory.c: Fix common/ includes.
7189         * target-descriptions.c: Fix common/ includes.
7190         * symtab.h: Fix common/ includes.
7191         * symfile.c: Fix common/ includes.
7192         * stap-probe.c: Fix common/ includes.
7193         * spu-linux-nat.c: Fix common/ includes.
7194         * sparc-nat.c: Fix common/ includes.
7195         * source.c: Fix common/ includes.
7196         * solib.c: Fix common/ includes.
7197         * solib-target.c: Fix common/ includes.
7198         * ser-unix.c: Fix common/ includes.
7199         * ser-tcp.c: Fix common/ includes.
7200         * ser-pipe.c: Fix common/ includes.
7201         * ser-base.c: Fix common/ includes.
7202         * selftest-arch.c: Fix common/ includes.
7203         * s12z-tdep.c: Fix common/ includes.
7204         * rust-exp.y: Fix common/ includes.
7205         * rs6000-aix-tdep.c: Fix common/ includes.
7206         * riscv-tdep.c: Fix common/ includes.
7207         * remote.c: Fix common/ includes.
7208         * remote-notif.h: Fix common/ includes.
7209         * remote-fileio.h: Fix common/ includes.
7210         * remote-fileio.c: Fix common/ includes.
7211         * regcache.h: Fix common/ includes.
7212         * regcache.c: Fix common/ includes.
7213         * record-btrace.c: Fix common/ includes.
7214         * python/python.c: Fix common/ includes.
7215         * python/py-type.c: Fix common/ includes.
7216         * python/py-inferior.c: Fix common/ includes.
7217         * progspace.h: Fix common/ includes.
7218         * producer.c: Fix common/ includes.
7219         * procfs.c: Fix common/ includes.
7220         * proc-api.c: Fix common/ includes.
7221         * printcmd.c: Fix common/ includes.
7222         * ppc-linux-nat.c: Fix common/ includes.
7223         * parser-defs.h: Fix common/ includes.
7224         * osdata.c: Fix common/ includes.
7225         * obsd-nat.c: Fix common/ includes.
7226         * nat/x86-linux.c: Fix common/ includes.
7227         * nat/x86-linux-dregs.c: Fix common/ includes.
7228         * nat/x86-dregs.h: Fix common/ includes.
7229         * nat/x86-dregs.c: Fix common/ includes.
7230         * nat/ppc-linux.c: Fix common/ includes.
7231         * nat/mips-linux-watch.h: Fix common/ includes.
7232         * nat/mips-linux-watch.c: Fix common/ includes.
7233         * nat/linux-waitpid.c: Fix common/ includes.
7234         * nat/linux-ptrace.h: Fix common/ includes.
7235         * nat/linux-ptrace.c: Fix common/ includes.
7236         * nat/linux-procfs.c: Fix common/ includes.
7237         * nat/linux-personality.c: Fix common/ includes.
7238         * nat/linux-osdata.c: Fix common/ includes.
7239         * nat/linux-namespaces.c: Fix common/ includes.
7240         * nat/linux-btrace.h: Fix common/ includes.
7241         * nat/linux-btrace.c: Fix common/ includes.
7242         * nat/fork-inferior.c: Fix common/ includes.
7243         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7244         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7245         * nat/aarch64-linux.c: Fix common/ includes.
7246         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7247         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7248         * namespace.h: Fix common/ includes.
7249         * mips-linux-tdep.c: Fix common/ includes.
7250         * minsyms.c: Fix common/ includes.
7251         * mi/mi-parse.h: Fix common/ includes.
7252         * mi/mi-main.c: Fix common/ includes.
7253         * mi/mi-cmd-env.c: Fix common/ includes.
7254         * memrange.h: Fix common/ includes.
7255         * memattr.c: Fix common/ includes.
7256         * maint.h: Fix common/ includes.
7257         * maint.c: Fix common/ includes.
7258         * main.c: Fix common/ includes.
7259         * machoread.c: Fix common/ includes.
7260         * location.c: Fix common/ includes.
7261         * linux-thread-db.c: Fix common/ includes.
7262         * linux-nat.c: Fix common/ includes.
7263         * linux-fork.c: Fix common/ includes.
7264         * inline-frame.c: Fix common/ includes.
7265         * infrun.c: Fix common/ includes.
7266         * inflow.c: Fix common/ includes.
7267         * inferior.h: Fix common/ includes.
7268         * inferior.c: Fix common/ includes.
7269         * infcmd.c: Fix common/ includes.
7270         * inf-ptrace.c: Fix common/ includes.
7271         * inf-child.c: Fix common/ includes.
7272         * ia64-linux-nat.c: Fix common/ includes.
7273         * i387-tdep.c: Fix common/ includes.
7274         * i386-tdep.c: Fix common/ includes.
7275         * i386-linux-tdep.c: Fix common/ includes.
7276         * i386-linux-nat.c: Fix common/ includes.
7277         * i386-go32-tdep.c: Fix common/ includes.
7278         * i386-fbsd-tdep.c: Fix common/ includes.
7279         * i386-fbsd-nat.c: Fix common/ includes.
7280         * guile/scm-type.c: Fix common/ includes.
7281         * guile/guile.c: Fix common/ includes.
7282         * go32-nat.c: Fix common/ includes.
7283         * gnu-nat.c: Fix common/ includes.
7284         * gdbthread.h: Fix common/ includes.
7285         * gdbarch-selftests.c: Fix common/ includes.
7286         * gdb_usleep.c: Fix common/ includes.
7287         * gdb_select.h: Fix common/ includes.
7288         * gdb_bfd.c: Fix common/ includes.
7289         * gcore.c: Fix common/ includes.
7290         * fork-child.c: Fix common/ includes.
7291         * findvar.c: Fix common/ includes.
7292         * fbsd-nat.c: Fix common/ includes.
7293         * event-top.c: Fix common/ includes.
7294         * event-loop.c: Fix common/ includes.
7295         * dwarf2read.c: Fix common/ includes.
7296         * dwarf2loc.c: Fix common/ includes.
7297         * dwarf2-frame.c: Fix common/ includes.
7298         * dwarf-index-cache.c: Fix common/ includes.
7299         * dtrace-probe.c: Fix common/ includes.
7300         * disasm-selftests.c: Fix common/ includes.
7301         * defs.h: Fix common/ includes.
7302         * csky-tdep.c: Fix common/ includes.
7303         * cp-valprint.c: Fix common/ includes.
7304         * cp-support.h: Fix common/ includes.
7305         * cp-support.c: Fix common/ includes.
7306         * corelow.c: Fix common/ includes.
7307         * completer.h: Fix common/ includes.
7308         * completer.c: Fix common/ includes.
7309         * compile/compile.c: Fix common/ includes.
7310         * compile/compile-loc2c.c: Fix common/ includes.
7311         * compile/compile-cplus-types.c: Fix common/ includes.
7312         * compile/compile-cplus-symbols.c: Fix common/ includes.
7313         * command.h: Fix common/ includes.
7314         * cli/cli-dump.c: Fix common/ includes.
7315         * cli/cli-cmds.c: Fix common/ includes.
7316         * charset.c: Fix common/ includes.
7317         * build-id.c: Fix common/ includes.
7318         * btrace.h: Fix common/ includes.
7319         * btrace.c: Fix common/ includes.
7320         * breakpoint.h: Fix common/ includes.
7321         * breakpoint.c: Fix common/ includes.
7322         * ax.h:
7323         (enum agent_op): Fix common/ includes.
7324         * ax-general.c (struct aop_map): Fix common/ includes.
7325         * ax-gdb.c: Fix common/ includes.
7326         * auxv.c: Fix common/ includes.
7327         * auto-load.c: Fix common/ includes.
7328         * arm-tdep.c: Fix common/ includes.
7329         * arch/riscv.c: Fix common/ includes.
7330         * arch/ppc-linux-common.c: Fix common/ includes.
7331         * arch/i386.c: Fix common/ includes.
7332         * arch/arm.c: Fix common/ includes.
7333         * arch/arm-linux.c: Fix common/ includes.
7334         * arch/arm-get-next-pcs.c: Fix common/ includes.
7335         * arch/amd64.c: Fix common/ includes.
7336         * arch/aarch64.c: Fix common/ includes.
7337         * arch/aarch64-insn.c: Fix common/ includes.
7338         * arch-utils.c: Fix common/ includes.
7339         * amd64-windows-tdep.c: Fix common/ includes.
7340         * amd64-tdep.c: Fix common/ includes.
7341         * amd64-sol2-tdep.c: Fix common/ includes.
7342         * amd64-obsd-tdep.c: Fix common/ includes.
7343         * amd64-nbsd-tdep.c: Fix common/ includes.
7344         * amd64-linux-tdep.c: Fix common/ includes.
7345         * amd64-linux-nat.c: Fix common/ includes.
7346         * amd64-fbsd-tdep.c: Fix common/ includes.
7347         * amd64-fbsd-nat.c: Fix common/ includes.
7348         * amd64-dicos-tdep.c: Fix common/ includes.
7349         * amd64-darwin-tdep.c: Fix common/ includes.
7350         * agent.c: Fix common/ includes.
7351         * ada-lang.h: Fix common/ includes.
7352         * ada-lang.c: Fix common/ includes.
7353         * aarch64-tdep.c: Fix common/ includes.
7354
7355 2019-01-25  Tom Tromey  <tom@tromey.com>
7356
7357         * common/create-version.sh: Use common/version.h.
7358
7359 2019-01-24  Pedro Alves  <palves@redhat.com>
7360
7361         * infrun.c (signal_stop, signal_print, signal_program)
7362         (signal_catch, signal_pass): Now arrays instead of pointers.
7363         (update_signals_program_target, do_target_resume)
7364         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7365         * linux-nat.c (linux_nat_target::pass_signals)
7366         (linux_nat_target::create_inferior, linux_nat_target::attach):
7367         Adjust.
7368         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7369         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7370         * procfs.c (procfs_target::pass_signals): Adjust.
7371         * record-full.c (record_full_target::resume): Adjust.
7372         * remote.c (remote_target::pass_signals)
7373         (remote_target::program_signals): Adjust.
7374         * target-debug.h (target_debug_print_signals): Now takes a
7375         gdb::array_view as parameter.  Adjust.
7376         * target.h (target_ops) <pass_signals, program_signals>: Replace
7377         pointer and length parameters with gdb::array_view.
7378         (target_pass_signals, target_program_signals): Likewise.
7379         * target-delegates.c: Regenerate.
7380
7381 2019-01-24  Pedro Alves  <palves@redhat.com>
7382
7383         * common/forward-scope-exit.h
7384         (forward_scope_exit::forward_scope_exit): Pass arguments to
7385         m_bind_function directly, instead of creating a std::bind and
7386         copying that.
7387
7388 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7389
7390         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7391         for static members.
7392         (pass_in_v_vfp_candidate): Likewise.
7393
7394 2019-01-23  Tom Tromey  <tom@tromey.com>
7395             Pedro Alves  <palves@redhat.com>
7396
7397         * regcache.c (class regcache_invalidator): Remove.
7398         (regcache::raw_write): Use make_scope_exit.
7399
7400 2019-01-23  Tom Tromey  <tom@tromey.com>
7401
7402         * ui-out.h (class ui_out_emit_type): Update comment.
7403
7404 2019-01-23  Tom Tromey  <tom@tromey.com>
7405
7406         * infrun.c (fetch_inferior_event): Update comment.
7407
7408 2019-01-23  Tom Tromey  <tom@tromey.com>
7409             Pedro Alves  <palves@redhat.com>
7410
7411         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7412         parameter.
7413         (fetch_inferior_event): Use SCOPE_EXIT.
7414
7415
7416 2019-01-23  Tom Tromey  <tom@tromey.com>
7417             Pedro Alves  <palves@redhat.com>
7418
7419         * infrun.c (disable_thread_events): Delete.
7420         (stop_all_threads): Use SCOPE_EXIT.
7421
7422 2019-01-23  Tom Tromey  <tom@tromey.com>
7423             Pedro Alves  <palves@redhat.com>
7424
7425         * symfile.c: Include forward-scope-exit.h.
7426         (clear_symtab_users_cleanup): Replace forward declaration with
7427         a FORWARD_SCOPE_EXIT.
7428         (syms_from_objfile_1): Use the forward_scope_exit and
7429         gdb::optional instead of cleanup_function.
7430         (reread_symbols): Use the forward_scope_exit instead of
7431         cleanup_function.
7432         (clear_symtab_users_cleanup): Remove function.
7433
7434 2019-01-23  Tom Tromey  <tom@tromey.com>
7435             Pedro Alves  <palves@redhat.com>
7436
7437         * linux-nat.c: Include scope-exit.h.
7438         (cleanup_target_stop): Remove.
7439         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7440         SCOPE_EXIT.
7441
7442 2019-01-23  Tom Tromey  <tom@tromey.com>
7443             Pedro Alves  <palves@redhat.com>
7444
7445         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7446         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7447
7448 2019-01-23  Tom Tromey  <tom@tromey.com>
7449             Andrew Burgess  <andrew.burgess@embecosm.com>
7450             Pedro Alves  <palves@redhat.com>
7451
7452         * infrun.c (fetch_inferior_event): Use scope_exit.
7453         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7454         * top.c (execute_command): Use scope_exit.
7455         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7456         * utils.c (do_bpstat_clear_actions_cleanup)
7457         (make_bpstat_clear_actions_cleanup): Remove.
7458
7459 2019-01-23  Tom Tromey  <tom@tromey.com>
7460             Pedro Alves  <palves@redhat.com>
7461
7462         * infrun.c: Include "common/scope-exit.h"
7463         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7464         (wait_for_inferior): Use SCOPE_EXIT.
7465         (fetch_inferior_event): Use scope_exit.
7466
7467 2019-01-23  Tom Tromey  <tom@tromey.com>
7468             Pedro Alves  <palves@redhat.com>
7469
7470         * breakpoint.c (create_breakpoint): Remove cleanup.
7471
7472 2019-01-23  Tom Tromey  <tom@tromey.com>
7473             Andrew Burgess  <andrew.burgess@embecosm.com>
7474             Pedro Alves  <palves@redhat.com>
7475
7476 2019-01-23  Pedro Alves  <palves@redhat.com>
7477
7478         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7479
7480 2019-01-23  Pedro Alves  <palves@redhat.com>
7481             Andrew Burgess  <andrew.burgess@embecosm.com>
7482
7483         * gdbthread.h: Include "common/forward-scope-exit.h".
7484         (scoped_finish_thread_state): Redefine custom class in terms of
7485         forward_scope_exit.
7486
7487 2019-01-23  Pedro Alves  <palves@redhat.com>
7488             Andrew Burgess  <andrew.burgess@embecosm.com>
7489
7490         * common/forward-scope-exit.h: New file.
7491
7492 2019-01-23  Pedro Alves  <palves@redhat.com>
7493             Andrew Burgess  <andrew.burgess@embecosm.com>
7494             Tom Tromey  <tom@tromey.com>
7495
7496         * common/scope-exit.h: New file.
7497
7498 2019-01-23  Pedro Alves  <palves@redhat.com>
7499
7500         * common/preprocessor.h (ESC): Rename to ...
7501         (ESC_PARENS): ... this.
7502         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7503         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7504
7505 2019-01-23  Tom Tromey  <tom@tromey.com>
7506
7507         * language.h (class scoped_switch_to_sym_language_if_auto):
7508         Initialize m_lang in both cases.
7509
7510 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7511
7512         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7513         with XCNEW.
7514
7515 2019-01-22  Tom Tromey  <tom@tromey.com>
7516
7517         * corelow.c: Do not include sys/file.h.
7518
7519 2019-01-22  Tom Tromey  <tom@tromey.com>
7520
7521         * tui/tui-wingeneral.h: Include gdb_curses.h.
7522
7523 2019-01-22  Tom Tromey  <tom@tromey.com>
7524
7525         * source-cache.h (class source_cache) <get_source_lines,
7526         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7527
7528 2019-01-22  Tom Tromey  <tom@tromey.com>
7529
7530         * remote-fileio.h (struct remote_target): Declare.
7531
7532 2019-01-22  Tom Tromey  <tom@tromey.com>
7533
7534         * python/py-arch.c: Do not include py-ref.h.
7535         * python/py-bpevent.c: Do not include py-ref.h.
7536         * python/py-cmd.c: Do not include py-ref.h.
7537         * python/py-continueevent.c: Do not include py-ref.h.
7538         * python/py-event.h: Do not include py-ref.h.
7539         * python/py-evtregistry.c: Do not include py-ref.h.
7540         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7541         * python/py-frame.c: Do not include py-ref.h.
7542         * python/py-framefilter.c: Do not include py-ref.h.
7543         * python/py-function.c: Do not include py-ref.h.
7544         * python/py-infevents.c: Do not include py-ref.h.
7545         * python/py-linetable.c: Do not include py-ref.h.
7546         * python/py-objfile.c: Do not include py-ref.h.
7547         * python/py-param.c: Do not include py-ref.h.
7548         * python/py-prettyprint.c: Do not include py-ref.h.
7549         * python/py-progspace.c: Do not include py-ref.h.
7550         * python/py-symbol.c: Do not include py-ref.h.
7551         * python/py-symtab.c: Do not include py-ref.h.
7552         * python/py-type.c: Do not include py-ref.h.
7553         * python/py-unwind.c: Do not include py-ref.h.
7554         * python/py-utils.c: Do not include py-ref.h.
7555         * python/py-value.c: Do not include py-ref.h.
7556         * python/py-varobj.c: Do not include py-ref.h.
7557         * python/py-xmethods.c: Do not include py-ref.h.
7558         * python/python.c: Do not include py-ref.h.
7559         * varobj.c: Do not include py-ref.h.
7560
7561 2019-01-22  Tom Tromey  <tom@tromey.com>
7562
7563         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7564         keyword for bcache.
7565
7566 2019-01-22  Tom Tromey  <tom@tromey.com>
7567
7568         * compile/compile-cplus-types.c: Remove a comment by #include.
7569
7570 2019-01-22  Tom Tromey  <tom@tromey.com>
7571
7572         * compile/gcc-c-plugin.h: Include compile-internal.h.
7573
7574 2019-01-22  Tom Tromey  <tom@tromey.com>
7575
7576         * stabsread.c (EXTERN): Do not define.
7577         (symnum, next_symbol_text_func, processing_gcc_compilation)
7578         (within_function, global_sym_chain, global_stabs)
7579         (previous_stab_code, this_object_header_files)
7580         (n_this_object_header_files)
7581         (n_allocated_this_object_header_files): Define.
7582         * stabsread.h (EXTERN): Never define.  Use "extern".
7583
7584 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7585
7586         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7587         history_value.
7588
7589 2019-01-21  Tom Tromey  <tom@tromey.com>
7590
7591         * ui-out.c: Fix includes.
7592         * tui/tui-source.c: Fix includes.
7593         * target.c: Fix includes.
7594         * remote.c: Fix includes.
7595         * regcache.c: Fix includes.
7596         * python/py-block.c: Fix includes.
7597         * printcmd.c: Fix includes.
7598         * or1k-tdep.c: Fix includes.
7599         * mi/mi-main.c: Fix includes.
7600         * m32r-tdep.c: Fix includes.
7601         * csky-tdep.c: Fix includes.
7602         * compile/compile-cplus-types.c: Fix includes.
7603         * cli/cli-interp.c: Fix includes.
7604
7605 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7606
7607         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7608         for padding.
7609
7610 2019-01-16  Tom Tromey  <tom@tromey.com>
7611
7612         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7613         earlier.
7614         (struct objfile) <msymbols_range>: Move from top level.
7615         <msymbols>: New method.
7616         (class objfile_msymbols): Remove.
7617         * symtab.c (default_collect_symbol_completion_matches_break_on):
7618         Update.
7619         * symmisc.c (dump_msymbols): Update.
7620         * stabsread.c (scan_file_globals): Update.
7621         * objc-lang.c (info_selectors_command, info_classes_command)
7622         (find_methods): Update.
7623         * minsyms.c (find_solib_trampoline_target): Update.
7624         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7625         * coffread.c (coff_symfile_read): Update.
7626         * ada-lang.c (ada_lookup_simple_minsym)
7627         (ada_collect_symbol_completion_matches): Update.
7628
7629 2019-01-16  Tom Tromey  <tom@tromey.com>
7630
7631         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7632         type.  Remove no-argument constructor.
7633         <iterator::operator++>: Simplify.
7634         <begin>: Update.
7635         <end>: Use minimal_symbol_count.
7636
7637 2019-01-16  Tom Tromey  <tom@tromey.com>
7638
7639         * objfiles.h (struct objfile) <psymtabs>: New method.
7640         (class objfile_psymtabs): Remove.
7641         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7642         typedef.
7643         <range>: New method.
7644         (require_partial_symbols): Change return type.
7645         * psymtab.c (require_partial_symbols)
7646         (psym_expand_symtabs_matching): Update.
7647         * mdebugread.c (parse_partial_symbols): Update.
7648         * dbxread.c (dbx_end_psymtab): Update.
7649
7650 2019-01-15  Tom Tromey  <tom@tromey.com>
7651
7652         * symtab.c (lookup_objfile_from_block)
7653         (lookup_symbol_in_objfile_symtabs)
7654         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7655         (find_line_symtab, info_sources_command)
7656         (default_collect_symbol_completion_matches_break_on)
7657         (make_source_files_completion_list): Update.
7658         * symmisc.c (print_objfile_statistics, dump_objfile)
7659         (maintenance_print_symbols, maintenance_info_symtabs)
7660         (maintenance_check_symtabs, maintenance_info_line_tables):
7661         Update.
7662         * source.c (select_source_symtab)
7663         (forget_cached_source_info_for_objfile): Update.
7664         * objfiles.h (class objfile_compunits): Remove.
7665         (struct objfile) <compunits_range>: New typedef.
7666         (compunits): New method.
7667         * objfiles.c (objfile_relocate1): Update.
7668         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7669         * maint.c (count_symtabs_and_blocks): Update.
7670         * linespec.c (iterate_over_all_matching_symtabs): Update.
7671         * cp-support.c (add_symbol_overload_list_qualified): Update.
7672         * coffread.c (coff_symtab_read): Update.
7673         * ada-lang.c (add_nonlocal_symbols)
7674         (ada_collect_symbol_completion_matches)
7675         (ada_add_global_exceptions): Update.
7676
7677 2019-01-15  Tom Tromey  <tom@tromey.com>
7678
7679         * progspace.h (program_space) <objfiles_safe_range>: New
7680         typedef.
7681         <objfiles_safe>: New method.
7682         * objfiles.h (class all_objfiles_safe): Remove.
7683         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7684         * jit.c (jit_inferior_exit_hook): Update.
7685
7686 2019-01-17  Tom Tromey  <tom@tromey.com>
7687
7688         * progspace.h (program_space) <objfiles_range>: New typedef.
7689         <objfiles>: New method.
7690         <objfiles_head>: Rename from objfiles.
7691         (object_files): Update.
7692         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7693         * guile/scm-pretty-print.c
7694         (ppscm_find_pretty_printer_from_objfiles): Update.
7695         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7696         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7697         Update.
7698         * python/py-progspace.c (pspy_get_objfiles): Update.
7699         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7700         Update.
7701         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7702         (objfpy_lookup_objfile_by_build_id): Update.
7703         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7704         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7705         Update.
7706         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7707         (expand_symtab_containing_pc, lookup_objfile_from_block)
7708         (lookup_static_symbol, basic_lookup_transparent_type)
7709         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7710         (find_line_symtab, info_sources_command)
7711         (default_collect_symbol_completion_matches_break_on)
7712         (make_source_files_completion_list, find_main_name): Update.
7713         * symmisc.c (print_symbol_bcache_statistics)
7714         (print_objfile_statistics, maintenance_print_symbols)
7715         (maintenance_print_msymbols, maintenance_print_objfiles)
7716         (maintenance_info_symtabs, maintenance_check_symtabs)
7717         (maintenance_expand_symtabs, maintenance_info_line_tables):
7718         Update.
7719         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7720         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7721         (map_overlay_command, unmap_overlay_command)
7722         (simple_overlay_update, expand_symtabs_matching)
7723         (map_symbol_filenames): Update.
7724         * symfile-debug.c (set_debug_symfile): Update.
7725         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7726         Update.
7727         * source.c (select_source_symtab, forget_cached_source_info):
7728         Update.
7729         * solib.c (solib_read_symbols): Update.
7730         * solib-spu.c (append_ocl_sos): Update.
7731         * psymtab.c (maintenance_print_psymbols)
7732         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7733         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7734         * printcmd.c (info_symbol_command): Update.
7735         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7736         Update.
7737         * objfiles.h (class all_objfiles): Remove.
7738         * objfiles.c (have_partial_symbols, have_full_symbols)
7739         (have_minimal_symbols, qsort_cmp, update_section_map)
7740         (shared_objfile_contains_address_p)
7741         (default_iterate_over_objfiles_in_search_order): Update.
7742         * objc-lang.c (info_selectors_command, info_classes_command)
7743         (find_methods): Update.
7744         * minsyms.c (find_solib_trampoline_target): Update.
7745         * maint.c (maintenance_info_sections)
7746         (maintenance_translate_address, count_symtabs_and_blocks):
7747         Update.
7748         * main.c (captured_main_1): Update.
7749         * linux-thread-db.c (try_thread_db_load_from_pdir)
7750         (has_libpthread): Update.
7751         * linespec.c (iterate_over_all_matching_symtabs)
7752         (search_minsyms_for_name): Update.
7753         * jit.c (jit_find_objf_with_entry_addr): Update.
7754         * hppa-tdep.c (find_unwind_entry)
7755         (hppa_lookup_stub_minimal_symbol): Update.
7756         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7757         Update.
7758         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7759         (elf_gnu_ifunc_resolve_by_got): Update.
7760         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7761         * dwarf-index-write.c (save_gdb_index_command): Update.
7762         * cp-support.c (add_symbol_overload_list_qualified): Update.
7763         * breakpoint.c (create_overlay_event_breakpoint)
7764         (create_longjmp_master_breakpoint)
7765         (create_std_terminate_master_breakpoint)
7766         (create_exception_master_breakpoint): Update.
7767         * blockframe.c (find_pc_partial_function): Update.
7768         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7769         (ada_collect_symbol_completion_matches)
7770         (ada_add_global_exceptions): Update.
7771
7772 2019-01-17  Tom Tromey  <tom@tromey.com>
7773
7774         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7775         declare VEC.
7776         (solib_target_parse_libraries): Change return type.
7777         (library_list_start_segment, library_list_start_section)
7778         (library_list_end_library, library_list_start_library); Update.
7779         (solib_target_free_library_list): Remove.
7780         (solib_target_parse_libraries): Remove cleanup.  Change return
7781         type.
7782         (solib_target_current_sos): Update.
7783
7784 2019-01-17  Tom Tromey  <tromey@bapiya>
7785
7786         * valprint.c: Replace "the the" with "the".
7787         * symtab.c: Replace "the the" with "the".
7788         * solib.c: Replace "the the" with "the".
7789         * solib-dsbt.c: Replace "the the" with "the".
7790         * linespec.c: Replace "the the" with "the".
7791         * dwarf2loc.h: Replace "the the" with "the".
7792         * amd64-windows-tdep.c: Replace "the the" with "the".
7793         * aarch64-tdep.c: Replace "the the" with "the".
7794
7795 2019-01-16  Keith Seitz  <keiths@redhat.com>
7796
7797         PR gdb/23773
7798         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7799         <builder>: Rename to ..
7800         <m_builder>: ... this and make private.
7801         (dwarf2_cu::get_builder): New method.  Change all users of
7802         `builder' to use this method.
7803         (dwarf2_start_symtab): Move to ...
7804         (dwarf2_cu::start_symtab): ... here.  Update all callers
7805         (setup_type_unit_groups): Move to ...
7806         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7807         callers.
7808         (dwarf2_cu::reset_builder): New method.
7809         (process_full_compunit, process_full_type_unit): Use
7810         dwarf2_cu::reset_builder.
7811         (follow_die_offset): Record the ancestor CU if it is different
7812         from the followed DIE's CU.
7813         (follow_die_sig_1): Likewise.
7814
7815 2019-01-15  Tom Tromey  <tom@tromey.com>
7816
7817         * remote.c (class remote_state) <buf>: Now a char_vector.
7818         <buf_size>: Remove.
7819         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7820         parameter.
7821         (remote_target::getpkt_or_notif_sane_1)
7822         (remote_target::getpkt_sane)
7823         (remote_target::getpkt_or_notif_sane): Likewise.
7824         (class remote_target) <putpkt>: New overload.
7825         (remote_target::read_frame): Change type of "buf_p".  Remove
7826         sizeof_p parameter.
7827         (packet_ok): New overload.
7828         (packet_check_result): New overload.
7829         Update all uses.
7830
7831 2019-01-14  Tom Tromey  <tom@tromey.com>
7832
7833         * remote-notif.c (handle_notification, remote_notif_ack)
7834         (remote_notif_parse): Make "buf" const.
7835         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7836         const.
7837         (remote_notif_parse, remote_notif_ack, handle_notification):
7838         Likewise.
7839         * remote.c (remote_notif_stop_parse): Make "buf" const.
7840         (remote_target::remote_parse_stop_reply): Make "buf" const.
7841         (remote_notif_stop_ack): Make "buf" const.
7842
7843 2019-01-14  Tom Tromey  <tom@tromey.com>
7844
7845         * remote.c (remote_console_output): Make parameter const.
7846
7847 2019-01-14  Tom Tromey  <tom@tromey.com>
7848
7849         * target-debug.h (target_debug_print_signals): Constify.
7850         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7851         * procfs.c (procfs_target::pass_signals): Update.
7852         * linux-nat.c (linux_nat_target::pass_signals): Update.
7853         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7854         * target-delegates.c: Rebuild.
7855         * remote.c (remote_target::program_signals): Update.
7856         (remote_target::pass_signals): Update.
7857         * target.c (target_pass_signals): Constify argument.
7858         (target_program_signals): Likewise.
7859         * target.h (struct target_ops) <pass_signals, program_signals>:
7860         Constify argument.
7861         (target_pass_signals, target_program_signals): Constify argument.
7862
7863 2019-01-14  Tom Tromey  <tom@tromey.com>
7864
7865         PR tui/28819:
7866         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7867
7868 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7869
7870         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7871         field.
7872         * rs6000-tdep.c: Include reggroups.h.
7873         (IS_V_ALIAS_PSEUDOREG): Define.
7874         (rs6000_register_name): Return names for the "vX" aliases.
7875         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7876         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7877         aliases.  Call default_register_reggroup_p for all other
7878         pseudo-registers.
7879         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7880         New functions.
7881         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7882         Handle "vX" aliases.
7883         (v_alias_pseudo_register_collect): New function.
7884         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7885         (rs6000_gdbarch_init): Initialize "vX" aliases as
7886         pseudo-registers.  Restore registration of
7887         rs6000_pseudo_register_reggroup_p with
7888         set_tdesc_pseudo_register_reggroup_p.
7889
7890 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7891
7892         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7893         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7894         set_gdbarch_num_pseudo_regs.
7895
7896 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7897
7898         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7899         Remove arg prefixname, add do_set and do_show.
7900         Add member functions set_list and show_list.
7901         * cli/cli-style.c (class cli_style_option): Update accordingly.
7902         (style_set_list): Move to file scope.
7903         (style_show_list): Likewise.
7904         (set_style): Call help_list.
7905         (show_style): Call cmd_show_list.
7906         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7907         Update to use the new macro.
7908
7909 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7910
7911         * ada-lang.c (_initialize_ada_language): Expand the help text
7912         for the "catch exception" command.
7913
7914 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7915
7916         * symtab.c (matching_obj_sections): Initialize obj,
7917         declare it closer to its usage.
7918
7919 2019-01-10  Tom Tromey  <tom@tromey.com>
7920
7921         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7922         (basic_inf_threads_range): Remove.
7923         (inf_threads_range, inf_non_exited_threads_range)
7924         (safe_inf_threads_range): Use next_adapter.
7925
7926 2019-01-10  Keith Seitz  <keiths@redhat.com>
7927
7928         PR gdb/23712
7929         PR symtab/23010
7930         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7931         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7932
7933 2019-01-10  Keith Seitz  <keiths@redhat.com>
7934
7935         PR gdb/23712
7936         PR symtab/23010
7937         * dictionary.c (pending_to_vector): Remove.
7938         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7939         Remove _1 suffix, replacing functions of the same name.  Update
7940         all callers.
7941         (dict_create_hashed, dict_create_hashed_expandable)
7942         (dict_create_linear, dict_create_linear_expandable, dict_free)
7943         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7944         Make functions static.
7945
7946 2019-01-10  Keith Seitz  <keiths@redhat.com>
7947
7948         PR gdb/23712
7949         PR symtab/23010
7950         * dictionary.h (struct dictionary): Replace declaration with
7951         multidictionary.
7952         (dict_create_hashed, dict_create_hashed_expandable)
7953         (dict_create_linear, dict_create_linear_expandable)
7954         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7955         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7956         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7957         taking multidictionary argument.
7958         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7959         * block.h (struct block) <dict>: Change to multidictionary
7960         and rename `multidict'.
7961         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7962         symmisc.c: Update all dictionary references to multidictionary.
7963
7964 2019-01-10  Keith Seitz  <keiths@redhat.com>
7965
7966         PR gdb/23712
7967         PR symtab/23010
7968         * dictionary.c: Include unordered_map.
7969         (pending_to_vector): New function.
7970         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7971         Rewrite the non-"_1" functions to take vector instead
7972         of linked list.
7973         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7974         "new" _1 versions of the same name.
7975         (multidictionary): Define.
7976         (std::hash<enum language): New definition.
7977         (collate_pending_symbols_by_language, mdict_create_hashed)
7978         (mdict_create_hashed_expandable, mdict_create_linear)
7979         (mdict_create_linear_expandable, mdict_free)
7980         (find_language_dictionary, create_new_language_dictionary)
7981         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7982         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7983         (mdict_size, mdict_empty): New functions.
7984         * dictionary.h (mdict_iterator): Define.
7985
7986 2019-01-10  Pedro Alves  <palves@redhat.com>
7987
7988         * breakpoint.c (read_uploaded_action)
7989         (create_tracepoint_from_upload): Adjust to use
7990         gdb::unique_xmalloc_ptr.
7991         * ctf.c (ctf_write_uploaded_tp):
7992         (SET_ARRAY_FIELD): Use emplace_back.
7993         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7994         * tracefile-tfile.c (tfile_write_uploaded_tp):
7995         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7996         gdb::unique_xmalloc_ptr.
7997         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7998         at_string, cond_string, cmd_strings>: Replace char pointers
7999         with gdb::unique_xmalloc_ptr.
8000
8001 2019-01-10  Pedro Alves  <palves@redhat.com>
8002
8003         * solib-target.c (library_list_start_library): Don't xstrdup name.
8004
8005 2019-01-10  Pedro Alves  <palves@redhat.com>
8006
8007         * mdebugread.c (parse_partial_symbols): Use
8008         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8009
8010 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8011
8012         * linux-fork.c (scoped_switch_fork_info)
8013         <~scoped_switch_fork_info>: Fix incorrect variable name.
8014
8015 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8016
8017         * linux-fork.c (scoped_switch_fork_info)
8018         <scoped_switch_fork_info>: Make explicit.
8019         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8020
8021 2019-01-10  Tom Tromey  <tom@tromey.com>
8022
8023         * objfiles.h (objfile::reset_psymtabs): Update.
8024         * objfiles.c (objfile::objfile): Update.
8025         * psymtab.h (psymtab_storage::obstack): Update.
8026         (psymtab_storage::m_obstack): Use gdb::optional.
8027         (class psymtab_storage): Update comment.  Remove objfile
8028         parameter.
8029         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8030
8031 2019-01-10  Tom Tromey  <tom@tromey.com>
8032
8033         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8034         <free_psymtabs>: Now private.
8035         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8036         (allocate_psymtab): Use new method.
8037
8038 2019-01-10  Tom Tromey  <tom@tromey.com>
8039
8040         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8041         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8042         * mdebugread.c (parse_partial_symbols): Use
8043         allocate_dependencies.
8044         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8045         allocate_dependencies.
8046         (process_psymtab_comp_unit_reader)
8047         (build_type_psymtab_dependencies): Likewise.
8048         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8049
8050 2019-01-10  Tom Tromey  <tom@tromey.com>
8051
8052         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8053         PSYMBOL_SET_LANGUAGE.
8054         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8055
8056 2019-01-10  Tom Tromey  <tom@tromey.com>
8057
8058         * psymtab.h (psymtab_storage::obstack): New method.
8059         <m_obstack>: Rename from obstack; now private.
8060         * psymtab.c (psymtab_storage): Update.
8061         * dwarf2read.c (create_addrmap_from_index)
8062         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8063         Update.
8064
8065 2019-01-10  Tom Tromey  <tom@tromey.com>
8066
8067         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8068         * objfiles.h (objfile::reset_psymtabs): New method.
8069
8070 2019-01-10  Tom Tromey  <tom@tromey.com>
8071
8072         * symmisc.c (print_symbol_bcache_statistics): Update.
8073         (print_objfile_statistics): Update.
8074         * symfile.c (reread_symbols): Update.
8075         * psymtab.h (class psymtab_storage): New.
8076         * psymtab.c (psymtab_storage): New constructor.
8077         (~psymtab_storage): New destructor.
8078         (require_partial_symbols): Update.
8079         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8080         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8081         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8082         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8083         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8084         (start_psymtab_common, end_psymtab_common)
8085         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8086         (allocate_psymtab): Update.
8087         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8088         Update.
8089         (dump_psymtab_addrmap, maintenance_print_psymbols)
8090         (maintenance_check_psymtabs): Update.
8091         (class objfile_psymtabs): Move to objfiles.h.
8092         * psympriv.h (discard_psymtab): Now inline.
8093         (psymtab_discarder::psymtab_discarder): Update.
8094         (psymtab_discarder::~psymtab_discarder): Update.
8095         (ALL_OBJFILE_PSYMTABS): Rewrite.
8096         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8097         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8098         Remove fields.
8099         <partial_symtabs>: New field.
8100         (class objfile_psymtabs): Move from psymtab.h.  Update.
8101         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8102         psymbol_cache.
8103         (objfile::~objfile): Don't destroy psymbol_cache.
8104         * mdebugread.c (parse_partial_symbols): Update.
8105         * dwarf2read.c (create_addrmap_from_index)
8106         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8107         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8108         (add_partial_subprogram, dwarf2_ranges_read): Update.
8109         * dwarf-index-write.c (write_address_map)
8110         (write_one_signatured_type, recursively_write_psymbols)
8111         (class debug_names, class debug_names, write_psymtabs_to_index):
8112         Update.
8113
8114 2019-01-10  Tom Tromey  <tom@tromey.com>
8115
8116         * symtab.h (SYMBOL_SET_NAMES): Update.
8117         (symbol_set_names): Update.
8118         (MSYMBOL_SET_NAMES): Update.
8119         * symtab.c (symbol_set_names): Change argument to be an
8120         objfile_per_bfd_storage.
8121         * psymtab.c (add_psymbol_to_bcache): Update.
8122         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8123
8124 2019-01-10  Tom Tromey  <tom@tromey.com>
8125
8126         * symtab.c (create_demangled_names_hash): Change argument to be an
8127         objfile_per_bfd_storage.
8128         (symbol_set_names): Update.
8129
8130 2019-01-10  Tom Tromey  <tom@tromey.com>
8131
8132         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8133         init_psymbol_list.
8134         * psymtab.c (init_psymbol_list): Do nothing if already called.
8135         * psympriv.h (init_psymbol_list): Add comment.
8136         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8137         init_psymbol_list.
8138         * dbxread.c (dbx_symfile_read): Unconditionally call
8139         init_psymbol_list.
8140
8141 2019-01-10  Tom Tromey  <tom@tromey.com>
8142
8143         * xcoffread.c (scan_xcoff_symtab): Update.
8144         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8145         "where".
8146         * mdebugread.c (parse_partial_symbols)
8147         (handle_psymbol_enumerators): Update.
8148         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8149         * dbxread.c (read_dbx_symtab): Update.
8150         * psympriv.h (psymbol_placement): New enum.
8151         (add_psymbol_to_list): Update.
8152
8153 2019-01-10  Tom Tromey  <tom@tromey.com>
8154
8155         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8156         static_psymbols parameters.
8157         (scan_xcoff_symtab): Update.
8158         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8159         static_psymbols parameters.
8160         * psympriv.h (start_psymtab_common): Update.
8161         * mdebugread.c (parse_partial_symbols): Update.
8162         * dwarf2read.c (create_partial_symtab): Update.
8163         * dbxread.c (read_dbx_symtab): Update.
8164         (start_psymtab): Remove global_psymbols and static_psymbols
8165         parameters.
8166
8167 2019-01-10  Tom Tromey  <tom@tromey.com>
8168
8169         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8170         * psymtab.c (allocate_psymtab): Add comment.
8171         * psympriv.h (allocate_psymtab): Add comment.
8172         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8173         initializations.
8174         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8175
8176 2019-01-10  Tom Tromey  <tom@tromey.com>
8177
8178         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8179         Don't declare.
8180         * mipsread.c: Include mdebugread.h.
8181         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8182         Declare.
8183         * elfread.c: Include mdebugread.h.
8184
8185 2019-01-09  Tom Tromey  <tom@tromey.com>
8186
8187         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8188         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8189         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8190         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8191         (psym_lookup_symbol, psym_find_last_source_symtab)
8192         (psym_forget_cached_source_info, psym_print_stats)
8193         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8194         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8195         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8196         (psym_find_compunit_symtab_by_address)
8197         (maintenance_print_psymbols, maintenance_info_psymtabs)
8198         (maintenance_check_psymtabs): Use ranged for.
8199         * psymtab.h (class objfile_psymtabs): New.
8200         (require_partial_symbols): Return objfile_psymtabs.
8201         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8202
8203 2019-01-09  Tom Tromey  <tom@tromey.com>
8204
8205         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8206         (find_pc_mapped_section, list_overlays_command)
8207         (map_overlay_command, unmap_overlay_command)
8208         (simple_overlay_update): Use all_objfiles.
8209         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8210         * printcmd.c (info_symbol_command): Use all_objfiles.
8211         * objfiles.h (ALL_OBJSECTIONS): Remove.
8212         * maint.c (maintenance_translate_address): Use all_objfiles.
8213         * gcore.c (gcore_create_callback): Use all_objfiles.
8214         (objfile_find_memory_regions): Likewise.
8215
8216 2019-01-09  Tom Tromey  <tom@tromey.com>
8217
8218         * symtab.c (find_line_symtab, info_sources_command)
8219         (make_source_files_completion_list): Use objfile_compunits.
8220         * source.c (select_source_symtab): Use objfile_compunits.
8221         * objfiles.h (struct objfile): Update comment.
8222         (ALL_OBJFILES): Remove.
8223         (ALL_FILETABS): Remove.
8224         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8225         objfile_compunits.
8226
8227 2019-01-09  Tom Tromey  <tom@tromey.com>
8228
8229         * symmisc.c (print_objfile_statistics, dump_objfile)
8230         (maintenance_print_symbols): Use compunit_filetabs.
8231         * source.c (forget_cached_source_info_for_objfile): Use
8232         compunit_filetabs.
8233         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8234         (ALL_FILETABS): Use compunit_filetabs.
8235         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8236         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8237
8238 2019-01-09  Tom Tromey  <tom@tromey.com>
8239
8240         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8241         (compunit_filetabs): New.
8242         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8243         compunit_filetabs.
8244         (info_sources_command, make_source_files_completion_list): Remove
8245         declaration.
8246         * symmisc.c (print_objfile_statistics, dump_objfile)
8247         (maintenance_print_symbols): Remove declaration.
8248         (maintenance_info_symtabs): Use compunit_filetabs.
8249         (maintenance_info_line_tables): Likewise.
8250         * source.c (select_source_symtab): Change local variable name.
8251         (forget_cached_source_info_for_objfile): Remove declaration.
8252         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8253         * objfiles.c (objfile_relocate1): Remove declaration.
8254         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8255         declaration.
8256         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8257         * coffread.c (coff_symtab_read): Remove declaration.
8258         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8259         compunit_filetabs.
8260
8261 2019-01-09  Tom Tromey  <tom@tromey.com>
8262
8263         * symtab.c (lookup_objfile_from_block)
8264         (find_pc_sect_compunit_symtab, search_symbols)
8265         (default_collect_symbol_completion_matches_break_on): Use
8266         objfile_compunits.
8267         * objfiles.h (ALL_COMPUNITS): Remove.
8268         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8269         * cp-support.c (add_symbol_overload_list_qualified): Use
8270         objfile_compunits.
8271         * ada-lang.c (ada_collect_symbol_completion_matches)
8272         (ada_add_global_exceptions): Use objfile_compunits.
8273
8274 2019-01-09  Tom Tromey  <tom@tromey.com>
8275
8276         * source.c (select_source_symtab)
8277         (forget_cached_source_info_for_objfile): Remove declaration.
8278         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8279         declaration.
8280         * maint.c (count_symtabs_and_blocks): Remove declaration.
8281         * cp-support.c (add_symbol_overload_list_qualified): Remove
8282         declaration.
8283         * coffread.c (coff_symtab_read): Remove declaration.
8284         * symtab.c (lookup_symbol_in_objfile_symtabs)
8285         (basic_lookup_transparent_type_1): Use objfile_compunits.
8286         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8287         (info_sources_command, search_symbols)
8288         (default_collect_symbol_completion_matches_break_on)
8289         (make_source_files_completion_list): Remove declaration.
8290         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8291         (ada_collect_symbol_completion_matches)
8292         (ada_add_global_exceptions): Remove declaration.
8293         * linespec.c (iterate_over_all_matching_symtabs): Use
8294         objfile_compunits.
8295         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8296         (class objfile_compunits): New.
8297         (ALL_COMPUNITS): Use objfile_compunits.
8298         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8299         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8300         objfile_compunits.
8301         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8302
8303 2019-01-09  Tom Tromey  <tom@tromey.com>
8304
8305         * symtab.c (search_symbols)
8306         (default_collect_symbol_completion_matches_break_on): Use
8307         objfile_msymbols.
8308         * ada-lang.c (ada_lookup_simple_minsym)
8309         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8310         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8311         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8312         objfile_msymbols.
8313         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8314         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8315         * objc-lang.c (find_methods): Use objfile_msymbols.
8316         (info_selectors_command, info_classes_command): Likewise.
8317         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8318         * objfiles.h (class objfile_msymbols): New.
8319         (ALL_OBJFILE_MSYMBOLS): Remove.
8320         (ALL_MSYMBOLS): Remove.
8321
8322 2019-01-09  Tom Tromey  <tom@tromey.com>
8323
8324         * common/next-iterator.h (next_adapter): Add Iterator template
8325         parameter.
8326         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8327         (class all_objfiles_safe): New.
8328         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8329         * objfiles.c (put_objfile_before): Update comment.
8330         (add_separate_debug_objfile): Likewise.
8331         (free_all_objfiles): Use all_objfiles_safe.
8332         (objfile_purge_solibs): Likewise.
8333
8334 2019-01-09  Tom Tromey  <tom@tromey.com>
8335
8336         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8337         (expand_symtab_containing_pc, lookup_static_symbol)
8338         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8339         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8340         all_objfiles.
8341         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8342         * breakpoint.c (create_overlay_event_breakpoint)
8343         (create_longjmp_master_breakpoint)
8344         (create_std_terminate_master_breakpoint)
8345         (create_exception_master_breakpoint): Use all_objfiles.
8346         * linux-thread-db.c (try_thread_db_load_from_pdir)
8347         (has_libpthread): Use all_objfiles.
8348         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8349         * linespec.c (iterate_over_all_matching_symtabs)
8350         (search_minsyms_for_name): Use all_objfiles.
8351         * maint.c (maintenance_info_sections): Use all_objfiles.
8352         * main.c (captured_main_1): Use all_objfiles.
8353         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8354         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8355         * guile/scm-pretty-print.c
8356         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8357         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8358         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8359         (maintenance_print_msymbols): Use all_objfiles.
8360         * source.c (select_source_symtab): Use all_objfiles.
8361         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8362         * symfile.c (remove_symbol_file_command)
8363         (expand_symtabs_matching, map_symbol_filenames): Use
8364         all_objfiles.
8365         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8366         all_objfiles.
8367         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8368         * objc-lang.c (find_methods): Use all_objfiles.
8369         * objfiles.c (have_partial_symbols, have_full_symbols)
8370         (have_minimal_symbols, qsort_cmp)
8371         (default_iterate_over_objfiles_in_search_order): Use
8372         all_objfiles.
8373         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8374         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8375         (maintenance_check_psymtabs): Use all_objfiles.
8376         (ALL_PSYMTABS): Remove.
8377         * compile/compile-object-run.c (do_module_cleanup): Use
8378         all_objfiles.
8379         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8380         * cp-support.c (add_symbol_overload_list_qualified): Use
8381         all_objfiles.
8382         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8383         Use all_objfiles.
8384         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8385         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8386         all_objfiles.
8387         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8388         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8389         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8390         Uses all_objfiles.
8391         * solib.c (solib_read_symbols): Use all_objfiles
8392
8393 2019-01-09  Tom Tromey  <tom@tromey.com>
8394
8395         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8396         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8397         all_objfiles.
8398         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8399         * symmisc.c (print_symbol_bcache_statistics)
8400         (print_objfile_statistics, maintenance_print_objfiles)
8401         (maintenance_info_symtabs, maintenance_check_symtabs)
8402         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8403         all_objfiles.
8404         * source.c (forget_cached_source_info): Use all_objfiles.
8405         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8406         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8407         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8408         * objfiles.c (update_section_map): Use all_objfiles.
8409         (shared_objfile_contains_address_p): Likewise.
8410         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8411         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8412
8413 2019-01-09  Tom Tromey  <tom@tromey.com>
8414
8415         * common/next-iterator.h: New file.
8416         * objfiles.h (class all_objfiles): New.
8417         (struct objfile_iterator): New.
8418
8419 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8420
8421         * NEWS: Move the description of the changed "frame", "select-frame",
8422          and "info frame" commands to the Changed commands section.
8423
8424 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8425
8426         * gdbtypes.c (check_stub_method_group): Remove handling of old
8427         mangling schemes.
8428         * linespec.c (find_methods): Likewise.
8429         * stabsread.c (read_member_functions): Likewise.
8430         * valops.c (search_struct_method): Likewise.
8431         (value_struct_elt_for_reference): Likewise.
8432         * NEWS: Mention this change.
8433
8434 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8435
8436         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8437         print_source_lines.
8438         * source.c (print_source_lines_base): Update line number check.
8439         (print_source_lines): New function.
8440         (source_lines_range::source_lines_range): New function.
8441         * source.h (class source_lines_range): New class.
8442         (print_source_lines): New declaration.
8443
8444 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8445
8446         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8447
8448 2019-01-08  Tom Tromey  <tom@tromey.com>
8449             Simon Marchi  <simon.marchi@ericsson.com>
8450
8451         PR gdb/24060
8452         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8453         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8454         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8455         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8456         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8457         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8458
8459 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8460
8461         * source.c (select_source_symtab): Move header comment to
8462         declaration in source.h.
8463         (forget_cached_source_info_for_objfile): Likewise.
8464         (forget_cached_source_info): Likewise.
8465         (identify_source_line): Likewise.
8466         * source.h (identify_source_line): Move declaration from symtab.h
8467         and add comment from source.c
8468         (print_source_lines): Likewise.
8469         (forget_cached_source_info_for_objfile): Likewise.
8470         (forget_cached_source_info): Likewise.
8471         (select_source_symtab): Likewise.
8472         (enum print_source_lines_flag): Move definition from symtab.h.
8473         * symtab.h (identify_source_line): Move declaration to source.h.
8474         (print_source_lines): Likewise.
8475         (forget_cached_source_info_for_objfile): Likewise.
8476         (forget_cached_source_info): Likewise.
8477         (select_source_symtab): Likewise.
8478         (enum print_source_lines_flag): Move definition to source.h.
8479         * tui/tui-hooks.c: Add 'source.h' include.
8480
8481 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8482
8483         * source.c (print_source_lines_base): Handle requests to print
8484         reverse line number sequences, and guard against empty lines
8485         string.
8486
8487 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8488
8489         * source.c (print_source_lines_base): Fix skip of '\r' if next
8490         character is '\n'.
8491
8492 2019-01-06  Tom Tromey  <tom@tromey.com>
8493
8494         * c-exp.y (struct c_parse_state) <macro_original_text,
8495         expansion_obstack>: New member.
8496         (macro_original_text, expansion_obstack): Remove globals.
8497         (scan_macro_expansion, scanning_macro_expansion)
8498         (finished_macro_expansion): Update.
8499         (scan_macro_cleanup): Remove.
8500         (yylex, c_parse): Update.
8501
8502 2019-01-06  Tom Tromey  <tom@tromey.com>
8503
8504         * c-exp.y (struct c_parse_state) <strings>: New member.
8505         (operator_stoken): Update.
8506
8507 2019-01-06  Tom Tromey  <tom@tromey.com>
8508
8509         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8510         (union type_stack_elt) <typelist_val>: Now a pointer to
8511         std::vector.
8512         (type_stack_cleanup): Don't declare.
8513         (push_typelist): Update.
8514         * parse.c (pop_typelist): Return a std::vector.
8515         (push_typelist): Take a std::vector.
8516         (follow_types): Update.  Do not free args.
8517         (type_stack_cleanup): Remove.
8518         * c-exp.y (struct c_parse_state): New.
8519         (cpstate): New global.
8520         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8521         (nonempty_typelist): Update.
8522         (func_mod): Create a new vector.
8523         (c_parse): Create a c_parse_state.
8524         (check_parameter_typelist): Do not delete params.
8525         (function_method): Update.  Do not delete type_list.
8526
8527 2019-01-06  Tom Tromey  <tom@tromey.com>
8528
8529         PR gdb/28155:
8530         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8531         check_typedef.
8532         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8533         (print_return_value): Likewise.
8534
8535 2019-01-05  Tom Tromey  <tom@tromey.com>
8536
8537         * contrib/cleanup_check.py: Remove.
8538         * contrib/gcc-with-excheck: Remove.
8539         * contrib/exsummary.py: Remove.
8540         * contrib/excheck.py: Remove.
8541
8542 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8543
8544         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8545         NULL. Initialize tpprev to NULL instead of assigning it
8546         to NULL on the next statement.
8547         * windows-nat.c (windows_delete_thread): Remove check for
8548         main_thread_id before printing thread exit notifications.
8549         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8550         Remove thread ID check against main_thread_id.
8551         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8552         windows_delete_thread.
8553         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8554
8555 2019-01-04  Tom Tromey  <tom@tromey.com>
8556
8557         * compile/compile.c (_initialize_compile): Use upper case for
8558         metasyntactic variables.
8559         * symmisc.c (_initialize_symmisc): Use upper case for
8560         metasyntactic variables.
8561         * psymtab.c (_initialize_psymtab): Use upper case for
8562         metasyntactic variables.
8563         * demangle.c (demangle_command): Use upper case for metasyntactic
8564         variables.
8565         (_initialize_demangler): Likewise.
8566         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8567         variables.
8568
8569 2019-01-03  Tom Tromey  <tom@tromey.com>
8570
8571         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8572
8573 2019-01-03  Tom Tromey  <tom@tromey.com>
8574
8575         * python/py-symtab.c (salpy_str): Update.
8576         (struct salpy_sal_object) <symtab>: Now a PyObject.
8577         (salpy_dealloc): Update.
8578         (del_objfile_sal): Use gdbpy_ref.
8579
8580 2019-01-03  Tom Tromey  <tom@tromey.com>
8581
8582         * python/py-type.c (convert_field): Use new_reference.  Return
8583         gdbpy_ref.
8584         (make_fielditem): Return gdbpy_ref.
8585         (typy_fields): Update.
8586         (typy_getitem): Update.
8587         (field_name): Return gdbpy_ref.  Use new_reference.
8588         (typy_iterator_iternext): Update.
8589
8590 2019-01-03  Tom Tromey  <tom@tromey.com>
8591
8592         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8593
8594 2019-01-03  Tom Tromey  <tom@tromey.com>
8595
8596         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8597         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8598         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8599         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8600         (pspy_set_type_printers): Likewise.
8601         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8602         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8603         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8604         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8605         (objfpy_set_type_printers): Likewise.
8606
8607 2019-01-03  Tom Tromey  <tom@tromey.com>
8608
8609         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8610         (gdbpy_print_stack): Use gdbpy_err_fetch.
8611         * python/python-internal.h (class gdbpy_err_fetch): New class.
8612         (class gdbpy_enter) <m_error_type, m_error_value,
8613         m_error_traceback>: Remove.
8614         <m_error>: New member.
8615         (gdbpy_exception_to_string): Don't declare.
8616         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8617         * python/py-value.c (convert_value_from_python): Use
8618         gdbpy_err_fetch.
8619         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8620         gdbpy_exception_to_string.
8621         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8622         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8623         gdbpy_err_fetch.
8624
8625 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8626
8627         * linux-nat.c (delete_lwp_cleanup): Delete.
8628         (struct lwp_deleter): New struct.
8629         (lwp_info_up): New typedef.
8630         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8631         lwp_info_up.
8632
8633 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8634
8635         * linux-fork.c (class scoped_switch_fork_info): New class.
8636         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8637
8638 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8639
8640         * valops.c (find_overload_match): Remove use of null_cleanup, and
8641         calls to do_cleanups.
8642
8643 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8644
8645         * compile/compile-cplus-types.c
8646         (compile_cplus_instance::decl_name): Handle changes to
8647         cp_func_name.
8648         * cp-support.c (cp_func_name): Update header comment, update
8649         return type.
8650         * cp-support.h (cp_func_name): Update return type in declaration.
8651         * valops.c (find_overload_match): Move temp_func local to top
8652         level of function and change its type.  Use temp_func to hold and
8653         delete temporary string obtained from cp_func_name.
8654
8655 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8656
8657         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8658         gdb::char_vector, remove cleanup, and update uses of `msg`.
8659
8660 2019-01-03  Jim Wilson  <jimw@sifive.com>
8661
8662         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8663
8664 2019-01-02  Tom Tromey  <tom@tromey.com>
8665
8666         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8667         (tdesc_parse_xml): Remove cleanups.
8668         * target-descriptions.h (make_cleanup_free_target_description):
8669         Don't declare.
8670         (target_desc_deleter): New struct.
8671         (target_desc_up): New typedef.
8672         * target-descriptions.c (target_desc_deleter::operator()): Rename
8673         from free_target_description.
8674         (make_cleanup_free_target_description): Remove.
8675
8676 2019-01-02  Tom Tromey  <tom@tromey.com>
8677
8678         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8679         constructor, destructor.
8680         (linespec_parser): Remove typedef.
8681         (~linespec_parser): Rename from linespec_parser_delete.
8682         (linespec_lex_to_end, linespec_complete_label)
8683         (linespec_complete): Update.
8684         (decode_line_full): Remove cleanups.
8685         (decode_line_1): Update.
8686
8687 2019-01-02  Tom Tromey  <tom@tromey.com>
8688
8689         * python/python-internal.h (inferior_to_inferior_object): Change
8690         return type.
8691         * python/py-exitedevent.c (create_exited_event_object): Update.
8692         * python/py-inferior.c (inferior_to_inferior_object): Return
8693         gdbpy_ref.
8694         (python_new_inferior, python_inferior_deleted)
8695         (thread_to_thread_object, delete_thread_object)
8696         (build_inferior_list, gdbpy_selected_inferior): Update.
8697         * python/py-infthread.c (create_thread_object): Update.  Also fail
8698         if inferior_to_inferior_object fails.
8699
8700 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8701
8702         * inferior.h (class inferior) <displaced_step_state>: New field.
8703         * infrun.h (struct displaced_step_state): Move here from
8704         infrun.c.  Initialize fields, add constructor.
8705         <inf>: Remove field.
8706         <reset>: New method.
8707         * infrun.c (struct displaced_step_inferior_state): Move to
8708         infrun.h.
8709         (displaced_step_inferior_states): Remove.
8710         (get_displaced_stepping_state): Adust.
8711         (displaced_step_in_progress_any_inferior): Adjust.
8712         (displaced_step_in_progress_thread): Adjust.
8713         (displaced_step_in_progress): Adjust.
8714         (add_displaced_stepping_state): Remove.
8715         (get_displaced_step_closure_by_addr): Adjust.
8716         (remove_displaced_stepping_state): Remove.
8717         (infrun_inferior_exit): Call displaced_step_state.reset.
8718         (use_displaced_stepping): Don't check for NULL.
8719         (displaced_step_prepare_throw): Call
8720         get_displaced_stepping_state.
8721         (displaced_step_fixup): Don't check for NULL.
8722         (prepare_for_detach): Don't check for NULL.
8723
8724 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8725
8726         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8727          in case of call that did not complete.
8728
8729 2019-01-02  Andrey Utkin  <autkin@undo.io>
8730
8731         * symfile.c (find_separate_debug_file): Fix search of debug files for
8732         remote debuggee.
8733
8734 2019-01-02  Tom Tromey  <tom@tromey.com>
8735
8736         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8737         indentation.
8738         * python/py-frame.c (frapy_older): Remove cast.
8739         (frapy_newer): Likewise.
8740         * python/py-breakpoint.c (local_setattro): Remove cast.
8741         * python/py-arch.c (archpy_name): Remove local variable.
8742         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8743
8744 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8745
8746         * unittests/basic_string_view/element_access/char/empty.cc:
8747         Fix year range in copyright header.
8748
8749 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8750
8751         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8752         Delete.
8753         <operator==>: Update with for removed field.
8754         <hash>: Likewise.
8755         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8756         <isa_features>: ...this.
8757         <abi_features>: New field.
8758         (riscv_isa_flen): Update comment.
8759         (riscv_abi_xlen): New declaration.
8760         (riscv_abi_flen): New declaration.
8761         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8762         isa_features.
8763         (riscv_abi_xlen): New function.
8764         (riscv_isa_flen): Update to get answer from isa_features.
8765         (riscv_abi_flen): New function.
8766         (riscv_has_fp_abi): Update to get answer from abi_features.
8767         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8768         xlen and flen.
8769         (riscv_call_info) <xlen, flen>: Update comment.
8770         (riscv_call_arg_struct): Remove invalid assertions
8771         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8772         is removed.
8773         (riscv_gdbarch_init): Gather isa features and abi features
8774         separately, ensure both match on the gdbarch when reusing an old
8775         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8776         a target with 64-bit float hardware.
8777
8778 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8779
8780         * source.c (search_command_helper): Stop reverse search
8781         when line 1 has been searched.
8782
8783 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8784
8785         * record-full.c (record_full_base_target::close): Rewrite
8786         record_full_core_buf_list free logic.
8787
8788 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8789
8790         * break-catch-syscall.c (print_one_catch_syscall): xfree
8791         the last text.
8792
8793 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8794
8795         * top.c (print_gdb_version): Update Copyright year in version
8796         message.
8797
8798 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8799
8800         Update copyright year range in all GDB files.
8801
8802 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8803
8804         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8805
8806 For older changes see ChangeLog-2018.
8807 \f
8808 Local Variables:
8809 mode: change-log
8810 left-margin: 8
8811 fill-column: 74
8812 version-control: never
8813 coding: utf-8
8814 End:
8815