gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
   4         condition.
   5         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
   6         Remove condition.
   7         * tui/tui-source.c (tui_source_window_base::reset): New method.
   8         * tui/tui-layout.c (make_command_window): Don't call
   9         init_and_make_win.
  10         (make_source_window, make_disasm_window): Don't call
  11         make_source_or_disasm_window.
  12         (make_data_window): Don't call init_and_make_win.  Change calling
  13         convention.
  14         (show_source_disasm_command, show_data): Simplify.
  15         (make_source_or_disasm_window): Remove.
  16         (show_source_or_disasm_and_command): Simplify.
  17         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
  18         (struct tui_source_window_base) <reset>: Likewise.
  19         <execution_info>: Remove initializer.
  20         * tui/tui-data.c (tui_source_window_base): Initialize
  21         execution_info.
  22
  23 2019-07-17  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
  26         variable.
  27
  28 2019-07-17  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui.c (tui_rl_other_window): Update.
  31         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
  32         superclass method first.  Always iterate over regs_content.
  33         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
  34         method.
  35         * tui/tui-win.c (tui_set_focus_command): Update.
  36
  37 2019-07-17  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-win.c (tui_set_focus_command): Rename from
  40         tui_set_focus.  Call tui_enable.
  41         (tui_set_focus_command): Remove.
  42
  43 2019-07-17  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
  46         refresh_window.
  47         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
  48         touchwin.
  49         (tui_data_window::refresh_window): Call refresh_window on data
  50         items.  Always call superclass refresh_window.
  51         (tui_win_info::refresh): Remove.
  52         (tui_source_window_base::refresh_window): Update.
  53         (tui_refresh_all): Update.
  54         * tui/tui-layout.c (show_source_disasm_command): Remove call to
  55         refresh_window.
  56         (show_source_or_disasm_and_command): Likewise.
  57         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
  58         (struct tui_source_window_base) <refresh>: Likewise.
  59
  60 2019-07-17  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-winsource.c (tui_clear_source_content)
  63         (tui_show_source_content): Update.
  64         * tui/tui-source.c (tui_source_window::showing_source_p): Check
  65         whether content is empty.
  66         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
  67         Remove.
  68
  69 2019-07-17  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-winsource.c (tui_erase_source_content): Clear the
  72         window's contents.
  73         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
  74         * tui/tui-source.c (tui_set_source_content_nil): Remove.
  75
  76 2019-07-17  Tom Tromey  <tom@tromey.com>
  77
  78         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
  79         (struct tui_data_item_window): Update.
  80
  81 2019-07-17  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
  84         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
  85         defines.
  86
  87 2019-07-17  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-winsource.h (tui_erase_source_content)
  90         (tui_clear_source_content): Remove "display_prompt" parameter.
  91         * tui/tui-winsource.c (tui_update_source_window_as_is)
  92         (tui_update_source_windows_with_addr): Update.
  93         (tui_clear_source_content): Remove "display_prompt" parameter.
  94         (tui_erase_source_content): Likewise.  Simplify.
  95         (tui_show_source_content): Update.
  96         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  97         * tui/tui-stack.c (tui_show_frame_info): Update.
  98         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
  99         Remove defines.
 100
 101 2019-07-17  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 104         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 105         parameter.
 106         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 107         parameter.
 108
 109 2019-07-17  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-winsource.c (tui_clear_source_content)
 112         (tui_show_source_content, tui_show_exec_info_content)
 113         (tui_clear_exec_info_content): Update.
 114         * tui/tui-stack.c (tui_show_locator_content): Update.
 115         (tui_show_frame_info): Update.
 116         * tui/tui-source.h (tui_source_window): Don't declare.
 117         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 118         from tui_source_is_displayed.
 119         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 120         Remove field.
 121         (struct tui_source_window_base) <content_in_use>: New field.  Now
 122         bool.
 123         (struct tui_source_window) <showing_source_p>: New method.
 124         (TUI_SRC_WIN): Change cast.
 125         * tui/tui-data.c (tui_initialize_static_data): Update.
 126
 127 2019-07-17  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 130         location_matches_p.
 131         * tui/tui-source.c (tui_source_window::location_matches_p): New
 132         method.
 133         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 134         method.
 135         * tui/tui-data.h (struct tui_source_window_base)
 136         <location_matches_p>: New method.
 137         (struct tui_source_window, struct tui_disasm_window)
 138         <location_matches_p>: Likewise.
 139
 140 2019-07-17  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-win.c (tui_set_win_height_command): Rename from
 143         tui_set_win_height.
 144         (tui_set_win_height_command): Remove.
 145
 146 2019-07-17  Tom Tromey  <tom@tromey.com>
 147
 148         * tui/tui-source.c (tui_source_window): New constructor.  Add
 149         observer.
 150         (~tui_source_window): New destructor.
 151         (tui_source_window::style_changed): New method.
 152         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 153         (tui_attach_detach_observers): Update.
 154         * tui/tui-data.h (struct tui_source_window): Make constructor not
 155         inline.  Add destructor.
 156         (struct tui_source_window) <style_changed>: New method.
 157         <m_observable>: New member.
 158
 159 2019-07-17  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 162         * tui/tui-win.c (tui_resize_all): Fix typo.
 163
 164 2019-07-17  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 167         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 168         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 169         * tui/tui-win.c (window_name_completer): Use foreach.
 170         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 171         (update_tab_width): Likewise.
 172         * tui/tui-layout.c (show_layout): Update.
 173         * tui/tui-data.h (class tui_window_iterator): New.
 174         (struct all_tui_windows): New.
 175         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 176
 177 2019-07-17  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 180         parameter.  Don't reference globals.
 181         (tui_reg_command): Update.
 182
 183 2019-07-17  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-regs.c (tui_show_registers): Simplify.
 186
 187 2019-07-17  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-regs.c (tui_show_registers): Update.
 190         (tui_show_register_group): Add win_info parameter.
 191
 192 2019-07-17  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 195         Rename from tui_display_reg_element_at_line.
 196         (tui_data_window::display_registers_from_line): Update.
 197         * tui/tui-data.h (struct tui_data_window)
 198         <display_reg_element_at_line>: New method.
 199
 200 2019-07-17  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui-regs.h (tui_display_registers_from)
 203         (tui_display_registers_from_line): Don't declare.
 204         * tui/tui-windata.c (tui_data_window::display_all_data)
 205         (tui_data_window::refresh_all)
 206         (tui_data_window::do_scroll_vertical): Update.
 207         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 208         from tui_display_registers_from.
 209         (tui_display_reg_element_at_line): Update.
 210         (tui_data_window::display_registers_from_line): Rename from
 211         tui_display_registers_from_line.
 212         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 213         display_registers_from_line>: New methods.
 214
 215 2019-07-17  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 218         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 219         from tui_erase_data_content.
 220         (tui_data_window::display_all_data)
 221         (tui_data_window::refresh_all)
 222         (tui_data_window::do_scroll_vertical): Update.
 223         * tui/tui-regs.c (tui_show_registers): Update.
 224         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 225         New method.
 226
 227 2019-07-17  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 230         declare.
 231         * tui/tui-windata.c
 232         (tui_data_window::delete_data_content_windows): Rename from
 233         tui_delete_data_content_windows.
 234         (tui_data_window::display_all_data)
 235         (tui_data_window::do_scroll_vertical): Update.
 236         * tui/tui-data.h (struct tui_data_window)
 237         <delete_data_content_windows>: New method.
 238
 239 2019-07-17  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 242         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 243
 244 2019-07-17  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 247         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 248         from tui_display_all_data.
 249         * tui/tui-win.c
 250         (tui_data_window::do_make_visible_with_new_height): Update.
 251         * tui/tui-regs.c (tui_show_registers): Update.
 252         * tui/tui-layout.c (tui_set_layout): Update.
 253         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 254         method.
 255
 256 2019-07-17  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 259         * tui/tui-windata.c (tui_display_data_from): Remove.
 260         (tui_data_window::refresh_all): Update.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 265         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 266         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 267         tui_display_registers_from_line.
 268         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 269         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 270         "force_display" parameter.
 271
 272 2019-07-17  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 275         declare.
 276         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 277         Rename from tui_first_reg_element_no_inline.
 278         (tui_display_reg_element_at_line)
 279         (tui_display_registers_from_line): Update.
 280         * tui/tui-data.h (struct tui_data_window)
 281         <first_reg_element_no_inline>: New method.
 282
 283 2019-07-17  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-windata.c (tui_display_data_from)
 286         (tui_data_window::do_scroll_vertical): Update.
 287         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 288         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 289         Rename from tui_line_from_reg_element_no.
 290         (tui_display_registers_from_line): Update.
 291         * tui/tui-data.h (struct tui_data_window)
 292         <line_from_reg_element_no>: New method.
 293
 294 2019-07-17  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 297         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 298         tui_last_regs_line_no.
 299         (tui_display_reg_element_at_line)
 300         (tui_display_registers_from_line): Update.
 301         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 302         method.
 303
 304 2019-07-17  Tom Tromey  <tom@tromey.com>
 305
 306         PR tui/24722:
 307         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 308         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 309         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 310         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 311         (tui_update_breakpoint_info): Likewise.
 312         * tui/tui-hooks.c (tui_event_create_breakpoint)
 313         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 314         Update.
 315
 316 2019-07-17  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 319
 320 2019-07-17  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-winsource.c (tui_update_source_window_as_is)
 323         (tui_update_source_windows_with_addr): Update.
 324         * tui/tui-source.h (tui_set_source_content)
 325         (tui_show_symtab_source): Add "win_info" parameter.
 326         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 327         parameter.
 328         (tui_show_symtab_source): Likewise.
 329
 330 2019-07-17  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-wingeneral.c
 333         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 334
 335 2019-07-17  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 338         (struct tui_cmd_window) <can_scroll>: New method.
 339         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 340         method.
 341
 342 2019-07-17  Tom Tromey  <tromey@adacore.com>
 343
 344         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 345         do_field_signed>: Rename.  Change type of "value".
 346         * ui-out.c (ui_out::field_signed): Rename from field_int.
 347         Change type of "value".
 348         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 349         type of "value".
 350         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 351         do_field_int.  Change type of "value".
 352         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 353         do_field_int.  Change type of "value".
 354         * tracepoint.c (trace_status_mi, tfind_1)
 355         (print_one_static_tracepoint_marker): Update.
 356         * thread.c (print_thread_info_1, print_selected_thread_frame):
 357         Update.
 358         * stack.c (print_frame, print_frame_info): Update.
 359         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 360         Update.
 361         * source.c (print_source_lines_base): Update.
 362         * skip.c (info_skip_command): Update.
 363         * record-btrace.c (btrace_ui_out_decode_error)
 364         (btrace_call_history_src_line): Update.
 365         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 366         Update.
 367         * progspace.c (print_program_space): Update.
 368         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 369         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 370         do_field_int.  Change type of "value".
 371         * mi/mi-out.c (mi_ui_out::do_table_begin)
 372         (mi_ui_out::do_table_header): Update.
 373         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 374         type of "value".
 375         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 376         (mi_cmd_data_list_changed_registers, output_register)
 377         (mi_cmd_data_read_memory, mi_load_progress)
 378         (mi_cmd_trace_frame_collected): Update.
 379         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 380         Update.
 381         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 382         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 383         (mi_cmd_var_list_children, varobj_update_one): Update.
 384         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 385         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 386         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 387         * inferior.c (print_inferior): Update.
 388         * gdb_bfd.c (print_one_bfd): Update.
 389         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 390         Update.
 391         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 392         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 393         do_field_int.  Change type of "value".
 394         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 395         do_field_int.  Change type of "value".
 396         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 397         (print_one_breakpoint_location, print_it_catch_fork)
 398         (print_one_catch_fork, print_it_catch_vfork)
 399         (print_one_catch_vfork, print_it_catch_solib)
 400         (print_it_catch_exec, print_it_ranged_breakpoint)
 401         (print_mention_watchpoint, print_mention_masked_watchpoint)
 402         (bkpt_print_it, update_static_tracepoint): Update.
 403         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 404         * break-catch-syscall.c (print_it_catch_syscall): Update.
 405         * ada-tasks.c (print_ada_task_info): Update.
 406         * ada-lang.c (print_it_exception, print_mention_exception):
 407         Update.
 408
 409 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 410
 411         PR breakpoints/24541
 412         * gdbarch.c: Regenerate.
 413         * gdbarch.h: Regenerate.
 414         * gdbarch.sh: Adjust return type and parameter types for
 415         'stap_adjust_register'.
 416         (i386_stap_adjust_register): Adjust signature and return new
 417         register name.
 418         * stap-probe.c (stap_parse_register_operand): Adjust use of
 419         'gdbarch_stap_adjust_register'.
 420
 421 2019-07-17  Tom Tromey  <tromey@adacore.com>
 422
 423         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 424         declare VEC.
 425         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 426         std::vector.
 427         (struct s390_process_info): Add initializers.
 428         (s390_add_process): Use new.
 429         (s390_linux_nat_target::low_forget_process): Use delete.
 430         (s390_linux_nat_target::low_new_fork)
 431         (s390_linux_nat_target::stopped_by_watchpoint)
 432         (s390_linux_nat_target::low_prepare_to_resume)
 433         (s390_linux_nat_target::insert_watchpoint)
 434         (s390_linux_nat_target::insert_hw_breakpoint)
 435         (s390_linux_nat_target::remove_watchpoint)
 436         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 437
 438 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 439
 440         * aarch64-fbsd-nat.c: Include regcache.h.
 441         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 442         argument.
 443         (aarch64_fbsd_nat_target::fetch_registers)
 444         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 445         variable.
 446         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 447
 448 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 449
 450         * fbsd-nat.c: Include gdbarch.h.
 451
 452 2019-07-15  Tom Tromey  <tromey@adacore.com>
 453
 454         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 455
 456 2019-07-15  Tom Tromey  <tromey@adacore.com>
 457
 458         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 459         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 460         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 461         * cli-out.c (cli_ui_out::do_field_int): New method.
 462         * ui-out.c (ui_out::field_unsigned): New method.
 463         * symfile.c (generic_load): Use field_unsigned.
 464         (print_transfer_performance): Likewise.
 465         * record-btrace.c (ui_out_field_uint): Remove.
 466         (btrace_call_history_insn_range, btrace_call_history): Use
 467         field_unsigned.
 468         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 469         field_unsigned.
 470         * ui-out.h (class ui_out) <field_unsigned>: New method.
 471         <do_field_unsigned>: Likewise.
 472
 473 2019-07-15  Tom Tromey  <tromey@adacore.com>
 474
 475         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 476         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 477         * target.c (flash_erase_command): Use field_string.
 478         * infrun.c (print_signal_received_reason): Use field_string.
 479         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 480         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 481         field_string.
 482         * ada-tasks.c (print_ada_task_info): Use field_string.
 483
 484 2019-07-15  Tom Tromey  <tromey@adacore.com>
 485
 486         * target.c (flash_erase_command): Use field_core_addr.
 487         * symfile.c (generic_load): Use field_core_addr.
 488         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 489         Use field_core_addr.
 490         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 491         field_core_addr.
 492
 493 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 494
 495         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 496         value if its desired type is smaller than a CORE_ADDR and signed.
 497
 498 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 499
 500         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 501         of changes to field names, and use new is_reference field to
 502         decide if a property is a reference or not.
 503         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 504         field.
 505         (struct dwarf2_property_baton): Update header comment, rename
 506         'referenced_type' to 'property_type' and update comments.
 507         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 508         default property type, store in property baton, update to take
 509         accound of renamed field.
 510         (read_func_scope): Update call to attr_to_dynamic_prop.
 511         (read_array_type): Likewise.
 512         (dwarf2_per_cu_addr_sized_int_type): New function.
 513         (read_subrange_index_type): Move type finding code to
 514         dwarf2_per_cu_addr_sized_int_type.
 515         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 516         (dwarf2_per_cu_addr_type): New function.
 517         (set_die_type): Update calls to attr_to_dynamic_prop.
 518
 519 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 520
 521         * dwarf2read.c (read_subrange_index_type): New function.
 522         (read_subrange_type): Move code into new function and call it.
 523         * gdbtypes.c (create_range_type): Add some asserts.
 524
 525 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 526
 527         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 528         update return statements.
 529         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 530         declaration, and update comment to match.
 531         * gdbtypes.c (resolve_dynamic_array): Update call to
 532         dwarf2_evaluate_property to match new return type.
 533
 534 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 535
 536         * valarith.c (value_subscripted_rvalue): Change lowerbound
 537         parameter type from int to LONGEST.
 538         * value.h (value_subscripted_rvalue): Likewise in declaration.
 539
 540 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 541
 542         * cli/cli-utils.c (info_print_command_completer): New function.
 543         * cli/cli-utils.h: Add 'completer.h' include, and forward
 544         declaration for 'struct cmd_list_element'.
 545         (info_print_command_completer): Declare.
 546         * stack.c (_initialize_stack): Add completer for 'info locals' and
 547         'info args'.
 548         * symtab.c (_initialize_symtab): Add completer for 'info
 549         variables' and 'info functions'.
 550         * NEWS: Mention completion for additional info commands.
 551
 552 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 553
 554         * cli/cli-utils.c (extract_info_print_args): Delete.
 555         (extract_arg_maybe_quoted): Delete.
 556         (info_print_options_defs): New variable.
 557         (make_info_print_options_def_group): New function.
 558         (extract_info_print_options): Define new function.
 559         * cli/cli-utils.h (extract_info_print_args): Delete.
 560         (struct info_print_options): New structure.
 561         (extract_info_print_options): Declare new function.
 562         * stack.c (info_locals_command): Update to use new
 563         extract_info_print_options, also add a header comment.
 564         (info_args_command): Likewise.
 565         * symtab.c (info_variables_command): Likewise.
 566         (info_functions_command): Likewise.
 567
 568 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 569
 570         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 571         to extract string arguments.
 572         * common/common-utils.c (extract_string_maybe_quoted): New function.
 573         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 574
 575 2019-07-11  Tom Tromey  <tromey@adacore.com>
 576
 577         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 578         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 579         * top.h (gdbinit): Don't declare.
 580         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 581         into...
 582         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 583         * top.c (gdb_init): Don't call init_cli_cmds.
 584         (gdbinit): Remove.
 585         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 586
 587 2019-07-11  Tom Tromey  <tromey@adacore.com>
 588
 589         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 590         after it has been moved.
 591
 592 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 593
 594         * valops.c (value_must_coerce_to_target): Change return type to
 595         bool.
 596         * value.h (value_must_coerce_to_target): Likewise.
 597
 598 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 599
 600         * breakpoint.c (is_hardware_watchpoint): Remove
 601         forward-declaration.
 602         (is_masked_watchpoint): Change return type to bool.
 603         (is_tracepoint): Likewise.
 604         (is_breakpoint): Likewise.
 605         (is_hardware_watchpoint): Likewise.
 606         (is_watchpoint): Likewise.
 607         (is_no_memory_software_watchpoint): Likewise.
 608         (is_catchpoint): Likewise.
 609         (breakpoint_1): Make FILTER parameter's return type bool.
 610         is_masked_watchpoint): Change return type to bool.
 611         (save_breakpoints): Make FILTER parameter's return type bool.
 612         * breakpoint.h (is_breakpoint): Change return type to bool.
 613         (is_watchpoint): Likewise.
 614         (is_catchpoint): Likewise.
 615         (is_tracepoint): Likewise.
 616
 617 2019-07-10  Tom Tromey  <tom@tromey.com>
 618
 619         * defs.h: Don't include gdbarch.h.
 620         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 621         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 622         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 623         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 624         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 625         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 626         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 627         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 628         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 629         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 630         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 631         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 632         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 633         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 634         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 635         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 636         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 637         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 638         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 639         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 640         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 641         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 642         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 643         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 644         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 645         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 646         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 647
 648 2019-07-10  Tom Tromey  <tromey@adacore.com>
 649
 650         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 651         * breakpoint.c (init_ada_exception_breakpoint): Register as
 652         bp_catchpoint.
 653         (print_one_breakpoint_location, print_one_breakpoint): Use
 654         is_ada_exception_catchpoint.
 655         * ada-lang.c (class ada_catchpoint_location): Pass
 656         bp_loc_software_breakpoint to bp_location constructor.
 657         (is_ada_exception_catchpoint): New function.
 658
 659 2019-07-10  Tom Tromey  <tromey@adacore.com>
 660
 661         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 662         VEC.
 663         (struct arm_exidx_entry): New method operator<.
 664         (struct arm_exidx_data) <section_maps>: Change type.
 665         (arm_exidx_data_free): Remove.
 666         (arm_exidx_data_key): Change type.  Move lower.
 667         (arm_exidx_new_objfile): Update.
 668         (arm_compare_exidx_entries): Remove.
 669         (arm_find_exidx_entry, _initialize_arm_tdep)
 670
 671 2019-07-10  Tom Tromey  <tromey@adacore.com>
 672
 673         * solib-spu.c (ocl_program_data_key): Change type.
 674         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 675         Update.
 676
 677 2019-07-10  Tom Tromey  <tromey@adacore.com>
 678
 679         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 680         (struct solib_aix_inferior_data) <library_list>: Change type.
 681         (solib_aix_inferior_data_handle): Change type.
 682         (get_solib_aix_inferior_data): Update.
 683         (solib_aix_free_library_list): Remove.
 684         (library_list_start_library): Update.
 685         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 686         return type.
 687         (solib_aix_get_library_list)
 688         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 689         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 690
 691 2019-07-10  Tom Tromey  <tromey@adacore.com>
 692
 693         * solib-dsbt.c (struct dsbt_info): Add initializers.
 694         (solib_dsbt_pspace_data): Change type.
 695         (dsbt_pspace_data_cleanup): Remove.
 696         (get_dsbt_info, _initialize_dsbt_solib): Update.
 697
 698 2019-07-10  Tom Tromey  <tromey@adacore.com>
 699
 700         * spu-tdep.c (spu_overlay_data): Change type.
 701         (spu_get_overlay_table, spu_overlay_new_objfile)
 702         (_initialize_spu_tdep): Update.
 703
 704 2019-07-10  Tom Tromey  <tromey@adacore.com>
 705
 706         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 707         destructor.
 708         (dbx_objfile_data_key): Change type and declare later.
 709         (DBX_SYMFILE_INFO): Rewrite.
 710         * dbxread.c (dbx_objfile_data_key): Change type.
 711         (dbx_symfile_init): Update.
 712         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 713         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 714         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 715
 716 2019-07-10  Tom Tromey  <tromey@adacore.com>
 717
 718         * jit.c (jit_program_space_key): Change type.  Move lower.
 719         (get_jit_program_space_data): Update.
 720         (jit_program_space_data_cleanup): Remove.
 721         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 722         Update.
 723         (struct jit_program_space_data): Add initializers.
 724
 725 2019-07-10  Tom Tromey  <tromey@adacore.com>
 726
 727         * solib-darwin.c (struct darwin_info): Add initializers.
 728         (solib_darwin_pspace_data): Change type.
 729         (darwin_pspace_data_cleanup): Remove.
 730         (get_darwin_info, _initialize_darwin_solib): Update.
 731
 732 2019-07-10  Tom Tromey  <tromey@adacore.com>
 733
 734         * remote-sim.c (struct sim_inferior_data): Add initializers,
 735         constructor, and destructor.
 736         (sim_inferior_data_key): Change type.  Move lower.
 737         (check_for_duplicate_sim_descriptor): Update.
 738         (get_sim_inferior_data): Use new.  Update.
 739         (~sim_inferior_data_cleanup): Rename from
 740         sim_inferior_data_cleanup.  Simplify.
 741         (gdbsim_close_inferior, simulator_command)
 742         (sim_command_completer, _initialize_remote_sim): Update.
 743         (next_pid, INITIAL_PID): Move earlier.
 744
 745 2019-07-10  Tom Tromey  <tromey@adacore.com>
 746
 747         * python/python-internal.h (create_thread_object): Return
 748         gdbpy_ref.
 749         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 750         * python/py-inferior.c (struct threadlist_entry): Add
 751         constructor.
 752         <thread_obj>: Now a gdbpy_ref.
 753         (thread_to_thread_object): Update.
 754         (add_thread_object): Use new.
 755         (delete_thread_object): Use delete.
 756         (infpy_threads): Update.
 757         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 758         GIL.
 759
 760 2019-07-10  Tom Tromey  <tromey@adacore.com>
 761
 762         * valops.c (value_cast): Specialize error message for Ada.
 763
 764 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 765
 766         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 767
 768 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 769
 770         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 771         bpstat_should_step): Return bool, adjust comments.
 772         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 773         bpstat_should_step): Likewise.
 774
 775 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 776
 777         * features/Makefile: Use feature target descriptions for Arm.
 778         * features/arm/arm-core.c: Generate new file.
 779         * features/arm/arm-fpa.c: Likewise.
 780         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 781         * features/arm/arm-m-profile.c: Likewise.
 782         * features/arm/arm-vfpv2.c: Likewise.
 783         * features/arm/arm-vfpv3.c: Likewise.
 784         * features/arm/xscale-iwmmxt.c: Likewise.
 785         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 786
 787 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 788
 789         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 790         ptrace earlier.
 791
 792 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 793
 794         * features/aarch64-pauth.c: Regenerate.
 795
 796 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 797
 798         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 799         bool.
 800         (bpstat_what): Use false instead of 0.
 801
 802 2019-07-09  Pedro Alves  <palves@redhat.com>
 803
 804         * break-catch-throw.c (is_exception_catchpoint): New.
 805         * breakpoint.c (print_one_breakpoint_location): New parameter
 806         'raw_loc'.  Handle it.  Use
 807         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 808         looking at the breakpoint's type.
 809         (print_one_breakpoint): If handling "maint info breakpoints", also
 810         print locations of exception catchpoints.
 811         * breakpoint.h (is_exception_catchpoint): Declare.
 812
 813 2019-07-09  Pedro Alves  <palves@redhat.com>
 814
 815         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 816         "addr" field.
 817         (allocate_location_exception_catchpoint): New.
 818         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 819         (initialize_throw_catchpoint_ops): Install
 820         allocate_location_exception_catchpoint as allocate_location
 821         method.
 822         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 823         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 824         bp_loc_other.
 825         (breakpoint_address_is_meaningful): Delete.
 826         (bl_address_is_meaningful): New.
 827         (breakpoint_locations_match): Adjust comment.
 828         (bp_location_from_bp_type): New, factored out of...
 829         (bp_location::bp_location(breakpoint *)): ... this.
 830         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 831         factored out of...
 832         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 833         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 834         breakpoint_address_is_meaningful.
 835         (bp_locations_compare): Adjust comment.
 836         (update_global_location_list): Use bl_address_is_meaningful
 837         instead of breakpoint_address_is_meaningful.
 838         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 839         explicit.
 840         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 841         * python/py-breakpoint.c (bppy_get_location): No longer check
 842         whether location is null.
 843
 844 2019-07-09  Pedro Alves  <palves@redhat.com>
 845
 846         PR c++/15468
 847         * breakpoint.c (print_one_breakpoint_location): Remove
 848         single-location assert.
 849
 850 2019-07-09  Tom Tromey  <tom@tromey.com>
 851
 852         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 853         * configure: Rebuild.
 854         * configure.ac: Change common to gdbsupport.
 855         * gdbsupport: Rename from common.
 856         * acinclude.m4: Change common to gdbsupport.
 857         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 858         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 859         gdbsupport.
 860         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 861         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 862         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 863         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 864         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 865         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 866         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 867         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 868         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 869         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 870         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 871         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 872         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 873         coff-pe-read.c, command.h, compile/compile-c-support.c,
 874         compile/compile-c.h, compile/compile-cplus-symbols.c,
 875         compile/compile-cplus-types.c, compile/compile-cplus.h,
 876         compile/compile-loc2c.c, compile/compile.c, completer.c,
 877         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 878         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 879         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 880         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 881         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 882         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 883         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 884         features/aarch64-core.c, features/aarch64-fpu.c,
 885         features/aarch64-pauth.c, features/aarch64-sve.c,
 886         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 887         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 888         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 889         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 890         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 891         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 892         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 893         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 894         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 895         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 896         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 897         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 898         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 899         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 900         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 901         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 902         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 903         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 904         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 905         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 906         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 907         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 908         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 909         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 910         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 911         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 912         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 913         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 914         minsyms.c, mips-linux-tdep.c, namespace.h,
 915         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 916         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 917         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 918         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 919         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 920         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 921         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 922         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 923         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 924         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 925         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 926         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 927         procfs.c, producer.c, progspace.h, psymtab.h,
 928         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 929         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 930         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 931         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 932         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 933         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 934         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 935         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 936         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 937         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 938         target-memory.c, target.c, target.h, target/waitstatus.c,
 939         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 940         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 941         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 942         unittests/array-view-selftests.c,
 943         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 944         unittests/common-utils-selftests.c,
 945         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 946         unittests/format_pieces-selftests.c,
 947         unittests/function-view-selftests.c,
 948         unittests/lookup_name_info-selftests.c,
 949         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 950         unittests/mkdir-recursive-selftests.c,
 951         unittests/observable-selftests.c,
 952         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 953         unittests/parse-connection-spec-selftests.c,
 954         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 955         unittests/scoped_fd-selftests.c,
 956         unittests/scoped_mmap-selftests.c,
 957         unittests/scoped_restore-selftests.c,
 958         unittests/string_view-selftests.c, unittests/style-selftests.c,
 959         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 960         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 961         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 962         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 963         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 964         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 965
 966 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 967
 968         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 969         bool value.
 970         (decode_digits_ordinary): Set explicit_line field in sal.
 971         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 972         symtab_and_line that was set on an explicit line number in
 973         assembler code.  Do always update the recorded symtab and line if
 974         we do skip the prologue.
 975
 976 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 977
 978         * breakpoint.c (set_breakpoint_location_function): Remove
 979         explicit_loc parameter.
 980         (momentary_breakpoint_from_master): Update call to
 981         set_breakpoint_location_function.
 982         (add_location_to_breakpoint): Likewise.
 983
 984 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 985
 986         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 987         required features based on default bfd type when no specific bfd
 988         is present.
 989
 990 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 991
 992         * NEWS: Mention that GDB printf and eval commands can now print
 993         C-style and Ada-style convenience var strings without
 994         calling the inferior.
 995         * printcmd.c (printf_c_string): Locally print GDB internal var
 996         instead of transiting via the inferior.
 997         (printf_wide_c_string): Likewise.
 998
 999 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1000
1001         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1002
1003 2019-07-04  Tom Tromey  <tom@tromey.com>
1004
1005         PR tui/24724:
1006         * tui/tui-winsource.c (tui_clear_source_content): Update.
1007         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1008         (tui_update_breakpoint_info): Update.
1009         (tui_set_exec_info_content): Update.
1010         * tui/tui-source.c (tui_set_source_content_nil): Update.
1011         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1012         has_break.
1013         * tui/tui-data.h (enum tui_bp_flag): New.
1014         (tui_bp_flags): New enum flags type.
1015         (struct tui_source_element) <break_mode>: Change type.  Rename
1016         from has_break.
1017         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1018         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1019         constants.
1020         * tui/tui-winsource.h: Fix comment.
1021
1022 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1023
1024         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1025         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1026         (store_fpregs_to_thread)
1027         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1028         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1029         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1030         (IWMMXT_REGS_SIZE): Add define.
1031         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1032         (fetch_vfp_regs, store_vfp_regs)
1033         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1034         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1035
1036 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1037
1038         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1039         defines.
1040         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1041         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1042         (ARM_INT_REGISTER_SIZE): ...to this.
1043         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1044         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1045         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1046         (arm_linux_collect_gregset, supply_nwfpe_register)
1047         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1048         defines.
1049         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1050         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1051         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1052         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1053         (arm_return_in_memory, arm_store_return_value)
1054         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1055         (arm_record_ld_st_multiple): Likewise.
1056         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1057         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1058
1059 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1060
1061         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1062         AARCH64_DISPLACED_MODIFIED_INSNS.
1063         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1064         (aarch64_displaced_step_copy_insn): Likewise.
1065         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1066         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1067         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1068         ARM_DISPLACED_MODIFIED_INSNS.
1069         * arm-tdep.c (arm_gdbarch_init): Likewise.
1070         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1071         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1072         (struct arm_displaced_step_closure): Use
1073         ARM_DISPLACED_MODIFIED_INSNS.
1074
1075 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1076
1077         * features/Makefile: Remove unused xml files.
1078         * features/aarch64.xml: Remove.
1079         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1080         * features/i386/amd64-avx-avx512.xml: Remove.
1081         * features/i386/amd64-avx-linux.xml: Remove.
1082         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1083         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1084         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1085         * features/i386/amd64-avx-mpx.xml: Remove.
1086         * features/i386/amd64-avx.xml: Remove.
1087         * features/i386/amd64-linux.xml: Remove.
1088         * features/i386/amd64-mpx-linux.xml: Remove.
1089         * features/i386/amd64-mpx.xml: Remove.
1090         * features/i386/amd64.xml: Remove.
1091         * features/i386/i386-avx-avx512-linux.xml: Remove.
1092         * features/i386/i386-avx-avx512.xml: Remove.
1093         * features/i386/i386-avx-linux.xml: Remove.
1094         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1095         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1096         * features/i386/i386-avx-mpx-linux.xml: Remove.
1097         * features/i386/i386-avx-mpx.xml: Remove.
1098         * features/i386/i386-avx.xml: Remove.
1099         * features/i386/i386-linux.xml: Remove.
1100         * features/i386/i386-mmx-linux.xml: Remove.
1101         * features/i386/i386-mmx.xml: Remove.
1102         * features/i386/i386-mpx-linux.xml: Remove.
1103         * features/i386/i386-mpx.xml: Remove.
1104         * features/i386/i386.xml: Remove.
1105         * features/i386/x32-avx-avx512-linux.xml: Remove.
1106         * features/i386/x32-avx-linux.xml: Remove.
1107         * features/i386/x32-linux.xml: Remove.
1108
1109 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1110
1111         * regformats/aarch64.dat: Remove.
1112         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1113         * regformats/i386/amd64-avx-linux.dat: Remove.
1114         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1115         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1116         * regformats/i386/amd64-linux.dat: Remove.
1117         * regformats/i386/amd64-mpx-linux.dat: Remove.
1118         * regformats/i386/amd64.dat: Remove.
1119         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1120         * regformats/i386/i386-avx-linux.dat: Remove.
1121         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1122         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1123         * regformats/i386/i386-linux.dat: Remove.
1124         * regformats/i386/i386-mmx-linux.dat: Remove.
1125         * regformats/i386/i386-mpx-linux.dat: Remove.
1126         * regformats/i386/i386.dat: Remove.
1127         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1128         * regformats/i386/x32-avx-linux.dat: Remove.
1129         * regformats/i386/x32-linux.dat: Remove.
1130
1131 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1132
1133         * aarch64-tdep.c: Remove xml self tests.
1134         * amd64-linux-tdep.c: Likewise.
1135         * amd64-tdep.c: Likewise.
1136         * i386-linux-tdep.c: Likewise.
1137         * i386-tdep.c: Likewise.
1138
1139 2019-07-03  Pedro Alves  <palves@redhat.com>
1140
1141         PR cli/24732
1142         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1143         (pipe_cmd_option_defs): New.
1144         (make_pipe_cmd_options_def_group): New.
1145         (pipe_command): Use gdb::option::process_options.
1146         (pipe_command_completer): New function.
1147         (_initialize_cli_cmds): Install completer for "pipe" command.
1148
1149 2019-07-03  Pedro Alves  <palves@redhat.com>
1150
1151         * cli/cli-option.c (union option_value) <string>: New field.
1152         (struct option_def_and_value): Add ctor, move ctor, dtor and
1153         use DISABLE_COPY_AND_ASSIGN.
1154         (option_def_and_value::clear_value): New.
1155         (parse_option, save_option_value_in_ctx, get_val_type_str)
1156         (add_setshow_cmds_for_options): Handle var_string.
1157         * cli-option.h (union option_def::var_address) <string>: New
1158         field.
1159         (struct string_option_def): New.
1160         * maint-test-options.c (struct test_options_opts): Add default
1161         ctor and use DISABLE_COPY_AND_ASSIGN.
1162         <string_opt>: New field.
1163         (test_options_opts::~test_options_opts): New.
1164         (test_options_opts::dump): Also dump "-string".
1165         (test_options_option_defs): Install "string.
1166
1167 2019-07-03  Pedro Alves  <palves@redhat.com>
1168
1169         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1170         option_value with a null enumeration.
1171         (complete_options): Save the option values in the context.
1172         (save_option_value_in_ctx): New, factored out from ...
1173         (process_options): ... here.
1174         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1175         of the function.
1176         * maint-test-options.c (test_options_opts::dump): New, factored
1177         out from ...
1178         (maintenance_test_options_command_mode): ... here.
1179         (maintenance_test_options_command_completion_result): Delete.
1180         (maintenance_test_options_command_completion_text): Update
1181         comment.
1182         (maintenance_show_test_options_completion_result): Change
1183         prototype.  Just print
1184         maintenance_test_options_command_completion_text.
1185         (save_completion_result): New.
1186         (maintenance_test_options_completer_mode): Pass options context to
1187         complete_options, and then save a dump.
1188         (_initialize_maint_test_options): Use add_cmd to install "maint
1189         show test-options-completion-result".
1190
1191 2019-07-03  Pedro Alves  <palves@redhat.com>
1192
1193         * NEWS (New commands): Mention "with" and "maint with".
1194         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1195         (with_command, with_command_completer): New.
1196         (pipe_command): Adjust to new repeat_previous
1197         interface.
1198         (_initialize_cli_cmds): Install the "with" command and its "w"
1199         alias.
1200         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1201         declarations.
1202         * cli/cli-setshow.c (parse_cli_var_uinteger)
1203         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1204         argument strings for all var_types.
1205         (get_setshow_command_value_string): New, factored out from ...
1206         (do_show_command): ... this.
1207         * cli/cli-setshow.h: Include <string>.
1208         (get_setshow_command_value_string): Declare.
1209         * command.h (repeat_previous): Now returns const char *.  Adjust
1210         comment.
1211         * maint.c: Include "cli/cli-cmds.h".
1212         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1213         (_initialize_maint_cmds): Register the "maintenance with" command.
1214         * top.c (repeat_previous): Move bits from pipe_command here:
1215         Return the saved command line, if any; error out if there's no
1216         command to relaunch.
1217
1218 2019-07-03  Pedro Alves  <palves@redhat.com>
1219
1220         * NEWS (New commands): Mention "maint set/show test-settings"
1221         instead of "maint test-settings".
1222         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1223         (maintenance_test_settings_set_list): Rename to ...
1224         (maintenance_set_test_settings_list): ... this.
1225         (maintenance_test_settings_show_list): Rename to  ...
1226         (maintenance_show_test_settings_list): ... this.
1227         (maintenance_test_settings_cmd): Delete.
1228         (maintenance_test_settings_set_cmd): ...
1229         (maintenance_set_test_settings_cmd): ... this.
1230         (maintenance_test_settings_show_cmd): ...
1231         (maintenance_show_test_settings_cmd): ... this.
1232         (maintenance_test_settings_show_value_cmd):
1233         (maintenance_show_test_settings_value_cmd): ... this.
1234         (_initialize_maint_test_settings): No longer install the "maint
1235         test-settings" prefix command.  Rename "maint test-settings set"
1236         to "maint set test-settings", and "maint test-settings show" to
1237         "maint show test-settings".  Adjust all subcommands.
1238
1239 2019-07-03  Pedro Alves  <palves@redhat.com>
1240
1241         * maint-test-settings.c: Fix file's intro comment.  Replace all
1242         references to "test-options" with references to "test-settings",
1243         in comments.
1244
1245 2019-07-03  Pedro Alves  <palves@redhat.com>
1246
1247         * maint-test-settings.c (maintenance_test_settings_xxx)
1248         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1249         New.
1250         (maintenance_test_settings_enums): Use them.
1251         (maintenance_test_settings_enum): Default to
1252         maintenance_test_settings_xxx.
1253         (_initialize_maint_test_settings): Initialize
1254         MAINTENANCE_TEST_SETTINGS_FILENAME.
1255
1256 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1257
1258         * breakpoint.h (remove_breakpoints_inf): Change return type to
1259         void, move function documentation here.
1260         * breakpoint.c (remove_breakpoints_inf): Change return type to
1261         void, move function documentation to header.
1262
1263 2019-07-02  Pedro Alves  <palves@redhat.com>
1264
1265         * NEWS (Completion improvements): Mention "info threads".
1266         * thread.c (struct info_threads_opts, info_threads_option_defs)
1267         (make_info_threads_options_def_group): New.
1268         (info_threads_command): Use gdb::option::process_options.
1269         (info_threads_command_completer): New.
1270         (_initialize_thread): Use gdb::option::build_help to build the
1271         help text for "info threads".
1272
1273 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1274
1275         * defs.h (generic_load): Move from here...
1276         * symfile.h (generic_load): ... to here.  Rename name parameter
1277         to args.
1278         * symfile.c (generic_load): Add comment.
1279
1280 2019-07-01  Tom Tromey  <tromey@adacore.com>
1281
1282         * dwarf2read.c
1283         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1284         declaration of without_params.  Fix formatting.
1285
1286 2019-07-01  Tom Tromey  <tromey@adacore.com>
1287
1288         * ada-exp.y (find_primitive_type): Update.
1289         * ada-lang.h (ada_lookup_symbol): Update.
1290         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1291         parameter.
1292         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1293
1294 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1295
1296         PR breakpoints/24541
1297         * gdbarch.c: Regenerate.
1298         * gdbarch.h: Regenerate.
1299         * gdbarch.sh: Add 'stap_adjust_register'.
1300         * i386-tdep.c: Include '<unordered_set>'.
1301         (i386_stap_adjust_register): New function.
1302         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1303         * stap-probe.c (stap_parse_register_operand): Call
1304         'gdbarch_stap_adjust_register'.
1305
1306 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1307
1308         PR python/24742
1309         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1310         * python/python.c (do_start_initialization): Use 'xmalloc'
1311         instead of 'PyMem_Malloc'.
1312
1313 2019-06-28  Tom Tromey  <tromey@adacore.com>
1314
1315         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1316         for Ada.
1317
1318 2019-06-27  Tom Tromey  <tromey@adacore.com>
1319
1320         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1321         objfile_key.
1322         (arm_find_mapping_symbol, arm_record_special_symbol)
1323         (_initialize_arm_tdep): Update.
1324         (arm_objfile_data_free): Remove.
1325
1326 2019-06-27  Tom Tromey  <tromey@adacore.com>
1327
1328         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1329         to cp_print_static_field.
1330
1331 2019-06-26  Tom Tromey  <tromey@adacore.com>
1332
1333         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1334         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1335         declare.
1336
1337 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1338
1339         * features/aarch64-core.c (create_feature_aarch64_core):
1340         Regenerate.
1341         * features/aarch64-core.xml: Add cpsr flags.
1342
1343 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1344
1345         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1346         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1347
1348 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1349
1350         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1351         field.
1352         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1353         use.
1354         (arm_record_special_symbol): Don't insert new symbol in sorted
1355         position, push it at the end.
1356
1357 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1358
1359         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1360         (arm_mapping_symbol_s): Remove.
1361         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1362         (arm_mapping_symbol_vec): New typedef.
1363         (struct arm_per_objfile): Add constructor.
1364         <section_maps>: Change type to
1365         std::unique_ptr<arm_mapping_symbol_vec[]>.
1366         (arm_compare_mapping_symbols): Remove.
1367         (arm_find_mapping_symbol): Adjust to section_maps type change.
1368         (arm_objfile_data_free): Call delete on arm_per_objfile.
1369         (arm_record_special_symbol): Adjust to section_maps type change.
1370         Allocate arm_per_objfile with new.
1371
1372 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1373
1374         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1375         with the command prefix.
1376
1377 2019-06-25  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1380         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1381
1382 2019-06-25  Tom Tromey  <tom@tromey.com>
1383
1384         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1385         type.
1386         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1387         protected.
1388
1389 2019-06-25  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-winsource.c
1392         (tui_source_window_base::set_is_exec_point_at): Add check against
1393         LOA_ADDRESS.
1394
1395 2019-06-25  Tom Tromey  <tom@tromey.com>
1396
1397         * tui/tui-source.c (tui_set_source_content): Don't check before
1398         xfree.
1399         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1400
1401 2019-06-25  Tom Tromey  <tom@tromey.com>
1402
1403         * tui/tui-winsource.h (tui_update_source_window_as_is)
1404         (tui_alloc_source_buffer, tui_line_is_displayed)
1405         (tui_addr_is_displayed): Change type of win_info.
1406         * tui/tui-winsource.c (tui_update_source_window_as_is)
1407         (tui_clear_source_content, tui_show_source_line)
1408         (tui_show_source_content, tui_source_window_base::refill)
1409         (tui_source_window_base::set_is_exec_point_at)
1410         (tui_source_window_base::set_is_exec_point_at)
1411         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1412         (tui_alloc_source_buffer, tui_line_is_displayed)
1413         (tui_addr_is_displayed): Change type of win_info.  Update.
1414         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1415         (tui_source_window_base::do_make_visible_with_new_height):
1416         Update.
1417         * tui/tui-source.c (tui_set_source_content)
1418         (tui_set_source_content_nil)
1419         (tui_source_window::do_scroll_vertical): Update.
1420         * tui/tui-layout.c (show_layout): Update.
1421         * tui/tui-disasm.c (tui_set_disassem_content)
1422         (tui_disasm_window::do_scroll_vertical): Update.
1423         * tui/tui-data.h (tui_win_content): Remove.
1424         (struct tui_gen_win_info) <content, content_size>: Remove.
1425         (struct tui_source_element): Add initializers and destructor.
1426         (union tui_which_element, struct tui_win_element): Remove.
1427         (struct tui_source_window_base) <content>: New field.
1428         (struct tui_data_window): Remove destructor.
1429         (tui_alloc_content, tui_free_win_content)
1430         (tui_free_all_source_wins_content): Don't declare.
1431         * tui/tui-data.c (tui_initialize_static_data): Update.
1432         (init_content_element, tui_alloc_content): Remove.
1433         (~tui_gen_win_info): Update.
1434         (~tui_data_window, tui_free_all_source_wins_content)
1435         (tui_free_win_content, free_content, free_content_elements):
1436         Remove.
1437
1438 2019-06-25  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-winsource.h (tui_clear_source_content)
1441         (tui_erase_source_content, tui_show_source_content): Change type
1442         of win_info.
1443         * tui/tui-winsource.c (tui_clear_source_content)
1444         (tui_erase_source_content, tui_show_source_content): Change type
1445         of win_info.
1446         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1447         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1448         win_info.
1449         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1450         win_info.
1451         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1452
1453 2019-06-25  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-winsource.c (tui_clear_source_content)
1456         (tui_source_window_base::set_is_exec_point_at): Update.
1457         * tui/tui-source.c (tui_set_source_content_nil): Update.
1458         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1459         a bool.
1460         * tui/tui-data.c (init_content_element): Update.
1461
1462 2019-06-25  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1465         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1466         * tui/tui-layout.c (init_and_make_win): Update.
1467         * tui/tui.h (enum tui_win_type): Update.
1468         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1469         tui_win_is_auxillary.
1470         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1471         tui_win_is_auxillary.
1472
1473 2019-06-25  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1476         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1477         (tui_delete_data_content_windows, tui_display_all_data)
1478         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1479         Update.
1480         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1481         * tui/tui-regs.c (tui_last_regs_line_no)
1482         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1483         (tui_show_registers): Update.
1484         (tui_show_register_group): Return void.  Update.
1485         (tui_display_registers_from, tui_display_reg_element_at_line)
1486         (tui_display_registers_from_line, tui_check_register_values):
1487         Update.
1488         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1489         member.
1490         (struct tui_data_window) <regs_content>: Now a std::vector.
1491         <regs_content_count>: Remove.
1492         (tui_add_content_elements, tui_free_data_content): Don't declare.
1493         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1494         (init_content_element): Remove DATA_WIN case.  Add assert.
1495         (tui_add_content_elements): Remove.
1496         (tui_data_window): Update.
1497         (tui_free_data_content): Remove.
1498         (free_content_elements): Remove DATA_WIN case.
1499
1500 2019-06-25  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-data.c (tui_data_item_window): Update.
1503         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1504         * tui/tui-windata.c (tui_display_all_data)
1505         (tui_display_data_from_line): Update.
1506         (tui_check_data_values): Remove.
1507         * tui/tui-regs.c (tui_show_register_group)
1508         (tui_display_reg_element_at_line): Update.
1509         * tui/tui-hooks.c (tui_register_changed)
1510         (tui_refresh_frame_and_register_information): Call
1511         tui_check_register_values.
1512         * tui/tui-data.h (struct tui_data_window) <data_content,
1513         data_content_count, data_type>: Remove.
1514         (enum tui_data_type): Remove.
1515
1516         * tui/tui-data.c (tui_data_window::clear_detail)
1517         (~tui_data_window): Update.
1518
1519 2019-06-25  Tom Tromey  <tom@tromey.com>
1520
1521         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1522         declare.
1523         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1524         Rename from tui_first_data_item_displayed.  Update.
1525         (tui_data_window::refresh_all)
1526         (tui_data_window::do_scroll_vertical): Update.
1527         * tui/tui-data.h (struct tui_data_window)
1528         <first_data_item_displayed>: Declare new method.
1529
1530 2019-06-25  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1533         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1534         contents...
1535         (tui_initialize_static_data): ...here.
1536
1537 2019-06-25  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1540         (tui_display_registers_from, tui_check_register_values): Update.
1541         (tui_display_register): Remove win_info parameter; update.
1542         (tui_get_register): Change type of parameters.
1543         * tui/tui-data.h (struct tui_data_element): Remove.
1544         (union tui_which_element) <data>: Remove.
1545         <data_window>: Change type.
1546         (struct tui_data_item_window): New.
1547         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1548         case.  Add assert.
1549         (~tui_data_item_window): New destructor.
1550         (free_content_elements): Remove DATA_ITEM_WIN case.
1551
1552 2019-06-25  Tom Tromey  <tom@tromey.com>
1553
1554         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1555         Remove.
1556
1557 2019-06-25  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-data.h (struct tui_command_element): Remove.
1560         (union tui_which_element) <command>: Remove.
1561         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1562         assert.
1563         (free_content_elements): Remove CMD_WIN case.
1564
1565 2019-06-25  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-layout.c (tui_set_layout): Update.
1568         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1569         * tui/tui-data.c (layout_def): Update.
1570
1571 2019-06-25  Tom Tromey  <tom@tromey.com>
1572
1573         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1574         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1575         (tui_source_window_base::set_new_height): Update.
1576         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1577         Update.
1578         (tui_set_locator_fullname, tui_set_locator_info)
1579         (tui_show_frame_info): Update.
1580         * tui/tui-source.c (tui_set_source_content)
1581         (tui_source_is_displayed): Update.
1582         * tui/tui-layout.c (show_source_disasm_command, show_data)
1583         (show_source_or_disasm_and_command): Update.
1584         * tui/tui-disasm.c (tui_set_disassem_content)
1585         (tui_get_begin_asm_address): Update.
1586         * tui/tui-data.h (struct tui_locator_element): Remove.
1587         (union tui_which_element) <locator>: Remove.
1588         (struct tui_locator_window): New.
1589         (tui_locator_win_info_ptr): Change return type.
1590         * tui/tui-data.c (_locator): Change type.
1591         (tui_locator_win_info_ptr): Change return type.
1592         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1593         (tui_alloc_content): Add assert.
1594
1595 2019-06-25  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-winsource.c
1598         (tui_exec_info_window::maybe_allocate_content): New method.
1599         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1600         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1601         (make_source_or_disasm_window): Add cast.
1602         * tui/tui-data.h (union tui_which_element) <simple_string>:
1603         Remove.
1604         (struct tui_source_info): New.
1605         (struct tui_source_window_base) <execution_info>: Change type.
1606         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1607         case, and add assert.
1608         (tui_alloc_content): Add assert.
1609
1610 2019-06-25  Tom Tromey  <tom@tromey.com>
1611
1612         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1613         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1614         * tui/tui-data.c (tui_alloc_win_info): Remove.
1615
1616 2019-06-25  Tom Tromey  <tom@tromey.com>
1617
1618         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1619         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1620         can_highlight.
1621
1622 2019-06-25  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1625         make_visible_with_new_height method.
1626         (tui_win_info::make_visible_with_new_height): New method.
1627         (tui_source_window_base::do_make_visible_with_new_height)
1628         (tui_data_window::do_make_visible_with_new_height)
1629         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1630         (make_visible_with_new_height): Remove.
1631         (tui_resize_all, tui_adjust_win_heights): Use
1632         make_visible_with_new_height method.
1633         * tui/tui-data.h (struct tui_win_info)
1634         <do_make_visible_with_new_height, make_visible_with_new_height>:
1635         New methods.
1636         (struct tui_source_window_base, struct tui_data_window)
1637         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1638         methods.
1639
1640 2019-06-25  Tom Tromey  <tom@tromey.com>
1641
1642         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1643         method.
1644         (update_tab_width): Call update_tab_width method.
1645         * tui/tui-data.h (struct tui_win_info)
1646         (struct tui_source_window_base) <update_tab_width>: New methods.
1647
1648 2019-06-25  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1651         parameter.
1652         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1653         parameter.
1654         (tui_gen_win_info::make_visible): Update.
1655         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1656         parameter.
1657         * tui/tui-data.h (enum tui_box): New enum.
1658         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1659
1660 2019-06-25  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1663         init_and_make_win for EXEC_INFO_WIN.
1664         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1665         longer inline.
1666         (struct tui_win_info) <~tui_win_info>: Inline.
1667         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1668         Don't declare.
1669         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1670         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1671         Remove.
1672         (tui_initialize_static_data): Update.
1673         (~tui_gen_win_info): Handle more cleanup here.
1674         (~tui_source_window_base): Delete "execution_info".
1675         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1676
1677 2019-06-25  Tom Tromey  <tom@tromey.com>
1678
1679         * tui/tui-layout.c (make_command_window): Don't set
1680         can_highlight.
1681         (show_source_disasm_command): Call the reset method.
1682         (show_data): Don't set can_highlight.  Call the reset method.
1683         (tui_gen_win_info::reset): Rename from init_gen_win_info
1684         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1685         (show_source_or_disasm_and_command): Call the reset method.
1686         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1687         (struct tui_cmd_window): Set can_highlight.
1688
1689 2019-06-25  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1692         from make_visible.
1693         (tui_make_visible, tui_make_invisible): Rewrite.
1694         (tui_win_info::make_visible): Remove.
1695         (tui_source_window_base::make_visible): Update.
1696         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1697         method.  Moved from...
1698         (struct tui_win_info) <make_visible>: ...here.
1699
1700 2019-06-25  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-winsource.c
1703         (tui_source_window_base::do_scroll_horizontal): Remove direction
1704         parameter.
1705         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1706         direction parameter.
1707         * tui/tui-win.c (tui_win_info::forward_scroll)
1708         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1709         (tui_win_info::right_scroll): Update.
1710         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1711         direction parameter.
1712         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1713         direction parameter.
1714         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1715         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1716         Remove direction parameter.
1717         (struct tui_source_window_base, struct tui_source_window)
1718         (struct tui_disasm_window, struct tui_data_window)
1719         (struct tui_cmd_window): Update.
1720
1721 2019-06-25  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-winsource.h (tui_set_exec_info_content)
1724         (tui_show_exec_info_content, tui_erase_exec_info_content)
1725         (tui_clear_exec_info_content, tui_update_exec_info): Change
1726         argument to tui_source_window_base.
1727         * tui/tui-winsource.c (tui_set_exec_info_content)
1728         (tui_show_exec_info_content, tui_erase_exec_info_content)
1729         (tui_clear_exec_info_content, tui_update_exec_info): Change
1730         argument to tui_source_window_base.
1731
1732 2019-06-25  Tom Tromey  <tom@tromey.com>
1733
1734         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1735         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1736
1737 2019-06-25  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1740         check.
1741
1742 2019-06-25  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1745         type to void.
1746         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1747         type to void.
1748         * tui/tui-source.c (tui_set_source_content): Update.
1749         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1750
1751 2019-06-25  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-win.c (window_name_completer, tui_set_focus)
1754         (tui_all_windows_info): Use name method.
1755         * tui/tui-data.h (struct tui_gen_win_info)
1756         (struct tui_source_window, struct tui_disasm_window)
1757         (struct tui_data_window, struct tui_cmd_window) <name>: New
1758         method.
1759         (tui_win_name): Don't declare.
1760         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1761         (tui_win_name): Remove.
1762
1763 2019-06-25  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-winsource.h (tui_update_source_window)
1766         (tui_update_source_window_as_is): Change parameter type.
1767         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1768         to be a tui_source_window_base.
1769         (tui_update_source_window_as_is): Likewise.
1770         * tui/tui-win.c (make_visible_with_new_height): Update.
1771
1772 2019-06-25  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-winsource.c (tui_erase_source_content)
1775         (tui_show_source_content, tui_show_exec_info_content)
1776         (tui_erase_exec_info_content): Use refresh_window method.
1777         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1778         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1779         from tui_refresh_win.
1780         (tui_data_window::refresh_window): New method.
1781         (tui_win_info::refresh, tui_source_window_base::refresh)
1782         (tui_refresh_all): Use refresh_window method.
1783         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1784         method.
1785         * tui/tui-regs.c (tui_display_register): Call refresh_window
1786         method.
1787         * tui/tui-layout.c (show_source_disasm_command)
1788         (show_source_or_disasm_and_command): Call refresh_window method.
1789         * tui/tui-data.h (struct tui_gen_win_info)
1790         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1791         New method.
1792
1793 2019-06-25  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui.c (tui_rl_other_window, tui_enable)
1796         (tui_is_window_visible, tui_get_command_dimension): Update.
1797         * tui/tui-winsource.c (tui_update_source_window_as_is)
1798         (tui_clear_source_content, tui_erase_source_content)
1799         (tui_show_source_line, tui_source_window_base::refill)
1800         (tui_source_window_base::do_scroll_horizontal)
1801         (tui_source_window_base::set_is_exec_point_at)
1802         (tui_update_breakpoint_info, tui_set_exec_info_content)
1803         (tui_alloc_source_buffer, tui_line_is_displayed)
1804         (tui_addr_is_displayed): Update.
1805         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1806         (tui_check_and_display_highlight_if_needed)
1807         (tui_win_info::make_visible, tui_win_info::refresh)
1808         (tui_refresh_all): Update.
1809         * tui/tui-windata.c (tui_first_data_item_displayed)
1810         (tui_delete_data_content_windows, tui_erase_data_content)
1811         (tui_display_all_data, tui_data_window::refresh_all)
1812         (tui_check_data_values): Update.
1813         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1814         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1815         (tui_win_info::backward_scroll, tui_refresh_all_win)
1816         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1817         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1818         (tui_source_window_base::set_new_height)
1819         (tui_data_window::set_new_height)
1820         (make_invisible_and_set_new_height)
1821         (make_visible_with_new_height, new_height_ok)
1822         (parse_scrolling_args): Update.
1823         * tui/tui-stack.c (tui_show_frame_info): Update.
1824         * tui/tui-source.c (tui_set_source_content)
1825         (tui_set_source_content_nil, tui_source_is_displayed)
1826         (tui_source_window::do_scroll_vertical): Update.
1827         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1828         (tui_display_registers_from, tui_display_reg_element_at_line)
1829         (tui_check_register_values, tui_reg_command): Update.
1830         * tui/tui-layout.c (tui_default_win_height)
1831         (show_source_disasm_command, show_data, init_and_make_win)
1832         (show_source_or_disasm_and_command): Update.
1833         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1834         (tui_redisplay_readline, tui_mld_flush)
1835         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1836         (tui_getc): Update.
1837         * tui/tui-disasm.c (tui_set_disassem_content)
1838         (tui_disasm_window::do_scroll_vertical): Update.
1839         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1840         Now virtual.
1841         (struct tui_win_info): Derive from tui_gen_win_info.
1842         <~tui_win_info>: Mark as override.
1843         <generic>: Remove member.
1844         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1845         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1846         (~tui_data_window, ~tui_win_info)
1847         (tui_free_all_source_wins_content): Update.
1848         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1849
1850 2019-06-25  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-layout.c (init_and_make_win): Use new.
1853         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1854         destructor, initializers.
1855         (tui_alloc_generic_win_info): Don't declare.
1856         * tui/tui-data.c (_locator): Add argument to constructor.
1857         (source_win, disasm_win): New globals.
1858         (exec_info): Remove.
1859         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1860         Update.
1861         (tui_alloc_generic_win_info): Remove.
1862         (init_content_element): Use new.
1863         (tui_win_info::tui_win_info): Update.
1864         (free_content_elements) <case DATA_WIN>: Use delete.
1865
1866 2019-06-25  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1869         * tui/tui-windata.c (tui_first_data_item_displayed)
1870         (tui_delete_data_content_windows): Update.
1871         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1872         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1873         (tui_display_registers_from, tui_check_register_values): Update.
1874         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1875         pointer.
1876         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1877         window.
1878         (tui_free_data_content): Update.
1879         (free_content_elements) <case DATA_WIN>: Free the window.
1880
1881 2019-06-25  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1884         Update.
1885         * tui/tui-layout.c (make_command_window)
1886         (show_source_disasm_command, show_data, init_and_make_win)
1887         (show_source_or_disasm_and_command): Update.
1888         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1889         method.
1890         <can_highight, is_highlighted>: Now bool.
1891         (tui_set_win_highlight): Don't declare.
1892         * tui/tui-data.c (tui_set_win_highlight): Remove.
1893
1894 2019-06-25  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-wingeneral.c (make_visible): Remove check of window
1897         type.
1898
1899 2019-06-25  Tom Tromey  <tom@tromey.com>
1900
1901         * tui/tui-win.c (tui_win_info::max_height)
1902         (tui_cmd_window::max_height): New methods.
1903         (new_height_ok): Call max_height.
1904         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1905         <max_height>: New method.
1906
1907 2019-06-25  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-win.c (tui_source_window_base::set_new_height)
1910         (tui_data_window::set_new_height): New methods.
1911         (make_invisible_and_set_new_height): Call set_new_height method.
1912         * tui/tui-data.h (struct tui_win_info)
1913         (struct tui_source_window_base, struct tui_data_window)
1914         <set_new_height>: New method.
1915
1916 2019-06-25  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1919         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1920         tui_refresh_data_win.
1921         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1922         method.
1923         (tui_refresh_all_win): Call the refresh_all method.
1924         (tui_set_focus): Likewise.
1925         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1926         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1927         Likewise.
1928
1929 2019-06-25  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-winsource.h (tui_refill_source_window)
1932         (tui_set_is_exec_point_at): Don't declare.
1933         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1934         (tui_source_window_base::refill): Rename from
1935         tui_refill_source_window.
1936         (tui_source_window_base::do_scroll_horizontal): Update.
1937         (tui_source_window_base::set_is_exec_point_at): Rename from
1938         tui_set_is_exec_point_at.
1939         (tui_update_all_breakpoint_info): Update.
1940         * tui/tui-stack.c (tui_show_frame_info): Update.
1941         * tui/tui-layout.c (show_data): Add cast.
1942         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1943         * tui/tui-data.h (struct tui_source_window_base) <refill,
1944         set_is_exec_point_at>: New methods.
1945         (tui_source_windows, tui_add_to_source_windows): Update types.
1946         (tui_add_to_source_windows): Remove redundant declaration.
1947         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1948         (tui_source_windows): Change return type.
1949         (tui_clear_source_windows_detail): Update.
1950         (tui_add_to_source_windows): Change type of parameter.
1951         (tui_free_all_source_wins_content): Update.
1952
1953 2019-06-25  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-wingeneral.c (tui_win_info::refresh)
1956         (tui_source_window_base::refresh): New methods.
1957         (tui_refresh_all): Call the refresh method.
1958         * tui/tui-data.h (struct tui_win_info)
1959         (struct tui_source_window_base) <refresh>: New method.
1960
1961 2019-06-25  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui.h (tui_is_window_visible): Return bool.
1964         * tui/tui.c (tui_is_window_visible): Return bool.
1965         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1966         (tui_make_visible, tui_make_invisible)
1967         (tui_win_info::make_visible)
1968         (tui_source_window_base::make_visible, make_all_visible)
1969         (tui_make_all_visible, tui_make_all_invisible): Update.
1970         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1971         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1972         bool.
1973         (struct tui_win_info, struct tui_source_window_base)
1974         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1975         * tui/tui-data.c (tui_init_generic_part): Update.
1976
1977 2019-06-25  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1980         (tui_source_window_base::make_visible): New methods.
1981         (make_all_visible): Make method call.
1982         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1983         (struct tui_source_window_base, struct tui_cmd_window): Override
1984         make_visible.
1985         (tui_win_is_source_type): Don't declare.
1986         * tui/tui-data.c (tui_win_is_source_type): Remove.
1987
1988 2019-06-25  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1991         NULL check.
1992
1993 2019-06-25  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1996         Inline constructor.  Add initializers for members.
1997         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1998         constructors; now inline in class.
1999
2000 2019-06-25  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-regs.c (tui_show_registers): Update.
2003         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2004         bool.
2005         * tui/tui-data.c (tui_data_window::clear_detail)
2006         (tui_data_window): Update.
2007
2008 2019-06-25  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-windata.c (tui_display_all_data)
2011         (tui_display_data_from_line, tui_display_data_from)
2012         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2013         Update.
2014         * tui/tui-regs.c (tui_last_regs_line_no)
2015         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2016         (tui_show_registers, tui_show_register_group)
2017         (tui_display_registers_from, tui_display_reg_element_at_line)
2018         (tui_display_registers_from_line, tui_check_register_values)
2019         (tui_reg_next, tui_reg_prev): Update.
2020         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2021         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2022         tui_data_window.
2023         (struct tui_win_info) <detail>: Remove.  Add new fields from
2024         tui_data_info.
2025         (TUI_DATA_WIN): Add cast.
2026         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2027         (~tui_data_window): Simplify.
2028
2029 2019-06-25  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-layout.c (show_source_disasm_command)
2032         (show_source_or_disasm_and_command): Update.
2033         * tui/tui-io.c (update_cmdwin_start_line)
2034         (tui_redisplay_readline): Update.
2035         * tui/tui-data.h (struct tui_command_info): Remove.
2036         (struct tui_win_info) <detail>: Remove command_info member.
2037         (struct tui_data_window) <start_line>: New member, from
2038         tui_command_info.
2039         (TUI_CMD_WIN): Add casts.
2040
2041 2019-06-25  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-winsource.c (tui_update_source_window)
2044         (tui_refill_source_window)
2045         (tui_source_window_base::do_scroll_horizontal)
2046         (tui_update_breakpoint_info, tui_set_exec_info_content)
2047         (tui_show_exec_info_content, tui_erase_exec_info_content)
2048         (tui_clear_exec_info_content): Update.
2049         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2050         Update.
2051         * tui/tui-win.c (make_invisible_and_set_new_height)
2052         (make_visible_with_new_height): Update.
2053         * tui/tui-source.c (tui_set_source_content)
2054         (tui_show_symtab_source): Update.
2055         * tui/tui-layout.c (extract_display_start_addr)
2056         (show_source_disasm_command, show_data)
2057         (make_source_or_disasm_window)
2058         (show_source_or_disasm_and_command): Update.
2059         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2060         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2061         "gdbarch".
2062         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2063         to tui_source_window_base.
2064         (struct tui_win_info) <detail>: Remove source_info member.
2065         (struct tui_source_window_base) <has_locator>: Inline.
2066         Move contents from tui_source_info; rename has_locator member to
2067         m_has_locator.
2068         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2069         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2070         header file.
2071         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2072         Simplify.
2073         (tui_free_all_source_wins_content): Cast to
2074         tui_source_window_base.
2075
2076 2019-06-25  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-win.c (make_invisible_and_set_new_height)
2079         (make_visible_with_new_height): Call has_locator method.
2080         * tui/tui-layout.c (show_source_disasm_command, show_data)
2081         (show_source_or_disasm_and_command): Update for bool change.
2082         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2083         (tui_win_info) <has_locator>: New method.
2084         (struct tui_source_window_base) <has_locator>: New method.
2085         (tui_win_has_locator): Don't declare.
2086         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2087         from tui_win_has_locator.
2088         (tui_source_window_base): Use false, not FALSE.
2089
2090 2019-06-25  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2093         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2094         clear_detail method directly.
2095         (tui_clear_win_detail): Remove.
2096
2097 2019-06-25  Tom Tromey  <tom@tromey.com>
2098
2099         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2100         "this", not TUI_DISASM_WIN.
2101
2102 2019-06-25  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2105         declare.
2106         * tui/tui-winsource.c
2107         (tui_source_window_base::do_scroll_horizontal): Rename from
2108         tui_horizontal_source_scroll.
2109         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2110         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2111         from tui_vertical_data_scroll.
2112         * tui/tui-win.h (tui_scroll): Don't declare.
2113         * tui/tui-win.c (tui_win_info::forward_scroll)
2114         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2115         (tui_win_info::right_scroll): Rename and update.
2116         (tui_scroll_forward_command, tui_scroll_backward_command)
2117         (tui_scroll_left_command, tui_scroll_right_command): Update.
2118         (tui_scroll): Remove.
2119         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2120         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2121         from tui_vertical_source_scroll.
2122         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2123         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2124         from tui_vertical_disassem_scroll.
2125         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2126         do_scroll_horizontal>: New methods.
2127         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2128         Likewise.
2129         (struct tui_source_window_base): Add do_scroll_horizontal.
2130         (struct tui_source_window, struct tui_disasm_window): Add
2131         do_scroll_vertical.
2132         (struct tui_data_window, struct tui_cmd_window): Add
2133         do_scroll_horizontal and do_scroll_vertical.
2134         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2135
2136 2019-06-25  Tom Tromey  <tom@tromey.com>
2137
2138         * tui/tui-data.h (struct tui_source_window_base): New struct.
2139         (struct tui_source_window): Derive from tui_source_window_base.
2140         (struct tui_disasm_window): New struct.
2141         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2142         from tui_source_window::clear_detail.
2143         (tui_source_window_base): Rename from tui_source_window.
2144         (~tui_source_window_base): Rename from ~tui_source_window.
2145         (tui_alloc_win_info): Create a tui_disasm_window.
2146
2147 2019-06-25  Tom Tromey  <tom@tromey.com>
2148
2149         * tui/tui-data.h (struct tui_source_window)
2150         (struct tui_data_window): Declare destructors.
2151         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2152         destructors.
2153         (tui_win_info): Simplify.
2154
2155 2019-06-25  Tom Tromey  <tom@tromey.com>
2156
2157         * tui/tui-winsource.c (tui_display_main)
2158         (tui_update_source_windows_with_addr)
2159         (tui_update_all_breakpoint_info): Update.
2160         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2161         (new_height_ok, parse_scrolling_args): Update.
2162         * tui/tui-stack.c (tui_show_frame_info): Update.
2163         * tui/tui-data.h (struct tui_list): Remove.
2164         (tui_source_windows): Return a reference to a std::vector.
2165         * tui/tui-data.c (source_windows): Now a std::vector.
2166         (tui_source_windows): Change return type.
2167         (tui_clear_source_windows): Rewrite.
2168         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2169         (tui_free_all_source_wins_content): Rewrite.
2170
2171 2019-06-25  Tom Tromey  <tom@tromey.com>
2172
2173         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2174         (struct tui_data_window, struct tui_cmd_window): Declare
2175         clear_detail method.
2176         * tui/tui-data.c (tui_source_window::clear_detail)
2177         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2178         methods.
2179         (tui_clear_win_detail): Simplify.
2180
2181 2019-06-25  Tom Tromey  <tom@tromey.com>
2182
2183         * tui/tui-layout.c (make_source_window, make_disasm_window)
2184         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2185         Return the new window.
2186         (show_source_disasm_command, show_data)
2187         (show_source_or_disasm_and_command): Update.
2188
2189 2019-06-25  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2192         parameter.  Return the new window.
2193         (show_source_disasm_command): Update and remove NULL check.
2194         (show_source_or_disasm_and_command): Update.
2195
2196 2019-06-25  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2199
2200 2019-06-25  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-data.h (struct tui_win_info): Make constructor
2203         protected.  Make destructor virtual.  Add initializers.
2204         (tui_source_window, tui_data_window, tui_cmd_window): New
2205         classes.
2206         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2207         constructor.  Add "type" parameter.
2208         (tui_source_window, tui_data_window, tui_cmd_window): New
2209         constructors.
2210         (tui_alloc_win_info): Instantiate the appropriate subclass.
2211
2212 2019-06-25  Tom Tromey  <tom@tromey.com>
2213
2214         * tui/tui-win.c (tui_resize_all): Use delete.
2215         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2216         destructor.
2217         (tui_free_window): Don't declare.
2218         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2219         Update.
2220
2221 2019-06-25  Tom Tromey  <tom@tromey.com>
2222
2223         * tui/tui-data.h (struct tui_win_info): Add constructor.
2224         * tui/tui-data.c (tui_alloc_win_info): Use new.
2225         (tui_free_window): Use delete.
2226
2227 2019-06-22  Tom Tromey  <tom@tromey.com>
2228
2229         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2230         declare.
2231         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2232
2233 2019-06-22  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2236         declare.
2237         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2238
2239 2019-06-22  Tom de Vries  <tdevries@suse.de>
2240
2241         * dwarf2read.c (create_addrmap_from_aranges)
2242         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2243         instead of '%zu'.
2244
2245 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2246
2247         * dwarf2read.h (dwarf2_section_info_def): Remove.
2248         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2249         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2250         std::vector<dwarf2_section_info>.
2251         (struct dwo_file) <~dwo_file>: Remove.
2252         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2253         types field.
2254         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2255         (dwarf2_read_debug_names): Likewise.
2256         (create_debug_types_hash_table): Change parameter type to
2257         array_view, adjust code accordingly.
2258         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2259         (partial_die_info::fixup): Likewise.
2260         (determine_prefix): Likewise.
2261         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2262
2263 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2264
2265         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2266         gdb_bfd_ref_ptr.
2267         <~dwo_file>: Remove call to gdb_bfd_unref.
2268         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2269         gdb_bfd_ref_ptr::get.
2270
2271 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2272
2273         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2274         type to htab_up.
2275         * dwarf2read.c (struct dwo_file): Initialize fields.
2276         <~dwo_file>: New.
2277         (free_dwo_file): Remove, move content to ~dwo_file.
2278         (struct dwo_file_deleter): Remove.
2279         (dwo_file_up>: Remove custom deleter.
2280         (free_dwo_files): Remove.
2281         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2282         dwo_files.
2283         (process_skeletonless_type_units): Call unique_ptr::get.
2284         (allocate_dwo_file_hash_table): Add deleter to created hash
2285         table.  Change return type to htab_up.
2286         (lookup_dwo_file_slot): Don't memset dwo_file, call
2287         unique_ptr::get.
2288         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2289         (create_dwo_unit_in_dwp_v2): Likewise.
2290         (open_and_init_dwo_file): Likewise.
2291         (free_dwo_file_from_slot): Remove.
2292
2293 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2294
2295         * dwarf2read.h (struct dwarf2_section_info) <readin,
2296         is_virtual>: Change type to bool.
2297         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2298         true instead of 1.
2299
2300 2019-06-19  Tom Tromey  <tom@tromey.com>
2301
2302         * tui/tui-data.h (tui_init_content_element): Don't declare.
2303
2304 2019-06-19  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui-data.h (tui_init_win_info): Don't declare.
2307
2308 2019-06-19  Tom de Vries  <tdevries@suse.de>
2309
2310         * dwarf2read.h (abstract_to_concrete): Change type to
2311         std::unordered_map<sect_offset, std::vector<sect_offset>,
2312         gdb::hash_enum<sect_offset>>.
2313
2314 2019-06-19  Tom Tromey  <tromey@adacore.com>
2315
2316         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2317         EVAL_AVOID_SIDE_EFFECTS specially.
2318
2319 2019-06-19  Tom Tromey  <tromey@adacore.com>
2320
2321         * source-cache.c (highlighter): New global.
2322         (source_cache::get_source_lines): Create a highlighter on demand.
2323
2324 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2325
2326         * defs.h (deprecated_interactive_hook): Delete declaration.
2327         * interps.c (clear_interpreter_hooks): Remove use of
2328         deprecated_interactive_hook.
2329         * top.c (deprecated_interactive_hook): Delete definition.
2330         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2331
2332 2019-06-18  Tom de Vries  <tdevries@suse.de>
2333
2334         PR gdb/24515
2335         * dwarf2read.h (abstract_to_concrete): Change type from
2336         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2337         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2338         * dwarf2read.c (read_variable): Update.
2339         (dwarf2_fetch_die_loc_sect_off): Update.
2340
2341 2019-06-17  Tom de Vries  <tdevries@suse.de>
2342
2343         PR gdb/24617
2344         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2345         accessing parent[parent_len - 1].
2346
2347 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2348
2349         PR gdb/24364
2350         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2351         call dtrace_process_dof with NULL dof.
2352
2353 2019-06-16  Tom de Vries  <tdevries@suse.de>
2354
2355         PR gdb/24445
2356         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2357
2358 2019-06-16  Tom Tromey  <tom@tromey.com>
2359
2360         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2361         (make_all_visible): Use address of member.
2362
2363 2019-06-16  Tom Tromey  <tom@tromey.com>
2364
2365         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2366         (tui_free_window, free_content, free_content_elements): Remove
2367         unnecessary cast.
2368         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2369         cast.
2370         * tui/tui-regs.c (tui_show_register_group)
2371         (tui_display_registers_from, tui_display_reg_element_at_line):
2372         Remove unnecessary cast.
2373
2374 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2375
2376         * linux-nat.c (normal_mask): Delete.
2377         (_initialize_linux_nat): Don't initialise normal_mask.
2378
2379 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2380
2381         PR gdb/24445
2382         * dwarf-index-write.h (write_psymtabs_to_index): Add
2383         dwz_basename parameter.
2384         * dwarf-index-write.c (write_gdbindex): Move file writing to
2385         write_gdbindex_1.  Change return type void.
2386         (assert_file_size): Move up, remove filename parameter.
2387         (write_gdbindex_1): New function.
2388         (write_debug_names): Change return type to void, call
2389         assert_file_size.
2390         (struct index_wip_file): New struct.
2391         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2392         file logic to index_wip_file.  Write index for dwz file if
2393         needed.
2394         (save_gdb_index_command): Pass basename of dwz file, if present.
2395         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2396         build-id of dwz file, if present.
2397         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2398         (dwarf2_get_dwz_file): Likewise.
2399         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2400         (dwarf2_get_dwz_file): Likewise.
2401
2402 2019-06-16  Tom Tromey  <tom@tromey.com>
2403
2404         * coffread.c (process_coff_symbol): Use xstrdup.
2405         * value.c (create_internalvar): Use xstrdup.
2406
2407 2019-06-16  Tom Tromey  <tom@tromey.com>
2408
2409         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2410         * breakpoint.c (stopin_command, stopat_command)
2411         (until_break_command, decode_location_default): Remove unnecessary
2412         cast.
2413         * utils.c (subset_compare): Remove unnecessary cast.
2414         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2415         cast.
2416         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2417         cast.
2418         * infcmd.c (path_command): Remove unnecessary cast.
2419         * coffread.c (decode_type): Remove unnecessary cast.
2420         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2421         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2422         * tui/tui-stack.c (tui_show_locator_content)
2423         (tui_show_frame_info): Remove unnecessary cast.
2424         * tui/tui-win.c (tui_scroll_forward_command)
2425         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2426         (parse_scrolling_args): Remove unnecessary cast.
2427         * tui/tui-data.c (init_win_info, tui_del_window)
2428         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2429         (free_content_elements): Remove unnecessary cast.
2430         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2431         unnecessary cast.
2432         * tui/tui-source.c (tui_set_source_content)
2433         (tui_vertical_source_scroll): Remove unnecessary cast.
2434         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2435         cast.
2436         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2437         * tui/tui-regs.c (tui_display_registers_from)
2438         (tui_display_register): Remove unnecessary cast.
2439         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2440         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2441         (make_visible): Remove unnecessary cast.
2442         * tui/tui-winsource.c (tui_erase_source_content)
2443         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2444         unnecessary cast.
2445         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2446         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2447         * stabsread.c (read_type, read_array_type, read_range_type):
2448         Remove unnecessary cast.
2449         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2450         (parse_symbol, parse_type, upgrade_type, parse_external)
2451         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2452         unnecessary cast.
2453         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2454
2455 2019-06-16  Tom Tromey  <tom@tromey.com>
2456
2457         * tui/tui-data.c (tui_alloc_generic_win_info)
2458         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2459         checks.
2460
2461 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2462             Andrew Burgess  <andrew.burgess@embecosm.com>
2463
2464         * f-typeprint.c (f_print_type): Don't return early for not
2465         associated or not allocated types.
2466         (f_type_print_varspec_suffix): Add print_rank parameter and print
2467         ranks of array types in case they dangling.
2468         (f_type_print_base): Add print_rank parameter.
2469
2470 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2471
2472         * NEWS: Mention new MI commands.
2473         * break-catch-throw.c (enum exception_event_kind): Move to
2474         breakpoint.h.
2475         (print_mention_exception_catchpoint): Output text as a single
2476         message.
2477         (catch_exception_command_1): Rename to...
2478         (catch_exception_event): ...this, make non-static, update header
2479         command, and change some parameter types.
2480         (catch_catch_command): Update for changes to
2481         catch_exception_command_1.
2482         (catch_throw_command): Likewise.
2483         (catch_rethrow_command): Likewise.
2484         * breakpoint.c (enum exception_event_kind): Delete.
2485         * breakpoint.h (enum exception_event_kind): Moved here from
2486         break-catch-throw.c.
2487         (catch_exception_event): Declare.
2488         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2489         (mi_cmd_catch_throw): New function.
2490         (mi_cmd_catch_rethrow): New function.
2491         (mi_cmd_catch_catch): New function.
2492         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2493         'catch-catch' entries.
2494         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2495         (mi_cmd_catch_rethrow): Declare.
2496         (mi_cmd_catch_catch): Declare.
2497
2498 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2499
2500         * annotate.c (annotate_source_line): Change return type to void,
2501         update implementation to match.
2502         * annotate.h (annotate_source_line): Change return type to void,
2503         update header comment.
2504         * stack.c (print_frame_info): Don't change what frame information
2505         is printed based on whether annotations are on or not.
2506
2507 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2508
2509         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2510         (annotate_source): Make static.
2511         (annotate_source_line): Moved from source.c and renamed from
2512         identify_source_line.  Update the return type.
2513         * annotate.h (annotate_source): Delete declaration.
2514         (annotate_source_line): Declaration moved from source.h, and
2515         renamed from identify_source_line.  Return type updated.
2516         * source.c (identify_source_line): Moved to annotate.c and renamed
2517         to annotate_source_line.
2518         (info_line_command): Remove check of annotation_level.
2519         * source.h (identify_source_line): Move declaration to annotate.h
2520         and rename to annotate_source_line.
2521         * stack.c: Add 'annotate.h' include.
2522         (print_frame_info): Remove check of annotation_level before
2523         calling annotate_source_line.
2524
2525 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2526
2527         * source-cache.c (source_cache::get_plain_source_lines): Use
2528         open_source_file_with_line_charpos instead of just
2529         open_source_file, remove call to find_source_lines.
2530         (source_cache::get_source_lines): Likewise.
2531         * source.c (find_source_lines): Make static.
2532         (get_filename_and_charpos): Renamed into...
2533         (open_source_file_with_line_charpos): ..this along with changes to
2534         return a scoped_fd, and some other minor clean ups.
2535         (identify_source_line): Use open_source_file_with_line_charpos.
2536         (search_command_helper): Use open_source_file_with_line_charpos
2537         instead of just open_source_file, remove call to
2538         find_source_lines.
2539         * source.h (open_source_file_with_line_charpos): Declare new
2540         function.
2541         (find_source_lines): Delete declaration.
2542
2543 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2544
2545         * source.c (get_filename_and_charpos): Remove fullname
2546         parameter.
2547         (identify_source_line): Update call to get_filename_and_charpos.
2548
2549 2019-06-14  Tom Tromey  <tromey@adacore.com>
2550
2551         PR gdb/24502:
2552         * ui-style.h (skip_ansi_escape): Update comment.
2553         * ui-file.h (class no_terminal_escape_file): New class.
2554         * ui-file.c (no_terminal_escape_file::write)
2555         (no_terminal_escape_file::puts): New methods.
2556         * cli/cli-logging.c (handle_redirections): Use
2557         no_terminal_escape_file.
2558
2559 2019-06-14  Tom Tromey  <tromey@adacore.com>
2560
2561         * NEWS: Move convenience variable news above Python news.
2562
2563 2019-06-14  Tom Tromey  <tom@tromey.com>
2564
2565         * gnulib: Move directory to top-level.
2566         * configure.ac: Don't configure gnulib.
2567         * configure: Rebuild.
2568         * common/common-defs.h: Use new path to gnulib.
2569         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2570         (GNULIB_H): Remove.
2571         (INCGNU): Look in new gnulib location.
2572         (HFILES_NO_SRCDIR): Remove gnulib files.
2573         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2574         (generated_files): Remove GNULIB_H.
2575         ($(LIBGNU), all-lib): Remove targets.
2576         (distclean): Don't mention GNULIB_BUILDDIR.
2577         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2578
2579 2019-06-14  Tom Tromey  <tromey@adacore.com>
2580
2581         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2582         Warn if symbol file does not provide any symbols.
2583
2584 2019-06-14  Tom Tromey  <tromey@adacore.com>
2585
2586         * source.c (find_and_open_source): Respect basenames_may_differ.
2587
2588 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2589
2590         * annotate.c (annotate_breakpoints_invalid): Make use of
2591         scoped_restore_terminal_state.
2592         (annotate_frames_invalid): Likewise.
2593
2594 2019-06-14  Tom Tromey  <tromey@adacore.com>
2595
2596         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2597         allow assignment to an internalvar.
2598
2599 2019-06-14  Tom Tromey  <tromey@adacore.com>
2600
2601         * ada-lex.l: Allow "_" in attribute names.
2602
2603 2019-06-14  Tom Tromey  <tromey@adacore.com>
2604
2605         PR gdb/24653:
2606         * regcache.c (registers_changed): Don't call alloca.
2607         * top.c (execute_command): Don't call alloca.
2608
2609 2019-06-13  Pedro Alves  <palves@redhat.com>
2610
2611         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2612         'expression'.  When parsing an expression, error out if there's
2613         junk after "unlimited".
2614         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2615         (do_set_command): Adjust calls to is_unlimited_literal.
2616
2617 2019-06-13  Pedro Alves  <palves@redhat.com>
2618
2619         * compile/compile.c (make_compile_options_def_group): Add braces
2620         around array_view initializer.
2621         * thread.c (make_thread_apply_all_options_def_group)
2622         (make_thread_apply_all_options_def_group): Likewise.
2623
2624 2019-06-13  Pedro Alves  <palves@redhat.com>
2625
2626         * NEWS (New commands): Mention "maint test-options
2627         require-delimiter", "maint test-options unknown-is-error", "maint
2628         test-options unknown-is-operand" and "maint show
2629         test-options-completion-result".
2630         (New command options, command completion): New section.
2631         (Completion improvements): New section.
2632         Mention that you can abbreviate "unlimited".
2633
2634 2019-06-13  Pedro Alves  <palves@redhat.com>
2635
2636         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2637         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2638         * unittests/cli-utils-selftests.c (test_parse_flags)
2639         (test_parse_flags_qcs): Delete.
2640         (test_cli_utils): Don't call deleted functions.
2641
2642 2019-06-13  Pedro Alves  <palves@redhat.com>
2643
2644         * thread.c: Include "cli/cli-option.h".
2645         (tp_array_compar_ascending): Global.
2646         (tp_array_compar): Delete function.
2647         (tp_array_compar_ascending, tp_array_compar_descending): New
2648         functions.
2649         (ascending_option_def, qcs_flag_option_def)
2650         (thr_qcs_flags_option_defs)
2651         (make_thread_apply_all_options_def_group)
2652         (make_thread_apply_options_def_group): New.
2653         (thread_apply_all_command): Use gdb::option::process_options.
2654         (thread_apply_command_completer)
2655         (thread_apply_all_command_completer): New.
2656         (thread_apply_command): Use gdb::option::process_options.
2657         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2658         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2659         to generate help text of "thread apply".  Adjust "taas"'s help.
2660         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2661         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2662
2663 2019-06-13  Pedro Alves  <palves@redhat.com>
2664
2665         * thread.c (thread_apply_command): Check for invalid TID with
2666         isdigit instead of !isalpha.
2667
2668 2019-06-13  Pedro Alves  <palves@redhat.com>
2669
2670         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2671         (validate_flags_qcs): New.
2672         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2673         (validate_flags_qcs): Declare.
2674         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2675         (make_frame_apply_options_def_group): New.
2676         (frame_apply_command_count): Process options with
2677         gdb::option::process_options.
2678         (frame_apply_completer): New.
2679         (frame_apply_level_completer, frame_apply_all_completer)
2680         (frame_apply_completer): New.
2681         (_initialize_stack): Update help of "frame apply", "frame apply
2682         level", "frame apply all" and "faas" to mention supported options
2683         and install command completers.
2684         * stack.h (frame_apply_all_completer): Declare.
2685         * thread.c: Include "stack.h".
2686         (tfaas_command): Add "--".
2687         (_initialize_thread): Update help "tfaas" to mention supported
2688         options and install command completer.
2689
2690 2019-06-13  Pedro Alves  <palves@redhat.com>
2691
2692         * completer.c (complete_nested_command_line): New.
2693         (gdb_completion_word_break_characters_throw): Add assertion.
2694         * completer.h (complete_nested_command_line): Declare.
2695
2696 2019-06-13  Pedro Alves  <palves@redhat.com>
2697
2698         * stack.c (parse_backtrace_qualifiers): New.
2699         (backtrace_command): Use it.
2700         (backtrace_command_completer): Complete on qualifiers.
2701
2702 2019-06-13  Pedro Alves  <palves@redhat.com>
2703
2704         * frame.c: Include "cli/cli-option.h.
2705         (user_set_backtrace_options): New.
2706         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2707         Delete.
2708         (get_prev_frame): Adjust.
2709         (boolean_option_def, uinteger_option_def)
2710         (set_backtrace_option_defs): New.
2711         (_initialize_frame): Adjust and use
2712         gdb::option::add_setshow_cmds_for_options to install "set
2713         backtrace past-main" and "set backtrace past-entry".
2714         * frame.h: Include "cli/cli-option.h".
2715         (struct frame_print_options): Forward declare.
2716         (print_frame_arguments_all, print_frame_arguments_scalars)
2717         (print_frame_arguments_none): Declare.
2718         (print_entry_values): Delete declaration.
2719         (struct frame_print_options, user_frame_print_options): New.
2720         (struct set_backtrace_options): New.
2721         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2722         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2723         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2724         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2725         (list_args_or_locals): Add frame_print_options parameter.
2726         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2727         * python/py-framefilter.c (enumerate_args): Pass down
2728         USER_FRAME_PRINT_OPTIONS.
2729         * stack.c: Include "cli/cli-option.h".
2730         (print_frame_arguments_all, print_frame_arguments_scalars)
2731         (print_frame_arguments_none): Declare.
2732         (print_raw_frame_arguments, print_entry_values): Delete.
2733         (user_frame_print_options): New.
2734         (boolean_option_def, enum_option_def, frame_print_option_defs):
2735         New.
2736         (struct backtrace_cmd_options): New.
2737         (bt_flag_option_def): New.
2738         (backtrace_command_option_defs): New.
2739         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2740         (print_frame_arg, read_frame_arg, print_frame_args)
2741         (print_frame_info, print_frame): Add frame_print_options parameter
2742         and use it.
2743         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2744         (backtrace_command_1): Add frame_print_options and
2745         backtrace_cmd_options parameters and use them.
2746         (make_backtrace_options_def_group): New.
2747         (backtrace_command): Process command options with
2748         gdb::option::process_options.
2749         (backtrace_command_completer): New.
2750         (_initialize_stack): Extend "backtrace"'s help to mention
2751         supported options.  Install completer for "backtrace".
2752         Install some settings commands with add_setshow_cmds_for_options.
2753
2754 2019-06-13  Pedro Alves  <palves@redhat.com>
2755
2756         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2757         and that "set/show print raw frame-arguments" are now deprecated.
2758
2759         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2760         command.
2761         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2762         * stack.c (_initialize_stack): Install "set/show print
2763         raw-frame-arguments", and deprecate "set/show print raw
2764         frame-arguments".
2765         * valprint.c (_initialize_valprint): Deprecate "set/show print
2766         raw".
2767
2768 2019-06-13  Pedro Alves  <palves@redhat.com>
2769
2770         * compile/compile.c (struct compile_options): New.
2771         (compile_flag_option_def, compile_command_option_defs)
2772         (make_compile_options_def_group): New.
2773         (compile_file_command): Handle options with
2774         gdb::option::process_options.
2775         (compile_file_command_completer): New function.
2776         (compile_code_command): Handle options with
2777         gdb::option::process_options.
2778         (compile_code_command_completer): New function.
2779         (_initialize_compiler): Install completers for "compile code" and
2780         "compile file".  Mention available options in "compile code" and
2781         "compile code"'s help.
2782         * completer.c (advance_to_completion_word): New, factored out from
2783         ...
2784         (advance_to_expression_complete_word_point): ... this.
2785         (advance_to_filename_complete_word_point): New.
2786         * completer.h (advance_to_filename_complete_word_point): New
2787         declaration.
2788
2789 2019-06-13  Pedro Alves  <palves@redhat.com>
2790
2791         * compile/compile.c: Include "cli/cli-option.h".
2792         (compile_print_value): Scope data pointer is now a
2793         value_print_options pointer; adjust.
2794         (compile_print_command): Process options.  Scope data pointer is
2795         now a value_print_options pointer; adjust.
2796         (_initialize_compile): Update "compile print"'s help to include
2797         supported options.  Install a completer for "compile print".
2798         * cp-valprint.c (show_vtblprint, show_objectprint)
2799         (show_static_field_print): Delete.
2800         (_initialize_cp_valprint): Don't install "set print
2801         static-members", "set print vtbl", "set print object" here.
2802         * printcmd.c: Include "cli/cli-option.h" and
2803         "common/gdb_optional.h".
2804         (print_command_parse_format): Rework to fill in a
2805         value_print_options instead of a format_data.
2806         (print_value): Change parameter type from format_data pointer to
2807         value_print_options reference.  Adjust.
2808         (print_command_1): Process options.  Adjust to pass down a
2809         value_print_options.
2810         (print_command_completer): New.
2811         (_initialize_printcmd): Install print_command_completer as
2812         handle_brkchars completer for the "print" command.  Update
2813         "print"'s help to include supported options.
2814         * valprint.c: Include "cli/cli-option.h".
2815         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2816         here from cp-valprint.c.
2817         (boolean_option_def, uinteger_option_def)
2818         (value_print_option_defs, make_value_print_options_def_group):
2819         New.  Use gdb::option::add_setshow_cmds_for_options to install
2820         "set print elements", "set print null-stop", "set print repeats",
2821         "set print pretty", "set print union", "set print array", "set
2822         print address", "set print symbol", "set print array-indexes".
2823         * valprint.h: Include <string> and "cli/cli-option.h".
2824         (make_value_print_options_def_group): Declare.
2825         (print_value): Change parameter type from format_data pointer to
2826         value_print_options reference.
2827         (print_command_completer): Declare.
2828
2829 2019-06-13  Pedro Alves  <palves@redhat.com>
2830
2831         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2832         (COMMON_SFILES): Add maint-test-settings.c.
2833         * cli/cli-decode.c (boolean_enums): New global, factored out from
2834         ...
2835         (add_setshow_boolean_cmd): ... here.
2836         * cli/cli-decode.h (boolean_enums): Declare.
2837         * cli/cli-option.c: New file.
2838         * cli/cli-option.h: New file.
2839         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2840         factored out from ...
2841         (parse_cli_boolean_value(const char *)): ... this.
2842         (is_unlimited_literal): Change parameter type to pointer to
2843         pointer.  Adjust and advance ARG pointer.
2844         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2845         (parse_cli_var_enum): New, factored out from ...
2846         (do_set_command): ... this.  Adjust.
2847         * cli/cli-setshow.h (parse_cli_boolean_value)
2848         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2849         (parse_cli_var_enum): Declare.
2850         * cli/cli-utils.c: Include "cli/cli-option.h".
2851         (get_ulongest): New.
2852         * cli/cli-utils.h (get_ulongest): Declare.
2853         (check_for_argument): New overloads.
2854         * maint-test-options.c: New file.
2855
2856 2019-06-13  Pedro Alves  <palves@redhat.com>
2857
2858         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2859         parse a range if "-" is at the end of the string.
2860
2861 2019-06-13  Pedro Alves  <palves@redhat.com>
2862
2863         * cli/cli-setshow.c (parse_auto_binary_operation)
2864         (parse_cli_boolean_value): Don't allow "o".
2865
2866 2019-06-13  Pedro Alves  <palves@redhat.com>
2867
2868         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2869         * NEWS: Mention maint test-settings KIND.
2870         * maint-test-settings.c: New file.
2871
2872 2019-06-13  Pedro Alves  <palves@redhat.com>
2873
2874         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2875         completer.
2876         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2877         "set" completers.
2878
2879 2019-06-13  Pedro Alves  <palves@redhat.com>
2880
2881         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2882         after item.
2883
2884 2019-06-13  Pedro Alves  <palves@redhat.com>
2885
2886         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2887
2888 2019-06-13  Pedro Alves <palves@redhat.com>
2889
2890         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2891         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2892         call.
2893         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2894         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2895         calls.
2896         (check_for_argument): Skip spaces after argument.
2897
2898 2019-06-13  Pedro Alves  <palves@redhat.com>
2899
2900         * thread.c (thread_apply_command): Adjust TID parsing.
2901         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2902         detected before end of string.
2903         (tid_is_in_list): Error out if LIST is invalid.
2904
2905 2019-06-13  Pedro Alves  <palves@redhat.com>
2906
2907         * completer.c (complete_line_internal_1): Rewind completion word
2908         point.
2909         (completion_tracker::advance_custom_word_point_by): Change
2910         parameter type to int.
2911         * completer.h (completion_tracker::advance_custom_word_point_by):
2912         Likewise.
2913
2914 2019-06-13  Pedro Alves  <palves@redhat.com>
2915
2916         * completer.c (advance_to_completion_word): Handle delimiters.
2917
2918 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2919
2920         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2921
2922 2019-06-11  Tom Tromey  <tom@tromey.com>
2923
2924         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2925         (xmalloc_failed): Move to alloc.c.
2926         * alloc.c: New file.
2927         * Makefile.in (COMMON_SFILES): Add alloc.c.
2928
2929 2019-06-11  Tom Tromey  <tom@tromey.com>
2930
2931         * nat/linux-waitpid.c: Don't include server.h.
2932         (linux_debug): Remove.
2933         (my_waitpid): Update.
2934
2935 2019-06-11  Tom Tromey  <tromey@adacore.com>
2936
2937         * infcall.c (_initialize_infcall): Remove trailing newline from
2938         help.
2939         * user-regs.c (_initialize_user_regs): Remove trailing newline
2940         from help.
2941         * typeprint.c (_initialize_typeprint): Remove trailing newline
2942         from help.
2943         * reverse.c (_initialize_reverse): Remove trailing newlines from
2944         help.
2945         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2946         from help.
2947         * language.c (add_set_language_command): Remove trailing newline
2948         from help.
2949         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2950         help.
2951         * disasm.c (_initialize_disasm): Remove trailing newline from
2952         help.
2953         * top.c (init_main): Remove trailing newline from help.
2954         * interps.c (_initialize_interpreter): Remove trailing newline
2955         from help.
2956         * btrace.c (_initialize_btrace): Remove trailing newlines from
2957         help.
2958         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2959         from help.
2960         * python/python.c (_initialize_python): Remove trailing newline
2961         from help.
2962         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2963         help.
2964         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2965         from help.  Reformat some text.
2966         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2967         from help.
2968         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2969         newline from help.
2970
2971 2019-06-11  Tom Tromey  <tromey@adacore.com>
2972
2973         * darwin-nat.c (darwin_decode_exception_message)
2974         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2975
2976 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2977
2978         * valops.c (value_slice): Check for not allocated or not
2979         associated values.
2980
2981 2019-06-10  Tom de Vries  <tdevries@suse.de>
2982
2983         PR gdb/24618
2984         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2985         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2986         invalid.
2987
2988 2019-06-10  Tom de Vries  <tdevries@suse.de>
2989
2990         PR gdb/24611
2991         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2992         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2993
2994 2019-06-10  Tom de Vries  <tdevries@suse.de>
2995
2996         PR symtab/24545
2997         * symtab.c (struct demangled_name_entry): Add language field.
2998         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2999         static minimal symbol".  Set and use language field.
3000
3001 2019-06-10  Tom Tromey  <tromey@adacore.com>
3002
3003         * ada-lang.c (_initialize_ada_language): Update help text.
3004
3005 2019-06-10  Tom Tromey  <tromey@adacore.com>
3006
3007         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3008         with a newline.
3009         * guile/guile.c (handle_boot_error): Don't end warning with a
3010         newline.
3011         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3012         warning with a newline.
3013         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3014         newline.
3015         (s12z_frame_cache): Likewise.
3016         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3017         a newline.
3018         * solib-svr4.c (disable_probes_interface): Don't end warning with
3019         a newline.
3020         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3021         newline.
3022         * python/python.c (do_finish_initialization): Don't end warning
3023         with a newline.
3024
3025 2019-06-10  Tom Tromey  <tom@tromey.com>
3026
3027         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3028         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3029         gdbpy_enter.
3030
3031 2019-06-10  Tom Tromey  <tromey@adacore.com>
3032
3033         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3034         data.
3035         (elf_new_init): Don't call stabsread_new_init.
3036         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3037         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3038         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3039
3040 2019-06-10  Tom de Vries  <tdevries@suse.de>
3041
3042         PR symtab/16264
3043         PR symtab/24517
3044         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3045
3046 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3047
3048         * source.c (find_and_open_source): Also rewrite relative file
3049         names.
3050
3051 2019-04-26  Amos Bird  <amosbird@gmail.com>
3052
3053         * annotate.c (annotate_thread_exited): Add "thread-exited"
3054         annotation.
3055
3056 2019-06-06  Tom Tromey  <tromey@adacore.com>
3057
3058         * maint.h (class scoped_command_stats): Use
3059         DISABLE_COPY_AND_ASSIGN.
3060         <print_time>: New method.
3061         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3062         print_time.
3063         (scoped_command_stats::print_time): New method.
3064
3065 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3066
3067         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3068         instructions of lengths 6 or 8 bytes.
3069
3070 2019-06-04  Pedro Alves  <palves@redhat.com>
3071
3072         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3073
3074         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3075         * breakpoint.c (condition_completer): Likewise.
3076         * cli/cli-dump.c (scan_expression): Likewise.
3077         * common/filestuff.c (mkdir_recursive): Likewise.
3078         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3079         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3080         (gdb_abspath): Likewise.
3081         * compile/compile-cplus-types.c
3082         (compile_cplus_instance::decl_name): Likewise.
3083         * completer.c (complete_explicit_location):
3084         (signal_completer, reg_or_group_completer_1): Likewise.
3085         * cp-support.c (cp_remove_params_if_any): Likewise.
3086         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3087         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3088         * infcmd.c (strip_bg_char): Likewise.
3089         * linespec.c (copy_token_string): Likewise.
3090         * mi/mi-main.c (output_cores): Likewise.
3091         * psymtab.c (psymtab_search_name):
3092         * symfile.c (test_set_ext_lang_command): Likewise.
3093         * target.c (target_fileio_read_stralloc): Likewise.
3094         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3095         * value.c (complete_internalvar): Likewise.
3096
3097 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3098
3099         Add objfile property to gdb.Type.
3100         * NEWS: Mention Python API addition.
3101         * python/py-type.c (typy_get_objfile): New method.
3102
3103 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3104
3105         * NEWS: Mention the new set|show style [title|highlight].
3106         Mention changes to "show style", "help" and "apropos".
3107
3108 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3109
3110         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3111         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3112         instead of print_help_for_command.
3113         (print_doc_of_command): New function.
3114         (help_list): Add 'apropos -v word' suggestion.
3115         (print_help_for_command): Style the command name using title style.
3116         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3117         (_initialize_cli_cmds): Describe -v in apropos_command help.
3118
3119 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3120
3121         * cli/cli-style.h (cli_style_option): Add name in constructor,
3122         add m_name class member, add constructor with intensity,
3123         add name class function.
3124         (cli_style_option::add_setshow_commands): Remove name argument.
3125         (highlight_style, title_style): New styles.
3126         * cli/cli-style.c (do_show): New function that shows a style
3127         characteristic styling the style name with itself.
3128         (set_style_name): New function.
3129         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3130         Update all callers according to the changes in cli/cli-style.h.
3131         * utils.h (fputs_highlighted): New function.
3132         * utils.c (fputs_highlighted): Likewise.
3133
3134 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3135
3136         * NEWS: Mention new pipe command and new convenience variables.
3137
3138 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3139
3140         * cli/cli-cmds.c (pipe_command): New function.
3141         (_initialize_cli_cmds): Call add_com for pipe_command.
3142         Define | as an alias for pipe.
3143         (exit_status_set_internal_vars): New function.
3144         (shell_escape): Call exit_status_set_internal_vars.
3145         cli/cli-decode.c (find_command_name_length): Recognize | as
3146         a single character command.
3147
3148 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3149
3150         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3151         top.c (execute_command_to_ui_file): New function, mostly a copy
3152         of execute_command_to_string.
3153         (execute_command_to_string): Implement by calling
3154         execute_command_to_ui_file.
3155
3156 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3157
3158         * top.h (saved_command_line): Remove declaration.
3159         * top.c (previous_saved_command_line, previous_repeat_arguments):
3160         New variables.
3161         (saved_command_line): Make static, define together with other
3162         'repeat variables'.
3163         (dont_repeat): Clear repeat_arguments.
3164         (repeat_previous, get_saved_command_line, save_command_line):
3165         New functions.
3166         (gdb_init): Initialize saved_command_line
3167         and previous_saved_command_line.
3168         * main.c (captured_main_1): Remove saved_command_line initialization.
3169         * event-top.c (handle_line_of_input): Update to use
3170         the new 'repeat' related functions instead of direct access to
3171         saved_command_line.
3172         * command.h (repeat_previous, get_saved_command_line,
3173         save_command_line): New declarations.
3174         (dont_repeat): Add comment.
3175
3176 2019-05-30  Tom Tromey  <tromey@adacore.com>
3177
3178         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3179         Fix comment.
3180         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3181
3182 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3183
3184         PR cli/24587
3185         * completer.c (complete): Initialize variable word.
3186
3187 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3188
3189         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3190         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3191         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3192         'body' is NULL to the outter 'if', protecting the '!is_define'
3193         situation as well.
3194
3195 2019-05-29  Tom Tromey  <tromey@adacore.com>
3196
3197         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3198         (dwarf_unknown): New function.
3199         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3200         (dwarf_type_encoding_name): Use dwarf_unknown.
3201
3202 2019-05-29  Tom Tromey  <tromey@adacore.com>
3203
3204         PR c++/20020:
3205         * cp-valprint.c (cp_print_value_fields): Call
3206         cp_print_static_field inside "try".
3207
3208 2019-05-29  Tom Tromey  <tromey@adacore.com>
3209
3210         * inflow.c (struct terminal_info): Add default operator=.
3211         * configure: Rebuild.
3212         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3213         -Wdeprecated-copy-dtor, -Wredundant-move.
3214
3215 2019-05-29  Tom Tromey  <tromey@adacore.com>
3216
3217         * NEWS: Add entry.
3218         * infcmd.c (print_return_value_1): Handle finish_print
3219         option.
3220         (show_print_finish): New function.
3221         (_initialize_infcmd): Add "set/show print finish" commands.
3222         * valprint.c (user_print_options): Initialize new member.
3223         * valprint.h (struct value_print_options) <finish_print>: New
3224         member.
3225
3226 2019-05-28  Tom Tromey  <tromey@adacore.com>
3227
3228         * ada-lang.c (ada_remove_Xbn_suffix)
3229         (find_old_style_renaming_symbol)
3230         (parse_old_style_renaming): Remove.
3231         (ada_find_renaming_symbol): Don't call
3232         find_old_style_renaming_symbol.
3233         (ada_is_renaming_symbol): Rename from
3234         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3235         bool.  Now static.
3236         (ada_read_var_value): Update and simplify.
3237         * ada-exp.y (write_var_or_type): Remove old code.
3238
3239 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3240
3241         * event-top.c: Remove include comment.
3242         * inflow.c (class scoped_ignore_sigttou): Move from here...
3243         * inflow.h (class scoped_ignore_sigttou): ...to here.
3244         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3245         * top.c:  Remove include comment.
3246
3247 2019-05-27  Tom Tromey  <tom@tromey.com>
3248
3249         * NEWS: Fix typo.
3250
3251 2019-05-22  Tom Tromey  <tromey@adacore.com>
3252
3253         * target.c (target_follow_exec): Constify parameter.
3254         * target-delegates.c: Rebuild.
3255         * remote.c (remote_target::follow_exec): Constify parameter.
3256         * infrun.c (follow_exec): Constify parameter.
3257         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3258         (target_follow_exec): Likewise.
3259
3260 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3261
3262         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3263         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3264
3265 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3266
3267         * NEWS: Add debugredirect and testsuite sections.
3268
3269 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3270
3271         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3272         target descriptions using exclusively floating point register name
3273         aliases.
3274
3275 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3276
3277         PR gdb/18644:
3278         * f-lang.c (build_fortran_types): Handle the case where
3279         gdbarch_floatformat_for_type returns a nullptr.
3280
3281 2019-05-21  Tom de Vries  <tdevries@suse.de>
3282
3283         PR cli/24587
3284         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3285
3286 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3287
3288         PR gdb/18644:
3289         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3290         16-byte floats.
3291         * i386-tdep.c (i386_floatformat_for_type): Use
3292         floatformats_ia64_quad for the 16-byte floating point component
3293         within a fortran 32-byte complex number.
3294
3295 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3296
3297         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3298         delete default constructor.
3299         (find_partial_die): Update to return const struct.
3300         (partial_die_parent_scope): Move variable declaration into scope
3301         of its use and change its type to auto.
3302         (guess_partial_die_structure_name): Likewise.
3303         (partial_die_info::fixup): Likewise.
3304
3305 2019-05-17  Tom Tromey  <tromey@adacore.com>
3306
3307         * source.c (find_and_open_source): Remove cast.
3308
3309 2019-05-17  Tom Tromey  <tromey@adacore.com>
3310
3311         * annotate.c (annotate_source): Make "filename" const.
3312         * annotate.h (annotate_source): Use const.
3313
3314 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3315
3316         * disasm.c (set_disassembler_options): Send errors to stderr.
3317
3318 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3319
3320         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3321         (cli_interp_base::set_logging): Check debug_redirect.
3322         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3323         * cli/cli-logging.c (debug_redirect): Add static variable.
3324         (pop_output_files): Add default param.
3325         (handle_redirections): Print debug setting.
3326         (show_logging_command): Likewise.
3327         (_initialize_cli_logging): Add debugredirect command.
3328         * interps.c (current_interp_set_logging): Add debug_redirect
3329         parameter.
3330         * interps.h (set_logging): Add debug_redirect parameter.
3331         (current_interp_set_logging): Likewise.
3332         * mi/mi-common.h: Likewise.
3333         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3334
3335 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3336             Tom Tromey  <tromey@adacore.com>
3337
3338         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3339         directly.
3340         * cli/cli-interp.h (make_logging_output): Remove declaration.
3341         * cli/cli-logging.c (make_logging_output): Remove function.
3342         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3343         directly.
3344         * ui-file.c (tee_file::tee_file): Remove bools.
3345         (tee_file::~tee_file): Remove deletes.
3346         * ui-file.h (tee_file): Remove bools.
3347
3348 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3349
3350         * mi/mi-cmds.h (mi_cmd_complete): New function.
3351         * mi/mi-main.c (mi_cmd_complete): Likewise.
3352         * mi/mi-cmds.c: Define new MI command -complete.
3353         * NEWS: Mention new -complete command.
3354
3355 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3356
3357         * completer.h (complete): New function.
3358         * completer.c (complete): Likewise.
3359         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3360         function defined in completer.h.
3361
3362 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3363
3364         * MAINTAINERS (Write After Approval): Add myself.
3365
3366 2019-05-17  Tom de Vries  <tdevries@suse.de>
3367
3368         PR gdb/24094
3369         * dwarf2read.c (struct cu_partial_die_info): New struct.
3370         (find_partial_die): Return cu_partial_die_info.
3371         (partial_die_parent_scope, guess_partial_die_structure_name)
3372         (partial_die_info::fixup): Handle new return type of find_partial_die.
3373
3374 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3375
3376         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3377         "std::string", simplifying the algorithm.
3378
3379 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3380
3381         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3382         (stap_static_probe_ops::get_probes): Likewise.
3383
3384 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3385
3386         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3387         '-')" and "else if".
3388         (stap_parse_single_operand): Join checks for
3389         "gdbarch_stap_parse_special_token_p" and
3390         "gdbarch_stap_parse_special_token" in the same "if" statement.
3391         Invert check when verifying for operation on register
3392         displacement.
3393
3394 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3395
3396         * stap-probe.c (stap_get_opcode): Update comment.
3397         (stap_get_expected_argument_type): Likewise.
3398         (handle_stap_probe): Likewise.
3399
3400 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3401
3402         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3403         return type to 'bool'.  Adjust comment.  Use 'bool' when
3404         appropriate.
3405         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3406         * stap-probe.c (stap_parse_argument_1): Likewise.
3407         (stap_is_operator): Likewise.
3408         (stap_is_generic_prefix): Likewise.
3409         (stap_is_register_prefix): Likewise.
3410         (stap_is_register_indirection_prefix): Likewise.
3411         (stap_is_integer_prefix): Likewise.
3412         (stap_generic_check_suffix): Likewise.
3413         (stap_check_integer_suffix): Likewise.
3414         (stap_check_register_suffix): Likewise.
3415         (stap_check_register_indirection_suffix): Likewise.
3416         (stap_parse_register_operand): Likewise.
3417         (stap_parse_single_operand): Likewise.
3418         (stap_parse_argument_1): Likewise.
3419         (stap_probe::get_argument_count): Likewise.
3420         (stap_is_operator): Likewise.
3421
3422 2019-05-16  Tom Tromey  <tromey@adacore.com>
3423
3424         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3425         keyword to foreach.
3426
3427 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3428
3429         * linux-thread-db.c (try_thread_db_load_1): Change return type
3430         to bool.
3431         (try_thread_db_load): Likewise.
3432         (try_thread_db_load_from_pdir_1): Likewise.
3433         (try_thread_db_load_from_pdir): Likewise.
3434         (try_thread_db_load_from_sdir): Likewise.
3435         (try_thread_db_load_from_dir): Likewise.
3436         (thread_db_load_search): Likewise.
3437         (has_libpthread): Likewise.
3438         (thread_db_load): Likewise.
3439
3440 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3441
3442         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3443         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3444         NULL, and complain/return if that's the case.
3445
3446 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3447
3448         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3449         (advance, posn, abstract_read_memory): New functions.
3450         [struct mem_read_abstraction]: New struct.
3451         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3452
3453 2019-05-14  Tom Tromey  <tromey@adacore.com>
3454
3455         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3456         value is not lval_memory.
3457
3458 2019-05-14  Tom Tromey  <tromey@adacore.com>
3459
3460         * solib.c (info_sharedlibrary_command): Style the file name.
3461
3462 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3463
3464         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3465         (aarch64_vnv_type): Likewise.
3466         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3467         * common/tdesc.c: Likewise.
3468         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3469         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3470         * features/aarch64-fpu.xml: Add ieee half view.
3471         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3472         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3473         * gdbtypes.h (struct builtin_type): Likewise.
3474         (struct objfile_type): Likewise.
3475
3476 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3477
3478         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3479         typo.
3480         * location.h (string_to_event_location): Likewise.
3481
3482 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3483
3484         GDB 8.3 released.
3485
3486 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3487
3488         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3489         New variable declaration.
3490         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3491         New variable.
3492         (print_one_breakpoint): Use ui_out::test_flags and new global
3493         variable to compute use_fixed_output.
3494         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3495         Remove.
3496         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3497         (mi_multi_location_breakpoint_output_fixed): Remove.
3498         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3499         new variable.
3500         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3501         fix_multi_location_breakpoint_output flag if version >= 3.
3502         * ui-out.h (enum ui_out_flag)
3503         <fix_multi_location_breakpoint_output>: New enumerator.
3504
3505 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3506
3507         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3508
3509 2019-05-10  Tom Tromey  <tromey@adacore.com>
3510
3511         * ada-lang.c (catch_ada_completer): New function.
3512         (_initialize_ada_language): Use it.
3513
3514 2019-05-10  Tom Tromey  <tromey@adacore.com>
3515
3516         * thread.c (print_thread_info): Make "requested_threads" const.
3517         * gdbthread.h (print_thread_info): Make "requested_threads"
3518         const.
3519         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3520         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3521
3522 2019-05-08  Tom Tromey  <tom@tromey.com>
3523
3524         * gdbtypes.c (objfile_type_data): Change type.
3525         (objfile_type, _initialize_gdbtypes): Update.
3526
3527 2019-05-08  Tom Tromey  <tom@tromey.com>
3528
3529         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3530         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3531         (_initialize_dwarf2_frame): Update.
3532
3533 2019-05-08  Tom Tromey  <tom@tromey.com>
3534
3535         * objc-lang.c (objc_objfile_data): Change type.
3536         (find_methods): Update.
3537         (_initialize_objc_lang): Remove.
3538
3539 2019-05-08  Tom Tromey  <tom@tromey.com>
3540
3541         * stabsread.c (rs6000_builtin_type_data): Change type.
3542         (rs6000_builtin_type, _initialize_stabsread): Update.
3543
3544 2019-05-08  Tom Tromey  <tom@tromey.com>
3545
3546         * mips-tdep.c (mips_pdr_data): Remove.
3547         (_initialize_mips_tdep): Update.
3548
3549 2019-05-08  Tom Tromey  <tom@tromey.com>
3550
3551         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3552         (hppa_init_objfile_priv_data, read_unwind_info)
3553         (find_unwind_entry, _initialize_hppa_tdep): Update.
3554
3555 2019-05-08  Tom Tromey  <tom@tromey.com>
3556
3557         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3558         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3559         on obstack.
3560         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3561
3562 2019-05-08  Tom Tromey  <tom@tromey.com>
3563
3564         * mdebugread.c (basic_type_data): Change type.
3565         (basic_type, _initialize_mdebugread): Update.
3566
3567 2019-05-08  Tom Tromey  <tom@tromey.com>
3568
3569         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3570
3571 2019-05-08  Tom Tromey  <tom@tromey.com>
3572
3573         * nto-tdep.c (nto_inferior_data_reg): Change type.
3574         (nto_inferior_data): Update.
3575         (nto_inferior_data_cleanup, nto_new_inferior_data)
3576         (_initialize_nto_tdep): Remove.
3577         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3578
3579 2019-05-08  Tom Tromey  <tom@tromey.com>
3580
3581         * ada-lang.c (struct ada_inferior_data): Add initializers.
3582         (ada_inferior_data): Change type.
3583         (ada_inferior_data_cleanup): Remove.
3584         (get_ada_inferior_data, ada_inferior_exit)
3585         (struct ada_pspace_data): Add initializers, destructor.
3586         (ada_pspace_data_handle): Change type.
3587         (get_ada_pspace_data): Update.
3588         (ada_pspace_data_cleanup): Remove.
3589
3590 2019-05-08  Tom Tromey  <tom@tromey.com>
3591
3592         * coffread.c (struct coff_symfile_info): Add initializers.
3593         (coff_objfile_data_key): Move lower.  Change type.
3594         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3595         Update.
3596         (coff_free_info): Remove.
3597
3598 2019-05-08  Tom Tromey  <tom@tromey.com>
3599
3600         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3601         (fbsd_pspace_data_handle): Move lower.  Change type.
3602         (get_fbsd_pspace_data): Update.
3603         (fbsd_pspace_data_cleanup): Remove.
3604         (_initialize_fbsd_tdep): Update.
3605
3606 2019-05-08  Tom Tromey  <tom@tromey.com>
3607
3608         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3609         (get_ada_tasks_pspace_data): Update.
3610         (ada_tasks_pspace_data_cleanup): Remove.
3611         (_initialize_tasks): Update.
3612         (ada_tasks_inferior_data_handle): Change type.
3613         (get_ada_tasks_inferior_data): Update.
3614         (ada_tasks_inferior_data_cleanup): Remove.
3615         (struct ada_tasks_pspace_data): Add initializers.
3616
3617 2019-05-08  Tom Tromey  <tom@tromey.com>
3618
3619         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3620         * symfile-debug.c (debug_sym_get_probes): Change type.
3621         * stap-probe.c (handle_stap_probe):
3622         (stap_static_probe_ops::get_probes): Change type.
3623         * probe.h (class static_probe_ops) <get_probes>: Change type.
3624         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3625         (parse_probes_in_pspace): Update.
3626         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3627         Update.
3628         (any_static_probe_ops::get_probes): Change type.
3629         * elfread.c (elfread_data): New typedef.
3630         (probe_key): Change type.
3631         (elf_get_probes): Likewise.  Update.
3632         (probe_key_free): Remove.
3633         (_initialize_elfread): Update.
3634         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3635         Change type.
3636         (dtrace_process_dof_probe, dtrace_process_dof)
3637         (dtrace_static_probe_ops::get_probe): Change type.
3638
3639 2019-05-08  Tom Tromey  <tom@tromey.com>
3640
3641         * xcoffread.c (struct xcoff_symfile_info): Rename from
3642         coff_symfile_info.  Add initializers.
3643         (xcoff_objfile_data_key): Move lower.  Change type.
3644         (XCOFF_DATA): Rewrite.
3645         (xcoff_free_info): Remove.
3646         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3647         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3648         (xcoff_initial_scan): Update.
3649
3650 2019-05-08  Tom Tromey  <tom@tromey.com>
3651
3652         * solib-svr4.c (struct svr4_info): Add initializers and
3653         destructor.
3654         <probes_table>: Now an htab_up.
3655         (solib_svr4_pspace_data): Change type.
3656         (free_probes_table): Simplify.
3657         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3658         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3659         (probes_table_remove_objfile_probes, register_solib_event_probe)
3660         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3661         (_initialize_svr4_solib): Update.
3662
3663 2019-05-08  Tom Tromey  <tom@tromey.com>
3664
3665         * remote.c (remote_pspace_data): Change type.
3666         (remote_pspace_data_cleanup): Remove.
3667         (get_remote_exec_file, set_pspace_remote_exec_file)
3668         (_initialize_remote): Update.
3669
3670 2019-05-08  Tom Tromey  <tom@tromey.com>
3671
3672         * breakpoint.c (breakpoint_objfile_key): Change type.
3673         (get_breakpoint_objfile_data): Update.
3674         (free_breakpoint_objfile_data): Remove.
3675         (_initialize_breakpoint): Update.
3676
3677 2019-05-08  Tom Tromey  <tom@tromey.com>
3678
3679         * linux-tdep.c (struct linux_info): Add initializers.
3680         (linux_inferior_data): Move.  Change type.
3681         (invalidate_linux_cache_inf): Update.
3682         (linux_inferior_data_cleanup): Remove.
3683         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3684
3685 2019-05-08  Tom Tromey  <tom@tromey.com>
3686
3687         * auxv.c (auxv_inferior_data): Move.  Change type.
3688         (auxv_inferior_data_cleanup): Remove.
3689         (invalidate_auxv_cache_inf): Rewrite.
3690         (get_auxv_inferior_data, _initialize_auxv): Update.
3691
3692 2019-05-08  Tom Tromey  <tom@tromey.com>
3693
3694         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3695         (symfile_debug_objfile_data_key): Change type.
3696         (symfile_debug_installed, debug_qf_has_symbols)
3697         (debug_qf_find_last_source_symtab)
3698         (debug_qf_forget_cached_source_info)
3699         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3700         (debug_qf_print_stats, debug_qf_dump)
3701         (debug_qf_expand_symtabs_for_function)
3702         (debug_qf_expand_all_symtabs)
3703         (debug_qf_expand_symtabs_with_fullname)
3704         (debug_qf_map_matching_symbols)
3705         (debug_qf_expand_symtabs_matching)
3706         (debug_qf_find_pc_sect_compunit_symtab)
3707         (debug_qf_map_symbol_filenames)
3708         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3709         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3710         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3711         (debug_sym_read_linetable, debug_sym_relocate): Update.
3712         (symfile_debug_free_objfile): Remove.
3713         (install_symfile_debug_logging, _initialize_symfile_debug):
3714         Update.
3715
3716 2019-05-08  Tom Tromey  <tom@tromey.com>
3717
3718         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3719         allocate_on_obstack.
3720         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3721         (get_dwarf2_per_objfile): Update.
3722         (set_dwarf2_per_objfile): Remove.
3723         (dwarf2_has_info, dwarf2_get_section_info): Update.
3724         (dwarf2_free_objfile): Remove.
3725         (_initialize_dwarf2_read): Update.
3726
3727 2019-05-08  Tom Tromey  <tom@tromey.com>
3728
3729         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3730         initializers.
3731         <unsupported_script_warning_printed,
3732         script_not_found_warning_printed>: Now bool.
3733         (auto_load_pspace_data): Change type.
3734         (~auto_load_pspace_info): Rename from
3735         auto_load_pspace_data_cleanup.
3736         (get_auto_load_pspace_data, init_loaded_scripts_info)
3737         (clear_section_scripts, maybe_print_unsupported_script_warning)
3738         (maybe_print_script_not_found_warning, _initialize_auto_load):
3739         Update.
3740
3741 2019-05-08  Tom Tromey  <tom@tromey.com>
3742
3743         * objfiles.c (objfile_pspace_info): Add destructor and
3744         initializers.
3745         (objfiles_pspace_data): Change type.
3746         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3747         (get_objfile_pspace_data): Update.
3748         (objfiles_bfd_data): Change type.
3749         (get_objfile_bfd_data): Update.
3750         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3751
3752 2019-05-08  Tom Tromey  <tom@tromey.com>
3753
3754         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3755         Change type.
3756         (get_catch_syscall_inferior_data): Update.
3757         (catch_syscall_inferior_data_cleanup): Remove.
3758         (_initialize_break_catch_syscall): Update.
3759
3760 2019-05-08  Tom Tromey  <tom@tromey.com>
3761
3762         * inflow.c (struct terminal_info): Add destructor and
3763         initializers.
3764         (inflow_inferior_data): Change type.
3765         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3766         (get_inflow_inferior_data, inflow_inferior_exit)
3767         (swap_terminal_info, _initialize_inflow): Update.
3768
3769 2019-05-08  Tom Tromey  <tom@tromey.com>
3770
3771         * target-dcache.c (target_dcache_cleanup): Remove.
3772         (target_dcache_aspace_key): Change type.
3773         (target_dcache_init_p, target_dcache_invalidate)
3774         (target_dcache_get, target_dcache_get_or_init)
3775         (_initialize_target_dcache): Update.
3776         * dcache.h (struct dcache_deleter): New.
3777
3778 2019-05-08  Tom Tromey  <tom@tromey.com>
3779
3780         * symtab.c (struct symbol_cache): Add destructor and
3781         initializers.
3782         (symbol_cache_key): Move.  Change type.
3783         (make_symbol_cache, free_symbol_cache): Remove.
3784         (get_symbol_cache): Update.
3785         (symbol_cache_cleanup): Remove.
3786         (ALL_PSPACES, symbol_cache_flush)
3787         (maintenance_print_symbol_cache)
3788         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3789         Update.
3790
3791 2019-05-08  Tom Tromey  <tom@tromey.com>
3792
3793         * symtab.c (struct main_info): Add destructor and initializers.
3794         (main_progspace_key): Move.  Change type.
3795         (get_main_info): Update.
3796         (main_info_cleanup): Remove.
3797         (_initialize_symtab): Update.
3798
3799 2019-05-08  Tom Tromey  <tom@tromey.com>
3800
3801         * registry.h (DECLARE_REGISTRY): Define the _key class.
3802
3803 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3804
3805         * NEWS: Merge two 'New commands' sections.
3806
3807 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3808
3809         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3810         parameter and use Ada language definition instead.
3811         (ada_val_print_ptr): Remove unused language parameter.
3812         (ada_val_print_num): Remove language parameter and use Ada language
3813         definition instead.
3814         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3815         parameter.
3816         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3817         parameter and use Ada language definition instead.
3818         (ada_val_print_1): Update all ada_val_print_xxx calls.
3819         Remove language parameter.
3820         (ada_val_print): Update ada_val_print_1 call.
3821
3822 2019-05-08  Tom Tromey  <tromey@adacore.com>
3823
3824         * remote.c (remote_hw_watchpoint_limit)
3825         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3826         Now static.
3827
3828 2019-05-08  Tom Tromey  <tromey@adacore.com>
3829
3830         * maint.c (_initialize_maint_cmds): Move initialization code to
3831         remote.c.
3832         (watchdog, show_watchdog): Move to remote.c.
3833         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3834         "watchdog" static.
3835         (_initialize_remote): Move initialization code from maint.c.
3836         * defs.h (watchdog): Don't declare.
3837
3838 2019-05-08  Tom Tromey  <tromey@adacore.com>
3839
3840         * tui/tui-interp.c: Include main.h.
3841         * interps.c: Include main.h.
3842         * main.h (interpreter_p): Declare.
3843         * defs.h (interpreter_p): Don't declare.
3844
3845 2019-05-08  Tom Tromey  <tromey@adacore.com>
3846
3847         * dwarf2loc.c: Include dwarf2read.h.
3848         * defs.h (read_unsigned_leb128): Don't declare.
3849         * dwarf2read.h (read_unsigned_leb128): Declare.
3850
3851 2019-05-08  Tom Tromey  <tromey@adacore.com>
3852
3853         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3854         method.
3855
3856 2019-05-08  Tom Tromey  <tromey@adacore.com>
3857
3858         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3859         when no wrap column is set.
3860
3861 2019-05-08  Tom Tromey  <tromey@adacore.com>
3862
3863         * c-lang.c (c_get_string): Handle non-C-style arrays.
3864
3865 2019-05-08  Tom Tromey  <tromey@adacore.com>
3866
3867         * typeprint.c (print_offset_data::update): Print the bit offset,
3868         not the number of bits remaining.
3869
3870 2019-05-08  Tom Tromey  <tromey@adacore.com>
3871
3872         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3873         padding at end of comment.
3874
3875 2019-05-08  Tom Tromey  <tromey@adacore.com>
3876
3877         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3878         Compare main types.
3879
3880 2019-05-06  Tom Tromey  <tom@tromey.com>
3881
3882         * common/scoped_mmap.c: Include common-defs.h.
3883         * common/scoped_mmap.h: Don't include config.h.
3884
3885 2019-05-04  Tom Tromey  <tom@tromey.com>
3886
3887         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3888         (struct aarch64_call_info): Add initializers.
3889         <si>: Now a std::vector.
3890         (pass_on_stack, aarch64_push_dummy_call): Update.
3891
3892 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3893             Tom Tromey  <tom@tromey.com>
3894
3895         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3896         (ppc_threads): Now a std::vector.  Now static.
3897         (hwdebug_find_thread_points_by_tid)
3898         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3899         Update.
3900
3901 2019-05-04  Tom Tromey  <tom@tromey.com>
3902
3903         * arc-tdep.c (arc_tdesc_init): Return bool.
3904
3905 2019-05-04  Tom Tromey  <tom@tromey.com>
3906
3907         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3908         Use gdb_assert_not_reached.
3909
3910 2019-05-04  Tom Tromey  <tom@tromey.com>
3911
3912         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3913         "false".
3914
3915 2019-05-04  Tom Tromey  <tom@tromey.com>
3916
3917         * arc-tdep.c (arc_tdesc_init): Use bool.
3918
3919 2019-05-04  Tom Tromey  <tom@tromey.com>
3920
3921         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3922
3923 2019-05-04  Tom Tromey  <tom@tromey.com>
3924
3925         * cli/cli-cmds.c (valid_command_p): Return bool.
3926
3927 2019-05-04  Tom Tromey  <tom@tromey.com>
3928
3929         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3930         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3931
3932 2019-05-04  Raul Tambre  <raul@tambre.ee>
3933
3934         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3935         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3936         operator for comparison.
3937
3938 2019-05-04  Tom Tromey  <tom@tromey.com>
3939
3940         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3941         (lookup_partial_symbol, print_partial_symbols)
3942         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3943         (psymbol_compare): Update.
3944         (add_psymbol_to_bcache): Clear the entire psymbol.
3945         (maintenance_check_psymtabs): Update.
3946         * psympriv.h (struct partial_symbol): Don't derive from
3947         general_symbol_info.
3948         <obj_section, unrelocated_address, address,
3949         set_unrelocated_address>: Update.
3950         <ginfo>: New member.
3951         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3952         (debug_names::write_psymbols): Update.
3953
3954 2019-05-04  Tom de Vries  <tdevries@suse.de>
3955
3956         * contrib/cc-with-tweaks.sh: Support -n arg.
3957
3958 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3959
3960         * corelow.c (core_target::detach): Ensure frame cache and
3961         register caches are cleared.
3962         inferior.c (exit_inferior_1): Likewise.
3963
3964 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3965             Tom Tromey  <tom@tromey.com>
3966
3967         * dictionary.c (collate_pending_symbols_by_language): Remove
3968         "struct" from foreach.
3969         * symtab.c (lookup_global_symbol_from_objfile)
3970         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3971         foreach.
3972         * ser-tcp.c (net_open): Remove "struct" from foreach.
3973         * objfiles.c (objfile_relocate, objfile_rebase)
3974         (objfile_has_symbols): Remove "struct" from foreach.
3975         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3976         from foreach.
3977         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3978         foreach.
3979         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3980         "struct" from foreach.
3981         * ada-lang.c (create_excep_cond_exprs)
3982         (ada_exception_catchpoint_cond_string): Remove "struct" from
3983         foreach.
3984
3985 2019-05-03  Tom Tromey  <tromey@adacore.com>
3986
3987         * ada-exp.y (convert_char_literal): Check suffix of each
3988         enumerator.
3989
3990 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3991
3992         PR ada/21406:
3993         * ada-exp.y (yywrap): Don't define.
3994         * ada-lex.l (%option): Add noyywrap
3995         (yywrap): Remove.
3996
3997 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3998
3999         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4000         _WIN32_WINNT to the XP level, unless already defined to a higher
4001         level.
4002
4003         * unittests/parse-connection-spec-selftests.c:
4004         * ser-tcp.c:
4005         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4006         override.
4007
4008         * symfile.c (find_separate_debug_file): Remove colon from the
4009         drive spec of DOS/Windows file names of the target, so that the
4010         file name produced from DEBUGDIR and the target's directory will
4011         be valid on DOS/Windows systems.
4012
4013 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4014
4015         * rust-lang.c (val_print_struct): Handle printing structures
4016         containing strings.
4017
4018 2019-05-02  Tom Tromey  <tromey@adacore.com>
4019
4020         * valarith.c (_initialize_valarith): Remove.
4021
4022 2019-05-01  Tom Tromey  <tromey@adacore.com>
4023
4024         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4025         bitfields.
4026
4027 2019-05-01  Tom Tromey  <tromey@adacore.com>
4028
4029         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4030         for big-endian copies.
4031
4032 2019-04-30  Ali Tamur  <tamur@google.com>
4033         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4034         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4035         (read_3_bytes): New function.
4036
4037 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4038
4039         * windows-nat.c (main_thread_id): Delete.
4040         (handle_output_debug_string): Replace main_thread_id by
4041         current_event.dwThreadId.
4042         (fake_create_process): Likewise.
4043         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4044         Do not set main_thread_id.
4045         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4046         current_event.dwThreadId.
4047         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4048
4049 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4050
4051         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4052         Use current_event.dwThreadId instead of main_thread_id.
4053
4054 2019-04-30  Tom Tromey  <tromey@adacore.com>
4055
4056         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4057         (create_excep_cond_exprs): Iterate over program spaces.
4058         (ada_exception_catchpoint_cond_string): Examine all minimal
4059         symbols for exception types.
4060
4061 2019-04-30  Tom Tromey  <tromey@adacore.com>
4062
4063         PR c++/24470:
4064         * dwarf2read.c (process_structure_scope): Handle case where type
4065         has template parameters but no symbol was created.
4066
4067 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4068             Chris January  <chris.january@arm.com>
4069
4070         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4071         qualifier.
4072         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4073
4074 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4075
4076         * f-typeprint.c (f_print_type): Update rules for printing
4077         whitespace.
4078         (f_type_print_varspec_suffix): Likewise.
4079
4080 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4081             Chris January  <chris.january@arm.com>
4082
4083         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4084         function arguments.
4085
4086 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4087
4088         * f-lang.c (build_fortran_types): Change name of void type to
4089         lower case.
4090         * f-typeprint.c (f_type_print_base): Print the name of the void
4091         type, rather than a fixed string.
4092         * f-valprint.c (f_decorations): Use lower case void string.
4093
4094 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4095             Chris January  <chris.january@arm.com>
4096
4097         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4098         types for Fortran.
4099
4100 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4101             Chris January  <chris.january@arm.com>
4102             David Lecomber  <david.lecomber@arm.com>
4103
4104         * f-exp.y (BINOP_INTRINSIC): New token.
4105         (exp): New parser rule handling BINOP_INTRINSIC.
4106         (f77_keywords): Add new builtin procedures.
4107         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4108         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4109         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4110         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4111         (print_unop_subexp_f): New function.
4112         (print_binop_subexp_f): New function.
4113         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4114         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4115         (dump_subexp_body_f): Likewise.
4116         (operator_check_f): Likewise.
4117         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4118         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4119
4120 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4121
4122         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4123         UNOP_KIND.
4124         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4125         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4126         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4127         (operator_length_f): New fuction.
4128         (print_subexp_f): New function.
4129         (op_name_f): New function.
4130         (dump_subexp_body_f): New function.
4131         (operator_check_f): New function.
4132         (exp_descriptor_f): Replace standard expression handling functions
4133         with new functions.
4134         * gdb/fortran-operator.def: New file.
4135         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4136         * gdb/std-operator.def: Remove UNOP_KIND.
4137
4138 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4139
4140         * std-operator.def: Remove unbalanced, stray double quote
4141         character.
4142
4143 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4144             Chris January  <chris.january@arm.com>
4145             Daniel Everett  <daniel.everett@arm.com>
4146             Nick Forrington  <nick.forrington@arm.com>
4147             Richard Bunt  <richard.bunt@arm.com>
4148
4149         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4150         of depth when printing anonymous structs or unions.
4151         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4152         Don't print either the top-level value, or the children if the
4153         max-depth is exceeded.
4154         (ppscm_print_children): When printing the key of a map, allow one
4155         extra level of depth.
4156         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4157         print either the top-level value, or the children if the max-depth
4158         is exceeded.
4159         (print_children): When printing the key of a map, allow one extra
4160         level of depth.
4161         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4162         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4163         (user_print_options): Initialise max_depth field.
4164         (val_print_scalar_or_string_type_p): New function.
4165         (val_print): Check to see if the max depth has been reached.
4166         (val_print_check_max_depth): Define new function.
4167         (show_print_max_depth): New function.
4168         (_initialize_valprint): Add 'print max-depth' option.
4169         * valprint.h (struct value_print_options) <max_depth>: New field.
4170         (val_print_check_max_depth): Declare new function.
4171         * NEWS: Document new feature.
4172
4173 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4174
4175         * ada-lang.c (ada_language_defn): Initialise new field.
4176         * c-lang.c (c_is_string_type_p): New function.
4177         (c_language_defn): Initialise new field.
4178         (cplus_language_defn): Initialise new field.
4179         (asm_language_defn): Initialise new field.
4180         (minimal_language_defn): Initialise new field.
4181         * c-lang.h (c_is_string_type_p): Declare new function.
4182         * d-lang.c (d_language_defn): Initialise new field.
4183         * f-lang.c (f_is_string_type_p): New function.
4184         (f_language_defn): Initialise new field.
4185         * go-lang.c (go_is_string_type_p): New function.
4186         (go_language_defn): Initialise new field.
4187         * language.c (default_is_string_type_p): New function.
4188         (unknown_language_defn): Initialise new field.
4189         (auto_language_defn): Initialise new field.
4190         * language.h (struct language_defn) <la_is_string_type_p>: New
4191         member variable.
4192         (default_is_string_type_p): Declare new function.
4193         * m2-lang.c (m2_language_defn): Initialise new field.
4194         * objc-lang.c (objc_language_defn): Initialise new field.
4195         * opencl-lang.c (opencl_language_defn): Initialise new field.
4196         * p-lang.c (pascal_is_string_type_p): New function.
4197         (pascal_language_defn): Initialise new field.
4198         * rust-lang.c (rust_is_string_type_p): New function.
4199         (rust_language_defn): Initialise new field.
4200
4201 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4202
4203         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4204         New field.
4205         * ada-lang.c (ada_language_defn): Initialise new field.
4206         * c-lang.c (c_language_defn): Likewise.
4207         (cplus_language_defn): Likewise.
4208         (asm_language_defn): Likewise.
4209         (minimal_language_defn): Likewise.
4210         * d-lang.c (d_language_defn): Likewise.
4211         * f-lang.c (f_language_defn): Likewise.
4212         * go-lang.c (go_language_defn): Likewise.
4213         * language.c (unknown_language_defn): Likewise.
4214         (auto_language_defn): Likewise.
4215         * m2-lang.c (m2_language_defn): Likewise.
4216         * objc-lang.c (objc_language_defn): Likewise.
4217         * opencl-lang.c (opencl_language_defn): Likewise.
4218         * p-lang.c (pascal_language_defn): Likewise.
4219         * rust-lang.c (rust_language_defn): Likewise.
4220
4221 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4222
4223         * ada-lang.c (ada_is_character_type): Change return type to bool.
4224         (ada_is_string_type): Likewise.
4225         * ada-lang.h (ada_is_character_type): Update declaration
4226         (ada_is_string_type): Likewise.
4227
4228 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4229
4230         Support style in 'frame|thread apply'
4231
4232         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4233         * record.c (record_start, record_stop): Update callers of
4234         execute_command_to_string with false.
4235         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4236         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4237         methods.
4238         (class string_file): New constructor with term_out parameter.
4239         Override methods term_out and can_emit_style_escape.  New member
4240         term_out.
4241         (class stdio_file): Override can_emit_style_escape.
4242         (class tee_file): Override term_out and can_emit_style_escape.
4243         * utils.h (can_emit_style_escape): Remove.
4244         * utils.c (can_emit_style_escape): Likewise.
4245         Update all callers of can_emit_style_escape (SOMESTREAM) to
4246         SOMESTREAM->can_emit_style_escape.
4247         * source-cache.c (source_cache::get_source_lines): Likewise.
4248         * stack.c (frame_apply_command_count): Call execute_command_to_string
4249         passing the term_out characteristic of the current gdb_stdout.
4250         * thread.c (thr_try_catch_cmd): Likewise.
4251         * top.c (execute_command_to_string): pass term_out parameter
4252         to construct the string_file for the command output.
4253         * ui-file.c (term_cli_styling): New function (most code moved
4254         from utils.c can_emit_style_escape).
4255         (string_file::string_file, string_file::can_emit_style_escape,
4256         stdio_file::can_emit_style_escape, tee_file::term_out,
4257         tee_file::can_emit_style_escape): New functions.
4258
4259 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4260
4261         * NEWS: Mention the new set|show may-call-functions.
4262         * infcall.c (may_call_functions_p): New variable.
4263         (show_may_call_functions_p): New function.
4264         (call_function_by_hand_dummy): Throws an error if not
4265         may-call-functions.
4266         (_initialize_infcall): Call add_setshow_boolean_cmd for
4267         may-call-functions.
4268
4269 2019-04-25  Keith Seitz  <keiths@redhat.com>
4270
4271         PR c++/24367
4272         * cp-support.c (inspect_type): Don't attempt substitutions
4273         of symbol with the same name.
4274
4275 2019-04-25  Tom Tromey  <tromey@adacore.com>
4276
4277         PR gdb/24475:
4278         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4279         static.
4280
4281 2019-04-25  Tom Tromey  <tromey@adacore.com>
4282
4283         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4284         rvalue reference.
4285         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4286         (gdb_xml_parser::parse): Use std::move.
4287         * python/python-internal.h (gdbpy_convert_exception): Take a const
4288         reference.
4289         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4290         std::move.
4291         * python/py-utils.c (gdbpy_convert_exception): Take a const
4292         reference.
4293         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4294         Use std::move.
4295         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4296         Use std::move.
4297         * mi/mi-main.c (mi_print_exception): Take a const reference.
4298         * main.c (handle_command_errors): Take a const reference.
4299         * linespec.c (parse_linespec): Use std::move.
4300         * infcall.c (run_inferior_call): Use std::move.
4301         (call_function_by_hand_dummy): Use std::move.
4302         * exec.c (try_open_exec_file): Use std::move.
4303         * exceptions.h (exception_print, exception_fprintf)
4304         (exception_print_same): Update.
4305         * exceptions.c (print_exception, exception_print)
4306         (exception_fprintf, exception_print_same): Change parameters to
4307         const reference.
4308         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4309         * common/new-op.c: Use std::move.
4310         * common/common-exceptions.h (struct gdb_exception): Add move
4311         constructor.
4312         (struct gdb_exception_error, struct gdb_exception_quit, struct
4313         gdb_quit_bad_alloc): Change constructor to move constructor.
4314         (throw_exception): Change parameter to rvalue reference.
4315         * common/common-exceptions.c (throw_exception): Take rvalue
4316         reference.
4317         * cli/cli-interp.c (safe_execute_command): Use std::move.
4318         * breakpoint.c (insert_bp_location, location_to_sals): Use
4319         std::move.
4320
4321 2019-04-25  Tom Tromey  <tromey@adacore.com>
4322
4323         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4324         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4325         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4326         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4327         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4328         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4329         guile/scm-value.c: Use unpack.
4330         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4331         gdbscm_gdb_exception.
4332         (gdbscm_throw_gdb_exception): Likewise.
4333         (struct gdbscm_gdb_exception): New.
4334         (unpack): New function.
4335         (gdbscm_wrap): Use unpack.
4336
4337 2019-04-25  Tom Tromey  <tromey@adacore.com>
4338
4339         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4340         (gdb_rl_callback_handler): Use std::move.
4341         * common/common-exceptions.h (struct gdb_exception): Add move
4342         assignment operator.
4343         (throw_exception_sjlj): Change "exception" to const reference.
4344         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4345         (throw_exception_sjlj): Change "exception" to const reference.
4346
4347 2019-04-25  Tom Tromey  <tromey@adacore.com>
4348
4349         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4350         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4351         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4352         Update.
4353         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4354         Update.
4355         * mi/mi-interp.c (mi_interp::exec): Update.
4356         * linespec.c (parse_linespec): Update.
4357         * infcall.c (run_inferior_call): Update.
4358         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4359         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4360         (gdbscm_lookup_global_symbol): Update.
4361         * guile/scm-param.c (gdbscm_parameter_value): Update.
4362         * guile/scm-frame.c (gdbscm_frame_read_register)
4363         (gdbscm_frame_read_var): Update.
4364         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4365         * exec.c (try_open_exec_file): Update.
4366         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4367         (gdb_rl_callback_handler): Update.
4368         * common/common-exceptions.h (exception_none): Don't declare.
4369         * common/common-exceptions.c (exception_none): Don't define.
4370         (struct catcher) <exception>: Update.
4371         * cli/cli-interp.c (safe_execute_command): Update.
4372         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4373
4374 2019-04-25  Ali Tamur  <tamur@google.com>
4375
4376         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4377         (read_attribute_value): Likewise.
4378         (dwarf2_read_addr_index): Update comment.
4379         (read_str_index): Add DW_FORM_strx.
4380         (dwarf2_string_attr): Likewise.
4381         (dwarf2_const_value_attr): Likewise.
4382         (dump_die_shallow): Likewise.
4383         (dwarf2_fetch_constant_bytes): Likewise.
4384         (skip_form_bytes): Likewise.
4385         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4386
4387 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4388
4389         PR corefiles/11608
4390         PR corefiles/18187
4391         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4392         OFFSET.  Verify if current mapping contains an ELF header.
4393         (linux_find_memory_regions_full): Adjust call to
4394         dump_mapping_p.
4395
4396 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4397             Kang Li <kanglictf@gmail.com>
4398
4399         PR gdb/21600
4400
4401         * dwarf2-frame.c (read_initial_length): Be consistent about using
4402         unsigned representation of length.
4403         (decode_frame_entry_1): Likewise.  Check for wraparound of
4404         end pointer as well as buffer overflow.
4405
4406 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4407
4408         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4409         "vq".
4410
4411 2019-04-24  Tom Tromey  <tromey@adacore.com>
4412
4413         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4414
4415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4416
4417         * s12z-tdep.c (s12z_unwind_pc): Delete.
4418         (s12z_unwind_sp): Delete.
4419         (s12z_gdbarch_init): Don't register deleted functions with
4420         gdbarch.
4421
4422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4423
4424         * rl78-tdep.c (rl78_unwind_sp): Delete.
4425         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4426
4427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4428
4429         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4430         (xstormy16_unwind_pc): Delete.
4431         (xstormy16_dummy_id): Delete.
4432         (xstormy16_gdbarch_init): Don't register deleted functions with
4433         gdbarch.
4434
4435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4436
4437         * vax-tdep.c (vax_unwind_pc): Delete.
4438         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4439
4440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4441
4442         * v850-tdep.c (v850_unwind_sp): Delete.
4443         (v850_unwind_pc): Delete.
4444         (v850_dummy_id): Delete.
4445         (v850_gdbarch_init): Don't register deleted functions with
4446         gdbarch.
4447
4448 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4449
4450         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4451         (tilegx_unwind_pc): Delete.
4452         (tilegx_unwind_dummy_id): Delete.
4453         (tilegx_gdbarch_init): Don't register deleted functions with
4454         gdbarch.
4455
4456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4457
4458         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4459         (tic6x_dummy_id): Delete.
4460         (tic6x_gdbarch_init): Don't register deleted functions with
4461         gdbarch.
4462
4463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4464
4465         * sparc-tdep.c (sparc_unwind_pc): Delete.
4466         (sparc32_gdbarch_init): Don't register deleted function with
4467         gdbarch.
4468
4469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4470
4471         * sh-tdep.c (sh_unwind_sp): Delete.
4472         (sh_unwind_pc): Delete.
4473         (sh_dummy_id): Delete.
4474         (sh_gdbarch_init): Don't register deleted functions with
4475         gdbarch.
4476
4477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4478
4479         * score-tdep.c (score_unwind_sp): Delete.
4480         (score_unwind_pc): Delete.
4481         (score_dummy_id): Delete.
4482         (score_gdbarch_init): Don't register deleted functions with
4483         gdbarch.
4484
4485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4486
4487         * rx-tdep.c (rx_unwind_pc): Delete.
4488         (rx_unwind_sp): Delete.
4489         (rx_dummy_id): Delete.
4490         (rx_gdbarch_init): Don't register deleted functions with
4491         gdbarch.  Update comment.
4492
4493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4494
4495         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4496         (rs6000_dummy_id): Delete.
4497         (rs6000_gdbarch_init): Don't register deleted functions with
4498         gdbarch.
4499
4500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4501
4502         * or1k-tdep.c (or1k_dummy_id): Delete.
4503         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4504
4505 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4506
4507         * nios2-tdep.c (nios2_dummy_id): Delete.
4508         (nios2_unwind_sp): Delete.
4509         (nios2_gdbarch_init): Don't register deleted functions with
4510         gdbarch.
4511
4512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4513
4514         * nds32-tdep.c (nds32_dummy_id): Delete.
4515         (nds32_unwind_pc): Delete.
4516         (nds32_unwind_sp): Delete.
4517         (nds32_gdbarch_init): Don't register deleted functions with
4518         gdbarch.
4519
4520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4521
4522         * msp430-tdep.c (msp430_unwind_pc): Delete.
4523         (msp430_unwind_sp): Delete.
4524         (msp430_dummy_id): Delete.
4525         (msp430_gdbarch_init): Don't register deleted functions with
4526         gdbarch.
4527
4528 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4529
4530         * moxie-tdep.c (moxie_unwind_sp): Delete.
4531         (moxie_unwind_pc): Delete.
4532         (moxie_dummy_id): Delete.
4533         (moxie_gdbarch_init): Don't register deleted functions with
4534         gdbarch.
4535
4536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4537
4538         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4539         (mn10300_unwind_pc): Delete.
4540         (mn10300_unwind_sp): Delete.
4541         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4542         mn10300_unwind_sp.
4543         (mn10300_frame_unwind_init): Don't register deleted functions with
4544         gdbarch.
4545
4546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4547
4548         * mep-tdep.c (mep_unwind_pc): Delete.
4549         (mep_unwind_sp): Delete.
4550         (mep_dummy_id): Delete.
4551         (mep_gdbarch_init): Don't register deleted functions with
4552         gdbarch.
4553
4554 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4555
4556         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4557         (m68hc11_unwind_sp): Delete.
4558         (m68hc11_gdbarch_init): Don't register deleted functions with
4559         gdbarch.
4560
4561 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4562
4563         * m32r-tdep.c (m32r_unwind_sp): Delete.
4564         (m32r_unwind_pc): Delete.
4565         (m32r_dummy_id): Delete.
4566         (m32r_gdbarch_init): Don't register deleted functions with
4567         gdbarch.
4568
4569 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4570
4571         * m32c-tdep.c (m32c_unwind_pc): Delete.
4572         (m32c_unwind_sp): Delete.
4573         (m32c_dummy_id): Delete.
4574         (m32c_gdbarch_init): Don't register deleted functions with
4575         gdbarch.
4576
4577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4580         (lm32_unwind_pc): Delete.
4581         (lm32_dummy_id): Delete.
4582         (lm32_gdbarch_init): Don't register deleted functions with
4583         gdbarch.
4584
4585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4588         (iq2000_unwind_pc): Delete.
4589         (iq2000_dummy_id): Delete.
4590         (iq2000_gdbarch_init): Don't register deleted functions with
4591         gdbarch.
4592
4593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * nds32-tdep.c (nds32_type_align): Delete.
4596         (nds32_push_dummy_call): Use type_align instead.
4597
4598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         * arm-tdep.c (arm_type_align): Only handle vector override case.
4601         (arm_push_dummy_call): Use type_align.
4602         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4603
4604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4605
4606         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4607         case.
4608         (pass_on_stack): Use type_align.
4609         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4610         function.
4611
4612 2019-04-23  Tom Tromey  <tromey@adacore.com>
4613
4614         * dwarf2read.c (line_header::file_name_at): Remove unused
4615         overload.
4616
4617 2019-04-23  Tom de Vries  <tdevries@suse.de>
4618
4619         PR gdb/24438
4620         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4621         invocation.
4622
4623
4624 2019-03-27  Ali Tamur  <tamur@google.com>
4625
4626         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4627         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4628         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4629         (dwarf_expr_context::get_addr_index): Likewise
4630         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4631         (symbol_needs_eval_context::get_addr_index): Likewise
4632         (disassemble_dwarf_expression): Add DW_OP_addrx
4633         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4634         (read_cutu_die_from_dwo): Update comment
4635         (skip_one_die): Add DW_FORM_addrx
4636         (read_attribute_value): Likewise
4637         (var_decode_location): Add DW_OP_addrx
4638         (dwarf2_const_value_attr): Add DW_FORM_addrx
4639         (dump_die_shallow): Likewise
4640         (dwarf2_fetch_constant_bytes): Likewise
4641         (decode_locdesc): Add DW_OP_addrx
4642         (skip_form_bytes): Add DW_FORM_addrx
4643
4644 2019-04-22  Ali Tamur  <tamur@google.com>
4645
4646         * MAINTAINERS (Write After Approval): Add self.
4647
4648 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4649
4650         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4651         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4652         (open_symbol_file_object): Likewise.
4653         (svr4_default_sos): Add info parameter.
4654         (svr4_read_so_list): Likewise.
4655         (svr4_current_sos_direct): Adjust functions calls to pass down
4656         info.
4657         (svr4_current_sos_1): Add info parameter.
4658         (svr4_current_sos): Call get_svr4_info, pass info down to
4659         svr4_current_sos_1.
4660         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4661         get_svr4_info.
4662         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4663         get_svr4_info.
4664         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4665         to get_svr4_info.
4666         (probes_table_remove_objfile_probes): Likewise.
4667         (register_solib_event_probe): Add info parameter.
4668         (solist_update_incremental): Pass info parameter down to
4669         svr4_read_so_list.
4670         (disable_probes_interface): Add info parameter.
4671         (svr4_handle_solib_event): Pass current_program_space to
4672         get_svr4_info.  Adjust disable_probes_interface cleanup.
4673         (svr4_create_probe_breakpoints): Add info parameter, pass it
4674         down to register_solib_event_probe.
4675         (svr4_create_solib_event_breakpoints): Add info parameter,
4676         pass it down to svr4_create_probe_breakpoints.
4677         (enable_break): Pass info down to
4678         svr4_create_solib_event_breakpoints.
4679         (svr4_solib_create_inferior_hook): Pass current_program_space to
4680         get_svr4_info.
4681         (svr4_clear_solib): Likewise.
4682
4683 2019-04-22  Pedro Alves  <palves@redhat.com>
4684
4685         * solib-svr4.c (svr4_free_objfile_observer): New.
4686         (probe_and_action::objfile): New field.
4687         (probes_table_htab_remove_objfile_probes)
4688         (probes_table_remove_objfile_probes): New functions.
4689         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4690         in the new probe_and_action.  Don't store the probe in 'lookup'.
4691         (svr4_create_probe_breakpoints): Pass objfile to
4692         register_solib_event_probe.
4693         (_initialize_svr4_solib): Register a free_objfile observer.
4694
4695 2019-04-19  Tom Tromey  <tom@tromey.com>
4696
4697         * common/queue.h: Remove.
4698
4699 2019-04-19  Tom Tromey  <tom@tromey.com>
4700
4701         * event-loop.c: Don't include "common/queue.h".
4702
4703 2019-04-19  Tom Tromey  <tom@tromey.com>
4704
4705         * remote.c (remote_target): Use delete.
4706         * remote-notif.h: Include <list>, not "common/queue.h".
4707         (notif_client_p): Remove typedef.
4708         (remote_notif_state): Add constructor, destructor, initializer.
4709         <notif_queue>: Now a std::list.
4710         (remote_notif_state_xfree): Don't declare.
4711         * remote-notif.c (remote_notif_process, handle_notification)
4712         (remote_notif_state_allocate): Update.
4713         (~remote_notif_state): Rename from remote_notif_state_xfree.
4714
4715 2019-04-19  Tom Tromey  <tom@tromey.com>
4716
4717         * symfile.c (reread_symbols): Update.
4718         * objfiles.c (objfile_register_static_link)
4719         (objfile_lookup_static_link): Update
4720         (~objfile) Don't delete static_links.
4721         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4722
4723 2019-04-19  Tom Tromey  <tom@tromey.com>
4724
4725         * type-stack.h (struct type_stack) <insert>: Constify string.
4726         * type-stack.c (type_stack::insert): Constify string.
4727         * gdbtypes.h (lookup_template_type): Update.
4728         (address_space_name_to_int): Update.
4729         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4730         const.
4731         (lookup_template_type): Make name const.
4732         * c-exp.y: Update rules.
4733         (lex_one_token, classify_name, classify_inner_name)
4734         (c_print_token): Update.
4735         * p-exp.y: Update rules.
4736         (yylex): Update.
4737         * f-exp.y: Update rules.
4738         (yylex): Update.
4739         * d-exp.y: Update rules.
4740         (lex_one_token, classify_name, classify_inner_name): Update.
4741         * parse.c (write_dollar_variable, copy_name): Return std::string.
4742         * parser-defs.h (copy_name): Change return type.
4743         * m2-exp.y: Update rules.
4744         (yylex): Update.
4745         * go-exp.y (lex_one_token): Update.
4746         Update rules.
4747         (classify_unsafe_function, classify_packaged_name)
4748         (classify_name, yylex): Update.
4749
4750 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4751
4752         * configure.ac: add --enable-source-highlight switch.
4753         * configure: Regenerate.
4754         * top.c (print_gdb_version): plumb --enable-source-highlight
4755         status to "show configuration".
4756
4757 2019-04-19  Tom Tromey  <tromey@adacore.com>
4758
4759         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4760         Check ADA_TYPE_P.
4761         (empty_record, ada_template_to_fixed_record_type_1)
4762         (template_to_static_fixed_type)
4763         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4764         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4765         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4766         macros.
4767
4768 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4769
4770         PR symtab/24423:
4771         * source.c (print_source_lines_base): Advance "iter" when a
4772         control character is seen.
4773
4774 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4775
4776         * inferior.h (struct infcall_suspend_state_deleter):
4777         Catch exception in destructor to avoid crash.
4778
4779 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4780
4781         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4782         close to the add_com "shell".
4783
4784 2019-04-18  Tom Tromey  <tromey@adacore.com>
4785
4786         * process-stratum-target.h (class process_stratum_target)
4787         <stratum>: Add "final".
4788
4789 2019-04-17  Tom Tromey  <tromey@adacore.com>
4790
4791         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4792         against nullptr before use.
4793
4794 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4795
4796         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4797
4798 2019-04-17  Jim Wilson  <jimw@sifive.com>
4799             Andrew Burgess  <andrew.burgess@embecosm.com>
4800
4801         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4802         code read might fail, assume 4-byte breakpoint in that case.
4803
4804 2019-04-15  Leszek Swirski  <leszeks@google.com>
4805
4806         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4807         rather than a hand-rolled POD check when checking for forced MEMORY
4808         classification.
4809
4810 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4811
4812         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4813         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4814         function.
4815         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4816         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4817         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4818         declaration.
4819
4820 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4821
4822         * aarch64-linux-nat.c
4823         (aarch64_linux_nat_target::thread_architecture): Add override.
4824         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4825         each VQ.
4826
4827 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4828
4829         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4830
4831 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4832
4833         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4834         target types of size 96-bits, add some additional comments, and
4835         check that the builtin type we found was the correct size.
4836
4837 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4838
4839         * utils.c (prompt_for_continue): Don't restore the styling at the
4840         end, as applied_style has the wrong value.  This fixes styling in
4841         long lists of file names that are interrupted by the "Continue?"
4842         prompt.
4843
4844 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4845
4846         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4847         * c-lang.c (c_language_defn): Likewise.
4848         (cplus_language_defn): Likewise.
4849         (asm_language_defn): Likewise.
4850         (minimal_language_defn): Likewise.
4851         * d-lang.c (d_language_defn): Likewise.
4852         * f-lang.c (f_language_defn): Likewise.
4853         * go-lang.c (go_language_defn): Likewise.
4854         * language.c (unknown_language_defn): Likewise.
4855         (auto_language_defn): Likewise.
4856         * language.h (struct language_defn): Remove la_magic field.
4857         (LANG_MAGIC): Delete.
4858         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4859         * objc-lang.c (objc_language_defn): Likewise.
4860         * opencl-lang.c (opencl_language_defn): Likewise.
4861         * p-lang.c (pascal_language_defn): Likewise.
4862         * rust-lang.c (rust_language_defn): Likewise.
4863
4864 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4865
4866         * riscv-tdep.c (riscv_type_align): New function.
4867         (riscv_type_alignment): Delete.
4868         (riscv_arg_location): Use 'type_align'.
4869         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4870
4871 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4872
4873         * gdbtypes.c (type_align): A struct with no non-static fields also
4874         has alignment of 1.
4875
4876 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4877
4878         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4879         component to 0.
4880         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4881         member.
4882         (riscv_struct_info::analyse): New implementation using new
4883         analyse_inner member function.
4884         (riscv_struct_info::field_offset): New member function.
4885         (riscv_struct_info::m_offsets): New member variable.
4886         (riscv_struct_info::analyse_inner): New private member function,
4887         takes the old implementation of riscv_struct_info::analyse but
4888         extended to track field offsets.
4889         (riscv_call_arg_struct): Update the struct folding special cases
4890         to handle cases where empty C++ structs, which are non-zero
4891         length, are found.
4892         (riscv_arg_location): Initialise the length of each location, a
4893         non-zero length now indicates the location is in use.
4894         (riscv_push_dummy_call): Allow for the first location having a
4895         non-zero offset when setting up arguments.
4896         (riscv_return_value): Likewise, but for return values.
4897
4898 2019-04-11  Tom Tromey  <tromey@adacore.com>
4899
4900         * utils.c (internal_vproblem): Make "msg" const.
4901
4902 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4903
4904         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4905         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4906         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4907         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4908
4909 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4910
4911         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4912         function.
4913         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4914         of amd64_collect_native_gregset.
4915         (amd64_linux_nat_target::store_registers): Likewise.
4916
4917 2019-04-10  Tom Tromey  <tom@tromey.com>
4918
4919         * symtab.c (lookup_global_symbol_from_objfile)
4920         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4921         * objfiles.h (class separate_debug_iterator): New.
4922         (class separate_debug_range): New.
4923         (struct objfile) <separate_debug_objfiles>: New method.
4924         (objfile_separate_debug_iterate): Don't declare.
4925         * objfiles.c (separate_debug_iterator::operator++): Rename from
4926         objfile_separate_debug_iterate.
4927         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4928         iterator.
4929         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4930         iterator.
4931
4932 2019-04-10  Tom Tromey  <tom@tromey.com>
4933
4934         * symfile.c (reread_symbols): Remove old comment.
4935         * objfiles.c (free_all_objfiles): Fix a typo.
4936
4937 2019-04-10  Tom Tromey  <tom@tromey.com>
4938
4939         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4940         * minsyms.c (lookup_minimal_symbol): Use foreach.
4941         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4942         (lookup_minimal_symbol_solib_trampoline): Likewise.
4943         * symfile.c (reread_symbols): Use foreach.
4944
4945 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4946             Tom Tromey  <tromey@adacore.com>
4947
4948         PR rust/24414:
4949         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4950         (rust_lex_int_test): Change "value" to be LONGEST.
4951         (rust_lex_tests): Add test for long integer literal.
4952
4953 2019-04-09  Tom Tromey  <tromey@adacore.com>
4954
4955         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4956         to bool.
4957         (extended_remote_target::attach): Update.
4958         (remote_target::remote_notice_new_inferior): Update.
4959         (remote_target::add_current_inferior_and_thread): Update.
4960         * inferior.c (exit_inferior_1): Use "false".
4961         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4962
4963 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4964
4965         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4966         the "start" command.
4967
4968 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4969
4970         * python/py-inferior.c (infpy_thread_from_thread_handle):
4971         Adjust comments to reflect renaming of thread_from_thread_handle
4972         to thread_from_handle.  Adjust keywords.  Fix type error message.
4973         (inferior_object_methods): Add thread_from_handle.  Retain
4974         thread_from_thread_handle, but mark it as deprecated.
4975
4976 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4977
4978         * gdbthread.h (find_thread_by_handle): Revise declaration.
4979         * thread.c (find_thread_by_handle): Likewise.  Adjust
4980         implementation too.
4981         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4982         support for buffer objects as handles.
4983
4984 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4985
4986         * python/py-infthread.c (thpy_thread_handle): New function.
4987         (thread_object_methods): Register thpy_thread_handle.
4988
4989 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4990
4991         * gdbthread.h (thread_to_thread_handle): Declare.
4992         * thread.c (gdbtypes.h): Include.
4993         (thread_to_thread_handle): New function.
4994
4995         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4996         (target_thread_info_to_thread_handle): Declare.
4997         * target.c (target_thread_info_to_thread_handle): New function.
4998         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4999         * target-delegates.c: Regenerate.
5000
5001         * linux-thread-db.c (class thread_db_target): Add method
5002         thread_info_to_thread_handle.
5003         (thread_db_target::thread_info_to_thread_handle): Define.
5004         * remote.c (class remote_target): Add new method
5005         thread_info_to_thread_handle.
5006         (remote_target::thread_info_to_thread_handle): Define.
5007
5008 2019-04-08  Pedro Alves  <palves@redhat.com>
5009
5010         * common/common-exceptions.c (throw_exception): Don't create
5011         named object to throw; throw directly.
5012         (throw_it): Likewise.  Don't initialize gdb_exception::message
5013         here, with new; pass FMT and AP to the ctor instead.
5014         * common/common-exceptions.h: Include <string>.
5015         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5016         const char *, va_list)): New ctor.  Use std::make_shared.
5017         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5018         errors)): Delete.
5019         (gdb_exception_error::gdb_exception_error(enum errors, const char
5020         *, va_list)): New.
5021         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5022         Add assertion.
5023         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5024         errors)): Delete.
5025         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5026         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5027         Add assertion.
5028
5029 2019-04-08  Tom Tromey  <tom@tromey.com>
5030
5031         * valops.c (value_rtti_indirect_type): Replace throw_exception
5032         with throw.
5033         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5034         with throw.
5035         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5036         throw.
5037         * target.c (target_translate_tls_address): Replace throw_exception
5038         with throw.
5039         * stack.c (frame_apply_command_count): Replace throw_exception
5040         with throw.
5041         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5042         throw.
5043         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5044         with throw.
5045         * rs6000-tdep.c (rs6000_frame_cache)
5046         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5047         * remote.c: Replace throw_exception with throw.
5048         * record-full.c (record_full_message, record_full_wait_1)
5049         (record_full_restore): Replace throw_exception with throw.
5050         * record-btrace.c:
5051         (get_thread_current_frame_id, record_btrace_start_replaying)
5052         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5053         (cmd_record_btrace_start): Replace throw_exception with throw.
5054         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5055         throw.
5056         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5057         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5058         * linespec.c:
5059         (find_linespec_symbols): Replace throw_exception with throw.
5060         * infrun.c (displaced_step_prepare, resume): Replace
5061         throw_exception with throw.
5062         * infcmd.c (post_create_inferior): Replace throw_exception with
5063         throw.
5064         * inf-loop.c (inferior_event_handler): Replace throw_exception
5065         with throw.
5066         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5067         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5068         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5069         (get_prev_frame_always, get_frame_pc_if_available)
5070         (get_frame_address_in_block_if_available, get_frame_language):
5071         Replace throw_exception with throw.
5072         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5073         throw_exception with throw.
5074         * eval.c (fetch_subexp_value, evaluate_var_value)
5075         (evaluate_funcall, evaluate_subexp_standard): Replace
5076         throw_exception with throw.
5077         * dwarf2loc.c (call_site_find_chain)
5078         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5079         Replace throw_exception with throw.
5080         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5081         with throw.
5082         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5083         throw.
5084         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5085         * completer.c (complete_line_internal): Replace throw_exception
5086         with throw.
5087         * compile/compile-object-run.c (compile_object_run): Replace
5088         throw_exception with throw.
5089         * cli/cli-script.c (process_next_line): Replace throw_exception
5090         with throw.
5091         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5092         (btrace_enable, btrace_maint_update_pt_packets): Replace
5093         throw_exception with throw.
5094         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5095         throw_exception with throw.
5096         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5097         throw_exception with throw.
5098         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5099         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5100         * aarch64-tdep.c (aarch64_make_prologue_cache)
5101         (aarch64_make_stub_cache): Replace throw_exception with throw.
5102
5103 2019-04-08  Tom Tromey  <tom@tromey.com>
5104
5105         * common/common-exceptions.c (throw_exception): Rename from
5106         throw_exception_cxx.  Remove old copy.  Make argument const.
5107         (throw_it): Create and throw exception objects directly.
5108         * common/common-exceptions.h (throw_exception): Make argument
5109         const.
5110         (struct gdb_exception_error): Add constructor.
5111         (struct gdb_exception_quit): Add constructor.
5112
5113 2019-04-08  Tom Tromey  <tom@tromey.com>
5114
5115         * common/common-exceptions.h (exception_rethrow): Don't declare.
5116         (TRY_SJLJ): Update comment.
5117         (TRY, CATCH, END_CATCH): Remove.
5118         * common/common-exceptions.c (exception_rethrow): Remove.
5119
5120 2019-04-08  Tom Tromey  <tom@tromey.com>
5121
5122         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5123         Remove.
5124         (gdb_exception_error): Rename from
5125         gdb_exception_RETURN_MASK_ERROR.
5126         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5127         (gdb_quit_bad_alloc): Update.
5128         * aarch64-tdep.c: Update.
5129         * ada-lang.c: Update.
5130         * ada-typeprint.c: Update.
5131         * ada-valprint.c: Update.
5132         * amd64-tdep.c: Update.
5133         * arch-utils.c: Update.
5134         * break-catch-throw.c: Update.
5135         * breakpoint.c: Update.
5136         * btrace.c: Update.
5137         * c-varobj.c: Update.
5138         * cli/cli-cmds.c: Update.
5139         * cli/cli-interp.c: Update.
5140         * cli/cli-script.c: Update.
5141         * common/common-exceptions.c: Update.
5142         * common/new-op.c: Update.
5143         * common/selftest.c: Update.
5144         * compile/compile-c-symbols.c: Update.
5145         * compile/compile-cplus-symbols.c: Update.
5146         * compile/compile-object-load.c: Update.
5147         * compile/compile-object-run.c: Update.
5148         * completer.c: Update.
5149         * corelow.c: Update.
5150         * cp-abi.c: Update.
5151         * cp-support.c: Update.
5152         * cp-valprint.c: Update.
5153         * darwin-nat.c: Update.
5154         * disasm-selftests.c: Update.
5155         * dtrace-probe.c: Update.
5156         * dwarf-index-cache.c: Update.
5157         * dwarf-index-write.c: Update.
5158         * dwarf2-frame-tailcall.c: Update.
5159         * dwarf2-frame.c: Update.
5160         * dwarf2loc.c: Update.
5161         * dwarf2read.c: Update.
5162         * eval.c: Update.
5163         * event-loop.c: Update.
5164         * event-top.c: Update.
5165         * exec.c: Update.
5166         * f-valprint.c: Update.
5167         * fbsd-tdep.c: Update.
5168         * frame-unwind.c: Update.
5169         * frame.c: Update.
5170         * gdbtypes.c: Update.
5171         * gnu-v3-abi.c: Update.
5172         * guile/guile-internal.h: Update.
5173         * guile/scm-block.c: Update.
5174         * guile/scm-breakpoint.c: Update.
5175         * guile/scm-cmd.c: Update.
5176         * guile/scm-disasm.c: Update.
5177         * guile/scm-frame.c: Update.
5178         * guile/scm-lazy-string.c: Update.
5179         * guile/scm-math.c: Update.
5180         * guile/scm-param.c: Update.
5181         * guile/scm-ports.c: Update.
5182         * guile/scm-pretty-print.c: Update.
5183         * guile/scm-symbol.c: Update.
5184         * guile/scm-symtab.c: Update.
5185         * guile/scm-type.c: Update.
5186         * guile/scm-value.c: Update.
5187         * i386-linux-tdep.c: Update.
5188         * i386-tdep.c: Update.
5189         * inf-loop.c: Update.
5190         * infcall.c: Update.
5191         * infcmd.c: Update.
5192         * infrun.c: Update.
5193         * jit.c: Update.
5194         * language.c: Update.
5195         * linespec.c: Update.
5196         * linux-fork.c: Update.
5197         * linux-nat.c: Update.
5198         * linux-tdep.c: Update.
5199         * linux-thread-db.c: Update.
5200         * main.c: Update.
5201         * mi/mi-cmd-break.c: Update.
5202         * mi/mi-cmd-stack.c: Update.
5203         * mi/mi-interp.c: Update.
5204         * mi/mi-main.c: Update.
5205         * objc-lang.c: Update.
5206         * p-valprint.c: Update.
5207         * parse.c: Update.
5208         * ppc-linux-tdep.c: Update.
5209         * printcmd.c: Update.
5210         * python/py-arch.c: Update.
5211         * python/py-breakpoint.c: Update.
5212         * python/py-cmd.c: Update.
5213         * python/py-finishbreakpoint.c: Update.
5214         * python/py-frame.c: Update.
5215         * python/py-framefilter.c: Update.
5216         * python/py-gdb-readline.c: Update.
5217         * python/py-inferior.c: Update.
5218         * python/py-infthread.c: Update.
5219         * python/py-lazy-string.c: Update.
5220         * python/py-linetable.c: Update.
5221         * python/py-objfile.c: Update.
5222         * python/py-param.c: Update.
5223         * python/py-prettyprint.c: Update.
5224         * python/py-progspace.c: Update.
5225         * python/py-record-btrace.c: Update.
5226         * python/py-record.c: Update.
5227         * python/py-symbol.c: Update.
5228         * python/py-type.c: Update.
5229         * python/py-unwind.c: Update.
5230         * python/py-utils.c: Update.
5231         * python/py-value.c: Update.
5232         * python/python.c: Update.
5233         * record-btrace.c: Update.
5234         * record-full.c: Update.
5235         * remote-fileio.c: Update.
5236         * remote.c: Update.
5237         * riscv-tdep.c: Update.
5238         * rs6000-aix-tdep.c: Update.
5239         * rs6000-tdep.c: Update.
5240         * rust-exp.y: Update.
5241         * rust-lang.c: Update.
5242         * s390-tdep.c: Update.
5243         * selftest-arch.c: Update.
5244         * solib-dsbt.c: Update.
5245         * solib-frv.c: Update.
5246         * solib-spu.c: Update.
5247         * solib-svr4.c: Update.
5248         * solib.c: Update.
5249         * sparc64-linux-tdep.c: Update.
5250         * stack.c: Update.
5251         * symfile-mem.c: Update.
5252         * symmisc.c: Update.
5253         * target.c: Update.
5254         * thread.c: Update.
5255         * top.c: Update.
5256         * tracefile-tfile.c: Update.
5257         * tui/tui.c: Update.
5258         * typeprint.c: Update.
5259         * unittests/cli-utils-selftests.c: Update.
5260         * unittests/parse-connection-spec-selftests.c: Update.
5261         * valops.c: Update.
5262         * valprint.c: Update.
5263         * value.c: Update.
5264         * varobj.c: Update.
5265         * windows-nat.c: Update.
5266         * x86-linux-nat.c: Update.
5267         * xml-support.c: Update.
5268
5269 2019-04-08  Tom Tromey  <tom@tromey.com>
5270
5271         * xml-support.c: Use C++ exception handling.
5272         * x86-linux-nat.c: Use C++ exception handling.
5273         * windows-nat.c: Use C++ exception handling.
5274         * varobj.c: Use C++ exception handling.
5275         * value.c: Use C++ exception handling.
5276         * valprint.c: Use C++ exception handling.
5277         * valops.c: Use C++ exception handling.
5278         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5279         handling.
5280         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5281         * typeprint.c: Use C++ exception handling.
5282         * tui/tui.c: Use C++ exception handling.
5283         * tracefile-tfile.c: Use C++ exception handling.
5284         * top.c: Use C++ exception handling.
5285         * thread.c: Use C++ exception handling.
5286         * target.c: Use C++ exception handling.
5287         * symmisc.c: Use C++ exception handling.
5288         * symfile-mem.c: Use C++ exception handling.
5289         * stack.c: Use C++ exception handling.
5290         * sparc64-linux-tdep.c: Use C++ exception handling.
5291         * solib.c: Use C++ exception handling.
5292         * solib-svr4.c: Use C++ exception handling.
5293         * solib-spu.c: Use C++ exception handling.
5294         * solib-frv.c: Use C++ exception handling.
5295         * solib-dsbt.c: Use C++ exception handling.
5296         * selftest-arch.c: Use C++ exception handling.
5297         * s390-tdep.c: Use C++ exception handling.
5298         * rust-lang.c: Use C++ exception handling.
5299         * rust-exp.y: Use C++ exception handling.
5300         * rs6000-tdep.c: Use C++ exception handling.
5301         * rs6000-aix-tdep.c: Use C++ exception handling.
5302         * riscv-tdep.c: Use C++ exception handling.
5303         * remote.c: Use C++ exception handling.
5304         * remote-fileio.c: Use C++ exception handling.
5305         * record-full.c: Use C++ exception handling.
5306         * record-btrace.c: Use C++ exception handling.
5307         * python/python.c: Use C++ exception handling.
5308         * python/py-value.c: Use C++ exception handling.
5309         * python/py-utils.c: Use C++ exception handling.
5310         * python/py-unwind.c: Use C++ exception handling.
5311         * python/py-type.c: Use C++ exception handling.
5312         * python/py-symbol.c: Use C++ exception handling.
5313         * python/py-record.c: Use C++ exception handling.
5314         * python/py-record-btrace.c: Use C++ exception handling.
5315         * python/py-progspace.c: Use C++ exception handling.
5316         * python/py-prettyprint.c: Use C++ exception handling.
5317         * python/py-param.c: Use C++ exception handling.
5318         * python/py-objfile.c: Use C++ exception handling.
5319         * python/py-linetable.c: Use C++ exception handling.
5320         * python/py-lazy-string.c: Use C++ exception handling.
5321         * python/py-infthread.c: Use C++ exception handling.
5322         * python/py-inferior.c: Use C++ exception handling.
5323         * python/py-gdb-readline.c: Use C++ exception handling.
5324         * python/py-framefilter.c: Use C++ exception handling.
5325         * python/py-frame.c: Use C++ exception handling.
5326         * python/py-finishbreakpoint.c: Use C++ exception handling.
5327         * python/py-cmd.c: Use C++ exception handling.
5328         * python/py-breakpoint.c: Use C++ exception handling.
5329         * python/py-arch.c: Use C++ exception handling.
5330         * printcmd.c: Use C++ exception handling.
5331         * ppc-linux-tdep.c: Use C++ exception handling.
5332         * parse.c: Use C++ exception handling.
5333         * p-valprint.c: Use C++ exception handling.
5334         * objc-lang.c: Use C++ exception handling.
5335         * mi/mi-main.c: Use C++ exception handling.
5336         * mi/mi-interp.c: Use C++ exception handling.
5337         * mi/mi-cmd-stack.c: Use C++ exception handling.
5338         * mi/mi-cmd-break.c: Use C++ exception handling.
5339         * main.c: Use C++ exception handling.
5340         * linux-thread-db.c: Use C++ exception handling.
5341         * linux-tdep.c: Use C++ exception handling.
5342         * linux-nat.c: Use C++ exception handling.
5343         * linux-fork.c: Use C++ exception handling.
5344         * linespec.c: Use C++ exception handling.
5345         * language.c: Use C++ exception handling.
5346         * jit.c: Use C++ exception handling.
5347         * infrun.c: Use C++ exception handling.
5348         * infcmd.c: Use C++ exception handling.
5349         * infcall.c: Use C++ exception handling.
5350         * inf-loop.c: Use C++ exception handling.
5351         * i386-tdep.c: Use C++ exception handling.
5352         * i386-linux-tdep.c: Use C++ exception handling.
5353         * guile/scm-value.c: Use C++ exception handling.
5354         * guile/scm-type.c: Use C++ exception handling.
5355         * guile/scm-symtab.c: Use C++ exception handling.
5356         * guile/scm-symbol.c: Use C++ exception handling.
5357         * guile/scm-pretty-print.c: Use C++ exception handling.
5358         * guile/scm-ports.c: Use C++ exception handling.
5359         * guile/scm-param.c: Use C++ exception handling.
5360         * guile/scm-math.c: Use C++ exception handling.
5361         * guile/scm-lazy-string.c: Use C++ exception handling.
5362         * guile/scm-frame.c: Use C++ exception handling.
5363         * guile/scm-disasm.c: Use C++ exception handling.
5364         * guile/scm-cmd.c: Use C++ exception handling.
5365         * guile/scm-breakpoint.c: Use C++ exception handling.
5366         * guile/scm-block.c: Use C++ exception handling.
5367         * guile/guile-internal.h: Use C++ exception handling.
5368         * gnu-v3-abi.c: Use C++ exception handling.
5369         * gdbtypes.c: Use C++ exception handling.
5370         * frame.c: Use C++ exception handling.
5371         * frame-unwind.c: Use C++ exception handling.
5372         * fbsd-tdep.c: Use C++ exception handling.
5373         * f-valprint.c: Use C++ exception handling.
5374         * exec.c: Use C++ exception handling.
5375         * event-top.c: Use C++ exception handling.
5376         * event-loop.c: Use C++ exception handling.
5377         * eval.c: Use C++ exception handling.
5378         * dwarf2read.c: Use C++ exception handling.
5379         * dwarf2loc.c: Use C++ exception handling.
5380         * dwarf2-frame.c: Use C++ exception handling.
5381         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5382         * dwarf-index-write.c: Use C++ exception handling.
5383         * dwarf-index-cache.c: Use C++ exception handling.
5384         * dtrace-probe.c: Use C++ exception handling.
5385         * disasm-selftests.c: Use C++ exception handling.
5386         * darwin-nat.c: Use C++ exception handling.
5387         * cp-valprint.c: Use C++ exception handling.
5388         * cp-support.c: Use C++ exception handling.
5389         * cp-abi.c: Use C++ exception handling.
5390         * corelow.c: Use C++ exception handling.
5391         * completer.c: Use C++ exception handling.
5392         * compile/compile-object-run.c: Use C++ exception handling.
5393         * compile/compile-object-load.c: Use C++ exception handling.
5394         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5395         * compile/compile-c-symbols.c: Use C++ exception handling.
5396         * common/selftest.c: Use C++ exception handling.
5397         * common/new-op.c: Use C++ exception handling.
5398         * cli/cli-script.c: Use C++ exception handling.
5399         * cli/cli-interp.c: Use C++ exception handling.
5400         * cli/cli-cmds.c: Use C++ exception handling.
5401         * c-varobj.c: Use C++ exception handling.
5402         * btrace.c: Use C++ exception handling.
5403         * breakpoint.c: Use C++ exception handling.
5404         * break-catch-throw.c: Use C++ exception handling.
5405         * arch-utils.c: Use C++ exception handling.
5406         * amd64-tdep.c: Use C++ exception handling.
5407         * ada-valprint.c: Use C++ exception handling.
5408         * ada-typeprint.c: Use C++ exception handling.
5409         * ada-lang.c: Use C++ exception handling.
5410         * aarch64-tdep.c: Use C++ exception handling.
5411
5412 2019-04-08  Tom Tromey  <tom@tromey.com>
5413
5414         * xml-support.c (gdb_xml_parser::parse): Update.
5415         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5416         * value.c (show_convenience): Update.
5417         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5418         (test_parse_flags_qcs): Update.
5419         * thread.c (thr_try_catch_cmd): Update.
5420         * target.c (target_translate_tls_address): Update.
5421         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5422         (info_frame_command_core, frame_apply_command_count): Update.
5423         * rust-exp.y (rust_lex_exception_test): Update.
5424         * riscv-tdep.c (riscv_print_one_register_info): Update.
5425         * remote.c (remote_target::enable_btrace): Update.
5426         * record-btrace.c (record_btrace_enable_warn): Update.
5427         * python/py-utils.c (gdbpy_convert_exception): Update.
5428         * printcmd.c (do_one_display, print_variable_and_value): Update.
5429         * mi/mi-main.c (mi_print_exception): Update.
5430         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5431         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5432         * linux-nat.c (linux_nat_target::attach): Update.
5433         * linux-fork.c (class scoped_switch_fork_info): Update.
5434         * infrun.c (displaced_step_prepare): Update.
5435         * infcall.c (call_function_by_hand_dummy): Update.
5436         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5437         * gnu-v3-abi.c (print_one_vtable): Update.
5438         * frame.c (get_prev_frame_always): Update.
5439         * f-valprint.c (info_common_command_for_block): Update.
5440         * exec.c (try_open_exec_file): Update.
5441         * exceptions.c (print_exception, exception_print)
5442         (exception_fprintf, exception_print_same): Update.
5443         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5444         * dwarf-index-cache.c (index_cache::store)
5445         (index_cache::lookup_gdb_index): Update.
5446         * darwin-nat.c (maybe_cache_shell): Update.
5447         * cp-valprint.c (cp_print_value_fields): Update.
5448         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5449         (gcc_cplus_symbol_address): Update.
5450         * compile/compile-c-symbols.c (gcc_convert_symbol)
5451         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5452         * common/selftest.c: Update.
5453         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5454         a std::string.
5455         (exception_try_scope_entry, exception_try_scope_exit): Don't
5456         declare.
5457         (struct exception_try_scope): Remove.
5458         (TRY): Don't use exception_try_scope.
5459         (struct gdb_exception): Add constructor, operator=.
5460         <what>: New method.
5461         (struct gdb_exception_RETURN_MASK_ALL)
5462         (struct gdb_exception_RETURN_MASK_ERROR)
5463         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5464         (struct gdb_quit_bad_alloc): Update.
5465         * common/common-exceptions.c (exception_none): Change
5466         initializer.
5467         (struct catcher) <state, exception>: Initialize inline.
5468         <prev>: Remove member.
5469         (current_catcher): Remove.
5470         (catchers): New global.
5471         (exceptions_state_mc_init): Simplify.
5472         (catcher_pop): Remove.
5473         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5474         (try_scope_depth, exception_try_scope_entry)
5475         (exception_try_scope_exit): Remove.
5476         (throw_exception_sjlj): Update.
5477         (exception_messages, exception_messages_size): Remove.
5478         (throw_it): Simplify.
5479         (gdb_exception_sliced_copy): Remove.
5480         (throw_exception_cxx): Update.
5481         * cli/cli-script.c (script_from_file): Update.
5482         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5483         Update.
5484         * ada-valprint.c (ada_val_print): Update.
5485         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5486         (create_excep_cond_exprs): Update.
5487
5488 2019-04-08  Tom Tromey  <tom@tromey.com>
5489
5490         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5491         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5492         (TRY, CATCH, END_CATCH): Remove some definitions.
5493         * common/common-exceptions.c: Don't use GDB_XCPT.
5494         (catcher_list_size): Remove.
5495         (throw_exception, throw_it): Simplify.
5496
5497 2019-04-05  Tom Tromey  <tom@tromey.com>
5498
5499         Revert the header-sorting patch.
5500         * ft32-tdep.c: Revert.
5501         * frv-tdep.c: Revert.
5502         * frv-linux-tdep.c: Revert.
5503         * frame.c: Revert.
5504         * frame-unwind.c: Revert.
5505         * frame-base.c: Revert.
5506         * fork-child.c: Revert.
5507         * findvar.c: Revert.
5508         * findcmd.c: Revert.
5509         * filesystem.c: Revert.
5510         * filename-seen-cache.h: Revert.
5511         * filename-seen-cache.c: Revert.
5512         * fbsd-tdep.c: Revert.
5513         * fbsd-nat.h: Revert.
5514         * fbsd-nat.c: Revert.
5515         * f-valprint.c: Revert.
5516         * f-typeprint.c: Revert.
5517         * f-lang.c: Revert.
5518         * extension.h: Revert.
5519         * extension.c: Revert.
5520         * extension-priv.h: Revert.
5521         * expprint.c: Revert.
5522         * exec.h: Revert.
5523         * exec.c: Revert.
5524         * exceptions.c: Revert.
5525         * event-top.c: Revert.
5526         * event-loop.c: Revert.
5527         * eval.c: Revert.
5528         * elfread.c: Revert.
5529         * dwarf2read.h: Revert.
5530         * dwarf2read.c: Revert.
5531         * dwarf2loc.c: Revert.
5532         * dwarf2expr.h: Revert.
5533         * dwarf2expr.c: Revert.
5534         * dwarf2-frame.c: Revert.
5535         * dwarf2-frame-tailcall.c: Revert.
5536         * dwarf-index-write.h: Revert.
5537         * dwarf-index-write.c: Revert.
5538         * dwarf-index-common.c: Revert.
5539         * dwarf-index-cache.h: Revert.
5540         * dwarf-index-cache.c: Revert.
5541         * dummy-frame.c: Revert.
5542         * dtrace-probe.c: Revert.
5543         * disasm.h: Revert.
5544         * disasm.c: Revert.
5545         * disasm-selftests.c: Revert.
5546         * dictionary.c: Revert.
5547         * dicos-tdep.c: Revert.
5548         * demangle.c: Revert.
5549         * dcache.h: Revert.
5550         * dcache.c: Revert.
5551         * darwin-nat.h: Revert.
5552         * darwin-nat.c: Revert.
5553         * darwin-nat-info.c: Revert.
5554         * d-valprint.c: Revert.
5555         * d-namespace.c: Revert.
5556         * d-lang.c: Revert.
5557         * ctf.c: Revert.
5558         * csky-tdep.c: Revert.
5559         * csky-linux-tdep.c: Revert.
5560         * cris-tdep.c: Revert.
5561         * cris-linux-tdep.c: Revert.
5562         * cp-valprint.c: Revert.
5563         * cp-support.c: Revert.
5564         * cp-namespace.c: Revert.
5565         * cp-abi.c: Revert.
5566         * corelow.c: Revert.
5567         * corefile.c: Revert.
5568         * continuations.c: Revert.
5569         * completer.h: Revert.
5570         * completer.c: Revert.
5571         * complaints.c: Revert.
5572         * coffread.c: Revert.
5573         * coff-pe-read.c: Revert.
5574         * cli-out.h: Revert.
5575         * cli-out.c: Revert.
5576         * charset.c: Revert.
5577         * c-varobj.c: Revert.
5578         * c-valprint.c: Revert.
5579         * c-typeprint.c: Revert.
5580         * c-lang.c: Revert.
5581         * buildsym.c: Revert.
5582         * buildsym-legacy.c: Revert.
5583         * build-id.h: Revert.
5584         * build-id.c: Revert.
5585         * btrace.c: Revert.
5586         * bsd-uthread.c: Revert.
5587         * breakpoint.h: Revert.
5588         * breakpoint.c: Revert.
5589         * break-catch-throw.c: Revert.
5590         * break-catch-syscall.c: Revert.
5591         * break-catch-sig.c: Revert.
5592         * blockframe.c: Revert.
5593         * block.c: Revert.
5594         * bfin-tdep.c: Revert.
5595         * bfin-linux-tdep.c: Revert.
5596         * bfd-target.c: Revert.
5597         * bcache.c: Revert.
5598         * ax-general.c: Revert.
5599         * ax-gdb.h: Revert.
5600         * ax-gdb.c: Revert.
5601         * avr-tdep.c: Revert.
5602         * auxv.c: Revert.
5603         * auto-load.c: Revert.
5604         * arm-wince-tdep.c: Revert.
5605         * arm-tdep.c: Revert.
5606         * arm-symbian-tdep.c: Revert.
5607         * arm-pikeos-tdep.c: Revert.
5608         * arm-obsd-tdep.c: Revert.
5609         * arm-nbsd-tdep.c: Revert.
5610         * arm-nbsd-nat.c: Revert.
5611         * arm-linux-tdep.c: Revert.
5612         * arm-linux-nat.c: Revert.
5613         * arm-fbsd-tdep.c: Revert.
5614         * arm-fbsd-nat.c: Revert.
5615         * arm-bsd-tdep.c: Revert.
5616         * arch-utils.c: Revert.
5617         * arc-tdep.c: Revert.
5618         * arc-newlib-tdep.c: Revert.
5619         * annotate.h: Revert.
5620         * annotate.c: Revert.
5621         * amd64-windows-tdep.c: Revert.
5622         * amd64-windows-nat.c: Revert.
5623         * amd64-tdep.c: Revert.
5624         * amd64-sol2-tdep.c: Revert.
5625         * amd64-obsd-tdep.c: Revert.
5626         * amd64-obsd-nat.c: Revert.
5627         * amd64-nbsd-tdep.c: Revert.
5628         * amd64-nbsd-nat.c: Revert.
5629         * amd64-nat.c: Revert.
5630         * amd64-linux-tdep.c: Revert.
5631         * amd64-linux-nat.c: Revert.
5632         * amd64-fbsd-tdep.c: Revert.
5633         * amd64-fbsd-nat.c: Revert.
5634         * amd64-dicos-tdep.c: Revert.
5635         * amd64-darwin-tdep.c: Revert.
5636         * amd64-bsd-nat.c: Revert.
5637         * alpha-tdep.c: Revert.
5638         * alpha-obsd-tdep.c: Revert.
5639         * alpha-nbsd-tdep.c: Revert.
5640         * alpha-mdebug-tdep.c: Revert.
5641         * alpha-linux-tdep.c: Revert.
5642         * alpha-linux-nat.c: Revert.
5643         * alpha-bsd-tdep.c: Revert.
5644         * alpha-bsd-nat.c: Revert.
5645         * aix-thread.c: Revert.
5646         * agent.c: Revert.
5647         * addrmap.c: Revert.
5648         * ada-varobj.c: Revert.
5649         * ada-valprint.c: Revert.
5650         * ada-typeprint.c: Revert.
5651         * ada-tasks.c: Revert.
5652         * ada-lang.c: Revert.
5653         * aarch64-tdep.c: Revert.
5654         * aarch64-ravenscar-thread.c: Revert.
5655         * aarch64-newlib-tdep.c: Revert.
5656         * aarch64-linux-tdep.c: Revert.
5657         * aarch64-linux-nat.c: Revert.
5658         * aarch64-fbsd-tdep.c: Revert.
5659         * aarch64-fbsd-nat.c: Revert.
5660         * aarch32-linux-nat.c: Revert.
5661
5662 2019-04-05  Tom Tromey  <tom@tromey.com>
5663
5664         * ft32-tdep.c: Sort headers.
5665         * frv-tdep.c: Sort headers.
5666         * frv-linux-tdep.c: Sort headers.
5667         * frame.c: Sort headers.
5668         * frame-unwind.c: Sort headers.
5669         * frame-base.c: Sort headers.
5670         * fork-child.c: Sort headers.
5671         * findvar.c: Sort headers.
5672         * findcmd.c: Sort headers.
5673         * filesystem.c: Sort headers.
5674         * filename-seen-cache.h: Sort headers.
5675         * filename-seen-cache.c: Sort headers.
5676         * fbsd-tdep.c: Sort headers.
5677         * fbsd-nat.h: Sort headers.
5678         * fbsd-nat.c: Sort headers.
5679         * f-valprint.c: Sort headers.
5680         * f-typeprint.c: Sort headers.
5681         * f-lang.c: Sort headers.
5682         * extension.h: Sort headers.
5683         * extension.c: Sort headers.
5684         * extension-priv.h: Sort headers.
5685         * expprint.c: Sort headers.
5686         * exec.h: Sort headers.
5687         * exec.c: Sort headers.
5688         * exceptions.c: Sort headers.
5689         * event-top.c: Sort headers.
5690         * event-loop.c: Sort headers.
5691         * eval.c: Sort headers.
5692         * elfread.c: Sort headers.
5693         * dwarf2read.h: Sort headers.
5694         * dwarf2read.c: Sort headers.
5695         * dwarf2loc.c: Sort headers.
5696         * dwarf2expr.h: Sort headers.
5697         * dwarf2expr.c: Sort headers.
5698         * dwarf2-frame.c: Sort headers.
5699         * dwarf2-frame-tailcall.c: Sort headers.
5700         * dwarf-index-write.h: Sort headers.
5701         * dwarf-index-write.c: Sort headers.
5702         * dwarf-index-common.c: Sort headers.
5703         * dwarf-index-cache.h: Sort headers.
5704         * dwarf-index-cache.c: Sort headers.
5705         * dummy-frame.c: Sort headers.
5706         * dtrace-probe.c: Sort headers.
5707         * disasm.h: Sort headers.
5708         * disasm.c: Sort headers.
5709         * disasm-selftests.c: Sort headers.
5710         * dictionary.c: Sort headers.
5711         * dicos-tdep.c: Sort headers.
5712         * demangle.c: Sort headers.
5713         * dcache.h: Sort headers.
5714         * dcache.c: Sort headers.
5715         * darwin-nat.h: Sort headers.
5716         * darwin-nat.c: Sort headers.
5717         * darwin-nat-info.c: Sort headers.
5718         * d-valprint.c: Sort headers.
5719         * d-namespace.c: Sort headers.
5720         * d-lang.c: Sort headers.
5721         * ctf.c: Sort headers.
5722         * csky-tdep.c: Sort headers.
5723         * csky-linux-tdep.c: Sort headers.
5724         * cris-tdep.c: Sort headers.
5725         * cris-linux-tdep.c: Sort headers.
5726         * cp-valprint.c: Sort headers.
5727         * cp-support.c: Sort headers.
5728         * cp-namespace.c: Sort headers.
5729         * cp-abi.c: Sort headers.
5730         * corelow.c: Sort headers.
5731         * corefile.c: Sort headers.
5732         * continuations.c: Sort headers.
5733         * completer.h: Sort headers.
5734         * completer.c: Sort headers.
5735         * complaints.c: Sort headers.
5736         * coffread.c: Sort headers.
5737         * coff-pe-read.c: Sort headers.
5738         * cli-out.h: Sort headers.
5739         * cli-out.c: Sort headers.
5740         * charset.c: Sort headers.
5741         * c-varobj.c: Sort headers.
5742         * c-valprint.c: Sort headers.
5743         * c-typeprint.c: Sort headers.
5744         * c-lang.c: Sort headers.
5745         * buildsym.c: Sort headers.
5746         * buildsym-legacy.c: Sort headers.
5747         * build-id.h: Sort headers.
5748         * build-id.c: Sort headers.
5749         * btrace.c: Sort headers.
5750         * bsd-uthread.c: Sort headers.
5751         * breakpoint.h: Sort headers.
5752         * breakpoint.c: Sort headers.
5753         * break-catch-throw.c: Sort headers.
5754         * break-catch-syscall.c: Sort headers.
5755         * break-catch-sig.c: Sort headers.
5756         * blockframe.c: Sort headers.
5757         * block.c: Sort headers.
5758         * bfin-tdep.c: Sort headers.
5759         * bfin-linux-tdep.c: Sort headers.
5760         * bfd-target.c: Sort headers.
5761         * bcache.c: Sort headers.
5762         * ax-general.c: Sort headers.
5763         * ax-gdb.h: Sort headers.
5764         * ax-gdb.c: Sort headers.
5765         * avr-tdep.c: Sort headers.
5766         * auxv.c: Sort headers.
5767         * auto-load.c: Sort headers.
5768         * arm-wince-tdep.c: Sort headers.
5769         * arm-tdep.c: Sort headers.
5770         * arm-symbian-tdep.c: Sort headers.
5771         * arm-pikeos-tdep.c: Sort headers.
5772         * arm-obsd-tdep.c: Sort headers.
5773         * arm-nbsd-tdep.c: Sort headers.
5774         * arm-nbsd-nat.c: Sort headers.
5775         * arm-linux-tdep.c: Sort headers.
5776         * arm-linux-nat.c: Sort headers.
5777         * arm-fbsd-tdep.c: Sort headers.
5778         * arm-fbsd-nat.c: Sort headers.
5779         * arm-bsd-tdep.c: Sort headers.
5780         * arch-utils.c: Sort headers.
5781         * arc-tdep.c: Sort headers.
5782         * arc-newlib-tdep.c: Sort headers.
5783         * annotate.h: Sort headers.
5784         * annotate.c: Sort headers.
5785         * amd64-windows-tdep.c: Sort headers.
5786         * amd64-windows-nat.c: Sort headers.
5787         * amd64-tdep.c: Sort headers.
5788         * amd64-sol2-tdep.c: Sort headers.
5789         * amd64-obsd-tdep.c: Sort headers.
5790         * amd64-obsd-nat.c: Sort headers.
5791         * amd64-nbsd-tdep.c: Sort headers.
5792         * amd64-nbsd-nat.c: Sort headers.
5793         * amd64-nat.c: Sort headers.
5794         * amd64-linux-tdep.c: Sort headers.
5795         * amd64-linux-nat.c: Sort headers.
5796         * amd64-fbsd-tdep.c: Sort headers.
5797         * amd64-fbsd-nat.c: Sort headers.
5798         * amd64-dicos-tdep.c: Sort headers.
5799         * amd64-darwin-tdep.c: Sort headers.
5800         * amd64-bsd-nat.c: Sort headers.
5801         * alpha-tdep.c: Sort headers.
5802         * alpha-obsd-tdep.c: Sort headers.
5803         * alpha-nbsd-tdep.c: Sort headers.
5804         * alpha-mdebug-tdep.c: Sort headers.
5805         * alpha-linux-tdep.c: Sort headers.
5806         * alpha-linux-nat.c: Sort headers.
5807         * alpha-bsd-tdep.c: Sort headers.
5808         * alpha-bsd-nat.c: Sort headers.
5809         * aix-thread.c: Sort headers.
5810         * agent.c: Sort headers.
5811         * addrmap.c: Sort headers.
5812         * ada-varobj.c: Sort headers.
5813         * ada-valprint.c: Sort headers.
5814         * ada-typeprint.c: Sort headers.
5815         * ada-tasks.c: Sort headers.
5816         * ada-lang.c: Sort headers.
5817         * aarch64-tdep.c: Sort headers.
5818         * aarch64-ravenscar-thread.c: Sort headers.
5819         * aarch64-newlib-tdep.c: Sort headers.
5820         * aarch64-linux-tdep.c: Sort headers.
5821         * aarch64-linux-nat.c: Sort headers.
5822         * aarch64-fbsd-tdep.c: Sort headers.
5823         * aarch64-fbsd-nat.c: Sort headers.
5824         * aarch32-linux-nat.c: Sort headers.
5825
5826 2019-04-04  Tom Tromey  <tom@tromey.com>
5827
5828         * varobj.c (varobj_create): Update.
5829         * rust-exp.y (struct rust_parser) <update_innermost_block,
5830         lookup_symbol>: New methods.
5831         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5832         Rename.
5833         (rust_parser::rust_lookup_type)
5834         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5835         * printcmd.c (display_command, do_one_display): Update.
5836         * parser-defs.h (struct parser_state) <parser_state>: Add
5837         "tracker" parameter.
5838         (block_tracker): New member.
5839         (class innermost_block_tracker) <innermost_block_tracker>: Add
5840         "types" parameter.
5841         <reset>: Remove method.
5842         (innermost_block): Don't declare.
5843         (null_post_parser): Update.
5844         * parse.c (innermost_block): Remove global.
5845         (write_dollar_variable): Update.
5846         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5847         Remove "tracker_types" parameter.
5848         (parse_expression): Add "tracker" parameter.
5849         (parse_expression_for_completion): Update.
5850         (null_post_parser): Add "tracker" parameter.
5851         * p-exp.y: Update rules.
5852         * m2-exp.y: Update rules.
5853         * language.h (struct language_defn) <la_post_parser>: Add
5854         "tracker" parameter.
5855         * go-exp.y: Update rules.
5856         * f-exp.y: Update rules.
5857         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5858         parameter.
5859         * d-exp.y: Update rules.
5860         * c-exp.y: Update rules.
5861         * breakpoint.c (set_breakpoint_condition): Create an
5862         innermost_block_tracker.
5863         (watch_command_1): Likewise.
5864         * ada-lang.c (resolve): Add "tracker" parameter.
5865         (resolve_subexp): Likewise.
5866         * ada-exp.y (write_var_from_sym): Update.
5867
5868 2019-04-04  Tom Tromey  <tom@tromey.com>
5869
5870         * type-stack.h: New file.
5871         * type-stack.c: New file.
5872         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5873         type-stack.h.
5874         (insert_into_type_stack, insert_type, push_type, push_type_int)
5875         (insert_type_address_space, pop_type, pop_type_int)
5876         (pop_typelist, pop_type_stack, append_type_stack)
5877         (push_type_stack, get_type_stack, push_typelist)
5878         (follow_type_instance_flags, follow_types): Don't declare.
5879         * parse.c (type_stack): Remove global.
5880         (parse_exp_in_context): Update.
5881         (insert_into_type_stack, insert_type, push_type, push_type_int)
5882         (insert_type_address_space, pop_type, pop_type_int)
5883         (pop_typelist, pop_type_stack, append_type_stack)
5884         (push_type_stack, get_type_stack, push_typelist)
5885         (follow_type_instance_flags, follow_types): Remove (moved to
5886         type-stack.c).
5887         * f-exp.y (type_stack): New global.
5888         Update rules.
5889         (push_kind_type, f_parse): Update.
5890         * d-exp.y (type_stack): New global.
5891         Update rules.
5892         (d_parse): Update.
5893         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5894         Update rules.
5895         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5896         (HFILES_NO_SRCDIR): Add type-stack.h.
5897
5898 2019-04-04  Tom Tromey  <tom@tromey.com>
5899
5900         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5901         (rust_parser::convert_ast_to_expression, rust_parse)
5902         (rust_lex_test_completion, rust_lex_tests): Update.
5903         * parser-defs.h (struct expr_completion_state): New.
5904         (struct parser_state) <parser_state>: Add completion parameter.
5905         <mark_struct_expression, mark_completion_tag>: New methods.
5906         <parse_completion, m_completion_state>: New members.
5907         (prefixify_expression, null_post_parser): Update.
5908         (mark_struct_expression, mark_completion_tag): Don't declare.
5909         * parse.c (parse_completion, expout_last_struct)
5910         (expout_tag_completion_type, expout_completion_name): Remove
5911         globals.
5912         (parser_state::mark_struct_expression)
5913         (parser_state::mark_completion_tag): Now methods.
5914         (prefixify_expression): Add last_struct parameter.
5915         (prefixify_subexp): Likewise.
5916         (parse_exp_1): Update.
5917         (parse_exp_in_context): Add cstate parameter.  Update.
5918         (parse_expression_for_completion): Create an
5919         expr_completion_state.
5920         (null_post_parser): Add "completion" parameter.
5921         * p-exp.y: Update rules.
5922         (yylex): Update.
5923         * language.h (struct language_defn) <la_post_parser>: Add
5924         "completing" parameter.
5925         * go-exp.y: Update rules.
5926         (lex_one_token): Update.
5927         * expression.h (parse_completion): Don't declare.
5928         * d-exp.y: Update rules.
5929         (lex_one_token): Update rules.
5930         * c-exp.y: Update rules.
5931         (lex_one_token): Update.
5932         * ada-lang.c (resolve): Add "parse_completion" parameter.
5933         (resolve_subexp): Likewise.
5934         (ada_resolve_function): Likewise.
5935
5936 2019-04-04  Tom Tromey  <tom@tromey.com>
5937
5938         * parser-defs.h (struct parser_state) <start_arglist,
5939         end_arglist>: New methods.
5940         <arglist_len, m_funcall_chain>: New members.
5941         (arglist_len, start_arglist, end_arglist): Don't declare.
5942         * parse.c (arglist_len, funcall_chain): Remove global.
5943         (start_arglist, end_arglist): Remove functions.
5944         (parse_exp_in_context): Update.
5945         * p-exp.y: Update rules.
5946         * m2-exp.y: Update rules.
5947         * go-exp.y: Update rules.
5948         * f-exp.y: Update rules.
5949         * d-exp.y: Update rules.
5950         * c-exp.y: Update rules.
5951
5952 2019-04-04  Tom Tromey  <tom@tromey.com>
5953
5954         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5955         lex_operator, push_back>: New methods.
5956         Update all rules.
5957         (rust_parser::lex_hex, lex_escape): Rename and update.
5958         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5959         (rust_parser::lex_operator): Rename and update.
5960         (rust_parser::lex_number, rustyylex, rustyyerror)
5961         (rust_lex_test_init, rust_lex_test_sequence)
5962         (rust_lex_test_push_back, rust_lex_tests): Update.
5963         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5964         parameter.
5965         <lexptr, prev_lexptr>: New members.
5966         (lexptr, prev_lexptr): Don't declare.
5967         * parse.c (lexptr, prev_lexptr): Remove globals.
5968         (parse_exp_in_context): Update.
5969         * p-exp.y (yylex, yyerror): Update.
5970         * m2-exp.y (parse_number, yylex, yyerror): Update.
5971         * go-exp.y (lex_one_token, yyerror): Update.
5972         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5973         * d-exp.y (lex_one_token, yyerror): Update.
5974         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5975         (lex_one_token, yyerror): Update.
5976         * ada-lex.l (YY_INPUT): Update.
5977         (rewind_to_char): Update.
5978         * ada-exp.y (yyerror): Update.
5979
5980 2019-04-04  Tom Tromey  <tom@tromey.com>
5981
5982         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5983         * parser-defs.h (struct parser_state) <parser_state>: Add new
5984         parameter.
5985         <comma_terminates>: New member.
5986         (comma_terminates): Don't declare global.
5987         * parse.c (comma_terminates): Remove global.
5988         (parse_exp_in_context): Update.
5989         * p-exp.y (yylex): Update.
5990         * m2-exp.y (yylex): Update.
5991         * go-exp.y (lex_one_token): Update.
5992         * f-exp.y (yylex): Update.
5993         * d-exp.y (lex_one_token): Update.
5994         * c-exp.y (lex_one_token): Update.
5995         * ada-lex.l: Update.
5996
5997 2019-04-04  Tom Tromey  <tom@tromey.com>
5998
5999         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6000         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6001         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6002         * parser-defs.h (paren_depth): Don't declare.
6003         * parse.c (paren_depth): Remove global.
6004         (parse_exp_in_context): Update.
6005         * p-exp.y (paren_depth): New global.
6006         (pascal_parse): Initialize it.
6007         * m2-exp.y (paren_depth): New global.
6008         (m2_parse): Initialize it.
6009         * go-exp.y (paren_depth): New global.
6010         (go_parse): Initialize it.
6011         * f-exp.y (paren_depth): New global.
6012         (f_parse): Initialize it.
6013         * d-exp.y (paren_depth): New global.
6014         (d_parse): Initialize it.
6015         * c-exp.y (paren_depth): New global.
6016         (c_parse): Initialize it.
6017         * ada-lex.l (paren_depth): New global.
6018         (lexer_init): Initialize it.
6019
6020 2019-04-04  Tom Tromey  <tom@tromey.com>
6021
6022         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6023         (rust_parser::convert_ast_to_type)
6024         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6025         * parser-defs.h (struct parser_state) <parser_state>: Add
6026         parameters.  Initialize new members.
6027         <expression_context_block, expression_context_pc>: New members.
6028         * parse.c (expression_context_block, expression_context_pc):
6029         Remove globals.
6030         (parse_exp_in_context): Update.
6031         * p-exp.y: Update all rules.
6032         (yylex): Update.
6033         * m2-exp.y: Update all rules.
6034         (yylex): Update.
6035         * go-exp.y (yylex): Update.
6036         * f-exp.y (yylex): Update.
6037         * d-exp.y: Update all rules.
6038         (yylex): Update.
6039         * c-exp.y: Update all rules.
6040         (lex_one_token, classify_name, yylex, c_parse): Update.
6041         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6042
6043 2019-04-04  Tom Tromey  <tom@tromey.com>
6044
6045         * gdbarch.h, gdbarch.c: Rebuild.
6046         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6047         * stap-probe.h:
6048         (struct stap_parse_info): Replace "parser_state" with
6049         "expr_builder".
6050         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6051         (parser_state): New class.
6052         * parse.c (expr_builder): Rename.
6053         (expr_builder::release): Rename.
6054         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6055         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6056         (write_exp_elt_longcst, write_exp_elt_floatcst)
6057         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6058         (write_exp_string_vector, write_exp_bitstring)
6059         (write_exp_msymbol, mark_struct_expression)
6060         (write_dollar_variable)
6061         (insert_type_address_space, increase_expout_size): Replace
6062         "parser_state" with "expr_builder".
6063         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6064         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6065         "parser_state" with "expr_builder".
6066
6067 2019-04-04  Tom Tromey  <tom@tromey.com>
6068
6069         * rust-exp.y: Replace "parse_language" with method call.
6070         * p-exp.y:
6071         (yylex): Replace "parse_language" with method call.
6072         * m2-exp.y:
6073         (yylex): Replace "parse_language" with method call.
6074         * go-exp.y (classify_name): Replace "parse_language" with method
6075         call.
6076         * f-exp.y (yylex): Replace "parse_language" with method call.
6077         * d-exp.y (lex_one_token): Replace "parse_language" with method
6078         call.
6079         * c-exp.y:
6080         (lex_one_token, classify_name, yylex): Replace "parse_language"
6081         with method call.
6082         * ada-exp.y (find_primitive_type, type_char)
6083         (type_system_address): Replace "parse_language" with method call.
6084
6085 2019-04-04  Tom Tromey  <tom@tromey.com>
6086
6087         * rust-exp.y: Replace "parse_gdbarch" with method call.
6088         * parse.c (write_dollar_variable, insert_type_address_space):
6089         Replace "parse_gdbarch" with method call.
6090         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6091         call.
6092         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6093         call.
6094         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6095         "parse_gdbarch" with method call.
6096         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6097         with method call.
6098         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6099         "parse_gdbarch" with method call.
6100         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6101         "parse_gdbarch" with method call.
6102         * c-exp.y (parse_type, parse_number, classify_name): Replace
6103         "parse_gdbarch" with method call.
6104         * ada-lex.l: Replace "parse_gdbarch" with method call.
6105         * ada-exp.y (parse_type, find_primitive_type, type_char)
6106         (type_system_address): Replace "parse_gdbarch" with method call.
6107
6108 2019-04-04  Tom Tromey  <tom@tromey.com>
6109
6110         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6111         * stap-probe.c (stap_parse_argument): Update.
6112         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6113         initial_size parameter.
6114         * rust-exp.y (rust_lex_tests): Update.
6115         * parse.c (parser_state): Update.
6116         (parse_exp_in_context): Update.
6117         * parser-defs.h (struct parser_state) <parser_state>: Remove
6118         "initial_size" parameter.
6119
6120 2019-04-04  Tom Tromey  <tom@tromey.com>
6121
6122         * parser-defs.h (increase_expout_size): Don't declare.
6123         * parse.c (increase_expout_size): Now static.
6124
6125 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6126
6127         * gnu-nat.c (gnu_nat_target::wait): Fix
6128         target_waitstatus_to_string call.
6129
6130 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6131
6132         * eval.c (evaluate_subexp_standard): Handle internal functions
6133         during Fortran function call handling.
6134
6135 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6136
6137         * NEWS: Mention new internal functions.
6138         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6139         (read_base_type): Use dwarf2_init_complex_target_type.
6140         * value.c (creal_internal_fn): New function.
6141         (cimag_internal_fn): New function.
6142         (_initialize_values): Register new internal functions.
6143
6144 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6145
6146         * infrun.c (stop_all_threads): If debug_infrun, always
6147         trace the wait status after wait_one, using
6148         target_waitstatus_to_string and target_pid_to_str.
6149         (handle_inferior_event): Replace various trace of
6150         wait status kind by a single trace.
6151         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6152         wait status kind image by target_waitstatus_to_string.
6153         * target/waitstatus.c (target_waitstatus_to_string): Fix
6154         obsolete comment.
6155
6156 2019-04-01  Tom Tromey  <tromey@adacore.com>
6157
6158         PR symtab/23331:
6159         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6160
6161 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6162             Pedro Alves  <palves@redhat.com>
6163
6164         * top.c (quit_force): Call 'finalize_values'.
6165         * value.c (finalize_values): New function.
6166         * value.h (finalize_values): Declare.
6167
6168 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6169
6170         * NEWS: Announce $_gdb_major and $_gdb_minor.
6171
6172         * top.c (init_gdb_version_vars): New function.
6173         (gdb_init): Call init_gdb_version_vars.
6174
6175 2019-03-29  Tom Tromey  <tromey@adacore.com>
6176
6177         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6178         help text.  Remove dead code.
6179
6180 2019-03-29  Keith Seitz  <keiths@redhat.com>
6181
6182         From Siddhesh Poyarekar:
6183         * f-lang.h (f77_get_upperbound): Return LONGEST.
6184         (f77_get_lowerbound): Likewise.
6185         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6186         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6187         print them.
6188         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6189         plongest to format print it.
6190         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6191         (f77_get_upperbound): Likewise.
6192         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6193         LOWER_BOUND to LONGEST.
6194         (f77_create_arrayprint_offset_tbl): Likewise.
6195
6196 2019-03-29  Keith Seitz  <keiths@redhat.com>
6197
6198         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6199         %s/pulongest for TYPE_LENGTH instead of %d in format
6200         strings.
6201         * ada-typerint.c (ada_print_type): Likewise.
6202         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6203         * compile/compile-c-support.c (generate_register_struct): Likewise.
6204         * gdbtypes.c (recursive_dump_type): Likewise.
6205         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6206         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6207         instead of %d in format strings.
6208         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6209         to std::min to ULONGEST.
6210         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6211         instead of %d in format strings.
6212         * tracepoint.c (info_scope_command): Likewise.
6213         * typeprint.c (print_offset_data::update)
6214         (print_offset_data::finish): Likewise.
6215         * xtensa-tdep.c (xtensa_store_return_value)
6216         (xtensa_push_dummy_call): Likewise.
6217
6218 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6219
6220         * windows-nat.c (display_selector): Fixed format specifications
6221         for 64-bit Cygwin.
6222
6223 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6224
6225         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6226
6227 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6228
6229         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6230         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6231         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6232         (nios2_linux_init_abi): Install it.
6233
6234 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6235
6236         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6237
6238 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6239
6240         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6241
6242 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6243             Tom Tromey  <tromey@adacore.com>
6244
6245         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6246
6247 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6248
6249         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6250         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6251         method to compute the bounds of range types. Also print "[evaluated]"
6252         if the bounds' values come from a dynamic evaluation.
6253
6254 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6255
6256         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6257         whitespace when pretty printing is on.
6258
6259 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6260
6261         * ppc-linux-nat.c: Add include.
6262
6263 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6264
6265         * NEWS: Mention AArch64 Pointer Authentication.
6266
6267 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6268
6269         * arm-linux-nat.c: Add include.
6270
6271 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6272
6273         * source-cache.c (source_cache::get_source_lines): Re-read
6274         fullname after calling open_source_file.
6275
6276 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6277
6278         * NEWS: Mention TLS support for FreeBSD.
6279
6280 2019-03-25  Tom Tromey  <tromey@adacore.com>
6281
6282         * minsyms.c (BUNCH_SIZE): Update comment.
6283         (~minimal_symbol_reader): Remove old comment.
6284         (compact_minimal_symbols): Update comment.
6285         (minimal_symbol_reader::install): Remove old comment.  Update
6286         other comments.
6287
6288 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6289
6290         * s390-linux-nat.c: Add include.
6291
6292 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6293
6294         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6295         Call linux_get_hwcap.
6296         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6297         Likewise.
6298         (aarch64_linux_get_hwcap): Remove function.
6299         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6300         declaration.
6301         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6302         linux_get_hwcap.
6303         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6304         * linux-tdep.c (linux_get_hwcap): Add function.
6305         (linux_get_hwcap2): Likewise.
6306         * linux-tdep.h (linux_get_hwcap): Add declaration.
6307         (linux_get_hwcap2): Likewise.
6308         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6309         (ppc_linux_get_hwcap2): Likewise.
6310         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6311         linux_get_hwcap.
6312         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6313         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6314         (ppc_linux_nat_target::read_description): Likewise.
6315         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6316         * s390-linux-nat.c: Likewise.
6317         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6318
6319 2019-03-24  Tom Tromey  <tom@tromey.com>
6320
6321         * ada-lang.c (standard_lookup): Simplify initialization.
6322         (ada_lookup_symbol_nonlocal): Simplify return.
6323         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6324         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6325         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6326         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6327         initialization.
6328         * solib.c (solib_global_lookup): Simplify.
6329         * symtab.c (null_block_symbol): Remove.
6330         (symbol_cache_lookup): Simplify returns.
6331         (lookup_language_this): Simplify returns.
6332         (lookup_symbol_aux): Simplify return.
6333         (lookup_local_symbol): Simplify returns.
6334         (lookup_global_symbol_from_objfile): Simplify return.
6335         (lookup_symbol_in_objfile_symtabs)
6336         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6337         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6338         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6339         * cp-namespace.c (cp_lookup_bare_symbol)
6340         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6341         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6342         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6343         (cp_lookup_symbol_via_imports): Simplify initialization.
6344         (find_symbol_in_baseclass): Likewise.
6345         * symtab.h (null_block_symbol): Remove.
6346         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6347         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6348         (d_lookup_symbol_module): Likewise.
6349         (find_symbol_in_baseclass): Simplify initialization.
6350
6351 2019-03-24  Tom Tromey  <tom@tromey.com>
6352
6353         * expression.h: Don't include symtab.h.
6354         (struct block): Forward declare.
6355
6356 2019-03-24  Tom Tromey  <tom@tromey.com>
6357
6358         * c-exp.y (typebase): Remove casts.
6359         * gdbtypes.c (lookup_unsigned_typename, )
6360         (lookup_signed_typename): Remove cast.
6361         * eval.c (parse_to_comma_and_eval): Remove cast.
6362         * parse.c (write_dollar_variable): Remove cast.
6363         * block.h (struct block) <superblock>: Now const.
6364         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6365         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6366         (map_block): Make "block" const.
6367         * symfile.h (struct quick_symbol_functions)
6368         <map_matching_symbols>: Constify block argument to "callback".
6369         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6370         const.
6371         (find_pc_sect_compunit_symtab): Make "b" const.
6372         (find_symbol_at_address): Likewise.
6373         (search_symbols): Likewise.
6374         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6375         (dw2_debug_names_lookup_symbol): Likewise.
6376         (dw2_map_matching_symbols): Update.
6377         * p-valprint.c (pascal_val_print): Remove "block".
6378         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6379         (aux_add_nonlocal_symbols): Make "block" const.
6380         (resolve_subexp): Remove cast.
6381         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6382         const.
6383         (iterate_over_file_blocks): Likewise.
6384         * f-exp.y (%union) <bval>: Remove.
6385         * coffread.c (patch_opaque_types): Make "b" const.
6386         * spu-tdep.c (spu_catch_start): Make "block" const.
6387         * c-valprint.c (print_unpacked_pointer): Remove "block".
6388         * symmisc.c (dump_symtab_1): Make "b" const.
6389         (block_depth): Make "block" const.
6390         * d-exp.y (%union) <bval>: Remove.
6391         * cp-support.h (cp_lookup_rtti_type): Update.
6392         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6393         * psymtab.c (psym_lookup_symbol): Make "block" const.
6394         (maintenance_check_psymtabs): Make "b" const.
6395         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6396         (enumerate_locals, enumerate_args): Update.
6397         * python/py-symtab.c (stpy_global_block): Make "block" const.
6398         (stpy_static_block): Likewise.
6399         * inline-frame.c (block_starting_point_at): Make "new_block"
6400         const.
6401         * block.c (find_block_in_blockvector): Make return type const.
6402         (blockvector_for_pc_sect): Make "b" const.
6403         (find_block_in_blockvector): Make "b" const.
6404
6405 2019-03-23  Tom Tromey  <tom@tromey.com>
6406
6407         * varobj.c (varobj_create): Update.
6408         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6409         * printcmd.c (display_command, do_one_display): Don't reset
6410         innermost_block.
6411         * parser-defs.h (enum innermost_block_tracker_type): Move to
6412         expression.h.
6413         (innermost_block): Update comment.
6414         * parse.c (parse_exp_1): Add tracker_types parameter.
6415         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6416         tracker_types parameter.  Reset innermost_block.
6417         (parse_exp_in_context): Remove.
6418         (parse_expression_for_completion): Update.
6419         * objfiles.c (~objfile): Don't reset expression_context_block or
6420         innermost_block.
6421         * expression.h (enum innermost_block_tracker_type): Move from
6422         parser-defs.h.
6423         (parse_exp_1): Add tracker_types parameter.
6424         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6425         reset innermost_block.
6426
6427 2019-03-23  Tom Tromey  <tom@tromey.com>
6428
6429         * objfiles.h: Include bcache.h.
6430
6431 2019-03-23  Tom Tromey  <tom@tromey.com>
6432
6433         * linespec.c (get_current_search_block): Use
6434         scoped_restore_current_language.
6435         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6436
6437 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6438             Jiong Wang  <jiong.wang@arm.com>
6439
6440         * aarch64-linux-tdep.c
6441         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6442         section.
6443         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6444
6445 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6446             Jiong Wang  <jiong.wang@arm.com>
6447
6448         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6449         instructions.
6450         (aarch64_analyze_prologue_test): Add PACIASP test.
6451         (aarch64_prologue_prev_register): Unmask PC value.
6452
6453 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6454             Jiong Wang  <jiong.wang@arm.com>
6455
6456         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6457         (aarch64_dwarf2_prev_register): Unmask PC value.
6458         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6459         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6460         DW_CFA_AARCH64_negate_ra_state.
6461         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6462
6463 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6464             Jiong Wang  <jiong.wang@arm.com>
6465
6466         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6467         registers.
6468         (aarch64_pseudo_register_name): Likewise.
6469         (aarch64_pseudo_register_type): Likewise.
6470         (aarch64_pseudo_register_reggroup_p): Likewise.
6471         (aarch64_gdbarch_init): Add pauth registers.
6472         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6473         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6474         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6475         (struct gdbarch_tdep): Add regnum for ra_state.
6476
6477 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6478             Jiong Wang  <jiong.wang@arm.com>
6479
6480         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6481
6482 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6483             Jiong Wang  <jiong.wang@arm.com>
6484
6485         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6486         function.
6487         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6488         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6489         (aarch64_gdbarch_init): Add puth registers.
6490         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6491         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6492         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6493
6494 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6495             Jiong Wang  <jiong.wang@arm.com>
6496
6497         * aarch64-linux-nat.c
6498         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6499         * aarch64-linux-tdep.c
6500         (aarch64_linux_core_read_description): Likewise.
6501         (aarch64_linux_get_hwcap): New function.
6502         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6503         (aarch64_linux_get_hwcap): New declaration.
6504
6505 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6506             Jiong Wang  <jiong.wang@arm.com>
6507
6508         * aarch64-linux-nat.c
6509         (aarch64_linux_nat_target::read_description): Add pauth param.
6510         * aarch64-linux-tdep.c
6511         (aarch64_linux_core_read_description): Likewise.
6512         * aarch64-tdep.c (struct target_desc): Add in pauth.
6513         (aarch64_read_description): Add pauth param.
6514         (aarch64_gdbarch_init): Likewise.
6515         * aarch64-tdep.h (aarch64_read_description): Likewise.
6516         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6517         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6518         * features/Makefile: Add new files.
6519         * features/aarch64-pauth.c: New file.
6520         * features/aarch64-pauth.xml: New file.
6521
6522 2019-03-20  Tom Tromey  <tromey@adacore.com>
6523
6524         * infrun.c (handle_inferior_event): Rename from
6525         handle_inferior_event_1.  Create a scoped_value_mark.
6526         (handle_inferior_event): Remove.
6527
6528 2019-03-19  Tom Tromey  <tromey@adacore.com>
6529
6530         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6531         * infrun.h (print_stop_event): Add "displays" parameter.
6532         * infrun.c (print_stop_event): Add "displays" parameter.
6533
6534 2019-03-19  Pedro Alves  <palves@redhat.com>
6535
6536         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6537         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6538         to -1.  Fix TABs vs spaces.
6539         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6540         * tui/tui-out.h (tui_ui_out) Add intro comments.
6541         <m_line, m_start_of_line>: In-class initialize, and add describing
6542         comment.
6543
6544 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6545
6546         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6547         variable names.
6548         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6549
6550 2019-03-18  Pedro Alves  <palves@redhat.com>
6551             Eli Zaretskii <eliz@gnu.org>
6552
6553         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6554         m_line and m_start_of_line.
6555
6556 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6557
6558         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6559         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6560         it returns a newline.  This fixes a regression in TU mode, whereby
6561         the next line is output on the same screen line as the user input.
6562
6563 2019-03-18  Tom Tromey  <tromey@adacore.com>
6564
6565         * minsyms.c (minimal_symbol_reader::install): Remove call to
6566         obstack_blank.
6567
6568 2019-03-18  Pedro Alves  <palves@redhat.com>
6569
6570         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6571         New globals.
6572         (apply_style): New, factored out from ...
6573         (apply_ansi_escape): ... this.  Handle reverse video mode.
6574         (tui_set_reverse_mode): New function.
6575         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6576         * tui/tui-winsource.c (tui_show_source_line): Use
6577         tui_set_reverse_mode instead of setting A_STANDOUT.
6578         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6579         New setter methods.
6580
6581 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6582
6583         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6584         Handle tabs.
6585
6586 2019-03-18  Tom Tromey  <tromey@adacore.com>
6587
6588         * ada-lang.c (empty_array): Add "high" parameter.
6589         (ada_evaluate_subexp): Update.
6590
6591 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6592
6593         * unittests/string_view-selftests.c: Define
6594         _initialize_string_view_selftests unconditionally.
6595
6596 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6597
6598         PR gdb/24350
6599         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6600
6601 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6602
6603         PR gdb/24351
6604         * windows-nat.c (display_selector): Fix format specifiers.
6605
6606 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6607
6608         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6609         tui_refill_source_window instead of tui_refresh_win, to update the
6610         current execution line.  This fixes redisplay of the current line
6611         when stepping through the code with "next" or "step".
6612
6613 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6614
6615         * source-cache.c (source_cache::get_source_lines): Call
6616         find_source_lines to initialize s->nlines.  This fixes vertical
6617         scrolling of TUI source window when the DOWN arrow is pressed.
6618
6619 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6620
6621         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6622         linux-thread-db.c (_initialize_thread_db): Likewise.
6623
6624 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6625
6626         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6627         wclrtoeol in tui_show_source_line".  This reverts changes made in
6628         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6629
6630 2019-03-15  Tom Tromey  <tom@tromey.com>
6631
6632         * symtab.h (struct minimal_symbol): Derive from
6633         general_symbol_info.
6634         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6635         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6636         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6637         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6638         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6639         (MSYMBOL_SEARCH_NAME): Update.
6640         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6641         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6642         * minsyms.c (minimal_symbol_reader::record_full): Update.
6643
6644 2019-03-15  Tom Tromey  <tom@tromey.com>
6645
6646         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6647
6648 2019-03-15  Tom Tromey  <tom@tromey.com>
6649
6650         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6651         unique_xmalloc_ptr.
6652         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6653         Update.
6654         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6655         (build_minimal_symbol_hash_tables)
6656         (minimal_symbol_reader::install): Update.
6657
6658 2019-03-15  Tom Tromey  <tom@tromey.com>
6659
6660         * symtab.c (create_demangled_names_hash): Update.
6661         (symbol_set_names): Update.
6662         * objfiles.h (struct objfile_per_bfd_storage)
6663         <demangled_names_hash>: Now an htab_up.
6664         * objfiles.c (objfile_per_bfd_storage): Simplify.
6665
6666 2019-03-15  Tom Tromey  <tom@tromey.com>
6667
6668         * objfiles.h (struct objfile_per_bfd_storage): Declare
6669         destructor.
6670         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6671         New.
6672         (get_objfile_bfd_data): Use new.  Don't initialize
6673         language_of_main.
6674         (free_objfile_per_bfd_storage): Remove.
6675         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6676
6677 2019-03-15  Tom Tromey  <tom@tromey.com>
6678
6679         * symfile.c (reread_symbols): Update.
6680         * objfiles.c (objfile::objfile): Update.
6681         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6682         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6683         comment.
6684         (minimal_symbol_reader::install): Update.
6685         (terminate_minimal_symbol_table): Remove.
6686         * jit.c (jit_object_close_impl): Update.
6687
6688 2019-03-15  Tom Tromey  <tom@tromey.com>
6689
6690         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6691         initializations.
6692
6693 2019-03-15  Tom Tromey  <tom@tromey.com>
6694
6695         * objfiles.h (struct objfile_per_bfd_storage)
6696         <demangled_hash_languages>: Now a bitset.
6697         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6698         (lookup_minimal_symbol): Update.
6699
6700 2019-03-15  Tom Tromey  <tom@tromey.com>
6701
6702         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6703         Don't return the symbol.
6704         * coffread.c (record_minimal_symbol): Use record_full.
6705
6706 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6707
6708         The MS-Windows port of ncurses fails to switch to a color pair if
6709         one or both of the colors are the implicit default colors.  This
6710         change records the default colors when TUI is initialized, and
6711         then specifies them explicitly when a color pair uses the default
6712         colors.  This allows color styling in TUI mode on MS-Windows.
6713
6714         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6715         ncurses_norm_attr.
6716         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6717         colors in ncurses_norm_attr.
6718         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6719         "none", replace it with the default color recorded in
6720         ncurses_norm_attr.
6721
6722 2019-03-14  Tom Tromey  <tromey@adacore.com>
6723
6724         * source-cache.h (class source_cache) <get_source_lines>: Return
6725         std::string.
6726         * source-cache.c (source_cache::extract_lines): Handle case where
6727         first_pos==npos.  Return std::string.
6728         (source_cache::get_source_lines): Update.
6729
6730 2019-03-14  Tom Tromey  <tromey@adacore.com>
6731
6732         * NEWS: Add item for "style sources" commands.
6733         * source-cache.c (source_cache::get_source_lines): Check
6734         source_styling.
6735         * cli/cli-style.c (source_styling): New global.
6736         (_initialize_cli_style): Add "style sources" commands.
6737         (show_style_sources): New function.
6738         * cli/cli-style.h (source_styling): Declare.
6739
6740 2019-03-14  Pedro Alves  <palves@redhat.com>
6741             Tom Tromey  <tromey@adacore.com>
6742
6743         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6744         * tui/tui-winsource.c (tui_refill_source_window): New function,
6745         from...
6746         (tui_horizontal_source_scroll): ... here.  Move some logic.
6747         * cli/cli-style.c (set_style_enabled): Notify new observable.
6748         * tui/tui-hooks.c (tui_redisplay_source): New function.
6749         (tui_attach_detach_observers): Attach or detach
6750         tui_redisplay_source.
6751         * observable.h (source_styling_changed): New observable.
6752         * observable.c: Define source_styling_changed observable.
6753
6754 2019-03-13  Tom Tromey  <tromey@adacore.com>
6755
6756         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6757         (i386_gnu_nat_target::store_registers): Update.
6758         * target-debug.h (target_debug_print_std_string): New macro.
6759         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6760         * windows-tdep.c (display_one_tib): Update.
6761         * tui/tui-stack.c (tui_make_status_line): Update.
6762         * top.c (print_inferior_quit_action): Update.
6763         * thread.c (thr_try_catch_cmd): Update.
6764         (add_thread_with_info): Update.
6765         (thread_target_id_str): Update.
6766         (thr_try_catch_cmd): Update.
6767         (thread_command): Update.
6768         (thread_find_command): Update.
6769         * record-btrace.c (record_btrace_target::info_record)
6770         (record_btrace_resume_thread, record_btrace_target::resume)
6771         (record_btrace_cancel_resume, record_btrace_step_thread)
6772         (record_btrace_target::wait, record_btrace_target::wait)
6773         (record_btrace_target::wait, record_btrace_target::stop): Update.
6774         * progspace.c (print_program_space): Update.
6775         * process-stratum-target.c
6776         (process_stratum_target::thread_address_space): Update.
6777         * linux-fork.c (linux_fork_mourn_inferior)
6778         (detach_checkpoint_command, info_checkpoints_command)
6779         (linux_fork_context): Update.
6780         (linux_fork_detach): Update.
6781         (class scoped_switch_fork_info): Update.
6782         (delete_checkpoint_command): Update.
6783         * infrun.c (follow_fork_inferior): Update.
6784         (follow_fork_inferior): Update.
6785         (proceed_after_vfork_done): Update.
6786         (handle_vfork_child_exec_or_exit): Update.
6787         (follow_exec): Update.
6788         (displaced_step_prepare_throw): Update.
6789         (displaced_step_restore): Update.
6790         (start_step_over): Update.
6791         (resume_1): Update.
6792         (clear_proceed_status_thread): Update.
6793         (proceed): Update.
6794         (print_target_wait_results): Update.
6795         (do_target_wait): Update.
6796         (context_switch): Update.
6797         (stop_all_threads): Update.
6798         (restart_threads): Update.
6799         (finish_step_over): Update.
6800         (handle_signal_stop): Update.
6801         (switch_back_to_stepped_thread): Update.
6802         (keep_going_pass_signal): Update.
6803         (print_exited_reason): Update.
6804         (normal_stop): Update.
6805         * inferior.c (inferior_pid_to_str): Change return type.
6806         (print_selected_inferior): Update.
6807         (add_inferior): Update.
6808         (detach_inferior): Update.
6809         * dummy-frame.c (fprint_dummy_frames): Update.
6810         * dcache.c (dcache_info_1): Update.
6811         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6812         (btrace_fetch, btrace_clear): Update.
6813         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6814         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6815         type.
6816         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6817         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6818         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6819         * gdbarch.c, gdbarch.h: Rebuild.
6820         * gdbarch.sh (core_pid_to_str): Change return type.
6821         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6822         return type.
6823         (windows_nat_target::pid_to_str): Change return type.
6824         (windows_delete_thread): Update.
6825         (windows_nat_target::attach): Update.
6826         (windows_nat_target::files_info): Update.
6827         * target-delegates.c: Rebuild.
6828         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6829         return type.
6830         (sol_thread_target::pid_to_str): Change return type.
6831         * remote.c (class remote_target) <pid_to_str>: Change return
6832         type.
6833         (remote_target::pid_to_str): Change return type.
6834         (extended_remote_target::attach, remote_target::remote_stop_ns)
6835         (remote_target::remote_notif_remove_queued_reply)
6836         (remote_target::push_stop_reply, remote_target::disable_btrace):
6837         Update.
6838         (extended_remote_target::attach): Update.
6839         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6840         type.
6841         (gdbsim_target::pid_to_str): Change return type.
6842         * ravenscar-thread.c (struct ravenscar_thread_target)
6843         <pid_to_str>: Change return type.
6844         (ravenscar_thread_target::pid_to_str): Change return type.
6845         * procfs.c (class procfs_target) <pid_to_str>: Change return
6846         type.
6847         (procfs_target::pid_to_str): Change return type.
6848         (procfs_target::attach): Update.
6849         (procfs_target::detach): Update.
6850         (procfs_target::fetch_registers): Update.
6851         (procfs_target::store_registers): Update.
6852         (procfs_target::wait): Update.
6853         (procfs_target::files_info): Update.
6854         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6855         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6856         return type.
6857         (nto_procfs_target::pid_to_str): Change return type.
6858         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6859         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6860         return type.
6861         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6862         (exit_lwp): Update.
6863         (attach_proc_task_lwp_callback, get_detach_signal)
6864         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6865         (linux_nat_target::resume, wait_lwp, stop_callback)
6866         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6867         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6868         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6869         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6870         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6871         type.
6872         (inf_ptrace_target::attach): Update.
6873         (inf_ptrace_target::files_info): Update.
6874         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6875         type.
6876         (go32_nat_target::pid_to_str): Change return type.
6877         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6878         (gnu_nat_target::wait): Update.
6879         (gnu_nat_target::wait): Update.
6880         (gnu_nat_target::resume): Update.
6881         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6882         (fbsd_nat_target::wait): Update.
6883         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6884         type.
6885         (darwin_nat_target::attach): Update.
6886         * corelow.c (class core_target) <pid_to_str>: Change return type.
6887         (core_target::pid_to_str): Change return type.
6888         * target.c (normal_pid_to_str): Change return type.
6889         (default_pid_to_str): Likewise.
6890         (target_pid_to_str): Change return type.
6891         (target_translate_tls_address): Update.
6892         (target_announce_detach): Update.
6893         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6894         return type.
6895         (bsd_uthread_target::pid_to_str): Change return type.
6896         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6897         type.
6898         (bsd_kvm_target::pid_to_str): Change return type.
6899         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6900         return type.
6901         (aix_thread_target::pid_to_str): Change return type.
6902         * target.h (struct target_ops) <pid_to_str>: Change return type.
6903         (target_pid_to_str, normal_pid_to_str): Likewise.
6904         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6905         type.
6906         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6907         type.
6908         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6909         return type.
6910         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6911         type.
6912         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6913         type.
6914         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6915         return type.
6916
6917 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6918
6919         * NEWS: Mention that the new default MI version is 3.  Mention
6920         changes to the output of commands and events that deal with
6921         multi-location breakpoints.
6922         * breakpoint.c: Include "mi/mi-out.h".
6923         (print_one_breakpoint): Change output syntax if using MI version
6924         >= 3.
6925         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6926         New.
6927         (mi_multi_location_breakpoint_output_fixed): New.
6928         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6929         (mi_cmd_fix_multi_location_breakpoint_output): New.
6930         (mi_multi_location_breakpoint_output_fixed): New.
6931         * mi/mi-cmds.c (mi_cmds): Register command
6932         -fix-multi-location-breakpoint-output.
6933         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6934         interpreter "mi".
6935
6936 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6937
6938         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6939         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6940         instantiate mi_ui_out based on interpreter name.
6941         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6942         * mi/mi-main.c (mi_load_progress): Likewise.
6943
6944 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6945
6946         * NEWS: Combine separate "New targets" sections for 8.3.
6947
6948 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6949
6950         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6951         (ppcfbsd_init_abi): Install gdbarch
6952         "fetch_tls_load_module_address" and "get_thread_local_address"
6953         methods.
6954
6955 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6956
6957         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6958         (riscv_fbsd_init_abi): Install gdbarch
6959         "fetch_tls_load_module_address" and "get_thread_local_address"
6960         methods.
6961
6962 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6963
6964         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6965         (i386fbsd_init_abi): Install gdbarch
6966         "fetch_tls_load_module_address" and "get_thread_local_address"
6967         methods.
6968
6969 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6970
6971         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6972         (amd64fbsd_init_abi): Install gdbarch
6973         "fetch_tls_load_module_address" and "get_thread_local_address"
6974         methods.
6975
6976 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6977
6978         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6979         (struct fbsd_pspace_data): New type.
6980         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6981         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6982         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6983         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6984         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6985
6986 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6987
6988         * gdbtypes.c (lookup_struct_elt): New function.
6989         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6990         * gdbtypes.h (struct struct_elt): New type.
6991         (lookup_struct_elt): New prototype.
6992
6993 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6994
6995         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6996         remove disabled code block.
6997
6998 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6999
7000         * gdbarch.sh (get_thread_local_address): New method.
7001         * gdbarch.h, gdbarch.c: Regenerate.
7002         * target.c (target_translate_tls_address): Use
7003         gdbarch_get_thread_local_address if present instead of
7004         target::get_thread_local_address.
7005
7006 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7007
7008         * target.h (target::get_thread_local_address): Update comment.
7009
7010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7011
7012         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7013         objfile->separate_debug_objfile_backlink if not NULL.
7014
7015 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7016
7017         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7018         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7019         (amd64bsd_store_inferior_registers): Likewise.
7020         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7021         Enable segment base registers.
7022         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7023         PT_GETFSBASE and PT_GETGSBASE.
7024         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7025         PT_SETGSBASE.
7026         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7027         segment base registers.
7028         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7029
7030 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7031
7032         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7033         Update calls to i386_target_description to add 'segments'
7034         parameter.
7035         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7036         add segment base registers.
7037         * arch/i386.c (i386_create_target_description): Add 'segments'
7038         parameter to enable segment base registers.
7039         * arch/i386.h (i386_create_target_description): Likewise.
7040         * features/i386/32bit-segments.xml: New file.
7041         * features/i386/32bit-segments.c: Generate.
7042         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7043         call to i386_target_description to add 'segments' parameter.
7044         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7045         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7046         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7047         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7048         if feature is present.
7049         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7050         Add 'segments' parameter to call to i386_target_description.
7051         (i386_target_description): Add 'segments' parameter to enable
7052         segment base registers.
7053         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7054         to call to i386_target_description.
7055         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7056         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7057         Define I386_NUM_REGS.
7058         (i386_target_description): Add 'segments' parameter to enable
7059         segment base registers.
7060
7061 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7062
7063         PR/24325
7064         * source-cache.c: #undef open and close, to avoid unresolved
7065         externals during linking.
7066
7067 2019-03-12  Tom Tromey  <tromey@adacore.com>
7068
7069         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7070         const.  Add initializers.
7071         (_initialize_remote): Don't initialize ptid globals.
7072
7073 2019-03-12  Pedro Alves  <palves@redhat.com>
7074
7075         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7076
7077 2019-03-12  Pedro Alves  <palves@redhat.com>
7078
7079         * cp-name-parser.y (main): Remove unused 'len' variable.
7080
7081 2019-03-12  Tom Tromey  <tromey@adacore.com>
7082
7083         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7084         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7085
7086 2019-03-12  Tom Tromey  <tromey@adacore.com>
7087
7088         * linux-nat.c (iterate_over_lwps): Update.
7089         (stop_callback): Remove parameter.
7090         (stop_wait_callback, detach_callback, resume_set_callback)
7091         (select_singlestep_lwp_callback, set_ignore_sigint)
7092         (status_callback, resumed_callback, resume_clear_callback)
7093         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7094         data parameter.
7095         (linux_nat_target::detach, linux_nat_target::resume)
7096         (linux_stop_and_wait_all_lwps, select_event_lwp)
7097         (linux_nat_filter_event, linux_nat_wait_1)
7098         (linux_nat_target::kill, linux_nat_target::stop)
7099         (linux_nat_target::stop): Update.
7100         (linux_nat_resume_callback): Change type.
7101         (resume_stopped_resumed_lwps, count_events_callback)
7102         (select_event_lwp_callback): Likewise.
7103         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7104         * arm-linux-nat.c (struct update_registers_data): Remove.
7105         (update_registers_callback): Change type.
7106         (arm_linux_insert_hw_breakpoint1): Update.
7107         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7108         parameter.
7109         (x86_linux_dr_set_addr): Update.
7110         (x86_linux_dr_set_control): Update.
7111         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7112         (iterate_over_lwps): Use gdb::function_view.
7113         * nat/aarch64-linux-hw-point.c (struct
7114         aarch64_dr_update_callback_param): Remove.
7115         (debug_reg_change_callback): Change type.
7116         (aarch64_notify_debug_reg_change): Update.
7117         * s390-linux-nat.c (s390_refresh_per_info): Update.
7118
7119 2019-03-11  Tom Tromey  <tromey@adacore.com>
7120
7121         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7122         redundant assignment to "this_cu".
7123
7124 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7125
7126         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7127
7128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7129
7130         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7131         from...
7132         (rank_one_type): ... this.
7133
7134 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7135
7136         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7137         from...
7138         (rank_one_type): ... this.
7139
7140 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7141
7142         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7143         from...
7144         (rank_one_type): ... this.
7145
7146 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7147
7148         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7149         from...
7150         (rank_one_type): ... this.
7151
7152 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7153
7154         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7155         from...
7156         (rank_one_type): ... this.
7157
7158 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7159
7160         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7161         from...
7162         (rank_one_type): ... this.
7163
7164 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7165
7166         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7167         from...
7168         (rank_one_type): ... this.
7169
7170 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7171
7172         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7173         from...
7174         (rank_one_type): ... this.
7175
7176 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7177
7178         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7179         from...
7180         (rank_one_type): ... this.
7181
7182 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7183
7184         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7185         from...
7186         (rank_one_type): ... this.
7187
7188 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7189
7190         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7191         from...
7192         (rank_one_type): ... this.
7193
7194 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7195
7196         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7197         from...
7198         (rank_one_type): ... this.
7199
7200 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7201
7202         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7203         inferior-events' shows the example events.
7204
7205 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7206
7207         Support styling on native MS-Windows console
7208
7209         PR/24315
7210         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7211         on MS-Windows if $TERM is not defined.
7212
7213         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7214
7215         * posix-hdep.c (gdb_console_fputs):
7216         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7217         functions.
7218         * ui-file.h (gdb_console_fputs): Add prototype.
7219
7220         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7221         back to fputs only if the former returns zero.
7222
7223 2019-03-07  Tom Tromey  <tom@tromey.com>
7224
7225         * symmisc.c (print_symbol_bcache_statistics): Update.
7226         (print_objfile_statistics): Update.
7227         * symfile.c (allocate_symtab): Update.
7228         * stabsread.c: Don't include bcache.h.
7229         * psymtab.h (struct psymbol_bcache): Don't declare.
7230         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7231         (psymbol_bcache_init, psymbol_bcache_free)
7232         (psymbol_bcache_get_bcache): Don't declare.
7233         * psymtab.c (struct psymbol_bcache): Remove.
7234         (psymtab_storage::psymtab_storage): Update.
7235         (psymtab_storage::~psymtab_storage): Update.
7236         (psymbol_bcache_init, psymbol_bcache_free)
7237         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7238         (add_psymbol_to_bcache): Update.
7239         (allocate_psymtab): Update.
7240         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7241         macro_cache>: No longer pointers.
7242         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7243         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7244         * macrotab.c (macro_bcache): Update.
7245         * macroexp.c: Don't include bcache.h.
7246         * gdbtypes.c (check_types_worklist): Update.
7247         (types_deeply_equal): Remove TRY/CATCH.  Update.
7248         * elfread.c (elf_symtab_read): Update.
7249         * dwarf2read.c: Don't include bcache.h.
7250         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7251         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7252         (print_bcache_statistics, bcache_memory_used): Don't declare.
7253         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7254         methods.  Rename all data members.
7255         * bcache.c (struct bcache): Move to bcache.h.
7256         (bcache::expand_hash_table): Rename from expand_hash_table.
7257         (bcache): Remove.
7258         (bcache::insert): Rename from bcache_full.
7259         (bcache::compare): Rename from bcache_compare.
7260         (bcache_xmalloc): Remove.
7261         (bcache::~bcache): Rename from bcache_xfree.
7262         (bcache::print_statistics): Rename from print_bcache_statistics.
7263         (bcache::memory_used): Rename from bcache_memory_used.
7264
7265 2019-03-07  Pedro Alves  <palves@redhat.com>
7266
7267         * infrun.c (normal_stop): Also check for
7268         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7269
7270 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7271
7272         * f-lang.c (value_from_host_double): Moved to...
7273         * value.c (value_from_host_double): ...here.
7274         * value.h (value_from_host_double): Declare.
7275         * guile/scm-math.c (vlscm_convert_typed_number): Use
7276         value_from_host_double.
7277         (vlscm_convert_number): Likewise.
7278         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7279         * python/py-value.c (convert_value_from_python): Likewise.
7280
7281 2019-03-06  Tom Tromey  <tom@tromey.com>
7282
7283         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7284
7285 2019-03-06  Tom Tromey  <tom@tromey.com>
7286
7287         * utils.h (free_current_contents): Don't declare.
7288         * utils.c (free_current_contents): Remove.
7289
7290 2019-03-06  Tom Tromey  <tom@tromey.com>
7291
7292         * top.c (quit_force): Update.
7293         * main.c (captured_command_loop): Update.
7294         * common/new-op.c (operator new): Update.
7295         * common/common-exceptions.c (struct catcher)
7296         <save_cleanup_chain>: Remove member.
7297         (exceptions_state_mc_init): Update.
7298         (exception_try_scope_entry): Return nullptr.
7299         (exception_try_scope_exit, exception_rethrow)
7300         (throw_exception_sjlj, throw_exception_cxx): Update.
7301         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7302         (all_cleanups, do_cleanups, discard_cleanups)
7303         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7304         (restore_cleanups, restore_final_cleanups): Don't declare.
7305         (do_final_cleanups): Remove parameter.
7306         * common/cleanups.c (cleanup_chain, make_cleanup)
7307         (make_cleanup_dtor, all_cleanups, do_cleanups)
7308         (discard_my_cleanups, discard_cleanups)
7309         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7310         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7311         (null_cleanup): Remove.
7312         (do_final_cleanups): Remove parameter.
7313
7314 2019-03-06  Tom Tromey  <tom@tromey.com>
7315
7316         * remote.c (remote_target::remote_parse_stop_reply): Use
7317         unique_xmalloc_ptr.
7318
7319 2019-03-06  Tom Tromey  <tom@tromey.com>
7320
7321         * stabsread.c (struct stabs_field_info): Rename from field_info.
7322         <list, fnlist>: Add initializers.
7323         <obstack>: New member.
7324         (read_member_functions, read_struct_fields, read_baseclasses):
7325         Allocate on obstack.  Don't use cleanups.
7326         (read_one_struct_field, read_member_functions, read_struct_fields)
7327         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7328         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7329         (read_struct_type): Update.
7330
7331 2019-03-06  Tom Tromey  <tom@tromey.com>
7332
7333         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7334         * common/filestuff.h (make_cleanup_close): Don't declare.
7335         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7336         Remove.
7337
7338 2019-03-06  Tom Tromey  <tom@tromey.com>
7339
7340         * solib-aix.c: Use make_scope_exit.
7341
7342 2019-03-06  Tom Tromey  <tom@tromey.com>
7343
7344         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7345         Use make_scope_exit.
7346
7347 2019-03-06  Tom Tromey  <tom@tromey.com>
7348
7349         * solib-svr4.c (disable_probes_interface): Remove parameter.
7350         (svr4_handle_solib_event): Use make_scope_exit.
7351
7352 2019-03-06  Tom Tromey  <tom@tromey.com>
7353
7354         * remote.c (struct stop_reply_deleter): Remove.
7355         (stop_reply_up): Update.
7356         (struct stop_reply): Derive from notif_event.  Don't typedef.
7357         <regcache>: Now a std::vector.
7358         (stop_reply_xfree): Remove.
7359         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7360         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7361         (remote_target::discard_pending_stop_replies): Use delete.
7362         (remote_target::remote_parse_stop_reply): Update.
7363         (remote_target::process_stop_reply): Update.
7364         * remote-notif.h (struct notif_event): Add virtual destructor.
7365         Remove "dtr" member.
7366         (struct notif_client) <alloc_event>: Return a unique_ptr.
7367         (notif_event_xfree): Don't declare.
7368         (notif_event_up): New typedef.
7369         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7370         (notif_event_xfree, do_notif_event_xfree): Remove.
7371         (remote_notif_state_xfree): Update.
7372
7373 2019-03-06  Tom Tromey  <tom@tromey.com>
7374
7375         * infrun.c (displaced_step_clear_cleanup): Now a
7376         forward_scope_exit type.
7377         (displaced_step_prepare_throw): Update.
7378         (displaced_step_fixup): Update.
7379
7380 2019-03-06  Tom Tromey  <tom@tromey.com>
7381
7382         * inferior.h (class inferior): Update comment.
7383         * gdbthread.h (class thread_info): Update comment.
7384
7385 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7386             Tom Tromey  <tom@tromey.com>
7387
7388         * stabsread.h (struct stab_section_list): Remove.
7389         (coffstab_build_psymtabs): Update.
7390         * dbxread.c (symbuf_sections): Now a std::vector.
7391         (sect_idx): New global.
7392         (fill_symbuf): Update.
7393         (coffstab_build_psymtabs): Change type of stabsects parameter.
7394         Update.
7395         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7396         std::vector.
7397         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7398         (coff_locate_sections): Update.
7399         (coff_symfile_read): Remove cleanups.  Update.
7400         (init_stringtab): Add storage parameter.
7401         (free_stringtab, free_stringtab_cleanup): Remove.
7402         (init_lineno): Add storage parameter.
7403         (free_linetab, free_linetab_cleanup): Remove.
7404
7405 2019-03-06  Pedro Alves  <palves@redhat.com>
7406
7407         * linux-fork.c (fork_info::clobber_regs): Delete.
7408         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7409         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7410         comment.  Adjust.
7411         (scoped_switch_fork_info::scoped_switch_fork_info)
7412         (checkpoint_command, linux_fork_context): Adjust
7413         fork_save_infrun_state calls.
7414
7415 2019-03-06  Pedro Alves  <palves@redhat.com>
7416
7417         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7418         (inf_has_multiple_threads): Return 'bool' and rewrite using
7419         inferior_info::threads().
7420
7421 2019-03-06  Pedro Alves  <palves@redhat.com>
7422
7423         * linux-fork.c: Include <list>.
7424         (fork_list): Now a std::list instance.
7425         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7426         (forks_exist_p, find_last_fork): Adjust.
7427         (new_fork): Delete.
7428         (one_fork_p): New.
7429         (add_fork): Adjust.
7430         (free_fork): Delete, folded into fork_info::~fork_info().
7431         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7432         Adjust.
7433         (init_fork_list): Delete.
7434         (linux_fork_killall, linux_fork_mourn_inferior)
7435         (linux_fork_detach, info_checkpoints_command): Adjust.
7436         (_initialize_linux_fork): No longer call init_fork_list.
7437
7438 2019-03-06  Pedro Alves  <palves@redhat.com>
7439
7440         * linux-fork.c (new_fork): New, split out of ...
7441         (add_fork): ... this.  Return void.  Move "first fork" special
7442         case from here, to ...
7443         (checkpoint_command): ... here.
7444         * linux-linux.h (add_fork): Return void.
7445
7446 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7447
7448         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7449
7450 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7451             Chris January  <chris.january@arm.com>
7452             David Lecomber  <david.lecomber@arm.com>
7453
7454         * f-exp.y: New token, UNOP_INTRINSIC.
7455         (exp): New pattern using UNOP_INTRINSIC token.
7456         (f77_keywords): Add 'abs' keyword.
7457         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7458         (value_from_host_double): New function.
7459         (evaluate_subexp_f): Support UNOP_ABS.
7460
7461 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7462
7463         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7464         types.
7465
7466 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7467
7468         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7469         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7470         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7471
7472 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7473
7474         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7475
7476 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7477             Chris January  <chris.january@arm.com>
7478
7479         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7480         * f-exp.y: Define 'KIND' token.
7481         (exp): New pattern for KIND expressions.
7482         (ptype): Handle types with a kind extension.
7483         (direct_abs_decl): Extend to spot kind extensions.
7484         (f77_keywords): Add 'kind' to the list.
7485         (push_kind_type): New function.
7486         (convert_to_kind_type): New function.
7487         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7488         * parse.c (operator_length_standard): Likewise.
7489         * parser-defs.h (enum type_pieces): Add tp_kind.
7490         * std-operator.def: Add UNOP_KIND.
7491
7492 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7493
7494         * f-exp.y (f_parse): Set yydebug.
7495
7496 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7497
7498         * f-lang.c (evaluate_subexp_f): New function.
7499         (exp_descriptor_f): New global.
7500         (f_language_defn): Use exp_descriptor_f instead of
7501         exp_descriptor_standard.
7502
7503 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7504
7505         * f-exp.y (struct token): Add comments.
7506         (dot_ops): Remove uppercase versions and the end marker.
7507         (f77_keywords): Likewise.
7508         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7509         entries in the dot_ops array are case insensitive, and use
7510         strncasecmp to compare strings.  Also some whitespace cleanup in
7511         this area.  Similar for the f77_keywords array, except entries in
7512         this list might be case sensitive.
7513
7514 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7515
7516         * f-exp.y (struct f77_boolean_val): Add comments.
7517         (boolean_values): Remove uppercase versions, and end marker.
7518         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7519         and use strncasecmp to achieve case insensitivity.  Additionally,
7520         perform whitespace cleanup around this code.
7521
7522 2019-03-06  Tom Tromey  <tromey@adacore.com>
7523
7524         * remote-sim.c (gdbsim_target_open): Use result of
7525         gdb_argv::release.
7526
7527 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7528         Dirk Schubert  <dirk.schubert@arm.com>
7529         Chris January  <chris.january@arm.com>
7530
7531         * eval.c (evaluate_subexp_standard): Call Fortran argument
7532         wrapping logic.
7533         * f-lang.c (struct value): A value which can be passed into a
7534         Fortran function call.
7535         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7536         where appropriate.
7537         (struct type): Value ready for a Fortran function call.
7538         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7539         is needed.
7540         * f-lang.h (fortran_argument_convert): Declaration.
7541         (fortran_preserve_arg_pointer): Declaration.
7542         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7543
7544 2019-03-05  Tom Tromey  <tromey@adacore.com>
7545
7546         * python/py-prettyprint.c (print_string_repr): Remove #if.
7547         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7548
7549 2019-03-05  Tom Tromey  <tromey@adacore.com>
7550
7551         * target.c (the_dummy_target): Move later.  Change type to
7552         "dummy_target".
7553         (initialize_targets): Don't initialize the_dummy_target.
7554
7555 2019-03-05  Tom Tromey  <tromey@adacore.com>
7556
7557         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7558         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7559
7560 2019-03-05  Tom Tromey  <tromey@adacore.com>
7561
7562         * windows-nat.c (windows_nat_target::attach)
7563         (windows_nat_target::detach): Don't call gdb_flush.
7564         * valprint.c (generic_val_print, val_print, val_print_string):
7565         Don't call gdb_flush.
7566         * utils.c (defaulted_query): Don't call gdb_flush.
7567         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7568         * target.c (target_announce_detach): Don't call gdb_flush.
7569         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7570         * remote.c (extended_remote_target::attach): Don't call
7571         gdb_flush.
7572         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7573         * printcmd.c (do_examine): Don't call gdb_flush.
7574         (info_display_command): Don't call gdb_flush.
7575         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7576         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7577         * memattr.c (info_mem_command): Don't call gdb_flush.
7578         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7579         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7580         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7581         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7582         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7583         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7584         (gnu_nat_target::detach): Don't call gdb_flush.
7585         * f-valprint.c (f_val_print): Don't call gdb_flush.
7586         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7587         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7588         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7589         gdb_flush.
7590         * c-valprint.c (c_val_print): Don't call gdb_flush.
7591         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7592
7593 2019-03-05  Tom Tromey  <tromey@adacore.com>
7594
7595         * varobj.c (update_dynamic_varobj_children): Update.
7596         (install_default_visualizer): Use reset, not release.
7597         * value.c (set_internalvar): Update.
7598         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7599         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7600         ATTRIBUTE_UNUSED_RESULT.
7601
7602 2019-03-05  Tom Tromey  <tromey@adacore.com>
7603
7604         * remote.c (class scoped_remote_fd) <release>: Add
7605         ATTRIBUTE_UNUSED_RESULT.
7606
7607 2019-03-05  Tom Tromey  <tromey@adacore.com>
7608
7609         * macroexp.c (struct macro_buffer) <release>: Add
7610         ATTRIBUTE_UNUSED_RESULT.
7611
7612 2019-03-05  Tom Tromey  <tromey@adacore.com>
7613
7614         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7615         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7616         ATTRIBUTE_UNUSED_RESULT.
7617
7618 2019-03-05  Tom Tromey  <tromey@adacore.com>
7619
7620         * common/scoped_fd.h (class scoped_fd) <release>: Add
7621         ATTRIBUTE_UNUSED_RESULT.
7622
7623 2019-03-05  Tom Tromey  <tromey@adacore.com>
7624
7625         * parser-defs.h (struct parser_state) <release>: Add
7626         ATTRIBUTE_UNUSED_RESULT.
7627
7628 2019-03-05  Tom Tromey  <tromey@adacore.com>
7629
7630         * utils.h (class gdb_argv) <release>: Add
7631         ATTRIBUTE_UNUSED_RESULT.
7632         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7633
7634 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7635
7636         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7637         for-loop range, to avoid compiler warnings.
7638
7639         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7640         avoid compiler warnings about unused variables.
7641
7642         * NEWS: Mention end of support for native debugging on MS-Windows
7643         before XP.
7644
7645         PR gdb/24292
7646         * common/netstuff.c:
7647         * gdbserver/gdbreplay.c
7648         * gdbserver/remote-utils.c:
7649         * ser-tcp.c:
7650         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7651         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7652         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7653         'getaddrinfo' and 'freeaddrinfo' were not available before
7654         Windows XP, and mingw.org's MinGW headers by default define
7655         _WIN32_WINNT to 0x500.
7656
7657 2019-03-01  Gary Benson <gbenson@redhat.com>
7658
7659         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7660
7661 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7662             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7663
7664         PR gdb/8527
7665         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7666         set_sigint_trap, clear_sigint_trap.
7667
7668 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7669
7670         * target.c (target_detach): Clear the regcache and the
7671         frame cache.
7672
7673 2019-02-27  Pedro Alves  <palves@redhat.com>
7674
7675         * utils.c (set_screen_size): When we cap the height/width sizes,
7676         tweak the corresponding command variable to show "unlimited":
7677
7678 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7679             Pedro Alves  <palves@redhat.com>
7680
7681         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7682         before calling rl_set_screen_size.
7683
7684 2019-02-27  Tom Tromey  <tromey@adacore.com>
7685
7686         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7687         define.
7688         * python/py-value.c: Remove Python 2.4 workaround.
7689         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7690         workaround.
7691         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7692         Python 2.4 workaround.
7693         * python/python-internal.h: Remove Python 2.4 comment.
7694         (Py_ssize_t): Don't define.
7695         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7696         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7697         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7698         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7699         * python/python.c (do_start_initialization): Remove Python 2.4
7700         workaround.
7701         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7702         (print_children): Remove Python 2.4 workaround.
7703         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7704         workaround.
7705         (CHARBUFFERPROC_NAME): Remove.
7706         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7707         Python 2.4 workaround.
7708
7709 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7710
7711         * NEWS: Note minimum Python version.
7712
7713 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7714
7715         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7716         code from these functions.  Remove corresponding ifdefs.  Use
7717         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7718         Remove gotos and target of gotos.
7719         (infpy_search_memory): Likewise.
7720
7721 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7722
7723         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7724         (hppa_gdbarch_init): Don't register deleted functions with
7725         gdbarch.
7726
7727 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7728
7729         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7730         (h8300_unwind_sp): Delete.
7731         (h8300_dummy_id): Delete.
7732         (h8300_gdbarch_init): Don't register deleted functions with
7733         gdbarch.
7734
7735 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7736
7737         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7738         (ft32_unwind_pc): Delete.
7739         (ft32_unwind_sp): Delete.
7740         (ft32_gdbarch_init): Don't register deleted functions with
7741         gdbarch.
7742
7743 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7744
7745         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7746         (frv_unwind_pc): Delete.
7747         (frv_unwind_sp): Delete.
7748         (frv_gdbarch_init): Don't register deleted functions with
7749         gdbarch.
7750
7751 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7752
7753         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7754         (riscv_unwind_pc): Delete.
7755         (riscv_unwind_sp): Delete.
7756         (riscv_gdbarch_init): Don't register deleted functions with
7757         gdbarch.
7758
7759 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7760
7761         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7762         (csky_unwind_pc): Delete.
7763         (csky_unwind_sp): Delete.
7764         (csky_gdbarch_init): Don't register deleted functions with
7765         gdbarch.
7766
7767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7768
7769         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7770         (cris_unwind_pc): Delete.
7771         (cris_unwind_sp): Delete.
7772         (cris_gdbarch_init): Don't register deleted functions with
7773         gdbarch.
7774
7775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7776
7777         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7778         (bfin_unwind_pc): Delete.
7779         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7780
7781 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7782
7783         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7784         (arm_unwind_pc): Delete.
7785         (arm_unwind_sp): Delete.
7786         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7787
7788 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7789
7790         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7791         (arc_unwind_pc): Delete.
7792         (arc_unwind_sp): Delete.
7793         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7794
7795 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7796
7797         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7798         (alpha_unwind_pc): Delete.
7799         (alpha_gdbarch_init): Don't register deleted functions with
7800         gdbarch.
7801
7802 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7803
7804         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7805         (aarch64_unwind_pc): Delete.
7806         (aarch64_unwind_sp): Delete.
7807         (aarch64_gdbarch_init): Don't register deleted functions with
7808         gdbarch.
7809
7810 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7811
7812         * gdbtypes.c (type_align): Don't consider static members when
7813         computing structure alignment.
7814
7815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7816
7817         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7818         return 0 for other types.
7819         * arch-utils.c (default_type_align): Always return 0.
7820         * gdbarch.h: Regenerate.
7821         * gdbarch.sh (type_align): Extend comment.
7822         * gdbtypes.c (type_align): Add additional comments, always call
7823         gdbarch_type_align before applying the default rules.
7824         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7825         generic code will then apply a suitable default.
7826         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7827         types, return 0 for other types.
7828
7829 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7830
7831         * NEWS: Create a new section for the next release branch.
7832         Rename the section of the current branch, now that it has
7833         been cut.
7834
7835 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7836
7837         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7838         * version.in: Bump version to 8.3.50.DATE-git.
7839
7840 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7841
7842         * aix-thread.c (ptid_cmp): Remove unused variable.
7843         (get_signaled_thread): Likewise.
7844         (store_regs_user_thread): Likewise.
7845         (store_regs_kernel_thread): Likewise.
7846         (fetch_regs_kernel_thread): Remove shadowed variable.
7847
7848 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7849
7850         * features/riscv/32bit-cpu.xml: Add register numbers.
7851         * features/riscv/32bit-fpu.c: Regenerate.
7852         * features/riscv/32bit-fpu.xml: Add register numbers.
7853         * features/riscv/64bit-cpu.xml: Add register numbers.
7854         * features/riscv/64bit-fpu.c: Regenerate.
7855         * features/riscv/64bit-fpu.xml: Add register numbers.
7856
7857 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7858
7859         * NEWS: Mention two argument form of gdb.Value constructor.
7860         * python/py-value.c (convert_buffer_and_type_to_value): New
7861         function.
7862         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7863         Add support for handling an optional second argument.  Call
7864         convert_buffer_and_type_to_value as appropriate.
7865         * python/python-internal.h (Py_buffer_deleter): New struct.
7866         (Py_buffer_up): New typedef.
7867
7868 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7869
7870         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7871         instead of releasing ownership.
7872
7873 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7874
7875         * dwarf2read.c (open_and_init_dwp_file): Call
7876         elf_numsections instead of bfd_count_sections to initialize
7877         dwp_file->num_sections.
7878
7879 2019-02-25  Tom Tromey  <tromey@adacore.com>
7880
7881         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7882
7883 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7884
7885         * gcore.in: Add '--readnever' option when invoking GDB.
7886
7887 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7888
7889         * MAINTAINERS: Update my email address.
7890
7891 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7892
7893         * build-id.c (build_id_to_debug_bfd_1): New function.
7894         (build_id_to_debug_bfd): Look for separate debug file in
7895         sysroot.
7896
7897 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7898
7899         * gdbarch.sh: Update the copyright year range that is placed into
7900         generated files.
7901
7902 2019-02-22  Keith Seitz  <keiths@redhat.com>
7903
7904         PR symtab/23853
7905         * linespec.c (create_sals_line_offset): Search for the default
7906         symtab's filename instead of its fullname.
7907
7908 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7909
7910         * NEWS: Update style defaults.
7911
7912 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7913
7914         * main.c (captured_main_1): Disable styling in batch mode.
7915
7916 2019-02-20  Tom Tromey  <tom@tromey.com>
7917
7918         * symtab.c (symtab_symbol_info): Fix typos.
7919
7920 2019-02-20  Tom Tromey  <tromey@adacore.com>
7921
7922         * findcmd.c (_initialize_mem_search): Use upper case for
7923         metasyntactic variables.
7924
7925 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7926
7927         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7928         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7929
7930 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7931
7932         * top.h (source_file_name): Change to std::string.
7933         * top.c (source_file_name): Likewise.
7934         (command_line_input): Adjust.
7935         * cli/cli-script.c (script_from_file): Adjust.
7936
7937 2019-02-19  Tom Tromey  <tromey@adacore.com>
7938
7939         * ravenscar-thread.c
7940         (ravenscar_thread_target::update_thread_list): Don't call
7941         ada_build_task_list.
7942         * ada-lang.h (ada_build_task_list): Don't declare.
7943         * ada-tasks.c (struct ada_tasks_inferior_data)
7944         <task_list_valid_p>: Now bool.
7945         (read_known_tasks, ada_task_list_changed)
7946         (ada_tasks_invalidate_inferior_data): Update.
7947         (read_known_tasks_array): Return bool.
7948         (read_known_tasks_list): Likewise.
7949         (read_known_tasks): Return void.
7950         (ada_build_task_list): Now static.
7951
7952 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7953
7954         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7955         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7956
7957 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7958
7959         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7960         variant for ada_tasks_pspace_data_handle and
7961         ada_tasks_inferior_data_handle.
7962         (ada_tasks_pspace_data_cleanup): New function.
7963         (ada_tasks_inferior_data_cleanup): New function.
7964
7965 2019-02-17  Tom Tromey  <tom@tromey.com>
7966
7967         * macrotab.h (macro_source_fullname): Return a std::string.
7968         * macrotab.c (macro_include, check_for_redefinition)
7969         (macro_undef, macro_lookup_definition, foreach_macro)
7970         (foreach_macro_in_scope): Update.
7971         (macro_source_fullname): Return a std::string.
7972         * macrocmd.c (show_pp_source_pos): Update.
7973
7974 2019-02-17  Tom Tromey  <tom@tromey.com>
7975
7976         * macrocmd.c (show_pp_source_pos): Style the file names.
7977
7978 2019-02-17  Tom Tromey  <tom@tromey.com>
7979
7980         PR tui/24197:
7981         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7982
7983 2019-02-17  Tom Tromey  <tom@tromey.com>
7984
7985         * ada-lang.c (user_select_syms): Use filtered printing.
7986         * utils.c (wrap_style): New global.
7987         (desired_style): Remove.
7988         (emit_style_escape): Add stream parameter.
7989         (set_output_style, reset_terminal_style, prompt_for_continue):
7990         Update.
7991         (flush_wrap_buffer): Only flush gdb_stdout.
7992         (wrap_here): Set wrap_style.
7993         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7994         treat escape sequences as a character.  Change when wrap buffer is
7995         flushed.
7996         (fputs_styled): Do not set the output style when the default is
7997         requested.
7998         * ui-style.h (struct ui_file_style) <is_default>: New method.
7999         * source.c (print_source_lines_base): Emit escape sequences in one
8000         piece.
8001
8002 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8003
8004         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8005         integers and enumeration types.
8006
8007 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8008
8009         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8010         instead of lookup_symbol_in_language
8011         (do_exact_match): New function.
8012         (ada_get_symbol_name_matcher): Return do_exact_match when
8013         doing a verbatim match.
8014
8015 2019-02-15  Tom Tromey  <tromey@adacore.com>
8016
8017         * ravenscar-thread.c (ravenscar_thread_target::resume)
8018         (ravenscar_thread_target::wait): Special case wildcard requests.
8019
8020 2019-02-15  Tom Tromey  <tromey@adacore.com>
8021
8022         * ravenscar-thread.c (base_ptid): Remove.
8023         (struct ravenscar_thread_target) <close>: New method.
8024         <m_base_ptid>: New member.
8025         <update_inferior_ptid, active_task, task_is_currently_active,
8026         runtime_initialized>: Declare methods.
8027         <ravenscar_thread_target>: Add constructor.
8028         (ravenscar_thread_target::task_is_currently_active)
8029         (ravenscar_thread_target::update_inferior_ptid)
8030         (ravenscar_runtime_initialized): Rename.  Now methods.
8031         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8032         (ravenscar_thread_target::update_thread_list): Update.
8033         (ravenscar_thread_target::active_task): Now method.
8034         (ravenscar_thread_target::store_registers)
8035         (ravenscar_thread_target::prepare_to_store)
8036         (ravenscar_thread_target::prepare_to_store)
8037         (ravenscar_thread_target::mourn_inferior): Update.
8038         (ravenscar_inferior_created): Use "new" to create target.
8039         (ravenscar_thread_target::get_ada_task_ptid): Update.
8040         (_initialize_ravenscar): Don't initialize base_ptid.
8041         (ravenscar_ops): Remove global.
8042
8043 2019-02-15  Tom Tromey  <tromey@adacore.com>
8044
8045         * target.h (push_target): Declare new overload.
8046         * target.c (push_target): New overload, taking an rvalue reference.
8047         * remote.c (remote_target::open_1): Use push_target overload.
8048         * corelow.c (core_target_open): Use push_target overload.
8049
8050 2019-02-15  Tom Tromey  <tromey@adacore.com>
8051
8052         * ravenscar-thread.c (is_ravenscar_task)
8053         (ravenscar_task_is_currently_active): Return bool.
8054         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8055         (_initialize_ravenscar): Remove "(void)".
8056         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8057         Return bool.
8058
8059 2019-02-15  Tom Tromey  <tromey@adacore.com>
8060
8061         * ravenscar-thread.c (ravenscar_runtime_initializer)
8062         (has_ravenscar_runtime, get_running_thread_id)
8063         (ravenscar_thread_target::resume): Fix indentation.
8064
8065 2019-02-15  Tom Tromey  <tromey@adacore.com>
8066
8067         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8068         from ravenscar_arch_ops.
8069         (sparc_ravenscar_ops::fetch_registers)
8070         (sparc_ravenscar_ops::store_registers): Now methods.
8071         (sparc_ravenscar_prepare_to_store): Remove.
8072         (sparc_ravenscar_ops): Redefine.
8073         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8074         methods and destructor.  Remove members.
8075         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8076         (ravenscar_thread_target::store_registers)
8077         (ravenscar_thread_target::prepare_to_store): Update.
8078         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8079         Remove.
8080         (struct ppc_ravenscar_powerpc_ops): Derive from
8081         ravenscar_arch_ops.
8082         (ppc_ravenscar_powerpc_ops::fetch_registers)
8083         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8084         (ppc_ravenscar_powerpc_ops): Redefine.
8085         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8086         (ppc_ravenscar_e500_ops::fetch_registers)
8087         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8088         (ppc_ravenscar_e500_ops): Redefine.
8089         * aarch64-ravenscar-thread.c
8090         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8091         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8092         (aarch64_ravenscar_fetch_registers)
8093         (aarch64_ravenscar_store_registers): Now methods.
8094         (aarch64_ravenscar_ops): Redefine.
8095
8096 2019-02-15  Tom Tromey  <tromey@adacore.com>
8097
8098         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8099         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8100         (ravenscar_thread_target::stopped_by_watchpoint)
8101         (ravenscar_thread_target::stopped_data_address)
8102         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8103
8104 2019-02-15  Tom Tromey  <tromey@adacore.com>
8105
8106         * ravenscar-thread.c: Fix some typos.
8107
8108 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8109             Tom Tromey  <tromey@adacore.com>
8110
8111         * ada-lang.c (ada_exception_sal): Change addr_string to a
8112         std::string.
8113         (create_ada_exception_catchpoint): Update.
8114
8115 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8116             Tom Tromey  <tromey@adacore.com>
8117
8118         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8119         (bp_location_ops): Remove.
8120         (base_breakpoint_allocate_location): Update.
8121         (free_bp_location): Update.
8122         * ada-lang.c (class ada_catchpoint_location)
8123         <ada_catchpoint_location>: Remove ops parameter.
8124         (ada_catchpoint_location_dtor): Remove.
8125         (ada_catchpoint_location_ops): Remove.
8126         (allocate_location_exception): Update.
8127         * breakpoint.h (struct bp_location_ops): Remove.
8128         (class bp_location) <bp_location>: Remove bp_location_ops
8129         parameter.
8130         <~bp_location>: Add destructor.
8131         <ops>: Remove.
8132
8133 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8134             Pedro Alves  <palves@redhat.com>
8135
8136         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8137         'PATH_MAX'.
8138
8139 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8140             Samuel Thibault  <samuel.thibault@gnu.org>
8141             Thomas Schwinge  <thomas@codesourcery.com>
8142
8143         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8144         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8145
8146 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8147
8148         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8149         (check_empty): Use "const char *".
8150
8151         * gnu-nat.c (gnu_nat_target::detach): Instead of
8152         'detach_inferior (pid)' call
8153         'detach_inferior (find_inferior_pid (pid))'.
8154
8155         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8156         'nat/fork-inferior.o'.
8157         * gnu-nat.c: #include "nat/fork-inferior.h".
8158
8159         * gnu-nat.c (gnu_nat_target::detach): Instead of
8160         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8161         * gnu-nat.h: #include "inf-child.h".
8162         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8163         'i386_gnu_nat_target::fetch_registers'.
8164         (gnu_store_registers): Rename/move to
8165         'i386_gnu_nat_target::store_registers'.
8166
8167         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8168         * gnu-nat.h (mach_thread_info): New function.
8169         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8170
8171         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8172
8173 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8174
8175         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8176
8177 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8178
8179         * windows-nat.c (windows_add_thread): Add new parameter
8180         "main_thread_p" with default value set to false.  Update
8181         function documentation as well as all callers.
8182         (windows_delete_thread): Likewise.
8183         (fake_create_process): Update call to windows_add_thread.
8184         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8185         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8186         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8187         call to windows_delete_thread.
8188
8189 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8190
8191         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8192
8193 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8194
8195         * symfile.c (find_separate_debug_file): Use canonical path of
8196         sysroot with child_path instead of gdb_sysroot if it is valid.
8197
8198 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8199
8200         * symfile.c (find_separate_debug_file): Use child_path to
8201         determine if an object file is under a sysroot.
8202
8203 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8204
8205         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8206         unittests/child-path-selftests.c.
8207         * common/pathstuff.c (child_path): New function.
8208         * common/pathstuff.h (child_path): New prototype.
8209         * unittests/child-path-selftests.c: New file.
8210
8211 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8212
8213         * symfile.c (find_separate_debug_file): Look for separate debug
8214         files in debug directories under the sysroot.
8215
8216 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8217
8218         * symtab.h (struct minimal_symbol data_p): New const method.
8219         (struct minimal_symbol text_p): Likewise.
8220         * symtab.c (output_source_filename): Use file name style
8221         to print file name.
8222         (print_symbol_info): Likewise.
8223         (print_msymbol_info): Use address style to print addresses.
8224         Use function name style to print executable text symbols.
8225         (expand_symtab_containing_pc): Use data_p.
8226         (find_pc_sect_compunit_symtab): Likewise.
8227
8228 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8229
8230         * breakpoint.c (describe_other_breakpoints): Use address style
8231         to print addresses.
8232         (say_where): Likewise.
8233
8234 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8235
8236         * ada-typeprint.c (print_func_type): Print function name
8237         style to print function name.
8238         * c-typeprint.c (c_print_type_1): Likewise.
8239
8240 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8241
8242         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8243         for execve.
8244
8245 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8246
8247         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8248         type_stack.
8249
8250 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8251
8252         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8253         TYPE_CODE_REF types.
8254
8255 2019-02-08  Jim Wilson  <jimw@sifive.com>
8256
8257         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8258         (riscv_linux_fregset): New.
8259         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8260
8261 2019-02-07  Tom Tromey  <tom@tromey.com>
8262
8263         * thread.c (thread_cancel_execution_command): Update.
8264         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8265         methods.
8266         (struct thread_fsm_ops): Remove.
8267         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8268         (thread_fsm_should_stop, thread_fsm_return_value)
8269         (thread_fsm_set_finished, thread_fsm_finished_p)
8270         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8271         Don't declare.
8272         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8273         * infrun.c (clear_proceed_status_thread)
8274         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8275         (print_stop_event): Update.
8276         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8277         Add constructor.
8278         (step_command_fsm_ops): Remove.
8279         (new_step_command_fsm): Remove.
8280         (step_1): Update.
8281         (step_command_fsm::should_stop): Rename from
8282         step_command_fsm_should_stop.
8283         (step_command_fsm::clean_up): Rename from
8284         step_command_fsm_clean_up.
8285         (step_command_fsm::do_async_reply_reason): Rename from
8286         step_command_fsm_async_reply_reason.
8287         (struct until_next_fsm): Inherit from thread_fsm.  Add
8288         constructor.
8289         (until_next_fsm_ops): Remove.
8290         (new_until_next_fsm): Remove.
8291         (until_next_fsm::should_stop): Rename from
8292         until_next_fsm_should_stop.
8293         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8294         (until_next_fsm::do_async_reply_reason): Rename from
8295         until_next_fsm_async_reply_reason.
8296         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8297         constructor.  Change type of breakpoint.
8298         (finish_command_fsm_ops): Remove.
8299         (new_finish_command_fsm): Remove.
8300         (finish_command_fsm::should_stop): Rename from
8301         finish_command_fsm_should_stop.
8302         (finish_command_fsm::clean_up): Rename from
8303         finish_command_fsm_clean_up.
8304         (finish_command_fsm::return_value): Rename from
8305         finish_command_fsm_return_value.
8306         (finish_command_fsm::do_async_reply_reason): Rename from
8307         finish_command_fsm_async_reply_reason.
8308         (finish_command): Update.
8309         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8310         Add constructor.
8311         (call_thread_fsm_ops): Remove.
8312         (call_thread_fsm::call_thread_fsm): Rename from
8313         new_call_thread_fsm.
8314         (call_thread_fsm::should_stop): Rename from
8315         call_thread_fsm_should_stop.
8316         (call_thread_fsm::should_notify_stop): Rename from
8317         call_thread_fsm_should_notify_stop.
8318         (run_inferior_call, call_function_by_hand_dummy): Update.
8319         * cli/cli-interp.c (should_print_stop_to_console): Update.
8320         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8321         Add constructor.  Change type of location_breakpoint,
8322         caller_breakpoint.
8323         (until_break_fsm_ops): Remove.
8324         (new_until_break_fsm): Remove.
8325         (until_break_fsm::should_stop): Rename from
8326         until_break_fsm_should_stop.
8327         (until_break_fsm::clean_up): Rename from
8328         until_break_fsm_clean_up.
8329         (until_break_fsm::do_async_reply_reason): Rename from
8330         until_break_fsm_async_reply_reason.
8331         (until_break_command): Update.
8332         * thread-fsm.c: Remove.
8333         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8334
8335 2019-02-07  Tom Tromey  <tom@tromey.com>
8336
8337         * yy-remap.h: Add include guard.
8338         * xtensa-tdep.h: Add include guard.
8339         * xcoffread.h: Rename include guard.
8340         * varobj-iter.h: Add include guard.
8341         * tui/tui.h: Rename include guard.
8342         * tui/tui-winsource.h: Rename include guard.
8343         * tui/tui-wingeneral.h: Rename include guard.
8344         * tui/tui-windata.h: Rename include guard.
8345         * tui/tui-win.h: Rename include guard.
8346         * tui/tui-stack.h: Rename include guard.
8347         * tui/tui-source.h: Rename include guard.
8348         * tui/tui-regs.h: Rename include guard.
8349         * tui/tui-out.h: Rename include guard.
8350         * tui/tui-layout.h: Rename include guard.
8351         * tui/tui-io.h: Rename include guard.
8352         * tui/tui-hooks.h: Rename include guard.
8353         * tui/tui-file.h: Rename include guard.
8354         * tui/tui-disasm.h: Rename include guard.
8355         * tui/tui-data.h: Rename include guard.
8356         * tui/tui-command.h: Rename include guard.
8357         * tic6x-tdep.h: Add include guard.
8358         * target/waitstatus.h: Rename include guard.
8359         * target/wait.h: Rename include guard.
8360         * target/target.h: Rename include guard.
8361         * target/resume.h: Rename include guard.
8362         * target-float.h: Rename include guard.
8363         * stabsread.h: Add include guard.
8364         * rs6000-tdep.h: Add include guard.
8365         * riscv-fbsd-tdep.h: Add include guard.
8366         * regformats/regdef.h: Rename include guard.
8367         * record.h: Rename include guard.
8368         * python/python.h: Rename include guard.
8369         * python/python-internal.h: Rename include guard.
8370         * python/py-stopevent.h: Rename include guard.
8371         * python/py-ref.h: Rename include guard.
8372         * python/py-record.h: Rename include guard.
8373         * python/py-record-full.h: Rename include guard.
8374         * python/py-record-btrace.h: Rename include guard.
8375         * python/py-instruction.h: Rename include guard.
8376         * python/py-events.h: Rename include guard.
8377         * python/py-event.h: Rename include guard.
8378         * procfs.h: Add include guard.
8379         * proc-utils.h: Add include guard.
8380         * p-lang.h: Add include guard.
8381         * or1k-tdep.h: Rename include guard.
8382         * observable.h: Rename include guard.
8383         * nto-tdep.h: Rename include guard.
8384         * nat/x86-linux.h: Rename include guard.
8385         * nat/x86-linux-dregs.h: Rename include guard.
8386         * nat/x86-gcc-cpuid.h: Add include guard.
8387         * nat/x86-dregs.h: Rename include guard.
8388         * nat/x86-cpuid.h: Rename include guard.
8389         * nat/ppc-linux.h: Rename include guard.
8390         * nat/mips-linux-watch.h: Rename include guard.
8391         * nat/linux-waitpid.h: Rename include guard.
8392         * nat/linux-ptrace.h: Rename include guard.
8393         * nat/linux-procfs.h: Rename include guard.
8394         * nat/linux-osdata.h: Rename include guard.
8395         * nat/linux-nat.h: Rename include guard.
8396         * nat/linux-namespaces.h: Rename include guard.
8397         * nat/linux-btrace.h: Rename include guard.
8398         * nat/glibc_thread_db.h: Rename include guard.
8399         * nat/gdb_thread_db.h: Rename include guard.
8400         * nat/gdb_ptrace.h: Rename include guard.
8401         * nat/fork-inferior.h: Rename include guard.
8402         * nat/amd64-linux-siginfo.h: Rename include guard.
8403         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8404         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8405         * nat/aarch64-linux.h: Rename include guard.
8406         * nat/aarch64-linux-hw-point.h: Rename include guard.
8407         * mn10300-tdep.h: Add include guard.
8408         * mips-linux-tdep.h: Add include guard.
8409         * mi/mi-parse.h: Rename include guard.
8410         * mi/mi-out.h: Rename include guard.
8411         * mi/mi-main.h: Rename include guard.
8412         * mi/mi-interp.h: Rename include guard.
8413         * mi/mi-getopt.h: Rename include guard.
8414         * mi/mi-console.h: Rename include guard.
8415         * mi/mi-common.h: Rename include guard.
8416         * mi/mi-cmds.h: Rename include guard.
8417         * mi/mi-cmd-break.h: Rename include guard.
8418         * m2-lang.h: Add include guard.
8419         * location.h: Rename include guard.
8420         * linux-record.h: Rename include guard.
8421         * linux-nat.h: Add include guard.
8422         * linux-fork.h: Add include guard.
8423         * i386-darwin-tdep.h: Rename include guard.
8424         * hppa-linux-offsets.h: Add include guard.
8425         * guile/guile.h: Rename include guard.
8426         * guile/guile-internal.h: Rename include guard.
8427         * gnu-nat.h: Rename include guard.
8428         * gdb-stabs.h: Rename include guard.
8429         * frv-tdep.h: Add include guard.
8430         * f-lang.h: Add include guard.
8431         * event-loop.h: Add include guard.
8432         * darwin-nat.h: Rename include guard.
8433         * cp-abi.h: Rename include guard.
8434         * config/sparc/nm-sol2.h: Rename include guard.
8435         * config/nm-nto.h: Rename include guard.
8436         * config/nm-linux.h: Add include guard.
8437         * config/i386/nm-i386gnu.h: Rename include guard.
8438         * config/djgpp/nl_types.h: Rename include guard.
8439         * config/djgpp/langinfo.h: Rename include guard.
8440         * compile/gcc-cp-plugin.h: Add include guard.
8441         * compile/gcc-c-plugin.h: Add include guard.
8442         * compile/compile.h: Rename include guard.
8443         * compile/compile-object-run.h: Rename include guard.
8444         * compile/compile-object-load.h: Rename include guard.
8445         * compile/compile-internal.h: Rename include guard.
8446         * compile/compile-cplus.h: Rename include guard.
8447         * compile/compile-c.h: Rename include guard.
8448         * common/xml-utils.h: Rename include guard.
8449         * common/x86-xstate.h: Rename include guard.
8450         * common/version.h: Rename include guard.
8451         * common/vec.h: Rename include guard.
8452         * common/tdesc.h: Rename include guard.
8453         * common/selftest.h: Rename include guard.
8454         * common/scoped_restore.h: Rename include guard.
8455         * common/scoped_mmap.h: Rename include guard.
8456         * common/scoped_fd.h: Rename include guard.
8457         * common/safe-iterator.h: Rename include guard.
8458         * common/run-time-clock.h: Rename include guard.
8459         * common/refcounted-object.h: Rename include guard.
8460         * common/queue.h: Rename include guard.
8461         * common/ptid.h: Rename include guard.
8462         * common/print-utils.h: Rename include guard.
8463         * common/preprocessor.h: Rename include guard.
8464         * common/pathstuff.h: Rename include guard.
8465         * common/observable.h: Rename include guard.
8466         * common/netstuff.h: Rename include guard.
8467         * common/job-control.h: Rename include guard.
8468         * common/host-defs.h: Rename include guard.
8469         * common/gdb_wait.h: Rename include guard.
8470         * common/gdb_vecs.h: Rename include guard.
8471         * common/gdb_unlinker.h: Rename include guard.
8472         * common/gdb_unique_ptr.h: Rename include guard.
8473         * common/gdb_tilde_expand.h: Rename include guard.
8474         * common/gdb_sys_time.h: Rename include guard.
8475         * common/gdb_string_view.h: Rename include guard.
8476         * common/gdb_splay_tree.h: Rename include guard.
8477         * common/gdb_setjmp.h: Rename include guard.
8478         * common/gdb_ref_ptr.h: Rename include guard.
8479         * common/gdb_optional.h: Rename include guard.
8480         * common/gdb_locale.h: Rename include guard.
8481         * common/gdb_assert.h: Rename include guard.
8482         * common/filtered-iterator.h: Rename include guard.
8483         * common/filestuff.h: Rename include guard.
8484         * common/fileio.h: Rename include guard.
8485         * common/environ.h: Rename include guard.
8486         * common/common-utils.h: Rename include guard.
8487         * common/common-types.h: Rename include guard.
8488         * common/common-regcache.h: Rename include guard.
8489         * common/common-inferior.h: Rename include guard.
8490         * common/common-gdbthread.h: Rename include guard.
8491         * common/common-exceptions.h: Rename include guard.
8492         * common/common-defs.h: Rename include guard.
8493         * common/common-debug.h: Rename include guard.
8494         * common/cleanups.h: Rename include guard.
8495         * common/buffer.h: Rename include guard.
8496         * common/btrace-common.h: Rename include guard.
8497         * common/break-common.h: Rename include guard.
8498         * cli/cli-utils.h: Rename include guard.
8499         * cli/cli-style.h: Rename include guard.
8500         * cli/cli-setshow.h: Rename include guard.
8501         * cli/cli-script.h: Rename include guard.
8502         * cli/cli-interp.h: Rename include guard.
8503         * cli/cli-decode.h: Rename include guard.
8504         * cli/cli-cmds.h: Rename include guard.
8505         * charset-list.h: Add include guard.
8506         * buildsym-legacy.h: Rename include guard.
8507         * bfin-tdep.h: Add include guard.
8508         * ax.h: Rename include guard.
8509         * arm-linux-tdep.h: Add include guard.
8510         * arm-fbsd-tdep.h: Add include guard.
8511         * arch/xtensa.h: Rename include guard.
8512         * arch/tic6x.h: Add include guard.
8513         * arch/i386.h: Add include guard.
8514         * arch/arm.h: Rename include guard.
8515         * arch/arm-linux.h: Rename include guard.
8516         * arch/arm-get-next-pcs.h: Rename include guard.
8517         * arch/amd64.h: Add include guard.
8518         * arch/aarch64-insn.h: Rename include guard.
8519         * arch-utils.h: Rename include guard.
8520         * annotate.h: Add include guard.
8521         * amd64-darwin-tdep.h: Rename include guard.
8522         * aarch64-linux-tdep.h: Add include guard.
8523         * aarch64-fbsd-tdep.h: Add include guard.
8524         * aarch32-linux-nat.h: Add include guard.
8525
8526 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8527
8528         * macrotab.c (macro_define_internal): New function that
8529         factorizes macro_define_object_internal and macro_define_function
8530         code.
8531         (macro_define_object_internal): Use macro_define_internal.
8532         (macro_define_function): Likewise.
8533
8534 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8535
8536         * macrocmd.c (extract_identifier): Return
8537         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8538         callers.
8539
8540 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8541
8542         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8543
8544 2019-02-05  Tom Tromey  <tom@tromey.com>
8545
8546         * target.c (target_stack::unpush): Move assertion earlier.
8547
8548 2019-01-30  Tom Tromey  <tom@tromey.com>
8549
8550         PR python/23615:
8551         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8552         (gdbpy_parse_and_eval): Likewise.
8553         * python/python-internal.h (gdbpy_allow_threads): New class.
8554
8555 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8556
8557         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8558         (aarch64_fbsd_fpregmap): Move earlier.
8559         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8560         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8561         instead of individual calls to trad_frame_set_reg_addr.
8562         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8563         earlier.
8564         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8565         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8566         instead of individual calls to trad_frame_set_reg_addr.
8567
8568 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8569
8570         * CONTRIBUTE: Replace contribution list with wiki link.
8571
8572 2019-01-25  Tom Tromey  <tom@tromey.com>
8573
8574         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8575
8576 2019-01-25  Tom Tromey  <tom@tromey.com>
8577
8578         * xtensa-linux-nat.c: Fix common/ includes.
8579         * xml-support.h: Fix common/ includes.
8580         * xml-support.c: Fix common/ includes.
8581         * x86-linux-nat.c: Fix common/ includes.
8582         * windows-nat.c: Fix common/ includes.
8583         * varobj.h: Fix common/ includes.
8584         * varobj.c: Fix common/ includes.
8585         * value.c: Fix common/ includes.
8586         * valops.c: Fix common/ includes.
8587         * utils.c: Fix common/ includes.
8588         * unittests/xml-utils-selftests.c: Fix common/ includes.
8589         * unittests/utils-selftests.c: Fix common/ includes.
8590         * unittests/unpack-selftests.c: Fix common/ includes.
8591         * unittests/tracepoint-selftests.c: Fix common/ includes.
8592         * unittests/style-selftests.c: Fix common/ includes.
8593         * unittests/string_view-selftests.c: Fix common/ includes.
8594         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8595         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8596         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8597         * unittests/rsp-low-selftests.c: Fix common/ includes.
8598         * unittests/parse-connection-spec-selftests.c: Fix common/
8599         includes.
8600         * unittests/optional-selftests.c: Fix common/ includes.
8601         * unittests/offset-type-selftests.c: Fix common/ includes.
8602         * unittests/observable-selftests.c: Fix common/ includes.
8603         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8604         * unittests/memrange-selftests.c: Fix common/ includes.
8605         * unittests/memory-map-selftests.c: Fix common/ includes.
8606         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8607         * unittests/function-view-selftests.c: Fix common/ includes.
8608         * unittests/environ-selftests.c: Fix common/ includes.
8609         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8610         * unittests/common-utils-selftests.c: Fix common/ includes.
8611         * unittests/cli-utils-selftests.c: Fix common/ includes.
8612         * unittests/array-view-selftests.c: Fix common/ includes.
8613         * ui-file.c: Fix common/ includes.
8614         * tui/tui-io.c: Fix common/ includes.
8615         * tracepoint.h: Fix common/ includes.
8616         * tracepoint.c: Fix common/ includes.
8617         * tracefile-tfile.c: Fix common/ includes.
8618         * top.h: Fix common/ includes.
8619         * top.c: Fix common/ includes.
8620         * thread.c: Fix common/ includes.
8621         * target/waitstatus.h: Fix common/ includes.
8622         * target/waitstatus.c: Fix common/ includes.
8623         * target.h: Fix common/ includes.
8624         * target.c: Fix common/ includes.
8625         * target-memory.c: Fix common/ includes.
8626         * target-descriptions.c: Fix common/ includes.
8627         * symtab.h: Fix common/ includes.
8628         * symfile.c: Fix common/ includes.
8629         * stap-probe.c: Fix common/ includes.
8630         * spu-linux-nat.c: Fix common/ includes.
8631         * sparc-nat.c: Fix common/ includes.
8632         * source.c: Fix common/ includes.
8633         * solib.c: Fix common/ includes.
8634         * solib-target.c: Fix common/ includes.
8635         * ser-unix.c: Fix common/ includes.
8636         * ser-tcp.c: Fix common/ includes.
8637         * ser-pipe.c: Fix common/ includes.
8638         * ser-base.c: Fix common/ includes.
8639         * selftest-arch.c: Fix common/ includes.
8640         * s12z-tdep.c: Fix common/ includes.
8641         * rust-exp.y: Fix common/ includes.
8642         * rs6000-aix-tdep.c: Fix common/ includes.
8643         * riscv-tdep.c: Fix common/ includes.
8644         * remote.c: Fix common/ includes.
8645         * remote-notif.h: Fix common/ includes.
8646         * remote-fileio.h: Fix common/ includes.
8647         * remote-fileio.c: Fix common/ includes.
8648         * regcache.h: Fix common/ includes.
8649         * regcache.c: Fix common/ includes.
8650         * record-btrace.c: Fix common/ includes.
8651         * python/python.c: Fix common/ includes.
8652         * python/py-type.c: Fix common/ includes.
8653         * python/py-inferior.c: Fix common/ includes.
8654         * progspace.h: Fix common/ includes.
8655         * producer.c: Fix common/ includes.
8656         * procfs.c: Fix common/ includes.
8657         * proc-api.c: Fix common/ includes.
8658         * printcmd.c: Fix common/ includes.
8659         * ppc-linux-nat.c: Fix common/ includes.
8660         * parser-defs.h: Fix common/ includes.
8661         * osdata.c: Fix common/ includes.
8662         * obsd-nat.c: Fix common/ includes.
8663         * nat/x86-linux.c: Fix common/ includes.
8664         * nat/x86-linux-dregs.c: Fix common/ includes.
8665         * nat/x86-dregs.h: Fix common/ includes.
8666         * nat/x86-dregs.c: Fix common/ includes.
8667         * nat/ppc-linux.c: Fix common/ includes.
8668         * nat/mips-linux-watch.h: Fix common/ includes.
8669         * nat/mips-linux-watch.c: Fix common/ includes.
8670         * nat/linux-waitpid.c: Fix common/ includes.
8671         * nat/linux-ptrace.h: Fix common/ includes.
8672         * nat/linux-ptrace.c: Fix common/ includes.
8673         * nat/linux-procfs.c: Fix common/ includes.
8674         * nat/linux-personality.c: Fix common/ includes.
8675         * nat/linux-osdata.c: Fix common/ includes.
8676         * nat/linux-namespaces.c: Fix common/ includes.
8677         * nat/linux-btrace.h: Fix common/ includes.
8678         * nat/linux-btrace.c: Fix common/ includes.
8679         * nat/fork-inferior.c: Fix common/ includes.
8680         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8681         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8682         * nat/aarch64-linux.c: Fix common/ includes.
8683         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8684         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8685         * namespace.h: Fix common/ includes.
8686         * mips-linux-tdep.c: Fix common/ includes.
8687         * minsyms.c: Fix common/ includes.
8688         * mi/mi-parse.h: Fix common/ includes.
8689         * mi/mi-main.c: Fix common/ includes.
8690         * mi/mi-cmd-env.c: Fix common/ includes.
8691         * memrange.h: Fix common/ includes.
8692         * memattr.c: Fix common/ includes.
8693         * maint.h: Fix common/ includes.
8694         * maint.c: Fix common/ includes.
8695         * main.c: Fix common/ includes.
8696         * machoread.c: Fix common/ includes.
8697         * location.c: Fix common/ includes.
8698         * linux-thread-db.c: Fix common/ includes.
8699         * linux-nat.c: Fix common/ includes.
8700         * linux-fork.c: Fix common/ includes.
8701         * inline-frame.c: Fix common/ includes.
8702         * infrun.c: Fix common/ includes.
8703         * inflow.c: Fix common/ includes.
8704         * inferior.h: Fix common/ includes.
8705         * inferior.c: Fix common/ includes.
8706         * infcmd.c: Fix common/ includes.
8707         * inf-ptrace.c: Fix common/ includes.
8708         * inf-child.c: Fix common/ includes.
8709         * ia64-linux-nat.c: Fix common/ includes.
8710         * i387-tdep.c: Fix common/ includes.
8711         * i386-tdep.c: Fix common/ includes.
8712         * i386-linux-tdep.c: Fix common/ includes.
8713         * i386-linux-nat.c: Fix common/ includes.
8714         * i386-go32-tdep.c: Fix common/ includes.
8715         * i386-fbsd-tdep.c: Fix common/ includes.
8716         * i386-fbsd-nat.c: Fix common/ includes.
8717         * guile/scm-type.c: Fix common/ includes.
8718         * guile/guile.c: Fix common/ includes.
8719         * go32-nat.c: Fix common/ includes.
8720         * gnu-nat.c: Fix common/ includes.
8721         * gdbthread.h: Fix common/ includes.
8722         * gdbarch-selftests.c: Fix common/ includes.
8723         * gdb_usleep.c: Fix common/ includes.
8724         * gdb_select.h: Fix common/ includes.
8725         * gdb_bfd.c: Fix common/ includes.
8726         * gcore.c: Fix common/ includes.
8727         * fork-child.c: Fix common/ includes.
8728         * findvar.c: Fix common/ includes.
8729         * fbsd-nat.c: Fix common/ includes.
8730         * event-top.c: Fix common/ includes.
8731         * event-loop.c: Fix common/ includes.
8732         * dwarf2read.c: Fix common/ includes.
8733         * dwarf2loc.c: Fix common/ includes.
8734         * dwarf2-frame.c: Fix common/ includes.
8735         * dwarf-index-cache.c: Fix common/ includes.
8736         * dtrace-probe.c: Fix common/ includes.
8737         * disasm-selftests.c: Fix common/ includes.
8738         * defs.h: Fix common/ includes.
8739         * csky-tdep.c: Fix common/ includes.
8740         * cp-valprint.c: Fix common/ includes.
8741         * cp-support.h: Fix common/ includes.
8742         * cp-support.c: Fix common/ includes.
8743         * corelow.c: Fix common/ includes.
8744         * completer.h: Fix common/ includes.
8745         * completer.c: Fix common/ includes.
8746         * compile/compile.c: Fix common/ includes.
8747         * compile/compile-loc2c.c: Fix common/ includes.
8748         * compile/compile-cplus-types.c: Fix common/ includes.
8749         * compile/compile-cplus-symbols.c: Fix common/ includes.
8750         * command.h: Fix common/ includes.
8751         * cli/cli-dump.c: Fix common/ includes.
8752         * cli/cli-cmds.c: Fix common/ includes.
8753         * charset.c: Fix common/ includes.
8754         * build-id.c: Fix common/ includes.
8755         * btrace.h: Fix common/ includes.
8756         * btrace.c: Fix common/ includes.
8757         * breakpoint.h: Fix common/ includes.
8758         * breakpoint.c: Fix common/ includes.
8759         * ax.h:
8760         (enum agent_op): Fix common/ includes.
8761         * ax-general.c (struct aop_map): Fix common/ includes.
8762         * ax-gdb.c: Fix common/ includes.
8763         * auxv.c: Fix common/ includes.
8764         * auto-load.c: Fix common/ includes.
8765         * arm-tdep.c: Fix common/ includes.
8766         * arch/riscv.c: Fix common/ includes.
8767         * arch/ppc-linux-common.c: Fix common/ includes.
8768         * arch/i386.c: Fix common/ includes.
8769         * arch/arm.c: Fix common/ includes.
8770         * arch/arm-linux.c: Fix common/ includes.
8771         * arch/arm-get-next-pcs.c: Fix common/ includes.
8772         * arch/amd64.c: Fix common/ includes.
8773         * arch/aarch64.c: Fix common/ includes.
8774         * arch/aarch64-insn.c: Fix common/ includes.
8775         * arch-utils.c: Fix common/ includes.
8776         * amd64-windows-tdep.c: Fix common/ includes.
8777         * amd64-tdep.c: Fix common/ includes.
8778         * amd64-sol2-tdep.c: Fix common/ includes.
8779         * amd64-obsd-tdep.c: Fix common/ includes.
8780         * amd64-nbsd-tdep.c: Fix common/ includes.
8781         * amd64-linux-tdep.c: Fix common/ includes.
8782         * amd64-linux-nat.c: Fix common/ includes.
8783         * amd64-fbsd-tdep.c: Fix common/ includes.
8784         * amd64-fbsd-nat.c: Fix common/ includes.
8785         * amd64-dicos-tdep.c: Fix common/ includes.
8786         * amd64-darwin-tdep.c: Fix common/ includes.
8787         * agent.c: Fix common/ includes.
8788         * ada-lang.h: Fix common/ includes.
8789         * ada-lang.c: Fix common/ includes.
8790         * aarch64-tdep.c: Fix common/ includes.
8791
8792 2019-01-25  Tom Tromey  <tom@tromey.com>
8793
8794         * common/create-version.sh: Use common/version.h.
8795
8796 2019-01-24  Pedro Alves  <palves@redhat.com>
8797
8798         * infrun.c (signal_stop, signal_print, signal_program)
8799         (signal_catch, signal_pass): Now arrays instead of pointers.
8800         (update_signals_program_target, do_target_resume)
8801         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8802         * linux-nat.c (linux_nat_target::pass_signals)
8803         (linux_nat_target::create_inferior, linux_nat_target::attach):
8804         Adjust.
8805         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8806         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8807         * procfs.c (procfs_target::pass_signals): Adjust.
8808         * record-full.c (record_full_target::resume): Adjust.
8809         * remote.c (remote_target::pass_signals)
8810         (remote_target::program_signals): Adjust.
8811         * target-debug.h (target_debug_print_signals): Now takes a
8812         gdb::array_view as parameter.  Adjust.
8813         * target.h (target_ops) <pass_signals, program_signals>: Replace
8814         pointer and length parameters with gdb::array_view.
8815         (target_pass_signals, target_program_signals): Likewise.
8816         * target-delegates.c: Regenerate.
8817
8818 2019-01-24  Pedro Alves  <palves@redhat.com>
8819
8820         * common/forward-scope-exit.h
8821         (forward_scope_exit::forward_scope_exit): Pass arguments to
8822         m_bind_function directly, instead of creating a std::bind and
8823         copying that.
8824
8825 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8826
8827         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8828         for static members.
8829         (pass_in_v_vfp_candidate): Likewise.
8830
8831 2019-01-23  Tom Tromey  <tom@tromey.com>
8832             Pedro Alves  <palves@redhat.com>
8833
8834         * regcache.c (class regcache_invalidator): Remove.
8835         (regcache::raw_write): Use make_scope_exit.
8836
8837 2019-01-23  Tom Tromey  <tom@tromey.com>
8838
8839         * ui-out.h (class ui_out_emit_type): Update comment.
8840
8841 2019-01-23  Tom Tromey  <tom@tromey.com>
8842
8843         * infrun.c (fetch_inferior_event): Update comment.
8844
8845 2019-01-23  Tom Tromey  <tom@tromey.com>
8846             Pedro Alves  <palves@redhat.com>
8847
8848         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8849         parameter.
8850         (fetch_inferior_event): Use SCOPE_EXIT.
8851
8852
8853 2019-01-23  Tom Tromey  <tom@tromey.com>
8854             Pedro Alves  <palves@redhat.com>
8855
8856         * infrun.c (disable_thread_events): Delete.
8857         (stop_all_threads): Use SCOPE_EXIT.
8858
8859 2019-01-23  Tom Tromey  <tom@tromey.com>
8860             Pedro Alves  <palves@redhat.com>
8861
8862         * symfile.c: Include forward-scope-exit.h.
8863         (clear_symtab_users_cleanup): Replace forward declaration with
8864         a FORWARD_SCOPE_EXIT.
8865         (syms_from_objfile_1): Use the forward_scope_exit and
8866         gdb::optional instead of cleanup_function.
8867         (reread_symbols): Use the forward_scope_exit instead of
8868         cleanup_function.
8869         (clear_symtab_users_cleanup): Remove function.
8870
8871 2019-01-23  Tom Tromey  <tom@tromey.com>
8872             Pedro Alves  <palves@redhat.com>
8873
8874         * linux-nat.c: Include scope-exit.h.
8875         (cleanup_target_stop): Remove.
8876         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8877         SCOPE_EXIT.
8878
8879 2019-01-23  Tom Tromey  <tom@tromey.com>
8880             Pedro Alves  <palves@redhat.com>
8881
8882         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8883         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8884
8885 2019-01-23  Tom Tromey  <tom@tromey.com>
8886             Andrew Burgess  <andrew.burgess@embecosm.com>
8887             Pedro Alves  <palves@redhat.com>
8888
8889         * infrun.c (fetch_inferior_event): Use scope_exit.
8890         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8891         * top.c (execute_command): Use scope_exit.
8892         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8893         * utils.c (do_bpstat_clear_actions_cleanup)
8894         (make_bpstat_clear_actions_cleanup): Remove.
8895
8896 2019-01-23  Tom Tromey  <tom@tromey.com>
8897             Pedro Alves  <palves@redhat.com>
8898
8899         * infrun.c: Include "common/scope-exit.h"
8900         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8901         (wait_for_inferior): Use SCOPE_EXIT.
8902         (fetch_inferior_event): Use scope_exit.
8903
8904 2019-01-23  Tom Tromey  <tom@tromey.com>
8905             Pedro Alves  <palves@redhat.com>
8906
8907         * breakpoint.c (create_breakpoint): Remove cleanup.
8908
8909 2019-01-23  Tom Tromey  <tom@tromey.com>
8910             Andrew Burgess  <andrew.burgess@embecosm.com>
8911             Pedro Alves  <palves@redhat.com>
8912
8913 2019-01-23  Pedro Alves  <palves@redhat.com>
8914
8915         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8916
8917 2019-01-23  Pedro Alves  <palves@redhat.com>
8918             Andrew Burgess  <andrew.burgess@embecosm.com>
8919
8920         * gdbthread.h: Include "common/forward-scope-exit.h".
8921         (scoped_finish_thread_state): Redefine custom class in terms of
8922         forward_scope_exit.
8923
8924 2019-01-23  Pedro Alves  <palves@redhat.com>
8925             Andrew Burgess  <andrew.burgess@embecosm.com>
8926
8927         * common/forward-scope-exit.h: New file.
8928
8929 2019-01-23  Pedro Alves  <palves@redhat.com>
8930             Andrew Burgess  <andrew.burgess@embecosm.com>
8931             Tom Tromey  <tom@tromey.com>
8932
8933         * common/scope-exit.h: New file.
8934
8935 2019-01-23  Pedro Alves  <palves@redhat.com>
8936
8937         * common/preprocessor.h (ESC): Rename to ...
8938         (ESC_PARENS): ... this.
8939         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8940         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8941
8942 2019-01-23  Tom Tromey  <tom@tromey.com>
8943
8944         * language.h (class scoped_switch_to_sym_language_if_auto):
8945         Initialize m_lang in both cases.
8946
8947 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8948
8949         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8950         with XCNEW.
8951
8952 2019-01-22  Tom Tromey  <tom@tromey.com>
8953
8954         * corelow.c: Do not include sys/file.h.
8955
8956 2019-01-22  Tom Tromey  <tom@tromey.com>
8957
8958         * tui/tui-wingeneral.h: Include gdb_curses.h.
8959
8960 2019-01-22  Tom Tromey  <tom@tromey.com>
8961
8962         * source-cache.h (class source_cache) <get_source_lines,
8963         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8964
8965 2019-01-22  Tom Tromey  <tom@tromey.com>
8966
8967         * remote-fileio.h (struct remote_target): Declare.
8968
8969 2019-01-22  Tom Tromey  <tom@tromey.com>
8970
8971         * python/py-arch.c: Do not include py-ref.h.
8972         * python/py-bpevent.c: Do not include py-ref.h.
8973         * python/py-cmd.c: Do not include py-ref.h.
8974         * python/py-continueevent.c: Do not include py-ref.h.
8975         * python/py-event.h: Do not include py-ref.h.
8976         * python/py-evtregistry.c: Do not include py-ref.h.
8977         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8978         * python/py-frame.c: Do not include py-ref.h.
8979         * python/py-framefilter.c: Do not include py-ref.h.
8980         * python/py-function.c: Do not include py-ref.h.
8981         * python/py-infevents.c: Do not include py-ref.h.
8982         * python/py-linetable.c: Do not include py-ref.h.
8983         * python/py-objfile.c: Do not include py-ref.h.
8984         * python/py-param.c: Do not include py-ref.h.
8985         * python/py-prettyprint.c: Do not include py-ref.h.
8986         * python/py-progspace.c: Do not include py-ref.h.
8987         * python/py-symbol.c: Do not include py-ref.h.
8988         * python/py-symtab.c: Do not include py-ref.h.
8989         * python/py-type.c: Do not include py-ref.h.
8990         * python/py-unwind.c: Do not include py-ref.h.
8991         * python/py-utils.c: Do not include py-ref.h.
8992         * python/py-value.c: Do not include py-ref.h.
8993         * python/py-varobj.c: Do not include py-ref.h.
8994         * python/py-xmethods.c: Do not include py-ref.h.
8995         * python/python.c: Do not include py-ref.h.
8996         * varobj.c: Do not include py-ref.h.
8997
8998 2019-01-22  Tom Tromey  <tom@tromey.com>
8999
9000         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9001         keyword for bcache.
9002
9003 2019-01-22  Tom Tromey  <tom@tromey.com>
9004
9005         * compile/compile-cplus-types.c: Remove a comment by #include.
9006
9007 2019-01-22  Tom Tromey  <tom@tromey.com>
9008
9009         * compile/gcc-c-plugin.h: Include compile-internal.h.
9010
9011 2019-01-22  Tom Tromey  <tom@tromey.com>
9012
9013         * stabsread.c (EXTERN): Do not define.
9014         (symnum, next_symbol_text_func, processing_gcc_compilation)
9015         (within_function, global_sym_chain, global_stabs)
9016         (previous_stab_code, this_object_header_files)
9017         (n_this_object_header_files)
9018         (n_allocated_this_object_header_files): Define.
9019         * stabsread.h (EXTERN): Never define.  Use "extern".
9020
9021 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9022
9023         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9024         history_value.
9025
9026 2019-01-21  Tom Tromey  <tom@tromey.com>
9027
9028         * ui-out.c: Fix includes.
9029         * tui/tui-source.c: Fix includes.
9030         * target.c: Fix includes.
9031         * remote.c: Fix includes.
9032         * regcache.c: Fix includes.
9033         * python/py-block.c: Fix includes.
9034         * printcmd.c: Fix includes.
9035         * or1k-tdep.c: Fix includes.
9036         * mi/mi-main.c: Fix includes.
9037         * m32r-tdep.c: Fix includes.
9038         * csky-tdep.c: Fix includes.
9039         * compile/compile-cplus-types.c: Fix includes.
9040         * cli/cli-interp.c: Fix includes.
9041
9042 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9043
9044         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9045         for padding.
9046
9047 2019-01-16  Tom Tromey  <tom@tromey.com>
9048
9049         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9050         earlier.
9051         (struct objfile) <msymbols_range>: Move from top level.
9052         <msymbols>: New method.
9053         (class objfile_msymbols): Remove.
9054         * symtab.c (default_collect_symbol_completion_matches_break_on):
9055         Update.
9056         * symmisc.c (dump_msymbols): Update.
9057         * stabsread.c (scan_file_globals): Update.
9058         * objc-lang.c (info_selectors_command, info_classes_command)
9059         (find_methods): Update.
9060         * minsyms.c (find_solib_trampoline_target): Update.
9061         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9062         * coffread.c (coff_symfile_read): Update.
9063         * ada-lang.c (ada_lookup_simple_minsym)
9064         (ada_collect_symbol_completion_matches): Update.
9065
9066 2019-01-16  Tom Tromey  <tom@tromey.com>
9067
9068         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9069         type.  Remove no-argument constructor.
9070         <iterator::operator++>: Simplify.
9071         <begin>: Update.
9072         <end>: Use minimal_symbol_count.
9073
9074 2019-01-16  Tom Tromey  <tom@tromey.com>
9075
9076         * objfiles.h (struct objfile) <psymtabs>: New method.
9077         (class objfile_psymtabs): Remove.
9078         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9079         typedef.
9080         <range>: New method.
9081         (require_partial_symbols): Change return type.
9082         * psymtab.c (require_partial_symbols)
9083         (psym_expand_symtabs_matching): Update.
9084         * mdebugread.c (parse_partial_symbols): Update.
9085         * dbxread.c (dbx_end_psymtab): Update.
9086
9087 2019-01-15  Tom Tromey  <tom@tromey.com>
9088
9089         * symtab.c (lookup_objfile_from_block)
9090         (lookup_symbol_in_objfile_symtabs)
9091         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9092         (find_line_symtab, info_sources_command)
9093         (default_collect_symbol_completion_matches_break_on)
9094         (make_source_files_completion_list): Update.
9095         * symmisc.c (print_objfile_statistics, dump_objfile)
9096         (maintenance_print_symbols, maintenance_info_symtabs)
9097         (maintenance_check_symtabs, maintenance_info_line_tables):
9098         Update.
9099         * source.c (select_source_symtab)
9100         (forget_cached_source_info_for_objfile): Update.
9101         * objfiles.h (class objfile_compunits): Remove.
9102         (struct objfile) <compunits_range>: New typedef.
9103         (compunits): New method.
9104         * objfiles.c (objfile_relocate1): Update.
9105         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9106         * maint.c (count_symtabs_and_blocks): Update.
9107         * linespec.c (iterate_over_all_matching_symtabs): Update.
9108         * cp-support.c (add_symbol_overload_list_qualified): Update.
9109         * coffread.c (coff_symtab_read): Update.
9110         * ada-lang.c (add_nonlocal_symbols)
9111         (ada_collect_symbol_completion_matches)
9112         (ada_add_global_exceptions): Update.
9113
9114 2019-01-15  Tom Tromey  <tom@tromey.com>
9115
9116         * progspace.h (program_space) <objfiles_safe_range>: New
9117         typedef.
9118         <objfiles_safe>: New method.
9119         * objfiles.h (class all_objfiles_safe): Remove.
9120         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9121         * jit.c (jit_inferior_exit_hook): Update.
9122
9123 2019-01-17  Tom Tromey  <tom@tromey.com>
9124
9125         * progspace.h (program_space) <objfiles_range>: New typedef.
9126         <objfiles>: New method.
9127         <objfiles_head>: Rename from objfiles.
9128         (object_files): Update.
9129         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9130         * guile/scm-pretty-print.c
9131         (ppscm_find_pretty_printer_from_objfiles): Update.
9132         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9133         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9134         Update.
9135         * python/py-progspace.c (pspy_get_objfiles): Update.
9136         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9137         Update.
9138         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9139         (objfpy_lookup_objfile_by_build_id): Update.
9140         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9141         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9142         Update.
9143         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9144         (expand_symtab_containing_pc, lookup_objfile_from_block)
9145         (lookup_static_symbol, basic_lookup_transparent_type)
9146         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9147         (find_line_symtab, info_sources_command)
9148         (default_collect_symbol_completion_matches_break_on)
9149         (make_source_files_completion_list, find_main_name): Update.
9150         * symmisc.c (print_symbol_bcache_statistics)
9151         (print_objfile_statistics, maintenance_print_symbols)
9152         (maintenance_print_msymbols, maintenance_print_objfiles)
9153         (maintenance_info_symtabs, maintenance_check_symtabs)
9154         (maintenance_expand_symtabs, maintenance_info_line_tables):
9155         Update.
9156         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9157         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9158         (map_overlay_command, unmap_overlay_command)
9159         (simple_overlay_update, expand_symtabs_matching)
9160         (map_symbol_filenames): Update.
9161         * symfile-debug.c (set_debug_symfile): Update.
9162         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9163         Update.
9164         * source.c (select_source_symtab, forget_cached_source_info):
9165         Update.
9166         * solib.c (solib_read_symbols): Update.
9167         * solib-spu.c (append_ocl_sos): Update.
9168         * psymtab.c (maintenance_print_psymbols)
9169         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9170         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9171         * printcmd.c (info_symbol_command): Update.
9172         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9173         Update.
9174         * objfiles.h (class all_objfiles): Remove.
9175         * objfiles.c (have_partial_symbols, have_full_symbols)
9176         (have_minimal_symbols, qsort_cmp, update_section_map)
9177         (shared_objfile_contains_address_p)
9178         (default_iterate_over_objfiles_in_search_order): Update.
9179         * objc-lang.c (info_selectors_command, info_classes_command)
9180         (find_methods): Update.
9181         * minsyms.c (find_solib_trampoline_target): Update.
9182         * maint.c (maintenance_info_sections)
9183         (maintenance_translate_address, count_symtabs_and_blocks):
9184         Update.
9185         * main.c (captured_main_1): Update.
9186         * linux-thread-db.c (try_thread_db_load_from_pdir)
9187         (has_libpthread): Update.
9188         * linespec.c (iterate_over_all_matching_symtabs)
9189         (search_minsyms_for_name): Update.
9190         * jit.c (jit_find_objf_with_entry_addr): Update.
9191         * hppa-tdep.c (find_unwind_entry)
9192         (hppa_lookup_stub_minimal_symbol): Update.
9193         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9194         Update.
9195         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9196         (elf_gnu_ifunc_resolve_by_got): Update.
9197         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9198         * dwarf-index-write.c (save_gdb_index_command): Update.
9199         * cp-support.c (add_symbol_overload_list_qualified): Update.
9200         * breakpoint.c (create_overlay_event_breakpoint)
9201         (create_longjmp_master_breakpoint)
9202         (create_std_terminate_master_breakpoint)
9203         (create_exception_master_breakpoint): Update.
9204         * blockframe.c (find_pc_partial_function): Update.
9205         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9206         (ada_collect_symbol_completion_matches)
9207         (ada_add_global_exceptions): Update.
9208
9209 2019-01-17  Tom Tromey  <tom@tromey.com>
9210
9211         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9212         declare VEC.
9213         (solib_target_parse_libraries): Change return type.
9214         (library_list_start_segment, library_list_start_section)
9215         (library_list_end_library, library_list_start_library); Update.
9216         (solib_target_free_library_list): Remove.
9217         (solib_target_parse_libraries): Remove cleanup.  Change return
9218         type.
9219         (solib_target_current_sos): Update.
9220
9221 2019-01-17  Tom Tromey  <tromey@bapiya>
9222
9223         * valprint.c: Replace "the the" with "the".
9224         * symtab.c: Replace "the the" with "the".
9225         * solib.c: Replace "the the" with "the".
9226         * solib-dsbt.c: Replace "the the" with "the".
9227         * linespec.c: Replace "the the" with "the".
9228         * dwarf2loc.h: Replace "the the" with "the".
9229         * amd64-windows-tdep.c: Replace "the the" with "the".
9230         * aarch64-tdep.c: Replace "the the" with "the".
9231
9232 2019-01-16  Keith Seitz  <keiths@redhat.com>
9233
9234         PR gdb/23773
9235         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9236         <builder>: Rename to ..
9237         <m_builder>: ... this and make private.
9238         (dwarf2_cu::get_builder): New method.  Change all users of
9239         `builder' to use this method.
9240         (dwarf2_start_symtab): Move to ...
9241         (dwarf2_cu::start_symtab): ... here.  Update all callers
9242         (setup_type_unit_groups): Move to ...
9243         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9244         callers.
9245         (dwarf2_cu::reset_builder): New method.
9246         (process_full_compunit, process_full_type_unit): Use
9247         dwarf2_cu::reset_builder.
9248         (follow_die_offset): Record the ancestor CU if it is different
9249         from the followed DIE's CU.
9250         (follow_die_sig_1): Likewise.
9251
9252 2019-01-15  Tom Tromey  <tom@tromey.com>
9253
9254         * remote.c (class remote_state) <buf>: Now a char_vector.
9255         <buf_size>: Remove.
9256         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9257         parameter.
9258         (remote_target::getpkt_or_notif_sane_1)
9259         (remote_target::getpkt_sane)
9260         (remote_target::getpkt_or_notif_sane): Likewise.
9261         (class remote_target) <putpkt>: New overload.
9262         (remote_target::read_frame): Change type of "buf_p".  Remove
9263         sizeof_p parameter.
9264         (packet_ok): New overload.
9265         (packet_check_result): New overload.
9266         Update all uses.
9267
9268 2019-01-14  Tom Tromey  <tom@tromey.com>
9269
9270         * remote-notif.c (handle_notification, remote_notif_ack)
9271         (remote_notif_parse): Make "buf" const.
9272         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9273         const.
9274         (remote_notif_parse, remote_notif_ack, handle_notification):
9275         Likewise.
9276         * remote.c (remote_notif_stop_parse): Make "buf" const.
9277         (remote_target::remote_parse_stop_reply): Make "buf" const.
9278         (remote_notif_stop_ack): Make "buf" const.
9279
9280 2019-01-14  Tom Tromey  <tom@tromey.com>
9281
9282         * remote.c (remote_console_output): Make parameter const.
9283
9284 2019-01-14  Tom Tromey  <tom@tromey.com>
9285
9286         * target-debug.h (target_debug_print_signals): Constify.
9287         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9288         * procfs.c (procfs_target::pass_signals): Update.
9289         * linux-nat.c (linux_nat_target::pass_signals): Update.
9290         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9291         * target-delegates.c: Rebuild.
9292         * remote.c (remote_target::program_signals): Update.
9293         (remote_target::pass_signals): Update.
9294         * target.c (target_pass_signals): Constify argument.
9295         (target_program_signals): Likewise.
9296         * target.h (struct target_ops) <pass_signals, program_signals>:
9297         Constify argument.
9298         (target_pass_signals, target_program_signals): Constify argument.
9299
9300 2019-01-14  Tom Tromey  <tom@tromey.com>
9301
9302         PR tui/28819:
9303         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9304
9305 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9306
9307         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9308         field.
9309         * rs6000-tdep.c: Include reggroups.h.
9310         (IS_V_ALIAS_PSEUDOREG): Define.
9311         (rs6000_register_name): Return names for the "vX" aliases.
9312         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9313         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9314         aliases.  Call default_register_reggroup_p for all other
9315         pseudo-registers.
9316         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9317         New functions.
9318         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9319         Handle "vX" aliases.
9320         (v_alias_pseudo_register_collect): New function.
9321         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9322         (rs6000_gdbarch_init): Initialize "vX" aliases as
9323         pseudo-registers.  Restore registration of
9324         rs6000_pseudo_register_reggroup_p with
9325         set_tdesc_pseudo_register_reggroup_p.
9326
9327 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9328
9329         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9330         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9331         set_gdbarch_num_pseudo_regs.
9332
9333 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9334
9335         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9336         Remove arg prefixname, add do_set and do_show.
9337         Add member functions set_list and show_list.
9338         * cli/cli-style.c (class cli_style_option): Update accordingly.
9339         (style_set_list): Move to file scope.
9340         (style_show_list): Likewise.
9341         (set_style): Call help_list.
9342         (show_style): Call cmd_show_list.
9343         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9344         Update to use the new macro.
9345
9346 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9347
9348         * ada-lang.c (_initialize_ada_language): Expand the help text
9349         for the "catch exception" command.
9350
9351 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9352
9353         * symtab.c (matching_obj_sections): Initialize obj,
9354         declare it closer to its usage.
9355
9356 2019-01-10  Tom Tromey  <tom@tromey.com>
9357
9358         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9359         (basic_inf_threads_range): Remove.
9360         (inf_threads_range, inf_non_exited_threads_range)
9361         (safe_inf_threads_range): Use next_adapter.
9362
9363 2019-01-10  Keith Seitz  <keiths@redhat.com>
9364
9365         PR gdb/23712
9366         PR symtab/23010
9367         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9368         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9369
9370 2019-01-10  Keith Seitz  <keiths@redhat.com>
9371
9372         PR gdb/23712
9373         PR symtab/23010
9374         * dictionary.c (pending_to_vector): Remove.
9375         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9376         Remove _1 suffix, replacing functions of the same name.  Update
9377         all callers.
9378         (dict_create_hashed, dict_create_hashed_expandable)
9379         (dict_create_linear, dict_create_linear_expandable, dict_free)
9380         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9381         Make functions static.
9382
9383 2019-01-10  Keith Seitz  <keiths@redhat.com>
9384
9385         PR gdb/23712
9386         PR symtab/23010
9387         * dictionary.h (struct dictionary): Replace declaration with
9388         multidictionary.
9389         (dict_create_hashed, dict_create_hashed_expandable)
9390         (dict_create_linear, dict_create_linear_expandable)
9391         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9392         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9393         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9394         taking multidictionary argument.
9395         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9396         * block.h (struct block) <dict>: Change to multidictionary
9397         and rename `multidict'.
9398         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9399         symmisc.c: Update all dictionary references to multidictionary.
9400
9401 2019-01-10  Keith Seitz  <keiths@redhat.com>
9402
9403         PR gdb/23712
9404         PR symtab/23010
9405         * dictionary.c: Include unordered_map.
9406         (pending_to_vector): New function.
9407         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9408         Rewrite the non-"_1" functions to take vector instead
9409         of linked list.
9410         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9411         "new" _1 versions of the same name.
9412         (multidictionary): Define.
9413         (std::hash<enum language): New definition.
9414         (collate_pending_symbols_by_language, mdict_create_hashed)
9415         (mdict_create_hashed_expandable, mdict_create_linear)
9416         (mdict_create_linear_expandable, mdict_free)
9417         (find_language_dictionary, create_new_language_dictionary)
9418         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9419         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9420         (mdict_size, mdict_empty): New functions.
9421         * dictionary.h (mdict_iterator): Define.
9422
9423 2019-01-10  Pedro Alves  <palves@redhat.com>
9424
9425         * breakpoint.c (read_uploaded_action)
9426         (create_tracepoint_from_upload): Adjust to use
9427         gdb::unique_xmalloc_ptr.
9428         * ctf.c (ctf_write_uploaded_tp):
9429         (SET_ARRAY_FIELD): Use emplace_back.
9430         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9431         * tracefile-tfile.c (tfile_write_uploaded_tp):
9432         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9433         gdb::unique_xmalloc_ptr.
9434         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9435         at_string, cond_string, cmd_strings>: Replace char pointers
9436         with gdb::unique_xmalloc_ptr.
9437
9438 2019-01-10  Pedro Alves  <palves@redhat.com>
9439
9440         * solib-target.c (library_list_start_library): Don't xstrdup name.
9441
9442 2019-01-10  Pedro Alves  <palves@redhat.com>
9443
9444         * mdebugread.c (parse_partial_symbols): Use
9445         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9446
9447 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9448
9449         * linux-fork.c (scoped_switch_fork_info)
9450         <~scoped_switch_fork_info>: Fix incorrect variable name.
9451
9452 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9453
9454         * linux-fork.c (scoped_switch_fork_info)
9455         <scoped_switch_fork_info>: Make explicit.
9456         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9457
9458 2019-01-10  Tom Tromey  <tom@tromey.com>
9459
9460         * objfiles.h (objfile::reset_psymtabs): Update.
9461         * objfiles.c (objfile::objfile): Update.
9462         * psymtab.h (psymtab_storage::obstack): Update.
9463         (psymtab_storage::m_obstack): Use gdb::optional.
9464         (class psymtab_storage): Update comment.  Remove objfile
9465         parameter.
9466         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9467
9468 2019-01-10  Tom Tromey  <tom@tromey.com>
9469
9470         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9471         <free_psymtabs>: Now private.
9472         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9473         (allocate_psymtab): Use new method.
9474
9475 2019-01-10  Tom Tromey  <tom@tromey.com>
9476
9477         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9478         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9479         * mdebugread.c (parse_partial_symbols): Use
9480         allocate_dependencies.
9481         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9482         allocate_dependencies.
9483         (process_psymtab_comp_unit_reader)
9484         (build_type_psymtab_dependencies): Likewise.
9485         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9486
9487 2019-01-10  Tom Tromey  <tom@tromey.com>
9488
9489         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9490         PSYMBOL_SET_LANGUAGE.
9491         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9492
9493 2019-01-10  Tom Tromey  <tom@tromey.com>
9494
9495         * psymtab.h (psymtab_storage::obstack): New method.
9496         <m_obstack>: Rename from obstack; now private.
9497         * psymtab.c (psymtab_storage): Update.
9498         * dwarf2read.c (create_addrmap_from_index)
9499         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9500         Update.
9501
9502 2019-01-10  Tom Tromey  <tom@tromey.com>
9503
9504         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9505         * objfiles.h (objfile::reset_psymtabs): New method.
9506
9507 2019-01-10  Tom Tromey  <tom@tromey.com>
9508
9509         * symmisc.c (print_symbol_bcache_statistics): Update.
9510         (print_objfile_statistics): Update.
9511         * symfile.c (reread_symbols): Update.
9512         * psymtab.h (class psymtab_storage): New.
9513         * psymtab.c (psymtab_storage): New constructor.
9514         (~psymtab_storage): New destructor.
9515         (require_partial_symbols): Update.
9516         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9517         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9518         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9519         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9520         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9521         (start_psymtab_common, end_psymtab_common)
9522         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9523         (allocate_psymtab): Update.
9524         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9525         Update.
9526         (dump_psymtab_addrmap, maintenance_print_psymbols)
9527         (maintenance_check_psymtabs): Update.
9528         (class objfile_psymtabs): Move to objfiles.h.
9529         * psympriv.h (discard_psymtab): Now inline.
9530         (psymtab_discarder::psymtab_discarder): Update.
9531         (psymtab_discarder::~psymtab_discarder): Update.
9532         (ALL_OBJFILE_PSYMTABS): Rewrite.
9533         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9534         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9535         Remove fields.
9536         <partial_symtabs>: New field.
9537         (class objfile_psymtabs): Move from psymtab.h.  Update.
9538         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9539         psymbol_cache.
9540         (objfile::~objfile): Don't destroy psymbol_cache.
9541         * mdebugread.c (parse_partial_symbols): Update.
9542         * dwarf2read.c (create_addrmap_from_index)
9543         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9544         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9545         (add_partial_subprogram, dwarf2_ranges_read): Update.
9546         * dwarf-index-write.c (write_address_map)
9547         (write_one_signatured_type, recursively_write_psymbols)
9548         (class debug_names, class debug_names, write_psymtabs_to_index):
9549         Update.
9550
9551 2019-01-10  Tom Tromey  <tom@tromey.com>
9552
9553         * symtab.h (SYMBOL_SET_NAMES): Update.
9554         (symbol_set_names): Update.
9555         (MSYMBOL_SET_NAMES): Update.
9556         * symtab.c (symbol_set_names): Change argument to be an
9557         objfile_per_bfd_storage.
9558         * psymtab.c (add_psymbol_to_bcache): Update.
9559         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9560
9561 2019-01-10  Tom Tromey  <tom@tromey.com>
9562
9563         * symtab.c (create_demangled_names_hash): Change argument to be an
9564         objfile_per_bfd_storage.
9565         (symbol_set_names): Update.
9566
9567 2019-01-10  Tom Tromey  <tom@tromey.com>
9568
9569         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9570         init_psymbol_list.
9571         * psymtab.c (init_psymbol_list): Do nothing if already called.
9572         * psympriv.h (init_psymbol_list): Add comment.
9573         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9574         init_psymbol_list.
9575         * dbxread.c (dbx_symfile_read): Unconditionally call
9576         init_psymbol_list.
9577
9578 2019-01-10  Tom Tromey  <tom@tromey.com>
9579
9580         * xcoffread.c (scan_xcoff_symtab): Update.
9581         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9582         "where".
9583         * mdebugread.c (parse_partial_symbols)
9584         (handle_psymbol_enumerators): Update.
9585         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9586         * dbxread.c (read_dbx_symtab): Update.
9587         * psympriv.h (psymbol_placement): New enum.
9588         (add_psymbol_to_list): Update.
9589
9590 2019-01-10  Tom Tromey  <tom@tromey.com>
9591
9592         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9593         static_psymbols parameters.
9594         (scan_xcoff_symtab): Update.
9595         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9596         static_psymbols parameters.
9597         * psympriv.h (start_psymtab_common): Update.
9598         * mdebugread.c (parse_partial_symbols): Update.
9599         * dwarf2read.c (create_partial_symtab): Update.
9600         * dbxread.c (read_dbx_symtab): Update.
9601         (start_psymtab): Remove global_psymbols and static_psymbols
9602         parameters.
9603
9604 2019-01-10  Tom Tromey  <tom@tromey.com>
9605
9606         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9607         * psymtab.c (allocate_psymtab): Add comment.
9608         * psympriv.h (allocate_psymtab): Add comment.
9609         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9610         initializations.
9611         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9612
9613 2019-01-10  Tom Tromey  <tom@tromey.com>
9614
9615         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9616         Don't declare.
9617         * mipsread.c: Include mdebugread.h.
9618         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9619         Declare.
9620         * elfread.c: Include mdebugread.h.
9621
9622 2019-01-09  Tom Tromey  <tom@tromey.com>
9623
9624         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9625         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9626         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9627         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9628         (psym_lookup_symbol, psym_find_last_source_symtab)
9629         (psym_forget_cached_source_info, psym_print_stats)
9630         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9631         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9632         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9633         (psym_find_compunit_symtab_by_address)
9634         (maintenance_print_psymbols, maintenance_info_psymtabs)
9635         (maintenance_check_psymtabs): Use ranged for.
9636         * psymtab.h (class objfile_psymtabs): New.
9637         (require_partial_symbols): Return objfile_psymtabs.
9638         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9639
9640 2019-01-09  Tom Tromey  <tom@tromey.com>
9641
9642         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9643         (find_pc_mapped_section, list_overlays_command)
9644         (map_overlay_command, unmap_overlay_command)
9645         (simple_overlay_update): Use all_objfiles.
9646         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9647         * printcmd.c (info_symbol_command): Use all_objfiles.
9648         * objfiles.h (ALL_OBJSECTIONS): Remove.
9649         * maint.c (maintenance_translate_address): Use all_objfiles.
9650         * gcore.c (gcore_create_callback): Use all_objfiles.
9651         (objfile_find_memory_regions): Likewise.
9652
9653 2019-01-09  Tom Tromey  <tom@tromey.com>
9654
9655         * symtab.c (find_line_symtab, info_sources_command)
9656         (make_source_files_completion_list): Use objfile_compunits.
9657         * source.c (select_source_symtab): Use objfile_compunits.
9658         * objfiles.h (struct objfile): Update comment.
9659         (ALL_OBJFILES): Remove.
9660         (ALL_FILETABS): Remove.
9661         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9662         objfile_compunits.
9663
9664 2019-01-09  Tom Tromey  <tom@tromey.com>
9665
9666         * symmisc.c (print_objfile_statistics, dump_objfile)
9667         (maintenance_print_symbols): Use compunit_filetabs.
9668         * source.c (forget_cached_source_info_for_objfile): Use
9669         compunit_filetabs.
9670         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9671         (ALL_FILETABS): Use compunit_filetabs.
9672         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9673         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9674
9675 2019-01-09  Tom Tromey  <tom@tromey.com>
9676
9677         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9678         (compunit_filetabs): New.
9679         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9680         compunit_filetabs.
9681         (info_sources_command, make_source_files_completion_list): Remove
9682         declaration.
9683         * symmisc.c (print_objfile_statistics, dump_objfile)
9684         (maintenance_print_symbols): Remove declaration.
9685         (maintenance_info_symtabs): Use compunit_filetabs.
9686         (maintenance_info_line_tables): Likewise.
9687         * source.c (select_source_symtab): Change local variable name.
9688         (forget_cached_source_info_for_objfile): Remove declaration.
9689         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9690         * objfiles.c (objfile_relocate1): Remove declaration.
9691         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9692         declaration.
9693         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9694         * coffread.c (coff_symtab_read): Remove declaration.
9695         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9696         compunit_filetabs.
9697
9698 2019-01-09  Tom Tromey  <tom@tromey.com>
9699
9700         * symtab.c (lookup_objfile_from_block)
9701         (find_pc_sect_compunit_symtab, search_symbols)
9702         (default_collect_symbol_completion_matches_break_on): Use
9703         objfile_compunits.
9704         * objfiles.h (ALL_COMPUNITS): Remove.
9705         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9706         * cp-support.c (add_symbol_overload_list_qualified): Use
9707         objfile_compunits.
9708         * ada-lang.c (ada_collect_symbol_completion_matches)
9709         (ada_add_global_exceptions): Use objfile_compunits.
9710
9711 2019-01-09  Tom Tromey  <tom@tromey.com>
9712
9713         * source.c (select_source_symtab)
9714         (forget_cached_source_info_for_objfile): Remove declaration.
9715         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9716         declaration.
9717         * maint.c (count_symtabs_and_blocks): Remove declaration.
9718         * cp-support.c (add_symbol_overload_list_qualified): Remove
9719         declaration.
9720         * coffread.c (coff_symtab_read): Remove declaration.
9721         * symtab.c (lookup_symbol_in_objfile_symtabs)
9722         (basic_lookup_transparent_type_1): Use objfile_compunits.
9723         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9724         (info_sources_command, search_symbols)
9725         (default_collect_symbol_completion_matches_break_on)
9726         (make_source_files_completion_list): Remove declaration.
9727         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9728         (ada_collect_symbol_completion_matches)
9729         (ada_add_global_exceptions): Remove declaration.
9730         * linespec.c (iterate_over_all_matching_symtabs): Use
9731         objfile_compunits.
9732         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9733         (class objfile_compunits): New.
9734         (ALL_COMPUNITS): Use objfile_compunits.
9735         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9736         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9737         objfile_compunits.
9738         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9739
9740 2019-01-09  Tom Tromey  <tom@tromey.com>
9741
9742         * symtab.c (search_symbols)
9743         (default_collect_symbol_completion_matches_break_on): Use
9744         objfile_msymbols.
9745         * ada-lang.c (ada_lookup_simple_minsym)
9746         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9747         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9748         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9749         objfile_msymbols.
9750         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9751         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9752         * objc-lang.c (find_methods): Use objfile_msymbols.
9753         (info_selectors_command, info_classes_command): Likewise.
9754         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9755         * objfiles.h (class objfile_msymbols): New.
9756         (ALL_OBJFILE_MSYMBOLS): Remove.
9757         (ALL_MSYMBOLS): Remove.
9758
9759 2019-01-09  Tom Tromey  <tom@tromey.com>
9760
9761         * common/next-iterator.h (next_adapter): Add Iterator template
9762         parameter.
9763         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9764         (class all_objfiles_safe): New.
9765         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9766         * objfiles.c (put_objfile_before): Update comment.
9767         (add_separate_debug_objfile): Likewise.
9768         (free_all_objfiles): Use all_objfiles_safe.
9769         (objfile_purge_solibs): Likewise.
9770
9771 2019-01-09  Tom Tromey  <tom@tromey.com>
9772
9773         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9774         (expand_symtab_containing_pc, lookup_static_symbol)
9775         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9776         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9777         all_objfiles.
9778         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9779         * breakpoint.c (create_overlay_event_breakpoint)
9780         (create_longjmp_master_breakpoint)
9781         (create_std_terminate_master_breakpoint)
9782         (create_exception_master_breakpoint): Use all_objfiles.
9783         * linux-thread-db.c (try_thread_db_load_from_pdir)
9784         (has_libpthread): Use all_objfiles.
9785         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9786         * linespec.c (iterate_over_all_matching_symtabs)
9787         (search_minsyms_for_name): Use all_objfiles.
9788         * maint.c (maintenance_info_sections): Use all_objfiles.
9789         * main.c (captured_main_1): Use all_objfiles.
9790         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9791         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9792         * guile/scm-pretty-print.c
9793         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9794         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9795         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9796         (maintenance_print_msymbols): Use all_objfiles.
9797         * source.c (select_source_symtab): Use all_objfiles.
9798         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9799         * symfile.c (remove_symbol_file_command)
9800         (expand_symtabs_matching, map_symbol_filenames): Use
9801         all_objfiles.
9802         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9803         all_objfiles.
9804         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9805         * objc-lang.c (find_methods): Use all_objfiles.
9806         * objfiles.c (have_partial_symbols, have_full_symbols)
9807         (have_minimal_symbols, qsort_cmp)
9808         (default_iterate_over_objfiles_in_search_order): Use
9809         all_objfiles.
9810         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9811         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9812         (maintenance_check_psymtabs): Use all_objfiles.
9813         (ALL_PSYMTABS): Remove.
9814         * compile/compile-object-run.c (do_module_cleanup): Use
9815         all_objfiles.
9816         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9817         * cp-support.c (add_symbol_overload_list_qualified): Use
9818         all_objfiles.
9819         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9820         Use all_objfiles.
9821         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9822         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9823         all_objfiles.
9824         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9825         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9826         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9827         Uses all_objfiles.
9828         * solib.c (solib_read_symbols): Use all_objfiles
9829
9830 2019-01-09  Tom Tromey  <tom@tromey.com>
9831
9832         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9833         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9834         all_objfiles.
9835         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9836         * symmisc.c (print_symbol_bcache_statistics)
9837         (print_objfile_statistics, maintenance_print_objfiles)
9838         (maintenance_info_symtabs, maintenance_check_symtabs)
9839         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9840         all_objfiles.
9841         * source.c (forget_cached_source_info): Use all_objfiles.
9842         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9843         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9844         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9845         * objfiles.c (update_section_map): Use all_objfiles.
9846         (shared_objfile_contains_address_p): Likewise.
9847         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9848         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9849
9850 2019-01-09  Tom Tromey  <tom@tromey.com>
9851
9852         * common/next-iterator.h: New file.
9853         * objfiles.h (class all_objfiles): New.
9854         (struct objfile_iterator): New.
9855
9856 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9857
9858         * NEWS: Move the description of the changed "frame", "select-frame",
9859          and "info frame" commands to the Changed commands section.
9860
9861 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9862
9863         * gdbtypes.c (check_stub_method_group): Remove handling of old
9864         mangling schemes.
9865         * linespec.c (find_methods): Likewise.
9866         * stabsread.c (read_member_functions): Likewise.
9867         * valops.c (search_struct_method): Likewise.
9868         (value_struct_elt_for_reference): Likewise.
9869         * NEWS: Mention this change.
9870
9871 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9872
9873         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9874         print_source_lines.
9875         * source.c (print_source_lines_base): Update line number check.
9876         (print_source_lines): New function.
9877         (source_lines_range::source_lines_range): New function.
9878         * source.h (class source_lines_range): New class.
9879         (print_source_lines): New declaration.
9880
9881 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9882
9883         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9884
9885 2019-01-08  Tom Tromey  <tom@tromey.com>
9886             Simon Marchi  <simon.marchi@ericsson.com>
9887
9888         PR gdb/24060
9889         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9890         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9891         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9892         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9893         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9894         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9895
9896 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9897
9898         * source.c (select_source_symtab): Move header comment to
9899         declaration in source.h.
9900         (forget_cached_source_info_for_objfile): Likewise.
9901         (forget_cached_source_info): Likewise.
9902         (identify_source_line): Likewise.
9903         * source.h (identify_source_line): Move declaration from symtab.h
9904         and add comment from source.c
9905         (print_source_lines): Likewise.
9906         (forget_cached_source_info_for_objfile): Likewise.
9907         (forget_cached_source_info): Likewise.
9908         (select_source_symtab): Likewise.
9909         (enum print_source_lines_flag): Move definition from symtab.h.
9910         * symtab.h (identify_source_line): Move declaration to source.h.
9911         (print_source_lines): Likewise.
9912         (forget_cached_source_info_for_objfile): Likewise.
9913         (forget_cached_source_info): Likewise.
9914         (select_source_symtab): Likewise.
9915         (enum print_source_lines_flag): Move definition to source.h.
9916         * tui/tui-hooks.c: Add 'source.h' include.
9917
9918 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9919
9920         * source.c (print_source_lines_base): Handle requests to print
9921         reverse line number sequences, and guard against empty lines
9922         string.
9923
9924 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9925
9926         * source.c (print_source_lines_base): Fix skip of '\r' if next
9927         character is '\n'.
9928
9929 2019-01-06  Tom Tromey  <tom@tromey.com>
9930
9931         * c-exp.y (struct c_parse_state) <macro_original_text,
9932         expansion_obstack>: New member.
9933         (macro_original_text, expansion_obstack): Remove globals.
9934         (scan_macro_expansion, scanning_macro_expansion)
9935         (finished_macro_expansion): Update.
9936         (scan_macro_cleanup): Remove.
9937         (yylex, c_parse): Update.
9938
9939 2019-01-06  Tom Tromey  <tom@tromey.com>
9940
9941         * c-exp.y (struct c_parse_state) <strings>: New member.
9942         (operator_stoken): Update.
9943
9944 2019-01-06  Tom Tromey  <tom@tromey.com>
9945
9946         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9947         (union type_stack_elt) <typelist_val>: Now a pointer to
9948         std::vector.
9949         (type_stack_cleanup): Don't declare.
9950         (push_typelist): Update.
9951         * parse.c (pop_typelist): Return a std::vector.
9952         (push_typelist): Take a std::vector.
9953         (follow_types): Update.  Do not free args.
9954         (type_stack_cleanup): Remove.
9955         * c-exp.y (struct c_parse_state): New.
9956         (cpstate): New global.
9957         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9958         (nonempty_typelist): Update.
9959         (func_mod): Create a new vector.
9960         (c_parse): Create a c_parse_state.
9961         (check_parameter_typelist): Do not delete params.
9962         (function_method): Update.  Do not delete type_list.
9963
9964 2019-01-06  Tom Tromey  <tom@tromey.com>
9965
9966         PR gdb/28155:
9967         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9968         check_typedef.
9969         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9970         (print_return_value): Likewise.
9971
9972 2019-01-05  Tom Tromey  <tom@tromey.com>
9973
9974         * contrib/cleanup_check.py: Remove.
9975         * contrib/gcc-with-excheck: Remove.
9976         * contrib/exsummary.py: Remove.
9977         * contrib/excheck.py: Remove.
9978
9979 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9980
9981         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9982         NULL. Initialize tpprev to NULL instead of assigning it
9983         to NULL on the next statement.
9984         * windows-nat.c (windows_delete_thread): Remove check for
9985         main_thread_id before printing thread exit notifications.
9986         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9987         Remove thread ID check against main_thread_id.
9988         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9989         windows_delete_thread.
9990         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9991
9992 2019-01-04  Tom Tromey  <tom@tromey.com>
9993
9994         * compile/compile.c (_initialize_compile): Use upper case for
9995         metasyntactic variables.
9996         * symmisc.c (_initialize_symmisc): Use upper case for
9997         metasyntactic variables.
9998         * psymtab.c (_initialize_psymtab): Use upper case for
9999         metasyntactic variables.
10000         * demangle.c (demangle_command): Use upper case for metasyntactic
10001         variables.
10002         (_initialize_demangler): Likewise.
10003         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10004         variables.
10005
10006 2019-01-03  Tom Tromey  <tom@tromey.com>
10007
10008         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10009
10010 2019-01-03  Tom Tromey  <tom@tromey.com>
10011
10012         * python/py-symtab.c (salpy_str): Update.
10013         (struct salpy_sal_object) <symtab>: Now a PyObject.
10014         (salpy_dealloc): Update.
10015         (del_objfile_sal): Use gdbpy_ref.
10016
10017 2019-01-03  Tom Tromey  <tom@tromey.com>
10018
10019         * python/py-type.c (convert_field): Use new_reference.  Return
10020         gdbpy_ref.
10021         (make_fielditem): Return gdbpy_ref.
10022         (typy_fields): Update.
10023         (typy_getitem): Update.
10024         (field_name): Return gdbpy_ref.  Use new_reference.
10025         (typy_iterator_iternext): Update.
10026
10027 2019-01-03  Tom Tromey  <tom@tromey.com>
10028
10029         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10030
10031 2019-01-03  Tom Tromey  <tom@tromey.com>
10032
10033         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10034         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10035         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10036         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10037         (pspy_set_type_printers): Likewise.
10038         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10039         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10040         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10041         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10042         (objfpy_set_type_printers): Likewise.
10043
10044 2019-01-03  Tom Tromey  <tom@tromey.com>
10045
10046         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10047         (gdbpy_print_stack): Use gdbpy_err_fetch.
10048         * python/python-internal.h (class gdbpy_err_fetch): New class.
10049         (class gdbpy_enter) <m_error_type, m_error_value,
10050         m_error_traceback>: Remove.
10051         <m_error>: New member.
10052         (gdbpy_exception_to_string): Don't declare.
10053         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10054         * python/py-value.c (convert_value_from_python): Use
10055         gdbpy_err_fetch.
10056         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10057         gdbpy_exception_to_string.
10058         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10059         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10060         gdbpy_err_fetch.
10061
10062 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10063
10064         * linux-nat.c (delete_lwp_cleanup): Delete.
10065         (struct lwp_deleter): New struct.
10066         (lwp_info_up): New typedef.
10067         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10068         lwp_info_up.
10069
10070 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10071
10072         * linux-fork.c (class scoped_switch_fork_info): New class.
10073         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10074
10075 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10076
10077         * valops.c (find_overload_match): Remove use of null_cleanup, and
10078         calls to do_cleanups.
10079
10080 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10081
10082         * compile/compile-cplus-types.c
10083         (compile_cplus_instance::decl_name): Handle changes to
10084         cp_func_name.
10085         * cp-support.c (cp_func_name): Update header comment, update
10086         return type.
10087         * cp-support.h (cp_func_name): Update return type in declaration.
10088         * valops.c (find_overload_match): Move temp_func local to top
10089         level of function and change its type.  Use temp_func to hold and
10090         delete temporary string obtained from cp_func_name.
10091
10092 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10093
10094         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10095         gdb::char_vector, remove cleanup, and update uses of `msg`.
10096
10097 2019-01-03  Jim Wilson  <jimw@sifive.com>
10098
10099         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10100
10101 2019-01-02  Tom Tromey  <tom@tromey.com>
10102
10103         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10104         (tdesc_parse_xml): Remove cleanups.
10105         * target-descriptions.h (make_cleanup_free_target_description):
10106         Don't declare.
10107         (target_desc_deleter): New struct.
10108         (target_desc_up): New typedef.
10109         * target-descriptions.c (target_desc_deleter::operator()): Rename
10110         from free_target_description.
10111         (make_cleanup_free_target_description): Remove.
10112
10113 2019-01-02  Tom Tromey  <tom@tromey.com>
10114
10115         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10116         constructor, destructor.
10117         (linespec_parser): Remove typedef.
10118         (~linespec_parser): Rename from linespec_parser_delete.
10119         (linespec_lex_to_end, linespec_complete_label)
10120         (linespec_complete): Update.
10121         (decode_line_full): Remove cleanups.
10122         (decode_line_1): Update.
10123
10124 2019-01-02  Tom Tromey  <tom@tromey.com>
10125
10126         * python/python-internal.h (inferior_to_inferior_object): Change
10127         return type.
10128         * python/py-exitedevent.c (create_exited_event_object): Update.
10129         * python/py-inferior.c (inferior_to_inferior_object): Return
10130         gdbpy_ref.
10131         (python_new_inferior, python_inferior_deleted)
10132         (thread_to_thread_object, delete_thread_object)
10133         (build_inferior_list, gdbpy_selected_inferior): Update.
10134         * python/py-infthread.c (create_thread_object): Update.  Also fail
10135         if inferior_to_inferior_object fails.
10136
10137 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10138
10139         * inferior.h (class inferior) <displaced_step_state>: New field.
10140         * infrun.h (struct displaced_step_state): Move here from
10141         infrun.c.  Initialize fields, add constructor.
10142         <inf>: Remove field.
10143         <reset>: New method.
10144         * infrun.c (struct displaced_step_inferior_state): Move to
10145         infrun.h.
10146         (displaced_step_inferior_states): Remove.
10147         (get_displaced_stepping_state): Adust.
10148         (displaced_step_in_progress_any_inferior): Adjust.
10149         (displaced_step_in_progress_thread): Adjust.
10150         (displaced_step_in_progress): Adjust.
10151         (add_displaced_stepping_state): Remove.
10152         (get_displaced_step_closure_by_addr): Adjust.
10153         (remove_displaced_stepping_state): Remove.
10154         (infrun_inferior_exit): Call displaced_step_state.reset.
10155         (use_displaced_stepping): Don't check for NULL.
10156         (displaced_step_prepare_throw): Call
10157         get_displaced_stepping_state.
10158         (displaced_step_fixup): Don't check for NULL.
10159         (prepare_for_detach): Don't check for NULL.
10160
10161 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10162
10163         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10164          in case of call that did not complete.
10165
10166 2019-01-02  Andrey Utkin  <autkin@undo.io>
10167
10168         * symfile.c (find_separate_debug_file): Fix search of debug files for
10169         remote debuggee.
10170
10171 2019-01-02  Tom Tromey  <tom@tromey.com>
10172
10173         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10174         indentation.
10175         * python/py-frame.c (frapy_older): Remove cast.
10176         (frapy_newer): Likewise.
10177         * python/py-breakpoint.c (local_setattro): Remove cast.
10178         * python/py-arch.c (archpy_name): Remove local variable.
10179         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10180
10181 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10182
10183         * unittests/basic_string_view/element_access/char/empty.cc:
10184         Fix year range in copyright header.
10185
10186 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10187
10188         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10189         Delete.
10190         <operator==>: Update with for removed field.
10191         <hash>: Likewise.
10192         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10193         <isa_features>: ...this.
10194         <abi_features>: New field.
10195         (riscv_isa_flen): Update comment.
10196         (riscv_abi_xlen): New declaration.
10197         (riscv_abi_flen): New declaration.
10198         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10199         isa_features.
10200         (riscv_abi_xlen): New function.
10201         (riscv_isa_flen): Update to get answer from isa_features.
10202         (riscv_abi_flen): New function.
10203         (riscv_has_fp_abi): Update to get answer from abi_features.
10204         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10205         xlen and flen.
10206         (riscv_call_info) <xlen, flen>: Update comment.
10207         (riscv_call_arg_struct): Remove invalid assertions
10208         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10209         is removed.
10210         (riscv_gdbarch_init): Gather isa features and abi features
10211         separately, ensure both match on the gdbarch when reusing an old
10212         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10213         a target with 64-bit float hardware.
10214
10215 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10216
10217         * source.c (search_command_helper): Stop reverse search
10218         when line 1 has been searched.
10219
10220 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10221
10222         * record-full.c (record_full_base_target::close): Rewrite
10223         record_full_core_buf_list free logic.
10224
10225 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10226
10227         * break-catch-syscall.c (print_one_catch_syscall): xfree
10228         the last text.
10229
10230 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10231
10232         * top.c (print_gdb_version): Update Copyright year in version
10233         message.
10234
10235 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10236
10237         Update copyright year range in all GDB files.
10238
10239 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10240
10241         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10242
10243 For older changes see ChangeLog-2018.
10244 \f
10245 Local Variables:
10246 mode: change-log
10247 left-margin: 8
10248 fill-column: 74
10249 version-control: never
10250 coding: utf-8
10251 End:
10252