gdb/ChangeLog

   1 2019-08-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
   4
   5 2019-08-20  Tom Tromey  <tom@tromey.com>
   6
   7         * tui/tui-source.h (struct tui_source_window): Update.
   8         * tui/tui-regs.c (tui_show_registers): Update.
   9         * tui/tui-disasm.h (struct tui_disasm_window): Update.
  10         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
  11         (NO_REGS_STRING): Remove defines.
  12
  13 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
  14
  15         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
  16         unnecessary thread walk if remote doesn't support the packet.
  17
  18 2019-08-19  Tom Tromey  <tromey@adacore.com>
  19
  20         * python/py-value.c (value_has_field): Fix indentation.
  21
  22 2019-08-19  Tom Tromey  <tromey@adacore.com>
  23
  24         * printcmd.c (do_one_display, info_display_command): Update.
  25         * block.h (contained_in): Return bool.  Add allow_nested
  26         parameter.
  27         * block.c (contained_in): Return bool.  Add allow_nested
  28         parameter.
  29
  30 2019-08-19  Tom Tromey  <tom@tromey.com>
  31
  32         * configure: Rebuild.
  33         * configure.ac: Disallow the combination of -static-libstdc++ and
  34         source highlight.
  35         * source-cache.c (get_language_name): Handle rust.
  36         (source_cache::get_source_lines): Ignore highlighting exceptions.
  37
  38 2019-08-16  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
  41         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
  42         (struct tui_source_window_base) <make_visible, refresh_window,
  43         resize>: Remove methods.
  44         <execution_info>: Remove field.
  45         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
  46         (tui_show_source_line, tui_source_window_base)
  47         (~tui_source_window_base): Update.
  48         (tui_source_window_base::resize)
  49         (tui_source_window_base::make_visible)
  50         (tui_source_window_base::refresh_window): Remove.
  51         (tui_source_window_base::update_exec_info): Update.
  52         * tui/tui-source.c (tui_source_window::set_contents): Update.
  53         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  54
  55 2019-08-16  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-hooks.c (tui_remove_hooks): Don't set
  58         deprecated_query_hook.
  59
  60 2019-08-16  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  63         (tui_update_source_windows_with_line): Update.
  64         * tui/tui-source.h (struct tui_source_window)
  65         <show_symtab_source>: Declare.
  66         (tui_show_symtab_source): Don't declare.
  67         * tui/tui-source.c (tui_show_symtab_source): Rename from
  68         tui_show_symtab_source.
  69
  70 2019-08-16  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-winsource.h (struct tui_source_window_base)
  73         <set_contents>: Declare.
  74         * tui/tui-winsource.c
  75         (tui_source_window_base::update_source_window_as_is): Update.
  76         * tui/tui-source.h (struct tui_source_window) <set_contents>:
  77         Declare.
  78         (tui_set_source_content): Don't declare.
  79         * tui/tui-source.c (tui_source_window::set_contents): Rename from
  80         tui_set_source_content.
  81         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  82         Declare.
  83         (tui_set_disassem_content): Don't declare.
  84         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
  85         tui_set_disassem_content.
  86
  87 2019-08-16  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-winsource.h (struct tui_source_window_base)
  90         <update_breakpoint_info>: Declare.
  91         (tui_update_breakpoint_info): Don't declare.
  92         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
  93         (tui_update_all_breakpoint_info): Update.
  94         (tui_source_window_base::update_breakpoint_info): Rename from
  95         tui_update_breakpoint_info.
  96         (tui_source_window_base::update_exec_info): Update.
  97
  98 2019-08-16  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-winsource.h (struct tui_source_window_base)
 101         <update_source_window>: Declare.
 102         (tui_update_source_window): Don't declare.
 103         * tui/tui-winsource.c
 104         (tui_source_window_base::update_source_window): Rename from
 105         tui_update_source_window.
 106         (tui_source_window_base::rerender): Update.
 107         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 108         * tui/tui-disasm.c (tui_show_disassem)
 109         (tui_show_disassem_and_update_source)
 110         (tui_disasm_window::maybe_update): Update.
 111
 112 2019-08-16  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-winsource.h (struct tui_source_window_base)
 115         <update_source_window_as_is>: Declare.
 116         (tui_update_source_window_as_is): Don't declare.
 117         * tui/tui-winsource.c (tui_update_source_window): Update
 118         (tui_source_window_base::update_source_window_as_is): Rename from
 119         tui_update_source_window_as_is.
 120         (tui_source_window_base::refill): Update.
 121         * tui/tui-source.c (tui_show_symtab_source): Update.
 122         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 123         Update.
 124
 125 2019-08-16  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui-winsource.h (tui_update_source_window)
 128         (tui_update_source_window_as_is): Remove "noerror" parameter.
 129         * tui/tui-winsource.c (tui_update_source_window)
 130         (tui_update_source_window_as_is): Remove "noerror" parameter.
 131         (tui_update_source_windows_with_addr)
 132         (tui_update_source_windows_with_line)
 133         (tui_source_window_base::rerender)
 134         (tui_source_window_base::refill): Update.
 135         * tui/tui-source.h (tui_set_source_content)
 136         (tui_show_symtab_source): Remove "noerror" parameter.
 137         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 138         parameter.
 139         (tui_show_symtab_source): Likewise.
 140         (tui_source_window::maybe_update): Update.
 141         * tui/tui-disasm.c (tui_show_disassem)
 142         (tui_show_disassem_and_update_source)
 143         (tui_disasm_window::do_scroll_vertical)
 144         (tui_disasm_window::maybe_update): Update.
 145
 146 2019-08-16  Tom Tromey  <tom@tromey.com>
 147
 148         * tui/tui.c (tui_is_window_visible): Update.
 149         * tui/tui-wingeneral.c (tui_make_window)
 150         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 151         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 152         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 153         (tui_set_win_height_command, parse_scrolling_args): Update.
 154         * tui/tui-source.c (tui_source_window::style_changed): Update.
 155         * tui/tui-regs.c (tui_show_registers)
 156         (tui_data_window::first_data_item_displayed)
 157         (tui_data_window::delete_data_content_windows)
 158         (tui_check_register_values, tui_reg_command): Update.
 159         * tui/tui-disasm.c (tui_show_disassem): Update.
 160         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 161         method.
 162         <is_visible>: Remove field.
 163         * tui/tui-data.c (tui_next_win, tui_prev_win)
 164         (tui_delete_invisible_windows): Update.
 165
 166 2019-08-16  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-winsource.h (struct tui_source_window_base)
 169         <m_has_locator>: Remove.
 170         * tui/tui-layout.c (show_source_disasm_command, show_data)
 171         (show_source_or_disasm_and_command): Update.
 172
 173 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 174
 175         * NEWS (Other MI changes): New subsection.
 176         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 177         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 178         * arch-utils.c (default_get_pc_address_flags): New function.
 179         * arch-utils.h (default_get_pc_address_flags): New declaration.
 180         * gdbarch.sh: Add get_pc_address_flags.
 181         * gdbarch.c: Regenerate.
 182         * gdbarch.h: Likewise.
 183         * stack.c (print_pc): New function.
 184         (print_frame_info) (print_frame): Call print_pc.
 185
 186 2019-08-16  Tom de Vries  <tdevries@suse.de>
 187
 188         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 189         print_objfile_section_info.
 190
 191 2019-08-15  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 194         calling update_cmdwin_start_line.
 195         * tui/tui-winsource.h (struct tui_source_window_base)
 196         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 197         <rerender>: Declare.
 198         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 199         Call rerender.
 200         (tui_source_window_base::set_new_height): Remove.
 201         (tui_source_window_base::rerender): Rename from
 202         do_make_visible_with_new_height.
 203         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 204         resize method.
 205         (tui_win_info::make_invisible_and_set_new_height)
 206         (tui_win_info::make_visible_with_new_height): Remove.
 207         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 208         Declare.
 209         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 210         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 211         do_make_visible_with_new_height>: Don't declare.
 212         <rerender>: Declare.
 213         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 214         set_new_height.
 215         (tui_data_window::do_make_visible_with_new_height): Remove.
 216         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 217         call tui_show_locator_content.
 218         (tui_gen_win_info::resize): Call rerender.
 219         (show_source_or_disasm_and_command): Don't call
 220         tui_show_locator_content.
 221         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 222         method.
 223         (struct tui_win_info) <rerender>: Declare.
 224         <set_new_height, make_invisible_and_set_new_height,
 225         make_visible_with_new_height>: Don't declare.
 226         * tui/tui-data.c (tui_win_list::rerender): New method.
 227         * tui/tui-command.h (struct tui_cmd_window)
 228         <do_make_visible_with_new_height>: Don't declare.
 229         * tui/tui-command.c
 230         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 231
 232 2019-08-15  Tom Tromey  <tromey@adacore.com>
 233
 234         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 235         * ada-lang.c (ada_enum_name): Likewise.
 236
 237 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 238
 239         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 240         leading underscore.
 241         (GdbOutputErrorFile): Likewise.
 242         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 243         accordingly.
 244         (execute_unwinders): Rename to have a leading underscore.
 245         (auto_load_packages): Likewise.
 246         (global scope): Adjust call to auto_load_packages accordingly.
 247         (GdbSetPythonDirectory): Likewise.
 248         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 249         instead of execute_unwinders.
 250
 251 2019-08-15  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 254         (show_data): Don't change window visibility.
 255         (tui_gen_win_info::resize): Remove special case for command
 256         window.  Use wresize, when available.
 257         (show_source_or_disasm_and_command): Don't change window
 258         visibility.
 259         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 260         <make_visible>: New method.
 261         * tui/tui-command.c (tui_cmd_window::resize): New method.
 262
 263 2019-08-15  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 266         (struct tui_source_windows): New.
 267         * tui/tui-winsource.c (tui_display_main): Update.
 268         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 269         (new_height_ok, parse_scrolling_args): Update.
 270         * tui/tui-layout.c (show_layout, show_data): Update.
 271         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 272         (tui_add_to_source_windows): Don't declare.
 273         * tui/tui-data.c (source_windows, tui_source_windows)
 274         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 275
 276 2019-08-15  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 279         Rename from reset.
 280         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 281         * tui/tui-layout.c (show_source_disasm_command, show_data):
 282         Update.
 283         (tui_gen_win_info::resize): Rename.
 284         (show_source_or_disasm_and_command): Update.
 285         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 286         reset.
 287
 288 2019-08-15  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 291         * tui/tui-interp.c (tui_interp::init): Don't call
 292         tui_initialize_static_data.
 293         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 294
 295 2019-08-15  Tom Tromey  <tom@tromey.com>
 296
 297         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 298         examine tui_win_list.
 299
 300 2019-08-15  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 303         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 304         tui_clear_source_content.
 305         (tui_clear_source_content): Remove.
 306         (tui_source_window_base::do_erase_source_content): Hoist call to
 307         content.clear().
 308         * tui/tui-stack.c (tui_show_frame_info): Don't call
 309         tui_clear_source_content.
 310
 311 2019-08-15  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-winsource.h (struct tui_source_window_base)
 314         <do_erase_source_content>: New method.
 315         <erase_source_content>: New method.
 316         (tui_erase_source_content): Don't declare.
 317         * tui/tui-winsource.c (tui_clear_source_content): Update.
 318         (tui_source_window_base::do_erase_source_content): Rename from
 319         tui_erase_source_content.
 320         (tui_source_window_base::show_source_content): Update.
 321         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 322         * tui/tui-source.h (struct tui_source_window)
 323         <erase_source_content>: New method.
 324         * tui/tui-disasm.h (struct tui_disasm_window)
 325         <erase_source_content>: New method.
 326
 327 2019-08-15  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 330         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 331         constructor.
 332         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 333         * tui/tui-source.c (tui_set_source_content): Update.
 334         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 335
 336 2019-08-15  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 339         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 340         tui-source.c.
 341         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 342         Declare.
 343         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 344         method.
 345         (tui_source_window::maybe_update): Update.
 346
 347 2019-08-15  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 350         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 351         tui-disasm.c.
 352         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 353         Declare.
 354         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 355         method.
 356         (tui_disasm_window::maybe_update): Update.
 357
 358 2019-08-15  Tom Tromey  <tom@tromey.com>
 359
 360         * tui/tui-winsource.h (struct tui_source_window_base)
 361         <maybe_update>: Declare.
 362         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 363         method.
 364         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 365         Declare.
 366         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 367         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 368         Declare.
 369         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 370
 371 2019-08-15  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 374
 375 2019-08-15  Tom Tromey  <tom@tromey.com>
 376
 377         * tui/tui-wingeneral.c: Include tui-stack.h.
 378         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 379         (struct tui_locator_window): Move from tui-data.h.
 380         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 381         (tui_initialize_static_data): Move from tui-data.c.
 382         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 383         (struct tui_locator_window): Move to tui-stack.c.
 384         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 385         (tui_initialize_static_data): Move to tui-stack.c.
 386
 387 2019-08-15  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui-layout.c (show_source_disasm_command)
 390         (show_source_or_disasm_and_command): Use make_visible method, not
 391         tui_make_window.
 392         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 393         Remove.
 394
 395 2019-08-15  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-wingeneral.h (tui_make_window): Update.
 398         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 399         parameter.
 400         (tui_gen_win_info::make_visible): Update.
 401         * tui/tui-regs.c (tui_data_window::display_registers_from):
 402         Update.
 403         * tui/tui-layout.c (show_source_disasm_command)
 404         (show_source_or_disasm_and_command): Update.
 405         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 406         (enum tui_box): Remove.
 407         (struct tui_win_info) <can_box>: New method.
 408         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 409         method.
 410
 411 2019-08-15  Tom de Vries  <tdevries@suse.de>
 412
 413         * linux-nat-trad.c: Include gdbarch.h.
 414
 415 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 416
 417         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 418         register sizes.
 419
 420 2019-08-14  Tom Tromey  <tromey@adacore.com>
 421
 422         * darwin-nat.c: Include gdbarch.h.
 423         * darwin-nat-info.c: Include gdbarch.h.
 424
 425 2019-08-13  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 428         Remove.
 429         * tui/tui-data.c (tui_initialize_static_data): Update.
 430
 431 2019-08-13  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui-winsource.h (struct tui_exec_info_window)
 434         <~tui_exec_info_window, maybe_allocate_content, get_content,
 435         m_content>: Remove.
 436         (struct tui_source_window_base) <set_exec_info_content,
 437         show_exec_info_content>: Don't declare.
 438         * tui/tui-winsource.c
 439         (tui_exec_info_window::maybe_allocate_content): Remove.
 440         (tui_source_window_base::update_exec_info): Rename from
 441         set_exec_info_content.
 442         (tui_source_window_base::show_exec_info_content)
 443         (tui_source_window_base::update_exec_info): Remove.
 444
 445 2019-08-13  Tom Tromey  <tom@tromey.com>
 446
 447         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 448         declare.
 449         * tui/tui-winsource.c (tui_update_source_window_as_is)
 450         (tui_update_source_windows_with_addr, tui_erase_source_content):
 451         Update.
 452         (tui_clear_exec_info_content): Remove.
 453
 454 2019-08-13  Tom Tromey  <tom@tromey.com>
 455
 456         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 457         declare.
 458         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 459         call tui_erase_exec_info_content.
 460         (tui_clear_exec_info_content): Rename from
 461         tui_erase_exec_info_content.
 462         (tui_clear_exec_info_content): Delete.
 463
 464 2019-08-13  Tom Tromey  <tom@tromey.com>
 465
 466         * tui/tui-winsource.h (struct tui_source_window_base)
 467         <show_exec_info_content>: Declare.
 468         (tui_show_exec_info_content): Don't declare.
 469         * tui/tui-winsource.c
 470         (tui_source_window_base::show_exec_info_content): Rename from
 471         tui_show_exec_info_content.
 472         (tui_source_window_base::update_exec_info): Update.
 473
 474 2019-08-13  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 477         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 478         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 479         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 480         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 481         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 482         ... here.
 483
 484 2019-08-13  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-winsource.h (struct tui_source_window_base)
 487         <update_exec_info>: Declare.
 488         (tui_update_exec_info): Don't declare.
 489         * tui/tui-winsource.c (tui_update_source_window_as_is)
 490         (tui_source_window_base::refresh_all)
 491         (tui_update_all_breakpoint_info): Update.
 492         (tui_source_window_base::update_exec_info): Rename from
 493         tui_update_exec_info.
 494         * tui/tui-stack.c (tui_show_frame_info): Update.
 495
 496 2019-08-13  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-winsource.h (struct tui_source_window_base)
 499         <set_exec_info_content>: Declare.
 500         (tui_set_exec_info_content): Don't declare.
 501         * tui/tui-winsource.c
 502         (tui_source_window_base::set_exec_info_content): Rename from
 503         tui_set_exec_info_content.
 504         (tui_update_exec_info): Update.
 505
 506 2019-08-13  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-winsource.h (struct tui_source_window_base)
 509         <show_source_content>: Declare.
 510         (tui_show_source_content): Don't declare.
 511         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 512         (tui_source_window_base::show_source_content): Rename from
 513         tui_show_source_content.
 514         (tui_source_window_base::refresh_all): Update.
 515         * tui/tui-layout.c (show_source_disasm_command)
 516         (show_source_or_disasm_and_command): Update.
 517
 518 2019-08-13  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-winsource.c (tui_erase_source_content)
 521         (tui_show_source_content, tui_source_window_base::refresh_all):
 522         Update.
 523         * tui/tui-wingeneral.h
 524         (tui_check_and_display_highlight_if_needed): Don't declare.
 525         * tui/tui-wingeneral.c
 526         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 527         check_and_display_highlight_if_needed.
 528         * tui/tui-win.c (tui_rehighlight_all)
 529         (tui_win_info::make_visible_with_new_height): Update.
 530         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 531         (tui_data_window::erase_data_content)
 532         (tui_data_window::display_all_data): Update.
 533         * tui/tui-data.h (struct tui_win_info)
 534         <check_and_display_highlight_if_needed>: Declare.
 535
 536 2019-08-13  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-win.c (tui_resize_all): Call
 539         tui_delete_invisible_windows.
 540         * tui/tui-layout.c (show_layout): Call
 541         tui_delete_invisible_windows.
 542         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 543         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 544
 545 2019-08-13  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 548         tui_add_win_to_layout.
 549
 550 2019-08-13  Tom Tromey  <tom@tromey.com>
 551
 552         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 553         * tui/tui-layout.c (tui_default_win_height): Now static.
 554
 555 2019-08-13  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 558         single switch.
 559         (show_source_disasm_command, show_source_or_disasm_and_command):
 560         Don't check current layout.
 561
 562 2019-08-13  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-wingeneral.c (make_all_visible): Remove.
 565         (tui_make_all_invisible): Simplify.
 566         * tui/tui-layout.c (tui_make_all_invisible): Move from
 567         tui-wingeneral.c; simplify.
 568         (show_layout): Hoist call to tui_make_all_invisible.
 569         (show_data): Don't call tui_make_all_invisible.
 570
 571 2019-08-13  Tom Tromey  <tom@tromey.com>
 572
 573         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 574         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 575
 576 2019-08-13  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 579         tui-data.c.
 580         (show_source_disasm_command, show_data)
 581         (show_source_or_disasm_and_command): Don't use
 582         tui_set_current_layout_to.
 583         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 584         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 585         tui-layout.c.
 586         (tui_set_current_layout_to): Remove.
 587
 588 2019-08-13  Tom Tromey  <tom@tromey.com>
 589
 590         * tui/tui-layout.c (tui_set_layout): Update.
 591         * tui/tui-data.h (struct tui_layout_def): Remove.
 592         (tui_layout_def): Don't declare.
 593         * tui/tui-data.c (layout_def): Remove.
 594         (tui_layout_def): Remove.
 595
 596 2019-08-13  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-winsource.h (struct tui_source_window_base)
 599         <clear_detail>: No longer "override".
 600         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 601         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 602         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 603         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 604         Remove.
 605         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 606
 607 2019-08-13  Tom Tromey  <tromey@adacore.com>
 608
 609         * tracepoint.c: Don't include readline.h or history.h.
 610
 611 2019-08-12  Tom Tromey  <tom@tromey.com>
 612
 613         * configure: Rebuild.
 614         * configure.ac: Check for readline 7.
 615         * NEWS: Mention readline 7 requirement.
 616         * README: Update.
 617
 618 2019-08-12  Tom Tromey  <tom@tromey.com>
 619
 620         * mingw-hdep.c (gdb_select): Remove readline hack.
 621
 622 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 623
 624         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 625         when the function fails.
 626
 627 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 628
 629         * s390-tdep.c (s390_type_align): New function.
 630         (s390_gdbarch_init): Set it as type_align gdbarch method.
 631
 632 2019-08-09  Tom de Vries  <tdevries@suse.de>
 633
 634         PR gdb/24591
 635         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 636         pc_low with relocation offset.
 637
 638 2019-08-07  Tom Tromey  <tromey@adacore.com>
 639
 640         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 641         (print_frame_args): Update.
 642         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 643         Update.
 644         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 645         * frame.h (struct frame_arg): Add initializers.
 646         <error>: Now a unique_xmalloc_ptr.
 647
 648 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 649
 650         * NEWS: Expand the Pointer Authentication entry.
 651         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 652         (aarch64_frame_unmask_lr): ... to this.
 653         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 654         Call aarch64_frame_unmask_lr.
 655         * frame.c (struct frame_info): Add "masked" variable.
 656         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 657         (fprint_frame): Check for masked pc.
 658         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 659         declarations.
 660         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 661         * stack.c (print_frame): Check for masked pc.
 662
 663 2019-08-06  Tom Tromey  <tom@tromey.com>
 664
 665         * stabsread.c (patch_block_stabs, read_one_struct_field)
 666         (read_enum_type): Use obstack_strndup.
 667         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 668         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 669         * dwarf2read.c (guess_full_die_structure_name)
 670         (anonymous_struct_prefix): Use obstack_strndup.
 671         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 672         * c-exp.y (yylex): Use obstack_strndup.
 673         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 674         (write_var_or_type): Use obstack_strndup.
 675
 676 2019-08-06  Tom Tromey  <tom@tromey.com>
 677
 678         * symfile.c (reread_symbols): Use obstack_strdup.
 679         * stabsread.c (read_type): Use obstack_strdup.
 680         * gdb_obstack.h (obstack_strdup): New overload.
 681         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 682         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 683         (dwarf2_canonicalize_name): Use obstack_strdup.
 684         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 685         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 686         Use obstack_strdup.
 687
 688 2019-08-06  Tom Tromey  <tom@tromey.com>
 689
 690         * gdb_obstack.h (obstack_strdup): Define.
 691         * gdb_obstack.c (obstack_strdup): Don't define.
 692
 693 2019-08-06  Tom Tromey  <tom@tromey.com>
 694
 695         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 696         obstack_strdup.
 697         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 698         obstack_strdup.
 699         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 700         * stabsread.c (common_block_start): Use obstack_strdup.
 701         * objfiles.c (set_objfile_main_name, objfile): Use
 702         obstack_strdup.
 703         * namespace.c (add_using_directive): Use obstack_strdup.
 704         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 705         * jit.c (finalize_symtab): Use obstack_strdup.
 706         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 707         (guess_partial_die_structure_name, partial_die_info::fixup)
 708         (dwarf2_name): Use obstack_strdup.
 709         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 710         obstack_strdup.
 711         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 712         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 713         obstack_strdup.
 714         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 715
 716 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 717
 718         * unittests/help-doc-selftests.c: New file.
 719         * Makefile.in: Add the new file.
 720
 721 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 722
 723         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 724         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 725         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 726         the trailing '.' is not output, and the first character is uppercased.
 727         (print_help_for_command): Update call to print_doc_line.
 728         (print_doc_of_command): Likewise.
 729         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 730         * cli/cli-option.c (append_indented_doc): Do not append newline.
 731         (build_help_option): Append newline after first appended_indented_doc
 732         only if a second call is done.
 733         (build_help): Append 2 new lines before each option, except the first
 734         one.
 735         * compile/compile.c (_initialize_compile): Add new lines after
 736         %OPTIONS%, when not at the end of the help.
 737         Change help doc or code
 738         producing the help doc to respect the invariants.
 739         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 740         Also removed the new line after 'Options:', as all other commands
 741         do not put an empty line between 'Options:' and the first option.
 742         * printcmd.c (_initialize_printcmd): Likewise.
 743         * stack.c (_initialize_stack): Likewise.
 744         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 745         incorrectly telling COMMAND is optional.
 746         * ada-lang.c (_initialize_ada_language): Change help doc or code
 747         producing the help doc to respect the invariants.
 748         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 749         * breakpoint.c (_initialize_breakpoint): Likewise.
 750         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 751         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 752         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 753         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 754         _initialize_cli_style): Likewise.
 755         * corelow.c (core_target_info): Likewise.
 756         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 757         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 758         * filesystem.c (_initialize_filesystem): Likewise.
 759         * frame.c (_initialize_frame): Likewise.
 760         * gnu-nat.c (add_task_commands): Likewise.
 761         * infcall.c (_initialize_infcall): Likewise.
 762         * infcmd.c (_initialize_infcmd): Likewise.
 763         * interps.c (_initialize_interpreter): Likewise.
 764         * language.c (_initialize_language): Likewise.
 765         * linux-fork.c (_initialize_linux_fork): Likewise.
 766         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 767         * maint.c (_initialize_maint_cmds): Likewise.
 768         * memattr.c (_initialize_mem): Likewise.
 769         * printcmd.c (_initialize_printcmd): Likewise.
 770         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 771         _RegEx): Likewise.
 772         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 773         * record-btrace.c (_initialize_record_btrace): Likewise.
 774         * record-full.c (_initialize_record_full): Likewise.
 775         * record.c (_initialize_record): Likewise.
 776         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 777         * regcache.c (_initialize_regcache): Likewise.
 778         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 779         _initialize_remote): Likewise.
 780         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 781         * serial.c (_initialize_serial): Likewise.
 782         * skip.c (_initialize_step_skip): Likewise.
 783         * source.c (_initialize_source): Likewise.
 784         * stack.c (_initialize_stack): Likewise.
 785         * symfile.c (_initialize_symfile): Likewise.
 786         * symtab.c (_initialize_symtab): Likewise.
 787         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 788         * top.c (init_main): Likewise.
 789         * tracefile-tfile.c (tfile_target_info): Likewise.
 790         * tracepoint.c (_initialize_tracepoint): Likewise.
 791         * tui/tui-win.c (_initialize_tui_win): Likewise.
 792         * utils.c (add_internal_problem_command): Likewise.
 793         * valprint.c (value_print_option_defs): Likewise.
 794
 795 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 796
 797         PR build/24886
 798         * configure.ac: Drop enable-libmcheck support.
 799         * configure, config.in: Rebuild.
 800         * libmcheck.m4: Remove.
 801         * acinclude.m4: Don't include it.
 802         * Makefile.in: Don't distribute it.
 803         * top.c (print_gdb_configuration): Don't mention it.
 804
 805 2019-08-06  Tom Tromey  <tom@tromey.com>
 806
 807         * utils.c (set_output_style): Sometimes pass stream to
 808         emit_style_escape.
 809         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 810         * record-btrace.c (btrace_insn_history): Update.
 811         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 812         method.
 813         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 814         Update initializers.
 815         <m_uiout>: New field.
 816         <m_di>: Move lower.
 817         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 818         Remove "uiout" parameter.
 819         (dump_insns): Update.
 820         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 821         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 822
 823 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 824
 825         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 826         (error_in_psymtab_expansion): Likewise.
 827         (lookup_symbol_via_quick_fns): Likewise.
 828         (basic_lookup_transparent_type_quick): Likewise.
 829         (basic_lookup_transparent_type_1): Likewise.
 830
 831 2019-08-06  Tom Tromey  <tromey@adacore.com>
 832
 833         * source.c (last_source_error): Now bool.
 834         (print_source_lines_base): Make "noprint" bool.  Only open
 835         source file when last_source_visited changes.
 836
 837 2019-08-06  Tom Tromey  <tromey@adacore.com>
 838
 839         * annotate.c (annotate_source_line): Use g_source_cache.
 840         * source-cache.c (source_cache::get_plain_source_lines): Change
 841         parameters.  Populate m_offset_cache.
 842         (source_cache::ensure): New method.
 843         (source_cache::get_line_charpos): New method.
 844         (extract_lines): Move lower.  Change parameters.
 845         (source_cache::get_source_lines): Move lower.
 846         * source-cache.h (class source_cache): Update comment.
 847         <get_line_charpos>: New method.
 848         <get_source_lines>: Update comment.
 849         <clear>: Clear m_offset_cache.
 850         <get_plain_source_lines>: Change parameters.
 851         <ensure>: New method
 852         <m_offset_cache>: New member.
 853         * source.c (forget_cached_source_info_for_objfile): Update.
 854         (info_source_command): Use g_source_cache.
 855         (find_source_lines, open_source_file_with_line_charpos): Remove.
 856         (print_source_lines_base, search_command_helper): Use g_source_cache.
 857         * source.h (open_source_file_with_line_charpos): Don't declare.
 858         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 859         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 860         Use g_source_cache.
 861
 862 2019-08-06  Tom Tromey  <tromey@adacore.com>
 863
 864         * source-cache.c (source_cache::get_plain_source_lines):
 865         Remove "first_line" and "last_line" parameters.
 866         (source_cache::get_source_lines): Cache plain text.
 867         * source-cache.h (class source_cache)
 868         <get_plain_source_lines>: Update.
 869
 870 2019-08-06  Tom Tromey  <tromey@adacore.com>
 871
 872         * source-cache.c (extract_lines): No longer a method.
 873         Changed type of parameter.  Include final newline.
 874         (selftests::extract_lines_test): New function.
 875         (_initialize_source_cache): Likewise.
 876         * source-cache.h (class source_cache)
 877         <extract_lines>: Don't declare.
 878
 879 2019-08-06  Tom Tromey  <tromey@adacore.com>
 880
 881         * breakpoint.c (init_breakpoint_sal): Update.
 882         (breakpoint): Update.
 883         * breakpoint.h (struct breakpoint) <filter>: Now a
 884         unique_xmalloc_ptr.
 885
 886 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 887
 888         * NEWS: Mention dictionary access on blocks.
 889         * python/py-block.c (blpy_getitem): New function.
 890         (block_object_as_mapping): New struct.
 891         (block_object_type): Use new struct for tp_as_mapping field.
 892
 893 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 894
 895         * objfiles.h (objfile): Add a comment describing partial symbols.
 896
 897 2019-08-05  Tom Tromey  <tromey@adacore.com>
 898
 899         * compile/compile.c (_initialize_compile): Use _(), not N_().
 900         * thread.c (_initialize_thread): Use _(), not N_().
 901         * stack.c (_initialize_stack): Use _(), not N_().
 902         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 903
 904 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 905
 906         * dwarf2read.c (struct dw2_symtab_iterator):
 907         <want_specific_block>: Remove.
 908         <block_index>: Change type to gdb::optional.
 909         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 910         change type of BLOCK_INDEX parameter to gdb::optional.
 911         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 912         (dw2_lookup_symbol): Don't pass argument for
 913         WANT_SPECIFIC_BLOCK.
 914         (dw2_expand_symtabs_for_function): Don't pass argument for
 915         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 916         (class dw2_debug_names_iterator)
 917         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 918         parameter, change BLOCK_INDEX type to gdb::optional.
 919         <m_want_specific_block>: Remove.
 920         <m_block_index>: Change type to gdb::optional.
 921         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 922         gdb::optional.  Re-write in function of gdb::optional.
 923         (dw2_debug_names_lookup_symbol): Don't pass argument for
 924         WANT_SPECIFIC_BLOCK.
 925         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 926         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 927         BLOCK_INDEX.
 928
 929 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 930
 931         * NEWS: Mention changes to "info sources" command.
 932
 933 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 934
 935         * symtab.c (filename_partial_match_opts): New struct type.
 936         (struct output_source_filename_data): New members
 937         regexp, c_regexp, partial_match.
 938         (output_source_filename): Use new members to decide to print file.
 939         (info_sources_option_defs): New variable.
 940         (make_info_sources_options_def_group, print_info_sources_header,
 941         info_sources_command_completer):
 942         New functions.
 943         (info_sources_command): Read new optional arguments.
 944         (_initialize_symtab): Update info sources help.
 945
 946 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 947
 948         * ada-lang.c (exception_support_info_v0): Renamed from...
 949         (default_exception_support_info): ... this.  Create new
 950         definition for v1.
 951         (ada_has_this_exception_support): Look up catch_handlers_sym.
 952         (ada_exception_support_info_sniffer): Try v0 after default.
 953
 954 2019-08-01  Tom Tromey  <tromey@adacore.com>
 955
 956         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 957         gdbarch.h.
 958
 959 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 960
 961         * s12z-tdep.c: Fix include path for s12z-opc.h.
 962
 963 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 964
 965         * NEWS: Require GNU make 3.82.
 966
 967 2019-07-16  Tom Tromey  <tom@tromey.com>
 968
 969         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 970         declare.
 971
 972 2019-07-30  Tom Tromey  <tromey@adacore.com>
 973
 974         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 975
 976 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 977
 978         * printcmd.c (print_address_symbolic): Print negative offsets.
 979         (build_address_symbolic): Force signed arithmetic when computing
 980         offset.
 981
 982 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 983
 984         PR/24474: Add a function to lookup static variables.
 985         * NEWS: Mention this new function.
 986         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 987         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 988         * python/python.c (python_GdbMethods): Add new function.
 989
 990 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 991
 992         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 993         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 994         (objfpy_lookup_static_symbol): New function.
 995         (objfile_object_methods): Add new functions.
 996
 997 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 998
 999         * NEWS: Mention 'set|show print frame-info'.  Mention new
1000         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1001         backtrace argument.  Mention that python frame filtering code
1002         is now consistent with what 'backtrace' command prints.
1003
1004 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1005
1006         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1007         comments.
1008         (print_frame_info_auto, print_frame_info_source_line,
1009         print_frame_info_location, print_frame_info_source_and_location,
1010         print_frame_info_location_and_address, print_frame_info_short_location):
1011         New declarations.
1012         (struct frame_print_options): New member print_frame_info.
1013         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1014         * stack.h (get_user_print_what_frame_info): New declaration.
1015         (frame_show_address): New declaration.
1016         * stack.c (print_frame_arguments_choices): New value 'presence'.
1017         (print_frame_info_auto, print_frame_info_source_line,
1018         print_frame_info_location, print_frame_info_source_and_location,
1019         print_frame_info_location_and_address, print_frame_info_short_location,
1020         print_frame_info_choices, print_frame_info_print_what): New definitions.
1021         (print_frame_args): Only print dots for args if print frame-arguments
1022         is 'presence'.
1023         (frame_print_option_defs): New element for "frame-info".
1024         (get_user_print_what_frame_info): New function.
1025         (frame_show_address): Make non static.  Move comment to stack.h.
1026         (print_frame_info_to_print_what): New function.
1027         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1028         to decide what to print.
1029         (backtrace_command_1): Handle the new print_frame_arguments_presence
1030         value.
1031         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1032         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1033         (py_print_frame): In non-mi mode, use LOCATION as default for
1034         print_what, similarly to frame information printed directly by
1035         backtrace command. Handle frame-info user option in non MI mode.
1036
1037 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1038
1039         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1040         Add case for debugging 32-bit target on 64-bit host.  Revise
1041         comment.
1042
1043 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1044
1045         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1046         instead of find_function_entry_range_from_pc.
1047
1048 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1049
1050         * stack.c (find_frame_funname): Remove code which preferred
1051         minsym over symtab sym in "certain pathological cases".
1052
1053         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1054         parameter.  Change type of "do_demangle" to bool.
1055         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1056         Pass suitable "prefer_sym_over_minsym" flag to
1057         build_address_symbolic().  Don't output "+" for negative offsets.
1058         * printcmd.c (print_address_symbolic): Update invocation of
1059         build_address_symbolic to include a "prefer_sym_over_minsym"
1060         flag.
1061         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1062         Restrict cases in which use of minimal symbol is preferred to that
1063         of a found symbol.  Update comments.
1064
1065         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1066         for entry pc when entry pc is out of range for that FDE.
1067
1068 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1069
1070         PR gdb/24839:
1071         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1072         type.
1073
1074 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1075
1076         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1077         this function's Python signature.
1078
1079
1080 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1081
1082         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1083         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1084         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1085         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1086         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1087
1088
1089 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1090
1091         * h8300-tdep.c (h8300_register_name_common): New.
1092         h8300_register_name): Use h8300_register_name_common.
1093         (h8300s_register_name): Likewise.
1094         (h8300sx_register_name): Likewise.
1095         (h8300h_register_nam): New.
1096         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1097
1098
1099 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1100
1101         * arm-tdep.c (arm_skip_cmse_entry): New function.
1102         (arm_is_sgstubs_section): New function.
1103         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1104
1105 2019-07-22  Tom Tromey  <tom@tromey.com>
1106
1107         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1108         Don't self-assign.
1109
1110 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1113         type_print.
1114
1115 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1116
1117         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1118         so that GDB doesn't match any msymbols when searching in the
1119         TYPES_DOMAIN.
1120         (print_symbol_info): Print using typedef_print or type_print based
1121         on the type of the symbol.  Add updated FIXME comment moved from...
1122         (_initialize_symtab): ... move and update FIXME comment to above.
1123
1124 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * NEWS: Mention adding -q option to "info types".
1127         * symtab.c (struct info_types_options): New struct.
1128         (info_types_options_defs): New variable.
1129         (make_info_types_options_def_group): New function.
1130         (info_types_command): Use gdb::option framework to parse options.
1131         (info_types_command_completer): New function.
1132         (_initialize_symtab): Extend the help text on "info types" and
1133         register command completer.
1134
1135 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1136
1137         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1138         (lookup_symbol_in_objfile): Change int to block_enum and add a
1139         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1140
1141 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1142
1143         * MAINTAINERS (Write After Approval): Add self.
1144
1145 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1146
1147         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1148         instruction to the dummy code region.
1149
1150 2019-07-19  Tom Tromey  <tromey@adacore.com>
1151
1152         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1153         (ARGSUSED, PARAMS, __func__): Remove rules.
1154
1155 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1156
1157         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1158         * features/arm/arm-with-iwmmxt.c: Remove.
1159         * features/arm/arm-with-iwmmxt.xml: Remove.
1160         * features/arm/arm-with-m-fpa-layout.c: Remove.
1161         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1162         * features/arm/arm-with-m-vfp-d16.c: Remove.
1163         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1164         * features/arm/arm-with-m.c: Remove.
1165         * features/arm/arm-with-m.xml: Remove.
1166         * features/arm/arm-with-neon.c: Remove.
1167         * features/arm/arm-with-neon.xml: Remove.
1168         * features/arm/arm-with-vfpv2.c: Remove.
1169         * features/arm/arm-with-vfpv2.xml: Remove.
1170         * features/arm/arm-with-vfpv3.c: Remove.
1171         * features/arm/arm-with-vfpv3.xml: Remove.
1172
1173 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1174
1175         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1176
1177 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1178
1179         * arch/aarch32.c (aarch32_create_target_description): Create
1180         target descriptions using features.
1181         * arch/arm.c (arm_create_target_description)
1182         (arm_create_mprofile_target_description): Likewise.
1183         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1184
1185 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1186
1187         * Makefile.in: Add new files.
1188         * aarch32-tdep.c: New file.
1189         * aarch32-tdep.h: New file.
1190         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1191         Call aarch32_read_description.
1192         * arch/aarch32.c: New file.
1193         * arch/aarch32.h: New file.
1194         * arch/arm.c (arm_create_target_description)
1195         (arm_create_mprofile_target_description): New function.
1196         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1197         (arm_create_target_description)
1198         (arm_create_mprofile_target_description): New declaration.
1199         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1200         read_description functions.
1201         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1202         Likewise.
1203         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1204         * arm-tdep.c (tdesc_arm_list): New variable.
1205         (arm_register_g_packet_guesses): Call create description functions.
1206         (arm_read_description) (arm_read_mprofile_description): New
1207         function.
1208         * arm-tdep.h (arm_read_description)
1209         (arm_read_mprofile_description): Add declaration.
1210         * configure.tgt: Add new files.
1211
1212 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1213
1214         * top.c (new_ui_command): Open specified terminal just once.
1215
1216 2019-07-18  Tom Tromey  <tromey@adacore.com>
1217
1218         * symtab.c (main_name): Constify return type.
1219         * symfile.c (set_initial_language): Update.
1220         * symtab.h (main_name): Constify return type.
1221
1222 2019-07-17  Tom Tromey  <tom@tromey.com>
1223
1224         * tui/tui-winsource.c (tui_update_source_window)
1225         (tui_update_source_window_as_is)
1226         (tui_update_source_windows_with_line): Remove return.
1227         * tui/tui-disasm.c (tui_show_disassem)
1228         (tui_show_disassem_and_update_source): Remove return.
1229         * tui/tui.c (tui_reset): Remove return.
1230         * tui/tui-wingeneral.c
1231         (tui_check_and_display_highlight_if_needed): Remove return.
1232
1233 2019-07-17  Tom Tromey  <tom@tromey.com>
1234
1235         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1236
1237 2019-07-17  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui-winsource.h (struct tui_exec_info_window)
1240         (struct tui_source_window_base): Move from tui-data.h.
1241         * tui/tui-winsource.c: Move many method definitions from
1242         elsewhere.  Remove "structuring" comments.
1243         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1244         (tui_source_window_base::refresh_window): Move to
1245         tui-winsource.c.
1246         * tui/tui-win.c (tui_source_window_base::refresh_all)
1247         (tui_source_window_base::update_tab_width)
1248         (tui_source_window_base::set_new_height)
1249         (tui_source_window_base::do_make_visible_with_new_height): Move to
1250         tui-winsource.c.
1251         * tui/tui-source.h: Update.
1252         * tui/tui-source.c (tui_source_window_base::reset): Move to
1253         tui-winsource.c.
1254         * tui/tui-disasm.h: Update.
1255         * tui/tui-data.h (struct tui_exec_info_window): Move to
1256         tui-winsource.h.
1257         (struct tui_source_window_base): Likewise.
1258         * tui/tui-data.c (tui_source_window_base::clear_detail)
1259         (tui_source_window_base, ~tui_source_window_base): Move to
1260         tui-winsource.c.
1261
1262 2019-07-17  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-win.c (tui_resize_all)
1265         (tui_source_window_base::update_tab_width)
1266         (tui_adjust_win_heights): Update.
1267         (tui_win_info::make_invisible_and_set_new_height): Rename from
1268         make_invisible_and_set_new_height.
1269         * tui/tui-data.h (struct tui_win_info)
1270         <make_invisible_and_set_new_height>: New method.
1271
1272 2019-07-17  Tom Tromey  <tom@tromey.com>
1273
1274         * tui/tui.c: Update.
1275         * tui/tui-source.h (struct tui_source_window): Move from
1276         tui-data.h.
1277         * tui/tui-layout.c: Update.
1278         * tui/tui-disasm.c: Update.
1279         * tui/tui-data.h (struct tui_source_window): Move to
1280         tui-source.h.
1281
1282 2019-07-17  Tom Tromey  <tom@tromey.com>
1283
1284         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1285         tui-data.h.
1286         * tui/tui-data.h (struct tui_disasm_window): Move to
1287         tui-disasm.h.
1288
1289 2019-07-17  Tom Tromey  <tom@tromey.com>
1290
1291         * tui/tui-regs.h (struct tui_data_item_window): Move from
1292         tui-data.h.
1293         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1294         * tui/tui-data.h (struct tui_data_item_window): Move to
1295         tui-regs.h.
1296         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1297
1298 2019-07-17  Tom Tromey  <tom@tromey.com>
1299
1300         * tui/tui.c: Update.
1301         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1302         (tui_cmd_window::max_height): Move to tui-command.c.
1303         * tui/tui-layout.c: Update.
1304         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1305         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1306         tui-command.c.
1307         * tui/tui-command.h (struct tui_cmd_window): Move from
1308         tui-data.h.
1309         * tui/tui-command.c: Remove "structuring" comments.
1310         (tui_cmd_window::clear_detail)
1311         (tui_cmd_window::do_make_visible_with_new_height)
1312         (tui_cmd_window::max_height): Move from elsewhere.
1313
1314 2019-07-17  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1317         Now static.
1318         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1319         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1320
1321 2019-07-17  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui.c: Update.
1324         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1325         tui-regs.c.
1326         * tui/tui-windata.h: Remove file.
1327         * tui/tui-windata.c: Remove file.
1328         * tui/tui-win.c (tui_data_window::set_new_height)
1329         (tui_data_window::do_make_visible_with_new_height): Move to
1330         tui-regs.c.
1331         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1332         * tui/tui-regs.c: Remove "structuring" comments.
1333         (tui_data_window::first_data_item_displayed)
1334         (tui_data_window::delete_data_content_windows)
1335         (tui_data_window::erase_data_content)
1336         (tui_data_window::display_all_data)
1337         (tui_data_window::refresh_all)
1338         (tui_data_window::do_scroll_vertical)
1339         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1340         (tui_data_window::do_make_visible_with_new_height)
1341         (tui_data_window::refresh_window): Move from elsewhere.
1342         (_initialize_tui_regs): Move to end of file.
1343         * tui/tui-layout.c: Update.
1344         * tui/tui-hooks.c: Update.
1345         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1346         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1347         tui-regs.c.
1348         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1349
1350 2019-07-17  Tom Tromey  <tom@tromey.com>
1351
1352         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1353         seen.
1354
1355 2019-07-17  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-win.c (tui_source_window_base::set_new_height)
1358         (tui_source_window_base::do_make_visible_with_new_height): Use
1359         m_has_locator field directly.
1360         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1361         method.
1362         (struct tui_source_window_base) <has_locator>: Likewise.
1363
1364 2019-07-17  Tom Tromey  <tom@tromey.com>
1365
1366         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1367         Don't declare.
1368         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1369         Remove.
1370         * tui/tui-win.c (tui_source_window_base::set_new_height)
1371         (tui_source_window_base::set_new_height)
1372         (make_invisible_and_set_new_height)
1373         (tui_source_window_base::do_make_visible_with_new_height)
1374         (tui_source_window_base::do_make_visible_with_new_height):
1375         Update.
1376         * tui/tui-layout.c (show_source_disasm_command, show_data)
1377         (show_source_or_disasm_and_command): Update.
1378         * tui/tui-layout.c (show_layout): Update.
1379
1380 2019-07-17  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-layout.c (make_data_window): Remove.
1383         (show_data): Unify creation and re-initialization cases.
1384
1385 2019-07-17  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-layout.c (make_source_window, make_disasm_window):
1388         Remove.
1389         (show_data): Unify creation and re-initialization cases.
1390
1391 2019-07-17  Tom Tromey  <tom@tromey.com>
1392
1393         * tui/tui-layout.c (make_command_window): Remove.
1394         (show_source_disasm_command, show_source_or_disasm_and_command):
1395         Unify creation and re-initialization cases.
1396
1397 2019-07-17  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1400         creation and re-initialization cases.
1401
1402 2019-07-17  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-regs.c (tui_get_register): Return void.
1405
1406 2019-07-17  Tom Tromey  <tom@tromey.com>
1407
1408         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1409         Simplify.
1410
1411 2019-07-17  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1414         resetting.
1415
1416 2019-07-17  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1419         * tui/tui-regs.c (tui_reg_layout): New function.
1420         (tui_show_registers, tui_reg_command): Use it.
1421         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1422         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1423         parameters.
1424         (tui_layout_command): Remove.
1425
1426 2019-07-17  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-layout.h (tui/tui-layout): Return void.
1429         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1430
1431 2019-07-17  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-layout.c (show_source_disasm_command, show_data):
1434         Update.
1435         (reset_locator): Remove.
1436         (show_source_or_disasm_and_command): Update.
1437
1438 2019-07-17  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-source.c (tui_source_window_base::reset): Remove
1441         win_type parameter.
1442         * tui/tui-layout.c (make_command_window, make_source_window)
1443         (make_disasm_window, make_data_window)
1444         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1445         (reset_locator, show_source_or_disasm_and_command): Update.
1446         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1447         win_type parameter.
1448         (struct tui_source_window_base) <reset>: Likewise.
1449
1450 2019-07-17  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-layout.c (show_source_disasm_command): Use
1453         reset_locator.
1454         (reset_locator): New function.
1455         (init_and_make_win): Remove.
1456         (show_source_or_disasm_and_command): Use reset_locator.
1457
1458 2019-07-17  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1461         condition.
1462         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1463         Remove condition.
1464         * tui/tui-source.c (tui_source_window_base::reset): New method.
1465         * tui/tui-layout.c (make_command_window): Don't call
1466         init_and_make_win.
1467         (make_source_window, make_disasm_window): Don't call
1468         make_source_or_disasm_window.
1469         (make_data_window): Don't call init_and_make_win.  Change calling
1470         convention.
1471         (show_source_disasm_command, show_data): Simplify.
1472         (make_source_or_disasm_window): Remove.
1473         (show_source_or_disasm_and_command): Simplify.
1474         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1475         (struct tui_source_window_base) <reset>: Likewise.
1476         <execution_info>: Remove initializer.
1477         * tui/tui-data.c (tui_source_window_base): Initialize
1478         execution_info.
1479
1480 2019-07-17  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1483         variable.
1484
1485 2019-07-17  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui.c (tui_rl_other_window): Update.
1488         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1489         superclass method first.  Always iterate over regs_content.
1490         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1491         method.
1492         * tui/tui-win.c (tui_set_focus_command): Update.
1493
1494 2019-07-17  Tom Tromey  <tom@tromey.com>
1495
1496         * tui/tui-win.c (tui_set_focus_command): Rename from
1497         tui_set_focus.  Call tui_enable.
1498         (tui_set_focus_command): Remove.
1499
1500 2019-07-17  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1503         refresh_window.
1504         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1505         touchwin.
1506         (tui_data_window::refresh_window): Call refresh_window on data
1507         items.  Always call superclass refresh_window.
1508         (tui_win_info::refresh): Remove.
1509         (tui_source_window_base::refresh_window): Update.
1510         (tui_refresh_all): Update.
1511         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1512         refresh_window.
1513         (show_source_or_disasm_and_command): Likewise.
1514         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1515         (struct tui_source_window_base) <refresh>: Likewise.
1516
1517 2019-07-17  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-winsource.c (tui_clear_source_content)
1520         (tui_show_source_content): Update.
1521         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1522         whether content is empty.
1523         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1524         Remove.
1525
1526 2019-07-17  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1529         window's contents.
1530         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1531         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1532
1533 2019-07-17  Tom Tromey  <tom@tromey.com>
1534
1535         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1536         (struct tui_data_item_window): Update.
1537
1538 2019-07-17  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1541         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1542         defines.
1543
1544 2019-07-17  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui-winsource.h (tui_erase_source_content)
1547         (tui_clear_source_content): Remove "display_prompt" parameter.
1548         * tui/tui-winsource.c (tui_update_source_window_as_is)
1549         (tui_update_source_windows_with_addr): Update.
1550         (tui_clear_source_content): Remove "display_prompt" parameter.
1551         (tui_erase_source_content): Likewise.  Simplify.
1552         (tui_show_source_content): Update.
1553         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1554         * tui/tui-stack.c (tui_show_frame_info): Update.
1555         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1556         Remove defines.
1557
1558 2019-07-17  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1561         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1562         parameter.
1563         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1564         parameter.
1565
1566 2019-07-17  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-winsource.c (tui_clear_source_content)
1569         (tui_show_source_content, tui_show_exec_info_content)
1570         (tui_clear_exec_info_content): Update.
1571         * tui/tui-stack.c (tui_show_locator_content): Update.
1572         (tui_show_frame_info): Update.
1573         * tui/tui-source.h (tui_source_window): Don't declare.
1574         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1575         from tui_source_is_displayed.
1576         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1577         Remove field.
1578         (struct tui_source_window_base) <content_in_use>: New field.  Now
1579         bool.
1580         (struct tui_source_window) <showing_source_p>: New method.
1581         (TUI_SRC_WIN): Change cast.
1582         * tui/tui-data.c (tui_initialize_static_data): Update.
1583
1584 2019-07-17  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1587         location_matches_p.
1588         * tui/tui-source.c (tui_source_window::location_matches_p): New
1589         method.
1590         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1591         method.
1592         * tui/tui-data.h (struct tui_source_window_base)
1593         <location_matches_p>: New method.
1594         (struct tui_source_window, struct tui_disasm_window)
1595         <location_matches_p>: Likewise.
1596
1597 2019-07-17  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-win.c (tui_set_win_height_command): Rename from
1600         tui_set_win_height.
1601         (tui_set_win_height_command): Remove.
1602
1603 2019-07-17  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-source.c (tui_source_window): New constructor.  Add
1606         observer.
1607         (~tui_source_window): New destructor.
1608         (tui_source_window::style_changed): New method.
1609         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1610         (tui_attach_detach_observers): Update.
1611         * tui/tui-data.h (struct tui_source_window): Make constructor not
1612         inline.  Add destructor.
1613         (struct tui_source_window) <style_changed>: New method.
1614         <m_observable>: New member.
1615
1616 2019-07-17  Tom Tromey  <tom@tromey.com>
1617
1618         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1619         * tui/tui-win.c (tui_resize_all): Fix typo.
1620
1621 2019-07-17  Tom Tromey  <tom@tromey.com>
1622
1623         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1624         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1625         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1626         * tui/tui-win.c (window_name_completer): Use foreach.
1627         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1628         (update_tab_width): Likewise.
1629         * tui/tui-layout.c (show_layout): Update.
1630         * tui/tui-data.h (class tui_window_iterator): New.
1631         (struct all_tui_windows): New.
1632         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1633
1634 2019-07-17  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1637         parameter.  Don't reference globals.
1638         (tui_reg_command): Update.
1639
1640 2019-07-17  Tom Tromey  <tom@tromey.com>
1641
1642         * tui/tui-regs.c (tui_show_registers): Simplify.
1643
1644 2019-07-17  Tom Tromey  <tom@tromey.com>
1645
1646         * tui/tui-regs.c (tui_show_registers): Update.
1647         (tui_show_register_group): Add win_info parameter.
1648
1649 2019-07-17  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1652         Rename from tui_display_reg_element_at_line.
1653         (tui_data_window::display_registers_from_line): Update.
1654         * tui/tui-data.h (struct tui_data_window)
1655         <display_reg_element_at_line>: New method.
1656
1657 2019-07-17  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-regs.h (tui_display_registers_from)
1660         (tui_display_registers_from_line): Don't declare.
1661         * tui/tui-windata.c (tui_data_window::display_all_data)
1662         (tui_data_window::refresh_all)
1663         (tui_data_window::do_scroll_vertical): Update.
1664         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1665         from tui_display_registers_from.
1666         (tui_display_reg_element_at_line): Update.
1667         (tui_data_window::display_registers_from_line): Rename from
1668         tui_display_registers_from_line.
1669         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1670         display_registers_from_line>: New methods.
1671
1672 2019-07-17  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1675         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1676         from tui_erase_data_content.
1677         (tui_data_window::display_all_data)
1678         (tui_data_window::refresh_all)
1679         (tui_data_window::do_scroll_vertical): Update.
1680         * tui/tui-regs.c (tui_show_registers): Update.
1681         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1682         New method.
1683
1684 2019-07-17  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1687         declare.
1688         * tui/tui-windata.c
1689         (tui_data_window::delete_data_content_windows): Rename from
1690         tui_delete_data_content_windows.
1691         (tui_data_window::display_all_data)
1692         (tui_data_window::do_scroll_vertical): Update.
1693         * tui/tui-data.h (struct tui_data_window)
1694         <delete_data_content_windows>: New method.
1695
1696 2019-07-17  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1699         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1700
1701 2019-07-17  Tom Tromey  <tom@tromey.com>
1702
1703         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1704         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1705         from tui_display_all_data.
1706         * tui/tui-win.c
1707         (tui_data_window::do_make_visible_with_new_height): Update.
1708         * tui/tui-regs.c (tui_show_registers): Update.
1709         * tui/tui-layout.c (tui_set_layout): Update.
1710         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1711         method.
1712
1713 2019-07-17  Tom Tromey  <tom@tromey.com>
1714
1715         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1716         * tui/tui-windata.c (tui_display_data_from): Remove.
1717         (tui_data_window::refresh_all): Update.
1718
1719 2019-07-17  Tom Tromey  <tom@tromey.com>
1720
1721         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1722         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1723         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1724         tui_display_registers_from_line.
1725         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1726         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1727         "force_display" parameter.
1728
1729 2019-07-17  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1732         declare.
1733         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1734         Rename from tui_first_reg_element_no_inline.
1735         (tui_display_reg_element_at_line)
1736         (tui_display_registers_from_line): Update.
1737         * tui/tui-data.h (struct tui_data_window)
1738         <first_reg_element_no_inline>: New method.
1739
1740 2019-07-17  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-windata.c (tui_display_data_from)
1743         (tui_data_window::do_scroll_vertical): Update.
1744         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1745         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1746         Rename from tui_line_from_reg_element_no.
1747         (tui_display_registers_from_line): Update.
1748         * tui/tui-data.h (struct tui_data_window)
1749         <line_from_reg_element_no>: New method.
1750
1751 2019-07-17  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1754         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1755         tui_last_regs_line_no.
1756         (tui_display_reg_element_at_line)
1757         (tui_display_registers_from_line): Update.
1758         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1759         method.
1760
1761 2019-07-17  Tom Tromey  <tom@tromey.com>
1762
1763         PR tui/24722:
1764         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1765         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1766         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1767         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1768         (tui_update_breakpoint_info): Likewise.
1769         * tui/tui-hooks.c (tui_event_create_breakpoint)
1770         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1771         Update.
1772
1773 2019-07-17  Tom Tromey  <tom@tromey.com>
1774
1775         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1776
1777 2019-07-17  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-winsource.c (tui_update_source_window_as_is)
1780         (tui_update_source_windows_with_addr): Update.
1781         * tui/tui-source.h (tui_set_source_content)
1782         (tui_show_symtab_source): Add "win_info" parameter.
1783         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1784         parameter.
1785         (tui_show_symtab_source): Likewise.
1786
1787 2019-07-17  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-wingeneral.c
1790         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1791
1792 2019-07-17  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1795         (struct tui_cmd_window) <can_scroll>: New method.
1796         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1797         method.
1798
1799 2019-07-17  Tom Tromey  <tromey@adacore.com>
1800
1801         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1802         do_field_signed>: Rename.  Change type of "value".
1803         * ui-out.c (ui_out::field_signed): Rename from field_int.
1804         Change type of "value".
1805         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1806         type of "value".
1807         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1808         do_field_int.  Change type of "value".
1809         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1810         do_field_int.  Change type of "value".
1811         * tracepoint.c (trace_status_mi, tfind_1)
1812         (print_one_static_tracepoint_marker): Update.
1813         * thread.c (print_thread_info_1, print_selected_thread_frame):
1814         Update.
1815         * stack.c (print_frame, print_frame_info): Update.
1816         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1817         Update.
1818         * source.c (print_source_lines_base): Update.
1819         * skip.c (info_skip_command): Update.
1820         * record-btrace.c (btrace_ui_out_decode_error)
1821         (btrace_call_history_src_line): Update.
1822         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1823         Update.
1824         * progspace.c (print_program_space): Update.
1825         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1826         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1827         do_field_int.  Change type of "value".
1828         * mi/mi-out.c (mi_ui_out::do_table_begin)
1829         (mi_ui_out::do_table_header): Update.
1830         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1831         type of "value".
1832         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1833         (mi_cmd_data_list_changed_registers, output_register)
1834         (mi_cmd_data_read_memory, mi_load_progress)
1835         (mi_cmd_trace_frame_collected): Update.
1836         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1837         Update.
1838         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1839         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1840         (mi_cmd_var_list_children, varobj_update_one): Update.
1841         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1842         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1843         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1844         * inferior.c (print_inferior): Update.
1845         * gdb_bfd.c (print_one_bfd): Update.
1846         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1847         Update.
1848         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1849         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1850         do_field_int.  Change type of "value".
1851         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1852         do_field_int.  Change type of "value".
1853         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1854         (print_one_breakpoint_location, print_it_catch_fork)
1855         (print_one_catch_fork, print_it_catch_vfork)
1856         (print_one_catch_vfork, print_it_catch_solib)
1857         (print_it_catch_exec, print_it_ranged_breakpoint)
1858         (print_mention_watchpoint, print_mention_masked_watchpoint)
1859         (bkpt_print_it, update_static_tracepoint): Update.
1860         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1861         * break-catch-syscall.c (print_it_catch_syscall): Update.
1862         * ada-tasks.c (print_ada_task_info): Update.
1863         * ada-lang.c (print_it_exception, print_mention_exception):
1864         Update.
1865
1866 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1867
1868         PR breakpoints/24541
1869         * gdbarch.c: Regenerate.
1870         * gdbarch.h: Regenerate.
1871         * gdbarch.sh: Adjust return type and parameter types for
1872         'stap_adjust_register'.
1873         (i386_stap_adjust_register): Adjust signature and return new
1874         register name.
1875         * stap-probe.c (stap_parse_register_operand): Adjust use of
1876         'gdbarch_stap_adjust_register'.
1877
1878 2019-07-17  Tom Tromey  <tromey@adacore.com>
1879
1880         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1881         declare VEC.
1882         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1883         std::vector.
1884         (struct s390_process_info): Add initializers.
1885         (s390_add_process): Use new.
1886         (s390_linux_nat_target::low_forget_process): Use delete.
1887         (s390_linux_nat_target::low_new_fork)
1888         (s390_linux_nat_target::stopped_by_watchpoint)
1889         (s390_linux_nat_target::low_prepare_to_resume)
1890         (s390_linux_nat_target::insert_watchpoint)
1891         (s390_linux_nat_target::insert_hw_breakpoint)
1892         (s390_linux_nat_target::remove_watchpoint)
1893         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1894
1895 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1896
1897         * aarch64-fbsd-nat.c: Include regcache.h.
1898         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1899         argument.
1900         (aarch64_fbsd_nat_target::fetch_registers)
1901         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1902         variable.
1903         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1904
1905 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1906
1907         * fbsd-nat.c: Include gdbarch.h.
1908
1909 2019-07-15  Tom Tromey  <tromey@adacore.com>
1910
1911         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1912
1913 2019-07-15  Tom Tromey  <tromey@adacore.com>
1914
1915         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1916         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1917         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1918         * cli-out.c (cli_ui_out::do_field_int): New method.
1919         * ui-out.c (ui_out::field_unsigned): New method.
1920         * symfile.c (generic_load): Use field_unsigned.
1921         (print_transfer_performance): Likewise.
1922         * record-btrace.c (ui_out_field_uint): Remove.
1923         (btrace_call_history_insn_range, btrace_call_history): Use
1924         field_unsigned.
1925         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1926         field_unsigned.
1927         * ui-out.h (class ui_out) <field_unsigned>: New method.
1928         <do_field_unsigned>: Likewise.
1929
1930 2019-07-15  Tom Tromey  <tromey@adacore.com>
1931
1932         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1933         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1934         * target.c (flash_erase_command): Use field_string.
1935         * infrun.c (print_signal_received_reason): Use field_string.
1936         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1937         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1938         field_string.
1939         * ada-tasks.c (print_ada_task_info): Use field_string.
1940
1941 2019-07-15  Tom Tromey  <tromey@adacore.com>
1942
1943         * target.c (flash_erase_command): Use field_core_addr.
1944         * symfile.c (generic_load): Use field_core_addr.
1945         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1946         Use field_core_addr.
1947         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1948         field_core_addr.
1949
1950 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1953         value if its desired type is smaller than a CORE_ADDR and signed.
1954
1955 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1956
1957         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1958         of changes to field names, and use new is_reference field to
1959         decide if a property is a reference or not.
1960         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1961         field.
1962         (struct dwarf2_property_baton): Update header comment, rename
1963         'referenced_type' to 'property_type' and update comments.
1964         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1965         default property type, store in property baton, update to take
1966         accound of renamed field.
1967         (read_func_scope): Update call to attr_to_dynamic_prop.
1968         (read_array_type): Likewise.
1969         (dwarf2_per_cu_addr_sized_int_type): New function.
1970         (read_subrange_index_type): Move type finding code to
1971         dwarf2_per_cu_addr_sized_int_type.
1972         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1973         (dwarf2_per_cu_addr_type): New function.
1974         (set_die_type): Update calls to attr_to_dynamic_prop.
1975
1976 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1977
1978         * dwarf2read.c (read_subrange_index_type): New function.
1979         (read_subrange_type): Move code into new function and call it.
1980         * gdbtypes.c (create_range_type): Add some asserts.
1981
1982 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1983
1984         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1985         update return statements.
1986         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1987         declaration, and update comment to match.
1988         * gdbtypes.c (resolve_dynamic_array): Update call to
1989         dwarf2_evaluate_property to match new return type.
1990
1991 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1992
1993         * valarith.c (value_subscripted_rvalue): Change lowerbound
1994         parameter type from int to LONGEST.
1995         * value.h (value_subscripted_rvalue): Likewise in declaration.
1996
1997 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1998
1999         * cli/cli-utils.c (info_print_command_completer): New function.
2000         * cli/cli-utils.h: Add 'completer.h' include, and forward
2001         declaration for 'struct cmd_list_element'.
2002         (info_print_command_completer): Declare.
2003         * stack.c (_initialize_stack): Add completer for 'info locals' and
2004         'info args'.
2005         * symtab.c (_initialize_symtab): Add completer for 'info
2006         variables' and 'info functions'.
2007         * NEWS: Mention completion for additional info commands.
2008
2009 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2010
2011         * cli/cli-utils.c (extract_info_print_args): Delete.
2012         (extract_arg_maybe_quoted): Delete.
2013         (info_print_options_defs): New variable.
2014         (make_info_print_options_def_group): New function.
2015         (extract_info_print_options): Define new function.
2016         * cli/cli-utils.h (extract_info_print_args): Delete.
2017         (struct info_print_options): New structure.
2018         (extract_info_print_options): Declare new function.
2019         * stack.c (info_locals_command): Update to use new
2020         extract_info_print_options, also add a header comment.
2021         (info_args_command): Likewise.
2022         * symtab.c (info_variables_command): Likewise.
2023         (info_functions_command): Likewise.
2024
2025 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2026
2027         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2028         to extract string arguments.
2029         * common/common-utils.c (extract_string_maybe_quoted): New function.
2030         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2031
2032 2019-07-11  Tom Tromey  <tromey@adacore.com>
2033
2034         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2035         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2036         * top.h (gdbinit): Don't declare.
2037         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2038         into...
2039         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2040         * top.c (gdb_init): Don't call init_cli_cmds.
2041         (gdbinit): Remove.
2042         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2043
2044 2019-07-11  Tom Tromey  <tromey@adacore.com>
2045
2046         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2047         after it has been moved.
2048
2049 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2050
2051         * valops.c (value_must_coerce_to_target): Change return type to
2052         bool.
2053         * value.h (value_must_coerce_to_target): Likewise.
2054
2055 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2056
2057         * breakpoint.c (is_hardware_watchpoint): Remove
2058         forward-declaration.
2059         (is_masked_watchpoint): Change return type to bool.
2060         (is_tracepoint): Likewise.
2061         (is_breakpoint): Likewise.
2062         (is_hardware_watchpoint): Likewise.
2063         (is_watchpoint): Likewise.
2064         (is_no_memory_software_watchpoint): Likewise.
2065         (is_catchpoint): Likewise.
2066         (breakpoint_1): Make FILTER parameter's return type bool.
2067         is_masked_watchpoint): Change return type to bool.
2068         (save_breakpoints): Make FILTER parameter's return type bool.
2069         * breakpoint.h (is_breakpoint): Change return type to bool.
2070         (is_watchpoint): Likewise.
2071         (is_catchpoint): Likewise.
2072         (is_tracepoint): Likewise.
2073
2074 2019-07-10  Tom Tromey  <tom@tromey.com>
2075
2076         * defs.h: Don't include gdbarch.h.
2077         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2078         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2079         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2080         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2081         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2082         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2083         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2084         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2085         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2086         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2087         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2088         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2089         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2090         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2091         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2092         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2093         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2094         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2095         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2096         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2097         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2098         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2099         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2100         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2101         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2102         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2103         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2104
2105 2019-07-10  Tom Tromey  <tromey@adacore.com>
2106
2107         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2108         * breakpoint.c (init_ada_exception_breakpoint): Register as
2109         bp_catchpoint.
2110         (print_one_breakpoint_location, print_one_breakpoint): Use
2111         is_ada_exception_catchpoint.
2112         * ada-lang.c (class ada_catchpoint_location): Pass
2113         bp_loc_software_breakpoint to bp_location constructor.
2114         (is_ada_exception_catchpoint): New function.
2115
2116 2019-07-10  Tom Tromey  <tromey@adacore.com>
2117
2118         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2119         VEC.
2120         (struct arm_exidx_entry): New method operator<.
2121         (struct arm_exidx_data) <section_maps>: Change type.
2122         (arm_exidx_data_free): Remove.
2123         (arm_exidx_data_key): Change type.  Move lower.
2124         (arm_exidx_new_objfile): Update.
2125         (arm_compare_exidx_entries): Remove.
2126         (arm_find_exidx_entry, _initialize_arm_tdep)
2127
2128 2019-07-10  Tom Tromey  <tromey@adacore.com>
2129
2130         * solib-spu.c (ocl_program_data_key): Change type.
2131         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2132         Update.
2133
2134 2019-07-10  Tom Tromey  <tromey@adacore.com>
2135
2136         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2137         (struct solib_aix_inferior_data) <library_list>: Change type.
2138         (solib_aix_inferior_data_handle): Change type.
2139         (get_solib_aix_inferior_data): Update.
2140         (solib_aix_free_library_list): Remove.
2141         (library_list_start_library): Update.
2142         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2143         return type.
2144         (solib_aix_get_library_list)
2145         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2146         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2147
2148 2019-07-10  Tom Tromey  <tromey@adacore.com>
2149
2150         * solib-dsbt.c (struct dsbt_info): Add initializers.
2151         (solib_dsbt_pspace_data): Change type.
2152         (dsbt_pspace_data_cleanup): Remove.
2153         (get_dsbt_info, _initialize_dsbt_solib): Update.
2154
2155 2019-07-10  Tom Tromey  <tromey@adacore.com>
2156
2157         * spu-tdep.c (spu_overlay_data): Change type.
2158         (spu_get_overlay_table, spu_overlay_new_objfile)
2159         (_initialize_spu_tdep): Update.
2160
2161 2019-07-10  Tom Tromey  <tromey@adacore.com>
2162
2163         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2164         destructor.
2165         (dbx_objfile_data_key): Change type and declare later.
2166         (DBX_SYMFILE_INFO): Rewrite.
2167         * dbxread.c (dbx_objfile_data_key): Change type.
2168         (dbx_symfile_init): Update.
2169         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2170         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2171         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2172
2173 2019-07-10  Tom Tromey  <tromey@adacore.com>
2174
2175         * jit.c (jit_program_space_key): Change type.  Move lower.
2176         (get_jit_program_space_data): Update.
2177         (jit_program_space_data_cleanup): Remove.
2178         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2179         Update.
2180         (struct jit_program_space_data): Add initializers.
2181
2182 2019-07-10  Tom Tromey  <tromey@adacore.com>
2183
2184         * solib-darwin.c (struct darwin_info): Add initializers.
2185         (solib_darwin_pspace_data): Change type.
2186         (darwin_pspace_data_cleanup): Remove.
2187         (get_darwin_info, _initialize_darwin_solib): Update.
2188
2189 2019-07-10  Tom Tromey  <tromey@adacore.com>
2190
2191         * remote-sim.c (struct sim_inferior_data): Add initializers,
2192         constructor, and destructor.
2193         (sim_inferior_data_key): Change type.  Move lower.
2194         (check_for_duplicate_sim_descriptor): Update.
2195         (get_sim_inferior_data): Use new.  Update.
2196         (~sim_inferior_data_cleanup): Rename from
2197         sim_inferior_data_cleanup.  Simplify.
2198         (gdbsim_close_inferior, simulator_command)
2199         (sim_command_completer, _initialize_remote_sim): Update.
2200         (next_pid, INITIAL_PID): Move earlier.
2201
2202 2019-07-10  Tom Tromey  <tromey@adacore.com>
2203
2204         * python/python-internal.h (create_thread_object): Return
2205         gdbpy_ref.
2206         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2207         * python/py-inferior.c (struct threadlist_entry): Add
2208         constructor.
2209         <thread_obj>: Now a gdbpy_ref.
2210         (thread_to_thread_object): Update.
2211         (add_thread_object): Use new.
2212         (delete_thread_object): Use delete.
2213         (infpy_threads): Update.
2214         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2215         GIL.
2216
2217 2019-07-10  Tom Tromey  <tromey@adacore.com>
2218
2219         * valops.c (value_cast): Specialize error message for Ada.
2220
2221 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2222
2223         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2224
2225 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2226
2227         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2228         bpstat_should_step): Return bool, adjust comments.
2229         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2230         bpstat_should_step): Likewise.
2231
2232 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2233
2234         * features/Makefile: Use feature target descriptions for Arm.
2235         * features/arm/arm-core.c: Generate new file.
2236         * features/arm/arm-fpa.c: Likewise.
2237         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2238         * features/arm/arm-m-profile.c: Likewise.
2239         * features/arm/arm-vfpv2.c: Likewise.
2240         * features/arm/arm-vfpv3.c: Likewise.
2241         * features/arm/xscale-iwmmxt.c: Likewise.
2242         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2243
2244 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2245
2246         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2247         ptrace earlier.
2248
2249 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2250
2251         * features/aarch64-pauth.c: Regenerate.
2252
2253 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2254
2255         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2256         bool.
2257         (bpstat_what): Use false instead of 0.
2258
2259 2019-07-09  Pedro Alves  <palves@redhat.com>
2260
2261         * break-catch-throw.c (is_exception_catchpoint): New.
2262         * breakpoint.c (print_one_breakpoint_location): New parameter
2263         'raw_loc'.  Handle it.  Use
2264         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2265         looking at the breakpoint's type.
2266         (print_one_breakpoint): If handling "maint info breakpoints", also
2267         print locations of exception catchpoints.
2268         * breakpoint.h (is_exception_catchpoint): Declare.
2269
2270 2019-07-09  Pedro Alves  <palves@redhat.com>
2271
2272         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2273         "addr" field.
2274         (allocate_location_exception_catchpoint): New.
2275         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2276         (initialize_throw_catchpoint_ops): Install
2277         allocate_location_exception_catchpoint as allocate_location
2278         method.
2279         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2280         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2281         bp_loc_other.
2282         (breakpoint_address_is_meaningful): Delete.
2283         (bl_address_is_meaningful): New.
2284         (breakpoint_locations_match): Adjust comment.
2285         (bp_location_from_bp_type): New, factored out of...
2286         (bp_location::bp_location(breakpoint *)): ... this.
2287         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2288         factored out of...
2289         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2290         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2291         breakpoint_address_is_meaningful.
2292         (bp_locations_compare): Adjust comment.
2293         (update_global_location_list): Use bl_address_is_meaningful
2294         instead of breakpoint_address_is_meaningful.
2295         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2296         explicit.
2297         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2298         * python/py-breakpoint.c (bppy_get_location): No longer check
2299         whether location is null.
2300
2301 2019-07-09  Pedro Alves  <palves@redhat.com>
2302
2303         PR c++/15468
2304         * breakpoint.c (print_one_breakpoint_location): Remove
2305         single-location assert.
2306
2307 2019-07-09  Tom Tromey  <tom@tromey.com>
2308
2309         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2310         * configure: Rebuild.
2311         * configure.ac: Change common to gdbsupport.
2312         * gdbsupport: Rename from common.
2313         * acinclude.m4: Change common to gdbsupport.
2314         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2315         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2316         gdbsupport.
2317         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2318         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2319         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2320         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2321         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2322         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2323         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2324         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2325         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2326         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2327         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2328         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2329         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2330         coff-pe-read.c, command.h, compile/compile-c-support.c,
2331         compile/compile-c.h, compile/compile-cplus-symbols.c,
2332         compile/compile-cplus-types.c, compile/compile-cplus.h,
2333         compile/compile-loc2c.c, compile/compile.c, completer.c,
2334         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2335         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2336         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2337         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2338         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2339         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2340         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2341         features/aarch64-core.c, features/aarch64-fpu.c,
2342         features/aarch64-pauth.c, features/aarch64-sve.c,
2343         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2344         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2345         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2346         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2347         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2348         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2349         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2350         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2351         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2352         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2353         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2354         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2355         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2356         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2357         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2358         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2359         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2360         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2361         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2362         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2363         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2364         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2365         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2366         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2367         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2368         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2369         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2370         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2371         minsyms.c, mips-linux-tdep.c, namespace.h,
2372         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2373         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2374         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2375         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2376         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2377         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2378         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2379         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2380         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2381         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2382         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2383         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2384         procfs.c, producer.c, progspace.h, psymtab.h,
2385         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2386         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2387         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2388         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2389         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2390         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2391         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2392         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2393         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2394         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2395         target-memory.c, target.c, target.h, target/waitstatus.c,
2396         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2397         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2398         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2399         unittests/array-view-selftests.c,
2400         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2401         unittests/common-utils-selftests.c,
2402         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2403         unittests/format_pieces-selftests.c,
2404         unittests/function-view-selftests.c,
2405         unittests/lookup_name_info-selftests.c,
2406         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2407         unittests/mkdir-recursive-selftests.c,
2408         unittests/observable-selftests.c,
2409         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2410         unittests/parse-connection-spec-selftests.c,
2411         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2412         unittests/scoped_fd-selftests.c,
2413         unittests/scoped_mmap-selftests.c,
2414         unittests/scoped_restore-selftests.c,
2415         unittests/string_view-selftests.c, unittests/style-selftests.c,
2416         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2417         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2418         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2419         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2420         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2421         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2422
2423 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2424
2425         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2426         bool value.
2427         (decode_digits_ordinary): Set explicit_line field in sal.
2428         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2429         symtab_and_line that was set on an explicit line number in
2430         assembler code.  Do always update the recorded symtab and line if
2431         we do skip the prologue.
2432
2433 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2434
2435         * breakpoint.c (set_breakpoint_location_function): Remove
2436         explicit_loc parameter.
2437         (momentary_breakpoint_from_master): Update call to
2438         set_breakpoint_location_function.
2439         (add_location_to_breakpoint): Likewise.
2440
2441 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2442
2443         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2444         required features based on default bfd type when no specific bfd
2445         is present.
2446
2447 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2448
2449         * NEWS: Mention that GDB printf and eval commands can now print
2450         C-style and Ada-style convenience var strings without
2451         calling the inferior.
2452         * printcmd.c (printf_c_string): Locally print GDB internal var
2453         instead of transiting via the inferior.
2454         (printf_wide_c_string): Likewise.
2455
2456 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2457
2458         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2459
2460 2019-07-04  Tom Tromey  <tom@tromey.com>
2461
2462         PR tui/24724:
2463         * tui/tui-winsource.c (tui_clear_source_content): Update.
2464         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2465         (tui_update_breakpoint_info): Update.
2466         (tui_set_exec_info_content): Update.
2467         * tui/tui-source.c (tui_set_source_content_nil): Update.
2468         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2469         has_break.
2470         * tui/tui-data.h (enum tui_bp_flag): New.
2471         (tui_bp_flags): New enum flags type.
2472         (struct tui_source_element) <break_mode>: Change type.  Rename
2473         from has_break.
2474         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2475         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2476         constants.
2477         * tui/tui-winsource.h: Fix comment.
2478
2479 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2480
2481         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2482         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2483         (store_fpregs_to_thread)
2484         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2485         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2486         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2487         (IWMMXT_REGS_SIZE): Add define.
2488         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2489         (fetch_vfp_regs, store_vfp_regs)
2490         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2491         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2492
2493 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2494
2495         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2496         defines.
2497         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2498         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2499         (ARM_INT_REGISTER_SIZE): ...to this.
2500         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2501         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2502         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2503         (arm_linux_collect_gregset, supply_nwfpe_register)
2504         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2505         defines.
2506         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2507         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2508         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2509         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2510         (arm_return_in_memory, arm_store_return_value)
2511         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2512         (arm_record_ld_st_multiple): Likewise.
2513         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2514         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2515
2516 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2517
2518         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2519         AARCH64_DISPLACED_MODIFIED_INSNS.
2520         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2521         (aarch64_displaced_step_copy_insn): Likewise.
2522         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2523         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2524         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2525         ARM_DISPLACED_MODIFIED_INSNS.
2526         * arm-tdep.c (arm_gdbarch_init): Likewise.
2527         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2528         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2529         (struct arm_displaced_step_closure): Use
2530         ARM_DISPLACED_MODIFIED_INSNS.
2531
2532 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2533
2534         * features/Makefile: Remove unused xml files.
2535         * features/aarch64.xml: Remove.
2536         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2537         * features/i386/amd64-avx-avx512.xml: Remove.
2538         * features/i386/amd64-avx-linux.xml: Remove.
2539         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2540         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2541         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2542         * features/i386/amd64-avx-mpx.xml: Remove.
2543         * features/i386/amd64-avx.xml: Remove.
2544         * features/i386/amd64-linux.xml: Remove.
2545         * features/i386/amd64-mpx-linux.xml: Remove.
2546         * features/i386/amd64-mpx.xml: Remove.
2547         * features/i386/amd64.xml: Remove.
2548         * features/i386/i386-avx-avx512-linux.xml: Remove.
2549         * features/i386/i386-avx-avx512.xml: Remove.
2550         * features/i386/i386-avx-linux.xml: Remove.
2551         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2552         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2553         * features/i386/i386-avx-mpx-linux.xml: Remove.
2554         * features/i386/i386-avx-mpx.xml: Remove.
2555         * features/i386/i386-avx.xml: Remove.
2556         * features/i386/i386-linux.xml: Remove.
2557         * features/i386/i386-mmx-linux.xml: Remove.
2558         * features/i386/i386-mmx.xml: Remove.
2559         * features/i386/i386-mpx-linux.xml: Remove.
2560         * features/i386/i386-mpx.xml: Remove.
2561         * features/i386/i386.xml: Remove.
2562         * features/i386/x32-avx-avx512-linux.xml: Remove.
2563         * features/i386/x32-avx-linux.xml: Remove.
2564         * features/i386/x32-linux.xml: Remove.
2565
2566 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2567
2568         * regformats/aarch64.dat: Remove.
2569         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2570         * regformats/i386/amd64-avx-linux.dat: Remove.
2571         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2572         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2573         * regformats/i386/amd64-linux.dat: Remove.
2574         * regformats/i386/amd64-mpx-linux.dat: Remove.
2575         * regformats/i386/amd64.dat: Remove.
2576         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2577         * regformats/i386/i386-avx-linux.dat: Remove.
2578         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2579         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2580         * regformats/i386/i386-linux.dat: Remove.
2581         * regformats/i386/i386-mmx-linux.dat: Remove.
2582         * regformats/i386/i386-mpx-linux.dat: Remove.
2583         * regformats/i386/i386.dat: Remove.
2584         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2585         * regformats/i386/x32-avx-linux.dat: Remove.
2586         * regformats/i386/x32-linux.dat: Remove.
2587
2588 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2589
2590         * aarch64-tdep.c: Remove xml self tests.
2591         * amd64-linux-tdep.c: Likewise.
2592         * amd64-tdep.c: Likewise.
2593         * i386-linux-tdep.c: Likewise.
2594         * i386-tdep.c: Likewise.
2595
2596 2019-07-03  Pedro Alves  <palves@redhat.com>
2597
2598         PR cli/24732
2599         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2600         (pipe_cmd_option_defs): New.
2601         (make_pipe_cmd_options_def_group): New.
2602         (pipe_command): Use gdb::option::process_options.
2603         (pipe_command_completer): New function.
2604         (_initialize_cli_cmds): Install completer for "pipe" command.
2605
2606 2019-07-03  Pedro Alves  <palves@redhat.com>
2607
2608         * cli/cli-option.c (union option_value) <string>: New field.
2609         (struct option_def_and_value): Add ctor, move ctor, dtor and
2610         use DISABLE_COPY_AND_ASSIGN.
2611         (option_def_and_value::clear_value): New.
2612         (parse_option, save_option_value_in_ctx, get_val_type_str)
2613         (add_setshow_cmds_for_options): Handle var_string.
2614         * cli-option.h (union option_def::var_address) <string>: New
2615         field.
2616         (struct string_option_def): New.
2617         * maint-test-options.c (struct test_options_opts): Add default
2618         ctor and use DISABLE_COPY_AND_ASSIGN.
2619         <string_opt>: New field.
2620         (test_options_opts::~test_options_opts): New.
2621         (test_options_opts::dump): Also dump "-string".
2622         (test_options_option_defs): Install "string.
2623
2624 2019-07-03  Pedro Alves  <palves@redhat.com>
2625
2626         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2627         option_value with a null enumeration.
2628         (complete_options): Save the option values in the context.
2629         (save_option_value_in_ctx): New, factored out from ...
2630         (process_options): ... here.
2631         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2632         of the function.
2633         * maint-test-options.c (test_options_opts::dump): New, factored
2634         out from ...
2635         (maintenance_test_options_command_mode): ... here.
2636         (maintenance_test_options_command_completion_result): Delete.
2637         (maintenance_test_options_command_completion_text): Update
2638         comment.
2639         (maintenance_show_test_options_completion_result): Change
2640         prototype.  Just print
2641         maintenance_test_options_command_completion_text.
2642         (save_completion_result): New.
2643         (maintenance_test_options_completer_mode): Pass options context to
2644         complete_options, and then save a dump.
2645         (_initialize_maint_test_options): Use add_cmd to install "maint
2646         show test-options-completion-result".
2647
2648 2019-07-03  Pedro Alves  <palves@redhat.com>
2649
2650         * NEWS (New commands): Mention "with" and "maint with".
2651         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2652         (with_command, with_command_completer): New.
2653         (pipe_command): Adjust to new repeat_previous
2654         interface.
2655         (_initialize_cli_cmds): Install the "with" command and its "w"
2656         alias.
2657         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2658         declarations.
2659         * cli/cli-setshow.c (parse_cli_var_uinteger)
2660         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2661         argument strings for all var_types.
2662         (get_setshow_command_value_string): New, factored out from ...
2663         (do_show_command): ... this.
2664         * cli/cli-setshow.h: Include <string>.
2665         (get_setshow_command_value_string): Declare.
2666         * command.h (repeat_previous): Now returns const char *.  Adjust
2667         comment.
2668         * maint.c: Include "cli/cli-cmds.h".
2669         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2670         (_initialize_maint_cmds): Register the "maintenance with" command.
2671         * top.c (repeat_previous): Move bits from pipe_command here:
2672         Return the saved command line, if any; error out if there's no
2673         command to relaunch.
2674
2675 2019-07-03  Pedro Alves  <palves@redhat.com>
2676
2677         * NEWS (New commands): Mention "maint set/show test-settings"
2678         instead of "maint test-settings".
2679         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2680         (maintenance_test_settings_set_list): Rename to ...
2681         (maintenance_set_test_settings_list): ... this.
2682         (maintenance_test_settings_show_list): Rename to  ...
2683         (maintenance_show_test_settings_list): ... this.
2684         (maintenance_test_settings_cmd): Delete.
2685         (maintenance_test_settings_set_cmd): ...
2686         (maintenance_set_test_settings_cmd): ... this.
2687         (maintenance_test_settings_show_cmd): ...
2688         (maintenance_show_test_settings_cmd): ... this.
2689         (maintenance_test_settings_show_value_cmd):
2690         (maintenance_show_test_settings_value_cmd): ... this.
2691         (_initialize_maint_test_settings): No longer install the "maint
2692         test-settings" prefix command.  Rename "maint test-settings set"
2693         to "maint set test-settings", and "maint test-settings show" to
2694         "maint show test-settings".  Adjust all subcommands.
2695
2696 2019-07-03  Pedro Alves  <palves@redhat.com>
2697
2698         * maint-test-settings.c: Fix file's intro comment.  Replace all
2699         references to "test-options" with references to "test-settings",
2700         in comments.
2701
2702 2019-07-03  Pedro Alves  <palves@redhat.com>
2703
2704         * maint-test-settings.c (maintenance_test_settings_xxx)
2705         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2706         New.
2707         (maintenance_test_settings_enums): Use them.
2708         (maintenance_test_settings_enum): Default to
2709         maintenance_test_settings_xxx.
2710         (_initialize_maint_test_settings): Initialize
2711         MAINTENANCE_TEST_SETTINGS_FILENAME.
2712
2713 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2714
2715         * breakpoint.h (remove_breakpoints_inf): Change return type to
2716         void, move function documentation here.
2717         * breakpoint.c (remove_breakpoints_inf): Change return type to
2718         void, move function documentation to header.
2719
2720 2019-07-02  Pedro Alves  <palves@redhat.com>
2721
2722         * NEWS (Completion improvements): Mention "info threads".
2723         * thread.c (struct info_threads_opts, info_threads_option_defs)
2724         (make_info_threads_options_def_group): New.
2725         (info_threads_command): Use gdb::option::process_options.
2726         (info_threads_command_completer): New.
2727         (_initialize_thread): Use gdb::option::build_help to build the
2728         help text for "info threads".
2729
2730 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2731
2732         * defs.h (generic_load): Move from here...
2733         * symfile.h (generic_load): ... to here.  Rename name parameter
2734         to args.
2735         * symfile.c (generic_load): Add comment.
2736
2737 2019-07-01  Tom Tromey  <tromey@adacore.com>
2738
2739         * dwarf2read.c
2740         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2741         declaration of without_params.  Fix formatting.
2742
2743 2019-07-01  Tom Tromey  <tromey@adacore.com>
2744
2745         * ada-exp.y (find_primitive_type): Update.
2746         * ada-lang.h (ada_lookup_symbol): Update.
2747         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2748         parameter.
2749         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2750
2751 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2752
2753         PR breakpoints/24541
2754         * gdbarch.c: Regenerate.
2755         * gdbarch.h: Regenerate.
2756         * gdbarch.sh: Add 'stap_adjust_register'.
2757         * i386-tdep.c: Include '<unordered_set>'.
2758         (i386_stap_adjust_register): New function.
2759         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2760         * stap-probe.c (stap_parse_register_operand): Call
2761         'gdbarch_stap_adjust_register'.
2762
2763 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2764
2765         PR python/24742
2766         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2767         * python/python.c (do_start_initialization): Use 'xmalloc'
2768         instead of 'PyMem_Malloc'.
2769
2770 2019-06-28  Tom Tromey  <tromey@adacore.com>
2771
2772         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2773         for Ada.
2774
2775 2019-06-27  Tom Tromey  <tromey@adacore.com>
2776
2777         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2778         objfile_key.
2779         (arm_find_mapping_symbol, arm_record_special_symbol)
2780         (_initialize_arm_tdep): Update.
2781         (arm_objfile_data_free): Remove.
2782
2783 2019-06-27  Tom Tromey  <tromey@adacore.com>
2784
2785         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2786         to cp_print_static_field.
2787
2788 2019-06-26  Tom Tromey  <tromey@adacore.com>
2789
2790         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2791         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2792         declare.
2793
2794 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2795
2796         * features/aarch64-core.c (create_feature_aarch64_core):
2797         Regenerate.
2798         * features/aarch64-core.xml: Add cpsr flags.
2799
2800 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2801
2802         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2803         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2804
2805 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2806
2807         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2808         field.
2809         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2810         use.
2811         (arm_record_special_symbol): Don't insert new symbol in sorted
2812         position, push it at the end.
2813
2814 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2815
2816         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2817         (arm_mapping_symbol_s): Remove.
2818         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2819         (arm_mapping_symbol_vec): New typedef.
2820         (struct arm_per_objfile): Add constructor.
2821         <section_maps>: Change type to
2822         std::unique_ptr<arm_mapping_symbol_vec[]>.
2823         (arm_compare_mapping_symbols): Remove.
2824         (arm_find_mapping_symbol): Adjust to section_maps type change.
2825         (arm_objfile_data_free): Call delete on arm_per_objfile.
2826         (arm_record_special_symbol): Adjust to section_maps type change.
2827         Allocate arm_per_objfile with new.
2828
2829 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2830
2831         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2832         with the command prefix.
2833
2834 2019-06-25  Tom Tromey  <tom@tromey.com>
2835
2836         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2837         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2838
2839 2019-06-25  Tom Tromey  <tom@tromey.com>
2840
2841         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2842         type.
2843         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2844         protected.
2845
2846 2019-06-25  Tom Tromey  <tom@tromey.com>
2847
2848         * tui/tui-winsource.c
2849         (tui_source_window_base::set_is_exec_point_at): Add check against
2850         LOA_ADDRESS.
2851
2852 2019-06-25  Tom Tromey  <tom@tromey.com>
2853
2854         * tui/tui-source.c (tui_set_source_content): Don't check before
2855         xfree.
2856         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2857
2858 2019-06-25  Tom Tromey  <tom@tromey.com>
2859
2860         * tui/tui-winsource.h (tui_update_source_window_as_is)
2861         (tui_alloc_source_buffer, tui_line_is_displayed)
2862         (tui_addr_is_displayed): Change type of win_info.
2863         * tui/tui-winsource.c (tui_update_source_window_as_is)
2864         (tui_clear_source_content, tui_show_source_line)
2865         (tui_show_source_content, tui_source_window_base::refill)
2866         (tui_source_window_base::set_is_exec_point_at)
2867         (tui_source_window_base::set_is_exec_point_at)
2868         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2869         (tui_alloc_source_buffer, tui_line_is_displayed)
2870         (tui_addr_is_displayed): Change type of win_info.  Update.
2871         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2872         (tui_source_window_base::do_make_visible_with_new_height):
2873         Update.
2874         * tui/tui-source.c (tui_set_source_content)
2875         (tui_set_source_content_nil)
2876         (tui_source_window::do_scroll_vertical): Update.
2877         * tui/tui-layout.c (show_layout): Update.
2878         * tui/tui-disasm.c (tui_set_disassem_content)
2879         (tui_disasm_window::do_scroll_vertical): Update.
2880         * tui/tui-data.h (tui_win_content): Remove.
2881         (struct tui_gen_win_info) <content, content_size>: Remove.
2882         (struct tui_source_element): Add initializers and destructor.
2883         (union tui_which_element, struct tui_win_element): Remove.
2884         (struct tui_source_window_base) <content>: New field.
2885         (struct tui_data_window): Remove destructor.
2886         (tui_alloc_content, tui_free_win_content)
2887         (tui_free_all_source_wins_content): Don't declare.
2888         * tui/tui-data.c (tui_initialize_static_data): Update.
2889         (init_content_element, tui_alloc_content): Remove.
2890         (~tui_gen_win_info): Update.
2891         (~tui_data_window, tui_free_all_source_wins_content)
2892         (tui_free_win_content, free_content, free_content_elements):
2893         Remove.
2894
2895 2019-06-25  Tom Tromey  <tom@tromey.com>
2896
2897         * tui/tui-winsource.h (tui_clear_source_content)
2898         (tui_erase_source_content, tui_show_source_content): Change type
2899         of win_info.
2900         * tui/tui-winsource.c (tui_clear_source_content)
2901         (tui_erase_source_content, tui_show_source_content): Change type
2902         of win_info.
2903         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2904         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2905         win_info.
2906         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2907         win_info.
2908         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2909
2910 2019-06-25  Tom Tromey  <tom@tromey.com>
2911
2912         * tui/tui-winsource.c (tui_clear_source_content)
2913         (tui_source_window_base::set_is_exec_point_at): Update.
2914         * tui/tui-source.c (tui_set_source_content_nil): Update.
2915         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2916         a bool.
2917         * tui/tui-data.c (init_content_element): Update.
2918
2919 2019-06-25  Tom Tromey  <tom@tromey.com>
2920
2921         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2922         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2923         * tui/tui-layout.c (init_and_make_win): Update.
2924         * tui/tui.h (enum tui_win_type): Update.
2925         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2926         tui_win_is_auxillary.
2927         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2928         tui_win_is_auxillary.
2929
2930 2019-06-25  Tom Tromey  <tom@tromey.com>
2931
2932         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2933         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2934         (tui_delete_data_content_windows, tui_display_all_data)
2935         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2936         Update.
2937         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2938         * tui/tui-regs.c (tui_last_regs_line_no)
2939         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2940         (tui_show_registers): Update.
2941         (tui_show_register_group): Return void.  Update.
2942         (tui_display_registers_from, tui_display_reg_element_at_line)
2943         (tui_display_registers_from_line, tui_check_register_values):
2944         Update.
2945         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2946         member.
2947         (struct tui_data_window) <regs_content>: Now a std::vector.
2948         <regs_content_count>: Remove.
2949         (tui_add_content_elements, tui_free_data_content): Don't declare.
2950         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2951         (init_content_element): Remove DATA_WIN case.  Add assert.
2952         (tui_add_content_elements): Remove.
2953         (tui_data_window): Update.
2954         (tui_free_data_content): Remove.
2955         (free_content_elements): Remove DATA_WIN case.
2956
2957 2019-06-25  Tom Tromey  <tom@tromey.com>
2958
2959         * tui/tui-data.c (tui_data_item_window): Update.
2960         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2961         * tui/tui-windata.c (tui_display_all_data)
2962         (tui_display_data_from_line): Update.
2963         (tui_check_data_values): Remove.
2964         * tui/tui-regs.c (tui_show_register_group)
2965         (tui_display_reg_element_at_line): Update.
2966         * tui/tui-hooks.c (tui_register_changed)
2967         (tui_refresh_frame_and_register_information): Call
2968         tui_check_register_values.
2969         * tui/tui-data.h (struct tui_data_window) <data_content,
2970         data_content_count, data_type>: Remove.
2971         (enum tui_data_type): Remove.
2972
2973         * tui/tui-data.c (tui_data_window::clear_detail)
2974         (~tui_data_window): Update.
2975
2976 2019-06-25  Tom Tromey  <tom@tromey.com>
2977
2978         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2979         declare.
2980         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2981         Rename from tui_first_data_item_displayed.  Update.
2982         (tui_data_window::refresh_all)
2983         (tui_data_window::do_scroll_vertical): Update.
2984         * tui/tui-data.h (struct tui_data_window)
2985         <first_data_item_displayed>: Declare new method.
2986
2987 2019-06-25  Tom Tromey  <tom@tromey.com>
2988
2989         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2990         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2991         contents...
2992         (tui_initialize_static_data): ...here.
2993
2994 2019-06-25  Tom Tromey  <tom@tromey.com>
2995
2996         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2997         (tui_display_registers_from, tui_check_register_values): Update.
2998         (tui_display_register): Remove win_info parameter; update.
2999         (tui_get_register): Change type of parameters.
3000         * tui/tui-data.h (struct tui_data_element): Remove.
3001         (union tui_which_element) <data>: Remove.
3002         <data_window>: Change type.
3003         (struct tui_data_item_window): New.
3004         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3005         case.  Add assert.
3006         (~tui_data_item_window): New destructor.
3007         (free_content_elements): Remove DATA_ITEM_WIN case.
3008
3009 2019-06-25  Tom Tromey  <tom@tromey.com>
3010
3011         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3012         Remove.
3013
3014 2019-06-25  Tom Tromey  <tom@tromey.com>
3015
3016         * tui/tui-data.h (struct tui_command_element): Remove.
3017         (union tui_which_element) <command>: Remove.
3018         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3019         assert.
3020         (free_content_elements): Remove CMD_WIN case.
3021
3022 2019-06-25  Tom Tromey  <tom@tromey.com>
3023
3024         * tui/tui-layout.c (tui_set_layout): Update.
3025         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3026         * tui/tui-data.c (layout_def): Update.
3027
3028 2019-06-25  Tom Tromey  <tom@tromey.com>
3029
3030         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3031         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3032         (tui_source_window_base::set_new_height): Update.
3033         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3034         Update.
3035         (tui_set_locator_fullname, tui_set_locator_info)
3036         (tui_show_frame_info): Update.
3037         * tui/tui-source.c (tui_set_source_content)
3038         (tui_source_is_displayed): Update.
3039         * tui/tui-layout.c (show_source_disasm_command, show_data)
3040         (show_source_or_disasm_and_command): Update.
3041         * tui/tui-disasm.c (tui_set_disassem_content)
3042         (tui_get_begin_asm_address): Update.
3043         * tui/tui-data.h (struct tui_locator_element): Remove.
3044         (union tui_which_element) <locator>: Remove.
3045         (struct tui_locator_window): New.
3046         (tui_locator_win_info_ptr): Change return type.
3047         * tui/tui-data.c (_locator): Change type.
3048         (tui_locator_win_info_ptr): Change return type.
3049         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3050         (tui_alloc_content): Add assert.
3051
3052 2019-06-25  Tom Tromey  <tom@tromey.com>
3053
3054         * tui/tui-winsource.c
3055         (tui_exec_info_window::maybe_allocate_content): New method.
3056         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3057         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3058         (make_source_or_disasm_window): Add cast.
3059         * tui/tui-data.h (union tui_which_element) <simple_string>:
3060         Remove.
3061         (struct tui_source_info): New.
3062         (struct tui_source_window_base) <execution_info>: Change type.
3063         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3064         case, and add assert.
3065         (tui_alloc_content): Add assert.
3066
3067 2019-06-25  Tom Tromey  <tom@tromey.com>
3068
3069         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3070         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3071         * tui/tui-data.c (tui_alloc_win_info): Remove.
3072
3073 2019-06-25  Tom Tromey  <tom@tromey.com>
3074
3075         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3076         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3077         can_highlight.
3078
3079 2019-06-25  Tom Tromey  <tom@tromey.com>
3080
3081         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3082         make_visible_with_new_height method.
3083         (tui_win_info::make_visible_with_new_height): New method.
3084         (tui_source_window_base::do_make_visible_with_new_height)
3085         (tui_data_window::do_make_visible_with_new_height)
3086         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3087         (make_visible_with_new_height): Remove.
3088         (tui_resize_all, tui_adjust_win_heights): Use
3089         make_visible_with_new_height method.
3090         * tui/tui-data.h (struct tui_win_info)
3091         <do_make_visible_with_new_height, make_visible_with_new_height>:
3092         New methods.
3093         (struct tui_source_window_base, struct tui_data_window)
3094         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3095         methods.
3096
3097 2019-06-25  Tom Tromey  <tom@tromey.com>
3098
3099         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3100         method.
3101         (update_tab_width): Call update_tab_width method.
3102         * tui/tui-data.h (struct tui_win_info)
3103         (struct tui_source_window_base) <update_tab_width>: New methods.
3104
3105 2019-06-25  Tom Tromey  <tom@tromey.com>
3106
3107         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3108         parameter.
3109         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3110         parameter.
3111         (tui_gen_win_info::make_visible): Update.
3112         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3113         parameter.
3114         * tui/tui-data.h (enum tui_box): New enum.
3115         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3116
3117 2019-06-25  Tom Tromey  <tom@tromey.com>
3118
3119         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3120         init_and_make_win for EXEC_INFO_WIN.
3121         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3122         longer inline.
3123         (struct tui_win_info) <~tui_win_info>: Inline.
3124         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3125         Don't declare.
3126         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3127         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3128         Remove.
3129         (tui_initialize_static_data): Update.
3130         (~tui_gen_win_info): Handle more cleanup here.
3131         (~tui_source_window_base): Delete "execution_info".
3132         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3133
3134 2019-06-25  Tom Tromey  <tom@tromey.com>
3135
3136         * tui/tui-layout.c (make_command_window): Don't set
3137         can_highlight.
3138         (show_source_disasm_command): Call the reset method.
3139         (show_data): Don't set can_highlight.  Call the reset method.
3140         (tui_gen_win_info::reset): Rename from init_gen_win_info
3141         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3142         (show_source_or_disasm_and_command): Call the reset method.
3143         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3144         (struct tui_cmd_window): Set can_highlight.
3145
3146 2019-06-25  Tom Tromey  <tom@tromey.com>
3147
3148         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3149         from make_visible.
3150         (tui_make_visible, tui_make_invisible): Rewrite.
3151         (tui_win_info::make_visible): Remove.
3152         (tui_source_window_base::make_visible): Update.
3153         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3154         method.  Moved from...
3155         (struct tui_win_info) <make_visible>: ...here.
3156
3157 2019-06-25  Tom Tromey  <tom@tromey.com>
3158
3159         * tui/tui-winsource.c
3160         (tui_source_window_base::do_scroll_horizontal): Remove direction
3161         parameter.
3162         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3163         direction parameter.
3164         * tui/tui-win.c (tui_win_info::forward_scroll)
3165         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3166         (tui_win_info::right_scroll): Update.
3167         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3168         direction parameter.
3169         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3170         direction parameter.
3171         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3172         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3173         Remove direction parameter.
3174         (struct tui_source_window_base, struct tui_source_window)
3175         (struct tui_disasm_window, struct tui_data_window)
3176         (struct tui_cmd_window): Update.
3177
3178 2019-06-25  Tom Tromey  <tom@tromey.com>
3179
3180         * tui/tui-winsource.h (tui_set_exec_info_content)
3181         (tui_show_exec_info_content, tui_erase_exec_info_content)
3182         (tui_clear_exec_info_content, tui_update_exec_info): Change
3183         argument to tui_source_window_base.
3184         * tui/tui-winsource.c (tui_set_exec_info_content)
3185         (tui_show_exec_info_content, tui_erase_exec_info_content)
3186         (tui_clear_exec_info_content, tui_update_exec_info): Change
3187         argument to tui_source_window_base.
3188
3189 2019-06-25  Tom Tromey  <tom@tromey.com>
3190
3191         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3192         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3193
3194 2019-06-25  Tom Tromey  <tom@tromey.com>
3195
3196         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3197         check.
3198
3199 2019-06-25  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3202         type to void.
3203         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3204         type to void.
3205         * tui/tui-source.c (tui_set_source_content): Update.
3206         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3207
3208 2019-06-25  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui-win.c (window_name_completer, tui_set_focus)
3211         (tui_all_windows_info): Use name method.
3212         * tui/tui-data.h (struct tui_gen_win_info)
3213         (struct tui_source_window, struct tui_disasm_window)
3214         (struct tui_data_window, struct tui_cmd_window) <name>: New
3215         method.
3216         (tui_win_name): Don't declare.
3217         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3218         (tui_win_name): Remove.
3219
3220 2019-06-25  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui-winsource.h (tui_update_source_window)
3223         (tui_update_source_window_as_is): Change parameter type.
3224         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3225         to be a tui_source_window_base.
3226         (tui_update_source_window_as_is): Likewise.
3227         * tui/tui-win.c (make_visible_with_new_height): Update.
3228
3229 2019-06-25  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui-winsource.c (tui_erase_source_content)
3232         (tui_show_source_content, tui_show_exec_info_content)
3233         (tui_erase_exec_info_content): Use refresh_window method.
3234         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3235         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3236         from tui_refresh_win.
3237         (tui_data_window::refresh_window): New method.
3238         (tui_win_info::refresh, tui_source_window_base::refresh)
3239         (tui_refresh_all): Use refresh_window method.
3240         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3241         method.
3242         * tui/tui-regs.c (tui_display_register): Call refresh_window
3243         method.
3244         * tui/tui-layout.c (show_source_disasm_command)
3245         (show_source_or_disasm_and_command): Call refresh_window method.
3246         * tui/tui-data.h (struct tui_gen_win_info)
3247         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3248         New method.
3249
3250 2019-06-25  Tom Tromey  <tom@tromey.com>
3251
3252         * tui/tui.c (tui_rl_other_window, tui_enable)
3253         (tui_is_window_visible, tui_get_command_dimension): Update.
3254         * tui/tui-winsource.c (tui_update_source_window_as_is)
3255         (tui_clear_source_content, tui_erase_source_content)
3256         (tui_show_source_line, tui_source_window_base::refill)
3257         (tui_source_window_base::do_scroll_horizontal)
3258         (tui_source_window_base::set_is_exec_point_at)
3259         (tui_update_breakpoint_info, tui_set_exec_info_content)
3260         (tui_alloc_source_buffer, tui_line_is_displayed)
3261         (tui_addr_is_displayed): Update.
3262         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3263         (tui_check_and_display_highlight_if_needed)
3264         (tui_win_info::make_visible, tui_win_info::refresh)
3265         (tui_refresh_all): Update.
3266         * tui/tui-windata.c (tui_first_data_item_displayed)
3267         (tui_delete_data_content_windows, tui_erase_data_content)
3268         (tui_display_all_data, tui_data_window::refresh_all)
3269         (tui_check_data_values): Update.
3270         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3271         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3272         (tui_win_info::backward_scroll, tui_refresh_all_win)
3273         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3274         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3275         (tui_source_window_base::set_new_height)
3276         (tui_data_window::set_new_height)
3277         (make_invisible_and_set_new_height)
3278         (make_visible_with_new_height, new_height_ok)
3279         (parse_scrolling_args): Update.
3280         * tui/tui-stack.c (tui_show_frame_info): Update.
3281         * tui/tui-source.c (tui_set_source_content)
3282         (tui_set_source_content_nil, tui_source_is_displayed)
3283         (tui_source_window::do_scroll_vertical): Update.
3284         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3285         (tui_display_registers_from, tui_display_reg_element_at_line)
3286         (tui_check_register_values, tui_reg_command): Update.
3287         * tui/tui-layout.c (tui_default_win_height)
3288         (show_source_disasm_command, show_data, init_and_make_win)
3289         (show_source_or_disasm_and_command): Update.
3290         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3291         (tui_redisplay_readline, tui_mld_flush)
3292         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3293         (tui_getc): Update.
3294         * tui/tui-disasm.c (tui_set_disassem_content)
3295         (tui_disasm_window::do_scroll_vertical): Update.
3296         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3297         Now virtual.
3298         (struct tui_win_info): Derive from tui_gen_win_info.
3299         <~tui_win_info>: Mark as override.
3300         <generic>: Remove member.
3301         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3302         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3303         (~tui_data_window, ~tui_win_info)
3304         (tui_free_all_source_wins_content): Update.
3305         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3306
3307 2019-06-25  Tom Tromey  <tom@tromey.com>
3308
3309         * tui/tui-layout.c (init_and_make_win): Use new.
3310         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3311         destructor, initializers.
3312         (tui_alloc_generic_win_info): Don't declare.
3313         * tui/tui-data.c (_locator): Add argument to constructor.
3314         (source_win, disasm_win): New globals.
3315         (exec_info): Remove.
3316         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3317         Update.
3318         (tui_alloc_generic_win_info): Remove.
3319         (init_content_element): Use new.
3320         (tui_win_info::tui_win_info): Update.
3321         (free_content_elements) <case DATA_WIN>: Use delete.
3322
3323 2019-06-25  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3326         * tui/tui-windata.c (tui_first_data_item_displayed)
3327         (tui_delete_data_content_windows): Update.
3328         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3329         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3330         (tui_display_registers_from, tui_check_register_values): Update.
3331         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3332         pointer.
3333         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3334         window.
3335         (tui_free_data_content): Update.
3336         (free_content_elements) <case DATA_WIN>: Free the window.
3337
3338 2019-06-25  Tom Tromey  <tom@tromey.com>
3339
3340         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3341         Update.
3342         * tui/tui-layout.c (make_command_window)
3343         (show_source_disasm_command, show_data, init_and_make_win)
3344         (show_source_or_disasm_and_command): Update.
3345         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3346         method.
3347         <can_highight, is_highlighted>: Now bool.
3348         (tui_set_win_highlight): Don't declare.
3349         * tui/tui-data.c (tui_set_win_highlight): Remove.
3350
3351 2019-06-25  Tom Tromey  <tom@tromey.com>
3352
3353         * tui/tui-wingeneral.c (make_visible): Remove check of window
3354         type.
3355
3356 2019-06-25  Tom Tromey  <tom@tromey.com>
3357
3358         * tui/tui-win.c (tui_win_info::max_height)
3359         (tui_cmd_window::max_height): New methods.
3360         (new_height_ok): Call max_height.
3361         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3362         <max_height>: New method.
3363
3364 2019-06-25  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui-win.c (tui_source_window_base::set_new_height)
3367         (tui_data_window::set_new_height): New methods.
3368         (make_invisible_and_set_new_height): Call set_new_height method.
3369         * tui/tui-data.h (struct tui_win_info)
3370         (struct tui_source_window_base, struct tui_data_window)
3371         <set_new_height>: New method.
3372
3373 2019-06-25  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3376         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3377         tui_refresh_data_win.
3378         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3379         method.
3380         (tui_refresh_all_win): Call the refresh_all method.
3381         (tui_set_focus): Likewise.
3382         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3383         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3384         Likewise.
3385
3386 2019-06-25  Tom Tromey  <tom@tromey.com>
3387
3388         * tui/tui-winsource.h (tui_refill_source_window)
3389         (tui_set_is_exec_point_at): Don't declare.
3390         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3391         (tui_source_window_base::refill): Rename from
3392         tui_refill_source_window.
3393         (tui_source_window_base::do_scroll_horizontal): Update.
3394         (tui_source_window_base::set_is_exec_point_at): Rename from
3395         tui_set_is_exec_point_at.
3396         (tui_update_all_breakpoint_info): Update.
3397         * tui/tui-stack.c (tui_show_frame_info): Update.
3398         * tui/tui-layout.c (show_data): Add cast.
3399         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3400         * tui/tui-data.h (struct tui_source_window_base) <refill,
3401         set_is_exec_point_at>: New methods.
3402         (tui_source_windows, tui_add_to_source_windows): Update types.
3403         (tui_add_to_source_windows): Remove redundant declaration.
3404         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3405         (tui_source_windows): Change return type.
3406         (tui_clear_source_windows_detail): Update.
3407         (tui_add_to_source_windows): Change type of parameter.
3408         (tui_free_all_source_wins_content): Update.
3409
3410 2019-06-25  Tom Tromey  <tom@tromey.com>
3411
3412         * tui/tui-wingeneral.c (tui_win_info::refresh)
3413         (tui_source_window_base::refresh): New methods.
3414         (tui_refresh_all): Call the refresh method.
3415         * tui/tui-data.h (struct tui_win_info)
3416         (struct tui_source_window_base) <refresh>: New method.
3417
3418 2019-06-25  Tom Tromey  <tom@tromey.com>
3419
3420         * tui/tui.h (tui_is_window_visible): Return bool.
3421         * tui/tui.c (tui_is_window_visible): Return bool.
3422         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3423         (tui_make_visible, tui_make_invisible)
3424         (tui_win_info::make_visible)
3425         (tui_source_window_base::make_visible, make_all_visible)
3426         (tui_make_all_visible, tui_make_all_invisible): Update.
3427         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3428         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3429         bool.
3430         (struct tui_win_info, struct tui_source_window_base)
3431         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3432         * tui/tui-data.c (tui_init_generic_part): Update.
3433
3434 2019-06-25  Tom Tromey  <tom@tromey.com>
3435
3436         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3437         (tui_source_window_base::make_visible): New methods.
3438         (make_all_visible): Make method call.
3439         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3440         (struct tui_source_window_base, struct tui_cmd_window): Override
3441         make_visible.
3442         (tui_win_is_source_type): Don't declare.
3443         * tui/tui-data.c (tui_win_is_source_type): Remove.
3444
3445 2019-06-25  Tom Tromey  <tom@tromey.com>
3446
3447         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3448         NULL check.
3449
3450 2019-06-25  Tom Tromey  <tom@tromey.com>
3451
3452         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3453         Inline constructor.  Add initializers for members.
3454         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3455         constructors; now inline in class.
3456
3457 2019-06-25  Tom Tromey  <tom@tromey.com>
3458
3459         * tui/tui-regs.c (tui_show_registers): Update.
3460         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3461         bool.
3462         * tui/tui-data.c (tui_data_window::clear_detail)
3463         (tui_data_window): Update.
3464
3465 2019-06-25  Tom Tromey  <tom@tromey.com>
3466
3467         * tui/tui-windata.c (tui_display_all_data)
3468         (tui_display_data_from_line, tui_display_data_from)
3469         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3470         Update.
3471         * tui/tui-regs.c (tui_last_regs_line_no)
3472         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3473         (tui_show_registers, tui_show_register_group)
3474         (tui_display_registers_from, tui_display_reg_element_at_line)
3475         (tui_display_registers_from_line, tui_check_register_values)
3476         (tui_reg_next, tui_reg_prev): Update.
3477         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3478         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3479         tui_data_window.
3480         (struct tui_win_info) <detail>: Remove.  Add new fields from
3481         tui_data_info.
3482         (TUI_DATA_WIN): Add cast.
3483         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3484         (~tui_data_window): Simplify.
3485
3486 2019-06-25  Tom Tromey  <tom@tromey.com>
3487
3488         * tui/tui-layout.c (show_source_disasm_command)
3489         (show_source_or_disasm_and_command): Update.
3490         * tui/tui-io.c (update_cmdwin_start_line)
3491         (tui_redisplay_readline): Update.
3492         * tui/tui-data.h (struct tui_command_info): Remove.
3493         (struct tui_win_info) <detail>: Remove command_info member.
3494         (struct tui_data_window) <start_line>: New member, from
3495         tui_command_info.
3496         (TUI_CMD_WIN): Add casts.
3497
3498 2019-06-25  Tom Tromey  <tom@tromey.com>
3499
3500         * tui/tui-winsource.c (tui_update_source_window)
3501         (tui_refill_source_window)
3502         (tui_source_window_base::do_scroll_horizontal)
3503         (tui_update_breakpoint_info, tui_set_exec_info_content)
3504         (tui_show_exec_info_content, tui_erase_exec_info_content)
3505         (tui_clear_exec_info_content): Update.
3506         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3507         Update.
3508         * tui/tui-win.c (make_invisible_and_set_new_height)
3509         (make_visible_with_new_height): Update.
3510         * tui/tui-source.c (tui_set_source_content)
3511         (tui_show_symtab_source): Update.
3512         * tui/tui-layout.c (extract_display_start_addr)
3513         (show_source_disasm_command, show_data)
3514         (make_source_or_disasm_window)
3515         (show_source_or_disasm_and_command): Update.
3516         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3517         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3518         "gdbarch".
3519         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3520         to tui_source_window_base.
3521         (struct tui_win_info) <detail>: Remove source_info member.
3522         (struct tui_source_window_base) <has_locator>: Inline.
3523         Move contents from tui_source_info; rename has_locator member to
3524         m_has_locator.
3525         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3526         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3527         header file.
3528         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3529         Simplify.
3530         (tui_free_all_source_wins_content): Cast to
3531         tui_source_window_base.
3532
3533 2019-06-25  Tom Tromey  <tom@tromey.com>
3534
3535         * tui/tui-win.c (make_invisible_and_set_new_height)
3536         (make_visible_with_new_height): Call has_locator method.
3537         * tui/tui-layout.c (show_source_disasm_command, show_data)
3538         (show_source_or_disasm_and_command): Update for bool change.
3539         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3540         (tui_win_info) <has_locator>: New method.
3541         (struct tui_source_window_base) <has_locator>: New method.
3542         (tui_win_has_locator): Don't declare.
3543         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3544         from tui_win_has_locator.
3545         (tui_source_window_base): Use false, not FALSE.
3546
3547 2019-06-25  Tom Tromey  <tom@tromey.com>
3548
3549         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3550         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3551         clear_detail method directly.
3552         (tui_clear_win_detail): Remove.
3553
3554 2019-06-25  Tom Tromey  <tom@tromey.com>
3555
3556         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3557         "this", not TUI_DISASM_WIN.
3558
3559 2019-06-25  Tom Tromey  <tom@tromey.com>
3560
3561         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3562         declare.
3563         * tui/tui-winsource.c
3564         (tui_source_window_base::do_scroll_horizontal): Rename from
3565         tui_horizontal_source_scroll.
3566         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3567         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3568         from tui_vertical_data_scroll.
3569         * tui/tui-win.h (tui_scroll): Don't declare.
3570         * tui/tui-win.c (tui_win_info::forward_scroll)
3571         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3572         (tui_win_info::right_scroll): Rename and update.
3573         (tui_scroll_forward_command, tui_scroll_backward_command)
3574         (tui_scroll_left_command, tui_scroll_right_command): Update.
3575         (tui_scroll): Remove.
3576         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3577         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3578         from tui_vertical_source_scroll.
3579         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3580         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3581         from tui_vertical_disassem_scroll.
3582         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3583         do_scroll_horizontal>: New methods.
3584         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3585         Likewise.
3586         (struct tui_source_window_base): Add do_scroll_horizontal.
3587         (struct tui_source_window, struct tui_disasm_window): Add
3588         do_scroll_vertical.
3589         (struct tui_data_window, struct tui_cmd_window): Add
3590         do_scroll_horizontal and do_scroll_vertical.
3591         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3592
3593 2019-06-25  Tom Tromey  <tom@tromey.com>
3594
3595         * tui/tui-data.h (struct tui_source_window_base): New struct.
3596         (struct tui_source_window): Derive from tui_source_window_base.
3597         (struct tui_disasm_window): New struct.
3598         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3599         from tui_source_window::clear_detail.
3600         (tui_source_window_base): Rename from tui_source_window.
3601         (~tui_source_window_base): Rename from ~tui_source_window.
3602         (tui_alloc_win_info): Create a tui_disasm_window.
3603
3604 2019-06-25  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui-data.h (struct tui_source_window)
3607         (struct tui_data_window): Declare destructors.
3608         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3609         destructors.
3610         (tui_win_info): Simplify.
3611
3612 2019-06-25  Tom Tromey  <tom@tromey.com>
3613
3614         * tui/tui-winsource.c (tui_display_main)
3615         (tui_update_source_windows_with_addr)
3616         (tui_update_all_breakpoint_info): Update.
3617         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3618         (new_height_ok, parse_scrolling_args): Update.
3619         * tui/tui-stack.c (tui_show_frame_info): Update.
3620         * tui/tui-data.h (struct tui_list): Remove.
3621         (tui_source_windows): Return a reference to a std::vector.
3622         * tui/tui-data.c (source_windows): Now a std::vector.
3623         (tui_source_windows): Change return type.
3624         (tui_clear_source_windows): Rewrite.
3625         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3626         (tui_free_all_source_wins_content): Rewrite.
3627
3628 2019-06-25  Tom Tromey  <tom@tromey.com>
3629
3630         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3631         (struct tui_data_window, struct tui_cmd_window): Declare
3632         clear_detail method.
3633         * tui/tui-data.c (tui_source_window::clear_detail)
3634         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3635         methods.
3636         (tui_clear_win_detail): Simplify.
3637
3638 2019-06-25  Tom Tromey  <tom@tromey.com>
3639
3640         * tui/tui-layout.c (make_source_window, make_disasm_window)
3641         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3642         Return the new window.
3643         (show_source_disasm_command, show_data)
3644         (show_source_or_disasm_and_command): Update.
3645
3646 2019-06-25  Tom Tromey  <tom@tromey.com>
3647
3648         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3649         parameter.  Return the new window.
3650         (show_source_disasm_command): Update and remove NULL check.
3651         (show_source_or_disasm_and_command): Update.
3652
3653 2019-06-25  Tom Tromey  <tom@tromey.com>
3654
3655         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3656
3657 2019-06-25  Tom Tromey  <tom@tromey.com>
3658
3659         * tui/tui-data.h (struct tui_win_info): Make constructor
3660         protected.  Make destructor virtual.  Add initializers.
3661         (tui_source_window, tui_data_window, tui_cmd_window): New
3662         classes.
3663         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3664         constructor.  Add "type" parameter.
3665         (tui_source_window, tui_data_window, tui_cmd_window): New
3666         constructors.
3667         (tui_alloc_win_info): Instantiate the appropriate subclass.
3668
3669 2019-06-25  Tom Tromey  <tom@tromey.com>
3670
3671         * tui/tui-win.c (tui_resize_all): Use delete.
3672         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3673         destructor.
3674         (tui_free_window): Don't declare.
3675         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3676         Update.
3677
3678 2019-06-25  Tom Tromey  <tom@tromey.com>
3679
3680         * tui/tui-data.h (struct tui_win_info): Add constructor.
3681         * tui/tui-data.c (tui_alloc_win_info): Use new.
3682         (tui_free_window): Use delete.
3683
3684 2019-06-22  Tom Tromey  <tom@tromey.com>
3685
3686         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3687         declare.
3688         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3689
3690 2019-06-22  Tom Tromey  <tom@tromey.com>
3691
3692         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3693         declare.
3694         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3695
3696 2019-06-22  Tom de Vries  <tdevries@suse.de>
3697
3698         * dwarf2read.c (create_addrmap_from_aranges)
3699         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3700         instead of '%zu'.
3701
3702 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3703
3704         * dwarf2read.h (dwarf2_section_info_def): Remove.
3705         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3706         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3707         std::vector<dwarf2_section_info>.
3708         (struct dwo_file) <~dwo_file>: Remove.
3709         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3710         types field.
3711         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3712         (dwarf2_read_debug_names): Likewise.
3713         (create_debug_types_hash_table): Change parameter type to
3714         array_view, adjust code accordingly.
3715         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3716         (partial_die_info::fixup): Likewise.
3717         (determine_prefix): Likewise.
3718         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3719
3720 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3721
3722         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3723         gdb_bfd_ref_ptr.
3724         <~dwo_file>: Remove call to gdb_bfd_unref.
3725         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3726         gdb_bfd_ref_ptr::get.
3727
3728 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3729
3730         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3731         type to htab_up.
3732         * dwarf2read.c (struct dwo_file): Initialize fields.
3733         <~dwo_file>: New.
3734         (free_dwo_file): Remove, move content to ~dwo_file.
3735         (struct dwo_file_deleter): Remove.
3736         (dwo_file_up>: Remove custom deleter.
3737         (free_dwo_files): Remove.
3738         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3739         dwo_files.
3740         (process_skeletonless_type_units): Call unique_ptr::get.
3741         (allocate_dwo_file_hash_table): Add deleter to created hash
3742         table.  Change return type to htab_up.
3743         (lookup_dwo_file_slot): Don't memset dwo_file, call
3744         unique_ptr::get.
3745         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3746         (create_dwo_unit_in_dwp_v2): Likewise.
3747         (open_and_init_dwo_file): Likewise.
3748         (free_dwo_file_from_slot): Remove.
3749
3750 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3751
3752         * dwarf2read.h (struct dwarf2_section_info) <readin,
3753         is_virtual>: Change type to bool.
3754         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3755         true instead of 1.
3756
3757 2019-06-19  Tom Tromey  <tom@tromey.com>
3758
3759         * tui/tui-data.h (tui_init_content_element): Don't declare.
3760
3761 2019-06-19  Tom Tromey  <tom@tromey.com>
3762
3763         * tui/tui-data.h (tui_init_win_info): Don't declare.
3764
3765 2019-06-19  Tom de Vries  <tdevries@suse.de>
3766
3767         * dwarf2read.h (abstract_to_concrete): Change type to
3768         std::unordered_map<sect_offset, std::vector<sect_offset>,
3769         gdb::hash_enum<sect_offset>>.
3770
3771 2019-06-19  Tom Tromey  <tromey@adacore.com>
3772
3773         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3774         EVAL_AVOID_SIDE_EFFECTS specially.
3775
3776 2019-06-19  Tom Tromey  <tromey@adacore.com>
3777
3778         * source-cache.c (highlighter): New global.
3779         (source_cache::get_source_lines): Create a highlighter on demand.
3780
3781 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3782
3783         * defs.h (deprecated_interactive_hook): Delete declaration.
3784         * interps.c (clear_interpreter_hooks): Remove use of
3785         deprecated_interactive_hook.
3786         * top.c (deprecated_interactive_hook): Delete definition.
3787         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3788
3789 2019-06-18  Tom de Vries  <tdevries@suse.de>
3790
3791         PR gdb/24515
3792         * dwarf2read.h (abstract_to_concrete): Change type from
3793         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3794         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3795         * dwarf2read.c (read_variable): Update.
3796         (dwarf2_fetch_die_loc_sect_off): Update.
3797
3798 2019-06-17  Tom de Vries  <tdevries@suse.de>
3799
3800         PR gdb/24617
3801         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3802         accessing parent[parent_len - 1].
3803
3804 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3805
3806         PR gdb/24364
3807         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3808         call dtrace_process_dof with NULL dof.
3809
3810 2019-06-16  Tom de Vries  <tdevries@suse.de>
3811
3812         PR gdb/24445
3813         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3814
3815 2019-06-16  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3818         (make_all_visible): Use address of member.
3819
3820 2019-06-16  Tom Tromey  <tom@tromey.com>
3821
3822         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3823         (tui_free_window, free_content, free_content_elements): Remove
3824         unnecessary cast.
3825         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3826         cast.
3827         * tui/tui-regs.c (tui_show_register_group)
3828         (tui_display_registers_from, tui_display_reg_element_at_line):
3829         Remove unnecessary cast.
3830
3831 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * linux-nat.c (normal_mask): Delete.
3834         (_initialize_linux_nat): Don't initialise normal_mask.
3835
3836 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3837
3838         PR gdb/24445
3839         * dwarf-index-write.h (write_psymtabs_to_index): Add
3840         dwz_basename parameter.
3841         * dwarf-index-write.c (write_gdbindex): Move file writing to
3842         write_gdbindex_1.  Change return type void.
3843         (assert_file_size): Move up, remove filename parameter.
3844         (write_gdbindex_1): New function.
3845         (write_debug_names): Change return type to void, call
3846         assert_file_size.
3847         (struct index_wip_file): New struct.
3848         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3849         file logic to index_wip_file.  Write index for dwz file if
3850         needed.
3851         (save_gdb_index_command): Pass basename of dwz file, if present.
3852         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3853         build-id of dwz file, if present.
3854         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3855         (dwarf2_get_dwz_file): Likewise.
3856         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3857         (dwarf2_get_dwz_file): Likewise.
3858
3859 2019-06-16  Tom Tromey  <tom@tromey.com>
3860
3861         * coffread.c (process_coff_symbol): Use xstrdup.
3862         * value.c (create_internalvar): Use xstrdup.
3863
3864 2019-06-16  Tom Tromey  <tom@tromey.com>
3865
3866         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3867         * breakpoint.c (stopin_command, stopat_command)
3868         (until_break_command, decode_location_default): Remove unnecessary
3869         cast.
3870         * utils.c (subset_compare): Remove unnecessary cast.
3871         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3872         cast.
3873         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3874         cast.
3875         * infcmd.c (path_command): Remove unnecessary cast.
3876         * coffread.c (decode_type): Remove unnecessary cast.
3877         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3878         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3879         * tui/tui-stack.c (tui_show_locator_content)
3880         (tui_show_frame_info): Remove unnecessary cast.
3881         * tui/tui-win.c (tui_scroll_forward_command)
3882         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3883         (parse_scrolling_args): Remove unnecessary cast.
3884         * tui/tui-data.c (init_win_info, tui_del_window)
3885         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3886         (free_content_elements): Remove unnecessary cast.
3887         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3888         unnecessary cast.
3889         * tui/tui-source.c (tui_set_source_content)
3890         (tui_vertical_source_scroll): Remove unnecessary cast.
3891         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3892         cast.
3893         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3894         * tui/tui-regs.c (tui_display_registers_from)
3895         (tui_display_register): Remove unnecessary cast.
3896         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3897         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3898         (make_visible): Remove unnecessary cast.
3899         * tui/tui-winsource.c (tui_erase_source_content)
3900         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3901         unnecessary cast.
3902         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3903         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3904         * stabsread.c (read_type, read_array_type, read_range_type):
3905         Remove unnecessary cast.
3906         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3907         (parse_symbol, parse_type, upgrade_type, parse_external)
3908         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3909         unnecessary cast.
3910         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3911
3912 2019-06-16  Tom Tromey  <tom@tromey.com>
3913
3914         * tui/tui-data.c (tui_alloc_generic_win_info)
3915         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3916         checks.
3917
3918 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3919             Andrew Burgess  <andrew.burgess@embecosm.com>
3920
3921         * f-typeprint.c (f_print_type): Don't return early for not
3922         associated or not allocated types.
3923         (f_type_print_varspec_suffix): Add print_rank parameter and print
3924         ranks of array types in case they dangling.
3925         (f_type_print_base): Add print_rank parameter.
3926
3927 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3928
3929         * NEWS: Mention new MI commands.
3930         * break-catch-throw.c (enum exception_event_kind): Move to
3931         breakpoint.h.
3932         (print_mention_exception_catchpoint): Output text as a single
3933         message.
3934         (catch_exception_command_1): Rename to...
3935         (catch_exception_event): ...this, make non-static, update header
3936         command, and change some parameter types.
3937         (catch_catch_command): Update for changes to
3938         catch_exception_command_1.
3939         (catch_throw_command): Likewise.
3940         (catch_rethrow_command): Likewise.
3941         * breakpoint.c (enum exception_event_kind): Delete.
3942         * breakpoint.h (enum exception_event_kind): Moved here from
3943         break-catch-throw.c.
3944         (catch_exception_event): Declare.
3945         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3946         (mi_cmd_catch_throw): New function.
3947         (mi_cmd_catch_rethrow): New function.
3948         (mi_cmd_catch_catch): New function.
3949         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3950         'catch-catch' entries.
3951         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3952         (mi_cmd_catch_rethrow): Declare.
3953         (mi_cmd_catch_catch): Declare.
3954
3955 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3956
3957         * annotate.c (annotate_source_line): Change return type to void,
3958         update implementation to match.
3959         * annotate.h (annotate_source_line): Change return type to void,
3960         update header comment.
3961         * stack.c (print_frame_info): Don't change what frame information
3962         is printed based on whether annotations are on or not.
3963
3964 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3965
3966         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3967         (annotate_source): Make static.
3968         (annotate_source_line): Moved from source.c and renamed from
3969         identify_source_line.  Update the return type.
3970         * annotate.h (annotate_source): Delete declaration.
3971         (annotate_source_line): Declaration moved from source.h, and
3972         renamed from identify_source_line.  Return type updated.
3973         * source.c (identify_source_line): Moved to annotate.c and renamed
3974         to annotate_source_line.
3975         (info_line_command): Remove check of annotation_level.
3976         * source.h (identify_source_line): Move declaration to annotate.h
3977         and rename to annotate_source_line.
3978         * stack.c: Add 'annotate.h' include.
3979         (print_frame_info): Remove check of annotation_level before
3980         calling annotate_source_line.
3981
3982 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3983
3984         * source-cache.c (source_cache::get_plain_source_lines): Use
3985         open_source_file_with_line_charpos instead of just
3986         open_source_file, remove call to find_source_lines.
3987         (source_cache::get_source_lines): Likewise.
3988         * source.c (find_source_lines): Make static.
3989         (get_filename_and_charpos): Renamed into...
3990         (open_source_file_with_line_charpos): ..this along with changes to
3991         return a scoped_fd, and some other minor clean ups.
3992         (identify_source_line): Use open_source_file_with_line_charpos.
3993         (search_command_helper): Use open_source_file_with_line_charpos
3994         instead of just open_source_file, remove call to
3995         find_source_lines.
3996         * source.h (open_source_file_with_line_charpos): Declare new
3997         function.
3998         (find_source_lines): Delete declaration.
3999
4000 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4001
4002         * source.c (get_filename_and_charpos): Remove fullname
4003         parameter.
4004         (identify_source_line): Update call to get_filename_and_charpos.
4005
4006 2019-06-14  Tom Tromey  <tromey@adacore.com>
4007
4008         PR gdb/24502:
4009         * ui-style.h (skip_ansi_escape): Update comment.
4010         * ui-file.h (class no_terminal_escape_file): New class.
4011         * ui-file.c (no_terminal_escape_file::write)
4012         (no_terminal_escape_file::puts): New methods.
4013         * cli/cli-logging.c (handle_redirections): Use
4014         no_terminal_escape_file.
4015
4016 2019-06-14  Tom Tromey  <tromey@adacore.com>
4017
4018         * NEWS: Move convenience variable news above Python news.
4019
4020 2019-06-14  Tom Tromey  <tom@tromey.com>
4021
4022         * gnulib: Move directory to top-level.
4023         * configure.ac: Don't configure gnulib.
4024         * configure: Rebuild.
4025         * common/common-defs.h: Use new path to gnulib.
4026         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4027         (GNULIB_H): Remove.
4028         (INCGNU): Look in new gnulib location.
4029         (HFILES_NO_SRCDIR): Remove gnulib files.
4030         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4031         (generated_files): Remove GNULIB_H.
4032         ($(LIBGNU), all-lib): Remove targets.
4033         (distclean): Don't mention GNULIB_BUILDDIR.
4034         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4035
4036 2019-06-14  Tom Tromey  <tromey@adacore.com>
4037
4038         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4039         Warn if symbol file does not provide any symbols.
4040
4041 2019-06-14  Tom Tromey  <tromey@adacore.com>
4042
4043         * source.c (find_and_open_source): Respect basenames_may_differ.
4044
4045 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4046
4047         * annotate.c (annotate_breakpoints_invalid): Make use of
4048         scoped_restore_terminal_state.
4049         (annotate_frames_invalid): Likewise.
4050
4051 2019-06-14  Tom Tromey  <tromey@adacore.com>
4052
4053         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4054         allow assignment to an internalvar.
4055
4056 2019-06-14  Tom Tromey  <tromey@adacore.com>
4057
4058         * ada-lex.l: Allow "_" in attribute names.
4059
4060 2019-06-14  Tom Tromey  <tromey@adacore.com>
4061
4062         PR gdb/24653:
4063         * regcache.c (registers_changed): Don't call alloca.
4064         * top.c (execute_command): Don't call alloca.
4065
4066 2019-06-13  Pedro Alves  <palves@redhat.com>
4067
4068         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4069         'expression'.  When parsing an expression, error out if there's
4070         junk after "unlimited".
4071         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4072         (do_set_command): Adjust calls to is_unlimited_literal.
4073
4074 2019-06-13  Pedro Alves  <palves@redhat.com>
4075
4076         * compile/compile.c (make_compile_options_def_group): Add braces
4077         around array_view initializer.
4078         * thread.c (make_thread_apply_all_options_def_group)
4079         (make_thread_apply_all_options_def_group): Likewise.
4080
4081 2019-06-13  Pedro Alves  <palves@redhat.com>
4082
4083         * NEWS (New commands): Mention "maint test-options
4084         require-delimiter", "maint test-options unknown-is-error", "maint
4085         test-options unknown-is-operand" and "maint show
4086         test-options-completion-result".
4087         (New command options, command completion): New section.
4088         (Completion improvements): New section.
4089         Mention that you can abbreviate "unlimited".
4090
4091 2019-06-13  Pedro Alves  <palves@redhat.com>
4092
4093         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4094         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4095         * unittests/cli-utils-selftests.c (test_parse_flags)
4096         (test_parse_flags_qcs): Delete.
4097         (test_cli_utils): Don't call deleted functions.
4098
4099 2019-06-13  Pedro Alves  <palves@redhat.com>
4100
4101         * thread.c: Include "cli/cli-option.h".
4102         (tp_array_compar_ascending): Global.
4103         (tp_array_compar): Delete function.
4104         (tp_array_compar_ascending, tp_array_compar_descending): New
4105         functions.
4106         (ascending_option_def, qcs_flag_option_def)
4107         (thr_qcs_flags_option_defs)
4108         (make_thread_apply_all_options_def_group)
4109         (make_thread_apply_options_def_group): New.
4110         (thread_apply_all_command): Use gdb::option::process_options.
4111         (thread_apply_command_completer)
4112         (thread_apply_all_command_completer): New.
4113         (thread_apply_command): Use gdb::option::process_options.
4114         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4115         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4116         to generate help text of "thread apply".  Adjust "taas"'s help.
4117         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4118         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4119
4120 2019-06-13  Pedro Alves  <palves@redhat.com>
4121
4122         * thread.c (thread_apply_command): Check for invalid TID with
4123         isdigit instead of !isalpha.
4124
4125 2019-06-13  Pedro Alves  <palves@redhat.com>
4126
4127         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4128         (validate_flags_qcs): New.
4129         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4130         (validate_flags_qcs): Declare.
4131         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4132         (make_frame_apply_options_def_group): New.
4133         (frame_apply_command_count): Process options with
4134         gdb::option::process_options.
4135         (frame_apply_completer): New.
4136         (frame_apply_level_completer, frame_apply_all_completer)
4137         (frame_apply_completer): New.
4138         (_initialize_stack): Update help of "frame apply", "frame apply
4139         level", "frame apply all" and "faas" to mention supported options
4140         and install command completers.
4141         * stack.h (frame_apply_all_completer): Declare.
4142         * thread.c: Include "stack.h".
4143         (tfaas_command): Add "--".
4144         (_initialize_thread): Update help "tfaas" to mention supported
4145         options and install command completer.
4146
4147 2019-06-13  Pedro Alves  <palves@redhat.com>
4148
4149         * completer.c (complete_nested_command_line): New.
4150         (gdb_completion_word_break_characters_throw): Add assertion.
4151         * completer.h (complete_nested_command_line): Declare.
4152
4153 2019-06-13  Pedro Alves  <palves@redhat.com>
4154
4155         * stack.c (parse_backtrace_qualifiers): New.
4156         (backtrace_command): Use it.
4157         (backtrace_command_completer): Complete on qualifiers.
4158
4159 2019-06-13  Pedro Alves  <palves@redhat.com>
4160
4161         * frame.c: Include "cli/cli-option.h.
4162         (user_set_backtrace_options): New.
4163         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4164         Delete.
4165         (get_prev_frame): Adjust.
4166         (boolean_option_def, uinteger_option_def)
4167         (set_backtrace_option_defs): New.
4168         (_initialize_frame): Adjust and use
4169         gdb::option::add_setshow_cmds_for_options to install "set
4170         backtrace past-main" and "set backtrace past-entry".
4171         * frame.h: Include "cli/cli-option.h".
4172         (struct frame_print_options): Forward declare.
4173         (print_frame_arguments_all, print_frame_arguments_scalars)
4174         (print_frame_arguments_none): Declare.
4175         (print_entry_values): Delete declaration.
4176         (struct frame_print_options, user_frame_print_options): New.
4177         (struct set_backtrace_options): New.
4178         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4179         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4180         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4181         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4182         (list_args_or_locals): Add frame_print_options parameter.
4183         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4184         * python/py-framefilter.c (enumerate_args): Pass down
4185         USER_FRAME_PRINT_OPTIONS.
4186         * stack.c: Include "cli/cli-option.h".
4187         (print_frame_arguments_all, print_frame_arguments_scalars)
4188         (print_frame_arguments_none): Declare.
4189         (print_raw_frame_arguments, print_entry_values): Delete.
4190         (user_frame_print_options): New.
4191         (boolean_option_def, enum_option_def, frame_print_option_defs):
4192         New.
4193         (struct backtrace_cmd_options): New.
4194         (bt_flag_option_def): New.
4195         (backtrace_command_option_defs): New.
4196         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4197         (print_frame_arg, read_frame_arg, print_frame_args)
4198         (print_frame_info, print_frame): Add frame_print_options parameter
4199         and use it.
4200         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4201         (backtrace_command_1): Add frame_print_options and
4202         backtrace_cmd_options parameters and use them.
4203         (make_backtrace_options_def_group): New.
4204         (backtrace_command): Process command options with
4205         gdb::option::process_options.
4206         (backtrace_command_completer): New.
4207         (_initialize_stack): Extend "backtrace"'s help to mention
4208         supported options.  Install completer for "backtrace".
4209         Install some settings commands with add_setshow_cmds_for_options.
4210
4211 2019-06-13  Pedro Alves  <palves@redhat.com>
4212
4213         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4214         and that "set/show print raw frame-arguments" are now deprecated.
4215
4216         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4217         command.
4218         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4219         * stack.c (_initialize_stack): Install "set/show print
4220         raw-frame-arguments", and deprecate "set/show print raw
4221         frame-arguments".
4222         * valprint.c (_initialize_valprint): Deprecate "set/show print
4223         raw".
4224
4225 2019-06-13  Pedro Alves  <palves@redhat.com>
4226
4227         * compile/compile.c (struct compile_options): New.
4228         (compile_flag_option_def, compile_command_option_defs)
4229         (make_compile_options_def_group): New.
4230         (compile_file_command): Handle options with
4231         gdb::option::process_options.
4232         (compile_file_command_completer): New function.
4233         (compile_code_command): Handle options with
4234         gdb::option::process_options.
4235         (compile_code_command_completer): New function.
4236         (_initialize_compiler): Install completers for "compile code" and
4237         "compile file".  Mention available options in "compile code" and
4238         "compile code"'s help.
4239         * completer.c (advance_to_completion_word): New, factored out from
4240         ...
4241         (advance_to_expression_complete_word_point): ... this.
4242         (advance_to_filename_complete_word_point): New.
4243         * completer.h (advance_to_filename_complete_word_point): New
4244         declaration.
4245
4246 2019-06-13  Pedro Alves  <palves@redhat.com>
4247
4248         * compile/compile.c: Include "cli/cli-option.h".
4249         (compile_print_value): Scope data pointer is now a
4250         value_print_options pointer; adjust.
4251         (compile_print_command): Process options.  Scope data pointer is
4252         now a value_print_options pointer; adjust.
4253         (_initialize_compile): Update "compile print"'s help to include
4254         supported options.  Install a completer for "compile print".
4255         * cp-valprint.c (show_vtblprint, show_objectprint)
4256         (show_static_field_print): Delete.
4257         (_initialize_cp_valprint): Don't install "set print
4258         static-members", "set print vtbl", "set print object" here.
4259         * printcmd.c: Include "cli/cli-option.h" and
4260         "common/gdb_optional.h".
4261         (print_command_parse_format): Rework to fill in a
4262         value_print_options instead of a format_data.
4263         (print_value): Change parameter type from format_data pointer to
4264         value_print_options reference.  Adjust.
4265         (print_command_1): Process options.  Adjust to pass down a
4266         value_print_options.
4267         (print_command_completer): New.
4268         (_initialize_printcmd): Install print_command_completer as
4269         handle_brkchars completer for the "print" command.  Update
4270         "print"'s help to include supported options.
4271         * valprint.c: Include "cli/cli-option.h".
4272         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4273         here from cp-valprint.c.
4274         (boolean_option_def, uinteger_option_def)
4275         (value_print_option_defs, make_value_print_options_def_group):
4276         New.  Use gdb::option::add_setshow_cmds_for_options to install
4277         "set print elements", "set print null-stop", "set print repeats",
4278         "set print pretty", "set print union", "set print array", "set
4279         print address", "set print symbol", "set print array-indexes".
4280         * valprint.h: Include <string> and "cli/cli-option.h".
4281         (make_value_print_options_def_group): Declare.
4282         (print_value): Change parameter type from format_data pointer to
4283         value_print_options reference.
4284         (print_command_completer): Declare.
4285
4286 2019-06-13  Pedro Alves  <palves@redhat.com>
4287
4288         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4289         (COMMON_SFILES): Add maint-test-settings.c.
4290         * cli/cli-decode.c (boolean_enums): New global, factored out from
4291         ...
4292         (add_setshow_boolean_cmd): ... here.
4293         * cli/cli-decode.h (boolean_enums): Declare.
4294         * cli/cli-option.c: New file.
4295         * cli/cli-option.h: New file.
4296         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4297         factored out from ...
4298         (parse_cli_boolean_value(const char *)): ... this.
4299         (is_unlimited_literal): Change parameter type to pointer to
4300         pointer.  Adjust and advance ARG pointer.
4301         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4302         (parse_cli_var_enum): New, factored out from ...
4303         (do_set_command): ... this.  Adjust.
4304         * cli/cli-setshow.h (parse_cli_boolean_value)
4305         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4306         (parse_cli_var_enum): Declare.
4307         * cli/cli-utils.c: Include "cli/cli-option.h".
4308         (get_ulongest): New.
4309         * cli/cli-utils.h (get_ulongest): Declare.
4310         (check_for_argument): New overloads.
4311         * maint-test-options.c: New file.
4312
4313 2019-06-13  Pedro Alves  <palves@redhat.com>
4314
4315         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4316         parse a range if "-" is at the end of the string.
4317
4318 2019-06-13  Pedro Alves  <palves@redhat.com>
4319
4320         * cli/cli-setshow.c (parse_auto_binary_operation)
4321         (parse_cli_boolean_value): Don't allow "o".
4322
4323 2019-06-13  Pedro Alves  <palves@redhat.com>
4324
4325         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4326         * NEWS: Mention maint test-settings KIND.
4327         * maint-test-settings.c: New file.
4328
4329 2019-06-13  Pedro Alves  <palves@redhat.com>
4330
4331         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4332         completer.
4333         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4334         "set" completers.
4335
4336 2019-06-13  Pedro Alves  <palves@redhat.com>
4337
4338         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4339         after item.
4340
4341 2019-06-13  Pedro Alves  <palves@redhat.com>
4342
4343         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4344
4345 2019-06-13  Pedro Alves <palves@redhat.com>
4346
4347         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4348         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4349         call.
4350         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4351         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4352         calls.
4353         (check_for_argument): Skip spaces after argument.
4354
4355 2019-06-13  Pedro Alves  <palves@redhat.com>
4356
4357         * thread.c (thread_apply_command): Adjust TID parsing.
4358         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4359         detected before end of string.
4360         (tid_is_in_list): Error out if LIST is invalid.
4361
4362 2019-06-13  Pedro Alves  <palves@redhat.com>
4363
4364         * completer.c (complete_line_internal_1): Rewind completion word
4365         point.
4366         (completion_tracker::advance_custom_word_point_by): Change
4367         parameter type to int.
4368         * completer.h (completion_tracker::advance_custom_word_point_by):
4369         Likewise.
4370
4371 2019-06-13  Pedro Alves  <palves@redhat.com>
4372
4373         * completer.c (advance_to_completion_word): Handle delimiters.
4374
4375 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4376
4377         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4378
4379 2019-06-11  Tom Tromey  <tom@tromey.com>
4380
4381         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4382         (xmalloc_failed): Move to alloc.c.
4383         * alloc.c: New file.
4384         * Makefile.in (COMMON_SFILES): Add alloc.c.
4385
4386 2019-06-11  Tom Tromey  <tom@tromey.com>
4387
4388         * nat/linux-waitpid.c: Don't include server.h.
4389         (linux_debug): Remove.
4390         (my_waitpid): Update.
4391
4392 2019-06-11  Tom Tromey  <tromey@adacore.com>
4393
4394         * infcall.c (_initialize_infcall): Remove trailing newline from
4395         help.
4396         * user-regs.c (_initialize_user_regs): Remove trailing newline
4397         from help.
4398         * typeprint.c (_initialize_typeprint): Remove trailing newline
4399         from help.
4400         * reverse.c (_initialize_reverse): Remove trailing newlines from
4401         help.
4402         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4403         from help.
4404         * language.c (add_set_language_command): Remove trailing newline
4405         from help.
4406         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4407         help.
4408         * disasm.c (_initialize_disasm): Remove trailing newline from
4409         help.
4410         * top.c (init_main): Remove trailing newline from help.
4411         * interps.c (_initialize_interpreter): Remove trailing newline
4412         from help.
4413         * btrace.c (_initialize_btrace): Remove trailing newlines from
4414         help.
4415         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4416         from help.
4417         * python/python.c (_initialize_python): Remove trailing newline
4418         from help.
4419         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4420         help.
4421         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4422         from help.  Reformat some text.
4423         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4424         from help.
4425         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4426         newline from help.
4427
4428 2019-06-11  Tom Tromey  <tromey@adacore.com>
4429
4430         * darwin-nat.c (darwin_decode_exception_message)
4431         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4432
4433 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4434
4435         * valops.c (value_slice): Check for not allocated or not
4436         associated values.
4437
4438 2019-06-10  Tom de Vries  <tdevries@suse.de>
4439
4440         PR gdb/24618
4441         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4442         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4443         invalid.
4444
4445 2019-06-10  Tom de Vries  <tdevries@suse.de>
4446
4447         PR gdb/24611
4448         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4449         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4450
4451 2019-06-10  Tom de Vries  <tdevries@suse.de>
4452
4453         PR symtab/24545
4454         * symtab.c (struct demangled_name_entry): Add language field.
4455         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4456         static minimal symbol".  Set and use language field.
4457
4458 2019-06-10  Tom Tromey  <tromey@adacore.com>
4459
4460         * ada-lang.c (_initialize_ada_language): Update help text.
4461
4462 2019-06-10  Tom Tromey  <tromey@adacore.com>
4463
4464         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4465         with a newline.
4466         * guile/guile.c (handle_boot_error): Don't end warning with a
4467         newline.
4468         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4469         warning with a newline.
4470         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4471         newline.
4472         (s12z_frame_cache): Likewise.
4473         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4474         a newline.
4475         * solib-svr4.c (disable_probes_interface): Don't end warning with
4476         a newline.
4477         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4478         newline.
4479         * python/python.c (do_finish_initialization): Don't end warning
4480         with a newline.
4481
4482 2019-06-10  Tom Tromey  <tom@tromey.com>
4483
4484         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4485         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4486         gdbpy_enter.
4487
4488 2019-06-10  Tom Tromey  <tromey@adacore.com>
4489
4490         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4491         data.
4492         (elf_new_init): Don't call stabsread_new_init.
4493         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4494         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4495         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4496
4497 2019-06-10  Tom de Vries  <tdevries@suse.de>
4498
4499         PR symtab/16264
4500         PR symtab/24517
4501         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4502
4503 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4504
4505         * source.c (find_and_open_source): Also rewrite relative file
4506         names.
4507
4508 2019-04-26  Amos Bird  <amosbird@gmail.com>
4509
4510         * annotate.c (annotate_thread_exited): Add "thread-exited"
4511         annotation.
4512
4513 2019-06-06  Tom Tromey  <tromey@adacore.com>
4514
4515         * maint.h (class scoped_command_stats): Use
4516         DISABLE_COPY_AND_ASSIGN.
4517         <print_time>: New method.
4518         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4519         print_time.
4520         (scoped_command_stats::print_time): New method.
4521
4522 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4523
4524         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4525         instructions of lengths 6 or 8 bytes.
4526
4527 2019-06-04  Pedro Alves  <palves@redhat.com>
4528
4529         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4530
4531         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4532         * breakpoint.c (condition_completer): Likewise.
4533         * cli/cli-dump.c (scan_expression): Likewise.
4534         * common/filestuff.c (mkdir_recursive): Likewise.
4535         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4536         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4537         (gdb_abspath): Likewise.
4538         * compile/compile-cplus-types.c
4539         (compile_cplus_instance::decl_name): Likewise.
4540         * completer.c (complete_explicit_location):
4541         (signal_completer, reg_or_group_completer_1): Likewise.
4542         * cp-support.c (cp_remove_params_if_any): Likewise.
4543         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4544         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4545         * infcmd.c (strip_bg_char): Likewise.
4546         * linespec.c (copy_token_string): Likewise.
4547         * mi/mi-main.c (output_cores): Likewise.
4548         * psymtab.c (psymtab_search_name):
4549         * symfile.c (test_set_ext_lang_command): Likewise.
4550         * target.c (target_fileio_read_stralloc): Likewise.
4551         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4552         * value.c (complete_internalvar): Likewise.
4553
4554 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4555
4556         Add objfile property to gdb.Type.
4557         * NEWS: Mention Python API addition.
4558         * python/py-type.c (typy_get_objfile): New method.
4559
4560 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4561
4562         * NEWS: Mention the new set|show style [title|highlight].
4563         Mention changes to "show style", "help" and "apropos".
4564
4565 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4566
4567         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4568         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4569         instead of print_help_for_command.
4570         (print_doc_of_command): New function.
4571         (help_list): Add 'apropos -v word' suggestion.
4572         (print_help_for_command): Style the command name using title style.
4573         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4574         (_initialize_cli_cmds): Describe -v in apropos_command help.
4575
4576 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4577
4578         * cli/cli-style.h (cli_style_option): Add name in constructor,
4579         add m_name class member, add constructor with intensity,
4580         add name class function.
4581         (cli_style_option::add_setshow_commands): Remove name argument.
4582         (highlight_style, title_style): New styles.
4583         * cli/cli-style.c (do_show): New function that shows a style
4584         characteristic styling the style name with itself.
4585         (set_style_name): New function.
4586         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4587         Update all callers according to the changes in cli/cli-style.h.
4588         * utils.h (fputs_highlighted): New function.
4589         * utils.c (fputs_highlighted): Likewise.
4590
4591 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4592
4593         * NEWS: Mention new pipe command and new convenience variables.
4594
4595 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4596
4597         * cli/cli-cmds.c (pipe_command): New function.
4598         (_initialize_cli_cmds): Call add_com for pipe_command.
4599         Define | as an alias for pipe.
4600         (exit_status_set_internal_vars): New function.
4601         (shell_escape): Call exit_status_set_internal_vars.
4602         cli/cli-decode.c (find_command_name_length): Recognize | as
4603         a single character command.
4604
4605 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4606
4607         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4608         top.c (execute_command_to_ui_file): New function, mostly a copy
4609         of execute_command_to_string.
4610         (execute_command_to_string): Implement by calling
4611         execute_command_to_ui_file.
4612
4613 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4614
4615         * top.h (saved_command_line): Remove declaration.
4616         * top.c (previous_saved_command_line, previous_repeat_arguments):
4617         New variables.
4618         (saved_command_line): Make static, define together with other
4619         'repeat variables'.
4620         (dont_repeat): Clear repeat_arguments.
4621         (repeat_previous, get_saved_command_line, save_command_line):
4622         New functions.
4623         (gdb_init): Initialize saved_command_line
4624         and previous_saved_command_line.
4625         * main.c (captured_main_1): Remove saved_command_line initialization.
4626         * event-top.c (handle_line_of_input): Update to use
4627         the new 'repeat' related functions instead of direct access to
4628         saved_command_line.
4629         * command.h (repeat_previous, get_saved_command_line,
4630         save_command_line): New declarations.
4631         (dont_repeat): Add comment.
4632
4633 2019-05-30  Tom Tromey  <tromey@adacore.com>
4634
4635         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4636         Fix comment.
4637         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4638
4639 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4640
4641         PR cli/24587
4642         * completer.c (complete): Initialize variable word.
4643
4644 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4645
4646         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4647         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4648         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4649         'body' is NULL to the outter 'if', protecting the '!is_define'
4650         situation as well.
4651
4652 2019-05-29  Tom Tromey  <tromey@adacore.com>
4653
4654         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4655         (dwarf_unknown): New function.
4656         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4657         (dwarf_type_encoding_name): Use dwarf_unknown.
4658
4659 2019-05-29  Tom Tromey  <tromey@adacore.com>
4660
4661         PR c++/20020:
4662         * cp-valprint.c (cp_print_value_fields): Call
4663         cp_print_static_field inside "try".
4664
4665 2019-05-29  Tom Tromey  <tromey@adacore.com>
4666
4667         * inflow.c (struct terminal_info): Add default operator=.
4668         * configure: Rebuild.
4669         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4670         -Wdeprecated-copy-dtor, -Wredundant-move.
4671
4672 2019-05-29  Tom Tromey  <tromey@adacore.com>
4673
4674         * NEWS: Add entry.
4675         * infcmd.c (print_return_value_1): Handle finish_print
4676         option.
4677         (show_print_finish): New function.
4678         (_initialize_infcmd): Add "set/show print finish" commands.
4679         * valprint.c (user_print_options): Initialize new member.
4680         * valprint.h (struct value_print_options) <finish_print>: New
4681         member.
4682
4683 2019-05-28  Tom Tromey  <tromey@adacore.com>
4684
4685         * ada-lang.c (ada_remove_Xbn_suffix)
4686         (find_old_style_renaming_symbol)
4687         (parse_old_style_renaming): Remove.
4688         (ada_find_renaming_symbol): Don't call
4689         find_old_style_renaming_symbol.
4690         (ada_is_renaming_symbol): Rename from
4691         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4692         bool.  Now static.
4693         (ada_read_var_value): Update and simplify.
4694         * ada-exp.y (write_var_or_type): Remove old code.
4695
4696 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4697
4698         * event-top.c: Remove include comment.
4699         * inflow.c (class scoped_ignore_sigttou): Move from here...
4700         * inflow.h (class scoped_ignore_sigttou): ...to here.
4701         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4702         * top.c:  Remove include comment.
4703
4704 2019-05-27  Tom Tromey  <tom@tromey.com>
4705
4706         * NEWS: Fix typo.
4707
4708 2019-05-22  Tom Tromey  <tromey@adacore.com>
4709
4710         * target.c (target_follow_exec): Constify parameter.
4711         * target-delegates.c: Rebuild.
4712         * remote.c (remote_target::follow_exec): Constify parameter.
4713         * infrun.c (follow_exec): Constify parameter.
4714         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4715         (target_follow_exec): Likewise.
4716
4717 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4718
4719         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4720         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4721
4722 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4723
4724         * NEWS: Add debugredirect and testsuite sections.
4725
4726 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4727
4728         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4729         target descriptions using exclusively floating point register name
4730         aliases.
4731
4732 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4733
4734         PR gdb/18644:
4735         * f-lang.c (build_fortran_types): Handle the case where
4736         gdbarch_floatformat_for_type returns a nullptr.
4737
4738 2019-05-21  Tom de Vries  <tdevries@suse.de>
4739
4740         PR cli/24587
4741         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4742
4743 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4744
4745         PR gdb/18644:
4746         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4747         16-byte floats.
4748         * i386-tdep.c (i386_floatformat_for_type): Use
4749         floatformats_ia64_quad for the 16-byte floating point component
4750         within a fortran 32-byte complex number.
4751
4752 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4753
4754         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4755         delete default constructor.
4756         (find_partial_die): Update to return const struct.
4757         (partial_die_parent_scope): Move variable declaration into scope
4758         of its use and change its type to auto.
4759         (guess_partial_die_structure_name): Likewise.
4760         (partial_die_info::fixup): Likewise.
4761
4762 2019-05-17  Tom Tromey  <tromey@adacore.com>
4763
4764         * source.c (find_and_open_source): Remove cast.
4765
4766 2019-05-17  Tom Tromey  <tromey@adacore.com>
4767
4768         * annotate.c (annotate_source): Make "filename" const.
4769         * annotate.h (annotate_source): Use const.
4770
4771 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4772
4773         * disasm.c (set_disassembler_options): Send errors to stderr.
4774
4775 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4776
4777         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4778         (cli_interp_base::set_logging): Check debug_redirect.
4779         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4780         * cli/cli-logging.c (debug_redirect): Add static variable.
4781         (pop_output_files): Add default param.
4782         (handle_redirections): Print debug setting.
4783         (show_logging_command): Likewise.
4784         (_initialize_cli_logging): Add debugredirect command.
4785         * interps.c (current_interp_set_logging): Add debug_redirect
4786         parameter.
4787         * interps.h (set_logging): Add debug_redirect parameter.
4788         (current_interp_set_logging): Likewise.
4789         * mi/mi-common.h: Likewise.
4790         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4791
4792 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4793             Tom Tromey  <tromey@adacore.com>
4794
4795         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4796         directly.
4797         * cli/cli-interp.h (make_logging_output): Remove declaration.
4798         * cli/cli-logging.c (make_logging_output): Remove function.
4799         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4800         directly.
4801         * ui-file.c (tee_file::tee_file): Remove bools.
4802         (tee_file::~tee_file): Remove deletes.
4803         * ui-file.h (tee_file): Remove bools.
4804
4805 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4806
4807         * mi/mi-cmds.h (mi_cmd_complete): New function.
4808         * mi/mi-main.c (mi_cmd_complete): Likewise.
4809         * mi/mi-cmds.c: Define new MI command -complete.
4810         * NEWS: Mention new -complete command.
4811
4812 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4813
4814         * completer.h (complete): New function.
4815         * completer.c (complete): Likewise.
4816         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4817         function defined in completer.h.
4818
4819 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4820
4821         * MAINTAINERS (Write After Approval): Add myself.
4822
4823 2019-05-17  Tom de Vries  <tdevries@suse.de>
4824
4825         PR gdb/24094
4826         * dwarf2read.c (struct cu_partial_die_info): New struct.
4827         (find_partial_die): Return cu_partial_die_info.
4828         (partial_die_parent_scope, guess_partial_die_structure_name)
4829         (partial_die_info::fixup): Handle new return type of find_partial_die.
4830
4831 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4832
4833         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4834         "std::string", simplifying the algorithm.
4835
4836 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4837
4838         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4839         (stap_static_probe_ops::get_probes): Likewise.
4840
4841 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4842
4843         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4844         '-')" and "else if".
4845         (stap_parse_single_operand): Join checks for
4846         "gdbarch_stap_parse_special_token_p" and
4847         "gdbarch_stap_parse_special_token" in the same "if" statement.
4848         Invert check when verifying for operation on register
4849         displacement.
4850
4851 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4852
4853         * stap-probe.c (stap_get_opcode): Update comment.
4854         (stap_get_expected_argument_type): Likewise.
4855         (handle_stap_probe): Likewise.
4856
4857 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4858
4859         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4860         return type to 'bool'.  Adjust comment.  Use 'bool' when
4861         appropriate.
4862         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4863         * stap-probe.c (stap_parse_argument_1): Likewise.
4864         (stap_is_operator): Likewise.
4865         (stap_is_generic_prefix): Likewise.
4866         (stap_is_register_prefix): Likewise.
4867         (stap_is_register_indirection_prefix): Likewise.
4868         (stap_is_integer_prefix): Likewise.
4869         (stap_generic_check_suffix): Likewise.
4870         (stap_check_integer_suffix): Likewise.
4871         (stap_check_register_suffix): Likewise.
4872         (stap_check_register_indirection_suffix): Likewise.
4873         (stap_parse_register_operand): Likewise.
4874         (stap_parse_single_operand): Likewise.
4875         (stap_parse_argument_1): Likewise.
4876         (stap_probe::get_argument_count): Likewise.
4877         (stap_is_operator): Likewise.
4878
4879 2019-05-16  Tom Tromey  <tromey@adacore.com>
4880
4881         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4882         keyword to foreach.
4883
4884 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4885
4886         * linux-thread-db.c (try_thread_db_load_1): Change return type
4887         to bool.
4888         (try_thread_db_load): Likewise.
4889         (try_thread_db_load_from_pdir_1): Likewise.
4890         (try_thread_db_load_from_pdir): Likewise.
4891         (try_thread_db_load_from_sdir): Likewise.
4892         (try_thread_db_load_from_dir): Likewise.
4893         (thread_db_load_search): Likewise.
4894         (has_libpthread): Likewise.
4895         (thread_db_load): Likewise.
4896
4897 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4898
4899         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4900         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4901         NULL, and complain/return if that's the case.
4902
4903 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4904
4905         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4906         (advance, posn, abstract_read_memory): New functions.
4907         [struct mem_read_abstraction]: New struct.
4908         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4909
4910 2019-05-14  Tom Tromey  <tromey@adacore.com>
4911
4912         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4913         value is not lval_memory.
4914
4915 2019-05-14  Tom Tromey  <tromey@adacore.com>
4916
4917         * solib.c (info_sharedlibrary_command): Style the file name.
4918
4919 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4920
4921         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4922         (aarch64_vnv_type): Likewise.
4923         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4924         * common/tdesc.c: Likewise.
4925         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4926         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4927         * features/aarch64-fpu.xml: Add ieee half view.
4928         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4929         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4930         * gdbtypes.h (struct builtin_type): Likewise.
4931         (struct objfile_type): Likewise.
4932
4933 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4934
4935         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4936         typo.
4937         * location.h (string_to_event_location): Likewise.
4938
4939 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4940
4941         GDB 8.3 released.
4942
4943 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4944
4945         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4946         New variable declaration.
4947         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4948         New variable.
4949         (print_one_breakpoint): Use ui_out::test_flags and new global
4950         variable to compute use_fixed_output.
4951         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4952         Remove.
4953         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4954         (mi_multi_location_breakpoint_output_fixed): Remove.
4955         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4956         new variable.
4957         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4958         fix_multi_location_breakpoint_output flag if version >= 3.
4959         * ui-out.h (enum ui_out_flag)
4960         <fix_multi_location_breakpoint_output>: New enumerator.
4961
4962 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4963
4964         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4965
4966 2019-05-10  Tom Tromey  <tromey@adacore.com>
4967
4968         * ada-lang.c (catch_ada_completer): New function.
4969         (_initialize_ada_language): Use it.
4970
4971 2019-05-10  Tom Tromey  <tromey@adacore.com>
4972
4973         * thread.c (print_thread_info): Make "requested_threads" const.
4974         * gdbthread.h (print_thread_info): Make "requested_threads"
4975         const.
4976         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4977         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4978
4979 2019-05-08  Tom Tromey  <tom@tromey.com>
4980
4981         * gdbtypes.c (objfile_type_data): Change type.
4982         (objfile_type, _initialize_gdbtypes): Update.
4983
4984 2019-05-08  Tom Tromey  <tom@tromey.com>
4985
4986         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4987         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4988         (_initialize_dwarf2_frame): Update.
4989
4990 2019-05-08  Tom Tromey  <tom@tromey.com>
4991
4992         * objc-lang.c (objc_objfile_data): Change type.
4993         (find_methods): Update.
4994         (_initialize_objc_lang): Remove.
4995
4996 2019-05-08  Tom Tromey  <tom@tromey.com>
4997
4998         * stabsread.c (rs6000_builtin_type_data): Change type.
4999         (rs6000_builtin_type, _initialize_stabsread): Update.
5000
5001 2019-05-08  Tom Tromey  <tom@tromey.com>
5002
5003         * mips-tdep.c (mips_pdr_data): Remove.
5004         (_initialize_mips_tdep): Update.
5005
5006 2019-05-08  Tom Tromey  <tom@tromey.com>
5007
5008         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5009         (hppa_init_objfile_priv_data, read_unwind_info)
5010         (find_unwind_entry, _initialize_hppa_tdep): Update.
5011
5012 2019-05-08  Tom Tromey  <tom@tromey.com>
5013
5014         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5015         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5016         on obstack.
5017         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5018
5019 2019-05-08  Tom Tromey  <tom@tromey.com>
5020
5021         * mdebugread.c (basic_type_data): Change type.
5022         (basic_type, _initialize_mdebugread): Update.
5023
5024 2019-05-08  Tom Tromey  <tom@tromey.com>
5025
5026         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5027
5028 2019-05-08  Tom Tromey  <tom@tromey.com>
5029
5030         * nto-tdep.c (nto_inferior_data_reg): Change type.
5031         (nto_inferior_data): Update.
5032         (nto_inferior_data_cleanup, nto_new_inferior_data)
5033         (_initialize_nto_tdep): Remove.
5034         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5035
5036 2019-05-08  Tom Tromey  <tom@tromey.com>
5037
5038         * ada-lang.c (struct ada_inferior_data): Add initializers.
5039         (ada_inferior_data): Change type.
5040         (ada_inferior_data_cleanup): Remove.
5041         (get_ada_inferior_data, ada_inferior_exit)
5042         (struct ada_pspace_data): Add initializers, destructor.
5043         (ada_pspace_data_handle): Change type.
5044         (get_ada_pspace_data): Update.
5045         (ada_pspace_data_cleanup): Remove.
5046
5047 2019-05-08  Tom Tromey  <tom@tromey.com>
5048
5049         * coffread.c (struct coff_symfile_info): Add initializers.
5050         (coff_objfile_data_key): Move lower.  Change type.
5051         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5052         Update.
5053         (coff_free_info): Remove.
5054
5055 2019-05-08  Tom Tromey  <tom@tromey.com>
5056
5057         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5058         (fbsd_pspace_data_handle): Move lower.  Change type.
5059         (get_fbsd_pspace_data): Update.
5060         (fbsd_pspace_data_cleanup): Remove.
5061         (_initialize_fbsd_tdep): Update.
5062
5063 2019-05-08  Tom Tromey  <tom@tromey.com>
5064
5065         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5066         (get_ada_tasks_pspace_data): Update.
5067         (ada_tasks_pspace_data_cleanup): Remove.
5068         (_initialize_tasks): Update.
5069         (ada_tasks_inferior_data_handle): Change type.
5070         (get_ada_tasks_inferior_data): Update.
5071         (ada_tasks_inferior_data_cleanup): Remove.
5072         (struct ada_tasks_pspace_data): Add initializers.
5073
5074 2019-05-08  Tom Tromey  <tom@tromey.com>
5075
5076         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5077         * symfile-debug.c (debug_sym_get_probes): Change type.
5078         * stap-probe.c (handle_stap_probe):
5079         (stap_static_probe_ops::get_probes): Change type.
5080         * probe.h (class static_probe_ops) <get_probes>: Change type.
5081         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5082         (parse_probes_in_pspace): Update.
5083         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5084         Update.
5085         (any_static_probe_ops::get_probes): Change type.
5086         * elfread.c (elfread_data): New typedef.
5087         (probe_key): Change type.
5088         (elf_get_probes): Likewise.  Update.
5089         (probe_key_free): Remove.
5090         (_initialize_elfread): Update.
5091         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5092         Change type.
5093         (dtrace_process_dof_probe, dtrace_process_dof)
5094         (dtrace_static_probe_ops::get_probe): Change type.
5095
5096 2019-05-08  Tom Tromey  <tom@tromey.com>
5097
5098         * xcoffread.c (struct xcoff_symfile_info): Rename from
5099         coff_symfile_info.  Add initializers.
5100         (xcoff_objfile_data_key): Move lower.  Change type.
5101         (XCOFF_DATA): Rewrite.
5102         (xcoff_free_info): Remove.
5103         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5104         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5105         (xcoff_initial_scan): Update.
5106
5107 2019-05-08  Tom Tromey  <tom@tromey.com>
5108
5109         * solib-svr4.c (struct svr4_info): Add initializers and
5110         destructor.
5111         <probes_table>: Now an htab_up.
5112         (solib_svr4_pspace_data): Change type.
5113         (free_probes_table): Simplify.
5114         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5115         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5116         (probes_table_remove_objfile_probes, register_solib_event_probe)
5117         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5118         (_initialize_svr4_solib): Update.
5119
5120 2019-05-08  Tom Tromey  <tom@tromey.com>
5121
5122         * remote.c (remote_pspace_data): Change type.
5123         (remote_pspace_data_cleanup): Remove.
5124         (get_remote_exec_file, set_pspace_remote_exec_file)
5125         (_initialize_remote): Update.
5126
5127 2019-05-08  Tom Tromey  <tom@tromey.com>
5128
5129         * breakpoint.c (breakpoint_objfile_key): Change type.
5130         (get_breakpoint_objfile_data): Update.
5131         (free_breakpoint_objfile_data): Remove.
5132         (_initialize_breakpoint): Update.
5133
5134 2019-05-08  Tom Tromey  <tom@tromey.com>
5135
5136         * linux-tdep.c (struct linux_info): Add initializers.
5137         (linux_inferior_data): Move.  Change type.
5138         (invalidate_linux_cache_inf): Update.
5139         (linux_inferior_data_cleanup): Remove.
5140         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5141
5142 2019-05-08  Tom Tromey  <tom@tromey.com>
5143
5144         * auxv.c (auxv_inferior_data): Move.  Change type.
5145         (auxv_inferior_data_cleanup): Remove.
5146         (invalidate_auxv_cache_inf): Rewrite.
5147         (get_auxv_inferior_data, _initialize_auxv): Update.
5148
5149 2019-05-08  Tom Tromey  <tom@tromey.com>
5150
5151         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5152         (symfile_debug_objfile_data_key): Change type.
5153         (symfile_debug_installed, debug_qf_has_symbols)
5154         (debug_qf_find_last_source_symtab)
5155         (debug_qf_forget_cached_source_info)
5156         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5157         (debug_qf_print_stats, debug_qf_dump)
5158         (debug_qf_expand_symtabs_for_function)
5159         (debug_qf_expand_all_symtabs)
5160         (debug_qf_expand_symtabs_with_fullname)
5161         (debug_qf_map_matching_symbols)
5162         (debug_qf_expand_symtabs_matching)
5163         (debug_qf_find_pc_sect_compunit_symtab)
5164         (debug_qf_map_symbol_filenames)
5165         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5166         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5167         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5168         (debug_sym_read_linetable, debug_sym_relocate): Update.
5169         (symfile_debug_free_objfile): Remove.
5170         (install_symfile_debug_logging, _initialize_symfile_debug):
5171         Update.
5172
5173 2019-05-08  Tom Tromey  <tom@tromey.com>
5174
5175         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5176         allocate_on_obstack.
5177         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5178         (get_dwarf2_per_objfile): Update.
5179         (set_dwarf2_per_objfile): Remove.
5180         (dwarf2_has_info, dwarf2_get_section_info): Update.
5181         (dwarf2_free_objfile): Remove.
5182         (_initialize_dwarf2_read): Update.
5183
5184 2019-05-08  Tom Tromey  <tom@tromey.com>
5185
5186         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5187         initializers.
5188         <unsupported_script_warning_printed,
5189         script_not_found_warning_printed>: Now bool.
5190         (auto_load_pspace_data): Change type.
5191         (~auto_load_pspace_info): Rename from
5192         auto_load_pspace_data_cleanup.
5193         (get_auto_load_pspace_data, init_loaded_scripts_info)
5194         (clear_section_scripts, maybe_print_unsupported_script_warning)
5195         (maybe_print_script_not_found_warning, _initialize_auto_load):
5196         Update.
5197
5198 2019-05-08  Tom Tromey  <tom@tromey.com>
5199
5200         * objfiles.c (objfile_pspace_info): Add destructor and
5201         initializers.
5202         (objfiles_pspace_data): Change type.
5203         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5204         (get_objfile_pspace_data): Update.
5205         (objfiles_bfd_data): Change type.
5206         (get_objfile_bfd_data): Update.
5207         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5208
5209 2019-05-08  Tom Tromey  <tom@tromey.com>
5210
5211         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5212         Change type.
5213         (get_catch_syscall_inferior_data): Update.
5214         (catch_syscall_inferior_data_cleanup): Remove.
5215         (_initialize_break_catch_syscall): Update.
5216
5217 2019-05-08  Tom Tromey  <tom@tromey.com>
5218
5219         * inflow.c (struct terminal_info): Add destructor and
5220         initializers.
5221         (inflow_inferior_data): Change type.
5222         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5223         (get_inflow_inferior_data, inflow_inferior_exit)
5224         (swap_terminal_info, _initialize_inflow): Update.
5225
5226 2019-05-08  Tom Tromey  <tom@tromey.com>
5227
5228         * target-dcache.c (target_dcache_cleanup): Remove.
5229         (target_dcache_aspace_key): Change type.
5230         (target_dcache_init_p, target_dcache_invalidate)
5231         (target_dcache_get, target_dcache_get_or_init)
5232         (_initialize_target_dcache): Update.
5233         * dcache.h (struct dcache_deleter): New.
5234
5235 2019-05-08  Tom Tromey  <tom@tromey.com>
5236
5237         * symtab.c (struct symbol_cache): Add destructor and
5238         initializers.
5239         (symbol_cache_key): Move.  Change type.
5240         (make_symbol_cache, free_symbol_cache): Remove.
5241         (get_symbol_cache): Update.
5242         (symbol_cache_cleanup): Remove.
5243         (ALL_PSPACES, symbol_cache_flush)
5244         (maintenance_print_symbol_cache)
5245         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5246         Update.
5247
5248 2019-05-08  Tom Tromey  <tom@tromey.com>
5249
5250         * symtab.c (struct main_info): Add destructor and initializers.
5251         (main_progspace_key): Move.  Change type.
5252         (get_main_info): Update.
5253         (main_info_cleanup): Remove.
5254         (_initialize_symtab): Update.
5255
5256 2019-05-08  Tom Tromey  <tom@tromey.com>
5257
5258         * registry.h (DECLARE_REGISTRY): Define the _key class.
5259
5260 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5261
5262         * NEWS: Merge two 'New commands' sections.
5263
5264 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5265
5266         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5267         parameter and use Ada language definition instead.
5268         (ada_val_print_ptr): Remove unused language parameter.
5269         (ada_val_print_num): Remove language parameter and use Ada language
5270         definition instead.
5271         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5272         parameter.
5273         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5274         parameter and use Ada language definition instead.
5275         (ada_val_print_1): Update all ada_val_print_xxx calls.
5276         Remove language parameter.
5277         (ada_val_print): Update ada_val_print_1 call.
5278
5279 2019-05-08  Tom Tromey  <tromey@adacore.com>
5280
5281         * remote.c (remote_hw_watchpoint_limit)
5282         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5283         Now static.
5284
5285 2019-05-08  Tom Tromey  <tromey@adacore.com>
5286
5287         * maint.c (_initialize_maint_cmds): Move initialization code to
5288         remote.c.
5289         (watchdog, show_watchdog): Move to remote.c.
5290         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5291         "watchdog" static.
5292         (_initialize_remote): Move initialization code from maint.c.
5293         * defs.h (watchdog): Don't declare.
5294
5295 2019-05-08  Tom Tromey  <tromey@adacore.com>
5296
5297         * tui/tui-interp.c: Include main.h.
5298         * interps.c: Include main.h.
5299         * main.h (interpreter_p): Declare.
5300         * defs.h (interpreter_p): Don't declare.
5301
5302 2019-05-08  Tom Tromey  <tromey@adacore.com>
5303
5304         * dwarf2loc.c: Include dwarf2read.h.
5305         * defs.h (read_unsigned_leb128): Don't declare.
5306         * dwarf2read.h (read_unsigned_leb128): Declare.
5307
5308 2019-05-08  Tom Tromey  <tromey@adacore.com>
5309
5310         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5311         method.
5312
5313 2019-05-08  Tom Tromey  <tromey@adacore.com>
5314
5315         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5316         when no wrap column is set.
5317
5318 2019-05-08  Tom Tromey  <tromey@adacore.com>
5319
5320         * c-lang.c (c_get_string): Handle non-C-style arrays.
5321
5322 2019-05-08  Tom Tromey  <tromey@adacore.com>
5323
5324         * typeprint.c (print_offset_data::update): Print the bit offset,
5325         not the number of bits remaining.
5326
5327 2019-05-08  Tom Tromey  <tromey@adacore.com>
5328
5329         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5330         padding at end of comment.
5331
5332 2019-05-08  Tom Tromey  <tromey@adacore.com>
5333
5334         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5335         Compare main types.
5336
5337 2019-05-06  Tom Tromey  <tom@tromey.com>
5338
5339         * common/scoped_mmap.c: Include common-defs.h.
5340         * common/scoped_mmap.h: Don't include config.h.
5341
5342 2019-05-04  Tom Tromey  <tom@tromey.com>
5343
5344         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5345         (struct aarch64_call_info): Add initializers.
5346         <si>: Now a std::vector.
5347         (pass_on_stack, aarch64_push_dummy_call): Update.
5348
5349 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5350             Tom Tromey  <tom@tromey.com>
5351
5352         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5353         (ppc_threads): Now a std::vector.  Now static.
5354         (hwdebug_find_thread_points_by_tid)
5355         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5356         Update.
5357
5358 2019-05-04  Tom Tromey  <tom@tromey.com>
5359
5360         * arc-tdep.c (arc_tdesc_init): Return bool.
5361
5362 2019-05-04  Tom Tromey  <tom@tromey.com>
5363
5364         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5365         Use gdb_assert_not_reached.
5366
5367 2019-05-04  Tom Tromey  <tom@tromey.com>
5368
5369         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5370         "false".
5371
5372 2019-05-04  Tom Tromey  <tom@tromey.com>
5373
5374         * arc-tdep.c (arc_tdesc_init): Use bool.
5375
5376 2019-05-04  Tom Tromey  <tom@tromey.com>
5377
5378         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5379
5380 2019-05-04  Tom Tromey  <tom@tromey.com>
5381
5382         * cli/cli-cmds.c (valid_command_p): Return bool.
5383
5384 2019-05-04  Tom Tromey  <tom@tromey.com>
5385
5386         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5387         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5388
5389 2019-05-04  Raul Tambre  <raul@tambre.ee>
5390
5391         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5392         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5393         operator for comparison.
5394
5395 2019-05-04  Tom Tromey  <tom@tromey.com>
5396
5397         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5398         (lookup_partial_symbol, print_partial_symbols)
5399         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5400         (psymbol_compare): Update.
5401         (add_psymbol_to_bcache): Clear the entire psymbol.
5402         (maintenance_check_psymtabs): Update.
5403         * psympriv.h (struct partial_symbol): Don't derive from
5404         general_symbol_info.
5405         <obj_section, unrelocated_address, address,
5406         set_unrelocated_address>: Update.
5407         <ginfo>: New member.
5408         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5409         (debug_names::write_psymbols): Update.
5410
5411 2019-05-04  Tom de Vries  <tdevries@suse.de>
5412
5413         * contrib/cc-with-tweaks.sh: Support -n arg.
5414
5415 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5416
5417         * corelow.c (core_target::detach): Ensure frame cache and
5418         register caches are cleared.
5419         inferior.c (exit_inferior_1): Likewise.
5420
5421 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5422             Tom Tromey  <tom@tromey.com>
5423
5424         * dictionary.c (collate_pending_symbols_by_language): Remove
5425         "struct" from foreach.
5426         * symtab.c (lookup_global_symbol_from_objfile)
5427         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5428         foreach.
5429         * ser-tcp.c (net_open): Remove "struct" from foreach.
5430         * objfiles.c (objfile_relocate, objfile_rebase)
5431         (objfile_has_symbols): Remove "struct" from foreach.
5432         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5433         from foreach.
5434         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5435         foreach.
5436         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5437         "struct" from foreach.
5438         * ada-lang.c (create_excep_cond_exprs)
5439         (ada_exception_catchpoint_cond_string): Remove "struct" from
5440         foreach.
5441
5442 2019-05-03  Tom Tromey  <tromey@adacore.com>
5443
5444         * ada-exp.y (convert_char_literal): Check suffix of each
5445         enumerator.
5446
5447 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5448
5449         PR ada/21406:
5450         * ada-exp.y (yywrap): Don't define.
5451         * ada-lex.l (%option): Add noyywrap
5452         (yywrap): Remove.
5453
5454 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5455
5456         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5457         _WIN32_WINNT to the XP level, unless already defined to a higher
5458         level.
5459
5460         * unittests/parse-connection-spec-selftests.c:
5461         * ser-tcp.c:
5462         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5463         override.
5464
5465         * symfile.c (find_separate_debug_file): Remove colon from the
5466         drive spec of DOS/Windows file names of the target, so that the
5467         file name produced from DEBUGDIR and the target's directory will
5468         be valid on DOS/Windows systems.
5469
5470 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5471
5472         * rust-lang.c (val_print_struct): Handle printing structures
5473         containing strings.
5474
5475 2019-05-02  Tom Tromey  <tromey@adacore.com>
5476
5477         * valarith.c (_initialize_valarith): Remove.
5478
5479 2019-05-01  Tom Tromey  <tromey@adacore.com>
5480
5481         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5482         bitfields.
5483
5484 2019-05-01  Tom Tromey  <tromey@adacore.com>
5485
5486         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5487         for big-endian copies.
5488
5489 2019-04-30  Ali Tamur  <tamur@google.com>
5490         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5491         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5492         (read_3_bytes): New function.
5493
5494 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5495
5496         * windows-nat.c (main_thread_id): Delete.
5497         (handle_output_debug_string): Replace main_thread_id by
5498         current_event.dwThreadId.
5499         (fake_create_process): Likewise.
5500         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5501         Do not set main_thread_id.
5502         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5503         current_event.dwThreadId.
5504         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5505
5506 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5507
5508         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5509         Use current_event.dwThreadId instead of main_thread_id.
5510
5511 2019-04-30  Tom Tromey  <tromey@adacore.com>
5512
5513         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5514         (create_excep_cond_exprs): Iterate over program spaces.
5515         (ada_exception_catchpoint_cond_string): Examine all minimal
5516         symbols for exception types.
5517
5518 2019-04-30  Tom Tromey  <tromey@adacore.com>
5519
5520         PR c++/24470:
5521         * dwarf2read.c (process_structure_scope): Handle case where type
5522         has template parameters but no symbol was created.
5523
5524 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5525             Chris January  <chris.january@arm.com>
5526
5527         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5528         qualifier.
5529         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5530
5531 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5532
5533         * f-typeprint.c (f_print_type): Update rules for printing
5534         whitespace.
5535         (f_type_print_varspec_suffix): Likewise.
5536
5537 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5538             Chris January  <chris.january@arm.com>
5539
5540         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5541         function arguments.
5542
5543 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5544
5545         * f-lang.c (build_fortran_types): Change name of void type to
5546         lower case.
5547         * f-typeprint.c (f_type_print_base): Print the name of the void
5548         type, rather than a fixed string.
5549         * f-valprint.c (f_decorations): Use lower case void string.
5550
5551 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5552             Chris January  <chris.january@arm.com>
5553
5554         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5555         types for Fortran.
5556
5557 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5558             Chris January  <chris.january@arm.com>
5559             David Lecomber  <david.lecomber@arm.com>
5560
5561         * f-exp.y (BINOP_INTRINSIC): New token.
5562         (exp): New parser rule handling BINOP_INTRINSIC.
5563         (f77_keywords): Add new builtin procedures.
5564         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5565         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5566         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5567         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5568         (print_unop_subexp_f): New function.
5569         (print_binop_subexp_f): New function.
5570         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5571         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5572         (dump_subexp_body_f): Likewise.
5573         (operator_check_f): Likewise.
5574         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5575         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5576
5577 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5578
5579         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5580         UNOP_KIND.
5581         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5582         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5583         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5584         (operator_length_f): New fuction.
5585         (print_subexp_f): New function.
5586         (op_name_f): New function.
5587         (dump_subexp_body_f): New function.
5588         (operator_check_f): New function.
5589         (exp_descriptor_f): Replace standard expression handling functions
5590         with new functions.
5591         * gdb/fortran-operator.def: New file.
5592         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5593         * gdb/std-operator.def: Remove UNOP_KIND.
5594
5595 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5596
5597         * std-operator.def: Remove unbalanced, stray double quote
5598         character.
5599
5600 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5601             Chris January  <chris.january@arm.com>
5602             Daniel Everett  <daniel.everett@arm.com>
5603             Nick Forrington  <nick.forrington@arm.com>
5604             Richard Bunt  <richard.bunt@arm.com>
5605
5606         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5607         of depth when printing anonymous structs or unions.
5608         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5609         Don't print either the top-level value, or the children if the
5610         max-depth is exceeded.
5611         (ppscm_print_children): When printing the key of a map, allow one
5612         extra level of depth.
5613         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5614         print either the top-level value, or the children if the max-depth
5615         is exceeded.
5616         (print_children): When printing the key of a map, allow one extra
5617         level of depth.
5618         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5619         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5620         (user_print_options): Initialise max_depth field.
5621         (val_print_scalar_or_string_type_p): New function.
5622         (val_print): Check to see if the max depth has been reached.
5623         (val_print_check_max_depth): Define new function.
5624         (show_print_max_depth): New function.
5625         (_initialize_valprint): Add 'print max-depth' option.
5626         * valprint.h (struct value_print_options) <max_depth>: New field.
5627         (val_print_check_max_depth): Declare new function.
5628         * NEWS: Document new feature.
5629
5630 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5631
5632         * ada-lang.c (ada_language_defn): Initialise new field.
5633         * c-lang.c (c_is_string_type_p): New function.
5634         (c_language_defn): Initialise new field.
5635         (cplus_language_defn): Initialise new field.
5636         (asm_language_defn): Initialise new field.
5637         (minimal_language_defn): Initialise new field.
5638         * c-lang.h (c_is_string_type_p): Declare new function.
5639         * d-lang.c (d_language_defn): Initialise new field.
5640         * f-lang.c (f_is_string_type_p): New function.
5641         (f_language_defn): Initialise new field.
5642         * go-lang.c (go_is_string_type_p): New function.
5643         (go_language_defn): Initialise new field.
5644         * language.c (default_is_string_type_p): New function.
5645         (unknown_language_defn): Initialise new field.
5646         (auto_language_defn): Initialise new field.
5647         * language.h (struct language_defn) <la_is_string_type_p>: New
5648         member variable.
5649         (default_is_string_type_p): Declare new function.
5650         * m2-lang.c (m2_language_defn): Initialise new field.
5651         * objc-lang.c (objc_language_defn): Initialise new field.
5652         * opencl-lang.c (opencl_language_defn): Initialise new field.
5653         * p-lang.c (pascal_is_string_type_p): New function.
5654         (pascal_language_defn): Initialise new field.
5655         * rust-lang.c (rust_is_string_type_p): New function.
5656         (rust_language_defn): Initialise new field.
5657
5658 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5659
5660         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5661         New field.
5662         * ada-lang.c (ada_language_defn): Initialise new field.
5663         * c-lang.c (c_language_defn): Likewise.
5664         (cplus_language_defn): Likewise.
5665         (asm_language_defn): Likewise.
5666         (minimal_language_defn): Likewise.
5667         * d-lang.c (d_language_defn): Likewise.
5668         * f-lang.c (f_language_defn): Likewise.
5669         * go-lang.c (go_language_defn): Likewise.
5670         * language.c (unknown_language_defn): Likewise.
5671         (auto_language_defn): Likewise.
5672         * m2-lang.c (m2_language_defn): Likewise.
5673         * objc-lang.c (objc_language_defn): Likewise.
5674         * opencl-lang.c (opencl_language_defn): Likewise.
5675         * p-lang.c (pascal_language_defn): Likewise.
5676         * rust-lang.c (rust_language_defn): Likewise.
5677
5678 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5679
5680         * ada-lang.c (ada_is_character_type): Change return type to bool.
5681         (ada_is_string_type): Likewise.
5682         * ada-lang.h (ada_is_character_type): Update declaration
5683         (ada_is_string_type): Likewise.
5684
5685 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5686
5687         Support style in 'frame|thread apply'
5688
5689         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5690         * record.c (record_start, record_stop): Update callers of
5691         execute_command_to_string with false.
5692         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5693         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5694         methods.
5695         (class string_file): New constructor with term_out parameter.
5696         Override methods term_out and can_emit_style_escape.  New member
5697         term_out.
5698         (class stdio_file): Override can_emit_style_escape.
5699         (class tee_file): Override term_out and can_emit_style_escape.
5700         * utils.h (can_emit_style_escape): Remove.
5701         * utils.c (can_emit_style_escape): Likewise.
5702         Update all callers of can_emit_style_escape (SOMESTREAM) to
5703         SOMESTREAM->can_emit_style_escape.
5704         * source-cache.c (source_cache::get_source_lines): Likewise.
5705         * stack.c (frame_apply_command_count): Call execute_command_to_string
5706         passing the term_out characteristic of the current gdb_stdout.
5707         * thread.c (thr_try_catch_cmd): Likewise.
5708         * top.c (execute_command_to_string): pass term_out parameter
5709         to construct the string_file for the command output.
5710         * ui-file.c (term_cli_styling): New function (most code moved
5711         from utils.c can_emit_style_escape).
5712         (string_file::string_file, string_file::can_emit_style_escape,
5713         stdio_file::can_emit_style_escape, tee_file::term_out,
5714         tee_file::can_emit_style_escape): New functions.
5715
5716 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5717
5718         * NEWS: Mention the new set|show may-call-functions.
5719         * infcall.c (may_call_functions_p): New variable.
5720         (show_may_call_functions_p): New function.
5721         (call_function_by_hand_dummy): Throws an error if not
5722         may-call-functions.
5723         (_initialize_infcall): Call add_setshow_boolean_cmd for
5724         may-call-functions.
5725
5726 2019-04-25  Keith Seitz  <keiths@redhat.com>
5727
5728         PR c++/24367
5729         * cp-support.c (inspect_type): Don't attempt substitutions
5730         of symbol with the same name.
5731
5732 2019-04-25  Tom Tromey  <tromey@adacore.com>
5733
5734         PR gdb/24475:
5735         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5736         static.
5737
5738 2019-04-25  Tom Tromey  <tromey@adacore.com>
5739
5740         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5741         rvalue reference.
5742         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5743         (gdb_xml_parser::parse): Use std::move.
5744         * python/python-internal.h (gdbpy_convert_exception): Take a const
5745         reference.
5746         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5747         std::move.
5748         * python/py-utils.c (gdbpy_convert_exception): Take a const
5749         reference.
5750         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5751         Use std::move.
5752         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5753         Use std::move.
5754         * mi/mi-main.c (mi_print_exception): Take a const reference.
5755         * main.c (handle_command_errors): Take a const reference.
5756         * linespec.c (parse_linespec): Use std::move.
5757         * infcall.c (run_inferior_call): Use std::move.
5758         (call_function_by_hand_dummy): Use std::move.
5759         * exec.c (try_open_exec_file): Use std::move.
5760         * exceptions.h (exception_print, exception_fprintf)
5761         (exception_print_same): Update.
5762         * exceptions.c (print_exception, exception_print)
5763         (exception_fprintf, exception_print_same): Change parameters to
5764         const reference.
5765         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5766         * common/new-op.c: Use std::move.
5767         * common/common-exceptions.h (struct gdb_exception): Add move
5768         constructor.
5769         (struct gdb_exception_error, struct gdb_exception_quit, struct
5770         gdb_quit_bad_alloc): Change constructor to move constructor.
5771         (throw_exception): Change parameter to rvalue reference.
5772         * common/common-exceptions.c (throw_exception): Take rvalue
5773         reference.
5774         * cli/cli-interp.c (safe_execute_command): Use std::move.
5775         * breakpoint.c (insert_bp_location, location_to_sals): Use
5776         std::move.
5777
5778 2019-04-25  Tom Tromey  <tromey@adacore.com>
5779
5780         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5781         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5782         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5783         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5784         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5785         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5786         guile/scm-value.c: Use unpack.
5787         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5788         gdbscm_gdb_exception.
5789         (gdbscm_throw_gdb_exception): Likewise.
5790         (struct gdbscm_gdb_exception): New.
5791         (unpack): New function.
5792         (gdbscm_wrap): Use unpack.
5793
5794 2019-04-25  Tom Tromey  <tromey@adacore.com>
5795
5796         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5797         (gdb_rl_callback_handler): Use std::move.
5798         * common/common-exceptions.h (struct gdb_exception): Add move
5799         assignment operator.
5800         (throw_exception_sjlj): Change "exception" to const reference.
5801         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5802         (throw_exception_sjlj): Change "exception" to const reference.
5803
5804 2019-04-25  Tom Tromey  <tromey@adacore.com>
5805
5806         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5807         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5808         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5809         Update.
5810         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5811         Update.
5812         * mi/mi-interp.c (mi_interp::exec): Update.
5813         * linespec.c (parse_linespec): Update.
5814         * infcall.c (run_inferior_call): Update.
5815         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5816         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5817         (gdbscm_lookup_global_symbol): Update.
5818         * guile/scm-param.c (gdbscm_parameter_value): Update.
5819         * guile/scm-frame.c (gdbscm_frame_read_register)
5820         (gdbscm_frame_read_var): Update.
5821         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5822         * exec.c (try_open_exec_file): Update.
5823         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5824         (gdb_rl_callback_handler): Update.
5825         * common/common-exceptions.h (exception_none): Don't declare.
5826         * common/common-exceptions.c (exception_none): Don't define.
5827         (struct catcher) <exception>: Update.
5828         * cli/cli-interp.c (safe_execute_command): Update.
5829         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5830
5831 2019-04-25  Ali Tamur  <tamur@google.com>
5832
5833         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5834         (read_attribute_value): Likewise.
5835         (dwarf2_read_addr_index): Update comment.
5836         (read_str_index): Add DW_FORM_strx.
5837         (dwarf2_string_attr): Likewise.
5838         (dwarf2_const_value_attr): Likewise.
5839         (dump_die_shallow): Likewise.
5840         (dwarf2_fetch_constant_bytes): Likewise.
5841         (skip_form_bytes): Likewise.
5842         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5843
5844 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5845
5846         PR corefiles/11608
5847         PR corefiles/18187
5848         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5849         OFFSET.  Verify if current mapping contains an ELF header.
5850         (linux_find_memory_regions_full): Adjust call to
5851         dump_mapping_p.
5852
5853 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5854             Kang Li <kanglictf@gmail.com>
5855
5856         PR gdb/21600
5857
5858         * dwarf2-frame.c (read_initial_length): Be consistent about using
5859         unsigned representation of length.
5860         (decode_frame_entry_1): Likewise.  Check for wraparound of
5861         end pointer as well as buffer overflow.
5862
5863 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5864
5865         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5866         "vq".
5867
5868 2019-04-24  Tom Tromey  <tromey@adacore.com>
5869
5870         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5871
5872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5873
5874         * s12z-tdep.c (s12z_unwind_pc): Delete.
5875         (s12z_unwind_sp): Delete.
5876         (s12z_gdbarch_init): Don't register deleted functions with
5877         gdbarch.
5878
5879 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5880
5881         * rl78-tdep.c (rl78_unwind_sp): Delete.
5882         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5883
5884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5885
5886         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5887         (xstormy16_unwind_pc): Delete.
5888         (xstormy16_dummy_id): Delete.
5889         (xstormy16_gdbarch_init): Don't register deleted functions with
5890         gdbarch.
5891
5892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5893
5894         * vax-tdep.c (vax_unwind_pc): Delete.
5895         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5896
5897 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5898
5899         * v850-tdep.c (v850_unwind_sp): Delete.
5900         (v850_unwind_pc): Delete.
5901         (v850_dummy_id): Delete.
5902         (v850_gdbarch_init): Don't register deleted functions with
5903         gdbarch.
5904
5905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5906
5907         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5908         (tilegx_unwind_pc): Delete.
5909         (tilegx_unwind_dummy_id): Delete.
5910         (tilegx_gdbarch_init): Don't register deleted functions with
5911         gdbarch.
5912
5913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5914
5915         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5916         (tic6x_dummy_id): Delete.
5917         (tic6x_gdbarch_init): Don't register deleted functions with
5918         gdbarch.
5919
5920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5921
5922         * sparc-tdep.c (sparc_unwind_pc): Delete.
5923         (sparc32_gdbarch_init): Don't register deleted function with
5924         gdbarch.
5925
5926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5927
5928         * sh-tdep.c (sh_unwind_sp): Delete.
5929         (sh_unwind_pc): Delete.
5930         (sh_dummy_id): Delete.
5931         (sh_gdbarch_init): Don't register deleted functions with
5932         gdbarch.
5933
5934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5935
5936         * score-tdep.c (score_unwind_sp): Delete.
5937         (score_unwind_pc): Delete.
5938         (score_dummy_id): Delete.
5939         (score_gdbarch_init): Don't register deleted functions with
5940         gdbarch.
5941
5942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5943
5944         * rx-tdep.c (rx_unwind_pc): Delete.
5945         (rx_unwind_sp): Delete.
5946         (rx_dummy_id): Delete.
5947         (rx_gdbarch_init): Don't register deleted functions with
5948         gdbarch.  Update comment.
5949
5950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5951
5952         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5953         (rs6000_dummy_id): Delete.
5954         (rs6000_gdbarch_init): Don't register deleted functions with
5955         gdbarch.
5956
5957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5958
5959         * or1k-tdep.c (or1k_dummy_id): Delete.
5960         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5961
5962 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5963
5964         * nios2-tdep.c (nios2_dummy_id): Delete.
5965         (nios2_unwind_sp): Delete.
5966         (nios2_gdbarch_init): Don't register deleted functions with
5967         gdbarch.
5968
5969 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5970
5971         * nds32-tdep.c (nds32_dummy_id): Delete.
5972         (nds32_unwind_pc): Delete.
5973         (nds32_unwind_sp): Delete.
5974         (nds32_gdbarch_init): Don't register deleted functions with
5975         gdbarch.
5976
5977 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5978
5979         * msp430-tdep.c (msp430_unwind_pc): Delete.
5980         (msp430_unwind_sp): Delete.
5981         (msp430_dummy_id): Delete.
5982         (msp430_gdbarch_init): Don't register deleted functions with
5983         gdbarch.
5984
5985 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5986
5987         * moxie-tdep.c (moxie_unwind_sp): Delete.
5988         (moxie_unwind_pc): Delete.
5989         (moxie_dummy_id): Delete.
5990         (moxie_gdbarch_init): Don't register deleted functions with
5991         gdbarch.
5992
5993 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5994
5995         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5996         (mn10300_unwind_pc): Delete.
5997         (mn10300_unwind_sp): Delete.
5998         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5999         mn10300_unwind_sp.
6000         (mn10300_frame_unwind_init): Don't register deleted functions with
6001         gdbarch.
6002
6003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6004
6005         * mep-tdep.c (mep_unwind_pc): Delete.
6006         (mep_unwind_sp): Delete.
6007         (mep_dummy_id): Delete.
6008         (mep_gdbarch_init): Don't register deleted functions with
6009         gdbarch.
6010
6011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6012
6013         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6014         (m68hc11_unwind_sp): Delete.
6015         (m68hc11_gdbarch_init): Don't register deleted functions with
6016         gdbarch.
6017
6018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6019
6020         * m32r-tdep.c (m32r_unwind_sp): Delete.
6021         (m32r_unwind_pc): Delete.
6022         (m32r_dummy_id): Delete.
6023         (m32r_gdbarch_init): Don't register deleted functions with
6024         gdbarch.
6025
6026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6027
6028         * m32c-tdep.c (m32c_unwind_pc): Delete.
6029         (m32c_unwind_sp): Delete.
6030         (m32c_dummy_id): Delete.
6031         (m32c_gdbarch_init): Don't register deleted functions with
6032         gdbarch.
6033
6034 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6035
6036         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6037         (lm32_unwind_pc): Delete.
6038         (lm32_dummy_id): Delete.
6039         (lm32_gdbarch_init): Don't register deleted functions with
6040         gdbarch.
6041
6042 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6043
6044         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6045         (iq2000_unwind_pc): Delete.
6046         (iq2000_dummy_id): Delete.
6047         (iq2000_gdbarch_init): Don't register deleted functions with
6048         gdbarch.
6049
6050 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6051
6052         * nds32-tdep.c (nds32_type_align): Delete.
6053         (nds32_push_dummy_call): Use type_align instead.
6054
6055 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * arm-tdep.c (arm_type_align): Only handle vector override case.
6058         (arm_push_dummy_call): Use type_align.
6059         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6060
6061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6062
6063         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6064         case.
6065         (pass_on_stack): Use type_align.
6066         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6067         function.
6068
6069 2019-04-23  Tom Tromey  <tromey@adacore.com>
6070
6071         * dwarf2read.c (line_header::file_name_at): Remove unused
6072         overload.
6073
6074 2019-04-23  Tom de Vries  <tdevries@suse.de>
6075
6076         PR gdb/24438
6077         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6078         invocation.
6079
6080
6081 2019-03-27  Ali Tamur  <tamur@google.com>
6082
6083         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6084         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6085         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6086         (dwarf_expr_context::get_addr_index): Likewise
6087         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6088         (symbol_needs_eval_context::get_addr_index): Likewise
6089         (disassemble_dwarf_expression): Add DW_OP_addrx
6090         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6091         (read_cutu_die_from_dwo): Update comment
6092         (skip_one_die): Add DW_FORM_addrx
6093         (read_attribute_value): Likewise
6094         (var_decode_location): Add DW_OP_addrx
6095         (dwarf2_const_value_attr): Add DW_FORM_addrx
6096         (dump_die_shallow): Likewise
6097         (dwarf2_fetch_constant_bytes): Likewise
6098         (decode_locdesc): Add DW_OP_addrx
6099         (skip_form_bytes): Add DW_FORM_addrx
6100
6101 2019-04-22  Ali Tamur  <tamur@google.com>
6102
6103         * MAINTAINERS (Write After Approval): Add self.
6104
6105 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6106
6107         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6108         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6109         (open_symbol_file_object): Likewise.
6110         (svr4_default_sos): Add info parameter.
6111         (svr4_read_so_list): Likewise.
6112         (svr4_current_sos_direct): Adjust functions calls to pass down
6113         info.
6114         (svr4_current_sos_1): Add info parameter.
6115         (svr4_current_sos): Call get_svr4_info, pass info down to
6116         svr4_current_sos_1.
6117         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6118         get_svr4_info.
6119         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6120         get_svr4_info.
6121         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6122         to get_svr4_info.
6123         (probes_table_remove_objfile_probes): Likewise.
6124         (register_solib_event_probe): Add info parameter.
6125         (solist_update_incremental): Pass info parameter down to
6126         svr4_read_so_list.
6127         (disable_probes_interface): Add info parameter.
6128         (svr4_handle_solib_event): Pass current_program_space to
6129         get_svr4_info.  Adjust disable_probes_interface cleanup.
6130         (svr4_create_probe_breakpoints): Add info parameter, pass it
6131         down to register_solib_event_probe.
6132         (svr4_create_solib_event_breakpoints): Add info parameter,
6133         pass it down to svr4_create_probe_breakpoints.
6134         (enable_break): Pass info down to
6135         svr4_create_solib_event_breakpoints.
6136         (svr4_solib_create_inferior_hook): Pass current_program_space to
6137         get_svr4_info.
6138         (svr4_clear_solib): Likewise.
6139
6140 2019-04-22  Pedro Alves  <palves@redhat.com>
6141
6142         * solib-svr4.c (svr4_free_objfile_observer): New.
6143         (probe_and_action::objfile): New field.
6144         (probes_table_htab_remove_objfile_probes)
6145         (probes_table_remove_objfile_probes): New functions.
6146         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6147         in the new probe_and_action.  Don't store the probe in 'lookup'.
6148         (svr4_create_probe_breakpoints): Pass objfile to
6149         register_solib_event_probe.
6150         (_initialize_svr4_solib): Register a free_objfile observer.
6151
6152 2019-04-19  Tom Tromey  <tom@tromey.com>
6153
6154         * common/queue.h: Remove.
6155
6156 2019-04-19  Tom Tromey  <tom@tromey.com>
6157
6158         * event-loop.c: Don't include "common/queue.h".
6159
6160 2019-04-19  Tom Tromey  <tom@tromey.com>
6161
6162         * remote.c (remote_target): Use delete.
6163         * remote-notif.h: Include <list>, not "common/queue.h".
6164         (notif_client_p): Remove typedef.
6165         (remote_notif_state): Add constructor, destructor, initializer.
6166         <notif_queue>: Now a std::list.
6167         (remote_notif_state_xfree): Don't declare.
6168         * remote-notif.c (remote_notif_process, handle_notification)
6169         (remote_notif_state_allocate): Update.
6170         (~remote_notif_state): Rename from remote_notif_state_xfree.
6171
6172 2019-04-19  Tom Tromey  <tom@tromey.com>
6173
6174         * symfile.c (reread_symbols): Update.
6175         * objfiles.c (objfile_register_static_link)
6176         (objfile_lookup_static_link): Update
6177         (~objfile) Don't delete static_links.
6178         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6179
6180 2019-04-19  Tom Tromey  <tom@tromey.com>
6181
6182         * type-stack.h (struct type_stack) <insert>: Constify string.
6183         * type-stack.c (type_stack::insert): Constify string.
6184         * gdbtypes.h (lookup_template_type): Update.
6185         (address_space_name_to_int): Update.
6186         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6187         const.
6188         (lookup_template_type): Make name const.
6189         * c-exp.y: Update rules.
6190         (lex_one_token, classify_name, classify_inner_name)
6191         (c_print_token): Update.
6192         * p-exp.y: Update rules.
6193         (yylex): Update.
6194         * f-exp.y: Update rules.
6195         (yylex): Update.
6196         * d-exp.y: Update rules.
6197         (lex_one_token, classify_name, classify_inner_name): Update.
6198         * parse.c (write_dollar_variable, copy_name): Return std::string.
6199         * parser-defs.h (copy_name): Change return type.
6200         * m2-exp.y: Update rules.
6201         (yylex): Update.
6202         * go-exp.y (lex_one_token): Update.
6203         Update rules.
6204         (classify_unsafe_function, classify_packaged_name)
6205         (classify_name, yylex): Update.
6206
6207 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6208
6209         * configure.ac: add --enable-source-highlight switch.
6210         * configure: Regenerate.
6211         * top.c (print_gdb_version): plumb --enable-source-highlight
6212         status to "show configuration".
6213
6214 2019-04-19  Tom Tromey  <tromey@adacore.com>
6215
6216         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6217         Check ADA_TYPE_P.
6218         (empty_record, ada_template_to_fixed_record_type_1)
6219         (template_to_static_fixed_type)
6220         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6221         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6222         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6223         macros.
6224
6225 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6226
6227         PR symtab/24423:
6228         * source.c (print_source_lines_base): Advance "iter" when a
6229         control character is seen.
6230
6231 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6232
6233         * inferior.h (struct infcall_suspend_state_deleter):
6234         Catch exception in destructor to avoid crash.
6235
6236 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6237
6238         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6239         close to the add_com "shell".
6240
6241 2019-04-18  Tom Tromey  <tromey@adacore.com>
6242
6243         * process-stratum-target.h (class process_stratum_target)
6244         <stratum>: Add "final".
6245
6246 2019-04-17  Tom Tromey  <tromey@adacore.com>
6247
6248         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6249         against nullptr before use.
6250
6251 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6252
6253         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6254
6255 2019-04-17  Jim Wilson  <jimw@sifive.com>
6256             Andrew Burgess  <andrew.burgess@embecosm.com>
6257
6258         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6259         code read might fail, assume 4-byte breakpoint in that case.
6260
6261 2019-04-15  Leszek Swirski  <leszeks@google.com>
6262
6263         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6264         rather than a hand-rolled POD check when checking for forced MEMORY
6265         classification.
6266
6267 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6268
6269         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6270         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6271         function.
6272         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6273         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6274         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6275         declaration.
6276
6277 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6278
6279         * aarch64-linux-nat.c
6280         (aarch64_linux_nat_target::thread_architecture): Add override.
6281         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6282         each VQ.
6283
6284 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6285
6286         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6287
6288 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6289
6290         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6291         target types of size 96-bits, add some additional comments, and
6292         check that the builtin type we found was the correct size.
6293
6294 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6295
6296         * utils.c (prompt_for_continue): Don't restore the styling at the
6297         end, as applied_style has the wrong value.  This fixes styling in
6298         long lists of file names that are interrupted by the "Continue?"
6299         prompt.
6300
6301 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6302
6303         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6304         * c-lang.c (c_language_defn): Likewise.
6305         (cplus_language_defn): Likewise.
6306         (asm_language_defn): Likewise.
6307         (minimal_language_defn): Likewise.
6308         * d-lang.c (d_language_defn): Likewise.
6309         * f-lang.c (f_language_defn): Likewise.
6310         * go-lang.c (go_language_defn): Likewise.
6311         * language.c (unknown_language_defn): Likewise.
6312         (auto_language_defn): Likewise.
6313         * language.h (struct language_defn): Remove la_magic field.
6314         (LANG_MAGIC): Delete.
6315         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6316         * objc-lang.c (objc_language_defn): Likewise.
6317         * opencl-lang.c (opencl_language_defn): Likewise.
6318         * p-lang.c (pascal_language_defn): Likewise.
6319         * rust-lang.c (rust_language_defn): Likewise.
6320
6321 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6322
6323         * riscv-tdep.c (riscv_type_align): New function.
6324         (riscv_type_alignment): Delete.
6325         (riscv_arg_location): Use 'type_align'.
6326         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6327
6328 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6329
6330         * gdbtypes.c (type_align): A struct with no non-static fields also
6331         has alignment of 1.
6332
6333 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6334
6335         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6336         component to 0.
6337         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6338         member.
6339         (riscv_struct_info::analyse): New implementation using new
6340         analyse_inner member function.
6341         (riscv_struct_info::field_offset): New member function.
6342         (riscv_struct_info::m_offsets): New member variable.
6343         (riscv_struct_info::analyse_inner): New private member function,
6344         takes the old implementation of riscv_struct_info::analyse but
6345         extended to track field offsets.
6346         (riscv_call_arg_struct): Update the struct folding special cases
6347         to handle cases where empty C++ structs, which are non-zero
6348         length, are found.
6349         (riscv_arg_location): Initialise the length of each location, a
6350         non-zero length now indicates the location is in use.
6351         (riscv_push_dummy_call): Allow for the first location having a
6352         non-zero offset when setting up arguments.
6353         (riscv_return_value): Likewise, but for return values.
6354
6355 2019-04-11  Tom Tromey  <tromey@adacore.com>
6356
6357         * utils.c (internal_vproblem): Make "msg" const.
6358
6359 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6360
6361         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6362         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6363         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6364         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6365
6366 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6367
6368         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6369         function.
6370         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6371         of amd64_collect_native_gregset.
6372         (amd64_linux_nat_target::store_registers): Likewise.
6373
6374 2019-04-10  Tom Tromey  <tom@tromey.com>
6375
6376         * symtab.c (lookup_global_symbol_from_objfile)
6377         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6378         * objfiles.h (class separate_debug_iterator): New.
6379         (class separate_debug_range): New.
6380         (struct objfile) <separate_debug_objfiles>: New method.
6381         (objfile_separate_debug_iterate): Don't declare.
6382         * objfiles.c (separate_debug_iterator::operator++): Rename from
6383         objfile_separate_debug_iterate.
6384         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6385         iterator.
6386         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6387         iterator.
6388
6389 2019-04-10  Tom Tromey  <tom@tromey.com>
6390
6391         * symfile.c (reread_symbols): Remove old comment.
6392         * objfiles.c (free_all_objfiles): Fix a typo.
6393
6394 2019-04-10  Tom Tromey  <tom@tromey.com>
6395
6396         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6397         * minsyms.c (lookup_minimal_symbol): Use foreach.
6398         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6399         (lookup_minimal_symbol_solib_trampoline): Likewise.
6400         * symfile.c (reread_symbols): Use foreach.
6401
6402 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6403             Tom Tromey  <tromey@adacore.com>
6404
6405         PR rust/24414:
6406         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6407         (rust_lex_int_test): Change "value" to be LONGEST.
6408         (rust_lex_tests): Add test for long integer literal.
6409
6410 2019-04-09  Tom Tromey  <tromey@adacore.com>
6411
6412         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6413         to bool.
6414         (extended_remote_target::attach): Update.
6415         (remote_target::remote_notice_new_inferior): Update.
6416         (remote_target::add_current_inferior_and_thread): Update.
6417         * inferior.c (exit_inferior_1): Use "false".
6418         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6419
6420 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6421
6422         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6423         the "start" command.
6424
6425 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6426
6427         * python/py-inferior.c (infpy_thread_from_thread_handle):
6428         Adjust comments to reflect renaming of thread_from_thread_handle
6429         to thread_from_handle.  Adjust keywords.  Fix type error message.
6430         (inferior_object_methods): Add thread_from_handle.  Retain
6431         thread_from_thread_handle, but mark it as deprecated.
6432
6433 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6434
6435         * gdbthread.h (find_thread_by_handle): Revise declaration.
6436         * thread.c (find_thread_by_handle): Likewise.  Adjust
6437         implementation too.
6438         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6439         support for buffer objects as handles.
6440
6441 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6442
6443         * python/py-infthread.c (thpy_thread_handle): New function.
6444         (thread_object_methods): Register thpy_thread_handle.
6445
6446 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6447
6448         * gdbthread.h (thread_to_thread_handle): Declare.
6449         * thread.c (gdbtypes.h): Include.
6450         (thread_to_thread_handle): New function.
6451
6452         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6453         (target_thread_info_to_thread_handle): Declare.
6454         * target.c (target_thread_info_to_thread_handle): New function.
6455         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6456         * target-delegates.c: Regenerate.
6457
6458         * linux-thread-db.c (class thread_db_target): Add method
6459         thread_info_to_thread_handle.
6460         (thread_db_target::thread_info_to_thread_handle): Define.
6461         * remote.c (class remote_target): Add new method
6462         thread_info_to_thread_handle.
6463         (remote_target::thread_info_to_thread_handle): Define.
6464
6465 2019-04-08  Pedro Alves  <palves@redhat.com>
6466
6467         * common/common-exceptions.c (throw_exception): Don't create
6468         named object to throw; throw directly.
6469         (throw_it): Likewise.  Don't initialize gdb_exception::message
6470         here, with new; pass FMT and AP to the ctor instead.
6471         * common/common-exceptions.h: Include <string>.
6472         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6473         const char *, va_list)): New ctor.  Use std::make_shared.
6474         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6475         errors)): Delete.
6476         (gdb_exception_error::gdb_exception_error(enum errors, const char
6477         *, va_list)): New.
6478         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6479         Add assertion.
6480         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6481         errors)): Delete.
6482         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6483         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6484         Add assertion.
6485
6486 2019-04-08  Tom Tromey  <tom@tromey.com>
6487
6488         * valops.c (value_rtti_indirect_type): Replace throw_exception
6489         with throw.
6490         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6491         with throw.
6492         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6493         throw.
6494         * target.c (target_translate_tls_address): Replace throw_exception
6495         with throw.
6496         * stack.c (frame_apply_command_count): Replace throw_exception
6497         with throw.
6498         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6499         throw.
6500         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6501         with throw.
6502         * rs6000-tdep.c (rs6000_frame_cache)
6503         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6504         * remote.c: Replace throw_exception with throw.
6505         * record-full.c (record_full_message, record_full_wait_1)
6506         (record_full_restore): Replace throw_exception with throw.
6507         * record-btrace.c:
6508         (get_thread_current_frame_id, record_btrace_start_replaying)
6509         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6510         (cmd_record_btrace_start): Replace throw_exception with throw.
6511         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6512         throw.
6513         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6514         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6515         * linespec.c:
6516         (find_linespec_symbols): Replace throw_exception with throw.
6517         * infrun.c (displaced_step_prepare, resume): Replace
6518         throw_exception with throw.
6519         * infcmd.c (post_create_inferior): Replace throw_exception with
6520         throw.
6521         * inf-loop.c (inferior_event_handler): Replace throw_exception
6522         with throw.
6523         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6524         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6525         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6526         (get_prev_frame_always, get_frame_pc_if_available)
6527         (get_frame_address_in_block_if_available, get_frame_language):
6528         Replace throw_exception with throw.
6529         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6530         throw_exception with throw.
6531         * eval.c (fetch_subexp_value, evaluate_var_value)
6532         (evaluate_funcall, evaluate_subexp_standard): Replace
6533         throw_exception with throw.
6534         * dwarf2loc.c (call_site_find_chain)
6535         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6536         Replace throw_exception with throw.
6537         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6538         with throw.
6539         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6540         throw.
6541         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6542         * completer.c (complete_line_internal): Replace throw_exception
6543         with throw.
6544         * compile/compile-object-run.c (compile_object_run): Replace
6545         throw_exception with throw.
6546         * cli/cli-script.c (process_next_line): Replace throw_exception
6547         with throw.
6548         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6549         (btrace_enable, btrace_maint_update_pt_packets): Replace
6550         throw_exception with throw.
6551         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6552         throw_exception with throw.
6553         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6554         throw_exception with throw.
6555         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6556         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6557         * aarch64-tdep.c (aarch64_make_prologue_cache)
6558         (aarch64_make_stub_cache): Replace throw_exception with throw.
6559
6560 2019-04-08  Tom Tromey  <tom@tromey.com>
6561
6562         * common/common-exceptions.c (throw_exception): Rename from
6563         throw_exception_cxx.  Remove old copy.  Make argument const.
6564         (throw_it): Create and throw exception objects directly.
6565         * common/common-exceptions.h (throw_exception): Make argument
6566         const.
6567         (struct gdb_exception_error): Add constructor.
6568         (struct gdb_exception_quit): Add constructor.
6569
6570 2019-04-08  Tom Tromey  <tom@tromey.com>
6571
6572         * common/common-exceptions.h (exception_rethrow): Don't declare.
6573         (TRY_SJLJ): Update comment.
6574         (TRY, CATCH, END_CATCH): Remove.
6575         * common/common-exceptions.c (exception_rethrow): Remove.
6576
6577 2019-04-08  Tom Tromey  <tom@tromey.com>
6578
6579         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6580         Remove.
6581         (gdb_exception_error): Rename from
6582         gdb_exception_RETURN_MASK_ERROR.
6583         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6584         (gdb_quit_bad_alloc): Update.
6585         * aarch64-tdep.c: Update.
6586         * ada-lang.c: Update.
6587         * ada-typeprint.c: Update.
6588         * ada-valprint.c: Update.
6589         * amd64-tdep.c: Update.
6590         * arch-utils.c: Update.
6591         * break-catch-throw.c: Update.
6592         * breakpoint.c: Update.
6593         * btrace.c: Update.
6594         * c-varobj.c: Update.
6595         * cli/cli-cmds.c: Update.
6596         * cli/cli-interp.c: Update.
6597         * cli/cli-script.c: Update.
6598         * common/common-exceptions.c: Update.
6599         * common/new-op.c: Update.
6600         * common/selftest.c: Update.
6601         * compile/compile-c-symbols.c: Update.
6602         * compile/compile-cplus-symbols.c: Update.
6603         * compile/compile-object-load.c: Update.
6604         * compile/compile-object-run.c: Update.
6605         * completer.c: Update.
6606         * corelow.c: Update.
6607         * cp-abi.c: Update.
6608         * cp-support.c: Update.
6609         * cp-valprint.c: Update.
6610         * darwin-nat.c: Update.
6611         * disasm-selftests.c: Update.
6612         * dtrace-probe.c: Update.
6613         * dwarf-index-cache.c: Update.
6614         * dwarf-index-write.c: Update.
6615         * dwarf2-frame-tailcall.c: Update.
6616         * dwarf2-frame.c: Update.
6617         * dwarf2loc.c: Update.
6618         * dwarf2read.c: Update.
6619         * eval.c: Update.
6620         * event-loop.c: Update.
6621         * event-top.c: Update.
6622         * exec.c: Update.
6623         * f-valprint.c: Update.
6624         * fbsd-tdep.c: Update.
6625         * frame-unwind.c: Update.
6626         * frame.c: Update.
6627         * gdbtypes.c: Update.
6628         * gnu-v3-abi.c: Update.
6629         * guile/guile-internal.h: Update.
6630         * guile/scm-block.c: Update.
6631         * guile/scm-breakpoint.c: Update.
6632         * guile/scm-cmd.c: Update.
6633         * guile/scm-disasm.c: Update.
6634         * guile/scm-frame.c: Update.
6635         * guile/scm-lazy-string.c: Update.
6636         * guile/scm-math.c: Update.
6637         * guile/scm-param.c: Update.
6638         * guile/scm-ports.c: Update.
6639         * guile/scm-pretty-print.c: Update.
6640         * guile/scm-symbol.c: Update.
6641         * guile/scm-symtab.c: Update.
6642         * guile/scm-type.c: Update.
6643         * guile/scm-value.c: Update.
6644         * i386-linux-tdep.c: Update.
6645         * i386-tdep.c: Update.
6646         * inf-loop.c: Update.
6647         * infcall.c: Update.
6648         * infcmd.c: Update.
6649         * infrun.c: Update.
6650         * jit.c: Update.
6651         * language.c: Update.
6652         * linespec.c: Update.
6653         * linux-fork.c: Update.
6654         * linux-nat.c: Update.
6655         * linux-tdep.c: Update.
6656         * linux-thread-db.c: Update.
6657         * main.c: Update.
6658         * mi/mi-cmd-break.c: Update.
6659         * mi/mi-cmd-stack.c: Update.
6660         * mi/mi-interp.c: Update.
6661         * mi/mi-main.c: Update.
6662         * objc-lang.c: Update.
6663         * p-valprint.c: Update.
6664         * parse.c: Update.
6665         * ppc-linux-tdep.c: Update.
6666         * printcmd.c: Update.
6667         * python/py-arch.c: Update.
6668         * python/py-breakpoint.c: Update.
6669         * python/py-cmd.c: Update.
6670         * python/py-finishbreakpoint.c: Update.
6671         * python/py-frame.c: Update.
6672         * python/py-framefilter.c: Update.
6673         * python/py-gdb-readline.c: Update.
6674         * python/py-inferior.c: Update.
6675         * python/py-infthread.c: Update.
6676         * python/py-lazy-string.c: Update.
6677         * python/py-linetable.c: Update.
6678         * python/py-objfile.c: Update.
6679         * python/py-param.c: Update.
6680         * python/py-prettyprint.c: Update.
6681         * python/py-progspace.c: Update.
6682         * python/py-record-btrace.c: Update.
6683         * python/py-record.c: Update.
6684         * python/py-symbol.c: Update.
6685         * python/py-type.c: Update.
6686         * python/py-unwind.c: Update.
6687         * python/py-utils.c: Update.
6688         * python/py-value.c: Update.
6689         * python/python.c: Update.
6690         * record-btrace.c: Update.
6691         * record-full.c: Update.
6692         * remote-fileio.c: Update.
6693         * remote.c: Update.
6694         * riscv-tdep.c: Update.
6695         * rs6000-aix-tdep.c: Update.
6696         * rs6000-tdep.c: Update.
6697         * rust-exp.y: Update.
6698         * rust-lang.c: Update.
6699         * s390-tdep.c: Update.
6700         * selftest-arch.c: Update.
6701         * solib-dsbt.c: Update.
6702         * solib-frv.c: Update.
6703         * solib-spu.c: Update.
6704         * solib-svr4.c: Update.
6705         * solib.c: Update.
6706         * sparc64-linux-tdep.c: Update.
6707         * stack.c: Update.
6708         * symfile-mem.c: Update.
6709         * symmisc.c: Update.
6710         * target.c: Update.
6711         * thread.c: Update.
6712         * top.c: Update.
6713         * tracefile-tfile.c: Update.
6714         * tui/tui.c: Update.
6715         * typeprint.c: Update.
6716         * unittests/cli-utils-selftests.c: Update.
6717         * unittests/parse-connection-spec-selftests.c: Update.
6718         * valops.c: Update.
6719         * valprint.c: Update.
6720         * value.c: Update.
6721         * varobj.c: Update.
6722         * windows-nat.c: Update.
6723         * x86-linux-nat.c: Update.
6724         * xml-support.c: Update.
6725
6726 2019-04-08  Tom Tromey  <tom@tromey.com>
6727
6728         * xml-support.c: Use C++ exception handling.
6729         * x86-linux-nat.c: Use C++ exception handling.
6730         * windows-nat.c: Use C++ exception handling.
6731         * varobj.c: Use C++ exception handling.
6732         * value.c: Use C++ exception handling.
6733         * valprint.c: Use C++ exception handling.
6734         * valops.c: Use C++ exception handling.
6735         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6736         handling.
6737         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6738         * typeprint.c: Use C++ exception handling.
6739         * tui/tui.c: Use C++ exception handling.
6740         * tracefile-tfile.c: Use C++ exception handling.
6741         * top.c: Use C++ exception handling.
6742         * thread.c: Use C++ exception handling.
6743         * target.c: Use C++ exception handling.
6744         * symmisc.c: Use C++ exception handling.
6745         * symfile-mem.c: Use C++ exception handling.
6746         * stack.c: Use C++ exception handling.
6747         * sparc64-linux-tdep.c: Use C++ exception handling.
6748         * solib.c: Use C++ exception handling.
6749         * solib-svr4.c: Use C++ exception handling.
6750         * solib-spu.c: Use C++ exception handling.
6751         * solib-frv.c: Use C++ exception handling.
6752         * solib-dsbt.c: Use C++ exception handling.
6753         * selftest-arch.c: Use C++ exception handling.
6754         * s390-tdep.c: Use C++ exception handling.
6755         * rust-lang.c: Use C++ exception handling.
6756         * rust-exp.y: Use C++ exception handling.
6757         * rs6000-tdep.c: Use C++ exception handling.
6758         * rs6000-aix-tdep.c: Use C++ exception handling.
6759         * riscv-tdep.c: Use C++ exception handling.
6760         * remote.c: Use C++ exception handling.
6761         * remote-fileio.c: Use C++ exception handling.
6762         * record-full.c: Use C++ exception handling.
6763         * record-btrace.c: Use C++ exception handling.
6764         * python/python.c: Use C++ exception handling.
6765         * python/py-value.c: Use C++ exception handling.
6766         * python/py-utils.c: Use C++ exception handling.
6767         * python/py-unwind.c: Use C++ exception handling.
6768         * python/py-type.c: Use C++ exception handling.
6769         * python/py-symbol.c: Use C++ exception handling.
6770         * python/py-record.c: Use C++ exception handling.
6771         * python/py-record-btrace.c: Use C++ exception handling.
6772         * python/py-progspace.c: Use C++ exception handling.
6773         * python/py-prettyprint.c: Use C++ exception handling.
6774         * python/py-param.c: Use C++ exception handling.
6775         * python/py-objfile.c: Use C++ exception handling.
6776         * python/py-linetable.c: Use C++ exception handling.
6777         * python/py-lazy-string.c: Use C++ exception handling.
6778         * python/py-infthread.c: Use C++ exception handling.
6779         * python/py-inferior.c: Use C++ exception handling.
6780         * python/py-gdb-readline.c: Use C++ exception handling.
6781         * python/py-framefilter.c: Use C++ exception handling.
6782         * python/py-frame.c: Use C++ exception handling.
6783         * python/py-finishbreakpoint.c: Use C++ exception handling.
6784         * python/py-cmd.c: Use C++ exception handling.
6785         * python/py-breakpoint.c: Use C++ exception handling.
6786         * python/py-arch.c: Use C++ exception handling.
6787         * printcmd.c: Use C++ exception handling.
6788         * ppc-linux-tdep.c: Use C++ exception handling.
6789         * parse.c: Use C++ exception handling.
6790         * p-valprint.c: Use C++ exception handling.
6791         * objc-lang.c: Use C++ exception handling.
6792         * mi/mi-main.c: Use C++ exception handling.
6793         * mi/mi-interp.c: Use C++ exception handling.
6794         * mi/mi-cmd-stack.c: Use C++ exception handling.
6795         * mi/mi-cmd-break.c: Use C++ exception handling.
6796         * main.c: Use C++ exception handling.
6797         * linux-thread-db.c: Use C++ exception handling.
6798         * linux-tdep.c: Use C++ exception handling.
6799         * linux-nat.c: Use C++ exception handling.
6800         * linux-fork.c: Use C++ exception handling.
6801         * linespec.c: Use C++ exception handling.
6802         * language.c: Use C++ exception handling.
6803         * jit.c: Use C++ exception handling.
6804         * infrun.c: Use C++ exception handling.
6805         * infcmd.c: Use C++ exception handling.
6806         * infcall.c: Use C++ exception handling.
6807         * inf-loop.c: Use C++ exception handling.
6808         * i386-tdep.c: Use C++ exception handling.
6809         * i386-linux-tdep.c: Use C++ exception handling.
6810         * guile/scm-value.c: Use C++ exception handling.
6811         * guile/scm-type.c: Use C++ exception handling.
6812         * guile/scm-symtab.c: Use C++ exception handling.
6813         * guile/scm-symbol.c: Use C++ exception handling.
6814         * guile/scm-pretty-print.c: Use C++ exception handling.
6815         * guile/scm-ports.c: Use C++ exception handling.
6816         * guile/scm-param.c: Use C++ exception handling.
6817         * guile/scm-math.c: Use C++ exception handling.
6818         * guile/scm-lazy-string.c: Use C++ exception handling.
6819         * guile/scm-frame.c: Use C++ exception handling.
6820         * guile/scm-disasm.c: Use C++ exception handling.
6821         * guile/scm-cmd.c: Use C++ exception handling.
6822         * guile/scm-breakpoint.c: Use C++ exception handling.
6823         * guile/scm-block.c: Use C++ exception handling.
6824         * guile/guile-internal.h: Use C++ exception handling.
6825         * gnu-v3-abi.c: Use C++ exception handling.
6826         * gdbtypes.c: Use C++ exception handling.
6827         * frame.c: Use C++ exception handling.
6828         * frame-unwind.c: Use C++ exception handling.
6829         * fbsd-tdep.c: Use C++ exception handling.
6830         * f-valprint.c: Use C++ exception handling.
6831         * exec.c: Use C++ exception handling.
6832         * event-top.c: Use C++ exception handling.
6833         * event-loop.c: Use C++ exception handling.
6834         * eval.c: Use C++ exception handling.
6835         * dwarf2read.c: Use C++ exception handling.
6836         * dwarf2loc.c: Use C++ exception handling.
6837         * dwarf2-frame.c: Use C++ exception handling.
6838         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6839         * dwarf-index-write.c: Use C++ exception handling.
6840         * dwarf-index-cache.c: Use C++ exception handling.
6841         * dtrace-probe.c: Use C++ exception handling.
6842         * disasm-selftests.c: Use C++ exception handling.
6843         * darwin-nat.c: Use C++ exception handling.
6844         * cp-valprint.c: Use C++ exception handling.
6845         * cp-support.c: Use C++ exception handling.
6846         * cp-abi.c: Use C++ exception handling.
6847         * corelow.c: Use C++ exception handling.
6848         * completer.c: Use C++ exception handling.
6849         * compile/compile-object-run.c: Use C++ exception handling.
6850         * compile/compile-object-load.c: Use C++ exception handling.
6851         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6852         * compile/compile-c-symbols.c: Use C++ exception handling.
6853         * common/selftest.c: Use C++ exception handling.
6854         * common/new-op.c: Use C++ exception handling.
6855         * cli/cli-script.c: Use C++ exception handling.
6856         * cli/cli-interp.c: Use C++ exception handling.
6857         * cli/cli-cmds.c: Use C++ exception handling.
6858         * c-varobj.c: Use C++ exception handling.
6859         * btrace.c: Use C++ exception handling.
6860         * breakpoint.c: Use C++ exception handling.
6861         * break-catch-throw.c: Use C++ exception handling.
6862         * arch-utils.c: Use C++ exception handling.
6863         * amd64-tdep.c: Use C++ exception handling.
6864         * ada-valprint.c: Use C++ exception handling.
6865         * ada-typeprint.c: Use C++ exception handling.
6866         * ada-lang.c: Use C++ exception handling.
6867         * aarch64-tdep.c: Use C++ exception handling.
6868
6869 2019-04-08  Tom Tromey  <tom@tromey.com>
6870
6871         * xml-support.c (gdb_xml_parser::parse): Update.
6872         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6873         * value.c (show_convenience): Update.
6874         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6875         (test_parse_flags_qcs): Update.
6876         * thread.c (thr_try_catch_cmd): Update.
6877         * target.c (target_translate_tls_address): Update.
6878         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6879         (info_frame_command_core, frame_apply_command_count): Update.
6880         * rust-exp.y (rust_lex_exception_test): Update.
6881         * riscv-tdep.c (riscv_print_one_register_info): Update.
6882         * remote.c (remote_target::enable_btrace): Update.
6883         * record-btrace.c (record_btrace_enable_warn): Update.
6884         * python/py-utils.c (gdbpy_convert_exception): Update.
6885         * printcmd.c (do_one_display, print_variable_and_value): Update.
6886         * mi/mi-main.c (mi_print_exception): Update.
6887         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6888         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6889         * linux-nat.c (linux_nat_target::attach): Update.
6890         * linux-fork.c (class scoped_switch_fork_info): Update.
6891         * infrun.c (displaced_step_prepare): Update.
6892         * infcall.c (call_function_by_hand_dummy): Update.
6893         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6894         * gnu-v3-abi.c (print_one_vtable): Update.
6895         * frame.c (get_prev_frame_always): Update.
6896         * f-valprint.c (info_common_command_for_block): Update.
6897         * exec.c (try_open_exec_file): Update.
6898         * exceptions.c (print_exception, exception_print)
6899         (exception_fprintf, exception_print_same): Update.
6900         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6901         * dwarf-index-cache.c (index_cache::store)
6902         (index_cache::lookup_gdb_index): Update.
6903         * darwin-nat.c (maybe_cache_shell): Update.
6904         * cp-valprint.c (cp_print_value_fields): Update.
6905         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6906         (gcc_cplus_symbol_address): Update.
6907         * compile/compile-c-symbols.c (gcc_convert_symbol)
6908         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6909         * common/selftest.c: Update.
6910         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6911         a std::string.
6912         (exception_try_scope_entry, exception_try_scope_exit): Don't
6913         declare.
6914         (struct exception_try_scope): Remove.
6915         (TRY): Don't use exception_try_scope.
6916         (struct gdb_exception): Add constructor, operator=.
6917         <what>: New method.
6918         (struct gdb_exception_RETURN_MASK_ALL)
6919         (struct gdb_exception_RETURN_MASK_ERROR)
6920         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6921         (struct gdb_quit_bad_alloc): Update.
6922         * common/common-exceptions.c (exception_none): Change
6923         initializer.
6924         (struct catcher) <state, exception>: Initialize inline.
6925         <prev>: Remove member.
6926         (current_catcher): Remove.
6927         (catchers): New global.
6928         (exceptions_state_mc_init): Simplify.
6929         (catcher_pop): Remove.
6930         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6931         (try_scope_depth, exception_try_scope_entry)
6932         (exception_try_scope_exit): Remove.
6933         (throw_exception_sjlj): Update.
6934         (exception_messages, exception_messages_size): Remove.
6935         (throw_it): Simplify.
6936         (gdb_exception_sliced_copy): Remove.
6937         (throw_exception_cxx): Update.
6938         * cli/cli-script.c (script_from_file): Update.
6939         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6940         Update.
6941         * ada-valprint.c (ada_val_print): Update.
6942         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6943         (create_excep_cond_exprs): Update.
6944
6945 2019-04-08  Tom Tromey  <tom@tromey.com>
6946
6947         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6948         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6949         (TRY, CATCH, END_CATCH): Remove some definitions.
6950         * common/common-exceptions.c: Don't use GDB_XCPT.
6951         (catcher_list_size): Remove.
6952         (throw_exception, throw_it): Simplify.
6953
6954 2019-04-05  Tom Tromey  <tom@tromey.com>
6955
6956         Revert the header-sorting patch.
6957         * ft32-tdep.c: Revert.
6958         * frv-tdep.c: Revert.
6959         * frv-linux-tdep.c: Revert.
6960         * frame.c: Revert.
6961         * frame-unwind.c: Revert.
6962         * frame-base.c: Revert.
6963         * fork-child.c: Revert.
6964         * findvar.c: Revert.
6965         * findcmd.c: Revert.
6966         * filesystem.c: Revert.
6967         * filename-seen-cache.h: Revert.
6968         * filename-seen-cache.c: Revert.
6969         * fbsd-tdep.c: Revert.
6970         * fbsd-nat.h: Revert.
6971         * fbsd-nat.c: Revert.
6972         * f-valprint.c: Revert.
6973         * f-typeprint.c: Revert.
6974         * f-lang.c: Revert.
6975         * extension.h: Revert.
6976         * extension.c: Revert.
6977         * extension-priv.h: Revert.
6978         * expprint.c: Revert.
6979         * exec.h: Revert.
6980         * exec.c: Revert.
6981         * exceptions.c: Revert.
6982         * event-top.c: Revert.
6983         * event-loop.c: Revert.
6984         * eval.c: Revert.
6985         * elfread.c: Revert.
6986         * dwarf2read.h: Revert.
6987         * dwarf2read.c: Revert.
6988         * dwarf2loc.c: Revert.
6989         * dwarf2expr.h: Revert.
6990         * dwarf2expr.c: Revert.
6991         * dwarf2-frame.c: Revert.
6992         * dwarf2-frame-tailcall.c: Revert.
6993         * dwarf-index-write.h: Revert.
6994         * dwarf-index-write.c: Revert.
6995         * dwarf-index-common.c: Revert.
6996         * dwarf-index-cache.h: Revert.
6997         * dwarf-index-cache.c: Revert.
6998         * dummy-frame.c: Revert.
6999         * dtrace-probe.c: Revert.
7000         * disasm.h: Revert.
7001         * disasm.c: Revert.
7002         * disasm-selftests.c: Revert.
7003         * dictionary.c: Revert.
7004         * dicos-tdep.c: Revert.
7005         * demangle.c: Revert.
7006         * dcache.h: Revert.
7007         * dcache.c: Revert.
7008         * darwin-nat.h: Revert.
7009         * darwin-nat.c: Revert.
7010         * darwin-nat-info.c: Revert.
7011         * d-valprint.c: Revert.
7012         * d-namespace.c: Revert.
7013         * d-lang.c: Revert.
7014         * ctf.c: Revert.
7015         * csky-tdep.c: Revert.
7016         * csky-linux-tdep.c: Revert.
7017         * cris-tdep.c: Revert.
7018         * cris-linux-tdep.c: Revert.
7019         * cp-valprint.c: Revert.
7020         * cp-support.c: Revert.
7021         * cp-namespace.c: Revert.
7022         * cp-abi.c: Revert.
7023         * corelow.c: Revert.
7024         * corefile.c: Revert.
7025         * continuations.c: Revert.
7026         * completer.h: Revert.
7027         * completer.c: Revert.
7028         * complaints.c: Revert.
7029         * coffread.c: Revert.
7030         * coff-pe-read.c: Revert.
7031         * cli-out.h: Revert.
7032         * cli-out.c: Revert.
7033         * charset.c: Revert.
7034         * c-varobj.c: Revert.
7035         * c-valprint.c: Revert.
7036         * c-typeprint.c: Revert.
7037         * c-lang.c: Revert.
7038         * buildsym.c: Revert.
7039         * buildsym-legacy.c: Revert.
7040         * build-id.h: Revert.
7041         * build-id.c: Revert.
7042         * btrace.c: Revert.
7043         * bsd-uthread.c: Revert.
7044         * breakpoint.h: Revert.
7045         * breakpoint.c: Revert.
7046         * break-catch-throw.c: Revert.
7047         * break-catch-syscall.c: Revert.
7048         * break-catch-sig.c: Revert.
7049         * blockframe.c: Revert.
7050         * block.c: Revert.
7051         * bfin-tdep.c: Revert.
7052         * bfin-linux-tdep.c: Revert.
7053         * bfd-target.c: Revert.
7054         * bcache.c: Revert.
7055         * ax-general.c: Revert.
7056         * ax-gdb.h: Revert.
7057         * ax-gdb.c: Revert.
7058         * avr-tdep.c: Revert.
7059         * auxv.c: Revert.
7060         * auto-load.c: Revert.
7061         * arm-wince-tdep.c: Revert.
7062         * arm-tdep.c: Revert.
7063         * arm-symbian-tdep.c: Revert.
7064         * arm-pikeos-tdep.c: Revert.
7065         * arm-obsd-tdep.c: Revert.
7066         * arm-nbsd-tdep.c: Revert.
7067         * arm-nbsd-nat.c: Revert.
7068         * arm-linux-tdep.c: Revert.
7069         * arm-linux-nat.c: Revert.
7070         * arm-fbsd-tdep.c: Revert.
7071         * arm-fbsd-nat.c: Revert.
7072         * arm-bsd-tdep.c: Revert.
7073         * arch-utils.c: Revert.
7074         * arc-tdep.c: Revert.
7075         * arc-newlib-tdep.c: Revert.
7076         * annotate.h: Revert.
7077         * annotate.c: Revert.
7078         * amd64-windows-tdep.c: Revert.
7079         * amd64-windows-nat.c: Revert.
7080         * amd64-tdep.c: Revert.
7081         * amd64-sol2-tdep.c: Revert.
7082         * amd64-obsd-tdep.c: Revert.
7083         * amd64-obsd-nat.c: Revert.
7084         * amd64-nbsd-tdep.c: Revert.
7085         * amd64-nbsd-nat.c: Revert.
7086         * amd64-nat.c: Revert.
7087         * amd64-linux-tdep.c: Revert.
7088         * amd64-linux-nat.c: Revert.
7089         * amd64-fbsd-tdep.c: Revert.
7090         * amd64-fbsd-nat.c: Revert.
7091         * amd64-dicos-tdep.c: Revert.
7092         * amd64-darwin-tdep.c: Revert.
7093         * amd64-bsd-nat.c: Revert.
7094         * alpha-tdep.c: Revert.
7095         * alpha-obsd-tdep.c: Revert.
7096         * alpha-nbsd-tdep.c: Revert.
7097         * alpha-mdebug-tdep.c: Revert.
7098         * alpha-linux-tdep.c: Revert.
7099         * alpha-linux-nat.c: Revert.
7100         * alpha-bsd-tdep.c: Revert.
7101         * alpha-bsd-nat.c: Revert.
7102         * aix-thread.c: Revert.
7103         * agent.c: Revert.
7104         * addrmap.c: Revert.
7105         * ada-varobj.c: Revert.
7106         * ada-valprint.c: Revert.
7107         * ada-typeprint.c: Revert.
7108         * ada-tasks.c: Revert.
7109         * ada-lang.c: Revert.
7110         * aarch64-tdep.c: Revert.
7111         * aarch64-ravenscar-thread.c: Revert.
7112         * aarch64-newlib-tdep.c: Revert.
7113         * aarch64-linux-tdep.c: Revert.
7114         * aarch64-linux-nat.c: Revert.
7115         * aarch64-fbsd-tdep.c: Revert.
7116         * aarch64-fbsd-nat.c: Revert.
7117         * aarch32-linux-nat.c: Revert.
7118
7119 2019-04-05  Tom Tromey  <tom@tromey.com>
7120
7121         * ft32-tdep.c: Sort headers.
7122         * frv-tdep.c: Sort headers.
7123         * frv-linux-tdep.c: Sort headers.
7124         * frame.c: Sort headers.
7125         * frame-unwind.c: Sort headers.
7126         * frame-base.c: Sort headers.
7127         * fork-child.c: Sort headers.
7128         * findvar.c: Sort headers.
7129         * findcmd.c: Sort headers.
7130         * filesystem.c: Sort headers.
7131         * filename-seen-cache.h: Sort headers.
7132         * filename-seen-cache.c: Sort headers.
7133         * fbsd-tdep.c: Sort headers.
7134         * fbsd-nat.h: Sort headers.
7135         * fbsd-nat.c: Sort headers.
7136         * f-valprint.c: Sort headers.
7137         * f-typeprint.c: Sort headers.
7138         * f-lang.c: Sort headers.
7139         * extension.h: Sort headers.
7140         * extension.c: Sort headers.
7141         * extension-priv.h: Sort headers.
7142         * expprint.c: Sort headers.
7143         * exec.h: Sort headers.
7144         * exec.c: Sort headers.
7145         * exceptions.c: Sort headers.
7146         * event-top.c: Sort headers.
7147         * event-loop.c: Sort headers.
7148         * eval.c: Sort headers.
7149         * elfread.c: Sort headers.
7150         * dwarf2read.h: Sort headers.
7151         * dwarf2read.c: Sort headers.
7152         * dwarf2loc.c: Sort headers.
7153         * dwarf2expr.h: Sort headers.
7154         * dwarf2expr.c: Sort headers.
7155         * dwarf2-frame.c: Sort headers.
7156         * dwarf2-frame-tailcall.c: Sort headers.
7157         * dwarf-index-write.h: Sort headers.
7158         * dwarf-index-write.c: Sort headers.
7159         * dwarf-index-common.c: Sort headers.
7160         * dwarf-index-cache.h: Sort headers.
7161         * dwarf-index-cache.c: Sort headers.
7162         * dummy-frame.c: Sort headers.
7163         * dtrace-probe.c: Sort headers.
7164         * disasm.h: Sort headers.
7165         * disasm.c: Sort headers.
7166         * disasm-selftests.c: Sort headers.
7167         * dictionary.c: Sort headers.
7168         * dicos-tdep.c: Sort headers.
7169         * demangle.c: Sort headers.
7170         * dcache.h: Sort headers.
7171         * dcache.c: Sort headers.
7172         * darwin-nat.h: Sort headers.
7173         * darwin-nat.c: Sort headers.
7174         * darwin-nat-info.c: Sort headers.
7175         * d-valprint.c: Sort headers.
7176         * d-namespace.c: Sort headers.
7177         * d-lang.c: Sort headers.
7178         * ctf.c: Sort headers.
7179         * csky-tdep.c: Sort headers.
7180         * csky-linux-tdep.c: Sort headers.
7181         * cris-tdep.c: Sort headers.
7182         * cris-linux-tdep.c: Sort headers.
7183         * cp-valprint.c: Sort headers.
7184         * cp-support.c: Sort headers.
7185         * cp-namespace.c: Sort headers.
7186         * cp-abi.c: Sort headers.
7187         * corelow.c: Sort headers.
7188         * corefile.c: Sort headers.
7189         * continuations.c: Sort headers.
7190         * completer.h: Sort headers.
7191         * completer.c: Sort headers.
7192         * complaints.c: Sort headers.
7193         * coffread.c: Sort headers.
7194         * coff-pe-read.c: Sort headers.
7195         * cli-out.h: Sort headers.
7196         * cli-out.c: Sort headers.
7197         * charset.c: Sort headers.
7198         * c-varobj.c: Sort headers.
7199         * c-valprint.c: Sort headers.
7200         * c-typeprint.c: Sort headers.
7201         * c-lang.c: Sort headers.
7202         * buildsym.c: Sort headers.
7203         * buildsym-legacy.c: Sort headers.
7204         * build-id.h: Sort headers.
7205         * build-id.c: Sort headers.
7206         * btrace.c: Sort headers.
7207         * bsd-uthread.c: Sort headers.
7208         * breakpoint.h: Sort headers.
7209         * breakpoint.c: Sort headers.
7210         * break-catch-throw.c: Sort headers.
7211         * break-catch-syscall.c: Sort headers.
7212         * break-catch-sig.c: Sort headers.
7213         * blockframe.c: Sort headers.
7214         * block.c: Sort headers.
7215         * bfin-tdep.c: Sort headers.
7216         * bfin-linux-tdep.c: Sort headers.
7217         * bfd-target.c: Sort headers.
7218         * bcache.c: Sort headers.
7219         * ax-general.c: Sort headers.
7220         * ax-gdb.h: Sort headers.
7221         * ax-gdb.c: Sort headers.
7222         * avr-tdep.c: Sort headers.
7223         * auxv.c: Sort headers.
7224         * auto-load.c: Sort headers.
7225         * arm-wince-tdep.c: Sort headers.
7226         * arm-tdep.c: Sort headers.
7227         * arm-symbian-tdep.c: Sort headers.
7228         * arm-pikeos-tdep.c: Sort headers.
7229         * arm-obsd-tdep.c: Sort headers.
7230         * arm-nbsd-tdep.c: Sort headers.
7231         * arm-nbsd-nat.c: Sort headers.
7232         * arm-linux-tdep.c: Sort headers.
7233         * arm-linux-nat.c: Sort headers.
7234         * arm-fbsd-tdep.c: Sort headers.
7235         * arm-fbsd-nat.c: Sort headers.
7236         * arm-bsd-tdep.c: Sort headers.
7237         * arch-utils.c: Sort headers.
7238         * arc-tdep.c: Sort headers.
7239         * arc-newlib-tdep.c: Sort headers.
7240         * annotate.h: Sort headers.
7241         * annotate.c: Sort headers.
7242         * amd64-windows-tdep.c: Sort headers.
7243         * amd64-windows-nat.c: Sort headers.
7244         * amd64-tdep.c: Sort headers.
7245         * amd64-sol2-tdep.c: Sort headers.
7246         * amd64-obsd-tdep.c: Sort headers.
7247         * amd64-obsd-nat.c: Sort headers.
7248         * amd64-nbsd-tdep.c: Sort headers.
7249         * amd64-nbsd-nat.c: Sort headers.
7250         * amd64-nat.c: Sort headers.
7251         * amd64-linux-tdep.c: Sort headers.
7252         * amd64-linux-nat.c: Sort headers.
7253         * amd64-fbsd-tdep.c: Sort headers.
7254         * amd64-fbsd-nat.c: Sort headers.
7255         * amd64-dicos-tdep.c: Sort headers.
7256         * amd64-darwin-tdep.c: Sort headers.
7257         * amd64-bsd-nat.c: Sort headers.
7258         * alpha-tdep.c: Sort headers.
7259         * alpha-obsd-tdep.c: Sort headers.
7260         * alpha-nbsd-tdep.c: Sort headers.
7261         * alpha-mdebug-tdep.c: Sort headers.
7262         * alpha-linux-tdep.c: Sort headers.
7263         * alpha-linux-nat.c: Sort headers.
7264         * alpha-bsd-tdep.c: Sort headers.
7265         * alpha-bsd-nat.c: Sort headers.
7266         * aix-thread.c: Sort headers.
7267         * agent.c: Sort headers.
7268         * addrmap.c: Sort headers.
7269         * ada-varobj.c: Sort headers.
7270         * ada-valprint.c: Sort headers.
7271         * ada-typeprint.c: Sort headers.
7272         * ada-tasks.c: Sort headers.
7273         * ada-lang.c: Sort headers.
7274         * aarch64-tdep.c: Sort headers.
7275         * aarch64-ravenscar-thread.c: Sort headers.
7276         * aarch64-newlib-tdep.c: Sort headers.
7277         * aarch64-linux-tdep.c: Sort headers.
7278         * aarch64-linux-nat.c: Sort headers.
7279         * aarch64-fbsd-tdep.c: Sort headers.
7280         * aarch64-fbsd-nat.c: Sort headers.
7281         * aarch32-linux-nat.c: Sort headers.
7282
7283 2019-04-04  Tom Tromey  <tom@tromey.com>
7284
7285         * varobj.c (varobj_create): Update.
7286         * rust-exp.y (struct rust_parser) <update_innermost_block,
7287         lookup_symbol>: New methods.
7288         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7289         Rename.
7290         (rust_parser::rust_lookup_type)
7291         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7292         * printcmd.c (display_command, do_one_display): Update.
7293         * parser-defs.h (struct parser_state) <parser_state>: Add
7294         "tracker" parameter.
7295         (block_tracker): New member.
7296         (class innermost_block_tracker) <innermost_block_tracker>: Add
7297         "types" parameter.
7298         <reset>: Remove method.
7299         (innermost_block): Don't declare.
7300         (null_post_parser): Update.
7301         * parse.c (innermost_block): Remove global.
7302         (write_dollar_variable): Update.
7303         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7304         Remove "tracker_types" parameter.
7305         (parse_expression): Add "tracker" parameter.
7306         (parse_expression_for_completion): Update.
7307         (null_post_parser): Add "tracker" parameter.
7308         * p-exp.y: Update rules.
7309         * m2-exp.y: Update rules.
7310         * language.h (struct language_defn) <la_post_parser>: Add
7311         "tracker" parameter.
7312         * go-exp.y: Update rules.
7313         * f-exp.y: Update rules.
7314         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7315         parameter.
7316         * d-exp.y: Update rules.
7317         * c-exp.y: Update rules.
7318         * breakpoint.c (set_breakpoint_condition): Create an
7319         innermost_block_tracker.
7320         (watch_command_1): Likewise.
7321         * ada-lang.c (resolve): Add "tracker" parameter.
7322         (resolve_subexp): Likewise.
7323         * ada-exp.y (write_var_from_sym): Update.
7324
7325 2019-04-04  Tom Tromey  <tom@tromey.com>
7326
7327         * type-stack.h: New file.
7328         * type-stack.c: New file.
7329         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7330         type-stack.h.
7331         (insert_into_type_stack, insert_type, push_type, push_type_int)
7332         (insert_type_address_space, pop_type, pop_type_int)
7333         (pop_typelist, pop_type_stack, append_type_stack)
7334         (push_type_stack, get_type_stack, push_typelist)
7335         (follow_type_instance_flags, follow_types): Don't declare.
7336         * parse.c (type_stack): Remove global.
7337         (parse_exp_in_context): Update.
7338         (insert_into_type_stack, insert_type, push_type, push_type_int)
7339         (insert_type_address_space, pop_type, pop_type_int)
7340         (pop_typelist, pop_type_stack, append_type_stack)
7341         (push_type_stack, get_type_stack, push_typelist)
7342         (follow_type_instance_flags, follow_types): Remove (moved to
7343         type-stack.c).
7344         * f-exp.y (type_stack): New global.
7345         Update rules.
7346         (push_kind_type, f_parse): Update.
7347         * d-exp.y (type_stack): New global.
7348         Update rules.
7349         (d_parse): Update.
7350         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7351         Update rules.
7352         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7353         (HFILES_NO_SRCDIR): Add type-stack.h.
7354
7355 2019-04-04  Tom Tromey  <tom@tromey.com>
7356
7357         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7358         (rust_parser::convert_ast_to_expression, rust_parse)
7359         (rust_lex_test_completion, rust_lex_tests): Update.
7360         * parser-defs.h (struct expr_completion_state): New.
7361         (struct parser_state) <parser_state>: Add completion parameter.
7362         <mark_struct_expression, mark_completion_tag>: New methods.
7363         <parse_completion, m_completion_state>: New members.
7364         (prefixify_expression, null_post_parser): Update.
7365         (mark_struct_expression, mark_completion_tag): Don't declare.
7366         * parse.c (parse_completion, expout_last_struct)
7367         (expout_tag_completion_type, expout_completion_name): Remove
7368         globals.
7369         (parser_state::mark_struct_expression)
7370         (parser_state::mark_completion_tag): Now methods.
7371         (prefixify_expression): Add last_struct parameter.
7372         (prefixify_subexp): Likewise.
7373         (parse_exp_1): Update.
7374         (parse_exp_in_context): Add cstate parameter.  Update.
7375         (parse_expression_for_completion): Create an
7376         expr_completion_state.
7377         (null_post_parser): Add "completion" parameter.
7378         * p-exp.y: Update rules.
7379         (yylex): Update.
7380         * language.h (struct language_defn) <la_post_parser>: Add
7381         "completing" parameter.
7382         * go-exp.y: Update rules.
7383         (lex_one_token): Update.
7384         * expression.h (parse_completion): Don't declare.
7385         * d-exp.y: Update rules.
7386         (lex_one_token): Update rules.
7387         * c-exp.y: Update rules.
7388         (lex_one_token): Update.
7389         * ada-lang.c (resolve): Add "parse_completion" parameter.
7390         (resolve_subexp): Likewise.
7391         (ada_resolve_function): Likewise.
7392
7393 2019-04-04  Tom Tromey  <tom@tromey.com>
7394
7395         * parser-defs.h (struct parser_state) <start_arglist,
7396         end_arglist>: New methods.
7397         <arglist_len, m_funcall_chain>: New members.
7398         (arglist_len, start_arglist, end_arglist): Don't declare.
7399         * parse.c (arglist_len, funcall_chain): Remove global.
7400         (start_arglist, end_arglist): Remove functions.
7401         (parse_exp_in_context): Update.
7402         * p-exp.y: Update rules.
7403         * m2-exp.y: Update rules.
7404         * go-exp.y: Update rules.
7405         * f-exp.y: Update rules.
7406         * d-exp.y: Update rules.
7407         * c-exp.y: Update rules.
7408
7409 2019-04-04  Tom Tromey  <tom@tromey.com>
7410
7411         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7412         lex_operator, push_back>: New methods.
7413         Update all rules.
7414         (rust_parser::lex_hex, lex_escape): Rename and update.
7415         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7416         (rust_parser::lex_operator): Rename and update.
7417         (rust_parser::lex_number, rustyylex, rustyyerror)
7418         (rust_lex_test_init, rust_lex_test_sequence)
7419         (rust_lex_test_push_back, rust_lex_tests): Update.
7420         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7421         parameter.
7422         <lexptr, prev_lexptr>: New members.
7423         (lexptr, prev_lexptr): Don't declare.
7424         * parse.c (lexptr, prev_lexptr): Remove globals.
7425         (parse_exp_in_context): Update.
7426         * p-exp.y (yylex, yyerror): Update.
7427         * m2-exp.y (parse_number, yylex, yyerror): Update.
7428         * go-exp.y (lex_one_token, yyerror): Update.
7429         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7430         * d-exp.y (lex_one_token, yyerror): Update.
7431         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7432         (lex_one_token, yyerror): Update.
7433         * ada-lex.l (YY_INPUT): Update.
7434         (rewind_to_char): Update.
7435         * ada-exp.y (yyerror): Update.
7436
7437 2019-04-04  Tom Tromey  <tom@tromey.com>
7438
7439         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7440         * parser-defs.h (struct parser_state) <parser_state>: Add new
7441         parameter.
7442         <comma_terminates>: New member.
7443         (comma_terminates): Don't declare global.
7444         * parse.c (comma_terminates): Remove global.
7445         (parse_exp_in_context): Update.
7446         * p-exp.y (yylex): Update.
7447         * m2-exp.y (yylex): Update.
7448         * go-exp.y (lex_one_token): Update.
7449         * f-exp.y (yylex): Update.
7450         * d-exp.y (lex_one_token): Update.
7451         * c-exp.y (lex_one_token): Update.
7452         * ada-lex.l: Update.
7453
7454 2019-04-04  Tom Tromey  <tom@tromey.com>
7455
7456         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7457         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7458         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7459         * parser-defs.h (paren_depth): Don't declare.
7460         * parse.c (paren_depth): Remove global.
7461         (parse_exp_in_context): Update.
7462         * p-exp.y (paren_depth): New global.
7463         (pascal_parse): Initialize it.
7464         * m2-exp.y (paren_depth): New global.
7465         (m2_parse): Initialize it.
7466         * go-exp.y (paren_depth): New global.
7467         (go_parse): Initialize it.
7468         * f-exp.y (paren_depth): New global.
7469         (f_parse): Initialize it.
7470         * d-exp.y (paren_depth): New global.
7471         (d_parse): Initialize it.
7472         * c-exp.y (paren_depth): New global.
7473         (c_parse): Initialize it.
7474         * ada-lex.l (paren_depth): New global.
7475         (lexer_init): Initialize it.
7476
7477 2019-04-04  Tom Tromey  <tom@tromey.com>
7478
7479         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7480         (rust_parser::convert_ast_to_type)
7481         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7482         * parser-defs.h (struct parser_state) <parser_state>: Add
7483         parameters.  Initialize new members.
7484         <expression_context_block, expression_context_pc>: New members.
7485         * parse.c (expression_context_block, expression_context_pc):
7486         Remove globals.
7487         (parse_exp_in_context): Update.
7488         * p-exp.y: Update all rules.
7489         (yylex): Update.
7490         * m2-exp.y: Update all rules.
7491         (yylex): Update.
7492         * go-exp.y (yylex): Update.
7493         * f-exp.y (yylex): Update.
7494         * d-exp.y: Update all rules.
7495         (yylex): Update.
7496         * c-exp.y: Update all rules.
7497         (lex_one_token, classify_name, yylex, c_parse): Update.
7498         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7499
7500 2019-04-04  Tom Tromey  <tom@tromey.com>
7501
7502         * gdbarch.h, gdbarch.c: Rebuild.
7503         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7504         * stap-probe.h:
7505         (struct stap_parse_info): Replace "parser_state" with
7506         "expr_builder".
7507         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7508         (parser_state): New class.
7509         * parse.c (expr_builder): Rename.
7510         (expr_builder::release): Rename.
7511         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7512         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7513         (write_exp_elt_longcst, write_exp_elt_floatcst)
7514         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7515         (write_exp_string_vector, write_exp_bitstring)
7516         (write_exp_msymbol, mark_struct_expression)
7517         (write_dollar_variable)
7518         (insert_type_address_space, increase_expout_size): Replace
7519         "parser_state" with "expr_builder".
7520         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7521         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7522         "parser_state" with "expr_builder".
7523
7524 2019-04-04  Tom Tromey  <tom@tromey.com>
7525
7526         * rust-exp.y: Replace "parse_language" with method call.
7527         * p-exp.y:
7528         (yylex): Replace "parse_language" with method call.
7529         * m2-exp.y:
7530         (yylex): Replace "parse_language" with method call.
7531         * go-exp.y (classify_name): Replace "parse_language" with method
7532         call.
7533         * f-exp.y (yylex): Replace "parse_language" with method call.
7534         * d-exp.y (lex_one_token): Replace "parse_language" with method
7535         call.
7536         * c-exp.y:
7537         (lex_one_token, classify_name, yylex): Replace "parse_language"
7538         with method call.
7539         * ada-exp.y (find_primitive_type, type_char)
7540         (type_system_address): Replace "parse_language" with method call.
7541
7542 2019-04-04  Tom Tromey  <tom@tromey.com>
7543
7544         * rust-exp.y: Replace "parse_gdbarch" with method call.
7545         * parse.c (write_dollar_variable, insert_type_address_space):
7546         Replace "parse_gdbarch" with method call.
7547         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7548         call.
7549         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7550         call.
7551         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7552         "parse_gdbarch" with method call.
7553         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7554         with method call.
7555         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7556         "parse_gdbarch" with method call.
7557         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7558         "parse_gdbarch" with method call.
7559         * c-exp.y (parse_type, parse_number, classify_name): Replace
7560         "parse_gdbarch" with method call.
7561         * ada-lex.l: Replace "parse_gdbarch" with method call.
7562         * ada-exp.y (parse_type, find_primitive_type, type_char)
7563         (type_system_address): Replace "parse_gdbarch" with method call.
7564
7565 2019-04-04  Tom Tromey  <tom@tromey.com>
7566
7567         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7568         * stap-probe.c (stap_parse_argument): Update.
7569         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7570         initial_size parameter.
7571         * rust-exp.y (rust_lex_tests): Update.
7572         * parse.c (parser_state): Update.
7573         (parse_exp_in_context): Update.
7574         * parser-defs.h (struct parser_state) <parser_state>: Remove
7575         "initial_size" parameter.
7576
7577 2019-04-04  Tom Tromey  <tom@tromey.com>
7578
7579         * parser-defs.h (increase_expout_size): Don't declare.
7580         * parse.c (increase_expout_size): Now static.
7581
7582 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7583
7584         * gnu-nat.c (gnu_nat_target::wait): Fix
7585         target_waitstatus_to_string call.
7586
7587 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7588
7589         * eval.c (evaluate_subexp_standard): Handle internal functions
7590         during Fortran function call handling.
7591
7592 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7593
7594         * NEWS: Mention new internal functions.
7595         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7596         (read_base_type): Use dwarf2_init_complex_target_type.
7597         * value.c (creal_internal_fn): New function.
7598         (cimag_internal_fn): New function.
7599         (_initialize_values): Register new internal functions.
7600
7601 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7602
7603         * infrun.c (stop_all_threads): If debug_infrun, always
7604         trace the wait status after wait_one, using
7605         target_waitstatus_to_string and target_pid_to_str.
7606         (handle_inferior_event): Replace various trace of
7607         wait status kind by a single trace.
7608         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7609         wait status kind image by target_waitstatus_to_string.
7610         * target/waitstatus.c (target_waitstatus_to_string): Fix
7611         obsolete comment.
7612
7613 2019-04-01  Tom Tromey  <tromey@adacore.com>
7614
7615         PR symtab/23331:
7616         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7617
7618 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7619             Pedro Alves  <palves@redhat.com>
7620
7621         * top.c (quit_force): Call 'finalize_values'.
7622         * value.c (finalize_values): New function.
7623         * value.h (finalize_values): Declare.
7624
7625 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7626
7627         * NEWS: Announce $_gdb_major and $_gdb_minor.
7628
7629         * top.c (init_gdb_version_vars): New function.
7630         (gdb_init): Call init_gdb_version_vars.
7631
7632 2019-03-29  Tom Tromey  <tromey@adacore.com>
7633
7634         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7635         help text.  Remove dead code.
7636
7637 2019-03-29  Keith Seitz  <keiths@redhat.com>
7638
7639         From Siddhesh Poyarekar:
7640         * f-lang.h (f77_get_upperbound): Return LONGEST.
7641         (f77_get_lowerbound): Likewise.
7642         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7643         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7644         print them.
7645         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7646         plongest to format print it.
7647         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7648         (f77_get_upperbound): Likewise.
7649         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7650         LOWER_BOUND to LONGEST.
7651         (f77_create_arrayprint_offset_tbl): Likewise.
7652
7653 2019-03-29  Keith Seitz  <keiths@redhat.com>
7654
7655         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7656         %s/pulongest for TYPE_LENGTH instead of %d in format
7657         strings.
7658         * ada-typerint.c (ada_print_type): Likewise.
7659         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7660         * compile/compile-c-support.c (generate_register_struct): Likewise.
7661         * gdbtypes.c (recursive_dump_type): Likewise.
7662         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7663         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7664         instead of %d in format strings.
7665         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7666         to std::min to ULONGEST.
7667         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7668         instead of %d in format strings.
7669         * tracepoint.c (info_scope_command): Likewise.
7670         * typeprint.c (print_offset_data::update)
7671         (print_offset_data::finish): Likewise.
7672         * xtensa-tdep.c (xtensa_store_return_value)
7673         (xtensa_push_dummy_call): Likewise.
7674
7675 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7676
7677         * windows-nat.c (display_selector): Fixed format specifications
7678         for 64-bit Cygwin.
7679
7680 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7681
7682         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7683
7684 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7685
7686         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7687         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7688         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7689         (nios2_linux_init_abi): Install it.
7690
7691 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7692
7693         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7694
7695 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7696
7697         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7698
7699 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7700             Tom Tromey  <tromey@adacore.com>
7701
7702         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7703
7704 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7705
7706         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7707         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7708         method to compute the bounds of range types. Also print "[evaluated]"
7709         if the bounds' values come from a dynamic evaluation.
7710
7711 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7712
7713         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7714         whitespace when pretty printing is on.
7715
7716 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7717
7718         * ppc-linux-nat.c: Add include.
7719
7720 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7721
7722         * NEWS: Mention AArch64 Pointer Authentication.
7723
7724 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7725
7726         * arm-linux-nat.c: Add include.
7727
7728 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7729
7730         * source-cache.c (source_cache::get_source_lines): Re-read
7731         fullname after calling open_source_file.
7732
7733 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7734
7735         * NEWS: Mention TLS support for FreeBSD.
7736
7737 2019-03-25  Tom Tromey  <tromey@adacore.com>
7738
7739         * minsyms.c (BUNCH_SIZE): Update comment.
7740         (~minimal_symbol_reader): Remove old comment.
7741         (compact_minimal_symbols): Update comment.
7742         (minimal_symbol_reader::install): Remove old comment.  Update
7743         other comments.
7744
7745 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7746
7747         * s390-linux-nat.c: Add include.
7748
7749 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7750
7751         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7752         Call linux_get_hwcap.
7753         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7754         Likewise.
7755         (aarch64_linux_get_hwcap): Remove function.
7756         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7757         declaration.
7758         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7759         linux_get_hwcap.
7760         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7761         * linux-tdep.c (linux_get_hwcap): Add function.
7762         (linux_get_hwcap2): Likewise.
7763         * linux-tdep.h (linux_get_hwcap): Add declaration.
7764         (linux_get_hwcap2): Likewise.
7765         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7766         (ppc_linux_get_hwcap2): Likewise.
7767         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7768         linux_get_hwcap.
7769         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7770         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7771         (ppc_linux_nat_target::read_description): Likewise.
7772         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7773         * s390-linux-nat.c: Likewise.
7774         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7775
7776 2019-03-24  Tom Tromey  <tom@tromey.com>
7777
7778         * ada-lang.c (standard_lookup): Simplify initialization.
7779         (ada_lookup_symbol_nonlocal): Simplify return.
7780         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7781         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7782         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7783         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7784         initialization.
7785         * solib.c (solib_global_lookup): Simplify.
7786         * symtab.c (null_block_symbol): Remove.
7787         (symbol_cache_lookup): Simplify returns.
7788         (lookup_language_this): Simplify returns.
7789         (lookup_symbol_aux): Simplify return.
7790         (lookup_local_symbol): Simplify returns.
7791         (lookup_global_symbol_from_objfile): Simplify return.
7792         (lookup_symbol_in_objfile_symtabs)
7793         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7794         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7795         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7796         * cp-namespace.c (cp_lookup_bare_symbol)
7797         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7798         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7799         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7800         (cp_lookup_symbol_via_imports): Simplify initialization.
7801         (find_symbol_in_baseclass): Likewise.
7802         * symtab.h (null_block_symbol): Remove.
7803         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7804         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7805         (d_lookup_symbol_module): Likewise.
7806         (find_symbol_in_baseclass): Simplify initialization.
7807
7808 2019-03-24  Tom Tromey  <tom@tromey.com>
7809
7810         * expression.h: Don't include symtab.h.
7811         (struct block): Forward declare.
7812
7813 2019-03-24  Tom Tromey  <tom@tromey.com>
7814
7815         * c-exp.y (typebase): Remove casts.
7816         * gdbtypes.c (lookup_unsigned_typename, )
7817         (lookup_signed_typename): Remove cast.
7818         * eval.c (parse_to_comma_and_eval): Remove cast.
7819         * parse.c (write_dollar_variable): Remove cast.
7820         * block.h (struct block) <superblock>: Now const.
7821         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7822         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7823         (map_block): Make "block" const.
7824         * symfile.h (struct quick_symbol_functions)
7825         <map_matching_symbols>: Constify block argument to "callback".
7826         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7827         const.
7828         (find_pc_sect_compunit_symtab): Make "b" const.
7829         (find_symbol_at_address): Likewise.
7830         (search_symbols): Likewise.
7831         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7832         (dw2_debug_names_lookup_symbol): Likewise.
7833         (dw2_map_matching_symbols): Update.
7834         * p-valprint.c (pascal_val_print): Remove "block".
7835         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7836         (aux_add_nonlocal_symbols): Make "block" const.
7837         (resolve_subexp): Remove cast.
7838         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7839         const.
7840         (iterate_over_file_blocks): Likewise.
7841         * f-exp.y (%union) <bval>: Remove.
7842         * coffread.c (patch_opaque_types): Make "b" const.
7843         * spu-tdep.c (spu_catch_start): Make "block" const.
7844         * c-valprint.c (print_unpacked_pointer): Remove "block".
7845         * symmisc.c (dump_symtab_1): Make "b" const.
7846         (block_depth): Make "block" const.
7847         * d-exp.y (%union) <bval>: Remove.
7848         * cp-support.h (cp_lookup_rtti_type): Update.
7849         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7850         * psymtab.c (psym_lookup_symbol): Make "block" const.
7851         (maintenance_check_psymtabs): Make "b" const.
7852         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7853         (enumerate_locals, enumerate_args): Update.
7854         * python/py-symtab.c (stpy_global_block): Make "block" const.
7855         (stpy_static_block): Likewise.
7856         * inline-frame.c (block_starting_point_at): Make "new_block"
7857         const.
7858         * block.c (find_block_in_blockvector): Make return type const.
7859         (blockvector_for_pc_sect): Make "b" const.
7860         (find_block_in_blockvector): Make "b" const.
7861
7862 2019-03-23  Tom Tromey  <tom@tromey.com>
7863
7864         * varobj.c (varobj_create): Update.
7865         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7866         * printcmd.c (display_command, do_one_display): Don't reset
7867         innermost_block.
7868         * parser-defs.h (enum innermost_block_tracker_type): Move to
7869         expression.h.
7870         (innermost_block): Update comment.
7871         * parse.c (parse_exp_1): Add tracker_types parameter.
7872         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7873         tracker_types parameter.  Reset innermost_block.
7874         (parse_exp_in_context): Remove.
7875         (parse_expression_for_completion): Update.
7876         * objfiles.c (~objfile): Don't reset expression_context_block or
7877         innermost_block.
7878         * expression.h (enum innermost_block_tracker_type): Move from
7879         parser-defs.h.
7880         (parse_exp_1): Add tracker_types parameter.
7881         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7882         reset innermost_block.
7883
7884 2019-03-23  Tom Tromey  <tom@tromey.com>
7885
7886         * objfiles.h: Include bcache.h.
7887
7888 2019-03-23  Tom Tromey  <tom@tromey.com>
7889
7890         * linespec.c (get_current_search_block): Use
7891         scoped_restore_current_language.
7892         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7893
7894 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7895             Jiong Wang  <jiong.wang@arm.com>
7896
7897         * aarch64-linux-tdep.c
7898         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7899         section.
7900         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7901
7902 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7903             Jiong Wang  <jiong.wang@arm.com>
7904
7905         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7906         instructions.
7907         (aarch64_analyze_prologue_test): Add PACIASP test.
7908         (aarch64_prologue_prev_register): Unmask PC value.
7909
7910 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7911             Jiong Wang  <jiong.wang@arm.com>
7912
7913         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7914         (aarch64_dwarf2_prev_register): Unmask PC value.
7915         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7916         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7917         DW_CFA_AARCH64_negate_ra_state.
7918         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7919
7920 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7921             Jiong Wang  <jiong.wang@arm.com>
7922
7923         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7924         registers.
7925         (aarch64_pseudo_register_name): Likewise.
7926         (aarch64_pseudo_register_type): Likewise.
7927         (aarch64_pseudo_register_reggroup_p): Likewise.
7928         (aarch64_gdbarch_init): Add pauth registers.
7929         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7930         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7931         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7932         (struct gdbarch_tdep): Add regnum for ra_state.
7933
7934 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7935             Jiong Wang  <jiong.wang@arm.com>
7936
7937         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7938
7939 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7940             Jiong Wang  <jiong.wang@arm.com>
7941
7942         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7943         function.
7944         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7945         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7946         (aarch64_gdbarch_init): Add puth registers.
7947         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7948         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7949         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7950
7951 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7952             Jiong Wang  <jiong.wang@arm.com>
7953
7954         * aarch64-linux-nat.c
7955         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7956         * aarch64-linux-tdep.c
7957         (aarch64_linux_core_read_description): Likewise.
7958         (aarch64_linux_get_hwcap): New function.
7959         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7960         (aarch64_linux_get_hwcap): New declaration.
7961
7962 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7963             Jiong Wang  <jiong.wang@arm.com>
7964
7965         * aarch64-linux-nat.c
7966         (aarch64_linux_nat_target::read_description): Add pauth param.
7967         * aarch64-linux-tdep.c
7968         (aarch64_linux_core_read_description): Likewise.
7969         * aarch64-tdep.c (struct target_desc): Add in pauth.
7970         (aarch64_read_description): Add pauth param.
7971         (aarch64_gdbarch_init): Likewise.
7972         * aarch64-tdep.h (aarch64_read_description): Likewise.
7973         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7974         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7975         * features/Makefile: Add new files.
7976         * features/aarch64-pauth.c: New file.
7977         * features/aarch64-pauth.xml: New file.
7978
7979 2019-03-20  Tom Tromey  <tromey@adacore.com>
7980
7981         * infrun.c (handle_inferior_event): Rename from
7982         handle_inferior_event_1.  Create a scoped_value_mark.
7983         (handle_inferior_event): Remove.
7984
7985 2019-03-19  Tom Tromey  <tromey@adacore.com>
7986
7987         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7988         * infrun.h (print_stop_event): Add "displays" parameter.
7989         * infrun.c (print_stop_event): Add "displays" parameter.
7990
7991 2019-03-19  Pedro Alves  <palves@redhat.com>
7992
7993         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7994         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7995         to -1.  Fix TABs vs spaces.
7996         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7997         * tui/tui-out.h (tui_ui_out) Add intro comments.
7998         <m_line, m_start_of_line>: In-class initialize, and add describing
7999         comment.
8000
8001 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8002
8003         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8004         variable names.
8005         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8006
8007 2019-03-18  Pedro Alves  <palves@redhat.com>
8008             Eli Zaretskii <eliz@gnu.org>
8009
8010         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8011         m_line and m_start_of_line.
8012
8013 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8014
8015         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8016         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8017         it returns a newline.  This fixes a regression in TU mode, whereby
8018         the next line is output on the same screen line as the user input.
8019
8020 2019-03-18  Tom Tromey  <tromey@adacore.com>
8021
8022         * minsyms.c (minimal_symbol_reader::install): Remove call to
8023         obstack_blank.
8024
8025 2019-03-18  Pedro Alves  <palves@redhat.com>
8026
8027         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8028         New globals.
8029         (apply_style): New, factored out from ...
8030         (apply_ansi_escape): ... this.  Handle reverse video mode.
8031         (tui_set_reverse_mode): New function.
8032         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8033         * tui/tui-winsource.c (tui_show_source_line): Use
8034         tui_set_reverse_mode instead of setting A_STANDOUT.
8035         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8036         New setter methods.
8037
8038 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8039
8040         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8041         Handle tabs.
8042
8043 2019-03-18  Tom Tromey  <tromey@adacore.com>
8044
8045         * ada-lang.c (empty_array): Add "high" parameter.
8046         (ada_evaluate_subexp): Update.
8047
8048 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8049
8050         * unittests/string_view-selftests.c: Define
8051         _initialize_string_view_selftests unconditionally.
8052
8053 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8054
8055         PR gdb/24350
8056         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8057
8058 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8059
8060         PR gdb/24351
8061         * windows-nat.c (display_selector): Fix format specifiers.
8062
8063 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8064
8065         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8066         tui_refill_source_window instead of tui_refresh_win, to update the
8067         current execution line.  This fixes redisplay of the current line
8068         when stepping through the code with "next" or "step".
8069
8070 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8071
8072         * source-cache.c (source_cache::get_source_lines): Call
8073         find_source_lines to initialize s->nlines.  This fixes vertical
8074         scrolling of TUI source window when the DOWN arrow is pressed.
8075
8076 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8077
8078         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8079         linux-thread-db.c (_initialize_thread_db): Likewise.
8080
8081 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8082
8083         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8084         wclrtoeol in tui_show_source_line".  This reverts changes made in
8085         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8086
8087 2019-03-15  Tom Tromey  <tom@tromey.com>
8088
8089         * symtab.h (struct minimal_symbol): Derive from
8090         general_symbol_info.
8091         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8092         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8093         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8094         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8095         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8096         (MSYMBOL_SEARCH_NAME): Update.
8097         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8098         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8099         * minsyms.c (minimal_symbol_reader::record_full): Update.
8100
8101 2019-03-15  Tom Tromey  <tom@tromey.com>
8102
8103         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8104
8105 2019-03-15  Tom Tromey  <tom@tromey.com>
8106
8107         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8108         unique_xmalloc_ptr.
8109         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8110         Update.
8111         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8112         (build_minimal_symbol_hash_tables)
8113         (minimal_symbol_reader::install): Update.
8114
8115 2019-03-15  Tom Tromey  <tom@tromey.com>
8116
8117         * symtab.c (create_demangled_names_hash): Update.
8118         (symbol_set_names): Update.
8119         * objfiles.h (struct objfile_per_bfd_storage)
8120         <demangled_names_hash>: Now an htab_up.
8121         * objfiles.c (objfile_per_bfd_storage): Simplify.
8122
8123 2019-03-15  Tom Tromey  <tom@tromey.com>
8124
8125         * objfiles.h (struct objfile_per_bfd_storage): Declare
8126         destructor.
8127         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8128         New.
8129         (get_objfile_bfd_data): Use new.  Don't initialize
8130         language_of_main.
8131         (free_objfile_per_bfd_storage): Remove.
8132         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8133
8134 2019-03-15  Tom Tromey  <tom@tromey.com>
8135
8136         * symfile.c (reread_symbols): Update.
8137         * objfiles.c (objfile::objfile): Update.
8138         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8139         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8140         comment.
8141         (minimal_symbol_reader::install): Update.
8142         (terminate_minimal_symbol_table): Remove.
8143         * jit.c (jit_object_close_impl): Update.
8144
8145 2019-03-15  Tom Tromey  <tom@tromey.com>
8146
8147         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8148         initializations.
8149
8150 2019-03-15  Tom Tromey  <tom@tromey.com>
8151
8152         * objfiles.h (struct objfile_per_bfd_storage)
8153         <demangled_hash_languages>: Now a bitset.
8154         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8155         (lookup_minimal_symbol): Update.
8156
8157 2019-03-15  Tom Tromey  <tom@tromey.com>
8158
8159         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8160         Don't return the symbol.
8161         * coffread.c (record_minimal_symbol): Use record_full.
8162
8163 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8164
8165         The MS-Windows port of ncurses fails to switch to a color pair if
8166         one or both of the colors are the implicit default colors.  This
8167         change records the default colors when TUI is initialized, and
8168         then specifies them explicitly when a color pair uses the default
8169         colors.  This allows color styling in TUI mode on MS-Windows.
8170
8171         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8172         ncurses_norm_attr.
8173         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8174         colors in ncurses_norm_attr.
8175         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8176         "none", replace it with the default color recorded in
8177         ncurses_norm_attr.
8178
8179 2019-03-14  Tom Tromey  <tromey@adacore.com>
8180
8181         * source-cache.h (class source_cache) <get_source_lines>: Return
8182         std::string.
8183         * source-cache.c (source_cache::extract_lines): Handle case where
8184         first_pos==npos.  Return std::string.
8185         (source_cache::get_source_lines): Update.
8186
8187 2019-03-14  Tom Tromey  <tromey@adacore.com>
8188
8189         * NEWS: Add item for "style sources" commands.
8190         * source-cache.c (source_cache::get_source_lines): Check
8191         source_styling.
8192         * cli/cli-style.c (source_styling): New global.
8193         (_initialize_cli_style): Add "style sources" commands.
8194         (show_style_sources): New function.
8195         * cli/cli-style.h (source_styling): Declare.
8196
8197 2019-03-14  Pedro Alves  <palves@redhat.com>
8198             Tom Tromey  <tromey@adacore.com>
8199
8200         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8201         * tui/tui-winsource.c (tui_refill_source_window): New function,
8202         from...
8203         (tui_horizontal_source_scroll): ... here.  Move some logic.
8204         * cli/cli-style.c (set_style_enabled): Notify new observable.
8205         * tui/tui-hooks.c (tui_redisplay_source): New function.
8206         (tui_attach_detach_observers): Attach or detach
8207         tui_redisplay_source.
8208         * observable.h (source_styling_changed): New observable.
8209         * observable.c: Define source_styling_changed observable.
8210
8211 2019-03-13  Tom Tromey  <tromey@adacore.com>
8212
8213         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8214         (i386_gnu_nat_target::store_registers): Update.
8215         * target-debug.h (target_debug_print_std_string): New macro.
8216         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8217         * windows-tdep.c (display_one_tib): Update.
8218         * tui/tui-stack.c (tui_make_status_line): Update.
8219         * top.c (print_inferior_quit_action): Update.
8220         * thread.c (thr_try_catch_cmd): Update.
8221         (add_thread_with_info): Update.
8222         (thread_target_id_str): Update.
8223         (thr_try_catch_cmd): Update.
8224         (thread_command): Update.
8225         (thread_find_command): Update.
8226         * record-btrace.c (record_btrace_target::info_record)
8227         (record_btrace_resume_thread, record_btrace_target::resume)
8228         (record_btrace_cancel_resume, record_btrace_step_thread)
8229         (record_btrace_target::wait, record_btrace_target::wait)
8230         (record_btrace_target::wait, record_btrace_target::stop): Update.
8231         * progspace.c (print_program_space): Update.
8232         * process-stratum-target.c
8233         (process_stratum_target::thread_address_space): Update.
8234         * linux-fork.c (linux_fork_mourn_inferior)
8235         (detach_checkpoint_command, info_checkpoints_command)
8236         (linux_fork_context): Update.
8237         (linux_fork_detach): Update.
8238         (class scoped_switch_fork_info): Update.
8239         (delete_checkpoint_command): Update.
8240         * infrun.c (follow_fork_inferior): Update.
8241         (follow_fork_inferior): Update.
8242         (proceed_after_vfork_done): Update.
8243         (handle_vfork_child_exec_or_exit): Update.
8244         (follow_exec): Update.
8245         (displaced_step_prepare_throw): Update.
8246         (displaced_step_restore): Update.
8247         (start_step_over): Update.
8248         (resume_1): Update.
8249         (clear_proceed_status_thread): Update.
8250         (proceed): Update.
8251         (print_target_wait_results): Update.
8252         (do_target_wait): Update.
8253         (context_switch): Update.
8254         (stop_all_threads): Update.
8255         (restart_threads): Update.
8256         (finish_step_over): Update.
8257         (handle_signal_stop): Update.
8258         (switch_back_to_stepped_thread): Update.
8259         (keep_going_pass_signal): Update.
8260         (print_exited_reason): Update.
8261         (normal_stop): Update.
8262         * inferior.c (inferior_pid_to_str): Change return type.
8263         (print_selected_inferior): Update.
8264         (add_inferior): Update.
8265         (detach_inferior): Update.
8266         * dummy-frame.c (fprint_dummy_frames): Update.
8267         * dcache.c (dcache_info_1): Update.
8268         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8269         (btrace_fetch, btrace_clear): Update.
8270         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8271         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8272         type.
8273         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8274         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8275         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8276         * gdbarch.c, gdbarch.h: Rebuild.
8277         * gdbarch.sh (core_pid_to_str): Change return type.
8278         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8279         return type.
8280         (windows_nat_target::pid_to_str): Change return type.
8281         (windows_delete_thread): Update.
8282         (windows_nat_target::attach): Update.
8283         (windows_nat_target::files_info): Update.
8284         * target-delegates.c: Rebuild.
8285         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8286         return type.
8287         (sol_thread_target::pid_to_str): Change return type.
8288         * remote.c (class remote_target) <pid_to_str>: Change return
8289         type.
8290         (remote_target::pid_to_str): Change return type.
8291         (extended_remote_target::attach, remote_target::remote_stop_ns)
8292         (remote_target::remote_notif_remove_queued_reply)
8293         (remote_target::push_stop_reply, remote_target::disable_btrace):
8294         Update.
8295         (extended_remote_target::attach): Update.
8296         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8297         type.
8298         (gdbsim_target::pid_to_str): Change return type.
8299         * ravenscar-thread.c (struct ravenscar_thread_target)
8300         <pid_to_str>: Change return type.
8301         (ravenscar_thread_target::pid_to_str): Change return type.
8302         * procfs.c (class procfs_target) <pid_to_str>: Change return
8303         type.
8304         (procfs_target::pid_to_str): Change return type.
8305         (procfs_target::attach): Update.
8306         (procfs_target::detach): Update.
8307         (procfs_target::fetch_registers): Update.
8308         (procfs_target::store_registers): Update.
8309         (procfs_target::wait): Update.
8310         (procfs_target::files_info): Update.
8311         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8312         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8313         return type.
8314         (nto_procfs_target::pid_to_str): Change return type.
8315         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8316         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8317         return type.
8318         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8319         (exit_lwp): Update.
8320         (attach_proc_task_lwp_callback, get_detach_signal)
8321         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8322         (linux_nat_target::resume, wait_lwp, stop_callback)
8323         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8324         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8325         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8326         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8327         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8328         type.
8329         (inf_ptrace_target::attach): Update.
8330         (inf_ptrace_target::files_info): Update.
8331         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8332         type.
8333         (go32_nat_target::pid_to_str): Change return type.
8334         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8335         (gnu_nat_target::wait): Update.
8336         (gnu_nat_target::wait): Update.
8337         (gnu_nat_target::resume): Update.
8338         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8339         (fbsd_nat_target::wait): Update.
8340         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8341         type.
8342         (darwin_nat_target::attach): Update.
8343         * corelow.c (class core_target) <pid_to_str>: Change return type.
8344         (core_target::pid_to_str): Change return type.
8345         * target.c (normal_pid_to_str): Change return type.
8346         (default_pid_to_str): Likewise.
8347         (target_pid_to_str): Change return type.
8348         (target_translate_tls_address): Update.
8349         (target_announce_detach): Update.
8350         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8351         return type.
8352         (bsd_uthread_target::pid_to_str): Change return type.
8353         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8354         type.
8355         (bsd_kvm_target::pid_to_str): Change return type.
8356         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8357         return type.
8358         (aix_thread_target::pid_to_str): Change return type.
8359         * target.h (struct target_ops) <pid_to_str>: Change return type.
8360         (target_pid_to_str, normal_pid_to_str): Likewise.
8361         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8362         type.
8363         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8364         type.
8365         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8366         return type.
8367         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8368         type.
8369         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8370         type.
8371         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8372         return type.
8373
8374 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8375
8376         * NEWS: Mention that the new default MI version is 3.  Mention
8377         changes to the output of commands and events that deal with
8378         multi-location breakpoints.
8379         * breakpoint.c: Include "mi/mi-out.h".
8380         (print_one_breakpoint): Change output syntax if using MI version
8381         >= 3.
8382         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8383         New.
8384         (mi_multi_location_breakpoint_output_fixed): New.
8385         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8386         (mi_cmd_fix_multi_location_breakpoint_output): New.
8387         (mi_multi_location_breakpoint_output_fixed): New.
8388         * mi/mi-cmds.c (mi_cmds): Register command
8389         -fix-multi-location-breakpoint-output.
8390         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8391         interpreter "mi".
8392
8393 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8394
8395         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8396         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8397         instantiate mi_ui_out based on interpreter name.
8398         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8399         * mi/mi-main.c (mi_load_progress): Likewise.
8400
8401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8402
8403         * NEWS: Combine separate "New targets" sections for 8.3.
8404
8405 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8406
8407         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8408         (ppcfbsd_init_abi): Install gdbarch
8409         "fetch_tls_load_module_address" and "get_thread_local_address"
8410         methods.
8411
8412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8413
8414         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8415         (riscv_fbsd_init_abi): Install gdbarch
8416         "fetch_tls_load_module_address" and "get_thread_local_address"
8417         methods.
8418
8419 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8420
8421         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8422         (i386fbsd_init_abi): Install gdbarch
8423         "fetch_tls_load_module_address" and "get_thread_local_address"
8424         methods.
8425
8426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8427
8428         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8429         (amd64fbsd_init_abi): Install gdbarch
8430         "fetch_tls_load_module_address" and "get_thread_local_address"
8431         methods.
8432
8433 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8434
8435         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8436         (struct fbsd_pspace_data): New type.
8437         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8438         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8439         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8440         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8441         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8442
8443 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8444
8445         * gdbtypes.c (lookup_struct_elt): New function.
8446         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8447         * gdbtypes.h (struct struct_elt): New type.
8448         (lookup_struct_elt): New prototype.
8449
8450 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8451
8452         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8453         remove disabled code block.
8454
8455 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8456
8457         * gdbarch.sh (get_thread_local_address): New method.
8458         * gdbarch.h, gdbarch.c: Regenerate.
8459         * target.c (target_translate_tls_address): Use
8460         gdbarch_get_thread_local_address if present instead of
8461         target::get_thread_local_address.
8462
8463 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8464
8465         * target.h (target::get_thread_local_address): Update comment.
8466
8467 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8468
8469         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8470         objfile->separate_debug_objfile_backlink if not NULL.
8471
8472 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8473
8474         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8475         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8476         (amd64bsd_store_inferior_registers): Likewise.
8477         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8478         Enable segment base registers.
8479         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8480         PT_GETFSBASE and PT_GETGSBASE.
8481         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8482         PT_SETGSBASE.
8483         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8484         segment base registers.
8485         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8486
8487 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8488
8489         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8490         Update calls to i386_target_description to add 'segments'
8491         parameter.
8492         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8493         add segment base registers.
8494         * arch/i386.c (i386_create_target_description): Add 'segments'
8495         parameter to enable segment base registers.
8496         * arch/i386.h (i386_create_target_description): Likewise.
8497         * features/i386/32bit-segments.xml: New file.
8498         * features/i386/32bit-segments.c: Generate.
8499         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8500         call to i386_target_description to add 'segments' parameter.
8501         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8502         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8503         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8504         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8505         if feature is present.
8506         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8507         Add 'segments' parameter to call to i386_target_description.
8508         (i386_target_description): Add 'segments' parameter to enable
8509         segment base registers.
8510         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8511         to call to i386_target_description.
8512         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8513         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8514         Define I386_NUM_REGS.
8515         (i386_target_description): Add 'segments' parameter to enable
8516         segment base registers.
8517
8518 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8519
8520         PR/24325
8521         * source-cache.c: #undef open and close, to avoid unresolved
8522         externals during linking.
8523
8524 2019-03-12  Tom Tromey  <tromey@adacore.com>
8525
8526         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8527         const.  Add initializers.
8528         (_initialize_remote): Don't initialize ptid globals.
8529
8530 2019-03-12  Pedro Alves  <palves@redhat.com>
8531
8532         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8533
8534 2019-03-12  Pedro Alves  <palves@redhat.com>
8535
8536         * cp-name-parser.y (main): Remove unused 'len' variable.
8537
8538 2019-03-12  Tom Tromey  <tromey@adacore.com>
8539
8540         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8541         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8542
8543 2019-03-12  Tom Tromey  <tromey@adacore.com>
8544
8545         * linux-nat.c (iterate_over_lwps): Update.
8546         (stop_callback): Remove parameter.
8547         (stop_wait_callback, detach_callback, resume_set_callback)
8548         (select_singlestep_lwp_callback, set_ignore_sigint)
8549         (status_callback, resumed_callback, resume_clear_callback)
8550         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8551         data parameter.
8552         (linux_nat_target::detach, linux_nat_target::resume)
8553         (linux_stop_and_wait_all_lwps, select_event_lwp)
8554         (linux_nat_filter_event, linux_nat_wait_1)
8555         (linux_nat_target::kill, linux_nat_target::stop)
8556         (linux_nat_target::stop): Update.
8557         (linux_nat_resume_callback): Change type.
8558         (resume_stopped_resumed_lwps, count_events_callback)
8559         (select_event_lwp_callback): Likewise.
8560         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8561         * arm-linux-nat.c (struct update_registers_data): Remove.
8562         (update_registers_callback): Change type.
8563         (arm_linux_insert_hw_breakpoint1): Update.
8564         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8565         parameter.
8566         (x86_linux_dr_set_addr): Update.
8567         (x86_linux_dr_set_control): Update.
8568         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8569         (iterate_over_lwps): Use gdb::function_view.
8570         * nat/aarch64-linux-hw-point.c (struct
8571         aarch64_dr_update_callback_param): Remove.
8572         (debug_reg_change_callback): Change type.
8573         (aarch64_notify_debug_reg_change): Update.
8574         * s390-linux-nat.c (s390_refresh_per_info): Update.
8575
8576 2019-03-11  Tom Tromey  <tromey@adacore.com>
8577
8578         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8579         redundant assignment to "this_cu".
8580
8581 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8582
8583         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8584
8585 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8586
8587         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8588         from...
8589         (rank_one_type): ... this.
8590
8591 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8592
8593         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8594         from...
8595         (rank_one_type): ... this.
8596
8597 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8598
8599         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8600         from...
8601         (rank_one_type): ... this.
8602
8603 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8604
8605         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8606         from...
8607         (rank_one_type): ... this.
8608
8609 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8610
8611         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8612         from...
8613         (rank_one_type): ... this.
8614
8615 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8616
8617         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8618         from...
8619         (rank_one_type): ... this.
8620
8621 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8622
8623         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8624         from...
8625         (rank_one_type): ... this.
8626
8627 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8628
8629         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8630         from...
8631         (rank_one_type): ... this.
8632
8633 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8634
8635         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8636         from...
8637         (rank_one_type): ... this.
8638
8639 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8640
8641         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8642         from...
8643         (rank_one_type): ... this.
8644
8645 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8646
8647         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8648         from...
8649         (rank_one_type): ... this.
8650
8651 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8652
8653         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8654         from...
8655         (rank_one_type): ... this.
8656
8657 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8658
8659         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8660         inferior-events' shows the example events.
8661
8662 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8663
8664         Support styling on native MS-Windows console
8665
8666         PR/24315
8667         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8668         on MS-Windows if $TERM is not defined.
8669
8670         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8671
8672         * posix-hdep.c (gdb_console_fputs):
8673         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8674         functions.
8675         * ui-file.h (gdb_console_fputs): Add prototype.
8676
8677         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8678         back to fputs only if the former returns zero.
8679
8680 2019-03-07  Tom Tromey  <tom@tromey.com>
8681
8682         * symmisc.c (print_symbol_bcache_statistics): Update.
8683         (print_objfile_statistics): Update.
8684         * symfile.c (allocate_symtab): Update.
8685         * stabsread.c: Don't include bcache.h.
8686         * psymtab.h (struct psymbol_bcache): Don't declare.
8687         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8688         (psymbol_bcache_init, psymbol_bcache_free)
8689         (psymbol_bcache_get_bcache): Don't declare.
8690         * psymtab.c (struct psymbol_bcache): Remove.
8691         (psymtab_storage::psymtab_storage): Update.
8692         (psymtab_storage::~psymtab_storage): Update.
8693         (psymbol_bcache_init, psymbol_bcache_free)
8694         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8695         (add_psymbol_to_bcache): Update.
8696         (allocate_psymtab): Update.
8697         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8698         macro_cache>: No longer pointers.
8699         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8700         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8701         * macrotab.c (macro_bcache): Update.
8702         * macroexp.c: Don't include bcache.h.
8703         * gdbtypes.c (check_types_worklist): Update.
8704         (types_deeply_equal): Remove TRY/CATCH.  Update.
8705         * elfread.c (elf_symtab_read): Update.
8706         * dwarf2read.c: Don't include bcache.h.
8707         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8708         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8709         (print_bcache_statistics, bcache_memory_used): Don't declare.
8710         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8711         methods.  Rename all data members.
8712         * bcache.c (struct bcache): Move to bcache.h.
8713         (bcache::expand_hash_table): Rename from expand_hash_table.
8714         (bcache): Remove.
8715         (bcache::insert): Rename from bcache_full.
8716         (bcache::compare): Rename from bcache_compare.
8717         (bcache_xmalloc): Remove.
8718         (bcache::~bcache): Rename from bcache_xfree.
8719         (bcache::print_statistics): Rename from print_bcache_statistics.
8720         (bcache::memory_used): Rename from bcache_memory_used.
8721
8722 2019-03-07  Pedro Alves  <palves@redhat.com>
8723
8724         * infrun.c (normal_stop): Also check for
8725         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8726
8727 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8728
8729         * f-lang.c (value_from_host_double): Moved to...
8730         * value.c (value_from_host_double): ...here.
8731         * value.h (value_from_host_double): Declare.
8732         * guile/scm-math.c (vlscm_convert_typed_number): Use
8733         value_from_host_double.
8734         (vlscm_convert_number): Likewise.
8735         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8736         * python/py-value.c (convert_value_from_python): Likewise.
8737
8738 2019-03-06  Tom Tromey  <tom@tromey.com>
8739
8740         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8741
8742 2019-03-06  Tom Tromey  <tom@tromey.com>
8743
8744         * utils.h (free_current_contents): Don't declare.
8745         * utils.c (free_current_contents): Remove.
8746
8747 2019-03-06  Tom Tromey  <tom@tromey.com>
8748
8749         * top.c (quit_force): Update.
8750         * main.c (captured_command_loop): Update.
8751         * common/new-op.c (operator new): Update.
8752         * common/common-exceptions.c (struct catcher)
8753         <save_cleanup_chain>: Remove member.
8754         (exceptions_state_mc_init): Update.
8755         (exception_try_scope_entry): Return nullptr.
8756         (exception_try_scope_exit, exception_rethrow)
8757         (throw_exception_sjlj, throw_exception_cxx): Update.
8758         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8759         (all_cleanups, do_cleanups, discard_cleanups)
8760         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8761         (restore_cleanups, restore_final_cleanups): Don't declare.
8762         (do_final_cleanups): Remove parameter.
8763         * common/cleanups.c (cleanup_chain, make_cleanup)
8764         (make_cleanup_dtor, all_cleanups, do_cleanups)
8765         (discard_my_cleanups, discard_cleanups)
8766         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8767         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8768         (null_cleanup): Remove.
8769         (do_final_cleanups): Remove parameter.
8770
8771 2019-03-06  Tom Tromey  <tom@tromey.com>
8772
8773         * remote.c (remote_target::remote_parse_stop_reply): Use
8774         unique_xmalloc_ptr.
8775
8776 2019-03-06  Tom Tromey  <tom@tromey.com>
8777
8778         * stabsread.c (struct stabs_field_info): Rename from field_info.
8779         <list, fnlist>: Add initializers.
8780         <obstack>: New member.
8781         (read_member_functions, read_struct_fields, read_baseclasses):
8782         Allocate on obstack.  Don't use cleanups.
8783         (read_one_struct_field, read_member_functions, read_struct_fields)
8784         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8785         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8786         (read_struct_type): Update.
8787
8788 2019-03-06  Tom Tromey  <tom@tromey.com>
8789
8790         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8791         * common/filestuff.h (make_cleanup_close): Don't declare.
8792         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8793         Remove.
8794
8795 2019-03-06  Tom Tromey  <tom@tromey.com>
8796
8797         * solib-aix.c: Use make_scope_exit.
8798
8799 2019-03-06  Tom Tromey  <tom@tromey.com>
8800
8801         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8802         Use make_scope_exit.
8803
8804 2019-03-06  Tom Tromey  <tom@tromey.com>
8805
8806         * solib-svr4.c (disable_probes_interface): Remove parameter.
8807         (svr4_handle_solib_event): Use make_scope_exit.
8808
8809 2019-03-06  Tom Tromey  <tom@tromey.com>
8810
8811         * remote.c (struct stop_reply_deleter): Remove.
8812         (stop_reply_up): Update.
8813         (struct stop_reply): Derive from notif_event.  Don't typedef.
8814         <regcache>: Now a std::vector.
8815         (stop_reply_xfree): Remove.
8816         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8817         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8818         (remote_target::discard_pending_stop_replies): Use delete.
8819         (remote_target::remote_parse_stop_reply): Update.
8820         (remote_target::process_stop_reply): Update.
8821         * remote-notif.h (struct notif_event): Add virtual destructor.
8822         Remove "dtr" member.
8823         (struct notif_client) <alloc_event>: Return a unique_ptr.
8824         (notif_event_xfree): Don't declare.
8825         (notif_event_up): New typedef.
8826         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8827         (notif_event_xfree, do_notif_event_xfree): Remove.
8828         (remote_notif_state_xfree): Update.
8829
8830 2019-03-06  Tom Tromey  <tom@tromey.com>
8831
8832         * infrun.c (displaced_step_clear_cleanup): Now a
8833         forward_scope_exit type.
8834         (displaced_step_prepare_throw): Update.
8835         (displaced_step_fixup): Update.
8836
8837 2019-03-06  Tom Tromey  <tom@tromey.com>
8838
8839         * inferior.h (class inferior): Update comment.
8840         * gdbthread.h (class thread_info): Update comment.
8841
8842 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8843             Tom Tromey  <tom@tromey.com>
8844
8845         * stabsread.h (struct stab_section_list): Remove.
8846         (coffstab_build_psymtabs): Update.
8847         * dbxread.c (symbuf_sections): Now a std::vector.
8848         (sect_idx): New global.
8849         (fill_symbuf): Update.
8850         (coffstab_build_psymtabs): Change type of stabsects parameter.
8851         Update.
8852         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8853         std::vector.
8854         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8855         (coff_locate_sections): Update.
8856         (coff_symfile_read): Remove cleanups.  Update.
8857         (init_stringtab): Add storage parameter.
8858         (free_stringtab, free_stringtab_cleanup): Remove.
8859         (init_lineno): Add storage parameter.
8860         (free_linetab, free_linetab_cleanup): Remove.
8861
8862 2019-03-06  Pedro Alves  <palves@redhat.com>
8863
8864         * linux-fork.c (fork_info::clobber_regs): Delete.
8865         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8866         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8867         comment.  Adjust.
8868         (scoped_switch_fork_info::scoped_switch_fork_info)
8869         (checkpoint_command, linux_fork_context): Adjust
8870         fork_save_infrun_state calls.
8871
8872 2019-03-06  Pedro Alves  <palves@redhat.com>
8873
8874         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8875         (inf_has_multiple_threads): Return 'bool' and rewrite using
8876         inferior_info::threads().
8877
8878 2019-03-06  Pedro Alves  <palves@redhat.com>
8879
8880         * linux-fork.c: Include <list>.
8881         (fork_list): Now a std::list instance.
8882         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8883         (forks_exist_p, find_last_fork): Adjust.
8884         (new_fork): Delete.
8885         (one_fork_p): New.
8886         (add_fork): Adjust.
8887         (free_fork): Delete, folded into fork_info::~fork_info().
8888         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8889         Adjust.
8890         (init_fork_list): Delete.
8891         (linux_fork_killall, linux_fork_mourn_inferior)
8892         (linux_fork_detach, info_checkpoints_command): Adjust.
8893         (_initialize_linux_fork): No longer call init_fork_list.
8894
8895 2019-03-06  Pedro Alves  <palves@redhat.com>
8896
8897         * linux-fork.c (new_fork): New, split out of ...
8898         (add_fork): ... this.  Return void.  Move "first fork" special
8899         case from here, to ...
8900         (checkpoint_command): ... here.
8901         * linux-linux.h (add_fork): Return void.
8902
8903 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8904
8905         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8906
8907 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8908             Chris January  <chris.january@arm.com>
8909             David Lecomber  <david.lecomber@arm.com>
8910
8911         * f-exp.y: New token, UNOP_INTRINSIC.
8912         (exp): New pattern using UNOP_INTRINSIC token.
8913         (f77_keywords): Add 'abs' keyword.
8914         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8915         (value_from_host_double): New function.
8916         (evaluate_subexp_f): Support UNOP_ABS.
8917
8918 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8919
8920         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8921         types.
8922
8923 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8924
8925         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8926         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8927         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8928
8929 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8930
8931         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8932
8933 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8934             Chris January  <chris.january@arm.com>
8935
8936         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8937         * f-exp.y: Define 'KIND' token.
8938         (exp): New pattern for KIND expressions.
8939         (ptype): Handle types with a kind extension.
8940         (direct_abs_decl): Extend to spot kind extensions.
8941         (f77_keywords): Add 'kind' to the list.
8942         (push_kind_type): New function.
8943         (convert_to_kind_type): New function.
8944         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8945         * parse.c (operator_length_standard): Likewise.
8946         * parser-defs.h (enum type_pieces): Add tp_kind.
8947         * std-operator.def: Add UNOP_KIND.
8948
8949 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8950
8951         * f-exp.y (f_parse): Set yydebug.
8952
8953 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8954
8955         * f-lang.c (evaluate_subexp_f): New function.
8956         (exp_descriptor_f): New global.
8957         (f_language_defn): Use exp_descriptor_f instead of
8958         exp_descriptor_standard.
8959
8960 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8961
8962         * f-exp.y (struct token): Add comments.
8963         (dot_ops): Remove uppercase versions and the end marker.
8964         (f77_keywords): Likewise.
8965         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8966         entries in the dot_ops array are case insensitive, and use
8967         strncasecmp to compare strings.  Also some whitespace cleanup in
8968         this area.  Similar for the f77_keywords array, except entries in
8969         this list might be case sensitive.
8970
8971 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8972
8973         * f-exp.y (struct f77_boolean_val): Add comments.
8974         (boolean_values): Remove uppercase versions, and end marker.
8975         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8976         and use strncasecmp to achieve case insensitivity.  Additionally,
8977         perform whitespace cleanup around this code.
8978
8979 2019-03-06  Tom Tromey  <tromey@adacore.com>
8980
8981         * remote-sim.c (gdbsim_target_open): Use result of
8982         gdb_argv::release.
8983
8984 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8985         Dirk Schubert  <dirk.schubert@arm.com>
8986         Chris January  <chris.january@arm.com>
8987
8988         * eval.c (evaluate_subexp_standard): Call Fortran argument
8989         wrapping logic.
8990         * f-lang.c (struct value): A value which can be passed into a
8991         Fortran function call.
8992         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8993         where appropriate.
8994         (struct type): Value ready for a Fortran function call.
8995         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8996         is needed.
8997         * f-lang.h (fortran_argument_convert): Declaration.
8998         (fortran_preserve_arg_pointer): Declaration.
8999         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9000
9001 2019-03-05  Tom Tromey  <tromey@adacore.com>
9002
9003         * python/py-prettyprint.c (print_string_repr): Remove #if.
9004         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9005
9006 2019-03-05  Tom Tromey  <tromey@adacore.com>
9007
9008         * target.c (the_dummy_target): Move later.  Change type to
9009         "dummy_target".
9010         (initialize_targets): Don't initialize the_dummy_target.
9011
9012 2019-03-05  Tom Tromey  <tromey@adacore.com>
9013
9014         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9015         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9016
9017 2019-03-05  Tom Tromey  <tromey@adacore.com>
9018
9019         * windows-nat.c (windows_nat_target::attach)
9020         (windows_nat_target::detach): Don't call gdb_flush.
9021         * valprint.c (generic_val_print, val_print, val_print_string):
9022         Don't call gdb_flush.
9023         * utils.c (defaulted_query): Don't call gdb_flush.
9024         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9025         * target.c (target_announce_detach): Don't call gdb_flush.
9026         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9027         * remote.c (extended_remote_target::attach): Don't call
9028         gdb_flush.
9029         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9030         * printcmd.c (do_examine): Don't call gdb_flush.
9031         (info_display_command): Don't call gdb_flush.
9032         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9033         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9034         * memattr.c (info_mem_command): Don't call gdb_flush.
9035         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9036         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9037         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9038         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9039         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9040         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9041         (gnu_nat_target::detach): Don't call gdb_flush.
9042         * f-valprint.c (f_val_print): Don't call gdb_flush.
9043         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9044         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9045         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9046         gdb_flush.
9047         * c-valprint.c (c_val_print): Don't call gdb_flush.
9048         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9049
9050 2019-03-05  Tom Tromey  <tromey@adacore.com>
9051
9052         * varobj.c (update_dynamic_varobj_children): Update.
9053         (install_default_visualizer): Use reset, not release.
9054         * value.c (set_internalvar): Update.
9055         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9056         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9057         ATTRIBUTE_UNUSED_RESULT.
9058
9059 2019-03-05  Tom Tromey  <tromey@adacore.com>
9060
9061         * remote.c (class scoped_remote_fd) <release>: Add
9062         ATTRIBUTE_UNUSED_RESULT.
9063
9064 2019-03-05  Tom Tromey  <tromey@adacore.com>
9065
9066         * macroexp.c (struct macro_buffer) <release>: Add
9067         ATTRIBUTE_UNUSED_RESULT.
9068
9069 2019-03-05  Tom Tromey  <tromey@adacore.com>
9070
9071         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9072         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9073         ATTRIBUTE_UNUSED_RESULT.
9074
9075 2019-03-05  Tom Tromey  <tromey@adacore.com>
9076
9077         * common/scoped_fd.h (class scoped_fd) <release>: Add
9078         ATTRIBUTE_UNUSED_RESULT.
9079
9080 2019-03-05  Tom Tromey  <tromey@adacore.com>
9081
9082         * parser-defs.h (struct parser_state) <release>: Add
9083         ATTRIBUTE_UNUSED_RESULT.
9084
9085 2019-03-05  Tom Tromey  <tromey@adacore.com>
9086
9087         * utils.h (class gdb_argv) <release>: Add
9088         ATTRIBUTE_UNUSED_RESULT.
9089         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9090
9091 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9092
9093         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9094         for-loop range, to avoid compiler warnings.
9095
9096         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9097         avoid compiler warnings about unused variables.
9098
9099         * NEWS: Mention end of support for native debugging on MS-Windows
9100         before XP.
9101
9102         PR gdb/24292
9103         * common/netstuff.c:
9104         * gdbserver/gdbreplay.c
9105         * gdbserver/remote-utils.c:
9106         * ser-tcp.c:
9107         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9108         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9109         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9110         'getaddrinfo' and 'freeaddrinfo' were not available before
9111         Windows XP, and mingw.org's MinGW headers by default define
9112         _WIN32_WINNT to 0x500.
9113
9114 2019-03-01  Gary Benson <gbenson@redhat.com>
9115
9116         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9117
9118 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9119             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9120
9121         PR gdb/8527
9122         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9123         set_sigint_trap, clear_sigint_trap.
9124
9125 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9126
9127         * target.c (target_detach): Clear the regcache and the
9128         frame cache.
9129
9130 2019-02-27  Pedro Alves  <palves@redhat.com>
9131
9132         * utils.c (set_screen_size): When we cap the height/width sizes,
9133         tweak the corresponding command variable to show "unlimited":
9134
9135 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9136             Pedro Alves  <palves@redhat.com>
9137
9138         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9139         before calling rl_set_screen_size.
9140
9141 2019-02-27  Tom Tromey  <tromey@adacore.com>
9142
9143         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9144         define.
9145         * python/py-value.c: Remove Python 2.4 workaround.
9146         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9147         workaround.
9148         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9149         Python 2.4 workaround.
9150         * python/python-internal.h: Remove Python 2.4 comment.
9151         (Py_ssize_t): Don't define.
9152         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9153         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9154         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9155         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9156         * python/python.c (do_start_initialization): Remove Python 2.4
9157         workaround.
9158         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9159         (print_children): Remove Python 2.4 workaround.
9160         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9161         workaround.
9162         (CHARBUFFERPROC_NAME): Remove.
9163         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9164         Python 2.4 workaround.
9165
9166 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9167
9168         * NEWS: Note minimum Python version.
9169
9170 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9171
9172         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9173         code from these functions.  Remove corresponding ifdefs.  Use
9174         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9175         Remove gotos and target of gotos.
9176         (infpy_search_memory): Likewise.
9177
9178 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9179
9180         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9181         (hppa_gdbarch_init): Don't register deleted functions with
9182         gdbarch.
9183
9184 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9185
9186         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9187         (h8300_unwind_sp): Delete.
9188         (h8300_dummy_id): Delete.
9189         (h8300_gdbarch_init): Don't register deleted functions with
9190         gdbarch.
9191
9192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9193
9194         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9195         (ft32_unwind_pc): Delete.
9196         (ft32_unwind_sp): Delete.
9197         (ft32_gdbarch_init): Don't register deleted functions with
9198         gdbarch.
9199
9200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9201
9202         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9203         (frv_unwind_pc): Delete.
9204         (frv_unwind_sp): Delete.
9205         (frv_gdbarch_init): Don't register deleted functions with
9206         gdbarch.
9207
9208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9209
9210         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9211         (riscv_unwind_pc): Delete.
9212         (riscv_unwind_sp): Delete.
9213         (riscv_gdbarch_init): Don't register deleted functions with
9214         gdbarch.
9215
9216 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9217
9218         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9219         (csky_unwind_pc): Delete.
9220         (csky_unwind_sp): Delete.
9221         (csky_gdbarch_init): Don't register deleted functions with
9222         gdbarch.
9223
9224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9225
9226         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9227         (cris_unwind_pc): Delete.
9228         (cris_unwind_sp): Delete.
9229         (cris_gdbarch_init): Don't register deleted functions with
9230         gdbarch.
9231
9232 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9233
9234         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9235         (bfin_unwind_pc): Delete.
9236         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9237
9238 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9239
9240         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9241         (arm_unwind_pc): Delete.
9242         (arm_unwind_sp): Delete.
9243         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9244
9245 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9246
9247         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9248         (arc_unwind_pc): Delete.
9249         (arc_unwind_sp): Delete.
9250         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9251
9252 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9253
9254         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9255         (alpha_unwind_pc): Delete.
9256         (alpha_gdbarch_init): Don't register deleted functions with
9257         gdbarch.
9258
9259 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9260
9261         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9262         (aarch64_unwind_pc): Delete.
9263         (aarch64_unwind_sp): Delete.
9264         (aarch64_gdbarch_init): Don't register deleted functions with
9265         gdbarch.
9266
9267 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9268
9269         * gdbtypes.c (type_align): Don't consider static members when
9270         computing structure alignment.
9271
9272 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9273
9274         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9275         return 0 for other types.
9276         * arch-utils.c (default_type_align): Always return 0.
9277         * gdbarch.h: Regenerate.
9278         * gdbarch.sh (type_align): Extend comment.
9279         * gdbtypes.c (type_align): Add additional comments, always call
9280         gdbarch_type_align before applying the default rules.
9281         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9282         generic code will then apply a suitable default.
9283         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9284         types, return 0 for other types.
9285
9286 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9287
9288         * NEWS: Create a new section for the next release branch.
9289         Rename the section of the current branch, now that it has
9290         been cut.
9291
9292 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9293
9294         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9295         * version.in: Bump version to 8.3.50.DATE-git.
9296
9297 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9298
9299         * aix-thread.c (ptid_cmp): Remove unused variable.
9300         (get_signaled_thread): Likewise.
9301         (store_regs_user_thread): Likewise.
9302         (store_regs_kernel_thread): Likewise.
9303         (fetch_regs_kernel_thread): Remove shadowed variable.
9304
9305 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9306
9307         * features/riscv/32bit-cpu.xml: Add register numbers.
9308         * features/riscv/32bit-fpu.c: Regenerate.
9309         * features/riscv/32bit-fpu.xml: Add register numbers.
9310         * features/riscv/64bit-cpu.xml: Add register numbers.
9311         * features/riscv/64bit-fpu.c: Regenerate.
9312         * features/riscv/64bit-fpu.xml: Add register numbers.
9313
9314 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9315
9316         * NEWS: Mention two argument form of gdb.Value constructor.
9317         * python/py-value.c (convert_buffer_and_type_to_value): New
9318         function.
9319         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9320         Add support for handling an optional second argument.  Call
9321         convert_buffer_and_type_to_value as appropriate.
9322         * python/python-internal.h (Py_buffer_deleter): New struct.
9323         (Py_buffer_up): New typedef.
9324
9325 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9326
9327         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9328         instead of releasing ownership.
9329
9330 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9331
9332         * dwarf2read.c (open_and_init_dwp_file): Call
9333         elf_numsections instead of bfd_count_sections to initialize
9334         dwp_file->num_sections.
9335
9336 2019-02-25  Tom Tromey  <tromey@adacore.com>
9337
9338         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9339
9340 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9341
9342         * gcore.in: Add '--readnever' option when invoking GDB.
9343
9344 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9345
9346         * MAINTAINERS: Update my email address.
9347
9348 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9349
9350         * build-id.c (build_id_to_debug_bfd_1): New function.
9351         (build_id_to_debug_bfd): Look for separate debug file in
9352         sysroot.
9353
9354 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9355
9356         * gdbarch.sh: Update the copyright year range that is placed into
9357         generated files.
9358
9359 2019-02-22  Keith Seitz  <keiths@redhat.com>
9360
9361         PR symtab/23853
9362         * linespec.c (create_sals_line_offset): Search for the default
9363         symtab's filename instead of its fullname.
9364
9365 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9366
9367         * NEWS: Update style defaults.
9368
9369 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9370
9371         * main.c (captured_main_1): Disable styling in batch mode.
9372
9373 2019-02-20  Tom Tromey  <tom@tromey.com>
9374
9375         * symtab.c (symtab_symbol_info): Fix typos.
9376
9377 2019-02-20  Tom Tromey  <tromey@adacore.com>
9378
9379         * findcmd.c (_initialize_mem_search): Use upper case for
9380         metasyntactic variables.
9381
9382 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9383
9384         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9385         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9386
9387 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9388
9389         * top.h (source_file_name): Change to std::string.
9390         * top.c (source_file_name): Likewise.
9391         (command_line_input): Adjust.
9392         * cli/cli-script.c (script_from_file): Adjust.
9393
9394 2019-02-19  Tom Tromey  <tromey@adacore.com>
9395
9396         * ravenscar-thread.c
9397         (ravenscar_thread_target::update_thread_list): Don't call
9398         ada_build_task_list.
9399         * ada-lang.h (ada_build_task_list): Don't declare.
9400         * ada-tasks.c (struct ada_tasks_inferior_data)
9401         <task_list_valid_p>: Now bool.
9402         (read_known_tasks, ada_task_list_changed)
9403         (ada_tasks_invalidate_inferior_data): Update.
9404         (read_known_tasks_array): Return bool.
9405         (read_known_tasks_list): Likewise.
9406         (read_known_tasks): Return void.
9407         (ada_build_task_list): Now static.
9408
9409 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9410
9411         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9412         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9413
9414 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9415
9416         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9417         variant for ada_tasks_pspace_data_handle and
9418         ada_tasks_inferior_data_handle.
9419         (ada_tasks_pspace_data_cleanup): New function.
9420         (ada_tasks_inferior_data_cleanup): New function.
9421
9422 2019-02-17  Tom Tromey  <tom@tromey.com>
9423
9424         * macrotab.h (macro_source_fullname): Return a std::string.
9425         * macrotab.c (macro_include, check_for_redefinition)
9426         (macro_undef, macro_lookup_definition, foreach_macro)
9427         (foreach_macro_in_scope): Update.
9428         (macro_source_fullname): Return a std::string.
9429         * macrocmd.c (show_pp_source_pos): Update.
9430
9431 2019-02-17  Tom Tromey  <tom@tromey.com>
9432
9433         * macrocmd.c (show_pp_source_pos): Style the file names.
9434
9435 2019-02-17  Tom Tromey  <tom@tromey.com>
9436
9437         PR tui/24197:
9438         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9439
9440 2019-02-17  Tom Tromey  <tom@tromey.com>
9441
9442         * ada-lang.c (user_select_syms): Use filtered printing.
9443         * utils.c (wrap_style): New global.
9444         (desired_style): Remove.
9445         (emit_style_escape): Add stream parameter.
9446         (set_output_style, reset_terminal_style, prompt_for_continue):
9447         Update.
9448         (flush_wrap_buffer): Only flush gdb_stdout.
9449         (wrap_here): Set wrap_style.
9450         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9451         treat escape sequences as a character.  Change when wrap buffer is
9452         flushed.
9453         (fputs_styled): Do not set the output style when the default is
9454         requested.
9455         * ui-style.h (struct ui_file_style) <is_default>: New method.
9456         * source.c (print_source_lines_base): Emit escape sequences in one
9457         piece.
9458
9459 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9460
9461         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9462         integers and enumeration types.
9463
9464 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9465
9466         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9467         instead of lookup_symbol_in_language
9468         (do_exact_match): New function.
9469         (ada_get_symbol_name_matcher): Return do_exact_match when
9470         doing a verbatim match.
9471
9472 2019-02-15  Tom Tromey  <tromey@adacore.com>
9473
9474         * ravenscar-thread.c (ravenscar_thread_target::resume)
9475         (ravenscar_thread_target::wait): Special case wildcard requests.
9476
9477 2019-02-15  Tom Tromey  <tromey@adacore.com>
9478
9479         * ravenscar-thread.c (base_ptid): Remove.
9480         (struct ravenscar_thread_target) <close>: New method.
9481         <m_base_ptid>: New member.
9482         <update_inferior_ptid, active_task, task_is_currently_active,
9483         runtime_initialized>: Declare methods.
9484         <ravenscar_thread_target>: Add constructor.
9485         (ravenscar_thread_target::task_is_currently_active)
9486         (ravenscar_thread_target::update_inferior_ptid)
9487         (ravenscar_runtime_initialized): Rename.  Now methods.
9488         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9489         (ravenscar_thread_target::update_thread_list): Update.
9490         (ravenscar_thread_target::active_task): Now method.
9491         (ravenscar_thread_target::store_registers)
9492         (ravenscar_thread_target::prepare_to_store)
9493         (ravenscar_thread_target::prepare_to_store)
9494         (ravenscar_thread_target::mourn_inferior): Update.
9495         (ravenscar_inferior_created): Use "new" to create target.
9496         (ravenscar_thread_target::get_ada_task_ptid): Update.
9497         (_initialize_ravenscar): Don't initialize base_ptid.
9498         (ravenscar_ops): Remove global.
9499
9500 2019-02-15  Tom Tromey  <tromey@adacore.com>
9501
9502         * target.h (push_target): Declare new overload.
9503         * target.c (push_target): New overload, taking an rvalue reference.
9504         * remote.c (remote_target::open_1): Use push_target overload.
9505         * corelow.c (core_target_open): Use push_target overload.
9506
9507 2019-02-15  Tom Tromey  <tromey@adacore.com>
9508
9509         * ravenscar-thread.c (is_ravenscar_task)
9510         (ravenscar_task_is_currently_active): Return bool.
9511         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9512         (_initialize_ravenscar): Remove "(void)".
9513         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9514         Return bool.
9515
9516 2019-02-15  Tom Tromey  <tromey@adacore.com>
9517
9518         * ravenscar-thread.c (ravenscar_runtime_initializer)
9519         (has_ravenscar_runtime, get_running_thread_id)
9520         (ravenscar_thread_target::resume): Fix indentation.
9521
9522 2019-02-15  Tom Tromey  <tromey@adacore.com>
9523
9524         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9525         from ravenscar_arch_ops.
9526         (sparc_ravenscar_ops::fetch_registers)
9527         (sparc_ravenscar_ops::store_registers): Now methods.
9528         (sparc_ravenscar_prepare_to_store): Remove.
9529         (sparc_ravenscar_ops): Redefine.
9530         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9531         methods and destructor.  Remove members.
9532         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9533         (ravenscar_thread_target::store_registers)
9534         (ravenscar_thread_target::prepare_to_store): Update.
9535         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9536         Remove.
9537         (struct ppc_ravenscar_powerpc_ops): Derive from
9538         ravenscar_arch_ops.
9539         (ppc_ravenscar_powerpc_ops::fetch_registers)
9540         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9541         (ppc_ravenscar_powerpc_ops): Redefine.
9542         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9543         (ppc_ravenscar_e500_ops::fetch_registers)
9544         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9545         (ppc_ravenscar_e500_ops): Redefine.
9546         * aarch64-ravenscar-thread.c
9547         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9548         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9549         (aarch64_ravenscar_fetch_registers)
9550         (aarch64_ravenscar_store_registers): Now methods.
9551         (aarch64_ravenscar_ops): Redefine.
9552
9553 2019-02-15  Tom Tromey  <tromey@adacore.com>
9554
9555         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9556         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9557         (ravenscar_thread_target::stopped_by_watchpoint)
9558         (ravenscar_thread_target::stopped_data_address)
9559         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9560
9561 2019-02-15  Tom Tromey  <tromey@adacore.com>
9562
9563         * ravenscar-thread.c: Fix some typos.
9564
9565 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9566             Tom Tromey  <tromey@adacore.com>
9567
9568         * ada-lang.c (ada_exception_sal): Change addr_string to a
9569         std::string.
9570         (create_ada_exception_catchpoint): Update.
9571
9572 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9573             Tom Tromey  <tromey@adacore.com>
9574
9575         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9576         (bp_location_ops): Remove.
9577         (base_breakpoint_allocate_location): Update.
9578         (free_bp_location): Update.
9579         * ada-lang.c (class ada_catchpoint_location)
9580         <ada_catchpoint_location>: Remove ops parameter.
9581         (ada_catchpoint_location_dtor): Remove.
9582         (ada_catchpoint_location_ops): Remove.
9583         (allocate_location_exception): Update.
9584         * breakpoint.h (struct bp_location_ops): Remove.
9585         (class bp_location) <bp_location>: Remove bp_location_ops
9586         parameter.
9587         <~bp_location>: Add destructor.
9588         <ops>: Remove.
9589
9590 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9591             Pedro Alves  <palves@redhat.com>
9592
9593         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9594         'PATH_MAX'.
9595
9596 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9597             Samuel Thibault  <samuel.thibault@gnu.org>
9598             Thomas Schwinge  <thomas@codesourcery.com>
9599
9600         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9601         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9602
9603 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9604
9605         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9606         (check_empty): Use "const char *".
9607
9608         * gnu-nat.c (gnu_nat_target::detach): Instead of
9609         'detach_inferior (pid)' call
9610         'detach_inferior (find_inferior_pid (pid))'.
9611
9612         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9613         'nat/fork-inferior.o'.
9614         * gnu-nat.c: #include "nat/fork-inferior.h".
9615
9616         * gnu-nat.c (gnu_nat_target::detach): Instead of
9617         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9618         * gnu-nat.h: #include "inf-child.h".
9619         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9620         'i386_gnu_nat_target::fetch_registers'.
9621         (gnu_store_registers): Rename/move to
9622         'i386_gnu_nat_target::store_registers'.
9623
9624         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9625         * gnu-nat.h (mach_thread_info): New function.
9626         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9627
9628         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9629
9630 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9631
9632         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9633
9634 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9635
9636         * windows-nat.c (windows_add_thread): Add new parameter
9637         "main_thread_p" with default value set to false.  Update
9638         function documentation as well as all callers.
9639         (windows_delete_thread): Likewise.
9640         (fake_create_process): Update call to windows_add_thread.
9641         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9642         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9643         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9644         call to windows_delete_thread.
9645
9646 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9647
9648         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9649
9650 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9651
9652         * symfile.c (find_separate_debug_file): Use canonical path of
9653         sysroot with child_path instead of gdb_sysroot if it is valid.
9654
9655 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9656
9657         * symfile.c (find_separate_debug_file): Use child_path to
9658         determine if an object file is under a sysroot.
9659
9660 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9661
9662         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9663         unittests/child-path-selftests.c.
9664         * common/pathstuff.c (child_path): New function.
9665         * common/pathstuff.h (child_path): New prototype.
9666         * unittests/child-path-selftests.c: New file.
9667
9668 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9669
9670         * symfile.c (find_separate_debug_file): Look for separate debug
9671         files in debug directories under the sysroot.
9672
9673 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9674
9675         * symtab.h (struct minimal_symbol data_p): New const method.
9676         (struct minimal_symbol text_p): Likewise.
9677         * symtab.c (output_source_filename): Use file name style
9678         to print file name.
9679         (print_symbol_info): Likewise.
9680         (print_msymbol_info): Use address style to print addresses.
9681         Use function name style to print executable text symbols.
9682         (expand_symtab_containing_pc): Use data_p.
9683         (find_pc_sect_compunit_symtab): Likewise.
9684
9685 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9686
9687         * breakpoint.c (describe_other_breakpoints): Use address style
9688         to print addresses.
9689         (say_where): Likewise.
9690
9691 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9692
9693         * ada-typeprint.c (print_func_type): Print function name
9694         style to print function name.
9695         * c-typeprint.c (c_print_type_1): Likewise.
9696
9697 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9698
9699         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9700         for execve.
9701
9702 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9703
9704         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9705         type_stack.
9706
9707 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9708
9709         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9710         TYPE_CODE_REF types.
9711
9712 2019-02-08  Jim Wilson  <jimw@sifive.com>
9713
9714         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9715         (riscv_linux_fregset): New.
9716         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9717
9718 2019-02-07  Tom Tromey  <tom@tromey.com>
9719
9720         * thread.c (thread_cancel_execution_command): Update.
9721         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9722         methods.
9723         (struct thread_fsm_ops): Remove.
9724         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9725         (thread_fsm_should_stop, thread_fsm_return_value)
9726         (thread_fsm_set_finished, thread_fsm_finished_p)
9727         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9728         Don't declare.
9729         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9730         * infrun.c (clear_proceed_status_thread)
9731         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9732         (print_stop_event): Update.
9733         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9734         Add constructor.
9735         (step_command_fsm_ops): Remove.
9736         (new_step_command_fsm): Remove.
9737         (step_1): Update.
9738         (step_command_fsm::should_stop): Rename from
9739         step_command_fsm_should_stop.
9740         (step_command_fsm::clean_up): Rename from
9741         step_command_fsm_clean_up.
9742         (step_command_fsm::do_async_reply_reason): Rename from
9743         step_command_fsm_async_reply_reason.
9744         (struct until_next_fsm): Inherit from thread_fsm.  Add
9745         constructor.
9746         (until_next_fsm_ops): Remove.
9747         (new_until_next_fsm): Remove.
9748         (until_next_fsm::should_stop): Rename from
9749         until_next_fsm_should_stop.
9750         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9751         (until_next_fsm::do_async_reply_reason): Rename from
9752         until_next_fsm_async_reply_reason.
9753         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9754         constructor.  Change type of breakpoint.
9755         (finish_command_fsm_ops): Remove.
9756         (new_finish_command_fsm): Remove.
9757         (finish_command_fsm::should_stop): Rename from
9758         finish_command_fsm_should_stop.
9759         (finish_command_fsm::clean_up): Rename from
9760         finish_command_fsm_clean_up.
9761         (finish_command_fsm::return_value): Rename from
9762         finish_command_fsm_return_value.
9763         (finish_command_fsm::do_async_reply_reason): Rename from
9764         finish_command_fsm_async_reply_reason.
9765         (finish_command): Update.
9766         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9767         Add constructor.
9768         (call_thread_fsm_ops): Remove.
9769         (call_thread_fsm::call_thread_fsm): Rename from
9770         new_call_thread_fsm.
9771         (call_thread_fsm::should_stop): Rename from
9772         call_thread_fsm_should_stop.
9773         (call_thread_fsm::should_notify_stop): Rename from
9774         call_thread_fsm_should_notify_stop.
9775         (run_inferior_call, call_function_by_hand_dummy): Update.
9776         * cli/cli-interp.c (should_print_stop_to_console): Update.
9777         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9778         Add constructor.  Change type of location_breakpoint,
9779         caller_breakpoint.
9780         (until_break_fsm_ops): Remove.
9781         (new_until_break_fsm): Remove.
9782         (until_break_fsm::should_stop): Rename from
9783         until_break_fsm_should_stop.
9784         (until_break_fsm::clean_up): Rename from
9785         until_break_fsm_clean_up.
9786         (until_break_fsm::do_async_reply_reason): Rename from
9787         until_break_fsm_async_reply_reason.
9788         (until_break_command): Update.
9789         * thread-fsm.c: Remove.
9790         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9791
9792 2019-02-07  Tom Tromey  <tom@tromey.com>
9793
9794         * yy-remap.h: Add include guard.
9795         * xtensa-tdep.h: Add include guard.
9796         * xcoffread.h: Rename include guard.
9797         * varobj-iter.h: Add include guard.
9798         * tui/tui.h: Rename include guard.
9799         * tui/tui-winsource.h: Rename include guard.
9800         * tui/tui-wingeneral.h: Rename include guard.
9801         * tui/tui-windata.h: Rename include guard.
9802         * tui/tui-win.h: Rename include guard.
9803         * tui/tui-stack.h: Rename include guard.
9804         * tui/tui-source.h: Rename include guard.
9805         * tui/tui-regs.h: Rename include guard.
9806         * tui/tui-out.h: Rename include guard.
9807         * tui/tui-layout.h: Rename include guard.
9808         * tui/tui-io.h: Rename include guard.
9809         * tui/tui-hooks.h: Rename include guard.
9810         * tui/tui-file.h: Rename include guard.
9811         * tui/tui-disasm.h: Rename include guard.
9812         * tui/tui-data.h: Rename include guard.
9813         * tui/tui-command.h: Rename include guard.
9814         * tic6x-tdep.h: Add include guard.
9815         * target/waitstatus.h: Rename include guard.
9816         * target/wait.h: Rename include guard.
9817         * target/target.h: Rename include guard.
9818         * target/resume.h: Rename include guard.
9819         * target-float.h: Rename include guard.
9820         * stabsread.h: Add include guard.
9821         * rs6000-tdep.h: Add include guard.
9822         * riscv-fbsd-tdep.h: Add include guard.
9823         * regformats/regdef.h: Rename include guard.
9824         * record.h: Rename include guard.
9825         * python/python.h: Rename include guard.
9826         * python/python-internal.h: Rename include guard.
9827         * python/py-stopevent.h: Rename include guard.
9828         * python/py-ref.h: Rename include guard.
9829         * python/py-record.h: Rename include guard.
9830         * python/py-record-full.h: Rename include guard.
9831         * python/py-record-btrace.h: Rename include guard.
9832         * python/py-instruction.h: Rename include guard.
9833         * python/py-events.h: Rename include guard.
9834         * python/py-event.h: Rename include guard.
9835         * procfs.h: Add include guard.
9836         * proc-utils.h: Add include guard.
9837         * p-lang.h: Add include guard.
9838         * or1k-tdep.h: Rename include guard.
9839         * observable.h: Rename include guard.
9840         * nto-tdep.h: Rename include guard.
9841         * nat/x86-linux.h: Rename include guard.
9842         * nat/x86-linux-dregs.h: Rename include guard.
9843         * nat/x86-gcc-cpuid.h: Add include guard.
9844         * nat/x86-dregs.h: Rename include guard.
9845         * nat/x86-cpuid.h: Rename include guard.
9846         * nat/ppc-linux.h: Rename include guard.
9847         * nat/mips-linux-watch.h: Rename include guard.
9848         * nat/linux-waitpid.h: Rename include guard.
9849         * nat/linux-ptrace.h: Rename include guard.
9850         * nat/linux-procfs.h: Rename include guard.
9851         * nat/linux-osdata.h: Rename include guard.
9852         * nat/linux-nat.h: Rename include guard.
9853         * nat/linux-namespaces.h: Rename include guard.
9854         * nat/linux-btrace.h: Rename include guard.
9855         * nat/glibc_thread_db.h: Rename include guard.
9856         * nat/gdb_thread_db.h: Rename include guard.
9857         * nat/gdb_ptrace.h: Rename include guard.
9858         * nat/fork-inferior.h: Rename include guard.
9859         * nat/amd64-linux-siginfo.h: Rename include guard.
9860         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9861         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9862         * nat/aarch64-linux.h: Rename include guard.
9863         * nat/aarch64-linux-hw-point.h: Rename include guard.
9864         * mn10300-tdep.h: Add include guard.
9865         * mips-linux-tdep.h: Add include guard.
9866         * mi/mi-parse.h: Rename include guard.
9867         * mi/mi-out.h: Rename include guard.
9868         * mi/mi-main.h: Rename include guard.
9869         * mi/mi-interp.h: Rename include guard.
9870         * mi/mi-getopt.h: Rename include guard.
9871         * mi/mi-console.h: Rename include guard.
9872         * mi/mi-common.h: Rename include guard.
9873         * mi/mi-cmds.h: Rename include guard.
9874         * mi/mi-cmd-break.h: Rename include guard.
9875         * m2-lang.h: Add include guard.
9876         * location.h: Rename include guard.
9877         * linux-record.h: Rename include guard.
9878         * linux-nat.h: Add include guard.
9879         * linux-fork.h: Add include guard.
9880         * i386-darwin-tdep.h: Rename include guard.
9881         * hppa-linux-offsets.h: Add include guard.
9882         * guile/guile.h: Rename include guard.
9883         * guile/guile-internal.h: Rename include guard.
9884         * gnu-nat.h: Rename include guard.
9885         * gdb-stabs.h: Rename include guard.
9886         * frv-tdep.h: Add include guard.
9887         * f-lang.h: Add include guard.
9888         * event-loop.h: Add include guard.
9889         * darwin-nat.h: Rename include guard.
9890         * cp-abi.h: Rename include guard.
9891         * config/sparc/nm-sol2.h: Rename include guard.
9892         * config/nm-nto.h: Rename include guard.
9893         * config/nm-linux.h: Add include guard.
9894         * config/i386/nm-i386gnu.h: Rename include guard.
9895         * config/djgpp/nl_types.h: Rename include guard.
9896         * config/djgpp/langinfo.h: Rename include guard.
9897         * compile/gcc-cp-plugin.h: Add include guard.
9898         * compile/gcc-c-plugin.h: Add include guard.
9899         * compile/compile.h: Rename include guard.
9900         * compile/compile-object-run.h: Rename include guard.
9901         * compile/compile-object-load.h: Rename include guard.
9902         * compile/compile-internal.h: Rename include guard.
9903         * compile/compile-cplus.h: Rename include guard.
9904         * compile/compile-c.h: Rename include guard.
9905         * common/xml-utils.h: Rename include guard.
9906         * common/x86-xstate.h: Rename include guard.
9907         * common/version.h: Rename include guard.
9908         * common/vec.h: Rename include guard.
9909         * common/tdesc.h: Rename include guard.
9910         * common/selftest.h: Rename include guard.
9911         * common/scoped_restore.h: Rename include guard.
9912         * common/scoped_mmap.h: Rename include guard.
9913         * common/scoped_fd.h: Rename include guard.
9914         * common/safe-iterator.h: Rename include guard.
9915         * common/run-time-clock.h: Rename include guard.
9916         * common/refcounted-object.h: Rename include guard.
9917         * common/queue.h: Rename include guard.
9918         * common/ptid.h: Rename include guard.
9919         * common/print-utils.h: Rename include guard.
9920         * common/preprocessor.h: Rename include guard.
9921         * common/pathstuff.h: Rename include guard.
9922         * common/observable.h: Rename include guard.
9923         * common/netstuff.h: Rename include guard.
9924         * common/job-control.h: Rename include guard.
9925         * common/host-defs.h: Rename include guard.
9926         * common/gdb_wait.h: Rename include guard.
9927         * common/gdb_vecs.h: Rename include guard.
9928         * common/gdb_unlinker.h: Rename include guard.
9929         * common/gdb_unique_ptr.h: Rename include guard.
9930         * common/gdb_tilde_expand.h: Rename include guard.
9931         * common/gdb_sys_time.h: Rename include guard.
9932         * common/gdb_string_view.h: Rename include guard.
9933         * common/gdb_splay_tree.h: Rename include guard.
9934         * common/gdb_setjmp.h: Rename include guard.
9935         * common/gdb_ref_ptr.h: Rename include guard.
9936         * common/gdb_optional.h: Rename include guard.
9937         * common/gdb_locale.h: Rename include guard.
9938         * common/gdb_assert.h: Rename include guard.
9939         * common/filtered-iterator.h: Rename include guard.
9940         * common/filestuff.h: Rename include guard.
9941         * common/fileio.h: Rename include guard.
9942         * common/environ.h: Rename include guard.
9943         * common/common-utils.h: Rename include guard.
9944         * common/common-types.h: Rename include guard.
9945         * common/common-regcache.h: Rename include guard.
9946         * common/common-inferior.h: Rename include guard.
9947         * common/common-gdbthread.h: Rename include guard.
9948         * common/common-exceptions.h: Rename include guard.
9949         * common/common-defs.h: Rename include guard.
9950         * common/common-debug.h: Rename include guard.
9951         * common/cleanups.h: Rename include guard.
9952         * common/buffer.h: Rename include guard.
9953         * common/btrace-common.h: Rename include guard.
9954         * common/break-common.h: Rename include guard.
9955         * cli/cli-utils.h: Rename include guard.
9956         * cli/cli-style.h: Rename include guard.
9957         * cli/cli-setshow.h: Rename include guard.
9958         * cli/cli-script.h: Rename include guard.
9959         * cli/cli-interp.h: Rename include guard.
9960         * cli/cli-decode.h: Rename include guard.
9961         * cli/cli-cmds.h: Rename include guard.
9962         * charset-list.h: Add include guard.
9963         * buildsym-legacy.h: Rename include guard.
9964         * bfin-tdep.h: Add include guard.
9965         * ax.h: Rename include guard.
9966         * arm-linux-tdep.h: Add include guard.
9967         * arm-fbsd-tdep.h: Add include guard.
9968         * arch/xtensa.h: Rename include guard.
9969         * arch/tic6x.h: Add include guard.
9970         * arch/i386.h: Add include guard.
9971         * arch/arm.h: Rename include guard.
9972         * arch/arm-linux.h: Rename include guard.
9973         * arch/arm-get-next-pcs.h: Rename include guard.
9974         * arch/amd64.h: Add include guard.
9975         * arch/aarch64-insn.h: Rename include guard.
9976         * arch-utils.h: Rename include guard.
9977         * annotate.h: Add include guard.
9978         * amd64-darwin-tdep.h: Rename include guard.
9979         * aarch64-linux-tdep.h: Add include guard.
9980         * aarch64-fbsd-tdep.h: Add include guard.
9981         * aarch32-linux-nat.h: Add include guard.
9982
9983 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9984
9985         * macrotab.c (macro_define_internal): New function that
9986         factorizes macro_define_object_internal and macro_define_function
9987         code.
9988         (macro_define_object_internal): Use macro_define_internal.
9989         (macro_define_function): Likewise.
9990
9991 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9992
9993         * macrocmd.c (extract_identifier): Return
9994         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9995         callers.
9996
9997 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9998
9999         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10000
10001 2019-02-05  Tom Tromey  <tom@tromey.com>
10002
10003         * target.c (target_stack::unpush): Move assertion earlier.
10004
10005 2019-01-30  Tom Tromey  <tom@tromey.com>
10006
10007         PR python/23615:
10008         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10009         (gdbpy_parse_and_eval): Likewise.
10010         * python/python-internal.h (gdbpy_allow_threads): New class.
10011
10012 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10013
10014         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10015         (aarch64_fbsd_fpregmap): Move earlier.
10016         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10017         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10018         instead of individual calls to trad_frame_set_reg_addr.
10019         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10020         earlier.
10021         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10022         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10023         instead of individual calls to trad_frame_set_reg_addr.
10024
10025 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10026
10027         * CONTRIBUTE: Replace contribution list with wiki link.
10028
10029 2019-01-25  Tom Tromey  <tom@tromey.com>
10030
10031         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10032
10033 2019-01-25  Tom Tromey  <tom@tromey.com>
10034
10035         * xtensa-linux-nat.c: Fix common/ includes.
10036         * xml-support.h: Fix common/ includes.
10037         * xml-support.c: Fix common/ includes.
10038         * x86-linux-nat.c: Fix common/ includes.
10039         * windows-nat.c: Fix common/ includes.
10040         * varobj.h: Fix common/ includes.
10041         * varobj.c: Fix common/ includes.
10042         * value.c: Fix common/ includes.
10043         * valops.c: Fix common/ includes.
10044         * utils.c: Fix common/ includes.
10045         * unittests/xml-utils-selftests.c: Fix common/ includes.
10046         * unittests/utils-selftests.c: Fix common/ includes.
10047         * unittests/unpack-selftests.c: Fix common/ includes.
10048         * unittests/tracepoint-selftests.c: Fix common/ includes.
10049         * unittests/style-selftests.c: Fix common/ includes.
10050         * unittests/string_view-selftests.c: Fix common/ includes.
10051         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10052         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10053         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10054         * unittests/rsp-low-selftests.c: Fix common/ includes.
10055         * unittests/parse-connection-spec-selftests.c: Fix common/
10056         includes.
10057         * unittests/optional-selftests.c: Fix common/ includes.
10058         * unittests/offset-type-selftests.c: Fix common/ includes.
10059         * unittests/observable-selftests.c: Fix common/ includes.
10060         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10061         * unittests/memrange-selftests.c: Fix common/ includes.
10062         * unittests/memory-map-selftests.c: Fix common/ includes.
10063         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10064         * unittests/function-view-selftests.c: Fix common/ includes.
10065         * unittests/environ-selftests.c: Fix common/ includes.
10066         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10067         * unittests/common-utils-selftests.c: Fix common/ includes.
10068         * unittests/cli-utils-selftests.c: Fix common/ includes.
10069         * unittests/array-view-selftests.c: Fix common/ includes.
10070         * ui-file.c: Fix common/ includes.
10071         * tui/tui-io.c: Fix common/ includes.
10072         * tracepoint.h: Fix common/ includes.
10073         * tracepoint.c: Fix common/ includes.
10074         * tracefile-tfile.c: Fix common/ includes.
10075         * top.h: Fix common/ includes.
10076         * top.c: Fix common/ includes.
10077         * thread.c: Fix common/ includes.
10078         * target/waitstatus.h: Fix common/ includes.
10079         * target/waitstatus.c: Fix common/ includes.
10080         * target.h: Fix common/ includes.
10081         * target.c: Fix common/ includes.
10082         * target-memory.c: Fix common/ includes.
10083         * target-descriptions.c: Fix common/ includes.
10084         * symtab.h: Fix common/ includes.
10085         * symfile.c: Fix common/ includes.
10086         * stap-probe.c: Fix common/ includes.
10087         * spu-linux-nat.c: Fix common/ includes.
10088         * sparc-nat.c: Fix common/ includes.
10089         * source.c: Fix common/ includes.
10090         * solib.c: Fix common/ includes.
10091         * solib-target.c: Fix common/ includes.
10092         * ser-unix.c: Fix common/ includes.
10093         * ser-tcp.c: Fix common/ includes.
10094         * ser-pipe.c: Fix common/ includes.
10095         * ser-base.c: Fix common/ includes.
10096         * selftest-arch.c: Fix common/ includes.
10097         * s12z-tdep.c: Fix common/ includes.
10098         * rust-exp.y: Fix common/ includes.
10099         * rs6000-aix-tdep.c: Fix common/ includes.
10100         * riscv-tdep.c: Fix common/ includes.
10101         * remote.c: Fix common/ includes.
10102         * remote-notif.h: Fix common/ includes.
10103         * remote-fileio.h: Fix common/ includes.
10104         * remote-fileio.c: Fix common/ includes.
10105         * regcache.h: Fix common/ includes.
10106         * regcache.c: Fix common/ includes.
10107         * record-btrace.c: Fix common/ includes.
10108         * python/python.c: Fix common/ includes.
10109         * python/py-type.c: Fix common/ includes.
10110         * python/py-inferior.c: Fix common/ includes.
10111         * progspace.h: Fix common/ includes.
10112         * producer.c: Fix common/ includes.
10113         * procfs.c: Fix common/ includes.
10114         * proc-api.c: Fix common/ includes.
10115         * printcmd.c: Fix common/ includes.
10116         * ppc-linux-nat.c: Fix common/ includes.
10117         * parser-defs.h: Fix common/ includes.
10118         * osdata.c: Fix common/ includes.
10119         * obsd-nat.c: Fix common/ includes.
10120         * nat/x86-linux.c: Fix common/ includes.
10121         * nat/x86-linux-dregs.c: Fix common/ includes.
10122         * nat/x86-dregs.h: Fix common/ includes.
10123         * nat/x86-dregs.c: Fix common/ includes.
10124         * nat/ppc-linux.c: Fix common/ includes.
10125         * nat/mips-linux-watch.h: Fix common/ includes.
10126         * nat/mips-linux-watch.c: Fix common/ includes.
10127         * nat/linux-waitpid.c: Fix common/ includes.
10128         * nat/linux-ptrace.h: Fix common/ includes.
10129         * nat/linux-ptrace.c: Fix common/ includes.
10130         * nat/linux-procfs.c: Fix common/ includes.
10131         * nat/linux-personality.c: Fix common/ includes.
10132         * nat/linux-osdata.c: Fix common/ includes.
10133         * nat/linux-namespaces.c: Fix common/ includes.
10134         * nat/linux-btrace.h: Fix common/ includes.
10135         * nat/linux-btrace.c: Fix common/ includes.
10136         * nat/fork-inferior.c: Fix common/ includes.
10137         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10138         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10139         * nat/aarch64-linux.c: Fix common/ includes.
10140         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10141         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10142         * namespace.h: Fix common/ includes.
10143         * mips-linux-tdep.c: Fix common/ includes.
10144         * minsyms.c: Fix common/ includes.
10145         * mi/mi-parse.h: Fix common/ includes.
10146         * mi/mi-main.c: Fix common/ includes.
10147         * mi/mi-cmd-env.c: Fix common/ includes.
10148         * memrange.h: Fix common/ includes.
10149         * memattr.c: Fix common/ includes.
10150         * maint.h: Fix common/ includes.
10151         * maint.c: Fix common/ includes.
10152         * main.c: Fix common/ includes.
10153         * machoread.c: Fix common/ includes.
10154         * location.c: Fix common/ includes.
10155         * linux-thread-db.c: Fix common/ includes.
10156         * linux-nat.c: Fix common/ includes.
10157         * linux-fork.c: Fix common/ includes.
10158         * inline-frame.c: Fix common/ includes.
10159         * infrun.c: Fix common/ includes.
10160         * inflow.c: Fix common/ includes.
10161         * inferior.h: Fix common/ includes.
10162         * inferior.c: Fix common/ includes.
10163         * infcmd.c: Fix common/ includes.
10164         * inf-ptrace.c: Fix common/ includes.
10165         * inf-child.c: Fix common/ includes.
10166         * ia64-linux-nat.c: Fix common/ includes.
10167         * i387-tdep.c: Fix common/ includes.
10168         * i386-tdep.c: Fix common/ includes.
10169         * i386-linux-tdep.c: Fix common/ includes.
10170         * i386-linux-nat.c: Fix common/ includes.
10171         * i386-go32-tdep.c: Fix common/ includes.
10172         * i386-fbsd-tdep.c: Fix common/ includes.
10173         * i386-fbsd-nat.c: Fix common/ includes.
10174         * guile/scm-type.c: Fix common/ includes.
10175         * guile/guile.c: Fix common/ includes.
10176         * go32-nat.c: Fix common/ includes.
10177         * gnu-nat.c: Fix common/ includes.
10178         * gdbthread.h: Fix common/ includes.
10179         * gdbarch-selftests.c: Fix common/ includes.
10180         * gdb_usleep.c: Fix common/ includes.
10181         * gdb_select.h: Fix common/ includes.
10182         * gdb_bfd.c: Fix common/ includes.
10183         * gcore.c: Fix common/ includes.
10184         * fork-child.c: Fix common/ includes.
10185         * findvar.c: Fix common/ includes.
10186         * fbsd-nat.c: Fix common/ includes.
10187         * event-top.c: Fix common/ includes.
10188         * event-loop.c: Fix common/ includes.
10189         * dwarf2read.c: Fix common/ includes.
10190         * dwarf2loc.c: Fix common/ includes.
10191         * dwarf2-frame.c: Fix common/ includes.
10192         * dwarf-index-cache.c: Fix common/ includes.
10193         * dtrace-probe.c: Fix common/ includes.
10194         * disasm-selftests.c: Fix common/ includes.
10195         * defs.h: Fix common/ includes.
10196         * csky-tdep.c: Fix common/ includes.
10197         * cp-valprint.c: Fix common/ includes.
10198         * cp-support.h: Fix common/ includes.
10199         * cp-support.c: Fix common/ includes.
10200         * corelow.c: Fix common/ includes.
10201         * completer.h: Fix common/ includes.
10202         * completer.c: Fix common/ includes.
10203         * compile/compile.c: Fix common/ includes.
10204         * compile/compile-loc2c.c: Fix common/ includes.
10205         * compile/compile-cplus-types.c: Fix common/ includes.
10206         * compile/compile-cplus-symbols.c: Fix common/ includes.
10207         * command.h: Fix common/ includes.
10208         * cli/cli-dump.c: Fix common/ includes.
10209         * cli/cli-cmds.c: Fix common/ includes.
10210         * charset.c: Fix common/ includes.
10211         * build-id.c: Fix common/ includes.
10212         * btrace.h: Fix common/ includes.
10213         * btrace.c: Fix common/ includes.
10214         * breakpoint.h: Fix common/ includes.
10215         * breakpoint.c: Fix common/ includes.
10216         * ax.h:
10217         (enum agent_op): Fix common/ includes.
10218         * ax-general.c (struct aop_map): Fix common/ includes.
10219         * ax-gdb.c: Fix common/ includes.
10220         * auxv.c: Fix common/ includes.
10221         * auto-load.c: Fix common/ includes.
10222         * arm-tdep.c: Fix common/ includes.
10223         * arch/riscv.c: Fix common/ includes.
10224         * arch/ppc-linux-common.c: Fix common/ includes.
10225         * arch/i386.c: Fix common/ includes.
10226         * arch/arm.c: Fix common/ includes.
10227         * arch/arm-linux.c: Fix common/ includes.
10228         * arch/arm-get-next-pcs.c: Fix common/ includes.
10229         * arch/amd64.c: Fix common/ includes.
10230         * arch/aarch64.c: Fix common/ includes.
10231         * arch/aarch64-insn.c: Fix common/ includes.
10232         * arch-utils.c: Fix common/ includes.
10233         * amd64-windows-tdep.c: Fix common/ includes.
10234         * amd64-tdep.c: Fix common/ includes.
10235         * amd64-sol2-tdep.c: Fix common/ includes.
10236         * amd64-obsd-tdep.c: Fix common/ includes.
10237         * amd64-nbsd-tdep.c: Fix common/ includes.
10238         * amd64-linux-tdep.c: Fix common/ includes.
10239         * amd64-linux-nat.c: Fix common/ includes.
10240         * amd64-fbsd-tdep.c: Fix common/ includes.
10241         * amd64-fbsd-nat.c: Fix common/ includes.
10242         * amd64-dicos-tdep.c: Fix common/ includes.
10243         * amd64-darwin-tdep.c: Fix common/ includes.
10244         * agent.c: Fix common/ includes.
10245         * ada-lang.h: Fix common/ includes.
10246         * ada-lang.c: Fix common/ includes.
10247         * aarch64-tdep.c: Fix common/ includes.
10248
10249 2019-01-25  Tom Tromey  <tom@tromey.com>
10250
10251         * common/create-version.sh: Use common/version.h.
10252
10253 2019-01-24  Pedro Alves  <palves@redhat.com>
10254
10255         * infrun.c (signal_stop, signal_print, signal_program)
10256         (signal_catch, signal_pass): Now arrays instead of pointers.
10257         (update_signals_program_target, do_target_resume)
10258         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10259         * linux-nat.c (linux_nat_target::pass_signals)
10260         (linux_nat_target::create_inferior, linux_nat_target::attach):
10261         Adjust.
10262         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10263         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10264         * procfs.c (procfs_target::pass_signals): Adjust.
10265         * record-full.c (record_full_target::resume): Adjust.
10266         * remote.c (remote_target::pass_signals)
10267         (remote_target::program_signals): Adjust.
10268         * target-debug.h (target_debug_print_signals): Now takes a
10269         gdb::array_view as parameter.  Adjust.
10270         * target.h (target_ops) <pass_signals, program_signals>: Replace
10271         pointer and length parameters with gdb::array_view.
10272         (target_pass_signals, target_program_signals): Likewise.
10273         * target-delegates.c: Regenerate.
10274
10275 2019-01-24  Pedro Alves  <palves@redhat.com>
10276
10277         * common/forward-scope-exit.h
10278         (forward_scope_exit::forward_scope_exit): Pass arguments to
10279         m_bind_function directly, instead of creating a std::bind and
10280         copying that.
10281
10282 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10283
10284         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10285         for static members.
10286         (pass_in_v_vfp_candidate): Likewise.
10287
10288 2019-01-23  Tom Tromey  <tom@tromey.com>
10289             Pedro Alves  <palves@redhat.com>
10290
10291         * regcache.c (class regcache_invalidator): Remove.
10292         (regcache::raw_write): Use make_scope_exit.
10293
10294 2019-01-23  Tom Tromey  <tom@tromey.com>
10295
10296         * ui-out.h (class ui_out_emit_type): Update comment.
10297
10298 2019-01-23  Tom Tromey  <tom@tromey.com>
10299
10300         * infrun.c (fetch_inferior_event): Update comment.
10301
10302 2019-01-23  Tom Tromey  <tom@tromey.com>
10303             Pedro Alves  <palves@redhat.com>
10304
10305         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10306         parameter.
10307         (fetch_inferior_event): Use SCOPE_EXIT.
10308
10309
10310 2019-01-23  Tom Tromey  <tom@tromey.com>
10311             Pedro Alves  <palves@redhat.com>
10312
10313         * infrun.c (disable_thread_events): Delete.
10314         (stop_all_threads): Use SCOPE_EXIT.
10315
10316 2019-01-23  Tom Tromey  <tom@tromey.com>
10317             Pedro Alves  <palves@redhat.com>
10318
10319         * symfile.c: Include forward-scope-exit.h.
10320         (clear_symtab_users_cleanup): Replace forward declaration with
10321         a FORWARD_SCOPE_EXIT.
10322         (syms_from_objfile_1): Use the forward_scope_exit and
10323         gdb::optional instead of cleanup_function.
10324         (reread_symbols): Use the forward_scope_exit instead of
10325         cleanup_function.
10326         (clear_symtab_users_cleanup): Remove function.
10327
10328 2019-01-23  Tom Tromey  <tom@tromey.com>
10329             Pedro Alves  <palves@redhat.com>
10330
10331         * linux-nat.c: Include scope-exit.h.
10332         (cleanup_target_stop): Remove.
10333         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10334         SCOPE_EXIT.
10335
10336 2019-01-23  Tom Tromey  <tom@tromey.com>
10337             Pedro Alves  <palves@redhat.com>
10338
10339         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10340         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10341
10342 2019-01-23  Tom Tromey  <tom@tromey.com>
10343             Andrew Burgess  <andrew.burgess@embecosm.com>
10344             Pedro Alves  <palves@redhat.com>
10345
10346         * infrun.c (fetch_inferior_event): Use scope_exit.
10347         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10348         * top.c (execute_command): Use scope_exit.
10349         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10350         * utils.c (do_bpstat_clear_actions_cleanup)
10351         (make_bpstat_clear_actions_cleanup): Remove.
10352
10353 2019-01-23  Tom Tromey  <tom@tromey.com>
10354             Pedro Alves  <palves@redhat.com>
10355
10356         * infrun.c: Include "common/scope-exit.h"
10357         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10358         (wait_for_inferior): Use SCOPE_EXIT.
10359         (fetch_inferior_event): Use scope_exit.
10360
10361 2019-01-23  Tom Tromey  <tom@tromey.com>
10362             Pedro Alves  <palves@redhat.com>
10363
10364         * breakpoint.c (create_breakpoint): Remove cleanup.
10365
10366 2019-01-23  Tom Tromey  <tom@tromey.com>
10367             Andrew Burgess  <andrew.burgess@embecosm.com>
10368             Pedro Alves  <palves@redhat.com>
10369
10370 2019-01-23  Pedro Alves  <palves@redhat.com>
10371
10372         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10373
10374 2019-01-23  Pedro Alves  <palves@redhat.com>
10375             Andrew Burgess  <andrew.burgess@embecosm.com>
10376
10377         * gdbthread.h: Include "common/forward-scope-exit.h".
10378         (scoped_finish_thread_state): Redefine custom class in terms of
10379         forward_scope_exit.
10380
10381 2019-01-23  Pedro Alves  <palves@redhat.com>
10382             Andrew Burgess  <andrew.burgess@embecosm.com>
10383
10384         * common/forward-scope-exit.h: New file.
10385
10386 2019-01-23  Pedro Alves  <palves@redhat.com>
10387             Andrew Burgess  <andrew.burgess@embecosm.com>
10388             Tom Tromey  <tom@tromey.com>
10389
10390         * common/scope-exit.h: New file.
10391
10392 2019-01-23  Pedro Alves  <palves@redhat.com>
10393
10394         * common/preprocessor.h (ESC): Rename to ...
10395         (ESC_PARENS): ... this.
10396         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10397         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10398
10399 2019-01-23  Tom Tromey  <tom@tromey.com>
10400
10401         * language.h (class scoped_switch_to_sym_language_if_auto):
10402         Initialize m_lang in both cases.
10403
10404 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10405
10406         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10407         with XCNEW.
10408
10409 2019-01-22  Tom Tromey  <tom@tromey.com>
10410
10411         * corelow.c: Do not include sys/file.h.
10412
10413 2019-01-22  Tom Tromey  <tom@tromey.com>
10414
10415         * tui/tui-wingeneral.h: Include gdb_curses.h.
10416
10417 2019-01-22  Tom Tromey  <tom@tromey.com>
10418
10419         * source-cache.h (class source_cache) <get_source_lines,
10420         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10421
10422 2019-01-22  Tom Tromey  <tom@tromey.com>
10423
10424         * remote-fileio.h (struct remote_target): Declare.
10425
10426 2019-01-22  Tom Tromey  <tom@tromey.com>
10427
10428         * python/py-arch.c: Do not include py-ref.h.
10429         * python/py-bpevent.c: Do not include py-ref.h.
10430         * python/py-cmd.c: Do not include py-ref.h.
10431         * python/py-continueevent.c: Do not include py-ref.h.
10432         * python/py-event.h: Do not include py-ref.h.
10433         * python/py-evtregistry.c: Do not include py-ref.h.
10434         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10435         * python/py-frame.c: Do not include py-ref.h.
10436         * python/py-framefilter.c: Do not include py-ref.h.
10437         * python/py-function.c: Do not include py-ref.h.
10438         * python/py-infevents.c: Do not include py-ref.h.
10439         * python/py-linetable.c: Do not include py-ref.h.
10440         * python/py-objfile.c: Do not include py-ref.h.
10441         * python/py-param.c: Do not include py-ref.h.
10442         * python/py-prettyprint.c: Do not include py-ref.h.
10443         * python/py-progspace.c: Do not include py-ref.h.
10444         * python/py-symbol.c: Do not include py-ref.h.
10445         * python/py-symtab.c: Do not include py-ref.h.
10446         * python/py-type.c: Do not include py-ref.h.
10447         * python/py-unwind.c: Do not include py-ref.h.
10448         * python/py-utils.c: Do not include py-ref.h.
10449         * python/py-value.c: Do not include py-ref.h.
10450         * python/py-varobj.c: Do not include py-ref.h.
10451         * python/py-xmethods.c: Do not include py-ref.h.
10452         * python/python.c: Do not include py-ref.h.
10453         * varobj.c: Do not include py-ref.h.
10454
10455 2019-01-22  Tom Tromey  <tom@tromey.com>
10456
10457         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10458         keyword for bcache.
10459
10460 2019-01-22  Tom Tromey  <tom@tromey.com>
10461
10462         * compile/compile-cplus-types.c: Remove a comment by #include.
10463
10464 2019-01-22  Tom Tromey  <tom@tromey.com>
10465
10466         * compile/gcc-c-plugin.h: Include compile-internal.h.
10467
10468 2019-01-22  Tom Tromey  <tom@tromey.com>
10469
10470         * stabsread.c (EXTERN): Do not define.
10471         (symnum, next_symbol_text_func, processing_gcc_compilation)
10472         (within_function, global_sym_chain, global_stabs)
10473         (previous_stab_code, this_object_header_files)
10474         (n_this_object_header_files)
10475         (n_allocated_this_object_header_files): Define.
10476         * stabsread.h (EXTERN): Never define.  Use "extern".
10477
10478 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10479
10480         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10481         history_value.
10482
10483 2019-01-21  Tom Tromey  <tom@tromey.com>
10484
10485         * ui-out.c: Fix includes.
10486         * tui/tui-source.c: Fix includes.
10487         * target.c: Fix includes.
10488         * remote.c: Fix includes.
10489         * regcache.c: Fix includes.
10490         * python/py-block.c: Fix includes.
10491         * printcmd.c: Fix includes.
10492         * or1k-tdep.c: Fix includes.
10493         * mi/mi-main.c: Fix includes.
10494         * m32r-tdep.c: Fix includes.
10495         * csky-tdep.c: Fix includes.
10496         * compile/compile-cplus-types.c: Fix includes.
10497         * cli/cli-interp.c: Fix includes.
10498
10499 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10500
10501         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10502         for padding.
10503
10504 2019-01-16  Tom Tromey  <tom@tromey.com>
10505
10506         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10507         earlier.
10508         (struct objfile) <msymbols_range>: Move from top level.
10509         <msymbols>: New method.
10510         (class objfile_msymbols): Remove.
10511         * symtab.c (default_collect_symbol_completion_matches_break_on):
10512         Update.
10513         * symmisc.c (dump_msymbols): Update.
10514         * stabsread.c (scan_file_globals): Update.
10515         * objc-lang.c (info_selectors_command, info_classes_command)
10516         (find_methods): Update.
10517         * minsyms.c (find_solib_trampoline_target): Update.
10518         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10519         * coffread.c (coff_symfile_read): Update.
10520         * ada-lang.c (ada_lookup_simple_minsym)
10521         (ada_collect_symbol_completion_matches): Update.
10522
10523 2019-01-16  Tom Tromey  <tom@tromey.com>
10524
10525         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10526         type.  Remove no-argument constructor.
10527         <iterator::operator++>: Simplify.
10528         <begin>: Update.
10529         <end>: Use minimal_symbol_count.
10530
10531 2019-01-16  Tom Tromey  <tom@tromey.com>
10532
10533         * objfiles.h (struct objfile) <psymtabs>: New method.
10534         (class objfile_psymtabs): Remove.
10535         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10536         typedef.
10537         <range>: New method.
10538         (require_partial_symbols): Change return type.
10539         * psymtab.c (require_partial_symbols)
10540         (psym_expand_symtabs_matching): Update.
10541         * mdebugread.c (parse_partial_symbols): Update.
10542         * dbxread.c (dbx_end_psymtab): Update.
10543
10544 2019-01-15  Tom Tromey  <tom@tromey.com>
10545
10546         * symtab.c (lookup_objfile_from_block)
10547         (lookup_symbol_in_objfile_symtabs)
10548         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10549         (find_line_symtab, info_sources_command)
10550         (default_collect_symbol_completion_matches_break_on)
10551         (make_source_files_completion_list): Update.
10552         * symmisc.c (print_objfile_statistics, dump_objfile)
10553         (maintenance_print_symbols, maintenance_info_symtabs)
10554         (maintenance_check_symtabs, maintenance_info_line_tables):
10555         Update.
10556         * source.c (select_source_symtab)
10557         (forget_cached_source_info_for_objfile): Update.
10558         * objfiles.h (class objfile_compunits): Remove.
10559         (struct objfile) <compunits_range>: New typedef.
10560         (compunits): New method.
10561         * objfiles.c (objfile_relocate1): Update.
10562         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10563         * maint.c (count_symtabs_and_blocks): Update.
10564         * linespec.c (iterate_over_all_matching_symtabs): Update.
10565         * cp-support.c (add_symbol_overload_list_qualified): Update.
10566         * coffread.c (coff_symtab_read): Update.
10567         * ada-lang.c (add_nonlocal_symbols)
10568         (ada_collect_symbol_completion_matches)
10569         (ada_add_global_exceptions): Update.
10570
10571 2019-01-15  Tom Tromey  <tom@tromey.com>
10572
10573         * progspace.h (program_space) <objfiles_safe_range>: New
10574         typedef.
10575         <objfiles_safe>: New method.
10576         * objfiles.h (class all_objfiles_safe): Remove.
10577         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10578         * jit.c (jit_inferior_exit_hook): Update.
10579
10580 2019-01-17  Tom Tromey  <tom@tromey.com>
10581
10582         * progspace.h (program_space) <objfiles_range>: New typedef.
10583         <objfiles>: New method.
10584         <objfiles_head>: Rename from objfiles.
10585         (object_files): Update.
10586         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10587         * guile/scm-pretty-print.c
10588         (ppscm_find_pretty_printer_from_objfiles): Update.
10589         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10590         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10591         Update.
10592         * python/py-progspace.c (pspy_get_objfiles): Update.
10593         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10594         Update.
10595         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10596         (objfpy_lookup_objfile_by_build_id): Update.
10597         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10598         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10599         Update.
10600         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10601         (expand_symtab_containing_pc, lookup_objfile_from_block)
10602         (lookup_static_symbol, basic_lookup_transparent_type)
10603         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10604         (find_line_symtab, info_sources_command)
10605         (default_collect_symbol_completion_matches_break_on)
10606         (make_source_files_completion_list, find_main_name): Update.
10607         * symmisc.c (print_symbol_bcache_statistics)
10608         (print_objfile_statistics, maintenance_print_symbols)
10609         (maintenance_print_msymbols, maintenance_print_objfiles)
10610         (maintenance_info_symtabs, maintenance_check_symtabs)
10611         (maintenance_expand_symtabs, maintenance_info_line_tables):
10612         Update.
10613         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10614         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10615         (map_overlay_command, unmap_overlay_command)
10616         (simple_overlay_update, expand_symtabs_matching)
10617         (map_symbol_filenames): Update.
10618         * symfile-debug.c (set_debug_symfile): Update.
10619         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10620         Update.
10621         * source.c (select_source_symtab, forget_cached_source_info):
10622         Update.
10623         * solib.c (solib_read_symbols): Update.
10624         * solib-spu.c (append_ocl_sos): Update.
10625         * psymtab.c (maintenance_print_psymbols)
10626         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10627         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10628         * printcmd.c (info_symbol_command): Update.
10629         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10630         Update.
10631         * objfiles.h (class all_objfiles): Remove.
10632         * objfiles.c (have_partial_symbols, have_full_symbols)
10633         (have_minimal_symbols, qsort_cmp, update_section_map)
10634         (shared_objfile_contains_address_p)
10635         (default_iterate_over_objfiles_in_search_order): Update.
10636         * objc-lang.c (info_selectors_command, info_classes_command)
10637         (find_methods): Update.
10638         * minsyms.c (find_solib_trampoline_target): Update.
10639         * maint.c (maintenance_info_sections)
10640         (maintenance_translate_address, count_symtabs_and_blocks):
10641         Update.
10642         * main.c (captured_main_1): Update.
10643         * linux-thread-db.c (try_thread_db_load_from_pdir)
10644         (has_libpthread): Update.
10645         * linespec.c (iterate_over_all_matching_symtabs)
10646         (search_minsyms_for_name): Update.
10647         * jit.c (jit_find_objf_with_entry_addr): Update.
10648         * hppa-tdep.c (find_unwind_entry)
10649         (hppa_lookup_stub_minimal_symbol): Update.
10650         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10651         Update.
10652         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10653         (elf_gnu_ifunc_resolve_by_got): Update.
10654         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10655         * dwarf-index-write.c (save_gdb_index_command): Update.
10656         * cp-support.c (add_symbol_overload_list_qualified): Update.
10657         * breakpoint.c (create_overlay_event_breakpoint)
10658         (create_longjmp_master_breakpoint)
10659         (create_std_terminate_master_breakpoint)
10660         (create_exception_master_breakpoint): Update.
10661         * blockframe.c (find_pc_partial_function): Update.
10662         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10663         (ada_collect_symbol_completion_matches)
10664         (ada_add_global_exceptions): Update.
10665
10666 2019-01-17  Tom Tromey  <tom@tromey.com>
10667
10668         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10669         declare VEC.
10670         (solib_target_parse_libraries): Change return type.
10671         (library_list_start_segment, library_list_start_section)
10672         (library_list_end_library, library_list_start_library); Update.
10673         (solib_target_free_library_list): Remove.
10674         (solib_target_parse_libraries): Remove cleanup.  Change return
10675         type.
10676         (solib_target_current_sos): Update.
10677
10678 2019-01-17  Tom Tromey  <tromey@bapiya>
10679
10680         * valprint.c: Replace "the the" with "the".
10681         * symtab.c: Replace "the the" with "the".
10682         * solib.c: Replace "the the" with "the".
10683         * solib-dsbt.c: Replace "the the" with "the".
10684         * linespec.c: Replace "the the" with "the".
10685         * dwarf2loc.h: Replace "the the" with "the".
10686         * amd64-windows-tdep.c: Replace "the the" with "the".
10687         * aarch64-tdep.c: Replace "the the" with "the".
10688
10689 2019-01-16  Keith Seitz  <keiths@redhat.com>
10690
10691         PR gdb/23773
10692         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10693         <builder>: Rename to ..
10694         <m_builder>: ... this and make private.
10695         (dwarf2_cu::get_builder): New method.  Change all users of
10696         `builder' to use this method.
10697         (dwarf2_start_symtab): Move to ...
10698         (dwarf2_cu::start_symtab): ... here.  Update all callers
10699         (setup_type_unit_groups): Move to ...
10700         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10701         callers.
10702         (dwarf2_cu::reset_builder): New method.
10703         (process_full_compunit, process_full_type_unit): Use
10704         dwarf2_cu::reset_builder.
10705         (follow_die_offset): Record the ancestor CU if it is different
10706         from the followed DIE's CU.
10707         (follow_die_sig_1): Likewise.
10708
10709 2019-01-15  Tom Tromey  <tom@tromey.com>
10710
10711         * remote.c (class remote_state) <buf>: Now a char_vector.
10712         <buf_size>: Remove.
10713         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10714         parameter.
10715         (remote_target::getpkt_or_notif_sane_1)
10716         (remote_target::getpkt_sane)
10717         (remote_target::getpkt_or_notif_sane): Likewise.
10718         (class remote_target) <putpkt>: New overload.
10719         (remote_target::read_frame): Change type of "buf_p".  Remove
10720         sizeof_p parameter.
10721         (packet_ok): New overload.
10722         (packet_check_result): New overload.
10723         Update all uses.
10724
10725 2019-01-14  Tom Tromey  <tom@tromey.com>
10726
10727         * remote-notif.c (handle_notification, remote_notif_ack)
10728         (remote_notif_parse): Make "buf" const.
10729         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10730         const.
10731         (remote_notif_parse, remote_notif_ack, handle_notification):
10732         Likewise.
10733         * remote.c (remote_notif_stop_parse): Make "buf" const.
10734         (remote_target::remote_parse_stop_reply): Make "buf" const.
10735         (remote_notif_stop_ack): Make "buf" const.
10736
10737 2019-01-14  Tom Tromey  <tom@tromey.com>
10738
10739         * remote.c (remote_console_output): Make parameter const.
10740
10741 2019-01-14  Tom Tromey  <tom@tromey.com>
10742
10743         * target-debug.h (target_debug_print_signals): Constify.
10744         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10745         * procfs.c (procfs_target::pass_signals): Update.
10746         * linux-nat.c (linux_nat_target::pass_signals): Update.
10747         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10748         * target-delegates.c: Rebuild.
10749         * remote.c (remote_target::program_signals): Update.
10750         (remote_target::pass_signals): Update.
10751         * target.c (target_pass_signals): Constify argument.
10752         (target_program_signals): Likewise.
10753         * target.h (struct target_ops) <pass_signals, program_signals>:
10754         Constify argument.
10755         (target_pass_signals, target_program_signals): Constify argument.
10756
10757 2019-01-14  Tom Tromey  <tom@tromey.com>
10758
10759         PR tui/28819:
10760         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10761
10762 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10763
10764         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10765         field.
10766         * rs6000-tdep.c: Include reggroups.h.
10767         (IS_V_ALIAS_PSEUDOREG): Define.
10768         (rs6000_register_name): Return names for the "vX" aliases.
10769         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10770         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10771         aliases.  Call default_register_reggroup_p for all other
10772         pseudo-registers.
10773         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10774         New functions.
10775         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10776         Handle "vX" aliases.
10777         (v_alias_pseudo_register_collect): New function.
10778         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10779         (rs6000_gdbarch_init): Initialize "vX" aliases as
10780         pseudo-registers.  Restore registration of
10781         rs6000_pseudo_register_reggroup_p with
10782         set_tdesc_pseudo_register_reggroup_p.
10783
10784 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10785
10786         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10787         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10788         set_gdbarch_num_pseudo_regs.
10789
10790 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10791
10792         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10793         Remove arg prefixname, add do_set and do_show.
10794         Add member functions set_list and show_list.
10795         * cli/cli-style.c (class cli_style_option): Update accordingly.
10796         (style_set_list): Move to file scope.
10797         (style_show_list): Likewise.
10798         (set_style): Call help_list.
10799         (show_style): Call cmd_show_list.
10800         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10801         Update to use the new macro.
10802
10803 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10804
10805         * ada-lang.c (_initialize_ada_language): Expand the help text
10806         for the "catch exception" command.
10807
10808 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10809
10810         * symtab.c (matching_obj_sections): Initialize obj,
10811         declare it closer to its usage.
10812
10813 2019-01-10  Tom Tromey  <tom@tromey.com>
10814
10815         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10816         (basic_inf_threads_range): Remove.
10817         (inf_threads_range, inf_non_exited_threads_range)
10818         (safe_inf_threads_range): Use next_adapter.
10819
10820 2019-01-10  Keith Seitz  <keiths@redhat.com>
10821
10822         PR gdb/23712
10823         PR symtab/23010
10824         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10825         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10826
10827 2019-01-10  Keith Seitz  <keiths@redhat.com>
10828
10829         PR gdb/23712
10830         PR symtab/23010
10831         * dictionary.c (pending_to_vector): Remove.
10832         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10833         Remove _1 suffix, replacing functions of the same name.  Update
10834         all callers.
10835         (dict_create_hashed, dict_create_hashed_expandable)
10836         (dict_create_linear, dict_create_linear_expandable, dict_free)
10837         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10838         Make functions static.
10839
10840 2019-01-10  Keith Seitz  <keiths@redhat.com>
10841
10842         PR gdb/23712
10843         PR symtab/23010
10844         * dictionary.h (struct dictionary): Replace declaration with
10845         multidictionary.
10846         (dict_create_hashed, dict_create_hashed_expandable)
10847         (dict_create_linear, dict_create_linear_expandable)
10848         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10849         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10850         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10851         taking multidictionary argument.
10852         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10853         * block.h (struct block) <dict>: Change to multidictionary
10854         and rename `multidict'.
10855         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10856         symmisc.c: Update all dictionary references to multidictionary.
10857
10858 2019-01-10  Keith Seitz  <keiths@redhat.com>
10859
10860         PR gdb/23712
10861         PR symtab/23010
10862         * dictionary.c: Include unordered_map.
10863         (pending_to_vector): New function.
10864         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10865         Rewrite the non-"_1" functions to take vector instead
10866         of linked list.
10867         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10868         "new" _1 versions of the same name.
10869         (multidictionary): Define.
10870         (std::hash<enum language): New definition.
10871         (collate_pending_symbols_by_language, mdict_create_hashed)
10872         (mdict_create_hashed_expandable, mdict_create_linear)
10873         (mdict_create_linear_expandable, mdict_free)
10874         (find_language_dictionary, create_new_language_dictionary)
10875         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10876         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10877         (mdict_size, mdict_empty): New functions.
10878         * dictionary.h (mdict_iterator): Define.
10879
10880 2019-01-10  Pedro Alves  <palves@redhat.com>
10881
10882         * breakpoint.c (read_uploaded_action)
10883         (create_tracepoint_from_upload): Adjust to use
10884         gdb::unique_xmalloc_ptr.
10885         * ctf.c (ctf_write_uploaded_tp):
10886         (SET_ARRAY_FIELD): Use emplace_back.
10887         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10888         * tracefile-tfile.c (tfile_write_uploaded_tp):
10889         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10890         gdb::unique_xmalloc_ptr.
10891         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10892         at_string, cond_string, cmd_strings>: Replace char pointers
10893         with gdb::unique_xmalloc_ptr.
10894
10895 2019-01-10  Pedro Alves  <palves@redhat.com>
10896
10897         * solib-target.c (library_list_start_library): Don't xstrdup name.
10898
10899 2019-01-10  Pedro Alves  <palves@redhat.com>
10900
10901         * mdebugread.c (parse_partial_symbols): Use
10902         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10903
10904 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10905
10906         * linux-fork.c (scoped_switch_fork_info)
10907         <~scoped_switch_fork_info>: Fix incorrect variable name.
10908
10909 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10910
10911         * linux-fork.c (scoped_switch_fork_info)
10912         <scoped_switch_fork_info>: Make explicit.
10913         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10914
10915 2019-01-10  Tom Tromey  <tom@tromey.com>
10916
10917         * objfiles.h (objfile::reset_psymtabs): Update.
10918         * objfiles.c (objfile::objfile): Update.
10919         * psymtab.h (psymtab_storage::obstack): Update.
10920         (psymtab_storage::m_obstack): Use gdb::optional.
10921         (class psymtab_storage): Update comment.  Remove objfile
10922         parameter.
10923         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10924
10925 2019-01-10  Tom Tromey  <tom@tromey.com>
10926
10927         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10928         <free_psymtabs>: Now private.
10929         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10930         (allocate_psymtab): Use new method.
10931
10932 2019-01-10  Tom Tromey  <tom@tromey.com>
10933
10934         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10935         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10936         * mdebugread.c (parse_partial_symbols): Use
10937         allocate_dependencies.
10938         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10939         allocate_dependencies.
10940         (process_psymtab_comp_unit_reader)
10941         (build_type_psymtab_dependencies): Likewise.
10942         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10943
10944 2019-01-10  Tom Tromey  <tom@tromey.com>
10945
10946         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10947         PSYMBOL_SET_LANGUAGE.
10948         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10949
10950 2019-01-10  Tom Tromey  <tom@tromey.com>
10951
10952         * psymtab.h (psymtab_storage::obstack): New method.
10953         <m_obstack>: Rename from obstack; now private.
10954         * psymtab.c (psymtab_storage): Update.
10955         * dwarf2read.c (create_addrmap_from_index)
10956         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10957         Update.
10958
10959 2019-01-10  Tom Tromey  <tom@tromey.com>
10960
10961         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10962         * objfiles.h (objfile::reset_psymtabs): New method.
10963
10964 2019-01-10  Tom Tromey  <tom@tromey.com>
10965
10966         * symmisc.c (print_symbol_bcache_statistics): Update.
10967         (print_objfile_statistics): Update.
10968         * symfile.c (reread_symbols): Update.
10969         * psymtab.h (class psymtab_storage): New.
10970         * psymtab.c (psymtab_storage): New constructor.
10971         (~psymtab_storage): New destructor.
10972         (require_partial_symbols): Update.
10973         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10974         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10975         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10976         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10977         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10978         (start_psymtab_common, end_psymtab_common)
10979         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10980         (allocate_psymtab): Update.
10981         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10982         Update.
10983         (dump_psymtab_addrmap, maintenance_print_psymbols)
10984         (maintenance_check_psymtabs): Update.
10985         (class objfile_psymtabs): Move to objfiles.h.
10986         * psympriv.h (discard_psymtab): Now inline.
10987         (psymtab_discarder::psymtab_discarder): Update.
10988         (psymtab_discarder::~psymtab_discarder): Update.
10989         (ALL_OBJFILE_PSYMTABS): Rewrite.
10990         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10991         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10992         Remove fields.
10993         <partial_symtabs>: New field.
10994         (class objfile_psymtabs): Move from psymtab.h.  Update.
10995         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10996         psymbol_cache.
10997         (objfile::~objfile): Don't destroy psymbol_cache.
10998         * mdebugread.c (parse_partial_symbols): Update.
10999         * dwarf2read.c (create_addrmap_from_index)
11000         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11001         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11002         (add_partial_subprogram, dwarf2_ranges_read): Update.
11003         * dwarf-index-write.c (write_address_map)
11004         (write_one_signatured_type, recursively_write_psymbols)
11005         (class debug_names, class debug_names, write_psymtabs_to_index):
11006         Update.
11007
11008 2019-01-10  Tom Tromey  <tom@tromey.com>
11009
11010         * symtab.h (SYMBOL_SET_NAMES): Update.
11011         (symbol_set_names): Update.
11012         (MSYMBOL_SET_NAMES): Update.
11013         * symtab.c (symbol_set_names): Change argument to be an
11014         objfile_per_bfd_storage.
11015         * psymtab.c (add_psymbol_to_bcache): Update.
11016         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11017
11018 2019-01-10  Tom Tromey  <tom@tromey.com>
11019
11020         * symtab.c (create_demangled_names_hash): Change argument to be an
11021         objfile_per_bfd_storage.
11022         (symbol_set_names): Update.
11023
11024 2019-01-10  Tom Tromey  <tom@tromey.com>
11025
11026         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11027         init_psymbol_list.
11028         * psymtab.c (init_psymbol_list): Do nothing if already called.
11029         * psympriv.h (init_psymbol_list): Add comment.
11030         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11031         init_psymbol_list.
11032         * dbxread.c (dbx_symfile_read): Unconditionally call
11033         init_psymbol_list.
11034
11035 2019-01-10  Tom Tromey  <tom@tromey.com>
11036
11037         * xcoffread.c (scan_xcoff_symtab): Update.
11038         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11039         "where".
11040         * mdebugread.c (parse_partial_symbols)
11041         (handle_psymbol_enumerators): Update.
11042         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11043         * dbxread.c (read_dbx_symtab): Update.
11044         * psympriv.h (psymbol_placement): New enum.
11045         (add_psymbol_to_list): Update.
11046
11047 2019-01-10  Tom Tromey  <tom@tromey.com>
11048
11049         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11050         static_psymbols parameters.
11051         (scan_xcoff_symtab): Update.
11052         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11053         static_psymbols parameters.
11054         * psympriv.h (start_psymtab_common): Update.
11055         * mdebugread.c (parse_partial_symbols): Update.
11056         * dwarf2read.c (create_partial_symtab): Update.
11057         * dbxread.c (read_dbx_symtab): Update.
11058         (start_psymtab): Remove global_psymbols and static_psymbols
11059         parameters.
11060
11061 2019-01-10  Tom Tromey  <tom@tromey.com>
11062
11063         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11064         * psymtab.c (allocate_psymtab): Add comment.
11065         * psympriv.h (allocate_psymtab): Add comment.
11066         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11067         initializations.
11068         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11069
11070 2019-01-10  Tom Tromey  <tom@tromey.com>
11071
11072         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11073         Don't declare.
11074         * mipsread.c: Include mdebugread.h.
11075         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11076         Declare.
11077         * elfread.c: Include mdebugread.h.
11078
11079 2019-01-09  Tom Tromey  <tom@tromey.com>
11080
11081         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11082         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11083         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11084         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11085         (psym_lookup_symbol, psym_find_last_source_symtab)
11086         (psym_forget_cached_source_info, psym_print_stats)
11087         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11088         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11089         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11090         (psym_find_compunit_symtab_by_address)
11091         (maintenance_print_psymbols, maintenance_info_psymtabs)
11092         (maintenance_check_psymtabs): Use ranged for.
11093         * psymtab.h (class objfile_psymtabs): New.
11094         (require_partial_symbols): Return objfile_psymtabs.
11095         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11096
11097 2019-01-09  Tom Tromey  <tom@tromey.com>
11098
11099         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11100         (find_pc_mapped_section, list_overlays_command)
11101         (map_overlay_command, unmap_overlay_command)
11102         (simple_overlay_update): Use all_objfiles.
11103         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11104         * printcmd.c (info_symbol_command): Use all_objfiles.
11105         * objfiles.h (ALL_OBJSECTIONS): Remove.
11106         * maint.c (maintenance_translate_address): Use all_objfiles.
11107         * gcore.c (gcore_create_callback): Use all_objfiles.
11108         (objfile_find_memory_regions): Likewise.
11109
11110 2019-01-09  Tom Tromey  <tom@tromey.com>
11111
11112         * symtab.c (find_line_symtab, info_sources_command)
11113         (make_source_files_completion_list): Use objfile_compunits.
11114         * source.c (select_source_symtab): Use objfile_compunits.
11115         * objfiles.h (struct objfile): Update comment.
11116         (ALL_OBJFILES): Remove.
11117         (ALL_FILETABS): Remove.
11118         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11119         objfile_compunits.
11120
11121 2019-01-09  Tom Tromey  <tom@tromey.com>
11122
11123         * symmisc.c (print_objfile_statistics, dump_objfile)
11124         (maintenance_print_symbols): Use compunit_filetabs.
11125         * source.c (forget_cached_source_info_for_objfile): Use
11126         compunit_filetabs.
11127         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11128         (ALL_FILETABS): Use compunit_filetabs.
11129         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11130         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11131
11132 2019-01-09  Tom Tromey  <tom@tromey.com>
11133
11134         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11135         (compunit_filetabs): New.
11136         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11137         compunit_filetabs.
11138         (info_sources_command, make_source_files_completion_list): Remove
11139         declaration.
11140         * symmisc.c (print_objfile_statistics, dump_objfile)
11141         (maintenance_print_symbols): Remove declaration.
11142         (maintenance_info_symtabs): Use compunit_filetabs.
11143         (maintenance_info_line_tables): Likewise.
11144         * source.c (select_source_symtab): Change local variable name.
11145         (forget_cached_source_info_for_objfile): Remove declaration.
11146         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11147         * objfiles.c (objfile_relocate1): Remove declaration.
11148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11149         declaration.
11150         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11151         * coffread.c (coff_symtab_read): Remove declaration.
11152         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11153         compunit_filetabs.
11154
11155 2019-01-09  Tom Tromey  <tom@tromey.com>
11156
11157         * symtab.c (lookup_objfile_from_block)
11158         (find_pc_sect_compunit_symtab, search_symbols)
11159         (default_collect_symbol_completion_matches_break_on): Use
11160         objfile_compunits.
11161         * objfiles.h (ALL_COMPUNITS): Remove.
11162         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11163         * cp-support.c (add_symbol_overload_list_qualified): Use
11164         objfile_compunits.
11165         * ada-lang.c (ada_collect_symbol_completion_matches)
11166         (ada_add_global_exceptions): Use objfile_compunits.
11167
11168 2019-01-09  Tom Tromey  <tom@tromey.com>
11169
11170         * source.c (select_source_symtab)
11171         (forget_cached_source_info_for_objfile): Remove declaration.
11172         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11173         declaration.
11174         * maint.c (count_symtabs_and_blocks): Remove declaration.
11175         * cp-support.c (add_symbol_overload_list_qualified): Remove
11176         declaration.
11177         * coffread.c (coff_symtab_read): Remove declaration.
11178         * symtab.c (lookup_symbol_in_objfile_symtabs)
11179         (basic_lookup_transparent_type_1): Use objfile_compunits.
11180         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11181         (info_sources_command, search_symbols)
11182         (default_collect_symbol_completion_matches_break_on)
11183         (make_source_files_completion_list): Remove declaration.
11184         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11185         (ada_collect_symbol_completion_matches)
11186         (ada_add_global_exceptions): Remove declaration.
11187         * linespec.c (iterate_over_all_matching_symtabs): Use
11188         objfile_compunits.
11189         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11190         (class objfile_compunits): New.
11191         (ALL_COMPUNITS): Use objfile_compunits.
11192         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11193         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11194         objfile_compunits.
11195         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11196
11197 2019-01-09  Tom Tromey  <tom@tromey.com>
11198
11199         * symtab.c (search_symbols)
11200         (default_collect_symbol_completion_matches_break_on): Use
11201         objfile_msymbols.
11202         * ada-lang.c (ada_lookup_simple_minsym)
11203         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11204         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11205         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11206         objfile_msymbols.
11207         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11208         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11209         * objc-lang.c (find_methods): Use objfile_msymbols.
11210         (info_selectors_command, info_classes_command): Likewise.
11211         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11212         * objfiles.h (class objfile_msymbols): New.
11213         (ALL_OBJFILE_MSYMBOLS): Remove.
11214         (ALL_MSYMBOLS): Remove.
11215
11216 2019-01-09  Tom Tromey  <tom@tromey.com>
11217
11218         * common/next-iterator.h (next_adapter): Add Iterator template
11219         parameter.
11220         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11221         (class all_objfiles_safe): New.
11222         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11223         * objfiles.c (put_objfile_before): Update comment.
11224         (add_separate_debug_objfile): Likewise.
11225         (free_all_objfiles): Use all_objfiles_safe.
11226         (objfile_purge_solibs): Likewise.
11227
11228 2019-01-09  Tom Tromey  <tom@tromey.com>
11229
11230         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11231         (expand_symtab_containing_pc, lookup_static_symbol)
11232         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11233         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11234         all_objfiles.
11235         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11236         * breakpoint.c (create_overlay_event_breakpoint)
11237         (create_longjmp_master_breakpoint)
11238         (create_std_terminate_master_breakpoint)
11239         (create_exception_master_breakpoint): Use all_objfiles.
11240         * linux-thread-db.c (try_thread_db_load_from_pdir)
11241         (has_libpthread): Use all_objfiles.
11242         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11243         * linespec.c (iterate_over_all_matching_symtabs)
11244         (search_minsyms_for_name): Use all_objfiles.
11245         * maint.c (maintenance_info_sections): Use all_objfiles.
11246         * main.c (captured_main_1): Use all_objfiles.
11247         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11248         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11249         * guile/scm-pretty-print.c
11250         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11251         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11252         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11253         (maintenance_print_msymbols): Use all_objfiles.
11254         * source.c (select_source_symtab): Use all_objfiles.
11255         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11256         * symfile.c (remove_symbol_file_command)
11257         (expand_symtabs_matching, map_symbol_filenames): Use
11258         all_objfiles.
11259         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11260         all_objfiles.
11261         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11262         * objc-lang.c (find_methods): Use all_objfiles.
11263         * objfiles.c (have_partial_symbols, have_full_symbols)
11264         (have_minimal_symbols, qsort_cmp)
11265         (default_iterate_over_objfiles_in_search_order): Use
11266         all_objfiles.
11267         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11268         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11269         (maintenance_check_psymtabs): Use all_objfiles.
11270         (ALL_PSYMTABS): Remove.
11271         * compile/compile-object-run.c (do_module_cleanup): Use
11272         all_objfiles.
11273         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11274         * cp-support.c (add_symbol_overload_list_qualified): Use
11275         all_objfiles.
11276         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11277         Use all_objfiles.
11278         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11279         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11280         all_objfiles.
11281         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11282         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11283         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11284         Uses all_objfiles.
11285         * solib.c (solib_read_symbols): Use all_objfiles
11286
11287 2019-01-09  Tom Tromey  <tom@tromey.com>
11288
11289         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11290         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11291         all_objfiles.
11292         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11293         * symmisc.c (print_symbol_bcache_statistics)
11294         (print_objfile_statistics, maintenance_print_objfiles)
11295         (maintenance_info_symtabs, maintenance_check_symtabs)
11296         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11297         all_objfiles.
11298         * source.c (forget_cached_source_info): Use all_objfiles.
11299         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11300         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11301         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11302         * objfiles.c (update_section_map): Use all_objfiles.
11303         (shared_objfile_contains_address_p): Likewise.
11304         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11305         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11306
11307 2019-01-09  Tom Tromey  <tom@tromey.com>
11308
11309         * common/next-iterator.h: New file.
11310         * objfiles.h (class all_objfiles): New.
11311         (struct objfile_iterator): New.
11312
11313 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11314
11315         * NEWS: Move the description of the changed "frame", "select-frame",
11316          and "info frame" commands to the Changed commands section.
11317
11318 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11319
11320         * gdbtypes.c (check_stub_method_group): Remove handling of old
11321         mangling schemes.
11322         * linespec.c (find_methods): Likewise.
11323         * stabsread.c (read_member_functions): Likewise.
11324         * valops.c (search_struct_method): Likewise.
11325         (value_struct_elt_for_reference): Likewise.
11326         * NEWS: Mention this change.
11327
11328 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11329
11330         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11331         print_source_lines.
11332         * source.c (print_source_lines_base): Update line number check.
11333         (print_source_lines): New function.
11334         (source_lines_range::source_lines_range): New function.
11335         * source.h (class source_lines_range): New class.
11336         (print_source_lines): New declaration.
11337
11338 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11339
11340         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11341
11342 2019-01-08  Tom Tromey  <tom@tromey.com>
11343             Simon Marchi  <simon.marchi@ericsson.com>
11344
11345         PR gdb/24060
11346         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11347         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11348         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11349         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11350         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11351         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11352
11353 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11354
11355         * source.c (select_source_symtab): Move header comment to
11356         declaration in source.h.
11357         (forget_cached_source_info_for_objfile): Likewise.
11358         (forget_cached_source_info): Likewise.
11359         (identify_source_line): Likewise.
11360         * source.h (identify_source_line): Move declaration from symtab.h
11361         and add comment from source.c
11362         (print_source_lines): Likewise.
11363         (forget_cached_source_info_for_objfile): Likewise.
11364         (forget_cached_source_info): Likewise.
11365         (select_source_symtab): Likewise.
11366         (enum print_source_lines_flag): Move definition from symtab.h.
11367         * symtab.h (identify_source_line): Move declaration to source.h.
11368         (print_source_lines): Likewise.
11369         (forget_cached_source_info_for_objfile): Likewise.
11370         (forget_cached_source_info): Likewise.
11371         (select_source_symtab): Likewise.
11372         (enum print_source_lines_flag): Move definition to source.h.
11373         * tui/tui-hooks.c: Add 'source.h' include.
11374
11375 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11376
11377         * source.c (print_source_lines_base): Handle requests to print
11378         reverse line number sequences, and guard against empty lines
11379         string.
11380
11381 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11382
11383         * source.c (print_source_lines_base): Fix skip of '\r' if next
11384         character is '\n'.
11385
11386 2019-01-06  Tom Tromey  <tom@tromey.com>
11387
11388         * c-exp.y (struct c_parse_state) <macro_original_text,
11389         expansion_obstack>: New member.
11390         (macro_original_text, expansion_obstack): Remove globals.
11391         (scan_macro_expansion, scanning_macro_expansion)
11392         (finished_macro_expansion): Update.
11393         (scan_macro_cleanup): Remove.
11394         (yylex, c_parse): Update.
11395
11396 2019-01-06  Tom Tromey  <tom@tromey.com>
11397
11398         * c-exp.y (struct c_parse_state) <strings>: New member.
11399         (operator_stoken): Update.
11400
11401 2019-01-06  Tom Tromey  <tom@tromey.com>
11402
11403         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11404         (union type_stack_elt) <typelist_val>: Now a pointer to
11405         std::vector.
11406         (type_stack_cleanup): Don't declare.
11407         (push_typelist): Update.
11408         * parse.c (pop_typelist): Return a std::vector.
11409         (push_typelist): Take a std::vector.
11410         (follow_types): Update.  Do not free args.
11411         (type_stack_cleanup): Remove.
11412         * c-exp.y (struct c_parse_state): New.
11413         (cpstate): New global.
11414         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11415         (nonempty_typelist): Update.
11416         (func_mod): Create a new vector.
11417         (c_parse): Create a c_parse_state.
11418         (check_parameter_typelist): Do not delete params.
11419         (function_method): Update.  Do not delete type_list.
11420
11421 2019-01-06  Tom Tromey  <tom@tromey.com>
11422
11423         PR gdb/28155:
11424         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11425         check_typedef.
11426         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11427         (print_return_value): Likewise.
11428
11429 2019-01-05  Tom Tromey  <tom@tromey.com>
11430
11431         * contrib/cleanup_check.py: Remove.
11432         * contrib/gcc-with-excheck: Remove.
11433         * contrib/exsummary.py: Remove.
11434         * contrib/excheck.py: Remove.
11435
11436 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11437
11438         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11439         NULL. Initialize tpprev to NULL instead of assigning it
11440         to NULL on the next statement.
11441         * windows-nat.c (windows_delete_thread): Remove check for
11442         main_thread_id before printing thread exit notifications.
11443         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11444         Remove thread ID check against main_thread_id.
11445         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11446         windows_delete_thread.
11447         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11448
11449 2019-01-04  Tom Tromey  <tom@tromey.com>
11450
11451         * compile/compile.c (_initialize_compile): Use upper case for
11452         metasyntactic variables.
11453         * symmisc.c (_initialize_symmisc): Use upper case for
11454         metasyntactic variables.
11455         * psymtab.c (_initialize_psymtab): Use upper case for
11456         metasyntactic variables.
11457         * demangle.c (demangle_command): Use upper case for metasyntactic
11458         variables.
11459         (_initialize_demangler): Likewise.
11460         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11461         variables.
11462
11463 2019-01-03  Tom Tromey  <tom@tromey.com>
11464
11465         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11466
11467 2019-01-03  Tom Tromey  <tom@tromey.com>
11468
11469         * python/py-symtab.c (salpy_str): Update.
11470         (struct salpy_sal_object) <symtab>: Now a PyObject.
11471         (salpy_dealloc): Update.
11472         (del_objfile_sal): Use gdbpy_ref.
11473
11474 2019-01-03  Tom Tromey  <tom@tromey.com>
11475
11476         * python/py-type.c (convert_field): Use new_reference.  Return
11477         gdbpy_ref.
11478         (make_fielditem): Return gdbpy_ref.
11479         (typy_fields): Update.
11480         (typy_getitem): Update.
11481         (field_name): Return gdbpy_ref.  Use new_reference.
11482         (typy_iterator_iternext): Update.
11483
11484 2019-01-03  Tom Tromey  <tom@tromey.com>
11485
11486         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11487
11488 2019-01-03  Tom Tromey  <tom@tromey.com>
11489
11490         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11491         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11492         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11493         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11494         (pspy_set_type_printers): Likewise.
11495         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11496         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11497         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11498         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11499         (objfpy_set_type_printers): Likewise.
11500
11501 2019-01-03  Tom Tromey  <tom@tromey.com>
11502
11503         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11504         (gdbpy_print_stack): Use gdbpy_err_fetch.
11505         * python/python-internal.h (class gdbpy_err_fetch): New class.
11506         (class gdbpy_enter) <m_error_type, m_error_value,
11507         m_error_traceback>: Remove.
11508         <m_error>: New member.
11509         (gdbpy_exception_to_string): Don't declare.
11510         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11511         * python/py-value.c (convert_value_from_python): Use
11512         gdbpy_err_fetch.
11513         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11514         gdbpy_exception_to_string.
11515         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11516         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11517         gdbpy_err_fetch.
11518
11519 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11520
11521         * linux-nat.c (delete_lwp_cleanup): Delete.
11522         (struct lwp_deleter): New struct.
11523         (lwp_info_up): New typedef.
11524         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11525         lwp_info_up.
11526
11527 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11528
11529         * linux-fork.c (class scoped_switch_fork_info): New class.
11530         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11531
11532 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11533
11534         * valops.c (find_overload_match): Remove use of null_cleanup, and
11535         calls to do_cleanups.
11536
11537 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11538
11539         * compile/compile-cplus-types.c
11540         (compile_cplus_instance::decl_name): Handle changes to
11541         cp_func_name.
11542         * cp-support.c (cp_func_name): Update header comment, update
11543         return type.
11544         * cp-support.h (cp_func_name): Update return type in declaration.
11545         * valops.c (find_overload_match): Move temp_func local to top
11546         level of function and change its type.  Use temp_func to hold and
11547         delete temporary string obtained from cp_func_name.
11548
11549 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11550
11551         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11552         gdb::char_vector, remove cleanup, and update uses of `msg`.
11553
11554 2019-01-03  Jim Wilson  <jimw@sifive.com>
11555
11556         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11557
11558 2019-01-02  Tom Tromey  <tom@tromey.com>
11559
11560         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11561         (tdesc_parse_xml): Remove cleanups.
11562         * target-descriptions.h (make_cleanup_free_target_description):
11563         Don't declare.
11564         (target_desc_deleter): New struct.
11565         (target_desc_up): New typedef.
11566         * target-descriptions.c (target_desc_deleter::operator()): Rename
11567         from free_target_description.
11568         (make_cleanup_free_target_description): Remove.
11569
11570 2019-01-02  Tom Tromey  <tom@tromey.com>
11571
11572         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11573         constructor, destructor.
11574         (linespec_parser): Remove typedef.
11575         (~linespec_parser): Rename from linespec_parser_delete.
11576         (linespec_lex_to_end, linespec_complete_label)
11577         (linespec_complete): Update.
11578         (decode_line_full): Remove cleanups.
11579         (decode_line_1): Update.
11580
11581 2019-01-02  Tom Tromey  <tom@tromey.com>
11582
11583         * python/python-internal.h (inferior_to_inferior_object): Change
11584         return type.
11585         * python/py-exitedevent.c (create_exited_event_object): Update.
11586         * python/py-inferior.c (inferior_to_inferior_object): Return
11587         gdbpy_ref.
11588         (python_new_inferior, python_inferior_deleted)
11589         (thread_to_thread_object, delete_thread_object)
11590         (build_inferior_list, gdbpy_selected_inferior): Update.
11591         * python/py-infthread.c (create_thread_object): Update.  Also fail
11592         if inferior_to_inferior_object fails.
11593
11594 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11595
11596         * inferior.h (class inferior) <displaced_step_state>: New field.
11597         * infrun.h (struct displaced_step_state): Move here from
11598         infrun.c.  Initialize fields, add constructor.
11599         <inf>: Remove field.
11600         <reset>: New method.
11601         * infrun.c (struct displaced_step_inferior_state): Move to
11602         infrun.h.
11603         (displaced_step_inferior_states): Remove.
11604         (get_displaced_stepping_state): Adust.
11605         (displaced_step_in_progress_any_inferior): Adjust.
11606         (displaced_step_in_progress_thread): Adjust.
11607         (displaced_step_in_progress): Adjust.
11608         (add_displaced_stepping_state): Remove.
11609         (get_displaced_step_closure_by_addr): Adjust.
11610         (remove_displaced_stepping_state): Remove.
11611         (infrun_inferior_exit): Call displaced_step_state.reset.
11612         (use_displaced_stepping): Don't check for NULL.
11613         (displaced_step_prepare_throw): Call
11614         get_displaced_stepping_state.
11615         (displaced_step_fixup): Don't check for NULL.
11616         (prepare_for_detach): Don't check for NULL.
11617
11618 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11619
11620         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11621          in case of call that did not complete.
11622
11623 2019-01-02  Andrey Utkin  <autkin@undo.io>
11624
11625         * symfile.c (find_separate_debug_file): Fix search of debug files for
11626         remote debuggee.
11627
11628 2019-01-02  Tom Tromey  <tom@tromey.com>
11629
11630         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11631         indentation.
11632         * python/py-frame.c (frapy_older): Remove cast.
11633         (frapy_newer): Likewise.
11634         * python/py-breakpoint.c (local_setattro): Remove cast.
11635         * python/py-arch.c (archpy_name): Remove local variable.
11636         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11637
11638 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11639
11640         * unittests/basic_string_view/element_access/char/empty.cc:
11641         Fix year range in copyright header.
11642
11643 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11644
11645         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11646         Delete.
11647         <operator==>: Update with for removed field.
11648         <hash>: Likewise.
11649         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11650         <isa_features>: ...this.
11651         <abi_features>: New field.
11652         (riscv_isa_flen): Update comment.
11653         (riscv_abi_xlen): New declaration.
11654         (riscv_abi_flen): New declaration.
11655         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11656         isa_features.
11657         (riscv_abi_xlen): New function.
11658         (riscv_isa_flen): Update to get answer from isa_features.
11659         (riscv_abi_flen): New function.
11660         (riscv_has_fp_abi): Update to get answer from abi_features.
11661         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11662         xlen and flen.
11663         (riscv_call_info) <xlen, flen>: Update comment.
11664         (riscv_call_arg_struct): Remove invalid assertions
11665         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11666         is removed.
11667         (riscv_gdbarch_init): Gather isa features and abi features
11668         separately, ensure both match on the gdbarch when reusing an old
11669         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11670         a target with 64-bit float hardware.
11671
11672 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11673
11674         * source.c (search_command_helper): Stop reverse search
11675         when line 1 has been searched.
11676
11677 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11678
11679         * record-full.c (record_full_base_target::close): Rewrite
11680         record_full_core_buf_list free logic.
11681
11682 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11683
11684         * break-catch-syscall.c (print_one_catch_syscall): xfree
11685         the last text.
11686
11687 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11688
11689         * top.c (print_gdb_version): Update Copyright year in version
11690         message.
11691
11692 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11693
11694         Update copyright year range in all GDB files.
11695
11696 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11697
11698         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11699
11700 For older changes see ChangeLog-2018.
11701 \f
11702 Local Variables:
11703 mode: change-log
11704 left-margin: 8
11705 fill-column: 74
11706 version-control: never
11707 coding: utf-8
11708 End:
11709