gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.c (tui_data_item_window): Update.
   4         * tui/tui-windata.h (tui_check_data_values): Don't declare.
   5         * tui/tui-windata.c (tui_display_all_data)
   6         (tui_display_data_from_line): Update.
   7         (tui_check_data_values): Remove.
   8         * tui/tui-regs.c (tui_show_register_group)
   9         (tui_display_reg_element_at_line): Update.
  10         * tui/tui-hooks.c (tui_register_changed)
  11         (tui_refresh_frame_and_register_information): Call
  12         tui_check_register_values.
  13         * tui/tui-data.h (struct tui_data_window) <data_content,
  14         data_content_count, data_type>: Remove.
  15         (enum tui_data_type): Remove.
  16
  17         * tui/tui-data.c (tui_data_window::clear_detail)
  18         (~tui_data_window): Update.
  19
  20 2019-06-25  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
  23         declare.
  24         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
  25         Rename from tui_first_data_item_displayed.  Update.
  26         (tui_data_window::refresh_all)
  27         (tui_data_window::do_scroll_vertical): Update.
  28         * tui/tui-data.h (struct tui_data_window)
  29         <first_data_item_displayed>: Declare new method.
  30
  31 2019-06-25  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-data.h (tui_init_generic_part): Don't declare.
  34         * tui/tui-data.c (tui_init_generic_part): Remove, moving
  35         contents...
  36         (tui_initialize_static_data): ...here.
  37
  38 2019-06-25  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
  41         (tui_display_registers_from, tui_check_register_values): Update.
  42         (tui_display_register): Remove win_info parameter; update.
  43         (tui_get_register): Change type of parameters.
  44         * tui/tui-data.h (struct tui_data_element): Remove.
  45         (union tui_which_element) <data>: Remove.
  46         <data_window>: Change type.
  47         (struct tui_data_item_window): New.
  48         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
  49         case.  Add assert.
  50         (~tui_data_item_window): New destructor.
  51         (free_content_elements): Remove DATA_ITEM_WIN case.
  52
  53 2019-06-25  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
  56         Remove.
  57
  58 2019-06-25  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-data.h (struct tui_command_element): Remove.
  61         (union tui_which_element) <command>: Remove.
  62         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
  63         assert.
  64         (free_content_elements): Remove CMD_WIN case.
  65
  66 2019-06-25  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-layout.c (tui_set_layout): Update.
  69         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
  70         * tui/tui-data.c (layout_def): Update.
  71
  72 2019-06-25  Tom Tromey  <tom@tromey.com>
  73
  74         * tui/tui-wingeneral.c (tui_refresh_all): Update.
  75         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  76         (tui_source_window_base::set_new_height): Update.
  77         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
  78         Update.
  79         (tui_set_locator_fullname, tui_set_locator_info)
  80         (tui_show_frame_info): Update.
  81         * tui/tui-source.c (tui_set_source_content)
  82         (tui_source_is_displayed): Update.
  83         * tui/tui-layout.c (show_source_disasm_command, show_data)
  84         (show_source_or_disasm_and_command): Update.
  85         * tui/tui-disasm.c (tui_set_disassem_content)
  86         (tui_get_begin_asm_address): Update.
  87         * tui/tui-data.h (struct tui_locator_element): Remove.
  88         (union tui_which_element) <locator>: Remove.
  89         (struct tui_locator_window): New.
  90         (tui_locator_win_info_ptr): Change return type.
  91         * tui/tui-data.c (_locator): Change type.
  92         (tui_locator_win_info_ptr): Change return type.
  93         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
  94         (tui_alloc_content): Add assert.
  95
  96 2019-06-25  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-winsource.c
  99         (tui_exec_info_window::maybe_allocate_content): New method.
 100         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 101         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 102         (make_source_or_disasm_window): Add cast.
 103         * tui/tui-data.h (union tui_which_element) <simple_string>:
 104         Remove.
 105         (struct tui_source_info): New.
 106         (struct tui_source_window_base) <execution_info>: Change type.
 107         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 108         case, and add assert.
 109         (tui_alloc_content): Add assert.
 110
 111 2019-06-25  Tom Tromey  <tom@tromey.com>
 112
 113         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 114         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 115         * tui/tui-data.c (tui_alloc_win_info): Remove.
 116
 117 2019-06-25  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 120         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 121         can_highlight.
 122
 123 2019-06-25  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 126         make_visible_with_new_height method.
 127         (tui_win_info::make_visible_with_new_height): New method.
 128         (tui_source_window_base::do_make_visible_with_new_height)
 129         (tui_data_window::do_make_visible_with_new_height)
 130         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 131         (make_visible_with_new_height): Remove.
 132         (tui_resize_all, tui_adjust_win_heights): Use
 133         make_visible_with_new_height method.
 134         * tui/tui-data.h (struct tui_win_info)
 135         <do_make_visible_with_new_height, make_visible_with_new_height>:
 136         New methods.
 137         (struct tui_source_window_base, struct tui_data_window)
 138         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 139         methods.
 140
 141 2019-06-25  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 144         method.
 145         (update_tab_width): Call update_tab_width method.
 146         * tui/tui-data.h (struct tui_win_info)
 147         (struct tui_source_window_base) <update_tab_width>: New methods.
 148
 149 2019-06-25  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 152         parameter.
 153         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 154         parameter.
 155         (tui_gen_win_info::make_visible): Update.
 156         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 157         parameter.
 158         * tui/tui-data.h (enum tui_box): New enum.
 159         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 160
 161 2019-06-25  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 164         init_and_make_win for EXEC_INFO_WIN.
 165         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 166         longer inline.
 167         (struct tui_win_info) <~tui_win_info>: Inline.
 168         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 169         Don't declare.
 170         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 171         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 172         Remove.
 173         (tui_initialize_static_data): Update.
 174         (~tui_gen_win_info): Handle more cleanup here.
 175         (~tui_source_window_base): Delete "execution_info".
 176         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 177
 178 2019-06-25  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-layout.c (make_command_window): Don't set
 181         can_highlight.
 182         (show_source_disasm_command): Call the reset method.
 183         (show_data): Don't set can_highlight.  Call the reset method.
 184         (tui_gen_win_info::reset): Rename from init_gen_win_info
 185         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 186         (show_source_or_disasm_and_command): Call the reset method.
 187         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 188         (struct tui_cmd_window): Set can_highlight.
 189
 190 2019-06-25  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 193         from make_visible.
 194         (tui_make_visible, tui_make_invisible): Rewrite.
 195         (tui_win_info::make_visible): Remove.
 196         (tui_source_window_base::make_visible): Update.
 197         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 198         method.  Moved from...
 199         (struct tui_win_info) <make_visible>: ...here.
 200
 201 2019-06-25  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-winsource.c
 204         (tui_source_window_base::do_scroll_horizontal): Remove direction
 205         parameter.
 206         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 207         direction parameter.
 208         * tui/tui-win.c (tui_win_info::forward_scroll)
 209         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 210         (tui_win_info::right_scroll): Update.
 211         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 212         direction parameter.
 213         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 214         direction parameter.
 215         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 216         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 217         Remove direction parameter.
 218         (struct tui_source_window_base, struct tui_source_window)
 219         (struct tui_disasm_window, struct tui_data_window)
 220         (struct tui_cmd_window): Update.
 221
 222 2019-06-25  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-winsource.h (tui_set_exec_info_content)
 225         (tui_show_exec_info_content, tui_erase_exec_info_content)
 226         (tui_clear_exec_info_content, tui_update_exec_info): Change
 227         argument to tui_source_window_base.
 228         * tui/tui-winsource.c (tui_set_exec_info_content)
 229         (tui_show_exec_info_content, tui_erase_exec_info_content)
 230         (tui_clear_exec_info_content, tui_update_exec_info): Change
 231         argument to tui_source_window_base.
 232
 233 2019-06-25  Tom Tromey  <tom@tromey.com>
 234
 235         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 236         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 237
 238 2019-06-25  Tom Tromey  <tom@tromey.com>
 239
 240         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 241         check.
 242
 243 2019-06-25  Tom Tromey  <tom@tromey.com>
 244
 245         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 246         type to void.
 247         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 248         type to void.
 249         * tui/tui-source.c (tui_set_source_content): Update.
 250         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 251
 252 2019-06-25  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-win.c (window_name_completer, tui_set_focus)
 255         (tui_all_windows_info): Use name method.
 256         * tui/tui-data.h (struct tui_gen_win_info)
 257         (struct tui_source_window, struct tui_disasm_window)
 258         (struct tui_data_window, struct tui_cmd_window) <name>: New
 259         method.
 260         (tui_win_name): Don't declare.
 261         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 262         (tui_win_name): Remove.
 263
 264 2019-06-25  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-winsource.h (tui_update_source_window)
 267         (tui_update_source_window_as_is): Change parameter type.
 268         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 269         to be a tui_source_window_base.
 270         (tui_update_source_window_as_is): Likewise.
 271         * tui/tui-win.c (make_visible_with_new_height): Update.
 272
 273 2019-06-25  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui-winsource.c (tui_erase_source_content)
 276         (tui_show_source_content, tui_show_exec_info_content)
 277         (tui_erase_exec_info_content): Use refresh_window method.
 278         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 279         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 280         from tui_refresh_win.
 281         (tui_data_window::refresh_window): New method.
 282         (tui_win_info::refresh, tui_source_window_base::refresh)
 283         (tui_refresh_all): Use refresh_window method.
 284         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 285         method.
 286         * tui/tui-regs.c (tui_display_register): Call refresh_window
 287         method.
 288         * tui/tui-layout.c (show_source_disasm_command)
 289         (show_source_or_disasm_and_command): Call refresh_window method.
 290         * tui/tui-data.h (struct tui_gen_win_info)
 291         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 292         New method.
 293
 294 2019-06-25  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui.c (tui_rl_other_window, tui_enable)
 297         (tui_is_window_visible, tui_get_command_dimension): Update.
 298         * tui/tui-winsource.c (tui_update_source_window_as_is)
 299         (tui_clear_source_content, tui_erase_source_content)
 300         (tui_show_source_line, tui_source_window_base::refill)
 301         (tui_source_window_base::do_scroll_horizontal)
 302         (tui_source_window_base::set_is_exec_point_at)
 303         (tui_update_breakpoint_info, tui_set_exec_info_content)
 304         (tui_alloc_source_buffer, tui_line_is_displayed)
 305         (tui_addr_is_displayed): Update.
 306         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 307         (tui_check_and_display_highlight_if_needed)
 308         (tui_win_info::make_visible, tui_win_info::refresh)
 309         (tui_refresh_all): Update.
 310         * tui/tui-windata.c (tui_first_data_item_displayed)
 311         (tui_delete_data_content_windows, tui_erase_data_content)
 312         (tui_display_all_data, tui_data_window::refresh_all)
 313         (tui_check_data_values): Update.
 314         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 315         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 316         (tui_win_info::backward_scroll, tui_refresh_all_win)
 317         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 318         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 319         (tui_source_window_base::set_new_height)
 320         (tui_data_window::set_new_height)
 321         (make_invisible_and_set_new_height)
 322         (make_visible_with_new_height, new_height_ok)
 323         (parse_scrolling_args): Update.
 324         * tui/tui-stack.c (tui_show_frame_info): Update.
 325         * tui/tui-source.c (tui_set_source_content)
 326         (tui_set_source_content_nil, tui_source_is_displayed)
 327         (tui_source_window::do_scroll_vertical): Update.
 328         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 329         (tui_display_registers_from, tui_display_reg_element_at_line)
 330         (tui_check_register_values, tui_reg_command): Update.
 331         * tui/tui-layout.c (tui_default_win_height)
 332         (show_source_disasm_command, show_data, init_and_make_win)
 333         (show_source_or_disasm_and_command): Update.
 334         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 335         (tui_redisplay_readline, tui_mld_flush)
 336         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 337         (tui_getc): Update.
 338         * tui/tui-disasm.c (tui_set_disassem_content)
 339         (tui_disasm_window::do_scroll_vertical): Update.
 340         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 341         Now virtual.
 342         (struct tui_win_info): Derive from tui_gen_win_info.
 343         <~tui_win_info>: Mark as override.
 344         <generic>: Remove member.
 345         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 346         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 347         (~tui_data_window, ~tui_win_info)
 348         (tui_free_all_source_wins_content): Update.
 349         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 350
 351 2019-06-25  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui-layout.c (init_and_make_win): Use new.
 354         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 355         destructor, initializers.
 356         (tui_alloc_generic_win_info): Don't declare.
 357         * tui/tui-data.c (_locator): Add argument to constructor.
 358         (source_win, disasm_win): New globals.
 359         (exec_info): Remove.
 360         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 361         Update.
 362         (tui_alloc_generic_win_info): Remove.
 363         (init_content_element): Use new.
 364         (tui_win_info::tui_win_info): Update.
 365         (free_content_elements) <case DATA_WIN>: Use delete.
 366
 367 2019-06-25  Tom Tromey  <tom@tromey.com>
 368
 369         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 370         * tui/tui-windata.c (tui_first_data_item_displayed)
 371         (tui_delete_data_content_windows): Update.
 372         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 373         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 374         (tui_display_registers_from, tui_check_register_values): Update.
 375         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 376         pointer.
 377         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 378         window.
 379         (tui_free_data_content): Update.
 380         (free_content_elements) <case DATA_WIN>: Free the window.
 381
 382 2019-06-25  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 385         Update.
 386         * tui/tui-layout.c (make_command_window)
 387         (show_source_disasm_command, show_data, init_and_make_win)
 388         (show_source_or_disasm_and_command): Update.
 389         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 390         method.
 391         <can_highight, is_highlighted>: Now bool.
 392         (tui_set_win_highlight): Don't declare.
 393         * tui/tui-data.c (tui_set_win_highlight): Remove.
 394
 395 2019-06-25  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-wingeneral.c (make_visible): Remove check of window
 398         type.
 399
 400 2019-06-25  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-win.c (tui_win_info::max_height)
 403         (tui_cmd_window::max_height): New methods.
 404         (new_height_ok): Call max_height.
 405         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 406         <max_height>: New method.
 407
 408 2019-06-25  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-win.c (tui_source_window_base::set_new_height)
 411         (tui_data_window::set_new_height): New methods.
 412         (make_invisible_and_set_new_height): Call set_new_height method.
 413         * tui/tui-data.h (struct tui_win_info)
 414         (struct tui_source_window_base, struct tui_data_window)
 415         <set_new_height>: New method.
 416
 417 2019-06-25  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 420         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 421         tui_refresh_data_win.
 422         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 423         method.
 424         (tui_refresh_all_win): Call the refresh_all method.
 425         (tui_set_focus): Likewise.
 426         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 427         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 428         Likewise.
 429
 430 2019-06-25  Tom Tromey  <tom@tromey.com>
 431
 432         * tui/tui-winsource.h (tui_refill_source_window)
 433         (tui_set_is_exec_point_at): Don't declare.
 434         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 435         (tui_source_window_base::refill): Rename from
 436         tui_refill_source_window.
 437         (tui_source_window_base::do_scroll_horizontal): Update.
 438         (tui_source_window_base::set_is_exec_point_at): Rename from
 439         tui_set_is_exec_point_at.
 440         (tui_update_all_breakpoint_info): Update.
 441         * tui/tui-stack.c (tui_show_frame_info): Update.
 442         * tui/tui-layout.c (show_data): Add cast.
 443         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 444         * tui/tui-data.h (struct tui_source_window_base) <refill,
 445         set_is_exec_point_at>: New methods.
 446         (tui_source_windows, tui_add_to_source_windows): Update types.
 447         (tui_add_to_source_windows): Remove redundant declaration.
 448         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 449         (tui_source_windows): Change return type.
 450         (tui_clear_source_windows_detail): Update.
 451         (tui_add_to_source_windows): Change type of parameter.
 452         (tui_free_all_source_wins_content): Update.
 453
 454 2019-06-25  Tom Tromey  <tom@tromey.com>
 455
 456         * tui/tui-wingeneral.c (tui_win_info::refresh)
 457         (tui_source_window_base::refresh): New methods.
 458         (tui_refresh_all): Call the refresh method.
 459         * tui/tui-data.h (struct tui_win_info)
 460         (struct tui_source_window_base) <refresh>: New method.
 461
 462 2019-06-25  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui.h (tui_is_window_visible): Return bool.
 465         * tui/tui.c (tui_is_window_visible): Return bool.
 466         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 467         (tui_make_visible, tui_make_invisible)
 468         (tui_win_info::make_visible)
 469         (tui_source_window_base::make_visible, make_all_visible)
 470         (tui_make_all_visible, tui_make_all_invisible): Update.
 471         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 472         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 473         bool.
 474         (struct tui_win_info, struct tui_source_window_base)
 475         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 476         * tui/tui-data.c (tui_init_generic_part): Update.
 477
 478 2019-06-25  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 481         (tui_source_window_base::make_visible): New methods.
 482         (make_all_visible): Make method call.
 483         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 484         (struct tui_source_window_base, struct tui_cmd_window): Override
 485         make_visible.
 486         (tui_win_is_source_type): Don't declare.
 487         * tui/tui-data.c (tui_win_is_source_type): Remove.
 488
 489 2019-06-25  Tom Tromey  <tom@tromey.com>
 490
 491         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 492         NULL check.
 493
 494 2019-06-25  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 497         Inline constructor.  Add initializers for members.
 498         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 499         constructors; now inline in class.
 500
 501 2019-06-25  Tom Tromey  <tom@tromey.com>
 502
 503         * tui/tui-regs.c (tui_show_registers): Update.
 504         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 505         bool.
 506         * tui/tui-data.c (tui_data_window::clear_detail)
 507         (tui_data_window): Update.
 508
 509 2019-06-25  Tom Tromey  <tom@tromey.com>
 510
 511         * tui/tui-windata.c (tui_display_all_data)
 512         (tui_display_data_from_line, tui_display_data_from)
 513         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 514         Update.
 515         * tui/tui-regs.c (tui_last_regs_line_no)
 516         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 517         (tui_show_registers, tui_show_register_group)
 518         (tui_display_registers_from, tui_display_reg_element_at_line)
 519         (tui_display_registers_from_line, tui_check_register_values)
 520         (tui_reg_next, tui_reg_prev): Update.
 521         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 522         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 523         tui_data_window.
 524         (struct tui_win_info) <detail>: Remove.  Add new fields from
 525         tui_data_info.
 526         (TUI_DATA_WIN): Add cast.
 527         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 528         (~tui_data_window): Simplify.
 529
 530 2019-06-25  Tom Tromey  <tom@tromey.com>
 531
 532         * tui/tui-layout.c (show_source_disasm_command)
 533         (show_source_or_disasm_and_command): Update.
 534         * tui/tui-io.c (update_cmdwin_start_line)
 535         (tui_redisplay_readline): Update.
 536         * tui/tui-data.h (struct tui_command_info): Remove.
 537         (struct tui_win_info) <detail>: Remove command_info member.
 538         (struct tui_data_window) <start_line>: New member, from
 539         tui_command_info.
 540         (TUI_CMD_WIN): Add casts.
 541
 542 2019-06-25  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-winsource.c (tui_update_source_window)
 545         (tui_refill_source_window)
 546         (tui_source_window_base::do_scroll_horizontal)
 547         (tui_update_breakpoint_info, tui_set_exec_info_content)
 548         (tui_show_exec_info_content, tui_erase_exec_info_content)
 549         (tui_clear_exec_info_content): Update.
 550         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 551         Update.
 552         * tui/tui-win.c (make_invisible_and_set_new_height)
 553         (make_visible_with_new_height): Update.
 554         * tui/tui-source.c (tui_set_source_content)
 555         (tui_show_symtab_source): Update.
 556         * tui/tui-layout.c (extract_display_start_addr)
 557         (show_source_disasm_command, show_data)
 558         (make_source_or_disasm_window)
 559         (show_source_or_disasm_and_command): Update.
 560         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 561         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 562         "gdbarch".
 563         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 564         to tui_source_window_base.
 565         (struct tui_win_info) <detail>: Remove source_info member.
 566         (struct tui_source_window_base) <has_locator>: Inline.
 567         Move contents from tui_source_info; rename has_locator member to
 568         m_has_locator.
 569         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 570         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 571         header file.
 572         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 573         Simplify.
 574         (tui_free_all_source_wins_content): Cast to
 575         tui_source_window_base.
 576
 577 2019-06-25  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-win.c (make_invisible_and_set_new_height)
 580         (make_visible_with_new_height): Call has_locator method.
 581         * tui/tui-layout.c (show_source_disasm_command, show_data)
 582         (show_source_or_disasm_and_command): Update for bool change.
 583         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 584         (tui_win_info) <has_locator>: New method.
 585         (struct tui_source_window_base) <has_locator>: New method.
 586         (tui_win_has_locator): Don't declare.
 587         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 588         from tui_win_has_locator.
 589         (tui_source_window_base): Use false, not FALSE.
 590
 591 2019-06-25  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 594         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 595         clear_detail method directly.
 596         (tui_clear_win_detail): Remove.
 597
 598 2019-06-25  Tom Tromey  <tom@tromey.com>
 599
 600         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 601         "this", not TUI_DISASM_WIN.
 602
 603 2019-06-25  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 606         declare.
 607         * tui/tui-winsource.c
 608         (tui_source_window_base::do_scroll_horizontal): Rename from
 609         tui_horizontal_source_scroll.
 610         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 611         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 612         from tui_vertical_data_scroll.
 613         * tui/tui-win.h (tui_scroll): Don't declare.
 614         * tui/tui-win.c (tui_win_info::forward_scroll)
 615         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 616         (tui_win_info::right_scroll): Rename and update.
 617         (tui_scroll_forward_command, tui_scroll_backward_command)
 618         (tui_scroll_left_command, tui_scroll_right_command): Update.
 619         (tui_scroll): Remove.
 620         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 621         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 622         from tui_vertical_source_scroll.
 623         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 624         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 625         from tui_vertical_disassem_scroll.
 626         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 627         do_scroll_horizontal>: New methods.
 628         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 629         Likewise.
 630         (struct tui_source_window_base): Add do_scroll_horizontal.
 631         (struct tui_source_window, struct tui_disasm_window): Add
 632         do_scroll_vertical.
 633         (struct tui_data_window, struct tui_cmd_window): Add
 634         do_scroll_horizontal and do_scroll_vertical.
 635         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 636
 637 2019-06-25  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-data.h (struct tui_source_window_base): New struct.
 640         (struct tui_source_window): Derive from tui_source_window_base.
 641         (struct tui_disasm_window): New struct.
 642         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 643         from tui_source_window::clear_detail.
 644         (tui_source_window_base): Rename from tui_source_window.
 645         (~tui_source_window_base): Rename from ~tui_source_window.
 646         (tui_alloc_win_info): Create a tui_disasm_window.
 647
 648 2019-06-25  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-data.h (struct tui_source_window)
 651         (struct tui_data_window): Declare destructors.
 652         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 653         destructors.
 654         (tui_win_info): Simplify.
 655
 656 2019-06-25  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-winsource.c (tui_display_main)
 659         (tui_update_source_windows_with_addr)
 660         (tui_update_all_breakpoint_info): Update.
 661         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 662         (new_height_ok, parse_scrolling_args): Update.
 663         * tui/tui-stack.c (tui_show_frame_info): Update.
 664         * tui/tui-data.h (struct tui_list): Remove.
 665         (tui_source_windows): Return a reference to a std::vector.
 666         * tui/tui-data.c (source_windows): Now a std::vector.
 667         (tui_source_windows): Change return type.
 668         (tui_clear_source_windows): Rewrite.
 669         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 670         (tui_free_all_source_wins_content): Rewrite.
 671
 672 2019-06-25  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 675         (struct tui_data_window, struct tui_cmd_window): Declare
 676         clear_detail method.
 677         * tui/tui-data.c (tui_source_window::clear_detail)
 678         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 679         methods.
 680         (tui_clear_win_detail): Simplify.
 681
 682 2019-06-25  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-layout.c (make_source_window, make_disasm_window)
 685         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 686         Return the new window.
 687         (show_source_disasm_command, show_data)
 688         (show_source_or_disasm_and_command): Update.
 689
 690 2019-06-25  Tom Tromey  <tom@tromey.com>
 691
 692         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 693         parameter.  Return the new window.
 694         (show_source_disasm_command): Update and remove NULL check.
 695         (show_source_or_disasm_and_command): Update.
 696
 697 2019-06-25  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 700
 701 2019-06-25  Tom Tromey  <tom@tromey.com>
 702
 703         * tui/tui-data.h (struct tui_win_info): Make constructor
 704         protected.  Make destructor virtual.  Add initializers.
 705         (tui_source_window, tui_data_window, tui_cmd_window): New
 706         classes.
 707         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 708         constructor.  Add "type" parameter.
 709         (tui_source_window, tui_data_window, tui_cmd_window): New
 710         constructors.
 711         (tui_alloc_win_info): Instantiate the appropriate subclass.
 712
 713 2019-06-25  Tom Tromey  <tom@tromey.com>
 714
 715         * tui/tui-win.c (tui_resize_all): Use delete.
 716         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 717         destructor.
 718         (tui_free_window): Don't declare.
 719         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 720         Update.
 721
 722 2019-06-25  Tom Tromey  <tom@tromey.com>
 723
 724         * tui/tui-data.h (struct tui_win_info): Add constructor.
 725         * tui/tui-data.c (tui_alloc_win_info): Use new.
 726         (tui_free_window): Use delete.
 727
 728 2019-06-22  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 731         declare.
 732         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 733
 734 2019-06-22  Tom Tromey  <tom@tromey.com>
 735
 736         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 737         declare.
 738         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 739
 740 2019-06-22  Tom de Vries  <tdevries@suse.de>
 741
 742         * dwarf2read.c (create_addrmap_from_aranges)
 743         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 744         instead of '%zu'.
 745
 746 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 747
 748         * dwarf2read.h (dwarf2_section_info_def): Remove.
 749         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 750         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 751         std::vector<dwarf2_section_info>.
 752         (struct dwo_file) <~dwo_file>: Remove.
 753         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 754         types field.
 755         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 756         (dwarf2_read_debug_names): Likewise.
 757         (create_debug_types_hash_table): Change parameter type to
 758         array_view, adjust code accordingly.
 759         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 760         (partial_die_info::fixup): Likewise.
 761         (determine_prefix): Likewise.
 762         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 763
 764 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 765
 766         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 767         gdb_bfd_ref_ptr.
 768         <~dwo_file>: Remove call to gdb_bfd_unref.
 769         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 770         gdb_bfd_ref_ptr::get.
 771
 772 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 773
 774         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 775         type to htab_up.
 776         * dwarf2read.c (struct dwo_file): Initialize fields.
 777         <~dwo_file>: New.
 778         (free_dwo_file): Remove, move content to ~dwo_file.
 779         (struct dwo_file_deleter): Remove.
 780         (dwo_file_up>: Remove custom deleter.
 781         (free_dwo_files): Remove.
 782         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 783         dwo_files.
 784         (process_skeletonless_type_units): Call unique_ptr::get.
 785         (allocate_dwo_file_hash_table): Add deleter to created hash
 786         table.  Change return type to htab_up.
 787         (lookup_dwo_file_slot): Don't memset dwo_file, call
 788         unique_ptr::get.
 789         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 790         (create_dwo_unit_in_dwp_v2): Likewise.
 791         (open_and_init_dwo_file): Likewise.
 792         (free_dwo_file_from_slot): Remove.
 793
 794 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 795
 796         * dwarf2read.h (struct dwarf2_section_info) <readin,
 797         is_virtual>: Change type to bool.
 798         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 799         true instead of 1.
 800
 801 2019-06-19  Tom Tromey  <tom@tromey.com>
 802
 803         * tui/tui-data.h (tui_init_content_element): Don't declare.
 804
 805 2019-06-19  Tom Tromey  <tom@tromey.com>
 806
 807         * tui/tui-data.h (tui_init_win_info): Don't declare.
 808
 809 2019-06-19  Tom de Vries  <tdevries@suse.de>
 810
 811         * dwarf2read.h (abstract_to_concrete): Change type to
 812         std::unordered_map<sect_offset, std::vector<sect_offset>,
 813         gdb::hash_enum<sect_offset>>.
 814
 815 2019-06-19  Tom Tromey  <tromey@adacore.com>
 816
 817         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 818         EVAL_AVOID_SIDE_EFFECTS specially.
 819
 820 2019-06-19  Tom Tromey  <tromey@adacore.com>
 821
 822         * source-cache.c (highlighter): New global.
 823         (source_cache::get_source_lines): Create a highlighter on demand.
 824
 825 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 826
 827         * defs.h (deprecated_interactive_hook): Delete declaration.
 828         * interps.c (clear_interpreter_hooks): Remove use of
 829         deprecated_interactive_hook.
 830         * top.c (deprecated_interactive_hook): Delete definition.
 831         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 832
 833 2019-06-18  Tom de Vries  <tdevries@suse.de>
 834
 835         PR gdb/24515
 836         * dwarf2read.h (abstract_to_concrete): Change type from
 837         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 838         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 839         * dwarf2read.c (read_variable): Update.
 840         (dwarf2_fetch_die_loc_sect_off): Update.
 841
 842 2019-06-17  Tom de Vries  <tdevries@suse.de>
 843
 844         PR gdb/24617
 845         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 846         accessing parent[parent_len - 1].
 847
 848 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 849
 850         PR gdb/24364
 851         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 852         call dtrace_process_dof with NULL dof.
 853
 854 2019-06-16  Tom de Vries  <tdevries@suse.de>
 855
 856         PR gdb/24445
 857         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 858
 859 2019-06-16  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 862         (make_all_visible): Use address of member.
 863
 864 2019-06-16  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 867         (tui_free_window, free_content, free_content_elements): Remove
 868         unnecessary cast.
 869         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 870         cast.
 871         * tui/tui-regs.c (tui_show_register_group)
 872         (tui_display_registers_from, tui_display_reg_element_at_line):
 873         Remove unnecessary cast.
 874
 875 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 876
 877         * linux-nat.c (normal_mask): Delete.
 878         (_initialize_linux_nat): Don't initialise normal_mask.
 879
 880 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 881
 882         PR gdb/24445
 883         * dwarf-index-write.h (write_psymtabs_to_index): Add
 884         dwz_basename parameter.
 885         * dwarf-index-write.c (write_gdbindex): Move file writing to
 886         write_gdbindex_1.  Change return type void.
 887         (assert_file_size): Move up, remove filename parameter.
 888         (write_gdbindex_1): New function.
 889         (write_debug_names): Change return type to void, call
 890         assert_file_size.
 891         (struct index_wip_file): New struct.
 892         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 893         file logic to index_wip_file.  Write index for dwz file if
 894         needed.
 895         (save_gdb_index_command): Pass basename of dwz file, if present.
 896         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 897         build-id of dwz file, if present.
 898         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 899         (dwarf2_get_dwz_file): Likewise.
 900         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 901         (dwarf2_get_dwz_file): Likewise.
 902
 903 2019-06-16  Tom Tromey  <tom@tromey.com>
 904
 905         * coffread.c (process_coff_symbol): Use xstrdup.
 906         * value.c (create_internalvar): Use xstrdup.
 907
 908 2019-06-16  Tom Tromey  <tom@tromey.com>
 909
 910         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 911         * breakpoint.c (stopin_command, stopat_command)
 912         (until_break_command, decode_location_default): Remove unnecessary
 913         cast.
 914         * utils.c (subset_compare): Remove unnecessary cast.
 915         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 916         cast.
 917         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 918         cast.
 919         * infcmd.c (path_command): Remove unnecessary cast.
 920         * coffread.c (decode_type): Remove unnecessary cast.
 921         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 922         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 923         * tui/tui-stack.c (tui_show_locator_content)
 924         (tui_show_frame_info): Remove unnecessary cast.
 925         * tui/tui-win.c (tui_scroll_forward_command)
 926         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 927         (parse_scrolling_args): Remove unnecessary cast.
 928         * tui/tui-data.c (init_win_info, tui_del_window)
 929         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 930         (free_content_elements): Remove unnecessary cast.
 931         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 932         unnecessary cast.
 933         * tui/tui-source.c (tui_set_source_content)
 934         (tui_vertical_source_scroll): Remove unnecessary cast.
 935         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 936         cast.
 937         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 938         * tui/tui-regs.c (tui_display_registers_from)
 939         (tui_display_register): Remove unnecessary cast.
 940         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 941         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 942         (make_visible): Remove unnecessary cast.
 943         * tui/tui-winsource.c (tui_erase_source_content)
 944         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 945         unnecessary cast.
 946         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 947         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 948         * stabsread.c (read_type, read_array_type, read_range_type):
 949         Remove unnecessary cast.
 950         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 951         (parse_symbol, parse_type, upgrade_type, parse_external)
 952         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 953         unnecessary cast.
 954         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 955
 956 2019-06-16  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-data.c (tui_alloc_generic_win_info)
 959         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 960         checks.
 961
 962 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 963             Andrew Burgess  <andrew.burgess@embecosm.com>
 964
 965         * f-typeprint.c (f_print_type): Don't return early for not
 966         associated or not allocated types.
 967         (f_type_print_varspec_suffix): Add print_rank parameter and print
 968         ranks of array types in case they dangling.
 969         (f_type_print_base): Add print_rank parameter.
 970
 971 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 972
 973         * NEWS: Mention new MI commands.
 974         * break-catch-throw.c (enum exception_event_kind): Move to
 975         breakpoint.h.
 976         (print_mention_exception_catchpoint): Output text as a single
 977         message.
 978         (catch_exception_command_1): Rename to...
 979         (catch_exception_event): ...this, make non-static, update header
 980         command, and change some parameter types.
 981         (catch_catch_command): Update for changes to
 982         catch_exception_command_1.
 983         (catch_throw_command): Likewise.
 984         (catch_rethrow_command): Likewise.
 985         * breakpoint.c (enum exception_event_kind): Delete.
 986         * breakpoint.h (enum exception_event_kind): Moved here from
 987         break-catch-throw.c.
 988         (catch_exception_event): Declare.
 989         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 990         (mi_cmd_catch_throw): New function.
 991         (mi_cmd_catch_rethrow): New function.
 992         (mi_cmd_catch_catch): New function.
 993         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 994         'catch-catch' entries.
 995         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 996         (mi_cmd_catch_rethrow): Declare.
 997         (mi_cmd_catch_catch): Declare.
 998
 999 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1000
1001         * annotate.c (annotate_source_line): Change return type to void,
1002         update implementation to match.
1003         * annotate.h (annotate_source_line): Change return type to void,
1004         update header comment.
1005         * stack.c (print_frame_info): Don't change what frame information
1006         is printed based on whether annotations are on or not.
1007
1008 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1009
1010         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1011         (annotate_source): Make static.
1012         (annotate_source_line): Moved from source.c and renamed from
1013         identify_source_line.  Update the return type.
1014         * annotate.h (annotate_source): Delete declaration.
1015         (annotate_source_line): Declaration moved from source.h, and
1016         renamed from identify_source_line.  Return type updated.
1017         * source.c (identify_source_line): Moved to annotate.c and renamed
1018         to annotate_source_line.
1019         (info_line_command): Remove check of annotation_level.
1020         * source.h (identify_source_line): Move declaration to annotate.h
1021         and rename to annotate_source_line.
1022         * stack.c: Add 'annotate.h' include.
1023         (print_frame_info): Remove check of annotation_level before
1024         calling annotate_source_line.
1025
1026 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1027
1028         * source-cache.c (source_cache::get_plain_source_lines): Use
1029         open_source_file_with_line_charpos instead of just
1030         open_source_file, remove call to find_source_lines.
1031         (source_cache::get_source_lines): Likewise.
1032         * source.c (find_source_lines): Make static.
1033         (get_filename_and_charpos): Renamed into...
1034         (open_source_file_with_line_charpos): ..this along with changes to
1035         return a scoped_fd, and some other minor clean ups.
1036         (identify_source_line): Use open_source_file_with_line_charpos.
1037         (search_command_helper): Use open_source_file_with_line_charpos
1038         instead of just open_source_file, remove call to
1039         find_source_lines.
1040         * source.h (open_source_file_with_line_charpos): Declare new
1041         function.
1042         (find_source_lines): Delete declaration.
1043
1044 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1045
1046         * source.c (get_filename_and_charpos): Remove fullname
1047         parameter.
1048         (identify_source_line): Update call to get_filename_and_charpos.
1049
1050 2019-06-14  Tom Tromey  <tromey@adacore.com>
1051
1052         PR gdb/24502:
1053         * ui-style.h (skip_ansi_escape): Update comment.
1054         * ui-file.h (class no_terminal_escape_file): New class.
1055         * ui-file.c (no_terminal_escape_file::write)
1056         (no_terminal_escape_file::puts): New methods.
1057         * cli/cli-logging.c (handle_redirections): Use
1058         no_terminal_escape_file.
1059
1060 2019-06-14  Tom Tromey  <tromey@adacore.com>
1061
1062         * NEWS: Move convenience variable news above Python news.
1063
1064 2019-06-14  Tom Tromey  <tom@tromey.com>
1065
1066         * gnulib: Move directory to top-level.
1067         * configure.ac: Don't configure gnulib.
1068         * configure: Rebuild.
1069         * common/common-defs.h: Use new path to gnulib.
1070         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1071         (GNULIB_H): Remove.
1072         (INCGNU): Look in new gnulib location.
1073         (HFILES_NO_SRCDIR): Remove gnulib files.
1074         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1075         (generated_files): Remove GNULIB_H.
1076         ($(LIBGNU), all-lib): Remove targets.
1077         (distclean): Don't mention GNULIB_BUILDDIR.
1078         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1079
1080 2019-06-14  Tom Tromey  <tromey@adacore.com>
1081
1082         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1083         Warn if symbol file does not provide any symbols.
1084
1085 2019-06-14  Tom Tromey  <tromey@adacore.com>
1086
1087         * source.c (find_and_open_source): Respect basenames_may_differ.
1088
1089 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1090
1091         * annotate.c (annotate_breakpoints_invalid): Make use of
1092         scoped_restore_terminal_state.
1093         (annotate_frames_invalid): Likewise.
1094
1095 2019-06-14  Tom Tromey  <tromey@adacore.com>
1096
1097         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1098         allow assignment to an internalvar.
1099
1100 2019-06-14  Tom Tromey  <tromey@adacore.com>
1101
1102         * ada-lex.l: Allow "_" in attribute names.
1103
1104 2019-06-14  Tom Tromey  <tromey@adacore.com>
1105
1106         PR gdb/24653:
1107         * regcache.c (registers_changed): Don't call alloca.
1108         * top.c (execute_command): Don't call alloca.
1109
1110 2019-06-13  Pedro Alves  <palves@redhat.com>
1111
1112         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1113         'expression'.  When parsing an expression, error out if there's
1114         junk after "unlimited".
1115         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1116         (do_set_command): Adjust calls to is_unlimited_literal.
1117
1118 2019-06-13  Pedro Alves  <palves@redhat.com>
1119
1120         * compile/compile.c (make_compile_options_def_group): Add braces
1121         around array_view initializer.
1122         * thread.c (make_thread_apply_all_options_def_group)
1123         (make_thread_apply_all_options_def_group): Likewise.
1124
1125 2019-06-13  Pedro Alves  <palves@redhat.com>
1126
1127         * NEWS (New commands): Mention "maint test-options
1128         require-delimiter", "maint test-options unknown-is-error", "maint
1129         test-options unknown-is-operand" and "maint show
1130         test-options-completion-result".
1131         (New command options, command completion): New section.
1132         (Completion improvements): New section.
1133         Mention that you can abbreviate "unlimited".
1134
1135 2019-06-13  Pedro Alves  <palves@redhat.com>
1136
1137         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1138         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1139         * unittests/cli-utils-selftests.c (test_parse_flags)
1140         (test_parse_flags_qcs): Delete.
1141         (test_cli_utils): Don't call deleted functions.
1142
1143 2019-06-13  Pedro Alves  <palves@redhat.com>
1144
1145         * thread.c: Include "cli/cli-option.h".
1146         (tp_array_compar_ascending): Global.
1147         (tp_array_compar): Delete function.
1148         (tp_array_compar_ascending, tp_array_compar_descending): New
1149         functions.
1150         (ascending_option_def, qcs_flag_option_def)
1151         (thr_qcs_flags_option_defs)
1152         (make_thread_apply_all_options_def_group)
1153         (make_thread_apply_options_def_group): New.
1154         (thread_apply_all_command): Use gdb::option::process_options.
1155         (thread_apply_command_completer)
1156         (thread_apply_all_command_completer): New.
1157         (thread_apply_command): Use gdb::option::process_options.
1158         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1159         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1160         to generate help text of "thread apply".  Adjust "taas"'s help.
1161         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1162         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1163
1164 2019-06-13  Pedro Alves  <palves@redhat.com>
1165
1166         * thread.c (thread_apply_command): Check for invalid TID with
1167         isdigit instead of !isalpha.
1168
1169 2019-06-13  Pedro Alves  <palves@redhat.com>
1170
1171         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1172         (validate_flags_qcs): New.
1173         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1174         (validate_flags_qcs): Declare.
1175         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1176         (make_frame_apply_options_def_group): New.
1177         (frame_apply_command_count): Process options with
1178         gdb::option::process_options.
1179         (frame_apply_completer): New.
1180         (frame_apply_level_completer, frame_apply_all_completer)
1181         (frame_apply_completer): New.
1182         (_initialize_stack): Update help of "frame apply", "frame apply
1183         level", "frame apply all" and "faas" to mention supported options
1184         and install command completers.
1185         * stack.h (frame_apply_all_completer): Declare.
1186         * thread.c: Include "stack.h".
1187         (tfaas_command): Add "--".
1188         (_initialize_thread): Update help "tfaas" to mention supported
1189         options and install command completer.
1190
1191 2019-06-13  Pedro Alves  <palves@redhat.com>
1192
1193         * completer.c (complete_nested_command_line): New.
1194         (gdb_completion_word_break_characters_throw): Add assertion.
1195         * completer.h (complete_nested_command_line): Declare.
1196
1197 2019-06-13  Pedro Alves  <palves@redhat.com>
1198
1199         * stack.c (parse_backtrace_qualifiers): New.
1200         (backtrace_command): Use it.
1201         (backtrace_command_completer): Complete on qualifiers.
1202
1203 2019-06-13  Pedro Alves  <palves@redhat.com>
1204
1205         * frame.c: Include "cli/cli-option.h.
1206         (user_set_backtrace_options): New.
1207         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1208         Delete.
1209         (get_prev_frame): Adjust.
1210         (boolean_option_def, uinteger_option_def)
1211         (set_backtrace_option_defs): New.
1212         (_initialize_frame): Adjust and use
1213         gdb::option::add_setshow_cmds_for_options to install "set
1214         backtrace past-main" and "set backtrace past-entry".
1215         * frame.h: Include "cli/cli-option.h".
1216         (struct frame_print_options): Forward declare.
1217         (print_frame_arguments_all, print_frame_arguments_scalars)
1218         (print_frame_arguments_none): Declare.
1219         (print_entry_values): Delete declaration.
1220         (struct frame_print_options, user_frame_print_options): New.
1221         (struct set_backtrace_options): New.
1222         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1223         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1224         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1225         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1226         (list_args_or_locals): Add frame_print_options parameter.
1227         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1228         * python/py-framefilter.c (enumerate_args): Pass down
1229         USER_FRAME_PRINT_OPTIONS.
1230         * stack.c: Include "cli/cli-option.h".
1231         (print_frame_arguments_all, print_frame_arguments_scalars)
1232         (print_frame_arguments_none): Declare.
1233         (print_raw_frame_arguments, print_entry_values): Delete.
1234         (user_frame_print_options): New.
1235         (boolean_option_def, enum_option_def, frame_print_option_defs):
1236         New.
1237         (struct backtrace_cmd_options): New.
1238         (bt_flag_option_def): New.
1239         (backtrace_command_option_defs): New.
1240         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1241         (print_frame_arg, read_frame_arg, print_frame_args)
1242         (print_frame_info, print_frame): Add frame_print_options parameter
1243         and use it.
1244         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1245         (backtrace_command_1): Add frame_print_options and
1246         backtrace_cmd_options parameters and use them.
1247         (make_backtrace_options_def_group): New.
1248         (backtrace_command): Process command options with
1249         gdb::option::process_options.
1250         (backtrace_command_completer): New.
1251         (_initialize_stack): Extend "backtrace"'s help to mention
1252         supported options.  Install completer for "backtrace".
1253         Install some settings commands with add_setshow_cmds_for_options.
1254
1255 2019-06-13  Pedro Alves  <palves@redhat.com>
1256
1257         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1258         and that "set/show print raw frame-arguments" are now deprecated.
1259
1260         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1261         command.
1262         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1263         * stack.c (_initialize_stack): Install "set/show print
1264         raw-frame-arguments", and deprecate "set/show print raw
1265         frame-arguments".
1266         * valprint.c (_initialize_valprint): Deprecate "set/show print
1267         raw".
1268
1269 2019-06-13  Pedro Alves  <palves@redhat.com>
1270
1271         * compile/compile.c (struct compile_options): New.
1272         (compile_flag_option_def, compile_command_option_defs)
1273         (make_compile_options_def_group): New.
1274         (compile_file_command): Handle options with
1275         gdb::option::process_options.
1276         (compile_file_command_completer): New function.
1277         (compile_code_command): Handle options with
1278         gdb::option::process_options.
1279         (compile_code_command_completer): New function.
1280         (_initialize_compiler): Install completers for "compile code" and
1281         "compile file".  Mention available options in "compile code" and
1282         "compile code"'s help.
1283         * completer.c (advance_to_completion_word): New, factored out from
1284         ...
1285         (advance_to_expression_complete_word_point): ... this.
1286         (advance_to_filename_complete_word_point): New.
1287         * completer.h (advance_to_filename_complete_word_point): New
1288         declaration.
1289
1290 2019-06-13  Pedro Alves  <palves@redhat.com>
1291
1292         * compile/compile.c: Include "cli/cli-option.h".
1293         (compile_print_value): Scope data pointer is now a
1294         value_print_options pointer; adjust.
1295         (compile_print_command): Process options.  Scope data pointer is
1296         now a value_print_options pointer; adjust.
1297         (_initialize_compile): Update "compile print"'s help to include
1298         supported options.  Install a completer for "compile print".
1299         * cp-valprint.c (show_vtblprint, show_objectprint)
1300         (show_static_field_print): Delete.
1301         (_initialize_cp_valprint): Don't install "set print
1302         static-members", "set print vtbl", "set print object" here.
1303         * printcmd.c: Include "cli/cli-option.h" and
1304         "common/gdb_optional.h".
1305         (print_command_parse_format): Rework to fill in a
1306         value_print_options instead of a format_data.
1307         (print_value): Change parameter type from format_data pointer to
1308         value_print_options reference.  Adjust.
1309         (print_command_1): Process options.  Adjust to pass down a
1310         value_print_options.
1311         (print_command_completer): New.
1312         (_initialize_printcmd): Install print_command_completer as
1313         handle_brkchars completer for the "print" command.  Update
1314         "print"'s help to include supported options.
1315         * valprint.c: Include "cli/cli-option.h".
1316         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1317         here from cp-valprint.c.
1318         (boolean_option_def, uinteger_option_def)
1319         (value_print_option_defs, make_value_print_options_def_group):
1320         New.  Use gdb::option::add_setshow_cmds_for_options to install
1321         "set print elements", "set print null-stop", "set print repeats",
1322         "set print pretty", "set print union", "set print array", "set
1323         print address", "set print symbol", "set print array-indexes".
1324         * valprint.h: Include <string> and "cli/cli-option.h".
1325         (make_value_print_options_def_group): Declare.
1326         (print_value): Change parameter type from format_data pointer to
1327         value_print_options reference.
1328         (print_command_completer): Declare.
1329
1330 2019-06-13  Pedro Alves  <palves@redhat.com>
1331
1332         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1333         (COMMON_SFILES): Add maint-test-settings.c.
1334         * cli/cli-decode.c (boolean_enums): New global, factored out from
1335         ...
1336         (add_setshow_boolean_cmd): ... here.
1337         * cli/cli-decode.h (boolean_enums): Declare.
1338         * cli/cli-option.c: New file.
1339         * cli/cli-option.h: New file.
1340         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1341         factored out from ...
1342         (parse_cli_boolean_value(const char *)): ... this.
1343         (is_unlimited_literal): Change parameter type to pointer to
1344         pointer.  Adjust and advance ARG pointer.
1345         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1346         (parse_cli_var_enum): New, factored out from ...
1347         (do_set_command): ... this.  Adjust.
1348         * cli/cli-setshow.h (parse_cli_boolean_value)
1349         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1350         (parse_cli_var_enum): Declare.
1351         * cli/cli-utils.c: Include "cli/cli-option.h".
1352         (get_ulongest): New.
1353         * cli/cli-utils.h (get_ulongest): Declare.
1354         (check_for_argument): New overloads.
1355         * maint-test-options.c: New file.
1356
1357 2019-06-13  Pedro Alves  <palves@redhat.com>
1358
1359         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1360         parse a range if "-" is at the end of the string.
1361
1362 2019-06-13  Pedro Alves  <palves@redhat.com>
1363
1364         * cli/cli-setshow.c (parse_auto_binary_operation)
1365         (parse_cli_boolean_value): Don't allow "o".
1366
1367 2019-06-13  Pedro Alves  <palves@redhat.com>
1368
1369         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1370         * NEWS: Mention maint test-settings KIND.
1371         * maint-test-settings.c: New file.
1372
1373 2019-06-13  Pedro Alves  <palves@redhat.com>
1374
1375         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1376         completer.
1377         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1378         "set" completers.
1379
1380 2019-06-13  Pedro Alves  <palves@redhat.com>
1381
1382         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1383         after item.
1384
1385 2019-06-13  Pedro Alves  <palves@redhat.com>
1386
1387         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1388
1389 2019-06-13  Pedro Alves <palves@redhat.com>
1390
1391         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1392         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1393         call.
1394         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1395         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1396         calls.
1397         (check_for_argument): Skip spaces after argument.
1398
1399 2019-06-13  Pedro Alves  <palves@redhat.com>
1400
1401         * thread.c (thread_apply_command): Adjust TID parsing.
1402         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1403         detected before end of string.
1404         (tid_is_in_list): Error out if LIST is invalid.
1405
1406 2019-06-13  Pedro Alves  <palves@redhat.com>
1407
1408         * completer.c (complete_line_internal_1): Rewind completion word
1409         point.
1410         (completion_tracker::advance_custom_word_point_by): Change
1411         parameter type to int.
1412         * completer.h (completion_tracker::advance_custom_word_point_by):
1413         Likewise.
1414
1415 2019-06-13  Pedro Alves  <palves@redhat.com>
1416
1417         * completer.c (advance_to_completion_word): Handle delimiters.
1418
1419 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1420
1421         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1422
1423 2019-06-11  Tom Tromey  <tom@tromey.com>
1424
1425         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1426         (xmalloc_failed): Move to alloc.c.
1427         * alloc.c: New file.
1428         * Makefile.in (COMMON_SFILES): Add alloc.c.
1429
1430 2019-06-11  Tom Tromey  <tom@tromey.com>
1431
1432         * nat/linux-waitpid.c: Don't include server.h.
1433         (linux_debug): Remove.
1434         (my_waitpid): Update.
1435
1436 2019-06-11  Tom Tromey  <tromey@adacore.com>
1437
1438         * infcall.c (_initialize_infcall): Remove trailing newline from
1439         help.
1440         * user-regs.c (_initialize_user_regs): Remove trailing newline
1441         from help.
1442         * typeprint.c (_initialize_typeprint): Remove trailing newline
1443         from help.
1444         * reverse.c (_initialize_reverse): Remove trailing newlines from
1445         help.
1446         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1447         from help.
1448         * language.c (add_set_language_command): Remove trailing newline
1449         from help.
1450         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1451         help.
1452         * disasm.c (_initialize_disasm): Remove trailing newline from
1453         help.
1454         * top.c (init_main): Remove trailing newline from help.
1455         * interps.c (_initialize_interpreter): Remove trailing newline
1456         from help.
1457         * btrace.c (_initialize_btrace): Remove trailing newlines from
1458         help.
1459         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1460         from help.
1461         * python/python.c (_initialize_python): Remove trailing newline
1462         from help.
1463         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1464         help.
1465         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1466         from help.  Reformat some text.
1467         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1468         from help.
1469         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1470         newline from help.
1471
1472 2019-06-11  Tom Tromey  <tromey@adacore.com>
1473
1474         * darwin-nat.c (darwin_decode_exception_message)
1475         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1476
1477 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1478
1479         * valops.c (value_slice): Check for not allocated or not
1480         associated values.
1481
1482 2019-06-10  Tom de Vries  <tdevries@suse.de>
1483
1484         PR gdb/24618
1485         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1486         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1487         invalid.
1488
1489 2019-06-10  Tom de Vries  <tdevries@suse.de>
1490
1491         PR gdb/24611
1492         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1493         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1494
1495 2019-06-10  Tom de Vries  <tdevries@suse.de>
1496
1497         PR symtab/24545
1498         * symtab.c (struct demangled_name_entry): Add language field.
1499         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1500         static minimal symbol".  Set and use language field.
1501
1502 2019-06-10  Tom Tromey  <tromey@adacore.com>
1503
1504         * ada-lang.c (_initialize_ada_language): Update help text.
1505
1506 2019-06-10  Tom Tromey  <tromey@adacore.com>
1507
1508         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1509         with a newline.
1510         * guile/guile.c (handle_boot_error): Don't end warning with a
1511         newline.
1512         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1513         warning with a newline.
1514         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1515         newline.
1516         (s12z_frame_cache): Likewise.
1517         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1518         a newline.
1519         * solib-svr4.c (disable_probes_interface): Don't end warning with
1520         a newline.
1521         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1522         newline.
1523         * python/python.c (do_finish_initialization): Don't end warning
1524         with a newline.
1525
1526 2019-06-10  Tom Tromey  <tom@tromey.com>
1527
1528         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1529         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1530         gdbpy_enter.
1531
1532 2019-06-10  Tom Tromey  <tromey@adacore.com>
1533
1534         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1535         data.
1536         (elf_new_init): Don't call stabsread_new_init.
1537         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1538         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1539         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1540
1541 2019-06-10  Tom de Vries  <tdevries@suse.de>
1542
1543         PR symtab/16264
1544         PR symtab/24517
1545         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1546
1547 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1548
1549         * source.c (find_and_open_source): Also rewrite relative file
1550         names.
1551
1552 2019-04-26  Amos Bird  <amosbird@gmail.com>
1553
1554         * annotate.c (annotate_thread_exited): Add "thread-exited"
1555         annotation.
1556
1557 2019-06-06  Tom Tromey  <tromey@adacore.com>
1558
1559         * maint.h (class scoped_command_stats): Use
1560         DISABLE_COPY_AND_ASSIGN.
1561         <print_time>: New method.
1562         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1563         print_time.
1564         (scoped_command_stats::print_time): New method.
1565
1566 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1567
1568         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1569         instructions of lengths 6 or 8 bytes.
1570
1571 2019-06-04  Pedro Alves  <palves@redhat.com>
1572
1573         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1574
1575         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1576         * breakpoint.c (condition_completer): Likewise.
1577         * cli/cli-dump.c (scan_expression): Likewise.
1578         * common/filestuff.c (mkdir_recursive): Likewise.
1579         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1580         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1581         (gdb_abspath): Likewise.
1582         * compile/compile-cplus-types.c
1583         (compile_cplus_instance::decl_name): Likewise.
1584         * completer.c (complete_explicit_location):
1585         (signal_completer, reg_or_group_completer_1): Likewise.
1586         * cp-support.c (cp_remove_params_if_any): Likewise.
1587         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1588         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1589         * infcmd.c (strip_bg_char): Likewise.
1590         * linespec.c (copy_token_string): Likewise.
1591         * mi/mi-main.c (output_cores): Likewise.
1592         * psymtab.c (psymtab_search_name):
1593         * symfile.c (test_set_ext_lang_command): Likewise.
1594         * target.c (target_fileio_read_stralloc): Likewise.
1595         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1596         * value.c (complete_internalvar): Likewise.
1597
1598 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1599
1600         Add objfile property to gdb.Type.
1601         * NEWS: Mention Python API addition.
1602         * python/py-type.c (typy_get_objfile): New method.
1603
1604 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1605
1606         * NEWS: Mention the new set|show style [title|highlight].
1607         Mention changes to "show style", "help" and "apropos".
1608
1609 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1610
1611         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1612         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1613         instead of print_help_for_command.
1614         (print_doc_of_command): New function.
1615         (help_list): Add 'apropos -v word' suggestion.
1616         (print_help_for_command): Style the command name using title style.
1617         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1618         (_initialize_cli_cmds): Describe -v in apropos_command help.
1619
1620 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1621
1622         * cli/cli-style.h (cli_style_option): Add name in constructor,
1623         add m_name class member, add constructor with intensity,
1624         add name class function.
1625         (cli_style_option::add_setshow_commands): Remove name argument.
1626         (highlight_style, title_style): New styles.
1627         * cli/cli-style.c (do_show): New function that shows a style
1628         characteristic styling the style name with itself.
1629         (set_style_name): New function.
1630         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1631         Update all callers according to the changes in cli/cli-style.h.
1632         * utils.h (fputs_highlighted): New function.
1633         * utils.c (fputs_highlighted): Likewise.
1634
1635 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1636
1637         * NEWS: Mention new pipe command and new convenience variables.
1638
1639 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1640
1641         * cli/cli-cmds.c (pipe_command): New function.
1642         (_initialize_cli_cmds): Call add_com for pipe_command.
1643         Define | as an alias for pipe.
1644         (exit_status_set_internal_vars): New function.
1645         (shell_escape): Call exit_status_set_internal_vars.
1646         cli/cli-decode.c (find_command_name_length): Recognize | as
1647         a single character command.
1648
1649 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1650
1651         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1652         top.c (execute_command_to_ui_file): New function, mostly a copy
1653         of execute_command_to_string.
1654         (execute_command_to_string): Implement by calling
1655         execute_command_to_ui_file.
1656
1657 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1658
1659         * top.h (saved_command_line): Remove declaration.
1660         * top.c (previous_saved_command_line, previous_repeat_arguments):
1661         New variables.
1662         (saved_command_line): Make static, define together with other
1663         'repeat variables'.
1664         (dont_repeat): Clear repeat_arguments.
1665         (repeat_previous, get_saved_command_line, save_command_line):
1666         New functions.
1667         (gdb_init): Initialize saved_command_line
1668         and previous_saved_command_line.
1669         * main.c (captured_main_1): Remove saved_command_line initialization.
1670         * event-top.c (handle_line_of_input): Update to use
1671         the new 'repeat' related functions instead of direct access to
1672         saved_command_line.
1673         * command.h (repeat_previous, get_saved_command_line,
1674         save_command_line): New declarations.
1675         (dont_repeat): Add comment.
1676
1677 2019-05-30  Tom Tromey  <tromey@adacore.com>
1678
1679         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1680         Fix comment.
1681         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1682
1683 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1684
1685         PR cli/24587
1686         * completer.c (complete): Initialize variable word.
1687
1688 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1689
1690         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1691         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1692         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1693         'body' is NULL to the outter 'if', protecting the '!is_define'
1694         situation as well.
1695
1696 2019-05-29  Tom Tromey  <tromey@adacore.com>
1697
1698         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1699         (dwarf_unknown): New function.
1700         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1701         (dwarf_type_encoding_name): Use dwarf_unknown.
1702
1703 2019-05-29  Tom Tromey  <tromey@adacore.com>
1704
1705         PR c++/20020:
1706         * cp-valprint.c (cp_print_value_fields): Call
1707         cp_print_static_field inside "try".
1708
1709 2019-05-29  Tom Tromey  <tromey@adacore.com>
1710
1711         * inflow.c (struct terminal_info): Add default operator=.
1712         * configure: Rebuild.
1713         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1714         -Wdeprecated-copy-dtor, -Wredundant-move.
1715
1716 2019-05-29  Tom Tromey  <tromey@adacore.com>
1717
1718         * NEWS: Add entry.
1719         * infcmd.c (print_return_value_1): Handle finish_print
1720         option.
1721         (show_print_finish): New function.
1722         (_initialize_infcmd): Add "set/show print finish" commands.
1723         * valprint.c (user_print_options): Initialize new member.
1724         * valprint.h (struct value_print_options) <finish_print>: New
1725         member.
1726
1727 2019-05-28  Tom Tromey  <tromey@adacore.com>
1728
1729         * ada-lang.c (ada_remove_Xbn_suffix)
1730         (find_old_style_renaming_symbol)
1731         (parse_old_style_renaming): Remove.
1732         (ada_find_renaming_symbol): Don't call
1733         find_old_style_renaming_symbol.
1734         (ada_is_renaming_symbol): Rename from
1735         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1736         bool.  Now static.
1737         (ada_read_var_value): Update and simplify.
1738         * ada-exp.y (write_var_or_type): Remove old code.
1739
1740 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1741
1742         * event-top.c: Remove include comment.
1743         * inflow.c (class scoped_ignore_sigttou): Move from here...
1744         * inflow.h (class scoped_ignore_sigttou): ...to here.
1745         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1746         * top.c:  Remove include comment.
1747
1748 2019-05-27  Tom Tromey  <tom@tromey.com>
1749
1750         * NEWS: Fix typo.
1751
1752 2019-05-22  Tom Tromey  <tromey@adacore.com>
1753
1754         * target.c (target_follow_exec): Constify parameter.
1755         * target-delegates.c: Rebuild.
1756         * remote.c (remote_target::follow_exec): Constify parameter.
1757         * infrun.c (follow_exec): Constify parameter.
1758         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1759         (target_follow_exec): Likewise.
1760
1761 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1762
1763         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1764         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1765
1766 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1767
1768         * NEWS: Add debugredirect and testsuite sections.
1769
1770 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1771
1772         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1773         target descriptions using exclusively floating point register name
1774         aliases.
1775
1776 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1777
1778         PR gdb/18644:
1779         * f-lang.c (build_fortran_types): Handle the case where
1780         gdbarch_floatformat_for_type returns a nullptr.
1781
1782 2019-05-21  Tom de Vries  <tdevries@suse.de>
1783
1784         PR cli/24587
1785         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1786
1787 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1788
1789         PR gdb/18644:
1790         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1791         16-byte floats.
1792         * i386-tdep.c (i386_floatformat_for_type): Use
1793         floatformats_ia64_quad for the 16-byte floating point component
1794         within a fortran 32-byte complex number.
1795
1796 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1797
1798         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1799         delete default constructor.
1800         (find_partial_die): Update to return const struct.
1801         (partial_die_parent_scope): Move variable declaration into scope
1802         of its use and change its type to auto.
1803         (guess_partial_die_structure_name): Likewise.
1804         (partial_die_info::fixup): Likewise.
1805
1806 2019-05-17  Tom Tromey  <tromey@adacore.com>
1807
1808         * source.c (find_and_open_source): Remove cast.
1809
1810 2019-05-17  Tom Tromey  <tromey@adacore.com>
1811
1812         * annotate.c (annotate_source): Make "filename" const.
1813         * annotate.h (annotate_source): Use const.
1814
1815 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1816
1817         * disasm.c (set_disassembler_options): Send errors to stderr.
1818
1819 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1820
1821         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1822         (cli_interp_base::set_logging): Check debug_redirect.
1823         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1824         * cli/cli-logging.c (debug_redirect): Add static variable.
1825         (pop_output_files): Add default param.
1826         (handle_redirections): Print debug setting.
1827         (show_logging_command): Likewise.
1828         (_initialize_cli_logging): Add debugredirect command.
1829         * interps.c (current_interp_set_logging): Add debug_redirect
1830         parameter.
1831         * interps.h (set_logging): Add debug_redirect parameter.
1832         (current_interp_set_logging): Likewise.
1833         * mi/mi-common.h: Likewise.
1834         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1835
1836 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1837             Tom Tromey  <tromey@adacore.com>
1838
1839         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1840         directly.
1841         * cli/cli-interp.h (make_logging_output): Remove declaration.
1842         * cli/cli-logging.c (make_logging_output): Remove function.
1843         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1844         directly.
1845         * ui-file.c (tee_file::tee_file): Remove bools.
1846         (tee_file::~tee_file): Remove deletes.
1847         * ui-file.h (tee_file): Remove bools.
1848
1849 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1850
1851         * mi/mi-cmds.h (mi_cmd_complete): New function.
1852         * mi/mi-main.c (mi_cmd_complete): Likewise.
1853         * mi/mi-cmds.c: Define new MI command -complete.
1854         * NEWS: Mention new -complete command.
1855
1856 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1857
1858         * completer.h (complete): New function.
1859         * completer.c (complete): Likewise.
1860         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1861         function defined in completer.h.
1862
1863 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1864
1865         * MAINTAINERS (Write After Approval): Add myself.
1866
1867 2019-05-17  Tom de Vries  <tdevries@suse.de>
1868
1869         PR gdb/24094
1870         * dwarf2read.c (struct cu_partial_die_info): New struct.
1871         (find_partial_die): Return cu_partial_die_info.
1872         (partial_die_parent_scope, guess_partial_die_structure_name)
1873         (partial_die_info::fixup): Handle new return type of find_partial_die.
1874
1875 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1876
1877         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1878         "std::string", simplifying the algorithm.
1879
1880 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1881
1882         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1883         (stap_static_probe_ops::get_probes): Likewise.
1884
1885 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1886
1887         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1888         '-')" and "else if".
1889         (stap_parse_single_operand): Join checks for
1890         "gdbarch_stap_parse_special_token_p" and
1891         "gdbarch_stap_parse_special_token" in the same "if" statement.
1892         Invert check when verifying for operation on register
1893         displacement.
1894
1895 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1896
1897         * stap-probe.c (stap_get_opcode): Update comment.
1898         (stap_get_expected_argument_type): Likewise.
1899         (handle_stap_probe): Likewise.
1900
1901 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1902
1903         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1904         return type to 'bool'.  Adjust comment.  Use 'bool' when
1905         appropriate.
1906         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1907         * stap-probe.c (stap_parse_argument_1): Likewise.
1908         (stap_is_operator): Likewise.
1909         (stap_is_generic_prefix): Likewise.
1910         (stap_is_register_prefix): Likewise.
1911         (stap_is_register_indirection_prefix): Likewise.
1912         (stap_is_integer_prefix): Likewise.
1913         (stap_generic_check_suffix): Likewise.
1914         (stap_check_integer_suffix): Likewise.
1915         (stap_check_register_suffix): Likewise.
1916         (stap_check_register_indirection_suffix): Likewise.
1917         (stap_parse_register_operand): Likewise.
1918         (stap_parse_single_operand): Likewise.
1919         (stap_parse_argument_1): Likewise.
1920         (stap_probe::get_argument_count): Likewise.
1921         (stap_is_operator): Likewise.
1922
1923 2019-05-16  Tom Tromey  <tromey@adacore.com>
1924
1925         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1926         keyword to foreach.
1927
1928 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1929
1930         * linux-thread-db.c (try_thread_db_load_1): Change return type
1931         to bool.
1932         (try_thread_db_load): Likewise.
1933         (try_thread_db_load_from_pdir_1): Likewise.
1934         (try_thread_db_load_from_pdir): Likewise.
1935         (try_thread_db_load_from_sdir): Likewise.
1936         (try_thread_db_load_from_dir): Likewise.
1937         (thread_db_load_search): Likewise.
1938         (has_libpthread): Likewise.
1939         (thread_db_load): Likewise.
1940
1941 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1942
1943         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1944         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1945         NULL, and complain/return if that's the case.
1946
1947 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1948
1949         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1950         (advance, posn, abstract_read_memory): New functions.
1951         [struct mem_read_abstraction]: New struct.
1952         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1953
1954 2019-05-14  Tom Tromey  <tromey@adacore.com>
1955
1956         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1957         value is not lval_memory.
1958
1959 2019-05-14  Tom Tromey  <tromey@adacore.com>
1960
1961         * solib.c (info_sharedlibrary_command): Style the file name.
1962
1963 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1964
1965         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1966         (aarch64_vnv_type): Likewise.
1967         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1968         * common/tdesc.c: Likewise.
1969         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1970         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1971         * features/aarch64-fpu.xml: Add ieee half view.
1972         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1973         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1974         * gdbtypes.h (struct builtin_type): Likewise.
1975         (struct objfile_type): Likewise.
1976
1977 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1978
1979         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1980         typo.
1981         * location.h (string_to_event_location): Likewise.
1982
1983 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1984
1985         GDB 8.3 released.
1986
1987 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1988
1989         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1990         New variable declaration.
1991         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1992         New variable.
1993         (print_one_breakpoint): Use ui_out::test_flags and new global
1994         variable to compute use_fixed_output.
1995         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1996         Remove.
1997         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1998         (mi_multi_location_breakpoint_output_fixed): Remove.
1999         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2000         new variable.
2001         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2002         fix_multi_location_breakpoint_output flag if version >= 3.
2003         * ui-out.h (enum ui_out_flag)
2004         <fix_multi_location_breakpoint_output>: New enumerator.
2005
2006 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2007
2008         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2009
2010 2019-05-10  Tom Tromey  <tromey@adacore.com>
2011
2012         * ada-lang.c (catch_ada_completer): New function.
2013         (_initialize_ada_language): Use it.
2014
2015 2019-05-10  Tom Tromey  <tromey@adacore.com>
2016
2017         * thread.c (print_thread_info): Make "requested_threads" const.
2018         * gdbthread.h (print_thread_info): Make "requested_threads"
2019         const.
2020         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2021         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2022
2023 2019-05-08  Tom Tromey  <tom@tromey.com>
2024
2025         * gdbtypes.c (objfile_type_data): Change type.
2026         (objfile_type, _initialize_gdbtypes): Update.
2027
2028 2019-05-08  Tom Tromey  <tom@tromey.com>
2029
2030         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2031         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2032         (_initialize_dwarf2_frame): Update.
2033
2034 2019-05-08  Tom Tromey  <tom@tromey.com>
2035
2036         * objc-lang.c (objc_objfile_data): Change type.
2037         (find_methods): Update.
2038         (_initialize_objc_lang): Remove.
2039
2040 2019-05-08  Tom Tromey  <tom@tromey.com>
2041
2042         * stabsread.c (rs6000_builtin_type_data): Change type.
2043         (rs6000_builtin_type, _initialize_stabsread): Update.
2044
2045 2019-05-08  Tom Tromey  <tom@tromey.com>
2046
2047         * mips-tdep.c (mips_pdr_data): Remove.
2048         (_initialize_mips_tdep): Update.
2049
2050 2019-05-08  Tom Tromey  <tom@tromey.com>
2051
2052         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2053         (hppa_init_objfile_priv_data, read_unwind_info)
2054         (find_unwind_entry, _initialize_hppa_tdep): Update.
2055
2056 2019-05-08  Tom Tromey  <tom@tromey.com>
2057
2058         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2059         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2060         on obstack.
2061         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2062
2063 2019-05-08  Tom Tromey  <tom@tromey.com>
2064
2065         * mdebugread.c (basic_type_data): Change type.
2066         (basic_type, _initialize_mdebugread): Update.
2067
2068 2019-05-08  Tom Tromey  <tom@tromey.com>
2069
2070         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2071
2072 2019-05-08  Tom Tromey  <tom@tromey.com>
2073
2074         * nto-tdep.c (nto_inferior_data_reg): Change type.
2075         (nto_inferior_data): Update.
2076         (nto_inferior_data_cleanup, nto_new_inferior_data)
2077         (_initialize_nto_tdep): Remove.
2078         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2079
2080 2019-05-08  Tom Tromey  <tom@tromey.com>
2081
2082         * ada-lang.c (struct ada_inferior_data): Add initializers.
2083         (ada_inferior_data): Change type.
2084         (ada_inferior_data_cleanup): Remove.
2085         (get_ada_inferior_data, ada_inferior_exit)
2086         (struct ada_pspace_data): Add initializers, destructor.
2087         (ada_pspace_data_handle): Change type.
2088         (get_ada_pspace_data): Update.
2089         (ada_pspace_data_cleanup): Remove.
2090
2091 2019-05-08  Tom Tromey  <tom@tromey.com>
2092
2093         * coffread.c (struct coff_symfile_info): Add initializers.
2094         (coff_objfile_data_key): Move lower.  Change type.
2095         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2096         Update.
2097         (coff_free_info): Remove.
2098
2099 2019-05-08  Tom Tromey  <tom@tromey.com>
2100
2101         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2102         (fbsd_pspace_data_handle): Move lower.  Change type.
2103         (get_fbsd_pspace_data): Update.
2104         (fbsd_pspace_data_cleanup): Remove.
2105         (_initialize_fbsd_tdep): Update.
2106
2107 2019-05-08  Tom Tromey  <tom@tromey.com>
2108
2109         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2110         (get_ada_tasks_pspace_data): Update.
2111         (ada_tasks_pspace_data_cleanup): Remove.
2112         (_initialize_tasks): Update.
2113         (ada_tasks_inferior_data_handle): Change type.
2114         (get_ada_tasks_inferior_data): Update.
2115         (ada_tasks_inferior_data_cleanup): Remove.
2116         (struct ada_tasks_pspace_data): Add initializers.
2117
2118 2019-05-08  Tom Tromey  <tom@tromey.com>
2119
2120         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2121         * symfile-debug.c (debug_sym_get_probes): Change type.
2122         * stap-probe.c (handle_stap_probe):
2123         (stap_static_probe_ops::get_probes): Change type.
2124         * probe.h (class static_probe_ops) <get_probes>: Change type.
2125         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2126         (parse_probes_in_pspace): Update.
2127         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2128         Update.
2129         (any_static_probe_ops::get_probes): Change type.
2130         * elfread.c (elfread_data): New typedef.
2131         (probe_key): Change type.
2132         (elf_get_probes): Likewise.  Update.
2133         (probe_key_free): Remove.
2134         (_initialize_elfread): Update.
2135         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2136         Change type.
2137         (dtrace_process_dof_probe, dtrace_process_dof)
2138         (dtrace_static_probe_ops::get_probe): Change type.
2139
2140 2019-05-08  Tom Tromey  <tom@tromey.com>
2141
2142         * xcoffread.c (struct xcoff_symfile_info): Rename from
2143         coff_symfile_info.  Add initializers.
2144         (xcoff_objfile_data_key): Move lower.  Change type.
2145         (XCOFF_DATA): Rewrite.
2146         (xcoff_free_info): Remove.
2147         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2148         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2149         (xcoff_initial_scan): Update.
2150
2151 2019-05-08  Tom Tromey  <tom@tromey.com>
2152
2153         * solib-svr4.c (struct svr4_info): Add initializers and
2154         destructor.
2155         <probes_table>: Now an htab_up.
2156         (solib_svr4_pspace_data): Change type.
2157         (free_probes_table): Simplify.
2158         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2159         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2160         (probes_table_remove_objfile_probes, register_solib_event_probe)
2161         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2162         (_initialize_svr4_solib): Update.
2163
2164 2019-05-08  Tom Tromey  <tom@tromey.com>
2165
2166         * remote.c (remote_pspace_data): Change type.
2167         (remote_pspace_data_cleanup): Remove.
2168         (get_remote_exec_file, set_pspace_remote_exec_file)
2169         (_initialize_remote): Update.
2170
2171 2019-05-08  Tom Tromey  <tom@tromey.com>
2172
2173         * breakpoint.c (breakpoint_objfile_key): Change type.
2174         (get_breakpoint_objfile_data): Update.
2175         (free_breakpoint_objfile_data): Remove.
2176         (_initialize_breakpoint): Update.
2177
2178 2019-05-08  Tom Tromey  <tom@tromey.com>
2179
2180         * linux-tdep.c (struct linux_info): Add initializers.
2181         (linux_inferior_data): Move.  Change type.
2182         (invalidate_linux_cache_inf): Update.
2183         (linux_inferior_data_cleanup): Remove.
2184         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2185
2186 2019-05-08  Tom Tromey  <tom@tromey.com>
2187
2188         * auxv.c (auxv_inferior_data): Move.  Change type.
2189         (auxv_inferior_data_cleanup): Remove.
2190         (invalidate_auxv_cache_inf): Rewrite.
2191         (get_auxv_inferior_data, _initialize_auxv): Update.
2192
2193 2019-05-08  Tom Tromey  <tom@tromey.com>
2194
2195         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2196         (symfile_debug_objfile_data_key): Change type.
2197         (symfile_debug_installed, debug_qf_has_symbols)
2198         (debug_qf_find_last_source_symtab)
2199         (debug_qf_forget_cached_source_info)
2200         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2201         (debug_qf_print_stats, debug_qf_dump)
2202         (debug_qf_expand_symtabs_for_function)
2203         (debug_qf_expand_all_symtabs)
2204         (debug_qf_expand_symtabs_with_fullname)
2205         (debug_qf_map_matching_symbols)
2206         (debug_qf_expand_symtabs_matching)
2207         (debug_qf_find_pc_sect_compunit_symtab)
2208         (debug_qf_map_symbol_filenames)
2209         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2210         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2211         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2212         (debug_sym_read_linetable, debug_sym_relocate): Update.
2213         (symfile_debug_free_objfile): Remove.
2214         (install_symfile_debug_logging, _initialize_symfile_debug):
2215         Update.
2216
2217 2019-05-08  Tom Tromey  <tom@tromey.com>
2218
2219         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2220         allocate_on_obstack.
2221         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2222         (get_dwarf2_per_objfile): Update.
2223         (set_dwarf2_per_objfile): Remove.
2224         (dwarf2_has_info, dwarf2_get_section_info): Update.
2225         (dwarf2_free_objfile): Remove.
2226         (_initialize_dwarf2_read): Update.
2227
2228 2019-05-08  Tom Tromey  <tom@tromey.com>
2229
2230         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2231         initializers.
2232         <unsupported_script_warning_printed,
2233         script_not_found_warning_printed>: Now bool.
2234         (auto_load_pspace_data): Change type.
2235         (~auto_load_pspace_info): Rename from
2236         auto_load_pspace_data_cleanup.
2237         (get_auto_load_pspace_data, init_loaded_scripts_info)
2238         (clear_section_scripts, maybe_print_unsupported_script_warning)
2239         (maybe_print_script_not_found_warning, _initialize_auto_load):
2240         Update.
2241
2242 2019-05-08  Tom Tromey  <tom@tromey.com>
2243
2244         * objfiles.c (objfile_pspace_info): Add destructor and
2245         initializers.
2246         (objfiles_pspace_data): Change type.
2247         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2248         (get_objfile_pspace_data): Update.
2249         (objfiles_bfd_data): Change type.
2250         (get_objfile_bfd_data): Update.
2251         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2252
2253 2019-05-08  Tom Tromey  <tom@tromey.com>
2254
2255         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2256         Change type.
2257         (get_catch_syscall_inferior_data): Update.
2258         (catch_syscall_inferior_data_cleanup): Remove.
2259         (_initialize_break_catch_syscall): Update.
2260
2261 2019-05-08  Tom Tromey  <tom@tromey.com>
2262
2263         * inflow.c (struct terminal_info): Add destructor and
2264         initializers.
2265         (inflow_inferior_data): Change type.
2266         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2267         (get_inflow_inferior_data, inflow_inferior_exit)
2268         (swap_terminal_info, _initialize_inflow): Update.
2269
2270 2019-05-08  Tom Tromey  <tom@tromey.com>
2271
2272         * target-dcache.c (target_dcache_cleanup): Remove.
2273         (target_dcache_aspace_key): Change type.
2274         (target_dcache_init_p, target_dcache_invalidate)
2275         (target_dcache_get, target_dcache_get_or_init)
2276         (_initialize_target_dcache): Update.
2277         * dcache.h (struct dcache_deleter): New.
2278
2279 2019-05-08  Tom Tromey  <tom@tromey.com>
2280
2281         * symtab.c (struct symbol_cache): Add destructor and
2282         initializers.
2283         (symbol_cache_key): Move.  Change type.
2284         (make_symbol_cache, free_symbol_cache): Remove.
2285         (get_symbol_cache): Update.
2286         (symbol_cache_cleanup): Remove.
2287         (ALL_PSPACES, symbol_cache_flush)
2288         (maintenance_print_symbol_cache)
2289         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2290         Update.
2291
2292 2019-05-08  Tom Tromey  <tom@tromey.com>
2293
2294         * symtab.c (struct main_info): Add destructor and initializers.
2295         (main_progspace_key): Move.  Change type.
2296         (get_main_info): Update.
2297         (main_info_cleanup): Remove.
2298         (_initialize_symtab): Update.
2299
2300 2019-05-08  Tom Tromey  <tom@tromey.com>
2301
2302         * registry.h (DECLARE_REGISTRY): Define the _key class.
2303
2304 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2305
2306         * NEWS: Merge two 'New commands' sections.
2307
2308 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2309
2310         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2311         parameter and use Ada language definition instead.
2312         (ada_val_print_ptr): Remove unused language parameter.
2313         (ada_val_print_num): Remove language parameter and use Ada language
2314         definition instead.
2315         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2316         parameter.
2317         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2318         parameter and use Ada language definition instead.
2319         (ada_val_print_1): Update all ada_val_print_xxx calls.
2320         Remove language parameter.
2321         (ada_val_print): Update ada_val_print_1 call.
2322
2323 2019-05-08  Tom Tromey  <tromey@adacore.com>
2324
2325         * remote.c (remote_hw_watchpoint_limit)
2326         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2327         Now static.
2328
2329 2019-05-08  Tom Tromey  <tromey@adacore.com>
2330
2331         * maint.c (_initialize_maint_cmds): Move initialization code to
2332         remote.c.
2333         (watchdog, show_watchdog): Move to remote.c.
2334         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2335         "watchdog" static.
2336         (_initialize_remote): Move initialization code from maint.c.
2337         * defs.h (watchdog): Don't declare.
2338
2339 2019-05-08  Tom Tromey  <tromey@adacore.com>
2340
2341         * tui/tui-interp.c: Include main.h.
2342         * interps.c: Include main.h.
2343         * main.h (interpreter_p): Declare.
2344         * defs.h (interpreter_p): Don't declare.
2345
2346 2019-05-08  Tom Tromey  <tromey@adacore.com>
2347
2348         * dwarf2loc.c: Include dwarf2read.h.
2349         * defs.h (read_unsigned_leb128): Don't declare.
2350         * dwarf2read.h (read_unsigned_leb128): Declare.
2351
2352 2019-05-08  Tom Tromey  <tromey@adacore.com>
2353
2354         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2355         method.
2356
2357 2019-05-08  Tom Tromey  <tromey@adacore.com>
2358
2359         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2360         when no wrap column is set.
2361
2362 2019-05-08  Tom Tromey  <tromey@adacore.com>
2363
2364         * c-lang.c (c_get_string): Handle non-C-style arrays.
2365
2366 2019-05-08  Tom Tromey  <tromey@adacore.com>
2367
2368         * typeprint.c (print_offset_data::update): Print the bit offset,
2369         not the number of bits remaining.
2370
2371 2019-05-08  Tom Tromey  <tromey@adacore.com>
2372
2373         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2374         padding at end of comment.
2375
2376 2019-05-08  Tom Tromey  <tromey@adacore.com>
2377
2378         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2379         Compare main types.
2380
2381 2019-05-06  Tom Tromey  <tom@tromey.com>
2382
2383         * common/scoped_mmap.c: Include common-defs.h.
2384         * common/scoped_mmap.h: Don't include config.h.
2385
2386 2019-05-04  Tom Tromey  <tom@tromey.com>
2387
2388         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2389         (struct aarch64_call_info): Add initializers.
2390         <si>: Now a std::vector.
2391         (pass_on_stack, aarch64_push_dummy_call): Update.
2392
2393 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2394             Tom Tromey  <tom@tromey.com>
2395
2396         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2397         (ppc_threads): Now a std::vector.  Now static.
2398         (hwdebug_find_thread_points_by_tid)
2399         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2400         Update.
2401
2402 2019-05-04  Tom Tromey  <tom@tromey.com>
2403
2404         * arc-tdep.c (arc_tdesc_init): Return bool.
2405
2406 2019-05-04  Tom Tromey  <tom@tromey.com>
2407
2408         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2409         Use gdb_assert_not_reached.
2410
2411 2019-05-04  Tom Tromey  <tom@tromey.com>
2412
2413         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2414         "false".
2415
2416 2019-05-04  Tom Tromey  <tom@tromey.com>
2417
2418         * arc-tdep.c (arc_tdesc_init): Use bool.
2419
2420 2019-05-04  Tom Tromey  <tom@tromey.com>
2421
2422         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2423
2424 2019-05-04  Tom Tromey  <tom@tromey.com>
2425
2426         * cli/cli-cmds.c (valid_command_p): Return bool.
2427
2428 2019-05-04  Tom Tromey  <tom@tromey.com>
2429
2430         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2431         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2432
2433 2019-05-04  Raul Tambre  <raul@tambre.ee>
2434
2435         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2436         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2437         operator for comparison.
2438
2439 2019-05-04  Tom Tromey  <tom@tromey.com>
2440
2441         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2442         (lookup_partial_symbol, print_partial_symbols)
2443         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2444         (psymbol_compare): Update.
2445         (add_psymbol_to_bcache): Clear the entire psymbol.
2446         (maintenance_check_psymtabs): Update.
2447         * psympriv.h (struct partial_symbol): Don't derive from
2448         general_symbol_info.
2449         <obj_section, unrelocated_address, address,
2450         set_unrelocated_address>: Update.
2451         <ginfo>: New member.
2452         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2453         (debug_names::write_psymbols): Update.
2454
2455 2019-05-04  Tom de Vries  <tdevries@suse.de>
2456
2457         * contrib/cc-with-tweaks.sh: Support -n arg.
2458
2459 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2460
2461         * corelow.c (core_target::detach): Ensure frame cache and
2462         register caches are cleared.
2463         inferior.c (exit_inferior_1): Likewise.
2464
2465 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2466             Tom Tromey  <tom@tromey.com>
2467
2468         * dictionary.c (collate_pending_symbols_by_language): Remove
2469         "struct" from foreach.
2470         * symtab.c (lookup_global_symbol_from_objfile)
2471         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2472         foreach.
2473         * ser-tcp.c (net_open): Remove "struct" from foreach.
2474         * objfiles.c (objfile_relocate, objfile_rebase)
2475         (objfile_has_symbols): Remove "struct" from foreach.
2476         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2477         from foreach.
2478         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2479         foreach.
2480         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2481         "struct" from foreach.
2482         * ada-lang.c (create_excep_cond_exprs)
2483         (ada_exception_catchpoint_cond_string): Remove "struct" from
2484         foreach.
2485
2486 2019-05-03  Tom Tromey  <tromey@adacore.com>
2487
2488         * ada-exp.y (convert_char_literal): Check suffix of each
2489         enumerator.
2490
2491 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2492
2493         PR ada/21406:
2494         * ada-exp.y (yywrap): Don't define.
2495         * ada-lex.l (%option): Add noyywrap
2496         (yywrap): Remove.
2497
2498 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2499
2500         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2501         _WIN32_WINNT to the XP level, unless already defined to a higher
2502         level.
2503
2504         * unittests/parse-connection-spec-selftests.c:
2505         * ser-tcp.c:
2506         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2507         override.
2508
2509         * symfile.c (find_separate_debug_file): Remove colon from the
2510         drive spec of DOS/Windows file names of the target, so that the
2511         file name produced from DEBUGDIR and the target's directory will
2512         be valid on DOS/Windows systems.
2513
2514 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * rust-lang.c (val_print_struct): Handle printing structures
2517         containing strings.
2518
2519 2019-05-02  Tom Tromey  <tromey@adacore.com>
2520
2521         * valarith.c (_initialize_valarith): Remove.
2522
2523 2019-05-01  Tom Tromey  <tromey@adacore.com>
2524
2525         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2526         bitfields.
2527
2528 2019-05-01  Tom Tromey  <tromey@adacore.com>
2529
2530         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2531         for big-endian copies.
2532
2533 2019-04-30  Ali Tamur  <tamur@google.com>
2534         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2535         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2536         (read_3_bytes): New function.
2537
2538 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2539
2540         * windows-nat.c (main_thread_id): Delete.
2541         (handle_output_debug_string): Replace main_thread_id by
2542         current_event.dwThreadId.
2543         (fake_create_process): Likewise.
2544         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2545         Do not set main_thread_id.
2546         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2547         current_event.dwThreadId.
2548         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2549
2550 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2551
2552         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2553         Use current_event.dwThreadId instead of main_thread_id.
2554
2555 2019-04-30  Tom Tromey  <tromey@adacore.com>
2556
2557         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2558         (create_excep_cond_exprs): Iterate over program spaces.
2559         (ada_exception_catchpoint_cond_string): Examine all minimal
2560         symbols for exception types.
2561
2562 2019-04-30  Tom Tromey  <tromey@adacore.com>
2563
2564         PR c++/24470:
2565         * dwarf2read.c (process_structure_scope): Handle case where type
2566         has template parameters but no symbol was created.
2567
2568 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2569             Chris January  <chris.january@arm.com>
2570
2571         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2572         qualifier.
2573         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2574
2575 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2576
2577         * f-typeprint.c (f_print_type): Update rules for printing
2578         whitespace.
2579         (f_type_print_varspec_suffix): Likewise.
2580
2581 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2582             Chris January  <chris.january@arm.com>
2583
2584         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2585         function arguments.
2586
2587 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2588
2589         * f-lang.c (build_fortran_types): Change name of void type to
2590         lower case.
2591         * f-typeprint.c (f_type_print_base): Print the name of the void
2592         type, rather than a fixed string.
2593         * f-valprint.c (f_decorations): Use lower case void string.
2594
2595 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2596             Chris January  <chris.january@arm.com>
2597
2598         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2599         types for Fortran.
2600
2601 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2602             Chris January  <chris.january@arm.com>
2603             David Lecomber  <david.lecomber@arm.com>
2604
2605         * f-exp.y (BINOP_INTRINSIC): New token.
2606         (exp): New parser rule handling BINOP_INTRINSIC.
2607         (f77_keywords): Add new builtin procedures.
2608         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2609         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2610         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2611         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2612         (print_unop_subexp_f): New function.
2613         (print_binop_subexp_f): New function.
2614         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2615         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2616         (dump_subexp_body_f): Likewise.
2617         (operator_check_f): Likewise.
2618         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2619         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2620
2621 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2622
2623         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2624         UNOP_KIND.
2625         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2626         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2627         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2628         (operator_length_f): New fuction.
2629         (print_subexp_f): New function.
2630         (op_name_f): New function.
2631         (dump_subexp_body_f): New function.
2632         (operator_check_f): New function.
2633         (exp_descriptor_f): Replace standard expression handling functions
2634         with new functions.
2635         * gdb/fortran-operator.def: New file.
2636         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2637         * gdb/std-operator.def: Remove UNOP_KIND.
2638
2639 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2640
2641         * std-operator.def: Remove unbalanced, stray double quote
2642         character.
2643
2644 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2645             Chris January  <chris.january@arm.com>
2646             Daniel Everett  <daniel.everett@arm.com>
2647             Nick Forrington  <nick.forrington@arm.com>
2648             Richard Bunt  <richard.bunt@arm.com>
2649
2650         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2651         of depth when printing anonymous structs or unions.
2652         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2653         Don't print either the top-level value, or the children if the
2654         max-depth is exceeded.
2655         (ppscm_print_children): When printing the key of a map, allow one
2656         extra level of depth.
2657         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2658         print either the top-level value, or the children if the max-depth
2659         is exceeded.
2660         (print_children): When printing the key of a map, allow one extra
2661         level of depth.
2662         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2663         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2664         (user_print_options): Initialise max_depth field.
2665         (val_print_scalar_or_string_type_p): New function.
2666         (val_print): Check to see if the max depth has been reached.
2667         (val_print_check_max_depth): Define new function.
2668         (show_print_max_depth): New function.
2669         (_initialize_valprint): Add 'print max-depth' option.
2670         * valprint.h (struct value_print_options) <max_depth>: New field.
2671         (val_print_check_max_depth): Declare new function.
2672         * NEWS: Document new feature.
2673
2674 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2675
2676         * ada-lang.c (ada_language_defn): Initialise new field.
2677         * c-lang.c (c_is_string_type_p): New function.
2678         (c_language_defn): Initialise new field.
2679         (cplus_language_defn): Initialise new field.
2680         (asm_language_defn): Initialise new field.
2681         (minimal_language_defn): Initialise new field.
2682         * c-lang.h (c_is_string_type_p): Declare new function.
2683         * d-lang.c (d_language_defn): Initialise new field.
2684         * f-lang.c (f_is_string_type_p): New function.
2685         (f_language_defn): Initialise new field.
2686         * go-lang.c (go_is_string_type_p): New function.
2687         (go_language_defn): Initialise new field.
2688         * language.c (default_is_string_type_p): New function.
2689         (unknown_language_defn): Initialise new field.
2690         (auto_language_defn): Initialise new field.
2691         * language.h (struct language_defn) <la_is_string_type_p>: New
2692         member variable.
2693         (default_is_string_type_p): Declare new function.
2694         * m2-lang.c (m2_language_defn): Initialise new field.
2695         * objc-lang.c (objc_language_defn): Initialise new field.
2696         * opencl-lang.c (opencl_language_defn): Initialise new field.
2697         * p-lang.c (pascal_is_string_type_p): New function.
2698         (pascal_language_defn): Initialise new field.
2699         * rust-lang.c (rust_is_string_type_p): New function.
2700         (rust_language_defn): Initialise new field.
2701
2702 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2703
2704         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2705         New field.
2706         * ada-lang.c (ada_language_defn): Initialise new field.
2707         * c-lang.c (c_language_defn): Likewise.
2708         (cplus_language_defn): Likewise.
2709         (asm_language_defn): Likewise.
2710         (minimal_language_defn): Likewise.
2711         * d-lang.c (d_language_defn): Likewise.
2712         * f-lang.c (f_language_defn): Likewise.
2713         * go-lang.c (go_language_defn): Likewise.
2714         * language.c (unknown_language_defn): Likewise.
2715         (auto_language_defn): Likewise.
2716         * m2-lang.c (m2_language_defn): Likewise.
2717         * objc-lang.c (objc_language_defn): Likewise.
2718         * opencl-lang.c (opencl_language_defn): Likewise.
2719         * p-lang.c (pascal_language_defn): Likewise.
2720         * rust-lang.c (rust_language_defn): Likewise.
2721
2722 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2723
2724         * ada-lang.c (ada_is_character_type): Change return type to bool.
2725         (ada_is_string_type): Likewise.
2726         * ada-lang.h (ada_is_character_type): Update declaration
2727         (ada_is_string_type): Likewise.
2728
2729 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2730
2731         Support style in 'frame|thread apply'
2732
2733         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2734         * record.c (record_start, record_stop): Update callers of
2735         execute_command_to_string with false.
2736         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2737         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2738         methods.
2739         (class string_file): New constructor with term_out parameter.
2740         Override methods term_out and can_emit_style_escape.  New member
2741         term_out.
2742         (class stdio_file): Override can_emit_style_escape.
2743         (class tee_file): Override term_out and can_emit_style_escape.
2744         * utils.h (can_emit_style_escape): Remove.
2745         * utils.c (can_emit_style_escape): Likewise.
2746         Update all callers of can_emit_style_escape (SOMESTREAM) to
2747         SOMESTREAM->can_emit_style_escape.
2748         * source-cache.c (source_cache::get_source_lines): Likewise.
2749         * stack.c (frame_apply_command_count): Call execute_command_to_string
2750         passing the term_out characteristic of the current gdb_stdout.
2751         * thread.c (thr_try_catch_cmd): Likewise.
2752         * top.c (execute_command_to_string): pass term_out parameter
2753         to construct the string_file for the command output.
2754         * ui-file.c (term_cli_styling): New function (most code moved
2755         from utils.c can_emit_style_escape).
2756         (string_file::string_file, string_file::can_emit_style_escape,
2757         stdio_file::can_emit_style_escape, tee_file::term_out,
2758         tee_file::can_emit_style_escape): New functions.
2759
2760 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2761
2762         * NEWS: Mention the new set|show may-call-functions.
2763         * infcall.c (may_call_functions_p): New variable.
2764         (show_may_call_functions_p): New function.
2765         (call_function_by_hand_dummy): Throws an error if not
2766         may-call-functions.
2767         (_initialize_infcall): Call add_setshow_boolean_cmd for
2768         may-call-functions.
2769
2770 2019-04-25  Keith Seitz  <keiths@redhat.com>
2771
2772         PR c++/24367
2773         * cp-support.c (inspect_type): Don't attempt substitutions
2774         of symbol with the same name.
2775
2776 2019-04-25  Tom Tromey  <tromey@adacore.com>
2777
2778         PR gdb/24475:
2779         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2780         static.
2781
2782 2019-04-25  Tom Tromey  <tromey@adacore.com>
2783
2784         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2785         rvalue reference.
2786         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2787         (gdb_xml_parser::parse): Use std::move.
2788         * python/python-internal.h (gdbpy_convert_exception): Take a const
2789         reference.
2790         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2791         std::move.
2792         * python/py-utils.c (gdbpy_convert_exception): Take a const
2793         reference.
2794         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2795         Use std::move.
2796         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2797         Use std::move.
2798         * mi/mi-main.c (mi_print_exception): Take a const reference.
2799         * main.c (handle_command_errors): Take a const reference.
2800         * linespec.c (parse_linespec): Use std::move.
2801         * infcall.c (run_inferior_call): Use std::move.
2802         (call_function_by_hand_dummy): Use std::move.
2803         * exec.c (try_open_exec_file): Use std::move.
2804         * exceptions.h (exception_print, exception_fprintf)
2805         (exception_print_same): Update.
2806         * exceptions.c (print_exception, exception_print)
2807         (exception_fprintf, exception_print_same): Change parameters to
2808         const reference.
2809         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2810         * common/new-op.c: Use std::move.
2811         * common/common-exceptions.h (struct gdb_exception): Add move
2812         constructor.
2813         (struct gdb_exception_error, struct gdb_exception_quit, struct
2814         gdb_quit_bad_alloc): Change constructor to move constructor.
2815         (throw_exception): Change parameter to rvalue reference.
2816         * common/common-exceptions.c (throw_exception): Take rvalue
2817         reference.
2818         * cli/cli-interp.c (safe_execute_command): Use std::move.
2819         * breakpoint.c (insert_bp_location, location_to_sals): Use
2820         std::move.
2821
2822 2019-04-25  Tom Tromey  <tromey@adacore.com>
2823
2824         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2825         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2826         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2827         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2828         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2829         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2830         guile/scm-value.c: Use unpack.
2831         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2832         gdbscm_gdb_exception.
2833         (gdbscm_throw_gdb_exception): Likewise.
2834         (struct gdbscm_gdb_exception): New.
2835         (unpack): New function.
2836         (gdbscm_wrap): Use unpack.
2837
2838 2019-04-25  Tom Tromey  <tromey@adacore.com>
2839
2840         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2841         (gdb_rl_callback_handler): Use std::move.
2842         * common/common-exceptions.h (struct gdb_exception): Add move
2843         assignment operator.
2844         (throw_exception_sjlj): Change "exception" to const reference.
2845         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2846         (throw_exception_sjlj): Change "exception" to const reference.
2847
2848 2019-04-25  Tom Tromey  <tromey@adacore.com>
2849
2850         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2851         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2852         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2853         Update.
2854         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2855         Update.
2856         * mi/mi-interp.c (mi_interp::exec): Update.
2857         * linespec.c (parse_linespec): Update.
2858         * infcall.c (run_inferior_call): Update.
2859         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2860         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2861         (gdbscm_lookup_global_symbol): Update.
2862         * guile/scm-param.c (gdbscm_parameter_value): Update.
2863         * guile/scm-frame.c (gdbscm_frame_read_register)
2864         (gdbscm_frame_read_var): Update.
2865         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2866         * exec.c (try_open_exec_file): Update.
2867         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2868         (gdb_rl_callback_handler): Update.
2869         * common/common-exceptions.h (exception_none): Don't declare.
2870         * common/common-exceptions.c (exception_none): Don't define.
2871         (struct catcher) <exception>: Update.
2872         * cli/cli-interp.c (safe_execute_command): Update.
2873         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2874
2875 2019-04-25  Ali Tamur  <tamur@google.com>
2876
2877         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2878         (read_attribute_value): Likewise.
2879         (dwarf2_read_addr_index): Update comment.
2880         (read_str_index): Add DW_FORM_strx.
2881         (dwarf2_string_attr): Likewise.
2882         (dwarf2_const_value_attr): Likewise.
2883         (dump_die_shallow): Likewise.
2884         (dwarf2_fetch_constant_bytes): Likewise.
2885         (skip_form_bytes): Likewise.
2886         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2887
2888 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2889
2890         PR corefiles/11608
2891         PR corefiles/18187
2892         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2893         OFFSET.  Verify if current mapping contains an ELF header.
2894         (linux_find_memory_regions_full): Adjust call to
2895         dump_mapping_p.
2896
2897 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2898             Kang Li <kanglictf@gmail.com>
2899
2900         PR gdb/21600
2901
2902         * dwarf2-frame.c (read_initial_length): Be consistent about using
2903         unsigned representation of length.
2904         (decode_frame_entry_1): Likewise.  Check for wraparound of
2905         end pointer as well as buffer overflow.
2906
2907 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2908
2909         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2910         "vq".
2911
2912 2019-04-24  Tom Tromey  <tromey@adacore.com>
2913
2914         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2915
2916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2917
2918         * s12z-tdep.c (s12z_unwind_pc): Delete.
2919         (s12z_unwind_sp): Delete.
2920         (s12z_gdbarch_init): Don't register deleted functions with
2921         gdbarch.
2922
2923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2924
2925         * rl78-tdep.c (rl78_unwind_sp): Delete.
2926         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2927
2928 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2929
2930         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2931         (xstormy16_unwind_pc): Delete.
2932         (xstormy16_dummy_id): Delete.
2933         (xstormy16_gdbarch_init): Don't register deleted functions with
2934         gdbarch.
2935
2936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2937
2938         * vax-tdep.c (vax_unwind_pc): Delete.
2939         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2940
2941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2942
2943         * v850-tdep.c (v850_unwind_sp): Delete.
2944         (v850_unwind_pc): Delete.
2945         (v850_dummy_id): Delete.
2946         (v850_gdbarch_init): Don't register deleted functions with
2947         gdbarch.
2948
2949 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2950
2951         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2952         (tilegx_unwind_pc): Delete.
2953         (tilegx_unwind_dummy_id): Delete.
2954         (tilegx_gdbarch_init): Don't register deleted functions with
2955         gdbarch.
2956
2957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2958
2959         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2960         (tic6x_dummy_id): Delete.
2961         (tic6x_gdbarch_init): Don't register deleted functions with
2962         gdbarch.
2963
2964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2965
2966         * sparc-tdep.c (sparc_unwind_pc): Delete.
2967         (sparc32_gdbarch_init): Don't register deleted function with
2968         gdbarch.
2969
2970 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2971
2972         * sh-tdep.c (sh_unwind_sp): Delete.
2973         (sh_unwind_pc): Delete.
2974         (sh_dummy_id): Delete.
2975         (sh_gdbarch_init): Don't register deleted functions with
2976         gdbarch.
2977
2978 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2979
2980         * score-tdep.c (score_unwind_sp): Delete.
2981         (score_unwind_pc): Delete.
2982         (score_dummy_id): Delete.
2983         (score_gdbarch_init): Don't register deleted functions with
2984         gdbarch.
2985
2986 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2987
2988         * rx-tdep.c (rx_unwind_pc): Delete.
2989         (rx_unwind_sp): Delete.
2990         (rx_dummy_id): Delete.
2991         (rx_gdbarch_init): Don't register deleted functions with
2992         gdbarch.  Update comment.
2993
2994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2995
2996         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2997         (rs6000_dummy_id): Delete.
2998         (rs6000_gdbarch_init): Don't register deleted functions with
2999         gdbarch.
3000
3001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3002
3003         * or1k-tdep.c (or1k_dummy_id): Delete.
3004         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3005
3006 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3007
3008         * nios2-tdep.c (nios2_dummy_id): Delete.
3009         (nios2_unwind_sp): Delete.
3010         (nios2_gdbarch_init): Don't register deleted functions with
3011         gdbarch.
3012
3013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3014
3015         * nds32-tdep.c (nds32_dummy_id): Delete.
3016         (nds32_unwind_pc): Delete.
3017         (nds32_unwind_sp): Delete.
3018         (nds32_gdbarch_init): Don't register deleted functions with
3019         gdbarch.
3020
3021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3022
3023         * msp430-tdep.c (msp430_unwind_pc): Delete.
3024         (msp430_unwind_sp): Delete.
3025         (msp430_dummy_id): Delete.
3026         (msp430_gdbarch_init): Don't register deleted functions with
3027         gdbarch.
3028
3029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3030
3031         * moxie-tdep.c (moxie_unwind_sp): Delete.
3032         (moxie_unwind_pc): Delete.
3033         (moxie_dummy_id): Delete.
3034         (moxie_gdbarch_init): Don't register deleted functions with
3035         gdbarch.
3036
3037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3038
3039         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3040         (mn10300_unwind_pc): Delete.
3041         (mn10300_unwind_sp): Delete.
3042         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3043         mn10300_unwind_sp.
3044         (mn10300_frame_unwind_init): Don't register deleted functions with
3045         gdbarch.
3046
3047 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3048
3049         * mep-tdep.c (mep_unwind_pc): Delete.
3050         (mep_unwind_sp): Delete.
3051         (mep_dummy_id): Delete.
3052         (mep_gdbarch_init): Don't register deleted functions with
3053         gdbarch.
3054
3055 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3056
3057         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3058         (m68hc11_unwind_sp): Delete.
3059         (m68hc11_gdbarch_init): Don't register deleted functions with
3060         gdbarch.
3061
3062 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3063
3064         * m32r-tdep.c (m32r_unwind_sp): Delete.
3065         (m32r_unwind_pc): Delete.
3066         (m32r_dummy_id): Delete.
3067         (m32r_gdbarch_init): Don't register deleted functions with
3068         gdbarch.
3069
3070 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3071
3072         * m32c-tdep.c (m32c_unwind_pc): Delete.
3073         (m32c_unwind_sp): Delete.
3074         (m32c_dummy_id): Delete.
3075         (m32c_gdbarch_init): Don't register deleted functions with
3076         gdbarch.
3077
3078 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3079
3080         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3081         (lm32_unwind_pc): Delete.
3082         (lm32_dummy_id): Delete.
3083         (lm32_gdbarch_init): Don't register deleted functions with
3084         gdbarch.
3085
3086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3087
3088         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3089         (iq2000_unwind_pc): Delete.
3090         (iq2000_dummy_id): Delete.
3091         (iq2000_gdbarch_init): Don't register deleted functions with
3092         gdbarch.
3093
3094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3095
3096         * nds32-tdep.c (nds32_type_align): Delete.
3097         (nds32_push_dummy_call): Use type_align instead.
3098
3099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3100
3101         * arm-tdep.c (arm_type_align): Only handle vector override case.
3102         (arm_push_dummy_call): Use type_align.
3103         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3104
3105 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3106
3107         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3108         case.
3109         (pass_on_stack): Use type_align.
3110         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3111         function.
3112
3113 2019-04-23  Tom Tromey  <tromey@adacore.com>
3114
3115         * dwarf2read.c (line_header::file_name_at): Remove unused
3116         overload.
3117
3118 2019-04-23  Tom de Vries  <tdevries@suse.de>
3119
3120         PR gdb/24438
3121         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3122         invocation.
3123
3124
3125 2019-03-27  Ali Tamur  <tamur@google.com>
3126
3127         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3128         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3129         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3130         (dwarf_expr_context::get_addr_index): Likewise
3131         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3132         (symbol_needs_eval_context::get_addr_index): Likewise
3133         (disassemble_dwarf_expression): Add DW_OP_addrx
3134         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3135         (read_cutu_die_from_dwo): Update comment
3136         (skip_one_die): Add DW_FORM_addrx
3137         (read_attribute_value): Likewise
3138         (var_decode_location): Add DW_OP_addrx
3139         (dwarf2_const_value_attr): Add DW_FORM_addrx
3140         (dump_die_shallow): Likewise
3141         (dwarf2_fetch_constant_bytes): Likewise
3142         (decode_locdesc): Add DW_OP_addrx
3143         (skip_form_bytes): Add DW_FORM_addrx
3144
3145 2019-04-22  Ali Tamur  <tamur@google.com>
3146
3147         * MAINTAINERS (Write After Approval): Add self.
3148
3149 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3150
3151         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3152         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3153         (open_symbol_file_object): Likewise.
3154         (svr4_default_sos): Add info parameter.
3155         (svr4_read_so_list): Likewise.
3156         (svr4_current_sos_direct): Adjust functions calls to pass down
3157         info.
3158         (svr4_current_sos_1): Add info parameter.
3159         (svr4_current_sos): Call get_svr4_info, pass info down to
3160         svr4_current_sos_1.
3161         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3162         get_svr4_info.
3163         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3164         get_svr4_info.
3165         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3166         to get_svr4_info.
3167         (probes_table_remove_objfile_probes): Likewise.
3168         (register_solib_event_probe): Add info parameter.
3169         (solist_update_incremental): Pass info parameter down to
3170         svr4_read_so_list.
3171         (disable_probes_interface): Add info parameter.
3172         (svr4_handle_solib_event): Pass current_program_space to
3173         get_svr4_info.  Adjust disable_probes_interface cleanup.
3174         (svr4_create_probe_breakpoints): Add info parameter, pass it
3175         down to register_solib_event_probe.
3176         (svr4_create_solib_event_breakpoints): Add info parameter,
3177         pass it down to svr4_create_probe_breakpoints.
3178         (enable_break): Pass info down to
3179         svr4_create_solib_event_breakpoints.
3180         (svr4_solib_create_inferior_hook): Pass current_program_space to
3181         get_svr4_info.
3182         (svr4_clear_solib): Likewise.
3183
3184 2019-04-22  Pedro Alves  <palves@redhat.com>
3185
3186         * solib-svr4.c (svr4_free_objfile_observer): New.
3187         (probe_and_action::objfile): New field.
3188         (probes_table_htab_remove_objfile_probes)
3189         (probes_table_remove_objfile_probes): New functions.
3190         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3191         in the new probe_and_action.  Don't store the probe in 'lookup'.
3192         (svr4_create_probe_breakpoints): Pass objfile to
3193         register_solib_event_probe.
3194         (_initialize_svr4_solib): Register a free_objfile observer.
3195
3196 2019-04-19  Tom Tromey  <tom@tromey.com>
3197
3198         * common/queue.h: Remove.
3199
3200 2019-04-19  Tom Tromey  <tom@tromey.com>
3201
3202         * event-loop.c: Don't include "common/queue.h".
3203
3204 2019-04-19  Tom Tromey  <tom@tromey.com>
3205
3206         * remote.c (remote_target): Use delete.
3207         * remote-notif.h: Include <list>, not "common/queue.h".
3208         (notif_client_p): Remove typedef.
3209         (remote_notif_state): Add constructor, destructor, initializer.
3210         <notif_queue>: Now a std::list.
3211         (remote_notif_state_xfree): Don't declare.
3212         * remote-notif.c (remote_notif_process, handle_notification)
3213         (remote_notif_state_allocate): Update.
3214         (~remote_notif_state): Rename from remote_notif_state_xfree.
3215
3216 2019-04-19  Tom Tromey  <tom@tromey.com>
3217
3218         * symfile.c (reread_symbols): Update.
3219         * objfiles.c (objfile_register_static_link)
3220         (objfile_lookup_static_link): Update
3221         (~objfile) Don't delete static_links.
3222         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3223
3224 2019-04-19  Tom Tromey  <tom@tromey.com>
3225
3226         * type-stack.h (struct type_stack) <insert>: Constify string.
3227         * type-stack.c (type_stack::insert): Constify string.
3228         * gdbtypes.h (lookup_template_type): Update.
3229         (address_space_name_to_int): Update.
3230         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3231         const.
3232         (lookup_template_type): Make name const.
3233         * c-exp.y: Update rules.
3234         (lex_one_token, classify_name, classify_inner_name)
3235         (c_print_token): Update.
3236         * p-exp.y: Update rules.
3237         (yylex): Update.
3238         * f-exp.y: Update rules.
3239         (yylex): Update.
3240         * d-exp.y: Update rules.
3241         (lex_one_token, classify_name, classify_inner_name): Update.
3242         * parse.c (write_dollar_variable, copy_name): Return std::string.
3243         * parser-defs.h (copy_name): Change return type.
3244         * m2-exp.y: Update rules.
3245         (yylex): Update.
3246         * go-exp.y (lex_one_token): Update.
3247         Update rules.
3248         (classify_unsafe_function, classify_packaged_name)
3249         (classify_name, yylex): Update.
3250
3251 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3252
3253         * configure.ac: add --enable-source-highlight switch.
3254         * configure: Regenerate.
3255         * top.c (print_gdb_version): plumb --enable-source-highlight
3256         status to "show configuration".
3257
3258 2019-04-19  Tom Tromey  <tromey@adacore.com>
3259
3260         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3261         Check ADA_TYPE_P.
3262         (empty_record, ada_template_to_fixed_record_type_1)
3263         (template_to_static_fixed_type)
3264         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3265         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3266         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3267         macros.
3268
3269 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3270
3271         PR symtab/24423:
3272         * source.c (print_source_lines_base): Advance "iter" when a
3273         control character is seen.
3274
3275 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3276
3277         * inferior.h (struct infcall_suspend_state_deleter):
3278         Catch exception in destructor to avoid crash.
3279
3280 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3281
3282         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3283         close to the add_com "shell".
3284
3285 2019-04-18  Tom Tromey  <tromey@adacore.com>
3286
3287         * process-stratum-target.h (class process_stratum_target)
3288         <stratum>: Add "final".
3289
3290 2019-04-17  Tom Tromey  <tromey@adacore.com>
3291
3292         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3293         against nullptr before use.
3294
3295 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3296
3297         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3298
3299 2019-04-17  Jim Wilson  <jimw@sifive.com>
3300             Andrew Burgess  <andrew.burgess@embecosm.com>
3301
3302         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3303         code read might fail, assume 4-byte breakpoint in that case.
3304
3305 2019-04-15  Leszek Swirski  <leszeks@google.com>
3306
3307         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3308         rather than a hand-rolled POD check when checking for forced MEMORY
3309         classification.
3310
3311 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3312
3313         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3314         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3315         function.
3316         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3317         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3318         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3319         declaration.
3320
3321 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3322
3323         * aarch64-linux-nat.c
3324         (aarch64_linux_nat_target::thread_architecture): Add override.
3325         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3326         each VQ.
3327
3328 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3329
3330         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3331
3332 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3333
3334         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3335         target types of size 96-bits, add some additional comments, and
3336         check that the builtin type we found was the correct size.
3337
3338 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3339
3340         * utils.c (prompt_for_continue): Don't restore the styling at the
3341         end, as applied_style has the wrong value.  This fixes styling in
3342         long lists of file names that are interrupted by the "Continue?"
3343         prompt.
3344
3345 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3346
3347         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3348         * c-lang.c (c_language_defn): Likewise.
3349         (cplus_language_defn): Likewise.
3350         (asm_language_defn): Likewise.
3351         (minimal_language_defn): Likewise.
3352         * d-lang.c (d_language_defn): Likewise.
3353         * f-lang.c (f_language_defn): Likewise.
3354         * go-lang.c (go_language_defn): Likewise.
3355         * language.c (unknown_language_defn): Likewise.
3356         (auto_language_defn): Likewise.
3357         * language.h (struct language_defn): Remove la_magic field.
3358         (LANG_MAGIC): Delete.
3359         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3360         * objc-lang.c (objc_language_defn): Likewise.
3361         * opencl-lang.c (opencl_language_defn): Likewise.
3362         * p-lang.c (pascal_language_defn): Likewise.
3363         * rust-lang.c (rust_language_defn): Likewise.
3364
3365 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3366
3367         * riscv-tdep.c (riscv_type_align): New function.
3368         (riscv_type_alignment): Delete.
3369         (riscv_arg_location): Use 'type_align'.
3370         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3371
3372 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3373
3374         * gdbtypes.c (type_align): A struct with no non-static fields also
3375         has alignment of 1.
3376
3377 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3378
3379         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3380         component to 0.
3381         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3382         member.
3383         (riscv_struct_info::analyse): New implementation using new
3384         analyse_inner member function.
3385         (riscv_struct_info::field_offset): New member function.
3386         (riscv_struct_info::m_offsets): New member variable.
3387         (riscv_struct_info::analyse_inner): New private member function,
3388         takes the old implementation of riscv_struct_info::analyse but
3389         extended to track field offsets.
3390         (riscv_call_arg_struct): Update the struct folding special cases
3391         to handle cases where empty C++ structs, which are non-zero
3392         length, are found.
3393         (riscv_arg_location): Initialise the length of each location, a
3394         non-zero length now indicates the location is in use.
3395         (riscv_push_dummy_call): Allow for the first location having a
3396         non-zero offset when setting up arguments.
3397         (riscv_return_value): Likewise, but for return values.
3398
3399 2019-04-11  Tom Tromey  <tromey@adacore.com>
3400
3401         * utils.c (internal_vproblem): Make "msg" const.
3402
3403 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3404
3405         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3406         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3407         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3408         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3409
3410 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3411
3412         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3413         function.
3414         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3415         of amd64_collect_native_gregset.
3416         (amd64_linux_nat_target::store_registers): Likewise.
3417
3418 2019-04-10  Tom Tromey  <tom@tromey.com>
3419
3420         * symtab.c (lookup_global_symbol_from_objfile)
3421         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3422         * objfiles.h (class separate_debug_iterator): New.
3423         (class separate_debug_range): New.
3424         (struct objfile) <separate_debug_objfiles>: New method.
3425         (objfile_separate_debug_iterate): Don't declare.
3426         * objfiles.c (separate_debug_iterator::operator++): Rename from
3427         objfile_separate_debug_iterate.
3428         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3429         iterator.
3430         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3431         iterator.
3432
3433 2019-04-10  Tom Tromey  <tom@tromey.com>
3434
3435         * symfile.c (reread_symbols): Remove old comment.
3436         * objfiles.c (free_all_objfiles): Fix a typo.
3437
3438 2019-04-10  Tom Tromey  <tom@tromey.com>
3439
3440         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3441         * minsyms.c (lookup_minimal_symbol): Use foreach.
3442         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3443         (lookup_minimal_symbol_solib_trampoline): Likewise.
3444         * symfile.c (reread_symbols): Use foreach.
3445
3446 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3447             Tom Tromey  <tromey@adacore.com>
3448
3449         PR rust/24414:
3450         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3451         (rust_lex_int_test): Change "value" to be LONGEST.
3452         (rust_lex_tests): Add test for long integer literal.
3453
3454 2019-04-09  Tom Tromey  <tromey@adacore.com>
3455
3456         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3457         to bool.
3458         (extended_remote_target::attach): Update.
3459         (remote_target::remote_notice_new_inferior): Update.
3460         (remote_target::add_current_inferior_and_thread): Update.
3461         * inferior.c (exit_inferior_1): Use "false".
3462         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3463
3464 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3465
3466         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3467         the "start" command.
3468
3469 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3470
3471         * python/py-inferior.c (infpy_thread_from_thread_handle):
3472         Adjust comments to reflect renaming of thread_from_thread_handle
3473         to thread_from_handle.  Adjust keywords.  Fix type error message.
3474         (inferior_object_methods): Add thread_from_handle.  Retain
3475         thread_from_thread_handle, but mark it as deprecated.
3476
3477 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3478
3479         * gdbthread.h (find_thread_by_handle): Revise declaration.
3480         * thread.c (find_thread_by_handle): Likewise.  Adjust
3481         implementation too.
3482         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3483         support for buffer objects as handles.
3484
3485 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3486
3487         * python/py-infthread.c (thpy_thread_handle): New function.
3488         (thread_object_methods): Register thpy_thread_handle.
3489
3490 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3491
3492         * gdbthread.h (thread_to_thread_handle): Declare.
3493         * thread.c (gdbtypes.h): Include.
3494         (thread_to_thread_handle): New function.
3495
3496         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3497         (target_thread_info_to_thread_handle): Declare.
3498         * target.c (target_thread_info_to_thread_handle): New function.
3499         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3500         * target-delegates.c: Regenerate.
3501
3502         * linux-thread-db.c (class thread_db_target): Add method
3503         thread_info_to_thread_handle.
3504         (thread_db_target::thread_info_to_thread_handle): Define.
3505         * remote.c (class remote_target): Add new method
3506         thread_info_to_thread_handle.
3507         (remote_target::thread_info_to_thread_handle): Define.
3508
3509 2019-04-08  Pedro Alves  <palves@redhat.com>
3510
3511         * common/common-exceptions.c (throw_exception): Don't create
3512         named object to throw; throw directly.
3513         (throw_it): Likewise.  Don't initialize gdb_exception::message
3514         here, with new; pass FMT and AP to the ctor instead.
3515         * common/common-exceptions.h: Include <string>.
3516         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3517         const char *, va_list)): New ctor.  Use std::make_shared.
3518         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3519         errors)): Delete.
3520         (gdb_exception_error::gdb_exception_error(enum errors, const char
3521         *, va_list)): New.
3522         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3523         Add assertion.
3524         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3525         errors)): Delete.
3526         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3527         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3528         Add assertion.
3529
3530 2019-04-08  Tom Tromey  <tom@tromey.com>
3531
3532         * valops.c (value_rtti_indirect_type): Replace throw_exception
3533         with throw.
3534         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3535         with throw.
3536         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3537         throw.
3538         * target.c (target_translate_tls_address): Replace throw_exception
3539         with throw.
3540         * stack.c (frame_apply_command_count): Replace throw_exception
3541         with throw.
3542         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3543         throw.
3544         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3545         with throw.
3546         * rs6000-tdep.c (rs6000_frame_cache)
3547         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3548         * remote.c: Replace throw_exception with throw.
3549         * record-full.c (record_full_message, record_full_wait_1)
3550         (record_full_restore): Replace throw_exception with throw.
3551         * record-btrace.c:
3552         (get_thread_current_frame_id, record_btrace_start_replaying)
3553         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3554         (cmd_record_btrace_start): Replace throw_exception with throw.
3555         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3556         throw.
3557         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3558         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3559         * linespec.c:
3560         (find_linespec_symbols): Replace throw_exception with throw.
3561         * infrun.c (displaced_step_prepare, resume): Replace
3562         throw_exception with throw.
3563         * infcmd.c (post_create_inferior): Replace throw_exception with
3564         throw.
3565         * inf-loop.c (inferior_event_handler): Replace throw_exception
3566         with throw.
3567         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3568         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3569         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3570         (get_prev_frame_always, get_frame_pc_if_available)
3571         (get_frame_address_in_block_if_available, get_frame_language):
3572         Replace throw_exception with throw.
3573         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3574         throw_exception with throw.
3575         * eval.c (fetch_subexp_value, evaluate_var_value)
3576         (evaluate_funcall, evaluate_subexp_standard): Replace
3577         throw_exception with throw.
3578         * dwarf2loc.c (call_site_find_chain)
3579         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3580         Replace throw_exception with throw.
3581         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3582         with throw.
3583         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3584         throw.
3585         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3586         * completer.c (complete_line_internal): Replace throw_exception
3587         with throw.
3588         * compile/compile-object-run.c (compile_object_run): Replace
3589         throw_exception with throw.
3590         * cli/cli-script.c (process_next_line): Replace throw_exception
3591         with throw.
3592         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3593         (btrace_enable, btrace_maint_update_pt_packets): Replace
3594         throw_exception with throw.
3595         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3596         throw_exception with throw.
3597         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3598         throw_exception with throw.
3599         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3600         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3601         * aarch64-tdep.c (aarch64_make_prologue_cache)
3602         (aarch64_make_stub_cache): Replace throw_exception with throw.
3603
3604 2019-04-08  Tom Tromey  <tom@tromey.com>
3605
3606         * common/common-exceptions.c (throw_exception): Rename from
3607         throw_exception_cxx.  Remove old copy.  Make argument const.
3608         (throw_it): Create and throw exception objects directly.
3609         * common/common-exceptions.h (throw_exception): Make argument
3610         const.
3611         (struct gdb_exception_error): Add constructor.
3612         (struct gdb_exception_quit): Add constructor.
3613
3614 2019-04-08  Tom Tromey  <tom@tromey.com>
3615
3616         * common/common-exceptions.h (exception_rethrow): Don't declare.
3617         (TRY_SJLJ): Update comment.
3618         (TRY, CATCH, END_CATCH): Remove.
3619         * common/common-exceptions.c (exception_rethrow): Remove.
3620
3621 2019-04-08  Tom Tromey  <tom@tromey.com>
3622
3623         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3624         Remove.
3625         (gdb_exception_error): Rename from
3626         gdb_exception_RETURN_MASK_ERROR.
3627         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3628         (gdb_quit_bad_alloc): Update.
3629         * aarch64-tdep.c: Update.
3630         * ada-lang.c: Update.
3631         * ada-typeprint.c: Update.
3632         * ada-valprint.c: Update.
3633         * amd64-tdep.c: Update.
3634         * arch-utils.c: Update.
3635         * break-catch-throw.c: Update.
3636         * breakpoint.c: Update.
3637         * btrace.c: Update.
3638         * c-varobj.c: Update.
3639         * cli/cli-cmds.c: Update.
3640         * cli/cli-interp.c: Update.
3641         * cli/cli-script.c: Update.
3642         * common/common-exceptions.c: Update.
3643         * common/new-op.c: Update.
3644         * common/selftest.c: Update.
3645         * compile/compile-c-symbols.c: Update.
3646         * compile/compile-cplus-symbols.c: Update.
3647         * compile/compile-object-load.c: Update.
3648         * compile/compile-object-run.c: Update.
3649         * completer.c: Update.
3650         * corelow.c: Update.
3651         * cp-abi.c: Update.
3652         * cp-support.c: Update.
3653         * cp-valprint.c: Update.
3654         * darwin-nat.c: Update.
3655         * disasm-selftests.c: Update.
3656         * dtrace-probe.c: Update.
3657         * dwarf-index-cache.c: Update.
3658         * dwarf-index-write.c: Update.
3659         * dwarf2-frame-tailcall.c: Update.
3660         * dwarf2-frame.c: Update.
3661         * dwarf2loc.c: Update.
3662         * dwarf2read.c: Update.
3663         * eval.c: Update.
3664         * event-loop.c: Update.
3665         * event-top.c: Update.
3666         * exec.c: Update.
3667         * f-valprint.c: Update.
3668         * fbsd-tdep.c: Update.
3669         * frame-unwind.c: Update.
3670         * frame.c: Update.
3671         * gdbtypes.c: Update.
3672         * gnu-v3-abi.c: Update.
3673         * guile/guile-internal.h: Update.
3674         * guile/scm-block.c: Update.
3675         * guile/scm-breakpoint.c: Update.
3676         * guile/scm-cmd.c: Update.
3677         * guile/scm-disasm.c: Update.
3678         * guile/scm-frame.c: Update.
3679         * guile/scm-lazy-string.c: Update.
3680         * guile/scm-math.c: Update.
3681         * guile/scm-param.c: Update.
3682         * guile/scm-ports.c: Update.
3683         * guile/scm-pretty-print.c: Update.
3684         * guile/scm-symbol.c: Update.
3685         * guile/scm-symtab.c: Update.
3686         * guile/scm-type.c: Update.
3687         * guile/scm-value.c: Update.
3688         * i386-linux-tdep.c: Update.
3689         * i386-tdep.c: Update.
3690         * inf-loop.c: Update.
3691         * infcall.c: Update.
3692         * infcmd.c: Update.
3693         * infrun.c: Update.
3694         * jit.c: Update.
3695         * language.c: Update.
3696         * linespec.c: Update.
3697         * linux-fork.c: Update.
3698         * linux-nat.c: Update.
3699         * linux-tdep.c: Update.
3700         * linux-thread-db.c: Update.
3701         * main.c: Update.
3702         * mi/mi-cmd-break.c: Update.
3703         * mi/mi-cmd-stack.c: Update.
3704         * mi/mi-interp.c: Update.
3705         * mi/mi-main.c: Update.
3706         * objc-lang.c: Update.
3707         * p-valprint.c: Update.
3708         * parse.c: Update.
3709         * ppc-linux-tdep.c: Update.
3710         * printcmd.c: Update.
3711         * python/py-arch.c: Update.
3712         * python/py-breakpoint.c: Update.
3713         * python/py-cmd.c: Update.
3714         * python/py-finishbreakpoint.c: Update.
3715         * python/py-frame.c: Update.
3716         * python/py-framefilter.c: Update.
3717         * python/py-gdb-readline.c: Update.
3718         * python/py-inferior.c: Update.
3719         * python/py-infthread.c: Update.
3720         * python/py-lazy-string.c: Update.
3721         * python/py-linetable.c: Update.
3722         * python/py-objfile.c: Update.
3723         * python/py-param.c: Update.
3724         * python/py-prettyprint.c: Update.
3725         * python/py-progspace.c: Update.
3726         * python/py-record-btrace.c: Update.
3727         * python/py-record.c: Update.
3728         * python/py-symbol.c: Update.
3729         * python/py-type.c: Update.
3730         * python/py-unwind.c: Update.
3731         * python/py-utils.c: Update.
3732         * python/py-value.c: Update.
3733         * python/python.c: Update.
3734         * record-btrace.c: Update.
3735         * record-full.c: Update.
3736         * remote-fileio.c: Update.
3737         * remote.c: Update.
3738         * riscv-tdep.c: Update.
3739         * rs6000-aix-tdep.c: Update.
3740         * rs6000-tdep.c: Update.
3741         * rust-exp.y: Update.
3742         * rust-lang.c: Update.
3743         * s390-tdep.c: Update.
3744         * selftest-arch.c: Update.
3745         * solib-dsbt.c: Update.
3746         * solib-frv.c: Update.
3747         * solib-spu.c: Update.
3748         * solib-svr4.c: Update.
3749         * solib.c: Update.
3750         * sparc64-linux-tdep.c: Update.
3751         * stack.c: Update.
3752         * symfile-mem.c: Update.
3753         * symmisc.c: Update.
3754         * target.c: Update.
3755         * thread.c: Update.
3756         * top.c: Update.
3757         * tracefile-tfile.c: Update.
3758         * tui/tui.c: Update.
3759         * typeprint.c: Update.
3760         * unittests/cli-utils-selftests.c: Update.
3761         * unittests/parse-connection-spec-selftests.c: Update.
3762         * valops.c: Update.
3763         * valprint.c: Update.
3764         * value.c: Update.
3765         * varobj.c: Update.
3766         * windows-nat.c: Update.
3767         * x86-linux-nat.c: Update.
3768         * xml-support.c: Update.
3769
3770 2019-04-08  Tom Tromey  <tom@tromey.com>
3771
3772         * xml-support.c: Use C++ exception handling.
3773         * x86-linux-nat.c: Use C++ exception handling.
3774         * windows-nat.c: Use C++ exception handling.
3775         * varobj.c: Use C++ exception handling.
3776         * value.c: Use C++ exception handling.
3777         * valprint.c: Use C++ exception handling.
3778         * valops.c: Use C++ exception handling.
3779         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3780         handling.
3781         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3782         * typeprint.c: Use C++ exception handling.
3783         * tui/tui.c: Use C++ exception handling.
3784         * tracefile-tfile.c: Use C++ exception handling.
3785         * top.c: Use C++ exception handling.
3786         * thread.c: Use C++ exception handling.
3787         * target.c: Use C++ exception handling.
3788         * symmisc.c: Use C++ exception handling.
3789         * symfile-mem.c: Use C++ exception handling.
3790         * stack.c: Use C++ exception handling.
3791         * sparc64-linux-tdep.c: Use C++ exception handling.
3792         * solib.c: Use C++ exception handling.
3793         * solib-svr4.c: Use C++ exception handling.
3794         * solib-spu.c: Use C++ exception handling.
3795         * solib-frv.c: Use C++ exception handling.
3796         * solib-dsbt.c: Use C++ exception handling.
3797         * selftest-arch.c: Use C++ exception handling.
3798         * s390-tdep.c: Use C++ exception handling.
3799         * rust-lang.c: Use C++ exception handling.
3800         * rust-exp.y: Use C++ exception handling.
3801         * rs6000-tdep.c: Use C++ exception handling.
3802         * rs6000-aix-tdep.c: Use C++ exception handling.
3803         * riscv-tdep.c: Use C++ exception handling.
3804         * remote.c: Use C++ exception handling.
3805         * remote-fileio.c: Use C++ exception handling.
3806         * record-full.c: Use C++ exception handling.
3807         * record-btrace.c: Use C++ exception handling.
3808         * python/python.c: Use C++ exception handling.
3809         * python/py-value.c: Use C++ exception handling.
3810         * python/py-utils.c: Use C++ exception handling.
3811         * python/py-unwind.c: Use C++ exception handling.
3812         * python/py-type.c: Use C++ exception handling.
3813         * python/py-symbol.c: Use C++ exception handling.
3814         * python/py-record.c: Use C++ exception handling.
3815         * python/py-record-btrace.c: Use C++ exception handling.
3816         * python/py-progspace.c: Use C++ exception handling.
3817         * python/py-prettyprint.c: Use C++ exception handling.
3818         * python/py-param.c: Use C++ exception handling.
3819         * python/py-objfile.c: Use C++ exception handling.
3820         * python/py-linetable.c: Use C++ exception handling.
3821         * python/py-lazy-string.c: Use C++ exception handling.
3822         * python/py-infthread.c: Use C++ exception handling.
3823         * python/py-inferior.c: Use C++ exception handling.
3824         * python/py-gdb-readline.c: Use C++ exception handling.
3825         * python/py-framefilter.c: Use C++ exception handling.
3826         * python/py-frame.c: Use C++ exception handling.
3827         * python/py-finishbreakpoint.c: Use C++ exception handling.
3828         * python/py-cmd.c: Use C++ exception handling.
3829         * python/py-breakpoint.c: Use C++ exception handling.
3830         * python/py-arch.c: Use C++ exception handling.
3831         * printcmd.c: Use C++ exception handling.
3832         * ppc-linux-tdep.c: Use C++ exception handling.
3833         * parse.c: Use C++ exception handling.
3834         * p-valprint.c: Use C++ exception handling.
3835         * objc-lang.c: Use C++ exception handling.
3836         * mi/mi-main.c: Use C++ exception handling.
3837         * mi/mi-interp.c: Use C++ exception handling.
3838         * mi/mi-cmd-stack.c: Use C++ exception handling.
3839         * mi/mi-cmd-break.c: Use C++ exception handling.
3840         * main.c: Use C++ exception handling.
3841         * linux-thread-db.c: Use C++ exception handling.
3842         * linux-tdep.c: Use C++ exception handling.
3843         * linux-nat.c: Use C++ exception handling.
3844         * linux-fork.c: Use C++ exception handling.
3845         * linespec.c: Use C++ exception handling.
3846         * language.c: Use C++ exception handling.
3847         * jit.c: Use C++ exception handling.
3848         * infrun.c: Use C++ exception handling.
3849         * infcmd.c: Use C++ exception handling.
3850         * infcall.c: Use C++ exception handling.
3851         * inf-loop.c: Use C++ exception handling.
3852         * i386-tdep.c: Use C++ exception handling.
3853         * i386-linux-tdep.c: Use C++ exception handling.
3854         * guile/scm-value.c: Use C++ exception handling.
3855         * guile/scm-type.c: Use C++ exception handling.
3856         * guile/scm-symtab.c: Use C++ exception handling.
3857         * guile/scm-symbol.c: Use C++ exception handling.
3858         * guile/scm-pretty-print.c: Use C++ exception handling.
3859         * guile/scm-ports.c: Use C++ exception handling.
3860         * guile/scm-param.c: Use C++ exception handling.
3861         * guile/scm-math.c: Use C++ exception handling.
3862         * guile/scm-lazy-string.c: Use C++ exception handling.
3863         * guile/scm-frame.c: Use C++ exception handling.
3864         * guile/scm-disasm.c: Use C++ exception handling.
3865         * guile/scm-cmd.c: Use C++ exception handling.
3866         * guile/scm-breakpoint.c: Use C++ exception handling.
3867         * guile/scm-block.c: Use C++ exception handling.
3868         * guile/guile-internal.h: Use C++ exception handling.
3869         * gnu-v3-abi.c: Use C++ exception handling.
3870         * gdbtypes.c: Use C++ exception handling.
3871         * frame.c: Use C++ exception handling.
3872         * frame-unwind.c: Use C++ exception handling.
3873         * fbsd-tdep.c: Use C++ exception handling.
3874         * f-valprint.c: Use C++ exception handling.
3875         * exec.c: Use C++ exception handling.
3876         * event-top.c: Use C++ exception handling.
3877         * event-loop.c: Use C++ exception handling.
3878         * eval.c: Use C++ exception handling.
3879         * dwarf2read.c: Use C++ exception handling.
3880         * dwarf2loc.c: Use C++ exception handling.
3881         * dwarf2-frame.c: Use C++ exception handling.
3882         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3883         * dwarf-index-write.c: Use C++ exception handling.
3884         * dwarf-index-cache.c: Use C++ exception handling.
3885         * dtrace-probe.c: Use C++ exception handling.
3886         * disasm-selftests.c: Use C++ exception handling.
3887         * darwin-nat.c: Use C++ exception handling.
3888         * cp-valprint.c: Use C++ exception handling.
3889         * cp-support.c: Use C++ exception handling.
3890         * cp-abi.c: Use C++ exception handling.
3891         * corelow.c: Use C++ exception handling.
3892         * completer.c: Use C++ exception handling.
3893         * compile/compile-object-run.c: Use C++ exception handling.
3894         * compile/compile-object-load.c: Use C++ exception handling.
3895         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3896         * compile/compile-c-symbols.c: Use C++ exception handling.
3897         * common/selftest.c: Use C++ exception handling.
3898         * common/new-op.c: Use C++ exception handling.
3899         * cli/cli-script.c: Use C++ exception handling.
3900         * cli/cli-interp.c: Use C++ exception handling.
3901         * cli/cli-cmds.c: Use C++ exception handling.
3902         * c-varobj.c: Use C++ exception handling.
3903         * btrace.c: Use C++ exception handling.
3904         * breakpoint.c: Use C++ exception handling.
3905         * break-catch-throw.c: Use C++ exception handling.
3906         * arch-utils.c: Use C++ exception handling.
3907         * amd64-tdep.c: Use C++ exception handling.
3908         * ada-valprint.c: Use C++ exception handling.
3909         * ada-typeprint.c: Use C++ exception handling.
3910         * ada-lang.c: Use C++ exception handling.
3911         * aarch64-tdep.c: Use C++ exception handling.
3912
3913 2019-04-08  Tom Tromey  <tom@tromey.com>
3914
3915         * xml-support.c (gdb_xml_parser::parse): Update.
3916         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3917         * value.c (show_convenience): Update.
3918         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3919         (test_parse_flags_qcs): Update.
3920         * thread.c (thr_try_catch_cmd): Update.
3921         * target.c (target_translate_tls_address): Update.
3922         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3923         (info_frame_command_core, frame_apply_command_count): Update.
3924         * rust-exp.y (rust_lex_exception_test): Update.
3925         * riscv-tdep.c (riscv_print_one_register_info): Update.
3926         * remote.c (remote_target::enable_btrace): Update.
3927         * record-btrace.c (record_btrace_enable_warn): Update.
3928         * python/py-utils.c (gdbpy_convert_exception): Update.
3929         * printcmd.c (do_one_display, print_variable_and_value): Update.
3930         * mi/mi-main.c (mi_print_exception): Update.
3931         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3932         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3933         * linux-nat.c (linux_nat_target::attach): Update.
3934         * linux-fork.c (class scoped_switch_fork_info): Update.
3935         * infrun.c (displaced_step_prepare): Update.
3936         * infcall.c (call_function_by_hand_dummy): Update.
3937         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3938         * gnu-v3-abi.c (print_one_vtable): Update.
3939         * frame.c (get_prev_frame_always): Update.
3940         * f-valprint.c (info_common_command_for_block): Update.
3941         * exec.c (try_open_exec_file): Update.
3942         * exceptions.c (print_exception, exception_print)
3943         (exception_fprintf, exception_print_same): Update.
3944         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3945         * dwarf-index-cache.c (index_cache::store)
3946         (index_cache::lookup_gdb_index): Update.
3947         * darwin-nat.c (maybe_cache_shell): Update.
3948         * cp-valprint.c (cp_print_value_fields): Update.
3949         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3950         (gcc_cplus_symbol_address): Update.
3951         * compile/compile-c-symbols.c (gcc_convert_symbol)
3952         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3953         * common/selftest.c: Update.
3954         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3955         a std::string.
3956         (exception_try_scope_entry, exception_try_scope_exit): Don't
3957         declare.
3958         (struct exception_try_scope): Remove.
3959         (TRY): Don't use exception_try_scope.
3960         (struct gdb_exception): Add constructor, operator=.
3961         <what>: New method.
3962         (struct gdb_exception_RETURN_MASK_ALL)
3963         (struct gdb_exception_RETURN_MASK_ERROR)
3964         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3965         (struct gdb_quit_bad_alloc): Update.
3966         * common/common-exceptions.c (exception_none): Change
3967         initializer.
3968         (struct catcher) <state, exception>: Initialize inline.
3969         <prev>: Remove member.
3970         (current_catcher): Remove.
3971         (catchers): New global.
3972         (exceptions_state_mc_init): Simplify.
3973         (catcher_pop): Remove.
3974         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3975         (try_scope_depth, exception_try_scope_entry)
3976         (exception_try_scope_exit): Remove.
3977         (throw_exception_sjlj): Update.
3978         (exception_messages, exception_messages_size): Remove.
3979         (throw_it): Simplify.
3980         (gdb_exception_sliced_copy): Remove.
3981         (throw_exception_cxx): Update.
3982         * cli/cli-script.c (script_from_file): Update.
3983         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3984         Update.
3985         * ada-valprint.c (ada_val_print): Update.
3986         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3987         (create_excep_cond_exprs): Update.
3988
3989 2019-04-08  Tom Tromey  <tom@tromey.com>
3990
3991         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3992         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3993         (TRY, CATCH, END_CATCH): Remove some definitions.
3994         * common/common-exceptions.c: Don't use GDB_XCPT.
3995         (catcher_list_size): Remove.
3996         (throw_exception, throw_it): Simplify.
3997
3998 2019-04-05  Tom Tromey  <tom@tromey.com>
3999
4000         Revert the header-sorting patch.
4001         * ft32-tdep.c: Revert.
4002         * frv-tdep.c: Revert.
4003         * frv-linux-tdep.c: Revert.
4004         * frame.c: Revert.
4005         * frame-unwind.c: Revert.
4006         * frame-base.c: Revert.
4007         * fork-child.c: Revert.
4008         * findvar.c: Revert.
4009         * findcmd.c: Revert.
4010         * filesystem.c: Revert.
4011         * filename-seen-cache.h: Revert.
4012         * filename-seen-cache.c: Revert.
4013         * fbsd-tdep.c: Revert.
4014         * fbsd-nat.h: Revert.
4015         * fbsd-nat.c: Revert.
4016         * f-valprint.c: Revert.
4017         * f-typeprint.c: Revert.
4018         * f-lang.c: Revert.
4019         * extension.h: Revert.
4020         * extension.c: Revert.
4021         * extension-priv.h: Revert.
4022         * expprint.c: Revert.
4023         * exec.h: Revert.
4024         * exec.c: Revert.
4025         * exceptions.c: Revert.
4026         * event-top.c: Revert.
4027         * event-loop.c: Revert.
4028         * eval.c: Revert.
4029         * elfread.c: Revert.
4030         * dwarf2read.h: Revert.
4031         * dwarf2read.c: Revert.
4032         * dwarf2loc.c: Revert.
4033         * dwarf2expr.h: Revert.
4034         * dwarf2expr.c: Revert.
4035         * dwarf2-frame.c: Revert.
4036         * dwarf2-frame-tailcall.c: Revert.
4037         * dwarf-index-write.h: Revert.
4038         * dwarf-index-write.c: Revert.
4039         * dwarf-index-common.c: Revert.
4040         * dwarf-index-cache.h: Revert.
4041         * dwarf-index-cache.c: Revert.
4042         * dummy-frame.c: Revert.
4043         * dtrace-probe.c: Revert.
4044         * disasm.h: Revert.
4045         * disasm.c: Revert.
4046         * disasm-selftests.c: Revert.
4047         * dictionary.c: Revert.
4048         * dicos-tdep.c: Revert.
4049         * demangle.c: Revert.
4050         * dcache.h: Revert.
4051         * dcache.c: Revert.
4052         * darwin-nat.h: Revert.
4053         * darwin-nat.c: Revert.
4054         * darwin-nat-info.c: Revert.
4055         * d-valprint.c: Revert.
4056         * d-namespace.c: Revert.
4057         * d-lang.c: Revert.
4058         * ctf.c: Revert.
4059         * csky-tdep.c: Revert.
4060         * csky-linux-tdep.c: Revert.
4061         * cris-tdep.c: Revert.
4062         * cris-linux-tdep.c: Revert.
4063         * cp-valprint.c: Revert.
4064         * cp-support.c: Revert.
4065         * cp-namespace.c: Revert.
4066         * cp-abi.c: Revert.
4067         * corelow.c: Revert.
4068         * corefile.c: Revert.
4069         * continuations.c: Revert.
4070         * completer.h: Revert.
4071         * completer.c: Revert.
4072         * complaints.c: Revert.
4073         * coffread.c: Revert.
4074         * coff-pe-read.c: Revert.
4075         * cli-out.h: Revert.
4076         * cli-out.c: Revert.
4077         * charset.c: Revert.
4078         * c-varobj.c: Revert.
4079         * c-valprint.c: Revert.
4080         * c-typeprint.c: Revert.
4081         * c-lang.c: Revert.
4082         * buildsym.c: Revert.
4083         * buildsym-legacy.c: Revert.
4084         * build-id.h: Revert.
4085         * build-id.c: Revert.
4086         * btrace.c: Revert.
4087         * bsd-uthread.c: Revert.
4088         * breakpoint.h: Revert.
4089         * breakpoint.c: Revert.
4090         * break-catch-throw.c: Revert.
4091         * break-catch-syscall.c: Revert.
4092         * break-catch-sig.c: Revert.
4093         * blockframe.c: Revert.
4094         * block.c: Revert.
4095         * bfin-tdep.c: Revert.
4096         * bfin-linux-tdep.c: Revert.
4097         * bfd-target.c: Revert.
4098         * bcache.c: Revert.
4099         * ax-general.c: Revert.
4100         * ax-gdb.h: Revert.
4101         * ax-gdb.c: Revert.
4102         * avr-tdep.c: Revert.
4103         * auxv.c: Revert.
4104         * auto-load.c: Revert.
4105         * arm-wince-tdep.c: Revert.
4106         * arm-tdep.c: Revert.
4107         * arm-symbian-tdep.c: Revert.
4108         * arm-pikeos-tdep.c: Revert.
4109         * arm-obsd-tdep.c: Revert.
4110         * arm-nbsd-tdep.c: Revert.
4111         * arm-nbsd-nat.c: Revert.
4112         * arm-linux-tdep.c: Revert.
4113         * arm-linux-nat.c: Revert.
4114         * arm-fbsd-tdep.c: Revert.
4115         * arm-fbsd-nat.c: Revert.
4116         * arm-bsd-tdep.c: Revert.
4117         * arch-utils.c: Revert.
4118         * arc-tdep.c: Revert.
4119         * arc-newlib-tdep.c: Revert.
4120         * annotate.h: Revert.
4121         * annotate.c: Revert.
4122         * amd64-windows-tdep.c: Revert.
4123         * amd64-windows-nat.c: Revert.
4124         * amd64-tdep.c: Revert.
4125         * amd64-sol2-tdep.c: Revert.
4126         * amd64-obsd-tdep.c: Revert.
4127         * amd64-obsd-nat.c: Revert.
4128         * amd64-nbsd-tdep.c: Revert.
4129         * amd64-nbsd-nat.c: Revert.
4130         * amd64-nat.c: Revert.
4131         * amd64-linux-tdep.c: Revert.
4132         * amd64-linux-nat.c: Revert.
4133         * amd64-fbsd-tdep.c: Revert.
4134         * amd64-fbsd-nat.c: Revert.
4135         * amd64-dicos-tdep.c: Revert.
4136         * amd64-darwin-tdep.c: Revert.
4137         * amd64-bsd-nat.c: Revert.
4138         * alpha-tdep.c: Revert.
4139         * alpha-obsd-tdep.c: Revert.
4140         * alpha-nbsd-tdep.c: Revert.
4141         * alpha-mdebug-tdep.c: Revert.
4142         * alpha-linux-tdep.c: Revert.
4143         * alpha-linux-nat.c: Revert.
4144         * alpha-bsd-tdep.c: Revert.
4145         * alpha-bsd-nat.c: Revert.
4146         * aix-thread.c: Revert.
4147         * agent.c: Revert.
4148         * addrmap.c: Revert.
4149         * ada-varobj.c: Revert.
4150         * ada-valprint.c: Revert.
4151         * ada-typeprint.c: Revert.
4152         * ada-tasks.c: Revert.
4153         * ada-lang.c: Revert.
4154         * aarch64-tdep.c: Revert.
4155         * aarch64-ravenscar-thread.c: Revert.
4156         * aarch64-newlib-tdep.c: Revert.
4157         * aarch64-linux-tdep.c: Revert.
4158         * aarch64-linux-nat.c: Revert.
4159         * aarch64-fbsd-tdep.c: Revert.
4160         * aarch64-fbsd-nat.c: Revert.
4161         * aarch32-linux-nat.c: Revert.
4162
4163 2019-04-05  Tom Tromey  <tom@tromey.com>
4164
4165         * ft32-tdep.c: Sort headers.
4166         * frv-tdep.c: Sort headers.
4167         * frv-linux-tdep.c: Sort headers.
4168         * frame.c: Sort headers.
4169         * frame-unwind.c: Sort headers.
4170         * frame-base.c: Sort headers.
4171         * fork-child.c: Sort headers.
4172         * findvar.c: Sort headers.
4173         * findcmd.c: Sort headers.
4174         * filesystem.c: Sort headers.
4175         * filename-seen-cache.h: Sort headers.
4176         * filename-seen-cache.c: Sort headers.
4177         * fbsd-tdep.c: Sort headers.
4178         * fbsd-nat.h: Sort headers.
4179         * fbsd-nat.c: Sort headers.
4180         * f-valprint.c: Sort headers.
4181         * f-typeprint.c: Sort headers.
4182         * f-lang.c: Sort headers.
4183         * extension.h: Sort headers.
4184         * extension.c: Sort headers.
4185         * extension-priv.h: Sort headers.
4186         * expprint.c: Sort headers.
4187         * exec.h: Sort headers.
4188         * exec.c: Sort headers.
4189         * exceptions.c: Sort headers.
4190         * event-top.c: Sort headers.
4191         * event-loop.c: Sort headers.
4192         * eval.c: Sort headers.
4193         * elfread.c: Sort headers.
4194         * dwarf2read.h: Sort headers.
4195         * dwarf2read.c: Sort headers.
4196         * dwarf2loc.c: Sort headers.
4197         * dwarf2expr.h: Sort headers.
4198         * dwarf2expr.c: Sort headers.
4199         * dwarf2-frame.c: Sort headers.
4200         * dwarf2-frame-tailcall.c: Sort headers.
4201         * dwarf-index-write.h: Sort headers.
4202         * dwarf-index-write.c: Sort headers.
4203         * dwarf-index-common.c: Sort headers.
4204         * dwarf-index-cache.h: Sort headers.
4205         * dwarf-index-cache.c: Sort headers.
4206         * dummy-frame.c: Sort headers.
4207         * dtrace-probe.c: Sort headers.
4208         * disasm.h: Sort headers.
4209         * disasm.c: Sort headers.
4210         * disasm-selftests.c: Sort headers.
4211         * dictionary.c: Sort headers.
4212         * dicos-tdep.c: Sort headers.
4213         * demangle.c: Sort headers.
4214         * dcache.h: Sort headers.
4215         * dcache.c: Sort headers.
4216         * darwin-nat.h: Sort headers.
4217         * darwin-nat.c: Sort headers.
4218         * darwin-nat-info.c: Sort headers.
4219         * d-valprint.c: Sort headers.
4220         * d-namespace.c: Sort headers.
4221         * d-lang.c: Sort headers.
4222         * ctf.c: Sort headers.
4223         * csky-tdep.c: Sort headers.
4224         * csky-linux-tdep.c: Sort headers.
4225         * cris-tdep.c: Sort headers.
4226         * cris-linux-tdep.c: Sort headers.
4227         * cp-valprint.c: Sort headers.
4228         * cp-support.c: Sort headers.
4229         * cp-namespace.c: Sort headers.
4230         * cp-abi.c: Sort headers.
4231         * corelow.c: Sort headers.
4232         * corefile.c: Sort headers.
4233         * continuations.c: Sort headers.
4234         * completer.h: Sort headers.
4235         * completer.c: Sort headers.
4236         * complaints.c: Sort headers.
4237         * coffread.c: Sort headers.
4238         * coff-pe-read.c: Sort headers.
4239         * cli-out.h: Sort headers.
4240         * cli-out.c: Sort headers.
4241         * charset.c: Sort headers.
4242         * c-varobj.c: Sort headers.
4243         * c-valprint.c: Sort headers.
4244         * c-typeprint.c: Sort headers.
4245         * c-lang.c: Sort headers.
4246         * buildsym.c: Sort headers.
4247         * buildsym-legacy.c: Sort headers.
4248         * build-id.h: Sort headers.
4249         * build-id.c: Sort headers.
4250         * btrace.c: Sort headers.
4251         * bsd-uthread.c: Sort headers.
4252         * breakpoint.h: Sort headers.
4253         * breakpoint.c: Sort headers.
4254         * break-catch-throw.c: Sort headers.
4255         * break-catch-syscall.c: Sort headers.
4256         * break-catch-sig.c: Sort headers.
4257         * blockframe.c: Sort headers.
4258         * block.c: Sort headers.
4259         * bfin-tdep.c: Sort headers.
4260         * bfin-linux-tdep.c: Sort headers.
4261         * bfd-target.c: Sort headers.
4262         * bcache.c: Sort headers.
4263         * ax-general.c: Sort headers.
4264         * ax-gdb.h: Sort headers.
4265         * ax-gdb.c: Sort headers.
4266         * avr-tdep.c: Sort headers.
4267         * auxv.c: Sort headers.
4268         * auto-load.c: Sort headers.
4269         * arm-wince-tdep.c: Sort headers.
4270         * arm-tdep.c: Sort headers.
4271         * arm-symbian-tdep.c: Sort headers.
4272         * arm-pikeos-tdep.c: Sort headers.
4273         * arm-obsd-tdep.c: Sort headers.
4274         * arm-nbsd-tdep.c: Sort headers.
4275         * arm-nbsd-nat.c: Sort headers.
4276         * arm-linux-tdep.c: Sort headers.
4277         * arm-linux-nat.c: Sort headers.
4278         * arm-fbsd-tdep.c: Sort headers.
4279         * arm-fbsd-nat.c: Sort headers.
4280         * arm-bsd-tdep.c: Sort headers.
4281         * arch-utils.c: Sort headers.
4282         * arc-tdep.c: Sort headers.
4283         * arc-newlib-tdep.c: Sort headers.
4284         * annotate.h: Sort headers.
4285         * annotate.c: Sort headers.
4286         * amd64-windows-tdep.c: Sort headers.
4287         * amd64-windows-nat.c: Sort headers.
4288         * amd64-tdep.c: Sort headers.
4289         * amd64-sol2-tdep.c: Sort headers.
4290         * amd64-obsd-tdep.c: Sort headers.
4291         * amd64-obsd-nat.c: Sort headers.
4292         * amd64-nbsd-tdep.c: Sort headers.
4293         * amd64-nbsd-nat.c: Sort headers.
4294         * amd64-nat.c: Sort headers.
4295         * amd64-linux-tdep.c: Sort headers.
4296         * amd64-linux-nat.c: Sort headers.
4297         * amd64-fbsd-tdep.c: Sort headers.
4298         * amd64-fbsd-nat.c: Sort headers.
4299         * amd64-dicos-tdep.c: Sort headers.
4300         * amd64-darwin-tdep.c: Sort headers.
4301         * amd64-bsd-nat.c: Sort headers.
4302         * alpha-tdep.c: Sort headers.
4303         * alpha-obsd-tdep.c: Sort headers.
4304         * alpha-nbsd-tdep.c: Sort headers.
4305         * alpha-mdebug-tdep.c: Sort headers.
4306         * alpha-linux-tdep.c: Sort headers.
4307         * alpha-linux-nat.c: Sort headers.
4308         * alpha-bsd-tdep.c: Sort headers.
4309         * alpha-bsd-nat.c: Sort headers.
4310         * aix-thread.c: Sort headers.
4311         * agent.c: Sort headers.
4312         * addrmap.c: Sort headers.
4313         * ada-varobj.c: Sort headers.
4314         * ada-valprint.c: Sort headers.
4315         * ada-typeprint.c: Sort headers.
4316         * ada-tasks.c: Sort headers.
4317         * ada-lang.c: Sort headers.
4318         * aarch64-tdep.c: Sort headers.
4319         * aarch64-ravenscar-thread.c: Sort headers.
4320         * aarch64-newlib-tdep.c: Sort headers.
4321         * aarch64-linux-tdep.c: Sort headers.
4322         * aarch64-linux-nat.c: Sort headers.
4323         * aarch64-fbsd-tdep.c: Sort headers.
4324         * aarch64-fbsd-nat.c: Sort headers.
4325         * aarch32-linux-nat.c: Sort headers.
4326
4327 2019-04-04  Tom Tromey  <tom@tromey.com>
4328
4329         * varobj.c (varobj_create): Update.
4330         * rust-exp.y (struct rust_parser) <update_innermost_block,
4331         lookup_symbol>: New methods.
4332         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4333         Rename.
4334         (rust_parser::rust_lookup_type)
4335         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4336         * printcmd.c (display_command, do_one_display): Update.
4337         * parser-defs.h (struct parser_state) <parser_state>: Add
4338         "tracker" parameter.
4339         (block_tracker): New member.
4340         (class innermost_block_tracker) <innermost_block_tracker>: Add
4341         "types" parameter.
4342         <reset>: Remove method.
4343         (innermost_block): Don't declare.
4344         (null_post_parser): Update.
4345         * parse.c (innermost_block): Remove global.
4346         (write_dollar_variable): Update.
4347         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4348         Remove "tracker_types" parameter.
4349         (parse_expression): Add "tracker" parameter.
4350         (parse_expression_for_completion): Update.
4351         (null_post_parser): Add "tracker" parameter.
4352         * p-exp.y: Update rules.
4353         * m2-exp.y: Update rules.
4354         * language.h (struct language_defn) <la_post_parser>: Add
4355         "tracker" parameter.
4356         * go-exp.y: Update rules.
4357         * f-exp.y: Update rules.
4358         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4359         parameter.
4360         * d-exp.y: Update rules.
4361         * c-exp.y: Update rules.
4362         * breakpoint.c (set_breakpoint_condition): Create an
4363         innermost_block_tracker.
4364         (watch_command_1): Likewise.
4365         * ada-lang.c (resolve): Add "tracker" parameter.
4366         (resolve_subexp): Likewise.
4367         * ada-exp.y (write_var_from_sym): Update.
4368
4369 2019-04-04  Tom Tromey  <tom@tromey.com>
4370
4371         * type-stack.h: New file.
4372         * type-stack.c: New file.
4373         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4374         type-stack.h.
4375         (insert_into_type_stack, insert_type, push_type, push_type_int)
4376         (insert_type_address_space, pop_type, pop_type_int)
4377         (pop_typelist, pop_type_stack, append_type_stack)
4378         (push_type_stack, get_type_stack, push_typelist)
4379         (follow_type_instance_flags, follow_types): Don't declare.
4380         * parse.c (type_stack): Remove global.
4381         (parse_exp_in_context): Update.
4382         (insert_into_type_stack, insert_type, push_type, push_type_int)
4383         (insert_type_address_space, pop_type, pop_type_int)
4384         (pop_typelist, pop_type_stack, append_type_stack)
4385         (push_type_stack, get_type_stack, push_typelist)
4386         (follow_type_instance_flags, follow_types): Remove (moved to
4387         type-stack.c).
4388         * f-exp.y (type_stack): New global.
4389         Update rules.
4390         (push_kind_type, f_parse): Update.
4391         * d-exp.y (type_stack): New global.
4392         Update rules.
4393         (d_parse): Update.
4394         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4395         Update rules.
4396         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4397         (HFILES_NO_SRCDIR): Add type-stack.h.
4398
4399 2019-04-04  Tom Tromey  <tom@tromey.com>
4400
4401         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4402         (rust_parser::convert_ast_to_expression, rust_parse)
4403         (rust_lex_test_completion, rust_lex_tests): Update.
4404         * parser-defs.h (struct expr_completion_state): New.
4405         (struct parser_state) <parser_state>: Add completion parameter.
4406         <mark_struct_expression, mark_completion_tag>: New methods.
4407         <parse_completion, m_completion_state>: New members.
4408         (prefixify_expression, null_post_parser): Update.
4409         (mark_struct_expression, mark_completion_tag): Don't declare.
4410         * parse.c (parse_completion, expout_last_struct)
4411         (expout_tag_completion_type, expout_completion_name): Remove
4412         globals.
4413         (parser_state::mark_struct_expression)
4414         (parser_state::mark_completion_tag): Now methods.
4415         (prefixify_expression): Add last_struct parameter.
4416         (prefixify_subexp): Likewise.
4417         (parse_exp_1): Update.
4418         (parse_exp_in_context): Add cstate parameter.  Update.
4419         (parse_expression_for_completion): Create an
4420         expr_completion_state.
4421         (null_post_parser): Add "completion" parameter.
4422         * p-exp.y: Update rules.
4423         (yylex): Update.
4424         * language.h (struct language_defn) <la_post_parser>: Add
4425         "completing" parameter.
4426         * go-exp.y: Update rules.
4427         (lex_one_token): Update.
4428         * expression.h (parse_completion): Don't declare.
4429         * d-exp.y: Update rules.
4430         (lex_one_token): Update rules.
4431         * c-exp.y: Update rules.
4432         (lex_one_token): Update.
4433         * ada-lang.c (resolve): Add "parse_completion" parameter.
4434         (resolve_subexp): Likewise.
4435         (ada_resolve_function): Likewise.
4436
4437 2019-04-04  Tom Tromey  <tom@tromey.com>
4438
4439         * parser-defs.h (struct parser_state) <start_arglist,
4440         end_arglist>: New methods.
4441         <arglist_len, m_funcall_chain>: New members.
4442         (arglist_len, start_arglist, end_arglist): Don't declare.
4443         * parse.c (arglist_len, funcall_chain): Remove global.
4444         (start_arglist, end_arglist): Remove functions.
4445         (parse_exp_in_context): Update.
4446         * p-exp.y: Update rules.
4447         * m2-exp.y: Update rules.
4448         * go-exp.y: Update rules.
4449         * f-exp.y: Update rules.
4450         * d-exp.y: Update rules.
4451         * c-exp.y: Update rules.
4452
4453 2019-04-04  Tom Tromey  <tom@tromey.com>
4454
4455         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4456         lex_operator, push_back>: New methods.
4457         Update all rules.
4458         (rust_parser::lex_hex, lex_escape): Rename and update.
4459         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4460         (rust_parser::lex_operator): Rename and update.
4461         (rust_parser::lex_number, rustyylex, rustyyerror)
4462         (rust_lex_test_init, rust_lex_test_sequence)
4463         (rust_lex_test_push_back, rust_lex_tests): Update.
4464         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4465         parameter.
4466         <lexptr, prev_lexptr>: New members.
4467         (lexptr, prev_lexptr): Don't declare.
4468         * parse.c (lexptr, prev_lexptr): Remove globals.
4469         (parse_exp_in_context): Update.
4470         * p-exp.y (yylex, yyerror): Update.
4471         * m2-exp.y (parse_number, yylex, yyerror): Update.
4472         * go-exp.y (lex_one_token, yyerror): Update.
4473         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4474         * d-exp.y (lex_one_token, yyerror): Update.
4475         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4476         (lex_one_token, yyerror): Update.
4477         * ada-lex.l (YY_INPUT): Update.
4478         (rewind_to_char): Update.
4479         * ada-exp.y (yyerror): Update.
4480
4481 2019-04-04  Tom Tromey  <tom@tromey.com>
4482
4483         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4484         * parser-defs.h (struct parser_state) <parser_state>: Add new
4485         parameter.
4486         <comma_terminates>: New member.
4487         (comma_terminates): Don't declare global.
4488         * parse.c (comma_terminates): Remove global.
4489         (parse_exp_in_context): Update.
4490         * p-exp.y (yylex): Update.
4491         * m2-exp.y (yylex): Update.
4492         * go-exp.y (lex_one_token): Update.
4493         * f-exp.y (yylex): Update.
4494         * d-exp.y (lex_one_token): Update.
4495         * c-exp.y (lex_one_token): Update.
4496         * ada-lex.l: Update.
4497
4498 2019-04-04  Tom Tromey  <tom@tromey.com>
4499
4500         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4501         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4502         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4503         * parser-defs.h (paren_depth): Don't declare.
4504         * parse.c (paren_depth): Remove global.
4505         (parse_exp_in_context): Update.
4506         * p-exp.y (paren_depth): New global.
4507         (pascal_parse): Initialize it.
4508         * m2-exp.y (paren_depth): New global.
4509         (m2_parse): Initialize it.
4510         * go-exp.y (paren_depth): New global.
4511         (go_parse): Initialize it.
4512         * f-exp.y (paren_depth): New global.
4513         (f_parse): Initialize it.
4514         * d-exp.y (paren_depth): New global.
4515         (d_parse): Initialize it.
4516         * c-exp.y (paren_depth): New global.
4517         (c_parse): Initialize it.
4518         * ada-lex.l (paren_depth): New global.
4519         (lexer_init): Initialize it.
4520
4521 2019-04-04  Tom Tromey  <tom@tromey.com>
4522
4523         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4524         (rust_parser::convert_ast_to_type)
4525         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4526         * parser-defs.h (struct parser_state) <parser_state>: Add
4527         parameters.  Initialize new members.
4528         <expression_context_block, expression_context_pc>: New members.
4529         * parse.c (expression_context_block, expression_context_pc):
4530         Remove globals.
4531         (parse_exp_in_context): Update.
4532         * p-exp.y: Update all rules.
4533         (yylex): Update.
4534         * m2-exp.y: Update all rules.
4535         (yylex): Update.
4536         * go-exp.y (yylex): Update.
4537         * f-exp.y (yylex): Update.
4538         * d-exp.y: Update all rules.
4539         (yylex): Update.
4540         * c-exp.y: Update all rules.
4541         (lex_one_token, classify_name, yylex, c_parse): Update.
4542         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4543
4544 2019-04-04  Tom Tromey  <tom@tromey.com>
4545
4546         * gdbarch.h, gdbarch.c: Rebuild.
4547         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4548         * stap-probe.h:
4549         (struct stap_parse_info): Replace "parser_state" with
4550         "expr_builder".
4551         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4552         (parser_state): New class.
4553         * parse.c (expr_builder): Rename.
4554         (expr_builder::release): Rename.
4555         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4556         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4557         (write_exp_elt_longcst, write_exp_elt_floatcst)
4558         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4559         (write_exp_string_vector, write_exp_bitstring)
4560         (write_exp_msymbol, mark_struct_expression)
4561         (write_dollar_variable)
4562         (insert_type_address_space, increase_expout_size): Replace
4563         "parser_state" with "expr_builder".
4564         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4565         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4566         "parser_state" with "expr_builder".
4567
4568 2019-04-04  Tom Tromey  <tom@tromey.com>
4569
4570         * rust-exp.y: Replace "parse_language" with method call.
4571         * p-exp.y:
4572         (yylex): Replace "parse_language" with method call.
4573         * m2-exp.y:
4574         (yylex): Replace "parse_language" with method call.
4575         * go-exp.y (classify_name): Replace "parse_language" with method
4576         call.
4577         * f-exp.y (yylex): Replace "parse_language" with method call.
4578         * d-exp.y (lex_one_token): Replace "parse_language" with method
4579         call.
4580         * c-exp.y:
4581         (lex_one_token, classify_name, yylex): Replace "parse_language"
4582         with method call.
4583         * ada-exp.y (find_primitive_type, type_char)
4584         (type_system_address): Replace "parse_language" with method call.
4585
4586 2019-04-04  Tom Tromey  <tom@tromey.com>
4587
4588         * rust-exp.y: Replace "parse_gdbarch" with method call.
4589         * parse.c (write_dollar_variable, insert_type_address_space):
4590         Replace "parse_gdbarch" with method call.
4591         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4592         call.
4593         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4594         call.
4595         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4596         "parse_gdbarch" with method call.
4597         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4598         with method call.
4599         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4600         "parse_gdbarch" with method call.
4601         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4602         "parse_gdbarch" with method call.
4603         * c-exp.y (parse_type, parse_number, classify_name): Replace
4604         "parse_gdbarch" with method call.
4605         * ada-lex.l: Replace "parse_gdbarch" with method call.
4606         * ada-exp.y (parse_type, find_primitive_type, type_char)
4607         (type_system_address): Replace "parse_gdbarch" with method call.
4608
4609 2019-04-04  Tom Tromey  <tom@tromey.com>
4610
4611         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4612         * stap-probe.c (stap_parse_argument): Update.
4613         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4614         initial_size parameter.
4615         * rust-exp.y (rust_lex_tests): Update.
4616         * parse.c (parser_state): Update.
4617         (parse_exp_in_context): Update.
4618         * parser-defs.h (struct parser_state) <parser_state>: Remove
4619         "initial_size" parameter.
4620
4621 2019-04-04  Tom Tromey  <tom@tromey.com>
4622
4623         * parser-defs.h (increase_expout_size): Don't declare.
4624         * parse.c (increase_expout_size): Now static.
4625
4626 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4627
4628         * gnu-nat.c (gnu_nat_target::wait): Fix
4629         target_waitstatus_to_string call.
4630
4631 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4632
4633         * eval.c (evaluate_subexp_standard): Handle internal functions
4634         during Fortran function call handling.
4635
4636 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4637
4638         * NEWS: Mention new internal functions.
4639         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4640         (read_base_type): Use dwarf2_init_complex_target_type.
4641         * value.c (creal_internal_fn): New function.
4642         (cimag_internal_fn): New function.
4643         (_initialize_values): Register new internal functions.
4644
4645 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4646
4647         * infrun.c (stop_all_threads): If debug_infrun, always
4648         trace the wait status after wait_one, using
4649         target_waitstatus_to_string and target_pid_to_str.
4650         (handle_inferior_event): Replace various trace of
4651         wait status kind by a single trace.
4652         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4653         wait status kind image by target_waitstatus_to_string.
4654         * target/waitstatus.c (target_waitstatus_to_string): Fix
4655         obsolete comment.
4656
4657 2019-04-01  Tom Tromey  <tromey@adacore.com>
4658
4659         PR symtab/23331:
4660         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4661
4662 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4663             Pedro Alves  <palves@redhat.com>
4664
4665         * top.c (quit_force): Call 'finalize_values'.
4666         * value.c (finalize_values): New function.
4667         * value.h (finalize_values): Declare.
4668
4669 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4670
4671         * NEWS: Announce $_gdb_major and $_gdb_minor.
4672
4673         * top.c (init_gdb_version_vars): New function.
4674         (gdb_init): Call init_gdb_version_vars.
4675
4676 2019-03-29  Tom Tromey  <tromey@adacore.com>
4677
4678         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4679         help text.  Remove dead code.
4680
4681 2019-03-29  Keith Seitz  <keiths@redhat.com>
4682
4683         From Siddhesh Poyarekar:
4684         * f-lang.h (f77_get_upperbound): Return LONGEST.
4685         (f77_get_lowerbound): Likewise.
4686         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4687         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4688         print them.
4689         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4690         plongest to format print it.
4691         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4692         (f77_get_upperbound): Likewise.
4693         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4694         LOWER_BOUND to LONGEST.
4695         (f77_create_arrayprint_offset_tbl): Likewise.
4696
4697 2019-03-29  Keith Seitz  <keiths@redhat.com>
4698
4699         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4700         %s/pulongest for TYPE_LENGTH instead of %d in format
4701         strings.
4702         * ada-typerint.c (ada_print_type): Likewise.
4703         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4704         * compile/compile-c-support.c (generate_register_struct): Likewise.
4705         * gdbtypes.c (recursive_dump_type): Likewise.
4706         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4707         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4708         instead of %d in format strings.
4709         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4710         to std::min to ULONGEST.
4711         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4712         instead of %d in format strings.
4713         * tracepoint.c (info_scope_command): Likewise.
4714         * typeprint.c (print_offset_data::update)
4715         (print_offset_data::finish): Likewise.
4716         * xtensa-tdep.c (xtensa_store_return_value)
4717         (xtensa_push_dummy_call): Likewise.
4718
4719 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4720
4721         * windows-nat.c (display_selector): Fixed format specifications
4722         for 64-bit Cygwin.
4723
4724 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4725
4726         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4727
4728 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4729
4730         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4731         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4732         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4733         (nios2_linux_init_abi): Install it.
4734
4735 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4736
4737         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4738
4739 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4740
4741         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4742
4743 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4744             Tom Tromey  <tromey@adacore.com>
4745
4746         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4747
4748 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4749
4750         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4751         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4752         method to compute the bounds of range types. Also print "[evaluated]"
4753         if the bounds' values come from a dynamic evaluation.
4754
4755 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4756
4757         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4758         whitespace when pretty printing is on.
4759
4760 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4761
4762         * ppc-linux-nat.c: Add include.
4763
4764 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4765
4766         * NEWS: Mention AArch64 Pointer Authentication.
4767
4768 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4769
4770         * arm-linux-nat.c: Add include.
4771
4772 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4773
4774         * source-cache.c (source_cache::get_source_lines): Re-read
4775         fullname after calling open_source_file.
4776
4777 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4778
4779         * NEWS: Mention TLS support for FreeBSD.
4780
4781 2019-03-25  Tom Tromey  <tromey@adacore.com>
4782
4783         * minsyms.c (BUNCH_SIZE): Update comment.
4784         (~minimal_symbol_reader): Remove old comment.
4785         (compact_minimal_symbols): Update comment.
4786         (minimal_symbol_reader::install): Remove old comment.  Update
4787         other comments.
4788
4789 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4790
4791         * s390-linux-nat.c: Add include.
4792
4793 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4794
4795         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4796         Call linux_get_hwcap.
4797         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4798         Likewise.
4799         (aarch64_linux_get_hwcap): Remove function.
4800         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4801         declaration.
4802         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4803         linux_get_hwcap.
4804         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4805         * linux-tdep.c (linux_get_hwcap): Add function.
4806         (linux_get_hwcap2): Likewise.
4807         * linux-tdep.h (linux_get_hwcap): Add declaration.
4808         (linux_get_hwcap2): Likewise.
4809         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4810         (ppc_linux_get_hwcap2): Likewise.
4811         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4812         linux_get_hwcap.
4813         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4814         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4815         (ppc_linux_nat_target::read_description): Likewise.
4816         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4817         * s390-linux-nat.c: Likewise.
4818         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4819
4820 2019-03-24  Tom Tromey  <tom@tromey.com>
4821
4822         * ada-lang.c (standard_lookup): Simplify initialization.
4823         (ada_lookup_symbol_nonlocal): Simplify return.
4824         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4825         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4826         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4827         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4828         initialization.
4829         * solib.c (solib_global_lookup): Simplify.
4830         * symtab.c (null_block_symbol): Remove.
4831         (symbol_cache_lookup): Simplify returns.
4832         (lookup_language_this): Simplify returns.
4833         (lookup_symbol_aux): Simplify return.
4834         (lookup_local_symbol): Simplify returns.
4835         (lookup_global_symbol_from_objfile): Simplify return.
4836         (lookup_symbol_in_objfile_symtabs)
4837         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4838         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4839         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4840         * cp-namespace.c (cp_lookup_bare_symbol)
4841         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4842         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4843         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4844         (cp_lookup_symbol_via_imports): Simplify initialization.
4845         (find_symbol_in_baseclass): Likewise.
4846         * symtab.h (null_block_symbol): Remove.
4847         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4848         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4849         (d_lookup_symbol_module): Likewise.
4850         (find_symbol_in_baseclass): Simplify initialization.
4851
4852 2019-03-24  Tom Tromey  <tom@tromey.com>
4853
4854         * expression.h: Don't include symtab.h.
4855         (struct block): Forward declare.
4856
4857 2019-03-24  Tom Tromey  <tom@tromey.com>
4858
4859         * c-exp.y (typebase): Remove casts.
4860         * gdbtypes.c (lookup_unsigned_typename, )
4861         (lookup_signed_typename): Remove cast.
4862         * eval.c (parse_to_comma_and_eval): Remove cast.
4863         * parse.c (write_dollar_variable): Remove cast.
4864         * block.h (struct block) <superblock>: Now const.
4865         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4866         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4867         (map_block): Make "block" const.
4868         * symfile.h (struct quick_symbol_functions)
4869         <map_matching_symbols>: Constify block argument to "callback".
4870         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4871         const.
4872         (find_pc_sect_compunit_symtab): Make "b" const.
4873         (find_symbol_at_address): Likewise.
4874         (search_symbols): Likewise.
4875         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4876         (dw2_debug_names_lookup_symbol): Likewise.
4877         (dw2_map_matching_symbols): Update.
4878         * p-valprint.c (pascal_val_print): Remove "block".
4879         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4880         (aux_add_nonlocal_symbols): Make "block" const.
4881         (resolve_subexp): Remove cast.
4882         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4883         const.
4884         (iterate_over_file_blocks): Likewise.
4885         * f-exp.y (%union) <bval>: Remove.
4886         * coffread.c (patch_opaque_types): Make "b" const.
4887         * spu-tdep.c (spu_catch_start): Make "block" const.
4888         * c-valprint.c (print_unpacked_pointer): Remove "block".
4889         * symmisc.c (dump_symtab_1): Make "b" const.
4890         (block_depth): Make "block" const.
4891         * d-exp.y (%union) <bval>: Remove.
4892         * cp-support.h (cp_lookup_rtti_type): Update.
4893         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4894         * psymtab.c (psym_lookup_symbol): Make "block" const.
4895         (maintenance_check_psymtabs): Make "b" const.
4896         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4897         (enumerate_locals, enumerate_args): Update.
4898         * python/py-symtab.c (stpy_global_block): Make "block" const.
4899         (stpy_static_block): Likewise.
4900         * inline-frame.c (block_starting_point_at): Make "new_block"
4901         const.
4902         * block.c (find_block_in_blockvector): Make return type const.
4903         (blockvector_for_pc_sect): Make "b" const.
4904         (find_block_in_blockvector): Make "b" const.
4905
4906 2019-03-23  Tom Tromey  <tom@tromey.com>
4907
4908         * varobj.c (varobj_create): Update.
4909         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4910         * printcmd.c (display_command, do_one_display): Don't reset
4911         innermost_block.
4912         * parser-defs.h (enum innermost_block_tracker_type): Move to
4913         expression.h.
4914         (innermost_block): Update comment.
4915         * parse.c (parse_exp_1): Add tracker_types parameter.
4916         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4917         tracker_types parameter.  Reset innermost_block.
4918         (parse_exp_in_context): Remove.
4919         (parse_expression_for_completion): Update.
4920         * objfiles.c (~objfile): Don't reset expression_context_block or
4921         innermost_block.
4922         * expression.h (enum innermost_block_tracker_type): Move from
4923         parser-defs.h.
4924         (parse_exp_1): Add tracker_types parameter.
4925         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4926         reset innermost_block.
4927
4928 2019-03-23  Tom Tromey  <tom@tromey.com>
4929
4930         * objfiles.h: Include bcache.h.
4931
4932 2019-03-23  Tom Tromey  <tom@tromey.com>
4933
4934         * linespec.c (get_current_search_block): Use
4935         scoped_restore_current_language.
4936         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4937
4938 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4939             Jiong Wang  <jiong.wang@arm.com>
4940
4941         * aarch64-linux-tdep.c
4942         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4943         section.
4944         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4945
4946 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4947             Jiong Wang  <jiong.wang@arm.com>
4948
4949         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4950         instructions.
4951         (aarch64_analyze_prologue_test): Add PACIASP test.
4952         (aarch64_prologue_prev_register): Unmask PC value.
4953
4954 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4955             Jiong Wang  <jiong.wang@arm.com>
4956
4957         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4958         (aarch64_dwarf2_prev_register): Unmask PC value.
4959         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4960         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4961         DW_CFA_AARCH64_negate_ra_state.
4962         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4963
4964 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4965             Jiong Wang  <jiong.wang@arm.com>
4966
4967         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4968         registers.
4969         (aarch64_pseudo_register_name): Likewise.
4970         (aarch64_pseudo_register_type): Likewise.
4971         (aarch64_pseudo_register_reggroup_p): Likewise.
4972         (aarch64_gdbarch_init): Add pauth registers.
4973         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4974         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4975         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4976         (struct gdbarch_tdep): Add regnum for ra_state.
4977
4978 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4979             Jiong Wang  <jiong.wang@arm.com>
4980
4981         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4982
4983 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4984             Jiong Wang  <jiong.wang@arm.com>
4985
4986         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4987         function.
4988         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4989         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4990         (aarch64_gdbarch_init): Add puth registers.
4991         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4992         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4993         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4994
4995 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4996             Jiong Wang  <jiong.wang@arm.com>
4997
4998         * aarch64-linux-nat.c
4999         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5000         * aarch64-linux-tdep.c
5001         (aarch64_linux_core_read_description): Likewise.
5002         (aarch64_linux_get_hwcap): New function.
5003         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5004         (aarch64_linux_get_hwcap): New declaration.
5005
5006 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5007             Jiong Wang  <jiong.wang@arm.com>
5008
5009         * aarch64-linux-nat.c
5010         (aarch64_linux_nat_target::read_description): Add pauth param.
5011         * aarch64-linux-tdep.c
5012         (aarch64_linux_core_read_description): Likewise.
5013         * aarch64-tdep.c (struct target_desc): Add in pauth.
5014         (aarch64_read_description): Add pauth param.
5015         (aarch64_gdbarch_init): Likewise.
5016         * aarch64-tdep.h (aarch64_read_description): Likewise.
5017         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5018         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5019         * features/Makefile: Add new files.
5020         * features/aarch64-pauth.c: New file.
5021         * features/aarch64-pauth.xml: New file.
5022
5023 2019-03-20  Tom Tromey  <tromey@adacore.com>
5024
5025         * infrun.c (handle_inferior_event): Rename from
5026         handle_inferior_event_1.  Create a scoped_value_mark.
5027         (handle_inferior_event): Remove.
5028
5029 2019-03-19  Tom Tromey  <tromey@adacore.com>
5030
5031         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5032         * infrun.h (print_stop_event): Add "displays" parameter.
5033         * infrun.c (print_stop_event): Add "displays" parameter.
5034
5035 2019-03-19  Pedro Alves  <palves@redhat.com>
5036
5037         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5038         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5039         to -1.  Fix TABs vs spaces.
5040         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5041         * tui/tui-out.h (tui_ui_out) Add intro comments.
5042         <m_line, m_start_of_line>: In-class initialize, and add describing
5043         comment.
5044
5045 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5046
5047         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5048         variable names.
5049         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5050
5051 2019-03-18  Pedro Alves  <palves@redhat.com>
5052             Eli Zaretskii <eliz@gnu.org>
5053
5054         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5055         m_line and m_start_of_line.
5056
5057 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5058
5059         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5060         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5061         it returns a newline.  This fixes a regression in TU mode, whereby
5062         the next line is output on the same screen line as the user input.
5063
5064 2019-03-18  Tom Tromey  <tromey@adacore.com>
5065
5066         * minsyms.c (minimal_symbol_reader::install): Remove call to
5067         obstack_blank.
5068
5069 2019-03-18  Pedro Alves  <palves@redhat.com>
5070
5071         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5072         New globals.
5073         (apply_style): New, factored out from ...
5074         (apply_ansi_escape): ... this.  Handle reverse video mode.
5075         (tui_set_reverse_mode): New function.
5076         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5077         * tui/tui-winsource.c (tui_show_source_line): Use
5078         tui_set_reverse_mode instead of setting A_STANDOUT.
5079         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5080         New setter methods.
5081
5082 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5083
5084         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5085         Handle tabs.
5086
5087 2019-03-18  Tom Tromey  <tromey@adacore.com>
5088
5089         * ada-lang.c (empty_array): Add "high" parameter.
5090         (ada_evaluate_subexp): Update.
5091
5092 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5093
5094         * unittests/string_view-selftests.c: Define
5095         _initialize_string_view_selftests unconditionally.
5096
5097 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5098
5099         PR gdb/24350
5100         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5101
5102 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5103
5104         PR gdb/24351
5105         * windows-nat.c (display_selector): Fix format specifiers.
5106
5107 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5108
5109         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5110         tui_refill_source_window instead of tui_refresh_win, to update the
5111         current execution line.  This fixes redisplay of the current line
5112         when stepping through the code with "next" or "step".
5113
5114 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5115
5116         * source-cache.c (source_cache::get_source_lines): Call
5117         find_source_lines to initialize s->nlines.  This fixes vertical
5118         scrolling of TUI source window when the DOWN arrow is pressed.
5119
5120 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5121
5122         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5123         linux-thread-db.c (_initialize_thread_db): Likewise.
5124
5125 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5126
5127         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5128         wclrtoeol in tui_show_source_line".  This reverts changes made in
5129         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5130
5131 2019-03-15  Tom Tromey  <tom@tromey.com>
5132
5133         * symtab.h (struct minimal_symbol): Derive from
5134         general_symbol_info.
5135         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5136         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5137         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5138         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5139         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5140         (MSYMBOL_SEARCH_NAME): Update.
5141         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5142         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5143         * minsyms.c (minimal_symbol_reader::record_full): Update.
5144
5145 2019-03-15  Tom Tromey  <tom@tromey.com>
5146
5147         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5148
5149 2019-03-15  Tom Tromey  <tom@tromey.com>
5150
5151         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5152         unique_xmalloc_ptr.
5153         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5154         Update.
5155         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5156         (build_minimal_symbol_hash_tables)
5157         (minimal_symbol_reader::install): Update.
5158
5159 2019-03-15  Tom Tromey  <tom@tromey.com>
5160
5161         * symtab.c (create_demangled_names_hash): Update.
5162         (symbol_set_names): Update.
5163         * objfiles.h (struct objfile_per_bfd_storage)
5164         <demangled_names_hash>: Now an htab_up.
5165         * objfiles.c (objfile_per_bfd_storage): Simplify.
5166
5167 2019-03-15  Tom Tromey  <tom@tromey.com>
5168
5169         * objfiles.h (struct objfile_per_bfd_storage): Declare
5170         destructor.
5171         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5172         New.
5173         (get_objfile_bfd_data): Use new.  Don't initialize
5174         language_of_main.
5175         (free_objfile_per_bfd_storage): Remove.
5176         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5177
5178 2019-03-15  Tom Tromey  <tom@tromey.com>
5179
5180         * symfile.c (reread_symbols): Update.
5181         * objfiles.c (objfile::objfile): Update.
5182         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5183         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5184         comment.
5185         (minimal_symbol_reader::install): Update.
5186         (terminate_minimal_symbol_table): Remove.
5187         * jit.c (jit_object_close_impl): Update.
5188
5189 2019-03-15  Tom Tromey  <tom@tromey.com>
5190
5191         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5192         initializations.
5193
5194 2019-03-15  Tom Tromey  <tom@tromey.com>
5195
5196         * objfiles.h (struct objfile_per_bfd_storage)
5197         <demangled_hash_languages>: Now a bitset.
5198         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5199         (lookup_minimal_symbol): Update.
5200
5201 2019-03-15  Tom Tromey  <tom@tromey.com>
5202
5203         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5204         Don't return the symbol.
5205         * coffread.c (record_minimal_symbol): Use record_full.
5206
5207 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5208
5209         The MS-Windows port of ncurses fails to switch to a color pair if
5210         one or both of the colors are the implicit default colors.  This
5211         change records the default colors when TUI is initialized, and
5212         then specifies them explicitly when a color pair uses the default
5213         colors.  This allows color styling in TUI mode on MS-Windows.
5214
5215         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5216         ncurses_norm_attr.
5217         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5218         colors in ncurses_norm_attr.
5219         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5220         "none", replace it with the default color recorded in
5221         ncurses_norm_attr.
5222
5223 2019-03-14  Tom Tromey  <tromey@adacore.com>
5224
5225         * source-cache.h (class source_cache) <get_source_lines>: Return
5226         std::string.
5227         * source-cache.c (source_cache::extract_lines): Handle case where
5228         first_pos==npos.  Return std::string.
5229         (source_cache::get_source_lines): Update.
5230
5231 2019-03-14  Tom Tromey  <tromey@adacore.com>
5232
5233         * NEWS: Add item for "style sources" commands.
5234         * source-cache.c (source_cache::get_source_lines): Check
5235         source_styling.
5236         * cli/cli-style.c (source_styling): New global.
5237         (_initialize_cli_style): Add "style sources" commands.
5238         (show_style_sources): New function.
5239         * cli/cli-style.h (source_styling): Declare.
5240
5241 2019-03-14  Pedro Alves  <palves@redhat.com>
5242             Tom Tromey  <tromey@adacore.com>
5243
5244         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5245         * tui/tui-winsource.c (tui_refill_source_window): New function,
5246         from...
5247         (tui_horizontal_source_scroll): ... here.  Move some logic.
5248         * cli/cli-style.c (set_style_enabled): Notify new observable.
5249         * tui/tui-hooks.c (tui_redisplay_source): New function.
5250         (tui_attach_detach_observers): Attach or detach
5251         tui_redisplay_source.
5252         * observable.h (source_styling_changed): New observable.
5253         * observable.c: Define source_styling_changed observable.
5254
5255 2019-03-13  Tom Tromey  <tromey@adacore.com>
5256
5257         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5258         (i386_gnu_nat_target::store_registers): Update.
5259         * target-debug.h (target_debug_print_std_string): New macro.
5260         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5261         * windows-tdep.c (display_one_tib): Update.
5262         * tui/tui-stack.c (tui_make_status_line): Update.
5263         * top.c (print_inferior_quit_action): Update.
5264         * thread.c (thr_try_catch_cmd): Update.
5265         (add_thread_with_info): Update.
5266         (thread_target_id_str): Update.
5267         (thr_try_catch_cmd): Update.
5268         (thread_command): Update.
5269         (thread_find_command): Update.
5270         * record-btrace.c (record_btrace_target::info_record)
5271         (record_btrace_resume_thread, record_btrace_target::resume)
5272         (record_btrace_cancel_resume, record_btrace_step_thread)
5273         (record_btrace_target::wait, record_btrace_target::wait)
5274         (record_btrace_target::wait, record_btrace_target::stop): Update.
5275         * progspace.c (print_program_space): Update.
5276         * process-stratum-target.c
5277         (process_stratum_target::thread_address_space): Update.
5278         * linux-fork.c (linux_fork_mourn_inferior)
5279         (detach_checkpoint_command, info_checkpoints_command)
5280         (linux_fork_context): Update.
5281         (linux_fork_detach): Update.
5282         (class scoped_switch_fork_info): Update.
5283         (delete_checkpoint_command): Update.
5284         * infrun.c (follow_fork_inferior): Update.
5285         (follow_fork_inferior): Update.
5286         (proceed_after_vfork_done): Update.
5287         (handle_vfork_child_exec_or_exit): Update.
5288         (follow_exec): Update.
5289         (displaced_step_prepare_throw): Update.
5290         (displaced_step_restore): Update.
5291         (start_step_over): Update.
5292         (resume_1): Update.
5293         (clear_proceed_status_thread): Update.
5294         (proceed): Update.
5295         (print_target_wait_results): Update.
5296         (do_target_wait): Update.
5297         (context_switch): Update.
5298         (stop_all_threads): Update.
5299         (restart_threads): Update.
5300         (finish_step_over): Update.
5301         (handle_signal_stop): Update.
5302         (switch_back_to_stepped_thread): Update.
5303         (keep_going_pass_signal): Update.
5304         (print_exited_reason): Update.
5305         (normal_stop): Update.
5306         * inferior.c (inferior_pid_to_str): Change return type.
5307         (print_selected_inferior): Update.
5308         (add_inferior): Update.
5309         (detach_inferior): Update.
5310         * dummy-frame.c (fprint_dummy_frames): Update.
5311         * dcache.c (dcache_info_1): Update.
5312         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5313         (btrace_fetch, btrace_clear): Update.
5314         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5315         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5316         type.
5317         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5318         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5319         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5320         * gdbarch.c, gdbarch.h: Rebuild.
5321         * gdbarch.sh (core_pid_to_str): Change return type.
5322         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5323         return type.
5324         (windows_nat_target::pid_to_str): Change return type.
5325         (windows_delete_thread): Update.
5326         (windows_nat_target::attach): Update.
5327         (windows_nat_target::files_info): Update.
5328         * target-delegates.c: Rebuild.
5329         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5330         return type.
5331         (sol_thread_target::pid_to_str): Change return type.
5332         * remote.c (class remote_target) <pid_to_str>: Change return
5333         type.
5334         (remote_target::pid_to_str): Change return type.
5335         (extended_remote_target::attach, remote_target::remote_stop_ns)
5336         (remote_target::remote_notif_remove_queued_reply)
5337         (remote_target::push_stop_reply, remote_target::disable_btrace):
5338         Update.
5339         (extended_remote_target::attach): Update.
5340         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5341         type.
5342         (gdbsim_target::pid_to_str): Change return type.
5343         * ravenscar-thread.c (struct ravenscar_thread_target)
5344         <pid_to_str>: Change return type.
5345         (ravenscar_thread_target::pid_to_str): Change return type.
5346         * procfs.c (class procfs_target) <pid_to_str>: Change return
5347         type.
5348         (procfs_target::pid_to_str): Change return type.
5349         (procfs_target::attach): Update.
5350         (procfs_target::detach): Update.
5351         (procfs_target::fetch_registers): Update.
5352         (procfs_target::store_registers): Update.
5353         (procfs_target::wait): Update.
5354         (procfs_target::files_info): Update.
5355         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5356         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5357         return type.
5358         (nto_procfs_target::pid_to_str): Change return type.
5359         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5360         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5361         return type.
5362         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5363         (exit_lwp): Update.
5364         (attach_proc_task_lwp_callback, get_detach_signal)
5365         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5366         (linux_nat_target::resume, wait_lwp, stop_callback)
5367         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5368         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5369         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5370         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5371         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5372         type.
5373         (inf_ptrace_target::attach): Update.
5374         (inf_ptrace_target::files_info): Update.
5375         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5376         type.
5377         (go32_nat_target::pid_to_str): Change return type.
5378         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5379         (gnu_nat_target::wait): Update.
5380         (gnu_nat_target::wait): Update.
5381         (gnu_nat_target::resume): Update.
5382         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5383         (fbsd_nat_target::wait): Update.
5384         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5385         type.
5386         (darwin_nat_target::attach): Update.
5387         * corelow.c (class core_target) <pid_to_str>: Change return type.
5388         (core_target::pid_to_str): Change return type.
5389         * target.c (normal_pid_to_str): Change return type.
5390         (default_pid_to_str): Likewise.
5391         (target_pid_to_str): Change return type.
5392         (target_translate_tls_address): Update.
5393         (target_announce_detach): Update.
5394         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5395         return type.
5396         (bsd_uthread_target::pid_to_str): Change return type.
5397         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5398         type.
5399         (bsd_kvm_target::pid_to_str): Change return type.
5400         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5401         return type.
5402         (aix_thread_target::pid_to_str): Change return type.
5403         * target.h (struct target_ops) <pid_to_str>: Change return type.
5404         (target_pid_to_str, normal_pid_to_str): Likewise.
5405         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5406         type.
5407         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5408         type.
5409         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5410         return type.
5411         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5412         type.
5413         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5414         type.
5415         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5416         return type.
5417
5418 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5419
5420         * NEWS: Mention that the new default MI version is 3.  Mention
5421         changes to the output of commands and events that deal with
5422         multi-location breakpoints.
5423         * breakpoint.c: Include "mi/mi-out.h".
5424         (print_one_breakpoint): Change output syntax if using MI version
5425         >= 3.
5426         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5427         New.
5428         (mi_multi_location_breakpoint_output_fixed): New.
5429         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5430         (mi_cmd_fix_multi_location_breakpoint_output): New.
5431         (mi_multi_location_breakpoint_output_fixed): New.
5432         * mi/mi-cmds.c (mi_cmds): Register command
5433         -fix-multi-location-breakpoint-output.
5434         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5435         interpreter "mi".
5436
5437 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5438
5439         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5440         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5441         instantiate mi_ui_out based on interpreter name.
5442         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5443         * mi/mi-main.c (mi_load_progress): Likewise.
5444
5445 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5446
5447         * NEWS: Combine separate "New targets" sections for 8.3.
5448
5449 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5450
5451         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5452         (ppcfbsd_init_abi): Install gdbarch
5453         "fetch_tls_load_module_address" and "get_thread_local_address"
5454         methods.
5455
5456 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5457
5458         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5459         (riscv_fbsd_init_abi): Install gdbarch
5460         "fetch_tls_load_module_address" and "get_thread_local_address"
5461         methods.
5462
5463 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5464
5465         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5466         (i386fbsd_init_abi): Install gdbarch
5467         "fetch_tls_load_module_address" and "get_thread_local_address"
5468         methods.
5469
5470 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5471
5472         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5473         (amd64fbsd_init_abi): Install gdbarch
5474         "fetch_tls_load_module_address" and "get_thread_local_address"
5475         methods.
5476
5477 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5478
5479         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5480         (struct fbsd_pspace_data): New type.
5481         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5482         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5483         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5484         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5485         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5486
5487 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5488
5489         * gdbtypes.c (lookup_struct_elt): New function.
5490         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5491         * gdbtypes.h (struct struct_elt): New type.
5492         (lookup_struct_elt): New prototype.
5493
5494 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5495
5496         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5497         remove disabled code block.
5498
5499 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5500
5501         * gdbarch.sh (get_thread_local_address): New method.
5502         * gdbarch.h, gdbarch.c: Regenerate.
5503         * target.c (target_translate_tls_address): Use
5504         gdbarch_get_thread_local_address if present instead of
5505         target::get_thread_local_address.
5506
5507 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5508
5509         * target.h (target::get_thread_local_address): Update comment.
5510
5511 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5512
5513         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5514         objfile->separate_debug_objfile_backlink if not NULL.
5515
5516 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5517
5518         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5519         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5520         (amd64bsd_store_inferior_registers): Likewise.
5521         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5522         Enable segment base registers.
5523         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5524         PT_GETFSBASE and PT_GETGSBASE.
5525         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5526         PT_SETGSBASE.
5527         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5528         segment base registers.
5529         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5530
5531 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5532
5533         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5534         Update calls to i386_target_description to add 'segments'
5535         parameter.
5536         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5537         add segment base registers.
5538         * arch/i386.c (i386_create_target_description): Add 'segments'
5539         parameter to enable segment base registers.
5540         * arch/i386.h (i386_create_target_description): Likewise.
5541         * features/i386/32bit-segments.xml: New file.
5542         * features/i386/32bit-segments.c: Generate.
5543         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5544         call to i386_target_description to add 'segments' parameter.
5545         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5546         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5547         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5548         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5549         if feature is present.
5550         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5551         Add 'segments' parameter to call to i386_target_description.
5552         (i386_target_description): Add 'segments' parameter to enable
5553         segment base registers.
5554         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5555         to call to i386_target_description.
5556         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5557         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5558         Define I386_NUM_REGS.
5559         (i386_target_description): Add 'segments' parameter to enable
5560         segment base registers.
5561
5562 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5563
5564         PR/24325
5565         * source-cache.c: #undef open and close, to avoid unresolved
5566         externals during linking.
5567
5568 2019-03-12  Tom Tromey  <tromey@adacore.com>
5569
5570         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5571         const.  Add initializers.
5572         (_initialize_remote): Don't initialize ptid globals.
5573
5574 2019-03-12  Pedro Alves  <palves@redhat.com>
5575
5576         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5577
5578 2019-03-12  Pedro Alves  <palves@redhat.com>
5579
5580         * cp-name-parser.y (main): Remove unused 'len' variable.
5581
5582 2019-03-12  Tom Tromey  <tromey@adacore.com>
5583
5584         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5585         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5586
5587 2019-03-12  Tom Tromey  <tromey@adacore.com>
5588
5589         * linux-nat.c (iterate_over_lwps): Update.
5590         (stop_callback): Remove parameter.
5591         (stop_wait_callback, detach_callback, resume_set_callback)
5592         (select_singlestep_lwp_callback, set_ignore_sigint)
5593         (status_callback, resumed_callback, resume_clear_callback)
5594         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5595         data parameter.
5596         (linux_nat_target::detach, linux_nat_target::resume)
5597         (linux_stop_and_wait_all_lwps, select_event_lwp)
5598         (linux_nat_filter_event, linux_nat_wait_1)
5599         (linux_nat_target::kill, linux_nat_target::stop)
5600         (linux_nat_target::stop): Update.
5601         (linux_nat_resume_callback): Change type.
5602         (resume_stopped_resumed_lwps, count_events_callback)
5603         (select_event_lwp_callback): Likewise.
5604         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5605         * arm-linux-nat.c (struct update_registers_data): Remove.
5606         (update_registers_callback): Change type.
5607         (arm_linux_insert_hw_breakpoint1): Update.
5608         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5609         parameter.
5610         (x86_linux_dr_set_addr): Update.
5611         (x86_linux_dr_set_control): Update.
5612         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5613         (iterate_over_lwps): Use gdb::function_view.
5614         * nat/aarch64-linux-hw-point.c (struct
5615         aarch64_dr_update_callback_param): Remove.
5616         (debug_reg_change_callback): Change type.
5617         (aarch64_notify_debug_reg_change): Update.
5618         * s390-linux-nat.c (s390_refresh_per_info): Update.
5619
5620 2019-03-11  Tom Tromey  <tromey@adacore.com>
5621
5622         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5623         redundant assignment to "this_cu".
5624
5625 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5626
5627         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5628
5629 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5630
5631         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5632         from...
5633         (rank_one_type): ... this.
5634
5635 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5636
5637         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5638         from...
5639         (rank_one_type): ... this.
5640
5641 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5642
5643         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5644         from...
5645         (rank_one_type): ... this.
5646
5647 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5648
5649         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5650         from...
5651         (rank_one_type): ... this.
5652
5653 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5654
5655         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5656         from...
5657         (rank_one_type): ... this.
5658
5659 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5660
5661         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5662         from...
5663         (rank_one_type): ... this.
5664
5665 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5666
5667         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5668         from...
5669         (rank_one_type): ... this.
5670
5671 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5672
5673         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5674         from...
5675         (rank_one_type): ... this.
5676
5677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5678
5679         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5680         from...
5681         (rank_one_type): ... this.
5682
5683 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5684
5685         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5686         from...
5687         (rank_one_type): ... this.
5688
5689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5690
5691         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5692         from...
5693         (rank_one_type): ... this.
5694
5695 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5696
5697         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5698         from...
5699         (rank_one_type): ... this.
5700
5701 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5702
5703         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5704         inferior-events' shows the example events.
5705
5706 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5707
5708         Support styling on native MS-Windows console
5709
5710         PR/24315
5711         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5712         on MS-Windows if $TERM is not defined.
5713
5714         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5715
5716         * posix-hdep.c (gdb_console_fputs):
5717         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5718         functions.
5719         * ui-file.h (gdb_console_fputs): Add prototype.
5720
5721         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5722         back to fputs only if the former returns zero.
5723
5724 2019-03-07  Tom Tromey  <tom@tromey.com>
5725
5726         * symmisc.c (print_symbol_bcache_statistics): Update.
5727         (print_objfile_statistics): Update.
5728         * symfile.c (allocate_symtab): Update.
5729         * stabsread.c: Don't include bcache.h.
5730         * psymtab.h (struct psymbol_bcache): Don't declare.
5731         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5732         (psymbol_bcache_init, psymbol_bcache_free)
5733         (psymbol_bcache_get_bcache): Don't declare.
5734         * psymtab.c (struct psymbol_bcache): Remove.
5735         (psymtab_storage::psymtab_storage): Update.
5736         (psymtab_storage::~psymtab_storage): Update.
5737         (psymbol_bcache_init, psymbol_bcache_free)
5738         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5739         (add_psymbol_to_bcache): Update.
5740         (allocate_psymtab): Update.
5741         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5742         macro_cache>: No longer pointers.
5743         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5744         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5745         * macrotab.c (macro_bcache): Update.
5746         * macroexp.c: Don't include bcache.h.
5747         * gdbtypes.c (check_types_worklist): Update.
5748         (types_deeply_equal): Remove TRY/CATCH.  Update.
5749         * elfread.c (elf_symtab_read): Update.
5750         * dwarf2read.c: Don't include bcache.h.
5751         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5752         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5753         (print_bcache_statistics, bcache_memory_used): Don't declare.
5754         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5755         methods.  Rename all data members.
5756         * bcache.c (struct bcache): Move to bcache.h.
5757         (bcache::expand_hash_table): Rename from expand_hash_table.
5758         (bcache): Remove.
5759         (bcache::insert): Rename from bcache_full.
5760         (bcache::compare): Rename from bcache_compare.
5761         (bcache_xmalloc): Remove.
5762         (bcache::~bcache): Rename from bcache_xfree.
5763         (bcache::print_statistics): Rename from print_bcache_statistics.
5764         (bcache::memory_used): Rename from bcache_memory_used.
5765
5766 2019-03-07  Pedro Alves  <palves@redhat.com>
5767
5768         * infrun.c (normal_stop): Also check for
5769         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5770
5771 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5772
5773         * f-lang.c (value_from_host_double): Moved to...
5774         * value.c (value_from_host_double): ...here.
5775         * value.h (value_from_host_double): Declare.
5776         * guile/scm-math.c (vlscm_convert_typed_number): Use
5777         value_from_host_double.
5778         (vlscm_convert_number): Likewise.
5779         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5780         * python/py-value.c (convert_value_from_python): Likewise.
5781
5782 2019-03-06  Tom Tromey  <tom@tromey.com>
5783
5784         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5785
5786 2019-03-06  Tom Tromey  <tom@tromey.com>
5787
5788         * utils.h (free_current_contents): Don't declare.
5789         * utils.c (free_current_contents): Remove.
5790
5791 2019-03-06  Tom Tromey  <tom@tromey.com>
5792
5793         * top.c (quit_force): Update.
5794         * main.c (captured_command_loop): Update.
5795         * common/new-op.c (operator new): Update.
5796         * common/common-exceptions.c (struct catcher)
5797         <save_cleanup_chain>: Remove member.
5798         (exceptions_state_mc_init): Update.
5799         (exception_try_scope_entry): Return nullptr.
5800         (exception_try_scope_exit, exception_rethrow)
5801         (throw_exception_sjlj, throw_exception_cxx): Update.
5802         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5803         (all_cleanups, do_cleanups, discard_cleanups)
5804         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5805         (restore_cleanups, restore_final_cleanups): Don't declare.
5806         (do_final_cleanups): Remove parameter.
5807         * common/cleanups.c (cleanup_chain, make_cleanup)
5808         (make_cleanup_dtor, all_cleanups, do_cleanups)
5809         (discard_my_cleanups, discard_cleanups)
5810         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5811         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5812         (null_cleanup): Remove.
5813         (do_final_cleanups): Remove parameter.
5814
5815 2019-03-06  Tom Tromey  <tom@tromey.com>
5816
5817         * remote.c (remote_target::remote_parse_stop_reply): Use
5818         unique_xmalloc_ptr.
5819
5820 2019-03-06  Tom Tromey  <tom@tromey.com>
5821
5822         * stabsread.c (struct stabs_field_info): Rename from field_info.
5823         <list, fnlist>: Add initializers.
5824         <obstack>: New member.
5825         (read_member_functions, read_struct_fields, read_baseclasses):
5826         Allocate on obstack.  Don't use cleanups.
5827         (read_one_struct_field, read_member_functions, read_struct_fields)
5828         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5829         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5830         (read_struct_type): Update.
5831
5832 2019-03-06  Tom Tromey  <tom@tromey.com>
5833
5834         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5835         * common/filestuff.h (make_cleanup_close): Don't declare.
5836         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5837         Remove.
5838
5839 2019-03-06  Tom Tromey  <tom@tromey.com>
5840
5841         * solib-aix.c: Use make_scope_exit.
5842
5843 2019-03-06  Tom Tromey  <tom@tromey.com>
5844
5845         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5846         Use make_scope_exit.
5847
5848 2019-03-06  Tom Tromey  <tom@tromey.com>
5849
5850         * solib-svr4.c (disable_probes_interface): Remove parameter.
5851         (svr4_handle_solib_event): Use make_scope_exit.
5852
5853 2019-03-06  Tom Tromey  <tom@tromey.com>
5854
5855         * remote.c (struct stop_reply_deleter): Remove.
5856         (stop_reply_up): Update.
5857         (struct stop_reply): Derive from notif_event.  Don't typedef.
5858         <regcache>: Now a std::vector.
5859         (stop_reply_xfree): Remove.
5860         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5861         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5862         (remote_target::discard_pending_stop_replies): Use delete.
5863         (remote_target::remote_parse_stop_reply): Update.
5864         (remote_target::process_stop_reply): Update.
5865         * remote-notif.h (struct notif_event): Add virtual destructor.
5866         Remove "dtr" member.
5867         (struct notif_client) <alloc_event>: Return a unique_ptr.
5868         (notif_event_xfree): Don't declare.
5869         (notif_event_up): New typedef.
5870         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5871         (notif_event_xfree, do_notif_event_xfree): Remove.
5872         (remote_notif_state_xfree): Update.
5873
5874 2019-03-06  Tom Tromey  <tom@tromey.com>
5875
5876         * infrun.c (displaced_step_clear_cleanup): Now a
5877         forward_scope_exit type.
5878         (displaced_step_prepare_throw): Update.
5879         (displaced_step_fixup): Update.
5880
5881 2019-03-06  Tom Tromey  <tom@tromey.com>
5882
5883         * inferior.h (class inferior): Update comment.
5884         * gdbthread.h (class thread_info): Update comment.
5885
5886 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5887             Tom Tromey  <tom@tromey.com>
5888
5889         * stabsread.h (struct stab_section_list): Remove.
5890         (coffstab_build_psymtabs): Update.
5891         * dbxread.c (symbuf_sections): Now a std::vector.
5892         (sect_idx): New global.
5893         (fill_symbuf): Update.
5894         (coffstab_build_psymtabs): Change type of stabsects parameter.
5895         Update.
5896         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5897         std::vector.
5898         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5899         (coff_locate_sections): Update.
5900         (coff_symfile_read): Remove cleanups.  Update.
5901         (init_stringtab): Add storage parameter.
5902         (free_stringtab, free_stringtab_cleanup): Remove.
5903         (init_lineno): Add storage parameter.
5904         (free_linetab, free_linetab_cleanup): Remove.
5905
5906 2019-03-06  Pedro Alves  <palves@redhat.com>
5907
5908         * linux-fork.c (fork_info::clobber_regs): Delete.
5909         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5910         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5911         comment.  Adjust.
5912         (scoped_switch_fork_info::scoped_switch_fork_info)
5913         (checkpoint_command, linux_fork_context): Adjust
5914         fork_save_infrun_state calls.
5915
5916 2019-03-06  Pedro Alves  <palves@redhat.com>
5917
5918         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5919         (inf_has_multiple_threads): Return 'bool' and rewrite using
5920         inferior_info::threads().
5921
5922 2019-03-06  Pedro Alves  <palves@redhat.com>
5923
5924         * linux-fork.c: Include <list>.
5925         (fork_list): Now a std::list instance.
5926         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5927         (forks_exist_p, find_last_fork): Adjust.
5928         (new_fork): Delete.
5929         (one_fork_p): New.
5930         (add_fork): Adjust.
5931         (free_fork): Delete, folded into fork_info::~fork_info().
5932         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5933         Adjust.
5934         (init_fork_list): Delete.
5935         (linux_fork_killall, linux_fork_mourn_inferior)
5936         (linux_fork_detach, info_checkpoints_command): Adjust.
5937         (_initialize_linux_fork): No longer call init_fork_list.
5938
5939 2019-03-06  Pedro Alves  <palves@redhat.com>
5940
5941         * linux-fork.c (new_fork): New, split out of ...
5942         (add_fork): ... this.  Return void.  Move "first fork" special
5943         case from here, to ...
5944         (checkpoint_command): ... here.
5945         * linux-linux.h (add_fork): Return void.
5946
5947 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5948
5949         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5950
5951 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5952             Chris January  <chris.january@arm.com>
5953             David Lecomber  <david.lecomber@arm.com>
5954
5955         * f-exp.y: New token, UNOP_INTRINSIC.
5956         (exp): New pattern using UNOP_INTRINSIC token.
5957         (f77_keywords): Add 'abs' keyword.
5958         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5959         (value_from_host_double): New function.
5960         (evaluate_subexp_f): Support UNOP_ABS.
5961
5962 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5963
5964         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5965         types.
5966
5967 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5968
5969         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5970         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5971         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5972
5973 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5974
5975         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5976
5977 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5978             Chris January  <chris.january@arm.com>
5979
5980         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5981         * f-exp.y: Define 'KIND' token.
5982         (exp): New pattern for KIND expressions.
5983         (ptype): Handle types with a kind extension.
5984         (direct_abs_decl): Extend to spot kind extensions.
5985         (f77_keywords): Add 'kind' to the list.
5986         (push_kind_type): New function.
5987         (convert_to_kind_type): New function.
5988         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5989         * parse.c (operator_length_standard): Likewise.
5990         * parser-defs.h (enum type_pieces): Add tp_kind.
5991         * std-operator.def: Add UNOP_KIND.
5992
5993 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5994
5995         * f-exp.y (f_parse): Set yydebug.
5996
5997 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5998
5999         * f-lang.c (evaluate_subexp_f): New function.
6000         (exp_descriptor_f): New global.
6001         (f_language_defn): Use exp_descriptor_f instead of
6002         exp_descriptor_standard.
6003
6004 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * f-exp.y (struct token): Add comments.
6007         (dot_ops): Remove uppercase versions and the end marker.
6008         (f77_keywords): Likewise.
6009         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6010         entries in the dot_ops array are case insensitive, and use
6011         strncasecmp to compare strings.  Also some whitespace cleanup in
6012         this area.  Similar for the f77_keywords array, except entries in
6013         this list might be case sensitive.
6014
6015 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6016
6017         * f-exp.y (struct f77_boolean_val): Add comments.
6018         (boolean_values): Remove uppercase versions, and end marker.
6019         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6020         and use strncasecmp to achieve case insensitivity.  Additionally,
6021         perform whitespace cleanup around this code.
6022
6023 2019-03-06  Tom Tromey  <tromey@adacore.com>
6024
6025         * remote-sim.c (gdbsim_target_open): Use result of
6026         gdb_argv::release.
6027
6028 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6029         Dirk Schubert  <dirk.schubert@arm.com>
6030         Chris January  <chris.january@arm.com>
6031
6032         * eval.c (evaluate_subexp_standard): Call Fortran argument
6033         wrapping logic.
6034         * f-lang.c (struct value): A value which can be passed into a
6035         Fortran function call.
6036         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6037         where appropriate.
6038         (struct type): Value ready for a Fortran function call.
6039         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6040         is needed.
6041         * f-lang.h (fortran_argument_convert): Declaration.
6042         (fortran_preserve_arg_pointer): Declaration.
6043         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6044
6045 2019-03-05  Tom Tromey  <tromey@adacore.com>
6046
6047         * python/py-prettyprint.c (print_string_repr): Remove #if.
6048         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6049
6050 2019-03-05  Tom Tromey  <tromey@adacore.com>
6051
6052         * target.c (the_dummy_target): Move later.  Change type to
6053         "dummy_target".
6054         (initialize_targets): Don't initialize the_dummy_target.
6055
6056 2019-03-05  Tom Tromey  <tromey@adacore.com>
6057
6058         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6059         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6060
6061 2019-03-05  Tom Tromey  <tromey@adacore.com>
6062
6063         * windows-nat.c (windows_nat_target::attach)
6064         (windows_nat_target::detach): Don't call gdb_flush.
6065         * valprint.c (generic_val_print, val_print, val_print_string):
6066         Don't call gdb_flush.
6067         * utils.c (defaulted_query): Don't call gdb_flush.
6068         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6069         * target.c (target_announce_detach): Don't call gdb_flush.
6070         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6071         * remote.c (extended_remote_target::attach): Don't call
6072         gdb_flush.
6073         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6074         * printcmd.c (do_examine): Don't call gdb_flush.
6075         (info_display_command): Don't call gdb_flush.
6076         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6077         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6078         * memattr.c (info_mem_command): Don't call gdb_flush.
6079         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6080         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6081         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6082         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6083         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6084         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6085         (gnu_nat_target::detach): Don't call gdb_flush.
6086         * f-valprint.c (f_val_print): Don't call gdb_flush.
6087         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6088         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6089         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6090         gdb_flush.
6091         * c-valprint.c (c_val_print): Don't call gdb_flush.
6092         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6093
6094 2019-03-05  Tom Tromey  <tromey@adacore.com>
6095
6096         * varobj.c (update_dynamic_varobj_children): Update.
6097         (install_default_visualizer): Use reset, not release.
6098         * value.c (set_internalvar): Update.
6099         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6100         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6101         ATTRIBUTE_UNUSED_RESULT.
6102
6103 2019-03-05  Tom Tromey  <tromey@adacore.com>
6104
6105         * remote.c (class scoped_remote_fd) <release>: Add
6106         ATTRIBUTE_UNUSED_RESULT.
6107
6108 2019-03-05  Tom Tromey  <tromey@adacore.com>
6109
6110         * macroexp.c (struct macro_buffer) <release>: Add
6111         ATTRIBUTE_UNUSED_RESULT.
6112
6113 2019-03-05  Tom Tromey  <tromey@adacore.com>
6114
6115         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6116         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6117         ATTRIBUTE_UNUSED_RESULT.
6118
6119 2019-03-05  Tom Tromey  <tromey@adacore.com>
6120
6121         * common/scoped_fd.h (class scoped_fd) <release>: Add
6122         ATTRIBUTE_UNUSED_RESULT.
6123
6124 2019-03-05  Tom Tromey  <tromey@adacore.com>
6125
6126         * parser-defs.h (struct parser_state) <release>: Add
6127         ATTRIBUTE_UNUSED_RESULT.
6128
6129 2019-03-05  Tom Tromey  <tromey@adacore.com>
6130
6131         * utils.h (class gdb_argv) <release>: Add
6132         ATTRIBUTE_UNUSED_RESULT.
6133         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6134
6135 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6136
6137         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6138         for-loop range, to avoid compiler warnings.
6139
6140         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6141         avoid compiler warnings about unused variables.
6142
6143         * NEWS: Mention end of support for native debugging on MS-Windows
6144         before XP.
6145
6146         PR gdb/24292
6147         * common/netstuff.c:
6148         * gdbserver/gdbreplay.c
6149         * gdbserver/remote-utils.c:
6150         * ser-tcp.c:
6151         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6152         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6153         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6154         'getaddrinfo' and 'freeaddrinfo' were not available before
6155         Windows XP, and mingw.org's MinGW headers by default define
6156         _WIN32_WINNT to 0x500.
6157
6158 2019-03-01  Gary Benson <gbenson@redhat.com>
6159
6160         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6161
6162 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6163             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6164
6165         PR gdb/8527
6166         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6167         set_sigint_trap, clear_sigint_trap.
6168
6169 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6170
6171         * target.c (target_detach): Clear the regcache and the
6172         frame cache.
6173
6174 2019-02-27  Pedro Alves  <palves@redhat.com>
6175
6176         * utils.c (set_screen_size): When we cap the height/width sizes,
6177         tweak the corresponding command variable to show "unlimited":
6178
6179 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6180             Pedro Alves  <palves@redhat.com>
6181
6182         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6183         before calling rl_set_screen_size.
6184
6185 2019-02-27  Tom Tromey  <tromey@adacore.com>
6186
6187         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6188         define.
6189         * python/py-value.c: Remove Python 2.4 workaround.
6190         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6191         workaround.
6192         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6193         Python 2.4 workaround.
6194         * python/python-internal.h: Remove Python 2.4 comment.
6195         (Py_ssize_t): Don't define.
6196         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6197         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6198         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6199         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6200         * python/python.c (do_start_initialization): Remove Python 2.4
6201         workaround.
6202         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6203         (print_children): Remove Python 2.4 workaround.
6204         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6205         workaround.
6206         (CHARBUFFERPROC_NAME): Remove.
6207         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6208         Python 2.4 workaround.
6209
6210 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6211
6212         * NEWS: Note minimum Python version.
6213
6214 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6215
6216         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6217         code from these functions.  Remove corresponding ifdefs.  Use
6218         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6219         Remove gotos and target of gotos.
6220         (infpy_search_memory): Likewise.
6221
6222 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6223
6224         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6225         (hppa_gdbarch_init): Don't register deleted functions with
6226         gdbarch.
6227
6228 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6229
6230         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6231         (h8300_unwind_sp): Delete.
6232         (h8300_dummy_id): Delete.
6233         (h8300_gdbarch_init): Don't register deleted functions with
6234         gdbarch.
6235
6236 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6237
6238         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6239         (ft32_unwind_pc): Delete.
6240         (ft32_unwind_sp): Delete.
6241         (ft32_gdbarch_init): Don't register deleted functions with
6242         gdbarch.
6243
6244 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6245
6246         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6247         (frv_unwind_pc): Delete.
6248         (frv_unwind_sp): Delete.
6249         (frv_gdbarch_init): Don't register deleted functions with
6250         gdbarch.
6251
6252 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6253
6254         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6255         (riscv_unwind_pc): Delete.
6256         (riscv_unwind_sp): Delete.
6257         (riscv_gdbarch_init): Don't register deleted functions with
6258         gdbarch.
6259
6260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6261
6262         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6263         (csky_unwind_pc): Delete.
6264         (csky_unwind_sp): Delete.
6265         (csky_gdbarch_init): Don't register deleted functions with
6266         gdbarch.
6267
6268 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6269
6270         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6271         (cris_unwind_pc): Delete.
6272         (cris_unwind_sp): Delete.
6273         (cris_gdbarch_init): Don't register deleted functions with
6274         gdbarch.
6275
6276 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6277
6278         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6279         (bfin_unwind_pc): Delete.
6280         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6281
6282 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6283
6284         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6285         (arm_unwind_pc): Delete.
6286         (arm_unwind_sp): Delete.
6287         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6288
6289 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6290
6291         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6292         (arc_unwind_pc): Delete.
6293         (arc_unwind_sp): Delete.
6294         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6295
6296 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6297
6298         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6299         (alpha_unwind_pc): Delete.
6300         (alpha_gdbarch_init): Don't register deleted functions with
6301         gdbarch.
6302
6303 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6304
6305         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6306         (aarch64_unwind_pc): Delete.
6307         (aarch64_unwind_sp): Delete.
6308         (aarch64_gdbarch_init): Don't register deleted functions with
6309         gdbarch.
6310
6311 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6312
6313         * gdbtypes.c (type_align): Don't consider static members when
6314         computing structure alignment.
6315
6316 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6317
6318         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6319         return 0 for other types.
6320         * arch-utils.c (default_type_align): Always return 0.
6321         * gdbarch.h: Regenerate.
6322         * gdbarch.sh (type_align): Extend comment.
6323         * gdbtypes.c (type_align): Add additional comments, always call
6324         gdbarch_type_align before applying the default rules.
6325         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6326         generic code will then apply a suitable default.
6327         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6328         types, return 0 for other types.
6329
6330 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6331
6332         * NEWS: Create a new section for the next release branch.
6333         Rename the section of the current branch, now that it has
6334         been cut.
6335
6336 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6337
6338         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6339         * version.in: Bump version to 8.3.50.DATE-git.
6340
6341 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6342
6343         * aix-thread.c (ptid_cmp): Remove unused variable.
6344         (get_signaled_thread): Likewise.
6345         (store_regs_user_thread): Likewise.
6346         (store_regs_kernel_thread): Likewise.
6347         (fetch_regs_kernel_thread): Remove shadowed variable.
6348
6349 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6350
6351         * features/riscv/32bit-cpu.xml: Add register numbers.
6352         * features/riscv/32bit-fpu.c: Regenerate.
6353         * features/riscv/32bit-fpu.xml: Add register numbers.
6354         * features/riscv/64bit-cpu.xml: Add register numbers.
6355         * features/riscv/64bit-fpu.c: Regenerate.
6356         * features/riscv/64bit-fpu.xml: Add register numbers.
6357
6358 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6359
6360         * NEWS: Mention two argument form of gdb.Value constructor.
6361         * python/py-value.c (convert_buffer_and_type_to_value): New
6362         function.
6363         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6364         Add support for handling an optional second argument.  Call
6365         convert_buffer_and_type_to_value as appropriate.
6366         * python/python-internal.h (Py_buffer_deleter): New struct.
6367         (Py_buffer_up): New typedef.
6368
6369 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6370
6371         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6372         instead of releasing ownership.
6373
6374 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6375
6376         * dwarf2read.c (open_and_init_dwp_file): Call
6377         elf_numsections instead of bfd_count_sections to initialize
6378         dwp_file->num_sections.
6379
6380 2019-02-25  Tom Tromey  <tromey@adacore.com>
6381
6382         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6383
6384 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6385
6386         * gcore.in: Add '--readnever' option when invoking GDB.
6387
6388 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6389
6390         * MAINTAINERS: Update my email address.
6391
6392 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6393
6394         * build-id.c (build_id_to_debug_bfd_1): New function.
6395         (build_id_to_debug_bfd): Look for separate debug file in
6396         sysroot.
6397
6398 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6399
6400         * gdbarch.sh: Update the copyright year range that is placed into
6401         generated files.
6402
6403 2019-02-22  Keith Seitz  <keiths@redhat.com>
6404
6405         PR symtab/23853
6406         * linespec.c (create_sals_line_offset): Search for the default
6407         symtab's filename instead of its fullname.
6408
6409 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6410
6411         * NEWS: Update style defaults.
6412
6413 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6414
6415         * main.c (captured_main_1): Disable styling in batch mode.
6416
6417 2019-02-20  Tom Tromey  <tom@tromey.com>
6418
6419         * symtab.c (symtab_symbol_info): Fix typos.
6420
6421 2019-02-20  Tom Tromey  <tromey@adacore.com>
6422
6423         * findcmd.c (_initialize_mem_search): Use upper case for
6424         metasyntactic variables.
6425
6426 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6427
6428         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6429         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6430
6431 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6432
6433         * top.h (source_file_name): Change to std::string.
6434         * top.c (source_file_name): Likewise.
6435         (command_line_input): Adjust.
6436         * cli/cli-script.c (script_from_file): Adjust.
6437
6438 2019-02-19  Tom Tromey  <tromey@adacore.com>
6439
6440         * ravenscar-thread.c
6441         (ravenscar_thread_target::update_thread_list): Don't call
6442         ada_build_task_list.
6443         * ada-lang.h (ada_build_task_list): Don't declare.
6444         * ada-tasks.c (struct ada_tasks_inferior_data)
6445         <task_list_valid_p>: Now bool.
6446         (read_known_tasks, ada_task_list_changed)
6447         (ada_tasks_invalidate_inferior_data): Update.
6448         (read_known_tasks_array): Return bool.
6449         (read_known_tasks_list): Likewise.
6450         (read_known_tasks): Return void.
6451         (ada_build_task_list): Now static.
6452
6453 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6454
6455         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6456         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6457
6458 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6459
6460         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6461         variant for ada_tasks_pspace_data_handle and
6462         ada_tasks_inferior_data_handle.
6463         (ada_tasks_pspace_data_cleanup): New function.
6464         (ada_tasks_inferior_data_cleanup): New function.
6465
6466 2019-02-17  Tom Tromey  <tom@tromey.com>
6467
6468         * macrotab.h (macro_source_fullname): Return a std::string.
6469         * macrotab.c (macro_include, check_for_redefinition)
6470         (macro_undef, macro_lookup_definition, foreach_macro)
6471         (foreach_macro_in_scope): Update.
6472         (macro_source_fullname): Return a std::string.
6473         * macrocmd.c (show_pp_source_pos): Update.
6474
6475 2019-02-17  Tom Tromey  <tom@tromey.com>
6476
6477         * macrocmd.c (show_pp_source_pos): Style the file names.
6478
6479 2019-02-17  Tom Tromey  <tom@tromey.com>
6480
6481         PR tui/24197:
6482         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6483
6484 2019-02-17  Tom Tromey  <tom@tromey.com>
6485
6486         * ada-lang.c (user_select_syms): Use filtered printing.
6487         * utils.c (wrap_style): New global.
6488         (desired_style): Remove.
6489         (emit_style_escape): Add stream parameter.
6490         (set_output_style, reset_terminal_style, prompt_for_continue):
6491         Update.
6492         (flush_wrap_buffer): Only flush gdb_stdout.
6493         (wrap_here): Set wrap_style.
6494         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6495         treat escape sequences as a character.  Change when wrap buffer is
6496         flushed.
6497         (fputs_styled): Do not set the output style when the default is
6498         requested.
6499         * ui-style.h (struct ui_file_style) <is_default>: New method.
6500         * source.c (print_source_lines_base): Emit escape sequences in one
6501         piece.
6502
6503 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6504
6505         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6506         integers and enumeration types.
6507
6508 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6509
6510         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6511         instead of lookup_symbol_in_language
6512         (do_exact_match): New function.
6513         (ada_get_symbol_name_matcher): Return do_exact_match when
6514         doing a verbatim match.
6515
6516 2019-02-15  Tom Tromey  <tromey@adacore.com>
6517
6518         * ravenscar-thread.c (ravenscar_thread_target::resume)
6519         (ravenscar_thread_target::wait): Special case wildcard requests.
6520
6521 2019-02-15  Tom Tromey  <tromey@adacore.com>
6522
6523         * ravenscar-thread.c (base_ptid): Remove.
6524         (struct ravenscar_thread_target) <close>: New method.
6525         <m_base_ptid>: New member.
6526         <update_inferior_ptid, active_task, task_is_currently_active,
6527         runtime_initialized>: Declare methods.
6528         <ravenscar_thread_target>: Add constructor.
6529         (ravenscar_thread_target::task_is_currently_active)
6530         (ravenscar_thread_target::update_inferior_ptid)
6531         (ravenscar_runtime_initialized): Rename.  Now methods.
6532         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6533         (ravenscar_thread_target::update_thread_list): Update.
6534         (ravenscar_thread_target::active_task): Now method.
6535         (ravenscar_thread_target::store_registers)
6536         (ravenscar_thread_target::prepare_to_store)
6537         (ravenscar_thread_target::prepare_to_store)
6538         (ravenscar_thread_target::mourn_inferior): Update.
6539         (ravenscar_inferior_created): Use "new" to create target.
6540         (ravenscar_thread_target::get_ada_task_ptid): Update.
6541         (_initialize_ravenscar): Don't initialize base_ptid.
6542         (ravenscar_ops): Remove global.
6543
6544 2019-02-15  Tom Tromey  <tromey@adacore.com>
6545
6546         * target.h (push_target): Declare new overload.
6547         * target.c (push_target): New overload, taking an rvalue reference.
6548         * remote.c (remote_target::open_1): Use push_target overload.
6549         * corelow.c (core_target_open): Use push_target overload.
6550
6551 2019-02-15  Tom Tromey  <tromey@adacore.com>
6552
6553         * ravenscar-thread.c (is_ravenscar_task)
6554         (ravenscar_task_is_currently_active): Return bool.
6555         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6556         (_initialize_ravenscar): Remove "(void)".
6557         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6558         Return bool.
6559
6560 2019-02-15  Tom Tromey  <tromey@adacore.com>
6561
6562         * ravenscar-thread.c (ravenscar_runtime_initializer)
6563         (has_ravenscar_runtime, get_running_thread_id)
6564         (ravenscar_thread_target::resume): Fix indentation.
6565
6566 2019-02-15  Tom Tromey  <tromey@adacore.com>
6567
6568         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6569         from ravenscar_arch_ops.
6570         (sparc_ravenscar_ops::fetch_registers)
6571         (sparc_ravenscar_ops::store_registers): Now methods.
6572         (sparc_ravenscar_prepare_to_store): Remove.
6573         (sparc_ravenscar_ops): Redefine.
6574         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6575         methods and destructor.  Remove members.
6576         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6577         (ravenscar_thread_target::store_registers)
6578         (ravenscar_thread_target::prepare_to_store): Update.
6579         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6580         Remove.
6581         (struct ppc_ravenscar_powerpc_ops): Derive from
6582         ravenscar_arch_ops.
6583         (ppc_ravenscar_powerpc_ops::fetch_registers)
6584         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6585         (ppc_ravenscar_powerpc_ops): Redefine.
6586         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6587         (ppc_ravenscar_e500_ops::fetch_registers)
6588         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6589         (ppc_ravenscar_e500_ops): Redefine.
6590         * aarch64-ravenscar-thread.c
6591         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6592         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6593         (aarch64_ravenscar_fetch_registers)
6594         (aarch64_ravenscar_store_registers): Now methods.
6595         (aarch64_ravenscar_ops): Redefine.
6596
6597 2019-02-15  Tom Tromey  <tromey@adacore.com>
6598
6599         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6600         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6601         (ravenscar_thread_target::stopped_by_watchpoint)
6602         (ravenscar_thread_target::stopped_data_address)
6603         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6604
6605 2019-02-15  Tom Tromey  <tromey@adacore.com>
6606
6607         * ravenscar-thread.c: Fix some typos.
6608
6609 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6610             Tom Tromey  <tromey@adacore.com>
6611
6612         * ada-lang.c (ada_exception_sal): Change addr_string to a
6613         std::string.
6614         (create_ada_exception_catchpoint): Update.
6615
6616 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6617             Tom Tromey  <tromey@adacore.com>
6618
6619         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6620         (bp_location_ops): Remove.
6621         (base_breakpoint_allocate_location): Update.
6622         (free_bp_location): Update.
6623         * ada-lang.c (class ada_catchpoint_location)
6624         <ada_catchpoint_location>: Remove ops parameter.
6625         (ada_catchpoint_location_dtor): Remove.
6626         (ada_catchpoint_location_ops): Remove.
6627         (allocate_location_exception): Update.
6628         * breakpoint.h (struct bp_location_ops): Remove.
6629         (class bp_location) <bp_location>: Remove bp_location_ops
6630         parameter.
6631         <~bp_location>: Add destructor.
6632         <ops>: Remove.
6633
6634 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6635             Pedro Alves  <palves@redhat.com>
6636
6637         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6638         'PATH_MAX'.
6639
6640 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6641             Samuel Thibault  <samuel.thibault@gnu.org>
6642             Thomas Schwinge  <thomas@codesourcery.com>
6643
6644         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6645         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6646
6647 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6648
6649         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6650         (check_empty): Use "const char *".
6651
6652         * gnu-nat.c (gnu_nat_target::detach): Instead of
6653         'detach_inferior (pid)' call
6654         'detach_inferior (find_inferior_pid (pid))'.
6655
6656         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6657         'nat/fork-inferior.o'.
6658         * gnu-nat.c: #include "nat/fork-inferior.h".
6659
6660         * gnu-nat.c (gnu_nat_target::detach): Instead of
6661         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6662         * gnu-nat.h: #include "inf-child.h".
6663         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6664         'i386_gnu_nat_target::fetch_registers'.
6665         (gnu_store_registers): Rename/move to
6666         'i386_gnu_nat_target::store_registers'.
6667
6668         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6669         * gnu-nat.h (mach_thread_info): New function.
6670         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6671
6672         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6673
6674 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6675
6676         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6677
6678 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6679
6680         * windows-nat.c (windows_add_thread): Add new parameter
6681         "main_thread_p" with default value set to false.  Update
6682         function documentation as well as all callers.
6683         (windows_delete_thread): Likewise.
6684         (fake_create_process): Update call to windows_add_thread.
6685         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6686         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6687         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6688         call to windows_delete_thread.
6689
6690 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6691
6692         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6693
6694 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6695
6696         * symfile.c (find_separate_debug_file): Use canonical path of
6697         sysroot with child_path instead of gdb_sysroot if it is valid.
6698
6699 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6700
6701         * symfile.c (find_separate_debug_file): Use child_path to
6702         determine if an object file is under a sysroot.
6703
6704 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6705
6706         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6707         unittests/child-path-selftests.c.
6708         * common/pathstuff.c (child_path): New function.
6709         * common/pathstuff.h (child_path): New prototype.
6710         * unittests/child-path-selftests.c: New file.
6711
6712 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6713
6714         * symfile.c (find_separate_debug_file): Look for separate debug
6715         files in debug directories under the sysroot.
6716
6717 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6718
6719         * symtab.h (struct minimal_symbol data_p): New const method.
6720         (struct minimal_symbol text_p): Likewise.
6721         * symtab.c (output_source_filename): Use file name style
6722         to print file name.
6723         (print_symbol_info): Likewise.
6724         (print_msymbol_info): Use address style to print addresses.
6725         Use function name style to print executable text symbols.
6726         (expand_symtab_containing_pc): Use data_p.
6727         (find_pc_sect_compunit_symtab): Likewise.
6728
6729 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6730
6731         * breakpoint.c (describe_other_breakpoints): Use address style
6732         to print addresses.
6733         (say_where): Likewise.
6734
6735 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6736
6737         * ada-typeprint.c (print_func_type): Print function name
6738         style to print function name.
6739         * c-typeprint.c (c_print_type_1): Likewise.
6740
6741 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6742
6743         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6744         for execve.
6745
6746 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6747
6748         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6749         type_stack.
6750
6751 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6752
6753         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6754         TYPE_CODE_REF types.
6755
6756 2019-02-08  Jim Wilson  <jimw@sifive.com>
6757
6758         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6759         (riscv_linux_fregset): New.
6760         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6761
6762 2019-02-07  Tom Tromey  <tom@tromey.com>
6763
6764         * thread.c (thread_cancel_execution_command): Update.
6765         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6766         methods.
6767         (struct thread_fsm_ops): Remove.
6768         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6769         (thread_fsm_should_stop, thread_fsm_return_value)
6770         (thread_fsm_set_finished, thread_fsm_finished_p)
6771         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6772         Don't declare.
6773         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6774         * infrun.c (clear_proceed_status_thread)
6775         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6776         (print_stop_event): Update.
6777         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6778         Add constructor.
6779         (step_command_fsm_ops): Remove.
6780         (new_step_command_fsm): Remove.
6781         (step_1): Update.
6782         (step_command_fsm::should_stop): Rename from
6783         step_command_fsm_should_stop.
6784         (step_command_fsm::clean_up): Rename from
6785         step_command_fsm_clean_up.
6786         (step_command_fsm::do_async_reply_reason): Rename from
6787         step_command_fsm_async_reply_reason.
6788         (struct until_next_fsm): Inherit from thread_fsm.  Add
6789         constructor.
6790         (until_next_fsm_ops): Remove.
6791         (new_until_next_fsm): Remove.
6792         (until_next_fsm::should_stop): Rename from
6793         until_next_fsm_should_stop.
6794         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6795         (until_next_fsm::do_async_reply_reason): Rename from
6796         until_next_fsm_async_reply_reason.
6797         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6798         constructor.  Change type of breakpoint.
6799         (finish_command_fsm_ops): Remove.
6800         (new_finish_command_fsm): Remove.
6801         (finish_command_fsm::should_stop): Rename from
6802         finish_command_fsm_should_stop.
6803         (finish_command_fsm::clean_up): Rename from
6804         finish_command_fsm_clean_up.
6805         (finish_command_fsm::return_value): Rename from
6806         finish_command_fsm_return_value.
6807         (finish_command_fsm::do_async_reply_reason): Rename from
6808         finish_command_fsm_async_reply_reason.
6809         (finish_command): Update.
6810         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6811         Add constructor.
6812         (call_thread_fsm_ops): Remove.
6813         (call_thread_fsm::call_thread_fsm): Rename from
6814         new_call_thread_fsm.
6815         (call_thread_fsm::should_stop): Rename from
6816         call_thread_fsm_should_stop.
6817         (call_thread_fsm::should_notify_stop): Rename from
6818         call_thread_fsm_should_notify_stop.
6819         (run_inferior_call, call_function_by_hand_dummy): Update.
6820         * cli/cli-interp.c (should_print_stop_to_console): Update.
6821         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6822         Add constructor.  Change type of location_breakpoint,
6823         caller_breakpoint.
6824         (until_break_fsm_ops): Remove.
6825         (new_until_break_fsm): Remove.
6826         (until_break_fsm::should_stop): Rename from
6827         until_break_fsm_should_stop.
6828         (until_break_fsm::clean_up): Rename from
6829         until_break_fsm_clean_up.
6830         (until_break_fsm::do_async_reply_reason): Rename from
6831         until_break_fsm_async_reply_reason.
6832         (until_break_command): Update.
6833         * thread-fsm.c: Remove.
6834         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6835
6836 2019-02-07  Tom Tromey  <tom@tromey.com>
6837
6838         * yy-remap.h: Add include guard.
6839         * xtensa-tdep.h: Add include guard.
6840         * xcoffread.h: Rename include guard.
6841         * varobj-iter.h: Add include guard.
6842         * tui/tui.h: Rename include guard.
6843         * tui/tui-winsource.h: Rename include guard.
6844         * tui/tui-wingeneral.h: Rename include guard.
6845         * tui/tui-windata.h: Rename include guard.
6846         * tui/tui-win.h: Rename include guard.
6847         * tui/tui-stack.h: Rename include guard.
6848         * tui/tui-source.h: Rename include guard.
6849         * tui/tui-regs.h: Rename include guard.
6850         * tui/tui-out.h: Rename include guard.
6851         * tui/tui-layout.h: Rename include guard.
6852         * tui/tui-io.h: Rename include guard.
6853         * tui/tui-hooks.h: Rename include guard.
6854         * tui/tui-file.h: Rename include guard.
6855         * tui/tui-disasm.h: Rename include guard.
6856         * tui/tui-data.h: Rename include guard.
6857         * tui/tui-command.h: Rename include guard.
6858         * tic6x-tdep.h: Add include guard.
6859         * target/waitstatus.h: Rename include guard.
6860         * target/wait.h: Rename include guard.
6861         * target/target.h: Rename include guard.
6862         * target/resume.h: Rename include guard.
6863         * target-float.h: Rename include guard.
6864         * stabsread.h: Add include guard.
6865         * rs6000-tdep.h: Add include guard.
6866         * riscv-fbsd-tdep.h: Add include guard.
6867         * regformats/regdef.h: Rename include guard.
6868         * record.h: Rename include guard.
6869         * python/python.h: Rename include guard.
6870         * python/python-internal.h: Rename include guard.
6871         * python/py-stopevent.h: Rename include guard.
6872         * python/py-ref.h: Rename include guard.
6873         * python/py-record.h: Rename include guard.
6874         * python/py-record-full.h: Rename include guard.
6875         * python/py-record-btrace.h: Rename include guard.
6876         * python/py-instruction.h: Rename include guard.
6877         * python/py-events.h: Rename include guard.
6878         * python/py-event.h: Rename include guard.
6879         * procfs.h: Add include guard.
6880         * proc-utils.h: Add include guard.
6881         * p-lang.h: Add include guard.
6882         * or1k-tdep.h: Rename include guard.
6883         * observable.h: Rename include guard.
6884         * nto-tdep.h: Rename include guard.
6885         * nat/x86-linux.h: Rename include guard.
6886         * nat/x86-linux-dregs.h: Rename include guard.
6887         * nat/x86-gcc-cpuid.h: Add include guard.
6888         * nat/x86-dregs.h: Rename include guard.
6889         * nat/x86-cpuid.h: Rename include guard.
6890         * nat/ppc-linux.h: Rename include guard.
6891         * nat/mips-linux-watch.h: Rename include guard.
6892         * nat/linux-waitpid.h: Rename include guard.
6893         * nat/linux-ptrace.h: Rename include guard.
6894         * nat/linux-procfs.h: Rename include guard.
6895         * nat/linux-osdata.h: Rename include guard.
6896         * nat/linux-nat.h: Rename include guard.
6897         * nat/linux-namespaces.h: Rename include guard.
6898         * nat/linux-btrace.h: Rename include guard.
6899         * nat/glibc_thread_db.h: Rename include guard.
6900         * nat/gdb_thread_db.h: Rename include guard.
6901         * nat/gdb_ptrace.h: Rename include guard.
6902         * nat/fork-inferior.h: Rename include guard.
6903         * nat/amd64-linux-siginfo.h: Rename include guard.
6904         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6905         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6906         * nat/aarch64-linux.h: Rename include guard.
6907         * nat/aarch64-linux-hw-point.h: Rename include guard.
6908         * mn10300-tdep.h: Add include guard.
6909         * mips-linux-tdep.h: Add include guard.
6910         * mi/mi-parse.h: Rename include guard.
6911         * mi/mi-out.h: Rename include guard.
6912         * mi/mi-main.h: Rename include guard.
6913         * mi/mi-interp.h: Rename include guard.
6914         * mi/mi-getopt.h: Rename include guard.
6915         * mi/mi-console.h: Rename include guard.
6916         * mi/mi-common.h: Rename include guard.
6917         * mi/mi-cmds.h: Rename include guard.
6918         * mi/mi-cmd-break.h: Rename include guard.
6919         * m2-lang.h: Add include guard.
6920         * location.h: Rename include guard.
6921         * linux-record.h: Rename include guard.
6922         * linux-nat.h: Add include guard.
6923         * linux-fork.h: Add include guard.
6924         * i386-darwin-tdep.h: Rename include guard.
6925         * hppa-linux-offsets.h: Add include guard.
6926         * guile/guile.h: Rename include guard.
6927         * guile/guile-internal.h: Rename include guard.
6928         * gnu-nat.h: Rename include guard.
6929         * gdb-stabs.h: Rename include guard.
6930         * frv-tdep.h: Add include guard.
6931         * f-lang.h: Add include guard.
6932         * event-loop.h: Add include guard.
6933         * darwin-nat.h: Rename include guard.
6934         * cp-abi.h: Rename include guard.
6935         * config/sparc/nm-sol2.h: Rename include guard.
6936         * config/nm-nto.h: Rename include guard.
6937         * config/nm-linux.h: Add include guard.
6938         * config/i386/nm-i386gnu.h: Rename include guard.
6939         * config/djgpp/nl_types.h: Rename include guard.
6940         * config/djgpp/langinfo.h: Rename include guard.
6941         * compile/gcc-cp-plugin.h: Add include guard.
6942         * compile/gcc-c-plugin.h: Add include guard.
6943         * compile/compile.h: Rename include guard.
6944         * compile/compile-object-run.h: Rename include guard.
6945         * compile/compile-object-load.h: Rename include guard.
6946         * compile/compile-internal.h: Rename include guard.
6947         * compile/compile-cplus.h: Rename include guard.
6948         * compile/compile-c.h: Rename include guard.
6949         * common/xml-utils.h: Rename include guard.
6950         * common/x86-xstate.h: Rename include guard.
6951         * common/version.h: Rename include guard.
6952         * common/vec.h: Rename include guard.
6953         * common/tdesc.h: Rename include guard.
6954         * common/selftest.h: Rename include guard.
6955         * common/scoped_restore.h: Rename include guard.
6956         * common/scoped_mmap.h: Rename include guard.
6957         * common/scoped_fd.h: Rename include guard.
6958         * common/safe-iterator.h: Rename include guard.
6959         * common/run-time-clock.h: Rename include guard.
6960         * common/refcounted-object.h: Rename include guard.
6961         * common/queue.h: Rename include guard.
6962         * common/ptid.h: Rename include guard.
6963         * common/print-utils.h: Rename include guard.
6964         * common/preprocessor.h: Rename include guard.
6965         * common/pathstuff.h: Rename include guard.
6966         * common/observable.h: Rename include guard.
6967         * common/netstuff.h: Rename include guard.
6968         * common/job-control.h: Rename include guard.
6969         * common/host-defs.h: Rename include guard.
6970         * common/gdb_wait.h: Rename include guard.
6971         * common/gdb_vecs.h: Rename include guard.
6972         * common/gdb_unlinker.h: Rename include guard.
6973         * common/gdb_unique_ptr.h: Rename include guard.
6974         * common/gdb_tilde_expand.h: Rename include guard.
6975         * common/gdb_sys_time.h: Rename include guard.
6976         * common/gdb_string_view.h: Rename include guard.
6977         * common/gdb_splay_tree.h: Rename include guard.
6978         * common/gdb_setjmp.h: Rename include guard.
6979         * common/gdb_ref_ptr.h: Rename include guard.
6980         * common/gdb_optional.h: Rename include guard.
6981         * common/gdb_locale.h: Rename include guard.
6982         * common/gdb_assert.h: Rename include guard.
6983         * common/filtered-iterator.h: Rename include guard.
6984         * common/filestuff.h: Rename include guard.
6985         * common/fileio.h: Rename include guard.
6986         * common/environ.h: Rename include guard.
6987         * common/common-utils.h: Rename include guard.
6988         * common/common-types.h: Rename include guard.
6989         * common/common-regcache.h: Rename include guard.
6990         * common/common-inferior.h: Rename include guard.
6991         * common/common-gdbthread.h: Rename include guard.
6992         * common/common-exceptions.h: Rename include guard.
6993         * common/common-defs.h: Rename include guard.
6994         * common/common-debug.h: Rename include guard.
6995         * common/cleanups.h: Rename include guard.
6996         * common/buffer.h: Rename include guard.
6997         * common/btrace-common.h: Rename include guard.
6998         * common/break-common.h: Rename include guard.
6999         * cli/cli-utils.h: Rename include guard.
7000         * cli/cli-style.h: Rename include guard.
7001         * cli/cli-setshow.h: Rename include guard.
7002         * cli/cli-script.h: Rename include guard.
7003         * cli/cli-interp.h: Rename include guard.
7004         * cli/cli-decode.h: Rename include guard.
7005         * cli/cli-cmds.h: Rename include guard.
7006         * charset-list.h: Add include guard.
7007         * buildsym-legacy.h: Rename include guard.
7008         * bfin-tdep.h: Add include guard.
7009         * ax.h: Rename include guard.
7010         * arm-linux-tdep.h: Add include guard.
7011         * arm-fbsd-tdep.h: Add include guard.
7012         * arch/xtensa.h: Rename include guard.
7013         * arch/tic6x.h: Add include guard.
7014         * arch/i386.h: Add include guard.
7015         * arch/arm.h: Rename include guard.
7016         * arch/arm-linux.h: Rename include guard.
7017         * arch/arm-get-next-pcs.h: Rename include guard.
7018         * arch/amd64.h: Add include guard.
7019         * arch/aarch64-insn.h: Rename include guard.
7020         * arch-utils.h: Rename include guard.
7021         * annotate.h: Add include guard.
7022         * amd64-darwin-tdep.h: Rename include guard.
7023         * aarch64-linux-tdep.h: Add include guard.
7024         * aarch64-fbsd-tdep.h: Add include guard.
7025         * aarch32-linux-nat.h: Add include guard.
7026
7027 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7028
7029         * macrotab.c (macro_define_internal): New function that
7030         factorizes macro_define_object_internal and macro_define_function
7031         code.
7032         (macro_define_object_internal): Use macro_define_internal.
7033         (macro_define_function): Likewise.
7034
7035 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7036
7037         * macrocmd.c (extract_identifier): Return
7038         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7039         callers.
7040
7041 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7042
7043         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7044
7045 2019-02-05  Tom Tromey  <tom@tromey.com>
7046
7047         * target.c (target_stack::unpush): Move assertion earlier.
7048
7049 2019-01-30  Tom Tromey  <tom@tromey.com>
7050
7051         PR python/23615:
7052         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7053         (gdbpy_parse_and_eval): Likewise.
7054         * python/python-internal.h (gdbpy_allow_threads): New class.
7055
7056 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7057
7058         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7059         (aarch64_fbsd_fpregmap): Move earlier.
7060         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7061         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7062         instead of individual calls to trad_frame_set_reg_addr.
7063         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7064         earlier.
7065         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7066         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7067         instead of individual calls to trad_frame_set_reg_addr.
7068
7069 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7070
7071         * CONTRIBUTE: Replace contribution list with wiki link.
7072
7073 2019-01-25  Tom Tromey  <tom@tromey.com>
7074
7075         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7076
7077 2019-01-25  Tom Tromey  <tom@tromey.com>
7078
7079         * xtensa-linux-nat.c: Fix common/ includes.
7080         * xml-support.h: Fix common/ includes.
7081         * xml-support.c: Fix common/ includes.
7082         * x86-linux-nat.c: Fix common/ includes.
7083         * windows-nat.c: Fix common/ includes.
7084         * varobj.h: Fix common/ includes.
7085         * varobj.c: Fix common/ includes.
7086         * value.c: Fix common/ includes.
7087         * valops.c: Fix common/ includes.
7088         * utils.c: Fix common/ includes.
7089         * unittests/xml-utils-selftests.c: Fix common/ includes.
7090         * unittests/utils-selftests.c: Fix common/ includes.
7091         * unittests/unpack-selftests.c: Fix common/ includes.
7092         * unittests/tracepoint-selftests.c: Fix common/ includes.
7093         * unittests/style-selftests.c: Fix common/ includes.
7094         * unittests/string_view-selftests.c: Fix common/ includes.
7095         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7096         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7097         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7098         * unittests/rsp-low-selftests.c: Fix common/ includes.
7099         * unittests/parse-connection-spec-selftests.c: Fix common/
7100         includes.
7101         * unittests/optional-selftests.c: Fix common/ includes.
7102         * unittests/offset-type-selftests.c: Fix common/ includes.
7103         * unittests/observable-selftests.c: Fix common/ includes.
7104         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7105         * unittests/memrange-selftests.c: Fix common/ includes.
7106         * unittests/memory-map-selftests.c: Fix common/ includes.
7107         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7108         * unittests/function-view-selftests.c: Fix common/ includes.
7109         * unittests/environ-selftests.c: Fix common/ includes.
7110         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7111         * unittests/common-utils-selftests.c: Fix common/ includes.
7112         * unittests/cli-utils-selftests.c: Fix common/ includes.
7113         * unittests/array-view-selftests.c: Fix common/ includes.
7114         * ui-file.c: Fix common/ includes.
7115         * tui/tui-io.c: Fix common/ includes.
7116         * tracepoint.h: Fix common/ includes.
7117         * tracepoint.c: Fix common/ includes.
7118         * tracefile-tfile.c: Fix common/ includes.
7119         * top.h: Fix common/ includes.
7120         * top.c: Fix common/ includes.
7121         * thread.c: Fix common/ includes.
7122         * target/waitstatus.h: Fix common/ includes.
7123         * target/waitstatus.c: Fix common/ includes.
7124         * target.h: Fix common/ includes.
7125         * target.c: Fix common/ includes.
7126         * target-memory.c: Fix common/ includes.
7127         * target-descriptions.c: Fix common/ includes.
7128         * symtab.h: Fix common/ includes.
7129         * symfile.c: Fix common/ includes.
7130         * stap-probe.c: Fix common/ includes.
7131         * spu-linux-nat.c: Fix common/ includes.
7132         * sparc-nat.c: Fix common/ includes.
7133         * source.c: Fix common/ includes.
7134         * solib.c: Fix common/ includes.
7135         * solib-target.c: Fix common/ includes.
7136         * ser-unix.c: Fix common/ includes.
7137         * ser-tcp.c: Fix common/ includes.
7138         * ser-pipe.c: Fix common/ includes.
7139         * ser-base.c: Fix common/ includes.
7140         * selftest-arch.c: Fix common/ includes.
7141         * s12z-tdep.c: Fix common/ includes.
7142         * rust-exp.y: Fix common/ includes.
7143         * rs6000-aix-tdep.c: Fix common/ includes.
7144         * riscv-tdep.c: Fix common/ includes.
7145         * remote.c: Fix common/ includes.
7146         * remote-notif.h: Fix common/ includes.
7147         * remote-fileio.h: Fix common/ includes.
7148         * remote-fileio.c: Fix common/ includes.
7149         * regcache.h: Fix common/ includes.
7150         * regcache.c: Fix common/ includes.
7151         * record-btrace.c: Fix common/ includes.
7152         * python/python.c: Fix common/ includes.
7153         * python/py-type.c: Fix common/ includes.
7154         * python/py-inferior.c: Fix common/ includes.
7155         * progspace.h: Fix common/ includes.
7156         * producer.c: Fix common/ includes.
7157         * procfs.c: Fix common/ includes.
7158         * proc-api.c: Fix common/ includes.
7159         * printcmd.c: Fix common/ includes.
7160         * ppc-linux-nat.c: Fix common/ includes.
7161         * parser-defs.h: Fix common/ includes.
7162         * osdata.c: Fix common/ includes.
7163         * obsd-nat.c: Fix common/ includes.
7164         * nat/x86-linux.c: Fix common/ includes.
7165         * nat/x86-linux-dregs.c: Fix common/ includes.
7166         * nat/x86-dregs.h: Fix common/ includes.
7167         * nat/x86-dregs.c: Fix common/ includes.
7168         * nat/ppc-linux.c: Fix common/ includes.
7169         * nat/mips-linux-watch.h: Fix common/ includes.
7170         * nat/mips-linux-watch.c: Fix common/ includes.
7171         * nat/linux-waitpid.c: Fix common/ includes.
7172         * nat/linux-ptrace.h: Fix common/ includes.
7173         * nat/linux-ptrace.c: Fix common/ includes.
7174         * nat/linux-procfs.c: Fix common/ includes.
7175         * nat/linux-personality.c: Fix common/ includes.
7176         * nat/linux-osdata.c: Fix common/ includes.
7177         * nat/linux-namespaces.c: Fix common/ includes.
7178         * nat/linux-btrace.h: Fix common/ includes.
7179         * nat/linux-btrace.c: Fix common/ includes.
7180         * nat/fork-inferior.c: Fix common/ includes.
7181         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7182         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7183         * nat/aarch64-linux.c: Fix common/ includes.
7184         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7185         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7186         * namespace.h: Fix common/ includes.
7187         * mips-linux-tdep.c: Fix common/ includes.
7188         * minsyms.c: Fix common/ includes.
7189         * mi/mi-parse.h: Fix common/ includes.
7190         * mi/mi-main.c: Fix common/ includes.
7191         * mi/mi-cmd-env.c: Fix common/ includes.
7192         * memrange.h: Fix common/ includes.
7193         * memattr.c: Fix common/ includes.
7194         * maint.h: Fix common/ includes.
7195         * maint.c: Fix common/ includes.
7196         * main.c: Fix common/ includes.
7197         * machoread.c: Fix common/ includes.
7198         * location.c: Fix common/ includes.
7199         * linux-thread-db.c: Fix common/ includes.
7200         * linux-nat.c: Fix common/ includes.
7201         * linux-fork.c: Fix common/ includes.
7202         * inline-frame.c: Fix common/ includes.
7203         * infrun.c: Fix common/ includes.
7204         * inflow.c: Fix common/ includes.
7205         * inferior.h: Fix common/ includes.
7206         * inferior.c: Fix common/ includes.
7207         * infcmd.c: Fix common/ includes.
7208         * inf-ptrace.c: Fix common/ includes.
7209         * inf-child.c: Fix common/ includes.
7210         * ia64-linux-nat.c: Fix common/ includes.
7211         * i387-tdep.c: Fix common/ includes.
7212         * i386-tdep.c: Fix common/ includes.
7213         * i386-linux-tdep.c: Fix common/ includes.
7214         * i386-linux-nat.c: Fix common/ includes.
7215         * i386-go32-tdep.c: Fix common/ includes.
7216         * i386-fbsd-tdep.c: Fix common/ includes.
7217         * i386-fbsd-nat.c: Fix common/ includes.
7218         * guile/scm-type.c: Fix common/ includes.
7219         * guile/guile.c: Fix common/ includes.
7220         * go32-nat.c: Fix common/ includes.
7221         * gnu-nat.c: Fix common/ includes.
7222         * gdbthread.h: Fix common/ includes.
7223         * gdbarch-selftests.c: Fix common/ includes.
7224         * gdb_usleep.c: Fix common/ includes.
7225         * gdb_select.h: Fix common/ includes.
7226         * gdb_bfd.c: Fix common/ includes.
7227         * gcore.c: Fix common/ includes.
7228         * fork-child.c: Fix common/ includes.
7229         * findvar.c: Fix common/ includes.
7230         * fbsd-nat.c: Fix common/ includes.
7231         * event-top.c: Fix common/ includes.
7232         * event-loop.c: Fix common/ includes.
7233         * dwarf2read.c: Fix common/ includes.
7234         * dwarf2loc.c: Fix common/ includes.
7235         * dwarf2-frame.c: Fix common/ includes.
7236         * dwarf-index-cache.c: Fix common/ includes.
7237         * dtrace-probe.c: Fix common/ includes.
7238         * disasm-selftests.c: Fix common/ includes.
7239         * defs.h: Fix common/ includes.
7240         * csky-tdep.c: Fix common/ includes.
7241         * cp-valprint.c: Fix common/ includes.
7242         * cp-support.h: Fix common/ includes.
7243         * cp-support.c: Fix common/ includes.
7244         * corelow.c: Fix common/ includes.
7245         * completer.h: Fix common/ includes.
7246         * completer.c: Fix common/ includes.
7247         * compile/compile.c: Fix common/ includes.
7248         * compile/compile-loc2c.c: Fix common/ includes.
7249         * compile/compile-cplus-types.c: Fix common/ includes.
7250         * compile/compile-cplus-symbols.c: Fix common/ includes.
7251         * command.h: Fix common/ includes.
7252         * cli/cli-dump.c: Fix common/ includes.
7253         * cli/cli-cmds.c: Fix common/ includes.
7254         * charset.c: Fix common/ includes.
7255         * build-id.c: Fix common/ includes.
7256         * btrace.h: Fix common/ includes.
7257         * btrace.c: Fix common/ includes.
7258         * breakpoint.h: Fix common/ includes.
7259         * breakpoint.c: Fix common/ includes.
7260         * ax.h:
7261         (enum agent_op): Fix common/ includes.
7262         * ax-general.c (struct aop_map): Fix common/ includes.
7263         * ax-gdb.c: Fix common/ includes.
7264         * auxv.c: Fix common/ includes.
7265         * auto-load.c: Fix common/ includes.
7266         * arm-tdep.c: Fix common/ includes.
7267         * arch/riscv.c: Fix common/ includes.
7268         * arch/ppc-linux-common.c: Fix common/ includes.
7269         * arch/i386.c: Fix common/ includes.
7270         * arch/arm.c: Fix common/ includes.
7271         * arch/arm-linux.c: Fix common/ includes.
7272         * arch/arm-get-next-pcs.c: Fix common/ includes.
7273         * arch/amd64.c: Fix common/ includes.
7274         * arch/aarch64.c: Fix common/ includes.
7275         * arch/aarch64-insn.c: Fix common/ includes.
7276         * arch-utils.c: Fix common/ includes.
7277         * amd64-windows-tdep.c: Fix common/ includes.
7278         * amd64-tdep.c: Fix common/ includes.
7279         * amd64-sol2-tdep.c: Fix common/ includes.
7280         * amd64-obsd-tdep.c: Fix common/ includes.
7281         * amd64-nbsd-tdep.c: Fix common/ includes.
7282         * amd64-linux-tdep.c: Fix common/ includes.
7283         * amd64-linux-nat.c: Fix common/ includes.
7284         * amd64-fbsd-tdep.c: Fix common/ includes.
7285         * amd64-fbsd-nat.c: Fix common/ includes.
7286         * amd64-dicos-tdep.c: Fix common/ includes.
7287         * amd64-darwin-tdep.c: Fix common/ includes.
7288         * agent.c: Fix common/ includes.
7289         * ada-lang.h: Fix common/ includes.
7290         * ada-lang.c: Fix common/ includes.
7291         * aarch64-tdep.c: Fix common/ includes.
7292
7293 2019-01-25  Tom Tromey  <tom@tromey.com>
7294
7295         * common/create-version.sh: Use common/version.h.
7296
7297 2019-01-24  Pedro Alves  <palves@redhat.com>
7298
7299         * infrun.c (signal_stop, signal_print, signal_program)
7300         (signal_catch, signal_pass): Now arrays instead of pointers.
7301         (update_signals_program_target, do_target_resume)
7302         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7303         * linux-nat.c (linux_nat_target::pass_signals)
7304         (linux_nat_target::create_inferior, linux_nat_target::attach):
7305         Adjust.
7306         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7307         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7308         * procfs.c (procfs_target::pass_signals): Adjust.
7309         * record-full.c (record_full_target::resume): Adjust.
7310         * remote.c (remote_target::pass_signals)
7311         (remote_target::program_signals): Adjust.
7312         * target-debug.h (target_debug_print_signals): Now takes a
7313         gdb::array_view as parameter.  Adjust.
7314         * target.h (target_ops) <pass_signals, program_signals>: Replace
7315         pointer and length parameters with gdb::array_view.
7316         (target_pass_signals, target_program_signals): Likewise.
7317         * target-delegates.c: Regenerate.
7318
7319 2019-01-24  Pedro Alves  <palves@redhat.com>
7320
7321         * common/forward-scope-exit.h
7322         (forward_scope_exit::forward_scope_exit): Pass arguments to
7323         m_bind_function directly, instead of creating a std::bind and
7324         copying that.
7325
7326 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7327
7328         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7329         for static members.
7330         (pass_in_v_vfp_candidate): Likewise.
7331
7332 2019-01-23  Tom Tromey  <tom@tromey.com>
7333             Pedro Alves  <palves@redhat.com>
7334
7335         * regcache.c (class regcache_invalidator): Remove.
7336         (regcache::raw_write): Use make_scope_exit.
7337
7338 2019-01-23  Tom Tromey  <tom@tromey.com>
7339
7340         * ui-out.h (class ui_out_emit_type): Update comment.
7341
7342 2019-01-23  Tom Tromey  <tom@tromey.com>
7343
7344         * infrun.c (fetch_inferior_event): Update comment.
7345
7346 2019-01-23  Tom Tromey  <tom@tromey.com>
7347             Pedro Alves  <palves@redhat.com>
7348
7349         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7350         parameter.
7351         (fetch_inferior_event): Use SCOPE_EXIT.
7352
7353
7354 2019-01-23  Tom Tromey  <tom@tromey.com>
7355             Pedro Alves  <palves@redhat.com>
7356
7357         * infrun.c (disable_thread_events): Delete.
7358         (stop_all_threads): Use SCOPE_EXIT.
7359
7360 2019-01-23  Tom Tromey  <tom@tromey.com>
7361             Pedro Alves  <palves@redhat.com>
7362
7363         * symfile.c: Include forward-scope-exit.h.
7364         (clear_symtab_users_cleanup): Replace forward declaration with
7365         a FORWARD_SCOPE_EXIT.
7366         (syms_from_objfile_1): Use the forward_scope_exit and
7367         gdb::optional instead of cleanup_function.
7368         (reread_symbols): Use the forward_scope_exit instead of
7369         cleanup_function.
7370         (clear_symtab_users_cleanup): Remove function.
7371
7372 2019-01-23  Tom Tromey  <tom@tromey.com>
7373             Pedro Alves  <palves@redhat.com>
7374
7375         * linux-nat.c: Include scope-exit.h.
7376         (cleanup_target_stop): Remove.
7377         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7378         SCOPE_EXIT.
7379
7380 2019-01-23  Tom Tromey  <tom@tromey.com>
7381             Pedro Alves  <palves@redhat.com>
7382
7383         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7384         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7385
7386 2019-01-23  Tom Tromey  <tom@tromey.com>
7387             Andrew Burgess  <andrew.burgess@embecosm.com>
7388             Pedro Alves  <palves@redhat.com>
7389
7390         * infrun.c (fetch_inferior_event): Use scope_exit.
7391         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7392         * top.c (execute_command): Use scope_exit.
7393         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7394         * utils.c (do_bpstat_clear_actions_cleanup)
7395         (make_bpstat_clear_actions_cleanup): Remove.
7396
7397 2019-01-23  Tom Tromey  <tom@tromey.com>
7398             Pedro Alves  <palves@redhat.com>
7399
7400         * infrun.c: Include "common/scope-exit.h"
7401         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7402         (wait_for_inferior): Use SCOPE_EXIT.
7403         (fetch_inferior_event): Use scope_exit.
7404
7405 2019-01-23  Tom Tromey  <tom@tromey.com>
7406             Pedro Alves  <palves@redhat.com>
7407
7408         * breakpoint.c (create_breakpoint): Remove cleanup.
7409
7410 2019-01-23  Tom Tromey  <tom@tromey.com>
7411             Andrew Burgess  <andrew.burgess@embecosm.com>
7412             Pedro Alves  <palves@redhat.com>
7413
7414 2019-01-23  Pedro Alves  <palves@redhat.com>
7415
7416         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7417
7418 2019-01-23  Pedro Alves  <palves@redhat.com>
7419             Andrew Burgess  <andrew.burgess@embecosm.com>
7420
7421         * gdbthread.h: Include "common/forward-scope-exit.h".
7422         (scoped_finish_thread_state): Redefine custom class in terms of
7423         forward_scope_exit.
7424
7425 2019-01-23  Pedro Alves  <palves@redhat.com>
7426             Andrew Burgess  <andrew.burgess@embecosm.com>
7427
7428         * common/forward-scope-exit.h: New file.
7429
7430 2019-01-23  Pedro Alves  <palves@redhat.com>
7431             Andrew Burgess  <andrew.burgess@embecosm.com>
7432             Tom Tromey  <tom@tromey.com>
7433
7434         * common/scope-exit.h: New file.
7435
7436 2019-01-23  Pedro Alves  <palves@redhat.com>
7437
7438         * common/preprocessor.h (ESC): Rename to ...
7439         (ESC_PARENS): ... this.
7440         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7441         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7442
7443 2019-01-23  Tom Tromey  <tom@tromey.com>
7444
7445         * language.h (class scoped_switch_to_sym_language_if_auto):
7446         Initialize m_lang in both cases.
7447
7448 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7449
7450         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7451         with XCNEW.
7452
7453 2019-01-22  Tom Tromey  <tom@tromey.com>
7454
7455         * corelow.c: Do not include sys/file.h.
7456
7457 2019-01-22  Tom Tromey  <tom@tromey.com>
7458
7459         * tui/tui-wingeneral.h: Include gdb_curses.h.
7460
7461 2019-01-22  Tom Tromey  <tom@tromey.com>
7462
7463         * source-cache.h (class source_cache) <get_source_lines,
7464         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7465
7466 2019-01-22  Tom Tromey  <tom@tromey.com>
7467
7468         * remote-fileio.h (struct remote_target): Declare.
7469
7470 2019-01-22  Tom Tromey  <tom@tromey.com>
7471
7472         * python/py-arch.c: Do not include py-ref.h.
7473         * python/py-bpevent.c: Do not include py-ref.h.
7474         * python/py-cmd.c: Do not include py-ref.h.
7475         * python/py-continueevent.c: Do not include py-ref.h.
7476         * python/py-event.h: Do not include py-ref.h.
7477         * python/py-evtregistry.c: Do not include py-ref.h.
7478         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7479         * python/py-frame.c: Do not include py-ref.h.
7480         * python/py-framefilter.c: Do not include py-ref.h.
7481         * python/py-function.c: Do not include py-ref.h.
7482         * python/py-infevents.c: Do not include py-ref.h.
7483         * python/py-linetable.c: Do not include py-ref.h.
7484         * python/py-objfile.c: Do not include py-ref.h.
7485         * python/py-param.c: Do not include py-ref.h.
7486         * python/py-prettyprint.c: Do not include py-ref.h.
7487         * python/py-progspace.c: Do not include py-ref.h.
7488         * python/py-symbol.c: Do not include py-ref.h.
7489         * python/py-symtab.c: Do not include py-ref.h.
7490         * python/py-type.c: Do not include py-ref.h.
7491         * python/py-unwind.c: Do not include py-ref.h.
7492         * python/py-utils.c: Do not include py-ref.h.
7493         * python/py-value.c: Do not include py-ref.h.
7494         * python/py-varobj.c: Do not include py-ref.h.
7495         * python/py-xmethods.c: Do not include py-ref.h.
7496         * python/python.c: Do not include py-ref.h.
7497         * varobj.c: Do not include py-ref.h.
7498
7499 2019-01-22  Tom Tromey  <tom@tromey.com>
7500
7501         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7502         keyword for bcache.
7503
7504 2019-01-22  Tom Tromey  <tom@tromey.com>
7505
7506         * compile/compile-cplus-types.c: Remove a comment by #include.
7507
7508 2019-01-22  Tom Tromey  <tom@tromey.com>
7509
7510         * compile/gcc-c-plugin.h: Include compile-internal.h.
7511
7512 2019-01-22  Tom Tromey  <tom@tromey.com>
7513
7514         * stabsread.c (EXTERN): Do not define.
7515         (symnum, next_symbol_text_func, processing_gcc_compilation)
7516         (within_function, global_sym_chain, global_stabs)
7517         (previous_stab_code, this_object_header_files)
7518         (n_this_object_header_files)
7519         (n_allocated_this_object_header_files): Define.
7520         * stabsread.h (EXTERN): Never define.  Use "extern".
7521
7522 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7523
7524         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7525         history_value.
7526
7527 2019-01-21  Tom Tromey  <tom@tromey.com>
7528
7529         * ui-out.c: Fix includes.
7530         * tui/tui-source.c: Fix includes.
7531         * target.c: Fix includes.
7532         * remote.c: Fix includes.
7533         * regcache.c: Fix includes.
7534         * python/py-block.c: Fix includes.
7535         * printcmd.c: Fix includes.
7536         * or1k-tdep.c: Fix includes.
7537         * mi/mi-main.c: Fix includes.
7538         * m32r-tdep.c: Fix includes.
7539         * csky-tdep.c: Fix includes.
7540         * compile/compile-cplus-types.c: Fix includes.
7541         * cli/cli-interp.c: Fix includes.
7542
7543 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7544
7545         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7546         for padding.
7547
7548 2019-01-16  Tom Tromey  <tom@tromey.com>
7549
7550         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7551         earlier.
7552         (struct objfile) <msymbols_range>: Move from top level.
7553         <msymbols>: New method.
7554         (class objfile_msymbols): Remove.
7555         * symtab.c (default_collect_symbol_completion_matches_break_on):
7556         Update.
7557         * symmisc.c (dump_msymbols): Update.
7558         * stabsread.c (scan_file_globals): Update.
7559         * objc-lang.c (info_selectors_command, info_classes_command)
7560         (find_methods): Update.
7561         * minsyms.c (find_solib_trampoline_target): Update.
7562         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7563         * coffread.c (coff_symfile_read): Update.
7564         * ada-lang.c (ada_lookup_simple_minsym)
7565         (ada_collect_symbol_completion_matches): Update.
7566
7567 2019-01-16  Tom Tromey  <tom@tromey.com>
7568
7569         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7570         type.  Remove no-argument constructor.
7571         <iterator::operator++>: Simplify.
7572         <begin>: Update.
7573         <end>: Use minimal_symbol_count.
7574
7575 2019-01-16  Tom Tromey  <tom@tromey.com>
7576
7577         * objfiles.h (struct objfile) <psymtabs>: New method.
7578         (class objfile_psymtabs): Remove.
7579         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7580         typedef.
7581         <range>: New method.
7582         (require_partial_symbols): Change return type.
7583         * psymtab.c (require_partial_symbols)
7584         (psym_expand_symtabs_matching): Update.
7585         * mdebugread.c (parse_partial_symbols): Update.
7586         * dbxread.c (dbx_end_psymtab): Update.
7587
7588 2019-01-15  Tom Tromey  <tom@tromey.com>
7589
7590         * symtab.c (lookup_objfile_from_block)
7591         (lookup_symbol_in_objfile_symtabs)
7592         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7593         (find_line_symtab, info_sources_command)
7594         (default_collect_symbol_completion_matches_break_on)
7595         (make_source_files_completion_list): Update.
7596         * symmisc.c (print_objfile_statistics, dump_objfile)
7597         (maintenance_print_symbols, maintenance_info_symtabs)
7598         (maintenance_check_symtabs, maintenance_info_line_tables):
7599         Update.
7600         * source.c (select_source_symtab)
7601         (forget_cached_source_info_for_objfile): Update.
7602         * objfiles.h (class objfile_compunits): Remove.
7603         (struct objfile) <compunits_range>: New typedef.
7604         (compunits): New method.
7605         * objfiles.c (objfile_relocate1): Update.
7606         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7607         * maint.c (count_symtabs_and_blocks): Update.
7608         * linespec.c (iterate_over_all_matching_symtabs): Update.
7609         * cp-support.c (add_symbol_overload_list_qualified): Update.
7610         * coffread.c (coff_symtab_read): Update.
7611         * ada-lang.c (add_nonlocal_symbols)
7612         (ada_collect_symbol_completion_matches)
7613         (ada_add_global_exceptions): Update.
7614
7615 2019-01-15  Tom Tromey  <tom@tromey.com>
7616
7617         * progspace.h (program_space) <objfiles_safe_range>: New
7618         typedef.
7619         <objfiles_safe>: New method.
7620         * objfiles.h (class all_objfiles_safe): Remove.
7621         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7622         * jit.c (jit_inferior_exit_hook): Update.
7623
7624 2019-01-17  Tom Tromey  <tom@tromey.com>
7625
7626         * progspace.h (program_space) <objfiles_range>: New typedef.
7627         <objfiles>: New method.
7628         <objfiles_head>: Rename from objfiles.
7629         (object_files): Update.
7630         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7631         * guile/scm-pretty-print.c
7632         (ppscm_find_pretty_printer_from_objfiles): Update.
7633         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7634         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7635         Update.
7636         * python/py-progspace.c (pspy_get_objfiles): Update.
7637         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7638         Update.
7639         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7640         (objfpy_lookup_objfile_by_build_id): Update.
7641         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7642         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7643         Update.
7644         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7645         (expand_symtab_containing_pc, lookup_objfile_from_block)
7646         (lookup_static_symbol, basic_lookup_transparent_type)
7647         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7648         (find_line_symtab, info_sources_command)
7649         (default_collect_symbol_completion_matches_break_on)
7650         (make_source_files_completion_list, find_main_name): Update.
7651         * symmisc.c (print_symbol_bcache_statistics)
7652         (print_objfile_statistics, maintenance_print_symbols)
7653         (maintenance_print_msymbols, maintenance_print_objfiles)
7654         (maintenance_info_symtabs, maintenance_check_symtabs)
7655         (maintenance_expand_symtabs, maintenance_info_line_tables):
7656         Update.
7657         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7658         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7659         (map_overlay_command, unmap_overlay_command)
7660         (simple_overlay_update, expand_symtabs_matching)
7661         (map_symbol_filenames): Update.
7662         * symfile-debug.c (set_debug_symfile): Update.
7663         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7664         Update.
7665         * source.c (select_source_symtab, forget_cached_source_info):
7666         Update.
7667         * solib.c (solib_read_symbols): Update.
7668         * solib-spu.c (append_ocl_sos): Update.
7669         * psymtab.c (maintenance_print_psymbols)
7670         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7671         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7672         * printcmd.c (info_symbol_command): Update.
7673         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7674         Update.
7675         * objfiles.h (class all_objfiles): Remove.
7676         * objfiles.c (have_partial_symbols, have_full_symbols)
7677         (have_minimal_symbols, qsort_cmp, update_section_map)
7678         (shared_objfile_contains_address_p)
7679         (default_iterate_over_objfiles_in_search_order): Update.
7680         * objc-lang.c (info_selectors_command, info_classes_command)
7681         (find_methods): Update.
7682         * minsyms.c (find_solib_trampoline_target): Update.
7683         * maint.c (maintenance_info_sections)
7684         (maintenance_translate_address, count_symtabs_and_blocks):
7685         Update.
7686         * main.c (captured_main_1): Update.
7687         * linux-thread-db.c (try_thread_db_load_from_pdir)
7688         (has_libpthread): Update.
7689         * linespec.c (iterate_over_all_matching_symtabs)
7690         (search_minsyms_for_name): Update.
7691         * jit.c (jit_find_objf_with_entry_addr): Update.
7692         * hppa-tdep.c (find_unwind_entry)
7693         (hppa_lookup_stub_minimal_symbol): Update.
7694         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7695         Update.
7696         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7697         (elf_gnu_ifunc_resolve_by_got): Update.
7698         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7699         * dwarf-index-write.c (save_gdb_index_command): Update.
7700         * cp-support.c (add_symbol_overload_list_qualified): Update.
7701         * breakpoint.c (create_overlay_event_breakpoint)
7702         (create_longjmp_master_breakpoint)
7703         (create_std_terminate_master_breakpoint)
7704         (create_exception_master_breakpoint): Update.
7705         * blockframe.c (find_pc_partial_function): Update.
7706         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7707         (ada_collect_symbol_completion_matches)
7708         (ada_add_global_exceptions): Update.
7709
7710 2019-01-17  Tom Tromey  <tom@tromey.com>
7711
7712         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7713         declare VEC.
7714         (solib_target_parse_libraries): Change return type.
7715         (library_list_start_segment, library_list_start_section)
7716         (library_list_end_library, library_list_start_library); Update.
7717         (solib_target_free_library_list): Remove.
7718         (solib_target_parse_libraries): Remove cleanup.  Change return
7719         type.
7720         (solib_target_current_sos): Update.
7721
7722 2019-01-17  Tom Tromey  <tromey@bapiya>
7723
7724         * valprint.c: Replace "the the" with "the".
7725         * symtab.c: Replace "the the" with "the".
7726         * solib.c: Replace "the the" with "the".
7727         * solib-dsbt.c: Replace "the the" with "the".
7728         * linespec.c: Replace "the the" with "the".
7729         * dwarf2loc.h: Replace "the the" with "the".
7730         * amd64-windows-tdep.c: Replace "the the" with "the".
7731         * aarch64-tdep.c: Replace "the the" with "the".
7732
7733 2019-01-16  Keith Seitz  <keiths@redhat.com>
7734
7735         PR gdb/23773
7736         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7737         <builder>: Rename to ..
7738         <m_builder>: ... this and make private.
7739         (dwarf2_cu::get_builder): New method.  Change all users of
7740         `builder' to use this method.
7741         (dwarf2_start_symtab): Move to ...
7742         (dwarf2_cu::start_symtab): ... here.  Update all callers
7743         (setup_type_unit_groups): Move to ...
7744         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7745         callers.
7746         (dwarf2_cu::reset_builder): New method.
7747         (process_full_compunit, process_full_type_unit): Use
7748         dwarf2_cu::reset_builder.
7749         (follow_die_offset): Record the ancestor CU if it is different
7750         from the followed DIE's CU.
7751         (follow_die_sig_1): Likewise.
7752
7753 2019-01-15  Tom Tromey  <tom@tromey.com>
7754
7755         * remote.c (class remote_state) <buf>: Now a char_vector.
7756         <buf_size>: Remove.
7757         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7758         parameter.
7759         (remote_target::getpkt_or_notif_sane_1)
7760         (remote_target::getpkt_sane)
7761         (remote_target::getpkt_or_notif_sane): Likewise.
7762         (class remote_target) <putpkt>: New overload.
7763         (remote_target::read_frame): Change type of "buf_p".  Remove
7764         sizeof_p parameter.
7765         (packet_ok): New overload.
7766         (packet_check_result): New overload.
7767         Update all uses.
7768
7769 2019-01-14  Tom Tromey  <tom@tromey.com>
7770
7771         * remote-notif.c (handle_notification, remote_notif_ack)
7772         (remote_notif_parse): Make "buf" const.
7773         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7774         const.
7775         (remote_notif_parse, remote_notif_ack, handle_notification):
7776         Likewise.
7777         * remote.c (remote_notif_stop_parse): Make "buf" const.
7778         (remote_target::remote_parse_stop_reply): Make "buf" const.
7779         (remote_notif_stop_ack): Make "buf" const.
7780
7781 2019-01-14  Tom Tromey  <tom@tromey.com>
7782
7783         * remote.c (remote_console_output): Make parameter const.
7784
7785 2019-01-14  Tom Tromey  <tom@tromey.com>
7786
7787         * target-debug.h (target_debug_print_signals): Constify.
7788         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7789         * procfs.c (procfs_target::pass_signals): Update.
7790         * linux-nat.c (linux_nat_target::pass_signals): Update.
7791         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7792         * target-delegates.c: Rebuild.
7793         * remote.c (remote_target::program_signals): Update.
7794         (remote_target::pass_signals): Update.
7795         * target.c (target_pass_signals): Constify argument.
7796         (target_program_signals): Likewise.
7797         * target.h (struct target_ops) <pass_signals, program_signals>:
7798         Constify argument.
7799         (target_pass_signals, target_program_signals): Constify argument.
7800
7801 2019-01-14  Tom Tromey  <tom@tromey.com>
7802
7803         PR tui/28819:
7804         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7805
7806 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7807
7808         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7809         field.
7810         * rs6000-tdep.c: Include reggroups.h.
7811         (IS_V_ALIAS_PSEUDOREG): Define.
7812         (rs6000_register_name): Return names for the "vX" aliases.
7813         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7814         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7815         aliases.  Call default_register_reggroup_p for all other
7816         pseudo-registers.
7817         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7818         New functions.
7819         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7820         Handle "vX" aliases.
7821         (v_alias_pseudo_register_collect): New function.
7822         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7823         (rs6000_gdbarch_init): Initialize "vX" aliases as
7824         pseudo-registers.  Restore registration of
7825         rs6000_pseudo_register_reggroup_p with
7826         set_tdesc_pseudo_register_reggroup_p.
7827
7828 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7829
7830         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7831         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7832         set_gdbarch_num_pseudo_regs.
7833
7834 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7835
7836         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7837         Remove arg prefixname, add do_set and do_show.
7838         Add member functions set_list and show_list.
7839         * cli/cli-style.c (class cli_style_option): Update accordingly.
7840         (style_set_list): Move to file scope.
7841         (style_show_list): Likewise.
7842         (set_style): Call help_list.
7843         (show_style): Call cmd_show_list.
7844         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7845         Update to use the new macro.
7846
7847 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7848
7849         * ada-lang.c (_initialize_ada_language): Expand the help text
7850         for the "catch exception" command.
7851
7852 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7853
7854         * symtab.c (matching_obj_sections): Initialize obj,
7855         declare it closer to its usage.
7856
7857 2019-01-10  Tom Tromey  <tom@tromey.com>
7858
7859         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7860         (basic_inf_threads_range): Remove.
7861         (inf_threads_range, inf_non_exited_threads_range)
7862         (safe_inf_threads_range): Use next_adapter.
7863
7864 2019-01-10  Keith Seitz  <keiths@redhat.com>
7865
7866         PR gdb/23712
7867         PR symtab/23010
7868         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7869         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7870
7871 2019-01-10  Keith Seitz  <keiths@redhat.com>
7872
7873         PR gdb/23712
7874         PR symtab/23010
7875         * dictionary.c (pending_to_vector): Remove.
7876         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7877         Remove _1 suffix, replacing functions of the same name.  Update
7878         all callers.
7879         (dict_create_hashed, dict_create_hashed_expandable)
7880         (dict_create_linear, dict_create_linear_expandable, dict_free)
7881         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7882         Make functions static.
7883
7884 2019-01-10  Keith Seitz  <keiths@redhat.com>
7885
7886         PR gdb/23712
7887         PR symtab/23010
7888         * dictionary.h (struct dictionary): Replace declaration with
7889         multidictionary.
7890         (dict_create_hashed, dict_create_hashed_expandable)
7891         (dict_create_linear, dict_create_linear_expandable)
7892         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7893         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7894         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7895         taking multidictionary argument.
7896         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7897         * block.h (struct block) <dict>: Change to multidictionary
7898         and rename `multidict'.
7899         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7900         symmisc.c: Update all dictionary references to multidictionary.
7901
7902 2019-01-10  Keith Seitz  <keiths@redhat.com>
7903
7904         PR gdb/23712
7905         PR symtab/23010
7906         * dictionary.c: Include unordered_map.
7907         (pending_to_vector): New function.
7908         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7909         Rewrite the non-"_1" functions to take vector instead
7910         of linked list.
7911         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7912         "new" _1 versions of the same name.
7913         (multidictionary): Define.
7914         (std::hash<enum language): New definition.
7915         (collate_pending_symbols_by_language, mdict_create_hashed)
7916         (mdict_create_hashed_expandable, mdict_create_linear)
7917         (mdict_create_linear_expandable, mdict_free)
7918         (find_language_dictionary, create_new_language_dictionary)
7919         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7920         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7921         (mdict_size, mdict_empty): New functions.
7922         * dictionary.h (mdict_iterator): Define.
7923
7924 2019-01-10  Pedro Alves  <palves@redhat.com>
7925
7926         * breakpoint.c (read_uploaded_action)
7927         (create_tracepoint_from_upload): Adjust to use
7928         gdb::unique_xmalloc_ptr.
7929         * ctf.c (ctf_write_uploaded_tp):
7930         (SET_ARRAY_FIELD): Use emplace_back.
7931         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7932         * tracefile-tfile.c (tfile_write_uploaded_tp):
7933         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7934         gdb::unique_xmalloc_ptr.
7935         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7936         at_string, cond_string, cmd_strings>: Replace char pointers
7937         with gdb::unique_xmalloc_ptr.
7938
7939 2019-01-10  Pedro Alves  <palves@redhat.com>
7940
7941         * solib-target.c (library_list_start_library): Don't xstrdup name.
7942
7943 2019-01-10  Pedro Alves  <palves@redhat.com>
7944
7945         * mdebugread.c (parse_partial_symbols): Use
7946         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7947
7948 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7949
7950         * linux-fork.c (scoped_switch_fork_info)
7951         <~scoped_switch_fork_info>: Fix incorrect variable name.
7952
7953 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7954
7955         * linux-fork.c (scoped_switch_fork_info)
7956         <scoped_switch_fork_info>: Make explicit.
7957         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7958
7959 2019-01-10  Tom Tromey  <tom@tromey.com>
7960
7961         * objfiles.h (objfile::reset_psymtabs): Update.
7962         * objfiles.c (objfile::objfile): Update.
7963         * psymtab.h (psymtab_storage::obstack): Update.
7964         (psymtab_storage::m_obstack): Use gdb::optional.
7965         (class psymtab_storage): Update comment.  Remove objfile
7966         parameter.
7967         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7968
7969 2019-01-10  Tom Tromey  <tom@tromey.com>
7970
7971         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7972         <free_psymtabs>: Now private.
7973         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7974         (allocate_psymtab): Use new method.
7975
7976 2019-01-10  Tom Tromey  <tom@tromey.com>
7977
7978         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7979         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7980         * mdebugread.c (parse_partial_symbols): Use
7981         allocate_dependencies.
7982         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7983         allocate_dependencies.
7984         (process_psymtab_comp_unit_reader)
7985         (build_type_psymtab_dependencies): Likewise.
7986         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7987
7988 2019-01-10  Tom Tromey  <tom@tromey.com>
7989
7990         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7991         PSYMBOL_SET_LANGUAGE.
7992         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7993
7994 2019-01-10  Tom Tromey  <tom@tromey.com>
7995
7996         * psymtab.h (psymtab_storage::obstack): New method.
7997         <m_obstack>: Rename from obstack; now private.
7998         * psymtab.c (psymtab_storage): Update.
7999         * dwarf2read.c (create_addrmap_from_index)
8000         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8001         Update.
8002
8003 2019-01-10  Tom Tromey  <tom@tromey.com>
8004
8005         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8006         * objfiles.h (objfile::reset_psymtabs): New method.
8007
8008 2019-01-10  Tom Tromey  <tom@tromey.com>
8009
8010         * symmisc.c (print_symbol_bcache_statistics): Update.
8011         (print_objfile_statistics): Update.
8012         * symfile.c (reread_symbols): Update.
8013         * psymtab.h (class psymtab_storage): New.
8014         * psymtab.c (psymtab_storage): New constructor.
8015         (~psymtab_storage): New destructor.
8016         (require_partial_symbols): Update.
8017         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8018         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8019         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8020         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8021         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8022         (start_psymtab_common, end_psymtab_common)
8023         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8024         (allocate_psymtab): Update.
8025         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8026         Update.
8027         (dump_psymtab_addrmap, maintenance_print_psymbols)
8028         (maintenance_check_psymtabs): Update.
8029         (class objfile_psymtabs): Move to objfiles.h.
8030         * psympriv.h (discard_psymtab): Now inline.
8031         (psymtab_discarder::psymtab_discarder): Update.
8032         (psymtab_discarder::~psymtab_discarder): Update.
8033         (ALL_OBJFILE_PSYMTABS): Rewrite.
8034         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8035         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8036         Remove fields.
8037         <partial_symtabs>: New field.
8038         (class objfile_psymtabs): Move from psymtab.h.  Update.
8039         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8040         psymbol_cache.
8041         (objfile::~objfile): Don't destroy psymbol_cache.
8042         * mdebugread.c (parse_partial_symbols): Update.
8043         * dwarf2read.c (create_addrmap_from_index)
8044         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8045         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8046         (add_partial_subprogram, dwarf2_ranges_read): Update.
8047         * dwarf-index-write.c (write_address_map)
8048         (write_one_signatured_type, recursively_write_psymbols)
8049         (class debug_names, class debug_names, write_psymtabs_to_index):
8050         Update.
8051
8052 2019-01-10  Tom Tromey  <tom@tromey.com>
8053
8054         * symtab.h (SYMBOL_SET_NAMES): Update.
8055         (symbol_set_names): Update.
8056         (MSYMBOL_SET_NAMES): Update.
8057         * symtab.c (symbol_set_names): Change argument to be an
8058         objfile_per_bfd_storage.
8059         * psymtab.c (add_psymbol_to_bcache): Update.
8060         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8061
8062 2019-01-10  Tom Tromey  <tom@tromey.com>
8063
8064         * symtab.c (create_demangled_names_hash): Change argument to be an
8065         objfile_per_bfd_storage.
8066         (symbol_set_names): Update.
8067
8068 2019-01-10  Tom Tromey  <tom@tromey.com>
8069
8070         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8071         init_psymbol_list.
8072         * psymtab.c (init_psymbol_list): Do nothing if already called.
8073         * psympriv.h (init_psymbol_list): Add comment.
8074         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8075         init_psymbol_list.
8076         * dbxread.c (dbx_symfile_read): Unconditionally call
8077         init_psymbol_list.
8078
8079 2019-01-10  Tom Tromey  <tom@tromey.com>
8080
8081         * xcoffread.c (scan_xcoff_symtab): Update.
8082         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8083         "where".
8084         * mdebugread.c (parse_partial_symbols)
8085         (handle_psymbol_enumerators): Update.
8086         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8087         * dbxread.c (read_dbx_symtab): Update.
8088         * psympriv.h (psymbol_placement): New enum.
8089         (add_psymbol_to_list): Update.
8090
8091 2019-01-10  Tom Tromey  <tom@tromey.com>
8092
8093         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8094         static_psymbols parameters.
8095         (scan_xcoff_symtab): Update.
8096         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8097         static_psymbols parameters.
8098         * psympriv.h (start_psymtab_common): Update.
8099         * mdebugread.c (parse_partial_symbols): Update.
8100         * dwarf2read.c (create_partial_symtab): Update.
8101         * dbxread.c (read_dbx_symtab): Update.
8102         (start_psymtab): Remove global_psymbols and static_psymbols
8103         parameters.
8104
8105 2019-01-10  Tom Tromey  <tom@tromey.com>
8106
8107         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8108         * psymtab.c (allocate_psymtab): Add comment.
8109         * psympriv.h (allocate_psymtab): Add comment.
8110         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8111         initializations.
8112         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8113
8114 2019-01-10  Tom Tromey  <tom@tromey.com>
8115
8116         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8117         Don't declare.
8118         * mipsread.c: Include mdebugread.h.
8119         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8120         Declare.
8121         * elfread.c: Include mdebugread.h.
8122
8123 2019-01-09  Tom Tromey  <tom@tromey.com>
8124
8125         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8126         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8127         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8128         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8129         (psym_lookup_symbol, psym_find_last_source_symtab)
8130         (psym_forget_cached_source_info, psym_print_stats)
8131         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8132         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8133         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8134         (psym_find_compunit_symtab_by_address)
8135         (maintenance_print_psymbols, maintenance_info_psymtabs)
8136         (maintenance_check_psymtabs): Use ranged for.
8137         * psymtab.h (class objfile_psymtabs): New.
8138         (require_partial_symbols): Return objfile_psymtabs.
8139         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8140
8141 2019-01-09  Tom Tromey  <tom@tromey.com>
8142
8143         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8144         (find_pc_mapped_section, list_overlays_command)
8145         (map_overlay_command, unmap_overlay_command)
8146         (simple_overlay_update): Use all_objfiles.
8147         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8148         * printcmd.c (info_symbol_command): Use all_objfiles.
8149         * objfiles.h (ALL_OBJSECTIONS): Remove.
8150         * maint.c (maintenance_translate_address): Use all_objfiles.
8151         * gcore.c (gcore_create_callback): Use all_objfiles.
8152         (objfile_find_memory_regions): Likewise.
8153
8154 2019-01-09  Tom Tromey  <tom@tromey.com>
8155
8156         * symtab.c (find_line_symtab, info_sources_command)
8157         (make_source_files_completion_list): Use objfile_compunits.
8158         * source.c (select_source_symtab): Use objfile_compunits.
8159         * objfiles.h (struct objfile): Update comment.
8160         (ALL_OBJFILES): Remove.
8161         (ALL_FILETABS): Remove.
8162         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8163         objfile_compunits.
8164
8165 2019-01-09  Tom Tromey  <tom@tromey.com>
8166
8167         * symmisc.c (print_objfile_statistics, dump_objfile)
8168         (maintenance_print_symbols): Use compunit_filetabs.
8169         * source.c (forget_cached_source_info_for_objfile): Use
8170         compunit_filetabs.
8171         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8172         (ALL_FILETABS): Use compunit_filetabs.
8173         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8174         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8175
8176 2019-01-09  Tom Tromey  <tom@tromey.com>
8177
8178         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8179         (compunit_filetabs): New.
8180         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8181         compunit_filetabs.
8182         (info_sources_command, make_source_files_completion_list): Remove
8183         declaration.
8184         * symmisc.c (print_objfile_statistics, dump_objfile)
8185         (maintenance_print_symbols): Remove declaration.
8186         (maintenance_info_symtabs): Use compunit_filetabs.
8187         (maintenance_info_line_tables): Likewise.
8188         * source.c (select_source_symtab): Change local variable name.
8189         (forget_cached_source_info_for_objfile): Remove declaration.
8190         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8191         * objfiles.c (objfile_relocate1): Remove declaration.
8192         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8193         declaration.
8194         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8195         * coffread.c (coff_symtab_read): Remove declaration.
8196         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8197         compunit_filetabs.
8198
8199 2019-01-09  Tom Tromey  <tom@tromey.com>
8200
8201         * symtab.c (lookup_objfile_from_block)
8202         (find_pc_sect_compunit_symtab, search_symbols)
8203         (default_collect_symbol_completion_matches_break_on): Use
8204         objfile_compunits.
8205         * objfiles.h (ALL_COMPUNITS): Remove.
8206         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8207         * cp-support.c (add_symbol_overload_list_qualified): Use
8208         objfile_compunits.
8209         * ada-lang.c (ada_collect_symbol_completion_matches)
8210         (ada_add_global_exceptions): Use objfile_compunits.
8211
8212 2019-01-09  Tom Tromey  <tom@tromey.com>
8213
8214         * source.c (select_source_symtab)
8215         (forget_cached_source_info_for_objfile): Remove declaration.
8216         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8217         declaration.
8218         * maint.c (count_symtabs_and_blocks): Remove declaration.
8219         * cp-support.c (add_symbol_overload_list_qualified): Remove
8220         declaration.
8221         * coffread.c (coff_symtab_read): Remove declaration.
8222         * symtab.c (lookup_symbol_in_objfile_symtabs)
8223         (basic_lookup_transparent_type_1): Use objfile_compunits.
8224         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8225         (info_sources_command, search_symbols)
8226         (default_collect_symbol_completion_matches_break_on)
8227         (make_source_files_completion_list): Remove declaration.
8228         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8229         (ada_collect_symbol_completion_matches)
8230         (ada_add_global_exceptions): Remove declaration.
8231         * linespec.c (iterate_over_all_matching_symtabs): Use
8232         objfile_compunits.
8233         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8234         (class objfile_compunits): New.
8235         (ALL_COMPUNITS): Use objfile_compunits.
8236         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8237         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8238         objfile_compunits.
8239         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8240
8241 2019-01-09  Tom Tromey  <tom@tromey.com>
8242
8243         * symtab.c (search_symbols)
8244         (default_collect_symbol_completion_matches_break_on): Use
8245         objfile_msymbols.
8246         * ada-lang.c (ada_lookup_simple_minsym)
8247         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8248         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8249         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8250         objfile_msymbols.
8251         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8252         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8253         * objc-lang.c (find_methods): Use objfile_msymbols.
8254         (info_selectors_command, info_classes_command): Likewise.
8255         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8256         * objfiles.h (class objfile_msymbols): New.
8257         (ALL_OBJFILE_MSYMBOLS): Remove.
8258         (ALL_MSYMBOLS): Remove.
8259
8260 2019-01-09  Tom Tromey  <tom@tromey.com>
8261
8262         * common/next-iterator.h (next_adapter): Add Iterator template
8263         parameter.
8264         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8265         (class all_objfiles_safe): New.
8266         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8267         * objfiles.c (put_objfile_before): Update comment.
8268         (add_separate_debug_objfile): Likewise.
8269         (free_all_objfiles): Use all_objfiles_safe.
8270         (objfile_purge_solibs): Likewise.
8271
8272 2019-01-09  Tom Tromey  <tom@tromey.com>
8273
8274         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8275         (expand_symtab_containing_pc, lookup_static_symbol)
8276         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8277         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8278         all_objfiles.
8279         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8280         * breakpoint.c (create_overlay_event_breakpoint)
8281         (create_longjmp_master_breakpoint)
8282         (create_std_terminate_master_breakpoint)
8283         (create_exception_master_breakpoint): Use all_objfiles.
8284         * linux-thread-db.c (try_thread_db_load_from_pdir)
8285         (has_libpthread): Use all_objfiles.
8286         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8287         * linespec.c (iterate_over_all_matching_symtabs)
8288         (search_minsyms_for_name): Use all_objfiles.
8289         * maint.c (maintenance_info_sections): Use all_objfiles.
8290         * main.c (captured_main_1): Use all_objfiles.
8291         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8292         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8293         * guile/scm-pretty-print.c
8294         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8295         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8296         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8297         (maintenance_print_msymbols): Use all_objfiles.
8298         * source.c (select_source_symtab): Use all_objfiles.
8299         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8300         * symfile.c (remove_symbol_file_command)
8301         (expand_symtabs_matching, map_symbol_filenames): Use
8302         all_objfiles.
8303         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8304         all_objfiles.
8305         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8306         * objc-lang.c (find_methods): Use all_objfiles.
8307         * objfiles.c (have_partial_symbols, have_full_symbols)
8308         (have_minimal_symbols, qsort_cmp)
8309         (default_iterate_over_objfiles_in_search_order): Use
8310         all_objfiles.
8311         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8312         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8313         (maintenance_check_psymtabs): Use all_objfiles.
8314         (ALL_PSYMTABS): Remove.
8315         * compile/compile-object-run.c (do_module_cleanup): Use
8316         all_objfiles.
8317         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8318         * cp-support.c (add_symbol_overload_list_qualified): Use
8319         all_objfiles.
8320         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8321         Use all_objfiles.
8322         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8323         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8324         all_objfiles.
8325         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8326         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8327         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8328         Uses all_objfiles.
8329         * solib.c (solib_read_symbols): Use all_objfiles
8330
8331 2019-01-09  Tom Tromey  <tom@tromey.com>
8332
8333         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8334         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8335         all_objfiles.
8336         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8337         * symmisc.c (print_symbol_bcache_statistics)
8338         (print_objfile_statistics, maintenance_print_objfiles)
8339         (maintenance_info_symtabs, maintenance_check_symtabs)
8340         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8341         all_objfiles.
8342         * source.c (forget_cached_source_info): Use all_objfiles.
8343         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8344         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8345         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8346         * objfiles.c (update_section_map): Use all_objfiles.
8347         (shared_objfile_contains_address_p): Likewise.
8348         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8349         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8350
8351 2019-01-09  Tom Tromey  <tom@tromey.com>
8352
8353         * common/next-iterator.h: New file.
8354         * objfiles.h (class all_objfiles): New.
8355         (struct objfile_iterator): New.
8356
8357 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8358
8359         * NEWS: Move the description of the changed "frame", "select-frame",
8360          and "info frame" commands to the Changed commands section.
8361
8362 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8363
8364         * gdbtypes.c (check_stub_method_group): Remove handling of old
8365         mangling schemes.
8366         * linespec.c (find_methods): Likewise.
8367         * stabsread.c (read_member_functions): Likewise.
8368         * valops.c (search_struct_method): Likewise.
8369         (value_struct_elt_for_reference): Likewise.
8370         * NEWS: Mention this change.
8371
8372 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8373
8374         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8375         print_source_lines.
8376         * source.c (print_source_lines_base): Update line number check.
8377         (print_source_lines): New function.
8378         (source_lines_range::source_lines_range): New function.
8379         * source.h (class source_lines_range): New class.
8380         (print_source_lines): New declaration.
8381
8382 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8383
8384         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8385
8386 2019-01-08  Tom Tromey  <tom@tromey.com>
8387             Simon Marchi  <simon.marchi@ericsson.com>
8388
8389         PR gdb/24060
8390         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8391         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8392         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8393         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8394         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8395         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8396
8397 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8398
8399         * source.c (select_source_symtab): Move header comment to
8400         declaration in source.h.
8401         (forget_cached_source_info_for_objfile): Likewise.
8402         (forget_cached_source_info): Likewise.
8403         (identify_source_line): Likewise.
8404         * source.h (identify_source_line): Move declaration from symtab.h
8405         and add comment from source.c
8406         (print_source_lines): Likewise.
8407         (forget_cached_source_info_for_objfile): Likewise.
8408         (forget_cached_source_info): Likewise.
8409         (select_source_symtab): Likewise.
8410         (enum print_source_lines_flag): Move definition from symtab.h.
8411         * symtab.h (identify_source_line): Move declaration to source.h.
8412         (print_source_lines): Likewise.
8413         (forget_cached_source_info_for_objfile): Likewise.
8414         (forget_cached_source_info): Likewise.
8415         (select_source_symtab): Likewise.
8416         (enum print_source_lines_flag): Move definition to source.h.
8417         * tui/tui-hooks.c: Add 'source.h' include.
8418
8419 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8420
8421         * source.c (print_source_lines_base): Handle requests to print
8422         reverse line number sequences, and guard against empty lines
8423         string.
8424
8425 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8426
8427         * source.c (print_source_lines_base): Fix skip of '\r' if next
8428         character is '\n'.
8429
8430 2019-01-06  Tom Tromey  <tom@tromey.com>
8431
8432         * c-exp.y (struct c_parse_state) <macro_original_text,
8433         expansion_obstack>: New member.
8434         (macro_original_text, expansion_obstack): Remove globals.
8435         (scan_macro_expansion, scanning_macro_expansion)
8436         (finished_macro_expansion): Update.
8437         (scan_macro_cleanup): Remove.
8438         (yylex, c_parse): Update.
8439
8440 2019-01-06  Tom Tromey  <tom@tromey.com>
8441
8442         * c-exp.y (struct c_parse_state) <strings>: New member.
8443         (operator_stoken): Update.
8444
8445 2019-01-06  Tom Tromey  <tom@tromey.com>
8446
8447         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8448         (union type_stack_elt) <typelist_val>: Now a pointer to
8449         std::vector.
8450         (type_stack_cleanup): Don't declare.
8451         (push_typelist): Update.
8452         * parse.c (pop_typelist): Return a std::vector.
8453         (push_typelist): Take a std::vector.
8454         (follow_types): Update.  Do not free args.
8455         (type_stack_cleanup): Remove.
8456         * c-exp.y (struct c_parse_state): New.
8457         (cpstate): New global.
8458         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8459         (nonempty_typelist): Update.
8460         (func_mod): Create a new vector.
8461         (c_parse): Create a c_parse_state.
8462         (check_parameter_typelist): Do not delete params.
8463         (function_method): Update.  Do not delete type_list.
8464
8465 2019-01-06  Tom Tromey  <tom@tromey.com>
8466
8467         PR gdb/28155:
8468         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8469         check_typedef.
8470         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8471         (print_return_value): Likewise.
8472
8473 2019-01-05  Tom Tromey  <tom@tromey.com>
8474
8475         * contrib/cleanup_check.py: Remove.
8476         * contrib/gcc-with-excheck: Remove.
8477         * contrib/exsummary.py: Remove.
8478         * contrib/excheck.py: Remove.
8479
8480 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8481
8482         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8483         NULL. Initialize tpprev to NULL instead of assigning it
8484         to NULL on the next statement.
8485         * windows-nat.c (windows_delete_thread): Remove check for
8486         main_thread_id before printing thread exit notifications.
8487         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8488         Remove thread ID check against main_thread_id.
8489         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8490         windows_delete_thread.
8491         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8492
8493 2019-01-04  Tom Tromey  <tom@tromey.com>
8494
8495         * compile/compile.c (_initialize_compile): Use upper case for
8496         metasyntactic variables.
8497         * symmisc.c (_initialize_symmisc): Use upper case for
8498         metasyntactic variables.
8499         * psymtab.c (_initialize_psymtab): Use upper case for
8500         metasyntactic variables.
8501         * demangle.c (demangle_command): Use upper case for metasyntactic
8502         variables.
8503         (_initialize_demangler): Likewise.
8504         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8505         variables.
8506
8507 2019-01-03  Tom Tromey  <tom@tromey.com>
8508
8509         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8510
8511 2019-01-03  Tom Tromey  <tom@tromey.com>
8512
8513         * python/py-symtab.c (salpy_str): Update.
8514         (struct salpy_sal_object) <symtab>: Now a PyObject.
8515         (salpy_dealloc): Update.
8516         (del_objfile_sal): Use gdbpy_ref.
8517
8518 2019-01-03  Tom Tromey  <tom@tromey.com>
8519
8520         * python/py-type.c (convert_field): Use new_reference.  Return
8521         gdbpy_ref.
8522         (make_fielditem): Return gdbpy_ref.
8523         (typy_fields): Update.
8524         (typy_getitem): Update.
8525         (field_name): Return gdbpy_ref.  Use new_reference.
8526         (typy_iterator_iternext): Update.
8527
8528 2019-01-03  Tom Tromey  <tom@tromey.com>
8529
8530         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8531
8532 2019-01-03  Tom Tromey  <tom@tromey.com>
8533
8534         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8535         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8536         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8537         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8538         (pspy_set_type_printers): Likewise.
8539         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8540         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8541         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8542         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8543         (objfpy_set_type_printers): Likewise.
8544
8545 2019-01-03  Tom Tromey  <tom@tromey.com>
8546
8547         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8548         (gdbpy_print_stack): Use gdbpy_err_fetch.
8549         * python/python-internal.h (class gdbpy_err_fetch): New class.
8550         (class gdbpy_enter) <m_error_type, m_error_value,
8551         m_error_traceback>: Remove.
8552         <m_error>: New member.
8553         (gdbpy_exception_to_string): Don't declare.
8554         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8555         * python/py-value.c (convert_value_from_python): Use
8556         gdbpy_err_fetch.
8557         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8558         gdbpy_exception_to_string.
8559         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8560         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8561         gdbpy_err_fetch.
8562
8563 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8564
8565         * linux-nat.c (delete_lwp_cleanup): Delete.
8566         (struct lwp_deleter): New struct.
8567         (lwp_info_up): New typedef.
8568         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8569         lwp_info_up.
8570
8571 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8572
8573         * linux-fork.c (class scoped_switch_fork_info): New class.
8574         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8575
8576 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8577
8578         * valops.c (find_overload_match): Remove use of null_cleanup, and
8579         calls to do_cleanups.
8580
8581 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8582
8583         * compile/compile-cplus-types.c
8584         (compile_cplus_instance::decl_name): Handle changes to
8585         cp_func_name.
8586         * cp-support.c (cp_func_name): Update header comment, update
8587         return type.
8588         * cp-support.h (cp_func_name): Update return type in declaration.
8589         * valops.c (find_overload_match): Move temp_func local to top
8590         level of function and change its type.  Use temp_func to hold and
8591         delete temporary string obtained from cp_func_name.
8592
8593 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8594
8595         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8596         gdb::char_vector, remove cleanup, and update uses of `msg`.
8597
8598 2019-01-03  Jim Wilson  <jimw@sifive.com>
8599
8600         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8601
8602 2019-01-02  Tom Tromey  <tom@tromey.com>
8603
8604         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8605         (tdesc_parse_xml): Remove cleanups.
8606         * target-descriptions.h (make_cleanup_free_target_description):
8607         Don't declare.
8608         (target_desc_deleter): New struct.
8609         (target_desc_up): New typedef.
8610         * target-descriptions.c (target_desc_deleter::operator()): Rename
8611         from free_target_description.
8612         (make_cleanup_free_target_description): Remove.
8613
8614 2019-01-02  Tom Tromey  <tom@tromey.com>
8615
8616         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8617         constructor, destructor.
8618         (linespec_parser): Remove typedef.
8619         (~linespec_parser): Rename from linespec_parser_delete.
8620         (linespec_lex_to_end, linespec_complete_label)
8621         (linespec_complete): Update.
8622         (decode_line_full): Remove cleanups.
8623         (decode_line_1): Update.
8624
8625 2019-01-02  Tom Tromey  <tom@tromey.com>
8626
8627         * python/python-internal.h (inferior_to_inferior_object): Change
8628         return type.
8629         * python/py-exitedevent.c (create_exited_event_object): Update.
8630         * python/py-inferior.c (inferior_to_inferior_object): Return
8631         gdbpy_ref.
8632         (python_new_inferior, python_inferior_deleted)
8633         (thread_to_thread_object, delete_thread_object)
8634         (build_inferior_list, gdbpy_selected_inferior): Update.
8635         * python/py-infthread.c (create_thread_object): Update.  Also fail
8636         if inferior_to_inferior_object fails.
8637
8638 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8639
8640         * inferior.h (class inferior) <displaced_step_state>: New field.
8641         * infrun.h (struct displaced_step_state): Move here from
8642         infrun.c.  Initialize fields, add constructor.
8643         <inf>: Remove field.
8644         <reset>: New method.
8645         * infrun.c (struct displaced_step_inferior_state): Move to
8646         infrun.h.
8647         (displaced_step_inferior_states): Remove.
8648         (get_displaced_stepping_state): Adust.
8649         (displaced_step_in_progress_any_inferior): Adjust.
8650         (displaced_step_in_progress_thread): Adjust.
8651         (displaced_step_in_progress): Adjust.
8652         (add_displaced_stepping_state): Remove.
8653         (get_displaced_step_closure_by_addr): Adjust.
8654         (remove_displaced_stepping_state): Remove.
8655         (infrun_inferior_exit): Call displaced_step_state.reset.
8656         (use_displaced_stepping): Don't check for NULL.
8657         (displaced_step_prepare_throw): Call
8658         get_displaced_stepping_state.
8659         (displaced_step_fixup): Don't check for NULL.
8660         (prepare_for_detach): Don't check for NULL.
8661
8662 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8663
8664         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8665          in case of call that did not complete.
8666
8667 2019-01-02  Andrey Utkin  <autkin@undo.io>
8668
8669         * symfile.c (find_separate_debug_file): Fix search of debug files for
8670         remote debuggee.
8671
8672 2019-01-02  Tom Tromey  <tom@tromey.com>
8673
8674         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8675         indentation.
8676         * python/py-frame.c (frapy_older): Remove cast.
8677         (frapy_newer): Likewise.
8678         * python/py-breakpoint.c (local_setattro): Remove cast.
8679         * python/py-arch.c (archpy_name): Remove local variable.
8680         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8681
8682 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8683
8684         * unittests/basic_string_view/element_access/char/empty.cc:
8685         Fix year range in copyright header.
8686
8687 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8688
8689         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8690         Delete.
8691         <operator==>: Update with for removed field.
8692         <hash>: Likewise.
8693         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8694         <isa_features>: ...this.
8695         <abi_features>: New field.
8696         (riscv_isa_flen): Update comment.
8697         (riscv_abi_xlen): New declaration.
8698         (riscv_abi_flen): New declaration.
8699         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8700         isa_features.
8701         (riscv_abi_xlen): New function.
8702         (riscv_isa_flen): Update to get answer from isa_features.
8703         (riscv_abi_flen): New function.
8704         (riscv_has_fp_abi): Update to get answer from abi_features.
8705         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8706         xlen and flen.
8707         (riscv_call_info) <xlen, flen>: Update comment.
8708         (riscv_call_arg_struct): Remove invalid assertions
8709         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8710         is removed.
8711         (riscv_gdbarch_init): Gather isa features and abi features
8712         separately, ensure both match on the gdbarch when reusing an old
8713         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8714         a target with 64-bit float hardware.
8715
8716 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8717
8718         * source.c (search_command_helper): Stop reverse search
8719         when line 1 has been searched.
8720
8721 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8722
8723         * record-full.c (record_full_base_target::close): Rewrite
8724         record_full_core_buf_list free logic.
8725
8726 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8727
8728         * break-catch-syscall.c (print_one_catch_syscall): xfree
8729         the last text.
8730
8731 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8732
8733         * top.c (print_gdb_version): Update Copyright year in version
8734         message.
8735
8736 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8737
8738         Update copyright year range in all GDB files.
8739
8740 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8741
8742         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8743
8744 For older changes see ChangeLog-2018.
8745 \f
8746 Local Variables:
8747 mode: change-log
8748 left-margin: 8
8749 fill-column: 74
8750 version-control: never
8751 coding: utf-8
8752 End:
8753