gdb/ChangeLog

   1 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
   2
   3         * stack.c (find_frame_funname): Remove code which preferred
   4         minsym over symtab sym in "certain pathological cases".
   5
   6         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
   7         parameter.  Change type of "do_demangle" to bool.
   8         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
   9         Pass suitable "prefer_sym_over_minsym" flag to
  10         build_address_symbolic().  Don't output "+" for negative offsets.
  11         * printcmd.c (print_address_symbolic): Update invocation of
  12         build_address_symbolic to include a "prefer_sym_over_minsym"
  13         flag.
  14         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
  15         Restrict cases in which use of minimal symbol is preferred to that
  16         of a found symbol.  Update comments.
  17
  18         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
  19         for entry pc when entry pc is out of range for that FDE.
  20
  21         * printcmd.c (print_address_symbolic): Print negative offsets.
  22         (build_address_symbolic): Force signed arithmetic when computing
  23         offset.
  24
  25 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
  26
  27         PR gdb/24839:
  28         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
  29         type.
  30
  31 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
  32
  33         * python/py-objfile.c (add_separate_debug_file): Fix comment about
  34         this function's Python signature.
  35
  36
  37 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
  38
  39         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
  40         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  41         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  42         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
  43         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
  44
  45
  46 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
  47
  48         * h8300-tdep.c (h8300_register_name_common): New.
  49         h8300_register_name): Use h8300_register_name_common.
  50         (h8300s_register_name): Likewise.
  51         (h8300sx_register_name): Likewise.
  52         (h8300h_register_nam): New.
  53         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
  54
  55
  56 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
  57
  58         * arm-tdep.c (arm_skip_cmse_entry): New function.
  59         (arm_is_sgstubs_section): New function.
  60         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
  61
  62 2019-07-22  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
  65         Don't self-assign.
  66
  67 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  68
  69         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
  70         type_print.
  71
  72 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  73
  74         * symtab.c (search_symbols): Adjust msymbol matching type arrays
  75         so that GDB doesn't match any msymbols when searching in the
  76         TYPES_DOMAIN.
  77         (print_symbol_info): Print using typedef_print or type_print based
  78         on the type of the symbol.  Add updated FIXME comment moved from...
  79         (_initialize_symtab): ... move and update FIXME comment to above.
  80
  81 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  82
  83         * NEWS: Mention adding -q option to "info types".
  84         * symtab.c (struct info_types_options): New struct.
  85         (info_types_options_defs): New variable.
  86         (make_info_types_options_def_group): New function.
  87         (info_types_command): Use gdb::option framework to parse options.
  88         (info_types_command_completer): New function.
  89         (_initialize_symtab): Extend the help text on "info types" and
  90         register command completer.
  91
  92 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
  93
  94         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
  95         (lookup_symbol_in_objfile): Change int to block_enum and add a
  96         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
  97
  98 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
  99
 100         * MAINTAINERS (Write After Approval): Add self.
 101
 102 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 103
 104         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 105         instruction to the dummy code region.
 106
 107 2019-07-19  Tom Tromey  <tromey@adacore.com>
 108
 109         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 110         (ARGSUSED, PARAMS, __func__): Remove rules.
 111
 112 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 113
 114         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 115         * features/arm/arm-with-iwmmxt.c: Remove.
 116         * features/arm/arm-with-iwmmxt.xml: Remove.
 117         * features/arm/arm-with-m-fpa-layout.c: Remove.
 118         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 119         * features/arm/arm-with-m-vfp-d16.c: Remove.
 120         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 121         * features/arm/arm-with-m.c: Remove.
 122         * features/arm/arm-with-m.xml: Remove.
 123         * features/arm/arm-with-neon.c: Remove.
 124         * features/arm/arm-with-neon.xml: Remove.
 125         * features/arm/arm-with-vfpv2.c: Remove.
 126         * features/arm/arm-with-vfpv2.xml: Remove.
 127         * features/arm/arm-with-vfpv3.c: Remove.
 128         * features/arm/arm-with-vfpv3.xml: Remove.
 129
 130 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 131
 132         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 133
 134 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 135
 136         * arch/aarch32.c (aarch32_create_target_description): Create
 137         target descriptions using features.
 138         * arch/arm.c (arm_create_target_description)
 139         (arm_create_mprofile_target_description): Likewise.
 140         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 141
 142 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 143
 144         * Makefile.in: Add new files.
 145         * aarch32-tdep.c: New file.
 146         * aarch32-tdep.h: New file.
 147         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 148         Call aarch32_read_description.
 149         * arch/aarch32.c: New file.
 150         * arch/aarch32.h: New file.
 151         * arch/arm.c (arm_create_target_description)
 152         (arm_create_mprofile_target_description): New function.
 153         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 154         (arm_create_target_description)
 155         (arm_create_mprofile_target_description): New declaration.
 156         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 157         read_description functions.
 158         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 159         Likewise.
 160         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 161         * arm-tdep.c (tdesc_arm_list): New variable.
 162         (arm_register_g_packet_guesses): Call create description functions.
 163         (arm_read_description) (arm_read_mprofile_description): New
 164         function.
 165         * arm-tdep.h (arm_read_description)
 166         (arm_read_mprofile_description): Add declaration.
 167         * configure.tgt: Add new files.
 168
 169 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 170
 171         * top.c (new_ui_command): Open specified terminal just once.
 172
 173 2019-07-18  Tom Tromey  <tromey@adacore.com>
 174
 175         * symtab.c (main_name): Constify return type.
 176         * symfile.c (set_initial_language): Update.
 177         * symtab.h (main_name): Constify return type.
 178
 179 2019-07-17  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-winsource.c (tui_update_source_window)
 182         (tui_update_source_window_as_is)
 183         (tui_update_source_windows_with_line): Remove return.
 184         * tui/tui-disasm.c (tui_show_disassem)
 185         (tui_show_disassem_and_update_source): Remove return.
 186         * tui/tui.c (tui_reset): Remove return.
 187         * tui/tui-wingeneral.c
 188         (tui_check_and_display_highlight_if_needed): Remove return.
 189
 190 2019-07-17  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 193
 194 2019-07-17  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-winsource.h (struct tui_exec_info_window)
 197         (struct tui_source_window_base): Move from tui-data.h.
 198         * tui/tui-winsource.c: Move many method definitions from
 199         elsewhere.  Remove "structuring" comments.
 200         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 201         (tui_source_window_base::refresh_window): Move to
 202         tui-winsource.c.
 203         * tui/tui-win.c (tui_source_window_base::refresh_all)
 204         (tui_source_window_base::update_tab_width)
 205         (tui_source_window_base::set_new_height)
 206         (tui_source_window_base::do_make_visible_with_new_height): Move to
 207         tui-winsource.c.
 208         * tui/tui-source.h: Update.
 209         * tui/tui-source.c (tui_source_window_base::reset): Move to
 210         tui-winsource.c.
 211         * tui/tui-disasm.h: Update.
 212         * tui/tui-data.h (struct tui_exec_info_window): Move to
 213         tui-winsource.h.
 214         (struct tui_source_window_base): Likewise.
 215         * tui/tui-data.c (tui_source_window_base::clear_detail)
 216         (tui_source_window_base, ~tui_source_window_base): Move to
 217         tui-winsource.c.
 218
 219 2019-07-17  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-win.c (tui_resize_all)
 222         (tui_source_window_base::update_tab_width)
 223         (tui_adjust_win_heights): Update.
 224         (tui_win_info::make_invisible_and_set_new_height): Rename from
 225         make_invisible_and_set_new_height.
 226         * tui/tui-data.h (struct tui_win_info)
 227         <make_invisible_and_set_new_height>: New method.
 228
 229 2019-07-17  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui.c: Update.
 232         * tui/tui-source.h (struct tui_source_window): Move from
 233         tui-data.h.
 234         * tui/tui-layout.c: Update.
 235         * tui/tui-disasm.c: Update.
 236         * tui/tui-data.h (struct tui_source_window): Move to
 237         tui-source.h.
 238
 239 2019-07-17  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 242         tui-data.h.
 243         * tui/tui-data.h (struct tui_disasm_window): Move to
 244         tui-disasm.h.
 245
 246 2019-07-17  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-regs.h (struct tui_data_item_window): Move from
 249         tui-data.h.
 250         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 251         * tui/tui-data.h (struct tui_data_item_window): Move to
 252         tui-regs.h.
 253         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 254
 255 2019-07-17  Tom Tromey  <tom@tromey.com>
 256
 257         * tui/tui.c: Update.
 258         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 259         (tui_cmd_window::max_height): Move to tui-command.c.
 260         * tui/tui-layout.c: Update.
 261         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 262         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 263         tui-command.c.
 264         * tui/tui-command.h (struct tui_cmd_window): Move from
 265         tui-data.h.
 266         * tui/tui-command.c: Remove "structuring" comments.
 267         (tui_cmd_window::clear_detail)
 268         (tui_cmd_window::do_make_visible_with_new_height)
 269         (tui_cmd_window::max_height): Move from elsewhere.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 274         Now static.
 275         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 276         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 277
 278 2019-07-17  Tom Tromey  <tom@tromey.com>
 279
 280         * tui/tui.c: Update.
 281         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 282         tui-regs.c.
 283         * tui/tui-windata.h: Remove file.
 284         * tui/tui-windata.c: Remove file.
 285         * tui/tui-win.c (tui_data_window::set_new_height)
 286         (tui_data_window::do_make_visible_with_new_height): Move to
 287         tui-regs.c.
 288         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 289         * tui/tui-regs.c: Remove "structuring" comments.
 290         (tui_data_window::first_data_item_displayed)
 291         (tui_data_window::delete_data_content_windows)
 292         (tui_data_window::erase_data_content)
 293         (tui_data_window::display_all_data)
 294         (tui_data_window::refresh_all)
 295         (tui_data_window::do_scroll_vertical)
 296         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 297         (tui_data_window::do_make_visible_with_new_height)
 298         (tui_data_window::refresh_window): Move from elsewhere.
 299         (_initialize_tui_regs): Move to end of file.
 300         * tui/tui-layout.c: Update.
 301         * tui/tui-hooks.c: Update.
 302         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 303         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 304         tui-regs.c.
 305         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 306
 307 2019-07-17  Tom Tromey  <tom@tromey.com>
 308
 309         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 310         seen.
 311
 312 2019-07-17  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-win.c (tui_source_window_base::set_new_height)
 315         (tui_source_window_base::do_make_visible_with_new_height): Use
 316         m_has_locator field directly.
 317         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 318         method.
 319         (struct tui_source_window_base) <has_locator>: Likewise.
 320
 321 2019-07-17  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 324         Don't declare.
 325         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 326         Remove.
 327         * tui/tui-win.c (tui_source_window_base::set_new_height)
 328         (tui_source_window_base::set_new_height)
 329         (make_invisible_and_set_new_height)
 330         (tui_source_window_base::do_make_visible_with_new_height)
 331         (tui_source_window_base::do_make_visible_with_new_height):
 332         Update.
 333         * tui/tui-layout.c (show_source_disasm_command, show_data)
 334         (show_source_or_disasm_and_command): Update.
 335         * tui/tui-layout.c (show_layout): Update.
 336
 337 2019-07-17  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-layout.c (make_data_window): Remove.
 340         (show_data): Unify creation and re-initialization cases.
 341
 342 2019-07-17  Tom Tromey  <tom@tromey.com>
 343
 344         * tui/tui-layout.c (make_source_window, make_disasm_window):
 345         Remove.
 346         (show_data): Unify creation and re-initialization cases.
 347
 348 2019-07-17  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-layout.c (make_command_window): Remove.
 351         (show_source_disasm_command, show_source_or_disasm_and_command):
 352         Unify creation and re-initialization cases.
 353
 354 2019-07-17  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 357         creation and re-initialization cases.
 358
 359 2019-07-17  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-regs.c (tui_get_register): Return void.
 362
 363 2019-07-17  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 366         Simplify.
 367
 368 2019-07-17  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 371         resetting.
 372
 373 2019-07-17  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 376         * tui/tui-regs.c (tui_reg_layout): New function.
 377         (tui_show_registers, tui_reg_command): Use it.
 378         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 379         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 380         parameters.
 381         (tui_layout_command): Remove.
 382
 383 2019-07-17  Tom Tromey  <tom@tromey.com>
 384
 385         * tui/tui-layout.h (tui/tui-layout): Return void.
 386         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 387
 388 2019-07-17  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-layout.c (show_source_disasm_command, show_data):
 391         Update.
 392         (reset_locator): Remove.
 393         (show_source_or_disasm_and_command): Update.
 394
 395 2019-07-17  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-source.c (tui_source_window_base::reset): Remove
 398         win_type parameter.
 399         * tui/tui-layout.c (make_command_window, make_source_window)
 400         (make_disasm_window, make_data_window)
 401         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 402         (reset_locator, show_source_or_disasm_and_command): Update.
 403         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 404         win_type parameter.
 405         (struct tui_source_window_base) <reset>: Likewise.
 406
 407 2019-07-17  Tom Tromey  <tom@tromey.com>
 408
 409         * tui/tui-layout.c (show_source_disasm_command): Use
 410         reset_locator.
 411         (reset_locator): New function.
 412         (init_and_make_win): Remove.
 413         (show_source_or_disasm_and_command): Use reset_locator.
 414
 415 2019-07-17  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 418         condition.
 419         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 420         Remove condition.
 421         * tui/tui-source.c (tui_source_window_base::reset): New method.
 422         * tui/tui-layout.c (make_command_window): Don't call
 423         init_and_make_win.
 424         (make_source_window, make_disasm_window): Don't call
 425         make_source_or_disasm_window.
 426         (make_data_window): Don't call init_and_make_win.  Change calling
 427         convention.
 428         (show_source_disasm_command, show_data): Simplify.
 429         (make_source_or_disasm_window): Remove.
 430         (show_source_or_disasm_and_command): Simplify.
 431         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 432         (struct tui_source_window_base) <reset>: Likewise.
 433         <execution_info>: Remove initializer.
 434         * tui/tui-data.c (tui_source_window_base): Initialize
 435         execution_info.
 436
 437 2019-07-17  Tom Tromey  <tom@tromey.com>
 438
 439         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 440         variable.
 441
 442 2019-07-17  Tom Tromey  <tom@tromey.com>
 443
 444         * tui/tui.c (tui_rl_other_window): Update.
 445         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 446         superclass method first.  Always iterate over regs_content.
 447         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 448         method.
 449         * tui/tui-win.c (tui_set_focus_command): Update.
 450
 451 2019-07-17  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-win.c (tui_set_focus_command): Rename from
 454         tui_set_focus.  Call tui_enable.
 455         (tui_set_focus_command): Remove.
 456
 457 2019-07-17  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 460         refresh_window.
 461         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 462         touchwin.
 463         (tui_data_window::refresh_window): Call refresh_window on data
 464         items.  Always call superclass refresh_window.
 465         (tui_win_info::refresh): Remove.
 466         (tui_source_window_base::refresh_window): Update.
 467         (tui_refresh_all): Update.
 468         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 469         refresh_window.
 470         (show_source_or_disasm_and_command): Likewise.
 471         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 472         (struct tui_source_window_base) <refresh>: Likewise.
 473
 474 2019-07-17  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-winsource.c (tui_clear_source_content)
 477         (tui_show_source_content): Update.
 478         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 479         whether content is empty.
 480         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 481         Remove.
 482
 483 2019-07-17  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 486         window's contents.
 487         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 488         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 489
 490 2019-07-17  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 493         (struct tui_data_item_window): Update.
 494
 495 2019-07-17  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 498         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 499         defines.
 500
 501 2019-07-17  Tom Tromey  <tom@tromey.com>
 502
 503         * tui/tui-winsource.h (tui_erase_source_content)
 504         (tui_clear_source_content): Remove "display_prompt" parameter.
 505         * tui/tui-winsource.c (tui_update_source_window_as_is)
 506         (tui_update_source_windows_with_addr): Update.
 507         (tui_clear_source_content): Remove "display_prompt" parameter.
 508         (tui_erase_source_content): Likewise.  Simplify.
 509         (tui_show_source_content): Update.
 510         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 511         * tui/tui-stack.c (tui_show_frame_info): Update.
 512         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 513         Remove defines.
 514
 515 2019-07-17  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 518         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 519         parameter.
 520         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 521         parameter.
 522
 523 2019-07-17  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-winsource.c (tui_clear_source_content)
 526         (tui_show_source_content, tui_show_exec_info_content)
 527         (tui_clear_exec_info_content): Update.
 528         * tui/tui-stack.c (tui_show_locator_content): Update.
 529         (tui_show_frame_info): Update.
 530         * tui/tui-source.h (tui_source_window): Don't declare.
 531         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 532         from tui_source_is_displayed.
 533         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 534         Remove field.
 535         (struct tui_source_window_base) <content_in_use>: New field.  Now
 536         bool.
 537         (struct tui_source_window) <showing_source_p>: New method.
 538         (TUI_SRC_WIN): Change cast.
 539         * tui/tui-data.c (tui_initialize_static_data): Update.
 540
 541 2019-07-17  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 544         location_matches_p.
 545         * tui/tui-source.c (tui_source_window::location_matches_p): New
 546         method.
 547         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 548         method.
 549         * tui/tui-data.h (struct tui_source_window_base)
 550         <location_matches_p>: New method.
 551         (struct tui_source_window, struct tui_disasm_window)
 552         <location_matches_p>: Likewise.
 553
 554 2019-07-17  Tom Tromey  <tom@tromey.com>
 555
 556         * tui/tui-win.c (tui_set_win_height_command): Rename from
 557         tui_set_win_height.
 558         (tui_set_win_height_command): Remove.
 559
 560 2019-07-17  Tom Tromey  <tom@tromey.com>
 561
 562         * tui/tui-source.c (tui_source_window): New constructor.  Add
 563         observer.
 564         (~tui_source_window): New destructor.
 565         (tui_source_window::style_changed): New method.
 566         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 567         (tui_attach_detach_observers): Update.
 568         * tui/tui-data.h (struct tui_source_window): Make constructor not
 569         inline.  Add destructor.
 570         (struct tui_source_window) <style_changed>: New method.
 571         <m_observable>: New member.
 572
 573 2019-07-17  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 576         * tui/tui-win.c (tui_resize_all): Fix typo.
 577
 578 2019-07-17  Tom Tromey  <tom@tromey.com>
 579
 580         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 581         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 582         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 583         * tui/tui-win.c (window_name_completer): Use foreach.
 584         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 585         (update_tab_width): Likewise.
 586         * tui/tui-layout.c (show_layout): Update.
 587         * tui/tui-data.h (class tui_window_iterator): New.
 588         (struct all_tui_windows): New.
 589         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 590
 591 2019-07-17  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 594         parameter.  Don't reference globals.
 595         (tui_reg_command): Update.
 596
 597 2019-07-17  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui-regs.c (tui_show_registers): Simplify.
 600
 601 2019-07-17  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-regs.c (tui_show_registers): Update.
 604         (tui_show_register_group): Add win_info parameter.
 605
 606 2019-07-17  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 609         Rename from tui_display_reg_element_at_line.
 610         (tui_data_window::display_registers_from_line): Update.
 611         * tui/tui-data.h (struct tui_data_window)
 612         <display_reg_element_at_line>: New method.
 613
 614 2019-07-17  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-regs.h (tui_display_registers_from)
 617         (tui_display_registers_from_line): Don't declare.
 618         * tui/tui-windata.c (tui_data_window::display_all_data)
 619         (tui_data_window::refresh_all)
 620         (tui_data_window::do_scroll_vertical): Update.
 621         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 622         from tui_display_registers_from.
 623         (tui_display_reg_element_at_line): Update.
 624         (tui_data_window::display_registers_from_line): Rename from
 625         tui_display_registers_from_line.
 626         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 627         display_registers_from_line>: New methods.
 628
 629 2019-07-17  Tom Tromey  <tom@tromey.com>
 630
 631         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 632         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 633         from tui_erase_data_content.
 634         (tui_data_window::display_all_data)
 635         (tui_data_window::refresh_all)
 636         (tui_data_window::do_scroll_vertical): Update.
 637         * tui/tui-regs.c (tui_show_registers): Update.
 638         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 639         New method.
 640
 641 2019-07-17  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 644         declare.
 645         * tui/tui-windata.c
 646         (tui_data_window::delete_data_content_windows): Rename from
 647         tui_delete_data_content_windows.
 648         (tui_data_window::display_all_data)
 649         (tui_data_window::do_scroll_vertical): Update.
 650         * tui/tui-data.h (struct tui_data_window)
 651         <delete_data_content_windows>: New method.
 652
 653 2019-07-17  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 656         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 657
 658 2019-07-17  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 661         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 662         from tui_display_all_data.
 663         * tui/tui-win.c
 664         (tui_data_window::do_make_visible_with_new_height): Update.
 665         * tui/tui-regs.c (tui_show_registers): Update.
 666         * tui/tui-layout.c (tui_set_layout): Update.
 667         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 668         method.
 669
 670 2019-07-17  Tom Tromey  <tom@tromey.com>
 671
 672         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 673         * tui/tui-windata.c (tui_display_data_from): Remove.
 674         (tui_data_window::refresh_all): Update.
 675
 676 2019-07-17  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 679         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 680         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 681         tui_display_registers_from_line.
 682         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 683         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 684         "force_display" parameter.
 685
 686 2019-07-17  Tom Tromey  <tom@tromey.com>
 687
 688         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 689         declare.
 690         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 691         Rename from tui_first_reg_element_no_inline.
 692         (tui_display_reg_element_at_line)
 693         (tui_display_registers_from_line): Update.
 694         * tui/tui-data.h (struct tui_data_window)
 695         <first_reg_element_no_inline>: New method.
 696
 697 2019-07-17  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-windata.c (tui_display_data_from)
 700         (tui_data_window::do_scroll_vertical): Update.
 701         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 702         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 703         Rename from tui_line_from_reg_element_no.
 704         (tui_display_registers_from_line): Update.
 705         * tui/tui-data.h (struct tui_data_window)
 706         <line_from_reg_element_no>: New method.
 707
 708 2019-07-17  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 711         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 712         tui_last_regs_line_no.
 713         (tui_display_reg_element_at_line)
 714         (tui_display_registers_from_line): Update.
 715         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 716         method.
 717
 718 2019-07-17  Tom Tromey  <tom@tromey.com>
 719
 720         PR tui/24722:
 721         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 722         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 723         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 724         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 725         (tui_update_breakpoint_info): Likewise.
 726         * tui/tui-hooks.c (tui_event_create_breakpoint)
 727         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 728         Update.
 729
 730 2019-07-17  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 733
 734 2019-07-17  Tom Tromey  <tom@tromey.com>
 735
 736         * tui/tui-winsource.c (tui_update_source_window_as_is)
 737         (tui_update_source_windows_with_addr): Update.
 738         * tui/tui-source.h (tui_set_source_content)
 739         (tui_show_symtab_source): Add "win_info" parameter.
 740         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 741         parameter.
 742         (tui_show_symtab_source): Likewise.
 743
 744 2019-07-17  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-wingeneral.c
 747         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 748
 749 2019-07-17  Tom Tromey  <tom@tromey.com>
 750
 751         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 752         (struct tui_cmd_window) <can_scroll>: New method.
 753         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 754         method.
 755
 756 2019-07-17  Tom Tromey  <tromey@adacore.com>
 757
 758         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 759         do_field_signed>: Rename.  Change type of "value".
 760         * ui-out.c (ui_out::field_signed): Rename from field_int.
 761         Change type of "value".
 762         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 763         type of "value".
 764         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 765         do_field_int.  Change type of "value".
 766         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 767         do_field_int.  Change type of "value".
 768         * tracepoint.c (trace_status_mi, tfind_1)
 769         (print_one_static_tracepoint_marker): Update.
 770         * thread.c (print_thread_info_1, print_selected_thread_frame):
 771         Update.
 772         * stack.c (print_frame, print_frame_info): Update.
 773         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 774         Update.
 775         * source.c (print_source_lines_base): Update.
 776         * skip.c (info_skip_command): Update.
 777         * record-btrace.c (btrace_ui_out_decode_error)
 778         (btrace_call_history_src_line): Update.
 779         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 780         Update.
 781         * progspace.c (print_program_space): Update.
 782         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 783         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 784         do_field_int.  Change type of "value".
 785         * mi/mi-out.c (mi_ui_out::do_table_begin)
 786         (mi_ui_out::do_table_header): Update.
 787         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 788         type of "value".
 789         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 790         (mi_cmd_data_list_changed_registers, output_register)
 791         (mi_cmd_data_read_memory, mi_load_progress)
 792         (mi_cmd_trace_frame_collected): Update.
 793         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 794         Update.
 795         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 796         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 797         (mi_cmd_var_list_children, varobj_update_one): Update.
 798         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 799         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 800         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 801         * inferior.c (print_inferior): Update.
 802         * gdb_bfd.c (print_one_bfd): Update.
 803         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 804         Update.
 805         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 806         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 807         do_field_int.  Change type of "value".
 808         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 809         do_field_int.  Change type of "value".
 810         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 811         (print_one_breakpoint_location, print_it_catch_fork)
 812         (print_one_catch_fork, print_it_catch_vfork)
 813         (print_one_catch_vfork, print_it_catch_solib)
 814         (print_it_catch_exec, print_it_ranged_breakpoint)
 815         (print_mention_watchpoint, print_mention_masked_watchpoint)
 816         (bkpt_print_it, update_static_tracepoint): Update.
 817         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 818         * break-catch-syscall.c (print_it_catch_syscall): Update.
 819         * ada-tasks.c (print_ada_task_info): Update.
 820         * ada-lang.c (print_it_exception, print_mention_exception):
 821         Update.
 822
 823 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 824
 825         PR breakpoints/24541
 826         * gdbarch.c: Regenerate.
 827         * gdbarch.h: Regenerate.
 828         * gdbarch.sh: Adjust return type and parameter types for
 829         'stap_adjust_register'.
 830         (i386_stap_adjust_register): Adjust signature and return new
 831         register name.
 832         * stap-probe.c (stap_parse_register_operand): Adjust use of
 833         'gdbarch_stap_adjust_register'.
 834
 835 2019-07-17  Tom Tromey  <tromey@adacore.com>
 836
 837         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 838         declare VEC.
 839         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 840         std::vector.
 841         (struct s390_process_info): Add initializers.
 842         (s390_add_process): Use new.
 843         (s390_linux_nat_target::low_forget_process): Use delete.
 844         (s390_linux_nat_target::low_new_fork)
 845         (s390_linux_nat_target::stopped_by_watchpoint)
 846         (s390_linux_nat_target::low_prepare_to_resume)
 847         (s390_linux_nat_target::insert_watchpoint)
 848         (s390_linux_nat_target::insert_hw_breakpoint)
 849         (s390_linux_nat_target::remove_watchpoint)
 850         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 851
 852 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 853
 854         * aarch64-fbsd-nat.c: Include regcache.h.
 855         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 856         argument.
 857         (aarch64_fbsd_nat_target::fetch_registers)
 858         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 859         variable.
 860         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 861
 862 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 863
 864         * fbsd-nat.c: Include gdbarch.h.
 865
 866 2019-07-15  Tom Tromey  <tromey@adacore.com>
 867
 868         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 869
 870 2019-07-15  Tom Tromey  <tromey@adacore.com>
 871
 872         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 873         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 874         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 875         * cli-out.c (cli_ui_out::do_field_int): New method.
 876         * ui-out.c (ui_out::field_unsigned): New method.
 877         * symfile.c (generic_load): Use field_unsigned.
 878         (print_transfer_performance): Likewise.
 879         * record-btrace.c (ui_out_field_uint): Remove.
 880         (btrace_call_history_insn_range, btrace_call_history): Use
 881         field_unsigned.
 882         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 883         field_unsigned.
 884         * ui-out.h (class ui_out) <field_unsigned>: New method.
 885         <do_field_unsigned>: Likewise.
 886
 887 2019-07-15  Tom Tromey  <tromey@adacore.com>
 888
 889         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 890         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 891         * target.c (flash_erase_command): Use field_string.
 892         * infrun.c (print_signal_received_reason): Use field_string.
 893         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 894         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 895         field_string.
 896         * ada-tasks.c (print_ada_task_info): Use field_string.
 897
 898 2019-07-15  Tom Tromey  <tromey@adacore.com>
 899
 900         * target.c (flash_erase_command): Use field_core_addr.
 901         * symfile.c (generic_load): Use field_core_addr.
 902         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 903         Use field_core_addr.
 904         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 905         field_core_addr.
 906
 907 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 908
 909         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 910         value if its desired type is smaller than a CORE_ADDR and signed.
 911
 912 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 913
 914         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 915         of changes to field names, and use new is_reference field to
 916         decide if a property is a reference or not.
 917         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 918         field.
 919         (struct dwarf2_property_baton): Update header comment, rename
 920         'referenced_type' to 'property_type' and update comments.
 921         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 922         default property type, store in property baton, update to take
 923         accound of renamed field.
 924         (read_func_scope): Update call to attr_to_dynamic_prop.
 925         (read_array_type): Likewise.
 926         (dwarf2_per_cu_addr_sized_int_type): New function.
 927         (read_subrange_index_type): Move type finding code to
 928         dwarf2_per_cu_addr_sized_int_type.
 929         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 930         (dwarf2_per_cu_addr_type): New function.
 931         (set_die_type): Update calls to attr_to_dynamic_prop.
 932
 933 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 934
 935         * dwarf2read.c (read_subrange_index_type): New function.
 936         (read_subrange_type): Move code into new function and call it.
 937         * gdbtypes.c (create_range_type): Add some asserts.
 938
 939 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 942         update return statements.
 943         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 944         declaration, and update comment to match.
 945         * gdbtypes.c (resolve_dynamic_array): Update call to
 946         dwarf2_evaluate_property to match new return type.
 947
 948 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 949
 950         * valarith.c (value_subscripted_rvalue): Change lowerbound
 951         parameter type from int to LONGEST.
 952         * value.h (value_subscripted_rvalue): Likewise in declaration.
 953
 954 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 955
 956         * cli/cli-utils.c (info_print_command_completer): New function.
 957         * cli/cli-utils.h: Add 'completer.h' include, and forward
 958         declaration for 'struct cmd_list_element'.
 959         (info_print_command_completer): Declare.
 960         * stack.c (_initialize_stack): Add completer for 'info locals' and
 961         'info args'.
 962         * symtab.c (_initialize_symtab): Add completer for 'info
 963         variables' and 'info functions'.
 964         * NEWS: Mention completion for additional info commands.
 965
 966 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 967
 968         * cli/cli-utils.c (extract_info_print_args): Delete.
 969         (extract_arg_maybe_quoted): Delete.
 970         (info_print_options_defs): New variable.
 971         (make_info_print_options_def_group): New function.
 972         (extract_info_print_options): Define new function.
 973         * cli/cli-utils.h (extract_info_print_args): Delete.
 974         (struct info_print_options): New structure.
 975         (extract_info_print_options): Declare new function.
 976         * stack.c (info_locals_command): Update to use new
 977         extract_info_print_options, also add a header comment.
 978         (info_args_command): Likewise.
 979         * symtab.c (info_variables_command): Likewise.
 980         (info_functions_command): Likewise.
 981
 982 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 983
 984         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 985         to extract string arguments.
 986         * common/common-utils.c (extract_string_maybe_quoted): New function.
 987         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 988
 989 2019-07-11  Tom Tromey  <tromey@adacore.com>
 990
 991         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 992         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 993         * top.h (gdbinit): Don't declare.
 994         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 995         into...
 996         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 997         * top.c (gdb_init): Don't call init_cli_cmds.
 998         (gdbinit): Remove.
 999         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1000
1001 2019-07-11  Tom Tromey  <tromey@adacore.com>
1002
1003         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1004         after it has been moved.
1005
1006 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1007
1008         * valops.c (value_must_coerce_to_target): Change return type to
1009         bool.
1010         * value.h (value_must_coerce_to_target): Likewise.
1011
1012 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1013
1014         * breakpoint.c (is_hardware_watchpoint): Remove
1015         forward-declaration.
1016         (is_masked_watchpoint): Change return type to bool.
1017         (is_tracepoint): Likewise.
1018         (is_breakpoint): Likewise.
1019         (is_hardware_watchpoint): Likewise.
1020         (is_watchpoint): Likewise.
1021         (is_no_memory_software_watchpoint): Likewise.
1022         (is_catchpoint): Likewise.
1023         (breakpoint_1): Make FILTER parameter's return type bool.
1024         is_masked_watchpoint): Change return type to bool.
1025         (save_breakpoints): Make FILTER parameter's return type bool.
1026         * breakpoint.h (is_breakpoint): Change return type to bool.
1027         (is_watchpoint): Likewise.
1028         (is_catchpoint): Likewise.
1029         (is_tracepoint): Likewise.
1030
1031 2019-07-10  Tom Tromey  <tom@tromey.com>
1032
1033         * defs.h: Don't include gdbarch.h.
1034         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1035         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1036         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1037         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1038         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1039         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1040         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1041         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1042         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1043         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1044         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1045         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1046         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1047         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1048         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1049         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1050         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1051         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1052         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1053         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1054         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1055         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1056         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1057         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1058         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1059         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1060         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1061
1062 2019-07-10  Tom Tromey  <tromey@adacore.com>
1063
1064         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1065         * breakpoint.c (init_ada_exception_breakpoint): Register as
1066         bp_catchpoint.
1067         (print_one_breakpoint_location, print_one_breakpoint): Use
1068         is_ada_exception_catchpoint.
1069         * ada-lang.c (class ada_catchpoint_location): Pass
1070         bp_loc_software_breakpoint to bp_location constructor.
1071         (is_ada_exception_catchpoint): New function.
1072
1073 2019-07-10  Tom Tromey  <tromey@adacore.com>
1074
1075         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1076         VEC.
1077         (struct arm_exidx_entry): New method operator<.
1078         (struct arm_exidx_data) <section_maps>: Change type.
1079         (arm_exidx_data_free): Remove.
1080         (arm_exidx_data_key): Change type.  Move lower.
1081         (arm_exidx_new_objfile): Update.
1082         (arm_compare_exidx_entries): Remove.
1083         (arm_find_exidx_entry, _initialize_arm_tdep)
1084
1085 2019-07-10  Tom Tromey  <tromey@adacore.com>
1086
1087         * solib-spu.c (ocl_program_data_key): Change type.
1088         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1089         Update.
1090
1091 2019-07-10  Tom Tromey  <tromey@adacore.com>
1092
1093         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1094         (struct solib_aix_inferior_data) <library_list>: Change type.
1095         (solib_aix_inferior_data_handle): Change type.
1096         (get_solib_aix_inferior_data): Update.
1097         (solib_aix_free_library_list): Remove.
1098         (library_list_start_library): Update.
1099         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1100         return type.
1101         (solib_aix_get_library_list)
1102         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1103         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1104
1105 2019-07-10  Tom Tromey  <tromey@adacore.com>
1106
1107         * solib-dsbt.c (struct dsbt_info): Add initializers.
1108         (solib_dsbt_pspace_data): Change type.
1109         (dsbt_pspace_data_cleanup): Remove.
1110         (get_dsbt_info, _initialize_dsbt_solib): Update.
1111
1112 2019-07-10  Tom Tromey  <tromey@adacore.com>
1113
1114         * spu-tdep.c (spu_overlay_data): Change type.
1115         (spu_get_overlay_table, spu_overlay_new_objfile)
1116         (_initialize_spu_tdep): Update.
1117
1118 2019-07-10  Tom Tromey  <tromey@adacore.com>
1119
1120         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1121         destructor.
1122         (dbx_objfile_data_key): Change type and declare later.
1123         (DBX_SYMFILE_INFO): Rewrite.
1124         * dbxread.c (dbx_objfile_data_key): Change type.
1125         (dbx_symfile_init): Update.
1126         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1127         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1128         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1129
1130 2019-07-10  Tom Tromey  <tromey@adacore.com>
1131
1132         * jit.c (jit_program_space_key): Change type.  Move lower.
1133         (get_jit_program_space_data): Update.
1134         (jit_program_space_data_cleanup): Remove.
1135         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1136         Update.
1137         (struct jit_program_space_data): Add initializers.
1138
1139 2019-07-10  Tom Tromey  <tromey@adacore.com>
1140
1141         * solib-darwin.c (struct darwin_info): Add initializers.
1142         (solib_darwin_pspace_data): Change type.
1143         (darwin_pspace_data_cleanup): Remove.
1144         (get_darwin_info, _initialize_darwin_solib): Update.
1145
1146 2019-07-10  Tom Tromey  <tromey@adacore.com>
1147
1148         * remote-sim.c (struct sim_inferior_data): Add initializers,
1149         constructor, and destructor.
1150         (sim_inferior_data_key): Change type.  Move lower.
1151         (check_for_duplicate_sim_descriptor): Update.
1152         (get_sim_inferior_data): Use new.  Update.
1153         (~sim_inferior_data_cleanup): Rename from
1154         sim_inferior_data_cleanup.  Simplify.
1155         (gdbsim_close_inferior, simulator_command)
1156         (sim_command_completer, _initialize_remote_sim): Update.
1157         (next_pid, INITIAL_PID): Move earlier.
1158
1159 2019-07-10  Tom Tromey  <tromey@adacore.com>
1160
1161         * python/python-internal.h (create_thread_object): Return
1162         gdbpy_ref.
1163         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1164         * python/py-inferior.c (struct threadlist_entry): Add
1165         constructor.
1166         <thread_obj>: Now a gdbpy_ref.
1167         (thread_to_thread_object): Update.
1168         (add_thread_object): Use new.
1169         (delete_thread_object): Use delete.
1170         (infpy_threads): Update.
1171         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1172         GIL.
1173
1174 2019-07-10  Tom Tromey  <tromey@adacore.com>
1175
1176         * valops.c (value_cast): Specialize error message for Ada.
1177
1178 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1179
1180         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1181
1182 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1183
1184         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1185         bpstat_should_step): Return bool, adjust comments.
1186         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1187         bpstat_should_step): Likewise.
1188
1189 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1190
1191         * features/Makefile: Use feature target descriptions for Arm.
1192         * features/arm/arm-core.c: Generate new file.
1193         * features/arm/arm-fpa.c: Likewise.
1194         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1195         * features/arm/arm-m-profile.c: Likewise.
1196         * features/arm/arm-vfpv2.c: Likewise.
1197         * features/arm/arm-vfpv3.c: Likewise.
1198         * features/arm/xscale-iwmmxt.c: Likewise.
1199         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1200
1201 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1202
1203         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1204         ptrace earlier.
1205
1206 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1207
1208         * features/aarch64-pauth.c: Regenerate.
1209
1210 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1211
1212         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1213         bool.
1214         (bpstat_what): Use false instead of 0.
1215
1216 2019-07-09  Pedro Alves  <palves@redhat.com>
1217
1218         * break-catch-throw.c (is_exception_catchpoint): New.
1219         * breakpoint.c (print_one_breakpoint_location): New parameter
1220         'raw_loc'.  Handle it.  Use
1221         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1222         looking at the breakpoint's type.
1223         (print_one_breakpoint): If handling "maint info breakpoints", also
1224         print locations of exception catchpoints.
1225         * breakpoint.h (is_exception_catchpoint): Declare.
1226
1227 2019-07-09  Pedro Alves  <palves@redhat.com>
1228
1229         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1230         "addr" field.
1231         (allocate_location_exception_catchpoint): New.
1232         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1233         (initialize_throw_catchpoint_ops): Install
1234         allocate_location_exception_catchpoint as allocate_location
1235         method.
1236         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1237         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1238         bp_loc_other.
1239         (breakpoint_address_is_meaningful): Delete.
1240         (bl_address_is_meaningful): New.
1241         (breakpoint_locations_match): Adjust comment.
1242         (bp_location_from_bp_type): New, factored out of...
1243         (bp_location::bp_location(breakpoint *)): ... this.
1244         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1245         factored out of...
1246         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1247         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1248         breakpoint_address_is_meaningful.
1249         (bp_locations_compare): Adjust comment.
1250         (update_global_location_list): Use bl_address_is_meaningful
1251         instead of breakpoint_address_is_meaningful.
1252         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1253         explicit.
1254         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1255         * python/py-breakpoint.c (bppy_get_location): No longer check
1256         whether location is null.
1257
1258 2019-07-09  Pedro Alves  <palves@redhat.com>
1259
1260         PR c++/15468
1261         * breakpoint.c (print_one_breakpoint_location): Remove
1262         single-location assert.
1263
1264 2019-07-09  Tom Tromey  <tom@tromey.com>
1265
1266         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1267         * configure: Rebuild.
1268         * configure.ac: Change common to gdbsupport.
1269         * gdbsupport: Rename from common.
1270         * acinclude.m4: Change common to gdbsupport.
1271         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1272         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1273         gdbsupport.
1274         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1275         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1276         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1277         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1278         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1279         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1280         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1281         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1282         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1283         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1284         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1285         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1286         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1287         coff-pe-read.c, command.h, compile/compile-c-support.c,
1288         compile/compile-c.h, compile/compile-cplus-symbols.c,
1289         compile/compile-cplus-types.c, compile/compile-cplus.h,
1290         compile/compile-loc2c.c, compile/compile.c, completer.c,
1291         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1292         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1293         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1294         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1295         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1296         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1297         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1298         features/aarch64-core.c, features/aarch64-fpu.c,
1299         features/aarch64-pauth.c, features/aarch64-sve.c,
1300         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1301         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1302         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1303         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1304         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1305         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1306         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1307         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1308         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1309         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1310         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1311         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1312         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1313         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1314         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1315         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1316         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1317         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1318         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1319         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1320         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1321         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1322         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1323         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1324         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1325         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1326         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1327         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1328         minsyms.c, mips-linux-tdep.c, namespace.h,
1329         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1330         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1331         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1332         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1333         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1334         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1335         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1336         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1337         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1338         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1339         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1340         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1341         procfs.c, producer.c, progspace.h, psymtab.h,
1342         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1343         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1344         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1345         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1346         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1347         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1348         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1349         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1350         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1351         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1352         target-memory.c, target.c, target.h, target/waitstatus.c,
1353         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1354         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1355         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1356         unittests/array-view-selftests.c,
1357         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1358         unittests/common-utils-selftests.c,
1359         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1360         unittests/format_pieces-selftests.c,
1361         unittests/function-view-selftests.c,
1362         unittests/lookup_name_info-selftests.c,
1363         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1364         unittests/mkdir-recursive-selftests.c,
1365         unittests/observable-selftests.c,
1366         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1367         unittests/parse-connection-spec-selftests.c,
1368         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1369         unittests/scoped_fd-selftests.c,
1370         unittests/scoped_mmap-selftests.c,
1371         unittests/scoped_restore-selftests.c,
1372         unittests/string_view-selftests.c, unittests/style-selftests.c,
1373         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1374         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1375         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1376         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1377         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1378         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1379
1380 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1381
1382         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1383         bool value.
1384         (decode_digits_ordinary): Set explicit_line field in sal.
1385         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1386         symtab_and_line that was set on an explicit line number in
1387         assembler code.  Do always update the recorded symtab and line if
1388         we do skip the prologue.
1389
1390 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1391
1392         * breakpoint.c (set_breakpoint_location_function): Remove
1393         explicit_loc parameter.
1394         (momentary_breakpoint_from_master): Update call to
1395         set_breakpoint_location_function.
1396         (add_location_to_breakpoint): Likewise.
1397
1398 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1399
1400         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1401         required features based on default bfd type when no specific bfd
1402         is present.
1403
1404 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1405
1406         * NEWS: Mention that GDB printf and eval commands can now print
1407         C-style and Ada-style convenience var strings without
1408         calling the inferior.
1409         * printcmd.c (printf_c_string): Locally print GDB internal var
1410         instead of transiting via the inferior.
1411         (printf_wide_c_string): Likewise.
1412
1413 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1414
1415         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1416
1417 2019-07-04  Tom Tromey  <tom@tromey.com>
1418
1419         PR tui/24724:
1420         * tui/tui-winsource.c (tui_clear_source_content): Update.
1421         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1422         (tui_update_breakpoint_info): Update.
1423         (tui_set_exec_info_content): Update.
1424         * tui/tui-source.c (tui_set_source_content_nil): Update.
1425         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1426         has_break.
1427         * tui/tui-data.h (enum tui_bp_flag): New.
1428         (tui_bp_flags): New enum flags type.
1429         (struct tui_source_element) <break_mode>: Change type.  Rename
1430         from has_break.
1431         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1432         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1433         constants.
1434         * tui/tui-winsource.h: Fix comment.
1435
1436 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1437
1438         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1439         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1440         (store_fpregs_to_thread)
1441         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1442         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1443         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1444         (IWMMXT_REGS_SIZE): Add define.
1445         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1446         (fetch_vfp_regs, store_vfp_regs)
1447         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1448         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1449
1450 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1451
1452         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1453         defines.
1454         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1455         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1456         (ARM_INT_REGISTER_SIZE): ...to this.
1457         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1458         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1459         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1460         (arm_linux_collect_gregset, supply_nwfpe_register)
1461         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1462         defines.
1463         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1464         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1465         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1466         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1467         (arm_return_in_memory, arm_store_return_value)
1468         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1469         (arm_record_ld_st_multiple): Likewise.
1470         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1471         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1472
1473 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1474
1475         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1476         AARCH64_DISPLACED_MODIFIED_INSNS.
1477         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1478         (aarch64_displaced_step_copy_insn): Likewise.
1479         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1480         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1481         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1482         ARM_DISPLACED_MODIFIED_INSNS.
1483         * arm-tdep.c (arm_gdbarch_init): Likewise.
1484         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1485         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1486         (struct arm_displaced_step_closure): Use
1487         ARM_DISPLACED_MODIFIED_INSNS.
1488
1489 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1490
1491         * features/Makefile: Remove unused xml files.
1492         * features/aarch64.xml: Remove.
1493         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1494         * features/i386/amd64-avx-avx512.xml: Remove.
1495         * features/i386/amd64-avx-linux.xml: Remove.
1496         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1497         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1498         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1499         * features/i386/amd64-avx-mpx.xml: Remove.
1500         * features/i386/amd64-avx.xml: Remove.
1501         * features/i386/amd64-linux.xml: Remove.
1502         * features/i386/amd64-mpx-linux.xml: Remove.
1503         * features/i386/amd64-mpx.xml: Remove.
1504         * features/i386/amd64.xml: Remove.
1505         * features/i386/i386-avx-avx512-linux.xml: Remove.
1506         * features/i386/i386-avx-avx512.xml: Remove.
1507         * features/i386/i386-avx-linux.xml: Remove.
1508         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1509         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1510         * features/i386/i386-avx-mpx-linux.xml: Remove.
1511         * features/i386/i386-avx-mpx.xml: Remove.
1512         * features/i386/i386-avx.xml: Remove.
1513         * features/i386/i386-linux.xml: Remove.
1514         * features/i386/i386-mmx-linux.xml: Remove.
1515         * features/i386/i386-mmx.xml: Remove.
1516         * features/i386/i386-mpx-linux.xml: Remove.
1517         * features/i386/i386-mpx.xml: Remove.
1518         * features/i386/i386.xml: Remove.
1519         * features/i386/x32-avx-avx512-linux.xml: Remove.
1520         * features/i386/x32-avx-linux.xml: Remove.
1521         * features/i386/x32-linux.xml: Remove.
1522
1523 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1524
1525         * regformats/aarch64.dat: Remove.
1526         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1527         * regformats/i386/amd64-avx-linux.dat: Remove.
1528         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1529         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1530         * regformats/i386/amd64-linux.dat: Remove.
1531         * regformats/i386/amd64-mpx-linux.dat: Remove.
1532         * regformats/i386/amd64.dat: Remove.
1533         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1534         * regformats/i386/i386-avx-linux.dat: Remove.
1535         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1536         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1537         * regformats/i386/i386-linux.dat: Remove.
1538         * regformats/i386/i386-mmx-linux.dat: Remove.
1539         * regformats/i386/i386-mpx-linux.dat: Remove.
1540         * regformats/i386/i386.dat: Remove.
1541         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1542         * regformats/i386/x32-avx-linux.dat: Remove.
1543         * regformats/i386/x32-linux.dat: Remove.
1544
1545 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1546
1547         * aarch64-tdep.c: Remove xml self tests.
1548         * amd64-linux-tdep.c: Likewise.
1549         * amd64-tdep.c: Likewise.
1550         * i386-linux-tdep.c: Likewise.
1551         * i386-tdep.c: Likewise.
1552
1553 2019-07-03  Pedro Alves  <palves@redhat.com>
1554
1555         PR cli/24732
1556         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1557         (pipe_cmd_option_defs): New.
1558         (make_pipe_cmd_options_def_group): New.
1559         (pipe_command): Use gdb::option::process_options.
1560         (pipe_command_completer): New function.
1561         (_initialize_cli_cmds): Install completer for "pipe" command.
1562
1563 2019-07-03  Pedro Alves  <palves@redhat.com>
1564
1565         * cli/cli-option.c (union option_value) <string>: New field.
1566         (struct option_def_and_value): Add ctor, move ctor, dtor and
1567         use DISABLE_COPY_AND_ASSIGN.
1568         (option_def_and_value::clear_value): New.
1569         (parse_option, save_option_value_in_ctx, get_val_type_str)
1570         (add_setshow_cmds_for_options): Handle var_string.
1571         * cli-option.h (union option_def::var_address) <string>: New
1572         field.
1573         (struct string_option_def): New.
1574         * maint-test-options.c (struct test_options_opts): Add default
1575         ctor and use DISABLE_COPY_AND_ASSIGN.
1576         <string_opt>: New field.
1577         (test_options_opts::~test_options_opts): New.
1578         (test_options_opts::dump): Also dump "-string".
1579         (test_options_option_defs): Install "string.
1580
1581 2019-07-03  Pedro Alves  <palves@redhat.com>
1582
1583         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1584         option_value with a null enumeration.
1585         (complete_options): Save the option values in the context.
1586         (save_option_value_in_ctx): New, factored out from ...
1587         (process_options): ... here.
1588         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1589         of the function.
1590         * maint-test-options.c (test_options_opts::dump): New, factored
1591         out from ...
1592         (maintenance_test_options_command_mode): ... here.
1593         (maintenance_test_options_command_completion_result): Delete.
1594         (maintenance_test_options_command_completion_text): Update
1595         comment.
1596         (maintenance_show_test_options_completion_result): Change
1597         prototype.  Just print
1598         maintenance_test_options_command_completion_text.
1599         (save_completion_result): New.
1600         (maintenance_test_options_completer_mode): Pass options context to
1601         complete_options, and then save a dump.
1602         (_initialize_maint_test_options): Use add_cmd to install "maint
1603         show test-options-completion-result".
1604
1605 2019-07-03  Pedro Alves  <palves@redhat.com>
1606
1607         * NEWS (New commands): Mention "with" and "maint with".
1608         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1609         (with_command, with_command_completer): New.
1610         (pipe_command): Adjust to new repeat_previous
1611         interface.
1612         (_initialize_cli_cmds): Install the "with" command and its "w"
1613         alias.
1614         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1615         declarations.
1616         * cli/cli-setshow.c (parse_cli_var_uinteger)
1617         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1618         argument strings for all var_types.
1619         (get_setshow_command_value_string): New, factored out from ...
1620         (do_show_command): ... this.
1621         * cli/cli-setshow.h: Include <string>.
1622         (get_setshow_command_value_string): Declare.
1623         * command.h (repeat_previous): Now returns const char *.  Adjust
1624         comment.
1625         * maint.c: Include "cli/cli-cmds.h".
1626         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1627         (_initialize_maint_cmds): Register the "maintenance with" command.
1628         * top.c (repeat_previous): Move bits from pipe_command here:
1629         Return the saved command line, if any; error out if there's no
1630         command to relaunch.
1631
1632 2019-07-03  Pedro Alves  <palves@redhat.com>
1633
1634         * NEWS (New commands): Mention "maint set/show test-settings"
1635         instead of "maint test-settings".
1636         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1637         (maintenance_test_settings_set_list): Rename to ...
1638         (maintenance_set_test_settings_list): ... this.
1639         (maintenance_test_settings_show_list): Rename to  ...
1640         (maintenance_show_test_settings_list): ... this.
1641         (maintenance_test_settings_cmd): Delete.
1642         (maintenance_test_settings_set_cmd): ...
1643         (maintenance_set_test_settings_cmd): ... this.
1644         (maintenance_test_settings_show_cmd): ...
1645         (maintenance_show_test_settings_cmd): ... this.
1646         (maintenance_test_settings_show_value_cmd):
1647         (maintenance_show_test_settings_value_cmd): ... this.
1648         (_initialize_maint_test_settings): No longer install the "maint
1649         test-settings" prefix command.  Rename "maint test-settings set"
1650         to "maint set test-settings", and "maint test-settings show" to
1651         "maint show test-settings".  Adjust all subcommands.
1652
1653 2019-07-03  Pedro Alves  <palves@redhat.com>
1654
1655         * maint-test-settings.c: Fix file's intro comment.  Replace all
1656         references to "test-options" with references to "test-settings",
1657         in comments.
1658
1659 2019-07-03  Pedro Alves  <palves@redhat.com>
1660
1661         * maint-test-settings.c (maintenance_test_settings_xxx)
1662         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1663         New.
1664         (maintenance_test_settings_enums): Use them.
1665         (maintenance_test_settings_enum): Default to
1666         maintenance_test_settings_xxx.
1667         (_initialize_maint_test_settings): Initialize
1668         MAINTENANCE_TEST_SETTINGS_FILENAME.
1669
1670 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1671
1672         * breakpoint.h (remove_breakpoints_inf): Change return type to
1673         void, move function documentation here.
1674         * breakpoint.c (remove_breakpoints_inf): Change return type to
1675         void, move function documentation to header.
1676
1677 2019-07-02  Pedro Alves  <palves@redhat.com>
1678
1679         * NEWS (Completion improvements): Mention "info threads".
1680         * thread.c (struct info_threads_opts, info_threads_option_defs)
1681         (make_info_threads_options_def_group): New.
1682         (info_threads_command): Use gdb::option::process_options.
1683         (info_threads_command_completer): New.
1684         (_initialize_thread): Use gdb::option::build_help to build the
1685         help text for "info threads".
1686
1687 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1688
1689         * defs.h (generic_load): Move from here...
1690         * symfile.h (generic_load): ... to here.  Rename name parameter
1691         to args.
1692         * symfile.c (generic_load): Add comment.
1693
1694 2019-07-01  Tom Tromey  <tromey@adacore.com>
1695
1696         * dwarf2read.c
1697         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1698         declaration of without_params.  Fix formatting.
1699
1700 2019-07-01  Tom Tromey  <tromey@adacore.com>
1701
1702         * ada-exp.y (find_primitive_type): Update.
1703         * ada-lang.h (ada_lookup_symbol): Update.
1704         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1705         parameter.
1706         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1707
1708 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1709
1710         PR breakpoints/24541
1711         * gdbarch.c: Regenerate.
1712         * gdbarch.h: Regenerate.
1713         * gdbarch.sh: Add 'stap_adjust_register'.
1714         * i386-tdep.c: Include '<unordered_set>'.
1715         (i386_stap_adjust_register): New function.
1716         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1717         * stap-probe.c (stap_parse_register_operand): Call
1718         'gdbarch_stap_adjust_register'.
1719
1720 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1721
1722         PR python/24742
1723         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1724         * python/python.c (do_start_initialization): Use 'xmalloc'
1725         instead of 'PyMem_Malloc'.
1726
1727 2019-06-28  Tom Tromey  <tromey@adacore.com>
1728
1729         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1730         for Ada.
1731
1732 2019-06-27  Tom Tromey  <tromey@adacore.com>
1733
1734         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1735         objfile_key.
1736         (arm_find_mapping_symbol, arm_record_special_symbol)
1737         (_initialize_arm_tdep): Update.
1738         (arm_objfile_data_free): Remove.
1739
1740 2019-06-27  Tom Tromey  <tromey@adacore.com>
1741
1742         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1743         to cp_print_static_field.
1744
1745 2019-06-26  Tom Tromey  <tromey@adacore.com>
1746
1747         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1748         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1749         declare.
1750
1751 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1752
1753         * features/aarch64-core.c (create_feature_aarch64_core):
1754         Regenerate.
1755         * features/aarch64-core.xml: Add cpsr flags.
1756
1757 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1758
1759         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1760         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1761
1762 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1763
1764         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1765         field.
1766         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1767         use.
1768         (arm_record_special_symbol): Don't insert new symbol in sorted
1769         position, push it at the end.
1770
1771 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1772
1773         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1774         (arm_mapping_symbol_s): Remove.
1775         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1776         (arm_mapping_symbol_vec): New typedef.
1777         (struct arm_per_objfile): Add constructor.
1778         <section_maps>: Change type to
1779         std::unique_ptr<arm_mapping_symbol_vec[]>.
1780         (arm_compare_mapping_symbols): Remove.
1781         (arm_find_mapping_symbol): Adjust to section_maps type change.
1782         (arm_objfile_data_free): Call delete on arm_per_objfile.
1783         (arm_record_special_symbol): Adjust to section_maps type change.
1784         Allocate arm_per_objfile with new.
1785
1786 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1787
1788         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1789         with the command prefix.
1790
1791 2019-06-25  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1794         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1795
1796 2019-06-25  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1799         type.
1800         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1801         protected.
1802
1803 2019-06-25  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-winsource.c
1806         (tui_source_window_base::set_is_exec_point_at): Add check against
1807         LOA_ADDRESS.
1808
1809 2019-06-25  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui-source.c (tui_set_source_content): Don't check before
1812         xfree.
1813         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1814
1815 2019-06-25  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-winsource.h (tui_update_source_window_as_is)
1818         (tui_alloc_source_buffer, tui_line_is_displayed)
1819         (tui_addr_is_displayed): Change type of win_info.
1820         * tui/tui-winsource.c (tui_update_source_window_as_is)
1821         (tui_clear_source_content, tui_show_source_line)
1822         (tui_show_source_content, tui_source_window_base::refill)
1823         (tui_source_window_base::set_is_exec_point_at)
1824         (tui_source_window_base::set_is_exec_point_at)
1825         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1826         (tui_alloc_source_buffer, tui_line_is_displayed)
1827         (tui_addr_is_displayed): Change type of win_info.  Update.
1828         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1829         (tui_source_window_base::do_make_visible_with_new_height):
1830         Update.
1831         * tui/tui-source.c (tui_set_source_content)
1832         (tui_set_source_content_nil)
1833         (tui_source_window::do_scroll_vertical): Update.
1834         * tui/tui-layout.c (show_layout): Update.
1835         * tui/tui-disasm.c (tui_set_disassem_content)
1836         (tui_disasm_window::do_scroll_vertical): Update.
1837         * tui/tui-data.h (tui_win_content): Remove.
1838         (struct tui_gen_win_info) <content, content_size>: Remove.
1839         (struct tui_source_element): Add initializers and destructor.
1840         (union tui_which_element, struct tui_win_element): Remove.
1841         (struct tui_source_window_base) <content>: New field.
1842         (struct tui_data_window): Remove destructor.
1843         (tui_alloc_content, tui_free_win_content)
1844         (tui_free_all_source_wins_content): Don't declare.
1845         * tui/tui-data.c (tui_initialize_static_data): Update.
1846         (init_content_element, tui_alloc_content): Remove.
1847         (~tui_gen_win_info): Update.
1848         (~tui_data_window, tui_free_all_source_wins_content)
1849         (tui_free_win_content, free_content, free_content_elements):
1850         Remove.
1851
1852 2019-06-25  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-winsource.h (tui_clear_source_content)
1855         (tui_erase_source_content, tui_show_source_content): Change type
1856         of win_info.
1857         * tui/tui-winsource.c (tui_clear_source_content)
1858         (tui_erase_source_content, tui_show_source_content): Change type
1859         of win_info.
1860         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1861         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1862         win_info.
1863         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1864         win_info.
1865         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1866
1867 2019-06-25  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui-winsource.c (tui_clear_source_content)
1870         (tui_source_window_base::set_is_exec_point_at): Update.
1871         * tui/tui-source.c (tui_set_source_content_nil): Update.
1872         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1873         a bool.
1874         * tui/tui-data.c (init_content_element): Update.
1875
1876 2019-06-25  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1879         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1880         * tui/tui-layout.c (init_and_make_win): Update.
1881         * tui/tui.h (enum tui_win_type): Update.
1882         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1883         tui_win_is_auxillary.
1884         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1885         tui_win_is_auxillary.
1886
1887 2019-06-25  Tom Tromey  <tom@tromey.com>
1888
1889         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1890         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1891         (tui_delete_data_content_windows, tui_display_all_data)
1892         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1893         Update.
1894         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1895         * tui/tui-regs.c (tui_last_regs_line_no)
1896         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1897         (tui_show_registers): Update.
1898         (tui_show_register_group): Return void.  Update.
1899         (tui_display_registers_from, tui_display_reg_element_at_line)
1900         (tui_display_registers_from_line, tui_check_register_values):
1901         Update.
1902         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1903         member.
1904         (struct tui_data_window) <regs_content>: Now a std::vector.
1905         <regs_content_count>: Remove.
1906         (tui_add_content_elements, tui_free_data_content): Don't declare.
1907         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1908         (init_content_element): Remove DATA_WIN case.  Add assert.
1909         (tui_add_content_elements): Remove.
1910         (tui_data_window): Update.
1911         (tui_free_data_content): Remove.
1912         (free_content_elements): Remove DATA_WIN case.
1913
1914 2019-06-25  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-data.c (tui_data_item_window): Update.
1917         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1918         * tui/tui-windata.c (tui_display_all_data)
1919         (tui_display_data_from_line): Update.
1920         (tui_check_data_values): Remove.
1921         * tui/tui-regs.c (tui_show_register_group)
1922         (tui_display_reg_element_at_line): Update.
1923         * tui/tui-hooks.c (tui_register_changed)
1924         (tui_refresh_frame_and_register_information): Call
1925         tui_check_register_values.
1926         * tui/tui-data.h (struct tui_data_window) <data_content,
1927         data_content_count, data_type>: Remove.
1928         (enum tui_data_type): Remove.
1929
1930         * tui/tui-data.c (tui_data_window::clear_detail)
1931         (~tui_data_window): Update.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1936         declare.
1937         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1938         Rename from tui_first_data_item_displayed.  Update.
1939         (tui_data_window::refresh_all)
1940         (tui_data_window::do_scroll_vertical): Update.
1941         * tui/tui-data.h (struct tui_data_window)
1942         <first_data_item_displayed>: Declare new method.
1943
1944 2019-06-25  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1947         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1948         contents...
1949         (tui_initialize_static_data): ...here.
1950
1951 2019-06-25  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1954         (tui_display_registers_from, tui_check_register_values): Update.
1955         (tui_display_register): Remove win_info parameter; update.
1956         (tui_get_register): Change type of parameters.
1957         * tui/tui-data.h (struct tui_data_element): Remove.
1958         (union tui_which_element) <data>: Remove.
1959         <data_window>: Change type.
1960         (struct tui_data_item_window): New.
1961         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1962         case.  Add assert.
1963         (~tui_data_item_window): New destructor.
1964         (free_content_elements): Remove DATA_ITEM_WIN case.
1965
1966 2019-06-25  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1969         Remove.
1970
1971 2019-06-25  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-data.h (struct tui_command_element): Remove.
1974         (union tui_which_element) <command>: Remove.
1975         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1976         assert.
1977         (free_content_elements): Remove CMD_WIN case.
1978
1979 2019-06-25  Tom Tromey  <tom@tromey.com>
1980
1981         * tui/tui-layout.c (tui_set_layout): Update.
1982         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1983         * tui/tui-data.c (layout_def): Update.
1984
1985 2019-06-25  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1988         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1989         (tui_source_window_base::set_new_height): Update.
1990         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1991         Update.
1992         (tui_set_locator_fullname, tui_set_locator_info)
1993         (tui_show_frame_info): Update.
1994         * tui/tui-source.c (tui_set_source_content)
1995         (tui_source_is_displayed): Update.
1996         * tui/tui-layout.c (show_source_disasm_command, show_data)
1997         (show_source_or_disasm_and_command): Update.
1998         * tui/tui-disasm.c (tui_set_disassem_content)
1999         (tui_get_begin_asm_address): Update.
2000         * tui/tui-data.h (struct tui_locator_element): Remove.
2001         (union tui_which_element) <locator>: Remove.
2002         (struct tui_locator_window): New.
2003         (tui_locator_win_info_ptr): Change return type.
2004         * tui/tui-data.c (_locator): Change type.
2005         (tui_locator_win_info_ptr): Change return type.
2006         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2007         (tui_alloc_content): Add assert.
2008
2009 2019-06-25  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-winsource.c
2012         (tui_exec_info_window::maybe_allocate_content): New method.
2013         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2014         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2015         (make_source_or_disasm_window): Add cast.
2016         * tui/tui-data.h (union tui_which_element) <simple_string>:
2017         Remove.
2018         (struct tui_source_info): New.
2019         (struct tui_source_window_base) <execution_info>: Change type.
2020         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2021         case, and add assert.
2022         (tui_alloc_content): Add assert.
2023
2024 2019-06-25  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2027         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2028         * tui/tui-data.c (tui_alloc_win_info): Remove.
2029
2030 2019-06-25  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2033         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2034         can_highlight.
2035
2036 2019-06-25  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2039         make_visible_with_new_height method.
2040         (tui_win_info::make_visible_with_new_height): New method.
2041         (tui_source_window_base::do_make_visible_with_new_height)
2042         (tui_data_window::do_make_visible_with_new_height)
2043         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2044         (make_visible_with_new_height): Remove.
2045         (tui_resize_all, tui_adjust_win_heights): Use
2046         make_visible_with_new_height method.
2047         * tui/tui-data.h (struct tui_win_info)
2048         <do_make_visible_with_new_height, make_visible_with_new_height>:
2049         New methods.
2050         (struct tui_source_window_base, struct tui_data_window)
2051         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2052         methods.
2053
2054 2019-06-25  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2057         method.
2058         (update_tab_width): Call update_tab_width method.
2059         * tui/tui-data.h (struct tui_win_info)
2060         (struct tui_source_window_base) <update_tab_width>: New methods.
2061
2062 2019-06-25  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2065         parameter.
2066         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2067         parameter.
2068         (tui_gen_win_info::make_visible): Update.
2069         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2070         parameter.
2071         * tui/tui-data.h (enum tui_box): New enum.
2072         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2073
2074 2019-06-25  Tom Tromey  <tom@tromey.com>
2075
2076         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2077         init_and_make_win for EXEC_INFO_WIN.
2078         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2079         longer inline.
2080         (struct tui_win_info) <~tui_win_info>: Inline.
2081         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2082         Don't declare.
2083         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2084         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2085         Remove.
2086         (tui_initialize_static_data): Update.
2087         (~tui_gen_win_info): Handle more cleanup here.
2088         (~tui_source_window_base): Delete "execution_info".
2089         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2090
2091 2019-06-25  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-layout.c (make_command_window): Don't set
2094         can_highlight.
2095         (show_source_disasm_command): Call the reset method.
2096         (show_data): Don't set can_highlight.  Call the reset method.
2097         (tui_gen_win_info::reset): Rename from init_gen_win_info
2098         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2099         (show_source_or_disasm_and_command): Call the reset method.
2100         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2101         (struct tui_cmd_window): Set can_highlight.
2102
2103 2019-06-25  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2106         from make_visible.
2107         (tui_make_visible, tui_make_invisible): Rewrite.
2108         (tui_win_info::make_visible): Remove.
2109         (tui_source_window_base::make_visible): Update.
2110         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2111         method.  Moved from...
2112         (struct tui_win_info) <make_visible>: ...here.
2113
2114 2019-06-25  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-winsource.c
2117         (tui_source_window_base::do_scroll_horizontal): Remove direction
2118         parameter.
2119         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2120         direction parameter.
2121         * tui/tui-win.c (tui_win_info::forward_scroll)
2122         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2123         (tui_win_info::right_scroll): Update.
2124         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2125         direction parameter.
2126         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2127         direction parameter.
2128         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2129         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2130         Remove direction parameter.
2131         (struct tui_source_window_base, struct tui_source_window)
2132         (struct tui_disasm_window, struct tui_data_window)
2133         (struct tui_cmd_window): Update.
2134
2135 2019-06-25  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-winsource.h (tui_set_exec_info_content)
2138         (tui_show_exec_info_content, tui_erase_exec_info_content)
2139         (tui_clear_exec_info_content, tui_update_exec_info): Change
2140         argument to tui_source_window_base.
2141         * tui/tui-winsource.c (tui_set_exec_info_content)
2142         (tui_show_exec_info_content, tui_erase_exec_info_content)
2143         (tui_clear_exec_info_content, tui_update_exec_info): Change
2144         argument to tui_source_window_base.
2145
2146 2019-06-25  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2149         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2150
2151 2019-06-25  Tom Tromey  <tom@tromey.com>
2152
2153         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2154         check.
2155
2156 2019-06-25  Tom Tromey  <tom@tromey.com>
2157
2158         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2159         type to void.
2160         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2161         type to void.
2162         * tui/tui-source.c (tui_set_source_content): Update.
2163         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2164
2165 2019-06-25  Tom Tromey  <tom@tromey.com>
2166
2167         * tui/tui-win.c (window_name_completer, tui_set_focus)
2168         (tui_all_windows_info): Use name method.
2169         * tui/tui-data.h (struct tui_gen_win_info)
2170         (struct tui_source_window, struct tui_disasm_window)
2171         (struct tui_data_window, struct tui_cmd_window) <name>: New
2172         method.
2173         (tui_win_name): Don't declare.
2174         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2175         (tui_win_name): Remove.
2176
2177 2019-06-25  Tom Tromey  <tom@tromey.com>
2178
2179         * tui/tui-winsource.h (tui_update_source_window)
2180         (tui_update_source_window_as_is): Change parameter type.
2181         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2182         to be a tui_source_window_base.
2183         (tui_update_source_window_as_is): Likewise.
2184         * tui/tui-win.c (make_visible_with_new_height): Update.
2185
2186 2019-06-25  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-winsource.c (tui_erase_source_content)
2189         (tui_show_source_content, tui_show_exec_info_content)
2190         (tui_erase_exec_info_content): Use refresh_window method.
2191         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2192         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2193         from tui_refresh_win.
2194         (tui_data_window::refresh_window): New method.
2195         (tui_win_info::refresh, tui_source_window_base::refresh)
2196         (tui_refresh_all): Use refresh_window method.
2197         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2198         method.
2199         * tui/tui-regs.c (tui_display_register): Call refresh_window
2200         method.
2201         * tui/tui-layout.c (show_source_disasm_command)
2202         (show_source_or_disasm_and_command): Call refresh_window method.
2203         * tui/tui-data.h (struct tui_gen_win_info)
2204         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2205         New method.
2206
2207 2019-06-25  Tom Tromey  <tom@tromey.com>
2208
2209         * tui/tui.c (tui_rl_other_window, tui_enable)
2210         (tui_is_window_visible, tui_get_command_dimension): Update.
2211         * tui/tui-winsource.c (tui_update_source_window_as_is)
2212         (tui_clear_source_content, tui_erase_source_content)
2213         (tui_show_source_line, tui_source_window_base::refill)
2214         (tui_source_window_base::do_scroll_horizontal)
2215         (tui_source_window_base::set_is_exec_point_at)
2216         (tui_update_breakpoint_info, tui_set_exec_info_content)
2217         (tui_alloc_source_buffer, tui_line_is_displayed)
2218         (tui_addr_is_displayed): Update.
2219         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2220         (tui_check_and_display_highlight_if_needed)
2221         (tui_win_info::make_visible, tui_win_info::refresh)
2222         (tui_refresh_all): Update.
2223         * tui/tui-windata.c (tui_first_data_item_displayed)
2224         (tui_delete_data_content_windows, tui_erase_data_content)
2225         (tui_display_all_data, tui_data_window::refresh_all)
2226         (tui_check_data_values): Update.
2227         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2228         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2229         (tui_win_info::backward_scroll, tui_refresh_all_win)
2230         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2231         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2232         (tui_source_window_base::set_new_height)
2233         (tui_data_window::set_new_height)
2234         (make_invisible_and_set_new_height)
2235         (make_visible_with_new_height, new_height_ok)
2236         (parse_scrolling_args): Update.
2237         * tui/tui-stack.c (tui_show_frame_info): Update.
2238         * tui/tui-source.c (tui_set_source_content)
2239         (tui_set_source_content_nil, tui_source_is_displayed)
2240         (tui_source_window::do_scroll_vertical): Update.
2241         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2242         (tui_display_registers_from, tui_display_reg_element_at_line)
2243         (tui_check_register_values, tui_reg_command): Update.
2244         * tui/tui-layout.c (tui_default_win_height)
2245         (show_source_disasm_command, show_data, init_and_make_win)
2246         (show_source_or_disasm_and_command): Update.
2247         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2248         (tui_redisplay_readline, tui_mld_flush)
2249         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2250         (tui_getc): Update.
2251         * tui/tui-disasm.c (tui_set_disassem_content)
2252         (tui_disasm_window::do_scroll_vertical): Update.
2253         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2254         Now virtual.
2255         (struct tui_win_info): Derive from tui_gen_win_info.
2256         <~tui_win_info>: Mark as override.
2257         <generic>: Remove member.
2258         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2259         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2260         (~tui_data_window, ~tui_win_info)
2261         (tui_free_all_source_wins_content): Update.
2262         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2263
2264 2019-06-25  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-layout.c (init_and_make_win): Use new.
2267         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2268         destructor, initializers.
2269         (tui_alloc_generic_win_info): Don't declare.
2270         * tui/tui-data.c (_locator): Add argument to constructor.
2271         (source_win, disasm_win): New globals.
2272         (exec_info): Remove.
2273         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2274         Update.
2275         (tui_alloc_generic_win_info): Remove.
2276         (init_content_element): Use new.
2277         (tui_win_info::tui_win_info): Update.
2278         (free_content_elements) <case DATA_WIN>: Use delete.
2279
2280 2019-06-25  Tom Tromey  <tom@tromey.com>
2281
2282         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2283         * tui/tui-windata.c (tui_first_data_item_displayed)
2284         (tui_delete_data_content_windows): Update.
2285         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2286         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2287         (tui_display_registers_from, tui_check_register_values): Update.
2288         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2289         pointer.
2290         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2291         window.
2292         (tui_free_data_content): Update.
2293         (free_content_elements) <case DATA_WIN>: Free the window.
2294
2295 2019-06-25  Tom Tromey  <tom@tromey.com>
2296
2297         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2298         Update.
2299         * tui/tui-layout.c (make_command_window)
2300         (show_source_disasm_command, show_data, init_and_make_win)
2301         (show_source_or_disasm_and_command): Update.
2302         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2303         method.
2304         <can_highight, is_highlighted>: Now bool.
2305         (tui_set_win_highlight): Don't declare.
2306         * tui/tui-data.c (tui_set_win_highlight): Remove.
2307
2308 2019-06-25  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-wingeneral.c (make_visible): Remove check of window
2311         type.
2312
2313 2019-06-25  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-win.c (tui_win_info::max_height)
2316         (tui_cmd_window::max_height): New methods.
2317         (new_height_ok): Call max_height.
2318         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2319         <max_height>: New method.
2320
2321 2019-06-25  Tom Tromey  <tom@tromey.com>
2322
2323         * tui/tui-win.c (tui_source_window_base::set_new_height)
2324         (tui_data_window::set_new_height): New methods.
2325         (make_invisible_and_set_new_height): Call set_new_height method.
2326         * tui/tui-data.h (struct tui_win_info)
2327         (struct tui_source_window_base, struct tui_data_window)
2328         <set_new_height>: New method.
2329
2330 2019-06-25  Tom Tromey  <tom@tromey.com>
2331
2332         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2333         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2334         tui_refresh_data_win.
2335         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2336         method.
2337         (tui_refresh_all_win): Call the refresh_all method.
2338         (tui_set_focus): Likewise.
2339         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2340         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2341         Likewise.
2342
2343 2019-06-25  Tom Tromey  <tom@tromey.com>
2344
2345         * tui/tui-winsource.h (tui_refill_source_window)
2346         (tui_set_is_exec_point_at): Don't declare.
2347         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2348         (tui_source_window_base::refill): Rename from
2349         tui_refill_source_window.
2350         (tui_source_window_base::do_scroll_horizontal): Update.
2351         (tui_source_window_base::set_is_exec_point_at): Rename from
2352         tui_set_is_exec_point_at.
2353         (tui_update_all_breakpoint_info): Update.
2354         * tui/tui-stack.c (tui_show_frame_info): Update.
2355         * tui/tui-layout.c (show_data): Add cast.
2356         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2357         * tui/tui-data.h (struct tui_source_window_base) <refill,
2358         set_is_exec_point_at>: New methods.
2359         (tui_source_windows, tui_add_to_source_windows): Update types.
2360         (tui_add_to_source_windows): Remove redundant declaration.
2361         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2362         (tui_source_windows): Change return type.
2363         (tui_clear_source_windows_detail): Update.
2364         (tui_add_to_source_windows): Change type of parameter.
2365         (tui_free_all_source_wins_content): Update.
2366
2367 2019-06-25  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-wingeneral.c (tui_win_info::refresh)
2370         (tui_source_window_base::refresh): New methods.
2371         (tui_refresh_all): Call the refresh method.
2372         * tui/tui-data.h (struct tui_win_info)
2373         (struct tui_source_window_base) <refresh>: New method.
2374
2375 2019-06-25  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui.h (tui_is_window_visible): Return bool.
2378         * tui/tui.c (tui_is_window_visible): Return bool.
2379         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2380         (tui_make_visible, tui_make_invisible)
2381         (tui_win_info::make_visible)
2382         (tui_source_window_base::make_visible, make_all_visible)
2383         (tui_make_all_visible, tui_make_all_invisible): Update.
2384         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2385         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2386         bool.
2387         (struct tui_win_info, struct tui_source_window_base)
2388         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2389         * tui/tui-data.c (tui_init_generic_part): Update.
2390
2391 2019-06-25  Tom Tromey  <tom@tromey.com>
2392
2393         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2394         (tui_source_window_base::make_visible): New methods.
2395         (make_all_visible): Make method call.
2396         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2397         (struct tui_source_window_base, struct tui_cmd_window): Override
2398         make_visible.
2399         (tui_win_is_source_type): Don't declare.
2400         * tui/tui-data.c (tui_win_is_source_type): Remove.
2401
2402 2019-06-25  Tom Tromey  <tom@tromey.com>
2403
2404         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2405         NULL check.
2406
2407 2019-06-25  Tom Tromey  <tom@tromey.com>
2408
2409         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2410         Inline constructor.  Add initializers for members.
2411         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2412         constructors; now inline in class.
2413
2414 2019-06-25  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui-regs.c (tui_show_registers): Update.
2417         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2418         bool.
2419         * tui/tui-data.c (tui_data_window::clear_detail)
2420         (tui_data_window): Update.
2421
2422 2019-06-25  Tom Tromey  <tom@tromey.com>
2423
2424         * tui/tui-windata.c (tui_display_all_data)
2425         (tui_display_data_from_line, tui_display_data_from)
2426         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2427         Update.
2428         * tui/tui-regs.c (tui_last_regs_line_no)
2429         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2430         (tui_show_registers, tui_show_register_group)
2431         (tui_display_registers_from, tui_display_reg_element_at_line)
2432         (tui_display_registers_from_line, tui_check_register_values)
2433         (tui_reg_next, tui_reg_prev): Update.
2434         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2435         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2436         tui_data_window.
2437         (struct tui_win_info) <detail>: Remove.  Add new fields from
2438         tui_data_info.
2439         (TUI_DATA_WIN): Add cast.
2440         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2441         (~tui_data_window): Simplify.
2442
2443 2019-06-25  Tom Tromey  <tom@tromey.com>
2444
2445         * tui/tui-layout.c (show_source_disasm_command)
2446         (show_source_or_disasm_and_command): Update.
2447         * tui/tui-io.c (update_cmdwin_start_line)
2448         (tui_redisplay_readline): Update.
2449         * tui/tui-data.h (struct tui_command_info): Remove.
2450         (struct tui_win_info) <detail>: Remove command_info member.
2451         (struct tui_data_window) <start_line>: New member, from
2452         tui_command_info.
2453         (TUI_CMD_WIN): Add casts.
2454
2455 2019-06-25  Tom Tromey  <tom@tromey.com>
2456
2457         * tui/tui-winsource.c (tui_update_source_window)
2458         (tui_refill_source_window)
2459         (tui_source_window_base::do_scroll_horizontal)
2460         (tui_update_breakpoint_info, tui_set_exec_info_content)
2461         (tui_show_exec_info_content, tui_erase_exec_info_content)
2462         (tui_clear_exec_info_content): Update.
2463         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2464         Update.
2465         * tui/tui-win.c (make_invisible_and_set_new_height)
2466         (make_visible_with_new_height): Update.
2467         * tui/tui-source.c (tui_set_source_content)
2468         (tui_show_symtab_source): Update.
2469         * tui/tui-layout.c (extract_display_start_addr)
2470         (show_source_disasm_command, show_data)
2471         (make_source_or_disasm_window)
2472         (show_source_or_disasm_and_command): Update.
2473         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2474         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2475         "gdbarch".
2476         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2477         to tui_source_window_base.
2478         (struct tui_win_info) <detail>: Remove source_info member.
2479         (struct tui_source_window_base) <has_locator>: Inline.
2480         Move contents from tui_source_info; rename has_locator member to
2481         m_has_locator.
2482         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2483         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2484         header file.
2485         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2486         Simplify.
2487         (tui_free_all_source_wins_content): Cast to
2488         tui_source_window_base.
2489
2490 2019-06-25  Tom Tromey  <tom@tromey.com>
2491
2492         * tui/tui-win.c (make_invisible_and_set_new_height)
2493         (make_visible_with_new_height): Call has_locator method.
2494         * tui/tui-layout.c (show_source_disasm_command, show_data)
2495         (show_source_or_disasm_and_command): Update for bool change.
2496         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2497         (tui_win_info) <has_locator>: New method.
2498         (struct tui_source_window_base) <has_locator>: New method.
2499         (tui_win_has_locator): Don't declare.
2500         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2501         from tui_win_has_locator.
2502         (tui_source_window_base): Use false, not FALSE.
2503
2504 2019-06-25  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2507         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2508         clear_detail method directly.
2509         (tui_clear_win_detail): Remove.
2510
2511 2019-06-25  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2514         "this", not TUI_DISASM_WIN.
2515
2516 2019-06-25  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2519         declare.
2520         * tui/tui-winsource.c
2521         (tui_source_window_base::do_scroll_horizontal): Rename from
2522         tui_horizontal_source_scroll.
2523         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2524         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2525         from tui_vertical_data_scroll.
2526         * tui/tui-win.h (tui_scroll): Don't declare.
2527         * tui/tui-win.c (tui_win_info::forward_scroll)
2528         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2529         (tui_win_info::right_scroll): Rename and update.
2530         (tui_scroll_forward_command, tui_scroll_backward_command)
2531         (tui_scroll_left_command, tui_scroll_right_command): Update.
2532         (tui_scroll): Remove.
2533         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2534         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2535         from tui_vertical_source_scroll.
2536         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2537         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2538         from tui_vertical_disassem_scroll.
2539         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2540         do_scroll_horizontal>: New methods.
2541         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2542         Likewise.
2543         (struct tui_source_window_base): Add do_scroll_horizontal.
2544         (struct tui_source_window, struct tui_disasm_window): Add
2545         do_scroll_vertical.
2546         (struct tui_data_window, struct tui_cmd_window): Add
2547         do_scroll_horizontal and do_scroll_vertical.
2548         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2549
2550 2019-06-25  Tom Tromey  <tom@tromey.com>
2551
2552         * tui/tui-data.h (struct tui_source_window_base): New struct.
2553         (struct tui_source_window): Derive from tui_source_window_base.
2554         (struct tui_disasm_window): New struct.
2555         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2556         from tui_source_window::clear_detail.
2557         (tui_source_window_base): Rename from tui_source_window.
2558         (~tui_source_window_base): Rename from ~tui_source_window.
2559         (tui_alloc_win_info): Create a tui_disasm_window.
2560
2561 2019-06-25  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-data.h (struct tui_source_window)
2564         (struct tui_data_window): Declare destructors.
2565         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2566         destructors.
2567         (tui_win_info): Simplify.
2568
2569 2019-06-25  Tom Tromey  <tom@tromey.com>
2570
2571         * tui/tui-winsource.c (tui_display_main)
2572         (tui_update_source_windows_with_addr)
2573         (tui_update_all_breakpoint_info): Update.
2574         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2575         (new_height_ok, parse_scrolling_args): Update.
2576         * tui/tui-stack.c (tui_show_frame_info): Update.
2577         * tui/tui-data.h (struct tui_list): Remove.
2578         (tui_source_windows): Return a reference to a std::vector.
2579         * tui/tui-data.c (source_windows): Now a std::vector.
2580         (tui_source_windows): Change return type.
2581         (tui_clear_source_windows): Rewrite.
2582         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2583         (tui_free_all_source_wins_content): Rewrite.
2584
2585 2019-06-25  Tom Tromey  <tom@tromey.com>
2586
2587         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2588         (struct tui_data_window, struct tui_cmd_window): Declare
2589         clear_detail method.
2590         * tui/tui-data.c (tui_source_window::clear_detail)
2591         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2592         methods.
2593         (tui_clear_win_detail): Simplify.
2594
2595 2019-06-25  Tom Tromey  <tom@tromey.com>
2596
2597         * tui/tui-layout.c (make_source_window, make_disasm_window)
2598         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2599         Return the new window.
2600         (show_source_disasm_command, show_data)
2601         (show_source_or_disasm_and_command): Update.
2602
2603 2019-06-25  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2606         parameter.  Return the new window.
2607         (show_source_disasm_command): Update and remove NULL check.
2608         (show_source_or_disasm_and_command): Update.
2609
2610 2019-06-25  Tom Tromey  <tom@tromey.com>
2611
2612         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2613
2614 2019-06-25  Tom Tromey  <tom@tromey.com>
2615
2616         * tui/tui-data.h (struct tui_win_info): Make constructor
2617         protected.  Make destructor virtual.  Add initializers.
2618         (tui_source_window, tui_data_window, tui_cmd_window): New
2619         classes.
2620         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2621         constructor.  Add "type" parameter.
2622         (tui_source_window, tui_data_window, tui_cmd_window): New
2623         constructors.
2624         (tui_alloc_win_info): Instantiate the appropriate subclass.
2625
2626 2019-06-25  Tom Tromey  <tom@tromey.com>
2627
2628         * tui/tui-win.c (tui_resize_all): Use delete.
2629         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2630         destructor.
2631         (tui_free_window): Don't declare.
2632         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2633         Update.
2634
2635 2019-06-25  Tom Tromey  <tom@tromey.com>
2636
2637         * tui/tui-data.h (struct tui_win_info): Add constructor.
2638         * tui/tui-data.c (tui_alloc_win_info): Use new.
2639         (tui_free_window): Use delete.
2640
2641 2019-06-22  Tom Tromey  <tom@tromey.com>
2642
2643         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2644         declare.
2645         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2646
2647 2019-06-22  Tom Tromey  <tom@tromey.com>
2648
2649         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2650         declare.
2651         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2652
2653 2019-06-22  Tom de Vries  <tdevries@suse.de>
2654
2655         * dwarf2read.c (create_addrmap_from_aranges)
2656         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2657         instead of '%zu'.
2658
2659 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2660
2661         * dwarf2read.h (dwarf2_section_info_def): Remove.
2662         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2663         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2664         std::vector<dwarf2_section_info>.
2665         (struct dwo_file) <~dwo_file>: Remove.
2666         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2667         types field.
2668         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2669         (dwarf2_read_debug_names): Likewise.
2670         (create_debug_types_hash_table): Change parameter type to
2671         array_view, adjust code accordingly.
2672         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2673         (partial_die_info::fixup): Likewise.
2674         (determine_prefix): Likewise.
2675         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2676
2677 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2678
2679         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2680         gdb_bfd_ref_ptr.
2681         <~dwo_file>: Remove call to gdb_bfd_unref.
2682         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2683         gdb_bfd_ref_ptr::get.
2684
2685 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2686
2687         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2688         type to htab_up.
2689         * dwarf2read.c (struct dwo_file): Initialize fields.
2690         <~dwo_file>: New.
2691         (free_dwo_file): Remove, move content to ~dwo_file.
2692         (struct dwo_file_deleter): Remove.
2693         (dwo_file_up>: Remove custom deleter.
2694         (free_dwo_files): Remove.
2695         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2696         dwo_files.
2697         (process_skeletonless_type_units): Call unique_ptr::get.
2698         (allocate_dwo_file_hash_table): Add deleter to created hash
2699         table.  Change return type to htab_up.
2700         (lookup_dwo_file_slot): Don't memset dwo_file, call
2701         unique_ptr::get.
2702         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2703         (create_dwo_unit_in_dwp_v2): Likewise.
2704         (open_and_init_dwo_file): Likewise.
2705         (free_dwo_file_from_slot): Remove.
2706
2707 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2708
2709         * dwarf2read.h (struct dwarf2_section_info) <readin,
2710         is_virtual>: Change type to bool.
2711         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2712         true instead of 1.
2713
2714 2019-06-19  Tom Tromey  <tom@tromey.com>
2715
2716         * tui/tui-data.h (tui_init_content_element): Don't declare.
2717
2718 2019-06-19  Tom Tromey  <tom@tromey.com>
2719
2720         * tui/tui-data.h (tui_init_win_info): Don't declare.
2721
2722 2019-06-19  Tom de Vries  <tdevries@suse.de>
2723
2724         * dwarf2read.h (abstract_to_concrete): Change type to
2725         std::unordered_map<sect_offset, std::vector<sect_offset>,
2726         gdb::hash_enum<sect_offset>>.
2727
2728 2019-06-19  Tom Tromey  <tromey@adacore.com>
2729
2730         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2731         EVAL_AVOID_SIDE_EFFECTS specially.
2732
2733 2019-06-19  Tom Tromey  <tromey@adacore.com>
2734
2735         * source-cache.c (highlighter): New global.
2736         (source_cache::get_source_lines): Create a highlighter on demand.
2737
2738 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2739
2740         * defs.h (deprecated_interactive_hook): Delete declaration.
2741         * interps.c (clear_interpreter_hooks): Remove use of
2742         deprecated_interactive_hook.
2743         * top.c (deprecated_interactive_hook): Delete definition.
2744         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2745
2746 2019-06-18  Tom de Vries  <tdevries@suse.de>
2747
2748         PR gdb/24515
2749         * dwarf2read.h (abstract_to_concrete): Change type from
2750         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2751         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2752         * dwarf2read.c (read_variable): Update.
2753         (dwarf2_fetch_die_loc_sect_off): Update.
2754
2755 2019-06-17  Tom de Vries  <tdevries@suse.de>
2756
2757         PR gdb/24617
2758         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2759         accessing parent[parent_len - 1].
2760
2761 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2762
2763         PR gdb/24364
2764         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2765         call dtrace_process_dof with NULL dof.
2766
2767 2019-06-16  Tom de Vries  <tdevries@suse.de>
2768
2769         PR gdb/24445
2770         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2771
2772 2019-06-16  Tom Tromey  <tom@tromey.com>
2773
2774         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2775         (make_all_visible): Use address of member.
2776
2777 2019-06-16  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2780         (tui_free_window, free_content, free_content_elements): Remove
2781         unnecessary cast.
2782         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2783         cast.
2784         * tui/tui-regs.c (tui_show_register_group)
2785         (tui_display_registers_from, tui_display_reg_element_at_line):
2786         Remove unnecessary cast.
2787
2788 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2789
2790         * linux-nat.c (normal_mask): Delete.
2791         (_initialize_linux_nat): Don't initialise normal_mask.
2792
2793 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2794
2795         PR gdb/24445
2796         * dwarf-index-write.h (write_psymtabs_to_index): Add
2797         dwz_basename parameter.
2798         * dwarf-index-write.c (write_gdbindex): Move file writing to
2799         write_gdbindex_1.  Change return type void.
2800         (assert_file_size): Move up, remove filename parameter.
2801         (write_gdbindex_1): New function.
2802         (write_debug_names): Change return type to void, call
2803         assert_file_size.
2804         (struct index_wip_file): New struct.
2805         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2806         file logic to index_wip_file.  Write index for dwz file if
2807         needed.
2808         (save_gdb_index_command): Pass basename of dwz file, if present.
2809         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2810         build-id of dwz file, if present.
2811         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2812         (dwarf2_get_dwz_file): Likewise.
2813         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2814         (dwarf2_get_dwz_file): Likewise.
2815
2816 2019-06-16  Tom Tromey  <tom@tromey.com>
2817
2818         * coffread.c (process_coff_symbol): Use xstrdup.
2819         * value.c (create_internalvar): Use xstrdup.
2820
2821 2019-06-16  Tom Tromey  <tom@tromey.com>
2822
2823         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2824         * breakpoint.c (stopin_command, stopat_command)
2825         (until_break_command, decode_location_default): Remove unnecessary
2826         cast.
2827         * utils.c (subset_compare): Remove unnecessary cast.
2828         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2829         cast.
2830         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2831         cast.
2832         * infcmd.c (path_command): Remove unnecessary cast.
2833         * coffread.c (decode_type): Remove unnecessary cast.
2834         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2835         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2836         * tui/tui-stack.c (tui_show_locator_content)
2837         (tui_show_frame_info): Remove unnecessary cast.
2838         * tui/tui-win.c (tui_scroll_forward_command)
2839         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2840         (parse_scrolling_args): Remove unnecessary cast.
2841         * tui/tui-data.c (init_win_info, tui_del_window)
2842         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2843         (free_content_elements): Remove unnecessary cast.
2844         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2845         unnecessary cast.
2846         * tui/tui-source.c (tui_set_source_content)
2847         (tui_vertical_source_scroll): Remove unnecessary cast.
2848         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2849         cast.
2850         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2851         * tui/tui-regs.c (tui_display_registers_from)
2852         (tui_display_register): Remove unnecessary cast.
2853         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2854         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2855         (make_visible): Remove unnecessary cast.
2856         * tui/tui-winsource.c (tui_erase_source_content)
2857         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2858         unnecessary cast.
2859         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2860         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2861         * stabsread.c (read_type, read_array_type, read_range_type):
2862         Remove unnecessary cast.
2863         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2864         (parse_symbol, parse_type, upgrade_type, parse_external)
2865         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2866         unnecessary cast.
2867         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2868
2869 2019-06-16  Tom Tromey  <tom@tromey.com>
2870
2871         * tui/tui-data.c (tui_alloc_generic_win_info)
2872         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2873         checks.
2874
2875 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2876             Andrew Burgess  <andrew.burgess@embecosm.com>
2877
2878         * f-typeprint.c (f_print_type): Don't return early for not
2879         associated or not allocated types.
2880         (f_type_print_varspec_suffix): Add print_rank parameter and print
2881         ranks of array types in case they dangling.
2882         (f_type_print_base): Add print_rank parameter.
2883
2884 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * NEWS: Mention new MI commands.
2887         * break-catch-throw.c (enum exception_event_kind): Move to
2888         breakpoint.h.
2889         (print_mention_exception_catchpoint): Output text as a single
2890         message.
2891         (catch_exception_command_1): Rename to...
2892         (catch_exception_event): ...this, make non-static, update header
2893         command, and change some parameter types.
2894         (catch_catch_command): Update for changes to
2895         catch_exception_command_1.
2896         (catch_throw_command): Likewise.
2897         (catch_rethrow_command): Likewise.
2898         * breakpoint.c (enum exception_event_kind): Delete.
2899         * breakpoint.h (enum exception_event_kind): Moved here from
2900         break-catch-throw.c.
2901         (catch_exception_event): Declare.
2902         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2903         (mi_cmd_catch_throw): New function.
2904         (mi_cmd_catch_rethrow): New function.
2905         (mi_cmd_catch_catch): New function.
2906         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2907         'catch-catch' entries.
2908         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2909         (mi_cmd_catch_rethrow): Declare.
2910         (mi_cmd_catch_catch): Declare.
2911
2912 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2913
2914         * annotate.c (annotate_source_line): Change return type to void,
2915         update implementation to match.
2916         * annotate.h (annotate_source_line): Change return type to void,
2917         update header comment.
2918         * stack.c (print_frame_info): Don't change what frame information
2919         is printed based on whether annotations are on or not.
2920
2921 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2922
2923         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2924         (annotate_source): Make static.
2925         (annotate_source_line): Moved from source.c and renamed from
2926         identify_source_line.  Update the return type.
2927         * annotate.h (annotate_source): Delete declaration.
2928         (annotate_source_line): Declaration moved from source.h, and
2929         renamed from identify_source_line.  Return type updated.
2930         * source.c (identify_source_line): Moved to annotate.c and renamed
2931         to annotate_source_line.
2932         (info_line_command): Remove check of annotation_level.
2933         * source.h (identify_source_line): Move declaration to annotate.h
2934         and rename to annotate_source_line.
2935         * stack.c: Add 'annotate.h' include.
2936         (print_frame_info): Remove check of annotation_level before
2937         calling annotate_source_line.
2938
2939 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2940
2941         * source-cache.c (source_cache::get_plain_source_lines): Use
2942         open_source_file_with_line_charpos instead of just
2943         open_source_file, remove call to find_source_lines.
2944         (source_cache::get_source_lines): Likewise.
2945         * source.c (find_source_lines): Make static.
2946         (get_filename_and_charpos): Renamed into...
2947         (open_source_file_with_line_charpos): ..this along with changes to
2948         return a scoped_fd, and some other minor clean ups.
2949         (identify_source_line): Use open_source_file_with_line_charpos.
2950         (search_command_helper): Use open_source_file_with_line_charpos
2951         instead of just open_source_file, remove call to
2952         find_source_lines.
2953         * source.h (open_source_file_with_line_charpos): Declare new
2954         function.
2955         (find_source_lines): Delete declaration.
2956
2957 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2958
2959         * source.c (get_filename_and_charpos): Remove fullname
2960         parameter.
2961         (identify_source_line): Update call to get_filename_and_charpos.
2962
2963 2019-06-14  Tom Tromey  <tromey@adacore.com>
2964
2965         PR gdb/24502:
2966         * ui-style.h (skip_ansi_escape): Update comment.
2967         * ui-file.h (class no_terminal_escape_file): New class.
2968         * ui-file.c (no_terminal_escape_file::write)
2969         (no_terminal_escape_file::puts): New methods.
2970         * cli/cli-logging.c (handle_redirections): Use
2971         no_terminal_escape_file.
2972
2973 2019-06-14  Tom Tromey  <tromey@adacore.com>
2974
2975         * NEWS: Move convenience variable news above Python news.
2976
2977 2019-06-14  Tom Tromey  <tom@tromey.com>
2978
2979         * gnulib: Move directory to top-level.
2980         * configure.ac: Don't configure gnulib.
2981         * configure: Rebuild.
2982         * common/common-defs.h: Use new path to gnulib.
2983         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2984         (GNULIB_H): Remove.
2985         (INCGNU): Look in new gnulib location.
2986         (HFILES_NO_SRCDIR): Remove gnulib files.
2987         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2988         (generated_files): Remove GNULIB_H.
2989         ($(LIBGNU), all-lib): Remove targets.
2990         (distclean): Don't mention GNULIB_BUILDDIR.
2991         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2992
2993 2019-06-14  Tom Tromey  <tromey@adacore.com>
2994
2995         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2996         Warn if symbol file does not provide any symbols.
2997
2998 2019-06-14  Tom Tromey  <tromey@adacore.com>
2999
3000         * source.c (find_and_open_source): Respect basenames_may_differ.
3001
3002 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3003
3004         * annotate.c (annotate_breakpoints_invalid): Make use of
3005         scoped_restore_terminal_state.
3006         (annotate_frames_invalid): Likewise.
3007
3008 2019-06-14  Tom Tromey  <tromey@adacore.com>
3009
3010         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3011         allow assignment to an internalvar.
3012
3013 2019-06-14  Tom Tromey  <tromey@adacore.com>
3014
3015         * ada-lex.l: Allow "_" in attribute names.
3016
3017 2019-06-14  Tom Tromey  <tromey@adacore.com>
3018
3019         PR gdb/24653:
3020         * regcache.c (registers_changed): Don't call alloca.
3021         * top.c (execute_command): Don't call alloca.
3022
3023 2019-06-13  Pedro Alves  <palves@redhat.com>
3024
3025         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3026         'expression'.  When parsing an expression, error out if there's
3027         junk after "unlimited".
3028         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3029         (do_set_command): Adjust calls to is_unlimited_literal.
3030
3031 2019-06-13  Pedro Alves  <palves@redhat.com>
3032
3033         * compile/compile.c (make_compile_options_def_group): Add braces
3034         around array_view initializer.
3035         * thread.c (make_thread_apply_all_options_def_group)
3036         (make_thread_apply_all_options_def_group): Likewise.
3037
3038 2019-06-13  Pedro Alves  <palves@redhat.com>
3039
3040         * NEWS (New commands): Mention "maint test-options
3041         require-delimiter", "maint test-options unknown-is-error", "maint
3042         test-options unknown-is-operand" and "maint show
3043         test-options-completion-result".
3044         (New command options, command completion): New section.
3045         (Completion improvements): New section.
3046         Mention that you can abbreviate "unlimited".
3047
3048 2019-06-13  Pedro Alves  <palves@redhat.com>
3049
3050         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3051         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3052         * unittests/cli-utils-selftests.c (test_parse_flags)
3053         (test_parse_flags_qcs): Delete.
3054         (test_cli_utils): Don't call deleted functions.
3055
3056 2019-06-13  Pedro Alves  <palves@redhat.com>
3057
3058         * thread.c: Include "cli/cli-option.h".
3059         (tp_array_compar_ascending): Global.
3060         (tp_array_compar): Delete function.
3061         (tp_array_compar_ascending, tp_array_compar_descending): New
3062         functions.
3063         (ascending_option_def, qcs_flag_option_def)
3064         (thr_qcs_flags_option_defs)
3065         (make_thread_apply_all_options_def_group)
3066         (make_thread_apply_options_def_group): New.
3067         (thread_apply_all_command): Use gdb::option::process_options.
3068         (thread_apply_command_completer)
3069         (thread_apply_all_command_completer): New.
3070         (thread_apply_command): Use gdb::option::process_options.
3071         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3072         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3073         to generate help text of "thread apply".  Adjust "taas"'s help.
3074         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3075         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3076
3077 2019-06-13  Pedro Alves  <palves@redhat.com>
3078
3079         * thread.c (thread_apply_command): Check for invalid TID with
3080         isdigit instead of !isalpha.
3081
3082 2019-06-13  Pedro Alves  <palves@redhat.com>
3083
3084         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3085         (validate_flags_qcs): New.
3086         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3087         (validate_flags_qcs): Declare.
3088         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3089         (make_frame_apply_options_def_group): New.
3090         (frame_apply_command_count): Process options with
3091         gdb::option::process_options.
3092         (frame_apply_completer): New.
3093         (frame_apply_level_completer, frame_apply_all_completer)
3094         (frame_apply_completer): New.
3095         (_initialize_stack): Update help of "frame apply", "frame apply
3096         level", "frame apply all" and "faas" to mention supported options
3097         and install command completers.
3098         * stack.h (frame_apply_all_completer): Declare.
3099         * thread.c: Include "stack.h".
3100         (tfaas_command): Add "--".
3101         (_initialize_thread): Update help "tfaas" to mention supported
3102         options and install command completer.
3103
3104 2019-06-13  Pedro Alves  <palves@redhat.com>
3105
3106         * completer.c (complete_nested_command_line): New.
3107         (gdb_completion_word_break_characters_throw): Add assertion.
3108         * completer.h (complete_nested_command_line): Declare.
3109
3110 2019-06-13  Pedro Alves  <palves@redhat.com>
3111
3112         * stack.c (parse_backtrace_qualifiers): New.
3113         (backtrace_command): Use it.
3114         (backtrace_command_completer): Complete on qualifiers.
3115
3116 2019-06-13  Pedro Alves  <palves@redhat.com>
3117
3118         * frame.c: Include "cli/cli-option.h.
3119         (user_set_backtrace_options): New.
3120         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3121         Delete.
3122         (get_prev_frame): Adjust.
3123         (boolean_option_def, uinteger_option_def)
3124         (set_backtrace_option_defs): New.
3125         (_initialize_frame): Adjust and use
3126         gdb::option::add_setshow_cmds_for_options to install "set
3127         backtrace past-main" and "set backtrace past-entry".
3128         * frame.h: Include "cli/cli-option.h".
3129         (struct frame_print_options): Forward declare.
3130         (print_frame_arguments_all, print_frame_arguments_scalars)
3131         (print_frame_arguments_none): Declare.
3132         (print_entry_values): Delete declaration.
3133         (struct frame_print_options, user_frame_print_options): New.
3134         (struct set_backtrace_options): New.
3135         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3136         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3137         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3138         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3139         (list_args_or_locals): Add frame_print_options parameter.
3140         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3141         * python/py-framefilter.c (enumerate_args): Pass down
3142         USER_FRAME_PRINT_OPTIONS.
3143         * stack.c: Include "cli/cli-option.h".
3144         (print_frame_arguments_all, print_frame_arguments_scalars)
3145         (print_frame_arguments_none): Declare.
3146         (print_raw_frame_arguments, print_entry_values): Delete.
3147         (user_frame_print_options): New.
3148         (boolean_option_def, enum_option_def, frame_print_option_defs):
3149         New.
3150         (struct backtrace_cmd_options): New.
3151         (bt_flag_option_def): New.
3152         (backtrace_command_option_defs): New.
3153         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3154         (print_frame_arg, read_frame_arg, print_frame_args)
3155         (print_frame_info, print_frame): Add frame_print_options parameter
3156         and use it.
3157         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3158         (backtrace_command_1): Add frame_print_options and
3159         backtrace_cmd_options parameters and use them.
3160         (make_backtrace_options_def_group): New.
3161         (backtrace_command): Process command options with
3162         gdb::option::process_options.
3163         (backtrace_command_completer): New.
3164         (_initialize_stack): Extend "backtrace"'s help to mention
3165         supported options.  Install completer for "backtrace".
3166         Install some settings commands with add_setshow_cmds_for_options.
3167
3168 2019-06-13  Pedro Alves  <palves@redhat.com>
3169
3170         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3171         and that "set/show print raw frame-arguments" are now deprecated.
3172
3173         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3174         command.
3175         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3176         * stack.c (_initialize_stack): Install "set/show print
3177         raw-frame-arguments", and deprecate "set/show print raw
3178         frame-arguments".
3179         * valprint.c (_initialize_valprint): Deprecate "set/show print
3180         raw".
3181
3182 2019-06-13  Pedro Alves  <palves@redhat.com>
3183
3184         * compile/compile.c (struct compile_options): New.
3185         (compile_flag_option_def, compile_command_option_defs)
3186         (make_compile_options_def_group): New.
3187         (compile_file_command): Handle options with
3188         gdb::option::process_options.
3189         (compile_file_command_completer): New function.
3190         (compile_code_command): Handle options with
3191         gdb::option::process_options.
3192         (compile_code_command_completer): New function.
3193         (_initialize_compiler): Install completers for "compile code" and
3194         "compile file".  Mention available options in "compile code" and
3195         "compile code"'s help.
3196         * completer.c (advance_to_completion_word): New, factored out from
3197         ...
3198         (advance_to_expression_complete_word_point): ... this.
3199         (advance_to_filename_complete_word_point): New.
3200         * completer.h (advance_to_filename_complete_word_point): New
3201         declaration.
3202
3203 2019-06-13  Pedro Alves  <palves@redhat.com>
3204
3205         * compile/compile.c: Include "cli/cli-option.h".
3206         (compile_print_value): Scope data pointer is now a
3207         value_print_options pointer; adjust.
3208         (compile_print_command): Process options.  Scope data pointer is
3209         now a value_print_options pointer; adjust.
3210         (_initialize_compile): Update "compile print"'s help to include
3211         supported options.  Install a completer for "compile print".
3212         * cp-valprint.c (show_vtblprint, show_objectprint)
3213         (show_static_field_print): Delete.
3214         (_initialize_cp_valprint): Don't install "set print
3215         static-members", "set print vtbl", "set print object" here.
3216         * printcmd.c: Include "cli/cli-option.h" and
3217         "common/gdb_optional.h".
3218         (print_command_parse_format): Rework to fill in a
3219         value_print_options instead of a format_data.
3220         (print_value): Change parameter type from format_data pointer to
3221         value_print_options reference.  Adjust.
3222         (print_command_1): Process options.  Adjust to pass down a
3223         value_print_options.
3224         (print_command_completer): New.
3225         (_initialize_printcmd): Install print_command_completer as
3226         handle_brkchars completer for the "print" command.  Update
3227         "print"'s help to include supported options.
3228         * valprint.c: Include "cli/cli-option.h".
3229         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3230         here from cp-valprint.c.
3231         (boolean_option_def, uinteger_option_def)
3232         (value_print_option_defs, make_value_print_options_def_group):
3233         New.  Use gdb::option::add_setshow_cmds_for_options to install
3234         "set print elements", "set print null-stop", "set print repeats",
3235         "set print pretty", "set print union", "set print array", "set
3236         print address", "set print symbol", "set print array-indexes".
3237         * valprint.h: Include <string> and "cli/cli-option.h".
3238         (make_value_print_options_def_group): Declare.
3239         (print_value): Change parameter type from format_data pointer to
3240         value_print_options reference.
3241         (print_command_completer): Declare.
3242
3243 2019-06-13  Pedro Alves  <palves@redhat.com>
3244
3245         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3246         (COMMON_SFILES): Add maint-test-settings.c.
3247         * cli/cli-decode.c (boolean_enums): New global, factored out from
3248         ...
3249         (add_setshow_boolean_cmd): ... here.
3250         * cli/cli-decode.h (boolean_enums): Declare.
3251         * cli/cli-option.c: New file.
3252         * cli/cli-option.h: New file.
3253         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3254         factored out from ...
3255         (parse_cli_boolean_value(const char *)): ... this.
3256         (is_unlimited_literal): Change parameter type to pointer to
3257         pointer.  Adjust and advance ARG pointer.
3258         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3259         (parse_cli_var_enum): New, factored out from ...
3260         (do_set_command): ... this.  Adjust.
3261         * cli/cli-setshow.h (parse_cli_boolean_value)
3262         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3263         (parse_cli_var_enum): Declare.
3264         * cli/cli-utils.c: Include "cli/cli-option.h".
3265         (get_ulongest): New.
3266         * cli/cli-utils.h (get_ulongest): Declare.
3267         (check_for_argument): New overloads.
3268         * maint-test-options.c: New file.
3269
3270 2019-06-13  Pedro Alves  <palves@redhat.com>
3271
3272         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3273         parse a range if "-" is at the end of the string.
3274
3275 2019-06-13  Pedro Alves  <palves@redhat.com>
3276
3277         * cli/cli-setshow.c (parse_auto_binary_operation)
3278         (parse_cli_boolean_value): Don't allow "o".
3279
3280 2019-06-13  Pedro Alves  <palves@redhat.com>
3281
3282         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3283         * NEWS: Mention maint test-settings KIND.
3284         * maint-test-settings.c: New file.
3285
3286 2019-06-13  Pedro Alves  <palves@redhat.com>
3287
3288         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3289         completer.
3290         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3291         "set" completers.
3292
3293 2019-06-13  Pedro Alves  <palves@redhat.com>
3294
3295         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3296         after item.
3297
3298 2019-06-13  Pedro Alves  <palves@redhat.com>
3299
3300         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3301
3302 2019-06-13  Pedro Alves <palves@redhat.com>
3303
3304         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3305         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3306         call.
3307         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3308         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3309         calls.
3310         (check_for_argument): Skip spaces after argument.
3311
3312 2019-06-13  Pedro Alves  <palves@redhat.com>
3313
3314         * thread.c (thread_apply_command): Adjust TID parsing.
3315         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3316         detected before end of string.
3317         (tid_is_in_list): Error out if LIST is invalid.
3318
3319 2019-06-13  Pedro Alves  <palves@redhat.com>
3320
3321         * completer.c (complete_line_internal_1): Rewind completion word
3322         point.
3323         (completion_tracker::advance_custom_word_point_by): Change
3324         parameter type to int.
3325         * completer.h (completion_tracker::advance_custom_word_point_by):
3326         Likewise.
3327
3328 2019-06-13  Pedro Alves  <palves@redhat.com>
3329
3330         * completer.c (advance_to_completion_word): Handle delimiters.
3331
3332 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3333
3334         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3335
3336 2019-06-11  Tom Tromey  <tom@tromey.com>
3337
3338         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3339         (xmalloc_failed): Move to alloc.c.
3340         * alloc.c: New file.
3341         * Makefile.in (COMMON_SFILES): Add alloc.c.
3342
3343 2019-06-11  Tom Tromey  <tom@tromey.com>
3344
3345         * nat/linux-waitpid.c: Don't include server.h.
3346         (linux_debug): Remove.
3347         (my_waitpid): Update.
3348
3349 2019-06-11  Tom Tromey  <tromey@adacore.com>
3350
3351         * infcall.c (_initialize_infcall): Remove trailing newline from
3352         help.
3353         * user-regs.c (_initialize_user_regs): Remove trailing newline
3354         from help.
3355         * typeprint.c (_initialize_typeprint): Remove trailing newline
3356         from help.
3357         * reverse.c (_initialize_reverse): Remove trailing newlines from
3358         help.
3359         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3360         from help.
3361         * language.c (add_set_language_command): Remove trailing newline
3362         from help.
3363         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3364         help.
3365         * disasm.c (_initialize_disasm): Remove trailing newline from
3366         help.
3367         * top.c (init_main): Remove trailing newline from help.
3368         * interps.c (_initialize_interpreter): Remove trailing newline
3369         from help.
3370         * btrace.c (_initialize_btrace): Remove trailing newlines from
3371         help.
3372         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3373         from help.
3374         * python/python.c (_initialize_python): Remove trailing newline
3375         from help.
3376         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3377         help.
3378         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3379         from help.  Reformat some text.
3380         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3381         from help.
3382         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3383         newline from help.
3384
3385 2019-06-11  Tom Tromey  <tromey@adacore.com>
3386
3387         * darwin-nat.c (darwin_decode_exception_message)
3388         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3389
3390 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3391
3392         * valops.c (value_slice): Check for not allocated or not
3393         associated values.
3394
3395 2019-06-10  Tom de Vries  <tdevries@suse.de>
3396
3397         PR gdb/24618
3398         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3399         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3400         invalid.
3401
3402 2019-06-10  Tom de Vries  <tdevries@suse.de>
3403
3404         PR gdb/24611
3405         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3406         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3407
3408 2019-06-10  Tom de Vries  <tdevries@suse.de>
3409
3410         PR symtab/24545
3411         * symtab.c (struct demangled_name_entry): Add language field.
3412         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3413         static minimal symbol".  Set and use language field.
3414
3415 2019-06-10  Tom Tromey  <tromey@adacore.com>
3416
3417         * ada-lang.c (_initialize_ada_language): Update help text.
3418
3419 2019-06-10  Tom Tromey  <tromey@adacore.com>
3420
3421         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3422         with a newline.
3423         * guile/guile.c (handle_boot_error): Don't end warning with a
3424         newline.
3425         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3426         warning with a newline.
3427         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3428         newline.
3429         (s12z_frame_cache): Likewise.
3430         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3431         a newline.
3432         * solib-svr4.c (disable_probes_interface): Don't end warning with
3433         a newline.
3434         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3435         newline.
3436         * python/python.c (do_finish_initialization): Don't end warning
3437         with a newline.
3438
3439 2019-06-10  Tom Tromey  <tom@tromey.com>
3440
3441         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3442         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3443         gdbpy_enter.
3444
3445 2019-06-10  Tom Tromey  <tromey@adacore.com>
3446
3447         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3448         data.
3449         (elf_new_init): Don't call stabsread_new_init.
3450         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3451         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3452         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3453
3454 2019-06-10  Tom de Vries  <tdevries@suse.de>
3455
3456         PR symtab/16264
3457         PR symtab/24517
3458         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3459
3460 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3461
3462         * source.c (find_and_open_source): Also rewrite relative file
3463         names.
3464
3465 2019-04-26  Amos Bird  <amosbird@gmail.com>
3466
3467         * annotate.c (annotate_thread_exited): Add "thread-exited"
3468         annotation.
3469
3470 2019-06-06  Tom Tromey  <tromey@adacore.com>
3471
3472         * maint.h (class scoped_command_stats): Use
3473         DISABLE_COPY_AND_ASSIGN.
3474         <print_time>: New method.
3475         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3476         print_time.
3477         (scoped_command_stats::print_time): New method.
3478
3479 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3480
3481         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3482         instructions of lengths 6 or 8 bytes.
3483
3484 2019-06-04  Pedro Alves  <palves@redhat.com>
3485
3486         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3487
3488         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3489         * breakpoint.c (condition_completer): Likewise.
3490         * cli/cli-dump.c (scan_expression): Likewise.
3491         * common/filestuff.c (mkdir_recursive): Likewise.
3492         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3493         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3494         (gdb_abspath): Likewise.
3495         * compile/compile-cplus-types.c
3496         (compile_cplus_instance::decl_name): Likewise.
3497         * completer.c (complete_explicit_location):
3498         (signal_completer, reg_or_group_completer_1): Likewise.
3499         * cp-support.c (cp_remove_params_if_any): Likewise.
3500         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3501         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3502         * infcmd.c (strip_bg_char): Likewise.
3503         * linespec.c (copy_token_string): Likewise.
3504         * mi/mi-main.c (output_cores): Likewise.
3505         * psymtab.c (psymtab_search_name):
3506         * symfile.c (test_set_ext_lang_command): Likewise.
3507         * target.c (target_fileio_read_stralloc): Likewise.
3508         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3509         * value.c (complete_internalvar): Likewise.
3510
3511 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3512
3513         Add objfile property to gdb.Type.
3514         * NEWS: Mention Python API addition.
3515         * python/py-type.c (typy_get_objfile): New method.
3516
3517 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3518
3519         * NEWS: Mention the new set|show style [title|highlight].
3520         Mention changes to "show style", "help" and "apropos".
3521
3522 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3523
3524         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3525         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3526         instead of print_help_for_command.
3527         (print_doc_of_command): New function.
3528         (help_list): Add 'apropos -v word' suggestion.
3529         (print_help_for_command): Style the command name using title style.
3530         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3531         (_initialize_cli_cmds): Describe -v in apropos_command help.
3532
3533 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3534
3535         * cli/cli-style.h (cli_style_option): Add name in constructor,
3536         add m_name class member, add constructor with intensity,
3537         add name class function.
3538         (cli_style_option::add_setshow_commands): Remove name argument.
3539         (highlight_style, title_style): New styles.
3540         * cli/cli-style.c (do_show): New function that shows a style
3541         characteristic styling the style name with itself.
3542         (set_style_name): New function.
3543         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3544         Update all callers according to the changes in cli/cli-style.h.
3545         * utils.h (fputs_highlighted): New function.
3546         * utils.c (fputs_highlighted): Likewise.
3547
3548 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3549
3550         * NEWS: Mention new pipe command and new convenience variables.
3551
3552 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3553
3554         * cli/cli-cmds.c (pipe_command): New function.
3555         (_initialize_cli_cmds): Call add_com for pipe_command.
3556         Define | as an alias for pipe.
3557         (exit_status_set_internal_vars): New function.
3558         (shell_escape): Call exit_status_set_internal_vars.
3559         cli/cli-decode.c (find_command_name_length): Recognize | as
3560         a single character command.
3561
3562 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3563
3564         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3565         top.c (execute_command_to_ui_file): New function, mostly a copy
3566         of execute_command_to_string.
3567         (execute_command_to_string): Implement by calling
3568         execute_command_to_ui_file.
3569
3570 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3571
3572         * top.h (saved_command_line): Remove declaration.
3573         * top.c (previous_saved_command_line, previous_repeat_arguments):
3574         New variables.
3575         (saved_command_line): Make static, define together with other
3576         'repeat variables'.
3577         (dont_repeat): Clear repeat_arguments.
3578         (repeat_previous, get_saved_command_line, save_command_line):
3579         New functions.
3580         (gdb_init): Initialize saved_command_line
3581         and previous_saved_command_line.
3582         * main.c (captured_main_1): Remove saved_command_line initialization.
3583         * event-top.c (handle_line_of_input): Update to use
3584         the new 'repeat' related functions instead of direct access to
3585         saved_command_line.
3586         * command.h (repeat_previous, get_saved_command_line,
3587         save_command_line): New declarations.
3588         (dont_repeat): Add comment.
3589
3590 2019-05-30  Tom Tromey  <tromey@adacore.com>
3591
3592         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3593         Fix comment.
3594         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3595
3596 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3597
3598         PR cli/24587
3599         * completer.c (complete): Initialize variable word.
3600
3601 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3602
3603         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3604         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3605         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3606         'body' is NULL to the outter 'if', protecting the '!is_define'
3607         situation as well.
3608
3609 2019-05-29  Tom Tromey  <tromey@adacore.com>
3610
3611         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3612         (dwarf_unknown): New function.
3613         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3614         (dwarf_type_encoding_name): Use dwarf_unknown.
3615
3616 2019-05-29  Tom Tromey  <tromey@adacore.com>
3617
3618         PR c++/20020:
3619         * cp-valprint.c (cp_print_value_fields): Call
3620         cp_print_static_field inside "try".
3621
3622 2019-05-29  Tom Tromey  <tromey@adacore.com>
3623
3624         * inflow.c (struct terminal_info): Add default operator=.
3625         * configure: Rebuild.
3626         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3627         -Wdeprecated-copy-dtor, -Wredundant-move.
3628
3629 2019-05-29  Tom Tromey  <tromey@adacore.com>
3630
3631         * NEWS: Add entry.
3632         * infcmd.c (print_return_value_1): Handle finish_print
3633         option.
3634         (show_print_finish): New function.
3635         (_initialize_infcmd): Add "set/show print finish" commands.
3636         * valprint.c (user_print_options): Initialize new member.
3637         * valprint.h (struct value_print_options) <finish_print>: New
3638         member.
3639
3640 2019-05-28  Tom Tromey  <tromey@adacore.com>
3641
3642         * ada-lang.c (ada_remove_Xbn_suffix)
3643         (find_old_style_renaming_symbol)
3644         (parse_old_style_renaming): Remove.
3645         (ada_find_renaming_symbol): Don't call
3646         find_old_style_renaming_symbol.
3647         (ada_is_renaming_symbol): Rename from
3648         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3649         bool.  Now static.
3650         (ada_read_var_value): Update and simplify.
3651         * ada-exp.y (write_var_or_type): Remove old code.
3652
3653 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3654
3655         * event-top.c: Remove include comment.
3656         * inflow.c (class scoped_ignore_sigttou): Move from here...
3657         * inflow.h (class scoped_ignore_sigttou): ...to here.
3658         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3659         * top.c:  Remove include comment.
3660
3661 2019-05-27  Tom Tromey  <tom@tromey.com>
3662
3663         * NEWS: Fix typo.
3664
3665 2019-05-22  Tom Tromey  <tromey@adacore.com>
3666
3667         * target.c (target_follow_exec): Constify parameter.
3668         * target-delegates.c: Rebuild.
3669         * remote.c (remote_target::follow_exec): Constify parameter.
3670         * infrun.c (follow_exec): Constify parameter.
3671         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3672         (target_follow_exec): Likewise.
3673
3674 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3675
3676         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3677         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3678
3679 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3680
3681         * NEWS: Add debugredirect and testsuite sections.
3682
3683 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3684
3685         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3686         target descriptions using exclusively floating point register name
3687         aliases.
3688
3689 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3690
3691         PR gdb/18644:
3692         * f-lang.c (build_fortran_types): Handle the case where
3693         gdbarch_floatformat_for_type returns a nullptr.
3694
3695 2019-05-21  Tom de Vries  <tdevries@suse.de>
3696
3697         PR cli/24587
3698         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3699
3700 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3701
3702         PR gdb/18644:
3703         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3704         16-byte floats.
3705         * i386-tdep.c (i386_floatformat_for_type): Use
3706         floatformats_ia64_quad for the 16-byte floating point component
3707         within a fortran 32-byte complex number.
3708
3709 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3710
3711         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3712         delete default constructor.
3713         (find_partial_die): Update to return const struct.
3714         (partial_die_parent_scope): Move variable declaration into scope
3715         of its use and change its type to auto.
3716         (guess_partial_die_structure_name): Likewise.
3717         (partial_die_info::fixup): Likewise.
3718
3719 2019-05-17  Tom Tromey  <tromey@adacore.com>
3720
3721         * source.c (find_and_open_source): Remove cast.
3722
3723 2019-05-17  Tom Tromey  <tromey@adacore.com>
3724
3725         * annotate.c (annotate_source): Make "filename" const.
3726         * annotate.h (annotate_source): Use const.
3727
3728 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3729
3730         * disasm.c (set_disassembler_options): Send errors to stderr.
3731
3732 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3733
3734         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3735         (cli_interp_base::set_logging): Check debug_redirect.
3736         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3737         * cli/cli-logging.c (debug_redirect): Add static variable.
3738         (pop_output_files): Add default param.
3739         (handle_redirections): Print debug setting.
3740         (show_logging_command): Likewise.
3741         (_initialize_cli_logging): Add debugredirect command.
3742         * interps.c (current_interp_set_logging): Add debug_redirect
3743         parameter.
3744         * interps.h (set_logging): Add debug_redirect parameter.
3745         (current_interp_set_logging): Likewise.
3746         * mi/mi-common.h: Likewise.
3747         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3748
3749 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3750             Tom Tromey  <tromey@adacore.com>
3751
3752         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3753         directly.
3754         * cli/cli-interp.h (make_logging_output): Remove declaration.
3755         * cli/cli-logging.c (make_logging_output): Remove function.
3756         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3757         directly.
3758         * ui-file.c (tee_file::tee_file): Remove bools.
3759         (tee_file::~tee_file): Remove deletes.
3760         * ui-file.h (tee_file): Remove bools.
3761
3762 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3763
3764         * mi/mi-cmds.h (mi_cmd_complete): New function.
3765         * mi/mi-main.c (mi_cmd_complete): Likewise.
3766         * mi/mi-cmds.c: Define new MI command -complete.
3767         * NEWS: Mention new -complete command.
3768
3769 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3770
3771         * completer.h (complete): New function.
3772         * completer.c (complete): Likewise.
3773         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3774         function defined in completer.h.
3775
3776 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3777
3778         * MAINTAINERS (Write After Approval): Add myself.
3779
3780 2019-05-17  Tom de Vries  <tdevries@suse.de>
3781
3782         PR gdb/24094
3783         * dwarf2read.c (struct cu_partial_die_info): New struct.
3784         (find_partial_die): Return cu_partial_die_info.
3785         (partial_die_parent_scope, guess_partial_die_structure_name)
3786         (partial_die_info::fixup): Handle new return type of find_partial_die.
3787
3788 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3789
3790         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3791         "std::string", simplifying the algorithm.
3792
3793 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3794
3795         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3796         (stap_static_probe_ops::get_probes): Likewise.
3797
3798 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3799
3800         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3801         '-')" and "else if".
3802         (stap_parse_single_operand): Join checks for
3803         "gdbarch_stap_parse_special_token_p" and
3804         "gdbarch_stap_parse_special_token" in the same "if" statement.
3805         Invert check when verifying for operation on register
3806         displacement.
3807
3808 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3809
3810         * stap-probe.c (stap_get_opcode): Update comment.
3811         (stap_get_expected_argument_type): Likewise.
3812         (handle_stap_probe): Likewise.
3813
3814 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3815
3816         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3817         return type to 'bool'.  Adjust comment.  Use 'bool' when
3818         appropriate.
3819         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3820         * stap-probe.c (stap_parse_argument_1): Likewise.
3821         (stap_is_operator): Likewise.
3822         (stap_is_generic_prefix): Likewise.
3823         (stap_is_register_prefix): Likewise.
3824         (stap_is_register_indirection_prefix): Likewise.
3825         (stap_is_integer_prefix): Likewise.
3826         (stap_generic_check_suffix): Likewise.
3827         (stap_check_integer_suffix): Likewise.
3828         (stap_check_register_suffix): Likewise.
3829         (stap_check_register_indirection_suffix): Likewise.
3830         (stap_parse_register_operand): Likewise.
3831         (stap_parse_single_operand): Likewise.
3832         (stap_parse_argument_1): Likewise.
3833         (stap_probe::get_argument_count): Likewise.
3834         (stap_is_operator): Likewise.
3835
3836 2019-05-16  Tom Tromey  <tromey@adacore.com>
3837
3838         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3839         keyword to foreach.
3840
3841 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3842
3843         * linux-thread-db.c (try_thread_db_load_1): Change return type
3844         to bool.
3845         (try_thread_db_load): Likewise.
3846         (try_thread_db_load_from_pdir_1): Likewise.
3847         (try_thread_db_load_from_pdir): Likewise.
3848         (try_thread_db_load_from_sdir): Likewise.
3849         (try_thread_db_load_from_dir): Likewise.
3850         (thread_db_load_search): Likewise.
3851         (has_libpthread): Likewise.
3852         (thread_db_load): Likewise.
3853
3854 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3855
3856         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3857         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3858         NULL, and complain/return if that's the case.
3859
3860 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3861
3862         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3863         (advance, posn, abstract_read_memory): New functions.
3864         [struct mem_read_abstraction]: New struct.
3865         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3866
3867 2019-05-14  Tom Tromey  <tromey@adacore.com>
3868
3869         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3870         value is not lval_memory.
3871
3872 2019-05-14  Tom Tromey  <tromey@adacore.com>
3873
3874         * solib.c (info_sharedlibrary_command): Style the file name.
3875
3876 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3877
3878         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3879         (aarch64_vnv_type): Likewise.
3880         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3881         * common/tdesc.c: Likewise.
3882         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3883         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3884         * features/aarch64-fpu.xml: Add ieee half view.
3885         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3886         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3887         * gdbtypes.h (struct builtin_type): Likewise.
3888         (struct objfile_type): Likewise.
3889
3890 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3891
3892         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3893         typo.
3894         * location.h (string_to_event_location): Likewise.
3895
3896 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3897
3898         GDB 8.3 released.
3899
3900 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3901
3902         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3903         New variable declaration.
3904         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3905         New variable.
3906         (print_one_breakpoint): Use ui_out::test_flags and new global
3907         variable to compute use_fixed_output.
3908         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3909         Remove.
3910         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3911         (mi_multi_location_breakpoint_output_fixed): Remove.
3912         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3913         new variable.
3914         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3915         fix_multi_location_breakpoint_output flag if version >= 3.
3916         * ui-out.h (enum ui_out_flag)
3917         <fix_multi_location_breakpoint_output>: New enumerator.
3918
3919 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3920
3921         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3922
3923 2019-05-10  Tom Tromey  <tromey@adacore.com>
3924
3925         * ada-lang.c (catch_ada_completer): New function.
3926         (_initialize_ada_language): Use it.
3927
3928 2019-05-10  Tom Tromey  <tromey@adacore.com>
3929
3930         * thread.c (print_thread_info): Make "requested_threads" const.
3931         * gdbthread.h (print_thread_info): Make "requested_threads"
3932         const.
3933         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3934         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3935
3936 2019-05-08  Tom Tromey  <tom@tromey.com>
3937
3938         * gdbtypes.c (objfile_type_data): Change type.
3939         (objfile_type, _initialize_gdbtypes): Update.
3940
3941 2019-05-08  Tom Tromey  <tom@tromey.com>
3942
3943         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3944         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3945         (_initialize_dwarf2_frame): Update.
3946
3947 2019-05-08  Tom Tromey  <tom@tromey.com>
3948
3949         * objc-lang.c (objc_objfile_data): Change type.
3950         (find_methods): Update.
3951         (_initialize_objc_lang): Remove.
3952
3953 2019-05-08  Tom Tromey  <tom@tromey.com>
3954
3955         * stabsread.c (rs6000_builtin_type_data): Change type.
3956         (rs6000_builtin_type, _initialize_stabsread): Update.
3957
3958 2019-05-08  Tom Tromey  <tom@tromey.com>
3959
3960         * mips-tdep.c (mips_pdr_data): Remove.
3961         (_initialize_mips_tdep): Update.
3962
3963 2019-05-08  Tom Tromey  <tom@tromey.com>
3964
3965         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3966         (hppa_init_objfile_priv_data, read_unwind_info)
3967         (find_unwind_entry, _initialize_hppa_tdep): Update.
3968
3969 2019-05-08  Tom Tromey  <tom@tromey.com>
3970
3971         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3972         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3973         on obstack.
3974         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3975
3976 2019-05-08  Tom Tromey  <tom@tromey.com>
3977
3978         * mdebugread.c (basic_type_data): Change type.
3979         (basic_type, _initialize_mdebugread): Update.
3980
3981 2019-05-08  Tom Tromey  <tom@tromey.com>
3982
3983         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3984
3985 2019-05-08  Tom Tromey  <tom@tromey.com>
3986
3987         * nto-tdep.c (nto_inferior_data_reg): Change type.
3988         (nto_inferior_data): Update.
3989         (nto_inferior_data_cleanup, nto_new_inferior_data)
3990         (_initialize_nto_tdep): Remove.
3991         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3992
3993 2019-05-08  Tom Tromey  <tom@tromey.com>
3994
3995         * ada-lang.c (struct ada_inferior_data): Add initializers.
3996         (ada_inferior_data): Change type.
3997         (ada_inferior_data_cleanup): Remove.
3998         (get_ada_inferior_data, ada_inferior_exit)
3999         (struct ada_pspace_data): Add initializers, destructor.
4000         (ada_pspace_data_handle): Change type.
4001         (get_ada_pspace_data): Update.
4002         (ada_pspace_data_cleanup): Remove.
4003
4004 2019-05-08  Tom Tromey  <tom@tromey.com>
4005
4006         * coffread.c (struct coff_symfile_info): Add initializers.
4007         (coff_objfile_data_key): Move lower.  Change type.
4008         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4009         Update.
4010         (coff_free_info): Remove.
4011
4012 2019-05-08  Tom Tromey  <tom@tromey.com>
4013
4014         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4015         (fbsd_pspace_data_handle): Move lower.  Change type.
4016         (get_fbsd_pspace_data): Update.
4017         (fbsd_pspace_data_cleanup): Remove.
4018         (_initialize_fbsd_tdep): Update.
4019
4020 2019-05-08  Tom Tromey  <tom@tromey.com>
4021
4022         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4023         (get_ada_tasks_pspace_data): Update.
4024         (ada_tasks_pspace_data_cleanup): Remove.
4025         (_initialize_tasks): Update.
4026         (ada_tasks_inferior_data_handle): Change type.
4027         (get_ada_tasks_inferior_data): Update.
4028         (ada_tasks_inferior_data_cleanup): Remove.
4029         (struct ada_tasks_pspace_data): Add initializers.
4030
4031 2019-05-08  Tom Tromey  <tom@tromey.com>
4032
4033         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4034         * symfile-debug.c (debug_sym_get_probes): Change type.
4035         * stap-probe.c (handle_stap_probe):
4036         (stap_static_probe_ops::get_probes): Change type.
4037         * probe.h (class static_probe_ops) <get_probes>: Change type.
4038         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4039         (parse_probes_in_pspace): Update.
4040         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4041         Update.
4042         (any_static_probe_ops::get_probes): Change type.
4043         * elfread.c (elfread_data): New typedef.
4044         (probe_key): Change type.
4045         (elf_get_probes): Likewise.  Update.
4046         (probe_key_free): Remove.
4047         (_initialize_elfread): Update.
4048         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4049         Change type.
4050         (dtrace_process_dof_probe, dtrace_process_dof)
4051         (dtrace_static_probe_ops::get_probe): Change type.
4052
4053 2019-05-08  Tom Tromey  <tom@tromey.com>
4054
4055         * xcoffread.c (struct xcoff_symfile_info): Rename from
4056         coff_symfile_info.  Add initializers.
4057         (xcoff_objfile_data_key): Move lower.  Change type.
4058         (XCOFF_DATA): Rewrite.
4059         (xcoff_free_info): Remove.
4060         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4061         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4062         (xcoff_initial_scan): Update.
4063
4064 2019-05-08  Tom Tromey  <tom@tromey.com>
4065
4066         * solib-svr4.c (struct svr4_info): Add initializers and
4067         destructor.
4068         <probes_table>: Now an htab_up.
4069         (solib_svr4_pspace_data): Change type.
4070         (free_probes_table): Simplify.
4071         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4072         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4073         (probes_table_remove_objfile_probes, register_solib_event_probe)
4074         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4075         (_initialize_svr4_solib): Update.
4076
4077 2019-05-08  Tom Tromey  <tom@tromey.com>
4078
4079         * remote.c (remote_pspace_data): Change type.
4080         (remote_pspace_data_cleanup): Remove.
4081         (get_remote_exec_file, set_pspace_remote_exec_file)
4082         (_initialize_remote): Update.
4083
4084 2019-05-08  Tom Tromey  <tom@tromey.com>
4085
4086         * breakpoint.c (breakpoint_objfile_key): Change type.
4087         (get_breakpoint_objfile_data): Update.
4088         (free_breakpoint_objfile_data): Remove.
4089         (_initialize_breakpoint): Update.
4090
4091 2019-05-08  Tom Tromey  <tom@tromey.com>
4092
4093         * linux-tdep.c (struct linux_info): Add initializers.
4094         (linux_inferior_data): Move.  Change type.
4095         (invalidate_linux_cache_inf): Update.
4096         (linux_inferior_data_cleanup): Remove.
4097         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4098
4099 2019-05-08  Tom Tromey  <tom@tromey.com>
4100
4101         * auxv.c (auxv_inferior_data): Move.  Change type.
4102         (auxv_inferior_data_cleanup): Remove.
4103         (invalidate_auxv_cache_inf): Rewrite.
4104         (get_auxv_inferior_data, _initialize_auxv): Update.
4105
4106 2019-05-08  Tom Tromey  <tom@tromey.com>
4107
4108         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4109         (symfile_debug_objfile_data_key): Change type.
4110         (symfile_debug_installed, debug_qf_has_symbols)
4111         (debug_qf_find_last_source_symtab)
4112         (debug_qf_forget_cached_source_info)
4113         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4114         (debug_qf_print_stats, debug_qf_dump)
4115         (debug_qf_expand_symtabs_for_function)
4116         (debug_qf_expand_all_symtabs)
4117         (debug_qf_expand_symtabs_with_fullname)
4118         (debug_qf_map_matching_symbols)
4119         (debug_qf_expand_symtabs_matching)
4120         (debug_qf_find_pc_sect_compunit_symtab)
4121         (debug_qf_map_symbol_filenames)
4122         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4123         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4124         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4125         (debug_sym_read_linetable, debug_sym_relocate): Update.
4126         (symfile_debug_free_objfile): Remove.
4127         (install_symfile_debug_logging, _initialize_symfile_debug):
4128         Update.
4129
4130 2019-05-08  Tom Tromey  <tom@tromey.com>
4131
4132         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4133         allocate_on_obstack.
4134         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4135         (get_dwarf2_per_objfile): Update.
4136         (set_dwarf2_per_objfile): Remove.
4137         (dwarf2_has_info, dwarf2_get_section_info): Update.
4138         (dwarf2_free_objfile): Remove.
4139         (_initialize_dwarf2_read): Update.
4140
4141 2019-05-08  Tom Tromey  <tom@tromey.com>
4142
4143         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4144         initializers.
4145         <unsupported_script_warning_printed,
4146         script_not_found_warning_printed>: Now bool.
4147         (auto_load_pspace_data): Change type.
4148         (~auto_load_pspace_info): Rename from
4149         auto_load_pspace_data_cleanup.
4150         (get_auto_load_pspace_data, init_loaded_scripts_info)
4151         (clear_section_scripts, maybe_print_unsupported_script_warning)
4152         (maybe_print_script_not_found_warning, _initialize_auto_load):
4153         Update.
4154
4155 2019-05-08  Tom Tromey  <tom@tromey.com>
4156
4157         * objfiles.c (objfile_pspace_info): Add destructor and
4158         initializers.
4159         (objfiles_pspace_data): Change type.
4160         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4161         (get_objfile_pspace_data): Update.
4162         (objfiles_bfd_data): Change type.
4163         (get_objfile_bfd_data): Update.
4164         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4165
4166 2019-05-08  Tom Tromey  <tom@tromey.com>
4167
4168         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4169         Change type.
4170         (get_catch_syscall_inferior_data): Update.
4171         (catch_syscall_inferior_data_cleanup): Remove.
4172         (_initialize_break_catch_syscall): Update.
4173
4174 2019-05-08  Tom Tromey  <tom@tromey.com>
4175
4176         * inflow.c (struct terminal_info): Add destructor and
4177         initializers.
4178         (inflow_inferior_data): Change type.
4179         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4180         (get_inflow_inferior_data, inflow_inferior_exit)
4181         (swap_terminal_info, _initialize_inflow): Update.
4182
4183 2019-05-08  Tom Tromey  <tom@tromey.com>
4184
4185         * target-dcache.c (target_dcache_cleanup): Remove.
4186         (target_dcache_aspace_key): Change type.
4187         (target_dcache_init_p, target_dcache_invalidate)
4188         (target_dcache_get, target_dcache_get_or_init)
4189         (_initialize_target_dcache): Update.
4190         * dcache.h (struct dcache_deleter): New.
4191
4192 2019-05-08  Tom Tromey  <tom@tromey.com>
4193
4194         * symtab.c (struct symbol_cache): Add destructor and
4195         initializers.
4196         (symbol_cache_key): Move.  Change type.
4197         (make_symbol_cache, free_symbol_cache): Remove.
4198         (get_symbol_cache): Update.
4199         (symbol_cache_cleanup): Remove.
4200         (ALL_PSPACES, symbol_cache_flush)
4201         (maintenance_print_symbol_cache)
4202         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4203         Update.
4204
4205 2019-05-08  Tom Tromey  <tom@tromey.com>
4206
4207         * symtab.c (struct main_info): Add destructor and initializers.
4208         (main_progspace_key): Move.  Change type.
4209         (get_main_info): Update.
4210         (main_info_cleanup): Remove.
4211         (_initialize_symtab): Update.
4212
4213 2019-05-08  Tom Tromey  <tom@tromey.com>
4214
4215         * registry.h (DECLARE_REGISTRY): Define the _key class.
4216
4217 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4218
4219         * NEWS: Merge two 'New commands' sections.
4220
4221 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4222
4223         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4224         parameter and use Ada language definition instead.
4225         (ada_val_print_ptr): Remove unused language parameter.
4226         (ada_val_print_num): Remove language parameter and use Ada language
4227         definition instead.
4228         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4229         parameter.
4230         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4231         parameter and use Ada language definition instead.
4232         (ada_val_print_1): Update all ada_val_print_xxx calls.
4233         Remove language parameter.
4234         (ada_val_print): Update ada_val_print_1 call.
4235
4236 2019-05-08  Tom Tromey  <tromey@adacore.com>
4237
4238         * remote.c (remote_hw_watchpoint_limit)
4239         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4240         Now static.
4241
4242 2019-05-08  Tom Tromey  <tromey@adacore.com>
4243
4244         * maint.c (_initialize_maint_cmds): Move initialization code to
4245         remote.c.
4246         (watchdog, show_watchdog): Move to remote.c.
4247         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4248         "watchdog" static.
4249         (_initialize_remote): Move initialization code from maint.c.
4250         * defs.h (watchdog): Don't declare.
4251
4252 2019-05-08  Tom Tromey  <tromey@adacore.com>
4253
4254         * tui/tui-interp.c: Include main.h.
4255         * interps.c: Include main.h.
4256         * main.h (interpreter_p): Declare.
4257         * defs.h (interpreter_p): Don't declare.
4258
4259 2019-05-08  Tom Tromey  <tromey@adacore.com>
4260
4261         * dwarf2loc.c: Include dwarf2read.h.
4262         * defs.h (read_unsigned_leb128): Don't declare.
4263         * dwarf2read.h (read_unsigned_leb128): Declare.
4264
4265 2019-05-08  Tom Tromey  <tromey@adacore.com>
4266
4267         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4268         method.
4269
4270 2019-05-08  Tom Tromey  <tromey@adacore.com>
4271
4272         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4273         when no wrap column is set.
4274
4275 2019-05-08  Tom Tromey  <tromey@adacore.com>
4276
4277         * c-lang.c (c_get_string): Handle non-C-style arrays.
4278
4279 2019-05-08  Tom Tromey  <tromey@adacore.com>
4280
4281         * typeprint.c (print_offset_data::update): Print the bit offset,
4282         not the number of bits remaining.
4283
4284 2019-05-08  Tom Tromey  <tromey@adacore.com>
4285
4286         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4287         padding at end of comment.
4288
4289 2019-05-08  Tom Tromey  <tromey@adacore.com>
4290
4291         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4292         Compare main types.
4293
4294 2019-05-06  Tom Tromey  <tom@tromey.com>
4295
4296         * common/scoped_mmap.c: Include common-defs.h.
4297         * common/scoped_mmap.h: Don't include config.h.
4298
4299 2019-05-04  Tom Tromey  <tom@tromey.com>
4300
4301         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4302         (struct aarch64_call_info): Add initializers.
4303         <si>: Now a std::vector.
4304         (pass_on_stack, aarch64_push_dummy_call): Update.
4305
4306 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4307             Tom Tromey  <tom@tromey.com>
4308
4309         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4310         (ppc_threads): Now a std::vector.  Now static.
4311         (hwdebug_find_thread_points_by_tid)
4312         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4313         Update.
4314
4315 2019-05-04  Tom Tromey  <tom@tromey.com>
4316
4317         * arc-tdep.c (arc_tdesc_init): Return bool.
4318
4319 2019-05-04  Tom Tromey  <tom@tromey.com>
4320
4321         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4322         Use gdb_assert_not_reached.
4323
4324 2019-05-04  Tom Tromey  <tom@tromey.com>
4325
4326         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4327         "false".
4328
4329 2019-05-04  Tom Tromey  <tom@tromey.com>
4330
4331         * arc-tdep.c (arc_tdesc_init): Use bool.
4332
4333 2019-05-04  Tom Tromey  <tom@tromey.com>
4334
4335         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4336
4337 2019-05-04  Tom Tromey  <tom@tromey.com>
4338
4339         * cli/cli-cmds.c (valid_command_p): Return bool.
4340
4341 2019-05-04  Tom Tromey  <tom@tromey.com>
4342
4343         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4344         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4345
4346 2019-05-04  Raul Tambre  <raul@tambre.ee>
4347
4348         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4349         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4350         operator for comparison.
4351
4352 2019-05-04  Tom Tromey  <tom@tromey.com>
4353
4354         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4355         (lookup_partial_symbol, print_partial_symbols)
4356         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4357         (psymbol_compare): Update.
4358         (add_psymbol_to_bcache): Clear the entire psymbol.
4359         (maintenance_check_psymtabs): Update.
4360         * psympriv.h (struct partial_symbol): Don't derive from
4361         general_symbol_info.
4362         <obj_section, unrelocated_address, address,
4363         set_unrelocated_address>: Update.
4364         <ginfo>: New member.
4365         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4366         (debug_names::write_psymbols): Update.
4367
4368 2019-05-04  Tom de Vries  <tdevries@suse.de>
4369
4370         * contrib/cc-with-tweaks.sh: Support -n arg.
4371
4372 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4373
4374         * corelow.c (core_target::detach): Ensure frame cache and
4375         register caches are cleared.
4376         inferior.c (exit_inferior_1): Likewise.
4377
4378 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4379             Tom Tromey  <tom@tromey.com>
4380
4381         * dictionary.c (collate_pending_symbols_by_language): Remove
4382         "struct" from foreach.
4383         * symtab.c (lookup_global_symbol_from_objfile)
4384         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4385         foreach.
4386         * ser-tcp.c (net_open): Remove "struct" from foreach.
4387         * objfiles.c (objfile_relocate, objfile_rebase)
4388         (objfile_has_symbols): Remove "struct" from foreach.
4389         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4390         from foreach.
4391         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4392         foreach.
4393         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4394         "struct" from foreach.
4395         * ada-lang.c (create_excep_cond_exprs)
4396         (ada_exception_catchpoint_cond_string): Remove "struct" from
4397         foreach.
4398
4399 2019-05-03  Tom Tromey  <tromey@adacore.com>
4400
4401         * ada-exp.y (convert_char_literal): Check suffix of each
4402         enumerator.
4403
4404 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4405
4406         PR ada/21406:
4407         * ada-exp.y (yywrap): Don't define.
4408         * ada-lex.l (%option): Add noyywrap
4409         (yywrap): Remove.
4410
4411 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4412
4413         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4414         _WIN32_WINNT to the XP level, unless already defined to a higher
4415         level.
4416
4417         * unittests/parse-connection-spec-selftests.c:
4418         * ser-tcp.c:
4419         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4420         override.
4421
4422         * symfile.c (find_separate_debug_file): Remove colon from the
4423         drive spec of DOS/Windows file names of the target, so that the
4424         file name produced from DEBUGDIR and the target's directory will
4425         be valid on DOS/Windows systems.
4426
4427 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4428
4429         * rust-lang.c (val_print_struct): Handle printing structures
4430         containing strings.
4431
4432 2019-05-02  Tom Tromey  <tromey@adacore.com>
4433
4434         * valarith.c (_initialize_valarith): Remove.
4435
4436 2019-05-01  Tom Tromey  <tromey@adacore.com>
4437
4438         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4439         bitfields.
4440
4441 2019-05-01  Tom Tromey  <tromey@adacore.com>
4442
4443         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4444         for big-endian copies.
4445
4446 2019-04-30  Ali Tamur  <tamur@google.com>
4447         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4448         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4449         (read_3_bytes): New function.
4450
4451 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4452
4453         * windows-nat.c (main_thread_id): Delete.
4454         (handle_output_debug_string): Replace main_thread_id by
4455         current_event.dwThreadId.
4456         (fake_create_process): Likewise.
4457         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4458         Do not set main_thread_id.
4459         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4460         current_event.dwThreadId.
4461         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4462
4463 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4464
4465         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4466         Use current_event.dwThreadId instead of main_thread_id.
4467
4468 2019-04-30  Tom Tromey  <tromey@adacore.com>
4469
4470         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4471         (create_excep_cond_exprs): Iterate over program spaces.
4472         (ada_exception_catchpoint_cond_string): Examine all minimal
4473         symbols for exception types.
4474
4475 2019-04-30  Tom Tromey  <tromey@adacore.com>
4476
4477         PR c++/24470:
4478         * dwarf2read.c (process_structure_scope): Handle case where type
4479         has template parameters but no symbol was created.
4480
4481 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4482             Chris January  <chris.january@arm.com>
4483
4484         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4485         qualifier.
4486         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4487
4488 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4489
4490         * f-typeprint.c (f_print_type): Update rules for printing
4491         whitespace.
4492         (f_type_print_varspec_suffix): Likewise.
4493
4494 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4495             Chris January  <chris.january@arm.com>
4496
4497         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4498         function arguments.
4499
4500 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4501
4502         * f-lang.c (build_fortran_types): Change name of void type to
4503         lower case.
4504         * f-typeprint.c (f_type_print_base): Print the name of the void
4505         type, rather than a fixed string.
4506         * f-valprint.c (f_decorations): Use lower case void string.
4507
4508 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4509             Chris January  <chris.january@arm.com>
4510
4511         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4512         types for Fortran.
4513
4514 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4515             Chris January  <chris.january@arm.com>
4516             David Lecomber  <david.lecomber@arm.com>
4517
4518         * f-exp.y (BINOP_INTRINSIC): New token.
4519         (exp): New parser rule handling BINOP_INTRINSIC.
4520         (f77_keywords): Add new builtin procedures.
4521         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4522         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4523         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4524         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4525         (print_unop_subexp_f): New function.
4526         (print_binop_subexp_f): New function.
4527         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4528         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4529         (dump_subexp_body_f): Likewise.
4530         (operator_check_f): Likewise.
4531         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4532         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4533
4534 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4535
4536         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4537         UNOP_KIND.
4538         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4539         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4540         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4541         (operator_length_f): New fuction.
4542         (print_subexp_f): New function.
4543         (op_name_f): New function.
4544         (dump_subexp_body_f): New function.
4545         (operator_check_f): New function.
4546         (exp_descriptor_f): Replace standard expression handling functions
4547         with new functions.
4548         * gdb/fortran-operator.def: New file.
4549         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4550         * gdb/std-operator.def: Remove UNOP_KIND.
4551
4552 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4553
4554         * std-operator.def: Remove unbalanced, stray double quote
4555         character.
4556
4557 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4558             Chris January  <chris.january@arm.com>
4559             Daniel Everett  <daniel.everett@arm.com>
4560             Nick Forrington  <nick.forrington@arm.com>
4561             Richard Bunt  <richard.bunt@arm.com>
4562
4563         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4564         of depth when printing anonymous structs or unions.
4565         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4566         Don't print either the top-level value, or the children if the
4567         max-depth is exceeded.
4568         (ppscm_print_children): When printing the key of a map, allow one
4569         extra level of depth.
4570         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4571         print either the top-level value, or the children if the max-depth
4572         is exceeded.
4573         (print_children): When printing the key of a map, allow one extra
4574         level of depth.
4575         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4576         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4577         (user_print_options): Initialise max_depth field.
4578         (val_print_scalar_or_string_type_p): New function.
4579         (val_print): Check to see if the max depth has been reached.
4580         (val_print_check_max_depth): Define new function.
4581         (show_print_max_depth): New function.
4582         (_initialize_valprint): Add 'print max-depth' option.
4583         * valprint.h (struct value_print_options) <max_depth>: New field.
4584         (val_print_check_max_depth): Declare new function.
4585         * NEWS: Document new feature.
4586
4587 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4588
4589         * ada-lang.c (ada_language_defn): Initialise new field.
4590         * c-lang.c (c_is_string_type_p): New function.
4591         (c_language_defn): Initialise new field.
4592         (cplus_language_defn): Initialise new field.
4593         (asm_language_defn): Initialise new field.
4594         (minimal_language_defn): Initialise new field.
4595         * c-lang.h (c_is_string_type_p): Declare new function.
4596         * d-lang.c (d_language_defn): Initialise new field.
4597         * f-lang.c (f_is_string_type_p): New function.
4598         (f_language_defn): Initialise new field.
4599         * go-lang.c (go_is_string_type_p): New function.
4600         (go_language_defn): Initialise new field.
4601         * language.c (default_is_string_type_p): New function.
4602         (unknown_language_defn): Initialise new field.
4603         (auto_language_defn): Initialise new field.
4604         * language.h (struct language_defn) <la_is_string_type_p>: New
4605         member variable.
4606         (default_is_string_type_p): Declare new function.
4607         * m2-lang.c (m2_language_defn): Initialise new field.
4608         * objc-lang.c (objc_language_defn): Initialise new field.
4609         * opencl-lang.c (opencl_language_defn): Initialise new field.
4610         * p-lang.c (pascal_is_string_type_p): New function.
4611         (pascal_language_defn): Initialise new field.
4612         * rust-lang.c (rust_is_string_type_p): New function.
4613         (rust_language_defn): Initialise new field.
4614
4615 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4616
4617         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4618         New field.
4619         * ada-lang.c (ada_language_defn): Initialise new field.
4620         * c-lang.c (c_language_defn): Likewise.
4621         (cplus_language_defn): Likewise.
4622         (asm_language_defn): Likewise.
4623         (minimal_language_defn): Likewise.
4624         * d-lang.c (d_language_defn): Likewise.
4625         * f-lang.c (f_language_defn): Likewise.
4626         * go-lang.c (go_language_defn): Likewise.
4627         * language.c (unknown_language_defn): Likewise.
4628         (auto_language_defn): Likewise.
4629         * m2-lang.c (m2_language_defn): Likewise.
4630         * objc-lang.c (objc_language_defn): Likewise.
4631         * opencl-lang.c (opencl_language_defn): Likewise.
4632         * p-lang.c (pascal_language_defn): Likewise.
4633         * rust-lang.c (rust_language_defn): Likewise.
4634
4635 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4636
4637         * ada-lang.c (ada_is_character_type): Change return type to bool.
4638         (ada_is_string_type): Likewise.
4639         * ada-lang.h (ada_is_character_type): Update declaration
4640         (ada_is_string_type): Likewise.
4641
4642 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4643
4644         Support style in 'frame|thread apply'
4645
4646         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4647         * record.c (record_start, record_stop): Update callers of
4648         execute_command_to_string with false.
4649         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4650         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4651         methods.
4652         (class string_file): New constructor with term_out parameter.
4653         Override methods term_out and can_emit_style_escape.  New member
4654         term_out.
4655         (class stdio_file): Override can_emit_style_escape.
4656         (class tee_file): Override term_out and can_emit_style_escape.
4657         * utils.h (can_emit_style_escape): Remove.
4658         * utils.c (can_emit_style_escape): Likewise.
4659         Update all callers of can_emit_style_escape (SOMESTREAM) to
4660         SOMESTREAM->can_emit_style_escape.
4661         * source-cache.c (source_cache::get_source_lines): Likewise.
4662         * stack.c (frame_apply_command_count): Call execute_command_to_string
4663         passing the term_out characteristic of the current gdb_stdout.
4664         * thread.c (thr_try_catch_cmd): Likewise.
4665         * top.c (execute_command_to_string): pass term_out parameter
4666         to construct the string_file for the command output.
4667         * ui-file.c (term_cli_styling): New function (most code moved
4668         from utils.c can_emit_style_escape).
4669         (string_file::string_file, string_file::can_emit_style_escape,
4670         stdio_file::can_emit_style_escape, tee_file::term_out,
4671         tee_file::can_emit_style_escape): New functions.
4672
4673 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4674
4675         * NEWS: Mention the new set|show may-call-functions.
4676         * infcall.c (may_call_functions_p): New variable.
4677         (show_may_call_functions_p): New function.
4678         (call_function_by_hand_dummy): Throws an error if not
4679         may-call-functions.
4680         (_initialize_infcall): Call add_setshow_boolean_cmd for
4681         may-call-functions.
4682
4683 2019-04-25  Keith Seitz  <keiths@redhat.com>
4684
4685         PR c++/24367
4686         * cp-support.c (inspect_type): Don't attempt substitutions
4687         of symbol with the same name.
4688
4689 2019-04-25  Tom Tromey  <tromey@adacore.com>
4690
4691         PR gdb/24475:
4692         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4693         static.
4694
4695 2019-04-25  Tom Tromey  <tromey@adacore.com>
4696
4697         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4698         rvalue reference.
4699         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4700         (gdb_xml_parser::parse): Use std::move.
4701         * python/python-internal.h (gdbpy_convert_exception): Take a const
4702         reference.
4703         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4704         std::move.
4705         * python/py-utils.c (gdbpy_convert_exception): Take a const
4706         reference.
4707         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4708         Use std::move.
4709         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4710         Use std::move.
4711         * mi/mi-main.c (mi_print_exception): Take a const reference.
4712         * main.c (handle_command_errors): Take a const reference.
4713         * linespec.c (parse_linespec): Use std::move.
4714         * infcall.c (run_inferior_call): Use std::move.
4715         (call_function_by_hand_dummy): Use std::move.
4716         * exec.c (try_open_exec_file): Use std::move.
4717         * exceptions.h (exception_print, exception_fprintf)
4718         (exception_print_same): Update.
4719         * exceptions.c (print_exception, exception_print)
4720         (exception_fprintf, exception_print_same): Change parameters to
4721         const reference.
4722         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4723         * common/new-op.c: Use std::move.
4724         * common/common-exceptions.h (struct gdb_exception): Add move
4725         constructor.
4726         (struct gdb_exception_error, struct gdb_exception_quit, struct
4727         gdb_quit_bad_alloc): Change constructor to move constructor.
4728         (throw_exception): Change parameter to rvalue reference.
4729         * common/common-exceptions.c (throw_exception): Take rvalue
4730         reference.
4731         * cli/cli-interp.c (safe_execute_command): Use std::move.
4732         * breakpoint.c (insert_bp_location, location_to_sals): Use
4733         std::move.
4734
4735 2019-04-25  Tom Tromey  <tromey@adacore.com>
4736
4737         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4738         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4739         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4740         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4741         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4742         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4743         guile/scm-value.c: Use unpack.
4744         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4745         gdbscm_gdb_exception.
4746         (gdbscm_throw_gdb_exception): Likewise.
4747         (struct gdbscm_gdb_exception): New.
4748         (unpack): New function.
4749         (gdbscm_wrap): Use unpack.
4750
4751 2019-04-25  Tom Tromey  <tromey@adacore.com>
4752
4753         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4754         (gdb_rl_callback_handler): Use std::move.
4755         * common/common-exceptions.h (struct gdb_exception): Add move
4756         assignment operator.
4757         (throw_exception_sjlj): Change "exception" to const reference.
4758         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4759         (throw_exception_sjlj): Change "exception" to const reference.
4760
4761 2019-04-25  Tom Tromey  <tromey@adacore.com>
4762
4763         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4764         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4765         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4766         Update.
4767         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4768         Update.
4769         * mi/mi-interp.c (mi_interp::exec): Update.
4770         * linespec.c (parse_linespec): Update.
4771         * infcall.c (run_inferior_call): Update.
4772         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4773         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4774         (gdbscm_lookup_global_symbol): Update.
4775         * guile/scm-param.c (gdbscm_parameter_value): Update.
4776         * guile/scm-frame.c (gdbscm_frame_read_register)
4777         (gdbscm_frame_read_var): Update.
4778         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4779         * exec.c (try_open_exec_file): Update.
4780         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4781         (gdb_rl_callback_handler): Update.
4782         * common/common-exceptions.h (exception_none): Don't declare.
4783         * common/common-exceptions.c (exception_none): Don't define.
4784         (struct catcher) <exception>: Update.
4785         * cli/cli-interp.c (safe_execute_command): Update.
4786         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4787
4788 2019-04-25  Ali Tamur  <tamur@google.com>
4789
4790         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4791         (read_attribute_value): Likewise.
4792         (dwarf2_read_addr_index): Update comment.
4793         (read_str_index): Add DW_FORM_strx.
4794         (dwarf2_string_attr): Likewise.
4795         (dwarf2_const_value_attr): Likewise.
4796         (dump_die_shallow): Likewise.
4797         (dwarf2_fetch_constant_bytes): Likewise.
4798         (skip_form_bytes): Likewise.
4799         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4800
4801 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4802
4803         PR corefiles/11608
4804         PR corefiles/18187
4805         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4806         OFFSET.  Verify if current mapping contains an ELF header.
4807         (linux_find_memory_regions_full): Adjust call to
4808         dump_mapping_p.
4809
4810 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4811             Kang Li <kanglictf@gmail.com>
4812
4813         PR gdb/21600
4814
4815         * dwarf2-frame.c (read_initial_length): Be consistent about using
4816         unsigned representation of length.
4817         (decode_frame_entry_1): Likewise.  Check for wraparound of
4818         end pointer as well as buffer overflow.
4819
4820 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4821
4822         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4823         "vq".
4824
4825 2019-04-24  Tom Tromey  <tromey@adacore.com>
4826
4827         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4828
4829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4830
4831         * s12z-tdep.c (s12z_unwind_pc): Delete.
4832         (s12z_unwind_sp): Delete.
4833         (s12z_gdbarch_init): Don't register deleted functions with
4834         gdbarch.
4835
4836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4837
4838         * rl78-tdep.c (rl78_unwind_sp): Delete.
4839         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4840
4841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4842
4843         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4844         (xstormy16_unwind_pc): Delete.
4845         (xstormy16_dummy_id): Delete.
4846         (xstormy16_gdbarch_init): Don't register deleted functions with
4847         gdbarch.
4848
4849 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4850
4851         * vax-tdep.c (vax_unwind_pc): Delete.
4852         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4853
4854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4855
4856         * v850-tdep.c (v850_unwind_sp): Delete.
4857         (v850_unwind_pc): Delete.
4858         (v850_dummy_id): Delete.
4859         (v850_gdbarch_init): Don't register deleted functions with
4860         gdbarch.
4861
4862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4863
4864         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4865         (tilegx_unwind_pc): Delete.
4866         (tilegx_unwind_dummy_id): Delete.
4867         (tilegx_gdbarch_init): Don't register deleted functions with
4868         gdbarch.
4869
4870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4871
4872         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4873         (tic6x_dummy_id): Delete.
4874         (tic6x_gdbarch_init): Don't register deleted functions with
4875         gdbarch.
4876
4877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4878
4879         * sparc-tdep.c (sparc_unwind_pc): Delete.
4880         (sparc32_gdbarch_init): Don't register deleted function with
4881         gdbarch.
4882
4883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4884
4885         * sh-tdep.c (sh_unwind_sp): Delete.
4886         (sh_unwind_pc): Delete.
4887         (sh_dummy_id): Delete.
4888         (sh_gdbarch_init): Don't register deleted functions with
4889         gdbarch.
4890
4891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4892
4893         * score-tdep.c (score_unwind_sp): Delete.
4894         (score_unwind_pc): Delete.
4895         (score_dummy_id): Delete.
4896         (score_gdbarch_init): Don't register deleted functions with
4897         gdbarch.
4898
4899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4900
4901         * rx-tdep.c (rx_unwind_pc): Delete.
4902         (rx_unwind_sp): Delete.
4903         (rx_dummy_id): Delete.
4904         (rx_gdbarch_init): Don't register deleted functions with
4905         gdbarch.  Update comment.
4906
4907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4908
4909         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4910         (rs6000_dummy_id): Delete.
4911         (rs6000_gdbarch_init): Don't register deleted functions with
4912         gdbarch.
4913
4914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4915
4916         * or1k-tdep.c (or1k_dummy_id): Delete.
4917         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4918
4919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4920
4921         * nios2-tdep.c (nios2_dummy_id): Delete.
4922         (nios2_unwind_sp): Delete.
4923         (nios2_gdbarch_init): Don't register deleted functions with
4924         gdbarch.
4925
4926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4927
4928         * nds32-tdep.c (nds32_dummy_id): Delete.
4929         (nds32_unwind_pc): Delete.
4930         (nds32_unwind_sp): Delete.
4931         (nds32_gdbarch_init): Don't register deleted functions with
4932         gdbarch.
4933
4934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4935
4936         * msp430-tdep.c (msp430_unwind_pc): Delete.
4937         (msp430_unwind_sp): Delete.
4938         (msp430_dummy_id): Delete.
4939         (msp430_gdbarch_init): Don't register deleted functions with
4940         gdbarch.
4941
4942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4943
4944         * moxie-tdep.c (moxie_unwind_sp): Delete.
4945         (moxie_unwind_pc): Delete.
4946         (moxie_dummy_id): Delete.
4947         (moxie_gdbarch_init): Don't register deleted functions with
4948         gdbarch.
4949
4950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4951
4952         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4953         (mn10300_unwind_pc): Delete.
4954         (mn10300_unwind_sp): Delete.
4955         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4956         mn10300_unwind_sp.
4957         (mn10300_frame_unwind_init): Don't register deleted functions with
4958         gdbarch.
4959
4960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4961
4962         * mep-tdep.c (mep_unwind_pc): Delete.
4963         (mep_unwind_sp): Delete.
4964         (mep_dummy_id): Delete.
4965         (mep_gdbarch_init): Don't register deleted functions with
4966         gdbarch.
4967
4968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4971         (m68hc11_unwind_sp): Delete.
4972         (m68hc11_gdbarch_init): Don't register deleted functions with
4973         gdbarch.
4974
4975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4976
4977         * m32r-tdep.c (m32r_unwind_sp): Delete.
4978         (m32r_unwind_pc): Delete.
4979         (m32r_dummy_id): Delete.
4980         (m32r_gdbarch_init): Don't register deleted functions with
4981         gdbarch.
4982
4983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4984
4985         * m32c-tdep.c (m32c_unwind_pc): Delete.
4986         (m32c_unwind_sp): Delete.
4987         (m32c_dummy_id): Delete.
4988         (m32c_gdbarch_init): Don't register deleted functions with
4989         gdbarch.
4990
4991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4992
4993         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4994         (lm32_unwind_pc): Delete.
4995         (lm32_dummy_id): Delete.
4996         (lm32_gdbarch_init): Don't register deleted functions with
4997         gdbarch.
4998
4999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5000
5001         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5002         (iq2000_unwind_pc): Delete.
5003         (iq2000_dummy_id): Delete.
5004         (iq2000_gdbarch_init): Don't register deleted functions with
5005         gdbarch.
5006
5007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5008
5009         * nds32-tdep.c (nds32_type_align): Delete.
5010         (nds32_push_dummy_call): Use type_align instead.
5011
5012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5013
5014         * arm-tdep.c (arm_type_align): Only handle vector override case.
5015         (arm_push_dummy_call): Use type_align.
5016         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5017
5018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5019
5020         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5021         case.
5022         (pass_on_stack): Use type_align.
5023         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5024         function.
5025
5026 2019-04-23  Tom Tromey  <tromey@adacore.com>
5027
5028         * dwarf2read.c (line_header::file_name_at): Remove unused
5029         overload.
5030
5031 2019-04-23  Tom de Vries  <tdevries@suse.de>
5032
5033         PR gdb/24438
5034         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5035         invocation.
5036
5037
5038 2019-03-27  Ali Tamur  <tamur@google.com>
5039
5040         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5041         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5042         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5043         (dwarf_expr_context::get_addr_index): Likewise
5044         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5045         (symbol_needs_eval_context::get_addr_index): Likewise
5046         (disassemble_dwarf_expression): Add DW_OP_addrx
5047         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5048         (read_cutu_die_from_dwo): Update comment
5049         (skip_one_die): Add DW_FORM_addrx
5050         (read_attribute_value): Likewise
5051         (var_decode_location): Add DW_OP_addrx
5052         (dwarf2_const_value_attr): Add DW_FORM_addrx
5053         (dump_die_shallow): Likewise
5054         (dwarf2_fetch_constant_bytes): Likewise
5055         (decode_locdesc): Add DW_OP_addrx
5056         (skip_form_bytes): Add DW_FORM_addrx
5057
5058 2019-04-22  Ali Tamur  <tamur@google.com>
5059
5060         * MAINTAINERS (Write After Approval): Add self.
5061
5062 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5063
5064         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5065         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5066         (open_symbol_file_object): Likewise.
5067         (svr4_default_sos): Add info parameter.
5068         (svr4_read_so_list): Likewise.
5069         (svr4_current_sos_direct): Adjust functions calls to pass down
5070         info.
5071         (svr4_current_sos_1): Add info parameter.
5072         (svr4_current_sos): Call get_svr4_info, pass info down to
5073         svr4_current_sos_1.
5074         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5075         get_svr4_info.
5076         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5077         get_svr4_info.
5078         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5079         to get_svr4_info.
5080         (probes_table_remove_objfile_probes): Likewise.
5081         (register_solib_event_probe): Add info parameter.
5082         (solist_update_incremental): Pass info parameter down to
5083         svr4_read_so_list.
5084         (disable_probes_interface): Add info parameter.
5085         (svr4_handle_solib_event): Pass current_program_space to
5086         get_svr4_info.  Adjust disable_probes_interface cleanup.
5087         (svr4_create_probe_breakpoints): Add info parameter, pass it
5088         down to register_solib_event_probe.
5089         (svr4_create_solib_event_breakpoints): Add info parameter,
5090         pass it down to svr4_create_probe_breakpoints.
5091         (enable_break): Pass info down to
5092         svr4_create_solib_event_breakpoints.
5093         (svr4_solib_create_inferior_hook): Pass current_program_space to
5094         get_svr4_info.
5095         (svr4_clear_solib): Likewise.
5096
5097 2019-04-22  Pedro Alves  <palves@redhat.com>
5098
5099         * solib-svr4.c (svr4_free_objfile_observer): New.
5100         (probe_and_action::objfile): New field.
5101         (probes_table_htab_remove_objfile_probes)
5102         (probes_table_remove_objfile_probes): New functions.
5103         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5104         in the new probe_and_action.  Don't store the probe in 'lookup'.
5105         (svr4_create_probe_breakpoints): Pass objfile to
5106         register_solib_event_probe.
5107         (_initialize_svr4_solib): Register a free_objfile observer.
5108
5109 2019-04-19  Tom Tromey  <tom@tromey.com>
5110
5111         * common/queue.h: Remove.
5112
5113 2019-04-19  Tom Tromey  <tom@tromey.com>
5114
5115         * event-loop.c: Don't include "common/queue.h".
5116
5117 2019-04-19  Tom Tromey  <tom@tromey.com>
5118
5119         * remote.c (remote_target): Use delete.
5120         * remote-notif.h: Include <list>, not "common/queue.h".
5121         (notif_client_p): Remove typedef.
5122         (remote_notif_state): Add constructor, destructor, initializer.
5123         <notif_queue>: Now a std::list.
5124         (remote_notif_state_xfree): Don't declare.
5125         * remote-notif.c (remote_notif_process, handle_notification)
5126         (remote_notif_state_allocate): Update.
5127         (~remote_notif_state): Rename from remote_notif_state_xfree.
5128
5129 2019-04-19  Tom Tromey  <tom@tromey.com>
5130
5131         * symfile.c (reread_symbols): Update.
5132         * objfiles.c (objfile_register_static_link)
5133         (objfile_lookup_static_link): Update
5134         (~objfile) Don't delete static_links.
5135         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5136
5137 2019-04-19  Tom Tromey  <tom@tromey.com>
5138
5139         * type-stack.h (struct type_stack) <insert>: Constify string.
5140         * type-stack.c (type_stack::insert): Constify string.
5141         * gdbtypes.h (lookup_template_type): Update.
5142         (address_space_name_to_int): Update.
5143         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5144         const.
5145         (lookup_template_type): Make name const.
5146         * c-exp.y: Update rules.
5147         (lex_one_token, classify_name, classify_inner_name)
5148         (c_print_token): Update.
5149         * p-exp.y: Update rules.
5150         (yylex): Update.
5151         * f-exp.y: Update rules.
5152         (yylex): Update.
5153         * d-exp.y: Update rules.
5154         (lex_one_token, classify_name, classify_inner_name): Update.
5155         * parse.c (write_dollar_variable, copy_name): Return std::string.
5156         * parser-defs.h (copy_name): Change return type.
5157         * m2-exp.y: Update rules.
5158         (yylex): Update.
5159         * go-exp.y (lex_one_token): Update.
5160         Update rules.
5161         (classify_unsafe_function, classify_packaged_name)
5162         (classify_name, yylex): Update.
5163
5164 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5165
5166         * configure.ac: add --enable-source-highlight switch.
5167         * configure: Regenerate.
5168         * top.c (print_gdb_version): plumb --enable-source-highlight
5169         status to "show configuration".
5170
5171 2019-04-19  Tom Tromey  <tromey@adacore.com>
5172
5173         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5174         Check ADA_TYPE_P.
5175         (empty_record, ada_template_to_fixed_record_type_1)
5176         (template_to_static_fixed_type)
5177         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5178         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5179         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5180         macros.
5181
5182 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5183
5184         PR symtab/24423:
5185         * source.c (print_source_lines_base): Advance "iter" when a
5186         control character is seen.
5187
5188 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5189
5190         * inferior.h (struct infcall_suspend_state_deleter):
5191         Catch exception in destructor to avoid crash.
5192
5193 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5194
5195         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5196         close to the add_com "shell".
5197
5198 2019-04-18  Tom Tromey  <tromey@adacore.com>
5199
5200         * process-stratum-target.h (class process_stratum_target)
5201         <stratum>: Add "final".
5202
5203 2019-04-17  Tom Tromey  <tromey@adacore.com>
5204
5205         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5206         against nullptr before use.
5207
5208 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5209
5210         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5211
5212 2019-04-17  Jim Wilson  <jimw@sifive.com>
5213             Andrew Burgess  <andrew.burgess@embecosm.com>
5214
5215         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5216         code read might fail, assume 4-byte breakpoint in that case.
5217
5218 2019-04-15  Leszek Swirski  <leszeks@google.com>
5219
5220         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5221         rather than a hand-rolled POD check when checking for forced MEMORY
5222         classification.
5223
5224 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5225
5226         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5227         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5228         function.
5229         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5230         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5231         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5232         declaration.
5233
5234 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5235
5236         * aarch64-linux-nat.c
5237         (aarch64_linux_nat_target::thread_architecture): Add override.
5238         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5239         each VQ.
5240
5241 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5242
5243         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5244
5245 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5246
5247         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5248         target types of size 96-bits, add some additional comments, and
5249         check that the builtin type we found was the correct size.
5250
5251 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5252
5253         * utils.c (prompt_for_continue): Don't restore the styling at the
5254         end, as applied_style has the wrong value.  This fixes styling in
5255         long lists of file names that are interrupted by the "Continue?"
5256         prompt.
5257
5258 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5259
5260         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5261         * c-lang.c (c_language_defn): Likewise.
5262         (cplus_language_defn): Likewise.
5263         (asm_language_defn): Likewise.
5264         (minimal_language_defn): Likewise.
5265         * d-lang.c (d_language_defn): Likewise.
5266         * f-lang.c (f_language_defn): Likewise.
5267         * go-lang.c (go_language_defn): Likewise.
5268         * language.c (unknown_language_defn): Likewise.
5269         (auto_language_defn): Likewise.
5270         * language.h (struct language_defn): Remove la_magic field.
5271         (LANG_MAGIC): Delete.
5272         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5273         * objc-lang.c (objc_language_defn): Likewise.
5274         * opencl-lang.c (opencl_language_defn): Likewise.
5275         * p-lang.c (pascal_language_defn): Likewise.
5276         * rust-lang.c (rust_language_defn): Likewise.
5277
5278 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5279
5280         * riscv-tdep.c (riscv_type_align): New function.
5281         (riscv_type_alignment): Delete.
5282         (riscv_arg_location): Use 'type_align'.
5283         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5284
5285 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5286
5287         * gdbtypes.c (type_align): A struct with no non-static fields also
5288         has alignment of 1.
5289
5290 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5291
5292         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5293         component to 0.
5294         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5295         member.
5296         (riscv_struct_info::analyse): New implementation using new
5297         analyse_inner member function.
5298         (riscv_struct_info::field_offset): New member function.
5299         (riscv_struct_info::m_offsets): New member variable.
5300         (riscv_struct_info::analyse_inner): New private member function,
5301         takes the old implementation of riscv_struct_info::analyse but
5302         extended to track field offsets.
5303         (riscv_call_arg_struct): Update the struct folding special cases
5304         to handle cases where empty C++ structs, which are non-zero
5305         length, are found.
5306         (riscv_arg_location): Initialise the length of each location, a
5307         non-zero length now indicates the location is in use.
5308         (riscv_push_dummy_call): Allow for the first location having a
5309         non-zero offset when setting up arguments.
5310         (riscv_return_value): Likewise, but for return values.
5311
5312 2019-04-11  Tom Tromey  <tromey@adacore.com>
5313
5314         * utils.c (internal_vproblem): Make "msg" const.
5315
5316 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5317
5318         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5319         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5320         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5321         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5322
5323 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5324
5325         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5326         function.
5327         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5328         of amd64_collect_native_gregset.
5329         (amd64_linux_nat_target::store_registers): Likewise.
5330
5331 2019-04-10  Tom Tromey  <tom@tromey.com>
5332
5333         * symtab.c (lookup_global_symbol_from_objfile)
5334         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5335         * objfiles.h (class separate_debug_iterator): New.
5336         (class separate_debug_range): New.
5337         (struct objfile) <separate_debug_objfiles>: New method.
5338         (objfile_separate_debug_iterate): Don't declare.
5339         * objfiles.c (separate_debug_iterator::operator++): Rename from
5340         objfile_separate_debug_iterate.
5341         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5342         iterator.
5343         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5344         iterator.
5345
5346 2019-04-10  Tom Tromey  <tom@tromey.com>
5347
5348         * symfile.c (reread_symbols): Remove old comment.
5349         * objfiles.c (free_all_objfiles): Fix a typo.
5350
5351 2019-04-10  Tom Tromey  <tom@tromey.com>
5352
5353         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5354         * minsyms.c (lookup_minimal_symbol): Use foreach.
5355         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5356         (lookup_minimal_symbol_solib_trampoline): Likewise.
5357         * symfile.c (reread_symbols): Use foreach.
5358
5359 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5360             Tom Tromey  <tromey@adacore.com>
5361
5362         PR rust/24414:
5363         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5364         (rust_lex_int_test): Change "value" to be LONGEST.
5365         (rust_lex_tests): Add test for long integer literal.
5366
5367 2019-04-09  Tom Tromey  <tromey@adacore.com>
5368
5369         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5370         to bool.
5371         (extended_remote_target::attach): Update.
5372         (remote_target::remote_notice_new_inferior): Update.
5373         (remote_target::add_current_inferior_and_thread): Update.
5374         * inferior.c (exit_inferior_1): Use "false".
5375         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5376
5377 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5378
5379         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5380         the "start" command.
5381
5382 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5383
5384         * python/py-inferior.c (infpy_thread_from_thread_handle):
5385         Adjust comments to reflect renaming of thread_from_thread_handle
5386         to thread_from_handle.  Adjust keywords.  Fix type error message.
5387         (inferior_object_methods): Add thread_from_handle.  Retain
5388         thread_from_thread_handle, but mark it as deprecated.
5389
5390 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5391
5392         * gdbthread.h (find_thread_by_handle): Revise declaration.
5393         * thread.c (find_thread_by_handle): Likewise.  Adjust
5394         implementation too.
5395         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5396         support for buffer objects as handles.
5397
5398 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5399
5400         * python/py-infthread.c (thpy_thread_handle): New function.
5401         (thread_object_methods): Register thpy_thread_handle.
5402
5403 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5404
5405         * gdbthread.h (thread_to_thread_handle): Declare.
5406         * thread.c (gdbtypes.h): Include.
5407         (thread_to_thread_handle): New function.
5408
5409         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5410         (target_thread_info_to_thread_handle): Declare.
5411         * target.c (target_thread_info_to_thread_handle): New function.
5412         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5413         * target-delegates.c: Regenerate.
5414
5415         * linux-thread-db.c (class thread_db_target): Add method
5416         thread_info_to_thread_handle.
5417         (thread_db_target::thread_info_to_thread_handle): Define.
5418         * remote.c (class remote_target): Add new method
5419         thread_info_to_thread_handle.
5420         (remote_target::thread_info_to_thread_handle): Define.
5421
5422 2019-04-08  Pedro Alves  <palves@redhat.com>
5423
5424         * common/common-exceptions.c (throw_exception): Don't create
5425         named object to throw; throw directly.
5426         (throw_it): Likewise.  Don't initialize gdb_exception::message
5427         here, with new; pass FMT and AP to the ctor instead.
5428         * common/common-exceptions.h: Include <string>.
5429         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5430         const char *, va_list)): New ctor.  Use std::make_shared.
5431         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5432         errors)): Delete.
5433         (gdb_exception_error::gdb_exception_error(enum errors, const char
5434         *, va_list)): New.
5435         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5436         Add assertion.
5437         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5438         errors)): Delete.
5439         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5440         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5441         Add assertion.
5442
5443 2019-04-08  Tom Tromey  <tom@tromey.com>
5444
5445         * valops.c (value_rtti_indirect_type): Replace throw_exception
5446         with throw.
5447         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5448         with throw.
5449         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5450         throw.
5451         * target.c (target_translate_tls_address): Replace throw_exception
5452         with throw.
5453         * stack.c (frame_apply_command_count): Replace throw_exception
5454         with throw.
5455         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5456         throw.
5457         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5458         with throw.
5459         * rs6000-tdep.c (rs6000_frame_cache)
5460         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5461         * remote.c: Replace throw_exception with throw.
5462         * record-full.c (record_full_message, record_full_wait_1)
5463         (record_full_restore): Replace throw_exception with throw.
5464         * record-btrace.c:
5465         (get_thread_current_frame_id, record_btrace_start_replaying)
5466         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5467         (cmd_record_btrace_start): Replace throw_exception with throw.
5468         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5469         throw.
5470         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5471         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5472         * linespec.c:
5473         (find_linespec_symbols): Replace throw_exception with throw.
5474         * infrun.c (displaced_step_prepare, resume): Replace
5475         throw_exception with throw.
5476         * infcmd.c (post_create_inferior): Replace throw_exception with
5477         throw.
5478         * inf-loop.c (inferior_event_handler): Replace throw_exception
5479         with throw.
5480         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5481         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5482         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5483         (get_prev_frame_always, get_frame_pc_if_available)
5484         (get_frame_address_in_block_if_available, get_frame_language):
5485         Replace throw_exception with throw.
5486         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5487         throw_exception with throw.
5488         * eval.c (fetch_subexp_value, evaluate_var_value)
5489         (evaluate_funcall, evaluate_subexp_standard): Replace
5490         throw_exception with throw.
5491         * dwarf2loc.c (call_site_find_chain)
5492         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5493         Replace throw_exception with throw.
5494         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5495         with throw.
5496         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5497         throw.
5498         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5499         * completer.c (complete_line_internal): Replace throw_exception
5500         with throw.
5501         * compile/compile-object-run.c (compile_object_run): Replace
5502         throw_exception with throw.
5503         * cli/cli-script.c (process_next_line): Replace throw_exception
5504         with throw.
5505         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5506         (btrace_enable, btrace_maint_update_pt_packets): Replace
5507         throw_exception with throw.
5508         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5509         throw_exception with throw.
5510         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5511         throw_exception with throw.
5512         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5513         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5514         * aarch64-tdep.c (aarch64_make_prologue_cache)
5515         (aarch64_make_stub_cache): Replace throw_exception with throw.
5516
5517 2019-04-08  Tom Tromey  <tom@tromey.com>
5518
5519         * common/common-exceptions.c (throw_exception): Rename from
5520         throw_exception_cxx.  Remove old copy.  Make argument const.
5521         (throw_it): Create and throw exception objects directly.
5522         * common/common-exceptions.h (throw_exception): Make argument
5523         const.
5524         (struct gdb_exception_error): Add constructor.
5525         (struct gdb_exception_quit): Add constructor.
5526
5527 2019-04-08  Tom Tromey  <tom@tromey.com>
5528
5529         * common/common-exceptions.h (exception_rethrow): Don't declare.
5530         (TRY_SJLJ): Update comment.
5531         (TRY, CATCH, END_CATCH): Remove.
5532         * common/common-exceptions.c (exception_rethrow): Remove.
5533
5534 2019-04-08  Tom Tromey  <tom@tromey.com>
5535
5536         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5537         Remove.
5538         (gdb_exception_error): Rename from
5539         gdb_exception_RETURN_MASK_ERROR.
5540         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5541         (gdb_quit_bad_alloc): Update.
5542         * aarch64-tdep.c: Update.
5543         * ada-lang.c: Update.
5544         * ada-typeprint.c: Update.
5545         * ada-valprint.c: Update.
5546         * amd64-tdep.c: Update.
5547         * arch-utils.c: Update.
5548         * break-catch-throw.c: Update.
5549         * breakpoint.c: Update.
5550         * btrace.c: Update.
5551         * c-varobj.c: Update.
5552         * cli/cli-cmds.c: Update.
5553         * cli/cli-interp.c: Update.
5554         * cli/cli-script.c: Update.
5555         * common/common-exceptions.c: Update.
5556         * common/new-op.c: Update.
5557         * common/selftest.c: Update.
5558         * compile/compile-c-symbols.c: Update.
5559         * compile/compile-cplus-symbols.c: Update.
5560         * compile/compile-object-load.c: Update.
5561         * compile/compile-object-run.c: Update.
5562         * completer.c: Update.
5563         * corelow.c: Update.
5564         * cp-abi.c: Update.
5565         * cp-support.c: Update.
5566         * cp-valprint.c: Update.
5567         * darwin-nat.c: Update.
5568         * disasm-selftests.c: Update.
5569         * dtrace-probe.c: Update.
5570         * dwarf-index-cache.c: Update.
5571         * dwarf-index-write.c: Update.
5572         * dwarf2-frame-tailcall.c: Update.
5573         * dwarf2-frame.c: Update.
5574         * dwarf2loc.c: Update.
5575         * dwarf2read.c: Update.
5576         * eval.c: Update.
5577         * event-loop.c: Update.
5578         * event-top.c: Update.
5579         * exec.c: Update.
5580         * f-valprint.c: Update.
5581         * fbsd-tdep.c: Update.
5582         * frame-unwind.c: Update.
5583         * frame.c: Update.
5584         * gdbtypes.c: Update.
5585         * gnu-v3-abi.c: Update.
5586         * guile/guile-internal.h: Update.
5587         * guile/scm-block.c: Update.
5588         * guile/scm-breakpoint.c: Update.
5589         * guile/scm-cmd.c: Update.
5590         * guile/scm-disasm.c: Update.
5591         * guile/scm-frame.c: Update.
5592         * guile/scm-lazy-string.c: Update.
5593         * guile/scm-math.c: Update.
5594         * guile/scm-param.c: Update.
5595         * guile/scm-ports.c: Update.
5596         * guile/scm-pretty-print.c: Update.
5597         * guile/scm-symbol.c: Update.
5598         * guile/scm-symtab.c: Update.
5599         * guile/scm-type.c: Update.
5600         * guile/scm-value.c: Update.
5601         * i386-linux-tdep.c: Update.
5602         * i386-tdep.c: Update.
5603         * inf-loop.c: Update.
5604         * infcall.c: Update.
5605         * infcmd.c: Update.
5606         * infrun.c: Update.
5607         * jit.c: Update.
5608         * language.c: Update.
5609         * linespec.c: Update.
5610         * linux-fork.c: Update.
5611         * linux-nat.c: Update.
5612         * linux-tdep.c: Update.
5613         * linux-thread-db.c: Update.
5614         * main.c: Update.
5615         * mi/mi-cmd-break.c: Update.
5616         * mi/mi-cmd-stack.c: Update.
5617         * mi/mi-interp.c: Update.
5618         * mi/mi-main.c: Update.
5619         * objc-lang.c: Update.
5620         * p-valprint.c: Update.
5621         * parse.c: Update.
5622         * ppc-linux-tdep.c: Update.
5623         * printcmd.c: Update.
5624         * python/py-arch.c: Update.
5625         * python/py-breakpoint.c: Update.
5626         * python/py-cmd.c: Update.
5627         * python/py-finishbreakpoint.c: Update.
5628         * python/py-frame.c: Update.
5629         * python/py-framefilter.c: Update.
5630         * python/py-gdb-readline.c: Update.
5631         * python/py-inferior.c: Update.
5632         * python/py-infthread.c: Update.
5633         * python/py-lazy-string.c: Update.
5634         * python/py-linetable.c: Update.
5635         * python/py-objfile.c: Update.
5636         * python/py-param.c: Update.
5637         * python/py-prettyprint.c: Update.
5638         * python/py-progspace.c: Update.
5639         * python/py-record-btrace.c: Update.
5640         * python/py-record.c: Update.
5641         * python/py-symbol.c: Update.
5642         * python/py-type.c: Update.
5643         * python/py-unwind.c: Update.
5644         * python/py-utils.c: Update.
5645         * python/py-value.c: Update.
5646         * python/python.c: Update.
5647         * record-btrace.c: Update.
5648         * record-full.c: Update.
5649         * remote-fileio.c: Update.
5650         * remote.c: Update.
5651         * riscv-tdep.c: Update.
5652         * rs6000-aix-tdep.c: Update.
5653         * rs6000-tdep.c: Update.
5654         * rust-exp.y: Update.
5655         * rust-lang.c: Update.
5656         * s390-tdep.c: Update.
5657         * selftest-arch.c: Update.
5658         * solib-dsbt.c: Update.
5659         * solib-frv.c: Update.
5660         * solib-spu.c: Update.
5661         * solib-svr4.c: Update.
5662         * solib.c: Update.
5663         * sparc64-linux-tdep.c: Update.
5664         * stack.c: Update.
5665         * symfile-mem.c: Update.
5666         * symmisc.c: Update.
5667         * target.c: Update.
5668         * thread.c: Update.
5669         * top.c: Update.
5670         * tracefile-tfile.c: Update.
5671         * tui/tui.c: Update.
5672         * typeprint.c: Update.
5673         * unittests/cli-utils-selftests.c: Update.
5674         * unittests/parse-connection-spec-selftests.c: Update.
5675         * valops.c: Update.
5676         * valprint.c: Update.
5677         * value.c: Update.
5678         * varobj.c: Update.
5679         * windows-nat.c: Update.
5680         * x86-linux-nat.c: Update.
5681         * xml-support.c: Update.
5682
5683 2019-04-08  Tom Tromey  <tom@tromey.com>
5684
5685         * xml-support.c: Use C++ exception handling.
5686         * x86-linux-nat.c: Use C++ exception handling.
5687         * windows-nat.c: Use C++ exception handling.
5688         * varobj.c: Use C++ exception handling.
5689         * value.c: Use C++ exception handling.
5690         * valprint.c: Use C++ exception handling.
5691         * valops.c: Use C++ exception handling.
5692         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5693         handling.
5694         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5695         * typeprint.c: Use C++ exception handling.
5696         * tui/tui.c: Use C++ exception handling.
5697         * tracefile-tfile.c: Use C++ exception handling.
5698         * top.c: Use C++ exception handling.
5699         * thread.c: Use C++ exception handling.
5700         * target.c: Use C++ exception handling.
5701         * symmisc.c: Use C++ exception handling.
5702         * symfile-mem.c: Use C++ exception handling.
5703         * stack.c: Use C++ exception handling.
5704         * sparc64-linux-tdep.c: Use C++ exception handling.
5705         * solib.c: Use C++ exception handling.
5706         * solib-svr4.c: Use C++ exception handling.
5707         * solib-spu.c: Use C++ exception handling.
5708         * solib-frv.c: Use C++ exception handling.
5709         * solib-dsbt.c: Use C++ exception handling.
5710         * selftest-arch.c: Use C++ exception handling.
5711         * s390-tdep.c: Use C++ exception handling.
5712         * rust-lang.c: Use C++ exception handling.
5713         * rust-exp.y: Use C++ exception handling.
5714         * rs6000-tdep.c: Use C++ exception handling.
5715         * rs6000-aix-tdep.c: Use C++ exception handling.
5716         * riscv-tdep.c: Use C++ exception handling.
5717         * remote.c: Use C++ exception handling.
5718         * remote-fileio.c: Use C++ exception handling.
5719         * record-full.c: Use C++ exception handling.
5720         * record-btrace.c: Use C++ exception handling.
5721         * python/python.c: Use C++ exception handling.
5722         * python/py-value.c: Use C++ exception handling.
5723         * python/py-utils.c: Use C++ exception handling.
5724         * python/py-unwind.c: Use C++ exception handling.
5725         * python/py-type.c: Use C++ exception handling.
5726         * python/py-symbol.c: Use C++ exception handling.
5727         * python/py-record.c: Use C++ exception handling.
5728         * python/py-record-btrace.c: Use C++ exception handling.
5729         * python/py-progspace.c: Use C++ exception handling.
5730         * python/py-prettyprint.c: Use C++ exception handling.
5731         * python/py-param.c: Use C++ exception handling.
5732         * python/py-objfile.c: Use C++ exception handling.
5733         * python/py-linetable.c: Use C++ exception handling.
5734         * python/py-lazy-string.c: Use C++ exception handling.
5735         * python/py-infthread.c: Use C++ exception handling.
5736         * python/py-inferior.c: Use C++ exception handling.
5737         * python/py-gdb-readline.c: Use C++ exception handling.
5738         * python/py-framefilter.c: Use C++ exception handling.
5739         * python/py-frame.c: Use C++ exception handling.
5740         * python/py-finishbreakpoint.c: Use C++ exception handling.
5741         * python/py-cmd.c: Use C++ exception handling.
5742         * python/py-breakpoint.c: Use C++ exception handling.
5743         * python/py-arch.c: Use C++ exception handling.
5744         * printcmd.c: Use C++ exception handling.
5745         * ppc-linux-tdep.c: Use C++ exception handling.
5746         * parse.c: Use C++ exception handling.
5747         * p-valprint.c: Use C++ exception handling.
5748         * objc-lang.c: Use C++ exception handling.
5749         * mi/mi-main.c: Use C++ exception handling.
5750         * mi/mi-interp.c: Use C++ exception handling.
5751         * mi/mi-cmd-stack.c: Use C++ exception handling.
5752         * mi/mi-cmd-break.c: Use C++ exception handling.
5753         * main.c: Use C++ exception handling.
5754         * linux-thread-db.c: Use C++ exception handling.
5755         * linux-tdep.c: Use C++ exception handling.
5756         * linux-nat.c: Use C++ exception handling.
5757         * linux-fork.c: Use C++ exception handling.
5758         * linespec.c: Use C++ exception handling.
5759         * language.c: Use C++ exception handling.
5760         * jit.c: Use C++ exception handling.
5761         * infrun.c: Use C++ exception handling.
5762         * infcmd.c: Use C++ exception handling.
5763         * infcall.c: Use C++ exception handling.
5764         * inf-loop.c: Use C++ exception handling.
5765         * i386-tdep.c: Use C++ exception handling.
5766         * i386-linux-tdep.c: Use C++ exception handling.
5767         * guile/scm-value.c: Use C++ exception handling.
5768         * guile/scm-type.c: Use C++ exception handling.
5769         * guile/scm-symtab.c: Use C++ exception handling.
5770         * guile/scm-symbol.c: Use C++ exception handling.
5771         * guile/scm-pretty-print.c: Use C++ exception handling.
5772         * guile/scm-ports.c: Use C++ exception handling.
5773         * guile/scm-param.c: Use C++ exception handling.
5774         * guile/scm-math.c: Use C++ exception handling.
5775         * guile/scm-lazy-string.c: Use C++ exception handling.
5776         * guile/scm-frame.c: Use C++ exception handling.
5777         * guile/scm-disasm.c: Use C++ exception handling.
5778         * guile/scm-cmd.c: Use C++ exception handling.
5779         * guile/scm-breakpoint.c: Use C++ exception handling.
5780         * guile/scm-block.c: Use C++ exception handling.
5781         * guile/guile-internal.h: Use C++ exception handling.
5782         * gnu-v3-abi.c: Use C++ exception handling.
5783         * gdbtypes.c: Use C++ exception handling.
5784         * frame.c: Use C++ exception handling.
5785         * frame-unwind.c: Use C++ exception handling.
5786         * fbsd-tdep.c: Use C++ exception handling.
5787         * f-valprint.c: Use C++ exception handling.
5788         * exec.c: Use C++ exception handling.
5789         * event-top.c: Use C++ exception handling.
5790         * event-loop.c: Use C++ exception handling.
5791         * eval.c: Use C++ exception handling.
5792         * dwarf2read.c: Use C++ exception handling.
5793         * dwarf2loc.c: Use C++ exception handling.
5794         * dwarf2-frame.c: Use C++ exception handling.
5795         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5796         * dwarf-index-write.c: Use C++ exception handling.
5797         * dwarf-index-cache.c: Use C++ exception handling.
5798         * dtrace-probe.c: Use C++ exception handling.
5799         * disasm-selftests.c: Use C++ exception handling.
5800         * darwin-nat.c: Use C++ exception handling.
5801         * cp-valprint.c: Use C++ exception handling.
5802         * cp-support.c: Use C++ exception handling.
5803         * cp-abi.c: Use C++ exception handling.
5804         * corelow.c: Use C++ exception handling.
5805         * completer.c: Use C++ exception handling.
5806         * compile/compile-object-run.c: Use C++ exception handling.
5807         * compile/compile-object-load.c: Use C++ exception handling.
5808         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5809         * compile/compile-c-symbols.c: Use C++ exception handling.
5810         * common/selftest.c: Use C++ exception handling.
5811         * common/new-op.c: Use C++ exception handling.
5812         * cli/cli-script.c: Use C++ exception handling.
5813         * cli/cli-interp.c: Use C++ exception handling.
5814         * cli/cli-cmds.c: Use C++ exception handling.
5815         * c-varobj.c: Use C++ exception handling.
5816         * btrace.c: Use C++ exception handling.
5817         * breakpoint.c: Use C++ exception handling.
5818         * break-catch-throw.c: Use C++ exception handling.
5819         * arch-utils.c: Use C++ exception handling.
5820         * amd64-tdep.c: Use C++ exception handling.
5821         * ada-valprint.c: Use C++ exception handling.
5822         * ada-typeprint.c: Use C++ exception handling.
5823         * ada-lang.c: Use C++ exception handling.
5824         * aarch64-tdep.c: Use C++ exception handling.
5825
5826 2019-04-08  Tom Tromey  <tom@tromey.com>
5827
5828         * xml-support.c (gdb_xml_parser::parse): Update.
5829         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5830         * value.c (show_convenience): Update.
5831         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5832         (test_parse_flags_qcs): Update.
5833         * thread.c (thr_try_catch_cmd): Update.
5834         * target.c (target_translate_tls_address): Update.
5835         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5836         (info_frame_command_core, frame_apply_command_count): Update.
5837         * rust-exp.y (rust_lex_exception_test): Update.
5838         * riscv-tdep.c (riscv_print_one_register_info): Update.
5839         * remote.c (remote_target::enable_btrace): Update.
5840         * record-btrace.c (record_btrace_enable_warn): Update.
5841         * python/py-utils.c (gdbpy_convert_exception): Update.
5842         * printcmd.c (do_one_display, print_variable_and_value): Update.
5843         * mi/mi-main.c (mi_print_exception): Update.
5844         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5845         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5846         * linux-nat.c (linux_nat_target::attach): Update.
5847         * linux-fork.c (class scoped_switch_fork_info): Update.
5848         * infrun.c (displaced_step_prepare): Update.
5849         * infcall.c (call_function_by_hand_dummy): Update.
5850         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5851         * gnu-v3-abi.c (print_one_vtable): Update.
5852         * frame.c (get_prev_frame_always): Update.
5853         * f-valprint.c (info_common_command_for_block): Update.
5854         * exec.c (try_open_exec_file): Update.
5855         * exceptions.c (print_exception, exception_print)
5856         (exception_fprintf, exception_print_same): Update.
5857         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5858         * dwarf-index-cache.c (index_cache::store)
5859         (index_cache::lookup_gdb_index): Update.
5860         * darwin-nat.c (maybe_cache_shell): Update.
5861         * cp-valprint.c (cp_print_value_fields): Update.
5862         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5863         (gcc_cplus_symbol_address): Update.
5864         * compile/compile-c-symbols.c (gcc_convert_symbol)
5865         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5866         * common/selftest.c: Update.
5867         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5868         a std::string.
5869         (exception_try_scope_entry, exception_try_scope_exit): Don't
5870         declare.
5871         (struct exception_try_scope): Remove.
5872         (TRY): Don't use exception_try_scope.
5873         (struct gdb_exception): Add constructor, operator=.
5874         <what>: New method.
5875         (struct gdb_exception_RETURN_MASK_ALL)
5876         (struct gdb_exception_RETURN_MASK_ERROR)
5877         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5878         (struct gdb_quit_bad_alloc): Update.
5879         * common/common-exceptions.c (exception_none): Change
5880         initializer.
5881         (struct catcher) <state, exception>: Initialize inline.
5882         <prev>: Remove member.
5883         (current_catcher): Remove.
5884         (catchers): New global.
5885         (exceptions_state_mc_init): Simplify.
5886         (catcher_pop): Remove.
5887         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5888         (try_scope_depth, exception_try_scope_entry)
5889         (exception_try_scope_exit): Remove.
5890         (throw_exception_sjlj): Update.
5891         (exception_messages, exception_messages_size): Remove.
5892         (throw_it): Simplify.
5893         (gdb_exception_sliced_copy): Remove.
5894         (throw_exception_cxx): Update.
5895         * cli/cli-script.c (script_from_file): Update.
5896         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5897         Update.
5898         * ada-valprint.c (ada_val_print): Update.
5899         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5900         (create_excep_cond_exprs): Update.
5901
5902 2019-04-08  Tom Tromey  <tom@tromey.com>
5903
5904         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5905         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5906         (TRY, CATCH, END_CATCH): Remove some definitions.
5907         * common/common-exceptions.c: Don't use GDB_XCPT.
5908         (catcher_list_size): Remove.
5909         (throw_exception, throw_it): Simplify.
5910
5911 2019-04-05  Tom Tromey  <tom@tromey.com>
5912
5913         Revert the header-sorting patch.
5914         * ft32-tdep.c: Revert.
5915         * frv-tdep.c: Revert.
5916         * frv-linux-tdep.c: Revert.
5917         * frame.c: Revert.
5918         * frame-unwind.c: Revert.
5919         * frame-base.c: Revert.
5920         * fork-child.c: Revert.
5921         * findvar.c: Revert.
5922         * findcmd.c: Revert.
5923         * filesystem.c: Revert.
5924         * filename-seen-cache.h: Revert.
5925         * filename-seen-cache.c: Revert.
5926         * fbsd-tdep.c: Revert.
5927         * fbsd-nat.h: Revert.
5928         * fbsd-nat.c: Revert.
5929         * f-valprint.c: Revert.
5930         * f-typeprint.c: Revert.
5931         * f-lang.c: Revert.
5932         * extension.h: Revert.
5933         * extension.c: Revert.
5934         * extension-priv.h: Revert.
5935         * expprint.c: Revert.
5936         * exec.h: Revert.
5937         * exec.c: Revert.
5938         * exceptions.c: Revert.
5939         * event-top.c: Revert.
5940         * event-loop.c: Revert.
5941         * eval.c: Revert.
5942         * elfread.c: Revert.
5943         * dwarf2read.h: Revert.
5944         * dwarf2read.c: Revert.
5945         * dwarf2loc.c: Revert.
5946         * dwarf2expr.h: Revert.
5947         * dwarf2expr.c: Revert.
5948         * dwarf2-frame.c: Revert.
5949         * dwarf2-frame-tailcall.c: Revert.
5950         * dwarf-index-write.h: Revert.
5951         * dwarf-index-write.c: Revert.
5952         * dwarf-index-common.c: Revert.
5953         * dwarf-index-cache.h: Revert.
5954         * dwarf-index-cache.c: Revert.
5955         * dummy-frame.c: Revert.
5956         * dtrace-probe.c: Revert.
5957         * disasm.h: Revert.
5958         * disasm.c: Revert.
5959         * disasm-selftests.c: Revert.
5960         * dictionary.c: Revert.
5961         * dicos-tdep.c: Revert.
5962         * demangle.c: Revert.
5963         * dcache.h: Revert.
5964         * dcache.c: Revert.
5965         * darwin-nat.h: Revert.
5966         * darwin-nat.c: Revert.
5967         * darwin-nat-info.c: Revert.
5968         * d-valprint.c: Revert.
5969         * d-namespace.c: Revert.
5970         * d-lang.c: Revert.
5971         * ctf.c: Revert.
5972         * csky-tdep.c: Revert.
5973         * csky-linux-tdep.c: Revert.
5974         * cris-tdep.c: Revert.
5975         * cris-linux-tdep.c: Revert.
5976         * cp-valprint.c: Revert.
5977         * cp-support.c: Revert.
5978         * cp-namespace.c: Revert.
5979         * cp-abi.c: Revert.
5980         * corelow.c: Revert.
5981         * corefile.c: Revert.
5982         * continuations.c: Revert.
5983         * completer.h: Revert.
5984         * completer.c: Revert.
5985         * complaints.c: Revert.
5986         * coffread.c: Revert.
5987         * coff-pe-read.c: Revert.
5988         * cli-out.h: Revert.
5989         * cli-out.c: Revert.
5990         * charset.c: Revert.
5991         * c-varobj.c: Revert.
5992         * c-valprint.c: Revert.
5993         * c-typeprint.c: Revert.
5994         * c-lang.c: Revert.
5995         * buildsym.c: Revert.
5996         * buildsym-legacy.c: Revert.
5997         * build-id.h: Revert.
5998         * build-id.c: Revert.
5999         * btrace.c: Revert.
6000         * bsd-uthread.c: Revert.
6001         * breakpoint.h: Revert.
6002         * breakpoint.c: Revert.
6003         * break-catch-throw.c: Revert.
6004         * break-catch-syscall.c: Revert.
6005         * break-catch-sig.c: Revert.
6006         * blockframe.c: Revert.
6007         * block.c: Revert.
6008         * bfin-tdep.c: Revert.
6009         * bfin-linux-tdep.c: Revert.
6010         * bfd-target.c: Revert.
6011         * bcache.c: Revert.
6012         * ax-general.c: Revert.
6013         * ax-gdb.h: Revert.
6014         * ax-gdb.c: Revert.
6015         * avr-tdep.c: Revert.
6016         * auxv.c: Revert.
6017         * auto-load.c: Revert.
6018         * arm-wince-tdep.c: Revert.
6019         * arm-tdep.c: Revert.
6020         * arm-symbian-tdep.c: Revert.
6021         * arm-pikeos-tdep.c: Revert.
6022         * arm-obsd-tdep.c: Revert.
6023         * arm-nbsd-tdep.c: Revert.
6024         * arm-nbsd-nat.c: Revert.
6025         * arm-linux-tdep.c: Revert.
6026         * arm-linux-nat.c: Revert.
6027         * arm-fbsd-tdep.c: Revert.
6028         * arm-fbsd-nat.c: Revert.
6029         * arm-bsd-tdep.c: Revert.
6030         * arch-utils.c: Revert.
6031         * arc-tdep.c: Revert.
6032         * arc-newlib-tdep.c: Revert.
6033         * annotate.h: Revert.
6034         * annotate.c: Revert.
6035         * amd64-windows-tdep.c: Revert.
6036         * amd64-windows-nat.c: Revert.
6037         * amd64-tdep.c: Revert.
6038         * amd64-sol2-tdep.c: Revert.
6039         * amd64-obsd-tdep.c: Revert.
6040         * amd64-obsd-nat.c: Revert.
6041         * amd64-nbsd-tdep.c: Revert.
6042         * amd64-nbsd-nat.c: Revert.
6043         * amd64-nat.c: Revert.
6044         * amd64-linux-tdep.c: Revert.
6045         * amd64-linux-nat.c: Revert.
6046         * amd64-fbsd-tdep.c: Revert.
6047         * amd64-fbsd-nat.c: Revert.
6048         * amd64-dicos-tdep.c: Revert.
6049         * amd64-darwin-tdep.c: Revert.
6050         * amd64-bsd-nat.c: Revert.
6051         * alpha-tdep.c: Revert.
6052         * alpha-obsd-tdep.c: Revert.
6053         * alpha-nbsd-tdep.c: Revert.
6054         * alpha-mdebug-tdep.c: Revert.
6055         * alpha-linux-tdep.c: Revert.
6056         * alpha-linux-nat.c: Revert.
6057         * alpha-bsd-tdep.c: Revert.
6058         * alpha-bsd-nat.c: Revert.
6059         * aix-thread.c: Revert.
6060         * agent.c: Revert.
6061         * addrmap.c: Revert.
6062         * ada-varobj.c: Revert.
6063         * ada-valprint.c: Revert.
6064         * ada-typeprint.c: Revert.
6065         * ada-tasks.c: Revert.
6066         * ada-lang.c: Revert.
6067         * aarch64-tdep.c: Revert.
6068         * aarch64-ravenscar-thread.c: Revert.
6069         * aarch64-newlib-tdep.c: Revert.
6070         * aarch64-linux-tdep.c: Revert.
6071         * aarch64-linux-nat.c: Revert.
6072         * aarch64-fbsd-tdep.c: Revert.
6073         * aarch64-fbsd-nat.c: Revert.
6074         * aarch32-linux-nat.c: Revert.
6075
6076 2019-04-05  Tom Tromey  <tom@tromey.com>
6077
6078         * ft32-tdep.c: Sort headers.
6079         * frv-tdep.c: Sort headers.
6080         * frv-linux-tdep.c: Sort headers.
6081         * frame.c: Sort headers.
6082         * frame-unwind.c: Sort headers.
6083         * frame-base.c: Sort headers.
6084         * fork-child.c: Sort headers.
6085         * findvar.c: Sort headers.
6086         * findcmd.c: Sort headers.
6087         * filesystem.c: Sort headers.
6088         * filename-seen-cache.h: Sort headers.
6089         * filename-seen-cache.c: Sort headers.
6090         * fbsd-tdep.c: Sort headers.
6091         * fbsd-nat.h: Sort headers.
6092         * fbsd-nat.c: Sort headers.
6093         * f-valprint.c: Sort headers.
6094         * f-typeprint.c: Sort headers.
6095         * f-lang.c: Sort headers.
6096         * extension.h: Sort headers.
6097         * extension.c: Sort headers.
6098         * extension-priv.h: Sort headers.
6099         * expprint.c: Sort headers.
6100         * exec.h: Sort headers.
6101         * exec.c: Sort headers.
6102         * exceptions.c: Sort headers.
6103         * event-top.c: Sort headers.
6104         * event-loop.c: Sort headers.
6105         * eval.c: Sort headers.
6106         * elfread.c: Sort headers.
6107         * dwarf2read.h: Sort headers.
6108         * dwarf2read.c: Sort headers.
6109         * dwarf2loc.c: Sort headers.
6110         * dwarf2expr.h: Sort headers.
6111         * dwarf2expr.c: Sort headers.
6112         * dwarf2-frame.c: Sort headers.
6113         * dwarf2-frame-tailcall.c: Sort headers.
6114         * dwarf-index-write.h: Sort headers.
6115         * dwarf-index-write.c: Sort headers.
6116         * dwarf-index-common.c: Sort headers.
6117         * dwarf-index-cache.h: Sort headers.
6118         * dwarf-index-cache.c: Sort headers.
6119         * dummy-frame.c: Sort headers.
6120         * dtrace-probe.c: Sort headers.
6121         * disasm.h: Sort headers.
6122         * disasm.c: Sort headers.
6123         * disasm-selftests.c: Sort headers.
6124         * dictionary.c: Sort headers.
6125         * dicos-tdep.c: Sort headers.
6126         * demangle.c: Sort headers.
6127         * dcache.h: Sort headers.
6128         * dcache.c: Sort headers.
6129         * darwin-nat.h: Sort headers.
6130         * darwin-nat.c: Sort headers.
6131         * darwin-nat-info.c: Sort headers.
6132         * d-valprint.c: Sort headers.
6133         * d-namespace.c: Sort headers.
6134         * d-lang.c: Sort headers.
6135         * ctf.c: Sort headers.
6136         * csky-tdep.c: Sort headers.
6137         * csky-linux-tdep.c: Sort headers.
6138         * cris-tdep.c: Sort headers.
6139         * cris-linux-tdep.c: Sort headers.
6140         * cp-valprint.c: Sort headers.
6141         * cp-support.c: Sort headers.
6142         * cp-namespace.c: Sort headers.
6143         * cp-abi.c: Sort headers.
6144         * corelow.c: Sort headers.
6145         * corefile.c: Sort headers.
6146         * continuations.c: Sort headers.
6147         * completer.h: Sort headers.
6148         * completer.c: Sort headers.
6149         * complaints.c: Sort headers.
6150         * coffread.c: Sort headers.
6151         * coff-pe-read.c: Sort headers.
6152         * cli-out.h: Sort headers.
6153         * cli-out.c: Sort headers.
6154         * charset.c: Sort headers.
6155         * c-varobj.c: Sort headers.
6156         * c-valprint.c: Sort headers.
6157         * c-typeprint.c: Sort headers.
6158         * c-lang.c: Sort headers.
6159         * buildsym.c: Sort headers.
6160         * buildsym-legacy.c: Sort headers.
6161         * build-id.h: Sort headers.
6162         * build-id.c: Sort headers.
6163         * btrace.c: Sort headers.
6164         * bsd-uthread.c: Sort headers.
6165         * breakpoint.h: Sort headers.
6166         * breakpoint.c: Sort headers.
6167         * break-catch-throw.c: Sort headers.
6168         * break-catch-syscall.c: Sort headers.
6169         * break-catch-sig.c: Sort headers.
6170         * blockframe.c: Sort headers.
6171         * block.c: Sort headers.
6172         * bfin-tdep.c: Sort headers.
6173         * bfin-linux-tdep.c: Sort headers.
6174         * bfd-target.c: Sort headers.
6175         * bcache.c: Sort headers.
6176         * ax-general.c: Sort headers.
6177         * ax-gdb.h: Sort headers.
6178         * ax-gdb.c: Sort headers.
6179         * avr-tdep.c: Sort headers.
6180         * auxv.c: Sort headers.
6181         * auto-load.c: Sort headers.
6182         * arm-wince-tdep.c: Sort headers.
6183         * arm-tdep.c: Sort headers.
6184         * arm-symbian-tdep.c: Sort headers.
6185         * arm-pikeos-tdep.c: Sort headers.
6186         * arm-obsd-tdep.c: Sort headers.
6187         * arm-nbsd-tdep.c: Sort headers.
6188         * arm-nbsd-nat.c: Sort headers.
6189         * arm-linux-tdep.c: Sort headers.
6190         * arm-linux-nat.c: Sort headers.
6191         * arm-fbsd-tdep.c: Sort headers.
6192         * arm-fbsd-nat.c: Sort headers.
6193         * arm-bsd-tdep.c: Sort headers.
6194         * arch-utils.c: Sort headers.
6195         * arc-tdep.c: Sort headers.
6196         * arc-newlib-tdep.c: Sort headers.
6197         * annotate.h: Sort headers.
6198         * annotate.c: Sort headers.
6199         * amd64-windows-tdep.c: Sort headers.
6200         * amd64-windows-nat.c: Sort headers.
6201         * amd64-tdep.c: Sort headers.
6202         * amd64-sol2-tdep.c: Sort headers.
6203         * amd64-obsd-tdep.c: Sort headers.
6204         * amd64-obsd-nat.c: Sort headers.
6205         * amd64-nbsd-tdep.c: Sort headers.
6206         * amd64-nbsd-nat.c: Sort headers.
6207         * amd64-nat.c: Sort headers.
6208         * amd64-linux-tdep.c: Sort headers.
6209         * amd64-linux-nat.c: Sort headers.
6210         * amd64-fbsd-tdep.c: Sort headers.
6211         * amd64-fbsd-nat.c: Sort headers.
6212         * amd64-dicos-tdep.c: Sort headers.
6213         * amd64-darwin-tdep.c: Sort headers.
6214         * amd64-bsd-nat.c: Sort headers.
6215         * alpha-tdep.c: Sort headers.
6216         * alpha-obsd-tdep.c: Sort headers.
6217         * alpha-nbsd-tdep.c: Sort headers.
6218         * alpha-mdebug-tdep.c: Sort headers.
6219         * alpha-linux-tdep.c: Sort headers.
6220         * alpha-linux-nat.c: Sort headers.
6221         * alpha-bsd-tdep.c: Sort headers.
6222         * alpha-bsd-nat.c: Sort headers.
6223         * aix-thread.c: Sort headers.
6224         * agent.c: Sort headers.
6225         * addrmap.c: Sort headers.
6226         * ada-varobj.c: Sort headers.
6227         * ada-valprint.c: Sort headers.
6228         * ada-typeprint.c: Sort headers.
6229         * ada-tasks.c: Sort headers.
6230         * ada-lang.c: Sort headers.
6231         * aarch64-tdep.c: Sort headers.
6232         * aarch64-ravenscar-thread.c: Sort headers.
6233         * aarch64-newlib-tdep.c: Sort headers.
6234         * aarch64-linux-tdep.c: Sort headers.
6235         * aarch64-linux-nat.c: Sort headers.
6236         * aarch64-fbsd-tdep.c: Sort headers.
6237         * aarch64-fbsd-nat.c: Sort headers.
6238         * aarch32-linux-nat.c: Sort headers.
6239
6240 2019-04-04  Tom Tromey  <tom@tromey.com>
6241
6242         * varobj.c (varobj_create): Update.
6243         * rust-exp.y (struct rust_parser) <update_innermost_block,
6244         lookup_symbol>: New methods.
6245         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6246         Rename.
6247         (rust_parser::rust_lookup_type)
6248         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6249         * printcmd.c (display_command, do_one_display): Update.
6250         * parser-defs.h (struct parser_state) <parser_state>: Add
6251         "tracker" parameter.
6252         (block_tracker): New member.
6253         (class innermost_block_tracker) <innermost_block_tracker>: Add
6254         "types" parameter.
6255         <reset>: Remove method.
6256         (innermost_block): Don't declare.
6257         (null_post_parser): Update.
6258         * parse.c (innermost_block): Remove global.
6259         (write_dollar_variable): Update.
6260         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6261         Remove "tracker_types" parameter.
6262         (parse_expression): Add "tracker" parameter.
6263         (parse_expression_for_completion): Update.
6264         (null_post_parser): Add "tracker" parameter.
6265         * p-exp.y: Update rules.
6266         * m2-exp.y: Update rules.
6267         * language.h (struct language_defn) <la_post_parser>: Add
6268         "tracker" parameter.
6269         * go-exp.y: Update rules.
6270         * f-exp.y: Update rules.
6271         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6272         parameter.
6273         * d-exp.y: Update rules.
6274         * c-exp.y: Update rules.
6275         * breakpoint.c (set_breakpoint_condition): Create an
6276         innermost_block_tracker.
6277         (watch_command_1): Likewise.
6278         * ada-lang.c (resolve): Add "tracker" parameter.
6279         (resolve_subexp): Likewise.
6280         * ada-exp.y (write_var_from_sym): Update.
6281
6282 2019-04-04  Tom Tromey  <tom@tromey.com>
6283
6284         * type-stack.h: New file.
6285         * type-stack.c: New file.
6286         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6287         type-stack.h.
6288         (insert_into_type_stack, insert_type, push_type, push_type_int)
6289         (insert_type_address_space, pop_type, pop_type_int)
6290         (pop_typelist, pop_type_stack, append_type_stack)
6291         (push_type_stack, get_type_stack, push_typelist)
6292         (follow_type_instance_flags, follow_types): Don't declare.
6293         * parse.c (type_stack): Remove global.
6294         (parse_exp_in_context): Update.
6295         (insert_into_type_stack, insert_type, push_type, push_type_int)
6296         (insert_type_address_space, pop_type, pop_type_int)
6297         (pop_typelist, pop_type_stack, append_type_stack)
6298         (push_type_stack, get_type_stack, push_typelist)
6299         (follow_type_instance_flags, follow_types): Remove (moved to
6300         type-stack.c).
6301         * f-exp.y (type_stack): New global.
6302         Update rules.
6303         (push_kind_type, f_parse): Update.
6304         * d-exp.y (type_stack): New global.
6305         Update rules.
6306         (d_parse): Update.
6307         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6308         Update rules.
6309         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6310         (HFILES_NO_SRCDIR): Add type-stack.h.
6311
6312 2019-04-04  Tom Tromey  <tom@tromey.com>
6313
6314         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6315         (rust_parser::convert_ast_to_expression, rust_parse)
6316         (rust_lex_test_completion, rust_lex_tests): Update.
6317         * parser-defs.h (struct expr_completion_state): New.
6318         (struct parser_state) <parser_state>: Add completion parameter.
6319         <mark_struct_expression, mark_completion_tag>: New methods.
6320         <parse_completion, m_completion_state>: New members.
6321         (prefixify_expression, null_post_parser): Update.
6322         (mark_struct_expression, mark_completion_tag): Don't declare.
6323         * parse.c (parse_completion, expout_last_struct)
6324         (expout_tag_completion_type, expout_completion_name): Remove
6325         globals.
6326         (parser_state::mark_struct_expression)
6327         (parser_state::mark_completion_tag): Now methods.
6328         (prefixify_expression): Add last_struct parameter.
6329         (prefixify_subexp): Likewise.
6330         (parse_exp_1): Update.
6331         (parse_exp_in_context): Add cstate parameter.  Update.
6332         (parse_expression_for_completion): Create an
6333         expr_completion_state.
6334         (null_post_parser): Add "completion" parameter.
6335         * p-exp.y: Update rules.
6336         (yylex): Update.
6337         * language.h (struct language_defn) <la_post_parser>: Add
6338         "completing" parameter.
6339         * go-exp.y: Update rules.
6340         (lex_one_token): Update.
6341         * expression.h (parse_completion): Don't declare.
6342         * d-exp.y: Update rules.
6343         (lex_one_token): Update rules.
6344         * c-exp.y: Update rules.
6345         (lex_one_token): Update.
6346         * ada-lang.c (resolve): Add "parse_completion" parameter.
6347         (resolve_subexp): Likewise.
6348         (ada_resolve_function): Likewise.
6349
6350 2019-04-04  Tom Tromey  <tom@tromey.com>
6351
6352         * parser-defs.h (struct parser_state) <start_arglist,
6353         end_arglist>: New methods.
6354         <arglist_len, m_funcall_chain>: New members.
6355         (arglist_len, start_arglist, end_arglist): Don't declare.
6356         * parse.c (arglist_len, funcall_chain): Remove global.
6357         (start_arglist, end_arglist): Remove functions.
6358         (parse_exp_in_context): Update.
6359         * p-exp.y: Update rules.
6360         * m2-exp.y: Update rules.
6361         * go-exp.y: Update rules.
6362         * f-exp.y: Update rules.
6363         * d-exp.y: Update rules.
6364         * c-exp.y: Update rules.
6365
6366 2019-04-04  Tom Tromey  <tom@tromey.com>
6367
6368         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6369         lex_operator, push_back>: New methods.
6370         Update all rules.
6371         (rust_parser::lex_hex, lex_escape): Rename and update.
6372         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6373         (rust_parser::lex_operator): Rename and update.
6374         (rust_parser::lex_number, rustyylex, rustyyerror)
6375         (rust_lex_test_init, rust_lex_test_sequence)
6376         (rust_lex_test_push_back, rust_lex_tests): Update.
6377         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6378         parameter.
6379         <lexptr, prev_lexptr>: New members.
6380         (lexptr, prev_lexptr): Don't declare.
6381         * parse.c (lexptr, prev_lexptr): Remove globals.
6382         (parse_exp_in_context): Update.
6383         * p-exp.y (yylex, yyerror): Update.
6384         * m2-exp.y (parse_number, yylex, yyerror): Update.
6385         * go-exp.y (lex_one_token, yyerror): Update.
6386         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6387         * d-exp.y (lex_one_token, yyerror): Update.
6388         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6389         (lex_one_token, yyerror): Update.
6390         * ada-lex.l (YY_INPUT): Update.
6391         (rewind_to_char): Update.
6392         * ada-exp.y (yyerror): Update.
6393
6394 2019-04-04  Tom Tromey  <tom@tromey.com>
6395
6396         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6397         * parser-defs.h (struct parser_state) <parser_state>: Add new
6398         parameter.
6399         <comma_terminates>: New member.
6400         (comma_terminates): Don't declare global.
6401         * parse.c (comma_terminates): Remove global.
6402         (parse_exp_in_context): Update.
6403         * p-exp.y (yylex): Update.
6404         * m2-exp.y (yylex): Update.
6405         * go-exp.y (lex_one_token): Update.
6406         * f-exp.y (yylex): Update.
6407         * d-exp.y (lex_one_token): Update.
6408         * c-exp.y (lex_one_token): Update.
6409         * ada-lex.l: Update.
6410
6411 2019-04-04  Tom Tromey  <tom@tromey.com>
6412
6413         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6414         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6415         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6416         * parser-defs.h (paren_depth): Don't declare.
6417         * parse.c (paren_depth): Remove global.
6418         (parse_exp_in_context): Update.
6419         * p-exp.y (paren_depth): New global.
6420         (pascal_parse): Initialize it.
6421         * m2-exp.y (paren_depth): New global.
6422         (m2_parse): Initialize it.
6423         * go-exp.y (paren_depth): New global.
6424         (go_parse): Initialize it.
6425         * f-exp.y (paren_depth): New global.
6426         (f_parse): Initialize it.
6427         * d-exp.y (paren_depth): New global.
6428         (d_parse): Initialize it.
6429         * c-exp.y (paren_depth): New global.
6430         (c_parse): Initialize it.
6431         * ada-lex.l (paren_depth): New global.
6432         (lexer_init): Initialize it.
6433
6434 2019-04-04  Tom Tromey  <tom@tromey.com>
6435
6436         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6437         (rust_parser::convert_ast_to_type)
6438         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6439         * parser-defs.h (struct parser_state) <parser_state>: Add
6440         parameters.  Initialize new members.
6441         <expression_context_block, expression_context_pc>: New members.
6442         * parse.c (expression_context_block, expression_context_pc):
6443         Remove globals.
6444         (parse_exp_in_context): Update.
6445         * p-exp.y: Update all rules.
6446         (yylex): Update.
6447         * m2-exp.y: Update all rules.
6448         (yylex): Update.
6449         * go-exp.y (yylex): Update.
6450         * f-exp.y (yylex): Update.
6451         * d-exp.y: Update all rules.
6452         (yylex): Update.
6453         * c-exp.y: Update all rules.
6454         (lex_one_token, classify_name, yylex, c_parse): Update.
6455         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6456
6457 2019-04-04  Tom Tromey  <tom@tromey.com>
6458
6459         * gdbarch.h, gdbarch.c: Rebuild.
6460         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6461         * stap-probe.h:
6462         (struct stap_parse_info): Replace "parser_state" with
6463         "expr_builder".
6464         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6465         (parser_state): New class.
6466         * parse.c (expr_builder): Rename.
6467         (expr_builder::release): Rename.
6468         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6469         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6470         (write_exp_elt_longcst, write_exp_elt_floatcst)
6471         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6472         (write_exp_string_vector, write_exp_bitstring)
6473         (write_exp_msymbol, mark_struct_expression)
6474         (write_dollar_variable)
6475         (insert_type_address_space, increase_expout_size): Replace
6476         "parser_state" with "expr_builder".
6477         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6478         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6479         "parser_state" with "expr_builder".
6480
6481 2019-04-04  Tom Tromey  <tom@tromey.com>
6482
6483         * rust-exp.y: Replace "parse_language" with method call.
6484         * p-exp.y:
6485         (yylex): Replace "parse_language" with method call.
6486         * m2-exp.y:
6487         (yylex): Replace "parse_language" with method call.
6488         * go-exp.y (classify_name): Replace "parse_language" with method
6489         call.
6490         * f-exp.y (yylex): Replace "parse_language" with method call.
6491         * d-exp.y (lex_one_token): Replace "parse_language" with method
6492         call.
6493         * c-exp.y:
6494         (lex_one_token, classify_name, yylex): Replace "parse_language"
6495         with method call.
6496         * ada-exp.y (find_primitive_type, type_char)
6497         (type_system_address): Replace "parse_language" with method call.
6498
6499 2019-04-04  Tom Tromey  <tom@tromey.com>
6500
6501         * rust-exp.y: Replace "parse_gdbarch" with method call.
6502         * parse.c (write_dollar_variable, insert_type_address_space):
6503         Replace "parse_gdbarch" with method call.
6504         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6505         call.
6506         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6507         call.
6508         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6509         "parse_gdbarch" with method call.
6510         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6511         with method call.
6512         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6513         "parse_gdbarch" with method call.
6514         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6515         "parse_gdbarch" with method call.
6516         * c-exp.y (parse_type, parse_number, classify_name): Replace
6517         "parse_gdbarch" with method call.
6518         * ada-lex.l: Replace "parse_gdbarch" with method call.
6519         * ada-exp.y (parse_type, find_primitive_type, type_char)
6520         (type_system_address): Replace "parse_gdbarch" with method call.
6521
6522 2019-04-04  Tom Tromey  <tom@tromey.com>
6523
6524         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6525         * stap-probe.c (stap_parse_argument): Update.
6526         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6527         initial_size parameter.
6528         * rust-exp.y (rust_lex_tests): Update.
6529         * parse.c (parser_state): Update.
6530         (parse_exp_in_context): Update.
6531         * parser-defs.h (struct parser_state) <parser_state>: Remove
6532         "initial_size" parameter.
6533
6534 2019-04-04  Tom Tromey  <tom@tromey.com>
6535
6536         * parser-defs.h (increase_expout_size): Don't declare.
6537         * parse.c (increase_expout_size): Now static.
6538
6539 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6540
6541         * gnu-nat.c (gnu_nat_target::wait): Fix
6542         target_waitstatus_to_string call.
6543
6544 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6545
6546         * eval.c (evaluate_subexp_standard): Handle internal functions
6547         during Fortran function call handling.
6548
6549 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6550
6551         * NEWS: Mention new internal functions.
6552         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6553         (read_base_type): Use dwarf2_init_complex_target_type.
6554         * value.c (creal_internal_fn): New function.
6555         (cimag_internal_fn): New function.
6556         (_initialize_values): Register new internal functions.
6557
6558 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6559
6560         * infrun.c (stop_all_threads): If debug_infrun, always
6561         trace the wait status after wait_one, using
6562         target_waitstatus_to_string and target_pid_to_str.
6563         (handle_inferior_event): Replace various trace of
6564         wait status kind by a single trace.
6565         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6566         wait status kind image by target_waitstatus_to_string.
6567         * target/waitstatus.c (target_waitstatus_to_string): Fix
6568         obsolete comment.
6569
6570 2019-04-01  Tom Tromey  <tromey@adacore.com>
6571
6572         PR symtab/23331:
6573         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6574
6575 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6576             Pedro Alves  <palves@redhat.com>
6577
6578         * top.c (quit_force): Call 'finalize_values'.
6579         * value.c (finalize_values): New function.
6580         * value.h (finalize_values): Declare.
6581
6582 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6583
6584         * NEWS: Announce $_gdb_major and $_gdb_minor.
6585
6586         * top.c (init_gdb_version_vars): New function.
6587         (gdb_init): Call init_gdb_version_vars.
6588
6589 2019-03-29  Tom Tromey  <tromey@adacore.com>
6590
6591         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6592         help text.  Remove dead code.
6593
6594 2019-03-29  Keith Seitz  <keiths@redhat.com>
6595
6596         From Siddhesh Poyarekar:
6597         * f-lang.h (f77_get_upperbound): Return LONGEST.
6598         (f77_get_lowerbound): Likewise.
6599         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6600         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6601         print them.
6602         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6603         plongest to format print it.
6604         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6605         (f77_get_upperbound): Likewise.
6606         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6607         LOWER_BOUND to LONGEST.
6608         (f77_create_arrayprint_offset_tbl): Likewise.
6609
6610 2019-03-29  Keith Seitz  <keiths@redhat.com>
6611
6612         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6613         %s/pulongest for TYPE_LENGTH instead of %d in format
6614         strings.
6615         * ada-typerint.c (ada_print_type): Likewise.
6616         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6617         * compile/compile-c-support.c (generate_register_struct): Likewise.
6618         * gdbtypes.c (recursive_dump_type): Likewise.
6619         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6620         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6621         instead of %d in format strings.
6622         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6623         to std::min to ULONGEST.
6624         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6625         instead of %d in format strings.
6626         * tracepoint.c (info_scope_command): Likewise.
6627         * typeprint.c (print_offset_data::update)
6628         (print_offset_data::finish): Likewise.
6629         * xtensa-tdep.c (xtensa_store_return_value)
6630         (xtensa_push_dummy_call): Likewise.
6631
6632 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6633
6634         * windows-nat.c (display_selector): Fixed format specifications
6635         for 64-bit Cygwin.
6636
6637 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6638
6639         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6640
6641 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6642
6643         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6644         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6645         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6646         (nios2_linux_init_abi): Install it.
6647
6648 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6649
6650         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6651
6652 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6653
6654         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6655
6656 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6657             Tom Tromey  <tromey@adacore.com>
6658
6659         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6660
6661 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6662
6663         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6664         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6665         method to compute the bounds of range types. Also print "[evaluated]"
6666         if the bounds' values come from a dynamic evaluation.
6667
6668 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6669
6670         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6671         whitespace when pretty printing is on.
6672
6673 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6674
6675         * ppc-linux-nat.c: Add include.
6676
6677 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6678
6679         * NEWS: Mention AArch64 Pointer Authentication.
6680
6681 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6682
6683         * arm-linux-nat.c: Add include.
6684
6685 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6686
6687         * source-cache.c (source_cache::get_source_lines): Re-read
6688         fullname after calling open_source_file.
6689
6690 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6691
6692         * NEWS: Mention TLS support for FreeBSD.
6693
6694 2019-03-25  Tom Tromey  <tromey@adacore.com>
6695
6696         * minsyms.c (BUNCH_SIZE): Update comment.
6697         (~minimal_symbol_reader): Remove old comment.
6698         (compact_minimal_symbols): Update comment.
6699         (minimal_symbol_reader::install): Remove old comment.  Update
6700         other comments.
6701
6702 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6703
6704         * s390-linux-nat.c: Add include.
6705
6706 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6707
6708         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6709         Call linux_get_hwcap.
6710         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6711         Likewise.
6712         (aarch64_linux_get_hwcap): Remove function.
6713         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6714         declaration.
6715         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6716         linux_get_hwcap.
6717         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6718         * linux-tdep.c (linux_get_hwcap): Add function.
6719         (linux_get_hwcap2): Likewise.
6720         * linux-tdep.h (linux_get_hwcap): Add declaration.
6721         (linux_get_hwcap2): Likewise.
6722         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6723         (ppc_linux_get_hwcap2): Likewise.
6724         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6725         linux_get_hwcap.
6726         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6727         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6728         (ppc_linux_nat_target::read_description): Likewise.
6729         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6730         * s390-linux-nat.c: Likewise.
6731         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6732
6733 2019-03-24  Tom Tromey  <tom@tromey.com>
6734
6735         * ada-lang.c (standard_lookup): Simplify initialization.
6736         (ada_lookup_symbol_nonlocal): Simplify return.
6737         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6738         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6739         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6740         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6741         initialization.
6742         * solib.c (solib_global_lookup): Simplify.
6743         * symtab.c (null_block_symbol): Remove.
6744         (symbol_cache_lookup): Simplify returns.
6745         (lookup_language_this): Simplify returns.
6746         (lookup_symbol_aux): Simplify return.
6747         (lookup_local_symbol): Simplify returns.
6748         (lookup_global_symbol_from_objfile): Simplify return.
6749         (lookup_symbol_in_objfile_symtabs)
6750         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6751         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6752         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6753         * cp-namespace.c (cp_lookup_bare_symbol)
6754         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6755         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6756         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6757         (cp_lookup_symbol_via_imports): Simplify initialization.
6758         (find_symbol_in_baseclass): Likewise.
6759         * symtab.h (null_block_symbol): Remove.
6760         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6761         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6762         (d_lookup_symbol_module): Likewise.
6763         (find_symbol_in_baseclass): Simplify initialization.
6764
6765 2019-03-24  Tom Tromey  <tom@tromey.com>
6766
6767         * expression.h: Don't include symtab.h.
6768         (struct block): Forward declare.
6769
6770 2019-03-24  Tom Tromey  <tom@tromey.com>
6771
6772         * c-exp.y (typebase): Remove casts.
6773         * gdbtypes.c (lookup_unsigned_typename, )
6774         (lookup_signed_typename): Remove cast.
6775         * eval.c (parse_to_comma_and_eval): Remove cast.
6776         * parse.c (write_dollar_variable): Remove cast.
6777         * block.h (struct block) <superblock>: Now const.
6778         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6779         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6780         (map_block): Make "block" const.
6781         * symfile.h (struct quick_symbol_functions)
6782         <map_matching_symbols>: Constify block argument to "callback".
6783         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6784         const.
6785         (find_pc_sect_compunit_symtab): Make "b" const.
6786         (find_symbol_at_address): Likewise.
6787         (search_symbols): Likewise.
6788         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6789         (dw2_debug_names_lookup_symbol): Likewise.
6790         (dw2_map_matching_symbols): Update.
6791         * p-valprint.c (pascal_val_print): Remove "block".
6792         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6793         (aux_add_nonlocal_symbols): Make "block" const.
6794         (resolve_subexp): Remove cast.
6795         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6796         const.
6797         (iterate_over_file_blocks): Likewise.
6798         * f-exp.y (%union) <bval>: Remove.
6799         * coffread.c (patch_opaque_types): Make "b" const.
6800         * spu-tdep.c (spu_catch_start): Make "block" const.
6801         * c-valprint.c (print_unpacked_pointer): Remove "block".
6802         * symmisc.c (dump_symtab_1): Make "b" const.
6803         (block_depth): Make "block" const.
6804         * d-exp.y (%union) <bval>: Remove.
6805         * cp-support.h (cp_lookup_rtti_type): Update.
6806         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6807         * psymtab.c (psym_lookup_symbol): Make "block" const.
6808         (maintenance_check_psymtabs): Make "b" const.
6809         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6810         (enumerate_locals, enumerate_args): Update.
6811         * python/py-symtab.c (stpy_global_block): Make "block" const.
6812         (stpy_static_block): Likewise.
6813         * inline-frame.c (block_starting_point_at): Make "new_block"
6814         const.
6815         * block.c (find_block_in_blockvector): Make return type const.
6816         (blockvector_for_pc_sect): Make "b" const.
6817         (find_block_in_blockvector): Make "b" const.
6818
6819 2019-03-23  Tom Tromey  <tom@tromey.com>
6820
6821         * varobj.c (varobj_create): Update.
6822         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6823         * printcmd.c (display_command, do_one_display): Don't reset
6824         innermost_block.
6825         * parser-defs.h (enum innermost_block_tracker_type): Move to
6826         expression.h.
6827         (innermost_block): Update comment.
6828         * parse.c (parse_exp_1): Add tracker_types parameter.
6829         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6830         tracker_types parameter.  Reset innermost_block.
6831         (parse_exp_in_context): Remove.
6832         (parse_expression_for_completion): Update.
6833         * objfiles.c (~objfile): Don't reset expression_context_block or
6834         innermost_block.
6835         * expression.h (enum innermost_block_tracker_type): Move from
6836         parser-defs.h.
6837         (parse_exp_1): Add tracker_types parameter.
6838         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6839         reset innermost_block.
6840
6841 2019-03-23  Tom Tromey  <tom@tromey.com>
6842
6843         * objfiles.h: Include bcache.h.
6844
6845 2019-03-23  Tom Tromey  <tom@tromey.com>
6846
6847         * linespec.c (get_current_search_block): Use
6848         scoped_restore_current_language.
6849         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6850
6851 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6852             Jiong Wang  <jiong.wang@arm.com>
6853
6854         * aarch64-linux-tdep.c
6855         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6856         section.
6857         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6858
6859 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6860             Jiong Wang  <jiong.wang@arm.com>
6861
6862         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6863         instructions.
6864         (aarch64_analyze_prologue_test): Add PACIASP test.
6865         (aarch64_prologue_prev_register): Unmask PC value.
6866
6867 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6868             Jiong Wang  <jiong.wang@arm.com>
6869
6870         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6871         (aarch64_dwarf2_prev_register): Unmask PC value.
6872         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6873         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6874         DW_CFA_AARCH64_negate_ra_state.
6875         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6876
6877 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6878             Jiong Wang  <jiong.wang@arm.com>
6879
6880         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6881         registers.
6882         (aarch64_pseudo_register_name): Likewise.
6883         (aarch64_pseudo_register_type): Likewise.
6884         (aarch64_pseudo_register_reggroup_p): Likewise.
6885         (aarch64_gdbarch_init): Add pauth registers.
6886         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6887         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6888         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6889         (struct gdbarch_tdep): Add regnum for ra_state.
6890
6891 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6892             Jiong Wang  <jiong.wang@arm.com>
6893
6894         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6895
6896 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6897             Jiong Wang  <jiong.wang@arm.com>
6898
6899         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6900         function.
6901         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6902         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6903         (aarch64_gdbarch_init): Add puth registers.
6904         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6905         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6906         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6907
6908 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6909             Jiong Wang  <jiong.wang@arm.com>
6910
6911         * aarch64-linux-nat.c
6912         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6913         * aarch64-linux-tdep.c
6914         (aarch64_linux_core_read_description): Likewise.
6915         (aarch64_linux_get_hwcap): New function.
6916         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6917         (aarch64_linux_get_hwcap): New declaration.
6918
6919 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6920             Jiong Wang  <jiong.wang@arm.com>
6921
6922         * aarch64-linux-nat.c
6923         (aarch64_linux_nat_target::read_description): Add pauth param.
6924         * aarch64-linux-tdep.c
6925         (aarch64_linux_core_read_description): Likewise.
6926         * aarch64-tdep.c (struct target_desc): Add in pauth.
6927         (aarch64_read_description): Add pauth param.
6928         (aarch64_gdbarch_init): Likewise.
6929         * aarch64-tdep.h (aarch64_read_description): Likewise.
6930         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6931         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6932         * features/Makefile: Add new files.
6933         * features/aarch64-pauth.c: New file.
6934         * features/aarch64-pauth.xml: New file.
6935
6936 2019-03-20  Tom Tromey  <tromey@adacore.com>
6937
6938         * infrun.c (handle_inferior_event): Rename from
6939         handle_inferior_event_1.  Create a scoped_value_mark.
6940         (handle_inferior_event): Remove.
6941
6942 2019-03-19  Tom Tromey  <tromey@adacore.com>
6943
6944         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6945         * infrun.h (print_stop_event): Add "displays" parameter.
6946         * infrun.c (print_stop_event): Add "displays" parameter.
6947
6948 2019-03-19  Pedro Alves  <palves@redhat.com>
6949
6950         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6951         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6952         to -1.  Fix TABs vs spaces.
6953         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6954         * tui/tui-out.h (tui_ui_out) Add intro comments.
6955         <m_line, m_start_of_line>: In-class initialize, and add describing
6956         comment.
6957
6958 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6959
6960         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6961         variable names.
6962         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6963
6964 2019-03-18  Pedro Alves  <palves@redhat.com>
6965             Eli Zaretskii <eliz@gnu.org>
6966
6967         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6968         m_line and m_start_of_line.
6969
6970 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6971
6972         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6973         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6974         it returns a newline.  This fixes a regression in TU mode, whereby
6975         the next line is output on the same screen line as the user input.
6976
6977 2019-03-18  Tom Tromey  <tromey@adacore.com>
6978
6979         * minsyms.c (minimal_symbol_reader::install): Remove call to
6980         obstack_blank.
6981
6982 2019-03-18  Pedro Alves  <palves@redhat.com>
6983
6984         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6985         New globals.
6986         (apply_style): New, factored out from ...
6987         (apply_ansi_escape): ... this.  Handle reverse video mode.
6988         (tui_set_reverse_mode): New function.
6989         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6990         * tui/tui-winsource.c (tui_show_source_line): Use
6991         tui_set_reverse_mode instead of setting A_STANDOUT.
6992         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6993         New setter methods.
6994
6995 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6996
6997         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6998         Handle tabs.
6999
7000 2019-03-18  Tom Tromey  <tromey@adacore.com>
7001
7002         * ada-lang.c (empty_array): Add "high" parameter.
7003         (ada_evaluate_subexp): Update.
7004
7005 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7006
7007         * unittests/string_view-selftests.c: Define
7008         _initialize_string_view_selftests unconditionally.
7009
7010 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7011
7012         PR gdb/24350
7013         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7014
7015 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7016
7017         PR gdb/24351
7018         * windows-nat.c (display_selector): Fix format specifiers.
7019
7020 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7021
7022         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7023         tui_refill_source_window instead of tui_refresh_win, to update the
7024         current execution line.  This fixes redisplay of the current line
7025         when stepping through the code with "next" or "step".
7026
7027 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7028
7029         * source-cache.c (source_cache::get_source_lines): Call
7030         find_source_lines to initialize s->nlines.  This fixes vertical
7031         scrolling of TUI source window when the DOWN arrow is pressed.
7032
7033 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7034
7035         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7036         linux-thread-db.c (_initialize_thread_db): Likewise.
7037
7038 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7039
7040         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7041         wclrtoeol in tui_show_source_line".  This reverts changes made in
7042         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7043
7044 2019-03-15  Tom Tromey  <tom@tromey.com>
7045
7046         * symtab.h (struct minimal_symbol): Derive from
7047         general_symbol_info.
7048         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7049         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7050         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7051         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7052         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7053         (MSYMBOL_SEARCH_NAME): Update.
7054         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7055         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7056         * minsyms.c (minimal_symbol_reader::record_full): Update.
7057
7058 2019-03-15  Tom Tromey  <tom@tromey.com>
7059
7060         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7061
7062 2019-03-15  Tom Tromey  <tom@tromey.com>
7063
7064         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7065         unique_xmalloc_ptr.
7066         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7067         Update.
7068         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7069         (build_minimal_symbol_hash_tables)
7070         (minimal_symbol_reader::install): Update.
7071
7072 2019-03-15  Tom Tromey  <tom@tromey.com>
7073
7074         * symtab.c (create_demangled_names_hash): Update.
7075         (symbol_set_names): Update.
7076         * objfiles.h (struct objfile_per_bfd_storage)
7077         <demangled_names_hash>: Now an htab_up.
7078         * objfiles.c (objfile_per_bfd_storage): Simplify.
7079
7080 2019-03-15  Tom Tromey  <tom@tromey.com>
7081
7082         * objfiles.h (struct objfile_per_bfd_storage): Declare
7083         destructor.
7084         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7085         New.
7086         (get_objfile_bfd_data): Use new.  Don't initialize
7087         language_of_main.
7088         (free_objfile_per_bfd_storage): Remove.
7089         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7090
7091 2019-03-15  Tom Tromey  <tom@tromey.com>
7092
7093         * symfile.c (reread_symbols): Update.
7094         * objfiles.c (objfile::objfile): Update.
7095         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7096         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7097         comment.
7098         (minimal_symbol_reader::install): Update.
7099         (terminate_minimal_symbol_table): Remove.
7100         * jit.c (jit_object_close_impl): Update.
7101
7102 2019-03-15  Tom Tromey  <tom@tromey.com>
7103
7104         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7105         initializations.
7106
7107 2019-03-15  Tom Tromey  <tom@tromey.com>
7108
7109         * objfiles.h (struct objfile_per_bfd_storage)
7110         <demangled_hash_languages>: Now a bitset.
7111         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7112         (lookup_minimal_symbol): Update.
7113
7114 2019-03-15  Tom Tromey  <tom@tromey.com>
7115
7116         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7117         Don't return the symbol.
7118         * coffread.c (record_minimal_symbol): Use record_full.
7119
7120 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7121
7122         The MS-Windows port of ncurses fails to switch to a color pair if
7123         one or both of the colors are the implicit default colors.  This
7124         change records the default colors when TUI is initialized, and
7125         then specifies them explicitly when a color pair uses the default
7126         colors.  This allows color styling in TUI mode on MS-Windows.
7127
7128         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7129         ncurses_norm_attr.
7130         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7131         colors in ncurses_norm_attr.
7132         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7133         "none", replace it with the default color recorded in
7134         ncurses_norm_attr.
7135
7136 2019-03-14  Tom Tromey  <tromey@adacore.com>
7137
7138         * source-cache.h (class source_cache) <get_source_lines>: Return
7139         std::string.
7140         * source-cache.c (source_cache::extract_lines): Handle case where
7141         first_pos==npos.  Return std::string.
7142         (source_cache::get_source_lines): Update.
7143
7144 2019-03-14  Tom Tromey  <tromey@adacore.com>
7145
7146         * NEWS: Add item for "style sources" commands.
7147         * source-cache.c (source_cache::get_source_lines): Check
7148         source_styling.
7149         * cli/cli-style.c (source_styling): New global.
7150         (_initialize_cli_style): Add "style sources" commands.
7151         (show_style_sources): New function.
7152         * cli/cli-style.h (source_styling): Declare.
7153
7154 2019-03-14  Pedro Alves  <palves@redhat.com>
7155             Tom Tromey  <tromey@adacore.com>
7156
7157         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7158         * tui/tui-winsource.c (tui_refill_source_window): New function,
7159         from...
7160         (tui_horizontal_source_scroll): ... here.  Move some logic.
7161         * cli/cli-style.c (set_style_enabled): Notify new observable.
7162         * tui/tui-hooks.c (tui_redisplay_source): New function.
7163         (tui_attach_detach_observers): Attach or detach
7164         tui_redisplay_source.
7165         * observable.h (source_styling_changed): New observable.
7166         * observable.c: Define source_styling_changed observable.
7167
7168 2019-03-13  Tom Tromey  <tromey@adacore.com>
7169
7170         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7171         (i386_gnu_nat_target::store_registers): Update.
7172         * target-debug.h (target_debug_print_std_string): New macro.
7173         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7174         * windows-tdep.c (display_one_tib): Update.
7175         * tui/tui-stack.c (tui_make_status_line): Update.
7176         * top.c (print_inferior_quit_action): Update.
7177         * thread.c (thr_try_catch_cmd): Update.
7178         (add_thread_with_info): Update.
7179         (thread_target_id_str): Update.
7180         (thr_try_catch_cmd): Update.
7181         (thread_command): Update.
7182         (thread_find_command): Update.
7183         * record-btrace.c (record_btrace_target::info_record)
7184         (record_btrace_resume_thread, record_btrace_target::resume)
7185         (record_btrace_cancel_resume, record_btrace_step_thread)
7186         (record_btrace_target::wait, record_btrace_target::wait)
7187         (record_btrace_target::wait, record_btrace_target::stop): Update.
7188         * progspace.c (print_program_space): Update.
7189         * process-stratum-target.c
7190         (process_stratum_target::thread_address_space): Update.
7191         * linux-fork.c (linux_fork_mourn_inferior)
7192         (detach_checkpoint_command, info_checkpoints_command)
7193         (linux_fork_context): Update.
7194         (linux_fork_detach): Update.
7195         (class scoped_switch_fork_info): Update.
7196         (delete_checkpoint_command): Update.
7197         * infrun.c (follow_fork_inferior): Update.
7198         (follow_fork_inferior): Update.
7199         (proceed_after_vfork_done): Update.
7200         (handle_vfork_child_exec_or_exit): Update.
7201         (follow_exec): Update.
7202         (displaced_step_prepare_throw): Update.
7203         (displaced_step_restore): Update.
7204         (start_step_over): Update.
7205         (resume_1): Update.
7206         (clear_proceed_status_thread): Update.
7207         (proceed): Update.
7208         (print_target_wait_results): Update.
7209         (do_target_wait): Update.
7210         (context_switch): Update.
7211         (stop_all_threads): Update.
7212         (restart_threads): Update.
7213         (finish_step_over): Update.
7214         (handle_signal_stop): Update.
7215         (switch_back_to_stepped_thread): Update.
7216         (keep_going_pass_signal): Update.
7217         (print_exited_reason): Update.
7218         (normal_stop): Update.
7219         * inferior.c (inferior_pid_to_str): Change return type.
7220         (print_selected_inferior): Update.
7221         (add_inferior): Update.
7222         (detach_inferior): Update.
7223         * dummy-frame.c (fprint_dummy_frames): Update.
7224         * dcache.c (dcache_info_1): Update.
7225         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7226         (btrace_fetch, btrace_clear): Update.
7227         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7228         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7229         type.
7230         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7231         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7232         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7233         * gdbarch.c, gdbarch.h: Rebuild.
7234         * gdbarch.sh (core_pid_to_str): Change return type.
7235         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7236         return type.
7237         (windows_nat_target::pid_to_str): Change return type.
7238         (windows_delete_thread): Update.
7239         (windows_nat_target::attach): Update.
7240         (windows_nat_target::files_info): Update.
7241         * target-delegates.c: Rebuild.
7242         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7243         return type.
7244         (sol_thread_target::pid_to_str): Change return type.
7245         * remote.c (class remote_target) <pid_to_str>: Change return
7246         type.
7247         (remote_target::pid_to_str): Change return type.
7248         (extended_remote_target::attach, remote_target::remote_stop_ns)
7249         (remote_target::remote_notif_remove_queued_reply)
7250         (remote_target::push_stop_reply, remote_target::disable_btrace):
7251         Update.
7252         (extended_remote_target::attach): Update.
7253         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7254         type.
7255         (gdbsim_target::pid_to_str): Change return type.
7256         * ravenscar-thread.c (struct ravenscar_thread_target)
7257         <pid_to_str>: Change return type.
7258         (ravenscar_thread_target::pid_to_str): Change return type.
7259         * procfs.c (class procfs_target) <pid_to_str>: Change return
7260         type.
7261         (procfs_target::pid_to_str): Change return type.
7262         (procfs_target::attach): Update.
7263         (procfs_target::detach): Update.
7264         (procfs_target::fetch_registers): Update.
7265         (procfs_target::store_registers): Update.
7266         (procfs_target::wait): Update.
7267         (procfs_target::files_info): Update.
7268         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7269         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7270         return type.
7271         (nto_procfs_target::pid_to_str): Change return type.
7272         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7273         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7274         return type.
7275         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7276         (exit_lwp): Update.
7277         (attach_proc_task_lwp_callback, get_detach_signal)
7278         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7279         (linux_nat_target::resume, wait_lwp, stop_callback)
7280         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7281         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7282         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7283         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7284         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7285         type.
7286         (inf_ptrace_target::attach): Update.
7287         (inf_ptrace_target::files_info): Update.
7288         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7289         type.
7290         (go32_nat_target::pid_to_str): Change return type.
7291         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7292         (gnu_nat_target::wait): Update.
7293         (gnu_nat_target::wait): Update.
7294         (gnu_nat_target::resume): Update.
7295         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7296         (fbsd_nat_target::wait): Update.
7297         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7298         type.
7299         (darwin_nat_target::attach): Update.
7300         * corelow.c (class core_target) <pid_to_str>: Change return type.
7301         (core_target::pid_to_str): Change return type.
7302         * target.c (normal_pid_to_str): Change return type.
7303         (default_pid_to_str): Likewise.
7304         (target_pid_to_str): Change return type.
7305         (target_translate_tls_address): Update.
7306         (target_announce_detach): Update.
7307         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7308         return type.
7309         (bsd_uthread_target::pid_to_str): Change return type.
7310         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7311         type.
7312         (bsd_kvm_target::pid_to_str): Change return type.
7313         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7314         return type.
7315         (aix_thread_target::pid_to_str): Change return type.
7316         * target.h (struct target_ops) <pid_to_str>: Change return type.
7317         (target_pid_to_str, normal_pid_to_str): Likewise.
7318         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7319         type.
7320         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7321         type.
7322         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7323         return type.
7324         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7325         type.
7326         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7327         type.
7328         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7329         return type.
7330
7331 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7332
7333         * NEWS: Mention that the new default MI version is 3.  Mention
7334         changes to the output of commands and events that deal with
7335         multi-location breakpoints.
7336         * breakpoint.c: Include "mi/mi-out.h".
7337         (print_one_breakpoint): Change output syntax if using MI version
7338         >= 3.
7339         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7340         New.
7341         (mi_multi_location_breakpoint_output_fixed): New.
7342         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7343         (mi_cmd_fix_multi_location_breakpoint_output): New.
7344         (mi_multi_location_breakpoint_output_fixed): New.
7345         * mi/mi-cmds.c (mi_cmds): Register command
7346         -fix-multi-location-breakpoint-output.
7347         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7348         interpreter "mi".
7349
7350 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7351
7352         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7353         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7354         instantiate mi_ui_out based on interpreter name.
7355         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7356         * mi/mi-main.c (mi_load_progress): Likewise.
7357
7358 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7359
7360         * NEWS: Combine separate "New targets" sections for 8.3.
7361
7362 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7363
7364         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7365         (ppcfbsd_init_abi): Install gdbarch
7366         "fetch_tls_load_module_address" and "get_thread_local_address"
7367         methods.
7368
7369 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7370
7371         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7372         (riscv_fbsd_init_abi): Install gdbarch
7373         "fetch_tls_load_module_address" and "get_thread_local_address"
7374         methods.
7375
7376 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7377
7378         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7379         (i386fbsd_init_abi): Install gdbarch
7380         "fetch_tls_load_module_address" and "get_thread_local_address"
7381         methods.
7382
7383 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7384
7385         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7386         (amd64fbsd_init_abi): Install gdbarch
7387         "fetch_tls_load_module_address" and "get_thread_local_address"
7388         methods.
7389
7390 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7391
7392         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7393         (struct fbsd_pspace_data): New type.
7394         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7395         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7396         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7397         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7398         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7399
7400 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7401
7402         * gdbtypes.c (lookup_struct_elt): New function.
7403         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7404         * gdbtypes.h (struct struct_elt): New type.
7405         (lookup_struct_elt): New prototype.
7406
7407 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7408
7409         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7410         remove disabled code block.
7411
7412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7413
7414         * gdbarch.sh (get_thread_local_address): New method.
7415         * gdbarch.h, gdbarch.c: Regenerate.
7416         * target.c (target_translate_tls_address): Use
7417         gdbarch_get_thread_local_address if present instead of
7418         target::get_thread_local_address.
7419
7420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7421
7422         * target.h (target::get_thread_local_address): Update comment.
7423
7424 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7425
7426         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7427         objfile->separate_debug_objfile_backlink if not NULL.
7428
7429 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7430
7431         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7432         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7433         (amd64bsd_store_inferior_registers): Likewise.
7434         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7435         Enable segment base registers.
7436         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7437         PT_GETFSBASE and PT_GETGSBASE.
7438         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7439         PT_SETGSBASE.
7440         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7441         segment base registers.
7442         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7443
7444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7445
7446         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7447         Update calls to i386_target_description to add 'segments'
7448         parameter.
7449         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7450         add segment base registers.
7451         * arch/i386.c (i386_create_target_description): Add 'segments'
7452         parameter to enable segment base registers.
7453         * arch/i386.h (i386_create_target_description): Likewise.
7454         * features/i386/32bit-segments.xml: New file.
7455         * features/i386/32bit-segments.c: Generate.
7456         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7457         call to i386_target_description to add 'segments' parameter.
7458         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7459         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7460         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7461         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7462         if feature is present.
7463         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7464         Add 'segments' parameter to call to i386_target_description.
7465         (i386_target_description): Add 'segments' parameter to enable
7466         segment base registers.
7467         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7468         to call to i386_target_description.
7469         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7470         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7471         Define I386_NUM_REGS.
7472         (i386_target_description): Add 'segments' parameter to enable
7473         segment base registers.
7474
7475 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7476
7477         PR/24325
7478         * source-cache.c: #undef open and close, to avoid unresolved
7479         externals during linking.
7480
7481 2019-03-12  Tom Tromey  <tromey@adacore.com>
7482
7483         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7484         const.  Add initializers.
7485         (_initialize_remote): Don't initialize ptid globals.
7486
7487 2019-03-12  Pedro Alves  <palves@redhat.com>
7488
7489         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7490
7491 2019-03-12  Pedro Alves  <palves@redhat.com>
7492
7493         * cp-name-parser.y (main): Remove unused 'len' variable.
7494
7495 2019-03-12  Tom Tromey  <tromey@adacore.com>
7496
7497         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7498         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7499
7500 2019-03-12  Tom Tromey  <tromey@adacore.com>
7501
7502         * linux-nat.c (iterate_over_lwps): Update.
7503         (stop_callback): Remove parameter.
7504         (stop_wait_callback, detach_callback, resume_set_callback)
7505         (select_singlestep_lwp_callback, set_ignore_sigint)
7506         (status_callback, resumed_callback, resume_clear_callback)
7507         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7508         data parameter.
7509         (linux_nat_target::detach, linux_nat_target::resume)
7510         (linux_stop_and_wait_all_lwps, select_event_lwp)
7511         (linux_nat_filter_event, linux_nat_wait_1)
7512         (linux_nat_target::kill, linux_nat_target::stop)
7513         (linux_nat_target::stop): Update.
7514         (linux_nat_resume_callback): Change type.
7515         (resume_stopped_resumed_lwps, count_events_callback)
7516         (select_event_lwp_callback): Likewise.
7517         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7518         * arm-linux-nat.c (struct update_registers_data): Remove.
7519         (update_registers_callback): Change type.
7520         (arm_linux_insert_hw_breakpoint1): Update.
7521         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7522         parameter.
7523         (x86_linux_dr_set_addr): Update.
7524         (x86_linux_dr_set_control): Update.
7525         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7526         (iterate_over_lwps): Use gdb::function_view.
7527         * nat/aarch64-linux-hw-point.c (struct
7528         aarch64_dr_update_callback_param): Remove.
7529         (debug_reg_change_callback): Change type.
7530         (aarch64_notify_debug_reg_change): Update.
7531         * s390-linux-nat.c (s390_refresh_per_info): Update.
7532
7533 2019-03-11  Tom Tromey  <tromey@adacore.com>
7534
7535         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7536         redundant assignment to "this_cu".
7537
7538 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7539
7540         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7541
7542 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7543
7544         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7545         from...
7546         (rank_one_type): ... this.
7547
7548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7549
7550         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7551         from...
7552         (rank_one_type): ... this.
7553
7554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7555
7556         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7557         from...
7558         (rank_one_type): ... this.
7559
7560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7561
7562         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7563         from...
7564         (rank_one_type): ... this.
7565
7566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7567
7568         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7569         from...
7570         (rank_one_type): ... this.
7571
7572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7573
7574         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7575         from...
7576         (rank_one_type): ... this.
7577
7578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7579
7580         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7581         from...
7582         (rank_one_type): ... this.
7583
7584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7585
7586         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7587         from...
7588         (rank_one_type): ... this.
7589
7590 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7591
7592         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7593         from...
7594         (rank_one_type): ... this.
7595
7596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7597
7598         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7599         from...
7600         (rank_one_type): ... this.
7601
7602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7603
7604         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7605         from...
7606         (rank_one_type): ... this.
7607
7608 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7609
7610         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7611         from...
7612         (rank_one_type): ... this.
7613
7614 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7615
7616         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7617         inferior-events' shows the example events.
7618
7619 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7620
7621         Support styling on native MS-Windows console
7622
7623         PR/24315
7624         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7625         on MS-Windows if $TERM is not defined.
7626
7627         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7628
7629         * posix-hdep.c (gdb_console_fputs):
7630         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7631         functions.
7632         * ui-file.h (gdb_console_fputs): Add prototype.
7633
7634         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7635         back to fputs only if the former returns zero.
7636
7637 2019-03-07  Tom Tromey  <tom@tromey.com>
7638
7639         * symmisc.c (print_symbol_bcache_statistics): Update.
7640         (print_objfile_statistics): Update.
7641         * symfile.c (allocate_symtab): Update.
7642         * stabsread.c: Don't include bcache.h.
7643         * psymtab.h (struct psymbol_bcache): Don't declare.
7644         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7645         (psymbol_bcache_init, psymbol_bcache_free)
7646         (psymbol_bcache_get_bcache): Don't declare.
7647         * psymtab.c (struct psymbol_bcache): Remove.
7648         (psymtab_storage::psymtab_storage): Update.
7649         (psymtab_storage::~psymtab_storage): Update.
7650         (psymbol_bcache_init, psymbol_bcache_free)
7651         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7652         (add_psymbol_to_bcache): Update.
7653         (allocate_psymtab): Update.
7654         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7655         macro_cache>: No longer pointers.
7656         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7657         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7658         * macrotab.c (macro_bcache): Update.
7659         * macroexp.c: Don't include bcache.h.
7660         * gdbtypes.c (check_types_worklist): Update.
7661         (types_deeply_equal): Remove TRY/CATCH.  Update.
7662         * elfread.c (elf_symtab_read): Update.
7663         * dwarf2read.c: Don't include bcache.h.
7664         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7665         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7666         (print_bcache_statistics, bcache_memory_used): Don't declare.
7667         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7668         methods.  Rename all data members.
7669         * bcache.c (struct bcache): Move to bcache.h.
7670         (bcache::expand_hash_table): Rename from expand_hash_table.
7671         (bcache): Remove.
7672         (bcache::insert): Rename from bcache_full.
7673         (bcache::compare): Rename from bcache_compare.
7674         (bcache_xmalloc): Remove.
7675         (bcache::~bcache): Rename from bcache_xfree.
7676         (bcache::print_statistics): Rename from print_bcache_statistics.
7677         (bcache::memory_used): Rename from bcache_memory_used.
7678
7679 2019-03-07  Pedro Alves  <palves@redhat.com>
7680
7681         * infrun.c (normal_stop): Also check for
7682         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7683
7684 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7685
7686         * f-lang.c (value_from_host_double): Moved to...
7687         * value.c (value_from_host_double): ...here.
7688         * value.h (value_from_host_double): Declare.
7689         * guile/scm-math.c (vlscm_convert_typed_number): Use
7690         value_from_host_double.
7691         (vlscm_convert_number): Likewise.
7692         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7693         * python/py-value.c (convert_value_from_python): Likewise.
7694
7695 2019-03-06  Tom Tromey  <tom@tromey.com>
7696
7697         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7698
7699 2019-03-06  Tom Tromey  <tom@tromey.com>
7700
7701         * utils.h (free_current_contents): Don't declare.
7702         * utils.c (free_current_contents): Remove.
7703
7704 2019-03-06  Tom Tromey  <tom@tromey.com>
7705
7706         * top.c (quit_force): Update.
7707         * main.c (captured_command_loop): Update.
7708         * common/new-op.c (operator new): Update.
7709         * common/common-exceptions.c (struct catcher)
7710         <save_cleanup_chain>: Remove member.
7711         (exceptions_state_mc_init): Update.
7712         (exception_try_scope_entry): Return nullptr.
7713         (exception_try_scope_exit, exception_rethrow)
7714         (throw_exception_sjlj, throw_exception_cxx): Update.
7715         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7716         (all_cleanups, do_cleanups, discard_cleanups)
7717         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7718         (restore_cleanups, restore_final_cleanups): Don't declare.
7719         (do_final_cleanups): Remove parameter.
7720         * common/cleanups.c (cleanup_chain, make_cleanup)
7721         (make_cleanup_dtor, all_cleanups, do_cleanups)
7722         (discard_my_cleanups, discard_cleanups)
7723         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7724         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7725         (null_cleanup): Remove.
7726         (do_final_cleanups): Remove parameter.
7727
7728 2019-03-06  Tom Tromey  <tom@tromey.com>
7729
7730         * remote.c (remote_target::remote_parse_stop_reply): Use
7731         unique_xmalloc_ptr.
7732
7733 2019-03-06  Tom Tromey  <tom@tromey.com>
7734
7735         * stabsread.c (struct stabs_field_info): Rename from field_info.
7736         <list, fnlist>: Add initializers.
7737         <obstack>: New member.
7738         (read_member_functions, read_struct_fields, read_baseclasses):
7739         Allocate on obstack.  Don't use cleanups.
7740         (read_one_struct_field, read_member_functions, read_struct_fields)
7741         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7742         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7743         (read_struct_type): Update.
7744
7745 2019-03-06  Tom Tromey  <tom@tromey.com>
7746
7747         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7748         * common/filestuff.h (make_cleanup_close): Don't declare.
7749         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7750         Remove.
7751
7752 2019-03-06  Tom Tromey  <tom@tromey.com>
7753
7754         * solib-aix.c: Use make_scope_exit.
7755
7756 2019-03-06  Tom Tromey  <tom@tromey.com>
7757
7758         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7759         Use make_scope_exit.
7760
7761 2019-03-06  Tom Tromey  <tom@tromey.com>
7762
7763         * solib-svr4.c (disable_probes_interface): Remove parameter.
7764         (svr4_handle_solib_event): Use make_scope_exit.
7765
7766 2019-03-06  Tom Tromey  <tom@tromey.com>
7767
7768         * remote.c (struct stop_reply_deleter): Remove.
7769         (stop_reply_up): Update.
7770         (struct stop_reply): Derive from notif_event.  Don't typedef.
7771         <regcache>: Now a std::vector.
7772         (stop_reply_xfree): Remove.
7773         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7774         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7775         (remote_target::discard_pending_stop_replies): Use delete.
7776         (remote_target::remote_parse_stop_reply): Update.
7777         (remote_target::process_stop_reply): Update.
7778         * remote-notif.h (struct notif_event): Add virtual destructor.
7779         Remove "dtr" member.
7780         (struct notif_client) <alloc_event>: Return a unique_ptr.
7781         (notif_event_xfree): Don't declare.
7782         (notif_event_up): New typedef.
7783         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7784         (notif_event_xfree, do_notif_event_xfree): Remove.
7785         (remote_notif_state_xfree): Update.
7786
7787 2019-03-06  Tom Tromey  <tom@tromey.com>
7788
7789         * infrun.c (displaced_step_clear_cleanup): Now a
7790         forward_scope_exit type.
7791         (displaced_step_prepare_throw): Update.
7792         (displaced_step_fixup): Update.
7793
7794 2019-03-06  Tom Tromey  <tom@tromey.com>
7795
7796         * inferior.h (class inferior): Update comment.
7797         * gdbthread.h (class thread_info): Update comment.
7798
7799 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7800             Tom Tromey  <tom@tromey.com>
7801
7802         * stabsread.h (struct stab_section_list): Remove.
7803         (coffstab_build_psymtabs): Update.
7804         * dbxread.c (symbuf_sections): Now a std::vector.
7805         (sect_idx): New global.
7806         (fill_symbuf): Update.
7807         (coffstab_build_psymtabs): Change type of stabsects parameter.
7808         Update.
7809         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7810         std::vector.
7811         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7812         (coff_locate_sections): Update.
7813         (coff_symfile_read): Remove cleanups.  Update.
7814         (init_stringtab): Add storage parameter.
7815         (free_stringtab, free_stringtab_cleanup): Remove.
7816         (init_lineno): Add storage parameter.
7817         (free_linetab, free_linetab_cleanup): Remove.
7818
7819 2019-03-06  Pedro Alves  <palves@redhat.com>
7820
7821         * linux-fork.c (fork_info::clobber_regs): Delete.
7822         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7823         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7824         comment.  Adjust.
7825         (scoped_switch_fork_info::scoped_switch_fork_info)
7826         (checkpoint_command, linux_fork_context): Adjust
7827         fork_save_infrun_state calls.
7828
7829 2019-03-06  Pedro Alves  <palves@redhat.com>
7830
7831         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7832         (inf_has_multiple_threads): Return 'bool' and rewrite using
7833         inferior_info::threads().
7834
7835 2019-03-06  Pedro Alves  <palves@redhat.com>
7836
7837         * linux-fork.c: Include <list>.
7838         (fork_list): Now a std::list instance.
7839         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7840         (forks_exist_p, find_last_fork): Adjust.
7841         (new_fork): Delete.
7842         (one_fork_p): New.
7843         (add_fork): Adjust.
7844         (free_fork): Delete, folded into fork_info::~fork_info().
7845         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7846         Adjust.
7847         (init_fork_list): Delete.
7848         (linux_fork_killall, linux_fork_mourn_inferior)
7849         (linux_fork_detach, info_checkpoints_command): Adjust.
7850         (_initialize_linux_fork): No longer call init_fork_list.
7851
7852 2019-03-06  Pedro Alves  <palves@redhat.com>
7853
7854         * linux-fork.c (new_fork): New, split out of ...
7855         (add_fork): ... this.  Return void.  Move "first fork" special
7856         case from here, to ...
7857         (checkpoint_command): ... here.
7858         * linux-linux.h (add_fork): Return void.
7859
7860 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7861
7862         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7863
7864 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7865             Chris January  <chris.january@arm.com>
7866             David Lecomber  <david.lecomber@arm.com>
7867
7868         * f-exp.y: New token, UNOP_INTRINSIC.
7869         (exp): New pattern using UNOP_INTRINSIC token.
7870         (f77_keywords): Add 'abs' keyword.
7871         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7872         (value_from_host_double): New function.
7873         (evaluate_subexp_f): Support UNOP_ABS.
7874
7875 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7876
7877         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7878         types.
7879
7880 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7881
7882         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7883         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7884         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7885
7886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7887
7888         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7889
7890 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7891             Chris January  <chris.january@arm.com>
7892
7893         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7894         * f-exp.y: Define 'KIND' token.
7895         (exp): New pattern for KIND expressions.
7896         (ptype): Handle types with a kind extension.
7897         (direct_abs_decl): Extend to spot kind extensions.
7898         (f77_keywords): Add 'kind' to the list.
7899         (push_kind_type): New function.
7900         (convert_to_kind_type): New function.
7901         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7902         * parse.c (operator_length_standard): Likewise.
7903         * parser-defs.h (enum type_pieces): Add tp_kind.
7904         * std-operator.def: Add UNOP_KIND.
7905
7906 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7907
7908         * f-exp.y (f_parse): Set yydebug.
7909
7910 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7911
7912         * f-lang.c (evaluate_subexp_f): New function.
7913         (exp_descriptor_f): New global.
7914         (f_language_defn): Use exp_descriptor_f instead of
7915         exp_descriptor_standard.
7916
7917 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7918
7919         * f-exp.y (struct token): Add comments.
7920         (dot_ops): Remove uppercase versions and the end marker.
7921         (f77_keywords): Likewise.
7922         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7923         entries in the dot_ops array are case insensitive, and use
7924         strncasecmp to compare strings.  Also some whitespace cleanup in
7925         this area.  Similar for the f77_keywords array, except entries in
7926         this list might be case sensitive.
7927
7928 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7929
7930         * f-exp.y (struct f77_boolean_val): Add comments.
7931         (boolean_values): Remove uppercase versions, and end marker.
7932         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7933         and use strncasecmp to achieve case insensitivity.  Additionally,
7934         perform whitespace cleanup around this code.
7935
7936 2019-03-06  Tom Tromey  <tromey@adacore.com>
7937
7938         * remote-sim.c (gdbsim_target_open): Use result of
7939         gdb_argv::release.
7940
7941 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7942         Dirk Schubert  <dirk.schubert@arm.com>
7943         Chris January  <chris.january@arm.com>
7944
7945         * eval.c (evaluate_subexp_standard): Call Fortran argument
7946         wrapping logic.
7947         * f-lang.c (struct value): A value which can be passed into a
7948         Fortran function call.
7949         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7950         where appropriate.
7951         (struct type): Value ready for a Fortran function call.
7952         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7953         is needed.
7954         * f-lang.h (fortran_argument_convert): Declaration.
7955         (fortran_preserve_arg_pointer): Declaration.
7956         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7957
7958 2019-03-05  Tom Tromey  <tromey@adacore.com>
7959
7960         * python/py-prettyprint.c (print_string_repr): Remove #if.
7961         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7962
7963 2019-03-05  Tom Tromey  <tromey@adacore.com>
7964
7965         * target.c (the_dummy_target): Move later.  Change type to
7966         "dummy_target".
7967         (initialize_targets): Don't initialize the_dummy_target.
7968
7969 2019-03-05  Tom Tromey  <tromey@adacore.com>
7970
7971         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7972         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7973
7974 2019-03-05  Tom Tromey  <tromey@adacore.com>
7975
7976         * windows-nat.c (windows_nat_target::attach)
7977         (windows_nat_target::detach): Don't call gdb_flush.
7978         * valprint.c (generic_val_print, val_print, val_print_string):
7979         Don't call gdb_flush.
7980         * utils.c (defaulted_query): Don't call gdb_flush.
7981         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7982         * target.c (target_announce_detach): Don't call gdb_flush.
7983         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7984         * remote.c (extended_remote_target::attach): Don't call
7985         gdb_flush.
7986         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7987         * printcmd.c (do_examine): Don't call gdb_flush.
7988         (info_display_command): Don't call gdb_flush.
7989         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7990         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7991         * memattr.c (info_mem_command): Don't call gdb_flush.
7992         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7993         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7994         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7995         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7996         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7997         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7998         (gnu_nat_target::detach): Don't call gdb_flush.
7999         * f-valprint.c (f_val_print): Don't call gdb_flush.
8000         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8001         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8002         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8003         gdb_flush.
8004         * c-valprint.c (c_val_print): Don't call gdb_flush.
8005         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8006
8007 2019-03-05  Tom Tromey  <tromey@adacore.com>
8008
8009         * varobj.c (update_dynamic_varobj_children): Update.
8010         (install_default_visualizer): Use reset, not release.
8011         * value.c (set_internalvar): Update.
8012         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8013         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8014         ATTRIBUTE_UNUSED_RESULT.
8015
8016 2019-03-05  Tom Tromey  <tromey@adacore.com>
8017
8018         * remote.c (class scoped_remote_fd) <release>: Add
8019         ATTRIBUTE_UNUSED_RESULT.
8020
8021 2019-03-05  Tom Tromey  <tromey@adacore.com>
8022
8023         * macroexp.c (struct macro_buffer) <release>: Add
8024         ATTRIBUTE_UNUSED_RESULT.
8025
8026 2019-03-05  Tom Tromey  <tromey@adacore.com>
8027
8028         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8029         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8030         ATTRIBUTE_UNUSED_RESULT.
8031
8032 2019-03-05  Tom Tromey  <tromey@adacore.com>
8033
8034         * common/scoped_fd.h (class scoped_fd) <release>: Add
8035         ATTRIBUTE_UNUSED_RESULT.
8036
8037 2019-03-05  Tom Tromey  <tromey@adacore.com>
8038
8039         * parser-defs.h (struct parser_state) <release>: Add
8040         ATTRIBUTE_UNUSED_RESULT.
8041
8042 2019-03-05  Tom Tromey  <tromey@adacore.com>
8043
8044         * utils.h (class gdb_argv) <release>: Add
8045         ATTRIBUTE_UNUSED_RESULT.
8046         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8047
8048 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8049
8050         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8051         for-loop range, to avoid compiler warnings.
8052
8053         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8054         avoid compiler warnings about unused variables.
8055
8056         * NEWS: Mention end of support for native debugging on MS-Windows
8057         before XP.
8058
8059         PR gdb/24292
8060         * common/netstuff.c:
8061         * gdbserver/gdbreplay.c
8062         * gdbserver/remote-utils.c:
8063         * ser-tcp.c:
8064         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8065         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8066         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8067         'getaddrinfo' and 'freeaddrinfo' were not available before
8068         Windows XP, and mingw.org's MinGW headers by default define
8069         _WIN32_WINNT to 0x500.
8070
8071 2019-03-01  Gary Benson <gbenson@redhat.com>
8072
8073         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8074
8075 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8076             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8077
8078         PR gdb/8527
8079         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8080         set_sigint_trap, clear_sigint_trap.
8081
8082 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8083
8084         * target.c (target_detach): Clear the regcache and the
8085         frame cache.
8086
8087 2019-02-27  Pedro Alves  <palves@redhat.com>
8088
8089         * utils.c (set_screen_size): When we cap the height/width sizes,
8090         tweak the corresponding command variable to show "unlimited":
8091
8092 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8093             Pedro Alves  <palves@redhat.com>
8094
8095         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8096         before calling rl_set_screen_size.
8097
8098 2019-02-27  Tom Tromey  <tromey@adacore.com>
8099
8100         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8101         define.
8102         * python/py-value.c: Remove Python 2.4 workaround.
8103         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8104         workaround.
8105         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8106         Python 2.4 workaround.
8107         * python/python-internal.h: Remove Python 2.4 comment.
8108         (Py_ssize_t): Don't define.
8109         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8110         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8111         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8112         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8113         * python/python.c (do_start_initialization): Remove Python 2.4
8114         workaround.
8115         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8116         (print_children): Remove Python 2.4 workaround.
8117         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8118         workaround.
8119         (CHARBUFFERPROC_NAME): Remove.
8120         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8121         Python 2.4 workaround.
8122
8123 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8124
8125         * NEWS: Note minimum Python version.
8126
8127 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8128
8129         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8130         code from these functions.  Remove corresponding ifdefs.  Use
8131         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8132         Remove gotos and target of gotos.
8133         (infpy_search_memory): Likewise.
8134
8135 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8136
8137         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8138         (hppa_gdbarch_init): Don't register deleted functions with
8139         gdbarch.
8140
8141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8142
8143         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8144         (h8300_unwind_sp): Delete.
8145         (h8300_dummy_id): Delete.
8146         (h8300_gdbarch_init): Don't register deleted functions with
8147         gdbarch.
8148
8149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8150
8151         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8152         (ft32_unwind_pc): Delete.
8153         (ft32_unwind_sp): Delete.
8154         (ft32_gdbarch_init): Don't register deleted functions with
8155         gdbarch.
8156
8157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8158
8159         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8160         (frv_unwind_pc): Delete.
8161         (frv_unwind_sp): Delete.
8162         (frv_gdbarch_init): Don't register deleted functions with
8163         gdbarch.
8164
8165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8166
8167         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8168         (riscv_unwind_pc): Delete.
8169         (riscv_unwind_sp): Delete.
8170         (riscv_gdbarch_init): Don't register deleted functions with
8171         gdbarch.
8172
8173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8174
8175         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8176         (csky_unwind_pc): Delete.
8177         (csky_unwind_sp): Delete.
8178         (csky_gdbarch_init): Don't register deleted functions with
8179         gdbarch.
8180
8181 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8182
8183         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8184         (cris_unwind_pc): Delete.
8185         (cris_unwind_sp): Delete.
8186         (cris_gdbarch_init): Don't register deleted functions with
8187         gdbarch.
8188
8189 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8190
8191         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8192         (bfin_unwind_pc): Delete.
8193         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8194
8195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8196
8197         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8198         (arm_unwind_pc): Delete.
8199         (arm_unwind_sp): Delete.
8200         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8201
8202 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8203
8204         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8205         (arc_unwind_pc): Delete.
8206         (arc_unwind_sp): Delete.
8207         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8208
8209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8210
8211         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8212         (alpha_unwind_pc): Delete.
8213         (alpha_gdbarch_init): Don't register deleted functions with
8214         gdbarch.
8215
8216 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8217
8218         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8219         (aarch64_unwind_pc): Delete.
8220         (aarch64_unwind_sp): Delete.
8221         (aarch64_gdbarch_init): Don't register deleted functions with
8222         gdbarch.
8223
8224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8225
8226         * gdbtypes.c (type_align): Don't consider static members when
8227         computing structure alignment.
8228
8229 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8230
8231         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8232         return 0 for other types.
8233         * arch-utils.c (default_type_align): Always return 0.
8234         * gdbarch.h: Regenerate.
8235         * gdbarch.sh (type_align): Extend comment.
8236         * gdbtypes.c (type_align): Add additional comments, always call
8237         gdbarch_type_align before applying the default rules.
8238         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8239         generic code will then apply a suitable default.
8240         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8241         types, return 0 for other types.
8242
8243 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8244
8245         * NEWS: Create a new section for the next release branch.
8246         Rename the section of the current branch, now that it has
8247         been cut.
8248
8249 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8250
8251         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8252         * version.in: Bump version to 8.3.50.DATE-git.
8253
8254 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8255
8256         * aix-thread.c (ptid_cmp): Remove unused variable.
8257         (get_signaled_thread): Likewise.
8258         (store_regs_user_thread): Likewise.
8259         (store_regs_kernel_thread): Likewise.
8260         (fetch_regs_kernel_thread): Remove shadowed variable.
8261
8262 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8263
8264         * features/riscv/32bit-cpu.xml: Add register numbers.
8265         * features/riscv/32bit-fpu.c: Regenerate.
8266         * features/riscv/32bit-fpu.xml: Add register numbers.
8267         * features/riscv/64bit-cpu.xml: Add register numbers.
8268         * features/riscv/64bit-fpu.c: Regenerate.
8269         * features/riscv/64bit-fpu.xml: Add register numbers.
8270
8271 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8272
8273         * NEWS: Mention two argument form of gdb.Value constructor.
8274         * python/py-value.c (convert_buffer_and_type_to_value): New
8275         function.
8276         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8277         Add support for handling an optional second argument.  Call
8278         convert_buffer_and_type_to_value as appropriate.
8279         * python/python-internal.h (Py_buffer_deleter): New struct.
8280         (Py_buffer_up): New typedef.
8281
8282 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8283
8284         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8285         instead of releasing ownership.
8286
8287 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8288
8289         * dwarf2read.c (open_and_init_dwp_file): Call
8290         elf_numsections instead of bfd_count_sections to initialize
8291         dwp_file->num_sections.
8292
8293 2019-02-25  Tom Tromey  <tromey@adacore.com>
8294
8295         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8296
8297 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8298
8299         * gcore.in: Add '--readnever' option when invoking GDB.
8300
8301 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8302
8303         * MAINTAINERS: Update my email address.
8304
8305 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8306
8307         * build-id.c (build_id_to_debug_bfd_1): New function.
8308         (build_id_to_debug_bfd): Look for separate debug file in
8309         sysroot.
8310
8311 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8312
8313         * gdbarch.sh: Update the copyright year range that is placed into
8314         generated files.
8315
8316 2019-02-22  Keith Seitz  <keiths@redhat.com>
8317
8318         PR symtab/23853
8319         * linespec.c (create_sals_line_offset): Search for the default
8320         symtab's filename instead of its fullname.
8321
8322 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8323
8324         * NEWS: Update style defaults.
8325
8326 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8327
8328         * main.c (captured_main_1): Disable styling in batch mode.
8329
8330 2019-02-20  Tom Tromey  <tom@tromey.com>
8331
8332         * symtab.c (symtab_symbol_info): Fix typos.
8333
8334 2019-02-20  Tom Tromey  <tromey@adacore.com>
8335
8336         * findcmd.c (_initialize_mem_search): Use upper case for
8337         metasyntactic variables.
8338
8339 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8340
8341         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8342         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8343
8344 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8345
8346         * top.h (source_file_name): Change to std::string.
8347         * top.c (source_file_name): Likewise.
8348         (command_line_input): Adjust.
8349         * cli/cli-script.c (script_from_file): Adjust.
8350
8351 2019-02-19  Tom Tromey  <tromey@adacore.com>
8352
8353         * ravenscar-thread.c
8354         (ravenscar_thread_target::update_thread_list): Don't call
8355         ada_build_task_list.
8356         * ada-lang.h (ada_build_task_list): Don't declare.
8357         * ada-tasks.c (struct ada_tasks_inferior_data)
8358         <task_list_valid_p>: Now bool.
8359         (read_known_tasks, ada_task_list_changed)
8360         (ada_tasks_invalidate_inferior_data): Update.
8361         (read_known_tasks_array): Return bool.
8362         (read_known_tasks_list): Likewise.
8363         (read_known_tasks): Return void.
8364         (ada_build_task_list): Now static.
8365
8366 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8367
8368         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8369         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8370
8371 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8372
8373         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8374         variant for ada_tasks_pspace_data_handle and
8375         ada_tasks_inferior_data_handle.
8376         (ada_tasks_pspace_data_cleanup): New function.
8377         (ada_tasks_inferior_data_cleanup): New function.
8378
8379 2019-02-17  Tom Tromey  <tom@tromey.com>
8380
8381         * macrotab.h (macro_source_fullname): Return a std::string.
8382         * macrotab.c (macro_include, check_for_redefinition)
8383         (macro_undef, macro_lookup_definition, foreach_macro)
8384         (foreach_macro_in_scope): Update.
8385         (macro_source_fullname): Return a std::string.
8386         * macrocmd.c (show_pp_source_pos): Update.
8387
8388 2019-02-17  Tom Tromey  <tom@tromey.com>
8389
8390         * macrocmd.c (show_pp_source_pos): Style the file names.
8391
8392 2019-02-17  Tom Tromey  <tom@tromey.com>
8393
8394         PR tui/24197:
8395         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8396
8397 2019-02-17  Tom Tromey  <tom@tromey.com>
8398
8399         * ada-lang.c (user_select_syms): Use filtered printing.
8400         * utils.c (wrap_style): New global.
8401         (desired_style): Remove.
8402         (emit_style_escape): Add stream parameter.
8403         (set_output_style, reset_terminal_style, prompt_for_continue):
8404         Update.
8405         (flush_wrap_buffer): Only flush gdb_stdout.
8406         (wrap_here): Set wrap_style.
8407         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8408         treat escape sequences as a character.  Change when wrap buffer is
8409         flushed.
8410         (fputs_styled): Do not set the output style when the default is
8411         requested.
8412         * ui-style.h (struct ui_file_style) <is_default>: New method.
8413         * source.c (print_source_lines_base): Emit escape sequences in one
8414         piece.
8415
8416 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8417
8418         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8419         integers and enumeration types.
8420
8421 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8422
8423         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8424         instead of lookup_symbol_in_language
8425         (do_exact_match): New function.
8426         (ada_get_symbol_name_matcher): Return do_exact_match when
8427         doing a verbatim match.
8428
8429 2019-02-15  Tom Tromey  <tromey@adacore.com>
8430
8431         * ravenscar-thread.c (ravenscar_thread_target::resume)
8432         (ravenscar_thread_target::wait): Special case wildcard requests.
8433
8434 2019-02-15  Tom Tromey  <tromey@adacore.com>
8435
8436         * ravenscar-thread.c (base_ptid): Remove.
8437         (struct ravenscar_thread_target) <close>: New method.
8438         <m_base_ptid>: New member.
8439         <update_inferior_ptid, active_task, task_is_currently_active,
8440         runtime_initialized>: Declare methods.
8441         <ravenscar_thread_target>: Add constructor.
8442         (ravenscar_thread_target::task_is_currently_active)
8443         (ravenscar_thread_target::update_inferior_ptid)
8444         (ravenscar_runtime_initialized): Rename.  Now methods.
8445         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8446         (ravenscar_thread_target::update_thread_list): Update.
8447         (ravenscar_thread_target::active_task): Now method.
8448         (ravenscar_thread_target::store_registers)
8449         (ravenscar_thread_target::prepare_to_store)
8450         (ravenscar_thread_target::prepare_to_store)
8451         (ravenscar_thread_target::mourn_inferior): Update.
8452         (ravenscar_inferior_created): Use "new" to create target.
8453         (ravenscar_thread_target::get_ada_task_ptid): Update.
8454         (_initialize_ravenscar): Don't initialize base_ptid.
8455         (ravenscar_ops): Remove global.
8456
8457 2019-02-15  Tom Tromey  <tromey@adacore.com>
8458
8459         * target.h (push_target): Declare new overload.
8460         * target.c (push_target): New overload, taking an rvalue reference.
8461         * remote.c (remote_target::open_1): Use push_target overload.
8462         * corelow.c (core_target_open): Use push_target overload.
8463
8464 2019-02-15  Tom Tromey  <tromey@adacore.com>
8465
8466         * ravenscar-thread.c (is_ravenscar_task)
8467         (ravenscar_task_is_currently_active): Return bool.
8468         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8469         (_initialize_ravenscar): Remove "(void)".
8470         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8471         Return bool.
8472
8473 2019-02-15  Tom Tromey  <tromey@adacore.com>
8474
8475         * ravenscar-thread.c (ravenscar_runtime_initializer)
8476         (has_ravenscar_runtime, get_running_thread_id)
8477         (ravenscar_thread_target::resume): Fix indentation.
8478
8479 2019-02-15  Tom Tromey  <tromey@adacore.com>
8480
8481         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8482         from ravenscar_arch_ops.
8483         (sparc_ravenscar_ops::fetch_registers)
8484         (sparc_ravenscar_ops::store_registers): Now methods.
8485         (sparc_ravenscar_prepare_to_store): Remove.
8486         (sparc_ravenscar_ops): Redefine.
8487         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8488         methods and destructor.  Remove members.
8489         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8490         (ravenscar_thread_target::store_registers)
8491         (ravenscar_thread_target::prepare_to_store): Update.
8492         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8493         Remove.
8494         (struct ppc_ravenscar_powerpc_ops): Derive from
8495         ravenscar_arch_ops.
8496         (ppc_ravenscar_powerpc_ops::fetch_registers)
8497         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8498         (ppc_ravenscar_powerpc_ops): Redefine.
8499         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8500         (ppc_ravenscar_e500_ops::fetch_registers)
8501         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8502         (ppc_ravenscar_e500_ops): Redefine.
8503         * aarch64-ravenscar-thread.c
8504         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8505         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8506         (aarch64_ravenscar_fetch_registers)
8507         (aarch64_ravenscar_store_registers): Now methods.
8508         (aarch64_ravenscar_ops): Redefine.
8509
8510 2019-02-15  Tom Tromey  <tromey@adacore.com>
8511
8512         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8513         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8514         (ravenscar_thread_target::stopped_by_watchpoint)
8515         (ravenscar_thread_target::stopped_data_address)
8516         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8517
8518 2019-02-15  Tom Tromey  <tromey@adacore.com>
8519
8520         * ravenscar-thread.c: Fix some typos.
8521
8522 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8523             Tom Tromey  <tromey@adacore.com>
8524
8525         * ada-lang.c (ada_exception_sal): Change addr_string to a
8526         std::string.
8527         (create_ada_exception_catchpoint): Update.
8528
8529 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8530             Tom Tromey  <tromey@adacore.com>
8531
8532         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8533         (bp_location_ops): Remove.
8534         (base_breakpoint_allocate_location): Update.
8535         (free_bp_location): Update.
8536         * ada-lang.c (class ada_catchpoint_location)
8537         <ada_catchpoint_location>: Remove ops parameter.
8538         (ada_catchpoint_location_dtor): Remove.
8539         (ada_catchpoint_location_ops): Remove.
8540         (allocate_location_exception): Update.
8541         * breakpoint.h (struct bp_location_ops): Remove.
8542         (class bp_location) <bp_location>: Remove bp_location_ops
8543         parameter.
8544         <~bp_location>: Add destructor.
8545         <ops>: Remove.
8546
8547 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8548             Pedro Alves  <palves@redhat.com>
8549
8550         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8551         'PATH_MAX'.
8552
8553 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8554             Samuel Thibault  <samuel.thibault@gnu.org>
8555             Thomas Schwinge  <thomas@codesourcery.com>
8556
8557         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8558         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8559
8560 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8561
8562         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8563         (check_empty): Use "const char *".
8564
8565         * gnu-nat.c (gnu_nat_target::detach): Instead of
8566         'detach_inferior (pid)' call
8567         'detach_inferior (find_inferior_pid (pid))'.
8568
8569         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8570         'nat/fork-inferior.o'.
8571         * gnu-nat.c: #include "nat/fork-inferior.h".
8572
8573         * gnu-nat.c (gnu_nat_target::detach): Instead of
8574         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8575         * gnu-nat.h: #include "inf-child.h".
8576         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8577         'i386_gnu_nat_target::fetch_registers'.
8578         (gnu_store_registers): Rename/move to
8579         'i386_gnu_nat_target::store_registers'.
8580
8581         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8582         * gnu-nat.h (mach_thread_info): New function.
8583         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8584
8585         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8586
8587 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8588
8589         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8590
8591 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8592
8593         * windows-nat.c (windows_add_thread): Add new parameter
8594         "main_thread_p" with default value set to false.  Update
8595         function documentation as well as all callers.
8596         (windows_delete_thread): Likewise.
8597         (fake_create_process): Update call to windows_add_thread.
8598         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8599         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8600         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8601         call to windows_delete_thread.
8602
8603 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8604
8605         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8606
8607 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8608
8609         * symfile.c (find_separate_debug_file): Use canonical path of
8610         sysroot with child_path instead of gdb_sysroot if it is valid.
8611
8612 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8613
8614         * symfile.c (find_separate_debug_file): Use child_path to
8615         determine if an object file is under a sysroot.
8616
8617 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8618
8619         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8620         unittests/child-path-selftests.c.
8621         * common/pathstuff.c (child_path): New function.
8622         * common/pathstuff.h (child_path): New prototype.
8623         * unittests/child-path-selftests.c: New file.
8624
8625 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8626
8627         * symfile.c (find_separate_debug_file): Look for separate debug
8628         files in debug directories under the sysroot.
8629
8630 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8631
8632         * symtab.h (struct minimal_symbol data_p): New const method.
8633         (struct minimal_symbol text_p): Likewise.
8634         * symtab.c (output_source_filename): Use file name style
8635         to print file name.
8636         (print_symbol_info): Likewise.
8637         (print_msymbol_info): Use address style to print addresses.
8638         Use function name style to print executable text symbols.
8639         (expand_symtab_containing_pc): Use data_p.
8640         (find_pc_sect_compunit_symtab): Likewise.
8641
8642 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8643
8644         * breakpoint.c (describe_other_breakpoints): Use address style
8645         to print addresses.
8646         (say_where): Likewise.
8647
8648 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8649
8650         * ada-typeprint.c (print_func_type): Print function name
8651         style to print function name.
8652         * c-typeprint.c (c_print_type_1): Likewise.
8653
8654 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8655
8656         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8657         for execve.
8658
8659 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8660
8661         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8662         type_stack.
8663
8664 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8665
8666         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8667         TYPE_CODE_REF types.
8668
8669 2019-02-08  Jim Wilson  <jimw@sifive.com>
8670
8671         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8672         (riscv_linux_fregset): New.
8673         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8674
8675 2019-02-07  Tom Tromey  <tom@tromey.com>
8676
8677         * thread.c (thread_cancel_execution_command): Update.
8678         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8679         methods.
8680         (struct thread_fsm_ops): Remove.
8681         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8682         (thread_fsm_should_stop, thread_fsm_return_value)
8683         (thread_fsm_set_finished, thread_fsm_finished_p)
8684         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8685         Don't declare.
8686         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8687         * infrun.c (clear_proceed_status_thread)
8688         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8689         (print_stop_event): Update.
8690         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8691         Add constructor.
8692         (step_command_fsm_ops): Remove.
8693         (new_step_command_fsm): Remove.
8694         (step_1): Update.
8695         (step_command_fsm::should_stop): Rename from
8696         step_command_fsm_should_stop.
8697         (step_command_fsm::clean_up): Rename from
8698         step_command_fsm_clean_up.
8699         (step_command_fsm::do_async_reply_reason): Rename from
8700         step_command_fsm_async_reply_reason.
8701         (struct until_next_fsm): Inherit from thread_fsm.  Add
8702         constructor.
8703         (until_next_fsm_ops): Remove.
8704         (new_until_next_fsm): Remove.
8705         (until_next_fsm::should_stop): Rename from
8706         until_next_fsm_should_stop.
8707         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8708         (until_next_fsm::do_async_reply_reason): Rename from
8709         until_next_fsm_async_reply_reason.
8710         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8711         constructor.  Change type of breakpoint.
8712         (finish_command_fsm_ops): Remove.
8713         (new_finish_command_fsm): Remove.
8714         (finish_command_fsm::should_stop): Rename from
8715         finish_command_fsm_should_stop.
8716         (finish_command_fsm::clean_up): Rename from
8717         finish_command_fsm_clean_up.
8718         (finish_command_fsm::return_value): Rename from
8719         finish_command_fsm_return_value.
8720         (finish_command_fsm::do_async_reply_reason): Rename from
8721         finish_command_fsm_async_reply_reason.
8722         (finish_command): Update.
8723         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8724         Add constructor.
8725         (call_thread_fsm_ops): Remove.
8726         (call_thread_fsm::call_thread_fsm): Rename from
8727         new_call_thread_fsm.
8728         (call_thread_fsm::should_stop): Rename from
8729         call_thread_fsm_should_stop.
8730         (call_thread_fsm::should_notify_stop): Rename from
8731         call_thread_fsm_should_notify_stop.
8732         (run_inferior_call, call_function_by_hand_dummy): Update.
8733         * cli/cli-interp.c (should_print_stop_to_console): Update.
8734         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8735         Add constructor.  Change type of location_breakpoint,
8736         caller_breakpoint.
8737         (until_break_fsm_ops): Remove.
8738         (new_until_break_fsm): Remove.
8739         (until_break_fsm::should_stop): Rename from
8740         until_break_fsm_should_stop.
8741         (until_break_fsm::clean_up): Rename from
8742         until_break_fsm_clean_up.
8743         (until_break_fsm::do_async_reply_reason): Rename from
8744         until_break_fsm_async_reply_reason.
8745         (until_break_command): Update.
8746         * thread-fsm.c: Remove.
8747         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8748
8749 2019-02-07  Tom Tromey  <tom@tromey.com>
8750
8751         * yy-remap.h: Add include guard.
8752         * xtensa-tdep.h: Add include guard.
8753         * xcoffread.h: Rename include guard.
8754         * varobj-iter.h: Add include guard.
8755         * tui/tui.h: Rename include guard.
8756         * tui/tui-winsource.h: Rename include guard.
8757         * tui/tui-wingeneral.h: Rename include guard.
8758         * tui/tui-windata.h: Rename include guard.
8759         * tui/tui-win.h: Rename include guard.
8760         * tui/tui-stack.h: Rename include guard.
8761         * tui/tui-source.h: Rename include guard.
8762         * tui/tui-regs.h: Rename include guard.
8763         * tui/tui-out.h: Rename include guard.
8764         * tui/tui-layout.h: Rename include guard.
8765         * tui/tui-io.h: Rename include guard.
8766         * tui/tui-hooks.h: Rename include guard.
8767         * tui/tui-file.h: Rename include guard.
8768         * tui/tui-disasm.h: Rename include guard.
8769         * tui/tui-data.h: Rename include guard.
8770         * tui/tui-command.h: Rename include guard.
8771         * tic6x-tdep.h: Add include guard.
8772         * target/waitstatus.h: Rename include guard.
8773         * target/wait.h: Rename include guard.
8774         * target/target.h: Rename include guard.
8775         * target/resume.h: Rename include guard.
8776         * target-float.h: Rename include guard.
8777         * stabsread.h: Add include guard.
8778         * rs6000-tdep.h: Add include guard.
8779         * riscv-fbsd-tdep.h: Add include guard.
8780         * regformats/regdef.h: Rename include guard.
8781         * record.h: Rename include guard.
8782         * python/python.h: Rename include guard.
8783         * python/python-internal.h: Rename include guard.
8784         * python/py-stopevent.h: Rename include guard.
8785         * python/py-ref.h: Rename include guard.
8786         * python/py-record.h: Rename include guard.
8787         * python/py-record-full.h: Rename include guard.
8788         * python/py-record-btrace.h: Rename include guard.
8789         * python/py-instruction.h: Rename include guard.
8790         * python/py-events.h: Rename include guard.
8791         * python/py-event.h: Rename include guard.
8792         * procfs.h: Add include guard.
8793         * proc-utils.h: Add include guard.
8794         * p-lang.h: Add include guard.
8795         * or1k-tdep.h: Rename include guard.
8796         * observable.h: Rename include guard.
8797         * nto-tdep.h: Rename include guard.
8798         * nat/x86-linux.h: Rename include guard.
8799         * nat/x86-linux-dregs.h: Rename include guard.
8800         * nat/x86-gcc-cpuid.h: Add include guard.
8801         * nat/x86-dregs.h: Rename include guard.
8802         * nat/x86-cpuid.h: Rename include guard.
8803         * nat/ppc-linux.h: Rename include guard.
8804         * nat/mips-linux-watch.h: Rename include guard.
8805         * nat/linux-waitpid.h: Rename include guard.
8806         * nat/linux-ptrace.h: Rename include guard.
8807         * nat/linux-procfs.h: Rename include guard.
8808         * nat/linux-osdata.h: Rename include guard.
8809         * nat/linux-nat.h: Rename include guard.
8810         * nat/linux-namespaces.h: Rename include guard.
8811         * nat/linux-btrace.h: Rename include guard.
8812         * nat/glibc_thread_db.h: Rename include guard.
8813         * nat/gdb_thread_db.h: Rename include guard.
8814         * nat/gdb_ptrace.h: Rename include guard.
8815         * nat/fork-inferior.h: Rename include guard.
8816         * nat/amd64-linux-siginfo.h: Rename include guard.
8817         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8818         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8819         * nat/aarch64-linux.h: Rename include guard.
8820         * nat/aarch64-linux-hw-point.h: Rename include guard.
8821         * mn10300-tdep.h: Add include guard.
8822         * mips-linux-tdep.h: Add include guard.
8823         * mi/mi-parse.h: Rename include guard.
8824         * mi/mi-out.h: Rename include guard.
8825         * mi/mi-main.h: Rename include guard.
8826         * mi/mi-interp.h: Rename include guard.
8827         * mi/mi-getopt.h: Rename include guard.
8828         * mi/mi-console.h: Rename include guard.
8829         * mi/mi-common.h: Rename include guard.
8830         * mi/mi-cmds.h: Rename include guard.
8831         * mi/mi-cmd-break.h: Rename include guard.
8832         * m2-lang.h: Add include guard.
8833         * location.h: Rename include guard.
8834         * linux-record.h: Rename include guard.
8835         * linux-nat.h: Add include guard.
8836         * linux-fork.h: Add include guard.
8837         * i386-darwin-tdep.h: Rename include guard.
8838         * hppa-linux-offsets.h: Add include guard.
8839         * guile/guile.h: Rename include guard.
8840         * guile/guile-internal.h: Rename include guard.
8841         * gnu-nat.h: Rename include guard.
8842         * gdb-stabs.h: Rename include guard.
8843         * frv-tdep.h: Add include guard.
8844         * f-lang.h: Add include guard.
8845         * event-loop.h: Add include guard.
8846         * darwin-nat.h: Rename include guard.
8847         * cp-abi.h: Rename include guard.
8848         * config/sparc/nm-sol2.h: Rename include guard.
8849         * config/nm-nto.h: Rename include guard.
8850         * config/nm-linux.h: Add include guard.
8851         * config/i386/nm-i386gnu.h: Rename include guard.
8852         * config/djgpp/nl_types.h: Rename include guard.
8853         * config/djgpp/langinfo.h: Rename include guard.
8854         * compile/gcc-cp-plugin.h: Add include guard.
8855         * compile/gcc-c-plugin.h: Add include guard.
8856         * compile/compile.h: Rename include guard.
8857         * compile/compile-object-run.h: Rename include guard.
8858         * compile/compile-object-load.h: Rename include guard.
8859         * compile/compile-internal.h: Rename include guard.
8860         * compile/compile-cplus.h: Rename include guard.
8861         * compile/compile-c.h: Rename include guard.
8862         * common/xml-utils.h: Rename include guard.
8863         * common/x86-xstate.h: Rename include guard.
8864         * common/version.h: Rename include guard.
8865         * common/vec.h: Rename include guard.
8866         * common/tdesc.h: Rename include guard.
8867         * common/selftest.h: Rename include guard.
8868         * common/scoped_restore.h: Rename include guard.
8869         * common/scoped_mmap.h: Rename include guard.
8870         * common/scoped_fd.h: Rename include guard.
8871         * common/safe-iterator.h: Rename include guard.
8872         * common/run-time-clock.h: Rename include guard.
8873         * common/refcounted-object.h: Rename include guard.
8874         * common/queue.h: Rename include guard.
8875         * common/ptid.h: Rename include guard.
8876         * common/print-utils.h: Rename include guard.
8877         * common/preprocessor.h: Rename include guard.
8878         * common/pathstuff.h: Rename include guard.
8879         * common/observable.h: Rename include guard.
8880         * common/netstuff.h: Rename include guard.
8881         * common/job-control.h: Rename include guard.
8882         * common/host-defs.h: Rename include guard.
8883         * common/gdb_wait.h: Rename include guard.
8884         * common/gdb_vecs.h: Rename include guard.
8885         * common/gdb_unlinker.h: Rename include guard.
8886         * common/gdb_unique_ptr.h: Rename include guard.
8887         * common/gdb_tilde_expand.h: Rename include guard.
8888         * common/gdb_sys_time.h: Rename include guard.
8889         * common/gdb_string_view.h: Rename include guard.
8890         * common/gdb_splay_tree.h: Rename include guard.
8891         * common/gdb_setjmp.h: Rename include guard.
8892         * common/gdb_ref_ptr.h: Rename include guard.
8893         * common/gdb_optional.h: Rename include guard.
8894         * common/gdb_locale.h: Rename include guard.
8895         * common/gdb_assert.h: Rename include guard.
8896         * common/filtered-iterator.h: Rename include guard.
8897         * common/filestuff.h: Rename include guard.
8898         * common/fileio.h: Rename include guard.
8899         * common/environ.h: Rename include guard.
8900         * common/common-utils.h: Rename include guard.
8901         * common/common-types.h: Rename include guard.
8902         * common/common-regcache.h: Rename include guard.
8903         * common/common-inferior.h: Rename include guard.
8904         * common/common-gdbthread.h: Rename include guard.
8905         * common/common-exceptions.h: Rename include guard.
8906         * common/common-defs.h: Rename include guard.
8907         * common/common-debug.h: Rename include guard.
8908         * common/cleanups.h: Rename include guard.
8909         * common/buffer.h: Rename include guard.
8910         * common/btrace-common.h: Rename include guard.
8911         * common/break-common.h: Rename include guard.
8912         * cli/cli-utils.h: Rename include guard.
8913         * cli/cli-style.h: Rename include guard.
8914         * cli/cli-setshow.h: Rename include guard.
8915         * cli/cli-script.h: Rename include guard.
8916         * cli/cli-interp.h: Rename include guard.
8917         * cli/cli-decode.h: Rename include guard.
8918         * cli/cli-cmds.h: Rename include guard.
8919         * charset-list.h: Add include guard.
8920         * buildsym-legacy.h: Rename include guard.
8921         * bfin-tdep.h: Add include guard.
8922         * ax.h: Rename include guard.
8923         * arm-linux-tdep.h: Add include guard.
8924         * arm-fbsd-tdep.h: Add include guard.
8925         * arch/xtensa.h: Rename include guard.
8926         * arch/tic6x.h: Add include guard.
8927         * arch/i386.h: Add include guard.
8928         * arch/arm.h: Rename include guard.
8929         * arch/arm-linux.h: Rename include guard.
8930         * arch/arm-get-next-pcs.h: Rename include guard.
8931         * arch/amd64.h: Add include guard.
8932         * arch/aarch64-insn.h: Rename include guard.
8933         * arch-utils.h: Rename include guard.
8934         * annotate.h: Add include guard.
8935         * amd64-darwin-tdep.h: Rename include guard.
8936         * aarch64-linux-tdep.h: Add include guard.
8937         * aarch64-fbsd-tdep.h: Add include guard.
8938         * aarch32-linux-nat.h: Add include guard.
8939
8940 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8941
8942         * macrotab.c (macro_define_internal): New function that
8943         factorizes macro_define_object_internal and macro_define_function
8944         code.
8945         (macro_define_object_internal): Use macro_define_internal.
8946         (macro_define_function): Likewise.
8947
8948 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8949
8950         * macrocmd.c (extract_identifier): Return
8951         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8952         callers.
8953
8954 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8955
8956         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8957
8958 2019-02-05  Tom Tromey  <tom@tromey.com>
8959
8960         * target.c (target_stack::unpush): Move assertion earlier.
8961
8962 2019-01-30  Tom Tromey  <tom@tromey.com>
8963
8964         PR python/23615:
8965         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8966         (gdbpy_parse_and_eval): Likewise.
8967         * python/python-internal.h (gdbpy_allow_threads): New class.
8968
8969 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8970
8971         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8972         (aarch64_fbsd_fpregmap): Move earlier.
8973         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8974         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8975         instead of individual calls to trad_frame_set_reg_addr.
8976         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8977         earlier.
8978         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8979         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8980         instead of individual calls to trad_frame_set_reg_addr.
8981
8982 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8983
8984         * CONTRIBUTE: Replace contribution list with wiki link.
8985
8986 2019-01-25  Tom Tromey  <tom@tromey.com>
8987
8988         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8989
8990 2019-01-25  Tom Tromey  <tom@tromey.com>
8991
8992         * xtensa-linux-nat.c: Fix common/ includes.
8993         * xml-support.h: Fix common/ includes.
8994         * xml-support.c: Fix common/ includes.
8995         * x86-linux-nat.c: Fix common/ includes.
8996         * windows-nat.c: Fix common/ includes.
8997         * varobj.h: Fix common/ includes.
8998         * varobj.c: Fix common/ includes.
8999         * value.c: Fix common/ includes.
9000         * valops.c: Fix common/ includes.
9001         * utils.c: Fix common/ includes.
9002         * unittests/xml-utils-selftests.c: Fix common/ includes.
9003         * unittests/utils-selftests.c: Fix common/ includes.
9004         * unittests/unpack-selftests.c: Fix common/ includes.
9005         * unittests/tracepoint-selftests.c: Fix common/ includes.
9006         * unittests/style-selftests.c: Fix common/ includes.
9007         * unittests/string_view-selftests.c: Fix common/ includes.
9008         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9009         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9010         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9011         * unittests/rsp-low-selftests.c: Fix common/ includes.
9012         * unittests/parse-connection-spec-selftests.c: Fix common/
9013         includes.
9014         * unittests/optional-selftests.c: Fix common/ includes.
9015         * unittests/offset-type-selftests.c: Fix common/ includes.
9016         * unittests/observable-selftests.c: Fix common/ includes.
9017         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9018         * unittests/memrange-selftests.c: Fix common/ includes.
9019         * unittests/memory-map-selftests.c: Fix common/ includes.
9020         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9021         * unittests/function-view-selftests.c: Fix common/ includes.
9022         * unittests/environ-selftests.c: Fix common/ includes.
9023         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9024         * unittests/common-utils-selftests.c: Fix common/ includes.
9025         * unittests/cli-utils-selftests.c: Fix common/ includes.
9026         * unittests/array-view-selftests.c: Fix common/ includes.
9027         * ui-file.c: Fix common/ includes.
9028         * tui/tui-io.c: Fix common/ includes.
9029         * tracepoint.h: Fix common/ includes.
9030         * tracepoint.c: Fix common/ includes.
9031         * tracefile-tfile.c: Fix common/ includes.
9032         * top.h: Fix common/ includes.
9033         * top.c: Fix common/ includes.
9034         * thread.c: Fix common/ includes.
9035         * target/waitstatus.h: Fix common/ includes.
9036         * target/waitstatus.c: Fix common/ includes.
9037         * target.h: Fix common/ includes.
9038         * target.c: Fix common/ includes.
9039         * target-memory.c: Fix common/ includes.
9040         * target-descriptions.c: Fix common/ includes.
9041         * symtab.h: Fix common/ includes.
9042         * symfile.c: Fix common/ includes.
9043         * stap-probe.c: Fix common/ includes.
9044         * spu-linux-nat.c: Fix common/ includes.
9045         * sparc-nat.c: Fix common/ includes.
9046         * source.c: Fix common/ includes.
9047         * solib.c: Fix common/ includes.
9048         * solib-target.c: Fix common/ includes.
9049         * ser-unix.c: Fix common/ includes.
9050         * ser-tcp.c: Fix common/ includes.
9051         * ser-pipe.c: Fix common/ includes.
9052         * ser-base.c: Fix common/ includes.
9053         * selftest-arch.c: Fix common/ includes.
9054         * s12z-tdep.c: Fix common/ includes.
9055         * rust-exp.y: Fix common/ includes.
9056         * rs6000-aix-tdep.c: Fix common/ includes.
9057         * riscv-tdep.c: Fix common/ includes.
9058         * remote.c: Fix common/ includes.
9059         * remote-notif.h: Fix common/ includes.
9060         * remote-fileio.h: Fix common/ includes.
9061         * remote-fileio.c: Fix common/ includes.
9062         * regcache.h: Fix common/ includes.
9063         * regcache.c: Fix common/ includes.
9064         * record-btrace.c: Fix common/ includes.
9065         * python/python.c: Fix common/ includes.
9066         * python/py-type.c: Fix common/ includes.
9067         * python/py-inferior.c: Fix common/ includes.
9068         * progspace.h: Fix common/ includes.
9069         * producer.c: Fix common/ includes.
9070         * procfs.c: Fix common/ includes.
9071         * proc-api.c: Fix common/ includes.
9072         * printcmd.c: Fix common/ includes.
9073         * ppc-linux-nat.c: Fix common/ includes.
9074         * parser-defs.h: Fix common/ includes.
9075         * osdata.c: Fix common/ includes.
9076         * obsd-nat.c: Fix common/ includes.
9077         * nat/x86-linux.c: Fix common/ includes.
9078         * nat/x86-linux-dregs.c: Fix common/ includes.
9079         * nat/x86-dregs.h: Fix common/ includes.
9080         * nat/x86-dregs.c: Fix common/ includes.
9081         * nat/ppc-linux.c: Fix common/ includes.
9082         * nat/mips-linux-watch.h: Fix common/ includes.
9083         * nat/mips-linux-watch.c: Fix common/ includes.
9084         * nat/linux-waitpid.c: Fix common/ includes.
9085         * nat/linux-ptrace.h: Fix common/ includes.
9086         * nat/linux-ptrace.c: Fix common/ includes.
9087         * nat/linux-procfs.c: Fix common/ includes.
9088         * nat/linux-personality.c: Fix common/ includes.
9089         * nat/linux-osdata.c: Fix common/ includes.
9090         * nat/linux-namespaces.c: Fix common/ includes.
9091         * nat/linux-btrace.h: Fix common/ includes.
9092         * nat/linux-btrace.c: Fix common/ includes.
9093         * nat/fork-inferior.c: Fix common/ includes.
9094         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9095         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9096         * nat/aarch64-linux.c: Fix common/ includes.
9097         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9098         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9099         * namespace.h: Fix common/ includes.
9100         * mips-linux-tdep.c: Fix common/ includes.
9101         * minsyms.c: Fix common/ includes.
9102         * mi/mi-parse.h: Fix common/ includes.
9103         * mi/mi-main.c: Fix common/ includes.
9104         * mi/mi-cmd-env.c: Fix common/ includes.
9105         * memrange.h: Fix common/ includes.
9106         * memattr.c: Fix common/ includes.
9107         * maint.h: Fix common/ includes.
9108         * maint.c: Fix common/ includes.
9109         * main.c: Fix common/ includes.
9110         * machoread.c: Fix common/ includes.
9111         * location.c: Fix common/ includes.
9112         * linux-thread-db.c: Fix common/ includes.
9113         * linux-nat.c: Fix common/ includes.
9114         * linux-fork.c: Fix common/ includes.
9115         * inline-frame.c: Fix common/ includes.
9116         * infrun.c: Fix common/ includes.
9117         * inflow.c: Fix common/ includes.
9118         * inferior.h: Fix common/ includes.
9119         * inferior.c: Fix common/ includes.
9120         * infcmd.c: Fix common/ includes.
9121         * inf-ptrace.c: Fix common/ includes.
9122         * inf-child.c: Fix common/ includes.
9123         * ia64-linux-nat.c: Fix common/ includes.
9124         * i387-tdep.c: Fix common/ includes.
9125         * i386-tdep.c: Fix common/ includes.
9126         * i386-linux-tdep.c: Fix common/ includes.
9127         * i386-linux-nat.c: Fix common/ includes.
9128         * i386-go32-tdep.c: Fix common/ includes.
9129         * i386-fbsd-tdep.c: Fix common/ includes.
9130         * i386-fbsd-nat.c: Fix common/ includes.
9131         * guile/scm-type.c: Fix common/ includes.
9132         * guile/guile.c: Fix common/ includes.
9133         * go32-nat.c: Fix common/ includes.
9134         * gnu-nat.c: Fix common/ includes.
9135         * gdbthread.h: Fix common/ includes.
9136         * gdbarch-selftests.c: Fix common/ includes.
9137         * gdb_usleep.c: Fix common/ includes.
9138         * gdb_select.h: Fix common/ includes.
9139         * gdb_bfd.c: Fix common/ includes.
9140         * gcore.c: Fix common/ includes.
9141         * fork-child.c: Fix common/ includes.
9142         * findvar.c: Fix common/ includes.
9143         * fbsd-nat.c: Fix common/ includes.
9144         * event-top.c: Fix common/ includes.
9145         * event-loop.c: Fix common/ includes.
9146         * dwarf2read.c: Fix common/ includes.
9147         * dwarf2loc.c: Fix common/ includes.
9148         * dwarf2-frame.c: Fix common/ includes.
9149         * dwarf-index-cache.c: Fix common/ includes.
9150         * dtrace-probe.c: Fix common/ includes.
9151         * disasm-selftests.c: Fix common/ includes.
9152         * defs.h: Fix common/ includes.
9153         * csky-tdep.c: Fix common/ includes.
9154         * cp-valprint.c: Fix common/ includes.
9155         * cp-support.h: Fix common/ includes.
9156         * cp-support.c: Fix common/ includes.
9157         * corelow.c: Fix common/ includes.
9158         * completer.h: Fix common/ includes.
9159         * completer.c: Fix common/ includes.
9160         * compile/compile.c: Fix common/ includes.
9161         * compile/compile-loc2c.c: Fix common/ includes.
9162         * compile/compile-cplus-types.c: Fix common/ includes.
9163         * compile/compile-cplus-symbols.c: Fix common/ includes.
9164         * command.h: Fix common/ includes.
9165         * cli/cli-dump.c: Fix common/ includes.
9166         * cli/cli-cmds.c: Fix common/ includes.
9167         * charset.c: Fix common/ includes.
9168         * build-id.c: Fix common/ includes.
9169         * btrace.h: Fix common/ includes.
9170         * btrace.c: Fix common/ includes.
9171         * breakpoint.h: Fix common/ includes.
9172         * breakpoint.c: Fix common/ includes.
9173         * ax.h:
9174         (enum agent_op): Fix common/ includes.
9175         * ax-general.c (struct aop_map): Fix common/ includes.
9176         * ax-gdb.c: Fix common/ includes.
9177         * auxv.c: Fix common/ includes.
9178         * auto-load.c: Fix common/ includes.
9179         * arm-tdep.c: Fix common/ includes.
9180         * arch/riscv.c: Fix common/ includes.
9181         * arch/ppc-linux-common.c: Fix common/ includes.
9182         * arch/i386.c: Fix common/ includes.
9183         * arch/arm.c: Fix common/ includes.
9184         * arch/arm-linux.c: Fix common/ includes.
9185         * arch/arm-get-next-pcs.c: Fix common/ includes.
9186         * arch/amd64.c: Fix common/ includes.
9187         * arch/aarch64.c: Fix common/ includes.
9188         * arch/aarch64-insn.c: Fix common/ includes.
9189         * arch-utils.c: Fix common/ includes.
9190         * amd64-windows-tdep.c: Fix common/ includes.
9191         * amd64-tdep.c: Fix common/ includes.
9192         * amd64-sol2-tdep.c: Fix common/ includes.
9193         * amd64-obsd-tdep.c: Fix common/ includes.
9194         * amd64-nbsd-tdep.c: Fix common/ includes.
9195         * amd64-linux-tdep.c: Fix common/ includes.
9196         * amd64-linux-nat.c: Fix common/ includes.
9197         * amd64-fbsd-tdep.c: Fix common/ includes.
9198         * amd64-fbsd-nat.c: Fix common/ includes.
9199         * amd64-dicos-tdep.c: Fix common/ includes.
9200         * amd64-darwin-tdep.c: Fix common/ includes.
9201         * agent.c: Fix common/ includes.
9202         * ada-lang.h: Fix common/ includes.
9203         * ada-lang.c: Fix common/ includes.
9204         * aarch64-tdep.c: Fix common/ includes.
9205
9206 2019-01-25  Tom Tromey  <tom@tromey.com>
9207
9208         * common/create-version.sh: Use common/version.h.
9209
9210 2019-01-24  Pedro Alves  <palves@redhat.com>
9211
9212         * infrun.c (signal_stop, signal_print, signal_program)
9213         (signal_catch, signal_pass): Now arrays instead of pointers.
9214         (update_signals_program_target, do_target_resume)
9215         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9216         * linux-nat.c (linux_nat_target::pass_signals)
9217         (linux_nat_target::create_inferior, linux_nat_target::attach):
9218         Adjust.
9219         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9220         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9221         * procfs.c (procfs_target::pass_signals): Adjust.
9222         * record-full.c (record_full_target::resume): Adjust.
9223         * remote.c (remote_target::pass_signals)
9224         (remote_target::program_signals): Adjust.
9225         * target-debug.h (target_debug_print_signals): Now takes a
9226         gdb::array_view as parameter.  Adjust.
9227         * target.h (target_ops) <pass_signals, program_signals>: Replace
9228         pointer and length parameters with gdb::array_view.
9229         (target_pass_signals, target_program_signals): Likewise.
9230         * target-delegates.c: Regenerate.
9231
9232 2019-01-24  Pedro Alves  <palves@redhat.com>
9233
9234         * common/forward-scope-exit.h
9235         (forward_scope_exit::forward_scope_exit): Pass arguments to
9236         m_bind_function directly, instead of creating a std::bind and
9237         copying that.
9238
9239 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9240
9241         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9242         for static members.
9243         (pass_in_v_vfp_candidate): Likewise.
9244
9245 2019-01-23  Tom Tromey  <tom@tromey.com>
9246             Pedro Alves  <palves@redhat.com>
9247
9248         * regcache.c (class regcache_invalidator): Remove.
9249         (regcache::raw_write): Use make_scope_exit.
9250
9251 2019-01-23  Tom Tromey  <tom@tromey.com>
9252
9253         * ui-out.h (class ui_out_emit_type): Update comment.
9254
9255 2019-01-23  Tom Tromey  <tom@tromey.com>
9256
9257         * infrun.c (fetch_inferior_event): Update comment.
9258
9259 2019-01-23  Tom Tromey  <tom@tromey.com>
9260             Pedro Alves  <palves@redhat.com>
9261
9262         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9263         parameter.
9264         (fetch_inferior_event): Use SCOPE_EXIT.
9265
9266
9267 2019-01-23  Tom Tromey  <tom@tromey.com>
9268             Pedro Alves  <palves@redhat.com>
9269
9270         * infrun.c (disable_thread_events): Delete.
9271         (stop_all_threads): Use SCOPE_EXIT.
9272
9273 2019-01-23  Tom Tromey  <tom@tromey.com>
9274             Pedro Alves  <palves@redhat.com>
9275
9276         * symfile.c: Include forward-scope-exit.h.
9277         (clear_symtab_users_cleanup): Replace forward declaration with
9278         a FORWARD_SCOPE_EXIT.
9279         (syms_from_objfile_1): Use the forward_scope_exit and
9280         gdb::optional instead of cleanup_function.
9281         (reread_symbols): Use the forward_scope_exit instead of
9282         cleanup_function.
9283         (clear_symtab_users_cleanup): Remove function.
9284
9285 2019-01-23  Tom Tromey  <tom@tromey.com>
9286             Pedro Alves  <palves@redhat.com>
9287
9288         * linux-nat.c: Include scope-exit.h.
9289         (cleanup_target_stop): Remove.
9290         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9291         SCOPE_EXIT.
9292
9293 2019-01-23  Tom Tromey  <tom@tromey.com>
9294             Pedro Alves  <palves@redhat.com>
9295
9296         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9297         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9298
9299 2019-01-23  Tom Tromey  <tom@tromey.com>
9300             Andrew Burgess  <andrew.burgess@embecosm.com>
9301             Pedro Alves  <palves@redhat.com>
9302
9303         * infrun.c (fetch_inferior_event): Use scope_exit.
9304         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9305         * top.c (execute_command): Use scope_exit.
9306         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9307         * utils.c (do_bpstat_clear_actions_cleanup)
9308         (make_bpstat_clear_actions_cleanup): Remove.
9309
9310 2019-01-23  Tom Tromey  <tom@tromey.com>
9311             Pedro Alves  <palves@redhat.com>
9312
9313         * infrun.c: Include "common/scope-exit.h"
9314         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9315         (wait_for_inferior): Use SCOPE_EXIT.
9316         (fetch_inferior_event): Use scope_exit.
9317
9318 2019-01-23  Tom Tromey  <tom@tromey.com>
9319             Pedro Alves  <palves@redhat.com>
9320
9321         * breakpoint.c (create_breakpoint): Remove cleanup.
9322
9323 2019-01-23  Tom Tromey  <tom@tromey.com>
9324             Andrew Burgess  <andrew.burgess@embecosm.com>
9325             Pedro Alves  <palves@redhat.com>
9326
9327 2019-01-23  Pedro Alves  <palves@redhat.com>
9328
9329         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9330
9331 2019-01-23  Pedro Alves  <palves@redhat.com>
9332             Andrew Burgess  <andrew.burgess@embecosm.com>
9333
9334         * gdbthread.h: Include "common/forward-scope-exit.h".
9335         (scoped_finish_thread_state): Redefine custom class in terms of
9336         forward_scope_exit.
9337
9338 2019-01-23  Pedro Alves  <palves@redhat.com>
9339             Andrew Burgess  <andrew.burgess@embecosm.com>
9340
9341         * common/forward-scope-exit.h: New file.
9342
9343 2019-01-23  Pedro Alves  <palves@redhat.com>
9344             Andrew Burgess  <andrew.burgess@embecosm.com>
9345             Tom Tromey  <tom@tromey.com>
9346
9347         * common/scope-exit.h: New file.
9348
9349 2019-01-23  Pedro Alves  <palves@redhat.com>
9350
9351         * common/preprocessor.h (ESC): Rename to ...
9352         (ESC_PARENS): ... this.
9353         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9354         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9355
9356 2019-01-23  Tom Tromey  <tom@tromey.com>
9357
9358         * language.h (class scoped_switch_to_sym_language_if_auto):
9359         Initialize m_lang in both cases.
9360
9361 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9362
9363         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9364         with XCNEW.
9365
9366 2019-01-22  Tom Tromey  <tom@tromey.com>
9367
9368         * corelow.c: Do not include sys/file.h.
9369
9370 2019-01-22  Tom Tromey  <tom@tromey.com>
9371
9372         * tui/tui-wingeneral.h: Include gdb_curses.h.
9373
9374 2019-01-22  Tom Tromey  <tom@tromey.com>
9375
9376         * source-cache.h (class source_cache) <get_source_lines,
9377         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9378
9379 2019-01-22  Tom Tromey  <tom@tromey.com>
9380
9381         * remote-fileio.h (struct remote_target): Declare.
9382
9383 2019-01-22  Tom Tromey  <tom@tromey.com>
9384
9385         * python/py-arch.c: Do not include py-ref.h.
9386         * python/py-bpevent.c: Do not include py-ref.h.
9387         * python/py-cmd.c: Do not include py-ref.h.
9388         * python/py-continueevent.c: Do not include py-ref.h.
9389         * python/py-event.h: Do not include py-ref.h.
9390         * python/py-evtregistry.c: Do not include py-ref.h.
9391         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9392         * python/py-frame.c: Do not include py-ref.h.
9393         * python/py-framefilter.c: Do not include py-ref.h.
9394         * python/py-function.c: Do not include py-ref.h.
9395         * python/py-infevents.c: Do not include py-ref.h.
9396         * python/py-linetable.c: Do not include py-ref.h.
9397         * python/py-objfile.c: Do not include py-ref.h.
9398         * python/py-param.c: Do not include py-ref.h.
9399         * python/py-prettyprint.c: Do not include py-ref.h.
9400         * python/py-progspace.c: Do not include py-ref.h.
9401         * python/py-symbol.c: Do not include py-ref.h.
9402         * python/py-symtab.c: Do not include py-ref.h.
9403         * python/py-type.c: Do not include py-ref.h.
9404         * python/py-unwind.c: Do not include py-ref.h.
9405         * python/py-utils.c: Do not include py-ref.h.
9406         * python/py-value.c: Do not include py-ref.h.
9407         * python/py-varobj.c: Do not include py-ref.h.
9408         * python/py-xmethods.c: Do not include py-ref.h.
9409         * python/python.c: Do not include py-ref.h.
9410         * varobj.c: Do not include py-ref.h.
9411
9412 2019-01-22  Tom Tromey  <tom@tromey.com>
9413
9414         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9415         keyword for bcache.
9416
9417 2019-01-22  Tom Tromey  <tom@tromey.com>
9418
9419         * compile/compile-cplus-types.c: Remove a comment by #include.
9420
9421 2019-01-22  Tom Tromey  <tom@tromey.com>
9422
9423         * compile/gcc-c-plugin.h: Include compile-internal.h.
9424
9425 2019-01-22  Tom Tromey  <tom@tromey.com>
9426
9427         * stabsread.c (EXTERN): Do not define.
9428         (symnum, next_symbol_text_func, processing_gcc_compilation)
9429         (within_function, global_sym_chain, global_stabs)
9430         (previous_stab_code, this_object_header_files)
9431         (n_this_object_header_files)
9432         (n_allocated_this_object_header_files): Define.
9433         * stabsread.h (EXTERN): Never define.  Use "extern".
9434
9435 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9436
9437         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9438         history_value.
9439
9440 2019-01-21  Tom Tromey  <tom@tromey.com>
9441
9442         * ui-out.c: Fix includes.
9443         * tui/tui-source.c: Fix includes.
9444         * target.c: Fix includes.
9445         * remote.c: Fix includes.
9446         * regcache.c: Fix includes.
9447         * python/py-block.c: Fix includes.
9448         * printcmd.c: Fix includes.
9449         * or1k-tdep.c: Fix includes.
9450         * mi/mi-main.c: Fix includes.
9451         * m32r-tdep.c: Fix includes.
9452         * csky-tdep.c: Fix includes.
9453         * compile/compile-cplus-types.c: Fix includes.
9454         * cli/cli-interp.c: Fix includes.
9455
9456 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9457
9458         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9459         for padding.
9460
9461 2019-01-16  Tom Tromey  <tom@tromey.com>
9462
9463         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9464         earlier.
9465         (struct objfile) <msymbols_range>: Move from top level.
9466         <msymbols>: New method.
9467         (class objfile_msymbols): Remove.
9468         * symtab.c (default_collect_symbol_completion_matches_break_on):
9469         Update.
9470         * symmisc.c (dump_msymbols): Update.
9471         * stabsread.c (scan_file_globals): Update.
9472         * objc-lang.c (info_selectors_command, info_classes_command)
9473         (find_methods): Update.
9474         * minsyms.c (find_solib_trampoline_target): Update.
9475         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9476         * coffread.c (coff_symfile_read): Update.
9477         * ada-lang.c (ada_lookup_simple_minsym)
9478         (ada_collect_symbol_completion_matches): Update.
9479
9480 2019-01-16  Tom Tromey  <tom@tromey.com>
9481
9482         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9483         type.  Remove no-argument constructor.
9484         <iterator::operator++>: Simplify.
9485         <begin>: Update.
9486         <end>: Use minimal_symbol_count.
9487
9488 2019-01-16  Tom Tromey  <tom@tromey.com>
9489
9490         * objfiles.h (struct objfile) <psymtabs>: New method.
9491         (class objfile_psymtabs): Remove.
9492         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9493         typedef.
9494         <range>: New method.
9495         (require_partial_symbols): Change return type.
9496         * psymtab.c (require_partial_symbols)
9497         (psym_expand_symtabs_matching): Update.
9498         * mdebugread.c (parse_partial_symbols): Update.
9499         * dbxread.c (dbx_end_psymtab): Update.
9500
9501 2019-01-15  Tom Tromey  <tom@tromey.com>
9502
9503         * symtab.c (lookup_objfile_from_block)
9504         (lookup_symbol_in_objfile_symtabs)
9505         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9506         (find_line_symtab, info_sources_command)
9507         (default_collect_symbol_completion_matches_break_on)
9508         (make_source_files_completion_list): Update.
9509         * symmisc.c (print_objfile_statistics, dump_objfile)
9510         (maintenance_print_symbols, maintenance_info_symtabs)
9511         (maintenance_check_symtabs, maintenance_info_line_tables):
9512         Update.
9513         * source.c (select_source_symtab)
9514         (forget_cached_source_info_for_objfile): Update.
9515         * objfiles.h (class objfile_compunits): Remove.
9516         (struct objfile) <compunits_range>: New typedef.
9517         (compunits): New method.
9518         * objfiles.c (objfile_relocate1): Update.
9519         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9520         * maint.c (count_symtabs_and_blocks): Update.
9521         * linespec.c (iterate_over_all_matching_symtabs): Update.
9522         * cp-support.c (add_symbol_overload_list_qualified): Update.
9523         * coffread.c (coff_symtab_read): Update.
9524         * ada-lang.c (add_nonlocal_symbols)
9525         (ada_collect_symbol_completion_matches)
9526         (ada_add_global_exceptions): Update.
9527
9528 2019-01-15  Tom Tromey  <tom@tromey.com>
9529
9530         * progspace.h (program_space) <objfiles_safe_range>: New
9531         typedef.
9532         <objfiles_safe>: New method.
9533         * objfiles.h (class all_objfiles_safe): Remove.
9534         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9535         * jit.c (jit_inferior_exit_hook): Update.
9536
9537 2019-01-17  Tom Tromey  <tom@tromey.com>
9538
9539         * progspace.h (program_space) <objfiles_range>: New typedef.
9540         <objfiles>: New method.
9541         <objfiles_head>: Rename from objfiles.
9542         (object_files): Update.
9543         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9544         * guile/scm-pretty-print.c
9545         (ppscm_find_pretty_printer_from_objfiles): Update.
9546         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9547         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9548         Update.
9549         * python/py-progspace.c (pspy_get_objfiles): Update.
9550         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9551         Update.
9552         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9553         (objfpy_lookup_objfile_by_build_id): Update.
9554         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9555         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9556         Update.
9557         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9558         (expand_symtab_containing_pc, lookup_objfile_from_block)
9559         (lookup_static_symbol, basic_lookup_transparent_type)
9560         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9561         (find_line_symtab, info_sources_command)
9562         (default_collect_symbol_completion_matches_break_on)
9563         (make_source_files_completion_list, find_main_name): Update.
9564         * symmisc.c (print_symbol_bcache_statistics)
9565         (print_objfile_statistics, maintenance_print_symbols)
9566         (maintenance_print_msymbols, maintenance_print_objfiles)
9567         (maintenance_info_symtabs, maintenance_check_symtabs)
9568         (maintenance_expand_symtabs, maintenance_info_line_tables):
9569         Update.
9570         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9571         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9572         (map_overlay_command, unmap_overlay_command)
9573         (simple_overlay_update, expand_symtabs_matching)
9574         (map_symbol_filenames): Update.
9575         * symfile-debug.c (set_debug_symfile): Update.
9576         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9577         Update.
9578         * source.c (select_source_symtab, forget_cached_source_info):
9579         Update.
9580         * solib.c (solib_read_symbols): Update.
9581         * solib-spu.c (append_ocl_sos): Update.
9582         * psymtab.c (maintenance_print_psymbols)
9583         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9584         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9585         * printcmd.c (info_symbol_command): Update.
9586         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9587         Update.
9588         * objfiles.h (class all_objfiles): Remove.
9589         * objfiles.c (have_partial_symbols, have_full_symbols)
9590         (have_minimal_symbols, qsort_cmp, update_section_map)
9591         (shared_objfile_contains_address_p)
9592         (default_iterate_over_objfiles_in_search_order): Update.
9593         * objc-lang.c (info_selectors_command, info_classes_command)
9594         (find_methods): Update.
9595         * minsyms.c (find_solib_trampoline_target): Update.
9596         * maint.c (maintenance_info_sections)
9597         (maintenance_translate_address, count_symtabs_and_blocks):
9598         Update.
9599         * main.c (captured_main_1): Update.
9600         * linux-thread-db.c (try_thread_db_load_from_pdir)
9601         (has_libpthread): Update.
9602         * linespec.c (iterate_over_all_matching_symtabs)
9603         (search_minsyms_for_name): Update.
9604         * jit.c (jit_find_objf_with_entry_addr): Update.
9605         * hppa-tdep.c (find_unwind_entry)
9606         (hppa_lookup_stub_minimal_symbol): Update.
9607         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9608         Update.
9609         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9610         (elf_gnu_ifunc_resolve_by_got): Update.
9611         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9612         * dwarf-index-write.c (save_gdb_index_command): Update.
9613         * cp-support.c (add_symbol_overload_list_qualified): Update.
9614         * breakpoint.c (create_overlay_event_breakpoint)
9615         (create_longjmp_master_breakpoint)
9616         (create_std_terminate_master_breakpoint)
9617         (create_exception_master_breakpoint): Update.
9618         * blockframe.c (find_pc_partial_function): Update.
9619         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9620         (ada_collect_symbol_completion_matches)
9621         (ada_add_global_exceptions): Update.
9622
9623 2019-01-17  Tom Tromey  <tom@tromey.com>
9624
9625         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9626         declare VEC.
9627         (solib_target_parse_libraries): Change return type.
9628         (library_list_start_segment, library_list_start_section)
9629         (library_list_end_library, library_list_start_library); Update.
9630         (solib_target_free_library_list): Remove.
9631         (solib_target_parse_libraries): Remove cleanup.  Change return
9632         type.
9633         (solib_target_current_sos): Update.
9634
9635 2019-01-17  Tom Tromey  <tromey@bapiya>
9636
9637         * valprint.c: Replace "the the" with "the".
9638         * symtab.c: Replace "the the" with "the".
9639         * solib.c: Replace "the the" with "the".
9640         * solib-dsbt.c: Replace "the the" with "the".
9641         * linespec.c: Replace "the the" with "the".
9642         * dwarf2loc.h: Replace "the the" with "the".
9643         * amd64-windows-tdep.c: Replace "the the" with "the".
9644         * aarch64-tdep.c: Replace "the the" with "the".
9645
9646 2019-01-16  Keith Seitz  <keiths@redhat.com>
9647
9648         PR gdb/23773
9649         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9650         <builder>: Rename to ..
9651         <m_builder>: ... this and make private.
9652         (dwarf2_cu::get_builder): New method.  Change all users of
9653         `builder' to use this method.
9654         (dwarf2_start_symtab): Move to ...
9655         (dwarf2_cu::start_symtab): ... here.  Update all callers
9656         (setup_type_unit_groups): Move to ...
9657         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9658         callers.
9659         (dwarf2_cu::reset_builder): New method.
9660         (process_full_compunit, process_full_type_unit): Use
9661         dwarf2_cu::reset_builder.
9662         (follow_die_offset): Record the ancestor CU if it is different
9663         from the followed DIE's CU.
9664         (follow_die_sig_1): Likewise.
9665
9666 2019-01-15  Tom Tromey  <tom@tromey.com>
9667
9668         * remote.c (class remote_state) <buf>: Now a char_vector.
9669         <buf_size>: Remove.
9670         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9671         parameter.
9672         (remote_target::getpkt_or_notif_sane_1)
9673         (remote_target::getpkt_sane)
9674         (remote_target::getpkt_or_notif_sane): Likewise.
9675         (class remote_target) <putpkt>: New overload.
9676         (remote_target::read_frame): Change type of "buf_p".  Remove
9677         sizeof_p parameter.
9678         (packet_ok): New overload.
9679         (packet_check_result): New overload.
9680         Update all uses.
9681
9682 2019-01-14  Tom Tromey  <tom@tromey.com>
9683
9684         * remote-notif.c (handle_notification, remote_notif_ack)
9685         (remote_notif_parse): Make "buf" const.
9686         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9687         const.
9688         (remote_notif_parse, remote_notif_ack, handle_notification):
9689         Likewise.
9690         * remote.c (remote_notif_stop_parse): Make "buf" const.
9691         (remote_target::remote_parse_stop_reply): Make "buf" const.
9692         (remote_notif_stop_ack): Make "buf" const.
9693
9694 2019-01-14  Tom Tromey  <tom@tromey.com>
9695
9696         * remote.c (remote_console_output): Make parameter const.
9697
9698 2019-01-14  Tom Tromey  <tom@tromey.com>
9699
9700         * target-debug.h (target_debug_print_signals): Constify.
9701         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9702         * procfs.c (procfs_target::pass_signals): Update.
9703         * linux-nat.c (linux_nat_target::pass_signals): Update.
9704         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9705         * target-delegates.c: Rebuild.
9706         * remote.c (remote_target::program_signals): Update.
9707         (remote_target::pass_signals): Update.
9708         * target.c (target_pass_signals): Constify argument.
9709         (target_program_signals): Likewise.
9710         * target.h (struct target_ops) <pass_signals, program_signals>:
9711         Constify argument.
9712         (target_pass_signals, target_program_signals): Constify argument.
9713
9714 2019-01-14  Tom Tromey  <tom@tromey.com>
9715
9716         PR tui/28819:
9717         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9718
9719 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9720
9721         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9722         field.
9723         * rs6000-tdep.c: Include reggroups.h.
9724         (IS_V_ALIAS_PSEUDOREG): Define.
9725         (rs6000_register_name): Return names for the "vX" aliases.
9726         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9727         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9728         aliases.  Call default_register_reggroup_p for all other
9729         pseudo-registers.
9730         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9731         New functions.
9732         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9733         Handle "vX" aliases.
9734         (v_alias_pseudo_register_collect): New function.
9735         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9736         (rs6000_gdbarch_init): Initialize "vX" aliases as
9737         pseudo-registers.  Restore registration of
9738         rs6000_pseudo_register_reggroup_p with
9739         set_tdesc_pseudo_register_reggroup_p.
9740
9741 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9742
9743         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9744         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9745         set_gdbarch_num_pseudo_regs.
9746
9747 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9748
9749         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9750         Remove arg prefixname, add do_set and do_show.
9751         Add member functions set_list and show_list.
9752         * cli/cli-style.c (class cli_style_option): Update accordingly.
9753         (style_set_list): Move to file scope.
9754         (style_show_list): Likewise.
9755         (set_style): Call help_list.
9756         (show_style): Call cmd_show_list.
9757         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9758         Update to use the new macro.
9759
9760 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9761
9762         * ada-lang.c (_initialize_ada_language): Expand the help text
9763         for the "catch exception" command.
9764
9765 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9766
9767         * symtab.c (matching_obj_sections): Initialize obj,
9768         declare it closer to its usage.
9769
9770 2019-01-10  Tom Tromey  <tom@tromey.com>
9771
9772         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9773         (basic_inf_threads_range): Remove.
9774         (inf_threads_range, inf_non_exited_threads_range)
9775         (safe_inf_threads_range): Use next_adapter.
9776
9777 2019-01-10  Keith Seitz  <keiths@redhat.com>
9778
9779         PR gdb/23712
9780         PR symtab/23010
9781         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9782         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9783
9784 2019-01-10  Keith Seitz  <keiths@redhat.com>
9785
9786         PR gdb/23712
9787         PR symtab/23010
9788         * dictionary.c (pending_to_vector): Remove.
9789         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9790         Remove _1 suffix, replacing functions of the same name.  Update
9791         all callers.
9792         (dict_create_hashed, dict_create_hashed_expandable)
9793         (dict_create_linear, dict_create_linear_expandable, dict_free)
9794         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9795         Make functions static.
9796
9797 2019-01-10  Keith Seitz  <keiths@redhat.com>
9798
9799         PR gdb/23712
9800         PR symtab/23010
9801         * dictionary.h (struct dictionary): Replace declaration with
9802         multidictionary.
9803         (dict_create_hashed, dict_create_hashed_expandable)
9804         (dict_create_linear, dict_create_linear_expandable)
9805         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9806         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9807         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9808         taking multidictionary argument.
9809         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9810         * block.h (struct block) <dict>: Change to multidictionary
9811         and rename `multidict'.
9812         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9813         symmisc.c: Update all dictionary references to multidictionary.
9814
9815 2019-01-10  Keith Seitz  <keiths@redhat.com>
9816
9817         PR gdb/23712
9818         PR symtab/23010
9819         * dictionary.c: Include unordered_map.
9820         (pending_to_vector): New function.
9821         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9822         Rewrite the non-"_1" functions to take vector instead
9823         of linked list.
9824         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9825         "new" _1 versions of the same name.
9826         (multidictionary): Define.
9827         (std::hash<enum language): New definition.
9828         (collate_pending_symbols_by_language, mdict_create_hashed)
9829         (mdict_create_hashed_expandable, mdict_create_linear)
9830         (mdict_create_linear_expandable, mdict_free)
9831         (find_language_dictionary, create_new_language_dictionary)
9832         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9833         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9834         (mdict_size, mdict_empty): New functions.
9835         * dictionary.h (mdict_iterator): Define.
9836
9837 2019-01-10  Pedro Alves  <palves@redhat.com>
9838
9839         * breakpoint.c (read_uploaded_action)
9840         (create_tracepoint_from_upload): Adjust to use
9841         gdb::unique_xmalloc_ptr.
9842         * ctf.c (ctf_write_uploaded_tp):
9843         (SET_ARRAY_FIELD): Use emplace_back.
9844         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9845         * tracefile-tfile.c (tfile_write_uploaded_tp):
9846         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9847         gdb::unique_xmalloc_ptr.
9848         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9849         at_string, cond_string, cmd_strings>: Replace char pointers
9850         with gdb::unique_xmalloc_ptr.
9851
9852 2019-01-10  Pedro Alves  <palves@redhat.com>
9853
9854         * solib-target.c (library_list_start_library): Don't xstrdup name.
9855
9856 2019-01-10  Pedro Alves  <palves@redhat.com>
9857
9858         * mdebugread.c (parse_partial_symbols): Use
9859         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9860
9861 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9862
9863         * linux-fork.c (scoped_switch_fork_info)
9864         <~scoped_switch_fork_info>: Fix incorrect variable name.
9865
9866 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9867
9868         * linux-fork.c (scoped_switch_fork_info)
9869         <scoped_switch_fork_info>: Make explicit.
9870         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9871
9872 2019-01-10  Tom Tromey  <tom@tromey.com>
9873
9874         * objfiles.h (objfile::reset_psymtabs): Update.
9875         * objfiles.c (objfile::objfile): Update.
9876         * psymtab.h (psymtab_storage::obstack): Update.
9877         (psymtab_storage::m_obstack): Use gdb::optional.
9878         (class psymtab_storage): Update comment.  Remove objfile
9879         parameter.
9880         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9881
9882 2019-01-10  Tom Tromey  <tom@tromey.com>
9883
9884         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9885         <free_psymtabs>: Now private.
9886         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9887         (allocate_psymtab): Use new method.
9888
9889 2019-01-10  Tom Tromey  <tom@tromey.com>
9890
9891         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9892         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9893         * mdebugread.c (parse_partial_symbols): Use
9894         allocate_dependencies.
9895         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9896         allocate_dependencies.
9897         (process_psymtab_comp_unit_reader)
9898         (build_type_psymtab_dependencies): Likewise.
9899         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9900
9901 2019-01-10  Tom Tromey  <tom@tromey.com>
9902
9903         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9904         PSYMBOL_SET_LANGUAGE.
9905         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9906
9907 2019-01-10  Tom Tromey  <tom@tromey.com>
9908
9909         * psymtab.h (psymtab_storage::obstack): New method.
9910         <m_obstack>: Rename from obstack; now private.
9911         * psymtab.c (psymtab_storage): Update.
9912         * dwarf2read.c (create_addrmap_from_index)
9913         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9914         Update.
9915
9916 2019-01-10  Tom Tromey  <tom@tromey.com>
9917
9918         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9919         * objfiles.h (objfile::reset_psymtabs): New method.
9920
9921 2019-01-10  Tom Tromey  <tom@tromey.com>
9922
9923         * symmisc.c (print_symbol_bcache_statistics): Update.
9924         (print_objfile_statistics): Update.
9925         * symfile.c (reread_symbols): Update.
9926         * psymtab.h (class psymtab_storage): New.
9927         * psymtab.c (psymtab_storage): New constructor.
9928         (~psymtab_storage): New destructor.
9929         (require_partial_symbols): Update.
9930         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9931         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9932         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9933         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9934         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9935         (start_psymtab_common, end_psymtab_common)
9936         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9937         (allocate_psymtab): Update.
9938         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9939         Update.
9940         (dump_psymtab_addrmap, maintenance_print_psymbols)
9941         (maintenance_check_psymtabs): Update.
9942         (class objfile_psymtabs): Move to objfiles.h.
9943         * psympriv.h (discard_psymtab): Now inline.
9944         (psymtab_discarder::psymtab_discarder): Update.
9945         (psymtab_discarder::~psymtab_discarder): Update.
9946         (ALL_OBJFILE_PSYMTABS): Rewrite.
9947         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9948         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9949         Remove fields.
9950         <partial_symtabs>: New field.
9951         (class objfile_psymtabs): Move from psymtab.h.  Update.
9952         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9953         psymbol_cache.
9954         (objfile::~objfile): Don't destroy psymbol_cache.
9955         * mdebugread.c (parse_partial_symbols): Update.
9956         * dwarf2read.c (create_addrmap_from_index)
9957         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9958         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9959         (add_partial_subprogram, dwarf2_ranges_read): Update.
9960         * dwarf-index-write.c (write_address_map)
9961         (write_one_signatured_type, recursively_write_psymbols)
9962         (class debug_names, class debug_names, write_psymtabs_to_index):
9963         Update.
9964
9965 2019-01-10  Tom Tromey  <tom@tromey.com>
9966
9967         * symtab.h (SYMBOL_SET_NAMES): Update.
9968         (symbol_set_names): Update.
9969         (MSYMBOL_SET_NAMES): Update.
9970         * symtab.c (symbol_set_names): Change argument to be an
9971         objfile_per_bfd_storage.
9972         * psymtab.c (add_psymbol_to_bcache): Update.
9973         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9974
9975 2019-01-10  Tom Tromey  <tom@tromey.com>
9976
9977         * symtab.c (create_demangled_names_hash): Change argument to be an
9978         objfile_per_bfd_storage.
9979         (symbol_set_names): Update.
9980
9981 2019-01-10  Tom Tromey  <tom@tromey.com>
9982
9983         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9984         init_psymbol_list.
9985         * psymtab.c (init_psymbol_list): Do nothing if already called.
9986         * psympriv.h (init_psymbol_list): Add comment.
9987         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9988         init_psymbol_list.
9989         * dbxread.c (dbx_symfile_read): Unconditionally call
9990         init_psymbol_list.
9991
9992 2019-01-10  Tom Tromey  <tom@tromey.com>
9993
9994         * xcoffread.c (scan_xcoff_symtab): Update.
9995         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9996         "where".
9997         * mdebugread.c (parse_partial_symbols)
9998         (handle_psymbol_enumerators): Update.
9999         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10000         * dbxread.c (read_dbx_symtab): Update.
10001         * psympriv.h (psymbol_placement): New enum.
10002         (add_psymbol_to_list): Update.
10003
10004 2019-01-10  Tom Tromey  <tom@tromey.com>
10005
10006         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10007         static_psymbols parameters.
10008         (scan_xcoff_symtab): Update.
10009         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10010         static_psymbols parameters.
10011         * psympriv.h (start_psymtab_common): Update.
10012         * mdebugread.c (parse_partial_symbols): Update.
10013         * dwarf2read.c (create_partial_symtab): Update.
10014         * dbxread.c (read_dbx_symtab): Update.
10015         (start_psymtab): Remove global_psymbols and static_psymbols
10016         parameters.
10017
10018 2019-01-10  Tom Tromey  <tom@tromey.com>
10019
10020         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10021         * psymtab.c (allocate_psymtab): Add comment.
10022         * psympriv.h (allocate_psymtab): Add comment.
10023         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10024         initializations.
10025         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10026
10027 2019-01-10  Tom Tromey  <tom@tromey.com>
10028
10029         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10030         Don't declare.
10031         * mipsread.c: Include mdebugread.h.
10032         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10033         Declare.
10034         * elfread.c: Include mdebugread.h.
10035
10036 2019-01-09  Tom Tromey  <tom@tromey.com>
10037
10038         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10039         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10040         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10041         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10042         (psym_lookup_symbol, psym_find_last_source_symtab)
10043         (psym_forget_cached_source_info, psym_print_stats)
10044         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10045         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10046         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10047         (psym_find_compunit_symtab_by_address)
10048         (maintenance_print_psymbols, maintenance_info_psymtabs)
10049         (maintenance_check_psymtabs): Use ranged for.
10050         * psymtab.h (class objfile_psymtabs): New.
10051         (require_partial_symbols): Return objfile_psymtabs.
10052         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10053
10054 2019-01-09  Tom Tromey  <tom@tromey.com>
10055
10056         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10057         (find_pc_mapped_section, list_overlays_command)
10058         (map_overlay_command, unmap_overlay_command)
10059         (simple_overlay_update): Use all_objfiles.
10060         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10061         * printcmd.c (info_symbol_command): Use all_objfiles.
10062         * objfiles.h (ALL_OBJSECTIONS): Remove.
10063         * maint.c (maintenance_translate_address): Use all_objfiles.
10064         * gcore.c (gcore_create_callback): Use all_objfiles.
10065         (objfile_find_memory_regions): Likewise.
10066
10067 2019-01-09  Tom Tromey  <tom@tromey.com>
10068
10069         * symtab.c (find_line_symtab, info_sources_command)
10070         (make_source_files_completion_list): Use objfile_compunits.
10071         * source.c (select_source_symtab): Use objfile_compunits.
10072         * objfiles.h (struct objfile): Update comment.
10073         (ALL_OBJFILES): Remove.
10074         (ALL_FILETABS): Remove.
10075         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10076         objfile_compunits.
10077
10078 2019-01-09  Tom Tromey  <tom@tromey.com>
10079
10080         * symmisc.c (print_objfile_statistics, dump_objfile)
10081         (maintenance_print_symbols): Use compunit_filetabs.
10082         * source.c (forget_cached_source_info_for_objfile): Use
10083         compunit_filetabs.
10084         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10085         (ALL_FILETABS): Use compunit_filetabs.
10086         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10087         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10088
10089 2019-01-09  Tom Tromey  <tom@tromey.com>
10090
10091         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10092         (compunit_filetabs): New.
10093         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10094         compunit_filetabs.
10095         (info_sources_command, make_source_files_completion_list): Remove
10096         declaration.
10097         * symmisc.c (print_objfile_statistics, dump_objfile)
10098         (maintenance_print_symbols): Remove declaration.
10099         (maintenance_info_symtabs): Use compunit_filetabs.
10100         (maintenance_info_line_tables): Likewise.
10101         * source.c (select_source_symtab): Change local variable name.
10102         (forget_cached_source_info_for_objfile): Remove declaration.
10103         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10104         * objfiles.c (objfile_relocate1): Remove declaration.
10105         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10106         declaration.
10107         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10108         * coffread.c (coff_symtab_read): Remove declaration.
10109         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10110         compunit_filetabs.
10111
10112 2019-01-09  Tom Tromey  <tom@tromey.com>
10113
10114         * symtab.c (lookup_objfile_from_block)
10115         (find_pc_sect_compunit_symtab, search_symbols)
10116         (default_collect_symbol_completion_matches_break_on): Use
10117         objfile_compunits.
10118         * objfiles.h (ALL_COMPUNITS): Remove.
10119         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10120         * cp-support.c (add_symbol_overload_list_qualified): Use
10121         objfile_compunits.
10122         * ada-lang.c (ada_collect_symbol_completion_matches)
10123         (ada_add_global_exceptions): Use objfile_compunits.
10124
10125 2019-01-09  Tom Tromey  <tom@tromey.com>
10126
10127         * source.c (select_source_symtab)
10128         (forget_cached_source_info_for_objfile): Remove declaration.
10129         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10130         declaration.
10131         * maint.c (count_symtabs_and_blocks): Remove declaration.
10132         * cp-support.c (add_symbol_overload_list_qualified): Remove
10133         declaration.
10134         * coffread.c (coff_symtab_read): Remove declaration.
10135         * symtab.c (lookup_symbol_in_objfile_symtabs)
10136         (basic_lookup_transparent_type_1): Use objfile_compunits.
10137         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10138         (info_sources_command, search_symbols)
10139         (default_collect_symbol_completion_matches_break_on)
10140         (make_source_files_completion_list): Remove declaration.
10141         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10142         (ada_collect_symbol_completion_matches)
10143         (ada_add_global_exceptions): Remove declaration.
10144         * linespec.c (iterate_over_all_matching_symtabs): Use
10145         objfile_compunits.
10146         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10147         (class objfile_compunits): New.
10148         (ALL_COMPUNITS): Use objfile_compunits.
10149         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10150         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10151         objfile_compunits.
10152         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10153
10154 2019-01-09  Tom Tromey  <tom@tromey.com>
10155
10156         * symtab.c (search_symbols)
10157         (default_collect_symbol_completion_matches_break_on): Use
10158         objfile_msymbols.
10159         * ada-lang.c (ada_lookup_simple_minsym)
10160         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10161         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10162         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10163         objfile_msymbols.
10164         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10165         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10166         * objc-lang.c (find_methods): Use objfile_msymbols.
10167         (info_selectors_command, info_classes_command): Likewise.
10168         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10169         * objfiles.h (class objfile_msymbols): New.
10170         (ALL_OBJFILE_MSYMBOLS): Remove.
10171         (ALL_MSYMBOLS): Remove.
10172
10173 2019-01-09  Tom Tromey  <tom@tromey.com>
10174
10175         * common/next-iterator.h (next_adapter): Add Iterator template
10176         parameter.
10177         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10178         (class all_objfiles_safe): New.
10179         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10180         * objfiles.c (put_objfile_before): Update comment.
10181         (add_separate_debug_objfile): Likewise.
10182         (free_all_objfiles): Use all_objfiles_safe.
10183         (objfile_purge_solibs): Likewise.
10184
10185 2019-01-09  Tom Tromey  <tom@tromey.com>
10186
10187         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10188         (expand_symtab_containing_pc, lookup_static_symbol)
10189         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10190         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10191         all_objfiles.
10192         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10193         * breakpoint.c (create_overlay_event_breakpoint)
10194         (create_longjmp_master_breakpoint)
10195         (create_std_terminate_master_breakpoint)
10196         (create_exception_master_breakpoint): Use all_objfiles.
10197         * linux-thread-db.c (try_thread_db_load_from_pdir)
10198         (has_libpthread): Use all_objfiles.
10199         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10200         * linespec.c (iterate_over_all_matching_symtabs)
10201         (search_minsyms_for_name): Use all_objfiles.
10202         * maint.c (maintenance_info_sections): Use all_objfiles.
10203         * main.c (captured_main_1): Use all_objfiles.
10204         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10205         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10206         * guile/scm-pretty-print.c
10207         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10208         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10209         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10210         (maintenance_print_msymbols): Use all_objfiles.
10211         * source.c (select_source_symtab): Use all_objfiles.
10212         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10213         * symfile.c (remove_symbol_file_command)
10214         (expand_symtabs_matching, map_symbol_filenames): Use
10215         all_objfiles.
10216         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10217         all_objfiles.
10218         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10219         * objc-lang.c (find_methods): Use all_objfiles.
10220         * objfiles.c (have_partial_symbols, have_full_symbols)
10221         (have_minimal_symbols, qsort_cmp)
10222         (default_iterate_over_objfiles_in_search_order): Use
10223         all_objfiles.
10224         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10225         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10226         (maintenance_check_psymtabs): Use all_objfiles.
10227         (ALL_PSYMTABS): Remove.
10228         * compile/compile-object-run.c (do_module_cleanup): Use
10229         all_objfiles.
10230         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10231         * cp-support.c (add_symbol_overload_list_qualified): Use
10232         all_objfiles.
10233         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10234         Use all_objfiles.
10235         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10236         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10237         all_objfiles.
10238         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10239         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10240         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10241         Uses all_objfiles.
10242         * solib.c (solib_read_symbols): Use all_objfiles
10243
10244 2019-01-09  Tom Tromey  <tom@tromey.com>
10245
10246         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10247         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10248         all_objfiles.
10249         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10250         * symmisc.c (print_symbol_bcache_statistics)
10251         (print_objfile_statistics, maintenance_print_objfiles)
10252         (maintenance_info_symtabs, maintenance_check_symtabs)
10253         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10254         all_objfiles.
10255         * source.c (forget_cached_source_info): Use all_objfiles.
10256         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10257         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10258         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10259         * objfiles.c (update_section_map): Use all_objfiles.
10260         (shared_objfile_contains_address_p): Likewise.
10261         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10262         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10263
10264 2019-01-09  Tom Tromey  <tom@tromey.com>
10265
10266         * common/next-iterator.h: New file.
10267         * objfiles.h (class all_objfiles): New.
10268         (struct objfile_iterator): New.
10269
10270 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10271
10272         * NEWS: Move the description of the changed "frame", "select-frame",
10273          and "info frame" commands to the Changed commands section.
10274
10275 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10276
10277         * gdbtypes.c (check_stub_method_group): Remove handling of old
10278         mangling schemes.
10279         * linespec.c (find_methods): Likewise.
10280         * stabsread.c (read_member_functions): Likewise.
10281         * valops.c (search_struct_method): Likewise.
10282         (value_struct_elt_for_reference): Likewise.
10283         * NEWS: Mention this change.
10284
10285 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10286
10287         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10288         print_source_lines.
10289         * source.c (print_source_lines_base): Update line number check.
10290         (print_source_lines): New function.
10291         (source_lines_range::source_lines_range): New function.
10292         * source.h (class source_lines_range): New class.
10293         (print_source_lines): New declaration.
10294
10295 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10296
10297         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10298
10299 2019-01-08  Tom Tromey  <tom@tromey.com>
10300             Simon Marchi  <simon.marchi@ericsson.com>
10301
10302         PR gdb/24060
10303         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10304         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10305         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10306         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10307         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10308         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10309
10310 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10311
10312         * source.c (select_source_symtab): Move header comment to
10313         declaration in source.h.
10314         (forget_cached_source_info_for_objfile): Likewise.
10315         (forget_cached_source_info): Likewise.
10316         (identify_source_line): Likewise.
10317         * source.h (identify_source_line): Move declaration from symtab.h
10318         and add comment from source.c
10319         (print_source_lines): Likewise.
10320         (forget_cached_source_info_for_objfile): Likewise.
10321         (forget_cached_source_info): Likewise.
10322         (select_source_symtab): Likewise.
10323         (enum print_source_lines_flag): Move definition from symtab.h.
10324         * symtab.h (identify_source_line): Move declaration to source.h.
10325         (print_source_lines): Likewise.
10326         (forget_cached_source_info_for_objfile): Likewise.
10327         (forget_cached_source_info): Likewise.
10328         (select_source_symtab): Likewise.
10329         (enum print_source_lines_flag): Move definition to source.h.
10330         * tui/tui-hooks.c: Add 'source.h' include.
10331
10332 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10333
10334         * source.c (print_source_lines_base): Handle requests to print
10335         reverse line number sequences, and guard against empty lines
10336         string.
10337
10338 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10339
10340         * source.c (print_source_lines_base): Fix skip of '\r' if next
10341         character is '\n'.
10342
10343 2019-01-06  Tom Tromey  <tom@tromey.com>
10344
10345         * c-exp.y (struct c_parse_state) <macro_original_text,
10346         expansion_obstack>: New member.
10347         (macro_original_text, expansion_obstack): Remove globals.
10348         (scan_macro_expansion, scanning_macro_expansion)
10349         (finished_macro_expansion): Update.
10350         (scan_macro_cleanup): Remove.
10351         (yylex, c_parse): Update.
10352
10353 2019-01-06  Tom Tromey  <tom@tromey.com>
10354
10355         * c-exp.y (struct c_parse_state) <strings>: New member.
10356         (operator_stoken): Update.
10357
10358 2019-01-06  Tom Tromey  <tom@tromey.com>
10359
10360         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10361         (union type_stack_elt) <typelist_val>: Now a pointer to
10362         std::vector.
10363         (type_stack_cleanup): Don't declare.
10364         (push_typelist): Update.
10365         * parse.c (pop_typelist): Return a std::vector.
10366         (push_typelist): Take a std::vector.
10367         (follow_types): Update.  Do not free args.
10368         (type_stack_cleanup): Remove.
10369         * c-exp.y (struct c_parse_state): New.
10370         (cpstate): New global.
10371         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10372         (nonempty_typelist): Update.
10373         (func_mod): Create a new vector.
10374         (c_parse): Create a c_parse_state.
10375         (check_parameter_typelist): Do not delete params.
10376         (function_method): Update.  Do not delete type_list.
10377
10378 2019-01-06  Tom Tromey  <tom@tromey.com>
10379
10380         PR gdb/28155:
10381         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10382         check_typedef.
10383         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10384         (print_return_value): Likewise.
10385
10386 2019-01-05  Tom Tromey  <tom@tromey.com>
10387
10388         * contrib/cleanup_check.py: Remove.
10389         * contrib/gcc-with-excheck: Remove.
10390         * contrib/exsummary.py: Remove.
10391         * contrib/excheck.py: Remove.
10392
10393 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10394
10395         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10396         NULL. Initialize tpprev to NULL instead of assigning it
10397         to NULL on the next statement.
10398         * windows-nat.c (windows_delete_thread): Remove check for
10399         main_thread_id before printing thread exit notifications.
10400         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10401         Remove thread ID check against main_thread_id.
10402         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10403         windows_delete_thread.
10404         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10405
10406 2019-01-04  Tom Tromey  <tom@tromey.com>
10407
10408         * compile/compile.c (_initialize_compile): Use upper case for
10409         metasyntactic variables.
10410         * symmisc.c (_initialize_symmisc): Use upper case for
10411         metasyntactic variables.
10412         * psymtab.c (_initialize_psymtab): Use upper case for
10413         metasyntactic variables.
10414         * demangle.c (demangle_command): Use upper case for metasyntactic
10415         variables.
10416         (_initialize_demangler): Likewise.
10417         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10418         variables.
10419
10420 2019-01-03  Tom Tromey  <tom@tromey.com>
10421
10422         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10423
10424 2019-01-03  Tom Tromey  <tom@tromey.com>
10425
10426         * python/py-symtab.c (salpy_str): Update.
10427         (struct salpy_sal_object) <symtab>: Now a PyObject.
10428         (salpy_dealloc): Update.
10429         (del_objfile_sal): Use gdbpy_ref.
10430
10431 2019-01-03  Tom Tromey  <tom@tromey.com>
10432
10433         * python/py-type.c (convert_field): Use new_reference.  Return
10434         gdbpy_ref.
10435         (make_fielditem): Return gdbpy_ref.
10436         (typy_fields): Update.
10437         (typy_getitem): Update.
10438         (field_name): Return gdbpy_ref.  Use new_reference.
10439         (typy_iterator_iternext): Update.
10440
10441 2019-01-03  Tom Tromey  <tom@tromey.com>
10442
10443         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10444
10445 2019-01-03  Tom Tromey  <tom@tromey.com>
10446
10447         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10448         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10449         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10450         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10451         (pspy_set_type_printers): Likewise.
10452         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10453         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10454         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10455         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10456         (objfpy_set_type_printers): Likewise.
10457
10458 2019-01-03  Tom Tromey  <tom@tromey.com>
10459
10460         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10461         (gdbpy_print_stack): Use gdbpy_err_fetch.
10462         * python/python-internal.h (class gdbpy_err_fetch): New class.
10463         (class gdbpy_enter) <m_error_type, m_error_value,
10464         m_error_traceback>: Remove.
10465         <m_error>: New member.
10466         (gdbpy_exception_to_string): Don't declare.
10467         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10468         * python/py-value.c (convert_value_from_python): Use
10469         gdbpy_err_fetch.
10470         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10471         gdbpy_exception_to_string.
10472         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10473         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10474         gdbpy_err_fetch.
10475
10476 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10477
10478         * linux-nat.c (delete_lwp_cleanup): Delete.
10479         (struct lwp_deleter): New struct.
10480         (lwp_info_up): New typedef.
10481         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10482         lwp_info_up.
10483
10484 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10485
10486         * linux-fork.c (class scoped_switch_fork_info): New class.
10487         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10488
10489 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10490
10491         * valops.c (find_overload_match): Remove use of null_cleanup, and
10492         calls to do_cleanups.
10493
10494 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10495
10496         * compile/compile-cplus-types.c
10497         (compile_cplus_instance::decl_name): Handle changes to
10498         cp_func_name.
10499         * cp-support.c (cp_func_name): Update header comment, update
10500         return type.
10501         * cp-support.h (cp_func_name): Update return type in declaration.
10502         * valops.c (find_overload_match): Move temp_func local to top
10503         level of function and change its type.  Use temp_func to hold and
10504         delete temporary string obtained from cp_func_name.
10505
10506 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10507
10508         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10509         gdb::char_vector, remove cleanup, and update uses of `msg`.
10510
10511 2019-01-03  Jim Wilson  <jimw@sifive.com>
10512
10513         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10514
10515 2019-01-02  Tom Tromey  <tom@tromey.com>
10516
10517         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10518         (tdesc_parse_xml): Remove cleanups.
10519         * target-descriptions.h (make_cleanup_free_target_description):
10520         Don't declare.
10521         (target_desc_deleter): New struct.
10522         (target_desc_up): New typedef.
10523         * target-descriptions.c (target_desc_deleter::operator()): Rename
10524         from free_target_description.
10525         (make_cleanup_free_target_description): Remove.
10526
10527 2019-01-02  Tom Tromey  <tom@tromey.com>
10528
10529         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10530         constructor, destructor.
10531         (linespec_parser): Remove typedef.
10532         (~linespec_parser): Rename from linespec_parser_delete.
10533         (linespec_lex_to_end, linespec_complete_label)
10534         (linespec_complete): Update.
10535         (decode_line_full): Remove cleanups.
10536         (decode_line_1): Update.
10537
10538 2019-01-02  Tom Tromey  <tom@tromey.com>
10539
10540         * python/python-internal.h (inferior_to_inferior_object): Change
10541         return type.
10542         * python/py-exitedevent.c (create_exited_event_object): Update.
10543         * python/py-inferior.c (inferior_to_inferior_object): Return
10544         gdbpy_ref.
10545         (python_new_inferior, python_inferior_deleted)
10546         (thread_to_thread_object, delete_thread_object)
10547         (build_inferior_list, gdbpy_selected_inferior): Update.
10548         * python/py-infthread.c (create_thread_object): Update.  Also fail
10549         if inferior_to_inferior_object fails.
10550
10551 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10552
10553         * inferior.h (class inferior) <displaced_step_state>: New field.
10554         * infrun.h (struct displaced_step_state): Move here from
10555         infrun.c.  Initialize fields, add constructor.
10556         <inf>: Remove field.
10557         <reset>: New method.
10558         * infrun.c (struct displaced_step_inferior_state): Move to
10559         infrun.h.
10560         (displaced_step_inferior_states): Remove.
10561         (get_displaced_stepping_state): Adust.
10562         (displaced_step_in_progress_any_inferior): Adjust.
10563         (displaced_step_in_progress_thread): Adjust.
10564         (displaced_step_in_progress): Adjust.
10565         (add_displaced_stepping_state): Remove.
10566         (get_displaced_step_closure_by_addr): Adjust.
10567         (remove_displaced_stepping_state): Remove.
10568         (infrun_inferior_exit): Call displaced_step_state.reset.
10569         (use_displaced_stepping): Don't check for NULL.
10570         (displaced_step_prepare_throw): Call
10571         get_displaced_stepping_state.
10572         (displaced_step_fixup): Don't check for NULL.
10573         (prepare_for_detach): Don't check for NULL.
10574
10575 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10576
10577         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10578          in case of call that did not complete.
10579
10580 2019-01-02  Andrey Utkin  <autkin@undo.io>
10581
10582         * symfile.c (find_separate_debug_file): Fix search of debug files for
10583         remote debuggee.
10584
10585 2019-01-02  Tom Tromey  <tom@tromey.com>
10586
10587         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10588         indentation.
10589         * python/py-frame.c (frapy_older): Remove cast.
10590         (frapy_newer): Likewise.
10591         * python/py-breakpoint.c (local_setattro): Remove cast.
10592         * python/py-arch.c (archpy_name): Remove local variable.
10593         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10594
10595 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10596
10597         * unittests/basic_string_view/element_access/char/empty.cc:
10598         Fix year range in copyright header.
10599
10600 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10601
10602         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10603         Delete.
10604         <operator==>: Update with for removed field.
10605         <hash>: Likewise.
10606         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10607         <isa_features>: ...this.
10608         <abi_features>: New field.
10609         (riscv_isa_flen): Update comment.
10610         (riscv_abi_xlen): New declaration.
10611         (riscv_abi_flen): New declaration.
10612         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10613         isa_features.
10614         (riscv_abi_xlen): New function.
10615         (riscv_isa_flen): Update to get answer from isa_features.
10616         (riscv_abi_flen): New function.
10617         (riscv_has_fp_abi): Update to get answer from abi_features.
10618         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10619         xlen and flen.
10620         (riscv_call_info) <xlen, flen>: Update comment.
10621         (riscv_call_arg_struct): Remove invalid assertions
10622         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10623         is removed.
10624         (riscv_gdbarch_init): Gather isa features and abi features
10625         separately, ensure both match on the gdbarch when reusing an old
10626         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10627         a target with 64-bit float hardware.
10628
10629 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10630
10631         * source.c (search_command_helper): Stop reverse search
10632         when line 1 has been searched.
10633
10634 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10635
10636         * record-full.c (record_full_base_target::close): Rewrite
10637         record_full_core_buf_list free logic.
10638
10639 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10640
10641         * break-catch-syscall.c (print_one_catch_syscall): xfree
10642         the last text.
10643
10644 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10645
10646         * top.c (print_gdb_version): Update Copyright year in version
10647         message.
10648
10649 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10650
10651         Update copyright year range in all GDB files.
10652
10653 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10654
10655         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10656
10657 For older changes see ChangeLog-2018.
10658 \f
10659 Local Variables:
10660 mode: change-log
10661 left-margin: 8
10662 fill-column: 74
10663 version-control: never
10664 coding: utf-8
10665 End:
10666