gdb/ChangeLog

   1 2019-03-15  Tom Tromey  <tom@tromey.com>
   2
   3         * objfiles.h (struct objfile_per_bfd_storage)
   4         <demangled_hash_languages>: Now a bitset.
   5         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
   6         (lookup_minimal_symbol): Update.
   7
   8 2019-03-15  Tom Tromey  <tom@tromey.com>
   9
  10         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
  11         Don't return the symbol.
  12         * coffread.c (record_minimal_symbol): Use record_full.
  13
  14 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  15
  16         The MS-Windows port of ncurses fails to switch to a color pair if
  17         one or both of the colors are the implicit default colors.  This
  18         change records the default colors when TUI is initialized, and
  19         then specifies them explicitly when a color pair uses the default
  20         colors.  This allows color styling in TUI mode on MS-Windows.
  21
  22         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  23         ncurses_norm_attr.
  24         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  25         colors in ncurses_norm_attr.
  26         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  27         "none", replace it with the default color recorded in
  28         ncurses_norm_attr.
  29
  30 2019-03-14  Tom Tromey  <tromey@adacore.com>
  31
  32         * source-cache.h (class source_cache) <get_source_lines>: Return
  33         std::string.
  34         * source-cache.c (source_cache::extract_lines): Handle case where
  35         first_pos==npos.  Return std::string.
  36         (source_cache::get_source_lines): Update.
  37
  38 2019-03-14  Tom Tromey  <tromey@adacore.com>
  39
  40         * NEWS: Add item for "style sources" commands.
  41         * source-cache.c (source_cache::get_source_lines): Check
  42         source_styling.
  43         * cli/cli-style.c (source_styling): New global.
  44         (_initialize_cli_style): Add "style sources" commands.
  45         (show_style_sources): New function.
  46         * cli/cli-style.h (source_styling): Declare.
  47
  48 2019-03-14  Pedro Alves  <palves@redhat.com>
  49             Tom Tromey  <tromey@adacore.com>
  50
  51         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  52         * tui/tui-winsource.c (tui_refill_source_window): New function,
  53         from...
  54         (tui_horizontal_source_scroll): ... here.  Move some logic.
  55         * cli/cli-style.c (set_style_enabled): Notify new observable.
  56         * tui/tui-hooks.c (tui_redisplay_source): New function.
  57         (tui_attach_detach_observers): Attach or detach
  58         tui_redisplay_source.
  59         * observable.h (source_styling_changed): New observable.
  60         * observable.c: Define source_styling_changed observable.
  61
  62 2019-03-13  Tom Tromey  <tromey@adacore.com>
  63
  64         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
  65         (i386_gnu_nat_target::store_registers): Update.
  66         * target-debug.h (target_debug_print_std_string): New macro.
  67         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
  68         * windows-tdep.c (display_one_tib): Update.
  69         * tui/tui-stack.c (tui_make_status_line): Update.
  70         * top.c (print_inferior_quit_action): Update.
  71         * thread.c (thr_try_catch_cmd): Update.
  72         (add_thread_with_info): Update.
  73         (thread_target_id_str): Update.
  74         (thr_try_catch_cmd): Update.
  75         (thread_command): Update.
  76         (thread_find_command): Update.
  77         * record-btrace.c (record_btrace_target::info_record)
  78         (record_btrace_resume_thread, record_btrace_target::resume)
  79         (record_btrace_cancel_resume, record_btrace_step_thread)
  80         (record_btrace_target::wait, record_btrace_target::wait)
  81         (record_btrace_target::wait, record_btrace_target::stop): Update.
  82         * progspace.c (print_program_space): Update.
  83         * process-stratum-target.c
  84         (process_stratum_target::thread_address_space): Update.
  85         * linux-fork.c (linux_fork_mourn_inferior)
  86         (detach_checkpoint_command, info_checkpoints_command)
  87         (linux_fork_context): Update.
  88         (linux_fork_detach): Update.
  89         (class scoped_switch_fork_info): Update.
  90         (delete_checkpoint_command): Update.
  91         * infrun.c (follow_fork_inferior): Update.
  92         (follow_fork_inferior): Update.
  93         (proceed_after_vfork_done): Update.
  94         (handle_vfork_child_exec_or_exit): Update.
  95         (follow_exec): Update.
  96         (displaced_step_prepare_throw): Update.
  97         (displaced_step_restore): Update.
  98         (start_step_over): Update.
  99         (resume_1): Update.
 100         (clear_proceed_status_thread): Update.
 101         (proceed): Update.
 102         (print_target_wait_results): Update.
 103         (do_target_wait): Update.
 104         (context_switch): Update.
 105         (stop_all_threads): Update.
 106         (restart_threads): Update.
 107         (finish_step_over): Update.
 108         (handle_signal_stop): Update.
 109         (switch_back_to_stepped_thread): Update.
 110         (keep_going_pass_signal): Update.
 111         (print_exited_reason): Update.
 112         (normal_stop): Update.
 113         * inferior.c (inferior_pid_to_str): Change return type.
 114         (print_selected_inferior): Update.
 115         (add_inferior): Update.
 116         (detach_inferior): Update.
 117         * dummy-frame.c (fprint_dummy_frames): Update.
 118         * dcache.c (dcache_info_1): Update.
 119         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 120         (btrace_fetch, btrace_clear): Update.
 121         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 122         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 123         type.
 124         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 125         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 126         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 127         * gdbarch.c, gdbarch.h: Rebuild.
 128         * gdbarch.sh (core_pid_to_str): Change return type.
 129         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 130         return type.
 131         (windows_nat_target::pid_to_str): Change return type.
 132         (windows_delete_thread): Update.
 133         (windows_nat_target::attach): Update.
 134         (windows_nat_target::files_info): Update.
 135         * target-delegates.c: Rebuild.
 136         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 137         return type.
 138         (sol_thread_target::pid_to_str): Change return type.
 139         * remote.c (class remote_target) <pid_to_str>: Change return
 140         type.
 141         (remote_target::pid_to_str): Change return type.
 142         (extended_remote_target::attach, remote_target::remote_stop_ns)
 143         (remote_target::remote_notif_remove_queued_reply)
 144         (remote_target::push_stop_reply, remote_target::disable_btrace):
 145         Update.
 146         (extended_remote_target::attach): Update.
 147         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 148         type.
 149         (gdbsim_target::pid_to_str): Change return type.
 150         * ravenscar-thread.c (struct ravenscar_thread_target)
 151         <pid_to_str>: Change return type.
 152         (ravenscar_thread_target::pid_to_str): Change return type.
 153         * procfs.c (class procfs_target) <pid_to_str>: Change return
 154         type.
 155         (procfs_target::pid_to_str): Change return type.
 156         (procfs_target::attach): Update.
 157         (procfs_target::detach): Update.
 158         (procfs_target::fetch_registers): Update.
 159         (procfs_target::store_registers): Update.
 160         (procfs_target::wait): Update.
 161         (procfs_target::files_info): Update.
 162         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 163         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 164         return type.
 165         (nto_procfs_target::pid_to_str): Change return type.
 166         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 167         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 168         return type.
 169         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 170         (exit_lwp): Update.
 171         (attach_proc_task_lwp_callback, get_detach_signal)
 172         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 173         (linux_nat_target::resume, wait_lwp, stop_callback)
 174         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 175         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 176         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 177         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 178         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 179         type.
 180         (inf_ptrace_target::attach): Update.
 181         (inf_ptrace_target::files_info): Update.
 182         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 183         type.
 184         (go32_nat_target::pid_to_str): Change return type.
 185         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 186         (gnu_nat_target::wait): Update.
 187         (gnu_nat_target::wait): Update.
 188         (gnu_nat_target::resume): Update.
 189         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 190         (fbsd_nat_target::wait): Update.
 191         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 192         type.
 193         (darwin_nat_target::attach): Update.
 194         * corelow.c (class core_target) <pid_to_str>: Change return type.
 195         (core_target::pid_to_str): Change return type.
 196         * target.c (normal_pid_to_str): Change return type.
 197         (default_pid_to_str): Likewise.
 198         (target_pid_to_str): Change return type.
 199         (target_translate_tls_address): Update.
 200         (target_announce_detach): Update.
 201         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 202         return type.
 203         (bsd_uthread_target::pid_to_str): Change return type.
 204         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 205         type.
 206         (bsd_kvm_target::pid_to_str): Change return type.
 207         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 208         return type.
 209         (aix_thread_target::pid_to_str): Change return type.
 210         * target.h (struct target_ops) <pid_to_str>: Change return type.
 211         (target_pid_to_str, normal_pid_to_str): Likewise.
 212         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 213         type.
 214         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 215         type.
 216         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 217         return type.
 218         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 219         type.
 220         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 221         type.
 222         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 223         return type.
 224
 225 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 226
 227         * NEWS: Mention that the new default MI version is 3.  Mention
 228         changes to the output of commands and events that deal with
 229         multi-location breakpoints.
 230         * breakpoint.c: Include "mi/mi-out.h".
 231         (print_one_breakpoint): Change output syntax if using MI version
 232         >= 3.
 233         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 234         New.
 235         (mi_multi_location_breakpoint_output_fixed): New.
 236         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 237         (mi_cmd_fix_multi_location_breakpoint_output): New.
 238         (mi_multi_location_breakpoint_output_fixed): New.
 239         * mi/mi-cmds.c (mi_cmds): Register command
 240         -fix-multi-location-breakpoint-output.
 241         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 242         interpreter "mi".
 243
 244 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 245
 246         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 247         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 248         instantiate mi_ui_out based on interpreter name.
 249         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 250         * mi/mi-main.c (mi_load_progress): Likewise.
 251
 252 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 253
 254         * NEWS: Combine separate "New targets" sections for 8.3.
 255
 256 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 257
 258         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 259         (ppcfbsd_init_abi): Install gdbarch
 260         "fetch_tls_load_module_address" and "get_thread_local_address"
 261         methods.
 262
 263 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 264
 265         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 266         (riscv_fbsd_init_abi): Install gdbarch
 267         "fetch_tls_load_module_address" and "get_thread_local_address"
 268         methods.
 269
 270 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 271
 272         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 273         (i386fbsd_init_abi): Install gdbarch
 274         "fetch_tls_load_module_address" and "get_thread_local_address"
 275         methods.
 276
 277 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 278
 279         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 280         (amd64fbsd_init_abi): Install gdbarch
 281         "fetch_tls_load_module_address" and "get_thread_local_address"
 282         methods.
 283
 284 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 285
 286         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 287         (struct fbsd_pspace_data): New type.
 288         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 289         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 290         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 291         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 292         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 293
 294 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 295
 296         * gdbtypes.c (lookup_struct_elt): New function.
 297         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 298         * gdbtypes.h (struct struct_elt): New type.
 299         (lookup_struct_elt): New prototype.
 300
 301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 302
 303         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 304         remove disabled code block.
 305
 306 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 307
 308         * gdbarch.sh (get_thread_local_address): New method.
 309         * gdbarch.h, gdbarch.c: Regenerate.
 310         * target.c (target_translate_tls_address): Use
 311         gdbarch_get_thread_local_address if present instead of
 312         target::get_thread_local_address.
 313
 314 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 315
 316         * target.h (target::get_thread_local_address): Update comment.
 317
 318 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 319
 320         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 321         objfile->separate_debug_objfile_backlink if not NULL.
 322
 323 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 324
 325         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 326         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 327         (amd64bsd_store_inferior_registers): Likewise.
 328         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 329         Enable segment base registers.
 330         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 331         PT_GETFSBASE and PT_GETGSBASE.
 332         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 333         PT_SETGSBASE.
 334         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 335         segment base registers.
 336         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 337
 338 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 339
 340         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 341         Update calls to i386_target_description to add 'segments'
 342         parameter.
 343         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 344         add segment base registers.
 345         * arch/i386.c (i386_create_target_description): Add 'segments'
 346         parameter to enable segment base registers.
 347         * arch/i386.h (i386_create_target_description): Likewise.
 348         * features/i386/32bit-segments.xml: New file.
 349         * features/i386/32bit-segments.c: Generate.
 350         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 351         call to i386_target_description to add 'segments' parameter.
 352         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 353         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 354         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 355         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 356         if feature is present.
 357         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 358         Add 'segments' parameter to call to i386_target_description.
 359         (i386_target_description): Add 'segments' parameter to enable
 360         segment base registers.
 361         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 362         to call to i386_target_description.
 363         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 364         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 365         Define I386_NUM_REGS.
 366         (i386_target_description): Add 'segments' parameter to enable
 367         segment base registers.
 368
 369 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 370
 371         PR/24325
 372         * source-cache.c: #undef open and close, to avoid unresolved
 373         externals during linking.
 374
 375 2019-03-12  Tom Tromey  <tromey@adacore.com>
 376
 377         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 378         const.  Add initializers.
 379         (_initialize_remote): Don't initialize ptid globals.
 380
 381 2019-03-12  Pedro Alves  <palves@redhat.com>
 382
 383         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 384
 385 2019-03-12  Pedro Alves  <palves@redhat.com>
 386
 387         * cp-name-parser.y (main): Remove unused 'len' variable.
 388
 389 2019-03-12  Tom Tromey  <tromey@adacore.com>
 390
 391         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 392         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 393
 394 2019-03-12  Tom Tromey  <tromey@adacore.com>
 395
 396         * linux-nat.c (iterate_over_lwps): Update.
 397         (stop_callback): Remove parameter.
 398         (stop_wait_callback, detach_callback, resume_set_callback)
 399         (select_singlestep_lwp_callback, set_ignore_sigint)
 400         (status_callback, resumed_callback, resume_clear_callback)
 401         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 402         data parameter.
 403         (linux_nat_target::detach, linux_nat_target::resume)
 404         (linux_stop_and_wait_all_lwps, select_event_lwp)
 405         (linux_nat_filter_event, linux_nat_wait_1)
 406         (linux_nat_target::kill, linux_nat_target::stop)
 407         (linux_nat_target::stop): Update.
 408         (linux_nat_resume_callback): Change type.
 409         (resume_stopped_resumed_lwps, count_events_callback)
 410         (select_event_lwp_callback): Likewise.
 411         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 412         * arm-linux-nat.c (struct update_registers_data): Remove.
 413         (update_registers_callback): Change type.
 414         (arm_linux_insert_hw_breakpoint1): Update.
 415         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 416         parameter.
 417         (x86_linux_dr_set_addr): Update.
 418         (x86_linux_dr_set_control): Update.
 419         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 420         (iterate_over_lwps): Use gdb::function_view.
 421         * nat/aarch64-linux-hw-point.c (struct
 422         aarch64_dr_update_callback_param): Remove.
 423         (debug_reg_change_callback): Change type.
 424         (aarch64_notify_debug_reg_change): Update.
 425         * s390-linux-nat.c (s390_refresh_per_info): Update.
 426
 427 2019-03-11  Tom Tromey  <tromey@adacore.com>
 428
 429         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 430         redundant assignment to "this_cu".
 431
 432 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 433
 434         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 435
 436 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 437
 438         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 439         from...
 440         (rank_one_type): ... this.
 441
 442 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 443
 444         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 445         from...
 446         (rank_one_type): ... this.
 447
 448 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 449
 450         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 451         from...
 452         (rank_one_type): ... this.
 453
 454 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 455
 456         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 457         from...
 458         (rank_one_type): ... this.
 459
 460 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 461
 462         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 463         from...
 464         (rank_one_type): ... this.
 465
 466 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 467
 468         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 469         from...
 470         (rank_one_type): ... this.
 471
 472 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 473
 474         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 475         from...
 476         (rank_one_type): ... this.
 477
 478 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 479
 480         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 481         from...
 482         (rank_one_type): ... this.
 483
 484 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 485
 486         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 487         from...
 488         (rank_one_type): ... this.
 489
 490 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 491
 492         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 493         from...
 494         (rank_one_type): ... this.
 495
 496 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 497
 498         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 499         from...
 500         (rank_one_type): ... this.
 501
 502 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 503
 504         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 505         from...
 506         (rank_one_type): ... this.
 507
 508 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 509
 510         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 511         inferior-events' shows the example events.
 512
 513 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 514
 515         Support styling on native MS-Windows console
 516
 517         PR/24315
 518         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 519         on MS-Windows if $TERM is not defined.
 520
 521         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 522
 523         * posix-hdep.c (gdb_console_fputs):
 524         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 525         functions.
 526         * ui-file.h (gdb_console_fputs): Add prototype.
 527
 528         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 529         back to fputs only if the former returns zero.
 530
 531 2019-03-07  Tom Tromey  <tom@tromey.com>
 532
 533         * symmisc.c (print_symbol_bcache_statistics): Update.
 534         (print_objfile_statistics): Update.
 535         * symfile.c (allocate_symtab): Update.
 536         * stabsread.c: Don't include bcache.h.
 537         * psymtab.h (struct psymbol_bcache): Don't declare.
 538         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 539         (psymbol_bcache_init, psymbol_bcache_free)
 540         (psymbol_bcache_get_bcache): Don't declare.
 541         * psymtab.c (struct psymbol_bcache): Remove.
 542         (psymtab_storage::psymtab_storage): Update.
 543         (psymtab_storage::~psymtab_storage): Update.
 544         (psymbol_bcache_init, psymbol_bcache_free)
 545         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 546         (add_psymbol_to_bcache): Update.
 547         (allocate_psymtab): Update.
 548         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 549         macro_cache>: No longer pointers.
 550         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 551         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 552         * macrotab.c (macro_bcache): Update.
 553         * macroexp.c: Don't include bcache.h.
 554         * gdbtypes.c (check_types_worklist): Update.
 555         (types_deeply_equal): Remove TRY/CATCH.  Update.
 556         * elfread.c (elf_symtab_read): Update.
 557         * dwarf2read.c: Don't include bcache.h.
 558         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 559         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 560         (print_bcache_statistics, bcache_memory_used): Don't declare.
 561         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 562         methods.  Rename all data members.
 563         * bcache.c (struct bcache): Move to bcache.h.
 564         (bcache::expand_hash_table): Rename from expand_hash_table.
 565         (bcache): Remove.
 566         (bcache::insert): Rename from bcache_full.
 567         (bcache::compare): Rename from bcache_compare.
 568         (bcache_xmalloc): Remove.
 569         (bcache::~bcache): Rename from bcache_xfree.
 570         (bcache::print_statistics): Rename from print_bcache_statistics.
 571         (bcache::memory_used): Rename from bcache_memory_used.
 572
 573 2019-03-07  Pedro Alves  <palves@redhat.com>
 574
 575         * infrun.c (normal_stop): Also check for
 576         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 577
 578 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 579
 580         * f-lang.c (value_from_host_double): Moved to...
 581         * value.c (value_from_host_double): ...here.
 582         * value.h (value_from_host_double): Declare.
 583         * guile/scm-math.c (vlscm_convert_typed_number): Use
 584         value_from_host_double.
 585         (vlscm_convert_number): Likewise.
 586         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 587         * python/py-value.c (convert_value_from_python): Likewise.
 588
 589 2019-03-06  Tom Tromey  <tom@tromey.com>
 590
 591         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 592
 593 2019-03-06  Tom Tromey  <tom@tromey.com>
 594
 595         * utils.h (free_current_contents): Don't declare.
 596         * utils.c (free_current_contents): Remove.
 597
 598 2019-03-06  Tom Tromey  <tom@tromey.com>
 599
 600         * top.c (quit_force): Update.
 601         * main.c (captured_command_loop): Update.
 602         * common/new-op.c (operator new): Update.
 603         * common/common-exceptions.c (struct catcher)
 604         <save_cleanup_chain>: Remove member.
 605         (exceptions_state_mc_init): Update.
 606         (exception_try_scope_entry): Return nullptr.
 607         (exception_try_scope_exit, exception_rethrow)
 608         (throw_exception_sjlj, throw_exception_cxx): Update.
 609         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 610         (all_cleanups, do_cleanups, discard_cleanups)
 611         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 612         (restore_cleanups, restore_final_cleanups): Don't declare.
 613         (do_final_cleanups): Remove parameter.
 614         * common/cleanups.c (cleanup_chain, make_cleanup)
 615         (make_cleanup_dtor, all_cleanups, do_cleanups)
 616         (discard_my_cleanups, discard_cleanups)
 617         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 618         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 619         (null_cleanup): Remove.
 620         (do_final_cleanups): Remove parameter.
 621
 622 2019-03-06  Tom Tromey  <tom@tromey.com>
 623
 624         * remote.c (remote_target::remote_parse_stop_reply): Use
 625         unique_xmalloc_ptr.
 626
 627 2019-03-06  Tom Tromey  <tom@tromey.com>
 628
 629         * stabsread.c (struct stabs_field_info): Rename from field_info.
 630         <list, fnlist>: Add initializers.
 631         <obstack>: New member.
 632         (read_member_functions, read_struct_fields, read_baseclasses):
 633         Allocate on obstack.  Don't use cleanups.
 634         (read_one_struct_field, read_member_functions, read_struct_fields)
 635         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 636         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 637         (read_struct_type): Update.
 638
 639 2019-03-06  Tom Tromey  <tom@tromey.com>
 640
 641         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 642         * common/filestuff.h (make_cleanup_close): Don't declare.
 643         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 644         Remove.
 645
 646 2019-03-06  Tom Tromey  <tom@tromey.com>
 647
 648         * solib-aix.c: Use make_scope_exit.
 649
 650 2019-03-06  Tom Tromey  <tom@tromey.com>
 651
 652         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 653         Use make_scope_exit.
 654
 655 2019-03-06  Tom Tromey  <tom@tromey.com>
 656
 657         * solib-svr4.c (disable_probes_interface): Remove parameter.
 658         (svr4_handle_solib_event): Use make_scope_exit.
 659
 660 2019-03-06  Tom Tromey  <tom@tromey.com>
 661
 662         * remote.c (struct stop_reply_deleter): Remove.
 663         (stop_reply_up): Update.
 664         (struct stop_reply): Derive from notif_event.  Don't typedef.
 665         <regcache>: Now a std::vector.
 666         (stop_reply_xfree): Remove.
 667         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 668         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 669         (remote_target::discard_pending_stop_replies): Use delete.
 670         (remote_target::remote_parse_stop_reply): Update.
 671         (remote_target::process_stop_reply): Update.
 672         * remote-notif.h (struct notif_event): Add virtual destructor.
 673         Remove "dtr" member.
 674         (struct notif_client) <alloc_event>: Return a unique_ptr.
 675         (notif_event_xfree): Don't declare.
 676         (notif_event_up): New typedef.
 677         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 678         (notif_event_xfree, do_notif_event_xfree): Remove.
 679         (remote_notif_state_xfree): Update.
 680
 681 2019-03-06  Tom Tromey  <tom@tromey.com>
 682
 683         * infrun.c (displaced_step_clear_cleanup): Now a
 684         forward_scope_exit type.
 685         (displaced_step_prepare_throw): Update.
 686         (displaced_step_fixup): Update.
 687
 688 2019-03-06  Tom Tromey  <tom@tromey.com>
 689
 690         * inferior.h (class inferior): Update comment.
 691         * gdbthread.h (class thread_info): Update comment.
 692
 693 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 694             Tom Tromey  <tom@tromey.com>
 695
 696         * stabsread.h (struct stab_section_list): Remove.
 697         (coffstab_build_psymtabs): Update.
 698         * dbxread.c (symbuf_sections): Now a std::vector.
 699         (sect_idx): New global.
 700         (fill_symbuf): Update.
 701         (coffstab_build_psymtabs): Change type of stabsects parameter.
 702         Update.
 703         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 704         std::vector.
 705         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 706         (coff_locate_sections): Update.
 707         (coff_symfile_read): Remove cleanups.  Update.
 708         (init_stringtab): Add storage parameter.
 709         (free_stringtab, free_stringtab_cleanup): Remove.
 710         (init_lineno): Add storage parameter.
 711         (free_linetab, free_linetab_cleanup): Remove.
 712
 713 2019-03-06  Pedro Alves  <palves@redhat.com>
 714
 715         * linux-fork.c (fork_info::clobber_regs): Delete.
 716         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 717         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 718         comment.  Adjust.
 719         (scoped_switch_fork_info::scoped_switch_fork_info)
 720         (checkpoint_command, linux_fork_context): Adjust
 721         fork_save_infrun_state calls.
 722
 723 2019-03-06  Pedro Alves  <palves@redhat.com>
 724
 725         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 726         (inf_has_multiple_threads): Return 'bool' and rewrite using
 727         inferior_info::threads().
 728
 729 2019-03-06  Pedro Alves  <palves@redhat.com>
 730
 731         * linux-fork.c: Include <list>.
 732         (fork_list): Now a std::list instance.
 733         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 734         (forks_exist_p, find_last_fork): Adjust.
 735         (new_fork): Delete.
 736         (one_fork_p): New.
 737         (add_fork): Adjust.
 738         (free_fork): Delete, folded into fork_info::~fork_info().
 739         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 740         Adjust.
 741         (init_fork_list): Delete.
 742         (linux_fork_killall, linux_fork_mourn_inferior)
 743         (linux_fork_detach, info_checkpoints_command): Adjust.
 744         (_initialize_linux_fork): No longer call init_fork_list.
 745
 746 2019-03-06  Pedro Alves  <palves@redhat.com>
 747
 748         * linux-fork.c (new_fork): New, split out of ...
 749         (add_fork): ... this.  Return void.  Move "first fork" special
 750         case from here, to ...
 751         (checkpoint_command): ... here.
 752         * linux-linux.h (add_fork): Return void.
 753
 754 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 755
 756         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 757
 758 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 759             Chris January  <chris.january@arm.com>
 760             David Lecomber  <david.lecomber@arm.com>
 761
 762         * f-exp.y: New token, UNOP_INTRINSIC.
 763         (exp): New pattern using UNOP_INTRINSIC token.
 764         (f77_keywords): Add 'abs' keyword.
 765         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 766         (value_from_host_double): New function.
 767         (evaluate_subexp_f): Support UNOP_ABS.
 768
 769 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 770
 771         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 772         types.
 773
 774 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 775
 776         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 777         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 778         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 779
 780 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 781
 782         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 783
 784 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 785             Chris January  <chris.january@arm.com>
 786
 787         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 788         * f-exp.y: Define 'KIND' token.
 789         (exp): New pattern for KIND expressions.
 790         (ptype): Handle types with a kind extension.
 791         (direct_abs_decl): Extend to spot kind extensions.
 792         (f77_keywords): Add 'kind' to the list.
 793         (push_kind_type): New function.
 794         (convert_to_kind_type): New function.
 795         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 796         * parse.c (operator_length_standard): Likewise.
 797         * parser-defs.h (enum type_pieces): Add tp_kind.
 798         * std-operator.def: Add UNOP_KIND.
 799
 800 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 801
 802         * f-exp.y (f_parse): Set yydebug.
 803
 804 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 805
 806         * f-lang.c (evaluate_subexp_f): New function.
 807         (exp_descriptor_f): New global.
 808         (f_language_defn): Use exp_descriptor_f instead of
 809         exp_descriptor_standard.
 810
 811 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 812
 813         * f-exp.y (struct token): Add comments.
 814         (dot_ops): Remove uppercase versions and the end marker.
 815         (f77_keywords): Likewise.
 816         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 817         entries in the dot_ops array are case insensitive, and use
 818         strncasecmp to compare strings.  Also some whitespace cleanup in
 819         this area.  Similar for the f77_keywords array, except entries in
 820         this list might be case sensitive.
 821
 822 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 823
 824         * f-exp.y (struct f77_boolean_val): Add comments.
 825         (boolean_values): Remove uppercase versions, and end marker.
 826         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 827         and use strncasecmp to achieve case insensitivity.  Additionally,
 828         perform whitespace cleanup around this code.
 829
 830 2019-03-06  Tom Tromey  <tromey@adacore.com>
 831
 832         * remote-sim.c (gdbsim_target_open): Use result of
 833         gdb_argv::release.
 834
 835 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 836         Dirk Schubert  <dirk.schubert@arm.com>
 837         Chris January  <chris.january@arm.com>
 838
 839         * eval.c (evaluate_subexp_standard): Call Fortran argument
 840         wrapping logic.
 841         * f-lang.c (struct value): A value which can be passed into a
 842         Fortran function call.
 843         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 844         where appropriate.
 845         (struct type): Value ready for a Fortran function call.
 846         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 847         is needed.
 848         * f-lang.h (fortran_argument_convert): Declaration.
 849         (fortran_preserve_arg_pointer): Declaration.
 850         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 851
 852 2019-03-05  Tom Tromey  <tromey@adacore.com>
 853
 854         * python/py-prettyprint.c (print_string_repr): Remove #if.
 855         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 856
 857 2019-03-05  Tom Tromey  <tromey@adacore.com>
 858
 859         * target.c (the_dummy_target): Move later.  Change type to
 860         "dummy_target".
 861         (initialize_targets): Don't initialize the_dummy_target.
 862
 863 2019-03-05  Tom Tromey  <tromey@adacore.com>
 864
 865         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 866         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 867
 868 2019-03-05  Tom Tromey  <tromey@adacore.com>
 869
 870         * windows-nat.c (windows_nat_target::attach)
 871         (windows_nat_target::detach): Don't call gdb_flush.
 872         * valprint.c (generic_val_print, val_print, val_print_string):
 873         Don't call gdb_flush.
 874         * utils.c (defaulted_query): Don't call gdb_flush.
 875         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 876         * target.c (target_announce_detach): Don't call gdb_flush.
 877         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 878         * remote.c (extended_remote_target::attach): Don't call
 879         gdb_flush.
 880         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 881         * printcmd.c (do_examine): Don't call gdb_flush.
 882         (info_display_command): Don't call gdb_flush.
 883         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 884         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 885         * memattr.c (info_mem_command): Don't call gdb_flush.
 886         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 887         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 888         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 889         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 890         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 891         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 892         (gnu_nat_target::detach): Don't call gdb_flush.
 893         * f-valprint.c (f_val_print): Don't call gdb_flush.
 894         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 895         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 896         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 897         gdb_flush.
 898         * c-valprint.c (c_val_print): Don't call gdb_flush.
 899         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 900
 901 2019-03-05  Tom Tromey  <tromey@adacore.com>
 902
 903         * varobj.c (update_dynamic_varobj_children): Update.
 904         (install_default_visualizer): Use reset, not release.
 905         * value.c (set_internalvar): Update.
 906         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 907         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 908         ATTRIBUTE_UNUSED_RESULT.
 909
 910 2019-03-05  Tom Tromey  <tromey@adacore.com>
 911
 912         * remote.c (class scoped_remote_fd) <release>: Add
 913         ATTRIBUTE_UNUSED_RESULT.
 914
 915 2019-03-05  Tom Tromey  <tromey@adacore.com>
 916
 917         * macroexp.c (struct macro_buffer) <release>: Add
 918         ATTRIBUTE_UNUSED_RESULT.
 919
 920 2019-03-05  Tom Tromey  <tromey@adacore.com>
 921
 922         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 923         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 924         ATTRIBUTE_UNUSED_RESULT.
 925
 926 2019-03-05  Tom Tromey  <tromey@adacore.com>
 927
 928         * common/scoped_fd.h (class scoped_fd) <release>: Add
 929         ATTRIBUTE_UNUSED_RESULT.
 930
 931 2019-03-05  Tom Tromey  <tromey@adacore.com>
 932
 933         * parser-defs.h (struct parser_state) <release>: Add
 934         ATTRIBUTE_UNUSED_RESULT.
 935
 936 2019-03-05  Tom Tromey  <tromey@adacore.com>
 937
 938         * utils.h (class gdb_argv) <release>: Add
 939         ATTRIBUTE_UNUSED_RESULT.
 940         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 941
 942 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 943
 944         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 945         for-loop range, to avoid compiler warnings.
 946
 947         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 948         avoid compiler warnings about unused variables.
 949
 950         * NEWS: Mention end of support for native debugging on MS-Windows
 951         before XP.
 952
 953         PR gdb/24292
 954         * common/netstuff.c:
 955         * gdbserver/gdbreplay.c
 956         * gdbserver/remote-utils.c:
 957         * ser-tcp.c:
 958         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 959         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 960         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 961         'getaddrinfo' and 'freeaddrinfo' were not available before
 962         Windows XP, and mingw.org's MinGW headers by default define
 963         _WIN32_WINNT to 0x500.
 964
 965 2019-03-01  Gary Benson <gbenson@redhat.com>
 966
 967         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 968
 969 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 970             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 971
 972         PR gdb/8527
 973         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 974         set_sigint_trap, clear_sigint_trap.
 975
 976 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 977
 978         * target.c (target_detach): Clear the regcache and the
 979         frame cache.
 980
 981 2019-02-27  Pedro Alves  <palves@redhat.com>
 982
 983         * utils.c (set_screen_size): When we cap the height/width sizes,
 984         tweak the corresponding command variable to show "unlimited":
 985
 986 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 987             Pedro Alves  <palves@redhat.com>
 988
 989         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 990         before calling rl_set_screen_size.
 991
 992 2019-02-27  Tom Tromey  <tromey@adacore.com>
 993
 994         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 995         define.
 996         * python/py-value.c: Remove Python 2.4 workaround.
 997         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 998         workaround.
 999         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1000         Python 2.4 workaround.
1001         * python/python-internal.h: Remove Python 2.4 comment.
1002         (Py_ssize_t): Don't define.
1003         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1004         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1005         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1006         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1007         * python/python.c (do_start_initialization): Remove Python 2.4
1008         workaround.
1009         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1010         (print_children): Remove Python 2.4 workaround.
1011         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1012         workaround.
1013         (CHARBUFFERPROC_NAME): Remove.
1014         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1015         Python 2.4 workaround.
1016
1017 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1018
1019         * NEWS: Note minimum Python version.
1020
1021 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1022
1023         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1024         code from these functions.  Remove corresponding ifdefs.  Use
1025         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1026         Remove gotos and target of gotos.
1027         (infpy_search_memory): Likewise.
1028
1029 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1032         (hppa_gdbarch_init): Don't register deleted functions with
1033         gdbarch.
1034
1035 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1036
1037         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1038         (h8300_unwind_sp): Delete.
1039         (h8300_dummy_id): Delete.
1040         (h8300_gdbarch_init): Don't register deleted functions with
1041         gdbarch.
1042
1043 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1044
1045         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1046         (ft32_unwind_pc): Delete.
1047         (ft32_unwind_sp): Delete.
1048         (ft32_gdbarch_init): Don't register deleted functions with
1049         gdbarch.
1050
1051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1052
1053         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1054         (frv_unwind_pc): Delete.
1055         (frv_unwind_sp): Delete.
1056         (frv_gdbarch_init): Don't register deleted functions with
1057         gdbarch.
1058
1059 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1060
1061         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1062         (riscv_unwind_pc): Delete.
1063         (riscv_unwind_sp): Delete.
1064         (riscv_gdbarch_init): Don't register deleted functions with
1065         gdbarch.
1066
1067 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1068
1069         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1070         (csky_unwind_pc): Delete.
1071         (csky_unwind_sp): Delete.
1072         (csky_gdbarch_init): Don't register deleted functions with
1073         gdbarch.
1074
1075 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1076
1077         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1078         (cris_unwind_pc): Delete.
1079         (cris_unwind_sp): Delete.
1080         (cris_gdbarch_init): Don't register deleted functions with
1081         gdbarch.
1082
1083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1084
1085         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1086         (bfin_unwind_pc): Delete.
1087         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1088
1089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1090
1091         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1092         (arm_unwind_pc): Delete.
1093         (arm_unwind_sp): Delete.
1094         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1095
1096 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1097
1098         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1099         (arc_unwind_pc): Delete.
1100         (arc_unwind_sp): Delete.
1101         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1102
1103 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1104
1105         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1106         (alpha_unwind_pc): Delete.
1107         (alpha_gdbarch_init): Don't register deleted functions with
1108         gdbarch.
1109
1110 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1113         (aarch64_unwind_pc): Delete.
1114         (aarch64_unwind_sp): Delete.
1115         (aarch64_gdbarch_init): Don't register deleted functions with
1116         gdbarch.
1117
1118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1119
1120         * gdbtypes.c (type_align): Don't consider static members when
1121         computing structure alignment.
1122
1123 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1124
1125         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1126         return 0 for other types.
1127         * arch-utils.c (default_type_align): Always return 0.
1128         * gdbarch.h: Regenerate.
1129         * gdbarch.sh (type_align): Extend comment.
1130         * gdbtypes.c (type_align): Add additional comments, always call
1131         gdbarch_type_align before applying the default rules.
1132         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1133         generic code will then apply a suitable default.
1134         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1135         types, return 0 for other types.
1136
1137 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1138
1139         * NEWS: Create a new section for the next release branch.
1140         Rename the section of the current branch, now that it has
1141         been cut.
1142
1143 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1144
1145         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1146         * version.in: Bump version to 8.3.50.DATE-git.
1147
1148 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1149
1150         * aix-thread.c (ptid_cmp): Remove unused variable.
1151         (get_signaled_thread): Likewise.
1152         (store_regs_user_thread): Likewise.
1153         (store_regs_kernel_thread): Likewise.
1154         (fetch_regs_kernel_thread): Remove shadowed variable.
1155
1156 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1157
1158         * features/riscv/32bit-cpu.xml: Add register numbers.
1159         * features/riscv/32bit-fpu.c: Regenerate.
1160         * features/riscv/32bit-fpu.xml: Add register numbers.
1161         * features/riscv/64bit-cpu.xml: Add register numbers.
1162         * features/riscv/64bit-fpu.c: Regenerate.
1163         * features/riscv/64bit-fpu.xml: Add register numbers.
1164
1165 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1166
1167         * NEWS: Mention two argument form of gdb.Value constructor.
1168         * python/py-value.c (convert_buffer_and_type_to_value): New
1169         function.
1170         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1171         Add support for handling an optional second argument.  Call
1172         convert_buffer_and_type_to_value as appropriate.
1173         * python/python-internal.h (Py_buffer_deleter): New struct.
1174         (Py_buffer_up): New typedef.
1175
1176 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1177
1178         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1179         instead of releasing ownership.
1180
1181 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1182
1183         * dwarf2read.c (open_and_init_dwp_file): Call
1184         elf_numsections instead of bfd_count_sections to initialize
1185         dwp_file->num_sections.
1186
1187 2019-02-25  Tom Tromey  <tromey@adacore.com>
1188
1189         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1190
1191 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1192
1193         * gcore.in: Add '--readnever' option when invoking GDB.
1194
1195 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1196
1197         * MAINTAINERS: Update my email address.
1198
1199 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1200
1201         * build-id.c (build_id_to_debug_bfd_1): New function.
1202         (build_id_to_debug_bfd): Look for separate debug file in
1203         sysroot.
1204
1205 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * gdbarch.sh: Update the copyright year range that is placed into
1208         generated files.
1209
1210 2019-02-22  Keith Seitz  <keiths@redhat.com>
1211
1212         PR symtab/23853
1213         * linespec.c (create_sals_line_offset): Search for the default
1214         symtab's filename instead of its fullname.
1215
1216 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1217
1218         * NEWS: Update style defaults.
1219
1220 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1221
1222         * main.c (captured_main_1): Disable styling in batch mode.
1223
1224 2019-02-20  Tom Tromey  <tom@tromey.com>
1225
1226         * symtab.c (symtab_symbol_info): Fix typos.
1227
1228 2019-02-20  Tom Tromey  <tromey@adacore.com>
1229
1230         * findcmd.c (_initialize_mem_search): Use upper case for
1231         metasyntactic variables.
1232
1233 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1234
1235         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1236         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1237
1238 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1239
1240         * top.h (source_file_name): Change to std::string.
1241         * top.c (source_file_name): Likewise.
1242         (command_line_input): Adjust.
1243         * cli/cli-script.c (script_from_file): Adjust.
1244
1245 2019-02-19  Tom Tromey  <tromey@adacore.com>
1246
1247         * ravenscar-thread.c
1248         (ravenscar_thread_target::update_thread_list): Don't call
1249         ada_build_task_list.
1250         * ada-lang.h (ada_build_task_list): Don't declare.
1251         * ada-tasks.c (struct ada_tasks_inferior_data)
1252         <task_list_valid_p>: Now bool.
1253         (read_known_tasks, ada_task_list_changed)
1254         (ada_tasks_invalidate_inferior_data): Update.
1255         (read_known_tasks_array): Return bool.
1256         (read_known_tasks_list): Likewise.
1257         (read_known_tasks): Return void.
1258         (ada_build_task_list): Now static.
1259
1260 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1261
1262         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1263         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1264
1265 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1266
1267         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1268         variant for ada_tasks_pspace_data_handle and
1269         ada_tasks_inferior_data_handle.
1270         (ada_tasks_pspace_data_cleanup): New function.
1271         (ada_tasks_inferior_data_cleanup): New function.
1272
1273 2019-02-17  Tom Tromey  <tom@tromey.com>
1274
1275         * macrotab.h (macro_source_fullname): Return a std::string.
1276         * macrotab.c (macro_include, check_for_redefinition)
1277         (macro_undef, macro_lookup_definition, foreach_macro)
1278         (foreach_macro_in_scope): Update.
1279         (macro_source_fullname): Return a std::string.
1280         * macrocmd.c (show_pp_source_pos): Update.
1281
1282 2019-02-17  Tom Tromey  <tom@tromey.com>
1283
1284         * macrocmd.c (show_pp_source_pos): Style the file names.
1285
1286 2019-02-17  Tom Tromey  <tom@tromey.com>
1287
1288         PR tui/24197:
1289         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1290
1291 2019-02-17  Tom Tromey  <tom@tromey.com>
1292
1293         * ada-lang.c (user_select_syms): Use filtered printing.
1294         * utils.c (wrap_style): New global.
1295         (desired_style): Remove.
1296         (emit_style_escape): Add stream parameter.
1297         (set_output_style, reset_terminal_style, prompt_for_continue):
1298         Update.
1299         (flush_wrap_buffer): Only flush gdb_stdout.
1300         (wrap_here): Set wrap_style.
1301         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1302         treat escape sequences as a character.  Change when wrap buffer is
1303         flushed.
1304         (fputs_styled): Do not set the output style when the default is
1305         requested.
1306         * ui-style.h (struct ui_file_style) <is_default>: New method.
1307         * source.c (print_source_lines_base): Emit escape sequences in one
1308         piece.
1309
1310 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1311
1312         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1313         integers and enumeration types.
1314
1315 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1316
1317         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1318         instead of lookup_symbol_in_language
1319         (do_exact_match): New function.
1320         (ada_get_symbol_name_matcher): Return do_exact_match when
1321         doing a verbatim match.
1322
1323 2019-02-15  Tom Tromey  <tromey@adacore.com>
1324
1325         * ravenscar-thread.c (ravenscar_thread_target::resume)
1326         (ravenscar_thread_target::wait): Special case wildcard requests.
1327
1328 2019-02-15  Tom Tromey  <tromey@adacore.com>
1329
1330         * ravenscar-thread.c (base_ptid): Remove.
1331         (struct ravenscar_thread_target) <close>: New method.
1332         <m_base_ptid>: New member.
1333         <update_inferior_ptid, active_task, task_is_currently_active,
1334         runtime_initialized>: Declare methods.
1335         <ravenscar_thread_target>: Add constructor.
1336         (ravenscar_thread_target::task_is_currently_active)
1337         (ravenscar_thread_target::update_inferior_ptid)
1338         (ravenscar_runtime_initialized): Rename.  Now methods.
1339         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1340         (ravenscar_thread_target::update_thread_list): Update.
1341         (ravenscar_thread_target::active_task): Now method.
1342         (ravenscar_thread_target::store_registers)
1343         (ravenscar_thread_target::prepare_to_store)
1344         (ravenscar_thread_target::prepare_to_store)
1345         (ravenscar_thread_target::mourn_inferior): Update.
1346         (ravenscar_inferior_created): Use "new" to create target.
1347         (ravenscar_thread_target::get_ada_task_ptid): Update.
1348         (_initialize_ravenscar): Don't initialize base_ptid.
1349         (ravenscar_ops): Remove global.
1350
1351 2019-02-15  Tom Tromey  <tromey@adacore.com>
1352
1353         * target.h (push_target): Declare new overload.
1354         * target.c (push_target): New overload, taking an rvalue reference.
1355         * remote.c (remote_target::open_1): Use push_target overload.
1356         * corelow.c (core_target_open): Use push_target overload.
1357
1358 2019-02-15  Tom Tromey  <tromey@adacore.com>
1359
1360         * ravenscar-thread.c (is_ravenscar_task)
1361         (ravenscar_task_is_currently_active): Return bool.
1362         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1363         (_initialize_ravenscar): Remove "(void)".
1364         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1365         Return bool.
1366
1367 2019-02-15  Tom Tromey  <tromey@adacore.com>
1368
1369         * ravenscar-thread.c (ravenscar_runtime_initializer)
1370         (has_ravenscar_runtime, get_running_thread_id)
1371         (ravenscar_thread_target::resume): Fix indentation.
1372
1373 2019-02-15  Tom Tromey  <tromey@adacore.com>
1374
1375         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1376         from ravenscar_arch_ops.
1377         (sparc_ravenscar_ops::fetch_registers)
1378         (sparc_ravenscar_ops::store_registers): Now methods.
1379         (sparc_ravenscar_prepare_to_store): Remove.
1380         (sparc_ravenscar_ops): Redefine.
1381         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1382         methods and destructor.  Remove members.
1383         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1384         (ravenscar_thread_target::store_registers)
1385         (ravenscar_thread_target::prepare_to_store): Update.
1386         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1387         Remove.
1388         (struct ppc_ravenscar_powerpc_ops): Derive from
1389         ravenscar_arch_ops.
1390         (ppc_ravenscar_powerpc_ops::fetch_registers)
1391         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1392         (ppc_ravenscar_powerpc_ops): Redefine.
1393         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1394         (ppc_ravenscar_e500_ops::fetch_registers)
1395         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1396         (ppc_ravenscar_e500_ops): Redefine.
1397         * aarch64-ravenscar-thread.c
1398         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1399         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1400         (aarch64_ravenscar_fetch_registers)
1401         (aarch64_ravenscar_store_registers): Now methods.
1402         (aarch64_ravenscar_ops): Redefine.
1403
1404 2019-02-15  Tom Tromey  <tromey@adacore.com>
1405
1406         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1407         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1408         (ravenscar_thread_target::stopped_by_watchpoint)
1409         (ravenscar_thread_target::stopped_data_address)
1410         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1411
1412 2019-02-15  Tom Tromey  <tromey@adacore.com>
1413
1414         * ravenscar-thread.c: Fix some typos.
1415
1416 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1417             Tom Tromey  <tromey@adacore.com>
1418
1419         * ada-lang.c (ada_exception_sal): Change addr_string to a
1420         std::string.
1421         (create_ada_exception_catchpoint): Update.
1422
1423 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1424             Tom Tromey  <tromey@adacore.com>
1425
1426         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1427         (bp_location_ops): Remove.
1428         (base_breakpoint_allocate_location): Update.
1429         (free_bp_location): Update.
1430         * ada-lang.c (class ada_catchpoint_location)
1431         <ada_catchpoint_location>: Remove ops parameter.
1432         (ada_catchpoint_location_dtor): Remove.
1433         (ada_catchpoint_location_ops): Remove.
1434         (allocate_location_exception): Update.
1435         * breakpoint.h (struct bp_location_ops): Remove.
1436         (class bp_location) <bp_location>: Remove bp_location_ops
1437         parameter.
1438         <~bp_location>: Add destructor.
1439         <ops>: Remove.
1440
1441 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1442             Pedro Alves  <palves@redhat.com>
1443
1444         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1445         'PATH_MAX'.
1446
1447 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1448             Samuel Thibault  <samuel.thibault@gnu.org>
1449             Thomas Schwinge  <thomas@codesourcery.com>
1450
1451         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1452         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1453
1454 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1455
1456         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1457         (check_empty): Use "const char *".
1458
1459         * gnu-nat.c (gnu_nat_target::detach): Instead of
1460         'detach_inferior (pid)' call
1461         'detach_inferior (find_inferior_pid (pid))'.
1462
1463         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1464         'nat/fork-inferior.o'.
1465         * gnu-nat.c: #include "nat/fork-inferior.h".
1466
1467         * gnu-nat.c (gnu_nat_target::detach): Instead of
1468         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1469         * gnu-nat.h: #include "inf-child.h".
1470         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1471         'i386_gnu_nat_target::fetch_registers'.
1472         (gnu_store_registers): Rename/move to
1473         'i386_gnu_nat_target::store_registers'.
1474
1475         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1476         * gnu-nat.h (mach_thread_info): New function.
1477         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1478
1479         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1480
1481 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1482
1483         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1484
1485 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1486
1487         * windows-nat.c (windows_add_thread): Add new parameter
1488         "main_thread_p" with default value set to false.  Update
1489         function documentation as well as all callers.
1490         (windows_delete_thread): Likewise.
1491         (fake_create_process): Update call to windows_add_thread.
1492         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1493         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1494         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1495         call to windows_delete_thread.
1496
1497 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1498
1499         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1500
1501 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1502
1503         * symfile.c (find_separate_debug_file): Use canonical path of
1504         sysroot with child_path instead of gdb_sysroot if it is valid.
1505
1506 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1507
1508         * symfile.c (find_separate_debug_file): Use child_path to
1509         determine if an object file is under a sysroot.
1510
1511 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1512
1513         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1514         unittests/child-path-selftests.c.
1515         * common/pathstuff.c (child_path): New function.
1516         * common/pathstuff.h (child_path): New prototype.
1517         * unittests/child-path-selftests.c: New file.
1518
1519 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1520
1521         * symfile.c (find_separate_debug_file): Look for separate debug
1522         files in debug directories under the sysroot.
1523
1524 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1525
1526         * symtab.h (struct minimal_symbol data_p): New const method.
1527         (struct minimal_symbol text_p): Likewise.
1528         * symtab.c (output_source_filename): Use file name style
1529         to print file name.
1530         (print_symbol_info): Likewise.
1531         (print_msymbol_info): Use address style to print addresses.
1532         Use function name style to print executable text symbols.
1533         (expand_symtab_containing_pc): Use data_p.
1534         (find_pc_sect_compunit_symtab): Likewise.
1535
1536 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1537
1538         * breakpoint.c (describe_other_breakpoints): Use address style
1539         to print addresses.
1540         (say_where): Likewise.
1541
1542 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1543
1544         * ada-typeprint.c (print_func_type): Print function name
1545         style to print function name.
1546         * c-typeprint.c (c_print_type_1): Likewise.
1547
1548 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1549
1550         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1551         for execve.
1552
1553 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1554
1555         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1556         type_stack.
1557
1558 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1559
1560         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1561         TYPE_CODE_REF types.
1562
1563 2019-02-08  Jim Wilson  <jimw@sifive.com>
1564
1565         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1566         (riscv_linux_fregset): New.
1567         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1568
1569 2019-02-07  Tom Tromey  <tom@tromey.com>
1570
1571         * thread.c (thread_cancel_execution_command): Update.
1572         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1573         methods.
1574         (struct thread_fsm_ops): Remove.
1575         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1576         (thread_fsm_should_stop, thread_fsm_return_value)
1577         (thread_fsm_set_finished, thread_fsm_finished_p)
1578         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1579         Don't declare.
1580         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1581         * infrun.c (clear_proceed_status_thread)
1582         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1583         (print_stop_event): Update.
1584         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1585         Add constructor.
1586         (step_command_fsm_ops): Remove.
1587         (new_step_command_fsm): Remove.
1588         (step_1): Update.
1589         (step_command_fsm::should_stop): Rename from
1590         step_command_fsm_should_stop.
1591         (step_command_fsm::clean_up): Rename from
1592         step_command_fsm_clean_up.
1593         (step_command_fsm::do_async_reply_reason): Rename from
1594         step_command_fsm_async_reply_reason.
1595         (struct until_next_fsm): Inherit from thread_fsm.  Add
1596         constructor.
1597         (until_next_fsm_ops): Remove.
1598         (new_until_next_fsm): Remove.
1599         (until_next_fsm::should_stop): Rename from
1600         until_next_fsm_should_stop.
1601         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1602         (until_next_fsm::do_async_reply_reason): Rename from
1603         until_next_fsm_async_reply_reason.
1604         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1605         constructor.  Change type of breakpoint.
1606         (finish_command_fsm_ops): Remove.
1607         (new_finish_command_fsm): Remove.
1608         (finish_command_fsm::should_stop): Rename from
1609         finish_command_fsm_should_stop.
1610         (finish_command_fsm::clean_up): Rename from
1611         finish_command_fsm_clean_up.
1612         (finish_command_fsm::return_value): Rename from
1613         finish_command_fsm_return_value.
1614         (finish_command_fsm::do_async_reply_reason): Rename from
1615         finish_command_fsm_async_reply_reason.
1616         (finish_command): Update.
1617         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1618         Add constructor.
1619         (call_thread_fsm_ops): Remove.
1620         (call_thread_fsm::call_thread_fsm): Rename from
1621         new_call_thread_fsm.
1622         (call_thread_fsm::should_stop): Rename from
1623         call_thread_fsm_should_stop.
1624         (call_thread_fsm::should_notify_stop): Rename from
1625         call_thread_fsm_should_notify_stop.
1626         (run_inferior_call, call_function_by_hand_dummy): Update.
1627         * cli/cli-interp.c (should_print_stop_to_console): Update.
1628         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1629         Add constructor.  Change type of location_breakpoint,
1630         caller_breakpoint.
1631         (until_break_fsm_ops): Remove.
1632         (new_until_break_fsm): Remove.
1633         (until_break_fsm::should_stop): Rename from
1634         until_break_fsm_should_stop.
1635         (until_break_fsm::clean_up): Rename from
1636         until_break_fsm_clean_up.
1637         (until_break_fsm::do_async_reply_reason): Rename from
1638         until_break_fsm_async_reply_reason.
1639         (until_break_command): Update.
1640         * thread-fsm.c: Remove.
1641         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1642
1643 2019-02-07  Tom Tromey  <tom@tromey.com>
1644
1645         * yy-remap.h: Add include guard.
1646         * xtensa-tdep.h: Add include guard.
1647         * xcoffread.h: Rename include guard.
1648         * varobj-iter.h: Add include guard.
1649         * tui/tui.h: Rename include guard.
1650         * tui/tui-winsource.h: Rename include guard.
1651         * tui/tui-wingeneral.h: Rename include guard.
1652         * tui/tui-windata.h: Rename include guard.
1653         * tui/tui-win.h: Rename include guard.
1654         * tui/tui-stack.h: Rename include guard.
1655         * tui/tui-source.h: Rename include guard.
1656         * tui/tui-regs.h: Rename include guard.
1657         * tui/tui-out.h: Rename include guard.
1658         * tui/tui-layout.h: Rename include guard.
1659         * tui/tui-io.h: Rename include guard.
1660         * tui/tui-hooks.h: Rename include guard.
1661         * tui/tui-file.h: Rename include guard.
1662         * tui/tui-disasm.h: Rename include guard.
1663         * tui/tui-data.h: Rename include guard.
1664         * tui/tui-command.h: Rename include guard.
1665         * tic6x-tdep.h: Add include guard.
1666         * target/waitstatus.h: Rename include guard.
1667         * target/wait.h: Rename include guard.
1668         * target/target.h: Rename include guard.
1669         * target/resume.h: Rename include guard.
1670         * target-float.h: Rename include guard.
1671         * stabsread.h: Add include guard.
1672         * rs6000-tdep.h: Add include guard.
1673         * riscv-fbsd-tdep.h: Add include guard.
1674         * regformats/regdef.h: Rename include guard.
1675         * record.h: Rename include guard.
1676         * python/python.h: Rename include guard.
1677         * python/python-internal.h: Rename include guard.
1678         * python/py-stopevent.h: Rename include guard.
1679         * python/py-ref.h: Rename include guard.
1680         * python/py-record.h: Rename include guard.
1681         * python/py-record-full.h: Rename include guard.
1682         * python/py-record-btrace.h: Rename include guard.
1683         * python/py-instruction.h: Rename include guard.
1684         * python/py-events.h: Rename include guard.
1685         * python/py-event.h: Rename include guard.
1686         * procfs.h: Add include guard.
1687         * proc-utils.h: Add include guard.
1688         * p-lang.h: Add include guard.
1689         * or1k-tdep.h: Rename include guard.
1690         * observable.h: Rename include guard.
1691         * nto-tdep.h: Rename include guard.
1692         * nat/x86-linux.h: Rename include guard.
1693         * nat/x86-linux-dregs.h: Rename include guard.
1694         * nat/x86-gcc-cpuid.h: Add include guard.
1695         * nat/x86-dregs.h: Rename include guard.
1696         * nat/x86-cpuid.h: Rename include guard.
1697         * nat/ppc-linux.h: Rename include guard.
1698         * nat/mips-linux-watch.h: Rename include guard.
1699         * nat/linux-waitpid.h: Rename include guard.
1700         * nat/linux-ptrace.h: Rename include guard.
1701         * nat/linux-procfs.h: Rename include guard.
1702         * nat/linux-osdata.h: Rename include guard.
1703         * nat/linux-nat.h: Rename include guard.
1704         * nat/linux-namespaces.h: Rename include guard.
1705         * nat/linux-btrace.h: Rename include guard.
1706         * nat/glibc_thread_db.h: Rename include guard.
1707         * nat/gdb_thread_db.h: Rename include guard.
1708         * nat/gdb_ptrace.h: Rename include guard.
1709         * nat/fork-inferior.h: Rename include guard.
1710         * nat/amd64-linux-siginfo.h: Rename include guard.
1711         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1712         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1713         * nat/aarch64-linux.h: Rename include guard.
1714         * nat/aarch64-linux-hw-point.h: Rename include guard.
1715         * mn10300-tdep.h: Add include guard.
1716         * mips-linux-tdep.h: Add include guard.
1717         * mi/mi-parse.h: Rename include guard.
1718         * mi/mi-out.h: Rename include guard.
1719         * mi/mi-main.h: Rename include guard.
1720         * mi/mi-interp.h: Rename include guard.
1721         * mi/mi-getopt.h: Rename include guard.
1722         * mi/mi-console.h: Rename include guard.
1723         * mi/mi-common.h: Rename include guard.
1724         * mi/mi-cmds.h: Rename include guard.
1725         * mi/mi-cmd-break.h: Rename include guard.
1726         * m2-lang.h: Add include guard.
1727         * location.h: Rename include guard.
1728         * linux-record.h: Rename include guard.
1729         * linux-nat.h: Add include guard.
1730         * linux-fork.h: Add include guard.
1731         * i386-darwin-tdep.h: Rename include guard.
1732         * hppa-linux-offsets.h: Add include guard.
1733         * guile/guile.h: Rename include guard.
1734         * guile/guile-internal.h: Rename include guard.
1735         * gnu-nat.h: Rename include guard.
1736         * gdb-stabs.h: Rename include guard.
1737         * frv-tdep.h: Add include guard.
1738         * f-lang.h: Add include guard.
1739         * event-loop.h: Add include guard.
1740         * darwin-nat.h: Rename include guard.
1741         * cp-abi.h: Rename include guard.
1742         * config/sparc/nm-sol2.h: Rename include guard.
1743         * config/nm-nto.h: Rename include guard.
1744         * config/nm-linux.h: Add include guard.
1745         * config/i386/nm-i386gnu.h: Rename include guard.
1746         * config/djgpp/nl_types.h: Rename include guard.
1747         * config/djgpp/langinfo.h: Rename include guard.
1748         * compile/gcc-cp-plugin.h: Add include guard.
1749         * compile/gcc-c-plugin.h: Add include guard.
1750         * compile/compile.h: Rename include guard.
1751         * compile/compile-object-run.h: Rename include guard.
1752         * compile/compile-object-load.h: Rename include guard.
1753         * compile/compile-internal.h: Rename include guard.
1754         * compile/compile-cplus.h: Rename include guard.
1755         * compile/compile-c.h: Rename include guard.
1756         * common/xml-utils.h: Rename include guard.
1757         * common/x86-xstate.h: Rename include guard.
1758         * common/version.h: Rename include guard.
1759         * common/vec.h: Rename include guard.
1760         * common/tdesc.h: Rename include guard.
1761         * common/selftest.h: Rename include guard.
1762         * common/scoped_restore.h: Rename include guard.
1763         * common/scoped_mmap.h: Rename include guard.
1764         * common/scoped_fd.h: Rename include guard.
1765         * common/safe-iterator.h: Rename include guard.
1766         * common/run-time-clock.h: Rename include guard.
1767         * common/refcounted-object.h: Rename include guard.
1768         * common/queue.h: Rename include guard.
1769         * common/ptid.h: Rename include guard.
1770         * common/print-utils.h: Rename include guard.
1771         * common/preprocessor.h: Rename include guard.
1772         * common/pathstuff.h: Rename include guard.
1773         * common/observable.h: Rename include guard.
1774         * common/netstuff.h: Rename include guard.
1775         * common/job-control.h: Rename include guard.
1776         * common/host-defs.h: Rename include guard.
1777         * common/gdb_wait.h: Rename include guard.
1778         * common/gdb_vecs.h: Rename include guard.
1779         * common/gdb_unlinker.h: Rename include guard.
1780         * common/gdb_unique_ptr.h: Rename include guard.
1781         * common/gdb_tilde_expand.h: Rename include guard.
1782         * common/gdb_sys_time.h: Rename include guard.
1783         * common/gdb_string_view.h: Rename include guard.
1784         * common/gdb_splay_tree.h: Rename include guard.
1785         * common/gdb_setjmp.h: Rename include guard.
1786         * common/gdb_ref_ptr.h: Rename include guard.
1787         * common/gdb_optional.h: Rename include guard.
1788         * common/gdb_locale.h: Rename include guard.
1789         * common/gdb_assert.h: Rename include guard.
1790         * common/filtered-iterator.h: Rename include guard.
1791         * common/filestuff.h: Rename include guard.
1792         * common/fileio.h: Rename include guard.
1793         * common/environ.h: Rename include guard.
1794         * common/common-utils.h: Rename include guard.
1795         * common/common-types.h: Rename include guard.
1796         * common/common-regcache.h: Rename include guard.
1797         * common/common-inferior.h: Rename include guard.
1798         * common/common-gdbthread.h: Rename include guard.
1799         * common/common-exceptions.h: Rename include guard.
1800         * common/common-defs.h: Rename include guard.
1801         * common/common-debug.h: Rename include guard.
1802         * common/cleanups.h: Rename include guard.
1803         * common/buffer.h: Rename include guard.
1804         * common/btrace-common.h: Rename include guard.
1805         * common/break-common.h: Rename include guard.
1806         * cli/cli-utils.h: Rename include guard.
1807         * cli/cli-style.h: Rename include guard.
1808         * cli/cli-setshow.h: Rename include guard.
1809         * cli/cli-script.h: Rename include guard.
1810         * cli/cli-interp.h: Rename include guard.
1811         * cli/cli-decode.h: Rename include guard.
1812         * cli/cli-cmds.h: Rename include guard.
1813         * charset-list.h: Add include guard.
1814         * buildsym-legacy.h: Rename include guard.
1815         * bfin-tdep.h: Add include guard.
1816         * ax.h: Rename include guard.
1817         * arm-linux-tdep.h: Add include guard.
1818         * arm-fbsd-tdep.h: Add include guard.
1819         * arch/xtensa.h: Rename include guard.
1820         * arch/tic6x.h: Add include guard.
1821         * arch/i386.h: Add include guard.
1822         * arch/arm.h: Rename include guard.
1823         * arch/arm-linux.h: Rename include guard.
1824         * arch/arm-get-next-pcs.h: Rename include guard.
1825         * arch/amd64.h: Add include guard.
1826         * arch/aarch64-insn.h: Rename include guard.
1827         * arch-utils.h: Rename include guard.
1828         * annotate.h: Add include guard.
1829         * amd64-darwin-tdep.h: Rename include guard.
1830         * aarch64-linux-tdep.h: Add include guard.
1831         * aarch64-fbsd-tdep.h: Add include guard.
1832         * aarch32-linux-nat.h: Add include guard.
1833
1834 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1835
1836         * macrotab.c (macro_define_internal): New function that
1837         factorizes macro_define_object_internal and macro_define_function
1838         code.
1839         (macro_define_object_internal): Use macro_define_internal.
1840         (macro_define_function): Likewise.
1841
1842 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1843
1844         * macrocmd.c (extract_identifier): Return
1845         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1846         callers.
1847
1848 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1849
1850         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1851
1852 2019-02-05  Tom Tromey  <tom@tromey.com>
1853
1854         * target.c (target_stack::unpush): Move assertion earlier.
1855
1856 2019-01-30  Tom Tromey  <tom@tromey.com>
1857
1858         PR python/23615:
1859         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1860         (gdbpy_parse_and_eval): Likewise.
1861         * python/python-internal.h (gdbpy_allow_threads): New class.
1862
1863 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1864
1865         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1866         (aarch64_fbsd_fpregmap): Move earlier.
1867         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1868         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1869         instead of individual calls to trad_frame_set_reg_addr.
1870         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1871         earlier.
1872         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1873         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1874         instead of individual calls to trad_frame_set_reg_addr.
1875
1876 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1877
1878         * CONTRIBUTE: Replace contribution list with wiki link.
1879
1880 2019-01-25  Tom Tromey  <tom@tromey.com>
1881
1882         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1883
1884 2019-01-25  Tom Tromey  <tom@tromey.com>
1885
1886         * xtensa-linux-nat.c: Fix common/ includes.
1887         * xml-support.h: Fix common/ includes.
1888         * xml-support.c: Fix common/ includes.
1889         * x86-linux-nat.c: Fix common/ includes.
1890         * windows-nat.c: Fix common/ includes.
1891         * varobj.h: Fix common/ includes.
1892         * varobj.c: Fix common/ includes.
1893         * value.c: Fix common/ includes.
1894         * valops.c: Fix common/ includes.
1895         * utils.c: Fix common/ includes.
1896         * unittests/xml-utils-selftests.c: Fix common/ includes.
1897         * unittests/utils-selftests.c: Fix common/ includes.
1898         * unittests/unpack-selftests.c: Fix common/ includes.
1899         * unittests/tracepoint-selftests.c: Fix common/ includes.
1900         * unittests/style-selftests.c: Fix common/ includes.
1901         * unittests/string_view-selftests.c: Fix common/ includes.
1902         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1903         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1904         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1905         * unittests/rsp-low-selftests.c: Fix common/ includes.
1906         * unittests/parse-connection-spec-selftests.c: Fix common/
1907         includes.
1908         * unittests/optional-selftests.c: Fix common/ includes.
1909         * unittests/offset-type-selftests.c: Fix common/ includes.
1910         * unittests/observable-selftests.c: Fix common/ includes.
1911         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1912         * unittests/memrange-selftests.c: Fix common/ includes.
1913         * unittests/memory-map-selftests.c: Fix common/ includes.
1914         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1915         * unittests/function-view-selftests.c: Fix common/ includes.
1916         * unittests/environ-selftests.c: Fix common/ includes.
1917         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1918         * unittests/common-utils-selftests.c: Fix common/ includes.
1919         * unittests/cli-utils-selftests.c: Fix common/ includes.
1920         * unittests/array-view-selftests.c: Fix common/ includes.
1921         * ui-file.c: Fix common/ includes.
1922         * tui/tui-io.c: Fix common/ includes.
1923         * tracepoint.h: Fix common/ includes.
1924         * tracepoint.c: Fix common/ includes.
1925         * tracefile-tfile.c: Fix common/ includes.
1926         * top.h: Fix common/ includes.
1927         * top.c: Fix common/ includes.
1928         * thread.c: Fix common/ includes.
1929         * target/waitstatus.h: Fix common/ includes.
1930         * target/waitstatus.c: Fix common/ includes.
1931         * target.h: Fix common/ includes.
1932         * target.c: Fix common/ includes.
1933         * target-memory.c: Fix common/ includes.
1934         * target-descriptions.c: Fix common/ includes.
1935         * symtab.h: Fix common/ includes.
1936         * symfile.c: Fix common/ includes.
1937         * stap-probe.c: Fix common/ includes.
1938         * spu-linux-nat.c: Fix common/ includes.
1939         * sparc-nat.c: Fix common/ includes.
1940         * source.c: Fix common/ includes.
1941         * solib.c: Fix common/ includes.
1942         * solib-target.c: Fix common/ includes.
1943         * ser-unix.c: Fix common/ includes.
1944         * ser-tcp.c: Fix common/ includes.
1945         * ser-pipe.c: Fix common/ includes.
1946         * ser-base.c: Fix common/ includes.
1947         * selftest-arch.c: Fix common/ includes.
1948         * s12z-tdep.c: Fix common/ includes.
1949         * rust-exp.y: Fix common/ includes.
1950         * rs6000-aix-tdep.c: Fix common/ includes.
1951         * riscv-tdep.c: Fix common/ includes.
1952         * remote.c: Fix common/ includes.
1953         * remote-notif.h: Fix common/ includes.
1954         * remote-fileio.h: Fix common/ includes.
1955         * remote-fileio.c: Fix common/ includes.
1956         * regcache.h: Fix common/ includes.
1957         * regcache.c: Fix common/ includes.
1958         * record-btrace.c: Fix common/ includes.
1959         * python/python.c: Fix common/ includes.
1960         * python/py-type.c: Fix common/ includes.
1961         * python/py-inferior.c: Fix common/ includes.
1962         * progspace.h: Fix common/ includes.
1963         * producer.c: Fix common/ includes.
1964         * procfs.c: Fix common/ includes.
1965         * proc-api.c: Fix common/ includes.
1966         * printcmd.c: Fix common/ includes.
1967         * ppc-linux-nat.c: Fix common/ includes.
1968         * parser-defs.h: Fix common/ includes.
1969         * osdata.c: Fix common/ includes.
1970         * obsd-nat.c: Fix common/ includes.
1971         * nat/x86-linux.c: Fix common/ includes.
1972         * nat/x86-linux-dregs.c: Fix common/ includes.
1973         * nat/x86-dregs.h: Fix common/ includes.
1974         * nat/x86-dregs.c: Fix common/ includes.
1975         * nat/ppc-linux.c: Fix common/ includes.
1976         * nat/mips-linux-watch.h: Fix common/ includes.
1977         * nat/mips-linux-watch.c: Fix common/ includes.
1978         * nat/linux-waitpid.c: Fix common/ includes.
1979         * nat/linux-ptrace.h: Fix common/ includes.
1980         * nat/linux-ptrace.c: Fix common/ includes.
1981         * nat/linux-procfs.c: Fix common/ includes.
1982         * nat/linux-personality.c: Fix common/ includes.
1983         * nat/linux-osdata.c: Fix common/ includes.
1984         * nat/linux-namespaces.c: Fix common/ includes.
1985         * nat/linux-btrace.h: Fix common/ includes.
1986         * nat/linux-btrace.c: Fix common/ includes.
1987         * nat/fork-inferior.c: Fix common/ includes.
1988         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1989         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1990         * nat/aarch64-linux.c: Fix common/ includes.
1991         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1992         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1993         * namespace.h: Fix common/ includes.
1994         * mips-linux-tdep.c: Fix common/ includes.
1995         * minsyms.c: Fix common/ includes.
1996         * mi/mi-parse.h: Fix common/ includes.
1997         * mi/mi-main.c: Fix common/ includes.
1998         * mi/mi-cmd-env.c: Fix common/ includes.
1999         * memrange.h: Fix common/ includes.
2000         * memattr.c: Fix common/ includes.
2001         * maint.h: Fix common/ includes.
2002         * maint.c: Fix common/ includes.
2003         * main.c: Fix common/ includes.
2004         * machoread.c: Fix common/ includes.
2005         * location.c: Fix common/ includes.
2006         * linux-thread-db.c: Fix common/ includes.
2007         * linux-nat.c: Fix common/ includes.
2008         * linux-fork.c: Fix common/ includes.
2009         * inline-frame.c: Fix common/ includes.
2010         * infrun.c: Fix common/ includes.
2011         * inflow.c: Fix common/ includes.
2012         * inferior.h: Fix common/ includes.
2013         * inferior.c: Fix common/ includes.
2014         * infcmd.c: Fix common/ includes.
2015         * inf-ptrace.c: Fix common/ includes.
2016         * inf-child.c: Fix common/ includes.
2017         * ia64-linux-nat.c: Fix common/ includes.
2018         * i387-tdep.c: Fix common/ includes.
2019         * i386-tdep.c: Fix common/ includes.
2020         * i386-linux-tdep.c: Fix common/ includes.
2021         * i386-linux-nat.c: Fix common/ includes.
2022         * i386-go32-tdep.c: Fix common/ includes.
2023         * i386-fbsd-tdep.c: Fix common/ includes.
2024         * i386-fbsd-nat.c: Fix common/ includes.
2025         * guile/scm-type.c: Fix common/ includes.
2026         * guile/guile.c: Fix common/ includes.
2027         * go32-nat.c: Fix common/ includes.
2028         * gnu-nat.c: Fix common/ includes.
2029         * gdbthread.h: Fix common/ includes.
2030         * gdbarch-selftests.c: Fix common/ includes.
2031         * gdb_usleep.c: Fix common/ includes.
2032         * gdb_select.h: Fix common/ includes.
2033         * gdb_bfd.c: Fix common/ includes.
2034         * gcore.c: Fix common/ includes.
2035         * fork-child.c: Fix common/ includes.
2036         * findvar.c: Fix common/ includes.
2037         * fbsd-nat.c: Fix common/ includes.
2038         * event-top.c: Fix common/ includes.
2039         * event-loop.c: Fix common/ includes.
2040         * dwarf2read.c: Fix common/ includes.
2041         * dwarf2loc.c: Fix common/ includes.
2042         * dwarf2-frame.c: Fix common/ includes.
2043         * dwarf-index-cache.c: Fix common/ includes.
2044         * dtrace-probe.c: Fix common/ includes.
2045         * disasm-selftests.c: Fix common/ includes.
2046         * defs.h: Fix common/ includes.
2047         * csky-tdep.c: Fix common/ includes.
2048         * cp-valprint.c: Fix common/ includes.
2049         * cp-support.h: Fix common/ includes.
2050         * cp-support.c: Fix common/ includes.
2051         * corelow.c: Fix common/ includes.
2052         * completer.h: Fix common/ includes.
2053         * completer.c: Fix common/ includes.
2054         * compile/compile.c: Fix common/ includes.
2055         * compile/compile-loc2c.c: Fix common/ includes.
2056         * compile/compile-cplus-types.c: Fix common/ includes.
2057         * compile/compile-cplus-symbols.c: Fix common/ includes.
2058         * command.h: Fix common/ includes.
2059         * cli/cli-dump.c: Fix common/ includes.
2060         * cli/cli-cmds.c: Fix common/ includes.
2061         * charset.c: Fix common/ includes.
2062         * build-id.c: Fix common/ includes.
2063         * btrace.h: Fix common/ includes.
2064         * btrace.c: Fix common/ includes.
2065         * breakpoint.h: Fix common/ includes.
2066         * breakpoint.c: Fix common/ includes.
2067         * ax.h:
2068         (enum agent_op): Fix common/ includes.
2069         * ax-general.c (struct aop_map): Fix common/ includes.
2070         * ax-gdb.c: Fix common/ includes.
2071         * auxv.c: Fix common/ includes.
2072         * auto-load.c: Fix common/ includes.
2073         * arm-tdep.c: Fix common/ includes.
2074         * arch/riscv.c: Fix common/ includes.
2075         * arch/ppc-linux-common.c: Fix common/ includes.
2076         * arch/i386.c: Fix common/ includes.
2077         * arch/arm.c: Fix common/ includes.
2078         * arch/arm-linux.c: Fix common/ includes.
2079         * arch/arm-get-next-pcs.c: Fix common/ includes.
2080         * arch/amd64.c: Fix common/ includes.
2081         * arch/aarch64.c: Fix common/ includes.
2082         * arch/aarch64-insn.c: Fix common/ includes.
2083         * arch-utils.c: Fix common/ includes.
2084         * amd64-windows-tdep.c: Fix common/ includes.
2085         * amd64-tdep.c: Fix common/ includes.
2086         * amd64-sol2-tdep.c: Fix common/ includes.
2087         * amd64-obsd-tdep.c: Fix common/ includes.
2088         * amd64-nbsd-tdep.c: Fix common/ includes.
2089         * amd64-linux-tdep.c: Fix common/ includes.
2090         * amd64-linux-nat.c: Fix common/ includes.
2091         * amd64-fbsd-tdep.c: Fix common/ includes.
2092         * amd64-fbsd-nat.c: Fix common/ includes.
2093         * amd64-dicos-tdep.c: Fix common/ includes.
2094         * amd64-darwin-tdep.c: Fix common/ includes.
2095         * agent.c: Fix common/ includes.
2096         * ada-lang.h: Fix common/ includes.
2097         * ada-lang.c: Fix common/ includes.
2098         * aarch64-tdep.c: Fix common/ includes.
2099
2100 2019-01-25  Tom Tromey  <tom@tromey.com>
2101
2102         * common/create-version.sh: Use common/version.h.
2103
2104 2019-01-24  Pedro Alves  <palves@redhat.com>
2105
2106         * infrun.c (signal_stop, signal_print, signal_program)
2107         (signal_catch, signal_pass): Now arrays instead of pointers.
2108         (update_signals_program_target, do_target_resume)
2109         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2110         * linux-nat.c (linux_nat_target::pass_signals)
2111         (linux_nat_target::create_inferior, linux_nat_target::attach):
2112         Adjust.
2113         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2114         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2115         * procfs.c (procfs_target::pass_signals): Adjust.
2116         * record-full.c (record_full_target::resume): Adjust.
2117         * remote.c (remote_target::pass_signals)
2118         (remote_target::program_signals): Adjust.
2119         * target-debug.h (target_debug_print_signals): Now takes a
2120         gdb::array_view as parameter.  Adjust.
2121         * target.h (target_ops) <pass_signals, program_signals>: Replace
2122         pointer and length parameters with gdb::array_view.
2123         (target_pass_signals, target_program_signals): Likewise.
2124         * target-delegates.c: Regenerate.
2125
2126 2019-01-24  Pedro Alves  <palves@redhat.com>
2127
2128         * common/forward-scope-exit.h
2129         (forward_scope_exit::forward_scope_exit): Pass arguments to
2130         m_bind_function directly, instead of creating a std::bind and
2131         copying that.
2132
2133 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2134
2135         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2136         for static members.
2137         (pass_in_v_vfp_candidate): Likewise.
2138
2139 2019-01-23  Tom Tromey  <tom@tromey.com>
2140             Pedro Alves  <palves@redhat.com>
2141
2142         * regcache.c (class regcache_invalidator): Remove.
2143         (regcache::raw_write): Use make_scope_exit.
2144
2145 2019-01-23  Tom Tromey  <tom@tromey.com>
2146
2147         * ui-out.h (class ui_out_emit_type): Update comment.
2148
2149 2019-01-23  Tom Tromey  <tom@tromey.com>
2150
2151         * infrun.c (fetch_inferior_event): Update comment.
2152
2153 2019-01-23  Tom Tromey  <tom@tromey.com>
2154             Pedro Alves  <palves@redhat.com>
2155
2156         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2157         parameter.
2158         (fetch_inferior_event): Use SCOPE_EXIT.
2159
2160
2161 2019-01-23  Tom Tromey  <tom@tromey.com>
2162             Pedro Alves  <palves@redhat.com>
2163
2164         * infrun.c (disable_thread_events): Delete.
2165         (stop_all_threads): Use SCOPE_EXIT.
2166
2167 2019-01-23  Tom Tromey  <tom@tromey.com>
2168             Pedro Alves  <palves@redhat.com>
2169
2170         * symfile.c: Include forward-scope-exit.h.
2171         (clear_symtab_users_cleanup): Replace forward declaration with
2172         a FORWARD_SCOPE_EXIT.
2173         (syms_from_objfile_1): Use the forward_scope_exit and
2174         gdb::optional instead of cleanup_function.
2175         (reread_symbols): Use the forward_scope_exit instead of
2176         cleanup_function.
2177         (clear_symtab_users_cleanup): Remove function.
2178
2179 2019-01-23  Tom Tromey  <tom@tromey.com>
2180             Pedro Alves  <palves@redhat.com>
2181
2182         * linux-nat.c: Include scope-exit.h.
2183         (cleanup_target_stop): Remove.
2184         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2185         SCOPE_EXIT.
2186
2187 2019-01-23  Tom Tromey  <tom@tromey.com>
2188             Pedro Alves  <palves@redhat.com>
2189
2190         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2191         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2192
2193 2019-01-23  Tom Tromey  <tom@tromey.com>
2194             Andrew Burgess  <andrew.burgess@embecosm.com>
2195             Pedro Alves  <palves@redhat.com>
2196
2197         * infrun.c (fetch_inferior_event): Use scope_exit.
2198         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2199         * top.c (execute_command): Use scope_exit.
2200         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2201         * utils.c (do_bpstat_clear_actions_cleanup)
2202         (make_bpstat_clear_actions_cleanup): Remove.
2203
2204 2019-01-23  Tom Tromey  <tom@tromey.com>
2205             Pedro Alves  <palves@redhat.com>
2206
2207         * infrun.c: Include "common/scope-exit.h"
2208         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2209         (wait_for_inferior): Use SCOPE_EXIT.
2210         (fetch_inferior_event): Use scope_exit.
2211
2212 2019-01-23  Tom Tromey  <tom@tromey.com>
2213             Pedro Alves  <palves@redhat.com>
2214
2215         * breakpoint.c (create_breakpoint): Remove cleanup.
2216
2217 2019-01-23  Tom Tromey  <tom@tromey.com>
2218             Andrew Burgess  <andrew.burgess@embecosm.com>
2219             Pedro Alves  <palves@redhat.com>
2220
2221 2019-01-23  Pedro Alves  <palves@redhat.com>
2222
2223         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2224
2225 2019-01-23  Pedro Alves  <palves@redhat.com>
2226             Andrew Burgess  <andrew.burgess@embecosm.com>
2227
2228         * gdbthread.h: Include "common/forward-scope-exit.h".
2229         (scoped_finish_thread_state): Redefine custom class in terms of
2230         forward_scope_exit.
2231
2232 2019-01-23  Pedro Alves  <palves@redhat.com>
2233             Andrew Burgess  <andrew.burgess@embecosm.com>
2234
2235         * common/forward-scope-exit.h: New file.
2236
2237 2019-01-23  Pedro Alves  <palves@redhat.com>
2238             Andrew Burgess  <andrew.burgess@embecosm.com>
2239             Tom Tromey  <tom@tromey.com>
2240
2241         * common/scope-exit.h: New file.
2242
2243 2019-01-23  Pedro Alves  <palves@redhat.com>
2244
2245         * common/preprocessor.h (ESC): Rename to ...
2246         (ESC_PARENS): ... this.
2247         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2248         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2249
2250 2019-01-23  Tom Tromey  <tom@tromey.com>
2251
2252         * language.h (class scoped_switch_to_sym_language_if_auto):
2253         Initialize m_lang in both cases.
2254
2255 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2256
2257         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2258         with XCNEW.
2259
2260 2019-01-22  Tom Tromey  <tom@tromey.com>
2261
2262         * corelow.c: Do not include sys/file.h.
2263
2264 2019-01-22  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-wingeneral.h: Include gdb_curses.h.
2267
2268 2019-01-22  Tom Tromey  <tom@tromey.com>
2269
2270         * source-cache.h (class source_cache) <get_source_lines,
2271         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2272
2273 2019-01-22  Tom Tromey  <tom@tromey.com>
2274
2275         * remote-fileio.h (struct remote_target): Declare.
2276
2277 2019-01-22  Tom Tromey  <tom@tromey.com>
2278
2279         * python/py-arch.c: Do not include py-ref.h.
2280         * python/py-bpevent.c: Do not include py-ref.h.
2281         * python/py-cmd.c: Do not include py-ref.h.
2282         * python/py-continueevent.c: Do not include py-ref.h.
2283         * python/py-event.h: Do not include py-ref.h.
2284         * python/py-evtregistry.c: Do not include py-ref.h.
2285         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2286         * python/py-frame.c: Do not include py-ref.h.
2287         * python/py-framefilter.c: Do not include py-ref.h.
2288         * python/py-function.c: Do not include py-ref.h.
2289         * python/py-infevents.c: Do not include py-ref.h.
2290         * python/py-linetable.c: Do not include py-ref.h.
2291         * python/py-objfile.c: Do not include py-ref.h.
2292         * python/py-param.c: Do not include py-ref.h.
2293         * python/py-prettyprint.c: Do not include py-ref.h.
2294         * python/py-progspace.c: Do not include py-ref.h.
2295         * python/py-symbol.c: Do not include py-ref.h.
2296         * python/py-symtab.c: Do not include py-ref.h.
2297         * python/py-type.c: Do not include py-ref.h.
2298         * python/py-unwind.c: Do not include py-ref.h.
2299         * python/py-utils.c: Do not include py-ref.h.
2300         * python/py-value.c: Do not include py-ref.h.
2301         * python/py-varobj.c: Do not include py-ref.h.
2302         * python/py-xmethods.c: Do not include py-ref.h.
2303         * python/python.c: Do not include py-ref.h.
2304         * varobj.c: Do not include py-ref.h.
2305
2306 2019-01-22  Tom Tromey  <tom@tromey.com>
2307
2308         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2309         keyword for bcache.
2310
2311 2019-01-22  Tom Tromey  <tom@tromey.com>
2312
2313         * compile/compile-cplus-types.c: Remove a comment by #include.
2314
2315 2019-01-22  Tom Tromey  <tom@tromey.com>
2316
2317         * compile/gcc-c-plugin.h: Include compile-internal.h.
2318
2319 2019-01-22  Tom Tromey  <tom@tromey.com>
2320
2321         * stabsread.c (EXTERN): Do not define.
2322         (symnum, next_symbol_text_func, processing_gcc_compilation)
2323         (within_function, global_sym_chain, global_stabs)
2324         (previous_stab_code, this_object_header_files)
2325         (n_this_object_header_files)
2326         (n_allocated_this_object_header_files): Define.
2327         * stabsread.h (EXTERN): Never define.  Use "extern".
2328
2329 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2330
2331         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2332         history_value.
2333
2334 2019-01-21  Tom Tromey  <tom@tromey.com>
2335
2336         * ui-out.c: Fix includes.
2337         * tui/tui-source.c: Fix includes.
2338         * target.c: Fix includes.
2339         * remote.c: Fix includes.
2340         * regcache.c: Fix includes.
2341         * python/py-block.c: Fix includes.
2342         * printcmd.c: Fix includes.
2343         * or1k-tdep.c: Fix includes.
2344         * mi/mi-main.c: Fix includes.
2345         * m32r-tdep.c: Fix includes.
2346         * csky-tdep.c: Fix includes.
2347         * compile/compile-cplus-types.c: Fix includes.
2348         * cli/cli-interp.c: Fix includes.
2349
2350 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2351
2352         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2353         for padding.
2354
2355 2019-01-16  Tom Tromey  <tom@tromey.com>
2356
2357         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2358         earlier.
2359         (struct objfile) <msymbols_range>: Move from top level.
2360         <msymbols>: New method.
2361         (class objfile_msymbols): Remove.
2362         * symtab.c (default_collect_symbol_completion_matches_break_on):
2363         Update.
2364         * symmisc.c (dump_msymbols): Update.
2365         * stabsread.c (scan_file_globals): Update.
2366         * objc-lang.c (info_selectors_command, info_classes_command)
2367         (find_methods): Update.
2368         * minsyms.c (find_solib_trampoline_target): Update.
2369         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2370         * coffread.c (coff_symfile_read): Update.
2371         * ada-lang.c (ada_lookup_simple_minsym)
2372         (ada_collect_symbol_completion_matches): Update.
2373
2374 2019-01-16  Tom Tromey  <tom@tromey.com>
2375
2376         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2377         type.  Remove no-argument constructor.
2378         <iterator::operator++>: Simplify.
2379         <begin>: Update.
2380         <end>: Use minimal_symbol_count.
2381
2382 2019-01-16  Tom Tromey  <tom@tromey.com>
2383
2384         * objfiles.h (struct objfile) <psymtabs>: New method.
2385         (class objfile_psymtabs): Remove.
2386         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2387         typedef.
2388         <range>: New method.
2389         (require_partial_symbols): Change return type.
2390         * psymtab.c (require_partial_symbols)
2391         (psym_expand_symtabs_matching): Update.
2392         * mdebugread.c (parse_partial_symbols): Update.
2393         * dbxread.c (dbx_end_psymtab): Update.
2394
2395 2019-01-15  Tom Tromey  <tom@tromey.com>
2396
2397         * symtab.c (lookup_objfile_from_block)
2398         (lookup_symbol_in_objfile_symtabs)
2399         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2400         (find_line_symtab, info_sources_command)
2401         (default_collect_symbol_completion_matches_break_on)
2402         (make_source_files_completion_list): Update.
2403         * symmisc.c (print_objfile_statistics, dump_objfile)
2404         (maintenance_print_symbols, maintenance_info_symtabs)
2405         (maintenance_check_symtabs, maintenance_info_line_tables):
2406         Update.
2407         * source.c (select_source_symtab)
2408         (forget_cached_source_info_for_objfile): Update.
2409         * objfiles.h (class objfile_compunits): Remove.
2410         (struct objfile) <compunits_range>: New typedef.
2411         (compunits): New method.
2412         * objfiles.c (objfile_relocate1): Update.
2413         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2414         * maint.c (count_symtabs_and_blocks): Update.
2415         * linespec.c (iterate_over_all_matching_symtabs): Update.
2416         * cp-support.c (add_symbol_overload_list_qualified): Update.
2417         * coffread.c (coff_symtab_read): Update.
2418         * ada-lang.c (add_nonlocal_symbols)
2419         (ada_collect_symbol_completion_matches)
2420         (ada_add_global_exceptions): Update.
2421
2422 2019-01-15  Tom Tromey  <tom@tromey.com>
2423
2424         * progspace.h (program_space) <objfiles_safe_range>: New
2425         typedef.
2426         <objfiles_safe>: New method.
2427         * objfiles.h (class all_objfiles_safe): Remove.
2428         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2429         * jit.c (jit_inferior_exit_hook): Update.
2430
2431 2019-01-17  Tom Tromey  <tom@tromey.com>
2432
2433         * progspace.h (program_space) <objfiles_range>: New typedef.
2434         <objfiles>: New method.
2435         <objfiles_head>: Rename from objfiles.
2436         (object_files): Update.
2437         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2438         * guile/scm-pretty-print.c
2439         (ppscm_find_pretty_printer_from_objfiles): Update.
2440         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2441         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2442         Update.
2443         * python/py-progspace.c (pspy_get_objfiles): Update.
2444         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2445         Update.
2446         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2447         (objfpy_lookup_objfile_by_build_id): Update.
2448         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2449         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2450         Update.
2451         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2452         (expand_symtab_containing_pc, lookup_objfile_from_block)
2453         (lookup_static_symbol, basic_lookup_transparent_type)
2454         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2455         (find_line_symtab, info_sources_command)
2456         (default_collect_symbol_completion_matches_break_on)
2457         (make_source_files_completion_list, find_main_name): Update.
2458         * symmisc.c (print_symbol_bcache_statistics)
2459         (print_objfile_statistics, maintenance_print_symbols)
2460         (maintenance_print_msymbols, maintenance_print_objfiles)
2461         (maintenance_info_symtabs, maintenance_check_symtabs)
2462         (maintenance_expand_symtabs, maintenance_info_line_tables):
2463         Update.
2464         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2465         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2466         (map_overlay_command, unmap_overlay_command)
2467         (simple_overlay_update, expand_symtabs_matching)
2468         (map_symbol_filenames): Update.
2469         * symfile-debug.c (set_debug_symfile): Update.
2470         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2471         Update.
2472         * source.c (select_source_symtab, forget_cached_source_info):
2473         Update.
2474         * solib.c (solib_read_symbols): Update.
2475         * solib-spu.c (append_ocl_sos): Update.
2476         * psymtab.c (maintenance_print_psymbols)
2477         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2478         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2479         * printcmd.c (info_symbol_command): Update.
2480         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2481         Update.
2482         * objfiles.h (class all_objfiles): Remove.
2483         * objfiles.c (have_partial_symbols, have_full_symbols)
2484         (have_minimal_symbols, qsort_cmp, update_section_map)
2485         (shared_objfile_contains_address_p)
2486         (default_iterate_over_objfiles_in_search_order): Update.
2487         * objc-lang.c (info_selectors_command, info_classes_command)
2488         (find_methods): Update.
2489         * minsyms.c (find_solib_trampoline_target): Update.
2490         * maint.c (maintenance_info_sections)
2491         (maintenance_translate_address, count_symtabs_and_blocks):
2492         Update.
2493         * main.c (captured_main_1): Update.
2494         * linux-thread-db.c (try_thread_db_load_from_pdir)
2495         (has_libpthread): Update.
2496         * linespec.c (iterate_over_all_matching_symtabs)
2497         (search_minsyms_for_name): Update.
2498         * jit.c (jit_find_objf_with_entry_addr): Update.
2499         * hppa-tdep.c (find_unwind_entry)
2500         (hppa_lookup_stub_minimal_symbol): Update.
2501         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2502         Update.
2503         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2504         (elf_gnu_ifunc_resolve_by_got): Update.
2505         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2506         * dwarf-index-write.c (save_gdb_index_command): Update.
2507         * cp-support.c (add_symbol_overload_list_qualified): Update.
2508         * breakpoint.c (create_overlay_event_breakpoint)
2509         (create_longjmp_master_breakpoint)
2510         (create_std_terminate_master_breakpoint)
2511         (create_exception_master_breakpoint): Update.
2512         * blockframe.c (find_pc_partial_function): Update.
2513         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2514         (ada_collect_symbol_completion_matches)
2515         (ada_add_global_exceptions): Update.
2516
2517 2019-01-17  Tom Tromey  <tom@tromey.com>
2518
2519         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2520         declare VEC.
2521         (solib_target_parse_libraries): Change return type.
2522         (library_list_start_segment, library_list_start_section)
2523         (library_list_end_library, library_list_start_library); Update.
2524         (solib_target_free_library_list): Remove.
2525         (solib_target_parse_libraries): Remove cleanup.  Change return
2526         type.
2527         (solib_target_current_sos): Update.
2528
2529 2019-01-17  Tom Tromey  <tromey@bapiya>
2530
2531         * valprint.c: Replace "the the" with "the".
2532         * symtab.c: Replace "the the" with "the".
2533         * solib.c: Replace "the the" with "the".
2534         * solib-dsbt.c: Replace "the the" with "the".
2535         * linespec.c: Replace "the the" with "the".
2536         * dwarf2loc.h: Replace "the the" with "the".
2537         * amd64-windows-tdep.c: Replace "the the" with "the".
2538         * aarch64-tdep.c: Replace "the the" with "the".
2539
2540 2019-01-16  Keith Seitz  <keiths@redhat.com>
2541
2542         PR gdb/23773
2543         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2544         <builder>: Rename to ..
2545         <m_builder>: ... this and make private.
2546         (dwarf2_cu::get_builder): New method.  Change all users of
2547         `builder' to use this method.
2548         (dwarf2_start_symtab): Move to ...
2549         (dwarf2_cu::start_symtab): ... here.  Update all callers
2550         (setup_type_unit_groups): Move to ...
2551         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2552         callers.
2553         (dwarf2_cu::reset_builder): New method.
2554         (process_full_compunit, process_full_type_unit): Use
2555         dwarf2_cu::reset_builder.
2556         (follow_die_offset): Record the ancestor CU if it is different
2557         from the followed DIE's CU.
2558         (follow_die_sig_1): Likewise.
2559
2560 2019-01-15  Tom Tromey  <tom@tromey.com>
2561
2562         * remote.c (class remote_state) <buf>: Now a char_vector.
2563         <buf_size>: Remove.
2564         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2565         parameter.
2566         (remote_target::getpkt_or_notif_sane_1)
2567         (remote_target::getpkt_sane)
2568         (remote_target::getpkt_or_notif_sane): Likewise.
2569         (class remote_target) <putpkt>: New overload.
2570         (remote_target::read_frame): Change type of "buf_p".  Remove
2571         sizeof_p parameter.
2572         (packet_ok): New overload.
2573         (packet_check_result): New overload.
2574         Update all uses.
2575
2576 2019-01-14  Tom Tromey  <tom@tromey.com>
2577
2578         * remote-notif.c (handle_notification, remote_notif_ack)
2579         (remote_notif_parse): Make "buf" const.
2580         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2581         const.
2582         (remote_notif_parse, remote_notif_ack, handle_notification):
2583         Likewise.
2584         * remote.c (remote_notif_stop_parse): Make "buf" const.
2585         (remote_target::remote_parse_stop_reply): Make "buf" const.
2586         (remote_notif_stop_ack): Make "buf" const.
2587
2588 2019-01-14  Tom Tromey  <tom@tromey.com>
2589
2590         * remote.c (remote_console_output): Make parameter const.
2591
2592 2019-01-14  Tom Tromey  <tom@tromey.com>
2593
2594         * target-debug.h (target_debug_print_signals): Constify.
2595         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2596         * procfs.c (procfs_target::pass_signals): Update.
2597         * linux-nat.c (linux_nat_target::pass_signals): Update.
2598         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2599         * target-delegates.c: Rebuild.
2600         * remote.c (remote_target::program_signals): Update.
2601         (remote_target::pass_signals): Update.
2602         * target.c (target_pass_signals): Constify argument.
2603         (target_program_signals): Likewise.
2604         * target.h (struct target_ops) <pass_signals, program_signals>:
2605         Constify argument.
2606         (target_pass_signals, target_program_signals): Constify argument.
2607
2608 2019-01-14  Tom Tromey  <tom@tromey.com>
2609
2610         PR tui/28819:
2611         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2612
2613 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2614
2615         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2616         field.
2617         * rs6000-tdep.c: Include reggroups.h.
2618         (IS_V_ALIAS_PSEUDOREG): Define.
2619         (rs6000_register_name): Return names for the "vX" aliases.
2620         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2621         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2622         aliases.  Call default_register_reggroup_p for all other
2623         pseudo-registers.
2624         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2625         New functions.
2626         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2627         Handle "vX" aliases.
2628         (v_alias_pseudo_register_collect): New function.
2629         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2630         (rs6000_gdbarch_init): Initialize "vX" aliases as
2631         pseudo-registers.  Restore registration of
2632         rs6000_pseudo_register_reggroup_p with
2633         set_tdesc_pseudo_register_reggroup_p.
2634
2635 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2636
2637         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2638         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2639         set_gdbarch_num_pseudo_regs.
2640
2641 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2642
2643         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2644         Remove arg prefixname, add do_set and do_show.
2645         Add member functions set_list and show_list.
2646         * cli/cli-style.c (class cli_style_option): Update accordingly.
2647         (style_set_list): Move to file scope.
2648         (style_show_list): Likewise.
2649         (set_style): Call help_list.
2650         (show_style): Call cmd_show_list.
2651         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2652         Update to use the new macro.
2653
2654 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2655
2656         * ada-lang.c (_initialize_ada_language): Expand the help text
2657         for the "catch exception" command.
2658
2659 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2660
2661         * symtab.c (matching_obj_sections): Initialize obj,
2662         declare it closer to its usage.
2663
2664 2019-01-10  Tom Tromey  <tom@tromey.com>
2665
2666         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2667         (basic_inf_threads_range): Remove.
2668         (inf_threads_range, inf_non_exited_threads_range)
2669         (safe_inf_threads_range): Use next_adapter.
2670
2671 2019-01-10  Keith Seitz  <keiths@redhat.com>
2672
2673         PR gdb/23712
2674         PR symtab/23010
2675         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2676         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2677
2678 2019-01-10  Keith Seitz  <keiths@redhat.com>
2679
2680         PR gdb/23712
2681         PR symtab/23010
2682         * dictionary.c (pending_to_vector): Remove.
2683         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2684         Remove _1 suffix, replacing functions of the same name.  Update
2685         all callers.
2686         (dict_create_hashed, dict_create_hashed_expandable)
2687         (dict_create_linear, dict_create_linear_expandable, dict_free)
2688         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2689         Make functions static.
2690
2691 2019-01-10  Keith Seitz  <keiths@redhat.com>
2692
2693         PR gdb/23712
2694         PR symtab/23010
2695         * dictionary.h (struct dictionary): Replace declaration with
2696         multidictionary.
2697         (dict_create_hashed, dict_create_hashed_expandable)
2698         (dict_create_linear, dict_create_linear_expandable)
2699         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2700         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2701         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2702         taking multidictionary argument.
2703         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2704         * block.h (struct block) <dict>: Change to multidictionary
2705         and rename `multidict'.
2706         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2707         symmisc.c: Update all dictionary references to multidictionary.
2708
2709 2019-01-10  Keith Seitz  <keiths@redhat.com>
2710
2711         PR gdb/23712
2712         PR symtab/23010
2713         * dictionary.c: Include unordered_map.
2714         (pending_to_vector): New function.
2715         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2716         Rewrite the non-"_1" functions to take vector instead
2717         of linked list.
2718         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2719         "new" _1 versions of the same name.
2720         (multidictionary): Define.
2721         (std::hash<enum language): New definition.
2722         (collate_pending_symbols_by_language, mdict_create_hashed)
2723         (mdict_create_hashed_expandable, mdict_create_linear)
2724         (mdict_create_linear_expandable, mdict_free)
2725         (find_language_dictionary, create_new_language_dictionary)
2726         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2727         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2728         (mdict_size, mdict_empty): New functions.
2729         * dictionary.h (mdict_iterator): Define.
2730
2731 2019-01-10  Pedro Alves  <palves@redhat.com>
2732
2733         * breakpoint.c (read_uploaded_action)
2734         (create_tracepoint_from_upload): Adjust to use
2735         gdb::unique_xmalloc_ptr.
2736         * ctf.c (ctf_write_uploaded_tp):
2737         (SET_ARRAY_FIELD): Use emplace_back.
2738         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2739         * tracefile-tfile.c (tfile_write_uploaded_tp):
2740         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2741         gdb::unique_xmalloc_ptr.
2742         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2743         at_string, cond_string, cmd_strings>: Replace char pointers
2744         with gdb::unique_xmalloc_ptr.
2745
2746 2019-01-10  Pedro Alves  <palves@redhat.com>
2747
2748         * solib-target.c (library_list_start_library): Don't xstrdup name.
2749
2750 2019-01-10  Pedro Alves  <palves@redhat.com>
2751
2752         * mdebugread.c (parse_partial_symbols): Use
2753         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2754
2755 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2756
2757         * linux-fork.c (scoped_switch_fork_info)
2758         <~scoped_switch_fork_info>: Fix incorrect variable name.
2759
2760 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2761
2762         * linux-fork.c (scoped_switch_fork_info)
2763         <scoped_switch_fork_info>: Make explicit.
2764         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2765
2766 2019-01-10  Tom Tromey  <tom@tromey.com>
2767
2768         * objfiles.h (objfile::reset_psymtabs): Update.
2769         * objfiles.c (objfile::objfile): Update.
2770         * psymtab.h (psymtab_storage::obstack): Update.
2771         (psymtab_storage::m_obstack): Use gdb::optional.
2772         (class psymtab_storage): Update comment.  Remove objfile
2773         parameter.
2774         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2775
2776 2019-01-10  Tom Tromey  <tom@tromey.com>
2777
2778         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2779         <free_psymtabs>: Now private.
2780         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2781         (allocate_psymtab): Use new method.
2782
2783 2019-01-10  Tom Tromey  <tom@tromey.com>
2784
2785         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2786         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2787         * mdebugread.c (parse_partial_symbols): Use
2788         allocate_dependencies.
2789         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2790         allocate_dependencies.
2791         (process_psymtab_comp_unit_reader)
2792         (build_type_psymtab_dependencies): Likewise.
2793         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2794
2795 2019-01-10  Tom Tromey  <tom@tromey.com>
2796
2797         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2798         PSYMBOL_SET_LANGUAGE.
2799         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2800
2801 2019-01-10  Tom Tromey  <tom@tromey.com>
2802
2803         * psymtab.h (psymtab_storage::obstack): New method.
2804         <m_obstack>: Rename from obstack; now private.
2805         * psymtab.c (psymtab_storage): Update.
2806         * dwarf2read.c (create_addrmap_from_index)
2807         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2808         Update.
2809
2810 2019-01-10  Tom Tromey  <tom@tromey.com>
2811
2812         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2813         * objfiles.h (objfile::reset_psymtabs): New method.
2814
2815 2019-01-10  Tom Tromey  <tom@tromey.com>
2816
2817         * symmisc.c (print_symbol_bcache_statistics): Update.
2818         (print_objfile_statistics): Update.
2819         * symfile.c (reread_symbols): Update.
2820         * psymtab.h (class psymtab_storage): New.
2821         * psymtab.c (psymtab_storage): New constructor.
2822         (~psymtab_storage): New destructor.
2823         (require_partial_symbols): Update.
2824         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2825         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2826         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2827         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2828         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2829         (start_psymtab_common, end_psymtab_common)
2830         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2831         (allocate_psymtab): Update.
2832         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2833         Update.
2834         (dump_psymtab_addrmap, maintenance_print_psymbols)
2835         (maintenance_check_psymtabs): Update.
2836         (class objfile_psymtabs): Move to objfiles.h.
2837         * psympriv.h (discard_psymtab): Now inline.
2838         (psymtab_discarder::psymtab_discarder): Update.
2839         (psymtab_discarder::~psymtab_discarder): Update.
2840         (ALL_OBJFILE_PSYMTABS): Rewrite.
2841         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2842         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2843         Remove fields.
2844         <partial_symtabs>: New field.
2845         (class objfile_psymtabs): Move from psymtab.h.  Update.
2846         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2847         psymbol_cache.
2848         (objfile::~objfile): Don't destroy psymbol_cache.
2849         * mdebugread.c (parse_partial_symbols): Update.
2850         * dwarf2read.c (create_addrmap_from_index)
2851         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2852         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2853         (add_partial_subprogram, dwarf2_ranges_read): Update.
2854         * dwarf-index-write.c (write_address_map)
2855         (write_one_signatured_type, recursively_write_psymbols)
2856         (class debug_names, class debug_names, write_psymtabs_to_index):
2857         Update.
2858
2859 2019-01-10  Tom Tromey  <tom@tromey.com>
2860
2861         * symtab.h (SYMBOL_SET_NAMES): Update.
2862         (symbol_set_names): Update.
2863         (MSYMBOL_SET_NAMES): Update.
2864         * symtab.c (symbol_set_names): Change argument to be an
2865         objfile_per_bfd_storage.
2866         * psymtab.c (add_psymbol_to_bcache): Update.
2867         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2868
2869 2019-01-10  Tom Tromey  <tom@tromey.com>
2870
2871         * symtab.c (create_demangled_names_hash): Change argument to be an
2872         objfile_per_bfd_storage.
2873         (symbol_set_names): Update.
2874
2875 2019-01-10  Tom Tromey  <tom@tromey.com>
2876
2877         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2878         init_psymbol_list.
2879         * psymtab.c (init_psymbol_list): Do nothing if already called.
2880         * psympriv.h (init_psymbol_list): Add comment.
2881         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2882         init_psymbol_list.
2883         * dbxread.c (dbx_symfile_read): Unconditionally call
2884         init_psymbol_list.
2885
2886 2019-01-10  Tom Tromey  <tom@tromey.com>
2887
2888         * xcoffread.c (scan_xcoff_symtab): Update.
2889         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2890         "where".
2891         * mdebugread.c (parse_partial_symbols)
2892         (handle_psymbol_enumerators): Update.
2893         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2894         * dbxread.c (read_dbx_symtab): Update.
2895         * psympriv.h (psymbol_placement): New enum.
2896         (add_psymbol_to_list): Update.
2897
2898 2019-01-10  Tom Tromey  <tom@tromey.com>
2899
2900         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2901         static_psymbols parameters.
2902         (scan_xcoff_symtab): Update.
2903         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2904         static_psymbols parameters.
2905         * psympriv.h (start_psymtab_common): Update.
2906         * mdebugread.c (parse_partial_symbols): Update.
2907         * dwarf2read.c (create_partial_symtab): Update.
2908         * dbxread.c (read_dbx_symtab): Update.
2909         (start_psymtab): Remove global_psymbols and static_psymbols
2910         parameters.
2911
2912 2019-01-10  Tom Tromey  <tom@tromey.com>
2913
2914         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2915         * psymtab.c (allocate_psymtab): Add comment.
2916         * psympriv.h (allocate_psymtab): Add comment.
2917         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2918         initializations.
2919         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2920
2921 2019-01-10  Tom Tromey  <tom@tromey.com>
2922
2923         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2924         Don't declare.
2925         * mipsread.c: Include mdebugread.h.
2926         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2927         Declare.
2928         * elfread.c: Include mdebugread.h.
2929
2930 2019-01-09  Tom Tromey  <tom@tromey.com>
2931
2932         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2933         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2934         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2935         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2936         (psym_lookup_symbol, psym_find_last_source_symtab)
2937         (psym_forget_cached_source_info, psym_print_stats)
2938         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2939         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2940         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2941         (psym_find_compunit_symtab_by_address)
2942         (maintenance_print_psymbols, maintenance_info_psymtabs)
2943         (maintenance_check_psymtabs): Use ranged for.
2944         * psymtab.h (class objfile_psymtabs): New.
2945         (require_partial_symbols): Return objfile_psymtabs.
2946         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2947
2948 2019-01-09  Tom Tromey  <tom@tromey.com>
2949
2950         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2951         (find_pc_mapped_section, list_overlays_command)
2952         (map_overlay_command, unmap_overlay_command)
2953         (simple_overlay_update): Use all_objfiles.
2954         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2955         * printcmd.c (info_symbol_command): Use all_objfiles.
2956         * objfiles.h (ALL_OBJSECTIONS): Remove.
2957         * maint.c (maintenance_translate_address): Use all_objfiles.
2958         * gcore.c (gcore_create_callback): Use all_objfiles.
2959         (objfile_find_memory_regions): Likewise.
2960
2961 2019-01-09  Tom Tromey  <tom@tromey.com>
2962
2963         * symtab.c (find_line_symtab, info_sources_command)
2964         (make_source_files_completion_list): Use objfile_compunits.
2965         * source.c (select_source_symtab): Use objfile_compunits.
2966         * objfiles.h (struct objfile): Update comment.
2967         (ALL_OBJFILES): Remove.
2968         (ALL_FILETABS): Remove.
2969         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2970         objfile_compunits.
2971
2972 2019-01-09  Tom Tromey  <tom@tromey.com>
2973
2974         * symmisc.c (print_objfile_statistics, dump_objfile)
2975         (maintenance_print_symbols): Use compunit_filetabs.
2976         * source.c (forget_cached_source_info_for_objfile): Use
2977         compunit_filetabs.
2978         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2979         (ALL_FILETABS): Use compunit_filetabs.
2980         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2981         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2982
2983 2019-01-09  Tom Tromey  <tom@tromey.com>
2984
2985         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2986         (compunit_filetabs): New.
2987         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2988         compunit_filetabs.
2989         (info_sources_command, make_source_files_completion_list): Remove
2990         declaration.
2991         * symmisc.c (print_objfile_statistics, dump_objfile)
2992         (maintenance_print_symbols): Remove declaration.
2993         (maintenance_info_symtabs): Use compunit_filetabs.
2994         (maintenance_info_line_tables): Likewise.
2995         * source.c (select_source_symtab): Change local variable name.
2996         (forget_cached_source_info_for_objfile): Remove declaration.
2997         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2998         * objfiles.c (objfile_relocate1): Remove declaration.
2999         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3000         declaration.
3001         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3002         * coffread.c (coff_symtab_read): Remove declaration.
3003         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3004         compunit_filetabs.
3005
3006 2019-01-09  Tom Tromey  <tom@tromey.com>
3007
3008         * symtab.c (lookup_objfile_from_block)
3009         (find_pc_sect_compunit_symtab, search_symbols)
3010         (default_collect_symbol_completion_matches_break_on): Use
3011         objfile_compunits.
3012         * objfiles.h (ALL_COMPUNITS): Remove.
3013         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3014         * cp-support.c (add_symbol_overload_list_qualified): Use
3015         objfile_compunits.
3016         * ada-lang.c (ada_collect_symbol_completion_matches)
3017         (ada_add_global_exceptions): Use objfile_compunits.
3018
3019 2019-01-09  Tom Tromey  <tom@tromey.com>
3020
3021         * source.c (select_source_symtab)
3022         (forget_cached_source_info_for_objfile): Remove declaration.
3023         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3024         declaration.
3025         * maint.c (count_symtabs_and_blocks): Remove declaration.
3026         * cp-support.c (add_symbol_overload_list_qualified): Remove
3027         declaration.
3028         * coffread.c (coff_symtab_read): Remove declaration.
3029         * symtab.c (lookup_symbol_in_objfile_symtabs)
3030         (basic_lookup_transparent_type_1): Use objfile_compunits.
3031         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3032         (info_sources_command, search_symbols)
3033         (default_collect_symbol_completion_matches_break_on)
3034         (make_source_files_completion_list): Remove declaration.
3035         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3036         (ada_collect_symbol_completion_matches)
3037         (ada_add_global_exceptions): Remove declaration.
3038         * linespec.c (iterate_over_all_matching_symtabs): Use
3039         objfile_compunits.
3040         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3041         (class objfile_compunits): New.
3042         (ALL_COMPUNITS): Use objfile_compunits.
3043         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3044         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3045         objfile_compunits.
3046         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3047
3048 2019-01-09  Tom Tromey  <tom@tromey.com>
3049
3050         * symtab.c (search_symbols)
3051         (default_collect_symbol_completion_matches_break_on): Use
3052         objfile_msymbols.
3053         * ada-lang.c (ada_lookup_simple_minsym)
3054         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3055         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3056         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3057         objfile_msymbols.
3058         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3059         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3060         * objc-lang.c (find_methods): Use objfile_msymbols.
3061         (info_selectors_command, info_classes_command): Likewise.
3062         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3063         * objfiles.h (class objfile_msymbols): New.
3064         (ALL_OBJFILE_MSYMBOLS): Remove.
3065         (ALL_MSYMBOLS): Remove.
3066
3067 2019-01-09  Tom Tromey  <tom@tromey.com>
3068
3069         * common/next-iterator.h (next_adapter): Add Iterator template
3070         parameter.
3071         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3072         (class all_objfiles_safe): New.
3073         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3074         * objfiles.c (put_objfile_before): Update comment.
3075         (add_separate_debug_objfile): Likewise.
3076         (free_all_objfiles): Use all_objfiles_safe.
3077         (objfile_purge_solibs): Likewise.
3078
3079 2019-01-09  Tom Tromey  <tom@tromey.com>
3080
3081         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3082         (expand_symtab_containing_pc, lookup_static_symbol)
3083         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3084         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3085         all_objfiles.
3086         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3087         * breakpoint.c (create_overlay_event_breakpoint)
3088         (create_longjmp_master_breakpoint)
3089         (create_std_terminate_master_breakpoint)
3090         (create_exception_master_breakpoint): Use all_objfiles.
3091         * linux-thread-db.c (try_thread_db_load_from_pdir)
3092         (has_libpthread): Use all_objfiles.
3093         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3094         * linespec.c (iterate_over_all_matching_symtabs)
3095         (search_minsyms_for_name): Use all_objfiles.
3096         * maint.c (maintenance_info_sections): Use all_objfiles.
3097         * main.c (captured_main_1): Use all_objfiles.
3098         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3099         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3100         * guile/scm-pretty-print.c
3101         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3102         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3103         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3104         (maintenance_print_msymbols): Use all_objfiles.
3105         * source.c (select_source_symtab): Use all_objfiles.
3106         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3107         * symfile.c (remove_symbol_file_command)
3108         (expand_symtabs_matching, map_symbol_filenames): Use
3109         all_objfiles.
3110         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3111         all_objfiles.
3112         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3113         * objc-lang.c (find_methods): Use all_objfiles.
3114         * objfiles.c (have_partial_symbols, have_full_symbols)
3115         (have_minimal_symbols, qsort_cmp)
3116         (default_iterate_over_objfiles_in_search_order): Use
3117         all_objfiles.
3118         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3119         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3120         (maintenance_check_psymtabs): Use all_objfiles.
3121         (ALL_PSYMTABS): Remove.
3122         * compile/compile-object-run.c (do_module_cleanup): Use
3123         all_objfiles.
3124         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3125         * cp-support.c (add_symbol_overload_list_qualified): Use
3126         all_objfiles.
3127         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3128         Use all_objfiles.
3129         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3130         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3131         all_objfiles.
3132         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3133         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3134         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3135         Uses all_objfiles.
3136         * solib.c (solib_read_symbols): Use all_objfiles
3137
3138 2019-01-09  Tom Tromey  <tom@tromey.com>
3139
3140         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3141         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3142         all_objfiles.
3143         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3144         * symmisc.c (print_symbol_bcache_statistics)
3145         (print_objfile_statistics, maintenance_print_objfiles)
3146         (maintenance_info_symtabs, maintenance_check_symtabs)
3147         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3148         all_objfiles.
3149         * source.c (forget_cached_source_info): Use all_objfiles.
3150         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3151         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3152         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3153         * objfiles.c (update_section_map): Use all_objfiles.
3154         (shared_objfile_contains_address_p): Likewise.
3155         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3156         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3157
3158 2019-01-09  Tom Tromey  <tom@tromey.com>
3159
3160         * common/next-iterator.h: New file.
3161         * objfiles.h (class all_objfiles): New.
3162         (struct objfile_iterator): New.
3163
3164 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3165
3166         * NEWS: Move the description of the changed "frame", "select-frame",
3167          and "info frame" commands to the Changed commands section.
3168
3169 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3170
3171         * gdbtypes.c (check_stub_method_group): Remove handling of old
3172         mangling schemes.
3173         * linespec.c (find_methods): Likewise.
3174         * stabsread.c (read_member_functions): Likewise.
3175         * valops.c (search_struct_method): Likewise.
3176         (value_struct_elt_for_reference): Likewise.
3177         * NEWS: Mention this change.
3178
3179 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3180
3181         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3182         print_source_lines.
3183         * source.c (print_source_lines_base): Update line number check.
3184         (print_source_lines): New function.
3185         (source_lines_range::source_lines_range): New function.
3186         * source.h (class source_lines_range): New class.
3187         (print_source_lines): New declaration.
3188
3189 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3190
3191         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3192
3193 2019-01-08  Tom Tromey  <tom@tromey.com>
3194             Simon Marchi  <simon.marchi@ericsson.com>
3195
3196         PR gdb/24060
3197         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3198         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3199         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3200         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3201         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3202         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3203
3204 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3205
3206         * source.c (select_source_symtab): Move header comment to
3207         declaration in source.h.
3208         (forget_cached_source_info_for_objfile): Likewise.
3209         (forget_cached_source_info): Likewise.
3210         (identify_source_line): Likewise.
3211         * source.h (identify_source_line): Move declaration from symtab.h
3212         and add comment from source.c
3213         (print_source_lines): Likewise.
3214         (forget_cached_source_info_for_objfile): Likewise.
3215         (forget_cached_source_info): Likewise.
3216         (select_source_symtab): Likewise.
3217         (enum print_source_lines_flag): Move definition from symtab.h.
3218         * symtab.h (identify_source_line): Move declaration to source.h.
3219         (print_source_lines): Likewise.
3220         (forget_cached_source_info_for_objfile): Likewise.
3221         (forget_cached_source_info): Likewise.
3222         (select_source_symtab): Likewise.
3223         (enum print_source_lines_flag): Move definition to source.h.
3224         * tui/tui-hooks.c: Add 'source.h' include.
3225
3226 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3227
3228         * source.c (print_source_lines_base): Handle requests to print
3229         reverse line number sequences, and guard against empty lines
3230         string.
3231
3232 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3233
3234         * source.c (print_source_lines_base): Fix skip of '\r' if next
3235         character is '\n'.
3236
3237 2019-01-06  Tom Tromey  <tom@tromey.com>
3238
3239         * c-exp.y (struct c_parse_state) <macro_original_text,
3240         expansion_obstack>: New member.
3241         (macro_original_text, expansion_obstack): Remove globals.
3242         (scan_macro_expansion, scanning_macro_expansion)
3243         (finished_macro_expansion): Update.
3244         (scan_macro_cleanup): Remove.
3245         (yylex, c_parse): Update.
3246
3247 2019-01-06  Tom Tromey  <tom@tromey.com>
3248
3249         * c-exp.y (struct c_parse_state) <strings>: New member.
3250         (operator_stoken): Update.
3251
3252 2019-01-06  Tom Tromey  <tom@tromey.com>
3253
3254         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3255         (union type_stack_elt) <typelist_val>: Now a pointer to
3256         std::vector.
3257         (type_stack_cleanup): Don't declare.
3258         (push_typelist): Update.
3259         * parse.c (pop_typelist): Return a std::vector.
3260         (push_typelist): Take a std::vector.
3261         (follow_types): Update.  Do not free args.
3262         (type_stack_cleanup): Remove.
3263         * c-exp.y (struct c_parse_state): New.
3264         (cpstate): New global.
3265         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3266         (nonempty_typelist): Update.
3267         (func_mod): Create a new vector.
3268         (c_parse): Create a c_parse_state.
3269         (check_parameter_typelist): Do not delete params.
3270         (function_method): Update.  Do not delete type_list.
3271
3272 2019-01-06  Tom Tromey  <tom@tromey.com>
3273
3274         PR gdb/28155:
3275         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3276         check_typedef.
3277         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3278         (print_return_value): Likewise.
3279
3280 2019-01-05  Tom Tromey  <tom@tromey.com>
3281
3282         * contrib/cleanup_check.py: Remove.
3283         * contrib/gcc-with-excheck: Remove.
3284         * contrib/exsummary.py: Remove.
3285         * contrib/excheck.py: Remove.
3286
3287 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3288
3289         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3290         NULL. Initialize tpprev to NULL instead of assigning it
3291         to NULL on the next statement.
3292         * windows-nat.c (windows_delete_thread): Remove check for
3293         main_thread_id before printing thread exit notifications.
3294         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3295         Remove thread ID check against main_thread_id.
3296         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3297         windows_delete_thread.
3298         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3299
3300 2019-01-04  Tom Tromey  <tom@tromey.com>
3301
3302         * compile/compile.c (_initialize_compile): Use upper case for
3303         metasyntactic variables.
3304         * symmisc.c (_initialize_symmisc): Use upper case for
3305         metasyntactic variables.
3306         * psymtab.c (_initialize_psymtab): Use upper case for
3307         metasyntactic variables.
3308         * demangle.c (demangle_command): Use upper case for metasyntactic
3309         variables.
3310         (_initialize_demangler): Likewise.
3311         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3312         variables.
3313
3314 2019-01-03  Tom Tromey  <tom@tromey.com>
3315
3316         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3317
3318 2019-01-03  Tom Tromey  <tom@tromey.com>
3319
3320         * python/py-symtab.c (salpy_str): Update.
3321         (struct salpy_sal_object) <symtab>: Now a PyObject.
3322         (salpy_dealloc): Update.
3323         (del_objfile_sal): Use gdbpy_ref.
3324
3325 2019-01-03  Tom Tromey  <tom@tromey.com>
3326
3327         * python/py-type.c (convert_field): Use new_reference.  Return
3328         gdbpy_ref.
3329         (make_fielditem): Return gdbpy_ref.
3330         (typy_fields): Update.
3331         (typy_getitem): Update.
3332         (field_name): Return gdbpy_ref.  Use new_reference.
3333         (typy_iterator_iternext): Update.
3334
3335 2019-01-03  Tom Tromey  <tom@tromey.com>
3336
3337         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3338
3339 2019-01-03  Tom Tromey  <tom@tromey.com>
3340
3341         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3342         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3343         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3344         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3345         (pspy_set_type_printers): Likewise.
3346         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3347         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3348         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3349         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3350         (objfpy_set_type_printers): Likewise.
3351
3352 2019-01-03  Tom Tromey  <tom@tromey.com>
3353
3354         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3355         (gdbpy_print_stack): Use gdbpy_err_fetch.
3356         * python/python-internal.h (class gdbpy_err_fetch): New class.
3357         (class gdbpy_enter) <m_error_type, m_error_value,
3358         m_error_traceback>: Remove.
3359         <m_error>: New member.
3360         (gdbpy_exception_to_string): Don't declare.
3361         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3362         * python/py-value.c (convert_value_from_python): Use
3363         gdbpy_err_fetch.
3364         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3365         gdbpy_exception_to_string.
3366         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3367         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3368         gdbpy_err_fetch.
3369
3370 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3371
3372         * linux-nat.c (delete_lwp_cleanup): Delete.
3373         (struct lwp_deleter): New struct.
3374         (lwp_info_up): New typedef.
3375         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3376         lwp_info_up.
3377
3378 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3379
3380         * linux-fork.c (class scoped_switch_fork_info): New class.
3381         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3382
3383 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3384
3385         * valops.c (find_overload_match): Remove use of null_cleanup, and
3386         calls to do_cleanups.
3387
3388 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3389
3390         * compile/compile-cplus-types.c
3391         (compile_cplus_instance::decl_name): Handle changes to
3392         cp_func_name.
3393         * cp-support.c (cp_func_name): Update header comment, update
3394         return type.
3395         * cp-support.h (cp_func_name): Update return type in declaration.
3396         * valops.c (find_overload_match): Move temp_func local to top
3397         level of function and change its type.  Use temp_func to hold and
3398         delete temporary string obtained from cp_func_name.
3399
3400 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3401
3402         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3403         gdb::char_vector, remove cleanup, and update uses of `msg`.
3404
3405 2019-01-03  Jim Wilson  <jimw@sifive.com>
3406
3407         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3408
3409 2019-01-02  Tom Tromey  <tom@tromey.com>
3410
3411         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3412         (tdesc_parse_xml): Remove cleanups.
3413         * target-descriptions.h (make_cleanup_free_target_description):
3414         Don't declare.
3415         (target_desc_deleter): New struct.
3416         (target_desc_up): New typedef.
3417         * target-descriptions.c (target_desc_deleter::operator()): Rename
3418         from free_target_description.
3419         (make_cleanup_free_target_description): Remove.
3420
3421 2019-01-02  Tom Tromey  <tom@tromey.com>
3422
3423         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3424         constructor, destructor.
3425         (linespec_parser): Remove typedef.
3426         (~linespec_parser): Rename from linespec_parser_delete.
3427         (linespec_lex_to_end, linespec_complete_label)
3428         (linespec_complete): Update.
3429         (decode_line_full): Remove cleanups.
3430         (decode_line_1): Update.
3431
3432 2019-01-02  Tom Tromey  <tom@tromey.com>
3433
3434         * python/python-internal.h (inferior_to_inferior_object): Change
3435         return type.
3436         * python/py-exitedevent.c (create_exited_event_object): Update.
3437         * python/py-inferior.c (inferior_to_inferior_object): Return
3438         gdbpy_ref.
3439         (python_new_inferior, python_inferior_deleted)
3440         (thread_to_thread_object, delete_thread_object)
3441         (build_inferior_list, gdbpy_selected_inferior): Update.
3442         * python/py-infthread.c (create_thread_object): Update.  Also fail
3443         if inferior_to_inferior_object fails.
3444
3445 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3446
3447         * inferior.h (class inferior) <displaced_step_state>: New field.
3448         * infrun.h (struct displaced_step_state): Move here from
3449         infrun.c.  Initialize fields, add constructor.
3450         <inf>: Remove field.
3451         <reset>: New method.
3452         * infrun.c (struct displaced_step_inferior_state): Move to
3453         infrun.h.
3454         (displaced_step_inferior_states): Remove.
3455         (get_displaced_stepping_state): Adust.
3456         (displaced_step_in_progress_any_inferior): Adjust.
3457         (displaced_step_in_progress_thread): Adjust.
3458         (displaced_step_in_progress): Adjust.
3459         (add_displaced_stepping_state): Remove.
3460         (get_displaced_step_closure_by_addr): Adjust.
3461         (remove_displaced_stepping_state): Remove.
3462         (infrun_inferior_exit): Call displaced_step_state.reset.
3463         (use_displaced_stepping): Don't check for NULL.
3464         (displaced_step_prepare_throw): Call
3465         get_displaced_stepping_state.
3466         (displaced_step_fixup): Don't check for NULL.
3467         (prepare_for_detach): Don't check for NULL.
3468
3469 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3470
3471         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3472          in case of call that did not complete.
3473
3474 2019-01-02  Andrey Utkin  <autkin@undo.io>
3475
3476         * symfile.c (find_separate_debug_file): Fix search of debug files for
3477         remote debuggee.
3478
3479 2019-01-02  Tom Tromey  <tom@tromey.com>
3480
3481         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3482         indentation.
3483         * python/py-frame.c (frapy_older): Remove cast.
3484         (frapy_newer): Likewise.
3485         * python/py-breakpoint.c (local_setattro): Remove cast.
3486         * python/py-arch.c (archpy_name): Remove local variable.
3487         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3488
3489 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3490
3491         * unittests/basic_string_view/element_access/char/empty.cc:
3492         Fix year range in copyright header.
3493
3494 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3495
3496         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3497         Delete.
3498         <operator==>: Update with for removed field.
3499         <hash>: Likewise.
3500         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3501         <isa_features>: ...this.
3502         <abi_features>: New field.
3503         (riscv_isa_flen): Update comment.
3504         (riscv_abi_xlen): New declaration.
3505         (riscv_abi_flen): New declaration.
3506         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3507         isa_features.
3508         (riscv_abi_xlen): New function.
3509         (riscv_isa_flen): Update to get answer from isa_features.
3510         (riscv_abi_flen): New function.
3511         (riscv_has_fp_abi): Update to get answer from abi_features.
3512         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3513         xlen and flen.
3514         (riscv_call_info) <xlen, flen>: Update comment.
3515         (riscv_call_arg_struct): Remove invalid assertions
3516         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3517         is removed.
3518         (riscv_gdbarch_init): Gather isa features and abi features
3519         separately, ensure both match on the gdbarch when reusing an old
3520         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3521         a target with 64-bit float hardware.
3522
3523 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3524
3525         * source.c (search_command_helper): Stop reverse search
3526         when line 1 has been searched.
3527
3528 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3529
3530         * record-full.c (record_full_base_target::close): Rewrite
3531         record_full_core_buf_list free logic.
3532
3533 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3534
3535         * break-catch-syscall.c (print_one_catch_syscall): xfree
3536         the last text.
3537
3538 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3539
3540         * top.c (print_gdb_version): Update Copyright year in version
3541         message.
3542
3543 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3544
3545         Update copyright year range in all GDB files.
3546
3547 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3548
3549         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3550
3551 For older changes see ChangeLog-2018.
3552 \f
3553 Local Variables:
3554 mode: change-log
3555 left-margin: 8
3556 fill-column: 74
3557 version-control: never
3558 coding: utf-8
3559 End:
3560