gdb/ChangeLog

   1 2020-07-30  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
   2
   3         * breakpoint.c (set_breakpoint_condition): Update the
   4         condition string after parsing the new condition successfully.
   5
   6 2020-07-30  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
   7
   8         * proc-api.c (_STRUCTURED_PROC): Don't define.
   9         * proc-events.c: Likewise.
  10         * proc-flags.c: Likewise.
  11         * proc-why.c: Likewise.
  12         * procfs.c: Likewise.
  13
  14         * Makefile.in (INTERNAL_CPPFLAGS): Add LARGEFILE_CPPFLAGS.
  15         * configure, config.in: Regenerate.
  16
  17 2020-07-30  Tom de Vries  <tdevries@suse.de>
  18
  19         PR build/26320
  20         * ui-style.h (struct ui_file_style::color): Wrap m_value and
  21         m_red/m_green/m_blue in a union.
  22
  23 2020-07-29  Tom de Vries  <tdevries@suse.de>
  24
  25         PR tdep/26280
  26         * s390-tdep.c (s390_displaced_step_fixup): Fix Wmaybe-uninitialized.
  27
  28 2020-07-28  Tom Tromey  <tromey@adacore.com>
  29
  30         PR symtab/26270:
  31         * symtab.h (find_pc_partial_function_sym): Declare.
  32         * cli/cli-cmds.c (disassemble_command): Use
  33         find_pc_partial_function_sym.  Check asm_demangle.
  34         * blockframe.c (cache_pc_function_sym): New global.
  35         (cache_pc_function_name): Remove.
  36         (clear_pc_function_cache): Update.
  37         (find_pc_partial_function_sym): New function, from
  38         find_pc_partial_function.
  39         (find_pc_partial_function): Rewrite using
  40         find_pc_partial_function_sym.
  41
  42 2020-07-28  Tom Tromey  <tromey@adacore.com>
  43
  44         * cli/cli-cmds.c (_initialize_cli_cmds): Rearrange "disassemble"
  45         help.  Add usage.
  46
  47 2020-07-28  Tom Tromey  <tromey@adacore.com>
  48
  49         * dwarf2/expr.c (dwarf_expr_context::execute_stack_op)
  50         <DW_OP_GNU_variable_value>: Cast to address type.
  51
  52 2020-07-28  Kamil Rytarowski  <n54@gmx.com>
  53
  54         * nbsd-nat.h (nbsd_nat_target::xfer_partial): New declaration.
  55         * nbsd-nat.c (nbsd_nat_target::xfer_partial): New function.
  56         * nbsd-tdep.c (nbsd_gdbarch_data_handle, struct nbsd_gdbarch_data)
  57         (init_nbsd_gdbarch_data, get_nbsd_gdbarch_data)
  58         (nbsd_get_siginfo_type): New.
  59         (nbsd_init_abi): Install gdbarch "get_siginfo_type" method.
  60         (_initialize_nbsd_tdep): New.
  61
  62 2020-07-28  H.J. Lu  <hongjiu.lu@intel.com>
  63
  64         PR binutils/26301
  65         * configure: Regenerated.
  66
  67 2020-07-28  H.J. Lu  <hongjiu.lu@intel.com>
  68
  69         PR binutils/26301
  70         * configure: Regenerated.
  71
  72 2020-07-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  73
  74         * python/py-frame.c: Remove 'user-regs.h' include.
  75         (frapy_read_register): Rewrite to make use of
  76         gdbpy_parse_register_id.
  77         * python/py-registers.c (gdbpy_parse_register_id): New function,
  78         moved here from python/py-unwind.c.  Updated the return type, and
  79         also accepts register descriptor objects.
  80         * python/py-unwind.c: Remove 'user-regs.h' include.
  81         (pyuw_parse_register_id): Moved to python/py-registers.c.
  82         (unwind_infopy_add_saved_register): Update to use
  83         gdbpy_parse_register_id.
  84         (pending_framepy_read_register): Likewise.
  85         * python/python-internal.h (gdbpy_parse_register_id): Declare.
  86
  87 2020-07-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  88
  89         * python/py-registers.c: Add 'user-regs.h' include.
  90         (register_descriptor_iter_find): New function.
  91         (register_descriptor_iterator_object_methods): New static global
  92         methods array.
  93         (register_descriptor_iterator_object_type): Add pointer to methods
  94         array.
  95
  96 2020-07-27  John Baldwin  <jhb@FreeBSD.org>
  97
  98         * fbsd-nat.h: Include <osreldate.h>.  Define USE_SIGTRAP_SIGINFO
  99         for all architectures on FreeBSD 11.3 and later.
 100
 101 2020-07-27  Tom Tromey  <tromey@adacore.com>
 102
 103         * gcore.h (load_corefile): Don't declare.
 104
 105 2020-07-27  Tom de Vries  <tdevries@suse.de>
 106
 107         * configure.ac: Fix sys/sockets.h -> sys/socket.h typo.
 108         * config.in: Regenerate.
 109         * configure: Regenerate.
 110
 111 2020-07-26  Eli Zaretskii  <eliz@gnu.org>
 112
 113         * configure.ac (AC_CHECK_HEADERS): Check for sys/socket.h and
 114         ws2tcpip.h.  When checking whether socklen_t type is defined, use
 115         ws2tcpip.h if it is available and sys/socket.h isn't.
 116         * configure: Regenerate.
 117         * config.in: Regenerate.
 118
 119 2020-07-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 120
 121         PR fortran/23051
 122         PR fortran/26139
 123         * valops.c (value_ind): Pass address to
 124         readjust_indirect_value_type.
 125         * value.c (readjust_indirect_value_type): Make parameter
 126         non-const, and add extra address parameter.  Resolve original type
 127         before using it.
 128         * value.h (readjust_indirect_value_type): Update function
 129         signature and comment.
 130
 131 2020-07-25  Tom de Vries  <tdevries@suse.de>
 132
 133         PR symtab/26243
 134         * dwarf2/read.c (lnp_state_machine::record_line): Ignore zero line
 135         entries.
 136
 137 2020-07-24  Aaron Merey  <amerey@redhat.com>
 138
 139         * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS.
 140         * configure: Rebuild.
 141
 142 2020-07-23  Kevin Buettner  <kevinb@redhat.com>
 143
 144         PR corefiles/26294
 145         * corelow.c (_initialize_corelow): Add period to help text
 146         for "maintenance print core-file-backed-mappings".
 147
 148 2020-07-23  Pedro Alves  <pedro@palves.net>
 149
 150         * frame-unwind.c (frame_unwind_try_unwinder): On exception, don't
 151         touch THIS_CACHE/THIS_FRAME if the frame cache was cleared
 152         meanwhile.
 153         * frame.c (frame_cache_generation, get_frame_cache_generation):
 154         New.
 155         (reinit_frame_cache): Increment FRAME_CACHE_GENERATION.
 156         (get_prev_frame_if_no_cycle): On exception, don't touch
 157         PREV_FRAME/THIS_FRAME if the frame cache was cleared meanwhile.
 158         * frame.h (get_frame_cache_generation): Declare.
 159
 160 2020-07-23  Tom de Vries  <tdevries@suse.de>
 161
 162         PR tui/26282
 163         * tui/tui-winsource.h (struct tui_source_windows::tui_source_windows):
 164         New default constructor.
 165
 166 2020-07-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 167
 168         * disasm.c (do_mixed_source_and_assembly_deprecated): Don't
 169         exclude non-statement entries.
 170
 171 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 172
 173         * NEWS (New commands): Mention new command
 174         "maintenance print core-file-backed-mappings".
 175
 176 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 177
 178         * corelow.c (gdbcmd.h): Include.
 179         (core_target::info_proc_mappings): New method.
 180         (get_current_core_target): New function.
 181         (maintenance_print_core_file_backed_mappings): New function.
 182         (_initialize_corelow): Add core-file-backed-mappings to
 183         "maint print" commands.
 184
 185 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 186
 187         * linux-tdep.c (dump_note_entry_p): New function.
 188         (linux_dump_mapping_p_ftype): New typedef.
 189         (linux_find_memory_regions_full): Add new parameter,
 190         should_dump_mapping_p.
 191         (linux_find_memory_regions): Adjust call to
 192         linux_find_memory_regions_full.
 193         (linux_make_mappings_core_file_notes): Use dump_note_entry_p in
 194         call to linux_find_memory_regions_full.
 195
 196 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 197
 198         * corelow.c (solist.h, unordered_map): Include.
 199         (class core_target): Add field m_core_file_mappings and
 200         method build_file_mappings.
 201         (core_target::core_target): Call build_file_mappings.
 202         (core_target::~core_target): Free memory associated with
 203         m_core_file_mappings.
 204         (core_target::build_file_mappings): New method.
 205         (core_target::xfer_partial): Use m_core_file_mappings
 206         for memory transfers.
 207         * linux-tdep.c (linux_read_core_file_mappings): New
 208         function.
 209         (linux_core_info_proc_mappings): Rewrite to use
 210         linux_read_core_file_mappings.
 211         (linux_init_abi): Register linux_read_core_file_mappings.
 212
 213 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 214
 215         * arch-utils.c (default_read_core_file_mappings): New function.
 216         * arch-utils.c (default_read_core_file_mappings): Declare.
 217         * gdbarch.sh (read_core_file_mappings): New gdbarch method.
 218         * gdbarch.h, gdbarch.c: Regenerate.
 219
 220 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 221
 222         PR corefiles/25631
 223         * corelow.c (core_target:xfer_partial):  Revise
 224         TARGET_OBJECT_MEMORY case to consider non-SEC_HAS_CONTENTS
 225         case after first checking the stratum beneath the core
 226         target.
 227         (has_all_memory): Return true.
 228         * target.c (raw_memory_xfer_partial): Revise comment
 229         regarding use of has_all_memory.
 230
 231 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
 232
 233         * exec.h (section_table_xfer_memory): Revise declaration,
 234         replacing section name parameter with an optional callback
 235         predicate.
 236         * exec.c (section_table_xfer_memory): Likewise.
 237         * bfd-target.c, exec.c, target.c, corelow.c: Adjust all callers
 238         of section_table_xfer_memory.
 239
 240 2020-07-22  Tom Tromey  <tromey@adacore.com>
 241
 242         * mi/mi-cmd-stack.c (list_args_or_locals): Use
 243         lookup_symbol_search_name.
 244
 245 2020-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 246
 247         * python/py-registers.c (gdbpy_register_object_data_init): Remove
 248         redundant local variable.
 249         (gdbpy_get_register_descriptor): Extract descriptor vector as a
 250         reference, not pointer, update code accordingly.
 251
 252 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 253             Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 254
 255         * objfiles.h (struct objfile) <skip_jit_symbol_lookup>: New field.
 256         * jit.c (jit_breakpoint_re_set_internal): Use the
 257         `skip_jit_symbol_lookup` field.
 258
 259 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 260             Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 261
 262         * jit.c (jit_read_descriptor): Define the descriptor address once,
 263         use twice.
 264         (jit_breakpoint_deleted): Move the declaration of the loop variable
 265         `iter` into the loop header.
 266         (jit_breakpoint_re_set_internal): Move the declaration of the local
 267         variable `objf_data` to the first point of definition.
 268         (jit_event_handler): Move the declaration of local variables
 269         `code_entry`, `entry_addr`, and `objf` to their first point of use.
 270         Rename `objf` to `jited`.
 271
 272 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 273
 274         * jit.h (struct jiter_objfile_data) <jiter_objfile_data, objfile>:
 275         Remove.
 276         * jit.c (get_jiter_objfile_data): Update.
 277
 278 2020-07-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 279             Simon Marchi  <simon.marchi@polymtl.ca>
 280
 281         * jit.c (struct jit_program_space_data): Remove.
 282         (jit_program_space_key): Remove.
 283         (jiter_objfile_data::~jiter_objfile_data): Remove program space
 284         stuff.
 285         (get_jit_program_space_data): Remove.
 286         (jit_breakpoint_deleted): Iterate on all of the program space's
 287         objfiles.
 288         (jit_inferior_init): Likewise.
 289         (jit_breakpoint_re_set_internal): Likewise.  Also change return
 290         type to void.
 291         (jit_breakpoint_re_set): Pass current_program_space to
 292         jit_breakpoint_re_set_internal.
 293
 294 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 295
 296         * jit.h (struct jiter_objfile_data) <cached_code_address,
 297         jit_breakpoint>: Move to here from ...
 298         * jit.c (jit_program_space_data): ... here.
 299         (jiter_objfile_data::~jiter_objfile_data): Update.
 300         (jit_breakpoint_deleted): Update.
 301         (jit_breakpoint_re_set_internal): Update.
 302
 303 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 304
 305         * jit.c (jiter_objfile_data::~jiter_objfile_data): Remove some
 306         checks.
 307         (jit_read_descriptor): Remove NULL check.
 308         (jit_event_handler): Add an assertion.
 309
 310 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 311
 312         * jit.h (struct jit_objfile_data):  Split into...
 313         (struct jiter_objfile_data): ... this ...
 314         (struct jited_objfile_data): ... and this.
 315         * objfiles.h (struct objfile) <jit_data>: Remove.
 316         <jiter_data, jited_data>: New fields.
 317         * jit.c (jit_objfile_data::~jit_objfile_data): Rename to ...
 318         (jiter_objfile_data::~jiter_objfile_data): ... this.
 319         (get_jit_objfile_data): Rename to ...
 320         (get_jiter_objfile_data): ... this.
 321         (add_objfile_entry): Update.
 322         (jit_read_descriptor): Use get_jiter_objfile_data.
 323         (jit_find_objf_with_entry_addr): Use objfile's jited_data field.
 324         (jit_breakpoint_re_set_internal): Use get_jiter_objfile_data.
 325         (jit_inferior_exit_hook): Use objfile's jited_data field.
 326
 327 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
 328
 329         * jit.h: Forward-declare `struct minimal_symbol`.
 330         (struct jit_objfile_data): Migrate to here from jit.c; also add a
 331         constructor, destructor, and an objfile* field.
 332         * jit.c (jit_objfile_data): Remove.
 333         (struct jit_objfile_data): Migrate from here to jit.h.
 334         (jit_objfile_data::~jit_objfile_data): New destructor
 335         implementation with code moved from free_objfile_data.
 336         (free_objfile_data): Delete.
 337         (get_jit_objfile_data): Update to use the jit_data field of objfile.
 338         (jit_find_objf_with_entry_addr): Ditto.
 339         (jit_inferior_exit_hook): Ditto.
 340         (_initialize_jit): Remove the call to
 341         register_objfile_data_with_cleanup.
 342         * objfiles.h (struct objfile) <jit_data>: New field.
 343
 344 2020-07-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 345
 346         * jit.h: Forward-declare `struct objfile`.
 347         (jit_event_handler): Add a second parameter, the JITer objfile.
 348         * jit.c (jit_read_descriptor): Change the signature to take the
 349         JITer objfile as an argument instead of the jit_program_space_data.
 350         (jit_inferior_init): Update the call to jit_read_descriptor.
 351         (jit_event_handler): Use the new JITer objfile argument when calling
 352         jit_read_descriptor.
 353         * breakpoint.c (handle_jit_event): Update the call to
 354         jit_event_handler to pass the JITer objfile.
 355
 356 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 357
 358         * gdbarch.c: Regenerate.
 359         * gdbarch.h: Regenerate.
 360         * gdbarch.sh (handle_segmentation_fault): Remove method.
 361         * infrun.c (handle_segmentation_fault): Remove.
 362         (print_signal_received_reason): Remove call to
 363         handle_segmentation_fault.
 364
 365 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 366
 367         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 368         Rename to sparc64_linux_report_signal_info and add siggnal
 369         argument.
 370         (sparc64_linux_init_abi): Use sparc64_linux_report_signal_info
 371         instead of sparc64_linux_handle_segmentation_fault.
 372
 373 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 374
 375         * amd64-linux-tdep.c (amd64_linux_init_abi_common): Use
 376         i386_linux_report_signal_info instead of
 377         i386_linux_handle_segmentation_fault.
 378         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Rename
 379         to i386_linux_report_signal_info and add siggnal argument.
 380         (i386_linux_init_abi): Use i386_linux_report_signal_info instead
 381         of i386_linux_handle_segmentation_fault.
 382         * i386-linux-tdep.h (i386_linux_handle_segmentation_fault): Rename
 383         to i386_linux_report_signal_info and add siggnal argument.
 384
 385 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 386
 387         * corelow.c (core_target_open): Invoke gdbarch report_signal_info
 388         hook if present.
 389
 390 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
 391
 392         * gdbarch.c: Regenerate.
 393         * gdbarch.h: Regenerate.
 394         * gdbarch.sh (report_signal_info): New method.
 395         * infrun.c (print_signal_received_reason): Invoke gdbarch
 396         report_signal_info hook if present.
 397
 398 2020-07-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 399
 400         * python/py-registers.c : Add 'unordered_map' include.
 401         (gdbpy_new_reggroup): Renamed to...
 402         (gdbpy_get_reggroup): ...this.  Update to only create register
 403         group descriptors when needed.
 404         (gdbpy_reggroup_iter_next): Update.
 405
 406 2020-07-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 407
 408         * python/py-registers.c (gdbpy_register_object_data): New static
 409         global.
 410         (gdbpy_register_object_data_init): New function.
 411         (gdbpy_new_register_descriptor): Renamed to...
 412         (gdbpy_get_register_descriptor): ...this, and update to reuse
 413         existing register descriptors where possible.
 414         (gdbpy_register_descriptor_iter_next): Update.
 415         (gdbpy_initialize_registers): Register new gdbarch data.
 416
 417 2020-07-21  Simon Marchi  <simon.marchi@efficios.com>
 418
 419         * linux-nat.c (stopped_pids): Make static.
 420
 421 2020-07-21  Simon Marchi  <simon.marchi@polymtl.ca>
 422
 423         PR ada/26235
 424         * gdbtypes.c (ada_discrete_type_low_bound,
 425         ada_discrete_type_high_bound): Handle undefined bounds.
 426
 427 2020-07-21  Kamil Rytarowski  <n54@gmx.com>
 428
 429         * nbsd-nat.h (nbsd_nat_target::supports_multi_process): New
 430         declaration.
 431         * nbsd-nat.c (nbsd_nat_target::supports_multi_process): New
 432         function.
 433
 434 2020-07-20  John Baldwin  <jhb@FreeBSD.org>
 435
 436         * fbsd-tdep.c (fbsd_skip_solib_resolver): New function.
 437         (fbsd_init_abi): Install gdbarch "skip_solib_resolver" method.
 438         * fbsd-tdep.h (fbsd_skip_solib_resolver): New prototype.
 439         * mips-fbsd-tdep.c (mips_fbsd_skip_solib_resolver): New function.
 440         (mips_fbsd_init_abi): Install gdbarch "skip_solib_resolver"
 441         method.
 442
 443 2020-07-20 Ludovic Courtès  <ludo@gnu.org>
 444
 445         * guile/scm-math.c (vlscm_integer_fits_p): Use 'uintmax_t'
 446         and 'intmax_t' instead of 'scm_t_uintmax' and 'scm_t_intmax',
 447         which are deprecated in Guile 3.0.
 448         * configure.ac (try_guile_versions): Add "guile-3.0".
 449         * configure (try_guile_versions): Regenerate.
 450         * NEWS: Update entry.
 451
 452 2020-07-20  Ludovic Courtès  <ludo@gnu.org>
 453             Doug Evans  <dje@google.com>
 454
 455         PR gdb/21104
 456         * guile/scm-ports.c (USING_GUILE_BEFORE_2_2): New macro.
 457         (ioscm_memory_port)[read_buf_size, write_buf_size]: Wrap in #if
 458         USING_GUILE_BEFORE_2_2.
 459         (stdio_port_desc, memory_port_desc) [!USING_GUILE_BEFORE_2_2]:
 460         Change type to 'scm_t_port_type *'.
 461         (natural_buffer_size) [!USING_GUILE_BEFORE_2_2]: New variable.
 462         (ioscm_open_port) [USING_GUILE_BEFORE_2_2]: Add 'stream'
 463         parameter and honor it.  Update callers.
 464         (ioscm_open_port) [!USING_GUILE_BEFORE_2_2]: New function.
 465         (ioscm_read_from_port, ioscm_write) [!USING_GUILE_BEFORE_2_2]: New
 466         functions.
 467         (ioscm_fill_input, ioscm_input_waiting, ioscm_flush): Wrap in #if
 468         USING_GUILE_BEFORE_2_2.
 469         (ioscm_init_gdb_stdio_port) [!USING_GUILE_BEFORE_2_2]: Use
 470         'ioscm_read_from_port'.  Call 'scm_set_port_read_wait_fd'.
 471         (ioscm_init_stdio_buffers) [!USING_GUILE_BEFORE_2_2]: New function.
 472         (gdbscm_stdio_port_p) [!USING_GUILE_BEFORE_2_2]: Use 'SCM_PORTP'
 473         and 'SCM_PORT_TYPE'.
 474         (gdbscm_memory_port_end_input, gdbscm_memory_port_seek)
 475         (ioscm_reinit_memory_port): Wrap in #if USING_GUILE_BEFORE_2_2.
 476         (gdbscm_memory_port_read, gdbscm_memory_port_write)
 477         (gdbscm_memory_port_seek, gdbscm_memory_port_close)
 478         [!USING_GUILE_BEFORE_2_2]: New functions.
 479         (gdbscm_memory_port_print): Remove use of 'SCM_PTOB_NAME'.
 480         (ioscm_init_memory_port_type) [!USING_GUILE_BEFORE_2_2]: Use
 481         'gdbscm_memory_port_read'.
 482         Wrap 'scm_set_port_end_input', 'scm_set_port_flush', and
 483         'scm_set_port_free' calls in #if USING_GUILE_BEFORE_2_2.
 484         (gdbscm_get_natural_buffer_sizes) [!USING_GUILE_BEFORE_2_2]: New
 485         function.
 486         (ioscm_init_memory_port): Remove.
 487         (ioscm_init_memory_port_stream): New function
 488         (ioscm_init_memory_port_buffers) [USING_GUILE_BEFORE_2_2]: New
 489         function.
 490         (gdbscm_memory_port_read_buffer_size) [!USING_GUILE_BEFORE_2_2]:
 491         Return scm_from_uint (0).
 492         (gdbscm_set_memory_port_read_buffer_size_x)
 493         [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'.
 494         (gdbscm_memory_port_write_buffer_size) [!USING_GUILE_BEFORE_2_2]:
 495         Return scm_from_uint (0).
 496         (gdbscm_set_memory_port_write_buffer_size_x)
 497         [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'.
 498         * configure.ac (try_guile_versions): Add "guile-2.2".
 499         * configure: Regenerate.
 500         * NEWS: Add entry.
 501
 502 2020-07-18  Tom Tromey  <tom@tromey.com>
 503
 504         * linux-nat.c (linux_multi_process): Remove.
 505         (linux_nat_target::supports_multi_process): Return true.
 506
 507 2020-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 508
 509         * arch/riscv.c (riscv_tdesc_cache): Change map type.
 510         (riscv_lookup_target_description): Return pointer out of
 511         unique_ptr.
 512         * target-descriptions.c (allocate_target_description): Add
 513         comment.
 514         (target_desc_deleter::operator()): Likewise.
 515         * target-descriptions.h (struct target_desc_deleter): Moved to
 516         gdbsupport/tdesc.h.
 517         (target_desc_up): Likewise.
 518
 519 2020-07-17  Tom Tromey  <tromey@adacore.com>
 520
 521         * linux-nat.c (linux_nat_target::supports_non_stop)
 522         (linux_nat_target::always_non_stop_p): Use "true".
 523         (linux_nat_target::supports_disable_randomization): Use "true" and
 524         "false".
 525
 526 2020-07-16  Caroline Tice  <cmtice@google.com>
 527
 528         * dwarf2/read.c (RNGLIST_HEADER_SIZE32) New constant definition.
 529         (RNGLIST_HEADER_SIZE64): New constant definition.
 530         (struct dwop_section_names): Add rnglists_dwo.
 531         (dwop_section_names): Add .debug_rnglists.dwo, .zdebug_rnglists.dwo.
 532         (struct loclist_header): Rename to 'loclists_rnglists_header'.
 533         (struct dwo_sections): Add rnglists field.
 534         (read_attribut_reprocess): Add tag parameter.
 535         (dwarf2_ranges_read): Add tag parameter & remove forward function decl.
 536         (cu_debug_rnglists_section): New function (decl & definition).
 537         (dwarf2_locate_dwo_sections): Add code to read rnglists_dwo section.
 538         (dwarf2_rnglists_process): Add a dwarf_tag parameter, for the kind of
 539         die whose range is being checked; get rnglist section from
 540         cu_debug_rnglists_section, to get from either objfile or dwo file as
 541         appropriate.  Add cases for DW_RLE_base_addressx,
 542         DW_RLE_startx_length, DW_RLE_startx_endx.  Also, update to only add
 543         the base address to DW_RLE_offset_pairs (not to all ranges), moving
 544         test inside if-condition and updating complaint message.
 545         (dwarf2_ranges_process): Add dwarf tag parameter and pass it to
 546         dwarf2_rnglists_process.
 547         (dwarf2_ranges_read): Add dwarf tag parameter and pass it to
 548         dwarf2_ranges_process.
 549         (dwarf2_get_pc_bounds): Check for DW_FORM_rnglistx when setting
 550         need_ranges_base and update comment appropriately.  Also pass die tag
 551         to dwarf2_ranges_read.
 552         (dwarf2_record_block_ranges): Check for DW_FORM_rnglistx when setting
 553         need_ranges_base and update comment appropriately.  Also pass die tag
 554         to dwarf2_ranges_process.
 555         (read_full_die_1): Add code to read DW_AT_rnglists_base and assign to
 556         cu->ranges_base.  Also pass die tag to read_attribute_reprocess.
 557         (partial_die_info::read): Check for DW_FORM_rnglistx when setting
 558         need_ranges_base and update comment appropriately.  Also pass die tag
 559         to read_attribute_reprocess and dwarf2_ranges_read.
 560         (read_loclist_header): Rename function to read_loclists_rnglists_header,
 561         and update function comment appropriately.
 562         (read_loclist_index): Call read_loclists_rnglists_header instead of
 563         read_loclist_header.
 564         (read_rnglist_index): New function.
 565         (read_attribute_reprocess):  Add tag parameter. Add code for
 566         DW_FORM_rnglistx, passing tag to read_rnglist_index.
 567         (read_attribute_value): Mark DW_FORM_rnglistx with need_reprocess.
 568
 569 2020-07-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 570
 571         * f-typeprint.c (f_type_print_base): Allow for dynamic types not
 572         being resolved.
 573
 574 2020-07-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 575
 576         * arch-utils.c (show_architecture): Update formatting of messages.
 577
 578 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 579
 580         * gdbtypes.h (struct type) <bounds>: Handle array and string
 581         types.
 582         * ada-lang.c (assign_aggregate): Use type::bounds on
 583         array/string type.
 584         * c-typeprint.c (c_type_print_varspec_suffix): Likewise.
 585         * c-varobj.c (c_number_of_children): Likewise.
 586         (c_describe_child): Likewise.
 587         * eval.c (evaluate_subexp_for_sizeof): Likewise.
 588         * f-typeprint.c (f_type_print_varspec_suffix): Likewise.
 589         (f_type_print_base): Likewise.
 590         * f-valprint.c (f77_array_offset_tbl): Likewise.
 591         (f77_get_upperbound): Likewise.
 592         (f77_print_array_1): Likewise.
 593         * guile/scm-type.c (gdbscm_type_range): Likewise.
 594         * m2-typeprint.c (m2_array): Likewise.
 595         (m2_is_long_set_of_type): Likewise.
 596         * m2-valprint.c (get_long_set_bounds): Likewise.
 597         * p-typeprint.c (pascal_type_print_varspec_prefix): Likewise.
 598         * python/py-type.c (typy_range): Likewise.
 599         * rust-lang.c (rust_internal_print_type): Likewise.
 600         * type-stack.c (type_stack::follow_types): Likewise.
 601         * valarith.c (value_subscripted_rvalue): Likewise.
 602         * valops.c (value_cast): Likewise.
 603
 604 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 605
 606         * gdbtypes.c (TYPE_ARRAY_BIT_STRIDE): Remove.  Update all
 607         callers to use the equivalent accessor methods.
 608
 609 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 610
 611         * gdbtypes.h (struct range_bounds) <bit_stride>: New method.
 612         (struct type) <bit_stride>: New method.
 613         (TYPE_BIT_STRIDE): Remove.
 614         * gdbtypes.c (update_static_array_size): Use type::bit_stride.
 615
 616 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 617
 618         * gdbtypes.h (TYPE_ARRAY_LOWER_BOUND_VALUE,
 619         TYPE_ARRAY_UPPER_BOUND_VALUE): Remove.  Update all
 620         callers to use the equivalent accessor methods instead.
 621
 622 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 623
 624         * gdbtypes.h (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED,
 625         TYPE_ARRAY_LOWER_BOUND_IS_UNDEFINED): Remove.  Update all
 626         callers to use the equivalent accessor methods instead.
 627
 628 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 629
 630         * gdbtypes.h (TYPE_LOW_BOUND_KIND,
 631         TYPE_HIGH_BOUND_KIND): Remove.  Update all callers
 632         to use dynamic_prop::kind.
 633
 634 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 635
 636         * gdbtypes.h (TYPE_LOW_BOUND_UNDEFINED,
 637         TYPE_HIGH_BOUND_UNDEFINED): Remove.  Update all callers
 638         to get the bound property's kind and check against
 639         PROP_UNDEFINED.
 640
 641 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 642
 643         * gdbtypes.h (TYPE_LOW_BOUND, TYPE_HIGH_BOUND): Remove.  Update
 644         all callers to use type::range_bounds followed by
 645         dynamic_prop::{low,high}.
 646
 647 2020-07-12  Simon Marchi  <simon.marchi@polymtl.ca>
 648
 649         * gdbtypes.h (struct dynamic_prop) <kind, set_undefined,
 650         const_val, set_const_val, baton, set_locexpr, set_loclist,
 651         set_addr_offset, variant_parts, set_variant_parts,
 652         original_type, set_original_type>: New methods.
 653         <kind>: Rename to...
 654         <m_kind>: ... this.  Update all users to use the new methods
 655         instead.
 656         <data>: Rename to...
 657         <m_data>: ... this.  Update all users to use the new methods
 658         instead.
 659
 660 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 661
 662         * gdbtypes.c (get_discrete_bounds): Return failure if
 663         the range type's bounds are not both defined and constant
 664         values.
 665         (get_array_bounds): Update comment.  Remove undefined bound check.
 666
 667 2020-07-12  Simon Marchi  <simon.marchi@polymtl.ca>
 668
 669         * gdbtypes.h (TYPE_RANGE_DATA): Remove.  Update callers to use
 670         the type::bounds method directly.
 671
 672 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
 673
 674         * gdbtypes.h (struct type) <bounds, set_bounds>: New methods.
 675         (TYPE_RANGE_DATA): Use type::bounds.  Change all uses that
 676         are used to set the range type's bounds to use set_bounds.
 677
 678 2020-07-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 679
 680         * exec.c (_initialize_exec): Update exec-file-mismatch help.
 681
 682 2020-07-10  Pedro Alves  <pedro@palves.net>
 683
 684         * gdbthread.h (inferior_ref): Define.
 685         (scoped_restore_current_thread) <m_thread>: Now a thread_info_ref.
 686         (scoped_restore_current_thread) <m_inf>: Now an inferior_ref.
 687         * thread.c
 688         (scoped_restore_current_thread::restore):
 689         Adjust to gdb::ref_ptr.
 690         (scoped_restore_current_thread::~scoped_restore_current_thread):
 691         Remove manual decref handling.
 692         (scoped_restore_current_thread::scoped_restore_current_thread):
 693         Adjust to use
 694         inferior_ref::new_reference/thread_info_ref::new_reference.
 695         Incref the thread before calling get_frame_id instead of after.
 696         Let TARGET_CLOSE_ERROR propagate.
 697
 698 2020-07-10  Pedro Alves  <pedro@palves.net>
 699
 700         * frame-tailcall.c (dwarf2_tailcall_sniffer_first): Only swallow
 701         NO_ENTRY_VALUE_ERROR / MEMORY_ERROR / OPTIMIZED_OUT_ERROR /
 702         NOT_AVAILABLE_ERROR.
 703         * value.c (value_optimized_out): Only swallow MEMORY_ERROR /
 704         OPTIMIZED_OUT_ERROR / NOT_AVAILABLE_ERROR.
 705
 706 2020-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 707             Pedro Alves  <pedro@palves.net>
 708
 709         PR gdb/26199
 710         * infrun.c (threads_are_resumed_pending_p): Delete.
 711         (do_target_wait): Remove threads_are_executing and
 712         threads_are_resumed_pending_p checks from the inferior_matches
 713         lambda.  Update comments.
 714
 715 2020-07-10  Pedro Alves  <pedro@palves.net>
 716
 717         PR gdb/26199
 718         * infrun.c (handle_no_resumed): Transfer terminal to inferior with
 719         executing threads.
 720
 721 2020-07-10  Pedro Alves  <pedro@palves.net>
 722
 723         PR gdb/26199
 724         * infrun.c (handle_no_resumed): Handle multiple targets.
 725
 726 2020-07-10  Pedro Alves  <pedro@palves.net>
 727
 728         PR gdb/26199
 729         * infrun.c (prepare_to_wait): Check target_can_async_p instead of
 730         target_is_async_p.
 731
 732 2020-07-10  Pedro Alves  <pedro@palves.net>
 733
 734         PR gdb/26199
 735         * target.c (target_pass_ctrlc): Look at the inferior's non-exited
 736         threads, not all threads.
 737
 738 2020-07-10  Pedro Alves  <pedro@palves.net>
 739
 740         PR gdb/26199
 741         * remote.c (remote_target::open_1): Pass remote target pointer as
 742         data to create_async_event_handler.
 743         (remote_async_inferior_event_handler): Mark async event handler
 744         before returning if the remote target still has either pending
 745         events or unacknowledged notifications.
 746
 747 2020-07-10  John Baldwin  <jhb@FreeBSD.org>
 748
 749         * fbsd-nat.h (fbsd_nat_target::supports_multi_process): New
 750         declaration.
 751         * fbsd-nat.c (fbsd_nat_target::supports_multi_process): New
 752         function.
 753
 754 2020-07-09  John Baldwin  <jhb@FreeBSD.org>
 755
 756         * inf-ptrace.c (inf_ptrace_target::wait): Don't compare against
 757         inferior_ptid.
 758
 759 2020-07-09  John Baldwin  <jhb@FreeBSD.org>
 760
 761         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_ARGC,
 762         AT_FREEBSD_ARGV, AT_FREEBSD_ENVC, AT_FREEBSD_ENVV,
 763         AT_FREEBSD_PS_STRINGS.
 764
 765 2020-07-08  Hannes Domani  <ssbssa@yahoo.de>
 766
 767         * auto-load.c (auto_load_objfile_script_1): Convert drive part
 768         of debugfile path on Windows.
 769
 770 2020-07-08  John Baldwin  <jhb@FreeBSD.org>
 771
 772         * fbsd-nat.c (fbsd_nat_target::find_memory_regions): Rename 'obfd'
 773         argument to 'data'.
 774
 775 2020-07-08  Tom Tromey  <tromey@adacore.com>
 776
 777         * ada-lang.c (ada_exception_message_1): Use read_memory.
 778
 779 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 780
 781         PR python/22748
 782         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Remove
 783         special handling for inline frames.
 784         * findvar.c (value_of_register_lazy): Skip inline frames when
 785         creating lazy register values.
 786         * frame.c (frame_id_computed_p): Delete definition.
 787         * frame.h (frame_id_computed_p): Delete declaration.
 788
 789 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 790
 791         * NEWS: Mention additions to Python API.
 792         * python/py-arch.c (archpy_register_groups): New function.
 793         (arch_object_methods): Add 'register_groups' method.
 794         * python/py-registers.c (reggroup_iterator_object): New struct.
 795         (reggroup_object): New struct.
 796         (gdbpy_new_reggroup): New function.
 797         (gdbpy_reggroup_to_string): New function.
 798         (gdbpy_reggroup_name): New function.
 799         (gdbpy_reggroup_iter): New function.
 800         (gdbpy_reggroup_iter_next): New function.
 801         (gdbpy_new_reggroup_iterator): New function
 802         (gdbpy_initialize_registers): Register new types.
 803         (reggroup_iterator_object_type): Define new Python type.
 804         (gdbpy_reggroup_getset): New static global.
 805         (reggroup_object_type): Define new Python type.
 806         * python/python-internal.h
 807
 808 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 809
 810         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-registers.c
 811         * python/py-arch.c (archpy_registers): New function.
 812         (arch_object_methods): Add 'registers' method.
 813         * python/py-registers.c: New file.
 814         * python/python-internal.h
 815         (gdbpy_new_register_descriptor_iterator): Declare.
 816         (gdbpy_initialize_registers): Declare.
 817         * python/python.c (do_start_initialization): Call
 818         gdbpy_initialize_registers.
 819         * NEWS: Mention additions to the Python API.
 820
 821 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 822
 823         * NEWS: Mention new Python API method.
 824         * python/py-unwind.c (pending_framepy_architecture): New function.
 825         (pending_frame_object_methods): Add architecture method.
 826
 827 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * gdbarch.c: Regenerate.
 830         * gdbarch.h: Regenerate.
 831         * gdbarch.sh (deprecated_set_gdbarch_data): Delete.
 832         (gdbarch_data): Use internal_error for the case where
 833         deprecated_set_gdbarch_data was originally needed.
 834         * ia64-libunwind-tdep.c (libunwind_descr_init): Update parameters,
 835         and use passed in obstack.
 836         (libunwind_frame_set_descr): Should no longer get back NULL from
 837         gdbarch_data.
 838         (_initialize_libunwind_frame): Register as a pre-init gdbarch data
 839         type.
 840         * user-regs.c (user_regs_init): Update parameters, and use passed
 841         in obstack.
 842         (user_reg_add): Should no longer get back NULL from gdbarch_data.
 843         (_initialize_user_regs): Register as a pre-init gdbarch data type.
 844
 845 2020-07-06  Tom de Vries  <tdevries@suse.de>
 846
 847         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Handle
 848         End-Of-Sequence in lte_is_less_than.
 849         * symtab.c (find_pc_sect_line): Revert change from commit 3d92a3e313
 850         "gdb: Don't reorder line table entries too much when sorting".
 851
 852 2020-07-06  Tom de Vries  <tdevries@suse.de>
 853
 854         PR tui/26205
 855         * tui/tui-win.c (tui_partial_win_by_name): Don't test for NULL name.
 856
 857 2020-07-05  Tom de Vries  <tdevries@suse.de>
 858
 859         PR build/26187
 860         * inferior.h (struct infcall_suspend_state_deleter): If available, use
 861         std::uncaught_exceptions instead of deprecated
 862         std::uncaught_exception.
 863
 864 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 865
 866         * macroexp.h (macro_stringify): Return
 867         gdb::unique_xmalloc_ptr<char>.
 868         * macroexp.c (macro_stringify): Likewise.
 869         * macrotab.c (fixup_definition): Update.
 870
 871 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 872
 873         * c-exp.y (scan_macro_expansion): Don't free `expansion`.
 874         (lex_one_token): Update.
 875         * macroexp.c (struct macro_buffer) <release>: Return
 876         gdb::unique_xmalloc_ptr<char>.
 877         (macro_stringify): Update.
 878         (macro_expand): Update.
 879         (macro_expand_next): Return gdb::unique_xmalloc_ptr<char>.
 880         * macroexp.h (macro_expand_next): Likewise.
 881
 882 2020-07-02  Simon Marchi  <simon.marchi@efficios.com>
 883
 884         * macroexp.h (macro_lookup_ftype): Remove.
 885         (macro_expand, macro_expand_once, macro_expand_next): Remove
 886         lookup function parameters, add scope parameter.
 887         * macroexp.c (scan, substitute_args, expand, maybe_expand,
 888         macro_expand, macro_expand_once, macro_expand_next): Likewise.
 889         * macroscope.h (standard_macro_lookup): Change parameter type
 890         to macro_scope.
 891         * macroscope.c (standard_macro_lookup): Likewise.
 892         * c-exp.y (lex_one_token): Update.
 893         * macrocmd.c (macro_expand_command): Likewise.
 894         (macro_expand_once_command): Likewise.
 895
 896 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 897
 898         * inf-loop.c (inferior_event_handler): Remove client_data param.
 899         * inf-loop.h (inferior_event_handler): Likewise.
 900         * infcmd.c (step_1): Adjust.
 901         * infrun.c (proceed): Adjust.
 902         (fetch_inferior_event): Remove client_data param.
 903         (infrun_async_inferior_event_handler): Adjust.
 904         * infrun.h (fetch_inferior_event): Remove `void *` param.
 905         * linux-nat.c (handle_target_event): Adjust.
 906         * record-btrace.c (record_btrace_handle_async_inferior_event):
 907         Adjust.
 908         * record-full.c (record_full_async_inferior_event_handler):
 909         Adjust.
 910         * remote.c (remote_async_inferior_event_handler): Adjust.
 911
 912 2020-07-01  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui-data.h (struct tui_win_info) <name>: Now pure virtual.
 915         * tui/tui-stack.h (struct tui_locator_window) <name>: New method.
 916
 917 2020-07-01  Tom Tromey  <tom@tromey.com>
 918
 919         * tui/tui-wingeneral.c (tui_win_info::refresh_window): Move from
 920         tui_gen_win_info.
 921         (tui_win_info::make_window): Merge with
 922         tui_gen_win_info::make_window.
 923         (tui_win_info::make_visible): Move from tui_gen_win_info.
 924         * tui/tui-win.c (tui_win_info::max_width): Move from
 925         tui_gen_win_info.
 926         * tui/tui-layout.h (class tui_layout_window) <m_window>: Change
 927         type.
 928         <window_factory>: Likewise.
 929         * tui/tui-layout.c (tui_win_info::resize): Move from
 930         tui_gen_win_info.
 931         (make_standard_window): Change return type.
 932         (get_locator_window, tui_get_window_by_name): Likewise.
 933         (tui_layout_window::apply): Remove a cast.
 934         * tui/tui-data.h (MIN_WIN_HEIGHT): Move earlier.
 935         (struct tui_win_info): Merge with tui_gen_win_info.
 936         (struct tui_gen_win_info): Remove.
 937
 938 2020-07-01  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-stack.h (struct tui_locator_window): Derive from
 941         tui_win_info.
 942         <do_scroll_horizontal, do_scroll_vertical>: New methods.
 943         <can_box>: New method.
 944
 945 2020-07-01  Tom Tromey  <tom@tromey.com>
 946
 947         * tui/tui-stack.h (struct tui_locator_window): Remove body.
 948
 949 2020-07-01  Tom Tromey  <tom@tromey.com>
 950
 951         * tui/tui-regs.c (tui_data_window::display_registers_from)
 952         (tui_data_window::display_registers_from)
 953         (tui_data_window::first_data_item_displayed)
 954         (tui_data_window::delete_data_content_windows): Update.
 955         (tui_data_window::refresh_window, tui_data_window::no_refresh):
 956         Remove.
 957         (tui_data_window::check_register_values): Update.
 958         (tui_data_item_window::rerender): Add parameters.  Update.
 959         (tui_data_item_window::refresh_window): Remove.
 960         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: No longer
 961         virtual.
 962         * tui/tui-regs.h (struct tui_data_item_window): Don't derive from
 963         tui_gen_win_info.
 964         <refresh_window, max_height, min_height>: Remove.
 965         <rerender>: Add parameters.
 966         <x, y, visible>: New members.
 967         (struct tui_data_window) <refresh_window, no_refresh>: Remove.
 968         <m_item_width>: New member.
 969
 970 2020-07-01  Tom Tromey  <tom@tromey.com>
 971
 972         * tui/tui-regs.c (tui_data_window::show_register_group)
 973         (tui_data_window::check_register_values): Update.
 974         * tui/tui-regs.h (struct tui_data_item_window) <regno>: Rename
 975         from item_no.
 976
 977 2020-07-01  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-regs.c (tui_data_window::show_register_group): Remove
 980         useless "if".
 981
 982 2020-07-01  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 985         * tui/tui-regs.h (struct tui_data_item_window) <name>: Remove.
 986
 987 2020-07-01  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-stack.c (SINGLE_KEY): Move from tui-data.h
 990         * tui/tui-winsource.h (enum tui_line_or_address_kind)
 991         (struct tui_line_or_address): Move from tui-data.h.
 992         * tui/tui-win.c (DEFAULT_TAB_LEN): Move from tui-data.h.
 993         * tui/tui-data.h (DEFAULT_TAB_LEN): Move to tui-win.c.
 994         (tui_cmd_window, tui_source_window_base, tui_source_window)
 995         (tui_disasm_window): Don't declare.
 996         (enum tui_line_or_address_kind, struct tui_line_or_address): Move
 997         to tui-winsource.h.
 998         (SINGLE_KEY): Move to tui-stack.c.
 999
1000 2020-07-01  Tom Tromey  <tom@tromey.com>
1001
1002         * tui/tui-regs.h (struct tui_data_item_window) <content>: Now a
1003         std::string.
1004         * tui/tui-regs.c (class tab_expansion_file): New.
1005         (tab_expansion_file::write): New method.
1006         (tui_register_format): Change return type.  Use
1007         tab_expansion_file.
1008         (tui_get_register, tui_data_window::display_registers_from)
1009         (tui_data_item_window::rerender): Update.
1010         * tui/tui-io.h (tui_expand_tabs): Don't declare.
1011         * tui/tui-io.c (tui_expand_tabs): Remove.
1012
1013 2020-07-01  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-regs.c (tui_reggroup_completer): Use complete_on_enum.
1016
1017 2020-07-01  Fangrui Song  <maskray@google.com>
1018
1019         * dwarf2/read.c (lnp_state_machine::check_line_address): Test -1.
1020
1021 2020-07-01  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1022
1023         * dwarf2/read.c (set_die_type): Removed conditions to restrict
1024         forms for DW_AT_associated and DW_AT_allocated attributes,
1025         which is already checked in function attr_to_dynamic_prop.
1026
1027 2020-06-30  Tom Tromey  <tromey@adacore.com>
1028
1029         * dwarf2/read.c (quirk_rust_enum): Correctly call
1030         alloc_rust_variant for default-less enum.
1031
1032 2020-06-30  Tom Tromey  <tromey@adacore.com>
1033
1034         PR build/26183:
1035         * ada-lang.c (ada_lookup_name_info::ada_lookup_name_info): Use
1036         gdb::to_string.
1037
1038 2020-06-29  Simon Marchi  <simon.marchi@efficios.com>
1039
1040         * gdbarch.sh (displaced_step_copy_insn): Update doc.
1041         * gdbarch.h: Re-generate.
1042
1043 2020-06-28  Tom Tromey  <tom@tromey.com>
1044
1045         * command.h (cmd_types): Remove.
1046         (cmd_type): Don't declare.
1047         * cli/cli-decode.h (enum cmd_types): Uncomment.  No longer a
1048         typedef.
1049         * cli/cli-cmds.c (setting_cmd): Use cmd->type directly.
1050         * cli/cli-decode.c (cmd_type): Remove.
1051
1052 2020-06-27  Pedro Alves  <palves@redhat.com>
1053
1054         * fork-child.c (prefork_hook): Adjust.
1055         * infcmd.c (set_inferior_io_terminal, get_inferior_io_terminal):
1056         Delete.
1057         (set_inferior_tty_command, show_inferior_tty_command): Adjust.
1058         * inferior.c (inferior::set_tty, inferior::tty): New methods.
1059         * inferior.h (set_inferior_io_terminal, get_inferior_io_terminal):
1060         Remove declarations.
1061         (struct inferior) <set_tty, tty>: New methods.
1062         (struct inferior) <terminal>: Rename to ...
1063         (struct inferior) <m_terminal>: ... this and make private.
1064         * main.c (captured_main_1): Adjust.
1065         * mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): Adjust.
1066         (mi_cmd_inferior_tty_show): Adjust.
1067         * nto-procfs.c (nto_procfs_target::create_inferior): Adjust.
1068         * windows-nat.c (windows_nat_target::create_inferior): Adjust.
1069
1070 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
1071
1072         * configure.ac: Add --enable-libctf: handle --disable-static
1073         properly.
1074         * acinclude.m4: sinclude ../config/enable.m4.
1075         * Makefile.in (aclocal_m4_deps): Adjust accordingly.
1076         (LIBCTF): Substitute in.
1077         (CTF_DEPS): New, likewise.
1078         (CLIBS): libctf needs symbols from libbfd: move earlier.
1079         (CDEPS): Use CTF_DEPS, not LIBCTF, now LIBCTF can include rpath
1080         flags.
1081         * ctfread.c: Surround in ENABLE_LIBCTF.
1082         (elfctf_build_psymtabs) [!ENABLE_LIBCTF]: New stub.
1083         * configure: Regenerate.
1084         * config.in: Likewise.
1085
1086 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
1087
1088         * infcmd.c (set_inferior_io_terminal): Use make_unique_xstrdup.
1089
1090 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
1091
1092         * inferior.h (struct inferior) <terminal>: Change type to
1093         gdb::unique_xmalloc_ptr<char>.
1094         * inferior.c (inferior::~inferior): Don't free inf->terminal.
1095         * infcmd.c (set_inferior_io_terminal): Don't free terminal
1096         field, adjust to unique pointer.
1097         (get_inferior_io_terminal): Adjust to unique pointer.
1098
1099 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1100
1101         * riscv-tdep.c (riscv_print_registers_info): Loop over all
1102         registers, not just the known core set of registers.
1103
1104 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1105
1106         * riscv-tdep.c (riscv_register_name): Return NULL for duplicate
1107         fflags, frm, and fcsr registers.
1108         (riscv_register_reggroup_p): Remove unknown CSRs from save and
1109         restore groups.
1110         (riscv_tdesc_unknown_reg): New function.
1111         (riscv_gdbarch_init): Pass riscv_tdesc_unknown_reg to
1112         tdesc_use_registers.
1113         * riscv-tdep.h (struct gdbarch_tdep): Add
1114         unknown_csrs_first_regnum, unknown_csrs_count,
1115         duplicate_fflags_regnum, duplicate_frm_regnum, and
1116         duplicate_fcsr_regnum fields.
1117
1118 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1119
1120         * target-descriptions.c (tdesc_use_registers): Add new parameter a
1121         callback, use the callback (when not null) to help number unknown
1122         registers.
1123         * target-descriptions.h (tdesc_unknown_register_ftype): New typedef.
1124         (tdesc_use_registers): Add extra parameter to declaration.
1125
1126 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1127
1128         * riscv-tdep.c (value_of_riscv_user_reg): Moved to here from later
1129         in the file.
1130         (class riscv_pending_register_alias): Likewise.
1131         (riscv_register_feature::register_info): Change 'required_p' field
1132         to 'required', and change its type.  Add 'check' member function.
1133         (riscv_register_feature::register_info::check): Define new member
1134         function.
1135         (riscv_xreg_feature): Change initialisation of 'required' field.
1136         (riscv_freg_feature): Likewise.
1137         (riscv_virtual_feature): Likewise.
1138         (riscv_csr_feature): Likewise.
1139         (riscv_check_tdesc_feature): Take extra parameter, the csr
1140         tdesc_feature, rewrite the function to use the new
1141         riscv_register_feature::register_info::check function.
1142         (riscv_gdbarch_init): Pass the csr tdesc_feature where needed.
1143
1144 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1145
1146         * features/Makefile: Remove all references to the deleted files
1147         below.
1148         * features/riscv/32bit-csr.c: Deleted.
1149         * features/riscv/32bit-csr.xml: Deleted.
1150         * features/riscv/64bit-csr.c: Deleted.
1151         * features/riscv/64bit-csr.xml: Deleted.
1152         * features/riscv/rebuild-csr-xml.sh: Deleted.
1153
1154 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1155
1156         * riscv-tdep.c (struct riscv_register_feature::register_info): Fix
1157         whitespace error for declaration of names member variable.
1158         (struct riscv_register_feature): Add new prefer_first_name member
1159         variable, and fix whitespace error in declaration of registers.
1160         (riscv_xreg_feature): Initialize prefer_first_name field.
1161         (riscv_freg_feature): Likewise.
1162         (riscv_virtual_feature): Likewise.
1163         (riscv_csr_feature): Likewise.
1164         (riscv_register_name): Expand on comments.  Remove register name
1165         modifications for CSR and virtual registers.
1166
1167 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1168
1169         * riscv-tdep.c (struct riscv_register_feature): Fix whitespace
1170         errors.
1171
1172 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1173
1174         * riscv-tdep.c (riscv_create_csr_aliases): Handle csr aliases from
1175         riscv-opc.h.
1176         (class riscv_pending_register_alias): New class.
1177         (riscv_check_tdesc_feature): Take vector of pending aliases and
1178         populate it as appropriate.
1179         (riscv_setup_register_aliases): Delete.
1180         (riscv_gdbarch_init): Create vector of pending aliases and pass it
1181         to riscv_check_tdesc_feature in all cases.  Use the vector to
1182         create the register aliases.
1183
1184 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1185
1186         * sol2-tdep.c (sol2_static_transform_name): Remove.
1187         (sol2_init_abi): Don't register it.
1188         * gdbarch.sh (static_transform_name): Remove.
1189         * gdbarch.c, gdbarch.h: Regenerate.
1190
1191         * dbxread.c (read_dbx_symtab) <'S'>: Remove call to
1192         gdbarch_static_transform_name.
1193         * mdebugread.c (parse_partial_symbols) <'S'>: Likewise.
1194         * stabsread.c (define_symbol) <'X'>: Remove.
1195         (define_symbol) <'S'>: Remove gdbarch_static_transform_name
1196         handling.
1197         <'V'>: Likewise.
1198         * xcoffread.c (scan_xcoff_symtab): Remove gdbarch.
1199         <'S'>: Remove call to gdbarch_static_transform_name.
1200
1201 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1202
1203         * procfs.c (procfs_pre_trace): New function.
1204         (procfs_target::create_inferior): Pass it to fork_inferior.
1205
1206 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1207
1208         * configure.tgt <sparc-*-linux*> (gdb_target_obs): Remove
1209         sparc-sol2-tdep.o, sol2-tdep.o, sparc64-sol2-tdep.o.
1210         <sparc64-*-linux*> (gdb_target_obs): Remove sparc64-sol2-tdep.o,
1211         sol2-tdep.o, sparc-sol2-tdep.o.
1212         * sparc-sol2-tdep.c (sparc32_sol2_init_abi): Make static.
1213         * sparc-tdep.h (sparc32_sol2_init_abi): Remove.
1214         * sparc64-sol2-tdep.c (sparc64_sol2_init_abi): Make static.
1215         * sparc64-tdep.h (sparc64_sol2_init_abi): Remove.
1216
1217 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1218
1219         * amd64-sol2-tdep.c (amd64_sol2_sigtramp_p): Remove.
1220         (amd64_sol2_init_abi): Use sol2_sigtramp_p.
1221         Call sol2_init_abi.
1222         Remove calls to set_gdbarch_skip_solib_resolver,
1223         set_gdbarch_core_pid_to_str.
1224         * i386-sol2-tdep.c (i386_sol2_sigtramp_p): Remove.
1225         (i386_sol2_static_transform_name): Remove.
1226         (i386_sol2_init_abi): Call sol2_init_abi.
1227         Remove calls to set_gdbarch_sofun_address_maybe_missing,
1228         set_gdbarch_static_transform_name,
1229         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
1230         Use sol2_sigtramp_p.
1231         * sol2-tdep.c (sol2_pc_in_sigtramp): New function.
1232         (sol2_sigtramp_p): New function.
1233         (sol2_static_transform_name): New function.
1234         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Make static.
1235         (sol2_init_abi): New function.
1236         * sol2-tdep.h (sol2_sigtramp_p, sol2_init_abi): Declare.
1237         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Remove.
1238         * sparc-sol2-tdep.c (sparc_sol2_pc_in_sigtramp): Remove.
1239         (sparc32_sol2_sigtramp_frame_sniffer): Just call sol2_sigtramp_p.
1240         (sparc_sol2_static_transform_name): Remove.
1241         (sparc32_sol2_init_abi): Call sol2_init_abi.
1242         Remove calls to set_gdbarch_sofun_address_maybe_missing,
1243         set_gdbarch_static_transform_name,
1244         set_gdbarch_skip_solib_resolver,
1245         set_gdbarch_core_pid_to_str.
1246         * sparc-tdep.h (sparc_sol2_pc_in_sigtramp)
1247         (sparc_sol2_static_transform_name): Remove
1248         * sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_sniffer): Just
1249         call sol2_sigtramp_p.
1250         (sparc64_sol2_init_abi): Call sol2_init_abi.
1251         Remove calls to set_gdbarch_sofun_address_maybe_missing,
1252         set_gdbarch_static_transform_name,
1253         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
1254
1255 2020-06-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1256
1257         * symfile-add-flags.h: New flag SYMFILE_ALWAYS_CONFIRM.
1258         * exec.c (validate_exec_file): If from_tty, set both
1259         SYMFILE_VERBOSE (== from_tty) and SYMFILE_ALWAYS_CONFIRM.
1260         * symfile.c (symbol_file_add_with_addrs): if always_confirm
1261         and from_tty, unconditionally ask a confirmation.
1262
1263 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1264
1265         * target-descriptions.c (tdesc_architecture_name): Protect against
1266         NULL pointer dereference.
1267         (maint_print_xml_tdesc_cmd): New function.
1268         (_initialize_target_descriptions): Register new 'maint print
1269         xml-tdesc' command and give it the filename completer.
1270         * NEWS: Mention new 'maint print xml-tdesc' command.
1271
1272 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1273
1274         * target-descriptions.c (class tdesc_compatible_info): New class.
1275         (struct target_desc): Change type of compatible vector.
1276         (tdesc_compatible_p): Update for change in type of
1277         target_desc::compatible.
1278         (tdesc_compatible_info_list): New function.
1279         (tdesc_compatible_info_arch_name): New function.
1280         (tdesc_add_compatible): Update for change in type of
1281         target_desc::compatible.
1282         (print_c_tdesc::visit_pre): Likewise.
1283
1284 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1285
1286         * target-descriptions.c (print_c_tdesc::print_c_tdesc): Change
1287         whitespace to underscore.
1288         (maint_print_c_tdesc_cmd): Use fake filename for target
1289         descriptions that came from the target.
1290         (_initialize_target_descriptions): Add filename command completion
1291         for 'maint print c-tdesc'.
1292
1293 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
1294
1295         * dwarf2/loc.c (decode_debug_loclists_addresses): Add empty
1296         lines.
1297
1298 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
1299
1300         * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty
1301         lines.
1302         (dwarf2_find_location_expression): Likewise.
1303         (call_site_parameter_matches): Likewise.
1304         (dwarf2_compile_expr_to_ax): Likewise.
1305         (disassemble_dwarf_expression): Likewise.
1306         (loclist_describe_location): Likewise.
1307
1308 2020-06-23  Pedro Alves  <palves@redhat.com>
1309
1310         * gdbarch-selftests.c: Don't include inferior.h, gdbthread.h or
1311         progspace-and-thread.h.  Include scoped-mock-context.h instead.
1312         (register_to_value_test): Use scoped_mock_context.
1313         * regcache.c: Include "scoped-mock-context.h".
1314         (cooked_read_test): Don't error out if a target is already pushed.
1315         Use scoped_mock_context.  Adjust.
1316         * scoped-mock-context.h: New file.
1317
1318 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1319
1320         * ada-lang.c (ada_language_data): Delete la_is_string_type_p
1321         initializer.
1322         (ada_language::is_string_type_p): New member function.
1323         * c-lang.c (c_language_data): Delete la_is_string_type_p
1324         initializer.
1325         (cplus_language_data): Likewise.
1326         (asm_language_data): Likewise.
1327         (minimal_language_data): Likewise.
1328         * d-lang.c (d_language_data): Likewise.
1329         * f-lang.c (f_is_string_type_p): Delete function, implementation
1330         moved to f_language::is_string_type_p.
1331         (f_language_data): Delete la_is_string_type_p initializer.
1332         (f_language::is_string_type_p): New member function,
1333         implementation from f_is_string_type_p.
1334         * go-lang.c (go_is_string_type_p): Delete function, implementation
1335         moved to go_language::is_string_type_p.
1336         (go_language_data): Delete la_is_string_type_p initializer.
1337         (go_language::is_string_type_p): New member function,
1338         implementation from go_is_string_type_p.
1339         * language.c (language_defn::is_string_type_p): Define new member
1340         function.
1341         (default_is_string_type_p): Make static, add comment copied from
1342         header file.
1343         (unknown_language_data): Delete la_is_string_type_p initializer.
1344         (unknown_language::is_string_type_p): New member function.
1345         (auto_language_data): Delete la_is_string_type_p initializer.
1346         (auto_language::is_string_type_p): New member function.
1347         * language.h (language_data): Delete la_is_string_type_p field.
1348         (language_defn::is_string_type_p): Declare new function.
1349         (default_is_string_type_p): Delete desclaration, move comment to
1350         definition.
1351         * m2-lang.c (m2_is_string_type_p): Delete function, implementation
1352         moved to m2_language::is_string_type_p.
1353         (m2_language_data): Delete la_is_string_type_p initializer.
1354         (m2_language::is_string_type_p): New member function,
1355         implementation from m2_is_string_type_p.
1356         * objc-lang.c (objc_language_data): Delete la_is_string_type_p
1357         initializer.
1358         * opencl-lang.c (opencl_language_data): Likewise.
1359         * p-lang.c (pascal_is_string_type_p): Delete function,
1360         implementation moved to pascal_language::is_string_type_p.
1361         (pascal_language_data): Delete la_is_string_type_p initializer.
1362         (pascal_language::is_string_type_p): New member function,
1363         implementation from pascal_is_string_type_p.
1364         * rust-lang.c (rust_is_string_type_p): Delete function,
1365         implementation moved to rust_language::is_string_type_p.
1366         (rust_language_data): Delete la_is_string_type_p initializer.
1367         (rust_language::is_string_type_p): New member function,
1368         implementation from rust_is_string_type_p.
1369         * valprint.c (val_print_scalar_or_string_type_p): Update call to
1370         is_string_type_p.
1371
1372 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1373
1374         * ada-lang.c (ada_language_data): Delete la_print_typedef
1375         initializer.
1376         (ada_language::print_typedef): New member function.
1377         * c-lang.c (c_language_data): Delete la_print_typedef initializer.
1378         (cplus_language_data): Likewise.
1379         (asm_language_data): Likewise.
1380         (minimal_language_data): Likewise.
1381         * d-lang.c (d_language_data): Likewise.
1382         * f-lang.c (f_language_data): Likewise.
1383         (f_language::print_typedef): New member function.
1384         * go-lang.c (go_language_data): Delete la_print_typedef
1385         initializer.
1386         * language.c (language_defn::print_typedef): Define member
1387         function.
1388         (unknown_language_data): Delete la_print_typedef initializer.
1389         (unknown_language::print_typedef): New member function.
1390         (auto_language_data): Delete la_print_typedef initializer.
1391         (auto_language::print_typedef): New member function.
1392         * language.h (language_data): Delete la_print_typedef field.
1393         (language_defn::print_typedef): Declare new member function.
1394         (LA_PRINT_TYPEDEF): Update call to print_typedef.
1395         (default_print_typedef): Delete declaration.
1396         * m2-lang.c (m2_language_data): Delete la_print_typedef
1397         initializer.
1398         (m2_language::print_typedef): New member function.
1399         * objc-lang.c (objc_language_data): Delete la_print_typedef
1400         initializer.
1401         * opencl-lang.c (opencl_language_data): Likewise.
1402         * p-lang.c (pascal_language_data): Likewise.
1403         (pascal_language::print_typedef): New member function.
1404         * rust-lang.c (rust_print_typedef): Delete function,
1405         implementation moved to rust_language::print_typedef.
1406         (rust_language): Delete la_print_typedef initializer.
1407         (rust_language::print_typedef): New member function,
1408         implementation from rust_print_typedef.
1409         * typeprint.c (default_print_typedef): Delete.
1410
1411 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1412
1413         * ada-lang.c (ada_language_data): Delete la_printstr initializer.
1414         (ada_language::printstr): New member function.
1415         * c-lang.c (c_language_data): Delete la_printstr initializer.
1416         (cplus_language_data): Likewise.
1417         (asm_language_data): Likewise.
1418         (minimal_language_data): Likewise.
1419         * d-lang.c (d_language_data): Likewise.
1420         * f-lang.c (f_printstr): Rename to f_language::printstr.
1421         (f_language_data): Delete la_printstr initializer.
1422         (f_language::printstr): New member function, implementation from
1423         f_printstr.
1424         * go-lang.c (go_language_data): Delete la_printstr initializer.
1425         * language.c (language_defn::printstr): Define new member
1426         function.
1427         (unk_lang_printstr): Delete.
1428         (unknown_language_data): Delete la_printstr initializer.
1429         (unknown_language::printstr): New member function.
1430         (auto_language_data): Delete la_printstr initializer.
1431         (auto_language::printstr): New member function.
1432         * language.h (language_data): Delete la_printstr field.
1433         (language_defn::printstr): Declare new member function.
1434         (LA_PRINT_STRING): Update call to printstr.
1435         * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
1436         (m2_language_data): Delete la_printstr initializer.
1437         (m2_language::printstr): New member function, implementation from
1438         m2_printstr.
1439         * objc-lang.c (objc_language_data): Delete la_printstr
1440         initializer.
1441         * opencl-lang.c (opencl_language_data): Likewise.
1442         * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
1443         (pascal_language_data): Delete la_printstr initializer.
1444         (pascal_language::printstr): New member function, implementation
1445         from pascal_printstr.
1446         * p-lang.h (pascal_printstr): Delete declaration.
1447         * rust-lang.c (rust_printstr): Update header comment.
1448         (rust_language_data): Delete la_printstr initializer.
1449         (rust_language::printstr): New member function.
1450
1451 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1452
1453         * ada-lang.c (ada_language_data): Delete la_printchar initializer.
1454         (ada_language::printchar): New member function.
1455         * c-lang.c (c_language_data): Delete la_printchar initializer.
1456         (cplus_language_data): Likewise.
1457         (asm_language_data): Likewise.
1458         (minimal_language_data): Likewise.
1459         * d-lang.c (d_language_data): Likewise.
1460         * f-lang.c (f_printchar): Rename to f_language::printchar.
1461         (f_language_data): Delete la_printchar initializer.
1462         (f_language::printchar): New member function, implementation from
1463         f_printchar.
1464         * go-lang.c (go_language_data): Delete la_printchar initializer.
1465         * language.c (unk_lang_printchar): Delete.
1466         (language_defn::printchar): Define new member function.
1467         (unknown_language_data): Delete la_printchar initializer.
1468         (unknown_language::printchar): New member function.
1469         (auto_language_data): Delete la_printchar initializer.
1470         (auto_language::printchar): New member function.
1471         * language.h (language_data): Delete la_printchar field.
1472         (language_defn::printchar): Declare new member function.
1473         (LA_PRINT_CHAR): Update call to printchar.
1474         * m2-lang.c (m2_language_data): Delete la_printchar initializer.
1475         (m2_language::printchar): New member function.
1476         * objc-lang.c (objc_language_data): Delete la_printchar
1477         initializer.
1478         * opencl-lang.c (opencl_language_data): Likewise.
1479         * p-lang.c (pascal_language_data): Delete la_printchar
1480         initializer.
1481         (pascal_language::printchar): New member function.
1482         * rust-lang.c (rust_printchar): Rename to
1483         rust_language::printchar.
1484         (rust_language_data): Delete la_printchar initializer.
1485         (rust_language::printchar): New member function, implementation
1486         from rust_printchar.
1487
1488 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1489
1490         * ada-lang.c (emit_char): Renamed to ada_language::emitchar.
1491         (ada_language_data): Delete la_emitchar initializer.
1492         (ada_language::emitchar): New member function, implementation from
1493         emit_char.
1494         * c-lang.c (c_language_data): Delete la_emitchar initializer.
1495         (cplus_language_data): Likewise.
1496         (asm_language_data): Likewise.
1497         (minimal_language_data): Likewise.
1498         * d-lang.c (d_language_data): Likewise.
1499         * f-lang.c (f_emit_char): Rename to f_language::emitchar.
1500         (f_language_data): Delete la_emitchar initializer.
1501         (f_language::emitchar): New member function, implementation from
1502         f_emit_char.
1503         * go-lang.c (go_language_data): Delete la_emitchar initializer.
1504         * language.c (unk_lang_emit_char): Delete.
1505         (language_defn::emitchar): New member function definition.
1506         (unknown_language_data): Delete la_emitchar initializer.
1507         (unknown_language::emitchar): New member function.
1508         (auto_language_data): Delete la_emitchar initializer.
1509         (auto_language::emitchar): New member function.
1510         * language.h (language_data): Delete la_emitchar field.
1511         (language_defn::emitchar): New member field declaration.
1512         (LA_EMIT_CHAR): Update call to emitchar.
1513         * m2-lang.c (m2_emit_char): Rename to m2_language::emitchar.
1514         (m2_language_data): Delete la_emitchar initializer.
1515         (m2_language::emitchar): New member function, implementation from
1516         m2_emit_char.
1517         * objc-lang.c (objc_language_data): Delete la_emitchar
1518         initializer.
1519         * opencl-lang.c (opencl_language_data): Likewise.
1520         * p-lang.c (pascal_emit_char): Rename to pascal_language::emitchar.
1521         (pascal_language_data): Delete la_emitchar initializer.
1522         (pascal_language::emitchar): New member function, implementation
1523         from pascal_emit_char.
1524         * rust-lang.c (rust_emitchar): Rename to rust_language::emitchar.
1525         (rust_language_data): Delete la_emitchar initializer.
1526         (rust_language::emitchar): New member function, implementation
1527         from rust_emitchar.
1528
1529 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1530
1531         * ada-lang.c (resolve): Rename to ada_language::post_parser.
1532         (ada_language_data): Delete la_post_parser initializer.
1533         (ada_language::post_parser): New member function.
1534         * c-lang.c (c_language_data): Delete la_post_parser initializer.
1535         (cplus_language_data): Likewise.
1536         (asm_language_data): Likewise.
1537         (minimal_language_data): Likewise.
1538         * d-lang.c (d_language_data): Likewise.
1539         * f-lang.c (f_language_data): Likewise.
1540         * go-lang.c (go_language_data): Likewise.
1541         * language.c (unknown_language_data): Likewise.
1542         (auto_language_data): Likewise.
1543         * language.h (language_data): Delete la_post_parser field.
1544         (language_defn::post_parser): New member function.
1545         * m2-lang.c (m2_language_data): Delete la_post_parser initializer.
1546         * objc-lang.c (objc_language_data): Likewise.
1547         * opencl-lang.c (opencl_language_data): Likewise.
1548         * p-lang.c (pascal_language_data): Likewise.
1549         * parse.c (parse_exp_in_context): Update call to post_parser.
1550         (null_post_parser): Delete definition.
1551         * parser-defs.h (null_post_parser): Delete declaration.
1552         * rust-lang.c (rust_language_data): Delete la_post_parser
1553         initializer.
1554
1555 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1556
1557         * ada-lang.c (parse): Rename to ada_language::parser.
1558         (ada_language_data): Delete la_parser initializer.
1559         (ada_language::parser): New member function, implementation from
1560         parse.
1561         * c-lang.c (c_language_data): Delete la_parser initializer.
1562         (cplus_language_data): Likewise.
1563         (asm_language_data): Likewise.
1564         (minimal_language_data): Likewise.
1565         * d-lang.c (d_language_data): Likewise.
1566         (d_language::parser): New member function.
1567         * f-lang.c (f_language_data): Delete la_parser initializer.
1568         (f_language::parser): New member function.
1569         * go-lang.c (go_language_data): Delete la_parser initializer.
1570         (go_language::parser): New member function.
1571         * language.c (unk_lang_parser): Delete.
1572         (language_defn::parser): Define new member function.
1573         (unknown_language_data): Delete la_parser initializer.
1574         (unknown_language::parser): New member function.
1575         (auto_language_data): Delete la_parser initializer.
1576         (auto_language::parser): New member function.
1577         * language.h (language_data): Delete la_parser field.
1578         (language_defn::parser): Declare new member function.
1579         * m2-lang.c (m2_language_data): Delete la_parser initializer.
1580         (m2_language::parser): New member function.
1581         * objc-lang.c (objc_language_data): Delete la_parser initializer.
1582         * opencl-lang.c (opencl_language_data): Likewise.
1583         * p-lang.c (pascal_language_data): Likewise.
1584         (pascal_language::parser): New member function.
1585         * parse.c (parse_exp_in_context): Update call to parser.
1586         * rust-lang.c (rust_language_data): Delete la_parser initializer.
1587         (rust_language::parser): New member function.
1588
1589 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1590
1591         * top.c (print_gdb_configuration): Print --with-python-libdir
1592         configuration value.
1593
1594 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1595
1596         * NEWS: Mention change to the alias command.
1597
1598 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1599
1600         * cli/cli-cmds.c (lookup_cmd_for_default_args)
1601         (alias_command_completer)
1602         (make_alias_options_def_group): New functions.
1603         (alias_opts, alias_option_defs): New struct and array.
1604         (alias_usage_error): Update usage.
1605         (alias_command): Handles optional DEFAULT-ARGS... arguments.
1606         Use option framework.
1607         (_initialize_cli_cmds): Update alias command help.
1608         Update aliases command help.
1609         (show_user):
1610         Add NULL for new default_args lookup_cmd argument.
1611         (valid_command_p): Rename to validate_aliased_command.
1612         Add NULL for new default_args lookup_cmd argument.  Verify that the
1613         aliased_command has no default args.
1614         * cli/cli-decode.c (help_cmd): Show aliases definitions.
1615         (lookup_cmd_1, lookup_cmd): New argument default_args.
1616         (add_alias_cmd):
1617         Add NULL for new default_args lookup_cmd argument.
1618         (print_help_for_command): Show default args under the layout
1619          alias some_alias = some_aliased_cmd some_alias_default_arg.
1620         * cli/cli-decode.h (struct cmd_list_element): New member default_args.
1621         xfree default_args in destructor.
1622         * cli/cli-script.c (process_next_line, do_define_command):
1623         Add NULL for new default_args lookup_cmd argument.
1624         * command.h: Declare new default_args argument in lookup_cmd
1625         and lookup_cmd_1.
1626         * completer.c (complete_line_internal_1):
1627         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
1628         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1629         * guile/scm-param.c (add_setshow_generic, pascm_parameter_defined_p):
1630         Likewise.
1631         * infcmd.c (_initialize_infcmd): Likewise.
1632         * python/py-auto-load.c (gdbpy_initialize_auto_load): Likewise.
1633         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1634         * python/py-param.c (add_setshow_generic): Likewise.
1635         * remote.c (_initialize_remote): Likewise.
1636         * top.c (execute_command): Prepend default_args if command has some.
1637         (set_verbose):
1638         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
1639         * tracepoint.c (validate_actionline, encode_actions_1):
1640         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
1641
1642 2020-06-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1643
1644         * jit.c (jit_read_descriptor): Use bool as the return type.
1645         (jit_breakpoint_re_set_internal): Use bool as the return type.
1646         Invert the return value logic; return true if the jit breakpoint
1647         has been successfully initialized.
1648         (jit_inferior_init): Update the call to
1649         jit_breakpoint_re_set_internal.
1650
1651 2020-06-22  Pedro Alves  <palves@redhat.com>
1652
1653         PR gdb/25939
1654         * procfs.c (procfs_target::wait): Don't reference inferior_ptid.
1655         Use the current inferior instead.  Don't return
1656         TARGET_WAITKIND_SPURIOUS/inferior_ptid -- instead continue and
1657         wait again.
1658         * sol-thread.c (sol_thread_target::wait): Don't reference
1659         inferior_ptid.
1660         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, ps_lsetfpregs)
1661         (sol_update_thread_list_callback): Use the current inferior's pid
1662         instead of inferior_ptid.
1663
1664 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1665
1666         * procfs.c: Cleanup many comments.
1667
1668         (READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG)
1669         (AFTER_WATCHFLAG): Replace by value.
1670
1671         (MAIN_PROC_NAME_FORMAT): Inline ...
1672         (create_procinfo): ... here.
1673
1674         (procfs_debug_inferior): Remove SYS_exec handling.
1675         (syscall_is_exec): Likewise.
1676         (procfs_set_exec_trap): Likewise.
1677
1678         (syscall_is_lwp_exit): Inline in callers.
1679         (syscall_is_exit): Likewise.
1680         (syscall_is_exec): Likewise.
1681         (syscall_is_lwp_create): Likewise.
1682
1683         (invalidate_cache): Remove #if 0 code.
1684
1685         (make_signal_thread_runnable):  Remove.
1686         (procfs_target::resume): Remove #if 0 code.
1687
1688 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1689
1690         PR gdb/25939
1691         * procfs.c (procfs_target::procfs_init_inferior): Move push_target
1692         call ...
1693         (procfs_target::create_inferior): ... here.
1694
1695 2020-06-21  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1696
1697         * exec.c (validate_exec_file): Ensure the build-id is up to
1698         date by calling reopen_exec_file (that checks file timestamp
1699         to decide to re-read the file).
1700
1701 2020-06-18  Pedro Alves  <palves@redhat.com>
1702
1703         PR gdb/25412
1704         * gdbthread.h (delete_thread, delete_thread_silent)
1705         (find_thread_ptid): Update comments.
1706         * thread.c (current_thread_): New global.
1707         (is_current_thread): Move higher, and reimplement.
1708         (inferior_thread): Reimplement.
1709         (set_thread_exited): Use bool.  Add assertions.
1710         (add_thread_silent): Simplify thread-reuse handling by always
1711         calling delete_thread.
1712         (delete_thread): Remove intro comment.
1713         (find_thread_ptid): Skip exited threads.
1714         (switch_to_thread_no_regs): Write to current_thread_.
1715         (switch_to_no_thread): Check CURRENT_THREAD_ instead of
1716         INFERIOR_PTID.  Clear current_thread_.
1717
1718 2020-06-18  Pedro Alves  <palves@redhat.com>
1719
1720         * aix-thread.c (pd_update): Use switch_to_thread.
1721
1722 2020-06-18  Pedro Alves  <palves@redhat.com>
1723
1724         * ravenscar-thread.c (ravenscar_thread_target): Update.
1725         (ravenscar_thread_target::update_inferior_ptid): Rename to ...
1726         (ravenscar_thread_target::add_active_thread): ... this.  Don't
1727         set m_base_ptid here.  Update to avoid referencing inferior_ptid.
1728         (ravenscar_thread_target::wait): Don't write to inferior_ptid.
1729
1730 2020-06-18  Pedro Alves  <palves@redhat.com>
1731
1732         * nat/windows-nat.c (current_windows_thread): Remove.
1733         * nat/windows-nat.h (current_windows_thread): Remove.
1734         * windows-nat.c (windows_nat_target::stopped_by_sw_breakpoint):
1735         Adjust.
1736         (display_selectors): Adjust to fetch the current
1737         windows_thread_info based on inferior_ptid.
1738         (fake_create_process): No longer write to current_windows_thread.
1739         (windows_nat_target::get_windows_debug_event):
1740         Don't set inferior_ptid or current_windows_thread.
1741         (windows_nat_target::wait): Adjust to not rely on
1742         current_windows_thread.
1743         (do_initial_windows_stuff): Now a method of windows_nat_target.
1744         Switch to the last_ptid thread.
1745         (windows_nat_target::attach): Adjust.
1746         (windows_nat_target::detach): Use switch_to_no_thread instead of
1747         writing to inferior_ptid directly.
1748         (windows_nat_target::create_inferior): Adjust.
1749
1750 2020-06-18  Pedro Alves  <palves@redhat.com>
1751
1752         * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid.
1753
1754 2020-06-18  Pedro Alves  <palves@redhat.com>
1755
1756         * go32-nat.c (go32_nat_target::create_inferior): Switch to thread
1757         after creating it, instead of writing to inferior_ptid.  Don't
1758         write to inferior_ptid.
1759
1760 2020-06-18  Pedro Alves  <palves@redhat.com>
1761
1762         * fork-child.c (postfork_hook): Don't write to inferior_ptid.
1763
1764 2020-06-18  Pedro Alves  <palves@redhat.com>
1765
1766         * bsd-kvm.c (bsd_kvm_target_open): Switch to thread after adding
1767         it, instead of writing to inferior_ptid.
1768
1769 2020-06-18  Pedro Alves  <palves@redhat.com>
1770
1771         * btrace.c (btrace_fetch): Use switch_to_thread instead of writing
1772         to inferior_ptid.
1773
1774 2020-06-18  Pedro Alves  <palves@redhat.com>
1775
1776         * bsd-kvm.c (bsd_kvm_target::close): Use switch_to_no_thread
1777         instead of writing to inferior_ptid directly.
1778
1779 2020-06-18  Pedro Alves  <palves@redhat.com>
1780
1781         * corelow.c (core_target::close): Use switch_to_no_thread instead
1782         of writing to inferior_ptid directly.
1783         (add_to_thread_list, core_target_open): Use switch_to_thread
1784         instead of writing to inferior_ptid directly.
1785
1786 2020-06-18  Pedro Alves  <palves@redhat.com>
1787
1788         * darwin-nat.c (darwin_nat_target::decode_message): Don't write to
1789         inferior_ptid.
1790         (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid
1791         inferior_ptid.
1792         (darwin_attach_pid): Use switch_to_no_thread instead of writing to
1793         inferior_ptid directly.
1794         (darwin_nat_target::init_thread_list): Switch to thread, instead
1795         of writing to inferior_ptid.
1796         (darwin_nat_target::attach): Don't write to inferior_ptid.
1797         (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid.
1798
1799 2020-06-18  Pedro Alves  <palves@redhat.com>
1800
1801         * gnu-nat.c (gnu_nat_target::create_inferior): Switch to the added
1802         thread.
1803         (gnu_nat_target::attach): Don't write to inferior_ptid directly.
1804         Instead use switch_to_thread.
1805         (gnu_nat_target::detach): Use switch_to_no_thread
1806         instead of writing to inferior_ptid directly.  Used passed-in
1807         inferior instead of looking up the inferior by pid.
1808
1809 2020-06-18  Pedro Alves  <palves@redhat.com>
1810
1811         * go32-nat.c (go32_nat_target::create_inferior): Don't write to
1812         inferior_ptid.
1813
1814 2020-06-18  Pedro Alves  <palves@redhat.com>
1815
1816         * nto-procfs.c (nto_procfs_target::update_thread_list): Avoid
1817         inferior_ptid.
1818         (nto_procfs_target::attach): Avoid inferior_ptid.  Switch to
1819         thread.
1820         (nto_procfs_target::detach): Avoid referencing
1821         inferior_ptid.  Use switch_to_no_thread instead of writing to
1822         inferior_ptid directly.
1823         (nto_procfs_target::mourn_inferior): Use switch_to_no_thread
1824         instead of writing to inferior_ptid directly.
1825         (nto_procfs_target::create_inferior): Avoid inferior_ptid.  Switch
1826         to thread.
1827
1828 2020-06-18  Pedro Alves  <palves@redhat.com>
1829
1830         * remote-sim.c (gdbsim_target::create_inferior): Switch to thread
1831         after creating it, instead of writing to inferior_ptid.
1832         (gdbsim_target_open): Use switch_to_no_thread instead of writing
1833         to inferior_ptid directly.
1834         (gdbsim_target::wait): Don't write to inferior_ptid.
1835
1836 2020-06-18  Pedro Alves  <palves@redhat.com>
1837
1838         * remote.c (remote_target::remote_notice_new_inferior): Use
1839         switch_to_thread instead of writing to inferior_ptid directly.
1840         (remote_target::add_current_inferior_and_thread): Use
1841         switch_to_no_thread instead of writing to inferior_ptid directly.
1842         (extended_remote_target::attach): Use switch_to_inferior_no_thread
1843         and switch_to_thread instead of using set_current_inferior or
1844         writing to inferior_ptid directly.
1845
1846 2020-06-18  Pedro Alves  <palves@redhat.com>
1847
1848         * tracectf.c (ctf_target_open): Switch to added thread instead of
1849         writing to inferior_ptid directly.
1850         (ctf_target::close): Use switch_to_no_thread instead of writing to
1851         inferior_ptid directly.
1852
1853 2020-06-18  Pedro Alves  <palves@redhat.com>
1854
1855         * tracefile-tfile.c (tfile_target_open): Don't write to
1856         inferior_ptid directly, instead switch to added thread.
1857         (tfile_target::close): Use switch_to_no_thread instead of writing
1858         to inferior_ptid directly.
1859
1860 2020-06-18  Pedro Alves  <palves@redhat.com>
1861
1862         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
1863         (procfs_target::detach): Use switch_to_no_thread
1864         instead of writing to inferior_ptid directly.
1865         (do_attach): Change return type to void.  Switch to the added
1866         thread.
1867         (procfs_target::create_inferior): Switch to the added thread.
1868         (procfs_do_thread_registers): Don't write to inferior_ptid.
1869
1870 2020-06-18  Pedro Alves  <palves@redhat.com>
1871
1872         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
1873         of writing to inferior_ptid.
1874         (scoped_restore_exited_inferior): Delete.
1875         (handle_vfork_child_exec_or_exit): Simplify using
1876         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
1877         instead of writing to inferior_ptid.
1878         (THREAD_STOPPED_BY): Delete.
1879         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
1880         (thread_stopped_by_hw_breakpoint): Delete.
1881         (save_waitstatus): Use
1882         scoped_restore_current_thread+switch_to_thread, and call
1883         target_stopped_by_watchpoint instead of
1884         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
1885         instead of thread_stopped_by_sw_breakpoint, and
1886         target_stopped_by_hw_breakpoint instead of
1887         thread_stopped_by_hw_breakpoint.
1888         (handle_inferior_event)
1889         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
1890         inferior_ptid directly, nor
1891         set_current_inferior/set_current_program_space.  Use
1892         switch_to_thread / switch_to_inferior_no_thread instead.
1893
1894 2020-06-18  Pedro Alves  <palves@redhat.com>
1895
1896         * target.c (generic_mourn_inferior): Use switch_to_no_thread
1897         instead of writing to inferior_ptid.
1898
1899 2020-06-18  Pedro Alves  <palves@redhat.com>
1900
1901         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
1902         added thread.
1903         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
1904         to the added thread.
1905         (inf_ptrace_target::detach_success): Use switch_to_no_thread
1906         instead of writing to inferior_ptid.
1907
1908 2020-06-18  Pedro Alves  <palves@redhat.com>
1909
1910         * gdbarch-selftests.c: Include "progspace-and-thread.h".
1911         (register_to_value_test): Mock a program_space too.  Heap-allocate
1912         the address space.  Don't write to inferior_ptid.  Use
1913         switch_to_thread instead.
1914
1915 2020-06-18  Pedro Alves  <palves@redhat.com>
1916
1917         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
1918         Delete.
1919         (find_signalled_thread()): New, factored out from
1920         linux_make_corefile_notes and adjusted to handle exited threads.
1921         (linux_make_corefile_notes): Adjust to use the new
1922         find_signalled_thread.
1923
1924 2020-06-18  Pedro Alves  <palves@redhat.com>
1925
1926         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
1927         of saving/restoring inferior_ptid.
1928
1929 2020-06-17  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
1932         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
1933         declare.
1934         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
1935
1936 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
1937
1938         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
1939         of partial symtabs.
1940
1941 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
1942
1943         * regformats/reg-arm.dat: Remove.
1944         * regformats/reg-bfin.dat: Remove.
1945         * regformats/reg-cris.dat: Remove.
1946         * regformats/reg-crisv32.dat: Remove.
1947         * regformats/reg-m32r.dat: Remove.
1948         * regformats/reg-tilegx.dat: Remove.
1949         * regformats/reg-tilegx32.dat: Remove.
1950
1951 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
1952
1953         * features/Makefile (WHICH): Remove arm files.
1954         * regformats/arm/arm-with-iwmmxt.dat: Remove.
1955         * regformats/arm/arm-with-neon.dat: Remove.
1956         * regformats/arm/arm-with-vfpv2.dat: Remove.
1957         * regformats/arm/arm-with-vfpv3.dat: Remove.
1958
1959 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
1960
1961         * features/Makefile (XMLTOC): Remove rx.xml.
1962
1963 2020-06-17  Pedro Alves  <palves@redhat.com>
1964
1965         * gdbthread.h (thread_control_state) <trap_expected> Update
1966         comments.
1967
1968 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1969
1970         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
1971         ada_language::lookup_symbol_nonlocal.
1972         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
1973         (ada_language::lookup_symbol_nonlocal): New member function,
1974         implementation from ada_lookup_symbol_nonlocal.
1975         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
1976         initializer.
1977         (cplus_language_data): Delete la_lookup_symbol_nonlocal
1978         initializer.
1979         (cplus_language::lookup_symbol_nonlocal): New member function.
1980         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
1981         (minimal_language_data) Likewise.
1982         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
1983         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
1984         initializer.
1985         (d_language::lookup_symbol_nonlocal): New member function.
1986         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
1987         initializer.
1988         (f_language::lookup_symbol_nonlocal): New member function.
1989         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
1990         initializer.
1991         * language.c (unknown_language_data): Likewise.
1992         (auto_language_data): Likewise.
1993         * language.h (language_data): Delete la_lookup_symbol_nonlocal
1994         field.
1995         (language_defn::lookup_symbol_nonlocal): New member function.
1996         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
1997         initializer.
1998         * objc-lang.c (objc_language_data): Likewise.
1999         * opencl-lang.c (opencl_language_data): Likewise.
2000         * p-lang.c (pascal_language_data): Likewise.
2001         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
2002         rust_language::lookup_symbol_nonlocal.
2003         (rust_language_data): Delete la_lookup_symbol_nonlocal
2004         initializer.
2005         (rust_language::lookup_symbol_nonlocal): New member function,
2006         implementation from rust_lookup_symbol_nonlocal.
2007         * symtab.c (lookup_symbol_aux): Update call to
2008         lookup_symbol_nonlocal.
2009         (basic_lookup_symbol_nonlocal): Rename to...
2010         (language_defn::lookup_symbol_nonlocal): ...this, and update
2011         header comment.  Remove language_defn parameter, and replace with
2012         uses of `this'.
2013         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
2014
2015 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2016
2017         * ada-lang.c (ada_language_data): Delete la_value_print_inner
2018         initializer.
2019         (ada_language::value_print_inner): New member function.
2020         * c-lang.c (c_language_data): Delete la_value_print_inner
2021         initializer.
2022         (cplus_language_data): Likewise.
2023         (asm_language_data): Likewise.
2024         (minimal_language_data): Likewise.
2025         * d-lang.c (d_language_data): Likewise.
2026         (d_language::value_print_inner): New member function.
2027         * f-lang.c (f_language_data): Delete la_value_print_inner
2028         initializer.
2029         (f_language::value_print_inner): New member function.
2030         * f-lang.h (f_value_print_innner): Rename to...
2031         (f_value_print_inner): ...this (note spelling of 'inner').
2032         * f-valprint.c (f_value_print_innner): Rename to...
2033         (f_value_print_inner): ...this (note spelling of 'inner').
2034         * go-lang.c (go_language_data): Delete la_value_print_inner
2035         initializer.
2036         (go_language::value_print_inner): New member function.
2037         * language.c (language_defn::value_print_inner): Define new member
2038         function.
2039         (unk_lang_value_print_inner): Delete.
2040         (unknown_language_data): Delete la_value_print_inner initializer.
2041         (unknown_language::value_print_inner): New member function.
2042         (auto_language_data): Delete la_value_print_inner initializer.
2043         (auto_language::value_print_inner): New member function.
2044         * language.h (language_data): Delete la_value_print_inner field.
2045         (language_defn::value_print_inner): Delcare new member function.
2046         * m2-lang.c (m2_language_data): Delete la_value_print_inner
2047         initializer.
2048         (m2_language::value_print_inner): New member function.
2049         * objc-lang.c (objc_language_data): Delete la_value_print_inner
2050         initializer.
2051         * opencl-lang.c (opencl_language_data): Likewise.
2052         * p-lang.c (pascal_language_data): Likewise.
2053         (pascal_language::value_print_inner): New member function.
2054         * rust-lang.c (rust_language_data): Delete la_value_print_inner
2055         initializer.
2056         (rust_language::value_print_inner): New member function.
2057         * valprint.c (do_val_print): Update call to value_print_inner.
2058
2059 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2060
2061         * ada-lang.c (ada_language_data): Delete la_value_print
2062         initializer.
2063         (ada_language::value_print): New member function.
2064         * c-lang.c (c_language_data): Delete la_value_print initializer.
2065         (cplus_language_data): Likewise.
2066         (asm_language_data): Likewise.
2067         (minimal_language_data): Likewise.
2068         * d-lang.c (d_language_data): Likewise.
2069         * f-lang.c (f_language_data): Likewise.
2070         * go-lang.c (go_language_data): Likewise.
2071         * language.c (unk_lang_value_print): Delete.
2072         (language_defn::value_print): Define new member function.
2073         (unknown_language_data): Delete la_value_print initializer.
2074         (unknown_language::value_print): New member function.
2075         (auto_language_data): Delete la_value_print initializer.
2076         (auto_language::value_print): New member function.
2077         * language.h (language_data): Delete la_value_print field.
2078         (language_defn::value_print): Declare new member function.
2079         (LA_VALUE_PRINT): Update call to value_print.
2080         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
2081         * objc-lang.c (objc_language_data): Likewise.
2082         * opencl-lang.c (opencl_language_data): Likewise.
2083         * p-lang.c (pascal_language_data): Likewise.
2084         (pascal_language::value_print): New member function.
2085         * rust-lang.c (rust_language_data): Delete la_value_print
2086         initializer.
2087
2088 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2089
2090         * ada-lang.c (ada_watch_location_expression): Rename to
2091         ada_language::watch_location_expression.
2092         (ada_language_data): Delete la_watch_location_expression
2093         initializer.
2094         (ada_language::watch_location_expression): New member function,
2095         implementation from ada_watch_location_expression.
2096         * breakpoint.c (watch_command_1): Update call to
2097         watch_location_expression.
2098         * c-lang.c (c_watch_location_expression): Rename to
2099         language_defn::watch_location_expression.
2100         (c_language_data): Delete la_watch_location_expression
2101         initializer.
2102         (cplus_language_data): Likewise.
2103         (asm_language_data): Likewise.
2104         (minimal_language_data): Likewise.
2105         * c-lang.h (c_watch_location_expression): Delete declaration.
2106         * d-lang.c (d_language_data): Delete la_watch_location_expression
2107         initializer.
2108         * f-lang.c (f_language_data): Likewise.
2109         * go-lang.c (go_language_data): Likewise.
2110         * language.c (language_defn::watch_location_expression): Member
2111         function implementation from c_watch_location_expression.
2112         (unknown_language_data): Delete la_watch_location_expression
2113         initializer.
2114         (auto_language_data): Likewise.
2115         * language.h (language_data): Delete la_watch_location_expression
2116         field.
2117         (language_defn::watch_location_expression): Declare new member
2118         function.
2119         * m2-lang.c (m2_language_data): Delete
2120         la_watch_location_expression initializer.
2121         * objc-lang.c (objc_language_data): Likewise.
2122         * opencl-lang.c (opencl_language_data): Likewise.
2123         * p-lang.c (pascal_language_data): Likewise.
2124         * rust-lang.c (rust_watch_location_expression): Rename to
2125         rust_language::watch_location_expression.
2126         (rust_language_data): Delete la_watch_location_expression
2127         initializer.
2128         (rust_language::watch_location_expression): New member function,
2129         implementation from rust_watch_location_expression.
2130
2131 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2132
2133         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
2134         ada_language::collect_symbol_completion_matches.
2135         (ada_language_data): Delete la_collect_symbol_completion_matches
2136         initializer.
2137         (ada_language::collect_symbol_completion_matches): New member
2138         function, implementation from
2139         ada_collect_symbol_completion_matches.
2140         * c-lang.c (c_language_data): Delete
2141         la_collect_symbol_completion_matches initializer.
2142         (cplus_language_data): Likewise.
2143         (asm_language_data): Likewise.
2144         (minimal_language_data): Likewise.
2145         * d-lang.c (d_language_data): Likewise.
2146         * f-lang.c (f_collect_symbol_completion_matches): Rename to
2147         f_language::collect_symbol_completion_matches.
2148         (f_language_data): Delete la_collect_symbol_completion_matches
2149         initializer.
2150         (f_language::collect_symbol_completion_matches) New member
2151         function, implementation from f_collect_symbol_completion_matches.
2152         * go-lang.c (go_language_data): Delete
2153         la_collect_symbol_completion_matches initializer.
2154         * language.c (unknown_language_data): Likewise.
2155         (auto_language_data): Likewise.
2156         * language.h (language_data): Delete
2157         la_collect_symbol_completion_matches field.
2158         (language_defn::collect_symbol_completion_matches): New member
2159         function.
2160         * m2-lang.c (m2_language_data): Delete
2161         la_collect_symbol_completion_matches initializer.
2162         * objc-lang.c (objc_language_data): Likewise.
2163         * opencl-lang.c (opencl_language_data): Likewise.
2164         * p-lang.c (pascal_language_data): Likewise.
2165         * rust-lang.c (rust_language_data): Likewise.
2166         * symtab.c (default_collect_symbol_completion_matches): Delete.
2167         (collect_symbol_completion_matches): Update call to
2168         collect_symbol_completion_matches.
2169         (collect_symbol_completion_matches_type): Likewise.
2170         * symtab.h (default_collect_symbol_completion_matches): Delete
2171         declaration.
2172
2173 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2174
2175         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
2176         (ada_language_data): Delete la_word_break_characters initializer.
2177         (ada_language::word_break_characters): New member function.
2178         * c-lang.c (c_language_data): Delete la_word_break_characters
2179         initializer.
2180         (cplus_language_data): Likewise.
2181         (asm_language_data): Likewise.
2182         (minimal_language_data): Likewise.
2183         * completer.c: Update global comment.
2184         (advance_to_expression_complete_word_point): Update call to
2185         word_break_characters.
2186         (complete_files_symbols): Likewise.
2187         (complete_line_internal_1): Likewise.
2188         (default_completer_handle_brkchars): Likewise.
2189         (skip_quoted_chars): Likewise.
2190         * d-lang.c (d_language_data): Delete la_word_break_characters
2191         initializer.
2192         * f-lang.c (f_word_break_characters): Delete.
2193         (f_language_data): Delete la_word_break_characters initializer.
2194         (f_language::word_break_characters): New member function.
2195         * go-lang.c (go_language_data): Delete la_word_break_characters
2196         initializer.
2197         * language.c (unknown_language_data): Likewise.
2198         (auto_language_data): Likewise.
2199         * language.h (default_word_break_characters): Move declaration to
2200         earlier in the file.
2201         (language_data): Delete la_word_break_characters field.
2202         (language_defn::word_break_characters): New member function.
2203         * m2-lang.c (m2_language_data): Delete la_word_break_characters
2204         initializer.
2205         * objc-lang.c (objc_language_data): Likewise.
2206         * opencl-lang.c (opencl_language_data): Likewise.
2207         * p-lang.c (pascal_language_data): Likewise.
2208         * rust-lang.c (rust_language_data): Likewise.
2209
2210 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2211
2212         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
2213         (ada_language_data): Delete la_get_symbol_name_matcher
2214         initializer.
2215         (language_defn::get_symbol_name_matcher_inner): New member
2216         function.
2217         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
2218         initializer.
2219         (cplus_language_data): Likewise.
2220         (cplus_language::get_symbol_name_matcher_inner): New member
2221         function.
2222         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
2223         (minimal_language_data): Likewise.
2224         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
2225         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
2226         initializer.
2227         * dictionary.c (iter_match_first_hashed): Update call to
2228         get_symbol_name_matcher.
2229         (iter_match_next_hashed): Likewise.
2230         (iter_match_next_linear): Likewise.
2231         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
2232         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
2233         initializer.
2234         (f_language::get_symbol_name_matcher_inner): New member function.
2235         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
2236         initializer.
2237         * language.c (default_symbol_name_matcher): Update header comment,
2238         make static.
2239         (language_defn::get_symbol_name_matcher): New definition.
2240         (language_defn::get_symbol_name_matcher_inner): Likewise.
2241         (get_symbol_name_matcher): Delete.
2242         (unknown_language_data): Delete la_get_symbol_name_matcher
2243         initializer.
2244         (auto_language_data): Likewise.
2245         * language.h (language_data): Delete la_get_symbol_name_matcher
2246         field.
2247         (language_defn::get_symbol_name_matcher): New member function.
2248         (language_defn::get_symbol_name_matcher_inner): Likewise.
2249         (default_symbol_name_matcher): Delete declaration.
2250         * linespec.c (find_methods): Update call to
2251         get_symbol_name_matcher.
2252         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
2253         initializer.
2254         * minsyms.c (lookup_minimal_symbol): Update call to
2255         get_symbol_name_matcher.
2256         (iterate_over_minimal_symbols): Likewise.
2257         * objc-lang.c (objc_language_data): Delete
2258         la_get_symbol_name_matcher initializer.
2259         * opencl-lang.c (opencl_language_data): Likewise.
2260         * p-lang.c (pascal_language_data): Likewise.
2261         * psymtab.c (psymbol_name_matches): Update call to
2262         get_symbol_name_matcher.
2263         * rust-lang.c (rust_language_data): Delete
2264         la_get_symbol_name_matcher initializer.
2265         * symtab.c (symbol_matches_search_name): Update call to
2266         get_symbol_name_matcher.
2267         (compare_symbol_name): Likewise.
2268
2269 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2270
2271         * ada-lang.c (ada_language_data): Delete la_compute_program
2272         initializer.
2273         * c-lang.c (c_language_data): Likewise.
2274         (c_language::compute_program): New member function.
2275         (cplus_language_data): Delete la_compute_program initializer.
2276         (cplus_language::compute_program): New member function.
2277         (asm_language_data): Delete la_compute_program initializer.
2278         (minimal_language_data): Likewise.
2279         * c-lang.h (c_compute_program): Update comment.
2280         (cplus_compute_program): Likewise.
2281         * compile/compile-c-support.c (c_compute_program): Likewise.
2282         (cplus_compute_program): Likewise.
2283         * compile/compile.c (compile_to_object): Update call to
2284         la_compute_program.
2285         * d-lang.c (d_language_data): Delete la_compute_program
2286         initializer.
2287         * f-lang.c (f_language_data): Likewise.
2288         * go-lang.c (go_language_data): Likewise.
2289         * language.c (unknown_language_data): Likewise.
2290         (auto_language_data): Likewise.
2291         * language.h (language_data): Delete la_compute_program field.
2292         (language_defn::compute_program): New member function.
2293         * m2-lang.c (m2_language_data): Delete la_compute_program
2294         initializer.
2295         * objc-lang.c (objc_language_data): Likewise.
2296         * opencl-lang.c (opencl_language_data): Likewise.
2297         * p-lang.c (pascal_language_data): Likewise.
2298         * rust-lang.c (rust_language_data): Likewise.
2299
2300 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         * ada-lang.c (ada_language_data) Delete
2303         la_class_name_from_physname initializer.
2304         * c-lang.c (c_language_data): Likewise.
2305         (cplus_language_data): Likewise.
2306         (cplus_language::class_name_from_physname): New member function.
2307         (asm_language_data): Delete la_class_name_from_physname
2308         initializer.
2309         (minimal_language_data): Likewise.
2310         * d-lang.c (d_language_data): Likewise.
2311         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
2312         method on language_defn class.
2313         (guess_full_die_structure_name): Likewise.
2314         * f-lang.c (f_language_data): Delete la_class_name_from_physname
2315         initializer.
2316         * go-lang.c (go_language_data): Likewise.
2317         * language.c (language_class_name_from_physname): Delete.
2318         (unk_lang_class_name): Delete.
2319         (unknown_language_data): Delete la_class_name_from_physname
2320         initializer.
2321         (auto_language_data): Likewise.
2322         * language.h (language_data): Delete la_class_name_from_physname
2323         field.
2324         (language_defn::class_name_from_physname): New function.
2325         (language_class_name_from_physname): Delete declaration.
2326         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
2327         initializer.
2328         * objc-lang.c (objc_language_data): Likewise.
2329         * opencl-lang.c (opencl_language_data): Likewise.
2330         * p-lang.c (pascal_language_data): Likewise.
2331         * rust-lang.c (rust_language_data): Likewise.
2332
2333 2020-06-16  Tom Tromey  <tom@tromey.com>
2334
2335         * tui/tui-data.h (STATUS_NAME): New macro.
2336         * tui/tui-layout.c (tui_remove_some_windows)
2337         (initialize_known_windows, tui_register_window)
2338         (tui_layout_split::remove_windows, initialize_layouts)
2339         (tui_new_layout_command): Don't use hard-coded window names.
2340
2341 2020-06-16  Tom Tromey  <tom@tromey.com>
2342
2343         PR tui/25348:
2344         * tui/tui.c (tui_ensure_readline_initialized): Rename from
2345         tui_initialize_readline.  Only run once.  Call rl_initialize.
2346         * tui/tui.h (tui_ensure_readline_initialized): Rename from
2347         tui_initialize_readline.
2348         * tui/tui-io.c (tui_setup_io): Call
2349         tui_ensure_readline_initialized.
2350         * tui/tui-interp.c (tui_interp::init): Update.
2351
2352 2020-06-16  Tom Tromey  <tom@tromey.com>
2353
2354         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
2355         Also preserve the status window.
2356
2357 2020-06-16  Tom Tromey  <tom@tromey.com>
2358
2359         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
2360         where m_window==nullptr.
2361
2362 2020-06-15  Tom Tromey  <tromey@adacore.com>
2363
2364         * windows-nat.c (windows_nat::handle_output_debug_string):
2365         Update.
2366         (windows_nat::handle_ms_vc_exception): Update.
2367         * target.h (target_read_string): Change API.
2368         * target.c (target_read_string): Change API.
2369         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
2370         Update.
2371         * solib-frv.c (frv_current_sos): Update.
2372         * solib-dsbt.c (dsbt_current_sos): Update.
2373         * solib-darwin.c (darwin_current_sos): Update.
2374         * linux-thread-db.c (inferior_has_bug): Update.
2375         * expprint.c (print_subexp_standard): Update.
2376         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
2377         (ada_exception_message_1): Update.
2378
2379 2020-06-15  Tom Tromey  <tromey@adacore.com>
2380
2381         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
2382
2383 2020-06-15  Tom Tromey  <tromey@adacore.com>
2384
2385         * valprint.c (read_string): Update comment.
2386         * target.c (MIN): Remove.
2387         (target_read_string): Rewrite.
2388
2389 2020-06-15  Tom Tromey  <tromey@adacore.com>
2390
2391         * corefile.c (read_memory_string): Remove.
2392         * ada-valprint.c (ada_value_print_ptr): Update.
2393         * ada-lang.h (ada_tag_name): Change return type.
2394         * ada-lang.c (type_from_tag): Update.
2395         (ada_tag_name_from_tsd): Change return type.  Use
2396         target_read_string.
2397         (ada_tag_name): Likewise.
2398         * gdbcore.h (read_memory_string): Don't declare.
2399
2400 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
2401
2402         * symtab.c (rbreak_command): Ignore Windows drive colon.
2403
2404 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
2405
2406         * NEWS: Mention removed GDBserver host support.
2407
2408 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
2409
2410         * features/riscv/rebuild-csr-xml.sh: Updated.
2411
2412 2020-06-11  Tom Tromey  <tom@tromey.com>
2413
2414         PR gdb/18318:
2415         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
2416
2417 2020-06-09  Jonny Grant  <jg@jguk.org>
2418 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
2419
2420         * main.c (captured_main_1): Don't print new line after help.
2421         (print_gdb_help): add mailing list and IRC channel information
2422         to --help.  Add new lines between items in the footer.  Remove
2423         quotes around bug url.
2424
2425 2020-06-11  Keith Seitz  <keiths@redhat.com>
2426
2427         PR gdb/21356
2428         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
2429         Resolve typedefs for type length calculations.
2430
2431 2020-06-10  Tom de Vries  <tdevries@suse.de>
2432
2433         PR ada/24713
2434         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
2435         (write_psymbols): Enable .gdb_index for ada.
2436         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
2437         ada.
2438
2439 2020-06-10  Tom de Vries  <tdevries@suse.de>
2440
2441         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
2442         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
2443         namei" instead of "const char *name" argument.
2444         (dw2_map_matching_symbols): Use "offset_type namei" variant of
2445         dw2_symtab_iter_init.
2446
2447 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
2448
2449         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
2450         to use type::field and field::type instead.
2451
2452 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
2453
2454         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
2455         to use field::type instead.
2456
2457 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
2458
2459         * gdbtypes.h (struct field) <type, set_type>: New methods.
2460         Rename `type` field to...
2461         <m_type>: ... this.  Change references throughout to use type or
2462         set_type methods.
2463         (FIELD_TYPE): Use field::type.  Change call sites that modify
2464         the field's type to use field::set_type instead.
2465
2466 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
2467
2468         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
2469         to use type::index_type instead.
2470
2471 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
2472
2473         * gdbtypes.h (struct type) <index_type, set_index_type>: New
2474         methods.
2475         (TYPE_INDEX_TYPE): Use type::index_type.
2476         * gdbtypes.c (create_array_type_with_stride): Likewise.
2477
2478 2020-06-07  Tom Tromey  <tom@tromey.com>
2479
2480         * valprint.c (generic_val_print_float): Remove "embedded_offset"
2481         parameter.
2482         (generic_value_print): Update.
2483
2484 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2485
2486         Revert commit 982a38f60b0.
2487         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
2488
2489 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2490
2491         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
2492         avoid use after free.
2493
2494 2020-06-05  Tom de Vries  <tdevries@suse.de>
2495
2496         * NEWS: Fix typos.
2497
2498 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
2499
2500         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
2501         the per_bfd object.
2502         (dwarf2_read_debug_names): Likewise.
2503         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
2504         object when re-using a per_bfd object with an index.
2505
2506 2020-06-03  Tom de Vries  <tdevries@suse.de>
2507
2508         PR symtab/26046
2509         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
2510         children for C++.
2511         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
2512         DW_TAG_subprogram.
2513
2514 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * ada-lang.c (ada_language_data): Delete skip_trampoline
2517         initializer.
2518         * c-lang.c (c_language_data): Likewise.
2519         (cplus_language_data): Likewise.
2520         (cplus_language::skip_trampoline): New member function.
2521         (asm_language_data): Delete skip_trampoline initializer.
2522         (minimal_language_data): Likewise.
2523         * d-lang.c (d_language_data): Likewise.
2524         * f-lang.c (f_language_data): Likewise.
2525         * go-lang.c (go_language_data): Likewise.
2526         * language.c (unk_lang_trampoline): Delete function.
2527         (skip_language_trampoline): Update.
2528         (unknown_language_data): Delete skip_trampoline initializer.
2529         (auto_language_data): Likewise.
2530         * language.h (language_data): Delete skip_trampoline field.
2531         (language_defn::skip_trampoline): New function.
2532         * m2-lang.c (m2_language_data): Delete skip_trampoline
2533         initializer.
2534         * objc-lang.c (objc_skip_trampoline): Delete function, move
2535         implementation to objc_language::skip_trampoline.
2536         (objc_language_data): Delete skip_trampoline initializer.
2537         (objc_language::skip_trampoline): New member function with
2538         implementation from objc_skip_trampoline.
2539         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
2540         initializer.
2541         * p-lang.c (pascal_language_data): Likewise.
2542         * rust-lang.c (rust_language_data): Likewise.
2543
2544 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2545
2546         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
2547         (ada_language::demangle): New member function.
2548         * c-lang.c (c_language_data): Delete la_demangle initializer.
2549         (cplus_language_data): Delete la_demangle initializer.
2550         (cplus_language::demangle): New member function.
2551         (asm_language_data): Delete la_demangle initializer.
2552         (minimal_language_data): Delete la_demangle initializer.
2553         * d-lang.c (d_language_data): Delete la_demangle initializer.
2554         (d_language::demangle): New member function.
2555         * f-lang.c (f_language_data): Delete la_demangle initializer.
2556         (f_language::demangle): New member function.
2557         * go-lang.c (go_language_data): Delete la_demangle initializer.
2558         (go_language::demangle): New member function.
2559         * language.c (language_demangle): Update.
2560         (unk_lang_demangle): Delete.
2561         (unknown_language_data): Delete la_demangle initializer.
2562         (unknown_language::demangle): New member function.
2563         (auto_language_data): Delete la_demangle initializer.
2564         (auto_language::demangle): New member function.
2565         * language.h (language_data): Delete la_demangle field.
2566         (language_defn::demangle): New function.
2567         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
2568         * objc-lang.c (objc_language_data): Delete la_demangle
2569         initializer.
2570         (objc_language::demangle): New member function.
2571         * opencl-lang.c (opencl_language_data): Delete la_demangle
2572         initializer.
2573         * p-lang.c (pascal_language_data): Likewise.
2574         * rust-lang.c (rust_language_data): Likewise.
2575         (rust_language::demangle): New member function.
2576
2577 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2578
2579         * ada-lang.c (ada_language_data): Delete la_print_type
2580         initializer.
2581         (ada_language::print_type): New member function.
2582         * c-lang.c (c_language_data): Delete la_print_type initializer.
2583         (c_language::print_type): New member function.
2584         (cplus_language_data): Delete la_print_type initializer.
2585         (cplus_language::print_type): New member function.
2586         (asm_language_data): Delete la_print_type initializer.
2587         (asm_language::print_type): New member function.
2588         (minimal_language_data): Delete la_print_type initializer.
2589         (minimal_language::print_type): New member function.
2590         * d-lang.c (d_language_data): Delete la_print_type initializer.
2591         (d_language::print_type): New member function.
2592         * f-lang.c (f_language_data): Delete la_print_type initializer.
2593         (f_language::print_type): New member function.
2594         * go-lang.c (go_language_data): Delete la_print_type initializer.
2595         (go_language::print_type): New member function.
2596         * language.c (unk_lang_print_type): Delete.
2597         (unknown_language_data): Delete la_print_type initializer.
2598         (unknown_language::print_type): New member function.
2599         (auto_language_data): Delete la_print_type initializer.
2600         (auto_language::print_type): New member function.
2601         * language.h (language_data): Delete la_print_type field.
2602         (language_defn::print_type): New function.
2603         (LA_PRINT_TYPE): Update.
2604         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
2605         (m2_language::print_type): New member function.
2606         * objc-lang.c (objc_language_data): Delete la_print_type
2607         initializer.
2608         (objc_language::print_type): New member function.
2609         * opencl-lang.c (opencl_print_type): Delete, implementation moved
2610         to opencl_language::print_type.
2611         (opencl_language_data): Delete la_print_type initializer.
2612         (opencl_language::print_type): New member function, implementation
2613         from opencl_print_type.
2614         * p-lang.c (pascal_language_data): Delete la_print_type
2615         initializer.
2616         (pascal_language::print_type): New member function.
2617         * rust-lang.c (rust_print_type): Delete, implementation moved to
2618         rust_language::print_type.
2619         (rust_language_data): Delete la_print_type initializer.
2620         (rust_language::print_type): New member function, implementation
2621         from rust_print_type.
2622
2623 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2624
2625         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
2626         implementation moves to...
2627         (ada_language::sniff_from_mangled_name): ...here.  Update return
2628         type.
2629         (ada_language_data): Delete la_sniff_from_mangled_name
2630         initializer.
2631         * c-lang.c (c_language_data): Likewise.
2632         (cplus_language_data): Likewise.
2633         (cplus_language::sniff_from_mangled_name): New member function,
2634         implementation taken from gdb_sniff_from_mangled_name.
2635         (asm_language_data): Delete la_sniff_from_mangled_name
2636         initializer.
2637         (minimal_language_data): Likewise.
2638         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
2639         implementation moves to cplus_language::sniff_from_mangled_name.
2640         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
2641         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
2642         moves to...
2643         (d_language::sniff_from_mangled_name): ...here.
2644         (d_language_data): Delete la_sniff_from_mangled_name initializer.
2645         * f-lang.c (f_language_data): Likewise.
2646         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
2647         moves to...
2648         (go_language::sniff_from_mangled_name): ...here.
2649         (go_language_data): Delete la_sniff_from_mangled_name initializer.
2650         * language.c (language_sniff_from_mangled_name): Delete.
2651         (unknown_language_data): Delete la_sniff_from_mangled_name
2652         initializer.
2653         (auto_language_data): Likewise.
2654         * language.h (language_data): Delete la_sniff_from_mangled_name
2655         field.
2656         (language_defn::sniff_from_mangled_name): New function.
2657         (language_sniff_from_mangled_name): Delete declaration.
2658         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
2659         field.
2660         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
2661         implementation moves to...
2662         (objc_language::sniff_from_mangled_name): ...here.
2663         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
2664         * opencl-lang.c (opencl_language_data): Likewise.
2665         * p-lang.c (pascal_language_data): Likewise.
2666         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
2667         implementation moves to...
2668         (rust_language::sniff_from_mangled_name): ...here.
2669         (rust_language_data): Delete la_sniff_from_mangled_name
2670         initializer.
2671         * symtab.c (symbol_find_demangled_name): Call
2672         sniff_from_mangled_name member function.
2673
2674 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2675
2676         * ada-lang.c (ada_language_data): Delete la_search_name_hash
2677         initializer.
2678         * c-lang.c (c_language_data): Likewise.
2679         (cplus_language_data): Likewise.
2680         (cplus_language::search_name_hash): New member function.
2681         (asm_language_data): Delete la_search_name_hash initializer.
2682         (minimal_language_data): Likewise.
2683         * d-lang.c (d_language_data): Likewise.
2684         * dictionary.c (default_search_name_hash): Rename to...
2685         (language_defn::search_name_hash): ...this.
2686         * f-lang.c (f_language_data): Likewise.
2687         (f_language::search_name_hash): New member function.
2688         * go-lang.c (go_language_data): Delete la_search_name_hash
2689         initializer.
2690         * language.c (unknown_language_data): Likewise.
2691         (auto_language_data): Likewise.
2692         * language.h (struct language_data): Delete la_search_name_hash
2693         field.
2694         (language_defn::search_name_hash): Declare new member function.
2695         (default_search_name_hash): Delete declaration.
2696         * m2-lang.c (m2_language_data): Delete la_search_name_hash
2697         initializer.
2698         * objc-lang.c (objc_language_data): Likewise.
2699         * opencl-lang.c (opencl_language_data): Likewise.
2700         * p-lang.c (pascal_language_data): Likewise.
2701         * rust-lang.c (rust_language_data): Likewise.
2702         * symtab.c (search_name_hash): Update call.
2703
2704 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2705
2706         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
2707         initializer.
2708         * c-lang.c (class compile_instance): Declare.
2709         (c_language_data): Delete la_get_compile_instance initializer.
2710         (c_language::get_compile_instance): New member function.
2711         (cplus_language_data): Delete la_get_compile_instance initializer.
2712         (cplus_language::get_compile_instance): New member function.
2713         (asm_language_data): Delete la_get_compile_instance initializer.
2714         (minimal_language_data): Likewise.
2715         * c-lang.h (c_get_compile_context): Update comment.
2716         (cplus_get_compile_context): Update comment.
2717         * compile/compile.c (compile_to_object): Update calls, don't rely
2718         on function pointer being NULL.
2719         * d-lang.c (d_language_data): Delete la_get_compile_instance
2720         initializer.
2721         * f-lang.c (f_language_data): Likewise.
2722         * go-lang.c (go_language_data): Likewise.
2723         * language.c (unknown_language_data): Likewise.
2724         (auto_language_data): Likewise.
2725         * language.h (language_data): Delete la_get_compile_instance field.
2726         (language_defn::get_compile_instance): New member function.
2727         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
2728         initializer.
2729         * objc-lang.c (objc_language_data): Likewise.
2730         * opencl-lang.c (opencl_language_data): Likewise.
2731         * p-lang.c (pascal_language_data): Likewise.
2732         * rust-lang.c (rust_language_data): Likewise.
2733
2734 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2735
2736         * ada-lang.c (ada_add_all_symbols): Update comment.
2737         (ada_iterate_over_symbols): Delete, move implementation to...
2738         (ada_language::iterate_over_symbols): ...here, a new member
2739         function, rewrite to use range based for loop.
2740         (ada_language_data): Delete la_iterate_over_symbols initializer.
2741         * c-lang.c (c_language_data): Likewise.
2742         (cplus_language_data): Likewise.
2743         (asm_language_data): Likewise.
2744         (minimal_language_data): Likewise.
2745         * d-lang.c (d_language_data): Likewise.
2746         * f-lang.c (f_language_data): Likewise.
2747         * go-lang.c (go_language_data): Likewise.
2748         * language.c (unknown_language_data): Likewise.
2749         (auto_language_data): Likewise.
2750         * language.h (language_data): Delete la_iterate_over_symbols field.
2751         (language_defn::iterate_over_symbols): New member function.
2752         (LA_ITERATE_OVER_SYMBOLS): Update.
2753         * linespec.c (iterate_over_all_matching_symtabs): Update.
2754         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
2755         initializer.
2756         * objc-lang.c (objc_language_data): Likewise.
2757         * opencl-lang.c (opencl_language_data): Likewise.
2758         * p-lang.c (pascal_language_data): Likewise.
2759         * rust-lang.c (rust_language_data): Likewise.
2760
2761 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2762
2763         * ada-lang.c (ada_language_data): Delete
2764         la_lookup_transparent_type initializer.
2765         * c-lang.c (c_language_data): Likewise.
2766         (cplus_language_data): Likewise.
2767         (cplus_language::lookup_transparent_type): New member function.
2768         (asm_language_data): Delete la_lookup_transparent_type
2769         initializer.
2770         (minimal_language_data): Likewise.
2771         * d-lang.c (d_language_data): Likewise.
2772         * f-lang.c (f_language_data): Likewise.
2773         * go-lang.c (go_language_data): Likewise.
2774         * language.c (unknown_language_data): Likewise.
2775         (auto_language_data): Likewise.
2776         * language.h (struct language_data): Delete
2777         la_lookup_transparent_type field.
2778         (language_defn::lookup_transparent_type): New member function.
2779         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
2780         initializer.
2781         * objc-lang.c (objc_language_data): Likewise.
2782         * opencl-lang.c (opencl_language_data): Likewise.
2783         * p-lang.c (pascal_language_data): Likewise.
2784         * rust-lang.c (rust_language_data): Likewise.
2785         * symtab.c (symbol_matches_domain): Update call.
2786
2787 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2788
2789         * ada-lang.c (ada_language_arch_info): Delete function, move
2790         implementation to...
2791         (ada_language::language_arch_info): ...here, a new member
2792         function.
2793         (ada_language_data): Delete la_language_arch_info.
2794         * c-lang.c (c_language_data): Likewise.
2795         (c_language::language_arch_info): New member function.
2796         (cplus_language_arch_info): Delete function, move
2797         implementation to...
2798         (cplus_language::language_arch_info): ...here, a new member
2799         function.
2800         (cplus_language_data): Delete la_language_arch_info.
2801         (asm_language_data): Likewise.
2802         (asm_language::language_arch_info): New member function.
2803         (minimal_language_data): Delete la_language_arch_info.
2804         (minimal_language::language_arch_info): New member function.
2805         * d-lang.c (d_language_arch_info): Delete function, move
2806         implementation to...
2807         (d_language::language_arch_info): ...here, a new member
2808         function.
2809         (d_language_data): Delete la_language_arch_info.
2810         * f-lang.c (f_language_arch_info): Delete function, move
2811         implementation to...
2812         (f_language::language_arch_info): ...here, a new member
2813         function.
2814         (f_language_data): Delete la_language_arch_info.
2815         * go-lang.c (go_language_arch_info): Delete function, move
2816         implementation to...
2817         (go_language::language_arch_info): ...here, a new member
2818         function.
2819         (go_language_data): Delete la_language_arch_info.
2820         * language.c (unknown_language_data): Likewise.
2821         (unknown_language::language_arch_info): New member function.
2822         (auto_language_data): Delete la_language_arch_info.
2823         (auto_language::language_arch_info): New member function.
2824         (language_gdbarch_post_init): Update call to
2825         la_language_arch_info.
2826         * language.h (language_data): Delete la_language_arch_info
2827         function pointer.
2828         (language_defn::language_arch_info): New function.
2829         * m2-lang.c (m2_language_arch_info): Delete function, move
2830         implementation to...
2831         (m2_language::language_arch_info): ...here, a new member
2832         function.
2833         (m2_language_data): Delete la_language_arch_info.
2834         * objc-lang.c (objc_language_arch_info): Delete function, move
2835         implementation to...
2836         (objc_language::language_arch_info): ...here, a new member
2837         function.
2838         (objc_language_data): Delete la_language_arch_info.
2839         * opencl-lang.c (opencl_language_arch_info): Delete function, move
2840         implementation to...
2841         (opencl_language::language_arch_info): ...here, a new member
2842         function.
2843         (opencl_language_data): Delete la_language_arch_info.
2844         * p-lang.c (pascal_language_arch_info): Delete function, move
2845         implementation to...
2846         (pascal_language::language_arch_info): ...here, a new member
2847         function.
2848         (pascal_language_data): Delete la_language_arch_info.
2849         * rust-lang.c (rust_language_arch_info): Delete function, move
2850         implementation to...
2851         (rust_language::language_arch_info): ...here, a new member
2852         function.
2853         (rust_language_data): Delete la_language_arch_info.
2854
2855 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2856
2857         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
2858         initializer.
2859         * c-lang.c (c_language_data): Likewise.
2860         (cplus_language_data): Likewise.
2861         (cplus_language::pass_by_reference_info): New method.
2862         (asm_language_data): Delete la_pass_by_reference initializer.
2863         (minimal_language_data): Likewise.
2864         * cp-abi.c (cp_pass_by_reference): Remove use of
2865         default_pass_by_reference.
2866         * d-lang.c (d_language_data): Likewise.
2867         * f-lang.c (f_language_data): Likewise.
2868         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
2869         default_pass_by_reference.
2870         * go-lang.c (go_language_data): Likewise.
2871         * language.c (language_pass_by_reference): Update.
2872         (default_pass_by_reference): Delete.
2873         (unknown_language_data): Delete la_pass_by_reference
2874         initializer.
2875         (auto_language_data): Likewise.
2876         * language.h (struct language_data): Delete la_pass_by_reference
2877         field.
2878         (language_defn::pass_by_reference_info): New member function.
2879         (default_pass_by_reference): Delete declaration.
2880         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
2881         initializer.
2882         * objc-lang.c (objc_language_data): Likewise.
2883         * opencl-lang.c (opencl_language_data): Likewise.
2884         * p-lang.c (pascal_language_data): Likewise.
2885         * rust-lang.c (rust_language_data): Likewise.
2886
2887 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2888
2889         * ada-lang.c (ada_read_var_value): Delete function, move
2890         implementation to...
2891         (ada_language::read_var_value): ...here.
2892         (ada_language_data): Delete la_read_var_value initializer.
2893         * c-lang.c (c_language_data): Likewise.
2894         (cplus_language_data): Likewise.
2895         (minimal_language_data): Likewise.
2896         * d-lang.c (d_language_data): Likewise.
2897         * f-lang.c (f_language_data): Likewise.
2898         * findvar.c (default_read_var_value): Rename to...
2899         (language_defn::read_var_value): ...this.
2900         * findvar.c (read_var_value): Update header comment, and change to
2901         call member function instead of function pointer.
2902         * go-lang.c (go_language_data): Likewise.
2903         * language.c (unknown_language_data): Delete la_read_var_value
2904         initializer.
2905         (auto_language_data): Likewise.
2906         * language.h (struct language_data): Delete la_read_var_value
2907         field.
2908         (language_defn::read_var_value): New member function.
2909         (default_read_var_value): Delete declaration.
2910         * m2-lang.c (m2_language_data): Delete la_read_var_value
2911         initializer.
2912         * objc-lang.c (objc_language_data): Likewise.
2913         * opencl-lang.c (opencl_language_data): Likewise.
2914         * p-lang.c (pascal_language_data): Likewise.
2915         * rust-lang.c (rust_language_data): Likewise.
2916         * value.h (default_read_var_value): Delete declaration.
2917
2918 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2919
2920         * ada-lang.c (ada_print_array_index): Delete function, move
2921         implementation to...
2922         (ada_language::print_array_index): ...here.
2923         (ada_language_data): Delete la_print_array_index initializer.
2924         * c-lang.c (c_language_data): Likewise.
2925         (cplus_language_data): Likewise.
2926         (minimal_language_data): Likewise.
2927         * d-lang.c (d_language_data): Likewise.
2928         * f-lang.c (f_language_data): Likewise.
2929         * go-lang.c (go_language_data): Likewise.
2930         * language.c (default_print_array_index): Delete function, move
2931         implementation to...
2932         (language_defn::print_array_index): ...here.
2933         (unknown_language_data): Delete la_print_array_index initializer.
2934         (auto_language_data): Likewise.
2935         * language.h (struct language_data): Delete la_print_array_index
2936         field.
2937         (language_defn::print_array_index): New member function.
2938         (LA_PRINT_ARRAY_INDEX): Update.
2939         (default_print_array_index): Delete declaration.
2940         * m2-lang.c (m2_language_data): Delete la_print_array_index
2941         initializer.
2942         * objc-lang.c (objc_language_data): Likewise.
2943         * opencl-lang.c (opencl_language_data): Likewise.
2944         * p-lang.c (pascal_language_data): Likewise.
2945         * rust-lang.c (rust_language_data): Likewise.
2946
2947 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2948
2949         * gdb/ada-lang.c (ada_language_defn): Convert to...
2950         (ada_language_data): ...this.
2951         (class ada_language): New class.
2952         (ada_language_defn): New static global.
2953         * gdb/c-lang.c (c_language_defn): Convert to...
2954         (c_language_data): ...this.
2955         (class c_language): New class.
2956         (c_language_defn): New static global.
2957         (cplus_language_defn): Convert to...
2958         (cplus_language_data): ...this.
2959         (class cplus_language): New class.
2960         (cplus_language_defn): New static global.
2961         (asm_language_defn): Convert to...
2962         (asm_language_data): ...this.
2963         (class asm_language): New class.
2964         (asm_language_defn): New static global.
2965         (minimal_language_defn): Convert to...
2966         (minimal_language_data): ...this.
2967         (class minimal_language): New class.
2968         (minimal_language_defn): New static global.
2969         * gdb/d-lang.c (d_language_defn): Convert to...
2970         (d_language_data): ...this.
2971         (class d_language): New class.
2972         (d_language_defn): New static global.
2973         * gdb/f-lang.c (f_language_defn): Convert to...
2974         (f_language_data): ...this.
2975         (class f_language): New class.
2976         (f_language_defn): New static global.
2977         * gdb/go-lang.c (go_language_defn): Convert to...
2978         (go_language_data): ...this.
2979         (class go_language): New class.
2980         (go_language_defn): New static global.
2981         * gdb/language.c (unknown_language_defn): Remove declaration.
2982         (current_language): Initialize to nullptr, real initialization is
2983         moved to _initialize_language.
2984         (languages): Delete global.
2985         (language_defn::languages): Define.
2986         (set_language_command): Use language_defn::languages.
2987         (set_language): Likewise.
2988         (range_error): Likewise.
2989         (language_enum): Likewise.
2990         (language_def): Likewise.
2991         (add_set_language_command): Use language_def::languages for the
2992         language list, and language_def to lookup language pointers.
2993         (skip_language_trampoline): Use language_defn::languages.
2994         (unknown_language_defn): Convert to...
2995         (unknown_language_data): ...this.
2996         (class unknown_language): New class.
2997         (unknown_language_defn): New static global.
2998         (auto_language_defn): Convert to...
2999         (auto_language_data): ...this.
3000         (class auto_language): New class.
3001         (auto_language_defn): New static global.
3002         (language_gdbarch_post_init): Use language_defn::languages.
3003         (_initialize_language): Initialize current_language.
3004         * gdb/language.h (struct language_defn): Rename to...
3005         (struct language_data): ...this.
3006         (struct language_defn): New.
3007         (auto_language_defn): Delete.
3008         (unknown_language_defn): Delete.
3009         (minimal_language_defn): Delete.
3010         (ada_language_defn): Delete.
3011         (asm_language_defn): Delete.
3012         (c_language_defn): Delete.
3013         (cplus_language_defn): Delete.
3014         (d_language_defn): Delete.
3015         (f_language_defn): Delete.
3016         (go_language_defn): Delete.
3017         (m2_language_defn): Delete.
3018         (objc_language_defn): Delete.
3019         (opencl_language_defn): Delete.
3020         (pascal_language_defn): Delete.
3021         (rust_language_defn): Delete.
3022         * gdb/m2-lang.c (m2_language_defn): Convert to...
3023         (m2_language_data): ...this.
3024         (class m2_language): New class.
3025         (m2_language_defn): New static global.
3026         * gdb/objc-lang.c (objc_language_defn): Convert to...
3027         (objc_language_data): ...this.
3028         (class objc_language): New class.
3029         (objc_language_defn): New static global.
3030         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
3031         (opencl_language_data): ...this.
3032         (class opencl_language): New class.
3033         (opencl_language_defn): New static global.
3034         * gdb/p-lang.c (pascal_language_defn): Convert to...
3035         (pascal_language_data): ...this.
3036         (class pascal_language): New class.
3037         (pascal_language_defn): New static global.
3038         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
3039         language pointer, update comment format.
3040         * gdb/rust-lang.c (rust_language_defn): Convert to...
3041         (rust_language_data): ...this.
3042         (class rust_language): New class.
3043         (rust_language_defn): New static global.
3044
3045 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3046
3047         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
3048         member variable.
3049         <m_stmt_at_address>: New member variable.
3050         (lnp_state_machine::record_line): Don't record some lines, update
3051         tracking of is_stmt at the same address.
3052         (lnp_state_machine::lnp_state_machine): Initialise new member
3053         variables.
3054
3055 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3056
3057         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
3058         "-include gnu-nat-mig.h".
3059         * gnu-nat-mig.h: New file.
3060         * gnu-nat.c: Include "gnu-nat-mig.h".
3061         (exc_server, msg_reply_server, notify_server,
3062         process_reply_server): Remove declarations.
3063
3064 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3065
3066         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
3067         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
3068         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
3069         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
3070         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
3071         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
3072         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
3073         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
3074         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
3075         to gnu_nat_target class.
3076         * gnu-nat.c: Likewise.
3077         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
3078         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
3079         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
3080         object.
3081         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
3082         instead of `gnu_target'.
3083
3084 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3085
3086         * i386-gnu-tdep.c: Include "gdbcore.h"
3087         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
3088         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
3089         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
3090         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
3091         i386_gnu_sigcontext_addr): New functions
3092         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
3093         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
3094         tdep.
3095
3096 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3097
3098         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
3099         before fork_inferior call. Avoid calling it if target_is_pushed returns
3100         true.
3101
3102 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3103
3104         * gnu-nat.h (gnu_target): New variable declaration.
3105         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
3106         gnu_target.
3107         * gnu-nat.c (gnu_target): New variable.
3108         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
3109         add_thread_silent, and add_thread calls.
3110         (gnu_nat_target::create_inferior): Pass gnu_target to
3111         add_thread_silent, thread_change_ptid call.
3112         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
3113         call.
3114
3115 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3116
3117         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
3118         (gnu_nat_target::find_memory_regions): Remove unused
3119         `old_address' variable.
3120
3121 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3122
3123         * gnu-nat.c: Include "gdbarch.h".
3124
3125 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3126
3127         * reply_mig_hack.awk (Error return): Cast function through
3128         void *, to bypass compiler function call check.
3129
3130 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3131
3132         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
3133         $(srcdir)/reply_mig_hack.awk.
3134
3135 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3136
3137         * gnu-nat.h (gnu_debug_flag): Set type to bool.
3138
3139 2020-05-30  Jonny Grant  <jg@jguk.org>
3140
3141         * configure.ac (ACX_BUGURL): change bug URL to https.
3142
3143 2020-05-30  Pedro Alves  <palves@redhat.com>
3144
3145         * cp-support.c (replace_typedefs_template): New.
3146         (replace_typedefs_qualified_name): Handle
3147         DEMANGLE_COMPONENT_TEMPLATE.
3148
3149 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
3150
3151         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
3152         dwarf2/index-cache.h, dwarf2/index-write.c,
3153         dwarf2/index-write.h, dwarf2/line-header.c,
3154         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
3155         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
3156         variables and fields from `dwarf2_per_objfile` to just
3157         `per_objfile` throughout.
3158
3159 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
3160
3161         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
3162         <push_dwarf_reg_entry_value>: Add comment.
3163
3164 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
3165             Keith Seitz  <keiths@redhat.com>
3166
3167         * python/python.c (do_start_initialization): Call PyEval_SaveThread
3168         instead of PyEval_ReleaseLock.
3169         (class gdbpy_gil): Move to earlier in file.
3170         (finalize_python): Set gdb_python_initialized.
3171         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
3172         when not initialized.
3173
3174 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
3175
3176         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
3177         <push_dwarf_reg_entry_value>: Remove assert.  Override
3178         per_objfile with caller_per_objfile.
3179
3180 2020-05-28  Tom de Vries  <tdevries@suse.de>
3181
3182         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
3183         PR gold/15646 workaround to symbol kind "type".
3184
3185 2020-05-27  Tom Tromey  <tromey@adacore.com>
3186
3187         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
3188
3189 2020-05-27  Tom Tromey  <tromey@adacore.com>
3190
3191         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
3192         Use htab_find_with_hash.
3193         <add_abbrev>: Remove "abbrev_number" parameter.
3194         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
3195         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
3196         (hash_abbrev): Add comment.
3197         (abbrev_table::lookup_abbrev): Move to header file.
3198         (abbrev_table::read): Update.
3199
3200 2020-05-27  Tom Tromey  <tromey@adacore.com>
3201
3202         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
3203         method.
3204         <canonical_name>: New member.
3205         <raw_name>: Rename from "name".
3206         (partial_die_info): Initialize canonical_name.
3207         (scan_partial_symbols): Check raw_name.
3208         (partial_die_parent_scope, partial_die_full_name)
3209         (add_partial_symbol, add_partial_subprogram)
3210         (add_partial_enumeration, load_partial_dies): Use "name" method.
3211         (partial_die_info::name): New method.
3212         (partial_die_info::read, guess_partial_die_structure_name)
3213         (partial_die_info::fixup): Update.
3214
3215 2020-05-27  Tom Tromey  <tromey@adacore.com>
3216
3217         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
3218         <get_ref_die_offset>: Inline.
3219         <get_ref_die_offset_complaint>: New method.
3220         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
3221         (attribute::get_ref_die_offset_complaint): Rename from
3222         get_ref_die_offset.  Just issue complaint.
3223
3224 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
3225
3226         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
3227
3228 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
3229
3230         * exec.c (exec_file_attach): Use errno value of first openp failure.
3231
3232 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
3233
3234         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
3235         Don't close thread handle.
3236
3237 2020-05-27  Tom Tromey  <tom@tromey.com>
3238             Simon Marchi  <simon.marchi@efficios.com>
3239
3240         * objfiles.h (struct objfile) <partial_symtabs>: Now a
3241         shared_ptr.
3242         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
3243         member.
3244         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
3245         dwarf2_per_bfd_objfile_data_key>: New globals.
3246         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
3247         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
3248         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
3249         shared.
3250         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
3251         short-circuit when sharing.
3252         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
3253         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
3254
3255 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3256
3257         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
3258         to...
3259         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
3260         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
3261
3262 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3263
3264         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
3265         build_name_components, find_name_components_bounds>:
3266         Add per_objfile parameter.
3267         (struct mapped_index) <symbol_name_at>: Likewise.
3268         (struct mapped_debug_names): Remove constructor.
3269         <dwarf2_per_objfile>: Remove field.
3270         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
3271         (mapped_index_base::find_name_components_bounds,
3272         mapped_index_base::build_name_components,
3273         dw2_expand_symtabs_matching_symbol): Likewise.
3274         (class mock_mapped_index) <symbol_name_at>: Likewise.
3275         (check_match): Likewise.
3276         (check_find_bounds_finds): Likewise.
3277         (test_mapped_index_find_name_component_bounds): Update.
3278         (CHECK_MATCH): Update.
3279         (dw2_expand_symtabs_matching): Update.
3280         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
3281         per_objfile parameter.
3282         <find_vec_in_debug_names>: Likewise.
3283         <m_per_objfile>: New field.
3284         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
3285         parameter.
3286         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
3287         (dw2_debug_names_iterator::next): Update.
3288         (dw2_debug_names_lookup_symbol): Update.
3289         (dw2_debug_names_expand_symtabs_for_function): Update.
3290         (dw2_debug_names_map_matching_symbols): Update.
3291         (dw2_debug_names_expand_symtabs_matching): Update.
3292         (dwarf2_read_debug_names): Update.
3293
3294 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3295
3296         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
3297         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
3298         move to dwarf2_per_objfile.
3299         <read_in_chain>: Remove.
3300         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
3301         remove_all_cus, age_comp_units>: New methods.
3302         <m_dwarf2_cus>: New member.
3303         (struct dwarf2_per_cu_data) <cu>: Remove.
3304         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
3305         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
3306         moved to methods of dwarf2_per_objfile.
3307         (dwarf2_clear_marks): Remove.
3308         (dwarf2_queue_item::~dwarf2_queue_item): Update.
3309         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
3310         (dwarf2_per_bfd::free_cached_comp_units): Remove.
3311         (dwarf2_per_objfile::remove_all_cus): New.
3312         (class free_cached_comp_units) <~free_cached_comp_units>:
3313         Update.
3314         (load_cu): Update.
3315         (dw2_do_instantiate_symtab): Adjust.
3316         (fill_in_sig_entry_from_dwo_entry): Adjust.
3317         (cutu_reader::init_tu_and_read_dwo_dies): Update.
3318         (cutu_reader::cutu_reader): Likewise.
3319         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
3320         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
3321         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
3322         and dwarf2_per_objfile::age_comp_units.
3323         (load_partial_comp_unit): Update.
3324         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
3325         (process_queue): Likewise.
3326         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
3327         backlink.
3328         (dwarf2_read_addr_index): Likewise.
3329         (follow_die_offset): Likewise.
3330         (dwarf2_fetch_die_loc_sect_off): Likewise.
3331         (dwarf2_fetch_constant_bytes): Likewise.
3332         (dwarf2_fetch_die_type_sect_off): Likewise.
3333         (follow_die_sig_1): Likewise.
3334         (load_full_type_unit): Likewise.
3335         (read_signatured_type): Likewise.
3336         (dwarf2_cu::dwarf2_cu): Don't set cu field.
3337         (dwarf2_cu::~dwarf2_cu): Remove.
3338         (dwarf2_per_objfile::get_cu): New.
3339         (dwarf2_per_objfile::set_cu): New.
3340         (age_cached_comp_units): Rename to...
3341         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
3342         to std::unordered_map.
3343         (free_one_cached_comp_unit): Rename to...
3344         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
3345         to std::unordered_map.
3346         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
3347         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
3348         a dwarf2_per_objfile in data.
3349         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
3350         (dwarf2_clear_marks): Remove.
3351
3352 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3353
3354         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
3355         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
3356         (init_tu_and_read_dwo_dies): Likewise.
3357         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
3358         (cutu_reader::cutu_reader): Likewise.
3359         (load_partial_comp_unit): Likewise.
3360         (process_psymtab_comp_unit): Update.
3361         (build_type_psymtabs_1): Update.
3362         (process_skeletonless_type_unit): Update.
3363         (load_full_comp_unit): Update.
3364         (find_partial_die): Update.
3365         (dwarf2_read_addr_index): Update.
3366         (read_signatured_type): Update.
3367
3368 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3369
3370         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
3371         m_header_read_in>: New fields.
3372         <get_header>: New method.
3373         * dwarf2/read.c (per_cu_header_read_in): Remove.
3374         (dwarf2_per_cu_data::get_header): New.
3375         (dwarf2_per_cu_data::addr_size): Update.
3376         (dwarf2_per_cu_data::offset_size): Update.
3377         (dwarf2_per_cu_data::ref_addr_size): Update.
3378
3379 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3380
3381         * dwarf2/read.c (load_cu): Return dwarf2_cu.
3382         (dw2_do_instantiate_symtab): Update.
3383         (queue_and_load_all_dwo_tus): Change parameter from
3384         dwarf2_per_cu_data to dwarf2_cu.
3385         (dwarf2_fetch_die_loc_sect_off): Update.
3386         (dwarf2_fetch_constant_bytes): Update.
3387         (dwarf2_fetch_die_type_sect_off): Update.
3388
3389 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3390
3391         * dwarf2/read.c (process_full_comp_unit,
3392         process_full_type_unit): Remove per_cu, per_objfile paramters.
3393         Add dwarf2_cu parameter.
3394         (process_queue): Update.
3395
3396 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3397
3398         * dwarf2/read.c (create_cu_from_index_list): Replace
3399         dwarf2_per_objfile parameter with dwarf2_per_bfd.
3400         (create_cus_from_index_list): Likewise.
3401         (create_cus_from_index): Likewise.
3402         (create_signatured_type_table_from_index): Likewise.
3403         (create_cus_from_debug_names_list): Likewise.
3404         (create_cus_from_debug_names): Likewise.
3405         (dwarf2_read_gdb_index): Update.
3406         (dwarf2_read_debug_names): Update.
3407
3408 2020-05-27  Tom Tromey  <tom@tromey.com>
3409             Simon Marchi  <simon.marchi@efficios.com>
3410
3411         * dwarf2/read.h (struct dwarf2_per_objfile)
3412         <get_type_for_signatured_type, set_type_for_signatured_type>:
3413         New methods.
3414         <m_type_map>: New member.
3415         (struct signatured_type) <type>: Remove.
3416         * dwarf2/read.c
3417         (dwarf2_per_objfile::get_type_for_signatured_type,
3418         dwarf2_per_objfile::set_type_for_signatured_type): New.
3419         (get_signatured_type): Use new methods.
3420
3421 2020-05-27  Tom Tromey  <tom@tromey.com>
3422             Simon Marchi  <simon.marchi@efficios.com>
3423
3424         * dwarf2/read.h (struct type_unit_group_unshareable): New.
3425         (struct dwarf2_per_objfile) <type_units>: New member.
3426         <get_type_unit_group_unshareable>: New method.
3427         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
3428         num_symtabs, symtabs>: Remove; move to
3429         type_unit_group_unshareable.
3430         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
3431         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
3432         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
3433
3434 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3435
3436         * dwarf2/read.h (struct dwarf2_per_cu_data):
3437         <dwarf2_per_objfile>: Remove.
3438         * dwarf2/read.c (create_cu_from_index_list): Don't assign
3439         dwarf2_per_objfile.
3440         (create_signatured_type_table_from_index): Likewise.
3441         (create_signatured_type_table_from_debug_names): Likewise.
3442         (create_debug_type_hash_table): Likewise.
3443         (fill_in_sig_entry_from_dwo_entry): Likewise.
3444         (create_type_unit_group): Likewise.
3445         (read_comp_units_from_section): Likewise.
3446         (create_cus_hash_table): Likewise.
3447
3448 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3449
3450         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
3451         dwarf2_per_cu_data::dwarf2_per_objfile.
3452         (compute_compunit_symtab_includes): Likewise.
3453         (dwarf2_cu::start_symtab): Likewise.
3454
3455 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3456
3457         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
3458         parameter.
3459         * dwarf2/read.c (get_die_type_at_offset): Likewise.
3460         (read_namespace_alias): Update.
3461         (lookup_die_type): Update.
3462         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
3463         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
3464         Update.
3465         (disassemble_dwarf_expression): Update.
3466
3467 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3468
3469         * dwarf2/read.h (struct dwarf2_queue_item): Add
3470         dwarf2_per_objfile parameter, assign new parameter.
3471         <per_objfile>: New field.
3472         * dwarf2/read.c (free_one_cached_comp_unit): Add
3473         dwarf2_per_objfile parameter.
3474         (queue_comp_unit): Likewise.
3475         (dw2_do_instantiate_symtab): Update.
3476         (process_psymtab_comp_unit): Update.
3477         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
3478         (process_imported_unit_die): Update.
3479         (queue_and_load_dwo_tu): Update.
3480         (follow_die_offset): Update.
3481         (follow_die_sig_1): Update.
3482
3483 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3484
3485         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
3486         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
3487         (read_call_site_scope): Assign per_objfile.
3488         (dwarf2_per_cu_data::objfile): Remove.
3489         * gdbtypes.h (struct call_site) <per_objfile>: New member.
3490         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
3491         dwarf2_per_objfile parameter.
3492         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
3493         dwarf2_per_objfile parameter.
3494         (dwarf_expr_reg_to_entry_parameter): Add output
3495         dwarf2_per_objfile parameter.
3496         (locexpr_get_frame_base): Update.
3497         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
3498         <push_dwarf_reg_entry_value>: Update.
3499         <call_site_to_target_addr>: Update.
3500         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
3501         parameter.
3502         (value_of_dwarf_reg_entry): Update.
3503         (rw_pieced_value): Update.
3504         (indirect_synthetic_pointer): Update.
3505         (dwarf2_evaluate_property): Update.
3506         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
3507         parameter.
3508         (locexpr_read_variable): Update.
3509         (locexpr_get_symbol_read_needs): Update.
3510         (loclist_read_variable): Update.
3511
3512 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3513
3514         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
3515         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3516         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
3517         parameter.
3518         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
3519         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3520         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
3521         parameter.
3522         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
3523         sect_variable_value): Add dwarf2_per_objfile parameter.
3524         (class dwarf_evaluate_loc_desc) <dwarf_call,
3525         dwarf_variable_value>: Update.
3526         (fetch_const_value_from_synthetic_pointer): Add
3527         dwarf2_per_objfile parameter.
3528         (fetch_const_value_from_synthetic_pointer): Update.
3529         (coerced_pieced_ref): Update.
3530         (class symbol_needs_eval_context) <dwarf_call,
3531         dwarf_variable_value>: Update.
3532         (dwarf2_compile_expr_to_ax): Update.
3533
3534 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3535
3536         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
3537         parameter.
3538         (dwarf2_evaluate_loc_desc_full): Update.
3539
3540 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3541
3542         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
3543         parameter.
3544         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
3545         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
3546         dwarf2_per_objfile parameter.
3547         (decode_debug_loc_dwo_addresses): Likewise.
3548         (dwarf2_find_location_expression): Update.
3549         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
3550         (locexpr_describe_location_piece): Add dwarf2_per_objfile
3551         parameter.
3552         (disassemble_dwarf_expression): Add dwarf2_per_objfile
3553         parameter.
3554         (locexpr_describe_location_1): Likewise.
3555         (locexpr_describe_location): Update.
3556
3557 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3558
3559         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
3560         Remove.
3561         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
3562         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
3563         (dwarf2_compile_property_to_c): Update.
3564         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
3565         use text offset from objfile.
3566         (locexpr_tracepoint_var_ref): Update.
3567         (locexpr_generate_c_location): Update.
3568         (loclist_describe_location): Update.
3569         (loclist_tracepoint_var_ref): Update.
3570         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
3571         dwarf2_per_objfile parameter.
3572         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
3573         use text offset from objfile.
3574         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
3575
3576 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3577
3578         * dwarf2/expr.h (struct dwarf_expr_context)
3579         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
3580         <offset>: Remove.
3581         <per_objfile>: New member.
3582         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
3583         dwarf2_per_objfile parameter.  Don't set offset, set
3584         per_objfile.
3585         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
3586         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
3587         a dwarf2_per_objfile object instead of an offset.
3588         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
3589         constructor.
3590         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
3591         to dwarf2_expr_executor constructor.  Don't set offset.
3592         (dwarf2_fetch_cfa_info): Update.
3593         (struct dwarf2_frame_cache) <text_offset>: Remove.
3594         <per_objfile>: New field.
3595         (dwarf2_frame_cache): Update.
3596         (dwarf2_frame_prev_register): Update.
3597         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
3598         <dwarf_evaluate_loc_desc>: Add constructor.
3599         (dwarf2_evaluate_loc_desc_full): Update.
3600         (dwarf2_locexpr_baton_eval): Update.
3601         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
3602         Add constructor.
3603         (dwarf2_loc_desc_get_symbol_read_needs): Update.
3604
3605 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3606
3607         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
3608         addr_sized_int_type>: Move to dwarf2_cu.
3609         <int_type>: Move to dwarf2_per_objfile.
3610         (struct dwarf2_per_objfile) <int_type>: Move here.
3611         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
3612         addr_sized_int_type>: Move here.
3613         (read_func_scope): Update.
3614         (read_array_type): Update.
3615         (read_tag_string_type): Update.
3616         (attr_to_dynamic_prop): Update.
3617         (dwarf2_per_cu_data::int_type): Rename to...
3618         (dwarf2_per_objfile::int_type): ... this.
3619         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
3620         (dwarf2_cu::addr_sized_int_type): ... this.
3621         (read_subrange_type): Update.
3622         (dwarf2_per_cu_data::addr_type): Rename to...
3623         (dwarf2_cu::addr_type): ... this.
3624         (set_die_type): Update.
3625
3626 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3627
3628         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
3629         data through per_cu->cu.
3630
3631 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3632
3633         * dwarf2/read.c (lookup_dwo_comp_unit): Change
3634         dwarf2_per_cu_data parameter fo dwarf2_cu.
3635         (lookup_dwo_type_unit): Likewise.
3636         (read_cutu_die_from_dwo): Likewise.
3637         (lookup_dwo_unit): Likewise.
3638         (open_and_init_dwo_file): Likewise.
3639         (lookup_dwo_cutu): Likewise.
3640         (lookup_dwo_comp_unit): Likewise.
3641         (lookup_dwo_type_unit): Likewise.
3642         (cutu_reader::init_tu_and_read_dwo_dies): Update.
3643         (cutu_reader::cutu_reader): Update.
3644
3645 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3646
3647         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
3648         parameter.
3649         (process_full_type_unit): Likewise.
3650         (process_queue): Update.
3651
3652 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3653
3654         * dwarf2/read.c (recursively_compute_inclusions): Add
3655         dwarf2_per_objfile parameter.
3656         (compute_compunit_symtab_includes): Likewise.
3657         (process_cu_includes): Update.
3658
3659 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3660
3661         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
3662         parameter.
3663         (create_type_unit_group): Update.
3664         (process_psymtab_comp_unit_reader): Update.
3665         (build_type_psymtabs_reader): Update.
3666
3667 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3668
3669         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
3670         object through m_this_cu->cu.
3671
3672 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3673
3674         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
3675         the info parameter.
3676         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
3677
3678 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3679
3680         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
3681         per_objfile parameter.
3682         (load_full_type_unit): Add per_objfile parameter.
3683         (read_signatured_type): Likewise.
3684         (load_full_comp_unit): Likewise.
3685         (load_cu): Likewise.
3686         (dw2_do_instantiate_symtab): Likewise.
3687         (dw2_get_file_names): Likewise.
3688         (dw2_map_symtabs_matching_filename): Update.
3689         (dw_expand_symtabs_matching_file_matcher): Update.
3690         (dw2_map_symbol_filenames): Update.
3691         (process_psymtab_comp_unit): Add per_objfile parameter.
3692         (build_type_psymtabs_1): Update.
3693         (process_skeletonless_type_unit): Update.
3694         (dwarf2_build_psymtabs_hard): Update.
3695         (load_partial_comp_unit): Add per_objfile parameter.
3696         (scan_partial_symbols): Update.
3697         (load_full_comp_unit): Add per_objfile parameter.
3698         (process_imported_unit_die): Update.
3699         (create_cus_hash_table): Update.
3700         (find_partial_die): Update.
3701         (dwarf2_read_addr_index): Update.
3702         (follow_die_offset): Update.
3703         (dwarf2_fetch_die_loc_sect_off): Update.
3704         (dwarf2_fetch_constant_bytes): Update.
3705         (dwarf2_fetch_die_type_sect_off): Update.
3706         (follow_die_sig_1): Update.
3707         (load_full_type_unit): Add per_objfile parameter.
3708         (read_signatured_type): Likewise.
3709
3710 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3711
3712         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
3713         of objfile_name.
3714
3715 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3716
3717         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
3718         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
3719         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
3720         field.
3721         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
3722         (create_cus_from_index): Update.
3723         (dwarf2_read_gdb_index): Update.
3724         (create_cus_from_debug_names): Update.
3725         (dwarf2_read_debug_names): Update.
3726         (get_abbrev_section_for_cu): Update.
3727         (create_all_comp_units): Update.
3728         (read_attribute_value): Update.
3729         (get_debug_line_section): Update.
3730         * dwarf2/index-cache.c (index_cache::store): Update.
3731         * dwarf2/index-write.c (save_gdb_index_command): Update.
3732         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
3733
3734 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3735
3736         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
3737         member.
3738         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
3739         dwarf2_per_cu_data::per_bfd.
3740         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
3741         (create_type_unit_group): Likewise.
3742         (queue_comp_unit): Remove reference to
3743         per_cu->dwarf2_per_objfile.
3744         (maybe_queue_comp_unit): Likewise.
3745         (fill_in_sig_entry_from_dwo_entry): Assign new field.
3746         (create_cus_hash_table): Assign new field.
3747
3748 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3749
3750         * dwarf2/read.c: Replace
3751         dwarf2_cu->per_cu->dwarf2_per_objfile references with
3752         dwarf2_cu->per_objfile throughout.
3753
3754 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3755
3756         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
3757         parameter, don't use per_cu->dwarf2_per_objfile.
3758         (dw2_instantiate_symtab): Likewise.
3759         (dw2_find_last_source_symtab): Update.
3760         (dw2_map_expand_apply): Update.
3761         (dw2_lookup_symbol): Update.
3762         (dw2_expand_symtabs_for_function): Update.
3763         (dw2_expand_all_symtabs): Update.
3764         (dw2_expand_symtabs_with_fullname): Update.
3765         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
3766         don't use per_cu->dwarf2_per_objfile.
3767         (dw2_expand_marked_cus): Update.
3768         (dw2_find_pc_sect_compunit_symtab): Update.
3769         (dw2_debug_names_lookup_symbol): Update.
3770         (dw2_debug_names_expand_symtabs_for_function): Update.
3771         (dw2_debug_names_map_matching_symbols): Update.
3772         (dwarf2_psymtab::expand_psymtab): Update.
3773
3774 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3775
3776         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
3777         <per_objfile>: New member.
3778         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
3779         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
3780         call to dwarf2_cu.
3781         (cutu_reader::cutu_reader): Update.
3782         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
3783
3784 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
3785
3786         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
3787         struct dwarf2_per_objfile.
3788         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
3789         dwarf2_per_bfd.
3790         * dwarf2/read.c (set_die_type): Update.
3791         (get_die_type_at_offset): Update.
3792
3793 2020-05-27  Tom Tromey  <tom@tromey.com>
3794             Simon Marchi  <simon.marchi@efficios.com>
3795
3796         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
3797         method.
3798         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
3799         get_symtab, set_symtab>: New methods.
3800         <m_symtabs>: New field.
3801         (struct dwarf2_psymtab): Derive from partial_symtab.
3802         <readin_p, get_compunit_symtab>: Declare methods.
3803         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
3804         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
3805         New methods.
3806         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
3807         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
3808         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
3809         (dw2_symtab_iter_next, dw2_print_stats)
3810         (dw2_expand_symtabs_with_fullname)
3811         (dw2_expand_symtabs_matching_one)
3812         (dw_expand_symtabs_matching_file_matcher)
3813         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
3814         (dw2_debug_names_iterator::next)
3815         (dw2_debug_names_map_matching_symbols)
3816         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
3817         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
3818         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
3819         New methods.
3820         (get_compunit_symtab, process_full_comp_unit)
3821         (process_full_type_unit): Update.
3822         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
3823
3824 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
3825
3826         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
3827         then introduce a new dwarf2_per_objfile type.
3828         <read_line_string>: Move to the new dwarf2_per_objfile type.
3829         <objfile>: Likewise.
3830         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
3831         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
3832         dwarf2_per_objfile->per_bfd.
3833         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
3834         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
3835         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
3836         (dwarf2_per_bfd::free_cached_comp_units): ... this.
3837         (dwarf2_has_info): Allocate dwarf2_per_bfd.
3838         (dwarf2_per_objfile::locate_sections): Rename to...
3839         (dwarf2_per_bfd::locate_sections): ... this.
3840         (dwarf2_per_objfile::get_cutu): Rename to...
3841         (dwarf2_per_bfd::get_cutu): ... this.
3842         (dwarf2_per_objfile::get_cu): Rename to...
3843         (dwarf2_per_bfd::get_cu): ... this.
3844         (dwarf2_per_objfile::get_tu): Rename to...
3845         (dwarf2_per_bfd::get_tu): ... this.
3846         (dwarf2_per_objfile::allocate_per_cu): Rename to...
3847         (dwarf2_per_bfd::allocate_per_cu): ... this.
3848         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
3849         (dwarf2_per_bfd::allocate_signatured_type): ... this.
3850         (get_gdb_index_contents_ftype): Change parameter from
3851         dwarf2_per_objfile to dwarf2_per_bfd.
3852         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
3853         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
3854
3855 2020-05-27  Tom Tromey  <tom@tromey.com>
3856             Simon Marchi  <simon.marchi@efficios.com>
3857
3858         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
3859         (allocate_piece_closure): Set "per_objfile" member.
3860         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
3861         (locexpr_describe_location, loclist_describe_location): Use new
3862         member.
3863         * dwarf2/read.c (read_call_site_scope)
3864         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
3865         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
3866         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
3867         handle_data_member_location): Set per_objfile member.
3868         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
3869         member.
3870         (struct dwarf2_loclist_baton) <per_objfile>: New member.
3871
3872 2020-05-27  Tom Tromey  <tom@tromey.com>
3873
3874         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
3875         allocate_signatured_type>: Declare new methods.
3876         <m_num_psymtabs>: New member.
3877         (struct dwarf2_per_cu_data) <index>: New member.
3878         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
3879         (dwarf2_per_objfile::allocate_signatured_type): New methods.
3880         (create_cu_from_index_list): Use allocate_per_cu.
3881         (create_signatured_type_table_from_index)
3882         (create_signatured_type_table_from_debug_names)
3883         (create_debug_type_hash_table, add_type_unit)
3884         (read_comp_units_from_section): Use allocate_signatured_type.
3885
3886 2020-05-27  Tom Tromey  <tom@tromey.com>
3887
3888         * psymtab.c (partial_map_expand_apply)
3889         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
3890         (psym_lookup_global_symbol_language)
3891         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
3892         (psym_print_stats, psym_expand_symtabs_for_function)
3893         (psym_map_symbol_filenames, psym_map_matching_symbols)
3894         (psym_expand_symtabs_matching)
3895         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
3896         (maintenance_check_psymtabs): Update.
3897         * psympriv.h (struct partial_symtab) <readin_p,
3898         get_compunit_symtab>: Add objfile parameter.
3899         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
3900         Likewise.
3901         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
3902         get_compunit_symtab>: Likewise.
3903         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
3904
3905 2020-05-27  Tom Tromey  <tom@tromey.com>
3906
3907         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
3908         member.
3909         * dwarf2/read.c (delete_file_name_entry): Fix comment.
3910         (create_cu_from_index_list)
3911         (create_signatured_type_table_from_index)
3912         (create_signatured_type_table_from_debug_names)
3913         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
3914         (dwarf2_create_include_psymtab)
3915         (create_debug_type_hash_table, add_type_unit)
3916         (create_type_unit_group, read_comp_units_from_section)
3917         (dwarf2_compute_name, create_cus_hash_table)
3918         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
3919         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
3920         obstack.
3921         (dw2_get_real_path): Likewise.  Change argument to
3922         dwarf2_per_objfile.
3923
3924 2020-05-27  Luis Machado  <luis.machado@linaro.org>
3925
3926         PR tdep/26000
3927         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
3928         for ldrd (immediate).
3929
3930 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3931
3932         * command.h: Add comment giving the name of class_tui.
3933         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
3934         create the fake command for the help for class_tui.
3935
3936 2020-05-26  Tom Tromey  <tromey@adacore.com>
3937
3938         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
3939         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
3940         (val_atr): New function.
3941         (value_val_atr): Use it.
3942         * ada-valprint.c (print_optional_low_bound): Change low bound
3943         handling for enums.
3944         (val_print_packed_array_elements): Don't call discrete_position.
3945         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
3946         discrete_position for enum types.
3947         * language.c (default_print_array_index): Change type.
3948         * language.h (struct language_defn) <la_print_array_index>: Add
3949         index_type parameter, change type of index_value.
3950         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
3951         (default_print_array_index): Update.
3952         * valprint.c (maybe_print_array_index): Don't call
3953         value_from_longest.  Update.
3954         (value_print_array_elements): Don't call discrete_position.
3955
3956 2020-05-26  Tom Tromey  <tromey@adacore.com>
3957
3958         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
3959         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
3960
3961 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
3962
3963         PR gdb/13519
3964         * avr-tdep.c (avr_integer_to_address): Return data or code
3965         address accordingly to the second 'type' argument of the
3966         function.
3967
3968 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
3969
3970         * infcmd.c, inferior.h: (construct_inferior_arguments):
3971         Moved function from here to gdbsupport/common-inferior.{h,cc}
3972
3973 2020-05-23  Tom Tromey  <tom@tromey.com>
3974
3975         Revert commit eca1f90c:
3976         * NEWS: Remove entry for completion styling.
3977         * completer.c (_rl_completion_prefix_display_length): Move
3978         declaration later.
3979         (gdb_fnprint): Revert.
3980         (gdb_display_match_list_1): Likewise.
3981         * cli/cli-style.c (completion_prefix_style)
3982         (completion_difference_style, completion_suffix_style): Remove.
3983         (_initialize_cli_style): Revert.
3984         * cli/cli-style.h (completion_prefix_style)
3985         (completion_difference_style, completion_suffix_style): Don't
3986         declare.
3987
3988 2020-05-24  Pedro Alves  <palves@redhat.com>
3989
3990         * symtab.c (completion_list_add_name): Return boolean indication
3991         of whether the symbol matched.
3992         (completion_list_add_symbol): Don't try to remove C++ aliases if
3993         the symbol didn't match in the first place.
3994         * symtab.h (completion_list_add_name): Return bool.
3995
3996 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
3997
3998         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
3999         type::field.
4000
4001 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
4002
4003         GDB 9.2 released.
4004
4005 2020-05-23  Tom Tromey  <tom@tromey.com>
4006
4007         * NEWS: Add entry for completion styling.
4008         * completer.c (_rl_completion_prefix_display_length): Move
4009         declaration earlier.
4010         (gdb_fnprint): Use completion_style.
4011         (gdb_display_match_list_1): Likewise.
4012         * cli/cli-style.c (completion_prefix_style)
4013         (completion_difference_style, completion_suffix_style): New
4014         globals.
4015         (_initialize_cli_style): Register new globals.
4016         * cli/cli-style.h (completion_prefix_style)
4017         (completion_difference_style, completion_suffix_style): Declare.
4018
4019 2020-05-23  Pedro Alves  <palves@redhat.com>
4020
4021         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
4022         (parse_escape): Use ISDIGIT instead of isdigit.
4023         (puts_debug): Use gdb_isprint instead of isprint.
4024         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
4025         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
4026         ISSPACE instead of isspace.
4027         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
4028         instead of isspace.
4029         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
4030         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
4031         instead of isxdigit and ISDIGIT instead of isdigit.
4032
4033 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
4034
4035         * gdbtypes.h (struct type) <field>: New method.
4036         (TYPE_FIELDS): Remove, replace all uses with either type::fields
4037         or type::field.
4038
4039 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
4040
4041         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
4042         (TYPE_FIELDS): Use type::fields.  Change all call sites that
4043         modify the propery to use type::set_fields instead.
4044
4045 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
4046
4047         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
4048         type::num_fields instead.
4049
4050 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
4051
4052         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
4053         methods.
4054         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
4055         that modify the number of fields to use type::set_num_fields
4056         instead.
4057
4058 2020-05-22  Tom Tromey  <tromey@adacore.com>
4059
4060         * compile/compile-object-load.h (munmap_list_free): Don't
4061         declare.
4062
4063 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4064
4065         * annotate.c (annotate_source_line): Update return type, add call
4066         to update current symtab and line.
4067         * annotate.h (annotate_source_line): Update return type, and
4068         extend header comment.
4069         * source.c (info_line_command): Check annotation_level before
4070         calling annotate_source_line.
4071         * stack.c (print_frame_info): If calling annotate_source_line
4072         returns true, then don't print any other source line information.
4073
4074 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
4075
4076         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
4077
4078 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
4079
4080         * coffread.c (patch_type): Remove NULL check before xfree.
4081         * corefile.c (set_gnutarget): Likewise.
4082         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
4083         * exec.c (build_section_table): Likewise.
4084         * remote.c (remote_target::pass_signals): Likewise.
4085         * utils.c (n_spaces): Likewise.
4086         * cli/cli-script.c (document_command): Likewise.
4087         * i386-windows-tdep.c (core_process_module_section): Likewise.
4088         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
4089
4090 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
4091
4092         * symfile.c (reread_symbols): Clear objfile's section_offsets
4093         vector and section indices, re-compute them by calling
4094         sym_offsets.
4095
4096 2020-05-20  Tom Tromey  <tromey@adacore.com>
4097
4098         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
4099         (desc_one_bound, desc_index_type): Compute field name.
4100
4101 2020-05-20  Tom de Vries  <tdevries@suse.de>
4102
4103         PR symtab/25833
4104         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
4105
4106 2020-05-20  Alan Modra  <amodra@gmail.com>
4107
4108         PR 25993
4109         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
4110         bfd_set_filename.
4111         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
4112         passed to bfd_set_filename.
4113         * symfile-mem.c (add_vsyscall_page): Likewise for string
4114         passed to symbol_file_add_from_memory.
4115         (symbol_file_add_from_memory): Make name param a const char* and
4116         don't strdup.
4117
4118 2020-05-20  Alan Modra  <amodra@gmail.com>
4119
4120         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
4121         rather than accessing bfd->filename directly.
4122         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
4123         and use bfd_section_name.
4124         * dwarf2/frame.c (decode_frame_entry): Likewise.
4125         * exec.c (exec_set_section_address): Likewise.
4126         * solib-aix.c (solib_aix_bfd_open): Likewise.
4127         * stap-probe.c (get_stap_base_address): Likewise.
4128         * symfile.c (reread_symbols): Likewise.
4129
4130 2020-05-19  Tom Tromey  <tromey@adacore.com>
4131
4132         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
4133
4134 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4135
4136         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
4137
4138 2020-05-19  Pedro Alves  <palves@redhat.com>
4139
4140         * NEWS (set exec-file-mismatch): Adjust entry.
4141         * exec.c: Include "build-id.h".
4142         (validate_exec_file): Try to match build IDs instead of filenames.
4143         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
4144         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
4145         and pass down 'warn_if_slow'.
4146         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
4147         gdb_bfd_open_closure to pass it down.
4148         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
4149
4150 2020-05-19  Pedro Alves  <palves@redhat.com>
4151
4152         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
4153         * target.c (target_fileio_open_1): Rename to target_fileio_open
4154         and make extern.  Use bool.
4155         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
4156         (target_fileio_read_alloc_1): Adjust.
4157         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
4158         (target_fileio_open_warn_if_slow): Delete declaration.
4159
4160 2020-05-19  Pedro Alves  <palves@redhat.com>
4161
4162         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
4163         Adjust all callers.
4164
4165 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
4166
4167         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
4168         whether disp is negative.
4169
4170 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4171
4172         * symfile.h (struct symfile_segment_data)
4173         <~symfile_segment_data>: Remove.
4174         <segment_info>: Change to std::vector.
4175         * symfile.c (default_symfile_segments): Update.
4176         * elfread.c (elf_symfile_segments): Update.
4177
4178 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4179
4180         * symfile.h (struct symfile_segment_data) <struct segment>: New.
4181         <segments>: New.
4182         <segment_bases, segment_sizes>: Remove.
4183         * symfile.c (default_symfile_segments): Update.
4184         * elfread.c (elf_symfile_segments): Update.
4185         * remote.c (remote_target::get_offsets): Update.
4186         * solib-target.c (solib_target_relocate_section_addresses):
4187         Update.
4188
4189 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
4190
4191         * symfile.h (struct symfile_segment_data): Initialize fields.
4192         <~symfile_segment_data>: Add.
4193         (symfile_segment_data_up): New.
4194         (struct sym_fns) <sym_segments>: Return a
4195         symfile_segment_data_up.
4196         (default_symfile_segments): Return a symfile_segment_data_up.
4197         (free_symfile_segment_data): Remove.
4198         (get_symfile_segment_data): Return a symfile_segment_data_up.
4199         * symfile.c (default_symfile_segments): Likewise.
4200         (get_symfile_segment_data): Likewise.
4201         (free_symfile_segment_data): Remove.
4202         (symfile_find_segment_sections): Update.
4203         * elfread.c (elf_symfile_segments): Return a
4204         symfile_segment_data_up.
4205         * remote.c (remote_target::get_offsets): Update.
4206         * solib-target.c (solib_target_relocate_section_addresses):
4207         Update.
4208         * symfile-debug.c (debug_sym_segments): Return a
4209         symfile_segment_data_up.
4210
4211 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4212
4213         PR build/25981
4214         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
4215         Hardcode register numbers.
4216
4217         PR build/25981
4218         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
4219         procfs_find_LDT_entry): Remove.
4220         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
4221         procfs_find_LDT_entry): Remove.
4222         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
4223         Remove.
4224
4225 2020-05-17  Pedro Alves  <palves@redhat.com>
4226             Andrew Burgess  <andrew.burgess@embecosm.com>
4227             Keno Fischer  <keno@juliacomputing.com>
4228
4229         PR gdb/25741
4230         * breakpoint.c (build_target_condition_list): Update comments.
4231         (build_target_command_list): Update comments and skip matching
4232         locations.
4233         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
4234         a separate function.  Simplify "set breakpoint auto-hw off"
4235         handling.
4236         (insert_breakpoints): Update comment.
4237         (tracepoint_locations_match): New parameter.  For breakpoints,
4238         compare location types too, if the caller wants to.
4239         (handle_automatic_hardware_breakpoints): New functions.
4240         (bp_location_is_less_than): Also sort by location type and
4241         hardware breakpoint length.
4242         (update_global_location_list): Handle "set breakpoint auto-hw on"
4243         here.
4244         (update_breakpoint_locations): Ask breakpoint_locations_match to
4245         ignore location types.
4246
4247 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
4248
4249         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
4250         type::name instead.
4251
4252 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
4253
4254         * gdbtypes.h (struct type) <name, set_name>: New methods.
4255         (TYPE_CODE): Use type::name.  Change all call sites used to set
4256         the name to use type::set_name instead.
4257
4258 2020-05-16  Tom Tromey  <tom@tromey.com>
4259
4260         * top.c (quit_force): Update.
4261         * infrun.c (handle_no_resumed): Update.
4262         * top.h (all_uis): New function.
4263         (ALL_UIS): Remove.
4264
4265 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
4266
4267         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
4268
4269 2020-05-16  Pedro Alves  <palves@redhat.com>
4270
4271         * ia64-linux-nat.c
4272         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
4273         Declare method.
4274         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
4275
4276 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
4277
4278         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
4279         (sparc64_adi_info): Likewise.
4280
4281 2020-05-15  Tom Tromey  <tom@tromey.com>
4282
4283         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
4284         block_objfile.
4285         (lookup_objfile_from_block): Remove.
4286         (lookup_symbol_in_block, lookup_symbol_in_static_block)
4287         (lookup_global_symbol): Use block_objfile.
4288         * symtab.h (lookup_objfile_from_block): Don't declare.
4289         * printcmd.c (clear_dangling_display_expressions): Use
4290         block_objfile.
4291         * parse.c (operator_check_standard): Use block_objfile.
4292
4293 2020-05-15  Tom Tromey  <tom@tromey.com>
4294
4295         * language.c (language_alloc_type_symbol): Set
4296         SYMBOL_SECTION.
4297         * symtab.c (initialize_objfile_symbol): Remove.
4298         (allocate_symbol): Remove.
4299         (allocate_template_symbol): Remove.
4300         * dwarf2/read.c (fixup_go_packaging): Use "new".
4301         (new_symbol): Use "new".
4302         (read_variable): Don't call initialize_objfile_symbol.  Use
4303         "new".
4304         (read_func_scope): Use "new".
4305         * xcoffread.c (process_xcoff_symbol): Don't call
4306         initialize_objfile_symbol.
4307         (SYMBOL_DUP): Remove.
4308         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
4309         "new".
4310         * symtab.h (allocate_symbol, initialize_objfile_symbol)
4311         (allocate_template_symbol): Don't declare.
4312         (struct symbol): Add copy constructor.  Change defaults.
4313         * jit.c (finalize_symtab): Use "new".
4314         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
4315         Use "new".
4316         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
4317         (common_block_end): Use "new".
4318         * mdebugread.c (parse_symbol): Use "new".
4319         (new_symbol): Likewise.
4320
4321 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4322
4323         * NEWS: Mention changes to help and apropos.
4324
4325 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4326
4327         * command.h (enum command_class): Improve comments, document
4328         that class_alias is for user-defined aliases, give the class
4329         name for each class, remove unused class_xdb.
4330         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
4331         * breakpoint.c (_initialize_breakpoint): Replace class_alias
4332         by a precise class.
4333         * infcmd.c (_initialize_infcmd): Likewise.
4334         * reverse.c (_initialize_reverse): Likewise.
4335         * stack.c (_initialize_stack): Likewise.
4336         * symfile.c (_initialize_symfile): Likewise.
4337         * tracepoint.c (_initialize_tracepoint): Likewise.
4338
4339 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4340
4341         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
4342         when their aliased command is traversed.
4343         (help_cmd): Add fput_command_names_styled call to
4344         output command name and aliases when command has an alias.
4345
4346 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4347
4348         * cli/cli-decode.h (help_cmd_list): Remove declaration.
4349         * cli/cli-decode.c (help_cmd_list): Declare as static,
4350         remove prefix argument, use bool for recurse arg, rework to show the aliases of
4351         a command together with the command.
4352         (fput_command_name_styled, fput_command_names_styled): New functions.
4353         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
4354         fput_command_name_styled.
4355         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
4356         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
4357
4358 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4359
4360         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
4361         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
4362         * command.h (cmd_show_list): Likewise.
4363         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
4364         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
4365
4366 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4367
4368         * unittests/command-def-selftests.c (traverse_command_structure):
4369         Verify all commands of a list have the same prefix command and
4370         that only the top cmdlist commands have a null prefix.
4371
4372 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4373
4374         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
4375         as prefix, not one of its aliases.
4376         (set_cmd_prefix): Remove.
4377         (do_add_cmd): Centralize the setting of the prefix of a command, when
4378         command is defined after its full chain of prefix commands.
4379         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
4380         (add_setshow_cmd_full): Likewise.
4381         (update_prefix_field_of_prefixed_commands): New function.
4382         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
4383         update_prefix_field_of_prefixed_commands.
4384         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
4385         addresses of remote_set_cmdlist and remote_show_cmdlist given
4386         as argument, not the address of an argument.
4387         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
4388         * gdb/remote.c (_initialize_remote): Likewise.
4389
4390 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4391
4392         * cli/cli-cmds.c (alias_command): Check for an existing alias
4393         using lookup_cmd_composition, as valid_command_p is too strict
4394         and forbids aliases that are the prefix of an existing alias
4395         or command.
4396         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
4397         command is properly recognised as a valid command.
4398
4399 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4400
4401         * unittests/help-doc-selftests.c: Rename to
4402         unittests/command-def-selftests.c
4403         * unittests/command-def-selftests.c (help_doc_tests): Update some
4404         comments.
4405         (command_structure_tests, traverse_command_structure): New namespace
4406         and function.
4407         (command_structure_invariants_tests): New function.
4408         (_initialize_command_def_selftests) Renamed from
4409         _initialize_help_doc_selftests, register command_structure_invariants
4410         selftest.
4411
4412 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4413
4414         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
4415         an alias of 'show'.
4416
4417 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
4418
4419         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
4420         ada_is_fixed_point_type.  Update all callers.
4421         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
4422         all callers.
4423         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
4424         Update all callers.
4425         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
4426         print_fixed_point_type.  Update all callers.
4427         * ada-valprint.c (ada_value_print_num): Replace call to
4428         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
4429
4430 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
4431
4432         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
4433         processors.
4434         (cpu_supports_bts): Add CV_AMD case.
4435
4436 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
4437             Simon Marchi  <simon.marchi@efficios.com>
4438
4439         * infrun.c (stop_all_threads): Collect multiple wait events at
4440         each pass.
4441
4442 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
4443
4444         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
4445         type::code instead.
4446
4447 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
4448
4449         * gdbtypes.h (struct type) <code, set_code>: New methods.
4450         (TYPE_CODE): Use type::code.  Change all call sites used to set
4451         the code to use type::set_code instead.
4452
4453 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4454             Tom de Vries  <tdevries@suse.de>
4455             Pedro Alves  <palves@redhat.com>
4456
4457         PR threads/25478
4458         * infrun.c (stop_all_threads): Do NOT ignore
4459         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
4460         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
4461         received.
4462         (handle_no_resumed): Remove code handling a live inferior with no
4463         threads.
4464         * remote.c (has_single_non_exited_thread): New.
4465         (remote_target::update_thread_list): Do not delete a thread if is
4466         the last thread of the process.
4467         * thread.c (thread_select): Call delete_exited_threads instead of
4468         prune_threads.
4469
4470 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4471
4472         * infrun.c (stop_all_threads): Enable/disable thread events of all
4473         targets.  Move a debug message denoting the end of the function
4474         into the SCOPED_EXIT block.
4475
4476 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4477
4478         * process-stratum-target.h: Include <set>.
4479         (all_non_exited_process_targets, switch_to_target_no_thread): New
4480         function declarations.
4481         * process-stratum-target.c (all_non_exited_process_targets)
4482         (switch_to_target_no_thread): New function implementations.
4483
4484 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4485
4486         * infrun.c (handle_inferior_event): Extract out a piece of code
4487         into...
4488         (mark_non_executing_threads): ...this new function.
4489
4490 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4491
4492         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
4493         use.
4494
4495 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4496
4497         * regcache.c (regcache_read_pc_protected): New function
4498         implementation that returns 0 if the PC cannot read via
4499         'regcache_read_pc'.
4500         * infrun.c (proceed): Call 'regcache_read_pc_protected'
4501         instead of 'regcache_read_pc'.
4502         (keep_going_pass_signal): Ditto.
4503
4504 2020-05-13  Tom Tromey  <tromey@adacore.com>
4505
4506         * ada-lang.c (align_value): Remove.
4507         (ada_template_to_fixed_record_type_1): Use align_up.
4508
4509 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4510
4511         * async-event.c: Update the copyright year.
4512         * async-event.h: Update the copyright year.
4513
4514 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
4515
4516         * objfiles.h (is_addr_in_objfile,
4517         shared_objfile_contains_address_p): Return bool.
4518         * objfile.c (is_addr_in_objfile,
4519         shared_objfile_contains_address_p): Return bool.
4520
4521 2020-05-11  Tom Tromey  <tromey@adacore.com>
4522
4523         * cli/cli-cmds.c (info_command): Restore.
4524         (_initialize_cli_cmds): Use add_prefix_command for "info".
4525         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
4526
4527 2020-05-11  Tom Tromey  <tromey@adacore.com>
4528
4529         * ada-lang.c (ada_value_primitive_field): Now public.
4530         * ada-lang.h (ada_value_primitive_field): Declare.
4531         * ada-valprint.c (print_field_values): Use
4532         ada_value_primitive_field for wrapper fields.
4533
4534 2020-05-11  Tom de Vries  <tdevries@suse.de>
4535
4536         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
4537         MODULE_DOMAIN.
4538
4539 2020-05-11  Tom de Vries  <tdevries@suse.de>
4540
4541         PR symtab/25941
4542         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
4543         with length 0, if not gdb-produced.
4544         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
4545
4546 2020-05-09  Tom de Vries  <tdevries@suse.de>
4547
4548         PR gdb/25955
4549         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
4550         calculation.
4551
4552 2020-05-09  Tom Tromey  <tom@tromey.com>
4553
4554         * top.c (server_command): Now bool.
4555         * top.h (server_command): Now bool.
4556
4557 2020-05-08  Tom Tromey  <tromey@adacore.com>
4558
4559         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
4560         already being processed.
4561
4562 2020-05-08  Tom Tromey  <tom@tromey.com>
4563
4564         * printcmd.c (struct display) <next>: Remove.
4565         <display>: New constructor.
4566         <exp_string>: Now a std::string.
4567         <enabled_p>: Now a bool.
4568         (display_number): Move definition earlier.
4569         (displays): Rename from display_chain.  Now a std::vector.
4570         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
4571         (display_command): Update.
4572         (do_one_display, disable_display)
4573         (enable_disable_display_command, do_enable_disable_display):
4574         Update.
4575         (free_display): Remove.
4576         (clear_displays): Rewrite.
4577         (delete_display): Update.
4578         (map_display_numbers): Use function_view.  Remove "data"
4579         parameter.  Update.
4580         (do_delete_display): Remove.
4581         (undisplay_command): Update.
4582         (do_one_display, do_displays, disable_display)
4583         (info_display_command): Update.
4584         (do_enable_disable_display): Remove.
4585         (enable_disable_display_command)
4586         (clear_dangling_display_expressions): Update.
4587
4588 2020-05-08  Tom Tromey  <tom@tromey.com>
4589
4590         * symtab.c (set_symbol_cache_size)
4591         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
4592         (maintenance_print_symbol_cache_statistics): Update.
4593         * symmisc.c (print_symbol_bcache_statistics)
4594         (print_objfile_statistics, maintenance_print_objfiles)
4595         (maintenance_info_symtabs, maintenance_check_symtabs)
4596         (maintenance_expand_symtabs, maintenance_info_line_tables):
4597         Update.
4598         * symfile-debug.c (set_debug_symfile): Update.
4599         * source.c (forget_cached_source_info): Update.
4600         * python/python.c (gdbpy_progspaces): Update.
4601         * psymtab.c (maintenance_info_psymtabs): Update.
4602         * probe.c (parse_probes): Update.
4603         * linespec.c (iterate_over_all_matching_symtabs)
4604         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
4605         * guile/scm-progspace.c (gdbscm_progspaces): Update.
4606         * exec.c (exec_target::close): Update.
4607         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
4608         * breakpoint.c (print_one_breakpoint_location)
4609         (create_longjmp_master_breakpoint)
4610         (create_std_terminate_master_breakpoint): Update.
4611         * progspace.c (program_spaces): Now a std::vector.
4612         (maybe_new_address_space): Update.
4613         (add_program_space): Remove.
4614         (program_space::program_space): Update.
4615         (remove_program_space): Update.
4616         (number_of_program_spaces): Remove.
4617         (print_program_space, update_address_spaces): Update.
4618         * progspace.h (program_spaces): Change type.
4619         (ALL_PSPACES): Remove.
4620         (number_of_program_spaces): Don't declare.
4621         (struct program_space) <next>: Remove.
4622
4623 2020-05-08  Tom Tromey  <tom@tromey.com>
4624
4625         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
4626         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
4627         (enable_break): Update.
4628         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
4629         (frv_fdpic_find_canonical_descriptor): Update.
4630         (frv_fetch_objfile_link_map): Update.
4631         * progspace.c (program_space::free_all_objfiles): Update.
4632         (program_space::solibs): New method.
4633         * progspace.h (struct program_space) <solibs>: New method.
4634         * solist.h (master_so_list): Don't declare.
4635         (ALL_SO_LIBS): Remove.
4636         * solib.h (so_list_head): Remove.
4637         (update_solib_list): Update comment.
4638         * solib.c (master_so_list): Remove.
4639         (solib_used, update_solib_list, solib_add)
4640         (info_sharedlibrary_command, clear_solib)
4641         (reload_shared_libraries_1, remove_user_added_objfile): Update.
4642
4643 2020-05-08  Tom Tromey  <tom@tromey.com>
4644
4645         * extension.c (extension_languages): Now a std::array.
4646         (ALL_EXTENSION_LANGUAGES): Remove.
4647         (get_ext_lang_defn, get_ext_lang_of_file)
4648         (eval_ext_lang_from_control_command): Update.
4649         (finish_ext_lang_initialization)
4650         (auto_load_ext_lang_scripts_for_objfile)
4651         (ext_lang_type_printers::ext_lang_type_printers)
4652         (apply_ext_lang_type_printers)
4653         (ext_lang_type_printers::~ext_lang_type_printers)
4654         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
4655         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
4656         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
4657         (get_matching_xmethod_workers, ext_lang_colorize)
4658         (ext_lang_before_prompt): Update.
4659         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
4660
4661 2020-05-08  Tom Tromey  <tom@tromey.com>
4662
4663         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
4664         overload.
4665         <swap_string, m_string>: Remove.
4666         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
4667         Update.
4668         * stabsread.c (define_symbol, read_type): Update.
4669         * linespec.c (find_linespec_symbols): Update.
4670         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
4671         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
4672         * dbxread.c (read_dbx_symtab): Update.
4673         * cp-support.h (cp_canonicalize_string_full)
4674         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
4675         Return unique_xmalloc_ptr.
4676         * cp-support.c (inspect_type): Update.
4677         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
4678         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
4679         Likewise.
4680         * c-typeprint.c (print_name_maybe_canonical): Update.
4681         * break-catch-throw.c (check_status_exception_catchpoint):
4682         Update.
4683
4684 2020-05-08  Tom de Vries  <tdevries@suse.de>
4685
4686         * infrun.c (follow_fork): Copy current_line and current_symtab to
4687         child thread.
4688
4689 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
4690
4691         * async-event.c (struct async_signal_handler, struct
4692         async_event_handler): Reformat, remove typedef.
4693
4694 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
4695
4696         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
4697         access thistype->main_type->dyn_prop_list directly.
4698
4699 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
4700
4701         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
4702         (remove_dyn_prop): Remove.  Update all users to use
4703         type::remove_dyn_prop.
4704         * gdbtypes.c (remove_dyn_prop): Rename to...
4705         (type::remove_dyn_prop): ... this.
4706
4707 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
4708
4709         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
4710         (add_dyn_prop): Remove.  Update all users to use
4711         type::add_dyn_prop.
4712         * gdbtypes.c (add_dyn_prop): Rename to...
4713         (type::add_dyn_prop): ... this.
4714
4715 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
4716
4717         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
4718         (get_dyn_prop): Remove.  Update all users to use
4719         type::dyn_prop.
4720         * gdbtypes.c (get_dyn_prop): Rename to...
4721         (type::dyn_prop): ... this.
4722
4723 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
4724
4725         * gdbtypes.h (struct main_type) <flag_static>: Remove.
4726
4727 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
4728
4729         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
4730         instruction, skip it if it's there.
4731
4732 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
4733
4734         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
4735
4736 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
4737
4738         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
4739         * gdbtypes.c (recursive_dump_type): Remove use of
4740         TYPE_INCOMPLETE.
4741
4742 2020-05-03  Tom Tromey  <tom@tromey.com>
4743
4744         * breakpoint.c (catch_command, tcatch_command): Remove.
4745         (_initialize_breakpoint): Use add_basic_prefix_cmd,
4746         add_show_prefix_cmd.
4747         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
4748         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
4749         Remove.
4750         (add_internal_problem_command): Use add_basic_prefix_cmd,
4751         add_show_prefix_cmd.
4752         * mips-tdep.c (set_mipsfpu_command): Remove.
4753         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
4754         * dwarf2/index-cache.c (set_index_cache_command): Remove.
4755         (_initialize_index_cache): Use add_basic_prefix_cmd.
4756         * memattr.c (dummy_cmd): Remove.
4757         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
4758         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
4759         (_initialize_tui_win): Use add_basic_prefix_cmd,
4760         add_show_prefix_cmd.
4761         * cli/cli-logging.c (set_logging_command): Remove.
4762         (_initialize_cli_logging): Use add_basic_prefix_cmd,
4763         add_show_prefix_cmd.
4764         (show_logging_command): Remove.
4765         * target.c (target_command): Remove.
4766         (add_target): Use add_basic_prefix_cmd.
4767
4768 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
4769
4770         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
4771
4772 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4773
4774         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
4775         info_command.
4776
4777 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
4778
4779         * nbsd-nat.c (nbsd_enable_proc_events)
4780         (nbsd_nat_target::post_startup_inferior): Add.
4781         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
4782         (nbsd_nat_target::update_thread_list): Rewrite.
4783         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
4784         "PTRACE_LWP_CREATE".
4785         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
4786
4787 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4788
4789         * stack.c (_initialize_stack): Remove duplicated creation
4790         of "frame" command and "f" alias.
4791
4792 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
4793
4794         PR gdb/18706
4795         * gdbtypes.c (check_typedef): Calculate size of array of
4796         stubbed type.
4797
4798 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
4799
4800         PR gdb/15559
4801         * i386-tdep.c (i386_push_dummy_call): Call
4802         i386_thiscall_push_dummy_call.
4803         (i386_thiscall_push_dummy_call): New function.
4804         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
4805         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
4806         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
4807
4808 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4809
4810         * gdbarch.sh (do_read): Add shellcheck disable directive for
4811         warning SC2162.
4812
4813 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4814
4815         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
4816         "referenced but not assigned" warning.
4817
4818 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4819
4820         * gdbarch.sh: Remove code that sets fallbackdefault.
4821
4822 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4823
4824         * gdbarch.sh: Use shell operators && and || instead of
4825         -a and -o.
4826
4827 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4828
4829         * gdbarch.sh: Use $(...) instead of `...`.
4830
4831 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4832
4833         * gdbarch.sh: Use double quotes around variables.
4834
4835 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
4836
4837         * gdbarch.sh: Use %s with printf, instead of variables in the
4838         format string.
4839
4840 2020-04-29  Tom Tromey  <tromey@adacore.com>
4841
4842         PR ada/25875:
4843         * dwarf2/read.c (update_enumeration_type_from_children): Compute
4844         type fields here.
4845         (read_enumeration_type): Call
4846         update_enumeration_type_from_children later.  Update comments.
4847         (process_enumeration_scope): Don't create type fields.
4848
4849 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
4850
4851         * nbsd-tdep.c: Include "xml-syscall.h".
4852         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
4853
4854 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
4855
4856         * nbsd-nat.c: Include "sys/wait.h".
4857         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
4858         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
4859         (nbsd_nat_target::remove_exec_catchpoint)
4860         (nbsd_nat_target::set_syscall_catchpoint): Add.
4861         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
4862         (nbsd_nat_target::insert_exec_catchpoint)
4863         (nbsd_nat_target::remove_exec_catchpoint)
4864         (nbsd_nat_target::set_syscall_catchpoint): Add.
4865         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
4866         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
4867         `nbsd_get_syscall_number'.
4868
4869 2020-04-29  Tom Tromey  <tom@tromey.com>
4870
4871         * stack.c (print_block_frame_labels): Remove.
4872
4873 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
4874
4875         PR gdb/17320
4876         * ada-valprint.c (val_print_packed_array_elements): Move array
4877         end bracket to new line.
4878         (ada_val_print_string): Remove extra spaces before first array
4879         element.
4880         * c-valprint.c (c_value_print_array): Likewise.
4881         * m2-valprint.c (m2_print_array_contents): Likewise.
4882         (m2_value_print_inner): Likewise.
4883         * p-valprint.c (pascal_value_print_inner): Likewise.
4884         * valprint.c (generic_val_print_array): Likewise.
4885         (value_print_array_elements): Move first array element and array
4886         end bracket to new line.
4887
4888 2020-04-29  Tom de Vries  <tdevries@suse.de>
4889
4890         PR symtab/25889
4891         * linespec.c (find_method): Fix ix calculation.
4892
4893 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
4894
4895         * syscalls/update-netbsd.sh: New file.
4896         * syscalls/netbsd.xml: Regenerate.
4897         * data-directory/Makefile.in: Register `netbsd.xml' in
4898         `SYSCALLS_FILES'.
4899
4900 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
4901
4902         * syscalls/update-freebsd.sh: Add double quotes.
4903
4904 2020-04-28  Tom Tromey  <tom@tromey.com>
4905
4906         * NEWS: Update.
4907         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
4908         (cmdpy_init): Allow class_tui.
4909
4910 2020-04-28 Mark Williams <mark@myosotissp.com>
4911
4912         PR gdb/24480
4913         * dwarf2read.c: Add missing assingments to list_in_scope when
4914         start_symtab was already called.
4915
4916 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
4917
4918         PR gdb/25881
4919         * dwarf2/read.c (offset_map_type): Use
4920         gdb:hash_enum<sect_offset> as hash function.
4921
4922 2020-04-28  Tom de Vries  <tdevries@suse.de>
4923
4924         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
4925         with DW_AT_signature.
4926
4927 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
4928
4929         * configure.ac: Remove check for fs_base/gs_base in
4930         user_regs_struct.
4931         * configure: Re-generate.
4932         * config.in: Re-generate.
4933         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
4934         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
4935         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
4936
4937 2020-04-27  Luis Machado  <luis.machado@linaro.org>
4938
4939         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
4940         problematic inline frame unwinding situation.
4941         * frame.c (frame_id_computed_p): New function.
4942         * frame.h (frame_id_computed_p): New prototype.
4943
4944 2020-04-26  Tom Tromey  <tom@tromey.com>
4945
4946         * command.h (enum command_class) <class_pseudo>: Remove.
4947
4948 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4949
4950         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
4951         and whitespace.
4952
4953 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
4954
4955         * inf-ptrace.c (inf_ptrace_target::wait): Remove
4956         `PT_GET_PROCESS_STATE' block.
4957
4958 2020-04-24  Tom Tromey  <tom@tromey.com>
4959
4960         * symtab.h (symbol_get_demangled_name): Don't declare.
4961         * symtab.c (symbol_get_demangled_name): Remove.
4962         (general_symbol_info::natural_name)
4963         (general_symbol_info::demangled_name): Update.
4964
4965 2020-04-24  Tom Tromey  <tom@tromey.com>
4966
4967         PR rust/25025:
4968         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
4969
4970 2020-04-24  Tom Tromey  <tom@tromey.com>
4971
4972         PR symtab/12707:
4973         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
4974         exists.
4975         (new_symbol): Likewise.
4976         * compile/compile-object-load.c (get_out_value_type): Use
4977         symbol_matches_search_name.
4978
4979 2020-04-24  Tom Tromey  <tom@tromey.com>
4980
4981         * dwarf2/read.c (add_partial_symbol): Do not call
4982         compute_and_set_names.
4983
4984 2020-04-24  Tom Tromey  <tom@tromey.com>
4985
4986         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
4987         overload.
4988
4989 2020-04-24  Tom Tromey  <tom@tromey.com>
4990
4991         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
4992         (add_psymbol_to_list): New overload.  Make old overload call new
4993         one.
4994         * psympriv.h (add_psymbol_to_list): New overload.
4995
4996 2020-04-24  Tom Tromey  <tom@tromey.com>
4997
4998         * dwarf2/read.c (partial_die_info::read) <case
4999         DW_AT_linkage_name>: Use value_as_string.
5000         (dwarf2_string_attr): Use value_as_string.
5001         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
5002         method.
5003         * dwarf2/attribute.c (attribute::value_as_string): New method.
5004
5005 2020-04-24  Tom Tromey  <tom@tromey.com>
5006
5007         * symtab.c (general_symbol_info::natural_name)
5008         (general_symbol_info::demangled_name): Check for language_rust.
5009
5010 2020-04-24  Tom Tromey  <tom@tromey.com>
5011
5012         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
5013         (dwarf2_physname): ... from here.
5014         (partial_die_info::read): Add Rust "{" hack.
5015
5016 2020-04-24  Tom Tromey  <tom@tromey.com>
5017
5018         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
5019         method.
5020         (symbol_set_demangled_name): Don't declare.
5021         * symtab.c (general_symbol_info::set_demangled_name): Rename from
5022         symbol_set_demangled_name.
5023         (general_symbol_info::set_language)
5024         (general_symbol_info::compute_and_set_names): Update.
5025         * minsyms.c (minimal_symbol_reader::install): Update.
5026         * dwarf2/read.c (new_symbol): Update.
5027
5028 2020-04-24  Tom Tromey  <tromey@adacore.com>
5029
5030         PR python/23662:
5031         * python/py-type.c (convert_field): Handle
5032         FIELD_LOC_KIND_DWARF_BLOCK.
5033         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
5034         (typy_get_dynamic): Nw function.
5035         (type_object_getset): Add "dynamic".
5036         * NEWS: Add entry.
5037
5038 2020-04-24  Tom Tromey  <tromey@adacore.com>
5039
5040         * ada-typeprint.c (print_choices, print_variant_part)
5041         (print_record_field_types_dynamic): New functions.
5042         (print_record_field_types): Use print_record_field_types_dynamic.
5043
5044 2020-04-24  Tom Tromey  <tromey@adacore.com>
5045
5046         * dwarf2/read.c (handle_data_member_location): New overload.
5047         (dwarf2_add_field): Use it.
5048         (decode_locdesc): Add "computed" parameter.  Update comment.
5049         * gdbtypes.c (is_dynamic_type_internal): Also look for
5050         FIELD_LOC_KIND_DWARF_BLOCK.
5051         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
5052         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
5053         virtual base classes.
5054         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
5055         FIELD_LOC_KIND_DWARF_BLOCK.
5056
5057 2020-04-24  Tom Tromey  <tromey@adacore.com>
5058
5059         * dwarf2/read.c (read_structure_type): Handle dynamic length.
5060         * gdbtypes.c (is_dynamic_type_internal): Check
5061         TYPE_HAS_DYNAMIC_LENGTH.
5062         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
5063         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
5064         New macros.
5065         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
5066         constant.
5067
5068 2020-04-24  Tom Tromey  <tromey@adacore.com>
5069
5070         * dwarf2/read.c (struct variant_field): Rewrite.
5071         (struct variant_part_builder): New.
5072         (struct nextfield): Remove "variant" field.  Add "offset".
5073         (struct field_info): Add "current_variant_part" and
5074         "variant_parts".
5075         (alloc_discriminant_info): Remove.
5076         (alloc_rust_variant): New function.
5077         (quirk_rust_enum): Update.
5078         (dwarf2_add_field): Set "offset" member.  Don't handle
5079         DW_TAG_variant_part.
5080         (offset_map_type): New typedef.
5081         (convert_variant_range, create_one_variant)
5082         (create_one_variant_part, create_variant_parts)
5083         (add_variant_property): New functions.
5084         (dwarf2_attach_fields_to_type): Call add_variant_property.
5085         (read_structure_type): Don't handle DW_TAG_variant_part.
5086         (handle_variant_part, handle_variant): New functions.
5087         (handle_struct_member_die): Use them.
5088         (process_structure_scope): Don't handle variant parts.
5089         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
5090         (struct discriminant_info): Remove.
5091         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
5092         (struct main_type) <flag_discriminated_union>: Remove.
5093         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
5094         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
5095         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
5096         Update.
5097         * valops.c (value_union_variant): Remove.
5098         * value.h (value_union_variant): Don't declare.
5099
5100 2020-04-24  Tom Tromey  <tromey@adacore.com>
5101
5102         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
5103         (ada_value_primitive_packed_val): Update.
5104         * ada-valprint.c (ada_value_print_1): Update.
5105         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
5106         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
5107         just an address.  Use evaluate_for_locexpr_baton.
5108         (dwarf2_evaluate_property): Update.
5109         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
5110         array_view.
5111         * findvar.c (default_read_var_value): Update.
5112         * gdbtypes.c (compute_variant_fields_inner)
5113         (resolve_dynamic_type_internal): Update.
5114         (resolve_dynamic_type): Change type of valaddr parameter.
5115         * gdbtypes.h (resolve_dynamic_type): Update.
5116         * valarith.c (value_subscripted_rvalue): Update.
5117         * value.c (value_from_contents_and_address): Update.
5118
5119 2020-04-24  Tom Tromey  <tromey@adacore.com>
5120
5121         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
5122         "push_initial_value" parameter.
5123         (dwarf2_evaluate_property): Likewise.
5124         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
5125
5126 2020-04-24  Tom Tromey  <tromey@adacore.com>
5127
5128         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
5129         (variant::matches, compute_variant_fields_recurse)
5130         (compute_variant_fields_inner, compute_variant_fields): New
5131         functions.
5132         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
5133         Use resolved_type after type is made.
5134         (operator==): Add new cases.
5135         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
5136         (struct discriminant_range, struct variant, struct variant_part):
5137         New.
5138         (union dynamic_prop_data) <variant_parts, original_type>: New
5139         members.
5140         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
5141         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
5142         constants.
5143         * value.c (unpack_bits_as_long): Now public.
5144         * value.h (unpack_bits_as_long): Declare.
5145
5146 2020-04-24  Tom Tromey  <tromey@adacore.com>
5147
5148         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
5149         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
5150
5151 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
5152
5153         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
5154
5155 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
5156
5157         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
5158         (remove_fork_catchpoint, post_startup_inferior)
5159         (post_attach): Move...
5160         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
5161         (remove_fork_catchpoint, post_startup_inferior)
5162         (post_attach): ...here.
5163         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
5164         (remove_fork_catchpoint, post_startup_inferior)
5165         (post_attach): Move...
5166         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
5167         (remove_fork_catchpoint, post_startup_inferior)
5168         (post_attach): ...here.
5169
5170 2020-04-24  Tom Tromey  <tromey@adacore.com>
5171
5172         * nat/windows-nat.h (struct windows_thread_info)
5173         <pc_adjusted>: New member.
5174         * windows-nat.c (windows_fetch_one_register): Check
5175         pc_adjusted.
5176         (windows_nat_target::get_windows_debug_event)
5177         (windows_nat_target::wait): Set pc_adjusted.
5178
5179 2020-04-24  Tom de Vries  <tdevries@suse.de>
5180
5181         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
5182         Run gdb-add-index inside temp dir.
5183
5184 2020-04-23  Tom Tromey  <tromey@adacore.com>
5185
5186         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
5187         in loop.
5188
5189 2020-04-23  Luis Machado  <luis.machado@linaro.org>
5190
5191         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
5192         get_frame_register instead of gdbarch_unwind_pc.
5193
5194 2020-04-23  Tom de Vries  <tdevries@suse.de>
5195
5196         * symtab.c (lookup_global_symbol): Prefer def over decl.
5197
5198 2020-04-23  Tom de Vries  <tdevries@suse.de>
5199
5200         PR symtab/25807
5201         * block.c (best_symbol, better_symbol): Promote to external.
5202         * block.h (best_symbol, better_symbol): Declare.
5203         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
5204         decl.
5205
5206 2020-04-23  Tom Tromey  <tromey@adacore.com>
5207
5208         PR ada/25837:
5209         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
5210         "const char *", not a "const std::string &".
5211         <name_and_matcher::operator==>: Update.
5212         * unittests/lookup_name_info-selftests.c: Change type of
5213         "result".
5214
5215 2020-04-23  Tom Tromey  <tom@tromey.com>
5216
5217         * inferior.h (iterate_over_inferiors): Don't declare.
5218         * inferior.c (iterate_over_inferiors): Remove.
5219         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
5220         Remove.
5221         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
5222         use iterate_over_inferiors.
5223         (darwin_resume_inferior_it)
5224         (struct resume_inferior_threads_param)
5225         (darwin_resume_inferior_threads_it): Remove.
5226         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
5227
5228 2020-04-23  Tom de Vries  <tdevries@suse.de>
5229
5230         * blockframe.c (find_pc_partial_function): Use
5231         find_pc_sect_compunit_symtab rather than
5232         objfile->sf->qf->find_pc_sect_compunit_symtab.
5233
5234 2020-04-22  Tom de Vries  <tdevries@suse.de>
5235
5236         PR symtab/25764
5237         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
5238         in psymtabs.
5239
5240 2020-04-22  Tom de Vries  <tdevries@suse.de>
5241
5242         PR symtab/25801
5243         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
5244         symtabs.
5245
5246 2020-04-22  Tom de Vries  <tdevries@suse.de>
5247
5248         PR symtab/25700
5249         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
5250         CU if already created.
5251
5252 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5253
5254         * infrun.c (displaced_step_fixup): Switch to the event_thread
5255         before calling displaced_step_restore, not after.
5256
5257 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
5258
5259         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
5260         its inferior is not recorded by us.
5261         (record_btrace_target_open): Replace call to
5262         all_non_exited_threads () with call to current_inferior
5263         ()->non_exited_threads ().
5264         (record_btrace_target::stop_recording): Likewise.
5265         (record_btrace_target::close): Likewise.
5266         (record_btrace_target::wait): Likewise.
5267         (record_btrace_target::record_stop_replaying): Likewise.
5268
5269 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
5270
5271         * btrace.c (btrace_enable): Throw an error on double enables and
5272         when enabling recording fails.
5273         (btrace_disable): Throw an error if the thread is not recorded.
5274
5275 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
5276
5277         * record-btrace.c (record_btrace_target::fetch_registers): Forward
5278         request if we do not have a thread_info.
5279
5280 2020-04-21  Tom de Vries  <tdevries@suse.de>
5281
5282         PR gdb/25471
5283         * thread.c
5284         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
5285         exception in get_frame_id.
5286
5287 2020-04-20  Tom Tromey  <tromey@adacore.com>
5288
5289         * python/python.c (struct gdbpy_event): Mark move constructor as
5290         noexcept.
5291         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
5292         constructor as noexcept.
5293         * completer.h (struct completion_result): Mark move constructor as
5294         noexcept.
5295         * completer.c (completion_result::completion_result): Use
5296         initialization style.  Don't call reset_match_list.
5297
5298 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
5299
5300         * MAINTAINERS (Write After Approval): Add myself.
5301
5302 2020-04-18  Tom Tromey  <tom@tromey.com>
5303
5304         * windows-tdep.c (init_w32_command_list)
5305         (w32_prefix_command_valid): Restore.
5306         (_initialize_windows_tdep): Call init_w32_command_list.
5307
5308 2020-04-18  Tom Tromey  <tom@tromey.com>
5309
5310         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
5311         * value.c (value_fn_field): Update.
5312         * valops.c (find_function_in_inferior)
5313         (value_allocate_space_in_inferior): Update.
5314         * tui/tui-winsource.c (tui_update_source_windows_with_line):
5315         Update.
5316         * tui/tui-source.c (tui_source_window::set_contents): Update.
5317         * symtab.c (lookup_global_or_static_symbol)
5318         (find_function_start_sal_1, skip_prologue_sal)
5319         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
5320         * symmisc.c (dump_msymbols, dump_symtab_1)
5321         (maintenance_print_one_line_table): Update.
5322         * symfile.c (init_entry_point_info, section_is_mapped)
5323         (list_overlays_command, simple_read_overlay_table)
5324         (simple_overlay_update_1): Update.
5325         * stap-probe.c (handle_stap_probe): Update.
5326         * stabsread.c (dbx_init_float_type, define_symbol)
5327         (read_one_struct_field, read_enum_type, read_range_type): Update.
5328         * source.c (info_line_command): Update.
5329         * python/python.c (gdbpy_source_objfile_script)
5330         (gdbpy_execute_objfile_script): Update.
5331         * python/py-type.c (save_objfile_types): Update.
5332         * python/py-objfile.c (py_free_objfile): Update.
5333         * python/py-inferior.c (python_new_objfile): Update.
5334         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
5335         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
5336         (maintenance_check_psymtabs): Update.
5337         * printcmd.c (info_address_command): Update.
5338         * objfiles.h (struct objfile) <arch>: New method, from
5339         get_objfile_arch.
5340         (get_objfile_arch): Don't declare.
5341         * objfiles.c (get_objfile_arch): Remove.
5342         (filter_overlapping_sections): Update.
5343         * minsyms.c (msymbol_is_function): Update.
5344         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
5345         (output_nondebug_symbol): Update.
5346         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
5347         (mdebug_expand_psymtab): Update.
5348         * machoread.c (macho_add_oso_symfile): Update.
5349         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
5350         Update.
5351         * linux-fork.c (checkpoint_command): Update.
5352         * linespec.c (convert_linespec_to_sals): Update.
5353         * jit.c (finalize_symtab): Update.
5354         * infrun.c (insert_exception_resume_from_probe): Update.
5355         * ia64-tdep.c (ia64_find_unwind_table): Update.
5356         * hppa-tdep.c (internalize_unwinds): Update.
5357         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
5358         Update.
5359         * gcore.c (call_target_sbrk): Update.
5360         * elfread.c (record_minimal_symbol, elf_symtab_read)
5361         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
5362         (elf_gnu_ifunc_resolve_by_got): Update.
5363         * dwarf2/read.c (create_addrmap_from_index)
5364         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5365         (read_debug_names_from_section)
5366         (process_psymtab_comp_unit_reader, add_partial_symbol)
5367         (add_partial_subprogram, process_full_comp_unit)
5368         (read_file_scope, read_func_scope, read_lexical_block_scope)
5369         (read_call_site_scope, dwarf2_ranges_read)
5370         (dwarf2_record_block_ranges, dwarf2_add_field)
5371         (mark_common_block_symbol_computed, read_tag_pointer_type)
5372         (read_tag_string_type, dwarf2_init_float_type)
5373         (dwarf2_init_complex_target_type, read_base_type)
5374         (partial_die_info::read, partial_die_info::read)
5375         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
5376         (dwarf2_fetch_die_loc_sect_off): Update.
5377         * dwarf2/loc.c (dwarf2_find_location_expression)
5378         (class dwarf_evaluate_loc_desc, rw_pieced_value)
5379         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
5380         (dwarf2_loc_desc_get_symbol_read_needs)
5381         (locexpr_describe_location_piece, locexpr_describe_location_1)
5382         (loclist_describe_location): Update.
5383         * dwarf2/index-write.c (write_debug_names): Update.
5384         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
5385         * dtrace-probe.c (dtrace_process_dof): Update.
5386         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
5387         (process_one_symbol): Update.
5388         * ctfread.c (ctf_init_float_type, read_base_type): Update.
5389         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
5390         (coff_read_enum_type): Update.
5391         * cli/cli-cmds.c (edit_command, list_command): Update.
5392         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
5393         * breakpoint.c (create_overlay_event_breakpoint)
5394         (create_longjmp_master_breakpoint)
5395         (create_std_terminate_master_breakpoint)
5396         (create_exception_master_breakpoint, get_sal_arch): Update.
5397         * block.c (block_gdbarch): Update.
5398         * annotate.c (annotate_source_line): Update.
5399
5400 2020-04-17  Tom Tromey  <tromey@adacore.com>
5401
5402         * auto-load.c (show_auto_load_cmd): Remove.
5403         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
5404         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
5405         (maintenance_print_arc_command): Remove.
5406         * tui/tui-win.c (tui_command): Remove.
5407         (tui_get_cmd_list): Use add_basic_prefix_cmd.
5408         * tui/tui-layout.c (tui_layout_command): Remove.
5409         (_initialize_tui_layout): Use add_basic_prefix_cmd.
5410         * python/python.c (user_set_python, user_show_python): Remove.
5411         (_initialize_python): Use add_basic_prefix_cmd,
5412         add_show_prefix_cmd.
5413         * guile/guile.c (set_guile_command, show_guile_command): Remove.
5414         (install_gdb_commands): Use add_basic_prefix_cmd,
5415         add_show_prefix_cmd.
5416         (info_guile_command): Remove.
5417         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
5418         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
5419         add_show_prefix_cmd.
5420         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
5421         Remove do_set and do_show parameters.
5422         * cli/cli-style.c (set_style, show_style): Remove.
5423         (_initialize_cli_style): Use add_basic_prefix_cmd,
5424         add_show_prefix_cmd.
5425         (cli_style_option::add_setshow_commands): Remove do_set and
5426         do_show parameters.
5427         (cli_style_option::add_setshow_commands): Use
5428         add_basic_prefix_cmd, add_show_prefix_cmd.
5429         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
5430         (set_style_name): Remove.
5431         * cli/cli-dump.c (dump_command, append_command): Remove.
5432         (srec_dump_command, ihex_dump_command, verilog_dump_command)
5433         (tekhex_dump_command, binary_dump_command)
5434         (binary_append_command): Remove.
5435         (_initialize_cli_dump): Use add_basic_prefix_cmd.
5436         * windows-tdep.c (w32_prefix_command_valid): Remove global.
5437         (init_w32_command_list): Remove; move into ...
5438         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
5439         * valprint.c (set_print, show_print, set_print_raw)
5440         (show_print_raw): Remove.
5441         (_initialize_valprint): Use add_basic_prefix_cmd,
5442         add_show_prefix_cmd.
5443         * typeprint.c (set_print_type, show_print_type): Remove.
5444         (_initialize_typeprint): Use add_basic_prefix_cmd,
5445         add_show_prefix_cmd.
5446         * record.c (set_record_command, show_record_command): Remove.
5447         (_initialize_record): Use add_basic_prefix_cmd,
5448         add_show_prefix_cmd.
5449         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
5450         add_show_prefix_cmd.
5451         (info_command, show_command, set_debug, show_debug): Remove.
5452         * top.h (set_history, show_history): Don't declare.
5453         * top.c (set_history, show_history): Remove.
5454         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
5455         (unset_tdesc_cmd): Remove.
5456         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
5457         add_show_prefix_cmd.
5458         * symtab.c (info_module_command): Remove.
5459         (_initialize_symtab): Use add_basic_prefix_cmd.
5460         * symfile.c (overlay_command): Remove.
5461         (_initialize_symfile): Use add_basic_prefix_cmd.
5462         * sparc64-tdep.c (info_adi_command): Remove.
5463         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
5464         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
5465         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
5466         add_show_prefix_cmd.
5467         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
5468         (_initialize_serial): Use add_basic_prefix_cmd,
5469         add_show_prefix_cmd.
5470         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
5471         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
5472         add_show_prefix_cmd.
5473         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
5474         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
5475         add_show_prefix_cmd.
5476         * riscv-tdep.c (show_riscv_command, set_riscv_command)
5477         (show_debug_riscv_command, set_debug_riscv_command): Remove.
5478         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
5479         add_show_prefix_cmd.
5480         * remote.c (remote_command, set_remote_cmd): Remove.
5481         (_initialize_remote): Use add_basic_prefix_cmd.
5482         * record-full.c (set_record_full_command)
5483         (show_record_full_command): Remove.
5484         (_initialize_record_full): Use add_basic_prefix_cmd,
5485         add_show_prefix_cmd.
5486         * record-btrace.c (cmd_set_record_btrace)
5487         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
5488         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
5489         (cmd_show_record_btrace_pt): Remove.
5490         (_initialize_record_btrace): Use add_basic_prefix_cmd,
5491         add_show_prefix_cmd.
5492         * ravenscar-thread.c (set_ravenscar_command)
5493         (show_ravenscar_command): Remove.
5494         (_initialize_ravenscar): Use add_basic_prefix_cmd,
5495         add_show_prefix_cmd.
5496         * mips-tdep.c (show_mips_command, set_mips_command)
5497         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
5498         add_show_prefix_cmd.
5499         * maint.c (maintenance_command, maintenance_info_command)
5500         (maintenance_check_command, maintenance_print_command)
5501         (maintenance_set_cmd, maintenance_show_cmd): Remove.
5502         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
5503         add_show_prefix_cmd.
5504         (show_per_command_cmd): Remove.
5505         * maint-test-settings.c (maintenance_set_test_settings_cmd):
5506         Remove.
5507         (maintenance_show_test_settings_cmd): Remove.
5508         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
5509         add_show_prefix_cmd.
5510         * maint-test-options.c (maintenance_test_options_command):
5511         Remove.
5512         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
5513         * macrocmd.c (macro_command): Remove
5514         (_initialize_macrocmd): Use add_basic_prefix_cmd.
5515         * language.c (set_check, show_check): Remove.
5516         (_initialize_language): Use add_basic_prefix_cmd,
5517         add_show_prefix_cmd.
5518         * infcmd.c (unset_command): Remove.
5519         (_initialize_infcmd): Use add_basic_prefix_cmd.
5520         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
5521         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
5522         add_show_prefix_cmd.
5523         * go32-nat.c (go32_info_dos_command): Remove.
5524         (_initialize_go32_nat): Use add_basic_prefix_cmd.
5525         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
5526         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
5527         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
5528         (_initialize_frame): Use add_basic_prefix_cmd,
5529         add_show_prefix_cmd.
5530         * dcache.c (set_dcache_command, show_dcache_command): Remove.
5531         (_initialize_dcache): Use add_basic_prefix_cmd,
5532         add_show_prefix_cmd.
5533         * cp-support.c (maint_cplus_command): Remove.
5534         (_initialize_cp_support): Use add_basic_prefix_cmd.
5535         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
5536         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
5537         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
5538         add_basic_prefix_cmd, add_show_prefix_cmd.
5539         * breakpoint.c (save_command): Remove.
5540         (_initialize_breakpoint): Use add_basic_prefix_cmd.
5541         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
5542         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
5543         add_show_prefix_cmd.
5544         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
5545         (set_ada_command, show_ada_command): Remove.
5546         (_initialize_ada_language): Use add_basic_prefix_cmd,
5547         add_show_prefix_cmd.
5548         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
5549
5550 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
5551
5552         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
5553         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
5554
5555 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
5556
5557         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
5558         warning messages.
5559
5560 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
5561
5562         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
5563         import table is not at beginning of .idata section.
5564
5565 2020-04-16  Pedro Alves  <palves@redhat.com>
5566
5567         * inferior.c (delete_inferior): Use delete operator directly
5568         instead of delete_program_space.
5569         * progspace.c (add_program_space): New, factored out from
5570         program_space::program_space.
5571         (remove_program_space): New, factored out from
5572         delete_program_space.
5573         (program_space::program_space): Remove intro comment.  Rewrite.
5574         (program_space::~program_space): Remove intro comment.  Call
5575         remove_program_space.
5576         (delete_program_space): Delete.
5577         * progspace.h (program_space::program_space): Make explicit.  Move
5578         intro comment here, adjusted.
5579         (program_space::~program_space): Move intro comment here,
5580         adjusted.
5581         (delete_program_space): Remove.
5582
5583 2020-04-16  Tom Tromey  <tromey@adacore.com>
5584
5585         * windows-nat.c (windows_nat::handle_access_violation): New
5586         function.
5587         * nat/windows-nat.h (handle_access_violation): Declare.
5588         * nat/windows-nat.c (handle_exception): Move Cygwin code to
5589         windows-nat.c.  Call handle_access_violation.
5590
5591 2020-04-16  Tom de Vries  <tdevries@suse.de>
5592
5593         PR symtab/25791
5594         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
5595         CUs without psymtab.
5596
5597 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
5598
5599         * python/python.c (do_start_initialization): Don't call
5600         PyEval_InitThreads for Python 3.9 and beyond.
5601
5602 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
5603
5604         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
5605         thread functions.
5606         (obsd_nat_target::wait): Likewise.
5607
5608 2020-04-15  Tom Tromey  <tromey@adacore.com>
5609
5610         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
5611         (DEBUG_EXCEPT): Use debug_printf.
5612
5613 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5614
5615         * completer.c (class completion_tracker::completion_hash_entry)
5616         <hash_name>: New member function.
5617         (completion_tracker::discard_completions): New callback to hash a
5618         completion_hash_entry, pass this to htab_create_alloc.
5619
5620 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
5621
5622         * windows-nat.c (windows_make_so): Warn rather than stopping with
5623         an error if realpath() fails.
5624
5625 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
5626
5627         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
5628         (nbsd_nat_target::info_proc): Add do_status.
5629
5630 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
5631             Tom de Vries  <tdevries@suse.de>
5632
5633         PR symtab/25718
5634         * psympriv.h (struct partial_symtab::read_symtab)
5635         (struct partial_symtab::expand_psymtab)
5636         (struct partial_symtab::read_dependencies): Update comments.
5637         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
5638         read_symtab for includer.
5639         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
5640         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
5641         (struct dwarf2_include_psymtab::m_readin): Remove.
5642         (struct dwarf2_include_psymtab::includer): New member function.
5643         (dwarf2_psymtab::expand_psymtab): Assert !readin.
5644
5645 2020-04-14  Tom de Vries  <tdevries@suse.de>
5646
5647         PR symtab/25720
5648         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
5649         with NULL symbol_matcher and lookup_name.
5650         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
5651         and lookup_name.
5652         * dwarf2/read.c (dw2_expand_symtabs_matching)
5653         (dw2_debug_names_expand_symtabs_matching): Same.
5654         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
5655         Make lookup_name a pointer.  Update comment.
5656         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
5657         lookup_name being a pointer.
5658         * symfile.c (expand_symtabs_matching): Same.
5659         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
5660         * linespec.c (iterate_over_all_matching_symtabs): Same.
5661
5662 2020-04-13  Tom Tromey  <tom@tromey.com>
5663
5664         * run-on-main-thread.c: Update include.
5665         * unittests/main-thread-selftests.c: Update include.
5666         * tui/tui-win.c: Update include.
5667         * tui/tui-io.c: Update include.
5668         * tui/tui-interp.c: Update include.
5669         * tui/tui-hooks.c: Update include.
5670         * top.h: Update include.
5671         * top.c: Update include.
5672         * ser-base.c: Update include.
5673         * remote.c: Update include.
5674         * remote-notif.c: Update include.
5675         * remote-fileio.c: Update include.
5676         * record-full.c: Update include.
5677         * record-btrace.c: Update include.
5678         * python/python.c: Update include.
5679         * posix-hdep.c: Update include.
5680         * mingw-hdep.c: Update include.
5681         * mi/mi-main.c: Update include.
5682         * mi/mi-interp.c: Update include.
5683         * main.c: Update include.
5684         * linux-nat.c: Update include.
5685         * interps.c: Update include.
5686         * infrun.c: Update include.
5687         * inf-loop.c: Update include.
5688         * event-top.c: Update include.
5689         * event-loop.c: Move to ../gdbsupport/.
5690         * event-loop.h: Move to ../gdbsupport/.
5691         * async-event.h: Update include.
5692         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
5693
5694 2020-04-13  Tom Tromey  <tom@tromey.com>
5695
5696         * tui/tui-win.c: Include async-event.h.
5697         * remote.c: Include async-event.h.
5698         * remote-notif.c: Include async-event.h.
5699         * record-full.c: Include async-event.h.
5700         * record-btrace.c: Include async-event.h.
5701         * infrun.c: Include async-event.h.
5702         * event-top.c: Include async-event.h.
5703         * event-loop.h: Move some declarations to async-event.h.
5704         * event-loop.c: Don't include ser-event.h or top.h.  Move some
5705         code to async-event.c.
5706         * async-event.h: New file.
5707         * async-event.c: New file.
5708         * Makefile.in (COMMON_SFILES): Add async-event.c.
5709         (HFILES_NO_SRCDIR): Add async-event.h.
5710
5711 2020-04-13  Tom Tromey  <tom@tromey.com>
5712
5713         * utils.c (flush_streams): New function.
5714         * event-loop.c (gdb_wait_for_event): Call flush_streams.
5715
5716 2020-04-13  Tom Tromey  <tom@tromey.com>
5717
5718         * event-loop.c (handle_file_event): Use warning, not
5719         printf_unfiltered.
5720
5721 2020-04-13  Tom Tromey  <tom@tromey.com>
5722
5723         * event-loop.c: Include <chrono>.
5724
5725 2020-04-13  Tom Tromey  <tom@tromey.com>
5726
5727         * gdb_select.h: Move to ../gdbsupport/.
5728         * event-loop.c: Update include path.
5729         * top.c: Update include path.
5730         * ser-base.c: Update include path.
5731         * ui-file.c: Update include path.
5732         * ser-tcp.c: Update include path.
5733         * guile/scm-ports.c: Update include path.
5734         * posix-hdep.c: Update include path.
5735         * ser-unix.c: Update include path.
5736         * gdb_usleep.c: Update include path.
5737         * mingw-hdep.c: Update include path.
5738         * inflow.c: Update include path.
5739         * infrun.c: Update include path.
5740         * event-top.c: Update include path.
5741
5742 2020-04-13  Tom Tromey  <tom@tromey.com>
5743
5744         * configure: Rebuild.
5745         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
5746
5747 2020-04-13  Tom Tromey  <tom@tromey.com>
5748
5749         * event-loop.h (start_event_loop): Don't declare.
5750         * event-loop.c (start_event_loop): Move...
5751         * main.c (start_event_loop): ...here.  Now static.
5752
5753 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
5754
5755         * MAINTAINERS: Update my email address.
5756
5757 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
5758
5759         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
5760         IP_ALL.
5761
5762 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
5763
5764         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
5765         (nbsd_nat_target::info_proc): Add do_cmdline.
5766
5767 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
5768
5769         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
5770         (nbsd_nat_target::info_proc): Add do_cwd.
5771
5772 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
5773
5774         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
5775
5776 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
5777
5778         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
5779         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
5780         (nbsd_nat_target::info_proc): New functions.
5781         * nbsd-nat.c (kinfo_get_vmmap): New function.
5782         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
5783         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
5784         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
5785         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
5786         functions.
5787         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
5788         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
5789         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
5790         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
5791         (KINFO_VME_FLAG_GROWS_DOWN): New.
5792
5793 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
5794
5795         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
5796         bit shift.
5797
5798 2020-04-10  Tom Tromey  <tromey@adacore.com>
5799
5800         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
5801
5802 2020-04-10  Tom Tromey  <tromey@adacore.com>
5803
5804         * symtab.c (get_symbol_address, get_msymbol_address): Skip
5805         separate debug files.
5806
5807 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
5808
5809         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
5810         Move to...
5811         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
5812         ... here.
5813         * windows-nat.c (windows_nat_target::get_windows_debug_event):
5814         Check for STATUS_WX86_BREAKPOINT.
5815         (windows_nat_target::wait): Same.
5816
5817 2020-04-10  Tom de Vries  <tdevries@suse.de>
5818
5819         PR cli/25808
5820         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
5821
5822 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
5823
5824         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
5825         (Write After Approval): Remove Tom de Vries.
5826
5827 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5828
5829         revert partially:
5830         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5831
5832         * buildsym.c (record_line): Fix undefined behavior and preserve
5833         lines at eof.
5834
5835 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
5836
5837         * auxv.h (svr4_auxv_parse): New.
5838         * auxv.c (default_auxv_parse): Split into default_auxv_parse
5839         and generic_auxv_parse.
5840         (svr4_auxv_parse): Add.
5841         * obsd-tdep.c: Include "auxv.h".
5842         (obsd_auxv_parse): Remove.
5843         (obsd_init_abi): Remove comment.
5844         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
5845         from `obsd_auxv_parse' to `svr4_auxv_parse'.
5846         * nbsd-tdep.c: Include "auxv.h".
5847         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
5848
5849 2020-04-08  Tom Tromey  <tromey@adacore.com>
5850
5851         * nat/windows-nat.h (last_wait_event): Don't declare.
5852         (wait_for_debug_event): Update comment.
5853         * nat/windows-nat.c (last_wait_event): Now static.
5854
5855 2020-04-08  Tom Tromey  <tromey@adacore.com>
5856
5857         * windows-nat.c (wait_for_debug_event): Move to
5858         nat/windows-nat.c.
5859         * nat/windows-nat.h (wait_for_debug_event): Declare.
5860         * nat/windows-nat.c (wait_for_debug_event): Move from
5861         windows-nat.c.  No longer static.
5862
5863 2020-04-08  Tom Tromey  <tromey@adacore.com>
5864
5865         * windows-nat.c (get_windows_debug_event): Use
5866         fetch_pending_stop.
5867         * nat/windows-nat.h (fetch_pending_stop): Declare.
5868         * nat/windows-nat.c (fetch_pending_stop): New function.
5869
5870 2020-04-08  Tom Tromey  <tromey@adacore.com>
5871
5872         * windows-nat.c (windows_continue): Use matching_pending_stop and
5873         continue_last_debug_event.
5874         * nat/windows-nat.h (matching_pending_stop)
5875         (continue_last_debug_event): Declare.
5876         * nat/windows-nat.c (DEBUG_EVENTS): New define.
5877         (matching_pending_stop, continue_last_debug_event): New
5878         functions.
5879
5880 2020-04-08  Tom Tromey  <tromey@adacore.com>
5881
5882         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
5883         (handle_exception_result): Move to nat/windows-nat.h.
5884         (DEBUG_EXCEPTION_SIMPLE): Remove.
5885         (windows_nat::handle_ms_vc_exception): New function.
5886         (handle_exception): Move to nat/windows-nat.c.
5887         (get_windows_debug_event): Update.
5888         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
5889         nat/windows-nat.c.
5890         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
5891         (handle_exception_result): Move from windows-nat.c.
5892         (handle_exception): Declare.
5893         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
5894         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
5895         windows-nat.c.
5896
5897 2020-04-08  Tom Tromey  <tromey@adacore.com>
5898
5899         * windows-nat.c (exception_count, event_count): Remove.
5900         (handle_exception, get_windows_debug_event)
5901         (do_initial_windows_stuff): Update.
5902
5903 2020-04-08  Tom Tromey  <tromey@adacore.com>
5904
5905         * windows-nat.c (windows_nat::handle_load_dll)
5906         (windows_nat::handle_unload_dll): Rename.  No longer static.
5907         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
5908         Declare.
5909
5910 2020-04-08  Tom Tromey  <tromey@adacore.com>
5911
5912         * complaints.h (stop_whining): Declare at top-level.
5913         (complaint): Don't declare stop_whining.
5914
5915 2020-04-08  Tom Tromey  <tromey@adacore.com>
5916
5917         * windows-nat.c (windows_nat::handle_output_debug_string):
5918         Rename.  No longer static.
5919         * nat/windows-nat.h (handle_output_debug_string): Declare.
5920
5921 2020-04-08  Tom Tromey  <tromey@adacore.com>
5922
5923         * windows-nat.c (current_process_handle, current_process_id)
5924         (main_thread_id, last_sig, current_event, last_wait_event)
5925         (current_windows_thread, desired_stop_thread_id, pending_stops)
5926         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
5927         (display_selectors, fake_create_process)
5928         (get_windows_debug_event): Update.
5929         * nat/windows-nat.h (current_process_handle, current_process_id)
5930         (main_thread_id, last_sig, current_event, last_wait_event)
5931         (current_windows_thread, desired_stop_thread_id, pending_stops)
5932         (struct pending_stop, siginfo_er): Move from windows-nat.c.
5933         * nat/windows-nat.c (current_process_handle, current_process_id)
5934         (main_thread_id, last_sig, current_event, last_wait_event)
5935         (current_windows_thread, desired_stop_thread_id, pending_stops)
5936         (siginfo_er): New globals.  Move from windows-nat.c.
5937
5938 2020-04-08  Tom Tromey  <tromey@adacore.com>
5939
5940         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
5941         (handle_load_dll): Update.
5942         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
5943
5944 2020-04-08  Tom Tromey  <tromey@adacore.com>
5945
5946         * windows-nat.c (enum thread_disposition_type): Move to
5947         nat/windows-nat.h.
5948         (windows_nat::thread_rec): Rename from thread_rec.  No longer
5949         static.
5950         (windows_add_thread, windows_nat_target::fetch_registers)
5951         (windows_nat_target::store_registers, handle_exception)
5952         (windows_nat_target::resume, get_windows_debug_event)
5953         (windows_nat_target::get_tib_address)
5954         (windows_nat_target::thread_name)
5955         (windows_nat_target::thread_alive): Update.
5956         * nat/windows-nat.h (enum thread_disposition_type): Move from
5957         windows-nat.c.
5958         (thread_rec): Declare.
5959
5960 2020-04-08  Tom Tromey  <tromey@adacore.com>
5961
5962         * windows-nat.c: Add "using namespace".
5963         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
5964         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
5965
5966 2020-04-08  Tom Tromey  <tromey@adacore.com>
5967
5968         * nat/windows-nat.h (struct windows_thread_info): Declare
5969         destructor.
5970         * nat/windows-nat.c (~windows_thread_info): New.
5971
5972 2020-04-08  Tom Tromey  <tromey@adacore.com>
5973
5974         PR gdb/22992
5975         * windows-nat.c (current_event): Update comment.
5976         (last_wait_event, desired_stop_thread_id): New globals.
5977         (struct pending_stop): New.
5978         (pending_stops): New global.
5979         (windows_nat_target) <stopped_by_sw_breakpoint>
5980         <supports_stopped_by_sw_breakpoint>: New methods.
5981         (windows_fetch_one_register): Add assertions.  Adjust PC.
5982         (windows_continue): Handle pending stops.  Suspend other threads
5983         when stepping.  Use last_wait_event
5984         (wait_for_debug_event): New function.
5985         (get_windows_debug_event): Use wait_for_debug_event.  Handle
5986         pending stops.  Queue spurious stops.
5987         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
5988         (windows_nat_target::kill): Use wait_for_debug_event.
5989         * nat/windows-nat.h (struct windows_thread_info)
5990         <stopped_at_software_breakpoint>: New field.
5991         * nat/windows-nat.c (windows_thread_info::resume): Clear
5992         stopped_at_software_breakpoint.
5993
5994 2020-04-08  Tom Tromey  <tromey@adacore.com>
5995
5996         * windows-nat.c (enum thread_disposition_type): New.
5997         (thread_rec): Replace "get_context" parameter with "disposition";
5998         change type.
5999         (windows_add_thread, windows_nat_target::fetch_registers)
6000         (windows_nat_target::store_registers, handle_exception)
6001         (windows_nat_target::resume, get_windows_debug_event)
6002         (windows_nat_target::get_tib_address)
6003         (windows_nat_target::thread_name)
6004         (windows_nat_target::thread_alive): Update.
6005
6006 2020-04-08  Tom Tromey  <tromey@adacore.com>
6007
6008         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
6009         (windows_continue): Use windows_continue::resume.
6010         * nat/windows-nat.h (struct windows_thread_info) <suspend,
6011         resume>: Declare new methods.
6012         * nat/windows-nat.c: New file.
6013         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
6014
6015 2020-04-08  Tom Tromey  <tromey@adacore.com>
6016
6017         * windows-nat.c (windows_add_thread, windows_delete_thread)
6018         (windows_nat_target::fetch_registers)
6019         (windows_nat_target::store_registers, fake_create_process)
6020         (windows_nat_target::resume, windows_nat_target::resume)
6021         (get_windows_debug_event, windows_nat_target::wait)
6022         (windows_nat_target::pid_to_str)
6023         (windows_nat_target::get_tib_address)
6024         (windows_nat_target::get_ada_task_ptid)
6025         (windows_nat_target::thread_name)
6026         (windows_nat_target::thread_alive): Use lwp, not tid.
6027
6028 2020-04-08  Tom Tromey  <tromey@adacore.com>
6029
6030         * windows-nat.c (handle_exception)
6031         (windows_nat_target::thread_name): Update.
6032         * nat/windows-nat.h (windows_thread_info): Remove destructor.
6033         <name>: Now unique_xmalloc_ptr.
6034
6035 2020-04-08  Tom Tromey  <tromey@adacore.com>
6036
6037         * windows-nat.c (thread_rec)
6038         (windows_nat_target::fetch_registers): Update.
6039         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
6040         Update comment.
6041         <debug_registers_changed, reload_context>: Now bool.
6042
6043 2020-04-08  Tom Tromey  <tromey@adacore.com>
6044
6045         * windows-nat.c (windows_add_thread): Use new.
6046         (windows_init_thread_list, windows_delete_thread): Use delete.
6047         (get_windows_debug_event): Update.
6048         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
6049         destructor, and initializers.
6050
6051 2020-04-08  Tom Tromey  <tromey@adacore.com>
6052
6053         * windows-nat.c (struct windows_thread_info): Remove.
6054         * nat/windows-nat.h: New file.
6055
6056 2020-04-08  Tom Tromey  <tromey@adacore.com>
6057
6058         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
6059         (thread_rec, windows_add_thread, windows_delete_thread)
6060         (windows_continue): Update.
6061
6062 2020-04-08  Tom Tromey  <tromey@adacore.com>
6063
6064         * windows-nat.c (struct windows_thread_info): Remove typedef.
6065         (thread_head): Remove.
6066         (thread_list): New global.
6067         (thread_rec, windows_add_thread, windows_init_thread_list)
6068         (windows_delete_thread, windows_continue): Update.
6069
6070 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
6071
6072         * windows-tdep.h (windows_init_abi): Add comment.
6073         (cygwin_init_abi): New declaration.
6074         * windows-tdep.c: Split signal enumeration in two, one for
6075         Windows and one for Cygwin.
6076         (windows_gdb_signal_to_target): Only deal with signal of the
6077         Windows OS ABI.
6078         (cygwin_gdb_signal_to_target): New function.
6079         (windows_init_abi): Rename to windows_init_abi_common, don't set
6080         gdb_signal_to_target gdbarch method.  Add new new function with
6081         this name.
6082         (cygwin_init_abi): New function.
6083         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
6084         comment.  Don't call windows_init_abi.
6085         (amd64_windows_init_abi): Add comment, call windows_init_abi.
6086         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
6087         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
6088         i386_windows_init_abi_common, don't call windows_init_abi.  Add
6089         a new function of this name.
6090         (i386_cygwin_init_abi): New function.
6091         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
6092         OS ABI Cygwin.
6093
6094 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
6095
6096         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
6097         parameter.c.
6098         (dwarf2_read_gdb_index): Update.
6099
6100 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
6101
6102         * nbsd-tdep.c: Include "objfiles.h".
6103         (nbsd_skip_solib_resolver): New.
6104         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
6105
6106 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
6107
6108         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
6109         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
6110         with DW_LLE_base_addressx are being emitted in DWARFv5.
6111         Add the newly added kind DW_LOC_OFFSET_PAIR also.
6112         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
6113         unsigned integer.
6114
6115 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
6116
6117         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
6118         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
6119         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
6120         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
6121         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
6122         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
6123         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
6124
6125
6126 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
6127
6128         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
6129         (read_loclist_index): New function definition.
6130         (lookup_loclist_base): New function definition.
6131         (read_loclist_header): New function definition.
6132         (dwarf2_cu): Add loclist_base and loclist_header field.
6133         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
6134         (read_full_die_1): Read the value of DW_AT_loclists_base.
6135         (read_attribute_reprocess): Handle DW_FORM_loclistx.
6136         (read_attribute_value): Handle DW_FORM_loclistx.
6137         (skip_one_die): Handle DW_FORM_loclistx.
6138         (loclist_header): New structure declaration.
6139         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
6140
6141 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
6142
6143         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
6144         constructor.  Remove `addr` parameter from other constructor and
6145         add `per_cu` parameter.
6146         * dwarf2/read.c (create_partial_symtab): Update.
6147
6148 2020-04-07  Tom de Vries  <tdevries@suse.de>
6149
6150         PR symtab/25796
6151         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
6152         (partial_die_info::fixup): Inherit has_const_value.
6153
6154 2020-04-07  Tom de Vries  <tdevries@suse.de>
6155
6156         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
6157         symbols without address.
6158
6159 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
6160
6161         * nbsd-nat.h (struct thread_info): Add forward declaration.
6162         (nbsd_nat_target::thread_alive): Add.
6163         (nbsd_nat_target::thread_name): Likewise.
6164         (nbsd_nat_target::update_thread_list): Likewise.
6165         (update_thread_list::post_attach): Likewise.
6166         (post_attach::pid_to_str): Likewise.
6167         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
6168         (nbsd_thread_lister): Add.
6169         (nbsd_nat_target::thread_alive): Likewise.
6170         (nbsd_nat_target::thread_name): Likewise.
6171         (nbsd_add_threads): Likewise.
6172         (update_thread_list::post_attach): Likewise.
6173         (nbsd_nat_target::update_thread_list): Likewise.
6174         (post_attach::pid_to_str): Likewise.
6175
6176 2020-04-06  Tom Tromey  <tromey@adacore.com>
6177
6178         * ada-valprint.c (print_variant_part): Extract the variant field.
6179         (print_field_values): Use the field as the outer value when
6180         recursing.
6181
6182 2020-04-06  Tom Tromey  <tromey@adacore.com>
6183
6184         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
6185         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
6186         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
6187         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
6188         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
6189
6190 2020-04-06  Tom Tromey  <tromey@adacore.com>
6191
6192         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
6193         TYPE_CODE_ERROR.
6194
6195 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
6196
6197         * nbsd-tdep.c: Include "gdbarch.h".
6198         Define enum with NetBSD signal numbers.
6199         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
6200         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
6201         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
6202         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
6203         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
6204         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
6205         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
6206         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
6207         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
6208         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
6209         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
6210         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
6211
6212 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
6213
6214         PR gdb/25325
6215         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
6216
6217 2020-04-03  Tom Tromey  <tromey@adacore.com>
6218
6219         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
6220         Read constant block.
6221
6222 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
6223
6224         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
6225         (gdb_bfd_get_full_section_contents): New declaration.
6226         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
6227         * windows-tdep.c (is_linked_with_cygwin_dll): Use
6228         gdb_bfd_get_full_section_contents.
6229
6230 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
6231
6232         * exec.c (build_section_table): Replace internal_error with
6233         gdb_assert.
6234         (section_table_xfer_memory_partial): Likewise.
6235         * mdebugread.c (parse_partial_symbols): Likewise.
6236         * psymtab.c (lookup_partial_symbol): Likewise.
6237         * utils.c (wrap_here): Likewise.
6238
6239 2020-04-02  Tom Tromey  <tromey@adacore.com>
6240
6241         * f-lang.c (build_fortran_types): Use arch_type to initialize
6242         builtin_complex_s32 in the TYPE_CODE_ERROR case.
6243
6244 2020-04-02  Tom Tromey  <tromey@adacore.com>
6245
6246         * dwarf2/read.c (partial_die_info::read): Do not create a vector
6247         of attributes.
6248
6249 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6250             Bernd Edlinger <bernd.edlinger@hotmail.de>
6251             Tom Tromey  <tromey@adacore.com>
6252
6253         * buildsym.c (buildsym_compunit::record_line): Remove
6254         deduplication code.
6255
6256 2020-04-02  Tom de Vries  <tdevries@suse.de>
6257
6258         PR ada/24671
6259         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
6260
6261 2020-04-02  Tom de Vries  <tdevries@suse.de>
6262
6263         * dwarf2/read.c (dwarf2_gdb_index_functions,
6264         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
6265         NULL.
6266         * psymtab.c (psym_lookup_global_symbol_language): New function.
6267         (psym_functions): Init psym_lookup_global_symbol_language with
6268         psym_lookup_global_symbol_language.
6269         * symfile-debug.c (debug_sym_quick_functions): Init
6270         lookup_global_symbol_language with NULL.
6271         * symfile.c (set_initial_language): Remove fixme comment.
6272         * symfile.h (struct quick_symbol_functions): Add
6273         lookup_global_symbol_language.
6274         * symtab.c (find_quick_global_symbol_language): New function.
6275         (find_main_name): Use find_quick_global_symbol_language.
6276
6277 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
6278
6279         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
6280
6281 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6282
6283         * buildsym.c (record_line): Fix undefined behavior and preserve
6284         lines at eof.
6285
6286 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6287
6288         * buildsym.c (record_line): Fix the resizing condition.
6289
6290 2020-04-01  Tom Tromey  <tom@tromey.com>
6291
6292         * value.h (value_literal_complex): Add comment.
6293         * valops.c (value_literal_complex): Refer to value.h.
6294
6295 2020-04-01  Tom Tromey  <tom@tromey.com>
6296
6297         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
6298         (scalar_type): New rule, from typebase.
6299         (typebase): Use scalar_type.  Recognize complex types.
6300         (field_name): Handle FLOAT_KEYWORD.
6301         (ident_tokens): Add _Complex and __complex__.
6302
6303 2020-04-01  Tom Tromey  <tom@tromey.com>
6304
6305         PR exp/25299:
6306         * valarith.c (promotion_type, complex_binop): New functions.
6307         (scalar_binop): Handle complex numbers.  Use promotion_type.
6308         (value_pos, value_neg, value_complement): Handle complex numbers.
6309
6310 2020-04-01  Tom Tromey  <tom@tromey.com>
6311
6312         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
6313         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
6314         (parse_number): Handle complex numbers.
6315
6316 2020-04-01  Tom Tromey  <tom@tromey.com>
6317
6318         * c-valprint.c (c_decorations): Change complex suffix to "i".
6319
6320 2020-04-01  Tom Tromey  <tom@tromey.com>
6321
6322         * valprint.c (generic_value_print_complex): Use accessors.
6323         * value.h (value_real_part, value_imaginary_part): Declare.
6324         * valops.c (value_real_part, value_imaginary_part): New
6325         functions.
6326         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
6327
6328 2020-04-01  Tom Tromey  <tom@tromey.com>
6329
6330         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
6331         (read_range_type): Update.
6332         * mdebugread.c (basic_type): Update.
6333         * go-lang.c (build_go_types): Use init_complex_type.
6334         * gdbtypes.h (struct main_type) <complex_type>: New member.
6335         (init_complex_type): Update.
6336         (arch_complex_type): Don't declare.
6337         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
6338         Make name if none given.  Use alloc_type_copy.  Look for cached
6339         complex type.
6340         (arch_complex_type): Remove.
6341         (gdbtypes_post_init): Use init_complex_type.
6342         * f-lang.c (build_fortran_types): Use init_complex_type.
6343         * dwarf2/read.c (read_base_type): Update.
6344         * d-lang.c (build_d_types): Use init_complex_type.
6345         * ctfread.c (read_base_type): Update.
6346
6347 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6348
6349         * infrun.c (stop_all_threads): Update assertion, plus when
6350         stopping threads, take into account that we might be trying
6351         to stop an all-stop target.
6352         (stop_waiting): Call 'stop_all_threads' if there exists a
6353         non-stop target.
6354
6355 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6356
6357         * target.h (exists_non_stop_target): New function declaration.
6358         * target.c (exists_non_stop_target): New function.
6359
6360 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
6361
6362         PR gdb/24789
6363         * eval.c (is_integral_or_integral_reference): New function.
6364         (evaluate_subexp_standard): Allow integer references in
6365         pointer arithmetic.
6366
6367 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6368
6369         * remote.c (remote_target::remote_parse_stop_reply): Remove the
6370         check for no ptid in the stop reply when the target is non-stop.
6371
6372 2020-04-01  Tom Tromey  <tromey@adacore.com>
6373
6374         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
6375         "name" parameter to rvalue reference.  Initialize m_name_holder.
6376         <lookup_name_info>: New overloads.
6377         <name>: Return gdb::string_view.
6378         <c_str>: New method.
6379         <make_ignore_params>: Update.
6380         <search_name_hash>: Update.
6381         <language_lookup_name>: Return const char *.
6382         <m_name>: Change type.
6383         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
6384         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
6385         (lookup_name_info::match_any): Update.
6386         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
6387         Update.
6388         * minsyms.c (linkage_name_str): Update.
6389         * language.c (default_symbol_name_matcher): Update.
6390         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
6391         Update.
6392         * ada-lang.c (ada_fold_name): Change parameter to string_view.
6393         (ada_lookup_name_info::ada_lookup_name_info): Update.
6394         (literal_symbol_name_matcher): Update.
6395
6396 2020-04-01  Tom Tromey  <tromey@adacore.com>
6397
6398         * psymtab.c (psymtab_search_name): Remove function.
6399         (psym_lookup_symbol): Create search name and lookup name here.
6400         (lookup_partial_symbol): Remove "name" parameter; add
6401         lookup_name.
6402         (psym_expand_symtabs_for_function): Update.
6403
6404 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
6405
6406         PR tui/25597:
6407         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
6408
6409 2020-03-31  Tom Tromey  <tromey@adacore.com>
6410
6411         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
6412         memcpy.
6413
6414 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
6415
6416         * features/riscv/32bit-csr.xml: Regenerated.
6417         * features/riscv/64bit-csr.xml: Regenerated.
6418
6419 2020-03-30  Tom Tromey  <tromey@adacore.com>
6420
6421         * ada-valprint.c (print_variant_part): Update.
6422         * ada-lang.h (ada_which_variant_applies): Update.
6423         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
6424         outer_valaddr parameters; replace with "outer" value parameter.
6425         (to_fixed_variant_branch_type): Update.
6426
6427 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6428
6429         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
6430         <list>.  Remove inclusion of observable.h.
6431         (PPC_DEBUG_CURRENT_VERSION): Move up define.
6432         (struct arch_lwp_info): New struct.
6433         (class ppc_linux_dreg_interface): New class.
6434         (struct ppc_linux_process_info): New struct.
6435         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
6436         <low_new_clone, low_forget_process, low_prepare_to_resume>
6437         <copy_thread_dreg_state, mark_thread_stale>
6438         <mark_debug_registers_changed, register_hw_breakpoint>
6439         <clear_hw_breakpoint, register_wp, clear_wp>
6440         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
6441         <num_memory_accesses, get_trigger_type>
6442         <create_watchpoint_request, hwdebug_point_cmp>
6443         <init_arch_lwp_info, get_arch_lwp_info>
6444         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
6445         methods.
6446         <struct ptid_hash>: New inner struct.
6447         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
6448         members.
6449         (saved_dabr_value, hwdebug_info, max_slots_number)
6450         (struct hw_break_tuple, struct thread_points, ppc_threads)
6451         (have_ptrace_hwdebug_interface)
6452         (hwdebug_find_thread_points_by_tid)
6453         (hwdebug_insert_point, hwdebug_remove_point): Remove.
6454         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
6455         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
6456         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
6457         use m_dreg_interface.
6458         (hwdebug_point_cmp): Change to...
6459         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
6460         reference arguments instead of pointers.
6461         (ppc_linux_nat_target::ranged_break_num_registers): Use
6462         m_dreg_interface.
6463         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
6464         m_dreg_interface.  Call register_hw_breakpoint.
6465         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
6466         m_dreg_interface.  Call clear_hw_breakpoint.
6467         (get_trigger_type): Change to...
6468         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
6469         comment.
6470         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
6471         use m_dreg_interface.  Call register_hw_breakpoint.
6472         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
6473         use m_dreg_interface.  Call clear_hw_breakpoint.
6474         (can_use_watchpoint_cond_accel): Change to...
6475         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
6476         method.  Update comment, use m_dreg_interface and
6477         m_process_info.
6478         (calculate_dvc): Change to...
6479         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
6480         m_dreg_interface.
6481         (num_memory_accesses): Change to...
6482         (ppc_linux_nat_target::num_memory_accesses): ...this method.
6483         (check_condition): Change to...
6484         (ppc_linux_nat_target::check_condition): ...this method.
6485         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
6486         comment, use m_dreg_interface.
6487         (create_watchpoint_request): Change to...
6488         (ppc_linux_nat_target::create_watchpoint_request): ...this
6489         method.  Use m_dreg_interface.
6490         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
6491         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
6492         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
6493         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
6494         (ppc_linux_nat_target::low_forget_process)
6495         (ppc_linux_nat_target::low_new_fork)
6496         (ppc_linux_nat_target::low_new_clone)
6497         (ppc_linux_nat_target::low_delete_thread)
6498         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
6499         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
6500         only call mark_thread_stale.
6501         (ppc_linux_thread_exit): Remove.
6502         (ppc_linux_nat_target::stopped_data_address): Change to...
6503         (ppc_linux_nat_target::low_stopped_data_address): This. Add
6504         comment, use m_dreg_interface and m_thread_hw_breakpoints.
6505         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
6506         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
6507         comment.  Call low_stopped_data_address.
6508         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
6509         m_dreg_interface.
6510         (ppc_linux_nat_target::masked_watch_num_registers): Use
6511         m_dreg_interface.
6512         (ppc_linux_nat_target::copy_thread_dreg_state)
6513         (ppc_linux_nat_target::mark_thread_stale)
6514         (ppc_linux_nat_target::mark_debug_registers_changed)
6515         (ppc_linux_nat_target::register_hw_breakpoint)
6516         (ppc_linux_nat_target::clear_hw_breakpoint)
6517         (ppc_linux_nat_target::register_wp)
6518         (ppc_linux_nat_target::clear_wp)
6519         (ppc_linux_nat_target::init_arch_lwp_info)
6520         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
6521         (_initialize_ppc_linux_nat): Remove observer callback.
6522
6523 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6524
6525         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
6526         (ppc_linux_nat_target::auxv_parse)
6527         (ppc_linux_nat_target::read_description)
6528         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
6529         Move up.
6530
6531 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6532
6533         * linux-nat.h (low_new_clone): New method.
6534         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
6535
6536 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
6537
6538         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
6539         (dbx_expand_psymtab): ... this.
6540         (start_psymtab): Update.
6541         * mdebugread.c (psymtab_to_symtab_1): Rename to...
6542         (mdebug_expand_psymtab): ... this.
6543         (parse_partial_symbols): Update.
6544         (new_psymtab): Update.
6545         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
6546         (xcoff_expand_psymtab): ... this.
6547         (xcoff_start_psymtab): Update.
6548
6549 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
6550
6551         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
6552         <expand_dependencies>: ... this.
6553         * psymtab.c (partial_symtab::read_dependencies): Rename to...
6554         (partial_symtab::expand_dependencies): ... this.
6555         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
6556         Update.
6557         (dwarf2_psymtab::expand_psymtab): Update.
6558         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
6559         * mdebugread.c (psymtab_to_symtab_1): Update.
6560         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
6561
6562 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
6563
6564         * psympriv.h (discard_psymtab): Remove.
6565         * dbxread.c (dbx_end_psymtab): Update.
6566         * xcoffread.c (xcoff_end_psymtab): Update.
6567
6568 2020-03-28  Tom Tromey  <tom@tromey.com>
6569
6570         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
6571         comment.
6572
6573 2020-03-28  Tom Tromey  <tom@tromey.com>
6574
6575         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
6576
6577 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
6578
6579         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
6580
6581 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
6582
6583         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
6584
6585 2020-03-26  Tom Tromey  <tom@tromey.com>
6586
6587         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
6588         (mark_common_block_symbol_computed, read_tag_string_type)
6589         (attr_to_dynamic_prop, read_subrange_type): Update.
6590         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
6591         to be methods on struct attribute.
6592         (skip_one_die, process_imported_unit_die, read_namespace_alias)
6593         (read_call_site_scope, partial_die_info::read)
6594         (partial_die_info::read, lookup_die_type, follow_die_ref):
6595         Update.
6596         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
6597         from dwarf2_get_ref_die_offset.
6598         (attribute::constant_value): New method, from
6599         dwarf2_get_attr_constant_value.
6600         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
6601         Declare method.
6602         <constant_value>: New method.
6603
6604 2020-03-26  Tom Tromey  <tom@tromey.com>
6605
6606         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
6607         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
6608         (dwarf_type_encoding_name): Move to stringify.c.
6609         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
6610         * dwarf2/stringify.c: New file.
6611         * dwarf2/stringify.h: New file.
6612
6613 2020-03-26  Tom Tromey  <tom@tromey.com>
6614
6615         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
6616         Rewrite.
6617
6618 2020-03-26  Tom Tromey  <tom@tromey.com>
6619
6620         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
6621         methods.
6622         * dwarf2/read.c (lookup_addr_base): Move to die.h.
6623         (lookup_ranges_base): Likewise.
6624         (read_cutu_die_from_dwo, read_full_die_1): Update.
6625
6626 2020-03-26  Tom Tromey  <tom@tromey.com>
6627
6628         * dwarf2/read.c (read_import_statement, read_file_scope)
6629         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
6630         (read_lexical_block_scope, read_call_site_scope)
6631         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
6632         (handle_struct_member_die, process_structure_scope)
6633         (update_enumeration_type_from_children)
6634         (process_enumeration_scope, read_array_type, read_common_block)
6635         (read_namespace, read_module, read_subroutine_type): Update.
6636         (sibling_die): Remove.
6637
6638 2020-03-26  Tom Tromey  <tom@tromey.com>
6639
6640         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
6641         (build_type_psymtabs_reader, read_structure_type)
6642         (read_enumeration_type, read_full_die_1): Update.
6643         (dwarf2_attr_no_follow): Move to die.h.
6644         * dwarf2/die.h (struct die_info) <attr>: New method.
6645
6646 2020-03-26  Tom Tromey  <tom@tromey.com>
6647
6648         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
6649         <base_address>: Now an optional.
6650         (dwarf2_find_base_address, dwarf2_rnglists_process)
6651         (dwarf2_ranges_process, fill_in_loclist_baton)
6652         (dwarf2_symbol_mark_computed): Update.
6653
6654 2020-03-26  Tom Tromey  <tom@tromey.com>
6655
6656         * dwarf2/read.c (struct die_info): Move to die.h.
6657         * dwarf2/die.h: New file.
6658
6659 2020-03-26  Tom Tromey  <tom@tromey.com>
6660
6661         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
6662         * dwarf2/read.c
6663         (dwarf2_statement_list_fits_in_line_number_section_complaint):
6664         Move to line-header.c.
6665         (read_checked_initial_length_and_offset, read_formatted_entries):
6666         Likewise.
6667         (dwarf_decode_line_header): Split into two.
6668         * dwarf2/line-header.c
6669         (dwarf2_statement_list_fits_in_line_number_section_complaint):
6670         Move from read.c.
6671         (read_checked_initial_length_and_offset, read_formatted_entries):
6672         Likewise.
6673         (dwarf_decode_line_header): New function, split from read.c.
6674
6675 2020-03-26  Tom Tromey  <tom@tromey.com>
6676
6677         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
6678         Declare method.
6679         * dwarf2/read.c (read_attribute_value): Update.
6680         (dwarf2_per_objfile::read_line_string): Rename from
6681         read_indirect_line_string.
6682         (read_formatted_entries): Update.
6683
6684 2020-03-26  Tom Tromey  <tom@tromey.com>
6685
6686         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
6687         variable.
6688
6689 2020-03-26  Tom Tromey  <tom@tromey.com>
6690
6691         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
6692         const.
6693         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
6694         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
6695         parameter const.
6696
6697 2020-03-26  Tom Tromey  <tom@tromey.com>
6698
6699         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
6700         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
6701         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
6702         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
6703
6704 2020-03-26  Tom Tromey  <tom@tromey.com>
6705
6706         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
6707         file_names_size, file_full_name, file_file_name>: Use const.
6708         <file_name_at, file_names>: Add const overload.
6709         * dwarf2/line-header.c (line_header::file_file_name)
6710         (line_header::file_full_name): Update.
6711
6712 2020-03-26  Tom Tromey  <tom@tromey.com>
6713
6714         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
6715         (macro_start_file, consume_improper_spaces)
6716         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
6717         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
6718         (dwarf_decode_macros): Move to macro.c.
6719         * dwarf2/macro.c: New file.
6720         * dwarf2/macro.h: New file.
6721         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
6722
6723 2020-03-26  Tom Tromey  <tom@tromey.com>
6724
6725         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
6726         method.
6727         * dwarf2/section.c: New method.  From
6728         read_indirect_string_at_offset_from.
6729         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
6730         (read_indirect_string_at_offset_from): Move to section.c.
6731         (read_indirect_string_at_offset): Rewrite.
6732         (read_indirect_line_string_at_offset): Remove.
6733         (read_indirect_string, read_indirect_line_string)
6734         (dwarf_decode_macro_bytes): Update.
6735
6736 2020-03-26  Tom Tromey  <tom@tromey.com>
6737
6738         * dwarf2/section.h (struct dwarf2_section_info)
6739         <overload_complaint>: Declare.
6740         (dwarf2_section_buffer_overflow_complaint): Don't declare.
6741         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
6742         Rename from dwarf2_section_buffer_overflow_complaint.
6743         * dwarf2/read.c (skip_one_die, partial_die_info::read)
6744         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
6745
6746 2020-03-26  Tom Tromey  <tom@tromey.com>
6747
6748         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
6749         Declare.
6750         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
6751         Move from read.c.
6752         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
6753         to section.c.
6754
6755 2020-03-26  Tom Tromey  <tom@tromey.com>
6756
6757         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
6758
6759 2020-03-26  Tom Tromey  <tom@tromey.com>
6760
6761         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
6762         "builder".
6763         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
6764         parameter.
6765         (dwarf_decode_macros): Update.
6766
6767 2020-03-26  Tom Tromey  <tom@tromey.com>
6768
6769         * dwarf2/read.c (read_attribute_value): Update.
6770         (read_indirect_string_from_dwz): Move to dwz.c; change into
6771         method.
6772         (dwarf_decode_macro_bytes): Update.
6773         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
6774         * dwarf2/dwz.c: New file.
6775         * Makefile.in (COMMON_SFILES): Add dwz.c.
6776
6777 2020-03-26  Tom Tromey  <tom@tromey.com>
6778
6779         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
6780         * dwarf2/read.c: Add include.
6781         * dwarf2/index-write.c: Add include.
6782         * dwarf2/index-cache.c: Add include.
6783         * dwarf2/dwz.h: New file.
6784
6785 2020-03-25  Tom Tromey  <tom@tromey.com>
6786
6787         * compile/compile-object-load.c (get_out_value_type): Mention
6788         correct symbol name in error message.
6789
6790 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
6791
6792         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
6793
6794 2020-03-25  Tom de Vries  <tdevries@suse.de>
6795
6796         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
6797         * symmisc.c (dump_symtab_1): Print user and includes fields.
6798         (maintenance_info_symtabs): Same.
6799
6800 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
6801
6802         PR gdb/25534
6803         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
6804         (riscv_regcache_cooked_write): New function.
6805         (riscv_push_dummy_call): Use new function.
6806         (riscv_return_value): Likewise.
6807
6808 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
6809
6810         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
6811         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
6812         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
6813         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
6814         * infrun.c (follow_fork): Likewise.
6815         (follow_fork_inferior): Likewise.
6816         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
6817         * linux-nat.h (class linux_nat_target): Likewise.
6818         * remote.c (class remote_target) <follow_fork>: Likewise.
6819         (remote_target::follow_fork): Likewise.
6820         * target-delegates.c: Re-generate.
6821         * target.c (default_follow_fork): Likewise.
6822         (target_follow_fork): Likewise.
6823         * target.h (struct target_ops) <follow_fork>: Likewise.
6824         (target_follow_fork): Likewise.
6825
6826 2020-03-24  Tom de Vries  <tdevries@suse.de>
6827
6828         * psymtab.c (maintenance_info_psymtabs): Print user field.
6829
6830 2020-03-20  Tom Tromey  <tromey@adacore.com>
6831
6832         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
6833         const.
6834         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
6835         const.
6836
6837 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
6838
6839         * ptrace.m4: Don't check for ptrace declaration.
6840         * config.in: Re-generate.
6841         * configure: Re-generate.
6842         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
6843         not defined.
6844
6845 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
6846
6847         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
6848         `PTRACE_TYPE_RET'.
6849         * i386-bsd-nat.c (gdb_ptrace): Likewise.
6850         * sparc-nat.c (gdb_ptrace): Likewise.
6851         * x86-bsd-nat.c (gdb_ptrace): Likewise.
6852
6853 2020-03-20  Tom Tromey  <tromey@adacore.com>
6854
6855         * c-exp.y (lex_one_token): Fix assert.
6856
6857 2020-03-20  Tom Tromey  <tromey@adacore.com>
6858
6859         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
6860         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
6861         strncpy call.
6862
6863 2020-03-20  Tom Tromey  <tromey@adacore.com>
6864
6865         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
6866
6867 2020-03-20  Tom Tromey  <tromey@adacore.com>
6868
6869         * ada-valprint.c (print_variant_part): Remove parameters; switch
6870         to value-based API.
6871         (print_field_values): Likewise.
6872         (ada_val_print_struct_union): Likewise.
6873         (ada_value_print_1): Update.
6874
6875 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
6876
6877         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
6878         nbsd_nat_target instead of inf_ptrace_target.
6879         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
6880         nbsd_nat_target.
6881
6882 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
6883
6884         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
6885         it to the ptrace call.
6886         * (store_registers): Likewise.
6887
6888 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
6889
6890         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
6891         it to the ptrace call.
6892         * (store_registers): Likewise.
6893
6894 2020-03-19  Luis Machado  <luis.machado@linaro.org>
6895
6896         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
6897         valid, fetch vg value from ptrace.
6898
6899 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
6900         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
6901         * inf-ptrace.c: Likewise.
6902         * (gdb_ptrace): Add.
6903         * (inf_ptrace_target::resume): Update.
6904         * (inf_ptrace_target::xfer_partial): Likewise.
6905         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
6906         * (inf_ptrace_peek_poke): Update.
6907
6908 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
6909
6910         * x86-bsd-nat.c (gdb_ptrace): New.
6911         * (x86bsd_dr_set): Add new argument `ptid'.
6912         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
6913         x86bsd_dr_set_addr): Update.
6914
6915 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6916
6917         * remote.c (remote_target::process_stop_reply): Handle events for
6918         all threads differently.
6919
6920 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6921
6922         * completer.c (completion_tracker::remove_completion): Define new
6923         function.
6924         * completer.h (completion_tracker::remove_completion): Declare new
6925         function.
6926         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
6927         when adding a C++ function symbol.
6928
6929 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6930
6931         * completer.c (completion_tracker::completion_hash_entry): Define
6932         new class.
6933         (advance_to_filename_complete_word_point): Call
6934         recompute_lowest_common_denominator.
6935         (completion_tracker::completion_tracker): Call discard_completions
6936         to setup the hash table.
6937         (completion_tracker::discard_completions): Allow for being called
6938         from the constructor, pass new equal function, and element deleter
6939         when constructing the hash table.  Initialise new class member
6940         variables.
6941         (completion_tracker::maybe_add_completion): Remove use of
6942         m_entries_vec, and store more information into m_entries_hash.
6943         (completion_tracker::recompute_lcd_visitor): New function, most
6944         content taken from...
6945         (completion_tracker::recompute_lowest_common_denominator):
6946         ...here, this now just visits each item in the hash calling the
6947         above visitor.
6948         (completion_tracker::build_completion_result): Remove use of
6949         m_entries_vec, call recompute_lowest_common_denominator.
6950         * completer.h (completion_tracker::have_completions): Remove use
6951         of m_entries_vec.
6952         (completion_tracker::completion_hash_entry): Declare new class.
6953         (completion_tracker::recompute_lowest_common_denominator): Change
6954         function signature.
6955         (completion_tracker::recompute_lcd_visitor): Declare new function.
6956         (completion_tracker::m_entries_vec): Delete.
6957         (completion_tracker::m_entries_hash): Initialize to NULL.
6958         (completion_tracker::m_lowest_common_denominator_valid): New
6959         member variable.
6960         (completion_tracker::m_lowest_common_denominator_max_length): New
6961         member variable.
6962
6963 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6964
6965         * regformats/regdef.h: Put reg in gdb namespace.
6966
6967 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6968
6969         * i386-bsd-nat.c (gdb_ptrace): New.
6970         * (i386bsd_fetch_inferior_registers,
6971         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
6972         * (i386bsd_fetch_inferior_registers,
6973         i386bsd_store_inferior_registers) Use gdb_ptrace.
6974
6975 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6976
6977         * amd64-bsd-nat.c (gdb_ptrace): New.
6978         * (amd64bsd_fetch_inferior_registers,
6979         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
6980         * (amd64bsd_fetch_inferior_registers,
6981         amd64bsd_store_inferior_registers) Use gdb_ptrace.
6982
6983 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6984
6985         * user-regs.c (user_reg::read): Rename to...
6986         (user_reg::xread): ...this.
6987         * (append_user_reg): Rename argument `read' to `xread'.
6988         * (user_reg_add_builtin): Likewise.
6989         * (user_reg_add): Likewise.
6990         * (value_of_user_reg): Likewise.
6991
6992 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6993
6994         * sparc-nat.c (gdb_ptrace): New.
6995         * sparc-nat.c (sparc_fetch_inferior_registers)
6996         (sparc_store_inferior_registers) Remove obsolete comment.
6997         * sparc-nat.c (sparc_fetch_inferior_registers)
6998         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
6999         * sparc-nat.c (sparc_fetch_inferior_registers)
7000         (sparc_store_inferior_registers) Use gdb_ptrace.
7001
7002 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7003
7004         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
7005         it to the ptrace call.
7006         * sh-nbsd-nat.c (store_registers): Likewise.
7007
7008 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7009
7010         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
7011         nbsd_nat_target instead of inf_ptrace_target.
7012         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
7013         nbsd_nat_target.
7014
7015 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7016
7017         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
7018
7019 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7020
7021         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
7022         <sys/sysctl.h>.
7023         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
7024
7025 2020-03-17  Tom de Vries  <tdevries@suse.de>
7026
7027         PR gdb/23710
7028         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
7029         fields.
7030         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
7031         fields.
7032         (process_imported_unit_die): Skip import of c++ CUs.
7033
7034 2020-03-16  Tom Tromey  <tom@tromey.com>
7035
7036         * p-valprint.c (pascal_object_print_value): Initialize
7037         base_value.
7038
7039 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
7040             Shahab Vahedi  <shahab@synopsys.com>
7041
7042         * Makefile.in: Add arch/arc.o
7043         * configure.tgt: Likewise.
7044         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
7045         (_initialize_arc_tdep): Don't initialize old target descriptions.
7046         (arc_read_description): New function to cache target descriptions.
7047         * arc-tdep.h (arc_read_description): Add proto type.
7048         * arch/arc.c: New file.
7049         * arch/arc.h: Likewise.
7050         * features/Makefile: Replace old target descriptions with new.
7051         * features/arc-arcompact.c: Remove.
7052         * features/arc-arcompact.xml: Likewise.
7053         * features/arc-v2.c: Likewise
7054         * features/arc-v2.xml: Likewise
7055         * features/arc/aux-arcompact.xml: New file.
7056         * features/arc/aux-v2.xml: Likewise.
7057         * features/arc/core-arcompact.xml: Likewise.
7058         * features/arc/core-v2.xml: Likewise.
7059         * features/arc/aux-arcompact.c: Generate.
7060         * features/arc/aux-v2.c: Likewise.
7061         * features/arc/core-arcompact.c: Likewise.
7062         * features/arc/core-v2.c: Likewise.
7063         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
7064
7065 2020-03-16  Tom Tromey  <tromey@adacore.com>
7066
7067         PR gdb/25663:
7068         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
7069         putting value into bcache.
7070
7071 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7072
7073         PR gdb/21500
7074         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
7075         to...
7076         (amd64_windows_init_abi_common): ... this.  Don't set size of
7077         long type.
7078         (amd64_windows_init_abi): New function.
7079         (amd64_cygwin_init_abi): New function.
7080         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
7081         the Cygwin OS ABI.
7082         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
7083         comment.
7084
7085 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7086
7087         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
7088         * windows-tdep.c (CYGWIN_DLL_NAME): New.
7089         (pe_import_directory_entry): New struct type.
7090         (is_linked_with_cygwin_dll): New function.
7091         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
7092         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
7093         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
7094
7095 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7096
7097         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
7098         i386_cygwin_core_osabi_sniffer.
7099
7100 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7101
7102         * i386-cygwin-tdep.c: Rename to...
7103         * i386-windows-tdep.c: ... this.
7104         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
7105         i386-windows-tdep.c.
7106         * configure.tgt: Likewise.
7107
7108 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7109
7110         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
7111         * osabi.c (gdb_osabi_names): Add "Windows".
7112         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
7113         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
7114         (i386_cygwin_core_osabi_sniffer): New function, extracted from
7115         i386_cygwin_osabi_sniffer.
7116         (_initialize_i386_cygwin_tdep): Register OS ABI
7117         GDB_OSABI_WINDOWS for i386.
7118         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
7119         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
7120         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
7121         for x86-64.
7122         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
7123         when the target matches '*-*-mingw*'.
7124
7125 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7126
7127         * defs.h (enum gdb_osabi): Move to...
7128         * osabi.h (enum gdb_osabi): ... here.
7129         * gdbarch.sh: Include osabi.h in gdbarch.h.
7130         * gdbarch.h: Re-generate.
7131
7132 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
7133
7134         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
7135         function.
7136         (_initialize_amd64_windows_tdep): Register osabi sniffer.
7137
7138 2020-03-14  Tom Tromey  <tom@tromey.com>
7139
7140         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
7141         for C++.
7142         (c_type_print_modifier): Likewise.  Add "language" parameter.
7143         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
7144         (c_type_print_base_1): Update.
7145         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
7146         constants.
7147         * type-stack.c (type_stack::insert): Handle tp_atomic and
7148         tp_restrict.
7149         (type_stack::follow_type_instance_flags): Likewise.
7150         (type_stack::follow_types): Likewise.  Merge type-following code.
7151         * c-exp.y (RESTRICT, ATOMIC): New tokens.
7152         (space_identifier, cv_with_space_id)
7153         (const_or_volatile_or_space_identifier_noopt)
7154         (const_or_volatile_or_space_identifier): Remove.
7155         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
7156         rules.
7157         (ptr_operator, typebase): Update.
7158         (enum token_flag) <FLAG_C>: New constant.
7159         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
7160         "_Atomic".
7161         (lex_one_token): Handle FLAG_C.
7162
7163 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7164
7165         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
7166         it to the ptrace call.
7167         * m68k-bsd-nat.c (store_registers): Likewise.
7168
7169 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7170
7171         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
7172         gdb_byte *.
7173         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
7174         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
7175         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
7176
7177 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7178
7179         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
7180         nbsd_nat_target instead of inf_ptrace_target.
7181         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
7182         nbsd_nat_target.
7183
7184 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7185
7186         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
7187         register_t.
7188
7189 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7190
7191         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
7192         it to the ptrace call.
7193         * alpha-bsd-nat.c (store_registers): Likewise.
7194
7195 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7196
7197         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
7198         includes.
7199         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
7200         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
7201         fill_fpregset): Likewise.
7202
7203 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7204
7205         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
7206         nbsd_nat_target instead of inf_ptrace_target.
7207         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
7208         nbsd_nat_target.
7209
7210 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7211
7212         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
7213         register_t.
7214
7215 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7216
7217         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
7218         it to the ptrace call.
7219         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
7220         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
7221         * arm-nbsd-nat.c (store_register): Likewise.
7222         * arm-nbsd-nat.c (store_regs): Likewise.
7223         * arm-nbsd-nat.c (store_fp_register): Likewise.
7224         * arm-nbsd-nat.c (store_fp_regs): Likewise.
7225
7226 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7227
7228         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
7229         nbsd_nat_target instead of inf_ptrace_target.
7230         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
7231         nbsd_nat_target.
7232
7233 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7234
7235         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
7236         it to the ptrace call.
7237         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
7238
7239 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7240
7241         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
7242         it to the ptrace call.
7243         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
7244
7245 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7246
7247         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
7248         gdb_byte *.
7249         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
7250
7251 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7252
7253         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
7254         instead of inf_ptrace_target.
7255         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
7256         nbsd_nat_target.
7257
7258 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7259
7260         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
7261         register_t.
7262
7263 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7264
7265         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
7266         register_t.
7267
7268 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
7269
7270         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
7271         register_t.
7272
7273 2020-03-13  Tom Tromey  <tom@tromey.com>
7274
7275         * value.h (val_print): Don't declare.
7276         * valprint.h (val_print_array_elements)
7277         (val_print_scalar_formatted, generic_val_print): Don't declare.
7278         * valprint.c (generic_val_print_array): Take a struct value.
7279         (generic_val_print_ptr, generic_val_print_memberptr)
7280         (generic_val_print_bool, generic_val_print_int)
7281         (generic_val_print_char, generic_val_print_complex)
7282         (generic_val_print): Remove.
7283         (generic_value_print): Update.
7284         (do_val_print): Remove unused parameters.  Don't call
7285         la_val_print.
7286         (val_print): Remove.
7287         (common_val_print): Update.  Don't call value_check_printable.
7288         (val_print_scalar_formatted, val_print_array_elements): Remove.
7289         * rust-lang.c (rust_val_print): Remove.
7290         (rust_language_defn): Update.
7291         * p-valprint.c (pascal_val_print): Remove.
7292         (pascal_value_print_inner): Update.
7293         (pascal_object_print_val_fields, pascal_object_print_val):
7294         Remove.
7295         (pascal_object_print_static_field): Update.
7296         * p-lang.h (pascal_val_print): Don't declare.
7297         * p-lang.c (pascal_language_defn): Update.
7298         * opencl-lang.c (opencl_language_defn): Update.
7299         * objc-lang.c (objc_language_defn): Update.
7300         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
7301         * m2-lang.h (m2_val_print): Don't declare.
7302         * m2-lang.c (m2_language_defn): Update.
7303         * language.h (struct language_defn) <la_val_print>: Remove.
7304         * language.c (unk_lang_value_print_inner): Rename.  Change
7305         argument types.
7306         (unknown_language_defn, auto_language_defn): Update.
7307         * go-valprint.c (go_val_print): Remove.
7308         * go-lang.h (go_val_print): Don't declare.
7309         * go-lang.c (go_language_defn): Update.
7310         * f-valprint.c (f_val_print): Remove.
7311         * f-lang.h (f_value_print): Don't declare.
7312         * f-lang.c (f_language_defn): Update.
7313         * d-valprint.c (d_val_print): Remove.
7314         * d-lang.h (d_value_print): Don't declare.
7315         * d-lang.c (d_language_defn): Update.
7316         * cp-valprint.c (cp_print_value_fields)
7317         (cp_print_value_fields_rtti, cp_print_value): Remove.
7318         (cp_print_static_field): Update.
7319         * c-valprint.c (c_val_print_array, c_val_print_ptr)
7320         (c_val_print_struct, c_val_print_union, c_val_print_int)
7321         (c_val_print_memberptr, c_val_print): Remove.
7322         * c-lang.h (c_val_print_array, cp_print_value_fields)
7323         (cp_print_value_fields_rtti): Don't declare.
7324         * c-lang.c (c_language_defn, cplus_language_defn)
7325         (asm_language_defn, minimal_language_defn): Update.
7326         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
7327         (ada_val_print_enum): Take a struct value.
7328         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
7329         (ada_val_print): Remove.
7330         (ada_value_print_1): Update.
7331         (printable_val_type): Remove.
7332         * ada-lang.h (ada_val_print): Don't declare.
7333         * ada-lang.c (ada_language_defn): Update.
7334
7335 2020-03-13  Tom Tromey  <tom@tromey.com>
7336
7337         * valprint.c (do_val_print): Update.
7338         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
7339         a struct value.
7340         (value_to_value_object_no_release): Declare.
7341         * python/py-value.c (value_to_value_object_no_release): New
7342         function.
7343         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
7344         struct value.
7345         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
7346         function.
7347         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
7348         a struct value.
7349         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
7350         Declare.
7351         (gdbscm_apply_val_pretty_printer): Take a struct value.
7352         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
7353         value.
7354         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
7355         value.
7356         * extension-priv.h (struct extension_language_ops)
7357         <apply_val_pretty_printer>: Take a struct value.
7358         * cp-valprint.c (cp_print_value): Create a struct value.
7359         (cp_print_value): Update.
7360
7361 2020-03-13  Tom Tromey  <tom@tromey.com>
7362
7363         * ada-valprint.c (print_field_values): Call common_val_print.
7364
7365 2020-03-13  Tom Tromey  <tom@tromey.com>
7366
7367         * ada-valprint.c (val_print_packed_array_elements): Remove
7368         bitoffset and val parameters.  Call common_val_print.
7369         (ada_val_print_string): Remove offset, address, and original_value
7370         parameters.
7371         (ada_val_print_array): Update.
7372         (ada_value_print_array): New function.
7373         (ada_value_print_1): Call it.
7374
7375 2020-03-13  Tom Tromey  <tom@tromey.com>
7376
7377         * ada-valprint.c (ada_value_print): Use common_val_print.
7378
7379 2020-03-13  Tom Tromey  <tom@tromey.com>
7380
7381         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
7382
7383 2020-03-13  Tom Tromey  <tom@tromey.com>
7384
7385         * ada-valprint.c (ada_value_print_num): New function.
7386         (ada_value_print_1): Use it.
7387
7388 2020-03-13  Tom Tromey  <tom@tromey.com>
7389
7390         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
7391
7392 2020-03-13  Tom Tromey  <tom@tromey.com>
7393
7394         * ada-valprint.c (ada_value_print_ptr): New function.
7395         (ada_value_print_1): Use it.
7396
7397 2020-03-13  Tom Tromey  <tom@tromey.com>
7398
7399         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
7400         call common_val_print.
7401         (ada_val_print_1): Update.
7402         (ada_value_print_1): New function.
7403         (ada_value_print_inner): Rewrite.
7404
7405 2020-03-13  Tom Tromey  <tom@tromey.com>
7406
7407         * cp-valprint.c (cp_print_value_fields): Update.
7408         (cp_print_value): New function.
7409
7410 2020-03-13  Tom Tromey  <tom@tromey.com>
7411
7412         * m2-valprint.c (m2_value_print_inner): Use
7413         cp_print_value_fields.
7414         * cp-valprint.c (cp_print_value_fields): New function.
7415         * c-valprint.c (c_value_print_struct): New function.
7416         (c_value_print_inner): Use c_value_print_struct.
7417         * c-lang.h (cp_print_value_fields): Declare.
7418
7419 2020-03-13  Tom Tromey  <tom@tromey.com>
7420
7421         * c-valprint.c (c_value_print_array): New function.
7422         (c_value_print_inner): Use it.
7423
7424 2020-03-13  Tom Tromey  <tom@tromey.com>
7425
7426         * c-valprint.c (c_value_print_memberptr): New function.
7427         (c_value_print_inner): Use it.
7428
7429 2020-03-13  Tom Tromey  <tom@tromey.com>
7430
7431         * c-valprint.c (c_value_print_int): New function.
7432         (c_value_print_inner): Use it.
7433
7434 2020-03-13  Tom Tromey  <tom@tromey.com>
7435
7436         * c-valprint.c (c_value_print_ptr): New function.
7437         (c_value_print_inner): Use it.
7438
7439 2020-03-13  Tom Tromey  <tom@tromey.com>
7440
7441         * c-valprint.c (c_value_print_inner): Rewrite.
7442
7443 2020-03-13  Tom Tromey  <tom@tromey.com>
7444
7445         * valprint.c (generic_value_print_complex): New function.
7446         (generic_value_print): Use it.
7447
7448 2020-03-13  Tom Tromey  <tom@tromey.com>
7449
7450         * valprint.c (generic_val_print_float): Don't call
7451         val_print_scalar_formatted.
7452         (generic_val_print, generic_value_print): Update.
7453
7454 2020-03-13  Tom Tromey  <tom@tromey.com>
7455
7456         * valprint.c (generic_value_print_char): New function
7457         (generic_value_print): Use it.
7458
7459 2020-03-13  Tom Tromey  <tom@tromey.com>
7460
7461         * valprint.c (generic_value_print_int): New function.
7462         (generic_value_print): Use it.
7463
7464 2020-03-13  Tom Tromey  <tom@tromey.com>
7465
7466         * valprint.c (generic_value_print_bool): New function.
7467         (generic_value_print): Use it.
7468
7469 2020-03-13  Tom Tromey  <tom@tromey.com>
7470
7471         * valprint.c (generic_val_print_func): Simplify.
7472         (generic_val_print, generic_value_print): Update.
7473
7474 2020-03-13  Tom Tromey  <tom@tromey.com>
7475
7476         * valprint.c (generic_val_print_flags): Remove.
7477         (generic_val_print, generic_value_print): Update.
7478         (val_print_type_code_flags): Add original_value parameter.
7479
7480 2020-03-13  Tom Tromey  <tom@tromey.com>
7481
7482         * valprint.c (generic_val_print): Update.
7483         (generic_value_print): Update.
7484         * valprint.c (generic_val_print_enum): Don't call
7485         val_print_scalar_formatted.
7486
7487 2020-03-13  Tom Tromey  <tom@tromey.com>
7488
7489         * valprint.c (generic_value_print): Call generic_value_print_ptr.
7490         * valprint.c (generic_value_print_ptr): New function.
7491
7492 2020-03-13  Tom Tromey  <tom@tromey.com>
7493
7494         * valprint.c (generic_value_print): Rewrite.
7495
7496 2020-03-13  Tom Tromey  <tom@tromey.com>
7497
7498         * p-valprint.c (pascal_object_print_value_fields)
7499         (pascal_object_print_value): New functions.
7500
7501 2020-03-13  Tom Tromey  <tom@tromey.com>
7502
7503         * p-valprint.c (pascal_value_print_inner): Rewrite.
7504
7505 2020-03-13  Tom Tromey  <tom@tromey.com>
7506
7507         * f-valprint.c (f_value_print_innner): Rewrite.
7508
7509 2020-03-13  Tom Tromey  <tom@tromey.com>
7510
7511         * m2-valprint.c (m2_print_unbounded_array): New overload.
7512         (m2_print_unbounded_array): Update.
7513         (m2_print_array_contents): Take a struct value.
7514         (m2_value_print_inner): Rewrite.
7515
7516 2020-03-13  Tom Tromey  <tom@tromey.com>
7517
7518         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
7519         (d_value_print_inner): New function.
7520         * d-lang.h (d_value_print_inner): Declare.
7521         * d-lang.c (d_language_defn): Use d_value_print_inner.
7522
7523 2020-03-13  Tom Tromey  <tom@tromey.com>
7524
7525         * go-valprint.c (go_value_print_inner): New function.
7526         * go-lang.h (go_value_print_inner): Declare.
7527         * go-lang.c (go_language_defn): Use go_value_print_inner.
7528
7529 2020-03-13  Tom Tromey  <tom@tromey.com>
7530
7531         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
7532         API.
7533         (rust_val_print): Rewrite.
7534         (rust_value_print_inner): New function, from rust_val_print.
7535         (rust_language_defn): Use rust_value_print_inner.
7536
7537 2020-03-13  Tom Tromey  <tom@tromey.com>
7538
7539         * ada-valprint.c (ada_value_print_inner): New function.
7540         * ada-lang.h (ada_value_print_inner): Declare.
7541         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
7542
7543 2020-03-13  Tom Tromey  <tom@tromey.com>
7544
7545         * f-valprint.c (f_value_print_innner): New function.
7546         * f-lang.h (f_value_print_innner): Declare.
7547         * f-lang.c (f_language_defn): Use f_value_print_innner.
7548
7549 2020-03-13  Tom Tromey  <tom@tromey.com>
7550
7551         * p-valprint.c (pascal_value_print_inner): New function.
7552         * p-lang.h (pascal_value_print_inner): Declare.
7553         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
7554
7555 2020-03-13  Tom Tromey  <tom@tromey.com>
7556
7557         * m2-valprint.c (m2_value_print_inner): New function.
7558         * m2-lang.h (m2_value_print_inner): Declare.
7559         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
7560
7561 2020-03-13  Tom Tromey  <tom@tromey.com>
7562
7563         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
7564         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
7565         * c-valprint.c (c_value_print_inner): New function.
7566         * c-lang.h (c_value_print_inner): Declare.
7567         * c-lang.c (c_language_defn, cplus_language_defn)
7568         (asm_language_defn, minimal_language_defn): Use
7569         c_value_print_inner.
7570
7571 2020-03-13  Tom Tromey  <tom@tromey.com>
7572
7573         * p-valprint.c (pascal_object_print_value_fields): Now static.
7574         * p-lang.h (pascal_object_print_value_fields): Don't declare.
7575
7576 2020-03-13  Tom Tromey  <tom@tromey.com>
7577
7578         * c-valprint.c (c_val_print_array): Simplify.
7579
7580 2020-03-13  Tom Tromey  <tom@tromey.com>
7581
7582         * valprint.c (value_print_array_elements): New function.
7583         * valprint.h (value_print_array_elements): Declare.
7584
7585 2020-03-13  Tom Tromey  <tom@tromey.com>
7586
7587         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
7588         * mips-tdep.c (mips_print_register): Use
7589         value_print_scalar_formatted.
7590
7591 2020-03-13  Tom Tromey  <tom@tromey.com>
7592
7593         * valprint.h (value_print_scalar_formatted): Declare.
7594         * valprint.c (value_print_scalar_formatted): New function.
7595
7596 2020-03-13  Tom Tromey  <tom@tromey.com>
7597
7598         * valprint.h (generic_value_print): Declare.
7599         * valprint.c (generic_value_print): New function.
7600
7601 2020-03-13  Tom Tromey  <tom@tromey.com>
7602
7603         * valprint.c (do_val_print): Call la_value_print_inner, if
7604         available.
7605         * rust-lang.c (rust_language_defn): Update.
7606         * p-lang.c (pascal_language_defn): Update.
7607         * opencl-lang.c (opencl_language_defn): Update.
7608         * objc-lang.c (objc_language_defn): Update.
7609         * m2-lang.c (m2_language_defn): Update.
7610         * language.h (struct language_defn) <la_value_print_inner>: New
7611         member.
7612         * language.c (unknown_language_defn, auto_language_defn): Update.
7613         * go-lang.c (go_language_defn): Update.
7614         * f-lang.c (f_language_defn): Update.
7615         * d-lang.c (d_language_defn): Update.
7616         * c-lang.c (c_language_defn, cplus_language_defn)
7617         (asm_language_defn, minimal_language_defn): Update.
7618         * ada-lang.c (ada_language_defn): Update.
7619
7620 2020-03-13  Tom Tromey  <tom@tromey.com>
7621
7622         * c-valprint.c (c_value_print): Use common_val_print.
7623
7624 2020-03-13  Tom Tromey  <tom@tromey.com>
7625
7626         * cp-valprint.c (cp_print_static_field): Use common_val_print.
7627
7628 2020-03-13  Tom Tromey  <tom@tromey.com>
7629
7630         * f-valprint.c (f77_print_array_1, f_val_print): Use
7631         common_val_print.
7632
7633 2020-03-13  Tom Tromey  <tom@tromey.com>
7634
7635         * riscv-tdep.c (riscv_print_one_register_info): Use
7636         common_val_print.
7637
7638 2020-03-13  Tom Tromey  <tom@tromey.com>
7639
7640         * mi/mi-main.c (output_register): Use common_val_print.
7641
7642 2020-03-13  Tom Tromey  <tom@tromey.com>
7643
7644         * infcmd.c (default_print_one_register_info): Use
7645         common_val_print.
7646
7647 2020-03-13  Tom Tromey  <tom@tromey.com>
7648
7649         * valprint.h (common_val_print_checked): Declare.
7650         * valprint.c (common_val_print_checked): New function.
7651         * stack.c (print_frame_arg): Use common_val_print_checked.
7652
7653 2020-03-13  Tom Tromey  <tom@tromey.com>
7654
7655         * valprint.c (do_val_print): New function, from val_print.
7656         (val_print): Use do_val_print.
7657         (common_val_print): Use do_val_print.
7658
7659 2020-03-13  Tom Tromey  <tom@tromey.com>
7660
7661         * valprint.c (value_print): Use scoped_value_mark.
7662
7663 2020-03-13  Tom de Vries  <tdevries@suse.de>
7664
7665         PR symtab/25646
7666         * psymtab.c (partial_symtab::partial_symtab): Don't set
7667         globals_offset and statics_offset.  Push element onto
7668         current_global_psymbols and current_static_psymbols stacks.
7669         (concat): New function.
7670         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
7671         element from current_global_psymbols and current_static_psymbols
7672         stacks.  Concat popped elements to global_psymbols and
7673         static_symbols.
7674         (add_psymbol_to_list): Use current_global_psymbols and
7675         current_static_psymbols stacks.
7676         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
7677         current_static_psymbols fields.
7678
7679 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
7680
7681         * corelow.c (sniff_core_bfd): Remove.
7682         (class core_target) <m_core_vec>: Remove.
7683         (core_target::core_target): Update.
7684         (core_file_fns): Remove.
7685         (deprecated_add_core_fns): Remove.
7686         (default_core_sniffer): Remove.
7687         (sniff_core_bfd): Remove.
7688         (default_check_format): Remove.
7689         (gdb_check_format): Remove.
7690         (core_target_open): Update.
7691         (core_target::get_core_register_section): Update.
7692         (get_core_registers_cb): Update.
7693         (core_target::fetch_registers): Update.
7694         * gdbcore.h (struct core_fns): Remove.
7695         (deprecated_add_core_fns): Remove.
7696         (default_core_sniffer): Remove.
7697         (default_check_format): Remove.
7698
7699 2020-03-12  Tom Tromey  <tom@tromey.com>
7700
7701         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
7702         CORE_ADDR.
7703         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
7704
7705 2020-03-12  Tom Tromey  <tom@tromey.com>
7706
7707         * remote.c (remote_target::download_tracepoint)
7708         (remote_target::enable_tracepoint)
7709         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
7710         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
7711         sprintf_vma.
7712
7713 2020-03-12  Tom Tromey  <tom@tromey.com>
7714
7715         * symfile-mem.c: Update CORE_ADDR size assert.
7716
7717 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
7718
7719         * selftest.m4: Move to gdbsupport/.
7720         * acinclude.m4: Update path to selftest.m4.
7721
7722 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
7723
7724         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
7725         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
7726         gdbarch-selfselftests.c and selftest-arch.c.
7727         (SUBDIR_UNITTESTS_OBS): Rename to...
7728         (SELFTESTS_OBS): ... this.
7729         (COMMON_SFILES): Remove disasm-selftests.c and
7730         gdbarch-selftests.c.
7731         * configure.ac: Don't add selftest-arch.{c,o} to
7732         CONFIG_{SRCS,OBS}.
7733         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
7734         preprocessor conditions.
7735
7736 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
7737
7738         * configure.ac: Don't source bfd/development.sh.
7739         * selftest.m4: Modify comment.
7740         * configure: Re-generate.
7741
7742 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
7743
7744         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
7745         not "true" or "false".
7746         * configure: Re-generate.
7747
7748 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
7749
7750         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
7751         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
7752         renamed to arm_nbsd_supply_gregset.
7753         (fetch_register): Update to call arm_nbsd_supply_gregset.
7754         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
7755         (arm_netbsd_nat_target::fetch_registers): Update.
7756         (fetch_elfcore_registers): Removed.
7757         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
7758         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
7759         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
7760         not require NetBSD system headers.
7761         (arm_nbsd_regset): New struct.
7762         (arm_nbsd_iterate_over_regset_sections): New function.
7763         (arm_netbsd_init_abi_common): Updated to call
7764         set_gdbarch_iterate_over_regset_sections.
7765         * arm-nbsd-tdep.h: New file.
7766
7767 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
7768
7769         * symtab.c (find_pc_sect_line): Add check which prevents infinite
7770         recursion.
7771
7772 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
7773
7774         * configure: Re-generate.
7775
7776 2020-03-11  Tom Tromey  <tromey@adacore.com>
7777
7778         * ada-typeprint.c (print_choices): Fix comment.
7779
7780 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7781
7782         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
7783         previous item in the list, when the list has no items.
7784
7785 2020-03-11  Tom de Vries  <tdevries@suse.de>
7786
7787         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
7788         PROP_LOCLIST handling code.
7789
7790 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7791
7792         * buildsym-legacy.c (record_line): Pass extra parameter to
7793         record_line.
7794         * buildsym.c (buildsym_compunit::record_line): Take an extra
7795         parameter, reduce duplication in the line table, and record the
7796         is_stmt flag in the line table.
7797         * buildsym.h (buildsym_compunit::record_line): Add extra
7798         parameter.
7799         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
7800         non-statement lines.
7801         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
7802         this to the symtab builder.
7803         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
7804         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
7805         through to dwarf_record_line_1.
7806         * infrun.c (process_event_stop_test): When stepping, don't stop at
7807         a non-statement instruction, and only refresh the step info when
7808         we land in the middle of a line's range.  Also add an extra
7809         comment.
7810         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
7811         field.
7812         * record-btrace.c (btrace_find_line_range): Only record lines
7813         marked as is-statement.
7814         * stack.c (frame_show_address): Show the frame address if we are
7815         in a non-statement sal.
7816         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
7817         (maintenance_print_one_line_table): Print a header for the is_stmt
7818         column, and include is_stmt information in the output.
7819         * symtab.c (find_pc_sect_line): Find lines marked as statements in
7820         preference to non-statements.
7821         (find_pcs_for_symtab_line): Prefer is-statement entries.
7822         (find_line_common): Likewise.
7823         * symtab.h (struct linetable_entry): Add is_stmt field.
7824         (struct symtab_and_line): Likewise.
7825         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
7826         arranging the line table.
7827
7828 2020-03-07  Tom de Vries  <tdevries@suse.de>
7829
7830         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
7831         DIE.
7832
7833 2020-03-07  Tom Tromey  <tom@tromey.com>
7834
7835         * valops.c (value_literal_complex): Remove obsolete comment.
7836         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
7837         comment.
7838
7839 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
7840
7841         * infrun.h: Forward-declare thread_info.
7842         (set_step_info): Add thread_info parameter, add doc.
7843         * infrun.c (set_step_info): Add thread_info parameter, move doc
7844         to header.
7845         * infrun.c (process_event_stop_test): Pass thread to
7846         set_step_info call.
7847         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
7848         set_step_info.
7849         (prepare_one_step): Add thread_info parameter, pass it to
7850         set_step_frame and prepare_one_step (recursive) call.
7851         (step_1): Pass thread to prepare_one_step call.
7852         (step_command_fsm::should_stop): Pass thread to
7853         prepare_one_step.
7854         (until_next_fsm): Pass thread to set_step_frame call.
7855         (finish_command): Pass thread to set_step_info call.
7856
7857 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
7858
7859         * windows-tdep.c (windows_solib_create_inferior_hook):
7860         Check if inferior is running.
7861
7862 2020-03-06  Tom de Vries  <tdevries@suse.de>
7863
7864         * NEWS: Fix "the the".
7865         * ctfread.c: Same.
7866
7867 2020-03-06  Tom de Vries  <tdevries@suse.de>
7868
7869         * psymtab.c (psymtab_to_symtab): Don't print "done.".
7870
7871 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7872
7873         * .dir-locals.el: Add a comment referencing the other copies of
7874         this file.
7875
7876 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
7877
7878         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
7879         psargs.
7880
7881 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
7882
7883         * .gitattributes: New file.
7884
7885 2020-03-04  Tom Tromey  <tom@tromey.com>
7886
7887         * symmisc.c (print_symbol_bcache_statistics)
7888         (print_objfile_statistics): Update.
7889         * symfile.c (allocate_symtab): Use intern.
7890         * psymtab.c (partial_symtab::partial_symtab): Use intern.
7891         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7892         macro_cache>: Remove.
7893         <string_cache>: New member.
7894         (struct objfile) <intern>: New methods.
7895         * elfread.c (elf_symtab_read): Use intern.
7896         * dwarf2/read.c (fixup_go_packaging): Intern package name.
7897         (dwarf2_compute_name, dwarf2_physname)
7898         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
7899         names.
7900         (guess_partial_die_structure_name): Update.
7901         (partial_die_info::fixup): Intern name.
7902         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
7903         name.
7904         (dwarf2_name): Intern name.  Update.
7905         * buildsym.c (buildsym_compunit::get_macro_table): Use
7906         string_cache.
7907
7908 2020-03-04  Tom Tromey  <tom@tromey.com>
7909
7910         * jit.c (bfd_open_from_target_memory): Make "target" const.
7911         * corefile.c (gnutarget): Now const.
7912         * gdbcore.h (gnutarget): Now const.
7913
7914 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
7915
7916         * NEWS: Mention support for WOW64 processes.
7917         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
7918         (amd64_windows_segment_register_p): Remove static.
7919         (_initialize_amd64_windows_nat): Update.
7920         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
7921         * i386-windows-nat.c (context_offset): Update.
7922         (i386_mappings): Rename and remove static.
7923         (i386_windows_segment_register_p): Remove static.
7924         (_initialize_i386_windows_nat): Update.
7925         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
7926         (STATUS_WX86_SINGLE_STEP): New macro.
7927         (EnumProcessModulesEx): New macro.
7928         (Wow64SuspendThread): New macro.
7929         (Wow64GetThreadContext): New macro.
7930         (Wow64SetThreadContext): New macro.
7931         (Wow64GetThreadSelectorEntry): New macro.
7932         (windows_set_context_register_offsets): Add static.
7933         (windows_set_segment_register_p): Likewise.
7934         (windows_add_thread): Adapt for WOW64 processes.
7935         (windows_fetch_one_register): Likewise.
7936         (windows_nat_target::fetch_registers): Likewise.
7937         (windows_store_one_register): Likewise.
7938         (display_selector): Likewise.
7939         (display_selectors): Likewise.
7940         (handle_exception): Likewise.
7941         (windows_continue): Likewise.
7942         (windows_nat_target::resume): Likewise.
7943         (windows_add_all_dlls): Likewise.
7944         (do_initial_windows_stuff): Likewise.
7945         (windows_nat_target::attach): Likewise.
7946         (windows_get_exec_module_filename): Likewise.
7947         (windows_nat_target::create_inferior): Likewise.
7948         (windows_xfer_siginfo): Likewise.
7949         (_initialize_loadable): Initialize Wow64SuspendThread,
7950         Wow64GetThreadContext, Wow64SetThreadContext,
7951         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
7952         * windows-nat.h (windows_set_context_register_offsets):
7953         Remove declaration.
7954         (windows_set_segment_register_p): Likewise.
7955         (i386_windows_segment_register_p): Add declaration.
7956         (amd64_windows_segment_register_p): Likewise.
7957
7958 2020-03-04  Luis Machado  <luis.machado@linaro.org>
7959
7960         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
7961         in "info registers" for AArch64/ARM.
7962
7963         The change caused "info registers" to not print GPR's.
7964
7965         gdb/ChangeLog:
7966
7967         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
7968
7969         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
7970         when reg->group is empty and reggroup is not.
7971
7972 2020-03-03  Tom Tromey  <tromey@adacore.com>
7973
7974         * dwarf2/frame.c (struct dwarf2_frame_cache)
7975         <checked_tailcall_bottom, entry_cfa_sp_offset,
7976         entry_cfa_sp_offset_p>: Remove members.
7977         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
7978         (dwarf2_frame_prev_register): Don't call
7979         dwarf2_tailcall_sniffer_first.
7980         (dwarf2_append_unwinders): Don't append tailcall unwinder.
7981         * frame-unwind.c (add_unwinder): New fuction.
7982         (frame_unwind_init): Use it.  Add tailcall unwinder.
7983
7984 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7985             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7986
7987         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
7988         value should be printed as true.
7989
7990 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
7991
7992         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
7993         (windows_init_abi): Set and use windows_so_ops.
7994
7995 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
7996
7997         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
7998         when verifying if dealing with a convenience variable.
7999
8000 2020-03-03  Luis Machado  <luis.machado@linaro.org>
8001
8002         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
8003
8004 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
8005
8006         * infrun.c (gdbarch_supports_displaced_stepping): New.
8007         (use_displaced_stepping): Break up conditions in smaller pieces.
8008         Use gdbarch_supports_displaced_stepping.
8009         (displaced_step_prepare_throw): Use
8010         gdbarch_supports_displaced_stepping.
8011
8012 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8013
8014         * NEWS: Mention new behaviour of the history filename.
8015         * top.c (write_history_p): Add comment.
8016         (show_write_history_p): Add header comment, give a different
8017         message when history writing is on, but the history filename is
8018         empty.
8019         (history_filename): Add comment.
8020         (history_filename_empty): New function.
8021         (show_history_filename): Add header comment, give a different
8022         message when the filename is empty.
8023         (init_history): Compare history_filename against nullptr, and only
8024         read history if the filename is not empty.
8025         (set_history_filename): Add header comment, and only make
8026         non-empty filenames absolute.
8027         (init_main): Make the filename argument to 'set history filename'
8028         optional.
8029
8030 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
8031
8032         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
8033         (arm_supply_vfpregset): ...this, and update to use VFP registers.
8034         (fetch_fp_register): Update.
8035         (fetch_fp_regs): Update.
8036         (store_fp_register): Update.
8037         (store_fp_regs): Update.
8038         (arm_netbsd_nat_target::read_description): New function.
8039         (fetch_elfcore_registers): Update.
8040
8041 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8042
8043         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
8044         general_thread if the stop reply is missing a thread-id.
8045         (remote_target::process_stop_reply): Use the first non-exited
8046         thread if the target didn't pass a thread-id.
8047         * infrun.c (do_target_wait): Move call to
8048         switch_to_inferior_no_thread to ....
8049         (do_target_wait_1): ... here.
8050
8051 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
8052
8053         * debuginfod-support.c: Include defs.h first.
8054
8055 2020-02-28  Tom de Vries  <tdevries@suse.de>
8056
8057         * symfile.c (set_initial_language): Use default language for lookup.
8058
8059 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
8060
8061         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
8062         reader variable, pass `this` to read_cutu_die_from_dwo.
8063
8064 2020-02-27  Aaron Merey  <amerey@redhat.com>
8065
8066         * source.c (open_source_file): Check for nullptr when computing
8067         srcpath.
8068
8069 2020-02-27  Tom Tromey  <tromey@adacore.com>
8070
8071         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
8072         member.
8073         (dwarf2_add_field): Don't update nfields.
8074         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
8075
8076 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8077
8078         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
8079         abs.
8080
8081 2020-02-26  Tom Tromey  <tom@tromey.com>
8082
8083         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
8084         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
8085         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
8086         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
8087         per_cu_data.
8088
8089 2020-02-26  Tom Tromey  <tom@tromey.com>
8090
8091         * dwarf2/index-write.c (psym_index_map): Change type.
8092         (add_address_entry_worker, write_one_signatured_type)
8093         (recursively_count_psymbols, recursively_write_psymbols)
8094         (class debug_names, psyms_seen_size, write_gdbindex)
8095         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
8096
8097 2020-02-26  Aaron Merey  <amerey@redhat.com>
8098
8099         * Makefile.in: Handle optional debuginfod support.
8100         * NEWS: Update.
8101         * README: Add --with-debuginfod summary.
8102         * config.in: Regenerate.
8103         * configure: Regenerate.
8104         * configure.ac: Handle optional debuginfod support.
8105         * debuginfod-support.c: debuginfod helper functions.
8106         * debuginfod-support.h: Ditto.
8107         * doc/gdb.texinfo: Add --with-debuginfod to configure options
8108         summary.
8109         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
8110         when a dwz file cannot be found.
8111         * elfread.c (elf_symfile_read): Query debuginfod servers when a
8112         debuginfo file cannot be found.
8113         * source.c (open_source_file): Query debuginfod servers when a
8114         source file cannot be found.
8115         * top.c (print_gdb_configuration): Include
8116         --{with,without}-debuginfod in the output.
8117
8118 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
8119
8120         * thread.c (thr_try_catch_cmd): Print thread name.
8121
8122 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
8123
8124         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
8125         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
8126         dwarf2_fetch_die_type_sect_off): Move to...
8127         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
8128         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
8129         dwarf2_fetch_die_type_sect_off): ... here.
8130         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
8131         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
8132         dwarf2_fetch_die_type_sect_off): Move doc to header file.
8133
8134 2020-02-26  Tom de Vries  <tdevries@suse.de>
8135
8136         PR gdb/25603
8137         * symfile.c (set_initial_language): Exit-early if
8138         language_mode == language_mode_manual.
8139
8140 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
8141
8142         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
8143         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
8144         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
8145
8146 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
8147
8148         * gdbtypes.c (create_array_type_with_stride): Handle negative
8149         array strides.
8150         * valarith.c (value_subscripted_rvalue): Likewise.
8151
8152 2020-02-25  Luis Machado  <luis.machado@linaro.org>
8153
8154         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
8155
8156 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
8157
8158         * loc.h (dwarf2_get_die_type): Move to...
8159         * read.h (dwarf2_get_die_type): ... here.
8160         * read.c (dwarf2_get_die_type): Move doc to header.
8161
8162 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
8163
8164         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
8165         'gnulib/Makefile.in' to the list.
8166
8167 2020-02-24  Tom Tromey  <tom@tromey.com>
8168
8169         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
8170         Remove.
8171         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
8172         XOBNEWVEC.
8173
8174 2020-02-24  Tom Tromey  <tom@tromey.com>
8175
8176         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
8177         New method.
8178         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
8179         (dw2_do_instantiate_symtab, dw2_get_file_names)
8180         (build_type_psymtab_dependencies, load_full_type_unit): Update.
8181
8182 2020-02-24  Tom Tromey  <tom@tromey.com>
8183
8184         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
8185         make_scoped_restore.
8186         (dwarf2_psymtab::read_symtab): Don't clear
8187         reading_partial_symbols.
8188
8189 2020-02-24  Tom de Vries  <tdevries@suse.de>
8190
8191         PR gdb/25592
8192         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
8193
8194 2020-02-24  Tom de Vries  <tdevries@suse.de>
8195
8196         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
8197         commands layout next/prev/regs.
8198
8199 2020-02-22  Tom Tromey  <tom@tromey.com>
8200
8201         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
8202         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
8203
8204 2020-02-22  Tom Tromey  <tom@tromey.com>
8205
8206         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
8207
8208 2020-02-22  Tom Tromey  <tom@tromey.com>
8209
8210         * tui/tui-win.c (_initialize_tui_win): Add usage text.
8211         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
8212         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
8213         * tui/tui.c (_initialize_tui): Add usage text.
8214
8215 2020-02-22  Tom Tromey  <tom@tromey.com>
8216
8217         * tui/tui-win.c (tui_set_focus_command)
8218         (tui_set_win_height_command): Use error_no_arg.
8219         (_initialize_tui_win): Update help text.
8220         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
8221
8222 2020-02-22  Tom Tromey  <tom@tromey.com>
8223
8224         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
8225         * tui/tui-disasm.h (struct tui_disasm_window)
8226         <display_start_addr>: Declare.
8227         * tui/tui-source.h (struct tui_source_window)
8228         <display_start_addr>: Declare.
8229         * tui/tui-winsource.h (struct tui_source_window_base)
8230         <show_source_line, display_start_addr>: New methods.
8231         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
8232         Rename and move to protected section.
8233         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
8234         (tui_source_window_base::do_erase_source_content): Update.
8235         (tui_source_window_base::show_source_line): Now a method.
8236         (tui_source_window_base::show_source_content)
8237         (tui_source_window_base::tui_source_window_base)
8238         (tui_source_window_base::rerender)
8239         (tui_source_window_base::refill)
8240         (tui_source_window_base::do_scroll_horizontal)
8241         (tui_source_window_base::set_is_exec_point_at)
8242         (tui_source_window_base::update_breakpoint_info)
8243         (tui_source_window_base::update_exec_info): Update.
8244         * tui/tui-source.c (tui_source_window::set_contents)
8245         (tui_source_window::showing_source_p)
8246         (tui_source_window::do_scroll_vertical)
8247         (tui_source_window::location_matches_p)
8248         (tui_source_window::line_is_displayed): Update.
8249         (tui_source_window::display_start_addr): New method.
8250         * tui/tui-disasm.c (tui_disasm_window::set_contents)
8251         (tui_disasm_window::do_scroll_vertical)
8252         (tui_disasm_window::location_matches_p): Update.
8253         (tui_disasm_window::display_start_addr): New method.
8254
8255 2020-02-22  Tom Tromey  <tom@tromey.com>
8256
8257         * NEWS: Add entry for gdb.register_window_type.
8258         * tui/tui-layout.h (window_factory): New typedef.
8259         (tui_register_window): Declare.
8260         * tui/tui-layout.c (saved_tui_windows): New global.
8261         (tui_apply_current_layout): Use it.
8262         (tui_register_window): New function.
8263         * python/python.c (do_start_initialization): Call
8264         gdbpy_initialize_tui.
8265         (python_GdbMethods): Add "register_window_type" function.
8266         * python/python-internal.h (gdbpy_register_tui_window)
8267         (gdbpy_initialize_tui): Declare.
8268         * python/py-tui.c: New file.
8269         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
8270
8271 2020-02-22  Tom Tromey  <tom@tromey.com>
8272
8273         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
8274
8275 2020-02-22  Tom Tromey  <tom@tromey.com>
8276
8277         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
8278         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
8279         * tui/tui-data.c (tui_set_win_with_focus): Remove.
8280         (tui_set_win_focus_to): Move from tui-win.c.
8281
8282 2020-02-22  Tom Tromey  <tom@tromey.com>
8283
8284         * tui/tui-layout.c (make_standard_window, get_locator_window): New
8285         functions.
8286         (known_window_types): New global.
8287         (tui_get_window_by_name): Reimplement.
8288         (initialize_known_windows): New function.
8289         (validate_window_name): Rewrite.
8290         (_initialize_tui_layout): Call initialize_known_windows.
8291
8292 2020-02-22  Tom Tromey  <tom@tromey.com>
8293
8294         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
8295         Remove constants.
8296         * tui/tui-winsource.h (struct tui_source_window_base)
8297         <tui_source_window_base>: Remove parameter.
8298         * tui/tui-winsource.c
8299         (tui_source_window_base::tui_source_window_base): Remove
8300         parameter.
8301         (tui_source_window_base::refill): Update.
8302         * tui/tui-stack.h (struct tui_locator_window)
8303         <tui_locator_window>: Update.
8304         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
8305         Default the constructor.
8306         * tui/tui-regs.h (struct tui_data_item_window)
8307         <tui_data_item_window>: Default the constructor.
8308         (struct tui_data_window) <tui_data_window>: Likewise.
8309         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
8310         Default the constructor.
8311         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
8312         Default the constructor.
8313         <type>: Remove.
8314         (struct tui_win_info) <tui_win_info>: Default the constructor.
8315         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
8316         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
8317         Default the constructor.
8318
8319 2020-02-22  Tom Tromey  <tom@tromey.com>
8320
8321         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
8322         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
8323         * tui/tui-win.c (tui_resize_all): Don't call
8324         tui_delete_invisible_windows.
8325         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
8326         done.
8327         (tui_set_layout): Update.
8328         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
8329         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
8330         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
8331
8332 2020-02-22  Tom Tromey  <tom@tromey.com>
8333
8334         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
8335         correctly.
8336
8337 2020-02-22  Tom Tromey  <tom@tromey.com>
8338
8339         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
8340
8341 2020-02-22  Tom Tromey  <tom@tromey.com>
8342
8343         * tui/tui-winsource.h (struct tui_source_window_iterator)
8344         <inner_iterator>: New etytypedef.
8345         <tui_source_window_iterator>: Take "end" parameter.
8346         <tui_source_window_iterator>: Take iterator.
8347         <operator*, advance>: Update.
8348         <m_iter>: Change type.
8349         <m_end>: New field.
8350         (struct tui_source_windows) <begin, end>: Update.
8351         * tui/tui-layout.c (tui_windows): New global.
8352         (tui_apply_current_layout): Clear tui_windows.
8353         (tui_layout_window::apply): Update tui_windows.
8354         * tui/tui-data.h (tui_windows): Declare.
8355         (all_tui_windows): Now inline function.
8356         (class tui_window_iterator, struct all_tui_windows): Remove.
8357
8358 2020-02-22  Tom Tromey  <tom@tromey.com>
8359
8360         PR tui/17850:
8361         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
8362         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
8363         "height" argument.
8364         (class tui_layout_window) <get_sizes>: Likewise.
8365         (class tui_layout_split) <tui_layout_split>: Add "vertical"
8366         argument.
8367         <get_sizes>: Add "height" argument.
8368         <m_vertical>: New field.
8369         * tui/tui-layout.c (tui_layout_split::clone): Update.
8370         (tui_layout_split::get_sizes): Add "height" argument.
8371         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
8372         (tui_new_layout_command): Parse "-horizontal".
8373         (_initialize_tui_layout): Update help string.
8374         (tui_layout_split::specification): Add "-horizontal" when needed.
8375         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
8376         argument.
8377         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
8378         New methods.
8379
8380 2020-02-22  Tom Tromey  <tom@tromey.com>
8381
8382         * tui/tui-layout.h (enum tui_adjust_result): New.
8383         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
8384         (class tui_layout_window) <adjust_size>: Return
8385         tui_adjust_result.  Rewrite.
8386         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
8387         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
8388
8389 2020-02-22  Tom Tromey  <tom@tromey.com>
8390
8391         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
8392         parameter and return types.
8393         (class tui_layout_base) <specification>: Add "depth".
8394         (class tui_layout_window) <specification>: Add "depth".
8395         (class tui_layout_split) <specification>: Add "depth".
8396         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
8397         and return types.
8398         (tui_new_layout_command): Parse sub-layouts.
8399         (_initialize_tui_layout): Update help string.
8400         (tui_layout_window::specification): Add "depth".
8401         (add_layout_command): Update.
8402
8403 2020-02-22  Tom Tromey  <tom@tromey.com>
8404
8405         * NEWS: Add "tui new-layout" item.
8406         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
8407         Add new-layout command to help text.
8408         (validate_window_name): New function.
8409         (tui_new_layout_command): New function.
8410         (_initialize_tui_layout): Register "new-layout".
8411         (tui_layout_window::specification): New method.
8412         (tui_layout_window::specification): New method.
8413         * tui/tui-layout.h (class tui_layout_base) <specification>: New
8414         method.
8415         (class tui_layout_window) <specification>: New method.
8416         (class tui_layout_split) <specification>: New method.
8417
8418 2020-02-22  Tom Tromey  <tom@tromey.com>
8419
8420         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
8421         * tui/tui-win.c (window_name_completer): Update comment.
8422         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
8423         Declare method.
8424         (class tui_layout_window) <replace_window>: Likewise.
8425         (class tui_layout_split) <replace_window>: Likewise.
8426         (tui_set_layout): Don't declare.
8427         (tui_set_initial_layout): Declare function.
8428         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
8429         (asm_regs_layout): New globals.
8430         (tui_current_layout, show_layout): Remove.
8431         (tui_set_layout, tui_add_win_to_layout): Rewrite.
8432         (find_layout, tui_apply_layout): New function.
8433         (layout_completer): Remove.
8434         (tui_next_layout): Reimplement.
8435         (tui_next_layout_command): New function.
8436         (tui_set_initial_layout, tui_prev_layout_command): New functions.
8437         (tui_regs_layout): Reimplement.
8438         (tui_regs_layout_command): New function.
8439         (extract_display_start_addr): Rewrite.
8440         (next_layout, prev_layout): Remove.
8441         (tui_layout_window::replace_window): New method.
8442         (tui_layout_split::replace_window): New method.
8443         (destroy_layout): New function.
8444         (layout_list): New global.
8445         (add_layout_command): New function.
8446         (initialize_layouts): Update.
8447         (tui_layout_command): New function.
8448         (_initialize_tui_layout): Install "layout" commands.
8449         * tui/tui-data.h (enum tui_layout_type): Remove.
8450         (tui_current_layout): Don't declare.
8451
8452 2020-02-22  Tom Tromey  <tom@tromey.com>
8453
8454         * tui/tui-regs.c (tui_reg_layout): Remove.
8455         (tui_reg_command): Use tui_regs_layout.
8456         * tui/tui-layout.h (tui_reg_command): Declare.
8457         * tui/tui-layout.c (tui_reg_command): New function.
8458
8459 2020-02-22  Tom Tromey  <tom@tromey.com>
8460
8461         * tui/tui.c (tui_rl_delete_other_windows): Call
8462         tui_remove_some_windows.
8463         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
8464         Declare method.
8465         (class tui_layout_window) <remove_windows>: New method.
8466         (class tui_layout_split) <remove_windows>: Declare.
8467         (tui_remove_some_windows): Declare.
8468         * tui/tui-layout.c (tui_remove_some_windows): New function.
8469         (tui_layout_split::remove_windows): New method.
8470
8471 2020-02-22  Tom Tromey  <tom@tromey.com>
8472
8473         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
8474         * tui/tui-layout.h (tui_next_layout): Declare.
8475         * tui/tui-layout.c (tui_next_layout): New function.
8476
8477 2020-02-22  Tom Tromey  <tom@tromey.com>
8478
8479         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
8480         correct coordinates.
8481
8482 2020-02-22  Tom Tromey  <tom@tromey.com>
8483
8484         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
8485         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
8486         DATA_WIN case.
8487
8488 2020-02-22  Tom Tromey  <tom@tromey.com>
8489
8490         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
8491         TUI_DISASM_WIN, not tui_win_list.
8492
8493 2020-02-22  Tom Tromey  <tom@tromey.com>
8494
8495         * valprint.c (generic_val_print_enum_1)
8496         (val_print_type_code_flags): Style member names.
8497         * rust-lang.c (val_print_struct, rust_print_enum)
8498         (rust_print_struct_def, rust_internal_print_type): Style member
8499         names.
8500         * p-valprint.c (pascal_object_print_value_fields): Style member
8501         names.  Only call fprintf_symbol_filtered for static members.
8502         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
8503         * f-valprint.c (f_val_print): Style member names.
8504         * f-typeprint.c (f_type_print_base): Style member names.
8505         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
8506         call fprintf_symbol_filtered for static members.
8507         (cp_print_class_member): Style member names.
8508         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
8509         member names.
8510         * ada-valprint.c (ada_print_scalar): Style enum names.
8511         (ada_val_print_enum): Likewise.
8512         * ada-typeprint.c (print_enum_type): Style enum names.
8513
8514 2020-02-21  Tom Tromey  <tom@tromey.com>
8515
8516         * psympriv.h (struct partial_symtab): Update comment.
8517
8518 2020-02-21  Tom Tromey  <tromey@adacore.com>
8519
8520         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
8521         type is CORE_ADDR.
8522
8523 2020-02-21  Tom de Vries  <tdevries@suse.de>
8524
8525         PR gdb/25534
8526         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
8527         if dependencies[i]->user != NULL.
8528
8529 2020-02-21  Ali Tamur  <tamur@google.com>
8530
8531         * dwarf2/read.c (dwarf2_name): Add null check.
8532
8533 2020-02-20  Tom Tromey  <tom@tromey.com>
8534
8535         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
8536         ">=", in binary search.
8537         (dwarf2_find_containing_comp_unit): New overload.
8538         (run_test): New self-test.
8539         (_initialize_dwarf2_read): Register new test.
8540
8541 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
8542
8543         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
8544         * riscv-tdep.h: Likewise.
8545         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
8546         rv32-only CSR.
8547         * features/riscv/64bit-csr.xml: Regenerated.
8548
8549 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
8550             Tom Tromey  <tom@tromey.com>
8551
8552         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
8553         of 'fputc_unfiltered'.
8554         (putchar_unfiltered): Call 'fputc_unfiltered'.
8555         (fputc_unfiltered): Call 'fputs_unfiltered'.
8556
8557 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
8558
8559         * config.in: Regenerate.
8560         * configure: Regenerate.
8561         * configure.ac: Add --with-python-libdir option.
8562         * main.c: Use WITH_PYTHON_LIBDIR.
8563
8564 2020-02-19  Tom Tromey  <tom@tromey.com>
8565
8566         * symtab.c (general_symbol_info::compute_and_set_names): Use
8567         obstack_strndup.  Simplify call to symbol_set_demangled_name.
8568
8569 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
8570
8571         * dwarf2/read.c (allocate_signatured_type_table,
8572         allocate_dwo_unit_table, allocate_type_unit_groups_table,
8573         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
8574         Remove objfile parameter, update all callers.
8575
8576 2020-02-19  Doug Evans  <dje@google.com>
8577
8578         PR rust/25535
8579         * rust-lang.c (rust_print_enum): Apply embedded_offset to
8580         rust_enum_variant calculation.
8581
8582 2020-02-19  Tom Tromey  <tromey@adacore.com>
8583
8584         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
8585
8586 2020-02-19  Tom Tromey  <tromey@adacore.com>
8587
8588         * ada-lang.c (cache_symbol): Use obstack_strdup.
8589
8590 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
8591
8592         * configure: Regenerate.
8593
8594 2020-02-19  Tom Tromey  <tromey@adacore.com>
8595
8596         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
8597         NULL check.
8598
8599 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
8600
8601         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
8602
8603 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
8604
8605         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
8606         if GDBSERVER is not defined.
8607         (riscv_tdesc_cache): Likewise, also store const target_desc.
8608         (STATIC_IN_GDB): Define.
8609         (riscv_create_target_description): Update declaration with
8610         STATIC_IN_GDB.
8611         (riscv_lookup_target_description): New function, only define if
8612         GDBSERVER is not defined.
8613         * arch/riscv.h (riscv_create_target_description): Declare only
8614         when GDBSERVER is defined.
8615         (riscv_lookup_target_description): New declaration when GDBSERVER
8616         is not defined.
8617         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
8618         (riscv_linux_read_features): ...this, and return
8619         riscv_gdbarch_features instead of target_desc.
8620         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
8621         (riscv_linux_read_description): Rename to...
8622         (riscv_linux_read_features): ...this.
8623         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
8624         Update to use riscv_gdbarch_features and
8625         riscv_lookup_target_description.
8626         * riscv-tdep.c (riscv_find_default_target_description): Use
8627         riscv_lookup_target_description instead of
8628         riscv_create_target_description.
8629
8630 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
8631
8632         * valprint.c (generic_val_print_enum_1): When printing a flag
8633         enum with value 0 and there is no enumerator with value 0, print
8634         just "0" instead of "(unknown: 0x0)".
8635
8636 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
8637
8638         * valprint.c (generic_val_print_enum_1): Print unknown part of
8639         flag enum in hex.
8640
8641 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
8642
8643         * dwarf2/read.c (update_enumeration_type_from_children): Allow
8644         flag enums to contain duplicate enumerators.
8645         * valprint.c (generic_val_print_enum_1): Update comment.
8646
8647 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
8648
8649         * dwarf2/read.c: Include "count-one-bits.h".
8650         (update_enumeration_type_from_children): If an enumerator has
8651         multiple bits set, don't treat the enumeration as a "flag enum".
8652         * valprint.c (generic_val_print_enum_1): Assert that enumerators
8653         of flag enums have 0 or 1 bit set.
8654
8655 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
8656
8657         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
8658         conversion.
8659         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
8660         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
8661         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
8662         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
8663         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
8664
8665 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
8666
8667         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
8668
8669 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
8670
8671         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
8672         displaced_step_closure_up.
8673         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
8674         (struct displaced_step_closure_up):
8675         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
8676         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
8677         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
8678         Likewise.
8679         * gdbarch.sh (displaced_step_copy_insn): Likewise.
8680         * gdbarch.c, gdbarch.h: Re-generate.
8681         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
8682         displaced_step_closure_up.
8683         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
8684         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
8685         * infrun.h (displaced_step_closure_up): New type alias.
8686         (struct displaced_step_inferior_state) <step_closure>: Change
8687         type to displaced_step_closure_up.
8688         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
8689         displaced_step_closure_up.
8690         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
8691
8692 2020-02-14  Tom Tromey  <tom@tromey.com>
8693
8694         * minidebug.c (gnu_debug_key): New global.
8695         (find_separate_debug_file_in_section): Use it.
8696
8697 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
8698
8699         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
8700         std::unique_ptr.
8701         * gdbarch.c: Re-generate.
8702         * gdbarch.h: Re-generate.
8703         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
8704         change.
8705         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
8706         type to std::unique_ptr.
8707         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
8708         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
8709         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
8710         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
8711         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
8712         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
8713         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
8714         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
8715         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
8716
8717 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
8718
8719         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
8720         std::unique_ptr.
8721         (displaced_step_clear): Rename to...
8722         (displaced_step_reset): ... this.  Just call displaced->reset ().
8723         (displaced_step_clear_cleanup): Rename to...
8724         (displaced_step_reset_cleanup): ... this.
8725         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
8726         (displaced_step_fixup): Likewise.
8727         (resume_1): Likewise.
8728         (handle_inferior_event): Restore child's memory before calling
8729         displaced_step_fixup on the parent.
8730         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
8731         to std::unique_ptr.
8732         <step_closure>: Change type to std::unique_ptr.
8733
8734 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
8735
8736         * arm-tdep.c: Include count-one-bits.h.
8737         (cleanup_block_store_pc): Use count_one_bits.
8738         (cleanup_block_load_pc): Use count_one_bits.
8739         (arm_copy_block_xfer): Use count_one_bits.
8740         (thumb2_copy_block_xfer): Use count_one_bits.
8741         (thumb_copy_pop_pc_16bit): Use count_one_bits.
8742         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
8743         (thumb_get_next_pcs_raw): Use count_one_bits.
8744         (arm_get_next_pcs_raw): Use count_one_bits_l.
8745         * arch/arm.c (bitcount): Remove.
8746         * arch/arm.h (bitcount): Remove.
8747
8748 2020-02-14  Tom Tromey  <tromey@adacore.com>
8749
8750         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
8751         Update.
8752         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
8753         * dwarf2/loc.c (call_site_find_chain_1): Return
8754         unique_xmalloc_ptr.
8755         (call_site_find_chain): Likewise.
8756
8757 2020-02-14  Richard Biener  <rguenther@suse.de>
8758
8759         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
8760         on expression with division operators.
8761
8762 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
8763
8764         * MAINTAINERS (Write After Approval): Adding myself.
8765
8766 2020-02-12  Tom Tromey  <tom@tromey.com>
8767
8768         * event-loop.c (event_data, gdb_event, event_handler_func):
8769         Remove.
8770
8771 2020-02-12  Tom Tromey  <tom@tromey.com>
8772
8773         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
8774         (dwarf2_frame_objfile_data): Add comment.
8775         (find_comp_unit, set_comp_unit): New functions.
8776         (dwarf2_frame_find_fde): Use find_comp_unit.
8777         (dwarf2_build_frame_info): Use set_comp_unit.
8778
8779 2020-02-12  Tom Tromey  <tom@tromey.com>
8780
8781         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
8782         (comp_unit): Don't initialize objfile.
8783         (execute_cfa_program): Add text_offset parameter.
8784         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
8785         (dwarf2_frame_cache): Update.
8786         (dwarf2_build_frame_info): Don't set "objfile" member.
8787
8788 2020-02-12  Tom Tromey  <tom@tromey.com>
8789
8790         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
8791         (decode_frame_entry): Likewise.
8792         (dwarf2_build_frame_info): Update.
8793
8794 2020-02-12  Tom Tromey  <tom@tromey.com>
8795
8796         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
8797         (decode_frame_entry_1): Use the comp_unit obstack.
8798
8799 2020-02-12  Tom Tromey  <tom@tromey.com>
8800
8801         * dwarf2/frame.c (struct comp_unit): Add initializers and
8802         constructor.
8803         (dwarf2_frame_objfile_data): Store a comp_unit.
8804         (dwarf2_frame_find_fde): Update.
8805         (dwarf2_build_frame_info): Use "new".
8806
8807 2020-02-12  Tom Tromey  <tom@tromey.com>
8808
8809         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
8810         (dwarf2_fde_table): Typedef for std::vector.
8811         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
8812         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
8813         (decode_frame_entry): Update.
8814         (dwarf2_build_frame_info): Use "new".
8815
8816 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
8817
8818         * arm-tdep.c (arm_gdbarch_init): Update.
8819         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
8820         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
8821         have_neon, is_m>: Change to bool.
8822
8823 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
8824
8825         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
8826
8827 2020-02-12  Tom Tromey  <tom@tromey.com>
8828
8829         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
8830
8831 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
8832
8833         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
8834         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
8835
8836 2020-02-11  Tom Tromey  <tom@tromey.com>
8837
8838         * psymtab.h: Update comment.
8839
8840 2020-02-11  Tom Tromey  <tom@tromey.com>
8841
8842         * gdb_obstack.h (struct auto_obstack): Use
8843         DISABLE_COPY_AND_ASSIGN.
8844
8845 2020-02-11  Tom Tromey  <tom@tromey.com>
8846
8847         * dwarf2/frame.h (struct objfile): Don't forward declare.
8848
8849 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
8850
8851         * cris-tdep.c (cris_supply_gregset): Change signature to match
8852         what struct regset expects.
8853         (cris_regset): New struct.
8854         (fetch_core_registers): Remove.
8855         (cris_iterate_over_regset_sections): New function.
8856         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
8857         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
8858
8859 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
8860
8861         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
8862         registers.
8863
8864 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
8865
8866         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
8867
8868 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
8869
8870         * configure: Re-generate.
8871
8872 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
8873
8874         * configure: Re-generate.
8875
8876 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
8877
8878         * acinclude: Update warning.m4 path.
8879         * warning.m4: Move to gdbsupport.
8880
8881 2020-02-11  Tom Tromey  <tromey@adacore.com>
8882
8883         * remote.c (remote_console_output): Update.
8884         * printcmd.c (printf_command): Update.
8885         * event-loop.c (gdb_wait_for_event): Update.
8886         * linux-nat.c (sigchld_handler): Update.
8887         * remote-sim.c (gdb_os_write_stdout): Update.
8888         (gdb_os_flush_stdout): Update.
8889         (gdb_os_flush_stderr): Update.
8890         (gdb_os_write_stderr): Update.
8891         * exceptions.c (print_exception): Update.
8892         * remote-fileio.c (remote_fileio_func_read): Update.
8893         (remote_fileio_func_write): Update.
8894         * tui/tui.c (tui_enable): Update.
8895         * tui/tui-interp.c (tui_interp::init): Update.
8896         * utils.c (init_page_info): Update.
8897         (putchar_unfiltered, fputc_unfiltered): Update.
8898         (gdb_flush): Update.
8899         (emit_style_escape): Update.
8900         (flush_wrap_buffer, fputs_maybe_filtered): Update.
8901         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
8902         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
8903         (stderr_file::write): Update.
8904         (stderr_file::puts): Update.
8905         * ui-file.h (ui_file_isatty, ui_file_write)
8906         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
8907         (ui_file_puts): Don't declare.
8908
8909 2020-02-10  Tom de Vries  <tdevries@suse.de>
8910
8911         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
8912         sentinel to char *.
8913
8914 2020-02-09  Tom de Vries  <tdevries@suse.de>
8915
8916         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
8917         filename if it matches "<artificial>".
8918
8919 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
8920
8921         * windows-tdep.c (struct enum_value_name): New struct.
8922         (create_enum): New function.
8923         (windows_get_siginfo_type): Create and use enum types.
8924
8925 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
8926
8927         * NEWS: Mention $_siginfo support for Windows.
8928         * windows-nat.c (handle_exception): Set siginfo_er.
8929         (windows_nat_target::mourn_inferior): Reset siginfo_er.
8930         (windows_xfer_siginfo): New function.
8931         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
8932         * windows-tdep.c (struct windows_gdbarch_data): New struct.
8933         (init_windows_gdbarch_data): New function.
8934         (get_windows_gdbarch_data): New function.
8935         (windows_get_siginfo_type): New function.
8936         (windows_init_abi): Register windows_get_siginfo_type.
8937         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
8938
8939 2020-02-08  Tom Tromey  <tom@tromey.com>
8940
8941         * dwarf2/read.c (class cutu_reader) <cutu_reader,
8942         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
8943         <keep>: Declare method.
8944         <m_keep>: Remove member.
8945         <~cutu_reader>: Remove.
8946         (cutu_reader::init_tu_and_read_dwo_dies): Update.
8947         (cutu_reader::cutu_reader): Update.
8948         (cutu_reader::keep): Rename from ~cutu_reader.
8949         (process_psymtab_comp_unit, build_type_psymtabs_1)
8950         (process_skeletonless_type_unit, load_partial_comp_unit)
8951         (load_full_comp_unit, dwarf2_read_addr_index)
8952         (read_signatured_type): Update.
8953
8954 2020-02-08  Tom Tromey  <tom@tromey.com>
8955
8956         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
8957         "want_partial_unit" parameter.
8958         (process_psymtab_comp_unit): Change want_partial_unit to bool.
8959         Inline check for DW_TAG_partial_unit.
8960         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
8961
8962 2020-02-08  Tom Tromey  <tom@tromey.com>
8963
8964         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
8965         read.c.
8966         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
8967         read.c.
8968
8969 2020-02-08  Tom Tromey  <tom@tromey.com>
8970
8971         * dwarf2/read.c (read_address): Move to comp-unit.c.
8972         (dwarf2_rnglists_process, dwarf2_ranges_process)
8973         (read_attribute_value, dwarf_decode_lines_1)
8974         (var_decode_location, decode_locdesc): Update.
8975         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
8976         read.c.  Remove "cu" parameter.
8977         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
8978         method.
8979
8980 2020-02-08  Tom Tromey  <tom@tromey.com>
8981
8982         * dwarf2/read.c (read_attribute_value, read_indirect_string)
8983         (read_indirect_line_string): Update.
8984         * dwarf2/comp-unit.c (read_offset): Remove.
8985         (read_comp_unit_head): Update.
8986         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
8987         method.
8988         (read_offset): Don't declare.
8989
8990 2020-02-08  Tom Tromey  <tom@tromey.com>
8991
8992         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
8993         * dwarf2/read.c (struct comp_unit_head): Move to
8994         dwarf2/comp-unit.h.
8995         (enum class rcuh_kind): Move to comp-unit.h.
8996         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
8997         (read_comp_unit_head, error_check_comp_unit_head)
8998         (read_and_check_comp_unit_head): Move to comp-unit.c.
8999         (read_offset, dwarf_unit_type_name): Likewise.
9000         (create_debug_type_hash_table, read_cutu_die_from_dwo)
9001         (cutu_reader::cutu_reader, read_call_site_scope)
9002         (find_partial_die, follow_die_offset): Update.
9003         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
9004
9005 2020-02-08  Tom Tromey  <tom@tromey.com>
9006
9007         * dwarf2/read.c (read_offset_1): Move to leb.c.
9008         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
9009         (dwarf_decode_macro_bytes): Update.
9010         * dwarf2/leb.c (read_offset): Rename; move from read.c.
9011         * dwarf2/leb.h (read_offset): Declare.
9012
9013 2020-02-08  Tom Tromey  <tom@tromey.com>
9014
9015         * dwarf2/read.c (dwarf2_section_size): Remove.
9016         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
9017         Update.
9018         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
9019
9020 2020-02-08  Tom Tromey  <tom@tromey.com>
9021
9022         * dwarf2/read.c (read_initial_length): Move to leb.c.
9023         * dwarf2/leb.h (read_initial_length): Declare.
9024         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
9025         handle_nonstd parameter.
9026         * dwarf2/frame.c (read_initial_length): Remove.
9027         (decode_frame_entry_1): Update.
9028
9029 2020-02-08  Tom Tromey  <tom@tromey.com>
9030
9031         * dwarf2/loc.c (dwarf2_find_location_expression)
9032         (dwarf_evaluate_loc_desc::get_tls_address)
9033         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
9034         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
9035         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
9036         (dwarf2_compile_property_to_c)
9037         (dwarf2_loc_desc_get_symbol_read_needs)
9038         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
9039         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
9040         (loclist_describe_location, loclist_tracepoint_var_ref)
9041         (loclist_generate_c_location): Update.
9042         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
9043         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
9044         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
9045         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
9046         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
9047         (dwarf2_per_cu_data::addr_size)
9048         (dwarf2_per_cu_data::ref_addr_size)
9049         (dwarf2_per_cu_data::text_offset)
9050         (dwarf2_per_cu_data::addr_type): Now methods.
9051         (per_cu_header_read_in): Make per_cu "const".
9052         (dwarf2_version): Remove.
9053         (dwarf2_per_cu_data::int_type): Now a method.
9054         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
9055         (set_die_type, read_array_type, read_subrange_index_type)
9056         (read_tag_string_type, read_subrange_type): Update.
9057         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
9058         offset_size, ref_addr_size, text_offset, addr_type, version,
9059         objfile, int_type, addr_sized_int_type>: Declare methods.
9060
9061 2020-02-08  Tom Tromey  <tom@tromey.com>
9062
9063         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
9064         Move earlier.
9065
9066 2020-02-08  Tom Tromey  <tom@tromey.com>
9067
9068         * dwarf2/read.h (dwarf_line_debug): Declare.
9069         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
9070         * dwarf2/read.c: Move line_header code to new files.
9071         (dwarf_line_debug): No longer static.
9072         * dwarf2/line-header.c: New file.
9073         * dwarf2/line-header.h: New file.
9074
9075 2020-02-08  Tom Tromey  <tom@tromey.com>
9076
9077         * dwarf2/read.c (struct line_header) <file_full_name,
9078         file_file_name>: Return unique_xmalloc_ptr.
9079         (line_header::file_file_name): Update.
9080         (line_header::file_full_name): Update.
9081         (dw2_get_file_names_reader): Update.
9082         (macro_start_file): Update.
9083
9084 2020-02-08  Tom Tromey  <tom@tromey.com>
9085
9086         * dwarf2/read.c (struct line_header) <file_full_name,
9087         file_file_name>: Declare methods.
9088         (dw2_get_file_names_reader): Update.
9089         (file_file_name): Now a method.
9090         (file_full_name): Likewise.
9091         (macro_start_file): Update.
9092
9093 2020-02-08  Tom Tromey  <tom@tromey.com>
9094
9095         * dwarf2/read.c (dwarf_always_disassemble)
9096         (show_dwarf_always_disassemble): Move to loc.c.
9097         (_initialize_dwarf2_read): Move "always-disassemble" registration
9098         to loc.c.
9099         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
9100         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
9101         static.
9102         (show_dwarf_always_disassemble): Move from read.c.
9103         (_initialize_dwarf2loc): Move always-disassemble from read.c.
9104
9105 2020-02-08  Tom Tromey  <tom@tromey.com>
9106
9107         * dwarf2/read.c (~dwarf2_per_objfile): Update.
9108         (create_quick_file_names_table): Return htab_up.
9109         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
9110         Update.
9111         * dwarf2/read.h (struct dwarf2_per_objfile)
9112         <quick_file_names_table>: Now htab_up.
9113
9114 2020-02-08  Tom Tromey  <tom@tromey.com>
9115
9116         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
9117
9118 2020-02-08  Tom Tromey  <tom@tromey.com>
9119
9120         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
9121         Rewrite.
9122         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
9123         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
9124         (abbrev_table::abbrev_table): No longer inline.
9125         (ABBREV_HASH_SIZE): Remove.
9126         (abbrev_table::m_abbrevs): Now an htab_up.
9127
9128 2020-02-08  Tom Tromey  <tom@tromey.com>
9129
9130         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
9131         (cutu_reader): Update.
9132         (build_type_psymtabs_1): Update.
9133         * dwarf2/abbrev.c (abbrev_table::read): Rename.
9134         (abbrev_table::alloc_abbrev): Update.
9135         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
9136         (abbrev_table::read): New static method, renamed from
9137         abbrev_table_read_table.
9138         (abbrev_table::alloc_abbrev)
9139         (abbrev_table::add_abbrev): Now private.
9140         (abbrev_table::abbrev_table): Now private.
9141         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
9142
9143 2020-02-08  Tom Tromey  <tom@tromey.com>
9144
9145         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
9146         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
9147         htab_up.
9148
9149 2020-02-08  Tom Tromey  <tom@tromey.com>
9150
9151         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
9152         htab_up.
9153         (lookup_dwo_unit_in_dwp): Update.
9154         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
9155         on obstack.
9156
9157 2020-02-08  Tom Tromey  <tom@tromey.com>
9158
9159         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
9160         obstack.
9161
9162 2020-02-08  Tom Tromey  <tom@tromey.com>
9163
9164         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
9165         line_header_hash.
9166         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
9167         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
9168         Change type to htab_up.
9169
9170 2020-02-08  Tom Tromey  <tom@tromey.com>
9171
9172         * dwarf2/read.c (allocate_type_unit_groups_table): Return
9173         htab_up.  Don't allocate on obstack.
9174         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
9175         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
9176         Change type to htab_up.
9177
9178 2020-02-08  Tom Tromey  <tom@tromey.com>
9179
9180         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
9181         Change type to htab_up.
9182         * dwarf2/read.c (create_signatured_type_table_from_index)
9183         (create_signatured_type_table_from_debug_names)
9184         (create_all_type_units, add_type_unit)
9185         (lookup_dwo_signatured_type, lookup_signatured_type)
9186         (process_skeletonless_type_unit): Update.
9187         (create_debug_type_hash_table, create_debug_types_hash_table):
9188         Change type of types_htab.
9189         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
9190         htab_up.  Don't allocate on obstack.
9191         (create_cus_hash_table): Change type of cus_htab parameter.
9192         (struct dwo_file) <cus, tus>: Now htab_up.
9193         (lookup_dwo_signatured_type, lookup_dwo_cutu)
9194         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
9195         (queue_and_load_all_dwo_tus): Update.
9196         * dwarf2/index-write.c (write_gdbindex): Update.
9197         (write_debug_names): Update.
9198
9199 2020-02-08  Tom Tromey  <tom@tromey.com>
9200
9201         * dwarf2/read.h (struct dwarf2_queue_item): Move from
9202         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
9203         destructor.
9204         (struct dwarf2_per_objfile) <queue>: New member.
9205         * dwarf2/read.c (struct dwarf2_queue_item): Move to
9206         dwarf2/read.h.
9207         (dwarf2_queue, dwarf2_queue_tail): Remove.
9208         (class dwarf2_queue_guard): Add parameter to constructor.  Use
9209         DISABLE_COPY_AND_ASSIGN.
9210         <m_per_objfile>: New member.
9211         <~dwarf2_queue_guard>: Rewrite.
9212         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
9213         Update.
9214         (~dwarf2_queue_item): New.
9215
9216 2020-02-08  Tom Tromey  <tom@tromey.com>
9217
9218         * dwarf2/read.c (struct die_info) <has_children>: New member.
9219         (dw2_get_file_names_reader): Remove has_children.
9220         (dw2_get_file_names): Update.
9221         (read_cutu_die_from_dwo): Remove has_children.
9222         (cutu_reader::init_tu_and_read_dwo_dies)
9223         (cutu_reader::cutu_reader): Update.
9224         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
9225         Remove has_children.
9226         (build_type_psymtabs_1, process_skeletonless_type_unit)
9227         (load_partial_comp_unit, load_full_comp_unit): Update.
9228         (create_dwo_cu_reader): Remove has_children.
9229         (create_cus_hash_table, read_die_and_children): Update.
9230         (read_full_die_1,read_full_die): Remove has_children.
9231         (read_signatured_type): Update.
9232         (class cutu_reader) <has_children>: Remove.
9233
9234 2020-02-08  Tom Tromey  <tom@tromey.com>
9235
9236         * dwarf2/expr.c: Rename from dwarf2expr.c.
9237         * dwarf2/expr.h: Rename from dwarf2expr.h.
9238         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
9239         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
9240         * dwarf2/frame.c: Rename from dwarf2-frame.c.
9241         * dwarf2/frame.h: Rename from dwarf2-frame.h.
9242         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
9243         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
9244         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
9245         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
9246         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
9247         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
9248         * dwarf2/loc.c: Rename from dwarf2loc.c.
9249         * dwarf2/loc.h: Rename from dwarf2loc.h.
9250         * dwarf2/read.c: Rename from dwarf2read.c.
9251         * dwarf2/read.h: Rename from dwarf2read.h.
9252         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
9253         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
9254         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
9255         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
9256         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
9257         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
9258         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
9259         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
9260         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
9261         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
9262         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
9263         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
9264         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
9265         Update.
9266         * Makefile.in (COMMON_SFILES): Update.
9267         (HFILES_NO_SRCDIR): Update.
9268
9269 2020-02-08  Tom Tromey  <tom@tromey.com>
9270
9271         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
9272         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
9273
9274 2020-02-08  Tom Tromey  <tom@tromey.com>
9275
9276         * dwarf2read.h (struct die_info): Don't declare.
9277
9278 2020-02-08  Tom Tromey  <tom@tromey.com>
9279
9280         * dwarf2read.h (die_info_ptr): Remove typedef.
9281
9282 2020-02-08  Tom Tromey  <tom@tromey.com>
9283
9284         * dwarf2read.c (read_call_site_scope)
9285         (handle_data_member_location, dwarf2_add_member_fn)
9286         (mark_common_block_symbol_computed, read_common_block)
9287         (attr_to_dynamic_prop, partial_die_info::read)
9288         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
9289         (dwarf2_symbol_mark_computed, set_die_type): Update.
9290         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
9291         method.
9292         (attr_form_is_block): Don't declare.
9293         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
9294
9295 2020-02-08  Tom Tromey  <tom@tromey.com>
9296
9297         * dwarf2read.c (dwarf2_find_base_address, )
9298         (read_call_site_scope, rust_containing_type)
9299         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
9300         (handle_data_member_location, dwarf2_add_member_fn)
9301         (get_alignment, read_structure_type, process_structure_scope)
9302         (mark_common_block_symbol_computed, read_common_block)
9303         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
9304         (partial_die_info::read, read_attribute_value, new_symbol)
9305         (lookup_die_type, dwarf2_get_ref_die_offset)
9306         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
9307         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
9308         (dwarf2_symbol_mark_computed): Update.
9309         * dwarf2/attribute.h (struct attribute) <value_as_address,
9310         form_is_section_offset, form_is_constant, form_is_ref>: Declare
9311         methods.
9312         (value_as_address, attr_form_is_section_offset)
9313         (attr_form_is_constant, attr_form_is_ref): Don't declare.
9314         * dwarf2/attribute.c (attribute::value_as_address)
9315         (attribute::form_is_section_offset, attribute::form_is_constant)
9316         (attribute::form_is_ref): Now methods.
9317
9318 2020-02-08  Tom Tromey  <tom@tromey.com>
9319
9320         * dwarf2read.c (struct attribute, DW_STRING)
9321         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
9322         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
9323         (attr_form_is_block, attr_form_is_section_offset)
9324         (attr_form_is_constant, attr_form_is_ref): Move.
9325         * dwarf2/attribute.h: New file.
9326         * dwarf2/attribute.c: New file, from dwarf2read.c.
9327         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
9328
9329 2020-02-08  Tom Tromey  <tom@tromey.com>
9330
9331         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
9332         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
9333         Move.
9334         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
9335         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
9336         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
9337         abbrev.c.
9338         * dwarf2/abbrev.h: New file.
9339         * dwarf2/abbrev.c: New file, from dwarf2read.c.
9340         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
9341
9342 2020-02-08  Tom Tromey  <tom@tromey.com>
9343
9344         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
9345         (dwarf2_section_size, dwarf2_get_section_info)
9346         (create_signatured_type_table_from_debug_names)
9347         (create_addrmap_from_aranges, read_debug_names_from_section)
9348         (get_gdb_index_contents_from_section, read_comp_unit_head)
9349         (error_check_comp_unit_head, read_abbrev_offset)
9350         (create_debug_type_hash_table, init_cu_die_reader)
9351         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
9352         (read_comp_units_from_section, create_cus_hash_table)
9353         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
9354         (create_dwp_v2_section, dwarf2_rnglists_process)
9355         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
9356         (abbrev_table_read_table, read_indirect_string_at_offset_from)
9357         (read_indirect_string_from_dwz, read_addr_index_1)
9358         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
9359         (dwarf_decode_macro_bytes, dwarf_decode_macros)
9360         (fill_in_loclist_baton): Update.
9361         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
9362         get_containing_section, get_bfd_owner, get_bfd_section,
9363         get_file_name, get_id, get_flags, empty, read>: Declare methods.
9364         (dwarf2_read_section, get_section_name, get_section_file_name)
9365         (get_containing_section, get_section_bfd_owner)
9366         (get_section_bfd_section, get_section_name, get_section_file_name)
9367         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
9368         declare.
9369         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
9370         (dwarf2_section_info::get_bfd_owner)
9371         (dwarf2_section_info::get_bfd_section)
9372         (dwarf2_section_info::get_name)
9373         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
9374         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
9375         (dwarf2_section_info::read): Now methods.
9376         * dwarf-index-write.c (class debug_names): Update.
9377
9378 2020-02-08  Tom Tromey  <tom@tromey.com>
9379
9380         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
9381         Move to dwarf2/section.h.
9382         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
9383         (get_section_bfd_section, get_section_name)
9384         (get_section_file_name, get_section_id, get_section_flags)
9385         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
9386         dwarf2/section.c.
9387         * dwarf2/section.h: New file.
9388         * dwarf2/section.c: New file, from dwarf2read.c.
9389         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
9390
9391 2020-02-08  Tom Tromey  <tom@tromey.com>
9392
9393         * dwarf2read.h (read_unsigned_leb128): Don't declare.
9394         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
9395         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
9396         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
9397         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
9398         * dwarf2/leb.h: New file, from dwarf2read.c.
9399         * dwarf2/leb.c: New file, from dwarf2read.c.
9400         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
9401         Remove.
9402         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
9403         (COMMON_SFILES): Add dwarf2/leb.c.
9404
9405 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
9406
9407         GDB 9.1 released.
9408
9409 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
9410
9411         PR gdb/25190:
9412         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
9413         * gdb/remote.c (remote_console_output): Update.
9414         * gdb/ui-file.c (fputs_unfiltered): Rename to...
9415         (ui_file_puts): ...this.
9416         * gdb/ui-file.h (ui_file_puts): Add declaration.
9417         * gdb/utils.c (emit_style_escape): Update.
9418         (flush_wrap_buffer): Update.
9419         (fputs_maybe_filtered): Update.
9420         (fputs_unfiltered): Add function.
9421
9422 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
9423
9424         * gdb/event-loop.c (gdb_wait_for_event): Update.
9425         * gdb/printcmd.c (printf_command): Update.
9426         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
9427         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
9428         (gdb_os_flush_stderr): Update.
9429         * gdb/remote.c (remote_console_output): Update.
9430         * gdb/ui-file.c (gdb_flush): Rename to...
9431         (ui_file_flush): ...this.
9432         (stderr_file::write): Update.
9433         (stderr_file::puts): Update.
9434         * gdb/ui-file.h (gdb_flush): Rename to...
9435         (ui_file_flush): ...this.
9436         * gdb/utils.c (gdb_flush): Add function.
9437         * gdb/utils.h (gdb_flush): Add declaration.
9438
9439 2020-02-07  Tom Tromey  <tromey@adacore.com>
9440
9441         PR breakpoints/24915:
9442         * source.c (find_and_open_source): Do not check basenames_may_differ.
9443
9444 2020-02-07  Tom Tromey  <tom@tromey.com>
9445
9446         * README: Update gdbserver documentation.
9447         * gdbserver: Move to top level.
9448         * configure.tgt (build_gdbserver): Remove.
9449         * configure.ac: Remove --enable-gdbserver.
9450         * configure: Rebuild.
9451         * Makefile.in (distclean): Don't mention gdbserver.
9452
9453 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
9454
9455         * source-cache.c (source_cache::ensure): Surround
9456         get_plain_source_lines with a try/catch.
9457         (source_cache::get_line_charpos): Get rid of try/catch
9458         and only check for the return value of "ensure".
9459         * tui/tui-source.c (tui_source_window::set_contents):
9460         Simplify "nlines" calculation.
9461
9462 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
9463
9464         * MAINTAINERS (Write After Approval): Add myself.
9465
9466 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
9467
9468         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
9469         function call.
9470
9471 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
9472
9473         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
9474
9475 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
9476
9477         * nat/riscv-linux-tdesc.h: New file.
9478         * nat/riscv-linux-tdesc.c: New file, taking code from...
9479         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
9480         ... here.
9481         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
9482         NATDEPFILES.
9483
9484 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
9485
9486         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
9487         we don't set the fake simulator ptid to the null_ptid.
9488
9489 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
9490
9491         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
9492         * gdbthread.h (class thread_info) <resumed>: Likewise.
9493         * infrun.c (resume_1): Likewise.
9494         (proceed): Likewise.
9495         (infrun_thread_stop_requested): Likewise.
9496         (stop_all_threads): Likewise.
9497         (handle_inferior_event): Likewise.
9498         (restart_threads): Likewise.
9499         (finish_step_over): Likewise.
9500         (keep_going_stepped_thread): Likewise.
9501         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
9502         (linux_handle_extended_wait): Likewise.
9503         * record-btrace.c (get_thread_current_frame_id): Likewise.
9504         * record-full.c (record_full_wait_1): Likewise.
9505         * remote.c (remote_target::process_initial_stop_replies): Likewise.
9506         * target.c (target_resume): Likewise.
9507         * thread.c (set_running_thread): Likewise.
9508
9509 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
9510
9511         * f-valprint.c (f77_print_array_1): Changed datatype of index
9512         variable to LONGEST from int to enable it to contain bound
9513         values correctly.
9514
9515 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
9516
9517         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
9518         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
9519         offsets according to FLEN determined.
9520         (riscv_linux_nat_target::read_description): Determine FLEN
9521         dynamically.
9522         (riscv_linux_nat_target::fetch_registers): Size regset buffer
9523         according to FLEN determined.
9524         (riscv_linux_nat_target::store_registers): Likewise.
9525
9526 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
9527
9528         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
9529         when reg->group is empty and reggroup is not.
9530
9531 2020-01-31  Tom Tromey  <tromey@adacore.com>
9532
9533         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
9534         Call beneath target's mourn_inferior after unpushing.
9535
9536 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
9537
9538         PR tui/9765
9539         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
9540         have enough lines to fill the screen, still return the lowest
9541         address we found.
9542
9543 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
9544
9545         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
9546         '-', '<', and '>' commands.
9547
9548 2020-01-29  Pedro Alves  <palves@redhat.com>
9549             Sergio Durigan Junior  <sergiodj@redhat.com>
9550
9551         * infcmd.c (construct_inferior_arguments): Assert that
9552         'argc' is greater than 0.
9553
9554 2020-01-29  Luis Machado  <luis.machado@linaro.org>
9555
9556         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
9557         (BRK_INSN_MASK): Define to 0xd4200000.
9558         (aarch64_program_breakpoint_here_p): New function.
9559         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
9560         * arch-utils.c (default_program_breakpoint_here_p): Moved from
9561         breakpoint.c.
9562         * arch-utils.h (default_program_breakpoint_here_p): Moved from
9563         breakpoint.h
9564         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
9565         call gdbarch_program_breakpoint_here_p.
9566         (program_breakpoint_here): Moved to arch-utils.c, renamed to
9567         default_program_breakpoint_here_p, changed return type to bool and
9568         simplified.
9569         * breakpoint.h (program_breakpoint_here): Moved prototype to
9570         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
9571         return type to bool.
9572         * gdbarch.c: Regenerate.
9573         * gdbarch.h: Regenerate.
9574         * gdbarch.sh (program_breakpoint_here_p): New method.
9575         * infrun.c (handle_signal_stop): Call
9576         gdbarch_program_breakpoint_here_p.
9577
9578 2020-01-26  Tom Tromey  <tom@tromey.com>
9579
9580         * ctfread.c (struct ctf_fp_info): Reindent.
9581         (_initialize_ctfread): Remove.
9582
9583 2020-01-26  Tom Tromey  <tom@tromey.com>
9584
9585         * psymtab.c (partial_map_expand_apply)
9586         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
9587         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
9588         (psym_print_stats, psym_expand_symtabs_for_function)
9589         (psym_map_symbol_filenames, psym_map_matching_symbols)
9590         (psym_expand_symtabs_matching)
9591         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
9592         (maintenance_check_psymtabs): Use new methods.
9593         * psympriv.h (struct partial_symtab) <readin_p,
9594         get_compunit_symtab>: New methods.
9595         <readin, compunit_symtab>: Remove members.
9596         (struct standard_psymtab): New.
9597         (struct legacy_psymtab): Derive from standard_psymtab.
9598         * dwarf2read.h (struct dwarf2_psymtab): Derive from
9599         standard_psymtab.
9600         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
9601
9602 2020-01-26  Tom Tromey  <tom@tromey.com>
9603
9604         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
9605         read_dependencies.  Add assert.
9606         * psymtab.c (partial_symtab::read_dependencies): New method.
9607         * psympriv.h (struct partial_symtab) <read_dependencies>: New
9608         method.
9609         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
9610         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
9611         read_dependencies.
9612         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
9613         Add assert.
9614
9615 2020-01-26  Tom Tromey  <tom@tromey.com>
9616
9617         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
9618         Call expand_psymtab.
9619         (xcoff_read_symtab): Call expand_psymtab.
9620         (xcoff_start_psymtab, xcoff_end_psymtab): Set
9621         legacy_expand_psymtab.
9622         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
9623         method.
9624         (struct legacy_psymtab) <expand_psymtab>: Implement.
9625         <legacy_expand_psymtab>: New member.
9626         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
9627         (parse_partial_symbols): Set legacy_expand_psymtab.
9628         (psymtab_to_symtab_1): Change argument order.  Call
9629         expand_psymtab.
9630         (new_psymtab): Set legacy_expand_psymtab.
9631         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
9632         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
9633         expand_psymtab.
9634         (dwarf2_psymtab::expand_psymtab): Rename from
9635         psymtab_to_symtab_1.  Call expand_psymtab.
9636         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
9637         (dbx_end_psymtab): Likewise.
9638         (dbx_psymtab_to_symtab_1): Change argument order. Call
9639         expand_psymtab.
9640         (dbx_read_symtab): Call expand_psymtab.
9641         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
9642         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
9643         (ctf_psymtab::read_symtab): Call expand_psymtab.
9644
9645 2020-01-26  Tom Tromey  <tom@tromey.com>
9646
9647         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
9648         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
9649         messages.
9650         * mdebugread.c (mdebug_read_symtab): Remove prints.
9651         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
9652         assert.
9653         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
9654
9655 2020-01-26  Tom Tromey  <tom@tromey.com>
9656
9657         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
9658         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
9659         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
9660         legacy_symtab.
9661         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
9662         * psymtab.c (psymtab_to_symtab): Call method.
9663         (dump_psymtab): Update.
9664         * psympriv.h (struct partial_symtab): Add virtual destructor.
9665         <read_symtab>: New method.
9666         (struct legacy_symtab): New.
9667         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
9668         (struct pst_map) <pst>: Now a legacy_psymtab.
9669         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
9670         (new_psymtab): Use legacy_psymtab.
9671         * dwarf2read.h (struct dwarf2_psymtab): New.
9672         (struct dwarf2_per_cu_data) <psymtab>: Use it.
9673         * dwarf2read.c (dwarf2_create_include_psymtab)
9674         (dwarf2_build_include_psymtabs, create_type_unit_group)
9675         (create_partial_symtab, process_psymtab_comp_unit_reader)
9676         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
9677         (set_partial_user): Use dwarf2_psymtab.
9678         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
9679         (psymtab_to_symtab_1, process_full_comp_unit)
9680         (process_full_type_unit, dwarf2_ranges_read)
9681         (dwarf2_get_pc_bounds, psymtab_include_file_name)
9682         (dwarf_decode_lines): Use dwarf2_psymtab.
9683         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
9684         (add_address_entry_worker, write_one_signatured_type)
9685         (recursively_count_psymbols, recursively_write_psymbols)
9686         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
9687         (write_debug_names): Likewise.
9688         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
9689         <pst>: Now a legacy_psymtab.
9690         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
9691         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
9692         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
9693         * ctfread.c (struct ctf_psymtab): New.
9694         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
9695         ctf_psymtab.
9696         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
9697         (create_partial_symtab): Return a ctf_psymtab.
9698         (scan_partial_symbols): Update.
9699
9700 2020-01-26  Tom Tromey  <tom@tromey.com>
9701
9702         * xcoffread.c (xcoff_start_psymtab): Use new.
9703         * psymtab.c (partial_symtab::partial_symtab): New constructor,
9704         renamed from start_psymtab_common.
9705         * psympriv.h (struct partial_symtab): Add new constructor.
9706         (start_psymtab_common): Don't declare.
9707         * mdebugread.c (parse_partial_symbols): Use new.
9708         * dwarf2read.c (create_partial_symtab): Use new.
9709         * dbxread.c (start_psymtab): Use new.
9710         * ctfread.c (create_partial_symtab): Use new.
9711
9712 2020-01-26  Tom Tromey  <tom@tromey.com>
9713
9714         * xcoffread.c (xcoff_end_psymtab): Use new.
9715         * psymtab.c (start_psymtab_common): Use new.
9716         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
9717         Update.
9718         * psympriv.h (struct partial_symtab): Add parameters to
9719         constructor.  Don't inline.
9720         (allocate_psymtab): Don't declare.
9721         * mdebugread.c (new_psymtab): Use new.
9722         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
9723         * dbxread.c (dbx_end_psymtab): Use new.
9724
9725 2020-01-26  Tom Tromey  <tom@tromey.com>
9726
9727         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
9728         allocate_psymtab.  Update documentation.
9729         * psymtab.c (psymtab_storage::install_psymtab): Rename from
9730         allocate_psymtab.  Do not use new.
9731         (allocate_psymtab): Use new.  Update.
9732
9733 2020-01-26  Tom Tromey  <tom@tromey.com>
9734
9735         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
9736         * psymtab.c (psym_print_stats): Update.
9737         * psympriv.h (struct partial_symtab) <readin,
9738         psymtabs_addrmap_supported, anonymous>: Now bool.
9739         * mdebugread.c (psymtab_to_symtab_1): Update.
9740         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
9741         (build_type_psymtabs_reader, psymtab_to_symtab_1)
9742         (process_full_comp_unit, process_full_type_unit): Update.
9743         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
9744         * ctfread.c (psymtab_to_symtab): Update.
9745
9746 2020-01-26  Tom Tromey  <tom@tromey.com>
9747
9748         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
9749         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
9750         * psymtab.c (psymtab_storage): Delete psymtabs.
9751         (psymtab_storage::allocate_psymtab): Use new.
9752         (psymtab_storage::discard_psymtab): Use delete.
9753         * psympriv.h (struct partial_symtab): Add constructor and
9754         initializers.
9755
9756 2020-01-26  Tom Tromey  <tom@tromey.com>
9757
9758         * machoread.c: Do not include psympriv.h.
9759
9760 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9761
9762         * NEWS: Mention the new option and the set/show commands.
9763
9764 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9765
9766         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
9767         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
9768         (validate_exec_file): New variables, enums, functions.
9769         (exec_file_locate_attach, print_section_info): Style the filenames.
9770         (_initialize_exec): Install show_exec_file_mismatch_command and
9771          set_exec_file_mismatch_command.
9772         * gdbcore.h (validate_exec_file): Declare.
9773         * infcmd.c (attach_command): Call validate_exec_file.
9774         * remote.c ( remote_target::remote_add_inferior): Likewise.
9775
9776 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
9777
9778         * frame.c (find_frame_sal): Move call to get_next_frame into more
9779         inner scope.
9780         * inline-frame.c (inilne_state) <inline_state>: Update argument
9781         types.
9782         (inilne_state) <skipped_symbol>: Rename to...
9783         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
9784         (skip_inline_frames): Build vector of skipped symbols and use this
9785         to reate the inline_state.
9786         (inline_skipped_symbol): Add a comment and some assertions, fetch
9787         skipped symbol from the list.
9788
9789 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
9790
9791         * buildsym.c (lte_is_less_than): Delete.
9792         (buildsym_compunit::end_symtab_with_blockvector): Create local
9793         lambda function to sort line table entries, and use
9794         std::stable_sort instead of std::sort.
9795         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
9796         markers when looking for a previous line.
9797
9798 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
9799
9800         * dwarf2read.c (lnp_state_machine::record_line): Include
9801         end_sequence parameter in debug print out.  Record the line if we
9802         are at an end_sequence marker even if it's not the start of a
9803         statement.
9804         * symmisc.c (maintenance_print_one_line_table): Print end of
9805         sequence markers with 'END' not '0'.
9806
9807 2020-01-24  Pedro Alves  <palves@redhat.com>
9808
9809         PR gdb/25410
9810         * thread.c (scoped_restore_current_thread::restore): Use
9811         switch_to_inferior_no_thread.
9812         * exec.c: Include "progspace-and-thread.h".
9813         (add_target_sections, remove_target_sections):
9814         scoped_restore_current_pspace_and_thread instead of
9815         scoped_restore_current_thread.
9816         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
9817         and aspace to the inferior before calling clone_program_space.
9818         Remove stale comment.
9819
9820 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
9821
9822         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
9823         (arm_netbsd_nat_target::fetch_registers): ...this.
9824         (arm_nbsd_nat_target::store_registers): Rename to...
9825         (arm_netbsd_nat_target::store_registers): ...this.
9826
9827 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
9828
9829         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
9830         register_t.
9831
9832 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
9833
9834         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
9835         Update comment.
9836         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
9837         Likewise.
9838         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
9839         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
9840         the correct replacement (iterate_over_regset_sections).
9841         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
9842         Update comment.
9843
9844 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
9845
9846         PR gdb/23718
9847         * gdb/python/python.c (execute_gdb_command): Call
9848         async_enable_stdin in catch block.
9849
9850 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
9851
9852         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
9853         SWITCH_THRU_ALL_UIS.
9854
9855 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
9856
9857         PR tui/9765
9858         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
9859         comment, add extra parameter, and update to store previous symbol
9860         when appropriate.
9861         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
9862         add extra parameter.
9863         * tui/tui-disasm.c (tui_disassemble): Update header comment,
9864         remove unneeded parameter, add try/catch around gdb_print_insn,
9865         rewrite to add items to asm_lines vector.
9866         (tui_find_backward_disassembly_start_address): New function.
9867         (tui_find_disassembly_address): Updated throughout.
9868         (tui_disasm_window::set_contents): Update for changes to
9869         tui_disassemble.
9870         (tui_disasm_window::do_scroll_vertical): No need to adjust the
9871         number of lines to scroll.
9872
9873 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
9874
9875         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
9876         (SECT_OFF_DATA): Likewise.
9877         (SECT_OFF_RODATA): Likewise.
9878         (SECT_OFF_TEXT): Likewise.
9879         (SECT_OFF_BSS): Likewise.
9880         (struct objfile) <text_section_offset, data_section_offset>: New
9881         methods.
9882         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
9883         objfile::text_section_offset.
9884         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
9885         * coffread.c (coff_symtab_read): Likewise.
9886         (enter_linenos): Likewise.
9887         (process_coff_symbol): Likewise.
9888         * ctfread.c (get_objfile_text_range): Likewise.
9889         * dtrace-probe.c (dtrace_probe::get_relocated_address):
9890         Use objfile::data_section_offset.
9891         * dwarf2-frame.c (execute_cfa_program): Use
9892         objfile::text_section_offset.
9893         (dwarf2_frame_find_fde): Likewise.
9894         * dwarf2read.c (create_addrmap_from_index): Likewise.
9895         (create_addrmap_from_aranges): Likewise.
9896         (dw2_find_pc_sect_compunit_symtab): Likewise.
9897         (process_psymtab_comp_unit_reader): Likewise.
9898         (add_partial_symbol): Likewise.
9899         (add_partial_subprogram): Likewise.
9900         (process_full_comp_unit): Likewise.
9901         (read_file_scope): Likewise.
9902         (read_func_scope): Likewise.
9903         (read_lexical_block_scope): Likewise.
9904         (read_call_site_scope): Likewise.
9905         (dwarf2_rnglists_process): Likewise.
9906         (dwarf2_ranges_process): Likewise.
9907         (dwarf2_ranges_read): Likewise.
9908         (dwarf_decode_lines_1): Likewise.
9909         (new_symbol): Likewise.
9910         (dwarf2_fetch_die_loc_sect_off): Likewise.
9911         (dwarf2_per_cu_text_offset): Likewise.
9912         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
9913         * hppa-tdep.c (read_unwind_info): Likewise.
9914         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
9915         * psympriv.h (struct partial_symtab): Likewise.
9916         * psymtab.c (find_pc_sect_psymtab): Likewise.
9917         * solib-svr4.c (enable_break): Likewise.
9918         * stap-probe.c (relocate_address): Use
9919         objfile::data_section_offset.
9920         * xcoffread.c (enter_line_range): Use
9921         objfile::text_section_offset.
9922         (read_xcoff_symtab): Likewise.
9923
9924 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
9925
9926         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
9927         declaration to narrower scopes.
9928
9929 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
9930
9931         * darwin-nat.h (struct darwin_exception_msg, enum
9932         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
9933         Move up.
9934         (class darwin_nat_target) <wait_1, check_new_threads,
9935         decode_exception_message, decode_message, stop_inferior,
9936         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
9937         * darwin-nat.c (darwin_check_new_threads): Rename to...
9938         (darwin_nat_target::check_new_threads): ... this.
9939         (darwin_suspend_inferior_it): Remove.
9940         (darwin_decode_exception_message): Rename to...
9941         (darwin_nat_target::decode_exception_message): ... this.
9942         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
9943         (darwin_decode_message): Rename to...
9944         (darwin_nat_target::decode_message): ... this.
9945         (cancel_breakpoint): Rename to...
9946         (darwin_nat_target::cancel_breakpoint): ... this.
9947         (darwin_wait): Rename to...
9948         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
9949         instead of iterate_over_inferiors.
9950         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
9951         (darwin_stop_inferior): Rename to...
9952         (darwin_nat_target::stop_inferior): ... this.
9953         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
9954         (darwin_init_thread_list): Rename to...
9955         (darwin_nat_target::init_thread_list): ... this.
9956         (darwin_ptrace_him): Rename to...
9957         (darwin_nat_target::ptrace_him): ... this.
9958         (darwin_nat_target::create_inferior): Pass lambda function to
9959         fork_inferior.
9960         (darwin_nat_target::detach): Call stop_inferior instead of
9961         darwin_stop_inferior.
9962         * fork-inferior.h (fork_inferior): Change init_trace_fun
9963         parameter to gdb::function_view.
9964         * fork-inferior.c (fork_inferior): Likewise.
9965
9966 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
9967
9968         * i386-cygwin-tdep.c (core_process_module_section): Update.
9969         * windows-nat.c (struct lm_info_windows): Add text_offset.
9970         (windows_xfer_shared_libraries): Update.
9971         * windows-tdep.c (windows_xfer_shared_library):
9972         Add text_offset_cached argument.
9973         * windows-tdep.h (windows_xfer_shared_library): Update.
9974
9975 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
9976
9977         * gdbarch.sh: Add declaration for _initialize_gdbarch.
9978
9979 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
9980
9981         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
9982         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
9983         replace with range-based for.
9984         (gdbsim_interrupt_inferior): Remove.
9985         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
9986         with a range-based for.  Inline code from
9987         gdbsim_interrupt_inferior.
9988
9989 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
9990
9991         * infrun.c (proceed): Fix indentation.
9992
9993 2020-01-21  Tom Tromey  <tromey@adacore.com>
9994
9995         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
9996         * python/python.c (python_extension_ops): Update.
9997         (gdbpy_colorize): New function.
9998         * python/lib/gdb/__init__.py (colorize): New function.
9999         * extension.h (ext_lang_colorize): Declare.
10000         * extension.c (ext_lang_colorize): New function.
10001         * extension-priv.h (struct extension_language_ops) <colorize>: New
10002         member.
10003         * cli/cli-style.c (_initialize_cli_style): Update help text.
10004
10005 2020-01-21  Luis Machado  <luis.machado@linaro.org>
10006
10007         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
10008         <cond>: Change type to bool.
10009         (aarch64_displaced_step_b_cond): Update cond to use bool type.
10010         (aarch64_displaced_step_cb): Likewise.
10011         (aarch64_displaced_step_tb): Likewise.
10012
10013 2020-01-21  Luis Machado  <luis.machado@linaro.org>
10014
10015         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
10016         output.
10017
10018 2020-01-21  Luis Machado  <luis.machado@linaro.org>
10019
10020         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
10021         <pc_adjust>: Adjust the documentation.
10022         (aarch64_displaced_step_fixup): Check if PC really moved before
10023         adjusting it.
10024
10025 2020-01-19  Tom Tromey  <tom@tromey.com>
10026
10027         * disasm.c (~gdb_disassembler): New destructor.
10028         (gdb_buffered_insn_length): Call disassemble_free_target.
10029         * disasm.h (class gdb_disassembler): Declare destructor.  Use
10030         DISABLE_COPY_AND_ASSIGN.
10031
10032 2020-01-19  Tom Tromey  <tom@tromey.com>
10033
10034         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
10035         (die_reader_func_ftype): Remove.
10036         (cutu_reader): New class.
10037         (dw2_get_file_names_reader): Remove "data" parameter.
10038         (dw2_get_file_names): Use cutu_reader.
10039         (create_debug_type_hash_table): Update.
10040         (read_cutu_die_from_dwo): Update comment.
10041         (lookup_dwo_unit): Add dwo_name parameter.
10042         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
10043         die_reader_func_ftype and data parameters.
10044         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
10045         Remove die_reader_func_ftype and data parameters.
10046         (~cutu_reader): New; from init_cutu_and_read_dies.
10047         (cutu_reader::cutu_reader): Rename from
10048         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
10049         and data parameters.
10050         (init_cutu_and_read_dies_simple): Remove.
10051         (struct process_psymtab_comp_unit_data): Remove.
10052         (process_psymtab_comp_unit_reader): Remove data parameter; add
10053         want_partial_unit and pretend_language parameters.
10054         (process_psymtab_comp_unit): Use cutu_reader.
10055         (build_type_psymtabs_reader): Remove data parameter.
10056         (build_type_psymtabs_1): Use cutu_reader.
10057         (process_skeletonless_type_unit): Likewise.
10058         (load_partial_comp_unit_reader): Remove.
10059         (load_partial_comp_unit): Use cutu_reader.
10060         (load_full_comp_unit_reader): Remove.
10061         (load_full_comp_unit): Use cutu_reader.
10062         (struct create_dwo_cu_data): Remove.
10063         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
10064         dwo_unit parameters.
10065         (create_cus_hash_table): Use cutu_reader.
10066         (struct dwarf2_read_addr_index_data): Remove.
10067         (dwarf2_read_addr_index_reader): Remove.
10068         (dwarf2_read_addr_index): Use cutu_reader.
10069         (read_signatured_type_reader): Remove.
10070         (read_signatured_type): Use cutu_reader.
10071
10072 2020-01-19  Tom Tromey  <tom@tromey.com>
10073
10074         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
10075         * tui/tui-wingeneral.h (class tui_suppress_output): New.
10076         (tui_wrefresh): Declare.
10077         * tui/tui-wingeneral.c (suppress_output): New global.
10078         (tui_suppress_output, ~tui_suppress_output): New constructor and
10079         destructor.
10080         (tui_wrefresh): New function.
10081         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
10082         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
10083         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
10084         method.
10085         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
10086         tui_wrefresh.
10087         (tui_data_window::no_refresh): New method.
10088         (tui_data_item_window::refresh_window): Call tui_wrefresh.
10089         (tui_reg_command): Use tui_suppress_output
10090         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
10091         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
10092         method.
10093         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
10094
10095 2020-01-19  Tom Tromey  <tom@tromey.com>
10096
10097         * tui/tui-winsource.c (tui_update_source_windows_with_line):
10098         Handle case where symtab is null.
10099
10100 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
10101
10102         * linux-fork.c (one_fork_p): Simplify.
10103
10104 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10105
10106         * top.c (struct qt_args): Remove.
10107         (kill_or_detach): Change return type to void, replace `void *`
10108         parameter with a proper one.
10109         (print_inferior_quit_action):  Likewise.
10110         (quit_confirm): Use range-based for loop to iterate over inferiors.
10111         (quit_force): Likewise.
10112
10113 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10114
10115         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
10116         `void *` parameter with proper parameters.
10117         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
10118         (print_one_inferior): Change return type to void, replace `void *`
10119         parameter with proper parameters.
10120         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
10121         inferiors.
10122         (get_other_inferior): Remove.
10123         (mi_cmd_remove_inferior): Use range-based loop to iterate over
10124         inferiors.
10125
10126 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10127
10128         * mi/mi-interp.c (report_initial_inferior): Remove.
10129         (mi_interp::init): Use range-based for to iterate over inferiors.
10130
10131 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
10132
10133         * python/py-inferior.c (build_inferior_list): Remove.
10134         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
10135
10136 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
10137
10138         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
10139         (btrace_stitch_trace): Likewise.
10140         * charset.c (intermediate_encoding): Likewise (vaild).
10141         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
10142         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
10143         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
10144
10145 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
10146
10147         * windows-tdep.c (windows_get_tlb_type):
10148         Add rtl_user_process_parameters type.
10149
10150 2020-01-16  Pedro Alves  <palves@redhat.com>
10151             Norbert Lange  <nolange79@gmail.com>
10152
10153         PR build/24805
10154         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
10155         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
10156         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
10157         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
10158         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
10159         (ps_plog): Redeclare exported functions with default visibility.
10160
10161 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
10162
10163         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
10164         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
10165
10166 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
10167
10168         * infcmd.c (post_create_inferior): Use get_thread_regcache
10169         instead of get_current_regcache.
10170
10171 2020-01-14  Tom Tromey  <tom@tromey.com>
10172
10173         PR symtab/12535:
10174         * python/python.c (gdbpy_decode_line): Treat empty string the same
10175         as no argument.
10176
10177 2020-01-14  Tom Tromey  <tom@tromey.com>
10178
10179         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
10180
10181 2020-01-14  Tom Tromey  <tom@tromey.com>
10182
10183         * nat/linux-btrace.c: Don't include <config.h>.
10184         * nat/linux-ptrace.c: Don't include <config.h>.
10185         * nat/x86-linux-dregs.c: Don't include <config.h>.
10186
10187 2020-01-14  Tom Tromey  <tom@tromey.com>
10188
10189         * configure: Rebuild.
10190         * configure.ac: Move many checks to ../gdbsupport/common.m4.
10191
10192 2020-01-14  Tom Tromey  <tom@tromey.com>
10193
10194         * nat/x86-linux-dregs.c: Include configh.h.
10195         * nat/linux-ptrace.c: Include configh.h.
10196         * nat/linux-btrace.c: Include configh.h.
10197         * defs.h: Include config.h, bfd.h.
10198         * configure.ac: Don't source common.host.
10199         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
10200         * configure: Rebuild.
10201         * acinclude.m4: Update path.
10202         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
10203         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
10204         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
10205         (CLIBS): Add LIBSUPPORT.
10206         (CDEPS): Likewise.
10207         (COMMON_SFILES): Remove gdbsupport files.
10208         (HFILES_NO_SRCDIR): Likewise.
10209         (stamp-version): Update path to create-version.sh.
10210         (ALLDEPFILES): Remove gdbsupport files.
10211
10212 2020-01-14  Tom Tromey  <tom@tromey.com>
10213
10214         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
10215         USE_WIN32API when needed.
10216         * configure.ac (USE_WIN32API): Don't define.
10217         (WIN32LIBS): Use WIN32APILIBS.
10218         * configure: Rebuild.
10219
10220 2020-01-14  Tom Tromey  <tom@tromey.com>
10221
10222         * configure: Rebuild.
10223         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
10224
10225 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
10226
10227         * skip.c (skip_function_command): Make skip w/o arguments use the
10228         name of the inlined function if pc is inside any inlined function.
10229
10230 2020-01-14  Luis Machado  <luis.machado@linaro.org>
10231
10232         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
10233         * infrun.c (resume_1): Likewise.
10234         (handle_inferior_event): Remove stale comment.
10235         * linux-nat.c (linux_nat_target::resume): Update comments.
10236         (save_stop_reason): Likewise.
10237         (linux_nat_filter_event): Likewise.
10238         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
10239
10240 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10241
10242         * elfread.c (record_minimal_symbol): Set section index to 0 for
10243         non-allocatable sections.
10244
10245
10246 2020-01-13  Ali Tamur <tamur@google.com>
10247
10248         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
10249         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
10250         to gdb::optional.  Update comments.
10251         (dwo_file): Update comments.
10252         (read_attribute): Update API to take an additional out parameter,
10253         need_reprocess.  This is used to mark attributes that need other
10254         attributes (e.g. str_offsets_base) for correct computation which may not
10255         have been read yet.
10256         (read_attribute_reprocess): New function declaration.
10257         (read_addr_index): Likewise.
10258         (read_dwo_str_index): Likewise.
10259         (read_stub_str_index): Likewise.
10260         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
10261         (lookup_addr_base): New function definition.
10262         (lookup_ranges_base): Likewise.
10263         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
10264         lookup_ranges_base.
10265         (init_cutu_and_read_dies): Update comments.
10266         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
10267         unit.  This is used to inherit parent's str_offsets_base and addr_base.
10268         Update comments.
10269         (init_cutu_and_read_dies_simple): Reflect API changes.
10270         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
10271         (create_cus_hash_table): Change API to take parent compile unit.
10272         Reflect API changes.
10273         (open_and_init_dwo_file): Reflect API changes.
10274         (dwarf2_get_pc_bounds): Update comments.
10275         (dwarf2_record_block_ranges): Likewise.
10276         (read_full_die_1): Change implementation to reprocess attributes that
10277         need str_offsets_base and addr_base.
10278         (partial_die_info::read): Likewise.
10279         (read_attribute_reprocess): New function definition.
10280         (read_attribute_value): Change API to take an additional out parameter,
10281         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
10282         when a non-dwo compile unit has index based attributes.
10283         (read_attribute): Reflect API changes.
10284         (read_addr_index_1): Reflect API changes.  Update comments.
10285         (dwarf2_read_addr_index_data): Reflect API changes.
10286         (dwarf2_read_addr_index): Likewise.
10287         (read_str_index): Change API and implementation.  This becomes a helper
10288         to be used by the new string index related methods.  Update error
10289         message and comments.
10290         (read_dwo_str_index): New function definition.
10291         (read_stub_str_index): Likewise.
10292         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
10293         * symfile.h (dwarf2_debug_sections): Likewise.
10294         * xcoffread.c (dwarf2_debug_sections): Likewise.
10295
10296 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
10297
10298         * gdbcore.h (struct core_fns) <core_read_registers>: Change
10299         core_reg_sect type to gdb_byte *.
10300         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
10301         * cris-tdep.c (fetch_core_registers): Likewise.
10302         * corelow.c (core_target::get_core_register_section): Change
10303         type of `contents` to gdb::byte_vector.
10304
10305 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10306
10307         * tui/tui-wingeneral.c (box_win): Position the title in the center
10308         of the border.
10309
10310 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
10311
10312         * corelow.c (core_target::get_core_register_section): Use
10313           std::vector instead of alloca.
10314
10315 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
10316
10317         * warning.m4: Add -Wmissing-declarations to build_warnings.
10318         * configure: Re-generate.
10319
10320 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
10321
10322         * python/python.c (init__gdb_module): Add declaration.
10323
10324 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
10325
10326         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
10327         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
10328         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
10329         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
10330         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
10331         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
10332         * ada-exp.y (_initialize_ada_exp): Add declaration.
10333         * ada-lang.c (_initialize_ada_language): Add declaration.
10334         * ada-tasks.c (_initialize_tasks): Add declaration.
10335         * agent.c (_initialize_agent): Add declaration.
10336         * aix-thread.c (_initialize_aix_thread): Add declaration.
10337         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
10338         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
10339         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
10340         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
10341         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
10342         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
10343         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
10344         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
10345         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
10346         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
10347         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
10348         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
10349         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
10350         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
10351         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
10352         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
10353         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
10354         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
10355         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
10356         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
10357         * annotate.c (_initialize_annotate): Add declaration.
10358         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
10359         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
10360         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
10361         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
10362         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
10363         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
10364         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
10365         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
10366         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
10367         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
10368         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
10369         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
10370         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
10371         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
10372         * auto-load.c (_initialize_auto_load): Add declaration.
10373         * auxv.c (_initialize_auxv): Add declaration.
10374         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
10375         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
10376         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
10377         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
10378         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
10379         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
10380         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
10381         * breakpoint.c (_initialize_breakpoint): Add declaration.
10382         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
10383         * btrace.c (_initialize_btrace): Add declaration.
10384         * charset.c (_initialize_charset): Add declaration.
10385         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
10386         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
10387         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
10388         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
10389         * cli/cli-script.c (_initialize_cli_script): Add declaration.
10390         * cli/cli-style.c (_initialize_cli_style): Add declaration.
10391         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
10392         * coffread.c (_initialize_coffread): Add declaration.
10393         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
10394         * compile/compile.c (_initialize_compile): Add declaration.
10395         * complaints.c (_initialize_complaints): Add declaration.
10396         * completer.c (_initialize_completer): Add declaration.
10397         * copying.c (_initialize_copying): Add declaration.
10398         * corefile.c (_initialize_core): Add declaration.
10399         * corelow.c (_initialize_corelow): Add declaration.
10400         * cp-abi.c (_initialize_cp_abi): Add declaration.
10401         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
10402         * cp-support.c (_initialize_cp_support): Add declaration.
10403         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
10404         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
10405         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
10406         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
10407         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
10408         * ctfread.c (_initialize_ctfread): Add declaration.
10409         * d-lang.c (_initialize_d_language): Add declaration.
10410         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
10411         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
10412         * dbxread.c (_initialize_dbxread): Add declaration.
10413         * dcache.c (_initialize_dcache): Add declaration.
10414         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
10415         * disasm.c (_initialize_disasm): Add declaration.
10416         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
10417         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
10418         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
10419         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
10420         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
10421         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
10422         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
10423         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
10424         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
10425         * elfread.c (_initialize_elfread): Add declaration.
10426         * exec.c (_initialize_exec): Add declaration.
10427         * extension.c (_initialize_extension): Add declaration.
10428         * f-lang.c (_initialize_f_language): Add declaration.
10429         * f-valprint.c (_initialize_f_valprint): Add declaration.
10430         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
10431         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
10432         * filesystem.c (_initialize_filesystem): Add declaration.
10433         * findcmd.c (_initialize_mem_search): Add declaration.
10434         * findvar.c (_initialize_findvar): Add declaration.
10435         * fork-child.c (_initialize_fork_child): Add declaration.
10436         * frame-base.c (_initialize_frame_base): Add declaration.
10437         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
10438         * frame.c (_initialize_frame): Add declaration.
10439         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
10440         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
10441         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
10442         * gcore.c (_initialize_gcore): Add declaration.
10443         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
10444         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
10445         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
10446         * gdbarch.c (_initialize_gdbarch): Add declaration.
10447         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
10448         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
10449         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
10450         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
10451         * go-lang.c (_initialize_go_language): Add declaration.
10452         * go32-nat.c (_initialize_go32_nat): Add declaration.
10453         * guile/guile.c (_initialize_guile): Add declaration.
10454         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
10455         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
10456         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
10457         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
10458         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
10459         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
10460         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
10461         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
10462         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
10463         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
10464         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
10465         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
10466         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
10467         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
10468         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
10469         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
10470         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
10471         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
10472         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
10473         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
10474         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
10475         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
10476         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
10477         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
10478         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
10479         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
10480         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
10481         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
10482         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
10483         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
10484         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
10485         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
10486         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
10487         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
10488         * infcall.c (_initialize_infcall): Add declaration.
10489         * infcmd.c (_initialize_infcmd): Add declaration.
10490         * inflow.c (_initialize_inflow): Add declaration.
10491         * infrun.c (_initialize_infrun): Add declaration.
10492         * interps.c (_initialize_interpreter): Add declaration.
10493         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
10494         * jit.c (_initialize_jit): Add declaration.
10495         * language.c (_initialize_language): Add declaration.
10496         * linux-fork.c (_initialize_linux_fork): Add declaration.
10497         * linux-nat.c (_initialize_linux_nat): Add declaration.
10498         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
10499         * linux-thread-db.c (_initialize_thread_db): Add declaration.
10500         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
10501         * m2-lang.c (_initialize_m2_language): Add declaration.
10502         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
10503         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
10504         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
10505         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
10506         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
10507         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
10508         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
10509         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
10510         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
10511         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
10512         * machoread.c (_initialize_machoread): Add declaration.
10513         * macrocmd.c (_initialize_macrocmd): Add declaration.
10514         * macroscope.c (_initialize_macroscope): Add declaration.
10515         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
10516         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
10517         * maint.c (_initialize_maint_cmds): Add declaration.
10518         * mdebugread.c (_initialize_mdebugread): Add declaration.
10519         * memattr.c (_initialize_mem): Add declaration.
10520         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
10521         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
10522         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
10523         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
10524         * mi/mi-main.c (_initialize_mi_main): Add declaration.
10525         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
10526         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
10527         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
10528         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
10529         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
10530         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
10531         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
10532         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
10533         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
10534         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
10535         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
10536         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
10537         * mipsread.c (_initialize_mipsread): Add declaration.
10538         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
10539         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
10540         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
10541         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
10542         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
10543         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
10544         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
10545         * nto-procfs.c (_initialize_procfs): Add declaration.
10546         * objc-lang.c (_initialize_objc_language): Add declaration.
10547         * observable.c (_initialize_observer): Add declaration.
10548         * opencl-lang.c (_initialize_opencl_language): Add declaration.
10549         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
10550         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
10551         * osabi.c (_initialize_gdb_osabi): Add declaration.
10552         * osdata.c (_initialize_osdata): Add declaration.
10553         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
10554         * parse.c (_initialize_parse): Add declaration.
10555         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
10556         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
10557         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
10558         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
10559         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
10560         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
10561         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
10562         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
10563         * printcmd.c (_initialize_printcmd): Add declaration.
10564         * probe.c (_initialize_probe): Add declaration.
10565         * proc-api.c (_initialize_proc_api): Add declaration.
10566         * proc-events.c (_initialize_proc_events): Add declaration.
10567         * proc-service.c (_initialize_proc_service): Add declaration.
10568         * procfs.c (_initialize_procfs): Add declaration.
10569         * producer.c (_initialize_producer): Add declaration.
10570         * psymtab.c (_initialize_psymtab): Add declaration.
10571         * python/python.c (_initialize_python): Add declaration.
10572         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
10573         * record-btrace.c (_initialize_record_btrace): Add declaration.
10574         * record-full.c (_initialize_record_full): Add declaration.
10575         * record.c (_initialize_record): Add declaration.
10576         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
10577         * regcache.c (_initialize_regcache): Add declaration.
10578         * reggroups.c (_initialize_reggroup): Add declaration.
10579         * remote-notif.c (_initialize_notif): Add declaration.
10580         * remote-sim.c (_initialize_remote_sim): Add declaration.
10581         * remote.c (_initialize_remote): Add declaration.
10582         * reverse.c (_initialize_reverse): Add declaration.
10583         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
10584         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
10585         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
10586         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
10587         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
10588         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
10589         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
10590         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
10591         Add declaration.
10592         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
10593         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
10594         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
10595         * rust-exp.y (_initialize_rust_exp): Add declaration.
10596         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
10597         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
10598         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
10599         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
10600         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
10601         * score-tdep.c (_initialize_score_tdep): Add declaration.
10602         * ser-go32.c (_initialize_ser_dos): Add declaration.
10603         * ser-mingw.c (_initialize_ser_windows): Add declaration.
10604         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
10605         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
10606         * ser-uds.c (_initialize_ser_socket): Add declaration.
10607         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
10608         * serial.c (_initialize_serial): Add declaration.
10609         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
10610         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
10611         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
10612         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
10613         * skip.c (_initialize_step_skip): Add declaration.
10614         * sol-thread.c (_initialize_sol_thread): Add declaration.
10615         * solib-aix.c (_initialize_solib_aix): Add declaration.
10616         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
10617         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
10618         * solib-frv.c (_initialize_frv_solib): Add declaration.
10619         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
10620         * solib-target.c (_initialize_solib_target): Add declaration.
10621         * solib.c (_initialize_solib): Add declaration.
10622         * source-cache.c (_initialize_source_cache): Add declaration.
10623         * source.c (_initialize_source): Add declaration.
10624         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
10625         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
10626         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
10627         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
10628         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
10629         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
10630         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
10631         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
10632         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
10633         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
10634         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
10635         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
10636         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
10637         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
10638         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
10639         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
10640         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
10641         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
10642         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
10643         * stabsread.c (_initialize_stabsread): Add declaration.
10644         * stack.c (_initialize_stack): Add declaration.
10645         * stap-probe.c (_initialize_stap_probe): Add declaration.
10646         * std-regs.c (_initialize_frame_reg): Add declaration.
10647         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
10648         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
10649         * symfile.c (_initialize_symfile): Add declaration.
10650         * symmisc.c (_initialize_symmisc): Add declaration.
10651         * symtab.c (_initialize_symtab): Add declaration.
10652         * target.c (_initialize_target): Add declaration.
10653         * target-connection.c (_initialize_target_connection): Add
10654         declaration.
10655         * target-dcache.c (_initialize_target_dcache): Add declaration.
10656         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
10657         * thread.c (_initialize_thread): Add declaration.
10658         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
10659         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
10660         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
10661         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
10662         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
10663         * tracectf.c (_initialize_ctf): Add declaration.
10664         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
10665         * tracefile.c (_initialize_tracefile): Add declaration.
10666         * tracepoint.c (_initialize_tracepoint): Add declaration.
10667         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
10668         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
10669         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
10670         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
10671         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
10672         * tui/tui-win.c (_initialize_tui_win): Add declaration.
10673         * tui/tui.c (_initialize_tui): Add declaration.
10674         * typeprint.c (_initialize_typeprint): Add declaration.
10675         * ui-style.c (_initialize_ui_style): Add declaration.
10676         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
10677         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
10678         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
10679         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
10680         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
10681         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
10682         * unittests/filtered_iterator-selftests.c
10683         (_initialize_filtered_iterator_selftests): Add declaration.
10684         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
10685         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
10686         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
10687         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
10688         * unittests/main-thread-selftests.c
10689         (_initialize_main_thread_selftests): Add declaration.
10690         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
10691         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
10692         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
10693         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
10694         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
10695         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
10696         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
10697         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
10698         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
10699         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
10700         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
10701         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
10702         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
10703         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
10704         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
10705         declaration.
10706         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
10707         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
10708         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
10709         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
10710         * user-regs.c (_initialize_user_regs): Add declaration.
10711         * utils.c (_initialize_utils): Add declaration.
10712         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
10713         * valops.c (_initialize_valops): Add declaration.
10714         * valprint.c (_initialize_valprint): Add declaration.
10715         * value.c (_initialize_values): Add declaration.
10716         * varobj.c (_initialize_varobj): Add declaration.
10717         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
10718         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
10719         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
10720         * windows-nat.c (_initialize_windows_nat): Add declaration.
10721         (_initialize_check_for_gdb_ini): Add declaration.
10722         (_initialize_loadable): Add declaration.
10723         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
10724         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
10725         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
10726         * xcoffread.c (_initialize_xcoffread): Add declaration.
10727         * xml-support.c (_initialize_xml_support): Add declaration.
10728         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
10729         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
10730         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
10731         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
10732
10733 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
10734
10735         * regformats/regdat.sh: Generate declaration for init function.
10736
10737 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
10738
10739         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
10740         up.
10741         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
10742         close_one_inferior>: New methods.
10743         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
10744         pass down target to find_inferior_pid.
10745         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
10746         Pass down target to find_inferior_ptid.
10747         (gdbsim_target::create_inferior): Pass down target to
10748         add_thread_silent.
10749         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
10750         target down to find_inferior_ptid and switch_to_thread.
10751         (gdbsim_target::close): Update to call close_one_inferior.
10752         (struct resume_data): Remove.
10753         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
10754         directly, rather than through a void pointer.
10755         (gdbsim_target::resume): Update to call resume_one_inferior.
10756
10757 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
10758
10759         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
10760
10761 2020-01-12  Pedro Alves  <palves@redhat.com>
10762
10763         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
10764         directly for the current inferior instead of
10765         discard_all_inferiors.
10766         (discard_all_inferiors): Delete.
10767
10768 2020-01-11  Tom Tromey  <tom@tromey.com>
10769
10770         * tui/tui-wingeneral.c (box_win): Check cli_styling.
10771         * tui/tui-winsource.c (tui_source_window_base::refill): Use
10772         deprecated_safe_get_selected_frame.
10773
10774 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
10775
10776         * inferior.c (print_inferior): Switch inferior before printing it.
10777
10778 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
10779             Pedro Alves  <palves@redhat.com>
10780
10781         * progspace-and-thread.c (switch_to_program_space_and_thread):
10782         Assert there's an inferior for PSPACE.  Use
10783         switch_to_inferior_no_thread to switch the inferior too.
10784         * progspace.c (program_space::~program_space): Call
10785         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
10786         (program_space::free_all_objfiles): Don't call clear_symtab_users
10787         here.
10788         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
10789
10790 2020-01-10  Pedro Alves  <palves@redhat.com>
10791
10792         * NEWS: Mention multi-target debugging, "info connections", and
10793         "add-inferior -no-connection".
10794
10795 2020-01-10  Pedro Alves  <palves@redhat.com>
10796
10797         * infrun.c: Include "target-connection.h".
10798         (check_multi_target_resumption): New.
10799         (proceed): Call it.
10800         * target-connection.c (make_target_connection_string): Make
10801         extern.
10802         * target-connection.h (make_target_connection_string): Declare.
10803
10804 2020-01-10  Pedro Alves  <palves@redhat.com>
10805
10806         * Makefile.in (COMMON_SFILES): Add target-connection.c.
10807         * inferior.c (uiout_field_connection): New function.
10808         (print_inferior): Add new "connection-id" column.
10809         (add_inferior_command): Show connection number/string of added
10810         inferior.
10811         * process-stratum-target.h
10812         (process_stratum_target::connection_string): New virtual method.
10813         (process_stratum_target::connection_number): New field.
10814         * remote.c (remote_target::connection_string): New override.
10815         * target-connection.c: New file.
10816         * target-connection.h: New file.
10817         * target.c (decref_target): Remove process_stratum targets from
10818         the connection list.
10819         (target_stack::push): Add process_stratum targets to the
10820         connection list.
10821
10822 2020-01-10  Pedro Alves  <palves@redhat.com>
10823
10824         Revert:
10825         2016-04-12  Pedro Alves  <palves@redhat.com>
10826         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
10827         Remove references to name.
10828         * serial.h (struct serial) <name>: Delete.
10829
10830 2020-01-10  Pedro Alves  <palves@redhat.com>
10831
10832         * gdbarch-selftests.c (register_to_value_test): Remove "target
10833         already pushed" check.
10834
10835 2020-01-10  Pedro Alves  <palves@redhat.com>
10836             John Baldwin  <jhb@FreeBSD.org>
10837
10838         * aarch64-linux-nat.c
10839         (aarch64_linux_nat_target::thread_architecture): Adjust.
10840         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
10841         (task_command_1): Likewise.
10842         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
10843         (aix_thread_target::wait, aix_thread_target::fetch_registers)
10844         (aix_thread_target::store_registers)
10845         (aix_thread_target::thread_alive): Adjust.
10846         * amd64-fbsd-tdep.c: Include "inferior.h".
10847         (amd64fbsd_get_thread_local_address): Pass down target.
10848         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
10849         thread's gdbarch instead of target_gdbarch.
10850         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
10851         get_last_target_status.
10852         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
10853         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
10854         inferiors.
10855         (update_inserted_breakpoint_locations): Skip if inferiors with no
10856         execution.
10857         (update_global_location_list): When handling moribund locations,
10858         find representative inferior for location's pspace, and use thread
10859         count of its process_stratum target.
10860         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
10861         * bsd-uthread.c (bsd_uthread_target::wait): Use
10862         as_process_stratum_target and adjust thread_change_ptid and
10863         add_thread calls.
10864         (bsd_uthread_target::update_thread_list): Use
10865         as_process_stratum_target and adjust find_thread_ptid,
10866         thread_change_ptid and add_thread calls.
10867         * btrace.c (maint_btrace_packet_history_cmd): Adjust
10868         find_thread_ptid call.
10869         * corelow.c (add_to_thread_list): Adjust add_thread call.
10870         (core_target_open): Adjust add_thread_silent and thread_count
10871         calls.
10872         (core_target::pid_to_str): Adjust find_inferior_ptid call.
10873         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
10874         * event-top.c (async_disconnect): Pop targets from all inferiors.
10875         * exec.c (add_target_sections): Push exec target on all inferiors
10876         sharing the program space.
10877         (remove_target_sections): Remove the exec target from all
10878         inferiors sharing the program space.
10879         (exec_on_vfork): New.
10880         * exec.h (exec_on_vfork): Declare.
10881         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
10882         Pass it down.
10883         (fbsd_nat_target::update_thread_list): Adjust.
10884         (fbsd_nat_target::resume): Adjust.
10885         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
10886         down.
10887         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
10888         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
10889         get_thread_arch_regcache call.
10890         * fork-child.c (gdb_startup_inferior): Pass target down to
10891         startup_inferior and set_executing.
10892         * gdbthread.h (struct process_stratum_target): Forward declare.
10893         (add_thread, add_thread_silent, add_thread_with_info)
10894         (in_thread_list): Add process_stratum_target parameter.
10895         (find_thread_ptid(inferior*, ptid_t)): New overload.
10896         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
10897         parameter.
10898         (all_threads()): Delete overload.
10899         (all_threads, all_non_exited_threads): Add process_stratum_target
10900         parameter.
10901         (all_threads_safe): Use brace initialization.
10902         (thread_count): Add process_stratum_target parameter.
10903         (set_resumed, set_running, set_stop_requested, set_executing)
10904         (threads_are_executing, finish_thread_state): Add
10905         process_stratum_target parameter.
10906         (switch_to_thread): Use is_current_thread.
10907         * i386-fbsd-tdep.c: Include "inferior.h".
10908         (i386fbsd_get_thread_local_address): Pass down target.
10909         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
10910         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
10911         have_inferiors check.
10912         * inf-ptrace.c (inf_ptrace_target::create_inferior)
10913         (inf_ptrace_target::attach): Adjust.
10914         * infcall.c (run_inferior_call): Adjust.
10915         * infcmd.c (run_command_1): Pass target to
10916         scoped_finish_thread_state.
10917         (proceed_thread_callback): Skip inferiors with no execution.
10918         (continue_command): Rename 'all_threads' local to avoid hiding
10919         'all_threads' function.  Adjust get_last_target_status call.
10920         (prepare_one_step): Adjust set_running call.
10921         (signal_command): Use user_visible_resume_target.  Compare thread
10922         pointers instead of inferior_ptid.
10923         (info_program_command): Adjust to pass down target.
10924         (attach_command): Mark target's 'thread_executing' flag.
10925         (stop_current_target_threads_ns): New, factored out from ...
10926         (interrupt_target_1): ... this.  Switch inferior before making
10927         target calls.
10928         * inferior-iter.h
10929         (struct all_inferiors_iterator, struct all_inferiors_range)
10930         (struct all_inferiors_safe_range)
10931         (struct all_non_exited_inferiors_range): Filter on
10932         process_stratum_target too.  Remove explicit.
10933         * inferior.c (inferior::inferior): Push dummy target on target
10934         stack.
10935         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
10936         Add process_stratum_target parameter, and pass it down.
10937         (have_live_inferiors): Adjust.
10938         (switch_to_inferior_and_push_target): New.
10939         (add_inferior_command, clone_inferior_command): Handle
10940         "-no-connection" parameter.  Use
10941         switch_to_inferior_and_push_target.
10942         (_initialize_inferior): Mention "-no-connection" option in
10943         the help of "add-inferior" and "clone-inferior" commands.
10944         * inferior.h: Include "process-stratum-target.h".
10945         (interrupt_target_1): Use bool.
10946         (struct inferior) <push_target, unpush_target, target_is_pushed,
10947         find_target_beneath, top_target, process_target, target_at,
10948         m_stack>: New.
10949         (discard_all_inferiors): Delete.
10950         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
10951         (all_inferiors, all_non_exited_inferiors): Add
10952         process_stratum_target parameter.
10953         * infrun.c: Include "gdb_select.h" and <unordered_map>.
10954         (target_last_proc_target): New global.
10955         (follow_fork_inferior): Push target on new inferior.  Pass target
10956         to add_thread_silent.  Call exec_on_vfork.  Handle target's
10957         reference count.
10958         (follow_fork): Adjust get_last_target_status call.  Also consider
10959         target.
10960         (follow_exec): Push target on new inferior.
10961         (struct execution_control_state) <target>: New field.
10962         (user_visible_resume_target): New.
10963         (do_target_resume): Call target_async.
10964         (resume_1): Set target's threads_executing flag.  Consider resume
10965         target.
10966         (commit_resume_all_targets): New.
10967         (proceed): Also consider resume target.  Skip threads of inferiors
10968         with no execution.  Commit resumtion in all targets.
10969         (start_remote): Pass current inferior to wait_for_inferior.
10970         (infrun_thread_stop_requested): Consider target as well.  Pass
10971         thread_info pointer to clear_inline_frame_state instead of ptid.
10972         (infrun_thread_thread_exit): Consider target as well.
10973         (random_pending_event_thread): New inferior parameter.  Use it.
10974         (do_target_wait): Rename to ...
10975         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
10976         down.
10977         (threads_are_resumed_pending_p, do_target_wait): New.
10978         (prepare_for_detach): Adjust calls.
10979         (wait_for_inferior): New inferior parameter.  Handle it.  Use
10980         do_target_wait_1 instead of do_target_wait.
10981         (fetch_inferior_event): Adjust.  Switch to representative
10982         inferior.  Pass target down.
10983         (set_last_target_status): Add process_stratum_target parameter.
10984         Save target in global.
10985         (get_last_target_status): Add process_stratum_target parameter and
10986         handle it.
10987         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
10988         (context_switch): Check inferior_ptid == null_ptid before calling
10989         inferior_thread().
10990         (get_inferior_stop_soon): Pass down target.
10991         (wait_one): Rename to ...
10992         (poll_one_curr_target): ... this.
10993         (struct wait_one_event): New.
10994         (wait_one): New.
10995         (stop_all_threads): Adjust.
10996         (handle_no_resumed, handle_inferior_event): Adjust to consider the
10997         event's target.
10998         (switch_back_to_stepped_thread): Also consider target.
10999         (print_stop_event): Update.
11000         (normal_stop): Update.  Also consider the resume target.
11001         * infrun.h (wait_for_inferior): Remove declaration.
11002         (user_visible_resume_target): New declaration.
11003         (get_last_target_status, set_last_target_status): New
11004         process_stratum_target parameter.
11005         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
11006         process_stratum_target parameter, and use it.
11007         (clear_inline_frame_state (thread_info*)): New.
11008         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
11009         process_stratum_target parameter.
11010         (clear_inline_frame_state (thread_info*)): Declare.
11011         * linux-fork.c (delete_checkpoint_command): Pass target down to
11012         find_thread_ptid.
11013         (checkpoint_command): Adjust.
11014         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
11015         instead of just tweaking inferior_ptid.
11016         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
11017         (exit_lwp): Pass target down to find_thread_ptid.
11018         (attach_proc_task_lwp_callback): Pass target down to
11019         add_thread/set_running/set_executing.
11020         (linux_nat_target::attach): Pass target down to
11021         thread_change_ptid.
11022         (get_detach_signal): Pass target down to find_thread_ptid.
11023         Consider last target status's target.
11024         (linux_resume_one_lwp_throw, resume_lwp)
11025         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
11026         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
11027         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
11028         (linux_nat_target::async_wait_fd): New.
11029         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
11030         target down.
11031         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
11032         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
11033         * linux-thread-db.c (struct thread_db_info::process_target): New
11034         field.
11035         (add_thread_db_info): Save target.
11036         (get_thread_db_info): New process_stratum_target parameter.  Also
11037         match target.
11038         (delete_thread_db_info): New process_stratum_target parameter.
11039         Also match target.
11040         (thread_from_lwp): Adjust to pass down target.
11041         (thread_db_notice_clone): Pass down target.
11042         (check_thread_db_callback): Pass down target.
11043         (try_thread_db_load_1): Always push the thread_db target.
11044         (try_thread_db_load, record_thread): Pass target down.
11045         (thread_db_target::detach): Pass target down.  Always unpush the
11046         thread_db target.
11047         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
11048         target down.  Always unpush the thread_db target.
11049         (find_new_threads_callback, thread_db_find_new_threads_2)
11050         (thread_db_target::update_thread_list): Pass target down.
11051         (thread_db_target::pid_to_str): Pass current inferior down.
11052         (thread_db_target::get_thread_local_address): Pass target down.
11053         (thread_db_target::resume, maintenance_check_libthread_db): Pass
11054         target down.
11055         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
11056         * procfs.c (procfs_target::procfs_init_inferior): Declare.
11057         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
11058         (procfs_init_inferior): Rename to ...
11059         (procfs_target::procfs_init_inferior): ... this and adjust.
11060         (procfs_target::create_inferior, procfs_notice_thread)
11061         (procfs_do_thread_registers): Adjust.
11062         * ppc-fbsd-tdep.c: Include "inferior.h".
11063         (ppcfbsd_get_thread_local_address): Pass down target.
11064         * proc-service.c (ps_xfer_memory): Switch current inferior and
11065         program space as well.
11066         (get_ps_regcache): Pass target down.
11067         * process-stratum-target.c
11068         (process_stratum_target::thread_address_space)
11069         (process_stratum_target::thread_architecture): Pass target down.
11070         * process-stratum-target.h
11071         (process_stratum_target::threads_executing): New field.
11072         (as_process_stratum_target): New.
11073         * ravenscar-thread.c
11074         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
11075         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
11076         down.
11077         * record-btrace.c (record_btrace_target::info_record): Adjust.
11078         (record_btrace_target::record_method)
11079         (record_btrace_target::record_is_replaying)
11080         (record_btrace_target::fetch_registers)
11081         (get_thread_current_frame_id, record_btrace_target::resume)
11082         (record_btrace_target::wait, record_btrace_target::stop): Pass
11083         target down.
11084         * record-full.c (record_full_wait_1): Switch to event thread.
11085         Pass target down.
11086         * regcache.c (regcache::regcache)
11087         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
11088         process_stratum_target parameter and handle it.
11089         (current_thread_target): New global.
11090         (get_thread_regcache): Add process_stratum_target parameter and
11091         handle it.  Switch inferior before calling target method.
11092         (get_thread_regcache): Pass target down.
11093         (get_thread_regcache_for_ptid): Pass target down.
11094         (registers_changed_ptid): Add process_stratum_target parameter and
11095         handle it.
11096         (registers_changed_thread, registers_changed): Pass target down.
11097         (test_get_thread_arch_aspace_regcache): New.
11098         (current_regcache_test): Define a couple local test_target_ops
11099         instances and use them for testing.
11100         (readwrite_regcache): Pass process_stratum_target parameter.
11101         (cooked_read_test, cooked_write_test): Pass mock_target down.
11102         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
11103         (get_thread_arch_aspace_regcache): Add process_stratum_target
11104         parameter.
11105         (regcache::target): New method.
11106         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
11107         (regcache::registers_changed_ptid): Add process_stratum_target
11108         parameter.
11109         (regcache::m_target): New field.
11110         (registers_changed_ptid): Add process_stratum_target parameter.
11111         * remote.c (remote_state::supports_vCont_probed): New field.
11112         (remote_target::async_wait_fd): New method.
11113         (remote_unpush_and_throw): Add remote_target parameter.
11114         (get_current_remote_target): Adjust.
11115         (remote_target::remote_add_inferior): Push target.
11116         (remote_target::remote_add_thread)
11117         (remote_target::remote_notice_new_inferior)
11118         (get_remote_thread_info): Pass target down.
11119         (remote_target::update_thread_list): Skip threads of inferiors
11120         bound to other targets.  (remote_target::close): Don't discard
11121         inferiors.  (remote_target::add_current_inferior_and_thread)
11122         (remote_target::process_initial_stop_replies)
11123         (remote_target::start_remote)
11124         (remote_target::remote_serial_quit_handler): Pass down target.
11125         (remote_target::remote_unpush_target): New remote_target
11126         parameter.  Unpush the target from all inferiors.
11127         (remote_target::remote_unpush_and_throw): New remote_target
11128         parameter.  Pass it down.
11129         (remote_target::open_1): Check whether the current inferior has
11130         execution instead of checking whether any inferior is live.  Pass
11131         target down.
11132         (remote_target::remote_detach_1): Pass down target.  Use
11133         remote_unpush_target.
11134         (extended_remote_target::attach): Pass down target.
11135         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
11136         (remote_target::append_resumption): Pass down target.
11137         (remote_target::append_pending_thread_resumptions)
11138         (remote_target::remote_resume_with_hc, remote_target::resume)
11139         (remote_target::commit_resume): Pass down target.
11140         (remote_target::remote_stop_ns): Check supports_vCont_probed.
11141         (remote_target::interrupt_query)
11142         (remote_target::remove_new_fork_children)
11143         (remote_target::check_pending_events_prevent_wildcard_vcont)
11144         (remote_target::remote_parse_stop_reply)
11145         (remote_target::process_stop_reply): Pass down target.
11146         (first_remote_resumed_thread): New remote_target parameter.  Pass
11147         it down.
11148         (remote_target::wait_as): Pass down target.
11149         (unpush_and_perror): New remote_target parameter.  Pass it down.
11150         (remote_target::readchar, remote_target::remote_serial_write)
11151         (remote_target::getpkt_or_notif_sane_1)
11152         (remote_target::kill_new_fork_children, remote_target::kill): Pass
11153         down target.
11154         (remote_target::mourn_inferior): Pass down target.  Use
11155         remote_unpush_target.
11156         (remote_target::core_of_thread)
11157         (remote_target::remote_btrace_maybe_reopen): Pass down target.
11158         (remote_target::pid_to_exec_file)
11159         (remote_target::thread_handle_to_thread_info): Pass down target.
11160         (remote_target::async_wait_fd): New.
11161         * riscv-fbsd-tdep.c: Include "inferior.h".
11162         (riscv_fbsd_get_thread_local_address): Pass down target.
11163         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
11164         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
11165         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
11166         Adjust.
11167         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
11168         * solib-svr4.c (enable_break): Pass down target.
11169         * spu-multiarch.c (parse_spufs_run): Pass down target.
11170         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
11171         * target-delegates.c: Regenerate.
11172         * target.c (g_target_stack): Delete.
11173         (current_top_target): Return the current inferior's top target.
11174         (target_has_execution_1): Refer to the passed-in inferior's top
11175         target.
11176         (target_supports_terminal_ours): Check whether the initial
11177         inferior was already created.
11178         (decref_target): New.
11179         (target_stack::push): Incref/decref the target.
11180         (push_target, push_target, unpush_target): Adjust.
11181         (target_stack::unpush): Defref target.
11182         (target_is_pushed): Return bool.  Adjust to refer to the current
11183         inferior's target stack.
11184         (dispose_inferior): Delete, and inline parts ...
11185         (target_preopen): ... here.  Only dispose of the current inferior.
11186         (target_detach): Hold strong target reference while detaching.
11187         Pass target down.
11188         (target_thread_name): Add assertion.
11189         (target_resume): Pass down target.
11190         (target_ops::beneath, find_target_at): Adjust to refer to the
11191         current inferior's target stack.
11192         (get_dummy_target): New.
11193         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
11194         has a thread running.
11195         (initialize_targets): Rename to ...
11196         (_initialize_target): ... this.
11197         * target.h: Include "gdbsupport/refcounted-object.h".
11198         (struct target_ops): Inherit refcounted_object.
11199         (target_ops::shortname, target_ops::longname): Make const.
11200         (target_ops::async_wait_fd): New method.
11201         (decref_target): Declare.
11202         (struct target_ops_ref_policy): New.
11203         (target_ops_ref): New typedef.
11204         (get_dummy_target): Declare function.
11205         (target_is_pushed): Return bool.
11206         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
11207         (all_matching_threads_iterator::all_matching_threads_iterator):
11208         Handle filter target.
11209         * thread-iter.h (struct all_matching_threads_iterator, struct
11210         all_matching_threads_range, class all_non_exited_threads_range):
11211         Filter by target too.  Remove explicit.
11212         * thread.c (threads_executing): Delete.
11213         (inferior_thread): Pass down current inferior.
11214         (clear_thread_inferior_resources): Pass down thread pointer
11215         instead of ptid_t.
11216         (add_thread_silent, add_thread_with_info, add_thread): Add
11217         process_stratum_target parameter.  Use it for thread and inferior
11218         searches.
11219         (is_current_thread): New.
11220         (thread_info::deletable): Use it.
11221         (find_thread_ptid, thread_count, in_thread_list)
11222         (thread_change_ptid, set_resumed, set_running): New
11223         process_stratum_target parameter.  Pass it down.
11224         (set_executing): New process_stratum_target parameter.  Pass it
11225         down.  Adjust reference to 'threads_executing'.
11226         (threads_are_executing): New process_stratum_target parameter.
11227         Adjust reference to 'threads_executing'.
11228         (set_stop_requested, finish_thread_state): New
11229         process_stratum_target parameter.  Pass it down.
11230         (switch_to_thread): Also match inferior.
11231         (switch_to_thread): New process_stratum_target parameter.  Pass it
11232         down.
11233         (update_threads_executing): Reimplement.
11234         * top.c (quit_force): Pop targets from all inferior.
11235         (gdb_init): Don't call initialize_targets.
11236         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
11237         Declare.
11238         (windows_add_thread, windows_delete_thread): Adjust.
11239         (get_windows_debug_event): Rename to ...
11240         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
11241         * tracefile-tfile.c (tfile_target_open): Pass down target.
11242         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
11243         Forward declare.
11244         (switch_to_thread): Add process_stratum_target parameter.
11245         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
11246         parameter.  Use it.
11247         (mi_on_resume): Pass target down.
11248         * nat/fork-inferior.c (startup_inferior): Add
11249         process_stratum_target parameter.  Pass it down.
11250         * nat/fork-inferior.h (startup_inferior): Add
11251         process_stratum_target parameter.
11252         * python/py-threadevent.c (py_get_event_thread): Pass target down.
11253
11254 2020-01-10  Pedro Alves  <palves@redhat.com>
11255
11256         * remote.c (remote_target::start_remote): Don't set inferior_ptid
11257         directly.  Instead find the first thread in the thread list and
11258         use switch_to_thread.
11259
11260 2020-01-10  Pedro Alves  <palves@redhat.com>
11261
11262         * remote.c (remote_target::remote_add_inferior): Don't bind a
11263         process to the current inferior if the current inferior is already
11264         bound to a process.
11265
11266 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
11267             Pedro Alves  <palves@redhat.com>
11268
11269         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
11270         If no process is specified, return null_ptid instead of
11271         inferior_ptid.
11272         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
11273         TARGET_WAITKIND_SIGNALLED with no pid.
11274
11275 2020-01-10  Pedro Alves  <palves@redhat.com>
11276
11277         * remote.c (first_remote_resumed_thread): New.
11278         (remote_target::wait_as): Use it as default event_ptid instead of
11279         inferior_ptid.
11280
11281 2020-01-10  Pedro Alves  <palves@redhat.com>
11282
11283         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
11284
11285 2020-01-10  Pedro Alves  <palves@redhat.com>
11286
11287         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
11288         not -1.
11289
11290 2020-01-10  Pedro Alves  <palves@redhat.com>
11291
11292         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
11293         ptid to get_last_target_status.
11294         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
11295         ptid to get_last_target_status.
11296         * infcmd.c (continue_command): Don't pass a target_waitstatus to
11297         get_last_target_status.
11298         (info_program_command): Don't pass a target_waitstatus to
11299         get_last_target_status.
11300         * infrun.c (init_wait_for_inferior): Use
11301         nullify_last_target_wait_ptid.
11302         (get_last_target_status): Handle nullptr arguments.
11303         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
11304         (print_stop_event): Don't pass a ptid to get_last_target_status.
11305         (normal_stop): Don't pass a ptid to get_last_target_status.
11306         * infrun.h (get_last_target_status, set_last_target_status): Move
11307         comments here and update.
11308         (nullify_last_target_wait_ptid): Declare.
11309         * linux-fork.c (fork_load_infrun_state): Remove local extern
11310         declaration of nullify_last_target_wait_ptid.
11311         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
11312         to get_last_target_status.
11313
11314 2020-01-10  Pedro Alves  <palves@redhat.com>
11315
11316         * gdbthread.h (scoped_restore_current_thread)
11317         <dont_restore, restore, m_dont_restore>: Declare.
11318         * thread.c (thread_alive): Add assertion.  Return bool.
11319         (switch_to_thread_if_alive): New.
11320         (prune_threads): Switch inferior/thread.
11321         (print_thread_info_1): Switch thread before calling target methods.
11322         (scoped_restore_current_thread::restore): New, factored out from
11323         ...
11324         (scoped_restore_current_thread::~scoped_restore_current_thread):
11325         ... this.
11326         (scoped_restore_current_thread::scoped_restore_current_thread):
11327         Add assertion.
11328         (thread_apply_all_command, thread_select): Use
11329         switch_to_thread_if_alive.
11330         * infrun.c (proceed, restart_threads, handle_signal_stop)
11331         (switch_back_to_stepped_thread): Switch current thread before
11332         calling target methods.
11333
11334 2020-01-10  Pedro Alves <palves@redhat.com>
11335
11336         * inferior.c (switch_to_inferior_no_thread): New function,
11337         factored out from ...
11338         (inferior_command): ... here.
11339         * inferior.h (switch_to_inferior_no_thread): Declare.
11340         * mi/mi-main.c (run_one_inferior): Use
11341         switch_to_inferior_no_thread.
11342
11343 2020-01-10  Pedro Alves  <palves@redhat.com>
11344
11345         * infcmd.c (kill_command): Remove dead code.
11346
11347 2020-01-10  Pedro Alves  <palves@redhat.com>
11348
11349         * remote.c (remote_target::mourn_inferior): No longer check
11350         whether the target is running.
11351
11352 2020-01-10  Pedro Alves  <palves@redhat.com>
11353
11354         * corelow.c (core_target::has_execution): Change parameter type to
11355         inferior pointer.
11356         * inferior.c (number_of_live_inferiors): Use
11357         inferior::has_execution instead of target_has_execution_1.
11358         * inferior.h (inferior::has_execution): New.
11359         * linux-thread-db.c (thread_db_target::update_thread_list): Use
11360         inferior::has_execution instead of target_has_execution_1.
11361         * process-stratum-target.c
11362         (process_stratum_target::has_execution): Change parameter type to
11363         inferior pointer.  Check the inferior's PID instead of
11364         inferior_ptid.
11365         * process-stratum-target.h
11366         (process_stratum_target::has_execution): Change parameter type to
11367         inferior pointer.
11368         * record-full.c (record_full_core_target::has_execution): Change
11369         parameter type to inferior pointer.
11370         * target.c (target_has_execution_1): Change parameter type to
11371         inferior pointer.
11372         (target_has_execution_current): Adjust.
11373         * target.h (target_ops::has_execution): Change parameter type to
11374         inferior pointer.
11375         (target_has_execution_1): Change parameter type to inferior
11376         pointer.  Change return type to bool.
11377         * tracefile.h (tracefile_target::has_execution): Change parameter
11378         type to inferior pointer.
11379
11380 2020-01-10  Pedro Alves  <palves@redhat.com>
11381
11382         * exceptions.c (print_flush): Remove current_top_target() check.
11383
11384 2020-01-10  Pedro Alves  <palves@redhat.com>
11385
11386         * remote.c (show_remote_exec_file): Show the current inferior's
11387         exec-file instead of the command variable's value.
11388
11389 2020-01-10  Pedro Alves  <palves@redhat.com>
11390
11391         * record-full.c (record_full_resume_ptid): New global.
11392         (record_full_target::resume): Set it.
11393         (record_full_wait_1): Use record_full_resume_ptid instead of
11394         inferior_ptid.
11395
11396 2020-01-10  Pedro Alves  <palves@redhat.com>
11397
11398         * gdbthread.h (scoped_restore_current_thread)
11399         <dont_restore, restore, m_dont_restore>: Declare.
11400         * thread.c (thread_alive): Add assertion.  Return bool.
11401         (switch_to_thread_if_alive): New.
11402         (prune_threads): Switch inferior/thread.
11403         (print_thread_info_1): Switch thread before calling target methods.
11404         (scoped_restore_current_thread::restore): New, factored out from
11405         ...
11406         (scoped_restore_current_thread::~scoped_restore_current_thread):
11407         ... this.
11408         (scoped_restore_current_thread::scoped_restore_current_thread):
11409         Add assertion.
11410         (thread_apply_all_command, thread_select): Use
11411         switch_to_thread_if_alive.
11412
11413 2020-01-10  George Barrett  <bob@bob131.so>
11414
11415         * stap-probe.c (stap_modify_semaphore): Don't check for null
11416         semaphores.
11417         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
11418         for null semaphores.
11419
11420 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11421
11422         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
11423         all source windows, and maintain horizontal scroll status while
11424         doing so.
11425
11426 2020-01-09  Tom Tromey  <tom@tromey.com>
11427
11428         PR tui/18932:
11429         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
11430         update_source_window, not print_source_lines.
11431
11432 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11433
11434         * tui/tui.c (tui_enable): Register tui hooks after calling
11435         tui_display_main.
11436
11437 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
11438
11439         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
11440
11441 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
11442
11443         * thread.c (print_thread_info_1): Fix indentation.
11444
11445 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
11446
11447         * symtab.c (general_symbol_info::compute_and_set_names): Move the
11448         unique_xmalloc_ptr outside the if to always free the demangled name.
11449
11450 2020-01-08  Tom Tromey  <tromey@adacore.com>
11451
11452         * xcoffread.c (enter_line_range, read_xcoff_symtab)
11453         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
11454         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
11455         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
11456         Remove.
11457         (section_offsets): New typedef.
11458         * symtab.c (fixup_section, get_msymbol_address): Update.
11459         * symmisc.c (dump_msymbols): Update.
11460         * symfile.h (relative_addr_info_to_section_offsets)
11461         (symfile_map_offsets_to_segments): Update.
11462         * symfile.c (build_section_addr_info_from_objfile)
11463         (init_objfile_sect_indices): Update.
11464         (struct place_section_arg): Change type of "offsets".
11465         (place_section): Update.
11466         (relative_addr_info_to_section_offsets): Change type of
11467         "section_offsets".  Remove "num_sections" parameter.
11468         (default_symfile_offsets, syms_from_objfile_1)
11469         (set_objfile_default_section_offset): Update.
11470         (reread_symbols): No need to preserve section offsets by hand.
11471         (symfile_map_offsets_to_segments): Change type of "offsets".
11472         * stap-probe.c (relocate_address): Update.
11473         * stabsread.h (process_one_symbol): Update.
11474         * solib-target.c (struct lm_info_target) <offsets>: Change type.
11475         (solib_target_relocate_section_addresses): Update.
11476         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
11477         Update.
11478         * solib-frv.c (frv_relocate_main_executable): Update.
11479         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
11480         * solib-aix.c (solib_aix_get_section_offsets): Change return
11481         type.
11482         (solib_aix_solib_create_inferior_hook): Update.
11483         * remote.c (remote_target::get_offsets): Update.
11484         * psymtab.c (find_pc_sect_psymtab): Update.
11485         * psympriv.h (struct partial_symbol) <address, text_low,
11486         text_high>: Update.
11487         * objfiles.h (obj_section_offset): Update.
11488         (struct objfile) <section_offsets>: Change type.
11489         <num_sections>: Remove.
11490         (objfile_relocate): Update.
11491         * objfiles.c (entry_point_address_query): Update
11492         (relocate_one_symbol): Change type of "section_offsets".
11493         (objfile_relocate1, objfile_relocate1): Change type of
11494         "new_offsets".
11495         (objfile_rebase1): Update.
11496         * mipsread.c (mipscoff_symfile_read): Update.
11497         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
11498         parameter.
11499         * mdebugread.c (parse_symbol): Change type of "section_offsets".
11500         (parse_external, psymtab_to_symtab_1): Update.
11501         * machoread.c (macho_symfile_offsets): Update.
11502         * ia64-tdep.c (ia64_find_unwind_table): Update.
11503         * hppa-tdep.c (read_unwind_info): Update.
11504         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
11505         * dwarf2read.c (create_addrmap_from_index)
11506         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11507         (process_psymtab_comp_unit_reader, add_partial_symbol)
11508         (add_partial_subprogram, process_full_comp_unit)
11509         (read_file_scope, read_func_scope, read_lexical_block_scope)
11510         (read_call_site_scope, dwarf2_rnglists_process)
11511         (dwarf2_ranges_process, dwarf2_ranges_read)
11512         (dwarf_decode_lines_1, var_decode_location, new_symbol)
11513         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
11514         Update.
11515         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
11516         Update.
11517         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
11518         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
11519         (process_one_symbol): Change type of "section_offsets".
11520         * ctfread.c (get_objfile_text_range): Update.
11521         * coffread.c (coff_symtab_read, enter_linenos)
11522         (process_coff_symbol): Update.
11523         * coff-pe-read.c (add_pe_forwarded_sym): Update.
11524         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
11525
11526 2020-01-08  Tom Tromey  <tromey@adacore.com>
11527
11528         * dwarf2read.c (parse_macro_definition): Use std::string.
11529         (parse_macro_definition): Likewise.
11530
11531 2020-01-08  Tom Tromey  <tromey@adacore.com>
11532
11533         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
11534         (ATTR_ALLOC_CHUNK): Remove.
11535
11536 2020-01-08  Tom Tromey  <tromey@adacore.com>
11537
11538         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
11539
11540 2020-01-08  Tom Tromey  <tromey@adacore.com>
11541
11542         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
11543         (dwarf2_compute_name, open_dwo_file): Likewise.
11544         (process_enumeration_scope): Use std::vector.
11545         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
11546         (partial_die_info::fixup, dwarf2_start_subfile)
11547         (guess_full_die_structure_name, dwarf2_name): Likewise.
11548         (determine_prefix): Update.
11549         (guess_full_die_structure_name): Make return type const.
11550         (partial_die_full_name): Return unique_xmalloc_ptr.
11551         (DW_FIELD_ALLOC_CHUNK): Remove.
11552
11553 2020-01-07  Tom Tromey  <tromey@adacore.com>
11554
11555         PR build/24937:
11556         * stap-probe.c (class stap_static_probe_ops): Add constructor.
11557
11558 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
11559
11560         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
11561
11562 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11563
11564         * stack.c (print_frame_info): Move disassemble_next_line code
11565         inside source_print block.
11566
11567 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
11568
11569         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
11570         gdb/signals.h, as we are now using native signal symbols.
11571
11572 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
11573
11574         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
11575         overflow by an early check of content vs threshold.
11576         * tui/tui-source.c (tui_source_window::line_is_displayed):
11577         Likewise.
11578
11579 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
11580
11581         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
11582
11583 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
11584
11585         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
11586         export table if no section contains it's RVA.
11587
11588 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
11589
11590         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
11591
11592 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
11593
11594         * source.c (print_source_lines_base): Set last_line_listed.
11595
11596 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
11597
11598         * tui/tui-disasm.c: Remove trailing spaces.
11599
11600 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
11601             Pedro Alves  <palves@redhat.com>
11602
11603         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
11604         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
11605         (windows_gdb_signal_to_target): New function, uses the above
11606         enumeration to convert GDB internal signal codes to equivalent
11607         Windows codes.
11608         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
11609         * windows-nat.c: Include "gdb_wait.h".
11610         (get_windows_debug_event): Extract the fatal exception from the
11611         exit status and convert to the equivalent Posix signal number.
11612         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
11613         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
11614         * gdbsupport/gdb_wait.c: New file, implements
11615         windows_status_to_termsig.
11616         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
11617         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
11618
11619 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
11620
11621         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
11622         show_layout.
11623
11624 2020-01-05  Luis Machado  <luis.machado@linaro.org>
11625
11626         * aarch64-linux-nat.c
11627         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
11628         and bfd_mach_aarch64.
11629
11630 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11631
11632         * ui-file.c (stdio_file::can_emit_style_escape)
11633         (tee_file::can_emit_style_escape): Ensure style is used also on
11634         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
11635         to gdb_stdout.
11636         * main.c (set_gdb_data_directory): Use file style to output the
11637         warning that the given pathname is not a directory.
11638         * top.c (show_history_filename, gdb_safe_append_history)
11639         (show_gdb_datadir): Use file style.
11640
11641 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
11642
11643         * solib-target.c (struct lm_info_target):
11644         Change offsets to be a unique_xmalloc_ptr.
11645         (solib_target_relocate_section_addresses): Update.
11646
11647 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
11648
11649         * windows-nat.c (windows_clear_solib): Free so_list linked list.
11650
11651 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
11652
11653         * MAINTAINERS (Write After Approval): Add myself.
11654
11655 2020-01-02  Luis Machado  <luis.machado@linaro.org>
11656
11657         * proc-service.c (get_ps_regcache): Remove reference to obsolete
11658         Cell BE architecture.
11659         * target.h (struct target_ops) <thread_architecture>: Likewise.
11660
11661 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
11662
11663         * Makefile.in: Use INSTALL_PROGRAM_ENV.
11664
11665 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
11666
11667         * MAINTAINERS (Write After Approval): Add myself.
11668
11669 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11670
11671         * gdbarch.sh: Update copyright year range of generated files.
11672
11673 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11674
11675         Update copyright year range in all GDB files.
11676
11677 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11678
11679         * copyright.py: Convert to Python 3.
11680
11681 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11682
11683         * copyright.py: Adapt after move of gnulib directory from gdb
11684         directory to toplevel directory.
11685
11686 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11687
11688         * copyright.py (main): Exit if run from the wrong directory.
11689
11690 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11691
11692         * top.c (print_gdb_version): Change copyright year to 2020.
11693
11694 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
11695
11696         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
11697
11698 For older changes see ChangeLog-2019.
11699 \f
11700 Local Variables:
11701 mode: change-log
11702 left-margin: 8
11703 fill-column: 74
11704 version-control: never
11705 coding: utf-8
11706 End: