1 2019-12-19 Tom Tromey <tromey@adacore.com>
3 * ui-out.h (enum class field_kind): Fix comment.
5 2019-12-11 Tom Tromey <tromey@adacore.com>
7 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
9 2019-12-18 Tom Tromey <tromey@adacore.com>
12 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
13 type on macOS. Add comment.
15 2019-12-18 Simon Marchi <simon.marchi@efficios.com>
17 * c-lang.c (c_get_string, asm_language_defn): Remove space
20 2019-12-18 Tom Tromey <tromey@adacore.com>
23 * ui-out.c (ui_out::vmessage): Update.
24 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
26 (string_field): Update.
27 (signed_field): Update.
29 2019-12-18 Simon Marchi <simon.marchi@efficios.com>
31 * top.c (print_gdb_configuration): Adjust indentation.
33 2019-12-17 Christian Biesinger <cbiesinger@google.com>
35 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
37 2019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
39 * tui/tui-layout.h (class tui_layout_base): Add virtual
42 2019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
44 * infcmd.c (prepare_one_step): Step over skipped inline functions.
45 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
46 (process_event_stop_test): Keep stepping over skipped inline functions.
48 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
50 * jit.c (struct gdb_block) <next>: Remove field.
51 (struct gdb_symtab) <~gdb_symtab>: Remove.
52 <blocks>: Change type to std::forward_list<gdb_block>.
53 (compare_block): Remove.
54 (jit_block_open_impl): Adjust to std::forward_list. Place the new
55 block at the beginning, don't mind about sorting.
56 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
59 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
61 * jit.c (struct gdb_block): Add constructor, initialize
62 real_block and next fields.
63 <name>: Change type to gdb::unique_xmalloc_ptr.
64 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
65 (jit_block_open_impl): Allocate gdb_block with new.
66 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
68 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
70 * jit.c: Include forward_list.
71 (struct gdb_symtab) <next>: Remove field.
72 (struct gdb_object) <symtabs>: Change type to
73 std::forward_list<gdb_symtab>.
74 (jit_object_open_impl): Allocate gdb_object with new.
75 (jit_symtab_open_impl): Adjust to std::forward_list.
76 (finalize_symtab): Don't delete symtab.
77 (jit_object_close_impl): Adjust to std::forward_list. Free
78 gdb_object with delete.
80 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
82 * jit.c (struct gdb_symtab): Add constructor, destructor,
84 <linetable>: Change type to unique_xmalloc_ptr.
85 <file_name>: Change type to std::string.
86 (jit_symtab_open_impl): Allocate gdb_symtab with new.
87 (jit_symtab_line_mapping_add_impl): Adjust.
88 (finalize_symtab): Adjust, call delete on stab.
90 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
92 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
94 2019-12-16 Tom Tromey <tromey@adacore.com>
96 * windows-nat.c (windows_nat_target::attach): Update.
97 * remote.c (extended_remote_target::attach): Update.
98 * procfs.c (procfs_target::attach): Update.
99 * nto-procfs.c (nto_procfs_target::attach): Update.
100 (nto_procfs_target::create_inferior): Update.
101 * inf-ptrace.c (inf_ptrace_target::attach): Update.
102 * gnu-nat.c (gnu_nat_target::attach): Update.
103 (gnu_nat_target::detach): Update.
104 * darwin-nat.c (darwin_nat_target::attach): Update.
105 * corefile.c (get_exec_file): Constify result. Remove extraneous
107 * bsd-kvm.c (bsd_kvm_target_open): Update.
108 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
110 2019-12-16 Christian Biesinger <cbiesinger@google.com>
112 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
113 (we no longer need to include time.h before pathmax.h)
115 2019-12-15 Christian Biesinger <cbiesinger@google.com>
117 * ada-exp.y (write_ambiguous_var): Update.
118 * coffread.c (process_coff_symbol): Update.
119 * ctfread.c (ctf_add_enum_member_cb): Update.
120 (new_symbol): Update.
121 * dwarf2read.c (fixup_go_packaging): Update.
122 (new_symbol): Update.
123 * language.c (language_alloc_type_symbol): Update.
124 * mdebugread.c (new_symbol): Update.
125 * minsyms.c (minimal_symbol_reader::record_full): Update.
126 * psymtab.c (add_psymbol_to_bcache): Update.
127 * stabsread.c (define_symbol): Update.
128 (read_enum_type): Update.
129 * symtab.c (symbol_set_language): Make this a member function...
130 (general_symbol_info::set_language): ... here.
131 * symtab.h (struct general_symbol_info) <set_language>: New function.
132 (SYMBOL_SET_LANGUAGE): Remove.
133 (symbol_set_language): Remove.
135 2019-12-15 Christian Biesinger <cbiesinger@google.com>
137 * ada-lang.c (ada_add_block_symbols): Update.
138 (ada_collect_symbol_completion_matches): Update.
139 * ax-gdb.c (gen_expr): Update.
140 * block.c (block_lookup_symbol): Update.
141 (block_lookup_symbol_primary): Update.
142 (block_find_symbol): Update.
143 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
144 * dbxread.c (process_one_symbol): Update.
145 * dictionary.c (insert_symbol_hashed): Update.
146 (collate_pending_symbols_by_language): Update.
147 (mdict_add_symbol): Update.
148 * dwarf-index-write.c (write_psymbols): Update.
149 * dwarf2read.c (fixup_go_packaging): Update.
150 * findvar.c (read_var_value): Update.
151 * ft32-tdep.c (ft32_skip_prologue): Update.
152 * go-lang.c (go_symbol_package_name): Update.
153 * language.h (scoped_switch_to_sym_language_if_auto::
154 scoped_switch_to_sym_language_if_auto): Update.
155 * linespec.c (find_method): Update.
156 (find_label_symbols_in_block): Update.
157 * mdebugread.c (parse_symbol): Update.
158 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
159 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
160 (minimal_symbol_reader::install): Update.
161 * moxie-tdep.c (moxie_skip_prologue): Update.
162 * parse.c (parse_exp_in_context): Update.
163 * psymtab.c (psymbol_name_matches): Update.
164 (match_partial_symbol): Update.
165 (lookup_partial_symbol): Update.
166 (psymbol_hash): Update.
167 (psymbol_compare): Update.
168 * python/py-framefilter.c (extract_sym): Update.
169 (py_print_single_arg): Update.
170 * stabsread.c (define_symbol): Update.
171 * stack.c (print_frame_arg): Update.
172 (find_frame_funname): Update.
173 (info_frame_command_core): Update.
174 * symfile.c (set_initial_language): Update.
175 * symtab.c (symbol_set_demangled_name): Update.
176 (symbol_get_demangled_name): Update.
177 (symbol_set_language): Update.
178 (symbol_find_demangled_name): Update.
179 (symbol_set_names): Update.
180 (general_symbol_info::natural_name): Update.
181 (general_symbol_info::demangled_name): Update.
182 (general_symbol_info::search_name): Update.
183 (symbol_matches_search_name): Update.
184 (eq_symbol_entry): Update.
185 (iterate_over_symbols): Update.
186 (completion_list_add_symbol): Update.
187 (completion_list_add_msymbol): Update.
188 (completion_list_add_fields): Update.
189 * symtab.h (struct general_symbol_info) <language>: New function.
190 <language>: Rename to...
191 <m_language>: ...this.
192 (SYMBOL_LANGUAGE): Remove.
193 (MSYMBOL_LANGUAGE): Remove.
194 (struct symbol) <ctor>: Update.
195 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
197 2019-12-15 Christian Biesinger <cbiesinger@google.com>
199 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
200 set the language of sym.
201 * language.c (language_alloc_type_symbol): Likewise.
203 2019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
205 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
207 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
208 * corelow.c: Include 'gdbsupport/pathstuff.h'.
209 (core_target_open): Use 'gdb_abspath'.
210 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
211 'current_directory == NULL' case.
212 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
213 explain what happens when 'current_directory' is NULL.
214 * go32-nat.c (go32_nat_target::wait): Check if
215 'current_directory' is NULL before call to 'chdir'.
216 * source.c (add_path): Use 'gdb_abspath'.
217 * top.c: Include 'gdbsupport/pathstuff.h'.
218 (init_history): Use 'gdb_abspath'.
219 (set_history_filename): Likewise.
220 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
221 (tfile_target_open): Use 'gdb_abspath'.
223 2019-12-13 Tom Tromey <tromey@adacore.com>
225 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
228 2019-12-13 Tom Tromey <tromey@adacore.com>
230 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
232 2019-12-13 Tom Tromey <tromey@adacore.com>
234 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
236 2019-12-13 Tom Tromey <tromey@adacore.com>
238 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
240 2019-12-13 Tom Tromey <tromey@adacore.com>
242 * gdbsupport/common-utils.c (string_printf, string_vprintf)
243 (string_vappendf): Add ARI comment.
245 2019-12-13 Tom Tromey <tromey@adacore.com>
247 * contrib/ari/gdb_ari.sh: Remove "fix" call for
248 floatformat_to_double.
249 * target-float.c (host_float_ops<T>::from_target): Add ARI
252 2019-12-13 Tom Tromey <tromey@adacore.com>
254 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
255 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
257 * event-top.c (handle_sigsegv): Add ARI marker to abort.
259 2019-12-13 Tom Tromey <tromey@adacore.com>
261 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
263 2019-12-13 Tom Tromey <tromey@adacore.com>
265 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
267 2019-12-13 Tom Tromey <tromey@adacore.com>
269 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
272 2019-12-13 Tom Tromey <tromey@adacore.com>
274 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
275 end>: No longer "const".
277 2019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
279 * jit.c: Fix indentation, replace spaces with tabs where
282 2019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
284 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
286 2019-12-12 Tom Tromey <tom@tromey.com>
288 * objfiles.h (struct objfile) <partial_symtabs>: Now a
291 2019-12-12 Tom Tromey <tom@tromey.com>
293 * progspace.h (objfile_list): New typedef.
294 (class unwrapping_objfile_iterator)
295 (struct unwrapping_objfile_range): Newl
296 (struct program_space) <objfiles_range>: Change type.
297 <objfiles>: Change return type.
298 <add_objfile>: Change type of "objfile" parameter.
299 <objfiles_list>: Now a list of shared_ptr.
300 * progspace.c (program_space::add_objfile): Change type of
302 (program_space::remove_objfile): Update.
303 * objfiles.h (struct objfile) <~objfile>: Make public.
304 * objfiles.c (objfile::make): Update.
305 (objfile::unlink): Don't call delete.
307 2019-12-12 Tom Tromey <tom@tromey.com>
309 * symfile.c (symbol_file_clear): Update.
310 * progspace.h (struct program_space) <free_all_objfiles>: Declare
312 * progspace.c (program_space::free_all_objfiles): New method.
313 * objfiles.h (free_all_objfiles): Don't declare.
314 * objfiles.c (free_all_objfiles): Move to program_space.
316 2019-12-12 Tom Tromey <tom@tromey.com>
318 * progspace.c (program_space::add_objfile)
319 (program_space::remove_objfile): Update.
320 (program_space::multi_objfile_p): Remove.
321 * objfiles.h (struct objfile) <next>: Remove.
322 * objfiles.c (objfile::objfile): Update.
323 (put_objfile_before): Update.
324 (unlink_objfile): Update.
325 * progspace.h (object_files): Remove.
326 (struct program_space) <objfiles_head>: Remove.
327 <objfiles_list>: New member.
328 <objfiles_range, objfiles_safe_range>: Change type.
329 (objfiles): Change return type.
330 (objfiles_safe): Update.
331 (multi_objfile_p): Rewrite and inline.
332 (object_files): Remove macro.
334 2019-12-12 Tom Tromey <tom@tromey.com>
336 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
338 (basic_safe_range): New class.
340 2019-12-12 Tom Tromey <tom@tromey.com>
342 * progspace.c (program_space::multi_objfile_p): New method.
343 * printcmd.c (info_symbol_command): Update.
344 * maint.c (maintenance_translate_address): Update.
345 * objfiles.h (MULTI_OBJFILE_P): Remove.
346 * progspace.h (struct program_space) <multi_objfile_p>: New
349 2019-12-12 Tom Tromey <tom@tromey.com>
351 * progspace.h (struct program_space) <remove_objfile>: Declare.
352 * progspace.c (program_space::remove_objfile): New method.
353 * objfiles.c (unlink_objfile): Remove.
354 (objfile::unlink): Call remove_objfile.
355 (objfile): Don't call unlink_objfile.
357 2019-12-12 Tom Tromey <tom@tromey.com>
359 * progspace.h (struct program_space) <add_objfile>: Declare
361 * progspace.c (program_space::add_objfile): New method.
362 * objfiles.c (~objfile): Don't unlink objfile.
363 (put_objfile_before): Remove.
364 (add_separate_debug_objfile): Don't call put_objfile_before.
365 (objfile::make): Call add_objfile. Set new_objfiles_available on
366 the per-program-space data.
368 2019-12-12 Tom Tromey <tom@tromey.com>
370 * symfile.c (syms_from_objfile_1): Use objfile_up.
371 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
373 (reread_symbols): Use objfile_up.
374 * solib.c (update_solib_list, reload_shared_libraries_1): Call
376 * objfiles.h (struct objfile) <~objfile>: Now private.
377 <unlink>: New method.
378 (struct objfile_deleter): New.
379 (objfile_up): New typedef.
380 * objfiles.c (objfile::unlink): New method.
381 (free_objfile_separate_debug, free_all_objfiles)
382 (objfile_purge_solibs): Use it.
383 * jit.c (jit_unregister_code): Remove.
384 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
386 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
388 * compile/compile-object-load.c (compile_object_load): Use
391 2019-12-12 Tom Tromey <tom@tromey.com>
393 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
395 * objfiles.h (struct objjfile) <make>: No longer inline.
396 (add_separate_debug_objfile): Don't declare.
397 * objfiles.c (add_separate_debug_objfile): Now static.
398 (objfile::make): Move from objfiles.h. Call
399 add_separate_debug_objfile. Add "parent" parameter.
401 2019-12-12 Tom Tromey <tom@tromey.com>
403 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
404 * objfiles.h (struct objfile): Make constructor private.
405 <make>: New static method.
406 * jit.c (jit_object_close_impl): Update.
408 2019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
410 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
413 2019-12-12 Tom Tromey <tromey@adacore.com>
415 * xml-support.c (xml_fetch_content_from_file): Don't call
417 * utils.h (class gdb_argv): Remove malloc_failure comment.
418 * utils.c (gdb_argv::reset): Don't call malloc_failure.
420 2019-12-12 Tom Tromey <tromey@adacore.com>
422 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
423 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
424 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
425 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
426 * riscv-ravenscar-thread.c: New file.
427 * riscv-ravenscar-thread.h: New file.
428 * riscv-tdep.c (riscv_gdbarch_init): Call
429 register_riscv_ravenscar_ops.
431 2019-12-12 Tom Tromey <tromey@adacore.com>
433 * gdbsupport/thread-pool.c (set_thread_name): Use
436 2019-12-12 Luis Machado <luis.machado@linaro.org>
438 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
439 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
442 2019-12-11 Tom Tromey <tom@tromey.com>
444 * tui/tui-win.c (tui_set_win_height_command): Call
445 tui_adjust_window_height.
446 (tui_adjust_win_heights, new_height_ok): Remove.
447 * tui/tui-layout.h (tui_adjust_window_height): Declare.
448 * tui/tui-layout.c (tui_adjust_window_height): New function.
450 2019-12-11 Tom Tromey <tom@tromey.com>
452 * tui/tui-win.c (tui_resize_all): Remove code, call
453 tui_apply_current_layout.
455 2019-12-11 Tom Tromey <tom@tromey.com>
457 * tui/tui-layout.h (tui_apply_current_layout): Declare.
458 * tui/tui-layout.c (standard_layouts, applied_layout): New
460 (tui_apply_current_layout): New function.
461 (show_layout): Set applied_layout. Call
462 tui_apply_current_layout.
463 (show_source_command, show_disasm_command)
464 (show_source_disasm_command, show_data)
465 (show_source_or_disasm_and_command): Remove.
466 (initialize_layouts): New function.
467 (_initialize_tui_layout): Call initialize_layouts.
469 2019-12-11 Tom Tromey <tom@tromey.com>
471 * tui/tui-layout.h (class tui_layout_base)
472 (class tui_layout_window, class tui_layout_split): New.
473 * tui/tui-layout.c (tui_get_window_by_name)
474 (tui_layout_window::clone, tui_layout_window::apply)
475 (tui_layout_window::get_sizes, tui_layout_window::add_split)
476 (tui_layout_split::add_window, tui_layout_split::clone)
477 (tui_layout_split::get_sizes)
478 (tui_layout_split::set_weights_from_heights)
479 (tui_layout_split::adjust_size, tui_layout_split::apply): New
481 (tui_layout_split::add_split, tui_layout_split::add_split)
482 (tui_layout_split::set_weights_from_heights)
483 (tui_layout_split::set_weights_from_heights): New functions.
485 2019-12-11 Tom Tromey <tom@tromey.com>
487 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
488 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
489 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
490 * tui/tui-data.h (struct tui_point): Remove.
491 (struct tui_gen_win_info) <origin>: Remove.
493 * tui/tui-command.c (tui_cmd_window::resize): Update.
495 2019-12-11 Tom Tromey <tom@tromey.com>
497 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
499 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
501 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
503 (struct tui_win_info) <min_height>: Implement.
505 2019-12-11 Tom Tromey <tom@tromey.com>
507 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
508 (struct tui_win_info) <can_box>: Update.
510 2019-12-11 Tom Tromey <tom@tromey.com>
512 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
514 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
516 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
518 (struct tui_win_info) <max_height>: Now override.
520 2019-12-11 Joel Brobecker <brobecker@adacore.com>
522 * NEWS: Create a new section for the next release branch.
523 Rename the section of the current branch, now that it has
526 2019-12-11 Joel Brobecker <brobecker@adacore.com>
528 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
529 * version.in: Bump version to 10.0.50.DATE-git.
531 2019-12-11 Tom Tromey <tromey@adacore.com>
534 * gdbsupport/thread-pool.c (set_thread_name): New function.
535 (thread_pool::set_thread_count): Don't call pthread_setname_np.
536 (thread_pool::thread_function): Call set_thread_name.
538 2019-12-11 Tom Tromey <tromey@adacore.com>
540 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
543 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
545 * NEWS: Document -raw-values option and the related setting commands.
546 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
547 only set it on when /r is given.
548 * valprint.c (value_print_option_defs): New element raw-values.
549 * Makefile.in: Add the new file.
551 2019-12-10 Christian Biesinger <cbiesinger@google.com>
553 * gdbsupport/safe-strerror.c: Supress the unused function warning
554 for select_strerror_r.
556 2019-12-10 Christian Biesinger <cbiesinger@google.com>
558 * config.in: Regenerate.
559 * configure: Regenerate.
560 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
561 safe_strerror instead of strerror.
562 * gdbsupport/common.m4: Don't check for strerror.
563 * gdbsupport/safe-strerror.c: Support both the glibc version
564 of strerror_r and the XSI version.
566 2019-12-10 Tom Tromey <tromey@adacore.com>
568 * ada-typeprint.c (print_choices): Use a single "?".
569 (print_variant_part): Print "?" if the discriminant name
572 2019-12-10 George Barrett <bob@bob131.so>
574 Fix scripted probe breakpoints.
575 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
577 (breakpoint_ops_for_event_location_type)
578 (breakpoint_ops_for_event_location): Add function definitions.
579 (break_command_1, trace_command): Use
580 breakpoint_ops_for_event_location.
581 * breakpoint.h (breakpoint_ops_for_event_location): Add function
583 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
584 breakpoint_ops_for_event_location.
585 * python/py-breakpoint.c (bppy_init): Use
586 breakpoint_ops_for_event_location.
588 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
590 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
591 when ranking an lvalue argument for an rvalue parameter.
593 2019-12-08 Wataru Ashihara <wataash@wataash.com>
595 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
596 template argument for scoped_restore_tmpl from bool to int.
598 2019-12-07 Keith Seitz <keiths@redhat.com>
600 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
601 (build_id_to_debug_bfd): Make static, rewriting to use
602 build_id_to_bfd_suffix.
603 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
604 adding `suffix' parameter. Append SUFFIX to file names
605 when searching for matching files.
606 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
607 (build_id_to_exec_bfd): Likewise.
608 * build-id.h (build_id_to_debug_bfd): Clarify that function
609 searches for BFD of debug info file.
610 (build_id_to_exec_bfd): Declare.
611 * corelow.c: Include build-id.h.
612 (locate_exec_from_corefile_build_id): New function.
613 (core_target_open): If no executable BFD is found,
614 search for a core file BFD using build-id.
616 2019-12-06 Christian Biesinger <cbiesinger@google.com>
618 * bcache.c: Put in namespace gdb.
619 * bcache.h: Likewise.
620 * gdbtypes.c (check_types_worklist): Update.
621 (types_deeply_equal): Update.
622 * macrotab.c (struct macro_table) <bcache>: Update.
623 (new_macro_table): Update.
624 * macrotab.h (struct bcache): Put this forward declaration
625 inside namespace gdb.
626 (new_macro_table): Update.
627 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
629 <macro_cache>: Update.
630 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
632 2019-12-06 Tom de Vries <tdevries@suse.de>
635 * block.c (best_symbol, better_symbol): New function.
636 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
639 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
641 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
642 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
643 for ranking see-through reference cases.
645 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
646 * stack.c (faas_command): Check a command is provided.
647 * thread.c (taas_command, tfaas_command): Likewise.
649 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
650 * inferior.c (prune_inferiors): Only call delete_inferior,
651 Do not modify the inferior list.
653 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
655 * c-exp.y: Update calls to lookup_typename,
656 lookup_signed_typename and lookup_unsigned_typename.
657 * c-lang.c (evaluate_subexp_c): Likewise.
658 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
660 * eval.c (binop_promote): Likewise.
661 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
662 (lookup_unsigned_typename): Likewise.
663 (lookup_signed_typename): Likewise.
664 * gdbtypes.h (lookup_unsigned_typename): Likewise.
665 (lookup_signed_typename): Likewise.
666 (lookup_typename): Likewise.
667 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
668 lookup_typename, lookup_signed_typename,
669 lookup_unsigned_typename.
670 * m2-exp.y: Likewise.
671 * printcmd.c (printf_wide_c_string): Likewise.
672 (ui_printf): Likewise.
673 * python/py-type.c (typy_lookup_typename): Likewise.
674 * python/py-xmethods.c (python_xmethod_worker::invoke):
676 * rust-exp.y: Likewise.
678 2019-12-04 Christian Biesinger <cbiesinger@google.com>
680 * configure.nat (obsd64): Add missing files x86-nat.o and
683 2019-12-04 Tom Tromey <tom@tromey.com>
685 * valprint.c (val_print_string): Use metadata_style.
686 * go-valprint.c (print_go_string): Use metadata style.
687 * p-valprint.c (pascal_object_print_static_field): Use metadata
689 * cp-valprint.c (cp_print_static_field): Use metadata style.
691 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
692 Chris January <chris.january@arm.com>
694 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
696 (typebase): New patterns for complex, single/double precision, and
697 single/double complex.
698 (f77_keywords): Change token for complex keyword, and add single,
699 double, and precision keywords.
701 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
703 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
706 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
708 * regcache.c (cooked_read_test): Initialize thread list of
711 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
713 * aarch64-linux-tdep.c: Remove includes.
715 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
717 * aarch64-tdep.c: Remove includes.
719 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
721 * filtered-iterator.h (filtered_iterator) <operator==,
722 operator!=>: Compare wrapped iterators, not wrapped pointers.
723 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
724 unittests/filtered_iterator-selftests.c.
725 * unittests/filtered_iterator-selftests.c: New file.
727 2019-12-04 Tom Tromey <tromey@adacore.com>
729 * gdbtypes.c (create_range_type): Inherit endianity
732 2019-12-04 Tom Tromey <tromey@adacore.com>
734 * ada-lang.c (decode_constrained_packed_array)
735 (ada_value_assign, value_assign_to_component): Update.
736 * dwarf2loc.c (rw_pieced_value, access_memory)
737 (dwarf2_compile_expr_to_ax): Update.
738 * dwarf2read.c (dwarf2_add_field): Update.
739 * eval.c (evaluate_subexp_standard): Update.
740 * gdbarch.c, gdbarch.h: Rebuild.
741 * gdbarch.sh (bits_big_endian): Remove.
742 * gdbtypes.h (union field_location): Update comment.
743 * target-descriptions.c (make_gdb_type): Update.
744 * valarith.c (value_bit_index): Update.
745 * value.c (struct value) <bitpos>: Update comment.
746 (unpack_bits_as_long, modify_field): Update.
747 * value.h (value_bitpos): Update comment.
749 2019-12-04 Tom Tromey <tromey@adacore.com>
751 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
754 2019-12-04 Tom Tromey <tromey@adacore.com>
756 * dwarf2read.c (dwarf2_init_float_type)
757 (dwarf2_init_complex_target_type): Add byte_order parameter.
758 (read_base_type): Compute byte order earlier.
759 * gdbtypes.c (init_float_type): Add byte_order parameter.
760 * gdbtypes.h (init_float_type): Add byte_order parameter.
762 2019-12-04 Tom Tromey <tromey@adacore.com>
764 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
766 2019-12-04 Tom Tromey <tromey@adacore.com>
768 * dwarf2read.c (process_structure_scope): Initialize
771 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
773 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
774 add it into the search spec.
775 (parse_max_results_option): New function.
776 (mi_info_functions_or_variables): Parse -max-results flag and pass
777 it to mi_symbol_info.
778 (mi_cmd_symbol_info_modules): Likewise.
779 (mi_cmd_symbol_info_types): Likewise.
780 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
781 return type to bool, change result container into a set, and don't
782 add new results if we have enough already.
783 (global_symbol_searcher::add_matching_msymbols): Change return
784 type to bool, and don't add new results if we have enough already.
785 (sort_search_symbols_remove_dups): Delete.
786 (global_symbol_searcher::search): Early exit from search loop when
787 we have enough results. Use a std::set to collect the results
788 from calling add_matching_symbols.
789 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
791 (global_symbol_searcher) <m_max_search_results>: New member
793 (global_symbol_searcher) <add_matching_symbols>: Update header
794 comment and change return type to bool.
795 (global_symbol_searcher) <add_matching_msymbols>: Update header
796 comment and change return type to bool.
798 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
800 * symtab.c (symbol_search::compare_search_syms): Update header
802 (global_symbol_searcher::is_suitable_msymbol): New function.
803 (global_symbol_searcher::expand_symtabs): New function.
804 (global_symbol_searcher::add_matching_symbols): New function.
805 (global_symbol_searcher::add_matching_msymbols): New function.
806 (global_symbol_searcher::search): Move most of the content
807 into the new functions above, and call them as needed.
808 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
810 (global_symbol_searcher) <add_matching_symbols>: New member
812 (global_symbol_searcher) <add_matching_msymbols>: New member
814 (global_symbol_searcher) <is_suitable_msymbol>: New member
817 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
819 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
820 -symbol-info-module-variables entries.
821 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
822 (mi_cmd_symbol_info_module_variables): Declare.
823 * mi/mi-symbol-cmds.c
824 (module_symbol_search_iterator): New typedef.
825 (output_module_symbols_in_single_module_and_file): New function.
826 (output_module_symbols_in_single_module): New function.
827 (mi_info_module_functions_or_variables): New function.
828 (mi_cmd_symbol_info_module_functions): New function.
829 (mi_cmd_symbol_info_module_variables): New function.
830 * NEWS: Mention new MI command.
832 2019-12-03 Christian Biesinger <cbiesinger@google.com>
834 * bcache.c (hash): Remove.
835 (hash_continue): Remove.
836 * bcache.h (hash): Remove.
837 (hash_continue): Remove.
838 (struct bcache) <ctor>: Update.
839 * psymtab.c (psymbol_hash): Update.
840 * stabsread.c (hashname): Update.
841 * utils.h (fast_hash): Add an argument for a start value,
844 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
845 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
846 (destroy_block_symbol_cache): New function.
847 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
848 (resize_symbol_cache): Likewise.
850 2019-12-02 Tom Tromey <tom@tromey.com>
852 * unittests/tui-selftests.c (run_tests): Make conditional.
853 (_initialize_tui_selftest): Make conditional.
855 2019-12-02 Christian Biesinger <cbiesinger@google.com>
857 * aix-thread.c (debug_aix_thread): Change type to bool.
859 2019-12-02 Luis Machado <luis.machado@linaro.org>
861 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
863 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
865 * dwarf2read.c (read_tag_string_type): Read the fields required to
866 make a dynamic string, and possibly create a dynamic range for the
868 (attr_to_dynamic_prop): Setup is_reference based on the type of
869 attribute being processed.
870 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
871 (resolve_dynamic_array): Rename to...
872 (resolve_dynamic_array_or_string): ...this, update header comment,
873 and accept TYPE_CODE_STRING.
874 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
876 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
878 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
879 of its implementation from...
880 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
883 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
885 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
886 create a range with stride where appropriate.
887 * f-valprint.c: Include 'gdbarch.h'.
888 (f77_print_array_1): Take the stride into account when walking the
889 array. Also convert the stride into addressable units.
890 * gdbtypes.c (create_range_type): Initialise the stride to
892 (create_range_type_with_stride): New function, initialise the
893 range as normal, and then setup the stride.
894 (has_static_range): Include the stride here. Also change the
896 (create_array_type_with_stride): Consider the range stride if the
897 array isn't given its own stride.
898 (resolve_dynamic_range): Resolve the stride if needed.
899 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
900 (struct range_bounds) <flag_is_byte_stride>: New member variable.
901 (TYPE_BIT_STRIDE): Define.
902 (TYPE_ARRAY_BIT_STRIDE): Define.
903 (create_range_type_with_stride): Declare.
904 * valarith.c (value_subscripted_rvalue): Take range stride into
905 account when walking the array.
907 2019-12-01 Tom Tromey <tom@tromey.com>
909 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
912 2019-12-01 Tom Tromey <tom@tromey.com>
914 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
916 * unittests/tui-selftests.c: New file.
917 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
919 2019-12-01 Tom Tromey <tom@tromey.com>
921 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
923 2019-12-01 Tom Tromey <tom@tromey.com>
925 * NEWS: Document new settings.
926 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
927 * tui/tui-win.c (_initialize_tui_win): Add border style
929 * tui/tui-io.h (tui_apply_style): Declare.
930 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
932 (apply_ansi_escape, tui_set_reverse_mode): Update.
933 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
934 Add "skip_intensity" parameter.
935 <changed>: New member.
936 <do_set_value>: Declare.
937 (tui_border_style, tui_active_border_style): Declare.
938 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
940 (cli_style_option): Initialize "changed".
941 (cli_style_option::do_set_value): New function.
942 (cli_style_option::add_setshow_commands): Add "skip_intensity"
944 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
945 (_initialize_cli_style): Update. Create TUI border style
948 2019-12-01 Tom Tromey <tom@tromey.com>
950 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
952 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
954 * tui/tui-win.h (compact_source): Declare.
955 * tui/tui-win.c (compact_source): New global.
956 (tui_set_compact_source, tui_show_compact_source): New functions.
957 (_initialize_tui_win): Add "compact-source" setting.
958 * tui/tui-source.c (tui_source_window::set_contents): Handle
959 compact_source setting.
960 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
961 * NEWS: Document new setting.
963 2019-11-30 Tom Tromey <tom@tromey.com>
965 * dwarf2read.c (dwarf2_add_field): Include field offset when
966 computing variant part length.
968 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
969 * NEWS: Mention define-prefix. Tell that command names can now
970 contain a . character.
972 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
974 * command.h (valid_cmd_char_p): Declare.
975 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
976 the check of valid command char.
977 (find_command_name_length, valid_user_defined_cmd_name_p): Use
979 * cli/cli-script.c (validate_comname): Likewise.
980 * completer.c (gdb_completer_command_word_break_characters):
981 Do not remove . from the word break char, update comments.
982 (complete_line_internal_1): Use valid_cmd_char_p.
983 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
984 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
986 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
988 * cli/cli-script.c (do_define_command): Ensure a redefined
989 prefix command is kept as a prefix command.
990 (define_prefix_command): New function.
991 (show_user_1): Report user defined prefixes.
992 (_initialize_cli_script): Create the new 'define-prefix' command.
993 Add completers for 'define' and 'document'.
994 * top.c (execute_command): If command is a user-defined prefix only
995 command, report the list of commands for this prefix command.
997 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
999 * valops.c (find_oload_champ): Improve debug output.
1001 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1003 * valops.c (find_oload_champ): Print part of debug messages
1004 before the badness vector is std::move'd.
1006 2019-11-28 Tom Tromey <tom@tromey.com>
1008 * value.c (creal_internal_fn): Fix comment.
1010 2019-11-28 Tom Tromey <tom@tromey.com>
1012 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1013 flag_bound_evaluated>: Now unsigned.
1015 2019-11-28 Tom Tromey <tom@tromey.com>
1017 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1020 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1022 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1024 * jit.c (jit_unregister_code): Add debug print to match
1025 `jit_register_code`.
1027 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1029 * NEWS: Mention the new multithreaded symbol loading.
1031 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1033 * maint.c (n_worker_threads): Default to 0.
1034 (worker_threads_disabled): New function.
1035 * maint.h (worker_threads_disabled): New function.
1036 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1037 here if worker_threads_disabled () is true.
1038 (minimal_symbol_reader::install): Skip all threading if
1039 worker_threads_disabled () is true.
1041 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1043 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1044 hash code if possible.
1045 (add_minsym_to_demangled_hash_table): Likewise.
1046 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1047 on the background thread.
1048 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1051 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1053 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1054 of the mangled name on the background thread.
1055 * symtab.c (symbol_set_names): Allow passing in the hash of the
1057 * symtab.h (symbol_set_names): Likewise.
1059 2019-11-27 Kevin Buettner <kevinb@redhat.com>
1061 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1062 physnames are computed for inherited DIEs.
1064 2019-11-27 Tom Tromey <tromey@adacore.com>
1066 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1068 * cp-support.c: Remove unnecessary backslashes.
1070 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1072 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1073 with sym->set_linkage_name.
1074 * coffread.c (coff_read_enum_type): Likewise.
1075 * mdebugread.c (parse_symbol): Likewise.
1076 * stabsread.c (patch_block_stabs): Likewise.
1077 (define_symbol): Likewise.
1078 (read_enum_type): Likewise.
1079 (common_block_end): Likewise.
1080 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1082 (SYMBOL_SET_LINKAGE_NAME): Remove.
1083 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1084 with sym->set_linkage_name.
1086 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1088 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1089 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1090 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1091 * NEWS: Mention new MI command.
1093 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1095 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1096 '-symbol-info-types', and '-symbol-info-variables'.
1097 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1098 (mi_cmd_symbol_info_types): Declare.
1099 (mi_cmd_symbol_info_variables): Declare.
1100 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1101 (output_debug_symbol): New function.
1102 (output_nondebug_symbol): New function.
1103 (mi_symbol_info): New function.
1104 (mi_info_functions_or_variables): New function.
1105 (mi_cmd_symbol_info_functions): New function.
1106 (mi_cmd_symbol_info_types): New function.
1107 (mi_cmd_symbol_info_variables): New function.
1108 * NEWS: Mention new commands.
1110 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1112 * symtab.c (symbol_to_info_string): New function, most content
1113 moved from print_symbol_info, but updated to return a std::string.
1114 (print_symbol_info): Update to use symbol_to_info_string and print
1116 * symtab.h (symbol_to_info_string): Declare new function.
1118 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1120 * python/python.c (gdbpy_rbreak): Convert to using
1121 global_symbol_searcher.
1122 * symtab.c (file_matches): Convert return type to bool, change
1123 file list to std::vector, update header comment.
1124 (search_symbols): Rename to...
1125 (global_symbol_searcher::search): ...this and update now its
1126 a member function of global_symbol_searcher. Take account of the
1127 changes to file_matches.
1128 (symtab_symbol_info): Convert to using global_symbol_searcher.
1129 (rbreak_command): Likewise.
1130 (search_module_symbols): Likewise.
1131 * symtab.h (enum symbol_search): Update comment.
1132 (search_symbols): Remove declaration.
1133 (class global_symbol_searcher): New class.
1135 2019-11-26 Tom Tromey <tromey@adacore.com>
1137 * cp-support.c (_initialize_cp_support): Conditionally initialize
1138 gdb_demangle_attempt_core_dump.
1140 2019-11-26 Tom Tromey <tom@tromey.com>
1142 * python/py-function.c (fnpy_init): Update.
1143 * value.h (add_internal_function): Adjust declaration.
1144 * value.c (function_destroyer): Remove.
1145 (do_add_internal_function): Don't set destroyer or copy name.
1146 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1148 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1149 (cmdpy_init): Set name_allocated.
1150 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1152 (~cmd_list_element): Free "name" if needed.
1154 2019-11-26 Tom Tromey <tom@tromey.com>
1156 * value.h (add_internal_function): Add new overload. Move
1157 documentation from value.h.
1158 * value.c (do_add_internal_function): New function.
1159 (add_internal_function): Use it. Add new overload.
1160 (function_destroyer): Don't free doc.
1161 * python/py-function.c (fnpy_init): Update.
1163 2019-11-26 Tom Tromey <tom@tromey.com>
1165 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1166 (cmdpy_init): Set "doc_allocated".
1168 2019-11-26 Tom Tromey <tom@tromey.com>
1170 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1171 name of worker thread.
1172 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1174 * configure, config.in: Rebuild.
1176 2019-11-26 Tom Tromey <tom@tromey.com>
1178 * python/python.c (class gdbpy_gil): New.
1179 (struct gdbpy_event): Add constructor, destructor, operator().
1180 (gdbpy_post_event): Use run_on_main_thread.
1181 (gdbpy_initialize_events): Remove.
1182 (do_start_initialization): Update.
1184 2019-11-26 Tom Tromey <tom@tromey.com>
1187 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1188 commands. Call update_thread_pool_size.
1189 (update_thread_pool_size, maintenance_set_worker_threads): New
1191 (n_worker_threads): New global.
1193 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1194 Tom Tromey <tom@tromey.com>
1196 * minsyms.c (minimal_symbol_reader::install): Use
1198 * gdbsupport/parallel-for.h: New file.
1199 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1201 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1202 Tom Tromey <tom@tromey.com>
1204 * gdbsupport/thread-pool.h: New file.
1205 * gdbsupport/thread-pool.c: New file.
1206 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1207 (HFILES_NO_SRCDIR): Add thread-pool.h.
1209 2019-11-26 Tom Tromey <tom@tromey.com>
1211 * event-top.h (thread_local_segv_handler): Declare.
1212 * event-top.c (thread_local_segv_handler): New global.
1213 (install_handle_sigsegv, handle_sigsegv): New functions.
1214 (async_init_signals): Install SIGSEGV handler.
1215 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1217 (report_failed_demangle): New function.
1218 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1219 handler-setting code, instead use segv_handler. Run warning code
1222 2019-11-26 Tom Tromey <tom@tromey.com>
1224 * run-on-main-thread.c: New file.
1225 * run-on-main-thread.h: New file.
1226 * unittests/main-thread-selftests.c: New file.
1227 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1228 main-thread-selftests.c.
1229 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1230 (COMMON_SFILES): Add run-on-main-thread.c.
1232 2019-11-26 Tom Tromey <tom@tromey.com>
1234 * main.c (setup_alternate_signal_stack): Remove.
1235 (captured_main_1): Use gdb::alternate_signal_stack.
1236 * gdbsupport/alt-stack.h: New file.
1238 2019-11-26 Tom Tromey <tom@tromey.com>
1240 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1242 (save_original_signals_state, restore_original_signals_state): Use
1244 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1245 (_initialize_linux_nat): Use gdb_sigmask.
1246 * guile/guile.c (_initialize_guile): Use block_signals.
1247 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1248 * gdbsupport/gdb-sigmask.h: New file.
1249 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1250 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1251 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1253 * configure, config.in: Rebuild.
1254 * gdbsupport/block-signals.h: New file.
1256 2019-11-26 Tom Tromey <tom@tromey.com>
1258 * acinclude.m4: Include ax_pthread.m4.
1259 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1260 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1261 (CLIBS): Use PTHREAD_LIBS.
1262 (aclocal_m4_deps): Add ax_pthread.m4.
1263 * config.in, configure: Rebuild.
1264 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1266 2019-11-26 Tom Tromey <tom@tromey.com>
1268 * symtab.h (struct minimal_symbol) <name_set>: New member.
1269 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1270 Don't call symbol_set_names.
1271 (minimal_symbol_reader::install): Call symbol_set_names.
1273 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1275 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1276 restore_active_ext_lang, as GIL is needed for (indirectly)
1277 called PyOS_InterruptOccurred.
1279 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1281 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1284 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1286 * remote-sim.c (simulator_command): Make static, remove
1289 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1291 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1293 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1294 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1296 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1298 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1300 * unittests/basic_string_view/element_access/char/1.cc (test01):
1303 * unittests/basic_string_view/element_access/char/empty.cc (main):
1305 * unittests/basic_string_view/element_access/char/front_back.cc
1308 * unittests/basic_string_view/inserters/char/2.cc (test05):
1311 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1314 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1317 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1319 * unittests/basic_string_view/operations/compare/char/1.cc
1322 * unittests/basic_string_view/operations/compare/char/13650.cc
1324 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1327 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1330 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1333 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1336 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1339 * unittests/basic_string_view/operations/find/char/4.cc (main):
1341 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1344 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1347 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1350 * unittests/basic_string_view/operations/substr/char/1.cc
1353 * unittests/basic_string_view/operators/char/2.cc (main):
1355 * unittests/optional/assignment/1.cc (test): Likewise.
1356 * unittests/optional/assignment/2.cc (test): Likewise.
1357 * unittests/optional/assignment/3.cc (test): Likewise.
1358 * unittests/optional/assignment/4.cc (test): Likewise.
1359 * unittests/optional/assignment/5.cc (test): Likewise.
1360 * unittests/optional/assignment/6.cc (test): Likewise.
1361 * unittests/optional/assignment/7.cc (test): Likewise.
1362 * unittests/optional/cons/copy.cc (test): Likewise.
1363 * unittests/optional/cons/default.cc (test): Likewise.
1364 * unittests/optional/cons/move.cc (test): Likewise.
1365 * unittests/optional/cons/value.cc (test): Likewise.
1366 * unittests/optional/in_place.cc (test): Likewise.
1367 * unittests/optional/observers/1.cc (test): Likewise.
1368 * unittests/optional/observers/2.cc (test): Likewise.
1370 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1372 * tui-win.h (tui_set_var_cmd): Remove.
1373 * tui-win.c (tui_set_var_cmd): Make static.
1375 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1377 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1378 rbreak_command_wrapper): Remove.
1379 * symtab.c (rbreak_command_wrapper): Remove.
1381 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1383 * inferior.h (info_terminal_command): Remove declaration.
1384 * inflow.c (info_terminal_command): Make static.
1386 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1388 * inferior.c (exit_inferior_silent): Remove.
1390 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1392 * dictionary.c (dict_empty, mdict_empty): Remove.
1393 * dictionary.c (mdict_empty): Remove.
1395 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1397 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1398 (arc_insn_get_memory_offset): Likewise.
1399 (arc_insn_dump): Likewise.
1400 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1401 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1402 * dictionary.c (dict_iterator_next): Likewise.
1403 (dict_iter_match_first): Likewise.
1404 (dict_iter_match_next): Likewise.
1405 * f-lang.c (evaluate_subexp_f): Likewise.
1406 * hppa-tdep.c (hppa_read_pc): Likewise.
1407 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1408 * parse.c (write_exp_elt_msym): Likewise.
1409 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1410 * remote.c (remote_packet_size): Likewise.
1411 (remote_notif_stop_parse): Likewise.
1412 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1413 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1414 * source.c (prepare_path_for_appending): Likewise.
1415 * sparc64-linux-tdep.c
1416 (sparc64_linux_handle_segmentation_fault); Likewise.
1417 * stack.c (frame_selection_by_function_completer): Likewise.
1419 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1421 * completer.c (set_gdb_completion_word_break_characters):
1424 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1426 * dwarf-index-write.c: Include dwarf-index-write.h.
1427 * mi/mi-interp.c: Include mi/mi-interp.h.
1429 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1431 * aarch32-tdep.c: Include aarch32-tdep.h.
1432 * aarch32-tdep.h: Forward-declare struct target_desc.
1434 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1436 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1438 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1439 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1441 2019-11-25 Tom de Vries <tdevries@suse.de>
1443 * contrib/words.sh: Add -c option.
1445 2019-11-25 Christian Biesinger <cbiesinger@google.com>
1447 * solib.c (solib_find_1): Change int to bool.
1448 (exec_file_find): Change int to bool.
1449 (solib_find): Change int to bool.
1450 (solib_read_symbols): Change int to bool.
1451 (solib_used): Change int to bool.
1452 (solib_add): Change int to bool.
1453 (info_sharedlibrary_command): Change int to bool.
1454 (solib_contains_address_p): Change int to bool.
1455 (solib_keep_data_in_core): Change int to bool.
1456 (in_solib_dynsym_resolve_code): Change int to bool.
1457 (reload_shared_libraries_1): Change int to bool.
1458 (gdb_sysroot_changed): Change int to bool.
1459 * solib.h (solib_read_symbols): Change int to bool.
1460 (solib_contains_address_p): Change int to bool.
1461 (solib_keep_data_in_core): Change int to bool.
1462 (in_solib_dynsym_resolve_code): Change int to bool.
1463 (libpthread_name_p): Change int to bool.
1465 2019-11-25 Luis Machado <luis.machado@linaro.org>
1467 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1468 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1469 (remote_packet_max_chars): New static global.
1470 (show_remote_packet_max_chars): New function.
1471 (remote_target::putpkt_binary): Adjust to use new
1472 remote_packet_max_chars option.
1473 (remote_target::getpkt_or_notif_sane_1): Likewise.
1474 (_initialize_remote): Register new remote-packet-max-chars option.
1476 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
1478 * m68k-linux-nat.c: Include gdbarch.h.
1480 2019-11-24 Tom Tromey <tom@tromey.com>
1482 * symfile.c (read_symbols): Update.
1483 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1485 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1486 (psym_lookup_symbol, psym_find_last_source_symtab)
1487 (psym_forget_cached_source_info, psym_print_stats)
1488 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1489 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1490 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1491 (psym_find_compunit_symtab_by_address)
1492 (maintenance_print_psymbols, maintenance_info_psymtabs)
1493 (maintenance_check_psymtabs): Update.
1494 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1497 2019-11-22 Tom Tromey <tom@tromey.com>
1499 * observable.h: Update comments.
1501 2019-11-22 Tom Tromey <tromey@adacore.com>
1503 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1504 (print_ada_task_info): Don't try to fetch thread id if task is not
1507 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1509 * ada-exp.y: Update.
1510 * ada-lang.c (sort_choices): Update.
1511 (ada_print_symbol_signature): Update.
1512 (resolve_subexp): Update.
1513 (ada_parse_renaming): Update.
1514 (ada_read_renaming_var_value): Update.
1515 (lesseq_defined_than): Update.
1516 (remove_extra_symbols): Update.
1517 (remove_irrelevant_renamings): Update.
1518 (ada_add_block_symbols): Update.
1519 (ada_collect_symbol_completion_matches): Update.
1520 (ada_is_renaming_symbol): Update.
1521 (aggregate_assign_from_choices): Update.
1522 (ada_evaluate_subexp): Update.
1523 (ada_has_this_exception_support): Update.
1524 (ada_is_non_standard_exception_sym): Update.
1525 (ada_add_exceptions_from_frame): Update.
1526 (ada_add_global_exceptions): Update.
1527 (ada_print_subexp): Update.
1528 * ax-gdb.c (gen_var_ref): Update.
1529 (gen_maybe_namespace_elt): Update.
1530 (gen_expr_for_cast): Update.
1533 * blockframe.c (find_pc_partial_function): Update.
1534 * breakpoint.c (print_breakpoint_location): Update.
1535 (update_static_tracepoint): Update.
1536 * btrace.c (ftrace_print_function_name): Update.
1537 (ftrace_function_switched): Update.
1538 * buildsym.c (find_symbol_in_list): Update.
1540 * c-typeprint.c (c_print_typedef): Update.
1541 (c_type_print_template_args): Update.
1542 * cli/cli-cmds.c (edit_command): Update.
1543 (list_command): Update.
1544 (print_sal_location): Update.
1545 * coffread.c (patch_opaque_types): Update.
1546 (process_coff_symbol): Update.
1547 (coff_read_enum_type): Update.
1548 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1549 (convert_one_symbol): Update.
1550 (hash_symname): Update.
1551 (eq_symname): Update.
1552 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1553 * compile/compile-cplus-types.c (debug_print_scope): Update.
1554 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1555 * compile/compile-object-load.c (get_out_value_type): Update.
1556 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1557 (search_symbol_list): Update.
1558 (cp_lookup_symbol_imports_or_template): Update.
1559 * cp-support.c (overload_list_add_symbol): Update.
1560 * ctfread.c (psymtab_to_symtab): Update.
1561 * dbxread.c (cp_set_block_scope): Update.
1562 * dictionary.c (iter_match_first_hashed): Update.
1563 (iter_match_next_hashed): Update.
1564 (insert_symbol_hashed): Update.
1565 (iter_match_next_linear): Update.
1566 * dictionary.h: Update.
1567 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1568 (locexpr_describe_location_piece): Update.
1569 (locexpr_describe_location_1): Update.
1570 (locexpr_generate_c_location): Update.
1571 (loclist_describe_location): Update.
1572 (loclist_generate_c_location): Update.
1573 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1574 (read_func_scope): Update.
1575 (process_enumeration_scope): Update.
1576 (new_symbol): Update.
1577 (dwarf2_const_value): Update.
1578 (dwarf2_symbol_mark_computed): Update.
1579 * eval.c (evaluate_funcall): Update.
1580 (evaluate_subexp_standard): Update.
1581 * expprint.c (print_subexp_standard): Update.
1582 (dump_subexp_body_standard): Update.
1583 * f-valprint.c (info_common_command_for_block): Update.
1584 * findvar.c (get_hosting_frame): Update.
1585 (default_read_var_value): Update.
1586 * go-lang.c (go_symbol_package_name): Update.
1587 * guile/scm-block.c (bkscm_print_block_smob): Update.
1588 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1589 (gdbscm_symbol_name): Update.
1590 (gdbscm_symbol_linkage_name): Update.
1591 (gdbscm_symbol_print_name): Update.
1592 * infcall.c (get_function_name): Update.
1593 * infcmd.c (jump_command): Update.
1594 (finish_command): Update.
1595 * infrun.c (insert_exception_resume_breakpoint): Update.
1596 * linespec.c (canonicalize_linespec): Update.
1597 (create_sals_line_offset): Update.
1598 (convert_linespec_to_sals): Update.
1599 (complete_label): Update.
1600 (find_label_symbols_in_block): Update.
1601 * m2-typeprint.c (m2_print_typedef): Update.
1602 * mdebugread.c (mdebug_reg_to_regnum): Update.
1603 (parse_symbol): Update.
1604 (mylookup_symbol): Update.
1605 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1606 (list_args_or_locals): Update.
1607 * objc-lang.c (compare_selectors): Update.
1608 (info_selectors_command): Update.
1609 (compare_classes): Update.
1610 (info_classes_command): Update.
1611 (find_imps): Update.
1612 * p-typeprint.c (pascal_print_typedef): Update.
1613 * printcmd.c (build_address_symbolic): Update.
1614 (info_address_command): Update.
1615 (print_variable_and_value): Update.
1616 * python/py-framefilter.c (extract_sym): Update.
1617 (py_print_single_arg): Update.
1618 * python/py-symbol.c (sympy_str): Update.
1619 (sympy_get_name): Update.
1620 (sympy_get_linkage_name): Update.
1621 * python/python.c (gdbpy_rbreak): Update.
1622 * record-btrace.c (btrace_get_bfun_name): Update.
1623 (btrace_call_history): Update.
1624 * rust-lang.c (rust_print_typedef): Update.
1625 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1626 * stabsread.c (stab_reg_to_regnum): Update.
1627 (define_symbol): Update.
1628 (read_enum_type): Update.
1629 (common_block_end): Update.
1630 (cleanup_undefined_types_1): Update.
1631 (scan_file_globals): Update.
1632 * stack.c (print_frame_arg): Update.
1633 (print_frame_args): Update.
1634 (find_frame_funname): Update.
1635 (info_frame_command_core): Update.
1636 (iterate_over_block_locals): Update.
1637 (print_block_frame_labels): Update.
1638 (do_print_variable_and_value): Update.
1639 (iterate_over_block_arg_vars): Update.
1640 (return_command): Update.
1641 * symmisc.c (dump_symtab_1): Update.
1642 (print_symbol): Update.
1643 * symtab.c (eq_symbol_entry): Update.
1644 (symbol_cache_dump): Update.
1645 (lookup_language_this): Update.
1646 (find_pc_sect_line): Update.
1647 (skip_prologue_sal): Update.
1648 (symbol_search::compare_search_syms): Update.
1649 (treg_matches_sym_type_name): Update.
1650 (search_symbols): Update.
1651 (print_symbol_info): Update.
1652 (rbreak_command): Update.
1653 (completion_list_add_symbol): Update.
1654 (find_gnu_ifunc): Update.
1655 (get_symbol_address): Update.
1656 (search_module_symbols): Update.
1657 (info_module_subcommand): Update.
1658 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1659 (SYMBOL_LINKAGE_NAME): Remove.
1660 (SYMBOL_DEMANGLED_NAME): Remove.
1661 (SYMBOL_PRINT_NAME): Remove.
1662 (SYMBOL_SEARCH_NAME): Remove.
1663 * tracepoint.c (set_traceframe_context): Update.
1664 (validate_actionline): Update.
1665 (collection_list::collect_symbol): Update.
1666 (encode_actions_1): Update.
1667 (info_scope_command): Update.
1668 (print_one_static_tracepoint_marker): Update.
1669 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1670 * valops.c (address_of_variable): Update.
1671 (find_overload_match): Update.
1672 (find_oload_champ): Update.
1674 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1676 * ada-lang.c (ada_lookup_simple_minsym): Update.
1677 (ada_collect_symbol_completion_matches): Update.
1678 * ada-tasks.c (read_atcb): Update.
1679 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1680 (amd64_windows_skip_trampoline_code): Update.
1681 * arm-tdep.c (skip_prologue_function): Update.
1682 (arm_skip_stack_protector): Update.
1683 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1684 (arm_wince_skip_main_prologue): Update.
1685 * ax-gdb.c (gen_expr): Update.
1686 * block.c (call_site_for_pc): Update.
1687 * blockframe.c (find_pc_partial_function): Update.
1688 * breakpoint.c (set_breakpoint_location_function): Update.
1689 * btrace.c (ftrace_print_function_name): Update.
1690 (ftrace_function_switched): Update.
1691 * c-valprint.c (print_unpacked_pointer): Update.
1692 * coffread.c (coff_symfile_read): Update.
1693 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1694 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1695 * dwarf-index-write.c (write_psymbols): Update.
1696 * dwarf2loc.c (call_site_to_target_addr): Update.
1697 (func_verify_no_selftailcall): Update.
1698 (tailcall_dump): Update.
1699 (call_site_find_chain_1): Update.
1700 (dwarf_expr_reg_to_entry_parameter): Update.
1701 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1702 * eval.c (evaluate_funcall): Update.
1703 (evaluate_subexp_standard): Update.
1704 (evaluate_subexp_for_sizeof): Update.
1705 * expprint.c (print_subexp_standard): Update.
1706 (dump_subexp_body_standard): Update.
1707 * frame.c (get_prev_frame_always_1): Update.
1708 * frv-tdep.c (frv_skip_main_prologue): Update.
1709 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1710 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1711 (gnuv3_get_typename_from_type_info): Update.
1712 (gnuv3_skip_trampoline): Update.
1713 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1714 * i386-tdep.c (i386_skip_main_prologue): Update.
1715 (i386_pe_skip_trampoline_code): Update.
1716 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1717 * infcall.c (get_function_name): Update.
1718 * linespec.c (minsym_found): Update.
1719 * linux-fork.c (info_checkpoints_command): Update.
1720 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1721 (m32c_m16c_pointer_to_address): Update.
1722 * maint.c (maintenance_translate_address): Update.
1723 * minsyms.c (add_minsym_to_hash_table): Update.
1724 (add_minsym_to_demangled_hash_table): Update.
1725 (lookup_minimal_symbol_mangled): Update.
1726 (lookup_minimal_symbol_demangled): Update.
1727 (lookup_minimal_symbol_linkage): Update.
1728 (lookup_minimal_symbol_text): Update.
1729 (lookup_minimal_symbol_by_pc_name): Update.
1730 (minimal_symbol_is_less_than): Update.
1731 (compact_minimal_symbols): Update.
1732 (build_minimal_symbol_hash_tables): Update.
1733 (find_solib_trampoline_target): Update.
1734 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1735 (mips_skip_pic_trampoline_code): Update.
1736 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1737 * objc-lang.c (info_selectors_command): Update.
1738 (info_classes_command): Update.
1739 (find_methods): Update.
1740 (find_imps): Update.
1741 * p-valprint.c (pascal_val_print): Update.
1742 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1743 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1744 * printcmd.c (build_address_symbolic): Update.
1745 (info_symbol_command): Update.
1746 * psymtab.c (psymbol_name_matches): Update.
1747 (match_partial_symbol): Update.
1748 (lookup_partial_symbol): Update.
1749 (print_partial_symbols): Update.
1750 (sort_pst_symbols): Update.
1751 (maintenance_check_psymtabs): Update.
1752 * python/py-framefilter.c (py_print_frame): Update.
1753 * python/python.c (gdbpy_rbreak): Update.
1754 * record-btrace.c (btrace_get_bfun_name): Update.
1755 (btrace_call_history): Update.
1756 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1757 (rs6000_skip_trampoline_code): Update.
1758 * sol-thread.c (info_cb): Update.
1759 * stabsread.c (scan_file_globals): Update.
1760 * stack.c (find_frame_funname): Update.
1761 (info_frame_command_core): Update.
1762 * symmisc.c (dump_msymbols): Update.
1763 * symtab.c (symbol_natural_name): Rename to..,
1764 (general_symbol_info::natural_name): ...this.
1765 (symbol_demangled_name): Rename to...
1766 (general_symbol_info::demangled_name): ...this.
1767 (symbol_search_name): Rename to...
1768 (general_symbol_info::search_name): ...this.
1769 (symbol_matches_search_name): Update.
1770 (find_pc_sect_line): Update.
1771 (skip_prologue_sal): Update.
1772 (search_symbols): Update.
1773 (print_msymbol_info): Update.
1774 (rbreak_command): Update.
1775 (completion_list_add_msymbol): Update.
1776 (completion_list_objc_symbol): Update.
1777 (get_msymbol_address): Update.
1778 * symtab.h (struct general_symbol_info): Add member functions
1779 natural_name (), linkage_name (), print_name (), demangled_name (),
1781 (SYMBOL_NATURAL_NAME): Update.
1782 (symbol_natural_name): Move to a member function on general_symbol_info.
1783 (SYMBOL_DEMANGLED_NAME): Update.
1784 (symbol_demangled_name): Move to a member function on
1785 general_symbol_info.
1786 (SYMBOL_SEARCH_NAME): Update.
1787 (symbol_search_name): Move to a member function on general_symbol_info.
1788 (MSYMBOL_NATURAL_NAME): Remove.
1789 (MSYMBOL_LINKAGE_NAME): Remove.
1790 (MSYMBOL_PRINT_NAME): Remove.
1791 (MSYMBOL_DEMANGLED_NAME): Remove.
1792 (MSYMBOL_SEARCH_NAME): Remove.
1793 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1795 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1797 * symtab.c (create_demangled_names_hash): Use per_bfd->
1798 minimal_symbol_count for computing the initial size, if greater
1799 than our default size.
1801 2019-11-22 Tom de Vries <tdevries@suse.de>
1803 * contrib/words.sh: Improve words extraction.
1805 2019-11-22 Tom de Vries <tdevries@suse.de>
1807 * contrib/words.sh: Combine sed invocations.
1809 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1811 * Makefile.in: Update.
1812 * demangle.c: Rename to...
1813 * gdb-demangle.c: ..this.
1814 (is_cplus_marker): Change return type to bool.
1815 (_initialize_demangler): Rename to...
1816 (_initialize_gdb_demangle): ...this.
1817 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1818 * symtab.h (demangle): Remove declaration; instead include
1821 2019-11-21 Tom Tromey <tromey@adacore.com>
1823 * gdbsupport/format.c (format_pieces): Parse %I64d.
1824 * unittests/format_pieces-selftests.c (test_windows_formats): New
1826 (run_tests): Call it.
1828 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1830 Byte reverse display of variables with DW_END_big, DW_END_little
1831 (DW_AT_endianity) dwarf attributes if different than the native
1833 * ada-lang.c (ada_value_binop):
1834 Use type_byte_order instead of gdbarch_byte_order.
1835 * ada-valprint.c (printstr):
1836 (ada_val_print_string):
1837 * ada-lang.c (value_pointer):
1839 Use type_byte_order instead of gdbarch_byte_order.
1840 * c-lang.c (c_get_string):
1841 Use type_byte_order instead of gdbarch_byte_order.
1842 * c-valprint.c (c_val_print_array):
1843 Use type_byte_order instead of gdbarch_byte_order.
1844 * cp-valprint.c (cp_print_class_member):
1845 Use type_byte_order instead of gdbarch_byte_order.
1846 * dwarf2loc.c (rw_pieced_value):
1847 Use type_byte_order instead of gdbarch_byte_order.
1848 * dwarf2read.c (read_base_type): Handle DW_END_big,
1850 * f-lang.c (f_get_encoding):
1851 Use type_byte_order instead of gdbarch_byte_order.
1852 * findvar.c (default_read_var_value):
1853 Use type_byte_order instead of gdbarch_byte_order.
1854 * gdbtypes.c (check_types_equal):
1855 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1856 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1857 and TYPE_ENDIANITY_LITTLE if set.
1858 (type_byte_order): new function.
1859 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1860 (struct main_type) <flag_endianity_not_default>:
1862 (type_byte_order): New function.
1863 * infcmd.c (default_print_one_register_info):
1864 Use type_byte_order instead of gdbarch_byte_order.
1865 * p-lang.c (pascal_printstr):
1866 Use type_byte_order instead of gdbarch_byte_order.
1867 * p-valprint.c (pascal_val_print):
1868 Use type_byte_order instead of gdbarch_byte_order.
1869 * printcmd.c (print_scalar_formatted):
1870 Use type_byte_order instead of gdbarch_byte_order.
1871 * solib-darwin.c (darwin_current_sos):
1872 Use type_byte_order instead of gdbarch_byte_order.
1873 * solib-svr4.c (solib_svr4_r_ldsomap):
1874 Use type_byte_order instead of gdbarch_byte_order.
1875 * stap-probe.c (stap_modify_semaphore):
1876 Use type_byte_order instead of gdbarch_byte_order.
1877 * target-float.c (target_float_same_format_p):
1878 Use type_byte_order instead of gdbarch_byte_order.
1879 * valarith.c (scalar_binop):
1881 Use type_byte_order instead of gdbarch_byte_order.
1882 * valops.c (value_cast):
1883 Use type_byte_order instead of gdbarch_byte_order.
1884 * valprint.c (generic_emit_char):
1887 Use type_byte_order instead of gdbarch_byte_order.
1888 * value.c (unpack_long):
1889 (unpack_bits_as_long):
1890 (unpack_value_bitfield):
1893 (pack_unsigned_long):
1894 Use type_byte_order instead of gdbarch_byte_order.
1895 * findvar.c (unsigned_pointer_to_address):
1896 (signed_pointer_to_address):
1897 (unsigned_address_to_pointer):
1898 (address_to_signed_pointer):
1899 (default_read_var_value):
1900 (default_value_from_register):
1901 Use type_byte_order instead of gdbarch_byte_order.
1902 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1903 Use type_byte_order instead of gdbarch_byte_order.
1904 * riscv-tdep.c (riscv_print_one_register_info):
1905 Use type_byte_order instead of gdbarch_byte_order.
1907 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1909 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1910 (current_ui_gdb_stdin_ptr): Likewise.
1911 (current_ui_gdb_stderr_ptr): Likewise.
1912 (current_ui_gdb_stdlog_ptr): Likewise.
1913 (current_ui_current_uiout_ptr): Likewise.
1914 (gen_ret_current_ui_field_ptr): Remove.
1916 2019-11-21 Tom de Vries <tdevries@suse.de>
1919 * cli/cli-script.c (execute_control_command): Only switch to
1920 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1922 2019-11-19 Tom Tromey <tom@tromey.com>
1924 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1925 Now static. Change type of "name".
1926 (tui_set_win_height_command): Don't copy "arg".
1927 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1928 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1930 2019-11-19 Ali Tamur <tamur@google.com>
1932 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1933 "if (attr != nullptr)".
1934 (dwarf2_find_base_address): Likewise.
1935 (dwarf2_build_include_psymtabs): Likewise.
1936 (read_cutu_die_from_dwo): Likewise.
1937 (read_func_scope): Likewise.
1938 (read_call_site_scope): Likewise.
1939 (dwarf2_get_pc_bounds): Likewise.
1940 (dwarf2_record_block_ranges): Likewise.
1941 (dwarf2_add_field): Likewise.
1942 (dwarf2_add_member_fn): Likewise.
1943 (read_structure_type): Likewise.
1944 (read_enumeration_type): Likewise.
1945 (read_array_type): Likewise.
1946 (read_array_order): Likewise.
1947 (read_set_type): Likewise.
1948 (read_common_block): Likewise.
1949 (read_tag_reference_type): Likewise.
1950 (read_tag_string_type): Likewise.
1951 (read_subroutine_type): Likewise.
1952 (read_base_type): Likewise.
1953 (read_subrange_type): Likewise.
1954 (new_symbol): Likewise.
1955 (prepare_one_comp_unit): Likewise.
1957 2019-11-19 Tom Tromey <tromey@adacore.com>
1959 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1960 result in error when DebugActiveProcess fails.
1962 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1963 Pedro Alves <palves@redhat.com>
1965 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1966 * target.c (target_stack::push): Call 'unpush' if there's a
1967 target on top of the stack.
1969 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1971 * python/py-block.c (blpy_dealloc): Call tp_free.
1972 (blpy_block_syms_dealloc): Likewise.
1973 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1974 * python/py-inferior.c (infpy_dealloc): Likewise.
1975 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1976 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1977 * python/py-symbol.c (sympy_dealloc): Likewise.
1978 * python/py-symtab.c (stpy_dealloc): Likewise.
1979 * python/py-type.c (typy_iterator_dealloc): Likewise.
1981 2019-11-18 Christian Biesinger <cbiesinger@google.com>
1983 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1984 constructor instead of using a class initializer.
1986 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1988 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1989 * configure: Regenerate.
1990 * configure.ac: Don't source common.host.
1991 * gdbsupport/common.host: Remove.
1992 * gdbsupport/mingw-strerror.c: Remove.
1993 * gdbsupport/posix-strerror.c: Rename to...
1994 * gdbsupport/safe-strerror.c: ...this.
1996 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1998 * maint.c (scoped_command_stats::print_time): Use localtime_r
1999 instead of localtime (provided through gnulib if necessary).
2000 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2003 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2005 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2006 avoid compile errors.
2008 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2010 * config.in: Regenerate.
2011 * configure: Regenerate.
2012 * gdbsupport/common.m4: No longer check for strerror_r.
2013 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2014 POSIX version of strerror_r, now that gnulib provides it if
2017 2019-11-14 Christian Biesinger <cbiesinger@google.com>
2019 * README (`configure' options): Update.
2021 2019-11-14 Tom Tromey <tromey@adacore.com>
2023 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2024 expected type for the RHS if the LHS is a convenience variable.
2026 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2028 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2029 Provide explicit default and copy constructor.
2031 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2033 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2034 only call Py_INCREF (newbp) in the bppy_pending_object case.
2036 2019-11-13 Tom Tromey <tromey@adacore.com>
2039 * psympriv.h (partial_symbol): Remove static assert.
2040 * symtab.h (general_symbol_info, symbol): Remove static assert.
2042 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2044 * gdbsupport/format.c (format_pieces::format_pieces): Support
2045 printf 'z' size modifier.
2046 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2047 * printcmd.c (ui_printf): Handle size_t_arg.
2048 * ui-out.c (ui_out::vmessage): Likewise.
2049 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2051 (run_tests): Call test_format_int_sizes.
2053 2019-11-12 Christian Biesinger <cbiesinger@google.com>
2055 * ada-exp.y (write_ambiguous_var): Update.
2056 * buildsym.c (add_symbol_to_list): Update.
2057 * dwarf2read.c (read_variable): Update.
2058 (new_symbol): Update.
2059 * jit.c (finalize_symtab): Update.
2060 * language.c (language_alloc_type_symbol): Update.
2061 * symtab.c (fixup_symbol_section): Update.
2062 (initialize_objfile_symbol_1): Move code to...
2063 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2064 (allocate_symbol): Update.
2065 (allocate_template_symbol): Update.
2066 (get_symbol_address): Update.
2067 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2068 of having as a field, and add a constructor.
2069 (SYMBOL_VALUE): Update.
2070 (SYMBOL_VALUE_ADDRESS): Update.
2071 (SET_SYMBOL_VALUE_ADDRESS): Update.
2072 (SYMBOL_VALUE_BYTES): Update.
2073 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2074 (SYMBOL_BLOCK_VALUE): Update.
2075 (SYMBOL_VALUE_CHAIN): Update.
2076 (SYMBOL_LANGUAGE): Update.
2077 (SYMBOL_SECTION): Update.
2078 (SYMBOL_OBJ_SECTION): Update.
2079 (SYMBOL_SET_LANGUAGE): Update.
2080 (SYMBOL_SET_LINKAGE_NAME): Update.
2081 (SYMBOL_SET_NAMES): Update.
2082 (SYMBOL_NATURAL_NAME): Update.
2083 (SYMBOL_LINKAGE_NAME): Update.
2084 (SYMBOL_DEMANGLED_NAME): Update.
2085 (SYMBOL_SEARCH_NAME): Update.
2086 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2087 (struct symbol): Update.
2088 (struct template_symbol): Update.
2089 (struct rust_vtable_symbol): Update.
2090 * xcoffread.c (SYMBOL_DUP): Update.
2092 2019-11-12 Tom Tromey <tom@tromey.com>
2094 * tui/tui-layout.c (show_layout): Set current_layout.
2095 (show_source_disasm_command, show_data)
2096 (show_source_or_disasm_and_command): Don't set current_layout.
2098 2019-11-12 Tom Tromey <tom@tromey.com>
2100 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2102 2019-11-12 Tom Tromey <tom@tromey.com>
2104 * tui/tui-win.c (resize_message): New global.
2105 (show_tui_resize_message): New function.
2106 (tui_async_resize_screen): Print message if requested.
2107 (_initialize_tui_win): Add tui-resize-message setting.
2108 * NEWS: Add entry for new commands.
2110 2019-11-11 Tom Tromey <tom@tromey.com>
2112 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2115 2019-11-11 Christian Biesinger <cbiesinger@google.com>
2117 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2119 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2121 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2123 * python/python-internal.h (gdbpy_lookup_static_symbols):
2124 Declare new function.
2125 * python/python.c (python_GdbMethods): Add
2126 gdb.lookup_static_symbols method.
2127 * NEWS: Mention gdb.lookup_static_symbols.
2129 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2131 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2132 static block of current object file first. Also fix typo in
2135 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2137 * stack.c (set_last_displayed_sal): Delete.
2138 (last_displayed_sal_valid): Delete.
2139 (last_displayed_pspace): Delete.
2140 (last_displayed_addr): Delete.
2141 (last_displayed_symtab): Delete.
2142 (last_displayed_line): Delete.
2143 (class last_displayed_symtab_info_type): New.
2144 (last_displayed_symtab_info): New static global variable.
2145 (print_frame_info): Call methods on last_displayed_symtab_info.
2146 (clear_last_displayed_sal): Update header comment, and make use of
2147 last_displayed_symtab_info.
2148 (last_displayed_sal_is_valid): Likewise.
2149 (get_last_displayed_pspace): Likewise.
2150 (get_last_displayed_addr): Likewise.
2151 (get_last_displayed_symtab): Likewise.
2152 (get_last_displayed_line): Likewise.
2153 (get_last_displayed_sal): Likewise.
2154 * stack.h (clear_last_displayed_sal): Update header comment.
2155 (last_displayed_sal_is_valid): Likewise.
2156 (get_last_displayed_pspace): Likewise.
2157 (get_last_displayed_addr): Likewise.
2158 (get_last_displayed_symtab): Likewise.
2159 (get_last_displayed_line): Likewise.
2160 (get_last_displayed_sal): Likewise.
2162 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2164 * stack.c (frame_show_address): Convert return type to bool.
2165 * stack.h (frame_show_address): Likewise, and update header
2168 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2170 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2171 * unittests/vec-utils-selftests.c: New file.
2172 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2174 2019-11-10 Tom Tromey <tom@tromey.com>
2176 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2177 (tui_highlight_win): Likewise.
2178 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2179 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2180 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2181 Don't set can_highlight.
2183 2019-11-10 Tom Tromey <tom@tromey.com>
2185 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2186 Remove unused declaration.
2188 2019-11-08 Tom Tromey <tromey@adacore.com>
2190 * top.c (read_command_file): Update.
2191 (command_line_input): Make return type const.
2192 * python/py-gdb-readline.c: Update.
2193 * linespec.c (decode_line_2): Update.
2194 * defs.h (command_line_input): Make return type const.
2195 * cli/cli-script.c (read_next_line): Make return type const.
2196 * ada-lang.c (get_selections): Update.
2198 2019-11-06 Christian Biesinger <cbiesinger@google.com>
2200 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2201 * mi/mi-main.c (output_cores): Likewise.
2202 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2203 (linux_xfer_osdata_modules): Likewise.
2204 * remote.c (register_remote_support_xml): Likewise.
2205 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2206 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2208 2019-11-06 Tom Tromey <tom@tromey.com>
2210 * tui/tui-interp.c: Don't include readline.h.
2211 * tui/tui-hooks.c: Don't include readline.h.
2212 * symmisc.c: Include tilde.h, not readline.h.
2213 * symfile.c: Include tilde.h, not readline.h.
2214 * source.c: Include tilde.h, not readline.h.
2215 * solib.c: Include tilde.h, not readline.h.
2216 * psymtab.c: Include tilde.h, not readline.h.
2217 * exec.c: Include tilde.h, not readline.h.
2218 * corelow.c: Include tilde.h, not readline.h.
2219 * cli/cli-dump.c: Include tilde.h, not readline.h.
2220 * cli/cli-cmds.c: Don't include readline.h.
2222 2019-11-05 Tom Tromey <tom@tromey.com>
2224 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2225 (tui_disassemble): Set addr_size.
2226 (tui_disasm_window::set_contents): Use addr_size.
2228 2019-11-05 Tom Tromey <tom@tromey.com>
2230 * rust-lang.c (rust_language_defn): Update.
2231 * python/py-value.c (valpy_string): Call c_get_string.
2232 * p-lang.c (pascal_language_defn): Update.
2233 * opencl-lang.c (opencl_language_defn): Update.
2234 * objc-lang.c (objc_language_defn): Update.
2235 * m2-lang.c (m2_language_defn): Update.
2236 * language.c (unknown_language_defn, auto_language_defn): Update.
2237 (default_get_string): Remove.
2238 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2239 * go-lang.c (go_language_defn): Update.
2240 * f-lang.c (f_language_defn): Update.
2241 * d-lang.c (d_language_defn): Update.
2242 * c-lang.c (c_language_defn, cplus_language_defn)
2243 (asm_language_defn, minimal_language_defn): Update.
2244 * ada-lang.c (ada_language_defn): Update.
2245 * language.h (struct language_defn) <la_get_string>: Remove.
2246 (LA_GET_STRING): Remove.
2247 (default_get_string): Don't declare.
2249 2019-11-05 Tom Tromey <tom@tromey.com>
2251 * tui/tui-source.h (struct tui_source_window): Inline
2252 constructor. Remove destructor.
2253 <style_changed, m_observable>: Move to superclass.
2254 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2255 (struct tui_source_window_base): Move private members to end.
2256 <style_changed, m_observable>: Move from tui_source_window.
2257 * tui/tui-winsource.c (tui_copy_source_line): Move from
2258 tui-source.c. Rename from copy_source_line. Add special handling
2259 for negative line number.
2260 (tui_source_window_base::style_changed): Move from
2262 (tui_source_window_base): Register observer.
2263 (~tui_source_window_base): New.
2264 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2266 (tui_source_window::set_contents): Use tui_copy_source_line.
2267 (tui_source_window::tui_source_window): Move to tui-source.h.
2268 (tui_source_window::~tui_source_window): Remove.
2269 (tui_source_window::style_changed): Move to superclass.
2270 * tui/tui-disasm.c (tui_disassemble): Create string file with
2271 styling, when possible. Add "addr_size" parameter.
2272 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2273 Don't compute maximum size.
2274 (len_without_escapes): New function
2276 2019-11-05 Tom Tromey <tom@tromey.com>
2278 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2280 * tui/tui-winsource.c (tui_show_source_line): Update.
2281 * tui/tui-source.c (tui_source_window::set_contents): Update.
2282 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2284 2019-11-05 Christian Biesinger <cbiesinger@google.com>
2286 * symtab.h (gdb_static_assert): Put && operator at the beginning
2287 of the line instead of the end.
2289 2019-11-04 Christian Biesinger <cbiesinger@google.com>
2291 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2292 and sizeof (symbol).
2293 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2295 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2297 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2298 * configure.host: Mark *-*-solaris2.10* obsolete.
2299 * configure.tgt: Mark Solaris < 11 obsolete.
2300 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2301 Update target triplet.
2303 2019-11-01 Tom Tromey <tromey@adacore.com>
2305 * utils.c (print_sys_errmsg): Simplify.
2307 2019-11-01 Tom Tromey <tromey@adacore.com>
2309 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2311 2019-11-01 Christian Biesinger <cbiesinger@google.com>
2313 * configure: Regenerate.
2314 * configure.ac: Remove check for strerror_r.
2315 * gdbsupport/common.m4: Check for strerror_r.
2317 2019-11-01 Luis Machado <luis.machado@linaro.org>
2321 * arm-tdep.c (arm_per_objfile): Rename to ...
2322 (arm_per_bfd): ... this.
2323 (arm_objfile_data_key): Rename to ...
2324 (arm_bfd_data_key): ... this.
2325 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2327 (arm_record_special_symbol): Likewise.
2329 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2331 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2333 * c-typeprint.c (c_print_typedef): Likewise.
2334 * f-typeprint.c (f_print_typedef): Likewise.
2335 * m2-typeprint.c (m2_print_typedef): Likewise.
2336 * p-typeprint.c (pascal_print_typedef): Likewise.
2337 * rust-lang.c (rust_print_typedef): Likewise.
2338 * symtab.c (print_symbol_info): Print a newline after calling
2341 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2343 * symtab.c (info_module_cmdlist): New variable.
2344 (info_module_command): New function.
2345 (search_module_symbols): New function.
2346 (info_module_subcommand): New function.
2347 (struct info_modules_var_func_options): New struct.
2348 (info_modules_var_func_options_defs): New variable.
2349 (make_info_modules_var_func_options_def_group): New function.
2350 (info_module_functions_command): New function.
2351 (info_module_variables_command): New function.
2352 (info_module_var_func_command_completer): New function.
2353 (_initialize_symtab): Register new 'info module functions' and
2354 'info module variables' commands.
2355 * symtab.h (typedef symbol_search_in_module): New typedef.
2356 (search_module_symbols): Declare new function.
2357 * NEWS: Mention new commands.
2359 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2361 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2362 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2363 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2365 (scan_partial_symbols): Only create partial module symbols for non
2367 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2369 * symtab.c (search_domain_name): Likewise.
2370 (search_symbols): Likewise.
2371 (print_symbol_info): Likewise.
2372 (symtab_symbol_info): Likewise.
2373 (info_modules_command): New function.
2374 (_initialize_symtab): Register 'info modules' command.
2375 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2376 * NEWS: Mention new 'info modules' command.
2378 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2380 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2381 and $_gdb_maint_setting_str.
2383 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2385 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2386 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2387 (str_value_from_setting, gdb_setting_str_internal_fn)
2388 (gdb_maint_setting_str_internal_fn): New functions.
2389 (_initialize_cli_cmds): Define the new convenience functions.
2390 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2391 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2393 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2395 * agent.c (set_can_use_agent): When the setting is turned on,
2396 look up agent symbols if we don't have them yet.
2397 (agent_new_objfile): Don't look up agent symbols when the agent
2400 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2402 * config.in: Regenerate.
2404 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2406 * configure: Regenerate.
2407 * configure.ac: Check for strerror_r.
2408 * gdbsupport/common-utils.h (safe_strerror): Change return value
2409 to const char * and document that this function is now threadsafe.
2410 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2411 thread_local and call strerror_r, if available.
2412 * utils.c (perror_string): Update.
2413 (print_sys_errmsg): Update.
2415 2019-10-31 Luis Machado <luis.machado@linaro.org>
2417 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2419 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2420 objfile to fetch per-bfd data.
2421 (arm_find_exidx_entry): Likewise.
2423 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2425 * gdbsupport/agent.c (debug_agent): Change type to bool.
2426 (use_agent): Likewise.
2427 (all_agent_symbols_look_up): Likewise.
2428 (agent_loaded_p): Change return value to bool.
2429 (agent_look_up_symbols): Update.
2430 (agent_capability_check): Change return value to bool.
2431 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2432 (debug_agent): Change type to bool.
2433 (use_agent): Likewise.
2434 (agent_capability_check): Change return value to bool.
2436 2019-10-30 Christian Biesinger <cbiesinger@google.com>
2438 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2439 (build_minimal_symbol_hash_tables): Code to clear the table moved
2440 to clear_minimal_symbol_hash_tables.
2441 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2444 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2446 * infcmd.c: Remove includes.
2447 * infrun.c: Remove includes.
2449 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2451 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2452 (grow_vect): Remove declaration.
2453 (ada_type_of_array): Remove declaration.
2454 (ada_update_initial_language): Remove declaration.
2455 (ada_fold_name): Remove declaration.
2456 (ada_fill_in_ada_prototype): Remove declaration.
2457 (user_select_syms): Remove declaration.
2458 (get_selections): Remove declaration.
2459 (ada_tag_type): Remove declaration.
2460 (ada_value_tag): Remove declaration.
2461 (ada_is_others_clause): Remove declaration.
2462 (ada_in_variant): Remove declaration.
2463 (ada_value_struct_elt): Remove declaration.
2464 (ada_attribute_name): Remove declaration.
2465 (ada_system_address_type): Remove declaration.
2466 * ada-lang.c (ada_watch_location_expression): Make static.
2467 (GROW_VECT): Move here from ada-lang.h.
2468 (grow_vect): Make static.
2469 (ada_update_initial_language): Make static.
2470 (ada_fold_name): Make static.
2471 (ada_type_of_array): Make static.
2472 (encoded_ordered_before): Move up.
2473 (sort_choices): Move up.
2474 (print_signatures): Move up.
2475 (ada_print_symbol_signature): Move up.
2476 (get_selections): Move up and make static.
2477 (user_select_syms): Move up and make static.
2478 (ada_value_struct_elt): Move up and make static.
2479 (ada_tag_type): Make static.
2480 (ada_value_tag): Make static.
2481 (ada_is_others_clause): Make static.
2482 (ada_in_variant): Make static.
2483 (ada_attribute_name): Make static.
2485 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2487 * ada-lang.c: Remove includes.
2488 * ada-typeprint.c: Remove includes.
2489 * ada-valprint.c: Remove includes.
2491 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
2493 * addrmap.c: Add static assertions of type size, moved from
2494 _initialize_addrmap.
2495 (_initialize_addrmap): Remove.
2497 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2499 * coffread.c (record_minimal_symbol): Update.
2500 (process_coff_symbol): Update.
2501 * dbxread.c (read_dbx_symtab): Update.
2502 * dwarf2read.c (add_partial_symbol): Update.
2503 (fixup_go_packaging): Update.
2504 (load_partial_dies): Update.
2505 (new_symbol): Update.
2506 * elfread.c (record_minimal_symbol): Change signature to use
2507 gdb::string_view instead of name+len.
2508 (elf_symtab_read): Update.
2509 (elf_rel_plt_read): Update.
2510 * mdebugread.c (parse_partial_symbols): Update.
2511 (handle_psymbol_enumerators): Update.
2512 (new_symbol): Update.
2513 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2514 to use gdb::string_view instead of name+len.
2515 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2516 * psympriv.h (add_psymbol_to_list): Likewise.
2517 * psymtab.c (add_psymbol_to_bcache): Likewise.
2518 (add_psymbol_to_list): Likewise.
2519 * stabsread.c (define_symbol): Update.
2520 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2521 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2522 (symbol_set_names): Likewise.
2523 * xcoffread.c (scan_xcoff_symtab): Update.
2525 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2527 * symtab.h (symbol_set_names): Document that copy_name must be
2528 set to true for non-nullterminated strings.
2529 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2530 linkage_name if the entry was not found and we need to demangle.
2532 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2534 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2535 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2536 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2537 * gdbsupport/gdb_binary_search.h: New file.
2539 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2541 * NEWS: Mention new --with-system-gdbinit-dir option.
2542 * config.in: Regenerate.
2543 * configure: Regenerate.
2544 * configure.ac: Add new option --with-system-gdbinit-dir.
2545 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2546 for a ".gdb" suffix.
2547 * main.c (get_init_files): Change system_gdbinit argument to
2548 a vector and return the files in SYSTEM_GDBINIT_DIR in
2549 addition to SYSTEM_GDBINIT.
2550 (captured_main_1): Update.
2551 (print_gdb_help): Update.
2552 * top.c (print_gdb_configuration): Also print the value of
2555 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2557 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2558 that takes gdb::string_view arguments.
2560 2019-10-26 Tom de Vries <tdevries@suse.de>
2562 * aarch64-linux-tdep.c: Fix typos in comments.
2563 * aarch64-tdep.c: Same.
2565 * amd64-nat.c: Same.
2567 * arch/aarch64-insn.c: Same.
2569 * breakpoint.h: Same.
2572 * cli/cli-decode.c: Same.
2573 * cli/cli-script.c: Same.
2574 * cli/cli-utils.h: Same.
2575 * coff-pe-read.c: Same.
2577 * compile/compile-cplus-symbols.c: Same.
2578 * compile/compile-object-run.c: Same.
2579 * completer.c: Same.
2581 * cp-support.c: Same.
2583 * dwarf-index-write.c: Same.
2584 * dwarf2-frame.c: Same.
2585 * dwarf2-frame.h: Same.
2587 * frame-base.h: Same.
2592 * guile/scm-objfile.c: Same.
2593 * i386-tdep.c: Same.
2594 * i386-tdep.h: Same.
2597 * linux-nat.c: Same.
2598 * m68k-tdep.c: Same.
2601 * mi/mi-cmd-disas.c: Same.
2602 * mi/mi-getopt.h: Same.
2603 * mi/mi-main.c: Same.
2605 * nat/aarch64-sve-linux-sigcontext.h: Same.
2607 * ppc-linux-nat.c: Same.
2608 * ppc-linux-tdep.c: Same.
2610 * progspace.h: Same.
2611 * prologue-value.h: Same.
2612 * python/py-evtregistry.c: Same.
2613 * python/py-instruction.h: Same.
2614 * record-btrace.c: Same.
2615 * record-full.c: Same.
2617 * rs6000-tdep.c: Same.
2619 * sol-thread.c: Same.
2620 * sparc-sol2-tdep.c: Same.
2621 * sparc64-tdep.c: Same.
2622 * stabsread.c: Same.
2626 * tracepoint.c: Same.
2627 * tui/tui-data.h: Same.
2628 * tui/tui-io.c: Same.
2629 * tui/tui-win.c: Same.
2631 * unittests/rsp-low-selftests.c: Same.
2632 * user-regs.h: Same.
2643 * xtensa-tdep.c: Same.
2645 2019-10-25 Ali Tamur <tamur@google.com>
2647 * charset.c (find_charset_names): Reflect API change.
2649 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2651 * symtab.c (struct demangled_name_entry): Change demangled name
2652 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2653 part of the struct anymore.
2654 (symbol_set_names): No longer obstack allocate + copy the demangled
2655 name, just store the allocated name from bfd.
2657 2019-10-25 Tom Tromey <tromey@adacore.com>
2659 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2660 (bsearch_cie_cmp, add_cie): Remove.
2661 (find_cie): Reimplement.
2662 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2663 (dwarf2_build_frame_info): Update.
2665 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2668 * symfile.c (reread_symbols): Call forget_cached_source_info to
2669 clear the stale source cache.
2671 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2673 * configure: Regenerate.
2674 * configure.ac: Remove code that sets python_has_threads.
2676 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2678 * config.in: Regenerate.
2679 * configure: Regenerate.
2680 * configure.ac: Remove the code that uses sed to get the python
2681 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2683 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2685 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2688 2019-10-23 Tom Tromey <tom@tromey.com>
2690 * arc-tdep.c: Remove ".." from include.
2691 * frv-tdep.c: Remove ".." from include.
2692 * lm32-tdep.c: Remove ".." from include.
2693 * microblaze-tdep.c: Remove ".." from include.
2694 * or1k-tdep.h: Remove ".." from include.
2695 * s12z-tdep.c: Remove ".." from include.
2696 * Makefile.in (OPCODES_CFLAGS): Add comment.
2697 (TOP_CFLAGS): New variable.
2698 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2700 2019-10-23 Tom Tromey <tom@tromey.com>
2702 * Makefile.in (READLINE_DIR): Update.
2704 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2706 * infcall.c (call_function_by_hand_dummy): Fix the function
2707 comment. And extract out a code section into...
2708 (reserve_stack_space): ...this new function.
2710 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2712 * infcall.c (value_arg_coerce): Remove an unused parameter.
2713 (call_function_by_hand_dummy): Update the call to
2716 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2718 * infcall.c (call_function_by_hand_dummy): Refactor.
2720 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2722 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2724 2019-10-23 Tom Tromey <tom@tromey.com>
2726 * configure: Rebuild.
2727 * configure.ac: Don't check for sigprocmask.
2728 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2730 2019-10-23 Tom Tromey <tom@tromey.com>
2732 * configure: Rebuild.
2733 * acinclude.m4: Use m4_include, not sinclude.
2735 2019-10-23 Tom de Vries <tdevries@suse.de>
2737 PR breakpoints/24687
2738 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2740 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2742 * symtab.c (struct demangled_name_entry) <language>: Change from
2743 bitfield to regular variable.
2745 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2747 * symtab.c (struct demangled_name_entry): Add a constructor.
2748 (free_demangled_name_entry): New function to call the destructor
2749 for demangled_name_entry.
2750 (create_demangled_names_hash): Pass free_demangled_name_entry to
2752 (symbol_set_names): Call placement new for demangled_name_entry.
2753 * utils.c: No longer include xxhash.h here, now that fast_hash
2754 is inlined in the header.
2755 * utils.h: Instead, include it here.
2757 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2759 * Makefile.in: Link with libxxhash.
2760 * config.in: Regenerate.
2761 * configure: Regenerate.
2762 * configure.ac: Search for libxxhash.
2763 * utils.c (fast_hash): Use xxhash if present.
2765 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2767 * utils.h (fast_hash): New function.
2768 * symtab.c (hash_demangled_name_entry): Call new function
2771 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2773 * symtab.c (struct demangled_name_entry): Change type of mangled
2774 to gdb::string_view. Also adds a constructor that takes the
2776 (hash_demangled_name_entry): Update.
2777 (eq_demangled_name_entry): Update.
2778 (free_demangled_name_entry): New function to call the destructor
2779 now that this is not a POD anymore.
2780 (create_demangled_names_hash): Pass free_demangled_name_entry to
2782 (symbol_set_names): Update.
2784 2019-10-21 Ali Tamur <tamu@google.com>
2786 * dwarf2read.c (dir_index): Change type.
2787 (file_name_index): Likewise.
2788 (line_header::include_dir_at): Change comment and implementation on
2789 whether it is DWARF 5.
2790 (line_header::is_valid_file_index): New function.
2791 (line_header::file_name_at): Change comment and implementation on
2792 whether it is DWARF 5.
2793 (line_header::file_names): Change to private field renamed as
2794 m_file_names and introduce a new accessor method.
2795 (line_header::file_names_size): New method.
2796 (line_header::include_dirs): Change to private field and rename as
2798 (dw2_get_file_names_reader): Define local var at a smaller scope and
2800 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2801 (process_structure_scope): Likewise.
2802 (line_header::add_include_dir): Change message and reflect renaming.
2803 (line_header::add_file_name): Likewise.
2804 (read_formatted_entries): Handle DW_FORM_data16.
2805 (dwarf_decode_line_header): Fix line header length calculation.
2806 (psymtab_include_file_name): Change comment and API.
2807 (lnp_state_machine::m_file): Update comment and reflect type change.
2808 (lnp_state_machine::record_line): Reflect type change.
2809 (dwarf_decode_lines): Reflect API change.
2810 (file_file_name): Likewise.
2811 (file_full_name): Likewise.
2813 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2815 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2817 2019-10-21 Tom Tromey <tom@tromey.com>
2819 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2821 2019-10-21 Tom Tromey <tom@tromey.com>
2823 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2824 NM_H. Use AC_CONFIG_LINKS.
2825 * configure: Rebuild.
2826 * Makefile.in (NM_H): New variable.
2827 (generated_files): Add NM_H. Remove gcore.
2828 (nm.h, stamp-nmh): New targets.
2830 2019-10-20 Tom Tromey <tom@tromey.com>
2832 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2833 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2835 (put_objfile_before): Now static.
2837 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2839 * gdbsupport/common-utils.h (startswith): Change return type to
2842 2019-10-19 Christian Biesinger <cbiesinger@google.com>
2844 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2845 * breakpoint.c (bp_locations_compare): Rename to...
2846 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2847 (update_global_location_list): Use std::sort instead of qsort.
2848 * buildsym.c (compare_line_numbers): Rename to...
2849 (lte_is_less_than): ...this, and change to std::sort semantics.
2850 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2852 * disasm.c (compare_lines): Rename to...
2853 (line_is_less_than): ...this, and change to std::sort semantics.
2854 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2856 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2857 (fde_is_less_than): ...this, and change to std::sort semantics.
2858 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2859 * mdebugread.c (compare_blocks):
2860 (block_is_less_than): ...this, and change to std::sort semantics.
2861 (sort_blocks): Call std::sort instead of qsort.
2862 * objfiles.c (qsort_cmp): Rename to...
2863 (sort_cmp): ...this, and change to std::sort semantics.
2864 (update_section_map): Call std::sort instead of qsort.
2865 * remote.c (compare_pnums): Remove.
2866 (map_regcache_remote_table): Call std::sort instead of qsort.
2867 * utils.c (compare_positive_ints): Remove.
2868 * utils.h (compare_positive_ints): Remove.
2869 * xcoffread.c (compare_lte): Remove.
2870 (arrange_linetable): Call std::sort instead of qsort.
2872 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2874 * symfile.c (init_entry_point_info): Fix typo.
2875 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2877 2019-10-18 Tom de Vries <tdevries@suse.de>
2879 * aarch64-tdep.c: Fix typos in comments.
2881 * ada-tasks.c: Same.
2882 * alpha-tdep.c: Same.
2883 * alpha-tdep.h: Same.
2884 * amd64-nat.c: Same.
2885 * amd64-windows-tdep.c: Same.
2888 * arch-utils.c: Same.
2889 * arm-nbsd-tdep.c: Same.
2892 * blockframe.c: Same.
2895 * coff-pe-read.c: Same.
2897 * cris-tdep.c: Same.
2898 * darwin-nat.c: Same.
2902 * dtrace-probe.c: Same.
2903 * dwarf-index-write.c: Same.
2904 * dwarf2-frame-tailcall.c: Same.
2905 * dwarf2-frame.c: Same.
2906 * dwarf2read.c: Same.
2908 * exceptions.c: Same.
2909 * fbsd-tdep.c: Same.
2913 * gnu-v3-abi.c: Same.
2915 * h8300-tdep.c: Same.
2916 * hppa-tdep.c: Same.
2917 * i386-linux-tdep.c: Same.
2918 * i386-tdep.c: Same.
2919 * ia64-libunwind-tdep.c: Same.
2920 * ia64-tdep.c: Same.
2924 * linux-nat.c: Same.
2925 * linux-thread-db.c: Same.
2926 * machoread.c: Same.
2927 * mdebugread.c: Same.
2929 * mn10300-tdep.c: Same.
2930 * namespace.c: Same.
2932 * opencl-lang.c: Same.
2933 * or1k-tdep.c: Same.
2935 * ppc-linux-nat.c: Same.
2936 * ppc-linux-tdep.c: Same.
2937 * ppc-sysv-tdep.c: Same.
2940 * record-btrace.c: Same.
2941 * record-full.c: Same.
2942 * remote-fileio.c: Same.
2944 * rs6000-tdep.c: Same.
2945 * s12z-tdep.c: Same.
2946 * score-tdep.c: Same.
2950 * sol-thread.c: Same.
2951 * solib-svr4.c: Same.
2954 * sparc-nat.c: Same.
2955 * sparc-sol2-tdep.c: Same.
2956 * sparc-tdep.c: Same.
2957 * sparc64-tdep.c: Same.
2958 * stabsread.c: Same.
2962 * target-descriptions.c: Same.
2963 * target-float.c: Same.
2970 * windows-nat.c: Same.
2971 * xcoffread.c: Same.
2972 * xstormy16-tdep.c: Same.
2973 * xtensa-tdep.c: Same.
2975 2019-10-17 Tom Tromey <tromey@adacore.com>
2977 * configure: Rebuild.
2978 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2979 in AC_CONFIG_FILES invocation.
2980 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2981 new-style config.status invocation.
2983 2019-10-17 Tom de Vries <tdevries@suse.de>
2985 * arm-nbsd-nat.c: Fix typos in comments.
2987 * darwin-nat-info.c: Same.
2988 * dwarf2read.c: Same.
2990 * event-top.c: Same.
2993 * hppa-tdep.c: Same.
2994 * i386-tdep.c: Same.
2997 * mdebugread.c: Same.
2998 * moxie-tdep.c: Same.
2999 * nto-procfs.c: Same.
3001 * ppc-linux-tdep.c: Same.
3003 * riscv-tdep.c: Same.
3004 * s390-tdep.c: Same.
3006 * sparc-linux-tdep.c: Same.
3007 * sparc-nat.c: Same.
3009 * target-descriptions.c: Same.
3013 2019-10-16 Tom Tromey <tom@tromey.com>
3015 * objfiles.h (struct objfile) <original_name>: Now const.
3017 2019-10-16 Christian Biesinger <cbiesinger@google.com>
3019 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3020 pass on to sigsetjmp's second argument.
3021 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3023 2019-10-16 Keith Seitz <keiths@redhat.com>
3026 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3027 sections whose size is greater than the file size.
3029 2019-10-16 Jim Wilson <jimw@sifive.com>
3031 * riscv-tdep.c (riscv_gcc_target_options): New.
3032 (riscv_gnu_triplet_regexp): New.
3033 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3034 set_gdbarch_gnu_triplet_regexp.
3036 2019-10-16 Christian Biesinger <cbiesinger@google.com>
3038 * Makefile.in: Add xml-builtin.h.
3039 * features/feature_to_c.sh: Add an include for xml-builtin.h
3040 to ensure that the compiler checks that the types match.
3041 * xml-builtin.h: New file.
3042 * xml-support.c (fetch_xml_builtin): Add missing const.
3043 * xml-support.h: Remove declaration of xml_builtins.
3045 2019-10-16 Tom de Vries <tdevries@suse.de>
3048 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3049 (amd64_classify_aggregate): ... here.
3050 (amd64_classify_aggregate_field): Handled fiels of nested structs
3053 2019-10-16 Tom de Vries <tdevries@suse.de>
3056 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3057 that handles 'theclass'.
3059 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3061 * linespec.c (decode_digits_ordinary): Update comment.
3062 * make-target-delegates: No longer need to handle VEC case.
3063 * memrange.c (normalize_mem_ranges): Update comment.
3064 * namespace.c (add_using_directive): Update comment.
3065 * objc-lang.c (uniquify_strings): Update comment.
3066 * ppc-linux-nat.c (struct thread_points): Update comment.
3067 * probe.h (find_probes_in_objfile): Update comment.
3068 * target.h (enum flash_preserve_mode): Update comment.
3069 * varobj.c (varobj_restrict_range): Update comment.
3070 * varobj.h (varobj_list_children): Update comment.
3072 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3074 * Makefile.in: Remove references to vec.h and vec.c.
3075 * aarch64-tdep.c: No longer include vec.h.
3076 * ada-lang.c: Likewise.
3077 * ada-lang.h: Likewise.
3078 * arm-tdep.c: Likewise.
3080 * breakpoint.h: Likewise.
3081 * charset.c: Likewise.
3082 * cp-support.h: Likewise.
3083 * dtrace-probe.c: Likewise.
3084 * dwarf2read.c: Likewise.
3085 * extension.h: Likewise.
3086 * gdb_bfd.c: Likewise.
3087 * gdbsupport/gdb_vecs.h: Likewise.
3088 * gdbsupport/vec.c: Remove.
3089 * gdbsupport/vec.h: Remove.
3090 * gdbthread.h: Likewise.
3091 * guile/scm-type.c: Likewise.
3092 * inline-frame.c: Likewise.
3093 * machoread.c: Likewise.
3094 * memattr.c: Likewise.
3095 * memrange.h: Likewise.
3096 * namespace.h: Likewise.
3097 * nat/linux-btrace.h: Likewise.
3098 * osdata.c: Likewise.
3099 * parser-defs.h: Likewise.
3100 * progspace.h: Likewise.
3101 * python/py-type.c: Likewise.
3102 * record-btrace.c: Likewise.
3103 * rust-exp.y: Likewise.
3104 * solib-target.c: Likewise.
3105 * stap-probe.c: Likewise.
3106 * target-descriptions.c: Likewise.
3107 * target-memory.c: Likewise.
3108 * target.h: Likewise.
3109 * varobj.c: Likewise.
3110 * varobj.h: Likewise.
3111 * xml-support.h: Likewise.
3113 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3115 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3116 Update for new std::vector based implementation.
3117 (process_psymtab_comp_unit_reader): Likewise.
3118 (scan_partial_symbols): Likewise.
3119 (recursively_compute_inclusions): Likewise.
3120 (compute_compunit_symtab_includes): Likewise.
3121 (process_imported_unit_die): Likewise.
3122 (queue_and_load_dwo_tu): Likewise.
3123 (follow_die_sig_1): Likewise.
3124 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3125 (typedef dwarf2_per_cu_ptr): Remove.
3126 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3128 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3129 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3130 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3131 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3134 2019-10-15 Tom Tromey <tromey@adacore.com>
3136 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3139 2019-10-15 Tom Tromey <tromey@adacore.com>
3141 * windows-nat.c (windows_nat_target::fetch_registers)
3142 (windows_nat_target::store_registers): Rename "pid" to "tid".
3144 2019-10-15 Tom Tromey <tromey@adacore.com>
3146 * gdbarch.h, gdbarch.c: Rebuild.
3147 * gdbarch.sh (gcc_target_options): Change return type to
3149 * compile/compile.c (get_args): Update.
3150 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3151 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3153 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3155 * arch-utils.c (default_gcc_target_options): Return std::string.
3156 * arch-utils.h (default_gcc_target_options): Return std::string.
3157 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3159 2019-10-15 Christian Biesinger <cbiesinger@google.com>
3161 * breakpoint.c (breakpoint_chain): Make static.
3162 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3163 of accessing breakpoint_chain.
3165 2019-10-15 Christian Biesinger <cbiesinger@google.com>
3167 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3168 to a gdb::function_view and return value to bool.
3169 * breakpoint.h (iterate_over_breakpoints): Likewise.
3170 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3171 (pop_dummy_frame): Update.
3172 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3173 (gdbscm_breakpoints): Update.
3174 * python/py-breakpoint.c (build_bp_list): Update.
3175 (gdbpy_breakpoints): Update.
3176 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3178 (bpfinishpy_handle_stop): Update.
3179 (bpfinishpy_handle_exit): Update.
3180 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3181 (svr4_update_solib_event_breakpoints): Update.
3183 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3185 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3186 when unwrapping single-field structs.
3188 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3190 * dwarf2read.c: Remove includes.
3192 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3194 * ui-out.c (ui_out::call_do_message): Silence
3195 -Wformat-nonliteral warning.
3197 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3199 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3200 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3201 include: readline/tilde.h.
3203 2019-10-12 Christian Biesinger <cbiesinger@google.com>
3205 * remote.c (remote_target::get_trace_status): Remove declaration of
3206 trace_regblock_size.
3208 2019-10-12 Christian Biesinger <cbiesinger@google.com>
3210 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3211 (show_user): Remove declaration of cmdlist.
3212 * cli/cli-cmds.h (max_user_call_depth): Declare.
3213 * cli/cli-script.c (execute_user_command): Remove declaration
3214 of max_user_call_depth.
3216 2019-10-11 Jim Wilson <jimw@sifive.com>
3218 * gdbsupport/print-utils.h (pulongest): Fix comment.
3219 (plongest): Likewise.
3220 (phex): Add missing comment, mention leading zeros.
3221 (phex_nz): Add mention of no leading zeros to comment.
3223 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3224 plongest instead of unsigned long long cast.
3226 2019-10-10 Christian Biesinger <cbiesinger@google.com>
3228 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3229 for external_editor_command and gdbtk_test.
3231 2019-10-10 Christian Biesinger <cbiesinger@google.com>
3233 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3234 * varobj.c (varobjdebug): Move comment to...
3235 * varobj.h (varobjdebug): ...here, and declare.
3237 2019-10-09 Tom Tromey <tom@tromey.com>
3239 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3242 2019-10-09 Tom Tromey <tom@tromey.com>
3244 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3245 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3246 * tui/tui-command.c (tui_cmd_window::resize)
3247 (tui_refresh_cmd_win): Update.
3248 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3249 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3250 * tui/tui-data.c (~tui_gen_win_info): Remove.
3251 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3252 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3253 (tui_redisplay_readline, tui_mld_flush)
3254 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3255 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3256 (tui_data_window::erase_data_content)
3257 (tui_data_item_window::rerender)
3258 (tui_data_item_window::refresh_window): Update.
3259 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3260 (box_win, tui_gen_win_info::make_window)
3261 (tui_gen_win_info::make_visible): Update.
3262 (tui_delete_win): Remove.
3263 * tui/tui-winsource.c
3264 (tui_source_window_base::do_erase_source_content): Update.
3265 (tui_show_source_line, tui_source_window_base::update_tab_width)
3266 (tui_source_window_base::update_exec_info): Update.
3267 * tui/tui-data.h (struct curses_deleter): New.
3268 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3269 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3271 2019-10-09 Tom Tromey <tom@tromey.com>
3273 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3275 2019-10-09 Tom Tromey <tom@tromey.com>
3277 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3278 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3280 2019-10-09 Tom Tromey <tom@tromey.com>
3282 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3283 window height directly.
3284 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3286 * tui/tui-layout.c (tui_default_win_height): Remove.
3287 (tui_default_win_viewport_height): Remove.
3289 2019-10-09 Tom Tromey <tom@tromey.com>
3291 * tui/tui.h: Remove comments.
3293 2019-10-09 Tom de Vries <tdevries@suse.de>
3295 * python/lib/gdb/printer/bound_registers.py: Use
3296 '^builtin_type_bound128' as regexp argument for
3297 add_builtin_pretty_printer.
3299 2019-10-09 Christian Biesinger <cbiesinger@google.com>
3301 * guile/guile.c (guile_extension_script_ops): Remove forward
3302 declaration and mark as static.
3303 (guile_script_ops): Likewise.
3304 (extension_language_guile): Move further down in the file so
3305 it can reference the definitions for guile_{extension_,}script_ops.
3307 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3309 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3310 except SORTL, DFLTCC, and KDSA.
3312 2019-10-08 Tom Tromey <tromey@adacore.com>
3314 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3315 (struct safe_symbol_file_add_args): Remove.
3317 2019-10-08 Tom Tromey <tromey@adacore.com>
3319 * windows-nat.c: Don't include buildsym-legacy.h.
3321 2019-10-08 Tom Tromey <tromey@adacore.com>
3323 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3325 2019-10-08 Christian Biesinger <cbiesinger@google.com>
3327 * gdbtypes.c (overload_debug): Move comment to header.
3328 * gdbtypes.h (overload_debug): Declare.
3329 * valops.c: Remove declaration of overload_debug, instead
3332 2019-10-08 Christian Biesinger <cbiesinger@google.com>
3334 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3336 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3338 * language.h (lang_frame_mismatch_warn): ... here. Also add
3340 * top.c (lang_frame_mismatch_warn): Remove declaration.
3341 (check_frame_language_change): Pass lang_frame_mismatch_warn
3344 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3346 * c-lang.h (vtbl_ptr_name): Declare.
3347 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3349 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3351 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3353 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3356 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3358 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3359 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3360 * ctfread.c: New file.
3361 * ctfread.h: New file.
3362 * elfread.c: Include ctfread.h.
3363 (struct elfinfo text_p): New member ctfsect.
3364 (elf_locate_sections): Mark CTF section.
3365 (elf_symfile_read): Call elfctf_build_psymtabs.
3366 * Makefile.in (LIBCTF): Add.
3369 (DIST): Add ctfread.c.
3371 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3373 * ctfread.c (struct nextfield): Renamed to ...
3374 (struct ctf_nextfield): ... this.
3375 (struct field_info): Renamed to ...
3376 (strut ctf_field_info): ... this.
3377 (attach_fields_to_type): Update for renamed structures.
3378 (ctf_add_member_cb): Likewise.
3379 (ctf_add_enum_member_cb): Likewise.
3380 (process_struct_members): Likewise.
3381 (process_enum_type): Likewise.
3383 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3385 * tracectf.h: Rename, was ctf.h.
3386 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3387 * tracefile.c: Likewise.
3388 * tracepoint.c: Remove unused include ctf.h.
3389 * mi/mi-main.c: Likewise.
3390 * Makefile.in Replace ctf.c with tracectf.c.
3392 2019-10-06 Joel Brobecker <brobecker@adacore.com>
3394 * version.in: Change version number to "9.0.50.DATE-git".
3396 2019-10-03 Tom Tromey <tom@tromey.com>
3399 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3401 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3403 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3404 cp_search_name_hash.
3405 * NEWS: Add entry about nested function support.
3407 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3408 Andrew Burgess <andrew.burgess@embecosm.com>
3410 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3411 for nested static variables when searchin VAR_DOMAIN.
3412 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3413 global scope, update comment.
3414 (add_partial_subprogram): Call add_partial_subprogram recursively
3415 for nested subroutines when processinng Fortran.
3416 (load_partial_dies): Process the child entities of a subprogram
3417 when processing Fortran.
3418 (partial_die_parent_scope): Handle building scope
3419 for Fortran nested functions.
3420 (process_die): Record that nested functions have a scope.
3421 (new_symbol): Always record Fortran subprograms on the global
3423 (determine_prefix): How to build the prefix for Fortran
3426 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3428 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3429 have just sent the thread a SIGSTOP and are waiting for it to
3432 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3434 * btrace.c (btrace_add_pc): Remove whitespace before the template
3435 parameter in 'std::vector <...>'.
3436 (parse_xml_btrace_block): Likewise.
3437 (btrace_maint_decode_pt): Likewise.
3438 (btrace_maint_update_packets): Likewise.
3439 (btrace_maint_print_packets): Likewise.
3440 * btrace.h (struct btrace_maint_info): Likewise.
3441 * dwarf2read.c (struct type_unit_group): Likewise.
3442 (build_type_psymtabs_reader): Likewise.
3443 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3444 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3445 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3447 2019-10-03 Tom de Vries <tdevries@suse.de>
3449 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3450 the first line of the help text for set/show style metadata.
3452 2019-10-02 Tom Tromey <tromey@adacore.com>
3454 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3455 * gdbsupport/common-inferior.c: New file.
3456 * infcmd.c (startup_with_shell): Don't define.
3457 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3458 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3459 * inferior.h (startup_with_shell): Don't declare.
3461 2019-10-02 Christian Biesinger <cbiesinger@google.com>
3463 * gdbsupport/gdb_assert.h: Include errors.h.
3464 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3466 2019-10-02 Tom Tromey <tromey@adacore.com>
3468 * NEWS: Add $_ada_exception entry.
3469 * ada-lang.c (struct ada_catchpoint): Add constructor.
3470 <m_kind>: New member.
3471 (allocate_location_exception, re_set_exception): Remove
3473 (should_stop_exception): Compute $_ada_exception.
3474 (check_status_exception, print_it_exception)
3475 (print_one_exception, print_mention_exception): Remove
3477 (allocate_location_catch_exception, re_set_catch_exception)
3478 (check_status_exception, print_it_catch_exception)
3479 (print_one_catch_exception, print_mention_catch_exception)
3480 (print_recreate_catch_exception)
3481 (allocate_location_catch_exception_unhandled)
3482 (re_set_catch_exception_unhandled)
3483 (check_status_exception, print_it_catch_exception_unhandled)
3484 (print_one_catch_exception_unhandled)
3485 (print_mention_catch_exception_unhandled)
3486 (print_recreate_catch_exception_unhandled)
3487 (allocate_location_catch_assert, re_set_catch_assert)
3488 (check_status_assert, print_it_catch_assert)
3489 (print_one_catch_assert, print_mention_catch_assert)
3490 (print_recreate_catch_assert)
3491 (allocate_location_catch_handlers, re_set_catch_handlers)
3492 (check_status_handlers, print_it_catch_handlers)
3493 (print_one_catch_handlers, print_mention_catch_handlers)
3494 (print_recreate_catch_handlers): Remove.
3495 (create_ada_exception_catchpoint): Update.
3496 (initialize_ada_catchpoint_ops): Update.
3498 2019-10-02 Tom Tromey <tromey@adacore.com>
3500 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3501 (create_excep_cond_exprs): Simplify exception string computation.
3502 (ada_exception_catchpoint_cond_string): Likewise.
3504 2019-10-02 Tom Tromey <tromey@adacore.com>
3506 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3507 * ada-lang.c (lesseq_defined_than): Handle
3509 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3511 (dwarf2_has_info): Likewise.
3512 (new_symbol): Set maybe_copied on symbol when
3514 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3516 <can_copy>: New member.
3517 * elfread.c (record_minimal_symbol): Set maybe_copied
3518 on symbol when appropriate.
3519 (elf_symfile_read): Update call to dwarf2_has_info.
3520 * minsyms.c (lookup_minimal_symbol_linkage): New
3522 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3523 * symtab.c (get_symbol_address, get_msymbol_address):
3525 * symtab.h (get_symbol_address, get_msymbol_address):
3527 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3529 (struct symbol, struct minimal_symbol) <maybe_copied>:
3532 2019-10-02 Tom Tromey <tromey@adacore.com>
3534 * source.c (struct current_source_location): New.
3535 (current_source_key): New global.
3536 (current_source_symtab, current_source_line)
3537 (current_source_pspace): Remove.
3538 (get_source_location): New function.
3539 (get_current_source_symtab_and_line)
3540 (set_default_source_symtab_and_line)
3541 (set_current_source_symtab_and_line)
3542 (clear_current_source_symtab_and_line, select_source_symtab)
3543 (info_source_command, print_source_lines_base)
3544 (info_line_command, search_command_helper, _initialize_source):
3547 2019-10-02 Tom Tromey <tromey@adacore.com>
3549 * source.c (select_source_symtab): Don't call
3550 decode_line_with_current_source.
3552 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3554 * symtab.c (lookup_global_symbol): Search global block.
3556 2019-10-02 Tom Tromey <tromey@adacore.com>
3558 * coffread.c (process_coff_symbol): Update.
3559 * dwarf2read.c (var_decode_location, new_symbol): Update.
3560 * mdebugread.c (parse_symbol): Update.
3561 * objfiles.c (relocate_one_symbol): Update.
3562 * stabsread.c (define_symbol, fix_common_block)
3563 (scan_file_globals): Update.
3564 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3565 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3566 * xcoffread.c (process_xcoff_symbol): Update.
3568 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3570 * MAINTAINERS: Update my email address.
3572 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3574 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3576 (build_type_psymtabs_reader): Update for std::vector.
3577 (build_type_psymtab_dependencies): Likewise.
3578 * dwarf2read.h: Remove use of DEF_VEC_P.
3579 (typedef sig_type_ptr): Delete.
3581 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3583 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3585 (btrace_maint_decode_pt): Likewise, and move allocation of the
3586 vector outside of the loop.
3587 (btrace_maint_update_packets): Update to handle change from VEC to
3589 (btrace_maint_print_packets): Likewise.
3590 (maint_info_btrace_cmd): Likewise.
3591 * btrace.h: Remove use of DEF_VEC_O.
3592 (typedef btrace_pt_packet_s): Delete.
3593 (struct btrace_maint_info) <packets>: Change fromm VEC to
3595 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3597 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3599 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3600 make accesses into the vector constant references.
3601 (btrace_add_pc): Update for std::vector.
3602 (btrace_stitch_bts): Likewise.
3603 (parse_xml_btrace_block): Likewise.
3604 (btrace_maint_update_packets): Likewise.
3605 (btrace_maint_print_packets): Likewise.
3606 (maint_info_btrace_cmd): Likewise.
3607 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3609 (btrace_data::empty): Likewise.
3610 (btrace_data_append): Likewise.
3611 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3612 (typedef btrace_block_s): Delete.
3613 (struct btrace_block): Add constructor.
3614 (struct btrace_data_bts) <blocks>: Change to std::vector.
3615 * nat/linux-btrace.c (perf_event_read_bts): Update for
3617 (linux_read_bts): Likewise.
3619 2019-10-01 Tom Tromey <tom@tromey.com>
3621 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3623 2019-10-01 Tom Tromey <tom@tromey.com>
3625 * stack.c (print_frame, info_frame_command_core): Use
3627 * linux-thread-db.c (try_thread_db_load_1)
3628 (try_thread_db_load_from_pdir_1): Use styled_string.
3629 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3630 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3631 (maybe_print_unsupported_script_warning)
3632 (maybe_print_script_not_found_warning): Use styled_string.
3633 * ada-lang.c (user_select_syms): Use styled_string.
3635 2019-10-01 Tom Tromey <tom@tromey.com>
3637 * p-lang.c (pascal_printstr): Use metadata style.
3638 * value.c (show_convenience): Use metadata style.
3639 * valprint.c (valprint_check_validity, val_print_optimized_out)
3640 (val_print_not_saved, val_print_unavailable)
3641 (val_print_invalid_address, generic_val_print, val_print)
3642 (value_check_printable, val_print_array_elements): Use metadata
3644 * ui-out.h (class ui_out) <field_fmt>: New overload.
3645 <do_field_fmt>: Add style parameter.
3646 * ui-out.c (ui_out::field_fmt): New overload.
3647 * typeprint.c (type_print_unknown_return_type)
3648 (val_print_not_allocated, val_print_not_associated): Use metadata
3650 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3652 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3653 * tracepoint.c (tvariables_info_1): Use metadata style.
3654 * stack.c (print_frame_arg, print_frame_info, print_frame)
3655 (info_frame_command_core): Use metadata style.
3656 * skip.c (info_skip_command): Use metadata style.
3657 * rust-lang.c (rust_print_enum): Use metadata style.
3658 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3660 * python/py-framefilter.c (py_print_single_arg): Use metadata
3662 * printcmd.c (do_one_display, print_variable_and_value): Use
3664 * p-valprint.c (pascal_val_print)
3665 (pascal_object_print_value_fields): Use metadata style.
3666 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3667 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3669 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3670 * m2-valprint.c (m2_print_long_set): Use metadata style.
3671 * m2-typeprint.c (m2_print_type): Use metadata style.
3672 * infcmd.c (print_return_value_1): Use metadata style.
3673 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3674 * f-valprint.c (info_common_command_for_block): Use metadata
3676 * f-typeprint.c (f_type_print_base): Use metadata style.
3677 * expprint.c (print_subexp_standard): Use metadata style.
3678 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3679 * cli/cli-style.h (class cli_style_option): Add constructor.
3680 (metadata_style): Declare.
3681 * cli/cli-style.c (metadata_style): New global.
3682 (_initialize_cli_style): Register metadata style.
3683 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3685 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3686 * c-typeprint.c (c_type_print_base_struct_union)
3687 (c_type_print_base_1): Use metadata style.
3688 * breakpoint.c (watchpoint_value_print)
3689 (print_one_breakpoint_location): Use metadata style.
3690 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3692 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3694 * ada-valprint.c (val_print_packed_array_elements, printstr)
3695 (print_field_values, ada_val_print_ref, ada_val_print): Use
3697 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3699 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3701 * ada-lang.c (user_select_syms): Use metadata style.
3703 2019-10-01 Tom Tromey <tom@tromey.com>
3705 * cli/cli-cmds.c (pwd_command): Style output.
3707 2019-10-01 Pedro Alves <palves@redhat.com>
3708 Tom Tromey <tom@tromey.com>
3710 * symtab.c (print_symbol_info): Use %ps.
3711 (print_msymbol_info): Use %ps.
3712 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3713 * printcmd.c (print_variable_and_value): Use %ps.
3714 * macrocmd.c (show_pp_source_pos): Use %ps.
3715 * infrun.c (print_exited_reason): Use ui_out::message.
3716 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3717 (describe_other_breakpoints): Use ui_out::message and new
3719 (say_where): Use new formats.
3720 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3723 2019-10-01 Pedro Alves <palves@redhat.com>
3724 Tom Tromey <tom@tromey.com>
3726 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3727 (test_gdb_formats): New function.
3728 (run_tests): Call it.
3729 (test_format_specifier): Update.
3730 * utils.h (fputs_filtered): Update comment.
3731 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3732 (fputs_styled_unfiltered): Declare.
3733 * utils.c (fputs_styled_unfiltered): New function.
3734 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3735 (vfprintf_filtered): Update.
3736 (vfprintf_unfiltered, vprintf_filtered): Update.
3737 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3738 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3739 disallow_ui_out_field>: New constants.
3740 (enum class field_kind): New.
3741 (struct base_field_s, struct signed_field_s): New.
3742 (signed_field): New function.
3743 (struct string_field_s): New.
3744 (string_field): New function.
3745 (struct styled_string_s): New.
3746 (styled_string): New function.
3747 (class ui_out) <message>: Add comment.
3748 <vmessage, call_do_message>: New methods.
3749 <do_message>: Add style parameter.
3750 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3752 (ui_out::message): Rewrite.
3753 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3755 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3756 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3757 gdb_extensions parameter.
3758 (class format_piece): Add parameter to constructor.
3759 (n_int_args): New field.
3760 * gdbsupport/format.c (format_pieces::format_pieces): Add
3761 gdb_extensions parameter. Handle '*'.
3762 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3763 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3764 vfprintf_styled_no_gdbfmt.
3765 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3766 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3768 * ui-style.h (struct ui_file_style) <ptr>: New method.
3770 2019-10-01 Tom Tromey <tom@tromey.com>
3772 * unittests/format_pieces-selftests.c: Update. Add final format.
3773 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3774 empty literal pieces.
3776 2019-10-01 Tom Tromey <tom@tromey.com>
3778 * ui-out.h (enum class ui_out_style_kind): Remove.
3779 (class ui_out) <field_string, field_stsream, do_field_string>:
3780 Change type of "style".
3781 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3782 (ui_out::field_string): Update.
3783 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3785 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3786 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3787 * stack.c (print_frame_arg, print_frame_info, print_frame):
3789 * source.c (print_source_lines_base): Update.
3790 * solib.c (info_sharedlibrary_command): Update.
3791 * skip.c (info_skip_command): Update.
3792 * record-btrace.c (btrace_call_history_src_line)
3793 (btrace_call_history): Update.
3794 * python/py-framefilter.c (py_print_frame): Update.
3795 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3797 * mi/mi-out.c (mi_ui_out::do_table_header)
3798 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3799 (mi_ui_out::do_field_string): Update.
3800 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3802 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3804 * cli-out.c (cli_ui_out::do_table_header)
3805 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3806 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3807 (cli_ui_out::do_field_fmt): Update.
3808 * breakpoint.c (print_breakpoint_location): Update.
3809 (update_static_tracepoint): Update.
3811 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3813 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3814 conversion of gdb_datadir.
3815 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3816 remove not needed c_str ().
3818 2019-09-30 Ali Tamur <tamur@google.com>
3820 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3821 (dwarf2_string_attr): Likewise.
3823 2019-09-30 Ali Tamur <tamur@google.com>
3825 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3826 (process_full_type_unit): Likewise.
3827 (dump_die_shallow): Likewise.
3828 (cu_debug_loc_section): Likewise.
3830 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3832 * minsyms.c (compare_minimal_symbols): Rename to...
3833 (minimal_symbol_is_less_than): ...this, and adjust to STL
3834 conventions (return bool, take arguments as references)
3835 (minimal_symbol_reader::install): Call std::sort instead
3838 2019-09-29 Christian Biesinger <cbiesinger@google.com>
3840 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3842 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3843 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3845 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3847 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3848 * psympriv.h (add_psymbol_to_list): Move comment here and update
3851 2019-09-29 Tom de Vries <tdevries@suse.de>
3853 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3854 Use $tmpdir/$(basename "$output_file").dwz instead of
3855 "${output_file}.dwz".
3857 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3860 * hppa-linux-nat.c: Include gdbarch.h.
3862 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3864 * blockframe.c (find_pc_partial_function): Change return type to bool.
3865 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3866 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3867 (stub_gnu_ifunc_resolve_name): Likewise.
3868 * symtab.c (compare_filenames_for_search): Likewise.
3869 (compare_glob_filenames_for_search): Likewise.
3870 (matching_obj_sections): Likewise.
3871 (symbol_matches_domain): Likewise.
3872 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3873 (find_line_pc): Change return type to bool.
3874 (find_line_pc_range): Likewise.
3875 (producer_is_realview): Likewise.
3876 * symtab.h (symbol_matches_domain): Likewise.
3877 (find_pc_partial_function): Likewise.
3878 (find_pc_line_pc_range): Likewise.
3879 (in_gnu_ifunc_stub): Likewise.
3880 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3881 (find_line_pc): Likewise.
3882 (find_line_pc_range): Likewise.
3883 (matching_obj_sections): Likewise.
3884 (find_line_symtab): Change out parameter to bool.
3885 (producer_is_realview): Change return type to bool.
3886 (compare_filenames_for_search): Likewise.
3887 (compare_glob_filenames_for_search): Likewise.
3889 2019-09-26 Tom Tromey <tom@tromey.com>
3891 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3892 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3893 * gdb_usleep.h: Remove.
3894 * gdb_usleep.c: Remove.
3895 * utils.c: Don't include gdb_usleep.h.
3897 2019-09-26 Tom Tromey <tromey@adacore.com>
3899 * python/py-type.c (type_to_type_object): Call check_typedef
3902 2019-09-26 Tom Tromey <tom@tromey.com>
3904 * utils.h (initialize_utils): Don't declare.
3905 * top.c (gdb_init): Don't call initialize_utils.
3906 * utils.c (initialize_utils): Remove. Move contents...
3907 (_initialize_utils): ... here.
3909 2019-09-25 Tom Tromey <tom@tromey.com>
3911 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3912 * utils.h (make_hex_string): Don't declare.
3913 * utils.c (make_hex_string): Remove.
3915 2019-09-24 Tom de Vries <tdevries@suse.de>
3918 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3919 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3921 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3923 * NEWS: Mention new simulator port for PRU.
3925 2019-09-23 Christian Biesinger <cbiesinger@google.com>
3927 * ada-exp.y (write_object_remaining): Update.
3928 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3929 and eliminate the static buffer.
3930 (ada_decode_symbol): Update.
3931 (ada_la_decode): Update.
3932 (ada_sniff_from_mangled_name): Update.
3933 (is_valid_name_for_wild_match): Update.
3934 (ada_lookup_name_info::matches): Update and simplify.
3935 (name_matches_regex): Update.
3936 (ada_add_global_exceptions): Update.
3937 * ada-lang.h (ada_decode): Update signature.
3938 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3939 * dwarf-index-write.c (debug_names::insert): Update.
3941 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3943 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3946 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3948 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3949 Change "nonzero" to "true" in documentation.
3951 2019-09-20 Christian Biesinger <cbiesinger@google.com>
3953 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3954 (_initialize_darwin_solib): Don't set
3955 darwin_so_ops.lookup_lib_global_symbol.
3956 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3957 set_gdbarch_iterate_over_objfiles_in_search_order.
3958 (elf_lookup_lib_symbol): Rename to...
3959 (svr4_iterate_over_objfiles_in_search_order): this, and update
3960 to iterate semantics.
3961 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3962 * solib.c (solib_global_lookup): Remove.
3963 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3964 (solib_global_lookup): Remove.
3965 * symtab.c (lookup_global_or_static_symbol): Remove call to
3966 solib_global_lookup.
3968 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3970 * NEWS: Move entries about default MI version now being
3971 version 3, and about the GDB/MI fix for multi-location
3972 breakpoints to the "since GDB 8.3" section.
3974 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3978 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3980 * NEWS: Mention that Cell/B.E. debugging support was removed.
3981 * MAINTAINERS: Remove spu target.
3983 * config/djgpp/fnchange.lst: Remove entries for removed files.
3985 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3986 spu-multiarch.o, and spu-tdep.o.
3987 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3988 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3989 spu-multiarch.c, and spu-tdep.c.
3990 * spu-linux-nat.c: Remove file.
3991 * spu-multiarch.c: Remove file.
3992 * spu-tdep.c: Remove file.
3993 * spu-tdep.h: Remove file.
3994 * solib-spu.c: Remove file.
3995 * solib-spu.h: Remove file.
3997 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3998 * configure.nat (spu-linux): Remove.
3999 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4000 solib-multiarch.o from gdb_target_obs.
4003 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4005 (ppc_linux_no_features): Update.
4006 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4008 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4009 (tdesc_powerpc_cell64l): Likewise.
4010 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4011 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4013 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4014 Do not include "features/rs6000/powerpc-cell32l.c" or
4015 "features/rs6000/powerpc-cell64l.c".
4016 (ppc_linux_spu_section): Remove.
4017 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4018 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4019 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4020 (ppc_linux_spe_context_lookup): Remove.
4021 (ppc_linux_spe_context_inferior_created): Remove.
4022 (ppc_linux_spe_context_solib_loaded): Remove.
4023 (ppc_linux_spe_context_solib_unloaded): Remove.
4024 (ppc_linux_spe_context): Remove.
4025 (struct ppu2spu_cache): Remove.
4026 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4027 (struct ppu2spu_data): Remove.
4028 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4029 ppu2spu_unwind): Remove.
4030 (ppc_linux_init_abi): Remove Cell/B.E. support.
4031 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4033 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4034 (rs6000/powerpc-cell64l-expedite): Likewise
4035 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4036 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4037 rs6000/powerpc-cell64l.xml.
4038 * features/rs6000/powerpc-cell32l.xml: Remove.
4039 * features/rs6000/powerpc-cell64l.xml: Likewise.
4040 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4041 * features/rs6000/powerpc-cell64l.c: Likewise.
4042 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4043 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4044 * regformats/reg-spu.dat: Remove.
4046 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4047 * corelow.c (struct spuid_list): Remove.
4048 (add_to_spuid_list): Remove.
4049 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4050 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4051 (remote_protocol_features): Remove associated entries.
4052 (_initialize_remote): No longer initialize them.
4053 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4054 * linux-nat.c (SPUFS_MAGIC): Remove.
4055 (linux_proc_xfer_spu): Remove.
4056 (spu_enumerate_spu_ids): Remove.
4057 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4058 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4059 (linux_make_corefile_notes): No longer call it.
4061 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4062 (cooked_write_test): Likewise.
4064 2019-09-20 Tom Tromey <tom@tromey.com>
4066 * NEWS: Mention case-sensitivity of TUI commands.
4067 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4068 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4069 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4071 2019-09-20 Tom Tromey <tom@tromey.com>
4073 * tui/tui-source.c (tui_source_window::set_contents): Use
4074 make_unique_xstrdup.
4075 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4076 make_unique_xstrdup.
4078 2019-09-20 Tom Tromey <tom@tromey.com>
4080 * tui/tui-data.c: Remove separator comments.
4081 * tui/tui-layout.c: Remove separator comments.
4082 * tui/tui-win.c: Remove separator comments.
4083 * tui/tui-wingeneral.c: Remove separator comments.
4085 2019-09-20 Tom Tromey <tom@tromey.com>
4087 * tui/tui.h (strcat_to_buf): Don't declare.
4088 * tui/tui.c (strcat_to_buf): Remove.
4090 2019-09-20 Tom Tromey <tom@tromey.com>
4092 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4094 * tui/tui-source.c (tui_source_window::set_contents)
4095 (tui_source_window::location_matches_p)
4096 (tui_source_window::maybe_update): Update.
4098 2019-09-20 Tom Tromey <tom@tromey.com>
4100 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4102 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4104 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4105 (tui_data_window::line_from_reg_element_no)
4106 (tui_data_window::first_reg_element_no_inline)
4107 (tui_data_window::show_registers)
4108 (tui_data_window::show_register_group)
4109 (tui_data_window::display_registers_from)
4110 (tui_data_window::display_registers_from_line)
4111 (tui_data_window::first_data_item_displayed)
4112 (tui_data_window::delete_data_content_windows)
4113 (tui_data_window::erase_data_content)
4114 (tui_data_window::do_scroll_vertical)
4115 (tui_data_window::refresh_window)
4116 (tui_data_window::check_register_values): Update.
4118 2019-09-20 Tom Tromey <tom@tromey.com>
4120 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4121 (struct tui_locator_window) <full_name, proc_name>: Now
4123 * tui/tui-stack.c (tui_locator_window::make_status_line)
4124 (tui_locator_window::set_locator_fullname)
4125 (tui_locator_window::set_locator_info): Update.
4126 * tui/tui-source.c (tui_source_window::set_contents)
4127 (tui_source_window::showing_source_p): Update.
4129 2019-09-20 Tom Tromey <tom@tromey.com>
4131 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4132 Don't call tui_locator_win_info_ptr.
4134 2019-09-20 Tom Tromey <tom@tromey.com>
4136 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4138 2019-09-20 Tom Tromey <tom@tromey.com>
4140 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4142 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4143 * tui/tui-layout.c (show_source_disasm_command, show_data)
4144 (show_source_or_disasm_and_command): Use 1 as height for locator.
4146 2019-09-20 Tom Tromey <tom@tromey.com>
4148 * tui/tui.c (tui_enable): Update.
4149 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4151 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4153 * tui/tui-data.c (win_resized): Now bool.
4154 (tui_win_resized): Return bool.
4155 (tui_set_win_resized_to): Accept a bool.
4157 2019-09-20 Tom Tromey <tom@tromey.com>
4159 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4160 Change type of "refresh_values_only".
4161 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4162 type of "refresh_values_only".
4164 2019-09-20 Tom Tromey <tom@tromey.com>
4166 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4168 (tui_disassemble): Add "pos" parameter.
4169 (tui_disasm_window::set_contents): Simplify.
4171 2019-09-20 Tom Tromey <tom@tromey.com>
4173 * tui/tui-winsource.h (struct tui_source_window_base)
4174 <show_source_content>: Now private.
4175 * tui/tui-winsource.c
4176 (tui_source_window_base::show_source_content): Don't handle empty
4179 2019-09-20 Tom Tromey <tom@tromey.com>
4181 * tui/tui-layout.c (show_source_disasm_command)
4182 (show_source_or_disasm_and_command): Don't call
4183 show_source_content.
4185 2019-09-20 Tom Tromey <tom@tromey.com>
4187 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4189 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4190 from tui_make_status_line.
4191 (tui_locator_window::rerender): Update.
4193 2019-09-20 Tom Tromey <tom@tromey.com>
4195 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4196 (tui_locator_window::rerender): Update.
4198 2019-09-20 Tom Tromey <tom@tromey.com>
4200 * tui/tui-winsource.h (struct tui_source_window_base)
4201 <~tui_source_window_base>: Don't declare.
4203 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4204 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4206 * tui/tui-source.c (tui_source_window::set_contents): Update.
4207 (tui_source_window::location_matches_p)
4208 (tui_source_window::maybe_update): Update.
4210 2019-09-20 Tom Tromey <tom@tromey.com>
4212 * tui/tui-winsource.h (~tui_source_element): Remove.
4213 (tui_source_element): Update.
4214 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4215 * tui/tui-winsource.c (tui_show_source_line): Update.
4216 * tui/tui-source.c (tui_source_window::set_contents): Update.
4217 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4219 2019-09-20 Tom Tromey <tom@tromey.com>
4221 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4223 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4224 tui_clear_source_windows_detail.
4225 * tui/tui-winsource.h (struct tui_source_window_base)
4226 <clear_detail>: Don't declare.
4227 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4229 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4231 2019-09-20 Tom Tromey <tromey@adacore.com>
4234 * block.c (contained_in): Fix final return value.
4236 2019-09-20 Alan Modra <amodra@gmail.com>
4238 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4239 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4240 (read_indirect_string_from_dwz): Use bfd accessor.
4241 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4242 * machoread.c (macho_symfile_read_all_oso): Likewise.
4243 * solib.c (solib_bfd_open): Likewise.
4245 2019-09-19 Christian Biesinger <cbiesinger@google.com>
4247 * eval.c: Move declaration of overload_resolution to...
4250 2019-09-19 Christian Biesinger <cbiesinger@google.com>
4252 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4253 * arm-linux-tdep.c: Likewise.
4254 * arm-nbsd-nat.c: Likewise.
4255 * arm-tdep.h: Declare arm_apcs_32.
4256 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4258 2019-09-19 Christian Biesinger <cbiesinger@google.com>
4260 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4261 * dwarf2read.h: Declare dwarf_always_disassemble.
4263 2019-09-19 Tom de Vries <tdevries@suse.de>
4266 * source-cache.c (source_cache::ensure): Catch exception thrown during
4267 construction of the highlighter.
4269 2019-09-18 Alan Modra <amodra@gmail.com>
4271 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4272 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4273 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4274 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4275 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4276 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4277 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4278 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4279 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4280 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4281 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4282 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4283 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4284 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4285 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4286 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4287 * mi/mi-interp.c: Update throughout for bfd section macro and
4289 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4290 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4292 2019-09-18 Tom Tromey <tom@tromey.com>
4295 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4297 (tui_enable): Do not call rl_initialize.
4299 2019-09-18 Christian Groessler <chris@groessler.org>
4301 * alpha-linux-nat.c: Include gdbarch.h.
4303 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4305 * ui-file.c: Include cli/cli-style.h.
4306 (term_cli_styling): Remove cli_styling declaration.
4308 2019-09-18 Alan Modra <amodra@gmail.com>
4310 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4311 to bfd_asymbol_section.
4313 2019-09-18 Alan Modra <amodra@gmail.com>
4315 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4316 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4317 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4319 2019-09-18 Alan Modra <amodra@gmail.com>
4321 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4322 * spu-linux-nat.c (spu_bfd_open): Likewise.
4324 2019-09-18 Christian Biesinger <cbiesinger@google.com>
4326 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4327 to bool to match definition in dwarf2read.c.
4329 2019-09-17 Christian Biesinger <cbiesinger@google.com>
4331 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4332 (print_signatures): Likewise.
4333 (trust_pad_over_xvs): Likewise.
4334 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4335 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4336 * arm-linux-nat.c (arm_apcs_32): Likewise.
4337 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4338 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4339 * arm-tdep.c (arm_debug): Likewise.
4340 (arm_apcs_32): Likewise.
4341 * auto-load.c (debug_auto_load): Likewise.
4342 (auto_load_gdb_scripts): Likewise.
4343 (global_auto_load): Likewise.
4344 (auto_load_local_gdbinit): Likewise.
4345 (auto_load_local_gdbinit_loaded): Likewise.
4346 * auto-load.h (global_auto_load): Likewise.
4347 (auto_load_local_gdbinit): Likewise.
4348 (auto_load_local_gdbinit_loaded): Likewise.
4349 * breakpoint.c (disconnected_dprintf): Likewise.
4350 (breakpoint_proceeded): Likewise.
4351 (automatic_hardware_breakpoints): Likewise.
4352 (always_inserted_mode): Likewise.
4353 (target_exact_watchpoints): Likewise.
4354 (_initialize_breakpoint): Update.
4355 * breakpoint.h (target_exact_watchpoints): Change to bool.
4356 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4357 * cli/cli-cmds.c (trace_commands): Likewise.
4358 * cli/cli-cmds.h (trace_commands): Likewise.
4359 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4361 * cli/cli-logging.c (logging_overwrite): Change to bool.
4362 (logging_redirect): Likewise.
4363 (debug_redirect): Likewise.
4364 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4365 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4367 <boolean_option_def>: Update.
4368 (struct flag_option_def): Change default type of Context to bool
4370 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4371 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4372 (get_setshow_command_value_string): Likewise.
4373 * cli/cli-style.c (cli_styling): Change to bool.
4374 (source_styling): Likewise.
4375 * cli/cli-style.h (source_styling): Likewise.
4376 (cli_styling): Likewise.
4377 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4379 * command.h (var_types): Update comment.
4380 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4381 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4383 (debug_compile_cplus_scopes): Likewise.
4384 * compile/compile-internal.h (compile_debug): Likewise.
4385 * compile/compile.c (compile_debug): Likewise.
4386 (struct compile_options) <raw>: Likewise.
4387 * cp-support.c (catch_demangler_crashes): Likewise.
4388 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4389 (usr_cmd_cris_dwarf2_cfi): Likewise.
4390 * csky-tdep.c (csky_debug): Likewise.
4391 * darwin-nat.c (enable_mach_exceptions): Likewise.
4392 * dcache.c (dcache_enabled_p): Likewise.
4393 * defs.h (info_verbose): Likewise.
4394 * demangle.c (demangle): Likewise.
4395 (asm_demangle): Likewise.
4396 * dwarf-index-cache.c (debug_index_cache): Likewise.
4397 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4398 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4399 * dwarf2read.c (check_physname): Likewise.
4400 (use_deprecated_index_sections): Likewise.
4401 (dwarf_always_disassemble): Likewise.
4402 * eval.c (overload_resolution): Likewise.
4403 * event-top.c (set_editing_cmd_var): Likewise.
4404 (exec_done_display_p): Likewise.
4405 * event-top.h (set_editing_cmd_var): Likewise.
4406 (exec_done_display_p): Likewise.
4407 * exec.c (write_files): Likewise.
4408 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4409 (debug_fbsd_nat): Likewise.
4410 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4412 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4413 <backtrace_past_entry> Likewise.
4414 * gdb-demangle.h (demangle): Likewise.
4415 (asm_demangle): Likewise.
4416 * gdb_bfd.c (bfd_sharing): Likewise.
4417 * gdbcore.h (write_files): Likewise.
4418 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4419 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4420 * gdbthread.h (print_thread_events): Likewise.
4421 * gdbtypes.c (opaque_type_resolution): Likewise.
4422 (strict_type_checking): Likewise.
4423 * gnu-nat.c (gnu_debug_flag): Likewise.
4424 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4425 * guile/scm-param.c (pascm_variable): Add boolval.
4426 (add_setshow_generic): Update.
4427 (pascm_param_value): Update.
4428 (pascm_set_param_value_x): Update.
4429 * hppa-tdep.c (hppa_debug): Change to bool..
4430 * infcall.c (may_call_functions_p): Likewise.
4431 (coerce_float_to_double_p): Likewise.
4432 (unwind_on_signal_p): Likewise.
4433 (unwind_on_terminating_exception_p): Likewise.
4434 * infcmd.c (startup_with_shell): Likewise.
4435 * inferior.c (print_inferior_events): Likewise.
4436 * inferior.h (startup_with_shell): Likewise.
4437 (print_inferior_events): Likewise.
4438 * infrun.c (step_stop_if_no_debug): Likewise.
4439 (detach_fork): Likewise.
4440 (debug_displaced): Likewise.
4441 (disable_randomization): Likewise.
4442 (non_stop): Likewise.
4443 (non_stop_1): Likewise.
4444 (observer_mode): Likewise.
4445 (observer_mode_1): Likewise.
4446 (set_observer_mode): Update.
4447 (sched_multi): Change to bool.
4448 * infrun.h (debug_displaced): Likewise.
4449 (sched_multi): Likewise.
4450 (step_stop_if_no_debug): Likewise.
4451 (non_stop): Likewise.
4452 (disable_randomization): Likewise.
4453 * linux-tdep.c (use_coredump_filter): Likewise.
4454 (dump_excluded_mappings): Likewise.
4455 * linux-thread-db.c (auto_load_thread_db): Likewise.
4456 (check_thread_db_on_load): Likewise.
4457 * main.c (captured_main_1): Update.
4458 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4459 xx2_opt, boolean_opt>: Change to bool.
4460 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4461 * maint.c (maintenance_profile_p): Likewise.
4462 (per_command_time): Likewise.
4463 (per_command_space): Likewise.
4464 (per_command_symtab): Likewise.
4465 * memattr.c (inaccessible_by_default): Likewise.
4466 * mi/mi-main.c (mi_async): Likewise.
4467 (mi_async_1): Likewise.
4468 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4469 * nat/fork-inferior.h (startup_with_shell): Likewise.
4470 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4471 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4472 * nios2-tdep.c (nios2_debug): Likewise.
4473 * or1k-tdep.c (or1k_debug): Likewise.
4474 * parse.c (parser_debug): Likewise.
4475 * parser-defs.h (parser_debug): Likewise.
4476 * printcmd.c (print_symbol_filename): Likewise.
4477 * proc-api.c (procfs_trace): Likewise.
4478 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4479 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4480 (set_parameter_value): Update.
4481 (add_setshow_generic): Update.
4482 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4484 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4486 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4487 * record-btrace.c (record_btrace_target::store_registers): Update.
4488 * record-full.c (record_full_memory_query): Change to bool.
4489 (record_full_stop_at_limit): Likewise.
4490 * record-full.h (record_full_memory_query): Likewise.
4491 * remote-notif.c (notif_debug): Likewise.
4492 * remote-notif.h (notif_debug): Likewise.
4493 * remote.c (use_range_stepping): Likewise.
4494 (interrupt_on_connect): Likewise.
4495 (remote_break): Likewise.
4496 * ser-tcp.c (tcp_auto_retry): Likewise.
4497 * ser-unix.c (serial_hwflow): Likewise.
4498 * skip.c (debug_skip): Likewise.
4499 * solib-aix.c (solib_aix_debug): Likewise.
4500 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4501 (spu_auto_flush_cache_p): Likewise.
4502 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4504 (struct info_print_options) <quiet>: Likewise.
4505 * symfile-debug.c (debug_symfile): Likewise.
4506 * symfile.c (auto_solib_add): Likewise.
4507 (separate_debug_file_debug): Likewise.
4508 * symfile.h (auto_solib_add): Likewise.
4509 (separate_debug_file_debug): Likewise.
4510 * symtab.c (basenames_may_differ): Likewise.
4511 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4512 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4513 (struct info_types_options) <quiet>: Likewise.
4514 * symtab.h (demangle): Likewise.
4515 (basenames_may_differ): Likewise.
4516 * target-dcache.c (stack_cache_enabled_1): Likewise.
4517 (code_cache_enabled_1): Likewise.
4518 * target.c (trust_readonly): Likewise.
4519 (may_write_registers): Likewise.
4520 (may_write_memory): Likewise.
4521 (may_insert_breakpoints): Likewise.
4522 (may_insert_tracepoints): Likewise.
4523 (may_insert_fast_tracepoints): Likewise.
4524 (may_stop): Likewise.
4525 (auto_connect_native_target): Likewise.
4526 (target_stop_and_wait): Update.
4527 (target_async_permitted): Change to bool.
4528 (target_async_permitted_1): Likewise.
4529 (may_write_registers_1): Likewise.
4530 (may_write_memory_1): Likewise.
4531 (may_insert_breakpoints_1): Likewise.
4532 (may_insert_tracepoints_1): Likewise.
4533 (may_insert_fast_tracepoints_1): Likewise.
4534 (may_stop_1): Likewise.
4535 * target.h (target_async_permitted): Likewise.
4536 (may_write_registers): Likewise.
4537 (may_write_memory): Likewise.
4538 (may_insert_breakpoints): Likewise.
4539 (may_insert_tracepoints): Likewise.
4540 (may_insert_fast_tracepoints): Likewise.
4541 (may_stop): Likewise.
4542 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4543 (make_thread_apply_all_options_def_group): Change argument from int*
4545 (thread_apply_all_command): Update.
4546 (print_thread_events): Change to bool.
4547 * top.c (confirm): Likewise.
4548 (command_editing_p): Likewise.
4549 (history_expansion_p): Likewise.
4550 (write_history_p): Likewise.
4551 (info_verbose): Likewise.
4552 * top.h (confirm): Likewise.
4553 (history_expansion_p): Likewise.
4554 * tracepoint.c (disconnected_tracing): Likewise.
4555 (circular_trace_buffer): Likewise.
4556 * typeprint.c (print_methods): Likewise.
4557 (print_typedefs): Likewise.
4558 * utils.c (debug_timestamp): Likewise.
4559 (sevenbit_strings): Likewise.
4560 (pagination_enabled): Likewise.
4561 * utils.h (sevenbit_strings): Likewise.
4562 (pagination_enabled): Likewise.
4563 * valops.c (overload_resolution): Likewise.
4564 * valprint.h (struct value_print_options) <prettyformat_arrays,
4565 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4566 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4567 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4569 * windows-nat.c (new_console): Likewise.
4570 (cygwin_exceptions): Likewise.
4571 (new_group): Likewise.
4572 (debug_exec): Likewise.
4573 (debug_events): Likewise.
4574 (debug_memory): Likewise.
4575 (debug_exceptions): Likewise.
4576 (useshell): Likewise.
4577 * windows-tdep.c (maint_display_all_tib): Likewise.
4578 * xml-support.c (debug_xml): Likewise.
4580 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4582 * source.c (prepare_path_for_appending): New function.
4583 (openp): Make use of new function.
4584 (find_and_open_source): Search for the compilation directory and
4585 source file as a relative path beneath the directory search path.
4587 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4589 * source-cache.c (source_cache::get_line_charpos): Catch
4590 exceptions and return false, this matches the behaviour documented
4593 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4595 * ada-tasks.c (info_task): Remove quoting of the task's name.
4597 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4599 * symfile.c (auto_solib_add): Replace comment with a reference
4602 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4604 * NEWS: Mention that gdb can now be compiled with Python 3
4607 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4609 * maint.c (maint_print_section_data::maint_print_section_data):
4610 Force use of 'float log10 (float)' by casting the argument to
4613 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4615 * maint.c: Add 'cmath' include.
4616 (struct maint_print_section_data): New structure.
4617 (print_section_index): New function.
4618 (print_bfd_section_info): Add header comment, small whitespace
4619 cleanup, and update to call new print_section_index function.
4620 (print_objfile_section_info): Likewise.
4621 (maint_obj_section_from_bfd_section): New function.
4622 (print_bfd_section_info_maybe_relocated): New function.
4623 (maintenance_info_sections): Add header comment, always use
4624 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4626 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4628 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4629 inner scope, add check that the objfile has psymtabs before
4630 checking psymtabs_addrmap.
4631 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4633 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4635 * NEWS: Announce that Ada task names are now shown at more places,
4636 and between quotes (except in info task output).
4637 * gdb/ada-tasks.c (task_to_str): New function.
4638 (display_current_task_id): Call task_to_str.
4639 (task_command_1): Likewise.
4640 (print_ada_task_info): In non-mi mode, Properly align headers and data
4641 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4643 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4645 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4646 prstatus.pr_lwp.pr_info instead of making it up.
4648 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4650 * auto-load.c (auto_load_expand_dir_vars): Update.
4651 * defs.h (gdb_datadir): Change to std::string.
4652 (python_libdir): Likewise.
4653 (relocate_gdb_directory): Change return type to std::string.
4654 * guile/guile.c (gdbscm_data_directory): Update.
4655 (initialize_scheme_side): Update.
4656 * jit.c (jit_reader_dir): Change to std::string.
4657 (jit_reader_load_command): Update.
4658 * main.c (gdb_datadir): Change to std::string.
4659 (python_libdir): Likewise.
4660 (set_gdb_data_directory): Update.
4661 (relocate_path): Change to return std::string.
4662 (relocate_gdb_directory): Change to return std::string.
4663 (relocate_gdbinit_path_maybe_in_datadir): Update.
4664 (captured_main_1): Update.
4665 * python/python.c (do_start_initialization): Update.
4666 * top.c (show_gdb_datadir): Update.
4667 * xml-syscall.c (xml_init_syscalls_info): Update.
4668 (init_syscalls_info): Update.
4670 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4672 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4673 out of get_init_files.
4674 (get_init_files): Update.
4676 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4678 * main.c (get_init_files): Change to use std::string.
4679 (captured_main_1): Update.
4680 (print_gdb_help): Update.
4682 2019-09-11 Ali Tamur <tamur@google.com>
4684 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4687 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4689 * dbxread.c (read_dbx_symtab): Update.
4690 * dwarf2read.c (load_partial_dies): Update.
4691 * mdebugread.c (parse_partial_symbols): Update.
4692 (handle_psymbol_enumerators): Update.
4693 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4694 * psymtab.c (add_psymbol_to_bcache): Likewise.
4695 (add_psymbol_to_list): Likewise.
4696 * symtab.c (symbol_set_names): Likewise.
4697 * symtab.h (symbol_set_names): Likewise.
4698 * xcoffread.c (scan_xcoff_symtab): Update.
4700 2019-09-11 Tom Tromey <tom@tromey.com>
4702 * symfile-mem.c (symbol_file_add_from_memory): Use
4704 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4705 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4707 2019-09-10 Tom Tromey <tromey@adacore.com>
4709 * dwarf-index-write.c (write_psymbols): Extend error message.
4710 (debug_names::insert): Add Ada code.
4711 (debug_names::write_psymbols): Remove Ada check.
4712 (debug_names) <m_string_obstack>: New member.
4713 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4714 (gdb_index_symbol_name_matcher::matches): Remove.
4715 (mapped_index_base::find_name_components_bounds): Add "lang"
4717 (mapped_index_base::build_name_components): Also split names
4718 according to Ada syntax.
4719 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4720 type of "match_callback".
4721 (check_match, check_find_bounds_finds)
4722 (dw2_expand_symtabs_matching): Update.
4723 (dw2_debug_names_iterator): Add new constructor.
4724 (dw2_debug_names_map_matching_symbols): New function.
4725 (dw2_debug_names_expand_symtabs_matching): Update.
4726 (dwarf2_debug_names_functions): Use
4727 dw2_debug_names_map_matching_symbols.
4729 2019-09-10 Tom Tromey <tromey@adacore.com>
4731 * dwarf2read.c (dw2_get_file_names_reader): Add the
4732 CU's file name to the results.
4734 2019-09-10 Tom Tromey <tromey@adacore.com>
4736 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4737 map_matching_symbols. Update.
4738 * dwarf2read.c (dw2_map_matching_symbols): Update.
4739 * psymtab.c (match_partial_symbol): Change type; update.
4740 (psym_map_matching_symbols): Likewise.
4741 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4743 * symfile.h (struct quick_symbol_functions)
4744 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4747 2019-09-10 Tom Tromey <tromey@adacore.com>
4749 * psymtab.c (map_block): Remove.
4750 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4751 * symtab.c (iterate_over_symbols_terminated): New function.
4752 * symtab.c (iterate_over_symbols_terminated): Declare.
4754 2019-09-10 Tom Tromey <tromey@adacore.com>
4756 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4757 * language.h (struct language_defn) <la_iterate_over_symbols>:
4759 * symtab.c (iterate_over_symbols): Return bool.
4760 * symtab.h (iterate_over_symbols): Return bool.
4762 2019-09-10 Tom Tromey <tromey@adacore.com>
4764 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4765 (add_nonlocal_symbols): Update.
4766 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4767 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4768 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4769 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4770 Change type of "callback". Remove "data".
4773 2019-09-09 Ali Tamur <tamur@google.com>
4775 * dwarf2read.c (comp_unit_head): Update comment.
4776 (dwarf2_dwo_name): New function declaration.
4777 (dwarf_unit_type_name): New function declaration.
4778 (read_comp_unit_head): Add support for new compilation units,
4779 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4780 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4781 (currently named as "signature") in their header. Also clarify error
4783 (lookup_dwo_id): New function. Returns the dwo id of the given
4785 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4786 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4788 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4789 (dwarf2_dwo_name): Get the dwo name if present.
4790 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4793 2019-09-09 Tom Tromey <tom@tromey.com>
4795 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4797 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4799 * python/python.c (do_start_initialization): Make progname_copy static,
4800 to avoid a leak report.
4802 2019-09-08 Tom Tromey <tom@tromey.com>
4804 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4806 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4808 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4809 Change type to gdb::optional<block_enum>.
4810 (dw2_symtab_iter_init): Change block_index parameter type
4811 to gdb::optional<block_enum>.
4812 (dw2_lookup_symbol): Change block_index parameter
4813 type to block_enum.c
4814 (dw2_debug_names_lookup_symbol): Likewise.
4815 * psymtab.c (psym_lookup_symbol): Likewise.
4816 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4817 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4820 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4822 * defs.h (relocate_gdb_directory): Change int to bool in
4823 signature and rename flag to relocatable.
4824 * main.c (relocate_path): Likewise.
4825 (relocate_gdb_directory): Likewise.
4827 2019-09-06 Alan Modra <amodra@gmail.com>
4829 * coffread.c (coff_symfile_read): Constify filename variable.
4830 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4831 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4832 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4833 * solib.c (reload_shared_libraries_1): Likewise.
4834 * symfile.c (reread_symbols): Likewise.
4835 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4836 * solib-darwin.c (darwin_bfd_open): Likewise.
4837 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4839 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4841 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4842 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4844 2019-09-03 Tom Tromey <tromey@adacore.com>
4846 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4848 (has_negatives): Unbias a range type bound.
4849 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4850 * gdbtypes.c (operator==): Handle new field.
4851 (create_range_type): Add "bias" parameter.
4852 (create_static_range_type, resolve_dynamic_range): Update.
4853 * gdbtypes.h (struct range_bounds) <bias>: New member.
4854 (create_range_type): Add bias parameter.
4855 * printcmd.c (print_scalar_formatted): Unbias range types.
4856 * value.c (unpack_long): Unbias range types.
4857 (pack_long): Bias range types.
4859 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4861 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4864 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4866 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4867 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4868 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4869 (compile_probe_arg): Likewise.
4870 * probe.h (get_argument_count): Likewise.
4871 * solib-svr4.c (solib_event_probe_action): Likewise.
4872 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4874 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4876 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4878 (svr4_create_solib_event_breakpoints): ...from here.
4880 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4882 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4883 suffix from warning message.
4885 2019-08-30 Tom Tromey <tom@tromey.com>
4887 * tui/tui-winsource.h (struct tui_source_window_base)
4888 <refresh_all>: Don't declare.
4889 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4891 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4892 tui_show_locator_content.
4893 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4895 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4896 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4899 2019-08-30 Tom Tromey <tom@tromey.com>
4901 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4903 2019-08-30 Tom Tromey <tom@tromey.com>
4905 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4906 Remove unnecessary forward declarations.
4908 2019-08-30 Tom Tromey <tom@tromey.com>
4910 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4912 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4913 tui_show_locator_content.
4915 2019-08-30 Tom Tromey <tom@tromey.com>
4917 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4918 (tui_locator_window::rerender): Rewrite using body of previous
4919 tui_show_locator_content.
4921 2019-08-30 Tom Tromey <tom@tromey.com>
4923 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4924 set_locator_fullname>: New methods.
4925 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4926 Rename from tui_set_locator_fullname.
4927 (tui_locator_window::set_locator_info): Rename from
4928 tui_set_locator_info. Return bool.
4929 (tui_update_locator_fullname, tui_show_frame_info): Update.
4931 2019-08-30 Tom Tromey <tom@tromey.com>
4933 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4935 2019-08-30 Tom Tromey <tom@tromey.com>
4937 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4940 2019-08-30 Tom Tromey <tom@tromey.com>
4942 * tui/tui-wingeneral.c (box_win): Assume win_info and
4943 win_info->handle cannot be NULL.
4945 2019-08-30 Tom Tromey <tom@tromey.com>
4947 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4948 refresh_window>: Declare.
4949 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4951 (tui_data_item_window::rerender): Rename from
4952 tui_display_register.
4953 (tui_data_item_window::refresh_window): New method.
4954 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4957 2019-08-30 Tom Tromey <tom@tromey.com>
4959 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4960 regs_column_count, current_group>: Move later. Now private.
4961 <get_current_group>: New method.
4962 * tui/tui-regs.c (tui_reg_command): Update.
4963 * tui/tui-layout.c (tui_set_layout): Update.
4965 2019-08-30 Tom Tromey <tom@tromey.com>
4967 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4968 (tui_data_window::rerender): Don't call
4969 check_and_display_highlight_if_needed.
4970 (tui_data_window::refresh_all): Remove call to
4973 2019-08-30 Tom Tromey <tom@tromey.com>
4975 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4976 (tui_data_window::display_registers_from)
4977 (tui_data_window::display_reg_element_at_line)
4978 (tui_data_window::display_registers_from_line): Remove checks of
4981 2019-08-30 Tom Tromey <tom@tromey.com>
4983 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4985 * tui/tui-regs.c (tui_data_window::show_registers): Call
4987 (tui_data_window::rerender): Rename from display_all_data.
4988 (tui_data_window::rerender): Remove old implementation.
4990 2019-08-30 Tom Tromey <tom@tromey.com>
4992 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4994 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4996 2019-08-29 Bernhard Wodok <barto@gmx.net>
4997 Sergio Durigan Junior <sergiodj@redhat.com>
5000 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5002 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5004 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5005 when searching for types.
5007 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5009 * f-lang.c (f_language_defn): Use f_print_typedef.
5010 * f-lang.h (f_print_typedef): Declare.
5011 * f-typeprint.c (f_print_typedef): Define.
5013 2019-08-27 Christian Biesinger <cbiesinger@google.com>
5015 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5017 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5019 * cli/cli-utils.c (info_print_options_defs): Delete.
5020 (make_info_print_options_def_group): Delete.
5021 (extract_info_print_options): Delete.
5022 (info_print_command_completer): Delete.
5023 (info_print_args_help): Add extra parameter, and optionally
5024 include text about -n flag.
5025 * cli/cli-utils.h (struct info_print_options): Delete.
5026 (extract_info_print_options): Delete declaration.
5027 (info_print_command_completer): Delete declaration.
5028 (info_print_args_help): Add extra parameter, extend header
5030 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5032 * stack.c (struct info_print_options): New type.
5033 (info_print_options_defs): New file scoped variable.
5034 (make_info_print_options_def_group): New static function.
5035 (info_print_command_completer): New static function.
5036 (info_locals_command): Update to use new local functions.
5037 (info_args_command): Likewise.
5038 (_initialize_stack): Add extra parameter to calls to
5039 info_print_args_help.
5040 * symtab.c (search_symbols): Add extra parameter, use this to
5041 possibly excluse non-debug symbols.
5042 (symtab_symbol_info): Add extra parameter, which is passed on to
5044 (struct info_print_options): New type.
5045 (info_print_options_defs): New file scoped variable.
5046 (make_info_print_options_def_group): New static function.
5047 (info_print_command_completer): New static function.
5048 (info_variables_command): Update to use local functions, and pass
5049 extra parameter through to symtab_symbol_info.
5050 (info_functions_command): Likewise.
5051 (info_types_command): Pass additional argument through to
5053 (rbreak_command): Pass extra argument to search_symbols.
5054 (_initialize_symtab): Add extra arguments for calls to
5055 info_print_args_help, and update help text for 'info variables',
5056 'whereis', and 'info functions' commands.
5057 * symtab.h (search_symbols): Add extra argument to declaration.
5058 * NEWS: Mention new flags.
5060 2019-08-26 Christian Biesinger <cbiesinger@google.com>
5062 * symtab.c (lookup_static_symbol): Call the new function (and move
5063 it down to be next to lookup_global_symbol).
5064 (struct global_sym_lookup_data): Add block_enum member and rename to...
5065 (struct global_or_static_sym_lookup_data): ...this.
5066 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5067 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5068 (lookup_symbol_global_or_static_iterator_cb): ...this.
5069 (lookup_global_or_static_symbol): New function.
5070 (lookup_global_symbol): Call new function.
5072 2019-08-26 Tom de Vries <tdevries@suse.de>
5075 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5076 when pc_probe.prob == NULL.
5078 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
5080 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5081 variable symbol_linkage to symbol_linkage_.
5083 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
5085 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5086 represent whether the symbol is static, dynamic, or we don't
5089 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5091 * gdb/rx-tdep.c (rx_register_names): New.
5092 (rx_register_name): Delete.
5093 (rx_psw_type): Delete.
5094 (rx_fpsw_type): Delete.
5095 (rx_register_type): Delete.
5096 (rx_gdbarch_init): Convert target-descriptions.
5097 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5098 * gdb/features/Makefile: Add rx.xml.
5099 * gdb/features/rx.xml: New.
5100 * gdb/features/rx.c: Generated.
5101 * gdb/NEWS: Mention target description support.
5103 2019-08-22 Christian Biesinger <cbiesinger@google.com>
5105 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5108 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5110 * configure.ac: Don't check for 'dlfcn.h' (moved to
5111 gdbsupport/common.m4).
5112 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5114 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5115 * compile/compile-c-support.c: Include
5116 'gdbsupport/gdb-dlfcn.h'.
5117 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5118 * gdb-dlfcn.c: Move to...
5119 * gdbsupport/gdb-dlfcn.c: ... here.
5120 * gdb-dlfcn.h: Move to...
5121 * gdbsupport/gdb-dlfcn.h: ... here.
5123 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5125 * nios2-tdep.c (struct reg_value): Improve comments. Make
5126 the offset field signed.
5128 2019-08-22 Christian Biesinger <cbiesinger@google.com>
5130 * python/lib/gdb/__init__.py (_execute_file): New function.
5131 * python/python.c (python_run_simple_file): Call gdb._execute_file
5134 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5136 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5137 all uses as this was never set to anything but a zero value.
5139 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5141 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5143 2019-08-21 Christian Biesinger <cbiesinger@google.com>
5145 * tui/tui-data.h (tui_gen_win_info): Add an =default
5146 move constructor, required by some GCC versions.
5148 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
5150 * go32-nat.c (go32_sysinfo): Add hygon_p.
5152 2019-08-20 Tom Tromey <tom@tromey.com>
5154 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5155 line_from_reg_element_no, first_reg_element_no_inline,
5156 display_all_data, delete_data_content_windows,
5157 erase_data_content>: Now private.
5159 2019-08-20 Tom Tromey <tom@tromey.com>
5161 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5162 (tui_unhighlight_win, tui_highlight_win)
5163 (tui_win_info::make_window): Update.
5164 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5166 2019-08-20 Tom Tromey <tom@tromey.com>
5168 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5169 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5170 (MAX_PID_WIDTH): Move to tui-stack.c.
5171 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5172 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5173 (MAX_PID_WIDTH): Move from tui-data.h.
5175 2019-08-20 Tom Tromey <tom@tromey.com>
5177 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5178 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5180 (tui_gen_win_info::make_window): Rename from tui_make_window.
5181 (tui_win_info::make_window): New method.
5182 (tui_gen_win_info::make_visible): Update.
5183 * tui/tui-source.c (tui_source_window::set_contents): Update.
5184 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5185 (tui_data_window::display_registers_from): Update.
5186 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5187 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5191 (struct tui_win_info) <make_window>: Declare.
5192 <can_box>: Now virtual.
5193 <title>: New member.
5194 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5195 * tui/tui-command.c (tui_cmd_window::resize): Update.
5197 2019-08-20 Tom Tromey <tom@tromey.com>
5199 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5200 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5201 (tui_data_window::check_register_values): Update.
5203 2019-08-20 Tom Tromey <tom@tromey.com>
5205 * tui/tui-regs.h (struct tui_data_window): Use
5206 DISABLE_COPY_AND_ASSIGN.
5207 <regs_content>: Change type, removing unique_ptr.
5208 <tui_data_window>: Add move constructor.
5209 * tui/tui-regs.c (tui_data_window::show_registers)
5210 (tui_data_window::show_register_group)
5211 (tui_data_window::display_registers_from)
5212 (tui_data_window::display_registers_from)
5213 (tui_data_window::first_data_item_displayed)
5214 (tui_data_window::delete_data_content_windows)
5215 (tui_data_window::rerender, tui_data_window::refresh_window)
5216 (tui_data_window::check_register_values): Update.
5218 2019-08-20 Tom Tromey <tom@tromey.com>
5220 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5221 show_register_group>: Declare.
5222 (tui_show_register_group): Don't declare.
5223 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5225 (tui_data_window::show_register_group): Rename from
5226 tui_show_register_group.
5227 (tui_data_window::check_register_values, tui_reg_command):
5229 * tui/tui-layout.c (tui_set_layout): Update.
5231 2019-08-20 Tom Tromey <tom@tromey.com>
5233 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5235 (tui_check_register_values): Don't declare.
5236 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5237 from tui_check_register_values.
5238 * tui/tui-hooks.c (tui_register_changed): Update.
5240 2019-08-20 Tom Tromey <tom@tromey.com>
5242 * tui/tui-regs.c (tui_reg_layout): Move later.
5243 (tui_show_registers): Don't enable TUI mode or change layout.
5245 2019-08-20 Tom Tromey <tom@tromey.com>
5247 * tui/tui-regs.h (struct tui_data_item_window)
5248 <~tui_data_item_window>: Remove.
5249 <content>: Now a unique_xmalloc_ptr.
5250 * tui/tui-regs.c (tui_register_format): Return a
5252 (tui_get_register): Update.
5253 (~tui_data_item_window): Remove.
5254 (tui_data_window::display_registers_from, tui_display_register):
5256 * tui/tui-io.h (tui_expand_tabs): Update.
5257 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5258 Remove "col" parameter.
5260 2019-08-20 Tom Tromey <tom@tromey.com>
5262 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5264 * tui/tui-regs.c (~tui_data_item_window): Update.
5266 2019-08-20 Tom Tromey <tom@tromey.com>
5268 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5271 2019-08-20 Tom Tromey <tom@tromey.com>
5273 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5275 2019-08-20 Tom Tromey <tom@tromey.com>
5277 * tui/tui-source.h (struct tui_source_window): Update.
5278 * tui/tui-regs.c (tui_show_registers): Update.
5279 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5280 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5281 (NO_REGS_STRING): Remove defines.
5283 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
5285 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5286 unnecessary thread walk if remote doesn't support the packet.
5288 2019-08-19 Tom Tromey <tromey@adacore.com>
5290 * python/py-value.c (value_has_field): Fix indentation.
5292 2019-08-19 Tom Tromey <tromey@adacore.com>
5294 * printcmd.c (do_one_display, info_display_command): Update.
5295 * block.h (contained_in): Return bool. Add allow_nested
5297 * block.c (contained_in): Return bool. Add allow_nested
5300 2019-08-19 Tom Tromey <tom@tromey.com>
5302 * configure: Rebuild.
5303 * configure.ac: Disallow the combination of -static-libstdc++ and
5305 * source-cache.c (get_language_name): Handle rust.
5306 (source_cache::get_source_lines): Ignore highlighting exceptions.
5308 2019-08-16 Tom Tromey <tom@tromey.com>
5310 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5311 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5312 (struct tui_source_window_base) <make_visible, refresh_window,
5313 resize>: Remove methods.
5314 <execution_info>: Remove field.
5315 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5316 (tui_show_source_line, tui_source_window_base)
5317 (~tui_source_window_base): Update.
5318 (tui_source_window_base::resize)
5319 (tui_source_window_base::make_visible)
5320 (tui_source_window_base::refresh_window): Remove.
5321 (tui_source_window_base::update_exec_info): Update.
5322 * tui/tui-source.c (tui_source_window::set_contents): Update.
5323 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5325 2019-08-16 Tom Tromey <tom@tromey.com>
5327 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5328 deprecated_query_hook.
5330 2019-08-16 Tom Tromey <tom@tromey.com>
5332 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5333 (tui_update_source_windows_with_line): Update.
5334 * tui/tui-source.h (struct tui_source_window)
5335 <show_symtab_source>: Declare.
5336 (tui_show_symtab_source): Don't declare.
5337 * tui/tui-source.c (tui_show_symtab_source): Rename from
5338 tui_show_symtab_source.
5340 2019-08-16 Tom Tromey <tom@tromey.com>
5342 * tui/tui-winsource.h (struct tui_source_window_base)
5343 <set_contents>: Declare.
5344 * tui/tui-winsource.c
5345 (tui_source_window_base::update_source_window_as_is): Update.
5346 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5348 (tui_set_source_content): Don't declare.
5349 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5350 tui_set_source_content.
5351 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5353 (tui_set_disassem_content): Don't declare.
5354 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5355 tui_set_disassem_content.
5357 2019-08-16 Tom Tromey <tom@tromey.com>
5359 * tui/tui-winsource.h (struct tui_source_window_base)
5360 <update_breakpoint_info>: Declare.
5361 (tui_update_breakpoint_info): Don't declare.
5362 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5363 (tui_update_all_breakpoint_info): Update.
5364 (tui_source_window_base::update_breakpoint_info): Rename from
5365 tui_update_breakpoint_info.
5366 (tui_source_window_base::update_exec_info): Update.
5368 2019-08-16 Tom Tromey <tom@tromey.com>
5370 * tui/tui-winsource.h (struct tui_source_window_base)
5371 <update_source_window>: Declare.
5372 (tui_update_source_window): Don't declare.
5373 * tui/tui-winsource.c
5374 (tui_source_window_base::update_source_window): Rename from
5375 tui_update_source_window.
5376 (tui_source_window_base::rerender): Update.
5377 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5378 * tui/tui-disasm.c (tui_show_disassem)
5379 (tui_show_disassem_and_update_source)
5380 (tui_disasm_window::maybe_update): Update.
5382 2019-08-16 Tom Tromey <tom@tromey.com>
5384 * tui/tui-winsource.h (struct tui_source_window_base)
5385 <update_source_window_as_is>: Declare.
5386 (tui_update_source_window_as_is): Don't declare.
5387 * tui/tui-winsource.c (tui_update_source_window): Update
5388 (tui_source_window_base::update_source_window_as_is): Rename from
5389 tui_update_source_window_as_is.
5390 (tui_source_window_base::refill): Update.
5391 * tui/tui-source.c (tui_show_symtab_source): Update.
5392 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5395 2019-08-16 Tom Tromey <tom@tromey.com>
5397 * tui/tui-winsource.h (tui_update_source_window)
5398 (tui_update_source_window_as_is): Remove "noerror" parameter.
5399 * tui/tui-winsource.c (tui_update_source_window)
5400 (tui_update_source_window_as_is): Remove "noerror" parameter.
5401 (tui_update_source_windows_with_addr)
5402 (tui_update_source_windows_with_line)
5403 (tui_source_window_base::rerender)
5404 (tui_source_window_base::refill): Update.
5405 * tui/tui-source.h (tui_set_source_content)
5406 (tui_show_symtab_source): Remove "noerror" parameter.
5407 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5409 (tui_show_symtab_source): Likewise.
5410 (tui_source_window::maybe_update): Update.
5411 * tui/tui-disasm.c (tui_show_disassem)
5412 (tui_show_disassem_and_update_source)
5413 (tui_disasm_window::do_scroll_vertical)
5414 (tui_disasm_window::maybe_update): Update.
5416 2019-08-16 Tom Tromey <tom@tromey.com>
5418 * tui/tui.c (tui_is_window_visible): Update.
5419 * tui/tui-wingeneral.c (tui_make_window)
5420 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5421 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5422 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5423 (tui_set_win_height_command, parse_scrolling_args): Update.
5424 * tui/tui-source.c (tui_source_window::style_changed): Update.
5425 * tui/tui-regs.c (tui_show_registers)
5426 (tui_data_window::first_data_item_displayed)
5427 (tui_data_window::delete_data_content_windows)
5428 (tui_check_register_values, tui_reg_command): Update.
5429 * tui/tui-disasm.c (tui_show_disassem): Update.
5430 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5432 <is_visible>: Remove field.
5433 * tui/tui-data.c (tui_next_win, tui_prev_win)
5434 (tui_delete_invisible_windows): Update.
5436 2019-08-16 Tom Tromey <tom@tromey.com>
5438 * tui/tui-winsource.h (struct tui_source_window_base)
5439 <m_has_locator>: Remove.
5440 * tui/tui-layout.c (show_source_disasm_command, show_data)
5441 (show_source_or_disasm_and_command): Update.
5443 2019-08-16 Alan Hayward <alan.hayward@arm.com>
5445 * NEWS (Other MI changes): New subsection.
5446 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5447 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5448 * arch-utils.c (default_get_pc_address_flags): New function.
5449 * arch-utils.h (default_get_pc_address_flags): New declaration.
5450 * gdbarch.sh: Add get_pc_address_flags.
5451 * gdbarch.c: Regenerate.
5452 * gdbarch.h: Likewise.
5453 * stack.c (print_pc): New function.
5454 (print_frame_info) (print_frame): Call print_pc.
5456 2019-08-16 Tom de Vries <tdevries@suse.de>
5458 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5459 print_objfile_section_info.
5461 2019-08-15 Tom Tromey <tom@tromey.com>
5463 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5464 calling update_cmdwin_start_line.
5465 * tui/tui-winsource.h (struct tui_source_window_base)
5466 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5467 <rerender>: Declare.
5468 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5470 (tui_source_window_base::set_new_height): Remove.
5471 (tui_source_window_base::rerender): Rename from
5472 do_make_visible_with_new_height.
5473 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5475 (tui_win_info::make_invisible_and_set_new_height)
5476 (tui_win_info::make_visible_with_new_height): Remove.
5477 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5479 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5480 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5481 do_make_visible_with_new_height>: Don't declare.
5482 <rerender>: Declare.
5483 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5485 (tui_data_window::do_make_visible_with_new_height): Remove.
5486 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5487 call tui_show_locator_content.
5488 (tui_gen_win_info::resize): Call rerender.
5489 (show_source_or_disasm_and_command): Don't call
5490 tui_show_locator_content.
5491 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5493 (struct tui_win_info) <rerender>: Declare.
5494 <set_new_height, make_invisible_and_set_new_height,
5495 make_visible_with_new_height>: Don't declare.
5496 * tui/tui-data.c (tui_win_list::rerender): New method.
5497 * tui/tui-command.h (struct tui_cmd_window)
5498 <do_make_visible_with_new_height>: Don't declare.
5500 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5502 2019-08-15 Tom Tromey <tromey@adacore.com>
5504 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5505 * ada-lang.c (ada_enum_name): Likewise.
5507 2019-08-15 Christian Biesinger <cbiesinger@google.com>
5509 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5511 (GdbOutputErrorFile): Likewise.
5512 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5514 (execute_unwinders): Rename to have a leading underscore.
5515 (auto_load_packages): Likewise.
5516 (global scope): Adjust call to auto_load_packages accordingly.
5517 (GdbSetPythonDirectory): Likewise.
5518 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5519 instead of execute_unwinders.
5521 2019-08-15 Tom Tromey <tom@tromey.com>
5523 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5524 (show_data): Don't change window visibility.
5525 (tui_gen_win_info::resize): Remove special case for command
5526 window. Use wresize, when available.
5527 (show_source_or_disasm_and_command): Don't change window
5529 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5530 <make_visible>: New method.
5531 * tui/tui-command.c (tui_cmd_window::resize): New method.
5533 2019-08-15 Tom Tromey <tom@tromey.com>
5535 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5536 (struct tui_source_windows): New.
5537 * tui/tui-winsource.c (tui_display_main): Update.
5538 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5539 (new_height_ok, parse_scrolling_args): Update.
5540 * tui/tui-layout.c (show_layout, show_data): Update.
5541 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5542 (tui_add_to_source_windows): Don't declare.
5543 * tui/tui-data.c (source_windows, tui_source_windows)
5544 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5546 2019-08-15 Tom Tromey <tom@tromey.com>
5548 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5550 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5551 * tui/tui-layout.c (show_source_disasm_command, show_data):
5553 (tui_gen_win_info::resize): Rename.
5554 (show_source_or_disasm_and_command): Update.
5555 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5558 2019-08-15 Tom Tromey <tom@tromey.com>
5560 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5561 * tui/tui-interp.c (tui_interp::init): Don't call
5562 tui_initialize_static_data.
5563 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5565 2019-08-15 Tom Tromey <tom@tromey.com>
5567 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5568 examine tui_win_list.
5570 2019-08-15 Tom Tromey <tom@tromey.com>
5572 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5573 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5574 tui_clear_source_content.
5575 (tui_clear_source_content): Remove.
5576 (tui_source_window_base::do_erase_source_content): Hoist call to
5578 * tui/tui-stack.c (tui_show_frame_info): Don't call
5579 tui_clear_source_content.
5581 2019-08-15 Tom Tromey <tom@tromey.com>
5583 * tui/tui-winsource.h (struct tui_source_window_base)
5584 <do_erase_source_content>: New method.
5585 <erase_source_content>: New method.
5586 (tui_erase_source_content): Don't declare.
5587 * tui/tui-winsource.c (tui_clear_source_content): Update.
5588 (tui_source_window_base::do_erase_source_content): Rename from
5589 tui_erase_source_content.
5590 (tui_source_window_base::show_source_content): Update.
5591 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5592 * tui/tui-source.h (struct tui_source_window)
5593 <erase_source_content>: New method.
5594 * tui/tui-disasm.h (struct tui_disasm_window)
5595 <erase_source_content>: New method.
5597 2019-08-15 Tom Tromey <tom@tromey.com>
5599 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5600 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5602 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5603 * tui/tui-source.c (tui_set_source_content): Update.
5604 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5606 2019-08-15 Tom Tromey <tom@tromey.com>
5608 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5609 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5611 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5613 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5615 (tui_source_window::maybe_update): Update.
5617 2019-08-15 Tom Tromey <tom@tromey.com>
5619 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5620 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5622 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5624 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5626 (tui_disasm_window::maybe_update): Update.
5628 2019-08-15 Tom Tromey <tom@tromey.com>
5630 * tui/tui-winsource.h (struct tui_source_window_base)
5631 <maybe_update>: Declare.
5632 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5634 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5636 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5637 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5639 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5641 2019-08-15 Tom Tromey <tom@tromey.com>
5643 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5645 2019-08-15 Tom Tromey <tom@tromey.com>
5647 * tui/tui-wingeneral.c: Include tui-stack.h.
5648 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5649 (struct tui_locator_window): Move from tui-data.h.
5650 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5651 (tui_initialize_static_data): Move from tui-data.c.
5652 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5653 (struct tui_locator_window): Move to tui-stack.c.
5654 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5655 (tui_initialize_static_data): Move to tui-stack.c.
5657 2019-08-15 Tom Tromey <tom@tromey.com>
5659 * tui/tui-layout.c (show_source_disasm_command)
5660 (show_source_or_disasm_and_command): Use make_visible method, not
5662 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5665 2019-08-15 Tom Tromey <tom@tromey.com>
5667 * tui/tui-wingeneral.h (tui_make_window): Update.
5668 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5670 (tui_gen_win_info::make_visible): Update.
5671 * tui/tui-regs.c (tui_data_window::display_registers_from):
5673 * tui/tui-layout.c (show_source_disasm_command)
5674 (show_source_or_disasm_and_command): Update.
5675 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5676 (enum tui_box): Remove.
5677 (struct tui_win_info) <can_box>: New method.
5678 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5681 2019-08-15 Tom de Vries <tdevries@suse.de>
5683 * linux-nat-trad.c: Include gdbarch.h.
5685 2019-08-14 Alan Hayward <alan.hayward@arm.com>
5687 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5690 2019-08-14 Tom Tromey <tromey@adacore.com>
5692 * darwin-nat.c: Include gdbarch.h.
5693 * darwin-nat-info.c: Include gdbarch.h.
5695 2019-08-13 Tom Tromey <tom@tromey.com>
5697 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5699 * tui/tui-data.c (tui_initialize_static_data): Update.
5701 2019-08-13 Tom Tromey <tom@tromey.com>
5703 * tui/tui-winsource.h (struct tui_exec_info_window)
5704 <~tui_exec_info_window, maybe_allocate_content, get_content,
5706 (struct tui_source_window_base) <set_exec_info_content,
5707 show_exec_info_content>: Don't declare.
5708 * tui/tui-winsource.c
5709 (tui_exec_info_window::maybe_allocate_content): Remove.
5710 (tui_source_window_base::update_exec_info): Rename from
5711 set_exec_info_content.
5712 (tui_source_window_base::show_exec_info_content)
5713 (tui_source_window_base::update_exec_info): Remove.
5715 2019-08-13 Tom Tromey <tom@tromey.com>
5717 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5719 * tui/tui-winsource.c (tui_update_source_window_as_is)
5720 (tui_update_source_windows_with_addr, tui_erase_source_content):
5722 (tui_clear_exec_info_content): Remove.
5724 2019-08-13 Tom Tromey <tom@tromey.com>
5726 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5728 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5729 call tui_erase_exec_info_content.
5730 (tui_clear_exec_info_content): Rename from
5731 tui_erase_exec_info_content.
5732 (tui_clear_exec_info_content): Delete.
5734 2019-08-13 Tom Tromey <tom@tromey.com>
5736 * tui/tui-winsource.h (struct tui_source_window_base)
5737 <show_exec_info_content>: Declare.
5738 (tui_show_exec_info_content): Don't declare.
5739 * tui/tui-winsource.c
5740 (tui_source_window_base::show_exec_info_content): Rename from
5741 tui_show_exec_info_content.
5742 (tui_source_window_base::update_exec_info): Update.
5744 2019-08-13 Tom Tromey <tom@tromey.com>
5746 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5747 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5748 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5749 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5750 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5751 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5754 2019-08-13 Tom Tromey <tom@tromey.com>
5756 * tui/tui-winsource.h (struct tui_source_window_base)
5757 <update_exec_info>: Declare.
5758 (tui_update_exec_info): Don't declare.
5759 * tui/tui-winsource.c (tui_update_source_window_as_is)
5760 (tui_source_window_base::refresh_all)
5761 (tui_update_all_breakpoint_info): Update.
5762 (tui_source_window_base::update_exec_info): Rename from
5763 tui_update_exec_info.
5764 * tui/tui-stack.c (tui_show_frame_info): Update.
5766 2019-08-13 Tom Tromey <tom@tromey.com>
5768 * tui/tui-winsource.h (struct tui_source_window_base)
5769 <set_exec_info_content>: Declare.
5770 (tui_set_exec_info_content): Don't declare.
5771 * tui/tui-winsource.c
5772 (tui_source_window_base::set_exec_info_content): Rename from
5773 tui_set_exec_info_content.
5774 (tui_update_exec_info): Update.
5776 2019-08-13 Tom Tromey <tom@tromey.com>
5778 * tui/tui-winsource.h (struct tui_source_window_base)
5779 <show_source_content>: Declare.
5780 (tui_show_source_content): Don't declare.
5781 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5782 (tui_source_window_base::show_source_content): Rename from
5783 tui_show_source_content.
5784 (tui_source_window_base::refresh_all): Update.
5785 * tui/tui-layout.c (show_source_disasm_command)
5786 (show_source_or_disasm_and_command): Update.
5788 2019-08-13 Tom Tromey <tom@tromey.com>
5790 * tui/tui-winsource.c (tui_erase_source_content)
5791 (tui_show_source_content, tui_source_window_base::refresh_all):
5793 * tui/tui-wingeneral.h
5794 (tui_check_and_display_highlight_if_needed): Don't declare.
5795 * tui/tui-wingeneral.c
5796 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5797 check_and_display_highlight_if_needed.
5798 * tui/tui-win.c (tui_rehighlight_all)
5799 (tui_win_info::make_visible_with_new_height): Update.
5800 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5801 (tui_data_window::erase_data_content)
5802 (tui_data_window::display_all_data): Update.
5803 * tui/tui-data.h (struct tui_win_info)
5804 <check_and_display_highlight_if_needed>: Declare.
5806 2019-08-13 Tom Tromey <tom@tromey.com>
5808 * tui/tui-win.c (tui_resize_all): Call
5809 tui_delete_invisible_windows.
5810 * tui/tui-layout.c (show_layout): Call
5811 tui_delete_invisible_windows.
5812 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5813 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5815 2019-08-13 Tom Tromey <tom@tromey.com>
5817 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5818 tui_add_win_to_layout.
5820 2019-08-13 Tom Tromey <tom@tromey.com>
5822 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5823 * tui/tui-layout.c (tui_default_win_height): Now static.
5825 2019-08-13 Tom Tromey <tom@tromey.com>
5827 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5829 (show_source_disasm_command, show_source_or_disasm_and_command):
5830 Don't check current layout.
5832 2019-08-13 Tom Tromey <tom@tromey.com>
5834 * tui/tui-wingeneral.c (make_all_visible): Remove.
5835 (tui_make_all_invisible): Simplify.
5836 * tui/tui-layout.c (tui_make_all_invisible): Move from
5837 tui-wingeneral.c; simplify.
5838 (show_layout): Hoist call to tui_make_all_invisible.
5839 (show_data): Don't call tui_make_all_invisible.
5841 2019-08-13 Tom Tromey <tom@tromey.com>
5843 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5844 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5846 2019-08-13 Tom Tromey <tom@tromey.com>
5848 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5850 (show_source_disasm_command, show_data)
5851 (show_source_or_disasm_and_command): Don't use
5852 tui_set_current_layout_to.
5853 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5854 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5856 (tui_set_current_layout_to): Remove.
5858 2019-08-13 Tom Tromey <tom@tromey.com>
5860 * tui/tui-layout.c (tui_set_layout): Update.
5861 * tui/tui-data.h (struct tui_layout_def): Remove.
5862 (tui_layout_def): Don't declare.
5863 * tui/tui-data.c (layout_def): Remove.
5864 (tui_layout_def): Remove.
5866 2019-08-13 Tom Tromey <tom@tromey.com>
5868 * tui/tui-winsource.h (struct tui_source_window_base)
5869 <clear_detail>: No longer "override".
5870 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5871 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5872 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5873 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5875 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5877 2019-08-13 Tom Tromey <tromey@adacore.com>
5879 * tracepoint.c: Don't include readline.h or history.h.
5881 2019-08-12 Tom Tromey <tom@tromey.com>
5883 * configure: Rebuild.
5884 * configure.ac: Check for readline 7.
5885 * NEWS: Mention readline 7 requirement.
5888 2019-08-12 Tom Tromey <tom@tromey.com>
5890 * mingw-hdep.c (gdb_select): Remove readline hack.
5892 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5894 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5895 when the function fails.
5897 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5899 * s390-tdep.c (s390_type_align): New function.
5900 (s390_gdbarch_init): Set it as type_align gdbarch method.
5902 2019-08-09 Tom de Vries <tdevries@suse.de>
5905 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5906 pc_low with relocation offset.
5908 2019-08-07 Tom Tromey <tromey@adacore.com>
5910 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5911 (print_frame_args): Update.
5912 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5914 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5915 * frame.h (struct frame_arg): Add initializers.
5916 <error>: Now a unique_xmalloc_ptr.
5918 2019-08-07 Alan Hayward <alan.hayward@arm.com>
5920 * NEWS: Expand the Pointer Authentication entry.
5921 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5922 (aarch64_frame_unmask_lr): ... to this.
5923 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5924 Call aarch64_frame_unmask_lr.
5925 * frame.c (struct frame_info): Add "masked" variable.
5926 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5927 (fprint_frame): Check for masked pc.
5928 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5930 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5931 * stack.c (print_frame): Check for masked pc.
5933 2019-08-06 Tom Tromey <tom@tromey.com>
5935 * stabsread.c (patch_block_stabs, read_one_struct_field)
5936 (read_enum_type): Use obstack_strndup.
5937 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5938 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5939 * dwarf2read.c (guess_full_die_structure_name)
5940 (anonymous_struct_prefix): Use obstack_strndup.
5941 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5942 * c-exp.y (yylex): Use obstack_strndup.
5943 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5944 (write_var_or_type): Use obstack_strndup.
5946 2019-08-06 Tom Tromey <tom@tromey.com>
5948 * symfile.c (reread_symbols): Use obstack_strdup.
5949 * stabsread.c (read_type): Use obstack_strdup.
5950 * gdb_obstack.h (obstack_strdup): New overload.
5951 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5952 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5953 (dwarf2_canonicalize_name): Use obstack_strdup.
5954 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5955 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5958 2019-08-06 Tom Tromey <tom@tromey.com>
5960 * gdb_obstack.h (obstack_strdup): Define.
5961 * gdb_obstack.c (obstack_strdup): Don't define.
5963 2019-08-06 Tom Tromey <tom@tromey.com>
5965 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5967 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5969 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5970 * stabsread.c (common_block_start): Use obstack_strdup.
5971 * objfiles.c (set_objfile_main_name, objfile): Use
5973 * namespace.c (add_using_directive): Use obstack_strdup.
5974 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5975 * jit.c (finalize_symtab): Use obstack_strdup.
5976 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5977 (guess_partial_die_structure_name, partial_die_info::fixup)
5978 (dwarf2_name): Use obstack_strdup.
5979 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5981 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5982 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5984 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5986 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5988 * unittests/help-doc-selftests.c: New file.
5989 * Makefile.in: Add the new file.
5991 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5993 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5994 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5995 the full first line, except when FOR_VALUE_PREFIX. In this case,
5996 the trailing '.' is not output, and the first character is uppercased.
5997 (print_help_for_command): Update call to print_doc_line.
5998 (print_doc_of_command): Likewise.
5999 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6000 * cli/cli-option.c (append_indented_doc): Do not append newline.
6001 (build_help_option): Append newline after first appended_indented_doc
6002 only if a second call is done.
6003 (build_help): Append 2 new lines before each option, except the first
6005 * compile/compile.c (_initialize_compile): Add new lines after
6006 %OPTIONS%, when not at the end of the help.
6007 Change help doc or code
6008 producing the help doc to respect the invariants.
6009 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6010 Also removed the new line after 'Options:', as all other commands
6011 do not put an empty line between 'Options:' and the first option.
6012 * printcmd.c (_initialize_printcmd): Likewise.
6013 * stack.c (_initialize_stack): Likewise.
6014 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6015 incorrectly telling COMMAND is optional.
6016 * ada-lang.c (_initialize_ada_language): Change help doc or code
6017 producing the help doc to respect the invariants.
6018 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6019 * breakpoint.c (_initialize_breakpoint): Likewise.
6020 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6021 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6022 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6023 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6024 _initialize_cli_style): Likewise.
6025 * corelow.c (core_target_info): Likewise.
6026 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6027 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6028 * filesystem.c (_initialize_filesystem): Likewise.
6029 * frame.c (_initialize_frame): Likewise.
6030 * gnu-nat.c (add_task_commands): Likewise.
6031 * infcall.c (_initialize_infcall): Likewise.
6032 * infcmd.c (_initialize_infcmd): Likewise.
6033 * interps.c (_initialize_interpreter): Likewise.
6034 * language.c (_initialize_language): Likewise.
6035 * linux-fork.c (_initialize_linux_fork): Likewise.
6036 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6037 * maint.c (_initialize_maint_cmds): Likewise.
6038 * memattr.c (_initialize_mem): Likewise.
6039 * printcmd.c (_initialize_printcmd): Likewise.
6040 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6042 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6043 * record-btrace.c (_initialize_record_btrace): Likewise.
6044 * record-full.c (_initialize_record_full): Likewise.
6045 * record.c (_initialize_record): Likewise.
6046 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6047 * regcache.c (_initialize_regcache): Likewise.
6048 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6049 _initialize_remote): Likewise.
6050 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6051 * serial.c (_initialize_serial): Likewise.
6052 * skip.c (_initialize_step_skip): Likewise.
6053 * source.c (_initialize_source): Likewise.
6054 * stack.c (_initialize_stack): Likewise.
6055 * symfile.c (_initialize_symfile): Likewise.
6056 * symtab.c (_initialize_symtab): Likewise.
6057 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6058 * top.c (init_main): Likewise.
6059 * tracefile-tfile.c (tfile_target_info): Likewise.
6060 * tracepoint.c (_initialize_tracepoint): Likewise.
6061 * tui/tui-win.c (_initialize_tui_win): Likewise.
6062 * utils.c (add_internal_problem_command): Likewise.
6063 * valprint.c (value_print_option_defs): Likewise.
6065 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
6068 * configure.ac: Drop enable-libmcheck support.
6069 * configure, config.in: Rebuild.
6070 * libmcheck.m4: Remove.
6071 * acinclude.m4: Don't include it.
6072 * Makefile.in: Don't distribute it.
6073 * top.c (print_gdb_configuration): Don't mention it.
6075 2019-08-06 Tom Tromey <tom@tromey.com>
6077 * utils.c (set_output_style): Sometimes pass stream to
6079 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6080 * record-btrace.c (btrace_insn_history): Update.
6081 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6083 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6084 Update initializers.
6085 <m_uiout>: New field.
6087 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6088 Remove "uiout" parameter.
6089 (dump_insns): Update.
6090 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6091 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6093 2019-08-06 Christian Biesinger <cbiesinger@google.com>
6095 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6096 (error_in_psymtab_expansion): Likewise.
6097 (lookup_symbol_via_quick_fns): Likewise.
6098 (basic_lookup_transparent_type_quick): Likewise.
6099 (basic_lookup_transparent_type_1): Likewise.
6101 2019-08-06 Tom Tromey <tromey@adacore.com>
6103 * source.c (last_source_error): Now bool.
6104 (print_source_lines_base): Make "noprint" bool. Only open
6105 source file when last_source_visited changes.
6107 2019-08-06 Tom Tromey <tromey@adacore.com>
6109 * annotate.c (annotate_source_line): Use g_source_cache.
6110 * source-cache.c (source_cache::get_plain_source_lines): Change
6111 parameters. Populate m_offset_cache.
6112 (source_cache::ensure): New method.
6113 (source_cache::get_line_charpos): New method.
6114 (extract_lines): Move lower. Change parameters.
6115 (source_cache::get_source_lines): Move lower.
6116 * source-cache.h (class source_cache): Update comment.
6117 <get_line_charpos>: New method.
6118 <get_source_lines>: Update comment.
6119 <clear>: Clear m_offset_cache.
6120 <get_plain_source_lines>: Change parameters.
6121 <ensure>: New method
6122 <m_offset_cache>: New member.
6123 * source.c (forget_cached_source_info_for_objfile): Update.
6124 (info_source_command): Use g_source_cache.
6125 (find_source_lines, open_source_file_with_line_charpos): Remove.
6126 (print_source_lines_base, search_command_helper): Use g_source_cache.
6127 * source.h (open_source_file_with_line_charpos): Don't declare.
6128 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6129 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6132 2019-08-06 Tom Tromey <tromey@adacore.com>
6134 * source-cache.c (source_cache::get_plain_source_lines):
6135 Remove "first_line" and "last_line" parameters.
6136 (source_cache::get_source_lines): Cache plain text.
6137 * source-cache.h (class source_cache)
6138 <get_plain_source_lines>: Update.
6140 2019-08-06 Tom Tromey <tromey@adacore.com>
6142 * source-cache.c (extract_lines): No longer a method.
6143 Changed type of parameter. Include final newline.
6144 (selftests::extract_lines_test): New function.
6145 (_initialize_source_cache): Likewise.
6146 * source-cache.h (class source_cache)
6147 <extract_lines>: Don't declare.
6149 2019-08-06 Tom Tromey <tromey@adacore.com>
6151 * breakpoint.c (init_breakpoint_sal): Update.
6152 (breakpoint): Update.
6153 * breakpoint.h (struct breakpoint) <filter>: Now a
6156 2019-08-05 Christian Biesinger <cbiesinger@google.com>
6158 * NEWS: Mention dictionary access on blocks.
6159 * python/py-block.c (blpy_getitem): New function.
6160 (block_object_as_mapping): New struct.
6161 (block_object_type): Use new struct for tp_as_mapping field.
6163 2019-08-05 Christian Biesinger <cbiesinger@google.com>
6165 * objfiles.h (objfile): Add a comment describing partial symbols.
6167 2019-08-05 Tom Tromey <tromey@adacore.com>
6169 * compile/compile.c (_initialize_compile): Use _(), not N_().
6170 * thread.c (_initialize_thread): Use _(), not N_().
6171 * stack.c (_initialize_stack): Use _(), not N_().
6172 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6174 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6176 * dwarf2read.c (struct dw2_symtab_iterator):
6177 <want_specific_block>: Remove.
6178 <block_index>: Change type to gdb::optional.
6179 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6180 change type of BLOCK_INDEX parameter to gdb::optional.
6181 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6182 (dw2_lookup_symbol): Don't pass argument for
6183 WANT_SPECIFIC_BLOCK.
6184 (dw2_expand_symtabs_for_function): Don't pass argument for
6185 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6186 (class dw2_debug_names_iterator)
6187 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6188 parameter, change BLOCK_INDEX type to gdb::optional.
6189 <m_want_specific_block>: Remove.
6190 <m_block_index>: Change type to gdb::optional.
6191 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6192 gdb::optional. Re-write in function of gdb::optional.
6193 (dw2_debug_names_lookup_symbol): Don't pass argument for
6194 WANT_SPECIFIC_BLOCK.
6195 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6196 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6199 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6201 * NEWS: Mention changes to "info sources" command.
6203 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6205 * symtab.c (filename_partial_match_opts): New struct type.
6206 (struct output_source_filename_data): New members
6207 regexp, c_regexp, partial_match.
6208 (output_source_filename): Use new members to decide to print file.
6209 (info_sources_option_defs): New variable.
6210 (make_info_sources_options_def_group, print_info_sources_header,
6211 info_sources_command_completer):
6213 (info_sources_command): Read new optional arguments.
6214 (_initialize_symtab): Update info sources help.
6216 2019-08-02 Alexandre Oliva <oliva@adacore.com>
6218 * ada-lang.c (exception_support_info_v0): Renamed from...
6219 (default_exception_support_info): ... this. Create new
6221 (ada_has_this_exception_support): Look up catch_handlers_sym.
6222 (ada_exception_support_info_sniffer): Try v0 after default.
6224 2019-08-01 Tom Tromey <tromey@adacore.com>
6226 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6229 2019-08-01 Christian Biesinger <cbiesinger@google.com>
6231 * s12z-tdep.c: Fix include path for s12z-opc.h.
6233 2019-08-01 Alan Hayward <alan.hayward@arm.com>
6235 * NEWS: Require GNU make 3.82.
6237 2019-07-16 Tom Tromey <tom@tromey.com>
6239 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6242 2019-07-30 Tom Tromey <tromey@adacore.com>
6244 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6246 2019-07-30 Kevin Buettner <kevinb@redhat.com>
6248 * printcmd.c (print_address_symbolic): Print negative offsets.
6249 (build_address_symbolic): Force signed arithmetic when computing
6252 2019-07-30 Christian Biesinger <cbiesinger@google.com>
6254 PR/24474: Add a function to lookup static variables.
6255 * NEWS: Mention this new function.
6256 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6257 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6258 * python/python.c (python_GdbMethods): Add new function.
6260 2019-07-29 Christian Biesinger <cbiesinger@google.com>
6262 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6263 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6264 (objfpy_lookup_static_symbol): New function.
6265 (objfile_object_methods): Add new functions.
6267 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6269 * NEWS: Mention 'set|show print frame-info'. Mention new
6270 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6271 backtrace argument. Mention that python frame filtering code
6272 is now consistent with what 'backtrace' command prints.
6274 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6276 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6278 (print_frame_info_auto, print_frame_info_source_line,
6279 print_frame_info_location, print_frame_info_source_and_location,
6280 print_frame_info_location_and_address, print_frame_info_short_location):
6282 (struct frame_print_options): New member print_frame_info.
6283 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6284 * stack.h (get_user_print_what_frame_info): New declaration.
6285 (frame_show_address): New declaration.
6286 * stack.c (print_frame_arguments_choices): New value 'presence'.
6287 (print_frame_info_auto, print_frame_info_source_line,
6288 print_frame_info_location, print_frame_info_source_and_location,
6289 print_frame_info_location_and_address, print_frame_info_short_location,
6290 print_frame_info_choices, print_frame_info_print_what): New definitions.
6291 (print_frame_args): Only print dots for args if print frame-arguments
6293 (frame_print_option_defs): New element for "frame-info".
6294 (get_user_print_what_frame_info): New function.
6295 (frame_show_address): Make non static. Move comment to stack.h.
6296 (print_frame_info_to_print_what): New function.
6297 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6298 to decide what to print.
6299 (backtrace_command_1): Handle the new print_frame_arguments_presence
6301 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6302 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6303 (py_print_frame): In non-mi mode, use LOCATION as default for
6304 print_what, similarly to frame information printed directly by
6305 backtrace command. Handle frame-info user option in non MI mode.
6307 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6309 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6310 Add case for debugging 32-bit target on 64-bit host. Revise
6313 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6315 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6316 instead of find_function_entry_range_from_pc.
6318 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6320 * stack.c (find_frame_funname): Remove code which preferred
6321 minsym over symtab sym in "certain pathological cases".
6323 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6324 parameter. Change type of "do_demangle" to bool.
6325 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6326 Pass suitable "prefer_sym_over_minsym" flag to
6327 build_address_symbolic(). Don't output "+" for negative offsets.
6328 * printcmd.c (print_address_symbolic): Update invocation of
6329 build_address_symbolic to include a "prefer_sym_over_minsym"
6331 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6332 Restrict cases in which use of minimal symbol is preferred to that
6333 of a found symbol. Update comments.
6335 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6336 for entry pc when entry pc is out of range for that FDE.
6338 2019-07-26 Brian Callahan <bcallah@openbsd.org>
6341 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6344 2019-07-25 Christian Biesinger <cbiesinger@google.com>
6346 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6347 this function's Python signature.
6350 2019-07-24 Christian Biesinger <cbiesinger@google.com>
6352 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6353 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6354 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6355 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6356 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6359 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6361 * h8300-tdep.c (h8300_register_name_common): New.
6362 h8300_register_name): Use h8300_register_name_common.
6363 (h8300s_register_name): Likewise.
6364 (h8300sx_register_name): Likewise.
6365 (h8300h_register_nam): New.
6366 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6369 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6371 * arm-tdep.c (arm_skip_cmse_entry): New function.
6372 (arm_is_sgstubs_section): New function.
6373 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6375 2019-07-22 Tom Tromey <tom@tromey.com>
6377 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6380 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6382 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6385 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6387 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6388 so that GDB doesn't match any msymbols when searching in the
6390 (print_symbol_info): Print using typedef_print or type_print based
6391 on the type of the symbol. Add updated FIXME comment moved from...
6392 (_initialize_symtab): ... move and update FIXME comment to above.
6394 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6396 * NEWS: Mention adding -q option to "info types".
6397 * symtab.c (struct info_types_options): New struct.
6398 (info_types_options_defs): New variable.
6399 (make_info_types_options_def_group): New function.
6400 (info_types_command): Use gdb::option framework to parse options.
6401 (info_types_command_completer): New function.
6402 (_initialize_symtab): Extend the help text on "info types" and
6403 register command completer.
6405 2019-07-21 Christian Biesinger <cbiesinger@google.com>
6407 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6408 (lookup_symbol_in_objfile): Change int to block_enum and add a
6409 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6411 2019-07-20 Christian Biesinger <cbiesinger@google.com>
6413 * MAINTAINERS (Write After Approval): Add self.
6415 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6417 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6418 instruction to the dummy code region.
6420 2019-07-19 Tom Tromey <tromey@adacore.com>
6422 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6423 (ARGSUSED, PARAMS, __func__): Remove rules.
6425 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6427 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6428 * features/arm/arm-with-iwmmxt.c: Remove.
6429 * features/arm/arm-with-iwmmxt.xml: Remove.
6430 * features/arm/arm-with-m-fpa-layout.c: Remove.
6431 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6432 * features/arm/arm-with-m-vfp-d16.c: Remove.
6433 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6434 * features/arm/arm-with-m.c: Remove.
6435 * features/arm/arm-with-m.xml: Remove.
6436 * features/arm/arm-with-neon.c: Remove.
6437 * features/arm/arm-with-neon.xml: Remove.
6438 * features/arm/arm-with-vfpv2.c: Remove.
6439 * features/arm/arm-with-vfpv2.xml: Remove.
6440 * features/arm/arm-with-vfpv3.c: Remove.
6441 * features/arm/arm-with-vfpv3.xml: Remove.
6443 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6445 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6447 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6449 * arch/aarch32.c (aarch32_create_target_description): Create
6450 target descriptions using features.
6451 * arch/arm.c (arm_create_target_description)
6452 (arm_create_mprofile_target_description): Likewise.
6453 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6455 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6457 * Makefile.in: Add new files.
6458 * aarch32-tdep.c: New file.
6459 * aarch32-tdep.h: New file.
6460 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6461 Call aarch32_read_description.
6462 * arch/aarch32.c: New file.
6463 * arch/aarch32.h: New file.
6464 * arch/arm.c (arm_create_target_description)
6465 (arm_create_mprofile_target_description): New function.
6466 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6467 (arm_create_target_description)
6468 (arm_create_mprofile_target_description): New declaration.
6469 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6470 read_description functions.
6471 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6473 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6474 * arm-tdep.c (tdesc_arm_list): New variable.
6475 (arm_register_g_packet_guesses): Call create description functions.
6476 (arm_read_description) (arm_read_mprofile_description): New
6478 * arm-tdep.h (arm_read_description)
6479 (arm_read_mprofile_description): Add declaration.
6480 * configure.tgt: Add new files.
6482 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6484 * top.c (new_ui_command): Open specified terminal just once.
6486 2019-07-18 Tom Tromey <tromey@adacore.com>
6488 * symtab.c (main_name): Constify return type.
6489 * symfile.c (set_initial_language): Update.
6490 * symtab.h (main_name): Constify return type.
6492 2019-07-17 Tom Tromey <tom@tromey.com>
6494 * tui/tui-winsource.c (tui_update_source_window)
6495 (tui_update_source_window_as_is)
6496 (tui_update_source_windows_with_line): Remove return.
6497 * tui/tui-disasm.c (tui_show_disassem)
6498 (tui_show_disassem_and_update_source): Remove return.
6499 * tui/tui.c (tui_reset): Remove return.
6500 * tui/tui-wingeneral.c
6501 (tui_check_and_display_highlight_if_needed): Remove return.
6503 2019-07-17 Tom Tromey <tom@tromey.com>
6505 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6507 2019-07-17 Tom Tromey <tom@tromey.com>
6509 * tui/tui-winsource.h (struct tui_exec_info_window)
6510 (struct tui_source_window_base): Move from tui-data.h.
6511 * tui/tui-winsource.c: Move many method definitions from
6512 elsewhere. Remove "structuring" comments.
6513 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6514 (tui_source_window_base::refresh_window): Move to
6516 * tui/tui-win.c (tui_source_window_base::refresh_all)
6517 (tui_source_window_base::update_tab_width)
6518 (tui_source_window_base::set_new_height)
6519 (tui_source_window_base::do_make_visible_with_new_height): Move to
6521 * tui/tui-source.h: Update.
6522 * tui/tui-source.c (tui_source_window_base::reset): Move to
6524 * tui/tui-disasm.h: Update.
6525 * tui/tui-data.h (struct tui_exec_info_window): Move to
6527 (struct tui_source_window_base): Likewise.
6528 * tui/tui-data.c (tui_source_window_base::clear_detail)
6529 (tui_source_window_base, ~tui_source_window_base): Move to
6532 2019-07-17 Tom Tromey <tom@tromey.com>
6534 * tui/tui-win.c (tui_resize_all)
6535 (tui_source_window_base::update_tab_width)
6536 (tui_adjust_win_heights): Update.
6537 (tui_win_info::make_invisible_and_set_new_height): Rename from
6538 make_invisible_and_set_new_height.
6539 * tui/tui-data.h (struct tui_win_info)
6540 <make_invisible_and_set_new_height>: New method.
6542 2019-07-17 Tom Tromey <tom@tromey.com>
6544 * tui/tui.c: Update.
6545 * tui/tui-source.h (struct tui_source_window): Move from
6547 * tui/tui-layout.c: Update.
6548 * tui/tui-disasm.c: Update.
6549 * tui/tui-data.h (struct tui_source_window): Move to
6552 2019-07-17 Tom Tromey <tom@tromey.com>
6554 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6556 * tui/tui-data.h (struct tui_disasm_window): Move to
6559 2019-07-17 Tom Tromey <tom@tromey.com>
6561 * tui/tui-regs.h (struct tui_data_item_window): Move from
6563 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6564 * tui/tui-data.h (struct tui_data_item_window): Move to
6566 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6568 2019-07-17 Tom Tromey <tom@tromey.com>
6570 * tui/tui.c: Update.
6571 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6572 (tui_cmd_window::max_height): Move to tui-command.c.
6573 * tui/tui-layout.c: Update.
6574 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6575 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6577 * tui/tui-command.h (struct tui_cmd_window): Move from
6579 * tui/tui-command.c: Remove "structuring" comments.
6580 (tui_cmd_window::clear_detail)
6581 (tui_cmd_window::do_make_visible_with_new_height)
6582 (tui_cmd_window::max_height): Move from elsewhere.
6584 2019-07-17 Tom Tromey <tom@tromey.com>
6586 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6588 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6589 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6591 2019-07-17 Tom Tromey <tom@tromey.com>
6593 * tui/tui.c: Update.
6594 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6596 * tui/tui-windata.h: Remove file.
6597 * tui/tui-windata.c: Remove file.
6598 * tui/tui-win.c (tui_data_window::set_new_height)
6599 (tui_data_window::do_make_visible_with_new_height): Move to
6601 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6602 * tui/tui-regs.c: Remove "structuring" comments.
6603 (tui_data_window::first_data_item_displayed)
6604 (tui_data_window::delete_data_content_windows)
6605 (tui_data_window::erase_data_content)
6606 (tui_data_window::display_all_data)
6607 (tui_data_window::refresh_all)
6608 (tui_data_window::do_scroll_vertical)
6609 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6610 (tui_data_window::do_make_visible_with_new_height)
6611 (tui_data_window::refresh_window): Move from elsewhere.
6612 (_initialize_tui_regs): Move to end of file.
6613 * tui/tui-layout.c: Update.
6614 * tui/tui-hooks.c: Update.
6615 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6616 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6618 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6620 2019-07-17 Tom Tromey <tom@tromey.com>
6622 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6625 2019-07-17 Tom Tromey <tom@tromey.com>
6627 * tui/tui-win.c (tui_source_window_base::set_new_height)
6628 (tui_source_window_base::do_make_visible_with_new_height): Use
6629 m_has_locator field directly.
6630 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6632 (struct tui_source_window_base) <has_locator>: Likewise.
6634 2019-07-17 Tom Tromey <tom@tromey.com>
6636 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6638 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6640 * tui/tui-win.c (tui_source_window_base::set_new_height)
6641 (tui_source_window_base::set_new_height)
6642 (make_invisible_and_set_new_height)
6643 (tui_source_window_base::do_make_visible_with_new_height)
6644 (tui_source_window_base::do_make_visible_with_new_height):
6646 * tui/tui-layout.c (show_source_disasm_command, show_data)
6647 (show_source_or_disasm_and_command): Update.
6648 * tui/tui-layout.c (show_layout): Update.
6650 2019-07-17 Tom Tromey <tom@tromey.com>
6652 * tui/tui-layout.c (make_data_window): Remove.
6653 (show_data): Unify creation and re-initialization cases.
6655 2019-07-17 Tom Tromey <tom@tromey.com>
6657 * tui/tui-layout.c (make_source_window, make_disasm_window):
6659 (show_data): Unify creation and re-initialization cases.
6661 2019-07-17 Tom Tromey <tom@tromey.com>
6663 * tui/tui-layout.c (make_command_window): Remove.
6664 (show_source_disasm_command, show_source_or_disasm_and_command):
6665 Unify creation and re-initialization cases.
6667 2019-07-17 Tom Tromey <tom@tromey.com>
6669 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6670 creation and re-initialization cases.
6672 2019-07-17 Tom Tromey <tom@tromey.com>
6674 * tui/tui-regs.c (tui_get_register): Return void.
6676 2019-07-17 Tom Tromey <tom@tromey.com>
6678 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6681 2019-07-17 Tom Tromey <tom@tromey.com>
6683 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6686 2019-07-17 Tom Tromey <tom@tromey.com>
6688 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6689 * tui/tui-regs.c (tui_reg_layout): New function.
6690 (tui_show_registers, tui_reg_command): Use it.
6691 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6692 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6694 (tui_layout_command): Remove.
6696 2019-07-17 Tom Tromey <tom@tromey.com>
6698 * tui/tui-layout.h (tui/tui-layout): Return void.
6699 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6701 2019-07-17 Tom Tromey <tom@tromey.com>
6703 * tui/tui-layout.c (show_source_disasm_command, show_data):
6705 (reset_locator): Remove.
6706 (show_source_or_disasm_and_command): Update.
6708 2019-07-17 Tom Tromey <tom@tromey.com>
6710 * tui/tui-source.c (tui_source_window_base::reset): Remove
6712 * tui/tui-layout.c (make_command_window, make_source_window)
6713 (make_disasm_window, make_data_window)
6714 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6715 (reset_locator, show_source_or_disasm_and_command): Update.
6716 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6718 (struct tui_source_window_base) <reset>: Likewise.
6720 2019-07-17 Tom Tromey <tom@tromey.com>
6722 * tui/tui-layout.c (show_source_disasm_command): Use
6724 (reset_locator): New function.
6725 (init_and_make_win): Remove.
6726 (show_source_or_disasm_and_command): Use reset_locator.
6728 2019-07-17 Tom Tromey <tom@tromey.com>
6730 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6732 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6734 * tui/tui-source.c (tui_source_window_base::reset): New method.
6735 * tui/tui-layout.c (make_command_window): Don't call
6737 (make_source_window, make_disasm_window): Don't call
6738 make_source_or_disasm_window.
6739 (make_data_window): Don't call init_and_make_win. Change calling
6741 (show_source_disasm_command, show_data): Simplify.
6742 (make_source_or_disasm_window): Remove.
6743 (show_source_or_disasm_and_command): Simplify.
6744 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6745 (struct tui_source_window_base) <reset>: Likewise.
6746 <execution_info>: Remove initializer.
6747 * tui/tui-data.c (tui_source_window_base): Initialize
6750 2019-07-17 Tom Tromey <tom@tromey.com>
6752 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6755 2019-07-17 Tom Tromey <tom@tromey.com>
6757 * tui/tui.c (tui_rl_other_window): Update.
6758 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6759 superclass method first. Always iterate over regs_content.
6760 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6762 * tui/tui-win.c (tui_set_focus_command): Update.
6764 2019-07-17 Tom Tromey <tom@tromey.com>
6766 * tui/tui-win.c (tui_set_focus_command): Rename from
6767 tui_set_focus. Call tui_enable.
6768 (tui_set_focus_command): Remove.
6770 2019-07-17 Tom Tromey <tom@tromey.com>
6772 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6774 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6776 (tui_data_window::refresh_window): Call refresh_window on data
6777 items. Always call superclass refresh_window.
6778 (tui_win_info::refresh): Remove.
6779 (tui_source_window_base::refresh_window): Update.
6780 (tui_refresh_all): Update.
6781 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6783 (show_source_or_disasm_and_command): Likewise.
6784 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6785 (struct tui_source_window_base) <refresh>: Likewise.
6787 2019-07-17 Tom Tromey <tom@tromey.com>
6789 * tui/tui-winsource.c (tui_clear_source_content)
6790 (tui_show_source_content): Update.
6791 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6792 whether content is empty.
6793 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6796 2019-07-17 Tom Tromey <tom@tromey.com>
6798 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6800 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6801 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6803 2019-07-17 Tom Tromey <tom@tromey.com>
6805 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6806 (struct tui_data_item_window): Update.
6808 2019-07-17 Tom Tromey <tom@tromey.com>
6810 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6811 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6814 2019-07-17 Tom Tromey <tom@tromey.com>
6816 * tui/tui-winsource.h (tui_erase_source_content)
6817 (tui_clear_source_content): Remove "display_prompt" parameter.
6818 * tui/tui-winsource.c (tui_update_source_window_as_is)
6819 (tui_update_source_windows_with_addr): Update.
6820 (tui_clear_source_content): Remove "display_prompt" parameter.
6821 (tui_erase_source_content): Likewise. Simplify.
6822 (tui_show_source_content): Update.
6823 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6824 * tui/tui-stack.c (tui_show_frame_info): Update.
6825 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6828 2019-07-17 Tom Tromey <tom@tromey.com>
6830 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6831 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6833 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6836 2019-07-17 Tom Tromey <tom@tromey.com>
6838 * tui/tui-winsource.c (tui_clear_source_content)
6839 (tui_show_source_content, tui_show_exec_info_content)
6840 (tui_clear_exec_info_content): Update.
6841 * tui/tui-stack.c (tui_show_locator_content): Update.
6842 (tui_show_frame_info): Update.
6843 * tui/tui-source.h (tui_source_window): Don't declare.
6844 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6845 from tui_source_is_displayed.
6846 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6848 (struct tui_source_window_base) <content_in_use>: New field. Now
6850 (struct tui_source_window) <showing_source_p>: New method.
6851 (TUI_SRC_WIN): Change cast.
6852 * tui/tui-data.c (tui_initialize_static_data): Update.
6854 2019-07-17 Tom Tromey <tom@tromey.com>
6856 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6858 * tui/tui-source.c (tui_source_window::location_matches_p): New
6860 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6862 * tui/tui-data.h (struct tui_source_window_base)
6863 <location_matches_p>: New method.
6864 (struct tui_source_window, struct tui_disasm_window)
6865 <location_matches_p>: Likewise.
6867 2019-07-17 Tom Tromey <tom@tromey.com>
6869 * tui/tui-win.c (tui_set_win_height_command): Rename from
6871 (tui_set_win_height_command): Remove.
6873 2019-07-17 Tom Tromey <tom@tromey.com>
6875 * tui/tui-source.c (tui_source_window): New constructor. Add
6877 (~tui_source_window): New destructor.
6878 (tui_source_window::style_changed): New method.
6879 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6880 (tui_attach_detach_observers): Update.
6881 * tui/tui-data.h (struct tui_source_window): Make constructor not
6882 inline. Add destructor.
6883 (struct tui_source_window) <style_changed>: New method.
6884 <m_observable>: New member.
6886 2019-07-17 Tom Tromey <tom@tromey.com>
6888 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6889 * tui/tui-win.c (tui_resize_all): Fix typo.
6891 2019-07-17 Tom Tromey <tom@tromey.com>
6893 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6894 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6895 (tui_refresh_all): Remove "list" parameter. Use foreach.
6896 * tui/tui-win.c (window_name_completer): Use foreach.
6897 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6898 (update_tab_width): Likewise.
6899 * tui/tui-layout.c (show_layout): Update.
6900 * tui/tui-data.h (class tui_window_iterator): New.
6901 (struct all_tui_windows): New.
6902 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6904 2019-07-17 Tom Tromey <tom@tromey.com>
6906 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6907 parameter. Don't reference globals.
6908 (tui_reg_command): Update.
6910 2019-07-17 Tom Tromey <tom@tromey.com>
6912 * tui/tui-regs.c (tui_show_registers): Simplify.
6914 2019-07-17 Tom Tromey <tom@tromey.com>
6916 * tui/tui-regs.c (tui_show_registers): Update.
6917 (tui_show_register_group): Add win_info parameter.
6919 2019-07-17 Tom Tromey <tom@tromey.com>
6921 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6922 Rename from tui_display_reg_element_at_line.
6923 (tui_data_window::display_registers_from_line): Update.
6924 * tui/tui-data.h (struct tui_data_window)
6925 <display_reg_element_at_line>: New method.
6927 2019-07-17 Tom Tromey <tom@tromey.com>
6929 * tui/tui-regs.h (tui_display_registers_from)
6930 (tui_display_registers_from_line): Don't declare.
6931 * tui/tui-windata.c (tui_data_window::display_all_data)
6932 (tui_data_window::refresh_all)
6933 (tui_data_window::do_scroll_vertical): Update.
6934 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6935 from tui_display_registers_from.
6936 (tui_display_reg_element_at_line): Update.
6937 (tui_data_window::display_registers_from_line): Rename from
6938 tui_display_registers_from_line.
6939 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6940 display_registers_from_line>: New methods.
6942 2019-07-17 Tom Tromey <tom@tromey.com>
6944 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6945 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6946 from tui_erase_data_content.
6947 (tui_data_window::display_all_data)
6948 (tui_data_window::refresh_all)
6949 (tui_data_window::do_scroll_vertical): Update.
6950 * tui/tui-regs.c (tui_show_registers): Update.
6951 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6954 2019-07-17 Tom Tromey <tom@tromey.com>
6956 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6959 (tui_data_window::delete_data_content_windows): Rename from
6960 tui_delete_data_content_windows.
6961 (tui_data_window::display_all_data)
6962 (tui_data_window::do_scroll_vertical): Update.
6963 * tui/tui-data.h (struct tui_data_window)
6964 <delete_data_content_windows>: New method.
6966 2019-07-17 Tom Tromey <tom@tromey.com>
6968 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6969 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6971 2019-07-17 Tom Tromey <tom@tromey.com>
6973 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6974 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6975 from tui_display_all_data.
6977 (tui_data_window::do_make_visible_with_new_height): Update.
6978 * tui/tui-regs.c (tui_show_registers): Update.
6979 * tui/tui-layout.c (tui_set_layout): Update.
6980 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6983 2019-07-17 Tom Tromey <tom@tromey.com>
6985 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6986 * tui/tui-windata.c (tui_display_data_from): Remove.
6987 (tui_data_window::refresh_all): Update.
6989 2019-07-17 Tom Tromey <tom@tromey.com>
6991 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6992 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6993 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6994 tui_display_registers_from_line.
6995 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6996 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6997 "force_display" parameter.
6999 2019-07-17 Tom Tromey <tom@tromey.com>
7001 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7003 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7004 Rename from tui_first_reg_element_no_inline.
7005 (tui_display_reg_element_at_line)
7006 (tui_display_registers_from_line): Update.
7007 * tui/tui-data.h (struct tui_data_window)
7008 <first_reg_element_no_inline>: New method.
7010 2019-07-17 Tom Tromey <tom@tromey.com>
7012 * tui/tui-windata.c (tui_display_data_from)
7013 (tui_data_window::do_scroll_vertical): Update.
7014 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7015 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7016 Rename from tui_line_from_reg_element_no.
7017 (tui_display_registers_from_line): Update.
7018 * tui/tui-data.h (struct tui_data_window)
7019 <line_from_reg_element_no>: New method.
7021 2019-07-17 Tom Tromey <tom@tromey.com>
7023 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7024 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7025 tui_last_regs_line_no.
7026 (tui_display_reg_element_at_line)
7027 (tui_display_registers_from_line): Update.
7028 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7031 2019-07-17 Tom Tromey <tom@tromey.com>
7034 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7035 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7036 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7037 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7038 (tui_update_breakpoint_info): Likewise.
7039 * tui/tui-hooks.c (tui_event_create_breakpoint)
7040 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7043 2019-07-17 Tom Tromey <tom@tromey.com>
7045 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7047 2019-07-17 Tom Tromey <tom@tromey.com>
7049 * tui/tui-winsource.c (tui_update_source_window_as_is)
7050 (tui_update_source_windows_with_addr): Update.
7051 * tui/tui-source.h (tui_set_source_content)
7052 (tui_show_symtab_source): Add "win_info" parameter.
7053 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7055 (tui_show_symtab_source): Likewise.
7057 2019-07-17 Tom Tromey <tom@tromey.com>
7059 * tui/tui-wingeneral.c
7060 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7062 2019-07-17 Tom Tromey <tom@tromey.com>
7064 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7065 (struct tui_cmd_window) <can_scroll>: New method.
7066 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7069 2019-07-17 Tom Tromey <tromey@adacore.com>
7071 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7072 do_field_signed>: Rename. Change type of "value".
7073 * ui-out.c (ui_out::field_signed): Rename from field_int.
7074 Change type of "value".
7075 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7077 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7078 do_field_int. Change type of "value".
7079 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7080 do_field_int. Change type of "value".
7081 * tracepoint.c (trace_status_mi, tfind_1)
7082 (print_one_static_tracepoint_marker): Update.
7083 * thread.c (print_thread_info_1, print_selected_thread_frame):
7085 * stack.c (print_frame, print_frame_info): Update.
7086 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7088 * source.c (print_source_lines_base): Update.
7089 * skip.c (info_skip_command): Update.
7090 * record-btrace.c (btrace_ui_out_decode_error)
7091 (btrace_call_history_src_line): Update.
7092 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7094 * progspace.c (print_program_space): Update.
7095 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7096 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7097 do_field_int. Change type of "value".
7098 * mi/mi-out.c (mi_ui_out::do_table_begin)
7099 (mi_ui_out::do_table_header): Update.
7100 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7102 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7103 (mi_cmd_data_list_changed_registers, output_register)
7104 (mi_cmd_data_read_memory, mi_load_progress)
7105 (mi_cmd_trace_frame_collected): Update.
7106 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7108 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7109 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7110 (mi_cmd_var_list_children, varobj_update_one): Update.
7111 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7112 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7113 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7114 * inferior.c (print_inferior): Update.
7115 * gdb_bfd.c (print_one_bfd): Update.
7116 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7118 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7119 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7120 do_field_int. Change type of "value".
7121 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7122 do_field_int. Change type of "value".
7123 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7124 (print_one_breakpoint_location, print_it_catch_fork)
7125 (print_one_catch_fork, print_it_catch_vfork)
7126 (print_one_catch_vfork, print_it_catch_solib)
7127 (print_it_catch_exec, print_it_ranged_breakpoint)
7128 (print_mention_watchpoint, print_mention_masked_watchpoint)
7129 (bkpt_print_it, update_static_tracepoint): Update.
7130 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7131 * break-catch-syscall.c (print_it_catch_syscall): Update.
7132 * ada-tasks.c (print_ada_task_info): Update.
7133 * ada-lang.c (print_it_exception, print_mention_exception):
7136 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7138 PR breakpoints/24541
7139 * gdbarch.c: Regenerate.
7140 * gdbarch.h: Regenerate.
7141 * gdbarch.sh: Adjust return type and parameter types for
7142 'stap_adjust_register'.
7143 (i386_stap_adjust_register): Adjust signature and return new
7145 * stap-probe.c (stap_parse_register_operand): Adjust use of
7146 'gdbarch_stap_adjust_register'.
7148 2019-07-17 Tom Tromey <tromey@adacore.com>
7150 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7152 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7154 (struct s390_process_info): Add initializers.
7155 (s390_add_process): Use new.
7156 (s390_linux_nat_target::low_forget_process): Use delete.
7157 (s390_linux_nat_target::low_new_fork)
7158 (s390_linux_nat_target::stopped_by_watchpoint)
7159 (s390_linux_nat_target::low_prepare_to_resume)
7160 (s390_linux_nat_target::insert_watchpoint)
7161 (s390_linux_nat_target::insert_hw_breakpoint)
7162 (s390_linux_nat_target::remove_watchpoint)
7163 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7165 2019-07-16 John Baldwin <jhb@FreeBSD.org>
7167 * aarch64-fbsd-nat.c: Include regcache.h.
7168 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7170 (aarch64_fbsd_nat_target::fetch_registers)
7171 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7173 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7175 2019-07-16 John Baldwin <jhb@FreeBSD.org>
7177 * fbsd-nat.c: Include gdbarch.h.
7179 2019-07-15 Tom Tromey <tromey@adacore.com>
7181 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7183 2019-07-15 Tom Tromey <tromey@adacore.com>
7185 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7186 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7187 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7188 * cli-out.c (cli_ui_out::do_field_int): New method.
7189 * ui-out.c (ui_out::field_unsigned): New method.
7190 * symfile.c (generic_load): Use field_unsigned.
7191 (print_transfer_performance): Likewise.
7192 * record-btrace.c (ui_out_field_uint): Remove.
7193 (btrace_call_history_insn_range, btrace_call_history): Use
7195 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7197 * ui-out.h (class ui_out) <field_unsigned>: New method.
7198 <do_field_unsigned>: Likewise.
7200 2019-07-15 Tom Tromey <tromey@adacore.com>
7202 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7203 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7204 * target.c (flash_erase_command): Use field_string.
7205 * infrun.c (print_signal_received_reason): Use field_string.
7206 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7207 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7209 * ada-tasks.c (print_ada_task_info): Use field_string.
7211 2019-07-15 Tom Tromey <tromey@adacore.com>
7213 * target.c (flash_erase_command): Use field_core_addr.
7214 * symfile.c (generic_load): Use field_core_addr.
7215 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7216 Use field_core_addr.
7217 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7220 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7222 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7223 value if its desired type is smaller than a CORE_ADDR and signed.
7225 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7227 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7228 of changes to field names, and use new is_reference field to
7229 decide if a property is a reference or not.
7230 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7232 (struct dwarf2_property_baton): Update header comment, rename
7233 'referenced_type' to 'property_type' and update comments.
7234 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7235 default property type, store in property baton, update to take
7236 accound of renamed field.
7237 (read_func_scope): Update call to attr_to_dynamic_prop.
7238 (read_array_type): Likewise.
7239 (dwarf2_per_cu_addr_sized_int_type): New function.
7240 (read_subrange_index_type): Move type finding code to
7241 dwarf2_per_cu_addr_sized_int_type.
7242 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7243 (dwarf2_per_cu_addr_type): New function.
7244 (set_die_type): Update calls to attr_to_dynamic_prop.
7246 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7248 * dwarf2read.c (read_subrange_index_type): New function.
7249 (read_subrange_type): Move code into new function and call it.
7250 * gdbtypes.c (create_range_type): Add some asserts.
7252 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7254 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7255 update return statements.
7256 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7257 declaration, and update comment to match.
7258 * gdbtypes.c (resolve_dynamic_array): Update call to
7259 dwarf2_evaluate_property to match new return type.
7261 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7263 * valarith.c (value_subscripted_rvalue): Change lowerbound
7264 parameter type from int to LONGEST.
7265 * value.h (value_subscripted_rvalue): Likewise in declaration.
7267 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7269 * cli/cli-utils.c (info_print_command_completer): New function.
7270 * cli/cli-utils.h: Add 'completer.h' include, and forward
7271 declaration for 'struct cmd_list_element'.
7272 (info_print_command_completer): Declare.
7273 * stack.c (_initialize_stack): Add completer for 'info locals' and
7275 * symtab.c (_initialize_symtab): Add completer for 'info
7276 variables' and 'info functions'.
7277 * NEWS: Mention completion for additional info commands.
7279 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7281 * cli/cli-utils.c (extract_info_print_args): Delete.
7282 (extract_arg_maybe_quoted): Delete.
7283 (info_print_options_defs): New variable.
7284 (make_info_print_options_def_group): New function.
7285 (extract_info_print_options): Define new function.
7286 * cli/cli-utils.h (extract_info_print_args): Delete.
7287 (struct info_print_options): New structure.
7288 (extract_info_print_options): Declare new function.
7289 * stack.c (info_locals_command): Update to use new
7290 extract_info_print_options, also add a header comment.
7291 (info_args_command): Likewise.
7292 * symtab.c (info_variables_command): Likewise.
7293 (info_functions_command): Likewise.
7295 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7297 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7298 to extract string arguments.
7299 * common/common-utils.c (extract_string_maybe_quoted): New function.
7300 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7302 2019-07-11 Tom Tromey <tromey@adacore.com>
7304 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7305 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7306 * top.h (gdbinit): Don't declare.
7307 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7309 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7310 * top.c (gdb_init): Don't call init_cli_cmds.
7312 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7314 2019-07-11 Tom Tromey <tromey@adacore.com>
7316 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7317 after it has been moved.
7319 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7321 * valops.c (value_must_coerce_to_target): Change return type to
7323 * value.h (value_must_coerce_to_target): Likewise.
7325 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
7327 * breakpoint.c (is_hardware_watchpoint): Remove
7328 forward-declaration.
7329 (is_masked_watchpoint): Change return type to bool.
7330 (is_tracepoint): Likewise.
7331 (is_breakpoint): Likewise.
7332 (is_hardware_watchpoint): Likewise.
7333 (is_watchpoint): Likewise.
7334 (is_no_memory_software_watchpoint): Likewise.
7335 (is_catchpoint): Likewise.
7336 (breakpoint_1): Make FILTER parameter's return type bool.
7337 is_masked_watchpoint): Change return type to bool.
7338 (save_breakpoints): Make FILTER parameter's return type bool.
7339 * breakpoint.h (is_breakpoint): Change return type to bool.
7340 (is_watchpoint): Likewise.
7341 (is_catchpoint): Likewise.
7342 (is_tracepoint): Likewise.
7344 2019-07-10 Tom Tromey <tom@tromey.com>
7346 * defs.h: Don't include gdbarch.h.
7347 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7348 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7349 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7350 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7351 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7352 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7353 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7354 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7355 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7356 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7357 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7358 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7359 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7360 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7361 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7362 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7363 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7364 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7365 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7366 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7367 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7368 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7369 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7370 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7371 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7372 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7373 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7375 2019-07-10 Tom Tromey <tromey@adacore.com>
7377 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7378 * breakpoint.c (init_ada_exception_breakpoint): Register as
7380 (print_one_breakpoint_location, print_one_breakpoint): Use
7381 is_ada_exception_catchpoint.
7382 * ada-lang.c (class ada_catchpoint_location): Pass
7383 bp_loc_software_breakpoint to bp_location constructor.
7384 (is_ada_exception_catchpoint): New function.
7386 2019-07-10 Tom Tromey <tromey@adacore.com>
7388 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7390 (struct arm_exidx_entry): New method operator<.
7391 (struct arm_exidx_data) <section_maps>: Change type.
7392 (arm_exidx_data_free): Remove.
7393 (arm_exidx_data_key): Change type. Move lower.
7394 (arm_exidx_new_objfile): Update.
7395 (arm_compare_exidx_entries): Remove.
7396 (arm_find_exidx_entry, _initialize_arm_tdep)
7398 2019-07-10 Tom Tromey <tromey@adacore.com>
7400 * solib-spu.c (ocl_program_data_key): Change type.
7401 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7404 2019-07-10 Tom Tromey <tromey@adacore.com>
7406 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7407 (struct solib_aix_inferior_data) <library_list>: Change type.
7408 (solib_aix_inferior_data_handle): Change type.
7409 (get_solib_aix_inferior_data): Update.
7410 (solib_aix_free_library_list): Remove.
7411 (library_list_start_library): Update.
7412 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7414 (solib_aix_get_library_list)
7415 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7416 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7418 2019-07-10 Tom Tromey <tromey@adacore.com>
7420 * solib-dsbt.c (struct dsbt_info): Add initializers.
7421 (solib_dsbt_pspace_data): Change type.
7422 (dsbt_pspace_data_cleanup): Remove.
7423 (get_dsbt_info, _initialize_dsbt_solib): Update.
7425 2019-07-10 Tom Tromey <tromey@adacore.com>
7427 * spu-tdep.c (spu_overlay_data): Change type.
7428 (spu_get_overlay_table, spu_overlay_new_objfile)
7429 (_initialize_spu_tdep): Update.
7431 2019-07-10 Tom Tromey <tromey@adacore.com>
7433 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7435 (dbx_objfile_data_key): Change type and declare later.
7436 (DBX_SYMFILE_INFO): Rewrite.
7437 * dbxread.c (dbx_objfile_data_key): Change type.
7438 (dbx_symfile_init): Update.
7439 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7440 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7441 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7443 2019-07-10 Tom Tromey <tromey@adacore.com>
7445 * jit.c (jit_program_space_key): Change type. Move lower.
7446 (get_jit_program_space_data): Update.
7447 (jit_program_space_data_cleanup): Remove.
7448 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7450 (struct jit_program_space_data): Add initializers.
7452 2019-07-10 Tom Tromey <tromey@adacore.com>
7454 * solib-darwin.c (struct darwin_info): Add initializers.
7455 (solib_darwin_pspace_data): Change type.
7456 (darwin_pspace_data_cleanup): Remove.
7457 (get_darwin_info, _initialize_darwin_solib): Update.
7459 2019-07-10 Tom Tromey <tromey@adacore.com>
7461 * remote-sim.c (struct sim_inferior_data): Add initializers,
7462 constructor, and destructor.
7463 (sim_inferior_data_key): Change type. Move lower.
7464 (check_for_duplicate_sim_descriptor): Update.
7465 (get_sim_inferior_data): Use new. Update.
7466 (~sim_inferior_data_cleanup): Rename from
7467 sim_inferior_data_cleanup. Simplify.
7468 (gdbsim_close_inferior, simulator_command)
7469 (sim_command_completer, _initialize_remote_sim): Update.
7470 (next_pid, INITIAL_PID): Move earlier.
7472 2019-07-10 Tom Tromey <tromey@adacore.com>
7474 * python/python-internal.h (create_thread_object): Return
7476 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7477 * python/py-inferior.c (struct threadlist_entry): Add
7479 <thread_obj>: Now a gdbpy_ref.
7480 (thread_to_thread_object): Update.
7481 (add_thread_object): Use new.
7482 (delete_thread_object): Use delete.
7483 (infpy_threads): Update.
7484 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7487 2019-07-10 Tom Tromey <tromey@adacore.com>
7489 * valops.c (value_cast): Specialize error message for Ada.
7491 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7493 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7495 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7497 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7498 bpstat_should_step): Return bool, adjust comments.
7499 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7500 bpstat_should_step): Likewise.
7502 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7504 * features/Makefile: Use feature target descriptions for Arm.
7505 * features/arm/arm-core.c: Generate new file.
7506 * features/arm/arm-fpa.c: Likewise.
7507 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7508 * features/arm/arm-m-profile.c: Likewise.
7509 * features/arm/arm-vfpv2.c: Likewise.
7510 * features/arm/arm-vfpv3.c: Likewise.
7511 * features/arm/xscale-iwmmxt.c: Likewise.
7512 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7514 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7516 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7519 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7521 * features/aarch64-pauth.c: Regenerate.
7523 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7525 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7527 (bpstat_what): Use false instead of 0.
7529 2019-07-09 Pedro Alves <palves@redhat.com>
7531 * break-catch-throw.c (is_exception_catchpoint): New.
7532 * breakpoint.c (print_one_breakpoint_location): New parameter
7533 'raw_loc'. Handle it. Use
7534 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7535 looking at the breakpoint's type.
7536 (print_one_breakpoint): If handling "maint info breakpoints", also
7537 print locations of exception catchpoints.
7538 * breakpoint.h (is_exception_catchpoint): Declare.
7540 2019-07-09 Pedro Alves <palves@redhat.com>
7542 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7544 (allocate_location_exception_catchpoint): New.
7545 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7546 (initialize_throw_catchpoint_ops): Install
7547 allocate_location_exception_catchpoint as allocate_location
7549 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7550 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7552 (breakpoint_address_is_meaningful): Delete.
7553 (bl_address_is_meaningful): New.
7554 (breakpoint_locations_match): Adjust comment.
7555 (bp_location_from_bp_type): New, factored out of...
7556 (bp_location::bp_location(breakpoint *)): ... this.
7557 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7559 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7560 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7561 breakpoint_address_is_meaningful.
7562 (bp_locations_compare): Adjust comment.
7563 (update_global_location_list): Use bl_address_is_meaningful
7564 instead of breakpoint_address_is_meaningful.
7565 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7567 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7568 * python/py-breakpoint.c (bppy_get_location): No longer check
7569 whether location is null.
7571 2019-07-09 Pedro Alves <palves@redhat.com>
7574 * breakpoint.c (print_one_breakpoint_location): Remove
7575 single-location assert.
7577 2019-07-09 Tom Tromey <tom@tromey.com>
7579 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7580 * configure: Rebuild.
7581 * configure.ac: Change common to gdbsupport.
7582 * gdbsupport: Rename from common.
7583 * acinclude.m4: Change common to gdbsupport.
7584 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7585 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7587 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7588 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7589 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7590 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7591 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7592 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7593 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7594 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7595 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7596 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7597 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7598 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7599 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7600 coff-pe-read.c, command.h, compile/compile-c-support.c,
7601 compile/compile-c.h, compile/compile-cplus-symbols.c,
7602 compile/compile-cplus-types.c, compile/compile-cplus.h,
7603 compile/compile-loc2c.c, compile/compile.c, completer.c,
7604 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7605 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7606 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7607 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7608 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7609 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7610 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7611 features/aarch64-core.c, features/aarch64-fpu.c,
7612 features/aarch64-pauth.c, features/aarch64-sve.c,
7613 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7614 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7615 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7616 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7617 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7618 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7619 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7620 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7621 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7622 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7623 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7624 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7625 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7626 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7627 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7628 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7629 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7630 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7631 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7632 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7633 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7634 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7635 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7636 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7637 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7638 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7639 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7640 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7641 minsyms.c, mips-linux-tdep.c, namespace.h,
7642 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7643 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7644 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7645 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7646 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7647 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7648 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7649 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7650 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7651 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7652 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7653 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7654 procfs.c, producer.c, progspace.h, psymtab.h,
7655 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7656 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7657 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7658 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7659 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7660 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7661 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7662 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7663 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7664 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7665 target-memory.c, target.c, target.h, target/waitstatus.c,
7666 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7667 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7668 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7669 unittests/array-view-selftests.c,
7670 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7671 unittests/common-utils-selftests.c,
7672 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7673 unittests/format_pieces-selftests.c,
7674 unittests/function-view-selftests.c,
7675 unittests/lookup_name_info-selftests.c,
7676 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7677 unittests/mkdir-recursive-selftests.c,
7678 unittests/observable-selftests.c,
7679 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7680 unittests/parse-connection-spec-selftests.c,
7681 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7682 unittests/scoped_fd-selftests.c,
7683 unittests/scoped_mmap-selftests.c,
7684 unittests/scoped_restore-selftests.c,
7685 unittests/string_view-selftests.c, unittests/style-selftests.c,
7686 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7687 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7688 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7689 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7690 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7691 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7693 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7695 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7697 (decode_digits_ordinary): Set explicit_line field in sal.
7698 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7699 symtab_and_line that was set on an explicit line number in
7700 assembler code. Do always update the recorded symtab and line if
7701 we do skip the prologue.
7703 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7705 * breakpoint.c (set_breakpoint_location_function): Remove
7706 explicit_loc parameter.
7707 (momentary_breakpoint_from_master): Update call to
7708 set_breakpoint_location_function.
7709 (add_location_to_breakpoint): Likewise.
7711 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7713 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7714 required features based on default bfd type when no specific bfd
7717 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7719 * NEWS: Mention that GDB printf and eval commands can now print
7720 C-style and Ada-style convenience var strings without
7721 calling the inferior.
7722 * printcmd.c (printf_c_string): Locally print GDB internal var
7723 instead of transiting via the inferior.
7724 (printf_wide_c_string): Likewise.
7726 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7728 PR breakpoints/25011
7729 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7731 2019-07-04 Tom Tromey <tom@tromey.com>
7734 * tui/tui-winsource.c (tui_clear_source_content): Update.
7735 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7736 (tui_update_breakpoint_info): Update.
7737 (tui_set_exec_info_content): Update.
7738 * tui/tui-source.c (tui_set_source_content_nil): Update.
7739 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7741 * tui/tui-data.h (enum tui_bp_flag): New.
7742 (tui_bp_flags): New enum flags type.
7743 (struct tui_source_element) <break_mode>: Change type. Rename
7745 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7746 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7748 * tui/tui-winsource.h: Fix comment.
7750 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7752 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7753 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7754 (store_fpregs_to_thread)
7755 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7756 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7757 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7758 (IWMMXT_REGS_SIZE): Add define.
7759 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7760 (fetch_vfp_regs, store_vfp_regs)
7761 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7762 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7764 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7766 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7768 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7769 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7770 (ARM_INT_REGISTER_SIZE): ...to this.
7771 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7772 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7773 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7774 (arm_linux_collect_gregset, supply_nwfpe_register)
7775 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7777 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7778 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7779 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7780 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7781 (arm_return_in_memory, arm_store_return_value)
7782 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7783 (arm_record_ld_st_multiple): Likewise.
7784 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7785 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7787 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7789 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7790 AARCH64_DISPLACED_MODIFIED_INSNS.
7791 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7792 (aarch64_displaced_step_copy_insn): Likewise.
7793 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7794 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7795 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7796 ARM_DISPLACED_MODIFIED_INSNS.
7797 * arm-tdep.c (arm_gdbarch_init): Likewise.
7798 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7799 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7800 (struct arm_displaced_step_closure): Use
7801 ARM_DISPLACED_MODIFIED_INSNS.
7803 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7805 * features/Makefile: Remove unused xml files.
7806 * features/aarch64.xml: Remove.
7807 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7808 * features/i386/amd64-avx-avx512.xml: Remove.
7809 * features/i386/amd64-avx-linux.xml: Remove.
7810 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7811 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7812 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7813 * features/i386/amd64-avx-mpx.xml: Remove.
7814 * features/i386/amd64-avx.xml: Remove.
7815 * features/i386/amd64-linux.xml: Remove.
7816 * features/i386/amd64-mpx-linux.xml: Remove.
7817 * features/i386/amd64-mpx.xml: Remove.
7818 * features/i386/amd64.xml: Remove.
7819 * features/i386/i386-avx-avx512-linux.xml: Remove.
7820 * features/i386/i386-avx-avx512.xml: Remove.
7821 * features/i386/i386-avx-linux.xml: Remove.
7822 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7823 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7824 * features/i386/i386-avx-mpx-linux.xml: Remove.
7825 * features/i386/i386-avx-mpx.xml: Remove.
7826 * features/i386/i386-avx.xml: Remove.
7827 * features/i386/i386-linux.xml: Remove.
7828 * features/i386/i386-mmx-linux.xml: Remove.
7829 * features/i386/i386-mmx.xml: Remove.
7830 * features/i386/i386-mpx-linux.xml: Remove.
7831 * features/i386/i386-mpx.xml: Remove.
7832 * features/i386/i386.xml: Remove.
7833 * features/i386/x32-avx-avx512-linux.xml: Remove.
7834 * features/i386/x32-avx-linux.xml: Remove.
7835 * features/i386/x32-linux.xml: Remove.
7837 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7839 * regformats/aarch64.dat: Remove.
7840 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7841 * regformats/i386/amd64-avx-linux.dat: Remove.
7842 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7843 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7844 * regformats/i386/amd64-linux.dat: Remove.
7845 * regformats/i386/amd64-mpx-linux.dat: Remove.
7846 * regformats/i386/amd64.dat: Remove.
7847 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7848 * regformats/i386/i386-avx-linux.dat: Remove.
7849 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7850 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7851 * regformats/i386/i386-linux.dat: Remove.
7852 * regformats/i386/i386-mmx-linux.dat: Remove.
7853 * regformats/i386/i386-mpx-linux.dat: Remove.
7854 * regformats/i386/i386.dat: Remove.
7855 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7856 * regformats/i386/x32-avx-linux.dat: Remove.
7857 * regformats/i386/x32-linux.dat: Remove.
7859 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7861 * aarch64-tdep.c: Remove xml self tests.
7862 * amd64-linux-tdep.c: Likewise.
7863 * amd64-tdep.c: Likewise.
7864 * i386-linux-tdep.c: Likewise.
7865 * i386-tdep.c: Likewise.
7867 2019-07-03 Pedro Alves <palves@redhat.com>
7870 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7871 (pipe_cmd_option_defs): New.
7872 (make_pipe_cmd_options_def_group): New.
7873 (pipe_command): Use gdb::option::process_options.
7874 (pipe_command_completer): New function.
7875 (_initialize_cli_cmds): Install completer for "pipe" command.
7877 2019-07-03 Pedro Alves <palves@redhat.com>
7879 * cli/cli-option.c (union option_value) <string>: New field.
7880 (struct option_def_and_value): Add ctor, move ctor, dtor and
7881 use DISABLE_COPY_AND_ASSIGN.
7882 (option_def_and_value::clear_value): New.
7883 (parse_option, save_option_value_in_ctx, get_val_type_str)
7884 (add_setshow_cmds_for_options): Handle var_string.
7885 * cli-option.h (union option_def::var_address) <string>: New
7887 (struct string_option_def): New.
7888 * maint-test-options.c (struct test_options_opts): Add default
7889 ctor and use DISABLE_COPY_AND_ASSIGN.
7890 <string_opt>: New field.
7891 (test_options_opts::~test_options_opts): New.
7892 (test_options_opts::dump): Also dump "-string".
7893 (test_options_option_defs): Install "string.
7895 2019-07-03 Pedro Alves <palves@redhat.com>
7897 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7898 option_value with a null enumeration.
7899 (complete_options): Save the option values in the context.
7900 (save_option_value_in_ctx): New, factored out from ...
7901 (process_options): ... here.
7902 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7904 * maint-test-options.c (test_options_opts::dump): New, factored
7906 (maintenance_test_options_command_mode): ... here.
7907 (maintenance_test_options_command_completion_result): Delete.
7908 (maintenance_test_options_command_completion_text): Update
7910 (maintenance_show_test_options_completion_result): Change
7911 prototype. Just print
7912 maintenance_test_options_command_completion_text.
7913 (save_completion_result): New.
7914 (maintenance_test_options_completer_mode): Pass options context to
7915 complete_options, and then save a dump.
7916 (_initialize_maint_test_options): Use add_cmd to install "maint
7917 show test-options-completion-result".
7919 2019-07-03 Pedro Alves <palves@redhat.com>
7921 * NEWS (New commands): Mention "with" and "maint with".
7922 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7923 (with_command, with_command_completer): New.
7924 (pipe_command): Adjust to new repeat_previous
7926 (_initialize_cli_cmds): Install the "with" command and its "w"
7928 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7930 * cli/cli-setshow.c (parse_cli_var_uinteger)
7931 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7932 argument strings for all var_types.
7933 (get_setshow_command_value_string): New, factored out from ...
7934 (do_show_command): ... this.
7935 * cli/cli-setshow.h: Include <string>.
7936 (get_setshow_command_value_string): Declare.
7937 * command.h (repeat_previous): Now returns const char *. Adjust
7939 * maint.c: Include "cli/cli-cmds.h".
7940 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7941 (_initialize_maint_cmds): Register the "maintenance with" command.
7942 * top.c (repeat_previous): Move bits from pipe_command here:
7943 Return the saved command line, if any; error out if there's no
7944 command to relaunch.
7946 2019-07-03 Pedro Alves <palves@redhat.com>
7948 * NEWS (New commands): Mention "maint set/show test-settings"
7949 instead of "maint test-settings".
7950 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7951 (maintenance_test_settings_set_list): Rename to ...
7952 (maintenance_set_test_settings_list): ... this.
7953 (maintenance_test_settings_show_list): Rename to ...
7954 (maintenance_show_test_settings_list): ... this.
7955 (maintenance_test_settings_cmd): Delete.
7956 (maintenance_test_settings_set_cmd): ...
7957 (maintenance_set_test_settings_cmd): ... this.
7958 (maintenance_test_settings_show_cmd): ...
7959 (maintenance_show_test_settings_cmd): ... this.
7960 (maintenance_test_settings_show_value_cmd):
7961 (maintenance_show_test_settings_value_cmd): ... this.
7962 (_initialize_maint_test_settings): No longer install the "maint
7963 test-settings" prefix command. Rename "maint test-settings set"
7964 to "maint set test-settings", and "maint test-settings show" to
7965 "maint show test-settings". Adjust all subcommands.
7967 2019-07-03 Pedro Alves <palves@redhat.com>
7969 * maint-test-settings.c: Fix file's intro comment. Replace all
7970 references to "test-options" with references to "test-settings",
7973 2019-07-03 Pedro Alves <palves@redhat.com>
7975 * maint-test-settings.c (maintenance_test_settings_xxx)
7976 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7978 (maintenance_test_settings_enums): Use them.
7979 (maintenance_test_settings_enum): Default to
7980 maintenance_test_settings_xxx.
7981 (_initialize_maint_test_settings): Initialize
7982 MAINTENANCE_TEST_SETTINGS_FILENAME.
7984 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7986 * breakpoint.h (remove_breakpoints_inf): Change return type to
7987 void, move function documentation here.
7988 * breakpoint.c (remove_breakpoints_inf): Change return type to
7989 void, move function documentation to header.
7991 2019-07-02 Pedro Alves <palves@redhat.com>
7993 * NEWS (Completion improvements): Mention "info threads".
7994 * thread.c (struct info_threads_opts, info_threads_option_defs)
7995 (make_info_threads_options_def_group): New.
7996 (info_threads_command): Use gdb::option::process_options.
7997 (info_threads_command_completer): New.
7998 (_initialize_thread): Use gdb::option::build_help to build the
7999 help text for "info threads".
8001 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8003 * defs.h (generic_load): Move from here...
8004 * symfile.h (generic_load): ... to here. Rename name parameter
8006 * symfile.c (generic_load): Add comment.
8008 2019-07-01 Tom Tromey <tromey@adacore.com>
8011 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8012 declaration of without_params. Fix formatting.
8014 2019-07-01 Tom Tromey <tromey@adacore.com>
8016 * ada-exp.y (find_primitive_type): Update.
8017 * ada-lang.h (ada_lookup_symbol): Update.
8018 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8020 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8022 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8024 PR breakpoints/24541
8025 * gdbarch.c: Regenerate.
8026 * gdbarch.h: Regenerate.
8027 * gdbarch.sh: Add 'stap_adjust_register'.
8028 * i386-tdep.c: Include '<unordered_set>'.
8029 (i386_stap_adjust_register): New function.
8030 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8031 * stap-probe.c (stap_parse_register_operand): Call
8032 'gdbarch_stap_adjust_register'.
8034 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8037 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8038 * python/python.c (do_start_initialization): Use 'xmalloc'
8039 instead of 'PyMem_Malloc'.
8041 2019-06-28 Tom Tromey <tromey@adacore.com>
8043 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8046 2019-06-27 Tom Tromey <tromey@adacore.com>
8048 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8050 (arm_find_mapping_symbol, arm_record_special_symbol)
8051 (_initialize_arm_tdep): Update.
8052 (arm_objfile_data_free): Remove.
8054 2019-06-27 Tom Tromey <tromey@adacore.com>
8056 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8057 to cp_print_static_field.
8059 2019-06-26 Tom Tromey <tromey@adacore.com>
8061 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8062 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8065 2019-06-26 Alan Hayward <alan.hayward@arm.com>
8067 * features/aarch64-core.c (create_feature_aarch64_core):
8069 * features/aarch64-core.xml: Add cpsr flags.
8071 2019-06-26 Alan Hayward <alan.hayward@arm.com>
8073 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8074 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8076 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8078 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8080 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8082 (arm_record_special_symbol): Don't insert new symbol in sorted
8083 position, push it at the end.
8085 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8087 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8088 (arm_mapping_symbol_s): Remove.
8089 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8090 (arm_mapping_symbol_vec): New typedef.
8091 (struct arm_per_objfile): Add constructor.
8092 <section_maps>: Change type to
8093 std::unique_ptr<arm_mapping_symbol_vec[]>.
8094 (arm_compare_mapping_symbols): Remove.
8095 (arm_find_mapping_symbol): Adjust to section_maps type change.
8096 (arm_objfile_data_free): Call delete on arm_per_objfile.
8097 (arm_record_special_symbol): Adjust to section_maps type change.
8098 Allocate arm_per_objfile with new.
8100 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8102 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8103 with the command prefix.
8105 2019-06-25 Tom Tromey <tom@tromey.com>
8107 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8108 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8110 2019-06-25 Tom Tromey <tom@tromey.com>
8112 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8114 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8117 2019-06-25 Tom Tromey <tom@tromey.com>
8119 * tui/tui-winsource.c
8120 (tui_source_window_base::set_is_exec_point_at): Add check against
8123 2019-06-25 Tom Tromey <tom@tromey.com>
8125 * tui/tui-source.c (tui_set_source_content): Don't check before
8127 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8129 2019-06-25 Tom Tromey <tom@tromey.com>
8131 * tui/tui-winsource.h (tui_update_source_window_as_is)
8132 (tui_alloc_source_buffer, tui_line_is_displayed)
8133 (tui_addr_is_displayed): Change type of win_info.
8134 * tui/tui-winsource.c (tui_update_source_window_as_is)
8135 (tui_clear_source_content, tui_show_source_line)
8136 (tui_show_source_content, tui_source_window_base::refill)
8137 (tui_source_window_base::set_is_exec_point_at)
8138 (tui_source_window_base::set_is_exec_point_at)
8139 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8140 (tui_alloc_source_buffer, tui_line_is_displayed)
8141 (tui_addr_is_displayed): Change type of win_info. Update.
8142 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8143 (tui_source_window_base::do_make_visible_with_new_height):
8145 * tui/tui-source.c (tui_set_source_content)
8146 (tui_set_source_content_nil)
8147 (tui_source_window::do_scroll_vertical): Update.
8148 * tui/tui-layout.c (show_layout): Update.
8149 * tui/tui-disasm.c (tui_set_disassem_content)
8150 (tui_disasm_window::do_scroll_vertical): Update.
8151 * tui/tui-data.h (tui_win_content): Remove.
8152 (struct tui_gen_win_info) <content, content_size>: Remove.
8153 (struct tui_source_element): Add initializers and destructor.
8154 (union tui_which_element, struct tui_win_element): Remove.
8155 (struct tui_source_window_base) <content>: New field.
8156 (struct tui_data_window): Remove destructor.
8157 (tui_alloc_content, tui_free_win_content)
8158 (tui_free_all_source_wins_content): Don't declare.
8159 * tui/tui-data.c (tui_initialize_static_data): Update.
8160 (init_content_element, tui_alloc_content): Remove.
8161 (~tui_gen_win_info): Update.
8162 (~tui_data_window, tui_free_all_source_wins_content)
8163 (tui_free_win_content, free_content, free_content_elements):
8166 2019-06-25 Tom Tromey <tom@tromey.com>
8168 * tui/tui-winsource.h (tui_clear_source_content)
8169 (tui_erase_source_content, tui_show_source_content): Change type
8171 * tui/tui-winsource.c (tui_clear_source_content)
8172 (tui_erase_source_content, tui_show_source_content): Change type
8174 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8175 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8177 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8179 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8181 2019-06-25 Tom Tromey <tom@tromey.com>
8183 * tui/tui-winsource.c (tui_clear_source_content)
8184 (tui_source_window_base::set_is_exec_point_at): Update.
8185 * tui/tui-source.c (tui_set_source_content_nil): Update.
8186 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8188 * tui/tui-data.c (init_content_element): Update.
8190 2019-06-25 Tom Tromey <tom@tromey.com>
8192 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8193 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8194 * tui/tui-layout.c (init_and_make_win): Update.
8195 * tui/tui.h (enum tui_win_type): Update.
8196 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8197 tui_win_is_auxillary.
8198 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8199 tui_win_is_auxillary.
8201 2019-06-25 Tom Tromey <tom@tromey.com>
8203 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8204 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8205 (tui_delete_data_content_windows, tui_display_all_data)
8206 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8208 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8209 * tui/tui-regs.c (tui_last_regs_line_no)
8210 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8211 (tui_show_registers): Update.
8212 (tui_show_register_group): Return void. Update.
8213 (tui_display_registers_from, tui_display_reg_element_at_line)
8214 (tui_display_registers_from_line, tui_check_register_values):
8216 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8218 (struct tui_data_window) <regs_content>: Now a std::vector.
8219 <regs_content_count>: Remove.
8220 (tui_add_content_elements, tui_free_data_content): Don't declare.
8221 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8222 (init_content_element): Remove DATA_WIN case. Add assert.
8223 (tui_add_content_elements): Remove.
8224 (tui_data_window): Update.
8225 (tui_free_data_content): Remove.
8226 (free_content_elements): Remove DATA_WIN case.
8228 2019-06-25 Tom Tromey <tom@tromey.com>
8230 * tui/tui-data.c (tui_data_item_window): Update.
8231 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8232 * tui/tui-windata.c (tui_display_all_data)
8233 (tui_display_data_from_line): Update.
8234 (tui_check_data_values): Remove.
8235 * tui/tui-regs.c (tui_show_register_group)
8236 (tui_display_reg_element_at_line): Update.
8237 * tui/tui-hooks.c (tui_register_changed)
8238 (tui_refresh_frame_and_register_information): Call
8239 tui_check_register_values.
8240 * tui/tui-data.h (struct tui_data_window) <data_content,
8241 data_content_count, data_type>: Remove.
8242 (enum tui_data_type): Remove.
8244 * tui/tui-data.c (tui_data_window::clear_detail)
8245 (~tui_data_window): Update.
8247 2019-06-25 Tom Tromey <tom@tromey.com>
8249 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8251 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8252 Rename from tui_first_data_item_displayed. Update.
8253 (tui_data_window::refresh_all)
8254 (tui_data_window::do_scroll_vertical): Update.
8255 * tui/tui-data.h (struct tui_data_window)
8256 <first_data_item_displayed>: Declare new method.
8258 2019-06-25 Tom Tromey <tom@tromey.com>
8260 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8261 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8263 (tui_initialize_static_data): ...here.
8265 2019-06-25 Tom Tromey <tom@tromey.com>
8267 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8268 (tui_display_registers_from, tui_check_register_values): Update.
8269 (tui_display_register): Remove win_info parameter; update.
8270 (tui_get_register): Change type of parameters.
8271 * tui/tui-data.h (struct tui_data_element): Remove.
8272 (union tui_which_element) <data>: Remove.
8273 <data_window>: Change type.
8274 (struct tui_data_item_window): New.
8275 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8277 (~tui_data_item_window): New destructor.
8278 (free_content_elements): Remove DATA_ITEM_WIN case.
8280 2019-06-25 Tom Tromey <tom@tromey.com>
8282 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8285 2019-06-25 Tom Tromey <tom@tromey.com>
8287 * tui/tui-data.h (struct tui_command_element): Remove.
8288 (union tui_which_element) <command>: Remove.
8289 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8291 (free_content_elements): Remove CMD_WIN case.
8293 2019-06-25 Tom Tromey <tom@tromey.com>
8295 * tui/tui-layout.c (tui_set_layout): Update.
8296 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8297 * tui/tui-data.c (layout_def): Update.
8299 2019-06-25 Tom Tromey <tom@tromey.com>
8301 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8302 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8303 (tui_source_window_base::set_new_height): Update.
8304 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8306 (tui_set_locator_fullname, tui_set_locator_info)
8307 (tui_show_frame_info): Update.
8308 * tui/tui-source.c (tui_set_source_content)
8309 (tui_source_is_displayed): Update.
8310 * tui/tui-layout.c (show_source_disasm_command, show_data)
8311 (show_source_or_disasm_and_command): Update.
8312 * tui/tui-disasm.c (tui_set_disassem_content)
8313 (tui_get_begin_asm_address): Update.
8314 * tui/tui-data.h (struct tui_locator_element): Remove.
8315 (union tui_which_element) <locator>: Remove.
8316 (struct tui_locator_window): New.
8317 (tui_locator_win_info_ptr): Change return type.
8318 * tui/tui-data.c (_locator): Change type.
8319 (tui_locator_win_info_ptr): Change return type.
8320 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8321 (tui_alloc_content): Add assert.
8323 2019-06-25 Tom Tromey <tom@tromey.com>
8325 * tui/tui-winsource.c
8326 (tui_exec_info_window::maybe_allocate_content): New method.
8327 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8328 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8329 (make_source_or_disasm_window): Add cast.
8330 * tui/tui-data.h (union tui_which_element) <simple_string>:
8332 (struct tui_source_info): New.
8333 (struct tui_source_window_base) <execution_info>: Change type.
8334 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8335 case, and add assert.
8336 (tui_alloc_content): Add assert.
8338 2019-06-25 Tom Tromey <tom@tromey.com>
8340 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8341 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8342 * tui/tui-data.c (tui_alloc_win_info): Remove.
8344 2019-06-25 Tom Tromey <tom@tromey.com>
8346 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8347 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8350 2019-06-25 Tom Tromey <tom@tromey.com>
8352 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8353 make_visible_with_new_height method.
8354 (tui_win_info::make_visible_with_new_height): New method.
8355 (tui_source_window_base::do_make_visible_with_new_height)
8356 (tui_data_window::do_make_visible_with_new_height)
8357 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8358 (make_visible_with_new_height): Remove.
8359 (tui_resize_all, tui_adjust_win_heights): Use
8360 make_visible_with_new_height method.
8361 * tui/tui-data.h (struct tui_win_info)
8362 <do_make_visible_with_new_height, make_visible_with_new_height>:
8364 (struct tui_source_window_base, struct tui_data_window)
8365 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8368 2019-06-25 Tom Tromey <tom@tromey.com>
8370 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8372 (update_tab_width): Call update_tab_width method.
8373 * tui/tui-data.h (struct tui_win_info)
8374 (struct tui_source_window_base) <update_tab_width>: New methods.
8376 2019-06-25 Tom Tromey <tom@tromey.com>
8378 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8380 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8382 (tui_gen_win_info::make_visible): Update.
8383 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8385 * tui/tui-data.h (enum tui_box): New enum.
8386 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8388 2019-06-25 Tom Tromey <tom@tromey.com>
8390 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8391 init_and_make_win for EXEC_INFO_WIN.
8392 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8394 (struct tui_win_info) <~tui_win_info>: Inline.
8395 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8397 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8398 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8400 (tui_initialize_static_data): Update.
8401 (~tui_gen_win_info): Handle more cleanup here.
8402 (~tui_source_window_base): Delete "execution_info".
8403 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8405 2019-06-25 Tom Tromey <tom@tromey.com>
8407 * tui/tui-layout.c (make_command_window): Don't set
8409 (show_source_disasm_command): Call the reset method.
8410 (show_data): Don't set can_highlight. Call the reset method.
8411 (tui_gen_win_info::reset): Rename from init_gen_win_info
8412 (init_and_make_win): Simplify. Return tui_gen_win_info.
8413 (show_source_or_disasm_and_command): Call the reset method.
8414 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8415 (struct tui_cmd_window): Set can_highlight.
8417 2019-06-25 Tom Tromey <tom@tromey.com>
8419 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8421 (tui_make_visible, tui_make_invisible): Rewrite.
8422 (tui_win_info::make_visible): Remove.
8423 (tui_source_window_base::make_visible): Update.
8424 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8425 method. Moved from...
8426 (struct tui_win_info) <make_visible>: ...here.
8428 2019-06-25 Tom Tromey <tom@tromey.com>
8430 * tui/tui-winsource.c
8431 (tui_source_window_base::do_scroll_horizontal): Remove direction
8433 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8434 direction parameter.
8435 * tui/tui-win.c (tui_win_info::forward_scroll)
8436 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8437 (tui_win_info::right_scroll): Update.
8438 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8439 direction parameter.
8440 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8441 direction parameter.
8442 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8443 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8444 Remove direction parameter.
8445 (struct tui_source_window_base, struct tui_source_window)
8446 (struct tui_disasm_window, struct tui_data_window)
8447 (struct tui_cmd_window): Update.
8449 2019-06-25 Tom Tromey <tom@tromey.com>
8451 * tui/tui-winsource.h (tui_set_exec_info_content)
8452 (tui_show_exec_info_content, tui_erase_exec_info_content)
8453 (tui_clear_exec_info_content, tui_update_exec_info): Change
8454 argument to tui_source_window_base.
8455 * tui/tui-winsource.c (tui_set_exec_info_content)
8456 (tui_show_exec_info_content, tui_erase_exec_info_content)
8457 (tui_clear_exec_info_content, tui_update_exec_info): Change
8458 argument to tui_source_window_base.
8460 2019-06-25 Tom Tromey <tom@tromey.com>
8462 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8463 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8465 2019-06-25 Tom Tromey <tom@tromey.com>
8467 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8470 2019-06-25 Tom Tromey <tom@tromey.com>
8472 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8474 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8476 * tui/tui-source.c (tui_set_source_content): Update.
8477 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8479 2019-06-25 Tom Tromey <tom@tromey.com>
8481 * tui/tui-win.c (window_name_completer, tui_set_focus)
8482 (tui_all_windows_info): Use name method.
8483 * tui/tui-data.h (struct tui_gen_win_info)
8484 (struct tui_source_window, struct tui_disasm_window)
8485 (struct tui_data_window, struct tui_cmd_window) <name>: New
8487 (tui_win_name): Don't declare.
8488 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8489 (tui_win_name): Remove.
8491 2019-06-25 Tom Tromey <tom@tromey.com>
8493 * tui/tui-winsource.h (tui_update_source_window)
8494 (tui_update_source_window_as_is): Change parameter type.
8495 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8496 to be a tui_source_window_base.
8497 (tui_update_source_window_as_is): Likewise.
8498 * tui/tui-win.c (make_visible_with_new_height): Update.
8500 2019-06-25 Tom Tromey <tom@tromey.com>
8502 * tui/tui-winsource.c (tui_erase_source_content)
8503 (tui_show_source_content, tui_show_exec_info_content)
8504 (tui_erase_exec_info_content): Use refresh_window method.
8505 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8506 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8507 from tui_refresh_win.
8508 (tui_data_window::refresh_window): New method.
8509 (tui_win_info::refresh, tui_source_window_base::refresh)
8510 (tui_refresh_all): Use refresh_window method.
8511 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8513 * tui/tui-regs.c (tui_display_register): Call refresh_window
8515 * tui/tui-layout.c (show_source_disasm_command)
8516 (show_source_or_disasm_and_command): Call refresh_window method.
8517 * tui/tui-data.h (struct tui_gen_win_info)
8518 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8521 2019-06-25 Tom Tromey <tom@tromey.com>
8523 * tui/tui.c (tui_rl_other_window, tui_enable)
8524 (tui_is_window_visible, tui_get_command_dimension): Update.
8525 * tui/tui-winsource.c (tui_update_source_window_as_is)
8526 (tui_clear_source_content, tui_erase_source_content)
8527 (tui_show_source_line, tui_source_window_base::refill)
8528 (tui_source_window_base::do_scroll_horizontal)
8529 (tui_source_window_base::set_is_exec_point_at)
8530 (tui_update_breakpoint_info, tui_set_exec_info_content)
8531 (tui_alloc_source_buffer, tui_line_is_displayed)
8532 (tui_addr_is_displayed): Update.
8533 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8534 (tui_check_and_display_highlight_if_needed)
8535 (tui_win_info::make_visible, tui_win_info::refresh)
8536 (tui_refresh_all): Update.
8537 * tui/tui-windata.c (tui_first_data_item_displayed)
8538 (tui_delete_data_content_windows, tui_erase_data_content)
8539 (tui_display_all_data, tui_data_window::refresh_all)
8540 (tui_check_data_values): Update.
8541 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8542 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8543 (tui_win_info::backward_scroll, tui_refresh_all_win)
8544 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8545 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8546 (tui_source_window_base::set_new_height)
8547 (tui_data_window::set_new_height)
8548 (make_invisible_and_set_new_height)
8549 (make_visible_with_new_height, new_height_ok)
8550 (parse_scrolling_args): Update.
8551 * tui/tui-stack.c (tui_show_frame_info): Update.
8552 * tui/tui-source.c (tui_set_source_content)
8553 (tui_set_source_content_nil, tui_source_is_displayed)
8554 (tui_source_window::do_scroll_vertical): Update.
8555 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8556 (tui_display_registers_from, tui_display_reg_element_at_line)
8557 (tui_check_register_values, tui_reg_command): Update.
8558 * tui/tui-layout.c (tui_default_win_height)
8559 (show_source_disasm_command, show_data, init_and_make_win)
8560 (show_source_or_disasm_and_command): Update.
8561 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8562 (tui_redisplay_readline, tui_mld_flush)
8563 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8565 * tui/tui-disasm.c (tui_set_disassem_content)
8566 (tui_disasm_window::do_scroll_vertical): Update.
8567 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8569 (struct tui_win_info): Derive from tui_gen_win_info.
8570 <~tui_win_info>: Mark as override.
8571 <generic>: Remove member.
8572 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8573 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8574 (~tui_data_window, ~tui_win_info)
8575 (tui_free_all_source_wins_content): Update.
8576 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8578 2019-06-25 Tom Tromey <tom@tromey.com>
8580 * tui/tui-layout.c (init_and_make_win): Use new.
8581 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8582 destructor, initializers.
8583 (tui_alloc_generic_win_info): Don't declare.
8584 * tui/tui-data.c (_locator): Add argument to constructor.
8585 (source_win, disasm_win): New globals.
8586 (exec_info): Remove.
8587 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8589 (tui_alloc_generic_win_info): Remove.
8590 (init_content_element): Use new.
8591 (tui_win_info::tui_win_info): Update.
8592 (free_content_elements) <case DATA_WIN>: Use delete.
8594 2019-06-25 Tom Tromey <tom@tromey.com>
8596 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8597 * tui/tui-windata.c (tui_first_data_item_displayed)
8598 (tui_delete_data_content_windows): Update.
8599 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8600 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8601 (tui_display_registers_from, tui_check_register_values): Update.
8602 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8604 * tui/tui-data.c (init_content_element): Update. Allocate the new
8606 (tui_free_data_content): Update.
8607 (free_content_elements) <case DATA_WIN>: Free the window.
8609 2019-06-25 Tom Tromey <tom@tromey.com>
8611 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8613 * tui/tui-layout.c (make_command_window)
8614 (show_source_disasm_command, show_data, init_and_make_win)
8615 (show_source_or_disasm_and_command): Update.
8616 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8618 <can_highight, is_highlighted>: Now bool.
8619 (tui_set_win_highlight): Don't declare.
8620 * tui/tui-data.c (tui_set_win_highlight): Remove.
8622 2019-06-25 Tom Tromey <tom@tromey.com>
8624 * tui/tui-wingeneral.c (make_visible): Remove check of window
8627 2019-06-25 Tom Tromey <tom@tromey.com>
8629 * tui/tui-win.c (tui_win_info::max_height)
8630 (tui_cmd_window::max_height): New methods.
8631 (new_height_ok): Call max_height.
8632 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8633 <max_height>: New method.
8635 2019-06-25 Tom Tromey <tom@tromey.com>
8637 * tui/tui-win.c (tui_source_window_base::set_new_height)
8638 (tui_data_window::set_new_height): New methods.
8639 (make_invisible_and_set_new_height): Call set_new_height method.
8640 * tui/tui-data.h (struct tui_win_info)
8641 (struct tui_source_window_base, struct tui_data_window)
8642 <set_new_height>: New method.
8644 2019-06-25 Tom Tromey <tom@tromey.com>
8646 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8647 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8648 tui_refresh_data_win.
8649 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8651 (tui_refresh_all_win): Call the refresh_all method.
8652 (tui_set_focus): Likewise.
8653 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8654 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8657 2019-06-25 Tom Tromey <tom@tromey.com>
8659 * tui/tui-winsource.h (tui_refill_source_window)
8660 (tui_set_is_exec_point_at): Don't declare.
8661 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8662 (tui_source_window_base::refill): Rename from
8663 tui_refill_source_window.
8664 (tui_source_window_base::do_scroll_horizontal): Update.
8665 (tui_source_window_base::set_is_exec_point_at): Rename from
8666 tui_set_is_exec_point_at.
8667 (tui_update_all_breakpoint_info): Update.
8668 * tui/tui-stack.c (tui_show_frame_info): Update.
8669 * tui/tui-layout.c (show_data): Add cast.
8670 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8671 * tui/tui-data.h (struct tui_source_window_base) <refill,
8672 set_is_exec_point_at>: New methods.
8673 (tui_source_windows, tui_add_to_source_windows): Update types.
8674 (tui_add_to_source_windows): Remove redundant declaration.
8675 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8676 (tui_source_windows): Change return type.
8677 (tui_clear_source_windows_detail): Update.
8678 (tui_add_to_source_windows): Change type of parameter.
8679 (tui_free_all_source_wins_content): Update.
8681 2019-06-25 Tom Tromey <tom@tromey.com>
8683 * tui/tui-wingeneral.c (tui_win_info::refresh)
8684 (tui_source_window_base::refresh): New methods.
8685 (tui_refresh_all): Call the refresh method.
8686 * tui/tui-data.h (struct tui_win_info)
8687 (struct tui_source_window_base) <refresh>: New method.
8689 2019-06-25 Tom Tromey <tom@tromey.com>
8691 * tui/tui.h (tui_is_window_visible): Return bool.
8692 * tui/tui.c (tui_is_window_visible): Return bool.
8693 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8694 (tui_make_visible, tui_make_invisible)
8695 (tui_win_info::make_visible)
8696 (tui_source_window_base::make_visible, make_all_visible)
8697 (tui_make_all_visible, tui_make_all_invisible): Update.
8698 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8699 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8701 (struct tui_win_info, struct tui_source_window_base)
8702 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8703 * tui/tui-data.c (tui_init_generic_part): Update.
8705 2019-06-25 Tom Tromey <tom@tromey.com>
8707 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8708 (tui_source_window_base::make_visible): New methods.
8709 (make_all_visible): Make method call.
8710 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8711 (struct tui_source_window_base, struct tui_cmd_window): Override
8713 (tui_win_is_source_type): Don't declare.
8714 * tui/tui-data.c (tui_win_is_source_type): Remove.
8716 2019-06-25 Tom Tromey <tom@tromey.com>
8718 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8721 2019-06-25 Tom Tromey <tom@tromey.com>
8723 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8724 Inline constructor. Add initializers for members.
8725 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8726 constructors; now inline in class.
8728 2019-06-25 Tom Tromey <tom@tromey.com>
8730 * tui/tui-regs.c (tui_show_registers): Update.
8731 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8733 * tui/tui-data.c (tui_data_window::clear_detail)
8734 (tui_data_window): Update.
8736 2019-06-25 Tom Tromey <tom@tromey.com>
8738 * tui/tui-windata.c (tui_display_all_data)
8739 (tui_display_data_from_line, tui_display_data_from)
8740 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8742 * tui/tui-regs.c (tui_last_regs_line_no)
8743 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8744 (tui_show_registers, tui_show_register_group)
8745 (tui_display_registers_from, tui_display_reg_element_at_line)
8746 (tui_display_registers_from_line, tui_check_register_values)
8747 (tui_reg_next, tui_reg_prev): Update.
8748 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8749 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8751 (struct tui_win_info) <detail>: Remove. Add new fields from
8753 (TUI_DATA_WIN): Add cast.
8754 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8755 (~tui_data_window): Simplify.
8757 2019-06-25 Tom Tromey <tom@tromey.com>
8759 * tui/tui-layout.c (show_source_disasm_command)
8760 (show_source_or_disasm_and_command): Update.
8761 * tui/tui-io.c (update_cmdwin_start_line)
8762 (tui_redisplay_readline): Update.
8763 * tui/tui-data.h (struct tui_command_info): Remove.
8764 (struct tui_win_info) <detail>: Remove command_info member.
8765 (struct tui_data_window) <start_line>: New member, from
8767 (TUI_CMD_WIN): Add casts.
8769 2019-06-25 Tom Tromey <tom@tromey.com>
8771 * tui/tui-winsource.c (tui_update_source_window)
8772 (tui_refill_source_window)
8773 (tui_source_window_base::do_scroll_horizontal)
8774 (tui_update_breakpoint_info, tui_set_exec_info_content)
8775 (tui_show_exec_info_content, tui_erase_exec_info_content)
8776 (tui_clear_exec_info_content): Update.
8777 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8779 * tui/tui-win.c (make_invisible_and_set_new_height)
8780 (make_visible_with_new_height): Update.
8781 * tui/tui-source.c (tui_set_source_content)
8782 (tui_show_symtab_source): Update.
8783 * tui/tui-layout.c (extract_display_start_addr)
8784 (show_source_disasm_command, show_data)
8785 (make_source_or_disasm_window)
8786 (show_source_or_disasm_and_command): Update.
8787 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8788 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8790 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8791 to tui_source_window_base.
8792 (struct tui_win_info) <detail>: Remove source_info member.
8793 (struct tui_source_window_base) <has_locator>: Inline.
8794 Move contents from tui_source_info; rename has_locator member to
8796 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8797 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8799 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8801 (tui_free_all_source_wins_content): Cast to
8802 tui_source_window_base.
8804 2019-06-25 Tom Tromey <tom@tromey.com>
8806 * tui/tui-win.c (make_invisible_and_set_new_height)
8807 (make_visible_with_new_height): Call has_locator method.
8808 * tui/tui-layout.c (show_source_disasm_command, show_data)
8809 (show_source_or_disasm_and_command): Update for bool change.
8810 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8811 (tui_win_info) <has_locator>: New method.
8812 (struct tui_source_window_base) <has_locator>: New method.
8813 (tui_win_has_locator): Don't declare.
8814 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8815 from tui_win_has_locator.
8816 (tui_source_window_base): Use false, not FALSE.
8818 2019-06-25 Tom Tromey <tom@tromey.com>
8820 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8821 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8822 clear_detail method directly.
8823 (tui_clear_win_detail): Remove.
8825 2019-06-25 Tom Tromey <tom@tromey.com>
8827 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8828 "this", not TUI_DISASM_WIN.
8830 2019-06-25 Tom Tromey <tom@tromey.com>
8832 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8834 * tui/tui-winsource.c
8835 (tui_source_window_base::do_scroll_horizontal): Rename from
8836 tui_horizontal_source_scroll.
8837 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8838 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8839 from tui_vertical_data_scroll.
8840 * tui/tui-win.h (tui_scroll): Don't declare.
8841 * tui/tui-win.c (tui_win_info::forward_scroll)
8842 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8843 (tui_win_info::right_scroll): Rename and update.
8844 (tui_scroll_forward_command, tui_scroll_backward_command)
8845 (tui_scroll_left_command, tui_scroll_right_command): Update.
8846 (tui_scroll): Remove.
8847 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8848 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8849 from tui_vertical_source_scroll.
8850 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8851 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8852 from tui_vertical_disassem_scroll.
8853 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8854 do_scroll_horizontal>: New methods.
8855 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8857 (struct tui_source_window_base): Add do_scroll_horizontal.
8858 (struct tui_source_window, struct tui_disasm_window): Add
8860 (struct tui_data_window, struct tui_cmd_window): Add
8861 do_scroll_horizontal and do_scroll_vertical.
8862 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8864 2019-06-25 Tom Tromey <tom@tromey.com>
8866 * tui/tui-data.h (struct tui_source_window_base): New struct.
8867 (struct tui_source_window): Derive from tui_source_window_base.
8868 (struct tui_disasm_window): New struct.
8869 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8870 from tui_source_window::clear_detail.
8871 (tui_source_window_base): Rename from tui_source_window.
8872 (~tui_source_window_base): Rename from ~tui_source_window.
8873 (tui_alloc_win_info): Create a tui_disasm_window.
8875 2019-06-25 Tom Tromey <tom@tromey.com>
8877 * tui/tui-data.h (struct tui_source_window)
8878 (struct tui_data_window): Declare destructors.
8879 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8881 (tui_win_info): Simplify.
8883 2019-06-25 Tom Tromey <tom@tromey.com>
8885 * tui/tui-winsource.c (tui_display_main)
8886 (tui_update_source_windows_with_addr)
8887 (tui_update_all_breakpoint_info): Update.
8888 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8889 (new_height_ok, parse_scrolling_args): Update.
8890 * tui/tui-stack.c (tui_show_frame_info): Update.
8891 * tui/tui-data.h (struct tui_list): Remove.
8892 (tui_source_windows): Return a reference to a std::vector.
8893 * tui/tui-data.c (source_windows): Now a std::vector.
8894 (tui_source_windows): Change return type.
8895 (tui_clear_source_windows): Rewrite.
8896 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8897 (tui_free_all_source_wins_content): Rewrite.
8899 2019-06-25 Tom Tromey <tom@tromey.com>
8901 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8902 (struct tui_data_window, struct tui_cmd_window): Declare
8903 clear_detail method.
8904 * tui/tui-data.c (tui_source_window::clear_detail)
8905 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8907 (tui_clear_win_detail): Simplify.
8909 2019-06-25 Tom Tromey <tom@tromey.com>
8911 * tui/tui-layout.c (make_source_window, make_disasm_window)
8912 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8913 Return the new window.
8914 (show_source_disasm_command, show_data)
8915 (show_source_or_disasm_and_command): Update.
8917 2019-06-25 Tom Tromey <tom@tromey.com>
8919 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8920 parameter. Return the new window.
8921 (show_source_disasm_command): Update and remove NULL check.
8922 (show_source_or_disasm_and_command): Update.
8924 2019-06-25 Tom Tromey <tom@tromey.com>
8926 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8928 2019-06-25 Tom Tromey <tom@tromey.com>
8930 * tui/tui-data.h (struct tui_win_info): Make constructor
8931 protected. Make destructor virtual. Add initializers.
8932 (tui_source_window, tui_data_window, tui_cmd_window): New
8934 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8935 constructor. Add "type" parameter.
8936 (tui_source_window, tui_data_window, tui_cmd_window): New
8938 (tui_alloc_win_info): Instantiate the appropriate subclass.
8940 2019-06-25 Tom Tromey <tom@tromey.com>
8942 * tui/tui-win.c (tui_resize_all): Use delete.
8943 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8945 (tui_free_window): Don't declare.
8946 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8949 2019-06-25 Tom Tromey <tom@tromey.com>
8951 * tui/tui-data.h (struct tui_win_info): Add constructor.
8952 * tui/tui-data.c (tui_alloc_win_info): Use new.
8953 (tui_free_window): Use delete.
8955 2019-06-22 Tom Tromey <tom@tromey.com>
8957 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8959 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8961 2019-06-22 Tom Tromey <tom@tromey.com>
8963 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8965 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8967 2019-06-22 Tom de Vries <tdevries@suse.de>
8969 * dwarf2read.c (create_addrmap_from_aranges)
8970 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8973 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
8975 * dwarf2read.h (dwarf2_section_info_def): Remove.
8976 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8977 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8978 std::vector<dwarf2_section_info>.
8979 (struct dwo_file) <~dwo_file>: Remove.
8980 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8982 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8983 (dwarf2_read_debug_names): Likewise.
8984 (create_debug_types_hash_table): Change parameter type to
8985 array_view, adjust code accordingly.
8986 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8987 (partial_die_info::fixup): Likewise.
8988 (determine_prefix): Likewise.
8989 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8991 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8993 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8995 <~dwo_file>: Remove call to gdb_bfd_unref.
8996 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8997 gdb_bfd_ref_ptr::get.
8999 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9001 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9003 * dwarf2read.c (struct dwo_file): Initialize fields.
9005 (free_dwo_file): Remove, move content to ~dwo_file.
9006 (struct dwo_file_deleter): Remove.
9007 (dwo_file_up>: Remove custom deleter.
9008 (free_dwo_files): Remove.
9009 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9011 (process_skeletonless_type_units): Call unique_ptr::get.
9012 (allocate_dwo_file_hash_table): Add deleter to created hash
9013 table. Change return type to htab_up.
9014 (lookup_dwo_file_slot): Don't memset dwo_file, call
9016 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9017 (create_dwo_unit_in_dwp_v2): Likewise.
9018 (open_and_init_dwo_file): Likewise.
9019 (free_dwo_file_from_slot): Remove.
9021 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9023 * dwarf2read.h (struct dwarf2_section_info) <readin,
9024 is_virtual>: Change type to bool.
9025 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9028 2019-06-19 Tom Tromey <tom@tromey.com>
9030 * tui/tui-data.h (tui_init_content_element): Don't declare.
9032 2019-06-19 Tom Tromey <tom@tromey.com>
9034 * tui/tui-data.h (tui_init_win_info): Don't declare.
9036 2019-06-19 Tom de Vries <tdevries@suse.de>
9038 * dwarf2read.h (abstract_to_concrete): Change type to
9039 std::unordered_map<sect_offset, std::vector<sect_offset>,
9040 gdb::hash_enum<sect_offset>>.
9042 2019-06-19 Tom Tromey <tromey@adacore.com>
9044 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9045 EVAL_AVOID_SIDE_EFFECTS specially.
9047 2019-06-19 Tom Tromey <tromey@adacore.com>
9049 * source-cache.c (highlighter): New global.
9050 (source_cache::get_source_lines): Create a highlighter on demand.
9052 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9054 * defs.h (deprecated_interactive_hook): Delete declaration.
9055 * interps.c (clear_interpreter_hooks): Remove use of
9056 deprecated_interactive_hook.
9057 * top.c (deprecated_interactive_hook): Delete definition.
9058 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9060 2019-06-18 Tom de Vries <tdevries@suse.de>
9063 * dwarf2read.h (abstract_to_concrete): Change type from
9064 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9065 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9066 * dwarf2read.c (read_variable): Update.
9067 (dwarf2_fetch_die_loc_sect_off): Update.
9069 2019-06-17 Tom de Vries <tdevries@suse.de>
9072 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9073 accessing parent[parent_len - 1].
9075 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9078 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9079 call dtrace_process_dof with NULL dof.
9081 2019-06-16 Tom de Vries <tdevries@suse.de>
9084 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9086 2019-06-16 Tom Tromey <tom@tromey.com>
9088 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9089 (make_all_visible): Use address of member.
9091 2019-06-16 Tom Tromey <tom@tromey.com>
9093 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9094 (tui_free_window, free_content, free_content_elements): Remove
9096 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9098 * tui/tui-regs.c (tui_show_register_group)
9099 (tui_display_registers_from, tui_display_reg_element_at_line):
9100 Remove unnecessary cast.
9102 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9104 * linux-nat.c (normal_mask): Delete.
9105 (_initialize_linux_nat): Don't initialise normal_mask.
9107 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9110 * dwarf-index-write.h (write_psymtabs_to_index): Add
9111 dwz_basename parameter.
9112 * dwarf-index-write.c (write_gdbindex): Move file writing to
9113 write_gdbindex_1. Change return type void.
9114 (assert_file_size): Move up, remove filename parameter.
9115 (write_gdbindex_1): New function.
9116 (write_debug_names): Change return type to void, call
9118 (struct index_wip_file): New struct.
9119 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9120 file logic to index_wip_file. Write index for dwz file if
9122 (save_gdb_index_command): Pass basename of dwz file, if present.
9123 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9124 build-id of dwz file, if present.
9125 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9126 (dwarf2_get_dwz_file): Likewise.
9127 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9128 (dwarf2_get_dwz_file): Likewise.
9130 2019-06-16 Tom Tromey <tom@tromey.com>
9132 * coffread.c (process_coff_symbol): Use xstrdup.
9133 * value.c (create_internalvar): Use xstrdup.
9135 2019-06-16 Tom Tromey <tom@tromey.com>
9137 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9138 * breakpoint.c (stopin_command, stopat_command)
9139 (until_break_command, decode_location_default): Remove unnecessary
9141 * utils.c (subset_compare): Remove unnecessary cast.
9142 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9144 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9146 * infcmd.c (path_command): Remove unnecessary cast.
9147 * coffread.c (decode_type): Remove unnecessary cast.
9148 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9149 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9150 * tui/tui-stack.c (tui_show_locator_content)
9151 (tui_show_frame_info): Remove unnecessary cast.
9152 * tui/tui-win.c (tui_scroll_forward_command)
9153 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9154 (parse_scrolling_args): Remove unnecessary cast.
9155 * tui/tui-data.c (init_win_info, tui_del_window)
9156 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9157 (free_content_elements): Remove unnecessary cast.
9158 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9160 * tui/tui-source.c (tui_set_source_content)
9161 (tui_vertical_source_scroll): Remove unnecessary cast.
9162 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9164 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9165 * tui/tui-regs.c (tui_display_registers_from)
9166 (tui_display_register): Remove unnecessary cast.
9167 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9168 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9169 (make_visible): Remove unnecessary cast.
9170 * tui/tui-winsource.c (tui_erase_source_content)
9171 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9173 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9174 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9175 * stabsread.c (read_type, read_array_type, read_range_type):
9176 Remove unnecessary cast.
9177 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9178 (parse_symbol, parse_type, upgrade_type, parse_external)
9179 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9181 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9183 2019-06-16 Tom Tromey <tom@tromey.com>
9185 * tui/tui-data.c (tui_alloc_generic_win_info)
9186 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9189 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9190 Andrew Burgess <andrew.burgess@embecosm.com>
9192 * f-typeprint.c (f_print_type): Don't return early for not
9193 associated or not allocated types.
9194 (f_type_print_varspec_suffix): Add print_rank parameter and print
9195 ranks of array types in case they dangling.
9196 (f_type_print_base): Add print_rank parameter.
9198 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9200 * NEWS: Mention new MI commands.
9201 * break-catch-throw.c (enum exception_event_kind): Move to
9203 (print_mention_exception_catchpoint): Output text as a single
9205 (catch_exception_command_1): Rename to...
9206 (catch_exception_event): ...this, make non-static, update header
9207 command, and change some parameter types.
9208 (catch_catch_command): Update for changes to
9209 catch_exception_command_1.
9210 (catch_throw_command): Likewise.
9211 (catch_rethrow_command): Likewise.
9212 * breakpoint.c (enum exception_event_kind): Delete.
9213 * breakpoint.h (enum exception_event_kind): Moved here from
9214 break-catch-throw.c.
9215 (catch_exception_event): Declare.
9216 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9217 (mi_cmd_catch_throw): New function.
9218 (mi_cmd_catch_rethrow): New function.
9219 (mi_cmd_catch_catch): New function.
9220 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9221 'catch-catch' entries.
9222 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9223 (mi_cmd_catch_rethrow): Declare.
9224 (mi_cmd_catch_catch): Declare.
9226 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9228 * annotate.c (annotate_source_line): Change return type to void,
9229 update implementation to match.
9230 * annotate.h (annotate_source_line): Change return type to void,
9231 update header comment.
9232 * stack.c (print_frame_info): Don't change what frame information
9233 is printed based on whether annotations are on or not.
9235 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9237 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9238 (annotate_source): Make static.
9239 (annotate_source_line): Moved from source.c and renamed from
9240 identify_source_line. Update the return type.
9241 * annotate.h (annotate_source): Delete declaration.
9242 (annotate_source_line): Declaration moved from source.h, and
9243 renamed from identify_source_line. Return type updated.
9244 * source.c (identify_source_line): Moved to annotate.c and renamed
9245 to annotate_source_line.
9246 (info_line_command): Remove check of annotation_level.
9247 * source.h (identify_source_line): Move declaration to annotate.h
9248 and rename to annotate_source_line.
9249 * stack.c: Add 'annotate.h' include.
9250 (print_frame_info): Remove check of annotation_level before
9251 calling annotate_source_line.
9253 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9255 * source-cache.c (source_cache::get_plain_source_lines): Use
9256 open_source_file_with_line_charpos instead of just
9257 open_source_file, remove call to find_source_lines.
9258 (source_cache::get_source_lines): Likewise.
9259 * source.c (find_source_lines): Make static.
9260 (get_filename_and_charpos): Renamed into...
9261 (open_source_file_with_line_charpos): ..this along with changes to
9262 return a scoped_fd, and some other minor clean ups.
9263 (identify_source_line): Use open_source_file_with_line_charpos.
9264 (search_command_helper): Use open_source_file_with_line_charpos
9265 instead of just open_source_file, remove call to
9267 * source.h (open_source_file_with_line_charpos): Declare new
9269 (find_source_lines): Delete declaration.
9271 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9273 * source.c (get_filename_and_charpos): Remove fullname
9275 (identify_source_line): Update call to get_filename_and_charpos.
9277 2019-06-14 Tom Tromey <tromey@adacore.com>
9280 * ui-style.h (skip_ansi_escape): Update comment.
9281 * ui-file.h (class no_terminal_escape_file): New class.
9282 * ui-file.c (no_terminal_escape_file::write)
9283 (no_terminal_escape_file::puts): New methods.
9284 * cli/cli-logging.c (handle_redirections): Use
9285 no_terminal_escape_file.
9287 2019-06-14 Tom Tromey <tromey@adacore.com>
9289 * NEWS: Move convenience variable news above Python news.
9291 2019-06-14 Tom Tromey <tom@tromey.com>
9293 * gnulib: Move directory to top-level.
9294 * configure.ac: Don't configure gnulib.
9295 * configure: Rebuild.
9296 * common/common-defs.h: Use new path to gnulib.
9297 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9299 (INCGNU): Look in new gnulib location.
9300 (HFILES_NO_SRCDIR): Remove gnulib files.
9301 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9302 (generated_files): Remove GNULIB_H.
9303 ($(LIBGNU), all-lib): Remove targets.
9304 (distclean): Don't mention GNULIB_BUILDDIR.
9305 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9307 2019-06-14 Tom Tromey <tromey@adacore.com>
9309 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9310 Warn if symbol file does not provide any symbols.
9312 2019-06-14 Tom Tromey <tromey@adacore.com>
9314 * source.c (find_and_open_source): Respect basenames_may_differ.
9316 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9318 * annotate.c (annotate_breakpoints_invalid): Make use of
9319 scoped_restore_terminal_state.
9320 (annotate_frames_invalid): Likewise.
9322 2019-06-14 Tom Tromey <tromey@adacore.com>
9324 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9325 allow assignment to an internalvar.
9327 2019-06-14 Tom Tromey <tromey@adacore.com>
9329 * ada-lex.l: Allow "_" in attribute names.
9331 2019-06-14 Tom Tromey <tromey@adacore.com>
9334 * regcache.c (registers_changed): Don't call alloca.
9335 * top.c (execute_command): Don't call alloca.
9337 2019-06-13 Pedro Alves <palves@redhat.com>
9339 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9340 'expression'. When parsing an expression, error out if there's
9341 junk after "unlimited".
9342 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9343 (do_set_command): Adjust calls to is_unlimited_literal.
9345 2019-06-13 Pedro Alves <palves@redhat.com>
9347 * compile/compile.c (make_compile_options_def_group): Add braces
9348 around array_view initializer.
9349 * thread.c (make_thread_apply_all_options_def_group)
9350 (make_thread_apply_all_options_def_group): Likewise.
9352 2019-06-13 Pedro Alves <palves@redhat.com>
9354 * NEWS (New commands): Mention "maint test-options
9355 require-delimiter", "maint test-options unknown-is-error", "maint
9356 test-options unknown-is-operand" and "maint show
9357 test-options-completion-result".
9358 (New command options, command completion): New section.
9359 (Completion improvements): New section.
9360 Mention that you can abbreviate "unlimited".
9362 2019-06-13 Pedro Alves <palves@redhat.com>
9364 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9365 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9366 * unittests/cli-utils-selftests.c (test_parse_flags)
9367 (test_parse_flags_qcs): Delete.
9368 (test_cli_utils): Don't call deleted functions.
9370 2019-06-13 Pedro Alves <palves@redhat.com>
9372 * thread.c: Include "cli/cli-option.h".
9373 (tp_array_compar_ascending): Global.
9374 (tp_array_compar): Delete function.
9375 (tp_array_compar_ascending, tp_array_compar_descending): New
9377 (ascending_option_def, qcs_flag_option_def)
9378 (thr_qcs_flags_option_defs)
9379 (make_thread_apply_all_options_def_group)
9380 (make_thread_apply_options_def_group): New.
9381 (thread_apply_all_command): Use gdb::option::process_options.
9382 (thread_apply_command_completer)
9383 (thread_apply_all_command_completer): New.
9384 (thread_apply_command): Use gdb::option::process_options.
9385 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9386 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9387 to generate help text of "thread apply". Adjust "taas"'s help.
9388 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9389 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9391 2019-06-13 Pedro Alves <palves@redhat.com>
9393 * thread.c (thread_apply_command): Check for invalid TID with
9394 isdigit instead of !isalpha.
9396 2019-06-13 Pedro Alves <palves@redhat.com>
9398 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9399 (validate_flags_qcs): New.
9400 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9401 (validate_flags_qcs): Declare.
9402 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9403 (make_frame_apply_options_def_group): New.
9404 (frame_apply_command_count): Process options with
9405 gdb::option::process_options.
9406 (frame_apply_completer): New.
9407 (frame_apply_level_completer, frame_apply_all_completer)
9408 (frame_apply_completer): New.
9409 (_initialize_stack): Update help of "frame apply", "frame apply
9410 level", "frame apply all" and "faas" to mention supported options
9411 and install command completers.
9412 * stack.h (frame_apply_all_completer): Declare.
9413 * thread.c: Include "stack.h".
9414 (tfaas_command): Add "--".
9415 (_initialize_thread): Update help "tfaas" to mention supported
9416 options and install command completer.
9418 2019-06-13 Pedro Alves <palves@redhat.com>
9420 * completer.c (complete_nested_command_line): New.
9421 (gdb_completion_word_break_characters_throw): Add assertion.
9422 * completer.h (complete_nested_command_line): Declare.
9424 2019-06-13 Pedro Alves <palves@redhat.com>
9426 * stack.c (parse_backtrace_qualifiers): New.
9427 (backtrace_command): Use it.
9428 (backtrace_command_completer): Complete on qualifiers.
9430 2019-06-13 Pedro Alves <palves@redhat.com>
9432 * frame.c: Include "cli/cli-option.h.
9433 (user_set_backtrace_options): New.
9434 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9436 (get_prev_frame): Adjust.
9437 (boolean_option_def, uinteger_option_def)
9438 (set_backtrace_option_defs): New.
9439 (_initialize_frame): Adjust and use
9440 gdb::option::add_setshow_cmds_for_options to install "set
9441 backtrace past-main" and "set backtrace past-entry".
9442 * frame.h: Include "cli/cli-option.h".
9443 (struct frame_print_options): Forward declare.
9444 (print_frame_arguments_all, print_frame_arguments_scalars)
9445 (print_frame_arguments_none): Declare.
9446 (print_entry_values): Delete declaration.
9447 (struct frame_print_options, user_frame_print_options): New.
9448 (struct set_backtrace_options): New.
9449 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9450 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9451 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9452 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9453 (list_args_or_locals): Add frame_print_options parameter.
9454 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9455 * python/py-framefilter.c (enumerate_args): Pass down
9456 USER_FRAME_PRINT_OPTIONS.
9457 * stack.c: Include "cli/cli-option.h".
9458 (print_frame_arguments_all, print_frame_arguments_scalars)
9459 (print_frame_arguments_none): Declare.
9460 (print_raw_frame_arguments, print_entry_values): Delete.
9461 (user_frame_print_options): New.
9462 (boolean_option_def, enum_option_def, frame_print_option_defs):
9464 (struct backtrace_cmd_options): New.
9465 (bt_flag_option_def): New.
9466 (backtrace_command_option_defs): New.
9467 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9468 (print_frame_arg, read_frame_arg, print_frame_args)
9469 (print_frame_info, print_frame): Add frame_print_options parameter
9471 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9472 (backtrace_command_1): Add frame_print_options and
9473 backtrace_cmd_options parameters and use them.
9474 (make_backtrace_options_def_group): New.
9475 (backtrace_command): Process command options with
9476 gdb::option::process_options.
9477 (backtrace_command_completer): New.
9478 (_initialize_stack): Extend "backtrace"'s help to mention
9479 supported options. Install completer for "backtrace".
9480 Install some settings commands with add_setshow_cmds_for_options.
9482 2019-06-13 Pedro Alves <palves@redhat.com>
9484 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9485 and that "set/show print raw frame-arguments" are now deprecated.
9487 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9489 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9490 * stack.c (_initialize_stack): Install "set/show print
9491 raw-frame-arguments", and deprecate "set/show print raw
9493 * valprint.c (_initialize_valprint): Deprecate "set/show print
9496 2019-06-13 Pedro Alves <palves@redhat.com>
9498 * compile/compile.c (struct compile_options): New.
9499 (compile_flag_option_def, compile_command_option_defs)
9500 (make_compile_options_def_group): New.
9501 (compile_file_command): Handle options with
9502 gdb::option::process_options.
9503 (compile_file_command_completer): New function.
9504 (compile_code_command): Handle options with
9505 gdb::option::process_options.
9506 (compile_code_command_completer): New function.
9507 (_initialize_compiler): Install completers for "compile code" and
9508 "compile file". Mention available options in "compile code" and
9509 "compile code"'s help.
9510 * completer.c (advance_to_completion_word): New, factored out from
9512 (advance_to_expression_complete_word_point): ... this.
9513 (advance_to_filename_complete_word_point): New.
9514 * completer.h (advance_to_filename_complete_word_point): New
9517 2019-06-13 Pedro Alves <palves@redhat.com>
9519 * compile/compile.c: Include "cli/cli-option.h".
9520 (compile_print_value): Scope data pointer is now a
9521 value_print_options pointer; adjust.
9522 (compile_print_command): Process options. Scope data pointer is
9523 now a value_print_options pointer; adjust.
9524 (_initialize_compile): Update "compile print"'s help to include
9525 supported options. Install a completer for "compile print".
9526 * cp-valprint.c (show_vtblprint, show_objectprint)
9527 (show_static_field_print): Delete.
9528 (_initialize_cp_valprint): Don't install "set print
9529 static-members", "set print vtbl", "set print object" here.
9530 * printcmd.c: Include "cli/cli-option.h" and
9531 "common/gdb_optional.h".
9532 (print_command_parse_format): Rework to fill in a
9533 value_print_options instead of a format_data.
9534 (print_value): Change parameter type from format_data pointer to
9535 value_print_options reference. Adjust.
9536 (print_command_1): Process options. Adjust to pass down a
9537 value_print_options.
9538 (print_command_completer): New.
9539 (_initialize_printcmd): Install print_command_completer as
9540 handle_brkchars completer for the "print" command. Update
9541 "print"'s help to include supported options.
9542 * valprint.c: Include "cli/cli-option.h".
9543 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9544 here from cp-valprint.c.
9545 (boolean_option_def, uinteger_option_def)
9546 (value_print_option_defs, make_value_print_options_def_group):
9547 New. Use gdb::option::add_setshow_cmds_for_options to install
9548 "set print elements", "set print null-stop", "set print repeats",
9549 "set print pretty", "set print union", "set print array", "set
9550 print address", "set print symbol", "set print array-indexes".
9551 * valprint.h: Include <string> and "cli/cli-option.h".
9552 (make_value_print_options_def_group): Declare.
9553 (print_value): Change parameter type from format_data pointer to
9554 value_print_options reference.
9555 (print_command_completer): Declare.
9557 2019-06-13 Pedro Alves <palves@redhat.com>
9559 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9560 (COMMON_SFILES): Add maint-test-settings.c.
9561 * cli/cli-decode.c (boolean_enums): New global, factored out from
9563 (add_setshow_boolean_cmd): ... here.
9564 * cli/cli-decode.h (boolean_enums): Declare.
9565 * cli/cli-option.c: New file.
9566 * cli/cli-option.h: New file.
9567 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9568 factored out from ...
9569 (parse_cli_boolean_value(const char *)): ... this.
9570 (is_unlimited_literal): Change parameter type to pointer to
9571 pointer. Adjust and advance ARG pointer.
9572 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9573 (parse_cli_var_enum): New, factored out from ...
9574 (do_set_command): ... this. Adjust.
9575 * cli/cli-setshow.h (parse_cli_boolean_value)
9576 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9577 (parse_cli_var_enum): Declare.
9578 * cli/cli-utils.c: Include "cli/cli-option.h".
9579 (get_ulongest): New.
9580 * cli/cli-utils.h (get_ulongest): Declare.
9581 (check_for_argument): New overloads.
9582 * maint-test-options.c: New file.
9584 2019-06-13 Pedro Alves <palves@redhat.com>
9586 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9587 parse a range if "-" is at the end of the string.
9589 2019-06-13 Pedro Alves <palves@redhat.com>
9591 * cli/cli-setshow.c (parse_auto_binary_operation)
9592 (parse_cli_boolean_value): Don't allow "o".
9594 2019-06-13 Pedro Alves <palves@redhat.com>
9596 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9597 * NEWS: Mention maint test-settings KIND.
9598 * maint-test-settings.c: New file.
9600 2019-06-13 Pedro Alves <palves@redhat.com>
9602 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9604 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9607 2019-06-13 Pedro Alves <palves@redhat.com>
9609 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9612 2019-06-13 Pedro Alves <palves@redhat.com>
9614 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9616 2019-06-13 Pedro Alves <palves@redhat.com>
9618 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9619 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9621 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9622 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9624 (check_for_argument): Skip spaces after argument.
9626 2019-06-13 Pedro Alves <palves@redhat.com>
9628 * thread.c (thread_apply_command): Adjust TID parsing.
9629 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9630 detected before end of string.
9631 (tid_is_in_list): Error out if LIST is invalid.
9633 2019-06-13 Pedro Alves <palves@redhat.com>
9635 * completer.c (complete_line_internal_1): Rewind completion word
9637 (completion_tracker::advance_custom_word_point_by): Change
9638 parameter type to int.
9639 * completer.h (completion_tracker::advance_custom_word_point_by):
9642 2019-06-13 Pedro Alves <palves@redhat.com>
9644 * completer.c (advance_to_completion_word): Handle delimiters.
9646 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9648 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9650 2019-06-11 Tom Tromey <tom@tromey.com>
9652 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9653 (xmalloc_failed): Move to alloc.c.
9654 * alloc.c: New file.
9655 * Makefile.in (COMMON_SFILES): Add alloc.c.
9657 2019-06-11 Tom Tromey <tom@tromey.com>
9659 * nat/linux-waitpid.c: Don't include server.h.
9660 (linux_debug): Remove.
9661 (my_waitpid): Update.
9663 2019-06-11 Tom Tromey <tromey@adacore.com>
9665 * infcall.c (_initialize_infcall): Remove trailing newline from
9667 * user-regs.c (_initialize_user_regs): Remove trailing newline
9669 * typeprint.c (_initialize_typeprint): Remove trailing newline
9671 * reverse.c (_initialize_reverse): Remove trailing newlines from
9673 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9675 * language.c (add_set_language_command): Remove trailing newline
9677 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9679 * disasm.c (_initialize_disasm): Remove trailing newline from
9681 * top.c (init_main): Remove trailing newline from help.
9682 * interps.c (_initialize_interpreter): Remove trailing newline
9684 * btrace.c (_initialize_btrace): Remove trailing newlines from
9686 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9688 * python/python.c (_initialize_python): Remove trailing newline
9690 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9692 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9693 from help. Reformat some text.
9694 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9696 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9699 2019-06-11 Tom Tromey <tromey@adacore.com>
9701 * darwin-nat.c (darwin_decode_exception_message)
9702 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9704 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9706 * valops.c (value_slice): Check for not allocated or not
9709 2019-06-10 Tom de Vries <tdevries@suse.de>
9712 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9713 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9716 2019-06-10 Tom de Vries <tdevries@suse.de>
9719 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9720 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9722 2019-06-10 Tom de Vries <tdevries@suse.de>
9725 * symtab.c (struct demangled_name_entry): Add language field.
9726 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9727 static minimal symbol". Set and use language field.
9729 2019-06-10 Tom Tromey <tromey@adacore.com>
9731 * ada-lang.c (_initialize_ada_language): Update help text.
9733 2019-06-10 Tom Tromey <tromey@adacore.com>
9735 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9737 * guile/guile.c (handle_boot_error): Don't end warning with a
9739 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9740 warning with a newline.
9741 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9743 (s12z_frame_cache): Likewise.
9744 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9746 * solib-svr4.c (disable_probes_interface): Don't end warning with
9748 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9750 * python/python.c (do_finish_initialization): Don't end warning
9753 2019-06-10 Tom Tromey <tom@tromey.com>
9755 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9756 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9759 2019-06-10 Tom Tromey <tromey@adacore.com>
9761 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9763 (elf_new_init): Don't call stabsread_new_init.
9764 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9765 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9766 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9768 2019-06-10 Tom de Vries <tdevries@suse.de>
9772 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9774 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9776 * source.c (find_and_open_source): Also rewrite relative file
9779 2019-04-26 Amos Bird <amosbird@gmail.com>
9781 * annotate.c (annotate_thread_exited): Add "thread-exited"
9784 2019-06-06 Tom Tromey <tromey@adacore.com>
9786 * maint.h (class scoped_command_stats): Use
9787 DISABLE_COPY_AND_ASSIGN.
9788 <print_time>: New method.
9789 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9791 (scoped_command_stats::print_time): New method.
9793 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9795 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9796 instructions of lengths 6 or 8 bytes.
9798 2019-06-04 Pedro Alves <palves@redhat.com>
9800 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9802 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9803 * breakpoint.c (condition_completer): Likewise.
9804 * cli/cli-dump.c (scan_expression): Likewise.
9805 * common/filestuff.c (mkdir_recursive): Likewise.
9806 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9807 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9808 (gdb_abspath): Likewise.
9809 * compile/compile-cplus-types.c
9810 (compile_cplus_instance::decl_name): Likewise.
9811 * completer.c (complete_explicit_location):
9812 (signal_completer, reg_or_group_completer_1): Likewise.
9813 * cp-support.c (cp_remove_params_if_any): Likewise.
9814 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9815 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9816 * infcmd.c (strip_bg_char): Likewise.
9817 * linespec.c (copy_token_string): Likewise.
9818 * mi/mi-main.c (output_cores): Likewise.
9819 * psymtab.c (psymtab_search_name):
9820 * symfile.c (test_set_ext_lang_command): Likewise.
9821 * target.c (target_fileio_read_stralloc): Likewise.
9822 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9823 * value.c (complete_internalvar): Likewise.
9825 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9827 Add objfile property to gdb.Type.
9828 * NEWS: Mention Python API addition.
9829 * python/py-type.c (typy_get_objfile): New method.
9831 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9833 * NEWS: Mention the new set|show style [title|highlight].
9834 Mention changes to "show style", "help" and "apropos".
9836 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9838 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9839 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9840 instead of print_help_for_command.
9841 (print_doc_of_command): New function.
9842 (help_list): Add 'apropos -v word' suggestion.
9843 (print_help_for_command): Style the command name using title style.
9844 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9845 (_initialize_cli_cmds): Describe -v in apropos_command help.
9847 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9849 * cli/cli-style.h (cli_style_option): Add name in constructor,
9850 add m_name class member, add constructor with intensity,
9851 add name class function.
9852 (cli_style_option::add_setshow_commands): Remove name argument.
9853 (highlight_style, title_style): New styles.
9854 * cli/cli-style.c (do_show): New function that shows a style
9855 characteristic styling the style name with itself.
9856 (set_style_name): New function.
9857 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9858 Update all callers according to the changes in cli/cli-style.h.
9859 * utils.h (fputs_highlighted): New function.
9860 * utils.c (fputs_highlighted): Likewise.
9862 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9864 * NEWS: Mention new pipe command and new convenience variables.
9866 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9868 * cli/cli-cmds.c (pipe_command): New function.
9869 (_initialize_cli_cmds): Call add_com for pipe_command.
9870 Define | as an alias for pipe.
9871 (exit_status_set_internal_vars): New function.
9872 (shell_escape): Call exit_status_set_internal_vars.
9873 cli/cli-decode.c (find_command_name_length): Recognize | as
9874 a single character command.
9876 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9878 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9879 top.c (execute_command_to_ui_file): New function, mostly a copy
9880 of execute_command_to_string.
9881 (execute_command_to_string): Implement by calling
9882 execute_command_to_ui_file.
9884 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9886 * top.h (saved_command_line): Remove declaration.
9887 * top.c (previous_saved_command_line, previous_repeat_arguments):
9889 (saved_command_line): Make static, define together with other
9891 (dont_repeat): Clear repeat_arguments.
9892 (repeat_previous, get_saved_command_line, save_command_line):
9894 (gdb_init): Initialize saved_command_line
9895 and previous_saved_command_line.
9896 * main.c (captured_main_1): Remove saved_command_line initialization.
9897 * event-top.c (handle_line_of_input): Update to use
9898 the new 'repeat' related functions instead of direct access to
9900 * command.h (repeat_previous, get_saved_command_line,
9901 save_command_line): New declarations.
9902 (dont_repeat): Add comment.
9904 2019-05-30 Tom Tromey <tromey@adacore.com>
9906 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9908 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9910 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9913 * completer.c (complete): Initialize variable word.
9915 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9917 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9918 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9919 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9920 'body' is NULL to the outter 'if', protecting the '!is_define'
9923 2019-05-29 Tom Tromey <tromey@adacore.com>
9925 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9926 (dwarf_unknown): New function.
9927 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9928 (dwarf_type_encoding_name): Use dwarf_unknown.
9930 2019-05-29 Tom Tromey <tromey@adacore.com>
9933 * cp-valprint.c (cp_print_value_fields): Call
9934 cp_print_static_field inside "try".
9936 2019-05-29 Tom Tromey <tromey@adacore.com>
9938 * inflow.c (struct terminal_info): Add default operator=.
9939 * configure: Rebuild.
9940 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9941 -Wdeprecated-copy-dtor, -Wredundant-move.
9943 2019-05-29 Tom Tromey <tromey@adacore.com>
9946 * infcmd.c (print_return_value_1): Handle finish_print
9948 (show_print_finish): New function.
9949 (_initialize_infcmd): Add "set/show print finish" commands.
9950 * valprint.c (user_print_options): Initialize new member.
9951 * valprint.h (struct value_print_options) <finish_print>: New
9954 2019-05-28 Tom Tromey <tromey@adacore.com>
9956 * ada-lang.c (ada_remove_Xbn_suffix)
9957 (find_old_style_renaming_symbol)
9958 (parse_old_style_renaming): Remove.
9959 (ada_find_renaming_symbol): Don't call
9960 find_old_style_renaming_symbol.
9961 (ada_is_renaming_symbol): Rename from
9962 ada_find_renaming_symbol. Remove "block" parameter. Return
9964 (ada_read_var_value): Update and simplify.
9965 * ada-exp.y (write_var_or_type): Remove old code.
9967 2019-05-28 Alan Hayward <alan.hayward@arm.com>
9970 * event-top.c: Remove include comment.
9971 * inflow.c (class scoped_ignore_sigttou): Move from here...
9972 * inflow.h (class scoped_ignore_sigttou): ...to here.
9973 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9974 * top.c: Remove include comment.
9976 2019-05-27 Tom Tromey <tom@tromey.com>
9980 2019-05-22 Tom Tromey <tromey@adacore.com>
9982 * target.c (target_follow_exec): Constify parameter.
9983 * target-delegates.c: Rebuild.
9984 * remote.c (remote_target::follow_exec): Constify parameter.
9985 * infrun.c (follow_exec): Constify parameter.
9986 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9987 (target_follow_exec): Likewise.
9989 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9991 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9992 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9994 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9996 * NEWS: Add debugredirect and testsuite sections.
9998 2019-05-22 Simon Cook <simon.cook@embecosm.com>
10000 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10001 target descriptions using exclusively floating point register name
10004 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10007 * f-lang.c (build_fortran_types): Handle the case where
10008 gdbarch_floatformat_for_type returns a nullptr.
10010 2019-05-21 Tom de Vries <tdevries@suse.de>
10013 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10015 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10018 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10020 * i386-tdep.c (i386_floatformat_for_type): Use
10021 floatformats_ia64_quad for the 16-byte floating point component
10022 within a fortran 32-byte complex number.
10024 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10026 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10027 delete default constructor.
10028 (find_partial_die): Update to return const struct.
10029 (partial_die_parent_scope): Move variable declaration into scope
10030 of its use and change its type to auto.
10031 (guess_partial_die_structure_name): Likewise.
10032 (partial_die_info::fixup): Likewise.
10034 2019-05-17 Tom Tromey <tromey@adacore.com>
10036 * source.c (find_and_open_source): Remove cast.
10038 2019-05-17 Tom Tromey <tromey@adacore.com>
10040 * annotate.c (annotate_source): Make "filename" const.
10041 * annotate.h (annotate_source): Use const.
10043 2019-05-17 Alan Hayward <alan.hayward@arm.com>
10045 * disasm.c (set_disassembler_options): Send errors to stderr.
10047 2019-05-17 Alan Hayward <alan.hayward@arm.com>
10049 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10050 (cli_interp_base::set_logging): Check debug_redirect.
10051 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10052 * cli/cli-logging.c (debug_redirect): Add static variable.
10053 (pop_output_files): Add default param.
10054 (handle_redirections): Print debug setting.
10055 (show_logging_command): Likewise.
10056 (_initialize_cli_logging): Add debugredirect command.
10057 * interps.c (current_interp_set_logging): Add debug_redirect
10059 * interps.h (set_logging): Add debug_redirect parameter.
10060 (current_interp_set_logging): Likewise.
10061 * mi/mi-common.h: Likewise.
10062 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10064 2019-05-17 Alan Hayward <alan.hayward@arm.com>
10065 Tom Tromey <tromey@adacore.com>
10067 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10069 * cli/cli-interp.h (make_logging_output): Remove declaration.
10070 * cli/cli-logging.c (make_logging_output): Remove function.
10071 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10073 * ui-file.c (tee_file::tee_file): Remove bools.
10074 (tee_file::~tee_file): Remove deletes.
10075 * ui-file.h (tee_file): Remove bools.
10077 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10079 * mi/mi-cmds.h (mi_cmd_complete): New function.
10080 * mi/mi-main.c (mi_cmd_complete): Likewise.
10081 * mi/mi-cmds.c: Define new MI command -complete.
10082 * NEWS: Mention new -complete command.
10084 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10086 * completer.h (complete): New function.
10087 * completer.c (complete): Likewise.
10088 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10089 function defined in completer.h.
10091 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10093 * MAINTAINERS (Write After Approval): Add myself.
10095 2019-05-17 Tom de Vries <tdevries@suse.de>
10098 * dwarf2read.c (struct cu_partial_die_info): New struct.
10099 (find_partial_die): Return cu_partial_die_info.
10100 (partial_die_parent_scope, guess_partial_die_structure_name)
10101 (partial_die_info::fixup): Handle new return type of find_partial_die.
10103 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10105 PR breakpoints/24541
10106 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10107 "std::string", simplifying the algorithm.
10109 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10111 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10112 (stap_static_probe_ops::get_probes): Likewise.
10114 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10116 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10117 '-')" and "else if".
10118 (stap_parse_single_operand): Join checks for
10119 "gdbarch_stap_parse_special_token_p" and
10120 "gdbarch_stap_parse_special_token" in the same "if" statement.
10121 Invert check when verifying for operation on register
10124 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10126 * stap-probe.c (stap_get_opcode): Update comment.
10127 (stap_get_expected_argument_type): Likewise.
10128 (handle_stap_probe): Likewise.
10130 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10132 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10133 return type to 'bool'. Adjust comment. Use 'bool' when
10135 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10136 * stap-probe.c (stap_parse_argument_1): Likewise.
10137 (stap_is_operator): Likewise.
10138 (stap_is_generic_prefix): Likewise.
10139 (stap_is_register_prefix): Likewise.
10140 (stap_is_register_indirection_prefix): Likewise.
10141 (stap_is_integer_prefix): Likewise.
10142 (stap_generic_check_suffix): Likewise.
10143 (stap_check_integer_suffix): Likewise.
10144 (stap_check_register_suffix): Likewise.
10145 (stap_check_register_indirection_suffix): Likewise.
10146 (stap_parse_register_operand): Likewise.
10147 (stap_parse_single_operand): Likewise.
10148 (stap_parse_argument_1): Likewise.
10149 (stap_probe::get_argument_count): Likewise.
10150 (stap_is_operator): Likewise.
10152 2019-05-16 Tom Tromey <tromey@adacore.com>
10154 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10155 keyword to foreach.
10157 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
10159 * linux-thread-db.c (try_thread_db_load_1): Change return type
10161 (try_thread_db_load): Likewise.
10162 (try_thread_db_load_from_pdir_1): Likewise.
10163 (try_thread_db_load_from_pdir): Likewise.
10164 (try_thread_db_load_from_sdir): Likewise.
10165 (try_thread_db_load_from_dir): Likewise.
10166 (thread_db_load_search): Likewise.
10167 (has_libpthread): Likewise.
10168 (thread_db_load): Likewise.
10170 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10172 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10173 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10174 NULL, and complain/return if that's the case.
10176 2019-05-15 John Darrington <john@darrington.wattle.id.au>
10178 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10179 (advance, posn, abstract_read_memory): New functions.
10180 [struct mem_read_abstraction]: New struct.
10181 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10183 2019-05-14 Tom Tromey <tromey@adacore.com>
10185 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10186 value is not lval_memory.
10188 2019-05-14 Tom Tromey <tromey@adacore.com>
10190 * solib.c (info_sharedlibrary_command): Style the file name.
10192 2019-05-14 Alan Hayward <alan.hayward@arm.com>
10194 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10195 (aarch64_vnv_type): Likewise.
10196 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10197 * common/tdesc.c: Likewise.
10198 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10199 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10200 * features/aarch64-fpu.xml: Add ieee half view.
10201 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10202 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10203 * gdbtypes.h (struct builtin_type): Likewise.
10204 (struct objfile_type): Likewise.
10206 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
10208 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10210 * location.h (string_to_event_location): Likewise.
10212 2019-05-11 Joel Brobecker <brobecker@adacore.com>
10216 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
10218 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10219 New variable declaration.
10220 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10222 (print_one_breakpoint): Use ui_out::test_flags and new global
10223 variable to compute use_fixed_output.
10224 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10226 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10227 (mi_multi_location_breakpoint_output_fixed): Remove.
10228 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10230 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10231 fix_multi_location_breakpoint_output flag if version >= 3.
10232 * ui-out.h (enum ui_out_flag)
10233 <fix_multi_location_breakpoint_output>: New enumerator.
10235 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
10237 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10239 2019-05-10 Tom Tromey <tromey@adacore.com>
10241 * ada-lang.c (catch_ada_completer): New function.
10242 (_initialize_ada_language): Use it.
10244 2019-05-10 Tom Tromey <tromey@adacore.com>
10246 * thread.c (print_thread_info): Make "requested_threads" const.
10247 * gdbthread.h (print_thread_info): Make "requested_threads"
10249 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10250 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10252 2019-05-08 Tom Tromey <tom@tromey.com>
10254 * gdbtypes.c (objfile_type_data): Change type.
10255 (objfile_type, _initialize_gdbtypes): Update.
10257 2019-05-08 Tom Tromey <tom@tromey.com>
10259 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10260 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10261 (_initialize_dwarf2_frame): Update.
10263 2019-05-08 Tom Tromey <tom@tromey.com>
10265 * objc-lang.c (objc_objfile_data): Change type.
10266 (find_methods): Update.
10267 (_initialize_objc_lang): Remove.
10269 2019-05-08 Tom Tromey <tom@tromey.com>
10271 * stabsread.c (rs6000_builtin_type_data): Change type.
10272 (rs6000_builtin_type, _initialize_stabsread): Update.
10274 2019-05-08 Tom Tromey <tom@tromey.com>
10276 * mips-tdep.c (mips_pdr_data): Remove.
10277 (_initialize_mips_tdep): Update.
10279 2019-05-08 Tom Tromey <tom@tromey.com>
10281 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10282 (hppa_init_objfile_priv_data, read_unwind_info)
10283 (find_unwind_entry, _initialize_hppa_tdep): Update.
10285 2019-05-08 Tom Tromey <tom@tromey.com>
10287 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10288 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10290 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10292 2019-05-08 Tom Tromey <tom@tromey.com>
10294 * mdebugread.c (basic_type_data): Change type.
10295 (basic_type, _initialize_mdebugread): Update.
10297 2019-05-08 Tom Tromey <tom@tromey.com>
10299 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10301 2019-05-08 Tom Tromey <tom@tromey.com>
10303 * nto-tdep.c (nto_inferior_data_reg): Change type.
10304 (nto_inferior_data): Update.
10305 (nto_inferior_data_cleanup, nto_new_inferior_data)
10306 (_initialize_nto_tdep): Remove.
10307 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10309 2019-05-08 Tom Tromey <tom@tromey.com>
10311 * ada-lang.c (struct ada_inferior_data): Add initializers.
10312 (ada_inferior_data): Change type.
10313 (ada_inferior_data_cleanup): Remove.
10314 (get_ada_inferior_data, ada_inferior_exit)
10315 (struct ada_pspace_data): Add initializers, destructor.
10316 (ada_pspace_data_handle): Change type.
10317 (get_ada_pspace_data): Update.
10318 (ada_pspace_data_cleanup): Remove.
10320 2019-05-08 Tom Tromey <tom@tromey.com>
10322 * coffread.c (struct coff_symfile_info): Add initializers.
10323 (coff_objfile_data_key): Move lower. Change type.
10324 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10326 (coff_free_info): Remove.
10328 2019-05-08 Tom Tromey <tom@tromey.com>
10330 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10331 (fbsd_pspace_data_handle): Move lower. Change type.
10332 (get_fbsd_pspace_data): Update.
10333 (fbsd_pspace_data_cleanup): Remove.
10334 (_initialize_fbsd_tdep): Update.
10336 2019-05-08 Tom Tromey <tom@tromey.com>
10338 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10339 (get_ada_tasks_pspace_data): Update.
10340 (ada_tasks_pspace_data_cleanup): Remove.
10341 (_initialize_tasks): Update.
10342 (ada_tasks_inferior_data_handle): Change type.
10343 (get_ada_tasks_inferior_data): Update.
10344 (ada_tasks_inferior_data_cleanup): Remove.
10345 (struct ada_tasks_pspace_data): Add initializers.
10347 2019-05-08 Tom Tromey <tom@tromey.com>
10349 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10350 * symfile-debug.c (debug_sym_get_probes): Change type.
10351 * stap-probe.c (handle_stap_probe):
10352 (stap_static_probe_ops::get_probes): Change type.
10353 * probe.h (class static_probe_ops) <get_probes>: Change type.
10354 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10355 (parse_probes_in_pspace): Update.
10356 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10358 (any_static_probe_ops::get_probes): Change type.
10359 * elfread.c (elfread_data): New typedef.
10360 (probe_key): Change type.
10361 (elf_get_probes): Likewise. Update.
10362 (probe_key_free): Remove.
10363 (_initialize_elfread): Update.
10364 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10366 (dtrace_process_dof_probe, dtrace_process_dof)
10367 (dtrace_static_probe_ops::get_probe): Change type.
10369 2019-05-08 Tom Tromey <tom@tromey.com>
10371 * xcoffread.c (struct xcoff_symfile_info): Rename from
10372 coff_symfile_info. Add initializers.
10373 (xcoff_objfile_data_key): Move lower. Change type.
10374 (XCOFF_DATA): Rewrite.
10375 (xcoff_free_info): Remove.
10376 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10377 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10378 (xcoff_initial_scan): Update.
10380 2019-05-08 Tom Tromey <tom@tromey.com>
10382 * solib-svr4.c (struct svr4_info): Add initializers and
10384 <probes_table>: Now an htab_up.
10385 (solib_svr4_pspace_data): Change type.
10386 (free_probes_table): Simplify.
10387 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10388 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10389 (probes_table_remove_objfile_probes, register_solib_event_probe)
10390 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10391 (_initialize_svr4_solib): Update.
10393 2019-05-08 Tom Tromey <tom@tromey.com>
10395 * remote.c (remote_pspace_data): Change type.
10396 (remote_pspace_data_cleanup): Remove.
10397 (get_remote_exec_file, set_pspace_remote_exec_file)
10398 (_initialize_remote): Update.
10400 2019-05-08 Tom Tromey <tom@tromey.com>
10402 * breakpoint.c (breakpoint_objfile_key): Change type.
10403 (get_breakpoint_objfile_data): Update.
10404 (free_breakpoint_objfile_data): Remove.
10405 (_initialize_breakpoint): Update.
10407 2019-05-08 Tom Tromey <tom@tromey.com>
10409 * linux-tdep.c (struct linux_info): Add initializers.
10410 (linux_inferior_data): Move. Change type.
10411 (invalidate_linux_cache_inf): Update.
10412 (linux_inferior_data_cleanup): Remove.
10413 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10415 2019-05-08 Tom Tromey <tom@tromey.com>
10417 * auxv.c (auxv_inferior_data): Move. Change type.
10418 (auxv_inferior_data_cleanup): Remove.
10419 (invalidate_auxv_cache_inf): Rewrite.
10420 (get_auxv_inferior_data, _initialize_auxv): Update.
10422 2019-05-08 Tom Tromey <tom@tromey.com>
10424 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10425 (symfile_debug_objfile_data_key): Change type.
10426 (symfile_debug_installed, debug_qf_has_symbols)
10427 (debug_qf_find_last_source_symtab)
10428 (debug_qf_forget_cached_source_info)
10429 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10430 (debug_qf_print_stats, debug_qf_dump)
10431 (debug_qf_expand_symtabs_for_function)
10432 (debug_qf_expand_all_symtabs)
10433 (debug_qf_expand_symtabs_with_fullname)
10434 (debug_qf_map_matching_symbols)
10435 (debug_qf_expand_symtabs_matching)
10436 (debug_qf_find_pc_sect_compunit_symtab)
10437 (debug_qf_map_symbol_filenames)
10438 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10439 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10440 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10441 (debug_sym_read_linetable, debug_sym_relocate): Update.
10442 (symfile_debug_free_objfile): Remove.
10443 (install_symfile_debug_logging, _initialize_symfile_debug):
10446 2019-05-08 Tom Tromey <tom@tromey.com>
10448 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10449 allocate_on_obstack.
10450 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10451 (get_dwarf2_per_objfile): Update.
10452 (set_dwarf2_per_objfile): Remove.
10453 (dwarf2_has_info, dwarf2_get_section_info): Update.
10454 (dwarf2_free_objfile): Remove.
10455 (_initialize_dwarf2_read): Update.
10457 2019-05-08 Tom Tromey <tom@tromey.com>
10459 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10461 <unsupported_script_warning_printed,
10462 script_not_found_warning_printed>: Now bool.
10463 (auto_load_pspace_data): Change type.
10464 (~auto_load_pspace_info): Rename from
10465 auto_load_pspace_data_cleanup.
10466 (get_auto_load_pspace_data, init_loaded_scripts_info)
10467 (clear_section_scripts, maybe_print_unsupported_script_warning)
10468 (maybe_print_script_not_found_warning, _initialize_auto_load):
10471 2019-05-08 Tom Tromey <tom@tromey.com>
10473 * objfiles.c (objfile_pspace_info): Add destructor and
10475 (objfiles_pspace_data): Change type.
10476 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10477 (get_objfile_pspace_data): Update.
10478 (objfiles_bfd_data): Change type.
10479 (get_objfile_bfd_data): Update.
10480 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10482 2019-05-08 Tom Tromey <tom@tromey.com>
10484 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10486 (get_catch_syscall_inferior_data): Update.
10487 (catch_syscall_inferior_data_cleanup): Remove.
10488 (_initialize_break_catch_syscall): Update.
10490 2019-05-08 Tom Tromey <tom@tromey.com>
10492 * inflow.c (struct terminal_info): Add destructor and
10494 (inflow_inferior_data): Change type.
10495 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10496 (get_inflow_inferior_data, inflow_inferior_exit)
10497 (swap_terminal_info, _initialize_inflow): Update.
10499 2019-05-08 Tom Tromey <tom@tromey.com>
10501 * target-dcache.c (target_dcache_cleanup): Remove.
10502 (target_dcache_aspace_key): Change type.
10503 (target_dcache_init_p, target_dcache_invalidate)
10504 (target_dcache_get, target_dcache_get_or_init)
10505 (_initialize_target_dcache): Update.
10506 * dcache.h (struct dcache_deleter): New.
10508 2019-05-08 Tom Tromey <tom@tromey.com>
10510 * symtab.c (struct symbol_cache): Add destructor and
10512 (symbol_cache_key): Move. Change type.
10513 (make_symbol_cache, free_symbol_cache): Remove.
10514 (get_symbol_cache): Update.
10515 (symbol_cache_cleanup): Remove.
10516 (ALL_PSPACES, symbol_cache_flush)
10517 (maintenance_print_symbol_cache)
10518 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10521 2019-05-08 Tom Tromey <tom@tromey.com>
10523 * symtab.c (struct main_info): Add destructor and initializers.
10524 (main_progspace_key): Move. Change type.
10525 (get_main_info): Update.
10526 (main_info_cleanup): Remove.
10527 (_initialize_symtab): Update.
10529 2019-05-08 Tom Tromey <tom@tromey.com>
10531 * registry.h (DECLARE_REGISTRY): Define the _key class.
10533 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10535 * NEWS: Merge two 'New commands' sections.
10537 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10539 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10540 parameter and use Ada language definition instead.
10541 (ada_val_print_ptr): Remove unused language parameter.
10542 (ada_val_print_num): Remove language parameter and use Ada language
10543 definition instead.
10544 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10546 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10547 parameter and use Ada language definition instead.
10548 (ada_val_print_1): Update all ada_val_print_xxx calls.
10549 Remove language parameter.
10550 (ada_val_print): Update ada_val_print_1 call.
10552 2019-05-08 Tom Tromey <tromey@adacore.com>
10554 * remote.c (remote_hw_watchpoint_limit)
10555 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10558 2019-05-08 Tom Tromey <tromey@adacore.com>
10560 * maint.c (_initialize_maint_cmds): Move initialization code to
10562 (watchdog, show_watchdog): Move to remote.c.
10563 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10565 (_initialize_remote): Move initialization code from maint.c.
10566 * defs.h (watchdog): Don't declare.
10568 2019-05-08 Tom Tromey <tromey@adacore.com>
10570 * tui/tui-interp.c: Include main.h.
10571 * interps.c: Include main.h.
10572 * main.h (interpreter_p): Declare.
10573 * defs.h (interpreter_p): Don't declare.
10575 2019-05-08 Tom Tromey <tromey@adacore.com>
10577 * dwarf2loc.c: Include dwarf2read.h.
10578 * defs.h (read_unsigned_leb128): Don't declare.
10579 * dwarf2read.h (read_unsigned_leb128): Declare.
10581 2019-05-08 Tom Tromey <tromey@adacore.com>
10583 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10586 2019-05-08 Tom Tromey <tromey@adacore.com>
10588 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10589 when no wrap column is set.
10591 2019-05-08 Tom Tromey <tromey@adacore.com>
10593 * c-lang.c (c_get_string): Handle non-C-style arrays.
10595 2019-05-08 Tom Tromey <tromey@adacore.com>
10597 * typeprint.c (print_offset_data::update): Print the bit offset,
10598 not the number of bits remaining.
10600 2019-05-08 Tom Tromey <tromey@adacore.com>
10602 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10603 padding at end of comment.
10605 2019-05-08 Tom Tromey <tromey@adacore.com>
10607 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10608 Compare main types.
10610 2019-05-06 Tom Tromey <tom@tromey.com>
10612 * common/scoped_mmap.c: Include common-defs.h.
10613 * common/scoped_mmap.h: Don't include config.h.
10615 2019-05-04 Tom Tromey <tom@tromey.com>
10617 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10618 (struct aarch64_call_info): Add initializers.
10619 <si>: Now a std::vector.
10620 (pass_on_stack, aarch64_push_dummy_call): Update.
10622 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10623 Tom Tromey <tom@tromey.com>
10625 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10626 (ppc_threads): Now a std::vector. Now static.
10627 (hwdebug_find_thread_points_by_tid)
10628 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10631 2019-05-04 Tom Tromey <tom@tromey.com>
10633 * arc-tdep.c (arc_tdesc_init): Return bool.
10635 2019-05-04 Tom Tromey <tom@tromey.com>
10637 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10638 Use gdb_assert_not_reached.
10640 2019-05-04 Tom Tromey <tom@tromey.com>
10642 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10645 2019-05-04 Tom Tromey <tom@tromey.com>
10647 * arc-tdep.c (arc_tdesc_init): Use bool.
10649 2019-05-04 Tom Tromey <tom@tromey.com>
10651 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10653 2019-05-04 Tom Tromey <tom@tromey.com>
10655 * cli/cli-cmds.c (valid_command_p): Return bool.
10657 2019-05-04 Tom Tromey <tom@tromey.com>
10659 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10660 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10662 2019-05-04 Raul Tambre <raul@tambre.ee>
10664 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10665 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10666 operator for comparison.
10668 2019-05-04 Tom Tromey <tom@tromey.com>
10670 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10671 (lookup_partial_symbol, print_partial_symbols)
10672 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10673 (psymbol_compare): Update.
10674 (add_psymbol_to_bcache): Clear the entire psymbol.
10675 (maintenance_check_psymtabs): Update.
10676 * psympriv.h (struct partial_symbol): Don't derive from
10677 general_symbol_info.
10678 <obj_section, unrelocated_address, address,
10679 set_unrelocated_address>: Update.
10680 <ginfo>: New member.
10681 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10682 (debug_names::write_psymbols): Update.
10684 2019-05-04 Tom de Vries <tdevries@suse.de>
10686 * contrib/cc-with-tweaks.sh: Support -n arg.
10688 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10690 * corelow.c (core_target::detach): Ensure frame cache and
10691 register caches are cleared.
10692 inferior.c (exit_inferior_1): Likewise.
10694 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10695 Tom Tromey <tom@tromey.com>
10697 * dictionary.c (collate_pending_symbols_by_language): Remove
10698 "struct" from foreach.
10699 * symtab.c (lookup_global_symbol_from_objfile)
10700 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10702 * ser-tcp.c (net_open): Remove "struct" from foreach.
10703 * objfiles.c (objfile_relocate, objfile_rebase)
10704 (objfile_has_symbols): Remove "struct" from foreach.
10705 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10707 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10709 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10710 "struct" from foreach.
10711 * ada-lang.c (create_excep_cond_exprs)
10712 (ada_exception_catchpoint_cond_string): Remove "struct" from
10715 2019-05-03 Tom Tromey <tromey@adacore.com>
10717 * ada-exp.y (convert_char_literal): Check suffix of each
10720 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10723 * ada-exp.y (yywrap): Don't define.
10724 * ada-lex.l (%option): Add noyywrap
10727 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10729 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10730 _WIN32_WINNT to the XP level, unless already defined to a higher
10733 * unittests/parse-connection-spec-selftests.c:
10735 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10738 * symfile.c (find_separate_debug_file): Remove colon from the
10739 drive spec of DOS/Windows file names of the target, so that the
10740 file name produced from DEBUGDIR and the target's directory will
10741 be valid on DOS/Windows systems.
10743 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10745 * rust-lang.c (val_print_struct): Handle printing structures
10746 containing strings.
10748 2019-05-02 Tom Tromey <tromey@adacore.com>
10750 * valarith.c (_initialize_valarith): Remove.
10752 2019-05-01 Tom Tromey <tromey@adacore.com>
10754 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10757 2019-05-01 Tom Tromey <tromey@adacore.com>
10759 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10760 for big-endian copies.
10762 2019-04-30 Ali Tamur <tamur@google.com>
10763 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10764 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10765 (read_3_bytes): New function.
10767 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10769 * windows-nat.c (main_thread_id): Delete.
10770 (handle_output_debug_string): Replace main_thread_id by
10771 current_event.dwThreadId.
10772 (fake_create_process): Likewise.
10773 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10774 Do not set main_thread_id.
10775 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10776 current_event.dwThreadId.
10777 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10779 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10781 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10782 Use current_event.dwThreadId instead of main_thread_id.
10784 2019-04-30 Tom Tromey <tromey@adacore.com>
10786 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10787 (create_excep_cond_exprs): Iterate over program spaces.
10788 (ada_exception_catchpoint_cond_string): Examine all minimal
10789 symbols for exception types.
10791 2019-04-30 Tom Tromey <tromey@adacore.com>
10794 * dwarf2read.c (process_structure_scope): Handle case where type
10795 has template parameters but no symbol was created.
10797 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10798 Chris January <chris.january@arm.com>
10800 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10802 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10804 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10806 * f-typeprint.c (f_print_type): Update rules for printing
10808 (f_type_print_varspec_suffix): Likewise.
10810 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10811 Chris January <chris.january@arm.com>
10813 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10814 function arguments.
10816 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10818 * f-lang.c (build_fortran_types): Change name of void type to
10820 * f-typeprint.c (f_type_print_base): Print the name of the void
10821 type, rather than a fixed string.
10822 * f-valprint.c (f_decorations): Use lower case void string.
10824 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10825 Chris January <chris.january@arm.com>
10827 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10830 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10831 Chris January <chris.january@arm.com>
10832 David Lecomber <david.lecomber@arm.com>
10834 * f-exp.y (BINOP_INTRINSIC): New token.
10835 (exp): New parser rule handling BINOP_INTRINSIC.
10836 (f77_keywords): Add new builtin procedures.
10837 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10838 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10839 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10840 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10841 (print_unop_subexp_f): New function.
10842 (print_binop_subexp_f): New function.
10843 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10844 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10845 (dump_subexp_body_f): Likewise.
10846 (operator_check_f): Likewise.
10847 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10848 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10850 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10852 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10854 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10855 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10856 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10857 (operator_length_f): New fuction.
10858 (print_subexp_f): New function.
10859 (op_name_f): New function.
10860 (dump_subexp_body_f): New function.
10861 (operator_check_f): New function.
10862 (exp_descriptor_f): Replace standard expression handling functions
10863 with new functions.
10864 * gdb/fortran-operator.def: New file.
10865 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10866 * gdb/std-operator.def: Remove UNOP_KIND.
10868 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10870 * std-operator.def: Remove unbalanced, stray double quote
10873 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10874 Chris January <chris.january@arm.com>
10875 Daniel Everett <daniel.everett@arm.com>
10876 Nick Forrington <nick.forrington@arm.com>
10877 Richard Bunt <richard.bunt@arm.com>
10879 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10880 of depth when printing anonymous structs or unions.
10881 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10882 Don't print either the top-level value, or the children if the
10883 max-depth is exceeded.
10884 (ppscm_print_children): When printing the key of a map, allow one
10885 extra level of depth.
10886 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10887 print either the top-level value, or the children if the max-depth
10889 (print_children): When printing the key of a map, allow one extra
10891 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10892 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10893 (user_print_options): Initialise max_depth field.
10894 (val_print_scalar_or_string_type_p): New function.
10895 (val_print): Check to see if the max depth has been reached.
10896 (val_print_check_max_depth): Define new function.
10897 (show_print_max_depth): New function.
10898 (_initialize_valprint): Add 'print max-depth' option.
10899 * valprint.h (struct value_print_options) <max_depth>: New field.
10900 (val_print_check_max_depth): Declare new function.
10901 * NEWS: Document new feature.
10903 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10905 * ada-lang.c (ada_language_defn): Initialise new field.
10906 * c-lang.c (c_is_string_type_p): New function.
10907 (c_language_defn): Initialise new field.
10908 (cplus_language_defn): Initialise new field.
10909 (asm_language_defn): Initialise new field.
10910 (minimal_language_defn): Initialise new field.
10911 * c-lang.h (c_is_string_type_p): Declare new function.
10912 * d-lang.c (d_language_defn): Initialise new field.
10913 * f-lang.c (f_is_string_type_p): New function.
10914 (f_language_defn): Initialise new field.
10915 * go-lang.c (go_is_string_type_p): New function.
10916 (go_language_defn): Initialise new field.
10917 * language.c (default_is_string_type_p): New function.
10918 (unknown_language_defn): Initialise new field.
10919 (auto_language_defn): Initialise new field.
10920 * language.h (struct language_defn) <la_is_string_type_p>: New
10922 (default_is_string_type_p): Declare new function.
10923 * m2-lang.c (m2_language_defn): Initialise new field.
10924 * objc-lang.c (objc_language_defn): Initialise new field.
10925 * opencl-lang.c (opencl_language_defn): Initialise new field.
10926 * p-lang.c (pascal_is_string_type_p): New function.
10927 (pascal_language_defn): Initialise new field.
10928 * rust-lang.c (rust_is_string_type_p): New function.
10929 (rust_language_defn): Initialise new field.
10931 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10933 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10935 * ada-lang.c (ada_language_defn): Initialise new field.
10936 * c-lang.c (c_language_defn): Likewise.
10937 (cplus_language_defn): Likewise.
10938 (asm_language_defn): Likewise.
10939 (minimal_language_defn): Likewise.
10940 * d-lang.c (d_language_defn): Likewise.
10941 * f-lang.c (f_language_defn): Likewise.
10942 * go-lang.c (go_language_defn): Likewise.
10943 * language.c (unknown_language_defn): Likewise.
10944 (auto_language_defn): Likewise.
10945 * m2-lang.c (m2_language_defn): Likewise.
10946 * objc-lang.c (objc_language_defn): Likewise.
10947 * opencl-lang.c (opencl_language_defn): Likewise.
10948 * p-lang.c (pascal_language_defn): Likewise.
10949 * rust-lang.c (rust_language_defn): Likewise.
10951 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10953 * ada-lang.c (ada_is_character_type): Change return type to bool.
10954 (ada_is_string_type): Likewise.
10955 * ada-lang.h (ada_is_character_type): Update declaration
10956 (ada_is_string_type): Likewise.
10958 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10960 Support style in 'frame|thread apply'
10962 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10963 * record.c (record_start, record_stop): Update callers of
10964 execute_command_to_string with false.
10965 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10966 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10968 (class string_file): New constructor with term_out parameter.
10969 Override methods term_out and can_emit_style_escape. New member
10971 (class stdio_file): Override can_emit_style_escape.
10972 (class tee_file): Override term_out and can_emit_style_escape.
10973 * utils.h (can_emit_style_escape): Remove.
10974 * utils.c (can_emit_style_escape): Likewise.
10975 Update all callers of can_emit_style_escape (SOMESTREAM) to
10976 SOMESTREAM->can_emit_style_escape.
10977 * source-cache.c (source_cache::get_source_lines): Likewise.
10978 * stack.c (frame_apply_command_count): Call execute_command_to_string
10979 passing the term_out characteristic of the current gdb_stdout.
10980 * thread.c (thr_try_catch_cmd): Likewise.
10981 * top.c (execute_command_to_string): pass term_out parameter
10982 to construct the string_file for the command output.
10983 * ui-file.c (term_cli_styling): New function (most code moved
10984 from utils.c can_emit_style_escape).
10985 (string_file::string_file, string_file::can_emit_style_escape,
10986 stdio_file::can_emit_style_escape, tee_file::term_out,
10987 tee_file::can_emit_style_escape): New functions.
10989 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10991 * NEWS: Mention the new set|show may-call-functions.
10992 * infcall.c (may_call_functions_p): New variable.
10993 (show_may_call_functions_p): New function.
10994 (call_function_by_hand_dummy): Throws an error if not
10995 may-call-functions.
10996 (_initialize_infcall): Call add_setshow_boolean_cmd for
10997 may-call-functions.
10999 2019-04-25 Keith Seitz <keiths@redhat.com>
11002 * cp-support.c (inspect_type): Don't attempt substitutions
11003 of symbol with the same name.
11005 2019-04-25 Tom Tromey <tromey@adacore.com>
11008 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11011 2019-04-25 Tom Tromey <tromey@adacore.com>
11013 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11015 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11016 (gdb_xml_parser::parse): Use std::move.
11017 * python/python-internal.h (gdbpy_convert_exception): Take a const
11019 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11021 * python/py-utils.c (gdbpy_convert_exception): Take a const
11023 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11025 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11027 * mi/mi-main.c (mi_print_exception): Take a const reference.
11028 * main.c (handle_command_errors): Take a const reference.
11029 * linespec.c (parse_linespec): Use std::move.
11030 * infcall.c (run_inferior_call): Use std::move.
11031 (call_function_by_hand_dummy): Use std::move.
11032 * exec.c (try_open_exec_file): Use std::move.
11033 * exceptions.h (exception_print, exception_fprintf)
11034 (exception_print_same): Update.
11035 * exceptions.c (print_exception, exception_print)
11036 (exception_fprintf, exception_print_same): Change parameters to
11038 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11039 * common/new-op.c: Use std::move.
11040 * common/common-exceptions.h (struct gdb_exception): Add move
11042 (struct gdb_exception_error, struct gdb_exception_quit, struct
11043 gdb_quit_bad_alloc): Change constructor to move constructor.
11044 (throw_exception): Change parameter to rvalue reference.
11045 * common/common-exceptions.c (throw_exception): Take rvalue
11047 * cli/cli-interp.c (safe_execute_command): Use std::move.
11048 * breakpoint.c (insert_bp_location, location_to_sals): Use
11051 2019-04-25 Tom Tromey <tromey@adacore.com>
11053 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11054 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11055 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11056 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11057 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11058 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11059 guile/scm-value.c: Use unpack.
11060 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11061 gdbscm_gdb_exception.
11062 (gdbscm_throw_gdb_exception): Likewise.
11063 (struct gdbscm_gdb_exception): New.
11064 (unpack): New function.
11065 (gdbscm_wrap): Use unpack.
11067 2019-04-25 Tom Tromey <tromey@adacore.com>
11069 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11070 (gdb_rl_callback_handler): Use std::move.
11071 * common/common-exceptions.h (struct gdb_exception): Add move
11072 assignment operator.
11073 (throw_exception_sjlj): Change "exception" to const reference.
11074 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11075 (throw_exception_sjlj): Change "exception" to const reference.
11077 2019-04-25 Tom Tromey <tromey@adacore.com>
11079 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11080 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11081 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11083 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11085 * mi/mi-interp.c (mi_interp::exec): Update.
11086 * linespec.c (parse_linespec): Update.
11087 * infcall.c (run_inferior_call): Update.
11088 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11089 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11090 (gdbscm_lookup_global_symbol): Update.
11091 * guile/scm-param.c (gdbscm_parameter_value): Update.
11092 * guile/scm-frame.c (gdbscm_frame_read_register)
11093 (gdbscm_frame_read_var): Update.
11094 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11095 * exec.c (try_open_exec_file): Update.
11096 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11097 (gdb_rl_callback_handler): Update.
11098 * common/common-exceptions.h (exception_none): Don't declare.
11099 * common/common-exceptions.c (exception_none): Don't define.
11100 (struct catcher) <exception>: Update.
11101 * cli/cli-interp.c (safe_execute_command): Update.
11102 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11104 2019-04-25 Ali Tamur <tamur@google.com>
11106 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11107 (read_attribute_value): Likewise.
11108 (dwarf2_read_addr_index): Update comment.
11109 (read_str_index): Add DW_FORM_strx.
11110 (dwarf2_string_attr): Likewise.
11111 (dwarf2_const_value_attr): Likewise.
11112 (dump_die_shallow): Likewise.
11113 (dwarf2_fetch_constant_bytes): Likewise.
11114 (skip_form_bytes): Likewise.
11115 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11117 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11121 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11122 OFFSET. Verify if current mapping contains an ELF header.
11123 (linux_find_memory_regions_full): Adjust call to
11126 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11127 Kang Li <kanglictf@gmail.com>
11131 * dwarf2-frame.c (read_initial_length): Be consistent about using
11132 unsigned representation of length.
11133 (decode_frame_entry_1): Likewise. Check for wraparound of
11134 end pointer as well as buffer overflow.
11136 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11138 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11141 2019-04-24 Tom Tromey <tromey@adacore.com>
11143 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11145 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11147 * s12z-tdep.c (s12z_unwind_pc): Delete.
11148 (s12z_unwind_sp): Delete.
11149 (s12z_gdbarch_init): Don't register deleted functions with
11152 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11154 * rl78-tdep.c (rl78_unwind_sp): Delete.
11155 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11157 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11159 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11160 (xstormy16_unwind_pc): Delete.
11161 (xstormy16_dummy_id): Delete.
11162 (xstormy16_gdbarch_init): Don't register deleted functions with
11165 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11167 * vax-tdep.c (vax_unwind_pc): Delete.
11168 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11170 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11172 * v850-tdep.c (v850_unwind_sp): Delete.
11173 (v850_unwind_pc): Delete.
11174 (v850_dummy_id): Delete.
11175 (v850_gdbarch_init): Don't register deleted functions with
11178 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11180 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11181 (tilegx_unwind_pc): Delete.
11182 (tilegx_unwind_dummy_id): Delete.
11183 (tilegx_gdbarch_init): Don't register deleted functions with
11186 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11188 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11189 (tic6x_dummy_id): Delete.
11190 (tic6x_gdbarch_init): Don't register deleted functions with
11193 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11195 * sparc-tdep.c (sparc_unwind_pc): Delete.
11196 (sparc32_gdbarch_init): Don't register deleted function with
11199 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11201 * sh-tdep.c (sh_unwind_sp): Delete.
11202 (sh_unwind_pc): Delete.
11203 (sh_dummy_id): Delete.
11204 (sh_gdbarch_init): Don't register deleted functions with
11207 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11209 * score-tdep.c (score_unwind_sp): Delete.
11210 (score_unwind_pc): Delete.
11211 (score_dummy_id): Delete.
11212 (score_gdbarch_init): Don't register deleted functions with
11215 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11217 * rx-tdep.c (rx_unwind_pc): Delete.
11218 (rx_unwind_sp): Delete.
11219 (rx_dummy_id): Delete.
11220 (rx_gdbarch_init): Don't register deleted functions with
11221 gdbarch. Update comment.
11223 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11225 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11226 (rs6000_dummy_id): Delete.
11227 (rs6000_gdbarch_init): Don't register deleted functions with
11230 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11232 * or1k-tdep.c (or1k_dummy_id): Delete.
11233 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11235 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11237 * nios2-tdep.c (nios2_dummy_id): Delete.
11238 (nios2_unwind_sp): Delete.
11239 (nios2_gdbarch_init): Don't register deleted functions with
11242 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11244 * nds32-tdep.c (nds32_dummy_id): Delete.
11245 (nds32_unwind_pc): Delete.
11246 (nds32_unwind_sp): Delete.
11247 (nds32_gdbarch_init): Don't register deleted functions with
11250 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11252 * msp430-tdep.c (msp430_unwind_pc): Delete.
11253 (msp430_unwind_sp): Delete.
11254 (msp430_dummy_id): Delete.
11255 (msp430_gdbarch_init): Don't register deleted functions with
11258 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11260 * moxie-tdep.c (moxie_unwind_sp): Delete.
11261 (moxie_unwind_pc): Delete.
11262 (moxie_dummy_id): Delete.
11263 (moxie_gdbarch_init): Don't register deleted functions with
11266 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11268 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11269 (mn10300_unwind_pc): Delete.
11270 (mn10300_unwind_sp): Delete.
11271 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11273 (mn10300_frame_unwind_init): Don't register deleted functions with
11276 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11278 * mep-tdep.c (mep_unwind_pc): Delete.
11279 (mep_unwind_sp): Delete.
11280 (mep_dummy_id): Delete.
11281 (mep_gdbarch_init): Don't register deleted functions with
11284 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11286 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11287 (m68hc11_unwind_sp): Delete.
11288 (m68hc11_gdbarch_init): Don't register deleted functions with
11291 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11293 * m32r-tdep.c (m32r_unwind_sp): Delete.
11294 (m32r_unwind_pc): Delete.
11295 (m32r_dummy_id): Delete.
11296 (m32r_gdbarch_init): Don't register deleted functions with
11299 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11301 * m32c-tdep.c (m32c_unwind_pc): Delete.
11302 (m32c_unwind_sp): Delete.
11303 (m32c_dummy_id): Delete.
11304 (m32c_gdbarch_init): Don't register deleted functions with
11307 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11309 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11310 (lm32_unwind_pc): Delete.
11311 (lm32_dummy_id): Delete.
11312 (lm32_gdbarch_init): Don't register deleted functions with
11315 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11317 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11318 (iq2000_unwind_pc): Delete.
11319 (iq2000_dummy_id): Delete.
11320 (iq2000_gdbarch_init): Don't register deleted functions with
11323 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11325 * nds32-tdep.c (nds32_type_align): Delete.
11326 (nds32_push_dummy_call): Use type_align instead.
11328 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11330 * arm-tdep.c (arm_type_align): Only handle vector override case.
11331 (arm_push_dummy_call): Use type_align.
11332 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11334 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11336 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11338 (pass_on_stack): Use type_align.
11339 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11342 2019-04-23 Tom Tromey <tromey@adacore.com>
11344 * dwarf2read.c (line_header::file_name_at): Remove unused
11347 2019-04-23 Tom de Vries <tdevries@suse.de>
11350 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11354 2019-03-27 Ali Tamur <tamur@google.com>
11356 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11357 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11358 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11359 (dwarf_expr_context::get_addr_index): Likewise
11360 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11361 (symbol_needs_eval_context::get_addr_index): Likewise
11362 (disassemble_dwarf_expression): Add DW_OP_addrx
11363 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11364 (read_cutu_die_from_dwo): Update comment
11365 (skip_one_die): Add DW_FORM_addrx
11366 (read_attribute_value): Likewise
11367 (var_decode_location): Add DW_OP_addrx
11368 (dwarf2_const_value_attr): Add DW_FORM_addrx
11369 (dump_die_shallow): Likewise
11370 (dwarf2_fetch_constant_bytes): Likewise
11371 (decode_locdesc): Add DW_OP_addrx
11372 (skip_form_bytes): Add DW_FORM_addrx
11374 2019-04-22 Ali Tamur <tamur@google.com>
11376 * MAINTAINERS (Write After Approval): Add self.
11378 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
11380 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11381 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11382 (open_symbol_file_object): Likewise.
11383 (svr4_default_sos): Add info parameter.
11384 (svr4_read_so_list): Likewise.
11385 (svr4_current_sos_direct): Adjust functions calls to pass down
11387 (svr4_current_sos_1): Add info parameter.
11388 (svr4_current_sos): Call get_svr4_info, pass info down to
11389 svr4_current_sos_1.
11390 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11392 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11394 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11396 (probes_table_remove_objfile_probes): Likewise.
11397 (register_solib_event_probe): Add info parameter.
11398 (solist_update_incremental): Pass info parameter down to
11400 (disable_probes_interface): Add info parameter.
11401 (svr4_handle_solib_event): Pass current_program_space to
11402 get_svr4_info. Adjust disable_probes_interface cleanup.
11403 (svr4_create_probe_breakpoints): Add info parameter, pass it
11404 down to register_solib_event_probe.
11405 (svr4_create_solib_event_breakpoints): Add info parameter,
11406 pass it down to svr4_create_probe_breakpoints.
11407 (enable_break): Pass info down to
11408 svr4_create_solib_event_breakpoints.
11409 (svr4_solib_create_inferior_hook): Pass current_program_space to
11411 (svr4_clear_solib): Likewise.
11413 2019-04-22 Pedro Alves <palves@redhat.com>
11415 * solib-svr4.c (svr4_free_objfile_observer): New.
11416 (probe_and_action::objfile): New field.
11417 (probes_table_htab_remove_objfile_probes)
11418 (probes_table_remove_objfile_probes): New functions.
11419 (register_solib_event_probe): Add 'objfile' parameter. Store it
11420 in the new probe_and_action. Don't store the probe in 'lookup'.
11421 (svr4_create_probe_breakpoints): Pass objfile to
11422 register_solib_event_probe.
11423 (_initialize_svr4_solib): Register a free_objfile observer.
11425 2019-04-19 Tom Tromey <tom@tromey.com>
11427 * common/queue.h: Remove.
11429 2019-04-19 Tom Tromey <tom@tromey.com>
11431 * event-loop.c: Don't include "common/queue.h".
11433 2019-04-19 Tom Tromey <tom@tromey.com>
11435 * remote.c (remote_target): Use delete.
11436 * remote-notif.h: Include <list>, not "common/queue.h".
11437 (notif_client_p): Remove typedef.
11438 (remote_notif_state): Add constructor, destructor, initializer.
11439 <notif_queue>: Now a std::list.
11440 (remote_notif_state_xfree): Don't declare.
11441 * remote-notif.c (remote_notif_process, handle_notification)
11442 (remote_notif_state_allocate): Update.
11443 (~remote_notif_state): Rename from remote_notif_state_xfree.
11445 2019-04-19 Tom Tromey <tom@tromey.com>
11447 * symfile.c (reread_symbols): Update.
11448 * objfiles.c (objfile_register_static_link)
11449 (objfile_lookup_static_link): Update
11450 (~objfile) Don't delete static_links.
11451 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11453 2019-04-19 Tom Tromey <tom@tromey.com>
11455 * type-stack.h (struct type_stack) <insert>: Constify string.
11456 * type-stack.c (type_stack::insert): Constify string.
11457 * gdbtypes.h (lookup_template_type): Update.
11458 (address_space_name_to_int): Update.
11459 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11461 (lookup_template_type): Make name const.
11462 * c-exp.y: Update rules.
11463 (lex_one_token, classify_name, classify_inner_name)
11464 (c_print_token): Update.
11465 * p-exp.y: Update rules.
11467 * f-exp.y: Update rules.
11469 * d-exp.y: Update rules.
11470 (lex_one_token, classify_name, classify_inner_name): Update.
11471 * parse.c (write_dollar_variable, copy_name): Return std::string.
11472 * parser-defs.h (copy_name): Change return type.
11473 * m2-exp.y: Update rules.
11475 * go-exp.y (lex_one_token): Update.
11477 (classify_unsafe_function, classify_packaged_name)
11478 (classify_name, yylex): Update.
11480 2019-04-19 Sergei Trofimovich <siarheit@google.com>
11482 * configure.ac: add --enable-source-highlight switch.
11483 * configure: Regenerate.
11484 * top.c (print_gdb_version): plumb --enable-source-highlight
11485 status to "show configuration".
11487 2019-04-19 Tom Tromey <tromey@adacore.com>
11489 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11491 (empty_record, ada_template_to_fixed_record_type_1)
11492 (template_to_static_fixed_type)
11493 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11494 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11495 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11498 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11501 * source.c (print_source_lines_base): Advance "iter" when a
11502 control character is seen.
11504 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11506 * inferior.h (struct infcall_suspend_state_deleter):
11507 Catch exception in destructor to avoid crash.
11509 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11511 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11512 close to the add_com "shell".
11514 2019-04-18 Tom Tromey <tromey@adacore.com>
11516 * process-stratum-target.h (class process_stratum_target)
11517 <stratum>: Add "final".
11519 2019-04-17 Tom Tromey <tromey@adacore.com>
11521 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11522 against nullptr before use.
11524 2019-04-17 Alan Hayward <alan.hayward@arm.com>
11526 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11528 2019-04-17 Jim Wilson <jimw@sifive.com>
11529 Andrew Burgess <andrew.burgess@embecosm.com>
11531 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11532 code read might fail, assume 4-byte breakpoint in that case.
11534 2019-04-15 Leszek Swirski <leszeks@google.com>
11536 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11537 rather than a hand-rolled POD check when checking for forced MEMORY
11540 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11542 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11543 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11545 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11546 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11547 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11550 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11552 * aarch64-linux-nat.c
11553 (aarch64_linux_nat_target::thread_architecture): Add override.
11554 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11557 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11559 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11561 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11563 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11564 target types of size 96-bits, add some additional comments, and
11565 check that the builtin type we found was the correct size.
11567 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11569 * utils.c (prompt_for_continue): Don't restore the styling at the
11570 end, as applied_style has the wrong value. This fixes styling in
11571 long lists of file names that are interrupted by the "Continue?"
11574 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11576 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11577 * c-lang.c (c_language_defn): Likewise.
11578 (cplus_language_defn): Likewise.
11579 (asm_language_defn): Likewise.
11580 (minimal_language_defn): Likewise.
11581 * d-lang.c (d_language_defn): Likewise.
11582 * f-lang.c (f_language_defn): Likewise.
11583 * go-lang.c (go_language_defn): Likewise.
11584 * language.c (unknown_language_defn): Likewise.
11585 (auto_language_defn): Likewise.
11586 * language.h (struct language_defn): Remove la_magic field.
11587 (LANG_MAGIC): Delete.
11588 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11589 * objc-lang.c (objc_language_defn): Likewise.
11590 * opencl-lang.c (opencl_language_defn): Likewise.
11591 * p-lang.c (pascal_language_defn): Likewise.
11592 * rust-lang.c (rust_language_defn): Likewise.
11594 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11596 * riscv-tdep.c (riscv_type_align): New function.
11597 (riscv_type_alignment): Delete.
11598 (riscv_arg_location): Use 'type_align'.
11599 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11601 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11603 * gdbtypes.c (type_align): A struct with no non-static fields also
11604 has alignment of 1.
11606 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11608 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11610 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11612 (riscv_struct_info::analyse): New implementation using new
11613 analyse_inner member function.
11614 (riscv_struct_info::field_offset): New member function.
11615 (riscv_struct_info::m_offsets): New member variable.
11616 (riscv_struct_info::analyse_inner): New private member function,
11617 takes the old implementation of riscv_struct_info::analyse but
11618 extended to track field offsets.
11619 (riscv_call_arg_struct): Update the struct folding special cases
11620 to handle cases where empty C++ structs, which are non-zero
11622 (riscv_arg_location): Initialise the length of each location, a
11623 non-zero length now indicates the location is in use.
11624 (riscv_push_dummy_call): Allow for the first location having a
11625 non-zero offset when setting up arguments.
11626 (riscv_return_value): Likewise, but for return values.
11628 2019-04-11 Tom Tromey <tromey@adacore.com>
11630 * utils.c (internal_vproblem): Make "msg" const.
11632 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11634 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11635 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11636 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11637 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11639 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11641 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11643 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11644 of amd64_collect_native_gregset.
11645 (amd64_linux_nat_target::store_registers): Likewise.
11647 2019-04-10 Tom Tromey <tom@tromey.com>
11649 * symtab.c (lookup_global_symbol_from_objfile)
11650 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11651 * objfiles.h (class separate_debug_iterator): New.
11652 (class separate_debug_range): New.
11653 (struct objfile) <separate_debug_objfiles>: New method.
11654 (objfile_separate_debug_iterate): Don't declare.
11655 * objfiles.c (separate_debug_iterator::operator++): Rename from
11656 objfile_separate_debug_iterate.
11657 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11659 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11662 2019-04-10 Tom Tromey <tom@tromey.com>
11664 * symfile.c (reread_symbols): Remove old comment.
11665 * objfiles.c (free_all_objfiles): Fix a typo.
11667 2019-04-10 Tom Tromey <tom@tromey.com>
11669 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11670 * minsyms.c (lookup_minimal_symbol): Use foreach.
11671 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11672 (lookup_minimal_symbol_solib_trampoline): Likewise.
11673 * symfile.c (reread_symbols): Use foreach.
11675 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11676 Tom Tromey <tromey@adacore.com>
11679 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11680 (rust_lex_int_test): Change "value" to be LONGEST.
11681 (rust_lex_tests): Add test for long integer literal.
11683 2019-04-09 Tom Tromey <tromey@adacore.com>
11685 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11687 (extended_remote_target::attach): Update.
11688 (remote_target::remote_notice_new_inferior): Update.
11689 (remote_target::add_current_inferior_and_thread): Update.
11690 * inferior.c (exit_inferior_1): Use "false".
11691 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11693 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
11695 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11696 the "start" command.
11698 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11700 * python/py-inferior.c (infpy_thread_from_thread_handle):
11701 Adjust comments to reflect renaming of thread_from_thread_handle
11702 to thread_from_handle. Adjust keywords. Fix type error message.
11703 (inferior_object_methods): Add thread_from_handle. Retain
11704 thread_from_thread_handle, but mark it as deprecated.
11706 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11708 * gdbthread.h (find_thread_by_handle): Revise declaration.
11709 * thread.c (find_thread_by_handle): Likewise. Adjust
11710 implementation too.
11711 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11712 support for buffer objects as handles.
11714 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11716 * python/py-infthread.c (thpy_thread_handle): New function.
11717 (thread_object_methods): Register thpy_thread_handle.
11719 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11721 * gdbthread.h (thread_to_thread_handle): Declare.
11722 * thread.c (gdbtypes.h): Include.
11723 (thread_to_thread_handle): New function.
11725 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11726 (target_thread_info_to_thread_handle): Declare.
11727 * target.c (target_thread_info_to_thread_handle): New function.
11728 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11729 * target-delegates.c: Regenerate.
11731 * linux-thread-db.c (class thread_db_target): Add method
11732 thread_info_to_thread_handle.
11733 (thread_db_target::thread_info_to_thread_handle): Define.
11734 * remote.c (class remote_target): Add new method
11735 thread_info_to_thread_handle.
11736 (remote_target::thread_info_to_thread_handle): Define.
11738 2019-04-08 Pedro Alves <palves@redhat.com>
11740 * common/common-exceptions.c (throw_exception): Don't create
11741 named object to throw; throw directly.
11742 (throw_it): Likewise. Don't initialize gdb_exception::message
11743 here, with new; pass FMT and AP to the ctor instead.
11744 * common/common-exceptions.h: Include <string>.
11745 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11746 const char *, va_list)): New ctor. Use std::make_shared.
11747 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11749 (gdb_exception_error::gdb_exception_error(enum errors, const char
11751 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11753 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11755 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11756 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11759 2019-04-08 Tom Tromey <tom@tromey.com>
11761 * valops.c (value_rtti_indirect_type): Replace throw_exception
11763 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11765 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11767 * target.c (target_translate_tls_address): Replace throw_exception
11769 * stack.c (frame_apply_command_count): Replace throw_exception
11771 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11773 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11775 * rs6000-tdep.c (rs6000_frame_cache)
11776 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11777 * remote.c: Replace throw_exception with throw.
11778 * record-full.c (record_full_message, record_full_wait_1)
11779 (record_full_restore): Replace throw_exception with throw.
11781 (get_thread_current_frame_id, record_btrace_start_replaying)
11782 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11783 (cmd_record_btrace_start): Replace throw_exception with throw.
11784 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11786 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11787 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11789 (find_linespec_symbols): Replace throw_exception with throw.
11790 * infrun.c (displaced_step_prepare, resume): Replace
11791 throw_exception with throw.
11792 * infcmd.c (post_create_inferior): Replace throw_exception with
11794 * inf-loop.c (inferior_event_handler): Replace throw_exception
11796 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11797 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11798 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11799 (get_prev_frame_always, get_frame_pc_if_available)
11800 (get_frame_address_in_block_if_available, get_frame_language):
11801 Replace throw_exception with throw.
11802 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11803 throw_exception with throw.
11804 * eval.c (fetch_subexp_value, evaluate_var_value)
11805 (evaluate_funcall, evaluate_subexp_standard): Replace
11806 throw_exception with throw.
11807 * dwarf2loc.c (call_site_find_chain)
11808 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11809 Replace throw_exception with throw.
11810 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11812 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11814 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11815 * completer.c (complete_line_internal): Replace throw_exception
11817 * compile/compile-object-run.c (compile_object_run): Replace
11818 throw_exception with throw.
11819 * cli/cli-script.c (process_next_line): Replace throw_exception
11821 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11822 (btrace_enable, btrace_maint_update_pt_packets): Replace
11823 throw_exception with throw.
11824 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11825 throw_exception with throw.
11826 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11827 throw_exception with throw.
11828 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11829 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11830 * aarch64-tdep.c (aarch64_make_prologue_cache)
11831 (aarch64_make_stub_cache): Replace throw_exception with throw.
11833 2019-04-08 Tom Tromey <tom@tromey.com>
11835 * common/common-exceptions.c (throw_exception): Rename from
11836 throw_exception_cxx. Remove old copy. Make argument const.
11837 (throw_it): Create and throw exception objects directly.
11838 * common/common-exceptions.h (throw_exception): Make argument
11840 (struct gdb_exception_error): Add constructor.
11841 (struct gdb_exception_quit): Add constructor.
11843 2019-04-08 Tom Tromey <tom@tromey.com>
11845 * common/common-exceptions.h (exception_rethrow): Don't declare.
11846 (TRY_SJLJ): Update comment.
11847 (TRY, CATCH, END_CATCH): Remove.
11848 * common/common-exceptions.c (exception_rethrow): Remove.
11850 2019-04-08 Tom Tromey <tom@tromey.com>
11852 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11854 (gdb_exception_error): Rename from
11855 gdb_exception_RETURN_MASK_ERROR.
11856 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11857 (gdb_quit_bad_alloc): Update.
11858 * aarch64-tdep.c: Update.
11859 * ada-lang.c: Update.
11860 * ada-typeprint.c: Update.
11861 * ada-valprint.c: Update.
11862 * amd64-tdep.c: Update.
11863 * arch-utils.c: Update.
11864 * break-catch-throw.c: Update.
11865 * breakpoint.c: Update.
11866 * btrace.c: Update.
11867 * c-varobj.c: Update.
11868 * cli/cli-cmds.c: Update.
11869 * cli/cli-interp.c: Update.
11870 * cli/cli-script.c: Update.
11871 * common/common-exceptions.c: Update.
11872 * common/new-op.c: Update.
11873 * common/selftest.c: Update.
11874 * compile/compile-c-symbols.c: Update.
11875 * compile/compile-cplus-symbols.c: Update.
11876 * compile/compile-object-load.c: Update.
11877 * compile/compile-object-run.c: Update.
11878 * completer.c: Update.
11879 * corelow.c: Update.
11880 * cp-abi.c: Update.
11881 * cp-support.c: Update.
11882 * cp-valprint.c: Update.
11883 * darwin-nat.c: Update.
11884 * disasm-selftests.c: Update.
11885 * dtrace-probe.c: Update.
11886 * dwarf-index-cache.c: Update.
11887 * dwarf-index-write.c: Update.
11888 * dwarf2-frame-tailcall.c: Update.
11889 * dwarf2-frame.c: Update.
11890 * dwarf2loc.c: Update.
11891 * dwarf2read.c: Update.
11893 * event-loop.c: Update.
11894 * event-top.c: Update.
11896 * f-valprint.c: Update.
11897 * fbsd-tdep.c: Update.
11898 * frame-unwind.c: Update.
11900 * gdbtypes.c: Update.
11901 * gnu-v3-abi.c: Update.
11902 * guile/guile-internal.h: Update.
11903 * guile/scm-block.c: Update.
11904 * guile/scm-breakpoint.c: Update.
11905 * guile/scm-cmd.c: Update.
11906 * guile/scm-disasm.c: Update.
11907 * guile/scm-frame.c: Update.
11908 * guile/scm-lazy-string.c: Update.
11909 * guile/scm-math.c: Update.
11910 * guile/scm-param.c: Update.
11911 * guile/scm-ports.c: Update.
11912 * guile/scm-pretty-print.c: Update.
11913 * guile/scm-symbol.c: Update.
11914 * guile/scm-symtab.c: Update.
11915 * guile/scm-type.c: Update.
11916 * guile/scm-value.c: Update.
11917 * i386-linux-tdep.c: Update.
11918 * i386-tdep.c: Update.
11919 * inf-loop.c: Update.
11920 * infcall.c: Update.
11921 * infcmd.c: Update.
11922 * infrun.c: Update.
11924 * language.c: Update.
11925 * linespec.c: Update.
11926 * linux-fork.c: Update.
11927 * linux-nat.c: Update.
11928 * linux-tdep.c: Update.
11929 * linux-thread-db.c: Update.
11931 * mi/mi-cmd-break.c: Update.
11932 * mi/mi-cmd-stack.c: Update.
11933 * mi/mi-interp.c: Update.
11934 * mi/mi-main.c: Update.
11935 * objc-lang.c: Update.
11936 * p-valprint.c: Update.
11938 * ppc-linux-tdep.c: Update.
11939 * printcmd.c: Update.
11940 * python/py-arch.c: Update.
11941 * python/py-breakpoint.c: Update.
11942 * python/py-cmd.c: Update.
11943 * python/py-finishbreakpoint.c: Update.
11944 * python/py-frame.c: Update.
11945 * python/py-framefilter.c: Update.
11946 * python/py-gdb-readline.c: Update.
11947 * python/py-inferior.c: Update.
11948 * python/py-infthread.c: Update.
11949 * python/py-lazy-string.c: Update.
11950 * python/py-linetable.c: Update.
11951 * python/py-objfile.c: Update.
11952 * python/py-param.c: Update.
11953 * python/py-prettyprint.c: Update.
11954 * python/py-progspace.c: Update.
11955 * python/py-record-btrace.c: Update.
11956 * python/py-record.c: Update.
11957 * python/py-symbol.c: Update.
11958 * python/py-type.c: Update.
11959 * python/py-unwind.c: Update.
11960 * python/py-utils.c: Update.
11961 * python/py-value.c: Update.
11962 * python/python.c: Update.
11963 * record-btrace.c: Update.
11964 * record-full.c: Update.
11965 * remote-fileio.c: Update.
11966 * remote.c: Update.
11967 * riscv-tdep.c: Update.
11968 * rs6000-aix-tdep.c: Update.
11969 * rs6000-tdep.c: Update.
11970 * rust-exp.y: Update.
11971 * rust-lang.c: Update.
11972 * s390-tdep.c: Update.
11973 * selftest-arch.c: Update.
11974 * solib-dsbt.c: Update.
11975 * solib-frv.c: Update.
11976 * solib-spu.c: Update.
11977 * solib-svr4.c: Update.
11979 * sparc64-linux-tdep.c: Update.
11981 * symfile-mem.c: Update.
11982 * symmisc.c: Update.
11983 * target.c: Update.
11984 * thread.c: Update.
11986 * tracefile-tfile.c: Update.
11987 * tui/tui.c: Update.
11988 * typeprint.c: Update.
11989 * unittests/cli-utils-selftests.c: Update.
11990 * unittests/parse-connection-spec-selftests.c: Update.
11991 * valops.c: Update.
11992 * valprint.c: Update.
11994 * varobj.c: Update.
11995 * windows-nat.c: Update.
11996 * x86-linux-nat.c: Update.
11997 * xml-support.c: Update.
11999 2019-04-08 Tom Tromey <tom@tromey.com>
12001 * xml-support.c: Use C++ exception handling.
12002 * x86-linux-nat.c: Use C++ exception handling.
12003 * windows-nat.c: Use C++ exception handling.
12004 * varobj.c: Use C++ exception handling.
12005 * value.c: Use C++ exception handling.
12006 * valprint.c: Use C++ exception handling.
12007 * valops.c: Use C++ exception handling.
12008 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12010 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12011 * typeprint.c: Use C++ exception handling.
12012 * tui/tui.c: Use C++ exception handling.
12013 * tracefile-tfile.c: Use C++ exception handling.
12014 * top.c: Use C++ exception handling.
12015 * thread.c: Use C++ exception handling.
12016 * target.c: Use C++ exception handling.
12017 * symmisc.c: Use C++ exception handling.
12018 * symfile-mem.c: Use C++ exception handling.
12019 * stack.c: Use C++ exception handling.
12020 * sparc64-linux-tdep.c: Use C++ exception handling.
12021 * solib.c: Use C++ exception handling.
12022 * solib-svr4.c: Use C++ exception handling.
12023 * solib-spu.c: Use C++ exception handling.
12024 * solib-frv.c: Use C++ exception handling.
12025 * solib-dsbt.c: Use C++ exception handling.
12026 * selftest-arch.c: Use C++ exception handling.
12027 * s390-tdep.c: Use C++ exception handling.
12028 * rust-lang.c: Use C++ exception handling.
12029 * rust-exp.y: Use C++ exception handling.
12030 * rs6000-tdep.c: Use C++ exception handling.
12031 * rs6000-aix-tdep.c: Use C++ exception handling.
12032 * riscv-tdep.c: Use C++ exception handling.
12033 * remote.c: Use C++ exception handling.
12034 * remote-fileio.c: Use C++ exception handling.
12035 * record-full.c: Use C++ exception handling.
12036 * record-btrace.c: Use C++ exception handling.
12037 * python/python.c: Use C++ exception handling.
12038 * python/py-value.c: Use C++ exception handling.
12039 * python/py-utils.c: Use C++ exception handling.
12040 * python/py-unwind.c: Use C++ exception handling.
12041 * python/py-type.c: Use C++ exception handling.
12042 * python/py-symbol.c: Use C++ exception handling.
12043 * python/py-record.c: Use C++ exception handling.
12044 * python/py-record-btrace.c: Use C++ exception handling.
12045 * python/py-progspace.c: Use C++ exception handling.
12046 * python/py-prettyprint.c: Use C++ exception handling.
12047 * python/py-param.c: Use C++ exception handling.
12048 * python/py-objfile.c: Use C++ exception handling.
12049 * python/py-linetable.c: Use C++ exception handling.
12050 * python/py-lazy-string.c: Use C++ exception handling.
12051 * python/py-infthread.c: Use C++ exception handling.
12052 * python/py-inferior.c: Use C++ exception handling.
12053 * python/py-gdb-readline.c: Use C++ exception handling.
12054 * python/py-framefilter.c: Use C++ exception handling.
12055 * python/py-frame.c: Use C++ exception handling.
12056 * python/py-finishbreakpoint.c: Use C++ exception handling.
12057 * python/py-cmd.c: Use C++ exception handling.
12058 * python/py-breakpoint.c: Use C++ exception handling.
12059 * python/py-arch.c: Use C++ exception handling.
12060 * printcmd.c: Use C++ exception handling.
12061 * ppc-linux-tdep.c: Use C++ exception handling.
12062 * parse.c: Use C++ exception handling.
12063 * p-valprint.c: Use C++ exception handling.
12064 * objc-lang.c: Use C++ exception handling.
12065 * mi/mi-main.c: Use C++ exception handling.
12066 * mi/mi-interp.c: Use C++ exception handling.
12067 * mi/mi-cmd-stack.c: Use C++ exception handling.
12068 * mi/mi-cmd-break.c: Use C++ exception handling.
12069 * main.c: Use C++ exception handling.
12070 * linux-thread-db.c: Use C++ exception handling.
12071 * linux-tdep.c: Use C++ exception handling.
12072 * linux-nat.c: Use C++ exception handling.
12073 * linux-fork.c: Use C++ exception handling.
12074 * linespec.c: Use C++ exception handling.
12075 * language.c: Use C++ exception handling.
12076 * jit.c: Use C++ exception handling.
12077 * infrun.c: Use C++ exception handling.
12078 * infcmd.c: Use C++ exception handling.
12079 * infcall.c: Use C++ exception handling.
12080 * inf-loop.c: Use C++ exception handling.
12081 * i386-tdep.c: Use C++ exception handling.
12082 * i386-linux-tdep.c: Use C++ exception handling.
12083 * guile/scm-value.c: Use C++ exception handling.
12084 * guile/scm-type.c: Use C++ exception handling.
12085 * guile/scm-symtab.c: Use C++ exception handling.
12086 * guile/scm-symbol.c: Use C++ exception handling.
12087 * guile/scm-pretty-print.c: Use C++ exception handling.
12088 * guile/scm-ports.c: Use C++ exception handling.
12089 * guile/scm-param.c: Use C++ exception handling.
12090 * guile/scm-math.c: Use C++ exception handling.
12091 * guile/scm-lazy-string.c: Use C++ exception handling.
12092 * guile/scm-frame.c: Use C++ exception handling.
12093 * guile/scm-disasm.c: Use C++ exception handling.
12094 * guile/scm-cmd.c: Use C++ exception handling.
12095 * guile/scm-breakpoint.c: Use C++ exception handling.
12096 * guile/scm-block.c: Use C++ exception handling.
12097 * guile/guile-internal.h: Use C++ exception handling.
12098 * gnu-v3-abi.c: Use C++ exception handling.
12099 * gdbtypes.c: Use C++ exception handling.
12100 * frame.c: Use C++ exception handling.
12101 * frame-unwind.c: Use C++ exception handling.
12102 * fbsd-tdep.c: Use C++ exception handling.
12103 * f-valprint.c: Use C++ exception handling.
12104 * exec.c: Use C++ exception handling.
12105 * event-top.c: Use C++ exception handling.
12106 * event-loop.c: Use C++ exception handling.
12107 * eval.c: Use C++ exception handling.
12108 * dwarf2read.c: Use C++ exception handling.
12109 * dwarf2loc.c: Use C++ exception handling.
12110 * dwarf2-frame.c: Use C++ exception handling.
12111 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12112 * dwarf-index-write.c: Use C++ exception handling.
12113 * dwarf-index-cache.c: Use C++ exception handling.
12114 * dtrace-probe.c: Use C++ exception handling.
12115 * disasm-selftests.c: Use C++ exception handling.
12116 * darwin-nat.c: Use C++ exception handling.
12117 * cp-valprint.c: Use C++ exception handling.
12118 * cp-support.c: Use C++ exception handling.
12119 * cp-abi.c: Use C++ exception handling.
12120 * corelow.c: Use C++ exception handling.
12121 * completer.c: Use C++ exception handling.
12122 * compile/compile-object-run.c: Use C++ exception handling.
12123 * compile/compile-object-load.c: Use C++ exception handling.
12124 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12125 * compile/compile-c-symbols.c: Use C++ exception handling.
12126 * common/selftest.c: Use C++ exception handling.
12127 * common/new-op.c: Use C++ exception handling.
12128 * cli/cli-script.c: Use C++ exception handling.
12129 * cli/cli-interp.c: Use C++ exception handling.
12130 * cli/cli-cmds.c: Use C++ exception handling.
12131 * c-varobj.c: Use C++ exception handling.
12132 * btrace.c: Use C++ exception handling.
12133 * breakpoint.c: Use C++ exception handling.
12134 * break-catch-throw.c: Use C++ exception handling.
12135 * arch-utils.c: Use C++ exception handling.
12136 * amd64-tdep.c: Use C++ exception handling.
12137 * ada-valprint.c: Use C++ exception handling.
12138 * ada-typeprint.c: Use C++ exception handling.
12139 * ada-lang.c: Use C++ exception handling.
12140 * aarch64-tdep.c: Use C++ exception handling.
12142 2019-04-08 Tom Tromey <tom@tromey.com>
12144 * xml-support.c (gdb_xml_parser::parse): Update.
12145 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12146 * value.c (show_convenience): Update.
12147 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12148 (test_parse_flags_qcs): Update.
12149 * thread.c (thr_try_catch_cmd): Update.
12150 * target.c (target_translate_tls_address): Update.
12151 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12152 (info_frame_command_core, frame_apply_command_count): Update.
12153 * rust-exp.y (rust_lex_exception_test): Update.
12154 * riscv-tdep.c (riscv_print_one_register_info): Update.
12155 * remote.c (remote_target::enable_btrace): Update.
12156 * record-btrace.c (record_btrace_enable_warn): Update.
12157 * python/py-utils.c (gdbpy_convert_exception): Update.
12158 * printcmd.c (do_one_display, print_variable_and_value): Update.
12159 * mi/mi-main.c (mi_print_exception): Update.
12160 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12161 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12162 * linux-nat.c (linux_nat_target::attach): Update.
12163 * linux-fork.c (class scoped_switch_fork_info): Update.
12164 * infrun.c (displaced_step_prepare): Update.
12165 * infcall.c (call_function_by_hand_dummy): Update.
12166 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12167 * gnu-v3-abi.c (print_one_vtable): Update.
12168 * frame.c (get_prev_frame_always): Update.
12169 * f-valprint.c (info_common_command_for_block): Update.
12170 * exec.c (try_open_exec_file): Update.
12171 * exceptions.c (print_exception, exception_print)
12172 (exception_fprintf, exception_print_same): Update.
12173 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12174 * dwarf-index-cache.c (index_cache::store)
12175 (index_cache::lookup_gdb_index): Update.
12176 * darwin-nat.c (maybe_cache_shell): Update.
12177 * cp-valprint.c (cp_print_value_fields): Update.
12178 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12179 (gcc_cplus_symbol_address): Update.
12180 * compile/compile-c-symbols.c (gcc_convert_symbol)
12181 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12182 * common/selftest.c: Update.
12183 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12185 (exception_try_scope_entry, exception_try_scope_exit): Don't
12187 (struct exception_try_scope): Remove.
12188 (TRY): Don't use exception_try_scope.
12189 (struct gdb_exception): Add constructor, operator=.
12190 <what>: New method.
12191 (struct gdb_exception_RETURN_MASK_ALL)
12192 (struct gdb_exception_RETURN_MASK_ERROR)
12193 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12194 (struct gdb_quit_bad_alloc): Update.
12195 * common/common-exceptions.c (exception_none): Change
12197 (struct catcher) <state, exception>: Initialize inline.
12198 <prev>: Remove member.
12199 (current_catcher): Remove.
12200 (catchers): New global.
12201 (exceptions_state_mc_init): Simplify.
12202 (catcher_pop): Remove.
12203 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12204 (try_scope_depth, exception_try_scope_entry)
12205 (exception_try_scope_exit): Remove.
12206 (throw_exception_sjlj): Update.
12207 (exception_messages, exception_messages_size): Remove.
12208 (throw_it): Simplify.
12209 (gdb_exception_sliced_copy): Remove.
12210 (throw_exception_cxx): Update.
12211 * cli/cli-script.c (script_from_file): Update.
12212 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12214 * ada-valprint.c (ada_val_print): Update.
12215 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12216 (create_excep_cond_exprs): Update.
12218 2019-04-08 Tom Tromey <tom@tromey.com>
12220 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12221 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12222 (TRY, CATCH, END_CATCH): Remove some definitions.
12223 * common/common-exceptions.c: Don't use GDB_XCPT.
12224 (catcher_list_size): Remove.
12225 (throw_exception, throw_it): Simplify.
12227 2019-04-05 Tom Tromey <tom@tromey.com>
12229 Revert the header-sorting patch.
12230 * ft32-tdep.c: Revert.
12231 * frv-tdep.c: Revert.
12232 * frv-linux-tdep.c: Revert.
12234 * frame-unwind.c: Revert.
12235 * frame-base.c: Revert.
12236 * fork-child.c: Revert.
12237 * findvar.c: Revert.
12238 * findcmd.c: Revert.
12239 * filesystem.c: Revert.
12240 * filename-seen-cache.h: Revert.
12241 * filename-seen-cache.c: Revert.
12242 * fbsd-tdep.c: Revert.
12243 * fbsd-nat.h: Revert.
12244 * fbsd-nat.c: Revert.
12245 * f-valprint.c: Revert.
12246 * f-typeprint.c: Revert.
12247 * f-lang.c: Revert.
12248 * extension.h: Revert.
12249 * extension.c: Revert.
12250 * extension-priv.h: Revert.
12251 * expprint.c: Revert.
12254 * exceptions.c: Revert.
12255 * event-top.c: Revert.
12256 * event-loop.c: Revert.
12258 * elfread.c: Revert.
12259 * dwarf2read.h: Revert.
12260 * dwarf2read.c: Revert.
12261 * dwarf2loc.c: Revert.
12262 * dwarf2expr.h: Revert.
12263 * dwarf2expr.c: Revert.
12264 * dwarf2-frame.c: Revert.
12265 * dwarf2-frame-tailcall.c: Revert.
12266 * dwarf-index-write.h: Revert.
12267 * dwarf-index-write.c: Revert.
12268 * dwarf-index-common.c: Revert.
12269 * dwarf-index-cache.h: Revert.
12270 * dwarf-index-cache.c: Revert.
12271 * dummy-frame.c: Revert.
12272 * dtrace-probe.c: Revert.
12273 * disasm.h: Revert.
12274 * disasm.c: Revert.
12275 * disasm-selftests.c: Revert.
12276 * dictionary.c: Revert.
12277 * dicos-tdep.c: Revert.
12278 * demangle.c: Revert.
12279 * dcache.h: Revert.
12280 * dcache.c: Revert.
12281 * darwin-nat.h: Revert.
12282 * darwin-nat.c: Revert.
12283 * darwin-nat-info.c: Revert.
12284 * d-valprint.c: Revert.
12285 * d-namespace.c: Revert.
12286 * d-lang.c: Revert.
12288 * csky-tdep.c: Revert.
12289 * csky-linux-tdep.c: Revert.
12290 * cris-tdep.c: Revert.
12291 * cris-linux-tdep.c: Revert.
12292 * cp-valprint.c: Revert.
12293 * cp-support.c: Revert.
12294 * cp-namespace.c: Revert.
12295 * cp-abi.c: Revert.
12296 * corelow.c: Revert.
12297 * corefile.c: Revert.
12298 * continuations.c: Revert.
12299 * completer.h: Revert.
12300 * completer.c: Revert.
12301 * complaints.c: Revert.
12302 * coffread.c: Revert.
12303 * coff-pe-read.c: Revert.
12304 * cli-out.h: Revert.
12305 * cli-out.c: Revert.
12306 * charset.c: Revert.
12307 * c-varobj.c: Revert.
12308 * c-valprint.c: Revert.
12309 * c-typeprint.c: Revert.
12310 * c-lang.c: Revert.
12311 * buildsym.c: Revert.
12312 * buildsym-legacy.c: Revert.
12313 * build-id.h: Revert.
12314 * build-id.c: Revert.
12315 * btrace.c: Revert.
12316 * bsd-uthread.c: Revert.
12317 * breakpoint.h: Revert.
12318 * breakpoint.c: Revert.
12319 * break-catch-throw.c: Revert.
12320 * break-catch-syscall.c: Revert.
12321 * break-catch-sig.c: Revert.
12322 * blockframe.c: Revert.
12324 * bfin-tdep.c: Revert.
12325 * bfin-linux-tdep.c: Revert.
12326 * bfd-target.c: Revert.
12327 * bcache.c: Revert.
12328 * ax-general.c: Revert.
12329 * ax-gdb.h: Revert.
12330 * ax-gdb.c: Revert.
12331 * avr-tdep.c: Revert.
12333 * auto-load.c: Revert.
12334 * arm-wince-tdep.c: Revert.
12335 * arm-tdep.c: Revert.
12336 * arm-symbian-tdep.c: Revert.
12337 * arm-pikeos-tdep.c: Revert.
12338 * arm-obsd-tdep.c: Revert.
12339 * arm-nbsd-tdep.c: Revert.
12340 * arm-nbsd-nat.c: Revert.
12341 * arm-linux-tdep.c: Revert.
12342 * arm-linux-nat.c: Revert.
12343 * arm-fbsd-tdep.c: Revert.
12344 * arm-fbsd-nat.c: Revert.
12345 * arm-bsd-tdep.c: Revert.
12346 * arch-utils.c: Revert.
12347 * arc-tdep.c: Revert.
12348 * arc-newlib-tdep.c: Revert.
12349 * annotate.h: Revert.
12350 * annotate.c: Revert.
12351 * amd64-windows-tdep.c: Revert.
12352 * amd64-windows-nat.c: Revert.
12353 * amd64-tdep.c: Revert.
12354 * amd64-sol2-tdep.c: Revert.
12355 * amd64-obsd-tdep.c: Revert.
12356 * amd64-obsd-nat.c: Revert.
12357 * amd64-nbsd-tdep.c: Revert.
12358 * amd64-nbsd-nat.c: Revert.
12359 * amd64-nat.c: Revert.
12360 * amd64-linux-tdep.c: Revert.
12361 * amd64-linux-nat.c: Revert.
12362 * amd64-fbsd-tdep.c: Revert.
12363 * amd64-fbsd-nat.c: Revert.
12364 * amd64-dicos-tdep.c: Revert.
12365 * amd64-darwin-tdep.c: Revert.
12366 * amd64-bsd-nat.c: Revert.
12367 * alpha-tdep.c: Revert.
12368 * alpha-obsd-tdep.c: Revert.
12369 * alpha-nbsd-tdep.c: Revert.
12370 * alpha-mdebug-tdep.c: Revert.
12371 * alpha-linux-tdep.c: Revert.
12372 * alpha-linux-nat.c: Revert.
12373 * alpha-bsd-tdep.c: Revert.
12374 * alpha-bsd-nat.c: Revert.
12375 * aix-thread.c: Revert.
12377 * addrmap.c: Revert.
12378 * ada-varobj.c: Revert.
12379 * ada-valprint.c: Revert.
12380 * ada-typeprint.c: Revert.
12381 * ada-tasks.c: Revert.
12382 * ada-lang.c: Revert.
12383 * aarch64-tdep.c: Revert.
12384 * aarch64-ravenscar-thread.c: Revert.
12385 * aarch64-newlib-tdep.c: Revert.
12386 * aarch64-linux-tdep.c: Revert.
12387 * aarch64-linux-nat.c: Revert.
12388 * aarch64-fbsd-tdep.c: Revert.
12389 * aarch64-fbsd-nat.c: Revert.
12390 * aarch32-linux-nat.c: Revert.
12392 2019-04-05 Tom Tromey <tom@tromey.com>
12394 * ft32-tdep.c: Sort headers.
12395 * frv-tdep.c: Sort headers.
12396 * frv-linux-tdep.c: Sort headers.
12397 * frame.c: Sort headers.
12398 * frame-unwind.c: Sort headers.
12399 * frame-base.c: Sort headers.
12400 * fork-child.c: Sort headers.
12401 * findvar.c: Sort headers.
12402 * findcmd.c: Sort headers.
12403 * filesystem.c: Sort headers.
12404 * filename-seen-cache.h: Sort headers.
12405 * filename-seen-cache.c: Sort headers.
12406 * fbsd-tdep.c: Sort headers.
12407 * fbsd-nat.h: Sort headers.
12408 * fbsd-nat.c: Sort headers.
12409 * f-valprint.c: Sort headers.
12410 * f-typeprint.c: Sort headers.
12411 * f-lang.c: Sort headers.
12412 * extension.h: Sort headers.
12413 * extension.c: Sort headers.
12414 * extension-priv.h: Sort headers.
12415 * expprint.c: Sort headers.
12416 * exec.h: Sort headers.
12417 * exec.c: Sort headers.
12418 * exceptions.c: Sort headers.
12419 * event-top.c: Sort headers.
12420 * event-loop.c: Sort headers.
12421 * eval.c: Sort headers.
12422 * elfread.c: Sort headers.
12423 * dwarf2read.h: Sort headers.
12424 * dwarf2read.c: Sort headers.
12425 * dwarf2loc.c: Sort headers.
12426 * dwarf2expr.h: Sort headers.
12427 * dwarf2expr.c: Sort headers.
12428 * dwarf2-frame.c: Sort headers.
12429 * dwarf2-frame-tailcall.c: Sort headers.
12430 * dwarf-index-write.h: Sort headers.
12431 * dwarf-index-write.c: Sort headers.
12432 * dwarf-index-common.c: Sort headers.
12433 * dwarf-index-cache.h: Sort headers.
12434 * dwarf-index-cache.c: Sort headers.
12435 * dummy-frame.c: Sort headers.
12436 * dtrace-probe.c: Sort headers.
12437 * disasm.h: Sort headers.
12438 * disasm.c: Sort headers.
12439 * disasm-selftests.c: Sort headers.
12440 * dictionary.c: Sort headers.
12441 * dicos-tdep.c: Sort headers.
12442 * demangle.c: Sort headers.
12443 * dcache.h: Sort headers.
12444 * dcache.c: Sort headers.
12445 * darwin-nat.h: Sort headers.
12446 * darwin-nat.c: Sort headers.
12447 * darwin-nat-info.c: Sort headers.
12448 * d-valprint.c: Sort headers.
12449 * d-namespace.c: Sort headers.
12450 * d-lang.c: Sort headers.
12451 * ctf.c: Sort headers.
12452 * csky-tdep.c: Sort headers.
12453 * csky-linux-tdep.c: Sort headers.
12454 * cris-tdep.c: Sort headers.
12455 * cris-linux-tdep.c: Sort headers.
12456 * cp-valprint.c: Sort headers.
12457 * cp-support.c: Sort headers.
12458 * cp-namespace.c: Sort headers.
12459 * cp-abi.c: Sort headers.
12460 * corelow.c: Sort headers.
12461 * corefile.c: Sort headers.
12462 * continuations.c: Sort headers.
12463 * completer.h: Sort headers.
12464 * completer.c: Sort headers.
12465 * complaints.c: Sort headers.
12466 * coffread.c: Sort headers.
12467 * coff-pe-read.c: Sort headers.
12468 * cli-out.h: Sort headers.
12469 * cli-out.c: Sort headers.
12470 * charset.c: Sort headers.
12471 * c-varobj.c: Sort headers.
12472 * c-valprint.c: Sort headers.
12473 * c-typeprint.c: Sort headers.
12474 * c-lang.c: Sort headers.
12475 * buildsym.c: Sort headers.
12476 * buildsym-legacy.c: Sort headers.
12477 * build-id.h: Sort headers.
12478 * build-id.c: Sort headers.
12479 * btrace.c: Sort headers.
12480 * bsd-uthread.c: Sort headers.
12481 * breakpoint.h: Sort headers.
12482 * breakpoint.c: Sort headers.
12483 * break-catch-throw.c: Sort headers.
12484 * break-catch-syscall.c: Sort headers.
12485 * break-catch-sig.c: Sort headers.
12486 * blockframe.c: Sort headers.
12487 * block.c: Sort headers.
12488 * bfin-tdep.c: Sort headers.
12489 * bfin-linux-tdep.c: Sort headers.
12490 * bfd-target.c: Sort headers.
12491 * bcache.c: Sort headers.
12492 * ax-general.c: Sort headers.
12493 * ax-gdb.h: Sort headers.
12494 * ax-gdb.c: Sort headers.
12495 * avr-tdep.c: Sort headers.
12496 * auxv.c: Sort headers.
12497 * auto-load.c: Sort headers.
12498 * arm-wince-tdep.c: Sort headers.
12499 * arm-tdep.c: Sort headers.
12500 * arm-symbian-tdep.c: Sort headers.
12501 * arm-pikeos-tdep.c: Sort headers.
12502 * arm-obsd-tdep.c: Sort headers.
12503 * arm-nbsd-tdep.c: Sort headers.
12504 * arm-nbsd-nat.c: Sort headers.
12505 * arm-linux-tdep.c: Sort headers.
12506 * arm-linux-nat.c: Sort headers.
12507 * arm-fbsd-tdep.c: Sort headers.
12508 * arm-fbsd-nat.c: Sort headers.
12509 * arm-bsd-tdep.c: Sort headers.
12510 * arch-utils.c: Sort headers.
12511 * arc-tdep.c: Sort headers.
12512 * arc-newlib-tdep.c: Sort headers.
12513 * annotate.h: Sort headers.
12514 * annotate.c: Sort headers.
12515 * amd64-windows-tdep.c: Sort headers.
12516 * amd64-windows-nat.c: Sort headers.
12517 * amd64-tdep.c: Sort headers.
12518 * amd64-sol2-tdep.c: Sort headers.
12519 * amd64-obsd-tdep.c: Sort headers.
12520 * amd64-obsd-nat.c: Sort headers.
12521 * amd64-nbsd-tdep.c: Sort headers.
12522 * amd64-nbsd-nat.c: Sort headers.
12523 * amd64-nat.c: Sort headers.
12524 * amd64-linux-tdep.c: Sort headers.
12525 * amd64-linux-nat.c: Sort headers.
12526 * amd64-fbsd-tdep.c: Sort headers.
12527 * amd64-fbsd-nat.c: Sort headers.
12528 * amd64-dicos-tdep.c: Sort headers.
12529 * amd64-darwin-tdep.c: Sort headers.
12530 * amd64-bsd-nat.c: Sort headers.
12531 * alpha-tdep.c: Sort headers.
12532 * alpha-obsd-tdep.c: Sort headers.
12533 * alpha-nbsd-tdep.c: Sort headers.
12534 * alpha-mdebug-tdep.c: Sort headers.
12535 * alpha-linux-tdep.c: Sort headers.
12536 * alpha-linux-nat.c: Sort headers.
12537 * alpha-bsd-tdep.c: Sort headers.
12538 * alpha-bsd-nat.c: Sort headers.
12539 * aix-thread.c: Sort headers.
12540 * agent.c: Sort headers.
12541 * addrmap.c: Sort headers.
12542 * ada-varobj.c: Sort headers.
12543 * ada-valprint.c: Sort headers.
12544 * ada-typeprint.c: Sort headers.
12545 * ada-tasks.c: Sort headers.
12546 * ada-lang.c: Sort headers.
12547 * aarch64-tdep.c: Sort headers.
12548 * aarch64-ravenscar-thread.c: Sort headers.
12549 * aarch64-newlib-tdep.c: Sort headers.
12550 * aarch64-linux-tdep.c: Sort headers.
12551 * aarch64-linux-nat.c: Sort headers.
12552 * aarch64-fbsd-tdep.c: Sort headers.
12553 * aarch64-fbsd-nat.c: Sort headers.
12554 * aarch32-linux-nat.c: Sort headers.
12556 2019-04-04 Tom Tromey <tom@tromey.com>
12558 * varobj.c (varobj_create): Update.
12559 * rust-exp.y (struct rust_parser) <update_innermost_block,
12560 lookup_symbol>: New methods.
12561 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12563 (rust_parser::rust_lookup_type)
12564 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12565 * printcmd.c (display_command, do_one_display): Update.
12566 * parser-defs.h (struct parser_state) <parser_state>: Add
12567 "tracker" parameter.
12568 (block_tracker): New member.
12569 (class innermost_block_tracker) <innermost_block_tracker>: Add
12571 <reset>: Remove method.
12572 (innermost_block): Don't declare.
12573 (null_post_parser): Update.
12574 * parse.c (innermost_block): Remove global.
12575 (write_dollar_variable): Update.
12576 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12577 Remove "tracker_types" parameter.
12578 (parse_expression): Add "tracker" parameter.
12579 (parse_expression_for_completion): Update.
12580 (null_post_parser): Add "tracker" parameter.
12581 * p-exp.y: Update rules.
12582 * m2-exp.y: Update rules.
12583 * language.h (struct language_defn) <la_post_parser>: Add
12584 "tracker" parameter.
12585 * go-exp.y: Update rules.
12586 * f-exp.y: Update rules.
12587 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12589 * d-exp.y: Update rules.
12590 * c-exp.y: Update rules.
12591 * breakpoint.c (set_breakpoint_condition): Create an
12592 innermost_block_tracker.
12593 (watch_command_1): Likewise.
12594 * ada-lang.c (resolve): Add "tracker" parameter.
12595 (resolve_subexp): Likewise.
12596 * ada-exp.y (write_var_from_sym): Update.
12598 2019-04-04 Tom Tromey <tom@tromey.com>
12600 * type-stack.h: New file.
12601 * type-stack.c: New file.
12602 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12604 (insert_into_type_stack, insert_type, push_type, push_type_int)
12605 (insert_type_address_space, pop_type, pop_type_int)
12606 (pop_typelist, pop_type_stack, append_type_stack)
12607 (push_type_stack, get_type_stack, push_typelist)
12608 (follow_type_instance_flags, follow_types): Don't declare.
12609 * parse.c (type_stack): Remove global.
12610 (parse_exp_in_context): Update.
12611 (insert_into_type_stack, insert_type, push_type, push_type_int)
12612 (insert_type_address_space, pop_type, pop_type_int)
12613 (pop_typelist, pop_type_stack, append_type_stack)
12614 (push_type_stack, get_type_stack, push_typelist)
12615 (follow_type_instance_flags, follow_types): Remove (moved to
12617 * f-exp.y (type_stack): New global.
12619 (push_kind_type, f_parse): Update.
12620 * d-exp.y (type_stack): New global.
12623 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12625 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12626 (HFILES_NO_SRCDIR): Add type-stack.h.
12628 2019-04-04 Tom Tromey <tom@tromey.com>
12630 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12631 (rust_parser::convert_ast_to_expression, rust_parse)
12632 (rust_lex_test_completion, rust_lex_tests): Update.
12633 * parser-defs.h (struct expr_completion_state): New.
12634 (struct parser_state) <parser_state>: Add completion parameter.
12635 <mark_struct_expression, mark_completion_tag>: New methods.
12636 <parse_completion, m_completion_state>: New members.
12637 (prefixify_expression, null_post_parser): Update.
12638 (mark_struct_expression, mark_completion_tag): Don't declare.
12639 * parse.c (parse_completion, expout_last_struct)
12640 (expout_tag_completion_type, expout_completion_name): Remove
12642 (parser_state::mark_struct_expression)
12643 (parser_state::mark_completion_tag): Now methods.
12644 (prefixify_expression): Add last_struct parameter.
12645 (prefixify_subexp): Likewise.
12646 (parse_exp_1): Update.
12647 (parse_exp_in_context): Add cstate parameter. Update.
12648 (parse_expression_for_completion): Create an
12649 expr_completion_state.
12650 (null_post_parser): Add "completion" parameter.
12651 * p-exp.y: Update rules.
12653 * language.h (struct language_defn) <la_post_parser>: Add
12654 "completing" parameter.
12655 * go-exp.y: Update rules.
12656 (lex_one_token): Update.
12657 * expression.h (parse_completion): Don't declare.
12658 * d-exp.y: Update rules.
12659 (lex_one_token): Update rules.
12660 * c-exp.y: Update rules.
12661 (lex_one_token): Update.
12662 * ada-lang.c (resolve): Add "parse_completion" parameter.
12663 (resolve_subexp): Likewise.
12664 (ada_resolve_function): Likewise.
12666 2019-04-04 Tom Tromey <tom@tromey.com>
12668 * parser-defs.h (struct parser_state) <start_arglist,
12669 end_arglist>: New methods.
12670 <arglist_len, m_funcall_chain>: New members.
12671 (arglist_len, start_arglist, end_arglist): Don't declare.
12672 * parse.c (arglist_len, funcall_chain): Remove global.
12673 (start_arglist, end_arglist): Remove functions.
12674 (parse_exp_in_context): Update.
12675 * p-exp.y: Update rules.
12676 * m2-exp.y: Update rules.
12677 * go-exp.y: Update rules.
12678 * f-exp.y: Update rules.
12679 * d-exp.y: Update rules.
12680 * c-exp.y: Update rules.
12682 2019-04-04 Tom Tromey <tom@tromey.com>
12684 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12685 lex_operator, push_back>: New methods.
12687 (rust_parser::lex_hex, lex_escape): Rename and update.
12688 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12689 (rust_parser::lex_operator): Rename and update.
12690 (rust_parser::lex_number, rustyylex, rustyyerror)
12691 (rust_lex_test_init, rust_lex_test_sequence)
12692 (rust_lex_test_push_back, rust_lex_tests): Update.
12693 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12695 <lexptr, prev_lexptr>: New members.
12696 (lexptr, prev_lexptr): Don't declare.
12697 * parse.c (lexptr, prev_lexptr): Remove globals.
12698 (parse_exp_in_context): Update.
12699 * p-exp.y (yylex, yyerror): Update.
12700 * m2-exp.y (parse_number, yylex, yyerror): Update.
12701 * go-exp.y (lex_one_token, yyerror): Update.
12702 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12703 * d-exp.y (lex_one_token, yyerror): Update.
12704 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12705 (lex_one_token, yyerror): Update.
12706 * ada-lex.l (YY_INPUT): Update.
12707 (rewind_to_char): Update.
12708 * ada-exp.y (yyerror): Update.
12710 2019-04-04 Tom Tromey <tom@tromey.com>
12712 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12713 * parser-defs.h (struct parser_state) <parser_state>: Add new
12715 <comma_terminates>: New member.
12716 (comma_terminates): Don't declare global.
12717 * parse.c (comma_terminates): Remove global.
12718 (parse_exp_in_context): Update.
12719 * p-exp.y (yylex): Update.
12720 * m2-exp.y (yylex): Update.
12721 * go-exp.y (lex_one_token): Update.
12722 * f-exp.y (yylex): Update.
12723 * d-exp.y (lex_one_token): Update.
12724 * c-exp.y (lex_one_token): Update.
12725 * ada-lex.l: Update.
12727 2019-04-04 Tom Tromey <tom@tromey.com>
12729 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12730 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12731 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12732 * parser-defs.h (paren_depth): Don't declare.
12733 * parse.c (paren_depth): Remove global.
12734 (parse_exp_in_context): Update.
12735 * p-exp.y (paren_depth): New global.
12736 (pascal_parse): Initialize it.
12737 * m2-exp.y (paren_depth): New global.
12738 (m2_parse): Initialize it.
12739 * go-exp.y (paren_depth): New global.
12740 (go_parse): Initialize it.
12741 * f-exp.y (paren_depth): New global.
12742 (f_parse): Initialize it.
12743 * d-exp.y (paren_depth): New global.
12744 (d_parse): Initialize it.
12745 * c-exp.y (paren_depth): New global.
12746 (c_parse): Initialize it.
12747 * ada-lex.l (paren_depth): New global.
12748 (lexer_init): Initialize it.
12750 2019-04-04 Tom Tromey <tom@tromey.com>
12752 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12753 (rust_parser::convert_ast_to_type)
12754 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12755 * parser-defs.h (struct parser_state) <parser_state>: Add
12756 parameters. Initialize new members.
12757 <expression_context_block, expression_context_pc>: New members.
12758 * parse.c (expression_context_block, expression_context_pc):
12760 (parse_exp_in_context): Update.
12761 * p-exp.y: Update all rules.
12763 * m2-exp.y: Update all rules.
12765 * go-exp.y (yylex): Update.
12766 * f-exp.y (yylex): Update.
12767 * d-exp.y: Update all rules.
12769 * c-exp.y: Update all rules.
12770 (lex_one_token, classify_name, yylex, c_parse): Update.
12771 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12773 2019-04-04 Tom Tromey <tom@tromey.com>
12775 * gdbarch.h, gdbarch.c: Rebuild.
12776 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12778 (struct stap_parse_info): Replace "parser_state" with
12780 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12781 (parser_state): New class.
12782 * parse.c (expr_builder): Rename.
12783 (expr_builder::release): Rename.
12784 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12785 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12786 (write_exp_elt_longcst, write_exp_elt_floatcst)
12787 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12788 (write_exp_string_vector, write_exp_bitstring)
12789 (write_exp_msymbol, mark_struct_expression)
12790 (write_dollar_variable)
12791 (insert_type_address_space, increase_expout_size): Replace
12792 "parser_state" with "expr_builder".
12793 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12794 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12795 "parser_state" with "expr_builder".
12797 2019-04-04 Tom Tromey <tom@tromey.com>
12799 * rust-exp.y: Replace "parse_language" with method call.
12801 (yylex): Replace "parse_language" with method call.
12803 (yylex): Replace "parse_language" with method call.
12804 * go-exp.y (classify_name): Replace "parse_language" with method
12806 * f-exp.y (yylex): Replace "parse_language" with method call.
12807 * d-exp.y (lex_one_token): Replace "parse_language" with method
12810 (lex_one_token, classify_name, yylex): Replace "parse_language"
12812 * ada-exp.y (find_primitive_type, type_char)
12813 (type_system_address): Replace "parse_language" with method call.
12815 2019-04-04 Tom Tromey <tom@tromey.com>
12817 * rust-exp.y: Replace "parse_gdbarch" with method call.
12818 * parse.c (write_dollar_variable, insert_type_address_space):
12819 Replace "parse_gdbarch" with method call.
12820 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12822 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12824 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12825 "parse_gdbarch" with method call.
12826 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12828 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12829 "parse_gdbarch" with method call.
12830 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12831 "parse_gdbarch" with method call.
12832 * c-exp.y (parse_type, parse_number, classify_name): Replace
12833 "parse_gdbarch" with method call.
12834 * ada-lex.l: Replace "parse_gdbarch" with method call.
12835 * ada-exp.y (parse_type, find_primitive_type, type_char)
12836 (type_system_address): Replace "parse_gdbarch" with method call.
12838 2019-04-04 Tom Tromey <tom@tromey.com>
12840 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12841 * stap-probe.c (stap_parse_argument): Update.
12842 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12843 initial_size parameter.
12844 * rust-exp.y (rust_lex_tests): Update.
12845 * parse.c (parser_state): Update.
12846 (parse_exp_in_context): Update.
12847 * parser-defs.h (struct parser_state) <parser_state>: Remove
12848 "initial_size" parameter.
12850 2019-04-04 Tom Tromey <tom@tromey.com>
12852 * parser-defs.h (increase_expout_size): Don't declare.
12853 * parse.c (increase_expout_size): Now static.
12855 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12857 * gnu-nat.c (gnu_nat_target::wait): Fix
12858 target_waitstatus_to_string call.
12860 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12862 * eval.c (evaluate_subexp_standard): Handle internal functions
12863 during Fortran function call handling.
12865 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12867 * NEWS: Mention new internal functions.
12868 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12869 (read_base_type): Use dwarf2_init_complex_target_type.
12870 * value.c (creal_internal_fn): New function.
12871 (cimag_internal_fn): New function.
12872 (_initialize_values): Register new internal functions.
12874 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12876 * infrun.c (stop_all_threads): If debug_infrun, always
12877 trace the wait status after wait_one, using
12878 target_waitstatus_to_string and target_pid_to_str.
12879 (handle_inferior_event): Replace various trace of
12880 wait status kind by a single trace.
12881 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12882 wait status kind image by target_waitstatus_to_string.
12883 * target/waitstatus.c (target_waitstatus_to_string): Fix
12886 2019-04-01 Tom Tromey <tromey@adacore.com>
12889 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12891 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12892 Pedro Alves <palves@redhat.com>
12894 * top.c (quit_force): Call 'finalize_values'.
12895 * value.c (finalize_values): New function.
12896 * value.h (finalize_values): Declare.
12898 2019-03-30 Eli Zaretskii <eliz@gnu.org>
12900 * NEWS: Announce $_gdb_major and $_gdb_minor.
12902 * top.c (init_gdb_version_vars): New function.
12903 (gdb_init): Call init_gdb_version_vars.
12905 2019-03-29 Tom Tromey <tromey@adacore.com>
12907 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12908 help text. Remove dead code.
12910 2019-03-29 Keith Seitz <keiths@redhat.com>
12912 From Siddhesh Poyarekar:
12913 * f-lang.h (f77_get_upperbound): Return LONGEST.
12914 (f77_get_lowerbound): Likewise.
12915 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12916 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12918 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12919 plongest to format print it.
12920 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12921 (f77_get_upperbound): Likewise.
12922 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12923 LOWER_BOUND to LONGEST.
12924 (f77_create_arrayprint_offset_tbl): Likewise.
12926 2019-03-29 Keith Seitz <keiths@redhat.com>
12928 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12929 %s/pulongest for TYPE_LENGTH instead of %d in format
12931 * ada-typerint.c (ada_print_type): Likewise.
12932 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12933 * compile/compile-c-support.c (generate_register_struct): Likewise.
12934 * gdbtypes.c (recursive_dump_type): Likewise.
12935 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12936 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12937 instead of %d in format strings.
12938 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12939 to std::min to ULONGEST.
12940 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12941 instead of %d in format strings.
12942 * tracepoint.c (info_scope_command): Likewise.
12943 * typeprint.c (print_offset_data::update)
12944 (print_offset_data::finish): Likewise.
12945 * xtensa-tdep.c (xtensa_store_return_value)
12946 (xtensa_push_dummy_call): Likewise.
12948 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12950 * windows-nat.c (display_selector): Fixed format specifications
12953 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12955 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12957 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12959 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12960 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12961 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12962 (nios2_linux_init_abi): Install it.
12964 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12966 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12968 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12970 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12972 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12973 Tom Tromey <tromey@adacore.com>
12975 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12977 2019-03-26 Joel Brobecker <brobecker@adacore.com>
12979 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12980 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12981 method to compute the bounds of range types. Also print "[evaluated]"
12982 if the bounds' values come from a dynamic evaluation.
12984 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12986 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12987 whitespace when pretty printing is on.
12989 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12991 * ppc-linux-nat.c: Add include.
12993 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12995 * NEWS: Mention AArch64 Pointer Authentication.
12997 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12999 * arm-linux-nat.c: Add include.
13001 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13003 * source-cache.c (source_cache::get_source_lines): Re-read
13004 fullname after calling open_source_file.
13006 2019-03-25 John Baldwin <jhb@FreeBSD.org>
13008 * NEWS: Mention TLS support for FreeBSD.
13010 2019-03-25 Tom Tromey <tromey@adacore.com>
13012 * minsyms.c (BUNCH_SIZE): Update comment.
13013 (~minimal_symbol_reader): Remove old comment.
13014 (compact_minimal_symbols): Update comment.
13015 (minimal_symbol_reader::install): Remove old comment. Update
13018 2019-03-25 Alan Hayward <alan.hayward@arm.com>
13020 * s390-linux-nat.c: Add include.
13022 2019-03-25 Alan Hayward <alan.hayward@arm.com>
13024 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13025 Call linux_get_hwcap.
13026 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13028 (aarch64_linux_get_hwcap): Remove function.
13029 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13031 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13033 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13034 * linux-tdep.c (linux_get_hwcap): Add function.
13035 (linux_get_hwcap2): Likewise.
13036 * linux-tdep.h (linux_get_hwcap): Add declaration.
13037 (linux_get_hwcap2): Likewise.
13038 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13039 (ppc_linux_get_hwcap2): Likewise.
13040 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13042 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13043 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13044 (ppc_linux_nat_target::read_description): Likewise.
13045 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13046 * s390-linux-nat.c: Likewise.
13047 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13049 2019-03-24 Tom Tromey <tom@tromey.com>
13051 * ada-lang.c (standard_lookup): Simplify initialization.
13052 (ada_lookup_symbol_nonlocal): Simplify return.
13053 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13054 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13055 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13056 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13058 * solib.c (solib_global_lookup): Simplify.
13059 * symtab.c (null_block_symbol): Remove.
13060 (symbol_cache_lookup): Simplify returns.
13061 (lookup_language_this): Simplify returns.
13062 (lookup_symbol_aux): Simplify return.
13063 (lookup_local_symbol): Simplify returns.
13064 (lookup_global_symbol_from_objfile): Simplify return.
13065 (lookup_symbol_in_objfile_symtabs)
13066 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13067 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13068 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13069 * cp-namespace.c (cp_lookup_bare_symbol)
13070 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13071 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13072 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13073 (cp_lookup_symbol_via_imports): Simplify initialization.
13074 (find_symbol_in_baseclass): Likewise.
13075 * symtab.h (null_block_symbol): Remove.
13076 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13077 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13078 (d_lookup_symbol_module): Likewise.
13079 (find_symbol_in_baseclass): Simplify initialization.
13081 2019-03-24 Tom Tromey <tom@tromey.com>
13083 * expression.h: Don't include symtab.h.
13084 (struct block): Forward declare.
13086 2019-03-24 Tom Tromey <tom@tromey.com>
13088 * c-exp.y (typebase): Remove casts.
13089 * gdbtypes.c (lookup_unsigned_typename, )
13090 (lookup_signed_typename): Remove cast.
13091 * eval.c (parse_to_comma_and_eval): Remove cast.
13092 * parse.c (write_dollar_variable): Remove cast.
13093 * block.h (struct block) <superblock>: Now const.
13094 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13095 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13096 (map_block): Make "block" const.
13097 * symfile.h (struct quick_symbol_functions)
13098 <map_matching_symbols>: Constify block argument to "callback".
13099 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13101 (find_pc_sect_compunit_symtab): Make "b" const.
13102 (find_symbol_at_address): Likewise.
13103 (search_symbols): Likewise.
13104 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13105 (dw2_debug_names_lookup_symbol): Likewise.
13106 (dw2_map_matching_symbols): Update.
13107 * p-valprint.c (pascal_val_print): Remove "block".
13108 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13109 (aux_add_nonlocal_symbols): Make "block" const.
13110 (resolve_subexp): Remove cast.
13111 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13113 (iterate_over_file_blocks): Likewise.
13114 * f-exp.y (%union) <bval>: Remove.
13115 * coffread.c (patch_opaque_types): Make "b" const.
13116 * spu-tdep.c (spu_catch_start): Make "block" const.
13117 * c-valprint.c (print_unpacked_pointer): Remove "block".
13118 * symmisc.c (dump_symtab_1): Make "b" const.
13119 (block_depth): Make "block" const.
13120 * d-exp.y (%union) <bval>: Remove.
13121 * cp-support.h (cp_lookup_rtti_type): Update.
13122 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13123 * psymtab.c (psym_lookup_symbol): Make "block" const.
13124 (maintenance_check_psymtabs): Make "b" const.
13125 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13126 (enumerate_locals, enumerate_args): Update.
13127 * python/py-symtab.c (stpy_global_block): Make "block" const.
13128 (stpy_static_block): Likewise.
13129 * inline-frame.c (block_starting_point_at): Make "new_block"
13131 * block.c (find_block_in_blockvector): Make return type const.
13132 (blockvector_for_pc_sect): Make "b" const.
13133 (find_block_in_blockvector): Make "b" const.
13135 2019-03-23 Tom Tromey <tom@tromey.com>
13137 * varobj.c (varobj_create): Update.
13138 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13139 * printcmd.c (display_command, do_one_display): Don't reset
13141 * parser-defs.h (enum innermost_block_tracker_type): Move to
13143 (innermost_block): Update comment.
13144 * parse.c (parse_exp_1): Add tracker_types parameter.
13145 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13146 tracker_types parameter. Reset innermost_block.
13147 (parse_exp_in_context): Remove.
13148 (parse_expression_for_completion): Update.
13149 * objfiles.c (~objfile): Don't reset expression_context_block or
13151 * expression.h (enum innermost_block_tracker_type): Move from
13153 (parse_exp_1): Add tracker_types parameter.
13154 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13155 reset innermost_block.
13157 2019-03-23 Tom Tromey <tom@tromey.com>
13159 * objfiles.h: Include bcache.h.
13161 2019-03-23 Tom Tromey <tom@tromey.com>
13163 * linespec.c (get_current_search_block): Use
13164 scoped_restore_current_language.
13165 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13167 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13168 Jiong Wang <jiong.wang@arm.com>
13170 * aarch64-linux-tdep.c
13171 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13173 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13175 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13176 Jiong Wang <jiong.wang@arm.com>
13178 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13180 (aarch64_analyze_prologue_test): Add PACIASP test.
13181 (aarch64_prologue_prev_register): Unmask PC value.
13183 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13184 Jiong Wang <jiong.wang@arm.com>
13186 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13187 (aarch64_dwarf2_prev_register): Unmask PC value.
13188 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13189 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13190 DW_CFA_AARCH64_negate_ra_state.
13191 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13193 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13194 Jiong Wang <jiong.wang@arm.com>
13196 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13198 (aarch64_pseudo_register_name): Likewise.
13199 (aarch64_pseudo_register_type): Likewise.
13200 (aarch64_pseudo_register_reggroup_p): Likewise.
13201 (aarch64_gdbarch_init): Add pauth registers.
13202 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13203 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13204 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13205 (struct gdbarch_tdep): Add regnum for ra_state.
13207 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13208 Jiong Wang <jiong.wang@arm.com>
13210 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13212 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13213 Jiong Wang <jiong.wang@arm.com>
13215 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13217 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13218 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13219 (aarch64_gdbarch_init): Add puth registers.
13220 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13221 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13222 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13224 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13225 Jiong Wang <jiong.wang@arm.com>
13227 * aarch64-linux-nat.c
13228 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13229 * aarch64-linux-tdep.c
13230 (aarch64_linux_core_read_description): Likewise.
13231 (aarch64_linux_get_hwcap): New function.
13232 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13233 (aarch64_linux_get_hwcap): New declaration.
13235 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13236 Jiong Wang <jiong.wang@arm.com>
13238 * aarch64-linux-nat.c
13239 (aarch64_linux_nat_target::read_description): Add pauth param.
13240 * aarch64-linux-tdep.c
13241 (aarch64_linux_core_read_description): Likewise.
13242 * aarch64-tdep.c (struct target_desc): Add in pauth.
13243 (aarch64_read_description): Add pauth param.
13244 (aarch64_gdbarch_init): Likewise.
13245 * aarch64-tdep.h (aarch64_read_description): Likewise.
13246 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13247 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13248 * features/Makefile: Add new files.
13249 * features/aarch64-pauth.c: New file.
13250 * features/aarch64-pauth.xml: New file.
13252 2019-03-20 Tom Tromey <tromey@adacore.com>
13254 * infrun.c (handle_inferior_event): Rename from
13255 handle_inferior_event_1. Create a scoped_value_mark.
13256 (handle_inferior_event): Remove.
13258 2019-03-19 Tom Tromey <tromey@adacore.com>
13260 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13261 * infrun.h (print_stop_event): Add "displays" parameter.
13262 * infrun.c (print_stop_event): Add "displays" parameter.
13264 2019-03-19 Pedro Alves <palves@redhat.com>
13266 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13267 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13268 to -1. Fix TABs vs spaces.
13269 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13270 * tui/tui-out.h (tui_ui_out) Add intro comments.
13271 <m_line, m_start_of_line>: In-class initialize, and add describing
13274 2019-03-18 Alan Hayward <alan.hayward@arm.com>
13276 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13278 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13280 2019-03-18 Pedro Alves <palves@redhat.com>
13281 Eli Zaretskii <eliz@gnu.org>
13283 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13284 m_line and m_start_of_line.
13286 2019-03-18 Eli Zaretskii <eliz@gnu.org>
13288 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13289 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13290 it returns a newline. This fixes a regression in TU mode, whereby
13291 the next line is output on the same screen line as the user input.
13293 2019-03-18 Tom Tromey <tromey@adacore.com>
13295 * minsyms.c (minimal_symbol_reader::install): Remove call to
13298 2019-03-18 Pedro Alves <palves@redhat.com>
13300 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13302 (apply_style): New, factored out from ...
13303 (apply_ansi_escape): ... this. Handle reverse video mode.
13304 (tui_set_reverse_mode): New function.
13305 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13306 * tui/tui-winsource.c (tui_show_source_line): Use
13307 tui_set_reverse_mode instead of setting A_STANDOUT.
13308 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13309 New setter methods.
13311 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
13313 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13316 2019-03-18 Tom Tromey <tromey@adacore.com>
13318 * ada-lang.c (empty_array): Add "high" parameter.
13319 (ada_evaluate_subexp): Update.
13321 2019-03-17 Sergei Trofimovich <siarheit@google.com>
13323 * unittests/string_view-selftests.c: Define
13324 _initialize_string_view_selftests unconditionally.
13326 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13329 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13331 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13334 * windows-nat.c (display_selector): Fix format specifiers.
13336 2019-03-17 Eli Zaretskii <eliz@gnu.org>
13338 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13339 tui_refill_source_window instead of tui_refresh_win, to update the
13340 current execution line. This fixes redisplay of the current line
13341 when stepping through the code with "next" or "step".
13343 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13345 * source-cache.c (source_cache::get_source_lines): Call
13346 find_source_lines to initialize s->nlines. This fixes vertical
13347 scrolling of TUI source window when the DOWN arrow is pressed.
13349 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13351 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13352 linux-thread-db.c (_initialize_thread_db): Likewise.
13354 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13356 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13357 wclrtoeol in tui_show_source_line". This reverts changes made in
13358 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13360 2019-03-15 Tom Tromey <tom@tromey.com>
13362 * symtab.h (struct minimal_symbol): Derive from
13363 general_symbol_info.
13364 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13365 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13366 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13367 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13368 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13369 (MSYMBOL_SEARCH_NAME): Update.
13370 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13371 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13372 * minsyms.c (minimal_symbol_reader::record_full): Update.
13374 2019-03-15 Tom Tromey <tom@tromey.com>
13376 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13378 2019-03-15 Tom Tromey <tom@tromey.com>
13380 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13381 unique_xmalloc_ptr.
13382 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13384 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13385 (build_minimal_symbol_hash_tables)
13386 (minimal_symbol_reader::install): Update.
13388 2019-03-15 Tom Tromey <tom@tromey.com>
13390 * symtab.c (create_demangled_names_hash): Update.
13391 (symbol_set_names): Update.
13392 * objfiles.h (struct objfile_per_bfd_storage)
13393 <demangled_names_hash>: Now an htab_up.
13394 * objfiles.c (objfile_per_bfd_storage): Simplify.
13396 2019-03-15 Tom Tromey <tom@tromey.com>
13398 * objfiles.h (struct objfile_per_bfd_storage): Declare
13400 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13402 (get_objfile_bfd_data): Use new. Don't initialize
13404 (free_objfile_per_bfd_storage): Remove.
13405 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13407 2019-03-15 Tom Tromey <tom@tromey.com>
13409 * symfile.c (reread_symbols): Update.
13410 * objfiles.c (objfile::objfile): Update.
13411 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13412 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13414 (minimal_symbol_reader::install): Update.
13415 (terminate_minimal_symbol_table): Remove.
13416 * jit.c (jit_object_close_impl): Update.
13418 2019-03-15 Tom Tromey <tom@tromey.com>
13420 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13423 2019-03-15 Tom Tromey <tom@tromey.com>
13425 * objfiles.h (struct objfile_per_bfd_storage)
13426 <demangled_hash_languages>: Now a bitset.
13427 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13428 (lookup_minimal_symbol): Update.
13430 2019-03-15 Tom Tromey <tom@tromey.com>
13432 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13433 Don't return the symbol.
13434 * coffread.c (record_minimal_symbol): Use record_full.
13436 2019-03-14 Eli Zaretskii <eliz@gnu.org>
13438 The MS-Windows port of ncurses fails to switch to a color pair if
13439 one or both of the colors are the implicit default colors. This
13440 change records the default colors when TUI is initialized, and
13441 then specifies them explicitly when a color pair uses the default
13442 colors. This allows color styling in TUI mode on MS-Windows.
13444 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13446 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13447 colors in ncurses_norm_attr.
13448 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13449 "none", replace it with the default color recorded in
13452 2019-03-14 Tom Tromey <tromey@adacore.com>
13454 * source-cache.h (class source_cache) <get_source_lines>: Return
13456 * source-cache.c (source_cache::extract_lines): Handle case where
13457 first_pos==npos. Return std::string.
13458 (source_cache::get_source_lines): Update.
13460 2019-03-14 Tom Tromey <tromey@adacore.com>
13462 * NEWS: Add item for "style sources" commands.
13463 * source-cache.c (source_cache::get_source_lines): Check
13465 * cli/cli-style.c (source_styling): New global.
13466 (_initialize_cli_style): Add "style sources" commands.
13467 (show_style_sources): New function.
13468 * cli/cli-style.h (source_styling): Declare.
13470 2019-03-14 Pedro Alves <palves@redhat.com>
13471 Tom Tromey <tromey@adacore.com>
13473 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13474 * tui/tui-winsource.c (tui_refill_source_window): New function,
13476 (tui_horizontal_source_scroll): ... here. Move some logic.
13477 * cli/cli-style.c (set_style_enabled): Notify new observable.
13478 * tui/tui-hooks.c (tui_redisplay_source): New function.
13479 (tui_attach_detach_observers): Attach or detach
13480 tui_redisplay_source.
13481 * observable.h (source_styling_changed): New observable.
13482 * observable.c: Define source_styling_changed observable.
13484 2019-03-13 Tom Tromey <tromey@adacore.com>
13486 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13487 (i386_gnu_nat_target::store_registers): Update.
13488 * target-debug.h (target_debug_print_std_string): New macro.
13489 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13490 * windows-tdep.c (display_one_tib): Update.
13491 * tui/tui-stack.c (tui_make_status_line): Update.
13492 * top.c (print_inferior_quit_action): Update.
13493 * thread.c (thr_try_catch_cmd): Update.
13494 (add_thread_with_info): Update.
13495 (thread_target_id_str): Update.
13496 (thr_try_catch_cmd): Update.
13497 (thread_command): Update.
13498 (thread_find_command): Update.
13499 * record-btrace.c (record_btrace_target::info_record)
13500 (record_btrace_resume_thread, record_btrace_target::resume)
13501 (record_btrace_cancel_resume, record_btrace_step_thread)
13502 (record_btrace_target::wait, record_btrace_target::wait)
13503 (record_btrace_target::wait, record_btrace_target::stop): Update.
13504 * progspace.c (print_program_space): Update.
13505 * process-stratum-target.c
13506 (process_stratum_target::thread_address_space): Update.
13507 * linux-fork.c (linux_fork_mourn_inferior)
13508 (detach_checkpoint_command, info_checkpoints_command)
13509 (linux_fork_context): Update.
13510 (linux_fork_detach): Update.
13511 (class scoped_switch_fork_info): Update.
13512 (delete_checkpoint_command): Update.
13513 * infrun.c (follow_fork_inferior): Update.
13514 (follow_fork_inferior): Update.
13515 (proceed_after_vfork_done): Update.
13516 (handle_vfork_child_exec_or_exit): Update.
13517 (follow_exec): Update.
13518 (displaced_step_prepare_throw): Update.
13519 (displaced_step_restore): Update.
13520 (start_step_over): Update.
13521 (resume_1): Update.
13522 (clear_proceed_status_thread): Update.
13524 (print_target_wait_results): Update.
13525 (do_target_wait): Update.
13526 (context_switch): Update.
13527 (stop_all_threads): Update.
13528 (restart_threads): Update.
13529 (finish_step_over): Update.
13530 (handle_signal_stop): Update.
13531 (switch_back_to_stepped_thread): Update.
13532 (keep_going_pass_signal): Update.
13533 (print_exited_reason): Update.
13534 (normal_stop): Update.
13535 * inferior.c (inferior_pid_to_str): Change return type.
13536 (print_selected_inferior): Update.
13537 (add_inferior): Update.
13538 (detach_inferior): Update.
13539 * dummy-frame.c (fprint_dummy_frames): Update.
13540 * dcache.c (dcache_info_1): Update.
13541 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13542 (btrace_fetch, btrace_clear): Update.
13543 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13544 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13546 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13547 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13548 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13549 * gdbarch.c, gdbarch.h: Rebuild.
13550 * gdbarch.sh (core_pid_to_str): Change return type.
13551 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13553 (windows_nat_target::pid_to_str): Change return type.
13554 (windows_delete_thread): Update.
13555 (windows_nat_target::attach): Update.
13556 (windows_nat_target::files_info): Update.
13557 * target-delegates.c: Rebuild.
13558 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13560 (sol_thread_target::pid_to_str): Change return type.
13561 * remote.c (class remote_target) <pid_to_str>: Change return
13563 (remote_target::pid_to_str): Change return type.
13564 (extended_remote_target::attach, remote_target::remote_stop_ns)
13565 (remote_target::remote_notif_remove_queued_reply)
13566 (remote_target::push_stop_reply, remote_target::disable_btrace):
13568 (extended_remote_target::attach): Update.
13569 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13571 (gdbsim_target::pid_to_str): Change return type.
13572 * ravenscar-thread.c (struct ravenscar_thread_target)
13573 <pid_to_str>: Change return type.
13574 (ravenscar_thread_target::pid_to_str): Change return type.
13575 * procfs.c (class procfs_target) <pid_to_str>: Change return
13577 (procfs_target::pid_to_str): Change return type.
13578 (procfs_target::attach): Update.
13579 (procfs_target::detach): Update.
13580 (procfs_target::fetch_registers): Update.
13581 (procfs_target::store_registers): Update.
13582 (procfs_target::wait): Update.
13583 (procfs_target::files_info): Update.
13584 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13585 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13587 (nto_procfs_target::pid_to_str): Change return type.
13588 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13589 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13591 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13592 (exit_lwp): Update.
13593 (attach_proc_task_lwp_callback, get_detach_signal)
13594 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13595 (linux_nat_target::resume, wait_lwp, stop_callback)
13596 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13597 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13598 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13599 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13600 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13602 (inf_ptrace_target::attach): Update.
13603 (inf_ptrace_target::files_info): Update.
13604 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13606 (go32_nat_target::pid_to_str): Change return type.
13607 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13608 (gnu_nat_target::wait): Update.
13609 (gnu_nat_target::wait): Update.
13610 (gnu_nat_target::resume): Update.
13611 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13612 (fbsd_nat_target::wait): Update.
13613 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13615 (darwin_nat_target::attach): Update.
13616 * corelow.c (class core_target) <pid_to_str>: Change return type.
13617 (core_target::pid_to_str): Change return type.
13618 * target.c (normal_pid_to_str): Change return type.
13619 (default_pid_to_str): Likewise.
13620 (target_pid_to_str): Change return type.
13621 (target_translate_tls_address): Update.
13622 (target_announce_detach): Update.
13623 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13625 (bsd_uthread_target::pid_to_str): Change return type.
13626 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13628 (bsd_kvm_target::pid_to_str): Change return type.
13629 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13631 (aix_thread_target::pid_to_str): Change return type.
13632 * target.h (struct target_ops) <pid_to_str>: Change return type.
13633 (target_pid_to_str, normal_pid_to_str): Likewise.
13634 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13636 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13638 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13640 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13642 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13644 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13647 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13649 * NEWS: Mention that the new default MI version is 3. Mention
13650 changes to the output of commands and events that deal with
13651 multi-location breakpoints.
13652 * breakpoint.c: Include "mi/mi-out.h".
13653 (print_one_breakpoint): Change output syntax if using MI version
13655 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13657 (mi_multi_location_breakpoint_output_fixed): New.
13658 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13659 (mi_cmd_fix_multi_location_breakpoint_output): New.
13660 (mi_multi_location_breakpoint_output_fixed): New.
13661 * mi/mi-cmds.c (mi_cmds): Register command
13662 -fix-multi-location-breakpoint-output.
13663 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13666 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13668 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13669 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13670 instantiate mi_ui_out based on interpreter name.
13671 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13672 * mi/mi-main.c (mi_load_progress): Likewise.
13674 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13676 * NEWS: Combine separate "New targets" sections for 8.3.
13678 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13680 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13681 (ppcfbsd_init_abi): Install gdbarch
13682 "fetch_tls_load_module_address" and "get_thread_local_address"
13685 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13687 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13688 (riscv_fbsd_init_abi): Install gdbarch
13689 "fetch_tls_load_module_address" and "get_thread_local_address"
13692 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13694 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13695 (i386fbsd_init_abi): Install gdbarch
13696 "fetch_tls_load_module_address" and "get_thread_local_address"
13699 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13701 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13702 (amd64fbsd_init_abi): Install gdbarch
13703 "fetch_tls_load_module_address" and "get_thread_local_address"
13706 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13708 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13709 (struct fbsd_pspace_data): New type.
13710 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13711 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13712 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13713 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13714 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13716 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13718 * gdbtypes.c (lookup_struct_elt): New function.
13719 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13720 * gdbtypes.h (struct struct_elt): New type.
13721 (lookup_struct_elt): New prototype.
13723 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13725 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13726 remove disabled code block.
13728 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13730 * gdbarch.sh (get_thread_local_address): New method.
13731 * gdbarch.h, gdbarch.c: Regenerate.
13732 * target.c (target_translate_tls_address): Use
13733 gdbarch_get_thread_local_address if present instead of
13734 target::get_thread_local_address.
13736 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13738 * target.h (target::get_thread_local_address): Update comment.
13740 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13742 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13743 objfile->separate_debug_objfile_backlink if not NULL.
13745 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13747 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13748 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13749 (amd64bsd_store_inferior_registers): Likewise.
13750 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13751 Enable segment base registers.
13752 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13753 PT_GETFSBASE and PT_GETGSBASE.
13754 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13756 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13757 segment base registers.
13758 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13760 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13762 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13763 Update calls to i386_target_description to add 'segments'
13765 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13766 add segment base registers.
13767 * arch/i386.c (i386_create_target_description): Add 'segments'
13768 parameter to enable segment base registers.
13769 * arch/i386.h (i386_create_target_description): Likewise.
13770 * features/i386/32bit-segments.xml: New file.
13771 * features/i386/32bit-segments.c: Generate.
13772 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13773 call to i386_target_description to add 'segments' parameter.
13774 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13775 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13776 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13777 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13778 if feature is present.
13779 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13780 Add 'segments' parameter to call to i386_target_description.
13781 (i386_target_description): Add 'segments' parameter to enable
13782 segment base registers.
13783 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13784 to call to i386_target_description.
13785 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13786 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13787 Define I386_NUM_REGS.
13788 (i386_target_description): Add 'segments' parameter to enable
13789 segment base registers.
13791 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13794 * source-cache.c: #undef open and close, to avoid unresolved
13795 externals during linking.
13797 2019-03-12 Tom Tromey <tromey@adacore.com>
13799 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13800 const. Add initializers.
13801 (_initialize_remote): Don't initialize ptid globals.
13803 2019-03-12 Pedro Alves <palves@redhat.com>
13805 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13807 2019-03-12 Pedro Alves <palves@redhat.com>
13809 * cp-name-parser.y (main): Remove unused 'len' variable.
13811 2019-03-12 Tom Tromey <tromey@adacore.com>
13813 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13814 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13816 2019-03-12 Tom Tromey <tromey@adacore.com>
13818 * linux-nat.c (iterate_over_lwps): Update.
13819 (stop_callback): Remove parameter.
13820 (stop_wait_callback, detach_callback, resume_set_callback)
13821 (select_singlestep_lwp_callback, set_ignore_sigint)
13822 (status_callback, resumed_callback, resume_clear_callback)
13823 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13825 (linux_nat_target::detach, linux_nat_target::resume)
13826 (linux_stop_and_wait_all_lwps, select_event_lwp)
13827 (linux_nat_filter_event, linux_nat_wait_1)
13828 (linux_nat_target::kill, linux_nat_target::stop)
13829 (linux_nat_target::stop): Update.
13830 (linux_nat_resume_callback): Change type.
13831 (resume_stopped_resumed_lwps, count_events_callback)
13832 (select_event_lwp_callback): Likewise.
13833 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13834 * arm-linux-nat.c (struct update_registers_data): Remove.
13835 (update_registers_callback): Change type.
13836 (arm_linux_insert_hw_breakpoint1): Update.
13837 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13839 (x86_linux_dr_set_addr): Update.
13840 (x86_linux_dr_set_control): Update.
13841 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13842 (iterate_over_lwps): Use gdb::function_view.
13843 * nat/aarch64-linux-hw-point.c (struct
13844 aarch64_dr_update_callback_param): Remove.
13845 (debug_reg_change_callback): Change type.
13846 (aarch64_notify_debug_reg_change): Update.
13847 * s390-linux-nat.c (s390_refresh_per_info): Update.
13849 2019-03-11 Tom Tromey <tromey@adacore.com>
13851 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13852 redundant assignment to "this_cu".
13854 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13856 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13858 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13860 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13862 (rank_one_type): ... this.
13864 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13866 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13868 (rank_one_type): ... this.
13870 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13872 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13874 (rank_one_type): ... this.
13876 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13878 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13880 (rank_one_type): ... this.
13882 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13884 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13886 (rank_one_type): ... this.
13888 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13890 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13892 (rank_one_type): ... this.
13894 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13896 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13898 (rank_one_type): ... this.
13900 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13902 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13904 (rank_one_type): ... this.
13906 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13908 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13910 (rank_one_type): ... this.
13912 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13914 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13916 (rank_one_type): ... this.
13918 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13920 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13922 (rank_one_type): ... this.
13924 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13926 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13928 (rank_one_type): ... this.
13930 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13932 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13933 inferior-events' shows the example events.
13935 2019-03-08 Eli Zaretskii <eliz@gnu.org>
13937 Support styling on native MS-Windows console
13940 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13941 on MS-Windows if $TERM is not defined.
13943 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13945 * posix-hdep.c (gdb_console_fputs):
13946 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13948 * ui-file.h (gdb_console_fputs): Add prototype.
13950 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13951 back to fputs only if the former returns zero.
13953 2019-03-07 Tom Tromey <tom@tromey.com>
13955 * symmisc.c (print_symbol_bcache_statistics): Update.
13956 (print_objfile_statistics): Update.
13957 * symfile.c (allocate_symtab): Update.
13958 * stabsread.c: Don't include bcache.h.
13959 * psymtab.h (struct psymbol_bcache): Don't declare.
13960 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13961 (psymbol_bcache_init, psymbol_bcache_free)
13962 (psymbol_bcache_get_bcache): Don't declare.
13963 * psymtab.c (struct psymbol_bcache): Remove.
13964 (psymtab_storage::psymtab_storage): Update.
13965 (psymtab_storage::~psymtab_storage): Update.
13966 (psymbol_bcache_init, psymbol_bcache_free)
13967 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13968 (add_psymbol_to_bcache): Update.
13969 (allocate_psymtab): Update.
13970 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13971 macro_cache>: No longer pointers.
13972 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13973 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13974 * macrotab.c (macro_bcache): Update.
13975 * macroexp.c: Don't include bcache.h.
13976 * gdbtypes.c (check_types_worklist): Update.
13977 (types_deeply_equal): Remove TRY/CATCH. Update.
13978 * elfread.c (elf_symtab_read): Update.
13979 * dwarf2read.c: Don't include bcache.h.
13980 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13981 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13982 (print_bcache_statistics, bcache_memory_used): Don't declare.
13983 (struct bcache): Move from bcache.c. Add constructor, destructor,
13984 methods. Rename all data members.
13985 * bcache.c (struct bcache): Move to bcache.h.
13986 (bcache::expand_hash_table): Rename from expand_hash_table.
13988 (bcache::insert): Rename from bcache_full.
13989 (bcache::compare): Rename from bcache_compare.
13990 (bcache_xmalloc): Remove.
13991 (bcache::~bcache): Rename from bcache_xfree.
13992 (bcache::print_statistics): Rename from print_bcache_statistics.
13993 (bcache::memory_used): Rename from bcache_memory_used.
13995 2019-03-07 Pedro Alves <palves@redhat.com>
13997 * infrun.c (normal_stop): Also check for
13998 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14000 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14002 * f-lang.c (value_from_host_double): Moved to...
14003 * value.c (value_from_host_double): ...here.
14004 * value.h (value_from_host_double): Declare.
14005 * guile/scm-math.c (vlscm_convert_typed_number): Use
14006 value_from_host_double.
14007 (vlscm_convert_number): Likewise.
14008 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14009 * python/py-value.c (convert_value_from_python): Likewise.
14011 2019-03-06 Tom Tromey <tom@tromey.com>
14013 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14015 2019-03-06 Tom Tromey <tom@tromey.com>
14017 * utils.h (free_current_contents): Don't declare.
14018 * utils.c (free_current_contents): Remove.
14020 2019-03-06 Tom Tromey <tom@tromey.com>
14022 * top.c (quit_force): Update.
14023 * main.c (captured_command_loop): Update.
14024 * common/new-op.c (operator new): Update.
14025 * common/common-exceptions.c (struct catcher)
14026 <save_cleanup_chain>: Remove member.
14027 (exceptions_state_mc_init): Update.
14028 (exception_try_scope_entry): Return nullptr.
14029 (exception_try_scope_exit, exception_rethrow)
14030 (throw_exception_sjlj, throw_exception_cxx): Update.
14031 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14032 (all_cleanups, do_cleanups, discard_cleanups)
14033 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14034 (restore_cleanups, restore_final_cleanups): Don't declare.
14035 (do_final_cleanups): Remove parameter.
14036 * common/cleanups.c (cleanup_chain, make_cleanup)
14037 (make_cleanup_dtor, all_cleanups, do_cleanups)
14038 (discard_my_cleanups, discard_cleanups)
14039 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14040 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14041 (null_cleanup): Remove.
14042 (do_final_cleanups): Remove parameter.
14044 2019-03-06 Tom Tromey <tom@tromey.com>
14046 * remote.c (remote_target::remote_parse_stop_reply): Use
14047 unique_xmalloc_ptr.
14049 2019-03-06 Tom Tromey <tom@tromey.com>
14051 * stabsread.c (struct stabs_field_info): Rename from field_info.
14052 <list, fnlist>: Add initializers.
14053 <obstack>: New member.
14054 (read_member_functions, read_struct_fields, read_baseclasses):
14055 Allocate on obstack. Don't use cleanups.
14056 (read_one_struct_field, read_member_functions, read_struct_fields)
14057 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14058 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14059 (read_struct_type): Update.
14061 2019-03-06 Tom Tromey <tom@tromey.com>
14063 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14064 * common/filestuff.h (make_cleanup_close): Don't declare.
14065 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14068 2019-03-06 Tom Tromey <tom@tromey.com>
14070 * solib-aix.c: Use make_scope_exit.
14072 2019-03-06 Tom Tromey <tom@tromey.com>
14074 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14075 Use make_scope_exit.
14077 2019-03-06 Tom Tromey <tom@tromey.com>
14079 * solib-svr4.c (disable_probes_interface): Remove parameter.
14080 (svr4_handle_solib_event): Use make_scope_exit.
14082 2019-03-06 Tom Tromey <tom@tromey.com>
14084 * remote.c (struct stop_reply_deleter): Remove.
14085 (stop_reply_up): Update.
14086 (struct stop_reply): Derive from notif_event. Don't typedef.
14087 <regcache>: Now a std::vector.
14088 (stop_reply_xfree): Remove.
14089 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14090 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14091 (remote_target::discard_pending_stop_replies): Use delete.
14092 (remote_target::remote_parse_stop_reply): Update.
14093 (remote_target::process_stop_reply): Update.
14094 * remote-notif.h (struct notif_event): Add virtual destructor.
14095 Remove "dtr" member.
14096 (struct notif_client) <alloc_event>: Return a unique_ptr.
14097 (notif_event_xfree): Don't declare.
14098 (notif_event_up): New typedef.
14099 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14100 (notif_event_xfree, do_notif_event_xfree): Remove.
14101 (remote_notif_state_xfree): Update.
14103 2019-03-06 Tom Tromey <tom@tromey.com>
14105 * infrun.c (displaced_step_clear_cleanup): Now a
14106 forward_scope_exit type.
14107 (displaced_step_prepare_throw): Update.
14108 (displaced_step_fixup): Update.
14110 2019-03-06 Tom Tromey <tom@tromey.com>
14112 * inferior.h (class inferior): Update comment.
14113 * gdbthread.h (class thread_info): Update comment.
14115 2019-03-06 Joel Brobecker <brobecker@adacore.com>
14116 Tom Tromey <tom@tromey.com>
14118 * stabsread.h (struct stab_section_list): Remove.
14119 (coffstab_build_psymtabs): Update.
14120 * dbxread.c (symbuf_sections): Now a std::vector.
14121 (sect_idx): New global.
14122 (fill_symbuf): Update.
14123 (coffstab_build_psymtabs): Change type of stabsects parameter.
14125 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14127 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14128 (coff_locate_sections): Update.
14129 (coff_symfile_read): Remove cleanups. Update.
14130 (init_stringtab): Add storage parameter.
14131 (free_stringtab, free_stringtab_cleanup): Remove.
14132 (init_lineno): Add storage parameter.
14133 (free_linetab, free_linetab_cleanup): Remove.
14135 2019-03-06 Pedro Alves <palves@redhat.com>
14137 * linux-fork.c (fork_info::clobber_regs): Delete.
14138 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14139 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14141 (scoped_switch_fork_info::scoped_switch_fork_info)
14142 (checkpoint_command, linux_fork_context): Adjust
14143 fork_save_infrun_state calls.
14145 2019-03-06 Pedro Alves <palves@redhat.com>
14147 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14148 (inf_has_multiple_threads): Return 'bool' and rewrite using
14149 inferior_info::threads().
14151 2019-03-06 Pedro Alves <palves@redhat.com>
14153 * linux-fork.c: Include <list>.
14154 (fork_list): Now a std::list instance.
14155 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14156 (forks_exist_p, find_last_fork): Adjust.
14157 (new_fork): Delete.
14159 (add_fork): Adjust.
14160 (free_fork): Delete, folded into fork_info::~fork_info().
14161 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14163 (init_fork_list): Delete.
14164 (linux_fork_killall, linux_fork_mourn_inferior)
14165 (linux_fork_detach, info_checkpoints_command): Adjust.
14166 (_initialize_linux_fork): No longer call init_fork_list.
14168 2019-03-06 Pedro Alves <palves@redhat.com>
14170 * linux-fork.c (new_fork): New, split out of ...
14171 (add_fork): ... this. Return void. Move "first fork" special
14172 case from here, to ...
14173 (checkpoint_command): ... here.
14174 * linux-linux.h (add_fork): Return void.
14176 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14178 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14180 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14181 Chris January <chris.january@arm.com>
14182 David Lecomber <david.lecomber@arm.com>
14184 * f-exp.y: New token, UNOP_INTRINSIC.
14185 (exp): New pattern using UNOP_INTRINSIC token.
14186 (f77_keywords): Add 'abs' keyword.
14187 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14188 (value_from_host_double): New function.
14189 (evaluate_subexp_f): Support UNOP_ABS.
14191 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14193 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14196 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14198 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14199 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14200 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14202 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14204 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14206 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14207 Chris January <chris.january@arm.com>
14209 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14210 * f-exp.y: Define 'KIND' token.
14211 (exp): New pattern for KIND expressions.
14212 (ptype): Handle types with a kind extension.
14213 (direct_abs_decl): Extend to spot kind extensions.
14214 (f77_keywords): Add 'kind' to the list.
14215 (push_kind_type): New function.
14216 (convert_to_kind_type): New function.
14217 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14218 * parse.c (operator_length_standard): Likewise.
14219 * parser-defs.h (enum type_pieces): Add tp_kind.
14220 * std-operator.def: Add UNOP_KIND.
14222 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14224 * f-exp.y (f_parse): Set yydebug.
14226 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14228 * f-lang.c (evaluate_subexp_f): New function.
14229 (exp_descriptor_f): New global.
14230 (f_language_defn): Use exp_descriptor_f instead of
14231 exp_descriptor_standard.
14233 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14235 * f-exp.y (struct token): Add comments.
14236 (dot_ops): Remove uppercase versions and the end marker.
14237 (f77_keywords): Likewise.
14238 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14239 entries in the dot_ops array are case insensitive, and use
14240 strncasecmp to compare strings. Also some whitespace cleanup in
14241 this area. Similar for the f77_keywords array, except entries in
14242 this list might be case sensitive.
14244 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14246 * f-exp.y (struct f77_boolean_val): Add comments.
14247 (boolean_values): Remove uppercase versions, and end marker.
14248 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14249 and use strncasecmp to achieve case insensitivity. Additionally,
14250 perform whitespace cleanup around this code.
14252 2019-03-06 Tom Tromey <tromey@adacore.com>
14254 * remote-sim.c (gdbsim_target_open): Use result of
14257 2019-03-06 Richard Bunt <richard.bunt@arm.com>
14258 Dirk Schubert <dirk.schubert@arm.com>
14259 Chris January <chris.january@arm.com>
14261 * eval.c (evaluate_subexp_standard): Call Fortran argument
14263 * f-lang.c (struct value): A value which can be passed into a
14264 Fortran function call.
14265 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14267 (struct type): Value ready for a Fortran function call.
14268 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14270 * f-lang.h (fortran_argument_convert): Declaration.
14271 (fortran_preserve_arg_pointer): Declaration.
14272 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14274 2019-03-05 Tom Tromey <tromey@adacore.com>
14276 * python/py-prettyprint.c (print_string_repr): Remove #if.
14277 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14279 2019-03-05 Tom Tromey <tromey@adacore.com>
14281 * target.c (the_dummy_target): Move later. Change type to
14283 (initialize_targets): Don't initialize the_dummy_target.
14285 2019-03-05 Tom Tromey <tromey@adacore.com>
14287 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14288 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14290 2019-03-05 Tom Tromey <tromey@adacore.com>
14292 * windows-nat.c (windows_nat_target::attach)
14293 (windows_nat_target::detach): Don't call gdb_flush.
14294 * valprint.c (generic_val_print, val_print, val_print_string):
14295 Don't call gdb_flush.
14296 * utils.c (defaulted_query): Don't call gdb_flush.
14297 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14298 * target.c (target_announce_detach): Don't call gdb_flush.
14299 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14300 * remote.c (extended_remote_target::attach): Don't call
14302 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14303 * printcmd.c (do_examine): Don't call gdb_flush.
14304 (info_display_command): Don't call gdb_flush.
14305 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14306 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14307 * memattr.c (info_mem_command): Don't call gdb_flush.
14308 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14309 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14310 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14311 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14312 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14313 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14314 (gnu_nat_target::detach): Don't call gdb_flush.
14315 * f-valprint.c (f_val_print): Don't call gdb_flush.
14316 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14317 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14318 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14320 * c-valprint.c (c_val_print): Don't call gdb_flush.
14321 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14323 2019-03-05 Tom Tromey <tromey@adacore.com>
14325 * varobj.c (update_dynamic_varobj_children): Update.
14326 (install_default_visualizer): Use reset, not release.
14327 * value.c (set_internalvar): Update.
14328 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14329 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14330 ATTRIBUTE_UNUSED_RESULT.
14332 2019-03-05 Tom Tromey <tromey@adacore.com>
14334 * remote.c (class scoped_remote_fd) <release>: Add
14335 ATTRIBUTE_UNUSED_RESULT.
14337 2019-03-05 Tom Tromey <tromey@adacore.com>
14339 * macroexp.c (struct macro_buffer) <release>: Add
14340 ATTRIBUTE_UNUSED_RESULT.
14342 2019-03-05 Tom Tromey <tromey@adacore.com>
14344 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14345 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14346 ATTRIBUTE_UNUSED_RESULT.
14348 2019-03-05 Tom Tromey <tromey@adacore.com>
14350 * common/scoped_fd.h (class scoped_fd) <release>: Add
14351 ATTRIBUTE_UNUSED_RESULT.
14353 2019-03-05 Tom Tromey <tromey@adacore.com>
14355 * parser-defs.h (struct parser_state) <release>: Add
14356 ATTRIBUTE_UNUSED_RESULT.
14358 2019-03-05 Tom Tromey <tromey@adacore.com>
14360 * utils.h (class gdb_argv) <release>: Add
14361 ATTRIBUTE_UNUSED_RESULT.
14362 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14364 2019-03-02 Eli Zaretskii <eliz@gnu.org>
14366 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14367 for-loop range, to avoid compiler warnings.
14369 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14370 avoid compiler warnings about unused variables.
14372 * NEWS: Mention end of support for native debugging on MS-Windows
14376 * common/netstuff.c:
14377 * gdbserver/gdbreplay.c
14378 * gdbserver/remote-utils.c:
14380 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14381 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14382 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14383 'getaddrinfo' and 'freeaddrinfo' were not available before
14384 Windows XP, and mingw.org's MinGW headers by default define
14385 _WIN32_WINNT to 0x500.
14387 2019-03-01 Gary Benson <gbenson@redhat.com>
14389 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14391 2019-02-28 Brian Vandenberg <phantall@gmail.com>
14392 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14395 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14396 set_sigint_trap, clear_sigint_trap.
14398 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14400 * target.c (target_detach): Clear the regcache and the
14403 2019-02-27 Pedro Alves <palves@redhat.com>
14405 * utils.c (set_screen_size): When we cap the height/width sizes,
14406 tweak the corresponding command variable to show "unlimited":
14408 2019-02-27 Saagar Jha <saagar@saagarjha.com>
14409 Pedro Alves <palves@redhat.com>
14411 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14412 before calling rl_set_screen_size.
14414 2019-02-27 Tom Tromey <tromey@adacore.com>
14416 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14418 * python/py-value.c: Remove Python 2.4 workaround.
14419 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14421 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14422 Python 2.4 workaround.
14423 * python/python-internal.h: Remove Python 2.4 comment.
14424 (Py_ssize_t): Don't define.
14425 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14426 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14427 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14428 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14429 * python/python.c (do_start_initialization): Remove Python 2.4
14431 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14432 (print_children): Remove Python 2.4 workaround.
14433 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14435 (CHARBUFFERPROC_NAME): Remove.
14436 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14437 Python 2.4 workaround.
14439 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14441 * NEWS: Note minimum Python version.
14443 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14445 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14446 code from these functions. Remove corresponding ifdefs. Use
14447 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14448 Remove gotos and target of gotos.
14449 (infpy_search_memory): Likewise.
14451 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14453 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14454 (hppa_gdbarch_init): Don't register deleted functions with
14457 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14459 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14460 (h8300_unwind_sp): Delete.
14461 (h8300_dummy_id): Delete.
14462 (h8300_gdbarch_init): Don't register deleted functions with
14465 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14467 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14468 (ft32_unwind_pc): Delete.
14469 (ft32_unwind_sp): Delete.
14470 (ft32_gdbarch_init): Don't register deleted functions with
14473 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14475 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14476 (frv_unwind_pc): Delete.
14477 (frv_unwind_sp): Delete.
14478 (frv_gdbarch_init): Don't register deleted functions with
14481 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14483 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14484 (riscv_unwind_pc): Delete.
14485 (riscv_unwind_sp): Delete.
14486 (riscv_gdbarch_init): Don't register deleted functions with
14489 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14491 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14492 (csky_unwind_pc): Delete.
14493 (csky_unwind_sp): Delete.
14494 (csky_gdbarch_init): Don't register deleted functions with
14497 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14499 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14500 (cris_unwind_pc): Delete.
14501 (cris_unwind_sp): Delete.
14502 (cris_gdbarch_init): Don't register deleted functions with
14505 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14507 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14508 (bfin_unwind_pc): Delete.
14509 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14511 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14513 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14514 (arm_unwind_pc): Delete.
14515 (arm_unwind_sp): Delete.
14516 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14518 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14520 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14521 (arc_unwind_pc): Delete.
14522 (arc_unwind_sp): Delete.
14523 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14525 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14527 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14528 (alpha_unwind_pc): Delete.
14529 (alpha_gdbarch_init): Don't register deleted functions with
14532 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14534 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14535 (aarch64_unwind_pc): Delete.
14536 (aarch64_unwind_sp): Delete.
14537 (aarch64_gdbarch_init): Don't register deleted functions with
14540 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14542 * gdbtypes.c (type_align): Don't consider static members when
14543 computing structure alignment.
14545 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14547 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14548 return 0 for other types.
14549 * arch-utils.c (default_type_align): Always return 0.
14550 * gdbarch.h: Regenerate.
14551 * gdbarch.sh (type_align): Extend comment.
14552 * gdbtypes.c (type_align): Add additional comments, always call
14553 gdbarch_type_align before applying the default rules.
14554 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14555 generic code will then apply a suitable default.
14556 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14557 types, return 0 for other types.
14559 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14561 * NEWS: Create a new section for the next release branch.
14562 Rename the section of the current branch, now that it has
14565 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14567 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14568 * version.in: Bump version to 8.3.50.DATE-git.
14570 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14572 * aix-thread.c (ptid_cmp): Remove unused variable.
14573 (get_signaled_thread): Likewise.
14574 (store_regs_user_thread): Likewise.
14575 (store_regs_kernel_thread): Likewise.
14576 (fetch_regs_kernel_thread): Remove shadowed variable.
14578 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14580 * features/riscv/32bit-cpu.xml: Add register numbers.
14581 * features/riscv/32bit-fpu.c: Regenerate.
14582 * features/riscv/32bit-fpu.xml: Add register numbers.
14583 * features/riscv/64bit-cpu.xml: Add register numbers.
14584 * features/riscv/64bit-fpu.c: Regenerate.
14585 * features/riscv/64bit-fpu.xml: Add register numbers.
14587 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14589 * NEWS: Mention two argument form of gdb.Value constructor.
14590 * python/py-value.c (convert_buffer_and_type_to_value): New
14592 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14593 Add support for handling an optional second argument. Call
14594 convert_buffer_and_type_to_value as appropriate.
14595 * python/python-internal.h (Py_buffer_deleter): New struct.
14596 (Py_buffer_up): New typedef.
14598 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14600 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14601 instead of releasing ownership.
14603 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14605 * dwarf2read.c (open_and_init_dwp_file): Call
14606 elf_numsections instead of bfd_count_sections to initialize
14607 dwp_file->num_sections.
14609 2019-02-25 Tom Tromey <tromey@adacore.com>
14611 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14613 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14615 * gcore.in: Add '--readnever' option when invoking GDB.
14617 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14619 * MAINTAINERS: Update my email address.
14621 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14623 * build-id.c (build_id_to_debug_bfd_1): New function.
14624 (build_id_to_debug_bfd): Look for separate debug file in
14627 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14629 * gdbarch.sh: Update the copyright year range that is placed into
14632 2019-02-22 Keith Seitz <keiths@redhat.com>
14635 * linespec.c (create_sals_line_offset): Search for the default
14636 symtab's filename instead of its fullname.
14638 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14640 * NEWS: Update style defaults.
14642 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14644 * main.c (captured_main_1): Disable styling in batch mode.
14646 2019-02-20 Tom Tromey <tom@tromey.com>
14648 * symtab.c (symtab_symbol_info): Fix typos.
14650 2019-02-20 Tom Tromey <tromey@adacore.com>
14652 * findcmd.c (_initialize_mem_search): Use upper case for
14653 metasyntactic variables.
14655 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14657 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14658 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14660 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14662 * top.h (source_file_name): Change to std::string.
14663 * top.c (source_file_name): Likewise.
14664 (command_line_input): Adjust.
14665 * cli/cli-script.c (script_from_file): Adjust.
14667 2019-02-19 Tom Tromey <tromey@adacore.com>
14669 * ravenscar-thread.c
14670 (ravenscar_thread_target::update_thread_list): Don't call
14671 ada_build_task_list.
14672 * ada-lang.h (ada_build_task_list): Don't declare.
14673 * ada-tasks.c (struct ada_tasks_inferior_data)
14674 <task_list_valid_p>: Now bool.
14675 (read_known_tasks, ada_task_list_changed)
14676 (ada_tasks_invalidate_inferior_data): Update.
14677 (read_known_tasks_array): Return bool.
14678 (read_known_tasks_list): Likewise.
14679 (read_known_tasks): Return void.
14680 (ada_build_task_list): Now static.
14682 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14684 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14685 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14687 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14689 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14690 variant for ada_tasks_pspace_data_handle and
14691 ada_tasks_inferior_data_handle.
14692 (ada_tasks_pspace_data_cleanup): New function.
14693 (ada_tasks_inferior_data_cleanup): New function.
14695 2019-02-17 Tom Tromey <tom@tromey.com>
14697 * macrotab.h (macro_source_fullname): Return a std::string.
14698 * macrotab.c (macro_include, check_for_redefinition)
14699 (macro_undef, macro_lookup_definition, foreach_macro)
14700 (foreach_macro_in_scope): Update.
14701 (macro_source_fullname): Return a std::string.
14702 * macrocmd.c (show_pp_source_pos): Update.
14704 2019-02-17 Tom Tromey <tom@tromey.com>
14706 * macrocmd.c (show_pp_source_pos): Style the file names.
14708 2019-02-17 Tom Tromey <tom@tromey.com>
14711 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14713 2019-02-17 Tom Tromey <tom@tromey.com>
14715 * ada-lang.c (user_select_syms): Use filtered printing.
14716 * utils.c (wrap_style): New global.
14717 (desired_style): Remove.
14718 (emit_style_escape): Add stream parameter.
14719 (set_output_style, reset_terminal_style, prompt_for_continue):
14721 (flush_wrap_buffer): Only flush gdb_stdout.
14722 (wrap_here): Set wrap_style.
14723 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14724 treat escape sequences as a character. Change when wrap buffer is
14726 (fputs_styled): Do not set the output style when the default is
14728 * ui-style.h (struct ui_file_style) <is_default>: New method.
14729 * source.c (print_source_lines_base): Emit escape sequences in one
14732 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14734 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14735 integers and enumeration types.
14737 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14739 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14740 instead of lookup_symbol_in_language
14741 (do_exact_match): New function.
14742 (ada_get_symbol_name_matcher): Return do_exact_match when
14743 doing a verbatim match.
14745 2019-02-15 Tom Tromey <tromey@adacore.com>
14747 * ravenscar-thread.c (ravenscar_thread_target::resume)
14748 (ravenscar_thread_target::wait): Special case wildcard requests.
14750 2019-02-15 Tom Tromey <tromey@adacore.com>
14752 * ravenscar-thread.c (base_ptid): Remove.
14753 (struct ravenscar_thread_target) <close>: New method.
14754 <m_base_ptid>: New member.
14755 <update_inferior_ptid, active_task, task_is_currently_active,
14756 runtime_initialized>: Declare methods.
14757 <ravenscar_thread_target>: Add constructor.
14758 (ravenscar_thread_target::task_is_currently_active)
14759 (ravenscar_thread_target::update_inferior_ptid)
14760 (ravenscar_runtime_initialized): Rename. Now methods.
14761 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14762 (ravenscar_thread_target::update_thread_list): Update.
14763 (ravenscar_thread_target::active_task): Now method.
14764 (ravenscar_thread_target::store_registers)
14765 (ravenscar_thread_target::prepare_to_store)
14766 (ravenscar_thread_target::prepare_to_store)
14767 (ravenscar_thread_target::mourn_inferior): Update.
14768 (ravenscar_inferior_created): Use "new" to create target.
14769 (ravenscar_thread_target::get_ada_task_ptid): Update.
14770 (_initialize_ravenscar): Don't initialize base_ptid.
14771 (ravenscar_ops): Remove global.
14773 2019-02-15 Tom Tromey <tromey@adacore.com>
14775 * target.h (push_target): Declare new overload.
14776 * target.c (push_target): New overload, taking an rvalue reference.
14777 * remote.c (remote_target::open_1): Use push_target overload.
14778 * corelow.c (core_target_open): Use push_target overload.
14780 2019-02-15 Tom Tromey <tromey@adacore.com>
14782 * ravenscar-thread.c (is_ravenscar_task)
14783 (ravenscar_task_is_currently_active): Return bool.
14784 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14785 (_initialize_ravenscar): Remove "(void)".
14786 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14789 2019-02-15 Tom Tromey <tromey@adacore.com>
14791 * ravenscar-thread.c (ravenscar_runtime_initializer)
14792 (has_ravenscar_runtime, get_running_thread_id)
14793 (ravenscar_thread_target::resume): Fix indentation.
14795 2019-02-15 Tom Tromey <tromey@adacore.com>
14797 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14798 from ravenscar_arch_ops.
14799 (sparc_ravenscar_ops::fetch_registers)
14800 (sparc_ravenscar_ops::store_registers): Now methods.
14801 (sparc_ravenscar_prepare_to_store): Remove.
14802 (sparc_ravenscar_ops): Redefine.
14803 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14804 methods and destructor. Remove members.
14805 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14806 (ravenscar_thread_target::store_registers)
14807 (ravenscar_thread_target::prepare_to_store): Update.
14808 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14810 (struct ppc_ravenscar_powerpc_ops): Derive from
14811 ravenscar_arch_ops.
14812 (ppc_ravenscar_powerpc_ops::fetch_registers)
14813 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14814 (ppc_ravenscar_powerpc_ops): Redefine.
14815 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14816 (ppc_ravenscar_e500_ops::fetch_registers)
14817 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14818 (ppc_ravenscar_e500_ops): Redefine.
14819 * aarch64-ravenscar-thread.c
14820 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14821 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14822 (aarch64_ravenscar_fetch_registers)
14823 (aarch64_ravenscar_store_registers): Now methods.
14824 (aarch64_ravenscar_ops): Redefine.
14826 2019-02-15 Tom Tromey <tromey@adacore.com>
14828 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14829 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14830 (ravenscar_thread_target::stopped_by_watchpoint)
14831 (ravenscar_thread_target::stopped_data_address)
14832 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14834 2019-02-15 Tom Tromey <tromey@adacore.com>
14836 * ravenscar-thread.c: Fix some typos.
14838 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14839 Tom Tromey <tromey@adacore.com>
14841 * ada-lang.c (ada_exception_sal): Change addr_string to a
14843 (create_ada_exception_catchpoint): Update.
14845 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14846 Tom Tromey <tromey@adacore.com>
14848 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14849 (bp_location_ops): Remove.
14850 (base_breakpoint_allocate_location): Update.
14851 (free_bp_location): Update.
14852 * ada-lang.c (class ada_catchpoint_location)
14853 <ada_catchpoint_location>: Remove ops parameter.
14854 (ada_catchpoint_location_dtor): Remove.
14855 (ada_catchpoint_location_ops): Remove.
14856 (allocate_location_exception): Update.
14857 * breakpoint.h (struct bp_location_ops): Remove.
14858 (class bp_location) <bp_location>: Remove bp_location_ops
14860 <~bp_location>: Add destructor.
14863 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14864 Pedro Alves <palves@redhat.com>
14866 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14869 2019-02-14 David Michael <fedora.dm0@gmail.com>
14870 Samuel Thibault <samuel.thibault@gnu.org>
14871 Thomas Schwinge <thomas@codesourcery.com>
14873 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14874 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14876 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14878 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14879 (check_empty): Use "const char *".
14881 * gnu-nat.c (gnu_nat_target::detach): Instead of
14882 'detach_inferior (pid)' call
14883 'detach_inferior (find_inferior_pid (pid))'.
14885 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14886 'nat/fork-inferior.o'.
14887 * gnu-nat.c: #include "nat/fork-inferior.h".
14889 * gnu-nat.c (gnu_nat_target::detach): Instead of
14890 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14891 * gnu-nat.h: #include "inf-child.h".
14892 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14893 'i386_gnu_nat_target::fetch_registers'.
14894 (gnu_store_registers): Rename/move to
14895 'i386_gnu_nat_target::store_registers'.
14897 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14898 * gnu-nat.h (mach_thread_info): New function.
14899 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14901 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14903 2019-02-14 Frederic Konrad <konrad@adacore.com>
14905 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14907 2019-02-14 Joel Brobecker <brobecker@adacore.com>
14909 * windows-nat.c (windows_add_thread): Add new parameter
14910 "main_thread_p" with default value set to false. Update
14911 function documentation as well as all callers.
14912 (windows_delete_thread): Likewise.
14913 (fake_create_process): Update call to windows_add_thread.
14914 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14915 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14916 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14917 call to windows_delete_thread.
14919 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14921 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14923 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14925 * symfile.c (find_separate_debug_file): Use canonical path of
14926 sysroot with child_path instead of gdb_sysroot if it is valid.
14928 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14930 * symfile.c (find_separate_debug_file): Use child_path to
14931 determine if an object file is under a sysroot.
14933 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14935 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14936 unittests/child-path-selftests.c.
14937 * common/pathstuff.c (child_path): New function.
14938 * common/pathstuff.h (child_path): New prototype.
14939 * unittests/child-path-selftests.c: New file.
14941 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14943 * symfile.c (find_separate_debug_file): Look for separate debug
14944 files in debug directories under the sysroot.
14946 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14948 * symtab.h (struct minimal_symbol data_p): New const method.
14949 (struct minimal_symbol text_p): Likewise.
14950 * symtab.c (output_source_filename): Use file name style
14951 to print file name.
14952 (print_symbol_info): Likewise.
14953 (print_msymbol_info): Use address style to print addresses.
14954 Use function name style to print executable text symbols.
14955 (expand_symtab_containing_pc): Use data_p.
14956 (find_pc_sect_compunit_symtab): Likewise.
14958 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14960 * breakpoint.c (describe_other_breakpoints): Use address style
14961 to print addresses.
14962 (say_where): Likewise.
14964 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14966 * ada-typeprint.c (print_func_type): Print function name
14967 style to print function name.
14968 * c-typeprint.c (c_print_type_1): Likewise.
14970 2019-02-11 Alan Hayward <alan.hayward@arm.com>
14972 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14975 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14977 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14980 2019-02-10 Joel Brobecker <brobecker@adacore.com>
14982 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14983 TYPE_CODE_REF types.
14985 2019-02-08 Jim Wilson <jimw@sifive.com>
14987 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14988 (riscv_linux_fregset): New.
14989 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14991 2019-02-07 Tom Tromey <tom@tromey.com>
14993 * thread.c (thread_cancel_execution_command): Update.
14994 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14996 (struct thread_fsm_ops): Remove.
14997 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14998 (thread_fsm_should_stop, thread_fsm_return_value)
14999 (thread_fsm_set_finished, thread_fsm_finished_p)
15000 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15002 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15003 * infrun.c (clear_proceed_status_thread)
15004 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15005 (print_stop_event): Update.
15006 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15008 (step_command_fsm_ops): Remove.
15009 (new_step_command_fsm): Remove.
15011 (step_command_fsm::should_stop): Rename from
15012 step_command_fsm_should_stop.
15013 (step_command_fsm::clean_up): Rename from
15014 step_command_fsm_clean_up.
15015 (step_command_fsm::do_async_reply_reason): Rename from
15016 step_command_fsm_async_reply_reason.
15017 (struct until_next_fsm): Inherit from thread_fsm. Add
15019 (until_next_fsm_ops): Remove.
15020 (new_until_next_fsm): Remove.
15021 (until_next_fsm::should_stop): Rename from
15022 until_next_fsm_should_stop.
15023 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15024 (until_next_fsm::do_async_reply_reason): Rename from
15025 until_next_fsm_async_reply_reason.
15026 (struct finish_command_fsm): Inherit from thread_fsm. Add
15027 constructor. Change type of breakpoint.
15028 (finish_command_fsm_ops): Remove.
15029 (new_finish_command_fsm): Remove.
15030 (finish_command_fsm::should_stop): Rename from
15031 finish_command_fsm_should_stop.
15032 (finish_command_fsm::clean_up): Rename from
15033 finish_command_fsm_clean_up.
15034 (finish_command_fsm::return_value): Rename from
15035 finish_command_fsm_return_value.
15036 (finish_command_fsm::do_async_reply_reason): Rename from
15037 finish_command_fsm_async_reply_reason.
15038 (finish_command): Update.
15039 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15041 (call_thread_fsm_ops): Remove.
15042 (call_thread_fsm::call_thread_fsm): Rename from
15043 new_call_thread_fsm.
15044 (call_thread_fsm::should_stop): Rename from
15045 call_thread_fsm_should_stop.
15046 (call_thread_fsm::should_notify_stop): Rename from
15047 call_thread_fsm_should_notify_stop.
15048 (run_inferior_call, call_function_by_hand_dummy): Update.
15049 * cli/cli-interp.c (should_print_stop_to_console): Update.
15050 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15051 Add constructor. Change type of location_breakpoint,
15053 (until_break_fsm_ops): Remove.
15054 (new_until_break_fsm): Remove.
15055 (until_break_fsm::should_stop): Rename from
15056 until_break_fsm_should_stop.
15057 (until_break_fsm::clean_up): Rename from
15058 until_break_fsm_clean_up.
15059 (until_break_fsm::do_async_reply_reason): Rename from
15060 until_break_fsm_async_reply_reason.
15061 (until_break_command): Update.
15062 * thread-fsm.c: Remove.
15063 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15065 2019-02-07 Tom Tromey <tom@tromey.com>
15067 * yy-remap.h: Add include guard.
15068 * xtensa-tdep.h: Add include guard.
15069 * xcoffread.h: Rename include guard.
15070 * varobj-iter.h: Add include guard.
15071 * tui/tui.h: Rename include guard.
15072 * tui/tui-winsource.h: Rename include guard.
15073 * tui/tui-wingeneral.h: Rename include guard.
15074 * tui/tui-windata.h: Rename include guard.
15075 * tui/tui-win.h: Rename include guard.
15076 * tui/tui-stack.h: Rename include guard.
15077 * tui/tui-source.h: Rename include guard.
15078 * tui/tui-regs.h: Rename include guard.
15079 * tui/tui-out.h: Rename include guard.
15080 * tui/tui-layout.h: Rename include guard.
15081 * tui/tui-io.h: Rename include guard.
15082 * tui/tui-hooks.h: Rename include guard.
15083 * tui/tui-file.h: Rename include guard.
15084 * tui/tui-disasm.h: Rename include guard.
15085 * tui/tui-data.h: Rename include guard.
15086 * tui/tui-command.h: Rename include guard.
15087 * tic6x-tdep.h: Add include guard.
15088 * target/waitstatus.h: Rename include guard.
15089 * target/wait.h: Rename include guard.
15090 * target/target.h: Rename include guard.
15091 * target/resume.h: Rename include guard.
15092 * target-float.h: Rename include guard.
15093 * stabsread.h: Add include guard.
15094 * rs6000-tdep.h: Add include guard.
15095 * riscv-fbsd-tdep.h: Add include guard.
15096 * regformats/regdef.h: Rename include guard.
15097 * record.h: Rename include guard.
15098 * python/python.h: Rename include guard.
15099 * python/python-internal.h: Rename include guard.
15100 * python/py-stopevent.h: Rename include guard.
15101 * python/py-ref.h: Rename include guard.
15102 * python/py-record.h: Rename include guard.
15103 * python/py-record-full.h: Rename include guard.
15104 * python/py-record-btrace.h: Rename include guard.
15105 * python/py-instruction.h: Rename include guard.
15106 * python/py-events.h: Rename include guard.
15107 * python/py-event.h: Rename include guard.
15108 * procfs.h: Add include guard.
15109 * proc-utils.h: Add include guard.
15110 * p-lang.h: Add include guard.
15111 * or1k-tdep.h: Rename include guard.
15112 * observable.h: Rename include guard.
15113 * nto-tdep.h: Rename include guard.
15114 * nat/x86-linux.h: Rename include guard.
15115 * nat/x86-linux-dregs.h: Rename include guard.
15116 * nat/x86-gcc-cpuid.h: Add include guard.
15117 * nat/x86-dregs.h: Rename include guard.
15118 * nat/x86-cpuid.h: Rename include guard.
15119 * nat/ppc-linux.h: Rename include guard.
15120 * nat/mips-linux-watch.h: Rename include guard.
15121 * nat/linux-waitpid.h: Rename include guard.
15122 * nat/linux-ptrace.h: Rename include guard.
15123 * nat/linux-procfs.h: Rename include guard.
15124 * nat/linux-osdata.h: Rename include guard.
15125 * nat/linux-nat.h: Rename include guard.
15126 * nat/linux-namespaces.h: Rename include guard.
15127 * nat/linux-btrace.h: Rename include guard.
15128 * nat/glibc_thread_db.h: Rename include guard.
15129 * nat/gdb_thread_db.h: Rename include guard.
15130 * nat/gdb_ptrace.h: Rename include guard.
15131 * nat/fork-inferior.h: Rename include guard.
15132 * nat/amd64-linux-siginfo.h: Rename include guard.
15133 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15134 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15135 * nat/aarch64-linux.h: Rename include guard.
15136 * nat/aarch64-linux-hw-point.h: Rename include guard.
15137 * mn10300-tdep.h: Add include guard.
15138 * mips-linux-tdep.h: Add include guard.
15139 * mi/mi-parse.h: Rename include guard.
15140 * mi/mi-out.h: Rename include guard.
15141 * mi/mi-main.h: Rename include guard.
15142 * mi/mi-interp.h: Rename include guard.
15143 * mi/mi-getopt.h: Rename include guard.
15144 * mi/mi-console.h: Rename include guard.
15145 * mi/mi-common.h: Rename include guard.
15146 * mi/mi-cmds.h: Rename include guard.
15147 * mi/mi-cmd-break.h: Rename include guard.
15148 * m2-lang.h: Add include guard.
15149 * location.h: Rename include guard.
15150 * linux-record.h: Rename include guard.
15151 * linux-nat.h: Add include guard.
15152 * linux-fork.h: Add include guard.
15153 * i386-darwin-tdep.h: Rename include guard.
15154 * hppa-linux-offsets.h: Add include guard.
15155 * guile/guile.h: Rename include guard.
15156 * guile/guile-internal.h: Rename include guard.
15157 * gnu-nat.h: Rename include guard.
15158 * gdb-stabs.h: Rename include guard.
15159 * frv-tdep.h: Add include guard.
15160 * f-lang.h: Add include guard.
15161 * event-loop.h: Add include guard.
15162 * darwin-nat.h: Rename include guard.
15163 * cp-abi.h: Rename include guard.
15164 * config/sparc/nm-sol2.h: Rename include guard.
15165 * config/nm-nto.h: Rename include guard.
15166 * config/nm-linux.h: Add include guard.
15167 * config/i386/nm-i386gnu.h: Rename include guard.
15168 * config/djgpp/nl_types.h: Rename include guard.
15169 * config/djgpp/langinfo.h: Rename include guard.
15170 * compile/gcc-cp-plugin.h: Add include guard.
15171 * compile/gcc-c-plugin.h: Add include guard.
15172 * compile/compile.h: Rename include guard.
15173 * compile/compile-object-run.h: Rename include guard.
15174 * compile/compile-object-load.h: Rename include guard.
15175 * compile/compile-internal.h: Rename include guard.
15176 * compile/compile-cplus.h: Rename include guard.
15177 * compile/compile-c.h: Rename include guard.
15178 * common/xml-utils.h: Rename include guard.
15179 * common/x86-xstate.h: Rename include guard.
15180 * common/version.h: Rename include guard.
15181 * common/vec.h: Rename include guard.
15182 * common/tdesc.h: Rename include guard.
15183 * common/selftest.h: Rename include guard.
15184 * common/scoped_restore.h: Rename include guard.
15185 * common/scoped_mmap.h: Rename include guard.
15186 * common/scoped_fd.h: Rename include guard.
15187 * common/safe-iterator.h: Rename include guard.
15188 * common/run-time-clock.h: Rename include guard.
15189 * common/refcounted-object.h: Rename include guard.
15190 * common/queue.h: Rename include guard.
15191 * common/ptid.h: Rename include guard.
15192 * common/print-utils.h: Rename include guard.
15193 * common/preprocessor.h: Rename include guard.
15194 * common/pathstuff.h: Rename include guard.
15195 * common/observable.h: Rename include guard.
15196 * common/netstuff.h: Rename include guard.
15197 * common/job-control.h: Rename include guard.
15198 * common/host-defs.h: Rename include guard.
15199 * common/gdb_wait.h: Rename include guard.
15200 * common/gdb_vecs.h: Rename include guard.
15201 * common/gdb_unlinker.h: Rename include guard.
15202 * common/gdb_unique_ptr.h: Rename include guard.
15203 * common/gdb_tilde_expand.h: Rename include guard.
15204 * common/gdb_sys_time.h: Rename include guard.
15205 * common/gdb_string_view.h: Rename include guard.
15206 * common/gdb_splay_tree.h: Rename include guard.
15207 * common/gdb_setjmp.h: Rename include guard.
15208 * common/gdb_ref_ptr.h: Rename include guard.
15209 * common/gdb_optional.h: Rename include guard.
15210 * common/gdb_locale.h: Rename include guard.
15211 * common/gdb_assert.h: Rename include guard.
15212 * common/filtered-iterator.h: Rename include guard.
15213 * common/filestuff.h: Rename include guard.
15214 * common/fileio.h: Rename include guard.
15215 * common/environ.h: Rename include guard.
15216 * common/common-utils.h: Rename include guard.
15217 * common/common-types.h: Rename include guard.
15218 * common/common-regcache.h: Rename include guard.
15219 * common/common-inferior.h: Rename include guard.
15220 * common/common-gdbthread.h: Rename include guard.
15221 * common/common-exceptions.h: Rename include guard.
15222 * common/common-defs.h: Rename include guard.
15223 * common/common-debug.h: Rename include guard.
15224 * common/cleanups.h: Rename include guard.
15225 * common/buffer.h: Rename include guard.
15226 * common/btrace-common.h: Rename include guard.
15227 * common/break-common.h: Rename include guard.
15228 * cli/cli-utils.h: Rename include guard.
15229 * cli/cli-style.h: Rename include guard.
15230 * cli/cli-setshow.h: Rename include guard.
15231 * cli/cli-script.h: Rename include guard.
15232 * cli/cli-interp.h: Rename include guard.
15233 * cli/cli-decode.h: Rename include guard.
15234 * cli/cli-cmds.h: Rename include guard.
15235 * charset-list.h: Add include guard.
15236 * buildsym-legacy.h: Rename include guard.
15237 * bfin-tdep.h: Add include guard.
15238 * ax.h: Rename include guard.
15239 * arm-linux-tdep.h: Add include guard.
15240 * arm-fbsd-tdep.h: Add include guard.
15241 * arch/xtensa.h: Rename include guard.
15242 * arch/tic6x.h: Add include guard.
15243 * arch/i386.h: Add include guard.
15244 * arch/arm.h: Rename include guard.
15245 * arch/arm-linux.h: Rename include guard.
15246 * arch/arm-get-next-pcs.h: Rename include guard.
15247 * arch/amd64.h: Add include guard.
15248 * arch/aarch64-insn.h: Rename include guard.
15249 * arch-utils.h: Rename include guard.
15250 * annotate.h: Add include guard.
15251 * amd64-darwin-tdep.h: Rename include guard.
15252 * aarch64-linux-tdep.h: Add include guard.
15253 * aarch64-fbsd-tdep.h: Add include guard.
15254 * aarch32-linux-nat.h: Add include guard.
15256 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15258 * macrotab.c (macro_define_internal): New function that
15259 factorizes macro_define_object_internal and macro_define_function
15261 (macro_define_object_internal): Use macro_define_internal.
15262 (macro_define_function): Likewise.
15264 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15266 * macrocmd.c (extract_identifier): Return
15267 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15270 2019-02-06 John Baldwin <jhb@FreeBSD.org>
15272 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15274 2019-02-05 Tom Tromey <tom@tromey.com>
15276 * target.c (target_stack::unpush): Move assertion earlier.
15278 2019-01-30 Tom Tromey <tom@tromey.com>
15281 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15282 (gdbpy_parse_and_eval): Likewise.
15283 * python/python-internal.h (gdbpy_allow_threads): New class.
15285 2019-01-28 John Baldwin <jhb@FreeBSD.org>
15287 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15288 (aarch64_fbsd_fpregmap): Move earlier.
15289 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15290 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15291 instead of individual calls to trad_frame_set_reg_addr.
15292 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15294 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15295 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15296 instead of individual calls to trad_frame_set_reg_addr.
15298 2019-01-28 Alan Hayward <alan.hayward@arm.com>
15300 * CONTRIBUTE: Replace contribution list with wiki link.
15302 2019-01-25 Tom Tromey <tom@tromey.com>
15304 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15306 2019-01-25 Tom Tromey <tom@tromey.com>
15308 * xtensa-linux-nat.c: Fix common/ includes.
15309 * xml-support.h: Fix common/ includes.
15310 * xml-support.c: Fix common/ includes.
15311 * x86-linux-nat.c: Fix common/ includes.
15312 * windows-nat.c: Fix common/ includes.
15313 * varobj.h: Fix common/ includes.
15314 * varobj.c: Fix common/ includes.
15315 * value.c: Fix common/ includes.
15316 * valops.c: Fix common/ includes.
15317 * utils.c: Fix common/ includes.
15318 * unittests/xml-utils-selftests.c: Fix common/ includes.
15319 * unittests/utils-selftests.c: Fix common/ includes.
15320 * unittests/unpack-selftests.c: Fix common/ includes.
15321 * unittests/tracepoint-selftests.c: Fix common/ includes.
15322 * unittests/style-selftests.c: Fix common/ includes.
15323 * unittests/string_view-selftests.c: Fix common/ includes.
15324 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15325 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15326 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15327 * unittests/rsp-low-selftests.c: Fix common/ includes.
15328 * unittests/parse-connection-spec-selftests.c: Fix common/
15330 * unittests/optional-selftests.c: Fix common/ includes.
15331 * unittests/offset-type-selftests.c: Fix common/ includes.
15332 * unittests/observable-selftests.c: Fix common/ includes.
15333 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15334 * unittests/memrange-selftests.c: Fix common/ includes.
15335 * unittests/memory-map-selftests.c: Fix common/ includes.
15336 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15337 * unittests/function-view-selftests.c: Fix common/ includes.
15338 * unittests/environ-selftests.c: Fix common/ includes.
15339 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15340 * unittests/common-utils-selftests.c: Fix common/ includes.
15341 * unittests/cli-utils-selftests.c: Fix common/ includes.
15342 * unittests/array-view-selftests.c: Fix common/ includes.
15343 * ui-file.c: Fix common/ includes.
15344 * tui/tui-io.c: Fix common/ includes.
15345 * tracepoint.h: Fix common/ includes.
15346 * tracepoint.c: Fix common/ includes.
15347 * tracefile-tfile.c: Fix common/ includes.
15348 * top.h: Fix common/ includes.
15349 * top.c: Fix common/ includes.
15350 * thread.c: Fix common/ includes.
15351 * target/waitstatus.h: Fix common/ includes.
15352 * target/waitstatus.c: Fix common/ includes.
15353 * target.h: Fix common/ includes.
15354 * target.c: Fix common/ includes.
15355 * target-memory.c: Fix common/ includes.
15356 * target-descriptions.c: Fix common/ includes.
15357 * symtab.h: Fix common/ includes.
15358 * symfile.c: Fix common/ includes.
15359 * stap-probe.c: Fix common/ includes.
15360 * spu-linux-nat.c: Fix common/ includes.
15361 * sparc-nat.c: Fix common/ includes.
15362 * source.c: Fix common/ includes.
15363 * solib.c: Fix common/ includes.
15364 * solib-target.c: Fix common/ includes.
15365 * ser-unix.c: Fix common/ includes.
15366 * ser-tcp.c: Fix common/ includes.
15367 * ser-pipe.c: Fix common/ includes.
15368 * ser-base.c: Fix common/ includes.
15369 * selftest-arch.c: Fix common/ includes.
15370 * s12z-tdep.c: Fix common/ includes.
15371 * rust-exp.y: Fix common/ includes.
15372 * rs6000-aix-tdep.c: Fix common/ includes.
15373 * riscv-tdep.c: Fix common/ includes.
15374 * remote.c: Fix common/ includes.
15375 * remote-notif.h: Fix common/ includes.
15376 * remote-fileio.h: Fix common/ includes.
15377 * remote-fileio.c: Fix common/ includes.
15378 * regcache.h: Fix common/ includes.
15379 * regcache.c: Fix common/ includes.
15380 * record-btrace.c: Fix common/ includes.
15381 * python/python.c: Fix common/ includes.
15382 * python/py-type.c: Fix common/ includes.
15383 * python/py-inferior.c: Fix common/ includes.
15384 * progspace.h: Fix common/ includes.
15385 * producer.c: Fix common/ includes.
15386 * procfs.c: Fix common/ includes.
15387 * proc-api.c: Fix common/ includes.
15388 * printcmd.c: Fix common/ includes.
15389 * ppc-linux-nat.c: Fix common/ includes.
15390 * parser-defs.h: Fix common/ includes.
15391 * osdata.c: Fix common/ includes.
15392 * obsd-nat.c: Fix common/ includes.
15393 * nat/x86-linux.c: Fix common/ includes.
15394 * nat/x86-linux-dregs.c: Fix common/ includes.
15395 * nat/x86-dregs.h: Fix common/ includes.
15396 * nat/x86-dregs.c: Fix common/ includes.
15397 * nat/ppc-linux.c: Fix common/ includes.
15398 * nat/mips-linux-watch.h: Fix common/ includes.
15399 * nat/mips-linux-watch.c: Fix common/ includes.
15400 * nat/linux-waitpid.c: Fix common/ includes.
15401 * nat/linux-ptrace.h: Fix common/ includes.
15402 * nat/linux-ptrace.c: Fix common/ includes.
15403 * nat/linux-procfs.c: Fix common/ includes.
15404 * nat/linux-personality.c: Fix common/ includes.
15405 * nat/linux-osdata.c: Fix common/ includes.
15406 * nat/linux-namespaces.c: Fix common/ includes.
15407 * nat/linux-btrace.h: Fix common/ includes.
15408 * nat/linux-btrace.c: Fix common/ includes.
15409 * nat/fork-inferior.c: Fix common/ includes.
15410 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15411 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15412 * nat/aarch64-linux.c: Fix common/ includes.
15413 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15414 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15415 * namespace.h: Fix common/ includes.
15416 * mips-linux-tdep.c: Fix common/ includes.
15417 * minsyms.c: Fix common/ includes.
15418 * mi/mi-parse.h: Fix common/ includes.
15419 * mi/mi-main.c: Fix common/ includes.
15420 * mi/mi-cmd-env.c: Fix common/ includes.
15421 * memrange.h: Fix common/ includes.
15422 * memattr.c: Fix common/ includes.
15423 * maint.h: Fix common/ includes.
15424 * maint.c: Fix common/ includes.
15425 * main.c: Fix common/ includes.
15426 * machoread.c: Fix common/ includes.
15427 * location.c: Fix common/ includes.
15428 * linux-thread-db.c: Fix common/ includes.
15429 * linux-nat.c: Fix common/ includes.
15430 * linux-fork.c: Fix common/ includes.
15431 * inline-frame.c: Fix common/ includes.
15432 * infrun.c: Fix common/ includes.
15433 * inflow.c: Fix common/ includes.
15434 * inferior.h: Fix common/ includes.
15435 * inferior.c: Fix common/ includes.
15436 * infcmd.c: Fix common/ includes.
15437 * inf-ptrace.c: Fix common/ includes.
15438 * inf-child.c: Fix common/ includes.
15439 * ia64-linux-nat.c: Fix common/ includes.
15440 * i387-tdep.c: Fix common/ includes.
15441 * i386-tdep.c: Fix common/ includes.
15442 * i386-linux-tdep.c: Fix common/ includes.
15443 * i386-linux-nat.c: Fix common/ includes.
15444 * i386-go32-tdep.c: Fix common/ includes.
15445 * i386-fbsd-tdep.c: Fix common/ includes.
15446 * i386-fbsd-nat.c: Fix common/ includes.
15447 * guile/scm-type.c: Fix common/ includes.
15448 * guile/guile.c: Fix common/ includes.
15449 * go32-nat.c: Fix common/ includes.
15450 * gnu-nat.c: Fix common/ includes.
15451 * gdbthread.h: Fix common/ includes.
15452 * gdbarch-selftests.c: Fix common/ includes.
15453 * gdb_usleep.c: Fix common/ includes.
15454 * gdb_select.h: Fix common/ includes.
15455 * gdb_bfd.c: Fix common/ includes.
15456 * gcore.c: Fix common/ includes.
15457 * fork-child.c: Fix common/ includes.
15458 * findvar.c: Fix common/ includes.
15459 * fbsd-nat.c: Fix common/ includes.
15460 * event-top.c: Fix common/ includes.
15461 * event-loop.c: Fix common/ includes.
15462 * dwarf2read.c: Fix common/ includes.
15463 * dwarf2loc.c: Fix common/ includes.
15464 * dwarf2-frame.c: Fix common/ includes.
15465 * dwarf-index-cache.c: Fix common/ includes.
15466 * dtrace-probe.c: Fix common/ includes.
15467 * disasm-selftests.c: Fix common/ includes.
15468 * defs.h: Fix common/ includes.
15469 * csky-tdep.c: Fix common/ includes.
15470 * cp-valprint.c: Fix common/ includes.
15471 * cp-support.h: Fix common/ includes.
15472 * cp-support.c: Fix common/ includes.
15473 * corelow.c: Fix common/ includes.
15474 * completer.h: Fix common/ includes.
15475 * completer.c: Fix common/ includes.
15476 * compile/compile.c: Fix common/ includes.
15477 * compile/compile-loc2c.c: Fix common/ includes.
15478 * compile/compile-cplus-types.c: Fix common/ includes.
15479 * compile/compile-cplus-symbols.c: Fix common/ includes.
15480 * command.h: Fix common/ includes.
15481 * cli/cli-dump.c: Fix common/ includes.
15482 * cli/cli-cmds.c: Fix common/ includes.
15483 * charset.c: Fix common/ includes.
15484 * build-id.c: Fix common/ includes.
15485 * btrace.h: Fix common/ includes.
15486 * btrace.c: Fix common/ includes.
15487 * breakpoint.h: Fix common/ includes.
15488 * breakpoint.c: Fix common/ includes.
15490 (enum agent_op): Fix common/ includes.
15491 * ax-general.c (struct aop_map): Fix common/ includes.
15492 * ax-gdb.c: Fix common/ includes.
15493 * auxv.c: Fix common/ includes.
15494 * auto-load.c: Fix common/ includes.
15495 * arm-tdep.c: Fix common/ includes.
15496 * arch/riscv.c: Fix common/ includes.
15497 * arch/ppc-linux-common.c: Fix common/ includes.
15498 * arch/i386.c: Fix common/ includes.
15499 * arch/arm.c: Fix common/ includes.
15500 * arch/arm-linux.c: Fix common/ includes.
15501 * arch/arm-get-next-pcs.c: Fix common/ includes.
15502 * arch/amd64.c: Fix common/ includes.
15503 * arch/aarch64.c: Fix common/ includes.
15504 * arch/aarch64-insn.c: Fix common/ includes.
15505 * arch-utils.c: Fix common/ includes.
15506 * amd64-windows-tdep.c: Fix common/ includes.
15507 * amd64-tdep.c: Fix common/ includes.
15508 * amd64-sol2-tdep.c: Fix common/ includes.
15509 * amd64-obsd-tdep.c: Fix common/ includes.
15510 * amd64-nbsd-tdep.c: Fix common/ includes.
15511 * amd64-linux-tdep.c: Fix common/ includes.
15512 * amd64-linux-nat.c: Fix common/ includes.
15513 * amd64-fbsd-tdep.c: Fix common/ includes.
15514 * amd64-fbsd-nat.c: Fix common/ includes.
15515 * amd64-dicos-tdep.c: Fix common/ includes.
15516 * amd64-darwin-tdep.c: Fix common/ includes.
15517 * agent.c: Fix common/ includes.
15518 * ada-lang.h: Fix common/ includes.
15519 * ada-lang.c: Fix common/ includes.
15520 * aarch64-tdep.c: Fix common/ includes.
15522 2019-01-25 Tom Tromey <tom@tromey.com>
15524 * common/create-version.sh: Use common/version.h.
15526 2019-01-24 Pedro Alves <palves@redhat.com>
15528 * infrun.c (signal_stop, signal_print, signal_program)
15529 (signal_catch, signal_pass): Now arrays instead of pointers.
15530 (update_signals_program_target, do_target_resume)
15531 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15532 * linux-nat.c (linux_nat_target::pass_signals)
15533 (linux_nat_target::create_inferior, linux_nat_target::attach):
15535 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15536 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15537 * procfs.c (procfs_target::pass_signals): Adjust.
15538 * record-full.c (record_full_target::resume): Adjust.
15539 * remote.c (remote_target::pass_signals)
15540 (remote_target::program_signals): Adjust.
15541 * target-debug.h (target_debug_print_signals): Now takes a
15542 gdb::array_view as parameter. Adjust.
15543 * target.h (target_ops) <pass_signals, program_signals>: Replace
15544 pointer and length parameters with gdb::array_view.
15545 (target_pass_signals, target_program_signals): Likewise.
15546 * target-delegates.c: Regenerate.
15548 2019-01-24 Pedro Alves <palves@redhat.com>
15550 * common/forward-scope-exit.h
15551 (forward_scope_exit::forward_scope_exit): Pass arguments to
15552 m_bind_function directly, instead of creating a std::bind and
15555 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15557 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15558 for static members.
15559 (pass_in_v_vfp_candidate): Likewise.
15561 2019-01-23 Tom Tromey <tom@tromey.com>
15562 Pedro Alves <palves@redhat.com>
15564 * regcache.c (class regcache_invalidator): Remove.
15565 (regcache::raw_write): Use make_scope_exit.
15567 2019-01-23 Tom Tromey <tom@tromey.com>
15569 * ui-out.h (class ui_out_emit_type): Update comment.
15571 2019-01-23 Tom Tromey <tom@tromey.com>
15573 * infrun.c (fetch_inferior_event): Update comment.
15575 2019-01-23 Tom Tromey <tom@tromey.com>
15576 Pedro Alves <palves@redhat.com>
15578 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15580 (fetch_inferior_event): Use SCOPE_EXIT.
15583 2019-01-23 Tom Tromey <tom@tromey.com>
15584 Pedro Alves <palves@redhat.com>
15586 * infrun.c (disable_thread_events): Delete.
15587 (stop_all_threads): Use SCOPE_EXIT.
15589 2019-01-23 Tom Tromey <tom@tromey.com>
15590 Pedro Alves <palves@redhat.com>
15592 * symfile.c: Include forward-scope-exit.h.
15593 (clear_symtab_users_cleanup): Replace forward declaration with
15594 a FORWARD_SCOPE_EXIT.
15595 (syms_from_objfile_1): Use the forward_scope_exit and
15596 gdb::optional instead of cleanup_function.
15597 (reread_symbols): Use the forward_scope_exit instead of
15599 (clear_symtab_users_cleanup): Remove function.
15601 2019-01-23 Tom Tromey <tom@tromey.com>
15602 Pedro Alves <palves@redhat.com>
15604 * linux-nat.c: Include scope-exit.h.
15605 (cleanup_target_stop): Remove.
15606 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15609 2019-01-23 Tom Tromey <tom@tromey.com>
15610 Pedro Alves <palves@redhat.com>
15612 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15613 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15615 2019-01-23 Tom Tromey <tom@tromey.com>
15616 Andrew Burgess <andrew.burgess@embecosm.com>
15617 Pedro Alves <palves@redhat.com>
15619 * infrun.c (fetch_inferior_event): Use scope_exit.
15620 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15621 * top.c (execute_command): Use scope_exit.
15622 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15623 * utils.c (do_bpstat_clear_actions_cleanup)
15624 (make_bpstat_clear_actions_cleanup): Remove.
15626 2019-01-23 Tom Tromey <tom@tromey.com>
15627 Pedro Alves <palves@redhat.com>
15629 * infrun.c: Include "common/scope-exit.h"
15630 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15631 (wait_for_inferior): Use SCOPE_EXIT.
15632 (fetch_inferior_event): Use scope_exit.
15634 2019-01-23 Tom Tromey <tom@tromey.com>
15635 Pedro Alves <palves@redhat.com>
15637 * breakpoint.c (create_breakpoint): Remove cleanup.
15639 2019-01-23 Tom Tromey <tom@tromey.com>
15640 Andrew Burgess <andrew.burgess@embecosm.com>
15641 Pedro Alves <palves@redhat.com>
15643 2019-01-23 Pedro Alves <palves@redhat.com>
15645 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15647 2019-01-23 Pedro Alves <palves@redhat.com>
15648 Andrew Burgess <andrew.burgess@embecosm.com>
15650 * gdbthread.h: Include "common/forward-scope-exit.h".
15651 (scoped_finish_thread_state): Redefine custom class in terms of
15652 forward_scope_exit.
15654 2019-01-23 Pedro Alves <palves@redhat.com>
15655 Andrew Burgess <andrew.burgess@embecosm.com>
15657 * common/forward-scope-exit.h: New file.
15659 2019-01-23 Pedro Alves <palves@redhat.com>
15660 Andrew Burgess <andrew.burgess@embecosm.com>
15661 Tom Tromey <tom@tromey.com>
15663 * common/scope-exit.h: New file.
15665 2019-01-23 Pedro Alves <palves@redhat.com>
15667 * common/preprocessor.h (ESC): Rename to ...
15668 (ESC_PARENS): ... this.
15669 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15670 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15672 2019-01-23 Tom Tromey <tom@tromey.com>
15674 * language.h (class scoped_switch_to_sym_language_if_auto):
15675 Initialize m_lang in both cases.
15677 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15679 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15682 2019-01-22 Tom Tromey <tom@tromey.com>
15684 * corelow.c: Do not include sys/file.h.
15686 2019-01-22 Tom Tromey <tom@tromey.com>
15688 * tui/tui-wingeneral.h: Include gdb_curses.h.
15690 2019-01-22 Tom Tromey <tom@tromey.com>
15692 * source-cache.h (class source_cache) <get_source_lines,
15693 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15695 2019-01-22 Tom Tromey <tom@tromey.com>
15697 * remote-fileio.h (struct remote_target): Declare.
15699 2019-01-22 Tom Tromey <tom@tromey.com>
15701 * python/py-arch.c: Do not include py-ref.h.
15702 * python/py-bpevent.c: Do not include py-ref.h.
15703 * python/py-cmd.c: Do not include py-ref.h.
15704 * python/py-continueevent.c: Do not include py-ref.h.
15705 * python/py-event.h: Do not include py-ref.h.
15706 * python/py-evtregistry.c: Do not include py-ref.h.
15707 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15708 * python/py-frame.c: Do not include py-ref.h.
15709 * python/py-framefilter.c: Do not include py-ref.h.
15710 * python/py-function.c: Do not include py-ref.h.
15711 * python/py-infevents.c: Do not include py-ref.h.
15712 * python/py-linetable.c: Do not include py-ref.h.
15713 * python/py-objfile.c: Do not include py-ref.h.
15714 * python/py-param.c: Do not include py-ref.h.
15715 * python/py-prettyprint.c: Do not include py-ref.h.
15716 * python/py-progspace.c: Do not include py-ref.h.
15717 * python/py-symbol.c: Do not include py-ref.h.
15718 * python/py-symtab.c: Do not include py-ref.h.
15719 * python/py-type.c: Do not include py-ref.h.
15720 * python/py-unwind.c: Do not include py-ref.h.
15721 * python/py-utils.c: Do not include py-ref.h.
15722 * python/py-value.c: Do not include py-ref.h.
15723 * python/py-varobj.c: Do not include py-ref.h.
15724 * python/py-xmethods.c: Do not include py-ref.h.
15725 * python/python.c: Do not include py-ref.h.
15726 * varobj.c: Do not include py-ref.h.
15728 2019-01-22 Tom Tromey <tom@tromey.com>
15730 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15731 keyword for bcache.
15733 2019-01-22 Tom Tromey <tom@tromey.com>
15735 * compile/compile-cplus-types.c: Remove a comment by #include.
15737 2019-01-22 Tom Tromey <tom@tromey.com>
15739 * compile/gcc-c-plugin.h: Include compile-internal.h.
15741 2019-01-22 Tom Tromey <tom@tromey.com>
15743 * stabsread.c (EXTERN): Do not define.
15744 (symnum, next_symbol_text_func, processing_gcc_compilation)
15745 (within_function, global_sym_chain, global_stabs)
15746 (previous_stab_code, this_object_header_files)
15747 (n_this_object_header_files)
15748 (n_allocated_this_object_header_files): Define.
15749 * stabsread.h (EXTERN): Never define. Use "extern".
15751 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15753 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15756 2019-01-21 Tom Tromey <tom@tromey.com>
15758 * ui-out.c: Fix includes.
15759 * tui/tui-source.c: Fix includes.
15760 * target.c: Fix includes.
15761 * remote.c: Fix includes.
15762 * regcache.c: Fix includes.
15763 * python/py-block.c: Fix includes.
15764 * printcmd.c: Fix includes.
15765 * or1k-tdep.c: Fix includes.
15766 * mi/mi-main.c: Fix includes.
15767 * m32r-tdep.c: Fix includes.
15768 * csky-tdep.c: Fix includes.
15769 * compile/compile-cplus-types.c: Fix includes.
15770 * cli/cli-interp.c: Fix includes.
15772 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15774 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15777 2019-01-16 Tom Tromey <tom@tromey.com>
15779 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15781 (struct objfile) <msymbols_range>: Move from top level.
15782 <msymbols>: New method.
15783 (class objfile_msymbols): Remove.
15784 * symtab.c (default_collect_symbol_completion_matches_break_on):
15786 * symmisc.c (dump_msymbols): Update.
15787 * stabsread.c (scan_file_globals): Update.
15788 * objc-lang.c (info_selectors_command, info_classes_command)
15789 (find_methods): Update.
15790 * minsyms.c (find_solib_trampoline_target): Update.
15791 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15792 * coffread.c (coff_symfile_read): Update.
15793 * ada-lang.c (ada_lookup_simple_minsym)
15794 (ada_collect_symbol_completion_matches): Update.
15796 2019-01-16 Tom Tromey <tom@tromey.com>
15798 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15799 type. Remove no-argument constructor.
15800 <iterator::operator++>: Simplify.
15802 <end>: Use minimal_symbol_count.
15804 2019-01-16 Tom Tromey <tom@tromey.com>
15806 * objfiles.h (struct objfile) <psymtabs>: New method.
15807 (class objfile_psymtabs): Remove.
15808 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15810 <range>: New method.
15811 (require_partial_symbols): Change return type.
15812 * psymtab.c (require_partial_symbols)
15813 (psym_expand_symtabs_matching): Update.
15814 * mdebugread.c (parse_partial_symbols): Update.
15815 * dbxread.c (dbx_end_psymtab): Update.
15817 2019-01-15 Tom Tromey <tom@tromey.com>
15819 * symtab.c (lookup_objfile_from_block)
15820 (lookup_symbol_in_objfile_symtabs)
15821 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15822 (find_line_symtab, info_sources_command)
15823 (default_collect_symbol_completion_matches_break_on)
15824 (make_source_files_completion_list): Update.
15825 * symmisc.c (print_objfile_statistics, dump_objfile)
15826 (maintenance_print_symbols, maintenance_info_symtabs)
15827 (maintenance_check_symtabs, maintenance_info_line_tables):
15829 * source.c (select_source_symtab)
15830 (forget_cached_source_info_for_objfile): Update.
15831 * objfiles.h (class objfile_compunits): Remove.
15832 (struct objfile) <compunits_range>: New typedef.
15833 (compunits): New method.
15834 * objfiles.c (objfile_relocate1): Update.
15835 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15836 * maint.c (count_symtabs_and_blocks): Update.
15837 * linespec.c (iterate_over_all_matching_symtabs): Update.
15838 * cp-support.c (add_symbol_overload_list_qualified): Update.
15839 * coffread.c (coff_symtab_read): Update.
15840 * ada-lang.c (add_nonlocal_symbols)
15841 (ada_collect_symbol_completion_matches)
15842 (ada_add_global_exceptions): Update.
15844 2019-01-15 Tom Tromey <tom@tromey.com>
15846 * progspace.h (program_space) <objfiles_safe_range>: New
15848 <objfiles_safe>: New method.
15849 * objfiles.h (class all_objfiles_safe): Remove.
15850 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15851 * jit.c (jit_inferior_exit_hook): Update.
15853 2019-01-17 Tom Tromey <tom@tromey.com>
15855 * progspace.h (program_space) <objfiles_range>: New typedef.
15856 <objfiles>: New method.
15857 <objfiles_head>: Rename from objfiles.
15858 (object_files): Update.
15859 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15860 * guile/scm-pretty-print.c
15861 (ppscm_find_pretty_printer_from_objfiles): Update.
15862 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15863 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15865 * python/py-progspace.c (pspy_get_objfiles): Update.
15866 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15868 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15869 (objfpy_lookup_objfile_by_build_id): Update.
15870 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15871 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15873 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15874 (expand_symtab_containing_pc, lookup_objfile_from_block)
15875 (lookup_static_symbol, basic_lookup_transparent_type)
15876 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15877 (find_line_symtab, info_sources_command)
15878 (default_collect_symbol_completion_matches_break_on)
15879 (make_source_files_completion_list, find_main_name): Update.
15880 * symmisc.c (print_symbol_bcache_statistics)
15881 (print_objfile_statistics, maintenance_print_symbols)
15882 (maintenance_print_msymbols, maintenance_print_objfiles)
15883 (maintenance_info_symtabs, maintenance_check_symtabs)
15884 (maintenance_expand_symtabs, maintenance_info_line_tables):
15886 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15887 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15888 (map_overlay_command, unmap_overlay_command)
15889 (simple_overlay_update, expand_symtabs_matching)
15890 (map_symbol_filenames): Update.
15891 * symfile-debug.c (set_debug_symfile): Update.
15892 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15894 * source.c (select_source_symtab, forget_cached_source_info):
15896 * solib.c (solib_read_symbols): Update.
15897 * solib-spu.c (append_ocl_sos): Update.
15898 * psymtab.c (maintenance_print_psymbols)
15899 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15900 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15901 * printcmd.c (info_symbol_command): Update.
15902 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15904 * objfiles.h (class all_objfiles): Remove.
15905 * objfiles.c (have_partial_symbols, have_full_symbols)
15906 (have_minimal_symbols, qsort_cmp, update_section_map)
15907 (shared_objfile_contains_address_p)
15908 (default_iterate_over_objfiles_in_search_order): Update.
15909 * objc-lang.c (info_selectors_command, info_classes_command)
15910 (find_methods): Update.
15911 * minsyms.c (find_solib_trampoline_target): Update.
15912 * maint.c (maintenance_info_sections)
15913 (maintenance_translate_address, count_symtabs_and_blocks):
15915 * main.c (captured_main_1): Update.
15916 * linux-thread-db.c (try_thread_db_load_from_pdir)
15917 (has_libpthread): Update.
15918 * linespec.c (iterate_over_all_matching_symtabs)
15919 (search_minsyms_for_name): Update.
15920 * jit.c (jit_find_objf_with_entry_addr): Update.
15921 * hppa-tdep.c (find_unwind_entry)
15922 (hppa_lookup_stub_minimal_symbol): Update.
15923 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15925 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15926 (elf_gnu_ifunc_resolve_by_got): Update.
15927 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15928 * dwarf-index-write.c (save_gdb_index_command): Update.
15929 * cp-support.c (add_symbol_overload_list_qualified): Update.
15930 * breakpoint.c (create_overlay_event_breakpoint)
15931 (create_longjmp_master_breakpoint)
15932 (create_std_terminate_master_breakpoint)
15933 (create_exception_master_breakpoint): Update.
15934 * blockframe.c (find_pc_partial_function): Update.
15935 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15936 (ada_collect_symbol_completion_matches)
15937 (ada_add_global_exceptions): Update.
15939 2019-01-17 Tom Tromey <tom@tromey.com>
15941 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15943 (solib_target_parse_libraries): Change return type.
15944 (library_list_start_segment, library_list_start_section)
15945 (library_list_end_library, library_list_start_library); Update.
15946 (solib_target_free_library_list): Remove.
15947 (solib_target_parse_libraries): Remove cleanup. Change return
15949 (solib_target_current_sos): Update.
15951 2019-01-17 Tom Tromey <tromey@bapiya>
15953 * valprint.c: Replace "the the" with "the".
15954 * symtab.c: Replace "the the" with "the".
15955 * solib.c: Replace "the the" with "the".
15956 * solib-dsbt.c: Replace "the the" with "the".
15957 * linespec.c: Replace "the the" with "the".
15958 * dwarf2loc.h: Replace "the the" with "the".
15959 * amd64-windows-tdep.c: Replace "the the" with "the".
15960 * aarch64-tdep.c: Replace "the the" with "the".
15962 2019-01-16 Keith Seitz <keiths@redhat.com>
15965 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15966 <builder>: Rename to ..
15967 <m_builder>: ... this and make private.
15968 (dwarf2_cu::get_builder): New method. Change all users of
15969 `builder' to use this method.
15970 (dwarf2_start_symtab): Move to ...
15971 (dwarf2_cu::start_symtab): ... here. Update all callers
15972 (setup_type_unit_groups): Move to ...
15973 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15975 (dwarf2_cu::reset_builder): New method.
15976 (process_full_compunit, process_full_type_unit): Use
15977 dwarf2_cu::reset_builder.
15978 (follow_die_offset): Record the ancestor CU if it is different
15979 from the followed DIE's CU.
15980 (follow_die_sig_1): Likewise.
15982 2019-01-15 Tom Tromey <tom@tromey.com>
15984 * remote.c (class remote_state) <buf>: Now a char_vector.
15985 <buf_size>: Remove.
15986 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15988 (remote_target::getpkt_or_notif_sane_1)
15989 (remote_target::getpkt_sane)
15990 (remote_target::getpkt_or_notif_sane): Likewise.
15991 (class remote_target) <putpkt>: New overload.
15992 (remote_target::read_frame): Change type of "buf_p". Remove
15993 sizeof_p parameter.
15994 (packet_ok): New overload.
15995 (packet_check_result): New overload.
15998 2019-01-14 Tom Tromey <tom@tromey.com>
16000 * remote-notif.c (handle_notification, remote_notif_ack)
16001 (remote_notif_parse): Make "buf" const.
16002 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16004 (remote_notif_parse, remote_notif_ack, handle_notification):
16006 * remote.c (remote_notif_stop_parse): Make "buf" const.
16007 (remote_target::remote_parse_stop_reply): Make "buf" const.
16008 (remote_notif_stop_ack): Make "buf" const.
16010 2019-01-14 Tom Tromey <tom@tromey.com>
16012 * remote.c (remote_console_output): Make parameter const.
16014 2019-01-14 Tom Tromey <tom@tromey.com>
16016 * target-debug.h (target_debug_print_signals): Constify.
16017 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16018 * procfs.c (procfs_target::pass_signals): Update.
16019 * linux-nat.c (linux_nat_target::pass_signals): Update.
16020 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16021 * target-delegates.c: Rebuild.
16022 * remote.c (remote_target::program_signals): Update.
16023 (remote_target::pass_signals): Update.
16024 * target.c (target_pass_signals): Constify argument.
16025 (target_program_signals): Likewise.
16026 * target.h (struct target_ops) <pass_signals, program_signals>:
16028 (target_pass_signals, target_program_signals): Constify argument.
16030 2019-01-14 Tom Tromey <tom@tromey.com>
16033 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16035 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16037 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16039 * rs6000-tdep.c: Include reggroups.h.
16040 (IS_V_ALIAS_PSEUDOREG): Define.
16041 (rs6000_register_name): Return names for the "vX" aliases.
16042 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16043 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16044 aliases. Call default_register_reggroup_p for all other
16046 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16048 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16049 Handle "vX" aliases.
16050 (v_alias_pseudo_register_collect): New function.
16051 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16052 (rs6000_gdbarch_init): Initialize "vX" aliases as
16053 pseudo-registers. Restore registration of
16054 rs6000_pseudo_register_reggroup_p with
16055 set_tdesc_pseudo_register_reggroup_p.
16057 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16059 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16060 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16061 set_gdbarch_num_pseudo_regs.
16063 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16065 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16066 Remove arg prefixname, add do_set and do_show.
16067 Add member functions set_list and show_list.
16068 * cli/cli-style.c (class cli_style_option): Update accordingly.
16069 (style_set_list): Move to file scope.
16070 (style_show_list): Likewise.
16071 (set_style): Call help_list.
16072 (show_style): Call cmd_show_list.
16073 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16074 Update to use the new macro.
16076 2019-10-12 Joel Brobecker <brobecker@adacore.com>
16078 * ada-lang.c (_initialize_ada_language): Expand the help text
16079 for the "catch exception" command.
16081 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16083 * symtab.c (matching_obj_sections): Initialize obj,
16084 declare it closer to its usage.
16086 2019-01-10 Tom Tromey <tom@tromey.com>
16088 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16089 (basic_inf_threads_range): Remove.
16090 (inf_threads_range, inf_non_exited_threads_range)
16091 (safe_inf_threads_range): Use next_adapter.
16093 2019-01-10 Keith Seitz <keiths@redhat.com>
16097 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16098 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16100 2019-01-10 Keith Seitz <keiths@redhat.com>
16104 * dictionary.c (pending_to_vector): Remove.
16105 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16106 Remove _1 suffix, replacing functions of the same name. Update
16108 (dict_create_hashed, dict_create_hashed_expandable)
16109 (dict_create_linear, dict_create_linear_expandable, dict_free)
16110 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16111 Make functions static.
16113 2019-01-10 Keith Seitz <keiths@redhat.com>
16117 * dictionary.h (struct dictionary): Replace declaration with
16119 (dict_create_hashed, dict_create_hashed_expandable)
16120 (dict_create_linear, dict_create_linear_expandable)
16121 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16122 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16123 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16124 taking multidictionary argument.
16125 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16126 * block.h (struct block) <dict>: Change to multidictionary
16127 and rename `multidict'.
16128 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16129 symmisc.c: Update all dictionary references to multidictionary.
16131 2019-01-10 Keith Seitz <keiths@redhat.com>
16135 * dictionary.c: Include unordered_map.
16136 (pending_to_vector): New function.
16137 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16138 Rewrite the non-"_1" functions to take vector instead
16140 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16141 "new" _1 versions of the same name.
16142 (multidictionary): Define.
16143 (std::hash<enum language): New definition.
16144 (collate_pending_symbols_by_language, mdict_create_hashed)
16145 (mdict_create_hashed_expandable, mdict_create_linear)
16146 (mdict_create_linear_expandable, mdict_free)
16147 (find_language_dictionary, create_new_language_dictionary)
16148 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16149 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16150 (mdict_size, mdict_empty): New functions.
16151 * dictionary.h (mdict_iterator): Define.
16153 2019-01-10 Pedro Alves <palves@redhat.com>
16155 * breakpoint.c (read_uploaded_action)
16156 (create_tracepoint_from_upload): Adjust to use
16157 gdb::unique_xmalloc_ptr.
16158 * ctf.c (ctf_write_uploaded_tp):
16159 (SET_ARRAY_FIELD): Use emplace_back.
16160 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16161 * tracefile-tfile.c (tfile_write_uploaded_tp):
16162 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16163 gdb::unique_xmalloc_ptr.
16164 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16165 at_string, cond_string, cmd_strings>: Replace char pointers
16166 with gdb::unique_xmalloc_ptr.
16168 2019-01-10 Pedro Alves <palves@redhat.com>
16170 * solib-target.c (library_list_start_library): Don't xstrdup name.
16172 2019-01-10 Pedro Alves <palves@redhat.com>
16174 * mdebugread.c (parse_partial_symbols): Use
16175 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16177 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16179 * linux-fork.c (scoped_switch_fork_info)
16180 <~scoped_switch_fork_info>: Fix incorrect variable name.
16182 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16184 * linux-fork.c (scoped_switch_fork_info)
16185 <scoped_switch_fork_info>: Make explicit.
16186 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16188 2019-01-10 Tom Tromey <tom@tromey.com>
16190 * objfiles.h (objfile::reset_psymtabs): Update.
16191 * objfiles.c (objfile::objfile): Update.
16192 * psymtab.h (psymtab_storage::obstack): Update.
16193 (psymtab_storage::m_obstack): Use gdb::optional.
16194 (class psymtab_storage): Update comment. Remove objfile
16196 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16198 2019-01-10 Tom Tromey <tom@tromey.com>
16200 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16201 <free_psymtabs>: Now private.
16202 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16203 (allocate_psymtab): Use new method.
16205 2019-01-10 Tom Tromey <tom@tromey.com>
16207 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16208 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16209 * mdebugread.c (parse_partial_symbols): Use
16210 allocate_dependencies.
16211 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16212 allocate_dependencies.
16213 (process_psymtab_comp_unit_reader)
16214 (build_type_psymtab_dependencies): Likewise.
16215 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16217 2019-01-10 Tom Tromey <tom@tromey.com>
16219 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16220 PSYMBOL_SET_LANGUAGE.
16221 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16223 2019-01-10 Tom Tromey <tom@tromey.com>
16225 * psymtab.h (psymtab_storage::obstack): New method.
16226 <m_obstack>: Rename from obstack; now private.
16227 * psymtab.c (psymtab_storage): Update.
16228 * dwarf2read.c (create_addrmap_from_index)
16229 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16232 2019-01-10 Tom Tromey <tom@tromey.com>
16234 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16235 * objfiles.h (objfile::reset_psymtabs): New method.
16237 2019-01-10 Tom Tromey <tom@tromey.com>
16239 * symmisc.c (print_symbol_bcache_statistics): Update.
16240 (print_objfile_statistics): Update.
16241 * symfile.c (reread_symbols): Update.
16242 * psymtab.h (class psymtab_storage): New.
16243 * psymtab.c (psymtab_storage): New constructor.
16244 (~psymtab_storage): New destructor.
16245 (require_partial_symbols): Update.
16246 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16247 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16248 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16249 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16250 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16251 (start_psymtab_common, end_psymtab_common)
16252 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16253 (allocate_psymtab): Update.
16254 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16256 (dump_psymtab_addrmap, maintenance_print_psymbols)
16257 (maintenance_check_psymtabs): Update.
16258 (class objfile_psymtabs): Move to objfiles.h.
16259 * psympriv.h (discard_psymtab): Now inline.
16260 (psymtab_discarder::psymtab_discarder): Update.
16261 (psymtab_discarder::~psymtab_discarder): Update.
16262 (ALL_OBJFILE_PSYMTABS): Rewrite.
16263 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16264 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16266 <partial_symtabs>: New field.
16267 (class objfile_psymtabs): Move from psymtab.h. Update.
16268 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16270 (objfile::~objfile): Don't destroy psymbol_cache.
16271 * mdebugread.c (parse_partial_symbols): Update.
16272 * dwarf2read.c (create_addrmap_from_index)
16273 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16274 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16275 (add_partial_subprogram, dwarf2_ranges_read): Update.
16276 * dwarf-index-write.c (write_address_map)
16277 (write_one_signatured_type, recursively_write_psymbols)
16278 (class debug_names, class debug_names, write_psymtabs_to_index):
16281 2019-01-10 Tom Tromey <tom@tromey.com>
16283 * symtab.h (SYMBOL_SET_NAMES): Update.
16284 (symbol_set_names): Update.
16285 (MSYMBOL_SET_NAMES): Update.
16286 * symtab.c (symbol_set_names): Change argument to be an
16287 objfile_per_bfd_storage.
16288 * psymtab.c (add_psymbol_to_bcache): Update.
16289 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16291 2019-01-10 Tom Tromey <tom@tromey.com>
16293 * symtab.c (create_demangled_names_hash): Change argument to be an
16294 objfile_per_bfd_storage.
16295 (symbol_set_names): Update.
16297 2019-01-10 Tom Tromey <tom@tromey.com>
16299 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16301 * psymtab.c (init_psymbol_list): Do nothing if already called.
16302 * psympriv.h (init_psymbol_list): Add comment.
16303 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16305 * dbxread.c (dbx_symfile_read): Unconditionally call
16308 2019-01-10 Tom Tromey <tom@tromey.com>
16310 * xcoffread.c (scan_xcoff_symtab): Update.
16311 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16313 * mdebugread.c (parse_partial_symbols)
16314 (handle_psymbol_enumerators): Update.
16315 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16316 * dbxread.c (read_dbx_symtab): Update.
16317 * psympriv.h (psymbol_placement): New enum.
16318 (add_psymbol_to_list): Update.
16320 2019-01-10 Tom Tromey <tom@tromey.com>
16322 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16323 static_psymbols parameters.
16324 (scan_xcoff_symtab): Update.
16325 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16326 static_psymbols parameters.
16327 * psympriv.h (start_psymtab_common): Update.
16328 * mdebugread.c (parse_partial_symbols): Update.
16329 * dwarf2read.c (create_partial_symtab): Update.
16330 * dbxread.c (read_dbx_symtab): Update.
16331 (start_psymtab): Remove global_psymbols and static_psymbols
16334 2019-01-10 Tom Tromey <tom@tromey.com>
16336 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16337 * psymtab.c (allocate_psymtab): Add comment.
16338 * psympriv.h (allocate_psymtab): Add comment.
16339 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16341 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16343 2019-01-10 Tom Tromey <tom@tromey.com>
16345 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16347 * mipsread.c: Include mdebugread.h.
16348 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16350 * elfread.c: Include mdebugread.h.
16352 2019-01-09 Tom Tromey <tom@tromey.com>
16354 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16355 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16356 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16357 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16358 (psym_lookup_symbol, psym_find_last_source_symtab)
16359 (psym_forget_cached_source_info, psym_print_stats)
16360 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16361 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16362 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16363 (psym_find_compunit_symtab_by_address)
16364 (maintenance_print_psymbols, maintenance_info_psymtabs)
16365 (maintenance_check_psymtabs): Use ranged for.
16366 * psymtab.h (class objfile_psymtabs): New.
16367 (require_partial_symbols): Return objfile_psymtabs.
16368 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16370 2019-01-09 Tom Tromey <tom@tromey.com>
16372 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16373 (find_pc_mapped_section, list_overlays_command)
16374 (map_overlay_command, unmap_overlay_command)
16375 (simple_overlay_update): Use all_objfiles.
16376 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16377 * printcmd.c (info_symbol_command): Use all_objfiles.
16378 * objfiles.h (ALL_OBJSECTIONS): Remove.
16379 * maint.c (maintenance_translate_address): Use all_objfiles.
16380 * gcore.c (gcore_create_callback): Use all_objfiles.
16381 (objfile_find_memory_regions): Likewise.
16383 2019-01-09 Tom Tromey <tom@tromey.com>
16385 * symtab.c (find_line_symtab, info_sources_command)
16386 (make_source_files_completion_list): Use objfile_compunits.
16387 * source.c (select_source_symtab): Use objfile_compunits.
16388 * objfiles.h (struct objfile): Update comment.
16389 (ALL_OBJFILES): Remove.
16390 (ALL_FILETABS): Remove.
16391 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16394 2019-01-09 Tom Tromey <tom@tromey.com>
16396 * symmisc.c (print_objfile_statistics, dump_objfile)
16397 (maintenance_print_symbols): Use compunit_filetabs.
16398 * source.c (forget_cached_source_info_for_objfile): Use
16400 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16401 (ALL_FILETABS): Use compunit_filetabs.
16402 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16403 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16405 2019-01-09 Tom Tromey <tom@tromey.com>
16407 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16408 (compunit_filetabs): New.
16409 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16411 (info_sources_command, make_source_files_completion_list): Remove
16413 * symmisc.c (print_objfile_statistics, dump_objfile)
16414 (maintenance_print_symbols): Remove declaration.
16415 (maintenance_info_symtabs): Use compunit_filetabs.
16416 (maintenance_info_line_tables): Likewise.
16417 * source.c (select_source_symtab): Change local variable name.
16418 (forget_cached_source_info_for_objfile): Remove declaration.
16419 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16420 * objfiles.c (objfile_relocate1): Remove declaration.
16421 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16423 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16424 * coffread.c (coff_symtab_read): Remove declaration.
16425 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16428 2019-01-09 Tom Tromey <tom@tromey.com>
16430 * symtab.c (lookup_objfile_from_block)
16431 (find_pc_sect_compunit_symtab, search_symbols)
16432 (default_collect_symbol_completion_matches_break_on): Use
16434 * objfiles.h (ALL_COMPUNITS): Remove.
16435 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16436 * cp-support.c (add_symbol_overload_list_qualified): Use
16438 * ada-lang.c (ada_collect_symbol_completion_matches)
16439 (ada_add_global_exceptions): Use objfile_compunits.
16441 2019-01-09 Tom Tromey <tom@tromey.com>
16443 * source.c (select_source_symtab)
16444 (forget_cached_source_info_for_objfile): Remove declaration.
16445 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16447 * maint.c (count_symtabs_and_blocks): Remove declaration.
16448 * cp-support.c (add_symbol_overload_list_qualified): Remove
16450 * coffread.c (coff_symtab_read): Remove declaration.
16451 * symtab.c (lookup_symbol_in_objfile_symtabs)
16452 (basic_lookup_transparent_type_1): Use objfile_compunits.
16453 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16454 (info_sources_command, search_symbols)
16455 (default_collect_symbol_completion_matches_break_on)
16456 (make_source_files_completion_list): Remove declaration.
16457 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16458 (ada_collect_symbol_completion_matches)
16459 (ada_add_global_exceptions): Remove declaration.
16460 * linespec.c (iterate_over_all_matching_symtabs): Use
16462 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16463 (class objfile_compunits): New.
16464 (ALL_COMPUNITS): Use objfile_compunits.
16465 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16466 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16468 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16470 2019-01-09 Tom Tromey <tom@tromey.com>
16472 * symtab.c (search_symbols)
16473 (default_collect_symbol_completion_matches_break_on): Use
16475 * ada-lang.c (ada_lookup_simple_minsym)
16476 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16477 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16478 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16480 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16481 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16482 * objc-lang.c (find_methods): Use objfile_msymbols.
16483 (info_selectors_command, info_classes_command): Likewise.
16484 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16485 * objfiles.h (class objfile_msymbols): New.
16486 (ALL_OBJFILE_MSYMBOLS): Remove.
16487 (ALL_MSYMBOLS): Remove.
16489 2019-01-09 Tom Tromey <tom@tromey.com>
16491 * common/next-iterator.h (next_adapter): Add Iterator template
16493 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16494 (class all_objfiles_safe): New.
16495 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16496 * objfiles.c (put_objfile_before): Update comment.
16497 (add_separate_debug_objfile): Likewise.
16498 (free_all_objfiles): Use all_objfiles_safe.
16499 (objfile_purge_solibs): Likewise.
16501 2019-01-09 Tom Tromey <tom@tromey.com>
16503 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16504 (expand_symtab_containing_pc, lookup_static_symbol)
16505 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16506 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16508 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16509 * breakpoint.c (create_overlay_event_breakpoint)
16510 (create_longjmp_master_breakpoint)
16511 (create_std_terminate_master_breakpoint)
16512 (create_exception_master_breakpoint): Use all_objfiles.
16513 * linux-thread-db.c (try_thread_db_load_from_pdir)
16514 (has_libpthread): Use all_objfiles.
16515 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16516 * linespec.c (iterate_over_all_matching_symtabs)
16517 (search_minsyms_for_name): Use all_objfiles.
16518 * maint.c (maintenance_info_sections): Use all_objfiles.
16519 * main.c (captured_main_1): Use all_objfiles.
16520 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16521 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16522 * guile/scm-pretty-print.c
16523 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16524 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16525 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16526 (maintenance_print_msymbols): Use all_objfiles.
16527 * source.c (select_source_symtab): Use all_objfiles.
16528 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16529 * symfile.c (remove_symbol_file_command)
16530 (expand_symtabs_matching, map_symbol_filenames): Use
16532 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16534 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16535 * objc-lang.c (find_methods): Use all_objfiles.
16536 * objfiles.c (have_partial_symbols, have_full_symbols)
16537 (have_minimal_symbols, qsort_cmp)
16538 (default_iterate_over_objfiles_in_search_order): Use
16540 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16541 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16542 (maintenance_check_psymtabs): Use all_objfiles.
16543 (ALL_PSYMTABS): Remove.
16544 * compile/compile-object-run.c (do_module_cleanup): Use
16546 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16547 * cp-support.c (add_symbol_overload_list_qualified): Use
16549 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16551 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16552 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16554 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16555 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16556 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16558 * solib.c (solib_read_symbols): Use all_objfiles
16560 2019-01-09 Tom Tromey <tom@tromey.com>
16562 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16563 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16565 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16566 * symmisc.c (print_symbol_bcache_statistics)
16567 (print_objfile_statistics, maintenance_print_objfiles)
16568 (maintenance_info_symtabs, maintenance_check_symtabs)
16569 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16571 * source.c (forget_cached_source_info): Use all_objfiles.
16572 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16573 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16574 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16575 * objfiles.c (update_section_map): Use all_objfiles.
16576 (shared_objfile_contains_address_p): Likewise.
16577 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16578 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16580 2019-01-09 Tom Tromey <tom@tromey.com>
16582 * common/next-iterator.h: New file.
16583 * objfiles.h (class all_objfiles): New.
16584 (struct objfile_iterator): New.
16586 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16588 * NEWS: Move the description of the changed "frame", "select-frame",
16589 and "info frame" commands to the Changed commands section.
16591 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16593 * gdbtypes.c (check_stub_method_group): Remove handling of old
16595 * linespec.c (find_methods): Likewise.
16596 * stabsread.c (read_member_functions): Likewise.
16597 * valops.c (search_struct_method): Likewise.
16598 (value_struct_elt_for_reference): Likewise.
16599 * NEWS: Mention this change.
16601 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16603 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16604 print_source_lines.
16605 * source.c (print_source_lines_base): Update line number check.
16606 (print_source_lines): New function.
16607 (source_lines_range::source_lines_range): New function.
16608 * source.h (class source_lines_range): New class.
16609 (print_source_lines): New declaration.
16611 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16613 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16615 2019-01-08 Tom Tromey <tom@tromey.com>
16616 Simon Marchi <simon.marchi@ericsson.com>
16619 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16620 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16621 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16622 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16623 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16624 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16626 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16628 * source.c (select_source_symtab): Move header comment to
16629 declaration in source.h.
16630 (forget_cached_source_info_for_objfile): Likewise.
16631 (forget_cached_source_info): Likewise.
16632 (identify_source_line): Likewise.
16633 * source.h (identify_source_line): Move declaration from symtab.h
16634 and add comment from source.c
16635 (print_source_lines): Likewise.
16636 (forget_cached_source_info_for_objfile): Likewise.
16637 (forget_cached_source_info): Likewise.
16638 (select_source_symtab): Likewise.
16639 (enum print_source_lines_flag): Move definition from symtab.h.
16640 * symtab.h (identify_source_line): Move declaration to source.h.
16641 (print_source_lines): Likewise.
16642 (forget_cached_source_info_for_objfile): Likewise.
16643 (forget_cached_source_info): Likewise.
16644 (select_source_symtab): Likewise.
16645 (enum print_source_lines_flag): Move definition to source.h.
16646 * tui/tui-hooks.c: Add 'source.h' include.
16648 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16650 * source.c (print_source_lines_base): Handle requests to print
16651 reverse line number sequences, and guard against empty lines
16654 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16656 * source.c (print_source_lines_base): Fix skip of '\r' if next
16659 2019-01-06 Tom Tromey <tom@tromey.com>
16661 * c-exp.y (struct c_parse_state) <macro_original_text,
16662 expansion_obstack>: New member.
16663 (macro_original_text, expansion_obstack): Remove globals.
16664 (scan_macro_expansion, scanning_macro_expansion)
16665 (finished_macro_expansion): Update.
16666 (scan_macro_cleanup): Remove.
16667 (yylex, c_parse): Update.
16669 2019-01-06 Tom Tromey <tom@tromey.com>
16671 * c-exp.y (struct c_parse_state) <strings>: New member.
16672 (operator_stoken): Update.
16674 2019-01-06 Tom Tromey <tom@tromey.com>
16676 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16677 (union type_stack_elt) <typelist_val>: Now a pointer to
16679 (type_stack_cleanup): Don't declare.
16680 (push_typelist): Update.
16681 * parse.c (pop_typelist): Return a std::vector.
16682 (push_typelist): Take a std::vector.
16683 (follow_types): Update. Do not free args.
16684 (type_stack_cleanup): Remove.
16685 * c-exp.y (struct c_parse_state): New.
16686 (cpstate): New global.
16687 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16688 (nonempty_typelist): Update.
16689 (func_mod): Create a new vector.
16690 (c_parse): Create a c_parse_state.
16691 (check_parameter_typelist): Do not delete params.
16692 (function_method): Update. Do not delete type_list.
16694 2019-01-06 Tom Tromey <tom@tromey.com>
16697 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16699 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16700 (print_return_value): Likewise.
16702 2019-01-05 Tom Tromey <tom@tromey.com>
16704 * contrib/cleanup_check.py: Remove.
16705 * contrib/gcc-with-excheck: Remove.
16706 * contrib/exsummary.py: Remove.
16707 * contrib/excheck.py: Remove.
16709 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16711 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16712 NULL. Initialize tpprev to NULL instead of assigning it
16713 to NULL on the next statement.
16714 * windows-nat.c (windows_delete_thread): Remove check for
16715 main_thread_id before printing thread exit notifications.
16716 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16717 Remove thread ID check against main_thread_id.
16718 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16719 windows_delete_thread.
16720 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16722 2019-01-04 Tom Tromey <tom@tromey.com>
16724 * compile/compile.c (_initialize_compile): Use upper case for
16725 metasyntactic variables.
16726 * symmisc.c (_initialize_symmisc): Use upper case for
16727 metasyntactic variables.
16728 * psymtab.c (_initialize_psymtab): Use upper case for
16729 metasyntactic variables.
16730 * demangle.c (demangle_command): Use upper case for metasyntactic
16732 (_initialize_demangler): Likewise.
16733 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16736 2019-01-03 Tom Tromey <tom@tromey.com>
16738 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16740 2019-01-03 Tom Tromey <tom@tromey.com>
16742 * python/py-symtab.c (salpy_str): Update.
16743 (struct salpy_sal_object) <symtab>: Now a PyObject.
16744 (salpy_dealloc): Update.
16745 (del_objfile_sal): Use gdbpy_ref.
16747 2019-01-03 Tom Tromey <tom@tromey.com>
16749 * python/py-type.c (convert_field): Use new_reference. Return
16751 (make_fielditem): Return gdbpy_ref.
16752 (typy_fields): Update.
16753 (typy_getitem): Update.
16754 (field_name): Return gdbpy_ref. Use new_reference.
16755 (typy_iterator_iternext): Update.
16757 2019-01-03 Tom Tromey <tom@tromey.com>
16759 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16761 2019-01-03 Tom Tromey <tom@tromey.com>
16763 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16764 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16765 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16766 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16767 (pspy_set_type_printers): Likewise.
16768 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16769 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16770 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16771 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16772 (objfpy_set_type_printers): Likewise.
16774 2019-01-03 Tom Tromey <tom@tromey.com>
16776 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16777 (gdbpy_print_stack): Use gdbpy_err_fetch.
16778 * python/python-internal.h (class gdbpy_err_fetch): New class.
16779 (class gdbpy_enter) <m_error_type, m_error_value,
16780 m_error_traceback>: Remove.
16781 <m_error>: New member.
16782 (gdbpy_exception_to_string): Don't declare.
16783 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16784 * python/py-value.c (convert_value_from_python): Use
16786 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16787 gdbpy_exception_to_string.
16788 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16789 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16792 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16794 * linux-nat.c (delete_lwp_cleanup): Delete.
16795 (struct lwp_deleter): New struct.
16796 (lwp_info_up): New typedef.
16797 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16800 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16802 * linux-fork.c (class scoped_switch_fork_info): New class.
16803 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16805 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16807 * valops.c (find_overload_match): Remove use of null_cleanup, and
16808 calls to do_cleanups.
16810 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16812 * compile/compile-cplus-types.c
16813 (compile_cplus_instance::decl_name): Handle changes to
16815 * cp-support.c (cp_func_name): Update header comment, update
16817 * cp-support.h (cp_func_name): Update return type in declaration.
16818 * valops.c (find_overload_match): Move temp_func local to top
16819 level of function and change its type. Use temp_func to hold and
16820 delete temporary string obtained from cp_func_name.
16822 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16824 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16825 gdb::char_vector, remove cleanup, and update uses of `msg`.
16827 2019-01-03 Jim Wilson <jimw@sifive.com>
16829 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16831 2019-01-02 Tom Tromey <tom@tromey.com>
16833 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16834 (tdesc_parse_xml): Remove cleanups.
16835 * target-descriptions.h (make_cleanup_free_target_description):
16837 (target_desc_deleter): New struct.
16838 (target_desc_up): New typedef.
16839 * target-descriptions.c (target_desc_deleter::operator()): Rename
16840 from free_target_description.
16841 (make_cleanup_free_target_description): Remove.
16843 2019-01-02 Tom Tromey <tom@tromey.com>
16845 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16846 constructor, destructor.
16847 (linespec_parser): Remove typedef.
16848 (~linespec_parser): Rename from linespec_parser_delete.
16849 (linespec_lex_to_end, linespec_complete_label)
16850 (linespec_complete): Update.
16851 (decode_line_full): Remove cleanups.
16852 (decode_line_1): Update.
16854 2019-01-02 Tom Tromey <tom@tromey.com>
16856 * python/python-internal.h (inferior_to_inferior_object): Change
16858 * python/py-exitedevent.c (create_exited_event_object): Update.
16859 * python/py-inferior.c (inferior_to_inferior_object): Return
16861 (python_new_inferior, python_inferior_deleted)
16862 (thread_to_thread_object, delete_thread_object)
16863 (build_inferior_list, gdbpy_selected_inferior): Update.
16864 * python/py-infthread.c (create_thread_object): Update. Also fail
16865 if inferior_to_inferior_object fails.
16867 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16869 * inferior.h (class inferior) <displaced_step_state>: New field.
16870 * infrun.h (struct displaced_step_state): Move here from
16871 infrun.c. Initialize fields, add constructor.
16872 <inf>: Remove field.
16873 <reset>: New method.
16874 * infrun.c (struct displaced_step_inferior_state): Move to
16876 (displaced_step_inferior_states): Remove.
16877 (get_displaced_stepping_state): Adust.
16878 (displaced_step_in_progress_any_inferior): Adjust.
16879 (displaced_step_in_progress_thread): Adjust.
16880 (displaced_step_in_progress): Adjust.
16881 (add_displaced_stepping_state): Remove.
16882 (get_displaced_step_closure_by_addr): Adjust.
16883 (remove_displaced_stepping_state): Remove.
16884 (infrun_inferior_exit): Call displaced_step_state.reset.
16885 (use_displaced_stepping): Don't check for NULL.
16886 (displaced_step_prepare_throw): Call
16887 get_displaced_stepping_state.
16888 (displaced_step_fixup): Don't check for NULL.
16889 (prepare_for_detach): Don't check for NULL.
16891 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16893 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16894 in case of call that did not complete.
16896 2019-01-02 Andrey Utkin <autkin@undo.io>
16898 * symfile.c (find_separate_debug_file): Fix search of debug files for
16901 2019-01-02 Tom Tromey <tom@tromey.com>
16903 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16905 * python/py-frame.c (frapy_older): Remove cast.
16906 (frapy_newer): Likewise.
16907 * python/py-breakpoint.c (local_setattro): Remove cast.
16908 * python/py-arch.c (archpy_name): Remove local variable.
16909 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16911 2019-01-02 Joel Brobecker <brobecker@adacore.com>
16913 * unittests/basic_string_view/element_access/char/empty.cc:
16914 Fix year range in copyright header.
16916 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16918 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16920 <operator==>: Update with for removed field.
16922 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16923 <isa_features>: ...this.
16924 <abi_features>: New field.
16925 (riscv_isa_flen): Update comment.
16926 (riscv_abi_xlen): New declaration.
16927 (riscv_abi_flen): New declaration.
16928 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16930 (riscv_abi_xlen): New function.
16931 (riscv_isa_flen): Update to get answer from isa_features.
16932 (riscv_abi_flen): New function.
16933 (riscv_has_fp_abi): Update to get answer from abi_features.
16934 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16936 (riscv_call_info) <xlen, flen>: Update comment.
16937 (riscv_call_arg_struct): Remove invalid assertions
16938 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16940 (riscv_gdbarch_init): Gather isa features and abi features
16941 separately, ensure both match on the gdbarch when reusing an old
16942 gdbarch. Relax an error check to allow 32-bit abi float to run on
16943 a target with 64-bit float hardware.
16945 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16947 * source.c (search_command_helper): Stop reverse search
16948 when line 1 has been searched.
16950 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16952 * record-full.c (record_full_base_target::close): Rewrite
16953 record_full_core_buf_list free logic.
16955 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16957 * break-catch-syscall.c (print_one_catch_syscall): xfree
16960 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16962 * top.c (print_gdb_version): Update Copyright year in version
16965 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16967 Update copyright year range in all GDB files.
16969 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16971 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16973 For older changes see ChangeLog-2018.
16979 version-control: never