gdb/ChangeLog

   1 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
   2
   3         * aarch64-fbsd-nat.c: Include regcache.h.
   4         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
   5         argument.
   6         (aarch64_fbsd_nat_target::fetch_registers)
   7         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
   8         variable.
   9         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
  10
  11 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
  12
  13         * fbsd-nat.c: Include gdbarch.h.
  14
  15 2019-07-15  Tom Tromey  <tromey@adacore.com>
  16
  17         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
  18
  19 2019-07-15  Tom Tromey  <tromey@adacore.com>
  20
  21         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
  22         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
  23         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
  24         * cli-out.c (cli_ui_out::do_field_int): New method.
  25         * ui-out.c (ui_out::field_unsigned): New method.
  26         * symfile.c (generic_load): Use field_unsigned.
  27         (print_transfer_performance): Likewise.
  28         * record-btrace.c (ui_out_field_uint): Remove.
  29         (btrace_call_history_insn_range, btrace_call_history): Use
  30         field_unsigned.
  31         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
  32         field_unsigned.
  33         * ui-out.h (class ui_out) <field_unsigned>: New method.
  34         <do_field_unsigned>: Likewise.
  35
  36 2019-07-15  Tom Tromey  <tromey@adacore.com>
  37
  38         * mi/mi-main.c (list_available_thread_groups): Use field_string.
  39         * mi/mi-interp.c (mi_memory_changed): Use field_string.
  40         * target.c (flash_erase_command): Use field_string.
  41         * infrun.c (print_signal_received_reason): Use field_string.
  42         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
  43         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
  44         field_string.
  45         * ada-tasks.c (print_ada_task_info): Use field_string.
  46
  47 2019-07-15  Tom Tromey  <tromey@adacore.com>
  48
  49         * target.c (flash_erase_command): Use field_core_addr.
  50         * symfile.c (generic_load): Use field_core_addr.
  51         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
  52         Use field_core_addr.
  53         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
  54         field_core_addr.
  55
  56 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  57
  58         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
  59         value if its desired type is smaller than a CORE_ADDR and signed.
  60
  61 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  62
  63         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
  64         of changes to field names, and use new is_reference field to
  65         decide if a property is a reference or not.
  66         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
  67         field.
  68         (struct dwarf2_property_baton): Update header comment, rename
  69         'referenced_type' to 'property_type' and update comments.
  70         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
  71         default property type, store in property baton, update to take
  72         accound of renamed field.
  73         (read_func_scope): Update call to attr_to_dynamic_prop.
  74         (read_array_type): Likewise.
  75         (dwarf2_per_cu_addr_sized_int_type): New function.
  76         (read_subrange_index_type): Move type finding code to
  77         dwarf2_per_cu_addr_sized_int_type.
  78         (read_subrange_type): Update calls to attr_to_dynamic_prop.
  79         (dwarf2_per_cu_addr_type): New function.
  80         (set_die_type): Update calls to attr_to_dynamic_prop.
  81
  82 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  83
  84         * dwarf2read.c (read_subrange_index_type): New function.
  85         (read_subrange_type): Move code into new function and call it.
  86         * gdbtypes.c (create_range_type): Add some asserts.
  87
  88 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  89
  90         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
  91         update return statements.
  92         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
  93         declaration, and update comment to match.
  94         * gdbtypes.c (resolve_dynamic_array): Update call to
  95         dwarf2_evaluate_property to match new return type.
  96
  97 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  98
  99         * valarith.c (value_subscripted_rvalue): Change lowerbound
 100         parameter type from int to LONGEST.
 101         * value.h (value_subscripted_rvalue): Likewise in declaration.
 102
 103 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 104
 105         * cli/cli-utils.c (info_print_command_completer): New function.
 106         * cli/cli-utils.h: Add 'completer.h' include, and forward
 107         declaration for 'struct cmd_list_element'.
 108         (info_print_command_completer): Declare.
 109         * stack.c (_initialize_stack): Add completer for 'info locals' and
 110         'info args'.
 111         * symtab.c (_initialize_symtab): Add completer for 'info
 112         variables' and 'info functions'.
 113         * NEWS: Mention completion for additional info commands.
 114
 115 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 116
 117         * cli/cli-utils.c (extract_info_print_args): Delete.
 118         (extract_arg_maybe_quoted): Delete.
 119         (info_print_options_defs): New variable.
 120         (make_info_print_options_def_group): New function.
 121         (extract_info_print_options): Define new function.
 122         * cli/cli-utils.h (extract_info_print_args): Delete.
 123         (struct info_print_options): New structure.
 124         (extract_info_print_options): Declare new function.
 125         * stack.c (info_locals_command): Update to use new
 126         extract_info_print_options, also add a header comment.
 127         (info_args_command): Likewise.
 128         * symtab.c (info_variables_command): Likewise.
 129         (info_functions_command): Likewise.
 130
 131 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 132
 133         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 134         to extract string arguments.
 135         * common/common-utils.c (extract_string_maybe_quoted): New function.
 136         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 137
 138 2019-07-11  Tom Tromey  <tromey@adacore.com>
 139
 140         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 141         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 142         * top.h (gdbinit): Don't declare.
 143         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 144         into...
 145         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 146         * top.c (gdb_init): Don't call init_cli_cmds.
 147         (gdbinit): Remove.
 148         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 149
 150 2019-07-11  Tom Tromey  <tromey@adacore.com>
 151
 152         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 153         after it has been moved.
 154
 155 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 156
 157         * valops.c (value_must_coerce_to_target): Change return type to
 158         bool.
 159         * value.h (value_must_coerce_to_target): Likewise.
 160
 161 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 162
 163         * breakpoint.c (is_hardware_watchpoint): Remove
 164         forward-declaration.
 165         (is_masked_watchpoint): Change return type to bool.
 166         (is_tracepoint): Likewise.
 167         (is_breakpoint): Likewise.
 168         (is_hardware_watchpoint): Likewise.
 169         (is_watchpoint): Likewise.
 170         (is_no_memory_software_watchpoint): Likewise.
 171         (is_catchpoint): Likewise.
 172         (breakpoint_1): Make FILTER parameter's return type bool.
 173         is_masked_watchpoint): Change return type to bool.
 174         (save_breakpoints): Make FILTER parameter's return type bool.
 175         * breakpoint.h (is_breakpoint): Change return type to bool.
 176         (is_watchpoint): Likewise.
 177         (is_catchpoint): Likewise.
 178         (is_tracepoint): Likewise.
 179
 180 2019-07-10  Tom Tromey  <tom@tromey.com>
 181
 182         * defs.h: Don't include gdbarch.h.
 183         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 184         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 185         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 186         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 187         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 188         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 189         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 190         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 191         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 192         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 193         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 194         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 195         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 196         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 197         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 198         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 199         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 200         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 201         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 202         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 203         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 204         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 205         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 206         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 207         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 208         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 209         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 210
 211 2019-07-10  Tom Tromey  <tromey@adacore.com>
 212
 213         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 214         * breakpoint.c (init_ada_exception_breakpoint): Register as
 215         bp_catchpoint.
 216         (print_one_breakpoint_location, print_one_breakpoint): Use
 217         is_ada_exception_catchpoint.
 218         * ada-lang.c (class ada_catchpoint_location): Pass
 219         bp_loc_software_breakpoint to bp_location constructor.
 220         (is_ada_exception_catchpoint): New function.
 221
 222 2019-07-10  Tom Tromey  <tromey@adacore.com>
 223
 224         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 225         VEC.
 226         (struct arm_exidx_entry): New method operator<.
 227         (struct arm_exidx_data) <section_maps>: Change type.
 228         (arm_exidx_data_free): Remove.
 229         (arm_exidx_data_key): Change type.  Move lower.
 230         (arm_exidx_new_objfile): Update.
 231         (arm_compare_exidx_entries): Remove.
 232         (arm_find_exidx_entry, _initialize_arm_tdep)
 233
 234 2019-07-10  Tom Tromey  <tromey@adacore.com>
 235
 236         * solib-spu.c (ocl_program_data_key): Change type.
 237         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 238         Update.
 239
 240 2019-07-10  Tom Tromey  <tromey@adacore.com>
 241
 242         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 243         (struct solib_aix_inferior_data) <library_list>: Change type.
 244         (solib_aix_inferior_data_handle): Change type.
 245         (get_solib_aix_inferior_data): Update.
 246         (solib_aix_free_library_list): Remove.
 247         (library_list_start_library): Update.
 248         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 249         return type.
 250         (solib_aix_get_library_list)
 251         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 252         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 253
 254 2019-07-10  Tom Tromey  <tromey@adacore.com>
 255
 256         * solib-dsbt.c (struct dsbt_info): Add initializers.
 257         (solib_dsbt_pspace_data): Change type.
 258         (dsbt_pspace_data_cleanup): Remove.
 259         (get_dsbt_info, _initialize_dsbt_solib): Update.
 260
 261 2019-07-10  Tom Tromey  <tromey@adacore.com>
 262
 263         * spu-tdep.c (spu_overlay_data): Change type.
 264         (spu_get_overlay_table, spu_overlay_new_objfile)
 265         (_initialize_spu_tdep): Update.
 266
 267 2019-07-10  Tom Tromey  <tromey@adacore.com>
 268
 269         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 270         destructor.
 271         (dbx_objfile_data_key): Change type and declare later.
 272         (DBX_SYMFILE_INFO): Rewrite.
 273         * dbxread.c (dbx_objfile_data_key): Change type.
 274         (dbx_symfile_init): Update.
 275         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 276         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 277         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 278
 279 2019-07-10  Tom Tromey  <tromey@adacore.com>
 280
 281         * jit.c (jit_program_space_key): Change type.  Move lower.
 282         (get_jit_program_space_data): Update.
 283         (jit_program_space_data_cleanup): Remove.
 284         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 285         Update.
 286         (struct jit_program_space_data): Add initializers.
 287
 288 2019-07-10  Tom Tromey  <tromey@adacore.com>
 289
 290         * solib-darwin.c (struct darwin_info): Add initializers.
 291         (solib_darwin_pspace_data): Change type.
 292         (darwin_pspace_data_cleanup): Remove.
 293         (get_darwin_info, _initialize_darwin_solib): Update.
 294
 295 2019-07-10  Tom Tromey  <tromey@adacore.com>
 296
 297         * remote-sim.c (struct sim_inferior_data): Add initializers,
 298         constructor, and destructor.
 299         (sim_inferior_data_key): Change type.  Move lower.
 300         (check_for_duplicate_sim_descriptor): Update.
 301         (get_sim_inferior_data): Use new.  Update.
 302         (~sim_inferior_data_cleanup): Rename from
 303         sim_inferior_data_cleanup.  Simplify.
 304         (gdbsim_close_inferior, simulator_command)
 305         (sim_command_completer, _initialize_remote_sim): Update.
 306         (next_pid, INITIAL_PID): Move earlier.
 307
 308 2019-07-10  Tom Tromey  <tromey@adacore.com>
 309
 310         * python/python-internal.h (create_thread_object): Return
 311         gdbpy_ref.
 312         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 313         * python/py-inferior.c (struct threadlist_entry): Add
 314         constructor.
 315         <thread_obj>: Now a gdbpy_ref.
 316         (thread_to_thread_object): Update.
 317         (add_thread_object): Use new.
 318         (delete_thread_object): Use delete.
 319         (infpy_threads): Update.
 320         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 321         GIL.
 322
 323 2019-07-10  Tom Tromey  <tromey@adacore.com>
 324
 325         * valops.c (value_cast): Specialize error message for Ada.
 326
 327 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 328
 329         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 330
 331 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 332
 333         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 334         bpstat_should_step): Return bool, adjust comments.
 335         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 336         bpstat_should_step): Likewise.
 337
 338 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 339
 340         * features/Makefile: Use feature target descriptions for Arm.
 341         * features/arm/arm-core.c: Generate new file.
 342         * features/arm/arm-fpa.c: Likewise.
 343         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 344         * features/arm/arm-m-profile.c: Likewise.
 345         * features/arm/arm-vfpv2.c: Likewise.
 346         * features/arm/arm-vfpv3.c: Likewise.
 347         * features/arm/xscale-iwmmxt.c: Likewise.
 348         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 349
 350 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 351
 352         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 353         ptrace earlier.
 354
 355 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 356
 357         * features/aarch64-pauth.c: Regenerate.
 358
 359 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 360
 361         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 362         bool.
 363         (bpstat_what): Use false instead of 0.
 364
 365 2019-07-09  Pedro Alves  <palves@redhat.com>
 366
 367         * break-catch-throw.c (is_exception_catchpoint): New.
 368         * breakpoint.c (print_one_breakpoint_location): New parameter
 369         'raw_loc'.  Handle it.  Use
 370         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 371         looking at the breakpoint's type.
 372         (print_one_breakpoint): If handling "maint info breakpoints", also
 373         print locations of exception catchpoints.
 374         * breakpoint.h (is_exception_catchpoint): Declare.
 375
 376 2019-07-09  Pedro Alves  <palves@redhat.com>
 377
 378         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 379         "addr" field.
 380         (allocate_location_exception_catchpoint): New.
 381         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 382         (initialize_throw_catchpoint_ops): Install
 383         allocate_location_exception_catchpoint as allocate_location
 384         method.
 385         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 386         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 387         bp_loc_other.
 388         (breakpoint_address_is_meaningful): Delete.
 389         (bl_address_is_meaningful): New.
 390         (breakpoint_locations_match): Adjust comment.
 391         (bp_location_from_bp_type): New, factored out of...
 392         (bp_location::bp_location(breakpoint *)): ... this.
 393         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 394         factored out of...
 395         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 396         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 397         breakpoint_address_is_meaningful.
 398         (bp_locations_compare): Adjust comment.
 399         (update_global_location_list): Use bl_address_is_meaningful
 400         instead of breakpoint_address_is_meaningful.
 401         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 402         explicit.
 403         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 404         * python/py-breakpoint.c (bppy_get_location): No longer check
 405         whether location is null.
 406
 407 2019-07-09  Pedro Alves  <palves@redhat.com>
 408
 409         PR c++/15468
 410         * breakpoint.c (print_one_breakpoint_location): Remove
 411         single-location assert.
 412
 413 2019-07-09  Tom Tromey  <tom@tromey.com>
 414
 415         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 416         * configure: Rebuild.
 417         * configure.ac: Change common to gdbsupport.
 418         * gdbsupport: Rename from common.
 419         * acinclude.m4: Change common to gdbsupport.
 420         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 421         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 422         gdbsupport.
 423         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 424         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 425         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 426         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 427         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 428         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 429         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 430         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 431         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 432         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 433         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 434         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 435         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 436         coff-pe-read.c, command.h, compile/compile-c-support.c,
 437         compile/compile-c.h, compile/compile-cplus-symbols.c,
 438         compile/compile-cplus-types.c, compile/compile-cplus.h,
 439         compile/compile-loc2c.c, compile/compile.c, completer.c,
 440         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 441         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 442         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 443         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 444         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 445         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 446         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 447         features/aarch64-core.c, features/aarch64-fpu.c,
 448         features/aarch64-pauth.c, features/aarch64-sve.c,
 449         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 450         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 451         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 452         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 453         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 454         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 455         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 456         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 457         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 458         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 459         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 460         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 461         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 462         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 463         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 464         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 465         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 466         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 467         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 468         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 469         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 470         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 471         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 472         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 473         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 474         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 475         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 476         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 477         minsyms.c, mips-linux-tdep.c, namespace.h,
 478         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 479         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 480         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 481         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 482         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 483         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 484         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 485         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 486         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 487         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 488         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 489         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 490         procfs.c, producer.c, progspace.h, psymtab.h,
 491         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 492         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 493         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 494         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 495         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 496         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 497         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 498         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 499         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 500         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 501         target-memory.c, target.c, target.h, target/waitstatus.c,
 502         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 503         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 504         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 505         unittests/array-view-selftests.c,
 506         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 507         unittests/common-utils-selftests.c,
 508         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 509         unittests/format_pieces-selftests.c,
 510         unittests/function-view-selftests.c,
 511         unittests/lookup_name_info-selftests.c,
 512         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 513         unittests/mkdir-recursive-selftests.c,
 514         unittests/observable-selftests.c,
 515         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 516         unittests/parse-connection-spec-selftests.c,
 517         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 518         unittests/scoped_fd-selftests.c,
 519         unittests/scoped_mmap-selftests.c,
 520         unittests/scoped_restore-selftests.c,
 521         unittests/string_view-selftests.c, unittests/style-selftests.c,
 522         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 523         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 524         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 525         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 526         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 527         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 528
 529 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 530
 531         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 532         bool value.
 533         (decode_digits_ordinary): Set explicit_line field in sal.
 534         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 535         symtab_and_line that was set on an explicit line number in
 536         assembler code.  Do always update the recorded symtab and line if
 537         we do skip the prologue.
 538
 539 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 540
 541         * breakpoint.c (set_breakpoint_location_function): Remove
 542         explicit_loc parameter.
 543         (momentary_breakpoint_from_master): Update call to
 544         set_breakpoint_location_function.
 545         (add_location_to_breakpoint): Likewise.
 546
 547 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 548
 549         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 550         required features based on default bfd type when no specific bfd
 551         is present.
 552
 553 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 554
 555         * NEWS: Mention that GDB printf and eval commands can now print
 556         C-style and Ada-style convenience var strings without
 557         calling the inferior.
 558         * printcmd.c (printf_c_string): Locally print GDB internal var
 559         instead of transiting via the inferior.
 560         (printf_wide_c_string): Likewise.
 561
 562 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 563
 564         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 565
 566 2019-07-04  Tom Tromey  <tom@tromey.com>
 567
 568         PR tui/24724:
 569         * tui/tui-winsource.c (tui_clear_source_content): Update.
 570         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 571         (tui_update_breakpoint_info): Update.
 572         (tui_set_exec_info_content): Update.
 573         * tui/tui-source.c (tui_set_source_content_nil): Update.
 574         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 575         has_break.
 576         * tui/tui-data.h (enum tui_bp_flag): New.
 577         (tui_bp_flags): New enum flags type.
 578         (struct tui_source_element) <break_mode>: Change type.  Rename
 579         from has_break.
 580         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 581         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 582         constants.
 583         * tui/tui-winsource.h: Fix comment.
 584
 585 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 586
 587         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 588         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 589         (store_fpregs_to_thread)
 590         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 591         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 592         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 593         (IWMMXT_REGS_SIZE): Add define.
 594         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 595         (fetch_vfp_regs, store_vfp_regs)
 596         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 597         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 598
 599 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 600
 601         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 602         defines.
 603         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 604         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 605         (ARM_INT_REGISTER_SIZE): ...to this.
 606         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 607         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 608         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 609         (arm_linux_collect_gregset, supply_nwfpe_register)
 610         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 611         defines.
 612         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 613         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 614         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 615         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 616         (arm_return_in_memory, arm_store_return_value)
 617         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 618         (arm_record_ld_st_multiple): Likewise.
 619         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 620         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 621
 622 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 623
 624         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 625         AARCH64_DISPLACED_MODIFIED_INSNS.
 626         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 627         (aarch64_displaced_step_copy_insn): Likewise.
 628         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 629         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 630         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 631         ARM_DISPLACED_MODIFIED_INSNS.
 632         * arm-tdep.c (arm_gdbarch_init): Likewise.
 633         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 634         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 635         (struct arm_displaced_step_closure): Use
 636         ARM_DISPLACED_MODIFIED_INSNS.
 637
 638 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 639
 640         * features/Makefile: Remove unused xml files.
 641         * features/aarch64.xml: Remove.
 642         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 643         * features/i386/amd64-avx-avx512.xml: Remove.
 644         * features/i386/amd64-avx-linux.xml: Remove.
 645         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 646         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 647         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 648         * features/i386/amd64-avx-mpx.xml: Remove.
 649         * features/i386/amd64-avx.xml: Remove.
 650         * features/i386/amd64-linux.xml: Remove.
 651         * features/i386/amd64-mpx-linux.xml: Remove.
 652         * features/i386/amd64-mpx.xml: Remove.
 653         * features/i386/amd64.xml: Remove.
 654         * features/i386/i386-avx-avx512-linux.xml: Remove.
 655         * features/i386/i386-avx-avx512.xml: Remove.
 656         * features/i386/i386-avx-linux.xml: Remove.
 657         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 658         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 659         * features/i386/i386-avx-mpx-linux.xml: Remove.
 660         * features/i386/i386-avx-mpx.xml: Remove.
 661         * features/i386/i386-avx.xml: Remove.
 662         * features/i386/i386-linux.xml: Remove.
 663         * features/i386/i386-mmx-linux.xml: Remove.
 664         * features/i386/i386-mmx.xml: Remove.
 665         * features/i386/i386-mpx-linux.xml: Remove.
 666         * features/i386/i386-mpx.xml: Remove.
 667         * features/i386/i386.xml: Remove.
 668         * features/i386/x32-avx-avx512-linux.xml: Remove.
 669         * features/i386/x32-avx-linux.xml: Remove.
 670         * features/i386/x32-linux.xml: Remove.
 671
 672 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 673
 674         * regformats/aarch64.dat: Remove.
 675         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 676         * regformats/i386/amd64-avx-linux.dat: Remove.
 677         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 678         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 679         * regformats/i386/amd64-linux.dat: Remove.
 680         * regformats/i386/amd64-mpx-linux.dat: Remove.
 681         * regformats/i386/amd64.dat: Remove.
 682         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 683         * regformats/i386/i386-avx-linux.dat: Remove.
 684         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 685         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 686         * regformats/i386/i386-linux.dat: Remove.
 687         * regformats/i386/i386-mmx-linux.dat: Remove.
 688         * regformats/i386/i386-mpx-linux.dat: Remove.
 689         * regformats/i386/i386.dat: Remove.
 690         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 691         * regformats/i386/x32-avx-linux.dat: Remove.
 692         * regformats/i386/x32-linux.dat: Remove.
 693
 694 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 695
 696         * aarch64-tdep.c: Remove xml self tests.
 697         * amd64-linux-tdep.c: Likewise.
 698         * amd64-tdep.c: Likewise.
 699         * i386-linux-tdep.c: Likewise.
 700         * i386-tdep.c: Likewise.
 701
 702 2019-07-03  Pedro Alves  <palves@redhat.com>
 703
 704         PR cli/24732
 705         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 706         (pipe_cmd_option_defs): New.
 707         (make_pipe_cmd_options_def_group): New.
 708         (pipe_command): Use gdb::option::process_options.
 709         (pipe_command_completer): New function.
 710         (_initialize_cli_cmds): Install completer for "pipe" command.
 711
 712 2019-07-03  Pedro Alves  <palves@redhat.com>
 713
 714         * cli/cli-option.c (union option_value) <string>: New field.
 715         (struct option_def_and_value): Add ctor, move ctor, dtor and
 716         use DISABLE_COPY_AND_ASSIGN.
 717         (option_def_and_value::clear_value): New.
 718         (parse_option, save_option_value_in_ctx, get_val_type_str)
 719         (add_setshow_cmds_for_options): Handle var_string.
 720         * cli-option.h (union option_def::var_address) <string>: New
 721         field.
 722         (struct string_option_def): New.
 723         * maint-test-options.c (struct test_options_opts): Add default
 724         ctor and use DISABLE_COPY_AND_ASSIGN.
 725         <string_opt>: New field.
 726         (test_options_opts::~test_options_opts): New.
 727         (test_options_opts::dump): Also dump "-string".
 728         (test_options_option_defs): Install "string.
 729
 730 2019-07-03  Pedro Alves  <palves@redhat.com>
 731
 732         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 733         option_value with a null enumeration.
 734         (complete_options): Save the option values in the context.
 735         (save_option_value_in_ctx): New, factored out from ...
 736         (process_options): ... here.
 737         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 738         of the function.
 739         * maint-test-options.c (test_options_opts::dump): New, factored
 740         out from ...
 741         (maintenance_test_options_command_mode): ... here.
 742         (maintenance_test_options_command_completion_result): Delete.
 743         (maintenance_test_options_command_completion_text): Update
 744         comment.
 745         (maintenance_show_test_options_completion_result): Change
 746         prototype.  Just print
 747         maintenance_test_options_command_completion_text.
 748         (save_completion_result): New.
 749         (maintenance_test_options_completer_mode): Pass options context to
 750         complete_options, and then save a dump.
 751         (_initialize_maint_test_options): Use add_cmd to install "maint
 752         show test-options-completion-result".
 753
 754 2019-07-03  Pedro Alves  <palves@redhat.com>
 755
 756         * NEWS (New commands): Mention "with" and "maint with".
 757         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 758         (with_command, with_command_completer): New.
 759         (pipe_command): Adjust to new repeat_previous
 760         interface.
 761         (_initialize_cli_cmds): Install the "with" command and its "w"
 762         alias.
 763         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 764         declarations.
 765         * cli/cli-setshow.c (parse_cli_var_uinteger)
 766         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 767         argument strings for all var_types.
 768         (get_setshow_command_value_string): New, factored out from ...
 769         (do_show_command): ... this.
 770         * cli/cli-setshow.h: Include <string>.
 771         (get_setshow_command_value_string): Declare.
 772         * command.h (repeat_previous): Now returns const char *.  Adjust
 773         comment.
 774         * maint.c: Include "cli/cli-cmds.h".
 775         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 776         (_initialize_maint_cmds): Register the "maintenance with" command.
 777         * top.c (repeat_previous): Move bits from pipe_command here:
 778         Return the saved command line, if any; error out if there's no
 779         command to relaunch.
 780
 781 2019-07-03  Pedro Alves  <palves@redhat.com>
 782
 783         * NEWS (New commands): Mention "maint set/show test-settings"
 784         instead of "maint test-settings".
 785         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 786         (maintenance_test_settings_set_list): Rename to ...
 787         (maintenance_set_test_settings_list): ... this.
 788         (maintenance_test_settings_show_list): Rename to  ...
 789         (maintenance_show_test_settings_list): ... this.
 790         (maintenance_test_settings_cmd): Delete.
 791         (maintenance_test_settings_set_cmd): ...
 792         (maintenance_set_test_settings_cmd): ... this.
 793         (maintenance_test_settings_show_cmd): ...
 794         (maintenance_show_test_settings_cmd): ... this.
 795         (maintenance_test_settings_show_value_cmd):
 796         (maintenance_show_test_settings_value_cmd): ... this.
 797         (_initialize_maint_test_settings): No longer install the "maint
 798         test-settings" prefix command.  Rename "maint test-settings set"
 799         to "maint set test-settings", and "maint test-settings show" to
 800         "maint show test-settings".  Adjust all subcommands.
 801
 802 2019-07-03  Pedro Alves  <palves@redhat.com>
 803
 804         * maint-test-settings.c: Fix file's intro comment.  Replace all
 805         references to "test-options" with references to "test-settings",
 806         in comments.
 807
 808 2019-07-03  Pedro Alves  <palves@redhat.com>
 809
 810         * maint-test-settings.c (maintenance_test_settings_xxx)
 811         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 812         New.
 813         (maintenance_test_settings_enums): Use them.
 814         (maintenance_test_settings_enum): Default to
 815         maintenance_test_settings_xxx.
 816         (_initialize_maint_test_settings): Initialize
 817         MAINTENANCE_TEST_SETTINGS_FILENAME.
 818
 819 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 820
 821         * breakpoint.h (remove_breakpoints_inf): Change return type to
 822         void, move function documentation here.
 823         * breakpoint.c (remove_breakpoints_inf): Change return type to
 824         void, move function documentation to header.
 825
 826 2019-07-02  Pedro Alves  <palves@redhat.com>
 827
 828         * NEWS (Completion improvements): Mention "info threads".
 829         * thread.c (struct info_threads_opts, info_threads_option_defs)
 830         (make_info_threads_options_def_group): New.
 831         (info_threads_command): Use gdb::option::process_options.
 832         (info_threads_command_completer): New.
 833         (_initialize_thread): Use gdb::option::build_help to build the
 834         help text for "info threads".
 835
 836 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 837
 838         * defs.h (generic_load): Move from here...
 839         * symfile.h (generic_load): ... to here.  Rename name parameter
 840         to args.
 841         * symfile.c (generic_load): Add comment.
 842
 843 2019-07-01  Tom Tromey  <tromey@adacore.com>
 844
 845         * dwarf2read.c
 846         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 847         declaration of without_params.  Fix formatting.
 848
 849 2019-07-01  Tom Tromey  <tromey@adacore.com>
 850
 851         * ada-exp.y (find_primitive_type): Update.
 852         * ada-lang.h (ada_lookup_symbol): Update.
 853         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 854         parameter.
 855         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 856
 857 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 858
 859         PR breakpoints/24541
 860         * gdbarch.c: Regenerate.
 861         * gdbarch.h: Regenerate.
 862         * gdbarch.sh: Add 'stap_adjust_register'.
 863         * i386-tdep.c: Include '<unordered_set>'.
 864         (i386_stap_adjust_register): New function.
 865         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 866         * stap-probe.c (stap_parse_register_operand): Call
 867         'gdbarch_stap_adjust_register'.
 868
 869 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 870
 871         PR python/24742
 872         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 873         * python/python.c (do_start_initialization): Use 'xmalloc'
 874         instead of 'PyMem_Malloc'.
 875
 876 2019-06-28  Tom Tromey  <tromey@adacore.com>
 877
 878         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 879         for Ada.
 880
 881 2019-06-27  Tom Tromey  <tromey@adacore.com>
 882
 883         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 884         objfile_key.
 885         (arm_find_mapping_symbol, arm_record_special_symbol)
 886         (_initialize_arm_tdep): Update.
 887         (arm_objfile_data_free): Remove.
 888
 889 2019-06-27  Tom Tromey  <tromey@adacore.com>
 890
 891         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 892         to cp_print_static_field.
 893
 894 2019-06-26  Tom Tromey  <tromey@adacore.com>
 895
 896         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 897         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 898         declare.
 899
 900 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 901
 902         * features/aarch64-core.c (create_feature_aarch64_core):
 903         Regenerate.
 904         * features/aarch64-core.xml: Add cpsr flags.
 905
 906 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 907
 908         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 909         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 910
 911 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 912
 913         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 914         field.
 915         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 916         use.
 917         (arm_record_special_symbol): Don't insert new symbol in sorted
 918         position, push it at the end.
 919
 920 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 921
 922         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 923         (arm_mapping_symbol_s): Remove.
 924         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 925         (arm_mapping_symbol_vec): New typedef.
 926         (struct arm_per_objfile): Add constructor.
 927         <section_maps>: Change type to
 928         std::unique_ptr<arm_mapping_symbol_vec[]>.
 929         (arm_compare_mapping_symbols): Remove.
 930         (arm_find_mapping_symbol): Adjust to section_maps type change.
 931         (arm_objfile_data_free): Call delete on arm_per_objfile.
 932         (arm_record_special_symbol): Adjust to section_maps type change.
 933         Allocate arm_per_objfile with new.
 934
 935 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 936
 937         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 938         with the command prefix.
 939
 940 2019-06-25  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 943         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 944
 945 2019-06-25  Tom Tromey  <tom@tromey.com>
 946
 947         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 948         type.
 949         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 950         protected.
 951
 952 2019-06-25  Tom Tromey  <tom@tromey.com>
 953
 954         * tui/tui-winsource.c
 955         (tui_source_window_base::set_is_exec_point_at): Add check against
 956         LOA_ADDRESS.
 957
 958 2019-06-25  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-source.c (tui_set_source_content): Don't check before
 961         xfree.
 962         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 963
 964 2019-06-25  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui-winsource.h (tui_update_source_window_as_is)
 967         (tui_alloc_source_buffer, tui_line_is_displayed)
 968         (tui_addr_is_displayed): Change type of win_info.
 969         * tui/tui-winsource.c (tui_update_source_window_as_is)
 970         (tui_clear_source_content, tui_show_source_line)
 971         (tui_show_source_content, tui_source_window_base::refill)
 972         (tui_source_window_base::set_is_exec_point_at)
 973         (tui_source_window_base::set_is_exec_point_at)
 974         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 975         (tui_alloc_source_buffer, tui_line_is_displayed)
 976         (tui_addr_is_displayed): Change type of win_info.  Update.
 977         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 978         (tui_source_window_base::do_make_visible_with_new_height):
 979         Update.
 980         * tui/tui-source.c (tui_set_source_content)
 981         (tui_set_source_content_nil)
 982         (tui_source_window::do_scroll_vertical): Update.
 983         * tui/tui-layout.c (show_layout): Update.
 984         * tui/tui-disasm.c (tui_set_disassem_content)
 985         (tui_disasm_window::do_scroll_vertical): Update.
 986         * tui/tui-data.h (tui_win_content): Remove.
 987         (struct tui_gen_win_info) <content, content_size>: Remove.
 988         (struct tui_source_element): Add initializers and destructor.
 989         (union tui_which_element, struct tui_win_element): Remove.
 990         (struct tui_source_window_base) <content>: New field.
 991         (struct tui_data_window): Remove destructor.
 992         (tui_alloc_content, tui_free_win_content)
 993         (tui_free_all_source_wins_content): Don't declare.
 994         * tui/tui-data.c (tui_initialize_static_data): Update.
 995         (init_content_element, tui_alloc_content): Remove.
 996         (~tui_gen_win_info): Update.
 997         (~tui_data_window, tui_free_all_source_wins_content)
 998         (tui_free_win_content, free_content, free_content_elements):
 999         Remove.
1000
1001 2019-06-25  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui-winsource.h (tui_clear_source_content)
1004         (tui_erase_source_content, tui_show_source_content): Change type
1005         of win_info.
1006         * tui/tui-winsource.c (tui_clear_source_content)
1007         (tui_erase_source_content, tui_show_source_content): Change type
1008         of win_info.
1009         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1010         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1011         win_info.
1012         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1013         win_info.
1014         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1015
1016 2019-06-25  Tom Tromey  <tom@tromey.com>
1017
1018         * tui/tui-winsource.c (tui_clear_source_content)
1019         (tui_source_window_base::set_is_exec_point_at): Update.
1020         * tui/tui-source.c (tui_set_source_content_nil): Update.
1021         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1022         a bool.
1023         * tui/tui-data.c (init_content_element): Update.
1024
1025 2019-06-25  Tom Tromey  <tom@tromey.com>
1026
1027         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1028         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1029         * tui/tui-layout.c (init_and_make_win): Update.
1030         * tui/tui.h (enum tui_win_type): Update.
1031         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1032         tui_win_is_auxillary.
1033         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1034         tui_win_is_auxillary.
1035
1036 2019-06-25  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1039         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1040         (tui_delete_data_content_windows, tui_display_all_data)
1041         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1042         Update.
1043         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1044         * tui/tui-regs.c (tui_last_regs_line_no)
1045         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1046         (tui_show_registers): Update.
1047         (tui_show_register_group): Return void.  Update.
1048         (tui_display_registers_from, tui_display_reg_element_at_line)
1049         (tui_display_registers_from_line, tui_check_register_values):
1050         Update.
1051         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1052         member.
1053         (struct tui_data_window) <regs_content>: Now a std::vector.
1054         <regs_content_count>: Remove.
1055         (tui_add_content_elements, tui_free_data_content): Don't declare.
1056         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1057         (init_content_element): Remove DATA_WIN case.  Add assert.
1058         (tui_add_content_elements): Remove.
1059         (tui_data_window): Update.
1060         (tui_free_data_content): Remove.
1061         (free_content_elements): Remove DATA_WIN case.
1062
1063 2019-06-25  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-data.c (tui_data_item_window): Update.
1066         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1067         * tui/tui-windata.c (tui_display_all_data)
1068         (tui_display_data_from_line): Update.
1069         (tui_check_data_values): Remove.
1070         * tui/tui-regs.c (tui_show_register_group)
1071         (tui_display_reg_element_at_line): Update.
1072         * tui/tui-hooks.c (tui_register_changed)
1073         (tui_refresh_frame_and_register_information): Call
1074         tui_check_register_values.
1075         * tui/tui-data.h (struct tui_data_window) <data_content,
1076         data_content_count, data_type>: Remove.
1077         (enum tui_data_type): Remove.
1078
1079         * tui/tui-data.c (tui_data_window::clear_detail)
1080         (~tui_data_window): Update.
1081
1082 2019-06-25  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1085         declare.
1086         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1087         Rename from tui_first_data_item_displayed.  Update.
1088         (tui_data_window::refresh_all)
1089         (tui_data_window::do_scroll_vertical): Update.
1090         * tui/tui-data.h (struct tui_data_window)
1091         <first_data_item_displayed>: Declare new method.
1092
1093 2019-06-25  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1096         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1097         contents...
1098         (tui_initialize_static_data): ...here.
1099
1100 2019-06-25  Tom Tromey  <tom@tromey.com>
1101
1102         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1103         (tui_display_registers_from, tui_check_register_values): Update.
1104         (tui_display_register): Remove win_info parameter; update.
1105         (tui_get_register): Change type of parameters.
1106         * tui/tui-data.h (struct tui_data_element): Remove.
1107         (union tui_which_element) <data>: Remove.
1108         <data_window>: Change type.
1109         (struct tui_data_item_window): New.
1110         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1111         case.  Add assert.
1112         (~tui_data_item_window): New destructor.
1113         (free_content_elements): Remove DATA_ITEM_WIN case.
1114
1115 2019-06-25  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1118         Remove.
1119
1120 2019-06-25  Tom Tromey  <tom@tromey.com>
1121
1122         * tui/tui-data.h (struct tui_command_element): Remove.
1123         (union tui_which_element) <command>: Remove.
1124         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1125         assert.
1126         (free_content_elements): Remove CMD_WIN case.
1127
1128 2019-06-25  Tom Tromey  <tom@tromey.com>
1129
1130         * tui/tui-layout.c (tui_set_layout): Update.
1131         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1132         * tui/tui-data.c (layout_def): Update.
1133
1134 2019-06-25  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1137         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1138         (tui_source_window_base::set_new_height): Update.
1139         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1140         Update.
1141         (tui_set_locator_fullname, tui_set_locator_info)
1142         (tui_show_frame_info): Update.
1143         * tui/tui-source.c (tui_set_source_content)
1144         (tui_source_is_displayed): Update.
1145         * tui/tui-layout.c (show_source_disasm_command, show_data)
1146         (show_source_or_disasm_and_command): Update.
1147         * tui/tui-disasm.c (tui_set_disassem_content)
1148         (tui_get_begin_asm_address): Update.
1149         * tui/tui-data.h (struct tui_locator_element): Remove.
1150         (union tui_which_element) <locator>: Remove.
1151         (struct tui_locator_window): New.
1152         (tui_locator_win_info_ptr): Change return type.
1153         * tui/tui-data.c (_locator): Change type.
1154         (tui_locator_win_info_ptr): Change return type.
1155         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1156         (tui_alloc_content): Add assert.
1157
1158 2019-06-25  Tom Tromey  <tom@tromey.com>
1159
1160         * tui/tui-winsource.c
1161         (tui_exec_info_window::maybe_allocate_content): New method.
1162         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1163         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1164         (make_source_or_disasm_window): Add cast.
1165         * tui/tui-data.h (union tui_which_element) <simple_string>:
1166         Remove.
1167         (struct tui_source_info): New.
1168         (struct tui_source_window_base) <execution_info>: Change type.
1169         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1170         case, and add assert.
1171         (tui_alloc_content): Add assert.
1172
1173 2019-06-25  Tom Tromey  <tom@tromey.com>
1174
1175         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1176         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1177         * tui/tui-data.c (tui_alloc_win_info): Remove.
1178
1179 2019-06-25  Tom Tromey  <tom@tromey.com>
1180
1181         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1182         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1183         can_highlight.
1184
1185 2019-06-25  Tom Tromey  <tom@tromey.com>
1186
1187         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1188         make_visible_with_new_height method.
1189         (tui_win_info::make_visible_with_new_height): New method.
1190         (tui_source_window_base::do_make_visible_with_new_height)
1191         (tui_data_window::do_make_visible_with_new_height)
1192         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1193         (make_visible_with_new_height): Remove.
1194         (tui_resize_all, tui_adjust_win_heights): Use
1195         make_visible_with_new_height method.
1196         * tui/tui-data.h (struct tui_win_info)
1197         <do_make_visible_with_new_height, make_visible_with_new_height>:
1198         New methods.
1199         (struct tui_source_window_base, struct tui_data_window)
1200         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1201         methods.
1202
1203 2019-06-25  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1206         method.
1207         (update_tab_width): Call update_tab_width method.
1208         * tui/tui-data.h (struct tui_win_info)
1209         (struct tui_source_window_base) <update_tab_width>: New methods.
1210
1211 2019-06-25  Tom Tromey  <tom@tromey.com>
1212
1213         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1214         parameter.
1215         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1216         parameter.
1217         (tui_gen_win_info::make_visible): Update.
1218         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1219         parameter.
1220         * tui/tui-data.h (enum tui_box): New enum.
1221         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1222
1223 2019-06-25  Tom Tromey  <tom@tromey.com>
1224
1225         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1226         init_and_make_win for EXEC_INFO_WIN.
1227         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1228         longer inline.
1229         (struct tui_win_info) <~tui_win_info>: Inline.
1230         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1231         Don't declare.
1232         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1233         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1234         Remove.
1235         (tui_initialize_static_data): Update.
1236         (~tui_gen_win_info): Handle more cleanup here.
1237         (~tui_source_window_base): Delete "execution_info".
1238         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1239
1240 2019-06-25  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui-layout.c (make_command_window): Don't set
1243         can_highlight.
1244         (show_source_disasm_command): Call the reset method.
1245         (show_data): Don't set can_highlight.  Call the reset method.
1246         (tui_gen_win_info::reset): Rename from init_gen_win_info
1247         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1248         (show_source_or_disasm_and_command): Call the reset method.
1249         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1250         (struct tui_cmd_window): Set can_highlight.
1251
1252 2019-06-25  Tom Tromey  <tom@tromey.com>
1253
1254         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1255         from make_visible.
1256         (tui_make_visible, tui_make_invisible): Rewrite.
1257         (tui_win_info::make_visible): Remove.
1258         (tui_source_window_base::make_visible): Update.
1259         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1260         method.  Moved from...
1261         (struct tui_win_info) <make_visible>: ...here.
1262
1263 2019-06-25  Tom Tromey  <tom@tromey.com>
1264
1265         * tui/tui-winsource.c
1266         (tui_source_window_base::do_scroll_horizontal): Remove direction
1267         parameter.
1268         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1269         direction parameter.
1270         * tui/tui-win.c (tui_win_info::forward_scroll)
1271         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1272         (tui_win_info::right_scroll): Update.
1273         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1274         direction parameter.
1275         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1276         direction parameter.
1277         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1278         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1279         Remove direction parameter.
1280         (struct tui_source_window_base, struct tui_source_window)
1281         (struct tui_disasm_window, struct tui_data_window)
1282         (struct tui_cmd_window): Update.
1283
1284 2019-06-25  Tom Tromey  <tom@tromey.com>
1285
1286         * tui/tui-winsource.h (tui_set_exec_info_content)
1287         (tui_show_exec_info_content, tui_erase_exec_info_content)
1288         (tui_clear_exec_info_content, tui_update_exec_info): Change
1289         argument to tui_source_window_base.
1290         * tui/tui-winsource.c (tui_set_exec_info_content)
1291         (tui_show_exec_info_content, tui_erase_exec_info_content)
1292         (tui_clear_exec_info_content, tui_update_exec_info): Change
1293         argument to tui_source_window_base.
1294
1295 2019-06-25  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1298         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1299
1300 2019-06-25  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1303         check.
1304
1305 2019-06-25  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1308         type to void.
1309         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1310         type to void.
1311         * tui/tui-source.c (tui_set_source_content): Update.
1312         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1313
1314 2019-06-25  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-win.c (window_name_completer, tui_set_focus)
1317         (tui_all_windows_info): Use name method.
1318         * tui/tui-data.h (struct tui_gen_win_info)
1319         (struct tui_source_window, struct tui_disasm_window)
1320         (struct tui_data_window, struct tui_cmd_window) <name>: New
1321         method.
1322         (tui_win_name): Don't declare.
1323         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1324         (tui_win_name): Remove.
1325
1326 2019-06-25  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-winsource.h (tui_update_source_window)
1329         (tui_update_source_window_as_is): Change parameter type.
1330         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1331         to be a tui_source_window_base.
1332         (tui_update_source_window_as_is): Likewise.
1333         * tui/tui-win.c (make_visible_with_new_height): Update.
1334
1335 2019-06-25  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-winsource.c (tui_erase_source_content)
1338         (tui_show_source_content, tui_show_exec_info_content)
1339         (tui_erase_exec_info_content): Use refresh_window method.
1340         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1341         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1342         from tui_refresh_win.
1343         (tui_data_window::refresh_window): New method.
1344         (tui_win_info::refresh, tui_source_window_base::refresh)
1345         (tui_refresh_all): Use refresh_window method.
1346         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1347         method.
1348         * tui/tui-regs.c (tui_display_register): Call refresh_window
1349         method.
1350         * tui/tui-layout.c (show_source_disasm_command)
1351         (show_source_or_disasm_and_command): Call refresh_window method.
1352         * tui/tui-data.h (struct tui_gen_win_info)
1353         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1354         New method.
1355
1356 2019-06-25  Tom Tromey  <tom@tromey.com>
1357
1358         * tui/tui.c (tui_rl_other_window, tui_enable)
1359         (tui_is_window_visible, tui_get_command_dimension): Update.
1360         * tui/tui-winsource.c (tui_update_source_window_as_is)
1361         (tui_clear_source_content, tui_erase_source_content)
1362         (tui_show_source_line, tui_source_window_base::refill)
1363         (tui_source_window_base::do_scroll_horizontal)
1364         (tui_source_window_base::set_is_exec_point_at)
1365         (tui_update_breakpoint_info, tui_set_exec_info_content)
1366         (tui_alloc_source_buffer, tui_line_is_displayed)
1367         (tui_addr_is_displayed): Update.
1368         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1369         (tui_check_and_display_highlight_if_needed)
1370         (tui_win_info::make_visible, tui_win_info::refresh)
1371         (tui_refresh_all): Update.
1372         * tui/tui-windata.c (tui_first_data_item_displayed)
1373         (tui_delete_data_content_windows, tui_erase_data_content)
1374         (tui_display_all_data, tui_data_window::refresh_all)
1375         (tui_check_data_values): Update.
1376         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1377         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1378         (tui_win_info::backward_scroll, tui_refresh_all_win)
1379         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1380         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1381         (tui_source_window_base::set_new_height)
1382         (tui_data_window::set_new_height)
1383         (make_invisible_and_set_new_height)
1384         (make_visible_with_new_height, new_height_ok)
1385         (parse_scrolling_args): Update.
1386         * tui/tui-stack.c (tui_show_frame_info): Update.
1387         * tui/tui-source.c (tui_set_source_content)
1388         (tui_set_source_content_nil, tui_source_is_displayed)
1389         (tui_source_window::do_scroll_vertical): Update.
1390         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1391         (tui_display_registers_from, tui_display_reg_element_at_line)
1392         (tui_check_register_values, tui_reg_command): Update.
1393         * tui/tui-layout.c (tui_default_win_height)
1394         (show_source_disasm_command, show_data, init_and_make_win)
1395         (show_source_or_disasm_and_command): Update.
1396         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1397         (tui_redisplay_readline, tui_mld_flush)
1398         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1399         (tui_getc): Update.
1400         * tui/tui-disasm.c (tui_set_disassem_content)
1401         (tui_disasm_window::do_scroll_vertical): Update.
1402         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1403         Now virtual.
1404         (struct tui_win_info): Derive from tui_gen_win_info.
1405         <~tui_win_info>: Mark as override.
1406         <generic>: Remove member.
1407         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1408         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1409         (~tui_data_window, ~tui_win_info)
1410         (tui_free_all_source_wins_content): Update.
1411         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1412
1413 2019-06-25  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui-layout.c (init_and_make_win): Use new.
1416         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1417         destructor, initializers.
1418         (tui_alloc_generic_win_info): Don't declare.
1419         * tui/tui-data.c (_locator): Add argument to constructor.
1420         (source_win, disasm_win): New globals.
1421         (exec_info): Remove.
1422         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1423         Update.
1424         (tui_alloc_generic_win_info): Remove.
1425         (init_content_element): Use new.
1426         (tui_win_info::tui_win_info): Update.
1427         (free_content_elements) <case DATA_WIN>: Use delete.
1428
1429 2019-06-25  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1432         * tui/tui-windata.c (tui_first_data_item_displayed)
1433         (tui_delete_data_content_windows): Update.
1434         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1435         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1436         (tui_display_registers_from, tui_check_register_values): Update.
1437         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1438         pointer.
1439         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1440         window.
1441         (tui_free_data_content): Update.
1442         (free_content_elements) <case DATA_WIN>: Free the window.
1443
1444 2019-06-25  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1447         Update.
1448         * tui/tui-layout.c (make_command_window)
1449         (show_source_disasm_command, show_data, init_and_make_win)
1450         (show_source_or_disasm_and_command): Update.
1451         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1452         method.
1453         <can_highight, is_highlighted>: Now bool.
1454         (tui_set_win_highlight): Don't declare.
1455         * tui/tui-data.c (tui_set_win_highlight): Remove.
1456
1457 2019-06-25  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-wingeneral.c (make_visible): Remove check of window
1460         type.
1461
1462 2019-06-25  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-win.c (tui_win_info::max_height)
1465         (tui_cmd_window::max_height): New methods.
1466         (new_height_ok): Call max_height.
1467         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1468         <max_height>: New method.
1469
1470 2019-06-25  Tom Tromey  <tom@tromey.com>
1471
1472         * tui/tui-win.c (tui_source_window_base::set_new_height)
1473         (tui_data_window::set_new_height): New methods.
1474         (make_invisible_and_set_new_height): Call set_new_height method.
1475         * tui/tui-data.h (struct tui_win_info)
1476         (struct tui_source_window_base, struct tui_data_window)
1477         <set_new_height>: New method.
1478
1479 2019-06-25  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1482         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1483         tui_refresh_data_win.
1484         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1485         method.
1486         (tui_refresh_all_win): Call the refresh_all method.
1487         (tui_set_focus): Likewise.
1488         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1489         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1490         Likewise.
1491
1492 2019-06-25  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-winsource.h (tui_refill_source_window)
1495         (tui_set_is_exec_point_at): Don't declare.
1496         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1497         (tui_source_window_base::refill): Rename from
1498         tui_refill_source_window.
1499         (tui_source_window_base::do_scroll_horizontal): Update.
1500         (tui_source_window_base::set_is_exec_point_at): Rename from
1501         tui_set_is_exec_point_at.
1502         (tui_update_all_breakpoint_info): Update.
1503         * tui/tui-stack.c (tui_show_frame_info): Update.
1504         * tui/tui-layout.c (show_data): Add cast.
1505         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1506         * tui/tui-data.h (struct tui_source_window_base) <refill,
1507         set_is_exec_point_at>: New methods.
1508         (tui_source_windows, tui_add_to_source_windows): Update types.
1509         (tui_add_to_source_windows): Remove redundant declaration.
1510         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1511         (tui_source_windows): Change return type.
1512         (tui_clear_source_windows_detail): Update.
1513         (tui_add_to_source_windows): Change type of parameter.
1514         (tui_free_all_source_wins_content): Update.
1515
1516 2019-06-25  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-wingeneral.c (tui_win_info::refresh)
1519         (tui_source_window_base::refresh): New methods.
1520         (tui_refresh_all): Call the refresh method.
1521         * tui/tui-data.h (struct tui_win_info)
1522         (struct tui_source_window_base) <refresh>: New method.
1523
1524 2019-06-25  Tom Tromey  <tom@tromey.com>
1525
1526         * tui/tui.h (tui_is_window_visible): Return bool.
1527         * tui/tui.c (tui_is_window_visible): Return bool.
1528         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1529         (tui_make_visible, tui_make_invisible)
1530         (tui_win_info::make_visible)
1531         (tui_source_window_base::make_visible, make_all_visible)
1532         (tui_make_all_visible, tui_make_all_invisible): Update.
1533         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1534         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1535         bool.
1536         (struct tui_win_info, struct tui_source_window_base)
1537         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1538         * tui/tui-data.c (tui_init_generic_part): Update.
1539
1540 2019-06-25  Tom Tromey  <tom@tromey.com>
1541
1542         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1543         (tui_source_window_base::make_visible): New methods.
1544         (make_all_visible): Make method call.
1545         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1546         (struct tui_source_window_base, struct tui_cmd_window): Override
1547         make_visible.
1548         (tui_win_is_source_type): Don't declare.
1549         * tui/tui-data.c (tui_win_is_source_type): Remove.
1550
1551 2019-06-25  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1554         NULL check.
1555
1556 2019-06-25  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1559         Inline constructor.  Add initializers for members.
1560         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1561         constructors; now inline in class.
1562
1563 2019-06-25  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-regs.c (tui_show_registers): Update.
1566         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1567         bool.
1568         * tui/tui-data.c (tui_data_window::clear_detail)
1569         (tui_data_window): Update.
1570
1571 2019-06-25  Tom Tromey  <tom@tromey.com>
1572
1573         * tui/tui-windata.c (tui_display_all_data)
1574         (tui_display_data_from_line, tui_display_data_from)
1575         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1576         Update.
1577         * tui/tui-regs.c (tui_last_regs_line_no)
1578         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1579         (tui_show_registers, tui_show_register_group)
1580         (tui_display_registers_from, tui_display_reg_element_at_line)
1581         (tui_display_registers_from_line, tui_check_register_values)
1582         (tui_reg_next, tui_reg_prev): Update.
1583         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1584         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1585         tui_data_window.
1586         (struct tui_win_info) <detail>: Remove.  Add new fields from
1587         tui_data_info.
1588         (TUI_DATA_WIN): Add cast.
1589         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1590         (~tui_data_window): Simplify.
1591
1592 2019-06-25  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-layout.c (show_source_disasm_command)
1595         (show_source_or_disasm_and_command): Update.
1596         * tui/tui-io.c (update_cmdwin_start_line)
1597         (tui_redisplay_readline): Update.
1598         * tui/tui-data.h (struct tui_command_info): Remove.
1599         (struct tui_win_info) <detail>: Remove command_info member.
1600         (struct tui_data_window) <start_line>: New member, from
1601         tui_command_info.
1602         (TUI_CMD_WIN): Add casts.
1603
1604 2019-06-25  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-winsource.c (tui_update_source_window)
1607         (tui_refill_source_window)
1608         (tui_source_window_base::do_scroll_horizontal)
1609         (tui_update_breakpoint_info, tui_set_exec_info_content)
1610         (tui_show_exec_info_content, tui_erase_exec_info_content)
1611         (tui_clear_exec_info_content): Update.
1612         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1613         Update.
1614         * tui/tui-win.c (make_invisible_and_set_new_height)
1615         (make_visible_with_new_height): Update.
1616         * tui/tui-source.c (tui_set_source_content)
1617         (tui_show_symtab_source): Update.
1618         * tui/tui-layout.c (extract_display_start_addr)
1619         (show_source_disasm_command, show_data)
1620         (make_source_or_disasm_window)
1621         (show_source_or_disasm_and_command): Update.
1622         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1623         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1624         "gdbarch".
1625         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1626         to tui_source_window_base.
1627         (struct tui_win_info) <detail>: Remove source_info member.
1628         (struct tui_source_window_base) <has_locator>: Inline.
1629         Move contents from tui_source_info; rename has_locator member to
1630         m_has_locator.
1631         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1632         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1633         header file.
1634         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1635         Simplify.
1636         (tui_free_all_source_wins_content): Cast to
1637         tui_source_window_base.
1638
1639 2019-06-25  Tom Tromey  <tom@tromey.com>
1640
1641         * tui/tui-win.c (make_invisible_and_set_new_height)
1642         (make_visible_with_new_height): Call has_locator method.
1643         * tui/tui-layout.c (show_source_disasm_command, show_data)
1644         (show_source_or_disasm_and_command): Update for bool change.
1645         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1646         (tui_win_info) <has_locator>: New method.
1647         (struct tui_source_window_base) <has_locator>: New method.
1648         (tui_win_has_locator): Don't declare.
1649         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1650         from tui_win_has_locator.
1651         (tui_source_window_base): Use false, not FALSE.
1652
1653 2019-06-25  Tom Tromey  <tom@tromey.com>
1654
1655         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1656         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1657         clear_detail method directly.
1658         (tui_clear_win_detail): Remove.
1659
1660 2019-06-25  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1663         "this", not TUI_DISASM_WIN.
1664
1665 2019-06-25  Tom Tromey  <tom@tromey.com>
1666
1667         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1668         declare.
1669         * tui/tui-winsource.c
1670         (tui_source_window_base::do_scroll_horizontal): Rename from
1671         tui_horizontal_source_scroll.
1672         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1673         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1674         from tui_vertical_data_scroll.
1675         * tui/tui-win.h (tui_scroll): Don't declare.
1676         * tui/tui-win.c (tui_win_info::forward_scroll)
1677         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1678         (tui_win_info::right_scroll): Rename and update.
1679         (tui_scroll_forward_command, tui_scroll_backward_command)
1680         (tui_scroll_left_command, tui_scroll_right_command): Update.
1681         (tui_scroll): Remove.
1682         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1683         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1684         from tui_vertical_source_scroll.
1685         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1686         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1687         from tui_vertical_disassem_scroll.
1688         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1689         do_scroll_horizontal>: New methods.
1690         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1691         Likewise.
1692         (struct tui_source_window_base): Add do_scroll_horizontal.
1693         (struct tui_source_window, struct tui_disasm_window): Add
1694         do_scroll_vertical.
1695         (struct tui_data_window, struct tui_cmd_window): Add
1696         do_scroll_horizontal and do_scroll_vertical.
1697         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1698
1699 2019-06-25  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-data.h (struct tui_source_window_base): New struct.
1702         (struct tui_source_window): Derive from tui_source_window_base.
1703         (struct tui_disasm_window): New struct.
1704         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1705         from tui_source_window::clear_detail.
1706         (tui_source_window_base): Rename from tui_source_window.
1707         (~tui_source_window_base): Rename from ~tui_source_window.
1708         (tui_alloc_win_info): Create a tui_disasm_window.
1709
1710 2019-06-25  Tom Tromey  <tom@tromey.com>
1711
1712         * tui/tui-data.h (struct tui_source_window)
1713         (struct tui_data_window): Declare destructors.
1714         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1715         destructors.
1716         (tui_win_info): Simplify.
1717
1718 2019-06-25  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-winsource.c (tui_display_main)
1721         (tui_update_source_windows_with_addr)
1722         (tui_update_all_breakpoint_info): Update.
1723         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1724         (new_height_ok, parse_scrolling_args): Update.
1725         * tui/tui-stack.c (tui_show_frame_info): Update.
1726         * tui/tui-data.h (struct tui_list): Remove.
1727         (tui_source_windows): Return a reference to a std::vector.
1728         * tui/tui-data.c (source_windows): Now a std::vector.
1729         (tui_source_windows): Change return type.
1730         (tui_clear_source_windows): Rewrite.
1731         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1732         (tui_free_all_source_wins_content): Rewrite.
1733
1734 2019-06-25  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1737         (struct tui_data_window, struct tui_cmd_window): Declare
1738         clear_detail method.
1739         * tui/tui-data.c (tui_source_window::clear_detail)
1740         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1741         methods.
1742         (tui_clear_win_detail): Simplify.
1743
1744 2019-06-25  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-layout.c (make_source_window, make_disasm_window)
1747         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1748         Return the new window.
1749         (show_source_disasm_command, show_data)
1750         (show_source_or_disasm_and_command): Update.
1751
1752 2019-06-25  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1755         parameter.  Return the new window.
1756         (show_source_disasm_command): Update and remove NULL check.
1757         (show_source_or_disasm_and_command): Update.
1758
1759 2019-06-25  Tom Tromey  <tom@tromey.com>
1760
1761         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1762
1763 2019-06-25  Tom Tromey  <tom@tromey.com>
1764
1765         * tui/tui-data.h (struct tui_win_info): Make constructor
1766         protected.  Make destructor virtual.  Add initializers.
1767         (tui_source_window, tui_data_window, tui_cmd_window): New
1768         classes.
1769         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1770         constructor.  Add "type" parameter.
1771         (tui_source_window, tui_data_window, tui_cmd_window): New
1772         constructors.
1773         (tui_alloc_win_info): Instantiate the appropriate subclass.
1774
1775 2019-06-25  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-win.c (tui_resize_all): Use delete.
1778         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1779         destructor.
1780         (tui_free_window): Don't declare.
1781         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1782         Update.
1783
1784 2019-06-25  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-data.h (struct tui_win_info): Add constructor.
1787         * tui/tui-data.c (tui_alloc_win_info): Use new.
1788         (tui_free_window): Use delete.
1789
1790 2019-06-22  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1793         declare.
1794         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1795
1796 2019-06-22  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1799         declare.
1800         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1801
1802 2019-06-22  Tom de Vries  <tdevries@suse.de>
1803
1804         * dwarf2read.c (create_addrmap_from_aranges)
1805         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1806         instead of '%zu'.
1807
1808 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1809
1810         * dwarf2read.h (dwarf2_section_info_def): Remove.
1811         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1812         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1813         std::vector<dwarf2_section_info>.
1814         (struct dwo_file) <~dwo_file>: Remove.
1815         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1816         types field.
1817         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1818         (dwarf2_read_debug_names): Likewise.
1819         (create_debug_types_hash_table): Change parameter type to
1820         array_view, adjust code accordingly.
1821         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1822         (partial_die_info::fixup): Likewise.
1823         (determine_prefix): Likewise.
1824         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1825
1826 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1827
1828         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1829         gdb_bfd_ref_ptr.
1830         <~dwo_file>: Remove call to gdb_bfd_unref.
1831         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1832         gdb_bfd_ref_ptr::get.
1833
1834 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1835
1836         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1837         type to htab_up.
1838         * dwarf2read.c (struct dwo_file): Initialize fields.
1839         <~dwo_file>: New.
1840         (free_dwo_file): Remove, move content to ~dwo_file.
1841         (struct dwo_file_deleter): Remove.
1842         (dwo_file_up>: Remove custom deleter.
1843         (free_dwo_files): Remove.
1844         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1845         dwo_files.
1846         (process_skeletonless_type_units): Call unique_ptr::get.
1847         (allocate_dwo_file_hash_table): Add deleter to created hash
1848         table.  Change return type to htab_up.
1849         (lookup_dwo_file_slot): Don't memset dwo_file, call
1850         unique_ptr::get.
1851         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1852         (create_dwo_unit_in_dwp_v2): Likewise.
1853         (open_and_init_dwo_file): Likewise.
1854         (free_dwo_file_from_slot): Remove.
1855
1856 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1857
1858         * dwarf2read.h (struct dwarf2_section_info) <readin,
1859         is_virtual>: Change type to bool.
1860         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1861         true instead of 1.
1862
1863 2019-06-19  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-data.h (tui_init_content_element): Don't declare.
1866
1867 2019-06-19  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui-data.h (tui_init_win_info): Don't declare.
1870
1871 2019-06-19  Tom de Vries  <tdevries@suse.de>
1872
1873         * dwarf2read.h (abstract_to_concrete): Change type to
1874         std::unordered_map<sect_offset, std::vector<sect_offset>,
1875         gdb::hash_enum<sect_offset>>.
1876
1877 2019-06-19  Tom Tromey  <tromey@adacore.com>
1878
1879         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1880         EVAL_AVOID_SIDE_EFFECTS specially.
1881
1882 2019-06-19  Tom Tromey  <tromey@adacore.com>
1883
1884         * source-cache.c (highlighter): New global.
1885         (source_cache::get_source_lines): Create a highlighter on demand.
1886
1887 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1888
1889         * defs.h (deprecated_interactive_hook): Delete declaration.
1890         * interps.c (clear_interpreter_hooks): Remove use of
1891         deprecated_interactive_hook.
1892         * top.c (deprecated_interactive_hook): Delete definition.
1893         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1894
1895 2019-06-18  Tom de Vries  <tdevries@suse.de>
1896
1897         PR gdb/24515
1898         * dwarf2read.h (abstract_to_concrete): Change type from
1899         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1900         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1901         * dwarf2read.c (read_variable): Update.
1902         (dwarf2_fetch_die_loc_sect_off): Update.
1903
1904 2019-06-17  Tom de Vries  <tdevries@suse.de>
1905
1906         PR gdb/24617
1907         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1908         accessing parent[parent_len - 1].
1909
1910 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1911
1912         PR gdb/24364
1913         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1914         call dtrace_process_dof with NULL dof.
1915
1916 2019-06-16  Tom de Vries  <tdevries@suse.de>
1917
1918         PR gdb/24445
1919         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1920
1921 2019-06-16  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1924         (make_all_visible): Use address of member.
1925
1926 2019-06-16  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1929         (tui_free_window, free_content, free_content_elements): Remove
1930         unnecessary cast.
1931         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1932         cast.
1933         * tui/tui-regs.c (tui_show_register_group)
1934         (tui_display_registers_from, tui_display_reg_element_at_line):
1935         Remove unnecessary cast.
1936
1937 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1938
1939         * linux-nat.c (normal_mask): Delete.
1940         (_initialize_linux_nat): Don't initialise normal_mask.
1941
1942 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1943
1944         PR gdb/24445
1945         * dwarf-index-write.h (write_psymtabs_to_index): Add
1946         dwz_basename parameter.
1947         * dwarf-index-write.c (write_gdbindex): Move file writing to
1948         write_gdbindex_1.  Change return type void.
1949         (assert_file_size): Move up, remove filename parameter.
1950         (write_gdbindex_1): New function.
1951         (write_debug_names): Change return type to void, call
1952         assert_file_size.
1953         (struct index_wip_file): New struct.
1954         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1955         file logic to index_wip_file.  Write index for dwz file if
1956         needed.
1957         (save_gdb_index_command): Pass basename of dwz file, if present.
1958         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1959         build-id of dwz file, if present.
1960         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1961         (dwarf2_get_dwz_file): Likewise.
1962         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1963         (dwarf2_get_dwz_file): Likewise.
1964
1965 2019-06-16  Tom Tromey  <tom@tromey.com>
1966
1967         * coffread.c (process_coff_symbol): Use xstrdup.
1968         * value.c (create_internalvar): Use xstrdup.
1969
1970 2019-06-16  Tom Tromey  <tom@tromey.com>
1971
1972         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1973         * breakpoint.c (stopin_command, stopat_command)
1974         (until_break_command, decode_location_default): Remove unnecessary
1975         cast.
1976         * utils.c (subset_compare): Remove unnecessary cast.
1977         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1978         cast.
1979         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1980         cast.
1981         * infcmd.c (path_command): Remove unnecessary cast.
1982         * coffread.c (decode_type): Remove unnecessary cast.
1983         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1984         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1985         * tui/tui-stack.c (tui_show_locator_content)
1986         (tui_show_frame_info): Remove unnecessary cast.
1987         * tui/tui-win.c (tui_scroll_forward_command)
1988         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1989         (parse_scrolling_args): Remove unnecessary cast.
1990         * tui/tui-data.c (init_win_info, tui_del_window)
1991         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1992         (free_content_elements): Remove unnecessary cast.
1993         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1994         unnecessary cast.
1995         * tui/tui-source.c (tui_set_source_content)
1996         (tui_vertical_source_scroll): Remove unnecessary cast.
1997         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1998         cast.
1999         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2000         * tui/tui-regs.c (tui_display_registers_from)
2001         (tui_display_register): Remove unnecessary cast.
2002         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2003         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2004         (make_visible): Remove unnecessary cast.
2005         * tui/tui-winsource.c (tui_erase_source_content)
2006         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2007         unnecessary cast.
2008         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2009         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2010         * stabsread.c (read_type, read_array_type, read_range_type):
2011         Remove unnecessary cast.
2012         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2013         (parse_symbol, parse_type, upgrade_type, parse_external)
2014         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2015         unnecessary cast.
2016         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2017
2018 2019-06-16  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-data.c (tui_alloc_generic_win_info)
2021         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2022         checks.
2023
2024 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2025             Andrew Burgess  <andrew.burgess@embecosm.com>
2026
2027         * f-typeprint.c (f_print_type): Don't return early for not
2028         associated or not allocated types.
2029         (f_type_print_varspec_suffix): Add print_rank parameter and print
2030         ranks of array types in case they dangling.
2031         (f_type_print_base): Add print_rank parameter.
2032
2033 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2034
2035         * NEWS: Mention new MI commands.
2036         * break-catch-throw.c (enum exception_event_kind): Move to
2037         breakpoint.h.
2038         (print_mention_exception_catchpoint): Output text as a single
2039         message.
2040         (catch_exception_command_1): Rename to...
2041         (catch_exception_event): ...this, make non-static, update header
2042         command, and change some parameter types.
2043         (catch_catch_command): Update for changes to
2044         catch_exception_command_1.
2045         (catch_throw_command): Likewise.
2046         (catch_rethrow_command): Likewise.
2047         * breakpoint.c (enum exception_event_kind): Delete.
2048         * breakpoint.h (enum exception_event_kind): Moved here from
2049         break-catch-throw.c.
2050         (catch_exception_event): Declare.
2051         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2052         (mi_cmd_catch_throw): New function.
2053         (mi_cmd_catch_rethrow): New function.
2054         (mi_cmd_catch_catch): New function.
2055         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2056         'catch-catch' entries.
2057         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2058         (mi_cmd_catch_rethrow): Declare.
2059         (mi_cmd_catch_catch): Declare.
2060
2061 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2062
2063         * annotate.c (annotate_source_line): Change return type to void,
2064         update implementation to match.
2065         * annotate.h (annotate_source_line): Change return type to void,
2066         update header comment.
2067         * stack.c (print_frame_info): Don't change what frame information
2068         is printed based on whether annotations are on or not.
2069
2070 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2071
2072         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2073         (annotate_source): Make static.
2074         (annotate_source_line): Moved from source.c and renamed from
2075         identify_source_line.  Update the return type.
2076         * annotate.h (annotate_source): Delete declaration.
2077         (annotate_source_line): Declaration moved from source.h, and
2078         renamed from identify_source_line.  Return type updated.
2079         * source.c (identify_source_line): Moved to annotate.c and renamed
2080         to annotate_source_line.
2081         (info_line_command): Remove check of annotation_level.
2082         * source.h (identify_source_line): Move declaration to annotate.h
2083         and rename to annotate_source_line.
2084         * stack.c: Add 'annotate.h' include.
2085         (print_frame_info): Remove check of annotation_level before
2086         calling annotate_source_line.
2087
2088 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2089
2090         * source-cache.c (source_cache::get_plain_source_lines): Use
2091         open_source_file_with_line_charpos instead of just
2092         open_source_file, remove call to find_source_lines.
2093         (source_cache::get_source_lines): Likewise.
2094         * source.c (find_source_lines): Make static.
2095         (get_filename_and_charpos): Renamed into...
2096         (open_source_file_with_line_charpos): ..this along with changes to
2097         return a scoped_fd, and some other minor clean ups.
2098         (identify_source_line): Use open_source_file_with_line_charpos.
2099         (search_command_helper): Use open_source_file_with_line_charpos
2100         instead of just open_source_file, remove call to
2101         find_source_lines.
2102         * source.h (open_source_file_with_line_charpos): Declare new
2103         function.
2104         (find_source_lines): Delete declaration.
2105
2106 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2107
2108         * source.c (get_filename_and_charpos): Remove fullname
2109         parameter.
2110         (identify_source_line): Update call to get_filename_and_charpos.
2111
2112 2019-06-14  Tom Tromey  <tromey@adacore.com>
2113
2114         PR gdb/24502:
2115         * ui-style.h (skip_ansi_escape): Update comment.
2116         * ui-file.h (class no_terminal_escape_file): New class.
2117         * ui-file.c (no_terminal_escape_file::write)
2118         (no_terminal_escape_file::puts): New methods.
2119         * cli/cli-logging.c (handle_redirections): Use
2120         no_terminal_escape_file.
2121
2122 2019-06-14  Tom Tromey  <tromey@adacore.com>
2123
2124         * NEWS: Move convenience variable news above Python news.
2125
2126 2019-06-14  Tom Tromey  <tom@tromey.com>
2127
2128         * gnulib: Move directory to top-level.
2129         * configure.ac: Don't configure gnulib.
2130         * configure: Rebuild.
2131         * common/common-defs.h: Use new path to gnulib.
2132         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2133         (GNULIB_H): Remove.
2134         (INCGNU): Look in new gnulib location.
2135         (HFILES_NO_SRCDIR): Remove gnulib files.
2136         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2137         (generated_files): Remove GNULIB_H.
2138         ($(LIBGNU), all-lib): Remove targets.
2139         (distclean): Don't mention GNULIB_BUILDDIR.
2140         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2141
2142 2019-06-14  Tom Tromey  <tromey@adacore.com>
2143
2144         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2145         Warn if symbol file does not provide any symbols.
2146
2147 2019-06-14  Tom Tromey  <tromey@adacore.com>
2148
2149         * source.c (find_and_open_source): Respect basenames_may_differ.
2150
2151 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2152
2153         * annotate.c (annotate_breakpoints_invalid): Make use of
2154         scoped_restore_terminal_state.
2155         (annotate_frames_invalid): Likewise.
2156
2157 2019-06-14  Tom Tromey  <tromey@adacore.com>
2158
2159         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2160         allow assignment to an internalvar.
2161
2162 2019-06-14  Tom Tromey  <tromey@adacore.com>
2163
2164         * ada-lex.l: Allow "_" in attribute names.
2165
2166 2019-06-14  Tom Tromey  <tromey@adacore.com>
2167
2168         PR gdb/24653:
2169         * regcache.c (registers_changed): Don't call alloca.
2170         * top.c (execute_command): Don't call alloca.
2171
2172 2019-06-13  Pedro Alves  <palves@redhat.com>
2173
2174         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2175         'expression'.  When parsing an expression, error out if there's
2176         junk after "unlimited".
2177         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2178         (do_set_command): Adjust calls to is_unlimited_literal.
2179
2180 2019-06-13  Pedro Alves  <palves@redhat.com>
2181
2182         * compile/compile.c (make_compile_options_def_group): Add braces
2183         around array_view initializer.
2184         * thread.c (make_thread_apply_all_options_def_group)
2185         (make_thread_apply_all_options_def_group): Likewise.
2186
2187 2019-06-13  Pedro Alves  <palves@redhat.com>
2188
2189         * NEWS (New commands): Mention "maint test-options
2190         require-delimiter", "maint test-options unknown-is-error", "maint
2191         test-options unknown-is-operand" and "maint show
2192         test-options-completion-result".
2193         (New command options, command completion): New section.
2194         (Completion improvements): New section.
2195         Mention that you can abbreviate "unlimited".
2196
2197 2019-06-13  Pedro Alves  <palves@redhat.com>
2198
2199         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2200         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2201         * unittests/cli-utils-selftests.c (test_parse_flags)
2202         (test_parse_flags_qcs): Delete.
2203         (test_cli_utils): Don't call deleted functions.
2204
2205 2019-06-13  Pedro Alves  <palves@redhat.com>
2206
2207         * thread.c: Include "cli/cli-option.h".
2208         (tp_array_compar_ascending): Global.
2209         (tp_array_compar): Delete function.
2210         (tp_array_compar_ascending, tp_array_compar_descending): New
2211         functions.
2212         (ascending_option_def, qcs_flag_option_def)
2213         (thr_qcs_flags_option_defs)
2214         (make_thread_apply_all_options_def_group)
2215         (make_thread_apply_options_def_group): New.
2216         (thread_apply_all_command): Use gdb::option::process_options.
2217         (thread_apply_command_completer)
2218         (thread_apply_all_command_completer): New.
2219         (thread_apply_command): Use gdb::option::process_options.
2220         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2221         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2222         to generate help text of "thread apply".  Adjust "taas"'s help.
2223         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2224         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2225
2226 2019-06-13  Pedro Alves  <palves@redhat.com>
2227
2228         * thread.c (thread_apply_command): Check for invalid TID with
2229         isdigit instead of !isalpha.
2230
2231 2019-06-13  Pedro Alves  <palves@redhat.com>
2232
2233         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2234         (validate_flags_qcs): New.
2235         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2236         (validate_flags_qcs): Declare.
2237         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2238         (make_frame_apply_options_def_group): New.
2239         (frame_apply_command_count): Process options with
2240         gdb::option::process_options.
2241         (frame_apply_completer): New.
2242         (frame_apply_level_completer, frame_apply_all_completer)
2243         (frame_apply_completer): New.
2244         (_initialize_stack): Update help of "frame apply", "frame apply
2245         level", "frame apply all" and "faas" to mention supported options
2246         and install command completers.
2247         * stack.h (frame_apply_all_completer): Declare.
2248         * thread.c: Include "stack.h".
2249         (tfaas_command): Add "--".
2250         (_initialize_thread): Update help "tfaas" to mention supported
2251         options and install command completer.
2252
2253 2019-06-13  Pedro Alves  <palves@redhat.com>
2254
2255         * completer.c (complete_nested_command_line): New.
2256         (gdb_completion_word_break_characters_throw): Add assertion.
2257         * completer.h (complete_nested_command_line): Declare.
2258
2259 2019-06-13  Pedro Alves  <palves@redhat.com>
2260
2261         * stack.c (parse_backtrace_qualifiers): New.
2262         (backtrace_command): Use it.
2263         (backtrace_command_completer): Complete on qualifiers.
2264
2265 2019-06-13  Pedro Alves  <palves@redhat.com>
2266
2267         * frame.c: Include "cli/cli-option.h.
2268         (user_set_backtrace_options): New.
2269         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2270         Delete.
2271         (get_prev_frame): Adjust.
2272         (boolean_option_def, uinteger_option_def)
2273         (set_backtrace_option_defs): New.
2274         (_initialize_frame): Adjust and use
2275         gdb::option::add_setshow_cmds_for_options to install "set
2276         backtrace past-main" and "set backtrace past-entry".
2277         * frame.h: Include "cli/cli-option.h".
2278         (struct frame_print_options): Forward declare.
2279         (print_frame_arguments_all, print_frame_arguments_scalars)
2280         (print_frame_arguments_none): Declare.
2281         (print_entry_values): Delete declaration.
2282         (struct frame_print_options, user_frame_print_options): New.
2283         (struct set_backtrace_options): New.
2284         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2285         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2286         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2287         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2288         (list_args_or_locals): Add frame_print_options parameter.
2289         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2290         * python/py-framefilter.c (enumerate_args): Pass down
2291         USER_FRAME_PRINT_OPTIONS.
2292         * stack.c: Include "cli/cli-option.h".
2293         (print_frame_arguments_all, print_frame_arguments_scalars)
2294         (print_frame_arguments_none): Declare.
2295         (print_raw_frame_arguments, print_entry_values): Delete.
2296         (user_frame_print_options): New.
2297         (boolean_option_def, enum_option_def, frame_print_option_defs):
2298         New.
2299         (struct backtrace_cmd_options): New.
2300         (bt_flag_option_def): New.
2301         (backtrace_command_option_defs): New.
2302         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2303         (print_frame_arg, read_frame_arg, print_frame_args)
2304         (print_frame_info, print_frame): Add frame_print_options parameter
2305         and use it.
2306         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2307         (backtrace_command_1): Add frame_print_options and
2308         backtrace_cmd_options parameters and use them.
2309         (make_backtrace_options_def_group): New.
2310         (backtrace_command): Process command options with
2311         gdb::option::process_options.
2312         (backtrace_command_completer): New.
2313         (_initialize_stack): Extend "backtrace"'s help to mention
2314         supported options.  Install completer for "backtrace".
2315         Install some settings commands with add_setshow_cmds_for_options.
2316
2317 2019-06-13  Pedro Alves  <palves@redhat.com>
2318
2319         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2320         and that "set/show print raw frame-arguments" are now deprecated.
2321
2322         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2323         command.
2324         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2325         * stack.c (_initialize_stack): Install "set/show print
2326         raw-frame-arguments", and deprecate "set/show print raw
2327         frame-arguments".
2328         * valprint.c (_initialize_valprint): Deprecate "set/show print
2329         raw".
2330
2331 2019-06-13  Pedro Alves  <palves@redhat.com>
2332
2333         * compile/compile.c (struct compile_options): New.
2334         (compile_flag_option_def, compile_command_option_defs)
2335         (make_compile_options_def_group): New.
2336         (compile_file_command): Handle options with
2337         gdb::option::process_options.
2338         (compile_file_command_completer): New function.
2339         (compile_code_command): Handle options with
2340         gdb::option::process_options.
2341         (compile_code_command_completer): New function.
2342         (_initialize_compiler): Install completers for "compile code" and
2343         "compile file".  Mention available options in "compile code" and
2344         "compile code"'s help.
2345         * completer.c (advance_to_completion_word): New, factored out from
2346         ...
2347         (advance_to_expression_complete_word_point): ... this.
2348         (advance_to_filename_complete_word_point): New.
2349         * completer.h (advance_to_filename_complete_word_point): New
2350         declaration.
2351
2352 2019-06-13  Pedro Alves  <palves@redhat.com>
2353
2354         * compile/compile.c: Include "cli/cli-option.h".
2355         (compile_print_value): Scope data pointer is now a
2356         value_print_options pointer; adjust.
2357         (compile_print_command): Process options.  Scope data pointer is
2358         now a value_print_options pointer; adjust.
2359         (_initialize_compile): Update "compile print"'s help to include
2360         supported options.  Install a completer for "compile print".
2361         * cp-valprint.c (show_vtblprint, show_objectprint)
2362         (show_static_field_print): Delete.
2363         (_initialize_cp_valprint): Don't install "set print
2364         static-members", "set print vtbl", "set print object" here.
2365         * printcmd.c: Include "cli/cli-option.h" and
2366         "common/gdb_optional.h".
2367         (print_command_parse_format): Rework to fill in a
2368         value_print_options instead of a format_data.
2369         (print_value): Change parameter type from format_data pointer to
2370         value_print_options reference.  Adjust.
2371         (print_command_1): Process options.  Adjust to pass down a
2372         value_print_options.
2373         (print_command_completer): New.
2374         (_initialize_printcmd): Install print_command_completer as
2375         handle_brkchars completer for the "print" command.  Update
2376         "print"'s help to include supported options.
2377         * valprint.c: Include "cli/cli-option.h".
2378         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2379         here from cp-valprint.c.
2380         (boolean_option_def, uinteger_option_def)
2381         (value_print_option_defs, make_value_print_options_def_group):
2382         New.  Use gdb::option::add_setshow_cmds_for_options to install
2383         "set print elements", "set print null-stop", "set print repeats",
2384         "set print pretty", "set print union", "set print array", "set
2385         print address", "set print symbol", "set print array-indexes".
2386         * valprint.h: Include <string> and "cli/cli-option.h".
2387         (make_value_print_options_def_group): Declare.
2388         (print_value): Change parameter type from format_data pointer to
2389         value_print_options reference.
2390         (print_command_completer): Declare.
2391
2392 2019-06-13  Pedro Alves  <palves@redhat.com>
2393
2394         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2395         (COMMON_SFILES): Add maint-test-settings.c.
2396         * cli/cli-decode.c (boolean_enums): New global, factored out from
2397         ...
2398         (add_setshow_boolean_cmd): ... here.
2399         * cli/cli-decode.h (boolean_enums): Declare.
2400         * cli/cli-option.c: New file.
2401         * cli/cli-option.h: New file.
2402         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2403         factored out from ...
2404         (parse_cli_boolean_value(const char *)): ... this.
2405         (is_unlimited_literal): Change parameter type to pointer to
2406         pointer.  Adjust and advance ARG pointer.
2407         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2408         (parse_cli_var_enum): New, factored out from ...
2409         (do_set_command): ... this.  Adjust.
2410         * cli/cli-setshow.h (parse_cli_boolean_value)
2411         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2412         (parse_cli_var_enum): Declare.
2413         * cli/cli-utils.c: Include "cli/cli-option.h".
2414         (get_ulongest): New.
2415         * cli/cli-utils.h (get_ulongest): Declare.
2416         (check_for_argument): New overloads.
2417         * maint-test-options.c: New file.
2418
2419 2019-06-13  Pedro Alves  <palves@redhat.com>
2420
2421         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2422         parse a range if "-" is at the end of the string.
2423
2424 2019-06-13  Pedro Alves  <palves@redhat.com>
2425
2426         * cli/cli-setshow.c (parse_auto_binary_operation)
2427         (parse_cli_boolean_value): Don't allow "o".
2428
2429 2019-06-13  Pedro Alves  <palves@redhat.com>
2430
2431         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2432         * NEWS: Mention maint test-settings KIND.
2433         * maint-test-settings.c: New file.
2434
2435 2019-06-13  Pedro Alves  <palves@redhat.com>
2436
2437         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2438         completer.
2439         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2440         "set" completers.
2441
2442 2019-06-13  Pedro Alves  <palves@redhat.com>
2443
2444         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2445         after item.
2446
2447 2019-06-13  Pedro Alves  <palves@redhat.com>
2448
2449         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2450
2451 2019-06-13  Pedro Alves <palves@redhat.com>
2452
2453         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2454         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2455         call.
2456         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2457         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2458         calls.
2459         (check_for_argument): Skip spaces after argument.
2460
2461 2019-06-13  Pedro Alves  <palves@redhat.com>
2462
2463         * thread.c (thread_apply_command): Adjust TID parsing.
2464         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2465         detected before end of string.
2466         (tid_is_in_list): Error out if LIST is invalid.
2467
2468 2019-06-13  Pedro Alves  <palves@redhat.com>
2469
2470         * completer.c (complete_line_internal_1): Rewind completion word
2471         point.
2472         (completion_tracker::advance_custom_word_point_by): Change
2473         parameter type to int.
2474         * completer.h (completion_tracker::advance_custom_word_point_by):
2475         Likewise.
2476
2477 2019-06-13  Pedro Alves  <palves@redhat.com>
2478
2479         * completer.c (advance_to_completion_word): Handle delimiters.
2480
2481 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2482
2483         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2484
2485 2019-06-11  Tom Tromey  <tom@tromey.com>
2486
2487         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2488         (xmalloc_failed): Move to alloc.c.
2489         * alloc.c: New file.
2490         * Makefile.in (COMMON_SFILES): Add alloc.c.
2491
2492 2019-06-11  Tom Tromey  <tom@tromey.com>
2493
2494         * nat/linux-waitpid.c: Don't include server.h.
2495         (linux_debug): Remove.
2496         (my_waitpid): Update.
2497
2498 2019-06-11  Tom Tromey  <tromey@adacore.com>
2499
2500         * infcall.c (_initialize_infcall): Remove trailing newline from
2501         help.
2502         * user-regs.c (_initialize_user_regs): Remove trailing newline
2503         from help.
2504         * typeprint.c (_initialize_typeprint): Remove trailing newline
2505         from help.
2506         * reverse.c (_initialize_reverse): Remove trailing newlines from
2507         help.
2508         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2509         from help.
2510         * language.c (add_set_language_command): Remove trailing newline
2511         from help.
2512         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2513         help.
2514         * disasm.c (_initialize_disasm): Remove trailing newline from
2515         help.
2516         * top.c (init_main): Remove trailing newline from help.
2517         * interps.c (_initialize_interpreter): Remove trailing newline
2518         from help.
2519         * btrace.c (_initialize_btrace): Remove trailing newlines from
2520         help.
2521         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2522         from help.
2523         * python/python.c (_initialize_python): Remove trailing newline
2524         from help.
2525         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2526         help.
2527         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2528         from help.  Reformat some text.
2529         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2530         from help.
2531         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2532         newline from help.
2533
2534 2019-06-11  Tom Tromey  <tromey@adacore.com>
2535
2536         * darwin-nat.c (darwin_decode_exception_message)
2537         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2538
2539 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2540
2541         * valops.c (value_slice): Check for not allocated or not
2542         associated values.
2543
2544 2019-06-10  Tom de Vries  <tdevries@suse.de>
2545
2546         PR gdb/24618
2547         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2548         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2549         invalid.
2550
2551 2019-06-10  Tom de Vries  <tdevries@suse.de>
2552
2553         PR gdb/24611
2554         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2555         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2556
2557 2019-06-10  Tom de Vries  <tdevries@suse.de>
2558
2559         PR symtab/24545
2560         * symtab.c (struct demangled_name_entry): Add language field.
2561         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2562         static minimal symbol".  Set and use language field.
2563
2564 2019-06-10  Tom Tromey  <tromey@adacore.com>
2565
2566         * ada-lang.c (_initialize_ada_language): Update help text.
2567
2568 2019-06-10  Tom Tromey  <tromey@adacore.com>
2569
2570         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2571         with a newline.
2572         * guile/guile.c (handle_boot_error): Don't end warning with a
2573         newline.
2574         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2575         warning with a newline.
2576         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2577         newline.
2578         (s12z_frame_cache): Likewise.
2579         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2580         a newline.
2581         * solib-svr4.c (disable_probes_interface): Don't end warning with
2582         a newline.
2583         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2584         newline.
2585         * python/python.c (do_finish_initialization): Don't end warning
2586         with a newline.
2587
2588 2019-06-10  Tom Tromey  <tom@tromey.com>
2589
2590         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2591         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2592         gdbpy_enter.
2593
2594 2019-06-10  Tom Tromey  <tromey@adacore.com>
2595
2596         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2597         data.
2598         (elf_new_init): Don't call stabsread_new_init.
2599         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2600         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2601         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2602
2603 2019-06-10  Tom de Vries  <tdevries@suse.de>
2604
2605         PR symtab/16264
2606         PR symtab/24517
2607         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2608
2609 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2610
2611         * source.c (find_and_open_source): Also rewrite relative file
2612         names.
2613
2614 2019-04-26  Amos Bird  <amosbird@gmail.com>
2615
2616         * annotate.c (annotate_thread_exited): Add "thread-exited"
2617         annotation.
2618
2619 2019-06-06  Tom Tromey  <tromey@adacore.com>
2620
2621         * maint.h (class scoped_command_stats): Use
2622         DISABLE_COPY_AND_ASSIGN.
2623         <print_time>: New method.
2624         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2625         print_time.
2626         (scoped_command_stats::print_time): New method.
2627
2628 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2629
2630         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2631         instructions of lengths 6 or 8 bytes.
2632
2633 2019-06-04  Pedro Alves  <palves@redhat.com>
2634
2635         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2636
2637         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2638         * breakpoint.c (condition_completer): Likewise.
2639         * cli/cli-dump.c (scan_expression): Likewise.
2640         * common/filestuff.c (mkdir_recursive): Likewise.
2641         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2642         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2643         (gdb_abspath): Likewise.
2644         * compile/compile-cplus-types.c
2645         (compile_cplus_instance::decl_name): Likewise.
2646         * completer.c (complete_explicit_location):
2647         (signal_completer, reg_or_group_completer_1): Likewise.
2648         * cp-support.c (cp_remove_params_if_any): Likewise.
2649         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2650         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2651         * infcmd.c (strip_bg_char): Likewise.
2652         * linespec.c (copy_token_string): Likewise.
2653         * mi/mi-main.c (output_cores): Likewise.
2654         * psymtab.c (psymtab_search_name):
2655         * symfile.c (test_set_ext_lang_command): Likewise.
2656         * target.c (target_fileio_read_stralloc): Likewise.
2657         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2658         * value.c (complete_internalvar): Likewise.
2659
2660 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2661
2662         Add objfile property to gdb.Type.
2663         * NEWS: Mention Python API addition.
2664         * python/py-type.c (typy_get_objfile): New method.
2665
2666 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2667
2668         * NEWS: Mention the new set|show style [title|highlight].
2669         Mention changes to "show style", "help" and "apropos".
2670
2671 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2672
2673         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2674         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2675         instead of print_help_for_command.
2676         (print_doc_of_command): New function.
2677         (help_list): Add 'apropos -v word' suggestion.
2678         (print_help_for_command): Style the command name using title style.
2679         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2680         (_initialize_cli_cmds): Describe -v in apropos_command help.
2681
2682 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2683
2684         * cli/cli-style.h (cli_style_option): Add name in constructor,
2685         add m_name class member, add constructor with intensity,
2686         add name class function.
2687         (cli_style_option::add_setshow_commands): Remove name argument.
2688         (highlight_style, title_style): New styles.
2689         * cli/cli-style.c (do_show): New function that shows a style
2690         characteristic styling the style name with itself.
2691         (set_style_name): New function.
2692         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2693         Update all callers according to the changes in cli/cli-style.h.
2694         * utils.h (fputs_highlighted): New function.
2695         * utils.c (fputs_highlighted): Likewise.
2696
2697 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2698
2699         * NEWS: Mention new pipe command and new convenience variables.
2700
2701 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2702
2703         * cli/cli-cmds.c (pipe_command): New function.
2704         (_initialize_cli_cmds): Call add_com for pipe_command.
2705         Define | as an alias for pipe.
2706         (exit_status_set_internal_vars): New function.
2707         (shell_escape): Call exit_status_set_internal_vars.
2708         cli/cli-decode.c (find_command_name_length): Recognize | as
2709         a single character command.
2710
2711 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2712
2713         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2714         top.c (execute_command_to_ui_file): New function, mostly a copy
2715         of execute_command_to_string.
2716         (execute_command_to_string): Implement by calling
2717         execute_command_to_ui_file.
2718
2719 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2720
2721         * top.h (saved_command_line): Remove declaration.
2722         * top.c (previous_saved_command_line, previous_repeat_arguments):
2723         New variables.
2724         (saved_command_line): Make static, define together with other
2725         'repeat variables'.
2726         (dont_repeat): Clear repeat_arguments.
2727         (repeat_previous, get_saved_command_line, save_command_line):
2728         New functions.
2729         (gdb_init): Initialize saved_command_line
2730         and previous_saved_command_line.
2731         * main.c (captured_main_1): Remove saved_command_line initialization.
2732         * event-top.c (handle_line_of_input): Update to use
2733         the new 'repeat' related functions instead of direct access to
2734         saved_command_line.
2735         * command.h (repeat_previous, get_saved_command_line,
2736         save_command_line): New declarations.
2737         (dont_repeat): Add comment.
2738
2739 2019-05-30  Tom Tromey  <tromey@adacore.com>
2740
2741         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2742         Fix comment.
2743         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2744
2745 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2746
2747         PR cli/24587
2748         * completer.c (complete): Initialize variable word.
2749
2750 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2751
2752         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2753         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2754         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2755         'body' is NULL to the outter 'if', protecting the '!is_define'
2756         situation as well.
2757
2758 2019-05-29  Tom Tromey  <tromey@adacore.com>
2759
2760         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2761         (dwarf_unknown): New function.
2762         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2763         (dwarf_type_encoding_name): Use dwarf_unknown.
2764
2765 2019-05-29  Tom Tromey  <tromey@adacore.com>
2766
2767         PR c++/20020:
2768         * cp-valprint.c (cp_print_value_fields): Call
2769         cp_print_static_field inside "try".
2770
2771 2019-05-29  Tom Tromey  <tromey@adacore.com>
2772
2773         * inflow.c (struct terminal_info): Add default operator=.
2774         * configure: Rebuild.
2775         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2776         -Wdeprecated-copy-dtor, -Wredundant-move.
2777
2778 2019-05-29  Tom Tromey  <tromey@adacore.com>
2779
2780         * NEWS: Add entry.
2781         * infcmd.c (print_return_value_1): Handle finish_print
2782         option.
2783         (show_print_finish): New function.
2784         (_initialize_infcmd): Add "set/show print finish" commands.
2785         * valprint.c (user_print_options): Initialize new member.
2786         * valprint.h (struct value_print_options) <finish_print>: New
2787         member.
2788
2789 2019-05-28  Tom Tromey  <tromey@adacore.com>
2790
2791         * ada-lang.c (ada_remove_Xbn_suffix)
2792         (find_old_style_renaming_symbol)
2793         (parse_old_style_renaming): Remove.
2794         (ada_find_renaming_symbol): Don't call
2795         find_old_style_renaming_symbol.
2796         (ada_is_renaming_symbol): Rename from
2797         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2798         bool.  Now static.
2799         (ada_read_var_value): Update and simplify.
2800         * ada-exp.y (write_var_or_type): Remove old code.
2801
2802 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2803
2804         * event-top.c: Remove include comment.
2805         * inflow.c (class scoped_ignore_sigttou): Move from here...
2806         * inflow.h (class scoped_ignore_sigttou): ...to here.
2807         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2808         * top.c:  Remove include comment.
2809
2810 2019-05-27  Tom Tromey  <tom@tromey.com>
2811
2812         * NEWS: Fix typo.
2813
2814 2019-05-22  Tom Tromey  <tromey@adacore.com>
2815
2816         * target.c (target_follow_exec): Constify parameter.
2817         * target-delegates.c: Rebuild.
2818         * remote.c (remote_target::follow_exec): Constify parameter.
2819         * infrun.c (follow_exec): Constify parameter.
2820         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2821         (target_follow_exec): Likewise.
2822
2823 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2824
2825         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2826         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2827
2828 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2829
2830         * NEWS: Add debugredirect and testsuite sections.
2831
2832 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2833
2834         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2835         target descriptions using exclusively floating point register name
2836         aliases.
2837
2838 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2839
2840         PR gdb/18644:
2841         * f-lang.c (build_fortran_types): Handle the case where
2842         gdbarch_floatformat_for_type returns a nullptr.
2843
2844 2019-05-21  Tom de Vries  <tdevries@suse.de>
2845
2846         PR cli/24587
2847         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2848
2849 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2850
2851         PR gdb/18644:
2852         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2853         16-byte floats.
2854         * i386-tdep.c (i386_floatformat_for_type): Use
2855         floatformats_ia64_quad for the 16-byte floating point component
2856         within a fortran 32-byte complex number.
2857
2858 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2859
2860         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2861         delete default constructor.
2862         (find_partial_die): Update to return const struct.
2863         (partial_die_parent_scope): Move variable declaration into scope
2864         of its use and change its type to auto.
2865         (guess_partial_die_structure_name): Likewise.
2866         (partial_die_info::fixup): Likewise.
2867
2868 2019-05-17  Tom Tromey  <tromey@adacore.com>
2869
2870         * source.c (find_and_open_source): Remove cast.
2871
2872 2019-05-17  Tom Tromey  <tromey@adacore.com>
2873
2874         * annotate.c (annotate_source): Make "filename" const.
2875         * annotate.h (annotate_source): Use const.
2876
2877 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2878
2879         * disasm.c (set_disassembler_options): Send errors to stderr.
2880
2881 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2882
2883         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2884         (cli_interp_base::set_logging): Check debug_redirect.
2885         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2886         * cli/cli-logging.c (debug_redirect): Add static variable.
2887         (pop_output_files): Add default param.
2888         (handle_redirections): Print debug setting.
2889         (show_logging_command): Likewise.
2890         (_initialize_cli_logging): Add debugredirect command.
2891         * interps.c (current_interp_set_logging): Add debug_redirect
2892         parameter.
2893         * interps.h (set_logging): Add debug_redirect parameter.
2894         (current_interp_set_logging): Likewise.
2895         * mi/mi-common.h: Likewise.
2896         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2897
2898 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2899             Tom Tromey  <tromey@adacore.com>
2900
2901         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2902         directly.
2903         * cli/cli-interp.h (make_logging_output): Remove declaration.
2904         * cli/cli-logging.c (make_logging_output): Remove function.
2905         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2906         directly.
2907         * ui-file.c (tee_file::tee_file): Remove bools.
2908         (tee_file::~tee_file): Remove deletes.
2909         * ui-file.h (tee_file): Remove bools.
2910
2911 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2912
2913         * mi/mi-cmds.h (mi_cmd_complete): New function.
2914         * mi/mi-main.c (mi_cmd_complete): Likewise.
2915         * mi/mi-cmds.c: Define new MI command -complete.
2916         * NEWS: Mention new -complete command.
2917
2918 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2919
2920         * completer.h (complete): New function.
2921         * completer.c (complete): Likewise.
2922         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2923         function defined in completer.h.
2924
2925 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2926
2927         * MAINTAINERS (Write After Approval): Add myself.
2928
2929 2019-05-17  Tom de Vries  <tdevries@suse.de>
2930
2931         PR gdb/24094
2932         * dwarf2read.c (struct cu_partial_die_info): New struct.
2933         (find_partial_die): Return cu_partial_die_info.
2934         (partial_die_parent_scope, guess_partial_die_structure_name)
2935         (partial_die_info::fixup): Handle new return type of find_partial_die.
2936
2937 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2938
2939         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2940         "std::string", simplifying the algorithm.
2941
2942 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2943
2944         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2945         (stap_static_probe_ops::get_probes): Likewise.
2946
2947 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2948
2949         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2950         '-')" and "else if".
2951         (stap_parse_single_operand): Join checks for
2952         "gdbarch_stap_parse_special_token_p" and
2953         "gdbarch_stap_parse_special_token" in the same "if" statement.
2954         Invert check when verifying for operation on register
2955         displacement.
2956
2957 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2958
2959         * stap-probe.c (stap_get_opcode): Update comment.
2960         (stap_get_expected_argument_type): Likewise.
2961         (handle_stap_probe): Likewise.
2962
2963 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2964
2965         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2966         return type to 'bool'.  Adjust comment.  Use 'bool' when
2967         appropriate.
2968         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2969         * stap-probe.c (stap_parse_argument_1): Likewise.
2970         (stap_is_operator): Likewise.
2971         (stap_is_generic_prefix): Likewise.
2972         (stap_is_register_prefix): Likewise.
2973         (stap_is_register_indirection_prefix): Likewise.
2974         (stap_is_integer_prefix): Likewise.
2975         (stap_generic_check_suffix): Likewise.
2976         (stap_check_integer_suffix): Likewise.
2977         (stap_check_register_suffix): Likewise.
2978         (stap_check_register_indirection_suffix): Likewise.
2979         (stap_parse_register_operand): Likewise.
2980         (stap_parse_single_operand): Likewise.
2981         (stap_parse_argument_1): Likewise.
2982         (stap_probe::get_argument_count): Likewise.
2983         (stap_is_operator): Likewise.
2984
2985 2019-05-16  Tom Tromey  <tromey@adacore.com>
2986
2987         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2988         keyword to foreach.
2989
2990 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2991
2992         * linux-thread-db.c (try_thread_db_load_1): Change return type
2993         to bool.
2994         (try_thread_db_load): Likewise.
2995         (try_thread_db_load_from_pdir_1): Likewise.
2996         (try_thread_db_load_from_pdir): Likewise.
2997         (try_thread_db_load_from_sdir): Likewise.
2998         (try_thread_db_load_from_dir): Likewise.
2999         (thread_db_load_search): Likewise.
3000         (has_libpthread): Likewise.
3001         (thread_db_load): Likewise.
3002
3003 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3004
3005         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3006         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3007         NULL, and complain/return if that's the case.
3008
3009 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3010
3011         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3012         (advance, posn, abstract_read_memory): New functions.
3013         [struct mem_read_abstraction]: New struct.
3014         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3015
3016 2019-05-14  Tom Tromey  <tromey@adacore.com>
3017
3018         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3019         value is not lval_memory.
3020
3021 2019-05-14  Tom Tromey  <tromey@adacore.com>
3022
3023         * solib.c (info_sharedlibrary_command): Style the file name.
3024
3025 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3026
3027         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3028         (aarch64_vnv_type): Likewise.
3029         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3030         * common/tdesc.c: Likewise.
3031         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3032         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3033         * features/aarch64-fpu.xml: Add ieee half view.
3034         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3035         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3036         * gdbtypes.h (struct builtin_type): Likewise.
3037         (struct objfile_type): Likewise.
3038
3039 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3040
3041         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3042         typo.
3043         * location.h (string_to_event_location): Likewise.
3044
3045 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3046
3047         GDB 8.3 released.
3048
3049 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3050
3051         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3052         New variable declaration.
3053         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3054         New variable.
3055         (print_one_breakpoint): Use ui_out::test_flags and new global
3056         variable to compute use_fixed_output.
3057         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3058         Remove.
3059         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3060         (mi_multi_location_breakpoint_output_fixed): Remove.
3061         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3062         new variable.
3063         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3064         fix_multi_location_breakpoint_output flag if version >= 3.
3065         * ui-out.h (enum ui_out_flag)
3066         <fix_multi_location_breakpoint_output>: New enumerator.
3067
3068 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3069
3070         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3071
3072 2019-05-10  Tom Tromey  <tromey@adacore.com>
3073
3074         * ada-lang.c (catch_ada_completer): New function.
3075         (_initialize_ada_language): Use it.
3076
3077 2019-05-10  Tom Tromey  <tromey@adacore.com>
3078
3079         * thread.c (print_thread_info): Make "requested_threads" const.
3080         * gdbthread.h (print_thread_info): Make "requested_threads"
3081         const.
3082         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3083         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3084
3085 2019-05-08  Tom Tromey  <tom@tromey.com>
3086
3087         * gdbtypes.c (objfile_type_data): Change type.
3088         (objfile_type, _initialize_gdbtypes): Update.
3089
3090 2019-05-08  Tom Tromey  <tom@tromey.com>
3091
3092         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3093         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3094         (_initialize_dwarf2_frame): Update.
3095
3096 2019-05-08  Tom Tromey  <tom@tromey.com>
3097
3098         * objc-lang.c (objc_objfile_data): Change type.
3099         (find_methods): Update.
3100         (_initialize_objc_lang): Remove.
3101
3102 2019-05-08  Tom Tromey  <tom@tromey.com>
3103
3104         * stabsread.c (rs6000_builtin_type_data): Change type.
3105         (rs6000_builtin_type, _initialize_stabsread): Update.
3106
3107 2019-05-08  Tom Tromey  <tom@tromey.com>
3108
3109         * mips-tdep.c (mips_pdr_data): Remove.
3110         (_initialize_mips_tdep): Update.
3111
3112 2019-05-08  Tom Tromey  <tom@tromey.com>
3113
3114         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3115         (hppa_init_objfile_priv_data, read_unwind_info)
3116         (find_unwind_entry, _initialize_hppa_tdep): Update.
3117
3118 2019-05-08  Tom Tromey  <tom@tromey.com>
3119
3120         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3121         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3122         on obstack.
3123         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3124
3125 2019-05-08  Tom Tromey  <tom@tromey.com>
3126
3127         * mdebugread.c (basic_type_data): Change type.
3128         (basic_type, _initialize_mdebugread): Update.
3129
3130 2019-05-08  Tom Tromey  <tom@tromey.com>
3131
3132         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3133
3134 2019-05-08  Tom Tromey  <tom@tromey.com>
3135
3136         * nto-tdep.c (nto_inferior_data_reg): Change type.
3137         (nto_inferior_data): Update.
3138         (nto_inferior_data_cleanup, nto_new_inferior_data)
3139         (_initialize_nto_tdep): Remove.
3140         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3141
3142 2019-05-08  Tom Tromey  <tom@tromey.com>
3143
3144         * ada-lang.c (struct ada_inferior_data): Add initializers.
3145         (ada_inferior_data): Change type.
3146         (ada_inferior_data_cleanup): Remove.
3147         (get_ada_inferior_data, ada_inferior_exit)
3148         (struct ada_pspace_data): Add initializers, destructor.
3149         (ada_pspace_data_handle): Change type.
3150         (get_ada_pspace_data): Update.
3151         (ada_pspace_data_cleanup): Remove.
3152
3153 2019-05-08  Tom Tromey  <tom@tromey.com>
3154
3155         * coffread.c (struct coff_symfile_info): Add initializers.
3156         (coff_objfile_data_key): Move lower.  Change type.
3157         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3158         Update.
3159         (coff_free_info): Remove.
3160
3161 2019-05-08  Tom Tromey  <tom@tromey.com>
3162
3163         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3164         (fbsd_pspace_data_handle): Move lower.  Change type.
3165         (get_fbsd_pspace_data): Update.
3166         (fbsd_pspace_data_cleanup): Remove.
3167         (_initialize_fbsd_tdep): Update.
3168
3169 2019-05-08  Tom Tromey  <tom@tromey.com>
3170
3171         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3172         (get_ada_tasks_pspace_data): Update.
3173         (ada_tasks_pspace_data_cleanup): Remove.
3174         (_initialize_tasks): Update.
3175         (ada_tasks_inferior_data_handle): Change type.
3176         (get_ada_tasks_inferior_data): Update.
3177         (ada_tasks_inferior_data_cleanup): Remove.
3178         (struct ada_tasks_pspace_data): Add initializers.
3179
3180 2019-05-08  Tom Tromey  <tom@tromey.com>
3181
3182         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3183         * symfile-debug.c (debug_sym_get_probes): Change type.
3184         * stap-probe.c (handle_stap_probe):
3185         (stap_static_probe_ops::get_probes): Change type.
3186         * probe.h (class static_probe_ops) <get_probes>: Change type.
3187         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3188         (parse_probes_in_pspace): Update.
3189         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3190         Update.
3191         (any_static_probe_ops::get_probes): Change type.
3192         * elfread.c (elfread_data): New typedef.
3193         (probe_key): Change type.
3194         (elf_get_probes): Likewise.  Update.
3195         (probe_key_free): Remove.
3196         (_initialize_elfread): Update.
3197         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3198         Change type.
3199         (dtrace_process_dof_probe, dtrace_process_dof)
3200         (dtrace_static_probe_ops::get_probe): Change type.
3201
3202 2019-05-08  Tom Tromey  <tom@tromey.com>
3203
3204         * xcoffread.c (struct xcoff_symfile_info): Rename from
3205         coff_symfile_info.  Add initializers.
3206         (xcoff_objfile_data_key): Move lower.  Change type.
3207         (XCOFF_DATA): Rewrite.
3208         (xcoff_free_info): Remove.
3209         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3210         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3211         (xcoff_initial_scan): Update.
3212
3213 2019-05-08  Tom Tromey  <tom@tromey.com>
3214
3215         * solib-svr4.c (struct svr4_info): Add initializers and
3216         destructor.
3217         <probes_table>: Now an htab_up.
3218         (solib_svr4_pspace_data): Change type.
3219         (free_probes_table): Simplify.
3220         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3221         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3222         (probes_table_remove_objfile_probes, register_solib_event_probe)
3223         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3224         (_initialize_svr4_solib): Update.
3225
3226 2019-05-08  Tom Tromey  <tom@tromey.com>
3227
3228         * remote.c (remote_pspace_data): Change type.
3229         (remote_pspace_data_cleanup): Remove.
3230         (get_remote_exec_file, set_pspace_remote_exec_file)
3231         (_initialize_remote): Update.
3232
3233 2019-05-08  Tom Tromey  <tom@tromey.com>
3234
3235         * breakpoint.c (breakpoint_objfile_key): Change type.
3236         (get_breakpoint_objfile_data): Update.
3237         (free_breakpoint_objfile_data): Remove.
3238         (_initialize_breakpoint): Update.
3239
3240 2019-05-08  Tom Tromey  <tom@tromey.com>
3241
3242         * linux-tdep.c (struct linux_info): Add initializers.
3243         (linux_inferior_data): Move.  Change type.
3244         (invalidate_linux_cache_inf): Update.
3245         (linux_inferior_data_cleanup): Remove.
3246         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3247
3248 2019-05-08  Tom Tromey  <tom@tromey.com>
3249
3250         * auxv.c (auxv_inferior_data): Move.  Change type.
3251         (auxv_inferior_data_cleanup): Remove.
3252         (invalidate_auxv_cache_inf): Rewrite.
3253         (get_auxv_inferior_data, _initialize_auxv): Update.
3254
3255 2019-05-08  Tom Tromey  <tom@tromey.com>
3256
3257         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3258         (symfile_debug_objfile_data_key): Change type.
3259         (symfile_debug_installed, debug_qf_has_symbols)
3260         (debug_qf_find_last_source_symtab)
3261         (debug_qf_forget_cached_source_info)
3262         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3263         (debug_qf_print_stats, debug_qf_dump)
3264         (debug_qf_expand_symtabs_for_function)
3265         (debug_qf_expand_all_symtabs)
3266         (debug_qf_expand_symtabs_with_fullname)
3267         (debug_qf_map_matching_symbols)
3268         (debug_qf_expand_symtabs_matching)
3269         (debug_qf_find_pc_sect_compunit_symtab)
3270         (debug_qf_map_symbol_filenames)
3271         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3272         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3273         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3274         (debug_sym_read_linetable, debug_sym_relocate): Update.
3275         (symfile_debug_free_objfile): Remove.
3276         (install_symfile_debug_logging, _initialize_symfile_debug):
3277         Update.
3278
3279 2019-05-08  Tom Tromey  <tom@tromey.com>
3280
3281         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3282         allocate_on_obstack.
3283         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3284         (get_dwarf2_per_objfile): Update.
3285         (set_dwarf2_per_objfile): Remove.
3286         (dwarf2_has_info, dwarf2_get_section_info): Update.
3287         (dwarf2_free_objfile): Remove.
3288         (_initialize_dwarf2_read): Update.
3289
3290 2019-05-08  Tom Tromey  <tom@tromey.com>
3291
3292         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3293         initializers.
3294         <unsupported_script_warning_printed,
3295         script_not_found_warning_printed>: Now bool.
3296         (auto_load_pspace_data): Change type.
3297         (~auto_load_pspace_info): Rename from
3298         auto_load_pspace_data_cleanup.
3299         (get_auto_load_pspace_data, init_loaded_scripts_info)
3300         (clear_section_scripts, maybe_print_unsupported_script_warning)
3301         (maybe_print_script_not_found_warning, _initialize_auto_load):
3302         Update.
3303
3304 2019-05-08  Tom Tromey  <tom@tromey.com>
3305
3306         * objfiles.c (objfile_pspace_info): Add destructor and
3307         initializers.
3308         (objfiles_pspace_data): Change type.
3309         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3310         (get_objfile_pspace_data): Update.
3311         (objfiles_bfd_data): Change type.
3312         (get_objfile_bfd_data): Update.
3313         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3314
3315 2019-05-08  Tom Tromey  <tom@tromey.com>
3316
3317         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3318         Change type.
3319         (get_catch_syscall_inferior_data): Update.
3320         (catch_syscall_inferior_data_cleanup): Remove.
3321         (_initialize_break_catch_syscall): Update.
3322
3323 2019-05-08  Tom Tromey  <tom@tromey.com>
3324
3325         * inflow.c (struct terminal_info): Add destructor and
3326         initializers.
3327         (inflow_inferior_data): Change type.
3328         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3329         (get_inflow_inferior_data, inflow_inferior_exit)
3330         (swap_terminal_info, _initialize_inflow): Update.
3331
3332 2019-05-08  Tom Tromey  <tom@tromey.com>
3333
3334         * target-dcache.c (target_dcache_cleanup): Remove.
3335         (target_dcache_aspace_key): Change type.
3336         (target_dcache_init_p, target_dcache_invalidate)
3337         (target_dcache_get, target_dcache_get_or_init)
3338         (_initialize_target_dcache): Update.
3339         * dcache.h (struct dcache_deleter): New.
3340
3341 2019-05-08  Tom Tromey  <tom@tromey.com>
3342
3343         * symtab.c (struct symbol_cache): Add destructor and
3344         initializers.
3345         (symbol_cache_key): Move.  Change type.
3346         (make_symbol_cache, free_symbol_cache): Remove.
3347         (get_symbol_cache): Update.
3348         (symbol_cache_cleanup): Remove.
3349         (ALL_PSPACES, symbol_cache_flush)
3350         (maintenance_print_symbol_cache)
3351         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3352         Update.
3353
3354 2019-05-08  Tom Tromey  <tom@tromey.com>
3355
3356         * symtab.c (struct main_info): Add destructor and initializers.
3357         (main_progspace_key): Move.  Change type.
3358         (get_main_info): Update.
3359         (main_info_cleanup): Remove.
3360         (_initialize_symtab): Update.
3361
3362 2019-05-08  Tom Tromey  <tom@tromey.com>
3363
3364         * registry.h (DECLARE_REGISTRY): Define the _key class.
3365
3366 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3367
3368         * NEWS: Merge two 'New commands' sections.
3369
3370 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3371
3372         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3373         parameter and use Ada language definition instead.
3374         (ada_val_print_ptr): Remove unused language parameter.
3375         (ada_val_print_num): Remove language parameter and use Ada language
3376         definition instead.
3377         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3378         parameter.
3379         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3380         parameter and use Ada language definition instead.
3381         (ada_val_print_1): Update all ada_val_print_xxx calls.
3382         Remove language parameter.
3383         (ada_val_print): Update ada_val_print_1 call.
3384
3385 2019-05-08  Tom Tromey  <tromey@adacore.com>
3386
3387         * remote.c (remote_hw_watchpoint_limit)
3388         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3389         Now static.
3390
3391 2019-05-08  Tom Tromey  <tromey@adacore.com>
3392
3393         * maint.c (_initialize_maint_cmds): Move initialization code to
3394         remote.c.
3395         (watchdog, show_watchdog): Move to remote.c.
3396         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3397         "watchdog" static.
3398         (_initialize_remote): Move initialization code from maint.c.
3399         * defs.h (watchdog): Don't declare.
3400
3401 2019-05-08  Tom Tromey  <tromey@adacore.com>
3402
3403         * tui/tui-interp.c: Include main.h.
3404         * interps.c: Include main.h.
3405         * main.h (interpreter_p): Declare.
3406         * defs.h (interpreter_p): Don't declare.
3407
3408 2019-05-08  Tom Tromey  <tromey@adacore.com>
3409
3410         * dwarf2loc.c: Include dwarf2read.h.
3411         * defs.h (read_unsigned_leb128): Don't declare.
3412         * dwarf2read.h (read_unsigned_leb128): Declare.
3413
3414 2019-05-08  Tom Tromey  <tromey@adacore.com>
3415
3416         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3417         method.
3418
3419 2019-05-08  Tom Tromey  <tromey@adacore.com>
3420
3421         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3422         when no wrap column is set.
3423
3424 2019-05-08  Tom Tromey  <tromey@adacore.com>
3425
3426         * c-lang.c (c_get_string): Handle non-C-style arrays.
3427
3428 2019-05-08  Tom Tromey  <tromey@adacore.com>
3429
3430         * typeprint.c (print_offset_data::update): Print the bit offset,
3431         not the number of bits remaining.
3432
3433 2019-05-08  Tom Tromey  <tromey@adacore.com>
3434
3435         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3436         padding at end of comment.
3437
3438 2019-05-08  Tom Tromey  <tromey@adacore.com>
3439
3440         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3441         Compare main types.
3442
3443 2019-05-06  Tom Tromey  <tom@tromey.com>
3444
3445         * common/scoped_mmap.c: Include common-defs.h.
3446         * common/scoped_mmap.h: Don't include config.h.
3447
3448 2019-05-04  Tom Tromey  <tom@tromey.com>
3449
3450         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3451         (struct aarch64_call_info): Add initializers.
3452         <si>: Now a std::vector.
3453         (pass_on_stack, aarch64_push_dummy_call): Update.
3454
3455 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3456             Tom Tromey  <tom@tromey.com>
3457
3458         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3459         (ppc_threads): Now a std::vector.  Now static.
3460         (hwdebug_find_thread_points_by_tid)
3461         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3462         Update.
3463
3464 2019-05-04  Tom Tromey  <tom@tromey.com>
3465
3466         * arc-tdep.c (arc_tdesc_init): Return bool.
3467
3468 2019-05-04  Tom Tromey  <tom@tromey.com>
3469
3470         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3471         Use gdb_assert_not_reached.
3472
3473 2019-05-04  Tom Tromey  <tom@tromey.com>
3474
3475         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3476         "false".
3477
3478 2019-05-04  Tom Tromey  <tom@tromey.com>
3479
3480         * arc-tdep.c (arc_tdesc_init): Use bool.
3481
3482 2019-05-04  Tom Tromey  <tom@tromey.com>
3483
3484         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3485
3486 2019-05-04  Tom Tromey  <tom@tromey.com>
3487
3488         * cli/cli-cmds.c (valid_command_p): Return bool.
3489
3490 2019-05-04  Tom Tromey  <tom@tromey.com>
3491
3492         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3493         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3494
3495 2019-05-04  Raul Tambre  <raul@tambre.ee>
3496
3497         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3498         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3499         operator for comparison.
3500
3501 2019-05-04  Tom Tromey  <tom@tromey.com>
3502
3503         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3504         (lookup_partial_symbol, print_partial_symbols)
3505         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3506         (psymbol_compare): Update.
3507         (add_psymbol_to_bcache): Clear the entire psymbol.
3508         (maintenance_check_psymtabs): Update.
3509         * psympriv.h (struct partial_symbol): Don't derive from
3510         general_symbol_info.
3511         <obj_section, unrelocated_address, address,
3512         set_unrelocated_address>: Update.
3513         <ginfo>: New member.
3514         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3515         (debug_names::write_psymbols): Update.
3516
3517 2019-05-04  Tom de Vries  <tdevries@suse.de>
3518
3519         * contrib/cc-with-tweaks.sh: Support -n arg.
3520
3521 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3522
3523         * corelow.c (core_target::detach): Ensure frame cache and
3524         register caches are cleared.
3525         inferior.c (exit_inferior_1): Likewise.
3526
3527 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3528             Tom Tromey  <tom@tromey.com>
3529
3530         * dictionary.c (collate_pending_symbols_by_language): Remove
3531         "struct" from foreach.
3532         * symtab.c (lookup_global_symbol_from_objfile)
3533         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3534         foreach.
3535         * ser-tcp.c (net_open): Remove "struct" from foreach.
3536         * objfiles.c (objfile_relocate, objfile_rebase)
3537         (objfile_has_symbols): Remove "struct" from foreach.
3538         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3539         from foreach.
3540         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3541         foreach.
3542         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3543         "struct" from foreach.
3544         * ada-lang.c (create_excep_cond_exprs)
3545         (ada_exception_catchpoint_cond_string): Remove "struct" from
3546         foreach.
3547
3548 2019-05-03  Tom Tromey  <tromey@adacore.com>
3549
3550         * ada-exp.y (convert_char_literal): Check suffix of each
3551         enumerator.
3552
3553 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3554
3555         PR ada/21406:
3556         * ada-exp.y (yywrap): Don't define.
3557         * ada-lex.l (%option): Add noyywrap
3558         (yywrap): Remove.
3559
3560 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3561
3562         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3563         _WIN32_WINNT to the XP level, unless already defined to a higher
3564         level.
3565
3566         * unittests/parse-connection-spec-selftests.c:
3567         * ser-tcp.c:
3568         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3569         override.
3570
3571         * symfile.c (find_separate_debug_file): Remove colon from the
3572         drive spec of DOS/Windows file names of the target, so that the
3573         file name produced from DEBUGDIR and the target's directory will
3574         be valid on DOS/Windows systems.
3575
3576 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3577
3578         * rust-lang.c (val_print_struct): Handle printing structures
3579         containing strings.
3580
3581 2019-05-02  Tom Tromey  <tromey@adacore.com>
3582
3583         * valarith.c (_initialize_valarith): Remove.
3584
3585 2019-05-01  Tom Tromey  <tromey@adacore.com>
3586
3587         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3588         bitfields.
3589
3590 2019-05-01  Tom Tromey  <tromey@adacore.com>
3591
3592         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3593         for big-endian copies.
3594
3595 2019-04-30  Ali Tamur  <tamur@google.com>
3596         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3597         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3598         (read_3_bytes): New function.
3599
3600 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3601
3602         * windows-nat.c (main_thread_id): Delete.
3603         (handle_output_debug_string): Replace main_thread_id by
3604         current_event.dwThreadId.
3605         (fake_create_process): Likewise.
3606         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3607         Do not set main_thread_id.
3608         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3609         current_event.dwThreadId.
3610         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3611
3612 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3613
3614         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3615         Use current_event.dwThreadId instead of main_thread_id.
3616
3617 2019-04-30  Tom Tromey  <tromey@adacore.com>
3618
3619         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3620         (create_excep_cond_exprs): Iterate over program spaces.
3621         (ada_exception_catchpoint_cond_string): Examine all minimal
3622         symbols for exception types.
3623
3624 2019-04-30  Tom Tromey  <tromey@adacore.com>
3625
3626         PR c++/24470:
3627         * dwarf2read.c (process_structure_scope): Handle case where type
3628         has template parameters but no symbol was created.
3629
3630 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3631             Chris January  <chris.january@arm.com>
3632
3633         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3634         qualifier.
3635         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3636
3637 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3638
3639         * f-typeprint.c (f_print_type): Update rules for printing
3640         whitespace.
3641         (f_type_print_varspec_suffix): Likewise.
3642
3643 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3644             Chris January  <chris.january@arm.com>
3645
3646         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3647         function arguments.
3648
3649 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3650
3651         * f-lang.c (build_fortran_types): Change name of void type to
3652         lower case.
3653         * f-typeprint.c (f_type_print_base): Print the name of the void
3654         type, rather than a fixed string.
3655         * f-valprint.c (f_decorations): Use lower case void string.
3656
3657 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3658             Chris January  <chris.january@arm.com>
3659
3660         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3661         types for Fortran.
3662
3663 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3664             Chris January  <chris.january@arm.com>
3665             David Lecomber  <david.lecomber@arm.com>
3666
3667         * f-exp.y (BINOP_INTRINSIC): New token.
3668         (exp): New parser rule handling BINOP_INTRINSIC.
3669         (f77_keywords): Add new builtin procedures.
3670         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3671         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3672         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3673         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3674         (print_unop_subexp_f): New function.
3675         (print_binop_subexp_f): New function.
3676         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3677         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3678         (dump_subexp_body_f): Likewise.
3679         (operator_check_f): Likewise.
3680         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3681         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3682
3683 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3684
3685         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3686         UNOP_KIND.
3687         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3688         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3689         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3690         (operator_length_f): New fuction.
3691         (print_subexp_f): New function.
3692         (op_name_f): New function.
3693         (dump_subexp_body_f): New function.
3694         (operator_check_f): New function.
3695         (exp_descriptor_f): Replace standard expression handling functions
3696         with new functions.
3697         * gdb/fortran-operator.def: New file.
3698         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3699         * gdb/std-operator.def: Remove UNOP_KIND.
3700
3701 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3702
3703         * std-operator.def: Remove unbalanced, stray double quote
3704         character.
3705
3706 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3707             Chris January  <chris.january@arm.com>
3708             Daniel Everett  <daniel.everett@arm.com>
3709             Nick Forrington  <nick.forrington@arm.com>
3710             Richard Bunt  <richard.bunt@arm.com>
3711
3712         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3713         of depth when printing anonymous structs or unions.
3714         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3715         Don't print either the top-level value, or the children if the
3716         max-depth is exceeded.
3717         (ppscm_print_children): When printing the key of a map, allow one
3718         extra level of depth.
3719         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3720         print either the top-level value, or the children if the max-depth
3721         is exceeded.
3722         (print_children): When printing the key of a map, allow one extra
3723         level of depth.
3724         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3725         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3726         (user_print_options): Initialise max_depth field.
3727         (val_print_scalar_or_string_type_p): New function.
3728         (val_print): Check to see if the max depth has been reached.
3729         (val_print_check_max_depth): Define new function.
3730         (show_print_max_depth): New function.
3731         (_initialize_valprint): Add 'print max-depth' option.
3732         * valprint.h (struct value_print_options) <max_depth>: New field.
3733         (val_print_check_max_depth): Declare new function.
3734         * NEWS: Document new feature.
3735
3736 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3737
3738         * ada-lang.c (ada_language_defn): Initialise new field.
3739         * c-lang.c (c_is_string_type_p): New function.
3740         (c_language_defn): Initialise new field.
3741         (cplus_language_defn): Initialise new field.
3742         (asm_language_defn): Initialise new field.
3743         (minimal_language_defn): Initialise new field.
3744         * c-lang.h (c_is_string_type_p): Declare new function.
3745         * d-lang.c (d_language_defn): Initialise new field.
3746         * f-lang.c (f_is_string_type_p): New function.
3747         (f_language_defn): Initialise new field.
3748         * go-lang.c (go_is_string_type_p): New function.
3749         (go_language_defn): Initialise new field.
3750         * language.c (default_is_string_type_p): New function.
3751         (unknown_language_defn): Initialise new field.
3752         (auto_language_defn): Initialise new field.
3753         * language.h (struct language_defn) <la_is_string_type_p>: New
3754         member variable.
3755         (default_is_string_type_p): Declare new function.
3756         * m2-lang.c (m2_language_defn): Initialise new field.
3757         * objc-lang.c (objc_language_defn): Initialise new field.
3758         * opencl-lang.c (opencl_language_defn): Initialise new field.
3759         * p-lang.c (pascal_is_string_type_p): New function.
3760         (pascal_language_defn): Initialise new field.
3761         * rust-lang.c (rust_is_string_type_p): New function.
3762         (rust_language_defn): Initialise new field.
3763
3764 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3765
3766         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3767         New field.
3768         * ada-lang.c (ada_language_defn): Initialise new field.
3769         * c-lang.c (c_language_defn): Likewise.
3770         (cplus_language_defn): Likewise.
3771         (asm_language_defn): Likewise.
3772         (minimal_language_defn): Likewise.
3773         * d-lang.c (d_language_defn): Likewise.
3774         * f-lang.c (f_language_defn): Likewise.
3775         * go-lang.c (go_language_defn): Likewise.
3776         * language.c (unknown_language_defn): Likewise.
3777         (auto_language_defn): Likewise.
3778         * m2-lang.c (m2_language_defn): Likewise.
3779         * objc-lang.c (objc_language_defn): Likewise.
3780         * opencl-lang.c (opencl_language_defn): Likewise.
3781         * p-lang.c (pascal_language_defn): Likewise.
3782         * rust-lang.c (rust_language_defn): Likewise.
3783
3784 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3785
3786         * ada-lang.c (ada_is_character_type): Change return type to bool.
3787         (ada_is_string_type): Likewise.
3788         * ada-lang.h (ada_is_character_type): Update declaration
3789         (ada_is_string_type): Likewise.
3790
3791 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3792
3793         Support style in 'frame|thread apply'
3794
3795         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3796         * record.c (record_start, record_stop): Update callers of
3797         execute_command_to_string with false.
3798         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3799         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3800         methods.
3801         (class string_file): New constructor with term_out parameter.
3802         Override methods term_out and can_emit_style_escape.  New member
3803         term_out.
3804         (class stdio_file): Override can_emit_style_escape.
3805         (class tee_file): Override term_out and can_emit_style_escape.
3806         * utils.h (can_emit_style_escape): Remove.
3807         * utils.c (can_emit_style_escape): Likewise.
3808         Update all callers of can_emit_style_escape (SOMESTREAM) to
3809         SOMESTREAM->can_emit_style_escape.
3810         * source-cache.c (source_cache::get_source_lines): Likewise.
3811         * stack.c (frame_apply_command_count): Call execute_command_to_string
3812         passing the term_out characteristic of the current gdb_stdout.
3813         * thread.c (thr_try_catch_cmd): Likewise.
3814         * top.c (execute_command_to_string): pass term_out parameter
3815         to construct the string_file for the command output.
3816         * ui-file.c (term_cli_styling): New function (most code moved
3817         from utils.c can_emit_style_escape).
3818         (string_file::string_file, string_file::can_emit_style_escape,
3819         stdio_file::can_emit_style_escape, tee_file::term_out,
3820         tee_file::can_emit_style_escape): New functions.
3821
3822 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3823
3824         * NEWS: Mention the new set|show may-call-functions.
3825         * infcall.c (may_call_functions_p): New variable.
3826         (show_may_call_functions_p): New function.
3827         (call_function_by_hand_dummy): Throws an error if not
3828         may-call-functions.
3829         (_initialize_infcall): Call add_setshow_boolean_cmd for
3830         may-call-functions.
3831
3832 2019-04-25  Keith Seitz  <keiths@redhat.com>
3833
3834         PR c++/24367
3835         * cp-support.c (inspect_type): Don't attempt substitutions
3836         of symbol with the same name.
3837
3838 2019-04-25  Tom Tromey  <tromey@adacore.com>
3839
3840         PR gdb/24475:
3841         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3842         static.
3843
3844 2019-04-25  Tom Tromey  <tromey@adacore.com>
3845
3846         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3847         rvalue reference.
3848         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3849         (gdb_xml_parser::parse): Use std::move.
3850         * python/python-internal.h (gdbpy_convert_exception): Take a const
3851         reference.
3852         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3853         std::move.
3854         * python/py-utils.c (gdbpy_convert_exception): Take a const
3855         reference.
3856         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3857         Use std::move.
3858         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3859         Use std::move.
3860         * mi/mi-main.c (mi_print_exception): Take a const reference.
3861         * main.c (handle_command_errors): Take a const reference.
3862         * linespec.c (parse_linespec): Use std::move.
3863         * infcall.c (run_inferior_call): Use std::move.
3864         (call_function_by_hand_dummy): Use std::move.
3865         * exec.c (try_open_exec_file): Use std::move.
3866         * exceptions.h (exception_print, exception_fprintf)
3867         (exception_print_same): Update.
3868         * exceptions.c (print_exception, exception_print)
3869         (exception_fprintf, exception_print_same): Change parameters to
3870         const reference.
3871         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3872         * common/new-op.c: Use std::move.
3873         * common/common-exceptions.h (struct gdb_exception): Add move
3874         constructor.
3875         (struct gdb_exception_error, struct gdb_exception_quit, struct
3876         gdb_quit_bad_alloc): Change constructor to move constructor.
3877         (throw_exception): Change parameter to rvalue reference.
3878         * common/common-exceptions.c (throw_exception): Take rvalue
3879         reference.
3880         * cli/cli-interp.c (safe_execute_command): Use std::move.
3881         * breakpoint.c (insert_bp_location, location_to_sals): Use
3882         std::move.
3883
3884 2019-04-25  Tom Tromey  <tromey@adacore.com>
3885
3886         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3887         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3888         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3889         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3890         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3891         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3892         guile/scm-value.c: Use unpack.
3893         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3894         gdbscm_gdb_exception.
3895         (gdbscm_throw_gdb_exception): Likewise.
3896         (struct gdbscm_gdb_exception): New.
3897         (unpack): New function.
3898         (gdbscm_wrap): Use unpack.
3899
3900 2019-04-25  Tom Tromey  <tromey@adacore.com>
3901
3902         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3903         (gdb_rl_callback_handler): Use std::move.
3904         * common/common-exceptions.h (struct gdb_exception): Add move
3905         assignment operator.
3906         (throw_exception_sjlj): Change "exception" to const reference.
3907         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3908         (throw_exception_sjlj): Change "exception" to const reference.
3909
3910 2019-04-25  Tom Tromey  <tromey@adacore.com>
3911
3912         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3913         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3914         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3915         Update.
3916         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3917         Update.
3918         * mi/mi-interp.c (mi_interp::exec): Update.
3919         * linespec.c (parse_linespec): Update.
3920         * infcall.c (run_inferior_call): Update.
3921         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3922         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3923         (gdbscm_lookup_global_symbol): Update.
3924         * guile/scm-param.c (gdbscm_parameter_value): Update.
3925         * guile/scm-frame.c (gdbscm_frame_read_register)
3926         (gdbscm_frame_read_var): Update.
3927         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3928         * exec.c (try_open_exec_file): Update.
3929         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3930         (gdb_rl_callback_handler): Update.
3931         * common/common-exceptions.h (exception_none): Don't declare.
3932         * common/common-exceptions.c (exception_none): Don't define.
3933         (struct catcher) <exception>: Update.
3934         * cli/cli-interp.c (safe_execute_command): Update.
3935         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3936
3937 2019-04-25  Ali Tamur  <tamur@google.com>
3938
3939         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3940         (read_attribute_value): Likewise.
3941         (dwarf2_read_addr_index): Update comment.
3942         (read_str_index): Add DW_FORM_strx.
3943         (dwarf2_string_attr): Likewise.
3944         (dwarf2_const_value_attr): Likewise.
3945         (dump_die_shallow): Likewise.
3946         (dwarf2_fetch_constant_bytes): Likewise.
3947         (skip_form_bytes): Likewise.
3948         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3949
3950 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3951
3952         PR corefiles/11608
3953         PR corefiles/18187
3954         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3955         OFFSET.  Verify if current mapping contains an ELF header.
3956         (linux_find_memory_regions_full): Adjust call to
3957         dump_mapping_p.
3958
3959 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3960             Kang Li <kanglictf@gmail.com>
3961
3962         PR gdb/21600
3963
3964         * dwarf2-frame.c (read_initial_length): Be consistent about using
3965         unsigned representation of length.
3966         (decode_frame_entry_1): Likewise.  Check for wraparound of
3967         end pointer as well as buffer overflow.
3968
3969 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3970
3971         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3972         "vq".
3973
3974 2019-04-24  Tom Tromey  <tromey@adacore.com>
3975
3976         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3977
3978 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3979
3980         * s12z-tdep.c (s12z_unwind_pc): Delete.
3981         (s12z_unwind_sp): Delete.
3982         (s12z_gdbarch_init): Don't register deleted functions with
3983         gdbarch.
3984
3985 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3986
3987         * rl78-tdep.c (rl78_unwind_sp): Delete.
3988         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3989
3990 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3991
3992         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3993         (xstormy16_unwind_pc): Delete.
3994         (xstormy16_dummy_id): Delete.
3995         (xstormy16_gdbarch_init): Don't register deleted functions with
3996         gdbarch.
3997
3998 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3999
4000         * vax-tdep.c (vax_unwind_pc): Delete.
4001         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4002
4003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4004
4005         * v850-tdep.c (v850_unwind_sp): Delete.
4006         (v850_unwind_pc): Delete.
4007         (v850_dummy_id): Delete.
4008         (v850_gdbarch_init): Don't register deleted functions with
4009         gdbarch.
4010
4011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4012
4013         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4014         (tilegx_unwind_pc): Delete.
4015         (tilegx_unwind_dummy_id): Delete.
4016         (tilegx_gdbarch_init): Don't register deleted functions with
4017         gdbarch.
4018
4019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4020
4021         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4022         (tic6x_dummy_id): Delete.
4023         (tic6x_gdbarch_init): Don't register deleted functions with
4024         gdbarch.
4025
4026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4027
4028         * sparc-tdep.c (sparc_unwind_pc): Delete.
4029         (sparc32_gdbarch_init): Don't register deleted function with
4030         gdbarch.
4031
4032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4033
4034         * sh-tdep.c (sh_unwind_sp): Delete.
4035         (sh_unwind_pc): Delete.
4036         (sh_dummy_id): Delete.
4037         (sh_gdbarch_init): Don't register deleted functions with
4038         gdbarch.
4039
4040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4041
4042         * score-tdep.c (score_unwind_sp): Delete.
4043         (score_unwind_pc): Delete.
4044         (score_dummy_id): Delete.
4045         (score_gdbarch_init): Don't register deleted functions with
4046         gdbarch.
4047
4048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4049
4050         * rx-tdep.c (rx_unwind_pc): Delete.
4051         (rx_unwind_sp): Delete.
4052         (rx_dummy_id): Delete.
4053         (rx_gdbarch_init): Don't register deleted functions with
4054         gdbarch.  Update comment.
4055
4056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4057
4058         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4059         (rs6000_dummy_id): Delete.
4060         (rs6000_gdbarch_init): Don't register deleted functions with
4061         gdbarch.
4062
4063 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4064
4065         * or1k-tdep.c (or1k_dummy_id): Delete.
4066         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4067
4068 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4069
4070         * nios2-tdep.c (nios2_dummy_id): Delete.
4071         (nios2_unwind_sp): Delete.
4072         (nios2_gdbarch_init): Don't register deleted functions with
4073         gdbarch.
4074
4075 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4076
4077         * nds32-tdep.c (nds32_dummy_id): Delete.
4078         (nds32_unwind_pc): Delete.
4079         (nds32_unwind_sp): Delete.
4080         (nds32_gdbarch_init): Don't register deleted functions with
4081         gdbarch.
4082
4083 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4084
4085         * msp430-tdep.c (msp430_unwind_pc): Delete.
4086         (msp430_unwind_sp): Delete.
4087         (msp430_dummy_id): Delete.
4088         (msp430_gdbarch_init): Don't register deleted functions with
4089         gdbarch.
4090
4091 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4092
4093         * moxie-tdep.c (moxie_unwind_sp): Delete.
4094         (moxie_unwind_pc): Delete.
4095         (moxie_dummy_id): Delete.
4096         (moxie_gdbarch_init): Don't register deleted functions with
4097         gdbarch.
4098
4099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4100
4101         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4102         (mn10300_unwind_pc): Delete.
4103         (mn10300_unwind_sp): Delete.
4104         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4105         mn10300_unwind_sp.
4106         (mn10300_frame_unwind_init): Don't register deleted functions with
4107         gdbarch.
4108
4109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4110
4111         * mep-tdep.c (mep_unwind_pc): Delete.
4112         (mep_unwind_sp): Delete.
4113         (mep_dummy_id): Delete.
4114         (mep_gdbarch_init): Don't register deleted functions with
4115         gdbarch.
4116
4117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4118
4119         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4120         (m68hc11_unwind_sp): Delete.
4121         (m68hc11_gdbarch_init): Don't register deleted functions with
4122         gdbarch.
4123
4124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4125
4126         * m32r-tdep.c (m32r_unwind_sp): Delete.
4127         (m32r_unwind_pc): Delete.
4128         (m32r_dummy_id): Delete.
4129         (m32r_gdbarch_init): Don't register deleted functions with
4130         gdbarch.
4131
4132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4133
4134         * m32c-tdep.c (m32c_unwind_pc): Delete.
4135         (m32c_unwind_sp): Delete.
4136         (m32c_dummy_id): Delete.
4137         (m32c_gdbarch_init): Don't register deleted functions with
4138         gdbarch.
4139
4140 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4141
4142         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4143         (lm32_unwind_pc): Delete.
4144         (lm32_dummy_id): Delete.
4145         (lm32_gdbarch_init): Don't register deleted functions with
4146         gdbarch.
4147
4148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4149
4150         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4151         (iq2000_unwind_pc): Delete.
4152         (iq2000_dummy_id): Delete.
4153         (iq2000_gdbarch_init): Don't register deleted functions with
4154         gdbarch.
4155
4156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4157
4158         * nds32-tdep.c (nds32_type_align): Delete.
4159         (nds32_push_dummy_call): Use type_align instead.
4160
4161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4162
4163         * arm-tdep.c (arm_type_align): Only handle vector override case.
4164         (arm_push_dummy_call): Use type_align.
4165         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4166
4167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4168
4169         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4170         case.
4171         (pass_on_stack): Use type_align.
4172         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4173         function.
4174
4175 2019-04-23  Tom Tromey  <tromey@adacore.com>
4176
4177         * dwarf2read.c (line_header::file_name_at): Remove unused
4178         overload.
4179
4180 2019-04-23  Tom de Vries  <tdevries@suse.de>
4181
4182         PR gdb/24438
4183         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4184         invocation.
4185
4186
4187 2019-03-27  Ali Tamur  <tamur@google.com>
4188
4189         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4190         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4191         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4192         (dwarf_expr_context::get_addr_index): Likewise
4193         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4194         (symbol_needs_eval_context::get_addr_index): Likewise
4195         (disassemble_dwarf_expression): Add DW_OP_addrx
4196         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4197         (read_cutu_die_from_dwo): Update comment
4198         (skip_one_die): Add DW_FORM_addrx
4199         (read_attribute_value): Likewise
4200         (var_decode_location): Add DW_OP_addrx
4201         (dwarf2_const_value_attr): Add DW_FORM_addrx
4202         (dump_die_shallow): Likewise
4203         (dwarf2_fetch_constant_bytes): Likewise
4204         (decode_locdesc): Add DW_OP_addrx
4205         (skip_form_bytes): Add DW_FORM_addrx
4206
4207 2019-04-22  Ali Tamur  <tamur@google.com>
4208
4209         * MAINTAINERS (Write After Approval): Add self.
4210
4211 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4212
4213         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4214         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4215         (open_symbol_file_object): Likewise.
4216         (svr4_default_sos): Add info parameter.
4217         (svr4_read_so_list): Likewise.
4218         (svr4_current_sos_direct): Adjust functions calls to pass down
4219         info.
4220         (svr4_current_sos_1): Add info parameter.
4221         (svr4_current_sos): Call get_svr4_info, pass info down to
4222         svr4_current_sos_1.
4223         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4224         get_svr4_info.
4225         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4226         get_svr4_info.
4227         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4228         to get_svr4_info.
4229         (probes_table_remove_objfile_probes): Likewise.
4230         (register_solib_event_probe): Add info parameter.
4231         (solist_update_incremental): Pass info parameter down to
4232         svr4_read_so_list.
4233         (disable_probes_interface): Add info parameter.
4234         (svr4_handle_solib_event): Pass current_program_space to
4235         get_svr4_info.  Adjust disable_probes_interface cleanup.
4236         (svr4_create_probe_breakpoints): Add info parameter, pass it
4237         down to register_solib_event_probe.
4238         (svr4_create_solib_event_breakpoints): Add info parameter,
4239         pass it down to svr4_create_probe_breakpoints.
4240         (enable_break): Pass info down to
4241         svr4_create_solib_event_breakpoints.
4242         (svr4_solib_create_inferior_hook): Pass current_program_space to
4243         get_svr4_info.
4244         (svr4_clear_solib): Likewise.
4245
4246 2019-04-22  Pedro Alves  <palves@redhat.com>
4247
4248         * solib-svr4.c (svr4_free_objfile_observer): New.
4249         (probe_and_action::objfile): New field.
4250         (probes_table_htab_remove_objfile_probes)
4251         (probes_table_remove_objfile_probes): New functions.
4252         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4253         in the new probe_and_action.  Don't store the probe in 'lookup'.
4254         (svr4_create_probe_breakpoints): Pass objfile to
4255         register_solib_event_probe.
4256         (_initialize_svr4_solib): Register a free_objfile observer.
4257
4258 2019-04-19  Tom Tromey  <tom@tromey.com>
4259
4260         * common/queue.h: Remove.
4261
4262 2019-04-19  Tom Tromey  <tom@tromey.com>
4263
4264         * event-loop.c: Don't include "common/queue.h".
4265
4266 2019-04-19  Tom Tromey  <tom@tromey.com>
4267
4268         * remote.c (remote_target): Use delete.
4269         * remote-notif.h: Include <list>, not "common/queue.h".
4270         (notif_client_p): Remove typedef.
4271         (remote_notif_state): Add constructor, destructor, initializer.
4272         <notif_queue>: Now a std::list.
4273         (remote_notif_state_xfree): Don't declare.
4274         * remote-notif.c (remote_notif_process, handle_notification)
4275         (remote_notif_state_allocate): Update.
4276         (~remote_notif_state): Rename from remote_notif_state_xfree.
4277
4278 2019-04-19  Tom Tromey  <tom@tromey.com>
4279
4280         * symfile.c (reread_symbols): Update.
4281         * objfiles.c (objfile_register_static_link)
4282         (objfile_lookup_static_link): Update
4283         (~objfile) Don't delete static_links.
4284         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4285
4286 2019-04-19  Tom Tromey  <tom@tromey.com>
4287
4288         * type-stack.h (struct type_stack) <insert>: Constify string.
4289         * type-stack.c (type_stack::insert): Constify string.
4290         * gdbtypes.h (lookup_template_type): Update.
4291         (address_space_name_to_int): Update.
4292         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4293         const.
4294         (lookup_template_type): Make name const.
4295         * c-exp.y: Update rules.
4296         (lex_one_token, classify_name, classify_inner_name)
4297         (c_print_token): Update.
4298         * p-exp.y: Update rules.
4299         (yylex): Update.
4300         * f-exp.y: Update rules.
4301         (yylex): Update.
4302         * d-exp.y: Update rules.
4303         (lex_one_token, classify_name, classify_inner_name): Update.
4304         * parse.c (write_dollar_variable, copy_name): Return std::string.
4305         * parser-defs.h (copy_name): Change return type.
4306         * m2-exp.y: Update rules.
4307         (yylex): Update.
4308         * go-exp.y (lex_one_token): Update.
4309         Update rules.
4310         (classify_unsafe_function, classify_packaged_name)
4311         (classify_name, yylex): Update.
4312
4313 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4314
4315         * configure.ac: add --enable-source-highlight switch.
4316         * configure: Regenerate.
4317         * top.c (print_gdb_version): plumb --enable-source-highlight
4318         status to "show configuration".
4319
4320 2019-04-19  Tom Tromey  <tromey@adacore.com>
4321
4322         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4323         Check ADA_TYPE_P.
4324         (empty_record, ada_template_to_fixed_record_type_1)
4325         (template_to_static_fixed_type)
4326         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4327         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4328         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4329         macros.
4330
4331 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4332
4333         PR symtab/24423:
4334         * source.c (print_source_lines_base): Advance "iter" when a
4335         control character is seen.
4336
4337 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4338
4339         * inferior.h (struct infcall_suspend_state_deleter):
4340         Catch exception in destructor to avoid crash.
4341
4342 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4343
4344         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4345         close to the add_com "shell".
4346
4347 2019-04-18  Tom Tromey  <tromey@adacore.com>
4348
4349         * process-stratum-target.h (class process_stratum_target)
4350         <stratum>: Add "final".
4351
4352 2019-04-17  Tom Tromey  <tromey@adacore.com>
4353
4354         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4355         against nullptr before use.
4356
4357 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4358
4359         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4360
4361 2019-04-17  Jim Wilson  <jimw@sifive.com>
4362             Andrew Burgess  <andrew.burgess@embecosm.com>
4363
4364         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4365         code read might fail, assume 4-byte breakpoint in that case.
4366
4367 2019-04-15  Leszek Swirski  <leszeks@google.com>
4368
4369         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4370         rather than a hand-rolled POD check when checking for forced MEMORY
4371         classification.
4372
4373 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4374
4375         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4376         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4377         function.
4378         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4379         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4380         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4381         declaration.
4382
4383 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4384
4385         * aarch64-linux-nat.c
4386         (aarch64_linux_nat_target::thread_architecture): Add override.
4387         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4388         each VQ.
4389
4390 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4391
4392         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4393
4394 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4395
4396         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4397         target types of size 96-bits, add some additional comments, and
4398         check that the builtin type we found was the correct size.
4399
4400 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4401
4402         * utils.c (prompt_for_continue): Don't restore the styling at the
4403         end, as applied_style has the wrong value.  This fixes styling in
4404         long lists of file names that are interrupted by the "Continue?"
4405         prompt.
4406
4407 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4408
4409         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4410         * c-lang.c (c_language_defn): Likewise.
4411         (cplus_language_defn): Likewise.
4412         (asm_language_defn): Likewise.
4413         (minimal_language_defn): Likewise.
4414         * d-lang.c (d_language_defn): Likewise.
4415         * f-lang.c (f_language_defn): Likewise.
4416         * go-lang.c (go_language_defn): Likewise.
4417         * language.c (unknown_language_defn): Likewise.
4418         (auto_language_defn): Likewise.
4419         * language.h (struct language_defn): Remove la_magic field.
4420         (LANG_MAGIC): Delete.
4421         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4422         * objc-lang.c (objc_language_defn): Likewise.
4423         * opencl-lang.c (opencl_language_defn): Likewise.
4424         * p-lang.c (pascal_language_defn): Likewise.
4425         * rust-lang.c (rust_language_defn): Likewise.
4426
4427 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4428
4429         * riscv-tdep.c (riscv_type_align): New function.
4430         (riscv_type_alignment): Delete.
4431         (riscv_arg_location): Use 'type_align'.
4432         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4433
4434 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4435
4436         * gdbtypes.c (type_align): A struct with no non-static fields also
4437         has alignment of 1.
4438
4439 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4440
4441         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4442         component to 0.
4443         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4444         member.
4445         (riscv_struct_info::analyse): New implementation using new
4446         analyse_inner member function.
4447         (riscv_struct_info::field_offset): New member function.
4448         (riscv_struct_info::m_offsets): New member variable.
4449         (riscv_struct_info::analyse_inner): New private member function,
4450         takes the old implementation of riscv_struct_info::analyse but
4451         extended to track field offsets.
4452         (riscv_call_arg_struct): Update the struct folding special cases
4453         to handle cases where empty C++ structs, which are non-zero
4454         length, are found.
4455         (riscv_arg_location): Initialise the length of each location, a
4456         non-zero length now indicates the location is in use.
4457         (riscv_push_dummy_call): Allow for the first location having a
4458         non-zero offset when setting up arguments.
4459         (riscv_return_value): Likewise, but for return values.
4460
4461 2019-04-11  Tom Tromey  <tromey@adacore.com>
4462
4463         * utils.c (internal_vproblem): Make "msg" const.
4464
4465 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4466
4467         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4468         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4469         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4470         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4471
4472 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4473
4474         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4475         function.
4476         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4477         of amd64_collect_native_gregset.
4478         (amd64_linux_nat_target::store_registers): Likewise.
4479
4480 2019-04-10  Tom Tromey  <tom@tromey.com>
4481
4482         * symtab.c (lookup_global_symbol_from_objfile)
4483         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4484         * objfiles.h (class separate_debug_iterator): New.
4485         (class separate_debug_range): New.
4486         (struct objfile) <separate_debug_objfiles>: New method.
4487         (objfile_separate_debug_iterate): Don't declare.
4488         * objfiles.c (separate_debug_iterator::operator++): Rename from
4489         objfile_separate_debug_iterate.
4490         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4491         iterator.
4492         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4493         iterator.
4494
4495 2019-04-10  Tom Tromey  <tom@tromey.com>
4496
4497         * symfile.c (reread_symbols): Remove old comment.
4498         * objfiles.c (free_all_objfiles): Fix a typo.
4499
4500 2019-04-10  Tom Tromey  <tom@tromey.com>
4501
4502         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4503         * minsyms.c (lookup_minimal_symbol): Use foreach.
4504         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4505         (lookup_minimal_symbol_solib_trampoline): Likewise.
4506         * symfile.c (reread_symbols): Use foreach.
4507
4508 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4509             Tom Tromey  <tromey@adacore.com>
4510
4511         PR rust/24414:
4512         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4513         (rust_lex_int_test): Change "value" to be LONGEST.
4514         (rust_lex_tests): Add test for long integer literal.
4515
4516 2019-04-09  Tom Tromey  <tromey@adacore.com>
4517
4518         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4519         to bool.
4520         (extended_remote_target::attach): Update.
4521         (remote_target::remote_notice_new_inferior): Update.
4522         (remote_target::add_current_inferior_and_thread): Update.
4523         * inferior.c (exit_inferior_1): Use "false".
4524         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4525
4526 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4527
4528         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4529         the "start" command.
4530
4531 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4532
4533         * python/py-inferior.c (infpy_thread_from_thread_handle):
4534         Adjust comments to reflect renaming of thread_from_thread_handle
4535         to thread_from_handle.  Adjust keywords.  Fix type error message.
4536         (inferior_object_methods): Add thread_from_handle.  Retain
4537         thread_from_thread_handle, but mark it as deprecated.
4538
4539 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4540
4541         * gdbthread.h (find_thread_by_handle): Revise declaration.
4542         * thread.c (find_thread_by_handle): Likewise.  Adjust
4543         implementation too.
4544         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4545         support for buffer objects as handles.
4546
4547 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4548
4549         * python/py-infthread.c (thpy_thread_handle): New function.
4550         (thread_object_methods): Register thpy_thread_handle.
4551
4552 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4553
4554         * gdbthread.h (thread_to_thread_handle): Declare.
4555         * thread.c (gdbtypes.h): Include.
4556         (thread_to_thread_handle): New function.
4557
4558         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4559         (target_thread_info_to_thread_handle): Declare.
4560         * target.c (target_thread_info_to_thread_handle): New function.
4561         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4562         * target-delegates.c: Regenerate.
4563
4564         * linux-thread-db.c (class thread_db_target): Add method
4565         thread_info_to_thread_handle.
4566         (thread_db_target::thread_info_to_thread_handle): Define.
4567         * remote.c (class remote_target): Add new method
4568         thread_info_to_thread_handle.
4569         (remote_target::thread_info_to_thread_handle): Define.
4570
4571 2019-04-08  Pedro Alves  <palves@redhat.com>
4572
4573         * common/common-exceptions.c (throw_exception): Don't create
4574         named object to throw; throw directly.
4575         (throw_it): Likewise.  Don't initialize gdb_exception::message
4576         here, with new; pass FMT and AP to the ctor instead.
4577         * common/common-exceptions.h: Include <string>.
4578         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4579         const char *, va_list)): New ctor.  Use std::make_shared.
4580         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4581         errors)): Delete.
4582         (gdb_exception_error::gdb_exception_error(enum errors, const char
4583         *, va_list)): New.
4584         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4585         Add assertion.
4586         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4587         errors)): Delete.
4588         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4589         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4590         Add assertion.
4591
4592 2019-04-08  Tom Tromey  <tom@tromey.com>
4593
4594         * valops.c (value_rtti_indirect_type): Replace throw_exception
4595         with throw.
4596         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4597         with throw.
4598         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4599         throw.
4600         * target.c (target_translate_tls_address): Replace throw_exception
4601         with throw.
4602         * stack.c (frame_apply_command_count): Replace throw_exception
4603         with throw.
4604         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4605         throw.
4606         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4607         with throw.
4608         * rs6000-tdep.c (rs6000_frame_cache)
4609         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4610         * remote.c: Replace throw_exception with throw.
4611         * record-full.c (record_full_message, record_full_wait_1)
4612         (record_full_restore): Replace throw_exception with throw.
4613         * record-btrace.c:
4614         (get_thread_current_frame_id, record_btrace_start_replaying)
4615         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4616         (cmd_record_btrace_start): Replace throw_exception with throw.
4617         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4618         throw.
4619         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4620         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4621         * linespec.c:
4622         (find_linespec_symbols): Replace throw_exception with throw.
4623         * infrun.c (displaced_step_prepare, resume): Replace
4624         throw_exception with throw.
4625         * infcmd.c (post_create_inferior): Replace throw_exception with
4626         throw.
4627         * inf-loop.c (inferior_event_handler): Replace throw_exception
4628         with throw.
4629         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4630         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4631         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4632         (get_prev_frame_always, get_frame_pc_if_available)
4633         (get_frame_address_in_block_if_available, get_frame_language):
4634         Replace throw_exception with throw.
4635         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4636         throw_exception with throw.
4637         * eval.c (fetch_subexp_value, evaluate_var_value)
4638         (evaluate_funcall, evaluate_subexp_standard): Replace
4639         throw_exception with throw.
4640         * dwarf2loc.c (call_site_find_chain)
4641         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4642         Replace throw_exception with throw.
4643         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4644         with throw.
4645         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4646         throw.
4647         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4648         * completer.c (complete_line_internal): Replace throw_exception
4649         with throw.
4650         * compile/compile-object-run.c (compile_object_run): Replace
4651         throw_exception with throw.
4652         * cli/cli-script.c (process_next_line): Replace throw_exception
4653         with throw.
4654         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4655         (btrace_enable, btrace_maint_update_pt_packets): Replace
4656         throw_exception with throw.
4657         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4658         throw_exception with throw.
4659         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4660         throw_exception with throw.
4661         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4662         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4663         * aarch64-tdep.c (aarch64_make_prologue_cache)
4664         (aarch64_make_stub_cache): Replace throw_exception with throw.
4665
4666 2019-04-08  Tom Tromey  <tom@tromey.com>
4667
4668         * common/common-exceptions.c (throw_exception): Rename from
4669         throw_exception_cxx.  Remove old copy.  Make argument const.
4670         (throw_it): Create and throw exception objects directly.
4671         * common/common-exceptions.h (throw_exception): Make argument
4672         const.
4673         (struct gdb_exception_error): Add constructor.
4674         (struct gdb_exception_quit): Add constructor.
4675
4676 2019-04-08  Tom Tromey  <tom@tromey.com>
4677
4678         * common/common-exceptions.h (exception_rethrow): Don't declare.
4679         (TRY_SJLJ): Update comment.
4680         (TRY, CATCH, END_CATCH): Remove.
4681         * common/common-exceptions.c (exception_rethrow): Remove.
4682
4683 2019-04-08  Tom Tromey  <tom@tromey.com>
4684
4685         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4686         Remove.
4687         (gdb_exception_error): Rename from
4688         gdb_exception_RETURN_MASK_ERROR.
4689         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4690         (gdb_quit_bad_alloc): Update.
4691         * aarch64-tdep.c: Update.
4692         * ada-lang.c: Update.
4693         * ada-typeprint.c: Update.
4694         * ada-valprint.c: Update.
4695         * amd64-tdep.c: Update.
4696         * arch-utils.c: Update.
4697         * break-catch-throw.c: Update.
4698         * breakpoint.c: Update.
4699         * btrace.c: Update.
4700         * c-varobj.c: Update.
4701         * cli/cli-cmds.c: Update.
4702         * cli/cli-interp.c: Update.
4703         * cli/cli-script.c: Update.
4704         * common/common-exceptions.c: Update.
4705         * common/new-op.c: Update.
4706         * common/selftest.c: Update.
4707         * compile/compile-c-symbols.c: Update.
4708         * compile/compile-cplus-symbols.c: Update.
4709         * compile/compile-object-load.c: Update.
4710         * compile/compile-object-run.c: Update.
4711         * completer.c: Update.
4712         * corelow.c: Update.
4713         * cp-abi.c: Update.
4714         * cp-support.c: Update.
4715         * cp-valprint.c: Update.
4716         * darwin-nat.c: Update.
4717         * disasm-selftests.c: Update.
4718         * dtrace-probe.c: Update.
4719         * dwarf-index-cache.c: Update.
4720         * dwarf-index-write.c: Update.
4721         * dwarf2-frame-tailcall.c: Update.
4722         * dwarf2-frame.c: Update.
4723         * dwarf2loc.c: Update.
4724         * dwarf2read.c: Update.
4725         * eval.c: Update.
4726         * event-loop.c: Update.
4727         * event-top.c: Update.
4728         * exec.c: Update.
4729         * f-valprint.c: Update.
4730         * fbsd-tdep.c: Update.
4731         * frame-unwind.c: Update.
4732         * frame.c: Update.
4733         * gdbtypes.c: Update.
4734         * gnu-v3-abi.c: Update.
4735         * guile/guile-internal.h: Update.
4736         * guile/scm-block.c: Update.
4737         * guile/scm-breakpoint.c: Update.
4738         * guile/scm-cmd.c: Update.
4739         * guile/scm-disasm.c: Update.
4740         * guile/scm-frame.c: Update.
4741         * guile/scm-lazy-string.c: Update.
4742         * guile/scm-math.c: Update.
4743         * guile/scm-param.c: Update.
4744         * guile/scm-ports.c: Update.
4745         * guile/scm-pretty-print.c: Update.
4746         * guile/scm-symbol.c: Update.
4747         * guile/scm-symtab.c: Update.
4748         * guile/scm-type.c: Update.
4749         * guile/scm-value.c: Update.
4750         * i386-linux-tdep.c: Update.
4751         * i386-tdep.c: Update.
4752         * inf-loop.c: Update.
4753         * infcall.c: Update.
4754         * infcmd.c: Update.
4755         * infrun.c: Update.
4756         * jit.c: Update.
4757         * language.c: Update.
4758         * linespec.c: Update.
4759         * linux-fork.c: Update.
4760         * linux-nat.c: Update.
4761         * linux-tdep.c: Update.
4762         * linux-thread-db.c: Update.
4763         * main.c: Update.
4764         * mi/mi-cmd-break.c: Update.
4765         * mi/mi-cmd-stack.c: Update.
4766         * mi/mi-interp.c: Update.
4767         * mi/mi-main.c: Update.
4768         * objc-lang.c: Update.
4769         * p-valprint.c: Update.
4770         * parse.c: Update.
4771         * ppc-linux-tdep.c: Update.
4772         * printcmd.c: Update.
4773         * python/py-arch.c: Update.
4774         * python/py-breakpoint.c: Update.
4775         * python/py-cmd.c: Update.
4776         * python/py-finishbreakpoint.c: Update.
4777         * python/py-frame.c: Update.
4778         * python/py-framefilter.c: Update.
4779         * python/py-gdb-readline.c: Update.
4780         * python/py-inferior.c: Update.
4781         * python/py-infthread.c: Update.
4782         * python/py-lazy-string.c: Update.
4783         * python/py-linetable.c: Update.
4784         * python/py-objfile.c: Update.
4785         * python/py-param.c: Update.
4786         * python/py-prettyprint.c: Update.
4787         * python/py-progspace.c: Update.
4788         * python/py-record-btrace.c: Update.
4789         * python/py-record.c: Update.
4790         * python/py-symbol.c: Update.
4791         * python/py-type.c: Update.
4792         * python/py-unwind.c: Update.
4793         * python/py-utils.c: Update.
4794         * python/py-value.c: Update.
4795         * python/python.c: Update.
4796         * record-btrace.c: Update.
4797         * record-full.c: Update.
4798         * remote-fileio.c: Update.
4799         * remote.c: Update.
4800         * riscv-tdep.c: Update.
4801         * rs6000-aix-tdep.c: Update.
4802         * rs6000-tdep.c: Update.
4803         * rust-exp.y: Update.
4804         * rust-lang.c: Update.
4805         * s390-tdep.c: Update.
4806         * selftest-arch.c: Update.
4807         * solib-dsbt.c: Update.
4808         * solib-frv.c: Update.
4809         * solib-spu.c: Update.
4810         * solib-svr4.c: Update.
4811         * solib.c: Update.
4812         * sparc64-linux-tdep.c: Update.
4813         * stack.c: Update.
4814         * symfile-mem.c: Update.
4815         * symmisc.c: Update.
4816         * target.c: Update.
4817         * thread.c: Update.
4818         * top.c: Update.
4819         * tracefile-tfile.c: Update.
4820         * tui/tui.c: Update.
4821         * typeprint.c: Update.
4822         * unittests/cli-utils-selftests.c: Update.
4823         * unittests/parse-connection-spec-selftests.c: Update.
4824         * valops.c: Update.
4825         * valprint.c: Update.
4826         * value.c: Update.
4827         * varobj.c: Update.
4828         * windows-nat.c: Update.
4829         * x86-linux-nat.c: Update.
4830         * xml-support.c: Update.
4831
4832 2019-04-08  Tom Tromey  <tom@tromey.com>
4833
4834         * xml-support.c: Use C++ exception handling.
4835         * x86-linux-nat.c: Use C++ exception handling.
4836         * windows-nat.c: Use C++ exception handling.
4837         * varobj.c: Use C++ exception handling.
4838         * value.c: Use C++ exception handling.
4839         * valprint.c: Use C++ exception handling.
4840         * valops.c: Use C++ exception handling.
4841         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4842         handling.
4843         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4844         * typeprint.c: Use C++ exception handling.
4845         * tui/tui.c: Use C++ exception handling.
4846         * tracefile-tfile.c: Use C++ exception handling.
4847         * top.c: Use C++ exception handling.
4848         * thread.c: Use C++ exception handling.
4849         * target.c: Use C++ exception handling.
4850         * symmisc.c: Use C++ exception handling.
4851         * symfile-mem.c: Use C++ exception handling.
4852         * stack.c: Use C++ exception handling.
4853         * sparc64-linux-tdep.c: Use C++ exception handling.
4854         * solib.c: Use C++ exception handling.
4855         * solib-svr4.c: Use C++ exception handling.
4856         * solib-spu.c: Use C++ exception handling.
4857         * solib-frv.c: Use C++ exception handling.
4858         * solib-dsbt.c: Use C++ exception handling.
4859         * selftest-arch.c: Use C++ exception handling.
4860         * s390-tdep.c: Use C++ exception handling.
4861         * rust-lang.c: Use C++ exception handling.
4862         * rust-exp.y: Use C++ exception handling.
4863         * rs6000-tdep.c: Use C++ exception handling.
4864         * rs6000-aix-tdep.c: Use C++ exception handling.
4865         * riscv-tdep.c: Use C++ exception handling.
4866         * remote.c: Use C++ exception handling.
4867         * remote-fileio.c: Use C++ exception handling.
4868         * record-full.c: Use C++ exception handling.
4869         * record-btrace.c: Use C++ exception handling.
4870         * python/python.c: Use C++ exception handling.
4871         * python/py-value.c: Use C++ exception handling.
4872         * python/py-utils.c: Use C++ exception handling.
4873         * python/py-unwind.c: Use C++ exception handling.
4874         * python/py-type.c: Use C++ exception handling.
4875         * python/py-symbol.c: Use C++ exception handling.
4876         * python/py-record.c: Use C++ exception handling.
4877         * python/py-record-btrace.c: Use C++ exception handling.
4878         * python/py-progspace.c: Use C++ exception handling.
4879         * python/py-prettyprint.c: Use C++ exception handling.
4880         * python/py-param.c: Use C++ exception handling.
4881         * python/py-objfile.c: Use C++ exception handling.
4882         * python/py-linetable.c: Use C++ exception handling.
4883         * python/py-lazy-string.c: Use C++ exception handling.
4884         * python/py-infthread.c: Use C++ exception handling.
4885         * python/py-inferior.c: Use C++ exception handling.
4886         * python/py-gdb-readline.c: Use C++ exception handling.
4887         * python/py-framefilter.c: Use C++ exception handling.
4888         * python/py-frame.c: Use C++ exception handling.
4889         * python/py-finishbreakpoint.c: Use C++ exception handling.
4890         * python/py-cmd.c: Use C++ exception handling.
4891         * python/py-breakpoint.c: Use C++ exception handling.
4892         * python/py-arch.c: Use C++ exception handling.
4893         * printcmd.c: Use C++ exception handling.
4894         * ppc-linux-tdep.c: Use C++ exception handling.
4895         * parse.c: Use C++ exception handling.
4896         * p-valprint.c: Use C++ exception handling.
4897         * objc-lang.c: Use C++ exception handling.
4898         * mi/mi-main.c: Use C++ exception handling.
4899         * mi/mi-interp.c: Use C++ exception handling.
4900         * mi/mi-cmd-stack.c: Use C++ exception handling.
4901         * mi/mi-cmd-break.c: Use C++ exception handling.
4902         * main.c: Use C++ exception handling.
4903         * linux-thread-db.c: Use C++ exception handling.
4904         * linux-tdep.c: Use C++ exception handling.
4905         * linux-nat.c: Use C++ exception handling.
4906         * linux-fork.c: Use C++ exception handling.
4907         * linespec.c: Use C++ exception handling.
4908         * language.c: Use C++ exception handling.
4909         * jit.c: Use C++ exception handling.
4910         * infrun.c: Use C++ exception handling.
4911         * infcmd.c: Use C++ exception handling.
4912         * infcall.c: Use C++ exception handling.
4913         * inf-loop.c: Use C++ exception handling.
4914         * i386-tdep.c: Use C++ exception handling.
4915         * i386-linux-tdep.c: Use C++ exception handling.
4916         * guile/scm-value.c: Use C++ exception handling.
4917         * guile/scm-type.c: Use C++ exception handling.
4918         * guile/scm-symtab.c: Use C++ exception handling.
4919         * guile/scm-symbol.c: Use C++ exception handling.
4920         * guile/scm-pretty-print.c: Use C++ exception handling.
4921         * guile/scm-ports.c: Use C++ exception handling.
4922         * guile/scm-param.c: Use C++ exception handling.
4923         * guile/scm-math.c: Use C++ exception handling.
4924         * guile/scm-lazy-string.c: Use C++ exception handling.
4925         * guile/scm-frame.c: Use C++ exception handling.
4926         * guile/scm-disasm.c: Use C++ exception handling.
4927         * guile/scm-cmd.c: Use C++ exception handling.
4928         * guile/scm-breakpoint.c: Use C++ exception handling.
4929         * guile/scm-block.c: Use C++ exception handling.
4930         * guile/guile-internal.h: Use C++ exception handling.
4931         * gnu-v3-abi.c: Use C++ exception handling.
4932         * gdbtypes.c: Use C++ exception handling.
4933         * frame.c: Use C++ exception handling.
4934         * frame-unwind.c: Use C++ exception handling.
4935         * fbsd-tdep.c: Use C++ exception handling.
4936         * f-valprint.c: Use C++ exception handling.
4937         * exec.c: Use C++ exception handling.
4938         * event-top.c: Use C++ exception handling.
4939         * event-loop.c: Use C++ exception handling.
4940         * eval.c: Use C++ exception handling.
4941         * dwarf2read.c: Use C++ exception handling.
4942         * dwarf2loc.c: Use C++ exception handling.
4943         * dwarf2-frame.c: Use C++ exception handling.
4944         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4945         * dwarf-index-write.c: Use C++ exception handling.
4946         * dwarf-index-cache.c: Use C++ exception handling.
4947         * dtrace-probe.c: Use C++ exception handling.
4948         * disasm-selftests.c: Use C++ exception handling.
4949         * darwin-nat.c: Use C++ exception handling.
4950         * cp-valprint.c: Use C++ exception handling.
4951         * cp-support.c: Use C++ exception handling.
4952         * cp-abi.c: Use C++ exception handling.
4953         * corelow.c: Use C++ exception handling.
4954         * completer.c: Use C++ exception handling.
4955         * compile/compile-object-run.c: Use C++ exception handling.
4956         * compile/compile-object-load.c: Use C++ exception handling.
4957         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4958         * compile/compile-c-symbols.c: Use C++ exception handling.
4959         * common/selftest.c: Use C++ exception handling.
4960         * common/new-op.c: Use C++ exception handling.
4961         * cli/cli-script.c: Use C++ exception handling.
4962         * cli/cli-interp.c: Use C++ exception handling.
4963         * cli/cli-cmds.c: Use C++ exception handling.
4964         * c-varobj.c: Use C++ exception handling.
4965         * btrace.c: Use C++ exception handling.
4966         * breakpoint.c: Use C++ exception handling.
4967         * break-catch-throw.c: Use C++ exception handling.
4968         * arch-utils.c: Use C++ exception handling.
4969         * amd64-tdep.c: Use C++ exception handling.
4970         * ada-valprint.c: Use C++ exception handling.
4971         * ada-typeprint.c: Use C++ exception handling.
4972         * ada-lang.c: Use C++ exception handling.
4973         * aarch64-tdep.c: Use C++ exception handling.
4974
4975 2019-04-08  Tom Tromey  <tom@tromey.com>
4976
4977         * xml-support.c (gdb_xml_parser::parse): Update.
4978         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4979         * value.c (show_convenience): Update.
4980         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4981         (test_parse_flags_qcs): Update.
4982         * thread.c (thr_try_catch_cmd): Update.
4983         * target.c (target_translate_tls_address): Update.
4984         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4985         (info_frame_command_core, frame_apply_command_count): Update.
4986         * rust-exp.y (rust_lex_exception_test): Update.
4987         * riscv-tdep.c (riscv_print_one_register_info): Update.
4988         * remote.c (remote_target::enable_btrace): Update.
4989         * record-btrace.c (record_btrace_enable_warn): Update.
4990         * python/py-utils.c (gdbpy_convert_exception): Update.
4991         * printcmd.c (do_one_display, print_variable_and_value): Update.
4992         * mi/mi-main.c (mi_print_exception): Update.
4993         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4994         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4995         * linux-nat.c (linux_nat_target::attach): Update.
4996         * linux-fork.c (class scoped_switch_fork_info): Update.
4997         * infrun.c (displaced_step_prepare): Update.
4998         * infcall.c (call_function_by_hand_dummy): Update.
4999         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5000         * gnu-v3-abi.c (print_one_vtable): Update.
5001         * frame.c (get_prev_frame_always): Update.
5002         * f-valprint.c (info_common_command_for_block): Update.
5003         * exec.c (try_open_exec_file): Update.
5004         * exceptions.c (print_exception, exception_print)
5005         (exception_fprintf, exception_print_same): Update.
5006         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5007         * dwarf-index-cache.c (index_cache::store)
5008         (index_cache::lookup_gdb_index): Update.
5009         * darwin-nat.c (maybe_cache_shell): Update.
5010         * cp-valprint.c (cp_print_value_fields): Update.
5011         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5012         (gcc_cplus_symbol_address): Update.
5013         * compile/compile-c-symbols.c (gcc_convert_symbol)
5014         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5015         * common/selftest.c: Update.
5016         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5017         a std::string.
5018         (exception_try_scope_entry, exception_try_scope_exit): Don't
5019         declare.
5020         (struct exception_try_scope): Remove.
5021         (TRY): Don't use exception_try_scope.
5022         (struct gdb_exception): Add constructor, operator=.
5023         <what>: New method.
5024         (struct gdb_exception_RETURN_MASK_ALL)
5025         (struct gdb_exception_RETURN_MASK_ERROR)
5026         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5027         (struct gdb_quit_bad_alloc): Update.
5028         * common/common-exceptions.c (exception_none): Change
5029         initializer.
5030         (struct catcher) <state, exception>: Initialize inline.
5031         <prev>: Remove member.
5032         (current_catcher): Remove.
5033         (catchers): New global.
5034         (exceptions_state_mc_init): Simplify.
5035         (catcher_pop): Remove.
5036         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5037         (try_scope_depth, exception_try_scope_entry)
5038         (exception_try_scope_exit): Remove.
5039         (throw_exception_sjlj): Update.
5040         (exception_messages, exception_messages_size): Remove.
5041         (throw_it): Simplify.
5042         (gdb_exception_sliced_copy): Remove.
5043         (throw_exception_cxx): Update.
5044         * cli/cli-script.c (script_from_file): Update.
5045         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5046         Update.
5047         * ada-valprint.c (ada_val_print): Update.
5048         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5049         (create_excep_cond_exprs): Update.
5050
5051 2019-04-08  Tom Tromey  <tom@tromey.com>
5052
5053         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5054         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5055         (TRY, CATCH, END_CATCH): Remove some definitions.
5056         * common/common-exceptions.c: Don't use GDB_XCPT.
5057         (catcher_list_size): Remove.
5058         (throw_exception, throw_it): Simplify.
5059
5060 2019-04-05  Tom Tromey  <tom@tromey.com>
5061
5062         Revert the header-sorting patch.
5063         * ft32-tdep.c: Revert.
5064         * frv-tdep.c: Revert.
5065         * frv-linux-tdep.c: Revert.
5066         * frame.c: Revert.
5067         * frame-unwind.c: Revert.
5068         * frame-base.c: Revert.
5069         * fork-child.c: Revert.
5070         * findvar.c: Revert.
5071         * findcmd.c: Revert.
5072         * filesystem.c: Revert.
5073         * filename-seen-cache.h: Revert.
5074         * filename-seen-cache.c: Revert.
5075         * fbsd-tdep.c: Revert.
5076         * fbsd-nat.h: Revert.
5077         * fbsd-nat.c: Revert.
5078         * f-valprint.c: Revert.
5079         * f-typeprint.c: Revert.
5080         * f-lang.c: Revert.
5081         * extension.h: Revert.
5082         * extension.c: Revert.
5083         * extension-priv.h: Revert.
5084         * expprint.c: Revert.
5085         * exec.h: Revert.
5086         * exec.c: Revert.
5087         * exceptions.c: Revert.
5088         * event-top.c: Revert.
5089         * event-loop.c: Revert.
5090         * eval.c: Revert.
5091         * elfread.c: Revert.
5092         * dwarf2read.h: Revert.
5093         * dwarf2read.c: Revert.
5094         * dwarf2loc.c: Revert.
5095         * dwarf2expr.h: Revert.
5096         * dwarf2expr.c: Revert.
5097         * dwarf2-frame.c: Revert.
5098         * dwarf2-frame-tailcall.c: Revert.
5099         * dwarf-index-write.h: Revert.
5100         * dwarf-index-write.c: Revert.
5101         * dwarf-index-common.c: Revert.
5102         * dwarf-index-cache.h: Revert.
5103         * dwarf-index-cache.c: Revert.
5104         * dummy-frame.c: Revert.
5105         * dtrace-probe.c: Revert.
5106         * disasm.h: Revert.
5107         * disasm.c: Revert.
5108         * disasm-selftests.c: Revert.
5109         * dictionary.c: Revert.
5110         * dicos-tdep.c: Revert.
5111         * demangle.c: Revert.
5112         * dcache.h: Revert.
5113         * dcache.c: Revert.
5114         * darwin-nat.h: Revert.
5115         * darwin-nat.c: Revert.
5116         * darwin-nat-info.c: Revert.
5117         * d-valprint.c: Revert.
5118         * d-namespace.c: Revert.
5119         * d-lang.c: Revert.
5120         * ctf.c: Revert.
5121         * csky-tdep.c: Revert.
5122         * csky-linux-tdep.c: Revert.
5123         * cris-tdep.c: Revert.
5124         * cris-linux-tdep.c: Revert.
5125         * cp-valprint.c: Revert.
5126         * cp-support.c: Revert.
5127         * cp-namespace.c: Revert.
5128         * cp-abi.c: Revert.
5129         * corelow.c: Revert.
5130         * corefile.c: Revert.
5131         * continuations.c: Revert.
5132         * completer.h: Revert.
5133         * completer.c: Revert.
5134         * complaints.c: Revert.
5135         * coffread.c: Revert.
5136         * coff-pe-read.c: Revert.
5137         * cli-out.h: Revert.
5138         * cli-out.c: Revert.
5139         * charset.c: Revert.
5140         * c-varobj.c: Revert.
5141         * c-valprint.c: Revert.
5142         * c-typeprint.c: Revert.
5143         * c-lang.c: Revert.
5144         * buildsym.c: Revert.
5145         * buildsym-legacy.c: Revert.
5146         * build-id.h: Revert.
5147         * build-id.c: Revert.
5148         * btrace.c: Revert.
5149         * bsd-uthread.c: Revert.
5150         * breakpoint.h: Revert.
5151         * breakpoint.c: Revert.
5152         * break-catch-throw.c: Revert.
5153         * break-catch-syscall.c: Revert.
5154         * break-catch-sig.c: Revert.
5155         * blockframe.c: Revert.
5156         * block.c: Revert.
5157         * bfin-tdep.c: Revert.
5158         * bfin-linux-tdep.c: Revert.
5159         * bfd-target.c: Revert.
5160         * bcache.c: Revert.
5161         * ax-general.c: Revert.
5162         * ax-gdb.h: Revert.
5163         * ax-gdb.c: Revert.
5164         * avr-tdep.c: Revert.
5165         * auxv.c: Revert.
5166         * auto-load.c: Revert.
5167         * arm-wince-tdep.c: Revert.
5168         * arm-tdep.c: Revert.
5169         * arm-symbian-tdep.c: Revert.
5170         * arm-pikeos-tdep.c: Revert.
5171         * arm-obsd-tdep.c: Revert.
5172         * arm-nbsd-tdep.c: Revert.
5173         * arm-nbsd-nat.c: Revert.
5174         * arm-linux-tdep.c: Revert.
5175         * arm-linux-nat.c: Revert.
5176         * arm-fbsd-tdep.c: Revert.
5177         * arm-fbsd-nat.c: Revert.
5178         * arm-bsd-tdep.c: Revert.
5179         * arch-utils.c: Revert.
5180         * arc-tdep.c: Revert.
5181         * arc-newlib-tdep.c: Revert.
5182         * annotate.h: Revert.
5183         * annotate.c: Revert.
5184         * amd64-windows-tdep.c: Revert.
5185         * amd64-windows-nat.c: Revert.
5186         * amd64-tdep.c: Revert.
5187         * amd64-sol2-tdep.c: Revert.
5188         * amd64-obsd-tdep.c: Revert.
5189         * amd64-obsd-nat.c: Revert.
5190         * amd64-nbsd-tdep.c: Revert.
5191         * amd64-nbsd-nat.c: Revert.
5192         * amd64-nat.c: Revert.
5193         * amd64-linux-tdep.c: Revert.
5194         * amd64-linux-nat.c: Revert.
5195         * amd64-fbsd-tdep.c: Revert.
5196         * amd64-fbsd-nat.c: Revert.
5197         * amd64-dicos-tdep.c: Revert.
5198         * amd64-darwin-tdep.c: Revert.
5199         * amd64-bsd-nat.c: Revert.
5200         * alpha-tdep.c: Revert.
5201         * alpha-obsd-tdep.c: Revert.
5202         * alpha-nbsd-tdep.c: Revert.
5203         * alpha-mdebug-tdep.c: Revert.
5204         * alpha-linux-tdep.c: Revert.
5205         * alpha-linux-nat.c: Revert.
5206         * alpha-bsd-tdep.c: Revert.
5207         * alpha-bsd-nat.c: Revert.
5208         * aix-thread.c: Revert.
5209         * agent.c: Revert.
5210         * addrmap.c: Revert.
5211         * ada-varobj.c: Revert.
5212         * ada-valprint.c: Revert.
5213         * ada-typeprint.c: Revert.
5214         * ada-tasks.c: Revert.
5215         * ada-lang.c: Revert.
5216         * aarch64-tdep.c: Revert.
5217         * aarch64-ravenscar-thread.c: Revert.
5218         * aarch64-newlib-tdep.c: Revert.
5219         * aarch64-linux-tdep.c: Revert.
5220         * aarch64-linux-nat.c: Revert.
5221         * aarch64-fbsd-tdep.c: Revert.
5222         * aarch64-fbsd-nat.c: Revert.
5223         * aarch32-linux-nat.c: Revert.
5224
5225 2019-04-05  Tom Tromey  <tom@tromey.com>
5226
5227         * ft32-tdep.c: Sort headers.
5228         * frv-tdep.c: Sort headers.
5229         * frv-linux-tdep.c: Sort headers.
5230         * frame.c: Sort headers.
5231         * frame-unwind.c: Sort headers.
5232         * frame-base.c: Sort headers.
5233         * fork-child.c: Sort headers.
5234         * findvar.c: Sort headers.
5235         * findcmd.c: Sort headers.
5236         * filesystem.c: Sort headers.
5237         * filename-seen-cache.h: Sort headers.
5238         * filename-seen-cache.c: Sort headers.
5239         * fbsd-tdep.c: Sort headers.
5240         * fbsd-nat.h: Sort headers.
5241         * fbsd-nat.c: Sort headers.
5242         * f-valprint.c: Sort headers.
5243         * f-typeprint.c: Sort headers.
5244         * f-lang.c: Sort headers.
5245         * extension.h: Sort headers.
5246         * extension.c: Sort headers.
5247         * extension-priv.h: Sort headers.
5248         * expprint.c: Sort headers.
5249         * exec.h: Sort headers.
5250         * exec.c: Sort headers.
5251         * exceptions.c: Sort headers.
5252         * event-top.c: Sort headers.
5253         * event-loop.c: Sort headers.
5254         * eval.c: Sort headers.
5255         * elfread.c: Sort headers.
5256         * dwarf2read.h: Sort headers.
5257         * dwarf2read.c: Sort headers.
5258         * dwarf2loc.c: Sort headers.
5259         * dwarf2expr.h: Sort headers.
5260         * dwarf2expr.c: Sort headers.
5261         * dwarf2-frame.c: Sort headers.
5262         * dwarf2-frame-tailcall.c: Sort headers.
5263         * dwarf-index-write.h: Sort headers.
5264         * dwarf-index-write.c: Sort headers.
5265         * dwarf-index-common.c: Sort headers.
5266         * dwarf-index-cache.h: Sort headers.
5267         * dwarf-index-cache.c: Sort headers.
5268         * dummy-frame.c: Sort headers.
5269         * dtrace-probe.c: Sort headers.
5270         * disasm.h: Sort headers.
5271         * disasm.c: Sort headers.
5272         * disasm-selftests.c: Sort headers.
5273         * dictionary.c: Sort headers.
5274         * dicos-tdep.c: Sort headers.
5275         * demangle.c: Sort headers.
5276         * dcache.h: Sort headers.
5277         * dcache.c: Sort headers.
5278         * darwin-nat.h: Sort headers.
5279         * darwin-nat.c: Sort headers.
5280         * darwin-nat-info.c: Sort headers.
5281         * d-valprint.c: Sort headers.
5282         * d-namespace.c: Sort headers.
5283         * d-lang.c: Sort headers.
5284         * ctf.c: Sort headers.
5285         * csky-tdep.c: Sort headers.
5286         * csky-linux-tdep.c: Sort headers.
5287         * cris-tdep.c: Sort headers.
5288         * cris-linux-tdep.c: Sort headers.
5289         * cp-valprint.c: Sort headers.
5290         * cp-support.c: Sort headers.
5291         * cp-namespace.c: Sort headers.
5292         * cp-abi.c: Sort headers.
5293         * corelow.c: Sort headers.
5294         * corefile.c: Sort headers.
5295         * continuations.c: Sort headers.
5296         * completer.h: Sort headers.
5297         * completer.c: Sort headers.
5298         * complaints.c: Sort headers.
5299         * coffread.c: Sort headers.
5300         * coff-pe-read.c: Sort headers.
5301         * cli-out.h: Sort headers.
5302         * cli-out.c: Sort headers.
5303         * charset.c: Sort headers.
5304         * c-varobj.c: Sort headers.
5305         * c-valprint.c: Sort headers.
5306         * c-typeprint.c: Sort headers.
5307         * c-lang.c: Sort headers.
5308         * buildsym.c: Sort headers.
5309         * buildsym-legacy.c: Sort headers.
5310         * build-id.h: Sort headers.
5311         * build-id.c: Sort headers.
5312         * btrace.c: Sort headers.
5313         * bsd-uthread.c: Sort headers.
5314         * breakpoint.h: Sort headers.
5315         * breakpoint.c: Sort headers.
5316         * break-catch-throw.c: Sort headers.
5317         * break-catch-syscall.c: Sort headers.
5318         * break-catch-sig.c: Sort headers.
5319         * blockframe.c: Sort headers.
5320         * block.c: Sort headers.
5321         * bfin-tdep.c: Sort headers.
5322         * bfin-linux-tdep.c: Sort headers.
5323         * bfd-target.c: Sort headers.
5324         * bcache.c: Sort headers.
5325         * ax-general.c: Sort headers.
5326         * ax-gdb.h: Sort headers.
5327         * ax-gdb.c: Sort headers.
5328         * avr-tdep.c: Sort headers.
5329         * auxv.c: Sort headers.
5330         * auto-load.c: Sort headers.
5331         * arm-wince-tdep.c: Sort headers.
5332         * arm-tdep.c: Sort headers.
5333         * arm-symbian-tdep.c: Sort headers.
5334         * arm-pikeos-tdep.c: Sort headers.
5335         * arm-obsd-tdep.c: Sort headers.
5336         * arm-nbsd-tdep.c: Sort headers.
5337         * arm-nbsd-nat.c: Sort headers.
5338         * arm-linux-tdep.c: Sort headers.
5339         * arm-linux-nat.c: Sort headers.
5340         * arm-fbsd-tdep.c: Sort headers.
5341         * arm-fbsd-nat.c: Sort headers.
5342         * arm-bsd-tdep.c: Sort headers.
5343         * arch-utils.c: Sort headers.
5344         * arc-tdep.c: Sort headers.
5345         * arc-newlib-tdep.c: Sort headers.
5346         * annotate.h: Sort headers.
5347         * annotate.c: Sort headers.
5348         * amd64-windows-tdep.c: Sort headers.
5349         * amd64-windows-nat.c: Sort headers.
5350         * amd64-tdep.c: Sort headers.
5351         * amd64-sol2-tdep.c: Sort headers.
5352         * amd64-obsd-tdep.c: Sort headers.
5353         * amd64-obsd-nat.c: Sort headers.
5354         * amd64-nbsd-tdep.c: Sort headers.
5355         * amd64-nbsd-nat.c: Sort headers.
5356         * amd64-nat.c: Sort headers.
5357         * amd64-linux-tdep.c: Sort headers.
5358         * amd64-linux-nat.c: Sort headers.
5359         * amd64-fbsd-tdep.c: Sort headers.
5360         * amd64-fbsd-nat.c: Sort headers.
5361         * amd64-dicos-tdep.c: Sort headers.
5362         * amd64-darwin-tdep.c: Sort headers.
5363         * amd64-bsd-nat.c: Sort headers.
5364         * alpha-tdep.c: Sort headers.
5365         * alpha-obsd-tdep.c: Sort headers.
5366         * alpha-nbsd-tdep.c: Sort headers.
5367         * alpha-mdebug-tdep.c: Sort headers.
5368         * alpha-linux-tdep.c: Sort headers.
5369         * alpha-linux-nat.c: Sort headers.
5370         * alpha-bsd-tdep.c: Sort headers.
5371         * alpha-bsd-nat.c: Sort headers.
5372         * aix-thread.c: Sort headers.
5373         * agent.c: Sort headers.
5374         * addrmap.c: Sort headers.
5375         * ada-varobj.c: Sort headers.
5376         * ada-valprint.c: Sort headers.
5377         * ada-typeprint.c: Sort headers.
5378         * ada-tasks.c: Sort headers.
5379         * ada-lang.c: Sort headers.
5380         * aarch64-tdep.c: Sort headers.
5381         * aarch64-ravenscar-thread.c: Sort headers.
5382         * aarch64-newlib-tdep.c: Sort headers.
5383         * aarch64-linux-tdep.c: Sort headers.
5384         * aarch64-linux-nat.c: Sort headers.
5385         * aarch64-fbsd-tdep.c: Sort headers.
5386         * aarch64-fbsd-nat.c: Sort headers.
5387         * aarch32-linux-nat.c: Sort headers.
5388
5389 2019-04-04  Tom Tromey  <tom@tromey.com>
5390
5391         * varobj.c (varobj_create): Update.
5392         * rust-exp.y (struct rust_parser) <update_innermost_block,
5393         lookup_symbol>: New methods.
5394         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5395         Rename.
5396         (rust_parser::rust_lookup_type)
5397         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5398         * printcmd.c (display_command, do_one_display): Update.
5399         * parser-defs.h (struct parser_state) <parser_state>: Add
5400         "tracker" parameter.
5401         (block_tracker): New member.
5402         (class innermost_block_tracker) <innermost_block_tracker>: Add
5403         "types" parameter.
5404         <reset>: Remove method.
5405         (innermost_block): Don't declare.
5406         (null_post_parser): Update.
5407         * parse.c (innermost_block): Remove global.
5408         (write_dollar_variable): Update.
5409         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5410         Remove "tracker_types" parameter.
5411         (parse_expression): Add "tracker" parameter.
5412         (parse_expression_for_completion): Update.
5413         (null_post_parser): Add "tracker" parameter.
5414         * p-exp.y: Update rules.
5415         * m2-exp.y: Update rules.
5416         * language.h (struct language_defn) <la_post_parser>: Add
5417         "tracker" parameter.
5418         * go-exp.y: Update rules.
5419         * f-exp.y: Update rules.
5420         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5421         parameter.
5422         * d-exp.y: Update rules.
5423         * c-exp.y: Update rules.
5424         * breakpoint.c (set_breakpoint_condition): Create an
5425         innermost_block_tracker.
5426         (watch_command_1): Likewise.
5427         * ada-lang.c (resolve): Add "tracker" parameter.
5428         (resolve_subexp): Likewise.
5429         * ada-exp.y (write_var_from_sym): Update.
5430
5431 2019-04-04  Tom Tromey  <tom@tromey.com>
5432
5433         * type-stack.h: New file.
5434         * type-stack.c: New file.
5435         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5436         type-stack.h.
5437         (insert_into_type_stack, insert_type, push_type, push_type_int)
5438         (insert_type_address_space, pop_type, pop_type_int)
5439         (pop_typelist, pop_type_stack, append_type_stack)
5440         (push_type_stack, get_type_stack, push_typelist)
5441         (follow_type_instance_flags, follow_types): Don't declare.
5442         * parse.c (type_stack): Remove global.
5443         (parse_exp_in_context): Update.
5444         (insert_into_type_stack, insert_type, push_type, push_type_int)
5445         (insert_type_address_space, pop_type, pop_type_int)
5446         (pop_typelist, pop_type_stack, append_type_stack)
5447         (push_type_stack, get_type_stack, push_typelist)
5448         (follow_type_instance_flags, follow_types): Remove (moved to
5449         type-stack.c).
5450         * f-exp.y (type_stack): New global.
5451         Update rules.
5452         (push_kind_type, f_parse): Update.
5453         * d-exp.y (type_stack): New global.
5454         Update rules.
5455         (d_parse): Update.
5456         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5457         Update rules.
5458         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5459         (HFILES_NO_SRCDIR): Add type-stack.h.
5460
5461 2019-04-04  Tom Tromey  <tom@tromey.com>
5462
5463         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5464         (rust_parser::convert_ast_to_expression, rust_parse)
5465         (rust_lex_test_completion, rust_lex_tests): Update.
5466         * parser-defs.h (struct expr_completion_state): New.
5467         (struct parser_state) <parser_state>: Add completion parameter.
5468         <mark_struct_expression, mark_completion_tag>: New methods.
5469         <parse_completion, m_completion_state>: New members.
5470         (prefixify_expression, null_post_parser): Update.
5471         (mark_struct_expression, mark_completion_tag): Don't declare.
5472         * parse.c (parse_completion, expout_last_struct)
5473         (expout_tag_completion_type, expout_completion_name): Remove
5474         globals.
5475         (parser_state::mark_struct_expression)
5476         (parser_state::mark_completion_tag): Now methods.
5477         (prefixify_expression): Add last_struct parameter.
5478         (prefixify_subexp): Likewise.
5479         (parse_exp_1): Update.
5480         (parse_exp_in_context): Add cstate parameter.  Update.
5481         (parse_expression_for_completion): Create an
5482         expr_completion_state.
5483         (null_post_parser): Add "completion" parameter.
5484         * p-exp.y: Update rules.
5485         (yylex): Update.
5486         * language.h (struct language_defn) <la_post_parser>: Add
5487         "completing" parameter.
5488         * go-exp.y: Update rules.
5489         (lex_one_token): Update.
5490         * expression.h (parse_completion): Don't declare.
5491         * d-exp.y: Update rules.
5492         (lex_one_token): Update rules.
5493         * c-exp.y: Update rules.
5494         (lex_one_token): Update.
5495         * ada-lang.c (resolve): Add "parse_completion" parameter.
5496         (resolve_subexp): Likewise.
5497         (ada_resolve_function): Likewise.
5498
5499 2019-04-04  Tom Tromey  <tom@tromey.com>
5500
5501         * parser-defs.h (struct parser_state) <start_arglist,
5502         end_arglist>: New methods.
5503         <arglist_len, m_funcall_chain>: New members.
5504         (arglist_len, start_arglist, end_arglist): Don't declare.
5505         * parse.c (arglist_len, funcall_chain): Remove global.
5506         (start_arglist, end_arglist): Remove functions.
5507         (parse_exp_in_context): Update.
5508         * p-exp.y: Update rules.
5509         * m2-exp.y: Update rules.
5510         * go-exp.y: Update rules.
5511         * f-exp.y: Update rules.
5512         * d-exp.y: Update rules.
5513         * c-exp.y: Update rules.
5514
5515 2019-04-04  Tom Tromey  <tom@tromey.com>
5516
5517         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5518         lex_operator, push_back>: New methods.
5519         Update all rules.
5520         (rust_parser::lex_hex, lex_escape): Rename and update.
5521         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5522         (rust_parser::lex_operator): Rename and update.
5523         (rust_parser::lex_number, rustyylex, rustyyerror)
5524         (rust_lex_test_init, rust_lex_test_sequence)
5525         (rust_lex_test_push_back, rust_lex_tests): Update.
5526         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5527         parameter.
5528         <lexptr, prev_lexptr>: New members.
5529         (lexptr, prev_lexptr): Don't declare.
5530         * parse.c (lexptr, prev_lexptr): Remove globals.
5531         (parse_exp_in_context): Update.
5532         * p-exp.y (yylex, yyerror): Update.
5533         * m2-exp.y (parse_number, yylex, yyerror): Update.
5534         * go-exp.y (lex_one_token, yyerror): Update.
5535         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5536         * d-exp.y (lex_one_token, yyerror): Update.
5537         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5538         (lex_one_token, yyerror): Update.
5539         * ada-lex.l (YY_INPUT): Update.
5540         (rewind_to_char): Update.
5541         * ada-exp.y (yyerror): Update.
5542
5543 2019-04-04  Tom Tromey  <tom@tromey.com>
5544
5545         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5546         * parser-defs.h (struct parser_state) <parser_state>: Add new
5547         parameter.
5548         <comma_terminates>: New member.
5549         (comma_terminates): Don't declare global.
5550         * parse.c (comma_terminates): Remove global.
5551         (parse_exp_in_context): Update.
5552         * p-exp.y (yylex): Update.
5553         * m2-exp.y (yylex): Update.
5554         * go-exp.y (lex_one_token): Update.
5555         * f-exp.y (yylex): Update.
5556         * d-exp.y (lex_one_token): Update.
5557         * c-exp.y (lex_one_token): Update.
5558         * ada-lex.l: Update.
5559
5560 2019-04-04  Tom Tromey  <tom@tromey.com>
5561
5562         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5563         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5564         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5565         * parser-defs.h (paren_depth): Don't declare.
5566         * parse.c (paren_depth): Remove global.
5567         (parse_exp_in_context): Update.
5568         * p-exp.y (paren_depth): New global.
5569         (pascal_parse): Initialize it.
5570         * m2-exp.y (paren_depth): New global.
5571         (m2_parse): Initialize it.
5572         * go-exp.y (paren_depth): New global.
5573         (go_parse): Initialize it.
5574         * f-exp.y (paren_depth): New global.
5575         (f_parse): Initialize it.
5576         * d-exp.y (paren_depth): New global.
5577         (d_parse): Initialize it.
5578         * c-exp.y (paren_depth): New global.
5579         (c_parse): Initialize it.
5580         * ada-lex.l (paren_depth): New global.
5581         (lexer_init): Initialize it.
5582
5583 2019-04-04  Tom Tromey  <tom@tromey.com>
5584
5585         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5586         (rust_parser::convert_ast_to_type)
5587         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5588         * parser-defs.h (struct parser_state) <parser_state>: Add
5589         parameters.  Initialize new members.
5590         <expression_context_block, expression_context_pc>: New members.
5591         * parse.c (expression_context_block, expression_context_pc):
5592         Remove globals.
5593         (parse_exp_in_context): Update.
5594         * p-exp.y: Update all rules.
5595         (yylex): Update.
5596         * m2-exp.y: Update all rules.
5597         (yylex): Update.
5598         * go-exp.y (yylex): Update.
5599         * f-exp.y (yylex): Update.
5600         * d-exp.y: Update all rules.
5601         (yylex): Update.
5602         * c-exp.y: Update all rules.
5603         (lex_one_token, classify_name, yylex, c_parse): Update.
5604         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5605
5606 2019-04-04  Tom Tromey  <tom@tromey.com>
5607
5608         * gdbarch.h, gdbarch.c: Rebuild.
5609         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5610         * stap-probe.h:
5611         (struct stap_parse_info): Replace "parser_state" with
5612         "expr_builder".
5613         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5614         (parser_state): New class.
5615         * parse.c (expr_builder): Rename.
5616         (expr_builder::release): Rename.
5617         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5618         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5619         (write_exp_elt_longcst, write_exp_elt_floatcst)
5620         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5621         (write_exp_string_vector, write_exp_bitstring)
5622         (write_exp_msymbol, mark_struct_expression)
5623         (write_dollar_variable)
5624         (insert_type_address_space, increase_expout_size): Replace
5625         "parser_state" with "expr_builder".
5626         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5627         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5628         "parser_state" with "expr_builder".
5629
5630 2019-04-04  Tom Tromey  <tom@tromey.com>
5631
5632         * rust-exp.y: Replace "parse_language" with method call.
5633         * p-exp.y:
5634         (yylex): Replace "parse_language" with method call.
5635         * m2-exp.y:
5636         (yylex): Replace "parse_language" with method call.
5637         * go-exp.y (classify_name): Replace "parse_language" with method
5638         call.
5639         * f-exp.y (yylex): Replace "parse_language" with method call.
5640         * d-exp.y (lex_one_token): Replace "parse_language" with method
5641         call.
5642         * c-exp.y:
5643         (lex_one_token, classify_name, yylex): Replace "parse_language"
5644         with method call.
5645         * ada-exp.y (find_primitive_type, type_char)
5646         (type_system_address): Replace "parse_language" with method call.
5647
5648 2019-04-04  Tom Tromey  <tom@tromey.com>
5649
5650         * rust-exp.y: Replace "parse_gdbarch" with method call.
5651         * parse.c (write_dollar_variable, insert_type_address_space):
5652         Replace "parse_gdbarch" with method call.
5653         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5654         call.
5655         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5656         call.
5657         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5658         "parse_gdbarch" with method call.
5659         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5660         with method call.
5661         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5662         "parse_gdbarch" with method call.
5663         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5664         "parse_gdbarch" with method call.
5665         * c-exp.y (parse_type, parse_number, classify_name): Replace
5666         "parse_gdbarch" with method call.
5667         * ada-lex.l: Replace "parse_gdbarch" with method call.
5668         * ada-exp.y (parse_type, find_primitive_type, type_char)
5669         (type_system_address): Replace "parse_gdbarch" with method call.
5670
5671 2019-04-04  Tom Tromey  <tom@tromey.com>
5672
5673         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5674         * stap-probe.c (stap_parse_argument): Update.
5675         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5676         initial_size parameter.
5677         * rust-exp.y (rust_lex_tests): Update.
5678         * parse.c (parser_state): Update.
5679         (parse_exp_in_context): Update.
5680         * parser-defs.h (struct parser_state) <parser_state>: Remove
5681         "initial_size" parameter.
5682
5683 2019-04-04  Tom Tromey  <tom@tromey.com>
5684
5685         * parser-defs.h (increase_expout_size): Don't declare.
5686         * parse.c (increase_expout_size): Now static.
5687
5688 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5689
5690         * gnu-nat.c (gnu_nat_target::wait): Fix
5691         target_waitstatus_to_string call.
5692
5693 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5694
5695         * eval.c (evaluate_subexp_standard): Handle internal functions
5696         during Fortran function call handling.
5697
5698 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5699
5700         * NEWS: Mention new internal functions.
5701         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5702         (read_base_type): Use dwarf2_init_complex_target_type.
5703         * value.c (creal_internal_fn): New function.
5704         (cimag_internal_fn): New function.
5705         (_initialize_values): Register new internal functions.
5706
5707 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5708
5709         * infrun.c (stop_all_threads): If debug_infrun, always
5710         trace the wait status after wait_one, using
5711         target_waitstatus_to_string and target_pid_to_str.
5712         (handle_inferior_event): Replace various trace of
5713         wait status kind by a single trace.
5714         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5715         wait status kind image by target_waitstatus_to_string.
5716         * target/waitstatus.c (target_waitstatus_to_string): Fix
5717         obsolete comment.
5718
5719 2019-04-01  Tom Tromey  <tromey@adacore.com>
5720
5721         PR symtab/23331:
5722         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5723
5724 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5725             Pedro Alves  <palves@redhat.com>
5726
5727         * top.c (quit_force): Call 'finalize_values'.
5728         * value.c (finalize_values): New function.
5729         * value.h (finalize_values): Declare.
5730
5731 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5732
5733         * NEWS: Announce $_gdb_major and $_gdb_minor.
5734
5735         * top.c (init_gdb_version_vars): New function.
5736         (gdb_init): Call init_gdb_version_vars.
5737
5738 2019-03-29  Tom Tromey  <tromey@adacore.com>
5739
5740         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5741         help text.  Remove dead code.
5742
5743 2019-03-29  Keith Seitz  <keiths@redhat.com>
5744
5745         From Siddhesh Poyarekar:
5746         * f-lang.h (f77_get_upperbound): Return LONGEST.
5747         (f77_get_lowerbound): Likewise.
5748         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5749         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5750         print them.
5751         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5752         plongest to format print it.
5753         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5754         (f77_get_upperbound): Likewise.
5755         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5756         LOWER_BOUND to LONGEST.
5757         (f77_create_arrayprint_offset_tbl): Likewise.
5758
5759 2019-03-29  Keith Seitz  <keiths@redhat.com>
5760
5761         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5762         %s/pulongest for TYPE_LENGTH instead of %d in format
5763         strings.
5764         * ada-typerint.c (ada_print_type): Likewise.
5765         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5766         * compile/compile-c-support.c (generate_register_struct): Likewise.
5767         * gdbtypes.c (recursive_dump_type): Likewise.
5768         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5769         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5770         instead of %d in format strings.
5771         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5772         to std::min to ULONGEST.
5773         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5774         instead of %d in format strings.
5775         * tracepoint.c (info_scope_command): Likewise.
5776         * typeprint.c (print_offset_data::update)
5777         (print_offset_data::finish): Likewise.
5778         * xtensa-tdep.c (xtensa_store_return_value)
5779         (xtensa_push_dummy_call): Likewise.
5780
5781 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5782
5783         * windows-nat.c (display_selector): Fixed format specifications
5784         for 64-bit Cygwin.
5785
5786 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5787
5788         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5789
5790 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5791
5792         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5793         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5794         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5795         (nios2_linux_init_abi): Install it.
5796
5797 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5798
5799         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5800
5801 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5802
5803         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5804
5805 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5806             Tom Tromey  <tromey@adacore.com>
5807
5808         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5809
5810 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5811
5812         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5813         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5814         method to compute the bounds of range types. Also print "[evaluated]"
5815         if the bounds' values come from a dynamic evaluation.
5816
5817 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5818
5819         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5820         whitespace when pretty printing is on.
5821
5822 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5823
5824         * ppc-linux-nat.c: Add include.
5825
5826 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5827
5828         * NEWS: Mention AArch64 Pointer Authentication.
5829
5830 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5831
5832         * arm-linux-nat.c: Add include.
5833
5834 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5835
5836         * source-cache.c (source_cache::get_source_lines): Re-read
5837         fullname after calling open_source_file.
5838
5839 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5840
5841         * NEWS: Mention TLS support for FreeBSD.
5842
5843 2019-03-25  Tom Tromey  <tromey@adacore.com>
5844
5845         * minsyms.c (BUNCH_SIZE): Update comment.
5846         (~minimal_symbol_reader): Remove old comment.
5847         (compact_minimal_symbols): Update comment.
5848         (minimal_symbol_reader::install): Remove old comment.  Update
5849         other comments.
5850
5851 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5852
5853         * s390-linux-nat.c: Add include.
5854
5855 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5856
5857         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5858         Call linux_get_hwcap.
5859         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5860         Likewise.
5861         (aarch64_linux_get_hwcap): Remove function.
5862         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5863         declaration.
5864         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5865         linux_get_hwcap.
5866         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5867         * linux-tdep.c (linux_get_hwcap): Add function.
5868         (linux_get_hwcap2): Likewise.
5869         * linux-tdep.h (linux_get_hwcap): Add declaration.
5870         (linux_get_hwcap2): Likewise.
5871         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5872         (ppc_linux_get_hwcap2): Likewise.
5873         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5874         linux_get_hwcap.
5875         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5876         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5877         (ppc_linux_nat_target::read_description): Likewise.
5878         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5879         * s390-linux-nat.c: Likewise.
5880         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5881
5882 2019-03-24  Tom Tromey  <tom@tromey.com>
5883
5884         * ada-lang.c (standard_lookup): Simplify initialization.
5885         (ada_lookup_symbol_nonlocal): Simplify return.
5886         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5887         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5888         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5889         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5890         initialization.
5891         * solib.c (solib_global_lookup): Simplify.
5892         * symtab.c (null_block_symbol): Remove.
5893         (symbol_cache_lookup): Simplify returns.
5894         (lookup_language_this): Simplify returns.
5895         (lookup_symbol_aux): Simplify return.
5896         (lookup_local_symbol): Simplify returns.
5897         (lookup_global_symbol_from_objfile): Simplify return.
5898         (lookup_symbol_in_objfile_symtabs)
5899         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5900         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5901         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5902         * cp-namespace.c (cp_lookup_bare_symbol)
5903         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5904         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5905         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5906         (cp_lookup_symbol_via_imports): Simplify initialization.
5907         (find_symbol_in_baseclass): Likewise.
5908         * symtab.h (null_block_symbol): Remove.
5909         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5910         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5911         (d_lookup_symbol_module): Likewise.
5912         (find_symbol_in_baseclass): Simplify initialization.
5913
5914 2019-03-24  Tom Tromey  <tom@tromey.com>
5915
5916         * expression.h: Don't include symtab.h.
5917         (struct block): Forward declare.
5918
5919 2019-03-24  Tom Tromey  <tom@tromey.com>
5920
5921         * c-exp.y (typebase): Remove casts.
5922         * gdbtypes.c (lookup_unsigned_typename, )
5923         (lookup_signed_typename): Remove cast.
5924         * eval.c (parse_to_comma_and_eval): Remove cast.
5925         * parse.c (write_dollar_variable): Remove cast.
5926         * block.h (struct block) <superblock>: Now const.
5927         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5928         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5929         (map_block): Make "block" const.
5930         * symfile.h (struct quick_symbol_functions)
5931         <map_matching_symbols>: Constify block argument to "callback".
5932         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5933         const.
5934         (find_pc_sect_compunit_symtab): Make "b" const.
5935         (find_symbol_at_address): Likewise.
5936         (search_symbols): Likewise.
5937         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5938         (dw2_debug_names_lookup_symbol): Likewise.
5939         (dw2_map_matching_symbols): Update.
5940         * p-valprint.c (pascal_val_print): Remove "block".
5941         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5942         (aux_add_nonlocal_symbols): Make "block" const.
5943         (resolve_subexp): Remove cast.
5944         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5945         const.
5946         (iterate_over_file_blocks): Likewise.
5947         * f-exp.y (%union) <bval>: Remove.
5948         * coffread.c (patch_opaque_types): Make "b" const.
5949         * spu-tdep.c (spu_catch_start): Make "block" const.
5950         * c-valprint.c (print_unpacked_pointer): Remove "block".
5951         * symmisc.c (dump_symtab_1): Make "b" const.
5952         (block_depth): Make "block" const.
5953         * d-exp.y (%union) <bval>: Remove.
5954         * cp-support.h (cp_lookup_rtti_type): Update.
5955         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5956         * psymtab.c (psym_lookup_symbol): Make "block" const.
5957         (maintenance_check_psymtabs): Make "b" const.
5958         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5959         (enumerate_locals, enumerate_args): Update.
5960         * python/py-symtab.c (stpy_global_block): Make "block" const.
5961         (stpy_static_block): Likewise.
5962         * inline-frame.c (block_starting_point_at): Make "new_block"
5963         const.
5964         * block.c (find_block_in_blockvector): Make return type const.
5965         (blockvector_for_pc_sect): Make "b" const.
5966         (find_block_in_blockvector): Make "b" const.
5967
5968 2019-03-23  Tom Tromey  <tom@tromey.com>
5969
5970         * varobj.c (varobj_create): Update.
5971         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5972         * printcmd.c (display_command, do_one_display): Don't reset
5973         innermost_block.
5974         * parser-defs.h (enum innermost_block_tracker_type): Move to
5975         expression.h.
5976         (innermost_block): Update comment.
5977         * parse.c (parse_exp_1): Add tracker_types parameter.
5978         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5979         tracker_types parameter.  Reset innermost_block.
5980         (parse_exp_in_context): Remove.
5981         (parse_expression_for_completion): Update.
5982         * objfiles.c (~objfile): Don't reset expression_context_block or
5983         innermost_block.
5984         * expression.h (enum innermost_block_tracker_type): Move from
5985         parser-defs.h.
5986         (parse_exp_1): Add tracker_types parameter.
5987         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5988         reset innermost_block.
5989
5990 2019-03-23  Tom Tromey  <tom@tromey.com>
5991
5992         * objfiles.h: Include bcache.h.
5993
5994 2019-03-23  Tom Tromey  <tom@tromey.com>
5995
5996         * linespec.c (get_current_search_block): Use
5997         scoped_restore_current_language.
5998         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5999
6000 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6001             Jiong Wang  <jiong.wang@arm.com>
6002
6003         * aarch64-linux-tdep.c
6004         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6005         section.
6006         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6007
6008 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6009             Jiong Wang  <jiong.wang@arm.com>
6010
6011         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6012         instructions.
6013         (aarch64_analyze_prologue_test): Add PACIASP test.
6014         (aarch64_prologue_prev_register): Unmask PC value.
6015
6016 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6017             Jiong Wang  <jiong.wang@arm.com>
6018
6019         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6020         (aarch64_dwarf2_prev_register): Unmask PC value.
6021         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6022         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6023         DW_CFA_AARCH64_negate_ra_state.
6024         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6025
6026 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6027             Jiong Wang  <jiong.wang@arm.com>
6028
6029         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6030         registers.
6031         (aarch64_pseudo_register_name): Likewise.
6032         (aarch64_pseudo_register_type): Likewise.
6033         (aarch64_pseudo_register_reggroup_p): Likewise.
6034         (aarch64_gdbarch_init): Add pauth registers.
6035         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6036         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6037         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6038         (struct gdbarch_tdep): Add regnum for ra_state.
6039
6040 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6041             Jiong Wang  <jiong.wang@arm.com>
6042
6043         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6044
6045 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6046             Jiong Wang  <jiong.wang@arm.com>
6047
6048         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6049         function.
6050         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6051         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6052         (aarch64_gdbarch_init): Add puth registers.
6053         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6054         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6055         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6056
6057 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6058             Jiong Wang  <jiong.wang@arm.com>
6059
6060         * aarch64-linux-nat.c
6061         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6062         * aarch64-linux-tdep.c
6063         (aarch64_linux_core_read_description): Likewise.
6064         (aarch64_linux_get_hwcap): New function.
6065         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6066         (aarch64_linux_get_hwcap): New declaration.
6067
6068 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6069             Jiong Wang  <jiong.wang@arm.com>
6070
6071         * aarch64-linux-nat.c
6072         (aarch64_linux_nat_target::read_description): Add pauth param.
6073         * aarch64-linux-tdep.c
6074         (aarch64_linux_core_read_description): Likewise.
6075         * aarch64-tdep.c (struct target_desc): Add in pauth.
6076         (aarch64_read_description): Add pauth param.
6077         (aarch64_gdbarch_init): Likewise.
6078         * aarch64-tdep.h (aarch64_read_description): Likewise.
6079         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6080         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6081         * features/Makefile: Add new files.
6082         * features/aarch64-pauth.c: New file.
6083         * features/aarch64-pauth.xml: New file.
6084
6085 2019-03-20  Tom Tromey  <tromey@adacore.com>
6086
6087         * infrun.c (handle_inferior_event): Rename from
6088         handle_inferior_event_1.  Create a scoped_value_mark.
6089         (handle_inferior_event): Remove.
6090
6091 2019-03-19  Tom Tromey  <tromey@adacore.com>
6092
6093         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6094         * infrun.h (print_stop_event): Add "displays" parameter.
6095         * infrun.c (print_stop_event): Add "displays" parameter.
6096
6097 2019-03-19  Pedro Alves  <palves@redhat.com>
6098
6099         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6100         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6101         to -1.  Fix TABs vs spaces.
6102         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6103         * tui/tui-out.h (tui_ui_out) Add intro comments.
6104         <m_line, m_start_of_line>: In-class initialize, and add describing
6105         comment.
6106
6107 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6108
6109         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6110         variable names.
6111         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6112
6113 2019-03-18  Pedro Alves  <palves@redhat.com>
6114             Eli Zaretskii <eliz@gnu.org>
6115
6116         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6117         m_line and m_start_of_line.
6118
6119 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6120
6121         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6122         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6123         it returns a newline.  This fixes a regression in TU mode, whereby
6124         the next line is output on the same screen line as the user input.
6125
6126 2019-03-18  Tom Tromey  <tromey@adacore.com>
6127
6128         * minsyms.c (minimal_symbol_reader::install): Remove call to
6129         obstack_blank.
6130
6131 2019-03-18  Pedro Alves  <palves@redhat.com>
6132
6133         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6134         New globals.
6135         (apply_style): New, factored out from ...
6136         (apply_ansi_escape): ... this.  Handle reverse video mode.
6137         (tui_set_reverse_mode): New function.
6138         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6139         * tui/tui-winsource.c (tui_show_source_line): Use
6140         tui_set_reverse_mode instead of setting A_STANDOUT.
6141         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6142         New setter methods.
6143
6144 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6145
6146         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6147         Handle tabs.
6148
6149 2019-03-18  Tom Tromey  <tromey@adacore.com>
6150
6151         * ada-lang.c (empty_array): Add "high" parameter.
6152         (ada_evaluate_subexp): Update.
6153
6154 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6155
6156         * unittests/string_view-selftests.c: Define
6157         _initialize_string_view_selftests unconditionally.
6158
6159 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6160
6161         PR gdb/24350
6162         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6163
6164 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6165
6166         PR gdb/24351
6167         * windows-nat.c (display_selector): Fix format specifiers.
6168
6169 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6170
6171         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6172         tui_refill_source_window instead of tui_refresh_win, to update the
6173         current execution line.  This fixes redisplay of the current line
6174         when stepping through the code with "next" or "step".
6175
6176 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6177
6178         * source-cache.c (source_cache::get_source_lines): Call
6179         find_source_lines to initialize s->nlines.  This fixes vertical
6180         scrolling of TUI source window when the DOWN arrow is pressed.
6181
6182 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6183
6184         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6185         linux-thread-db.c (_initialize_thread_db): Likewise.
6186
6187 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6188
6189         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6190         wclrtoeol in tui_show_source_line".  This reverts changes made in
6191         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6192
6193 2019-03-15  Tom Tromey  <tom@tromey.com>
6194
6195         * symtab.h (struct minimal_symbol): Derive from
6196         general_symbol_info.
6197         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6198         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6199         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6200         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6201         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6202         (MSYMBOL_SEARCH_NAME): Update.
6203         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6204         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6205         * minsyms.c (minimal_symbol_reader::record_full): Update.
6206
6207 2019-03-15  Tom Tromey  <tom@tromey.com>
6208
6209         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6210
6211 2019-03-15  Tom Tromey  <tom@tromey.com>
6212
6213         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6214         unique_xmalloc_ptr.
6215         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6216         Update.
6217         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6218         (build_minimal_symbol_hash_tables)
6219         (minimal_symbol_reader::install): Update.
6220
6221 2019-03-15  Tom Tromey  <tom@tromey.com>
6222
6223         * symtab.c (create_demangled_names_hash): Update.
6224         (symbol_set_names): Update.
6225         * objfiles.h (struct objfile_per_bfd_storage)
6226         <demangled_names_hash>: Now an htab_up.
6227         * objfiles.c (objfile_per_bfd_storage): Simplify.
6228
6229 2019-03-15  Tom Tromey  <tom@tromey.com>
6230
6231         * objfiles.h (struct objfile_per_bfd_storage): Declare
6232         destructor.
6233         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6234         New.
6235         (get_objfile_bfd_data): Use new.  Don't initialize
6236         language_of_main.
6237         (free_objfile_per_bfd_storage): Remove.
6238         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6239
6240 2019-03-15  Tom Tromey  <tom@tromey.com>
6241
6242         * symfile.c (reread_symbols): Update.
6243         * objfiles.c (objfile::objfile): Update.
6244         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6245         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6246         comment.
6247         (minimal_symbol_reader::install): Update.
6248         (terminate_minimal_symbol_table): Remove.
6249         * jit.c (jit_object_close_impl): Update.
6250
6251 2019-03-15  Tom Tromey  <tom@tromey.com>
6252
6253         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6254         initializations.
6255
6256 2019-03-15  Tom Tromey  <tom@tromey.com>
6257
6258         * objfiles.h (struct objfile_per_bfd_storage)
6259         <demangled_hash_languages>: Now a bitset.
6260         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6261         (lookup_minimal_symbol): Update.
6262
6263 2019-03-15  Tom Tromey  <tom@tromey.com>
6264
6265         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6266         Don't return the symbol.
6267         * coffread.c (record_minimal_symbol): Use record_full.
6268
6269 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6270
6271         The MS-Windows port of ncurses fails to switch to a color pair if
6272         one or both of the colors are the implicit default colors.  This
6273         change records the default colors when TUI is initialized, and
6274         then specifies them explicitly when a color pair uses the default
6275         colors.  This allows color styling in TUI mode on MS-Windows.
6276
6277         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6278         ncurses_norm_attr.
6279         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6280         colors in ncurses_norm_attr.
6281         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6282         "none", replace it with the default color recorded in
6283         ncurses_norm_attr.
6284
6285 2019-03-14  Tom Tromey  <tromey@adacore.com>
6286
6287         * source-cache.h (class source_cache) <get_source_lines>: Return
6288         std::string.
6289         * source-cache.c (source_cache::extract_lines): Handle case where
6290         first_pos==npos.  Return std::string.
6291         (source_cache::get_source_lines): Update.
6292
6293 2019-03-14  Tom Tromey  <tromey@adacore.com>
6294
6295         * NEWS: Add item for "style sources" commands.
6296         * source-cache.c (source_cache::get_source_lines): Check
6297         source_styling.
6298         * cli/cli-style.c (source_styling): New global.
6299         (_initialize_cli_style): Add "style sources" commands.
6300         (show_style_sources): New function.
6301         * cli/cli-style.h (source_styling): Declare.
6302
6303 2019-03-14  Pedro Alves  <palves@redhat.com>
6304             Tom Tromey  <tromey@adacore.com>
6305
6306         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6307         * tui/tui-winsource.c (tui_refill_source_window): New function,
6308         from...
6309         (tui_horizontal_source_scroll): ... here.  Move some logic.
6310         * cli/cli-style.c (set_style_enabled): Notify new observable.
6311         * tui/tui-hooks.c (tui_redisplay_source): New function.
6312         (tui_attach_detach_observers): Attach or detach
6313         tui_redisplay_source.
6314         * observable.h (source_styling_changed): New observable.
6315         * observable.c: Define source_styling_changed observable.
6316
6317 2019-03-13  Tom Tromey  <tromey@adacore.com>
6318
6319         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6320         (i386_gnu_nat_target::store_registers): Update.
6321         * target-debug.h (target_debug_print_std_string): New macro.
6322         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6323         * windows-tdep.c (display_one_tib): Update.
6324         * tui/tui-stack.c (tui_make_status_line): Update.
6325         * top.c (print_inferior_quit_action): Update.
6326         * thread.c (thr_try_catch_cmd): Update.
6327         (add_thread_with_info): Update.
6328         (thread_target_id_str): Update.
6329         (thr_try_catch_cmd): Update.
6330         (thread_command): Update.
6331         (thread_find_command): Update.
6332         * record-btrace.c (record_btrace_target::info_record)
6333         (record_btrace_resume_thread, record_btrace_target::resume)
6334         (record_btrace_cancel_resume, record_btrace_step_thread)
6335         (record_btrace_target::wait, record_btrace_target::wait)
6336         (record_btrace_target::wait, record_btrace_target::stop): Update.
6337         * progspace.c (print_program_space): Update.
6338         * process-stratum-target.c
6339         (process_stratum_target::thread_address_space): Update.
6340         * linux-fork.c (linux_fork_mourn_inferior)
6341         (detach_checkpoint_command, info_checkpoints_command)
6342         (linux_fork_context): Update.
6343         (linux_fork_detach): Update.
6344         (class scoped_switch_fork_info): Update.
6345         (delete_checkpoint_command): Update.
6346         * infrun.c (follow_fork_inferior): Update.
6347         (follow_fork_inferior): Update.
6348         (proceed_after_vfork_done): Update.
6349         (handle_vfork_child_exec_or_exit): Update.
6350         (follow_exec): Update.
6351         (displaced_step_prepare_throw): Update.
6352         (displaced_step_restore): Update.
6353         (start_step_over): Update.
6354         (resume_1): Update.
6355         (clear_proceed_status_thread): Update.
6356         (proceed): Update.
6357         (print_target_wait_results): Update.
6358         (do_target_wait): Update.
6359         (context_switch): Update.
6360         (stop_all_threads): Update.
6361         (restart_threads): Update.
6362         (finish_step_over): Update.
6363         (handle_signal_stop): Update.
6364         (switch_back_to_stepped_thread): Update.
6365         (keep_going_pass_signal): Update.
6366         (print_exited_reason): Update.
6367         (normal_stop): Update.
6368         * inferior.c (inferior_pid_to_str): Change return type.
6369         (print_selected_inferior): Update.
6370         (add_inferior): Update.
6371         (detach_inferior): Update.
6372         * dummy-frame.c (fprint_dummy_frames): Update.
6373         * dcache.c (dcache_info_1): Update.
6374         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6375         (btrace_fetch, btrace_clear): Update.
6376         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6377         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6378         type.
6379         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6380         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6381         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6382         * gdbarch.c, gdbarch.h: Rebuild.
6383         * gdbarch.sh (core_pid_to_str): Change return type.
6384         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6385         return type.
6386         (windows_nat_target::pid_to_str): Change return type.
6387         (windows_delete_thread): Update.
6388         (windows_nat_target::attach): Update.
6389         (windows_nat_target::files_info): Update.
6390         * target-delegates.c: Rebuild.
6391         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6392         return type.
6393         (sol_thread_target::pid_to_str): Change return type.
6394         * remote.c (class remote_target) <pid_to_str>: Change return
6395         type.
6396         (remote_target::pid_to_str): Change return type.
6397         (extended_remote_target::attach, remote_target::remote_stop_ns)
6398         (remote_target::remote_notif_remove_queued_reply)
6399         (remote_target::push_stop_reply, remote_target::disable_btrace):
6400         Update.
6401         (extended_remote_target::attach): Update.
6402         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6403         type.
6404         (gdbsim_target::pid_to_str): Change return type.
6405         * ravenscar-thread.c (struct ravenscar_thread_target)
6406         <pid_to_str>: Change return type.
6407         (ravenscar_thread_target::pid_to_str): Change return type.
6408         * procfs.c (class procfs_target) <pid_to_str>: Change return
6409         type.
6410         (procfs_target::pid_to_str): Change return type.
6411         (procfs_target::attach): Update.
6412         (procfs_target::detach): Update.
6413         (procfs_target::fetch_registers): Update.
6414         (procfs_target::store_registers): Update.
6415         (procfs_target::wait): Update.
6416         (procfs_target::files_info): Update.
6417         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6418         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6419         return type.
6420         (nto_procfs_target::pid_to_str): Change return type.
6421         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6422         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6423         return type.
6424         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6425         (exit_lwp): Update.
6426         (attach_proc_task_lwp_callback, get_detach_signal)
6427         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6428         (linux_nat_target::resume, wait_lwp, stop_callback)
6429         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6430         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6431         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6432         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6433         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6434         type.
6435         (inf_ptrace_target::attach): Update.
6436         (inf_ptrace_target::files_info): Update.
6437         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6438         type.
6439         (go32_nat_target::pid_to_str): Change return type.
6440         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6441         (gnu_nat_target::wait): Update.
6442         (gnu_nat_target::wait): Update.
6443         (gnu_nat_target::resume): Update.
6444         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6445         (fbsd_nat_target::wait): Update.
6446         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6447         type.
6448         (darwin_nat_target::attach): Update.
6449         * corelow.c (class core_target) <pid_to_str>: Change return type.
6450         (core_target::pid_to_str): Change return type.
6451         * target.c (normal_pid_to_str): Change return type.
6452         (default_pid_to_str): Likewise.
6453         (target_pid_to_str): Change return type.
6454         (target_translate_tls_address): Update.
6455         (target_announce_detach): Update.
6456         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6457         return type.
6458         (bsd_uthread_target::pid_to_str): Change return type.
6459         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6460         type.
6461         (bsd_kvm_target::pid_to_str): Change return type.
6462         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6463         return type.
6464         (aix_thread_target::pid_to_str): Change return type.
6465         * target.h (struct target_ops) <pid_to_str>: Change return type.
6466         (target_pid_to_str, normal_pid_to_str): Likewise.
6467         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6468         type.
6469         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6470         type.
6471         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6472         return type.
6473         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6474         type.
6475         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6476         type.
6477         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6478         return type.
6479
6480 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6481
6482         * NEWS: Mention that the new default MI version is 3.  Mention
6483         changes to the output of commands and events that deal with
6484         multi-location breakpoints.
6485         * breakpoint.c: Include "mi/mi-out.h".
6486         (print_one_breakpoint): Change output syntax if using MI version
6487         >= 3.
6488         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6489         New.
6490         (mi_multi_location_breakpoint_output_fixed): New.
6491         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6492         (mi_cmd_fix_multi_location_breakpoint_output): New.
6493         (mi_multi_location_breakpoint_output_fixed): New.
6494         * mi/mi-cmds.c (mi_cmds): Register command
6495         -fix-multi-location-breakpoint-output.
6496         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6497         interpreter "mi".
6498
6499 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6500
6501         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6502         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6503         instantiate mi_ui_out based on interpreter name.
6504         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6505         * mi/mi-main.c (mi_load_progress): Likewise.
6506
6507 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6508
6509         * NEWS: Combine separate "New targets" sections for 8.3.
6510
6511 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6512
6513         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6514         (ppcfbsd_init_abi): Install gdbarch
6515         "fetch_tls_load_module_address" and "get_thread_local_address"
6516         methods.
6517
6518 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6519
6520         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6521         (riscv_fbsd_init_abi): Install gdbarch
6522         "fetch_tls_load_module_address" and "get_thread_local_address"
6523         methods.
6524
6525 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6526
6527         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6528         (i386fbsd_init_abi): Install gdbarch
6529         "fetch_tls_load_module_address" and "get_thread_local_address"
6530         methods.
6531
6532 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6533
6534         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6535         (amd64fbsd_init_abi): Install gdbarch
6536         "fetch_tls_load_module_address" and "get_thread_local_address"
6537         methods.
6538
6539 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6540
6541         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6542         (struct fbsd_pspace_data): New type.
6543         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6544         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6545         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6546         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6547         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6548
6549 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6550
6551         * gdbtypes.c (lookup_struct_elt): New function.
6552         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6553         * gdbtypes.h (struct struct_elt): New type.
6554         (lookup_struct_elt): New prototype.
6555
6556 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6557
6558         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6559         remove disabled code block.
6560
6561 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6562
6563         * gdbarch.sh (get_thread_local_address): New method.
6564         * gdbarch.h, gdbarch.c: Regenerate.
6565         * target.c (target_translate_tls_address): Use
6566         gdbarch_get_thread_local_address if present instead of
6567         target::get_thread_local_address.
6568
6569 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6570
6571         * target.h (target::get_thread_local_address): Update comment.
6572
6573 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6574
6575         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6576         objfile->separate_debug_objfile_backlink if not NULL.
6577
6578 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6579
6580         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6581         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6582         (amd64bsd_store_inferior_registers): Likewise.
6583         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6584         Enable segment base registers.
6585         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6586         PT_GETFSBASE and PT_GETGSBASE.
6587         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6588         PT_SETGSBASE.
6589         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6590         segment base registers.
6591         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6592
6593 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6594
6595         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6596         Update calls to i386_target_description to add 'segments'
6597         parameter.
6598         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6599         add segment base registers.
6600         * arch/i386.c (i386_create_target_description): Add 'segments'
6601         parameter to enable segment base registers.
6602         * arch/i386.h (i386_create_target_description): Likewise.
6603         * features/i386/32bit-segments.xml: New file.
6604         * features/i386/32bit-segments.c: Generate.
6605         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6606         call to i386_target_description to add 'segments' parameter.
6607         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6608         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6609         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6610         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6611         if feature is present.
6612         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6613         Add 'segments' parameter to call to i386_target_description.
6614         (i386_target_description): Add 'segments' parameter to enable
6615         segment base registers.
6616         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6617         to call to i386_target_description.
6618         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6619         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6620         Define I386_NUM_REGS.
6621         (i386_target_description): Add 'segments' parameter to enable
6622         segment base registers.
6623
6624 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6625
6626         PR/24325
6627         * source-cache.c: #undef open and close, to avoid unresolved
6628         externals during linking.
6629
6630 2019-03-12  Tom Tromey  <tromey@adacore.com>
6631
6632         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6633         const.  Add initializers.
6634         (_initialize_remote): Don't initialize ptid globals.
6635
6636 2019-03-12  Pedro Alves  <palves@redhat.com>
6637
6638         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6639
6640 2019-03-12  Pedro Alves  <palves@redhat.com>
6641
6642         * cp-name-parser.y (main): Remove unused 'len' variable.
6643
6644 2019-03-12  Tom Tromey  <tromey@adacore.com>
6645
6646         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6647         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6648
6649 2019-03-12  Tom Tromey  <tromey@adacore.com>
6650
6651         * linux-nat.c (iterate_over_lwps): Update.
6652         (stop_callback): Remove parameter.
6653         (stop_wait_callback, detach_callback, resume_set_callback)
6654         (select_singlestep_lwp_callback, set_ignore_sigint)
6655         (status_callback, resumed_callback, resume_clear_callback)
6656         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6657         data parameter.
6658         (linux_nat_target::detach, linux_nat_target::resume)
6659         (linux_stop_and_wait_all_lwps, select_event_lwp)
6660         (linux_nat_filter_event, linux_nat_wait_1)
6661         (linux_nat_target::kill, linux_nat_target::stop)
6662         (linux_nat_target::stop): Update.
6663         (linux_nat_resume_callback): Change type.
6664         (resume_stopped_resumed_lwps, count_events_callback)
6665         (select_event_lwp_callback): Likewise.
6666         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6667         * arm-linux-nat.c (struct update_registers_data): Remove.
6668         (update_registers_callback): Change type.
6669         (arm_linux_insert_hw_breakpoint1): Update.
6670         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6671         parameter.
6672         (x86_linux_dr_set_addr): Update.
6673         (x86_linux_dr_set_control): Update.
6674         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6675         (iterate_over_lwps): Use gdb::function_view.
6676         * nat/aarch64-linux-hw-point.c (struct
6677         aarch64_dr_update_callback_param): Remove.
6678         (debug_reg_change_callback): Change type.
6679         (aarch64_notify_debug_reg_change): Update.
6680         * s390-linux-nat.c (s390_refresh_per_info): Update.
6681
6682 2019-03-11  Tom Tromey  <tromey@adacore.com>
6683
6684         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6685         redundant assignment to "this_cu".
6686
6687 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6688
6689         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6690
6691 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6692
6693         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6694         from...
6695         (rank_one_type): ... this.
6696
6697 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6698
6699         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6700         from...
6701         (rank_one_type): ... this.
6702
6703 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6704
6705         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6706         from...
6707         (rank_one_type): ... this.
6708
6709 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6710
6711         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6712         from...
6713         (rank_one_type): ... this.
6714
6715 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6716
6717         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6718         from...
6719         (rank_one_type): ... this.
6720
6721 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6722
6723         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6724         from...
6725         (rank_one_type): ... this.
6726
6727 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6728
6729         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6730         from...
6731         (rank_one_type): ... this.
6732
6733 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6734
6735         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6736         from...
6737         (rank_one_type): ... this.
6738
6739 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6740
6741         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6742         from...
6743         (rank_one_type): ... this.
6744
6745 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6746
6747         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6748         from...
6749         (rank_one_type): ... this.
6750
6751 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6752
6753         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6754         from...
6755         (rank_one_type): ... this.
6756
6757 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6758
6759         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6760         from...
6761         (rank_one_type): ... this.
6762
6763 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6764
6765         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6766         inferior-events' shows the example events.
6767
6768 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6769
6770         Support styling on native MS-Windows console
6771
6772         PR/24315
6773         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6774         on MS-Windows if $TERM is not defined.
6775
6776         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6777
6778         * posix-hdep.c (gdb_console_fputs):
6779         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6780         functions.
6781         * ui-file.h (gdb_console_fputs): Add prototype.
6782
6783         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6784         back to fputs only if the former returns zero.
6785
6786 2019-03-07  Tom Tromey  <tom@tromey.com>
6787
6788         * symmisc.c (print_symbol_bcache_statistics): Update.
6789         (print_objfile_statistics): Update.
6790         * symfile.c (allocate_symtab): Update.
6791         * stabsread.c: Don't include bcache.h.
6792         * psymtab.h (struct psymbol_bcache): Don't declare.
6793         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6794         (psymbol_bcache_init, psymbol_bcache_free)
6795         (psymbol_bcache_get_bcache): Don't declare.
6796         * psymtab.c (struct psymbol_bcache): Remove.
6797         (psymtab_storage::psymtab_storage): Update.
6798         (psymtab_storage::~psymtab_storage): Update.
6799         (psymbol_bcache_init, psymbol_bcache_free)
6800         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6801         (add_psymbol_to_bcache): Update.
6802         (allocate_psymtab): Update.
6803         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6804         macro_cache>: No longer pointers.
6805         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6806         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6807         * macrotab.c (macro_bcache): Update.
6808         * macroexp.c: Don't include bcache.h.
6809         * gdbtypes.c (check_types_worklist): Update.
6810         (types_deeply_equal): Remove TRY/CATCH.  Update.
6811         * elfread.c (elf_symtab_read): Update.
6812         * dwarf2read.c: Don't include bcache.h.
6813         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6814         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6815         (print_bcache_statistics, bcache_memory_used): Don't declare.
6816         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6817         methods.  Rename all data members.
6818         * bcache.c (struct bcache): Move to bcache.h.
6819         (bcache::expand_hash_table): Rename from expand_hash_table.
6820         (bcache): Remove.
6821         (bcache::insert): Rename from bcache_full.
6822         (bcache::compare): Rename from bcache_compare.
6823         (bcache_xmalloc): Remove.
6824         (bcache::~bcache): Rename from bcache_xfree.
6825         (bcache::print_statistics): Rename from print_bcache_statistics.
6826         (bcache::memory_used): Rename from bcache_memory_used.
6827
6828 2019-03-07  Pedro Alves  <palves@redhat.com>
6829
6830         * infrun.c (normal_stop): Also check for
6831         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6832
6833 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6834
6835         * f-lang.c (value_from_host_double): Moved to...
6836         * value.c (value_from_host_double): ...here.
6837         * value.h (value_from_host_double): Declare.
6838         * guile/scm-math.c (vlscm_convert_typed_number): Use
6839         value_from_host_double.
6840         (vlscm_convert_number): Likewise.
6841         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6842         * python/py-value.c (convert_value_from_python): Likewise.
6843
6844 2019-03-06  Tom Tromey  <tom@tromey.com>
6845
6846         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6847
6848 2019-03-06  Tom Tromey  <tom@tromey.com>
6849
6850         * utils.h (free_current_contents): Don't declare.
6851         * utils.c (free_current_contents): Remove.
6852
6853 2019-03-06  Tom Tromey  <tom@tromey.com>
6854
6855         * top.c (quit_force): Update.
6856         * main.c (captured_command_loop): Update.
6857         * common/new-op.c (operator new): Update.
6858         * common/common-exceptions.c (struct catcher)
6859         <save_cleanup_chain>: Remove member.
6860         (exceptions_state_mc_init): Update.
6861         (exception_try_scope_entry): Return nullptr.
6862         (exception_try_scope_exit, exception_rethrow)
6863         (throw_exception_sjlj, throw_exception_cxx): Update.
6864         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6865         (all_cleanups, do_cleanups, discard_cleanups)
6866         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6867         (restore_cleanups, restore_final_cleanups): Don't declare.
6868         (do_final_cleanups): Remove parameter.
6869         * common/cleanups.c (cleanup_chain, make_cleanup)
6870         (make_cleanup_dtor, all_cleanups, do_cleanups)
6871         (discard_my_cleanups, discard_cleanups)
6872         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6873         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6874         (null_cleanup): Remove.
6875         (do_final_cleanups): Remove parameter.
6876
6877 2019-03-06  Tom Tromey  <tom@tromey.com>
6878
6879         * remote.c (remote_target::remote_parse_stop_reply): Use
6880         unique_xmalloc_ptr.
6881
6882 2019-03-06  Tom Tromey  <tom@tromey.com>
6883
6884         * stabsread.c (struct stabs_field_info): Rename from field_info.
6885         <list, fnlist>: Add initializers.
6886         <obstack>: New member.
6887         (read_member_functions, read_struct_fields, read_baseclasses):
6888         Allocate on obstack.  Don't use cleanups.
6889         (read_one_struct_field, read_member_functions, read_struct_fields)
6890         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6891         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6892         (read_struct_type): Update.
6893
6894 2019-03-06  Tom Tromey  <tom@tromey.com>
6895
6896         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6897         * common/filestuff.h (make_cleanup_close): Don't declare.
6898         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6899         Remove.
6900
6901 2019-03-06  Tom Tromey  <tom@tromey.com>
6902
6903         * solib-aix.c: Use make_scope_exit.
6904
6905 2019-03-06  Tom Tromey  <tom@tromey.com>
6906
6907         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6908         Use make_scope_exit.
6909
6910 2019-03-06  Tom Tromey  <tom@tromey.com>
6911
6912         * solib-svr4.c (disable_probes_interface): Remove parameter.
6913         (svr4_handle_solib_event): Use make_scope_exit.
6914
6915 2019-03-06  Tom Tromey  <tom@tromey.com>
6916
6917         * remote.c (struct stop_reply_deleter): Remove.
6918         (stop_reply_up): Update.
6919         (struct stop_reply): Derive from notif_event.  Don't typedef.
6920         <regcache>: Now a std::vector.
6921         (stop_reply_xfree): Remove.
6922         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6923         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6924         (remote_target::discard_pending_stop_replies): Use delete.
6925         (remote_target::remote_parse_stop_reply): Update.
6926         (remote_target::process_stop_reply): Update.
6927         * remote-notif.h (struct notif_event): Add virtual destructor.
6928         Remove "dtr" member.
6929         (struct notif_client) <alloc_event>: Return a unique_ptr.
6930         (notif_event_xfree): Don't declare.
6931         (notif_event_up): New typedef.
6932         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6933         (notif_event_xfree, do_notif_event_xfree): Remove.
6934         (remote_notif_state_xfree): Update.
6935
6936 2019-03-06  Tom Tromey  <tom@tromey.com>
6937
6938         * infrun.c (displaced_step_clear_cleanup): Now a
6939         forward_scope_exit type.
6940         (displaced_step_prepare_throw): Update.
6941         (displaced_step_fixup): Update.
6942
6943 2019-03-06  Tom Tromey  <tom@tromey.com>
6944
6945         * inferior.h (class inferior): Update comment.
6946         * gdbthread.h (class thread_info): Update comment.
6947
6948 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6949             Tom Tromey  <tom@tromey.com>
6950
6951         * stabsread.h (struct stab_section_list): Remove.
6952         (coffstab_build_psymtabs): Update.
6953         * dbxread.c (symbuf_sections): Now a std::vector.
6954         (sect_idx): New global.
6955         (fill_symbuf): Update.
6956         (coffstab_build_psymtabs): Change type of stabsects parameter.
6957         Update.
6958         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6959         std::vector.
6960         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6961         (coff_locate_sections): Update.
6962         (coff_symfile_read): Remove cleanups.  Update.
6963         (init_stringtab): Add storage parameter.
6964         (free_stringtab, free_stringtab_cleanup): Remove.
6965         (init_lineno): Add storage parameter.
6966         (free_linetab, free_linetab_cleanup): Remove.
6967
6968 2019-03-06  Pedro Alves  <palves@redhat.com>
6969
6970         * linux-fork.c (fork_info::clobber_regs): Delete.
6971         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6972         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6973         comment.  Adjust.
6974         (scoped_switch_fork_info::scoped_switch_fork_info)
6975         (checkpoint_command, linux_fork_context): Adjust
6976         fork_save_infrun_state calls.
6977
6978 2019-03-06  Pedro Alves  <palves@redhat.com>
6979
6980         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6981         (inf_has_multiple_threads): Return 'bool' and rewrite using
6982         inferior_info::threads().
6983
6984 2019-03-06  Pedro Alves  <palves@redhat.com>
6985
6986         * linux-fork.c: Include <list>.
6987         (fork_list): Now a std::list instance.
6988         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6989         (forks_exist_p, find_last_fork): Adjust.
6990         (new_fork): Delete.
6991         (one_fork_p): New.
6992         (add_fork): Adjust.
6993         (free_fork): Delete, folded into fork_info::~fork_info().
6994         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6995         Adjust.
6996         (init_fork_list): Delete.
6997         (linux_fork_killall, linux_fork_mourn_inferior)
6998         (linux_fork_detach, info_checkpoints_command): Adjust.
6999         (_initialize_linux_fork): No longer call init_fork_list.
7000
7001 2019-03-06  Pedro Alves  <palves@redhat.com>
7002
7003         * linux-fork.c (new_fork): New, split out of ...
7004         (add_fork): ... this.  Return void.  Move "first fork" special
7005         case from here, to ...
7006         (checkpoint_command): ... here.
7007         * linux-linux.h (add_fork): Return void.
7008
7009 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7010
7011         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7012
7013 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7014             Chris January  <chris.january@arm.com>
7015             David Lecomber  <david.lecomber@arm.com>
7016
7017         * f-exp.y: New token, UNOP_INTRINSIC.
7018         (exp): New pattern using UNOP_INTRINSIC token.
7019         (f77_keywords): Add 'abs' keyword.
7020         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7021         (value_from_host_double): New function.
7022         (evaluate_subexp_f): Support UNOP_ABS.
7023
7024 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7025
7026         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7027         types.
7028
7029 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7030
7031         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7032         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7033         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7034
7035 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7036
7037         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7038
7039 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7040             Chris January  <chris.january@arm.com>
7041
7042         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7043         * f-exp.y: Define 'KIND' token.
7044         (exp): New pattern for KIND expressions.
7045         (ptype): Handle types with a kind extension.
7046         (direct_abs_decl): Extend to spot kind extensions.
7047         (f77_keywords): Add 'kind' to the list.
7048         (push_kind_type): New function.
7049         (convert_to_kind_type): New function.
7050         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7051         * parse.c (operator_length_standard): Likewise.
7052         * parser-defs.h (enum type_pieces): Add tp_kind.
7053         * std-operator.def: Add UNOP_KIND.
7054
7055 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7056
7057         * f-exp.y (f_parse): Set yydebug.
7058
7059 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7060
7061         * f-lang.c (evaluate_subexp_f): New function.
7062         (exp_descriptor_f): New global.
7063         (f_language_defn): Use exp_descriptor_f instead of
7064         exp_descriptor_standard.
7065
7066 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7067
7068         * f-exp.y (struct token): Add comments.
7069         (dot_ops): Remove uppercase versions and the end marker.
7070         (f77_keywords): Likewise.
7071         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7072         entries in the dot_ops array are case insensitive, and use
7073         strncasecmp to compare strings.  Also some whitespace cleanup in
7074         this area.  Similar for the f77_keywords array, except entries in
7075         this list might be case sensitive.
7076
7077 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7078
7079         * f-exp.y (struct f77_boolean_val): Add comments.
7080         (boolean_values): Remove uppercase versions, and end marker.
7081         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7082         and use strncasecmp to achieve case insensitivity.  Additionally,
7083         perform whitespace cleanup around this code.
7084
7085 2019-03-06  Tom Tromey  <tromey@adacore.com>
7086
7087         * remote-sim.c (gdbsim_target_open): Use result of
7088         gdb_argv::release.
7089
7090 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7091         Dirk Schubert  <dirk.schubert@arm.com>
7092         Chris January  <chris.january@arm.com>
7093
7094         * eval.c (evaluate_subexp_standard): Call Fortran argument
7095         wrapping logic.
7096         * f-lang.c (struct value): A value which can be passed into a
7097         Fortran function call.
7098         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7099         where appropriate.
7100         (struct type): Value ready for a Fortran function call.
7101         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7102         is needed.
7103         * f-lang.h (fortran_argument_convert): Declaration.
7104         (fortran_preserve_arg_pointer): Declaration.
7105         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7106
7107 2019-03-05  Tom Tromey  <tromey@adacore.com>
7108
7109         * python/py-prettyprint.c (print_string_repr): Remove #if.
7110         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7111
7112 2019-03-05  Tom Tromey  <tromey@adacore.com>
7113
7114         * target.c (the_dummy_target): Move later.  Change type to
7115         "dummy_target".
7116         (initialize_targets): Don't initialize the_dummy_target.
7117
7118 2019-03-05  Tom Tromey  <tromey@adacore.com>
7119
7120         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7121         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7122
7123 2019-03-05  Tom Tromey  <tromey@adacore.com>
7124
7125         * windows-nat.c (windows_nat_target::attach)
7126         (windows_nat_target::detach): Don't call gdb_flush.
7127         * valprint.c (generic_val_print, val_print, val_print_string):
7128         Don't call gdb_flush.
7129         * utils.c (defaulted_query): Don't call gdb_flush.
7130         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7131         * target.c (target_announce_detach): Don't call gdb_flush.
7132         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7133         * remote.c (extended_remote_target::attach): Don't call
7134         gdb_flush.
7135         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7136         * printcmd.c (do_examine): Don't call gdb_flush.
7137         (info_display_command): Don't call gdb_flush.
7138         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7139         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7140         * memattr.c (info_mem_command): Don't call gdb_flush.
7141         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7142         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7143         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7144         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7145         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7146         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7147         (gnu_nat_target::detach): Don't call gdb_flush.
7148         * f-valprint.c (f_val_print): Don't call gdb_flush.
7149         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7150         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7151         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7152         gdb_flush.
7153         * c-valprint.c (c_val_print): Don't call gdb_flush.
7154         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7155
7156 2019-03-05  Tom Tromey  <tromey@adacore.com>
7157
7158         * varobj.c (update_dynamic_varobj_children): Update.
7159         (install_default_visualizer): Use reset, not release.
7160         * value.c (set_internalvar): Update.
7161         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7162         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7163         ATTRIBUTE_UNUSED_RESULT.
7164
7165 2019-03-05  Tom Tromey  <tromey@adacore.com>
7166
7167         * remote.c (class scoped_remote_fd) <release>: Add
7168         ATTRIBUTE_UNUSED_RESULT.
7169
7170 2019-03-05  Tom Tromey  <tromey@adacore.com>
7171
7172         * macroexp.c (struct macro_buffer) <release>: Add
7173         ATTRIBUTE_UNUSED_RESULT.
7174
7175 2019-03-05  Tom Tromey  <tromey@adacore.com>
7176
7177         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7178         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7179         ATTRIBUTE_UNUSED_RESULT.
7180
7181 2019-03-05  Tom Tromey  <tromey@adacore.com>
7182
7183         * common/scoped_fd.h (class scoped_fd) <release>: Add
7184         ATTRIBUTE_UNUSED_RESULT.
7185
7186 2019-03-05  Tom Tromey  <tromey@adacore.com>
7187
7188         * parser-defs.h (struct parser_state) <release>: Add
7189         ATTRIBUTE_UNUSED_RESULT.
7190
7191 2019-03-05  Tom Tromey  <tromey@adacore.com>
7192
7193         * utils.h (class gdb_argv) <release>: Add
7194         ATTRIBUTE_UNUSED_RESULT.
7195         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7196
7197 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7198
7199         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7200         for-loop range, to avoid compiler warnings.
7201
7202         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7203         avoid compiler warnings about unused variables.
7204
7205         * NEWS: Mention end of support for native debugging on MS-Windows
7206         before XP.
7207
7208         PR gdb/24292
7209         * common/netstuff.c:
7210         * gdbserver/gdbreplay.c
7211         * gdbserver/remote-utils.c:
7212         * ser-tcp.c:
7213         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7214         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7215         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7216         'getaddrinfo' and 'freeaddrinfo' were not available before
7217         Windows XP, and mingw.org's MinGW headers by default define
7218         _WIN32_WINNT to 0x500.
7219
7220 2019-03-01  Gary Benson <gbenson@redhat.com>
7221
7222         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7223
7224 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7225             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7226
7227         PR gdb/8527
7228         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7229         set_sigint_trap, clear_sigint_trap.
7230
7231 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7232
7233         * target.c (target_detach): Clear the regcache and the
7234         frame cache.
7235
7236 2019-02-27  Pedro Alves  <palves@redhat.com>
7237
7238         * utils.c (set_screen_size): When we cap the height/width sizes,
7239         tweak the corresponding command variable to show "unlimited":
7240
7241 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7242             Pedro Alves  <palves@redhat.com>
7243
7244         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7245         before calling rl_set_screen_size.
7246
7247 2019-02-27  Tom Tromey  <tromey@adacore.com>
7248
7249         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7250         define.
7251         * python/py-value.c: Remove Python 2.4 workaround.
7252         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7253         workaround.
7254         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7255         Python 2.4 workaround.
7256         * python/python-internal.h: Remove Python 2.4 comment.
7257         (Py_ssize_t): Don't define.
7258         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7259         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7260         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7261         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7262         * python/python.c (do_start_initialization): Remove Python 2.4
7263         workaround.
7264         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7265         (print_children): Remove Python 2.4 workaround.
7266         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7267         workaround.
7268         (CHARBUFFERPROC_NAME): Remove.
7269         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7270         Python 2.4 workaround.
7271
7272 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7273
7274         * NEWS: Note minimum Python version.
7275
7276 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7277
7278         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7279         code from these functions.  Remove corresponding ifdefs.  Use
7280         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7281         Remove gotos and target of gotos.
7282         (infpy_search_memory): Likewise.
7283
7284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7285
7286         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7287         (hppa_gdbarch_init): Don't register deleted functions with
7288         gdbarch.
7289
7290 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7291
7292         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7293         (h8300_unwind_sp): Delete.
7294         (h8300_dummy_id): Delete.
7295         (h8300_gdbarch_init): Don't register deleted functions with
7296         gdbarch.
7297
7298 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7299
7300         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7301         (ft32_unwind_pc): Delete.
7302         (ft32_unwind_sp): Delete.
7303         (ft32_gdbarch_init): Don't register deleted functions with
7304         gdbarch.
7305
7306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7307
7308         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7309         (frv_unwind_pc): Delete.
7310         (frv_unwind_sp): Delete.
7311         (frv_gdbarch_init): Don't register deleted functions with
7312         gdbarch.
7313
7314 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7315
7316         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7317         (riscv_unwind_pc): Delete.
7318         (riscv_unwind_sp): Delete.
7319         (riscv_gdbarch_init): Don't register deleted functions with
7320         gdbarch.
7321
7322 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7323
7324         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7325         (csky_unwind_pc): Delete.
7326         (csky_unwind_sp): Delete.
7327         (csky_gdbarch_init): Don't register deleted functions with
7328         gdbarch.
7329
7330 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7331
7332         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7333         (cris_unwind_pc): Delete.
7334         (cris_unwind_sp): Delete.
7335         (cris_gdbarch_init): Don't register deleted functions with
7336         gdbarch.
7337
7338 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7339
7340         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7341         (bfin_unwind_pc): Delete.
7342         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7343
7344 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7345
7346         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7347         (arm_unwind_pc): Delete.
7348         (arm_unwind_sp): Delete.
7349         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7350
7351 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7352
7353         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7354         (arc_unwind_pc): Delete.
7355         (arc_unwind_sp): Delete.
7356         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7357
7358 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7359
7360         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7361         (alpha_unwind_pc): Delete.
7362         (alpha_gdbarch_init): Don't register deleted functions with
7363         gdbarch.
7364
7365 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7366
7367         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7368         (aarch64_unwind_pc): Delete.
7369         (aarch64_unwind_sp): Delete.
7370         (aarch64_gdbarch_init): Don't register deleted functions with
7371         gdbarch.
7372
7373 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7374
7375         * gdbtypes.c (type_align): Don't consider static members when
7376         computing structure alignment.
7377
7378 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7379
7380         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7381         return 0 for other types.
7382         * arch-utils.c (default_type_align): Always return 0.
7383         * gdbarch.h: Regenerate.
7384         * gdbarch.sh (type_align): Extend comment.
7385         * gdbtypes.c (type_align): Add additional comments, always call
7386         gdbarch_type_align before applying the default rules.
7387         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7388         generic code will then apply a suitable default.
7389         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7390         types, return 0 for other types.
7391
7392 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7393
7394         * NEWS: Create a new section for the next release branch.
7395         Rename the section of the current branch, now that it has
7396         been cut.
7397
7398 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7399
7400         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7401         * version.in: Bump version to 8.3.50.DATE-git.
7402
7403 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7404
7405         * aix-thread.c (ptid_cmp): Remove unused variable.
7406         (get_signaled_thread): Likewise.
7407         (store_regs_user_thread): Likewise.
7408         (store_regs_kernel_thread): Likewise.
7409         (fetch_regs_kernel_thread): Remove shadowed variable.
7410
7411 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7412
7413         * features/riscv/32bit-cpu.xml: Add register numbers.
7414         * features/riscv/32bit-fpu.c: Regenerate.
7415         * features/riscv/32bit-fpu.xml: Add register numbers.
7416         * features/riscv/64bit-cpu.xml: Add register numbers.
7417         * features/riscv/64bit-fpu.c: Regenerate.
7418         * features/riscv/64bit-fpu.xml: Add register numbers.
7419
7420 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7421
7422         * NEWS: Mention two argument form of gdb.Value constructor.
7423         * python/py-value.c (convert_buffer_and_type_to_value): New
7424         function.
7425         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7426         Add support for handling an optional second argument.  Call
7427         convert_buffer_and_type_to_value as appropriate.
7428         * python/python-internal.h (Py_buffer_deleter): New struct.
7429         (Py_buffer_up): New typedef.
7430
7431 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7432
7433         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7434         instead of releasing ownership.
7435
7436 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7437
7438         * dwarf2read.c (open_and_init_dwp_file): Call
7439         elf_numsections instead of bfd_count_sections to initialize
7440         dwp_file->num_sections.
7441
7442 2019-02-25  Tom Tromey  <tromey@adacore.com>
7443
7444         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7445
7446 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7447
7448         * gcore.in: Add '--readnever' option when invoking GDB.
7449
7450 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7451
7452         * MAINTAINERS: Update my email address.
7453
7454 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7455
7456         * build-id.c (build_id_to_debug_bfd_1): New function.
7457         (build_id_to_debug_bfd): Look for separate debug file in
7458         sysroot.
7459
7460 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7461
7462         * gdbarch.sh: Update the copyright year range that is placed into
7463         generated files.
7464
7465 2019-02-22  Keith Seitz  <keiths@redhat.com>
7466
7467         PR symtab/23853
7468         * linespec.c (create_sals_line_offset): Search for the default
7469         symtab's filename instead of its fullname.
7470
7471 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7472
7473         * NEWS: Update style defaults.
7474
7475 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7476
7477         * main.c (captured_main_1): Disable styling in batch mode.
7478
7479 2019-02-20  Tom Tromey  <tom@tromey.com>
7480
7481         * symtab.c (symtab_symbol_info): Fix typos.
7482
7483 2019-02-20  Tom Tromey  <tromey@adacore.com>
7484
7485         * findcmd.c (_initialize_mem_search): Use upper case for
7486         metasyntactic variables.
7487
7488 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7489
7490         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7491         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7492
7493 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7494
7495         * top.h (source_file_name): Change to std::string.
7496         * top.c (source_file_name): Likewise.
7497         (command_line_input): Adjust.
7498         * cli/cli-script.c (script_from_file): Adjust.
7499
7500 2019-02-19  Tom Tromey  <tromey@adacore.com>
7501
7502         * ravenscar-thread.c
7503         (ravenscar_thread_target::update_thread_list): Don't call
7504         ada_build_task_list.
7505         * ada-lang.h (ada_build_task_list): Don't declare.
7506         * ada-tasks.c (struct ada_tasks_inferior_data)
7507         <task_list_valid_p>: Now bool.
7508         (read_known_tasks, ada_task_list_changed)
7509         (ada_tasks_invalidate_inferior_data): Update.
7510         (read_known_tasks_array): Return bool.
7511         (read_known_tasks_list): Likewise.
7512         (read_known_tasks): Return void.
7513         (ada_build_task_list): Now static.
7514
7515 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7516
7517         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7518         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7519
7520 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7521
7522         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7523         variant for ada_tasks_pspace_data_handle and
7524         ada_tasks_inferior_data_handle.
7525         (ada_tasks_pspace_data_cleanup): New function.
7526         (ada_tasks_inferior_data_cleanup): New function.
7527
7528 2019-02-17  Tom Tromey  <tom@tromey.com>
7529
7530         * macrotab.h (macro_source_fullname): Return a std::string.
7531         * macrotab.c (macro_include, check_for_redefinition)
7532         (macro_undef, macro_lookup_definition, foreach_macro)
7533         (foreach_macro_in_scope): Update.
7534         (macro_source_fullname): Return a std::string.
7535         * macrocmd.c (show_pp_source_pos): Update.
7536
7537 2019-02-17  Tom Tromey  <tom@tromey.com>
7538
7539         * macrocmd.c (show_pp_source_pos): Style the file names.
7540
7541 2019-02-17  Tom Tromey  <tom@tromey.com>
7542
7543         PR tui/24197:
7544         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7545
7546 2019-02-17  Tom Tromey  <tom@tromey.com>
7547
7548         * ada-lang.c (user_select_syms): Use filtered printing.
7549         * utils.c (wrap_style): New global.
7550         (desired_style): Remove.
7551         (emit_style_escape): Add stream parameter.
7552         (set_output_style, reset_terminal_style, prompt_for_continue):
7553         Update.
7554         (flush_wrap_buffer): Only flush gdb_stdout.
7555         (wrap_here): Set wrap_style.
7556         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7557         treat escape sequences as a character.  Change when wrap buffer is
7558         flushed.
7559         (fputs_styled): Do not set the output style when the default is
7560         requested.
7561         * ui-style.h (struct ui_file_style) <is_default>: New method.
7562         * source.c (print_source_lines_base): Emit escape sequences in one
7563         piece.
7564
7565 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7566
7567         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7568         integers and enumeration types.
7569
7570 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7571
7572         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7573         instead of lookup_symbol_in_language
7574         (do_exact_match): New function.
7575         (ada_get_symbol_name_matcher): Return do_exact_match when
7576         doing a verbatim match.
7577
7578 2019-02-15  Tom Tromey  <tromey@adacore.com>
7579
7580         * ravenscar-thread.c (ravenscar_thread_target::resume)
7581         (ravenscar_thread_target::wait): Special case wildcard requests.
7582
7583 2019-02-15  Tom Tromey  <tromey@adacore.com>
7584
7585         * ravenscar-thread.c (base_ptid): Remove.
7586         (struct ravenscar_thread_target) <close>: New method.
7587         <m_base_ptid>: New member.
7588         <update_inferior_ptid, active_task, task_is_currently_active,
7589         runtime_initialized>: Declare methods.
7590         <ravenscar_thread_target>: Add constructor.
7591         (ravenscar_thread_target::task_is_currently_active)
7592         (ravenscar_thread_target::update_inferior_ptid)
7593         (ravenscar_runtime_initialized): Rename.  Now methods.
7594         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7595         (ravenscar_thread_target::update_thread_list): Update.
7596         (ravenscar_thread_target::active_task): Now method.
7597         (ravenscar_thread_target::store_registers)
7598         (ravenscar_thread_target::prepare_to_store)
7599         (ravenscar_thread_target::prepare_to_store)
7600         (ravenscar_thread_target::mourn_inferior): Update.
7601         (ravenscar_inferior_created): Use "new" to create target.
7602         (ravenscar_thread_target::get_ada_task_ptid): Update.
7603         (_initialize_ravenscar): Don't initialize base_ptid.
7604         (ravenscar_ops): Remove global.
7605
7606 2019-02-15  Tom Tromey  <tromey@adacore.com>
7607
7608         * target.h (push_target): Declare new overload.
7609         * target.c (push_target): New overload, taking an rvalue reference.
7610         * remote.c (remote_target::open_1): Use push_target overload.
7611         * corelow.c (core_target_open): Use push_target overload.
7612
7613 2019-02-15  Tom Tromey  <tromey@adacore.com>
7614
7615         * ravenscar-thread.c (is_ravenscar_task)
7616         (ravenscar_task_is_currently_active): Return bool.
7617         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7618         (_initialize_ravenscar): Remove "(void)".
7619         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7620         Return bool.
7621
7622 2019-02-15  Tom Tromey  <tromey@adacore.com>
7623
7624         * ravenscar-thread.c (ravenscar_runtime_initializer)
7625         (has_ravenscar_runtime, get_running_thread_id)
7626         (ravenscar_thread_target::resume): Fix indentation.
7627
7628 2019-02-15  Tom Tromey  <tromey@adacore.com>
7629
7630         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7631         from ravenscar_arch_ops.
7632         (sparc_ravenscar_ops::fetch_registers)
7633         (sparc_ravenscar_ops::store_registers): Now methods.
7634         (sparc_ravenscar_prepare_to_store): Remove.
7635         (sparc_ravenscar_ops): Redefine.
7636         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7637         methods and destructor.  Remove members.
7638         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7639         (ravenscar_thread_target::store_registers)
7640         (ravenscar_thread_target::prepare_to_store): Update.
7641         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7642         Remove.
7643         (struct ppc_ravenscar_powerpc_ops): Derive from
7644         ravenscar_arch_ops.
7645         (ppc_ravenscar_powerpc_ops::fetch_registers)
7646         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7647         (ppc_ravenscar_powerpc_ops): Redefine.
7648         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7649         (ppc_ravenscar_e500_ops::fetch_registers)
7650         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7651         (ppc_ravenscar_e500_ops): Redefine.
7652         * aarch64-ravenscar-thread.c
7653         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7654         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7655         (aarch64_ravenscar_fetch_registers)
7656         (aarch64_ravenscar_store_registers): Now methods.
7657         (aarch64_ravenscar_ops): Redefine.
7658
7659 2019-02-15  Tom Tromey  <tromey@adacore.com>
7660
7661         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7662         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7663         (ravenscar_thread_target::stopped_by_watchpoint)
7664         (ravenscar_thread_target::stopped_data_address)
7665         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7666
7667 2019-02-15  Tom Tromey  <tromey@adacore.com>
7668
7669         * ravenscar-thread.c: Fix some typos.
7670
7671 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7672             Tom Tromey  <tromey@adacore.com>
7673
7674         * ada-lang.c (ada_exception_sal): Change addr_string to a
7675         std::string.
7676         (create_ada_exception_catchpoint): Update.
7677
7678 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7679             Tom Tromey  <tromey@adacore.com>
7680
7681         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7682         (bp_location_ops): Remove.
7683         (base_breakpoint_allocate_location): Update.
7684         (free_bp_location): Update.
7685         * ada-lang.c (class ada_catchpoint_location)
7686         <ada_catchpoint_location>: Remove ops parameter.
7687         (ada_catchpoint_location_dtor): Remove.
7688         (ada_catchpoint_location_ops): Remove.
7689         (allocate_location_exception): Update.
7690         * breakpoint.h (struct bp_location_ops): Remove.
7691         (class bp_location) <bp_location>: Remove bp_location_ops
7692         parameter.
7693         <~bp_location>: Add destructor.
7694         <ops>: Remove.
7695
7696 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7697             Pedro Alves  <palves@redhat.com>
7698
7699         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7700         'PATH_MAX'.
7701
7702 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7703             Samuel Thibault  <samuel.thibault@gnu.org>
7704             Thomas Schwinge  <thomas@codesourcery.com>
7705
7706         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7707         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7708
7709 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7710
7711         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7712         (check_empty): Use "const char *".
7713
7714         * gnu-nat.c (gnu_nat_target::detach): Instead of
7715         'detach_inferior (pid)' call
7716         'detach_inferior (find_inferior_pid (pid))'.
7717
7718         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7719         'nat/fork-inferior.o'.
7720         * gnu-nat.c: #include "nat/fork-inferior.h".
7721
7722         * gnu-nat.c (gnu_nat_target::detach): Instead of
7723         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7724         * gnu-nat.h: #include "inf-child.h".
7725         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7726         'i386_gnu_nat_target::fetch_registers'.
7727         (gnu_store_registers): Rename/move to
7728         'i386_gnu_nat_target::store_registers'.
7729
7730         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7731         * gnu-nat.h (mach_thread_info): New function.
7732         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7733
7734         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7735
7736 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7737
7738         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7739
7740 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7741
7742         * windows-nat.c (windows_add_thread): Add new parameter
7743         "main_thread_p" with default value set to false.  Update
7744         function documentation as well as all callers.
7745         (windows_delete_thread): Likewise.
7746         (fake_create_process): Update call to windows_add_thread.
7747         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7748         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7749         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7750         call to windows_delete_thread.
7751
7752 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7753
7754         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7755
7756 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7757
7758         * symfile.c (find_separate_debug_file): Use canonical path of
7759         sysroot with child_path instead of gdb_sysroot if it is valid.
7760
7761 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7762
7763         * symfile.c (find_separate_debug_file): Use child_path to
7764         determine if an object file is under a sysroot.
7765
7766 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7767
7768         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7769         unittests/child-path-selftests.c.
7770         * common/pathstuff.c (child_path): New function.
7771         * common/pathstuff.h (child_path): New prototype.
7772         * unittests/child-path-selftests.c: New file.
7773
7774 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7775
7776         * symfile.c (find_separate_debug_file): Look for separate debug
7777         files in debug directories under the sysroot.
7778
7779 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7780
7781         * symtab.h (struct minimal_symbol data_p): New const method.
7782         (struct minimal_symbol text_p): Likewise.
7783         * symtab.c (output_source_filename): Use file name style
7784         to print file name.
7785         (print_symbol_info): Likewise.
7786         (print_msymbol_info): Use address style to print addresses.
7787         Use function name style to print executable text symbols.
7788         (expand_symtab_containing_pc): Use data_p.
7789         (find_pc_sect_compunit_symtab): Likewise.
7790
7791 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7792
7793         * breakpoint.c (describe_other_breakpoints): Use address style
7794         to print addresses.
7795         (say_where): Likewise.
7796
7797 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7798
7799         * ada-typeprint.c (print_func_type): Print function name
7800         style to print function name.
7801         * c-typeprint.c (c_print_type_1): Likewise.
7802
7803 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7804
7805         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7806         for execve.
7807
7808 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7809
7810         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7811         type_stack.
7812
7813 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7814
7815         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7816         TYPE_CODE_REF types.
7817
7818 2019-02-08  Jim Wilson  <jimw@sifive.com>
7819
7820         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7821         (riscv_linux_fregset): New.
7822         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7823
7824 2019-02-07  Tom Tromey  <tom@tromey.com>
7825
7826         * thread.c (thread_cancel_execution_command): Update.
7827         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7828         methods.
7829         (struct thread_fsm_ops): Remove.
7830         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7831         (thread_fsm_should_stop, thread_fsm_return_value)
7832         (thread_fsm_set_finished, thread_fsm_finished_p)
7833         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7834         Don't declare.
7835         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7836         * infrun.c (clear_proceed_status_thread)
7837         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7838         (print_stop_event): Update.
7839         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7840         Add constructor.
7841         (step_command_fsm_ops): Remove.
7842         (new_step_command_fsm): Remove.
7843         (step_1): Update.
7844         (step_command_fsm::should_stop): Rename from
7845         step_command_fsm_should_stop.
7846         (step_command_fsm::clean_up): Rename from
7847         step_command_fsm_clean_up.
7848         (step_command_fsm::do_async_reply_reason): Rename from
7849         step_command_fsm_async_reply_reason.
7850         (struct until_next_fsm): Inherit from thread_fsm.  Add
7851         constructor.
7852         (until_next_fsm_ops): Remove.
7853         (new_until_next_fsm): Remove.
7854         (until_next_fsm::should_stop): Rename from
7855         until_next_fsm_should_stop.
7856         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7857         (until_next_fsm::do_async_reply_reason): Rename from
7858         until_next_fsm_async_reply_reason.
7859         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7860         constructor.  Change type of breakpoint.
7861         (finish_command_fsm_ops): Remove.
7862         (new_finish_command_fsm): Remove.
7863         (finish_command_fsm::should_stop): Rename from
7864         finish_command_fsm_should_stop.
7865         (finish_command_fsm::clean_up): Rename from
7866         finish_command_fsm_clean_up.
7867         (finish_command_fsm::return_value): Rename from
7868         finish_command_fsm_return_value.
7869         (finish_command_fsm::do_async_reply_reason): Rename from
7870         finish_command_fsm_async_reply_reason.
7871         (finish_command): Update.
7872         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7873         Add constructor.
7874         (call_thread_fsm_ops): Remove.
7875         (call_thread_fsm::call_thread_fsm): Rename from
7876         new_call_thread_fsm.
7877         (call_thread_fsm::should_stop): Rename from
7878         call_thread_fsm_should_stop.
7879         (call_thread_fsm::should_notify_stop): Rename from
7880         call_thread_fsm_should_notify_stop.
7881         (run_inferior_call, call_function_by_hand_dummy): Update.
7882         * cli/cli-interp.c (should_print_stop_to_console): Update.
7883         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7884         Add constructor.  Change type of location_breakpoint,
7885         caller_breakpoint.
7886         (until_break_fsm_ops): Remove.
7887         (new_until_break_fsm): Remove.
7888         (until_break_fsm::should_stop): Rename from
7889         until_break_fsm_should_stop.
7890         (until_break_fsm::clean_up): Rename from
7891         until_break_fsm_clean_up.
7892         (until_break_fsm::do_async_reply_reason): Rename from
7893         until_break_fsm_async_reply_reason.
7894         (until_break_command): Update.
7895         * thread-fsm.c: Remove.
7896         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7897
7898 2019-02-07  Tom Tromey  <tom@tromey.com>
7899
7900         * yy-remap.h: Add include guard.
7901         * xtensa-tdep.h: Add include guard.
7902         * xcoffread.h: Rename include guard.
7903         * varobj-iter.h: Add include guard.
7904         * tui/tui.h: Rename include guard.
7905         * tui/tui-winsource.h: Rename include guard.
7906         * tui/tui-wingeneral.h: Rename include guard.
7907         * tui/tui-windata.h: Rename include guard.
7908         * tui/tui-win.h: Rename include guard.
7909         * tui/tui-stack.h: Rename include guard.
7910         * tui/tui-source.h: Rename include guard.
7911         * tui/tui-regs.h: Rename include guard.
7912         * tui/tui-out.h: Rename include guard.
7913         * tui/tui-layout.h: Rename include guard.
7914         * tui/tui-io.h: Rename include guard.
7915         * tui/tui-hooks.h: Rename include guard.
7916         * tui/tui-file.h: Rename include guard.
7917         * tui/tui-disasm.h: Rename include guard.
7918         * tui/tui-data.h: Rename include guard.
7919         * tui/tui-command.h: Rename include guard.
7920         * tic6x-tdep.h: Add include guard.
7921         * target/waitstatus.h: Rename include guard.
7922         * target/wait.h: Rename include guard.
7923         * target/target.h: Rename include guard.
7924         * target/resume.h: Rename include guard.
7925         * target-float.h: Rename include guard.
7926         * stabsread.h: Add include guard.
7927         * rs6000-tdep.h: Add include guard.
7928         * riscv-fbsd-tdep.h: Add include guard.
7929         * regformats/regdef.h: Rename include guard.
7930         * record.h: Rename include guard.
7931         * python/python.h: Rename include guard.
7932         * python/python-internal.h: Rename include guard.
7933         * python/py-stopevent.h: Rename include guard.
7934         * python/py-ref.h: Rename include guard.
7935         * python/py-record.h: Rename include guard.
7936         * python/py-record-full.h: Rename include guard.
7937         * python/py-record-btrace.h: Rename include guard.
7938         * python/py-instruction.h: Rename include guard.
7939         * python/py-events.h: Rename include guard.
7940         * python/py-event.h: Rename include guard.
7941         * procfs.h: Add include guard.
7942         * proc-utils.h: Add include guard.
7943         * p-lang.h: Add include guard.
7944         * or1k-tdep.h: Rename include guard.
7945         * observable.h: Rename include guard.
7946         * nto-tdep.h: Rename include guard.
7947         * nat/x86-linux.h: Rename include guard.
7948         * nat/x86-linux-dregs.h: Rename include guard.
7949         * nat/x86-gcc-cpuid.h: Add include guard.
7950         * nat/x86-dregs.h: Rename include guard.
7951         * nat/x86-cpuid.h: Rename include guard.
7952         * nat/ppc-linux.h: Rename include guard.
7953         * nat/mips-linux-watch.h: Rename include guard.
7954         * nat/linux-waitpid.h: Rename include guard.
7955         * nat/linux-ptrace.h: Rename include guard.
7956         * nat/linux-procfs.h: Rename include guard.
7957         * nat/linux-osdata.h: Rename include guard.
7958         * nat/linux-nat.h: Rename include guard.
7959         * nat/linux-namespaces.h: Rename include guard.
7960         * nat/linux-btrace.h: Rename include guard.
7961         * nat/glibc_thread_db.h: Rename include guard.
7962         * nat/gdb_thread_db.h: Rename include guard.
7963         * nat/gdb_ptrace.h: Rename include guard.
7964         * nat/fork-inferior.h: Rename include guard.
7965         * nat/amd64-linux-siginfo.h: Rename include guard.
7966         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7967         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7968         * nat/aarch64-linux.h: Rename include guard.
7969         * nat/aarch64-linux-hw-point.h: Rename include guard.
7970         * mn10300-tdep.h: Add include guard.
7971         * mips-linux-tdep.h: Add include guard.
7972         * mi/mi-parse.h: Rename include guard.
7973         * mi/mi-out.h: Rename include guard.
7974         * mi/mi-main.h: Rename include guard.
7975         * mi/mi-interp.h: Rename include guard.
7976         * mi/mi-getopt.h: Rename include guard.
7977         * mi/mi-console.h: Rename include guard.
7978         * mi/mi-common.h: Rename include guard.
7979         * mi/mi-cmds.h: Rename include guard.
7980         * mi/mi-cmd-break.h: Rename include guard.
7981         * m2-lang.h: Add include guard.
7982         * location.h: Rename include guard.
7983         * linux-record.h: Rename include guard.
7984         * linux-nat.h: Add include guard.
7985         * linux-fork.h: Add include guard.
7986         * i386-darwin-tdep.h: Rename include guard.
7987         * hppa-linux-offsets.h: Add include guard.
7988         * guile/guile.h: Rename include guard.
7989         * guile/guile-internal.h: Rename include guard.
7990         * gnu-nat.h: Rename include guard.
7991         * gdb-stabs.h: Rename include guard.
7992         * frv-tdep.h: Add include guard.
7993         * f-lang.h: Add include guard.
7994         * event-loop.h: Add include guard.
7995         * darwin-nat.h: Rename include guard.
7996         * cp-abi.h: Rename include guard.
7997         * config/sparc/nm-sol2.h: Rename include guard.
7998         * config/nm-nto.h: Rename include guard.
7999         * config/nm-linux.h: Add include guard.
8000         * config/i386/nm-i386gnu.h: Rename include guard.
8001         * config/djgpp/nl_types.h: Rename include guard.
8002         * config/djgpp/langinfo.h: Rename include guard.
8003         * compile/gcc-cp-plugin.h: Add include guard.
8004         * compile/gcc-c-plugin.h: Add include guard.
8005         * compile/compile.h: Rename include guard.
8006         * compile/compile-object-run.h: Rename include guard.
8007         * compile/compile-object-load.h: Rename include guard.
8008         * compile/compile-internal.h: Rename include guard.
8009         * compile/compile-cplus.h: Rename include guard.
8010         * compile/compile-c.h: Rename include guard.
8011         * common/xml-utils.h: Rename include guard.
8012         * common/x86-xstate.h: Rename include guard.
8013         * common/version.h: Rename include guard.
8014         * common/vec.h: Rename include guard.
8015         * common/tdesc.h: Rename include guard.
8016         * common/selftest.h: Rename include guard.
8017         * common/scoped_restore.h: Rename include guard.
8018         * common/scoped_mmap.h: Rename include guard.
8019         * common/scoped_fd.h: Rename include guard.
8020         * common/safe-iterator.h: Rename include guard.
8021         * common/run-time-clock.h: Rename include guard.
8022         * common/refcounted-object.h: Rename include guard.
8023         * common/queue.h: Rename include guard.
8024         * common/ptid.h: Rename include guard.
8025         * common/print-utils.h: Rename include guard.
8026         * common/preprocessor.h: Rename include guard.
8027         * common/pathstuff.h: Rename include guard.
8028         * common/observable.h: Rename include guard.
8029         * common/netstuff.h: Rename include guard.
8030         * common/job-control.h: Rename include guard.
8031         * common/host-defs.h: Rename include guard.
8032         * common/gdb_wait.h: Rename include guard.
8033         * common/gdb_vecs.h: Rename include guard.
8034         * common/gdb_unlinker.h: Rename include guard.
8035         * common/gdb_unique_ptr.h: Rename include guard.
8036         * common/gdb_tilde_expand.h: Rename include guard.
8037         * common/gdb_sys_time.h: Rename include guard.
8038         * common/gdb_string_view.h: Rename include guard.
8039         * common/gdb_splay_tree.h: Rename include guard.
8040         * common/gdb_setjmp.h: Rename include guard.
8041         * common/gdb_ref_ptr.h: Rename include guard.
8042         * common/gdb_optional.h: Rename include guard.
8043         * common/gdb_locale.h: Rename include guard.
8044         * common/gdb_assert.h: Rename include guard.
8045         * common/filtered-iterator.h: Rename include guard.
8046         * common/filestuff.h: Rename include guard.
8047         * common/fileio.h: Rename include guard.
8048         * common/environ.h: Rename include guard.
8049         * common/common-utils.h: Rename include guard.
8050         * common/common-types.h: Rename include guard.
8051         * common/common-regcache.h: Rename include guard.
8052         * common/common-inferior.h: Rename include guard.
8053         * common/common-gdbthread.h: Rename include guard.
8054         * common/common-exceptions.h: Rename include guard.
8055         * common/common-defs.h: Rename include guard.
8056         * common/common-debug.h: Rename include guard.
8057         * common/cleanups.h: Rename include guard.
8058         * common/buffer.h: Rename include guard.
8059         * common/btrace-common.h: Rename include guard.
8060         * common/break-common.h: Rename include guard.
8061         * cli/cli-utils.h: Rename include guard.
8062         * cli/cli-style.h: Rename include guard.
8063         * cli/cli-setshow.h: Rename include guard.
8064         * cli/cli-script.h: Rename include guard.
8065         * cli/cli-interp.h: Rename include guard.
8066         * cli/cli-decode.h: Rename include guard.
8067         * cli/cli-cmds.h: Rename include guard.
8068         * charset-list.h: Add include guard.
8069         * buildsym-legacy.h: Rename include guard.
8070         * bfin-tdep.h: Add include guard.
8071         * ax.h: Rename include guard.
8072         * arm-linux-tdep.h: Add include guard.
8073         * arm-fbsd-tdep.h: Add include guard.
8074         * arch/xtensa.h: Rename include guard.
8075         * arch/tic6x.h: Add include guard.
8076         * arch/i386.h: Add include guard.
8077         * arch/arm.h: Rename include guard.
8078         * arch/arm-linux.h: Rename include guard.
8079         * arch/arm-get-next-pcs.h: Rename include guard.
8080         * arch/amd64.h: Add include guard.
8081         * arch/aarch64-insn.h: Rename include guard.
8082         * arch-utils.h: Rename include guard.
8083         * annotate.h: Add include guard.
8084         * amd64-darwin-tdep.h: Rename include guard.
8085         * aarch64-linux-tdep.h: Add include guard.
8086         * aarch64-fbsd-tdep.h: Add include guard.
8087         * aarch32-linux-nat.h: Add include guard.
8088
8089 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8090
8091         * macrotab.c (macro_define_internal): New function that
8092         factorizes macro_define_object_internal and macro_define_function
8093         code.
8094         (macro_define_object_internal): Use macro_define_internal.
8095         (macro_define_function): Likewise.
8096
8097 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8098
8099         * macrocmd.c (extract_identifier): Return
8100         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8101         callers.
8102
8103 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8104
8105         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8106
8107 2019-02-05  Tom Tromey  <tom@tromey.com>
8108
8109         * target.c (target_stack::unpush): Move assertion earlier.
8110
8111 2019-01-30  Tom Tromey  <tom@tromey.com>
8112
8113         PR python/23615:
8114         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8115         (gdbpy_parse_and_eval): Likewise.
8116         * python/python-internal.h (gdbpy_allow_threads): New class.
8117
8118 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8119
8120         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8121         (aarch64_fbsd_fpregmap): Move earlier.
8122         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8123         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8124         instead of individual calls to trad_frame_set_reg_addr.
8125         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8126         earlier.
8127         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8128         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8129         instead of individual calls to trad_frame_set_reg_addr.
8130
8131 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8132
8133         * CONTRIBUTE: Replace contribution list with wiki link.
8134
8135 2019-01-25  Tom Tromey  <tom@tromey.com>
8136
8137         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8138
8139 2019-01-25  Tom Tromey  <tom@tromey.com>
8140
8141         * xtensa-linux-nat.c: Fix common/ includes.
8142         * xml-support.h: Fix common/ includes.
8143         * xml-support.c: Fix common/ includes.
8144         * x86-linux-nat.c: Fix common/ includes.
8145         * windows-nat.c: Fix common/ includes.
8146         * varobj.h: Fix common/ includes.
8147         * varobj.c: Fix common/ includes.
8148         * value.c: Fix common/ includes.
8149         * valops.c: Fix common/ includes.
8150         * utils.c: Fix common/ includes.
8151         * unittests/xml-utils-selftests.c: Fix common/ includes.
8152         * unittests/utils-selftests.c: Fix common/ includes.
8153         * unittests/unpack-selftests.c: Fix common/ includes.
8154         * unittests/tracepoint-selftests.c: Fix common/ includes.
8155         * unittests/style-selftests.c: Fix common/ includes.
8156         * unittests/string_view-selftests.c: Fix common/ includes.
8157         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8158         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8159         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8160         * unittests/rsp-low-selftests.c: Fix common/ includes.
8161         * unittests/parse-connection-spec-selftests.c: Fix common/
8162         includes.
8163         * unittests/optional-selftests.c: Fix common/ includes.
8164         * unittests/offset-type-selftests.c: Fix common/ includes.
8165         * unittests/observable-selftests.c: Fix common/ includes.
8166         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8167         * unittests/memrange-selftests.c: Fix common/ includes.
8168         * unittests/memory-map-selftests.c: Fix common/ includes.
8169         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8170         * unittests/function-view-selftests.c: Fix common/ includes.
8171         * unittests/environ-selftests.c: Fix common/ includes.
8172         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8173         * unittests/common-utils-selftests.c: Fix common/ includes.
8174         * unittests/cli-utils-selftests.c: Fix common/ includes.
8175         * unittests/array-view-selftests.c: Fix common/ includes.
8176         * ui-file.c: Fix common/ includes.
8177         * tui/tui-io.c: Fix common/ includes.
8178         * tracepoint.h: Fix common/ includes.
8179         * tracepoint.c: Fix common/ includes.
8180         * tracefile-tfile.c: Fix common/ includes.
8181         * top.h: Fix common/ includes.
8182         * top.c: Fix common/ includes.
8183         * thread.c: Fix common/ includes.
8184         * target/waitstatus.h: Fix common/ includes.
8185         * target/waitstatus.c: Fix common/ includes.
8186         * target.h: Fix common/ includes.
8187         * target.c: Fix common/ includes.
8188         * target-memory.c: Fix common/ includes.
8189         * target-descriptions.c: Fix common/ includes.
8190         * symtab.h: Fix common/ includes.
8191         * symfile.c: Fix common/ includes.
8192         * stap-probe.c: Fix common/ includes.
8193         * spu-linux-nat.c: Fix common/ includes.
8194         * sparc-nat.c: Fix common/ includes.
8195         * source.c: Fix common/ includes.
8196         * solib.c: Fix common/ includes.
8197         * solib-target.c: Fix common/ includes.
8198         * ser-unix.c: Fix common/ includes.
8199         * ser-tcp.c: Fix common/ includes.
8200         * ser-pipe.c: Fix common/ includes.
8201         * ser-base.c: Fix common/ includes.
8202         * selftest-arch.c: Fix common/ includes.
8203         * s12z-tdep.c: Fix common/ includes.
8204         * rust-exp.y: Fix common/ includes.
8205         * rs6000-aix-tdep.c: Fix common/ includes.
8206         * riscv-tdep.c: Fix common/ includes.
8207         * remote.c: Fix common/ includes.
8208         * remote-notif.h: Fix common/ includes.
8209         * remote-fileio.h: Fix common/ includes.
8210         * remote-fileio.c: Fix common/ includes.
8211         * regcache.h: Fix common/ includes.
8212         * regcache.c: Fix common/ includes.
8213         * record-btrace.c: Fix common/ includes.
8214         * python/python.c: Fix common/ includes.
8215         * python/py-type.c: Fix common/ includes.
8216         * python/py-inferior.c: Fix common/ includes.
8217         * progspace.h: Fix common/ includes.
8218         * producer.c: Fix common/ includes.
8219         * procfs.c: Fix common/ includes.
8220         * proc-api.c: Fix common/ includes.
8221         * printcmd.c: Fix common/ includes.
8222         * ppc-linux-nat.c: Fix common/ includes.
8223         * parser-defs.h: Fix common/ includes.
8224         * osdata.c: Fix common/ includes.
8225         * obsd-nat.c: Fix common/ includes.
8226         * nat/x86-linux.c: Fix common/ includes.
8227         * nat/x86-linux-dregs.c: Fix common/ includes.
8228         * nat/x86-dregs.h: Fix common/ includes.
8229         * nat/x86-dregs.c: Fix common/ includes.
8230         * nat/ppc-linux.c: Fix common/ includes.
8231         * nat/mips-linux-watch.h: Fix common/ includes.
8232         * nat/mips-linux-watch.c: Fix common/ includes.
8233         * nat/linux-waitpid.c: Fix common/ includes.
8234         * nat/linux-ptrace.h: Fix common/ includes.
8235         * nat/linux-ptrace.c: Fix common/ includes.
8236         * nat/linux-procfs.c: Fix common/ includes.
8237         * nat/linux-personality.c: Fix common/ includes.
8238         * nat/linux-osdata.c: Fix common/ includes.
8239         * nat/linux-namespaces.c: Fix common/ includes.
8240         * nat/linux-btrace.h: Fix common/ includes.
8241         * nat/linux-btrace.c: Fix common/ includes.
8242         * nat/fork-inferior.c: Fix common/ includes.
8243         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8244         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8245         * nat/aarch64-linux.c: Fix common/ includes.
8246         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8247         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8248         * namespace.h: Fix common/ includes.
8249         * mips-linux-tdep.c: Fix common/ includes.
8250         * minsyms.c: Fix common/ includes.
8251         * mi/mi-parse.h: Fix common/ includes.
8252         * mi/mi-main.c: Fix common/ includes.
8253         * mi/mi-cmd-env.c: Fix common/ includes.
8254         * memrange.h: Fix common/ includes.
8255         * memattr.c: Fix common/ includes.
8256         * maint.h: Fix common/ includes.
8257         * maint.c: Fix common/ includes.
8258         * main.c: Fix common/ includes.
8259         * machoread.c: Fix common/ includes.
8260         * location.c: Fix common/ includes.
8261         * linux-thread-db.c: Fix common/ includes.
8262         * linux-nat.c: Fix common/ includes.
8263         * linux-fork.c: Fix common/ includes.
8264         * inline-frame.c: Fix common/ includes.
8265         * infrun.c: Fix common/ includes.
8266         * inflow.c: Fix common/ includes.
8267         * inferior.h: Fix common/ includes.
8268         * inferior.c: Fix common/ includes.
8269         * infcmd.c: Fix common/ includes.
8270         * inf-ptrace.c: Fix common/ includes.
8271         * inf-child.c: Fix common/ includes.
8272         * ia64-linux-nat.c: Fix common/ includes.
8273         * i387-tdep.c: Fix common/ includes.
8274         * i386-tdep.c: Fix common/ includes.
8275         * i386-linux-tdep.c: Fix common/ includes.
8276         * i386-linux-nat.c: Fix common/ includes.
8277         * i386-go32-tdep.c: Fix common/ includes.
8278         * i386-fbsd-tdep.c: Fix common/ includes.
8279         * i386-fbsd-nat.c: Fix common/ includes.
8280         * guile/scm-type.c: Fix common/ includes.
8281         * guile/guile.c: Fix common/ includes.
8282         * go32-nat.c: Fix common/ includes.
8283         * gnu-nat.c: Fix common/ includes.
8284         * gdbthread.h: Fix common/ includes.
8285         * gdbarch-selftests.c: Fix common/ includes.
8286         * gdb_usleep.c: Fix common/ includes.
8287         * gdb_select.h: Fix common/ includes.
8288         * gdb_bfd.c: Fix common/ includes.
8289         * gcore.c: Fix common/ includes.
8290         * fork-child.c: Fix common/ includes.
8291         * findvar.c: Fix common/ includes.
8292         * fbsd-nat.c: Fix common/ includes.
8293         * event-top.c: Fix common/ includes.
8294         * event-loop.c: Fix common/ includes.
8295         * dwarf2read.c: Fix common/ includes.
8296         * dwarf2loc.c: Fix common/ includes.
8297         * dwarf2-frame.c: Fix common/ includes.
8298         * dwarf-index-cache.c: Fix common/ includes.
8299         * dtrace-probe.c: Fix common/ includes.
8300         * disasm-selftests.c: Fix common/ includes.
8301         * defs.h: Fix common/ includes.
8302         * csky-tdep.c: Fix common/ includes.
8303         * cp-valprint.c: Fix common/ includes.
8304         * cp-support.h: Fix common/ includes.
8305         * cp-support.c: Fix common/ includes.
8306         * corelow.c: Fix common/ includes.
8307         * completer.h: Fix common/ includes.
8308         * completer.c: Fix common/ includes.
8309         * compile/compile.c: Fix common/ includes.
8310         * compile/compile-loc2c.c: Fix common/ includes.
8311         * compile/compile-cplus-types.c: Fix common/ includes.
8312         * compile/compile-cplus-symbols.c: Fix common/ includes.
8313         * command.h: Fix common/ includes.
8314         * cli/cli-dump.c: Fix common/ includes.
8315         * cli/cli-cmds.c: Fix common/ includes.
8316         * charset.c: Fix common/ includes.
8317         * build-id.c: Fix common/ includes.
8318         * btrace.h: Fix common/ includes.
8319         * btrace.c: Fix common/ includes.
8320         * breakpoint.h: Fix common/ includes.
8321         * breakpoint.c: Fix common/ includes.
8322         * ax.h:
8323         (enum agent_op): Fix common/ includes.
8324         * ax-general.c (struct aop_map): Fix common/ includes.
8325         * ax-gdb.c: Fix common/ includes.
8326         * auxv.c: Fix common/ includes.
8327         * auto-load.c: Fix common/ includes.
8328         * arm-tdep.c: Fix common/ includes.
8329         * arch/riscv.c: Fix common/ includes.
8330         * arch/ppc-linux-common.c: Fix common/ includes.
8331         * arch/i386.c: Fix common/ includes.
8332         * arch/arm.c: Fix common/ includes.
8333         * arch/arm-linux.c: Fix common/ includes.
8334         * arch/arm-get-next-pcs.c: Fix common/ includes.
8335         * arch/amd64.c: Fix common/ includes.
8336         * arch/aarch64.c: Fix common/ includes.
8337         * arch/aarch64-insn.c: Fix common/ includes.
8338         * arch-utils.c: Fix common/ includes.
8339         * amd64-windows-tdep.c: Fix common/ includes.
8340         * amd64-tdep.c: Fix common/ includes.
8341         * amd64-sol2-tdep.c: Fix common/ includes.
8342         * amd64-obsd-tdep.c: Fix common/ includes.
8343         * amd64-nbsd-tdep.c: Fix common/ includes.
8344         * amd64-linux-tdep.c: Fix common/ includes.
8345         * amd64-linux-nat.c: Fix common/ includes.
8346         * amd64-fbsd-tdep.c: Fix common/ includes.
8347         * amd64-fbsd-nat.c: Fix common/ includes.
8348         * amd64-dicos-tdep.c: Fix common/ includes.
8349         * amd64-darwin-tdep.c: Fix common/ includes.
8350         * agent.c: Fix common/ includes.
8351         * ada-lang.h: Fix common/ includes.
8352         * ada-lang.c: Fix common/ includes.
8353         * aarch64-tdep.c: Fix common/ includes.
8354
8355 2019-01-25  Tom Tromey  <tom@tromey.com>
8356
8357         * common/create-version.sh: Use common/version.h.
8358
8359 2019-01-24  Pedro Alves  <palves@redhat.com>
8360
8361         * infrun.c (signal_stop, signal_print, signal_program)
8362         (signal_catch, signal_pass): Now arrays instead of pointers.
8363         (update_signals_program_target, do_target_resume)
8364         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8365         * linux-nat.c (linux_nat_target::pass_signals)
8366         (linux_nat_target::create_inferior, linux_nat_target::attach):
8367         Adjust.
8368         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8369         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8370         * procfs.c (procfs_target::pass_signals): Adjust.
8371         * record-full.c (record_full_target::resume): Adjust.
8372         * remote.c (remote_target::pass_signals)
8373         (remote_target::program_signals): Adjust.
8374         * target-debug.h (target_debug_print_signals): Now takes a
8375         gdb::array_view as parameter.  Adjust.
8376         * target.h (target_ops) <pass_signals, program_signals>: Replace
8377         pointer and length parameters with gdb::array_view.
8378         (target_pass_signals, target_program_signals): Likewise.
8379         * target-delegates.c: Regenerate.
8380
8381 2019-01-24  Pedro Alves  <palves@redhat.com>
8382
8383         * common/forward-scope-exit.h
8384         (forward_scope_exit::forward_scope_exit): Pass arguments to
8385         m_bind_function directly, instead of creating a std::bind and
8386         copying that.
8387
8388 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8389
8390         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8391         for static members.
8392         (pass_in_v_vfp_candidate): Likewise.
8393
8394 2019-01-23  Tom Tromey  <tom@tromey.com>
8395             Pedro Alves  <palves@redhat.com>
8396
8397         * regcache.c (class regcache_invalidator): Remove.
8398         (regcache::raw_write): Use make_scope_exit.
8399
8400 2019-01-23  Tom Tromey  <tom@tromey.com>
8401
8402         * ui-out.h (class ui_out_emit_type): Update comment.
8403
8404 2019-01-23  Tom Tromey  <tom@tromey.com>
8405
8406         * infrun.c (fetch_inferior_event): Update comment.
8407
8408 2019-01-23  Tom Tromey  <tom@tromey.com>
8409             Pedro Alves  <palves@redhat.com>
8410
8411         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8412         parameter.
8413         (fetch_inferior_event): Use SCOPE_EXIT.
8414
8415
8416 2019-01-23  Tom Tromey  <tom@tromey.com>
8417             Pedro Alves  <palves@redhat.com>
8418
8419         * infrun.c (disable_thread_events): Delete.
8420         (stop_all_threads): Use SCOPE_EXIT.
8421
8422 2019-01-23  Tom Tromey  <tom@tromey.com>
8423             Pedro Alves  <palves@redhat.com>
8424
8425         * symfile.c: Include forward-scope-exit.h.
8426         (clear_symtab_users_cleanup): Replace forward declaration with
8427         a FORWARD_SCOPE_EXIT.
8428         (syms_from_objfile_1): Use the forward_scope_exit and
8429         gdb::optional instead of cleanup_function.
8430         (reread_symbols): Use the forward_scope_exit instead of
8431         cleanup_function.
8432         (clear_symtab_users_cleanup): Remove function.
8433
8434 2019-01-23  Tom Tromey  <tom@tromey.com>
8435             Pedro Alves  <palves@redhat.com>
8436
8437         * linux-nat.c: Include scope-exit.h.
8438         (cleanup_target_stop): Remove.
8439         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8440         SCOPE_EXIT.
8441
8442 2019-01-23  Tom Tromey  <tom@tromey.com>
8443             Pedro Alves  <palves@redhat.com>
8444
8445         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8446         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8447
8448 2019-01-23  Tom Tromey  <tom@tromey.com>
8449             Andrew Burgess  <andrew.burgess@embecosm.com>
8450             Pedro Alves  <palves@redhat.com>
8451
8452         * infrun.c (fetch_inferior_event): Use scope_exit.
8453         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8454         * top.c (execute_command): Use scope_exit.
8455         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8456         * utils.c (do_bpstat_clear_actions_cleanup)
8457         (make_bpstat_clear_actions_cleanup): Remove.
8458
8459 2019-01-23  Tom Tromey  <tom@tromey.com>
8460             Pedro Alves  <palves@redhat.com>
8461
8462         * infrun.c: Include "common/scope-exit.h"
8463         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8464         (wait_for_inferior): Use SCOPE_EXIT.
8465         (fetch_inferior_event): Use scope_exit.
8466
8467 2019-01-23  Tom Tromey  <tom@tromey.com>
8468             Pedro Alves  <palves@redhat.com>
8469
8470         * breakpoint.c (create_breakpoint): Remove cleanup.
8471
8472 2019-01-23  Tom Tromey  <tom@tromey.com>
8473             Andrew Burgess  <andrew.burgess@embecosm.com>
8474             Pedro Alves  <palves@redhat.com>
8475
8476 2019-01-23  Pedro Alves  <palves@redhat.com>
8477
8478         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8479
8480 2019-01-23  Pedro Alves  <palves@redhat.com>
8481             Andrew Burgess  <andrew.burgess@embecosm.com>
8482
8483         * gdbthread.h: Include "common/forward-scope-exit.h".
8484         (scoped_finish_thread_state): Redefine custom class in terms of
8485         forward_scope_exit.
8486
8487 2019-01-23  Pedro Alves  <palves@redhat.com>
8488             Andrew Burgess  <andrew.burgess@embecosm.com>
8489
8490         * common/forward-scope-exit.h: New file.
8491
8492 2019-01-23  Pedro Alves  <palves@redhat.com>
8493             Andrew Burgess  <andrew.burgess@embecosm.com>
8494             Tom Tromey  <tom@tromey.com>
8495
8496         * common/scope-exit.h: New file.
8497
8498 2019-01-23  Pedro Alves  <palves@redhat.com>
8499
8500         * common/preprocessor.h (ESC): Rename to ...
8501         (ESC_PARENS): ... this.
8502         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8503         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8504
8505 2019-01-23  Tom Tromey  <tom@tromey.com>
8506
8507         * language.h (class scoped_switch_to_sym_language_if_auto):
8508         Initialize m_lang in both cases.
8509
8510 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8511
8512         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8513         with XCNEW.
8514
8515 2019-01-22  Tom Tromey  <tom@tromey.com>
8516
8517         * corelow.c: Do not include sys/file.h.
8518
8519 2019-01-22  Tom Tromey  <tom@tromey.com>
8520
8521         * tui/tui-wingeneral.h: Include gdb_curses.h.
8522
8523 2019-01-22  Tom Tromey  <tom@tromey.com>
8524
8525         * source-cache.h (class source_cache) <get_source_lines,
8526         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8527
8528 2019-01-22  Tom Tromey  <tom@tromey.com>
8529
8530         * remote-fileio.h (struct remote_target): Declare.
8531
8532 2019-01-22  Tom Tromey  <tom@tromey.com>
8533
8534         * python/py-arch.c: Do not include py-ref.h.
8535         * python/py-bpevent.c: Do not include py-ref.h.
8536         * python/py-cmd.c: Do not include py-ref.h.
8537         * python/py-continueevent.c: Do not include py-ref.h.
8538         * python/py-event.h: Do not include py-ref.h.
8539         * python/py-evtregistry.c: Do not include py-ref.h.
8540         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8541         * python/py-frame.c: Do not include py-ref.h.
8542         * python/py-framefilter.c: Do not include py-ref.h.
8543         * python/py-function.c: Do not include py-ref.h.
8544         * python/py-infevents.c: Do not include py-ref.h.
8545         * python/py-linetable.c: Do not include py-ref.h.
8546         * python/py-objfile.c: Do not include py-ref.h.
8547         * python/py-param.c: Do not include py-ref.h.
8548         * python/py-prettyprint.c: Do not include py-ref.h.
8549         * python/py-progspace.c: Do not include py-ref.h.
8550         * python/py-symbol.c: Do not include py-ref.h.
8551         * python/py-symtab.c: Do not include py-ref.h.
8552         * python/py-type.c: Do not include py-ref.h.
8553         * python/py-unwind.c: Do not include py-ref.h.
8554         * python/py-utils.c: Do not include py-ref.h.
8555         * python/py-value.c: Do not include py-ref.h.
8556         * python/py-varobj.c: Do not include py-ref.h.
8557         * python/py-xmethods.c: Do not include py-ref.h.
8558         * python/python.c: Do not include py-ref.h.
8559         * varobj.c: Do not include py-ref.h.
8560
8561 2019-01-22  Tom Tromey  <tom@tromey.com>
8562
8563         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8564         keyword for bcache.
8565
8566 2019-01-22  Tom Tromey  <tom@tromey.com>
8567
8568         * compile/compile-cplus-types.c: Remove a comment by #include.
8569
8570 2019-01-22  Tom Tromey  <tom@tromey.com>
8571
8572         * compile/gcc-c-plugin.h: Include compile-internal.h.
8573
8574 2019-01-22  Tom Tromey  <tom@tromey.com>
8575
8576         * stabsread.c (EXTERN): Do not define.
8577         (symnum, next_symbol_text_func, processing_gcc_compilation)
8578         (within_function, global_sym_chain, global_stabs)
8579         (previous_stab_code, this_object_header_files)
8580         (n_this_object_header_files)
8581         (n_allocated_this_object_header_files): Define.
8582         * stabsread.h (EXTERN): Never define.  Use "extern".
8583
8584 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8585
8586         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8587         history_value.
8588
8589 2019-01-21  Tom Tromey  <tom@tromey.com>
8590
8591         * ui-out.c: Fix includes.
8592         * tui/tui-source.c: Fix includes.
8593         * target.c: Fix includes.
8594         * remote.c: Fix includes.
8595         * regcache.c: Fix includes.
8596         * python/py-block.c: Fix includes.
8597         * printcmd.c: Fix includes.
8598         * or1k-tdep.c: Fix includes.
8599         * mi/mi-main.c: Fix includes.
8600         * m32r-tdep.c: Fix includes.
8601         * csky-tdep.c: Fix includes.
8602         * compile/compile-cplus-types.c: Fix includes.
8603         * cli/cli-interp.c: Fix includes.
8604
8605 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8606
8607         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8608         for padding.
8609
8610 2019-01-16  Tom Tromey  <tom@tromey.com>
8611
8612         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8613         earlier.
8614         (struct objfile) <msymbols_range>: Move from top level.
8615         <msymbols>: New method.
8616         (class objfile_msymbols): Remove.
8617         * symtab.c (default_collect_symbol_completion_matches_break_on):
8618         Update.
8619         * symmisc.c (dump_msymbols): Update.
8620         * stabsread.c (scan_file_globals): Update.
8621         * objc-lang.c (info_selectors_command, info_classes_command)
8622         (find_methods): Update.
8623         * minsyms.c (find_solib_trampoline_target): Update.
8624         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8625         * coffread.c (coff_symfile_read): Update.
8626         * ada-lang.c (ada_lookup_simple_minsym)
8627         (ada_collect_symbol_completion_matches): Update.
8628
8629 2019-01-16  Tom Tromey  <tom@tromey.com>
8630
8631         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8632         type.  Remove no-argument constructor.
8633         <iterator::operator++>: Simplify.
8634         <begin>: Update.
8635         <end>: Use minimal_symbol_count.
8636
8637 2019-01-16  Tom Tromey  <tom@tromey.com>
8638
8639         * objfiles.h (struct objfile) <psymtabs>: New method.
8640         (class objfile_psymtabs): Remove.
8641         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8642         typedef.
8643         <range>: New method.
8644         (require_partial_symbols): Change return type.
8645         * psymtab.c (require_partial_symbols)
8646         (psym_expand_symtabs_matching): Update.
8647         * mdebugread.c (parse_partial_symbols): Update.
8648         * dbxread.c (dbx_end_psymtab): Update.
8649
8650 2019-01-15  Tom Tromey  <tom@tromey.com>
8651
8652         * symtab.c (lookup_objfile_from_block)
8653         (lookup_symbol_in_objfile_symtabs)
8654         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8655         (find_line_symtab, info_sources_command)
8656         (default_collect_symbol_completion_matches_break_on)
8657         (make_source_files_completion_list): Update.
8658         * symmisc.c (print_objfile_statistics, dump_objfile)
8659         (maintenance_print_symbols, maintenance_info_symtabs)
8660         (maintenance_check_symtabs, maintenance_info_line_tables):
8661         Update.
8662         * source.c (select_source_symtab)
8663         (forget_cached_source_info_for_objfile): Update.
8664         * objfiles.h (class objfile_compunits): Remove.
8665         (struct objfile) <compunits_range>: New typedef.
8666         (compunits): New method.
8667         * objfiles.c (objfile_relocate1): Update.
8668         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8669         * maint.c (count_symtabs_and_blocks): Update.
8670         * linespec.c (iterate_over_all_matching_symtabs): Update.
8671         * cp-support.c (add_symbol_overload_list_qualified): Update.
8672         * coffread.c (coff_symtab_read): Update.
8673         * ada-lang.c (add_nonlocal_symbols)
8674         (ada_collect_symbol_completion_matches)
8675         (ada_add_global_exceptions): Update.
8676
8677 2019-01-15  Tom Tromey  <tom@tromey.com>
8678
8679         * progspace.h (program_space) <objfiles_safe_range>: New
8680         typedef.
8681         <objfiles_safe>: New method.
8682         * objfiles.h (class all_objfiles_safe): Remove.
8683         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8684         * jit.c (jit_inferior_exit_hook): Update.
8685
8686 2019-01-17  Tom Tromey  <tom@tromey.com>
8687
8688         * progspace.h (program_space) <objfiles_range>: New typedef.
8689         <objfiles>: New method.
8690         <objfiles_head>: Rename from objfiles.
8691         (object_files): Update.
8692         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8693         * guile/scm-pretty-print.c
8694         (ppscm_find_pretty_printer_from_objfiles): Update.
8695         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8696         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8697         Update.
8698         * python/py-progspace.c (pspy_get_objfiles): Update.
8699         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8700         Update.
8701         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8702         (objfpy_lookup_objfile_by_build_id): Update.
8703         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8704         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8705         Update.
8706         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8707         (expand_symtab_containing_pc, lookup_objfile_from_block)
8708         (lookup_static_symbol, basic_lookup_transparent_type)
8709         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8710         (find_line_symtab, info_sources_command)
8711         (default_collect_symbol_completion_matches_break_on)
8712         (make_source_files_completion_list, find_main_name): Update.
8713         * symmisc.c (print_symbol_bcache_statistics)
8714         (print_objfile_statistics, maintenance_print_symbols)
8715         (maintenance_print_msymbols, maintenance_print_objfiles)
8716         (maintenance_info_symtabs, maintenance_check_symtabs)
8717         (maintenance_expand_symtabs, maintenance_info_line_tables):
8718         Update.
8719         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8720         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8721         (map_overlay_command, unmap_overlay_command)
8722         (simple_overlay_update, expand_symtabs_matching)
8723         (map_symbol_filenames): Update.
8724         * symfile-debug.c (set_debug_symfile): Update.
8725         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8726         Update.
8727         * source.c (select_source_symtab, forget_cached_source_info):
8728         Update.
8729         * solib.c (solib_read_symbols): Update.
8730         * solib-spu.c (append_ocl_sos): Update.
8731         * psymtab.c (maintenance_print_psymbols)
8732         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8733         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8734         * printcmd.c (info_symbol_command): Update.
8735         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8736         Update.
8737         * objfiles.h (class all_objfiles): Remove.
8738         * objfiles.c (have_partial_symbols, have_full_symbols)
8739         (have_minimal_symbols, qsort_cmp, update_section_map)
8740         (shared_objfile_contains_address_p)
8741         (default_iterate_over_objfiles_in_search_order): Update.
8742         * objc-lang.c (info_selectors_command, info_classes_command)
8743         (find_methods): Update.
8744         * minsyms.c (find_solib_trampoline_target): Update.
8745         * maint.c (maintenance_info_sections)
8746         (maintenance_translate_address, count_symtabs_and_blocks):
8747         Update.
8748         * main.c (captured_main_1): Update.
8749         * linux-thread-db.c (try_thread_db_load_from_pdir)
8750         (has_libpthread): Update.
8751         * linespec.c (iterate_over_all_matching_symtabs)
8752         (search_minsyms_for_name): Update.
8753         * jit.c (jit_find_objf_with_entry_addr): Update.
8754         * hppa-tdep.c (find_unwind_entry)
8755         (hppa_lookup_stub_minimal_symbol): Update.
8756         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8757         Update.
8758         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8759         (elf_gnu_ifunc_resolve_by_got): Update.
8760         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8761         * dwarf-index-write.c (save_gdb_index_command): Update.
8762         * cp-support.c (add_symbol_overload_list_qualified): Update.
8763         * breakpoint.c (create_overlay_event_breakpoint)
8764         (create_longjmp_master_breakpoint)
8765         (create_std_terminate_master_breakpoint)
8766         (create_exception_master_breakpoint): Update.
8767         * blockframe.c (find_pc_partial_function): Update.
8768         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8769         (ada_collect_symbol_completion_matches)
8770         (ada_add_global_exceptions): Update.
8771
8772 2019-01-17  Tom Tromey  <tom@tromey.com>
8773
8774         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8775         declare VEC.
8776         (solib_target_parse_libraries): Change return type.
8777         (library_list_start_segment, library_list_start_section)
8778         (library_list_end_library, library_list_start_library); Update.
8779         (solib_target_free_library_list): Remove.
8780         (solib_target_parse_libraries): Remove cleanup.  Change return
8781         type.
8782         (solib_target_current_sos): Update.
8783
8784 2019-01-17  Tom Tromey  <tromey@bapiya>
8785
8786         * valprint.c: Replace "the the" with "the".
8787         * symtab.c: Replace "the the" with "the".
8788         * solib.c: Replace "the the" with "the".
8789         * solib-dsbt.c: Replace "the the" with "the".
8790         * linespec.c: Replace "the the" with "the".
8791         * dwarf2loc.h: Replace "the the" with "the".
8792         * amd64-windows-tdep.c: Replace "the the" with "the".
8793         * aarch64-tdep.c: Replace "the the" with "the".
8794
8795 2019-01-16  Keith Seitz  <keiths@redhat.com>
8796
8797         PR gdb/23773
8798         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8799         <builder>: Rename to ..
8800         <m_builder>: ... this and make private.
8801         (dwarf2_cu::get_builder): New method.  Change all users of
8802         `builder' to use this method.
8803         (dwarf2_start_symtab): Move to ...
8804         (dwarf2_cu::start_symtab): ... here.  Update all callers
8805         (setup_type_unit_groups): Move to ...
8806         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8807         callers.
8808         (dwarf2_cu::reset_builder): New method.
8809         (process_full_compunit, process_full_type_unit): Use
8810         dwarf2_cu::reset_builder.
8811         (follow_die_offset): Record the ancestor CU if it is different
8812         from the followed DIE's CU.
8813         (follow_die_sig_1): Likewise.
8814
8815 2019-01-15  Tom Tromey  <tom@tromey.com>
8816
8817         * remote.c (class remote_state) <buf>: Now a char_vector.
8818         <buf_size>: Remove.
8819         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8820         parameter.
8821         (remote_target::getpkt_or_notif_sane_1)
8822         (remote_target::getpkt_sane)
8823         (remote_target::getpkt_or_notif_sane): Likewise.
8824         (class remote_target) <putpkt>: New overload.
8825         (remote_target::read_frame): Change type of "buf_p".  Remove
8826         sizeof_p parameter.
8827         (packet_ok): New overload.
8828         (packet_check_result): New overload.
8829         Update all uses.
8830
8831 2019-01-14  Tom Tromey  <tom@tromey.com>
8832
8833         * remote-notif.c (handle_notification, remote_notif_ack)
8834         (remote_notif_parse): Make "buf" const.
8835         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8836         const.
8837         (remote_notif_parse, remote_notif_ack, handle_notification):
8838         Likewise.
8839         * remote.c (remote_notif_stop_parse): Make "buf" const.
8840         (remote_target::remote_parse_stop_reply): Make "buf" const.
8841         (remote_notif_stop_ack): Make "buf" const.
8842
8843 2019-01-14  Tom Tromey  <tom@tromey.com>
8844
8845         * remote.c (remote_console_output): Make parameter const.
8846
8847 2019-01-14  Tom Tromey  <tom@tromey.com>
8848
8849         * target-debug.h (target_debug_print_signals): Constify.
8850         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8851         * procfs.c (procfs_target::pass_signals): Update.
8852         * linux-nat.c (linux_nat_target::pass_signals): Update.
8853         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8854         * target-delegates.c: Rebuild.
8855         * remote.c (remote_target::program_signals): Update.
8856         (remote_target::pass_signals): Update.
8857         * target.c (target_pass_signals): Constify argument.
8858         (target_program_signals): Likewise.
8859         * target.h (struct target_ops) <pass_signals, program_signals>:
8860         Constify argument.
8861         (target_pass_signals, target_program_signals): Constify argument.
8862
8863 2019-01-14  Tom Tromey  <tom@tromey.com>
8864
8865         PR tui/28819:
8866         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8867
8868 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8869
8870         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8871         field.
8872         * rs6000-tdep.c: Include reggroups.h.
8873         (IS_V_ALIAS_PSEUDOREG): Define.
8874         (rs6000_register_name): Return names for the "vX" aliases.
8875         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8876         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8877         aliases.  Call default_register_reggroup_p for all other
8878         pseudo-registers.
8879         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8880         New functions.
8881         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8882         Handle "vX" aliases.
8883         (v_alias_pseudo_register_collect): New function.
8884         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8885         (rs6000_gdbarch_init): Initialize "vX" aliases as
8886         pseudo-registers.  Restore registration of
8887         rs6000_pseudo_register_reggroup_p with
8888         set_tdesc_pseudo_register_reggroup_p.
8889
8890 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8891
8892         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8893         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8894         set_gdbarch_num_pseudo_regs.
8895
8896 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8897
8898         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8899         Remove arg prefixname, add do_set and do_show.
8900         Add member functions set_list and show_list.
8901         * cli/cli-style.c (class cli_style_option): Update accordingly.
8902         (style_set_list): Move to file scope.
8903         (style_show_list): Likewise.
8904         (set_style): Call help_list.
8905         (show_style): Call cmd_show_list.
8906         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8907         Update to use the new macro.
8908
8909 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8910
8911         * ada-lang.c (_initialize_ada_language): Expand the help text
8912         for the "catch exception" command.
8913
8914 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8915
8916         * symtab.c (matching_obj_sections): Initialize obj,
8917         declare it closer to its usage.
8918
8919 2019-01-10  Tom Tromey  <tom@tromey.com>
8920
8921         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8922         (basic_inf_threads_range): Remove.
8923         (inf_threads_range, inf_non_exited_threads_range)
8924         (safe_inf_threads_range): Use next_adapter.
8925
8926 2019-01-10  Keith Seitz  <keiths@redhat.com>
8927
8928         PR gdb/23712
8929         PR symtab/23010
8930         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8931         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8932
8933 2019-01-10  Keith Seitz  <keiths@redhat.com>
8934
8935         PR gdb/23712
8936         PR symtab/23010
8937         * dictionary.c (pending_to_vector): Remove.
8938         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8939         Remove _1 suffix, replacing functions of the same name.  Update
8940         all callers.
8941         (dict_create_hashed, dict_create_hashed_expandable)
8942         (dict_create_linear, dict_create_linear_expandable, dict_free)
8943         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8944         Make functions static.
8945
8946 2019-01-10  Keith Seitz  <keiths@redhat.com>
8947
8948         PR gdb/23712
8949         PR symtab/23010
8950         * dictionary.h (struct dictionary): Replace declaration with
8951         multidictionary.
8952         (dict_create_hashed, dict_create_hashed_expandable)
8953         (dict_create_linear, dict_create_linear_expandable)
8954         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8955         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8956         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8957         taking multidictionary argument.
8958         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8959         * block.h (struct block) <dict>: Change to multidictionary
8960         and rename `multidict'.
8961         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8962         symmisc.c: Update all dictionary references to multidictionary.
8963
8964 2019-01-10  Keith Seitz  <keiths@redhat.com>
8965
8966         PR gdb/23712
8967         PR symtab/23010
8968         * dictionary.c: Include unordered_map.
8969         (pending_to_vector): New function.
8970         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8971         Rewrite the non-"_1" functions to take vector instead
8972         of linked list.
8973         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8974         "new" _1 versions of the same name.
8975         (multidictionary): Define.
8976         (std::hash<enum language): New definition.
8977         (collate_pending_symbols_by_language, mdict_create_hashed)
8978         (mdict_create_hashed_expandable, mdict_create_linear)
8979         (mdict_create_linear_expandable, mdict_free)
8980         (find_language_dictionary, create_new_language_dictionary)
8981         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8982         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8983         (mdict_size, mdict_empty): New functions.
8984         * dictionary.h (mdict_iterator): Define.
8985
8986 2019-01-10  Pedro Alves  <palves@redhat.com>
8987
8988         * breakpoint.c (read_uploaded_action)
8989         (create_tracepoint_from_upload): Adjust to use
8990         gdb::unique_xmalloc_ptr.
8991         * ctf.c (ctf_write_uploaded_tp):
8992         (SET_ARRAY_FIELD): Use emplace_back.
8993         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8994         * tracefile-tfile.c (tfile_write_uploaded_tp):
8995         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8996         gdb::unique_xmalloc_ptr.
8997         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8998         at_string, cond_string, cmd_strings>: Replace char pointers
8999         with gdb::unique_xmalloc_ptr.
9000
9001 2019-01-10  Pedro Alves  <palves@redhat.com>
9002
9003         * solib-target.c (library_list_start_library): Don't xstrdup name.
9004
9005 2019-01-10  Pedro Alves  <palves@redhat.com>
9006
9007         * mdebugread.c (parse_partial_symbols): Use
9008         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9009
9010 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9011
9012         * linux-fork.c (scoped_switch_fork_info)
9013         <~scoped_switch_fork_info>: Fix incorrect variable name.
9014
9015 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9016
9017         * linux-fork.c (scoped_switch_fork_info)
9018         <scoped_switch_fork_info>: Make explicit.
9019         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9020
9021 2019-01-10  Tom Tromey  <tom@tromey.com>
9022
9023         * objfiles.h (objfile::reset_psymtabs): Update.
9024         * objfiles.c (objfile::objfile): Update.
9025         * psymtab.h (psymtab_storage::obstack): Update.
9026         (psymtab_storage::m_obstack): Use gdb::optional.
9027         (class psymtab_storage): Update comment.  Remove objfile
9028         parameter.
9029         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9030
9031 2019-01-10  Tom Tromey  <tom@tromey.com>
9032
9033         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9034         <free_psymtabs>: Now private.
9035         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9036         (allocate_psymtab): Use new method.
9037
9038 2019-01-10  Tom Tromey  <tom@tromey.com>
9039
9040         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9041         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9042         * mdebugread.c (parse_partial_symbols): Use
9043         allocate_dependencies.
9044         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9045         allocate_dependencies.
9046         (process_psymtab_comp_unit_reader)
9047         (build_type_psymtab_dependencies): Likewise.
9048         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9049
9050 2019-01-10  Tom Tromey  <tom@tromey.com>
9051
9052         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9053         PSYMBOL_SET_LANGUAGE.
9054         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9055
9056 2019-01-10  Tom Tromey  <tom@tromey.com>
9057
9058         * psymtab.h (psymtab_storage::obstack): New method.
9059         <m_obstack>: Rename from obstack; now private.
9060         * psymtab.c (psymtab_storage): Update.
9061         * dwarf2read.c (create_addrmap_from_index)
9062         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9063         Update.
9064
9065 2019-01-10  Tom Tromey  <tom@tromey.com>
9066
9067         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9068         * objfiles.h (objfile::reset_psymtabs): New method.
9069
9070 2019-01-10  Tom Tromey  <tom@tromey.com>
9071
9072         * symmisc.c (print_symbol_bcache_statistics): Update.
9073         (print_objfile_statistics): Update.
9074         * symfile.c (reread_symbols): Update.
9075         * psymtab.h (class psymtab_storage): New.
9076         * psymtab.c (psymtab_storage): New constructor.
9077         (~psymtab_storage): New destructor.
9078         (require_partial_symbols): Update.
9079         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9080         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9081         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9082         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9083         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9084         (start_psymtab_common, end_psymtab_common)
9085         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9086         (allocate_psymtab): Update.
9087         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9088         Update.
9089         (dump_psymtab_addrmap, maintenance_print_psymbols)
9090         (maintenance_check_psymtabs): Update.
9091         (class objfile_psymtabs): Move to objfiles.h.
9092         * psympriv.h (discard_psymtab): Now inline.
9093         (psymtab_discarder::psymtab_discarder): Update.
9094         (psymtab_discarder::~psymtab_discarder): Update.
9095         (ALL_OBJFILE_PSYMTABS): Rewrite.
9096         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9097         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9098         Remove fields.
9099         <partial_symtabs>: New field.
9100         (class objfile_psymtabs): Move from psymtab.h.  Update.
9101         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9102         psymbol_cache.
9103         (objfile::~objfile): Don't destroy psymbol_cache.
9104         * mdebugread.c (parse_partial_symbols): Update.
9105         * dwarf2read.c (create_addrmap_from_index)
9106         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9107         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9108         (add_partial_subprogram, dwarf2_ranges_read): Update.
9109         * dwarf-index-write.c (write_address_map)
9110         (write_one_signatured_type, recursively_write_psymbols)
9111         (class debug_names, class debug_names, write_psymtabs_to_index):
9112         Update.
9113
9114 2019-01-10  Tom Tromey  <tom@tromey.com>
9115
9116         * symtab.h (SYMBOL_SET_NAMES): Update.
9117         (symbol_set_names): Update.
9118         (MSYMBOL_SET_NAMES): Update.
9119         * symtab.c (symbol_set_names): Change argument to be an
9120         objfile_per_bfd_storage.
9121         * psymtab.c (add_psymbol_to_bcache): Update.
9122         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9123
9124 2019-01-10  Tom Tromey  <tom@tromey.com>
9125
9126         * symtab.c (create_demangled_names_hash): Change argument to be an
9127         objfile_per_bfd_storage.
9128         (symbol_set_names): Update.
9129
9130 2019-01-10  Tom Tromey  <tom@tromey.com>
9131
9132         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9133         init_psymbol_list.
9134         * psymtab.c (init_psymbol_list): Do nothing if already called.
9135         * psympriv.h (init_psymbol_list): Add comment.
9136         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9137         init_psymbol_list.
9138         * dbxread.c (dbx_symfile_read): Unconditionally call
9139         init_psymbol_list.
9140
9141 2019-01-10  Tom Tromey  <tom@tromey.com>
9142
9143         * xcoffread.c (scan_xcoff_symtab): Update.
9144         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9145         "where".
9146         * mdebugread.c (parse_partial_symbols)
9147         (handle_psymbol_enumerators): Update.
9148         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9149         * dbxread.c (read_dbx_symtab): Update.
9150         * psympriv.h (psymbol_placement): New enum.
9151         (add_psymbol_to_list): Update.
9152
9153 2019-01-10  Tom Tromey  <tom@tromey.com>
9154
9155         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9156         static_psymbols parameters.
9157         (scan_xcoff_symtab): Update.
9158         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9159         static_psymbols parameters.
9160         * psympriv.h (start_psymtab_common): Update.
9161         * mdebugread.c (parse_partial_symbols): Update.
9162         * dwarf2read.c (create_partial_symtab): Update.
9163         * dbxread.c (read_dbx_symtab): Update.
9164         (start_psymtab): Remove global_psymbols and static_psymbols
9165         parameters.
9166
9167 2019-01-10  Tom Tromey  <tom@tromey.com>
9168
9169         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9170         * psymtab.c (allocate_psymtab): Add comment.
9171         * psympriv.h (allocate_psymtab): Add comment.
9172         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9173         initializations.
9174         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9175
9176 2019-01-10  Tom Tromey  <tom@tromey.com>
9177
9178         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9179         Don't declare.
9180         * mipsread.c: Include mdebugread.h.
9181         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9182         Declare.
9183         * elfread.c: Include mdebugread.h.
9184
9185 2019-01-09  Tom Tromey  <tom@tromey.com>
9186
9187         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9188         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9189         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9190         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9191         (psym_lookup_symbol, psym_find_last_source_symtab)
9192         (psym_forget_cached_source_info, psym_print_stats)
9193         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9194         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9195         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9196         (psym_find_compunit_symtab_by_address)
9197         (maintenance_print_psymbols, maintenance_info_psymtabs)
9198         (maintenance_check_psymtabs): Use ranged for.
9199         * psymtab.h (class objfile_psymtabs): New.
9200         (require_partial_symbols): Return objfile_psymtabs.
9201         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9202
9203 2019-01-09  Tom Tromey  <tom@tromey.com>
9204
9205         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9206         (find_pc_mapped_section, list_overlays_command)
9207         (map_overlay_command, unmap_overlay_command)
9208         (simple_overlay_update): Use all_objfiles.
9209         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9210         * printcmd.c (info_symbol_command): Use all_objfiles.
9211         * objfiles.h (ALL_OBJSECTIONS): Remove.
9212         * maint.c (maintenance_translate_address): Use all_objfiles.
9213         * gcore.c (gcore_create_callback): Use all_objfiles.
9214         (objfile_find_memory_regions): Likewise.
9215
9216 2019-01-09  Tom Tromey  <tom@tromey.com>
9217
9218         * symtab.c (find_line_symtab, info_sources_command)
9219         (make_source_files_completion_list): Use objfile_compunits.
9220         * source.c (select_source_symtab): Use objfile_compunits.
9221         * objfiles.h (struct objfile): Update comment.
9222         (ALL_OBJFILES): Remove.
9223         (ALL_FILETABS): Remove.
9224         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9225         objfile_compunits.
9226
9227 2019-01-09  Tom Tromey  <tom@tromey.com>
9228
9229         * symmisc.c (print_objfile_statistics, dump_objfile)
9230         (maintenance_print_symbols): Use compunit_filetabs.
9231         * source.c (forget_cached_source_info_for_objfile): Use
9232         compunit_filetabs.
9233         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9234         (ALL_FILETABS): Use compunit_filetabs.
9235         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9236         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9237
9238 2019-01-09  Tom Tromey  <tom@tromey.com>
9239
9240         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9241         (compunit_filetabs): New.
9242         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9243         compunit_filetabs.
9244         (info_sources_command, make_source_files_completion_list): Remove
9245         declaration.
9246         * symmisc.c (print_objfile_statistics, dump_objfile)
9247         (maintenance_print_symbols): Remove declaration.
9248         (maintenance_info_symtabs): Use compunit_filetabs.
9249         (maintenance_info_line_tables): Likewise.
9250         * source.c (select_source_symtab): Change local variable name.
9251         (forget_cached_source_info_for_objfile): Remove declaration.
9252         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9253         * objfiles.c (objfile_relocate1): Remove declaration.
9254         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9255         declaration.
9256         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9257         * coffread.c (coff_symtab_read): Remove declaration.
9258         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9259         compunit_filetabs.
9260
9261 2019-01-09  Tom Tromey  <tom@tromey.com>
9262
9263         * symtab.c (lookup_objfile_from_block)
9264         (find_pc_sect_compunit_symtab, search_symbols)
9265         (default_collect_symbol_completion_matches_break_on): Use
9266         objfile_compunits.
9267         * objfiles.h (ALL_COMPUNITS): Remove.
9268         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9269         * cp-support.c (add_symbol_overload_list_qualified): Use
9270         objfile_compunits.
9271         * ada-lang.c (ada_collect_symbol_completion_matches)
9272         (ada_add_global_exceptions): Use objfile_compunits.
9273
9274 2019-01-09  Tom Tromey  <tom@tromey.com>
9275
9276         * source.c (select_source_symtab)
9277         (forget_cached_source_info_for_objfile): Remove declaration.
9278         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9279         declaration.
9280         * maint.c (count_symtabs_and_blocks): Remove declaration.
9281         * cp-support.c (add_symbol_overload_list_qualified): Remove
9282         declaration.
9283         * coffread.c (coff_symtab_read): Remove declaration.
9284         * symtab.c (lookup_symbol_in_objfile_symtabs)
9285         (basic_lookup_transparent_type_1): Use objfile_compunits.
9286         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9287         (info_sources_command, search_symbols)
9288         (default_collect_symbol_completion_matches_break_on)
9289         (make_source_files_completion_list): Remove declaration.
9290         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9291         (ada_collect_symbol_completion_matches)
9292         (ada_add_global_exceptions): Remove declaration.
9293         * linespec.c (iterate_over_all_matching_symtabs): Use
9294         objfile_compunits.
9295         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9296         (class objfile_compunits): New.
9297         (ALL_COMPUNITS): Use objfile_compunits.
9298         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9299         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9300         objfile_compunits.
9301         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9302
9303 2019-01-09  Tom Tromey  <tom@tromey.com>
9304
9305         * symtab.c (search_symbols)
9306         (default_collect_symbol_completion_matches_break_on): Use
9307         objfile_msymbols.
9308         * ada-lang.c (ada_lookup_simple_minsym)
9309         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9310         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9311         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9312         objfile_msymbols.
9313         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9314         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9315         * objc-lang.c (find_methods): Use objfile_msymbols.
9316         (info_selectors_command, info_classes_command): Likewise.
9317         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9318         * objfiles.h (class objfile_msymbols): New.
9319         (ALL_OBJFILE_MSYMBOLS): Remove.
9320         (ALL_MSYMBOLS): Remove.
9321
9322 2019-01-09  Tom Tromey  <tom@tromey.com>
9323
9324         * common/next-iterator.h (next_adapter): Add Iterator template
9325         parameter.
9326         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9327         (class all_objfiles_safe): New.
9328         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9329         * objfiles.c (put_objfile_before): Update comment.
9330         (add_separate_debug_objfile): Likewise.
9331         (free_all_objfiles): Use all_objfiles_safe.
9332         (objfile_purge_solibs): Likewise.
9333
9334 2019-01-09  Tom Tromey  <tom@tromey.com>
9335
9336         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9337         (expand_symtab_containing_pc, lookup_static_symbol)
9338         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9339         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9340         all_objfiles.
9341         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9342         * breakpoint.c (create_overlay_event_breakpoint)
9343         (create_longjmp_master_breakpoint)
9344         (create_std_terminate_master_breakpoint)
9345         (create_exception_master_breakpoint): Use all_objfiles.
9346         * linux-thread-db.c (try_thread_db_load_from_pdir)
9347         (has_libpthread): Use all_objfiles.
9348         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9349         * linespec.c (iterate_over_all_matching_symtabs)
9350         (search_minsyms_for_name): Use all_objfiles.
9351         * maint.c (maintenance_info_sections): Use all_objfiles.
9352         * main.c (captured_main_1): Use all_objfiles.
9353         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9354         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9355         * guile/scm-pretty-print.c
9356         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9357         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9358         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9359         (maintenance_print_msymbols): Use all_objfiles.
9360         * source.c (select_source_symtab): Use all_objfiles.
9361         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9362         * symfile.c (remove_symbol_file_command)
9363         (expand_symtabs_matching, map_symbol_filenames): Use
9364         all_objfiles.
9365         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9366         all_objfiles.
9367         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9368         * objc-lang.c (find_methods): Use all_objfiles.
9369         * objfiles.c (have_partial_symbols, have_full_symbols)
9370         (have_minimal_symbols, qsort_cmp)
9371         (default_iterate_over_objfiles_in_search_order): Use
9372         all_objfiles.
9373         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9374         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9375         (maintenance_check_psymtabs): Use all_objfiles.
9376         (ALL_PSYMTABS): Remove.
9377         * compile/compile-object-run.c (do_module_cleanup): Use
9378         all_objfiles.
9379         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9380         * cp-support.c (add_symbol_overload_list_qualified): Use
9381         all_objfiles.
9382         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9383         Use all_objfiles.
9384         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9385         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9386         all_objfiles.
9387         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9388         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9389         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9390         Uses all_objfiles.
9391         * solib.c (solib_read_symbols): Use all_objfiles
9392
9393 2019-01-09  Tom Tromey  <tom@tromey.com>
9394
9395         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9396         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9397         all_objfiles.
9398         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9399         * symmisc.c (print_symbol_bcache_statistics)
9400         (print_objfile_statistics, maintenance_print_objfiles)
9401         (maintenance_info_symtabs, maintenance_check_symtabs)
9402         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9403         all_objfiles.
9404         * source.c (forget_cached_source_info): Use all_objfiles.
9405         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9406         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9407         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9408         * objfiles.c (update_section_map): Use all_objfiles.
9409         (shared_objfile_contains_address_p): Likewise.
9410         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9411         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9412
9413 2019-01-09  Tom Tromey  <tom@tromey.com>
9414
9415         * common/next-iterator.h: New file.
9416         * objfiles.h (class all_objfiles): New.
9417         (struct objfile_iterator): New.
9418
9419 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9420
9421         * NEWS: Move the description of the changed "frame", "select-frame",
9422          and "info frame" commands to the Changed commands section.
9423
9424 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9425
9426         * gdbtypes.c (check_stub_method_group): Remove handling of old
9427         mangling schemes.
9428         * linespec.c (find_methods): Likewise.
9429         * stabsread.c (read_member_functions): Likewise.
9430         * valops.c (search_struct_method): Likewise.
9431         (value_struct_elt_for_reference): Likewise.
9432         * NEWS: Mention this change.
9433
9434 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9435
9436         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9437         print_source_lines.
9438         * source.c (print_source_lines_base): Update line number check.
9439         (print_source_lines): New function.
9440         (source_lines_range::source_lines_range): New function.
9441         * source.h (class source_lines_range): New class.
9442         (print_source_lines): New declaration.
9443
9444 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9445
9446         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9447
9448 2019-01-08  Tom Tromey  <tom@tromey.com>
9449             Simon Marchi  <simon.marchi@ericsson.com>
9450
9451         PR gdb/24060
9452         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9453         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9454         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9455         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9456         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9457         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9458
9459 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9460
9461         * source.c (select_source_symtab): Move header comment to
9462         declaration in source.h.
9463         (forget_cached_source_info_for_objfile): Likewise.
9464         (forget_cached_source_info): Likewise.
9465         (identify_source_line): Likewise.
9466         * source.h (identify_source_line): Move declaration from symtab.h
9467         and add comment from source.c
9468         (print_source_lines): Likewise.
9469         (forget_cached_source_info_for_objfile): Likewise.
9470         (forget_cached_source_info): Likewise.
9471         (select_source_symtab): Likewise.
9472         (enum print_source_lines_flag): Move definition from symtab.h.
9473         * symtab.h (identify_source_line): Move declaration to source.h.
9474         (print_source_lines): Likewise.
9475         (forget_cached_source_info_for_objfile): Likewise.
9476         (forget_cached_source_info): Likewise.
9477         (select_source_symtab): Likewise.
9478         (enum print_source_lines_flag): Move definition to source.h.
9479         * tui/tui-hooks.c: Add 'source.h' include.
9480
9481 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9482
9483         * source.c (print_source_lines_base): Handle requests to print
9484         reverse line number sequences, and guard against empty lines
9485         string.
9486
9487 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9488
9489         * source.c (print_source_lines_base): Fix skip of '\r' if next
9490         character is '\n'.
9491
9492 2019-01-06  Tom Tromey  <tom@tromey.com>
9493
9494         * c-exp.y (struct c_parse_state) <macro_original_text,
9495         expansion_obstack>: New member.
9496         (macro_original_text, expansion_obstack): Remove globals.
9497         (scan_macro_expansion, scanning_macro_expansion)
9498         (finished_macro_expansion): Update.
9499         (scan_macro_cleanup): Remove.
9500         (yylex, c_parse): Update.
9501
9502 2019-01-06  Tom Tromey  <tom@tromey.com>
9503
9504         * c-exp.y (struct c_parse_state) <strings>: New member.
9505         (operator_stoken): Update.
9506
9507 2019-01-06  Tom Tromey  <tom@tromey.com>
9508
9509         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9510         (union type_stack_elt) <typelist_val>: Now a pointer to
9511         std::vector.
9512         (type_stack_cleanup): Don't declare.
9513         (push_typelist): Update.
9514         * parse.c (pop_typelist): Return a std::vector.
9515         (push_typelist): Take a std::vector.
9516         (follow_types): Update.  Do not free args.
9517         (type_stack_cleanup): Remove.
9518         * c-exp.y (struct c_parse_state): New.
9519         (cpstate): New global.
9520         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9521         (nonempty_typelist): Update.
9522         (func_mod): Create a new vector.
9523         (c_parse): Create a c_parse_state.
9524         (check_parameter_typelist): Do not delete params.
9525         (function_method): Update.  Do not delete type_list.
9526
9527 2019-01-06  Tom Tromey  <tom@tromey.com>
9528
9529         PR gdb/28155:
9530         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9531         check_typedef.
9532         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9533         (print_return_value): Likewise.
9534
9535 2019-01-05  Tom Tromey  <tom@tromey.com>
9536
9537         * contrib/cleanup_check.py: Remove.
9538         * contrib/gcc-with-excheck: Remove.
9539         * contrib/exsummary.py: Remove.
9540         * contrib/excheck.py: Remove.
9541
9542 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9543
9544         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9545         NULL. Initialize tpprev to NULL instead of assigning it
9546         to NULL on the next statement.
9547         * windows-nat.c (windows_delete_thread): Remove check for
9548         main_thread_id before printing thread exit notifications.
9549         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9550         Remove thread ID check against main_thread_id.
9551         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9552         windows_delete_thread.
9553         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9554
9555 2019-01-04  Tom Tromey  <tom@tromey.com>
9556
9557         * compile/compile.c (_initialize_compile): Use upper case for
9558         metasyntactic variables.
9559         * symmisc.c (_initialize_symmisc): Use upper case for
9560         metasyntactic variables.
9561         * psymtab.c (_initialize_psymtab): Use upper case for
9562         metasyntactic variables.
9563         * demangle.c (demangle_command): Use upper case for metasyntactic
9564         variables.
9565         (_initialize_demangler): Likewise.
9566         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9567         variables.
9568
9569 2019-01-03  Tom Tromey  <tom@tromey.com>
9570
9571         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9572
9573 2019-01-03  Tom Tromey  <tom@tromey.com>
9574
9575         * python/py-symtab.c (salpy_str): Update.
9576         (struct salpy_sal_object) <symtab>: Now a PyObject.
9577         (salpy_dealloc): Update.
9578         (del_objfile_sal): Use gdbpy_ref.
9579
9580 2019-01-03  Tom Tromey  <tom@tromey.com>
9581
9582         * python/py-type.c (convert_field): Use new_reference.  Return
9583         gdbpy_ref.
9584         (make_fielditem): Return gdbpy_ref.
9585         (typy_fields): Update.
9586         (typy_getitem): Update.
9587         (field_name): Return gdbpy_ref.  Use new_reference.
9588         (typy_iterator_iternext): Update.
9589
9590 2019-01-03  Tom Tromey  <tom@tromey.com>
9591
9592         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9593
9594 2019-01-03  Tom Tromey  <tom@tromey.com>
9595
9596         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9597         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9598         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9599         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9600         (pspy_set_type_printers): Likewise.
9601         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9602         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9603         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9604         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9605         (objfpy_set_type_printers): Likewise.
9606
9607 2019-01-03  Tom Tromey  <tom@tromey.com>
9608
9609         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9610         (gdbpy_print_stack): Use gdbpy_err_fetch.
9611         * python/python-internal.h (class gdbpy_err_fetch): New class.
9612         (class gdbpy_enter) <m_error_type, m_error_value,
9613         m_error_traceback>: Remove.
9614         <m_error>: New member.
9615         (gdbpy_exception_to_string): Don't declare.
9616         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9617         * python/py-value.c (convert_value_from_python): Use
9618         gdbpy_err_fetch.
9619         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9620         gdbpy_exception_to_string.
9621         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9622         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9623         gdbpy_err_fetch.
9624
9625 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9626
9627         * linux-nat.c (delete_lwp_cleanup): Delete.
9628         (struct lwp_deleter): New struct.
9629         (lwp_info_up): New typedef.
9630         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9631         lwp_info_up.
9632
9633 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9634
9635         * linux-fork.c (class scoped_switch_fork_info): New class.
9636         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9637
9638 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9639
9640         * valops.c (find_overload_match): Remove use of null_cleanup, and
9641         calls to do_cleanups.
9642
9643 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9644
9645         * compile/compile-cplus-types.c
9646         (compile_cplus_instance::decl_name): Handle changes to
9647         cp_func_name.
9648         * cp-support.c (cp_func_name): Update header comment, update
9649         return type.
9650         * cp-support.h (cp_func_name): Update return type in declaration.
9651         * valops.c (find_overload_match): Move temp_func local to top
9652         level of function and change its type.  Use temp_func to hold and
9653         delete temporary string obtained from cp_func_name.
9654
9655 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9656
9657         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9658         gdb::char_vector, remove cleanup, and update uses of `msg`.
9659
9660 2019-01-03  Jim Wilson  <jimw@sifive.com>
9661
9662         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9663
9664 2019-01-02  Tom Tromey  <tom@tromey.com>
9665
9666         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9667         (tdesc_parse_xml): Remove cleanups.
9668         * target-descriptions.h (make_cleanup_free_target_description):
9669         Don't declare.
9670         (target_desc_deleter): New struct.
9671         (target_desc_up): New typedef.
9672         * target-descriptions.c (target_desc_deleter::operator()): Rename
9673         from free_target_description.
9674         (make_cleanup_free_target_description): Remove.
9675
9676 2019-01-02  Tom Tromey  <tom@tromey.com>
9677
9678         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9679         constructor, destructor.
9680         (linespec_parser): Remove typedef.
9681         (~linespec_parser): Rename from linespec_parser_delete.
9682         (linespec_lex_to_end, linespec_complete_label)
9683         (linespec_complete): Update.
9684         (decode_line_full): Remove cleanups.
9685         (decode_line_1): Update.
9686
9687 2019-01-02  Tom Tromey  <tom@tromey.com>
9688
9689         * python/python-internal.h (inferior_to_inferior_object): Change
9690         return type.
9691         * python/py-exitedevent.c (create_exited_event_object): Update.
9692         * python/py-inferior.c (inferior_to_inferior_object): Return
9693         gdbpy_ref.
9694         (python_new_inferior, python_inferior_deleted)
9695         (thread_to_thread_object, delete_thread_object)
9696         (build_inferior_list, gdbpy_selected_inferior): Update.
9697         * python/py-infthread.c (create_thread_object): Update.  Also fail
9698         if inferior_to_inferior_object fails.
9699
9700 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9701
9702         * inferior.h (class inferior) <displaced_step_state>: New field.
9703         * infrun.h (struct displaced_step_state): Move here from
9704         infrun.c.  Initialize fields, add constructor.
9705         <inf>: Remove field.
9706         <reset>: New method.
9707         * infrun.c (struct displaced_step_inferior_state): Move to
9708         infrun.h.
9709         (displaced_step_inferior_states): Remove.
9710         (get_displaced_stepping_state): Adust.
9711         (displaced_step_in_progress_any_inferior): Adjust.
9712         (displaced_step_in_progress_thread): Adjust.
9713         (displaced_step_in_progress): Adjust.
9714         (add_displaced_stepping_state): Remove.
9715         (get_displaced_step_closure_by_addr): Adjust.
9716         (remove_displaced_stepping_state): Remove.
9717         (infrun_inferior_exit): Call displaced_step_state.reset.
9718         (use_displaced_stepping): Don't check for NULL.
9719         (displaced_step_prepare_throw): Call
9720         get_displaced_stepping_state.
9721         (displaced_step_fixup): Don't check for NULL.
9722         (prepare_for_detach): Don't check for NULL.
9723
9724 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9725
9726         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9727          in case of call that did not complete.
9728
9729 2019-01-02  Andrey Utkin  <autkin@undo.io>
9730
9731         * symfile.c (find_separate_debug_file): Fix search of debug files for
9732         remote debuggee.
9733
9734 2019-01-02  Tom Tromey  <tom@tromey.com>
9735
9736         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9737         indentation.
9738         * python/py-frame.c (frapy_older): Remove cast.
9739         (frapy_newer): Likewise.
9740         * python/py-breakpoint.c (local_setattro): Remove cast.
9741         * python/py-arch.c (archpy_name): Remove local variable.
9742         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9743
9744 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9745
9746         * unittests/basic_string_view/element_access/char/empty.cc:
9747         Fix year range in copyright header.
9748
9749 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9750
9751         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9752         Delete.
9753         <operator==>: Update with for removed field.
9754         <hash>: Likewise.
9755         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9756         <isa_features>: ...this.
9757         <abi_features>: New field.
9758         (riscv_isa_flen): Update comment.
9759         (riscv_abi_xlen): New declaration.
9760         (riscv_abi_flen): New declaration.
9761         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9762         isa_features.
9763         (riscv_abi_xlen): New function.
9764         (riscv_isa_flen): Update to get answer from isa_features.
9765         (riscv_abi_flen): New function.
9766         (riscv_has_fp_abi): Update to get answer from abi_features.
9767         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9768         xlen and flen.
9769         (riscv_call_info) <xlen, flen>: Update comment.
9770         (riscv_call_arg_struct): Remove invalid assertions
9771         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9772         is removed.
9773         (riscv_gdbarch_init): Gather isa features and abi features
9774         separately, ensure both match on the gdbarch when reusing an old
9775         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9776         a target with 64-bit float hardware.
9777
9778 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9779
9780         * source.c (search_command_helper): Stop reverse search
9781         when line 1 has been searched.
9782
9783 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9784
9785         * record-full.c (record_full_base_target::close): Rewrite
9786         record_full_core_buf_list free logic.
9787
9788 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9789
9790         * break-catch-syscall.c (print_one_catch_syscall): xfree
9791         the last text.
9792
9793 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9794
9795         * top.c (print_gdb_version): Update Copyright year in version
9796         message.
9797
9798 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9799
9800         Update copyright year range in all GDB files.
9801
9802 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9803
9804         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9805
9806 For older changes see ChangeLog-2018.
9807 \f
9808 Local Variables:
9809 mode: change-log
9810 left-margin: 8
9811 fill-column: 74
9812 version-control: never
9813 coding: utf-8
9814 End:
9815