gdb/ChangeLog

   1 2019-04-04  Tom Tromey  <tom@tromey.com>
   2
   3         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
   4         (rust_parser::convert_ast_to_expression, rust_parse)
   5         (rust_lex_test_completion, rust_lex_tests): Update.
   6         * parser-defs.h (struct expr_completion_state): New.
   7         (struct parser_state) <parser_state>: Add completion parameter.
   8         <mark_struct_expression, mark_completion_tag>: New methods.
   9         <parse_completion, m_completion_state>: New members.
  10         (prefixify_expression, null_post_parser): Update.
  11         (mark_struct_expression, mark_completion_tag): Don't declare.
  12         * parse.c (parse_completion, expout_last_struct)
  13         (expout_tag_completion_type, expout_completion_name): Remove
  14         globals.
  15         (parser_state::mark_struct_expression)
  16         (parser_state::mark_completion_tag): Now methods.
  17         (prefixify_expression): Add last_struct parameter.
  18         (prefixify_subexp): Likewise.
  19         (parse_exp_1): Update.
  20         (parse_exp_in_context): Add cstate parameter.  Update.
  21         (parse_expression_for_completion): Create an
  22         expr_completion_state.
  23         (null_post_parser): Add "completion" parameter.
  24         * p-exp.y: Update rules.
  25         (yylex): Update.
  26         * language.h (struct language_defn) <la_post_parser>: Add
  27         "completing" parameter.
  28         * go-exp.y: Update rules.
  29         (lex_one_token): Update.
  30         * expression.h (parse_completion): Don't declare.
  31         * d-exp.y: Update rules.
  32         (lex_one_token): Update rules.
  33         * c-exp.y: Update rules.
  34         (lex_one_token): Update.
  35         * ada-lang.c (resolve): Add "parse_completion" parameter.
  36         (resolve_subexp): Likewise.
  37         (ada_resolve_function): Likewise.
  38
  39 2019-04-04  Tom Tromey  <tom@tromey.com>
  40
  41         * parser-defs.h (struct parser_state) <start_arglist,
  42         end_arglist>: New methods.
  43         <arglist_len, m_funcall_chain>: New members.
  44         (arglist_len, start_arglist, end_arglist): Don't declare.
  45         * parse.c (arglist_len, funcall_chain): Remove global.
  46         (start_arglist, end_arglist): Remove functions.
  47         (parse_exp_in_context): Update.
  48         * p-exp.y: Update rules.
  49         * m2-exp.y: Update rules.
  50         * go-exp.y: Update rules.
  51         * f-exp.y: Update rules.
  52         * d-exp.y: Update rules.
  53         * c-exp.y: Update rules.
  54
  55 2019-04-04  Tom Tromey  <tom@tromey.com>
  56
  57         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
  58         lex_operator, push_back>: New methods.
  59         Update all rules.
  60         (rust_parser::lex_hex, lex_escape): Rename and update.
  61         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
  62         (rust_parser::lex_operator): Rename and update.
  63         (rust_parser::lex_number, rustyylex, rustyyerror)
  64         (rust_lex_test_init, rust_lex_test_sequence)
  65         (rust_lex_test_push_back, rust_lex_tests): Update.
  66         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
  67         parameter.
  68         <lexptr, prev_lexptr>: New members.
  69         (lexptr, prev_lexptr): Don't declare.
  70         * parse.c (lexptr, prev_lexptr): Remove globals.
  71         (parse_exp_in_context): Update.
  72         * p-exp.y (yylex, yyerror): Update.
  73         * m2-exp.y (parse_number, yylex, yyerror): Update.
  74         * go-exp.y (lex_one_token, yyerror): Update.
  75         * f-exp.y (match_string_literal, yylex, yyerror): Update.
  76         * d-exp.y (lex_one_token, yyerror): Update.
  77         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
  78         (lex_one_token, yyerror): Update.
  79         * ada-lex.l (YY_INPUT): Update.
  80         (rewind_to_char): Update.
  81         * ada-exp.y (yyerror): Update.
  82
  83 2019-04-04  Tom Tromey  <tom@tromey.com>
  84
  85         * rust-exp.y (rustyylex, rust_lex_tests): Update.
  86         * parser-defs.h (struct parser_state) <parser_state>: Add new
  87         parameter.
  88         <comma_terminates>: New member.
  89         (comma_terminates): Don't declare global.
  90         * parse.c (comma_terminates): Remove global.
  91         (parse_exp_in_context): Update.
  92         * p-exp.y (yylex): Update.
  93         * m2-exp.y (yylex): Update.
  94         * go-exp.y (lex_one_token): Update.
  95         * f-exp.y (yylex): Update.
  96         * d-exp.y (lex_one_token): Update.
  97         * c-exp.y (lex_one_token): Update.
  98         * ada-lex.l: Update.
  99
 100 2019-04-04  Tom Tromey  <tom@tromey.com>
 101
 102         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
 103         (rustyylex, rust_lex_test_init, rust_lex_test_one)
 104         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
 105         * parser-defs.h (paren_depth): Don't declare.
 106         * parse.c (paren_depth): Remove global.
 107         (parse_exp_in_context): Update.
 108         * p-exp.y (paren_depth): New global.
 109         (pascal_parse): Initialize it.
 110         * m2-exp.y (paren_depth): New global.
 111         (m2_parse): Initialize it.
 112         * go-exp.y (paren_depth): New global.
 113         (go_parse): Initialize it.
 114         * f-exp.y (paren_depth): New global.
 115         (f_parse): Initialize it.
 116         * d-exp.y (paren_depth): New global.
 117         (d_parse): Initialize it.
 118         * c-exp.y (paren_depth): New global.
 119         (c_parse): Initialize it.
 120         * ada-lex.l (paren_depth): New global.
 121         (lexer_init): Initialize it.
 122
 123 2019-04-04  Tom Tromey  <tom@tromey.com>
 124
 125         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
 126         (rust_parser::convert_ast_to_type)
 127         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
 128         * parser-defs.h (struct parser_state) <parser_state>: Add
 129         parameters.  Initialize new members.
 130         <expression_context_block, expression_context_pc>: New members.
 131         * parse.c (expression_context_block, expression_context_pc):
 132         Remove globals.
 133         (parse_exp_in_context): Update.
 134         * p-exp.y: Update all rules.
 135         (yylex): Update.
 136         * m2-exp.y: Update all rules.
 137         (yylex): Update.
 138         * go-exp.y (yylex): Update.
 139         * f-exp.y (yylex): Update.
 140         * d-exp.y: Update all rules.
 141         (yylex): Update.
 142         * c-exp.y: Update all rules.
 143         (lex_one_token, classify_name, yylex, c_parse): Update.
 144         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
 145
 146 2019-04-04  Tom Tromey  <tom@tromey.com>
 147
 148         * gdbarch.h, gdbarch.c: Rebuild.
 149         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
 150         * stap-probe.h:
 151         (struct stap_parse_info): Replace "parser_state" with
 152         "expr_builder".
 153         * parser-defs.h (struct expr_builder): Rename from "parser_state".
 154         (parser_state): New class.
 155         * parse.c (expr_builder): Rename.
 156         (expr_builder::release): Rename.
 157         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
 158         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
 159         (write_exp_elt_longcst, write_exp_elt_floatcst)
 160         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
 161         (write_exp_string_vector, write_exp_bitstring)
 162         (write_exp_msymbol, mark_struct_expression)
 163         (write_dollar_variable)
 164         (insert_type_address_space, increase_expout_size): Replace
 165         "parser_state" with "expr_builder".
 166         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
 167         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
 168         "parser_state" with "expr_builder".
 169
 170 2019-04-04  Tom Tromey  <tom@tromey.com>
 171
 172         * rust-exp.y: Replace "parse_language" with method call.
 173         * p-exp.y:
 174         (yylex): Replace "parse_language" with method call.
 175         * m2-exp.y:
 176         (yylex): Replace "parse_language" with method call.
 177         * go-exp.y (classify_name): Replace "parse_language" with method
 178         call.
 179         * f-exp.y (yylex): Replace "parse_language" with method call.
 180         * d-exp.y (lex_one_token): Replace "parse_language" with method
 181         call.
 182         * c-exp.y:
 183         (lex_one_token, classify_name, yylex): Replace "parse_language"
 184         with method call.
 185         * ada-exp.y (find_primitive_type, type_char)
 186         (type_system_address): Replace "parse_language" with method call.
 187
 188 2019-04-04  Tom Tromey  <tom@tromey.com>
 189
 190         * rust-exp.y: Replace "parse_gdbarch" with method call.
 191         * parse.c (write_dollar_variable, insert_type_address_space):
 192         Replace "parse_gdbarch" with method call.
 193         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
 194         call.
 195         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
 196         call.
 197         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
 198         "parse_gdbarch" with method call.
 199         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
 200         with method call.
 201         * f-exp.y (parse_type, parse_f_type, yylex): Replace
 202         "parse_gdbarch" with method call.
 203         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
 204         "parse_gdbarch" with method call.
 205         * c-exp.y (parse_type, parse_number, classify_name): Replace
 206         "parse_gdbarch" with method call.
 207         * ada-lex.l: Replace "parse_gdbarch" with method call.
 208         * ada-exp.y (parse_type, find_primitive_type, type_char)
 209         (type_system_address): Replace "parse_gdbarch" with method call.
 210
 211 2019-04-04  Tom Tromey  <tom@tromey.com>
 212
 213         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
 214         * stap-probe.c (stap_parse_argument): Update.
 215         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
 216         initial_size parameter.
 217         * rust-exp.y (rust_lex_tests): Update.
 218         * parse.c (parser_state): Update.
 219         (parse_exp_in_context): Update.
 220         * parser-defs.h (struct parser_state) <parser_state>: Remove
 221         "initial_size" parameter.
 222
 223 2019-04-04  Tom Tromey  <tom@tromey.com>
 224
 225         * parser-defs.h (increase_expout_size): Don't declare.
 226         * parse.c (increase_expout_size): Now static.
 227
 228 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
 229
 230         * gnu-nat.c (gnu_nat_target::wait): Fix
 231         target_waitstatus_to_string call.
 232
 233 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 234
 235         * eval.c (evaluate_subexp_standard): Handle internal functions
 236         during Fortran function call handling.
 237
 238 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 239
 240         * NEWS: Mention new internal functions.
 241         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
 242         (read_base_type): Use dwarf2_init_complex_target_type.
 243         * value.c (creal_internal_fn): New function.
 244         (cimag_internal_fn): New function.
 245         (_initialize_values): Register new internal functions.
 246
 247 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 248
 249         * infrun.c (stop_all_threads): If debug_infrun, always
 250         trace the wait status after wait_one, using
 251         target_waitstatus_to_string and target_pid_to_str.
 252         (handle_inferior_event): Replace various trace of
 253         wait status kind by a single trace.
 254         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
 255         wait status kind image by target_waitstatus_to_string.
 256         * target/waitstatus.c (target_waitstatus_to_string): Fix
 257         obsolete comment.
 258
 259 2019-04-01  Tom Tromey  <tromey@adacore.com>
 260
 261         PR symtab/23331:
 262         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
 263
 264 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
 265             Pedro Alves  <palves@redhat.com>
 266
 267         * top.c (quit_force): Call 'finalize_values'.
 268         * value.c (finalize_values): New function.
 269         * value.h (finalize_values): Declare.
 270
 271 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
 272
 273         * NEWS: Announce $_gdb_major and $_gdb_minor.
 274
 275         * top.c (init_gdb_version_vars): New function.
 276         (gdb_init): Call init_gdb_version_vars.
 277
 278 2019-03-29  Tom Tromey  <tromey@adacore.com>
 279
 280         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
 281         help text.  Remove dead code.
 282
 283 2019-03-29  Keith Seitz  <keiths@redhat.com>
 284
 285         From Siddhesh Poyarekar:
 286         * f-lang.h (f77_get_upperbound): Return LONGEST.
 287         (f77_get_lowerbound): Likewise.
 288         * f-typeprint.c (f_type_print_varspec_suffix): Expand
 289         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
 290         print them.
 291         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
 292         plongest to format print it.
 293         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
 294         (f77_get_upperbound): Likewise.
 295         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
 296         LOWER_BOUND to LONGEST.
 297         (f77_create_arrayprint_offset_tbl): Likewise.
 298
 299 2019-03-29  Keith Seitz  <keiths@redhat.com>
 300
 301         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
 302         %s/pulongest for TYPE_LENGTH instead of %d in format
 303         strings.
 304         * ada-typerint.c (ada_print_type): Likewise.
 305         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
 306         * compile/compile-c-support.c (generate_register_struct): Likewise.
 307         * gdbtypes.c (recursive_dump_type): Likewise.
 308         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
 309         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
 310         instead of %d in format strings.
 311         * riscv-tdep.c (riscv_type_alignment): Cast second argument
 312         to std::min to ULONGEST.
 313         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
 314         instead of %d in format strings.
 315         * tracepoint.c (info_scope_command): Likewise.
 316         * typeprint.c (print_offset_data::update)
 317         (print_offset_data::finish): Likewise.
 318         * xtensa-tdep.c (xtensa_store_return_value)
 319         (xtensa_push_dummy_call): Likewise.
 320
 321 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 322
 323         * windows-nat.c (display_selector): Fixed format specifications
 324         for 64-bit Cygwin.
 325
 326 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 327
 328         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 329
 330 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 331
 332         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 333         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 334         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 335         (nios2_linux_init_abi): Install it.
 336
 337 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 338
 339         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 340
 341 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 342
 343         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 344
 345 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 346             Tom Tromey  <tromey@adacore.com>
 347
 348         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 349
 350 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 351
 352         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 353         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 354         method to compute the bounds of range types. Also print "[evaluated]"
 355         if the bounds' values come from a dynamic evaluation.
 356
 357 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 358
 359         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 360         whitespace when pretty printing is on.
 361
 362 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 363
 364         * ppc-linux-nat.c: Add include.
 365
 366 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 367
 368         * NEWS: Mention AArch64 Pointer Authentication.
 369
 370 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 371
 372         * arm-linux-nat.c: Add include.
 373
 374 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 375
 376         * source-cache.c (source_cache::get_source_lines): Re-read
 377         fullname after calling open_source_file.
 378
 379 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 380
 381         * NEWS: Mention TLS support for FreeBSD.
 382
 383 2019-03-25  Tom Tromey  <tromey@adacore.com>
 384
 385         * minsyms.c (BUNCH_SIZE): Update comment.
 386         (~minimal_symbol_reader): Remove old comment.
 387         (compact_minimal_symbols): Update comment.
 388         (minimal_symbol_reader::install): Remove old comment.  Update
 389         other comments.
 390
 391 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 392
 393         * s390-linux-nat.c: Add include.
 394
 395 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 396
 397         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 398         Call linux_get_hwcap.
 399         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 400         Likewise.
 401         (aarch64_linux_get_hwcap): Remove function.
 402         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 403         declaration.
 404         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 405         linux_get_hwcap.
 406         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 407         * linux-tdep.c (linux_get_hwcap): Add function.
 408         (linux_get_hwcap2): Likewise.
 409         * linux-tdep.h (linux_get_hwcap): Add declaration.
 410         (linux_get_hwcap2): Likewise.
 411         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 412         (ppc_linux_get_hwcap2): Likewise.
 413         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 414         linux_get_hwcap.
 415         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 416         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 417         (ppc_linux_nat_target::read_description): Likewise.
 418         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 419         * s390-linux-nat.c: Likewise.
 420         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 421
 422 2019-03-24  Tom Tromey  <tom@tromey.com>
 423
 424         * ada-lang.c (standard_lookup): Simplify initialization.
 425         (ada_lookup_symbol_nonlocal): Simplify return.
 426         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 427         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 428         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 429         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 430         initialization.
 431         * solib.c (solib_global_lookup): Simplify.
 432         * symtab.c (null_block_symbol): Remove.
 433         (symbol_cache_lookup): Simplify returns.
 434         (lookup_language_this): Simplify returns.
 435         (lookup_symbol_aux): Simplify return.
 436         (lookup_local_symbol): Simplify returns.
 437         (lookup_global_symbol_from_objfile): Simplify return.
 438         (lookup_symbol_in_objfile_symtabs)
 439         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 440         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 441         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 442         * cp-namespace.c (cp_lookup_bare_symbol)
 443         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 444         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 445         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 446         (cp_lookup_symbol_via_imports): Simplify initialization.
 447         (find_symbol_in_baseclass): Likewise.
 448         * symtab.h (null_block_symbol): Remove.
 449         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 450         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 451         (d_lookup_symbol_module): Likewise.
 452         (find_symbol_in_baseclass): Simplify initialization.
 453
 454 2019-03-24  Tom Tromey  <tom@tromey.com>
 455
 456         * expression.h: Don't include symtab.h.
 457         (struct block): Forward declare.
 458
 459 2019-03-24  Tom Tromey  <tom@tromey.com>
 460
 461         * c-exp.y (typebase): Remove casts.
 462         * gdbtypes.c (lookup_unsigned_typename, )
 463         (lookup_signed_typename): Remove cast.
 464         * eval.c (parse_to_comma_and_eval): Remove cast.
 465         * parse.c (write_dollar_variable): Remove cast.
 466         * block.h (struct block) <superblock>: Now const.
 467         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 468         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 469         (map_block): Make "block" const.
 470         * symfile.h (struct quick_symbol_functions)
 471         <map_matching_symbols>: Constify block argument to "callback".
 472         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 473         const.
 474         (find_pc_sect_compunit_symtab): Make "b" const.
 475         (find_symbol_at_address): Likewise.
 476         (search_symbols): Likewise.
 477         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 478         (dw2_debug_names_lookup_symbol): Likewise.
 479         (dw2_map_matching_symbols): Update.
 480         * p-valprint.c (pascal_val_print): Remove "block".
 481         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 482         (aux_add_nonlocal_symbols): Make "block" const.
 483         (resolve_subexp): Remove cast.
 484         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 485         const.
 486         (iterate_over_file_blocks): Likewise.
 487         * f-exp.y (%union) <bval>: Remove.
 488         * coffread.c (patch_opaque_types): Make "b" const.
 489         * spu-tdep.c (spu_catch_start): Make "block" const.
 490         * c-valprint.c (print_unpacked_pointer): Remove "block".
 491         * symmisc.c (dump_symtab_1): Make "b" const.
 492         (block_depth): Make "block" const.
 493         * d-exp.y (%union) <bval>: Remove.
 494         * cp-support.h (cp_lookup_rtti_type): Update.
 495         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 496         * psymtab.c (psym_lookup_symbol): Make "block" const.
 497         (maintenance_check_psymtabs): Make "b" const.
 498         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 499         (enumerate_locals, enumerate_args): Update.
 500         * python/py-symtab.c (stpy_global_block): Make "block" const.
 501         (stpy_static_block): Likewise.
 502         * inline-frame.c (block_starting_point_at): Make "new_block"
 503         const.
 504         * block.c (find_block_in_blockvector): Make return type const.
 505         (blockvector_for_pc_sect): Make "b" const.
 506         (find_block_in_blockvector): Make "b" const.
 507
 508 2019-03-23  Tom Tromey  <tom@tromey.com>
 509
 510         * varobj.c (varobj_create): Update.
 511         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 512         * printcmd.c (display_command, do_one_display): Don't reset
 513         innermost_block.
 514         * parser-defs.h (enum innermost_block_tracker_type): Move to
 515         expression.h.
 516         (innermost_block): Update comment.
 517         * parse.c (parse_exp_1): Add tracker_types parameter.
 518         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 519         tracker_types parameter.  Reset innermost_block.
 520         (parse_exp_in_context): Remove.
 521         (parse_expression_for_completion): Update.
 522         * objfiles.c (~objfile): Don't reset expression_context_block or
 523         innermost_block.
 524         * expression.h (enum innermost_block_tracker_type): Move from
 525         parser-defs.h.
 526         (parse_exp_1): Add tracker_types parameter.
 527         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 528         reset innermost_block.
 529
 530 2019-03-23  Tom Tromey  <tom@tromey.com>
 531
 532         * objfiles.h: Include bcache.h.
 533
 534 2019-03-23  Tom Tromey  <tom@tromey.com>
 535
 536         * linespec.c (get_current_search_block): Use
 537         scoped_restore_current_language.
 538         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 539
 540 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 541             Jiong Wang  <jiong.wang@arm.com>
 542
 543         * aarch64-linux-tdep.c
 544         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 545         section.
 546         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 547
 548 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 549             Jiong Wang  <jiong.wang@arm.com>
 550
 551         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 552         instructions.
 553         (aarch64_analyze_prologue_test): Add PACIASP test.
 554         (aarch64_prologue_prev_register): Unmask PC value.
 555
 556 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 557             Jiong Wang  <jiong.wang@arm.com>
 558
 559         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 560         (aarch64_dwarf2_prev_register): Unmask PC value.
 561         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 562         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 563         DW_CFA_AARCH64_negate_ra_state.
 564         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 565
 566 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 567             Jiong Wang  <jiong.wang@arm.com>
 568
 569         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 570         registers.
 571         (aarch64_pseudo_register_name): Likewise.
 572         (aarch64_pseudo_register_type): Likewise.
 573         (aarch64_pseudo_register_reggroup_p): Likewise.
 574         (aarch64_gdbarch_init): Add pauth registers.
 575         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 576         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 577         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 578         (struct gdbarch_tdep): Add regnum for ra_state.
 579
 580 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 581             Jiong Wang  <jiong.wang@arm.com>
 582
 583         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 584
 585 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 586             Jiong Wang  <jiong.wang@arm.com>
 587
 588         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 589         function.
 590         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 591         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 592         (aarch64_gdbarch_init): Add puth registers.
 593         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 594         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 595         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 596
 597 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 598             Jiong Wang  <jiong.wang@arm.com>
 599
 600         * aarch64-linux-nat.c
 601         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 602         * aarch64-linux-tdep.c
 603         (aarch64_linux_core_read_description): Likewise.
 604         (aarch64_linux_get_hwcap): New function.
 605         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 606         (aarch64_linux_get_hwcap): New declaration.
 607
 608 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 609             Jiong Wang  <jiong.wang@arm.com>
 610
 611         * aarch64-linux-nat.c
 612         (aarch64_linux_nat_target::read_description): Add pauth param.
 613         * aarch64-linux-tdep.c
 614         (aarch64_linux_core_read_description): Likewise.
 615         * aarch64-tdep.c (struct target_desc): Add in pauth.
 616         (aarch64_read_description): Add pauth param.
 617         (aarch64_gdbarch_init): Likewise.
 618         * aarch64-tdep.h (aarch64_read_description): Likewise.
 619         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 620         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 621         * features/Makefile: Add new files.
 622         * features/aarch64-pauth.c: New file.
 623         * features/aarch64-pauth.xml: New file.
 624
 625 2019-03-20  Tom Tromey  <tromey@adacore.com>
 626
 627         * infrun.c (handle_inferior_event): Rename from
 628         handle_inferior_event_1.  Create a scoped_value_mark.
 629         (handle_inferior_event): Remove.
 630
 631 2019-03-19  Tom Tromey  <tromey@adacore.com>
 632
 633         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 634         * infrun.h (print_stop_event): Add "displays" parameter.
 635         * infrun.c (print_stop_event): Add "displays" parameter.
 636
 637 2019-03-19  Pedro Alves  <palves@redhat.com>
 638
 639         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 640         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 641         to -1.  Fix TABs vs spaces.
 642         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 643         * tui/tui-out.h (tui_ui_out) Add intro comments.
 644         <m_line, m_start_of_line>: In-class initialize, and add describing
 645         comment.
 646
 647 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 648
 649         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 650         variable names.
 651         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 652
 653 2019-03-18  Pedro Alves  <palves@redhat.com>
 654             Eli Zaretskii <eliz@gnu.org>
 655
 656         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 657         m_line and m_start_of_line.
 658
 659 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 660
 661         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 662         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 663         it returns a newline.  This fixes a regression in TU mode, whereby
 664         the next line is output on the same screen line as the user input.
 665
 666 2019-03-18  Tom Tromey  <tromey@adacore.com>
 667
 668         * minsyms.c (minimal_symbol_reader::install): Remove call to
 669         obstack_blank.
 670
 671 2019-03-18  Pedro Alves  <palves@redhat.com>
 672
 673         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 674         New globals.
 675         (apply_style): New, factored out from ...
 676         (apply_ansi_escape): ... this.  Handle reverse video mode.
 677         (tui_set_reverse_mode): New function.
 678         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 679         * tui/tui-winsource.c (tui_show_source_line): Use
 680         tui_set_reverse_mode instead of setting A_STANDOUT.
 681         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 682         New setter methods.
 683
 684 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 685
 686         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 687         Handle tabs.
 688
 689 2019-03-18  Tom Tromey  <tromey@adacore.com>
 690
 691         * ada-lang.c (empty_array): Add "high" parameter.
 692         (ada_evaluate_subexp): Update.
 693
 694 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 695
 696         * unittests/string_view-selftests.c: Define
 697         _initialize_string_view_selftests unconditionally.
 698
 699 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 700
 701         PR gdb/24350
 702         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 703
 704 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 705
 706         PR gdb/24351
 707         * windows-nat.c (display_selector): Fix format specifiers.
 708
 709 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 710
 711         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 712         tui_refill_source_window instead of tui_refresh_win, to update the
 713         current execution line.  This fixes redisplay of the current line
 714         when stepping through the code with "next" or "step".
 715
 716 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 717
 718         * source-cache.c (source_cache::get_source_lines): Call
 719         find_source_lines to initialize s->nlines.  This fixes vertical
 720         scrolling of TUI source window when the DOWN arrow is pressed.
 721
 722 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 723
 724         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 725         linux-thread-db.c (_initialize_thread_db): Likewise.
 726
 727 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 728
 729         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 730         wclrtoeol in tui_show_source_line".  This reverts changes made in
 731         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 732
 733 2019-03-15  Tom Tromey  <tom@tromey.com>
 734
 735         * symtab.h (struct minimal_symbol): Derive from
 736         general_symbol_info.
 737         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 738         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 739         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 740         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 741         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 742         (MSYMBOL_SEARCH_NAME): Update.
 743         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 744         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 745         * minsyms.c (minimal_symbol_reader::record_full): Update.
 746
 747 2019-03-15  Tom Tromey  <tom@tromey.com>
 748
 749         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 750
 751 2019-03-15  Tom Tromey  <tom@tromey.com>
 752
 753         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 754         unique_xmalloc_ptr.
 755         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 756         Update.
 757         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 758         (build_minimal_symbol_hash_tables)
 759         (minimal_symbol_reader::install): Update.
 760
 761 2019-03-15  Tom Tromey  <tom@tromey.com>
 762
 763         * symtab.c (create_demangled_names_hash): Update.
 764         (symbol_set_names): Update.
 765         * objfiles.h (struct objfile_per_bfd_storage)
 766         <demangled_names_hash>: Now an htab_up.
 767         * objfiles.c (objfile_per_bfd_storage): Simplify.
 768
 769 2019-03-15  Tom Tromey  <tom@tromey.com>
 770
 771         * objfiles.h (struct objfile_per_bfd_storage): Declare
 772         destructor.
 773         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 774         New.
 775         (get_objfile_bfd_data): Use new.  Don't initialize
 776         language_of_main.
 777         (free_objfile_per_bfd_storage): Remove.
 778         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 779
 780 2019-03-15  Tom Tromey  <tom@tromey.com>
 781
 782         * symfile.c (reread_symbols): Update.
 783         * objfiles.c (objfile::objfile): Update.
 784         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 785         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 786         comment.
 787         (minimal_symbol_reader::install): Update.
 788         (terminate_minimal_symbol_table): Remove.
 789         * jit.c (jit_object_close_impl): Update.
 790
 791 2019-03-15  Tom Tromey  <tom@tromey.com>
 792
 793         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 794         initializations.
 795
 796 2019-03-15  Tom Tromey  <tom@tromey.com>
 797
 798         * objfiles.h (struct objfile_per_bfd_storage)
 799         <demangled_hash_languages>: Now a bitset.
 800         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 801         (lookup_minimal_symbol): Update.
 802
 803 2019-03-15  Tom Tromey  <tom@tromey.com>
 804
 805         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 806         Don't return the symbol.
 807         * coffread.c (record_minimal_symbol): Use record_full.
 808
 809 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 810
 811         The MS-Windows port of ncurses fails to switch to a color pair if
 812         one or both of the colors are the implicit default colors.  This
 813         change records the default colors when TUI is initialized, and
 814         then specifies them explicitly when a color pair uses the default
 815         colors.  This allows color styling in TUI mode on MS-Windows.
 816
 817         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 818         ncurses_norm_attr.
 819         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 820         colors in ncurses_norm_attr.
 821         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 822         "none", replace it with the default color recorded in
 823         ncurses_norm_attr.
 824
 825 2019-03-14  Tom Tromey  <tromey@adacore.com>
 826
 827         * source-cache.h (class source_cache) <get_source_lines>: Return
 828         std::string.
 829         * source-cache.c (source_cache::extract_lines): Handle case where
 830         first_pos==npos.  Return std::string.
 831         (source_cache::get_source_lines): Update.
 832
 833 2019-03-14  Tom Tromey  <tromey@adacore.com>
 834
 835         * NEWS: Add item for "style sources" commands.
 836         * source-cache.c (source_cache::get_source_lines): Check
 837         source_styling.
 838         * cli/cli-style.c (source_styling): New global.
 839         (_initialize_cli_style): Add "style sources" commands.
 840         (show_style_sources): New function.
 841         * cli/cli-style.h (source_styling): Declare.
 842
 843 2019-03-14  Pedro Alves  <palves@redhat.com>
 844             Tom Tromey  <tromey@adacore.com>
 845
 846         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 847         * tui/tui-winsource.c (tui_refill_source_window): New function,
 848         from...
 849         (tui_horizontal_source_scroll): ... here.  Move some logic.
 850         * cli/cli-style.c (set_style_enabled): Notify new observable.
 851         * tui/tui-hooks.c (tui_redisplay_source): New function.
 852         (tui_attach_detach_observers): Attach or detach
 853         tui_redisplay_source.
 854         * observable.h (source_styling_changed): New observable.
 855         * observable.c: Define source_styling_changed observable.
 856
 857 2019-03-13  Tom Tromey  <tromey@adacore.com>
 858
 859         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 860         (i386_gnu_nat_target::store_registers): Update.
 861         * target-debug.h (target_debug_print_std_string): New macro.
 862         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 863         * windows-tdep.c (display_one_tib): Update.
 864         * tui/tui-stack.c (tui_make_status_line): Update.
 865         * top.c (print_inferior_quit_action): Update.
 866         * thread.c (thr_try_catch_cmd): Update.
 867         (add_thread_with_info): Update.
 868         (thread_target_id_str): Update.
 869         (thr_try_catch_cmd): Update.
 870         (thread_command): Update.
 871         (thread_find_command): Update.
 872         * record-btrace.c (record_btrace_target::info_record)
 873         (record_btrace_resume_thread, record_btrace_target::resume)
 874         (record_btrace_cancel_resume, record_btrace_step_thread)
 875         (record_btrace_target::wait, record_btrace_target::wait)
 876         (record_btrace_target::wait, record_btrace_target::stop): Update.
 877         * progspace.c (print_program_space): Update.
 878         * process-stratum-target.c
 879         (process_stratum_target::thread_address_space): Update.
 880         * linux-fork.c (linux_fork_mourn_inferior)
 881         (detach_checkpoint_command, info_checkpoints_command)
 882         (linux_fork_context): Update.
 883         (linux_fork_detach): Update.
 884         (class scoped_switch_fork_info): Update.
 885         (delete_checkpoint_command): Update.
 886         * infrun.c (follow_fork_inferior): Update.
 887         (follow_fork_inferior): Update.
 888         (proceed_after_vfork_done): Update.
 889         (handle_vfork_child_exec_or_exit): Update.
 890         (follow_exec): Update.
 891         (displaced_step_prepare_throw): Update.
 892         (displaced_step_restore): Update.
 893         (start_step_over): Update.
 894         (resume_1): Update.
 895         (clear_proceed_status_thread): Update.
 896         (proceed): Update.
 897         (print_target_wait_results): Update.
 898         (do_target_wait): Update.
 899         (context_switch): Update.
 900         (stop_all_threads): Update.
 901         (restart_threads): Update.
 902         (finish_step_over): Update.
 903         (handle_signal_stop): Update.
 904         (switch_back_to_stepped_thread): Update.
 905         (keep_going_pass_signal): Update.
 906         (print_exited_reason): Update.
 907         (normal_stop): Update.
 908         * inferior.c (inferior_pid_to_str): Change return type.
 909         (print_selected_inferior): Update.
 910         (add_inferior): Update.
 911         (detach_inferior): Update.
 912         * dummy-frame.c (fprint_dummy_frames): Update.
 913         * dcache.c (dcache_info_1): Update.
 914         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 915         (btrace_fetch, btrace_clear): Update.
 916         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 917         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 918         type.
 919         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 920         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 921         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 922         * gdbarch.c, gdbarch.h: Rebuild.
 923         * gdbarch.sh (core_pid_to_str): Change return type.
 924         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 925         return type.
 926         (windows_nat_target::pid_to_str): Change return type.
 927         (windows_delete_thread): Update.
 928         (windows_nat_target::attach): Update.
 929         (windows_nat_target::files_info): Update.
 930         * target-delegates.c: Rebuild.
 931         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 932         return type.
 933         (sol_thread_target::pid_to_str): Change return type.
 934         * remote.c (class remote_target) <pid_to_str>: Change return
 935         type.
 936         (remote_target::pid_to_str): Change return type.
 937         (extended_remote_target::attach, remote_target::remote_stop_ns)
 938         (remote_target::remote_notif_remove_queued_reply)
 939         (remote_target::push_stop_reply, remote_target::disable_btrace):
 940         Update.
 941         (extended_remote_target::attach): Update.
 942         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 943         type.
 944         (gdbsim_target::pid_to_str): Change return type.
 945         * ravenscar-thread.c (struct ravenscar_thread_target)
 946         <pid_to_str>: Change return type.
 947         (ravenscar_thread_target::pid_to_str): Change return type.
 948         * procfs.c (class procfs_target) <pid_to_str>: Change return
 949         type.
 950         (procfs_target::pid_to_str): Change return type.
 951         (procfs_target::attach): Update.
 952         (procfs_target::detach): Update.
 953         (procfs_target::fetch_registers): Update.
 954         (procfs_target::store_registers): Update.
 955         (procfs_target::wait): Update.
 956         (procfs_target::files_info): Update.
 957         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 958         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 959         return type.
 960         (nto_procfs_target::pid_to_str): Change return type.
 961         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 962         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 963         return type.
 964         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 965         (exit_lwp): Update.
 966         (attach_proc_task_lwp_callback, get_detach_signal)
 967         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 968         (linux_nat_target::resume, wait_lwp, stop_callback)
 969         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 970         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 971         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 972         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 973         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 974         type.
 975         (inf_ptrace_target::attach): Update.
 976         (inf_ptrace_target::files_info): Update.
 977         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 978         type.
 979         (go32_nat_target::pid_to_str): Change return type.
 980         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 981         (gnu_nat_target::wait): Update.
 982         (gnu_nat_target::wait): Update.
 983         (gnu_nat_target::resume): Update.
 984         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 985         (fbsd_nat_target::wait): Update.
 986         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 987         type.
 988         (darwin_nat_target::attach): Update.
 989         * corelow.c (class core_target) <pid_to_str>: Change return type.
 990         (core_target::pid_to_str): Change return type.
 991         * target.c (normal_pid_to_str): Change return type.
 992         (default_pid_to_str): Likewise.
 993         (target_pid_to_str): Change return type.
 994         (target_translate_tls_address): Update.
 995         (target_announce_detach): Update.
 996         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 997         return type.
 998         (bsd_uthread_target::pid_to_str): Change return type.
 999         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1000         type.
1001         (bsd_kvm_target::pid_to_str): Change return type.
1002         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1003         return type.
1004         (aix_thread_target::pid_to_str): Change return type.
1005         * target.h (struct target_ops) <pid_to_str>: Change return type.
1006         (target_pid_to_str, normal_pid_to_str): Likewise.
1007         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1008         type.
1009         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1010         type.
1011         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1012         return type.
1013         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1014         type.
1015         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1016         type.
1017         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1018         return type.
1019
1020 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1021
1022         * NEWS: Mention that the new default MI version is 3.  Mention
1023         changes to the output of commands and events that deal with
1024         multi-location breakpoints.
1025         * breakpoint.c: Include "mi/mi-out.h".
1026         (print_one_breakpoint): Change output syntax if using MI version
1027         >= 3.
1028         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1029         New.
1030         (mi_multi_location_breakpoint_output_fixed): New.
1031         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1032         (mi_cmd_fix_multi_location_breakpoint_output): New.
1033         (mi_multi_location_breakpoint_output_fixed): New.
1034         * mi/mi-cmds.c (mi_cmds): Register command
1035         -fix-multi-location-breakpoint-output.
1036         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1037         interpreter "mi".
1038
1039 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1040
1041         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1042         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1043         instantiate mi_ui_out based on interpreter name.
1044         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1045         * mi/mi-main.c (mi_load_progress): Likewise.
1046
1047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1048
1049         * NEWS: Combine separate "New targets" sections for 8.3.
1050
1051 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1052
1053         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1054         (ppcfbsd_init_abi): Install gdbarch
1055         "fetch_tls_load_module_address" and "get_thread_local_address"
1056         methods.
1057
1058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1059
1060         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1061         (riscv_fbsd_init_abi): Install gdbarch
1062         "fetch_tls_load_module_address" and "get_thread_local_address"
1063         methods.
1064
1065 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1066
1067         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1068         (i386fbsd_init_abi): Install gdbarch
1069         "fetch_tls_load_module_address" and "get_thread_local_address"
1070         methods.
1071
1072 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1073
1074         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1075         (amd64fbsd_init_abi): Install gdbarch
1076         "fetch_tls_load_module_address" and "get_thread_local_address"
1077         methods.
1078
1079 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1080
1081         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1082         (struct fbsd_pspace_data): New type.
1083         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1084         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1085         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1086         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1087         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1088
1089 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1090
1091         * gdbtypes.c (lookup_struct_elt): New function.
1092         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1093         * gdbtypes.h (struct struct_elt): New type.
1094         (lookup_struct_elt): New prototype.
1095
1096 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1097
1098         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1099         remove disabled code block.
1100
1101 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1102
1103         * gdbarch.sh (get_thread_local_address): New method.
1104         * gdbarch.h, gdbarch.c: Regenerate.
1105         * target.c (target_translate_tls_address): Use
1106         gdbarch_get_thread_local_address if present instead of
1107         target::get_thread_local_address.
1108
1109 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1110
1111         * target.h (target::get_thread_local_address): Update comment.
1112
1113 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1114
1115         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1116         objfile->separate_debug_objfile_backlink if not NULL.
1117
1118 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1119
1120         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1121         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1122         (amd64bsd_store_inferior_registers): Likewise.
1123         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1124         Enable segment base registers.
1125         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1126         PT_GETFSBASE and PT_GETGSBASE.
1127         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1128         PT_SETGSBASE.
1129         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1130         segment base registers.
1131         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1132
1133 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1134
1135         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1136         Update calls to i386_target_description to add 'segments'
1137         parameter.
1138         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1139         add segment base registers.
1140         * arch/i386.c (i386_create_target_description): Add 'segments'
1141         parameter to enable segment base registers.
1142         * arch/i386.h (i386_create_target_description): Likewise.
1143         * features/i386/32bit-segments.xml: New file.
1144         * features/i386/32bit-segments.c: Generate.
1145         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1146         call to i386_target_description to add 'segments' parameter.
1147         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1148         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1149         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1150         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1151         if feature is present.
1152         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1153         Add 'segments' parameter to call to i386_target_description.
1154         (i386_target_description): Add 'segments' parameter to enable
1155         segment base registers.
1156         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1157         to call to i386_target_description.
1158         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1159         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1160         Define I386_NUM_REGS.
1161         (i386_target_description): Add 'segments' parameter to enable
1162         segment base registers.
1163
1164 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1165
1166         PR/24325
1167         * source-cache.c: #undef open and close, to avoid unresolved
1168         externals during linking.
1169
1170 2019-03-12  Tom Tromey  <tromey@adacore.com>
1171
1172         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1173         const.  Add initializers.
1174         (_initialize_remote): Don't initialize ptid globals.
1175
1176 2019-03-12  Pedro Alves  <palves@redhat.com>
1177
1178         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1179
1180 2019-03-12  Pedro Alves  <palves@redhat.com>
1181
1182         * cp-name-parser.y (main): Remove unused 'len' variable.
1183
1184 2019-03-12  Tom Tromey  <tromey@adacore.com>
1185
1186         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1187         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1188
1189 2019-03-12  Tom Tromey  <tromey@adacore.com>
1190
1191         * linux-nat.c (iterate_over_lwps): Update.
1192         (stop_callback): Remove parameter.
1193         (stop_wait_callback, detach_callback, resume_set_callback)
1194         (select_singlestep_lwp_callback, set_ignore_sigint)
1195         (status_callback, resumed_callback, resume_clear_callback)
1196         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1197         data parameter.
1198         (linux_nat_target::detach, linux_nat_target::resume)
1199         (linux_stop_and_wait_all_lwps, select_event_lwp)
1200         (linux_nat_filter_event, linux_nat_wait_1)
1201         (linux_nat_target::kill, linux_nat_target::stop)
1202         (linux_nat_target::stop): Update.
1203         (linux_nat_resume_callback): Change type.
1204         (resume_stopped_resumed_lwps, count_events_callback)
1205         (select_event_lwp_callback): Likewise.
1206         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1207         * arm-linux-nat.c (struct update_registers_data): Remove.
1208         (update_registers_callback): Change type.
1209         (arm_linux_insert_hw_breakpoint1): Update.
1210         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1211         parameter.
1212         (x86_linux_dr_set_addr): Update.
1213         (x86_linux_dr_set_control): Update.
1214         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1215         (iterate_over_lwps): Use gdb::function_view.
1216         * nat/aarch64-linux-hw-point.c (struct
1217         aarch64_dr_update_callback_param): Remove.
1218         (debug_reg_change_callback): Change type.
1219         (aarch64_notify_debug_reg_change): Update.
1220         * s390-linux-nat.c (s390_refresh_per_info): Update.
1221
1222 2019-03-11  Tom Tromey  <tromey@adacore.com>
1223
1224         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1225         redundant assignment to "this_cu".
1226
1227 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1228
1229         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1230
1231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1232
1233         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1234         from...
1235         (rank_one_type): ... this.
1236
1237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1238
1239         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1240         from...
1241         (rank_one_type): ... this.
1242
1243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1244
1245         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1246         from...
1247         (rank_one_type): ... this.
1248
1249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1250
1251         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1252         from...
1253         (rank_one_type): ... this.
1254
1255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1256
1257         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1258         from...
1259         (rank_one_type): ... this.
1260
1261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1262
1263         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1264         from...
1265         (rank_one_type): ... this.
1266
1267 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1268
1269         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1270         from...
1271         (rank_one_type): ... this.
1272
1273 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1274
1275         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1276         from...
1277         (rank_one_type): ... this.
1278
1279 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1280
1281         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1282         from...
1283         (rank_one_type): ... this.
1284
1285 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1286
1287         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1288         from...
1289         (rank_one_type): ... this.
1290
1291 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1292
1293         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1294         from...
1295         (rank_one_type): ... this.
1296
1297 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1298
1299         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1300         from...
1301         (rank_one_type): ... this.
1302
1303 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1304
1305         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1306         inferior-events' shows the example events.
1307
1308 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1309
1310         Support styling on native MS-Windows console
1311
1312         PR/24315
1313         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1314         on MS-Windows if $TERM is not defined.
1315
1316         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1317
1318         * posix-hdep.c (gdb_console_fputs):
1319         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1320         functions.
1321         * ui-file.h (gdb_console_fputs): Add prototype.
1322
1323         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1324         back to fputs only if the former returns zero.
1325
1326 2019-03-07  Tom Tromey  <tom@tromey.com>
1327
1328         * symmisc.c (print_symbol_bcache_statistics): Update.
1329         (print_objfile_statistics): Update.
1330         * symfile.c (allocate_symtab): Update.
1331         * stabsread.c: Don't include bcache.h.
1332         * psymtab.h (struct psymbol_bcache): Don't declare.
1333         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1334         (psymbol_bcache_init, psymbol_bcache_free)
1335         (psymbol_bcache_get_bcache): Don't declare.
1336         * psymtab.c (struct psymbol_bcache): Remove.
1337         (psymtab_storage::psymtab_storage): Update.
1338         (psymtab_storage::~psymtab_storage): Update.
1339         (psymbol_bcache_init, psymbol_bcache_free)
1340         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1341         (add_psymbol_to_bcache): Update.
1342         (allocate_psymtab): Update.
1343         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1344         macro_cache>: No longer pointers.
1345         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1346         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1347         * macrotab.c (macro_bcache): Update.
1348         * macroexp.c: Don't include bcache.h.
1349         * gdbtypes.c (check_types_worklist): Update.
1350         (types_deeply_equal): Remove TRY/CATCH.  Update.
1351         * elfread.c (elf_symtab_read): Update.
1352         * dwarf2read.c: Don't include bcache.h.
1353         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1354         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1355         (print_bcache_statistics, bcache_memory_used): Don't declare.
1356         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1357         methods.  Rename all data members.
1358         * bcache.c (struct bcache): Move to bcache.h.
1359         (bcache::expand_hash_table): Rename from expand_hash_table.
1360         (bcache): Remove.
1361         (bcache::insert): Rename from bcache_full.
1362         (bcache::compare): Rename from bcache_compare.
1363         (bcache_xmalloc): Remove.
1364         (bcache::~bcache): Rename from bcache_xfree.
1365         (bcache::print_statistics): Rename from print_bcache_statistics.
1366         (bcache::memory_used): Rename from bcache_memory_used.
1367
1368 2019-03-07  Pedro Alves  <palves@redhat.com>
1369
1370         * infrun.c (normal_stop): Also check for
1371         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1372
1373 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1374
1375         * f-lang.c (value_from_host_double): Moved to...
1376         * value.c (value_from_host_double): ...here.
1377         * value.h (value_from_host_double): Declare.
1378         * guile/scm-math.c (vlscm_convert_typed_number): Use
1379         value_from_host_double.
1380         (vlscm_convert_number): Likewise.
1381         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1382         * python/py-value.c (convert_value_from_python): Likewise.
1383
1384 2019-03-06  Tom Tromey  <tom@tromey.com>
1385
1386         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1387
1388 2019-03-06  Tom Tromey  <tom@tromey.com>
1389
1390         * utils.h (free_current_contents): Don't declare.
1391         * utils.c (free_current_contents): Remove.
1392
1393 2019-03-06  Tom Tromey  <tom@tromey.com>
1394
1395         * top.c (quit_force): Update.
1396         * main.c (captured_command_loop): Update.
1397         * common/new-op.c (operator new): Update.
1398         * common/common-exceptions.c (struct catcher)
1399         <save_cleanup_chain>: Remove member.
1400         (exceptions_state_mc_init): Update.
1401         (exception_try_scope_entry): Return nullptr.
1402         (exception_try_scope_exit, exception_rethrow)
1403         (throw_exception_sjlj, throw_exception_cxx): Update.
1404         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1405         (all_cleanups, do_cleanups, discard_cleanups)
1406         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1407         (restore_cleanups, restore_final_cleanups): Don't declare.
1408         (do_final_cleanups): Remove parameter.
1409         * common/cleanups.c (cleanup_chain, make_cleanup)
1410         (make_cleanup_dtor, all_cleanups, do_cleanups)
1411         (discard_my_cleanups, discard_cleanups)
1412         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1413         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1414         (null_cleanup): Remove.
1415         (do_final_cleanups): Remove parameter.
1416
1417 2019-03-06  Tom Tromey  <tom@tromey.com>
1418
1419         * remote.c (remote_target::remote_parse_stop_reply): Use
1420         unique_xmalloc_ptr.
1421
1422 2019-03-06  Tom Tromey  <tom@tromey.com>
1423
1424         * stabsread.c (struct stabs_field_info): Rename from field_info.
1425         <list, fnlist>: Add initializers.
1426         <obstack>: New member.
1427         (read_member_functions, read_struct_fields, read_baseclasses):
1428         Allocate on obstack.  Don't use cleanups.
1429         (read_one_struct_field, read_member_functions, read_struct_fields)
1430         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1431         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1432         (read_struct_type): Update.
1433
1434 2019-03-06  Tom Tromey  <tom@tromey.com>
1435
1436         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1437         * common/filestuff.h (make_cleanup_close): Don't declare.
1438         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1439         Remove.
1440
1441 2019-03-06  Tom Tromey  <tom@tromey.com>
1442
1443         * solib-aix.c: Use make_scope_exit.
1444
1445 2019-03-06  Tom Tromey  <tom@tromey.com>
1446
1447         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1448         Use make_scope_exit.
1449
1450 2019-03-06  Tom Tromey  <tom@tromey.com>
1451
1452         * solib-svr4.c (disable_probes_interface): Remove parameter.
1453         (svr4_handle_solib_event): Use make_scope_exit.
1454
1455 2019-03-06  Tom Tromey  <tom@tromey.com>
1456
1457         * remote.c (struct stop_reply_deleter): Remove.
1458         (stop_reply_up): Update.
1459         (struct stop_reply): Derive from notif_event.  Don't typedef.
1460         <regcache>: Now a std::vector.
1461         (stop_reply_xfree): Remove.
1462         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1463         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1464         (remote_target::discard_pending_stop_replies): Use delete.
1465         (remote_target::remote_parse_stop_reply): Update.
1466         (remote_target::process_stop_reply): Update.
1467         * remote-notif.h (struct notif_event): Add virtual destructor.
1468         Remove "dtr" member.
1469         (struct notif_client) <alloc_event>: Return a unique_ptr.
1470         (notif_event_xfree): Don't declare.
1471         (notif_event_up): New typedef.
1472         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1473         (notif_event_xfree, do_notif_event_xfree): Remove.
1474         (remote_notif_state_xfree): Update.
1475
1476 2019-03-06  Tom Tromey  <tom@tromey.com>
1477
1478         * infrun.c (displaced_step_clear_cleanup): Now a
1479         forward_scope_exit type.
1480         (displaced_step_prepare_throw): Update.
1481         (displaced_step_fixup): Update.
1482
1483 2019-03-06  Tom Tromey  <tom@tromey.com>
1484
1485         * inferior.h (class inferior): Update comment.
1486         * gdbthread.h (class thread_info): Update comment.
1487
1488 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1489             Tom Tromey  <tom@tromey.com>
1490
1491         * stabsread.h (struct stab_section_list): Remove.
1492         (coffstab_build_psymtabs): Update.
1493         * dbxread.c (symbuf_sections): Now a std::vector.
1494         (sect_idx): New global.
1495         (fill_symbuf): Update.
1496         (coffstab_build_psymtabs): Change type of stabsects parameter.
1497         Update.
1498         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1499         std::vector.
1500         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1501         (coff_locate_sections): Update.
1502         (coff_symfile_read): Remove cleanups.  Update.
1503         (init_stringtab): Add storage parameter.
1504         (free_stringtab, free_stringtab_cleanup): Remove.
1505         (init_lineno): Add storage parameter.
1506         (free_linetab, free_linetab_cleanup): Remove.
1507
1508 2019-03-06  Pedro Alves  <palves@redhat.com>
1509
1510         * linux-fork.c (fork_info::clobber_regs): Delete.
1511         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1512         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1513         comment.  Adjust.
1514         (scoped_switch_fork_info::scoped_switch_fork_info)
1515         (checkpoint_command, linux_fork_context): Adjust
1516         fork_save_infrun_state calls.
1517
1518 2019-03-06  Pedro Alves  <palves@redhat.com>
1519
1520         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1521         (inf_has_multiple_threads): Return 'bool' and rewrite using
1522         inferior_info::threads().
1523
1524 2019-03-06  Pedro Alves  <palves@redhat.com>
1525
1526         * linux-fork.c: Include <list>.
1527         (fork_list): Now a std::list instance.
1528         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1529         (forks_exist_p, find_last_fork): Adjust.
1530         (new_fork): Delete.
1531         (one_fork_p): New.
1532         (add_fork): Adjust.
1533         (free_fork): Delete, folded into fork_info::~fork_info().
1534         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1535         Adjust.
1536         (init_fork_list): Delete.
1537         (linux_fork_killall, linux_fork_mourn_inferior)
1538         (linux_fork_detach, info_checkpoints_command): Adjust.
1539         (_initialize_linux_fork): No longer call init_fork_list.
1540
1541 2019-03-06  Pedro Alves  <palves@redhat.com>
1542
1543         * linux-fork.c (new_fork): New, split out of ...
1544         (add_fork): ... this.  Return void.  Move "first fork" special
1545         case from here, to ...
1546         (checkpoint_command): ... here.
1547         * linux-linux.h (add_fork): Return void.
1548
1549 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1550
1551         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1552
1553 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1554             Chris January  <chris.january@arm.com>
1555             David Lecomber  <david.lecomber@arm.com>
1556
1557         * f-exp.y: New token, UNOP_INTRINSIC.
1558         (exp): New pattern using UNOP_INTRINSIC token.
1559         (f77_keywords): Add 'abs' keyword.
1560         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1561         (value_from_host_double): New function.
1562         (evaluate_subexp_f): Support UNOP_ABS.
1563
1564 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1565
1566         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1567         types.
1568
1569 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1570
1571         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1572         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1573         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1574
1575 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1576
1577         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1578
1579 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1580             Chris January  <chris.january@arm.com>
1581
1582         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1583         * f-exp.y: Define 'KIND' token.
1584         (exp): New pattern for KIND expressions.
1585         (ptype): Handle types with a kind extension.
1586         (direct_abs_decl): Extend to spot kind extensions.
1587         (f77_keywords): Add 'kind' to the list.
1588         (push_kind_type): New function.
1589         (convert_to_kind_type): New function.
1590         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1591         * parse.c (operator_length_standard): Likewise.
1592         * parser-defs.h (enum type_pieces): Add tp_kind.
1593         * std-operator.def: Add UNOP_KIND.
1594
1595 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1596
1597         * f-exp.y (f_parse): Set yydebug.
1598
1599 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1600
1601         * f-lang.c (evaluate_subexp_f): New function.
1602         (exp_descriptor_f): New global.
1603         (f_language_defn): Use exp_descriptor_f instead of
1604         exp_descriptor_standard.
1605
1606 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1607
1608         * f-exp.y (struct token): Add comments.
1609         (dot_ops): Remove uppercase versions and the end marker.
1610         (f77_keywords): Likewise.
1611         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1612         entries in the dot_ops array are case insensitive, and use
1613         strncasecmp to compare strings.  Also some whitespace cleanup in
1614         this area.  Similar for the f77_keywords array, except entries in
1615         this list might be case sensitive.
1616
1617 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1618
1619         * f-exp.y (struct f77_boolean_val): Add comments.
1620         (boolean_values): Remove uppercase versions, and end marker.
1621         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1622         and use strncasecmp to achieve case insensitivity.  Additionally,
1623         perform whitespace cleanup around this code.
1624
1625 2019-03-06  Tom Tromey  <tromey@adacore.com>
1626
1627         * remote-sim.c (gdbsim_target_open): Use result of
1628         gdb_argv::release.
1629
1630 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1631         Dirk Schubert  <dirk.schubert@arm.com>
1632         Chris January  <chris.january@arm.com>
1633
1634         * eval.c (evaluate_subexp_standard): Call Fortran argument
1635         wrapping logic.
1636         * f-lang.c (struct value): A value which can be passed into a
1637         Fortran function call.
1638         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1639         where appropriate.
1640         (struct type): Value ready for a Fortran function call.
1641         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1642         is needed.
1643         * f-lang.h (fortran_argument_convert): Declaration.
1644         (fortran_preserve_arg_pointer): Declaration.
1645         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1646
1647 2019-03-05  Tom Tromey  <tromey@adacore.com>
1648
1649         * python/py-prettyprint.c (print_string_repr): Remove #if.
1650         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1651
1652 2019-03-05  Tom Tromey  <tromey@adacore.com>
1653
1654         * target.c (the_dummy_target): Move later.  Change type to
1655         "dummy_target".
1656         (initialize_targets): Don't initialize the_dummy_target.
1657
1658 2019-03-05  Tom Tromey  <tromey@adacore.com>
1659
1660         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1661         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1662
1663 2019-03-05  Tom Tromey  <tromey@adacore.com>
1664
1665         * windows-nat.c (windows_nat_target::attach)
1666         (windows_nat_target::detach): Don't call gdb_flush.
1667         * valprint.c (generic_val_print, val_print, val_print_string):
1668         Don't call gdb_flush.
1669         * utils.c (defaulted_query): Don't call gdb_flush.
1670         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1671         * target.c (target_announce_detach): Don't call gdb_flush.
1672         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1673         * remote.c (extended_remote_target::attach): Don't call
1674         gdb_flush.
1675         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1676         * printcmd.c (do_examine): Don't call gdb_flush.
1677         (info_display_command): Don't call gdb_flush.
1678         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1679         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1680         * memattr.c (info_mem_command): Don't call gdb_flush.
1681         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1682         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1683         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1684         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1685         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1686         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1687         (gnu_nat_target::detach): Don't call gdb_flush.
1688         * f-valprint.c (f_val_print): Don't call gdb_flush.
1689         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1690         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1691         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1692         gdb_flush.
1693         * c-valprint.c (c_val_print): Don't call gdb_flush.
1694         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1695
1696 2019-03-05  Tom Tromey  <tromey@adacore.com>
1697
1698         * varobj.c (update_dynamic_varobj_children): Update.
1699         (install_default_visualizer): Use reset, not release.
1700         * value.c (set_internalvar): Update.
1701         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1702         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1703         ATTRIBUTE_UNUSED_RESULT.
1704
1705 2019-03-05  Tom Tromey  <tromey@adacore.com>
1706
1707         * remote.c (class scoped_remote_fd) <release>: Add
1708         ATTRIBUTE_UNUSED_RESULT.
1709
1710 2019-03-05  Tom Tromey  <tromey@adacore.com>
1711
1712         * macroexp.c (struct macro_buffer) <release>: Add
1713         ATTRIBUTE_UNUSED_RESULT.
1714
1715 2019-03-05  Tom Tromey  <tromey@adacore.com>
1716
1717         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1718         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1719         ATTRIBUTE_UNUSED_RESULT.
1720
1721 2019-03-05  Tom Tromey  <tromey@adacore.com>
1722
1723         * common/scoped_fd.h (class scoped_fd) <release>: Add
1724         ATTRIBUTE_UNUSED_RESULT.
1725
1726 2019-03-05  Tom Tromey  <tromey@adacore.com>
1727
1728         * parser-defs.h (struct parser_state) <release>: Add
1729         ATTRIBUTE_UNUSED_RESULT.
1730
1731 2019-03-05  Tom Tromey  <tromey@adacore.com>
1732
1733         * utils.h (class gdb_argv) <release>: Add
1734         ATTRIBUTE_UNUSED_RESULT.
1735         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1736
1737 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1738
1739         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1740         for-loop range, to avoid compiler warnings.
1741
1742         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1743         avoid compiler warnings about unused variables.
1744
1745         * NEWS: Mention end of support for native debugging on MS-Windows
1746         before XP.
1747
1748         PR gdb/24292
1749         * common/netstuff.c:
1750         * gdbserver/gdbreplay.c
1751         * gdbserver/remote-utils.c:
1752         * ser-tcp.c:
1753         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1754         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1755         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1756         'getaddrinfo' and 'freeaddrinfo' were not available before
1757         Windows XP, and mingw.org's MinGW headers by default define
1758         _WIN32_WINNT to 0x500.
1759
1760 2019-03-01  Gary Benson <gbenson@redhat.com>
1761
1762         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1763
1764 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1765             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1766
1767         PR gdb/8527
1768         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1769         set_sigint_trap, clear_sigint_trap.
1770
1771 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1772
1773         * target.c (target_detach): Clear the regcache and the
1774         frame cache.
1775
1776 2019-02-27  Pedro Alves  <palves@redhat.com>
1777
1778         * utils.c (set_screen_size): When we cap the height/width sizes,
1779         tweak the corresponding command variable to show "unlimited":
1780
1781 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1782             Pedro Alves  <palves@redhat.com>
1783
1784         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1785         before calling rl_set_screen_size.
1786
1787 2019-02-27  Tom Tromey  <tromey@adacore.com>
1788
1789         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1790         define.
1791         * python/py-value.c: Remove Python 2.4 workaround.
1792         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1793         workaround.
1794         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1795         Python 2.4 workaround.
1796         * python/python-internal.h: Remove Python 2.4 comment.
1797         (Py_ssize_t): Don't define.
1798         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1799         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1800         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1801         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1802         * python/python.c (do_start_initialization): Remove Python 2.4
1803         workaround.
1804         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1805         (print_children): Remove Python 2.4 workaround.
1806         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1807         workaround.
1808         (CHARBUFFERPROC_NAME): Remove.
1809         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1810         Python 2.4 workaround.
1811
1812 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1813
1814         * NEWS: Note minimum Python version.
1815
1816 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1817
1818         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1819         code from these functions.  Remove corresponding ifdefs.  Use
1820         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1821         Remove gotos and target of gotos.
1822         (infpy_search_memory): Likewise.
1823
1824 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1825
1826         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1827         (hppa_gdbarch_init): Don't register deleted functions with
1828         gdbarch.
1829
1830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1831
1832         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1833         (h8300_unwind_sp): Delete.
1834         (h8300_dummy_id): Delete.
1835         (h8300_gdbarch_init): Don't register deleted functions with
1836         gdbarch.
1837
1838 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1839
1840         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1841         (ft32_unwind_pc): Delete.
1842         (ft32_unwind_sp): Delete.
1843         (ft32_gdbarch_init): Don't register deleted functions with
1844         gdbarch.
1845
1846 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1847
1848         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1849         (frv_unwind_pc): Delete.
1850         (frv_unwind_sp): Delete.
1851         (frv_gdbarch_init): Don't register deleted functions with
1852         gdbarch.
1853
1854 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1855
1856         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1857         (riscv_unwind_pc): Delete.
1858         (riscv_unwind_sp): Delete.
1859         (riscv_gdbarch_init): Don't register deleted functions with
1860         gdbarch.
1861
1862 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1863
1864         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1865         (csky_unwind_pc): Delete.
1866         (csky_unwind_sp): Delete.
1867         (csky_gdbarch_init): Don't register deleted functions with
1868         gdbarch.
1869
1870 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1871
1872         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1873         (cris_unwind_pc): Delete.
1874         (cris_unwind_sp): Delete.
1875         (cris_gdbarch_init): Don't register deleted functions with
1876         gdbarch.
1877
1878 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1879
1880         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1881         (bfin_unwind_pc): Delete.
1882         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1883
1884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1885
1886         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1887         (arm_unwind_pc): Delete.
1888         (arm_unwind_sp): Delete.
1889         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1890
1891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1892
1893         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1894         (arc_unwind_pc): Delete.
1895         (arc_unwind_sp): Delete.
1896         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1897
1898 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1899
1900         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1901         (alpha_unwind_pc): Delete.
1902         (alpha_gdbarch_init): Don't register deleted functions with
1903         gdbarch.
1904
1905 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1906
1907         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1908         (aarch64_unwind_pc): Delete.
1909         (aarch64_unwind_sp): Delete.
1910         (aarch64_gdbarch_init): Don't register deleted functions with
1911         gdbarch.
1912
1913 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1914
1915         * gdbtypes.c (type_align): Don't consider static members when
1916         computing structure alignment.
1917
1918 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1921         return 0 for other types.
1922         * arch-utils.c (default_type_align): Always return 0.
1923         * gdbarch.h: Regenerate.
1924         * gdbarch.sh (type_align): Extend comment.
1925         * gdbtypes.c (type_align): Add additional comments, always call
1926         gdbarch_type_align before applying the default rules.
1927         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1928         generic code will then apply a suitable default.
1929         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1930         types, return 0 for other types.
1931
1932 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1933
1934         * NEWS: Create a new section for the next release branch.
1935         Rename the section of the current branch, now that it has
1936         been cut.
1937
1938 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1939
1940         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1941         * version.in: Bump version to 8.3.50.DATE-git.
1942
1943 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1944
1945         * aix-thread.c (ptid_cmp): Remove unused variable.
1946         (get_signaled_thread): Likewise.
1947         (store_regs_user_thread): Likewise.
1948         (store_regs_kernel_thread): Likewise.
1949         (fetch_regs_kernel_thread): Remove shadowed variable.
1950
1951 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1952
1953         * features/riscv/32bit-cpu.xml: Add register numbers.
1954         * features/riscv/32bit-fpu.c: Regenerate.
1955         * features/riscv/32bit-fpu.xml: Add register numbers.
1956         * features/riscv/64bit-cpu.xml: Add register numbers.
1957         * features/riscv/64bit-fpu.c: Regenerate.
1958         * features/riscv/64bit-fpu.xml: Add register numbers.
1959
1960 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1961
1962         * NEWS: Mention two argument form of gdb.Value constructor.
1963         * python/py-value.c (convert_buffer_and_type_to_value): New
1964         function.
1965         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1966         Add support for handling an optional second argument.  Call
1967         convert_buffer_and_type_to_value as appropriate.
1968         * python/python-internal.h (Py_buffer_deleter): New struct.
1969         (Py_buffer_up): New typedef.
1970
1971 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1972
1973         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1974         instead of releasing ownership.
1975
1976 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1977
1978         * dwarf2read.c (open_and_init_dwp_file): Call
1979         elf_numsections instead of bfd_count_sections to initialize
1980         dwp_file->num_sections.
1981
1982 2019-02-25  Tom Tromey  <tromey@adacore.com>
1983
1984         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1985
1986 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1987
1988         * gcore.in: Add '--readnever' option when invoking GDB.
1989
1990 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1991
1992         * MAINTAINERS: Update my email address.
1993
1994 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1995
1996         * build-id.c (build_id_to_debug_bfd_1): New function.
1997         (build_id_to_debug_bfd): Look for separate debug file in
1998         sysroot.
1999
2000 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2001
2002         * gdbarch.sh: Update the copyright year range that is placed into
2003         generated files.
2004
2005 2019-02-22  Keith Seitz  <keiths@redhat.com>
2006
2007         PR symtab/23853
2008         * linespec.c (create_sals_line_offset): Search for the default
2009         symtab's filename instead of its fullname.
2010
2011 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2012
2013         * NEWS: Update style defaults.
2014
2015 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2016
2017         * main.c (captured_main_1): Disable styling in batch mode.
2018
2019 2019-02-20  Tom Tromey  <tom@tromey.com>
2020
2021         * symtab.c (symtab_symbol_info): Fix typos.
2022
2023 2019-02-20  Tom Tromey  <tromey@adacore.com>
2024
2025         * findcmd.c (_initialize_mem_search): Use upper case for
2026         metasyntactic variables.
2027
2028 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2029
2030         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2031         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2032
2033 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2034
2035         * top.h (source_file_name): Change to std::string.
2036         * top.c (source_file_name): Likewise.
2037         (command_line_input): Adjust.
2038         * cli/cli-script.c (script_from_file): Adjust.
2039
2040 2019-02-19  Tom Tromey  <tromey@adacore.com>
2041
2042         * ravenscar-thread.c
2043         (ravenscar_thread_target::update_thread_list): Don't call
2044         ada_build_task_list.
2045         * ada-lang.h (ada_build_task_list): Don't declare.
2046         * ada-tasks.c (struct ada_tasks_inferior_data)
2047         <task_list_valid_p>: Now bool.
2048         (read_known_tasks, ada_task_list_changed)
2049         (ada_tasks_invalidate_inferior_data): Update.
2050         (read_known_tasks_array): Return bool.
2051         (read_known_tasks_list): Likewise.
2052         (read_known_tasks): Return void.
2053         (ada_build_task_list): Now static.
2054
2055 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2056
2057         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2058         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2059
2060 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2061
2062         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2063         variant for ada_tasks_pspace_data_handle and
2064         ada_tasks_inferior_data_handle.
2065         (ada_tasks_pspace_data_cleanup): New function.
2066         (ada_tasks_inferior_data_cleanup): New function.
2067
2068 2019-02-17  Tom Tromey  <tom@tromey.com>
2069
2070         * macrotab.h (macro_source_fullname): Return a std::string.
2071         * macrotab.c (macro_include, check_for_redefinition)
2072         (macro_undef, macro_lookup_definition, foreach_macro)
2073         (foreach_macro_in_scope): Update.
2074         (macro_source_fullname): Return a std::string.
2075         * macrocmd.c (show_pp_source_pos): Update.
2076
2077 2019-02-17  Tom Tromey  <tom@tromey.com>
2078
2079         * macrocmd.c (show_pp_source_pos): Style the file names.
2080
2081 2019-02-17  Tom Tromey  <tom@tromey.com>
2082
2083         PR tui/24197:
2084         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2085
2086 2019-02-17  Tom Tromey  <tom@tromey.com>
2087
2088         * ada-lang.c (user_select_syms): Use filtered printing.
2089         * utils.c (wrap_style): New global.
2090         (desired_style): Remove.
2091         (emit_style_escape): Add stream parameter.
2092         (set_output_style, reset_terminal_style, prompt_for_continue):
2093         Update.
2094         (flush_wrap_buffer): Only flush gdb_stdout.
2095         (wrap_here): Set wrap_style.
2096         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2097         treat escape sequences as a character.  Change when wrap buffer is
2098         flushed.
2099         (fputs_styled): Do not set the output style when the default is
2100         requested.
2101         * ui-style.h (struct ui_file_style) <is_default>: New method.
2102         * source.c (print_source_lines_base): Emit escape sequences in one
2103         piece.
2104
2105 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2106
2107         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2108         integers and enumeration types.
2109
2110 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2111
2112         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2113         instead of lookup_symbol_in_language
2114         (do_exact_match): New function.
2115         (ada_get_symbol_name_matcher): Return do_exact_match when
2116         doing a verbatim match.
2117
2118 2019-02-15  Tom Tromey  <tromey@adacore.com>
2119
2120         * ravenscar-thread.c (ravenscar_thread_target::resume)
2121         (ravenscar_thread_target::wait): Special case wildcard requests.
2122
2123 2019-02-15  Tom Tromey  <tromey@adacore.com>
2124
2125         * ravenscar-thread.c (base_ptid): Remove.
2126         (struct ravenscar_thread_target) <close>: New method.
2127         <m_base_ptid>: New member.
2128         <update_inferior_ptid, active_task, task_is_currently_active,
2129         runtime_initialized>: Declare methods.
2130         <ravenscar_thread_target>: Add constructor.
2131         (ravenscar_thread_target::task_is_currently_active)
2132         (ravenscar_thread_target::update_inferior_ptid)
2133         (ravenscar_runtime_initialized): Rename.  Now methods.
2134         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2135         (ravenscar_thread_target::update_thread_list): Update.
2136         (ravenscar_thread_target::active_task): Now method.
2137         (ravenscar_thread_target::store_registers)
2138         (ravenscar_thread_target::prepare_to_store)
2139         (ravenscar_thread_target::prepare_to_store)
2140         (ravenscar_thread_target::mourn_inferior): Update.
2141         (ravenscar_inferior_created): Use "new" to create target.
2142         (ravenscar_thread_target::get_ada_task_ptid): Update.
2143         (_initialize_ravenscar): Don't initialize base_ptid.
2144         (ravenscar_ops): Remove global.
2145
2146 2019-02-15  Tom Tromey  <tromey@adacore.com>
2147
2148         * target.h (push_target): Declare new overload.
2149         * target.c (push_target): New overload, taking an rvalue reference.
2150         * remote.c (remote_target::open_1): Use push_target overload.
2151         * corelow.c (core_target_open): Use push_target overload.
2152
2153 2019-02-15  Tom Tromey  <tromey@adacore.com>
2154
2155         * ravenscar-thread.c (is_ravenscar_task)
2156         (ravenscar_task_is_currently_active): Return bool.
2157         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2158         (_initialize_ravenscar): Remove "(void)".
2159         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2160         Return bool.
2161
2162 2019-02-15  Tom Tromey  <tromey@adacore.com>
2163
2164         * ravenscar-thread.c (ravenscar_runtime_initializer)
2165         (has_ravenscar_runtime, get_running_thread_id)
2166         (ravenscar_thread_target::resume): Fix indentation.
2167
2168 2019-02-15  Tom Tromey  <tromey@adacore.com>
2169
2170         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2171         from ravenscar_arch_ops.
2172         (sparc_ravenscar_ops::fetch_registers)
2173         (sparc_ravenscar_ops::store_registers): Now methods.
2174         (sparc_ravenscar_prepare_to_store): Remove.
2175         (sparc_ravenscar_ops): Redefine.
2176         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2177         methods and destructor.  Remove members.
2178         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2179         (ravenscar_thread_target::store_registers)
2180         (ravenscar_thread_target::prepare_to_store): Update.
2181         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2182         Remove.
2183         (struct ppc_ravenscar_powerpc_ops): Derive from
2184         ravenscar_arch_ops.
2185         (ppc_ravenscar_powerpc_ops::fetch_registers)
2186         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2187         (ppc_ravenscar_powerpc_ops): Redefine.
2188         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2189         (ppc_ravenscar_e500_ops::fetch_registers)
2190         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2191         (ppc_ravenscar_e500_ops): Redefine.
2192         * aarch64-ravenscar-thread.c
2193         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2194         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2195         (aarch64_ravenscar_fetch_registers)
2196         (aarch64_ravenscar_store_registers): Now methods.
2197         (aarch64_ravenscar_ops): Redefine.
2198
2199 2019-02-15  Tom Tromey  <tromey@adacore.com>
2200
2201         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2202         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2203         (ravenscar_thread_target::stopped_by_watchpoint)
2204         (ravenscar_thread_target::stopped_data_address)
2205         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2206
2207 2019-02-15  Tom Tromey  <tromey@adacore.com>
2208
2209         * ravenscar-thread.c: Fix some typos.
2210
2211 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2212             Tom Tromey  <tromey@adacore.com>
2213
2214         * ada-lang.c (ada_exception_sal): Change addr_string to a
2215         std::string.
2216         (create_ada_exception_catchpoint): Update.
2217
2218 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2219             Tom Tromey  <tromey@adacore.com>
2220
2221         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2222         (bp_location_ops): Remove.
2223         (base_breakpoint_allocate_location): Update.
2224         (free_bp_location): Update.
2225         * ada-lang.c (class ada_catchpoint_location)
2226         <ada_catchpoint_location>: Remove ops parameter.
2227         (ada_catchpoint_location_dtor): Remove.
2228         (ada_catchpoint_location_ops): Remove.
2229         (allocate_location_exception): Update.
2230         * breakpoint.h (struct bp_location_ops): Remove.
2231         (class bp_location) <bp_location>: Remove bp_location_ops
2232         parameter.
2233         <~bp_location>: Add destructor.
2234         <ops>: Remove.
2235
2236 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2237             Pedro Alves  <palves@redhat.com>
2238
2239         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2240         'PATH_MAX'.
2241
2242 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2243             Samuel Thibault  <samuel.thibault@gnu.org>
2244             Thomas Schwinge  <thomas@codesourcery.com>
2245
2246         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2247         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2248
2249 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2250
2251         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2252         (check_empty): Use "const char *".
2253
2254         * gnu-nat.c (gnu_nat_target::detach): Instead of
2255         'detach_inferior (pid)' call
2256         'detach_inferior (find_inferior_pid (pid))'.
2257
2258         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2259         'nat/fork-inferior.o'.
2260         * gnu-nat.c: #include "nat/fork-inferior.h".
2261
2262         * gnu-nat.c (gnu_nat_target::detach): Instead of
2263         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2264         * gnu-nat.h: #include "inf-child.h".
2265         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2266         'i386_gnu_nat_target::fetch_registers'.
2267         (gnu_store_registers): Rename/move to
2268         'i386_gnu_nat_target::store_registers'.
2269
2270         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2271         * gnu-nat.h (mach_thread_info): New function.
2272         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2273
2274         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2275
2276 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2277
2278         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2279
2280 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2281
2282         * windows-nat.c (windows_add_thread): Add new parameter
2283         "main_thread_p" with default value set to false.  Update
2284         function documentation as well as all callers.
2285         (windows_delete_thread): Likewise.
2286         (fake_create_process): Update call to windows_add_thread.
2287         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2288         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2289         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2290         call to windows_delete_thread.
2291
2292 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2293
2294         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2295
2296 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2297
2298         * symfile.c (find_separate_debug_file): Use canonical path of
2299         sysroot with child_path instead of gdb_sysroot if it is valid.
2300
2301 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2302
2303         * symfile.c (find_separate_debug_file): Use child_path to
2304         determine if an object file is under a sysroot.
2305
2306 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2307
2308         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2309         unittests/child-path-selftests.c.
2310         * common/pathstuff.c (child_path): New function.
2311         * common/pathstuff.h (child_path): New prototype.
2312         * unittests/child-path-selftests.c: New file.
2313
2314 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2315
2316         * symfile.c (find_separate_debug_file): Look for separate debug
2317         files in debug directories under the sysroot.
2318
2319 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2320
2321         * symtab.h (struct minimal_symbol data_p): New const method.
2322         (struct minimal_symbol text_p): Likewise.
2323         * symtab.c (output_source_filename): Use file name style
2324         to print file name.
2325         (print_symbol_info): Likewise.
2326         (print_msymbol_info): Use address style to print addresses.
2327         Use function name style to print executable text symbols.
2328         (expand_symtab_containing_pc): Use data_p.
2329         (find_pc_sect_compunit_symtab): Likewise.
2330
2331 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2332
2333         * breakpoint.c (describe_other_breakpoints): Use address style
2334         to print addresses.
2335         (say_where): Likewise.
2336
2337 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2338
2339         * ada-typeprint.c (print_func_type): Print function name
2340         style to print function name.
2341         * c-typeprint.c (c_print_type_1): Likewise.
2342
2343 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2344
2345         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2346         for execve.
2347
2348 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2349
2350         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2351         type_stack.
2352
2353 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2354
2355         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2356         TYPE_CODE_REF types.
2357
2358 2019-02-08  Jim Wilson  <jimw@sifive.com>
2359
2360         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2361         (riscv_linux_fregset): New.
2362         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2363
2364 2019-02-07  Tom Tromey  <tom@tromey.com>
2365
2366         * thread.c (thread_cancel_execution_command): Update.
2367         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2368         methods.
2369         (struct thread_fsm_ops): Remove.
2370         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2371         (thread_fsm_should_stop, thread_fsm_return_value)
2372         (thread_fsm_set_finished, thread_fsm_finished_p)
2373         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2374         Don't declare.
2375         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2376         * infrun.c (clear_proceed_status_thread)
2377         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2378         (print_stop_event): Update.
2379         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2380         Add constructor.
2381         (step_command_fsm_ops): Remove.
2382         (new_step_command_fsm): Remove.
2383         (step_1): Update.
2384         (step_command_fsm::should_stop): Rename from
2385         step_command_fsm_should_stop.
2386         (step_command_fsm::clean_up): Rename from
2387         step_command_fsm_clean_up.
2388         (step_command_fsm::do_async_reply_reason): Rename from
2389         step_command_fsm_async_reply_reason.
2390         (struct until_next_fsm): Inherit from thread_fsm.  Add
2391         constructor.
2392         (until_next_fsm_ops): Remove.
2393         (new_until_next_fsm): Remove.
2394         (until_next_fsm::should_stop): Rename from
2395         until_next_fsm_should_stop.
2396         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2397         (until_next_fsm::do_async_reply_reason): Rename from
2398         until_next_fsm_async_reply_reason.
2399         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2400         constructor.  Change type of breakpoint.
2401         (finish_command_fsm_ops): Remove.
2402         (new_finish_command_fsm): Remove.
2403         (finish_command_fsm::should_stop): Rename from
2404         finish_command_fsm_should_stop.
2405         (finish_command_fsm::clean_up): Rename from
2406         finish_command_fsm_clean_up.
2407         (finish_command_fsm::return_value): Rename from
2408         finish_command_fsm_return_value.
2409         (finish_command_fsm::do_async_reply_reason): Rename from
2410         finish_command_fsm_async_reply_reason.
2411         (finish_command): Update.
2412         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2413         Add constructor.
2414         (call_thread_fsm_ops): Remove.
2415         (call_thread_fsm::call_thread_fsm): Rename from
2416         new_call_thread_fsm.
2417         (call_thread_fsm::should_stop): Rename from
2418         call_thread_fsm_should_stop.
2419         (call_thread_fsm::should_notify_stop): Rename from
2420         call_thread_fsm_should_notify_stop.
2421         (run_inferior_call, call_function_by_hand_dummy): Update.
2422         * cli/cli-interp.c (should_print_stop_to_console): Update.
2423         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2424         Add constructor.  Change type of location_breakpoint,
2425         caller_breakpoint.
2426         (until_break_fsm_ops): Remove.
2427         (new_until_break_fsm): Remove.
2428         (until_break_fsm::should_stop): Rename from
2429         until_break_fsm_should_stop.
2430         (until_break_fsm::clean_up): Rename from
2431         until_break_fsm_clean_up.
2432         (until_break_fsm::do_async_reply_reason): Rename from
2433         until_break_fsm_async_reply_reason.
2434         (until_break_command): Update.
2435         * thread-fsm.c: Remove.
2436         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2437
2438 2019-02-07  Tom Tromey  <tom@tromey.com>
2439
2440         * yy-remap.h: Add include guard.
2441         * xtensa-tdep.h: Add include guard.
2442         * xcoffread.h: Rename include guard.
2443         * varobj-iter.h: Add include guard.
2444         * tui/tui.h: Rename include guard.
2445         * tui/tui-winsource.h: Rename include guard.
2446         * tui/tui-wingeneral.h: Rename include guard.
2447         * tui/tui-windata.h: Rename include guard.
2448         * tui/tui-win.h: Rename include guard.
2449         * tui/tui-stack.h: Rename include guard.
2450         * tui/tui-source.h: Rename include guard.
2451         * tui/tui-regs.h: Rename include guard.
2452         * tui/tui-out.h: Rename include guard.
2453         * tui/tui-layout.h: Rename include guard.
2454         * tui/tui-io.h: Rename include guard.
2455         * tui/tui-hooks.h: Rename include guard.
2456         * tui/tui-file.h: Rename include guard.
2457         * tui/tui-disasm.h: Rename include guard.
2458         * tui/tui-data.h: Rename include guard.
2459         * tui/tui-command.h: Rename include guard.
2460         * tic6x-tdep.h: Add include guard.
2461         * target/waitstatus.h: Rename include guard.
2462         * target/wait.h: Rename include guard.
2463         * target/target.h: Rename include guard.
2464         * target/resume.h: Rename include guard.
2465         * target-float.h: Rename include guard.
2466         * stabsread.h: Add include guard.
2467         * rs6000-tdep.h: Add include guard.
2468         * riscv-fbsd-tdep.h: Add include guard.
2469         * regformats/regdef.h: Rename include guard.
2470         * record.h: Rename include guard.
2471         * python/python.h: Rename include guard.
2472         * python/python-internal.h: Rename include guard.
2473         * python/py-stopevent.h: Rename include guard.
2474         * python/py-ref.h: Rename include guard.
2475         * python/py-record.h: Rename include guard.
2476         * python/py-record-full.h: Rename include guard.
2477         * python/py-record-btrace.h: Rename include guard.
2478         * python/py-instruction.h: Rename include guard.
2479         * python/py-events.h: Rename include guard.
2480         * python/py-event.h: Rename include guard.
2481         * procfs.h: Add include guard.
2482         * proc-utils.h: Add include guard.
2483         * p-lang.h: Add include guard.
2484         * or1k-tdep.h: Rename include guard.
2485         * observable.h: Rename include guard.
2486         * nto-tdep.h: Rename include guard.
2487         * nat/x86-linux.h: Rename include guard.
2488         * nat/x86-linux-dregs.h: Rename include guard.
2489         * nat/x86-gcc-cpuid.h: Add include guard.
2490         * nat/x86-dregs.h: Rename include guard.
2491         * nat/x86-cpuid.h: Rename include guard.
2492         * nat/ppc-linux.h: Rename include guard.
2493         * nat/mips-linux-watch.h: Rename include guard.
2494         * nat/linux-waitpid.h: Rename include guard.
2495         * nat/linux-ptrace.h: Rename include guard.
2496         * nat/linux-procfs.h: Rename include guard.
2497         * nat/linux-osdata.h: Rename include guard.
2498         * nat/linux-nat.h: Rename include guard.
2499         * nat/linux-namespaces.h: Rename include guard.
2500         * nat/linux-btrace.h: Rename include guard.
2501         * nat/glibc_thread_db.h: Rename include guard.
2502         * nat/gdb_thread_db.h: Rename include guard.
2503         * nat/gdb_ptrace.h: Rename include guard.
2504         * nat/fork-inferior.h: Rename include guard.
2505         * nat/amd64-linux-siginfo.h: Rename include guard.
2506         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2507         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2508         * nat/aarch64-linux.h: Rename include guard.
2509         * nat/aarch64-linux-hw-point.h: Rename include guard.
2510         * mn10300-tdep.h: Add include guard.
2511         * mips-linux-tdep.h: Add include guard.
2512         * mi/mi-parse.h: Rename include guard.
2513         * mi/mi-out.h: Rename include guard.
2514         * mi/mi-main.h: Rename include guard.
2515         * mi/mi-interp.h: Rename include guard.
2516         * mi/mi-getopt.h: Rename include guard.
2517         * mi/mi-console.h: Rename include guard.
2518         * mi/mi-common.h: Rename include guard.
2519         * mi/mi-cmds.h: Rename include guard.
2520         * mi/mi-cmd-break.h: Rename include guard.
2521         * m2-lang.h: Add include guard.
2522         * location.h: Rename include guard.
2523         * linux-record.h: Rename include guard.
2524         * linux-nat.h: Add include guard.
2525         * linux-fork.h: Add include guard.
2526         * i386-darwin-tdep.h: Rename include guard.
2527         * hppa-linux-offsets.h: Add include guard.
2528         * guile/guile.h: Rename include guard.
2529         * guile/guile-internal.h: Rename include guard.
2530         * gnu-nat.h: Rename include guard.
2531         * gdb-stabs.h: Rename include guard.
2532         * frv-tdep.h: Add include guard.
2533         * f-lang.h: Add include guard.
2534         * event-loop.h: Add include guard.
2535         * darwin-nat.h: Rename include guard.
2536         * cp-abi.h: Rename include guard.
2537         * config/sparc/nm-sol2.h: Rename include guard.
2538         * config/nm-nto.h: Rename include guard.
2539         * config/nm-linux.h: Add include guard.
2540         * config/i386/nm-i386gnu.h: Rename include guard.
2541         * config/djgpp/nl_types.h: Rename include guard.
2542         * config/djgpp/langinfo.h: Rename include guard.
2543         * compile/gcc-cp-plugin.h: Add include guard.
2544         * compile/gcc-c-plugin.h: Add include guard.
2545         * compile/compile.h: Rename include guard.
2546         * compile/compile-object-run.h: Rename include guard.
2547         * compile/compile-object-load.h: Rename include guard.
2548         * compile/compile-internal.h: Rename include guard.
2549         * compile/compile-cplus.h: Rename include guard.
2550         * compile/compile-c.h: Rename include guard.
2551         * common/xml-utils.h: Rename include guard.
2552         * common/x86-xstate.h: Rename include guard.
2553         * common/version.h: Rename include guard.
2554         * common/vec.h: Rename include guard.
2555         * common/tdesc.h: Rename include guard.
2556         * common/selftest.h: Rename include guard.
2557         * common/scoped_restore.h: Rename include guard.
2558         * common/scoped_mmap.h: Rename include guard.
2559         * common/scoped_fd.h: Rename include guard.
2560         * common/safe-iterator.h: Rename include guard.
2561         * common/run-time-clock.h: Rename include guard.
2562         * common/refcounted-object.h: Rename include guard.
2563         * common/queue.h: Rename include guard.
2564         * common/ptid.h: Rename include guard.
2565         * common/print-utils.h: Rename include guard.
2566         * common/preprocessor.h: Rename include guard.
2567         * common/pathstuff.h: Rename include guard.
2568         * common/observable.h: Rename include guard.
2569         * common/netstuff.h: Rename include guard.
2570         * common/job-control.h: Rename include guard.
2571         * common/host-defs.h: Rename include guard.
2572         * common/gdb_wait.h: Rename include guard.
2573         * common/gdb_vecs.h: Rename include guard.
2574         * common/gdb_unlinker.h: Rename include guard.
2575         * common/gdb_unique_ptr.h: Rename include guard.
2576         * common/gdb_tilde_expand.h: Rename include guard.
2577         * common/gdb_sys_time.h: Rename include guard.
2578         * common/gdb_string_view.h: Rename include guard.
2579         * common/gdb_splay_tree.h: Rename include guard.
2580         * common/gdb_setjmp.h: Rename include guard.
2581         * common/gdb_ref_ptr.h: Rename include guard.
2582         * common/gdb_optional.h: Rename include guard.
2583         * common/gdb_locale.h: Rename include guard.
2584         * common/gdb_assert.h: Rename include guard.
2585         * common/filtered-iterator.h: Rename include guard.
2586         * common/filestuff.h: Rename include guard.
2587         * common/fileio.h: Rename include guard.
2588         * common/environ.h: Rename include guard.
2589         * common/common-utils.h: Rename include guard.
2590         * common/common-types.h: Rename include guard.
2591         * common/common-regcache.h: Rename include guard.
2592         * common/common-inferior.h: Rename include guard.
2593         * common/common-gdbthread.h: Rename include guard.
2594         * common/common-exceptions.h: Rename include guard.
2595         * common/common-defs.h: Rename include guard.
2596         * common/common-debug.h: Rename include guard.
2597         * common/cleanups.h: Rename include guard.
2598         * common/buffer.h: Rename include guard.
2599         * common/btrace-common.h: Rename include guard.
2600         * common/break-common.h: Rename include guard.
2601         * cli/cli-utils.h: Rename include guard.
2602         * cli/cli-style.h: Rename include guard.
2603         * cli/cli-setshow.h: Rename include guard.
2604         * cli/cli-script.h: Rename include guard.
2605         * cli/cli-interp.h: Rename include guard.
2606         * cli/cli-decode.h: Rename include guard.
2607         * cli/cli-cmds.h: Rename include guard.
2608         * charset-list.h: Add include guard.
2609         * buildsym-legacy.h: Rename include guard.
2610         * bfin-tdep.h: Add include guard.
2611         * ax.h: Rename include guard.
2612         * arm-linux-tdep.h: Add include guard.
2613         * arm-fbsd-tdep.h: Add include guard.
2614         * arch/xtensa.h: Rename include guard.
2615         * arch/tic6x.h: Add include guard.
2616         * arch/i386.h: Add include guard.
2617         * arch/arm.h: Rename include guard.
2618         * arch/arm-linux.h: Rename include guard.
2619         * arch/arm-get-next-pcs.h: Rename include guard.
2620         * arch/amd64.h: Add include guard.
2621         * arch/aarch64-insn.h: Rename include guard.
2622         * arch-utils.h: Rename include guard.
2623         * annotate.h: Add include guard.
2624         * amd64-darwin-tdep.h: Rename include guard.
2625         * aarch64-linux-tdep.h: Add include guard.
2626         * aarch64-fbsd-tdep.h: Add include guard.
2627         * aarch32-linux-nat.h: Add include guard.
2628
2629 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2630
2631         * macrotab.c (macro_define_internal): New function that
2632         factorizes macro_define_object_internal and macro_define_function
2633         code.
2634         (macro_define_object_internal): Use macro_define_internal.
2635         (macro_define_function): Likewise.
2636
2637 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2638
2639         * macrocmd.c (extract_identifier): Return
2640         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2641         callers.
2642
2643 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2644
2645         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2646
2647 2019-02-05  Tom Tromey  <tom@tromey.com>
2648
2649         * target.c (target_stack::unpush): Move assertion earlier.
2650
2651 2019-01-30  Tom Tromey  <tom@tromey.com>
2652
2653         PR python/23615:
2654         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2655         (gdbpy_parse_and_eval): Likewise.
2656         * python/python-internal.h (gdbpy_allow_threads): New class.
2657
2658 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2659
2660         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2661         (aarch64_fbsd_fpregmap): Move earlier.
2662         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2663         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2664         instead of individual calls to trad_frame_set_reg_addr.
2665         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2666         earlier.
2667         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2668         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2669         instead of individual calls to trad_frame_set_reg_addr.
2670
2671 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2672
2673         * CONTRIBUTE: Replace contribution list with wiki link.
2674
2675 2019-01-25  Tom Tromey  <tom@tromey.com>
2676
2677         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2678
2679 2019-01-25  Tom Tromey  <tom@tromey.com>
2680
2681         * xtensa-linux-nat.c: Fix common/ includes.
2682         * xml-support.h: Fix common/ includes.
2683         * xml-support.c: Fix common/ includes.
2684         * x86-linux-nat.c: Fix common/ includes.
2685         * windows-nat.c: Fix common/ includes.
2686         * varobj.h: Fix common/ includes.
2687         * varobj.c: Fix common/ includes.
2688         * value.c: Fix common/ includes.
2689         * valops.c: Fix common/ includes.
2690         * utils.c: Fix common/ includes.
2691         * unittests/xml-utils-selftests.c: Fix common/ includes.
2692         * unittests/utils-selftests.c: Fix common/ includes.
2693         * unittests/unpack-selftests.c: Fix common/ includes.
2694         * unittests/tracepoint-selftests.c: Fix common/ includes.
2695         * unittests/style-selftests.c: Fix common/ includes.
2696         * unittests/string_view-selftests.c: Fix common/ includes.
2697         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2698         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2699         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2700         * unittests/rsp-low-selftests.c: Fix common/ includes.
2701         * unittests/parse-connection-spec-selftests.c: Fix common/
2702         includes.
2703         * unittests/optional-selftests.c: Fix common/ includes.
2704         * unittests/offset-type-selftests.c: Fix common/ includes.
2705         * unittests/observable-selftests.c: Fix common/ includes.
2706         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2707         * unittests/memrange-selftests.c: Fix common/ includes.
2708         * unittests/memory-map-selftests.c: Fix common/ includes.
2709         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2710         * unittests/function-view-selftests.c: Fix common/ includes.
2711         * unittests/environ-selftests.c: Fix common/ includes.
2712         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2713         * unittests/common-utils-selftests.c: Fix common/ includes.
2714         * unittests/cli-utils-selftests.c: Fix common/ includes.
2715         * unittests/array-view-selftests.c: Fix common/ includes.
2716         * ui-file.c: Fix common/ includes.
2717         * tui/tui-io.c: Fix common/ includes.
2718         * tracepoint.h: Fix common/ includes.
2719         * tracepoint.c: Fix common/ includes.
2720         * tracefile-tfile.c: Fix common/ includes.
2721         * top.h: Fix common/ includes.
2722         * top.c: Fix common/ includes.
2723         * thread.c: Fix common/ includes.
2724         * target/waitstatus.h: Fix common/ includes.
2725         * target/waitstatus.c: Fix common/ includes.
2726         * target.h: Fix common/ includes.
2727         * target.c: Fix common/ includes.
2728         * target-memory.c: Fix common/ includes.
2729         * target-descriptions.c: Fix common/ includes.
2730         * symtab.h: Fix common/ includes.
2731         * symfile.c: Fix common/ includes.
2732         * stap-probe.c: Fix common/ includes.
2733         * spu-linux-nat.c: Fix common/ includes.
2734         * sparc-nat.c: Fix common/ includes.
2735         * source.c: Fix common/ includes.
2736         * solib.c: Fix common/ includes.
2737         * solib-target.c: Fix common/ includes.
2738         * ser-unix.c: Fix common/ includes.
2739         * ser-tcp.c: Fix common/ includes.
2740         * ser-pipe.c: Fix common/ includes.
2741         * ser-base.c: Fix common/ includes.
2742         * selftest-arch.c: Fix common/ includes.
2743         * s12z-tdep.c: Fix common/ includes.
2744         * rust-exp.y: Fix common/ includes.
2745         * rs6000-aix-tdep.c: Fix common/ includes.
2746         * riscv-tdep.c: Fix common/ includes.
2747         * remote.c: Fix common/ includes.
2748         * remote-notif.h: Fix common/ includes.
2749         * remote-fileio.h: Fix common/ includes.
2750         * remote-fileio.c: Fix common/ includes.
2751         * regcache.h: Fix common/ includes.
2752         * regcache.c: Fix common/ includes.
2753         * record-btrace.c: Fix common/ includes.
2754         * python/python.c: Fix common/ includes.
2755         * python/py-type.c: Fix common/ includes.
2756         * python/py-inferior.c: Fix common/ includes.
2757         * progspace.h: Fix common/ includes.
2758         * producer.c: Fix common/ includes.
2759         * procfs.c: Fix common/ includes.
2760         * proc-api.c: Fix common/ includes.
2761         * printcmd.c: Fix common/ includes.
2762         * ppc-linux-nat.c: Fix common/ includes.
2763         * parser-defs.h: Fix common/ includes.
2764         * osdata.c: Fix common/ includes.
2765         * obsd-nat.c: Fix common/ includes.
2766         * nat/x86-linux.c: Fix common/ includes.
2767         * nat/x86-linux-dregs.c: Fix common/ includes.
2768         * nat/x86-dregs.h: Fix common/ includes.
2769         * nat/x86-dregs.c: Fix common/ includes.
2770         * nat/ppc-linux.c: Fix common/ includes.
2771         * nat/mips-linux-watch.h: Fix common/ includes.
2772         * nat/mips-linux-watch.c: Fix common/ includes.
2773         * nat/linux-waitpid.c: Fix common/ includes.
2774         * nat/linux-ptrace.h: Fix common/ includes.
2775         * nat/linux-ptrace.c: Fix common/ includes.
2776         * nat/linux-procfs.c: Fix common/ includes.
2777         * nat/linux-personality.c: Fix common/ includes.
2778         * nat/linux-osdata.c: Fix common/ includes.
2779         * nat/linux-namespaces.c: Fix common/ includes.
2780         * nat/linux-btrace.h: Fix common/ includes.
2781         * nat/linux-btrace.c: Fix common/ includes.
2782         * nat/fork-inferior.c: Fix common/ includes.
2783         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2784         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2785         * nat/aarch64-linux.c: Fix common/ includes.
2786         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2787         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2788         * namespace.h: Fix common/ includes.
2789         * mips-linux-tdep.c: Fix common/ includes.
2790         * minsyms.c: Fix common/ includes.
2791         * mi/mi-parse.h: Fix common/ includes.
2792         * mi/mi-main.c: Fix common/ includes.
2793         * mi/mi-cmd-env.c: Fix common/ includes.
2794         * memrange.h: Fix common/ includes.
2795         * memattr.c: Fix common/ includes.
2796         * maint.h: Fix common/ includes.
2797         * maint.c: Fix common/ includes.
2798         * main.c: Fix common/ includes.
2799         * machoread.c: Fix common/ includes.
2800         * location.c: Fix common/ includes.
2801         * linux-thread-db.c: Fix common/ includes.
2802         * linux-nat.c: Fix common/ includes.
2803         * linux-fork.c: Fix common/ includes.
2804         * inline-frame.c: Fix common/ includes.
2805         * infrun.c: Fix common/ includes.
2806         * inflow.c: Fix common/ includes.
2807         * inferior.h: Fix common/ includes.
2808         * inferior.c: Fix common/ includes.
2809         * infcmd.c: Fix common/ includes.
2810         * inf-ptrace.c: Fix common/ includes.
2811         * inf-child.c: Fix common/ includes.
2812         * ia64-linux-nat.c: Fix common/ includes.
2813         * i387-tdep.c: Fix common/ includes.
2814         * i386-tdep.c: Fix common/ includes.
2815         * i386-linux-tdep.c: Fix common/ includes.
2816         * i386-linux-nat.c: Fix common/ includes.
2817         * i386-go32-tdep.c: Fix common/ includes.
2818         * i386-fbsd-tdep.c: Fix common/ includes.
2819         * i386-fbsd-nat.c: Fix common/ includes.
2820         * guile/scm-type.c: Fix common/ includes.
2821         * guile/guile.c: Fix common/ includes.
2822         * go32-nat.c: Fix common/ includes.
2823         * gnu-nat.c: Fix common/ includes.
2824         * gdbthread.h: Fix common/ includes.
2825         * gdbarch-selftests.c: Fix common/ includes.
2826         * gdb_usleep.c: Fix common/ includes.
2827         * gdb_select.h: Fix common/ includes.
2828         * gdb_bfd.c: Fix common/ includes.
2829         * gcore.c: Fix common/ includes.
2830         * fork-child.c: Fix common/ includes.
2831         * findvar.c: Fix common/ includes.
2832         * fbsd-nat.c: Fix common/ includes.
2833         * event-top.c: Fix common/ includes.
2834         * event-loop.c: Fix common/ includes.
2835         * dwarf2read.c: Fix common/ includes.
2836         * dwarf2loc.c: Fix common/ includes.
2837         * dwarf2-frame.c: Fix common/ includes.
2838         * dwarf-index-cache.c: Fix common/ includes.
2839         * dtrace-probe.c: Fix common/ includes.
2840         * disasm-selftests.c: Fix common/ includes.
2841         * defs.h: Fix common/ includes.
2842         * csky-tdep.c: Fix common/ includes.
2843         * cp-valprint.c: Fix common/ includes.
2844         * cp-support.h: Fix common/ includes.
2845         * cp-support.c: Fix common/ includes.
2846         * corelow.c: Fix common/ includes.
2847         * completer.h: Fix common/ includes.
2848         * completer.c: Fix common/ includes.
2849         * compile/compile.c: Fix common/ includes.
2850         * compile/compile-loc2c.c: Fix common/ includes.
2851         * compile/compile-cplus-types.c: Fix common/ includes.
2852         * compile/compile-cplus-symbols.c: Fix common/ includes.
2853         * command.h: Fix common/ includes.
2854         * cli/cli-dump.c: Fix common/ includes.
2855         * cli/cli-cmds.c: Fix common/ includes.
2856         * charset.c: Fix common/ includes.
2857         * build-id.c: Fix common/ includes.
2858         * btrace.h: Fix common/ includes.
2859         * btrace.c: Fix common/ includes.
2860         * breakpoint.h: Fix common/ includes.
2861         * breakpoint.c: Fix common/ includes.
2862         * ax.h:
2863         (enum agent_op): Fix common/ includes.
2864         * ax-general.c (struct aop_map): Fix common/ includes.
2865         * ax-gdb.c: Fix common/ includes.
2866         * auxv.c: Fix common/ includes.
2867         * auto-load.c: Fix common/ includes.
2868         * arm-tdep.c: Fix common/ includes.
2869         * arch/riscv.c: Fix common/ includes.
2870         * arch/ppc-linux-common.c: Fix common/ includes.
2871         * arch/i386.c: Fix common/ includes.
2872         * arch/arm.c: Fix common/ includes.
2873         * arch/arm-linux.c: Fix common/ includes.
2874         * arch/arm-get-next-pcs.c: Fix common/ includes.
2875         * arch/amd64.c: Fix common/ includes.
2876         * arch/aarch64.c: Fix common/ includes.
2877         * arch/aarch64-insn.c: Fix common/ includes.
2878         * arch-utils.c: Fix common/ includes.
2879         * amd64-windows-tdep.c: Fix common/ includes.
2880         * amd64-tdep.c: Fix common/ includes.
2881         * amd64-sol2-tdep.c: Fix common/ includes.
2882         * amd64-obsd-tdep.c: Fix common/ includes.
2883         * amd64-nbsd-tdep.c: Fix common/ includes.
2884         * amd64-linux-tdep.c: Fix common/ includes.
2885         * amd64-linux-nat.c: Fix common/ includes.
2886         * amd64-fbsd-tdep.c: Fix common/ includes.
2887         * amd64-fbsd-nat.c: Fix common/ includes.
2888         * amd64-dicos-tdep.c: Fix common/ includes.
2889         * amd64-darwin-tdep.c: Fix common/ includes.
2890         * agent.c: Fix common/ includes.
2891         * ada-lang.h: Fix common/ includes.
2892         * ada-lang.c: Fix common/ includes.
2893         * aarch64-tdep.c: Fix common/ includes.
2894
2895 2019-01-25  Tom Tromey  <tom@tromey.com>
2896
2897         * common/create-version.sh: Use common/version.h.
2898
2899 2019-01-24  Pedro Alves  <palves@redhat.com>
2900
2901         * infrun.c (signal_stop, signal_print, signal_program)
2902         (signal_catch, signal_pass): Now arrays instead of pointers.
2903         (update_signals_program_target, do_target_resume)
2904         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2905         * linux-nat.c (linux_nat_target::pass_signals)
2906         (linux_nat_target::create_inferior, linux_nat_target::attach):
2907         Adjust.
2908         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2909         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2910         * procfs.c (procfs_target::pass_signals): Adjust.
2911         * record-full.c (record_full_target::resume): Adjust.
2912         * remote.c (remote_target::pass_signals)
2913         (remote_target::program_signals): Adjust.
2914         * target-debug.h (target_debug_print_signals): Now takes a
2915         gdb::array_view as parameter.  Adjust.
2916         * target.h (target_ops) <pass_signals, program_signals>: Replace
2917         pointer and length parameters with gdb::array_view.
2918         (target_pass_signals, target_program_signals): Likewise.
2919         * target-delegates.c: Regenerate.
2920
2921 2019-01-24  Pedro Alves  <palves@redhat.com>
2922
2923         * common/forward-scope-exit.h
2924         (forward_scope_exit::forward_scope_exit): Pass arguments to
2925         m_bind_function directly, instead of creating a std::bind and
2926         copying that.
2927
2928 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2929
2930         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2931         for static members.
2932         (pass_in_v_vfp_candidate): Likewise.
2933
2934 2019-01-23  Tom Tromey  <tom@tromey.com>
2935             Pedro Alves  <palves@redhat.com>
2936
2937         * regcache.c (class regcache_invalidator): Remove.
2938         (regcache::raw_write): Use make_scope_exit.
2939
2940 2019-01-23  Tom Tromey  <tom@tromey.com>
2941
2942         * ui-out.h (class ui_out_emit_type): Update comment.
2943
2944 2019-01-23  Tom Tromey  <tom@tromey.com>
2945
2946         * infrun.c (fetch_inferior_event): Update comment.
2947
2948 2019-01-23  Tom Tromey  <tom@tromey.com>
2949             Pedro Alves  <palves@redhat.com>
2950
2951         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2952         parameter.
2953         (fetch_inferior_event): Use SCOPE_EXIT.
2954
2955
2956 2019-01-23  Tom Tromey  <tom@tromey.com>
2957             Pedro Alves  <palves@redhat.com>
2958
2959         * infrun.c (disable_thread_events): Delete.
2960         (stop_all_threads): Use SCOPE_EXIT.
2961
2962 2019-01-23  Tom Tromey  <tom@tromey.com>
2963             Pedro Alves  <palves@redhat.com>
2964
2965         * symfile.c: Include forward-scope-exit.h.
2966         (clear_symtab_users_cleanup): Replace forward declaration with
2967         a FORWARD_SCOPE_EXIT.
2968         (syms_from_objfile_1): Use the forward_scope_exit and
2969         gdb::optional instead of cleanup_function.
2970         (reread_symbols): Use the forward_scope_exit instead of
2971         cleanup_function.
2972         (clear_symtab_users_cleanup): Remove function.
2973
2974 2019-01-23  Tom Tromey  <tom@tromey.com>
2975             Pedro Alves  <palves@redhat.com>
2976
2977         * linux-nat.c: Include scope-exit.h.
2978         (cleanup_target_stop): Remove.
2979         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2980         SCOPE_EXIT.
2981
2982 2019-01-23  Tom Tromey  <tom@tromey.com>
2983             Pedro Alves  <palves@redhat.com>
2984
2985         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2986         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2987
2988 2019-01-23  Tom Tromey  <tom@tromey.com>
2989             Andrew Burgess  <andrew.burgess@embecosm.com>
2990             Pedro Alves  <palves@redhat.com>
2991
2992         * infrun.c (fetch_inferior_event): Use scope_exit.
2993         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2994         * top.c (execute_command): Use scope_exit.
2995         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2996         * utils.c (do_bpstat_clear_actions_cleanup)
2997         (make_bpstat_clear_actions_cleanup): Remove.
2998
2999 2019-01-23  Tom Tromey  <tom@tromey.com>
3000             Pedro Alves  <palves@redhat.com>
3001
3002         * infrun.c: Include "common/scope-exit.h"
3003         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3004         (wait_for_inferior): Use SCOPE_EXIT.
3005         (fetch_inferior_event): Use scope_exit.
3006
3007 2019-01-23  Tom Tromey  <tom@tromey.com>
3008             Pedro Alves  <palves@redhat.com>
3009
3010         * breakpoint.c (create_breakpoint): Remove cleanup.
3011
3012 2019-01-23  Tom Tromey  <tom@tromey.com>
3013             Andrew Burgess  <andrew.burgess@embecosm.com>
3014             Pedro Alves  <palves@redhat.com>
3015
3016 2019-01-23  Pedro Alves  <palves@redhat.com>
3017
3018         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3019
3020 2019-01-23  Pedro Alves  <palves@redhat.com>
3021             Andrew Burgess  <andrew.burgess@embecosm.com>
3022
3023         * gdbthread.h: Include "common/forward-scope-exit.h".
3024         (scoped_finish_thread_state): Redefine custom class in terms of
3025         forward_scope_exit.
3026
3027 2019-01-23  Pedro Alves  <palves@redhat.com>
3028             Andrew Burgess  <andrew.burgess@embecosm.com>
3029
3030         * common/forward-scope-exit.h: New file.
3031
3032 2019-01-23  Pedro Alves  <palves@redhat.com>
3033             Andrew Burgess  <andrew.burgess@embecosm.com>
3034             Tom Tromey  <tom@tromey.com>
3035
3036         * common/scope-exit.h: New file.
3037
3038 2019-01-23  Pedro Alves  <palves@redhat.com>
3039
3040         * common/preprocessor.h (ESC): Rename to ...
3041         (ESC_PARENS): ... this.
3042         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3043         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3044
3045 2019-01-23  Tom Tromey  <tom@tromey.com>
3046
3047         * language.h (class scoped_switch_to_sym_language_if_auto):
3048         Initialize m_lang in both cases.
3049
3050 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3051
3052         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3053         with XCNEW.
3054
3055 2019-01-22  Tom Tromey  <tom@tromey.com>
3056
3057         * corelow.c: Do not include sys/file.h.
3058
3059 2019-01-22  Tom Tromey  <tom@tromey.com>
3060
3061         * tui/tui-wingeneral.h: Include gdb_curses.h.
3062
3063 2019-01-22  Tom Tromey  <tom@tromey.com>
3064
3065         * source-cache.h (class source_cache) <get_source_lines,
3066         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3067
3068 2019-01-22  Tom Tromey  <tom@tromey.com>
3069
3070         * remote-fileio.h (struct remote_target): Declare.
3071
3072 2019-01-22  Tom Tromey  <tom@tromey.com>
3073
3074         * python/py-arch.c: Do not include py-ref.h.
3075         * python/py-bpevent.c: Do not include py-ref.h.
3076         * python/py-cmd.c: Do not include py-ref.h.
3077         * python/py-continueevent.c: Do not include py-ref.h.
3078         * python/py-event.h: Do not include py-ref.h.
3079         * python/py-evtregistry.c: Do not include py-ref.h.
3080         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3081         * python/py-frame.c: Do not include py-ref.h.
3082         * python/py-framefilter.c: Do not include py-ref.h.
3083         * python/py-function.c: Do not include py-ref.h.
3084         * python/py-infevents.c: Do not include py-ref.h.
3085         * python/py-linetable.c: Do not include py-ref.h.
3086         * python/py-objfile.c: Do not include py-ref.h.
3087         * python/py-param.c: Do not include py-ref.h.
3088         * python/py-prettyprint.c: Do not include py-ref.h.
3089         * python/py-progspace.c: Do not include py-ref.h.
3090         * python/py-symbol.c: Do not include py-ref.h.
3091         * python/py-symtab.c: Do not include py-ref.h.
3092         * python/py-type.c: Do not include py-ref.h.
3093         * python/py-unwind.c: Do not include py-ref.h.
3094         * python/py-utils.c: Do not include py-ref.h.
3095         * python/py-value.c: Do not include py-ref.h.
3096         * python/py-varobj.c: Do not include py-ref.h.
3097         * python/py-xmethods.c: Do not include py-ref.h.
3098         * python/python.c: Do not include py-ref.h.
3099         * varobj.c: Do not include py-ref.h.
3100
3101 2019-01-22  Tom Tromey  <tom@tromey.com>
3102
3103         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3104         keyword for bcache.
3105
3106 2019-01-22  Tom Tromey  <tom@tromey.com>
3107
3108         * compile/compile-cplus-types.c: Remove a comment by #include.
3109
3110 2019-01-22  Tom Tromey  <tom@tromey.com>
3111
3112         * compile/gcc-c-plugin.h: Include compile-internal.h.
3113
3114 2019-01-22  Tom Tromey  <tom@tromey.com>
3115
3116         * stabsread.c (EXTERN): Do not define.
3117         (symnum, next_symbol_text_func, processing_gcc_compilation)
3118         (within_function, global_sym_chain, global_stabs)
3119         (previous_stab_code, this_object_header_files)
3120         (n_this_object_header_files)
3121         (n_allocated_this_object_header_files): Define.
3122         * stabsread.h (EXTERN): Never define.  Use "extern".
3123
3124 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3125
3126         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3127         history_value.
3128
3129 2019-01-21  Tom Tromey  <tom@tromey.com>
3130
3131         * ui-out.c: Fix includes.
3132         * tui/tui-source.c: Fix includes.
3133         * target.c: Fix includes.
3134         * remote.c: Fix includes.
3135         * regcache.c: Fix includes.
3136         * python/py-block.c: Fix includes.
3137         * printcmd.c: Fix includes.
3138         * or1k-tdep.c: Fix includes.
3139         * mi/mi-main.c: Fix includes.
3140         * m32r-tdep.c: Fix includes.
3141         * csky-tdep.c: Fix includes.
3142         * compile/compile-cplus-types.c: Fix includes.
3143         * cli/cli-interp.c: Fix includes.
3144
3145 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3146
3147         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3148         for padding.
3149
3150 2019-01-16  Tom Tromey  <tom@tromey.com>
3151
3152         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3153         earlier.
3154         (struct objfile) <msymbols_range>: Move from top level.
3155         <msymbols>: New method.
3156         (class objfile_msymbols): Remove.
3157         * symtab.c (default_collect_symbol_completion_matches_break_on):
3158         Update.
3159         * symmisc.c (dump_msymbols): Update.
3160         * stabsread.c (scan_file_globals): Update.
3161         * objc-lang.c (info_selectors_command, info_classes_command)
3162         (find_methods): Update.
3163         * minsyms.c (find_solib_trampoline_target): Update.
3164         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3165         * coffread.c (coff_symfile_read): Update.
3166         * ada-lang.c (ada_lookup_simple_minsym)
3167         (ada_collect_symbol_completion_matches): Update.
3168
3169 2019-01-16  Tom Tromey  <tom@tromey.com>
3170
3171         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3172         type.  Remove no-argument constructor.
3173         <iterator::operator++>: Simplify.
3174         <begin>: Update.
3175         <end>: Use minimal_symbol_count.
3176
3177 2019-01-16  Tom Tromey  <tom@tromey.com>
3178
3179         * objfiles.h (struct objfile) <psymtabs>: New method.
3180         (class objfile_psymtabs): Remove.
3181         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3182         typedef.
3183         <range>: New method.
3184         (require_partial_symbols): Change return type.
3185         * psymtab.c (require_partial_symbols)
3186         (psym_expand_symtabs_matching): Update.
3187         * mdebugread.c (parse_partial_symbols): Update.
3188         * dbxread.c (dbx_end_psymtab): Update.
3189
3190 2019-01-15  Tom Tromey  <tom@tromey.com>
3191
3192         * symtab.c (lookup_objfile_from_block)
3193         (lookup_symbol_in_objfile_symtabs)
3194         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3195         (find_line_symtab, info_sources_command)
3196         (default_collect_symbol_completion_matches_break_on)
3197         (make_source_files_completion_list): Update.
3198         * symmisc.c (print_objfile_statistics, dump_objfile)
3199         (maintenance_print_symbols, maintenance_info_symtabs)
3200         (maintenance_check_symtabs, maintenance_info_line_tables):
3201         Update.
3202         * source.c (select_source_symtab)
3203         (forget_cached_source_info_for_objfile): Update.
3204         * objfiles.h (class objfile_compunits): Remove.
3205         (struct objfile) <compunits_range>: New typedef.
3206         (compunits): New method.
3207         * objfiles.c (objfile_relocate1): Update.
3208         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3209         * maint.c (count_symtabs_and_blocks): Update.
3210         * linespec.c (iterate_over_all_matching_symtabs): Update.
3211         * cp-support.c (add_symbol_overload_list_qualified): Update.
3212         * coffread.c (coff_symtab_read): Update.
3213         * ada-lang.c (add_nonlocal_symbols)
3214         (ada_collect_symbol_completion_matches)
3215         (ada_add_global_exceptions): Update.
3216
3217 2019-01-15  Tom Tromey  <tom@tromey.com>
3218
3219         * progspace.h (program_space) <objfiles_safe_range>: New
3220         typedef.
3221         <objfiles_safe>: New method.
3222         * objfiles.h (class all_objfiles_safe): Remove.
3223         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3224         * jit.c (jit_inferior_exit_hook): Update.
3225
3226 2019-01-17  Tom Tromey  <tom@tromey.com>
3227
3228         * progspace.h (program_space) <objfiles_range>: New typedef.
3229         <objfiles>: New method.
3230         <objfiles_head>: Rename from objfiles.
3231         (object_files): Update.
3232         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3233         * guile/scm-pretty-print.c
3234         (ppscm_find_pretty_printer_from_objfiles): Update.
3235         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3236         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3237         Update.
3238         * python/py-progspace.c (pspy_get_objfiles): Update.
3239         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3240         Update.
3241         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3242         (objfpy_lookup_objfile_by_build_id): Update.
3243         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3244         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3245         Update.
3246         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3247         (expand_symtab_containing_pc, lookup_objfile_from_block)
3248         (lookup_static_symbol, basic_lookup_transparent_type)
3249         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3250         (find_line_symtab, info_sources_command)
3251         (default_collect_symbol_completion_matches_break_on)
3252         (make_source_files_completion_list, find_main_name): Update.
3253         * symmisc.c (print_symbol_bcache_statistics)
3254         (print_objfile_statistics, maintenance_print_symbols)
3255         (maintenance_print_msymbols, maintenance_print_objfiles)
3256         (maintenance_info_symtabs, maintenance_check_symtabs)
3257         (maintenance_expand_symtabs, maintenance_info_line_tables):
3258         Update.
3259         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3260         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3261         (map_overlay_command, unmap_overlay_command)
3262         (simple_overlay_update, expand_symtabs_matching)
3263         (map_symbol_filenames): Update.
3264         * symfile-debug.c (set_debug_symfile): Update.
3265         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3266         Update.
3267         * source.c (select_source_symtab, forget_cached_source_info):
3268         Update.
3269         * solib.c (solib_read_symbols): Update.
3270         * solib-spu.c (append_ocl_sos): Update.
3271         * psymtab.c (maintenance_print_psymbols)
3272         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3273         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3274         * printcmd.c (info_symbol_command): Update.
3275         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3276         Update.
3277         * objfiles.h (class all_objfiles): Remove.
3278         * objfiles.c (have_partial_symbols, have_full_symbols)
3279         (have_minimal_symbols, qsort_cmp, update_section_map)
3280         (shared_objfile_contains_address_p)
3281         (default_iterate_over_objfiles_in_search_order): Update.
3282         * objc-lang.c (info_selectors_command, info_classes_command)
3283         (find_methods): Update.
3284         * minsyms.c (find_solib_trampoline_target): Update.
3285         * maint.c (maintenance_info_sections)
3286         (maintenance_translate_address, count_symtabs_and_blocks):
3287         Update.
3288         * main.c (captured_main_1): Update.
3289         * linux-thread-db.c (try_thread_db_load_from_pdir)
3290         (has_libpthread): Update.
3291         * linespec.c (iterate_over_all_matching_symtabs)
3292         (search_minsyms_for_name): Update.
3293         * jit.c (jit_find_objf_with_entry_addr): Update.
3294         * hppa-tdep.c (find_unwind_entry)
3295         (hppa_lookup_stub_minimal_symbol): Update.
3296         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3297         Update.
3298         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3299         (elf_gnu_ifunc_resolve_by_got): Update.
3300         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3301         * dwarf-index-write.c (save_gdb_index_command): Update.
3302         * cp-support.c (add_symbol_overload_list_qualified): Update.
3303         * breakpoint.c (create_overlay_event_breakpoint)
3304         (create_longjmp_master_breakpoint)
3305         (create_std_terminate_master_breakpoint)
3306         (create_exception_master_breakpoint): Update.
3307         * blockframe.c (find_pc_partial_function): Update.
3308         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3309         (ada_collect_symbol_completion_matches)
3310         (ada_add_global_exceptions): Update.
3311
3312 2019-01-17  Tom Tromey  <tom@tromey.com>
3313
3314         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3315         declare VEC.
3316         (solib_target_parse_libraries): Change return type.
3317         (library_list_start_segment, library_list_start_section)
3318         (library_list_end_library, library_list_start_library); Update.
3319         (solib_target_free_library_list): Remove.
3320         (solib_target_parse_libraries): Remove cleanup.  Change return
3321         type.
3322         (solib_target_current_sos): Update.
3323
3324 2019-01-17  Tom Tromey  <tromey@bapiya>
3325
3326         * valprint.c: Replace "the the" with "the".
3327         * symtab.c: Replace "the the" with "the".
3328         * solib.c: Replace "the the" with "the".
3329         * solib-dsbt.c: Replace "the the" with "the".
3330         * linespec.c: Replace "the the" with "the".
3331         * dwarf2loc.h: Replace "the the" with "the".
3332         * amd64-windows-tdep.c: Replace "the the" with "the".
3333         * aarch64-tdep.c: Replace "the the" with "the".
3334
3335 2019-01-16  Keith Seitz  <keiths@redhat.com>
3336
3337         PR gdb/23773
3338         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3339         <builder>: Rename to ..
3340         <m_builder>: ... this and make private.
3341         (dwarf2_cu::get_builder): New method.  Change all users of
3342         `builder' to use this method.
3343         (dwarf2_start_symtab): Move to ...
3344         (dwarf2_cu::start_symtab): ... here.  Update all callers
3345         (setup_type_unit_groups): Move to ...
3346         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3347         callers.
3348         (dwarf2_cu::reset_builder): New method.
3349         (process_full_compunit, process_full_type_unit): Use
3350         dwarf2_cu::reset_builder.
3351         (follow_die_offset): Record the ancestor CU if it is different
3352         from the followed DIE's CU.
3353         (follow_die_sig_1): Likewise.
3354
3355 2019-01-15  Tom Tromey  <tom@tromey.com>
3356
3357         * remote.c (class remote_state) <buf>: Now a char_vector.
3358         <buf_size>: Remove.
3359         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3360         parameter.
3361         (remote_target::getpkt_or_notif_sane_1)
3362         (remote_target::getpkt_sane)
3363         (remote_target::getpkt_or_notif_sane): Likewise.
3364         (class remote_target) <putpkt>: New overload.
3365         (remote_target::read_frame): Change type of "buf_p".  Remove
3366         sizeof_p parameter.
3367         (packet_ok): New overload.
3368         (packet_check_result): New overload.
3369         Update all uses.
3370
3371 2019-01-14  Tom Tromey  <tom@tromey.com>
3372
3373         * remote-notif.c (handle_notification, remote_notif_ack)
3374         (remote_notif_parse): Make "buf" const.
3375         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3376         const.
3377         (remote_notif_parse, remote_notif_ack, handle_notification):
3378         Likewise.
3379         * remote.c (remote_notif_stop_parse): Make "buf" const.
3380         (remote_target::remote_parse_stop_reply): Make "buf" const.
3381         (remote_notif_stop_ack): Make "buf" const.
3382
3383 2019-01-14  Tom Tromey  <tom@tromey.com>
3384
3385         * remote.c (remote_console_output): Make parameter const.
3386
3387 2019-01-14  Tom Tromey  <tom@tromey.com>
3388
3389         * target-debug.h (target_debug_print_signals): Constify.
3390         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3391         * procfs.c (procfs_target::pass_signals): Update.
3392         * linux-nat.c (linux_nat_target::pass_signals): Update.
3393         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3394         * target-delegates.c: Rebuild.
3395         * remote.c (remote_target::program_signals): Update.
3396         (remote_target::pass_signals): Update.
3397         * target.c (target_pass_signals): Constify argument.
3398         (target_program_signals): Likewise.
3399         * target.h (struct target_ops) <pass_signals, program_signals>:
3400         Constify argument.
3401         (target_pass_signals, target_program_signals): Constify argument.
3402
3403 2019-01-14  Tom Tromey  <tom@tromey.com>
3404
3405         PR tui/28819:
3406         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3407
3408 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3409
3410         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3411         field.
3412         * rs6000-tdep.c: Include reggroups.h.
3413         (IS_V_ALIAS_PSEUDOREG): Define.
3414         (rs6000_register_name): Return names for the "vX" aliases.
3415         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3416         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3417         aliases.  Call default_register_reggroup_p for all other
3418         pseudo-registers.
3419         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3420         New functions.
3421         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3422         Handle "vX" aliases.
3423         (v_alias_pseudo_register_collect): New function.
3424         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3425         (rs6000_gdbarch_init): Initialize "vX" aliases as
3426         pseudo-registers.  Restore registration of
3427         rs6000_pseudo_register_reggroup_p with
3428         set_tdesc_pseudo_register_reggroup_p.
3429
3430 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3431
3432         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3433         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3434         set_gdbarch_num_pseudo_regs.
3435
3436 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3437
3438         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3439         Remove arg prefixname, add do_set and do_show.
3440         Add member functions set_list and show_list.
3441         * cli/cli-style.c (class cli_style_option): Update accordingly.
3442         (style_set_list): Move to file scope.
3443         (style_show_list): Likewise.
3444         (set_style): Call help_list.
3445         (show_style): Call cmd_show_list.
3446         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3447         Update to use the new macro.
3448
3449 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3450
3451         * ada-lang.c (_initialize_ada_language): Expand the help text
3452         for the "catch exception" command.
3453
3454 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3455
3456         * symtab.c (matching_obj_sections): Initialize obj,
3457         declare it closer to its usage.
3458
3459 2019-01-10  Tom Tromey  <tom@tromey.com>
3460
3461         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3462         (basic_inf_threads_range): Remove.
3463         (inf_threads_range, inf_non_exited_threads_range)
3464         (safe_inf_threads_range): Use next_adapter.
3465
3466 2019-01-10  Keith Seitz  <keiths@redhat.com>
3467
3468         PR gdb/23712
3469         PR symtab/23010
3470         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3471         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3472
3473 2019-01-10  Keith Seitz  <keiths@redhat.com>
3474
3475         PR gdb/23712
3476         PR symtab/23010
3477         * dictionary.c (pending_to_vector): Remove.
3478         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3479         Remove _1 suffix, replacing functions of the same name.  Update
3480         all callers.
3481         (dict_create_hashed, dict_create_hashed_expandable)
3482         (dict_create_linear, dict_create_linear_expandable, dict_free)
3483         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3484         Make functions static.
3485
3486 2019-01-10  Keith Seitz  <keiths@redhat.com>
3487
3488         PR gdb/23712
3489         PR symtab/23010
3490         * dictionary.h (struct dictionary): Replace declaration with
3491         multidictionary.
3492         (dict_create_hashed, dict_create_hashed_expandable)
3493         (dict_create_linear, dict_create_linear_expandable)
3494         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3495         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3496         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3497         taking multidictionary argument.
3498         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3499         * block.h (struct block) <dict>: Change to multidictionary
3500         and rename `multidict'.
3501         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3502         symmisc.c: Update all dictionary references to multidictionary.
3503
3504 2019-01-10  Keith Seitz  <keiths@redhat.com>
3505
3506         PR gdb/23712
3507         PR symtab/23010
3508         * dictionary.c: Include unordered_map.
3509         (pending_to_vector): New function.
3510         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3511         Rewrite the non-"_1" functions to take vector instead
3512         of linked list.
3513         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3514         "new" _1 versions of the same name.
3515         (multidictionary): Define.
3516         (std::hash<enum language): New definition.
3517         (collate_pending_symbols_by_language, mdict_create_hashed)
3518         (mdict_create_hashed_expandable, mdict_create_linear)
3519         (mdict_create_linear_expandable, mdict_free)
3520         (find_language_dictionary, create_new_language_dictionary)
3521         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3522         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3523         (mdict_size, mdict_empty): New functions.
3524         * dictionary.h (mdict_iterator): Define.
3525
3526 2019-01-10  Pedro Alves  <palves@redhat.com>
3527
3528         * breakpoint.c (read_uploaded_action)
3529         (create_tracepoint_from_upload): Adjust to use
3530         gdb::unique_xmalloc_ptr.
3531         * ctf.c (ctf_write_uploaded_tp):
3532         (SET_ARRAY_FIELD): Use emplace_back.
3533         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3534         * tracefile-tfile.c (tfile_write_uploaded_tp):
3535         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3536         gdb::unique_xmalloc_ptr.
3537         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3538         at_string, cond_string, cmd_strings>: Replace char pointers
3539         with gdb::unique_xmalloc_ptr.
3540
3541 2019-01-10  Pedro Alves  <palves@redhat.com>
3542
3543         * solib-target.c (library_list_start_library): Don't xstrdup name.
3544
3545 2019-01-10  Pedro Alves  <palves@redhat.com>
3546
3547         * mdebugread.c (parse_partial_symbols): Use
3548         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3549
3550 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3551
3552         * linux-fork.c (scoped_switch_fork_info)
3553         <~scoped_switch_fork_info>: Fix incorrect variable name.
3554
3555 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3556
3557         * linux-fork.c (scoped_switch_fork_info)
3558         <scoped_switch_fork_info>: Make explicit.
3559         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3560
3561 2019-01-10  Tom Tromey  <tom@tromey.com>
3562
3563         * objfiles.h (objfile::reset_psymtabs): Update.
3564         * objfiles.c (objfile::objfile): Update.
3565         * psymtab.h (psymtab_storage::obstack): Update.
3566         (psymtab_storage::m_obstack): Use gdb::optional.
3567         (class psymtab_storage): Update comment.  Remove objfile
3568         parameter.
3569         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3570
3571 2019-01-10  Tom Tromey  <tom@tromey.com>
3572
3573         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3574         <free_psymtabs>: Now private.
3575         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3576         (allocate_psymtab): Use new method.
3577
3578 2019-01-10  Tom Tromey  <tom@tromey.com>
3579
3580         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3581         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3582         * mdebugread.c (parse_partial_symbols): Use
3583         allocate_dependencies.
3584         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3585         allocate_dependencies.
3586         (process_psymtab_comp_unit_reader)
3587         (build_type_psymtab_dependencies): Likewise.
3588         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3589
3590 2019-01-10  Tom Tromey  <tom@tromey.com>
3591
3592         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3593         PSYMBOL_SET_LANGUAGE.
3594         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3595
3596 2019-01-10  Tom Tromey  <tom@tromey.com>
3597
3598         * psymtab.h (psymtab_storage::obstack): New method.
3599         <m_obstack>: Rename from obstack; now private.
3600         * psymtab.c (psymtab_storage): Update.
3601         * dwarf2read.c (create_addrmap_from_index)
3602         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3603         Update.
3604
3605 2019-01-10  Tom Tromey  <tom@tromey.com>
3606
3607         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3608         * objfiles.h (objfile::reset_psymtabs): New method.
3609
3610 2019-01-10  Tom Tromey  <tom@tromey.com>
3611
3612         * symmisc.c (print_symbol_bcache_statistics): Update.
3613         (print_objfile_statistics): Update.
3614         * symfile.c (reread_symbols): Update.
3615         * psymtab.h (class psymtab_storage): New.
3616         * psymtab.c (psymtab_storage): New constructor.
3617         (~psymtab_storage): New destructor.
3618         (require_partial_symbols): Update.
3619         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3620         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3621         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3622         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3623         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3624         (start_psymtab_common, end_psymtab_common)
3625         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3626         (allocate_psymtab): Update.
3627         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3628         Update.
3629         (dump_psymtab_addrmap, maintenance_print_psymbols)
3630         (maintenance_check_psymtabs): Update.
3631         (class objfile_psymtabs): Move to objfiles.h.
3632         * psympriv.h (discard_psymtab): Now inline.
3633         (psymtab_discarder::psymtab_discarder): Update.
3634         (psymtab_discarder::~psymtab_discarder): Update.
3635         (ALL_OBJFILE_PSYMTABS): Rewrite.
3636         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3637         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3638         Remove fields.
3639         <partial_symtabs>: New field.
3640         (class objfile_psymtabs): Move from psymtab.h.  Update.
3641         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3642         psymbol_cache.
3643         (objfile::~objfile): Don't destroy psymbol_cache.
3644         * mdebugread.c (parse_partial_symbols): Update.
3645         * dwarf2read.c (create_addrmap_from_index)
3646         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3647         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3648         (add_partial_subprogram, dwarf2_ranges_read): Update.
3649         * dwarf-index-write.c (write_address_map)
3650         (write_one_signatured_type, recursively_write_psymbols)
3651         (class debug_names, class debug_names, write_psymtabs_to_index):
3652         Update.
3653
3654 2019-01-10  Tom Tromey  <tom@tromey.com>
3655
3656         * symtab.h (SYMBOL_SET_NAMES): Update.
3657         (symbol_set_names): Update.
3658         (MSYMBOL_SET_NAMES): Update.
3659         * symtab.c (symbol_set_names): Change argument to be an
3660         objfile_per_bfd_storage.
3661         * psymtab.c (add_psymbol_to_bcache): Update.
3662         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3663
3664 2019-01-10  Tom Tromey  <tom@tromey.com>
3665
3666         * symtab.c (create_demangled_names_hash): Change argument to be an
3667         objfile_per_bfd_storage.
3668         (symbol_set_names): Update.
3669
3670 2019-01-10  Tom Tromey  <tom@tromey.com>
3671
3672         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3673         init_psymbol_list.
3674         * psymtab.c (init_psymbol_list): Do nothing if already called.
3675         * psympriv.h (init_psymbol_list): Add comment.
3676         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3677         init_psymbol_list.
3678         * dbxread.c (dbx_symfile_read): Unconditionally call
3679         init_psymbol_list.
3680
3681 2019-01-10  Tom Tromey  <tom@tromey.com>
3682
3683         * xcoffread.c (scan_xcoff_symtab): Update.
3684         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3685         "where".
3686         * mdebugread.c (parse_partial_symbols)
3687         (handle_psymbol_enumerators): Update.
3688         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3689         * dbxread.c (read_dbx_symtab): Update.
3690         * psympriv.h (psymbol_placement): New enum.
3691         (add_psymbol_to_list): Update.
3692
3693 2019-01-10  Tom Tromey  <tom@tromey.com>
3694
3695         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3696         static_psymbols parameters.
3697         (scan_xcoff_symtab): Update.
3698         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3699         static_psymbols parameters.
3700         * psympriv.h (start_psymtab_common): Update.
3701         * mdebugread.c (parse_partial_symbols): Update.
3702         * dwarf2read.c (create_partial_symtab): Update.
3703         * dbxread.c (read_dbx_symtab): Update.
3704         (start_psymtab): Remove global_psymbols and static_psymbols
3705         parameters.
3706
3707 2019-01-10  Tom Tromey  <tom@tromey.com>
3708
3709         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3710         * psymtab.c (allocate_psymtab): Add comment.
3711         * psympriv.h (allocate_psymtab): Add comment.
3712         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3713         initializations.
3714         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3715
3716 2019-01-10  Tom Tromey  <tom@tromey.com>
3717
3718         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3719         Don't declare.
3720         * mipsread.c: Include mdebugread.h.
3721         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3722         Declare.
3723         * elfread.c: Include mdebugread.h.
3724
3725 2019-01-09  Tom Tromey  <tom@tromey.com>
3726
3727         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3728         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3729         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3730         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3731         (psym_lookup_symbol, psym_find_last_source_symtab)
3732         (psym_forget_cached_source_info, psym_print_stats)
3733         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3734         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3735         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3736         (psym_find_compunit_symtab_by_address)
3737         (maintenance_print_psymbols, maintenance_info_psymtabs)
3738         (maintenance_check_psymtabs): Use ranged for.
3739         * psymtab.h (class objfile_psymtabs): New.
3740         (require_partial_symbols): Return objfile_psymtabs.
3741         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3742
3743 2019-01-09  Tom Tromey  <tom@tromey.com>
3744
3745         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3746         (find_pc_mapped_section, list_overlays_command)
3747         (map_overlay_command, unmap_overlay_command)
3748         (simple_overlay_update): Use all_objfiles.
3749         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3750         * printcmd.c (info_symbol_command): Use all_objfiles.
3751         * objfiles.h (ALL_OBJSECTIONS): Remove.
3752         * maint.c (maintenance_translate_address): Use all_objfiles.
3753         * gcore.c (gcore_create_callback): Use all_objfiles.
3754         (objfile_find_memory_regions): Likewise.
3755
3756 2019-01-09  Tom Tromey  <tom@tromey.com>
3757
3758         * symtab.c (find_line_symtab, info_sources_command)
3759         (make_source_files_completion_list): Use objfile_compunits.
3760         * source.c (select_source_symtab): Use objfile_compunits.
3761         * objfiles.h (struct objfile): Update comment.
3762         (ALL_OBJFILES): Remove.
3763         (ALL_FILETABS): Remove.
3764         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3765         objfile_compunits.
3766
3767 2019-01-09  Tom Tromey  <tom@tromey.com>
3768
3769         * symmisc.c (print_objfile_statistics, dump_objfile)
3770         (maintenance_print_symbols): Use compunit_filetabs.
3771         * source.c (forget_cached_source_info_for_objfile): Use
3772         compunit_filetabs.
3773         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3774         (ALL_FILETABS): Use compunit_filetabs.
3775         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3776         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3777
3778 2019-01-09  Tom Tromey  <tom@tromey.com>
3779
3780         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3781         (compunit_filetabs): New.
3782         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3783         compunit_filetabs.
3784         (info_sources_command, make_source_files_completion_list): Remove
3785         declaration.
3786         * symmisc.c (print_objfile_statistics, dump_objfile)
3787         (maintenance_print_symbols): Remove declaration.
3788         (maintenance_info_symtabs): Use compunit_filetabs.
3789         (maintenance_info_line_tables): Likewise.
3790         * source.c (select_source_symtab): Change local variable name.
3791         (forget_cached_source_info_for_objfile): Remove declaration.
3792         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3793         * objfiles.c (objfile_relocate1): Remove declaration.
3794         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3795         declaration.
3796         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3797         * coffread.c (coff_symtab_read): Remove declaration.
3798         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3799         compunit_filetabs.
3800
3801 2019-01-09  Tom Tromey  <tom@tromey.com>
3802
3803         * symtab.c (lookup_objfile_from_block)
3804         (find_pc_sect_compunit_symtab, search_symbols)
3805         (default_collect_symbol_completion_matches_break_on): Use
3806         objfile_compunits.
3807         * objfiles.h (ALL_COMPUNITS): Remove.
3808         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3809         * cp-support.c (add_symbol_overload_list_qualified): Use
3810         objfile_compunits.
3811         * ada-lang.c (ada_collect_symbol_completion_matches)
3812         (ada_add_global_exceptions): Use objfile_compunits.
3813
3814 2019-01-09  Tom Tromey  <tom@tromey.com>
3815
3816         * source.c (select_source_symtab)
3817         (forget_cached_source_info_for_objfile): Remove declaration.
3818         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3819         declaration.
3820         * maint.c (count_symtabs_and_blocks): Remove declaration.
3821         * cp-support.c (add_symbol_overload_list_qualified): Remove
3822         declaration.
3823         * coffread.c (coff_symtab_read): Remove declaration.
3824         * symtab.c (lookup_symbol_in_objfile_symtabs)
3825         (basic_lookup_transparent_type_1): Use objfile_compunits.
3826         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3827         (info_sources_command, search_symbols)
3828         (default_collect_symbol_completion_matches_break_on)
3829         (make_source_files_completion_list): Remove declaration.
3830         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3831         (ada_collect_symbol_completion_matches)
3832         (ada_add_global_exceptions): Remove declaration.
3833         * linespec.c (iterate_over_all_matching_symtabs): Use
3834         objfile_compunits.
3835         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3836         (class objfile_compunits): New.
3837         (ALL_COMPUNITS): Use objfile_compunits.
3838         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3839         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3840         objfile_compunits.
3841         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3842
3843 2019-01-09  Tom Tromey  <tom@tromey.com>
3844
3845         * symtab.c (search_symbols)
3846         (default_collect_symbol_completion_matches_break_on): Use
3847         objfile_msymbols.
3848         * ada-lang.c (ada_lookup_simple_minsym)
3849         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3850         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3851         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3852         objfile_msymbols.
3853         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3854         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3855         * objc-lang.c (find_methods): Use objfile_msymbols.
3856         (info_selectors_command, info_classes_command): Likewise.
3857         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3858         * objfiles.h (class objfile_msymbols): New.
3859         (ALL_OBJFILE_MSYMBOLS): Remove.
3860         (ALL_MSYMBOLS): Remove.
3861
3862 2019-01-09  Tom Tromey  <tom@tromey.com>
3863
3864         * common/next-iterator.h (next_adapter): Add Iterator template
3865         parameter.
3866         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3867         (class all_objfiles_safe): New.
3868         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3869         * objfiles.c (put_objfile_before): Update comment.
3870         (add_separate_debug_objfile): Likewise.
3871         (free_all_objfiles): Use all_objfiles_safe.
3872         (objfile_purge_solibs): Likewise.
3873
3874 2019-01-09  Tom Tromey  <tom@tromey.com>
3875
3876         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3877         (expand_symtab_containing_pc, lookup_static_symbol)
3878         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3879         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3880         all_objfiles.
3881         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3882         * breakpoint.c (create_overlay_event_breakpoint)
3883         (create_longjmp_master_breakpoint)
3884         (create_std_terminate_master_breakpoint)
3885         (create_exception_master_breakpoint): Use all_objfiles.
3886         * linux-thread-db.c (try_thread_db_load_from_pdir)
3887         (has_libpthread): Use all_objfiles.
3888         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3889         * linespec.c (iterate_over_all_matching_symtabs)
3890         (search_minsyms_for_name): Use all_objfiles.
3891         * maint.c (maintenance_info_sections): Use all_objfiles.
3892         * main.c (captured_main_1): Use all_objfiles.
3893         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3894         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3895         * guile/scm-pretty-print.c
3896         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3897         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3898         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3899         (maintenance_print_msymbols): Use all_objfiles.
3900         * source.c (select_source_symtab): Use all_objfiles.
3901         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3902         * symfile.c (remove_symbol_file_command)
3903         (expand_symtabs_matching, map_symbol_filenames): Use
3904         all_objfiles.
3905         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3906         all_objfiles.
3907         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3908         * objc-lang.c (find_methods): Use all_objfiles.
3909         * objfiles.c (have_partial_symbols, have_full_symbols)
3910         (have_minimal_symbols, qsort_cmp)
3911         (default_iterate_over_objfiles_in_search_order): Use
3912         all_objfiles.
3913         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3914         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3915         (maintenance_check_psymtabs): Use all_objfiles.
3916         (ALL_PSYMTABS): Remove.
3917         * compile/compile-object-run.c (do_module_cleanup): Use
3918         all_objfiles.
3919         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3920         * cp-support.c (add_symbol_overload_list_qualified): Use
3921         all_objfiles.
3922         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3923         Use all_objfiles.
3924         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3925         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3926         all_objfiles.
3927         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3928         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3929         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3930         Uses all_objfiles.
3931         * solib.c (solib_read_symbols): Use all_objfiles
3932
3933 2019-01-09  Tom Tromey  <tom@tromey.com>
3934
3935         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3936         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3937         all_objfiles.
3938         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3939         * symmisc.c (print_symbol_bcache_statistics)
3940         (print_objfile_statistics, maintenance_print_objfiles)
3941         (maintenance_info_symtabs, maintenance_check_symtabs)
3942         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3943         all_objfiles.
3944         * source.c (forget_cached_source_info): Use all_objfiles.
3945         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3946         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3947         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3948         * objfiles.c (update_section_map): Use all_objfiles.
3949         (shared_objfile_contains_address_p): Likewise.
3950         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3951         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3952
3953 2019-01-09  Tom Tromey  <tom@tromey.com>
3954
3955         * common/next-iterator.h: New file.
3956         * objfiles.h (class all_objfiles): New.
3957         (struct objfile_iterator): New.
3958
3959 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3960
3961         * NEWS: Move the description of the changed "frame", "select-frame",
3962          and "info frame" commands to the Changed commands section.
3963
3964 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3965
3966         * gdbtypes.c (check_stub_method_group): Remove handling of old
3967         mangling schemes.
3968         * linespec.c (find_methods): Likewise.
3969         * stabsread.c (read_member_functions): Likewise.
3970         * valops.c (search_struct_method): Likewise.
3971         (value_struct_elt_for_reference): Likewise.
3972         * NEWS: Mention this change.
3973
3974 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3975
3976         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3977         print_source_lines.
3978         * source.c (print_source_lines_base): Update line number check.
3979         (print_source_lines): New function.
3980         (source_lines_range::source_lines_range): New function.
3981         * source.h (class source_lines_range): New class.
3982         (print_source_lines): New declaration.
3983
3984 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3985
3986         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3987
3988 2019-01-08  Tom Tromey  <tom@tromey.com>
3989             Simon Marchi  <simon.marchi@ericsson.com>
3990
3991         PR gdb/24060
3992         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3993         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3994         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3995         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3996         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3997         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3998
3999 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4000
4001         * source.c (select_source_symtab): Move header comment to
4002         declaration in source.h.
4003         (forget_cached_source_info_for_objfile): Likewise.
4004         (forget_cached_source_info): Likewise.
4005         (identify_source_line): Likewise.
4006         * source.h (identify_source_line): Move declaration from symtab.h
4007         and add comment from source.c
4008         (print_source_lines): Likewise.
4009         (forget_cached_source_info_for_objfile): Likewise.
4010         (forget_cached_source_info): Likewise.
4011         (select_source_symtab): Likewise.
4012         (enum print_source_lines_flag): Move definition from symtab.h.
4013         * symtab.h (identify_source_line): Move declaration to source.h.
4014         (print_source_lines): Likewise.
4015         (forget_cached_source_info_for_objfile): Likewise.
4016         (forget_cached_source_info): Likewise.
4017         (select_source_symtab): Likewise.
4018         (enum print_source_lines_flag): Move definition to source.h.
4019         * tui/tui-hooks.c: Add 'source.h' include.
4020
4021 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4022
4023         * source.c (print_source_lines_base): Handle requests to print
4024         reverse line number sequences, and guard against empty lines
4025         string.
4026
4027 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4028
4029         * source.c (print_source_lines_base): Fix skip of '\r' if next
4030         character is '\n'.
4031
4032 2019-01-06  Tom Tromey  <tom@tromey.com>
4033
4034         * c-exp.y (struct c_parse_state) <macro_original_text,
4035         expansion_obstack>: New member.
4036         (macro_original_text, expansion_obstack): Remove globals.
4037         (scan_macro_expansion, scanning_macro_expansion)
4038         (finished_macro_expansion): Update.
4039         (scan_macro_cleanup): Remove.
4040         (yylex, c_parse): Update.
4041
4042 2019-01-06  Tom Tromey  <tom@tromey.com>
4043
4044         * c-exp.y (struct c_parse_state) <strings>: New member.
4045         (operator_stoken): Update.
4046
4047 2019-01-06  Tom Tromey  <tom@tromey.com>
4048
4049         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4050         (union type_stack_elt) <typelist_val>: Now a pointer to
4051         std::vector.
4052         (type_stack_cleanup): Don't declare.
4053         (push_typelist): Update.
4054         * parse.c (pop_typelist): Return a std::vector.
4055         (push_typelist): Take a std::vector.
4056         (follow_types): Update.  Do not free args.
4057         (type_stack_cleanup): Remove.
4058         * c-exp.y (struct c_parse_state): New.
4059         (cpstate): New global.
4060         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4061         (nonempty_typelist): Update.
4062         (func_mod): Create a new vector.
4063         (c_parse): Create a c_parse_state.
4064         (check_parameter_typelist): Do not delete params.
4065         (function_method): Update.  Do not delete type_list.
4066
4067 2019-01-06  Tom Tromey  <tom@tromey.com>
4068
4069         PR gdb/28155:
4070         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4071         check_typedef.
4072         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4073         (print_return_value): Likewise.
4074
4075 2019-01-05  Tom Tromey  <tom@tromey.com>
4076
4077         * contrib/cleanup_check.py: Remove.
4078         * contrib/gcc-with-excheck: Remove.
4079         * contrib/exsummary.py: Remove.
4080         * contrib/excheck.py: Remove.
4081
4082 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4083
4084         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4085         NULL. Initialize tpprev to NULL instead of assigning it
4086         to NULL on the next statement.
4087         * windows-nat.c (windows_delete_thread): Remove check for
4088         main_thread_id before printing thread exit notifications.
4089         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4090         Remove thread ID check against main_thread_id.
4091         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4092         windows_delete_thread.
4093         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4094
4095 2019-01-04  Tom Tromey  <tom@tromey.com>
4096
4097         * compile/compile.c (_initialize_compile): Use upper case for
4098         metasyntactic variables.
4099         * symmisc.c (_initialize_symmisc): Use upper case for
4100         metasyntactic variables.
4101         * psymtab.c (_initialize_psymtab): Use upper case for
4102         metasyntactic variables.
4103         * demangle.c (demangle_command): Use upper case for metasyntactic
4104         variables.
4105         (_initialize_demangler): Likewise.
4106         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4107         variables.
4108
4109 2019-01-03  Tom Tromey  <tom@tromey.com>
4110
4111         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4112
4113 2019-01-03  Tom Tromey  <tom@tromey.com>
4114
4115         * python/py-symtab.c (salpy_str): Update.
4116         (struct salpy_sal_object) <symtab>: Now a PyObject.
4117         (salpy_dealloc): Update.
4118         (del_objfile_sal): Use gdbpy_ref.
4119
4120 2019-01-03  Tom Tromey  <tom@tromey.com>
4121
4122         * python/py-type.c (convert_field): Use new_reference.  Return
4123         gdbpy_ref.
4124         (make_fielditem): Return gdbpy_ref.
4125         (typy_fields): Update.
4126         (typy_getitem): Update.
4127         (field_name): Return gdbpy_ref.  Use new_reference.
4128         (typy_iterator_iternext): Update.
4129
4130 2019-01-03  Tom Tromey  <tom@tromey.com>
4131
4132         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4133
4134 2019-01-03  Tom Tromey  <tom@tromey.com>
4135
4136         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4137         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4138         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4139         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4140         (pspy_set_type_printers): Likewise.
4141         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4142         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4143         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4144         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4145         (objfpy_set_type_printers): Likewise.
4146
4147 2019-01-03  Tom Tromey  <tom@tromey.com>
4148
4149         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4150         (gdbpy_print_stack): Use gdbpy_err_fetch.
4151         * python/python-internal.h (class gdbpy_err_fetch): New class.
4152         (class gdbpy_enter) <m_error_type, m_error_value,
4153         m_error_traceback>: Remove.
4154         <m_error>: New member.
4155         (gdbpy_exception_to_string): Don't declare.
4156         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4157         * python/py-value.c (convert_value_from_python): Use
4158         gdbpy_err_fetch.
4159         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4160         gdbpy_exception_to_string.
4161         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4162         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4163         gdbpy_err_fetch.
4164
4165 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4166
4167         * linux-nat.c (delete_lwp_cleanup): Delete.
4168         (struct lwp_deleter): New struct.
4169         (lwp_info_up): New typedef.
4170         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4171         lwp_info_up.
4172
4173 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4174
4175         * linux-fork.c (class scoped_switch_fork_info): New class.
4176         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4177
4178 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4179
4180         * valops.c (find_overload_match): Remove use of null_cleanup, and
4181         calls to do_cleanups.
4182
4183 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4184
4185         * compile/compile-cplus-types.c
4186         (compile_cplus_instance::decl_name): Handle changes to
4187         cp_func_name.
4188         * cp-support.c (cp_func_name): Update header comment, update
4189         return type.
4190         * cp-support.h (cp_func_name): Update return type in declaration.
4191         * valops.c (find_overload_match): Move temp_func local to top
4192         level of function and change its type.  Use temp_func to hold and
4193         delete temporary string obtained from cp_func_name.
4194
4195 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4196
4197         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4198         gdb::char_vector, remove cleanup, and update uses of `msg`.
4199
4200 2019-01-03  Jim Wilson  <jimw@sifive.com>
4201
4202         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4203
4204 2019-01-02  Tom Tromey  <tom@tromey.com>
4205
4206         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4207         (tdesc_parse_xml): Remove cleanups.
4208         * target-descriptions.h (make_cleanup_free_target_description):
4209         Don't declare.
4210         (target_desc_deleter): New struct.
4211         (target_desc_up): New typedef.
4212         * target-descriptions.c (target_desc_deleter::operator()): Rename
4213         from free_target_description.
4214         (make_cleanup_free_target_description): Remove.
4215
4216 2019-01-02  Tom Tromey  <tom@tromey.com>
4217
4218         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4219         constructor, destructor.
4220         (linespec_parser): Remove typedef.
4221         (~linespec_parser): Rename from linespec_parser_delete.
4222         (linespec_lex_to_end, linespec_complete_label)
4223         (linespec_complete): Update.
4224         (decode_line_full): Remove cleanups.
4225         (decode_line_1): Update.
4226
4227 2019-01-02  Tom Tromey  <tom@tromey.com>
4228
4229         * python/python-internal.h (inferior_to_inferior_object): Change
4230         return type.
4231         * python/py-exitedevent.c (create_exited_event_object): Update.
4232         * python/py-inferior.c (inferior_to_inferior_object): Return
4233         gdbpy_ref.
4234         (python_new_inferior, python_inferior_deleted)
4235         (thread_to_thread_object, delete_thread_object)
4236         (build_inferior_list, gdbpy_selected_inferior): Update.
4237         * python/py-infthread.c (create_thread_object): Update.  Also fail
4238         if inferior_to_inferior_object fails.
4239
4240 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4241
4242         * inferior.h (class inferior) <displaced_step_state>: New field.
4243         * infrun.h (struct displaced_step_state): Move here from
4244         infrun.c.  Initialize fields, add constructor.
4245         <inf>: Remove field.
4246         <reset>: New method.
4247         * infrun.c (struct displaced_step_inferior_state): Move to
4248         infrun.h.
4249         (displaced_step_inferior_states): Remove.
4250         (get_displaced_stepping_state): Adust.
4251         (displaced_step_in_progress_any_inferior): Adjust.
4252         (displaced_step_in_progress_thread): Adjust.
4253         (displaced_step_in_progress): Adjust.
4254         (add_displaced_stepping_state): Remove.
4255         (get_displaced_step_closure_by_addr): Adjust.
4256         (remove_displaced_stepping_state): Remove.
4257         (infrun_inferior_exit): Call displaced_step_state.reset.
4258         (use_displaced_stepping): Don't check for NULL.
4259         (displaced_step_prepare_throw): Call
4260         get_displaced_stepping_state.
4261         (displaced_step_fixup): Don't check for NULL.
4262         (prepare_for_detach): Don't check for NULL.
4263
4264 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4265
4266         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4267          in case of call that did not complete.
4268
4269 2019-01-02  Andrey Utkin  <autkin@undo.io>
4270
4271         * symfile.c (find_separate_debug_file): Fix search of debug files for
4272         remote debuggee.
4273
4274 2019-01-02  Tom Tromey  <tom@tromey.com>
4275
4276         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4277         indentation.
4278         * python/py-frame.c (frapy_older): Remove cast.
4279         (frapy_newer): Likewise.
4280         * python/py-breakpoint.c (local_setattro): Remove cast.
4281         * python/py-arch.c (archpy_name): Remove local variable.
4282         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4283
4284 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4285
4286         * unittests/basic_string_view/element_access/char/empty.cc:
4287         Fix year range in copyright header.
4288
4289 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4290
4291         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4292         Delete.
4293         <operator==>: Update with for removed field.
4294         <hash>: Likewise.
4295         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4296         <isa_features>: ...this.
4297         <abi_features>: New field.
4298         (riscv_isa_flen): Update comment.
4299         (riscv_abi_xlen): New declaration.
4300         (riscv_abi_flen): New declaration.
4301         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4302         isa_features.
4303         (riscv_abi_xlen): New function.
4304         (riscv_isa_flen): Update to get answer from isa_features.
4305         (riscv_abi_flen): New function.
4306         (riscv_has_fp_abi): Update to get answer from abi_features.
4307         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4308         xlen and flen.
4309         (riscv_call_info) <xlen, flen>: Update comment.
4310         (riscv_call_arg_struct): Remove invalid assertions
4311         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4312         is removed.
4313         (riscv_gdbarch_init): Gather isa features and abi features
4314         separately, ensure both match on the gdbarch when reusing an old
4315         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4316         a target with 64-bit float hardware.
4317
4318 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4319
4320         * source.c (search_command_helper): Stop reverse search
4321         when line 1 has been searched.
4322
4323 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4324
4325         * record-full.c (record_full_base_target::close): Rewrite
4326         record_full_core_buf_list free logic.
4327
4328 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4329
4330         * break-catch-syscall.c (print_one_catch_syscall): xfree
4331         the last text.
4332
4333 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4334
4335         * top.c (print_gdb_version): Update Copyright year in version
4336         message.
4337
4338 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4339
4340         Update copyright year range in all GDB files.
4341
4342 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4343
4344         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4345
4346 For older changes see ChangeLog-2018.
4347 \f
4348 Local Variables:
4349 mode: change-log
4350 left-margin: 8
4351 fill-column: 74
4352 version-control: never
4353 coding: utf-8
4354 End:
4355