gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
   4         check.
   5
   6 2019-06-25  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
   9         type to void.
  10         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
  11         type to void.
  12         * tui/tui-source.c (tui_set_source_content): Update.
  13         * tui/tui-disasm.c (tui_set_disassem_content): Update.
  14
  15 2019-06-25  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-win.c (window_name_completer, tui_set_focus)
  18         (tui_all_windows_info): Use name method.
  19         * tui/tui-data.h (struct tui_gen_win_info)
  20         (struct tui_source_window, struct tui_disasm_window)
  21         (struct tui_data_window, struct tui_cmd_window) <name>: New
  22         method.
  23         (tui_win_name): Don't declare.
  24         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
  25         (tui_win_name): Remove.
  26
  27 2019-06-25  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-winsource.h (tui_update_source_window)
  30         (tui_update_source_window_as_is): Change parameter type.
  31         * tui/tui-winsource.c (tui_update_source_window): Change win_info
  32         to be a tui_source_window_base.
  33         (tui_update_source_window_as_is): Likewise.
  34         * tui/tui-win.c (make_visible_with_new_height): Update.
  35
  36 2019-06-25  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-winsource.c (tui_erase_source_content)
  39         (tui_show_source_content, tui_show_exec_info_content)
  40         (tui_erase_exec_info_content): Use refresh_window method.
  41         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
  42         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
  43         from tui_refresh_win.
  44         (tui_data_window::refresh_window): New method.
  45         (tui_win_info::refresh, tui_source_window_base::refresh)
  46         (tui_refresh_all): Use refresh_window method.
  47         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
  48         method.
  49         * tui/tui-regs.c (tui_display_register): Call refresh_window
  50         method.
  51         * tui/tui-layout.c (show_source_disasm_command)
  52         (show_source_or_disasm_and_command): Call refresh_window method.
  53         * tui/tui-data.h (struct tui_gen_win_info)
  54         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
  55         New method.
  56
  57 2019-06-25  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui.c (tui_rl_other_window, tui_enable)
  60         (tui_is_window_visible, tui_get_command_dimension): Update.
  61         * tui/tui-winsource.c (tui_update_source_window_as_is)
  62         (tui_clear_source_content, tui_erase_source_content)
  63         (tui_show_source_line, tui_source_window_base::refill)
  64         (tui_source_window_base::do_scroll_horizontal)
  65         (tui_source_window_base::set_is_exec_point_at)
  66         (tui_update_breakpoint_info, tui_set_exec_info_content)
  67         (tui_alloc_source_buffer, tui_line_is_displayed)
  68         (tui_addr_is_displayed): Update.
  69         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  70         (tui_check_and_display_highlight_if_needed)
  71         (tui_win_info::make_visible, tui_win_info::refresh)
  72         (tui_refresh_all): Update.
  73         * tui/tui-windata.c (tui_first_data_item_displayed)
  74         (tui_delete_data_content_windows, tui_erase_data_content)
  75         (tui_display_all_data, tui_data_window::refresh_all)
  76         (tui_check_data_values): Update.
  77         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
  78         (tui_set_win_focus_to, tui_win_info::forward_scroll)
  79         (tui_win_info::backward_scroll, tui_refresh_all_win)
  80         (tui_resize_all, tui_set_focus, tui_all_windows_info)
  81         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
  82         (tui_source_window_base::set_new_height)
  83         (tui_data_window::set_new_height)
  84         (make_invisible_and_set_new_height)
  85         (make_visible_with_new_height, new_height_ok)
  86         (parse_scrolling_args): Update.
  87         * tui/tui-stack.c (tui_show_frame_info): Update.
  88         * tui/tui-source.c (tui_set_source_content)
  89         (tui_set_source_content_nil, tui_source_is_displayed)
  90         (tui_source_window::do_scroll_vertical): Update.
  91         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
  92         (tui_display_registers_from, tui_display_reg_element_at_line)
  93         (tui_check_register_values, tui_reg_command): Update.
  94         * tui/tui-layout.c (tui_default_win_height)
  95         (show_source_disasm_command, show_data, init_and_make_win)
  96         (show_source_or_disasm_and_command): Update.
  97         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
  98         (tui_redisplay_readline, tui_mld_flush)
  99         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 100         (tui_getc): Update.
 101         * tui/tui-disasm.c (tui_set_disassem_content)
 102         (tui_disasm_window::do_scroll_vertical): Update.
 103         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 104         Now virtual.
 105         (struct tui_win_info): Derive from tui_gen_win_info.
 106         <~tui_win_info>: Mark as override.
 107         <generic>: Remove member.
 108         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 109         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 110         (~tui_data_window, ~tui_win_info)
 111         (tui_free_all_source_wins_content): Update.
 112         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 113
 114 2019-06-25  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui-layout.c (init_and_make_win): Use new.
 117         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 118         destructor, initializers.
 119         (tui_alloc_generic_win_info): Don't declare.
 120         * tui/tui-data.c (_locator): Add argument to constructor.
 121         (source_win, disasm_win): New globals.
 122         (exec_info): Remove.
 123         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 124         Update.
 125         (tui_alloc_generic_win_info): Remove.
 126         (init_content_element): Use new.
 127         (tui_win_info::tui_win_info): Update.
 128         (free_content_elements) <case DATA_WIN>: Use delete.
 129
 130 2019-06-25  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 133         * tui/tui-windata.c (tui_first_data_item_displayed)
 134         (tui_delete_data_content_windows): Update.
 135         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 136         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 137         (tui_display_registers_from, tui_check_register_values): Update.
 138         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 139         pointer.
 140         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 141         window.
 142         (tui_free_data_content): Update.
 143         (free_content_elements) <case DATA_WIN>: Free the window.
 144
 145 2019-06-25  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 148         Update.
 149         * tui/tui-layout.c (make_command_window)
 150         (show_source_disasm_command, show_data, init_and_make_win)
 151         (show_source_or_disasm_and_command): Update.
 152         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 153         method.
 154         <can_highight, is_highlighted>: Now bool.
 155         (tui_set_win_highlight): Don't declare.
 156         * tui/tui-data.c (tui_set_win_highlight): Remove.
 157
 158 2019-06-25  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-wingeneral.c (make_visible): Remove check of window
 161         type.
 162
 163 2019-06-25  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-win.c (tui_win_info::max_height)
 166         (tui_cmd_window::max_height): New methods.
 167         (new_height_ok): Call max_height.
 168         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 169         <max_height>: New method.
 170
 171 2019-06-25  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-win.c (tui_source_window_base::set_new_height)
 174         (tui_data_window::set_new_height): New methods.
 175         (make_invisible_and_set_new_height): Call set_new_height method.
 176         * tui/tui-data.h (struct tui_win_info)
 177         (struct tui_source_window_base, struct tui_data_window)
 178         <set_new_height>: New method.
 179
 180 2019-06-25  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 183         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 184         tui_refresh_data_win.
 185         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 186         method.
 187         (tui_refresh_all_win): Call the refresh_all method.
 188         (tui_set_focus): Likewise.
 189         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 190         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 191         Likewise.
 192
 193 2019-06-25  Tom Tromey  <tom@tromey.com>
 194
 195         * tui/tui-winsource.h (tui_refill_source_window)
 196         (tui_set_is_exec_point_at): Don't declare.
 197         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 198         (tui_source_window_base::refill): Rename from
 199         tui_refill_source_window.
 200         (tui_source_window_base::do_scroll_horizontal): Update.
 201         (tui_source_window_base::set_is_exec_point_at): Rename from
 202         tui_set_is_exec_point_at.
 203         (tui_update_all_breakpoint_info): Update.
 204         * tui/tui-stack.c (tui_show_frame_info): Update.
 205         * tui/tui-layout.c (show_data): Add cast.
 206         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 207         * tui/tui-data.h (struct tui_source_window_base) <refill,
 208         set_is_exec_point_at>: New methods.
 209         (tui_source_windows, tui_add_to_source_windows): Update types.
 210         (tui_add_to_source_windows): Remove redundant declaration.
 211         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 212         (tui_source_windows): Change return type.
 213         (tui_clear_source_windows_detail): Update.
 214         (tui_add_to_source_windows): Change type of parameter.
 215         (tui_free_all_source_wins_content): Update.
 216
 217 2019-06-25  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-wingeneral.c (tui_win_info::refresh)
 220         (tui_source_window_base::refresh): New methods.
 221         (tui_refresh_all): Call the refresh method.
 222         * tui/tui-data.h (struct tui_win_info)
 223         (struct tui_source_window_base) <refresh>: New method.
 224
 225 2019-06-25  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui.h (tui_is_window_visible): Return bool.
 228         * tui/tui.c (tui_is_window_visible): Return bool.
 229         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 230         (tui_make_visible, tui_make_invisible)
 231         (tui_win_info::make_visible)
 232         (tui_source_window_base::make_visible, make_all_visible)
 233         (tui_make_all_visible, tui_make_all_invisible): Update.
 234         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 235         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 236         bool.
 237         (struct tui_win_info, struct tui_source_window_base)
 238         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 239         * tui/tui-data.c (tui_init_generic_part): Update.
 240
 241 2019-06-25  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 244         (tui_source_window_base::make_visible): New methods.
 245         (make_all_visible): Make method call.
 246         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 247         (struct tui_source_window_base, struct tui_cmd_window): Override
 248         make_visible.
 249         (tui_win_is_source_type): Don't declare.
 250         * tui/tui-data.c (tui_win_is_source_type): Remove.
 251
 252 2019-06-25  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 255         NULL check.
 256
 257 2019-06-25  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 260         Inline constructor.  Add initializers for members.
 261         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 262         constructors; now inline in class.
 263
 264 2019-06-25  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-regs.c (tui_show_registers): Update.
 267         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 268         bool.
 269         * tui/tui-data.c (tui_data_window::clear_detail)
 270         (tui_data_window): Update.
 271
 272 2019-06-25  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-windata.c (tui_display_all_data)
 275         (tui_display_data_from_line, tui_display_data_from)
 276         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 277         Update.
 278         * tui/tui-regs.c (tui_last_regs_line_no)
 279         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 280         (tui_show_registers, tui_show_register_group)
 281         (tui_display_registers_from, tui_display_reg_element_at_line)
 282         (tui_display_registers_from_line, tui_check_register_values)
 283         (tui_reg_next, tui_reg_prev): Update.
 284         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 285         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 286         tui_data_window.
 287         (struct tui_win_info) <detail>: Remove.  Add new fields from
 288         tui_data_info.
 289         (TUI_DATA_WIN): Add cast.
 290         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 291         (~tui_data_window): Simplify.
 292
 293 2019-06-25  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-layout.c (show_source_disasm_command)
 296         (show_source_or_disasm_and_command): Update.
 297         * tui/tui-io.c (update_cmdwin_start_line)
 298         (tui_redisplay_readline): Update.
 299         * tui/tui-data.h (struct tui_command_info): Remove.
 300         (struct tui_win_info) <detail>: Remove command_info member.
 301         (struct tui_data_window) <start_line>: New member, from
 302         tui_command_info.
 303         (TUI_CMD_WIN): Add casts.
 304
 305 2019-06-25  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-winsource.c (tui_update_source_window)
 308         (tui_refill_source_window)
 309         (tui_source_window_base::do_scroll_horizontal)
 310         (tui_update_breakpoint_info, tui_set_exec_info_content)
 311         (tui_show_exec_info_content, tui_erase_exec_info_content)
 312         (tui_clear_exec_info_content): Update.
 313         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 314         Update.
 315         * tui/tui-win.c (make_invisible_and_set_new_height)
 316         (make_visible_with_new_height): Update.
 317         * tui/tui-source.c (tui_set_source_content)
 318         (tui_show_symtab_source): Update.
 319         * tui/tui-layout.c (extract_display_start_addr)
 320         (show_source_disasm_command, show_data)
 321         (make_source_or_disasm_window)
 322         (show_source_or_disasm_and_command): Update.
 323         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 324         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 325         "gdbarch".
 326         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 327         to tui_source_window_base.
 328         (struct tui_win_info) <detail>: Remove source_info member.
 329         (struct tui_source_window_base) <has_locator>: Inline.
 330         Move contents from tui_source_info; rename has_locator member to
 331         m_has_locator.
 332         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 333         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 334         header file.
 335         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 336         Simplify.
 337         (tui_free_all_source_wins_content): Cast to
 338         tui_source_window_base.
 339
 340 2019-06-25  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-win.c (make_invisible_and_set_new_height)
 343         (make_visible_with_new_height): Call has_locator method.
 344         * tui/tui-layout.c (show_source_disasm_command, show_data)
 345         (show_source_or_disasm_and_command): Update for bool change.
 346         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 347         (tui_win_info) <has_locator>: New method.
 348         (struct tui_source_window_base) <has_locator>: New method.
 349         (tui_win_has_locator): Don't declare.
 350         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 351         from tui_win_has_locator.
 352         (tui_source_window_base): Use false, not FALSE.
 353
 354 2019-06-25  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 357         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 358         clear_detail method directly.
 359         (tui_clear_win_detail): Remove.
 360
 361 2019-06-25  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 364         "this", not TUI_DISASM_WIN.
 365
 366 2019-06-25  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 369         declare.
 370         * tui/tui-winsource.c
 371         (tui_source_window_base::do_scroll_horizontal): Rename from
 372         tui_horizontal_source_scroll.
 373         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 374         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 375         from tui_vertical_data_scroll.
 376         * tui/tui-win.h (tui_scroll): Don't declare.
 377         * tui/tui-win.c (tui_win_info::forward_scroll)
 378         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 379         (tui_win_info::right_scroll): Rename and update.
 380         (tui_scroll_forward_command, tui_scroll_backward_command)
 381         (tui_scroll_left_command, tui_scroll_right_command): Update.
 382         (tui_scroll): Remove.
 383         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 384         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 385         from tui_vertical_source_scroll.
 386         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 387         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 388         from tui_vertical_disassem_scroll.
 389         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 390         do_scroll_horizontal>: New methods.
 391         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 392         Likewise.
 393         (struct tui_source_window_base): Add do_scroll_horizontal.
 394         (struct tui_source_window, struct tui_disasm_window): Add
 395         do_scroll_vertical.
 396         (struct tui_data_window, struct tui_cmd_window): Add
 397         do_scroll_horizontal and do_scroll_vertical.
 398         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 399
 400 2019-06-25  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-data.h (struct tui_source_window_base): New struct.
 403         (struct tui_source_window): Derive from tui_source_window_base.
 404         (struct tui_disasm_window): New struct.
 405         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 406         from tui_source_window::clear_detail.
 407         (tui_source_window_base): Rename from tui_source_window.
 408         (~tui_source_window_base): Rename from ~tui_source_window.
 409         (tui_alloc_win_info): Create a tui_disasm_window.
 410
 411 2019-06-25  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-data.h (struct tui_source_window)
 414         (struct tui_data_window): Declare destructors.
 415         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 416         destructors.
 417         (tui_win_info): Simplify.
 418
 419 2019-06-25  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-winsource.c (tui_display_main)
 422         (tui_update_source_windows_with_addr)
 423         (tui_update_all_breakpoint_info): Update.
 424         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 425         (new_height_ok, parse_scrolling_args): Update.
 426         * tui/tui-stack.c (tui_show_frame_info): Update.
 427         * tui/tui-data.h (struct tui_list): Remove.
 428         (tui_source_windows): Return a reference to a std::vector.
 429         * tui/tui-data.c (source_windows): Now a std::vector.
 430         (tui_source_windows): Change return type.
 431         (tui_clear_source_windows): Rewrite.
 432         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 433         (tui_free_all_source_wins_content): Rewrite.
 434
 435 2019-06-25  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 438         (struct tui_data_window, struct tui_cmd_window): Declare
 439         clear_detail method.
 440         * tui/tui-data.c (tui_source_window::clear_detail)
 441         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 442         methods.
 443         (tui_clear_win_detail): Simplify.
 444
 445 2019-06-25  Tom Tromey  <tom@tromey.com>
 446
 447         * tui/tui-layout.c (make_source_window, make_disasm_window)
 448         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 449         Return the new window.
 450         (show_source_disasm_command, show_data)
 451         (show_source_or_disasm_and_command): Update.
 452
 453 2019-06-25  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 456         parameter.  Return the new window.
 457         (show_source_disasm_command): Update and remove NULL check.
 458         (show_source_or_disasm_and_command): Update.
 459
 460 2019-06-25  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 463
 464 2019-06-25  Tom Tromey  <tom@tromey.com>
 465
 466         * tui/tui-data.h (struct tui_win_info): Make constructor
 467         protected.  Make destructor virtual.  Add initializers.
 468         (tui_source_window, tui_data_window, tui_cmd_window): New
 469         classes.
 470         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 471         constructor.  Add "type" parameter.
 472         (tui_source_window, tui_data_window, tui_cmd_window): New
 473         constructors.
 474         (tui_alloc_win_info): Instantiate the appropriate subclass.
 475
 476 2019-06-25  Tom Tromey  <tom@tromey.com>
 477
 478         * tui/tui-win.c (tui_resize_all): Use delete.
 479         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 480         destructor.
 481         (tui_free_window): Don't declare.
 482         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 483         Update.
 484
 485 2019-06-25  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-data.h (struct tui_win_info): Add constructor.
 488         * tui/tui-data.c (tui_alloc_win_info): Use new.
 489         (tui_free_window): Use delete.
 490
 491 2019-06-22  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 494         declare.
 495         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 496
 497 2019-06-22  Tom Tromey  <tom@tromey.com>
 498
 499         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 500         declare.
 501         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 502
 503 2019-06-22  Tom de Vries  <tdevries@suse.de>
 504
 505         * dwarf2read.c (create_addrmap_from_aranges)
 506         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 507         instead of '%zu'.
 508
 509 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 510
 511         * dwarf2read.h (dwarf2_section_info_def): Remove.
 512         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 513         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 514         std::vector<dwarf2_section_info>.
 515         (struct dwo_file) <~dwo_file>: Remove.
 516         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 517         types field.
 518         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 519         (dwarf2_read_debug_names): Likewise.
 520         (create_debug_types_hash_table): Change parameter type to
 521         array_view, adjust code accordingly.
 522         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 523         (partial_die_info::fixup): Likewise.
 524         (determine_prefix): Likewise.
 525         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 526
 527 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 528
 529         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 530         gdb_bfd_ref_ptr.
 531         <~dwo_file>: Remove call to gdb_bfd_unref.
 532         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 533         gdb_bfd_ref_ptr::get.
 534
 535 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 536
 537         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 538         type to htab_up.
 539         * dwarf2read.c (struct dwo_file): Initialize fields.
 540         <~dwo_file>: New.
 541         (free_dwo_file): Remove, move content to ~dwo_file.
 542         (struct dwo_file_deleter): Remove.
 543         (dwo_file_up>: Remove custom deleter.
 544         (free_dwo_files): Remove.
 545         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 546         dwo_files.
 547         (process_skeletonless_type_units): Call unique_ptr::get.
 548         (allocate_dwo_file_hash_table): Add deleter to created hash
 549         table.  Change return type to htab_up.
 550         (lookup_dwo_file_slot): Don't memset dwo_file, call
 551         unique_ptr::get.
 552         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 553         (create_dwo_unit_in_dwp_v2): Likewise.
 554         (open_and_init_dwo_file): Likewise.
 555         (free_dwo_file_from_slot): Remove.
 556
 557 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 558
 559         * dwarf2read.h (struct dwarf2_section_info) <readin,
 560         is_virtual>: Change type to bool.
 561         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 562         true instead of 1.
 563
 564 2019-06-19  Tom Tromey  <tom@tromey.com>
 565
 566         * tui/tui-data.h (tui_init_content_element): Don't declare.
 567
 568 2019-06-19  Tom Tromey  <tom@tromey.com>
 569
 570         * tui/tui-data.h (tui_init_win_info): Don't declare.
 571
 572 2019-06-19  Tom de Vries  <tdevries@suse.de>
 573
 574         * dwarf2read.h (abstract_to_concrete): Change type to
 575         std::unordered_map<sect_offset, std::vector<sect_offset>,
 576         gdb::hash_enum<sect_offset>>.
 577
 578 2019-06-19  Tom Tromey  <tromey@adacore.com>
 579
 580         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 581         EVAL_AVOID_SIDE_EFFECTS specially.
 582
 583 2019-06-19  Tom Tromey  <tromey@adacore.com>
 584
 585         * source-cache.c (highlighter): New global.
 586         (source_cache::get_source_lines): Create a highlighter on demand.
 587
 588 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 589
 590         * defs.h (deprecated_interactive_hook): Delete declaration.
 591         * interps.c (clear_interpreter_hooks): Remove use of
 592         deprecated_interactive_hook.
 593         * top.c (deprecated_interactive_hook): Delete definition.
 594         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 595
 596 2019-06-18  Tom de Vries  <tdevries@suse.de>
 597
 598         PR gdb/24515
 599         * dwarf2read.h (abstract_to_concrete): Change type from
 600         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 601         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 602         * dwarf2read.c (read_variable): Update.
 603         (dwarf2_fetch_die_loc_sect_off): Update.
 604
 605 2019-06-17  Tom de Vries  <tdevries@suse.de>
 606
 607         PR gdb/24617
 608         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 609         accessing parent[parent_len - 1].
 610
 611 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 612
 613         PR gdb/24364
 614         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 615         call dtrace_process_dof with NULL dof.
 616
 617 2019-06-16  Tom de Vries  <tdevries@suse.de>
 618
 619         PR gdb/24445
 620         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 621
 622 2019-06-16  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 625         (make_all_visible): Use address of member.
 626
 627 2019-06-16  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 630         (tui_free_window, free_content, free_content_elements): Remove
 631         unnecessary cast.
 632         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 633         cast.
 634         * tui/tui-regs.c (tui_show_register_group)
 635         (tui_display_registers_from, tui_display_reg_element_at_line):
 636         Remove unnecessary cast.
 637
 638 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 639
 640         * linux-nat.c (normal_mask): Delete.
 641         (_initialize_linux_nat): Don't initialise normal_mask.
 642
 643 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 644
 645         PR gdb/24445
 646         * dwarf-index-write.h (write_psymtabs_to_index): Add
 647         dwz_basename parameter.
 648         * dwarf-index-write.c (write_gdbindex): Move file writing to
 649         write_gdbindex_1.  Change return type void.
 650         (assert_file_size): Move up, remove filename parameter.
 651         (write_gdbindex_1): New function.
 652         (write_debug_names): Change return type to void, call
 653         assert_file_size.
 654         (struct index_wip_file): New struct.
 655         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 656         file logic to index_wip_file.  Write index for dwz file if
 657         needed.
 658         (save_gdb_index_command): Pass basename of dwz file, if present.
 659         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 660         build-id of dwz file, if present.
 661         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 662         (dwarf2_get_dwz_file): Likewise.
 663         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 664         (dwarf2_get_dwz_file): Likewise.
 665
 666 2019-06-16  Tom Tromey  <tom@tromey.com>
 667
 668         * coffread.c (process_coff_symbol): Use xstrdup.
 669         * value.c (create_internalvar): Use xstrdup.
 670
 671 2019-06-16  Tom Tromey  <tom@tromey.com>
 672
 673         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 674         * breakpoint.c (stopin_command, stopat_command)
 675         (until_break_command, decode_location_default): Remove unnecessary
 676         cast.
 677         * utils.c (subset_compare): Remove unnecessary cast.
 678         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 679         cast.
 680         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 681         cast.
 682         * infcmd.c (path_command): Remove unnecessary cast.
 683         * coffread.c (decode_type): Remove unnecessary cast.
 684         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 685         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 686         * tui/tui-stack.c (tui_show_locator_content)
 687         (tui_show_frame_info): Remove unnecessary cast.
 688         * tui/tui-win.c (tui_scroll_forward_command)
 689         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 690         (parse_scrolling_args): Remove unnecessary cast.
 691         * tui/tui-data.c (init_win_info, tui_del_window)
 692         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 693         (free_content_elements): Remove unnecessary cast.
 694         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 695         unnecessary cast.
 696         * tui/tui-source.c (tui_set_source_content)
 697         (tui_vertical_source_scroll): Remove unnecessary cast.
 698         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 699         cast.
 700         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 701         * tui/tui-regs.c (tui_display_registers_from)
 702         (tui_display_register): Remove unnecessary cast.
 703         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 704         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 705         (make_visible): Remove unnecessary cast.
 706         * tui/tui-winsource.c (tui_erase_source_content)
 707         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 708         unnecessary cast.
 709         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 710         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 711         * stabsread.c (read_type, read_array_type, read_range_type):
 712         Remove unnecessary cast.
 713         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 714         (parse_symbol, parse_type, upgrade_type, parse_external)
 715         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 716         unnecessary cast.
 717         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 718
 719 2019-06-16  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-data.c (tui_alloc_generic_win_info)
 722         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 723         checks.
 724
 725 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 726             Andrew Burgess  <andrew.burgess@embecosm.com>
 727
 728         * f-typeprint.c (f_print_type): Don't return early for not
 729         associated or not allocated types.
 730         (f_type_print_varspec_suffix): Add print_rank parameter and print
 731         ranks of array types in case they dangling.
 732         (f_type_print_base): Add print_rank parameter.
 733
 734 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 735
 736         * NEWS: Mention new MI commands.
 737         * break-catch-throw.c (enum exception_event_kind): Move to
 738         breakpoint.h.
 739         (print_mention_exception_catchpoint): Output text as a single
 740         message.
 741         (catch_exception_command_1): Rename to...
 742         (catch_exception_event): ...this, make non-static, update header
 743         command, and change some parameter types.
 744         (catch_catch_command): Update for changes to
 745         catch_exception_command_1.
 746         (catch_throw_command): Likewise.
 747         (catch_rethrow_command): Likewise.
 748         * breakpoint.c (enum exception_event_kind): Delete.
 749         * breakpoint.h (enum exception_event_kind): Moved here from
 750         break-catch-throw.c.
 751         (catch_exception_event): Declare.
 752         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 753         (mi_cmd_catch_throw): New function.
 754         (mi_cmd_catch_rethrow): New function.
 755         (mi_cmd_catch_catch): New function.
 756         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 757         'catch-catch' entries.
 758         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 759         (mi_cmd_catch_rethrow): Declare.
 760         (mi_cmd_catch_catch): Declare.
 761
 762 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 763
 764         * annotate.c (annotate_source_line): Change return type to void,
 765         update implementation to match.
 766         * annotate.h (annotate_source_line): Change return type to void,
 767         update header comment.
 768         * stack.c (print_frame_info): Don't change what frame information
 769         is printed based on whether annotations are on or not.
 770
 771 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 774         (annotate_source): Make static.
 775         (annotate_source_line): Moved from source.c and renamed from
 776         identify_source_line.  Update the return type.
 777         * annotate.h (annotate_source): Delete declaration.
 778         (annotate_source_line): Declaration moved from source.h, and
 779         renamed from identify_source_line.  Return type updated.
 780         * source.c (identify_source_line): Moved to annotate.c and renamed
 781         to annotate_source_line.
 782         (info_line_command): Remove check of annotation_level.
 783         * source.h (identify_source_line): Move declaration to annotate.h
 784         and rename to annotate_source_line.
 785         * stack.c: Add 'annotate.h' include.
 786         (print_frame_info): Remove check of annotation_level before
 787         calling annotate_source_line.
 788
 789 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 790
 791         * source-cache.c (source_cache::get_plain_source_lines): Use
 792         open_source_file_with_line_charpos instead of just
 793         open_source_file, remove call to find_source_lines.
 794         (source_cache::get_source_lines): Likewise.
 795         * source.c (find_source_lines): Make static.
 796         (get_filename_and_charpos): Renamed into...
 797         (open_source_file_with_line_charpos): ..this along with changes to
 798         return a scoped_fd, and some other minor clean ups.
 799         (identify_source_line): Use open_source_file_with_line_charpos.
 800         (search_command_helper): Use open_source_file_with_line_charpos
 801         instead of just open_source_file, remove call to
 802         find_source_lines.
 803         * source.h (open_source_file_with_line_charpos): Declare new
 804         function.
 805         (find_source_lines): Delete declaration.
 806
 807 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 808
 809         * source.c (get_filename_and_charpos): Remove fullname
 810         parameter.
 811         (identify_source_line): Update call to get_filename_and_charpos.
 812
 813 2019-06-14  Tom Tromey  <tromey@adacore.com>
 814
 815         PR gdb/24502:
 816         * ui-style.h (skip_ansi_escape): Update comment.
 817         * ui-file.h (class no_terminal_escape_file): New class.
 818         * ui-file.c (no_terminal_escape_file::write)
 819         (no_terminal_escape_file::puts): New methods.
 820         * cli/cli-logging.c (handle_redirections): Use
 821         no_terminal_escape_file.
 822
 823 2019-06-14  Tom Tromey  <tromey@adacore.com>
 824
 825         * NEWS: Move convenience variable news above Python news.
 826
 827 2019-06-14  Tom Tromey  <tom@tromey.com>
 828
 829         * gnulib: Move directory to top-level.
 830         * configure.ac: Don't configure gnulib.
 831         * configure: Rebuild.
 832         * common/common-defs.h: Use new path to gnulib.
 833         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 834         (GNULIB_H): Remove.
 835         (INCGNU): Look in new gnulib location.
 836         (HFILES_NO_SRCDIR): Remove gnulib files.
 837         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 838         (generated_files): Remove GNULIB_H.
 839         ($(LIBGNU), all-lib): Remove targets.
 840         (distclean): Don't mention GNULIB_BUILDDIR.
 841         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 842
 843 2019-06-14  Tom Tromey  <tromey@adacore.com>
 844
 845         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 846         Warn if symbol file does not provide any symbols.
 847
 848 2019-06-14  Tom Tromey  <tromey@adacore.com>
 849
 850         * source.c (find_and_open_source): Respect basenames_may_differ.
 851
 852 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 853
 854         * annotate.c (annotate_breakpoints_invalid): Make use of
 855         scoped_restore_terminal_state.
 856         (annotate_frames_invalid): Likewise.
 857
 858 2019-06-14  Tom Tromey  <tromey@adacore.com>
 859
 860         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 861         allow assignment to an internalvar.
 862
 863 2019-06-14  Tom Tromey  <tromey@adacore.com>
 864
 865         * ada-lex.l: Allow "_" in attribute names.
 866
 867 2019-06-14  Tom Tromey  <tromey@adacore.com>
 868
 869         PR gdb/24653:
 870         * regcache.c (registers_changed): Don't call alloca.
 871         * top.c (execute_command): Don't call alloca.
 872
 873 2019-06-13  Pedro Alves  <palves@redhat.com>
 874
 875         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 876         'expression'.  When parsing an expression, error out if there's
 877         junk after "unlimited".
 878         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 879         (do_set_command): Adjust calls to is_unlimited_literal.
 880
 881 2019-06-13  Pedro Alves  <palves@redhat.com>
 882
 883         * compile/compile.c (make_compile_options_def_group): Add braces
 884         around array_view initializer.
 885         * thread.c (make_thread_apply_all_options_def_group)
 886         (make_thread_apply_all_options_def_group): Likewise.
 887
 888 2019-06-13  Pedro Alves  <palves@redhat.com>
 889
 890         * NEWS (New commands): Mention "maint test-options
 891         require-delimiter", "maint test-options unknown-is-error", "maint
 892         test-options unknown-is-operand" and "maint show
 893         test-options-completion-result".
 894         (New command options, command completion): New section.
 895         (Completion improvements): New section.
 896         Mention that you can abbreviate "unlimited".
 897
 898 2019-06-13  Pedro Alves  <palves@redhat.com>
 899
 900         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 901         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 902         * unittests/cli-utils-selftests.c (test_parse_flags)
 903         (test_parse_flags_qcs): Delete.
 904         (test_cli_utils): Don't call deleted functions.
 905
 906 2019-06-13  Pedro Alves  <palves@redhat.com>
 907
 908         * thread.c: Include "cli/cli-option.h".
 909         (tp_array_compar_ascending): Global.
 910         (tp_array_compar): Delete function.
 911         (tp_array_compar_ascending, tp_array_compar_descending): New
 912         functions.
 913         (ascending_option_def, qcs_flag_option_def)
 914         (thr_qcs_flags_option_defs)
 915         (make_thread_apply_all_options_def_group)
 916         (make_thread_apply_options_def_group): New.
 917         (thread_apply_all_command): Use gdb::option::process_options.
 918         (thread_apply_command_completer)
 919         (thread_apply_all_command_completer): New.
 920         (thread_apply_command): Use gdb::option::process_options.
 921         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 922         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 923         to generate help text of "thread apply".  Adjust "taas"'s help.
 924         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 925         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 926
 927 2019-06-13  Pedro Alves  <palves@redhat.com>
 928
 929         * thread.c (thread_apply_command): Check for invalid TID with
 930         isdigit instead of !isalpha.
 931
 932 2019-06-13  Pedro Alves  <palves@redhat.com>
 933
 934         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 935         (validate_flags_qcs): New.
 936         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 937         (validate_flags_qcs): Declare.
 938         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 939         (make_frame_apply_options_def_group): New.
 940         (frame_apply_command_count): Process options with
 941         gdb::option::process_options.
 942         (frame_apply_completer): New.
 943         (frame_apply_level_completer, frame_apply_all_completer)
 944         (frame_apply_completer): New.
 945         (_initialize_stack): Update help of "frame apply", "frame apply
 946         level", "frame apply all" and "faas" to mention supported options
 947         and install command completers.
 948         * stack.h (frame_apply_all_completer): Declare.
 949         * thread.c: Include "stack.h".
 950         (tfaas_command): Add "--".
 951         (_initialize_thread): Update help "tfaas" to mention supported
 952         options and install command completer.
 953
 954 2019-06-13  Pedro Alves  <palves@redhat.com>
 955
 956         * completer.c (complete_nested_command_line): New.
 957         (gdb_completion_word_break_characters_throw): Add assertion.
 958         * completer.h (complete_nested_command_line): Declare.
 959
 960 2019-06-13  Pedro Alves  <palves@redhat.com>
 961
 962         * stack.c (parse_backtrace_qualifiers): New.
 963         (backtrace_command): Use it.
 964         (backtrace_command_completer): Complete on qualifiers.
 965
 966 2019-06-13  Pedro Alves  <palves@redhat.com>
 967
 968         * frame.c: Include "cli/cli-option.h.
 969         (user_set_backtrace_options): New.
 970         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 971         Delete.
 972         (get_prev_frame): Adjust.
 973         (boolean_option_def, uinteger_option_def)
 974         (set_backtrace_option_defs): New.
 975         (_initialize_frame): Adjust and use
 976         gdb::option::add_setshow_cmds_for_options to install "set
 977         backtrace past-main" and "set backtrace past-entry".
 978         * frame.h: Include "cli/cli-option.h".
 979         (struct frame_print_options): Forward declare.
 980         (print_frame_arguments_all, print_frame_arguments_scalars)
 981         (print_frame_arguments_none): Declare.
 982         (print_entry_values): Delete declaration.
 983         (struct frame_print_options, user_frame_print_options): New.
 984         (struct set_backtrace_options): New.
 985         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 986         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 987         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 988         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 989         (list_args_or_locals): Add frame_print_options parameter.
 990         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 991         * python/py-framefilter.c (enumerate_args): Pass down
 992         USER_FRAME_PRINT_OPTIONS.
 993         * stack.c: Include "cli/cli-option.h".
 994         (print_frame_arguments_all, print_frame_arguments_scalars)
 995         (print_frame_arguments_none): Declare.
 996         (print_raw_frame_arguments, print_entry_values): Delete.
 997         (user_frame_print_options): New.
 998         (boolean_option_def, enum_option_def, frame_print_option_defs):
 999         New.
1000         (struct backtrace_cmd_options): New.
1001         (bt_flag_option_def): New.
1002         (backtrace_command_option_defs): New.
1003         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1004         (print_frame_arg, read_frame_arg, print_frame_args)
1005         (print_frame_info, print_frame): Add frame_print_options parameter
1006         and use it.
1007         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1008         (backtrace_command_1): Add frame_print_options and
1009         backtrace_cmd_options parameters and use them.
1010         (make_backtrace_options_def_group): New.
1011         (backtrace_command): Process command options with
1012         gdb::option::process_options.
1013         (backtrace_command_completer): New.
1014         (_initialize_stack): Extend "backtrace"'s help to mention
1015         supported options.  Install completer for "backtrace".
1016         Install some settings commands with add_setshow_cmds_for_options.
1017
1018 2019-06-13  Pedro Alves  <palves@redhat.com>
1019
1020         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1021         and that "set/show print raw frame-arguments" are now deprecated.
1022
1023         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1024         command.
1025         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1026         * stack.c (_initialize_stack): Install "set/show print
1027         raw-frame-arguments", and deprecate "set/show print raw
1028         frame-arguments".
1029         * valprint.c (_initialize_valprint): Deprecate "set/show print
1030         raw".
1031
1032 2019-06-13  Pedro Alves  <palves@redhat.com>
1033
1034         * compile/compile.c (struct compile_options): New.
1035         (compile_flag_option_def, compile_command_option_defs)
1036         (make_compile_options_def_group): New.
1037         (compile_file_command): Handle options with
1038         gdb::option::process_options.
1039         (compile_file_command_completer): New function.
1040         (compile_code_command): Handle options with
1041         gdb::option::process_options.
1042         (compile_code_command_completer): New function.
1043         (_initialize_compiler): Install completers for "compile code" and
1044         "compile file".  Mention available options in "compile code" and
1045         "compile code"'s help.
1046         * completer.c (advance_to_completion_word): New, factored out from
1047         ...
1048         (advance_to_expression_complete_word_point): ... this.
1049         (advance_to_filename_complete_word_point): New.
1050         * completer.h (advance_to_filename_complete_word_point): New
1051         declaration.
1052
1053 2019-06-13  Pedro Alves  <palves@redhat.com>
1054
1055         * compile/compile.c: Include "cli/cli-option.h".
1056         (compile_print_value): Scope data pointer is now a
1057         value_print_options pointer; adjust.
1058         (compile_print_command): Process options.  Scope data pointer is
1059         now a value_print_options pointer; adjust.
1060         (_initialize_compile): Update "compile print"'s help to include
1061         supported options.  Install a completer for "compile print".
1062         * cp-valprint.c (show_vtblprint, show_objectprint)
1063         (show_static_field_print): Delete.
1064         (_initialize_cp_valprint): Don't install "set print
1065         static-members", "set print vtbl", "set print object" here.
1066         * printcmd.c: Include "cli/cli-option.h" and
1067         "common/gdb_optional.h".
1068         (print_command_parse_format): Rework to fill in a
1069         value_print_options instead of a format_data.
1070         (print_value): Change parameter type from format_data pointer to
1071         value_print_options reference.  Adjust.
1072         (print_command_1): Process options.  Adjust to pass down a
1073         value_print_options.
1074         (print_command_completer): New.
1075         (_initialize_printcmd): Install print_command_completer as
1076         handle_brkchars completer for the "print" command.  Update
1077         "print"'s help to include supported options.
1078         * valprint.c: Include "cli/cli-option.h".
1079         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1080         here from cp-valprint.c.
1081         (boolean_option_def, uinteger_option_def)
1082         (value_print_option_defs, make_value_print_options_def_group):
1083         New.  Use gdb::option::add_setshow_cmds_for_options to install
1084         "set print elements", "set print null-stop", "set print repeats",
1085         "set print pretty", "set print union", "set print array", "set
1086         print address", "set print symbol", "set print array-indexes".
1087         * valprint.h: Include <string> and "cli/cli-option.h".
1088         (make_value_print_options_def_group): Declare.
1089         (print_value): Change parameter type from format_data pointer to
1090         value_print_options reference.
1091         (print_command_completer): Declare.
1092
1093 2019-06-13  Pedro Alves  <palves@redhat.com>
1094
1095         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1096         (COMMON_SFILES): Add maint-test-settings.c.
1097         * cli/cli-decode.c (boolean_enums): New global, factored out from
1098         ...
1099         (add_setshow_boolean_cmd): ... here.
1100         * cli/cli-decode.h (boolean_enums): Declare.
1101         * cli/cli-option.c: New file.
1102         * cli/cli-option.h: New file.
1103         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1104         factored out from ...
1105         (parse_cli_boolean_value(const char *)): ... this.
1106         (is_unlimited_literal): Change parameter type to pointer to
1107         pointer.  Adjust and advance ARG pointer.
1108         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1109         (parse_cli_var_enum): New, factored out from ...
1110         (do_set_command): ... this.  Adjust.
1111         * cli/cli-setshow.h (parse_cli_boolean_value)
1112         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1113         (parse_cli_var_enum): Declare.
1114         * cli/cli-utils.c: Include "cli/cli-option.h".
1115         (get_ulongest): New.
1116         * cli/cli-utils.h (get_ulongest): Declare.
1117         (check_for_argument): New overloads.
1118         * maint-test-options.c: New file.
1119
1120 2019-06-13  Pedro Alves  <palves@redhat.com>
1121
1122         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1123         parse a range if "-" is at the end of the string.
1124
1125 2019-06-13  Pedro Alves  <palves@redhat.com>
1126
1127         * cli/cli-setshow.c (parse_auto_binary_operation)
1128         (parse_cli_boolean_value): Don't allow "o".
1129
1130 2019-06-13  Pedro Alves  <palves@redhat.com>
1131
1132         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1133         * NEWS: Mention maint test-settings KIND.
1134         * maint-test-settings.c: New file.
1135
1136 2019-06-13  Pedro Alves  <palves@redhat.com>
1137
1138         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1139         completer.
1140         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1141         "set" completers.
1142
1143 2019-06-13  Pedro Alves  <palves@redhat.com>
1144
1145         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1146         after item.
1147
1148 2019-06-13  Pedro Alves  <palves@redhat.com>
1149
1150         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1151
1152 2019-06-13  Pedro Alves <palves@redhat.com>
1153
1154         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1155         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1156         call.
1157         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1158         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1159         calls.
1160         (check_for_argument): Skip spaces after argument.
1161
1162 2019-06-13  Pedro Alves  <palves@redhat.com>
1163
1164         * thread.c (thread_apply_command): Adjust TID parsing.
1165         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1166         detected before end of string.
1167         (tid_is_in_list): Error out if LIST is invalid.
1168
1169 2019-06-13  Pedro Alves  <palves@redhat.com>
1170
1171         * completer.c (complete_line_internal_1): Rewind completion word
1172         point.
1173         (completion_tracker::advance_custom_word_point_by): Change
1174         parameter type to int.
1175         * completer.h (completion_tracker::advance_custom_word_point_by):
1176         Likewise.
1177
1178 2019-06-13  Pedro Alves  <palves@redhat.com>
1179
1180         * completer.c (advance_to_completion_word): Handle delimiters.
1181
1182 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1183
1184         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1185
1186 2019-06-11  Tom Tromey  <tom@tromey.com>
1187
1188         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1189         (xmalloc_failed): Move to alloc.c.
1190         * alloc.c: New file.
1191         * Makefile.in (COMMON_SFILES): Add alloc.c.
1192
1193 2019-06-11  Tom Tromey  <tom@tromey.com>
1194
1195         * nat/linux-waitpid.c: Don't include server.h.
1196         (linux_debug): Remove.
1197         (my_waitpid): Update.
1198
1199 2019-06-11  Tom Tromey  <tromey@adacore.com>
1200
1201         * infcall.c (_initialize_infcall): Remove trailing newline from
1202         help.
1203         * user-regs.c (_initialize_user_regs): Remove trailing newline
1204         from help.
1205         * typeprint.c (_initialize_typeprint): Remove trailing newline
1206         from help.
1207         * reverse.c (_initialize_reverse): Remove trailing newlines from
1208         help.
1209         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1210         from help.
1211         * language.c (add_set_language_command): Remove trailing newline
1212         from help.
1213         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1214         help.
1215         * disasm.c (_initialize_disasm): Remove trailing newline from
1216         help.
1217         * top.c (init_main): Remove trailing newline from help.
1218         * interps.c (_initialize_interpreter): Remove trailing newline
1219         from help.
1220         * btrace.c (_initialize_btrace): Remove trailing newlines from
1221         help.
1222         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1223         from help.
1224         * python/python.c (_initialize_python): Remove trailing newline
1225         from help.
1226         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1227         help.
1228         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1229         from help.  Reformat some text.
1230         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1231         from help.
1232         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1233         newline from help.
1234
1235 2019-06-11  Tom Tromey  <tromey@adacore.com>
1236
1237         * darwin-nat.c (darwin_decode_exception_message)
1238         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1239
1240 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         * valops.c (value_slice): Check for not allocated or not
1243         associated values.
1244
1245 2019-06-10  Tom de Vries  <tdevries@suse.de>
1246
1247         PR gdb/24618
1248         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1249         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1250         invalid.
1251
1252 2019-06-10  Tom de Vries  <tdevries@suse.de>
1253
1254         PR gdb/24611
1255         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1256         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1257
1258 2019-06-10  Tom de Vries  <tdevries@suse.de>
1259
1260         PR symtab/24545
1261         * symtab.c (struct demangled_name_entry): Add language field.
1262         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1263         static minimal symbol".  Set and use language field.
1264
1265 2019-06-10  Tom Tromey  <tromey@adacore.com>
1266
1267         * ada-lang.c (_initialize_ada_language): Update help text.
1268
1269 2019-06-10  Tom Tromey  <tromey@adacore.com>
1270
1271         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1272         with a newline.
1273         * guile/guile.c (handle_boot_error): Don't end warning with a
1274         newline.
1275         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1276         warning with a newline.
1277         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1278         newline.
1279         (s12z_frame_cache): Likewise.
1280         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1281         a newline.
1282         * solib-svr4.c (disable_probes_interface): Don't end warning with
1283         a newline.
1284         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1285         newline.
1286         * python/python.c (do_finish_initialization): Don't end warning
1287         with a newline.
1288
1289 2019-06-10  Tom Tromey  <tom@tromey.com>
1290
1291         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1292         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1293         gdbpy_enter.
1294
1295 2019-06-10  Tom Tromey  <tromey@adacore.com>
1296
1297         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1298         data.
1299         (elf_new_init): Don't call stabsread_new_init.
1300         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1301         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1302         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1303
1304 2019-06-10  Tom de Vries  <tdevries@suse.de>
1305
1306         PR symtab/16264
1307         PR symtab/24517
1308         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1309
1310 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1311
1312         * source.c (find_and_open_source): Also rewrite relative file
1313         names.
1314
1315 2019-04-26  Amos Bird  <amosbird@gmail.com>
1316
1317         * annotate.c (annotate_thread_exited): Add "thread-exited"
1318         annotation.
1319
1320 2019-06-06  Tom Tromey  <tromey@adacore.com>
1321
1322         * maint.h (class scoped_command_stats): Use
1323         DISABLE_COPY_AND_ASSIGN.
1324         <print_time>: New method.
1325         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1326         print_time.
1327         (scoped_command_stats::print_time): New method.
1328
1329 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1332         instructions of lengths 6 or 8 bytes.
1333
1334 2019-06-04  Pedro Alves  <palves@redhat.com>
1335
1336         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1337
1338         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1339         * breakpoint.c (condition_completer): Likewise.
1340         * cli/cli-dump.c (scan_expression): Likewise.
1341         * common/filestuff.c (mkdir_recursive): Likewise.
1342         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1343         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1344         (gdb_abspath): Likewise.
1345         * compile/compile-cplus-types.c
1346         (compile_cplus_instance::decl_name): Likewise.
1347         * completer.c (complete_explicit_location):
1348         (signal_completer, reg_or_group_completer_1): Likewise.
1349         * cp-support.c (cp_remove_params_if_any): Likewise.
1350         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1351         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1352         * infcmd.c (strip_bg_char): Likewise.
1353         * linespec.c (copy_token_string): Likewise.
1354         * mi/mi-main.c (output_cores): Likewise.
1355         * psymtab.c (psymtab_search_name):
1356         * symfile.c (test_set_ext_lang_command): Likewise.
1357         * target.c (target_fileio_read_stralloc): Likewise.
1358         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1359         * value.c (complete_internalvar): Likewise.
1360
1361 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1362
1363         Add objfile property to gdb.Type.
1364         * NEWS: Mention Python API addition.
1365         * python/py-type.c (typy_get_objfile): New method.
1366
1367 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1368
1369         * NEWS: Mention the new set|show style [title|highlight].
1370         Mention changes to "show style", "help" and "apropos".
1371
1372 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1373
1374         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1375         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1376         instead of print_help_for_command.
1377         (print_doc_of_command): New function.
1378         (help_list): Add 'apropos -v word' suggestion.
1379         (print_help_for_command): Style the command name using title style.
1380         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1381         (_initialize_cli_cmds): Describe -v in apropos_command help.
1382
1383 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1384
1385         * cli/cli-style.h (cli_style_option): Add name in constructor,
1386         add m_name class member, add constructor with intensity,
1387         add name class function.
1388         (cli_style_option::add_setshow_commands): Remove name argument.
1389         (highlight_style, title_style): New styles.
1390         * cli/cli-style.c (do_show): New function that shows a style
1391         characteristic styling the style name with itself.
1392         (set_style_name): New function.
1393         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1394         Update all callers according to the changes in cli/cli-style.h.
1395         * utils.h (fputs_highlighted): New function.
1396         * utils.c (fputs_highlighted): Likewise.
1397
1398 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1399
1400         * NEWS: Mention new pipe command and new convenience variables.
1401
1402 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1403
1404         * cli/cli-cmds.c (pipe_command): New function.
1405         (_initialize_cli_cmds): Call add_com for pipe_command.
1406         Define | as an alias for pipe.
1407         (exit_status_set_internal_vars): New function.
1408         (shell_escape): Call exit_status_set_internal_vars.
1409         cli/cli-decode.c (find_command_name_length): Recognize | as
1410         a single character command.
1411
1412 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1413
1414         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1415         top.c (execute_command_to_ui_file): New function, mostly a copy
1416         of execute_command_to_string.
1417         (execute_command_to_string): Implement by calling
1418         execute_command_to_ui_file.
1419
1420 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1421
1422         * top.h (saved_command_line): Remove declaration.
1423         * top.c (previous_saved_command_line, previous_repeat_arguments):
1424         New variables.
1425         (saved_command_line): Make static, define together with other
1426         'repeat variables'.
1427         (dont_repeat): Clear repeat_arguments.
1428         (repeat_previous, get_saved_command_line, save_command_line):
1429         New functions.
1430         (gdb_init): Initialize saved_command_line
1431         and previous_saved_command_line.
1432         * main.c (captured_main_1): Remove saved_command_line initialization.
1433         * event-top.c (handle_line_of_input): Update to use
1434         the new 'repeat' related functions instead of direct access to
1435         saved_command_line.
1436         * command.h (repeat_previous, get_saved_command_line,
1437         save_command_line): New declarations.
1438         (dont_repeat): Add comment.
1439
1440 2019-05-30  Tom Tromey  <tromey@adacore.com>
1441
1442         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1443         Fix comment.
1444         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1445
1446 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1447
1448         PR cli/24587
1449         * completer.c (complete): Initialize variable word.
1450
1451 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1452
1453         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1454         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1455         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1456         'body' is NULL to the outter 'if', protecting the '!is_define'
1457         situation as well.
1458
1459 2019-05-29  Tom Tromey  <tromey@adacore.com>
1460
1461         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1462         (dwarf_unknown): New function.
1463         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1464         (dwarf_type_encoding_name): Use dwarf_unknown.
1465
1466 2019-05-29  Tom Tromey  <tromey@adacore.com>
1467
1468         PR c++/20020:
1469         * cp-valprint.c (cp_print_value_fields): Call
1470         cp_print_static_field inside "try".
1471
1472 2019-05-29  Tom Tromey  <tromey@adacore.com>
1473
1474         * inflow.c (struct terminal_info): Add default operator=.
1475         * configure: Rebuild.
1476         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1477         -Wdeprecated-copy-dtor, -Wredundant-move.
1478
1479 2019-05-29  Tom Tromey  <tromey@adacore.com>
1480
1481         * NEWS: Add entry.
1482         * infcmd.c (print_return_value_1): Handle finish_print
1483         option.
1484         (show_print_finish): New function.
1485         (_initialize_infcmd): Add "set/show print finish" commands.
1486         * valprint.c (user_print_options): Initialize new member.
1487         * valprint.h (struct value_print_options) <finish_print>: New
1488         member.
1489
1490 2019-05-28  Tom Tromey  <tromey@adacore.com>
1491
1492         * ada-lang.c (ada_remove_Xbn_suffix)
1493         (find_old_style_renaming_symbol)
1494         (parse_old_style_renaming): Remove.
1495         (ada_find_renaming_symbol): Don't call
1496         find_old_style_renaming_symbol.
1497         (ada_is_renaming_symbol): Rename from
1498         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1499         bool.  Now static.
1500         (ada_read_var_value): Update and simplify.
1501         * ada-exp.y (write_var_or_type): Remove old code.
1502
1503 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1504
1505         * event-top.c: Remove include comment.
1506         * inflow.c (class scoped_ignore_sigttou): Move from here...
1507         * inflow.h (class scoped_ignore_sigttou): ...to here.
1508         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1509         * top.c:  Remove include comment.
1510
1511 2019-05-27  Tom Tromey  <tom@tromey.com>
1512
1513         * NEWS: Fix typo.
1514
1515 2019-05-22  Tom Tromey  <tromey@adacore.com>
1516
1517         * target.c (target_follow_exec): Constify parameter.
1518         * target-delegates.c: Rebuild.
1519         * remote.c (remote_target::follow_exec): Constify parameter.
1520         * infrun.c (follow_exec): Constify parameter.
1521         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1522         (target_follow_exec): Likewise.
1523
1524 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1525
1526         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1527         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1528
1529 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1530
1531         * NEWS: Add debugredirect and testsuite sections.
1532
1533 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1534
1535         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1536         target descriptions using exclusively floating point register name
1537         aliases.
1538
1539 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1540
1541         PR gdb/18644:
1542         * f-lang.c (build_fortran_types): Handle the case where
1543         gdbarch_floatformat_for_type returns a nullptr.
1544
1545 2019-05-21  Tom de Vries  <tdevries@suse.de>
1546
1547         PR cli/24587
1548         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1549
1550 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1551
1552         PR gdb/18644:
1553         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1554         16-byte floats.
1555         * i386-tdep.c (i386_floatformat_for_type): Use
1556         floatformats_ia64_quad for the 16-byte floating point component
1557         within a fortran 32-byte complex number.
1558
1559 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1560
1561         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1562         delete default constructor.
1563         (find_partial_die): Update to return const struct.
1564         (partial_die_parent_scope): Move variable declaration into scope
1565         of its use and change its type to auto.
1566         (guess_partial_die_structure_name): Likewise.
1567         (partial_die_info::fixup): Likewise.
1568
1569 2019-05-17  Tom Tromey  <tromey@adacore.com>
1570
1571         * source.c (find_and_open_source): Remove cast.
1572
1573 2019-05-17  Tom Tromey  <tromey@adacore.com>
1574
1575         * annotate.c (annotate_source): Make "filename" const.
1576         * annotate.h (annotate_source): Use const.
1577
1578 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1579
1580         * disasm.c (set_disassembler_options): Send errors to stderr.
1581
1582 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1583
1584         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1585         (cli_interp_base::set_logging): Check debug_redirect.
1586         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1587         * cli/cli-logging.c (debug_redirect): Add static variable.
1588         (pop_output_files): Add default param.
1589         (handle_redirections): Print debug setting.
1590         (show_logging_command): Likewise.
1591         (_initialize_cli_logging): Add debugredirect command.
1592         * interps.c (current_interp_set_logging): Add debug_redirect
1593         parameter.
1594         * interps.h (set_logging): Add debug_redirect parameter.
1595         (current_interp_set_logging): Likewise.
1596         * mi/mi-common.h: Likewise.
1597         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1598
1599 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1600             Tom Tromey  <tromey@adacore.com>
1601
1602         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1603         directly.
1604         * cli/cli-interp.h (make_logging_output): Remove declaration.
1605         * cli/cli-logging.c (make_logging_output): Remove function.
1606         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1607         directly.
1608         * ui-file.c (tee_file::tee_file): Remove bools.
1609         (tee_file::~tee_file): Remove deletes.
1610         * ui-file.h (tee_file): Remove bools.
1611
1612 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1613
1614         * mi/mi-cmds.h (mi_cmd_complete): New function.
1615         * mi/mi-main.c (mi_cmd_complete): Likewise.
1616         * mi/mi-cmds.c: Define new MI command -complete.
1617         * NEWS: Mention new -complete command.
1618
1619 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1620
1621         * completer.h (complete): New function.
1622         * completer.c (complete): Likewise.
1623         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1624         function defined in completer.h.
1625
1626 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1627
1628         * MAINTAINERS (Write After Approval): Add myself.
1629
1630 2019-05-17  Tom de Vries  <tdevries@suse.de>
1631
1632         PR gdb/24094
1633         * dwarf2read.c (struct cu_partial_die_info): New struct.
1634         (find_partial_die): Return cu_partial_die_info.
1635         (partial_die_parent_scope, guess_partial_die_structure_name)
1636         (partial_die_info::fixup): Handle new return type of find_partial_die.
1637
1638 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1639
1640         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1641         "std::string", simplifying the algorithm.
1642
1643 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1644
1645         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1646         (stap_static_probe_ops::get_probes): Likewise.
1647
1648 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1649
1650         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1651         '-')" and "else if".
1652         (stap_parse_single_operand): Join checks for
1653         "gdbarch_stap_parse_special_token_p" and
1654         "gdbarch_stap_parse_special_token" in the same "if" statement.
1655         Invert check when verifying for operation on register
1656         displacement.
1657
1658 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1659
1660         * stap-probe.c (stap_get_opcode): Update comment.
1661         (stap_get_expected_argument_type): Likewise.
1662         (handle_stap_probe): Likewise.
1663
1664 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1665
1666         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1667         return type to 'bool'.  Adjust comment.  Use 'bool' when
1668         appropriate.
1669         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1670         * stap-probe.c (stap_parse_argument_1): Likewise.
1671         (stap_is_operator): Likewise.
1672         (stap_is_generic_prefix): Likewise.
1673         (stap_is_register_prefix): Likewise.
1674         (stap_is_register_indirection_prefix): Likewise.
1675         (stap_is_integer_prefix): Likewise.
1676         (stap_generic_check_suffix): Likewise.
1677         (stap_check_integer_suffix): Likewise.
1678         (stap_check_register_suffix): Likewise.
1679         (stap_check_register_indirection_suffix): Likewise.
1680         (stap_parse_register_operand): Likewise.
1681         (stap_parse_single_operand): Likewise.
1682         (stap_parse_argument_1): Likewise.
1683         (stap_probe::get_argument_count): Likewise.
1684         (stap_is_operator): Likewise.
1685
1686 2019-05-16  Tom Tromey  <tromey@adacore.com>
1687
1688         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1689         keyword to foreach.
1690
1691 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1692
1693         * linux-thread-db.c (try_thread_db_load_1): Change return type
1694         to bool.
1695         (try_thread_db_load): Likewise.
1696         (try_thread_db_load_from_pdir_1): Likewise.
1697         (try_thread_db_load_from_pdir): Likewise.
1698         (try_thread_db_load_from_sdir): Likewise.
1699         (try_thread_db_load_from_dir): Likewise.
1700         (thread_db_load_search): Likewise.
1701         (has_libpthread): Likewise.
1702         (thread_db_load): Likewise.
1703
1704 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1705
1706         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1707         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1708         NULL, and complain/return if that's the case.
1709
1710 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1711
1712         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1713         (advance, posn, abstract_read_memory): New functions.
1714         [struct mem_read_abstraction]: New struct.
1715         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1716
1717 2019-05-14  Tom Tromey  <tromey@adacore.com>
1718
1719         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1720         value is not lval_memory.
1721
1722 2019-05-14  Tom Tromey  <tromey@adacore.com>
1723
1724         * solib.c (info_sharedlibrary_command): Style the file name.
1725
1726 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1727
1728         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1729         (aarch64_vnv_type): Likewise.
1730         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1731         * common/tdesc.c: Likewise.
1732         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1733         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1734         * features/aarch64-fpu.xml: Add ieee half view.
1735         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1736         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1737         * gdbtypes.h (struct builtin_type): Likewise.
1738         (struct objfile_type): Likewise.
1739
1740 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1741
1742         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1743         typo.
1744         * location.h (string_to_event_location): Likewise.
1745
1746 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1747
1748         GDB 8.3 released.
1749
1750 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1751
1752         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1753         New variable declaration.
1754         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1755         New variable.
1756         (print_one_breakpoint): Use ui_out::test_flags and new global
1757         variable to compute use_fixed_output.
1758         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1759         Remove.
1760         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1761         (mi_multi_location_breakpoint_output_fixed): Remove.
1762         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1763         new variable.
1764         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1765         fix_multi_location_breakpoint_output flag if version >= 3.
1766         * ui-out.h (enum ui_out_flag)
1767         <fix_multi_location_breakpoint_output>: New enumerator.
1768
1769 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1770
1771         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1772
1773 2019-05-10  Tom Tromey  <tromey@adacore.com>
1774
1775         * ada-lang.c (catch_ada_completer): New function.
1776         (_initialize_ada_language): Use it.
1777
1778 2019-05-10  Tom Tromey  <tromey@adacore.com>
1779
1780         * thread.c (print_thread_info): Make "requested_threads" const.
1781         * gdbthread.h (print_thread_info): Make "requested_threads"
1782         const.
1783         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1784         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1785
1786 2019-05-08  Tom Tromey  <tom@tromey.com>
1787
1788         * gdbtypes.c (objfile_type_data): Change type.
1789         (objfile_type, _initialize_gdbtypes): Update.
1790
1791 2019-05-08  Tom Tromey  <tom@tromey.com>
1792
1793         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1794         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1795         (_initialize_dwarf2_frame): Update.
1796
1797 2019-05-08  Tom Tromey  <tom@tromey.com>
1798
1799         * objc-lang.c (objc_objfile_data): Change type.
1800         (find_methods): Update.
1801         (_initialize_objc_lang): Remove.
1802
1803 2019-05-08  Tom Tromey  <tom@tromey.com>
1804
1805         * stabsread.c (rs6000_builtin_type_data): Change type.
1806         (rs6000_builtin_type, _initialize_stabsread): Update.
1807
1808 2019-05-08  Tom Tromey  <tom@tromey.com>
1809
1810         * mips-tdep.c (mips_pdr_data): Remove.
1811         (_initialize_mips_tdep): Update.
1812
1813 2019-05-08  Tom Tromey  <tom@tromey.com>
1814
1815         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1816         (hppa_init_objfile_priv_data, read_unwind_info)
1817         (find_unwind_entry, _initialize_hppa_tdep): Update.
1818
1819 2019-05-08  Tom Tromey  <tom@tromey.com>
1820
1821         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1822         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1823         on obstack.
1824         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1825
1826 2019-05-08  Tom Tromey  <tom@tromey.com>
1827
1828         * mdebugread.c (basic_type_data): Change type.
1829         (basic_type, _initialize_mdebugread): Update.
1830
1831 2019-05-08  Tom Tromey  <tom@tromey.com>
1832
1833         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1834
1835 2019-05-08  Tom Tromey  <tom@tromey.com>
1836
1837         * nto-tdep.c (nto_inferior_data_reg): Change type.
1838         (nto_inferior_data): Update.
1839         (nto_inferior_data_cleanup, nto_new_inferior_data)
1840         (_initialize_nto_tdep): Remove.
1841         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1842
1843 2019-05-08  Tom Tromey  <tom@tromey.com>
1844
1845         * ada-lang.c (struct ada_inferior_data): Add initializers.
1846         (ada_inferior_data): Change type.
1847         (ada_inferior_data_cleanup): Remove.
1848         (get_ada_inferior_data, ada_inferior_exit)
1849         (struct ada_pspace_data): Add initializers, destructor.
1850         (ada_pspace_data_handle): Change type.
1851         (get_ada_pspace_data): Update.
1852         (ada_pspace_data_cleanup): Remove.
1853
1854 2019-05-08  Tom Tromey  <tom@tromey.com>
1855
1856         * coffread.c (struct coff_symfile_info): Add initializers.
1857         (coff_objfile_data_key): Move lower.  Change type.
1858         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1859         Update.
1860         (coff_free_info): Remove.
1861
1862 2019-05-08  Tom Tromey  <tom@tromey.com>
1863
1864         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1865         (fbsd_pspace_data_handle): Move lower.  Change type.
1866         (get_fbsd_pspace_data): Update.
1867         (fbsd_pspace_data_cleanup): Remove.
1868         (_initialize_fbsd_tdep): Update.
1869
1870 2019-05-08  Tom Tromey  <tom@tromey.com>
1871
1872         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1873         (get_ada_tasks_pspace_data): Update.
1874         (ada_tasks_pspace_data_cleanup): Remove.
1875         (_initialize_tasks): Update.
1876         (ada_tasks_inferior_data_handle): Change type.
1877         (get_ada_tasks_inferior_data): Update.
1878         (ada_tasks_inferior_data_cleanup): Remove.
1879         (struct ada_tasks_pspace_data): Add initializers.
1880
1881 2019-05-08  Tom Tromey  <tom@tromey.com>
1882
1883         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1884         * symfile-debug.c (debug_sym_get_probes): Change type.
1885         * stap-probe.c (handle_stap_probe):
1886         (stap_static_probe_ops::get_probes): Change type.
1887         * probe.h (class static_probe_ops) <get_probes>: Change type.
1888         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1889         (parse_probes_in_pspace): Update.
1890         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1891         Update.
1892         (any_static_probe_ops::get_probes): Change type.
1893         * elfread.c (elfread_data): New typedef.
1894         (probe_key): Change type.
1895         (elf_get_probes): Likewise.  Update.
1896         (probe_key_free): Remove.
1897         (_initialize_elfread): Update.
1898         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1899         Change type.
1900         (dtrace_process_dof_probe, dtrace_process_dof)
1901         (dtrace_static_probe_ops::get_probe): Change type.
1902
1903 2019-05-08  Tom Tromey  <tom@tromey.com>
1904
1905         * xcoffread.c (struct xcoff_symfile_info): Rename from
1906         coff_symfile_info.  Add initializers.
1907         (xcoff_objfile_data_key): Move lower.  Change type.
1908         (XCOFF_DATA): Rewrite.
1909         (xcoff_free_info): Remove.
1910         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1911         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1912         (xcoff_initial_scan): Update.
1913
1914 2019-05-08  Tom Tromey  <tom@tromey.com>
1915
1916         * solib-svr4.c (struct svr4_info): Add initializers and
1917         destructor.
1918         <probes_table>: Now an htab_up.
1919         (solib_svr4_pspace_data): Change type.
1920         (free_probes_table): Simplify.
1921         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1922         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1923         (probes_table_remove_objfile_probes, register_solib_event_probe)
1924         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1925         (_initialize_svr4_solib): Update.
1926
1927 2019-05-08  Tom Tromey  <tom@tromey.com>
1928
1929         * remote.c (remote_pspace_data): Change type.
1930         (remote_pspace_data_cleanup): Remove.
1931         (get_remote_exec_file, set_pspace_remote_exec_file)
1932         (_initialize_remote): Update.
1933
1934 2019-05-08  Tom Tromey  <tom@tromey.com>
1935
1936         * breakpoint.c (breakpoint_objfile_key): Change type.
1937         (get_breakpoint_objfile_data): Update.
1938         (free_breakpoint_objfile_data): Remove.
1939         (_initialize_breakpoint): Update.
1940
1941 2019-05-08  Tom Tromey  <tom@tromey.com>
1942
1943         * linux-tdep.c (struct linux_info): Add initializers.
1944         (linux_inferior_data): Move.  Change type.
1945         (invalidate_linux_cache_inf): Update.
1946         (linux_inferior_data_cleanup): Remove.
1947         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1948
1949 2019-05-08  Tom Tromey  <tom@tromey.com>
1950
1951         * auxv.c (auxv_inferior_data): Move.  Change type.
1952         (auxv_inferior_data_cleanup): Remove.
1953         (invalidate_auxv_cache_inf): Rewrite.
1954         (get_auxv_inferior_data, _initialize_auxv): Update.
1955
1956 2019-05-08  Tom Tromey  <tom@tromey.com>
1957
1958         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1959         (symfile_debug_objfile_data_key): Change type.
1960         (symfile_debug_installed, debug_qf_has_symbols)
1961         (debug_qf_find_last_source_symtab)
1962         (debug_qf_forget_cached_source_info)
1963         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1964         (debug_qf_print_stats, debug_qf_dump)
1965         (debug_qf_expand_symtabs_for_function)
1966         (debug_qf_expand_all_symtabs)
1967         (debug_qf_expand_symtabs_with_fullname)
1968         (debug_qf_map_matching_symbols)
1969         (debug_qf_expand_symtabs_matching)
1970         (debug_qf_find_pc_sect_compunit_symtab)
1971         (debug_qf_map_symbol_filenames)
1972         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1973         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1974         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1975         (debug_sym_read_linetable, debug_sym_relocate): Update.
1976         (symfile_debug_free_objfile): Remove.
1977         (install_symfile_debug_logging, _initialize_symfile_debug):
1978         Update.
1979
1980 2019-05-08  Tom Tromey  <tom@tromey.com>
1981
1982         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1983         allocate_on_obstack.
1984         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1985         (get_dwarf2_per_objfile): Update.
1986         (set_dwarf2_per_objfile): Remove.
1987         (dwarf2_has_info, dwarf2_get_section_info): Update.
1988         (dwarf2_free_objfile): Remove.
1989         (_initialize_dwarf2_read): Update.
1990
1991 2019-05-08  Tom Tromey  <tom@tromey.com>
1992
1993         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1994         initializers.
1995         <unsupported_script_warning_printed,
1996         script_not_found_warning_printed>: Now bool.
1997         (auto_load_pspace_data): Change type.
1998         (~auto_load_pspace_info): Rename from
1999         auto_load_pspace_data_cleanup.
2000         (get_auto_load_pspace_data, init_loaded_scripts_info)
2001         (clear_section_scripts, maybe_print_unsupported_script_warning)
2002         (maybe_print_script_not_found_warning, _initialize_auto_load):
2003         Update.
2004
2005 2019-05-08  Tom Tromey  <tom@tromey.com>
2006
2007         * objfiles.c (objfile_pspace_info): Add destructor and
2008         initializers.
2009         (objfiles_pspace_data): Change type.
2010         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2011         (get_objfile_pspace_data): Update.
2012         (objfiles_bfd_data): Change type.
2013         (get_objfile_bfd_data): Update.
2014         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2015
2016 2019-05-08  Tom Tromey  <tom@tromey.com>
2017
2018         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2019         Change type.
2020         (get_catch_syscall_inferior_data): Update.
2021         (catch_syscall_inferior_data_cleanup): Remove.
2022         (_initialize_break_catch_syscall): Update.
2023
2024 2019-05-08  Tom Tromey  <tom@tromey.com>
2025
2026         * inflow.c (struct terminal_info): Add destructor and
2027         initializers.
2028         (inflow_inferior_data): Change type.
2029         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2030         (get_inflow_inferior_data, inflow_inferior_exit)
2031         (swap_terminal_info, _initialize_inflow): Update.
2032
2033 2019-05-08  Tom Tromey  <tom@tromey.com>
2034
2035         * target-dcache.c (target_dcache_cleanup): Remove.
2036         (target_dcache_aspace_key): Change type.
2037         (target_dcache_init_p, target_dcache_invalidate)
2038         (target_dcache_get, target_dcache_get_or_init)
2039         (_initialize_target_dcache): Update.
2040         * dcache.h (struct dcache_deleter): New.
2041
2042 2019-05-08  Tom Tromey  <tom@tromey.com>
2043
2044         * symtab.c (struct symbol_cache): Add destructor and
2045         initializers.
2046         (symbol_cache_key): Move.  Change type.
2047         (make_symbol_cache, free_symbol_cache): Remove.
2048         (get_symbol_cache): Update.
2049         (symbol_cache_cleanup): Remove.
2050         (ALL_PSPACES, symbol_cache_flush)
2051         (maintenance_print_symbol_cache)
2052         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2053         Update.
2054
2055 2019-05-08  Tom Tromey  <tom@tromey.com>
2056
2057         * symtab.c (struct main_info): Add destructor and initializers.
2058         (main_progspace_key): Move.  Change type.
2059         (get_main_info): Update.
2060         (main_info_cleanup): Remove.
2061         (_initialize_symtab): Update.
2062
2063 2019-05-08  Tom Tromey  <tom@tromey.com>
2064
2065         * registry.h (DECLARE_REGISTRY): Define the _key class.
2066
2067 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2068
2069         * NEWS: Merge two 'New commands' sections.
2070
2071 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2072
2073         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2074         parameter and use Ada language definition instead.
2075         (ada_val_print_ptr): Remove unused language parameter.
2076         (ada_val_print_num): Remove language parameter and use Ada language
2077         definition instead.
2078         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2079         parameter.
2080         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2081         parameter and use Ada language definition instead.
2082         (ada_val_print_1): Update all ada_val_print_xxx calls.
2083         Remove language parameter.
2084         (ada_val_print): Update ada_val_print_1 call.
2085
2086 2019-05-08  Tom Tromey  <tromey@adacore.com>
2087
2088         * remote.c (remote_hw_watchpoint_limit)
2089         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2090         Now static.
2091
2092 2019-05-08  Tom Tromey  <tromey@adacore.com>
2093
2094         * maint.c (_initialize_maint_cmds): Move initialization code to
2095         remote.c.
2096         (watchdog, show_watchdog): Move to remote.c.
2097         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2098         "watchdog" static.
2099         (_initialize_remote): Move initialization code from maint.c.
2100         * defs.h (watchdog): Don't declare.
2101
2102 2019-05-08  Tom Tromey  <tromey@adacore.com>
2103
2104         * tui/tui-interp.c: Include main.h.
2105         * interps.c: Include main.h.
2106         * main.h (interpreter_p): Declare.
2107         * defs.h (interpreter_p): Don't declare.
2108
2109 2019-05-08  Tom Tromey  <tromey@adacore.com>
2110
2111         * dwarf2loc.c: Include dwarf2read.h.
2112         * defs.h (read_unsigned_leb128): Don't declare.
2113         * dwarf2read.h (read_unsigned_leb128): Declare.
2114
2115 2019-05-08  Tom Tromey  <tromey@adacore.com>
2116
2117         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2118         method.
2119
2120 2019-05-08  Tom Tromey  <tromey@adacore.com>
2121
2122         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2123         when no wrap column is set.
2124
2125 2019-05-08  Tom Tromey  <tromey@adacore.com>
2126
2127         * c-lang.c (c_get_string): Handle non-C-style arrays.
2128
2129 2019-05-08  Tom Tromey  <tromey@adacore.com>
2130
2131         * typeprint.c (print_offset_data::update): Print the bit offset,
2132         not the number of bits remaining.
2133
2134 2019-05-08  Tom Tromey  <tromey@adacore.com>
2135
2136         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2137         padding at end of comment.
2138
2139 2019-05-08  Tom Tromey  <tromey@adacore.com>
2140
2141         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2142         Compare main types.
2143
2144 2019-05-06  Tom Tromey  <tom@tromey.com>
2145
2146         * common/scoped_mmap.c: Include common-defs.h.
2147         * common/scoped_mmap.h: Don't include config.h.
2148
2149 2019-05-04  Tom Tromey  <tom@tromey.com>
2150
2151         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2152         (struct aarch64_call_info): Add initializers.
2153         <si>: Now a std::vector.
2154         (pass_on_stack, aarch64_push_dummy_call): Update.
2155
2156 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2157             Tom Tromey  <tom@tromey.com>
2158
2159         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2160         (ppc_threads): Now a std::vector.  Now static.
2161         (hwdebug_find_thread_points_by_tid)
2162         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2163         Update.
2164
2165 2019-05-04  Tom Tromey  <tom@tromey.com>
2166
2167         * arc-tdep.c (arc_tdesc_init): Return bool.
2168
2169 2019-05-04  Tom Tromey  <tom@tromey.com>
2170
2171         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2172         Use gdb_assert_not_reached.
2173
2174 2019-05-04  Tom Tromey  <tom@tromey.com>
2175
2176         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2177         "false".
2178
2179 2019-05-04  Tom Tromey  <tom@tromey.com>
2180
2181         * arc-tdep.c (arc_tdesc_init): Use bool.
2182
2183 2019-05-04  Tom Tromey  <tom@tromey.com>
2184
2185         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2186
2187 2019-05-04  Tom Tromey  <tom@tromey.com>
2188
2189         * cli/cli-cmds.c (valid_command_p): Return bool.
2190
2191 2019-05-04  Tom Tromey  <tom@tromey.com>
2192
2193         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2194         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2195
2196 2019-05-04  Raul Tambre  <raul@tambre.ee>
2197
2198         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2199         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2200         operator for comparison.
2201
2202 2019-05-04  Tom Tromey  <tom@tromey.com>
2203
2204         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2205         (lookup_partial_symbol, print_partial_symbols)
2206         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2207         (psymbol_compare): Update.
2208         (add_psymbol_to_bcache): Clear the entire psymbol.
2209         (maintenance_check_psymtabs): Update.
2210         * psympriv.h (struct partial_symbol): Don't derive from
2211         general_symbol_info.
2212         <obj_section, unrelocated_address, address,
2213         set_unrelocated_address>: Update.
2214         <ginfo>: New member.
2215         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2216         (debug_names::write_psymbols): Update.
2217
2218 2019-05-04  Tom de Vries  <tdevries@suse.de>
2219
2220         * contrib/cc-with-tweaks.sh: Support -n arg.
2221
2222 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2223
2224         * corelow.c (core_target::detach): Ensure frame cache and
2225         register caches are cleared.
2226         inferior.c (exit_inferior_1): Likewise.
2227
2228 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2229             Tom Tromey  <tom@tromey.com>
2230
2231         * dictionary.c (collate_pending_symbols_by_language): Remove
2232         "struct" from foreach.
2233         * symtab.c (lookup_global_symbol_from_objfile)
2234         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2235         foreach.
2236         * ser-tcp.c (net_open): Remove "struct" from foreach.
2237         * objfiles.c (objfile_relocate, objfile_rebase)
2238         (objfile_has_symbols): Remove "struct" from foreach.
2239         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2240         from foreach.
2241         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2242         foreach.
2243         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2244         "struct" from foreach.
2245         * ada-lang.c (create_excep_cond_exprs)
2246         (ada_exception_catchpoint_cond_string): Remove "struct" from
2247         foreach.
2248
2249 2019-05-03  Tom Tromey  <tromey@adacore.com>
2250
2251         * ada-exp.y (convert_char_literal): Check suffix of each
2252         enumerator.
2253
2254 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2255
2256         PR ada/21406:
2257         * ada-exp.y (yywrap): Don't define.
2258         * ada-lex.l (%option): Add noyywrap
2259         (yywrap): Remove.
2260
2261 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2262
2263         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2264         _WIN32_WINNT to the XP level, unless already defined to a higher
2265         level.
2266
2267         * unittests/parse-connection-spec-selftests.c:
2268         * ser-tcp.c:
2269         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2270         override.
2271
2272         * symfile.c (find_separate_debug_file): Remove colon from the
2273         drive spec of DOS/Windows file names of the target, so that the
2274         file name produced from DEBUGDIR and the target's directory will
2275         be valid on DOS/Windows systems.
2276
2277 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2278
2279         * rust-lang.c (val_print_struct): Handle printing structures
2280         containing strings.
2281
2282 2019-05-02  Tom Tromey  <tromey@adacore.com>
2283
2284         * valarith.c (_initialize_valarith): Remove.
2285
2286 2019-05-01  Tom Tromey  <tromey@adacore.com>
2287
2288         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2289         bitfields.
2290
2291 2019-05-01  Tom Tromey  <tromey@adacore.com>
2292
2293         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2294         for big-endian copies.
2295
2296 2019-04-30  Ali Tamur  <tamur@google.com>
2297         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2298         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2299         (read_3_bytes): New function.
2300
2301 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2302
2303         * windows-nat.c (main_thread_id): Delete.
2304         (handle_output_debug_string): Replace main_thread_id by
2305         current_event.dwThreadId.
2306         (fake_create_process): Likewise.
2307         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2308         Do not set main_thread_id.
2309         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2310         current_event.dwThreadId.
2311         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2312
2313 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2314
2315         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2316         Use current_event.dwThreadId instead of main_thread_id.
2317
2318 2019-04-30  Tom Tromey  <tromey@adacore.com>
2319
2320         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2321         (create_excep_cond_exprs): Iterate over program spaces.
2322         (ada_exception_catchpoint_cond_string): Examine all minimal
2323         symbols for exception types.
2324
2325 2019-04-30  Tom Tromey  <tromey@adacore.com>
2326
2327         PR c++/24470:
2328         * dwarf2read.c (process_structure_scope): Handle case where type
2329         has template parameters but no symbol was created.
2330
2331 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2332             Chris January  <chris.january@arm.com>
2333
2334         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2335         qualifier.
2336         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2337
2338 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2339
2340         * f-typeprint.c (f_print_type): Update rules for printing
2341         whitespace.
2342         (f_type_print_varspec_suffix): Likewise.
2343
2344 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2345             Chris January  <chris.january@arm.com>
2346
2347         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2348         function arguments.
2349
2350 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2351
2352         * f-lang.c (build_fortran_types): Change name of void type to
2353         lower case.
2354         * f-typeprint.c (f_type_print_base): Print the name of the void
2355         type, rather than a fixed string.
2356         * f-valprint.c (f_decorations): Use lower case void string.
2357
2358 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2359             Chris January  <chris.january@arm.com>
2360
2361         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2362         types for Fortran.
2363
2364 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2365             Chris January  <chris.january@arm.com>
2366             David Lecomber  <david.lecomber@arm.com>
2367
2368         * f-exp.y (BINOP_INTRINSIC): New token.
2369         (exp): New parser rule handling BINOP_INTRINSIC.
2370         (f77_keywords): Add new builtin procedures.
2371         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2372         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2373         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2374         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2375         (print_unop_subexp_f): New function.
2376         (print_binop_subexp_f): New function.
2377         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2378         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2379         (dump_subexp_body_f): Likewise.
2380         (operator_check_f): Likewise.
2381         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2382         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2383
2384 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2385
2386         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2387         UNOP_KIND.
2388         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2389         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2390         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2391         (operator_length_f): New fuction.
2392         (print_subexp_f): New function.
2393         (op_name_f): New function.
2394         (dump_subexp_body_f): New function.
2395         (operator_check_f): New function.
2396         (exp_descriptor_f): Replace standard expression handling functions
2397         with new functions.
2398         * gdb/fortran-operator.def: New file.
2399         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2400         * gdb/std-operator.def: Remove UNOP_KIND.
2401
2402 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2403
2404         * std-operator.def: Remove unbalanced, stray double quote
2405         character.
2406
2407 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2408             Chris January  <chris.january@arm.com>
2409             Daniel Everett  <daniel.everett@arm.com>
2410             Nick Forrington  <nick.forrington@arm.com>
2411             Richard Bunt  <richard.bunt@arm.com>
2412
2413         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2414         of depth when printing anonymous structs or unions.
2415         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2416         Don't print either the top-level value, or the children if the
2417         max-depth is exceeded.
2418         (ppscm_print_children): When printing the key of a map, allow one
2419         extra level of depth.
2420         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2421         print either the top-level value, or the children if the max-depth
2422         is exceeded.
2423         (print_children): When printing the key of a map, allow one extra
2424         level of depth.
2425         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2426         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2427         (user_print_options): Initialise max_depth field.
2428         (val_print_scalar_or_string_type_p): New function.
2429         (val_print): Check to see if the max depth has been reached.
2430         (val_print_check_max_depth): Define new function.
2431         (show_print_max_depth): New function.
2432         (_initialize_valprint): Add 'print max-depth' option.
2433         * valprint.h (struct value_print_options) <max_depth>: New field.
2434         (val_print_check_max_depth): Declare new function.
2435         * NEWS: Document new feature.
2436
2437 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2438
2439         * ada-lang.c (ada_language_defn): Initialise new field.
2440         * c-lang.c (c_is_string_type_p): New function.
2441         (c_language_defn): Initialise new field.
2442         (cplus_language_defn): Initialise new field.
2443         (asm_language_defn): Initialise new field.
2444         (minimal_language_defn): Initialise new field.
2445         * c-lang.h (c_is_string_type_p): Declare new function.
2446         * d-lang.c (d_language_defn): Initialise new field.
2447         * f-lang.c (f_is_string_type_p): New function.
2448         (f_language_defn): Initialise new field.
2449         * go-lang.c (go_is_string_type_p): New function.
2450         (go_language_defn): Initialise new field.
2451         * language.c (default_is_string_type_p): New function.
2452         (unknown_language_defn): Initialise new field.
2453         (auto_language_defn): Initialise new field.
2454         * language.h (struct language_defn) <la_is_string_type_p>: New
2455         member variable.
2456         (default_is_string_type_p): Declare new function.
2457         * m2-lang.c (m2_language_defn): Initialise new field.
2458         * objc-lang.c (objc_language_defn): Initialise new field.
2459         * opencl-lang.c (opencl_language_defn): Initialise new field.
2460         * p-lang.c (pascal_is_string_type_p): New function.
2461         (pascal_language_defn): Initialise new field.
2462         * rust-lang.c (rust_is_string_type_p): New function.
2463         (rust_language_defn): Initialise new field.
2464
2465 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2466
2467         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2468         New field.
2469         * ada-lang.c (ada_language_defn): Initialise new field.
2470         * c-lang.c (c_language_defn): Likewise.
2471         (cplus_language_defn): Likewise.
2472         (asm_language_defn): Likewise.
2473         (minimal_language_defn): Likewise.
2474         * d-lang.c (d_language_defn): Likewise.
2475         * f-lang.c (f_language_defn): Likewise.
2476         * go-lang.c (go_language_defn): Likewise.
2477         * language.c (unknown_language_defn): Likewise.
2478         (auto_language_defn): Likewise.
2479         * m2-lang.c (m2_language_defn): Likewise.
2480         * objc-lang.c (objc_language_defn): Likewise.
2481         * opencl-lang.c (opencl_language_defn): Likewise.
2482         * p-lang.c (pascal_language_defn): Likewise.
2483         * rust-lang.c (rust_language_defn): Likewise.
2484
2485 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2486
2487         * ada-lang.c (ada_is_character_type): Change return type to bool.
2488         (ada_is_string_type): Likewise.
2489         * ada-lang.h (ada_is_character_type): Update declaration
2490         (ada_is_string_type): Likewise.
2491
2492 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2493
2494         Support style in 'frame|thread apply'
2495
2496         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2497         * record.c (record_start, record_stop): Update callers of
2498         execute_command_to_string with false.
2499         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2500         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2501         methods.
2502         (class string_file): New constructor with term_out parameter.
2503         Override methods term_out and can_emit_style_escape.  New member
2504         term_out.
2505         (class stdio_file): Override can_emit_style_escape.
2506         (class tee_file): Override term_out and can_emit_style_escape.
2507         * utils.h (can_emit_style_escape): Remove.
2508         * utils.c (can_emit_style_escape): Likewise.
2509         Update all callers of can_emit_style_escape (SOMESTREAM) to
2510         SOMESTREAM->can_emit_style_escape.
2511         * source-cache.c (source_cache::get_source_lines): Likewise.
2512         * stack.c (frame_apply_command_count): Call execute_command_to_string
2513         passing the term_out characteristic of the current gdb_stdout.
2514         * thread.c (thr_try_catch_cmd): Likewise.
2515         * top.c (execute_command_to_string): pass term_out parameter
2516         to construct the string_file for the command output.
2517         * ui-file.c (term_cli_styling): New function (most code moved
2518         from utils.c can_emit_style_escape).
2519         (string_file::string_file, string_file::can_emit_style_escape,
2520         stdio_file::can_emit_style_escape, tee_file::term_out,
2521         tee_file::can_emit_style_escape): New functions.
2522
2523 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2524
2525         * NEWS: Mention the new set|show may-call-functions.
2526         * infcall.c (may_call_functions_p): New variable.
2527         (show_may_call_functions_p): New function.
2528         (call_function_by_hand_dummy): Throws an error if not
2529         may-call-functions.
2530         (_initialize_infcall): Call add_setshow_boolean_cmd for
2531         may-call-functions.
2532
2533 2019-04-25  Keith Seitz  <keiths@redhat.com>
2534
2535         PR c++/24367
2536         * cp-support.c (inspect_type): Don't attempt substitutions
2537         of symbol with the same name.
2538
2539 2019-04-25  Tom Tromey  <tromey@adacore.com>
2540
2541         PR gdb/24475:
2542         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2543         static.
2544
2545 2019-04-25  Tom Tromey  <tromey@adacore.com>
2546
2547         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2548         rvalue reference.
2549         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2550         (gdb_xml_parser::parse): Use std::move.
2551         * python/python-internal.h (gdbpy_convert_exception): Take a const
2552         reference.
2553         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2554         std::move.
2555         * python/py-utils.c (gdbpy_convert_exception): Take a const
2556         reference.
2557         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2558         Use std::move.
2559         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2560         Use std::move.
2561         * mi/mi-main.c (mi_print_exception): Take a const reference.
2562         * main.c (handle_command_errors): Take a const reference.
2563         * linespec.c (parse_linespec): Use std::move.
2564         * infcall.c (run_inferior_call): Use std::move.
2565         (call_function_by_hand_dummy): Use std::move.
2566         * exec.c (try_open_exec_file): Use std::move.
2567         * exceptions.h (exception_print, exception_fprintf)
2568         (exception_print_same): Update.
2569         * exceptions.c (print_exception, exception_print)
2570         (exception_fprintf, exception_print_same): Change parameters to
2571         const reference.
2572         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2573         * common/new-op.c: Use std::move.
2574         * common/common-exceptions.h (struct gdb_exception): Add move
2575         constructor.
2576         (struct gdb_exception_error, struct gdb_exception_quit, struct
2577         gdb_quit_bad_alloc): Change constructor to move constructor.
2578         (throw_exception): Change parameter to rvalue reference.
2579         * common/common-exceptions.c (throw_exception): Take rvalue
2580         reference.
2581         * cli/cli-interp.c (safe_execute_command): Use std::move.
2582         * breakpoint.c (insert_bp_location, location_to_sals): Use
2583         std::move.
2584
2585 2019-04-25  Tom Tromey  <tromey@adacore.com>
2586
2587         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2588         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2589         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2590         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2591         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2592         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2593         guile/scm-value.c: Use unpack.
2594         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2595         gdbscm_gdb_exception.
2596         (gdbscm_throw_gdb_exception): Likewise.
2597         (struct gdbscm_gdb_exception): New.
2598         (unpack): New function.
2599         (gdbscm_wrap): Use unpack.
2600
2601 2019-04-25  Tom Tromey  <tromey@adacore.com>
2602
2603         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2604         (gdb_rl_callback_handler): Use std::move.
2605         * common/common-exceptions.h (struct gdb_exception): Add move
2606         assignment operator.
2607         (throw_exception_sjlj): Change "exception" to const reference.
2608         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2609         (throw_exception_sjlj): Change "exception" to const reference.
2610
2611 2019-04-25  Tom Tromey  <tromey@adacore.com>
2612
2613         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2614         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2615         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2616         Update.
2617         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2618         Update.
2619         * mi/mi-interp.c (mi_interp::exec): Update.
2620         * linespec.c (parse_linespec): Update.
2621         * infcall.c (run_inferior_call): Update.
2622         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2623         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2624         (gdbscm_lookup_global_symbol): Update.
2625         * guile/scm-param.c (gdbscm_parameter_value): Update.
2626         * guile/scm-frame.c (gdbscm_frame_read_register)
2627         (gdbscm_frame_read_var): Update.
2628         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2629         * exec.c (try_open_exec_file): Update.
2630         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2631         (gdb_rl_callback_handler): Update.
2632         * common/common-exceptions.h (exception_none): Don't declare.
2633         * common/common-exceptions.c (exception_none): Don't define.
2634         (struct catcher) <exception>: Update.
2635         * cli/cli-interp.c (safe_execute_command): Update.
2636         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2637
2638 2019-04-25  Ali Tamur  <tamur@google.com>
2639
2640         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2641         (read_attribute_value): Likewise.
2642         (dwarf2_read_addr_index): Update comment.
2643         (read_str_index): Add DW_FORM_strx.
2644         (dwarf2_string_attr): Likewise.
2645         (dwarf2_const_value_attr): Likewise.
2646         (dump_die_shallow): Likewise.
2647         (dwarf2_fetch_constant_bytes): Likewise.
2648         (skip_form_bytes): Likewise.
2649         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2650
2651 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2652
2653         PR corefiles/11608
2654         PR corefiles/18187
2655         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2656         OFFSET.  Verify if current mapping contains an ELF header.
2657         (linux_find_memory_regions_full): Adjust call to
2658         dump_mapping_p.
2659
2660 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2661             Kang Li <kanglictf@gmail.com>
2662
2663         PR gdb/21600
2664
2665         * dwarf2-frame.c (read_initial_length): Be consistent about using
2666         unsigned representation of length.
2667         (decode_frame_entry_1): Likewise.  Check for wraparound of
2668         end pointer as well as buffer overflow.
2669
2670 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2671
2672         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2673         "vq".
2674
2675 2019-04-24  Tom Tromey  <tromey@adacore.com>
2676
2677         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2678
2679 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2680
2681         * s12z-tdep.c (s12z_unwind_pc): Delete.
2682         (s12z_unwind_sp): Delete.
2683         (s12z_gdbarch_init): Don't register deleted functions with
2684         gdbarch.
2685
2686 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2687
2688         * rl78-tdep.c (rl78_unwind_sp): Delete.
2689         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2690
2691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2692
2693         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2694         (xstormy16_unwind_pc): Delete.
2695         (xstormy16_dummy_id): Delete.
2696         (xstormy16_gdbarch_init): Don't register deleted functions with
2697         gdbarch.
2698
2699 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2700
2701         * vax-tdep.c (vax_unwind_pc): Delete.
2702         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2703
2704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2705
2706         * v850-tdep.c (v850_unwind_sp): Delete.
2707         (v850_unwind_pc): Delete.
2708         (v850_dummy_id): Delete.
2709         (v850_gdbarch_init): Don't register deleted functions with
2710         gdbarch.
2711
2712 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2713
2714         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2715         (tilegx_unwind_pc): Delete.
2716         (tilegx_unwind_dummy_id): Delete.
2717         (tilegx_gdbarch_init): Don't register deleted functions with
2718         gdbarch.
2719
2720 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2721
2722         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2723         (tic6x_dummy_id): Delete.
2724         (tic6x_gdbarch_init): Don't register deleted functions with
2725         gdbarch.
2726
2727 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2728
2729         * sparc-tdep.c (sparc_unwind_pc): Delete.
2730         (sparc32_gdbarch_init): Don't register deleted function with
2731         gdbarch.
2732
2733 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2734
2735         * sh-tdep.c (sh_unwind_sp): Delete.
2736         (sh_unwind_pc): Delete.
2737         (sh_dummy_id): Delete.
2738         (sh_gdbarch_init): Don't register deleted functions with
2739         gdbarch.
2740
2741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2742
2743         * score-tdep.c (score_unwind_sp): Delete.
2744         (score_unwind_pc): Delete.
2745         (score_dummy_id): Delete.
2746         (score_gdbarch_init): Don't register deleted functions with
2747         gdbarch.
2748
2749 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2750
2751         * rx-tdep.c (rx_unwind_pc): Delete.
2752         (rx_unwind_sp): Delete.
2753         (rx_dummy_id): Delete.
2754         (rx_gdbarch_init): Don't register deleted functions with
2755         gdbarch.  Update comment.
2756
2757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2758
2759         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2760         (rs6000_dummy_id): Delete.
2761         (rs6000_gdbarch_init): Don't register deleted functions with
2762         gdbarch.
2763
2764 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2765
2766         * or1k-tdep.c (or1k_dummy_id): Delete.
2767         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2768
2769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2770
2771         * nios2-tdep.c (nios2_dummy_id): Delete.
2772         (nios2_unwind_sp): Delete.
2773         (nios2_gdbarch_init): Don't register deleted functions with
2774         gdbarch.
2775
2776 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2777
2778         * nds32-tdep.c (nds32_dummy_id): Delete.
2779         (nds32_unwind_pc): Delete.
2780         (nds32_unwind_sp): Delete.
2781         (nds32_gdbarch_init): Don't register deleted functions with
2782         gdbarch.
2783
2784 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2785
2786         * msp430-tdep.c (msp430_unwind_pc): Delete.
2787         (msp430_unwind_sp): Delete.
2788         (msp430_dummy_id): Delete.
2789         (msp430_gdbarch_init): Don't register deleted functions with
2790         gdbarch.
2791
2792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2793
2794         * moxie-tdep.c (moxie_unwind_sp): Delete.
2795         (moxie_unwind_pc): Delete.
2796         (moxie_dummy_id): Delete.
2797         (moxie_gdbarch_init): Don't register deleted functions with
2798         gdbarch.
2799
2800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2801
2802         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2803         (mn10300_unwind_pc): Delete.
2804         (mn10300_unwind_sp): Delete.
2805         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2806         mn10300_unwind_sp.
2807         (mn10300_frame_unwind_init): Don't register deleted functions with
2808         gdbarch.
2809
2810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2811
2812         * mep-tdep.c (mep_unwind_pc): Delete.
2813         (mep_unwind_sp): Delete.
2814         (mep_dummy_id): Delete.
2815         (mep_gdbarch_init): Don't register deleted functions with
2816         gdbarch.
2817
2818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2819
2820         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2821         (m68hc11_unwind_sp): Delete.
2822         (m68hc11_gdbarch_init): Don't register deleted functions with
2823         gdbarch.
2824
2825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2826
2827         * m32r-tdep.c (m32r_unwind_sp): Delete.
2828         (m32r_unwind_pc): Delete.
2829         (m32r_dummy_id): Delete.
2830         (m32r_gdbarch_init): Don't register deleted functions with
2831         gdbarch.
2832
2833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2834
2835         * m32c-tdep.c (m32c_unwind_pc): Delete.
2836         (m32c_unwind_sp): Delete.
2837         (m32c_dummy_id): Delete.
2838         (m32c_gdbarch_init): Don't register deleted functions with
2839         gdbarch.
2840
2841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2842
2843         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2844         (lm32_unwind_pc): Delete.
2845         (lm32_dummy_id): Delete.
2846         (lm32_gdbarch_init): Don't register deleted functions with
2847         gdbarch.
2848
2849 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2850
2851         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2852         (iq2000_unwind_pc): Delete.
2853         (iq2000_dummy_id): Delete.
2854         (iq2000_gdbarch_init): Don't register deleted functions with
2855         gdbarch.
2856
2857 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2858
2859         * nds32-tdep.c (nds32_type_align): Delete.
2860         (nds32_push_dummy_call): Use type_align instead.
2861
2862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2863
2864         * arm-tdep.c (arm_type_align): Only handle vector override case.
2865         (arm_push_dummy_call): Use type_align.
2866         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2867
2868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2869
2870         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2871         case.
2872         (pass_on_stack): Use type_align.
2873         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2874         function.
2875
2876 2019-04-23  Tom Tromey  <tromey@adacore.com>
2877
2878         * dwarf2read.c (line_header::file_name_at): Remove unused
2879         overload.
2880
2881 2019-04-23  Tom de Vries  <tdevries@suse.de>
2882
2883         PR gdb/24438
2884         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2885         invocation.
2886
2887
2888 2019-03-27  Ali Tamur  <tamur@google.com>
2889
2890         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2891         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2892         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2893         (dwarf_expr_context::get_addr_index): Likewise
2894         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2895         (symbol_needs_eval_context::get_addr_index): Likewise
2896         (disassemble_dwarf_expression): Add DW_OP_addrx
2897         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2898         (read_cutu_die_from_dwo): Update comment
2899         (skip_one_die): Add DW_FORM_addrx
2900         (read_attribute_value): Likewise
2901         (var_decode_location): Add DW_OP_addrx
2902         (dwarf2_const_value_attr): Add DW_FORM_addrx
2903         (dump_die_shallow): Likewise
2904         (dwarf2_fetch_constant_bytes): Likewise
2905         (decode_locdesc): Add DW_OP_addrx
2906         (skip_form_bytes): Add DW_FORM_addrx
2907
2908 2019-04-22  Ali Tamur  <tamur@google.com>
2909
2910         * MAINTAINERS (Write After Approval): Add self.
2911
2912 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2913
2914         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2915         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2916         (open_symbol_file_object): Likewise.
2917         (svr4_default_sos): Add info parameter.
2918         (svr4_read_so_list): Likewise.
2919         (svr4_current_sos_direct): Adjust functions calls to pass down
2920         info.
2921         (svr4_current_sos_1): Add info parameter.
2922         (svr4_current_sos): Call get_svr4_info, pass info down to
2923         svr4_current_sos_1.
2924         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2925         get_svr4_info.
2926         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2927         get_svr4_info.
2928         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2929         to get_svr4_info.
2930         (probes_table_remove_objfile_probes): Likewise.
2931         (register_solib_event_probe): Add info parameter.
2932         (solist_update_incremental): Pass info parameter down to
2933         svr4_read_so_list.
2934         (disable_probes_interface): Add info parameter.
2935         (svr4_handle_solib_event): Pass current_program_space to
2936         get_svr4_info.  Adjust disable_probes_interface cleanup.
2937         (svr4_create_probe_breakpoints): Add info parameter, pass it
2938         down to register_solib_event_probe.
2939         (svr4_create_solib_event_breakpoints): Add info parameter,
2940         pass it down to svr4_create_probe_breakpoints.
2941         (enable_break): Pass info down to
2942         svr4_create_solib_event_breakpoints.
2943         (svr4_solib_create_inferior_hook): Pass current_program_space to
2944         get_svr4_info.
2945         (svr4_clear_solib): Likewise.
2946
2947 2019-04-22  Pedro Alves  <palves@redhat.com>
2948
2949         * solib-svr4.c (svr4_free_objfile_observer): New.
2950         (probe_and_action::objfile): New field.
2951         (probes_table_htab_remove_objfile_probes)
2952         (probes_table_remove_objfile_probes): New functions.
2953         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2954         in the new probe_and_action.  Don't store the probe in 'lookup'.
2955         (svr4_create_probe_breakpoints): Pass objfile to
2956         register_solib_event_probe.
2957         (_initialize_svr4_solib): Register a free_objfile observer.
2958
2959 2019-04-19  Tom Tromey  <tom@tromey.com>
2960
2961         * common/queue.h: Remove.
2962
2963 2019-04-19  Tom Tromey  <tom@tromey.com>
2964
2965         * event-loop.c: Don't include "common/queue.h".
2966
2967 2019-04-19  Tom Tromey  <tom@tromey.com>
2968
2969         * remote.c (remote_target): Use delete.
2970         * remote-notif.h: Include <list>, not "common/queue.h".
2971         (notif_client_p): Remove typedef.
2972         (remote_notif_state): Add constructor, destructor, initializer.
2973         <notif_queue>: Now a std::list.
2974         (remote_notif_state_xfree): Don't declare.
2975         * remote-notif.c (remote_notif_process, handle_notification)
2976         (remote_notif_state_allocate): Update.
2977         (~remote_notif_state): Rename from remote_notif_state_xfree.
2978
2979 2019-04-19  Tom Tromey  <tom@tromey.com>
2980
2981         * symfile.c (reread_symbols): Update.
2982         * objfiles.c (objfile_register_static_link)
2983         (objfile_lookup_static_link): Update
2984         (~objfile) Don't delete static_links.
2985         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2986
2987 2019-04-19  Tom Tromey  <tom@tromey.com>
2988
2989         * type-stack.h (struct type_stack) <insert>: Constify string.
2990         * type-stack.c (type_stack::insert): Constify string.
2991         * gdbtypes.h (lookup_template_type): Update.
2992         (address_space_name_to_int): Update.
2993         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2994         const.
2995         (lookup_template_type): Make name const.
2996         * c-exp.y: Update rules.
2997         (lex_one_token, classify_name, classify_inner_name)
2998         (c_print_token): Update.
2999         * p-exp.y: Update rules.
3000         (yylex): Update.
3001         * f-exp.y: Update rules.
3002         (yylex): Update.
3003         * d-exp.y: Update rules.
3004         (lex_one_token, classify_name, classify_inner_name): Update.
3005         * parse.c (write_dollar_variable, copy_name): Return std::string.
3006         * parser-defs.h (copy_name): Change return type.
3007         * m2-exp.y: Update rules.
3008         (yylex): Update.
3009         * go-exp.y (lex_one_token): Update.
3010         Update rules.
3011         (classify_unsafe_function, classify_packaged_name)
3012         (classify_name, yylex): Update.
3013
3014 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3015
3016         * configure.ac: add --enable-source-highlight switch.
3017         * configure: Regenerate.
3018         * top.c (print_gdb_version): plumb --enable-source-highlight
3019         status to "show configuration".
3020
3021 2019-04-19  Tom Tromey  <tromey@adacore.com>
3022
3023         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3024         Check ADA_TYPE_P.
3025         (empty_record, ada_template_to_fixed_record_type_1)
3026         (template_to_static_fixed_type)
3027         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3028         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3029         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3030         macros.
3031
3032 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3033
3034         PR symtab/24423:
3035         * source.c (print_source_lines_base): Advance "iter" when a
3036         control character is seen.
3037
3038 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3039
3040         * inferior.h (struct infcall_suspend_state_deleter):
3041         Catch exception in destructor to avoid crash.
3042
3043 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3044
3045         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3046         close to the add_com "shell".
3047
3048 2019-04-18  Tom Tromey  <tromey@adacore.com>
3049
3050         * process-stratum-target.h (class process_stratum_target)
3051         <stratum>: Add "final".
3052
3053 2019-04-17  Tom Tromey  <tromey@adacore.com>
3054
3055         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3056         against nullptr before use.
3057
3058 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3059
3060         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3061
3062 2019-04-17  Jim Wilson  <jimw@sifive.com>
3063             Andrew Burgess  <andrew.burgess@embecosm.com>
3064
3065         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3066         code read might fail, assume 4-byte breakpoint in that case.
3067
3068 2019-04-15  Leszek Swirski  <leszeks@google.com>
3069
3070         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3071         rather than a hand-rolled POD check when checking for forced MEMORY
3072         classification.
3073
3074 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3075
3076         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3077         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3078         function.
3079         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3080         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3081         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3082         declaration.
3083
3084 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3085
3086         * aarch64-linux-nat.c
3087         (aarch64_linux_nat_target::thread_architecture): Add override.
3088         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3089         each VQ.
3090
3091 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3092
3093         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3094
3095 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3096
3097         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3098         target types of size 96-bits, add some additional comments, and
3099         check that the builtin type we found was the correct size.
3100
3101 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3102
3103         * utils.c (prompt_for_continue): Don't restore the styling at the
3104         end, as applied_style has the wrong value.  This fixes styling in
3105         long lists of file names that are interrupted by the "Continue?"
3106         prompt.
3107
3108 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3109
3110         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3111         * c-lang.c (c_language_defn): Likewise.
3112         (cplus_language_defn): Likewise.
3113         (asm_language_defn): Likewise.
3114         (minimal_language_defn): Likewise.
3115         * d-lang.c (d_language_defn): Likewise.
3116         * f-lang.c (f_language_defn): Likewise.
3117         * go-lang.c (go_language_defn): Likewise.
3118         * language.c (unknown_language_defn): Likewise.
3119         (auto_language_defn): Likewise.
3120         * language.h (struct language_defn): Remove la_magic field.
3121         (LANG_MAGIC): Delete.
3122         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3123         * objc-lang.c (objc_language_defn): Likewise.
3124         * opencl-lang.c (opencl_language_defn): Likewise.
3125         * p-lang.c (pascal_language_defn): Likewise.
3126         * rust-lang.c (rust_language_defn): Likewise.
3127
3128 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3129
3130         * riscv-tdep.c (riscv_type_align): New function.
3131         (riscv_type_alignment): Delete.
3132         (riscv_arg_location): Use 'type_align'.
3133         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3134
3135 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3136
3137         * gdbtypes.c (type_align): A struct with no non-static fields also
3138         has alignment of 1.
3139
3140 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3141
3142         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3143         component to 0.
3144         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3145         member.
3146         (riscv_struct_info::analyse): New implementation using new
3147         analyse_inner member function.
3148         (riscv_struct_info::field_offset): New member function.
3149         (riscv_struct_info::m_offsets): New member variable.
3150         (riscv_struct_info::analyse_inner): New private member function,
3151         takes the old implementation of riscv_struct_info::analyse but
3152         extended to track field offsets.
3153         (riscv_call_arg_struct): Update the struct folding special cases
3154         to handle cases where empty C++ structs, which are non-zero
3155         length, are found.
3156         (riscv_arg_location): Initialise the length of each location, a
3157         non-zero length now indicates the location is in use.
3158         (riscv_push_dummy_call): Allow for the first location having a
3159         non-zero offset when setting up arguments.
3160         (riscv_return_value): Likewise, but for return values.
3161
3162 2019-04-11  Tom Tromey  <tromey@adacore.com>
3163
3164         * utils.c (internal_vproblem): Make "msg" const.
3165
3166 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3167
3168         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3169         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3170         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3171         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3172
3173 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3174
3175         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3176         function.
3177         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3178         of amd64_collect_native_gregset.
3179         (amd64_linux_nat_target::store_registers): Likewise.
3180
3181 2019-04-10  Tom Tromey  <tom@tromey.com>
3182
3183         * symtab.c (lookup_global_symbol_from_objfile)
3184         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3185         * objfiles.h (class separate_debug_iterator): New.
3186         (class separate_debug_range): New.
3187         (struct objfile) <separate_debug_objfiles>: New method.
3188         (objfile_separate_debug_iterate): Don't declare.
3189         * objfiles.c (separate_debug_iterator::operator++): Rename from
3190         objfile_separate_debug_iterate.
3191         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3192         iterator.
3193         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3194         iterator.
3195
3196 2019-04-10  Tom Tromey  <tom@tromey.com>
3197
3198         * symfile.c (reread_symbols): Remove old comment.
3199         * objfiles.c (free_all_objfiles): Fix a typo.
3200
3201 2019-04-10  Tom Tromey  <tom@tromey.com>
3202
3203         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3204         * minsyms.c (lookup_minimal_symbol): Use foreach.
3205         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3206         (lookup_minimal_symbol_solib_trampoline): Likewise.
3207         * symfile.c (reread_symbols): Use foreach.
3208
3209 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3210             Tom Tromey  <tromey@adacore.com>
3211
3212         PR rust/24414:
3213         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3214         (rust_lex_int_test): Change "value" to be LONGEST.
3215         (rust_lex_tests): Add test for long integer literal.
3216
3217 2019-04-09  Tom Tromey  <tromey@adacore.com>
3218
3219         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3220         to bool.
3221         (extended_remote_target::attach): Update.
3222         (remote_target::remote_notice_new_inferior): Update.
3223         (remote_target::add_current_inferior_and_thread): Update.
3224         * inferior.c (exit_inferior_1): Use "false".
3225         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3226
3227 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3228
3229         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3230         the "start" command.
3231
3232 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3233
3234         * python/py-inferior.c (infpy_thread_from_thread_handle):
3235         Adjust comments to reflect renaming of thread_from_thread_handle
3236         to thread_from_handle.  Adjust keywords.  Fix type error message.
3237         (inferior_object_methods): Add thread_from_handle.  Retain
3238         thread_from_thread_handle, but mark it as deprecated.
3239
3240 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3241
3242         * gdbthread.h (find_thread_by_handle): Revise declaration.
3243         * thread.c (find_thread_by_handle): Likewise.  Adjust
3244         implementation too.
3245         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3246         support for buffer objects as handles.
3247
3248 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3249
3250         * python/py-infthread.c (thpy_thread_handle): New function.
3251         (thread_object_methods): Register thpy_thread_handle.
3252
3253 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3254
3255         * gdbthread.h (thread_to_thread_handle): Declare.
3256         * thread.c (gdbtypes.h): Include.
3257         (thread_to_thread_handle): New function.
3258
3259         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3260         (target_thread_info_to_thread_handle): Declare.
3261         * target.c (target_thread_info_to_thread_handle): New function.
3262         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3263         * target-delegates.c: Regenerate.
3264
3265         * linux-thread-db.c (class thread_db_target): Add method
3266         thread_info_to_thread_handle.
3267         (thread_db_target::thread_info_to_thread_handle): Define.
3268         * remote.c (class remote_target): Add new method
3269         thread_info_to_thread_handle.
3270         (remote_target::thread_info_to_thread_handle): Define.
3271
3272 2019-04-08  Pedro Alves  <palves@redhat.com>
3273
3274         * common/common-exceptions.c (throw_exception): Don't create
3275         named object to throw; throw directly.
3276         (throw_it): Likewise.  Don't initialize gdb_exception::message
3277         here, with new; pass FMT and AP to the ctor instead.
3278         * common/common-exceptions.h: Include <string>.
3279         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3280         const char *, va_list)): New ctor.  Use std::make_shared.
3281         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3282         errors)): Delete.
3283         (gdb_exception_error::gdb_exception_error(enum errors, const char
3284         *, va_list)): New.
3285         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3286         Add assertion.
3287         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3288         errors)): Delete.
3289         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3290         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3291         Add assertion.
3292
3293 2019-04-08  Tom Tromey  <tom@tromey.com>
3294
3295         * valops.c (value_rtti_indirect_type): Replace throw_exception
3296         with throw.
3297         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3298         with throw.
3299         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3300         throw.
3301         * target.c (target_translate_tls_address): Replace throw_exception
3302         with throw.
3303         * stack.c (frame_apply_command_count): Replace throw_exception
3304         with throw.
3305         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3306         throw.
3307         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3308         with throw.
3309         * rs6000-tdep.c (rs6000_frame_cache)
3310         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3311         * remote.c: Replace throw_exception with throw.
3312         * record-full.c (record_full_message, record_full_wait_1)
3313         (record_full_restore): Replace throw_exception with throw.
3314         * record-btrace.c:
3315         (get_thread_current_frame_id, record_btrace_start_replaying)
3316         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3317         (cmd_record_btrace_start): Replace throw_exception with throw.
3318         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3319         throw.
3320         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3321         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3322         * linespec.c:
3323         (find_linespec_symbols): Replace throw_exception with throw.
3324         * infrun.c (displaced_step_prepare, resume): Replace
3325         throw_exception with throw.
3326         * infcmd.c (post_create_inferior): Replace throw_exception with
3327         throw.
3328         * inf-loop.c (inferior_event_handler): Replace throw_exception
3329         with throw.
3330         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3331         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3332         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3333         (get_prev_frame_always, get_frame_pc_if_available)
3334         (get_frame_address_in_block_if_available, get_frame_language):
3335         Replace throw_exception with throw.
3336         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3337         throw_exception with throw.
3338         * eval.c (fetch_subexp_value, evaluate_var_value)
3339         (evaluate_funcall, evaluate_subexp_standard): Replace
3340         throw_exception with throw.
3341         * dwarf2loc.c (call_site_find_chain)
3342         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3343         Replace throw_exception with throw.
3344         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3345         with throw.
3346         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3347         throw.
3348         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3349         * completer.c (complete_line_internal): Replace throw_exception
3350         with throw.
3351         * compile/compile-object-run.c (compile_object_run): Replace
3352         throw_exception with throw.
3353         * cli/cli-script.c (process_next_line): Replace throw_exception
3354         with throw.
3355         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3356         (btrace_enable, btrace_maint_update_pt_packets): Replace
3357         throw_exception with throw.
3358         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3359         throw_exception with throw.
3360         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3361         throw_exception with throw.
3362         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3363         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3364         * aarch64-tdep.c (aarch64_make_prologue_cache)
3365         (aarch64_make_stub_cache): Replace throw_exception with throw.
3366
3367 2019-04-08  Tom Tromey  <tom@tromey.com>
3368
3369         * common/common-exceptions.c (throw_exception): Rename from
3370         throw_exception_cxx.  Remove old copy.  Make argument const.
3371         (throw_it): Create and throw exception objects directly.
3372         * common/common-exceptions.h (throw_exception): Make argument
3373         const.
3374         (struct gdb_exception_error): Add constructor.
3375         (struct gdb_exception_quit): Add constructor.
3376
3377 2019-04-08  Tom Tromey  <tom@tromey.com>
3378
3379         * common/common-exceptions.h (exception_rethrow): Don't declare.
3380         (TRY_SJLJ): Update comment.
3381         (TRY, CATCH, END_CATCH): Remove.
3382         * common/common-exceptions.c (exception_rethrow): Remove.
3383
3384 2019-04-08  Tom Tromey  <tom@tromey.com>
3385
3386         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3387         Remove.
3388         (gdb_exception_error): Rename from
3389         gdb_exception_RETURN_MASK_ERROR.
3390         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3391         (gdb_quit_bad_alloc): Update.
3392         * aarch64-tdep.c: Update.
3393         * ada-lang.c: Update.
3394         * ada-typeprint.c: Update.
3395         * ada-valprint.c: Update.
3396         * amd64-tdep.c: Update.
3397         * arch-utils.c: Update.
3398         * break-catch-throw.c: Update.
3399         * breakpoint.c: Update.
3400         * btrace.c: Update.
3401         * c-varobj.c: Update.
3402         * cli/cli-cmds.c: Update.
3403         * cli/cli-interp.c: Update.
3404         * cli/cli-script.c: Update.
3405         * common/common-exceptions.c: Update.
3406         * common/new-op.c: Update.
3407         * common/selftest.c: Update.
3408         * compile/compile-c-symbols.c: Update.
3409         * compile/compile-cplus-symbols.c: Update.
3410         * compile/compile-object-load.c: Update.
3411         * compile/compile-object-run.c: Update.
3412         * completer.c: Update.
3413         * corelow.c: Update.
3414         * cp-abi.c: Update.
3415         * cp-support.c: Update.
3416         * cp-valprint.c: Update.
3417         * darwin-nat.c: Update.
3418         * disasm-selftests.c: Update.
3419         * dtrace-probe.c: Update.
3420         * dwarf-index-cache.c: Update.
3421         * dwarf-index-write.c: Update.
3422         * dwarf2-frame-tailcall.c: Update.
3423         * dwarf2-frame.c: Update.
3424         * dwarf2loc.c: Update.
3425         * dwarf2read.c: Update.
3426         * eval.c: Update.
3427         * event-loop.c: Update.
3428         * event-top.c: Update.
3429         * exec.c: Update.
3430         * f-valprint.c: Update.
3431         * fbsd-tdep.c: Update.
3432         * frame-unwind.c: Update.
3433         * frame.c: Update.
3434         * gdbtypes.c: Update.
3435         * gnu-v3-abi.c: Update.
3436         * guile/guile-internal.h: Update.
3437         * guile/scm-block.c: Update.
3438         * guile/scm-breakpoint.c: Update.
3439         * guile/scm-cmd.c: Update.
3440         * guile/scm-disasm.c: Update.
3441         * guile/scm-frame.c: Update.
3442         * guile/scm-lazy-string.c: Update.
3443         * guile/scm-math.c: Update.
3444         * guile/scm-param.c: Update.
3445         * guile/scm-ports.c: Update.
3446         * guile/scm-pretty-print.c: Update.
3447         * guile/scm-symbol.c: Update.
3448         * guile/scm-symtab.c: Update.
3449         * guile/scm-type.c: Update.
3450         * guile/scm-value.c: Update.
3451         * i386-linux-tdep.c: Update.
3452         * i386-tdep.c: Update.
3453         * inf-loop.c: Update.
3454         * infcall.c: Update.
3455         * infcmd.c: Update.
3456         * infrun.c: Update.
3457         * jit.c: Update.
3458         * language.c: Update.
3459         * linespec.c: Update.
3460         * linux-fork.c: Update.
3461         * linux-nat.c: Update.
3462         * linux-tdep.c: Update.
3463         * linux-thread-db.c: Update.
3464         * main.c: Update.
3465         * mi/mi-cmd-break.c: Update.
3466         * mi/mi-cmd-stack.c: Update.
3467         * mi/mi-interp.c: Update.
3468         * mi/mi-main.c: Update.
3469         * objc-lang.c: Update.
3470         * p-valprint.c: Update.
3471         * parse.c: Update.
3472         * ppc-linux-tdep.c: Update.
3473         * printcmd.c: Update.
3474         * python/py-arch.c: Update.
3475         * python/py-breakpoint.c: Update.
3476         * python/py-cmd.c: Update.
3477         * python/py-finishbreakpoint.c: Update.
3478         * python/py-frame.c: Update.
3479         * python/py-framefilter.c: Update.
3480         * python/py-gdb-readline.c: Update.
3481         * python/py-inferior.c: Update.
3482         * python/py-infthread.c: Update.
3483         * python/py-lazy-string.c: Update.
3484         * python/py-linetable.c: Update.
3485         * python/py-objfile.c: Update.
3486         * python/py-param.c: Update.
3487         * python/py-prettyprint.c: Update.
3488         * python/py-progspace.c: Update.
3489         * python/py-record-btrace.c: Update.
3490         * python/py-record.c: Update.
3491         * python/py-symbol.c: Update.
3492         * python/py-type.c: Update.
3493         * python/py-unwind.c: Update.
3494         * python/py-utils.c: Update.
3495         * python/py-value.c: Update.
3496         * python/python.c: Update.
3497         * record-btrace.c: Update.
3498         * record-full.c: Update.
3499         * remote-fileio.c: Update.
3500         * remote.c: Update.
3501         * riscv-tdep.c: Update.
3502         * rs6000-aix-tdep.c: Update.
3503         * rs6000-tdep.c: Update.
3504         * rust-exp.y: Update.
3505         * rust-lang.c: Update.
3506         * s390-tdep.c: Update.
3507         * selftest-arch.c: Update.
3508         * solib-dsbt.c: Update.
3509         * solib-frv.c: Update.
3510         * solib-spu.c: Update.
3511         * solib-svr4.c: Update.
3512         * solib.c: Update.
3513         * sparc64-linux-tdep.c: Update.
3514         * stack.c: Update.
3515         * symfile-mem.c: Update.
3516         * symmisc.c: Update.
3517         * target.c: Update.
3518         * thread.c: Update.
3519         * top.c: Update.
3520         * tracefile-tfile.c: Update.
3521         * tui/tui.c: Update.
3522         * typeprint.c: Update.
3523         * unittests/cli-utils-selftests.c: Update.
3524         * unittests/parse-connection-spec-selftests.c: Update.
3525         * valops.c: Update.
3526         * valprint.c: Update.
3527         * value.c: Update.
3528         * varobj.c: Update.
3529         * windows-nat.c: Update.
3530         * x86-linux-nat.c: Update.
3531         * xml-support.c: Update.
3532
3533 2019-04-08  Tom Tromey  <tom@tromey.com>
3534
3535         * xml-support.c: Use C++ exception handling.
3536         * x86-linux-nat.c: Use C++ exception handling.
3537         * windows-nat.c: Use C++ exception handling.
3538         * varobj.c: Use C++ exception handling.
3539         * value.c: Use C++ exception handling.
3540         * valprint.c: Use C++ exception handling.
3541         * valops.c: Use C++ exception handling.
3542         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3543         handling.
3544         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3545         * typeprint.c: Use C++ exception handling.
3546         * tui/tui.c: Use C++ exception handling.
3547         * tracefile-tfile.c: Use C++ exception handling.
3548         * top.c: Use C++ exception handling.
3549         * thread.c: Use C++ exception handling.
3550         * target.c: Use C++ exception handling.
3551         * symmisc.c: Use C++ exception handling.
3552         * symfile-mem.c: Use C++ exception handling.
3553         * stack.c: Use C++ exception handling.
3554         * sparc64-linux-tdep.c: Use C++ exception handling.
3555         * solib.c: Use C++ exception handling.
3556         * solib-svr4.c: Use C++ exception handling.
3557         * solib-spu.c: Use C++ exception handling.
3558         * solib-frv.c: Use C++ exception handling.
3559         * solib-dsbt.c: Use C++ exception handling.
3560         * selftest-arch.c: Use C++ exception handling.
3561         * s390-tdep.c: Use C++ exception handling.
3562         * rust-lang.c: Use C++ exception handling.
3563         * rust-exp.y: Use C++ exception handling.
3564         * rs6000-tdep.c: Use C++ exception handling.
3565         * rs6000-aix-tdep.c: Use C++ exception handling.
3566         * riscv-tdep.c: Use C++ exception handling.
3567         * remote.c: Use C++ exception handling.
3568         * remote-fileio.c: Use C++ exception handling.
3569         * record-full.c: Use C++ exception handling.
3570         * record-btrace.c: Use C++ exception handling.
3571         * python/python.c: Use C++ exception handling.
3572         * python/py-value.c: Use C++ exception handling.
3573         * python/py-utils.c: Use C++ exception handling.
3574         * python/py-unwind.c: Use C++ exception handling.
3575         * python/py-type.c: Use C++ exception handling.
3576         * python/py-symbol.c: Use C++ exception handling.
3577         * python/py-record.c: Use C++ exception handling.
3578         * python/py-record-btrace.c: Use C++ exception handling.
3579         * python/py-progspace.c: Use C++ exception handling.
3580         * python/py-prettyprint.c: Use C++ exception handling.
3581         * python/py-param.c: Use C++ exception handling.
3582         * python/py-objfile.c: Use C++ exception handling.
3583         * python/py-linetable.c: Use C++ exception handling.
3584         * python/py-lazy-string.c: Use C++ exception handling.
3585         * python/py-infthread.c: Use C++ exception handling.
3586         * python/py-inferior.c: Use C++ exception handling.
3587         * python/py-gdb-readline.c: Use C++ exception handling.
3588         * python/py-framefilter.c: Use C++ exception handling.
3589         * python/py-frame.c: Use C++ exception handling.
3590         * python/py-finishbreakpoint.c: Use C++ exception handling.
3591         * python/py-cmd.c: Use C++ exception handling.
3592         * python/py-breakpoint.c: Use C++ exception handling.
3593         * python/py-arch.c: Use C++ exception handling.
3594         * printcmd.c: Use C++ exception handling.
3595         * ppc-linux-tdep.c: Use C++ exception handling.
3596         * parse.c: Use C++ exception handling.
3597         * p-valprint.c: Use C++ exception handling.
3598         * objc-lang.c: Use C++ exception handling.
3599         * mi/mi-main.c: Use C++ exception handling.
3600         * mi/mi-interp.c: Use C++ exception handling.
3601         * mi/mi-cmd-stack.c: Use C++ exception handling.
3602         * mi/mi-cmd-break.c: Use C++ exception handling.
3603         * main.c: Use C++ exception handling.
3604         * linux-thread-db.c: Use C++ exception handling.
3605         * linux-tdep.c: Use C++ exception handling.
3606         * linux-nat.c: Use C++ exception handling.
3607         * linux-fork.c: Use C++ exception handling.
3608         * linespec.c: Use C++ exception handling.
3609         * language.c: Use C++ exception handling.
3610         * jit.c: Use C++ exception handling.
3611         * infrun.c: Use C++ exception handling.
3612         * infcmd.c: Use C++ exception handling.
3613         * infcall.c: Use C++ exception handling.
3614         * inf-loop.c: Use C++ exception handling.
3615         * i386-tdep.c: Use C++ exception handling.
3616         * i386-linux-tdep.c: Use C++ exception handling.
3617         * guile/scm-value.c: Use C++ exception handling.
3618         * guile/scm-type.c: Use C++ exception handling.
3619         * guile/scm-symtab.c: Use C++ exception handling.
3620         * guile/scm-symbol.c: Use C++ exception handling.
3621         * guile/scm-pretty-print.c: Use C++ exception handling.
3622         * guile/scm-ports.c: Use C++ exception handling.
3623         * guile/scm-param.c: Use C++ exception handling.
3624         * guile/scm-math.c: Use C++ exception handling.
3625         * guile/scm-lazy-string.c: Use C++ exception handling.
3626         * guile/scm-frame.c: Use C++ exception handling.
3627         * guile/scm-disasm.c: Use C++ exception handling.
3628         * guile/scm-cmd.c: Use C++ exception handling.
3629         * guile/scm-breakpoint.c: Use C++ exception handling.
3630         * guile/scm-block.c: Use C++ exception handling.
3631         * guile/guile-internal.h: Use C++ exception handling.
3632         * gnu-v3-abi.c: Use C++ exception handling.
3633         * gdbtypes.c: Use C++ exception handling.
3634         * frame.c: Use C++ exception handling.
3635         * frame-unwind.c: Use C++ exception handling.
3636         * fbsd-tdep.c: Use C++ exception handling.
3637         * f-valprint.c: Use C++ exception handling.
3638         * exec.c: Use C++ exception handling.
3639         * event-top.c: Use C++ exception handling.
3640         * event-loop.c: Use C++ exception handling.
3641         * eval.c: Use C++ exception handling.
3642         * dwarf2read.c: Use C++ exception handling.
3643         * dwarf2loc.c: Use C++ exception handling.
3644         * dwarf2-frame.c: Use C++ exception handling.
3645         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3646         * dwarf-index-write.c: Use C++ exception handling.
3647         * dwarf-index-cache.c: Use C++ exception handling.
3648         * dtrace-probe.c: Use C++ exception handling.
3649         * disasm-selftests.c: Use C++ exception handling.
3650         * darwin-nat.c: Use C++ exception handling.
3651         * cp-valprint.c: Use C++ exception handling.
3652         * cp-support.c: Use C++ exception handling.
3653         * cp-abi.c: Use C++ exception handling.
3654         * corelow.c: Use C++ exception handling.
3655         * completer.c: Use C++ exception handling.
3656         * compile/compile-object-run.c: Use C++ exception handling.
3657         * compile/compile-object-load.c: Use C++ exception handling.
3658         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3659         * compile/compile-c-symbols.c: Use C++ exception handling.
3660         * common/selftest.c: Use C++ exception handling.
3661         * common/new-op.c: Use C++ exception handling.
3662         * cli/cli-script.c: Use C++ exception handling.
3663         * cli/cli-interp.c: Use C++ exception handling.
3664         * cli/cli-cmds.c: Use C++ exception handling.
3665         * c-varobj.c: Use C++ exception handling.
3666         * btrace.c: Use C++ exception handling.
3667         * breakpoint.c: Use C++ exception handling.
3668         * break-catch-throw.c: Use C++ exception handling.
3669         * arch-utils.c: Use C++ exception handling.
3670         * amd64-tdep.c: Use C++ exception handling.
3671         * ada-valprint.c: Use C++ exception handling.
3672         * ada-typeprint.c: Use C++ exception handling.
3673         * ada-lang.c: Use C++ exception handling.
3674         * aarch64-tdep.c: Use C++ exception handling.
3675
3676 2019-04-08  Tom Tromey  <tom@tromey.com>
3677
3678         * xml-support.c (gdb_xml_parser::parse): Update.
3679         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3680         * value.c (show_convenience): Update.
3681         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3682         (test_parse_flags_qcs): Update.
3683         * thread.c (thr_try_catch_cmd): Update.
3684         * target.c (target_translate_tls_address): Update.
3685         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3686         (info_frame_command_core, frame_apply_command_count): Update.
3687         * rust-exp.y (rust_lex_exception_test): Update.
3688         * riscv-tdep.c (riscv_print_one_register_info): Update.
3689         * remote.c (remote_target::enable_btrace): Update.
3690         * record-btrace.c (record_btrace_enable_warn): Update.
3691         * python/py-utils.c (gdbpy_convert_exception): Update.
3692         * printcmd.c (do_one_display, print_variable_and_value): Update.
3693         * mi/mi-main.c (mi_print_exception): Update.
3694         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3695         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3696         * linux-nat.c (linux_nat_target::attach): Update.
3697         * linux-fork.c (class scoped_switch_fork_info): Update.
3698         * infrun.c (displaced_step_prepare): Update.
3699         * infcall.c (call_function_by_hand_dummy): Update.
3700         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3701         * gnu-v3-abi.c (print_one_vtable): Update.
3702         * frame.c (get_prev_frame_always): Update.
3703         * f-valprint.c (info_common_command_for_block): Update.
3704         * exec.c (try_open_exec_file): Update.
3705         * exceptions.c (print_exception, exception_print)
3706         (exception_fprintf, exception_print_same): Update.
3707         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3708         * dwarf-index-cache.c (index_cache::store)
3709         (index_cache::lookup_gdb_index): Update.
3710         * darwin-nat.c (maybe_cache_shell): Update.
3711         * cp-valprint.c (cp_print_value_fields): Update.
3712         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3713         (gcc_cplus_symbol_address): Update.
3714         * compile/compile-c-symbols.c (gcc_convert_symbol)
3715         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3716         * common/selftest.c: Update.
3717         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3718         a std::string.
3719         (exception_try_scope_entry, exception_try_scope_exit): Don't
3720         declare.
3721         (struct exception_try_scope): Remove.
3722         (TRY): Don't use exception_try_scope.
3723         (struct gdb_exception): Add constructor, operator=.
3724         <what>: New method.
3725         (struct gdb_exception_RETURN_MASK_ALL)
3726         (struct gdb_exception_RETURN_MASK_ERROR)
3727         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3728         (struct gdb_quit_bad_alloc): Update.
3729         * common/common-exceptions.c (exception_none): Change
3730         initializer.
3731         (struct catcher) <state, exception>: Initialize inline.
3732         <prev>: Remove member.
3733         (current_catcher): Remove.
3734         (catchers): New global.
3735         (exceptions_state_mc_init): Simplify.
3736         (catcher_pop): Remove.
3737         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3738         (try_scope_depth, exception_try_scope_entry)
3739         (exception_try_scope_exit): Remove.
3740         (throw_exception_sjlj): Update.
3741         (exception_messages, exception_messages_size): Remove.
3742         (throw_it): Simplify.
3743         (gdb_exception_sliced_copy): Remove.
3744         (throw_exception_cxx): Update.
3745         * cli/cli-script.c (script_from_file): Update.
3746         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3747         Update.
3748         * ada-valprint.c (ada_val_print): Update.
3749         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3750         (create_excep_cond_exprs): Update.
3751
3752 2019-04-08  Tom Tromey  <tom@tromey.com>
3753
3754         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3755         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3756         (TRY, CATCH, END_CATCH): Remove some definitions.
3757         * common/common-exceptions.c: Don't use GDB_XCPT.
3758         (catcher_list_size): Remove.
3759         (throw_exception, throw_it): Simplify.
3760
3761 2019-04-05  Tom Tromey  <tom@tromey.com>
3762
3763         Revert the header-sorting patch.
3764         * ft32-tdep.c: Revert.
3765         * frv-tdep.c: Revert.
3766         * frv-linux-tdep.c: Revert.
3767         * frame.c: Revert.
3768         * frame-unwind.c: Revert.
3769         * frame-base.c: Revert.
3770         * fork-child.c: Revert.
3771         * findvar.c: Revert.
3772         * findcmd.c: Revert.
3773         * filesystem.c: Revert.
3774         * filename-seen-cache.h: Revert.
3775         * filename-seen-cache.c: Revert.
3776         * fbsd-tdep.c: Revert.
3777         * fbsd-nat.h: Revert.
3778         * fbsd-nat.c: Revert.
3779         * f-valprint.c: Revert.
3780         * f-typeprint.c: Revert.
3781         * f-lang.c: Revert.
3782         * extension.h: Revert.
3783         * extension.c: Revert.
3784         * extension-priv.h: Revert.
3785         * expprint.c: Revert.
3786         * exec.h: Revert.
3787         * exec.c: Revert.
3788         * exceptions.c: Revert.
3789         * event-top.c: Revert.
3790         * event-loop.c: Revert.
3791         * eval.c: Revert.
3792         * elfread.c: Revert.
3793         * dwarf2read.h: Revert.
3794         * dwarf2read.c: Revert.
3795         * dwarf2loc.c: Revert.
3796         * dwarf2expr.h: Revert.
3797         * dwarf2expr.c: Revert.
3798         * dwarf2-frame.c: Revert.
3799         * dwarf2-frame-tailcall.c: Revert.
3800         * dwarf-index-write.h: Revert.
3801         * dwarf-index-write.c: Revert.
3802         * dwarf-index-common.c: Revert.
3803         * dwarf-index-cache.h: Revert.
3804         * dwarf-index-cache.c: Revert.
3805         * dummy-frame.c: Revert.
3806         * dtrace-probe.c: Revert.
3807         * disasm.h: Revert.
3808         * disasm.c: Revert.
3809         * disasm-selftests.c: Revert.
3810         * dictionary.c: Revert.
3811         * dicos-tdep.c: Revert.
3812         * demangle.c: Revert.
3813         * dcache.h: Revert.
3814         * dcache.c: Revert.
3815         * darwin-nat.h: Revert.
3816         * darwin-nat.c: Revert.
3817         * darwin-nat-info.c: Revert.
3818         * d-valprint.c: Revert.
3819         * d-namespace.c: Revert.
3820         * d-lang.c: Revert.
3821         * ctf.c: Revert.
3822         * csky-tdep.c: Revert.
3823         * csky-linux-tdep.c: Revert.
3824         * cris-tdep.c: Revert.
3825         * cris-linux-tdep.c: Revert.
3826         * cp-valprint.c: Revert.
3827         * cp-support.c: Revert.
3828         * cp-namespace.c: Revert.
3829         * cp-abi.c: Revert.
3830         * corelow.c: Revert.
3831         * corefile.c: Revert.
3832         * continuations.c: Revert.
3833         * completer.h: Revert.
3834         * completer.c: Revert.
3835         * complaints.c: Revert.
3836         * coffread.c: Revert.
3837         * coff-pe-read.c: Revert.
3838         * cli-out.h: Revert.
3839         * cli-out.c: Revert.
3840         * charset.c: Revert.
3841         * c-varobj.c: Revert.
3842         * c-valprint.c: Revert.
3843         * c-typeprint.c: Revert.
3844         * c-lang.c: Revert.
3845         * buildsym.c: Revert.
3846         * buildsym-legacy.c: Revert.
3847         * build-id.h: Revert.
3848         * build-id.c: Revert.
3849         * btrace.c: Revert.
3850         * bsd-uthread.c: Revert.
3851         * breakpoint.h: Revert.
3852         * breakpoint.c: Revert.
3853         * break-catch-throw.c: Revert.
3854         * break-catch-syscall.c: Revert.
3855         * break-catch-sig.c: Revert.
3856         * blockframe.c: Revert.
3857         * block.c: Revert.
3858         * bfin-tdep.c: Revert.
3859         * bfin-linux-tdep.c: Revert.
3860         * bfd-target.c: Revert.
3861         * bcache.c: Revert.
3862         * ax-general.c: Revert.
3863         * ax-gdb.h: Revert.
3864         * ax-gdb.c: Revert.
3865         * avr-tdep.c: Revert.
3866         * auxv.c: Revert.
3867         * auto-load.c: Revert.
3868         * arm-wince-tdep.c: Revert.
3869         * arm-tdep.c: Revert.
3870         * arm-symbian-tdep.c: Revert.
3871         * arm-pikeos-tdep.c: Revert.
3872         * arm-obsd-tdep.c: Revert.
3873         * arm-nbsd-tdep.c: Revert.
3874         * arm-nbsd-nat.c: Revert.
3875         * arm-linux-tdep.c: Revert.
3876         * arm-linux-nat.c: Revert.
3877         * arm-fbsd-tdep.c: Revert.
3878         * arm-fbsd-nat.c: Revert.
3879         * arm-bsd-tdep.c: Revert.
3880         * arch-utils.c: Revert.
3881         * arc-tdep.c: Revert.
3882         * arc-newlib-tdep.c: Revert.
3883         * annotate.h: Revert.
3884         * annotate.c: Revert.
3885         * amd64-windows-tdep.c: Revert.
3886         * amd64-windows-nat.c: Revert.
3887         * amd64-tdep.c: Revert.
3888         * amd64-sol2-tdep.c: Revert.
3889         * amd64-obsd-tdep.c: Revert.
3890         * amd64-obsd-nat.c: Revert.
3891         * amd64-nbsd-tdep.c: Revert.
3892         * amd64-nbsd-nat.c: Revert.
3893         * amd64-nat.c: Revert.
3894         * amd64-linux-tdep.c: Revert.
3895         * amd64-linux-nat.c: Revert.
3896         * amd64-fbsd-tdep.c: Revert.
3897         * amd64-fbsd-nat.c: Revert.
3898         * amd64-dicos-tdep.c: Revert.
3899         * amd64-darwin-tdep.c: Revert.
3900         * amd64-bsd-nat.c: Revert.
3901         * alpha-tdep.c: Revert.
3902         * alpha-obsd-tdep.c: Revert.
3903         * alpha-nbsd-tdep.c: Revert.
3904         * alpha-mdebug-tdep.c: Revert.
3905         * alpha-linux-tdep.c: Revert.
3906         * alpha-linux-nat.c: Revert.
3907         * alpha-bsd-tdep.c: Revert.
3908         * alpha-bsd-nat.c: Revert.
3909         * aix-thread.c: Revert.
3910         * agent.c: Revert.
3911         * addrmap.c: Revert.
3912         * ada-varobj.c: Revert.
3913         * ada-valprint.c: Revert.
3914         * ada-typeprint.c: Revert.
3915         * ada-tasks.c: Revert.
3916         * ada-lang.c: Revert.
3917         * aarch64-tdep.c: Revert.
3918         * aarch64-ravenscar-thread.c: Revert.
3919         * aarch64-newlib-tdep.c: Revert.
3920         * aarch64-linux-tdep.c: Revert.
3921         * aarch64-linux-nat.c: Revert.
3922         * aarch64-fbsd-tdep.c: Revert.
3923         * aarch64-fbsd-nat.c: Revert.
3924         * aarch32-linux-nat.c: Revert.
3925
3926 2019-04-05  Tom Tromey  <tom@tromey.com>
3927
3928         * ft32-tdep.c: Sort headers.
3929         * frv-tdep.c: Sort headers.
3930         * frv-linux-tdep.c: Sort headers.
3931         * frame.c: Sort headers.
3932         * frame-unwind.c: Sort headers.
3933         * frame-base.c: Sort headers.
3934         * fork-child.c: Sort headers.
3935         * findvar.c: Sort headers.
3936         * findcmd.c: Sort headers.
3937         * filesystem.c: Sort headers.
3938         * filename-seen-cache.h: Sort headers.
3939         * filename-seen-cache.c: Sort headers.
3940         * fbsd-tdep.c: Sort headers.
3941         * fbsd-nat.h: Sort headers.
3942         * fbsd-nat.c: Sort headers.
3943         * f-valprint.c: Sort headers.
3944         * f-typeprint.c: Sort headers.
3945         * f-lang.c: Sort headers.
3946         * extension.h: Sort headers.
3947         * extension.c: Sort headers.
3948         * extension-priv.h: Sort headers.
3949         * expprint.c: Sort headers.
3950         * exec.h: Sort headers.
3951         * exec.c: Sort headers.
3952         * exceptions.c: Sort headers.
3953         * event-top.c: Sort headers.
3954         * event-loop.c: Sort headers.
3955         * eval.c: Sort headers.
3956         * elfread.c: Sort headers.
3957         * dwarf2read.h: Sort headers.
3958         * dwarf2read.c: Sort headers.
3959         * dwarf2loc.c: Sort headers.
3960         * dwarf2expr.h: Sort headers.
3961         * dwarf2expr.c: Sort headers.
3962         * dwarf2-frame.c: Sort headers.
3963         * dwarf2-frame-tailcall.c: Sort headers.
3964         * dwarf-index-write.h: Sort headers.
3965         * dwarf-index-write.c: Sort headers.
3966         * dwarf-index-common.c: Sort headers.
3967         * dwarf-index-cache.h: Sort headers.
3968         * dwarf-index-cache.c: Sort headers.
3969         * dummy-frame.c: Sort headers.
3970         * dtrace-probe.c: Sort headers.
3971         * disasm.h: Sort headers.
3972         * disasm.c: Sort headers.
3973         * disasm-selftests.c: Sort headers.
3974         * dictionary.c: Sort headers.
3975         * dicos-tdep.c: Sort headers.
3976         * demangle.c: Sort headers.
3977         * dcache.h: Sort headers.
3978         * dcache.c: Sort headers.
3979         * darwin-nat.h: Sort headers.
3980         * darwin-nat.c: Sort headers.
3981         * darwin-nat-info.c: Sort headers.
3982         * d-valprint.c: Sort headers.
3983         * d-namespace.c: Sort headers.
3984         * d-lang.c: Sort headers.
3985         * ctf.c: Sort headers.
3986         * csky-tdep.c: Sort headers.
3987         * csky-linux-tdep.c: Sort headers.
3988         * cris-tdep.c: Sort headers.
3989         * cris-linux-tdep.c: Sort headers.
3990         * cp-valprint.c: Sort headers.
3991         * cp-support.c: Sort headers.
3992         * cp-namespace.c: Sort headers.
3993         * cp-abi.c: Sort headers.
3994         * corelow.c: Sort headers.
3995         * corefile.c: Sort headers.
3996         * continuations.c: Sort headers.
3997         * completer.h: Sort headers.
3998         * completer.c: Sort headers.
3999         * complaints.c: Sort headers.
4000         * coffread.c: Sort headers.
4001         * coff-pe-read.c: Sort headers.
4002         * cli-out.h: Sort headers.
4003         * cli-out.c: Sort headers.
4004         * charset.c: Sort headers.
4005         * c-varobj.c: Sort headers.
4006         * c-valprint.c: Sort headers.
4007         * c-typeprint.c: Sort headers.
4008         * c-lang.c: Sort headers.
4009         * buildsym.c: Sort headers.
4010         * buildsym-legacy.c: Sort headers.
4011         * build-id.h: Sort headers.
4012         * build-id.c: Sort headers.
4013         * btrace.c: Sort headers.
4014         * bsd-uthread.c: Sort headers.
4015         * breakpoint.h: Sort headers.
4016         * breakpoint.c: Sort headers.
4017         * break-catch-throw.c: Sort headers.
4018         * break-catch-syscall.c: Sort headers.
4019         * break-catch-sig.c: Sort headers.
4020         * blockframe.c: Sort headers.
4021         * block.c: Sort headers.
4022         * bfin-tdep.c: Sort headers.
4023         * bfin-linux-tdep.c: Sort headers.
4024         * bfd-target.c: Sort headers.
4025         * bcache.c: Sort headers.
4026         * ax-general.c: Sort headers.
4027         * ax-gdb.h: Sort headers.
4028         * ax-gdb.c: Sort headers.
4029         * avr-tdep.c: Sort headers.
4030         * auxv.c: Sort headers.
4031         * auto-load.c: Sort headers.
4032         * arm-wince-tdep.c: Sort headers.
4033         * arm-tdep.c: Sort headers.
4034         * arm-symbian-tdep.c: Sort headers.
4035         * arm-pikeos-tdep.c: Sort headers.
4036         * arm-obsd-tdep.c: Sort headers.
4037         * arm-nbsd-tdep.c: Sort headers.
4038         * arm-nbsd-nat.c: Sort headers.
4039         * arm-linux-tdep.c: Sort headers.
4040         * arm-linux-nat.c: Sort headers.
4041         * arm-fbsd-tdep.c: Sort headers.
4042         * arm-fbsd-nat.c: Sort headers.
4043         * arm-bsd-tdep.c: Sort headers.
4044         * arch-utils.c: Sort headers.
4045         * arc-tdep.c: Sort headers.
4046         * arc-newlib-tdep.c: Sort headers.
4047         * annotate.h: Sort headers.
4048         * annotate.c: Sort headers.
4049         * amd64-windows-tdep.c: Sort headers.
4050         * amd64-windows-nat.c: Sort headers.
4051         * amd64-tdep.c: Sort headers.
4052         * amd64-sol2-tdep.c: Sort headers.
4053         * amd64-obsd-tdep.c: Sort headers.
4054         * amd64-obsd-nat.c: Sort headers.
4055         * amd64-nbsd-tdep.c: Sort headers.
4056         * amd64-nbsd-nat.c: Sort headers.
4057         * amd64-nat.c: Sort headers.
4058         * amd64-linux-tdep.c: Sort headers.
4059         * amd64-linux-nat.c: Sort headers.
4060         * amd64-fbsd-tdep.c: Sort headers.
4061         * amd64-fbsd-nat.c: Sort headers.
4062         * amd64-dicos-tdep.c: Sort headers.
4063         * amd64-darwin-tdep.c: Sort headers.
4064         * amd64-bsd-nat.c: Sort headers.
4065         * alpha-tdep.c: Sort headers.
4066         * alpha-obsd-tdep.c: Sort headers.
4067         * alpha-nbsd-tdep.c: Sort headers.
4068         * alpha-mdebug-tdep.c: Sort headers.
4069         * alpha-linux-tdep.c: Sort headers.
4070         * alpha-linux-nat.c: Sort headers.
4071         * alpha-bsd-tdep.c: Sort headers.
4072         * alpha-bsd-nat.c: Sort headers.
4073         * aix-thread.c: Sort headers.
4074         * agent.c: Sort headers.
4075         * addrmap.c: Sort headers.
4076         * ada-varobj.c: Sort headers.
4077         * ada-valprint.c: Sort headers.
4078         * ada-typeprint.c: Sort headers.
4079         * ada-tasks.c: Sort headers.
4080         * ada-lang.c: Sort headers.
4081         * aarch64-tdep.c: Sort headers.
4082         * aarch64-ravenscar-thread.c: Sort headers.
4083         * aarch64-newlib-tdep.c: Sort headers.
4084         * aarch64-linux-tdep.c: Sort headers.
4085         * aarch64-linux-nat.c: Sort headers.
4086         * aarch64-fbsd-tdep.c: Sort headers.
4087         * aarch64-fbsd-nat.c: Sort headers.
4088         * aarch32-linux-nat.c: Sort headers.
4089
4090 2019-04-04  Tom Tromey  <tom@tromey.com>
4091
4092         * varobj.c (varobj_create): Update.
4093         * rust-exp.y (struct rust_parser) <update_innermost_block,
4094         lookup_symbol>: New methods.
4095         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4096         Rename.
4097         (rust_parser::rust_lookup_type)
4098         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4099         * printcmd.c (display_command, do_one_display): Update.
4100         * parser-defs.h (struct parser_state) <parser_state>: Add
4101         "tracker" parameter.
4102         (block_tracker): New member.
4103         (class innermost_block_tracker) <innermost_block_tracker>: Add
4104         "types" parameter.
4105         <reset>: Remove method.
4106         (innermost_block): Don't declare.
4107         (null_post_parser): Update.
4108         * parse.c (innermost_block): Remove global.
4109         (write_dollar_variable): Update.
4110         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4111         Remove "tracker_types" parameter.
4112         (parse_expression): Add "tracker" parameter.
4113         (parse_expression_for_completion): Update.
4114         (null_post_parser): Add "tracker" parameter.
4115         * p-exp.y: Update rules.
4116         * m2-exp.y: Update rules.
4117         * language.h (struct language_defn) <la_post_parser>: Add
4118         "tracker" parameter.
4119         * go-exp.y: Update rules.
4120         * f-exp.y: Update rules.
4121         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4122         parameter.
4123         * d-exp.y: Update rules.
4124         * c-exp.y: Update rules.
4125         * breakpoint.c (set_breakpoint_condition): Create an
4126         innermost_block_tracker.
4127         (watch_command_1): Likewise.
4128         * ada-lang.c (resolve): Add "tracker" parameter.
4129         (resolve_subexp): Likewise.
4130         * ada-exp.y (write_var_from_sym): Update.
4131
4132 2019-04-04  Tom Tromey  <tom@tromey.com>
4133
4134         * type-stack.h: New file.
4135         * type-stack.c: New file.
4136         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4137         type-stack.h.
4138         (insert_into_type_stack, insert_type, push_type, push_type_int)
4139         (insert_type_address_space, pop_type, pop_type_int)
4140         (pop_typelist, pop_type_stack, append_type_stack)
4141         (push_type_stack, get_type_stack, push_typelist)
4142         (follow_type_instance_flags, follow_types): Don't declare.
4143         * parse.c (type_stack): Remove global.
4144         (parse_exp_in_context): Update.
4145         (insert_into_type_stack, insert_type, push_type, push_type_int)
4146         (insert_type_address_space, pop_type, pop_type_int)
4147         (pop_typelist, pop_type_stack, append_type_stack)
4148         (push_type_stack, get_type_stack, push_typelist)
4149         (follow_type_instance_flags, follow_types): Remove (moved to
4150         type-stack.c).
4151         * f-exp.y (type_stack): New global.
4152         Update rules.
4153         (push_kind_type, f_parse): Update.
4154         * d-exp.y (type_stack): New global.
4155         Update rules.
4156         (d_parse): Update.
4157         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4158         Update rules.
4159         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4160         (HFILES_NO_SRCDIR): Add type-stack.h.
4161
4162 2019-04-04  Tom Tromey  <tom@tromey.com>
4163
4164         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4165         (rust_parser::convert_ast_to_expression, rust_parse)
4166         (rust_lex_test_completion, rust_lex_tests): Update.
4167         * parser-defs.h (struct expr_completion_state): New.
4168         (struct parser_state) <parser_state>: Add completion parameter.
4169         <mark_struct_expression, mark_completion_tag>: New methods.
4170         <parse_completion, m_completion_state>: New members.
4171         (prefixify_expression, null_post_parser): Update.
4172         (mark_struct_expression, mark_completion_tag): Don't declare.
4173         * parse.c (parse_completion, expout_last_struct)
4174         (expout_tag_completion_type, expout_completion_name): Remove
4175         globals.
4176         (parser_state::mark_struct_expression)
4177         (parser_state::mark_completion_tag): Now methods.
4178         (prefixify_expression): Add last_struct parameter.
4179         (prefixify_subexp): Likewise.
4180         (parse_exp_1): Update.
4181         (parse_exp_in_context): Add cstate parameter.  Update.
4182         (parse_expression_for_completion): Create an
4183         expr_completion_state.
4184         (null_post_parser): Add "completion" parameter.
4185         * p-exp.y: Update rules.
4186         (yylex): Update.
4187         * language.h (struct language_defn) <la_post_parser>: Add
4188         "completing" parameter.
4189         * go-exp.y: Update rules.
4190         (lex_one_token): Update.
4191         * expression.h (parse_completion): Don't declare.
4192         * d-exp.y: Update rules.
4193         (lex_one_token): Update rules.
4194         * c-exp.y: Update rules.
4195         (lex_one_token): Update.
4196         * ada-lang.c (resolve): Add "parse_completion" parameter.
4197         (resolve_subexp): Likewise.
4198         (ada_resolve_function): Likewise.
4199
4200 2019-04-04  Tom Tromey  <tom@tromey.com>
4201
4202         * parser-defs.h (struct parser_state) <start_arglist,
4203         end_arglist>: New methods.
4204         <arglist_len, m_funcall_chain>: New members.
4205         (arglist_len, start_arglist, end_arglist): Don't declare.
4206         * parse.c (arglist_len, funcall_chain): Remove global.
4207         (start_arglist, end_arglist): Remove functions.
4208         (parse_exp_in_context): Update.
4209         * p-exp.y: Update rules.
4210         * m2-exp.y: Update rules.
4211         * go-exp.y: Update rules.
4212         * f-exp.y: Update rules.
4213         * d-exp.y: Update rules.
4214         * c-exp.y: Update rules.
4215
4216 2019-04-04  Tom Tromey  <tom@tromey.com>
4217
4218         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4219         lex_operator, push_back>: New methods.
4220         Update all rules.
4221         (rust_parser::lex_hex, lex_escape): Rename and update.
4222         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4223         (rust_parser::lex_operator): Rename and update.
4224         (rust_parser::lex_number, rustyylex, rustyyerror)
4225         (rust_lex_test_init, rust_lex_test_sequence)
4226         (rust_lex_test_push_back, rust_lex_tests): Update.
4227         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4228         parameter.
4229         <lexptr, prev_lexptr>: New members.
4230         (lexptr, prev_lexptr): Don't declare.
4231         * parse.c (lexptr, prev_lexptr): Remove globals.
4232         (parse_exp_in_context): Update.
4233         * p-exp.y (yylex, yyerror): Update.
4234         * m2-exp.y (parse_number, yylex, yyerror): Update.
4235         * go-exp.y (lex_one_token, yyerror): Update.
4236         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4237         * d-exp.y (lex_one_token, yyerror): Update.
4238         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4239         (lex_one_token, yyerror): Update.
4240         * ada-lex.l (YY_INPUT): Update.
4241         (rewind_to_char): Update.
4242         * ada-exp.y (yyerror): Update.
4243
4244 2019-04-04  Tom Tromey  <tom@tromey.com>
4245
4246         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4247         * parser-defs.h (struct parser_state) <parser_state>: Add new
4248         parameter.
4249         <comma_terminates>: New member.
4250         (comma_terminates): Don't declare global.
4251         * parse.c (comma_terminates): Remove global.
4252         (parse_exp_in_context): Update.
4253         * p-exp.y (yylex): Update.
4254         * m2-exp.y (yylex): Update.
4255         * go-exp.y (lex_one_token): Update.
4256         * f-exp.y (yylex): Update.
4257         * d-exp.y (lex_one_token): Update.
4258         * c-exp.y (lex_one_token): Update.
4259         * ada-lex.l: Update.
4260
4261 2019-04-04  Tom Tromey  <tom@tromey.com>
4262
4263         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4264         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4265         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4266         * parser-defs.h (paren_depth): Don't declare.
4267         * parse.c (paren_depth): Remove global.
4268         (parse_exp_in_context): Update.
4269         * p-exp.y (paren_depth): New global.
4270         (pascal_parse): Initialize it.
4271         * m2-exp.y (paren_depth): New global.
4272         (m2_parse): Initialize it.
4273         * go-exp.y (paren_depth): New global.
4274         (go_parse): Initialize it.
4275         * f-exp.y (paren_depth): New global.
4276         (f_parse): Initialize it.
4277         * d-exp.y (paren_depth): New global.
4278         (d_parse): Initialize it.
4279         * c-exp.y (paren_depth): New global.
4280         (c_parse): Initialize it.
4281         * ada-lex.l (paren_depth): New global.
4282         (lexer_init): Initialize it.
4283
4284 2019-04-04  Tom Tromey  <tom@tromey.com>
4285
4286         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4287         (rust_parser::convert_ast_to_type)
4288         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4289         * parser-defs.h (struct parser_state) <parser_state>: Add
4290         parameters.  Initialize new members.
4291         <expression_context_block, expression_context_pc>: New members.
4292         * parse.c (expression_context_block, expression_context_pc):
4293         Remove globals.
4294         (parse_exp_in_context): Update.
4295         * p-exp.y: Update all rules.
4296         (yylex): Update.
4297         * m2-exp.y: Update all rules.
4298         (yylex): Update.
4299         * go-exp.y (yylex): Update.
4300         * f-exp.y (yylex): Update.
4301         * d-exp.y: Update all rules.
4302         (yylex): Update.
4303         * c-exp.y: Update all rules.
4304         (lex_one_token, classify_name, yylex, c_parse): Update.
4305         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4306
4307 2019-04-04  Tom Tromey  <tom@tromey.com>
4308
4309         * gdbarch.h, gdbarch.c: Rebuild.
4310         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4311         * stap-probe.h:
4312         (struct stap_parse_info): Replace "parser_state" with
4313         "expr_builder".
4314         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4315         (parser_state): New class.
4316         * parse.c (expr_builder): Rename.
4317         (expr_builder::release): Rename.
4318         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4319         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4320         (write_exp_elt_longcst, write_exp_elt_floatcst)
4321         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4322         (write_exp_string_vector, write_exp_bitstring)
4323         (write_exp_msymbol, mark_struct_expression)
4324         (write_dollar_variable)
4325         (insert_type_address_space, increase_expout_size): Replace
4326         "parser_state" with "expr_builder".
4327         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4328         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4329         "parser_state" with "expr_builder".
4330
4331 2019-04-04  Tom Tromey  <tom@tromey.com>
4332
4333         * rust-exp.y: Replace "parse_language" with method call.
4334         * p-exp.y:
4335         (yylex): Replace "parse_language" with method call.
4336         * m2-exp.y:
4337         (yylex): Replace "parse_language" with method call.
4338         * go-exp.y (classify_name): Replace "parse_language" with method
4339         call.
4340         * f-exp.y (yylex): Replace "parse_language" with method call.
4341         * d-exp.y (lex_one_token): Replace "parse_language" with method
4342         call.
4343         * c-exp.y:
4344         (lex_one_token, classify_name, yylex): Replace "parse_language"
4345         with method call.
4346         * ada-exp.y (find_primitive_type, type_char)
4347         (type_system_address): Replace "parse_language" with method call.
4348
4349 2019-04-04  Tom Tromey  <tom@tromey.com>
4350
4351         * rust-exp.y: Replace "parse_gdbarch" with method call.
4352         * parse.c (write_dollar_variable, insert_type_address_space):
4353         Replace "parse_gdbarch" with method call.
4354         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4355         call.
4356         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4357         call.
4358         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4359         "parse_gdbarch" with method call.
4360         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4361         with method call.
4362         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4363         "parse_gdbarch" with method call.
4364         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4365         "parse_gdbarch" with method call.
4366         * c-exp.y (parse_type, parse_number, classify_name): Replace
4367         "parse_gdbarch" with method call.
4368         * ada-lex.l: Replace "parse_gdbarch" with method call.
4369         * ada-exp.y (parse_type, find_primitive_type, type_char)
4370         (type_system_address): Replace "parse_gdbarch" with method call.
4371
4372 2019-04-04  Tom Tromey  <tom@tromey.com>
4373
4374         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4375         * stap-probe.c (stap_parse_argument): Update.
4376         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4377         initial_size parameter.
4378         * rust-exp.y (rust_lex_tests): Update.
4379         * parse.c (parser_state): Update.
4380         (parse_exp_in_context): Update.
4381         * parser-defs.h (struct parser_state) <parser_state>: Remove
4382         "initial_size" parameter.
4383
4384 2019-04-04  Tom Tromey  <tom@tromey.com>
4385
4386         * parser-defs.h (increase_expout_size): Don't declare.
4387         * parse.c (increase_expout_size): Now static.
4388
4389 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4390
4391         * gnu-nat.c (gnu_nat_target::wait): Fix
4392         target_waitstatus_to_string call.
4393
4394 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4395
4396         * eval.c (evaluate_subexp_standard): Handle internal functions
4397         during Fortran function call handling.
4398
4399 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4400
4401         * NEWS: Mention new internal functions.
4402         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4403         (read_base_type): Use dwarf2_init_complex_target_type.
4404         * value.c (creal_internal_fn): New function.
4405         (cimag_internal_fn): New function.
4406         (_initialize_values): Register new internal functions.
4407
4408 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4409
4410         * infrun.c (stop_all_threads): If debug_infrun, always
4411         trace the wait status after wait_one, using
4412         target_waitstatus_to_string and target_pid_to_str.
4413         (handle_inferior_event): Replace various trace of
4414         wait status kind by a single trace.
4415         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4416         wait status kind image by target_waitstatus_to_string.
4417         * target/waitstatus.c (target_waitstatus_to_string): Fix
4418         obsolete comment.
4419
4420 2019-04-01  Tom Tromey  <tromey@adacore.com>
4421
4422         PR symtab/23331:
4423         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4424
4425 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4426             Pedro Alves  <palves@redhat.com>
4427
4428         * top.c (quit_force): Call 'finalize_values'.
4429         * value.c (finalize_values): New function.
4430         * value.h (finalize_values): Declare.
4431
4432 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4433
4434         * NEWS: Announce $_gdb_major and $_gdb_minor.
4435
4436         * top.c (init_gdb_version_vars): New function.
4437         (gdb_init): Call init_gdb_version_vars.
4438
4439 2019-03-29  Tom Tromey  <tromey@adacore.com>
4440
4441         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4442         help text.  Remove dead code.
4443
4444 2019-03-29  Keith Seitz  <keiths@redhat.com>
4445
4446         From Siddhesh Poyarekar:
4447         * f-lang.h (f77_get_upperbound): Return LONGEST.
4448         (f77_get_lowerbound): Likewise.
4449         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4450         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4451         print them.
4452         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4453         plongest to format print it.
4454         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4455         (f77_get_upperbound): Likewise.
4456         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4457         LOWER_BOUND to LONGEST.
4458         (f77_create_arrayprint_offset_tbl): Likewise.
4459
4460 2019-03-29  Keith Seitz  <keiths@redhat.com>
4461
4462         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4463         %s/pulongest for TYPE_LENGTH instead of %d in format
4464         strings.
4465         * ada-typerint.c (ada_print_type): Likewise.
4466         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4467         * compile/compile-c-support.c (generate_register_struct): Likewise.
4468         * gdbtypes.c (recursive_dump_type): Likewise.
4469         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4470         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4471         instead of %d in format strings.
4472         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4473         to std::min to ULONGEST.
4474         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4475         instead of %d in format strings.
4476         * tracepoint.c (info_scope_command): Likewise.
4477         * typeprint.c (print_offset_data::update)
4478         (print_offset_data::finish): Likewise.
4479         * xtensa-tdep.c (xtensa_store_return_value)
4480         (xtensa_push_dummy_call): Likewise.
4481
4482 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4483
4484         * windows-nat.c (display_selector): Fixed format specifications
4485         for 64-bit Cygwin.
4486
4487 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4488
4489         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4490
4491 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4492
4493         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4494         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4495         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4496         (nios2_linux_init_abi): Install it.
4497
4498 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4499
4500         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4501
4502 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4503
4504         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4505
4506 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4507             Tom Tromey  <tromey@adacore.com>
4508
4509         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4510
4511 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4512
4513         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4514         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4515         method to compute the bounds of range types. Also print "[evaluated]"
4516         if the bounds' values come from a dynamic evaluation.
4517
4518 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4519
4520         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4521         whitespace when pretty printing is on.
4522
4523 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4524
4525         * ppc-linux-nat.c: Add include.
4526
4527 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4528
4529         * NEWS: Mention AArch64 Pointer Authentication.
4530
4531 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4532
4533         * arm-linux-nat.c: Add include.
4534
4535 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4536
4537         * source-cache.c (source_cache::get_source_lines): Re-read
4538         fullname after calling open_source_file.
4539
4540 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4541
4542         * NEWS: Mention TLS support for FreeBSD.
4543
4544 2019-03-25  Tom Tromey  <tromey@adacore.com>
4545
4546         * minsyms.c (BUNCH_SIZE): Update comment.
4547         (~minimal_symbol_reader): Remove old comment.
4548         (compact_minimal_symbols): Update comment.
4549         (minimal_symbol_reader::install): Remove old comment.  Update
4550         other comments.
4551
4552 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4553
4554         * s390-linux-nat.c: Add include.
4555
4556 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4557
4558         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4559         Call linux_get_hwcap.
4560         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4561         Likewise.
4562         (aarch64_linux_get_hwcap): Remove function.
4563         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4564         declaration.
4565         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4566         linux_get_hwcap.
4567         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4568         * linux-tdep.c (linux_get_hwcap): Add function.
4569         (linux_get_hwcap2): Likewise.
4570         * linux-tdep.h (linux_get_hwcap): Add declaration.
4571         (linux_get_hwcap2): Likewise.
4572         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4573         (ppc_linux_get_hwcap2): Likewise.
4574         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4575         linux_get_hwcap.
4576         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4577         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4578         (ppc_linux_nat_target::read_description): Likewise.
4579         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4580         * s390-linux-nat.c: Likewise.
4581         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4582
4583 2019-03-24  Tom Tromey  <tom@tromey.com>
4584
4585         * ada-lang.c (standard_lookup): Simplify initialization.
4586         (ada_lookup_symbol_nonlocal): Simplify return.
4587         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4588         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4589         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4590         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4591         initialization.
4592         * solib.c (solib_global_lookup): Simplify.
4593         * symtab.c (null_block_symbol): Remove.
4594         (symbol_cache_lookup): Simplify returns.
4595         (lookup_language_this): Simplify returns.
4596         (lookup_symbol_aux): Simplify return.
4597         (lookup_local_symbol): Simplify returns.
4598         (lookup_global_symbol_from_objfile): Simplify return.
4599         (lookup_symbol_in_objfile_symtabs)
4600         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4601         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4602         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4603         * cp-namespace.c (cp_lookup_bare_symbol)
4604         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4605         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4606         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4607         (cp_lookup_symbol_via_imports): Simplify initialization.
4608         (find_symbol_in_baseclass): Likewise.
4609         * symtab.h (null_block_symbol): Remove.
4610         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4611         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4612         (d_lookup_symbol_module): Likewise.
4613         (find_symbol_in_baseclass): Simplify initialization.
4614
4615 2019-03-24  Tom Tromey  <tom@tromey.com>
4616
4617         * expression.h: Don't include symtab.h.
4618         (struct block): Forward declare.
4619
4620 2019-03-24  Tom Tromey  <tom@tromey.com>
4621
4622         * c-exp.y (typebase): Remove casts.
4623         * gdbtypes.c (lookup_unsigned_typename, )
4624         (lookup_signed_typename): Remove cast.
4625         * eval.c (parse_to_comma_and_eval): Remove cast.
4626         * parse.c (write_dollar_variable): Remove cast.
4627         * block.h (struct block) <superblock>: Now const.
4628         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4629         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4630         (map_block): Make "block" const.
4631         * symfile.h (struct quick_symbol_functions)
4632         <map_matching_symbols>: Constify block argument to "callback".
4633         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4634         const.
4635         (find_pc_sect_compunit_symtab): Make "b" const.
4636         (find_symbol_at_address): Likewise.
4637         (search_symbols): Likewise.
4638         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4639         (dw2_debug_names_lookup_symbol): Likewise.
4640         (dw2_map_matching_symbols): Update.
4641         * p-valprint.c (pascal_val_print): Remove "block".
4642         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4643         (aux_add_nonlocal_symbols): Make "block" const.
4644         (resolve_subexp): Remove cast.
4645         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4646         const.
4647         (iterate_over_file_blocks): Likewise.
4648         * f-exp.y (%union) <bval>: Remove.
4649         * coffread.c (patch_opaque_types): Make "b" const.
4650         * spu-tdep.c (spu_catch_start): Make "block" const.
4651         * c-valprint.c (print_unpacked_pointer): Remove "block".
4652         * symmisc.c (dump_symtab_1): Make "b" const.
4653         (block_depth): Make "block" const.
4654         * d-exp.y (%union) <bval>: Remove.
4655         * cp-support.h (cp_lookup_rtti_type): Update.
4656         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4657         * psymtab.c (psym_lookup_symbol): Make "block" const.
4658         (maintenance_check_psymtabs): Make "b" const.
4659         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4660         (enumerate_locals, enumerate_args): Update.
4661         * python/py-symtab.c (stpy_global_block): Make "block" const.
4662         (stpy_static_block): Likewise.
4663         * inline-frame.c (block_starting_point_at): Make "new_block"
4664         const.
4665         * block.c (find_block_in_blockvector): Make return type const.
4666         (blockvector_for_pc_sect): Make "b" const.
4667         (find_block_in_blockvector): Make "b" const.
4668
4669 2019-03-23  Tom Tromey  <tom@tromey.com>
4670
4671         * varobj.c (varobj_create): Update.
4672         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4673         * printcmd.c (display_command, do_one_display): Don't reset
4674         innermost_block.
4675         * parser-defs.h (enum innermost_block_tracker_type): Move to
4676         expression.h.
4677         (innermost_block): Update comment.
4678         * parse.c (parse_exp_1): Add tracker_types parameter.
4679         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4680         tracker_types parameter.  Reset innermost_block.
4681         (parse_exp_in_context): Remove.
4682         (parse_expression_for_completion): Update.
4683         * objfiles.c (~objfile): Don't reset expression_context_block or
4684         innermost_block.
4685         * expression.h (enum innermost_block_tracker_type): Move from
4686         parser-defs.h.
4687         (parse_exp_1): Add tracker_types parameter.
4688         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4689         reset innermost_block.
4690
4691 2019-03-23  Tom Tromey  <tom@tromey.com>
4692
4693         * objfiles.h: Include bcache.h.
4694
4695 2019-03-23  Tom Tromey  <tom@tromey.com>
4696
4697         * linespec.c (get_current_search_block): Use
4698         scoped_restore_current_language.
4699         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4700
4701 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4702             Jiong Wang  <jiong.wang@arm.com>
4703
4704         * aarch64-linux-tdep.c
4705         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4706         section.
4707         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4708
4709 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4710             Jiong Wang  <jiong.wang@arm.com>
4711
4712         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4713         instructions.
4714         (aarch64_analyze_prologue_test): Add PACIASP test.
4715         (aarch64_prologue_prev_register): Unmask PC value.
4716
4717 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4718             Jiong Wang  <jiong.wang@arm.com>
4719
4720         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4721         (aarch64_dwarf2_prev_register): Unmask PC value.
4722         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4723         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4724         DW_CFA_AARCH64_negate_ra_state.
4725         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4726
4727 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4728             Jiong Wang  <jiong.wang@arm.com>
4729
4730         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4731         registers.
4732         (aarch64_pseudo_register_name): Likewise.
4733         (aarch64_pseudo_register_type): Likewise.
4734         (aarch64_pseudo_register_reggroup_p): Likewise.
4735         (aarch64_gdbarch_init): Add pauth registers.
4736         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4737         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4738         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4739         (struct gdbarch_tdep): Add regnum for ra_state.
4740
4741 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4742             Jiong Wang  <jiong.wang@arm.com>
4743
4744         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4745
4746 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4747             Jiong Wang  <jiong.wang@arm.com>
4748
4749         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4750         function.
4751         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4752         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4753         (aarch64_gdbarch_init): Add puth registers.
4754         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4755         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4756         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4757
4758 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4759             Jiong Wang  <jiong.wang@arm.com>
4760
4761         * aarch64-linux-nat.c
4762         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4763         * aarch64-linux-tdep.c
4764         (aarch64_linux_core_read_description): Likewise.
4765         (aarch64_linux_get_hwcap): New function.
4766         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4767         (aarch64_linux_get_hwcap): New declaration.
4768
4769 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4770             Jiong Wang  <jiong.wang@arm.com>
4771
4772         * aarch64-linux-nat.c
4773         (aarch64_linux_nat_target::read_description): Add pauth param.
4774         * aarch64-linux-tdep.c
4775         (aarch64_linux_core_read_description): Likewise.
4776         * aarch64-tdep.c (struct target_desc): Add in pauth.
4777         (aarch64_read_description): Add pauth param.
4778         (aarch64_gdbarch_init): Likewise.
4779         * aarch64-tdep.h (aarch64_read_description): Likewise.
4780         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4781         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4782         * features/Makefile: Add new files.
4783         * features/aarch64-pauth.c: New file.
4784         * features/aarch64-pauth.xml: New file.
4785
4786 2019-03-20  Tom Tromey  <tromey@adacore.com>
4787
4788         * infrun.c (handle_inferior_event): Rename from
4789         handle_inferior_event_1.  Create a scoped_value_mark.
4790         (handle_inferior_event): Remove.
4791
4792 2019-03-19  Tom Tromey  <tromey@adacore.com>
4793
4794         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4795         * infrun.h (print_stop_event): Add "displays" parameter.
4796         * infrun.c (print_stop_event): Add "displays" parameter.
4797
4798 2019-03-19  Pedro Alves  <palves@redhat.com>
4799
4800         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4801         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4802         to -1.  Fix TABs vs spaces.
4803         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4804         * tui/tui-out.h (tui_ui_out) Add intro comments.
4805         <m_line, m_start_of_line>: In-class initialize, and add describing
4806         comment.
4807
4808 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4809
4810         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4811         variable names.
4812         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4813
4814 2019-03-18  Pedro Alves  <palves@redhat.com>
4815             Eli Zaretskii <eliz@gnu.org>
4816
4817         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4818         m_line and m_start_of_line.
4819
4820 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4821
4822         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4823         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4824         it returns a newline.  This fixes a regression in TU mode, whereby
4825         the next line is output on the same screen line as the user input.
4826
4827 2019-03-18  Tom Tromey  <tromey@adacore.com>
4828
4829         * minsyms.c (minimal_symbol_reader::install): Remove call to
4830         obstack_blank.
4831
4832 2019-03-18  Pedro Alves  <palves@redhat.com>
4833
4834         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4835         New globals.
4836         (apply_style): New, factored out from ...
4837         (apply_ansi_escape): ... this.  Handle reverse video mode.
4838         (tui_set_reverse_mode): New function.
4839         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4840         * tui/tui-winsource.c (tui_show_source_line): Use
4841         tui_set_reverse_mode instead of setting A_STANDOUT.
4842         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4843         New setter methods.
4844
4845 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4846
4847         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4848         Handle tabs.
4849
4850 2019-03-18  Tom Tromey  <tromey@adacore.com>
4851
4852         * ada-lang.c (empty_array): Add "high" parameter.
4853         (ada_evaluate_subexp): Update.
4854
4855 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4856
4857         * unittests/string_view-selftests.c: Define
4858         _initialize_string_view_selftests unconditionally.
4859
4860 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4861
4862         PR gdb/24350
4863         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4864
4865 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4866
4867         PR gdb/24351
4868         * windows-nat.c (display_selector): Fix format specifiers.
4869
4870 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4871
4872         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4873         tui_refill_source_window instead of tui_refresh_win, to update the
4874         current execution line.  This fixes redisplay of the current line
4875         when stepping through the code with "next" or "step".
4876
4877 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4878
4879         * source-cache.c (source_cache::get_source_lines): Call
4880         find_source_lines to initialize s->nlines.  This fixes vertical
4881         scrolling of TUI source window when the DOWN arrow is pressed.
4882
4883 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4884
4885         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4886         linux-thread-db.c (_initialize_thread_db): Likewise.
4887
4888 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4889
4890         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4891         wclrtoeol in tui_show_source_line".  This reverts changes made in
4892         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4893
4894 2019-03-15  Tom Tromey  <tom@tromey.com>
4895
4896         * symtab.h (struct minimal_symbol): Derive from
4897         general_symbol_info.
4898         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4899         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4900         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4901         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4902         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4903         (MSYMBOL_SEARCH_NAME): Update.
4904         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4905         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4906         * minsyms.c (minimal_symbol_reader::record_full): Update.
4907
4908 2019-03-15  Tom Tromey  <tom@tromey.com>
4909
4910         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4911
4912 2019-03-15  Tom Tromey  <tom@tromey.com>
4913
4914         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4915         unique_xmalloc_ptr.
4916         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4917         Update.
4918         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4919         (build_minimal_symbol_hash_tables)
4920         (minimal_symbol_reader::install): Update.
4921
4922 2019-03-15  Tom Tromey  <tom@tromey.com>
4923
4924         * symtab.c (create_demangled_names_hash): Update.
4925         (symbol_set_names): Update.
4926         * objfiles.h (struct objfile_per_bfd_storage)
4927         <demangled_names_hash>: Now an htab_up.
4928         * objfiles.c (objfile_per_bfd_storage): Simplify.
4929
4930 2019-03-15  Tom Tromey  <tom@tromey.com>
4931
4932         * objfiles.h (struct objfile_per_bfd_storage): Declare
4933         destructor.
4934         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4935         New.
4936         (get_objfile_bfd_data): Use new.  Don't initialize
4937         language_of_main.
4938         (free_objfile_per_bfd_storage): Remove.
4939         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4940
4941 2019-03-15  Tom Tromey  <tom@tromey.com>
4942
4943         * symfile.c (reread_symbols): Update.
4944         * objfiles.c (objfile::objfile): Update.
4945         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4946         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4947         comment.
4948         (minimal_symbol_reader::install): Update.
4949         (terminate_minimal_symbol_table): Remove.
4950         * jit.c (jit_object_close_impl): Update.
4951
4952 2019-03-15  Tom Tromey  <tom@tromey.com>
4953
4954         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4955         initializations.
4956
4957 2019-03-15  Tom Tromey  <tom@tromey.com>
4958
4959         * objfiles.h (struct objfile_per_bfd_storage)
4960         <demangled_hash_languages>: Now a bitset.
4961         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4962         (lookup_minimal_symbol): Update.
4963
4964 2019-03-15  Tom Tromey  <tom@tromey.com>
4965
4966         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4967         Don't return the symbol.
4968         * coffread.c (record_minimal_symbol): Use record_full.
4969
4970 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4971
4972         The MS-Windows port of ncurses fails to switch to a color pair if
4973         one or both of the colors are the implicit default colors.  This
4974         change records the default colors when TUI is initialized, and
4975         then specifies them explicitly when a color pair uses the default
4976         colors.  This allows color styling in TUI mode on MS-Windows.
4977
4978         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4979         ncurses_norm_attr.
4980         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4981         colors in ncurses_norm_attr.
4982         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4983         "none", replace it with the default color recorded in
4984         ncurses_norm_attr.
4985
4986 2019-03-14  Tom Tromey  <tromey@adacore.com>
4987
4988         * source-cache.h (class source_cache) <get_source_lines>: Return
4989         std::string.
4990         * source-cache.c (source_cache::extract_lines): Handle case where
4991         first_pos==npos.  Return std::string.
4992         (source_cache::get_source_lines): Update.
4993
4994 2019-03-14  Tom Tromey  <tromey@adacore.com>
4995
4996         * NEWS: Add item for "style sources" commands.
4997         * source-cache.c (source_cache::get_source_lines): Check
4998         source_styling.
4999         * cli/cli-style.c (source_styling): New global.
5000         (_initialize_cli_style): Add "style sources" commands.
5001         (show_style_sources): New function.
5002         * cli/cli-style.h (source_styling): Declare.
5003
5004 2019-03-14  Pedro Alves  <palves@redhat.com>
5005             Tom Tromey  <tromey@adacore.com>
5006
5007         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5008         * tui/tui-winsource.c (tui_refill_source_window): New function,
5009         from...
5010         (tui_horizontal_source_scroll): ... here.  Move some logic.
5011         * cli/cli-style.c (set_style_enabled): Notify new observable.
5012         * tui/tui-hooks.c (tui_redisplay_source): New function.
5013         (tui_attach_detach_observers): Attach or detach
5014         tui_redisplay_source.
5015         * observable.h (source_styling_changed): New observable.
5016         * observable.c: Define source_styling_changed observable.
5017
5018 2019-03-13  Tom Tromey  <tromey@adacore.com>
5019
5020         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5021         (i386_gnu_nat_target::store_registers): Update.
5022         * target-debug.h (target_debug_print_std_string): New macro.
5023         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5024         * windows-tdep.c (display_one_tib): Update.
5025         * tui/tui-stack.c (tui_make_status_line): Update.
5026         * top.c (print_inferior_quit_action): Update.
5027         * thread.c (thr_try_catch_cmd): Update.
5028         (add_thread_with_info): Update.
5029         (thread_target_id_str): Update.
5030         (thr_try_catch_cmd): Update.
5031         (thread_command): Update.
5032         (thread_find_command): Update.
5033         * record-btrace.c (record_btrace_target::info_record)
5034         (record_btrace_resume_thread, record_btrace_target::resume)
5035         (record_btrace_cancel_resume, record_btrace_step_thread)
5036         (record_btrace_target::wait, record_btrace_target::wait)
5037         (record_btrace_target::wait, record_btrace_target::stop): Update.
5038         * progspace.c (print_program_space): Update.
5039         * process-stratum-target.c
5040         (process_stratum_target::thread_address_space): Update.
5041         * linux-fork.c (linux_fork_mourn_inferior)
5042         (detach_checkpoint_command, info_checkpoints_command)
5043         (linux_fork_context): Update.
5044         (linux_fork_detach): Update.
5045         (class scoped_switch_fork_info): Update.
5046         (delete_checkpoint_command): Update.
5047         * infrun.c (follow_fork_inferior): Update.
5048         (follow_fork_inferior): Update.
5049         (proceed_after_vfork_done): Update.
5050         (handle_vfork_child_exec_or_exit): Update.
5051         (follow_exec): Update.
5052         (displaced_step_prepare_throw): Update.
5053         (displaced_step_restore): Update.
5054         (start_step_over): Update.
5055         (resume_1): Update.
5056         (clear_proceed_status_thread): Update.
5057         (proceed): Update.
5058         (print_target_wait_results): Update.
5059         (do_target_wait): Update.
5060         (context_switch): Update.
5061         (stop_all_threads): Update.
5062         (restart_threads): Update.
5063         (finish_step_over): Update.
5064         (handle_signal_stop): Update.
5065         (switch_back_to_stepped_thread): Update.
5066         (keep_going_pass_signal): Update.
5067         (print_exited_reason): Update.
5068         (normal_stop): Update.
5069         * inferior.c (inferior_pid_to_str): Change return type.
5070         (print_selected_inferior): Update.
5071         (add_inferior): Update.
5072         (detach_inferior): Update.
5073         * dummy-frame.c (fprint_dummy_frames): Update.
5074         * dcache.c (dcache_info_1): Update.
5075         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5076         (btrace_fetch, btrace_clear): Update.
5077         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5078         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5079         type.
5080         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5081         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5082         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5083         * gdbarch.c, gdbarch.h: Rebuild.
5084         * gdbarch.sh (core_pid_to_str): Change return type.
5085         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5086         return type.
5087         (windows_nat_target::pid_to_str): Change return type.
5088         (windows_delete_thread): Update.
5089         (windows_nat_target::attach): Update.
5090         (windows_nat_target::files_info): Update.
5091         * target-delegates.c: Rebuild.
5092         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5093         return type.
5094         (sol_thread_target::pid_to_str): Change return type.
5095         * remote.c (class remote_target) <pid_to_str>: Change return
5096         type.
5097         (remote_target::pid_to_str): Change return type.
5098         (extended_remote_target::attach, remote_target::remote_stop_ns)
5099         (remote_target::remote_notif_remove_queued_reply)
5100         (remote_target::push_stop_reply, remote_target::disable_btrace):
5101         Update.
5102         (extended_remote_target::attach): Update.
5103         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5104         type.
5105         (gdbsim_target::pid_to_str): Change return type.
5106         * ravenscar-thread.c (struct ravenscar_thread_target)
5107         <pid_to_str>: Change return type.
5108         (ravenscar_thread_target::pid_to_str): Change return type.
5109         * procfs.c (class procfs_target) <pid_to_str>: Change return
5110         type.
5111         (procfs_target::pid_to_str): Change return type.
5112         (procfs_target::attach): Update.
5113         (procfs_target::detach): Update.
5114         (procfs_target::fetch_registers): Update.
5115         (procfs_target::store_registers): Update.
5116         (procfs_target::wait): Update.
5117         (procfs_target::files_info): Update.
5118         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5119         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5120         return type.
5121         (nto_procfs_target::pid_to_str): Change return type.
5122         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5123         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5124         return type.
5125         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5126         (exit_lwp): Update.
5127         (attach_proc_task_lwp_callback, get_detach_signal)
5128         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5129         (linux_nat_target::resume, wait_lwp, stop_callback)
5130         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5131         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5132         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5133         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5134         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5135         type.
5136         (inf_ptrace_target::attach): Update.
5137         (inf_ptrace_target::files_info): Update.
5138         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5139         type.
5140         (go32_nat_target::pid_to_str): Change return type.
5141         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5142         (gnu_nat_target::wait): Update.
5143         (gnu_nat_target::wait): Update.
5144         (gnu_nat_target::resume): Update.
5145         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5146         (fbsd_nat_target::wait): Update.
5147         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5148         type.
5149         (darwin_nat_target::attach): Update.
5150         * corelow.c (class core_target) <pid_to_str>: Change return type.
5151         (core_target::pid_to_str): Change return type.
5152         * target.c (normal_pid_to_str): Change return type.
5153         (default_pid_to_str): Likewise.
5154         (target_pid_to_str): Change return type.
5155         (target_translate_tls_address): Update.
5156         (target_announce_detach): Update.
5157         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5158         return type.
5159         (bsd_uthread_target::pid_to_str): Change return type.
5160         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5161         type.
5162         (bsd_kvm_target::pid_to_str): Change return type.
5163         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5164         return type.
5165         (aix_thread_target::pid_to_str): Change return type.
5166         * target.h (struct target_ops) <pid_to_str>: Change return type.
5167         (target_pid_to_str, normal_pid_to_str): Likewise.
5168         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5169         type.
5170         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5171         type.
5172         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5173         return type.
5174         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5175         type.
5176         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5177         type.
5178         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5179         return type.
5180
5181 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5182
5183         * NEWS: Mention that the new default MI version is 3.  Mention
5184         changes to the output of commands and events that deal with
5185         multi-location breakpoints.
5186         * breakpoint.c: Include "mi/mi-out.h".
5187         (print_one_breakpoint): Change output syntax if using MI version
5188         >= 3.
5189         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5190         New.
5191         (mi_multi_location_breakpoint_output_fixed): New.
5192         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5193         (mi_cmd_fix_multi_location_breakpoint_output): New.
5194         (mi_multi_location_breakpoint_output_fixed): New.
5195         * mi/mi-cmds.c (mi_cmds): Register command
5196         -fix-multi-location-breakpoint-output.
5197         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5198         interpreter "mi".
5199
5200 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5201
5202         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5203         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5204         instantiate mi_ui_out based on interpreter name.
5205         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5206         * mi/mi-main.c (mi_load_progress): Likewise.
5207
5208 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5209
5210         * NEWS: Combine separate "New targets" sections for 8.3.
5211
5212 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5213
5214         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5215         (ppcfbsd_init_abi): Install gdbarch
5216         "fetch_tls_load_module_address" and "get_thread_local_address"
5217         methods.
5218
5219 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5220
5221         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5222         (riscv_fbsd_init_abi): Install gdbarch
5223         "fetch_tls_load_module_address" and "get_thread_local_address"
5224         methods.
5225
5226 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5227
5228         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5229         (i386fbsd_init_abi): Install gdbarch
5230         "fetch_tls_load_module_address" and "get_thread_local_address"
5231         methods.
5232
5233 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5234
5235         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5236         (amd64fbsd_init_abi): Install gdbarch
5237         "fetch_tls_load_module_address" and "get_thread_local_address"
5238         methods.
5239
5240 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5241
5242         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5243         (struct fbsd_pspace_data): New type.
5244         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5245         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5246         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5247         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5248         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5249
5250 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5251
5252         * gdbtypes.c (lookup_struct_elt): New function.
5253         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5254         * gdbtypes.h (struct struct_elt): New type.
5255         (lookup_struct_elt): New prototype.
5256
5257 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5258
5259         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5260         remove disabled code block.
5261
5262 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5263
5264         * gdbarch.sh (get_thread_local_address): New method.
5265         * gdbarch.h, gdbarch.c: Regenerate.
5266         * target.c (target_translate_tls_address): Use
5267         gdbarch_get_thread_local_address if present instead of
5268         target::get_thread_local_address.
5269
5270 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5271
5272         * target.h (target::get_thread_local_address): Update comment.
5273
5274 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5275
5276         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5277         objfile->separate_debug_objfile_backlink if not NULL.
5278
5279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5280
5281         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5282         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5283         (amd64bsd_store_inferior_registers): Likewise.
5284         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5285         Enable segment base registers.
5286         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5287         PT_GETFSBASE and PT_GETGSBASE.
5288         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5289         PT_SETGSBASE.
5290         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5291         segment base registers.
5292         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5293
5294 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5295
5296         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5297         Update calls to i386_target_description to add 'segments'
5298         parameter.
5299         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5300         add segment base registers.
5301         * arch/i386.c (i386_create_target_description): Add 'segments'
5302         parameter to enable segment base registers.
5303         * arch/i386.h (i386_create_target_description): Likewise.
5304         * features/i386/32bit-segments.xml: New file.
5305         * features/i386/32bit-segments.c: Generate.
5306         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5307         call to i386_target_description to add 'segments' parameter.
5308         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5309         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5310         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5311         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5312         if feature is present.
5313         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5314         Add 'segments' parameter to call to i386_target_description.
5315         (i386_target_description): Add 'segments' parameter to enable
5316         segment base registers.
5317         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5318         to call to i386_target_description.
5319         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5320         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5321         Define I386_NUM_REGS.
5322         (i386_target_description): Add 'segments' parameter to enable
5323         segment base registers.
5324
5325 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5326
5327         PR/24325
5328         * source-cache.c: #undef open and close, to avoid unresolved
5329         externals during linking.
5330
5331 2019-03-12  Tom Tromey  <tromey@adacore.com>
5332
5333         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5334         const.  Add initializers.
5335         (_initialize_remote): Don't initialize ptid globals.
5336
5337 2019-03-12  Pedro Alves  <palves@redhat.com>
5338
5339         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5340
5341 2019-03-12  Pedro Alves  <palves@redhat.com>
5342
5343         * cp-name-parser.y (main): Remove unused 'len' variable.
5344
5345 2019-03-12  Tom Tromey  <tromey@adacore.com>
5346
5347         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5348         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5349
5350 2019-03-12  Tom Tromey  <tromey@adacore.com>
5351
5352         * linux-nat.c (iterate_over_lwps): Update.
5353         (stop_callback): Remove parameter.
5354         (stop_wait_callback, detach_callback, resume_set_callback)
5355         (select_singlestep_lwp_callback, set_ignore_sigint)
5356         (status_callback, resumed_callback, resume_clear_callback)
5357         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5358         data parameter.
5359         (linux_nat_target::detach, linux_nat_target::resume)
5360         (linux_stop_and_wait_all_lwps, select_event_lwp)
5361         (linux_nat_filter_event, linux_nat_wait_1)
5362         (linux_nat_target::kill, linux_nat_target::stop)
5363         (linux_nat_target::stop): Update.
5364         (linux_nat_resume_callback): Change type.
5365         (resume_stopped_resumed_lwps, count_events_callback)
5366         (select_event_lwp_callback): Likewise.
5367         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5368         * arm-linux-nat.c (struct update_registers_data): Remove.
5369         (update_registers_callback): Change type.
5370         (arm_linux_insert_hw_breakpoint1): Update.
5371         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5372         parameter.
5373         (x86_linux_dr_set_addr): Update.
5374         (x86_linux_dr_set_control): Update.
5375         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5376         (iterate_over_lwps): Use gdb::function_view.
5377         * nat/aarch64-linux-hw-point.c (struct
5378         aarch64_dr_update_callback_param): Remove.
5379         (debug_reg_change_callback): Change type.
5380         (aarch64_notify_debug_reg_change): Update.
5381         * s390-linux-nat.c (s390_refresh_per_info): Update.
5382
5383 2019-03-11  Tom Tromey  <tromey@adacore.com>
5384
5385         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5386         redundant assignment to "this_cu".
5387
5388 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5389
5390         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5391
5392 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5393
5394         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5395         from...
5396         (rank_one_type): ... this.
5397
5398 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5399
5400         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5401         from...
5402         (rank_one_type): ... this.
5403
5404 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5405
5406         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5407         from...
5408         (rank_one_type): ... this.
5409
5410 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5411
5412         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5413         from...
5414         (rank_one_type): ... this.
5415
5416 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5417
5418         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5419         from...
5420         (rank_one_type): ... this.
5421
5422 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5423
5424         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5425         from...
5426         (rank_one_type): ... this.
5427
5428 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5429
5430         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5431         from...
5432         (rank_one_type): ... this.
5433
5434 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5435
5436         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5437         from...
5438         (rank_one_type): ... this.
5439
5440 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5441
5442         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5443         from...
5444         (rank_one_type): ... this.
5445
5446 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5447
5448         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5449         from...
5450         (rank_one_type): ... this.
5451
5452 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5453
5454         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5455         from...
5456         (rank_one_type): ... this.
5457
5458 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5459
5460         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5461         from...
5462         (rank_one_type): ... this.
5463
5464 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5465
5466         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5467         inferior-events' shows the example events.
5468
5469 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5470
5471         Support styling on native MS-Windows console
5472
5473         PR/24315
5474         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5475         on MS-Windows if $TERM is not defined.
5476
5477         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5478
5479         * posix-hdep.c (gdb_console_fputs):
5480         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5481         functions.
5482         * ui-file.h (gdb_console_fputs): Add prototype.
5483
5484         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5485         back to fputs only if the former returns zero.
5486
5487 2019-03-07  Tom Tromey  <tom@tromey.com>
5488
5489         * symmisc.c (print_symbol_bcache_statistics): Update.
5490         (print_objfile_statistics): Update.
5491         * symfile.c (allocate_symtab): Update.
5492         * stabsread.c: Don't include bcache.h.
5493         * psymtab.h (struct psymbol_bcache): Don't declare.
5494         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5495         (psymbol_bcache_init, psymbol_bcache_free)
5496         (psymbol_bcache_get_bcache): Don't declare.
5497         * psymtab.c (struct psymbol_bcache): Remove.
5498         (psymtab_storage::psymtab_storage): Update.
5499         (psymtab_storage::~psymtab_storage): Update.
5500         (psymbol_bcache_init, psymbol_bcache_free)
5501         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5502         (add_psymbol_to_bcache): Update.
5503         (allocate_psymtab): Update.
5504         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5505         macro_cache>: No longer pointers.
5506         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5507         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5508         * macrotab.c (macro_bcache): Update.
5509         * macroexp.c: Don't include bcache.h.
5510         * gdbtypes.c (check_types_worklist): Update.
5511         (types_deeply_equal): Remove TRY/CATCH.  Update.
5512         * elfread.c (elf_symtab_read): Update.
5513         * dwarf2read.c: Don't include bcache.h.
5514         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5515         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5516         (print_bcache_statistics, bcache_memory_used): Don't declare.
5517         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5518         methods.  Rename all data members.
5519         * bcache.c (struct bcache): Move to bcache.h.
5520         (bcache::expand_hash_table): Rename from expand_hash_table.
5521         (bcache): Remove.
5522         (bcache::insert): Rename from bcache_full.
5523         (bcache::compare): Rename from bcache_compare.
5524         (bcache_xmalloc): Remove.
5525         (bcache::~bcache): Rename from bcache_xfree.
5526         (bcache::print_statistics): Rename from print_bcache_statistics.
5527         (bcache::memory_used): Rename from bcache_memory_used.
5528
5529 2019-03-07  Pedro Alves  <palves@redhat.com>
5530
5531         * infrun.c (normal_stop): Also check for
5532         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5533
5534 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5535
5536         * f-lang.c (value_from_host_double): Moved to...
5537         * value.c (value_from_host_double): ...here.
5538         * value.h (value_from_host_double): Declare.
5539         * guile/scm-math.c (vlscm_convert_typed_number): Use
5540         value_from_host_double.
5541         (vlscm_convert_number): Likewise.
5542         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5543         * python/py-value.c (convert_value_from_python): Likewise.
5544
5545 2019-03-06  Tom Tromey  <tom@tromey.com>
5546
5547         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5548
5549 2019-03-06  Tom Tromey  <tom@tromey.com>
5550
5551         * utils.h (free_current_contents): Don't declare.
5552         * utils.c (free_current_contents): Remove.
5553
5554 2019-03-06  Tom Tromey  <tom@tromey.com>
5555
5556         * top.c (quit_force): Update.
5557         * main.c (captured_command_loop): Update.
5558         * common/new-op.c (operator new): Update.
5559         * common/common-exceptions.c (struct catcher)
5560         <save_cleanup_chain>: Remove member.
5561         (exceptions_state_mc_init): Update.
5562         (exception_try_scope_entry): Return nullptr.
5563         (exception_try_scope_exit, exception_rethrow)
5564         (throw_exception_sjlj, throw_exception_cxx): Update.
5565         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5566         (all_cleanups, do_cleanups, discard_cleanups)
5567         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5568         (restore_cleanups, restore_final_cleanups): Don't declare.
5569         (do_final_cleanups): Remove parameter.
5570         * common/cleanups.c (cleanup_chain, make_cleanup)
5571         (make_cleanup_dtor, all_cleanups, do_cleanups)
5572         (discard_my_cleanups, discard_cleanups)
5573         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5574         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5575         (null_cleanup): Remove.
5576         (do_final_cleanups): Remove parameter.
5577
5578 2019-03-06  Tom Tromey  <tom@tromey.com>
5579
5580         * remote.c (remote_target::remote_parse_stop_reply): Use
5581         unique_xmalloc_ptr.
5582
5583 2019-03-06  Tom Tromey  <tom@tromey.com>
5584
5585         * stabsread.c (struct stabs_field_info): Rename from field_info.
5586         <list, fnlist>: Add initializers.
5587         <obstack>: New member.
5588         (read_member_functions, read_struct_fields, read_baseclasses):
5589         Allocate on obstack.  Don't use cleanups.
5590         (read_one_struct_field, read_member_functions, read_struct_fields)
5591         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5592         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5593         (read_struct_type): Update.
5594
5595 2019-03-06  Tom Tromey  <tom@tromey.com>
5596
5597         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5598         * common/filestuff.h (make_cleanup_close): Don't declare.
5599         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5600         Remove.
5601
5602 2019-03-06  Tom Tromey  <tom@tromey.com>
5603
5604         * solib-aix.c: Use make_scope_exit.
5605
5606 2019-03-06  Tom Tromey  <tom@tromey.com>
5607
5608         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5609         Use make_scope_exit.
5610
5611 2019-03-06  Tom Tromey  <tom@tromey.com>
5612
5613         * solib-svr4.c (disable_probes_interface): Remove parameter.
5614         (svr4_handle_solib_event): Use make_scope_exit.
5615
5616 2019-03-06  Tom Tromey  <tom@tromey.com>
5617
5618         * remote.c (struct stop_reply_deleter): Remove.
5619         (stop_reply_up): Update.
5620         (struct stop_reply): Derive from notif_event.  Don't typedef.
5621         <regcache>: Now a std::vector.
5622         (stop_reply_xfree): Remove.
5623         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5624         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5625         (remote_target::discard_pending_stop_replies): Use delete.
5626         (remote_target::remote_parse_stop_reply): Update.
5627         (remote_target::process_stop_reply): Update.
5628         * remote-notif.h (struct notif_event): Add virtual destructor.
5629         Remove "dtr" member.
5630         (struct notif_client) <alloc_event>: Return a unique_ptr.
5631         (notif_event_xfree): Don't declare.
5632         (notif_event_up): New typedef.
5633         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5634         (notif_event_xfree, do_notif_event_xfree): Remove.
5635         (remote_notif_state_xfree): Update.
5636
5637 2019-03-06  Tom Tromey  <tom@tromey.com>
5638
5639         * infrun.c (displaced_step_clear_cleanup): Now a
5640         forward_scope_exit type.
5641         (displaced_step_prepare_throw): Update.
5642         (displaced_step_fixup): Update.
5643
5644 2019-03-06  Tom Tromey  <tom@tromey.com>
5645
5646         * inferior.h (class inferior): Update comment.
5647         * gdbthread.h (class thread_info): Update comment.
5648
5649 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5650             Tom Tromey  <tom@tromey.com>
5651
5652         * stabsread.h (struct stab_section_list): Remove.
5653         (coffstab_build_psymtabs): Update.
5654         * dbxread.c (symbuf_sections): Now a std::vector.
5655         (sect_idx): New global.
5656         (fill_symbuf): Update.
5657         (coffstab_build_psymtabs): Change type of stabsects parameter.
5658         Update.
5659         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5660         std::vector.
5661         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5662         (coff_locate_sections): Update.
5663         (coff_symfile_read): Remove cleanups.  Update.
5664         (init_stringtab): Add storage parameter.
5665         (free_stringtab, free_stringtab_cleanup): Remove.
5666         (init_lineno): Add storage parameter.
5667         (free_linetab, free_linetab_cleanup): Remove.
5668
5669 2019-03-06  Pedro Alves  <palves@redhat.com>
5670
5671         * linux-fork.c (fork_info::clobber_regs): Delete.
5672         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5673         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5674         comment.  Adjust.
5675         (scoped_switch_fork_info::scoped_switch_fork_info)
5676         (checkpoint_command, linux_fork_context): Adjust
5677         fork_save_infrun_state calls.
5678
5679 2019-03-06  Pedro Alves  <palves@redhat.com>
5680
5681         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5682         (inf_has_multiple_threads): Return 'bool' and rewrite using
5683         inferior_info::threads().
5684
5685 2019-03-06  Pedro Alves  <palves@redhat.com>
5686
5687         * linux-fork.c: Include <list>.
5688         (fork_list): Now a std::list instance.
5689         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5690         (forks_exist_p, find_last_fork): Adjust.
5691         (new_fork): Delete.
5692         (one_fork_p): New.
5693         (add_fork): Adjust.
5694         (free_fork): Delete, folded into fork_info::~fork_info().
5695         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5696         Adjust.
5697         (init_fork_list): Delete.
5698         (linux_fork_killall, linux_fork_mourn_inferior)
5699         (linux_fork_detach, info_checkpoints_command): Adjust.
5700         (_initialize_linux_fork): No longer call init_fork_list.
5701
5702 2019-03-06  Pedro Alves  <palves@redhat.com>
5703
5704         * linux-fork.c (new_fork): New, split out of ...
5705         (add_fork): ... this.  Return void.  Move "first fork" special
5706         case from here, to ...
5707         (checkpoint_command): ... here.
5708         * linux-linux.h (add_fork): Return void.
5709
5710 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5711
5712         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5713
5714 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5715             Chris January  <chris.january@arm.com>
5716             David Lecomber  <david.lecomber@arm.com>
5717
5718         * f-exp.y: New token, UNOP_INTRINSIC.
5719         (exp): New pattern using UNOP_INTRINSIC token.
5720         (f77_keywords): Add 'abs' keyword.
5721         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5722         (value_from_host_double): New function.
5723         (evaluate_subexp_f): Support UNOP_ABS.
5724
5725 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5726
5727         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5728         types.
5729
5730 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5731
5732         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5733         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5734         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5735
5736 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5737
5738         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5739
5740 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5741             Chris January  <chris.january@arm.com>
5742
5743         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5744         * f-exp.y: Define 'KIND' token.
5745         (exp): New pattern for KIND expressions.
5746         (ptype): Handle types with a kind extension.
5747         (direct_abs_decl): Extend to spot kind extensions.
5748         (f77_keywords): Add 'kind' to the list.
5749         (push_kind_type): New function.
5750         (convert_to_kind_type): New function.
5751         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5752         * parse.c (operator_length_standard): Likewise.
5753         * parser-defs.h (enum type_pieces): Add tp_kind.
5754         * std-operator.def: Add UNOP_KIND.
5755
5756 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5757
5758         * f-exp.y (f_parse): Set yydebug.
5759
5760 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5761
5762         * f-lang.c (evaluate_subexp_f): New function.
5763         (exp_descriptor_f): New global.
5764         (f_language_defn): Use exp_descriptor_f instead of
5765         exp_descriptor_standard.
5766
5767 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5768
5769         * f-exp.y (struct token): Add comments.
5770         (dot_ops): Remove uppercase versions and the end marker.
5771         (f77_keywords): Likewise.
5772         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5773         entries in the dot_ops array are case insensitive, and use
5774         strncasecmp to compare strings.  Also some whitespace cleanup in
5775         this area.  Similar for the f77_keywords array, except entries in
5776         this list might be case sensitive.
5777
5778 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5779
5780         * f-exp.y (struct f77_boolean_val): Add comments.
5781         (boolean_values): Remove uppercase versions, and end marker.
5782         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5783         and use strncasecmp to achieve case insensitivity.  Additionally,
5784         perform whitespace cleanup around this code.
5785
5786 2019-03-06  Tom Tromey  <tromey@adacore.com>
5787
5788         * remote-sim.c (gdbsim_target_open): Use result of
5789         gdb_argv::release.
5790
5791 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5792         Dirk Schubert  <dirk.schubert@arm.com>
5793         Chris January  <chris.january@arm.com>
5794
5795         * eval.c (evaluate_subexp_standard): Call Fortran argument
5796         wrapping logic.
5797         * f-lang.c (struct value): A value which can be passed into a
5798         Fortran function call.
5799         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5800         where appropriate.
5801         (struct type): Value ready for a Fortran function call.
5802         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5803         is needed.
5804         * f-lang.h (fortran_argument_convert): Declaration.
5805         (fortran_preserve_arg_pointer): Declaration.
5806         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5807
5808 2019-03-05  Tom Tromey  <tromey@adacore.com>
5809
5810         * python/py-prettyprint.c (print_string_repr): Remove #if.
5811         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5812
5813 2019-03-05  Tom Tromey  <tromey@adacore.com>
5814
5815         * target.c (the_dummy_target): Move later.  Change type to
5816         "dummy_target".
5817         (initialize_targets): Don't initialize the_dummy_target.
5818
5819 2019-03-05  Tom Tromey  <tromey@adacore.com>
5820
5821         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5822         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5823
5824 2019-03-05  Tom Tromey  <tromey@adacore.com>
5825
5826         * windows-nat.c (windows_nat_target::attach)
5827         (windows_nat_target::detach): Don't call gdb_flush.
5828         * valprint.c (generic_val_print, val_print, val_print_string):
5829         Don't call gdb_flush.
5830         * utils.c (defaulted_query): Don't call gdb_flush.
5831         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5832         * target.c (target_announce_detach): Don't call gdb_flush.
5833         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5834         * remote.c (extended_remote_target::attach): Don't call
5835         gdb_flush.
5836         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5837         * printcmd.c (do_examine): Don't call gdb_flush.
5838         (info_display_command): Don't call gdb_flush.
5839         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5840         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5841         * memattr.c (info_mem_command): Don't call gdb_flush.
5842         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5843         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5844         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5845         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5846         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5847         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5848         (gnu_nat_target::detach): Don't call gdb_flush.
5849         * f-valprint.c (f_val_print): Don't call gdb_flush.
5850         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5851         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5852         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5853         gdb_flush.
5854         * c-valprint.c (c_val_print): Don't call gdb_flush.
5855         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5856
5857 2019-03-05  Tom Tromey  <tromey@adacore.com>
5858
5859         * varobj.c (update_dynamic_varobj_children): Update.
5860         (install_default_visualizer): Use reset, not release.
5861         * value.c (set_internalvar): Update.
5862         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5863         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5864         ATTRIBUTE_UNUSED_RESULT.
5865
5866 2019-03-05  Tom Tromey  <tromey@adacore.com>
5867
5868         * remote.c (class scoped_remote_fd) <release>: Add
5869         ATTRIBUTE_UNUSED_RESULT.
5870
5871 2019-03-05  Tom Tromey  <tromey@adacore.com>
5872
5873         * macroexp.c (struct macro_buffer) <release>: Add
5874         ATTRIBUTE_UNUSED_RESULT.
5875
5876 2019-03-05  Tom Tromey  <tromey@adacore.com>
5877
5878         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5879         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5880         ATTRIBUTE_UNUSED_RESULT.
5881
5882 2019-03-05  Tom Tromey  <tromey@adacore.com>
5883
5884         * common/scoped_fd.h (class scoped_fd) <release>: Add
5885         ATTRIBUTE_UNUSED_RESULT.
5886
5887 2019-03-05  Tom Tromey  <tromey@adacore.com>
5888
5889         * parser-defs.h (struct parser_state) <release>: Add
5890         ATTRIBUTE_UNUSED_RESULT.
5891
5892 2019-03-05  Tom Tromey  <tromey@adacore.com>
5893
5894         * utils.h (class gdb_argv) <release>: Add
5895         ATTRIBUTE_UNUSED_RESULT.
5896         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5897
5898 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5899
5900         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5901         for-loop range, to avoid compiler warnings.
5902
5903         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5904         avoid compiler warnings about unused variables.
5905
5906         * NEWS: Mention end of support for native debugging on MS-Windows
5907         before XP.
5908
5909         PR gdb/24292
5910         * common/netstuff.c:
5911         * gdbserver/gdbreplay.c
5912         * gdbserver/remote-utils.c:
5913         * ser-tcp.c:
5914         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5915         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5916         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5917         'getaddrinfo' and 'freeaddrinfo' were not available before
5918         Windows XP, and mingw.org's MinGW headers by default define
5919         _WIN32_WINNT to 0x500.
5920
5921 2019-03-01  Gary Benson <gbenson@redhat.com>
5922
5923         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5924
5925 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5926             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5927
5928         PR gdb/8527
5929         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5930         set_sigint_trap, clear_sigint_trap.
5931
5932 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5933
5934         * target.c (target_detach): Clear the regcache and the
5935         frame cache.
5936
5937 2019-02-27  Pedro Alves  <palves@redhat.com>
5938
5939         * utils.c (set_screen_size): When we cap the height/width sizes,
5940         tweak the corresponding command variable to show "unlimited":
5941
5942 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5943             Pedro Alves  <palves@redhat.com>
5944
5945         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5946         before calling rl_set_screen_size.
5947
5948 2019-02-27  Tom Tromey  <tromey@adacore.com>
5949
5950         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5951         define.
5952         * python/py-value.c: Remove Python 2.4 workaround.
5953         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5954         workaround.
5955         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5956         Python 2.4 workaround.
5957         * python/python-internal.h: Remove Python 2.4 comment.
5958         (Py_ssize_t): Don't define.
5959         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5960         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5961         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5962         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5963         * python/python.c (do_start_initialization): Remove Python 2.4
5964         workaround.
5965         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5966         (print_children): Remove Python 2.4 workaround.
5967         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5968         workaround.
5969         (CHARBUFFERPROC_NAME): Remove.
5970         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5971         Python 2.4 workaround.
5972
5973 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5974
5975         * NEWS: Note minimum Python version.
5976
5977 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5978
5979         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5980         code from these functions.  Remove corresponding ifdefs.  Use
5981         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5982         Remove gotos and target of gotos.
5983         (infpy_search_memory): Likewise.
5984
5985 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5986
5987         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5988         (hppa_gdbarch_init): Don't register deleted functions with
5989         gdbarch.
5990
5991 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5992
5993         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5994         (h8300_unwind_sp): Delete.
5995         (h8300_dummy_id): Delete.
5996         (h8300_gdbarch_init): Don't register deleted functions with
5997         gdbarch.
5998
5999 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6000
6001         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6002         (ft32_unwind_pc): Delete.
6003         (ft32_unwind_sp): Delete.
6004         (ft32_gdbarch_init): Don't register deleted functions with
6005         gdbarch.
6006
6007 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6008
6009         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6010         (frv_unwind_pc): Delete.
6011         (frv_unwind_sp): Delete.
6012         (frv_gdbarch_init): Don't register deleted functions with
6013         gdbarch.
6014
6015 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6016
6017         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6018         (riscv_unwind_pc): Delete.
6019         (riscv_unwind_sp): Delete.
6020         (riscv_gdbarch_init): Don't register deleted functions with
6021         gdbarch.
6022
6023 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6024
6025         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6026         (csky_unwind_pc): Delete.
6027         (csky_unwind_sp): Delete.
6028         (csky_gdbarch_init): Don't register deleted functions with
6029         gdbarch.
6030
6031 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6032
6033         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6034         (cris_unwind_pc): Delete.
6035         (cris_unwind_sp): Delete.
6036         (cris_gdbarch_init): Don't register deleted functions with
6037         gdbarch.
6038
6039 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6040
6041         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6042         (bfin_unwind_pc): Delete.
6043         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6044
6045 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6046
6047         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6048         (arm_unwind_pc): Delete.
6049         (arm_unwind_sp): Delete.
6050         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6051
6052 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6053
6054         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6055         (arc_unwind_pc): Delete.
6056         (arc_unwind_sp): Delete.
6057         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6058
6059 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6060
6061         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6062         (alpha_unwind_pc): Delete.
6063         (alpha_gdbarch_init): Don't register deleted functions with
6064         gdbarch.
6065
6066 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6067
6068         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6069         (aarch64_unwind_pc): Delete.
6070         (aarch64_unwind_sp): Delete.
6071         (aarch64_gdbarch_init): Don't register deleted functions with
6072         gdbarch.
6073
6074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6075
6076         * gdbtypes.c (type_align): Don't consider static members when
6077         computing structure alignment.
6078
6079 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6080
6081         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6082         return 0 for other types.
6083         * arch-utils.c (default_type_align): Always return 0.
6084         * gdbarch.h: Regenerate.
6085         * gdbarch.sh (type_align): Extend comment.
6086         * gdbtypes.c (type_align): Add additional comments, always call
6087         gdbarch_type_align before applying the default rules.
6088         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6089         generic code will then apply a suitable default.
6090         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6091         types, return 0 for other types.
6092
6093 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6094
6095         * NEWS: Create a new section for the next release branch.
6096         Rename the section of the current branch, now that it has
6097         been cut.
6098
6099 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6100
6101         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6102         * version.in: Bump version to 8.3.50.DATE-git.
6103
6104 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6105
6106         * aix-thread.c (ptid_cmp): Remove unused variable.
6107         (get_signaled_thread): Likewise.
6108         (store_regs_user_thread): Likewise.
6109         (store_regs_kernel_thread): Likewise.
6110         (fetch_regs_kernel_thread): Remove shadowed variable.
6111
6112 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6113
6114         * features/riscv/32bit-cpu.xml: Add register numbers.
6115         * features/riscv/32bit-fpu.c: Regenerate.
6116         * features/riscv/32bit-fpu.xml: Add register numbers.
6117         * features/riscv/64bit-cpu.xml: Add register numbers.
6118         * features/riscv/64bit-fpu.c: Regenerate.
6119         * features/riscv/64bit-fpu.xml: Add register numbers.
6120
6121 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6122
6123         * NEWS: Mention two argument form of gdb.Value constructor.
6124         * python/py-value.c (convert_buffer_and_type_to_value): New
6125         function.
6126         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6127         Add support for handling an optional second argument.  Call
6128         convert_buffer_and_type_to_value as appropriate.
6129         * python/python-internal.h (Py_buffer_deleter): New struct.
6130         (Py_buffer_up): New typedef.
6131
6132 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6133
6134         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6135         instead of releasing ownership.
6136
6137 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6138
6139         * dwarf2read.c (open_and_init_dwp_file): Call
6140         elf_numsections instead of bfd_count_sections to initialize
6141         dwp_file->num_sections.
6142
6143 2019-02-25  Tom Tromey  <tromey@adacore.com>
6144
6145         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6146
6147 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6148
6149         * gcore.in: Add '--readnever' option when invoking GDB.
6150
6151 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6152
6153         * MAINTAINERS: Update my email address.
6154
6155 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6156
6157         * build-id.c (build_id_to_debug_bfd_1): New function.
6158         (build_id_to_debug_bfd): Look for separate debug file in
6159         sysroot.
6160
6161 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6162
6163         * gdbarch.sh: Update the copyright year range that is placed into
6164         generated files.
6165
6166 2019-02-22  Keith Seitz  <keiths@redhat.com>
6167
6168         PR symtab/23853
6169         * linespec.c (create_sals_line_offset): Search for the default
6170         symtab's filename instead of its fullname.
6171
6172 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6173
6174         * NEWS: Update style defaults.
6175
6176 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6177
6178         * main.c (captured_main_1): Disable styling in batch mode.
6179
6180 2019-02-20  Tom Tromey  <tom@tromey.com>
6181
6182         * symtab.c (symtab_symbol_info): Fix typos.
6183
6184 2019-02-20  Tom Tromey  <tromey@adacore.com>
6185
6186         * findcmd.c (_initialize_mem_search): Use upper case for
6187         metasyntactic variables.
6188
6189 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6190
6191         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6192         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6193
6194 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6195
6196         * top.h (source_file_name): Change to std::string.
6197         * top.c (source_file_name): Likewise.
6198         (command_line_input): Adjust.
6199         * cli/cli-script.c (script_from_file): Adjust.
6200
6201 2019-02-19  Tom Tromey  <tromey@adacore.com>
6202
6203         * ravenscar-thread.c
6204         (ravenscar_thread_target::update_thread_list): Don't call
6205         ada_build_task_list.
6206         * ada-lang.h (ada_build_task_list): Don't declare.
6207         * ada-tasks.c (struct ada_tasks_inferior_data)
6208         <task_list_valid_p>: Now bool.
6209         (read_known_tasks, ada_task_list_changed)
6210         (ada_tasks_invalidate_inferior_data): Update.
6211         (read_known_tasks_array): Return bool.
6212         (read_known_tasks_list): Likewise.
6213         (read_known_tasks): Return void.
6214         (ada_build_task_list): Now static.
6215
6216 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6217
6218         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6219         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6220
6221 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6222
6223         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6224         variant for ada_tasks_pspace_data_handle and
6225         ada_tasks_inferior_data_handle.
6226         (ada_tasks_pspace_data_cleanup): New function.
6227         (ada_tasks_inferior_data_cleanup): New function.
6228
6229 2019-02-17  Tom Tromey  <tom@tromey.com>
6230
6231         * macrotab.h (macro_source_fullname): Return a std::string.
6232         * macrotab.c (macro_include, check_for_redefinition)
6233         (macro_undef, macro_lookup_definition, foreach_macro)
6234         (foreach_macro_in_scope): Update.
6235         (macro_source_fullname): Return a std::string.
6236         * macrocmd.c (show_pp_source_pos): Update.
6237
6238 2019-02-17  Tom Tromey  <tom@tromey.com>
6239
6240         * macrocmd.c (show_pp_source_pos): Style the file names.
6241
6242 2019-02-17  Tom Tromey  <tom@tromey.com>
6243
6244         PR tui/24197:
6245         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6246
6247 2019-02-17  Tom Tromey  <tom@tromey.com>
6248
6249         * ada-lang.c (user_select_syms): Use filtered printing.
6250         * utils.c (wrap_style): New global.
6251         (desired_style): Remove.
6252         (emit_style_escape): Add stream parameter.
6253         (set_output_style, reset_terminal_style, prompt_for_continue):
6254         Update.
6255         (flush_wrap_buffer): Only flush gdb_stdout.
6256         (wrap_here): Set wrap_style.
6257         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6258         treat escape sequences as a character.  Change when wrap buffer is
6259         flushed.
6260         (fputs_styled): Do not set the output style when the default is
6261         requested.
6262         * ui-style.h (struct ui_file_style) <is_default>: New method.
6263         * source.c (print_source_lines_base): Emit escape sequences in one
6264         piece.
6265
6266 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6267
6268         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6269         integers and enumeration types.
6270
6271 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6272
6273         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6274         instead of lookup_symbol_in_language
6275         (do_exact_match): New function.
6276         (ada_get_symbol_name_matcher): Return do_exact_match when
6277         doing a verbatim match.
6278
6279 2019-02-15  Tom Tromey  <tromey@adacore.com>
6280
6281         * ravenscar-thread.c (ravenscar_thread_target::resume)
6282         (ravenscar_thread_target::wait): Special case wildcard requests.
6283
6284 2019-02-15  Tom Tromey  <tromey@adacore.com>
6285
6286         * ravenscar-thread.c (base_ptid): Remove.
6287         (struct ravenscar_thread_target) <close>: New method.
6288         <m_base_ptid>: New member.
6289         <update_inferior_ptid, active_task, task_is_currently_active,
6290         runtime_initialized>: Declare methods.
6291         <ravenscar_thread_target>: Add constructor.
6292         (ravenscar_thread_target::task_is_currently_active)
6293         (ravenscar_thread_target::update_inferior_ptid)
6294         (ravenscar_runtime_initialized): Rename.  Now methods.
6295         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6296         (ravenscar_thread_target::update_thread_list): Update.
6297         (ravenscar_thread_target::active_task): Now method.
6298         (ravenscar_thread_target::store_registers)
6299         (ravenscar_thread_target::prepare_to_store)
6300         (ravenscar_thread_target::prepare_to_store)
6301         (ravenscar_thread_target::mourn_inferior): Update.
6302         (ravenscar_inferior_created): Use "new" to create target.
6303         (ravenscar_thread_target::get_ada_task_ptid): Update.
6304         (_initialize_ravenscar): Don't initialize base_ptid.
6305         (ravenscar_ops): Remove global.
6306
6307 2019-02-15  Tom Tromey  <tromey@adacore.com>
6308
6309         * target.h (push_target): Declare new overload.
6310         * target.c (push_target): New overload, taking an rvalue reference.
6311         * remote.c (remote_target::open_1): Use push_target overload.
6312         * corelow.c (core_target_open): Use push_target overload.
6313
6314 2019-02-15  Tom Tromey  <tromey@adacore.com>
6315
6316         * ravenscar-thread.c (is_ravenscar_task)
6317         (ravenscar_task_is_currently_active): Return bool.
6318         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6319         (_initialize_ravenscar): Remove "(void)".
6320         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6321         Return bool.
6322
6323 2019-02-15  Tom Tromey  <tromey@adacore.com>
6324
6325         * ravenscar-thread.c (ravenscar_runtime_initializer)
6326         (has_ravenscar_runtime, get_running_thread_id)
6327         (ravenscar_thread_target::resume): Fix indentation.
6328
6329 2019-02-15  Tom Tromey  <tromey@adacore.com>
6330
6331         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6332         from ravenscar_arch_ops.
6333         (sparc_ravenscar_ops::fetch_registers)
6334         (sparc_ravenscar_ops::store_registers): Now methods.
6335         (sparc_ravenscar_prepare_to_store): Remove.
6336         (sparc_ravenscar_ops): Redefine.
6337         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6338         methods and destructor.  Remove members.
6339         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6340         (ravenscar_thread_target::store_registers)
6341         (ravenscar_thread_target::prepare_to_store): Update.
6342         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6343         Remove.
6344         (struct ppc_ravenscar_powerpc_ops): Derive from
6345         ravenscar_arch_ops.
6346         (ppc_ravenscar_powerpc_ops::fetch_registers)
6347         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6348         (ppc_ravenscar_powerpc_ops): Redefine.
6349         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6350         (ppc_ravenscar_e500_ops::fetch_registers)
6351         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6352         (ppc_ravenscar_e500_ops): Redefine.
6353         * aarch64-ravenscar-thread.c
6354         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6355         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6356         (aarch64_ravenscar_fetch_registers)
6357         (aarch64_ravenscar_store_registers): Now methods.
6358         (aarch64_ravenscar_ops): Redefine.
6359
6360 2019-02-15  Tom Tromey  <tromey@adacore.com>
6361
6362         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6363         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6364         (ravenscar_thread_target::stopped_by_watchpoint)
6365         (ravenscar_thread_target::stopped_data_address)
6366         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6367
6368 2019-02-15  Tom Tromey  <tromey@adacore.com>
6369
6370         * ravenscar-thread.c: Fix some typos.
6371
6372 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6373             Tom Tromey  <tromey@adacore.com>
6374
6375         * ada-lang.c (ada_exception_sal): Change addr_string to a
6376         std::string.
6377         (create_ada_exception_catchpoint): Update.
6378
6379 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6380             Tom Tromey  <tromey@adacore.com>
6381
6382         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6383         (bp_location_ops): Remove.
6384         (base_breakpoint_allocate_location): Update.
6385         (free_bp_location): Update.
6386         * ada-lang.c (class ada_catchpoint_location)
6387         <ada_catchpoint_location>: Remove ops parameter.
6388         (ada_catchpoint_location_dtor): Remove.
6389         (ada_catchpoint_location_ops): Remove.
6390         (allocate_location_exception): Update.
6391         * breakpoint.h (struct bp_location_ops): Remove.
6392         (class bp_location) <bp_location>: Remove bp_location_ops
6393         parameter.
6394         <~bp_location>: Add destructor.
6395         <ops>: Remove.
6396
6397 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6398             Pedro Alves  <palves@redhat.com>
6399
6400         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6401         'PATH_MAX'.
6402
6403 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6404             Samuel Thibault  <samuel.thibault@gnu.org>
6405             Thomas Schwinge  <thomas@codesourcery.com>
6406
6407         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6408         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6409
6410 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6411
6412         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6413         (check_empty): Use "const char *".
6414
6415         * gnu-nat.c (gnu_nat_target::detach): Instead of
6416         'detach_inferior (pid)' call
6417         'detach_inferior (find_inferior_pid (pid))'.
6418
6419         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6420         'nat/fork-inferior.o'.
6421         * gnu-nat.c: #include "nat/fork-inferior.h".
6422
6423         * gnu-nat.c (gnu_nat_target::detach): Instead of
6424         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6425         * gnu-nat.h: #include "inf-child.h".
6426         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6427         'i386_gnu_nat_target::fetch_registers'.
6428         (gnu_store_registers): Rename/move to
6429         'i386_gnu_nat_target::store_registers'.
6430
6431         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6432         * gnu-nat.h (mach_thread_info): New function.
6433         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6434
6435         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6436
6437 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6438
6439         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6440
6441 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6442
6443         * windows-nat.c (windows_add_thread): Add new parameter
6444         "main_thread_p" with default value set to false.  Update
6445         function documentation as well as all callers.
6446         (windows_delete_thread): Likewise.
6447         (fake_create_process): Update call to windows_add_thread.
6448         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6449         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6450         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6451         call to windows_delete_thread.
6452
6453 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6454
6455         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6456
6457 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6458
6459         * symfile.c (find_separate_debug_file): Use canonical path of
6460         sysroot with child_path instead of gdb_sysroot if it is valid.
6461
6462 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6463
6464         * symfile.c (find_separate_debug_file): Use child_path to
6465         determine if an object file is under a sysroot.
6466
6467 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6468
6469         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6470         unittests/child-path-selftests.c.
6471         * common/pathstuff.c (child_path): New function.
6472         * common/pathstuff.h (child_path): New prototype.
6473         * unittests/child-path-selftests.c: New file.
6474
6475 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6476
6477         * symfile.c (find_separate_debug_file): Look for separate debug
6478         files in debug directories under the sysroot.
6479
6480 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6481
6482         * symtab.h (struct minimal_symbol data_p): New const method.
6483         (struct minimal_symbol text_p): Likewise.
6484         * symtab.c (output_source_filename): Use file name style
6485         to print file name.
6486         (print_symbol_info): Likewise.
6487         (print_msymbol_info): Use address style to print addresses.
6488         Use function name style to print executable text symbols.
6489         (expand_symtab_containing_pc): Use data_p.
6490         (find_pc_sect_compunit_symtab): Likewise.
6491
6492 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6493
6494         * breakpoint.c (describe_other_breakpoints): Use address style
6495         to print addresses.
6496         (say_where): Likewise.
6497
6498 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6499
6500         * ada-typeprint.c (print_func_type): Print function name
6501         style to print function name.
6502         * c-typeprint.c (c_print_type_1): Likewise.
6503
6504 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6505
6506         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6507         for execve.
6508
6509 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6510
6511         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6512         type_stack.
6513
6514 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6515
6516         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6517         TYPE_CODE_REF types.
6518
6519 2019-02-08  Jim Wilson  <jimw@sifive.com>
6520
6521         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6522         (riscv_linux_fregset): New.
6523         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6524
6525 2019-02-07  Tom Tromey  <tom@tromey.com>
6526
6527         * thread.c (thread_cancel_execution_command): Update.
6528         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6529         methods.
6530         (struct thread_fsm_ops): Remove.
6531         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6532         (thread_fsm_should_stop, thread_fsm_return_value)
6533         (thread_fsm_set_finished, thread_fsm_finished_p)
6534         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6535         Don't declare.
6536         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6537         * infrun.c (clear_proceed_status_thread)
6538         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6539         (print_stop_event): Update.
6540         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6541         Add constructor.
6542         (step_command_fsm_ops): Remove.
6543         (new_step_command_fsm): Remove.
6544         (step_1): Update.
6545         (step_command_fsm::should_stop): Rename from
6546         step_command_fsm_should_stop.
6547         (step_command_fsm::clean_up): Rename from
6548         step_command_fsm_clean_up.
6549         (step_command_fsm::do_async_reply_reason): Rename from
6550         step_command_fsm_async_reply_reason.
6551         (struct until_next_fsm): Inherit from thread_fsm.  Add
6552         constructor.
6553         (until_next_fsm_ops): Remove.
6554         (new_until_next_fsm): Remove.
6555         (until_next_fsm::should_stop): Rename from
6556         until_next_fsm_should_stop.
6557         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6558         (until_next_fsm::do_async_reply_reason): Rename from
6559         until_next_fsm_async_reply_reason.
6560         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6561         constructor.  Change type of breakpoint.
6562         (finish_command_fsm_ops): Remove.
6563         (new_finish_command_fsm): Remove.
6564         (finish_command_fsm::should_stop): Rename from
6565         finish_command_fsm_should_stop.
6566         (finish_command_fsm::clean_up): Rename from
6567         finish_command_fsm_clean_up.
6568         (finish_command_fsm::return_value): Rename from
6569         finish_command_fsm_return_value.
6570         (finish_command_fsm::do_async_reply_reason): Rename from
6571         finish_command_fsm_async_reply_reason.
6572         (finish_command): Update.
6573         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6574         Add constructor.
6575         (call_thread_fsm_ops): Remove.
6576         (call_thread_fsm::call_thread_fsm): Rename from
6577         new_call_thread_fsm.
6578         (call_thread_fsm::should_stop): Rename from
6579         call_thread_fsm_should_stop.
6580         (call_thread_fsm::should_notify_stop): Rename from
6581         call_thread_fsm_should_notify_stop.
6582         (run_inferior_call, call_function_by_hand_dummy): Update.
6583         * cli/cli-interp.c (should_print_stop_to_console): Update.
6584         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6585         Add constructor.  Change type of location_breakpoint,
6586         caller_breakpoint.
6587         (until_break_fsm_ops): Remove.
6588         (new_until_break_fsm): Remove.
6589         (until_break_fsm::should_stop): Rename from
6590         until_break_fsm_should_stop.
6591         (until_break_fsm::clean_up): Rename from
6592         until_break_fsm_clean_up.
6593         (until_break_fsm::do_async_reply_reason): Rename from
6594         until_break_fsm_async_reply_reason.
6595         (until_break_command): Update.
6596         * thread-fsm.c: Remove.
6597         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6598
6599 2019-02-07  Tom Tromey  <tom@tromey.com>
6600
6601         * yy-remap.h: Add include guard.
6602         * xtensa-tdep.h: Add include guard.
6603         * xcoffread.h: Rename include guard.
6604         * varobj-iter.h: Add include guard.
6605         * tui/tui.h: Rename include guard.
6606         * tui/tui-winsource.h: Rename include guard.
6607         * tui/tui-wingeneral.h: Rename include guard.
6608         * tui/tui-windata.h: Rename include guard.
6609         * tui/tui-win.h: Rename include guard.
6610         * tui/tui-stack.h: Rename include guard.
6611         * tui/tui-source.h: Rename include guard.
6612         * tui/tui-regs.h: Rename include guard.
6613         * tui/tui-out.h: Rename include guard.
6614         * tui/tui-layout.h: Rename include guard.
6615         * tui/tui-io.h: Rename include guard.
6616         * tui/tui-hooks.h: Rename include guard.
6617         * tui/tui-file.h: Rename include guard.
6618         * tui/tui-disasm.h: Rename include guard.
6619         * tui/tui-data.h: Rename include guard.
6620         * tui/tui-command.h: Rename include guard.
6621         * tic6x-tdep.h: Add include guard.
6622         * target/waitstatus.h: Rename include guard.
6623         * target/wait.h: Rename include guard.
6624         * target/target.h: Rename include guard.
6625         * target/resume.h: Rename include guard.
6626         * target-float.h: Rename include guard.
6627         * stabsread.h: Add include guard.
6628         * rs6000-tdep.h: Add include guard.
6629         * riscv-fbsd-tdep.h: Add include guard.
6630         * regformats/regdef.h: Rename include guard.
6631         * record.h: Rename include guard.
6632         * python/python.h: Rename include guard.
6633         * python/python-internal.h: Rename include guard.
6634         * python/py-stopevent.h: Rename include guard.
6635         * python/py-ref.h: Rename include guard.
6636         * python/py-record.h: Rename include guard.
6637         * python/py-record-full.h: Rename include guard.
6638         * python/py-record-btrace.h: Rename include guard.
6639         * python/py-instruction.h: Rename include guard.
6640         * python/py-events.h: Rename include guard.
6641         * python/py-event.h: Rename include guard.
6642         * procfs.h: Add include guard.
6643         * proc-utils.h: Add include guard.
6644         * p-lang.h: Add include guard.
6645         * or1k-tdep.h: Rename include guard.
6646         * observable.h: Rename include guard.
6647         * nto-tdep.h: Rename include guard.
6648         * nat/x86-linux.h: Rename include guard.
6649         * nat/x86-linux-dregs.h: Rename include guard.
6650         * nat/x86-gcc-cpuid.h: Add include guard.
6651         * nat/x86-dregs.h: Rename include guard.
6652         * nat/x86-cpuid.h: Rename include guard.
6653         * nat/ppc-linux.h: Rename include guard.
6654         * nat/mips-linux-watch.h: Rename include guard.
6655         * nat/linux-waitpid.h: Rename include guard.
6656         * nat/linux-ptrace.h: Rename include guard.
6657         * nat/linux-procfs.h: Rename include guard.
6658         * nat/linux-osdata.h: Rename include guard.
6659         * nat/linux-nat.h: Rename include guard.
6660         * nat/linux-namespaces.h: Rename include guard.
6661         * nat/linux-btrace.h: Rename include guard.
6662         * nat/glibc_thread_db.h: Rename include guard.
6663         * nat/gdb_thread_db.h: Rename include guard.
6664         * nat/gdb_ptrace.h: Rename include guard.
6665         * nat/fork-inferior.h: Rename include guard.
6666         * nat/amd64-linux-siginfo.h: Rename include guard.
6667         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6668         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6669         * nat/aarch64-linux.h: Rename include guard.
6670         * nat/aarch64-linux-hw-point.h: Rename include guard.
6671         * mn10300-tdep.h: Add include guard.
6672         * mips-linux-tdep.h: Add include guard.
6673         * mi/mi-parse.h: Rename include guard.
6674         * mi/mi-out.h: Rename include guard.
6675         * mi/mi-main.h: Rename include guard.
6676         * mi/mi-interp.h: Rename include guard.
6677         * mi/mi-getopt.h: Rename include guard.
6678         * mi/mi-console.h: Rename include guard.
6679         * mi/mi-common.h: Rename include guard.
6680         * mi/mi-cmds.h: Rename include guard.
6681         * mi/mi-cmd-break.h: Rename include guard.
6682         * m2-lang.h: Add include guard.
6683         * location.h: Rename include guard.
6684         * linux-record.h: Rename include guard.
6685         * linux-nat.h: Add include guard.
6686         * linux-fork.h: Add include guard.
6687         * i386-darwin-tdep.h: Rename include guard.
6688         * hppa-linux-offsets.h: Add include guard.
6689         * guile/guile.h: Rename include guard.
6690         * guile/guile-internal.h: Rename include guard.
6691         * gnu-nat.h: Rename include guard.
6692         * gdb-stabs.h: Rename include guard.
6693         * frv-tdep.h: Add include guard.
6694         * f-lang.h: Add include guard.
6695         * event-loop.h: Add include guard.
6696         * darwin-nat.h: Rename include guard.
6697         * cp-abi.h: Rename include guard.
6698         * config/sparc/nm-sol2.h: Rename include guard.
6699         * config/nm-nto.h: Rename include guard.
6700         * config/nm-linux.h: Add include guard.
6701         * config/i386/nm-i386gnu.h: Rename include guard.
6702         * config/djgpp/nl_types.h: Rename include guard.
6703         * config/djgpp/langinfo.h: Rename include guard.
6704         * compile/gcc-cp-plugin.h: Add include guard.
6705         * compile/gcc-c-plugin.h: Add include guard.
6706         * compile/compile.h: Rename include guard.
6707         * compile/compile-object-run.h: Rename include guard.
6708         * compile/compile-object-load.h: Rename include guard.
6709         * compile/compile-internal.h: Rename include guard.
6710         * compile/compile-cplus.h: Rename include guard.
6711         * compile/compile-c.h: Rename include guard.
6712         * common/xml-utils.h: Rename include guard.
6713         * common/x86-xstate.h: Rename include guard.
6714         * common/version.h: Rename include guard.
6715         * common/vec.h: Rename include guard.
6716         * common/tdesc.h: Rename include guard.
6717         * common/selftest.h: Rename include guard.
6718         * common/scoped_restore.h: Rename include guard.
6719         * common/scoped_mmap.h: Rename include guard.
6720         * common/scoped_fd.h: Rename include guard.
6721         * common/safe-iterator.h: Rename include guard.
6722         * common/run-time-clock.h: Rename include guard.
6723         * common/refcounted-object.h: Rename include guard.
6724         * common/queue.h: Rename include guard.
6725         * common/ptid.h: Rename include guard.
6726         * common/print-utils.h: Rename include guard.
6727         * common/preprocessor.h: Rename include guard.
6728         * common/pathstuff.h: Rename include guard.
6729         * common/observable.h: Rename include guard.
6730         * common/netstuff.h: Rename include guard.
6731         * common/job-control.h: Rename include guard.
6732         * common/host-defs.h: Rename include guard.
6733         * common/gdb_wait.h: Rename include guard.
6734         * common/gdb_vecs.h: Rename include guard.
6735         * common/gdb_unlinker.h: Rename include guard.
6736         * common/gdb_unique_ptr.h: Rename include guard.
6737         * common/gdb_tilde_expand.h: Rename include guard.
6738         * common/gdb_sys_time.h: Rename include guard.
6739         * common/gdb_string_view.h: Rename include guard.
6740         * common/gdb_splay_tree.h: Rename include guard.
6741         * common/gdb_setjmp.h: Rename include guard.
6742         * common/gdb_ref_ptr.h: Rename include guard.
6743         * common/gdb_optional.h: Rename include guard.
6744         * common/gdb_locale.h: Rename include guard.
6745         * common/gdb_assert.h: Rename include guard.
6746         * common/filtered-iterator.h: Rename include guard.
6747         * common/filestuff.h: Rename include guard.
6748         * common/fileio.h: Rename include guard.
6749         * common/environ.h: Rename include guard.
6750         * common/common-utils.h: Rename include guard.
6751         * common/common-types.h: Rename include guard.
6752         * common/common-regcache.h: Rename include guard.
6753         * common/common-inferior.h: Rename include guard.
6754         * common/common-gdbthread.h: Rename include guard.
6755         * common/common-exceptions.h: Rename include guard.
6756         * common/common-defs.h: Rename include guard.
6757         * common/common-debug.h: Rename include guard.
6758         * common/cleanups.h: Rename include guard.
6759         * common/buffer.h: Rename include guard.
6760         * common/btrace-common.h: Rename include guard.
6761         * common/break-common.h: Rename include guard.
6762         * cli/cli-utils.h: Rename include guard.
6763         * cli/cli-style.h: Rename include guard.
6764         * cli/cli-setshow.h: Rename include guard.
6765         * cli/cli-script.h: Rename include guard.
6766         * cli/cli-interp.h: Rename include guard.
6767         * cli/cli-decode.h: Rename include guard.
6768         * cli/cli-cmds.h: Rename include guard.
6769         * charset-list.h: Add include guard.
6770         * buildsym-legacy.h: Rename include guard.
6771         * bfin-tdep.h: Add include guard.
6772         * ax.h: Rename include guard.
6773         * arm-linux-tdep.h: Add include guard.
6774         * arm-fbsd-tdep.h: Add include guard.
6775         * arch/xtensa.h: Rename include guard.
6776         * arch/tic6x.h: Add include guard.
6777         * arch/i386.h: Add include guard.
6778         * arch/arm.h: Rename include guard.
6779         * arch/arm-linux.h: Rename include guard.
6780         * arch/arm-get-next-pcs.h: Rename include guard.
6781         * arch/amd64.h: Add include guard.
6782         * arch/aarch64-insn.h: Rename include guard.
6783         * arch-utils.h: Rename include guard.
6784         * annotate.h: Add include guard.
6785         * amd64-darwin-tdep.h: Rename include guard.
6786         * aarch64-linux-tdep.h: Add include guard.
6787         * aarch64-fbsd-tdep.h: Add include guard.
6788         * aarch32-linux-nat.h: Add include guard.
6789
6790 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6791
6792         * macrotab.c (macro_define_internal): New function that
6793         factorizes macro_define_object_internal and macro_define_function
6794         code.
6795         (macro_define_object_internal): Use macro_define_internal.
6796         (macro_define_function): Likewise.
6797
6798 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6799
6800         * macrocmd.c (extract_identifier): Return
6801         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6802         callers.
6803
6804 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6805
6806         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6807
6808 2019-02-05  Tom Tromey  <tom@tromey.com>
6809
6810         * target.c (target_stack::unpush): Move assertion earlier.
6811
6812 2019-01-30  Tom Tromey  <tom@tromey.com>
6813
6814         PR python/23615:
6815         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6816         (gdbpy_parse_and_eval): Likewise.
6817         * python/python-internal.h (gdbpy_allow_threads): New class.
6818
6819 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6820
6821         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6822         (aarch64_fbsd_fpregmap): Move earlier.
6823         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6824         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6825         instead of individual calls to trad_frame_set_reg_addr.
6826         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6827         earlier.
6828         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6829         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6830         instead of individual calls to trad_frame_set_reg_addr.
6831
6832 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6833
6834         * CONTRIBUTE: Replace contribution list with wiki link.
6835
6836 2019-01-25  Tom Tromey  <tom@tromey.com>
6837
6838         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6839
6840 2019-01-25  Tom Tromey  <tom@tromey.com>
6841
6842         * xtensa-linux-nat.c: Fix common/ includes.
6843         * xml-support.h: Fix common/ includes.
6844         * xml-support.c: Fix common/ includes.
6845         * x86-linux-nat.c: Fix common/ includes.
6846         * windows-nat.c: Fix common/ includes.
6847         * varobj.h: Fix common/ includes.
6848         * varobj.c: Fix common/ includes.
6849         * value.c: Fix common/ includes.
6850         * valops.c: Fix common/ includes.
6851         * utils.c: Fix common/ includes.
6852         * unittests/xml-utils-selftests.c: Fix common/ includes.
6853         * unittests/utils-selftests.c: Fix common/ includes.
6854         * unittests/unpack-selftests.c: Fix common/ includes.
6855         * unittests/tracepoint-selftests.c: Fix common/ includes.
6856         * unittests/style-selftests.c: Fix common/ includes.
6857         * unittests/string_view-selftests.c: Fix common/ includes.
6858         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6859         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6860         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6861         * unittests/rsp-low-selftests.c: Fix common/ includes.
6862         * unittests/parse-connection-spec-selftests.c: Fix common/
6863         includes.
6864         * unittests/optional-selftests.c: Fix common/ includes.
6865         * unittests/offset-type-selftests.c: Fix common/ includes.
6866         * unittests/observable-selftests.c: Fix common/ includes.
6867         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6868         * unittests/memrange-selftests.c: Fix common/ includes.
6869         * unittests/memory-map-selftests.c: Fix common/ includes.
6870         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6871         * unittests/function-view-selftests.c: Fix common/ includes.
6872         * unittests/environ-selftests.c: Fix common/ includes.
6873         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6874         * unittests/common-utils-selftests.c: Fix common/ includes.
6875         * unittests/cli-utils-selftests.c: Fix common/ includes.
6876         * unittests/array-view-selftests.c: Fix common/ includes.
6877         * ui-file.c: Fix common/ includes.
6878         * tui/tui-io.c: Fix common/ includes.
6879         * tracepoint.h: Fix common/ includes.
6880         * tracepoint.c: Fix common/ includes.
6881         * tracefile-tfile.c: Fix common/ includes.
6882         * top.h: Fix common/ includes.
6883         * top.c: Fix common/ includes.
6884         * thread.c: Fix common/ includes.
6885         * target/waitstatus.h: Fix common/ includes.
6886         * target/waitstatus.c: Fix common/ includes.
6887         * target.h: Fix common/ includes.
6888         * target.c: Fix common/ includes.
6889         * target-memory.c: Fix common/ includes.
6890         * target-descriptions.c: Fix common/ includes.
6891         * symtab.h: Fix common/ includes.
6892         * symfile.c: Fix common/ includes.
6893         * stap-probe.c: Fix common/ includes.
6894         * spu-linux-nat.c: Fix common/ includes.
6895         * sparc-nat.c: Fix common/ includes.
6896         * source.c: Fix common/ includes.
6897         * solib.c: Fix common/ includes.
6898         * solib-target.c: Fix common/ includes.
6899         * ser-unix.c: Fix common/ includes.
6900         * ser-tcp.c: Fix common/ includes.
6901         * ser-pipe.c: Fix common/ includes.
6902         * ser-base.c: Fix common/ includes.
6903         * selftest-arch.c: Fix common/ includes.
6904         * s12z-tdep.c: Fix common/ includes.
6905         * rust-exp.y: Fix common/ includes.
6906         * rs6000-aix-tdep.c: Fix common/ includes.
6907         * riscv-tdep.c: Fix common/ includes.
6908         * remote.c: Fix common/ includes.
6909         * remote-notif.h: Fix common/ includes.
6910         * remote-fileio.h: Fix common/ includes.
6911         * remote-fileio.c: Fix common/ includes.
6912         * regcache.h: Fix common/ includes.
6913         * regcache.c: Fix common/ includes.
6914         * record-btrace.c: Fix common/ includes.
6915         * python/python.c: Fix common/ includes.
6916         * python/py-type.c: Fix common/ includes.
6917         * python/py-inferior.c: Fix common/ includes.
6918         * progspace.h: Fix common/ includes.
6919         * producer.c: Fix common/ includes.
6920         * procfs.c: Fix common/ includes.
6921         * proc-api.c: Fix common/ includes.
6922         * printcmd.c: Fix common/ includes.
6923         * ppc-linux-nat.c: Fix common/ includes.
6924         * parser-defs.h: Fix common/ includes.
6925         * osdata.c: Fix common/ includes.
6926         * obsd-nat.c: Fix common/ includes.
6927         * nat/x86-linux.c: Fix common/ includes.
6928         * nat/x86-linux-dregs.c: Fix common/ includes.
6929         * nat/x86-dregs.h: Fix common/ includes.
6930         * nat/x86-dregs.c: Fix common/ includes.
6931         * nat/ppc-linux.c: Fix common/ includes.
6932         * nat/mips-linux-watch.h: Fix common/ includes.
6933         * nat/mips-linux-watch.c: Fix common/ includes.
6934         * nat/linux-waitpid.c: Fix common/ includes.
6935         * nat/linux-ptrace.h: Fix common/ includes.
6936         * nat/linux-ptrace.c: Fix common/ includes.
6937         * nat/linux-procfs.c: Fix common/ includes.
6938         * nat/linux-personality.c: Fix common/ includes.
6939         * nat/linux-osdata.c: Fix common/ includes.
6940         * nat/linux-namespaces.c: Fix common/ includes.
6941         * nat/linux-btrace.h: Fix common/ includes.
6942         * nat/linux-btrace.c: Fix common/ includes.
6943         * nat/fork-inferior.c: Fix common/ includes.
6944         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6945         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6946         * nat/aarch64-linux.c: Fix common/ includes.
6947         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6948         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6949         * namespace.h: Fix common/ includes.
6950         * mips-linux-tdep.c: Fix common/ includes.
6951         * minsyms.c: Fix common/ includes.
6952         * mi/mi-parse.h: Fix common/ includes.
6953         * mi/mi-main.c: Fix common/ includes.
6954         * mi/mi-cmd-env.c: Fix common/ includes.
6955         * memrange.h: Fix common/ includes.
6956         * memattr.c: Fix common/ includes.
6957         * maint.h: Fix common/ includes.
6958         * maint.c: Fix common/ includes.
6959         * main.c: Fix common/ includes.
6960         * machoread.c: Fix common/ includes.
6961         * location.c: Fix common/ includes.
6962         * linux-thread-db.c: Fix common/ includes.
6963         * linux-nat.c: Fix common/ includes.
6964         * linux-fork.c: Fix common/ includes.
6965         * inline-frame.c: Fix common/ includes.
6966         * infrun.c: Fix common/ includes.
6967         * inflow.c: Fix common/ includes.
6968         * inferior.h: Fix common/ includes.
6969         * inferior.c: Fix common/ includes.
6970         * infcmd.c: Fix common/ includes.
6971         * inf-ptrace.c: Fix common/ includes.
6972         * inf-child.c: Fix common/ includes.
6973         * ia64-linux-nat.c: Fix common/ includes.
6974         * i387-tdep.c: Fix common/ includes.
6975         * i386-tdep.c: Fix common/ includes.
6976         * i386-linux-tdep.c: Fix common/ includes.
6977         * i386-linux-nat.c: Fix common/ includes.
6978         * i386-go32-tdep.c: Fix common/ includes.
6979         * i386-fbsd-tdep.c: Fix common/ includes.
6980         * i386-fbsd-nat.c: Fix common/ includes.
6981         * guile/scm-type.c: Fix common/ includes.
6982         * guile/guile.c: Fix common/ includes.
6983         * go32-nat.c: Fix common/ includes.
6984         * gnu-nat.c: Fix common/ includes.
6985         * gdbthread.h: Fix common/ includes.
6986         * gdbarch-selftests.c: Fix common/ includes.
6987         * gdb_usleep.c: Fix common/ includes.
6988         * gdb_select.h: Fix common/ includes.
6989         * gdb_bfd.c: Fix common/ includes.
6990         * gcore.c: Fix common/ includes.
6991         * fork-child.c: Fix common/ includes.
6992         * findvar.c: Fix common/ includes.
6993         * fbsd-nat.c: Fix common/ includes.
6994         * event-top.c: Fix common/ includes.
6995         * event-loop.c: Fix common/ includes.
6996         * dwarf2read.c: Fix common/ includes.
6997         * dwarf2loc.c: Fix common/ includes.
6998         * dwarf2-frame.c: Fix common/ includes.
6999         * dwarf-index-cache.c: Fix common/ includes.
7000         * dtrace-probe.c: Fix common/ includes.
7001         * disasm-selftests.c: Fix common/ includes.
7002         * defs.h: Fix common/ includes.
7003         * csky-tdep.c: Fix common/ includes.
7004         * cp-valprint.c: Fix common/ includes.
7005         * cp-support.h: Fix common/ includes.
7006         * cp-support.c: Fix common/ includes.
7007         * corelow.c: Fix common/ includes.
7008         * completer.h: Fix common/ includes.
7009         * completer.c: Fix common/ includes.
7010         * compile/compile.c: Fix common/ includes.
7011         * compile/compile-loc2c.c: Fix common/ includes.
7012         * compile/compile-cplus-types.c: Fix common/ includes.
7013         * compile/compile-cplus-symbols.c: Fix common/ includes.
7014         * command.h: Fix common/ includes.
7015         * cli/cli-dump.c: Fix common/ includes.
7016         * cli/cli-cmds.c: Fix common/ includes.
7017         * charset.c: Fix common/ includes.
7018         * build-id.c: Fix common/ includes.
7019         * btrace.h: Fix common/ includes.
7020         * btrace.c: Fix common/ includes.
7021         * breakpoint.h: Fix common/ includes.
7022         * breakpoint.c: Fix common/ includes.
7023         * ax.h:
7024         (enum agent_op): Fix common/ includes.
7025         * ax-general.c (struct aop_map): Fix common/ includes.
7026         * ax-gdb.c: Fix common/ includes.
7027         * auxv.c: Fix common/ includes.
7028         * auto-load.c: Fix common/ includes.
7029         * arm-tdep.c: Fix common/ includes.
7030         * arch/riscv.c: Fix common/ includes.
7031         * arch/ppc-linux-common.c: Fix common/ includes.
7032         * arch/i386.c: Fix common/ includes.
7033         * arch/arm.c: Fix common/ includes.
7034         * arch/arm-linux.c: Fix common/ includes.
7035         * arch/arm-get-next-pcs.c: Fix common/ includes.
7036         * arch/amd64.c: Fix common/ includes.
7037         * arch/aarch64.c: Fix common/ includes.
7038         * arch/aarch64-insn.c: Fix common/ includes.
7039         * arch-utils.c: Fix common/ includes.
7040         * amd64-windows-tdep.c: Fix common/ includes.
7041         * amd64-tdep.c: Fix common/ includes.
7042         * amd64-sol2-tdep.c: Fix common/ includes.
7043         * amd64-obsd-tdep.c: Fix common/ includes.
7044         * amd64-nbsd-tdep.c: Fix common/ includes.
7045         * amd64-linux-tdep.c: Fix common/ includes.
7046         * amd64-linux-nat.c: Fix common/ includes.
7047         * amd64-fbsd-tdep.c: Fix common/ includes.
7048         * amd64-fbsd-nat.c: Fix common/ includes.
7049         * amd64-dicos-tdep.c: Fix common/ includes.
7050         * amd64-darwin-tdep.c: Fix common/ includes.
7051         * agent.c: Fix common/ includes.
7052         * ada-lang.h: Fix common/ includes.
7053         * ada-lang.c: Fix common/ includes.
7054         * aarch64-tdep.c: Fix common/ includes.
7055
7056 2019-01-25  Tom Tromey  <tom@tromey.com>
7057
7058         * common/create-version.sh: Use common/version.h.
7059
7060 2019-01-24  Pedro Alves  <palves@redhat.com>
7061
7062         * infrun.c (signal_stop, signal_print, signal_program)
7063         (signal_catch, signal_pass): Now arrays instead of pointers.
7064         (update_signals_program_target, do_target_resume)
7065         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7066         * linux-nat.c (linux_nat_target::pass_signals)
7067         (linux_nat_target::create_inferior, linux_nat_target::attach):
7068         Adjust.
7069         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7070         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7071         * procfs.c (procfs_target::pass_signals): Adjust.
7072         * record-full.c (record_full_target::resume): Adjust.
7073         * remote.c (remote_target::pass_signals)
7074         (remote_target::program_signals): Adjust.
7075         * target-debug.h (target_debug_print_signals): Now takes a
7076         gdb::array_view as parameter.  Adjust.
7077         * target.h (target_ops) <pass_signals, program_signals>: Replace
7078         pointer and length parameters with gdb::array_view.
7079         (target_pass_signals, target_program_signals): Likewise.
7080         * target-delegates.c: Regenerate.
7081
7082 2019-01-24  Pedro Alves  <palves@redhat.com>
7083
7084         * common/forward-scope-exit.h
7085         (forward_scope_exit::forward_scope_exit): Pass arguments to
7086         m_bind_function directly, instead of creating a std::bind and
7087         copying that.
7088
7089 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7090
7091         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7092         for static members.
7093         (pass_in_v_vfp_candidate): Likewise.
7094
7095 2019-01-23  Tom Tromey  <tom@tromey.com>
7096             Pedro Alves  <palves@redhat.com>
7097
7098         * regcache.c (class regcache_invalidator): Remove.
7099         (regcache::raw_write): Use make_scope_exit.
7100
7101 2019-01-23  Tom Tromey  <tom@tromey.com>
7102
7103         * ui-out.h (class ui_out_emit_type): Update comment.
7104
7105 2019-01-23  Tom Tromey  <tom@tromey.com>
7106
7107         * infrun.c (fetch_inferior_event): Update comment.
7108
7109 2019-01-23  Tom Tromey  <tom@tromey.com>
7110             Pedro Alves  <palves@redhat.com>
7111
7112         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7113         parameter.
7114         (fetch_inferior_event): Use SCOPE_EXIT.
7115
7116
7117 2019-01-23  Tom Tromey  <tom@tromey.com>
7118             Pedro Alves  <palves@redhat.com>
7119
7120         * infrun.c (disable_thread_events): Delete.
7121         (stop_all_threads): Use SCOPE_EXIT.
7122
7123 2019-01-23  Tom Tromey  <tom@tromey.com>
7124             Pedro Alves  <palves@redhat.com>
7125
7126         * symfile.c: Include forward-scope-exit.h.
7127         (clear_symtab_users_cleanup): Replace forward declaration with
7128         a FORWARD_SCOPE_EXIT.
7129         (syms_from_objfile_1): Use the forward_scope_exit and
7130         gdb::optional instead of cleanup_function.
7131         (reread_symbols): Use the forward_scope_exit instead of
7132         cleanup_function.
7133         (clear_symtab_users_cleanup): Remove function.
7134
7135 2019-01-23  Tom Tromey  <tom@tromey.com>
7136             Pedro Alves  <palves@redhat.com>
7137
7138         * linux-nat.c: Include scope-exit.h.
7139         (cleanup_target_stop): Remove.
7140         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7141         SCOPE_EXIT.
7142
7143 2019-01-23  Tom Tromey  <tom@tromey.com>
7144             Pedro Alves  <palves@redhat.com>
7145
7146         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7147         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7148
7149 2019-01-23  Tom Tromey  <tom@tromey.com>
7150             Andrew Burgess  <andrew.burgess@embecosm.com>
7151             Pedro Alves  <palves@redhat.com>
7152
7153         * infrun.c (fetch_inferior_event): Use scope_exit.
7154         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7155         * top.c (execute_command): Use scope_exit.
7156         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7157         * utils.c (do_bpstat_clear_actions_cleanup)
7158         (make_bpstat_clear_actions_cleanup): Remove.
7159
7160 2019-01-23  Tom Tromey  <tom@tromey.com>
7161             Pedro Alves  <palves@redhat.com>
7162
7163         * infrun.c: Include "common/scope-exit.h"
7164         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7165         (wait_for_inferior): Use SCOPE_EXIT.
7166         (fetch_inferior_event): Use scope_exit.
7167
7168 2019-01-23  Tom Tromey  <tom@tromey.com>
7169             Pedro Alves  <palves@redhat.com>
7170
7171         * breakpoint.c (create_breakpoint): Remove cleanup.
7172
7173 2019-01-23  Tom Tromey  <tom@tromey.com>
7174             Andrew Burgess  <andrew.burgess@embecosm.com>
7175             Pedro Alves  <palves@redhat.com>
7176
7177 2019-01-23  Pedro Alves  <palves@redhat.com>
7178
7179         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7180
7181 2019-01-23  Pedro Alves  <palves@redhat.com>
7182             Andrew Burgess  <andrew.burgess@embecosm.com>
7183
7184         * gdbthread.h: Include "common/forward-scope-exit.h".
7185         (scoped_finish_thread_state): Redefine custom class in terms of
7186         forward_scope_exit.
7187
7188 2019-01-23  Pedro Alves  <palves@redhat.com>
7189             Andrew Burgess  <andrew.burgess@embecosm.com>
7190
7191         * common/forward-scope-exit.h: New file.
7192
7193 2019-01-23  Pedro Alves  <palves@redhat.com>
7194             Andrew Burgess  <andrew.burgess@embecosm.com>
7195             Tom Tromey  <tom@tromey.com>
7196
7197         * common/scope-exit.h: New file.
7198
7199 2019-01-23  Pedro Alves  <palves@redhat.com>
7200
7201         * common/preprocessor.h (ESC): Rename to ...
7202         (ESC_PARENS): ... this.
7203         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7204         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7205
7206 2019-01-23  Tom Tromey  <tom@tromey.com>
7207
7208         * language.h (class scoped_switch_to_sym_language_if_auto):
7209         Initialize m_lang in both cases.
7210
7211 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7212
7213         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7214         with XCNEW.
7215
7216 2019-01-22  Tom Tromey  <tom@tromey.com>
7217
7218         * corelow.c: Do not include sys/file.h.
7219
7220 2019-01-22  Tom Tromey  <tom@tromey.com>
7221
7222         * tui/tui-wingeneral.h: Include gdb_curses.h.
7223
7224 2019-01-22  Tom Tromey  <tom@tromey.com>
7225
7226         * source-cache.h (class source_cache) <get_source_lines,
7227         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7228
7229 2019-01-22  Tom Tromey  <tom@tromey.com>
7230
7231         * remote-fileio.h (struct remote_target): Declare.
7232
7233 2019-01-22  Tom Tromey  <tom@tromey.com>
7234
7235         * python/py-arch.c: Do not include py-ref.h.
7236         * python/py-bpevent.c: Do not include py-ref.h.
7237         * python/py-cmd.c: Do not include py-ref.h.
7238         * python/py-continueevent.c: Do not include py-ref.h.
7239         * python/py-event.h: Do not include py-ref.h.
7240         * python/py-evtregistry.c: Do not include py-ref.h.
7241         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7242         * python/py-frame.c: Do not include py-ref.h.
7243         * python/py-framefilter.c: Do not include py-ref.h.
7244         * python/py-function.c: Do not include py-ref.h.
7245         * python/py-infevents.c: Do not include py-ref.h.
7246         * python/py-linetable.c: Do not include py-ref.h.
7247         * python/py-objfile.c: Do not include py-ref.h.
7248         * python/py-param.c: Do not include py-ref.h.
7249         * python/py-prettyprint.c: Do not include py-ref.h.
7250         * python/py-progspace.c: Do not include py-ref.h.
7251         * python/py-symbol.c: Do not include py-ref.h.
7252         * python/py-symtab.c: Do not include py-ref.h.
7253         * python/py-type.c: Do not include py-ref.h.
7254         * python/py-unwind.c: Do not include py-ref.h.
7255         * python/py-utils.c: Do not include py-ref.h.
7256         * python/py-value.c: Do not include py-ref.h.
7257         * python/py-varobj.c: Do not include py-ref.h.
7258         * python/py-xmethods.c: Do not include py-ref.h.
7259         * python/python.c: Do not include py-ref.h.
7260         * varobj.c: Do not include py-ref.h.
7261
7262 2019-01-22  Tom Tromey  <tom@tromey.com>
7263
7264         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7265         keyword for bcache.
7266
7267 2019-01-22  Tom Tromey  <tom@tromey.com>
7268
7269         * compile/compile-cplus-types.c: Remove a comment by #include.
7270
7271 2019-01-22  Tom Tromey  <tom@tromey.com>
7272
7273         * compile/gcc-c-plugin.h: Include compile-internal.h.
7274
7275 2019-01-22  Tom Tromey  <tom@tromey.com>
7276
7277         * stabsread.c (EXTERN): Do not define.
7278         (symnum, next_symbol_text_func, processing_gcc_compilation)
7279         (within_function, global_sym_chain, global_stabs)
7280         (previous_stab_code, this_object_header_files)
7281         (n_this_object_header_files)
7282         (n_allocated_this_object_header_files): Define.
7283         * stabsread.h (EXTERN): Never define.  Use "extern".
7284
7285 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7286
7287         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7288         history_value.
7289
7290 2019-01-21  Tom Tromey  <tom@tromey.com>
7291
7292         * ui-out.c: Fix includes.
7293         * tui/tui-source.c: Fix includes.
7294         * target.c: Fix includes.
7295         * remote.c: Fix includes.
7296         * regcache.c: Fix includes.
7297         * python/py-block.c: Fix includes.
7298         * printcmd.c: Fix includes.
7299         * or1k-tdep.c: Fix includes.
7300         * mi/mi-main.c: Fix includes.
7301         * m32r-tdep.c: Fix includes.
7302         * csky-tdep.c: Fix includes.
7303         * compile/compile-cplus-types.c: Fix includes.
7304         * cli/cli-interp.c: Fix includes.
7305
7306 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7307
7308         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7309         for padding.
7310
7311 2019-01-16  Tom Tromey  <tom@tromey.com>
7312
7313         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7314         earlier.
7315         (struct objfile) <msymbols_range>: Move from top level.
7316         <msymbols>: New method.
7317         (class objfile_msymbols): Remove.
7318         * symtab.c (default_collect_symbol_completion_matches_break_on):
7319         Update.
7320         * symmisc.c (dump_msymbols): Update.
7321         * stabsread.c (scan_file_globals): Update.
7322         * objc-lang.c (info_selectors_command, info_classes_command)
7323         (find_methods): Update.
7324         * minsyms.c (find_solib_trampoline_target): Update.
7325         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7326         * coffread.c (coff_symfile_read): Update.
7327         * ada-lang.c (ada_lookup_simple_minsym)
7328         (ada_collect_symbol_completion_matches): Update.
7329
7330 2019-01-16  Tom Tromey  <tom@tromey.com>
7331
7332         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7333         type.  Remove no-argument constructor.
7334         <iterator::operator++>: Simplify.
7335         <begin>: Update.
7336         <end>: Use minimal_symbol_count.
7337
7338 2019-01-16  Tom Tromey  <tom@tromey.com>
7339
7340         * objfiles.h (struct objfile) <psymtabs>: New method.
7341         (class objfile_psymtabs): Remove.
7342         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7343         typedef.
7344         <range>: New method.
7345         (require_partial_symbols): Change return type.
7346         * psymtab.c (require_partial_symbols)
7347         (psym_expand_symtabs_matching): Update.
7348         * mdebugread.c (parse_partial_symbols): Update.
7349         * dbxread.c (dbx_end_psymtab): Update.
7350
7351 2019-01-15  Tom Tromey  <tom@tromey.com>
7352
7353         * symtab.c (lookup_objfile_from_block)
7354         (lookup_symbol_in_objfile_symtabs)
7355         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7356         (find_line_symtab, info_sources_command)
7357         (default_collect_symbol_completion_matches_break_on)
7358         (make_source_files_completion_list): Update.
7359         * symmisc.c (print_objfile_statistics, dump_objfile)
7360         (maintenance_print_symbols, maintenance_info_symtabs)
7361         (maintenance_check_symtabs, maintenance_info_line_tables):
7362         Update.
7363         * source.c (select_source_symtab)
7364         (forget_cached_source_info_for_objfile): Update.
7365         * objfiles.h (class objfile_compunits): Remove.
7366         (struct objfile) <compunits_range>: New typedef.
7367         (compunits): New method.
7368         * objfiles.c (objfile_relocate1): Update.
7369         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7370         * maint.c (count_symtabs_and_blocks): Update.
7371         * linespec.c (iterate_over_all_matching_symtabs): Update.
7372         * cp-support.c (add_symbol_overload_list_qualified): Update.
7373         * coffread.c (coff_symtab_read): Update.
7374         * ada-lang.c (add_nonlocal_symbols)
7375         (ada_collect_symbol_completion_matches)
7376         (ada_add_global_exceptions): Update.
7377
7378 2019-01-15  Tom Tromey  <tom@tromey.com>
7379
7380         * progspace.h (program_space) <objfiles_safe_range>: New
7381         typedef.
7382         <objfiles_safe>: New method.
7383         * objfiles.h (class all_objfiles_safe): Remove.
7384         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7385         * jit.c (jit_inferior_exit_hook): Update.
7386
7387 2019-01-17  Tom Tromey  <tom@tromey.com>
7388
7389         * progspace.h (program_space) <objfiles_range>: New typedef.
7390         <objfiles>: New method.
7391         <objfiles_head>: Rename from objfiles.
7392         (object_files): Update.
7393         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7394         * guile/scm-pretty-print.c
7395         (ppscm_find_pretty_printer_from_objfiles): Update.
7396         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7397         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7398         Update.
7399         * python/py-progspace.c (pspy_get_objfiles): Update.
7400         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7401         Update.
7402         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7403         (objfpy_lookup_objfile_by_build_id): Update.
7404         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7405         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7406         Update.
7407         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7408         (expand_symtab_containing_pc, lookup_objfile_from_block)
7409         (lookup_static_symbol, basic_lookup_transparent_type)
7410         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7411         (find_line_symtab, info_sources_command)
7412         (default_collect_symbol_completion_matches_break_on)
7413         (make_source_files_completion_list, find_main_name): Update.
7414         * symmisc.c (print_symbol_bcache_statistics)
7415         (print_objfile_statistics, maintenance_print_symbols)
7416         (maintenance_print_msymbols, maintenance_print_objfiles)
7417         (maintenance_info_symtabs, maintenance_check_symtabs)
7418         (maintenance_expand_symtabs, maintenance_info_line_tables):
7419         Update.
7420         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7421         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7422         (map_overlay_command, unmap_overlay_command)
7423         (simple_overlay_update, expand_symtabs_matching)
7424         (map_symbol_filenames): Update.
7425         * symfile-debug.c (set_debug_symfile): Update.
7426         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7427         Update.
7428         * source.c (select_source_symtab, forget_cached_source_info):
7429         Update.
7430         * solib.c (solib_read_symbols): Update.
7431         * solib-spu.c (append_ocl_sos): Update.
7432         * psymtab.c (maintenance_print_psymbols)
7433         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7434         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7435         * printcmd.c (info_symbol_command): Update.
7436         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7437         Update.
7438         * objfiles.h (class all_objfiles): Remove.
7439         * objfiles.c (have_partial_symbols, have_full_symbols)
7440         (have_minimal_symbols, qsort_cmp, update_section_map)
7441         (shared_objfile_contains_address_p)
7442         (default_iterate_over_objfiles_in_search_order): Update.
7443         * objc-lang.c (info_selectors_command, info_classes_command)
7444         (find_methods): Update.
7445         * minsyms.c (find_solib_trampoline_target): Update.
7446         * maint.c (maintenance_info_sections)
7447         (maintenance_translate_address, count_symtabs_and_blocks):
7448         Update.
7449         * main.c (captured_main_1): Update.
7450         * linux-thread-db.c (try_thread_db_load_from_pdir)
7451         (has_libpthread): Update.
7452         * linespec.c (iterate_over_all_matching_symtabs)
7453         (search_minsyms_for_name): Update.
7454         * jit.c (jit_find_objf_with_entry_addr): Update.
7455         * hppa-tdep.c (find_unwind_entry)
7456         (hppa_lookup_stub_minimal_symbol): Update.
7457         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7458         Update.
7459         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7460         (elf_gnu_ifunc_resolve_by_got): Update.
7461         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7462         * dwarf-index-write.c (save_gdb_index_command): Update.
7463         * cp-support.c (add_symbol_overload_list_qualified): Update.
7464         * breakpoint.c (create_overlay_event_breakpoint)
7465         (create_longjmp_master_breakpoint)
7466         (create_std_terminate_master_breakpoint)
7467         (create_exception_master_breakpoint): Update.
7468         * blockframe.c (find_pc_partial_function): Update.
7469         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7470         (ada_collect_symbol_completion_matches)
7471         (ada_add_global_exceptions): Update.
7472
7473 2019-01-17  Tom Tromey  <tom@tromey.com>
7474
7475         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7476         declare VEC.
7477         (solib_target_parse_libraries): Change return type.
7478         (library_list_start_segment, library_list_start_section)
7479         (library_list_end_library, library_list_start_library); Update.
7480         (solib_target_free_library_list): Remove.
7481         (solib_target_parse_libraries): Remove cleanup.  Change return
7482         type.
7483         (solib_target_current_sos): Update.
7484
7485 2019-01-17  Tom Tromey  <tromey@bapiya>
7486
7487         * valprint.c: Replace "the the" with "the".
7488         * symtab.c: Replace "the the" with "the".
7489         * solib.c: Replace "the the" with "the".
7490         * solib-dsbt.c: Replace "the the" with "the".
7491         * linespec.c: Replace "the the" with "the".
7492         * dwarf2loc.h: Replace "the the" with "the".
7493         * amd64-windows-tdep.c: Replace "the the" with "the".
7494         * aarch64-tdep.c: Replace "the the" with "the".
7495
7496 2019-01-16  Keith Seitz  <keiths@redhat.com>
7497
7498         PR gdb/23773
7499         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7500         <builder>: Rename to ..
7501         <m_builder>: ... this and make private.
7502         (dwarf2_cu::get_builder): New method.  Change all users of
7503         `builder' to use this method.
7504         (dwarf2_start_symtab): Move to ...
7505         (dwarf2_cu::start_symtab): ... here.  Update all callers
7506         (setup_type_unit_groups): Move to ...
7507         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7508         callers.
7509         (dwarf2_cu::reset_builder): New method.
7510         (process_full_compunit, process_full_type_unit): Use
7511         dwarf2_cu::reset_builder.
7512         (follow_die_offset): Record the ancestor CU if it is different
7513         from the followed DIE's CU.
7514         (follow_die_sig_1): Likewise.
7515
7516 2019-01-15  Tom Tromey  <tom@tromey.com>
7517
7518         * remote.c (class remote_state) <buf>: Now a char_vector.
7519         <buf_size>: Remove.
7520         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7521         parameter.
7522         (remote_target::getpkt_or_notif_sane_1)
7523         (remote_target::getpkt_sane)
7524         (remote_target::getpkt_or_notif_sane): Likewise.
7525         (class remote_target) <putpkt>: New overload.
7526         (remote_target::read_frame): Change type of "buf_p".  Remove
7527         sizeof_p parameter.
7528         (packet_ok): New overload.
7529         (packet_check_result): New overload.
7530         Update all uses.
7531
7532 2019-01-14  Tom Tromey  <tom@tromey.com>
7533
7534         * remote-notif.c (handle_notification, remote_notif_ack)
7535         (remote_notif_parse): Make "buf" const.
7536         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7537         const.
7538         (remote_notif_parse, remote_notif_ack, handle_notification):
7539         Likewise.
7540         * remote.c (remote_notif_stop_parse): Make "buf" const.
7541         (remote_target::remote_parse_stop_reply): Make "buf" const.
7542         (remote_notif_stop_ack): Make "buf" const.
7543
7544 2019-01-14  Tom Tromey  <tom@tromey.com>
7545
7546         * remote.c (remote_console_output): Make parameter const.
7547
7548 2019-01-14  Tom Tromey  <tom@tromey.com>
7549
7550         * target-debug.h (target_debug_print_signals): Constify.
7551         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7552         * procfs.c (procfs_target::pass_signals): Update.
7553         * linux-nat.c (linux_nat_target::pass_signals): Update.
7554         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7555         * target-delegates.c: Rebuild.
7556         * remote.c (remote_target::program_signals): Update.
7557         (remote_target::pass_signals): Update.
7558         * target.c (target_pass_signals): Constify argument.
7559         (target_program_signals): Likewise.
7560         * target.h (struct target_ops) <pass_signals, program_signals>:
7561         Constify argument.
7562         (target_pass_signals, target_program_signals): Constify argument.
7563
7564 2019-01-14  Tom Tromey  <tom@tromey.com>
7565
7566         PR tui/28819:
7567         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7568
7569 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7570
7571         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7572         field.
7573         * rs6000-tdep.c: Include reggroups.h.
7574         (IS_V_ALIAS_PSEUDOREG): Define.
7575         (rs6000_register_name): Return names for the "vX" aliases.
7576         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7577         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7578         aliases.  Call default_register_reggroup_p for all other
7579         pseudo-registers.
7580         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7581         New functions.
7582         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7583         Handle "vX" aliases.
7584         (v_alias_pseudo_register_collect): New function.
7585         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7586         (rs6000_gdbarch_init): Initialize "vX" aliases as
7587         pseudo-registers.  Restore registration of
7588         rs6000_pseudo_register_reggroup_p with
7589         set_tdesc_pseudo_register_reggroup_p.
7590
7591 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7592
7593         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7594         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7595         set_gdbarch_num_pseudo_regs.
7596
7597 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7598
7599         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7600         Remove arg prefixname, add do_set and do_show.
7601         Add member functions set_list and show_list.
7602         * cli/cli-style.c (class cli_style_option): Update accordingly.
7603         (style_set_list): Move to file scope.
7604         (style_show_list): Likewise.
7605         (set_style): Call help_list.
7606         (show_style): Call cmd_show_list.
7607         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7608         Update to use the new macro.
7609
7610 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7611
7612         * ada-lang.c (_initialize_ada_language): Expand the help text
7613         for the "catch exception" command.
7614
7615 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7616
7617         * symtab.c (matching_obj_sections): Initialize obj,
7618         declare it closer to its usage.
7619
7620 2019-01-10  Tom Tromey  <tom@tromey.com>
7621
7622         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7623         (basic_inf_threads_range): Remove.
7624         (inf_threads_range, inf_non_exited_threads_range)
7625         (safe_inf_threads_range): Use next_adapter.
7626
7627 2019-01-10  Keith Seitz  <keiths@redhat.com>
7628
7629         PR gdb/23712
7630         PR symtab/23010
7631         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7632         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7633
7634 2019-01-10  Keith Seitz  <keiths@redhat.com>
7635
7636         PR gdb/23712
7637         PR symtab/23010
7638         * dictionary.c (pending_to_vector): Remove.
7639         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7640         Remove _1 suffix, replacing functions of the same name.  Update
7641         all callers.
7642         (dict_create_hashed, dict_create_hashed_expandable)
7643         (dict_create_linear, dict_create_linear_expandable, dict_free)
7644         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7645         Make functions static.
7646
7647 2019-01-10  Keith Seitz  <keiths@redhat.com>
7648
7649         PR gdb/23712
7650         PR symtab/23010
7651         * dictionary.h (struct dictionary): Replace declaration with
7652         multidictionary.
7653         (dict_create_hashed, dict_create_hashed_expandable)
7654         (dict_create_linear, dict_create_linear_expandable)
7655         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7656         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7657         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7658         taking multidictionary argument.
7659         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7660         * block.h (struct block) <dict>: Change to multidictionary
7661         and rename `multidict'.
7662         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7663         symmisc.c: Update all dictionary references to multidictionary.
7664
7665 2019-01-10  Keith Seitz  <keiths@redhat.com>
7666
7667         PR gdb/23712
7668         PR symtab/23010
7669         * dictionary.c: Include unordered_map.
7670         (pending_to_vector): New function.
7671         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7672         Rewrite the non-"_1" functions to take vector instead
7673         of linked list.
7674         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7675         "new" _1 versions of the same name.
7676         (multidictionary): Define.
7677         (std::hash<enum language): New definition.
7678         (collate_pending_symbols_by_language, mdict_create_hashed)
7679         (mdict_create_hashed_expandable, mdict_create_linear)
7680         (mdict_create_linear_expandable, mdict_free)
7681         (find_language_dictionary, create_new_language_dictionary)
7682         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7683         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7684         (mdict_size, mdict_empty): New functions.
7685         * dictionary.h (mdict_iterator): Define.
7686
7687 2019-01-10  Pedro Alves  <palves@redhat.com>
7688
7689         * breakpoint.c (read_uploaded_action)
7690         (create_tracepoint_from_upload): Adjust to use
7691         gdb::unique_xmalloc_ptr.
7692         * ctf.c (ctf_write_uploaded_tp):
7693         (SET_ARRAY_FIELD): Use emplace_back.
7694         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7695         * tracefile-tfile.c (tfile_write_uploaded_tp):
7696         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7697         gdb::unique_xmalloc_ptr.
7698         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7699         at_string, cond_string, cmd_strings>: Replace char pointers
7700         with gdb::unique_xmalloc_ptr.
7701
7702 2019-01-10  Pedro Alves  <palves@redhat.com>
7703
7704         * solib-target.c (library_list_start_library): Don't xstrdup name.
7705
7706 2019-01-10  Pedro Alves  <palves@redhat.com>
7707
7708         * mdebugread.c (parse_partial_symbols): Use
7709         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7710
7711 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7712
7713         * linux-fork.c (scoped_switch_fork_info)
7714         <~scoped_switch_fork_info>: Fix incorrect variable name.
7715
7716 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7717
7718         * linux-fork.c (scoped_switch_fork_info)
7719         <scoped_switch_fork_info>: Make explicit.
7720         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7721
7722 2019-01-10  Tom Tromey  <tom@tromey.com>
7723
7724         * objfiles.h (objfile::reset_psymtabs): Update.
7725         * objfiles.c (objfile::objfile): Update.
7726         * psymtab.h (psymtab_storage::obstack): Update.
7727         (psymtab_storage::m_obstack): Use gdb::optional.
7728         (class psymtab_storage): Update comment.  Remove objfile
7729         parameter.
7730         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7731
7732 2019-01-10  Tom Tromey  <tom@tromey.com>
7733
7734         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7735         <free_psymtabs>: Now private.
7736         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7737         (allocate_psymtab): Use new method.
7738
7739 2019-01-10  Tom Tromey  <tom@tromey.com>
7740
7741         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7742         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7743         * mdebugread.c (parse_partial_symbols): Use
7744         allocate_dependencies.
7745         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7746         allocate_dependencies.
7747         (process_psymtab_comp_unit_reader)
7748         (build_type_psymtab_dependencies): Likewise.
7749         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7750
7751 2019-01-10  Tom Tromey  <tom@tromey.com>
7752
7753         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7754         PSYMBOL_SET_LANGUAGE.
7755         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7756
7757 2019-01-10  Tom Tromey  <tom@tromey.com>
7758
7759         * psymtab.h (psymtab_storage::obstack): New method.
7760         <m_obstack>: Rename from obstack; now private.
7761         * psymtab.c (psymtab_storage): Update.
7762         * dwarf2read.c (create_addrmap_from_index)
7763         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7764         Update.
7765
7766 2019-01-10  Tom Tromey  <tom@tromey.com>
7767
7768         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7769         * objfiles.h (objfile::reset_psymtabs): New method.
7770
7771 2019-01-10  Tom Tromey  <tom@tromey.com>
7772
7773         * symmisc.c (print_symbol_bcache_statistics): Update.
7774         (print_objfile_statistics): Update.
7775         * symfile.c (reread_symbols): Update.
7776         * psymtab.h (class psymtab_storage): New.
7777         * psymtab.c (psymtab_storage): New constructor.
7778         (~psymtab_storage): New destructor.
7779         (require_partial_symbols): Update.
7780         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7781         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7782         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7783         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7784         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7785         (start_psymtab_common, end_psymtab_common)
7786         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7787         (allocate_psymtab): Update.
7788         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7789         Update.
7790         (dump_psymtab_addrmap, maintenance_print_psymbols)
7791         (maintenance_check_psymtabs): Update.
7792         (class objfile_psymtabs): Move to objfiles.h.
7793         * psympriv.h (discard_psymtab): Now inline.
7794         (psymtab_discarder::psymtab_discarder): Update.
7795         (psymtab_discarder::~psymtab_discarder): Update.
7796         (ALL_OBJFILE_PSYMTABS): Rewrite.
7797         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7798         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7799         Remove fields.
7800         <partial_symtabs>: New field.
7801         (class objfile_psymtabs): Move from psymtab.h.  Update.
7802         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7803         psymbol_cache.
7804         (objfile::~objfile): Don't destroy psymbol_cache.
7805         * mdebugread.c (parse_partial_symbols): Update.
7806         * dwarf2read.c (create_addrmap_from_index)
7807         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7808         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7809         (add_partial_subprogram, dwarf2_ranges_read): Update.
7810         * dwarf-index-write.c (write_address_map)
7811         (write_one_signatured_type, recursively_write_psymbols)
7812         (class debug_names, class debug_names, write_psymtabs_to_index):
7813         Update.
7814
7815 2019-01-10  Tom Tromey  <tom@tromey.com>
7816
7817         * symtab.h (SYMBOL_SET_NAMES): Update.
7818         (symbol_set_names): Update.
7819         (MSYMBOL_SET_NAMES): Update.
7820         * symtab.c (symbol_set_names): Change argument to be an
7821         objfile_per_bfd_storage.
7822         * psymtab.c (add_psymbol_to_bcache): Update.
7823         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7824
7825 2019-01-10  Tom Tromey  <tom@tromey.com>
7826
7827         * symtab.c (create_demangled_names_hash): Change argument to be an
7828         objfile_per_bfd_storage.
7829         (symbol_set_names): Update.
7830
7831 2019-01-10  Tom Tromey  <tom@tromey.com>
7832
7833         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7834         init_psymbol_list.
7835         * psymtab.c (init_psymbol_list): Do nothing if already called.
7836         * psympriv.h (init_psymbol_list): Add comment.
7837         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7838         init_psymbol_list.
7839         * dbxread.c (dbx_symfile_read): Unconditionally call
7840         init_psymbol_list.
7841
7842 2019-01-10  Tom Tromey  <tom@tromey.com>
7843
7844         * xcoffread.c (scan_xcoff_symtab): Update.
7845         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7846         "where".
7847         * mdebugread.c (parse_partial_symbols)
7848         (handle_psymbol_enumerators): Update.
7849         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7850         * dbxread.c (read_dbx_symtab): Update.
7851         * psympriv.h (psymbol_placement): New enum.
7852         (add_psymbol_to_list): Update.
7853
7854 2019-01-10  Tom Tromey  <tom@tromey.com>
7855
7856         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7857         static_psymbols parameters.
7858         (scan_xcoff_symtab): Update.
7859         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7860         static_psymbols parameters.
7861         * psympriv.h (start_psymtab_common): Update.
7862         * mdebugread.c (parse_partial_symbols): Update.
7863         * dwarf2read.c (create_partial_symtab): Update.
7864         * dbxread.c (read_dbx_symtab): Update.
7865         (start_psymtab): Remove global_psymbols and static_psymbols
7866         parameters.
7867
7868 2019-01-10  Tom Tromey  <tom@tromey.com>
7869
7870         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7871         * psymtab.c (allocate_psymtab): Add comment.
7872         * psympriv.h (allocate_psymtab): Add comment.
7873         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7874         initializations.
7875         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7876
7877 2019-01-10  Tom Tromey  <tom@tromey.com>
7878
7879         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7880         Don't declare.
7881         * mipsread.c: Include mdebugread.h.
7882         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7883         Declare.
7884         * elfread.c: Include mdebugread.h.
7885
7886 2019-01-09  Tom Tromey  <tom@tromey.com>
7887
7888         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7889         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7890         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7891         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7892         (psym_lookup_symbol, psym_find_last_source_symtab)
7893         (psym_forget_cached_source_info, psym_print_stats)
7894         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7895         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7896         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7897         (psym_find_compunit_symtab_by_address)
7898         (maintenance_print_psymbols, maintenance_info_psymtabs)
7899         (maintenance_check_psymtabs): Use ranged for.
7900         * psymtab.h (class objfile_psymtabs): New.
7901         (require_partial_symbols): Return objfile_psymtabs.
7902         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7903
7904 2019-01-09  Tom Tromey  <tom@tromey.com>
7905
7906         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7907         (find_pc_mapped_section, list_overlays_command)
7908         (map_overlay_command, unmap_overlay_command)
7909         (simple_overlay_update): Use all_objfiles.
7910         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7911         * printcmd.c (info_symbol_command): Use all_objfiles.
7912         * objfiles.h (ALL_OBJSECTIONS): Remove.
7913         * maint.c (maintenance_translate_address): Use all_objfiles.
7914         * gcore.c (gcore_create_callback): Use all_objfiles.
7915         (objfile_find_memory_regions): Likewise.
7916
7917 2019-01-09  Tom Tromey  <tom@tromey.com>
7918
7919         * symtab.c (find_line_symtab, info_sources_command)
7920         (make_source_files_completion_list): Use objfile_compunits.
7921         * source.c (select_source_symtab): Use objfile_compunits.
7922         * objfiles.h (struct objfile): Update comment.
7923         (ALL_OBJFILES): Remove.
7924         (ALL_FILETABS): Remove.
7925         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7926         objfile_compunits.
7927
7928 2019-01-09  Tom Tromey  <tom@tromey.com>
7929
7930         * symmisc.c (print_objfile_statistics, dump_objfile)
7931         (maintenance_print_symbols): Use compunit_filetabs.
7932         * source.c (forget_cached_source_info_for_objfile): Use
7933         compunit_filetabs.
7934         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7935         (ALL_FILETABS): Use compunit_filetabs.
7936         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7937         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7938
7939 2019-01-09  Tom Tromey  <tom@tromey.com>
7940
7941         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7942         (compunit_filetabs): New.
7943         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7944         compunit_filetabs.
7945         (info_sources_command, make_source_files_completion_list): Remove
7946         declaration.
7947         * symmisc.c (print_objfile_statistics, dump_objfile)
7948         (maintenance_print_symbols): Remove declaration.
7949         (maintenance_info_symtabs): Use compunit_filetabs.
7950         (maintenance_info_line_tables): Likewise.
7951         * source.c (select_source_symtab): Change local variable name.
7952         (forget_cached_source_info_for_objfile): Remove declaration.
7953         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7954         * objfiles.c (objfile_relocate1): Remove declaration.
7955         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7956         declaration.
7957         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7958         * coffread.c (coff_symtab_read): Remove declaration.
7959         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7960         compunit_filetabs.
7961
7962 2019-01-09  Tom Tromey  <tom@tromey.com>
7963
7964         * symtab.c (lookup_objfile_from_block)
7965         (find_pc_sect_compunit_symtab, search_symbols)
7966         (default_collect_symbol_completion_matches_break_on): Use
7967         objfile_compunits.
7968         * objfiles.h (ALL_COMPUNITS): Remove.
7969         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7970         * cp-support.c (add_symbol_overload_list_qualified): Use
7971         objfile_compunits.
7972         * ada-lang.c (ada_collect_symbol_completion_matches)
7973         (ada_add_global_exceptions): Use objfile_compunits.
7974
7975 2019-01-09  Tom Tromey  <tom@tromey.com>
7976
7977         * source.c (select_source_symtab)
7978         (forget_cached_source_info_for_objfile): Remove declaration.
7979         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7980         declaration.
7981         * maint.c (count_symtabs_and_blocks): Remove declaration.
7982         * cp-support.c (add_symbol_overload_list_qualified): Remove
7983         declaration.
7984         * coffread.c (coff_symtab_read): Remove declaration.
7985         * symtab.c (lookup_symbol_in_objfile_symtabs)
7986         (basic_lookup_transparent_type_1): Use objfile_compunits.
7987         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7988         (info_sources_command, search_symbols)
7989         (default_collect_symbol_completion_matches_break_on)
7990         (make_source_files_completion_list): Remove declaration.
7991         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7992         (ada_collect_symbol_completion_matches)
7993         (ada_add_global_exceptions): Remove declaration.
7994         * linespec.c (iterate_over_all_matching_symtabs): Use
7995         objfile_compunits.
7996         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7997         (class objfile_compunits): New.
7998         (ALL_COMPUNITS): Use objfile_compunits.
7999         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8000         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8001         objfile_compunits.
8002         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8003
8004 2019-01-09  Tom Tromey  <tom@tromey.com>
8005
8006         * symtab.c (search_symbols)
8007         (default_collect_symbol_completion_matches_break_on): Use
8008         objfile_msymbols.
8009         * ada-lang.c (ada_lookup_simple_minsym)
8010         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8011         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8012         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8013         objfile_msymbols.
8014         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8015         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8016         * objc-lang.c (find_methods): Use objfile_msymbols.
8017         (info_selectors_command, info_classes_command): Likewise.
8018         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8019         * objfiles.h (class objfile_msymbols): New.
8020         (ALL_OBJFILE_MSYMBOLS): Remove.
8021         (ALL_MSYMBOLS): Remove.
8022
8023 2019-01-09  Tom Tromey  <tom@tromey.com>
8024
8025         * common/next-iterator.h (next_adapter): Add Iterator template
8026         parameter.
8027         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8028         (class all_objfiles_safe): New.
8029         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8030         * objfiles.c (put_objfile_before): Update comment.
8031         (add_separate_debug_objfile): Likewise.
8032         (free_all_objfiles): Use all_objfiles_safe.
8033         (objfile_purge_solibs): Likewise.
8034
8035 2019-01-09  Tom Tromey  <tom@tromey.com>
8036
8037         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8038         (expand_symtab_containing_pc, lookup_static_symbol)
8039         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8040         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8041         all_objfiles.
8042         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8043         * breakpoint.c (create_overlay_event_breakpoint)
8044         (create_longjmp_master_breakpoint)
8045         (create_std_terminate_master_breakpoint)
8046         (create_exception_master_breakpoint): Use all_objfiles.
8047         * linux-thread-db.c (try_thread_db_load_from_pdir)
8048         (has_libpthread): Use all_objfiles.
8049         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8050         * linespec.c (iterate_over_all_matching_symtabs)
8051         (search_minsyms_for_name): Use all_objfiles.
8052         * maint.c (maintenance_info_sections): Use all_objfiles.
8053         * main.c (captured_main_1): Use all_objfiles.
8054         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8055         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8056         * guile/scm-pretty-print.c
8057         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8058         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8059         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8060         (maintenance_print_msymbols): Use all_objfiles.
8061         * source.c (select_source_symtab): Use all_objfiles.
8062         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8063         * symfile.c (remove_symbol_file_command)
8064         (expand_symtabs_matching, map_symbol_filenames): Use
8065         all_objfiles.
8066         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8067         all_objfiles.
8068         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8069         * objc-lang.c (find_methods): Use all_objfiles.
8070         * objfiles.c (have_partial_symbols, have_full_symbols)
8071         (have_minimal_symbols, qsort_cmp)
8072         (default_iterate_over_objfiles_in_search_order): Use
8073         all_objfiles.
8074         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8075         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8076         (maintenance_check_psymtabs): Use all_objfiles.
8077         (ALL_PSYMTABS): Remove.
8078         * compile/compile-object-run.c (do_module_cleanup): Use
8079         all_objfiles.
8080         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8081         * cp-support.c (add_symbol_overload_list_qualified): Use
8082         all_objfiles.
8083         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8084         Use all_objfiles.
8085         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8086         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8087         all_objfiles.
8088         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8089         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8090         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8091         Uses all_objfiles.
8092         * solib.c (solib_read_symbols): Use all_objfiles
8093
8094 2019-01-09  Tom Tromey  <tom@tromey.com>
8095
8096         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8097         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8098         all_objfiles.
8099         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8100         * symmisc.c (print_symbol_bcache_statistics)
8101         (print_objfile_statistics, maintenance_print_objfiles)
8102         (maintenance_info_symtabs, maintenance_check_symtabs)
8103         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8104         all_objfiles.
8105         * source.c (forget_cached_source_info): Use all_objfiles.
8106         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8107         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8108         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8109         * objfiles.c (update_section_map): Use all_objfiles.
8110         (shared_objfile_contains_address_p): Likewise.
8111         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8112         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8113
8114 2019-01-09  Tom Tromey  <tom@tromey.com>
8115
8116         * common/next-iterator.h: New file.
8117         * objfiles.h (class all_objfiles): New.
8118         (struct objfile_iterator): New.
8119
8120 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8121
8122         * NEWS: Move the description of the changed "frame", "select-frame",
8123          and "info frame" commands to the Changed commands section.
8124
8125 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8126
8127         * gdbtypes.c (check_stub_method_group): Remove handling of old
8128         mangling schemes.
8129         * linespec.c (find_methods): Likewise.
8130         * stabsread.c (read_member_functions): Likewise.
8131         * valops.c (search_struct_method): Likewise.
8132         (value_struct_elt_for_reference): Likewise.
8133         * NEWS: Mention this change.
8134
8135 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8136
8137         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8138         print_source_lines.
8139         * source.c (print_source_lines_base): Update line number check.
8140         (print_source_lines): New function.
8141         (source_lines_range::source_lines_range): New function.
8142         * source.h (class source_lines_range): New class.
8143         (print_source_lines): New declaration.
8144
8145 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8146
8147         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8148
8149 2019-01-08  Tom Tromey  <tom@tromey.com>
8150             Simon Marchi  <simon.marchi@ericsson.com>
8151
8152         PR gdb/24060
8153         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8154         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8155         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8156         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8157         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8158         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8159
8160 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8161
8162         * source.c (select_source_symtab): Move header comment to
8163         declaration in source.h.
8164         (forget_cached_source_info_for_objfile): Likewise.
8165         (forget_cached_source_info): Likewise.
8166         (identify_source_line): Likewise.
8167         * source.h (identify_source_line): Move declaration from symtab.h
8168         and add comment from source.c
8169         (print_source_lines): Likewise.
8170         (forget_cached_source_info_for_objfile): Likewise.
8171         (forget_cached_source_info): Likewise.
8172         (select_source_symtab): Likewise.
8173         (enum print_source_lines_flag): Move definition from symtab.h.
8174         * symtab.h (identify_source_line): Move declaration to source.h.
8175         (print_source_lines): Likewise.
8176         (forget_cached_source_info_for_objfile): Likewise.
8177         (forget_cached_source_info): Likewise.
8178         (select_source_symtab): Likewise.
8179         (enum print_source_lines_flag): Move definition to source.h.
8180         * tui/tui-hooks.c: Add 'source.h' include.
8181
8182 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8183
8184         * source.c (print_source_lines_base): Handle requests to print
8185         reverse line number sequences, and guard against empty lines
8186         string.
8187
8188 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8189
8190         * source.c (print_source_lines_base): Fix skip of '\r' if next
8191         character is '\n'.
8192
8193 2019-01-06  Tom Tromey  <tom@tromey.com>
8194
8195         * c-exp.y (struct c_parse_state) <macro_original_text,
8196         expansion_obstack>: New member.
8197         (macro_original_text, expansion_obstack): Remove globals.
8198         (scan_macro_expansion, scanning_macro_expansion)
8199         (finished_macro_expansion): Update.
8200         (scan_macro_cleanup): Remove.
8201         (yylex, c_parse): Update.
8202
8203 2019-01-06  Tom Tromey  <tom@tromey.com>
8204
8205         * c-exp.y (struct c_parse_state) <strings>: New member.
8206         (operator_stoken): Update.
8207
8208 2019-01-06  Tom Tromey  <tom@tromey.com>
8209
8210         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8211         (union type_stack_elt) <typelist_val>: Now a pointer to
8212         std::vector.
8213         (type_stack_cleanup): Don't declare.
8214         (push_typelist): Update.
8215         * parse.c (pop_typelist): Return a std::vector.
8216         (push_typelist): Take a std::vector.
8217         (follow_types): Update.  Do not free args.
8218         (type_stack_cleanup): Remove.
8219         * c-exp.y (struct c_parse_state): New.
8220         (cpstate): New global.
8221         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8222         (nonempty_typelist): Update.
8223         (func_mod): Create a new vector.
8224         (c_parse): Create a c_parse_state.
8225         (check_parameter_typelist): Do not delete params.
8226         (function_method): Update.  Do not delete type_list.
8227
8228 2019-01-06  Tom Tromey  <tom@tromey.com>
8229
8230         PR gdb/28155:
8231         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8232         check_typedef.
8233         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8234         (print_return_value): Likewise.
8235
8236 2019-01-05  Tom Tromey  <tom@tromey.com>
8237
8238         * contrib/cleanup_check.py: Remove.
8239         * contrib/gcc-with-excheck: Remove.
8240         * contrib/exsummary.py: Remove.
8241         * contrib/excheck.py: Remove.
8242
8243 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8244
8245         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8246         NULL. Initialize tpprev to NULL instead of assigning it
8247         to NULL on the next statement.
8248         * windows-nat.c (windows_delete_thread): Remove check for
8249         main_thread_id before printing thread exit notifications.
8250         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8251         Remove thread ID check against main_thread_id.
8252         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8253         windows_delete_thread.
8254         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8255
8256 2019-01-04  Tom Tromey  <tom@tromey.com>
8257
8258         * compile/compile.c (_initialize_compile): Use upper case for
8259         metasyntactic variables.
8260         * symmisc.c (_initialize_symmisc): Use upper case for
8261         metasyntactic variables.
8262         * psymtab.c (_initialize_psymtab): Use upper case for
8263         metasyntactic variables.
8264         * demangle.c (demangle_command): Use upper case for metasyntactic
8265         variables.
8266         (_initialize_demangler): Likewise.
8267         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8268         variables.
8269
8270 2019-01-03  Tom Tromey  <tom@tromey.com>
8271
8272         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8273
8274 2019-01-03  Tom Tromey  <tom@tromey.com>
8275
8276         * python/py-symtab.c (salpy_str): Update.
8277         (struct salpy_sal_object) <symtab>: Now a PyObject.
8278         (salpy_dealloc): Update.
8279         (del_objfile_sal): Use gdbpy_ref.
8280
8281 2019-01-03  Tom Tromey  <tom@tromey.com>
8282
8283         * python/py-type.c (convert_field): Use new_reference.  Return
8284         gdbpy_ref.
8285         (make_fielditem): Return gdbpy_ref.
8286         (typy_fields): Update.
8287         (typy_getitem): Update.
8288         (field_name): Return gdbpy_ref.  Use new_reference.
8289         (typy_iterator_iternext): Update.
8290
8291 2019-01-03  Tom Tromey  <tom@tromey.com>
8292
8293         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8294
8295 2019-01-03  Tom Tromey  <tom@tromey.com>
8296
8297         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8298         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8299         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8300         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8301         (pspy_set_type_printers): Likewise.
8302         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8303         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8304         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8305         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8306         (objfpy_set_type_printers): Likewise.
8307
8308 2019-01-03  Tom Tromey  <tom@tromey.com>
8309
8310         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8311         (gdbpy_print_stack): Use gdbpy_err_fetch.
8312         * python/python-internal.h (class gdbpy_err_fetch): New class.
8313         (class gdbpy_enter) <m_error_type, m_error_value,
8314         m_error_traceback>: Remove.
8315         <m_error>: New member.
8316         (gdbpy_exception_to_string): Don't declare.
8317         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8318         * python/py-value.c (convert_value_from_python): Use
8319         gdbpy_err_fetch.
8320         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8321         gdbpy_exception_to_string.
8322         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8323         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8324         gdbpy_err_fetch.
8325
8326 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8327
8328         * linux-nat.c (delete_lwp_cleanup): Delete.
8329         (struct lwp_deleter): New struct.
8330         (lwp_info_up): New typedef.
8331         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8332         lwp_info_up.
8333
8334 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8335
8336         * linux-fork.c (class scoped_switch_fork_info): New class.
8337         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8338
8339 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8340
8341         * valops.c (find_overload_match): Remove use of null_cleanup, and
8342         calls to do_cleanups.
8343
8344 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8345
8346         * compile/compile-cplus-types.c
8347         (compile_cplus_instance::decl_name): Handle changes to
8348         cp_func_name.
8349         * cp-support.c (cp_func_name): Update header comment, update
8350         return type.
8351         * cp-support.h (cp_func_name): Update return type in declaration.
8352         * valops.c (find_overload_match): Move temp_func local to top
8353         level of function and change its type.  Use temp_func to hold and
8354         delete temporary string obtained from cp_func_name.
8355
8356 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8357
8358         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8359         gdb::char_vector, remove cleanup, and update uses of `msg`.
8360
8361 2019-01-03  Jim Wilson  <jimw@sifive.com>
8362
8363         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8364
8365 2019-01-02  Tom Tromey  <tom@tromey.com>
8366
8367         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8368         (tdesc_parse_xml): Remove cleanups.
8369         * target-descriptions.h (make_cleanup_free_target_description):
8370         Don't declare.
8371         (target_desc_deleter): New struct.
8372         (target_desc_up): New typedef.
8373         * target-descriptions.c (target_desc_deleter::operator()): Rename
8374         from free_target_description.
8375         (make_cleanup_free_target_description): Remove.
8376
8377 2019-01-02  Tom Tromey  <tom@tromey.com>
8378
8379         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8380         constructor, destructor.
8381         (linespec_parser): Remove typedef.
8382         (~linespec_parser): Rename from linespec_parser_delete.
8383         (linespec_lex_to_end, linespec_complete_label)
8384         (linespec_complete): Update.
8385         (decode_line_full): Remove cleanups.
8386         (decode_line_1): Update.
8387
8388 2019-01-02  Tom Tromey  <tom@tromey.com>
8389
8390         * python/python-internal.h (inferior_to_inferior_object): Change
8391         return type.
8392         * python/py-exitedevent.c (create_exited_event_object): Update.
8393         * python/py-inferior.c (inferior_to_inferior_object): Return
8394         gdbpy_ref.
8395         (python_new_inferior, python_inferior_deleted)
8396         (thread_to_thread_object, delete_thread_object)
8397         (build_inferior_list, gdbpy_selected_inferior): Update.
8398         * python/py-infthread.c (create_thread_object): Update.  Also fail
8399         if inferior_to_inferior_object fails.
8400
8401 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8402
8403         * inferior.h (class inferior) <displaced_step_state>: New field.
8404         * infrun.h (struct displaced_step_state): Move here from
8405         infrun.c.  Initialize fields, add constructor.
8406         <inf>: Remove field.
8407         <reset>: New method.
8408         * infrun.c (struct displaced_step_inferior_state): Move to
8409         infrun.h.
8410         (displaced_step_inferior_states): Remove.
8411         (get_displaced_stepping_state): Adust.
8412         (displaced_step_in_progress_any_inferior): Adjust.
8413         (displaced_step_in_progress_thread): Adjust.
8414         (displaced_step_in_progress): Adjust.
8415         (add_displaced_stepping_state): Remove.
8416         (get_displaced_step_closure_by_addr): Adjust.
8417         (remove_displaced_stepping_state): Remove.
8418         (infrun_inferior_exit): Call displaced_step_state.reset.
8419         (use_displaced_stepping): Don't check for NULL.
8420         (displaced_step_prepare_throw): Call
8421         get_displaced_stepping_state.
8422         (displaced_step_fixup): Don't check for NULL.
8423         (prepare_for_detach): Don't check for NULL.
8424
8425 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8426
8427         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8428          in case of call that did not complete.
8429
8430 2019-01-02  Andrey Utkin  <autkin@undo.io>
8431
8432         * symfile.c (find_separate_debug_file): Fix search of debug files for
8433         remote debuggee.
8434
8435 2019-01-02  Tom Tromey  <tom@tromey.com>
8436
8437         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8438         indentation.
8439         * python/py-frame.c (frapy_older): Remove cast.
8440         (frapy_newer): Likewise.
8441         * python/py-breakpoint.c (local_setattro): Remove cast.
8442         * python/py-arch.c (archpy_name): Remove local variable.
8443         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8444
8445 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8446
8447         * unittests/basic_string_view/element_access/char/empty.cc:
8448         Fix year range in copyright header.
8449
8450 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8451
8452         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8453         Delete.
8454         <operator==>: Update with for removed field.
8455         <hash>: Likewise.
8456         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8457         <isa_features>: ...this.
8458         <abi_features>: New field.
8459         (riscv_isa_flen): Update comment.
8460         (riscv_abi_xlen): New declaration.
8461         (riscv_abi_flen): New declaration.
8462         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8463         isa_features.
8464         (riscv_abi_xlen): New function.
8465         (riscv_isa_flen): Update to get answer from isa_features.
8466         (riscv_abi_flen): New function.
8467         (riscv_has_fp_abi): Update to get answer from abi_features.
8468         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8469         xlen and flen.
8470         (riscv_call_info) <xlen, flen>: Update comment.
8471         (riscv_call_arg_struct): Remove invalid assertions
8472         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8473         is removed.
8474         (riscv_gdbarch_init): Gather isa features and abi features
8475         separately, ensure both match on the gdbarch when reusing an old
8476         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8477         a target with 64-bit float hardware.
8478
8479 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8480
8481         * source.c (search_command_helper): Stop reverse search
8482         when line 1 has been searched.
8483
8484 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8485
8486         * record-full.c (record_full_base_target::close): Rewrite
8487         record_full_core_buf_list free logic.
8488
8489 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8490
8491         * break-catch-syscall.c (print_one_catch_syscall): xfree
8492         the last text.
8493
8494 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8495
8496         * top.c (print_gdb_version): Update Copyright year in version
8497         message.
8498
8499 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8500
8501         Update copyright year range in all GDB files.
8502
8503 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8504
8505         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8506
8507 For older changes see ChangeLog-2018.
8508 \f
8509 Local Variables:
8510 mode: change-log
8511 left-margin: 8
8512 fill-column: 74
8513 version-control: never
8514 coding: utf-8
8515 End:
8516