gdb/ChangeLog

   1 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
   4         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
   5         (store_fpregs_to_thread)
   6         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
   7         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
   8         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
   9         (IWMMXT_REGS_SIZE): Add define.
  10         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
  11         (fetch_vfp_regs, store_vfp_regs)
  12         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
  13         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
  14
  15 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
  16
  17         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
  18         defines.
  19         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
  20         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
  21         (ARM_INT_REGISTER_SIZE): ...to this.
  22         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
  23         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
  24         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
  25         (arm_linux_collect_gregset, supply_nwfpe_register)
  26         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
  27         defines.
  28         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
  29         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
  30         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
  31         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
  32         (arm_return_in_memory, arm_store_return_value)
  33         (arm_get_longjmp_target, arm_register_g_packet_guesses)
  34         (arm_record_ld_st_multiple): Likewise.
  35         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
  36         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
  37
  38 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
  39
  40         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
  41         AARCH64_DISPLACED_MODIFIED_INSNS.
  42         * aarch64-tdep.c (struct aarch64_displaced_step_data)
  43         (aarch64_displaced_step_copy_insn): Likewise.
  44         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
  45         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
  46         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
  47         ARM_DISPLACED_MODIFIED_INSNS.
  48         * arm-tdep.c (arm_gdbarch_init): Likewise.
  49         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
  50         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
  51         (struct arm_displaced_step_closure): Use
  52         ARM_DISPLACED_MODIFIED_INSNS.
  53
  54 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
  55
  56         * features/Makefile: Remove unused xml files.
  57         * features/aarch64.xml: Remove.
  58         * features/i386/amd64-avx-avx512-linux.xml: Remove.
  59         * features/i386/amd64-avx-avx512.xml: Remove.
  60         * features/i386/amd64-avx-linux.xml: Remove.
  61         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
  62         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
  63         * features/i386/amd64-avx-mpx-linux.xml: Remove.
  64         * features/i386/amd64-avx-mpx.xml: Remove.
  65         * features/i386/amd64-avx.xml: Remove.
  66         * features/i386/amd64-linux.xml: Remove.
  67         * features/i386/amd64-mpx-linux.xml: Remove.
  68         * features/i386/amd64-mpx.xml: Remove.
  69         * features/i386/amd64.xml: Remove.
  70         * features/i386/i386-avx-avx512-linux.xml: Remove.
  71         * features/i386/i386-avx-avx512.xml: Remove.
  72         * features/i386/i386-avx-linux.xml: Remove.
  73         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
  74         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
  75         * features/i386/i386-avx-mpx-linux.xml: Remove.
  76         * features/i386/i386-avx-mpx.xml: Remove.
  77         * features/i386/i386-avx.xml: Remove.
  78         * features/i386/i386-linux.xml: Remove.
  79         * features/i386/i386-mmx-linux.xml: Remove.
  80         * features/i386/i386-mmx.xml: Remove.
  81         * features/i386/i386-mpx-linux.xml: Remove.
  82         * features/i386/i386-mpx.xml: Remove.
  83         * features/i386/i386.xml: Remove.
  84         * features/i386/x32-avx-avx512-linux.xml: Remove.
  85         * features/i386/x32-avx-linux.xml: Remove.
  86         * features/i386/x32-linux.xml: Remove.
  87
  88 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
  89
  90         * regformats/aarch64.dat: Remove.
  91         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
  92         * regformats/i386/amd64-avx-linux.dat: Remove.
  93         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
  94         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
  95         * regformats/i386/amd64-linux.dat: Remove.
  96         * regformats/i386/amd64-mpx-linux.dat: Remove.
  97         * regformats/i386/amd64.dat: Remove.
  98         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
  99         * regformats/i386/i386-avx-linux.dat: Remove.
 100         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 101         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 102         * regformats/i386/i386-linux.dat: Remove.
 103         * regformats/i386/i386-mmx-linux.dat: Remove.
 104         * regformats/i386/i386-mpx-linux.dat: Remove.
 105         * regformats/i386/i386.dat: Remove.
 106         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 107         * regformats/i386/x32-avx-linux.dat: Remove.
 108         * regformats/i386/x32-linux.dat: Remove.
 109
 110 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 111
 112         * aarch64-tdep.c: Remove xml self tests.
 113         * amd64-linux-tdep.c: Likewise.
 114         * amd64-tdep.c: Likewise.
 115         * i386-linux-tdep.c: Likewise.
 116         * i386-tdep.c: Likewise.
 117
 118 2019-07-03  Pedro Alves  <palves@redhat.com>
 119
 120         PR cli/24732
 121         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 122         (pipe_cmd_option_defs): New.
 123         (make_pipe_cmd_options_def_group): New.
 124         (pipe_command): Use gdb::option::process_options.
 125         (pipe_command_completer): New function.
 126         (_initialize_cli_cmds): Install completer for "pipe" command.
 127
 128 2019-07-03  Pedro Alves  <palves@redhat.com>
 129
 130         * cli/cli-option.c (union option_value) <string>: New field.
 131         (struct option_def_and_value): Add ctor, move ctor, dtor and
 132         use DISABLE_COPY_AND_ASSIGN.
 133         (option_def_and_value::clear_value): New.
 134         (parse_option, save_option_value_in_ctx, get_val_type_str)
 135         (add_setshow_cmds_for_options): Handle var_string.
 136         * cli-option.h (union option_def::var_address) <string>: New
 137         field.
 138         (struct string_option_def): New.
 139         * maint-test-options.c (struct test_options_opts): Add default
 140         ctor and use DISABLE_COPY_AND_ASSIGN.
 141         <string_opt>: New field.
 142         (test_options_opts::~test_options_opts): New.
 143         (test_options_opts::dump): Also dump "-string".
 144         (test_options_option_defs): Install "string.
 145
 146 2019-07-03  Pedro Alves  <palves@redhat.com>
 147
 148         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 149         option_value with a null enumeration.
 150         (complete_options): Save the option values in the context.
 151         (save_option_value_in_ctx): New, factored out from ...
 152         (process_options): ... here.
 153         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 154         of the function.
 155         * maint-test-options.c (test_options_opts::dump): New, factored
 156         out from ...
 157         (maintenance_test_options_command_mode): ... here.
 158         (maintenance_test_options_command_completion_result): Delete.
 159         (maintenance_test_options_command_completion_text): Update
 160         comment.
 161         (maintenance_show_test_options_completion_result): Change
 162         prototype.  Just print
 163         maintenance_test_options_command_completion_text.
 164         (save_completion_result): New.
 165         (maintenance_test_options_completer_mode): Pass options context to
 166         complete_options, and then save a dump.
 167         (_initialize_maint_test_options): Use add_cmd to install "maint
 168         show test-options-completion-result".
 169
 170 2019-07-03  Pedro Alves  <palves@redhat.com>
 171
 172         * NEWS (New commands): Mention "with" and "maint with".
 173         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 174         (with_command, with_command_completer): New.
 175         (pipe_command): Adjust to new repeat_previous
 176         interface.
 177         (_initialize_cli_cmds): Install the "with" command and its "w"
 178         alias.
 179         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 180         declarations.
 181         * cli/cli-setshow.c (parse_cli_var_uinteger)
 182         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 183         argument strings for all var_types.
 184         (get_setshow_command_value_string): New, factored out from ...
 185         (do_show_command): ... this.
 186         * cli/cli-setshow.h: Include <string>.
 187         (get_setshow_command_value_string): Declare.
 188         * command.h (repeat_previous): Now returns const char *.  Adjust
 189         comment.
 190         * maint.c: Include "cli/cli-cmds.h".
 191         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 192         (_initialize_maint_cmds): Register the "maintenance with" command.
 193         * top.c (repeat_previous): Move bits from pipe_command here:
 194         Return the saved command line, if any; error out if there's no
 195         command to relaunch.
 196
 197 2019-07-03  Pedro Alves  <palves@redhat.com>
 198
 199         * NEWS (New commands): Mention "maint set/show test-settings"
 200         instead of "maint test-settings".
 201         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 202         (maintenance_test_settings_set_list): Rename to ...
 203         (maintenance_set_test_settings_list): ... this.
 204         (maintenance_test_settings_show_list): Rename to  ...
 205         (maintenance_show_test_settings_list): ... this.
 206         (maintenance_test_settings_cmd): Delete.
 207         (maintenance_test_settings_set_cmd): ...
 208         (maintenance_set_test_settings_cmd): ... this.
 209         (maintenance_test_settings_show_cmd): ...
 210         (maintenance_show_test_settings_cmd): ... this.
 211         (maintenance_test_settings_show_value_cmd):
 212         (maintenance_show_test_settings_value_cmd): ... this.
 213         (_initialize_maint_test_settings): No longer install the "maint
 214         test-settings" prefix command.  Rename "maint test-settings set"
 215         to "maint set test-settings", and "maint test-settings show" to
 216         "maint show test-settings".  Adjust all subcommands.
 217
 218 2019-07-03  Pedro Alves  <palves@redhat.com>
 219
 220         * maint-test-settings.c: Fix file's intro comment.  Replace all
 221         references to "test-options" with references to "test-settings",
 222         in comments.
 223
 224 2019-07-03  Pedro Alves  <palves@redhat.com>
 225
 226         * maint-test-settings.c (maintenance_test_settings_xxx)
 227         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 228         New.
 229         (maintenance_test_settings_enums): Use them.
 230         (maintenance_test_settings_enum): Default to
 231         maintenance_test_settings_xxx.
 232         (_initialize_maint_test_settings): Initialize
 233         MAINTENANCE_TEST_SETTINGS_FILENAME.
 234
 235 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 236
 237         * breakpoint.h (remove_breakpoints_inf): Change return type to
 238         void, move function documentation here.
 239         * breakpoint.c (remove_breakpoints_inf): Change return type to
 240         void, move function documentation to header.
 241
 242 2019-07-02  Pedro Alves  <palves@redhat.com>
 243
 244         * NEWS (Completion improvements): Mention "info threads".
 245         * thread.c (struct info_threads_opts, info_threads_option_defs)
 246         (make_info_threads_options_def_group): New.
 247         (info_threads_command): Use gdb::option::process_options.
 248         (info_threads_command_completer): New.
 249         (_initialize_thread): Use gdb::option::build_help to build the
 250         help text for "info threads".
 251
 252 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 253
 254         * defs.h (generic_load): Move from here...
 255         * symfile.h (generic_load): ... to here.  Rename name parameter
 256         to args.
 257         * symfile.c (generic_load): Add comment.
 258
 259 2019-07-01  Tom Tromey  <tromey@adacore.com>
 260
 261         * dwarf2read.c
 262         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 263         declaration of without_params.  Fix formatting.
 264
 265 2019-07-01  Tom Tromey  <tromey@adacore.com>
 266
 267         * ada-exp.y (find_primitive_type): Update.
 268         * ada-lang.h (ada_lookup_symbol): Update.
 269         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 270         parameter.
 271         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 272
 273 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 274
 275         PR breakpoints/24541
 276         * gdbarch.c: Regenerate.
 277         * gdbarch.h: Regenerate.
 278         * gdbarch.sh: Add 'stap_adjust_register'.
 279         * i386-tdep.c: Include '<unordered_set>'.
 280         (i386_stap_adjust_register): New function.
 281         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 282         * stap-probe.c (stap_parse_register_operand): Call
 283         'gdbarch_stap_adjust_register'.
 284
 285 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 286
 287         PR python/24742
 288         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 289         * python/python.c (do_start_initialization): Use 'xmalloc'
 290         instead of 'PyMem_Malloc'.
 291
 292 2019-06-28  Tom Tromey  <tromey@adacore.com>
 293
 294         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 295         for Ada.
 296
 297 2019-06-27  Tom Tromey  <tromey@adacore.com>
 298
 299         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 300         objfile_key.
 301         (arm_find_mapping_symbol, arm_record_special_symbol)
 302         (_initialize_arm_tdep): Update.
 303         (arm_objfile_data_free): Remove.
 304
 305 2019-06-27  Tom Tromey  <tromey@adacore.com>
 306
 307         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 308         to cp_print_static_field.
 309
 310 2019-06-26  Tom Tromey  <tromey@adacore.com>
 311
 312         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 313         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 314         declare.
 315
 316 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 317
 318         * features/aarch64-core.c (create_feature_aarch64_core):
 319         Regenerate.
 320         * features/aarch64-core.xml: Add cpsr flags.
 321
 322 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 323
 324         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 325         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 326
 327 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 328
 329         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 330         field.
 331         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 332         use.
 333         (arm_record_special_symbol): Don't insert new symbol in sorted
 334         position, push it at the end.
 335
 336 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 337
 338         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 339         (arm_mapping_symbol_s): Remove.
 340         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 341         (arm_mapping_symbol_vec): New typedef.
 342         (struct arm_per_objfile): Add constructor.
 343         <section_maps>: Change type to
 344         std::unique_ptr<arm_mapping_symbol_vec[]>.
 345         (arm_compare_mapping_symbols): Remove.
 346         (arm_find_mapping_symbol): Adjust to section_maps type change.
 347         (arm_objfile_data_free): Call delete on arm_per_objfile.
 348         (arm_record_special_symbol): Adjust to section_maps type change.
 349         Allocate arm_per_objfile with new.
 350
 351 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 352
 353         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 354         with the command prefix.
 355
 356 2019-06-25  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 359         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 360
 361 2019-06-25  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 364         type.
 365         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 366         protected.
 367
 368 2019-06-25  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-winsource.c
 371         (tui_source_window_base::set_is_exec_point_at): Add check against
 372         LOA_ADDRESS.
 373
 374 2019-06-25  Tom Tromey  <tom@tromey.com>
 375
 376         * tui/tui-source.c (tui_set_source_content): Don't check before
 377         xfree.
 378         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 379
 380 2019-06-25  Tom Tromey  <tom@tromey.com>
 381
 382         * tui/tui-winsource.h (tui_update_source_window_as_is)
 383         (tui_alloc_source_buffer, tui_line_is_displayed)
 384         (tui_addr_is_displayed): Change type of win_info.
 385         * tui/tui-winsource.c (tui_update_source_window_as_is)
 386         (tui_clear_source_content, tui_show_source_line)
 387         (tui_show_source_content, tui_source_window_base::refill)
 388         (tui_source_window_base::set_is_exec_point_at)
 389         (tui_source_window_base::set_is_exec_point_at)
 390         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 391         (tui_alloc_source_buffer, tui_line_is_displayed)
 392         (tui_addr_is_displayed): Change type of win_info.  Update.
 393         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 394         (tui_source_window_base::do_make_visible_with_new_height):
 395         Update.
 396         * tui/tui-source.c (tui_set_source_content)
 397         (tui_set_source_content_nil)
 398         (tui_source_window::do_scroll_vertical): Update.
 399         * tui/tui-layout.c (show_layout): Update.
 400         * tui/tui-disasm.c (tui_set_disassem_content)
 401         (tui_disasm_window::do_scroll_vertical): Update.
 402         * tui/tui-data.h (tui_win_content): Remove.
 403         (struct tui_gen_win_info) <content, content_size>: Remove.
 404         (struct tui_source_element): Add initializers and destructor.
 405         (union tui_which_element, struct tui_win_element): Remove.
 406         (struct tui_source_window_base) <content>: New field.
 407         (struct tui_data_window): Remove destructor.
 408         (tui_alloc_content, tui_free_win_content)
 409         (tui_free_all_source_wins_content): Don't declare.
 410         * tui/tui-data.c (tui_initialize_static_data): Update.
 411         (init_content_element, tui_alloc_content): Remove.
 412         (~tui_gen_win_info): Update.
 413         (~tui_data_window, tui_free_all_source_wins_content)
 414         (tui_free_win_content, free_content, free_content_elements):
 415         Remove.
 416
 417 2019-06-25  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-winsource.h (tui_clear_source_content)
 420         (tui_erase_source_content, tui_show_source_content): Change type
 421         of win_info.
 422         * tui/tui-winsource.c (tui_clear_source_content)
 423         (tui_erase_source_content, tui_show_source_content): Change type
 424         of win_info.
 425         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 426         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 427         win_info.
 428         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 429         win_info.
 430         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 431
 432 2019-06-25  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-winsource.c (tui_clear_source_content)
 435         (tui_source_window_base::set_is_exec_point_at): Update.
 436         * tui/tui-source.c (tui_set_source_content_nil): Update.
 437         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 438         a bool.
 439         * tui/tui-data.c (init_content_element): Update.
 440
 441 2019-06-25  Tom Tromey  <tom@tromey.com>
 442
 443         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 444         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 445         * tui/tui-layout.c (init_and_make_win): Update.
 446         * tui/tui.h (enum tui_win_type): Update.
 447         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 448         tui_win_is_auxillary.
 449         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 450         tui_win_is_auxillary.
 451
 452 2019-06-25  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 455         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 456         (tui_delete_data_content_windows, tui_display_all_data)
 457         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 458         Update.
 459         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 460         * tui/tui-regs.c (tui_last_regs_line_no)
 461         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 462         (tui_show_registers): Update.
 463         (tui_show_register_group): Return void.  Update.
 464         (tui_display_registers_from, tui_display_reg_element_at_line)
 465         (tui_display_registers_from_line, tui_check_register_values):
 466         Update.
 467         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 468         member.
 469         (struct tui_data_window) <regs_content>: Now a std::vector.
 470         <regs_content_count>: Remove.
 471         (tui_add_content_elements, tui_free_data_content): Don't declare.
 472         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 473         (init_content_element): Remove DATA_WIN case.  Add assert.
 474         (tui_add_content_elements): Remove.
 475         (tui_data_window): Update.
 476         (tui_free_data_content): Remove.
 477         (free_content_elements): Remove DATA_WIN case.
 478
 479 2019-06-25  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-data.c (tui_data_item_window): Update.
 482         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 483         * tui/tui-windata.c (tui_display_all_data)
 484         (tui_display_data_from_line): Update.
 485         (tui_check_data_values): Remove.
 486         * tui/tui-regs.c (tui_show_register_group)
 487         (tui_display_reg_element_at_line): Update.
 488         * tui/tui-hooks.c (tui_register_changed)
 489         (tui_refresh_frame_and_register_information): Call
 490         tui_check_register_values.
 491         * tui/tui-data.h (struct tui_data_window) <data_content,
 492         data_content_count, data_type>: Remove.
 493         (enum tui_data_type): Remove.
 494
 495         * tui/tui-data.c (tui_data_window::clear_detail)
 496         (~tui_data_window): Update.
 497
 498 2019-06-25  Tom Tromey  <tom@tromey.com>
 499
 500         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 501         declare.
 502         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 503         Rename from tui_first_data_item_displayed.  Update.
 504         (tui_data_window::refresh_all)
 505         (tui_data_window::do_scroll_vertical): Update.
 506         * tui/tui-data.h (struct tui_data_window)
 507         <first_data_item_displayed>: Declare new method.
 508
 509 2019-06-25  Tom Tromey  <tom@tromey.com>
 510
 511         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 512         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 513         contents...
 514         (tui_initialize_static_data): ...here.
 515
 516 2019-06-25  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 519         (tui_display_registers_from, tui_check_register_values): Update.
 520         (tui_display_register): Remove win_info parameter; update.
 521         (tui_get_register): Change type of parameters.
 522         * tui/tui-data.h (struct tui_data_element): Remove.
 523         (union tui_which_element) <data>: Remove.
 524         <data_window>: Change type.
 525         (struct tui_data_item_window): New.
 526         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 527         case.  Add assert.
 528         (~tui_data_item_window): New destructor.
 529         (free_content_elements): Remove DATA_ITEM_WIN case.
 530
 531 2019-06-25  Tom Tromey  <tom@tromey.com>
 532
 533         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 534         Remove.
 535
 536 2019-06-25  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-data.h (struct tui_command_element): Remove.
 539         (union tui_which_element) <command>: Remove.
 540         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 541         assert.
 542         (free_content_elements): Remove CMD_WIN case.
 543
 544 2019-06-25  Tom Tromey  <tom@tromey.com>
 545
 546         * tui/tui-layout.c (tui_set_layout): Update.
 547         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 548         * tui/tui-data.c (layout_def): Update.
 549
 550 2019-06-25  Tom Tromey  <tom@tromey.com>
 551
 552         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 553         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 554         (tui_source_window_base::set_new_height): Update.
 555         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 556         Update.
 557         (tui_set_locator_fullname, tui_set_locator_info)
 558         (tui_show_frame_info): Update.
 559         * tui/tui-source.c (tui_set_source_content)
 560         (tui_source_is_displayed): Update.
 561         * tui/tui-layout.c (show_source_disasm_command, show_data)
 562         (show_source_or_disasm_and_command): Update.
 563         * tui/tui-disasm.c (tui_set_disassem_content)
 564         (tui_get_begin_asm_address): Update.
 565         * tui/tui-data.h (struct tui_locator_element): Remove.
 566         (union tui_which_element) <locator>: Remove.
 567         (struct tui_locator_window): New.
 568         (tui_locator_win_info_ptr): Change return type.
 569         * tui/tui-data.c (_locator): Change type.
 570         (tui_locator_win_info_ptr): Change return type.
 571         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 572         (tui_alloc_content): Add assert.
 573
 574 2019-06-25  Tom Tromey  <tom@tromey.com>
 575
 576         * tui/tui-winsource.c
 577         (tui_exec_info_window::maybe_allocate_content): New method.
 578         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 579         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 580         (make_source_or_disasm_window): Add cast.
 581         * tui/tui-data.h (union tui_which_element) <simple_string>:
 582         Remove.
 583         (struct tui_source_info): New.
 584         (struct tui_source_window_base) <execution_info>: Change type.
 585         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 586         case, and add assert.
 587         (tui_alloc_content): Add assert.
 588
 589 2019-06-25  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 592         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 593         * tui/tui-data.c (tui_alloc_win_info): Remove.
 594
 595 2019-06-25  Tom Tromey  <tom@tromey.com>
 596
 597         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 598         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 599         can_highlight.
 600
 601 2019-06-25  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 604         make_visible_with_new_height method.
 605         (tui_win_info::make_visible_with_new_height): New method.
 606         (tui_source_window_base::do_make_visible_with_new_height)
 607         (tui_data_window::do_make_visible_with_new_height)
 608         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 609         (make_visible_with_new_height): Remove.
 610         (tui_resize_all, tui_adjust_win_heights): Use
 611         make_visible_with_new_height method.
 612         * tui/tui-data.h (struct tui_win_info)
 613         <do_make_visible_with_new_height, make_visible_with_new_height>:
 614         New methods.
 615         (struct tui_source_window_base, struct tui_data_window)
 616         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 617         methods.
 618
 619 2019-06-25  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 622         method.
 623         (update_tab_width): Call update_tab_width method.
 624         * tui/tui-data.h (struct tui_win_info)
 625         (struct tui_source_window_base) <update_tab_width>: New methods.
 626
 627 2019-06-25  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 630         parameter.
 631         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 632         parameter.
 633         (tui_gen_win_info::make_visible): Update.
 634         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 635         parameter.
 636         * tui/tui-data.h (enum tui_box): New enum.
 637         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 638
 639 2019-06-25  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 642         init_and_make_win for EXEC_INFO_WIN.
 643         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 644         longer inline.
 645         (struct tui_win_info) <~tui_win_info>: Inline.
 646         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 647         Don't declare.
 648         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 649         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 650         Remove.
 651         (tui_initialize_static_data): Update.
 652         (~tui_gen_win_info): Handle more cleanup here.
 653         (~tui_source_window_base): Delete "execution_info".
 654         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 655
 656 2019-06-25  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-layout.c (make_command_window): Don't set
 659         can_highlight.
 660         (show_source_disasm_command): Call the reset method.
 661         (show_data): Don't set can_highlight.  Call the reset method.
 662         (tui_gen_win_info::reset): Rename from init_gen_win_info
 663         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 664         (show_source_or_disasm_and_command): Call the reset method.
 665         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 666         (struct tui_cmd_window): Set can_highlight.
 667
 668 2019-06-25  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 671         from make_visible.
 672         (tui_make_visible, tui_make_invisible): Rewrite.
 673         (tui_win_info::make_visible): Remove.
 674         (tui_source_window_base::make_visible): Update.
 675         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 676         method.  Moved from...
 677         (struct tui_win_info) <make_visible>: ...here.
 678
 679 2019-06-25  Tom Tromey  <tom@tromey.com>
 680
 681         * tui/tui-winsource.c
 682         (tui_source_window_base::do_scroll_horizontal): Remove direction
 683         parameter.
 684         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 685         direction parameter.
 686         * tui/tui-win.c (tui_win_info::forward_scroll)
 687         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 688         (tui_win_info::right_scroll): Update.
 689         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 690         direction parameter.
 691         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 692         direction parameter.
 693         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 694         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 695         Remove direction parameter.
 696         (struct tui_source_window_base, struct tui_source_window)
 697         (struct tui_disasm_window, struct tui_data_window)
 698         (struct tui_cmd_window): Update.
 699
 700 2019-06-25  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui-winsource.h (tui_set_exec_info_content)
 703         (tui_show_exec_info_content, tui_erase_exec_info_content)
 704         (tui_clear_exec_info_content, tui_update_exec_info): Change
 705         argument to tui_source_window_base.
 706         * tui/tui-winsource.c (tui_set_exec_info_content)
 707         (tui_show_exec_info_content, tui_erase_exec_info_content)
 708         (tui_clear_exec_info_content, tui_update_exec_info): Change
 709         argument to tui_source_window_base.
 710
 711 2019-06-25  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 714         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 715
 716 2019-06-25  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 719         check.
 720
 721 2019-06-25  Tom Tromey  <tom@tromey.com>
 722
 723         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 724         type to void.
 725         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 726         type to void.
 727         * tui/tui-source.c (tui_set_source_content): Update.
 728         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 729
 730 2019-06-25  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui-win.c (window_name_completer, tui_set_focus)
 733         (tui_all_windows_info): Use name method.
 734         * tui/tui-data.h (struct tui_gen_win_info)
 735         (struct tui_source_window, struct tui_disasm_window)
 736         (struct tui_data_window, struct tui_cmd_window) <name>: New
 737         method.
 738         (tui_win_name): Don't declare.
 739         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 740         (tui_win_name): Remove.
 741
 742 2019-06-25  Tom Tromey  <tom@tromey.com>
 743
 744         * tui/tui-winsource.h (tui_update_source_window)
 745         (tui_update_source_window_as_is): Change parameter type.
 746         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 747         to be a tui_source_window_base.
 748         (tui_update_source_window_as_is): Likewise.
 749         * tui/tui-win.c (make_visible_with_new_height): Update.
 750
 751 2019-06-25  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-winsource.c (tui_erase_source_content)
 754         (tui_show_source_content, tui_show_exec_info_content)
 755         (tui_erase_exec_info_content): Use refresh_window method.
 756         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 757         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 758         from tui_refresh_win.
 759         (tui_data_window::refresh_window): New method.
 760         (tui_win_info::refresh, tui_source_window_base::refresh)
 761         (tui_refresh_all): Use refresh_window method.
 762         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 763         method.
 764         * tui/tui-regs.c (tui_display_register): Call refresh_window
 765         method.
 766         * tui/tui-layout.c (show_source_disasm_command)
 767         (show_source_or_disasm_and_command): Call refresh_window method.
 768         * tui/tui-data.h (struct tui_gen_win_info)
 769         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 770         New method.
 771
 772 2019-06-25  Tom Tromey  <tom@tromey.com>
 773
 774         * tui/tui.c (tui_rl_other_window, tui_enable)
 775         (tui_is_window_visible, tui_get_command_dimension): Update.
 776         * tui/tui-winsource.c (tui_update_source_window_as_is)
 777         (tui_clear_source_content, tui_erase_source_content)
 778         (tui_show_source_line, tui_source_window_base::refill)
 779         (tui_source_window_base::do_scroll_horizontal)
 780         (tui_source_window_base::set_is_exec_point_at)
 781         (tui_update_breakpoint_info, tui_set_exec_info_content)
 782         (tui_alloc_source_buffer, tui_line_is_displayed)
 783         (tui_addr_is_displayed): Update.
 784         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 785         (tui_check_and_display_highlight_if_needed)
 786         (tui_win_info::make_visible, tui_win_info::refresh)
 787         (tui_refresh_all): Update.
 788         * tui/tui-windata.c (tui_first_data_item_displayed)
 789         (tui_delete_data_content_windows, tui_erase_data_content)
 790         (tui_display_all_data, tui_data_window::refresh_all)
 791         (tui_check_data_values): Update.
 792         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 793         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 794         (tui_win_info::backward_scroll, tui_refresh_all_win)
 795         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 796         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 797         (tui_source_window_base::set_new_height)
 798         (tui_data_window::set_new_height)
 799         (make_invisible_and_set_new_height)
 800         (make_visible_with_new_height, new_height_ok)
 801         (parse_scrolling_args): Update.
 802         * tui/tui-stack.c (tui_show_frame_info): Update.
 803         * tui/tui-source.c (tui_set_source_content)
 804         (tui_set_source_content_nil, tui_source_is_displayed)
 805         (tui_source_window::do_scroll_vertical): Update.
 806         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 807         (tui_display_registers_from, tui_display_reg_element_at_line)
 808         (tui_check_register_values, tui_reg_command): Update.
 809         * tui/tui-layout.c (tui_default_win_height)
 810         (show_source_disasm_command, show_data, init_and_make_win)
 811         (show_source_or_disasm_and_command): Update.
 812         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 813         (tui_redisplay_readline, tui_mld_flush)
 814         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 815         (tui_getc): Update.
 816         * tui/tui-disasm.c (tui_set_disassem_content)
 817         (tui_disasm_window::do_scroll_vertical): Update.
 818         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 819         Now virtual.
 820         (struct tui_win_info): Derive from tui_gen_win_info.
 821         <~tui_win_info>: Mark as override.
 822         <generic>: Remove member.
 823         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 824         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 825         (~tui_data_window, ~tui_win_info)
 826         (tui_free_all_source_wins_content): Update.
 827         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 828
 829 2019-06-25  Tom Tromey  <tom@tromey.com>
 830
 831         * tui/tui-layout.c (init_and_make_win): Use new.
 832         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 833         destructor, initializers.
 834         (tui_alloc_generic_win_info): Don't declare.
 835         * tui/tui-data.c (_locator): Add argument to constructor.
 836         (source_win, disasm_win): New globals.
 837         (exec_info): Remove.
 838         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 839         Update.
 840         (tui_alloc_generic_win_info): Remove.
 841         (init_content_element): Use new.
 842         (tui_win_info::tui_win_info): Update.
 843         (free_content_elements) <case DATA_WIN>: Use delete.
 844
 845 2019-06-25  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 848         * tui/tui-windata.c (tui_first_data_item_displayed)
 849         (tui_delete_data_content_windows): Update.
 850         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 851         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 852         (tui_display_registers_from, tui_check_register_values): Update.
 853         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 854         pointer.
 855         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 856         window.
 857         (tui_free_data_content): Update.
 858         (free_content_elements) <case DATA_WIN>: Free the window.
 859
 860 2019-06-25  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 863         Update.
 864         * tui/tui-layout.c (make_command_window)
 865         (show_source_disasm_command, show_data, init_and_make_win)
 866         (show_source_or_disasm_and_command): Update.
 867         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 868         method.
 869         <can_highight, is_highlighted>: Now bool.
 870         (tui_set_win_highlight): Don't declare.
 871         * tui/tui-data.c (tui_set_win_highlight): Remove.
 872
 873 2019-06-25  Tom Tromey  <tom@tromey.com>
 874
 875         * tui/tui-wingeneral.c (make_visible): Remove check of window
 876         type.
 877
 878 2019-06-25  Tom Tromey  <tom@tromey.com>
 879
 880         * tui/tui-win.c (tui_win_info::max_height)
 881         (tui_cmd_window::max_height): New methods.
 882         (new_height_ok): Call max_height.
 883         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 884         <max_height>: New method.
 885
 886 2019-06-25  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-win.c (tui_source_window_base::set_new_height)
 889         (tui_data_window::set_new_height): New methods.
 890         (make_invisible_and_set_new_height): Call set_new_height method.
 891         * tui/tui-data.h (struct tui_win_info)
 892         (struct tui_source_window_base, struct tui_data_window)
 893         <set_new_height>: New method.
 894
 895 2019-06-25  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 898         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 899         tui_refresh_data_win.
 900         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 901         method.
 902         (tui_refresh_all_win): Call the refresh_all method.
 903         (tui_set_focus): Likewise.
 904         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 905         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 906         Likewise.
 907
 908 2019-06-25  Tom Tromey  <tom@tromey.com>
 909
 910         * tui/tui-winsource.h (tui_refill_source_window)
 911         (tui_set_is_exec_point_at): Don't declare.
 912         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 913         (tui_source_window_base::refill): Rename from
 914         tui_refill_source_window.
 915         (tui_source_window_base::do_scroll_horizontal): Update.
 916         (tui_source_window_base::set_is_exec_point_at): Rename from
 917         tui_set_is_exec_point_at.
 918         (tui_update_all_breakpoint_info): Update.
 919         * tui/tui-stack.c (tui_show_frame_info): Update.
 920         * tui/tui-layout.c (show_data): Add cast.
 921         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 922         * tui/tui-data.h (struct tui_source_window_base) <refill,
 923         set_is_exec_point_at>: New methods.
 924         (tui_source_windows, tui_add_to_source_windows): Update types.
 925         (tui_add_to_source_windows): Remove redundant declaration.
 926         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 927         (tui_source_windows): Change return type.
 928         (tui_clear_source_windows_detail): Update.
 929         (tui_add_to_source_windows): Change type of parameter.
 930         (tui_free_all_source_wins_content): Update.
 931
 932 2019-06-25  Tom Tromey  <tom@tromey.com>
 933
 934         * tui/tui-wingeneral.c (tui_win_info::refresh)
 935         (tui_source_window_base::refresh): New methods.
 936         (tui_refresh_all): Call the refresh method.
 937         * tui/tui-data.h (struct tui_win_info)
 938         (struct tui_source_window_base) <refresh>: New method.
 939
 940 2019-06-25  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui.h (tui_is_window_visible): Return bool.
 943         * tui/tui.c (tui_is_window_visible): Return bool.
 944         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 945         (tui_make_visible, tui_make_invisible)
 946         (tui_win_info::make_visible)
 947         (tui_source_window_base::make_visible, make_all_visible)
 948         (tui_make_all_visible, tui_make_all_invisible): Update.
 949         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 950         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 951         bool.
 952         (struct tui_win_info, struct tui_source_window_base)
 953         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 954         * tui/tui-data.c (tui_init_generic_part): Update.
 955
 956 2019-06-25  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 959         (tui_source_window_base::make_visible): New methods.
 960         (make_all_visible): Make method call.
 961         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 962         (struct tui_source_window_base, struct tui_cmd_window): Override
 963         make_visible.
 964         (tui_win_is_source_type): Don't declare.
 965         * tui/tui-data.c (tui_win_is_source_type): Remove.
 966
 967 2019-06-25  Tom Tromey  <tom@tromey.com>
 968
 969         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 970         NULL check.
 971
 972 2019-06-25  Tom Tromey  <tom@tromey.com>
 973
 974         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 975         Inline constructor.  Add initializers for members.
 976         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 977         constructors; now inline in class.
 978
 979 2019-06-25  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-regs.c (tui_show_registers): Update.
 982         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 983         bool.
 984         * tui/tui-data.c (tui_data_window::clear_detail)
 985         (tui_data_window): Update.
 986
 987 2019-06-25  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-windata.c (tui_display_all_data)
 990         (tui_display_data_from_line, tui_display_data_from)
 991         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 992         Update.
 993         * tui/tui-regs.c (tui_last_regs_line_no)
 994         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 995         (tui_show_registers, tui_show_register_group)
 996         (tui_display_registers_from, tui_display_reg_element_at_line)
 997         (tui_display_registers_from_line, tui_check_register_values)
 998         (tui_reg_next, tui_reg_prev): Update.
 999         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1000         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1001         tui_data_window.
1002         (struct tui_win_info) <detail>: Remove.  Add new fields from
1003         tui_data_info.
1004         (TUI_DATA_WIN): Add cast.
1005         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1006         (~tui_data_window): Simplify.
1007
1008 2019-06-25  Tom Tromey  <tom@tromey.com>
1009
1010         * tui/tui-layout.c (show_source_disasm_command)
1011         (show_source_or_disasm_and_command): Update.
1012         * tui/tui-io.c (update_cmdwin_start_line)
1013         (tui_redisplay_readline): Update.
1014         * tui/tui-data.h (struct tui_command_info): Remove.
1015         (struct tui_win_info) <detail>: Remove command_info member.
1016         (struct tui_data_window) <start_line>: New member, from
1017         tui_command_info.
1018         (TUI_CMD_WIN): Add casts.
1019
1020 2019-06-25  Tom Tromey  <tom@tromey.com>
1021
1022         * tui/tui-winsource.c (tui_update_source_window)
1023         (tui_refill_source_window)
1024         (tui_source_window_base::do_scroll_horizontal)
1025         (tui_update_breakpoint_info, tui_set_exec_info_content)
1026         (tui_show_exec_info_content, tui_erase_exec_info_content)
1027         (tui_clear_exec_info_content): Update.
1028         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1029         Update.
1030         * tui/tui-win.c (make_invisible_and_set_new_height)
1031         (make_visible_with_new_height): Update.
1032         * tui/tui-source.c (tui_set_source_content)
1033         (tui_show_symtab_source): Update.
1034         * tui/tui-layout.c (extract_display_start_addr)
1035         (show_source_disasm_command, show_data)
1036         (make_source_or_disasm_window)
1037         (show_source_or_disasm_and_command): Update.
1038         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1039         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1040         "gdbarch".
1041         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1042         to tui_source_window_base.
1043         (struct tui_win_info) <detail>: Remove source_info member.
1044         (struct tui_source_window_base) <has_locator>: Inline.
1045         Move contents from tui_source_info; rename has_locator member to
1046         m_has_locator.
1047         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1048         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1049         header file.
1050         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1051         Simplify.
1052         (tui_free_all_source_wins_content): Cast to
1053         tui_source_window_base.
1054
1055 2019-06-25  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-win.c (make_invisible_and_set_new_height)
1058         (make_visible_with_new_height): Call has_locator method.
1059         * tui/tui-layout.c (show_source_disasm_command, show_data)
1060         (show_source_or_disasm_and_command): Update for bool change.
1061         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1062         (tui_win_info) <has_locator>: New method.
1063         (struct tui_source_window_base) <has_locator>: New method.
1064         (tui_win_has_locator): Don't declare.
1065         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1066         from tui_win_has_locator.
1067         (tui_source_window_base): Use false, not FALSE.
1068
1069 2019-06-25  Tom Tromey  <tom@tromey.com>
1070
1071         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1072         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1073         clear_detail method directly.
1074         (tui_clear_win_detail): Remove.
1075
1076 2019-06-25  Tom Tromey  <tom@tromey.com>
1077
1078         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1079         "this", not TUI_DISASM_WIN.
1080
1081 2019-06-25  Tom Tromey  <tom@tromey.com>
1082
1083         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1084         declare.
1085         * tui/tui-winsource.c
1086         (tui_source_window_base::do_scroll_horizontal): Rename from
1087         tui_horizontal_source_scroll.
1088         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1089         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1090         from tui_vertical_data_scroll.
1091         * tui/tui-win.h (tui_scroll): Don't declare.
1092         * tui/tui-win.c (tui_win_info::forward_scroll)
1093         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1094         (tui_win_info::right_scroll): Rename and update.
1095         (tui_scroll_forward_command, tui_scroll_backward_command)
1096         (tui_scroll_left_command, tui_scroll_right_command): Update.
1097         (tui_scroll): Remove.
1098         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1099         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1100         from tui_vertical_source_scroll.
1101         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1102         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1103         from tui_vertical_disassem_scroll.
1104         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1105         do_scroll_horizontal>: New methods.
1106         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1107         Likewise.
1108         (struct tui_source_window_base): Add do_scroll_horizontal.
1109         (struct tui_source_window, struct tui_disasm_window): Add
1110         do_scroll_vertical.
1111         (struct tui_data_window, struct tui_cmd_window): Add
1112         do_scroll_horizontal and do_scroll_vertical.
1113         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1114
1115 2019-06-25  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui-data.h (struct tui_source_window_base): New struct.
1118         (struct tui_source_window): Derive from tui_source_window_base.
1119         (struct tui_disasm_window): New struct.
1120         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1121         from tui_source_window::clear_detail.
1122         (tui_source_window_base): Rename from tui_source_window.
1123         (~tui_source_window_base): Rename from ~tui_source_window.
1124         (tui_alloc_win_info): Create a tui_disasm_window.
1125
1126 2019-06-25  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-data.h (struct tui_source_window)
1129         (struct tui_data_window): Declare destructors.
1130         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1131         destructors.
1132         (tui_win_info): Simplify.
1133
1134 2019-06-25  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-winsource.c (tui_display_main)
1137         (tui_update_source_windows_with_addr)
1138         (tui_update_all_breakpoint_info): Update.
1139         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1140         (new_height_ok, parse_scrolling_args): Update.
1141         * tui/tui-stack.c (tui_show_frame_info): Update.
1142         * tui/tui-data.h (struct tui_list): Remove.
1143         (tui_source_windows): Return a reference to a std::vector.
1144         * tui/tui-data.c (source_windows): Now a std::vector.
1145         (tui_source_windows): Change return type.
1146         (tui_clear_source_windows): Rewrite.
1147         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1148         (tui_free_all_source_wins_content): Rewrite.
1149
1150 2019-06-25  Tom Tromey  <tom@tromey.com>
1151
1152         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1153         (struct tui_data_window, struct tui_cmd_window): Declare
1154         clear_detail method.
1155         * tui/tui-data.c (tui_source_window::clear_detail)
1156         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1157         methods.
1158         (tui_clear_win_detail): Simplify.
1159
1160 2019-06-25  Tom Tromey  <tom@tromey.com>
1161
1162         * tui/tui-layout.c (make_source_window, make_disasm_window)
1163         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1164         Return the new window.
1165         (show_source_disasm_command, show_data)
1166         (show_source_or_disasm_and_command): Update.
1167
1168 2019-06-25  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1171         parameter.  Return the new window.
1172         (show_source_disasm_command): Update and remove NULL check.
1173         (show_source_or_disasm_and_command): Update.
1174
1175 2019-06-25  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1178
1179 2019-06-25  Tom Tromey  <tom@tromey.com>
1180
1181         * tui/tui-data.h (struct tui_win_info): Make constructor
1182         protected.  Make destructor virtual.  Add initializers.
1183         (tui_source_window, tui_data_window, tui_cmd_window): New
1184         classes.
1185         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1186         constructor.  Add "type" parameter.
1187         (tui_source_window, tui_data_window, tui_cmd_window): New
1188         constructors.
1189         (tui_alloc_win_info): Instantiate the appropriate subclass.
1190
1191 2019-06-25  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui-win.c (tui_resize_all): Use delete.
1194         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1195         destructor.
1196         (tui_free_window): Don't declare.
1197         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1198         Update.
1199
1200 2019-06-25  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-data.h (struct tui_win_info): Add constructor.
1203         * tui/tui-data.c (tui_alloc_win_info): Use new.
1204         (tui_free_window): Use delete.
1205
1206 2019-06-22  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1209         declare.
1210         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1211
1212 2019-06-22  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1215         declare.
1216         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1217
1218 2019-06-22  Tom de Vries  <tdevries@suse.de>
1219
1220         * dwarf2read.c (create_addrmap_from_aranges)
1221         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1222         instead of '%zu'.
1223
1224 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1225
1226         * dwarf2read.h (dwarf2_section_info_def): Remove.
1227         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1228         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1229         std::vector<dwarf2_section_info>.
1230         (struct dwo_file) <~dwo_file>: Remove.
1231         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1232         types field.
1233         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1234         (dwarf2_read_debug_names): Likewise.
1235         (create_debug_types_hash_table): Change parameter type to
1236         array_view, adjust code accordingly.
1237         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1238         (partial_die_info::fixup): Likewise.
1239         (determine_prefix): Likewise.
1240         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1241
1242 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1243
1244         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1245         gdb_bfd_ref_ptr.
1246         <~dwo_file>: Remove call to gdb_bfd_unref.
1247         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1248         gdb_bfd_ref_ptr::get.
1249
1250 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1251
1252         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1253         type to htab_up.
1254         * dwarf2read.c (struct dwo_file): Initialize fields.
1255         <~dwo_file>: New.
1256         (free_dwo_file): Remove, move content to ~dwo_file.
1257         (struct dwo_file_deleter): Remove.
1258         (dwo_file_up>: Remove custom deleter.
1259         (free_dwo_files): Remove.
1260         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1261         dwo_files.
1262         (process_skeletonless_type_units): Call unique_ptr::get.
1263         (allocate_dwo_file_hash_table): Add deleter to created hash
1264         table.  Change return type to htab_up.
1265         (lookup_dwo_file_slot): Don't memset dwo_file, call
1266         unique_ptr::get.
1267         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1268         (create_dwo_unit_in_dwp_v2): Likewise.
1269         (open_and_init_dwo_file): Likewise.
1270         (free_dwo_file_from_slot): Remove.
1271
1272 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1273
1274         * dwarf2read.h (struct dwarf2_section_info) <readin,
1275         is_virtual>: Change type to bool.
1276         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1277         true instead of 1.
1278
1279 2019-06-19  Tom Tromey  <tom@tromey.com>
1280
1281         * tui/tui-data.h (tui_init_content_element): Don't declare.
1282
1283 2019-06-19  Tom Tromey  <tom@tromey.com>
1284
1285         * tui/tui-data.h (tui_init_win_info): Don't declare.
1286
1287 2019-06-19  Tom de Vries  <tdevries@suse.de>
1288
1289         * dwarf2read.h (abstract_to_concrete): Change type to
1290         std::unordered_map<sect_offset, std::vector<sect_offset>,
1291         gdb::hash_enum<sect_offset>>.
1292
1293 2019-06-19  Tom Tromey  <tromey@adacore.com>
1294
1295         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1296         EVAL_AVOID_SIDE_EFFECTS specially.
1297
1298 2019-06-19  Tom Tromey  <tromey@adacore.com>
1299
1300         * source-cache.c (highlighter): New global.
1301         (source_cache::get_source_lines): Create a highlighter on demand.
1302
1303 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1304
1305         * defs.h (deprecated_interactive_hook): Delete declaration.
1306         * interps.c (clear_interpreter_hooks): Remove use of
1307         deprecated_interactive_hook.
1308         * top.c (deprecated_interactive_hook): Delete definition.
1309         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1310
1311 2019-06-18  Tom de Vries  <tdevries@suse.de>
1312
1313         PR gdb/24515
1314         * dwarf2read.h (abstract_to_concrete): Change type from
1315         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1316         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1317         * dwarf2read.c (read_variable): Update.
1318         (dwarf2_fetch_die_loc_sect_off): Update.
1319
1320 2019-06-17  Tom de Vries  <tdevries@suse.de>
1321
1322         PR gdb/24617
1323         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1324         accessing parent[parent_len - 1].
1325
1326 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1327
1328         PR gdb/24364
1329         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1330         call dtrace_process_dof with NULL dof.
1331
1332 2019-06-16  Tom de Vries  <tdevries@suse.de>
1333
1334         PR gdb/24445
1335         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1336
1337 2019-06-16  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1340         (make_all_visible): Use address of member.
1341
1342 2019-06-16  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1345         (tui_free_window, free_content, free_content_elements): Remove
1346         unnecessary cast.
1347         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1348         cast.
1349         * tui/tui-regs.c (tui_show_register_group)
1350         (tui_display_registers_from, tui_display_reg_element_at_line):
1351         Remove unnecessary cast.
1352
1353 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1354
1355         * linux-nat.c (normal_mask): Delete.
1356         (_initialize_linux_nat): Don't initialise normal_mask.
1357
1358 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1359
1360         PR gdb/24445
1361         * dwarf-index-write.h (write_psymtabs_to_index): Add
1362         dwz_basename parameter.
1363         * dwarf-index-write.c (write_gdbindex): Move file writing to
1364         write_gdbindex_1.  Change return type void.
1365         (assert_file_size): Move up, remove filename parameter.
1366         (write_gdbindex_1): New function.
1367         (write_debug_names): Change return type to void, call
1368         assert_file_size.
1369         (struct index_wip_file): New struct.
1370         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1371         file logic to index_wip_file.  Write index for dwz file if
1372         needed.
1373         (save_gdb_index_command): Pass basename of dwz file, if present.
1374         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1375         build-id of dwz file, if present.
1376         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1377         (dwarf2_get_dwz_file): Likewise.
1378         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1379         (dwarf2_get_dwz_file): Likewise.
1380
1381 2019-06-16  Tom Tromey  <tom@tromey.com>
1382
1383         * coffread.c (process_coff_symbol): Use xstrdup.
1384         * value.c (create_internalvar): Use xstrdup.
1385
1386 2019-06-16  Tom Tromey  <tom@tromey.com>
1387
1388         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1389         * breakpoint.c (stopin_command, stopat_command)
1390         (until_break_command, decode_location_default): Remove unnecessary
1391         cast.
1392         * utils.c (subset_compare): Remove unnecessary cast.
1393         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1394         cast.
1395         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1396         cast.
1397         * infcmd.c (path_command): Remove unnecessary cast.
1398         * coffread.c (decode_type): Remove unnecessary cast.
1399         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1400         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1401         * tui/tui-stack.c (tui_show_locator_content)
1402         (tui_show_frame_info): Remove unnecessary cast.
1403         * tui/tui-win.c (tui_scroll_forward_command)
1404         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1405         (parse_scrolling_args): Remove unnecessary cast.
1406         * tui/tui-data.c (init_win_info, tui_del_window)
1407         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1408         (free_content_elements): Remove unnecessary cast.
1409         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1410         unnecessary cast.
1411         * tui/tui-source.c (tui_set_source_content)
1412         (tui_vertical_source_scroll): Remove unnecessary cast.
1413         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1414         cast.
1415         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1416         * tui/tui-regs.c (tui_display_registers_from)
1417         (tui_display_register): Remove unnecessary cast.
1418         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1419         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1420         (make_visible): Remove unnecessary cast.
1421         * tui/tui-winsource.c (tui_erase_source_content)
1422         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1423         unnecessary cast.
1424         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1425         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1426         * stabsread.c (read_type, read_array_type, read_range_type):
1427         Remove unnecessary cast.
1428         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1429         (parse_symbol, parse_type, upgrade_type, parse_external)
1430         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1431         unnecessary cast.
1432         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1433
1434 2019-06-16  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-data.c (tui_alloc_generic_win_info)
1437         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1438         checks.
1439
1440 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1441             Andrew Burgess  <andrew.burgess@embecosm.com>
1442
1443         * f-typeprint.c (f_print_type): Don't return early for not
1444         associated or not allocated types.
1445         (f_type_print_varspec_suffix): Add print_rank parameter and print
1446         ranks of array types in case they dangling.
1447         (f_type_print_base): Add print_rank parameter.
1448
1449 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1450
1451         * NEWS: Mention new MI commands.
1452         * break-catch-throw.c (enum exception_event_kind): Move to
1453         breakpoint.h.
1454         (print_mention_exception_catchpoint): Output text as a single
1455         message.
1456         (catch_exception_command_1): Rename to...
1457         (catch_exception_event): ...this, make non-static, update header
1458         command, and change some parameter types.
1459         (catch_catch_command): Update for changes to
1460         catch_exception_command_1.
1461         (catch_throw_command): Likewise.
1462         (catch_rethrow_command): Likewise.
1463         * breakpoint.c (enum exception_event_kind): Delete.
1464         * breakpoint.h (enum exception_event_kind): Moved here from
1465         break-catch-throw.c.
1466         (catch_exception_event): Declare.
1467         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1468         (mi_cmd_catch_throw): New function.
1469         (mi_cmd_catch_rethrow): New function.
1470         (mi_cmd_catch_catch): New function.
1471         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1472         'catch-catch' entries.
1473         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1474         (mi_cmd_catch_rethrow): Declare.
1475         (mi_cmd_catch_catch): Declare.
1476
1477 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1478
1479         * annotate.c (annotate_source_line): Change return type to void,
1480         update implementation to match.
1481         * annotate.h (annotate_source_line): Change return type to void,
1482         update header comment.
1483         * stack.c (print_frame_info): Don't change what frame information
1484         is printed based on whether annotations are on or not.
1485
1486 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1487
1488         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1489         (annotate_source): Make static.
1490         (annotate_source_line): Moved from source.c and renamed from
1491         identify_source_line.  Update the return type.
1492         * annotate.h (annotate_source): Delete declaration.
1493         (annotate_source_line): Declaration moved from source.h, and
1494         renamed from identify_source_line.  Return type updated.
1495         * source.c (identify_source_line): Moved to annotate.c and renamed
1496         to annotate_source_line.
1497         (info_line_command): Remove check of annotation_level.
1498         * source.h (identify_source_line): Move declaration to annotate.h
1499         and rename to annotate_source_line.
1500         * stack.c: Add 'annotate.h' include.
1501         (print_frame_info): Remove check of annotation_level before
1502         calling annotate_source_line.
1503
1504 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1505
1506         * source-cache.c (source_cache::get_plain_source_lines): Use
1507         open_source_file_with_line_charpos instead of just
1508         open_source_file, remove call to find_source_lines.
1509         (source_cache::get_source_lines): Likewise.
1510         * source.c (find_source_lines): Make static.
1511         (get_filename_and_charpos): Renamed into...
1512         (open_source_file_with_line_charpos): ..this along with changes to
1513         return a scoped_fd, and some other minor clean ups.
1514         (identify_source_line): Use open_source_file_with_line_charpos.
1515         (search_command_helper): Use open_source_file_with_line_charpos
1516         instead of just open_source_file, remove call to
1517         find_source_lines.
1518         * source.h (open_source_file_with_line_charpos): Declare new
1519         function.
1520         (find_source_lines): Delete declaration.
1521
1522 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1523
1524         * source.c (get_filename_and_charpos): Remove fullname
1525         parameter.
1526         (identify_source_line): Update call to get_filename_and_charpos.
1527
1528 2019-06-14  Tom Tromey  <tromey@adacore.com>
1529
1530         PR gdb/24502:
1531         * ui-style.h (skip_ansi_escape): Update comment.
1532         * ui-file.h (class no_terminal_escape_file): New class.
1533         * ui-file.c (no_terminal_escape_file::write)
1534         (no_terminal_escape_file::puts): New methods.
1535         * cli/cli-logging.c (handle_redirections): Use
1536         no_terminal_escape_file.
1537
1538 2019-06-14  Tom Tromey  <tromey@adacore.com>
1539
1540         * NEWS: Move convenience variable news above Python news.
1541
1542 2019-06-14  Tom Tromey  <tom@tromey.com>
1543
1544         * gnulib: Move directory to top-level.
1545         * configure.ac: Don't configure gnulib.
1546         * configure: Rebuild.
1547         * common/common-defs.h: Use new path to gnulib.
1548         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1549         (GNULIB_H): Remove.
1550         (INCGNU): Look in new gnulib location.
1551         (HFILES_NO_SRCDIR): Remove gnulib files.
1552         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1553         (generated_files): Remove GNULIB_H.
1554         ($(LIBGNU), all-lib): Remove targets.
1555         (distclean): Don't mention GNULIB_BUILDDIR.
1556         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1557
1558 2019-06-14  Tom Tromey  <tromey@adacore.com>
1559
1560         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1561         Warn if symbol file does not provide any symbols.
1562
1563 2019-06-14  Tom Tromey  <tromey@adacore.com>
1564
1565         * source.c (find_and_open_source): Respect basenames_may_differ.
1566
1567 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1568
1569         * annotate.c (annotate_breakpoints_invalid): Make use of
1570         scoped_restore_terminal_state.
1571         (annotate_frames_invalid): Likewise.
1572
1573 2019-06-14  Tom Tromey  <tromey@adacore.com>
1574
1575         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1576         allow assignment to an internalvar.
1577
1578 2019-06-14  Tom Tromey  <tromey@adacore.com>
1579
1580         * ada-lex.l: Allow "_" in attribute names.
1581
1582 2019-06-14  Tom Tromey  <tromey@adacore.com>
1583
1584         PR gdb/24653:
1585         * regcache.c (registers_changed): Don't call alloca.
1586         * top.c (execute_command): Don't call alloca.
1587
1588 2019-06-13  Pedro Alves  <palves@redhat.com>
1589
1590         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1591         'expression'.  When parsing an expression, error out if there's
1592         junk after "unlimited".
1593         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1594         (do_set_command): Adjust calls to is_unlimited_literal.
1595
1596 2019-06-13  Pedro Alves  <palves@redhat.com>
1597
1598         * compile/compile.c (make_compile_options_def_group): Add braces
1599         around array_view initializer.
1600         * thread.c (make_thread_apply_all_options_def_group)
1601         (make_thread_apply_all_options_def_group): Likewise.
1602
1603 2019-06-13  Pedro Alves  <palves@redhat.com>
1604
1605         * NEWS (New commands): Mention "maint test-options
1606         require-delimiter", "maint test-options unknown-is-error", "maint
1607         test-options unknown-is-operand" and "maint show
1608         test-options-completion-result".
1609         (New command options, command completion): New section.
1610         (Completion improvements): New section.
1611         Mention that you can abbreviate "unlimited".
1612
1613 2019-06-13  Pedro Alves  <palves@redhat.com>
1614
1615         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1616         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1617         * unittests/cli-utils-selftests.c (test_parse_flags)
1618         (test_parse_flags_qcs): Delete.
1619         (test_cli_utils): Don't call deleted functions.
1620
1621 2019-06-13  Pedro Alves  <palves@redhat.com>
1622
1623         * thread.c: Include "cli/cli-option.h".
1624         (tp_array_compar_ascending): Global.
1625         (tp_array_compar): Delete function.
1626         (tp_array_compar_ascending, tp_array_compar_descending): New
1627         functions.
1628         (ascending_option_def, qcs_flag_option_def)
1629         (thr_qcs_flags_option_defs)
1630         (make_thread_apply_all_options_def_group)
1631         (make_thread_apply_options_def_group): New.
1632         (thread_apply_all_command): Use gdb::option::process_options.
1633         (thread_apply_command_completer)
1634         (thread_apply_all_command_completer): New.
1635         (thread_apply_command): Use gdb::option::process_options.
1636         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1637         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1638         to generate help text of "thread apply".  Adjust "taas"'s help.
1639         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1640         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1641
1642 2019-06-13  Pedro Alves  <palves@redhat.com>
1643
1644         * thread.c (thread_apply_command): Check for invalid TID with
1645         isdigit instead of !isalpha.
1646
1647 2019-06-13  Pedro Alves  <palves@redhat.com>
1648
1649         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1650         (validate_flags_qcs): New.
1651         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1652         (validate_flags_qcs): Declare.
1653         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1654         (make_frame_apply_options_def_group): New.
1655         (frame_apply_command_count): Process options with
1656         gdb::option::process_options.
1657         (frame_apply_completer): New.
1658         (frame_apply_level_completer, frame_apply_all_completer)
1659         (frame_apply_completer): New.
1660         (_initialize_stack): Update help of "frame apply", "frame apply
1661         level", "frame apply all" and "faas" to mention supported options
1662         and install command completers.
1663         * stack.h (frame_apply_all_completer): Declare.
1664         * thread.c: Include "stack.h".
1665         (tfaas_command): Add "--".
1666         (_initialize_thread): Update help "tfaas" to mention supported
1667         options and install command completer.
1668
1669 2019-06-13  Pedro Alves  <palves@redhat.com>
1670
1671         * completer.c (complete_nested_command_line): New.
1672         (gdb_completion_word_break_characters_throw): Add assertion.
1673         * completer.h (complete_nested_command_line): Declare.
1674
1675 2019-06-13  Pedro Alves  <palves@redhat.com>
1676
1677         * stack.c (parse_backtrace_qualifiers): New.
1678         (backtrace_command): Use it.
1679         (backtrace_command_completer): Complete on qualifiers.
1680
1681 2019-06-13  Pedro Alves  <palves@redhat.com>
1682
1683         * frame.c: Include "cli/cli-option.h.
1684         (user_set_backtrace_options): New.
1685         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1686         Delete.
1687         (get_prev_frame): Adjust.
1688         (boolean_option_def, uinteger_option_def)
1689         (set_backtrace_option_defs): New.
1690         (_initialize_frame): Adjust and use
1691         gdb::option::add_setshow_cmds_for_options to install "set
1692         backtrace past-main" and "set backtrace past-entry".
1693         * frame.h: Include "cli/cli-option.h".
1694         (struct frame_print_options): Forward declare.
1695         (print_frame_arguments_all, print_frame_arguments_scalars)
1696         (print_frame_arguments_none): Declare.
1697         (print_entry_values): Delete declaration.
1698         (struct frame_print_options, user_frame_print_options): New.
1699         (struct set_backtrace_options): New.
1700         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1701         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1702         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1703         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1704         (list_args_or_locals): Add frame_print_options parameter.
1705         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1706         * python/py-framefilter.c (enumerate_args): Pass down
1707         USER_FRAME_PRINT_OPTIONS.
1708         * stack.c: Include "cli/cli-option.h".
1709         (print_frame_arguments_all, print_frame_arguments_scalars)
1710         (print_frame_arguments_none): Declare.
1711         (print_raw_frame_arguments, print_entry_values): Delete.
1712         (user_frame_print_options): New.
1713         (boolean_option_def, enum_option_def, frame_print_option_defs):
1714         New.
1715         (struct backtrace_cmd_options): New.
1716         (bt_flag_option_def): New.
1717         (backtrace_command_option_defs): New.
1718         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1719         (print_frame_arg, read_frame_arg, print_frame_args)
1720         (print_frame_info, print_frame): Add frame_print_options parameter
1721         and use it.
1722         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1723         (backtrace_command_1): Add frame_print_options and
1724         backtrace_cmd_options parameters and use them.
1725         (make_backtrace_options_def_group): New.
1726         (backtrace_command): Process command options with
1727         gdb::option::process_options.
1728         (backtrace_command_completer): New.
1729         (_initialize_stack): Extend "backtrace"'s help to mention
1730         supported options.  Install completer for "backtrace".
1731         Install some settings commands with add_setshow_cmds_for_options.
1732
1733 2019-06-13  Pedro Alves  <palves@redhat.com>
1734
1735         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1736         and that "set/show print raw frame-arguments" are now deprecated.
1737
1738         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1739         command.
1740         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1741         * stack.c (_initialize_stack): Install "set/show print
1742         raw-frame-arguments", and deprecate "set/show print raw
1743         frame-arguments".
1744         * valprint.c (_initialize_valprint): Deprecate "set/show print
1745         raw".
1746
1747 2019-06-13  Pedro Alves  <palves@redhat.com>
1748
1749         * compile/compile.c (struct compile_options): New.
1750         (compile_flag_option_def, compile_command_option_defs)
1751         (make_compile_options_def_group): New.
1752         (compile_file_command): Handle options with
1753         gdb::option::process_options.
1754         (compile_file_command_completer): New function.
1755         (compile_code_command): Handle options with
1756         gdb::option::process_options.
1757         (compile_code_command_completer): New function.
1758         (_initialize_compiler): Install completers for "compile code" and
1759         "compile file".  Mention available options in "compile code" and
1760         "compile code"'s help.
1761         * completer.c (advance_to_completion_word): New, factored out from
1762         ...
1763         (advance_to_expression_complete_word_point): ... this.
1764         (advance_to_filename_complete_word_point): New.
1765         * completer.h (advance_to_filename_complete_word_point): New
1766         declaration.
1767
1768 2019-06-13  Pedro Alves  <palves@redhat.com>
1769
1770         * compile/compile.c: Include "cli/cli-option.h".
1771         (compile_print_value): Scope data pointer is now a
1772         value_print_options pointer; adjust.
1773         (compile_print_command): Process options.  Scope data pointer is
1774         now a value_print_options pointer; adjust.
1775         (_initialize_compile): Update "compile print"'s help to include
1776         supported options.  Install a completer for "compile print".
1777         * cp-valprint.c (show_vtblprint, show_objectprint)
1778         (show_static_field_print): Delete.
1779         (_initialize_cp_valprint): Don't install "set print
1780         static-members", "set print vtbl", "set print object" here.
1781         * printcmd.c: Include "cli/cli-option.h" and
1782         "common/gdb_optional.h".
1783         (print_command_parse_format): Rework to fill in a
1784         value_print_options instead of a format_data.
1785         (print_value): Change parameter type from format_data pointer to
1786         value_print_options reference.  Adjust.
1787         (print_command_1): Process options.  Adjust to pass down a
1788         value_print_options.
1789         (print_command_completer): New.
1790         (_initialize_printcmd): Install print_command_completer as
1791         handle_brkchars completer for the "print" command.  Update
1792         "print"'s help to include supported options.
1793         * valprint.c: Include "cli/cli-option.h".
1794         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1795         here from cp-valprint.c.
1796         (boolean_option_def, uinteger_option_def)
1797         (value_print_option_defs, make_value_print_options_def_group):
1798         New.  Use gdb::option::add_setshow_cmds_for_options to install
1799         "set print elements", "set print null-stop", "set print repeats",
1800         "set print pretty", "set print union", "set print array", "set
1801         print address", "set print symbol", "set print array-indexes".
1802         * valprint.h: Include <string> and "cli/cli-option.h".
1803         (make_value_print_options_def_group): Declare.
1804         (print_value): Change parameter type from format_data pointer to
1805         value_print_options reference.
1806         (print_command_completer): Declare.
1807
1808 2019-06-13  Pedro Alves  <palves@redhat.com>
1809
1810         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1811         (COMMON_SFILES): Add maint-test-settings.c.
1812         * cli/cli-decode.c (boolean_enums): New global, factored out from
1813         ...
1814         (add_setshow_boolean_cmd): ... here.
1815         * cli/cli-decode.h (boolean_enums): Declare.
1816         * cli/cli-option.c: New file.
1817         * cli/cli-option.h: New file.
1818         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1819         factored out from ...
1820         (parse_cli_boolean_value(const char *)): ... this.
1821         (is_unlimited_literal): Change parameter type to pointer to
1822         pointer.  Adjust and advance ARG pointer.
1823         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1824         (parse_cli_var_enum): New, factored out from ...
1825         (do_set_command): ... this.  Adjust.
1826         * cli/cli-setshow.h (parse_cli_boolean_value)
1827         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1828         (parse_cli_var_enum): Declare.
1829         * cli/cli-utils.c: Include "cli/cli-option.h".
1830         (get_ulongest): New.
1831         * cli/cli-utils.h (get_ulongest): Declare.
1832         (check_for_argument): New overloads.
1833         * maint-test-options.c: New file.
1834
1835 2019-06-13  Pedro Alves  <palves@redhat.com>
1836
1837         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1838         parse a range if "-" is at the end of the string.
1839
1840 2019-06-13  Pedro Alves  <palves@redhat.com>
1841
1842         * cli/cli-setshow.c (parse_auto_binary_operation)
1843         (parse_cli_boolean_value): Don't allow "o".
1844
1845 2019-06-13  Pedro Alves  <palves@redhat.com>
1846
1847         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1848         * NEWS: Mention maint test-settings KIND.
1849         * maint-test-settings.c: New file.
1850
1851 2019-06-13  Pedro Alves  <palves@redhat.com>
1852
1853         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1854         completer.
1855         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1856         "set" completers.
1857
1858 2019-06-13  Pedro Alves  <palves@redhat.com>
1859
1860         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1861         after item.
1862
1863 2019-06-13  Pedro Alves  <palves@redhat.com>
1864
1865         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1866
1867 2019-06-13  Pedro Alves <palves@redhat.com>
1868
1869         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1870         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1871         call.
1872         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1873         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1874         calls.
1875         (check_for_argument): Skip spaces after argument.
1876
1877 2019-06-13  Pedro Alves  <palves@redhat.com>
1878
1879         * thread.c (thread_apply_command): Adjust TID parsing.
1880         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1881         detected before end of string.
1882         (tid_is_in_list): Error out if LIST is invalid.
1883
1884 2019-06-13  Pedro Alves  <palves@redhat.com>
1885
1886         * completer.c (complete_line_internal_1): Rewind completion word
1887         point.
1888         (completion_tracker::advance_custom_word_point_by): Change
1889         parameter type to int.
1890         * completer.h (completion_tracker::advance_custom_word_point_by):
1891         Likewise.
1892
1893 2019-06-13  Pedro Alves  <palves@redhat.com>
1894
1895         * completer.c (advance_to_completion_word): Handle delimiters.
1896
1897 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1898
1899         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1900
1901 2019-06-11  Tom Tromey  <tom@tromey.com>
1902
1903         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1904         (xmalloc_failed): Move to alloc.c.
1905         * alloc.c: New file.
1906         * Makefile.in (COMMON_SFILES): Add alloc.c.
1907
1908 2019-06-11  Tom Tromey  <tom@tromey.com>
1909
1910         * nat/linux-waitpid.c: Don't include server.h.
1911         (linux_debug): Remove.
1912         (my_waitpid): Update.
1913
1914 2019-06-11  Tom Tromey  <tromey@adacore.com>
1915
1916         * infcall.c (_initialize_infcall): Remove trailing newline from
1917         help.
1918         * user-regs.c (_initialize_user_regs): Remove trailing newline
1919         from help.
1920         * typeprint.c (_initialize_typeprint): Remove trailing newline
1921         from help.
1922         * reverse.c (_initialize_reverse): Remove trailing newlines from
1923         help.
1924         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1925         from help.
1926         * language.c (add_set_language_command): Remove trailing newline
1927         from help.
1928         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1929         help.
1930         * disasm.c (_initialize_disasm): Remove trailing newline from
1931         help.
1932         * top.c (init_main): Remove trailing newline from help.
1933         * interps.c (_initialize_interpreter): Remove trailing newline
1934         from help.
1935         * btrace.c (_initialize_btrace): Remove trailing newlines from
1936         help.
1937         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1938         from help.
1939         * python/python.c (_initialize_python): Remove trailing newline
1940         from help.
1941         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1942         help.
1943         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1944         from help.  Reformat some text.
1945         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1946         from help.
1947         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1948         newline from help.
1949
1950 2019-06-11  Tom Tromey  <tromey@adacore.com>
1951
1952         * darwin-nat.c (darwin_decode_exception_message)
1953         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1954
1955 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1956
1957         * valops.c (value_slice): Check for not allocated or not
1958         associated values.
1959
1960 2019-06-10  Tom de Vries  <tdevries@suse.de>
1961
1962         PR gdb/24618
1963         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1964         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1965         invalid.
1966
1967 2019-06-10  Tom de Vries  <tdevries@suse.de>
1968
1969         PR gdb/24611
1970         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1971         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1972
1973 2019-06-10  Tom de Vries  <tdevries@suse.de>
1974
1975         PR symtab/24545
1976         * symtab.c (struct demangled_name_entry): Add language field.
1977         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1978         static minimal symbol".  Set and use language field.
1979
1980 2019-06-10  Tom Tromey  <tromey@adacore.com>
1981
1982         * ada-lang.c (_initialize_ada_language): Update help text.
1983
1984 2019-06-10  Tom Tromey  <tromey@adacore.com>
1985
1986         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1987         with a newline.
1988         * guile/guile.c (handle_boot_error): Don't end warning with a
1989         newline.
1990         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1991         warning with a newline.
1992         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1993         newline.
1994         (s12z_frame_cache): Likewise.
1995         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1996         a newline.
1997         * solib-svr4.c (disable_probes_interface): Don't end warning with
1998         a newline.
1999         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2000         newline.
2001         * python/python.c (do_finish_initialization): Don't end warning
2002         with a newline.
2003
2004 2019-06-10  Tom Tromey  <tom@tromey.com>
2005
2006         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2007         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2008         gdbpy_enter.
2009
2010 2019-06-10  Tom Tromey  <tromey@adacore.com>
2011
2012         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2013         data.
2014         (elf_new_init): Don't call stabsread_new_init.
2015         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2016         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2017         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2018
2019 2019-06-10  Tom de Vries  <tdevries@suse.de>
2020
2021         PR symtab/16264
2022         PR symtab/24517
2023         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2024
2025 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2026
2027         * source.c (find_and_open_source): Also rewrite relative file
2028         names.
2029
2030 2019-04-26  Amos Bird  <amosbird@gmail.com>
2031
2032         * annotate.c (annotate_thread_exited): Add "thread-exited"
2033         annotation.
2034
2035 2019-06-06  Tom Tromey  <tromey@adacore.com>
2036
2037         * maint.h (class scoped_command_stats): Use
2038         DISABLE_COPY_AND_ASSIGN.
2039         <print_time>: New method.
2040         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2041         print_time.
2042         (scoped_command_stats::print_time): New method.
2043
2044 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2045
2046         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2047         instructions of lengths 6 or 8 bytes.
2048
2049 2019-06-04  Pedro Alves  <palves@redhat.com>
2050
2051         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2052
2053         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2054         * breakpoint.c (condition_completer): Likewise.
2055         * cli/cli-dump.c (scan_expression): Likewise.
2056         * common/filestuff.c (mkdir_recursive): Likewise.
2057         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2058         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2059         (gdb_abspath): Likewise.
2060         * compile/compile-cplus-types.c
2061         (compile_cplus_instance::decl_name): Likewise.
2062         * completer.c (complete_explicit_location):
2063         (signal_completer, reg_or_group_completer_1): Likewise.
2064         * cp-support.c (cp_remove_params_if_any): Likewise.
2065         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2066         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2067         * infcmd.c (strip_bg_char): Likewise.
2068         * linespec.c (copy_token_string): Likewise.
2069         * mi/mi-main.c (output_cores): Likewise.
2070         * psymtab.c (psymtab_search_name):
2071         * symfile.c (test_set_ext_lang_command): Likewise.
2072         * target.c (target_fileio_read_stralloc): Likewise.
2073         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2074         * value.c (complete_internalvar): Likewise.
2075
2076 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2077
2078         Add objfile property to gdb.Type.
2079         * NEWS: Mention Python API addition.
2080         * python/py-type.c (typy_get_objfile): New method.
2081
2082 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2083
2084         * NEWS: Mention the new set|show style [title|highlight].
2085         Mention changes to "show style", "help" and "apropos".
2086
2087 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2088
2089         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2090         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2091         instead of print_help_for_command.
2092         (print_doc_of_command): New function.
2093         (help_list): Add 'apropos -v word' suggestion.
2094         (print_help_for_command): Style the command name using title style.
2095         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2096         (_initialize_cli_cmds): Describe -v in apropos_command help.
2097
2098 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2099
2100         * cli/cli-style.h (cli_style_option): Add name in constructor,
2101         add m_name class member, add constructor with intensity,
2102         add name class function.
2103         (cli_style_option::add_setshow_commands): Remove name argument.
2104         (highlight_style, title_style): New styles.
2105         * cli/cli-style.c (do_show): New function that shows a style
2106         characteristic styling the style name with itself.
2107         (set_style_name): New function.
2108         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2109         Update all callers according to the changes in cli/cli-style.h.
2110         * utils.h (fputs_highlighted): New function.
2111         * utils.c (fputs_highlighted): Likewise.
2112
2113 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2114
2115         * NEWS: Mention new pipe command and new convenience variables.
2116
2117 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2118
2119         * cli/cli-cmds.c (pipe_command): New function.
2120         (_initialize_cli_cmds): Call add_com for pipe_command.
2121         Define | as an alias for pipe.
2122         (exit_status_set_internal_vars): New function.
2123         (shell_escape): Call exit_status_set_internal_vars.
2124         cli/cli-decode.c (find_command_name_length): Recognize | as
2125         a single character command.
2126
2127 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2128
2129         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2130         top.c (execute_command_to_ui_file): New function, mostly a copy
2131         of execute_command_to_string.
2132         (execute_command_to_string): Implement by calling
2133         execute_command_to_ui_file.
2134
2135 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2136
2137         * top.h (saved_command_line): Remove declaration.
2138         * top.c (previous_saved_command_line, previous_repeat_arguments):
2139         New variables.
2140         (saved_command_line): Make static, define together with other
2141         'repeat variables'.
2142         (dont_repeat): Clear repeat_arguments.
2143         (repeat_previous, get_saved_command_line, save_command_line):
2144         New functions.
2145         (gdb_init): Initialize saved_command_line
2146         and previous_saved_command_line.
2147         * main.c (captured_main_1): Remove saved_command_line initialization.
2148         * event-top.c (handle_line_of_input): Update to use
2149         the new 'repeat' related functions instead of direct access to
2150         saved_command_line.
2151         * command.h (repeat_previous, get_saved_command_line,
2152         save_command_line): New declarations.
2153         (dont_repeat): Add comment.
2154
2155 2019-05-30  Tom Tromey  <tromey@adacore.com>
2156
2157         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2158         Fix comment.
2159         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2160
2161 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2162
2163         PR cli/24587
2164         * completer.c (complete): Initialize variable word.
2165
2166 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2167
2168         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2169         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2170         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2171         'body' is NULL to the outter 'if', protecting the '!is_define'
2172         situation as well.
2173
2174 2019-05-29  Tom Tromey  <tromey@adacore.com>
2175
2176         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2177         (dwarf_unknown): New function.
2178         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2179         (dwarf_type_encoding_name): Use dwarf_unknown.
2180
2181 2019-05-29  Tom Tromey  <tromey@adacore.com>
2182
2183         PR c++/20020:
2184         * cp-valprint.c (cp_print_value_fields): Call
2185         cp_print_static_field inside "try".
2186
2187 2019-05-29  Tom Tromey  <tromey@adacore.com>
2188
2189         * inflow.c (struct terminal_info): Add default operator=.
2190         * configure: Rebuild.
2191         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2192         -Wdeprecated-copy-dtor, -Wredundant-move.
2193
2194 2019-05-29  Tom Tromey  <tromey@adacore.com>
2195
2196         * NEWS: Add entry.
2197         * infcmd.c (print_return_value_1): Handle finish_print
2198         option.
2199         (show_print_finish): New function.
2200         (_initialize_infcmd): Add "set/show print finish" commands.
2201         * valprint.c (user_print_options): Initialize new member.
2202         * valprint.h (struct value_print_options) <finish_print>: New
2203         member.
2204
2205 2019-05-28  Tom Tromey  <tromey@adacore.com>
2206
2207         * ada-lang.c (ada_remove_Xbn_suffix)
2208         (find_old_style_renaming_symbol)
2209         (parse_old_style_renaming): Remove.
2210         (ada_find_renaming_symbol): Don't call
2211         find_old_style_renaming_symbol.
2212         (ada_is_renaming_symbol): Rename from
2213         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2214         bool.  Now static.
2215         (ada_read_var_value): Update and simplify.
2216         * ada-exp.y (write_var_or_type): Remove old code.
2217
2218 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2219
2220         * event-top.c: Remove include comment.
2221         * inflow.c (class scoped_ignore_sigttou): Move from here...
2222         * inflow.h (class scoped_ignore_sigttou): ...to here.
2223         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2224         * top.c:  Remove include comment.
2225
2226 2019-05-27  Tom Tromey  <tom@tromey.com>
2227
2228         * NEWS: Fix typo.
2229
2230 2019-05-22  Tom Tromey  <tromey@adacore.com>
2231
2232         * target.c (target_follow_exec): Constify parameter.
2233         * target-delegates.c: Rebuild.
2234         * remote.c (remote_target::follow_exec): Constify parameter.
2235         * infrun.c (follow_exec): Constify parameter.
2236         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2237         (target_follow_exec): Likewise.
2238
2239 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2240
2241         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2242         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2243
2244 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2245
2246         * NEWS: Add debugredirect and testsuite sections.
2247
2248 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2249
2250         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2251         target descriptions using exclusively floating point register name
2252         aliases.
2253
2254 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2255
2256         PR gdb/18644:
2257         * f-lang.c (build_fortran_types): Handle the case where
2258         gdbarch_floatformat_for_type returns a nullptr.
2259
2260 2019-05-21  Tom de Vries  <tdevries@suse.de>
2261
2262         PR cli/24587
2263         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2264
2265 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2266
2267         PR gdb/18644:
2268         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2269         16-byte floats.
2270         * i386-tdep.c (i386_floatformat_for_type): Use
2271         floatformats_ia64_quad for the 16-byte floating point component
2272         within a fortran 32-byte complex number.
2273
2274 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2275
2276         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2277         delete default constructor.
2278         (find_partial_die): Update to return const struct.
2279         (partial_die_parent_scope): Move variable declaration into scope
2280         of its use and change its type to auto.
2281         (guess_partial_die_structure_name): Likewise.
2282         (partial_die_info::fixup): Likewise.
2283
2284 2019-05-17  Tom Tromey  <tromey@adacore.com>
2285
2286         * source.c (find_and_open_source): Remove cast.
2287
2288 2019-05-17  Tom Tromey  <tromey@adacore.com>
2289
2290         * annotate.c (annotate_source): Make "filename" const.
2291         * annotate.h (annotate_source): Use const.
2292
2293 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2294
2295         * disasm.c (set_disassembler_options): Send errors to stderr.
2296
2297 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2298
2299         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2300         (cli_interp_base::set_logging): Check debug_redirect.
2301         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2302         * cli/cli-logging.c (debug_redirect): Add static variable.
2303         (pop_output_files): Add default param.
2304         (handle_redirections): Print debug setting.
2305         (show_logging_command): Likewise.
2306         (_initialize_cli_logging): Add debugredirect command.
2307         * interps.c (current_interp_set_logging): Add debug_redirect
2308         parameter.
2309         * interps.h (set_logging): Add debug_redirect parameter.
2310         (current_interp_set_logging): Likewise.
2311         * mi/mi-common.h: Likewise.
2312         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2313
2314 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2315             Tom Tromey  <tromey@adacore.com>
2316
2317         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2318         directly.
2319         * cli/cli-interp.h (make_logging_output): Remove declaration.
2320         * cli/cli-logging.c (make_logging_output): Remove function.
2321         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2322         directly.
2323         * ui-file.c (tee_file::tee_file): Remove bools.
2324         (tee_file::~tee_file): Remove deletes.
2325         * ui-file.h (tee_file): Remove bools.
2326
2327 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2328
2329         * mi/mi-cmds.h (mi_cmd_complete): New function.
2330         * mi/mi-main.c (mi_cmd_complete): Likewise.
2331         * mi/mi-cmds.c: Define new MI command -complete.
2332         * NEWS: Mention new -complete command.
2333
2334 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2335
2336         * completer.h (complete): New function.
2337         * completer.c (complete): Likewise.
2338         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2339         function defined in completer.h.
2340
2341 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2342
2343         * MAINTAINERS (Write After Approval): Add myself.
2344
2345 2019-05-17  Tom de Vries  <tdevries@suse.de>
2346
2347         PR gdb/24094
2348         * dwarf2read.c (struct cu_partial_die_info): New struct.
2349         (find_partial_die): Return cu_partial_die_info.
2350         (partial_die_parent_scope, guess_partial_die_structure_name)
2351         (partial_die_info::fixup): Handle new return type of find_partial_die.
2352
2353 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2354
2355         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2356         "std::string", simplifying the algorithm.
2357
2358 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2359
2360         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2361         (stap_static_probe_ops::get_probes): Likewise.
2362
2363 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2364
2365         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2366         '-')" and "else if".
2367         (stap_parse_single_operand): Join checks for
2368         "gdbarch_stap_parse_special_token_p" and
2369         "gdbarch_stap_parse_special_token" in the same "if" statement.
2370         Invert check when verifying for operation on register
2371         displacement.
2372
2373 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2374
2375         * stap-probe.c (stap_get_opcode): Update comment.
2376         (stap_get_expected_argument_type): Likewise.
2377         (handle_stap_probe): Likewise.
2378
2379 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2380
2381         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2382         return type to 'bool'.  Adjust comment.  Use 'bool' when
2383         appropriate.
2384         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2385         * stap-probe.c (stap_parse_argument_1): Likewise.
2386         (stap_is_operator): Likewise.
2387         (stap_is_generic_prefix): Likewise.
2388         (stap_is_register_prefix): Likewise.
2389         (stap_is_register_indirection_prefix): Likewise.
2390         (stap_is_integer_prefix): Likewise.
2391         (stap_generic_check_suffix): Likewise.
2392         (stap_check_integer_suffix): Likewise.
2393         (stap_check_register_suffix): Likewise.
2394         (stap_check_register_indirection_suffix): Likewise.
2395         (stap_parse_register_operand): Likewise.
2396         (stap_parse_single_operand): Likewise.
2397         (stap_parse_argument_1): Likewise.
2398         (stap_probe::get_argument_count): Likewise.
2399         (stap_is_operator): Likewise.
2400
2401 2019-05-16  Tom Tromey  <tromey@adacore.com>
2402
2403         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2404         keyword to foreach.
2405
2406 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2407
2408         * linux-thread-db.c (try_thread_db_load_1): Change return type
2409         to bool.
2410         (try_thread_db_load): Likewise.
2411         (try_thread_db_load_from_pdir_1): Likewise.
2412         (try_thread_db_load_from_pdir): Likewise.
2413         (try_thread_db_load_from_sdir): Likewise.
2414         (try_thread_db_load_from_dir): Likewise.
2415         (thread_db_load_search): Likewise.
2416         (has_libpthread): Likewise.
2417         (thread_db_load): Likewise.
2418
2419 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2420
2421         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2422         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2423         NULL, and complain/return if that's the case.
2424
2425 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2426
2427         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2428         (advance, posn, abstract_read_memory): New functions.
2429         [struct mem_read_abstraction]: New struct.
2430         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2431
2432 2019-05-14  Tom Tromey  <tromey@adacore.com>
2433
2434         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2435         value is not lval_memory.
2436
2437 2019-05-14  Tom Tromey  <tromey@adacore.com>
2438
2439         * solib.c (info_sharedlibrary_command): Style the file name.
2440
2441 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2442
2443         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2444         (aarch64_vnv_type): Likewise.
2445         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2446         * common/tdesc.c: Likewise.
2447         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2448         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2449         * features/aarch64-fpu.xml: Add ieee half view.
2450         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2451         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2452         * gdbtypes.h (struct builtin_type): Likewise.
2453         (struct objfile_type): Likewise.
2454
2455 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2456
2457         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2458         typo.
2459         * location.h (string_to_event_location): Likewise.
2460
2461 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2462
2463         GDB 8.3 released.
2464
2465 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2466
2467         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2468         New variable declaration.
2469         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2470         New variable.
2471         (print_one_breakpoint): Use ui_out::test_flags and new global
2472         variable to compute use_fixed_output.
2473         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2474         Remove.
2475         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2476         (mi_multi_location_breakpoint_output_fixed): Remove.
2477         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2478         new variable.
2479         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2480         fix_multi_location_breakpoint_output flag if version >= 3.
2481         * ui-out.h (enum ui_out_flag)
2482         <fix_multi_location_breakpoint_output>: New enumerator.
2483
2484 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2485
2486         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2487
2488 2019-05-10  Tom Tromey  <tromey@adacore.com>
2489
2490         * ada-lang.c (catch_ada_completer): New function.
2491         (_initialize_ada_language): Use it.
2492
2493 2019-05-10  Tom Tromey  <tromey@adacore.com>
2494
2495         * thread.c (print_thread_info): Make "requested_threads" const.
2496         * gdbthread.h (print_thread_info): Make "requested_threads"
2497         const.
2498         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2499         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2500
2501 2019-05-08  Tom Tromey  <tom@tromey.com>
2502
2503         * gdbtypes.c (objfile_type_data): Change type.
2504         (objfile_type, _initialize_gdbtypes): Update.
2505
2506 2019-05-08  Tom Tromey  <tom@tromey.com>
2507
2508         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2509         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2510         (_initialize_dwarf2_frame): Update.
2511
2512 2019-05-08  Tom Tromey  <tom@tromey.com>
2513
2514         * objc-lang.c (objc_objfile_data): Change type.
2515         (find_methods): Update.
2516         (_initialize_objc_lang): Remove.
2517
2518 2019-05-08  Tom Tromey  <tom@tromey.com>
2519
2520         * stabsread.c (rs6000_builtin_type_data): Change type.
2521         (rs6000_builtin_type, _initialize_stabsread): Update.
2522
2523 2019-05-08  Tom Tromey  <tom@tromey.com>
2524
2525         * mips-tdep.c (mips_pdr_data): Remove.
2526         (_initialize_mips_tdep): Update.
2527
2528 2019-05-08  Tom Tromey  <tom@tromey.com>
2529
2530         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2531         (hppa_init_objfile_priv_data, read_unwind_info)
2532         (find_unwind_entry, _initialize_hppa_tdep): Update.
2533
2534 2019-05-08  Tom Tromey  <tom@tromey.com>
2535
2536         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2537         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2538         on obstack.
2539         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2540
2541 2019-05-08  Tom Tromey  <tom@tromey.com>
2542
2543         * mdebugread.c (basic_type_data): Change type.
2544         (basic_type, _initialize_mdebugread): Update.
2545
2546 2019-05-08  Tom Tromey  <tom@tromey.com>
2547
2548         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2549
2550 2019-05-08  Tom Tromey  <tom@tromey.com>
2551
2552         * nto-tdep.c (nto_inferior_data_reg): Change type.
2553         (nto_inferior_data): Update.
2554         (nto_inferior_data_cleanup, nto_new_inferior_data)
2555         (_initialize_nto_tdep): Remove.
2556         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2557
2558 2019-05-08  Tom Tromey  <tom@tromey.com>
2559
2560         * ada-lang.c (struct ada_inferior_data): Add initializers.
2561         (ada_inferior_data): Change type.
2562         (ada_inferior_data_cleanup): Remove.
2563         (get_ada_inferior_data, ada_inferior_exit)
2564         (struct ada_pspace_data): Add initializers, destructor.
2565         (ada_pspace_data_handle): Change type.
2566         (get_ada_pspace_data): Update.
2567         (ada_pspace_data_cleanup): Remove.
2568
2569 2019-05-08  Tom Tromey  <tom@tromey.com>
2570
2571         * coffread.c (struct coff_symfile_info): Add initializers.
2572         (coff_objfile_data_key): Move lower.  Change type.
2573         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2574         Update.
2575         (coff_free_info): Remove.
2576
2577 2019-05-08  Tom Tromey  <tom@tromey.com>
2578
2579         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2580         (fbsd_pspace_data_handle): Move lower.  Change type.
2581         (get_fbsd_pspace_data): Update.
2582         (fbsd_pspace_data_cleanup): Remove.
2583         (_initialize_fbsd_tdep): Update.
2584
2585 2019-05-08  Tom Tromey  <tom@tromey.com>
2586
2587         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2588         (get_ada_tasks_pspace_data): Update.
2589         (ada_tasks_pspace_data_cleanup): Remove.
2590         (_initialize_tasks): Update.
2591         (ada_tasks_inferior_data_handle): Change type.
2592         (get_ada_tasks_inferior_data): Update.
2593         (ada_tasks_inferior_data_cleanup): Remove.
2594         (struct ada_tasks_pspace_data): Add initializers.
2595
2596 2019-05-08  Tom Tromey  <tom@tromey.com>
2597
2598         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2599         * symfile-debug.c (debug_sym_get_probes): Change type.
2600         * stap-probe.c (handle_stap_probe):
2601         (stap_static_probe_ops::get_probes): Change type.
2602         * probe.h (class static_probe_ops) <get_probes>: Change type.
2603         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2604         (parse_probes_in_pspace): Update.
2605         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2606         Update.
2607         (any_static_probe_ops::get_probes): Change type.
2608         * elfread.c (elfread_data): New typedef.
2609         (probe_key): Change type.
2610         (elf_get_probes): Likewise.  Update.
2611         (probe_key_free): Remove.
2612         (_initialize_elfread): Update.
2613         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2614         Change type.
2615         (dtrace_process_dof_probe, dtrace_process_dof)
2616         (dtrace_static_probe_ops::get_probe): Change type.
2617
2618 2019-05-08  Tom Tromey  <tom@tromey.com>
2619
2620         * xcoffread.c (struct xcoff_symfile_info): Rename from
2621         coff_symfile_info.  Add initializers.
2622         (xcoff_objfile_data_key): Move lower.  Change type.
2623         (XCOFF_DATA): Rewrite.
2624         (xcoff_free_info): Remove.
2625         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2626         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2627         (xcoff_initial_scan): Update.
2628
2629 2019-05-08  Tom Tromey  <tom@tromey.com>
2630
2631         * solib-svr4.c (struct svr4_info): Add initializers and
2632         destructor.
2633         <probes_table>: Now an htab_up.
2634         (solib_svr4_pspace_data): Change type.
2635         (free_probes_table): Simplify.
2636         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2637         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2638         (probes_table_remove_objfile_probes, register_solib_event_probe)
2639         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2640         (_initialize_svr4_solib): Update.
2641
2642 2019-05-08  Tom Tromey  <tom@tromey.com>
2643
2644         * remote.c (remote_pspace_data): Change type.
2645         (remote_pspace_data_cleanup): Remove.
2646         (get_remote_exec_file, set_pspace_remote_exec_file)
2647         (_initialize_remote): Update.
2648
2649 2019-05-08  Tom Tromey  <tom@tromey.com>
2650
2651         * breakpoint.c (breakpoint_objfile_key): Change type.
2652         (get_breakpoint_objfile_data): Update.
2653         (free_breakpoint_objfile_data): Remove.
2654         (_initialize_breakpoint): Update.
2655
2656 2019-05-08  Tom Tromey  <tom@tromey.com>
2657
2658         * linux-tdep.c (struct linux_info): Add initializers.
2659         (linux_inferior_data): Move.  Change type.
2660         (invalidate_linux_cache_inf): Update.
2661         (linux_inferior_data_cleanup): Remove.
2662         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2663
2664 2019-05-08  Tom Tromey  <tom@tromey.com>
2665
2666         * auxv.c (auxv_inferior_data): Move.  Change type.
2667         (auxv_inferior_data_cleanup): Remove.
2668         (invalidate_auxv_cache_inf): Rewrite.
2669         (get_auxv_inferior_data, _initialize_auxv): Update.
2670
2671 2019-05-08  Tom Tromey  <tom@tromey.com>
2672
2673         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2674         (symfile_debug_objfile_data_key): Change type.
2675         (symfile_debug_installed, debug_qf_has_symbols)
2676         (debug_qf_find_last_source_symtab)
2677         (debug_qf_forget_cached_source_info)
2678         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2679         (debug_qf_print_stats, debug_qf_dump)
2680         (debug_qf_expand_symtabs_for_function)
2681         (debug_qf_expand_all_symtabs)
2682         (debug_qf_expand_symtabs_with_fullname)
2683         (debug_qf_map_matching_symbols)
2684         (debug_qf_expand_symtabs_matching)
2685         (debug_qf_find_pc_sect_compunit_symtab)
2686         (debug_qf_map_symbol_filenames)
2687         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2688         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2689         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2690         (debug_sym_read_linetable, debug_sym_relocate): Update.
2691         (symfile_debug_free_objfile): Remove.
2692         (install_symfile_debug_logging, _initialize_symfile_debug):
2693         Update.
2694
2695 2019-05-08  Tom Tromey  <tom@tromey.com>
2696
2697         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2698         allocate_on_obstack.
2699         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2700         (get_dwarf2_per_objfile): Update.
2701         (set_dwarf2_per_objfile): Remove.
2702         (dwarf2_has_info, dwarf2_get_section_info): Update.
2703         (dwarf2_free_objfile): Remove.
2704         (_initialize_dwarf2_read): Update.
2705
2706 2019-05-08  Tom Tromey  <tom@tromey.com>
2707
2708         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2709         initializers.
2710         <unsupported_script_warning_printed,
2711         script_not_found_warning_printed>: Now bool.
2712         (auto_load_pspace_data): Change type.
2713         (~auto_load_pspace_info): Rename from
2714         auto_load_pspace_data_cleanup.
2715         (get_auto_load_pspace_data, init_loaded_scripts_info)
2716         (clear_section_scripts, maybe_print_unsupported_script_warning)
2717         (maybe_print_script_not_found_warning, _initialize_auto_load):
2718         Update.
2719
2720 2019-05-08  Tom Tromey  <tom@tromey.com>
2721
2722         * objfiles.c (objfile_pspace_info): Add destructor and
2723         initializers.
2724         (objfiles_pspace_data): Change type.
2725         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2726         (get_objfile_pspace_data): Update.
2727         (objfiles_bfd_data): Change type.
2728         (get_objfile_bfd_data): Update.
2729         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2730
2731 2019-05-08  Tom Tromey  <tom@tromey.com>
2732
2733         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2734         Change type.
2735         (get_catch_syscall_inferior_data): Update.
2736         (catch_syscall_inferior_data_cleanup): Remove.
2737         (_initialize_break_catch_syscall): Update.
2738
2739 2019-05-08  Tom Tromey  <tom@tromey.com>
2740
2741         * inflow.c (struct terminal_info): Add destructor and
2742         initializers.
2743         (inflow_inferior_data): Change type.
2744         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2745         (get_inflow_inferior_data, inflow_inferior_exit)
2746         (swap_terminal_info, _initialize_inflow): Update.
2747
2748 2019-05-08  Tom Tromey  <tom@tromey.com>
2749
2750         * target-dcache.c (target_dcache_cleanup): Remove.
2751         (target_dcache_aspace_key): Change type.
2752         (target_dcache_init_p, target_dcache_invalidate)
2753         (target_dcache_get, target_dcache_get_or_init)
2754         (_initialize_target_dcache): Update.
2755         * dcache.h (struct dcache_deleter): New.
2756
2757 2019-05-08  Tom Tromey  <tom@tromey.com>
2758
2759         * symtab.c (struct symbol_cache): Add destructor and
2760         initializers.
2761         (symbol_cache_key): Move.  Change type.
2762         (make_symbol_cache, free_symbol_cache): Remove.
2763         (get_symbol_cache): Update.
2764         (symbol_cache_cleanup): Remove.
2765         (ALL_PSPACES, symbol_cache_flush)
2766         (maintenance_print_symbol_cache)
2767         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2768         Update.
2769
2770 2019-05-08  Tom Tromey  <tom@tromey.com>
2771
2772         * symtab.c (struct main_info): Add destructor and initializers.
2773         (main_progspace_key): Move.  Change type.
2774         (get_main_info): Update.
2775         (main_info_cleanup): Remove.
2776         (_initialize_symtab): Update.
2777
2778 2019-05-08  Tom Tromey  <tom@tromey.com>
2779
2780         * registry.h (DECLARE_REGISTRY): Define the _key class.
2781
2782 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2783
2784         * NEWS: Merge two 'New commands' sections.
2785
2786 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2787
2788         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2789         parameter and use Ada language definition instead.
2790         (ada_val_print_ptr): Remove unused language parameter.
2791         (ada_val_print_num): Remove language parameter and use Ada language
2792         definition instead.
2793         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2794         parameter.
2795         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2796         parameter and use Ada language definition instead.
2797         (ada_val_print_1): Update all ada_val_print_xxx calls.
2798         Remove language parameter.
2799         (ada_val_print): Update ada_val_print_1 call.
2800
2801 2019-05-08  Tom Tromey  <tromey@adacore.com>
2802
2803         * remote.c (remote_hw_watchpoint_limit)
2804         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2805         Now static.
2806
2807 2019-05-08  Tom Tromey  <tromey@adacore.com>
2808
2809         * maint.c (_initialize_maint_cmds): Move initialization code to
2810         remote.c.
2811         (watchdog, show_watchdog): Move to remote.c.
2812         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2813         "watchdog" static.
2814         (_initialize_remote): Move initialization code from maint.c.
2815         * defs.h (watchdog): Don't declare.
2816
2817 2019-05-08  Tom Tromey  <tromey@adacore.com>
2818
2819         * tui/tui-interp.c: Include main.h.
2820         * interps.c: Include main.h.
2821         * main.h (interpreter_p): Declare.
2822         * defs.h (interpreter_p): Don't declare.
2823
2824 2019-05-08  Tom Tromey  <tromey@adacore.com>
2825
2826         * dwarf2loc.c: Include dwarf2read.h.
2827         * defs.h (read_unsigned_leb128): Don't declare.
2828         * dwarf2read.h (read_unsigned_leb128): Declare.
2829
2830 2019-05-08  Tom Tromey  <tromey@adacore.com>
2831
2832         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2833         method.
2834
2835 2019-05-08  Tom Tromey  <tromey@adacore.com>
2836
2837         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2838         when no wrap column is set.
2839
2840 2019-05-08  Tom Tromey  <tromey@adacore.com>
2841
2842         * c-lang.c (c_get_string): Handle non-C-style arrays.
2843
2844 2019-05-08  Tom Tromey  <tromey@adacore.com>
2845
2846         * typeprint.c (print_offset_data::update): Print the bit offset,
2847         not the number of bits remaining.
2848
2849 2019-05-08  Tom Tromey  <tromey@adacore.com>
2850
2851         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2852         padding at end of comment.
2853
2854 2019-05-08  Tom Tromey  <tromey@adacore.com>
2855
2856         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2857         Compare main types.
2858
2859 2019-05-06  Tom Tromey  <tom@tromey.com>
2860
2861         * common/scoped_mmap.c: Include common-defs.h.
2862         * common/scoped_mmap.h: Don't include config.h.
2863
2864 2019-05-04  Tom Tromey  <tom@tromey.com>
2865
2866         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2867         (struct aarch64_call_info): Add initializers.
2868         <si>: Now a std::vector.
2869         (pass_on_stack, aarch64_push_dummy_call): Update.
2870
2871 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2872             Tom Tromey  <tom@tromey.com>
2873
2874         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2875         (ppc_threads): Now a std::vector.  Now static.
2876         (hwdebug_find_thread_points_by_tid)
2877         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2878         Update.
2879
2880 2019-05-04  Tom Tromey  <tom@tromey.com>
2881
2882         * arc-tdep.c (arc_tdesc_init): Return bool.
2883
2884 2019-05-04  Tom Tromey  <tom@tromey.com>
2885
2886         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2887         Use gdb_assert_not_reached.
2888
2889 2019-05-04  Tom Tromey  <tom@tromey.com>
2890
2891         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2892         "false".
2893
2894 2019-05-04  Tom Tromey  <tom@tromey.com>
2895
2896         * arc-tdep.c (arc_tdesc_init): Use bool.
2897
2898 2019-05-04  Tom Tromey  <tom@tromey.com>
2899
2900         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2901
2902 2019-05-04  Tom Tromey  <tom@tromey.com>
2903
2904         * cli/cli-cmds.c (valid_command_p): Return bool.
2905
2906 2019-05-04  Tom Tromey  <tom@tromey.com>
2907
2908         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2909         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2910
2911 2019-05-04  Raul Tambre  <raul@tambre.ee>
2912
2913         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2914         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2915         operator for comparison.
2916
2917 2019-05-04  Tom Tromey  <tom@tromey.com>
2918
2919         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2920         (lookup_partial_symbol, print_partial_symbols)
2921         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2922         (psymbol_compare): Update.
2923         (add_psymbol_to_bcache): Clear the entire psymbol.
2924         (maintenance_check_psymtabs): Update.
2925         * psympriv.h (struct partial_symbol): Don't derive from
2926         general_symbol_info.
2927         <obj_section, unrelocated_address, address,
2928         set_unrelocated_address>: Update.
2929         <ginfo>: New member.
2930         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2931         (debug_names::write_psymbols): Update.
2932
2933 2019-05-04  Tom de Vries  <tdevries@suse.de>
2934
2935         * contrib/cc-with-tweaks.sh: Support -n arg.
2936
2937 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2938
2939         * corelow.c (core_target::detach): Ensure frame cache and
2940         register caches are cleared.
2941         inferior.c (exit_inferior_1): Likewise.
2942
2943 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2944             Tom Tromey  <tom@tromey.com>
2945
2946         * dictionary.c (collate_pending_symbols_by_language): Remove
2947         "struct" from foreach.
2948         * symtab.c (lookup_global_symbol_from_objfile)
2949         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2950         foreach.
2951         * ser-tcp.c (net_open): Remove "struct" from foreach.
2952         * objfiles.c (objfile_relocate, objfile_rebase)
2953         (objfile_has_symbols): Remove "struct" from foreach.
2954         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2955         from foreach.
2956         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2957         foreach.
2958         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2959         "struct" from foreach.
2960         * ada-lang.c (create_excep_cond_exprs)
2961         (ada_exception_catchpoint_cond_string): Remove "struct" from
2962         foreach.
2963
2964 2019-05-03  Tom Tromey  <tromey@adacore.com>
2965
2966         * ada-exp.y (convert_char_literal): Check suffix of each
2967         enumerator.
2968
2969 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2970
2971         PR ada/21406:
2972         * ada-exp.y (yywrap): Don't define.
2973         * ada-lex.l (%option): Add noyywrap
2974         (yywrap): Remove.
2975
2976 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2977
2978         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2979         _WIN32_WINNT to the XP level, unless already defined to a higher
2980         level.
2981
2982         * unittests/parse-connection-spec-selftests.c:
2983         * ser-tcp.c:
2984         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2985         override.
2986
2987         * symfile.c (find_separate_debug_file): Remove colon from the
2988         drive spec of DOS/Windows file names of the target, so that the
2989         file name produced from DEBUGDIR and the target's directory will
2990         be valid on DOS/Windows systems.
2991
2992 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2993
2994         * rust-lang.c (val_print_struct): Handle printing structures
2995         containing strings.
2996
2997 2019-05-02  Tom Tromey  <tromey@adacore.com>
2998
2999         * valarith.c (_initialize_valarith): Remove.
3000
3001 2019-05-01  Tom Tromey  <tromey@adacore.com>
3002
3003         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3004         bitfields.
3005
3006 2019-05-01  Tom Tromey  <tromey@adacore.com>
3007
3008         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3009         for big-endian copies.
3010
3011 2019-04-30  Ali Tamur  <tamur@google.com>
3012         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3013         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3014         (read_3_bytes): New function.
3015
3016 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3017
3018         * windows-nat.c (main_thread_id): Delete.
3019         (handle_output_debug_string): Replace main_thread_id by
3020         current_event.dwThreadId.
3021         (fake_create_process): Likewise.
3022         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3023         Do not set main_thread_id.
3024         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3025         current_event.dwThreadId.
3026         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3027
3028 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3029
3030         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3031         Use current_event.dwThreadId instead of main_thread_id.
3032
3033 2019-04-30  Tom Tromey  <tromey@adacore.com>
3034
3035         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3036         (create_excep_cond_exprs): Iterate over program spaces.
3037         (ada_exception_catchpoint_cond_string): Examine all minimal
3038         symbols for exception types.
3039
3040 2019-04-30  Tom Tromey  <tromey@adacore.com>
3041
3042         PR c++/24470:
3043         * dwarf2read.c (process_structure_scope): Handle case where type
3044         has template parameters but no symbol was created.
3045
3046 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3047             Chris January  <chris.january@arm.com>
3048
3049         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3050         qualifier.
3051         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3052
3053 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3054
3055         * f-typeprint.c (f_print_type): Update rules for printing
3056         whitespace.
3057         (f_type_print_varspec_suffix): Likewise.
3058
3059 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3060             Chris January  <chris.january@arm.com>
3061
3062         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3063         function arguments.
3064
3065 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3066
3067         * f-lang.c (build_fortran_types): Change name of void type to
3068         lower case.
3069         * f-typeprint.c (f_type_print_base): Print the name of the void
3070         type, rather than a fixed string.
3071         * f-valprint.c (f_decorations): Use lower case void string.
3072
3073 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3074             Chris January  <chris.january@arm.com>
3075
3076         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3077         types for Fortran.
3078
3079 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3080             Chris January  <chris.january@arm.com>
3081             David Lecomber  <david.lecomber@arm.com>
3082
3083         * f-exp.y (BINOP_INTRINSIC): New token.
3084         (exp): New parser rule handling BINOP_INTRINSIC.
3085         (f77_keywords): Add new builtin procedures.
3086         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3087         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3088         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3089         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3090         (print_unop_subexp_f): New function.
3091         (print_binop_subexp_f): New function.
3092         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3093         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3094         (dump_subexp_body_f): Likewise.
3095         (operator_check_f): Likewise.
3096         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3097         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3098
3099 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3100
3101         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3102         UNOP_KIND.
3103         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3104         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3105         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3106         (operator_length_f): New fuction.
3107         (print_subexp_f): New function.
3108         (op_name_f): New function.
3109         (dump_subexp_body_f): New function.
3110         (operator_check_f): New function.
3111         (exp_descriptor_f): Replace standard expression handling functions
3112         with new functions.
3113         * gdb/fortran-operator.def: New file.
3114         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3115         * gdb/std-operator.def: Remove UNOP_KIND.
3116
3117 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3118
3119         * std-operator.def: Remove unbalanced, stray double quote
3120         character.
3121
3122 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3123             Chris January  <chris.january@arm.com>
3124             Daniel Everett  <daniel.everett@arm.com>
3125             Nick Forrington  <nick.forrington@arm.com>
3126             Richard Bunt  <richard.bunt@arm.com>
3127
3128         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3129         of depth when printing anonymous structs or unions.
3130         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3131         Don't print either the top-level value, or the children if the
3132         max-depth is exceeded.
3133         (ppscm_print_children): When printing the key of a map, allow one
3134         extra level of depth.
3135         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3136         print either the top-level value, or the children if the max-depth
3137         is exceeded.
3138         (print_children): When printing the key of a map, allow one extra
3139         level of depth.
3140         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3141         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3142         (user_print_options): Initialise max_depth field.
3143         (val_print_scalar_or_string_type_p): New function.
3144         (val_print): Check to see if the max depth has been reached.
3145         (val_print_check_max_depth): Define new function.
3146         (show_print_max_depth): New function.
3147         (_initialize_valprint): Add 'print max-depth' option.
3148         * valprint.h (struct value_print_options) <max_depth>: New field.
3149         (val_print_check_max_depth): Declare new function.
3150         * NEWS: Document new feature.
3151
3152 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3153
3154         * ada-lang.c (ada_language_defn): Initialise new field.
3155         * c-lang.c (c_is_string_type_p): New function.
3156         (c_language_defn): Initialise new field.
3157         (cplus_language_defn): Initialise new field.
3158         (asm_language_defn): Initialise new field.
3159         (minimal_language_defn): Initialise new field.
3160         * c-lang.h (c_is_string_type_p): Declare new function.
3161         * d-lang.c (d_language_defn): Initialise new field.
3162         * f-lang.c (f_is_string_type_p): New function.
3163         (f_language_defn): Initialise new field.
3164         * go-lang.c (go_is_string_type_p): New function.
3165         (go_language_defn): Initialise new field.
3166         * language.c (default_is_string_type_p): New function.
3167         (unknown_language_defn): Initialise new field.
3168         (auto_language_defn): Initialise new field.
3169         * language.h (struct language_defn) <la_is_string_type_p>: New
3170         member variable.
3171         (default_is_string_type_p): Declare new function.
3172         * m2-lang.c (m2_language_defn): Initialise new field.
3173         * objc-lang.c (objc_language_defn): Initialise new field.
3174         * opencl-lang.c (opencl_language_defn): Initialise new field.
3175         * p-lang.c (pascal_is_string_type_p): New function.
3176         (pascal_language_defn): Initialise new field.
3177         * rust-lang.c (rust_is_string_type_p): New function.
3178         (rust_language_defn): Initialise new field.
3179
3180 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3181
3182         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3183         New field.
3184         * ada-lang.c (ada_language_defn): Initialise new field.
3185         * c-lang.c (c_language_defn): Likewise.
3186         (cplus_language_defn): Likewise.
3187         (asm_language_defn): Likewise.
3188         (minimal_language_defn): Likewise.
3189         * d-lang.c (d_language_defn): Likewise.
3190         * f-lang.c (f_language_defn): Likewise.
3191         * go-lang.c (go_language_defn): Likewise.
3192         * language.c (unknown_language_defn): Likewise.
3193         (auto_language_defn): Likewise.
3194         * m2-lang.c (m2_language_defn): Likewise.
3195         * objc-lang.c (objc_language_defn): Likewise.
3196         * opencl-lang.c (opencl_language_defn): Likewise.
3197         * p-lang.c (pascal_language_defn): Likewise.
3198         * rust-lang.c (rust_language_defn): Likewise.
3199
3200 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3201
3202         * ada-lang.c (ada_is_character_type): Change return type to bool.
3203         (ada_is_string_type): Likewise.
3204         * ada-lang.h (ada_is_character_type): Update declaration
3205         (ada_is_string_type): Likewise.
3206
3207 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3208
3209         Support style in 'frame|thread apply'
3210
3211         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3212         * record.c (record_start, record_stop): Update callers of
3213         execute_command_to_string with false.
3214         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3215         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3216         methods.
3217         (class string_file): New constructor with term_out parameter.
3218         Override methods term_out and can_emit_style_escape.  New member
3219         term_out.
3220         (class stdio_file): Override can_emit_style_escape.
3221         (class tee_file): Override term_out and can_emit_style_escape.
3222         * utils.h (can_emit_style_escape): Remove.
3223         * utils.c (can_emit_style_escape): Likewise.
3224         Update all callers of can_emit_style_escape (SOMESTREAM) to
3225         SOMESTREAM->can_emit_style_escape.
3226         * source-cache.c (source_cache::get_source_lines): Likewise.
3227         * stack.c (frame_apply_command_count): Call execute_command_to_string
3228         passing the term_out characteristic of the current gdb_stdout.
3229         * thread.c (thr_try_catch_cmd): Likewise.
3230         * top.c (execute_command_to_string): pass term_out parameter
3231         to construct the string_file for the command output.
3232         * ui-file.c (term_cli_styling): New function (most code moved
3233         from utils.c can_emit_style_escape).
3234         (string_file::string_file, string_file::can_emit_style_escape,
3235         stdio_file::can_emit_style_escape, tee_file::term_out,
3236         tee_file::can_emit_style_escape): New functions.
3237
3238 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3239
3240         * NEWS: Mention the new set|show may-call-functions.
3241         * infcall.c (may_call_functions_p): New variable.
3242         (show_may_call_functions_p): New function.
3243         (call_function_by_hand_dummy): Throws an error if not
3244         may-call-functions.
3245         (_initialize_infcall): Call add_setshow_boolean_cmd for
3246         may-call-functions.
3247
3248 2019-04-25  Keith Seitz  <keiths@redhat.com>
3249
3250         PR c++/24367
3251         * cp-support.c (inspect_type): Don't attempt substitutions
3252         of symbol with the same name.
3253
3254 2019-04-25  Tom Tromey  <tromey@adacore.com>
3255
3256         PR gdb/24475:
3257         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3258         static.
3259
3260 2019-04-25  Tom Tromey  <tromey@adacore.com>
3261
3262         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3263         rvalue reference.
3264         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3265         (gdb_xml_parser::parse): Use std::move.
3266         * python/python-internal.h (gdbpy_convert_exception): Take a const
3267         reference.
3268         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3269         std::move.
3270         * python/py-utils.c (gdbpy_convert_exception): Take a const
3271         reference.
3272         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3273         Use std::move.
3274         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3275         Use std::move.
3276         * mi/mi-main.c (mi_print_exception): Take a const reference.
3277         * main.c (handle_command_errors): Take a const reference.
3278         * linespec.c (parse_linespec): Use std::move.
3279         * infcall.c (run_inferior_call): Use std::move.
3280         (call_function_by_hand_dummy): Use std::move.
3281         * exec.c (try_open_exec_file): Use std::move.
3282         * exceptions.h (exception_print, exception_fprintf)
3283         (exception_print_same): Update.
3284         * exceptions.c (print_exception, exception_print)
3285         (exception_fprintf, exception_print_same): Change parameters to
3286         const reference.
3287         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3288         * common/new-op.c: Use std::move.
3289         * common/common-exceptions.h (struct gdb_exception): Add move
3290         constructor.
3291         (struct gdb_exception_error, struct gdb_exception_quit, struct
3292         gdb_quit_bad_alloc): Change constructor to move constructor.
3293         (throw_exception): Change parameter to rvalue reference.
3294         * common/common-exceptions.c (throw_exception): Take rvalue
3295         reference.
3296         * cli/cli-interp.c (safe_execute_command): Use std::move.
3297         * breakpoint.c (insert_bp_location, location_to_sals): Use
3298         std::move.
3299
3300 2019-04-25  Tom Tromey  <tromey@adacore.com>
3301
3302         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3303         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3304         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3305         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3306         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3307         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3308         guile/scm-value.c: Use unpack.
3309         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3310         gdbscm_gdb_exception.
3311         (gdbscm_throw_gdb_exception): Likewise.
3312         (struct gdbscm_gdb_exception): New.
3313         (unpack): New function.
3314         (gdbscm_wrap): Use unpack.
3315
3316 2019-04-25  Tom Tromey  <tromey@adacore.com>
3317
3318         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3319         (gdb_rl_callback_handler): Use std::move.
3320         * common/common-exceptions.h (struct gdb_exception): Add move
3321         assignment operator.
3322         (throw_exception_sjlj): Change "exception" to const reference.
3323         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3324         (throw_exception_sjlj): Change "exception" to const reference.
3325
3326 2019-04-25  Tom Tromey  <tromey@adacore.com>
3327
3328         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3329         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3330         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3331         Update.
3332         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3333         Update.
3334         * mi/mi-interp.c (mi_interp::exec): Update.
3335         * linespec.c (parse_linespec): Update.
3336         * infcall.c (run_inferior_call): Update.
3337         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3338         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3339         (gdbscm_lookup_global_symbol): Update.
3340         * guile/scm-param.c (gdbscm_parameter_value): Update.
3341         * guile/scm-frame.c (gdbscm_frame_read_register)
3342         (gdbscm_frame_read_var): Update.
3343         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3344         * exec.c (try_open_exec_file): Update.
3345         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3346         (gdb_rl_callback_handler): Update.
3347         * common/common-exceptions.h (exception_none): Don't declare.
3348         * common/common-exceptions.c (exception_none): Don't define.
3349         (struct catcher) <exception>: Update.
3350         * cli/cli-interp.c (safe_execute_command): Update.
3351         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3352
3353 2019-04-25  Ali Tamur  <tamur@google.com>
3354
3355         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3356         (read_attribute_value): Likewise.
3357         (dwarf2_read_addr_index): Update comment.
3358         (read_str_index): Add DW_FORM_strx.
3359         (dwarf2_string_attr): Likewise.
3360         (dwarf2_const_value_attr): Likewise.
3361         (dump_die_shallow): Likewise.
3362         (dwarf2_fetch_constant_bytes): Likewise.
3363         (skip_form_bytes): Likewise.
3364         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3365
3366 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3367
3368         PR corefiles/11608
3369         PR corefiles/18187
3370         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3371         OFFSET.  Verify if current mapping contains an ELF header.
3372         (linux_find_memory_regions_full): Adjust call to
3373         dump_mapping_p.
3374
3375 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3376             Kang Li <kanglictf@gmail.com>
3377
3378         PR gdb/21600
3379
3380         * dwarf2-frame.c (read_initial_length): Be consistent about using
3381         unsigned representation of length.
3382         (decode_frame_entry_1): Likewise.  Check for wraparound of
3383         end pointer as well as buffer overflow.
3384
3385 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3386
3387         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3388         "vq".
3389
3390 2019-04-24  Tom Tromey  <tromey@adacore.com>
3391
3392         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3393
3394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3395
3396         * s12z-tdep.c (s12z_unwind_pc): Delete.
3397         (s12z_unwind_sp): Delete.
3398         (s12z_gdbarch_init): Don't register deleted functions with
3399         gdbarch.
3400
3401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3402
3403         * rl78-tdep.c (rl78_unwind_sp): Delete.
3404         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3405
3406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3407
3408         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3409         (xstormy16_unwind_pc): Delete.
3410         (xstormy16_dummy_id): Delete.
3411         (xstormy16_gdbarch_init): Don't register deleted functions with
3412         gdbarch.
3413
3414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3415
3416         * vax-tdep.c (vax_unwind_pc): Delete.
3417         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3418
3419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3420
3421         * v850-tdep.c (v850_unwind_sp): Delete.
3422         (v850_unwind_pc): Delete.
3423         (v850_dummy_id): Delete.
3424         (v850_gdbarch_init): Don't register deleted functions with
3425         gdbarch.
3426
3427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3428
3429         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3430         (tilegx_unwind_pc): Delete.
3431         (tilegx_unwind_dummy_id): Delete.
3432         (tilegx_gdbarch_init): Don't register deleted functions with
3433         gdbarch.
3434
3435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3436
3437         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3438         (tic6x_dummy_id): Delete.
3439         (tic6x_gdbarch_init): Don't register deleted functions with
3440         gdbarch.
3441
3442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3443
3444         * sparc-tdep.c (sparc_unwind_pc): Delete.
3445         (sparc32_gdbarch_init): Don't register deleted function with
3446         gdbarch.
3447
3448 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3449
3450         * sh-tdep.c (sh_unwind_sp): Delete.
3451         (sh_unwind_pc): Delete.
3452         (sh_dummy_id): Delete.
3453         (sh_gdbarch_init): Don't register deleted functions with
3454         gdbarch.
3455
3456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3457
3458         * score-tdep.c (score_unwind_sp): Delete.
3459         (score_unwind_pc): Delete.
3460         (score_dummy_id): Delete.
3461         (score_gdbarch_init): Don't register deleted functions with
3462         gdbarch.
3463
3464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3465
3466         * rx-tdep.c (rx_unwind_pc): Delete.
3467         (rx_unwind_sp): Delete.
3468         (rx_dummy_id): Delete.
3469         (rx_gdbarch_init): Don't register deleted functions with
3470         gdbarch.  Update comment.
3471
3472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3473
3474         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3475         (rs6000_dummy_id): Delete.
3476         (rs6000_gdbarch_init): Don't register deleted functions with
3477         gdbarch.
3478
3479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3480
3481         * or1k-tdep.c (or1k_dummy_id): Delete.
3482         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3483
3484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3485
3486         * nios2-tdep.c (nios2_dummy_id): Delete.
3487         (nios2_unwind_sp): Delete.
3488         (nios2_gdbarch_init): Don't register deleted functions with
3489         gdbarch.
3490
3491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3492
3493         * nds32-tdep.c (nds32_dummy_id): Delete.
3494         (nds32_unwind_pc): Delete.
3495         (nds32_unwind_sp): Delete.
3496         (nds32_gdbarch_init): Don't register deleted functions with
3497         gdbarch.
3498
3499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3500
3501         * msp430-tdep.c (msp430_unwind_pc): Delete.
3502         (msp430_unwind_sp): Delete.
3503         (msp430_dummy_id): Delete.
3504         (msp430_gdbarch_init): Don't register deleted functions with
3505         gdbarch.
3506
3507 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3508
3509         * moxie-tdep.c (moxie_unwind_sp): Delete.
3510         (moxie_unwind_pc): Delete.
3511         (moxie_dummy_id): Delete.
3512         (moxie_gdbarch_init): Don't register deleted functions with
3513         gdbarch.
3514
3515 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3516
3517         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3518         (mn10300_unwind_pc): Delete.
3519         (mn10300_unwind_sp): Delete.
3520         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3521         mn10300_unwind_sp.
3522         (mn10300_frame_unwind_init): Don't register deleted functions with
3523         gdbarch.
3524
3525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3526
3527         * mep-tdep.c (mep_unwind_pc): Delete.
3528         (mep_unwind_sp): Delete.
3529         (mep_dummy_id): Delete.
3530         (mep_gdbarch_init): Don't register deleted functions with
3531         gdbarch.
3532
3533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3534
3535         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3536         (m68hc11_unwind_sp): Delete.
3537         (m68hc11_gdbarch_init): Don't register deleted functions with
3538         gdbarch.
3539
3540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3541
3542         * m32r-tdep.c (m32r_unwind_sp): Delete.
3543         (m32r_unwind_pc): Delete.
3544         (m32r_dummy_id): Delete.
3545         (m32r_gdbarch_init): Don't register deleted functions with
3546         gdbarch.
3547
3548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3549
3550         * m32c-tdep.c (m32c_unwind_pc): Delete.
3551         (m32c_unwind_sp): Delete.
3552         (m32c_dummy_id): Delete.
3553         (m32c_gdbarch_init): Don't register deleted functions with
3554         gdbarch.
3555
3556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3557
3558         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3559         (lm32_unwind_pc): Delete.
3560         (lm32_dummy_id): Delete.
3561         (lm32_gdbarch_init): Don't register deleted functions with
3562         gdbarch.
3563
3564 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3565
3566         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3567         (iq2000_unwind_pc): Delete.
3568         (iq2000_dummy_id): Delete.
3569         (iq2000_gdbarch_init): Don't register deleted functions with
3570         gdbarch.
3571
3572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3573
3574         * nds32-tdep.c (nds32_type_align): Delete.
3575         (nds32_push_dummy_call): Use type_align instead.
3576
3577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3578
3579         * arm-tdep.c (arm_type_align): Only handle vector override case.
3580         (arm_push_dummy_call): Use type_align.
3581         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3582
3583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3584
3585         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3586         case.
3587         (pass_on_stack): Use type_align.
3588         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3589         function.
3590
3591 2019-04-23  Tom Tromey  <tromey@adacore.com>
3592
3593         * dwarf2read.c (line_header::file_name_at): Remove unused
3594         overload.
3595
3596 2019-04-23  Tom de Vries  <tdevries@suse.de>
3597
3598         PR gdb/24438
3599         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3600         invocation.
3601
3602
3603 2019-03-27  Ali Tamur  <tamur@google.com>
3604
3605         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3606         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3607         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3608         (dwarf_expr_context::get_addr_index): Likewise
3609         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3610         (symbol_needs_eval_context::get_addr_index): Likewise
3611         (disassemble_dwarf_expression): Add DW_OP_addrx
3612         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3613         (read_cutu_die_from_dwo): Update comment
3614         (skip_one_die): Add DW_FORM_addrx
3615         (read_attribute_value): Likewise
3616         (var_decode_location): Add DW_OP_addrx
3617         (dwarf2_const_value_attr): Add DW_FORM_addrx
3618         (dump_die_shallow): Likewise
3619         (dwarf2_fetch_constant_bytes): Likewise
3620         (decode_locdesc): Add DW_OP_addrx
3621         (skip_form_bytes): Add DW_FORM_addrx
3622
3623 2019-04-22  Ali Tamur  <tamur@google.com>
3624
3625         * MAINTAINERS (Write After Approval): Add self.
3626
3627 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3628
3629         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3630         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3631         (open_symbol_file_object): Likewise.
3632         (svr4_default_sos): Add info parameter.
3633         (svr4_read_so_list): Likewise.
3634         (svr4_current_sos_direct): Adjust functions calls to pass down
3635         info.
3636         (svr4_current_sos_1): Add info parameter.
3637         (svr4_current_sos): Call get_svr4_info, pass info down to
3638         svr4_current_sos_1.
3639         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3640         get_svr4_info.
3641         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3642         get_svr4_info.
3643         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3644         to get_svr4_info.
3645         (probes_table_remove_objfile_probes): Likewise.
3646         (register_solib_event_probe): Add info parameter.
3647         (solist_update_incremental): Pass info parameter down to
3648         svr4_read_so_list.
3649         (disable_probes_interface): Add info parameter.
3650         (svr4_handle_solib_event): Pass current_program_space to
3651         get_svr4_info.  Adjust disable_probes_interface cleanup.
3652         (svr4_create_probe_breakpoints): Add info parameter, pass it
3653         down to register_solib_event_probe.
3654         (svr4_create_solib_event_breakpoints): Add info parameter,
3655         pass it down to svr4_create_probe_breakpoints.
3656         (enable_break): Pass info down to
3657         svr4_create_solib_event_breakpoints.
3658         (svr4_solib_create_inferior_hook): Pass current_program_space to
3659         get_svr4_info.
3660         (svr4_clear_solib): Likewise.
3661
3662 2019-04-22  Pedro Alves  <palves@redhat.com>
3663
3664         * solib-svr4.c (svr4_free_objfile_observer): New.
3665         (probe_and_action::objfile): New field.
3666         (probes_table_htab_remove_objfile_probes)
3667         (probes_table_remove_objfile_probes): New functions.
3668         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3669         in the new probe_and_action.  Don't store the probe in 'lookup'.
3670         (svr4_create_probe_breakpoints): Pass objfile to
3671         register_solib_event_probe.
3672         (_initialize_svr4_solib): Register a free_objfile observer.
3673
3674 2019-04-19  Tom Tromey  <tom@tromey.com>
3675
3676         * common/queue.h: Remove.
3677
3678 2019-04-19  Tom Tromey  <tom@tromey.com>
3679
3680         * event-loop.c: Don't include "common/queue.h".
3681
3682 2019-04-19  Tom Tromey  <tom@tromey.com>
3683
3684         * remote.c (remote_target): Use delete.
3685         * remote-notif.h: Include <list>, not "common/queue.h".
3686         (notif_client_p): Remove typedef.
3687         (remote_notif_state): Add constructor, destructor, initializer.
3688         <notif_queue>: Now a std::list.
3689         (remote_notif_state_xfree): Don't declare.
3690         * remote-notif.c (remote_notif_process, handle_notification)
3691         (remote_notif_state_allocate): Update.
3692         (~remote_notif_state): Rename from remote_notif_state_xfree.
3693
3694 2019-04-19  Tom Tromey  <tom@tromey.com>
3695
3696         * symfile.c (reread_symbols): Update.
3697         * objfiles.c (objfile_register_static_link)
3698         (objfile_lookup_static_link): Update
3699         (~objfile) Don't delete static_links.
3700         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3701
3702 2019-04-19  Tom Tromey  <tom@tromey.com>
3703
3704         * type-stack.h (struct type_stack) <insert>: Constify string.
3705         * type-stack.c (type_stack::insert): Constify string.
3706         * gdbtypes.h (lookup_template_type): Update.
3707         (address_space_name_to_int): Update.
3708         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3709         const.
3710         (lookup_template_type): Make name const.
3711         * c-exp.y: Update rules.
3712         (lex_one_token, classify_name, classify_inner_name)
3713         (c_print_token): Update.
3714         * p-exp.y: Update rules.
3715         (yylex): Update.
3716         * f-exp.y: Update rules.
3717         (yylex): Update.
3718         * d-exp.y: Update rules.
3719         (lex_one_token, classify_name, classify_inner_name): Update.
3720         * parse.c (write_dollar_variable, copy_name): Return std::string.
3721         * parser-defs.h (copy_name): Change return type.
3722         * m2-exp.y: Update rules.
3723         (yylex): Update.
3724         * go-exp.y (lex_one_token): Update.
3725         Update rules.
3726         (classify_unsafe_function, classify_packaged_name)
3727         (classify_name, yylex): Update.
3728
3729 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3730
3731         * configure.ac: add --enable-source-highlight switch.
3732         * configure: Regenerate.
3733         * top.c (print_gdb_version): plumb --enable-source-highlight
3734         status to "show configuration".
3735
3736 2019-04-19  Tom Tromey  <tromey@adacore.com>
3737
3738         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3739         Check ADA_TYPE_P.
3740         (empty_record, ada_template_to_fixed_record_type_1)
3741         (template_to_static_fixed_type)
3742         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3743         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3744         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3745         macros.
3746
3747 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3748
3749         PR symtab/24423:
3750         * source.c (print_source_lines_base): Advance "iter" when a
3751         control character is seen.
3752
3753 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3754
3755         * inferior.h (struct infcall_suspend_state_deleter):
3756         Catch exception in destructor to avoid crash.
3757
3758 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3759
3760         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3761         close to the add_com "shell".
3762
3763 2019-04-18  Tom Tromey  <tromey@adacore.com>
3764
3765         * process-stratum-target.h (class process_stratum_target)
3766         <stratum>: Add "final".
3767
3768 2019-04-17  Tom Tromey  <tromey@adacore.com>
3769
3770         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3771         against nullptr before use.
3772
3773 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3774
3775         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3776
3777 2019-04-17  Jim Wilson  <jimw@sifive.com>
3778             Andrew Burgess  <andrew.burgess@embecosm.com>
3779
3780         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3781         code read might fail, assume 4-byte breakpoint in that case.
3782
3783 2019-04-15  Leszek Swirski  <leszeks@google.com>
3784
3785         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3786         rather than a hand-rolled POD check when checking for forced MEMORY
3787         classification.
3788
3789 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3790
3791         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3792         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3793         function.
3794         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3795         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3796         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3797         declaration.
3798
3799 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3800
3801         * aarch64-linux-nat.c
3802         (aarch64_linux_nat_target::thread_architecture): Add override.
3803         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3804         each VQ.
3805
3806 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3807
3808         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3809
3810 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3813         target types of size 96-bits, add some additional comments, and
3814         check that the builtin type we found was the correct size.
3815
3816 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3817
3818         * utils.c (prompt_for_continue): Don't restore the styling at the
3819         end, as applied_style has the wrong value.  This fixes styling in
3820         long lists of file names that are interrupted by the "Continue?"
3821         prompt.
3822
3823 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3824
3825         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3826         * c-lang.c (c_language_defn): Likewise.
3827         (cplus_language_defn): Likewise.
3828         (asm_language_defn): Likewise.
3829         (minimal_language_defn): Likewise.
3830         * d-lang.c (d_language_defn): Likewise.
3831         * f-lang.c (f_language_defn): Likewise.
3832         * go-lang.c (go_language_defn): Likewise.
3833         * language.c (unknown_language_defn): Likewise.
3834         (auto_language_defn): Likewise.
3835         * language.h (struct language_defn): Remove la_magic field.
3836         (LANG_MAGIC): Delete.
3837         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3838         * objc-lang.c (objc_language_defn): Likewise.
3839         * opencl-lang.c (opencl_language_defn): Likewise.
3840         * p-lang.c (pascal_language_defn): Likewise.
3841         * rust-lang.c (rust_language_defn): Likewise.
3842
3843 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3844
3845         * riscv-tdep.c (riscv_type_align): New function.
3846         (riscv_type_alignment): Delete.
3847         (riscv_arg_location): Use 'type_align'.
3848         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3849
3850 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3851
3852         * gdbtypes.c (type_align): A struct with no non-static fields also
3853         has alignment of 1.
3854
3855 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3856
3857         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3858         component to 0.
3859         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3860         member.
3861         (riscv_struct_info::analyse): New implementation using new
3862         analyse_inner member function.
3863         (riscv_struct_info::field_offset): New member function.
3864         (riscv_struct_info::m_offsets): New member variable.
3865         (riscv_struct_info::analyse_inner): New private member function,
3866         takes the old implementation of riscv_struct_info::analyse but
3867         extended to track field offsets.
3868         (riscv_call_arg_struct): Update the struct folding special cases
3869         to handle cases where empty C++ structs, which are non-zero
3870         length, are found.
3871         (riscv_arg_location): Initialise the length of each location, a
3872         non-zero length now indicates the location is in use.
3873         (riscv_push_dummy_call): Allow for the first location having a
3874         non-zero offset when setting up arguments.
3875         (riscv_return_value): Likewise, but for return values.
3876
3877 2019-04-11  Tom Tromey  <tromey@adacore.com>
3878
3879         * utils.c (internal_vproblem): Make "msg" const.
3880
3881 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3882
3883         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3884         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3885         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3886         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3887
3888 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3889
3890         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3891         function.
3892         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3893         of amd64_collect_native_gregset.
3894         (amd64_linux_nat_target::store_registers): Likewise.
3895
3896 2019-04-10  Tom Tromey  <tom@tromey.com>
3897
3898         * symtab.c (lookup_global_symbol_from_objfile)
3899         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3900         * objfiles.h (class separate_debug_iterator): New.
3901         (class separate_debug_range): New.
3902         (struct objfile) <separate_debug_objfiles>: New method.
3903         (objfile_separate_debug_iterate): Don't declare.
3904         * objfiles.c (separate_debug_iterator::operator++): Rename from
3905         objfile_separate_debug_iterate.
3906         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3907         iterator.
3908         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3909         iterator.
3910
3911 2019-04-10  Tom Tromey  <tom@tromey.com>
3912
3913         * symfile.c (reread_symbols): Remove old comment.
3914         * objfiles.c (free_all_objfiles): Fix a typo.
3915
3916 2019-04-10  Tom Tromey  <tom@tromey.com>
3917
3918         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3919         * minsyms.c (lookup_minimal_symbol): Use foreach.
3920         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3921         (lookup_minimal_symbol_solib_trampoline): Likewise.
3922         * symfile.c (reread_symbols): Use foreach.
3923
3924 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3925             Tom Tromey  <tromey@adacore.com>
3926
3927         PR rust/24414:
3928         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3929         (rust_lex_int_test): Change "value" to be LONGEST.
3930         (rust_lex_tests): Add test for long integer literal.
3931
3932 2019-04-09  Tom Tromey  <tromey@adacore.com>
3933
3934         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3935         to bool.
3936         (extended_remote_target::attach): Update.
3937         (remote_target::remote_notice_new_inferior): Update.
3938         (remote_target::add_current_inferior_and_thread): Update.
3939         * inferior.c (exit_inferior_1): Use "false".
3940         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3941
3942 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3943
3944         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3945         the "start" command.
3946
3947 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3948
3949         * python/py-inferior.c (infpy_thread_from_thread_handle):
3950         Adjust comments to reflect renaming of thread_from_thread_handle
3951         to thread_from_handle.  Adjust keywords.  Fix type error message.
3952         (inferior_object_methods): Add thread_from_handle.  Retain
3953         thread_from_thread_handle, but mark it as deprecated.
3954
3955 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3956
3957         * gdbthread.h (find_thread_by_handle): Revise declaration.
3958         * thread.c (find_thread_by_handle): Likewise.  Adjust
3959         implementation too.
3960         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3961         support for buffer objects as handles.
3962
3963 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3964
3965         * python/py-infthread.c (thpy_thread_handle): New function.
3966         (thread_object_methods): Register thpy_thread_handle.
3967
3968 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3969
3970         * gdbthread.h (thread_to_thread_handle): Declare.
3971         * thread.c (gdbtypes.h): Include.
3972         (thread_to_thread_handle): New function.
3973
3974         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3975         (target_thread_info_to_thread_handle): Declare.
3976         * target.c (target_thread_info_to_thread_handle): New function.
3977         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3978         * target-delegates.c: Regenerate.
3979
3980         * linux-thread-db.c (class thread_db_target): Add method
3981         thread_info_to_thread_handle.
3982         (thread_db_target::thread_info_to_thread_handle): Define.
3983         * remote.c (class remote_target): Add new method
3984         thread_info_to_thread_handle.
3985         (remote_target::thread_info_to_thread_handle): Define.
3986
3987 2019-04-08  Pedro Alves  <palves@redhat.com>
3988
3989         * common/common-exceptions.c (throw_exception): Don't create
3990         named object to throw; throw directly.
3991         (throw_it): Likewise.  Don't initialize gdb_exception::message
3992         here, with new; pass FMT and AP to the ctor instead.
3993         * common/common-exceptions.h: Include <string>.
3994         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3995         const char *, va_list)): New ctor.  Use std::make_shared.
3996         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3997         errors)): Delete.
3998         (gdb_exception_error::gdb_exception_error(enum errors, const char
3999         *, va_list)): New.
4000         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4001         Add assertion.
4002         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4003         errors)): Delete.
4004         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4005         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4006         Add assertion.
4007
4008 2019-04-08  Tom Tromey  <tom@tromey.com>
4009
4010         * valops.c (value_rtti_indirect_type): Replace throw_exception
4011         with throw.
4012         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4013         with throw.
4014         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4015         throw.
4016         * target.c (target_translate_tls_address): Replace throw_exception
4017         with throw.
4018         * stack.c (frame_apply_command_count): Replace throw_exception
4019         with throw.
4020         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4021         throw.
4022         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4023         with throw.
4024         * rs6000-tdep.c (rs6000_frame_cache)
4025         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4026         * remote.c: Replace throw_exception with throw.
4027         * record-full.c (record_full_message, record_full_wait_1)
4028         (record_full_restore): Replace throw_exception with throw.
4029         * record-btrace.c:
4030         (get_thread_current_frame_id, record_btrace_start_replaying)
4031         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4032         (cmd_record_btrace_start): Replace throw_exception with throw.
4033         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4034         throw.
4035         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4036         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4037         * linespec.c:
4038         (find_linespec_symbols): Replace throw_exception with throw.
4039         * infrun.c (displaced_step_prepare, resume): Replace
4040         throw_exception with throw.
4041         * infcmd.c (post_create_inferior): Replace throw_exception with
4042         throw.
4043         * inf-loop.c (inferior_event_handler): Replace throw_exception
4044         with throw.
4045         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4046         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4047         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4048         (get_prev_frame_always, get_frame_pc_if_available)
4049         (get_frame_address_in_block_if_available, get_frame_language):
4050         Replace throw_exception with throw.
4051         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4052         throw_exception with throw.
4053         * eval.c (fetch_subexp_value, evaluate_var_value)
4054         (evaluate_funcall, evaluate_subexp_standard): Replace
4055         throw_exception with throw.
4056         * dwarf2loc.c (call_site_find_chain)
4057         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4058         Replace throw_exception with throw.
4059         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4060         with throw.
4061         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4062         throw.
4063         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4064         * completer.c (complete_line_internal): Replace throw_exception
4065         with throw.
4066         * compile/compile-object-run.c (compile_object_run): Replace
4067         throw_exception with throw.
4068         * cli/cli-script.c (process_next_line): Replace throw_exception
4069         with throw.
4070         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4071         (btrace_enable, btrace_maint_update_pt_packets): Replace
4072         throw_exception with throw.
4073         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4074         throw_exception with throw.
4075         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4076         throw_exception with throw.
4077         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4078         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4079         * aarch64-tdep.c (aarch64_make_prologue_cache)
4080         (aarch64_make_stub_cache): Replace throw_exception with throw.
4081
4082 2019-04-08  Tom Tromey  <tom@tromey.com>
4083
4084         * common/common-exceptions.c (throw_exception): Rename from
4085         throw_exception_cxx.  Remove old copy.  Make argument const.
4086         (throw_it): Create and throw exception objects directly.
4087         * common/common-exceptions.h (throw_exception): Make argument
4088         const.
4089         (struct gdb_exception_error): Add constructor.
4090         (struct gdb_exception_quit): Add constructor.
4091
4092 2019-04-08  Tom Tromey  <tom@tromey.com>
4093
4094         * common/common-exceptions.h (exception_rethrow): Don't declare.
4095         (TRY_SJLJ): Update comment.
4096         (TRY, CATCH, END_CATCH): Remove.
4097         * common/common-exceptions.c (exception_rethrow): Remove.
4098
4099 2019-04-08  Tom Tromey  <tom@tromey.com>
4100
4101         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4102         Remove.
4103         (gdb_exception_error): Rename from
4104         gdb_exception_RETURN_MASK_ERROR.
4105         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4106         (gdb_quit_bad_alloc): Update.
4107         * aarch64-tdep.c: Update.
4108         * ada-lang.c: Update.
4109         * ada-typeprint.c: Update.
4110         * ada-valprint.c: Update.
4111         * amd64-tdep.c: Update.
4112         * arch-utils.c: Update.
4113         * break-catch-throw.c: Update.
4114         * breakpoint.c: Update.
4115         * btrace.c: Update.
4116         * c-varobj.c: Update.
4117         * cli/cli-cmds.c: Update.
4118         * cli/cli-interp.c: Update.
4119         * cli/cli-script.c: Update.
4120         * common/common-exceptions.c: Update.
4121         * common/new-op.c: Update.
4122         * common/selftest.c: Update.
4123         * compile/compile-c-symbols.c: Update.
4124         * compile/compile-cplus-symbols.c: Update.
4125         * compile/compile-object-load.c: Update.
4126         * compile/compile-object-run.c: Update.
4127         * completer.c: Update.
4128         * corelow.c: Update.
4129         * cp-abi.c: Update.
4130         * cp-support.c: Update.
4131         * cp-valprint.c: Update.
4132         * darwin-nat.c: Update.
4133         * disasm-selftests.c: Update.
4134         * dtrace-probe.c: Update.
4135         * dwarf-index-cache.c: Update.
4136         * dwarf-index-write.c: Update.
4137         * dwarf2-frame-tailcall.c: Update.
4138         * dwarf2-frame.c: Update.
4139         * dwarf2loc.c: Update.
4140         * dwarf2read.c: Update.
4141         * eval.c: Update.
4142         * event-loop.c: Update.
4143         * event-top.c: Update.
4144         * exec.c: Update.
4145         * f-valprint.c: Update.
4146         * fbsd-tdep.c: Update.
4147         * frame-unwind.c: Update.
4148         * frame.c: Update.
4149         * gdbtypes.c: Update.
4150         * gnu-v3-abi.c: Update.
4151         * guile/guile-internal.h: Update.
4152         * guile/scm-block.c: Update.
4153         * guile/scm-breakpoint.c: Update.
4154         * guile/scm-cmd.c: Update.
4155         * guile/scm-disasm.c: Update.
4156         * guile/scm-frame.c: Update.
4157         * guile/scm-lazy-string.c: Update.
4158         * guile/scm-math.c: Update.
4159         * guile/scm-param.c: Update.
4160         * guile/scm-ports.c: Update.
4161         * guile/scm-pretty-print.c: Update.
4162         * guile/scm-symbol.c: Update.
4163         * guile/scm-symtab.c: Update.
4164         * guile/scm-type.c: Update.
4165         * guile/scm-value.c: Update.
4166         * i386-linux-tdep.c: Update.
4167         * i386-tdep.c: Update.
4168         * inf-loop.c: Update.
4169         * infcall.c: Update.
4170         * infcmd.c: Update.
4171         * infrun.c: Update.
4172         * jit.c: Update.
4173         * language.c: Update.
4174         * linespec.c: Update.
4175         * linux-fork.c: Update.
4176         * linux-nat.c: Update.
4177         * linux-tdep.c: Update.
4178         * linux-thread-db.c: Update.
4179         * main.c: Update.
4180         * mi/mi-cmd-break.c: Update.
4181         * mi/mi-cmd-stack.c: Update.
4182         * mi/mi-interp.c: Update.
4183         * mi/mi-main.c: Update.
4184         * objc-lang.c: Update.
4185         * p-valprint.c: Update.
4186         * parse.c: Update.
4187         * ppc-linux-tdep.c: Update.
4188         * printcmd.c: Update.
4189         * python/py-arch.c: Update.
4190         * python/py-breakpoint.c: Update.
4191         * python/py-cmd.c: Update.
4192         * python/py-finishbreakpoint.c: Update.
4193         * python/py-frame.c: Update.
4194         * python/py-framefilter.c: Update.
4195         * python/py-gdb-readline.c: Update.
4196         * python/py-inferior.c: Update.
4197         * python/py-infthread.c: Update.
4198         * python/py-lazy-string.c: Update.
4199         * python/py-linetable.c: Update.
4200         * python/py-objfile.c: Update.
4201         * python/py-param.c: Update.
4202         * python/py-prettyprint.c: Update.
4203         * python/py-progspace.c: Update.
4204         * python/py-record-btrace.c: Update.
4205         * python/py-record.c: Update.
4206         * python/py-symbol.c: Update.
4207         * python/py-type.c: Update.
4208         * python/py-unwind.c: Update.
4209         * python/py-utils.c: Update.
4210         * python/py-value.c: Update.
4211         * python/python.c: Update.
4212         * record-btrace.c: Update.
4213         * record-full.c: Update.
4214         * remote-fileio.c: Update.
4215         * remote.c: Update.
4216         * riscv-tdep.c: Update.
4217         * rs6000-aix-tdep.c: Update.
4218         * rs6000-tdep.c: Update.
4219         * rust-exp.y: Update.
4220         * rust-lang.c: Update.
4221         * s390-tdep.c: Update.
4222         * selftest-arch.c: Update.
4223         * solib-dsbt.c: Update.
4224         * solib-frv.c: Update.
4225         * solib-spu.c: Update.
4226         * solib-svr4.c: Update.
4227         * solib.c: Update.
4228         * sparc64-linux-tdep.c: Update.
4229         * stack.c: Update.
4230         * symfile-mem.c: Update.
4231         * symmisc.c: Update.
4232         * target.c: Update.
4233         * thread.c: Update.
4234         * top.c: Update.
4235         * tracefile-tfile.c: Update.
4236         * tui/tui.c: Update.
4237         * typeprint.c: Update.
4238         * unittests/cli-utils-selftests.c: Update.
4239         * unittests/parse-connection-spec-selftests.c: Update.
4240         * valops.c: Update.
4241         * valprint.c: Update.
4242         * value.c: Update.
4243         * varobj.c: Update.
4244         * windows-nat.c: Update.
4245         * x86-linux-nat.c: Update.
4246         * xml-support.c: Update.
4247
4248 2019-04-08  Tom Tromey  <tom@tromey.com>
4249
4250         * xml-support.c: Use C++ exception handling.
4251         * x86-linux-nat.c: Use C++ exception handling.
4252         * windows-nat.c: Use C++ exception handling.
4253         * varobj.c: Use C++ exception handling.
4254         * value.c: Use C++ exception handling.
4255         * valprint.c: Use C++ exception handling.
4256         * valops.c: Use C++ exception handling.
4257         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4258         handling.
4259         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4260         * typeprint.c: Use C++ exception handling.
4261         * tui/tui.c: Use C++ exception handling.
4262         * tracefile-tfile.c: Use C++ exception handling.
4263         * top.c: Use C++ exception handling.
4264         * thread.c: Use C++ exception handling.
4265         * target.c: Use C++ exception handling.
4266         * symmisc.c: Use C++ exception handling.
4267         * symfile-mem.c: Use C++ exception handling.
4268         * stack.c: Use C++ exception handling.
4269         * sparc64-linux-tdep.c: Use C++ exception handling.
4270         * solib.c: Use C++ exception handling.
4271         * solib-svr4.c: Use C++ exception handling.
4272         * solib-spu.c: Use C++ exception handling.
4273         * solib-frv.c: Use C++ exception handling.
4274         * solib-dsbt.c: Use C++ exception handling.
4275         * selftest-arch.c: Use C++ exception handling.
4276         * s390-tdep.c: Use C++ exception handling.
4277         * rust-lang.c: Use C++ exception handling.
4278         * rust-exp.y: Use C++ exception handling.
4279         * rs6000-tdep.c: Use C++ exception handling.
4280         * rs6000-aix-tdep.c: Use C++ exception handling.
4281         * riscv-tdep.c: Use C++ exception handling.
4282         * remote.c: Use C++ exception handling.
4283         * remote-fileio.c: Use C++ exception handling.
4284         * record-full.c: Use C++ exception handling.
4285         * record-btrace.c: Use C++ exception handling.
4286         * python/python.c: Use C++ exception handling.
4287         * python/py-value.c: Use C++ exception handling.
4288         * python/py-utils.c: Use C++ exception handling.
4289         * python/py-unwind.c: Use C++ exception handling.
4290         * python/py-type.c: Use C++ exception handling.
4291         * python/py-symbol.c: Use C++ exception handling.
4292         * python/py-record.c: Use C++ exception handling.
4293         * python/py-record-btrace.c: Use C++ exception handling.
4294         * python/py-progspace.c: Use C++ exception handling.
4295         * python/py-prettyprint.c: Use C++ exception handling.
4296         * python/py-param.c: Use C++ exception handling.
4297         * python/py-objfile.c: Use C++ exception handling.
4298         * python/py-linetable.c: Use C++ exception handling.
4299         * python/py-lazy-string.c: Use C++ exception handling.
4300         * python/py-infthread.c: Use C++ exception handling.
4301         * python/py-inferior.c: Use C++ exception handling.
4302         * python/py-gdb-readline.c: Use C++ exception handling.
4303         * python/py-framefilter.c: Use C++ exception handling.
4304         * python/py-frame.c: Use C++ exception handling.
4305         * python/py-finishbreakpoint.c: Use C++ exception handling.
4306         * python/py-cmd.c: Use C++ exception handling.
4307         * python/py-breakpoint.c: Use C++ exception handling.
4308         * python/py-arch.c: Use C++ exception handling.
4309         * printcmd.c: Use C++ exception handling.
4310         * ppc-linux-tdep.c: Use C++ exception handling.
4311         * parse.c: Use C++ exception handling.
4312         * p-valprint.c: Use C++ exception handling.
4313         * objc-lang.c: Use C++ exception handling.
4314         * mi/mi-main.c: Use C++ exception handling.
4315         * mi/mi-interp.c: Use C++ exception handling.
4316         * mi/mi-cmd-stack.c: Use C++ exception handling.
4317         * mi/mi-cmd-break.c: Use C++ exception handling.
4318         * main.c: Use C++ exception handling.
4319         * linux-thread-db.c: Use C++ exception handling.
4320         * linux-tdep.c: Use C++ exception handling.
4321         * linux-nat.c: Use C++ exception handling.
4322         * linux-fork.c: Use C++ exception handling.
4323         * linespec.c: Use C++ exception handling.
4324         * language.c: Use C++ exception handling.
4325         * jit.c: Use C++ exception handling.
4326         * infrun.c: Use C++ exception handling.
4327         * infcmd.c: Use C++ exception handling.
4328         * infcall.c: Use C++ exception handling.
4329         * inf-loop.c: Use C++ exception handling.
4330         * i386-tdep.c: Use C++ exception handling.
4331         * i386-linux-tdep.c: Use C++ exception handling.
4332         * guile/scm-value.c: Use C++ exception handling.
4333         * guile/scm-type.c: Use C++ exception handling.
4334         * guile/scm-symtab.c: Use C++ exception handling.
4335         * guile/scm-symbol.c: Use C++ exception handling.
4336         * guile/scm-pretty-print.c: Use C++ exception handling.
4337         * guile/scm-ports.c: Use C++ exception handling.
4338         * guile/scm-param.c: Use C++ exception handling.
4339         * guile/scm-math.c: Use C++ exception handling.
4340         * guile/scm-lazy-string.c: Use C++ exception handling.
4341         * guile/scm-frame.c: Use C++ exception handling.
4342         * guile/scm-disasm.c: Use C++ exception handling.
4343         * guile/scm-cmd.c: Use C++ exception handling.
4344         * guile/scm-breakpoint.c: Use C++ exception handling.
4345         * guile/scm-block.c: Use C++ exception handling.
4346         * guile/guile-internal.h: Use C++ exception handling.
4347         * gnu-v3-abi.c: Use C++ exception handling.
4348         * gdbtypes.c: Use C++ exception handling.
4349         * frame.c: Use C++ exception handling.
4350         * frame-unwind.c: Use C++ exception handling.
4351         * fbsd-tdep.c: Use C++ exception handling.
4352         * f-valprint.c: Use C++ exception handling.
4353         * exec.c: Use C++ exception handling.
4354         * event-top.c: Use C++ exception handling.
4355         * event-loop.c: Use C++ exception handling.
4356         * eval.c: Use C++ exception handling.
4357         * dwarf2read.c: Use C++ exception handling.
4358         * dwarf2loc.c: Use C++ exception handling.
4359         * dwarf2-frame.c: Use C++ exception handling.
4360         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4361         * dwarf-index-write.c: Use C++ exception handling.
4362         * dwarf-index-cache.c: Use C++ exception handling.
4363         * dtrace-probe.c: Use C++ exception handling.
4364         * disasm-selftests.c: Use C++ exception handling.
4365         * darwin-nat.c: Use C++ exception handling.
4366         * cp-valprint.c: Use C++ exception handling.
4367         * cp-support.c: Use C++ exception handling.
4368         * cp-abi.c: Use C++ exception handling.
4369         * corelow.c: Use C++ exception handling.
4370         * completer.c: Use C++ exception handling.
4371         * compile/compile-object-run.c: Use C++ exception handling.
4372         * compile/compile-object-load.c: Use C++ exception handling.
4373         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4374         * compile/compile-c-symbols.c: Use C++ exception handling.
4375         * common/selftest.c: Use C++ exception handling.
4376         * common/new-op.c: Use C++ exception handling.
4377         * cli/cli-script.c: Use C++ exception handling.
4378         * cli/cli-interp.c: Use C++ exception handling.
4379         * cli/cli-cmds.c: Use C++ exception handling.
4380         * c-varobj.c: Use C++ exception handling.
4381         * btrace.c: Use C++ exception handling.
4382         * breakpoint.c: Use C++ exception handling.
4383         * break-catch-throw.c: Use C++ exception handling.
4384         * arch-utils.c: Use C++ exception handling.
4385         * amd64-tdep.c: Use C++ exception handling.
4386         * ada-valprint.c: Use C++ exception handling.
4387         * ada-typeprint.c: Use C++ exception handling.
4388         * ada-lang.c: Use C++ exception handling.
4389         * aarch64-tdep.c: Use C++ exception handling.
4390
4391 2019-04-08  Tom Tromey  <tom@tromey.com>
4392
4393         * xml-support.c (gdb_xml_parser::parse): Update.
4394         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4395         * value.c (show_convenience): Update.
4396         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4397         (test_parse_flags_qcs): Update.
4398         * thread.c (thr_try_catch_cmd): Update.
4399         * target.c (target_translate_tls_address): Update.
4400         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4401         (info_frame_command_core, frame_apply_command_count): Update.
4402         * rust-exp.y (rust_lex_exception_test): Update.
4403         * riscv-tdep.c (riscv_print_one_register_info): Update.
4404         * remote.c (remote_target::enable_btrace): Update.
4405         * record-btrace.c (record_btrace_enable_warn): Update.
4406         * python/py-utils.c (gdbpy_convert_exception): Update.
4407         * printcmd.c (do_one_display, print_variable_and_value): Update.
4408         * mi/mi-main.c (mi_print_exception): Update.
4409         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4410         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4411         * linux-nat.c (linux_nat_target::attach): Update.
4412         * linux-fork.c (class scoped_switch_fork_info): Update.
4413         * infrun.c (displaced_step_prepare): Update.
4414         * infcall.c (call_function_by_hand_dummy): Update.
4415         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4416         * gnu-v3-abi.c (print_one_vtable): Update.
4417         * frame.c (get_prev_frame_always): Update.
4418         * f-valprint.c (info_common_command_for_block): Update.
4419         * exec.c (try_open_exec_file): Update.
4420         * exceptions.c (print_exception, exception_print)
4421         (exception_fprintf, exception_print_same): Update.
4422         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4423         * dwarf-index-cache.c (index_cache::store)
4424         (index_cache::lookup_gdb_index): Update.
4425         * darwin-nat.c (maybe_cache_shell): Update.
4426         * cp-valprint.c (cp_print_value_fields): Update.
4427         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4428         (gcc_cplus_symbol_address): Update.
4429         * compile/compile-c-symbols.c (gcc_convert_symbol)
4430         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4431         * common/selftest.c: Update.
4432         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4433         a std::string.
4434         (exception_try_scope_entry, exception_try_scope_exit): Don't
4435         declare.
4436         (struct exception_try_scope): Remove.
4437         (TRY): Don't use exception_try_scope.
4438         (struct gdb_exception): Add constructor, operator=.
4439         <what>: New method.
4440         (struct gdb_exception_RETURN_MASK_ALL)
4441         (struct gdb_exception_RETURN_MASK_ERROR)
4442         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4443         (struct gdb_quit_bad_alloc): Update.
4444         * common/common-exceptions.c (exception_none): Change
4445         initializer.
4446         (struct catcher) <state, exception>: Initialize inline.
4447         <prev>: Remove member.
4448         (current_catcher): Remove.
4449         (catchers): New global.
4450         (exceptions_state_mc_init): Simplify.
4451         (catcher_pop): Remove.
4452         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4453         (try_scope_depth, exception_try_scope_entry)
4454         (exception_try_scope_exit): Remove.
4455         (throw_exception_sjlj): Update.
4456         (exception_messages, exception_messages_size): Remove.
4457         (throw_it): Simplify.
4458         (gdb_exception_sliced_copy): Remove.
4459         (throw_exception_cxx): Update.
4460         * cli/cli-script.c (script_from_file): Update.
4461         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4462         Update.
4463         * ada-valprint.c (ada_val_print): Update.
4464         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4465         (create_excep_cond_exprs): Update.
4466
4467 2019-04-08  Tom Tromey  <tom@tromey.com>
4468
4469         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4470         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4471         (TRY, CATCH, END_CATCH): Remove some definitions.
4472         * common/common-exceptions.c: Don't use GDB_XCPT.
4473         (catcher_list_size): Remove.
4474         (throw_exception, throw_it): Simplify.
4475
4476 2019-04-05  Tom Tromey  <tom@tromey.com>
4477
4478         Revert the header-sorting patch.
4479         * ft32-tdep.c: Revert.
4480         * frv-tdep.c: Revert.
4481         * frv-linux-tdep.c: Revert.
4482         * frame.c: Revert.
4483         * frame-unwind.c: Revert.
4484         * frame-base.c: Revert.
4485         * fork-child.c: Revert.
4486         * findvar.c: Revert.
4487         * findcmd.c: Revert.
4488         * filesystem.c: Revert.
4489         * filename-seen-cache.h: Revert.
4490         * filename-seen-cache.c: Revert.
4491         * fbsd-tdep.c: Revert.
4492         * fbsd-nat.h: Revert.
4493         * fbsd-nat.c: Revert.
4494         * f-valprint.c: Revert.
4495         * f-typeprint.c: Revert.
4496         * f-lang.c: Revert.
4497         * extension.h: Revert.
4498         * extension.c: Revert.
4499         * extension-priv.h: Revert.
4500         * expprint.c: Revert.
4501         * exec.h: Revert.
4502         * exec.c: Revert.
4503         * exceptions.c: Revert.
4504         * event-top.c: Revert.
4505         * event-loop.c: Revert.
4506         * eval.c: Revert.
4507         * elfread.c: Revert.
4508         * dwarf2read.h: Revert.
4509         * dwarf2read.c: Revert.
4510         * dwarf2loc.c: Revert.
4511         * dwarf2expr.h: Revert.
4512         * dwarf2expr.c: Revert.
4513         * dwarf2-frame.c: Revert.
4514         * dwarf2-frame-tailcall.c: Revert.
4515         * dwarf-index-write.h: Revert.
4516         * dwarf-index-write.c: Revert.
4517         * dwarf-index-common.c: Revert.
4518         * dwarf-index-cache.h: Revert.
4519         * dwarf-index-cache.c: Revert.
4520         * dummy-frame.c: Revert.
4521         * dtrace-probe.c: Revert.
4522         * disasm.h: Revert.
4523         * disasm.c: Revert.
4524         * disasm-selftests.c: Revert.
4525         * dictionary.c: Revert.
4526         * dicos-tdep.c: Revert.
4527         * demangle.c: Revert.
4528         * dcache.h: Revert.
4529         * dcache.c: Revert.
4530         * darwin-nat.h: Revert.
4531         * darwin-nat.c: Revert.
4532         * darwin-nat-info.c: Revert.
4533         * d-valprint.c: Revert.
4534         * d-namespace.c: Revert.
4535         * d-lang.c: Revert.
4536         * ctf.c: Revert.
4537         * csky-tdep.c: Revert.
4538         * csky-linux-tdep.c: Revert.
4539         * cris-tdep.c: Revert.
4540         * cris-linux-tdep.c: Revert.
4541         * cp-valprint.c: Revert.
4542         * cp-support.c: Revert.
4543         * cp-namespace.c: Revert.
4544         * cp-abi.c: Revert.
4545         * corelow.c: Revert.
4546         * corefile.c: Revert.
4547         * continuations.c: Revert.
4548         * completer.h: Revert.
4549         * completer.c: Revert.
4550         * complaints.c: Revert.
4551         * coffread.c: Revert.
4552         * coff-pe-read.c: Revert.
4553         * cli-out.h: Revert.
4554         * cli-out.c: Revert.
4555         * charset.c: Revert.
4556         * c-varobj.c: Revert.
4557         * c-valprint.c: Revert.
4558         * c-typeprint.c: Revert.
4559         * c-lang.c: Revert.
4560         * buildsym.c: Revert.
4561         * buildsym-legacy.c: Revert.
4562         * build-id.h: Revert.
4563         * build-id.c: Revert.
4564         * btrace.c: Revert.
4565         * bsd-uthread.c: Revert.
4566         * breakpoint.h: Revert.
4567         * breakpoint.c: Revert.
4568         * break-catch-throw.c: Revert.
4569         * break-catch-syscall.c: Revert.
4570         * break-catch-sig.c: Revert.
4571         * blockframe.c: Revert.
4572         * block.c: Revert.
4573         * bfin-tdep.c: Revert.
4574         * bfin-linux-tdep.c: Revert.
4575         * bfd-target.c: Revert.
4576         * bcache.c: Revert.
4577         * ax-general.c: Revert.
4578         * ax-gdb.h: Revert.
4579         * ax-gdb.c: Revert.
4580         * avr-tdep.c: Revert.
4581         * auxv.c: Revert.
4582         * auto-load.c: Revert.
4583         * arm-wince-tdep.c: Revert.
4584         * arm-tdep.c: Revert.
4585         * arm-symbian-tdep.c: Revert.
4586         * arm-pikeos-tdep.c: Revert.
4587         * arm-obsd-tdep.c: Revert.
4588         * arm-nbsd-tdep.c: Revert.
4589         * arm-nbsd-nat.c: Revert.
4590         * arm-linux-tdep.c: Revert.
4591         * arm-linux-nat.c: Revert.
4592         * arm-fbsd-tdep.c: Revert.
4593         * arm-fbsd-nat.c: Revert.
4594         * arm-bsd-tdep.c: Revert.
4595         * arch-utils.c: Revert.
4596         * arc-tdep.c: Revert.
4597         * arc-newlib-tdep.c: Revert.
4598         * annotate.h: Revert.
4599         * annotate.c: Revert.
4600         * amd64-windows-tdep.c: Revert.
4601         * amd64-windows-nat.c: Revert.
4602         * amd64-tdep.c: Revert.
4603         * amd64-sol2-tdep.c: Revert.
4604         * amd64-obsd-tdep.c: Revert.
4605         * amd64-obsd-nat.c: Revert.
4606         * amd64-nbsd-tdep.c: Revert.
4607         * amd64-nbsd-nat.c: Revert.
4608         * amd64-nat.c: Revert.
4609         * amd64-linux-tdep.c: Revert.
4610         * amd64-linux-nat.c: Revert.
4611         * amd64-fbsd-tdep.c: Revert.
4612         * amd64-fbsd-nat.c: Revert.
4613         * amd64-dicos-tdep.c: Revert.
4614         * amd64-darwin-tdep.c: Revert.
4615         * amd64-bsd-nat.c: Revert.
4616         * alpha-tdep.c: Revert.
4617         * alpha-obsd-tdep.c: Revert.
4618         * alpha-nbsd-tdep.c: Revert.
4619         * alpha-mdebug-tdep.c: Revert.
4620         * alpha-linux-tdep.c: Revert.
4621         * alpha-linux-nat.c: Revert.
4622         * alpha-bsd-tdep.c: Revert.
4623         * alpha-bsd-nat.c: Revert.
4624         * aix-thread.c: Revert.
4625         * agent.c: Revert.
4626         * addrmap.c: Revert.
4627         * ada-varobj.c: Revert.
4628         * ada-valprint.c: Revert.
4629         * ada-typeprint.c: Revert.
4630         * ada-tasks.c: Revert.
4631         * ada-lang.c: Revert.
4632         * aarch64-tdep.c: Revert.
4633         * aarch64-ravenscar-thread.c: Revert.
4634         * aarch64-newlib-tdep.c: Revert.
4635         * aarch64-linux-tdep.c: Revert.
4636         * aarch64-linux-nat.c: Revert.
4637         * aarch64-fbsd-tdep.c: Revert.
4638         * aarch64-fbsd-nat.c: Revert.
4639         * aarch32-linux-nat.c: Revert.
4640
4641 2019-04-05  Tom Tromey  <tom@tromey.com>
4642
4643         * ft32-tdep.c: Sort headers.
4644         * frv-tdep.c: Sort headers.
4645         * frv-linux-tdep.c: Sort headers.
4646         * frame.c: Sort headers.
4647         * frame-unwind.c: Sort headers.
4648         * frame-base.c: Sort headers.
4649         * fork-child.c: Sort headers.
4650         * findvar.c: Sort headers.
4651         * findcmd.c: Sort headers.
4652         * filesystem.c: Sort headers.
4653         * filename-seen-cache.h: Sort headers.
4654         * filename-seen-cache.c: Sort headers.
4655         * fbsd-tdep.c: Sort headers.
4656         * fbsd-nat.h: Sort headers.
4657         * fbsd-nat.c: Sort headers.
4658         * f-valprint.c: Sort headers.
4659         * f-typeprint.c: Sort headers.
4660         * f-lang.c: Sort headers.
4661         * extension.h: Sort headers.
4662         * extension.c: Sort headers.
4663         * extension-priv.h: Sort headers.
4664         * expprint.c: Sort headers.
4665         * exec.h: Sort headers.
4666         * exec.c: Sort headers.
4667         * exceptions.c: Sort headers.
4668         * event-top.c: Sort headers.
4669         * event-loop.c: Sort headers.
4670         * eval.c: Sort headers.
4671         * elfread.c: Sort headers.
4672         * dwarf2read.h: Sort headers.
4673         * dwarf2read.c: Sort headers.
4674         * dwarf2loc.c: Sort headers.
4675         * dwarf2expr.h: Sort headers.
4676         * dwarf2expr.c: Sort headers.
4677         * dwarf2-frame.c: Sort headers.
4678         * dwarf2-frame-tailcall.c: Sort headers.
4679         * dwarf-index-write.h: Sort headers.
4680         * dwarf-index-write.c: Sort headers.
4681         * dwarf-index-common.c: Sort headers.
4682         * dwarf-index-cache.h: Sort headers.
4683         * dwarf-index-cache.c: Sort headers.
4684         * dummy-frame.c: Sort headers.
4685         * dtrace-probe.c: Sort headers.
4686         * disasm.h: Sort headers.
4687         * disasm.c: Sort headers.
4688         * disasm-selftests.c: Sort headers.
4689         * dictionary.c: Sort headers.
4690         * dicos-tdep.c: Sort headers.
4691         * demangle.c: Sort headers.
4692         * dcache.h: Sort headers.
4693         * dcache.c: Sort headers.
4694         * darwin-nat.h: Sort headers.
4695         * darwin-nat.c: Sort headers.
4696         * darwin-nat-info.c: Sort headers.
4697         * d-valprint.c: Sort headers.
4698         * d-namespace.c: Sort headers.
4699         * d-lang.c: Sort headers.
4700         * ctf.c: Sort headers.
4701         * csky-tdep.c: Sort headers.
4702         * csky-linux-tdep.c: Sort headers.
4703         * cris-tdep.c: Sort headers.
4704         * cris-linux-tdep.c: Sort headers.
4705         * cp-valprint.c: Sort headers.
4706         * cp-support.c: Sort headers.
4707         * cp-namespace.c: Sort headers.
4708         * cp-abi.c: Sort headers.
4709         * corelow.c: Sort headers.
4710         * corefile.c: Sort headers.
4711         * continuations.c: Sort headers.
4712         * completer.h: Sort headers.
4713         * completer.c: Sort headers.
4714         * complaints.c: Sort headers.
4715         * coffread.c: Sort headers.
4716         * coff-pe-read.c: Sort headers.
4717         * cli-out.h: Sort headers.
4718         * cli-out.c: Sort headers.
4719         * charset.c: Sort headers.
4720         * c-varobj.c: Sort headers.
4721         * c-valprint.c: Sort headers.
4722         * c-typeprint.c: Sort headers.
4723         * c-lang.c: Sort headers.
4724         * buildsym.c: Sort headers.
4725         * buildsym-legacy.c: Sort headers.
4726         * build-id.h: Sort headers.
4727         * build-id.c: Sort headers.
4728         * btrace.c: Sort headers.
4729         * bsd-uthread.c: Sort headers.
4730         * breakpoint.h: Sort headers.
4731         * breakpoint.c: Sort headers.
4732         * break-catch-throw.c: Sort headers.
4733         * break-catch-syscall.c: Sort headers.
4734         * break-catch-sig.c: Sort headers.
4735         * blockframe.c: Sort headers.
4736         * block.c: Sort headers.
4737         * bfin-tdep.c: Sort headers.
4738         * bfin-linux-tdep.c: Sort headers.
4739         * bfd-target.c: Sort headers.
4740         * bcache.c: Sort headers.
4741         * ax-general.c: Sort headers.
4742         * ax-gdb.h: Sort headers.
4743         * ax-gdb.c: Sort headers.
4744         * avr-tdep.c: Sort headers.
4745         * auxv.c: Sort headers.
4746         * auto-load.c: Sort headers.
4747         * arm-wince-tdep.c: Sort headers.
4748         * arm-tdep.c: Sort headers.
4749         * arm-symbian-tdep.c: Sort headers.
4750         * arm-pikeos-tdep.c: Sort headers.
4751         * arm-obsd-tdep.c: Sort headers.
4752         * arm-nbsd-tdep.c: Sort headers.
4753         * arm-nbsd-nat.c: Sort headers.
4754         * arm-linux-tdep.c: Sort headers.
4755         * arm-linux-nat.c: Sort headers.
4756         * arm-fbsd-tdep.c: Sort headers.
4757         * arm-fbsd-nat.c: Sort headers.
4758         * arm-bsd-tdep.c: Sort headers.
4759         * arch-utils.c: Sort headers.
4760         * arc-tdep.c: Sort headers.
4761         * arc-newlib-tdep.c: Sort headers.
4762         * annotate.h: Sort headers.
4763         * annotate.c: Sort headers.
4764         * amd64-windows-tdep.c: Sort headers.
4765         * amd64-windows-nat.c: Sort headers.
4766         * amd64-tdep.c: Sort headers.
4767         * amd64-sol2-tdep.c: Sort headers.
4768         * amd64-obsd-tdep.c: Sort headers.
4769         * amd64-obsd-nat.c: Sort headers.
4770         * amd64-nbsd-tdep.c: Sort headers.
4771         * amd64-nbsd-nat.c: Sort headers.
4772         * amd64-nat.c: Sort headers.
4773         * amd64-linux-tdep.c: Sort headers.
4774         * amd64-linux-nat.c: Sort headers.
4775         * amd64-fbsd-tdep.c: Sort headers.
4776         * amd64-fbsd-nat.c: Sort headers.
4777         * amd64-dicos-tdep.c: Sort headers.
4778         * amd64-darwin-tdep.c: Sort headers.
4779         * amd64-bsd-nat.c: Sort headers.
4780         * alpha-tdep.c: Sort headers.
4781         * alpha-obsd-tdep.c: Sort headers.
4782         * alpha-nbsd-tdep.c: Sort headers.
4783         * alpha-mdebug-tdep.c: Sort headers.
4784         * alpha-linux-tdep.c: Sort headers.
4785         * alpha-linux-nat.c: Sort headers.
4786         * alpha-bsd-tdep.c: Sort headers.
4787         * alpha-bsd-nat.c: Sort headers.
4788         * aix-thread.c: Sort headers.
4789         * agent.c: Sort headers.
4790         * addrmap.c: Sort headers.
4791         * ada-varobj.c: Sort headers.
4792         * ada-valprint.c: Sort headers.
4793         * ada-typeprint.c: Sort headers.
4794         * ada-tasks.c: Sort headers.
4795         * ada-lang.c: Sort headers.
4796         * aarch64-tdep.c: Sort headers.
4797         * aarch64-ravenscar-thread.c: Sort headers.
4798         * aarch64-newlib-tdep.c: Sort headers.
4799         * aarch64-linux-tdep.c: Sort headers.
4800         * aarch64-linux-nat.c: Sort headers.
4801         * aarch64-fbsd-tdep.c: Sort headers.
4802         * aarch64-fbsd-nat.c: Sort headers.
4803         * aarch32-linux-nat.c: Sort headers.
4804
4805 2019-04-04  Tom Tromey  <tom@tromey.com>
4806
4807         * varobj.c (varobj_create): Update.
4808         * rust-exp.y (struct rust_parser) <update_innermost_block,
4809         lookup_symbol>: New methods.
4810         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4811         Rename.
4812         (rust_parser::rust_lookup_type)
4813         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4814         * printcmd.c (display_command, do_one_display): Update.
4815         * parser-defs.h (struct parser_state) <parser_state>: Add
4816         "tracker" parameter.
4817         (block_tracker): New member.
4818         (class innermost_block_tracker) <innermost_block_tracker>: Add
4819         "types" parameter.
4820         <reset>: Remove method.
4821         (innermost_block): Don't declare.
4822         (null_post_parser): Update.
4823         * parse.c (innermost_block): Remove global.
4824         (write_dollar_variable): Update.
4825         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4826         Remove "tracker_types" parameter.
4827         (parse_expression): Add "tracker" parameter.
4828         (parse_expression_for_completion): Update.
4829         (null_post_parser): Add "tracker" parameter.
4830         * p-exp.y: Update rules.
4831         * m2-exp.y: Update rules.
4832         * language.h (struct language_defn) <la_post_parser>: Add
4833         "tracker" parameter.
4834         * go-exp.y: Update rules.
4835         * f-exp.y: Update rules.
4836         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4837         parameter.
4838         * d-exp.y: Update rules.
4839         * c-exp.y: Update rules.
4840         * breakpoint.c (set_breakpoint_condition): Create an
4841         innermost_block_tracker.
4842         (watch_command_1): Likewise.
4843         * ada-lang.c (resolve): Add "tracker" parameter.
4844         (resolve_subexp): Likewise.
4845         * ada-exp.y (write_var_from_sym): Update.
4846
4847 2019-04-04  Tom Tromey  <tom@tromey.com>
4848
4849         * type-stack.h: New file.
4850         * type-stack.c: New file.
4851         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4852         type-stack.h.
4853         (insert_into_type_stack, insert_type, push_type, push_type_int)
4854         (insert_type_address_space, pop_type, pop_type_int)
4855         (pop_typelist, pop_type_stack, append_type_stack)
4856         (push_type_stack, get_type_stack, push_typelist)
4857         (follow_type_instance_flags, follow_types): Don't declare.
4858         * parse.c (type_stack): Remove global.
4859         (parse_exp_in_context): Update.
4860         (insert_into_type_stack, insert_type, push_type, push_type_int)
4861         (insert_type_address_space, pop_type, pop_type_int)
4862         (pop_typelist, pop_type_stack, append_type_stack)
4863         (push_type_stack, get_type_stack, push_typelist)
4864         (follow_type_instance_flags, follow_types): Remove (moved to
4865         type-stack.c).
4866         * f-exp.y (type_stack): New global.
4867         Update rules.
4868         (push_kind_type, f_parse): Update.
4869         * d-exp.y (type_stack): New global.
4870         Update rules.
4871         (d_parse): Update.
4872         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4873         Update rules.
4874         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4875         (HFILES_NO_SRCDIR): Add type-stack.h.
4876
4877 2019-04-04  Tom Tromey  <tom@tromey.com>
4878
4879         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4880         (rust_parser::convert_ast_to_expression, rust_parse)
4881         (rust_lex_test_completion, rust_lex_tests): Update.
4882         * parser-defs.h (struct expr_completion_state): New.
4883         (struct parser_state) <parser_state>: Add completion parameter.
4884         <mark_struct_expression, mark_completion_tag>: New methods.
4885         <parse_completion, m_completion_state>: New members.
4886         (prefixify_expression, null_post_parser): Update.
4887         (mark_struct_expression, mark_completion_tag): Don't declare.
4888         * parse.c (parse_completion, expout_last_struct)
4889         (expout_tag_completion_type, expout_completion_name): Remove
4890         globals.
4891         (parser_state::mark_struct_expression)
4892         (parser_state::mark_completion_tag): Now methods.
4893         (prefixify_expression): Add last_struct parameter.
4894         (prefixify_subexp): Likewise.
4895         (parse_exp_1): Update.
4896         (parse_exp_in_context): Add cstate parameter.  Update.
4897         (parse_expression_for_completion): Create an
4898         expr_completion_state.
4899         (null_post_parser): Add "completion" parameter.
4900         * p-exp.y: Update rules.
4901         (yylex): Update.
4902         * language.h (struct language_defn) <la_post_parser>: Add
4903         "completing" parameter.
4904         * go-exp.y: Update rules.
4905         (lex_one_token): Update.
4906         * expression.h (parse_completion): Don't declare.
4907         * d-exp.y: Update rules.
4908         (lex_one_token): Update rules.
4909         * c-exp.y: Update rules.
4910         (lex_one_token): Update.
4911         * ada-lang.c (resolve): Add "parse_completion" parameter.
4912         (resolve_subexp): Likewise.
4913         (ada_resolve_function): Likewise.
4914
4915 2019-04-04  Tom Tromey  <tom@tromey.com>
4916
4917         * parser-defs.h (struct parser_state) <start_arglist,
4918         end_arglist>: New methods.
4919         <arglist_len, m_funcall_chain>: New members.
4920         (arglist_len, start_arglist, end_arglist): Don't declare.
4921         * parse.c (arglist_len, funcall_chain): Remove global.
4922         (start_arglist, end_arglist): Remove functions.
4923         (parse_exp_in_context): Update.
4924         * p-exp.y: Update rules.
4925         * m2-exp.y: Update rules.
4926         * go-exp.y: Update rules.
4927         * f-exp.y: Update rules.
4928         * d-exp.y: Update rules.
4929         * c-exp.y: Update rules.
4930
4931 2019-04-04  Tom Tromey  <tom@tromey.com>
4932
4933         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4934         lex_operator, push_back>: New methods.
4935         Update all rules.
4936         (rust_parser::lex_hex, lex_escape): Rename and update.
4937         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4938         (rust_parser::lex_operator): Rename and update.
4939         (rust_parser::lex_number, rustyylex, rustyyerror)
4940         (rust_lex_test_init, rust_lex_test_sequence)
4941         (rust_lex_test_push_back, rust_lex_tests): Update.
4942         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4943         parameter.
4944         <lexptr, prev_lexptr>: New members.
4945         (lexptr, prev_lexptr): Don't declare.
4946         * parse.c (lexptr, prev_lexptr): Remove globals.
4947         (parse_exp_in_context): Update.
4948         * p-exp.y (yylex, yyerror): Update.
4949         * m2-exp.y (parse_number, yylex, yyerror): Update.
4950         * go-exp.y (lex_one_token, yyerror): Update.
4951         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4952         * d-exp.y (lex_one_token, yyerror): Update.
4953         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4954         (lex_one_token, yyerror): Update.
4955         * ada-lex.l (YY_INPUT): Update.
4956         (rewind_to_char): Update.
4957         * ada-exp.y (yyerror): Update.
4958
4959 2019-04-04  Tom Tromey  <tom@tromey.com>
4960
4961         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4962         * parser-defs.h (struct parser_state) <parser_state>: Add new
4963         parameter.
4964         <comma_terminates>: New member.
4965         (comma_terminates): Don't declare global.
4966         * parse.c (comma_terminates): Remove global.
4967         (parse_exp_in_context): Update.
4968         * p-exp.y (yylex): Update.
4969         * m2-exp.y (yylex): Update.
4970         * go-exp.y (lex_one_token): Update.
4971         * f-exp.y (yylex): Update.
4972         * d-exp.y (lex_one_token): Update.
4973         * c-exp.y (lex_one_token): Update.
4974         * ada-lex.l: Update.
4975
4976 2019-04-04  Tom Tromey  <tom@tromey.com>
4977
4978         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4979         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4980         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4981         * parser-defs.h (paren_depth): Don't declare.
4982         * parse.c (paren_depth): Remove global.
4983         (parse_exp_in_context): Update.
4984         * p-exp.y (paren_depth): New global.
4985         (pascal_parse): Initialize it.
4986         * m2-exp.y (paren_depth): New global.
4987         (m2_parse): Initialize it.
4988         * go-exp.y (paren_depth): New global.
4989         (go_parse): Initialize it.
4990         * f-exp.y (paren_depth): New global.
4991         (f_parse): Initialize it.
4992         * d-exp.y (paren_depth): New global.
4993         (d_parse): Initialize it.
4994         * c-exp.y (paren_depth): New global.
4995         (c_parse): Initialize it.
4996         * ada-lex.l (paren_depth): New global.
4997         (lexer_init): Initialize it.
4998
4999 2019-04-04  Tom Tromey  <tom@tromey.com>
5000
5001         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5002         (rust_parser::convert_ast_to_type)
5003         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5004         * parser-defs.h (struct parser_state) <parser_state>: Add
5005         parameters.  Initialize new members.
5006         <expression_context_block, expression_context_pc>: New members.
5007         * parse.c (expression_context_block, expression_context_pc):
5008         Remove globals.
5009         (parse_exp_in_context): Update.
5010         * p-exp.y: Update all rules.
5011         (yylex): Update.
5012         * m2-exp.y: Update all rules.
5013         (yylex): Update.
5014         * go-exp.y (yylex): Update.
5015         * f-exp.y (yylex): Update.
5016         * d-exp.y: Update all rules.
5017         (yylex): Update.
5018         * c-exp.y: Update all rules.
5019         (lex_one_token, classify_name, yylex, c_parse): Update.
5020         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5021
5022 2019-04-04  Tom Tromey  <tom@tromey.com>
5023
5024         * gdbarch.h, gdbarch.c: Rebuild.
5025         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5026         * stap-probe.h:
5027         (struct stap_parse_info): Replace "parser_state" with
5028         "expr_builder".
5029         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5030         (parser_state): New class.
5031         * parse.c (expr_builder): Rename.
5032         (expr_builder::release): Rename.
5033         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5034         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5035         (write_exp_elt_longcst, write_exp_elt_floatcst)
5036         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5037         (write_exp_string_vector, write_exp_bitstring)
5038         (write_exp_msymbol, mark_struct_expression)
5039         (write_dollar_variable)
5040         (insert_type_address_space, increase_expout_size): Replace
5041         "parser_state" with "expr_builder".
5042         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5043         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5044         "parser_state" with "expr_builder".
5045
5046 2019-04-04  Tom Tromey  <tom@tromey.com>
5047
5048         * rust-exp.y: Replace "parse_language" with method call.
5049         * p-exp.y:
5050         (yylex): Replace "parse_language" with method call.
5051         * m2-exp.y:
5052         (yylex): Replace "parse_language" with method call.
5053         * go-exp.y (classify_name): Replace "parse_language" with method
5054         call.
5055         * f-exp.y (yylex): Replace "parse_language" with method call.
5056         * d-exp.y (lex_one_token): Replace "parse_language" with method
5057         call.
5058         * c-exp.y:
5059         (lex_one_token, classify_name, yylex): Replace "parse_language"
5060         with method call.
5061         * ada-exp.y (find_primitive_type, type_char)
5062         (type_system_address): Replace "parse_language" with method call.
5063
5064 2019-04-04  Tom Tromey  <tom@tromey.com>
5065
5066         * rust-exp.y: Replace "parse_gdbarch" with method call.
5067         * parse.c (write_dollar_variable, insert_type_address_space):
5068         Replace "parse_gdbarch" with method call.
5069         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5070         call.
5071         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5072         call.
5073         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5074         "parse_gdbarch" with method call.
5075         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5076         with method call.
5077         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5078         "parse_gdbarch" with method call.
5079         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5080         "parse_gdbarch" with method call.
5081         * c-exp.y (parse_type, parse_number, classify_name): Replace
5082         "parse_gdbarch" with method call.
5083         * ada-lex.l: Replace "parse_gdbarch" with method call.
5084         * ada-exp.y (parse_type, find_primitive_type, type_char)
5085         (type_system_address): Replace "parse_gdbarch" with method call.
5086
5087 2019-04-04  Tom Tromey  <tom@tromey.com>
5088
5089         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5090         * stap-probe.c (stap_parse_argument): Update.
5091         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5092         initial_size parameter.
5093         * rust-exp.y (rust_lex_tests): Update.
5094         * parse.c (parser_state): Update.
5095         (parse_exp_in_context): Update.
5096         * parser-defs.h (struct parser_state) <parser_state>: Remove
5097         "initial_size" parameter.
5098
5099 2019-04-04  Tom Tromey  <tom@tromey.com>
5100
5101         * parser-defs.h (increase_expout_size): Don't declare.
5102         * parse.c (increase_expout_size): Now static.
5103
5104 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5105
5106         * gnu-nat.c (gnu_nat_target::wait): Fix
5107         target_waitstatus_to_string call.
5108
5109 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5110
5111         * eval.c (evaluate_subexp_standard): Handle internal functions
5112         during Fortran function call handling.
5113
5114 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5115
5116         * NEWS: Mention new internal functions.
5117         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5118         (read_base_type): Use dwarf2_init_complex_target_type.
5119         * value.c (creal_internal_fn): New function.
5120         (cimag_internal_fn): New function.
5121         (_initialize_values): Register new internal functions.
5122
5123 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5124
5125         * infrun.c (stop_all_threads): If debug_infrun, always
5126         trace the wait status after wait_one, using
5127         target_waitstatus_to_string and target_pid_to_str.
5128         (handle_inferior_event): Replace various trace of
5129         wait status kind by a single trace.
5130         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5131         wait status kind image by target_waitstatus_to_string.
5132         * target/waitstatus.c (target_waitstatus_to_string): Fix
5133         obsolete comment.
5134
5135 2019-04-01  Tom Tromey  <tromey@adacore.com>
5136
5137         PR symtab/23331:
5138         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5139
5140 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5141             Pedro Alves  <palves@redhat.com>
5142
5143         * top.c (quit_force): Call 'finalize_values'.
5144         * value.c (finalize_values): New function.
5145         * value.h (finalize_values): Declare.
5146
5147 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5148
5149         * NEWS: Announce $_gdb_major and $_gdb_minor.
5150
5151         * top.c (init_gdb_version_vars): New function.
5152         (gdb_init): Call init_gdb_version_vars.
5153
5154 2019-03-29  Tom Tromey  <tromey@adacore.com>
5155
5156         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5157         help text.  Remove dead code.
5158
5159 2019-03-29  Keith Seitz  <keiths@redhat.com>
5160
5161         From Siddhesh Poyarekar:
5162         * f-lang.h (f77_get_upperbound): Return LONGEST.
5163         (f77_get_lowerbound): Likewise.
5164         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5165         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5166         print them.
5167         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5168         plongest to format print it.
5169         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5170         (f77_get_upperbound): Likewise.
5171         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5172         LOWER_BOUND to LONGEST.
5173         (f77_create_arrayprint_offset_tbl): Likewise.
5174
5175 2019-03-29  Keith Seitz  <keiths@redhat.com>
5176
5177         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5178         %s/pulongest for TYPE_LENGTH instead of %d in format
5179         strings.
5180         * ada-typerint.c (ada_print_type): Likewise.
5181         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5182         * compile/compile-c-support.c (generate_register_struct): Likewise.
5183         * gdbtypes.c (recursive_dump_type): Likewise.
5184         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5185         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5186         instead of %d in format strings.
5187         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5188         to std::min to ULONGEST.
5189         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5190         instead of %d in format strings.
5191         * tracepoint.c (info_scope_command): Likewise.
5192         * typeprint.c (print_offset_data::update)
5193         (print_offset_data::finish): Likewise.
5194         * xtensa-tdep.c (xtensa_store_return_value)
5195         (xtensa_push_dummy_call): Likewise.
5196
5197 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5198
5199         * windows-nat.c (display_selector): Fixed format specifications
5200         for 64-bit Cygwin.
5201
5202 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5203
5204         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5205
5206 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5207
5208         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5209         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5210         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5211         (nios2_linux_init_abi): Install it.
5212
5213 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5214
5215         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5216
5217 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5218
5219         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5220
5221 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5222             Tom Tromey  <tromey@adacore.com>
5223
5224         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5225
5226 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5227
5228         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5229         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5230         method to compute the bounds of range types. Also print "[evaluated]"
5231         if the bounds' values come from a dynamic evaluation.
5232
5233 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5234
5235         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5236         whitespace when pretty printing is on.
5237
5238 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5239
5240         * ppc-linux-nat.c: Add include.
5241
5242 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5243
5244         * NEWS: Mention AArch64 Pointer Authentication.
5245
5246 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5247
5248         * arm-linux-nat.c: Add include.
5249
5250 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5251
5252         * source-cache.c (source_cache::get_source_lines): Re-read
5253         fullname after calling open_source_file.
5254
5255 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5256
5257         * NEWS: Mention TLS support for FreeBSD.
5258
5259 2019-03-25  Tom Tromey  <tromey@adacore.com>
5260
5261         * minsyms.c (BUNCH_SIZE): Update comment.
5262         (~minimal_symbol_reader): Remove old comment.
5263         (compact_minimal_symbols): Update comment.
5264         (minimal_symbol_reader::install): Remove old comment.  Update
5265         other comments.
5266
5267 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5268
5269         * s390-linux-nat.c: Add include.
5270
5271 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5272
5273         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5274         Call linux_get_hwcap.
5275         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5276         Likewise.
5277         (aarch64_linux_get_hwcap): Remove function.
5278         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5279         declaration.
5280         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5281         linux_get_hwcap.
5282         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5283         * linux-tdep.c (linux_get_hwcap): Add function.
5284         (linux_get_hwcap2): Likewise.
5285         * linux-tdep.h (linux_get_hwcap): Add declaration.
5286         (linux_get_hwcap2): Likewise.
5287         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5288         (ppc_linux_get_hwcap2): Likewise.
5289         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5290         linux_get_hwcap.
5291         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5292         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5293         (ppc_linux_nat_target::read_description): Likewise.
5294         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5295         * s390-linux-nat.c: Likewise.
5296         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5297
5298 2019-03-24  Tom Tromey  <tom@tromey.com>
5299
5300         * ada-lang.c (standard_lookup): Simplify initialization.
5301         (ada_lookup_symbol_nonlocal): Simplify return.
5302         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5303         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5304         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5305         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5306         initialization.
5307         * solib.c (solib_global_lookup): Simplify.
5308         * symtab.c (null_block_symbol): Remove.
5309         (symbol_cache_lookup): Simplify returns.
5310         (lookup_language_this): Simplify returns.
5311         (lookup_symbol_aux): Simplify return.
5312         (lookup_local_symbol): Simplify returns.
5313         (lookup_global_symbol_from_objfile): Simplify return.
5314         (lookup_symbol_in_objfile_symtabs)
5315         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5316         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5317         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5318         * cp-namespace.c (cp_lookup_bare_symbol)
5319         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5320         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5321         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5322         (cp_lookup_symbol_via_imports): Simplify initialization.
5323         (find_symbol_in_baseclass): Likewise.
5324         * symtab.h (null_block_symbol): Remove.
5325         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5326         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5327         (d_lookup_symbol_module): Likewise.
5328         (find_symbol_in_baseclass): Simplify initialization.
5329
5330 2019-03-24  Tom Tromey  <tom@tromey.com>
5331
5332         * expression.h: Don't include symtab.h.
5333         (struct block): Forward declare.
5334
5335 2019-03-24  Tom Tromey  <tom@tromey.com>
5336
5337         * c-exp.y (typebase): Remove casts.
5338         * gdbtypes.c (lookup_unsigned_typename, )
5339         (lookup_signed_typename): Remove cast.
5340         * eval.c (parse_to_comma_and_eval): Remove cast.
5341         * parse.c (write_dollar_variable): Remove cast.
5342         * block.h (struct block) <superblock>: Now const.
5343         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5344         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5345         (map_block): Make "block" const.
5346         * symfile.h (struct quick_symbol_functions)
5347         <map_matching_symbols>: Constify block argument to "callback".
5348         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5349         const.
5350         (find_pc_sect_compunit_symtab): Make "b" const.
5351         (find_symbol_at_address): Likewise.
5352         (search_symbols): Likewise.
5353         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5354         (dw2_debug_names_lookup_symbol): Likewise.
5355         (dw2_map_matching_symbols): Update.
5356         * p-valprint.c (pascal_val_print): Remove "block".
5357         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5358         (aux_add_nonlocal_symbols): Make "block" const.
5359         (resolve_subexp): Remove cast.
5360         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5361         const.
5362         (iterate_over_file_blocks): Likewise.
5363         * f-exp.y (%union) <bval>: Remove.
5364         * coffread.c (patch_opaque_types): Make "b" const.
5365         * spu-tdep.c (spu_catch_start): Make "block" const.
5366         * c-valprint.c (print_unpacked_pointer): Remove "block".
5367         * symmisc.c (dump_symtab_1): Make "b" const.
5368         (block_depth): Make "block" const.
5369         * d-exp.y (%union) <bval>: Remove.
5370         * cp-support.h (cp_lookup_rtti_type): Update.
5371         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5372         * psymtab.c (psym_lookup_symbol): Make "block" const.
5373         (maintenance_check_psymtabs): Make "b" const.
5374         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5375         (enumerate_locals, enumerate_args): Update.
5376         * python/py-symtab.c (stpy_global_block): Make "block" const.
5377         (stpy_static_block): Likewise.
5378         * inline-frame.c (block_starting_point_at): Make "new_block"
5379         const.
5380         * block.c (find_block_in_blockvector): Make return type const.
5381         (blockvector_for_pc_sect): Make "b" const.
5382         (find_block_in_blockvector): Make "b" const.
5383
5384 2019-03-23  Tom Tromey  <tom@tromey.com>
5385
5386         * varobj.c (varobj_create): Update.
5387         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5388         * printcmd.c (display_command, do_one_display): Don't reset
5389         innermost_block.
5390         * parser-defs.h (enum innermost_block_tracker_type): Move to
5391         expression.h.
5392         (innermost_block): Update comment.
5393         * parse.c (parse_exp_1): Add tracker_types parameter.
5394         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5395         tracker_types parameter.  Reset innermost_block.
5396         (parse_exp_in_context): Remove.
5397         (parse_expression_for_completion): Update.
5398         * objfiles.c (~objfile): Don't reset expression_context_block or
5399         innermost_block.
5400         * expression.h (enum innermost_block_tracker_type): Move from
5401         parser-defs.h.
5402         (parse_exp_1): Add tracker_types parameter.
5403         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5404         reset innermost_block.
5405
5406 2019-03-23  Tom Tromey  <tom@tromey.com>
5407
5408         * objfiles.h: Include bcache.h.
5409
5410 2019-03-23  Tom Tromey  <tom@tromey.com>
5411
5412         * linespec.c (get_current_search_block): Use
5413         scoped_restore_current_language.
5414         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5415
5416 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5417             Jiong Wang  <jiong.wang@arm.com>
5418
5419         * aarch64-linux-tdep.c
5420         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5421         section.
5422         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5423
5424 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5425             Jiong Wang  <jiong.wang@arm.com>
5426
5427         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5428         instructions.
5429         (aarch64_analyze_prologue_test): Add PACIASP test.
5430         (aarch64_prologue_prev_register): Unmask PC value.
5431
5432 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5433             Jiong Wang  <jiong.wang@arm.com>
5434
5435         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5436         (aarch64_dwarf2_prev_register): Unmask PC value.
5437         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5438         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5439         DW_CFA_AARCH64_negate_ra_state.
5440         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5441
5442 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5443             Jiong Wang  <jiong.wang@arm.com>
5444
5445         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5446         registers.
5447         (aarch64_pseudo_register_name): Likewise.
5448         (aarch64_pseudo_register_type): Likewise.
5449         (aarch64_pseudo_register_reggroup_p): Likewise.
5450         (aarch64_gdbarch_init): Add pauth registers.
5451         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5452         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5453         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5454         (struct gdbarch_tdep): Add regnum for ra_state.
5455
5456 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5457             Jiong Wang  <jiong.wang@arm.com>
5458
5459         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5460
5461 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5462             Jiong Wang  <jiong.wang@arm.com>
5463
5464         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5465         function.
5466         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5467         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5468         (aarch64_gdbarch_init): Add puth registers.
5469         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5470         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5471         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5472
5473 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5474             Jiong Wang  <jiong.wang@arm.com>
5475
5476         * aarch64-linux-nat.c
5477         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5478         * aarch64-linux-tdep.c
5479         (aarch64_linux_core_read_description): Likewise.
5480         (aarch64_linux_get_hwcap): New function.
5481         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5482         (aarch64_linux_get_hwcap): New declaration.
5483
5484 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5485             Jiong Wang  <jiong.wang@arm.com>
5486
5487         * aarch64-linux-nat.c
5488         (aarch64_linux_nat_target::read_description): Add pauth param.
5489         * aarch64-linux-tdep.c
5490         (aarch64_linux_core_read_description): Likewise.
5491         * aarch64-tdep.c (struct target_desc): Add in pauth.
5492         (aarch64_read_description): Add pauth param.
5493         (aarch64_gdbarch_init): Likewise.
5494         * aarch64-tdep.h (aarch64_read_description): Likewise.
5495         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5496         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5497         * features/Makefile: Add new files.
5498         * features/aarch64-pauth.c: New file.
5499         * features/aarch64-pauth.xml: New file.
5500
5501 2019-03-20  Tom Tromey  <tromey@adacore.com>
5502
5503         * infrun.c (handle_inferior_event): Rename from
5504         handle_inferior_event_1.  Create a scoped_value_mark.
5505         (handle_inferior_event): Remove.
5506
5507 2019-03-19  Tom Tromey  <tromey@adacore.com>
5508
5509         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5510         * infrun.h (print_stop_event): Add "displays" parameter.
5511         * infrun.c (print_stop_event): Add "displays" parameter.
5512
5513 2019-03-19  Pedro Alves  <palves@redhat.com>
5514
5515         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5516         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5517         to -1.  Fix TABs vs spaces.
5518         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5519         * tui/tui-out.h (tui_ui_out) Add intro comments.
5520         <m_line, m_start_of_line>: In-class initialize, and add describing
5521         comment.
5522
5523 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5524
5525         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5526         variable names.
5527         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5528
5529 2019-03-18  Pedro Alves  <palves@redhat.com>
5530             Eli Zaretskii <eliz@gnu.org>
5531
5532         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5533         m_line and m_start_of_line.
5534
5535 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5536
5537         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5538         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5539         it returns a newline.  This fixes a regression in TU mode, whereby
5540         the next line is output on the same screen line as the user input.
5541
5542 2019-03-18  Tom Tromey  <tromey@adacore.com>
5543
5544         * minsyms.c (minimal_symbol_reader::install): Remove call to
5545         obstack_blank.
5546
5547 2019-03-18  Pedro Alves  <palves@redhat.com>
5548
5549         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5550         New globals.
5551         (apply_style): New, factored out from ...
5552         (apply_ansi_escape): ... this.  Handle reverse video mode.
5553         (tui_set_reverse_mode): New function.
5554         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5555         * tui/tui-winsource.c (tui_show_source_line): Use
5556         tui_set_reverse_mode instead of setting A_STANDOUT.
5557         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5558         New setter methods.
5559
5560 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5561
5562         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5563         Handle tabs.
5564
5565 2019-03-18  Tom Tromey  <tromey@adacore.com>
5566
5567         * ada-lang.c (empty_array): Add "high" parameter.
5568         (ada_evaluate_subexp): Update.
5569
5570 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5571
5572         * unittests/string_view-selftests.c: Define
5573         _initialize_string_view_selftests unconditionally.
5574
5575 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5576
5577         PR gdb/24350
5578         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5579
5580 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5581
5582         PR gdb/24351
5583         * windows-nat.c (display_selector): Fix format specifiers.
5584
5585 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5586
5587         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5588         tui_refill_source_window instead of tui_refresh_win, to update the
5589         current execution line.  This fixes redisplay of the current line
5590         when stepping through the code with "next" or "step".
5591
5592 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5593
5594         * source-cache.c (source_cache::get_source_lines): Call
5595         find_source_lines to initialize s->nlines.  This fixes vertical
5596         scrolling of TUI source window when the DOWN arrow is pressed.
5597
5598 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5599
5600         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5601         linux-thread-db.c (_initialize_thread_db): Likewise.
5602
5603 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5604
5605         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5606         wclrtoeol in tui_show_source_line".  This reverts changes made in
5607         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5608
5609 2019-03-15  Tom Tromey  <tom@tromey.com>
5610
5611         * symtab.h (struct minimal_symbol): Derive from
5612         general_symbol_info.
5613         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5614         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5615         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5616         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5617         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5618         (MSYMBOL_SEARCH_NAME): Update.
5619         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5620         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5621         * minsyms.c (minimal_symbol_reader::record_full): Update.
5622
5623 2019-03-15  Tom Tromey  <tom@tromey.com>
5624
5625         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5626
5627 2019-03-15  Tom Tromey  <tom@tromey.com>
5628
5629         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5630         unique_xmalloc_ptr.
5631         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5632         Update.
5633         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5634         (build_minimal_symbol_hash_tables)
5635         (minimal_symbol_reader::install): Update.
5636
5637 2019-03-15  Tom Tromey  <tom@tromey.com>
5638
5639         * symtab.c (create_demangled_names_hash): Update.
5640         (symbol_set_names): Update.
5641         * objfiles.h (struct objfile_per_bfd_storage)
5642         <demangled_names_hash>: Now an htab_up.
5643         * objfiles.c (objfile_per_bfd_storage): Simplify.
5644
5645 2019-03-15  Tom Tromey  <tom@tromey.com>
5646
5647         * objfiles.h (struct objfile_per_bfd_storage): Declare
5648         destructor.
5649         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5650         New.
5651         (get_objfile_bfd_data): Use new.  Don't initialize
5652         language_of_main.
5653         (free_objfile_per_bfd_storage): Remove.
5654         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5655
5656 2019-03-15  Tom Tromey  <tom@tromey.com>
5657
5658         * symfile.c (reread_symbols): Update.
5659         * objfiles.c (objfile::objfile): Update.
5660         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5661         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5662         comment.
5663         (minimal_symbol_reader::install): Update.
5664         (terminate_minimal_symbol_table): Remove.
5665         * jit.c (jit_object_close_impl): Update.
5666
5667 2019-03-15  Tom Tromey  <tom@tromey.com>
5668
5669         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5670         initializations.
5671
5672 2019-03-15  Tom Tromey  <tom@tromey.com>
5673
5674         * objfiles.h (struct objfile_per_bfd_storage)
5675         <demangled_hash_languages>: Now a bitset.
5676         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5677         (lookup_minimal_symbol): Update.
5678
5679 2019-03-15  Tom Tromey  <tom@tromey.com>
5680
5681         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5682         Don't return the symbol.
5683         * coffread.c (record_minimal_symbol): Use record_full.
5684
5685 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5686
5687         The MS-Windows port of ncurses fails to switch to a color pair if
5688         one or both of the colors are the implicit default colors.  This
5689         change records the default colors when TUI is initialized, and
5690         then specifies them explicitly when a color pair uses the default
5691         colors.  This allows color styling in TUI mode on MS-Windows.
5692
5693         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5694         ncurses_norm_attr.
5695         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5696         colors in ncurses_norm_attr.
5697         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5698         "none", replace it with the default color recorded in
5699         ncurses_norm_attr.
5700
5701 2019-03-14  Tom Tromey  <tromey@adacore.com>
5702
5703         * source-cache.h (class source_cache) <get_source_lines>: Return
5704         std::string.
5705         * source-cache.c (source_cache::extract_lines): Handle case where
5706         first_pos==npos.  Return std::string.
5707         (source_cache::get_source_lines): Update.
5708
5709 2019-03-14  Tom Tromey  <tromey@adacore.com>
5710
5711         * NEWS: Add item for "style sources" commands.
5712         * source-cache.c (source_cache::get_source_lines): Check
5713         source_styling.
5714         * cli/cli-style.c (source_styling): New global.
5715         (_initialize_cli_style): Add "style sources" commands.
5716         (show_style_sources): New function.
5717         * cli/cli-style.h (source_styling): Declare.
5718
5719 2019-03-14  Pedro Alves  <palves@redhat.com>
5720             Tom Tromey  <tromey@adacore.com>
5721
5722         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5723         * tui/tui-winsource.c (tui_refill_source_window): New function,
5724         from...
5725         (tui_horizontal_source_scroll): ... here.  Move some logic.
5726         * cli/cli-style.c (set_style_enabled): Notify new observable.
5727         * tui/tui-hooks.c (tui_redisplay_source): New function.
5728         (tui_attach_detach_observers): Attach or detach
5729         tui_redisplay_source.
5730         * observable.h (source_styling_changed): New observable.
5731         * observable.c: Define source_styling_changed observable.
5732
5733 2019-03-13  Tom Tromey  <tromey@adacore.com>
5734
5735         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5736         (i386_gnu_nat_target::store_registers): Update.
5737         * target-debug.h (target_debug_print_std_string): New macro.
5738         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5739         * windows-tdep.c (display_one_tib): Update.
5740         * tui/tui-stack.c (tui_make_status_line): Update.
5741         * top.c (print_inferior_quit_action): Update.
5742         * thread.c (thr_try_catch_cmd): Update.
5743         (add_thread_with_info): Update.
5744         (thread_target_id_str): Update.
5745         (thr_try_catch_cmd): Update.
5746         (thread_command): Update.
5747         (thread_find_command): Update.
5748         * record-btrace.c (record_btrace_target::info_record)
5749         (record_btrace_resume_thread, record_btrace_target::resume)
5750         (record_btrace_cancel_resume, record_btrace_step_thread)
5751         (record_btrace_target::wait, record_btrace_target::wait)
5752         (record_btrace_target::wait, record_btrace_target::stop): Update.
5753         * progspace.c (print_program_space): Update.
5754         * process-stratum-target.c
5755         (process_stratum_target::thread_address_space): Update.
5756         * linux-fork.c (linux_fork_mourn_inferior)
5757         (detach_checkpoint_command, info_checkpoints_command)
5758         (linux_fork_context): Update.
5759         (linux_fork_detach): Update.
5760         (class scoped_switch_fork_info): Update.
5761         (delete_checkpoint_command): Update.
5762         * infrun.c (follow_fork_inferior): Update.
5763         (follow_fork_inferior): Update.
5764         (proceed_after_vfork_done): Update.
5765         (handle_vfork_child_exec_or_exit): Update.
5766         (follow_exec): Update.
5767         (displaced_step_prepare_throw): Update.
5768         (displaced_step_restore): Update.
5769         (start_step_over): Update.
5770         (resume_1): Update.
5771         (clear_proceed_status_thread): Update.
5772         (proceed): Update.
5773         (print_target_wait_results): Update.
5774         (do_target_wait): Update.
5775         (context_switch): Update.
5776         (stop_all_threads): Update.
5777         (restart_threads): Update.
5778         (finish_step_over): Update.
5779         (handle_signal_stop): Update.
5780         (switch_back_to_stepped_thread): Update.
5781         (keep_going_pass_signal): Update.
5782         (print_exited_reason): Update.
5783         (normal_stop): Update.
5784         * inferior.c (inferior_pid_to_str): Change return type.
5785         (print_selected_inferior): Update.
5786         (add_inferior): Update.
5787         (detach_inferior): Update.
5788         * dummy-frame.c (fprint_dummy_frames): Update.
5789         * dcache.c (dcache_info_1): Update.
5790         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5791         (btrace_fetch, btrace_clear): Update.
5792         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5793         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5794         type.
5795         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5796         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5797         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5798         * gdbarch.c, gdbarch.h: Rebuild.
5799         * gdbarch.sh (core_pid_to_str): Change return type.
5800         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5801         return type.
5802         (windows_nat_target::pid_to_str): Change return type.
5803         (windows_delete_thread): Update.
5804         (windows_nat_target::attach): Update.
5805         (windows_nat_target::files_info): Update.
5806         * target-delegates.c: Rebuild.
5807         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5808         return type.
5809         (sol_thread_target::pid_to_str): Change return type.
5810         * remote.c (class remote_target) <pid_to_str>: Change return
5811         type.
5812         (remote_target::pid_to_str): Change return type.
5813         (extended_remote_target::attach, remote_target::remote_stop_ns)
5814         (remote_target::remote_notif_remove_queued_reply)
5815         (remote_target::push_stop_reply, remote_target::disable_btrace):
5816         Update.
5817         (extended_remote_target::attach): Update.
5818         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5819         type.
5820         (gdbsim_target::pid_to_str): Change return type.
5821         * ravenscar-thread.c (struct ravenscar_thread_target)
5822         <pid_to_str>: Change return type.
5823         (ravenscar_thread_target::pid_to_str): Change return type.
5824         * procfs.c (class procfs_target) <pid_to_str>: Change return
5825         type.
5826         (procfs_target::pid_to_str): Change return type.
5827         (procfs_target::attach): Update.
5828         (procfs_target::detach): Update.
5829         (procfs_target::fetch_registers): Update.
5830         (procfs_target::store_registers): Update.
5831         (procfs_target::wait): Update.
5832         (procfs_target::files_info): Update.
5833         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5834         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5835         return type.
5836         (nto_procfs_target::pid_to_str): Change return type.
5837         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5838         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5839         return type.
5840         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5841         (exit_lwp): Update.
5842         (attach_proc_task_lwp_callback, get_detach_signal)
5843         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5844         (linux_nat_target::resume, wait_lwp, stop_callback)
5845         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5846         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5847         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5848         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5849         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5850         type.
5851         (inf_ptrace_target::attach): Update.
5852         (inf_ptrace_target::files_info): Update.
5853         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5854         type.
5855         (go32_nat_target::pid_to_str): Change return type.
5856         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5857         (gnu_nat_target::wait): Update.
5858         (gnu_nat_target::wait): Update.
5859         (gnu_nat_target::resume): Update.
5860         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5861         (fbsd_nat_target::wait): Update.
5862         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5863         type.
5864         (darwin_nat_target::attach): Update.
5865         * corelow.c (class core_target) <pid_to_str>: Change return type.
5866         (core_target::pid_to_str): Change return type.
5867         * target.c (normal_pid_to_str): Change return type.
5868         (default_pid_to_str): Likewise.
5869         (target_pid_to_str): Change return type.
5870         (target_translate_tls_address): Update.
5871         (target_announce_detach): Update.
5872         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5873         return type.
5874         (bsd_uthread_target::pid_to_str): Change return type.
5875         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5876         type.
5877         (bsd_kvm_target::pid_to_str): Change return type.
5878         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5879         return type.
5880         (aix_thread_target::pid_to_str): Change return type.
5881         * target.h (struct target_ops) <pid_to_str>: Change return type.
5882         (target_pid_to_str, normal_pid_to_str): Likewise.
5883         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5884         type.
5885         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5886         type.
5887         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5888         return type.
5889         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5890         type.
5891         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5892         type.
5893         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5894         return type.
5895
5896 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5897
5898         * NEWS: Mention that the new default MI version is 3.  Mention
5899         changes to the output of commands and events that deal with
5900         multi-location breakpoints.
5901         * breakpoint.c: Include "mi/mi-out.h".
5902         (print_one_breakpoint): Change output syntax if using MI version
5903         >= 3.
5904         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5905         New.
5906         (mi_multi_location_breakpoint_output_fixed): New.
5907         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5908         (mi_cmd_fix_multi_location_breakpoint_output): New.
5909         (mi_multi_location_breakpoint_output_fixed): New.
5910         * mi/mi-cmds.c (mi_cmds): Register command
5911         -fix-multi-location-breakpoint-output.
5912         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5913         interpreter "mi".
5914
5915 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5916
5917         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5918         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5919         instantiate mi_ui_out based on interpreter name.
5920         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5921         * mi/mi-main.c (mi_load_progress): Likewise.
5922
5923 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5924
5925         * NEWS: Combine separate "New targets" sections for 8.3.
5926
5927 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5928
5929         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5930         (ppcfbsd_init_abi): Install gdbarch
5931         "fetch_tls_load_module_address" and "get_thread_local_address"
5932         methods.
5933
5934 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5935
5936         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5937         (riscv_fbsd_init_abi): Install gdbarch
5938         "fetch_tls_load_module_address" and "get_thread_local_address"
5939         methods.
5940
5941 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5942
5943         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5944         (i386fbsd_init_abi): Install gdbarch
5945         "fetch_tls_load_module_address" and "get_thread_local_address"
5946         methods.
5947
5948 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5949
5950         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5951         (amd64fbsd_init_abi): Install gdbarch
5952         "fetch_tls_load_module_address" and "get_thread_local_address"
5953         methods.
5954
5955 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5956
5957         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5958         (struct fbsd_pspace_data): New type.
5959         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5960         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5961         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5962         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5963         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5964
5965 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5966
5967         * gdbtypes.c (lookup_struct_elt): New function.
5968         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5969         * gdbtypes.h (struct struct_elt): New type.
5970         (lookup_struct_elt): New prototype.
5971
5972 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5973
5974         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5975         remove disabled code block.
5976
5977 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5978
5979         * gdbarch.sh (get_thread_local_address): New method.
5980         * gdbarch.h, gdbarch.c: Regenerate.
5981         * target.c (target_translate_tls_address): Use
5982         gdbarch_get_thread_local_address if present instead of
5983         target::get_thread_local_address.
5984
5985 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5986
5987         * target.h (target::get_thread_local_address): Update comment.
5988
5989 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5990
5991         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5992         objfile->separate_debug_objfile_backlink if not NULL.
5993
5994 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5995
5996         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5997         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5998         (amd64bsd_store_inferior_registers): Likewise.
5999         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6000         Enable segment base registers.
6001         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6002         PT_GETFSBASE and PT_GETGSBASE.
6003         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6004         PT_SETGSBASE.
6005         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6006         segment base registers.
6007         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6008
6009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6010
6011         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6012         Update calls to i386_target_description to add 'segments'
6013         parameter.
6014         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6015         add segment base registers.
6016         * arch/i386.c (i386_create_target_description): Add 'segments'
6017         parameter to enable segment base registers.
6018         * arch/i386.h (i386_create_target_description): Likewise.
6019         * features/i386/32bit-segments.xml: New file.
6020         * features/i386/32bit-segments.c: Generate.
6021         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6022         call to i386_target_description to add 'segments' parameter.
6023         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6024         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6025         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6026         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6027         if feature is present.
6028         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6029         Add 'segments' parameter to call to i386_target_description.
6030         (i386_target_description): Add 'segments' parameter to enable
6031         segment base registers.
6032         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6033         to call to i386_target_description.
6034         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6035         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6036         Define I386_NUM_REGS.
6037         (i386_target_description): Add 'segments' parameter to enable
6038         segment base registers.
6039
6040 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6041
6042         PR/24325
6043         * source-cache.c: #undef open and close, to avoid unresolved
6044         externals during linking.
6045
6046 2019-03-12  Tom Tromey  <tromey@adacore.com>
6047
6048         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6049         const.  Add initializers.
6050         (_initialize_remote): Don't initialize ptid globals.
6051
6052 2019-03-12  Pedro Alves  <palves@redhat.com>
6053
6054         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6055
6056 2019-03-12  Pedro Alves  <palves@redhat.com>
6057
6058         * cp-name-parser.y (main): Remove unused 'len' variable.
6059
6060 2019-03-12  Tom Tromey  <tromey@adacore.com>
6061
6062         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6063         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6064
6065 2019-03-12  Tom Tromey  <tromey@adacore.com>
6066
6067         * linux-nat.c (iterate_over_lwps): Update.
6068         (stop_callback): Remove parameter.
6069         (stop_wait_callback, detach_callback, resume_set_callback)
6070         (select_singlestep_lwp_callback, set_ignore_sigint)
6071         (status_callback, resumed_callback, resume_clear_callback)
6072         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6073         data parameter.
6074         (linux_nat_target::detach, linux_nat_target::resume)
6075         (linux_stop_and_wait_all_lwps, select_event_lwp)
6076         (linux_nat_filter_event, linux_nat_wait_1)
6077         (linux_nat_target::kill, linux_nat_target::stop)
6078         (linux_nat_target::stop): Update.
6079         (linux_nat_resume_callback): Change type.
6080         (resume_stopped_resumed_lwps, count_events_callback)
6081         (select_event_lwp_callback): Likewise.
6082         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6083         * arm-linux-nat.c (struct update_registers_data): Remove.
6084         (update_registers_callback): Change type.
6085         (arm_linux_insert_hw_breakpoint1): Update.
6086         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6087         parameter.
6088         (x86_linux_dr_set_addr): Update.
6089         (x86_linux_dr_set_control): Update.
6090         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6091         (iterate_over_lwps): Use gdb::function_view.
6092         * nat/aarch64-linux-hw-point.c (struct
6093         aarch64_dr_update_callback_param): Remove.
6094         (debug_reg_change_callback): Change type.
6095         (aarch64_notify_debug_reg_change): Update.
6096         * s390-linux-nat.c (s390_refresh_per_info): Update.
6097
6098 2019-03-11  Tom Tromey  <tromey@adacore.com>
6099
6100         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6101         redundant assignment to "this_cu".
6102
6103 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6104
6105         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6106
6107 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6108
6109         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6110         from...
6111         (rank_one_type): ... this.
6112
6113 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6114
6115         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6116         from...
6117         (rank_one_type): ... this.
6118
6119 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6120
6121         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6122         from...
6123         (rank_one_type): ... this.
6124
6125 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6126
6127         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6128         from...
6129         (rank_one_type): ... this.
6130
6131 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6132
6133         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6134         from...
6135         (rank_one_type): ... this.
6136
6137 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6138
6139         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6140         from...
6141         (rank_one_type): ... this.
6142
6143 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6144
6145         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6146         from...
6147         (rank_one_type): ... this.
6148
6149 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6150
6151         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6152         from...
6153         (rank_one_type): ... this.
6154
6155 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6156
6157         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6158         from...
6159         (rank_one_type): ... this.
6160
6161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6162
6163         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6164         from...
6165         (rank_one_type): ... this.
6166
6167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6168
6169         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6170         from...
6171         (rank_one_type): ... this.
6172
6173 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6174
6175         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6176         from...
6177         (rank_one_type): ... this.
6178
6179 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6180
6181         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6182         inferior-events' shows the example events.
6183
6184 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6185
6186         Support styling on native MS-Windows console
6187
6188         PR/24315
6189         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6190         on MS-Windows if $TERM is not defined.
6191
6192         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6193
6194         * posix-hdep.c (gdb_console_fputs):
6195         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6196         functions.
6197         * ui-file.h (gdb_console_fputs): Add prototype.
6198
6199         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6200         back to fputs only if the former returns zero.
6201
6202 2019-03-07  Tom Tromey  <tom@tromey.com>
6203
6204         * symmisc.c (print_symbol_bcache_statistics): Update.
6205         (print_objfile_statistics): Update.
6206         * symfile.c (allocate_symtab): Update.
6207         * stabsread.c: Don't include bcache.h.
6208         * psymtab.h (struct psymbol_bcache): Don't declare.
6209         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6210         (psymbol_bcache_init, psymbol_bcache_free)
6211         (psymbol_bcache_get_bcache): Don't declare.
6212         * psymtab.c (struct psymbol_bcache): Remove.
6213         (psymtab_storage::psymtab_storage): Update.
6214         (psymtab_storage::~psymtab_storage): Update.
6215         (psymbol_bcache_init, psymbol_bcache_free)
6216         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6217         (add_psymbol_to_bcache): Update.
6218         (allocate_psymtab): Update.
6219         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6220         macro_cache>: No longer pointers.
6221         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6222         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6223         * macrotab.c (macro_bcache): Update.
6224         * macroexp.c: Don't include bcache.h.
6225         * gdbtypes.c (check_types_worklist): Update.
6226         (types_deeply_equal): Remove TRY/CATCH.  Update.
6227         * elfread.c (elf_symtab_read): Update.
6228         * dwarf2read.c: Don't include bcache.h.
6229         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6230         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6231         (print_bcache_statistics, bcache_memory_used): Don't declare.
6232         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6233         methods.  Rename all data members.
6234         * bcache.c (struct bcache): Move to bcache.h.
6235         (bcache::expand_hash_table): Rename from expand_hash_table.
6236         (bcache): Remove.
6237         (bcache::insert): Rename from bcache_full.
6238         (bcache::compare): Rename from bcache_compare.
6239         (bcache_xmalloc): Remove.
6240         (bcache::~bcache): Rename from bcache_xfree.
6241         (bcache::print_statistics): Rename from print_bcache_statistics.
6242         (bcache::memory_used): Rename from bcache_memory_used.
6243
6244 2019-03-07  Pedro Alves  <palves@redhat.com>
6245
6246         * infrun.c (normal_stop): Also check for
6247         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6248
6249 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6250
6251         * f-lang.c (value_from_host_double): Moved to...
6252         * value.c (value_from_host_double): ...here.
6253         * value.h (value_from_host_double): Declare.
6254         * guile/scm-math.c (vlscm_convert_typed_number): Use
6255         value_from_host_double.
6256         (vlscm_convert_number): Likewise.
6257         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6258         * python/py-value.c (convert_value_from_python): Likewise.
6259
6260 2019-03-06  Tom Tromey  <tom@tromey.com>
6261
6262         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6263
6264 2019-03-06  Tom Tromey  <tom@tromey.com>
6265
6266         * utils.h (free_current_contents): Don't declare.
6267         * utils.c (free_current_contents): Remove.
6268
6269 2019-03-06  Tom Tromey  <tom@tromey.com>
6270
6271         * top.c (quit_force): Update.
6272         * main.c (captured_command_loop): Update.
6273         * common/new-op.c (operator new): Update.
6274         * common/common-exceptions.c (struct catcher)
6275         <save_cleanup_chain>: Remove member.
6276         (exceptions_state_mc_init): Update.
6277         (exception_try_scope_entry): Return nullptr.
6278         (exception_try_scope_exit, exception_rethrow)
6279         (throw_exception_sjlj, throw_exception_cxx): Update.
6280         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6281         (all_cleanups, do_cleanups, discard_cleanups)
6282         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6283         (restore_cleanups, restore_final_cleanups): Don't declare.
6284         (do_final_cleanups): Remove parameter.
6285         * common/cleanups.c (cleanup_chain, make_cleanup)
6286         (make_cleanup_dtor, all_cleanups, do_cleanups)
6287         (discard_my_cleanups, discard_cleanups)
6288         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6289         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6290         (null_cleanup): Remove.
6291         (do_final_cleanups): Remove parameter.
6292
6293 2019-03-06  Tom Tromey  <tom@tromey.com>
6294
6295         * remote.c (remote_target::remote_parse_stop_reply): Use
6296         unique_xmalloc_ptr.
6297
6298 2019-03-06  Tom Tromey  <tom@tromey.com>
6299
6300         * stabsread.c (struct stabs_field_info): Rename from field_info.
6301         <list, fnlist>: Add initializers.
6302         <obstack>: New member.
6303         (read_member_functions, read_struct_fields, read_baseclasses):
6304         Allocate on obstack.  Don't use cleanups.
6305         (read_one_struct_field, read_member_functions, read_struct_fields)
6306         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6307         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6308         (read_struct_type): Update.
6309
6310 2019-03-06  Tom Tromey  <tom@tromey.com>
6311
6312         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6313         * common/filestuff.h (make_cleanup_close): Don't declare.
6314         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6315         Remove.
6316
6317 2019-03-06  Tom Tromey  <tom@tromey.com>
6318
6319         * solib-aix.c: Use make_scope_exit.
6320
6321 2019-03-06  Tom Tromey  <tom@tromey.com>
6322
6323         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6324         Use make_scope_exit.
6325
6326 2019-03-06  Tom Tromey  <tom@tromey.com>
6327
6328         * solib-svr4.c (disable_probes_interface): Remove parameter.
6329         (svr4_handle_solib_event): Use make_scope_exit.
6330
6331 2019-03-06  Tom Tromey  <tom@tromey.com>
6332
6333         * remote.c (struct stop_reply_deleter): Remove.
6334         (stop_reply_up): Update.
6335         (struct stop_reply): Derive from notif_event.  Don't typedef.
6336         <regcache>: Now a std::vector.
6337         (stop_reply_xfree): Remove.
6338         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6339         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6340         (remote_target::discard_pending_stop_replies): Use delete.
6341         (remote_target::remote_parse_stop_reply): Update.
6342         (remote_target::process_stop_reply): Update.
6343         * remote-notif.h (struct notif_event): Add virtual destructor.
6344         Remove "dtr" member.
6345         (struct notif_client) <alloc_event>: Return a unique_ptr.
6346         (notif_event_xfree): Don't declare.
6347         (notif_event_up): New typedef.
6348         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6349         (notif_event_xfree, do_notif_event_xfree): Remove.
6350         (remote_notif_state_xfree): Update.
6351
6352 2019-03-06  Tom Tromey  <tom@tromey.com>
6353
6354         * infrun.c (displaced_step_clear_cleanup): Now a
6355         forward_scope_exit type.
6356         (displaced_step_prepare_throw): Update.
6357         (displaced_step_fixup): Update.
6358
6359 2019-03-06  Tom Tromey  <tom@tromey.com>
6360
6361         * inferior.h (class inferior): Update comment.
6362         * gdbthread.h (class thread_info): Update comment.
6363
6364 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6365             Tom Tromey  <tom@tromey.com>
6366
6367         * stabsread.h (struct stab_section_list): Remove.
6368         (coffstab_build_psymtabs): Update.
6369         * dbxread.c (symbuf_sections): Now a std::vector.
6370         (sect_idx): New global.
6371         (fill_symbuf): Update.
6372         (coffstab_build_psymtabs): Change type of stabsects parameter.
6373         Update.
6374         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6375         std::vector.
6376         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6377         (coff_locate_sections): Update.
6378         (coff_symfile_read): Remove cleanups.  Update.
6379         (init_stringtab): Add storage parameter.
6380         (free_stringtab, free_stringtab_cleanup): Remove.
6381         (init_lineno): Add storage parameter.
6382         (free_linetab, free_linetab_cleanup): Remove.
6383
6384 2019-03-06  Pedro Alves  <palves@redhat.com>
6385
6386         * linux-fork.c (fork_info::clobber_regs): Delete.
6387         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6388         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6389         comment.  Adjust.
6390         (scoped_switch_fork_info::scoped_switch_fork_info)
6391         (checkpoint_command, linux_fork_context): Adjust
6392         fork_save_infrun_state calls.
6393
6394 2019-03-06  Pedro Alves  <palves@redhat.com>
6395
6396         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6397         (inf_has_multiple_threads): Return 'bool' and rewrite using
6398         inferior_info::threads().
6399
6400 2019-03-06  Pedro Alves  <palves@redhat.com>
6401
6402         * linux-fork.c: Include <list>.
6403         (fork_list): Now a std::list instance.
6404         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6405         (forks_exist_p, find_last_fork): Adjust.
6406         (new_fork): Delete.
6407         (one_fork_p): New.
6408         (add_fork): Adjust.
6409         (free_fork): Delete, folded into fork_info::~fork_info().
6410         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6411         Adjust.
6412         (init_fork_list): Delete.
6413         (linux_fork_killall, linux_fork_mourn_inferior)
6414         (linux_fork_detach, info_checkpoints_command): Adjust.
6415         (_initialize_linux_fork): No longer call init_fork_list.
6416
6417 2019-03-06  Pedro Alves  <palves@redhat.com>
6418
6419         * linux-fork.c (new_fork): New, split out of ...
6420         (add_fork): ... this.  Return void.  Move "first fork" special
6421         case from here, to ...
6422         (checkpoint_command): ... here.
6423         * linux-linux.h (add_fork): Return void.
6424
6425 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6426
6427         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6428
6429 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6430             Chris January  <chris.january@arm.com>
6431             David Lecomber  <david.lecomber@arm.com>
6432
6433         * f-exp.y: New token, UNOP_INTRINSIC.
6434         (exp): New pattern using UNOP_INTRINSIC token.
6435         (f77_keywords): Add 'abs' keyword.
6436         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6437         (value_from_host_double): New function.
6438         (evaluate_subexp_f): Support UNOP_ABS.
6439
6440 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6441
6442         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6443         types.
6444
6445 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6446
6447         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6448         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6449         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6450
6451 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6452
6453         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6454
6455 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6456             Chris January  <chris.january@arm.com>
6457
6458         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6459         * f-exp.y: Define 'KIND' token.
6460         (exp): New pattern for KIND expressions.
6461         (ptype): Handle types with a kind extension.
6462         (direct_abs_decl): Extend to spot kind extensions.
6463         (f77_keywords): Add 'kind' to the list.
6464         (push_kind_type): New function.
6465         (convert_to_kind_type): New function.
6466         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6467         * parse.c (operator_length_standard): Likewise.
6468         * parser-defs.h (enum type_pieces): Add tp_kind.
6469         * std-operator.def: Add UNOP_KIND.
6470
6471 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6472
6473         * f-exp.y (f_parse): Set yydebug.
6474
6475 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6476
6477         * f-lang.c (evaluate_subexp_f): New function.
6478         (exp_descriptor_f): New global.
6479         (f_language_defn): Use exp_descriptor_f instead of
6480         exp_descriptor_standard.
6481
6482 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6483
6484         * f-exp.y (struct token): Add comments.
6485         (dot_ops): Remove uppercase versions and the end marker.
6486         (f77_keywords): Likewise.
6487         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6488         entries in the dot_ops array are case insensitive, and use
6489         strncasecmp to compare strings.  Also some whitespace cleanup in
6490         this area.  Similar for the f77_keywords array, except entries in
6491         this list might be case sensitive.
6492
6493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6494
6495         * f-exp.y (struct f77_boolean_val): Add comments.
6496         (boolean_values): Remove uppercase versions, and end marker.
6497         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6498         and use strncasecmp to achieve case insensitivity.  Additionally,
6499         perform whitespace cleanup around this code.
6500
6501 2019-03-06  Tom Tromey  <tromey@adacore.com>
6502
6503         * remote-sim.c (gdbsim_target_open): Use result of
6504         gdb_argv::release.
6505
6506 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6507         Dirk Schubert  <dirk.schubert@arm.com>
6508         Chris January  <chris.january@arm.com>
6509
6510         * eval.c (evaluate_subexp_standard): Call Fortran argument
6511         wrapping logic.
6512         * f-lang.c (struct value): A value which can be passed into a
6513         Fortran function call.
6514         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6515         where appropriate.
6516         (struct type): Value ready for a Fortran function call.
6517         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6518         is needed.
6519         * f-lang.h (fortran_argument_convert): Declaration.
6520         (fortran_preserve_arg_pointer): Declaration.
6521         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6522
6523 2019-03-05  Tom Tromey  <tromey@adacore.com>
6524
6525         * python/py-prettyprint.c (print_string_repr): Remove #if.
6526         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6527
6528 2019-03-05  Tom Tromey  <tromey@adacore.com>
6529
6530         * target.c (the_dummy_target): Move later.  Change type to
6531         "dummy_target".
6532         (initialize_targets): Don't initialize the_dummy_target.
6533
6534 2019-03-05  Tom Tromey  <tromey@adacore.com>
6535
6536         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6537         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6538
6539 2019-03-05  Tom Tromey  <tromey@adacore.com>
6540
6541         * windows-nat.c (windows_nat_target::attach)
6542         (windows_nat_target::detach): Don't call gdb_flush.
6543         * valprint.c (generic_val_print, val_print, val_print_string):
6544         Don't call gdb_flush.
6545         * utils.c (defaulted_query): Don't call gdb_flush.
6546         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6547         * target.c (target_announce_detach): Don't call gdb_flush.
6548         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6549         * remote.c (extended_remote_target::attach): Don't call
6550         gdb_flush.
6551         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6552         * printcmd.c (do_examine): Don't call gdb_flush.
6553         (info_display_command): Don't call gdb_flush.
6554         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6555         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6556         * memattr.c (info_mem_command): Don't call gdb_flush.
6557         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6558         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6559         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6560         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6561         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6562         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6563         (gnu_nat_target::detach): Don't call gdb_flush.
6564         * f-valprint.c (f_val_print): Don't call gdb_flush.
6565         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6566         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6567         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6568         gdb_flush.
6569         * c-valprint.c (c_val_print): Don't call gdb_flush.
6570         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6571
6572 2019-03-05  Tom Tromey  <tromey@adacore.com>
6573
6574         * varobj.c (update_dynamic_varobj_children): Update.
6575         (install_default_visualizer): Use reset, not release.
6576         * value.c (set_internalvar): Update.
6577         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6578         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6579         ATTRIBUTE_UNUSED_RESULT.
6580
6581 2019-03-05  Tom Tromey  <tromey@adacore.com>
6582
6583         * remote.c (class scoped_remote_fd) <release>: Add
6584         ATTRIBUTE_UNUSED_RESULT.
6585
6586 2019-03-05  Tom Tromey  <tromey@adacore.com>
6587
6588         * macroexp.c (struct macro_buffer) <release>: Add
6589         ATTRIBUTE_UNUSED_RESULT.
6590
6591 2019-03-05  Tom Tromey  <tromey@adacore.com>
6592
6593         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6594         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6595         ATTRIBUTE_UNUSED_RESULT.
6596
6597 2019-03-05  Tom Tromey  <tromey@adacore.com>
6598
6599         * common/scoped_fd.h (class scoped_fd) <release>: Add
6600         ATTRIBUTE_UNUSED_RESULT.
6601
6602 2019-03-05  Tom Tromey  <tromey@adacore.com>
6603
6604         * parser-defs.h (struct parser_state) <release>: Add
6605         ATTRIBUTE_UNUSED_RESULT.
6606
6607 2019-03-05  Tom Tromey  <tromey@adacore.com>
6608
6609         * utils.h (class gdb_argv) <release>: Add
6610         ATTRIBUTE_UNUSED_RESULT.
6611         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6612
6613 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6614
6615         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6616         for-loop range, to avoid compiler warnings.
6617
6618         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6619         avoid compiler warnings about unused variables.
6620
6621         * NEWS: Mention end of support for native debugging on MS-Windows
6622         before XP.
6623
6624         PR gdb/24292
6625         * common/netstuff.c:
6626         * gdbserver/gdbreplay.c
6627         * gdbserver/remote-utils.c:
6628         * ser-tcp.c:
6629         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6630         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6631         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6632         'getaddrinfo' and 'freeaddrinfo' were not available before
6633         Windows XP, and mingw.org's MinGW headers by default define
6634         _WIN32_WINNT to 0x500.
6635
6636 2019-03-01  Gary Benson <gbenson@redhat.com>
6637
6638         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6639
6640 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6641             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6642
6643         PR gdb/8527
6644         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6645         set_sigint_trap, clear_sigint_trap.
6646
6647 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6648
6649         * target.c (target_detach): Clear the regcache and the
6650         frame cache.
6651
6652 2019-02-27  Pedro Alves  <palves@redhat.com>
6653
6654         * utils.c (set_screen_size): When we cap the height/width sizes,
6655         tweak the corresponding command variable to show "unlimited":
6656
6657 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6658             Pedro Alves  <palves@redhat.com>
6659
6660         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6661         before calling rl_set_screen_size.
6662
6663 2019-02-27  Tom Tromey  <tromey@adacore.com>
6664
6665         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6666         define.
6667         * python/py-value.c: Remove Python 2.4 workaround.
6668         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6669         workaround.
6670         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6671         Python 2.4 workaround.
6672         * python/python-internal.h: Remove Python 2.4 comment.
6673         (Py_ssize_t): Don't define.
6674         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6675         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6676         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6677         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6678         * python/python.c (do_start_initialization): Remove Python 2.4
6679         workaround.
6680         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6681         (print_children): Remove Python 2.4 workaround.
6682         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6683         workaround.
6684         (CHARBUFFERPROC_NAME): Remove.
6685         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6686         Python 2.4 workaround.
6687
6688 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6689
6690         * NEWS: Note minimum Python version.
6691
6692 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6693
6694         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6695         code from these functions.  Remove corresponding ifdefs.  Use
6696         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6697         Remove gotos and target of gotos.
6698         (infpy_search_memory): Likewise.
6699
6700 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6701
6702         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6703         (hppa_gdbarch_init): Don't register deleted functions with
6704         gdbarch.
6705
6706 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6707
6708         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6709         (h8300_unwind_sp): Delete.
6710         (h8300_dummy_id): Delete.
6711         (h8300_gdbarch_init): Don't register deleted functions with
6712         gdbarch.
6713
6714 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6715
6716         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6717         (ft32_unwind_pc): Delete.
6718         (ft32_unwind_sp): Delete.
6719         (ft32_gdbarch_init): Don't register deleted functions with
6720         gdbarch.
6721
6722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6723
6724         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6725         (frv_unwind_pc): Delete.
6726         (frv_unwind_sp): Delete.
6727         (frv_gdbarch_init): Don't register deleted functions with
6728         gdbarch.
6729
6730 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6731
6732         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6733         (riscv_unwind_pc): Delete.
6734         (riscv_unwind_sp): Delete.
6735         (riscv_gdbarch_init): Don't register deleted functions with
6736         gdbarch.
6737
6738 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6739
6740         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6741         (csky_unwind_pc): Delete.
6742         (csky_unwind_sp): Delete.
6743         (csky_gdbarch_init): Don't register deleted functions with
6744         gdbarch.
6745
6746 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6747
6748         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6749         (cris_unwind_pc): Delete.
6750         (cris_unwind_sp): Delete.
6751         (cris_gdbarch_init): Don't register deleted functions with
6752         gdbarch.
6753
6754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6755
6756         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6757         (bfin_unwind_pc): Delete.
6758         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6759
6760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6761
6762         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6763         (arm_unwind_pc): Delete.
6764         (arm_unwind_sp): Delete.
6765         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6766
6767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6768
6769         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6770         (arc_unwind_pc): Delete.
6771         (arc_unwind_sp): Delete.
6772         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6773
6774 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6775
6776         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6777         (alpha_unwind_pc): Delete.
6778         (alpha_gdbarch_init): Don't register deleted functions with
6779         gdbarch.
6780
6781 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6782
6783         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6784         (aarch64_unwind_pc): Delete.
6785         (aarch64_unwind_sp): Delete.
6786         (aarch64_gdbarch_init): Don't register deleted functions with
6787         gdbarch.
6788
6789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6790
6791         * gdbtypes.c (type_align): Don't consider static members when
6792         computing structure alignment.
6793
6794 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6795
6796         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6797         return 0 for other types.
6798         * arch-utils.c (default_type_align): Always return 0.
6799         * gdbarch.h: Regenerate.
6800         * gdbarch.sh (type_align): Extend comment.
6801         * gdbtypes.c (type_align): Add additional comments, always call
6802         gdbarch_type_align before applying the default rules.
6803         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6804         generic code will then apply a suitable default.
6805         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6806         types, return 0 for other types.
6807
6808 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6809
6810         * NEWS: Create a new section for the next release branch.
6811         Rename the section of the current branch, now that it has
6812         been cut.
6813
6814 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6815
6816         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6817         * version.in: Bump version to 8.3.50.DATE-git.
6818
6819 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6820
6821         * aix-thread.c (ptid_cmp): Remove unused variable.
6822         (get_signaled_thread): Likewise.
6823         (store_regs_user_thread): Likewise.
6824         (store_regs_kernel_thread): Likewise.
6825         (fetch_regs_kernel_thread): Remove shadowed variable.
6826
6827 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6828
6829         * features/riscv/32bit-cpu.xml: Add register numbers.
6830         * features/riscv/32bit-fpu.c: Regenerate.
6831         * features/riscv/32bit-fpu.xml: Add register numbers.
6832         * features/riscv/64bit-cpu.xml: Add register numbers.
6833         * features/riscv/64bit-fpu.c: Regenerate.
6834         * features/riscv/64bit-fpu.xml: Add register numbers.
6835
6836 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6837
6838         * NEWS: Mention two argument form of gdb.Value constructor.
6839         * python/py-value.c (convert_buffer_and_type_to_value): New
6840         function.
6841         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6842         Add support for handling an optional second argument.  Call
6843         convert_buffer_and_type_to_value as appropriate.
6844         * python/python-internal.h (Py_buffer_deleter): New struct.
6845         (Py_buffer_up): New typedef.
6846
6847 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6848
6849         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6850         instead of releasing ownership.
6851
6852 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6853
6854         * dwarf2read.c (open_and_init_dwp_file): Call
6855         elf_numsections instead of bfd_count_sections to initialize
6856         dwp_file->num_sections.
6857
6858 2019-02-25  Tom Tromey  <tromey@adacore.com>
6859
6860         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6861
6862 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6863
6864         * gcore.in: Add '--readnever' option when invoking GDB.
6865
6866 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6867
6868         * MAINTAINERS: Update my email address.
6869
6870 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6871
6872         * build-id.c (build_id_to_debug_bfd_1): New function.
6873         (build_id_to_debug_bfd): Look for separate debug file in
6874         sysroot.
6875
6876 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6877
6878         * gdbarch.sh: Update the copyright year range that is placed into
6879         generated files.
6880
6881 2019-02-22  Keith Seitz  <keiths@redhat.com>
6882
6883         PR symtab/23853
6884         * linespec.c (create_sals_line_offset): Search for the default
6885         symtab's filename instead of its fullname.
6886
6887 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6888
6889         * NEWS: Update style defaults.
6890
6891 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6892
6893         * main.c (captured_main_1): Disable styling in batch mode.
6894
6895 2019-02-20  Tom Tromey  <tom@tromey.com>
6896
6897         * symtab.c (symtab_symbol_info): Fix typos.
6898
6899 2019-02-20  Tom Tromey  <tromey@adacore.com>
6900
6901         * findcmd.c (_initialize_mem_search): Use upper case for
6902         metasyntactic variables.
6903
6904 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6905
6906         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6907         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6908
6909 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6910
6911         * top.h (source_file_name): Change to std::string.
6912         * top.c (source_file_name): Likewise.
6913         (command_line_input): Adjust.
6914         * cli/cli-script.c (script_from_file): Adjust.
6915
6916 2019-02-19  Tom Tromey  <tromey@adacore.com>
6917
6918         * ravenscar-thread.c
6919         (ravenscar_thread_target::update_thread_list): Don't call
6920         ada_build_task_list.
6921         * ada-lang.h (ada_build_task_list): Don't declare.
6922         * ada-tasks.c (struct ada_tasks_inferior_data)
6923         <task_list_valid_p>: Now bool.
6924         (read_known_tasks, ada_task_list_changed)
6925         (ada_tasks_invalidate_inferior_data): Update.
6926         (read_known_tasks_array): Return bool.
6927         (read_known_tasks_list): Likewise.
6928         (read_known_tasks): Return void.
6929         (ada_build_task_list): Now static.
6930
6931 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6932
6933         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6934         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6935
6936 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6937
6938         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6939         variant for ada_tasks_pspace_data_handle and
6940         ada_tasks_inferior_data_handle.
6941         (ada_tasks_pspace_data_cleanup): New function.
6942         (ada_tasks_inferior_data_cleanup): New function.
6943
6944 2019-02-17  Tom Tromey  <tom@tromey.com>
6945
6946         * macrotab.h (macro_source_fullname): Return a std::string.
6947         * macrotab.c (macro_include, check_for_redefinition)
6948         (macro_undef, macro_lookup_definition, foreach_macro)
6949         (foreach_macro_in_scope): Update.
6950         (macro_source_fullname): Return a std::string.
6951         * macrocmd.c (show_pp_source_pos): Update.
6952
6953 2019-02-17  Tom Tromey  <tom@tromey.com>
6954
6955         * macrocmd.c (show_pp_source_pos): Style the file names.
6956
6957 2019-02-17  Tom Tromey  <tom@tromey.com>
6958
6959         PR tui/24197:
6960         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6961
6962 2019-02-17  Tom Tromey  <tom@tromey.com>
6963
6964         * ada-lang.c (user_select_syms): Use filtered printing.
6965         * utils.c (wrap_style): New global.
6966         (desired_style): Remove.
6967         (emit_style_escape): Add stream parameter.
6968         (set_output_style, reset_terminal_style, prompt_for_continue):
6969         Update.
6970         (flush_wrap_buffer): Only flush gdb_stdout.
6971         (wrap_here): Set wrap_style.
6972         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6973         treat escape sequences as a character.  Change when wrap buffer is
6974         flushed.
6975         (fputs_styled): Do not set the output style when the default is
6976         requested.
6977         * ui-style.h (struct ui_file_style) <is_default>: New method.
6978         * source.c (print_source_lines_base): Emit escape sequences in one
6979         piece.
6980
6981 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6982
6983         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6984         integers and enumeration types.
6985
6986 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6987
6988         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6989         instead of lookup_symbol_in_language
6990         (do_exact_match): New function.
6991         (ada_get_symbol_name_matcher): Return do_exact_match when
6992         doing a verbatim match.
6993
6994 2019-02-15  Tom Tromey  <tromey@adacore.com>
6995
6996         * ravenscar-thread.c (ravenscar_thread_target::resume)
6997         (ravenscar_thread_target::wait): Special case wildcard requests.
6998
6999 2019-02-15  Tom Tromey  <tromey@adacore.com>
7000
7001         * ravenscar-thread.c (base_ptid): Remove.
7002         (struct ravenscar_thread_target) <close>: New method.
7003         <m_base_ptid>: New member.
7004         <update_inferior_ptid, active_task, task_is_currently_active,
7005         runtime_initialized>: Declare methods.
7006         <ravenscar_thread_target>: Add constructor.
7007         (ravenscar_thread_target::task_is_currently_active)
7008         (ravenscar_thread_target::update_inferior_ptid)
7009         (ravenscar_runtime_initialized): Rename.  Now methods.
7010         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7011         (ravenscar_thread_target::update_thread_list): Update.
7012         (ravenscar_thread_target::active_task): Now method.
7013         (ravenscar_thread_target::store_registers)
7014         (ravenscar_thread_target::prepare_to_store)
7015         (ravenscar_thread_target::prepare_to_store)
7016         (ravenscar_thread_target::mourn_inferior): Update.
7017         (ravenscar_inferior_created): Use "new" to create target.
7018         (ravenscar_thread_target::get_ada_task_ptid): Update.
7019         (_initialize_ravenscar): Don't initialize base_ptid.
7020         (ravenscar_ops): Remove global.
7021
7022 2019-02-15  Tom Tromey  <tromey@adacore.com>
7023
7024         * target.h (push_target): Declare new overload.
7025         * target.c (push_target): New overload, taking an rvalue reference.
7026         * remote.c (remote_target::open_1): Use push_target overload.
7027         * corelow.c (core_target_open): Use push_target overload.
7028
7029 2019-02-15  Tom Tromey  <tromey@adacore.com>
7030
7031         * ravenscar-thread.c (is_ravenscar_task)
7032         (ravenscar_task_is_currently_active): Return bool.
7033         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7034         (_initialize_ravenscar): Remove "(void)".
7035         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7036         Return bool.
7037
7038 2019-02-15  Tom Tromey  <tromey@adacore.com>
7039
7040         * ravenscar-thread.c (ravenscar_runtime_initializer)
7041         (has_ravenscar_runtime, get_running_thread_id)
7042         (ravenscar_thread_target::resume): Fix indentation.
7043
7044 2019-02-15  Tom Tromey  <tromey@adacore.com>
7045
7046         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7047         from ravenscar_arch_ops.
7048         (sparc_ravenscar_ops::fetch_registers)
7049         (sparc_ravenscar_ops::store_registers): Now methods.
7050         (sparc_ravenscar_prepare_to_store): Remove.
7051         (sparc_ravenscar_ops): Redefine.
7052         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7053         methods and destructor.  Remove members.
7054         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7055         (ravenscar_thread_target::store_registers)
7056         (ravenscar_thread_target::prepare_to_store): Update.
7057         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7058         Remove.
7059         (struct ppc_ravenscar_powerpc_ops): Derive from
7060         ravenscar_arch_ops.
7061         (ppc_ravenscar_powerpc_ops::fetch_registers)
7062         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7063         (ppc_ravenscar_powerpc_ops): Redefine.
7064         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7065         (ppc_ravenscar_e500_ops::fetch_registers)
7066         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7067         (ppc_ravenscar_e500_ops): Redefine.
7068         * aarch64-ravenscar-thread.c
7069         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7070         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7071         (aarch64_ravenscar_fetch_registers)
7072         (aarch64_ravenscar_store_registers): Now methods.
7073         (aarch64_ravenscar_ops): Redefine.
7074
7075 2019-02-15  Tom Tromey  <tromey@adacore.com>
7076
7077         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7078         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7079         (ravenscar_thread_target::stopped_by_watchpoint)
7080         (ravenscar_thread_target::stopped_data_address)
7081         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7082
7083 2019-02-15  Tom Tromey  <tromey@adacore.com>
7084
7085         * ravenscar-thread.c: Fix some typos.
7086
7087 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7088             Tom Tromey  <tromey@adacore.com>
7089
7090         * ada-lang.c (ada_exception_sal): Change addr_string to a
7091         std::string.
7092         (create_ada_exception_catchpoint): Update.
7093
7094 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7095             Tom Tromey  <tromey@adacore.com>
7096
7097         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7098         (bp_location_ops): Remove.
7099         (base_breakpoint_allocate_location): Update.
7100         (free_bp_location): Update.
7101         * ada-lang.c (class ada_catchpoint_location)
7102         <ada_catchpoint_location>: Remove ops parameter.
7103         (ada_catchpoint_location_dtor): Remove.
7104         (ada_catchpoint_location_ops): Remove.
7105         (allocate_location_exception): Update.
7106         * breakpoint.h (struct bp_location_ops): Remove.
7107         (class bp_location) <bp_location>: Remove bp_location_ops
7108         parameter.
7109         <~bp_location>: Add destructor.
7110         <ops>: Remove.
7111
7112 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7113             Pedro Alves  <palves@redhat.com>
7114
7115         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7116         'PATH_MAX'.
7117
7118 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7119             Samuel Thibault  <samuel.thibault@gnu.org>
7120             Thomas Schwinge  <thomas@codesourcery.com>
7121
7122         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7123         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7124
7125 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7126
7127         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7128         (check_empty): Use "const char *".
7129
7130         * gnu-nat.c (gnu_nat_target::detach): Instead of
7131         'detach_inferior (pid)' call
7132         'detach_inferior (find_inferior_pid (pid))'.
7133
7134         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7135         'nat/fork-inferior.o'.
7136         * gnu-nat.c: #include "nat/fork-inferior.h".
7137
7138         * gnu-nat.c (gnu_nat_target::detach): Instead of
7139         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7140         * gnu-nat.h: #include "inf-child.h".
7141         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7142         'i386_gnu_nat_target::fetch_registers'.
7143         (gnu_store_registers): Rename/move to
7144         'i386_gnu_nat_target::store_registers'.
7145
7146         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7147         * gnu-nat.h (mach_thread_info): New function.
7148         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7149
7150         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7151
7152 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7153
7154         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7155
7156 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7157
7158         * windows-nat.c (windows_add_thread): Add new parameter
7159         "main_thread_p" with default value set to false.  Update
7160         function documentation as well as all callers.
7161         (windows_delete_thread): Likewise.
7162         (fake_create_process): Update call to windows_add_thread.
7163         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7164         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7165         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7166         call to windows_delete_thread.
7167
7168 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7169
7170         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7171
7172 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7173
7174         * symfile.c (find_separate_debug_file): Use canonical path of
7175         sysroot with child_path instead of gdb_sysroot if it is valid.
7176
7177 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7178
7179         * symfile.c (find_separate_debug_file): Use child_path to
7180         determine if an object file is under a sysroot.
7181
7182 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7183
7184         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7185         unittests/child-path-selftests.c.
7186         * common/pathstuff.c (child_path): New function.
7187         * common/pathstuff.h (child_path): New prototype.
7188         * unittests/child-path-selftests.c: New file.
7189
7190 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7191
7192         * symfile.c (find_separate_debug_file): Look for separate debug
7193         files in debug directories under the sysroot.
7194
7195 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7196
7197         * symtab.h (struct minimal_symbol data_p): New const method.
7198         (struct minimal_symbol text_p): Likewise.
7199         * symtab.c (output_source_filename): Use file name style
7200         to print file name.
7201         (print_symbol_info): Likewise.
7202         (print_msymbol_info): Use address style to print addresses.
7203         Use function name style to print executable text symbols.
7204         (expand_symtab_containing_pc): Use data_p.
7205         (find_pc_sect_compunit_symtab): Likewise.
7206
7207 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7208
7209         * breakpoint.c (describe_other_breakpoints): Use address style
7210         to print addresses.
7211         (say_where): Likewise.
7212
7213 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7214
7215         * ada-typeprint.c (print_func_type): Print function name
7216         style to print function name.
7217         * c-typeprint.c (c_print_type_1): Likewise.
7218
7219 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7220
7221         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7222         for execve.
7223
7224 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7225
7226         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7227         type_stack.
7228
7229 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7230
7231         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7232         TYPE_CODE_REF types.
7233
7234 2019-02-08  Jim Wilson  <jimw@sifive.com>
7235
7236         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7237         (riscv_linux_fregset): New.
7238         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7239
7240 2019-02-07  Tom Tromey  <tom@tromey.com>
7241
7242         * thread.c (thread_cancel_execution_command): Update.
7243         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7244         methods.
7245         (struct thread_fsm_ops): Remove.
7246         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7247         (thread_fsm_should_stop, thread_fsm_return_value)
7248         (thread_fsm_set_finished, thread_fsm_finished_p)
7249         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7250         Don't declare.
7251         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7252         * infrun.c (clear_proceed_status_thread)
7253         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7254         (print_stop_event): Update.
7255         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7256         Add constructor.
7257         (step_command_fsm_ops): Remove.
7258         (new_step_command_fsm): Remove.
7259         (step_1): Update.
7260         (step_command_fsm::should_stop): Rename from
7261         step_command_fsm_should_stop.
7262         (step_command_fsm::clean_up): Rename from
7263         step_command_fsm_clean_up.
7264         (step_command_fsm::do_async_reply_reason): Rename from
7265         step_command_fsm_async_reply_reason.
7266         (struct until_next_fsm): Inherit from thread_fsm.  Add
7267         constructor.
7268         (until_next_fsm_ops): Remove.
7269         (new_until_next_fsm): Remove.
7270         (until_next_fsm::should_stop): Rename from
7271         until_next_fsm_should_stop.
7272         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7273         (until_next_fsm::do_async_reply_reason): Rename from
7274         until_next_fsm_async_reply_reason.
7275         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7276         constructor.  Change type of breakpoint.
7277         (finish_command_fsm_ops): Remove.
7278         (new_finish_command_fsm): Remove.
7279         (finish_command_fsm::should_stop): Rename from
7280         finish_command_fsm_should_stop.
7281         (finish_command_fsm::clean_up): Rename from
7282         finish_command_fsm_clean_up.
7283         (finish_command_fsm::return_value): Rename from
7284         finish_command_fsm_return_value.
7285         (finish_command_fsm::do_async_reply_reason): Rename from
7286         finish_command_fsm_async_reply_reason.
7287         (finish_command): Update.
7288         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7289         Add constructor.
7290         (call_thread_fsm_ops): Remove.
7291         (call_thread_fsm::call_thread_fsm): Rename from
7292         new_call_thread_fsm.
7293         (call_thread_fsm::should_stop): Rename from
7294         call_thread_fsm_should_stop.
7295         (call_thread_fsm::should_notify_stop): Rename from
7296         call_thread_fsm_should_notify_stop.
7297         (run_inferior_call, call_function_by_hand_dummy): Update.
7298         * cli/cli-interp.c (should_print_stop_to_console): Update.
7299         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7300         Add constructor.  Change type of location_breakpoint,
7301         caller_breakpoint.
7302         (until_break_fsm_ops): Remove.
7303         (new_until_break_fsm): Remove.
7304         (until_break_fsm::should_stop): Rename from
7305         until_break_fsm_should_stop.
7306         (until_break_fsm::clean_up): Rename from
7307         until_break_fsm_clean_up.
7308         (until_break_fsm::do_async_reply_reason): Rename from
7309         until_break_fsm_async_reply_reason.
7310         (until_break_command): Update.
7311         * thread-fsm.c: Remove.
7312         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7313
7314 2019-02-07  Tom Tromey  <tom@tromey.com>
7315
7316         * yy-remap.h: Add include guard.
7317         * xtensa-tdep.h: Add include guard.
7318         * xcoffread.h: Rename include guard.
7319         * varobj-iter.h: Add include guard.
7320         * tui/tui.h: Rename include guard.
7321         * tui/tui-winsource.h: Rename include guard.
7322         * tui/tui-wingeneral.h: Rename include guard.
7323         * tui/tui-windata.h: Rename include guard.
7324         * tui/tui-win.h: Rename include guard.
7325         * tui/tui-stack.h: Rename include guard.
7326         * tui/tui-source.h: Rename include guard.
7327         * tui/tui-regs.h: Rename include guard.
7328         * tui/tui-out.h: Rename include guard.
7329         * tui/tui-layout.h: Rename include guard.
7330         * tui/tui-io.h: Rename include guard.
7331         * tui/tui-hooks.h: Rename include guard.
7332         * tui/tui-file.h: Rename include guard.
7333         * tui/tui-disasm.h: Rename include guard.
7334         * tui/tui-data.h: Rename include guard.
7335         * tui/tui-command.h: Rename include guard.
7336         * tic6x-tdep.h: Add include guard.
7337         * target/waitstatus.h: Rename include guard.
7338         * target/wait.h: Rename include guard.
7339         * target/target.h: Rename include guard.
7340         * target/resume.h: Rename include guard.
7341         * target-float.h: Rename include guard.
7342         * stabsread.h: Add include guard.
7343         * rs6000-tdep.h: Add include guard.
7344         * riscv-fbsd-tdep.h: Add include guard.
7345         * regformats/regdef.h: Rename include guard.
7346         * record.h: Rename include guard.
7347         * python/python.h: Rename include guard.
7348         * python/python-internal.h: Rename include guard.
7349         * python/py-stopevent.h: Rename include guard.
7350         * python/py-ref.h: Rename include guard.
7351         * python/py-record.h: Rename include guard.
7352         * python/py-record-full.h: Rename include guard.
7353         * python/py-record-btrace.h: Rename include guard.
7354         * python/py-instruction.h: Rename include guard.
7355         * python/py-events.h: Rename include guard.
7356         * python/py-event.h: Rename include guard.
7357         * procfs.h: Add include guard.
7358         * proc-utils.h: Add include guard.
7359         * p-lang.h: Add include guard.
7360         * or1k-tdep.h: Rename include guard.
7361         * observable.h: Rename include guard.
7362         * nto-tdep.h: Rename include guard.
7363         * nat/x86-linux.h: Rename include guard.
7364         * nat/x86-linux-dregs.h: Rename include guard.
7365         * nat/x86-gcc-cpuid.h: Add include guard.
7366         * nat/x86-dregs.h: Rename include guard.
7367         * nat/x86-cpuid.h: Rename include guard.
7368         * nat/ppc-linux.h: Rename include guard.
7369         * nat/mips-linux-watch.h: Rename include guard.
7370         * nat/linux-waitpid.h: Rename include guard.
7371         * nat/linux-ptrace.h: Rename include guard.
7372         * nat/linux-procfs.h: Rename include guard.
7373         * nat/linux-osdata.h: Rename include guard.
7374         * nat/linux-nat.h: Rename include guard.
7375         * nat/linux-namespaces.h: Rename include guard.
7376         * nat/linux-btrace.h: Rename include guard.
7377         * nat/glibc_thread_db.h: Rename include guard.
7378         * nat/gdb_thread_db.h: Rename include guard.
7379         * nat/gdb_ptrace.h: Rename include guard.
7380         * nat/fork-inferior.h: Rename include guard.
7381         * nat/amd64-linux-siginfo.h: Rename include guard.
7382         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7383         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7384         * nat/aarch64-linux.h: Rename include guard.
7385         * nat/aarch64-linux-hw-point.h: Rename include guard.
7386         * mn10300-tdep.h: Add include guard.
7387         * mips-linux-tdep.h: Add include guard.
7388         * mi/mi-parse.h: Rename include guard.
7389         * mi/mi-out.h: Rename include guard.
7390         * mi/mi-main.h: Rename include guard.
7391         * mi/mi-interp.h: Rename include guard.
7392         * mi/mi-getopt.h: Rename include guard.
7393         * mi/mi-console.h: Rename include guard.
7394         * mi/mi-common.h: Rename include guard.
7395         * mi/mi-cmds.h: Rename include guard.
7396         * mi/mi-cmd-break.h: Rename include guard.
7397         * m2-lang.h: Add include guard.
7398         * location.h: Rename include guard.
7399         * linux-record.h: Rename include guard.
7400         * linux-nat.h: Add include guard.
7401         * linux-fork.h: Add include guard.
7402         * i386-darwin-tdep.h: Rename include guard.
7403         * hppa-linux-offsets.h: Add include guard.
7404         * guile/guile.h: Rename include guard.
7405         * guile/guile-internal.h: Rename include guard.
7406         * gnu-nat.h: Rename include guard.
7407         * gdb-stabs.h: Rename include guard.
7408         * frv-tdep.h: Add include guard.
7409         * f-lang.h: Add include guard.
7410         * event-loop.h: Add include guard.
7411         * darwin-nat.h: Rename include guard.
7412         * cp-abi.h: Rename include guard.
7413         * config/sparc/nm-sol2.h: Rename include guard.
7414         * config/nm-nto.h: Rename include guard.
7415         * config/nm-linux.h: Add include guard.
7416         * config/i386/nm-i386gnu.h: Rename include guard.
7417         * config/djgpp/nl_types.h: Rename include guard.
7418         * config/djgpp/langinfo.h: Rename include guard.
7419         * compile/gcc-cp-plugin.h: Add include guard.
7420         * compile/gcc-c-plugin.h: Add include guard.
7421         * compile/compile.h: Rename include guard.
7422         * compile/compile-object-run.h: Rename include guard.
7423         * compile/compile-object-load.h: Rename include guard.
7424         * compile/compile-internal.h: Rename include guard.
7425         * compile/compile-cplus.h: Rename include guard.
7426         * compile/compile-c.h: Rename include guard.
7427         * common/xml-utils.h: Rename include guard.
7428         * common/x86-xstate.h: Rename include guard.
7429         * common/version.h: Rename include guard.
7430         * common/vec.h: Rename include guard.
7431         * common/tdesc.h: Rename include guard.
7432         * common/selftest.h: Rename include guard.
7433         * common/scoped_restore.h: Rename include guard.
7434         * common/scoped_mmap.h: Rename include guard.
7435         * common/scoped_fd.h: Rename include guard.
7436         * common/safe-iterator.h: Rename include guard.
7437         * common/run-time-clock.h: Rename include guard.
7438         * common/refcounted-object.h: Rename include guard.
7439         * common/queue.h: Rename include guard.
7440         * common/ptid.h: Rename include guard.
7441         * common/print-utils.h: Rename include guard.
7442         * common/preprocessor.h: Rename include guard.
7443         * common/pathstuff.h: Rename include guard.
7444         * common/observable.h: Rename include guard.
7445         * common/netstuff.h: Rename include guard.
7446         * common/job-control.h: Rename include guard.
7447         * common/host-defs.h: Rename include guard.
7448         * common/gdb_wait.h: Rename include guard.
7449         * common/gdb_vecs.h: Rename include guard.
7450         * common/gdb_unlinker.h: Rename include guard.
7451         * common/gdb_unique_ptr.h: Rename include guard.
7452         * common/gdb_tilde_expand.h: Rename include guard.
7453         * common/gdb_sys_time.h: Rename include guard.
7454         * common/gdb_string_view.h: Rename include guard.
7455         * common/gdb_splay_tree.h: Rename include guard.
7456         * common/gdb_setjmp.h: Rename include guard.
7457         * common/gdb_ref_ptr.h: Rename include guard.
7458         * common/gdb_optional.h: Rename include guard.
7459         * common/gdb_locale.h: Rename include guard.
7460         * common/gdb_assert.h: Rename include guard.
7461         * common/filtered-iterator.h: Rename include guard.
7462         * common/filestuff.h: Rename include guard.
7463         * common/fileio.h: Rename include guard.
7464         * common/environ.h: Rename include guard.
7465         * common/common-utils.h: Rename include guard.
7466         * common/common-types.h: Rename include guard.
7467         * common/common-regcache.h: Rename include guard.
7468         * common/common-inferior.h: Rename include guard.
7469         * common/common-gdbthread.h: Rename include guard.
7470         * common/common-exceptions.h: Rename include guard.
7471         * common/common-defs.h: Rename include guard.
7472         * common/common-debug.h: Rename include guard.
7473         * common/cleanups.h: Rename include guard.
7474         * common/buffer.h: Rename include guard.
7475         * common/btrace-common.h: Rename include guard.
7476         * common/break-common.h: Rename include guard.
7477         * cli/cli-utils.h: Rename include guard.
7478         * cli/cli-style.h: Rename include guard.
7479         * cli/cli-setshow.h: Rename include guard.
7480         * cli/cli-script.h: Rename include guard.
7481         * cli/cli-interp.h: Rename include guard.
7482         * cli/cli-decode.h: Rename include guard.
7483         * cli/cli-cmds.h: Rename include guard.
7484         * charset-list.h: Add include guard.
7485         * buildsym-legacy.h: Rename include guard.
7486         * bfin-tdep.h: Add include guard.
7487         * ax.h: Rename include guard.
7488         * arm-linux-tdep.h: Add include guard.
7489         * arm-fbsd-tdep.h: Add include guard.
7490         * arch/xtensa.h: Rename include guard.
7491         * arch/tic6x.h: Add include guard.
7492         * arch/i386.h: Add include guard.
7493         * arch/arm.h: Rename include guard.
7494         * arch/arm-linux.h: Rename include guard.
7495         * arch/arm-get-next-pcs.h: Rename include guard.
7496         * arch/amd64.h: Add include guard.
7497         * arch/aarch64-insn.h: Rename include guard.
7498         * arch-utils.h: Rename include guard.
7499         * annotate.h: Add include guard.
7500         * amd64-darwin-tdep.h: Rename include guard.
7501         * aarch64-linux-tdep.h: Add include guard.
7502         * aarch64-fbsd-tdep.h: Add include guard.
7503         * aarch32-linux-nat.h: Add include guard.
7504
7505 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7506
7507         * macrotab.c (macro_define_internal): New function that
7508         factorizes macro_define_object_internal and macro_define_function
7509         code.
7510         (macro_define_object_internal): Use macro_define_internal.
7511         (macro_define_function): Likewise.
7512
7513 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7514
7515         * macrocmd.c (extract_identifier): Return
7516         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7517         callers.
7518
7519 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7520
7521         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7522
7523 2019-02-05  Tom Tromey  <tom@tromey.com>
7524
7525         * target.c (target_stack::unpush): Move assertion earlier.
7526
7527 2019-01-30  Tom Tromey  <tom@tromey.com>
7528
7529         PR python/23615:
7530         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7531         (gdbpy_parse_and_eval): Likewise.
7532         * python/python-internal.h (gdbpy_allow_threads): New class.
7533
7534 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7535
7536         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7537         (aarch64_fbsd_fpregmap): Move earlier.
7538         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7539         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7540         instead of individual calls to trad_frame_set_reg_addr.
7541         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7542         earlier.
7543         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7544         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7545         instead of individual calls to trad_frame_set_reg_addr.
7546
7547 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7548
7549         * CONTRIBUTE: Replace contribution list with wiki link.
7550
7551 2019-01-25  Tom Tromey  <tom@tromey.com>
7552
7553         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7554
7555 2019-01-25  Tom Tromey  <tom@tromey.com>
7556
7557         * xtensa-linux-nat.c: Fix common/ includes.
7558         * xml-support.h: Fix common/ includes.
7559         * xml-support.c: Fix common/ includes.
7560         * x86-linux-nat.c: Fix common/ includes.
7561         * windows-nat.c: Fix common/ includes.
7562         * varobj.h: Fix common/ includes.
7563         * varobj.c: Fix common/ includes.
7564         * value.c: Fix common/ includes.
7565         * valops.c: Fix common/ includes.
7566         * utils.c: Fix common/ includes.
7567         * unittests/xml-utils-selftests.c: Fix common/ includes.
7568         * unittests/utils-selftests.c: Fix common/ includes.
7569         * unittests/unpack-selftests.c: Fix common/ includes.
7570         * unittests/tracepoint-selftests.c: Fix common/ includes.
7571         * unittests/style-selftests.c: Fix common/ includes.
7572         * unittests/string_view-selftests.c: Fix common/ includes.
7573         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7574         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7575         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7576         * unittests/rsp-low-selftests.c: Fix common/ includes.
7577         * unittests/parse-connection-spec-selftests.c: Fix common/
7578         includes.
7579         * unittests/optional-selftests.c: Fix common/ includes.
7580         * unittests/offset-type-selftests.c: Fix common/ includes.
7581         * unittests/observable-selftests.c: Fix common/ includes.
7582         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7583         * unittests/memrange-selftests.c: Fix common/ includes.
7584         * unittests/memory-map-selftests.c: Fix common/ includes.
7585         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7586         * unittests/function-view-selftests.c: Fix common/ includes.
7587         * unittests/environ-selftests.c: Fix common/ includes.
7588         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7589         * unittests/common-utils-selftests.c: Fix common/ includes.
7590         * unittests/cli-utils-selftests.c: Fix common/ includes.
7591         * unittests/array-view-selftests.c: Fix common/ includes.
7592         * ui-file.c: Fix common/ includes.
7593         * tui/tui-io.c: Fix common/ includes.
7594         * tracepoint.h: Fix common/ includes.
7595         * tracepoint.c: Fix common/ includes.
7596         * tracefile-tfile.c: Fix common/ includes.
7597         * top.h: Fix common/ includes.
7598         * top.c: Fix common/ includes.
7599         * thread.c: Fix common/ includes.
7600         * target/waitstatus.h: Fix common/ includes.
7601         * target/waitstatus.c: Fix common/ includes.
7602         * target.h: Fix common/ includes.
7603         * target.c: Fix common/ includes.
7604         * target-memory.c: Fix common/ includes.
7605         * target-descriptions.c: Fix common/ includes.
7606         * symtab.h: Fix common/ includes.
7607         * symfile.c: Fix common/ includes.
7608         * stap-probe.c: Fix common/ includes.
7609         * spu-linux-nat.c: Fix common/ includes.
7610         * sparc-nat.c: Fix common/ includes.
7611         * source.c: Fix common/ includes.
7612         * solib.c: Fix common/ includes.
7613         * solib-target.c: Fix common/ includes.
7614         * ser-unix.c: Fix common/ includes.
7615         * ser-tcp.c: Fix common/ includes.
7616         * ser-pipe.c: Fix common/ includes.
7617         * ser-base.c: Fix common/ includes.
7618         * selftest-arch.c: Fix common/ includes.
7619         * s12z-tdep.c: Fix common/ includes.
7620         * rust-exp.y: Fix common/ includes.
7621         * rs6000-aix-tdep.c: Fix common/ includes.
7622         * riscv-tdep.c: Fix common/ includes.
7623         * remote.c: Fix common/ includes.
7624         * remote-notif.h: Fix common/ includes.
7625         * remote-fileio.h: Fix common/ includes.
7626         * remote-fileio.c: Fix common/ includes.
7627         * regcache.h: Fix common/ includes.
7628         * regcache.c: Fix common/ includes.
7629         * record-btrace.c: Fix common/ includes.
7630         * python/python.c: Fix common/ includes.
7631         * python/py-type.c: Fix common/ includes.
7632         * python/py-inferior.c: Fix common/ includes.
7633         * progspace.h: Fix common/ includes.
7634         * producer.c: Fix common/ includes.
7635         * procfs.c: Fix common/ includes.
7636         * proc-api.c: Fix common/ includes.
7637         * printcmd.c: Fix common/ includes.
7638         * ppc-linux-nat.c: Fix common/ includes.
7639         * parser-defs.h: Fix common/ includes.
7640         * osdata.c: Fix common/ includes.
7641         * obsd-nat.c: Fix common/ includes.
7642         * nat/x86-linux.c: Fix common/ includes.
7643         * nat/x86-linux-dregs.c: Fix common/ includes.
7644         * nat/x86-dregs.h: Fix common/ includes.
7645         * nat/x86-dregs.c: Fix common/ includes.
7646         * nat/ppc-linux.c: Fix common/ includes.
7647         * nat/mips-linux-watch.h: Fix common/ includes.
7648         * nat/mips-linux-watch.c: Fix common/ includes.
7649         * nat/linux-waitpid.c: Fix common/ includes.
7650         * nat/linux-ptrace.h: Fix common/ includes.
7651         * nat/linux-ptrace.c: Fix common/ includes.
7652         * nat/linux-procfs.c: Fix common/ includes.
7653         * nat/linux-personality.c: Fix common/ includes.
7654         * nat/linux-osdata.c: Fix common/ includes.
7655         * nat/linux-namespaces.c: Fix common/ includes.
7656         * nat/linux-btrace.h: Fix common/ includes.
7657         * nat/linux-btrace.c: Fix common/ includes.
7658         * nat/fork-inferior.c: Fix common/ includes.
7659         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7660         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7661         * nat/aarch64-linux.c: Fix common/ includes.
7662         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7663         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7664         * namespace.h: Fix common/ includes.
7665         * mips-linux-tdep.c: Fix common/ includes.
7666         * minsyms.c: Fix common/ includes.
7667         * mi/mi-parse.h: Fix common/ includes.
7668         * mi/mi-main.c: Fix common/ includes.
7669         * mi/mi-cmd-env.c: Fix common/ includes.
7670         * memrange.h: Fix common/ includes.
7671         * memattr.c: Fix common/ includes.
7672         * maint.h: Fix common/ includes.
7673         * maint.c: Fix common/ includes.
7674         * main.c: Fix common/ includes.
7675         * machoread.c: Fix common/ includes.
7676         * location.c: Fix common/ includes.
7677         * linux-thread-db.c: Fix common/ includes.
7678         * linux-nat.c: Fix common/ includes.
7679         * linux-fork.c: Fix common/ includes.
7680         * inline-frame.c: Fix common/ includes.
7681         * infrun.c: Fix common/ includes.
7682         * inflow.c: Fix common/ includes.
7683         * inferior.h: Fix common/ includes.
7684         * inferior.c: Fix common/ includes.
7685         * infcmd.c: Fix common/ includes.
7686         * inf-ptrace.c: Fix common/ includes.
7687         * inf-child.c: Fix common/ includes.
7688         * ia64-linux-nat.c: Fix common/ includes.
7689         * i387-tdep.c: Fix common/ includes.
7690         * i386-tdep.c: Fix common/ includes.
7691         * i386-linux-tdep.c: Fix common/ includes.
7692         * i386-linux-nat.c: Fix common/ includes.
7693         * i386-go32-tdep.c: Fix common/ includes.
7694         * i386-fbsd-tdep.c: Fix common/ includes.
7695         * i386-fbsd-nat.c: Fix common/ includes.
7696         * guile/scm-type.c: Fix common/ includes.
7697         * guile/guile.c: Fix common/ includes.
7698         * go32-nat.c: Fix common/ includes.
7699         * gnu-nat.c: Fix common/ includes.
7700         * gdbthread.h: Fix common/ includes.
7701         * gdbarch-selftests.c: Fix common/ includes.
7702         * gdb_usleep.c: Fix common/ includes.
7703         * gdb_select.h: Fix common/ includes.
7704         * gdb_bfd.c: Fix common/ includes.
7705         * gcore.c: Fix common/ includes.
7706         * fork-child.c: Fix common/ includes.
7707         * findvar.c: Fix common/ includes.
7708         * fbsd-nat.c: Fix common/ includes.
7709         * event-top.c: Fix common/ includes.
7710         * event-loop.c: Fix common/ includes.
7711         * dwarf2read.c: Fix common/ includes.
7712         * dwarf2loc.c: Fix common/ includes.
7713         * dwarf2-frame.c: Fix common/ includes.
7714         * dwarf-index-cache.c: Fix common/ includes.
7715         * dtrace-probe.c: Fix common/ includes.
7716         * disasm-selftests.c: Fix common/ includes.
7717         * defs.h: Fix common/ includes.
7718         * csky-tdep.c: Fix common/ includes.
7719         * cp-valprint.c: Fix common/ includes.
7720         * cp-support.h: Fix common/ includes.
7721         * cp-support.c: Fix common/ includes.
7722         * corelow.c: Fix common/ includes.
7723         * completer.h: Fix common/ includes.
7724         * completer.c: Fix common/ includes.
7725         * compile/compile.c: Fix common/ includes.
7726         * compile/compile-loc2c.c: Fix common/ includes.
7727         * compile/compile-cplus-types.c: Fix common/ includes.
7728         * compile/compile-cplus-symbols.c: Fix common/ includes.
7729         * command.h: Fix common/ includes.
7730         * cli/cli-dump.c: Fix common/ includes.
7731         * cli/cli-cmds.c: Fix common/ includes.
7732         * charset.c: Fix common/ includes.
7733         * build-id.c: Fix common/ includes.
7734         * btrace.h: Fix common/ includes.
7735         * btrace.c: Fix common/ includes.
7736         * breakpoint.h: Fix common/ includes.
7737         * breakpoint.c: Fix common/ includes.
7738         * ax.h:
7739         (enum agent_op): Fix common/ includes.
7740         * ax-general.c (struct aop_map): Fix common/ includes.
7741         * ax-gdb.c: Fix common/ includes.
7742         * auxv.c: Fix common/ includes.
7743         * auto-load.c: Fix common/ includes.
7744         * arm-tdep.c: Fix common/ includes.
7745         * arch/riscv.c: Fix common/ includes.
7746         * arch/ppc-linux-common.c: Fix common/ includes.
7747         * arch/i386.c: Fix common/ includes.
7748         * arch/arm.c: Fix common/ includes.
7749         * arch/arm-linux.c: Fix common/ includes.
7750         * arch/arm-get-next-pcs.c: Fix common/ includes.
7751         * arch/amd64.c: Fix common/ includes.
7752         * arch/aarch64.c: Fix common/ includes.
7753         * arch/aarch64-insn.c: Fix common/ includes.
7754         * arch-utils.c: Fix common/ includes.
7755         * amd64-windows-tdep.c: Fix common/ includes.
7756         * amd64-tdep.c: Fix common/ includes.
7757         * amd64-sol2-tdep.c: Fix common/ includes.
7758         * amd64-obsd-tdep.c: Fix common/ includes.
7759         * amd64-nbsd-tdep.c: Fix common/ includes.
7760         * amd64-linux-tdep.c: Fix common/ includes.
7761         * amd64-linux-nat.c: Fix common/ includes.
7762         * amd64-fbsd-tdep.c: Fix common/ includes.
7763         * amd64-fbsd-nat.c: Fix common/ includes.
7764         * amd64-dicos-tdep.c: Fix common/ includes.
7765         * amd64-darwin-tdep.c: Fix common/ includes.
7766         * agent.c: Fix common/ includes.
7767         * ada-lang.h: Fix common/ includes.
7768         * ada-lang.c: Fix common/ includes.
7769         * aarch64-tdep.c: Fix common/ includes.
7770
7771 2019-01-25  Tom Tromey  <tom@tromey.com>
7772
7773         * common/create-version.sh: Use common/version.h.
7774
7775 2019-01-24  Pedro Alves  <palves@redhat.com>
7776
7777         * infrun.c (signal_stop, signal_print, signal_program)
7778         (signal_catch, signal_pass): Now arrays instead of pointers.
7779         (update_signals_program_target, do_target_resume)
7780         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7781         * linux-nat.c (linux_nat_target::pass_signals)
7782         (linux_nat_target::create_inferior, linux_nat_target::attach):
7783         Adjust.
7784         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7785         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7786         * procfs.c (procfs_target::pass_signals): Adjust.
7787         * record-full.c (record_full_target::resume): Adjust.
7788         * remote.c (remote_target::pass_signals)
7789         (remote_target::program_signals): Adjust.
7790         * target-debug.h (target_debug_print_signals): Now takes a
7791         gdb::array_view as parameter.  Adjust.
7792         * target.h (target_ops) <pass_signals, program_signals>: Replace
7793         pointer and length parameters with gdb::array_view.
7794         (target_pass_signals, target_program_signals): Likewise.
7795         * target-delegates.c: Regenerate.
7796
7797 2019-01-24  Pedro Alves  <palves@redhat.com>
7798
7799         * common/forward-scope-exit.h
7800         (forward_scope_exit::forward_scope_exit): Pass arguments to
7801         m_bind_function directly, instead of creating a std::bind and
7802         copying that.
7803
7804 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7805
7806         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7807         for static members.
7808         (pass_in_v_vfp_candidate): Likewise.
7809
7810 2019-01-23  Tom Tromey  <tom@tromey.com>
7811             Pedro Alves  <palves@redhat.com>
7812
7813         * regcache.c (class regcache_invalidator): Remove.
7814         (regcache::raw_write): Use make_scope_exit.
7815
7816 2019-01-23  Tom Tromey  <tom@tromey.com>
7817
7818         * ui-out.h (class ui_out_emit_type): Update comment.
7819
7820 2019-01-23  Tom Tromey  <tom@tromey.com>
7821
7822         * infrun.c (fetch_inferior_event): Update comment.
7823
7824 2019-01-23  Tom Tromey  <tom@tromey.com>
7825             Pedro Alves  <palves@redhat.com>
7826
7827         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7828         parameter.
7829         (fetch_inferior_event): Use SCOPE_EXIT.
7830
7831
7832 2019-01-23  Tom Tromey  <tom@tromey.com>
7833             Pedro Alves  <palves@redhat.com>
7834
7835         * infrun.c (disable_thread_events): Delete.
7836         (stop_all_threads): Use SCOPE_EXIT.
7837
7838 2019-01-23  Tom Tromey  <tom@tromey.com>
7839             Pedro Alves  <palves@redhat.com>
7840
7841         * symfile.c: Include forward-scope-exit.h.
7842         (clear_symtab_users_cleanup): Replace forward declaration with
7843         a FORWARD_SCOPE_EXIT.
7844         (syms_from_objfile_1): Use the forward_scope_exit and
7845         gdb::optional instead of cleanup_function.
7846         (reread_symbols): Use the forward_scope_exit instead of
7847         cleanup_function.
7848         (clear_symtab_users_cleanup): Remove function.
7849
7850 2019-01-23  Tom Tromey  <tom@tromey.com>
7851             Pedro Alves  <palves@redhat.com>
7852
7853         * linux-nat.c: Include scope-exit.h.
7854         (cleanup_target_stop): Remove.
7855         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7856         SCOPE_EXIT.
7857
7858 2019-01-23  Tom Tromey  <tom@tromey.com>
7859             Pedro Alves  <palves@redhat.com>
7860
7861         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7862         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7863
7864 2019-01-23  Tom Tromey  <tom@tromey.com>
7865             Andrew Burgess  <andrew.burgess@embecosm.com>
7866             Pedro Alves  <palves@redhat.com>
7867
7868         * infrun.c (fetch_inferior_event): Use scope_exit.
7869         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7870         * top.c (execute_command): Use scope_exit.
7871         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7872         * utils.c (do_bpstat_clear_actions_cleanup)
7873         (make_bpstat_clear_actions_cleanup): Remove.
7874
7875 2019-01-23  Tom Tromey  <tom@tromey.com>
7876             Pedro Alves  <palves@redhat.com>
7877
7878         * infrun.c: Include "common/scope-exit.h"
7879         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7880         (wait_for_inferior): Use SCOPE_EXIT.
7881         (fetch_inferior_event): Use scope_exit.
7882
7883 2019-01-23  Tom Tromey  <tom@tromey.com>
7884             Pedro Alves  <palves@redhat.com>
7885
7886         * breakpoint.c (create_breakpoint): Remove cleanup.
7887
7888 2019-01-23  Tom Tromey  <tom@tromey.com>
7889             Andrew Burgess  <andrew.burgess@embecosm.com>
7890             Pedro Alves  <palves@redhat.com>
7891
7892 2019-01-23  Pedro Alves  <palves@redhat.com>
7893
7894         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7895
7896 2019-01-23  Pedro Alves  <palves@redhat.com>
7897             Andrew Burgess  <andrew.burgess@embecosm.com>
7898
7899         * gdbthread.h: Include "common/forward-scope-exit.h".
7900         (scoped_finish_thread_state): Redefine custom class in terms of
7901         forward_scope_exit.
7902
7903 2019-01-23  Pedro Alves  <palves@redhat.com>
7904             Andrew Burgess  <andrew.burgess@embecosm.com>
7905
7906         * common/forward-scope-exit.h: New file.
7907
7908 2019-01-23  Pedro Alves  <palves@redhat.com>
7909             Andrew Burgess  <andrew.burgess@embecosm.com>
7910             Tom Tromey  <tom@tromey.com>
7911
7912         * common/scope-exit.h: New file.
7913
7914 2019-01-23  Pedro Alves  <palves@redhat.com>
7915
7916         * common/preprocessor.h (ESC): Rename to ...
7917         (ESC_PARENS): ... this.
7918         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7919         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7920
7921 2019-01-23  Tom Tromey  <tom@tromey.com>
7922
7923         * language.h (class scoped_switch_to_sym_language_if_auto):
7924         Initialize m_lang in both cases.
7925
7926 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7927
7928         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7929         with XCNEW.
7930
7931 2019-01-22  Tom Tromey  <tom@tromey.com>
7932
7933         * corelow.c: Do not include sys/file.h.
7934
7935 2019-01-22  Tom Tromey  <tom@tromey.com>
7936
7937         * tui/tui-wingeneral.h: Include gdb_curses.h.
7938
7939 2019-01-22  Tom Tromey  <tom@tromey.com>
7940
7941         * source-cache.h (class source_cache) <get_source_lines,
7942         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7943
7944 2019-01-22  Tom Tromey  <tom@tromey.com>
7945
7946         * remote-fileio.h (struct remote_target): Declare.
7947
7948 2019-01-22  Tom Tromey  <tom@tromey.com>
7949
7950         * python/py-arch.c: Do not include py-ref.h.
7951         * python/py-bpevent.c: Do not include py-ref.h.
7952         * python/py-cmd.c: Do not include py-ref.h.
7953         * python/py-continueevent.c: Do not include py-ref.h.
7954         * python/py-event.h: Do not include py-ref.h.
7955         * python/py-evtregistry.c: Do not include py-ref.h.
7956         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7957         * python/py-frame.c: Do not include py-ref.h.
7958         * python/py-framefilter.c: Do not include py-ref.h.
7959         * python/py-function.c: Do not include py-ref.h.
7960         * python/py-infevents.c: Do not include py-ref.h.
7961         * python/py-linetable.c: Do not include py-ref.h.
7962         * python/py-objfile.c: Do not include py-ref.h.
7963         * python/py-param.c: Do not include py-ref.h.
7964         * python/py-prettyprint.c: Do not include py-ref.h.
7965         * python/py-progspace.c: Do not include py-ref.h.
7966         * python/py-symbol.c: Do not include py-ref.h.
7967         * python/py-symtab.c: Do not include py-ref.h.
7968         * python/py-type.c: Do not include py-ref.h.
7969         * python/py-unwind.c: Do not include py-ref.h.
7970         * python/py-utils.c: Do not include py-ref.h.
7971         * python/py-value.c: Do not include py-ref.h.
7972         * python/py-varobj.c: Do not include py-ref.h.
7973         * python/py-xmethods.c: Do not include py-ref.h.
7974         * python/python.c: Do not include py-ref.h.
7975         * varobj.c: Do not include py-ref.h.
7976
7977 2019-01-22  Tom Tromey  <tom@tromey.com>
7978
7979         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7980         keyword for bcache.
7981
7982 2019-01-22  Tom Tromey  <tom@tromey.com>
7983
7984         * compile/compile-cplus-types.c: Remove a comment by #include.
7985
7986 2019-01-22  Tom Tromey  <tom@tromey.com>
7987
7988         * compile/gcc-c-plugin.h: Include compile-internal.h.
7989
7990 2019-01-22  Tom Tromey  <tom@tromey.com>
7991
7992         * stabsread.c (EXTERN): Do not define.
7993         (symnum, next_symbol_text_func, processing_gcc_compilation)
7994         (within_function, global_sym_chain, global_stabs)
7995         (previous_stab_code, this_object_header_files)
7996         (n_this_object_header_files)
7997         (n_allocated_this_object_header_files): Define.
7998         * stabsread.h (EXTERN): Never define.  Use "extern".
7999
8000 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8001
8002         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8003         history_value.
8004
8005 2019-01-21  Tom Tromey  <tom@tromey.com>
8006
8007         * ui-out.c: Fix includes.
8008         * tui/tui-source.c: Fix includes.
8009         * target.c: Fix includes.
8010         * remote.c: Fix includes.
8011         * regcache.c: Fix includes.
8012         * python/py-block.c: Fix includes.
8013         * printcmd.c: Fix includes.
8014         * or1k-tdep.c: Fix includes.
8015         * mi/mi-main.c: Fix includes.
8016         * m32r-tdep.c: Fix includes.
8017         * csky-tdep.c: Fix includes.
8018         * compile/compile-cplus-types.c: Fix includes.
8019         * cli/cli-interp.c: Fix includes.
8020
8021 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8022
8023         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8024         for padding.
8025
8026 2019-01-16  Tom Tromey  <tom@tromey.com>
8027
8028         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8029         earlier.
8030         (struct objfile) <msymbols_range>: Move from top level.
8031         <msymbols>: New method.
8032         (class objfile_msymbols): Remove.
8033         * symtab.c (default_collect_symbol_completion_matches_break_on):
8034         Update.
8035         * symmisc.c (dump_msymbols): Update.
8036         * stabsread.c (scan_file_globals): Update.
8037         * objc-lang.c (info_selectors_command, info_classes_command)
8038         (find_methods): Update.
8039         * minsyms.c (find_solib_trampoline_target): Update.
8040         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8041         * coffread.c (coff_symfile_read): Update.
8042         * ada-lang.c (ada_lookup_simple_minsym)
8043         (ada_collect_symbol_completion_matches): Update.
8044
8045 2019-01-16  Tom Tromey  <tom@tromey.com>
8046
8047         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8048         type.  Remove no-argument constructor.
8049         <iterator::operator++>: Simplify.
8050         <begin>: Update.
8051         <end>: Use minimal_symbol_count.
8052
8053 2019-01-16  Tom Tromey  <tom@tromey.com>
8054
8055         * objfiles.h (struct objfile) <psymtabs>: New method.
8056         (class objfile_psymtabs): Remove.
8057         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8058         typedef.
8059         <range>: New method.
8060         (require_partial_symbols): Change return type.
8061         * psymtab.c (require_partial_symbols)
8062         (psym_expand_symtabs_matching): Update.
8063         * mdebugread.c (parse_partial_symbols): Update.
8064         * dbxread.c (dbx_end_psymtab): Update.
8065
8066 2019-01-15  Tom Tromey  <tom@tromey.com>
8067
8068         * symtab.c (lookup_objfile_from_block)
8069         (lookup_symbol_in_objfile_symtabs)
8070         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8071         (find_line_symtab, info_sources_command)
8072         (default_collect_symbol_completion_matches_break_on)
8073         (make_source_files_completion_list): Update.
8074         * symmisc.c (print_objfile_statistics, dump_objfile)
8075         (maintenance_print_symbols, maintenance_info_symtabs)
8076         (maintenance_check_symtabs, maintenance_info_line_tables):
8077         Update.
8078         * source.c (select_source_symtab)
8079         (forget_cached_source_info_for_objfile): Update.
8080         * objfiles.h (class objfile_compunits): Remove.
8081         (struct objfile) <compunits_range>: New typedef.
8082         (compunits): New method.
8083         * objfiles.c (objfile_relocate1): Update.
8084         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8085         * maint.c (count_symtabs_and_blocks): Update.
8086         * linespec.c (iterate_over_all_matching_symtabs): Update.
8087         * cp-support.c (add_symbol_overload_list_qualified): Update.
8088         * coffread.c (coff_symtab_read): Update.
8089         * ada-lang.c (add_nonlocal_symbols)
8090         (ada_collect_symbol_completion_matches)
8091         (ada_add_global_exceptions): Update.
8092
8093 2019-01-15  Tom Tromey  <tom@tromey.com>
8094
8095         * progspace.h (program_space) <objfiles_safe_range>: New
8096         typedef.
8097         <objfiles_safe>: New method.
8098         * objfiles.h (class all_objfiles_safe): Remove.
8099         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8100         * jit.c (jit_inferior_exit_hook): Update.
8101
8102 2019-01-17  Tom Tromey  <tom@tromey.com>
8103
8104         * progspace.h (program_space) <objfiles_range>: New typedef.
8105         <objfiles>: New method.
8106         <objfiles_head>: Rename from objfiles.
8107         (object_files): Update.
8108         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8109         * guile/scm-pretty-print.c
8110         (ppscm_find_pretty_printer_from_objfiles): Update.
8111         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8112         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8113         Update.
8114         * python/py-progspace.c (pspy_get_objfiles): Update.
8115         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8116         Update.
8117         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8118         (objfpy_lookup_objfile_by_build_id): Update.
8119         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8120         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8121         Update.
8122         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8123         (expand_symtab_containing_pc, lookup_objfile_from_block)
8124         (lookup_static_symbol, basic_lookup_transparent_type)
8125         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8126         (find_line_symtab, info_sources_command)
8127         (default_collect_symbol_completion_matches_break_on)
8128         (make_source_files_completion_list, find_main_name): Update.
8129         * symmisc.c (print_symbol_bcache_statistics)
8130         (print_objfile_statistics, maintenance_print_symbols)
8131         (maintenance_print_msymbols, maintenance_print_objfiles)
8132         (maintenance_info_symtabs, maintenance_check_symtabs)
8133         (maintenance_expand_symtabs, maintenance_info_line_tables):
8134         Update.
8135         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8136         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8137         (map_overlay_command, unmap_overlay_command)
8138         (simple_overlay_update, expand_symtabs_matching)
8139         (map_symbol_filenames): Update.
8140         * symfile-debug.c (set_debug_symfile): Update.
8141         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8142         Update.
8143         * source.c (select_source_symtab, forget_cached_source_info):
8144         Update.
8145         * solib.c (solib_read_symbols): Update.
8146         * solib-spu.c (append_ocl_sos): Update.
8147         * psymtab.c (maintenance_print_psymbols)
8148         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8149         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8150         * printcmd.c (info_symbol_command): Update.
8151         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8152         Update.
8153         * objfiles.h (class all_objfiles): Remove.
8154         * objfiles.c (have_partial_symbols, have_full_symbols)
8155         (have_minimal_symbols, qsort_cmp, update_section_map)
8156         (shared_objfile_contains_address_p)
8157         (default_iterate_over_objfiles_in_search_order): Update.
8158         * objc-lang.c (info_selectors_command, info_classes_command)
8159         (find_methods): Update.
8160         * minsyms.c (find_solib_trampoline_target): Update.
8161         * maint.c (maintenance_info_sections)
8162         (maintenance_translate_address, count_symtabs_and_blocks):
8163         Update.
8164         * main.c (captured_main_1): Update.
8165         * linux-thread-db.c (try_thread_db_load_from_pdir)
8166         (has_libpthread): Update.
8167         * linespec.c (iterate_over_all_matching_symtabs)
8168         (search_minsyms_for_name): Update.
8169         * jit.c (jit_find_objf_with_entry_addr): Update.
8170         * hppa-tdep.c (find_unwind_entry)
8171         (hppa_lookup_stub_minimal_symbol): Update.
8172         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8173         Update.
8174         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8175         (elf_gnu_ifunc_resolve_by_got): Update.
8176         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8177         * dwarf-index-write.c (save_gdb_index_command): Update.
8178         * cp-support.c (add_symbol_overload_list_qualified): Update.
8179         * breakpoint.c (create_overlay_event_breakpoint)
8180         (create_longjmp_master_breakpoint)
8181         (create_std_terminate_master_breakpoint)
8182         (create_exception_master_breakpoint): Update.
8183         * blockframe.c (find_pc_partial_function): Update.
8184         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8185         (ada_collect_symbol_completion_matches)
8186         (ada_add_global_exceptions): Update.
8187
8188 2019-01-17  Tom Tromey  <tom@tromey.com>
8189
8190         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8191         declare VEC.
8192         (solib_target_parse_libraries): Change return type.
8193         (library_list_start_segment, library_list_start_section)
8194         (library_list_end_library, library_list_start_library); Update.
8195         (solib_target_free_library_list): Remove.
8196         (solib_target_parse_libraries): Remove cleanup.  Change return
8197         type.
8198         (solib_target_current_sos): Update.
8199
8200 2019-01-17  Tom Tromey  <tromey@bapiya>
8201
8202         * valprint.c: Replace "the the" with "the".
8203         * symtab.c: Replace "the the" with "the".
8204         * solib.c: Replace "the the" with "the".
8205         * solib-dsbt.c: Replace "the the" with "the".
8206         * linespec.c: Replace "the the" with "the".
8207         * dwarf2loc.h: Replace "the the" with "the".
8208         * amd64-windows-tdep.c: Replace "the the" with "the".
8209         * aarch64-tdep.c: Replace "the the" with "the".
8210
8211 2019-01-16  Keith Seitz  <keiths@redhat.com>
8212
8213         PR gdb/23773
8214         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8215         <builder>: Rename to ..
8216         <m_builder>: ... this and make private.
8217         (dwarf2_cu::get_builder): New method.  Change all users of
8218         `builder' to use this method.
8219         (dwarf2_start_symtab): Move to ...
8220         (dwarf2_cu::start_symtab): ... here.  Update all callers
8221         (setup_type_unit_groups): Move to ...
8222         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8223         callers.
8224         (dwarf2_cu::reset_builder): New method.
8225         (process_full_compunit, process_full_type_unit): Use
8226         dwarf2_cu::reset_builder.
8227         (follow_die_offset): Record the ancestor CU if it is different
8228         from the followed DIE's CU.
8229         (follow_die_sig_1): Likewise.
8230
8231 2019-01-15  Tom Tromey  <tom@tromey.com>
8232
8233         * remote.c (class remote_state) <buf>: Now a char_vector.
8234         <buf_size>: Remove.
8235         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8236         parameter.
8237         (remote_target::getpkt_or_notif_sane_1)
8238         (remote_target::getpkt_sane)
8239         (remote_target::getpkt_or_notif_sane): Likewise.
8240         (class remote_target) <putpkt>: New overload.
8241         (remote_target::read_frame): Change type of "buf_p".  Remove
8242         sizeof_p parameter.
8243         (packet_ok): New overload.
8244         (packet_check_result): New overload.
8245         Update all uses.
8246
8247 2019-01-14  Tom Tromey  <tom@tromey.com>
8248
8249         * remote-notif.c (handle_notification, remote_notif_ack)
8250         (remote_notif_parse): Make "buf" const.
8251         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8252         const.
8253         (remote_notif_parse, remote_notif_ack, handle_notification):
8254         Likewise.
8255         * remote.c (remote_notif_stop_parse): Make "buf" const.
8256         (remote_target::remote_parse_stop_reply): Make "buf" const.
8257         (remote_notif_stop_ack): Make "buf" const.
8258
8259 2019-01-14  Tom Tromey  <tom@tromey.com>
8260
8261         * remote.c (remote_console_output): Make parameter const.
8262
8263 2019-01-14  Tom Tromey  <tom@tromey.com>
8264
8265         * target-debug.h (target_debug_print_signals): Constify.
8266         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8267         * procfs.c (procfs_target::pass_signals): Update.
8268         * linux-nat.c (linux_nat_target::pass_signals): Update.
8269         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8270         * target-delegates.c: Rebuild.
8271         * remote.c (remote_target::program_signals): Update.
8272         (remote_target::pass_signals): Update.
8273         * target.c (target_pass_signals): Constify argument.
8274         (target_program_signals): Likewise.
8275         * target.h (struct target_ops) <pass_signals, program_signals>:
8276         Constify argument.
8277         (target_pass_signals, target_program_signals): Constify argument.
8278
8279 2019-01-14  Tom Tromey  <tom@tromey.com>
8280
8281         PR tui/28819:
8282         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8283
8284 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8285
8286         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8287         field.
8288         * rs6000-tdep.c: Include reggroups.h.
8289         (IS_V_ALIAS_PSEUDOREG): Define.
8290         (rs6000_register_name): Return names for the "vX" aliases.
8291         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8292         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8293         aliases.  Call default_register_reggroup_p for all other
8294         pseudo-registers.
8295         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8296         New functions.
8297         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8298         Handle "vX" aliases.
8299         (v_alias_pseudo_register_collect): New function.
8300         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8301         (rs6000_gdbarch_init): Initialize "vX" aliases as
8302         pseudo-registers.  Restore registration of
8303         rs6000_pseudo_register_reggroup_p with
8304         set_tdesc_pseudo_register_reggroup_p.
8305
8306 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8307
8308         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8309         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8310         set_gdbarch_num_pseudo_regs.
8311
8312 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8313
8314         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8315         Remove arg prefixname, add do_set and do_show.
8316         Add member functions set_list and show_list.
8317         * cli/cli-style.c (class cli_style_option): Update accordingly.
8318         (style_set_list): Move to file scope.
8319         (style_show_list): Likewise.
8320         (set_style): Call help_list.
8321         (show_style): Call cmd_show_list.
8322         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8323         Update to use the new macro.
8324
8325 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8326
8327         * ada-lang.c (_initialize_ada_language): Expand the help text
8328         for the "catch exception" command.
8329
8330 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8331
8332         * symtab.c (matching_obj_sections): Initialize obj,
8333         declare it closer to its usage.
8334
8335 2019-01-10  Tom Tromey  <tom@tromey.com>
8336
8337         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8338         (basic_inf_threads_range): Remove.
8339         (inf_threads_range, inf_non_exited_threads_range)
8340         (safe_inf_threads_range): Use next_adapter.
8341
8342 2019-01-10  Keith Seitz  <keiths@redhat.com>
8343
8344         PR gdb/23712
8345         PR symtab/23010
8346         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8347         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8348
8349 2019-01-10  Keith Seitz  <keiths@redhat.com>
8350
8351         PR gdb/23712
8352         PR symtab/23010
8353         * dictionary.c (pending_to_vector): Remove.
8354         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8355         Remove _1 suffix, replacing functions of the same name.  Update
8356         all callers.
8357         (dict_create_hashed, dict_create_hashed_expandable)
8358         (dict_create_linear, dict_create_linear_expandable, dict_free)
8359         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8360         Make functions static.
8361
8362 2019-01-10  Keith Seitz  <keiths@redhat.com>
8363
8364         PR gdb/23712
8365         PR symtab/23010
8366         * dictionary.h (struct dictionary): Replace declaration with
8367         multidictionary.
8368         (dict_create_hashed, dict_create_hashed_expandable)
8369         (dict_create_linear, dict_create_linear_expandable)
8370         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8371         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8372         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8373         taking multidictionary argument.
8374         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8375         * block.h (struct block) <dict>: Change to multidictionary
8376         and rename `multidict'.
8377         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8378         symmisc.c: Update all dictionary references to multidictionary.
8379
8380 2019-01-10  Keith Seitz  <keiths@redhat.com>
8381
8382         PR gdb/23712
8383         PR symtab/23010
8384         * dictionary.c: Include unordered_map.
8385         (pending_to_vector): New function.
8386         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8387         Rewrite the non-"_1" functions to take vector instead
8388         of linked list.
8389         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8390         "new" _1 versions of the same name.
8391         (multidictionary): Define.
8392         (std::hash<enum language): New definition.
8393         (collate_pending_symbols_by_language, mdict_create_hashed)
8394         (mdict_create_hashed_expandable, mdict_create_linear)
8395         (mdict_create_linear_expandable, mdict_free)
8396         (find_language_dictionary, create_new_language_dictionary)
8397         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8398         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8399         (mdict_size, mdict_empty): New functions.
8400         * dictionary.h (mdict_iterator): Define.
8401
8402 2019-01-10  Pedro Alves  <palves@redhat.com>
8403
8404         * breakpoint.c (read_uploaded_action)
8405         (create_tracepoint_from_upload): Adjust to use
8406         gdb::unique_xmalloc_ptr.
8407         * ctf.c (ctf_write_uploaded_tp):
8408         (SET_ARRAY_FIELD): Use emplace_back.
8409         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8410         * tracefile-tfile.c (tfile_write_uploaded_tp):
8411         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8412         gdb::unique_xmalloc_ptr.
8413         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8414         at_string, cond_string, cmd_strings>: Replace char pointers
8415         with gdb::unique_xmalloc_ptr.
8416
8417 2019-01-10  Pedro Alves  <palves@redhat.com>
8418
8419         * solib-target.c (library_list_start_library): Don't xstrdup name.
8420
8421 2019-01-10  Pedro Alves  <palves@redhat.com>
8422
8423         * mdebugread.c (parse_partial_symbols): Use
8424         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8425
8426 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8427
8428         * linux-fork.c (scoped_switch_fork_info)
8429         <~scoped_switch_fork_info>: Fix incorrect variable name.
8430
8431 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8432
8433         * linux-fork.c (scoped_switch_fork_info)
8434         <scoped_switch_fork_info>: Make explicit.
8435         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8436
8437 2019-01-10  Tom Tromey  <tom@tromey.com>
8438
8439         * objfiles.h (objfile::reset_psymtabs): Update.
8440         * objfiles.c (objfile::objfile): Update.
8441         * psymtab.h (psymtab_storage::obstack): Update.
8442         (psymtab_storage::m_obstack): Use gdb::optional.
8443         (class psymtab_storage): Update comment.  Remove objfile
8444         parameter.
8445         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8446
8447 2019-01-10  Tom Tromey  <tom@tromey.com>
8448
8449         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8450         <free_psymtabs>: Now private.
8451         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8452         (allocate_psymtab): Use new method.
8453
8454 2019-01-10  Tom Tromey  <tom@tromey.com>
8455
8456         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8457         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8458         * mdebugread.c (parse_partial_symbols): Use
8459         allocate_dependencies.
8460         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8461         allocate_dependencies.
8462         (process_psymtab_comp_unit_reader)
8463         (build_type_psymtab_dependencies): Likewise.
8464         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8465
8466 2019-01-10  Tom Tromey  <tom@tromey.com>
8467
8468         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8469         PSYMBOL_SET_LANGUAGE.
8470         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8471
8472 2019-01-10  Tom Tromey  <tom@tromey.com>
8473
8474         * psymtab.h (psymtab_storage::obstack): New method.
8475         <m_obstack>: Rename from obstack; now private.
8476         * psymtab.c (psymtab_storage): Update.
8477         * dwarf2read.c (create_addrmap_from_index)
8478         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8479         Update.
8480
8481 2019-01-10  Tom Tromey  <tom@tromey.com>
8482
8483         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8484         * objfiles.h (objfile::reset_psymtabs): New method.
8485
8486 2019-01-10  Tom Tromey  <tom@tromey.com>
8487
8488         * symmisc.c (print_symbol_bcache_statistics): Update.
8489         (print_objfile_statistics): Update.
8490         * symfile.c (reread_symbols): Update.
8491         * psymtab.h (class psymtab_storage): New.
8492         * psymtab.c (psymtab_storage): New constructor.
8493         (~psymtab_storage): New destructor.
8494         (require_partial_symbols): Update.
8495         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8496         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8497         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8498         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8499         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8500         (start_psymtab_common, end_psymtab_common)
8501         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8502         (allocate_psymtab): Update.
8503         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8504         Update.
8505         (dump_psymtab_addrmap, maintenance_print_psymbols)
8506         (maintenance_check_psymtabs): Update.
8507         (class objfile_psymtabs): Move to objfiles.h.
8508         * psympriv.h (discard_psymtab): Now inline.
8509         (psymtab_discarder::psymtab_discarder): Update.
8510         (psymtab_discarder::~psymtab_discarder): Update.
8511         (ALL_OBJFILE_PSYMTABS): Rewrite.
8512         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8513         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8514         Remove fields.
8515         <partial_symtabs>: New field.
8516         (class objfile_psymtabs): Move from psymtab.h.  Update.
8517         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8518         psymbol_cache.
8519         (objfile::~objfile): Don't destroy psymbol_cache.
8520         * mdebugread.c (parse_partial_symbols): Update.
8521         * dwarf2read.c (create_addrmap_from_index)
8522         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8523         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8524         (add_partial_subprogram, dwarf2_ranges_read): Update.
8525         * dwarf-index-write.c (write_address_map)
8526         (write_one_signatured_type, recursively_write_psymbols)
8527         (class debug_names, class debug_names, write_psymtabs_to_index):
8528         Update.
8529
8530 2019-01-10  Tom Tromey  <tom@tromey.com>
8531
8532         * symtab.h (SYMBOL_SET_NAMES): Update.
8533         (symbol_set_names): Update.
8534         (MSYMBOL_SET_NAMES): Update.
8535         * symtab.c (symbol_set_names): Change argument to be an
8536         objfile_per_bfd_storage.
8537         * psymtab.c (add_psymbol_to_bcache): Update.
8538         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8539
8540 2019-01-10  Tom Tromey  <tom@tromey.com>
8541
8542         * symtab.c (create_demangled_names_hash): Change argument to be an
8543         objfile_per_bfd_storage.
8544         (symbol_set_names): Update.
8545
8546 2019-01-10  Tom Tromey  <tom@tromey.com>
8547
8548         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8549         init_psymbol_list.
8550         * psymtab.c (init_psymbol_list): Do nothing if already called.
8551         * psympriv.h (init_psymbol_list): Add comment.
8552         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8553         init_psymbol_list.
8554         * dbxread.c (dbx_symfile_read): Unconditionally call
8555         init_psymbol_list.
8556
8557 2019-01-10  Tom Tromey  <tom@tromey.com>
8558
8559         * xcoffread.c (scan_xcoff_symtab): Update.
8560         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8561         "where".
8562         * mdebugread.c (parse_partial_symbols)
8563         (handle_psymbol_enumerators): Update.
8564         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8565         * dbxread.c (read_dbx_symtab): Update.
8566         * psympriv.h (psymbol_placement): New enum.
8567         (add_psymbol_to_list): Update.
8568
8569 2019-01-10  Tom Tromey  <tom@tromey.com>
8570
8571         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8572         static_psymbols parameters.
8573         (scan_xcoff_symtab): Update.
8574         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8575         static_psymbols parameters.
8576         * psympriv.h (start_psymtab_common): Update.
8577         * mdebugread.c (parse_partial_symbols): Update.
8578         * dwarf2read.c (create_partial_symtab): Update.
8579         * dbxread.c (read_dbx_symtab): Update.
8580         (start_psymtab): Remove global_psymbols and static_psymbols
8581         parameters.
8582
8583 2019-01-10  Tom Tromey  <tom@tromey.com>
8584
8585         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8586         * psymtab.c (allocate_psymtab): Add comment.
8587         * psympriv.h (allocate_psymtab): Add comment.
8588         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8589         initializations.
8590         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8591
8592 2019-01-10  Tom Tromey  <tom@tromey.com>
8593
8594         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8595         Don't declare.
8596         * mipsread.c: Include mdebugread.h.
8597         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8598         Declare.
8599         * elfread.c: Include mdebugread.h.
8600
8601 2019-01-09  Tom Tromey  <tom@tromey.com>
8602
8603         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8604         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8605         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8606         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8607         (psym_lookup_symbol, psym_find_last_source_symtab)
8608         (psym_forget_cached_source_info, psym_print_stats)
8609         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8610         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8611         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8612         (psym_find_compunit_symtab_by_address)
8613         (maintenance_print_psymbols, maintenance_info_psymtabs)
8614         (maintenance_check_psymtabs): Use ranged for.
8615         * psymtab.h (class objfile_psymtabs): New.
8616         (require_partial_symbols): Return objfile_psymtabs.
8617         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8618
8619 2019-01-09  Tom Tromey  <tom@tromey.com>
8620
8621         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8622         (find_pc_mapped_section, list_overlays_command)
8623         (map_overlay_command, unmap_overlay_command)
8624         (simple_overlay_update): Use all_objfiles.
8625         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8626         * printcmd.c (info_symbol_command): Use all_objfiles.
8627         * objfiles.h (ALL_OBJSECTIONS): Remove.
8628         * maint.c (maintenance_translate_address): Use all_objfiles.
8629         * gcore.c (gcore_create_callback): Use all_objfiles.
8630         (objfile_find_memory_regions): Likewise.
8631
8632 2019-01-09  Tom Tromey  <tom@tromey.com>
8633
8634         * symtab.c (find_line_symtab, info_sources_command)
8635         (make_source_files_completion_list): Use objfile_compunits.
8636         * source.c (select_source_symtab): Use objfile_compunits.
8637         * objfiles.h (struct objfile): Update comment.
8638         (ALL_OBJFILES): Remove.
8639         (ALL_FILETABS): Remove.
8640         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8641         objfile_compunits.
8642
8643 2019-01-09  Tom Tromey  <tom@tromey.com>
8644
8645         * symmisc.c (print_objfile_statistics, dump_objfile)
8646         (maintenance_print_symbols): Use compunit_filetabs.
8647         * source.c (forget_cached_source_info_for_objfile): Use
8648         compunit_filetabs.
8649         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8650         (ALL_FILETABS): Use compunit_filetabs.
8651         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8652         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8653
8654 2019-01-09  Tom Tromey  <tom@tromey.com>
8655
8656         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8657         (compunit_filetabs): New.
8658         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8659         compunit_filetabs.
8660         (info_sources_command, make_source_files_completion_list): Remove
8661         declaration.
8662         * symmisc.c (print_objfile_statistics, dump_objfile)
8663         (maintenance_print_symbols): Remove declaration.
8664         (maintenance_info_symtabs): Use compunit_filetabs.
8665         (maintenance_info_line_tables): Likewise.
8666         * source.c (select_source_symtab): Change local variable name.
8667         (forget_cached_source_info_for_objfile): Remove declaration.
8668         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8669         * objfiles.c (objfile_relocate1): Remove declaration.
8670         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8671         declaration.
8672         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8673         * coffread.c (coff_symtab_read): Remove declaration.
8674         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8675         compunit_filetabs.
8676
8677 2019-01-09  Tom Tromey  <tom@tromey.com>
8678
8679         * symtab.c (lookup_objfile_from_block)
8680         (find_pc_sect_compunit_symtab, search_symbols)
8681         (default_collect_symbol_completion_matches_break_on): Use
8682         objfile_compunits.
8683         * objfiles.h (ALL_COMPUNITS): Remove.
8684         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8685         * cp-support.c (add_symbol_overload_list_qualified): Use
8686         objfile_compunits.
8687         * ada-lang.c (ada_collect_symbol_completion_matches)
8688         (ada_add_global_exceptions): Use objfile_compunits.
8689
8690 2019-01-09  Tom Tromey  <tom@tromey.com>
8691
8692         * source.c (select_source_symtab)
8693         (forget_cached_source_info_for_objfile): Remove declaration.
8694         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8695         declaration.
8696         * maint.c (count_symtabs_and_blocks): Remove declaration.
8697         * cp-support.c (add_symbol_overload_list_qualified): Remove
8698         declaration.
8699         * coffread.c (coff_symtab_read): Remove declaration.
8700         * symtab.c (lookup_symbol_in_objfile_symtabs)
8701         (basic_lookup_transparent_type_1): Use objfile_compunits.
8702         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8703         (info_sources_command, search_symbols)
8704         (default_collect_symbol_completion_matches_break_on)
8705         (make_source_files_completion_list): Remove declaration.
8706         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8707         (ada_collect_symbol_completion_matches)
8708         (ada_add_global_exceptions): Remove declaration.
8709         * linespec.c (iterate_over_all_matching_symtabs): Use
8710         objfile_compunits.
8711         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8712         (class objfile_compunits): New.
8713         (ALL_COMPUNITS): Use objfile_compunits.
8714         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8715         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8716         objfile_compunits.
8717         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8718
8719 2019-01-09  Tom Tromey  <tom@tromey.com>
8720
8721         * symtab.c (search_symbols)
8722         (default_collect_symbol_completion_matches_break_on): Use
8723         objfile_msymbols.
8724         * ada-lang.c (ada_lookup_simple_minsym)
8725         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8726         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8727         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8728         objfile_msymbols.
8729         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8730         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8731         * objc-lang.c (find_methods): Use objfile_msymbols.
8732         (info_selectors_command, info_classes_command): Likewise.
8733         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8734         * objfiles.h (class objfile_msymbols): New.
8735         (ALL_OBJFILE_MSYMBOLS): Remove.
8736         (ALL_MSYMBOLS): Remove.
8737
8738 2019-01-09  Tom Tromey  <tom@tromey.com>
8739
8740         * common/next-iterator.h (next_adapter): Add Iterator template
8741         parameter.
8742         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8743         (class all_objfiles_safe): New.
8744         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8745         * objfiles.c (put_objfile_before): Update comment.
8746         (add_separate_debug_objfile): Likewise.
8747         (free_all_objfiles): Use all_objfiles_safe.
8748         (objfile_purge_solibs): Likewise.
8749
8750 2019-01-09  Tom Tromey  <tom@tromey.com>
8751
8752         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8753         (expand_symtab_containing_pc, lookup_static_symbol)
8754         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8755         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8756         all_objfiles.
8757         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8758         * breakpoint.c (create_overlay_event_breakpoint)
8759         (create_longjmp_master_breakpoint)
8760         (create_std_terminate_master_breakpoint)
8761         (create_exception_master_breakpoint): Use all_objfiles.
8762         * linux-thread-db.c (try_thread_db_load_from_pdir)
8763         (has_libpthread): Use all_objfiles.
8764         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8765         * linespec.c (iterate_over_all_matching_symtabs)
8766         (search_minsyms_for_name): Use all_objfiles.
8767         * maint.c (maintenance_info_sections): Use all_objfiles.
8768         * main.c (captured_main_1): Use all_objfiles.
8769         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8770         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8771         * guile/scm-pretty-print.c
8772         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8773         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8774         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8775         (maintenance_print_msymbols): Use all_objfiles.
8776         * source.c (select_source_symtab): Use all_objfiles.
8777         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8778         * symfile.c (remove_symbol_file_command)
8779         (expand_symtabs_matching, map_symbol_filenames): Use
8780         all_objfiles.
8781         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8782         all_objfiles.
8783         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8784         * objc-lang.c (find_methods): Use all_objfiles.
8785         * objfiles.c (have_partial_symbols, have_full_symbols)
8786         (have_minimal_symbols, qsort_cmp)
8787         (default_iterate_over_objfiles_in_search_order): Use
8788         all_objfiles.
8789         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8790         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8791         (maintenance_check_psymtabs): Use all_objfiles.
8792         (ALL_PSYMTABS): Remove.
8793         * compile/compile-object-run.c (do_module_cleanup): Use
8794         all_objfiles.
8795         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8796         * cp-support.c (add_symbol_overload_list_qualified): Use
8797         all_objfiles.
8798         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8799         Use all_objfiles.
8800         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8801         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8802         all_objfiles.
8803         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8804         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8805         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8806         Uses all_objfiles.
8807         * solib.c (solib_read_symbols): Use all_objfiles
8808
8809 2019-01-09  Tom Tromey  <tom@tromey.com>
8810
8811         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8812         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8813         all_objfiles.
8814         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8815         * symmisc.c (print_symbol_bcache_statistics)
8816         (print_objfile_statistics, maintenance_print_objfiles)
8817         (maintenance_info_symtabs, maintenance_check_symtabs)
8818         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8819         all_objfiles.
8820         * source.c (forget_cached_source_info): Use all_objfiles.
8821         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8822         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8823         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8824         * objfiles.c (update_section_map): Use all_objfiles.
8825         (shared_objfile_contains_address_p): Likewise.
8826         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8827         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8828
8829 2019-01-09  Tom Tromey  <tom@tromey.com>
8830
8831         * common/next-iterator.h: New file.
8832         * objfiles.h (class all_objfiles): New.
8833         (struct objfile_iterator): New.
8834
8835 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8836
8837         * NEWS: Move the description of the changed "frame", "select-frame",
8838          and "info frame" commands to the Changed commands section.
8839
8840 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8841
8842         * gdbtypes.c (check_stub_method_group): Remove handling of old
8843         mangling schemes.
8844         * linespec.c (find_methods): Likewise.
8845         * stabsread.c (read_member_functions): Likewise.
8846         * valops.c (search_struct_method): Likewise.
8847         (value_struct_elt_for_reference): Likewise.
8848         * NEWS: Mention this change.
8849
8850 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8851
8852         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8853         print_source_lines.
8854         * source.c (print_source_lines_base): Update line number check.
8855         (print_source_lines): New function.
8856         (source_lines_range::source_lines_range): New function.
8857         * source.h (class source_lines_range): New class.
8858         (print_source_lines): New declaration.
8859
8860 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8861
8862         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8863
8864 2019-01-08  Tom Tromey  <tom@tromey.com>
8865             Simon Marchi  <simon.marchi@ericsson.com>
8866
8867         PR gdb/24060
8868         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8869         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8870         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8871         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8872         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8873         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8874
8875 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8876
8877         * source.c (select_source_symtab): Move header comment to
8878         declaration in source.h.
8879         (forget_cached_source_info_for_objfile): Likewise.
8880         (forget_cached_source_info): Likewise.
8881         (identify_source_line): Likewise.
8882         * source.h (identify_source_line): Move declaration from symtab.h
8883         and add comment from source.c
8884         (print_source_lines): Likewise.
8885         (forget_cached_source_info_for_objfile): Likewise.
8886         (forget_cached_source_info): Likewise.
8887         (select_source_symtab): Likewise.
8888         (enum print_source_lines_flag): Move definition from symtab.h.
8889         * symtab.h (identify_source_line): Move declaration to source.h.
8890         (print_source_lines): Likewise.
8891         (forget_cached_source_info_for_objfile): Likewise.
8892         (forget_cached_source_info): Likewise.
8893         (select_source_symtab): Likewise.
8894         (enum print_source_lines_flag): Move definition to source.h.
8895         * tui/tui-hooks.c: Add 'source.h' include.
8896
8897 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8898
8899         * source.c (print_source_lines_base): Handle requests to print
8900         reverse line number sequences, and guard against empty lines
8901         string.
8902
8903 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8904
8905         * source.c (print_source_lines_base): Fix skip of '\r' if next
8906         character is '\n'.
8907
8908 2019-01-06  Tom Tromey  <tom@tromey.com>
8909
8910         * c-exp.y (struct c_parse_state) <macro_original_text,
8911         expansion_obstack>: New member.
8912         (macro_original_text, expansion_obstack): Remove globals.
8913         (scan_macro_expansion, scanning_macro_expansion)
8914         (finished_macro_expansion): Update.
8915         (scan_macro_cleanup): Remove.
8916         (yylex, c_parse): Update.
8917
8918 2019-01-06  Tom Tromey  <tom@tromey.com>
8919
8920         * c-exp.y (struct c_parse_state) <strings>: New member.
8921         (operator_stoken): Update.
8922
8923 2019-01-06  Tom Tromey  <tom@tromey.com>
8924
8925         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8926         (union type_stack_elt) <typelist_val>: Now a pointer to
8927         std::vector.
8928         (type_stack_cleanup): Don't declare.
8929         (push_typelist): Update.
8930         * parse.c (pop_typelist): Return a std::vector.
8931         (push_typelist): Take a std::vector.
8932         (follow_types): Update.  Do not free args.
8933         (type_stack_cleanup): Remove.
8934         * c-exp.y (struct c_parse_state): New.
8935         (cpstate): New global.
8936         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8937         (nonempty_typelist): Update.
8938         (func_mod): Create a new vector.
8939         (c_parse): Create a c_parse_state.
8940         (check_parameter_typelist): Do not delete params.
8941         (function_method): Update.  Do not delete type_list.
8942
8943 2019-01-06  Tom Tromey  <tom@tromey.com>
8944
8945         PR gdb/28155:
8946         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8947         check_typedef.
8948         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8949         (print_return_value): Likewise.
8950
8951 2019-01-05  Tom Tromey  <tom@tromey.com>
8952
8953         * contrib/cleanup_check.py: Remove.
8954         * contrib/gcc-with-excheck: Remove.
8955         * contrib/exsummary.py: Remove.
8956         * contrib/excheck.py: Remove.
8957
8958 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8959
8960         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8961         NULL. Initialize tpprev to NULL instead of assigning it
8962         to NULL on the next statement.
8963         * windows-nat.c (windows_delete_thread): Remove check for
8964         main_thread_id before printing thread exit notifications.
8965         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8966         Remove thread ID check against main_thread_id.
8967         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8968         windows_delete_thread.
8969         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8970
8971 2019-01-04  Tom Tromey  <tom@tromey.com>
8972
8973         * compile/compile.c (_initialize_compile): Use upper case for
8974         metasyntactic variables.
8975         * symmisc.c (_initialize_symmisc): Use upper case for
8976         metasyntactic variables.
8977         * psymtab.c (_initialize_psymtab): Use upper case for
8978         metasyntactic variables.
8979         * demangle.c (demangle_command): Use upper case for metasyntactic
8980         variables.
8981         (_initialize_demangler): Likewise.
8982         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8983         variables.
8984
8985 2019-01-03  Tom Tromey  <tom@tromey.com>
8986
8987         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8988
8989 2019-01-03  Tom Tromey  <tom@tromey.com>
8990
8991         * python/py-symtab.c (salpy_str): Update.
8992         (struct salpy_sal_object) <symtab>: Now a PyObject.
8993         (salpy_dealloc): Update.
8994         (del_objfile_sal): Use gdbpy_ref.
8995
8996 2019-01-03  Tom Tromey  <tom@tromey.com>
8997
8998         * python/py-type.c (convert_field): Use new_reference.  Return
8999         gdbpy_ref.
9000         (make_fielditem): Return gdbpy_ref.
9001         (typy_fields): Update.
9002         (typy_getitem): Update.
9003         (field_name): Return gdbpy_ref.  Use new_reference.
9004         (typy_iterator_iternext): Update.
9005
9006 2019-01-03  Tom Tromey  <tom@tromey.com>
9007
9008         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9009
9010 2019-01-03  Tom Tromey  <tom@tromey.com>
9011
9012         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9013         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9014         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9015         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9016         (pspy_set_type_printers): Likewise.
9017         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9018         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9019         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9020         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9021         (objfpy_set_type_printers): Likewise.
9022
9023 2019-01-03  Tom Tromey  <tom@tromey.com>
9024
9025         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9026         (gdbpy_print_stack): Use gdbpy_err_fetch.
9027         * python/python-internal.h (class gdbpy_err_fetch): New class.
9028         (class gdbpy_enter) <m_error_type, m_error_value,
9029         m_error_traceback>: Remove.
9030         <m_error>: New member.
9031         (gdbpy_exception_to_string): Don't declare.
9032         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9033         * python/py-value.c (convert_value_from_python): Use
9034         gdbpy_err_fetch.
9035         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9036         gdbpy_exception_to_string.
9037         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9038         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9039         gdbpy_err_fetch.
9040
9041 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9042
9043         * linux-nat.c (delete_lwp_cleanup): Delete.
9044         (struct lwp_deleter): New struct.
9045         (lwp_info_up): New typedef.
9046         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9047         lwp_info_up.
9048
9049 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9050
9051         * linux-fork.c (class scoped_switch_fork_info): New class.
9052         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9053
9054 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9055
9056         * valops.c (find_overload_match): Remove use of null_cleanup, and
9057         calls to do_cleanups.
9058
9059 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9060
9061         * compile/compile-cplus-types.c
9062         (compile_cplus_instance::decl_name): Handle changes to
9063         cp_func_name.
9064         * cp-support.c (cp_func_name): Update header comment, update
9065         return type.
9066         * cp-support.h (cp_func_name): Update return type in declaration.
9067         * valops.c (find_overload_match): Move temp_func local to top
9068         level of function and change its type.  Use temp_func to hold and
9069         delete temporary string obtained from cp_func_name.
9070
9071 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9072
9073         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9074         gdb::char_vector, remove cleanup, and update uses of `msg`.
9075
9076 2019-01-03  Jim Wilson  <jimw@sifive.com>
9077
9078         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9079
9080 2019-01-02  Tom Tromey  <tom@tromey.com>
9081
9082         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9083         (tdesc_parse_xml): Remove cleanups.
9084         * target-descriptions.h (make_cleanup_free_target_description):
9085         Don't declare.
9086         (target_desc_deleter): New struct.
9087         (target_desc_up): New typedef.
9088         * target-descriptions.c (target_desc_deleter::operator()): Rename
9089         from free_target_description.
9090         (make_cleanup_free_target_description): Remove.
9091
9092 2019-01-02  Tom Tromey  <tom@tromey.com>
9093
9094         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9095         constructor, destructor.
9096         (linespec_parser): Remove typedef.
9097         (~linespec_parser): Rename from linespec_parser_delete.
9098         (linespec_lex_to_end, linespec_complete_label)
9099         (linespec_complete): Update.
9100         (decode_line_full): Remove cleanups.
9101         (decode_line_1): Update.
9102
9103 2019-01-02  Tom Tromey  <tom@tromey.com>
9104
9105         * python/python-internal.h (inferior_to_inferior_object): Change
9106         return type.
9107         * python/py-exitedevent.c (create_exited_event_object): Update.
9108         * python/py-inferior.c (inferior_to_inferior_object): Return
9109         gdbpy_ref.
9110         (python_new_inferior, python_inferior_deleted)
9111         (thread_to_thread_object, delete_thread_object)
9112         (build_inferior_list, gdbpy_selected_inferior): Update.
9113         * python/py-infthread.c (create_thread_object): Update.  Also fail
9114         if inferior_to_inferior_object fails.
9115
9116 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9117
9118         * inferior.h (class inferior) <displaced_step_state>: New field.
9119         * infrun.h (struct displaced_step_state): Move here from
9120         infrun.c.  Initialize fields, add constructor.
9121         <inf>: Remove field.
9122         <reset>: New method.
9123         * infrun.c (struct displaced_step_inferior_state): Move to
9124         infrun.h.
9125         (displaced_step_inferior_states): Remove.
9126         (get_displaced_stepping_state): Adust.
9127         (displaced_step_in_progress_any_inferior): Adjust.
9128         (displaced_step_in_progress_thread): Adjust.
9129         (displaced_step_in_progress): Adjust.
9130         (add_displaced_stepping_state): Remove.
9131         (get_displaced_step_closure_by_addr): Adjust.
9132         (remove_displaced_stepping_state): Remove.
9133         (infrun_inferior_exit): Call displaced_step_state.reset.
9134         (use_displaced_stepping): Don't check for NULL.
9135         (displaced_step_prepare_throw): Call
9136         get_displaced_stepping_state.
9137         (displaced_step_fixup): Don't check for NULL.
9138         (prepare_for_detach): Don't check for NULL.
9139
9140 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9141
9142         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9143          in case of call that did not complete.
9144
9145 2019-01-02  Andrey Utkin  <autkin@undo.io>
9146
9147         * symfile.c (find_separate_debug_file): Fix search of debug files for
9148         remote debuggee.
9149
9150 2019-01-02  Tom Tromey  <tom@tromey.com>
9151
9152         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9153         indentation.
9154         * python/py-frame.c (frapy_older): Remove cast.
9155         (frapy_newer): Likewise.
9156         * python/py-breakpoint.c (local_setattro): Remove cast.
9157         * python/py-arch.c (archpy_name): Remove local variable.
9158         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9159
9160 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9161
9162         * unittests/basic_string_view/element_access/char/empty.cc:
9163         Fix year range in copyright header.
9164
9165 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9166
9167         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9168         Delete.
9169         <operator==>: Update with for removed field.
9170         <hash>: Likewise.
9171         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9172         <isa_features>: ...this.
9173         <abi_features>: New field.
9174         (riscv_isa_flen): Update comment.
9175         (riscv_abi_xlen): New declaration.
9176         (riscv_abi_flen): New declaration.
9177         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9178         isa_features.
9179         (riscv_abi_xlen): New function.
9180         (riscv_isa_flen): Update to get answer from isa_features.
9181         (riscv_abi_flen): New function.
9182         (riscv_has_fp_abi): Update to get answer from abi_features.
9183         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9184         xlen and flen.
9185         (riscv_call_info) <xlen, flen>: Update comment.
9186         (riscv_call_arg_struct): Remove invalid assertions
9187         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9188         is removed.
9189         (riscv_gdbarch_init): Gather isa features and abi features
9190         separately, ensure both match on the gdbarch when reusing an old
9191         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9192         a target with 64-bit float hardware.
9193
9194 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9195
9196         * source.c (search_command_helper): Stop reverse search
9197         when line 1 has been searched.
9198
9199 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9200
9201         * record-full.c (record_full_base_target::close): Rewrite
9202         record_full_core_buf_list free logic.
9203
9204 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9205
9206         * break-catch-syscall.c (print_one_catch_syscall): xfree
9207         the last text.
9208
9209 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9210
9211         * top.c (print_gdb_version): Update Copyright year in version
9212         message.
9213
9214 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9215
9216         Update copyright year range in all GDB files.
9217
9218 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9219
9220         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9221
9222 For older changes see ChangeLog-2018.
9223 \f
9224 Local Variables:
9225 mode: change-log
9226 left-margin: 8
9227 fill-column: 74
9228 version-control: never
9229 coding: utf-8
9230 End:
9231