gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.c (tui_show_registers): Simplify.
   4
   5 2019-07-17  Tom Tromey  <tom@tromey.com>
   6
   7         * tui/tui-regs.c (tui_show_registers): Update.
   8         (tui_show_register_group): Add win_info parameter.
   9
  10 2019-07-17  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
  13         Rename from tui_display_reg_element_at_line.
  14         (tui_data_window::display_registers_from_line): Update.
  15         * tui/tui-data.h (struct tui_data_window)
  16         <display_reg_element_at_line>: New method.
  17
  18 2019-07-17  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-regs.h (tui_display_registers_from)
  21         (tui_display_registers_from_line): Don't declare.
  22         * tui/tui-windata.c (tui_data_window::display_all_data)
  23         (tui_data_window::refresh_all)
  24         (tui_data_window::do_scroll_vertical): Update.
  25         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
  26         from tui_display_registers_from.
  27         (tui_display_reg_element_at_line): Update.
  28         (tui_data_window::display_registers_from_line): Rename from
  29         tui_display_registers_from_line.
  30         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
  31         display_registers_from_line>: New methods.
  32
  33 2019-07-17  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
  36         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
  37         from tui_erase_data_content.
  38         (tui_data_window::display_all_data)
  39         (tui_data_window::refresh_all)
  40         (tui_data_window::do_scroll_vertical): Update.
  41         * tui/tui-regs.c (tui_show_registers): Update.
  42         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
  43         New method.
  44
  45 2019-07-17  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
  48         declare.
  49         * tui/tui-windata.c
  50         (tui_data_window::delete_data_content_windows): Rename from
  51         tui_delete_data_content_windows.
  52         (tui_data_window::display_all_data)
  53         (tui_data_window::do_scroll_vertical): Update.
  54         * tui/tui-data.h (struct tui_data_window)
  55         <delete_data_content_windows>: New method.
  56
  57 2019-07-17  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
  60         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
  61
  62 2019-07-17  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-windata.h (tui_display_all_data): Don't declare.
  65         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
  66         from tui_display_all_data.
  67         * tui/tui-win.c
  68         (tui_data_window::do_make_visible_with_new_height): Update.
  69         * tui/tui-regs.c (tui_show_registers): Update.
  70         * tui/tui-layout.c (tui_set_layout): Update.
  71         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
  72         method.
  73
  74 2019-07-17  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-windata.h (tui_display_data_from): Don't declare.
  77         * tui/tui-windata.c (tui_display_data_from): Remove.
  78         (tui_data_window::refresh_all): Update.
  79
  80 2019-07-17  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
  83         * tui/tui-windata.c (tui_display_data_from_line): Remove.
  84         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
  85         tui_display_registers_from_line.
  86         * tui/tui-regs.h (tui_display_registers_from_line): Update.
  87         * tui/tui-regs.c (tui_display_registers_from_line): Remove
  88         "force_display" parameter.
  89
  90 2019-07-17  Tom Tromey  <tom@tromey.com>
  91
  92         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
  93         declare.
  94         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
  95         Rename from tui_first_reg_element_no_inline.
  96         (tui_display_reg_element_at_line)
  97         (tui_display_registers_from_line): Update.
  98         * tui/tui-data.h (struct tui_data_window)
  99         <first_reg_element_no_inline>: New method.
 100
 101 2019-07-17  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-windata.c (tui_display_data_from)
 104         (tui_data_window::do_scroll_vertical): Update.
 105         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 106         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 107         Rename from tui_line_from_reg_element_no.
 108         (tui_display_registers_from_line): Update.
 109         * tui/tui-data.h (struct tui_data_window)
 110         <line_from_reg_element_no>: New method.
 111
 112 2019-07-17  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 115         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 116         tui_last_regs_line_no.
 117         (tui_display_reg_element_at_line)
 118         (tui_display_registers_from_line): Update.
 119         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 120         method.
 121
 122 2019-07-17  Tom Tromey  <tom@tromey.com>
 123
 124         PR tui/24722:
 125         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 126         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 127         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 128         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 129         (tui_update_breakpoint_info): Likewise.
 130         * tui/tui-hooks.c (tui_event_create_breakpoint)
 131         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 132         Update.
 133
 134 2019-07-17  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 137
 138 2019-07-17  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-winsource.c (tui_update_source_window_as_is)
 141         (tui_update_source_windows_with_addr): Update.
 142         * tui/tui-source.h (tui_set_source_content)
 143         (tui_show_symtab_source): Add "win_info" parameter.
 144         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 145         parameter.
 146         (tui_show_symtab_source): Likewise.
 147
 148 2019-07-17  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-wingeneral.c
 151         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 152
 153 2019-07-17  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 156         (struct tui_cmd_window) <can_scroll>: New method.
 157         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 158         method.
 159
 160 2019-07-17  Tom Tromey  <tromey@adacore.com>
 161
 162         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 163         do_field_signed>: Rename.  Change type of "value".
 164         * ui-out.c (ui_out::field_signed): Rename from field_int.
 165         Change type of "value".
 166         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 167         type of "value".
 168         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 169         do_field_int.  Change type of "value".
 170         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 171         do_field_int.  Change type of "value".
 172         * tracepoint.c (trace_status_mi, tfind_1)
 173         (print_one_static_tracepoint_marker): Update.
 174         * thread.c (print_thread_info_1, print_selected_thread_frame):
 175         Update.
 176         * stack.c (print_frame, print_frame_info): Update.
 177         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 178         Update.
 179         * source.c (print_source_lines_base): Update.
 180         * skip.c (info_skip_command): Update.
 181         * record-btrace.c (btrace_ui_out_decode_error)
 182         (btrace_call_history_src_line): Update.
 183         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 184         Update.
 185         * progspace.c (print_program_space): Update.
 186         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 187         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 188         do_field_int.  Change type of "value".
 189         * mi/mi-out.c (mi_ui_out::do_table_begin)
 190         (mi_ui_out::do_table_header): Update.
 191         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 192         type of "value".
 193         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 194         (mi_cmd_data_list_changed_registers, output_register)
 195         (mi_cmd_data_read_memory, mi_load_progress)
 196         (mi_cmd_trace_frame_collected): Update.
 197         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 198         Update.
 199         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 200         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 201         (mi_cmd_var_list_children, varobj_update_one): Update.
 202         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 203         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 204         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 205         * inferior.c (print_inferior): Update.
 206         * gdb_bfd.c (print_one_bfd): Update.
 207         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 208         Update.
 209         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 210         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 211         do_field_int.  Change type of "value".
 212         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 213         do_field_int.  Change type of "value".
 214         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 215         (print_one_breakpoint_location, print_it_catch_fork)
 216         (print_one_catch_fork, print_it_catch_vfork)
 217         (print_one_catch_vfork, print_it_catch_solib)
 218         (print_it_catch_exec, print_it_ranged_breakpoint)
 219         (print_mention_watchpoint, print_mention_masked_watchpoint)
 220         (bkpt_print_it, update_static_tracepoint): Update.
 221         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 222         * break-catch-syscall.c (print_it_catch_syscall): Update.
 223         * ada-tasks.c (print_ada_task_info): Update.
 224         * ada-lang.c (print_it_exception, print_mention_exception):
 225         Update.
 226
 227 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 228
 229         PR breakpoints/24541
 230         * gdbarch.c: Regenerate.
 231         * gdbarch.h: Regenerate.
 232         * gdbarch.sh: Adjust return type and parameter types for
 233         'stap_adjust_register'.
 234         (i386_stap_adjust_register): Adjust signature and return new
 235         register name.
 236         * stap-probe.c (stap_parse_register_operand): Adjust use of
 237         'gdbarch_stap_adjust_register'.
 238
 239 2019-07-17  Tom Tromey  <tromey@adacore.com>
 240
 241         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 242         declare VEC.
 243         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 244         std::vector.
 245         (struct s390_process_info): Add initializers.
 246         (s390_add_process): Use new.
 247         (s390_linux_nat_target::low_forget_process): Use delete.
 248         (s390_linux_nat_target::low_new_fork)
 249         (s390_linux_nat_target::stopped_by_watchpoint)
 250         (s390_linux_nat_target::low_prepare_to_resume)
 251         (s390_linux_nat_target::insert_watchpoint)
 252         (s390_linux_nat_target::insert_hw_breakpoint)
 253         (s390_linux_nat_target::remove_watchpoint)
 254         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 255
 256 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 257
 258         * aarch64-fbsd-nat.c: Include regcache.h.
 259         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 260         argument.
 261         (aarch64_fbsd_nat_target::fetch_registers)
 262         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 263         variable.
 264         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 265
 266 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 267
 268         * fbsd-nat.c: Include gdbarch.h.
 269
 270 2019-07-15  Tom Tromey  <tromey@adacore.com>
 271
 272         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 273
 274 2019-07-15  Tom Tromey  <tromey@adacore.com>
 275
 276         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 277         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 278         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 279         * cli-out.c (cli_ui_out::do_field_int): New method.
 280         * ui-out.c (ui_out::field_unsigned): New method.
 281         * symfile.c (generic_load): Use field_unsigned.
 282         (print_transfer_performance): Likewise.
 283         * record-btrace.c (ui_out_field_uint): Remove.
 284         (btrace_call_history_insn_range, btrace_call_history): Use
 285         field_unsigned.
 286         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 287         field_unsigned.
 288         * ui-out.h (class ui_out) <field_unsigned>: New method.
 289         <do_field_unsigned>: Likewise.
 290
 291 2019-07-15  Tom Tromey  <tromey@adacore.com>
 292
 293         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 294         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 295         * target.c (flash_erase_command): Use field_string.
 296         * infrun.c (print_signal_received_reason): Use field_string.
 297         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 298         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 299         field_string.
 300         * ada-tasks.c (print_ada_task_info): Use field_string.
 301
 302 2019-07-15  Tom Tromey  <tromey@adacore.com>
 303
 304         * target.c (flash_erase_command): Use field_core_addr.
 305         * symfile.c (generic_load): Use field_core_addr.
 306         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 307         Use field_core_addr.
 308         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 309         field_core_addr.
 310
 311 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 312
 313         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 314         value if its desired type is smaller than a CORE_ADDR and signed.
 315
 316 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 317
 318         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 319         of changes to field names, and use new is_reference field to
 320         decide if a property is a reference or not.
 321         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 322         field.
 323         (struct dwarf2_property_baton): Update header comment, rename
 324         'referenced_type' to 'property_type' and update comments.
 325         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 326         default property type, store in property baton, update to take
 327         accound of renamed field.
 328         (read_func_scope): Update call to attr_to_dynamic_prop.
 329         (read_array_type): Likewise.
 330         (dwarf2_per_cu_addr_sized_int_type): New function.
 331         (read_subrange_index_type): Move type finding code to
 332         dwarf2_per_cu_addr_sized_int_type.
 333         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 334         (dwarf2_per_cu_addr_type): New function.
 335         (set_die_type): Update calls to attr_to_dynamic_prop.
 336
 337 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 338
 339         * dwarf2read.c (read_subrange_index_type): New function.
 340         (read_subrange_type): Move code into new function and call it.
 341         * gdbtypes.c (create_range_type): Add some asserts.
 342
 343 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 344
 345         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 346         update return statements.
 347         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 348         declaration, and update comment to match.
 349         * gdbtypes.c (resolve_dynamic_array): Update call to
 350         dwarf2_evaluate_property to match new return type.
 351
 352 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 353
 354         * valarith.c (value_subscripted_rvalue): Change lowerbound
 355         parameter type from int to LONGEST.
 356         * value.h (value_subscripted_rvalue): Likewise in declaration.
 357
 358 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 359
 360         * cli/cli-utils.c (info_print_command_completer): New function.
 361         * cli/cli-utils.h: Add 'completer.h' include, and forward
 362         declaration for 'struct cmd_list_element'.
 363         (info_print_command_completer): Declare.
 364         * stack.c (_initialize_stack): Add completer for 'info locals' and
 365         'info args'.
 366         * symtab.c (_initialize_symtab): Add completer for 'info
 367         variables' and 'info functions'.
 368         * NEWS: Mention completion for additional info commands.
 369
 370 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 371
 372         * cli/cli-utils.c (extract_info_print_args): Delete.
 373         (extract_arg_maybe_quoted): Delete.
 374         (info_print_options_defs): New variable.
 375         (make_info_print_options_def_group): New function.
 376         (extract_info_print_options): Define new function.
 377         * cli/cli-utils.h (extract_info_print_args): Delete.
 378         (struct info_print_options): New structure.
 379         (extract_info_print_options): Declare new function.
 380         * stack.c (info_locals_command): Update to use new
 381         extract_info_print_options, also add a header comment.
 382         (info_args_command): Likewise.
 383         * symtab.c (info_variables_command): Likewise.
 384         (info_functions_command): Likewise.
 385
 386 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 387
 388         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 389         to extract string arguments.
 390         * common/common-utils.c (extract_string_maybe_quoted): New function.
 391         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 392
 393 2019-07-11  Tom Tromey  <tromey@adacore.com>
 394
 395         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 396         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 397         * top.h (gdbinit): Don't declare.
 398         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 399         into...
 400         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 401         * top.c (gdb_init): Don't call init_cli_cmds.
 402         (gdbinit): Remove.
 403         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 404
 405 2019-07-11  Tom Tromey  <tromey@adacore.com>
 406
 407         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 408         after it has been moved.
 409
 410 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 411
 412         * valops.c (value_must_coerce_to_target): Change return type to
 413         bool.
 414         * value.h (value_must_coerce_to_target): Likewise.
 415
 416 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 417
 418         * breakpoint.c (is_hardware_watchpoint): Remove
 419         forward-declaration.
 420         (is_masked_watchpoint): Change return type to bool.
 421         (is_tracepoint): Likewise.
 422         (is_breakpoint): Likewise.
 423         (is_hardware_watchpoint): Likewise.
 424         (is_watchpoint): Likewise.
 425         (is_no_memory_software_watchpoint): Likewise.
 426         (is_catchpoint): Likewise.
 427         (breakpoint_1): Make FILTER parameter's return type bool.
 428         is_masked_watchpoint): Change return type to bool.
 429         (save_breakpoints): Make FILTER parameter's return type bool.
 430         * breakpoint.h (is_breakpoint): Change return type to bool.
 431         (is_watchpoint): Likewise.
 432         (is_catchpoint): Likewise.
 433         (is_tracepoint): Likewise.
 434
 435 2019-07-10  Tom Tromey  <tom@tromey.com>
 436
 437         * defs.h: Don't include gdbarch.h.
 438         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 439         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 440         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 441         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 442         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 443         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 444         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 445         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 446         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 447         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 448         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 449         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 450         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 451         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 452         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 453         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 454         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 455         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 456         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 457         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 458         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 459         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 460         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 461         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 462         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 463         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 464         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 465
 466 2019-07-10  Tom Tromey  <tromey@adacore.com>
 467
 468         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 469         * breakpoint.c (init_ada_exception_breakpoint): Register as
 470         bp_catchpoint.
 471         (print_one_breakpoint_location, print_one_breakpoint): Use
 472         is_ada_exception_catchpoint.
 473         * ada-lang.c (class ada_catchpoint_location): Pass
 474         bp_loc_software_breakpoint to bp_location constructor.
 475         (is_ada_exception_catchpoint): New function.
 476
 477 2019-07-10  Tom Tromey  <tromey@adacore.com>
 478
 479         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 480         VEC.
 481         (struct arm_exidx_entry): New method operator<.
 482         (struct arm_exidx_data) <section_maps>: Change type.
 483         (arm_exidx_data_free): Remove.
 484         (arm_exidx_data_key): Change type.  Move lower.
 485         (arm_exidx_new_objfile): Update.
 486         (arm_compare_exidx_entries): Remove.
 487         (arm_find_exidx_entry, _initialize_arm_tdep)
 488
 489 2019-07-10  Tom Tromey  <tromey@adacore.com>
 490
 491         * solib-spu.c (ocl_program_data_key): Change type.
 492         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 493         Update.
 494
 495 2019-07-10  Tom Tromey  <tromey@adacore.com>
 496
 497         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 498         (struct solib_aix_inferior_data) <library_list>: Change type.
 499         (solib_aix_inferior_data_handle): Change type.
 500         (get_solib_aix_inferior_data): Update.
 501         (solib_aix_free_library_list): Remove.
 502         (library_list_start_library): Update.
 503         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 504         return type.
 505         (solib_aix_get_library_list)
 506         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 507         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 508
 509 2019-07-10  Tom Tromey  <tromey@adacore.com>
 510
 511         * solib-dsbt.c (struct dsbt_info): Add initializers.
 512         (solib_dsbt_pspace_data): Change type.
 513         (dsbt_pspace_data_cleanup): Remove.
 514         (get_dsbt_info, _initialize_dsbt_solib): Update.
 515
 516 2019-07-10  Tom Tromey  <tromey@adacore.com>
 517
 518         * spu-tdep.c (spu_overlay_data): Change type.
 519         (spu_get_overlay_table, spu_overlay_new_objfile)
 520         (_initialize_spu_tdep): Update.
 521
 522 2019-07-10  Tom Tromey  <tromey@adacore.com>
 523
 524         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 525         destructor.
 526         (dbx_objfile_data_key): Change type and declare later.
 527         (DBX_SYMFILE_INFO): Rewrite.
 528         * dbxread.c (dbx_objfile_data_key): Change type.
 529         (dbx_symfile_init): Update.
 530         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 531         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 532         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 533
 534 2019-07-10  Tom Tromey  <tromey@adacore.com>
 535
 536         * jit.c (jit_program_space_key): Change type.  Move lower.
 537         (get_jit_program_space_data): Update.
 538         (jit_program_space_data_cleanup): Remove.
 539         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 540         Update.
 541         (struct jit_program_space_data): Add initializers.
 542
 543 2019-07-10  Tom Tromey  <tromey@adacore.com>
 544
 545         * solib-darwin.c (struct darwin_info): Add initializers.
 546         (solib_darwin_pspace_data): Change type.
 547         (darwin_pspace_data_cleanup): Remove.
 548         (get_darwin_info, _initialize_darwin_solib): Update.
 549
 550 2019-07-10  Tom Tromey  <tromey@adacore.com>
 551
 552         * remote-sim.c (struct sim_inferior_data): Add initializers,
 553         constructor, and destructor.
 554         (sim_inferior_data_key): Change type.  Move lower.
 555         (check_for_duplicate_sim_descriptor): Update.
 556         (get_sim_inferior_data): Use new.  Update.
 557         (~sim_inferior_data_cleanup): Rename from
 558         sim_inferior_data_cleanup.  Simplify.
 559         (gdbsim_close_inferior, simulator_command)
 560         (sim_command_completer, _initialize_remote_sim): Update.
 561         (next_pid, INITIAL_PID): Move earlier.
 562
 563 2019-07-10  Tom Tromey  <tromey@adacore.com>
 564
 565         * python/python-internal.h (create_thread_object): Return
 566         gdbpy_ref.
 567         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 568         * python/py-inferior.c (struct threadlist_entry): Add
 569         constructor.
 570         <thread_obj>: Now a gdbpy_ref.
 571         (thread_to_thread_object): Update.
 572         (add_thread_object): Use new.
 573         (delete_thread_object): Use delete.
 574         (infpy_threads): Update.
 575         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 576         GIL.
 577
 578 2019-07-10  Tom Tromey  <tromey@adacore.com>
 579
 580         * valops.c (value_cast): Specialize error message for Ada.
 581
 582 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 583
 584         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 585
 586 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 587
 588         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 589         bpstat_should_step): Return bool, adjust comments.
 590         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 591         bpstat_should_step): Likewise.
 592
 593 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 594
 595         * features/Makefile: Use feature target descriptions for Arm.
 596         * features/arm/arm-core.c: Generate new file.
 597         * features/arm/arm-fpa.c: Likewise.
 598         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 599         * features/arm/arm-m-profile.c: Likewise.
 600         * features/arm/arm-vfpv2.c: Likewise.
 601         * features/arm/arm-vfpv3.c: Likewise.
 602         * features/arm/xscale-iwmmxt.c: Likewise.
 603         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 604
 605 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 606
 607         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 608         ptrace earlier.
 609
 610 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 611
 612         * features/aarch64-pauth.c: Regenerate.
 613
 614 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 615
 616         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 617         bool.
 618         (bpstat_what): Use false instead of 0.
 619
 620 2019-07-09  Pedro Alves  <palves@redhat.com>
 621
 622         * break-catch-throw.c (is_exception_catchpoint): New.
 623         * breakpoint.c (print_one_breakpoint_location): New parameter
 624         'raw_loc'.  Handle it.  Use
 625         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 626         looking at the breakpoint's type.
 627         (print_one_breakpoint): If handling "maint info breakpoints", also
 628         print locations of exception catchpoints.
 629         * breakpoint.h (is_exception_catchpoint): Declare.
 630
 631 2019-07-09  Pedro Alves  <palves@redhat.com>
 632
 633         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 634         "addr" field.
 635         (allocate_location_exception_catchpoint): New.
 636         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 637         (initialize_throw_catchpoint_ops): Install
 638         allocate_location_exception_catchpoint as allocate_location
 639         method.
 640         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 641         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 642         bp_loc_other.
 643         (breakpoint_address_is_meaningful): Delete.
 644         (bl_address_is_meaningful): New.
 645         (breakpoint_locations_match): Adjust comment.
 646         (bp_location_from_bp_type): New, factored out of...
 647         (bp_location::bp_location(breakpoint *)): ... this.
 648         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 649         factored out of...
 650         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 651         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 652         breakpoint_address_is_meaningful.
 653         (bp_locations_compare): Adjust comment.
 654         (update_global_location_list): Use bl_address_is_meaningful
 655         instead of breakpoint_address_is_meaningful.
 656         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 657         explicit.
 658         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 659         * python/py-breakpoint.c (bppy_get_location): No longer check
 660         whether location is null.
 661
 662 2019-07-09  Pedro Alves  <palves@redhat.com>
 663
 664         PR c++/15468
 665         * breakpoint.c (print_one_breakpoint_location): Remove
 666         single-location assert.
 667
 668 2019-07-09  Tom Tromey  <tom@tromey.com>
 669
 670         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 671         * configure: Rebuild.
 672         * configure.ac: Change common to gdbsupport.
 673         * gdbsupport: Rename from common.
 674         * acinclude.m4: Change common to gdbsupport.
 675         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 676         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 677         gdbsupport.
 678         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 679         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 680         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 681         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 682         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 683         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 684         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 685         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 686         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 687         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 688         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 689         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 690         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 691         coff-pe-read.c, command.h, compile/compile-c-support.c,
 692         compile/compile-c.h, compile/compile-cplus-symbols.c,
 693         compile/compile-cplus-types.c, compile/compile-cplus.h,
 694         compile/compile-loc2c.c, compile/compile.c, completer.c,
 695         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 696         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 697         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 698         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 699         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 700         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 701         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 702         features/aarch64-core.c, features/aarch64-fpu.c,
 703         features/aarch64-pauth.c, features/aarch64-sve.c,
 704         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 705         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 706         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 707         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 708         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 709         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 710         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 711         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 712         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 713         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 714         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 715         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 716         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 717         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 718         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 719         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 720         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 721         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 722         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 723         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 724         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 725         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 726         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 727         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 728         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 729         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 730         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 731         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 732         minsyms.c, mips-linux-tdep.c, namespace.h,
 733         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 734         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 735         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 736         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 737         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 738         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 739         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 740         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 741         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 742         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 743         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 744         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 745         procfs.c, producer.c, progspace.h, psymtab.h,
 746         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 747         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 748         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 749         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 750         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 751         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 752         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 753         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 754         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 755         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 756         target-memory.c, target.c, target.h, target/waitstatus.c,
 757         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 758         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 759         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 760         unittests/array-view-selftests.c,
 761         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 762         unittests/common-utils-selftests.c,
 763         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 764         unittests/format_pieces-selftests.c,
 765         unittests/function-view-selftests.c,
 766         unittests/lookup_name_info-selftests.c,
 767         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 768         unittests/mkdir-recursive-selftests.c,
 769         unittests/observable-selftests.c,
 770         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 771         unittests/parse-connection-spec-selftests.c,
 772         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 773         unittests/scoped_fd-selftests.c,
 774         unittests/scoped_mmap-selftests.c,
 775         unittests/scoped_restore-selftests.c,
 776         unittests/string_view-selftests.c, unittests/style-selftests.c,
 777         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 778         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 779         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 780         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 781         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 782         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 783
 784 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 785
 786         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 787         bool value.
 788         (decode_digits_ordinary): Set explicit_line field in sal.
 789         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 790         symtab_and_line that was set on an explicit line number in
 791         assembler code.  Do always update the recorded symtab and line if
 792         we do skip the prologue.
 793
 794 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 795
 796         * breakpoint.c (set_breakpoint_location_function): Remove
 797         explicit_loc parameter.
 798         (momentary_breakpoint_from_master): Update call to
 799         set_breakpoint_location_function.
 800         (add_location_to_breakpoint): Likewise.
 801
 802 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 803
 804         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 805         required features based on default bfd type when no specific bfd
 806         is present.
 807
 808 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 809
 810         * NEWS: Mention that GDB printf and eval commands can now print
 811         C-style and Ada-style convenience var strings without
 812         calling the inferior.
 813         * printcmd.c (printf_c_string): Locally print GDB internal var
 814         instead of transiting via the inferior.
 815         (printf_wide_c_string): Likewise.
 816
 817 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 818
 819         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 820
 821 2019-07-04  Tom Tromey  <tom@tromey.com>
 822
 823         PR tui/24724:
 824         * tui/tui-winsource.c (tui_clear_source_content): Update.
 825         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 826         (tui_update_breakpoint_info): Update.
 827         (tui_set_exec_info_content): Update.
 828         * tui/tui-source.c (tui_set_source_content_nil): Update.
 829         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 830         has_break.
 831         * tui/tui-data.h (enum tui_bp_flag): New.
 832         (tui_bp_flags): New enum flags type.
 833         (struct tui_source_element) <break_mode>: Change type.  Rename
 834         from has_break.
 835         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 836         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 837         constants.
 838         * tui/tui-winsource.h: Fix comment.
 839
 840 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 841
 842         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 843         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 844         (store_fpregs_to_thread)
 845         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 846         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 847         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 848         (IWMMXT_REGS_SIZE): Add define.
 849         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 850         (fetch_vfp_regs, store_vfp_regs)
 851         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 852         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 853
 854 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 855
 856         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 857         defines.
 858         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 859         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 860         (ARM_INT_REGISTER_SIZE): ...to this.
 861         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 862         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 863         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 864         (arm_linux_collect_gregset, supply_nwfpe_register)
 865         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 866         defines.
 867         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 868         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 869         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 870         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 871         (arm_return_in_memory, arm_store_return_value)
 872         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 873         (arm_record_ld_st_multiple): Likewise.
 874         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 875         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 876
 877 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 878
 879         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 880         AARCH64_DISPLACED_MODIFIED_INSNS.
 881         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 882         (aarch64_displaced_step_copy_insn): Likewise.
 883         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 884         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 885         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 886         ARM_DISPLACED_MODIFIED_INSNS.
 887         * arm-tdep.c (arm_gdbarch_init): Likewise.
 888         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 889         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 890         (struct arm_displaced_step_closure): Use
 891         ARM_DISPLACED_MODIFIED_INSNS.
 892
 893 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 894
 895         * features/Makefile: Remove unused xml files.
 896         * features/aarch64.xml: Remove.
 897         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 898         * features/i386/amd64-avx-avx512.xml: Remove.
 899         * features/i386/amd64-avx-linux.xml: Remove.
 900         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 901         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 902         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 903         * features/i386/amd64-avx-mpx.xml: Remove.
 904         * features/i386/amd64-avx.xml: Remove.
 905         * features/i386/amd64-linux.xml: Remove.
 906         * features/i386/amd64-mpx-linux.xml: Remove.
 907         * features/i386/amd64-mpx.xml: Remove.
 908         * features/i386/amd64.xml: Remove.
 909         * features/i386/i386-avx-avx512-linux.xml: Remove.
 910         * features/i386/i386-avx-avx512.xml: Remove.
 911         * features/i386/i386-avx-linux.xml: Remove.
 912         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 913         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 914         * features/i386/i386-avx-mpx-linux.xml: Remove.
 915         * features/i386/i386-avx-mpx.xml: Remove.
 916         * features/i386/i386-avx.xml: Remove.
 917         * features/i386/i386-linux.xml: Remove.
 918         * features/i386/i386-mmx-linux.xml: Remove.
 919         * features/i386/i386-mmx.xml: Remove.
 920         * features/i386/i386-mpx-linux.xml: Remove.
 921         * features/i386/i386-mpx.xml: Remove.
 922         * features/i386/i386.xml: Remove.
 923         * features/i386/x32-avx-avx512-linux.xml: Remove.
 924         * features/i386/x32-avx-linux.xml: Remove.
 925         * features/i386/x32-linux.xml: Remove.
 926
 927 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 928
 929         * regformats/aarch64.dat: Remove.
 930         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 931         * regformats/i386/amd64-avx-linux.dat: Remove.
 932         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 933         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 934         * regformats/i386/amd64-linux.dat: Remove.
 935         * regformats/i386/amd64-mpx-linux.dat: Remove.
 936         * regformats/i386/amd64.dat: Remove.
 937         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 938         * regformats/i386/i386-avx-linux.dat: Remove.
 939         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 940         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 941         * regformats/i386/i386-linux.dat: Remove.
 942         * regformats/i386/i386-mmx-linux.dat: Remove.
 943         * regformats/i386/i386-mpx-linux.dat: Remove.
 944         * regformats/i386/i386.dat: Remove.
 945         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 946         * regformats/i386/x32-avx-linux.dat: Remove.
 947         * regformats/i386/x32-linux.dat: Remove.
 948
 949 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 950
 951         * aarch64-tdep.c: Remove xml self tests.
 952         * amd64-linux-tdep.c: Likewise.
 953         * amd64-tdep.c: Likewise.
 954         * i386-linux-tdep.c: Likewise.
 955         * i386-tdep.c: Likewise.
 956
 957 2019-07-03  Pedro Alves  <palves@redhat.com>
 958
 959         PR cli/24732
 960         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 961         (pipe_cmd_option_defs): New.
 962         (make_pipe_cmd_options_def_group): New.
 963         (pipe_command): Use gdb::option::process_options.
 964         (pipe_command_completer): New function.
 965         (_initialize_cli_cmds): Install completer for "pipe" command.
 966
 967 2019-07-03  Pedro Alves  <palves@redhat.com>
 968
 969         * cli/cli-option.c (union option_value) <string>: New field.
 970         (struct option_def_and_value): Add ctor, move ctor, dtor and
 971         use DISABLE_COPY_AND_ASSIGN.
 972         (option_def_and_value::clear_value): New.
 973         (parse_option, save_option_value_in_ctx, get_val_type_str)
 974         (add_setshow_cmds_for_options): Handle var_string.
 975         * cli-option.h (union option_def::var_address) <string>: New
 976         field.
 977         (struct string_option_def): New.
 978         * maint-test-options.c (struct test_options_opts): Add default
 979         ctor and use DISABLE_COPY_AND_ASSIGN.
 980         <string_opt>: New field.
 981         (test_options_opts::~test_options_opts): New.
 982         (test_options_opts::dump): Also dump "-string".
 983         (test_options_option_defs): Install "string.
 984
 985 2019-07-03  Pedro Alves  <palves@redhat.com>
 986
 987         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 988         option_value with a null enumeration.
 989         (complete_options): Save the option values in the context.
 990         (save_option_value_in_ctx): New, factored out from ...
 991         (process_options): ... here.
 992         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 993         of the function.
 994         * maint-test-options.c (test_options_opts::dump): New, factored
 995         out from ...
 996         (maintenance_test_options_command_mode): ... here.
 997         (maintenance_test_options_command_completion_result): Delete.
 998         (maintenance_test_options_command_completion_text): Update
 999         comment.
1000         (maintenance_show_test_options_completion_result): Change
1001         prototype.  Just print
1002         maintenance_test_options_command_completion_text.
1003         (save_completion_result): New.
1004         (maintenance_test_options_completer_mode): Pass options context to
1005         complete_options, and then save a dump.
1006         (_initialize_maint_test_options): Use add_cmd to install "maint
1007         show test-options-completion-result".
1008
1009 2019-07-03  Pedro Alves  <palves@redhat.com>
1010
1011         * NEWS (New commands): Mention "with" and "maint with".
1012         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1013         (with_command, with_command_completer): New.
1014         (pipe_command): Adjust to new repeat_previous
1015         interface.
1016         (_initialize_cli_cmds): Install the "with" command and its "w"
1017         alias.
1018         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1019         declarations.
1020         * cli/cli-setshow.c (parse_cli_var_uinteger)
1021         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1022         argument strings for all var_types.
1023         (get_setshow_command_value_string): New, factored out from ...
1024         (do_show_command): ... this.
1025         * cli/cli-setshow.h: Include <string>.
1026         (get_setshow_command_value_string): Declare.
1027         * command.h (repeat_previous): Now returns const char *.  Adjust
1028         comment.
1029         * maint.c: Include "cli/cli-cmds.h".
1030         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1031         (_initialize_maint_cmds): Register the "maintenance with" command.
1032         * top.c (repeat_previous): Move bits from pipe_command here:
1033         Return the saved command line, if any; error out if there's no
1034         command to relaunch.
1035
1036 2019-07-03  Pedro Alves  <palves@redhat.com>
1037
1038         * NEWS (New commands): Mention "maint set/show test-settings"
1039         instead of "maint test-settings".
1040         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1041         (maintenance_test_settings_set_list): Rename to ...
1042         (maintenance_set_test_settings_list): ... this.
1043         (maintenance_test_settings_show_list): Rename to  ...
1044         (maintenance_show_test_settings_list): ... this.
1045         (maintenance_test_settings_cmd): Delete.
1046         (maintenance_test_settings_set_cmd): ...
1047         (maintenance_set_test_settings_cmd): ... this.
1048         (maintenance_test_settings_show_cmd): ...
1049         (maintenance_show_test_settings_cmd): ... this.
1050         (maintenance_test_settings_show_value_cmd):
1051         (maintenance_show_test_settings_value_cmd): ... this.
1052         (_initialize_maint_test_settings): No longer install the "maint
1053         test-settings" prefix command.  Rename "maint test-settings set"
1054         to "maint set test-settings", and "maint test-settings show" to
1055         "maint show test-settings".  Adjust all subcommands.
1056
1057 2019-07-03  Pedro Alves  <palves@redhat.com>
1058
1059         * maint-test-settings.c: Fix file's intro comment.  Replace all
1060         references to "test-options" with references to "test-settings",
1061         in comments.
1062
1063 2019-07-03  Pedro Alves  <palves@redhat.com>
1064
1065         * maint-test-settings.c (maintenance_test_settings_xxx)
1066         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1067         New.
1068         (maintenance_test_settings_enums): Use them.
1069         (maintenance_test_settings_enum): Default to
1070         maintenance_test_settings_xxx.
1071         (_initialize_maint_test_settings): Initialize
1072         MAINTENANCE_TEST_SETTINGS_FILENAME.
1073
1074 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1075
1076         * breakpoint.h (remove_breakpoints_inf): Change return type to
1077         void, move function documentation here.
1078         * breakpoint.c (remove_breakpoints_inf): Change return type to
1079         void, move function documentation to header.
1080
1081 2019-07-02  Pedro Alves  <palves@redhat.com>
1082
1083         * NEWS (Completion improvements): Mention "info threads".
1084         * thread.c (struct info_threads_opts, info_threads_option_defs)
1085         (make_info_threads_options_def_group): New.
1086         (info_threads_command): Use gdb::option::process_options.
1087         (info_threads_command_completer): New.
1088         (_initialize_thread): Use gdb::option::build_help to build the
1089         help text for "info threads".
1090
1091 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1092
1093         * defs.h (generic_load): Move from here...
1094         * symfile.h (generic_load): ... to here.  Rename name parameter
1095         to args.
1096         * symfile.c (generic_load): Add comment.
1097
1098 2019-07-01  Tom Tromey  <tromey@adacore.com>
1099
1100         * dwarf2read.c
1101         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1102         declaration of without_params.  Fix formatting.
1103
1104 2019-07-01  Tom Tromey  <tromey@adacore.com>
1105
1106         * ada-exp.y (find_primitive_type): Update.
1107         * ada-lang.h (ada_lookup_symbol): Update.
1108         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1109         parameter.
1110         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1111
1112 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1113
1114         PR breakpoints/24541
1115         * gdbarch.c: Regenerate.
1116         * gdbarch.h: Regenerate.
1117         * gdbarch.sh: Add 'stap_adjust_register'.
1118         * i386-tdep.c: Include '<unordered_set>'.
1119         (i386_stap_adjust_register): New function.
1120         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1121         * stap-probe.c (stap_parse_register_operand): Call
1122         'gdbarch_stap_adjust_register'.
1123
1124 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1125
1126         PR python/24742
1127         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1128         * python/python.c (do_start_initialization): Use 'xmalloc'
1129         instead of 'PyMem_Malloc'.
1130
1131 2019-06-28  Tom Tromey  <tromey@adacore.com>
1132
1133         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1134         for Ada.
1135
1136 2019-06-27  Tom Tromey  <tromey@adacore.com>
1137
1138         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1139         objfile_key.
1140         (arm_find_mapping_symbol, arm_record_special_symbol)
1141         (_initialize_arm_tdep): Update.
1142         (arm_objfile_data_free): Remove.
1143
1144 2019-06-27  Tom Tromey  <tromey@adacore.com>
1145
1146         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1147         to cp_print_static_field.
1148
1149 2019-06-26  Tom Tromey  <tromey@adacore.com>
1150
1151         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1152         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1153         declare.
1154
1155 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1156
1157         * features/aarch64-core.c (create_feature_aarch64_core):
1158         Regenerate.
1159         * features/aarch64-core.xml: Add cpsr flags.
1160
1161 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1162
1163         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1164         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1165
1166 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1167
1168         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1169         field.
1170         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1171         use.
1172         (arm_record_special_symbol): Don't insert new symbol in sorted
1173         position, push it at the end.
1174
1175 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1176
1177         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1178         (arm_mapping_symbol_s): Remove.
1179         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1180         (arm_mapping_symbol_vec): New typedef.
1181         (struct arm_per_objfile): Add constructor.
1182         <section_maps>: Change type to
1183         std::unique_ptr<arm_mapping_symbol_vec[]>.
1184         (arm_compare_mapping_symbols): Remove.
1185         (arm_find_mapping_symbol): Adjust to section_maps type change.
1186         (arm_objfile_data_free): Call delete on arm_per_objfile.
1187         (arm_record_special_symbol): Adjust to section_maps type change.
1188         Allocate arm_per_objfile with new.
1189
1190 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1191
1192         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1193         with the command prefix.
1194
1195 2019-06-25  Tom Tromey  <tom@tromey.com>
1196
1197         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1198         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1199
1200 2019-06-25  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1203         type.
1204         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1205         protected.
1206
1207 2019-06-25  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui-winsource.c
1210         (tui_source_window_base::set_is_exec_point_at): Add check against
1211         LOA_ADDRESS.
1212
1213 2019-06-25  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui-source.c (tui_set_source_content): Don't check before
1216         xfree.
1217         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1218
1219 2019-06-25  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui-winsource.h (tui_update_source_window_as_is)
1222         (tui_alloc_source_buffer, tui_line_is_displayed)
1223         (tui_addr_is_displayed): Change type of win_info.
1224         * tui/tui-winsource.c (tui_update_source_window_as_is)
1225         (tui_clear_source_content, tui_show_source_line)
1226         (tui_show_source_content, tui_source_window_base::refill)
1227         (tui_source_window_base::set_is_exec_point_at)
1228         (tui_source_window_base::set_is_exec_point_at)
1229         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1230         (tui_alloc_source_buffer, tui_line_is_displayed)
1231         (tui_addr_is_displayed): Change type of win_info.  Update.
1232         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1233         (tui_source_window_base::do_make_visible_with_new_height):
1234         Update.
1235         * tui/tui-source.c (tui_set_source_content)
1236         (tui_set_source_content_nil)
1237         (tui_source_window::do_scroll_vertical): Update.
1238         * tui/tui-layout.c (show_layout): Update.
1239         * tui/tui-disasm.c (tui_set_disassem_content)
1240         (tui_disasm_window::do_scroll_vertical): Update.
1241         * tui/tui-data.h (tui_win_content): Remove.
1242         (struct tui_gen_win_info) <content, content_size>: Remove.
1243         (struct tui_source_element): Add initializers and destructor.
1244         (union tui_which_element, struct tui_win_element): Remove.
1245         (struct tui_source_window_base) <content>: New field.
1246         (struct tui_data_window): Remove destructor.
1247         (tui_alloc_content, tui_free_win_content)
1248         (tui_free_all_source_wins_content): Don't declare.
1249         * tui/tui-data.c (tui_initialize_static_data): Update.
1250         (init_content_element, tui_alloc_content): Remove.
1251         (~tui_gen_win_info): Update.
1252         (~tui_data_window, tui_free_all_source_wins_content)
1253         (tui_free_win_content, free_content, free_content_elements):
1254         Remove.
1255
1256 2019-06-25  Tom Tromey  <tom@tromey.com>
1257
1258         * tui/tui-winsource.h (tui_clear_source_content)
1259         (tui_erase_source_content, tui_show_source_content): Change type
1260         of win_info.
1261         * tui/tui-winsource.c (tui_clear_source_content)
1262         (tui_erase_source_content, tui_show_source_content): Change type
1263         of win_info.
1264         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1265         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1266         win_info.
1267         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1268         win_info.
1269         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1270
1271 2019-06-25  Tom Tromey  <tom@tromey.com>
1272
1273         * tui/tui-winsource.c (tui_clear_source_content)
1274         (tui_source_window_base::set_is_exec_point_at): Update.
1275         * tui/tui-source.c (tui_set_source_content_nil): Update.
1276         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1277         a bool.
1278         * tui/tui-data.c (init_content_element): Update.
1279
1280 2019-06-25  Tom Tromey  <tom@tromey.com>
1281
1282         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1283         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1284         * tui/tui-layout.c (init_and_make_win): Update.
1285         * tui/tui.h (enum tui_win_type): Update.
1286         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1287         tui_win_is_auxillary.
1288         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1289         tui_win_is_auxillary.
1290
1291 2019-06-25  Tom Tromey  <tom@tromey.com>
1292
1293         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1294         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1295         (tui_delete_data_content_windows, tui_display_all_data)
1296         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1297         Update.
1298         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1299         * tui/tui-regs.c (tui_last_regs_line_no)
1300         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1301         (tui_show_registers): Update.
1302         (tui_show_register_group): Return void.  Update.
1303         (tui_display_registers_from, tui_display_reg_element_at_line)
1304         (tui_display_registers_from_line, tui_check_register_values):
1305         Update.
1306         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1307         member.
1308         (struct tui_data_window) <regs_content>: Now a std::vector.
1309         <regs_content_count>: Remove.
1310         (tui_add_content_elements, tui_free_data_content): Don't declare.
1311         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1312         (init_content_element): Remove DATA_WIN case.  Add assert.
1313         (tui_add_content_elements): Remove.
1314         (tui_data_window): Update.
1315         (tui_free_data_content): Remove.
1316         (free_content_elements): Remove DATA_WIN case.
1317
1318 2019-06-25  Tom Tromey  <tom@tromey.com>
1319
1320         * tui/tui-data.c (tui_data_item_window): Update.
1321         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1322         * tui/tui-windata.c (tui_display_all_data)
1323         (tui_display_data_from_line): Update.
1324         (tui_check_data_values): Remove.
1325         * tui/tui-regs.c (tui_show_register_group)
1326         (tui_display_reg_element_at_line): Update.
1327         * tui/tui-hooks.c (tui_register_changed)
1328         (tui_refresh_frame_and_register_information): Call
1329         tui_check_register_values.
1330         * tui/tui-data.h (struct tui_data_window) <data_content,
1331         data_content_count, data_type>: Remove.
1332         (enum tui_data_type): Remove.
1333
1334         * tui/tui-data.c (tui_data_window::clear_detail)
1335         (~tui_data_window): Update.
1336
1337 2019-06-25  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1340         declare.
1341         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1342         Rename from tui_first_data_item_displayed.  Update.
1343         (tui_data_window::refresh_all)
1344         (tui_data_window::do_scroll_vertical): Update.
1345         * tui/tui-data.h (struct tui_data_window)
1346         <first_data_item_displayed>: Declare new method.
1347
1348 2019-06-25  Tom Tromey  <tom@tromey.com>
1349
1350         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1351         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1352         contents...
1353         (tui_initialize_static_data): ...here.
1354
1355 2019-06-25  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1358         (tui_display_registers_from, tui_check_register_values): Update.
1359         (tui_display_register): Remove win_info parameter; update.
1360         (tui_get_register): Change type of parameters.
1361         * tui/tui-data.h (struct tui_data_element): Remove.
1362         (union tui_which_element) <data>: Remove.
1363         <data_window>: Change type.
1364         (struct tui_data_item_window): New.
1365         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1366         case.  Add assert.
1367         (~tui_data_item_window): New destructor.
1368         (free_content_elements): Remove DATA_ITEM_WIN case.
1369
1370 2019-06-25  Tom Tromey  <tom@tromey.com>
1371
1372         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1373         Remove.
1374
1375 2019-06-25  Tom Tromey  <tom@tromey.com>
1376
1377         * tui/tui-data.h (struct tui_command_element): Remove.
1378         (union tui_which_element) <command>: Remove.
1379         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1380         assert.
1381         (free_content_elements): Remove CMD_WIN case.
1382
1383 2019-06-25  Tom Tromey  <tom@tromey.com>
1384
1385         * tui/tui-layout.c (tui_set_layout): Update.
1386         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1387         * tui/tui-data.c (layout_def): Update.
1388
1389 2019-06-25  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1392         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1393         (tui_source_window_base::set_new_height): Update.
1394         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1395         Update.
1396         (tui_set_locator_fullname, tui_set_locator_info)
1397         (tui_show_frame_info): Update.
1398         * tui/tui-source.c (tui_set_source_content)
1399         (tui_source_is_displayed): Update.
1400         * tui/tui-layout.c (show_source_disasm_command, show_data)
1401         (show_source_or_disasm_and_command): Update.
1402         * tui/tui-disasm.c (tui_set_disassem_content)
1403         (tui_get_begin_asm_address): Update.
1404         * tui/tui-data.h (struct tui_locator_element): Remove.
1405         (union tui_which_element) <locator>: Remove.
1406         (struct tui_locator_window): New.
1407         (tui_locator_win_info_ptr): Change return type.
1408         * tui/tui-data.c (_locator): Change type.
1409         (tui_locator_win_info_ptr): Change return type.
1410         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1411         (tui_alloc_content): Add assert.
1412
1413 2019-06-25  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui-winsource.c
1416         (tui_exec_info_window::maybe_allocate_content): New method.
1417         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1418         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1419         (make_source_or_disasm_window): Add cast.
1420         * tui/tui-data.h (union tui_which_element) <simple_string>:
1421         Remove.
1422         (struct tui_source_info): New.
1423         (struct tui_source_window_base) <execution_info>: Change type.
1424         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1425         case, and add assert.
1426         (tui_alloc_content): Add assert.
1427
1428 2019-06-25  Tom Tromey  <tom@tromey.com>
1429
1430         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1431         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1432         * tui/tui-data.c (tui_alloc_win_info): Remove.
1433
1434 2019-06-25  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1437         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1438         can_highlight.
1439
1440 2019-06-25  Tom Tromey  <tom@tromey.com>
1441
1442         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1443         make_visible_with_new_height method.
1444         (tui_win_info::make_visible_with_new_height): New method.
1445         (tui_source_window_base::do_make_visible_with_new_height)
1446         (tui_data_window::do_make_visible_with_new_height)
1447         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1448         (make_visible_with_new_height): Remove.
1449         (tui_resize_all, tui_adjust_win_heights): Use
1450         make_visible_with_new_height method.
1451         * tui/tui-data.h (struct tui_win_info)
1452         <do_make_visible_with_new_height, make_visible_with_new_height>:
1453         New methods.
1454         (struct tui_source_window_base, struct tui_data_window)
1455         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1456         methods.
1457
1458 2019-06-25  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1461         method.
1462         (update_tab_width): Call update_tab_width method.
1463         * tui/tui-data.h (struct tui_win_info)
1464         (struct tui_source_window_base) <update_tab_width>: New methods.
1465
1466 2019-06-25  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1469         parameter.
1470         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1471         parameter.
1472         (tui_gen_win_info::make_visible): Update.
1473         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1474         parameter.
1475         * tui/tui-data.h (enum tui_box): New enum.
1476         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1477
1478 2019-06-25  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1481         init_and_make_win for EXEC_INFO_WIN.
1482         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1483         longer inline.
1484         (struct tui_win_info) <~tui_win_info>: Inline.
1485         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1486         Don't declare.
1487         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1488         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1489         Remove.
1490         (tui_initialize_static_data): Update.
1491         (~tui_gen_win_info): Handle more cleanup here.
1492         (~tui_source_window_base): Delete "execution_info".
1493         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1494
1495 2019-06-25  Tom Tromey  <tom@tromey.com>
1496
1497         * tui/tui-layout.c (make_command_window): Don't set
1498         can_highlight.
1499         (show_source_disasm_command): Call the reset method.
1500         (show_data): Don't set can_highlight.  Call the reset method.
1501         (tui_gen_win_info::reset): Rename from init_gen_win_info
1502         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1503         (show_source_or_disasm_and_command): Call the reset method.
1504         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1505         (struct tui_cmd_window): Set can_highlight.
1506
1507 2019-06-25  Tom Tromey  <tom@tromey.com>
1508
1509         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1510         from make_visible.
1511         (tui_make_visible, tui_make_invisible): Rewrite.
1512         (tui_win_info::make_visible): Remove.
1513         (tui_source_window_base::make_visible): Update.
1514         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1515         method.  Moved from...
1516         (struct tui_win_info) <make_visible>: ...here.
1517
1518 2019-06-25  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-winsource.c
1521         (tui_source_window_base::do_scroll_horizontal): Remove direction
1522         parameter.
1523         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1524         direction parameter.
1525         * tui/tui-win.c (tui_win_info::forward_scroll)
1526         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1527         (tui_win_info::right_scroll): Update.
1528         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1529         direction parameter.
1530         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1531         direction parameter.
1532         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1533         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1534         Remove direction parameter.
1535         (struct tui_source_window_base, struct tui_source_window)
1536         (struct tui_disasm_window, struct tui_data_window)
1537         (struct tui_cmd_window): Update.
1538
1539 2019-06-25  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-winsource.h (tui_set_exec_info_content)
1542         (tui_show_exec_info_content, tui_erase_exec_info_content)
1543         (tui_clear_exec_info_content, tui_update_exec_info): Change
1544         argument to tui_source_window_base.
1545         * tui/tui-winsource.c (tui_set_exec_info_content)
1546         (tui_show_exec_info_content, tui_erase_exec_info_content)
1547         (tui_clear_exec_info_content, tui_update_exec_info): Change
1548         argument to tui_source_window_base.
1549
1550 2019-06-25  Tom Tromey  <tom@tromey.com>
1551
1552         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1553         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1554
1555 2019-06-25  Tom Tromey  <tom@tromey.com>
1556
1557         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1558         check.
1559
1560 2019-06-25  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1563         type to void.
1564         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1565         type to void.
1566         * tui/tui-source.c (tui_set_source_content): Update.
1567         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1568
1569 2019-06-25  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-win.c (window_name_completer, tui_set_focus)
1572         (tui_all_windows_info): Use name method.
1573         * tui/tui-data.h (struct tui_gen_win_info)
1574         (struct tui_source_window, struct tui_disasm_window)
1575         (struct tui_data_window, struct tui_cmd_window) <name>: New
1576         method.
1577         (tui_win_name): Don't declare.
1578         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1579         (tui_win_name): Remove.
1580
1581 2019-06-25  Tom Tromey  <tom@tromey.com>
1582
1583         * tui/tui-winsource.h (tui_update_source_window)
1584         (tui_update_source_window_as_is): Change parameter type.
1585         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1586         to be a tui_source_window_base.
1587         (tui_update_source_window_as_is): Likewise.
1588         * tui/tui-win.c (make_visible_with_new_height): Update.
1589
1590 2019-06-25  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-winsource.c (tui_erase_source_content)
1593         (tui_show_source_content, tui_show_exec_info_content)
1594         (tui_erase_exec_info_content): Use refresh_window method.
1595         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1596         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1597         from tui_refresh_win.
1598         (tui_data_window::refresh_window): New method.
1599         (tui_win_info::refresh, tui_source_window_base::refresh)
1600         (tui_refresh_all): Use refresh_window method.
1601         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1602         method.
1603         * tui/tui-regs.c (tui_display_register): Call refresh_window
1604         method.
1605         * tui/tui-layout.c (show_source_disasm_command)
1606         (show_source_or_disasm_and_command): Call refresh_window method.
1607         * tui/tui-data.h (struct tui_gen_win_info)
1608         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1609         New method.
1610
1611 2019-06-25  Tom Tromey  <tom@tromey.com>
1612
1613         * tui/tui.c (tui_rl_other_window, tui_enable)
1614         (tui_is_window_visible, tui_get_command_dimension): Update.
1615         * tui/tui-winsource.c (tui_update_source_window_as_is)
1616         (tui_clear_source_content, tui_erase_source_content)
1617         (tui_show_source_line, tui_source_window_base::refill)
1618         (tui_source_window_base::do_scroll_horizontal)
1619         (tui_source_window_base::set_is_exec_point_at)
1620         (tui_update_breakpoint_info, tui_set_exec_info_content)
1621         (tui_alloc_source_buffer, tui_line_is_displayed)
1622         (tui_addr_is_displayed): Update.
1623         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1624         (tui_check_and_display_highlight_if_needed)
1625         (tui_win_info::make_visible, tui_win_info::refresh)
1626         (tui_refresh_all): Update.
1627         * tui/tui-windata.c (tui_first_data_item_displayed)
1628         (tui_delete_data_content_windows, tui_erase_data_content)
1629         (tui_display_all_data, tui_data_window::refresh_all)
1630         (tui_check_data_values): Update.
1631         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1632         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1633         (tui_win_info::backward_scroll, tui_refresh_all_win)
1634         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1635         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1636         (tui_source_window_base::set_new_height)
1637         (tui_data_window::set_new_height)
1638         (make_invisible_and_set_new_height)
1639         (make_visible_with_new_height, new_height_ok)
1640         (parse_scrolling_args): Update.
1641         * tui/tui-stack.c (tui_show_frame_info): Update.
1642         * tui/tui-source.c (tui_set_source_content)
1643         (tui_set_source_content_nil, tui_source_is_displayed)
1644         (tui_source_window::do_scroll_vertical): Update.
1645         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1646         (tui_display_registers_from, tui_display_reg_element_at_line)
1647         (tui_check_register_values, tui_reg_command): Update.
1648         * tui/tui-layout.c (tui_default_win_height)
1649         (show_source_disasm_command, show_data, init_and_make_win)
1650         (show_source_or_disasm_and_command): Update.
1651         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1652         (tui_redisplay_readline, tui_mld_flush)
1653         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1654         (tui_getc): Update.
1655         * tui/tui-disasm.c (tui_set_disassem_content)
1656         (tui_disasm_window::do_scroll_vertical): Update.
1657         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1658         Now virtual.
1659         (struct tui_win_info): Derive from tui_gen_win_info.
1660         <~tui_win_info>: Mark as override.
1661         <generic>: Remove member.
1662         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1663         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1664         (~tui_data_window, ~tui_win_info)
1665         (tui_free_all_source_wins_content): Update.
1666         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1667
1668 2019-06-25  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-layout.c (init_and_make_win): Use new.
1671         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1672         destructor, initializers.
1673         (tui_alloc_generic_win_info): Don't declare.
1674         * tui/tui-data.c (_locator): Add argument to constructor.
1675         (source_win, disasm_win): New globals.
1676         (exec_info): Remove.
1677         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1678         Update.
1679         (tui_alloc_generic_win_info): Remove.
1680         (init_content_element): Use new.
1681         (tui_win_info::tui_win_info): Update.
1682         (free_content_elements) <case DATA_WIN>: Use delete.
1683
1684 2019-06-25  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1687         * tui/tui-windata.c (tui_first_data_item_displayed)
1688         (tui_delete_data_content_windows): Update.
1689         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1690         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1691         (tui_display_registers_from, tui_check_register_values): Update.
1692         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1693         pointer.
1694         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1695         window.
1696         (tui_free_data_content): Update.
1697         (free_content_elements) <case DATA_WIN>: Free the window.
1698
1699 2019-06-25  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1702         Update.
1703         * tui/tui-layout.c (make_command_window)
1704         (show_source_disasm_command, show_data, init_and_make_win)
1705         (show_source_or_disasm_and_command): Update.
1706         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1707         method.
1708         <can_highight, is_highlighted>: Now bool.
1709         (tui_set_win_highlight): Don't declare.
1710         * tui/tui-data.c (tui_set_win_highlight): Remove.
1711
1712 2019-06-25  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-wingeneral.c (make_visible): Remove check of window
1715         type.
1716
1717 2019-06-25  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-win.c (tui_win_info::max_height)
1720         (tui_cmd_window::max_height): New methods.
1721         (new_height_ok): Call max_height.
1722         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1723         <max_height>: New method.
1724
1725 2019-06-25  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-win.c (tui_source_window_base::set_new_height)
1728         (tui_data_window::set_new_height): New methods.
1729         (make_invisible_and_set_new_height): Call set_new_height method.
1730         * tui/tui-data.h (struct tui_win_info)
1731         (struct tui_source_window_base, struct tui_data_window)
1732         <set_new_height>: New method.
1733
1734 2019-06-25  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1737         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1738         tui_refresh_data_win.
1739         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1740         method.
1741         (tui_refresh_all_win): Call the refresh_all method.
1742         (tui_set_focus): Likewise.
1743         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1744         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1745         Likewise.
1746
1747 2019-06-25  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-winsource.h (tui_refill_source_window)
1750         (tui_set_is_exec_point_at): Don't declare.
1751         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1752         (tui_source_window_base::refill): Rename from
1753         tui_refill_source_window.
1754         (tui_source_window_base::do_scroll_horizontal): Update.
1755         (tui_source_window_base::set_is_exec_point_at): Rename from
1756         tui_set_is_exec_point_at.
1757         (tui_update_all_breakpoint_info): Update.
1758         * tui/tui-stack.c (tui_show_frame_info): Update.
1759         * tui/tui-layout.c (show_data): Add cast.
1760         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1761         * tui/tui-data.h (struct tui_source_window_base) <refill,
1762         set_is_exec_point_at>: New methods.
1763         (tui_source_windows, tui_add_to_source_windows): Update types.
1764         (tui_add_to_source_windows): Remove redundant declaration.
1765         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1766         (tui_source_windows): Change return type.
1767         (tui_clear_source_windows_detail): Update.
1768         (tui_add_to_source_windows): Change type of parameter.
1769         (tui_free_all_source_wins_content): Update.
1770
1771 2019-06-25  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-wingeneral.c (tui_win_info::refresh)
1774         (tui_source_window_base::refresh): New methods.
1775         (tui_refresh_all): Call the refresh method.
1776         * tui/tui-data.h (struct tui_win_info)
1777         (struct tui_source_window_base) <refresh>: New method.
1778
1779 2019-06-25  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui.h (tui_is_window_visible): Return bool.
1782         * tui/tui.c (tui_is_window_visible): Return bool.
1783         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1784         (tui_make_visible, tui_make_invisible)
1785         (tui_win_info::make_visible)
1786         (tui_source_window_base::make_visible, make_all_visible)
1787         (tui_make_all_visible, tui_make_all_invisible): Update.
1788         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1789         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1790         bool.
1791         (struct tui_win_info, struct tui_source_window_base)
1792         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1793         * tui/tui-data.c (tui_init_generic_part): Update.
1794
1795 2019-06-25  Tom Tromey  <tom@tromey.com>
1796
1797         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1798         (tui_source_window_base::make_visible): New methods.
1799         (make_all_visible): Make method call.
1800         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1801         (struct tui_source_window_base, struct tui_cmd_window): Override
1802         make_visible.
1803         (tui_win_is_source_type): Don't declare.
1804         * tui/tui-data.c (tui_win_is_source_type): Remove.
1805
1806 2019-06-25  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1809         NULL check.
1810
1811 2019-06-25  Tom Tromey  <tom@tromey.com>
1812
1813         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1814         Inline constructor.  Add initializers for members.
1815         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1816         constructors; now inline in class.
1817
1818 2019-06-25  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-regs.c (tui_show_registers): Update.
1821         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1822         bool.
1823         * tui/tui-data.c (tui_data_window::clear_detail)
1824         (tui_data_window): Update.
1825
1826 2019-06-25  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-windata.c (tui_display_all_data)
1829         (tui_display_data_from_line, tui_display_data_from)
1830         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1831         Update.
1832         * tui/tui-regs.c (tui_last_regs_line_no)
1833         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1834         (tui_show_registers, tui_show_register_group)
1835         (tui_display_registers_from, tui_display_reg_element_at_line)
1836         (tui_display_registers_from_line, tui_check_register_values)
1837         (tui_reg_next, tui_reg_prev): Update.
1838         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1839         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1840         tui_data_window.
1841         (struct tui_win_info) <detail>: Remove.  Add new fields from
1842         tui_data_info.
1843         (TUI_DATA_WIN): Add cast.
1844         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1845         (~tui_data_window): Simplify.
1846
1847 2019-06-25  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-layout.c (show_source_disasm_command)
1850         (show_source_or_disasm_and_command): Update.
1851         * tui/tui-io.c (update_cmdwin_start_line)
1852         (tui_redisplay_readline): Update.
1853         * tui/tui-data.h (struct tui_command_info): Remove.
1854         (struct tui_win_info) <detail>: Remove command_info member.
1855         (struct tui_data_window) <start_line>: New member, from
1856         tui_command_info.
1857         (TUI_CMD_WIN): Add casts.
1858
1859 2019-06-25  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-winsource.c (tui_update_source_window)
1862         (tui_refill_source_window)
1863         (tui_source_window_base::do_scroll_horizontal)
1864         (tui_update_breakpoint_info, tui_set_exec_info_content)
1865         (tui_show_exec_info_content, tui_erase_exec_info_content)
1866         (tui_clear_exec_info_content): Update.
1867         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1868         Update.
1869         * tui/tui-win.c (make_invisible_and_set_new_height)
1870         (make_visible_with_new_height): Update.
1871         * tui/tui-source.c (tui_set_source_content)
1872         (tui_show_symtab_source): Update.
1873         * tui/tui-layout.c (extract_display_start_addr)
1874         (show_source_disasm_command, show_data)
1875         (make_source_or_disasm_window)
1876         (show_source_or_disasm_and_command): Update.
1877         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1878         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1879         "gdbarch".
1880         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1881         to tui_source_window_base.
1882         (struct tui_win_info) <detail>: Remove source_info member.
1883         (struct tui_source_window_base) <has_locator>: Inline.
1884         Move contents from tui_source_info; rename has_locator member to
1885         m_has_locator.
1886         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1887         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1888         header file.
1889         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1890         Simplify.
1891         (tui_free_all_source_wins_content): Cast to
1892         tui_source_window_base.
1893
1894 2019-06-25  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-win.c (make_invisible_and_set_new_height)
1897         (make_visible_with_new_height): Call has_locator method.
1898         * tui/tui-layout.c (show_source_disasm_command, show_data)
1899         (show_source_or_disasm_and_command): Update for bool change.
1900         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1901         (tui_win_info) <has_locator>: New method.
1902         (struct tui_source_window_base) <has_locator>: New method.
1903         (tui_win_has_locator): Don't declare.
1904         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1905         from tui_win_has_locator.
1906         (tui_source_window_base): Use false, not FALSE.
1907
1908 2019-06-25  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1911         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1912         clear_detail method directly.
1913         (tui_clear_win_detail): Remove.
1914
1915 2019-06-25  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1918         "this", not TUI_DISASM_WIN.
1919
1920 2019-06-25  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1923         declare.
1924         * tui/tui-winsource.c
1925         (tui_source_window_base::do_scroll_horizontal): Rename from
1926         tui_horizontal_source_scroll.
1927         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1928         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1929         from tui_vertical_data_scroll.
1930         * tui/tui-win.h (tui_scroll): Don't declare.
1931         * tui/tui-win.c (tui_win_info::forward_scroll)
1932         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1933         (tui_win_info::right_scroll): Rename and update.
1934         (tui_scroll_forward_command, tui_scroll_backward_command)
1935         (tui_scroll_left_command, tui_scroll_right_command): Update.
1936         (tui_scroll): Remove.
1937         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1938         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1939         from tui_vertical_source_scroll.
1940         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1941         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1942         from tui_vertical_disassem_scroll.
1943         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1944         do_scroll_horizontal>: New methods.
1945         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1946         Likewise.
1947         (struct tui_source_window_base): Add do_scroll_horizontal.
1948         (struct tui_source_window, struct tui_disasm_window): Add
1949         do_scroll_vertical.
1950         (struct tui_data_window, struct tui_cmd_window): Add
1951         do_scroll_horizontal and do_scroll_vertical.
1952         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1953
1954 2019-06-25  Tom Tromey  <tom@tromey.com>
1955
1956         * tui/tui-data.h (struct tui_source_window_base): New struct.
1957         (struct tui_source_window): Derive from tui_source_window_base.
1958         (struct tui_disasm_window): New struct.
1959         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1960         from tui_source_window::clear_detail.
1961         (tui_source_window_base): Rename from tui_source_window.
1962         (~tui_source_window_base): Rename from ~tui_source_window.
1963         (tui_alloc_win_info): Create a tui_disasm_window.
1964
1965 2019-06-25  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-data.h (struct tui_source_window)
1968         (struct tui_data_window): Declare destructors.
1969         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1970         destructors.
1971         (tui_win_info): Simplify.
1972
1973 2019-06-25  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-winsource.c (tui_display_main)
1976         (tui_update_source_windows_with_addr)
1977         (tui_update_all_breakpoint_info): Update.
1978         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1979         (new_height_ok, parse_scrolling_args): Update.
1980         * tui/tui-stack.c (tui_show_frame_info): Update.
1981         * tui/tui-data.h (struct tui_list): Remove.
1982         (tui_source_windows): Return a reference to a std::vector.
1983         * tui/tui-data.c (source_windows): Now a std::vector.
1984         (tui_source_windows): Change return type.
1985         (tui_clear_source_windows): Rewrite.
1986         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1987         (tui_free_all_source_wins_content): Rewrite.
1988
1989 2019-06-25  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1992         (struct tui_data_window, struct tui_cmd_window): Declare
1993         clear_detail method.
1994         * tui/tui-data.c (tui_source_window::clear_detail)
1995         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1996         methods.
1997         (tui_clear_win_detail): Simplify.
1998
1999 2019-06-25  Tom Tromey  <tom@tromey.com>
2000
2001         * tui/tui-layout.c (make_source_window, make_disasm_window)
2002         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2003         Return the new window.
2004         (show_source_disasm_command, show_data)
2005         (show_source_or_disasm_and_command): Update.
2006
2007 2019-06-25  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2010         parameter.  Return the new window.
2011         (show_source_disasm_command): Update and remove NULL check.
2012         (show_source_or_disasm_and_command): Update.
2013
2014 2019-06-25  Tom Tromey  <tom@tromey.com>
2015
2016         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2017
2018 2019-06-25  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-data.h (struct tui_win_info): Make constructor
2021         protected.  Make destructor virtual.  Add initializers.
2022         (tui_source_window, tui_data_window, tui_cmd_window): New
2023         classes.
2024         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2025         constructor.  Add "type" parameter.
2026         (tui_source_window, tui_data_window, tui_cmd_window): New
2027         constructors.
2028         (tui_alloc_win_info): Instantiate the appropriate subclass.
2029
2030 2019-06-25  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-win.c (tui_resize_all): Use delete.
2033         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2034         destructor.
2035         (tui_free_window): Don't declare.
2036         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2037         Update.
2038
2039 2019-06-25  Tom Tromey  <tom@tromey.com>
2040
2041         * tui/tui-data.h (struct tui_win_info): Add constructor.
2042         * tui/tui-data.c (tui_alloc_win_info): Use new.
2043         (tui_free_window): Use delete.
2044
2045 2019-06-22  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2048         declare.
2049         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2050
2051 2019-06-22  Tom Tromey  <tom@tromey.com>
2052
2053         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2054         declare.
2055         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2056
2057 2019-06-22  Tom de Vries  <tdevries@suse.de>
2058
2059         * dwarf2read.c (create_addrmap_from_aranges)
2060         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2061         instead of '%zu'.
2062
2063 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2064
2065         * dwarf2read.h (dwarf2_section_info_def): Remove.
2066         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2067         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2068         std::vector<dwarf2_section_info>.
2069         (struct dwo_file) <~dwo_file>: Remove.
2070         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2071         types field.
2072         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2073         (dwarf2_read_debug_names): Likewise.
2074         (create_debug_types_hash_table): Change parameter type to
2075         array_view, adjust code accordingly.
2076         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2077         (partial_die_info::fixup): Likewise.
2078         (determine_prefix): Likewise.
2079         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2080
2081 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2082
2083         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2084         gdb_bfd_ref_ptr.
2085         <~dwo_file>: Remove call to gdb_bfd_unref.
2086         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2087         gdb_bfd_ref_ptr::get.
2088
2089 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2090
2091         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2092         type to htab_up.
2093         * dwarf2read.c (struct dwo_file): Initialize fields.
2094         <~dwo_file>: New.
2095         (free_dwo_file): Remove, move content to ~dwo_file.
2096         (struct dwo_file_deleter): Remove.
2097         (dwo_file_up>: Remove custom deleter.
2098         (free_dwo_files): Remove.
2099         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2100         dwo_files.
2101         (process_skeletonless_type_units): Call unique_ptr::get.
2102         (allocate_dwo_file_hash_table): Add deleter to created hash
2103         table.  Change return type to htab_up.
2104         (lookup_dwo_file_slot): Don't memset dwo_file, call
2105         unique_ptr::get.
2106         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2107         (create_dwo_unit_in_dwp_v2): Likewise.
2108         (open_and_init_dwo_file): Likewise.
2109         (free_dwo_file_from_slot): Remove.
2110
2111 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2112
2113         * dwarf2read.h (struct dwarf2_section_info) <readin,
2114         is_virtual>: Change type to bool.
2115         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2116         true instead of 1.
2117
2118 2019-06-19  Tom Tromey  <tom@tromey.com>
2119
2120         * tui/tui-data.h (tui_init_content_element): Don't declare.
2121
2122 2019-06-19  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-data.h (tui_init_win_info): Don't declare.
2125
2126 2019-06-19  Tom de Vries  <tdevries@suse.de>
2127
2128         * dwarf2read.h (abstract_to_concrete): Change type to
2129         std::unordered_map<sect_offset, std::vector<sect_offset>,
2130         gdb::hash_enum<sect_offset>>.
2131
2132 2019-06-19  Tom Tromey  <tromey@adacore.com>
2133
2134         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2135         EVAL_AVOID_SIDE_EFFECTS specially.
2136
2137 2019-06-19  Tom Tromey  <tromey@adacore.com>
2138
2139         * source-cache.c (highlighter): New global.
2140         (source_cache::get_source_lines): Create a highlighter on demand.
2141
2142 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2143
2144         * defs.h (deprecated_interactive_hook): Delete declaration.
2145         * interps.c (clear_interpreter_hooks): Remove use of
2146         deprecated_interactive_hook.
2147         * top.c (deprecated_interactive_hook): Delete definition.
2148         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2149
2150 2019-06-18  Tom de Vries  <tdevries@suse.de>
2151
2152         PR gdb/24515
2153         * dwarf2read.h (abstract_to_concrete): Change type from
2154         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2155         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2156         * dwarf2read.c (read_variable): Update.
2157         (dwarf2_fetch_die_loc_sect_off): Update.
2158
2159 2019-06-17  Tom de Vries  <tdevries@suse.de>
2160
2161         PR gdb/24617
2162         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2163         accessing parent[parent_len - 1].
2164
2165 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2166
2167         PR gdb/24364
2168         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2169         call dtrace_process_dof with NULL dof.
2170
2171 2019-06-16  Tom de Vries  <tdevries@suse.de>
2172
2173         PR gdb/24445
2174         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2175
2176 2019-06-16  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2179         (make_all_visible): Use address of member.
2180
2181 2019-06-16  Tom Tromey  <tom@tromey.com>
2182
2183         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2184         (tui_free_window, free_content, free_content_elements): Remove
2185         unnecessary cast.
2186         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2187         cast.
2188         * tui/tui-regs.c (tui_show_register_group)
2189         (tui_display_registers_from, tui_display_reg_element_at_line):
2190         Remove unnecessary cast.
2191
2192 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2193
2194         * linux-nat.c (normal_mask): Delete.
2195         (_initialize_linux_nat): Don't initialise normal_mask.
2196
2197 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2198
2199         PR gdb/24445
2200         * dwarf-index-write.h (write_psymtabs_to_index): Add
2201         dwz_basename parameter.
2202         * dwarf-index-write.c (write_gdbindex): Move file writing to
2203         write_gdbindex_1.  Change return type void.
2204         (assert_file_size): Move up, remove filename parameter.
2205         (write_gdbindex_1): New function.
2206         (write_debug_names): Change return type to void, call
2207         assert_file_size.
2208         (struct index_wip_file): New struct.
2209         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2210         file logic to index_wip_file.  Write index for dwz file if
2211         needed.
2212         (save_gdb_index_command): Pass basename of dwz file, if present.
2213         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2214         build-id of dwz file, if present.
2215         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2216         (dwarf2_get_dwz_file): Likewise.
2217         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2218         (dwarf2_get_dwz_file): Likewise.
2219
2220 2019-06-16  Tom Tromey  <tom@tromey.com>
2221
2222         * coffread.c (process_coff_symbol): Use xstrdup.
2223         * value.c (create_internalvar): Use xstrdup.
2224
2225 2019-06-16  Tom Tromey  <tom@tromey.com>
2226
2227         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2228         * breakpoint.c (stopin_command, stopat_command)
2229         (until_break_command, decode_location_default): Remove unnecessary
2230         cast.
2231         * utils.c (subset_compare): Remove unnecessary cast.
2232         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2233         cast.
2234         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2235         cast.
2236         * infcmd.c (path_command): Remove unnecessary cast.
2237         * coffread.c (decode_type): Remove unnecessary cast.
2238         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2239         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2240         * tui/tui-stack.c (tui_show_locator_content)
2241         (tui_show_frame_info): Remove unnecessary cast.
2242         * tui/tui-win.c (tui_scroll_forward_command)
2243         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2244         (parse_scrolling_args): Remove unnecessary cast.
2245         * tui/tui-data.c (init_win_info, tui_del_window)
2246         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2247         (free_content_elements): Remove unnecessary cast.
2248         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2249         unnecessary cast.
2250         * tui/tui-source.c (tui_set_source_content)
2251         (tui_vertical_source_scroll): Remove unnecessary cast.
2252         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2253         cast.
2254         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2255         * tui/tui-regs.c (tui_display_registers_from)
2256         (tui_display_register): Remove unnecessary cast.
2257         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2258         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2259         (make_visible): Remove unnecessary cast.
2260         * tui/tui-winsource.c (tui_erase_source_content)
2261         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2262         unnecessary cast.
2263         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2264         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2265         * stabsread.c (read_type, read_array_type, read_range_type):
2266         Remove unnecessary cast.
2267         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2268         (parse_symbol, parse_type, upgrade_type, parse_external)
2269         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2270         unnecessary cast.
2271         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2272
2273 2019-06-16  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-data.c (tui_alloc_generic_win_info)
2276         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2277         checks.
2278
2279 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2280             Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * f-typeprint.c (f_print_type): Don't return early for not
2283         associated or not allocated types.
2284         (f_type_print_varspec_suffix): Add print_rank parameter and print
2285         ranks of array types in case they dangling.
2286         (f_type_print_base): Add print_rank parameter.
2287
2288 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * NEWS: Mention new MI commands.
2291         * break-catch-throw.c (enum exception_event_kind): Move to
2292         breakpoint.h.
2293         (print_mention_exception_catchpoint): Output text as a single
2294         message.
2295         (catch_exception_command_1): Rename to...
2296         (catch_exception_event): ...this, make non-static, update header
2297         command, and change some parameter types.
2298         (catch_catch_command): Update for changes to
2299         catch_exception_command_1.
2300         (catch_throw_command): Likewise.
2301         (catch_rethrow_command): Likewise.
2302         * breakpoint.c (enum exception_event_kind): Delete.
2303         * breakpoint.h (enum exception_event_kind): Moved here from
2304         break-catch-throw.c.
2305         (catch_exception_event): Declare.
2306         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2307         (mi_cmd_catch_throw): New function.
2308         (mi_cmd_catch_rethrow): New function.
2309         (mi_cmd_catch_catch): New function.
2310         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2311         'catch-catch' entries.
2312         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2313         (mi_cmd_catch_rethrow): Declare.
2314         (mi_cmd_catch_catch): Declare.
2315
2316 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2317
2318         * annotate.c (annotate_source_line): Change return type to void,
2319         update implementation to match.
2320         * annotate.h (annotate_source_line): Change return type to void,
2321         update header comment.
2322         * stack.c (print_frame_info): Don't change what frame information
2323         is printed based on whether annotations are on or not.
2324
2325 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2326
2327         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2328         (annotate_source): Make static.
2329         (annotate_source_line): Moved from source.c and renamed from
2330         identify_source_line.  Update the return type.
2331         * annotate.h (annotate_source): Delete declaration.
2332         (annotate_source_line): Declaration moved from source.h, and
2333         renamed from identify_source_line.  Return type updated.
2334         * source.c (identify_source_line): Moved to annotate.c and renamed
2335         to annotate_source_line.
2336         (info_line_command): Remove check of annotation_level.
2337         * source.h (identify_source_line): Move declaration to annotate.h
2338         and rename to annotate_source_line.
2339         * stack.c: Add 'annotate.h' include.
2340         (print_frame_info): Remove check of annotation_level before
2341         calling annotate_source_line.
2342
2343 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2344
2345         * source-cache.c (source_cache::get_plain_source_lines): Use
2346         open_source_file_with_line_charpos instead of just
2347         open_source_file, remove call to find_source_lines.
2348         (source_cache::get_source_lines): Likewise.
2349         * source.c (find_source_lines): Make static.
2350         (get_filename_and_charpos): Renamed into...
2351         (open_source_file_with_line_charpos): ..this along with changes to
2352         return a scoped_fd, and some other minor clean ups.
2353         (identify_source_line): Use open_source_file_with_line_charpos.
2354         (search_command_helper): Use open_source_file_with_line_charpos
2355         instead of just open_source_file, remove call to
2356         find_source_lines.
2357         * source.h (open_source_file_with_line_charpos): Declare new
2358         function.
2359         (find_source_lines): Delete declaration.
2360
2361 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2362
2363         * source.c (get_filename_and_charpos): Remove fullname
2364         parameter.
2365         (identify_source_line): Update call to get_filename_and_charpos.
2366
2367 2019-06-14  Tom Tromey  <tromey@adacore.com>
2368
2369         PR gdb/24502:
2370         * ui-style.h (skip_ansi_escape): Update comment.
2371         * ui-file.h (class no_terminal_escape_file): New class.
2372         * ui-file.c (no_terminal_escape_file::write)
2373         (no_terminal_escape_file::puts): New methods.
2374         * cli/cli-logging.c (handle_redirections): Use
2375         no_terminal_escape_file.
2376
2377 2019-06-14  Tom Tromey  <tromey@adacore.com>
2378
2379         * NEWS: Move convenience variable news above Python news.
2380
2381 2019-06-14  Tom Tromey  <tom@tromey.com>
2382
2383         * gnulib: Move directory to top-level.
2384         * configure.ac: Don't configure gnulib.
2385         * configure: Rebuild.
2386         * common/common-defs.h: Use new path to gnulib.
2387         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2388         (GNULIB_H): Remove.
2389         (INCGNU): Look in new gnulib location.
2390         (HFILES_NO_SRCDIR): Remove gnulib files.
2391         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2392         (generated_files): Remove GNULIB_H.
2393         ($(LIBGNU), all-lib): Remove targets.
2394         (distclean): Don't mention GNULIB_BUILDDIR.
2395         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2396
2397 2019-06-14  Tom Tromey  <tromey@adacore.com>
2398
2399         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2400         Warn if symbol file does not provide any symbols.
2401
2402 2019-06-14  Tom Tromey  <tromey@adacore.com>
2403
2404         * source.c (find_and_open_source): Respect basenames_may_differ.
2405
2406 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2407
2408         * annotate.c (annotate_breakpoints_invalid): Make use of
2409         scoped_restore_terminal_state.
2410         (annotate_frames_invalid): Likewise.
2411
2412 2019-06-14  Tom Tromey  <tromey@adacore.com>
2413
2414         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2415         allow assignment to an internalvar.
2416
2417 2019-06-14  Tom Tromey  <tromey@adacore.com>
2418
2419         * ada-lex.l: Allow "_" in attribute names.
2420
2421 2019-06-14  Tom Tromey  <tromey@adacore.com>
2422
2423         PR gdb/24653:
2424         * regcache.c (registers_changed): Don't call alloca.
2425         * top.c (execute_command): Don't call alloca.
2426
2427 2019-06-13  Pedro Alves  <palves@redhat.com>
2428
2429         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2430         'expression'.  When parsing an expression, error out if there's
2431         junk after "unlimited".
2432         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2433         (do_set_command): Adjust calls to is_unlimited_literal.
2434
2435 2019-06-13  Pedro Alves  <palves@redhat.com>
2436
2437         * compile/compile.c (make_compile_options_def_group): Add braces
2438         around array_view initializer.
2439         * thread.c (make_thread_apply_all_options_def_group)
2440         (make_thread_apply_all_options_def_group): Likewise.
2441
2442 2019-06-13  Pedro Alves  <palves@redhat.com>
2443
2444         * NEWS (New commands): Mention "maint test-options
2445         require-delimiter", "maint test-options unknown-is-error", "maint
2446         test-options unknown-is-operand" and "maint show
2447         test-options-completion-result".
2448         (New command options, command completion): New section.
2449         (Completion improvements): New section.
2450         Mention that you can abbreviate "unlimited".
2451
2452 2019-06-13  Pedro Alves  <palves@redhat.com>
2453
2454         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2455         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2456         * unittests/cli-utils-selftests.c (test_parse_flags)
2457         (test_parse_flags_qcs): Delete.
2458         (test_cli_utils): Don't call deleted functions.
2459
2460 2019-06-13  Pedro Alves  <palves@redhat.com>
2461
2462         * thread.c: Include "cli/cli-option.h".
2463         (tp_array_compar_ascending): Global.
2464         (tp_array_compar): Delete function.
2465         (tp_array_compar_ascending, tp_array_compar_descending): New
2466         functions.
2467         (ascending_option_def, qcs_flag_option_def)
2468         (thr_qcs_flags_option_defs)
2469         (make_thread_apply_all_options_def_group)
2470         (make_thread_apply_options_def_group): New.
2471         (thread_apply_all_command): Use gdb::option::process_options.
2472         (thread_apply_command_completer)
2473         (thread_apply_all_command_completer): New.
2474         (thread_apply_command): Use gdb::option::process_options.
2475         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2476         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2477         to generate help text of "thread apply".  Adjust "taas"'s help.
2478         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2479         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2480
2481 2019-06-13  Pedro Alves  <palves@redhat.com>
2482
2483         * thread.c (thread_apply_command): Check for invalid TID with
2484         isdigit instead of !isalpha.
2485
2486 2019-06-13  Pedro Alves  <palves@redhat.com>
2487
2488         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2489         (validate_flags_qcs): New.
2490         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2491         (validate_flags_qcs): Declare.
2492         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2493         (make_frame_apply_options_def_group): New.
2494         (frame_apply_command_count): Process options with
2495         gdb::option::process_options.
2496         (frame_apply_completer): New.
2497         (frame_apply_level_completer, frame_apply_all_completer)
2498         (frame_apply_completer): New.
2499         (_initialize_stack): Update help of "frame apply", "frame apply
2500         level", "frame apply all" and "faas" to mention supported options
2501         and install command completers.
2502         * stack.h (frame_apply_all_completer): Declare.
2503         * thread.c: Include "stack.h".
2504         (tfaas_command): Add "--".
2505         (_initialize_thread): Update help "tfaas" to mention supported
2506         options and install command completer.
2507
2508 2019-06-13  Pedro Alves  <palves@redhat.com>
2509
2510         * completer.c (complete_nested_command_line): New.
2511         (gdb_completion_word_break_characters_throw): Add assertion.
2512         * completer.h (complete_nested_command_line): Declare.
2513
2514 2019-06-13  Pedro Alves  <palves@redhat.com>
2515
2516         * stack.c (parse_backtrace_qualifiers): New.
2517         (backtrace_command): Use it.
2518         (backtrace_command_completer): Complete on qualifiers.
2519
2520 2019-06-13  Pedro Alves  <palves@redhat.com>
2521
2522         * frame.c: Include "cli/cli-option.h.
2523         (user_set_backtrace_options): New.
2524         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2525         Delete.
2526         (get_prev_frame): Adjust.
2527         (boolean_option_def, uinteger_option_def)
2528         (set_backtrace_option_defs): New.
2529         (_initialize_frame): Adjust and use
2530         gdb::option::add_setshow_cmds_for_options to install "set
2531         backtrace past-main" and "set backtrace past-entry".
2532         * frame.h: Include "cli/cli-option.h".
2533         (struct frame_print_options): Forward declare.
2534         (print_frame_arguments_all, print_frame_arguments_scalars)
2535         (print_frame_arguments_none): Declare.
2536         (print_entry_values): Delete declaration.
2537         (struct frame_print_options, user_frame_print_options): New.
2538         (struct set_backtrace_options): New.
2539         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2540         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2541         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2542         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2543         (list_args_or_locals): Add frame_print_options parameter.
2544         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2545         * python/py-framefilter.c (enumerate_args): Pass down
2546         USER_FRAME_PRINT_OPTIONS.
2547         * stack.c: Include "cli/cli-option.h".
2548         (print_frame_arguments_all, print_frame_arguments_scalars)
2549         (print_frame_arguments_none): Declare.
2550         (print_raw_frame_arguments, print_entry_values): Delete.
2551         (user_frame_print_options): New.
2552         (boolean_option_def, enum_option_def, frame_print_option_defs):
2553         New.
2554         (struct backtrace_cmd_options): New.
2555         (bt_flag_option_def): New.
2556         (backtrace_command_option_defs): New.
2557         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2558         (print_frame_arg, read_frame_arg, print_frame_args)
2559         (print_frame_info, print_frame): Add frame_print_options parameter
2560         and use it.
2561         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2562         (backtrace_command_1): Add frame_print_options and
2563         backtrace_cmd_options parameters and use them.
2564         (make_backtrace_options_def_group): New.
2565         (backtrace_command): Process command options with
2566         gdb::option::process_options.
2567         (backtrace_command_completer): New.
2568         (_initialize_stack): Extend "backtrace"'s help to mention
2569         supported options.  Install completer for "backtrace".
2570         Install some settings commands with add_setshow_cmds_for_options.
2571
2572 2019-06-13  Pedro Alves  <palves@redhat.com>
2573
2574         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2575         and that "set/show print raw frame-arguments" are now deprecated.
2576
2577         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2578         command.
2579         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2580         * stack.c (_initialize_stack): Install "set/show print
2581         raw-frame-arguments", and deprecate "set/show print raw
2582         frame-arguments".
2583         * valprint.c (_initialize_valprint): Deprecate "set/show print
2584         raw".
2585
2586 2019-06-13  Pedro Alves  <palves@redhat.com>
2587
2588         * compile/compile.c (struct compile_options): New.
2589         (compile_flag_option_def, compile_command_option_defs)
2590         (make_compile_options_def_group): New.
2591         (compile_file_command): Handle options with
2592         gdb::option::process_options.
2593         (compile_file_command_completer): New function.
2594         (compile_code_command): Handle options with
2595         gdb::option::process_options.
2596         (compile_code_command_completer): New function.
2597         (_initialize_compiler): Install completers for "compile code" and
2598         "compile file".  Mention available options in "compile code" and
2599         "compile code"'s help.
2600         * completer.c (advance_to_completion_word): New, factored out from
2601         ...
2602         (advance_to_expression_complete_word_point): ... this.
2603         (advance_to_filename_complete_word_point): New.
2604         * completer.h (advance_to_filename_complete_word_point): New
2605         declaration.
2606
2607 2019-06-13  Pedro Alves  <palves@redhat.com>
2608
2609         * compile/compile.c: Include "cli/cli-option.h".
2610         (compile_print_value): Scope data pointer is now a
2611         value_print_options pointer; adjust.
2612         (compile_print_command): Process options.  Scope data pointer is
2613         now a value_print_options pointer; adjust.
2614         (_initialize_compile): Update "compile print"'s help to include
2615         supported options.  Install a completer for "compile print".
2616         * cp-valprint.c (show_vtblprint, show_objectprint)
2617         (show_static_field_print): Delete.
2618         (_initialize_cp_valprint): Don't install "set print
2619         static-members", "set print vtbl", "set print object" here.
2620         * printcmd.c: Include "cli/cli-option.h" and
2621         "common/gdb_optional.h".
2622         (print_command_parse_format): Rework to fill in a
2623         value_print_options instead of a format_data.
2624         (print_value): Change parameter type from format_data pointer to
2625         value_print_options reference.  Adjust.
2626         (print_command_1): Process options.  Adjust to pass down a
2627         value_print_options.
2628         (print_command_completer): New.
2629         (_initialize_printcmd): Install print_command_completer as
2630         handle_brkchars completer for the "print" command.  Update
2631         "print"'s help to include supported options.
2632         * valprint.c: Include "cli/cli-option.h".
2633         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2634         here from cp-valprint.c.
2635         (boolean_option_def, uinteger_option_def)
2636         (value_print_option_defs, make_value_print_options_def_group):
2637         New.  Use gdb::option::add_setshow_cmds_for_options to install
2638         "set print elements", "set print null-stop", "set print repeats",
2639         "set print pretty", "set print union", "set print array", "set
2640         print address", "set print symbol", "set print array-indexes".
2641         * valprint.h: Include <string> and "cli/cli-option.h".
2642         (make_value_print_options_def_group): Declare.
2643         (print_value): Change parameter type from format_data pointer to
2644         value_print_options reference.
2645         (print_command_completer): Declare.
2646
2647 2019-06-13  Pedro Alves  <palves@redhat.com>
2648
2649         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2650         (COMMON_SFILES): Add maint-test-settings.c.
2651         * cli/cli-decode.c (boolean_enums): New global, factored out from
2652         ...
2653         (add_setshow_boolean_cmd): ... here.
2654         * cli/cli-decode.h (boolean_enums): Declare.
2655         * cli/cli-option.c: New file.
2656         * cli/cli-option.h: New file.
2657         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2658         factored out from ...
2659         (parse_cli_boolean_value(const char *)): ... this.
2660         (is_unlimited_literal): Change parameter type to pointer to
2661         pointer.  Adjust and advance ARG pointer.
2662         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2663         (parse_cli_var_enum): New, factored out from ...
2664         (do_set_command): ... this.  Adjust.
2665         * cli/cli-setshow.h (parse_cli_boolean_value)
2666         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2667         (parse_cli_var_enum): Declare.
2668         * cli/cli-utils.c: Include "cli/cli-option.h".
2669         (get_ulongest): New.
2670         * cli/cli-utils.h (get_ulongest): Declare.
2671         (check_for_argument): New overloads.
2672         * maint-test-options.c: New file.
2673
2674 2019-06-13  Pedro Alves  <palves@redhat.com>
2675
2676         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2677         parse a range if "-" is at the end of the string.
2678
2679 2019-06-13  Pedro Alves  <palves@redhat.com>
2680
2681         * cli/cli-setshow.c (parse_auto_binary_operation)
2682         (parse_cli_boolean_value): Don't allow "o".
2683
2684 2019-06-13  Pedro Alves  <palves@redhat.com>
2685
2686         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2687         * NEWS: Mention maint test-settings KIND.
2688         * maint-test-settings.c: New file.
2689
2690 2019-06-13  Pedro Alves  <palves@redhat.com>
2691
2692         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2693         completer.
2694         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2695         "set" completers.
2696
2697 2019-06-13  Pedro Alves  <palves@redhat.com>
2698
2699         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2700         after item.
2701
2702 2019-06-13  Pedro Alves  <palves@redhat.com>
2703
2704         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2705
2706 2019-06-13  Pedro Alves <palves@redhat.com>
2707
2708         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2709         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2710         call.
2711         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2712         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2713         calls.
2714         (check_for_argument): Skip spaces after argument.
2715
2716 2019-06-13  Pedro Alves  <palves@redhat.com>
2717
2718         * thread.c (thread_apply_command): Adjust TID parsing.
2719         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2720         detected before end of string.
2721         (tid_is_in_list): Error out if LIST is invalid.
2722
2723 2019-06-13  Pedro Alves  <palves@redhat.com>
2724
2725         * completer.c (complete_line_internal_1): Rewind completion word
2726         point.
2727         (completion_tracker::advance_custom_word_point_by): Change
2728         parameter type to int.
2729         * completer.h (completion_tracker::advance_custom_word_point_by):
2730         Likewise.
2731
2732 2019-06-13  Pedro Alves  <palves@redhat.com>
2733
2734         * completer.c (advance_to_completion_word): Handle delimiters.
2735
2736 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2737
2738         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2739
2740 2019-06-11  Tom Tromey  <tom@tromey.com>
2741
2742         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2743         (xmalloc_failed): Move to alloc.c.
2744         * alloc.c: New file.
2745         * Makefile.in (COMMON_SFILES): Add alloc.c.
2746
2747 2019-06-11  Tom Tromey  <tom@tromey.com>
2748
2749         * nat/linux-waitpid.c: Don't include server.h.
2750         (linux_debug): Remove.
2751         (my_waitpid): Update.
2752
2753 2019-06-11  Tom Tromey  <tromey@adacore.com>
2754
2755         * infcall.c (_initialize_infcall): Remove trailing newline from
2756         help.
2757         * user-regs.c (_initialize_user_regs): Remove trailing newline
2758         from help.
2759         * typeprint.c (_initialize_typeprint): Remove trailing newline
2760         from help.
2761         * reverse.c (_initialize_reverse): Remove trailing newlines from
2762         help.
2763         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2764         from help.
2765         * language.c (add_set_language_command): Remove trailing newline
2766         from help.
2767         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2768         help.
2769         * disasm.c (_initialize_disasm): Remove trailing newline from
2770         help.
2771         * top.c (init_main): Remove trailing newline from help.
2772         * interps.c (_initialize_interpreter): Remove trailing newline
2773         from help.
2774         * btrace.c (_initialize_btrace): Remove trailing newlines from
2775         help.
2776         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2777         from help.
2778         * python/python.c (_initialize_python): Remove trailing newline
2779         from help.
2780         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2781         help.
2782         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2783         from help.  Reformat some text.
2784         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2785         from help.
2786         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2787         newline from help.
2788
2789 2019-06-11  Tom Tromey  <tromey@adacore.com>
2790
2791         * darwin-nat.c (darwin_decode_exception_message)
2792         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2793
2794 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2795
2796         * valops.c (value_slice): Check for not allocated or not
2797         associated values.
2798
2799 2019-06-10  Tom de Vries  <tdevries@suse.de>
2800
2801         PR gdb/24618
2802         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2803         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2804         invalid.
2805
2806 2019-06-10  Tom de Vries  <tdevries@suse.de>
2807
2808         PR gdb/24611
2809         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2810         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2811
2812 2019-06-10  Tom de Vries  <tdevries@suse.de>
2813
2814         PR symtab/24545
2815         * symtab.c (struct demangled_name_entry): Add language field.
2816         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2817         static minimal symbol".  Set and use language field.
2818
2819 2019-06-10  Tom Tromey  <tromey@adacore.com>
2820
2821         * ada-lang.c (_initialize_ada_language): Update help text.
2822
2823 2019-06-10  Tom Tromey  <tromey@adacore.com>
2824
2825         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2826         with a newline.
2827         * guile/guile.c (handle_boot_error): Don't end warning with a
2828         newline.
2829         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2830         warning with a newline.
2831         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2832         newline.
2833         (s12z_frame_cache): Likewise.
2834         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2835         a newline.
2836         * solib-svr4.c (disable_probes_interface): Don't end warning with
2837         a newline.
2838         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2839         newline.
2840         * python/python.c (do_finish_initialization): Don't end warning
2841         with a newline.
2842
2843 2019-06-10  Tom Tromey  <tom@tromey.com>
2844
2845         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2846         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2847         gdbpy_enter.
2848
2849 2019-06-10  Tom Tromey  <tromey@adacore.com>
2850
2851         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2852         data.
2853         (elf_new_init): Don't call stabsread_new_init.
2854         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2855         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2856         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2857
2858 2019-06-10  Tom de Vries  <tdevries@suse.de>
2859
2860         PR symtab/16264
2861         PR symtab/24517
2862         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2863
2864 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2865
2866         * source.c (find_and_open_source): Also rewrite relative file
2867         names.
2868
2869 2019-04-26  Amos Bird  <amosbird@gmail.com>
2870
2871         * annotate.c (annotate_thread_exited): Add "thread-exited"
2872         annotation.
2873
2874 2019-06-06  Tom Tromey  <tromey@adacore.com>
2875
2876         * maint.h (class scoped_command_stats): Use
2877         DISABLE_COPY_AND_ASSIGN.
2878         <print_time>: New method.
2879         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2880         print_time.
2881         (scoped_command_stats::print_time): New method.
2882
2883 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2884
2885         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2886         instructions of lengths 6 or 8 bytes.
2887
2888 2019-06-04  Pedro Alves  <palves@redhat.com>
2889
2890         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2891
2892         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2893         * breakpoint.c (condition_completer): Likewise.
2894         * cli/cli-dump.c (scan_expression): Likewise.
2895         * common/filestuff.c (mkdir_recursive): Likewise.
2896         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2897         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2898         (gdb_abspath): Likewise.
2899         * compile/compile-cplus-types.c
2900         (compile_cplus_instance::decl_name): Likewise.
2901         * completer.c (complete_explicit_location):
2902         (signal_completer, reg_or_group_completer_1): Likewise.
2903         * cp-support.c (cp_remove_params_if_any): Likewise.
2904         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2905         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2906         * infcmd.c (strip_bg_char): Likewise.
2907         * linespec.c (copy_token_string): Likewise.
2908         * mi/mi-main.c (output_cores): Likewise.
2909         * psymtab.c (psymtab_search_name):
2910         * symfile.c (test_set_ext_lang_command): Likewise.
2911         * target.c (target_fileio_read_stralloc): Likewise.
2912         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2913         * value.c (complete_internalvar): Likewise.
2914
2915 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2916
2917         Add objfile property to gdb.Type.
2918         * NEWS: Mention Python API addition.
2919         * python/py-type.c (typy_get_objfile): New method.
2920
2921 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2922
2923         * NEWS: Mention the new set|show style [title|highlight].
2924         Mention changes to "show style", "help" and "apropos".
2925
2926 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2927
2928         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2929         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2930         instead of print_help_for_command.
2931         (print_doc_of_command): New function.
2932         (help_list): Add 'apropos -v word' suggestion.
2933         (print_help_for_command): Style the command name using title style.
2934         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2935         (_initialize_cli_cmds): Describe -v in apropos_command help.
2936
2937 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2938
2939         * cli/cli-style.h (cli_style_option): Add name in constructor,
2940         add m_name class member, add constructor with intensity,
2941         add name class function.
2942         (cli_style_option::add_setshow_commands): Remove name argument.
2943         (highlight_style, title_style): New styles.
2944         * cli/cli-style.c (do_show): New function that shows a style
2945         characteristic styling the style name with itself.
2946         (set_style_name): New function.
2947         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2948         Update all callers according to the changes in cli/cli-style.h.
2949         * utils.h (fputs_highlighted): New function.
2950         * utils.c (fputs_highlighted): Likewise.
2951
2952 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2953
2954         * NEWS: Mention new pipe command and new convenience variables.
2955
2956 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2957
2958         * cli/cli-cmds.c (pipe_command): New function.
2959         (_initialize_cli_cmds): Call add_com for pipe_command.
2960         Define | as an alias for pipe.
2961         (exit_status_set_internal_vars): New function.
2962         (shell_escape): Call exit_status_set_internal_vars.
2963         cli/cli-decode.c (find_command_name_length): Recognize | as
2964         a single character command.
2965
2966 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2967
2968         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2969         top.c (execute_command_to_ui_file): New function, mostly a copy
2970         of execute_command_to_string.
2971         (execute_command_to_string): Implement by calling
2972         execute_command_to_ui_file.
2973
2974 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2975
2976         * top.h (saved_command_line): Remove declaration.
2977         * top.c (previous_saved_command_line, previous_repeat_arguments):
2978         New variables.
2979         (saved_command_line): Make static, define together with other
2980         'repeat variables'.
2981         (dont_repeat): Clear repeat_arguments.
2982         (repeat_previous, get_saved_command_line, save_command_line):
2983         New functions.
2984         (gdb_init): Initialize saved_command_line
2985         and previous_saved_command_line.
2986         * main.c (captured_main_1): Remove saved_command_line initialization.
2987         * event-top.c (handle_line_of_input): Update to use
2988         the new 'repeat' related functions instead of direct access to
2989         saved_command_line.
2990         * command.h (repeat_previous, get_saved_command_line,
2991         save_command_line): New declarations.
2992         (dont_repeat): Add comment.
2993
2994 2019-05-30  Tom Tromey  <tromey@adacore.com>
2995
2996         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2997         Fix comment.
2998         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2999
3000 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3001
3002         PR cli/24587
3003         * completer.c (complete): Initialize variable word.
3004
3005 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3006
3007         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3008         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3009         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3010         'body' is NULL to the outter 'if', protecting the '!is_define'
3011         situation as well.
3012
3013 2019-05-29  Tom Tromey  <tromey@adacore.com>
3014
3015         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3016         (dwarf_unknown): New function.
3017         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3018         (dwarf_type_encoding_name): Use dwarf_unknown.
3019
3020 2019-05-29  Tom Tromey  <tromey@adacore.com>
3021
3022         PR c++/20020:
3023         * cp-valprint.c (cp_print_value_fields): Call
3024         cp_print_static_field inside "try".
3025
3026 2019-05-29  Tom Tromey  <tromey@adacore.com>
3027
3028         * inflow.c (struct terminal_info): Add default operator=.
3029         * configure: Rebuild.
3030         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3031         -Wdeprecated-copy-dtor, -Wredundant-move.
3032
3033 2019-05-29  Tom Tromey  <tromey@adacore.com>
3034
3035         * NEWS: Add entry.
3036         * infcmd.c (print_return_value_1): Handle finish_print
3037         option.
3038         (show_print_finish): New function.
3039         (_initialize_infcmd): Add "set/show print finish" commands.
3040         * valprint.c (user_print_options): Initialize new member.
3041         * valprint.h (struct value_print_options) <finish_print>: New
3042         member.
3043
3044 2019-05-28  Tom Tromey  <tromey@adacore.com>
3045
3046         * ada-lang.c (ada_remove_Xbn_suffix)
3047         (find_old_style_renaming_symbol)
3048         (parse_old_style_renaming): Remove.
3049         (ada_find_renaming_symbol): Don't call
3050         find_old_style_renaming_symbol.
3051         (ada_is_renaming_symbol): Rename from
3052         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3053         bool.  Now static.
3054         (ada_read_var_value): Update and simplify.
3055         * ada-exp.y (write_var_or_type): Remove old code.
3056
3057 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3058
3059         * event-top.c: Remove include comment.
3060         * inflow.c (class scoped_ignore_sigttou): Move from here...
3061         * inflow.h (class scoped_ignore_sigttou): ...to here.
3062         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3063         * top.c:  Remove include comment.
3064
3065 2019-05-27  Tom Tromey  <tom@tromey.com>
3066
3067         * NEWS: Fix typo.
3068
3069 2019-05-22  Tom Tromey  <tromey@adacore.com>
3070
3071         * target.c (target_follow_exec): Constify parameter.
3072         * target-delegates.c: Rebuild.
3073         * remote.c (remote_target::follow_exec): Constify parameter.
3074         * infrun.c (follow_exec): Constify parameter.
3075         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3076         (target_follow_exec): Likewise.
3077
3078 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3079
3080         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3081         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3082
3083 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3084
3085         * NEWS: Add debugredirect and testsuite sections.
3086
3087 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3088
3089         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3090         target descriptions using exclusively floating point register name
3091         aliases.
3092
3093 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3094
3095         PR gdb/18644:
3096         * f-lang.c (build_fortran_types): Handle the case where
3097         gdbarch_floatformat_for_type returns a nullptr.
3098
3099 2019-05-21  Tom de Vries  <tdevries@suse.de>
3100
3101         PR cli/24587
3102         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3103
3104 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3105
3106         PR gdb/18644:
3107         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3108         16-byte floats.
3109         * i386-tdep.c (i386_floatformat_for_type): Use
3110         floatformats_ia64_quad for the 16-byte floating point component
3111         within a fortran 32-byte complex number.
3112
3113 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3114
3115         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3116         delete default constructor.
3117         (find_partial_die): Update to return const struct.
3118         (partial_die_parent_scope): Move variable declaration into scope
3119         of its use and change its type to auto.
3120         (guess_partial_die_structure_name): Likewise.
3121         (partial_die_info::fixup): Likewise.
3122
3123 2019-05-17  Tom Tromey  <tromey@adacore.com>
3124
3125         * source.c (find_and_open_source): Remove cast.
3126
3127 2019-05-17  Tom Tromey  <tromey@adacore.com>
3128
3129         * annotate.c (annotate_source): Make "filename" const.
3130         * annotate.h (annotate_source): Use const.
3131
3132 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3133
3134         * disasm.c (set_disassembler_options): Send errors to stderr.
3135
3136 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3137
3138         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3139         (cli_interp_base::set_logging): Check debug_redirect.
3140         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3141         * cli/cli-logging.c (debug_redirect): Add static variable.
3142         (pop_output_files): Add default param.
3143         (handle_redirections): Print debug setting.
3144         (show_logging_command): Likewise.
3145         (_initialize_cli_logging): Add debugredirect command.
3146         * interps.c (current_interp_set_logging): Add debug_redirect
3147         parameter.
3148         * interps.h (set_logging): Add debug_redirect parameter.
3149         (current_interp_set_logging): Likewise.
3150         * mi/mi-common.h: Likewise.
3151         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3152
3153 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3154             Tom Tromey  <tromey@adacore.com>
3155
3156         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3157         directly.
3158         * cli/cli-interp.h (make_logging_output): Remove declaration.
3159         * cli/cli-logging.c (make_logging_output): Remove function.
3160         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3161         directly.
3162         * ui-file.c (tee_file::tee_file): Remove bools.
3163         (tee_file::~tee_file): Remove deletes.
3164         * ui-file.h (tee_file): Remove bools.
3165
3166 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3167
3168         * mi/mi-cmds.h (mi_cmd_complete): New function.
3169         * mi/mi-main.c (mi_cmd_complete): Likewise.
3170         * mi/mi-cmds.c: Define new MI command -complete.
3171         * NEWS: Mention new -complete command.
3172
3173 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3174
3175         * completer.h (complete): New function.
3176         * completer.c (complete): Likewise.
3177         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3178         function defined in completer.h.
3179
3180 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3181
3182         * MAINTAINERS (Write After Approval): Add myself.
3183
3184 2019-05-17  Tom de Vries  <tdevries@suse.de>
3185
3186         PR gdb/24094
3187         * dwarf2read.c (struct cu_partial_die_info): New struct.
3188         (find_partial_die): Return cu_partial_die_info.
3189         (partial_die_parent_scope, guess_partial_die_structure_name)
3190         (partial_die_info::fixup): Handle new return type of find_partial_die.
3191
3192 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3193
3194         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3195         "std::string", simplifying the algorithm.
3196
3197 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3198
3199         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3200         (stap_static_probe_ops::get_probes): Likewise.
3201
3202 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3203
3204         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3205         '-')" and "else if".
3206         (stap_parse_single_operand): Join checks for
3207         "gdbarch_stap_parse_special_token_p" and
3208         "gdbarch_stap_parse_special_token" in the same "if" statement.
3209         Invert check when verifying for operation on register
3210         displacement.
3211
3212 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3213
3214         * stap-probe.c (stap_get_opcode): Update comment.
3215         (stap_get_expected_argument_type): Likewise.
3216         (handle_stap_probe): Likewise.
3217
3218 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3219
3220         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3221         return type to 'bool'.  Adjust comment.  Use 'bool' when
3222         appropriate.
3223         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3224         * stap-probe.c (stap_parse_argument_1): Likewise.
3225         (stap_is_operator): Likewise.
3226         (stap_is_generic_prefix): Likewise.
3227         (stap_is_register_prefix): Likewise.
3228         (stap_is_register_indirection_prefix): Likewise.
3229         (stap_is_integer_prefix): Likewise.
3230         (stap_generic_check_suffix): Likewise.
3231         (stap_check_integer_suffix): Likewise.
3232         (stap_check_register_suffix): Likewise.
3233         (stap_check_register_indirection_suffix): Likewise.
3234         (stap_parse_register_operand): Likewise.
3235         (stap_parse_single_operand): Likewise.
3236         (stap_parse_argument_1): Likewise.
3237         (stap_probe::get_argument_count): Likewise.
3238         (stap_is_operator): Likewise.
3239
3240 2019-05-16  Tom Tromey  <tromey@adacore.com>
3241
3242         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3243         keyword to foreach.
3244
3245 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3246
3247         * linux-thread-db.c (try_thread_db_load_1): Change return type
3248         to bool.
3249         (try_thread_db_load): Likewise.
3250         (try_thread_db_load_from_pdir_1): Likewise.
3251         (try_thread_db_load_from_pdir): Likewise.
3252         (try_thread_db_load_from_sdir): Likewise.
3253         (try_thread_db_load_from_dir): Likewise.
3254         (thread_db_load_search): Likewise.
3255         (has_libpthread): Likewise.
3256         (thread_db_load): Likewise.
3257
3258 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3259
3260         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3261         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3262         NULL, and complain/return if that's the case.
3263
3264 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3265
3266         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3267         (advance, posn, abstract_read_memory): New functions.
3268         [struct mem_read_abstraction]: New struct.
3269         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3270
3271 2019-05-14  Tom Tromey  <tromey@adacore.com>
3272
3273         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3274         value is not lval_memory.
3275
3276 2019-05-14  Tom Tromey  <tromey@adacore.com>
3277
3278         * solib.c (info_sharedlibrary_command): Style the file name.
3279
3280 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3281
3282         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3283         (aarch64_vnv_type): Likewise.
3284         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3285         * common/tdesc.c: Likewise.
3286         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3287         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3288         * features/aarch64-fpu.xml: Add ieee half view.
3289         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3290         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3291         * gdbtypes.h (struct builtin_type): Likewise.
3292         (struct objfile_type): Likewise.
3293
3294 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3295
3296         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3297         typo.
3298         * location.h (string_to_event_location): Likewise.
3299
3300 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3301
3302         GDB 8.3 released.
3303
3304 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3305
3306         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3307         New variable declaration.
3308         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3309         New variable.
3310         (print_one_breakpoint): Use ui_out::test_flags and new global
3311         variable to compute use_fixed_output.
3312         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3313         Remove.
3314         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3315         (mi_multi_location_breakpoint_output_fixed): Remove.
3316         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3317         new variable.
3318         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3319         fix_multi_location_breakpoint_output flag if version >= 3.
3320         * ui-out.h (enum ui_out_flag)
3321         <fix_multi_location_breakpoint_output>: New enumerator.
3322
3323 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3324
3325         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3326
3327 2019-05-10  Tom Tromey  <tromey@adacore.com>
3328
3329         * ada-lang.c (catch_ada_completer): New function.
3330         (_initialize_ada_language): Use it.
3331
3332 2019-05-10  Tom Tromey  <tromey@adacore.com>
3333
3334         * thread.c (print_thread_info): Make "requested_threads" const.
3335         * gdbthread.h (print_thread_info): Make "requested_threads"
3336         const.
3337         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3338         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3339
3340 2019-05-08  Tom Tromey  <tom@tromey.com>
3341
3342         * gdbtypes.c (objfile_type_data): Change type.
3343         (objfile_type, _initialize_gdbtypes): Update.
3344
3345 2019-05-08  Tom Tromey  <tom@tromey.com>
3346
3347         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3348         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3349         (_initialize_dwarf2_frame): Update.
3350
3351 2019-05-08  Tom Tromey  <tom@tromey.com>
3352
3353         * objc-lang.c (objc_objfile_data): Change type.
3354         (find_methods): Update.
3355         (_initialize_objc_lang): Remove.
3356
3357 2019-05-08  Tom Tromey  <tom@tromey.com>
3358
3359         * stabsread.c (rs6000_builtin_type_data): Change type.
3360         (rs6000_builtin_type, _initialize_stabsread): Update.
3361
3362 2019-05-08  Tom Tromey  <tom@tromey.com>
3363
3364         * mips-tdep.c (mips_pdr_data): Remove.
3365         (_initialize_mips_tdep): Update.
3366
3367 2019-05-08  Tom Tromey  <tom@tromey.com>
3368
3369         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3370         (hppa_init_objfile_priv_data, read_unwind_info)
3371         (find_unwind_entry, _initialize_hppa_tdep): Update.
3372
3373 2019-05-08  Tom Tromey  <tom@tromey.com>
3374
3375         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3376         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3377         on obstack.
3378         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3379
3380 2019-05-08  Tom Tromey  <tom@tromey.com>
3381
3382         * mdebugread.c (basic_type_data): Change type.
3383         (basic_type, _initialize_mdebugread): Update.
3384
3385 2019-05-08  Tom Tromey  <tom@tromey.com>
3386
3387         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3388
3389 2019-05-08  Tom Tromey  <tom@tromey.com>
3390
3391         * nto-tdep.c (nto_inferior_data_reg): Change type.
3392         (nto_inferior_data): Update.
3393         (nto_inferior_data_cleanup, nto_new_inferior_data)
3394         (_initialize_nto_tdep): Remove.
3395         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3396
3397 2019-05-08  Tom Tromey  <tom@tromey.com>
3398
3399         * ada-lang.c (struct ada_inferior_data): Add initializers.
3400         (ada_inferior_data): Change type.
3401         (ada_inferior_data_cleanup): Remove.
3402         (get_ada_inferior_data, ada_inferior_exit)
3403         (struct ada_pspace_data): Add initializers, destructor.
3404         (ada_pspace_data_handle): Change type.
3405         (get_ada_pspace_data): Update.
3406         (ada_pspace_data_cleanup): Remove.
3407
3408 2019-05-08  Tom Tromey  <tom@tromey.com>
3409
3410         * coffread.c (struct coff_symfile_info): Add initializers.
3411         (coff_objfile_data_key): Move lower.  Change type.
3412         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3413         Update.
3414         (coff_free_info): Remove.
3415
3416 2019-05-08  Tom Tromey  <tom@tromey.com>
3417
3418         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3419         (fbsd_pspace_data_handle): Move lower.  Change type.
3420         (get_fbsd_pspace_data): Update.
3421         (fbsd_pspace_data_cleanup): Remove.
3422         (_initialize_fbsd_tdep): Update.
3423
3424 2019-05-08  Tom Tromey  <tom@tromey.com>
3425
3426         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3427         (get_ada_tasks_pspace_data): Update.
3428         (ada_tasks_pspace_data_cleanup): Remove.
3429         (_initialize_tasks): Update.
3430         (ada_tasks_inferior_data_handle): Change type.
3431         (get_ada_tasks_inferior_data): Update.
3432         (ada_tasks_inferior_data_cleanup): Remove.
3433         (struct ada_tasks_pspace_data): Add initializers.
3434
3435 2019-05-08  Tom Tromey  <tom@tromey.com>
3436
3437         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3438         * symfile-debug.c (debug_sym_get_probes): Change type.
3439         * stap-probe.c (handle_stap_probe):
3440         (stap_static_probe_ops::get_probes): Change type.
3441         * probe.h (class static_probe_ops) <get_probes>: Change type.
3442         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3443         (parse_probes_in_pspace): Update.
3444         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3445         Update.
3446         (any_static_probe_ops::get_probes): Change type.
3447         * elfread.c (elfread_data): New typedef.
3448         (probe_key): Change type.
3449         (elf_get_probes): Likewise.  Update.
3450         (probe_key_free): Remove.
3451         (_initialize_elfread): Update.
3452         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3453         Change type.
3454         (dtrace_process_dof_probe, dtrace_process_dof)
3455         (dtrace_static_probe_ops::get_probe): Change type.
3456
3457 2019-05-08  Tom Tromey  <tom@tromey.com>
3458
3459         * xcoffread.c (struct xcoff_symfile_info): Rename from
3460         coff_symfile_info.  Add initializers.
3461         (xcoff_objfile_data_key): Move lower.  Change type.
3462         (XCOFF_DATA): Rewrite.
3463         (xcoff_free_info): Remove.
3464         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3465         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3466         (xcoff_initial_scan): Update.
3467
3468 2019-05-08  Tom Tromey  <tom@tromey.com>
3469
3470         * solib-svr4.c (struct svr4_info): Add initializers and
3471         destructor.
3472         <probes_table>: Now an htab_up.
3473         (solib_svr4_pspace_data): Change type.
3474         (free_probes_table): Simplify.
3475         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3476         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3477         (probes_table_remove_objfile_probes, register_solib_event_probe)
3478         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3479         (_initialize_svr4_solib): Update.
3480
3481 2019-05-08  Tom Tromey  <tom@tromey.com>
3482
3483         * remote.c (remote_pspace_data): Change type.
3484         (remote_pspace_data_cleanup): Remove.
3485         (get_remote_exec_file, set_pspace_remote_exec_file)
3486         (_initialize_remote): Update.
3487
3488 2019-05-08  Tom Tromey  <tom@tromey.com>
3489
3490         * breakpoint.c (breakpoint_objfile_key): Change type.
3491         (get_breakpoint_objfile_data): Update.
3492         (free_breakpoint_objfile_data): Remove.
3493         (_initialize_breakpoint): Update.
3494
3495 2019-05-08  Tom Tromey  <tom@tromey.com>
3496
3497         * linux-tdep.c (struct linux_info): Add initializers.
3498         (linux_inferior_data): Move.  Change type.
3499         (invalidate_linux_cache_inf): Update.
3500         (linux_inferior_data_cleanup): Remove.
3501         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3502
3503 2019-05-08  Tom Tromey  <tom@tromey.com>
3504
3505         * auxv.c (auxv_inferior_data): Move.  Change type.
3506         (auxv_inferior_data_cleanup): Remove.
3507         (invalidate_auxv_cache_inf): Rewrite.
3508         (get_auxv_inferior_data, _initialize_auxv): Update.
3509
3510 2019-05-08  Tom Tromey  <tom@tromey.com>
3511
3512         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3513         (symfile_debug_objfile_data_key): Change type.
3514         (symfile_debug_installed, debug_qf_has_symbols)
3515         (debug_qf_find_last_source_symtab)
3516         (debug_qf_forget_cached_source_info)
3517         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3518         (debug_qf_print_stats, debug_qf_dump)
3519         (debug_qf_expand_symtabs_for_function)
3520         (debug_qf_expand_all_symtabs)
3521         (debug_qf_expand_symtabs_with_fullname)
3522         (debug_qf_map_matching_symbols)
3523         (debug_qf_expand_symtabs_matching)
3524         (debug_qf_find_pc_sect_compunit_symtab)
3525         (debug_qf_map_symbol_filenames)
3526         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3527         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3528         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3529         (debug_sym_read_linetable, debug_sym_relocate): Update.
3530         (symfile_debug_free_objfile): Remove.
3531         (install_symfile_debug_logging, _initialize_symfile_debug):
3532         Update.
3533
3534 2019-05-08  Tom Tromey  <tom@tromey.com>
3535
3536         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3537         allocate_on_obstack.
3538         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3539         (get_dwarf2_per_objfile): Update.
3540         (set_dwarf2_per_objfile): Remove.
3541         (dwarf2_has_info, dwarf2_get_section_info): Update.
3542         (dwarf2_free_objfile): Remove.
3543         (_initialize_dwarf2_read): Update.
3544
3545 2019-05-08  Tom Tromey  <tom@tromey.com>
3546
3547         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3548         initializers.
3549         <unsupported_script_warning_printed,
3550         script_not_found_warning_printed>: Now bool.
3551         (auto_load_pspace_data): Change type.
3552         (~auto_load_pspace_info): Rename from
3553         auto_load_pspace_data_cleanup.
3554         (get_auto_load_pspace_data, init_loaded_scripts_info)
3555         (clear_section_scripts, maybe_print_unsupported_script_warning)
3556         (maybe_print_script_not_found_warning, _initialize_auto_load):
3557         Update.
3558
3559 2019-05-08  Tom Tromey  <tom@tromey.com>
3560
3561         * objfiles.c (objfile_pspace_info): Add destructor and
3562         initializers.
3563         (objfiles_pspace_data): Change type.
3564         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3565         (get_objfile_pspace_data): Update.
3566         (objfiles_bfd_data): Change type.
3567         (get_objfile_bfd_data): Update.
3568         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3569
3570 2019-05-08  Tom Tromey  <tom@tromey.com>
3571
3572         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3573         Change type.
3574         (get_catch_syscall_inferior_data): Update.
3575         (catch_syscall_inferior_data_cleanup): Remove.
3576         (_initialize_break_catch_syscall): Update.
3577
3578 2019-05-08  Tom Tromey  <tom@tromey.com>
3579
3580         * inflow.c (struct terminal_info): Add destructor and
3581         initializers.
3582         (inflow_inferior_data): Change type.
3583         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3584         (get_inflow_inferior_data, inflow_inferior_exit)
3585         (swap_terminal_info, _initialize_inflow): Update.
3586
3587 2019-05-08  Tom Tromey  <tom@tromey.com>
3588
3589         * target-dcache.c (target_dcache_cleanup): Remove.
3590         (target_dcache_aspace_key): Change type.
3591         (target_dcache_init_p, target_dcache_invalidate)
3592         (target_dcache_get, target_dcache_get_or_init)
3593         (_initialize_target_dcache): Update.
3594         * dcache.h (struct dcache_deleter): New.
3595
3596 2019-05-08  Tom Tromey  <tom@tromey.com>
3597
3598         * symtab.c (struct symbol_cache): Add destructor and
3599         initializers.
3600         (symbol_cache_key): Move.  Change type.
3601         (make_symbol_cache, free_symbol_cache): Remove.
3602         (get_symbol_cache): Update.
3603         (symbol_cache_cleanup): Remove.
3604         (ALL_PSPACES, symbol_cache_flush)
3605         (maintenance_print_symbol_cache)
3606         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3607         Update.
3608
3609 2019-05-08  Tom Tromey  <tom@tromey.com>
3610
3611         * symtab.c (struct main_info): Add destructor and initializers.
3612         (main_progspace_key): Move.  Change type.
3613         (get_main_info): Update.
3614         (main_info_cleanup): Remove.
3615         (_initialize_symtab): Update.
3616
3617 2019-05-08  Tom Tromey  <tom@tromey.com>
3618
3619         * registry.h (DECLARE_REGISTRY): Define the _key class.
3620
3621 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3622
3623         * NEWS: Merge two 'New commands' sections.
3624
3625 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3626
3627         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3628         parameter and use Ada language definition instead.
3629         (ada_val_print_ptr): Remove unused language parameter.
3630         (ada_val_print_num): Remove language parameter and use Ada language
3631         definition instead.
3632         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3633         parameter.
3634         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3635         parameter and use Ada language definition instead.
3636         (ada_val_print_1): Update all ada_val_print_xxx calls.
3637         Remove language parameter.
3638         (ada_val_print): Update ada_val_print_1 call.
3639
3640 2019-05-08  Tom Tromey  <tromey@adacore.com>
3641
3642         * remote.c (remote_hw_watchpoint_limit)
3643         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3644         Now static.
3645
3646 2019-05-08  Tom Tromey  <tromey@adacore.com>
3647
3648         * maint.c (_initialize_maint_cmds): Move initialization code to
3649         remote.c.
3650         (watchdog, show_watchdog): Move to remote.c.
3651         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3652         "watchdog" static.
3653         (_initialize_remote): Move initialization code from maint.c.
3654         * defs.h (watchdog): Don't declare.
3655
3656 2019-05-08  Tom Tromey  <tromey@adacore.com>
3657
3658         * tui/tui-interp.c: Include main.h.
3659         * interps.c: Include main.h.
3660         * main.h (interpreter_p): Declare.
3661         * defs.h (interpreter_p): Don't declare.
3662
3663 2019-05-08  Tom Tromey  <tromey@adacore.com>
3664
3665         * dwarf2loc.c: Include dwarf2read.h.
3666         * defs.h (read_unsigned_leb128): Don't declare.
3667         * dwarf2read.h (read_unsigned_leb128): Declare.
3668
3669 2019-05-08  Tom Tromey  <tromey@adacore.com>
3670
3671         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3672         method.
3673
3674 2019-05-08  Tom Tromey  <tromey@adacore.com>
3675
3676         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3677         when no wrap column is set.
3678
3679 2019-05-08  Tom Tromey  <tromey@adacore.com>
3680
3681         * c-lang.c (c_get_string): Handle non-C-style arrays.
3682
3683 2019-05-08  Tom Tromey  <tromey@adacore.com>
3684
3685         * typeprint.c (print_offset_data::update): Print the bit offset,
3686         not the number of bits remaining.
3687
3688 2019-05-08  Tom Tromey  <tromey@adacore.com>
3689
3690         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3691         padding at end of comment.
3692
3693 2019-05-08  Tom Tromey  <tromey@adacore.com>
3694
3695         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3696         Compare main types.
3697
3698 2019-05-06  Tom Tromey  <tom@tromey.com>
3699
3700         * common/scoped_mmap.c: Include common-defs.h.
3701         * common/scoped_mmap.h: Don't include config.h.
3702
3703 2019-05-04  Tom Tromey  <tom@tromey.com>
3704
3705         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3706         (struct aarch64_call_info): Add initializers.
3707         <si>: Now a std::vector.
3708         (pass_on_stack, aarch64_push_dummy_call): Update.
3709
3710 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3711             Tom Tromey  <tom@tromey.com>
3712
3713         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3714         (ppc_threads): Now a std::vector.  Now static.
3715         (hwdebug_find_thread_points_by_tid)
3716         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3717         Update.
3718
3719 2019-05-04  Tom Tromey  <tom@tromey.com>
3720
3721         * arc-tdep.c (arc_tdesc_init): Return bool.
3722
3723 2019-05-04  Tom Tromey  <tom@tromey.com>
3724
3725         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3726         Use gdb_assert_not_reached.
3727
3728 2019-05-04  Tom Tromey  <tom@tromey.com>
3729
3730         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3731         "false".
3732
3733 2019-05-04  Tom Tromey  <tom@tromey.com>
3734
3735         * arc-tdep.c (arc_tdesc_init): Use bool.
3736
3737 2019-05-04  Tom Tromey  <tom@tromey.com>
3738
3739         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3740
3741 2019-05-04  Tom Tromey  <tom@tromey.com>
3742
3743         * cli/cli-cmds.c (valid_command_p): Return bool.
3744
3745 2019-05-04  Tom Tromey  <tom@tromey.com>
3746
3747         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3748         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3749
3750 2019-05-04  Raul Tambre  <raul@tambre.ee>
3751
3752         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3753         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3754         operator for comparison.
3755
3756 2019-05-04  Tom Tromey  <tom@tromey.com>
3757
3758         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3759         (lookup_partial_symbol, print_partial_symbols)
3760         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3761         (psymbol_compare): Update.
3762         (add_psymbol_to_bcache): Clear the entire psymbol.
3763         (maintenance_check_psymtabs): Update.
3764         * psympriv.h (struct partial_symbol): Don't derive from
3765         general_symbol_info.
3766         <obj_section, unrelocated_address, address,
3767         set_unrelocated_address>: Update.
3768         <ginfo>: New member.
3769         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3770         (debug_names::write_psymbols): Update.
3771
3772 2019-05-04  Tom de Vries  <tdevries@suse.de>
3773
3774         * contrib/cc-with-tweaks.sh: Support -n arg.
3775
3776 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3777
3778         * corelow.c (core_target::detach): Ensure frame cache and
3779         register caches are cleared.
3780         inferior.c (exit_inferior_1): Likewise.
3781
3782 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3783             Tom Tromey  <tom@tromey.com>
3784
3785         * dictionary.c (collate_pending_symbols_by_language): Remove
3786         "struct" from foreach.
3787         * symtab.c (lookup_global_symbol_from_objfile)
3788         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3789         foreach.
3790         * ser-tcp.c (net_open): Remove "struct" from foreach.
3791         * objfiles.c (objfile_relocate, objfile_rebase)
3792         (objfile_has_symbols): Remove "struct" from foreach.
3793         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3794         from foreach.
3795         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3796         foreach.
3797         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3798         "struct" from foreach.
3799         * ada-lang.c (create_excep_cond_exprs)
3800         (ada_exception_catchpoint_cond_string): Remove "struct" from
3801         foreach.
3802
3803 2019-05-03  Tom Tromey  <tromey@adacore.com>
3804
3805         * ada-exp.y (convert_char_literal): Check suffix of each
3806         enumerator.
3807
3808 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3809
3810         PR ada/21406:
3811         * ada-exp.y (yywrap): Don't define.
3812         * ada-lex.l (%option): Add noyywrap
3813         (yywrap): Remove.
3814
3815 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3816
3817         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3818         _WIN32_WINNT to the XP level, unless already defined to a higher
3819         level.
3820
3821         * unittests/parse-connection-spec-selftests.c:
3822         * ser-tcp.c:
3823         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3824         override.
3825
3826         * symfile.c (find_separate_debug_file): Remove colon from the
3827         drive spec of DOS/Windows file names of the target, so that the
3828         file name produced from DEBUGDIR and the target's directory will
3829         be valid on DOS/Windows systems.
3830
3831 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * rust-lang.c (val_print_struct): Handle printing structures
3834         containing strings.
3835
3836 2019-05-02  Tom Tromey  <tromey@adacore.com>
3837
3838         * valarith.c (_initialize_valarith): Remove.
3839
3840 2019-05-01  Tom Tromey  <tromey@adacore.com>
3841
3842         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3843         bitfields.
3844
3845 2019-05-01  Tom Tromey  <tromey@adacore.com>
3846
3847         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3848         for big-endian copies.
3849
3850 2019-04-30  Ali Tamur  <tamur@google.com>
3851         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3852         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3853         (read_3_bytes): New function.
3854
3855 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3856
3857         * windows-nat.c (main_thread_id): Delete.
3858         (handle_output_debug_string): Replace main_thread_id by
3859         current_event.dwThreadId.
3860         (fake_create_process): Likewise.
3861         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3862         Do not set main_thread_id.
3863         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3864         current_event.dwThreadId.
3865         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3866
3867 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3868
3869         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3870         Use current_event.dwThreadId instead of main_thread_id.
3871
3872 2019-04-30  Tom Tromey  <tromey@adacore.com>
3873
3874         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3875         (create_excep_cond_exprs): Iterate over program spaces.
3876         (ada_exception_catchpoint_cond_string): Examine all minimal
3877         symbols for exception types.
3878
3879 2019-04-30  Tom Tromey  <tromey@adacore.com>
3880
3881         PR c++/24470:
3882         * dwarf2read.c (process_structure_scope): Handle case where type
3883         has template parameters but no symbol was created.
3884
3885 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3886             Chris January  <chris.january@arm.com>
3887
3888         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3889         qualifier.
3890         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3891
3892 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3893
3894         * f-typeprint.c (f_print_type): Update rules for printing
3895         whitespace.
3896         (f_type_print_varspec_suffix): Likewise.
3897
3898 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3899             Chris January  <chris.january@arm.com>
3900
3901         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3902         function arguments.
3903
3904 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3905
3906         * f-lang.c (build_fortran_types): Change name of void type to
3907         lower case.
3908         * f-typeprint.c (f_type_print_base): Print the name of the void
3909         type, rather than a fixed string.
3910         * f-valprint.c (f_decorations): Use lower case void string.
3911
3912 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3913             Chris January  <chris.january@arm.com>
3914
3915         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3916         types for Fortran.
3917
3918 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3919             Chris January  <chris.january@arm.com>
3920             David Lecomber  <david.lecomber@arm.com>
3921
3922         * f-exp.y (BINOP_INTRINSIC): New token.
3923         (exp): New parser rule handling BINOP_INTRINSIC.
3924         (f77_keywords): Add new builtin procedures.
3925         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3926         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3927         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3928         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3929         (print_unop_subexp_f): New function.
3930         (print_binop_subexp_f): New function.
3931         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3932         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3933         (dump_subexp_body_f): Likewise.
3934         (operator_check_f): Likewise.
3935         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3936         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3937
3938 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3941         UNOP_KIND.
3942         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3943         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3944         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3945         (operator_length_f): New fuction.
3946         (print_subexp_f): New function.
3947         (op_name_f): New function.
3948         (dump_subexp_body_f): New function.
3949         (operator_check_f): New function.
3950         (exp_descriptor_f): Replace standard expression handling functions
3951         with new functions.
3952         * gdb/fortran-operator.def: New file.
3953         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3954         * gdb/std-operator.def: Remove UNOP_KIND.
3955
3956 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3957
3958         * std-operator.def: Remove unbalanced, stray double quote
3959         character.
3960
3961 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3962             Chris January  <chris.january@arm.com>
3963             Daniel Everett  <daniel.everett@arm.com>
3964             Nick Forrington  <nick.forrington@arm.com>
3965             Richard Bunt  <richard.bunt@arm.com>
3966
3967         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3968         of depth when printing anonymous structs or unions.
3969         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3970         Don't print either the top-level value, or the children if the
3971         max-depth is exceeded.
3972         (ppscm_print_children): When printing the key of a map, allow one
3973         extra level of depth.
3974         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3975         print either the top-level value, or the children if the max-depth
3976         is exceeded.
3977         (print_children): When printing the key of a map, allow one extra
3978         level of depth.
3979         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3980         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3981         (user_print_options): Initialise max_depth field.
3982         (val_print_scalar_or_string_type_p): New function.
3983         (val_print): Check to see if the max depth has been reached.
3984         (val_print_check_max_depth): Define new function.
3985         (show_print_max_depth): New function.
3986         (_initialize_valprint): Add 'print max-depth' option.
3987         * valprint.h (struct value_print_options) <max_depth>: New field.
3988         (val_print_check_max_depth): Declare new function.
3989         * NEWS: Document new feature.
3990
3991 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3992
3993         * ada-lang.c (ada_language_defn): Initialise new field.
3994         * c-lang.c (c_is_string_type_p): New function.
3995         (c_language_defn): Initialise new field.
3996         (cplus_language_defn): Initialise new field.
3997         (asm_language_defn): Initialise new field.
3998         (minimal_language_defn): Initialise new field.
3999         * c-lang.h (c_is_string_type_p): Declare new function.
4000         * d-lang.c (d_language_defn): Initialise new field.
4001         * f-lang.c (f_is_string_type_p): New function.
4002         (f_language_defn): Initialise new field.
4003         * go-lang.c (go_is_string_type_p): New function.
4004         (go_language_defn): Initialise new field.
4005         * language.c (default_is_string_type_p): New function.
4006         (unknown_language_defn): Initialise new field.
4007         (auto_language_defn): Initialise new field.
4008         * language.h (struct language_defn) <la_is_string_type_p>: New
4009         member variable.
4010         (default_is_string_type_p): Declare new function.
4011         * m2-lang.c (m2_language_defn): Initialise new field.
4012         * objc-lang.c (objc_language_defn): Initialise new field.
4013         * opencl-lang.c (opencl_language_defn): Initialise new field.
4014         * p-lang.c (pascal_is_string_type_p): New function.
4015         (pascal_language_defn): Initialise new field.
4016         * rust-lang.c (rust_is_string_type_p): New function.
4017         (rust_language_defn): Initialise new field.
4018
4019 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4020
4021         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4022         New field.
4023         * ada-lang.c (ada_language_defn): Initialise new field.
4024         * c-lang.c (c_language_defn): Likewise.
4025         (cplus_language_defn): Likewise.
4026         (asm_language_defn): Likewise.
4027         (minimal_language_defn): Likewise.
4028         * d-lang.c (d_language_defn): Likewise.
4029         * f-lang.c (f_language_defn): Likewise.
4030         * go-lang.c (go_language_defn): Likewise.
4031         * language.c (unknown_language_defn): Likewise.
4032         (auto_language_defn): Likewise.
4033         * m2-lang.c (m2_language_defn): Likewise.
4034         * objc-lang.c (objc_language_defn): Likewise.
4035         * opencl-lang.c (opencl_language_defn): Likewise.
4036         * p-lang.c (pascal_language_defn): Likewise.
4037         * rust-lang.c (rust_language_defn): Likewise.
4038
4039 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4040
4041         * ada-lang.c (ada_is_character_type): Change return type to bool.
4042         (ada_is_string_type): Likewise.
4043         * ada-lang.h (ada_is_character_type): Update declaration
4044         (ada_is_string_type): Likewise.
4045
4046 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4047
4048         Support style in 'frame|thread apply'
4049
4050         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4051         * record.c (record_start, record_stop): Update callers of
4052         execute_command_to_string with false.
4053         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4054         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4055         methods.
4056         (class string_file): New constructor with term_out parameter.
4057         Override methods term_out and can_emit_style_escape.  New member
4058         term_out.
4059         (class stdio_file): Override can_emit_style_escape.
4060         (class tee_file): Override term_out and can_emit_style_escape.
4061         * utils.h (can_emit_style_escape): Remove.
4062         * utils.c (can_emit_style_escape): Likewise.
4063         Update all callers of can_emit_style_escape (SOMESTREAM) to
4064         SOMESTREAM->can_emit_style_escape.
4065         * source-cache.c (source_cache::get_source_lines): Likewise.
4066         * stack.c (frame_apply_command_count): Call execute_command_to_string
4067         passing the term_out characteristic of the current gdb_stdout.
4068         * thread.c (thr_try_catch_cmd): Likewise.
4069         * top.c (execute_command_to_string): pass term_out parameter
4070         to construct the string_file for the command output.
4071         * ui-file.c (term_cli_styling): New function (most code moved
4072         from utils.c can_emit_style_escape).
4073         (string_file::string_file, string_file::can_emit_style_escape,
4074         stdio_file::can_emit_style_escape, tee_file::term_out,
4075         tee_file::can_emit_style_escape): New functions.
4076
4077 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4078
4079         * NEWS: Mention the new set|show may-call-functions.
4080         * infcall.c (may_call_functions_p): New variable.
4081         (show_may_call_functions_p): New function.
4082         (call_function_by_hand_dummy): Throws an error if not
4083         may-call-functions.
4084         (_initialize_infcall): Call add_setshow_boolean_cmd for
4085         may-call-functions.
4086
4087 2019-04-25  Keith Seitz  <keiths@redhat.com>
4088
4089         PR c++/24367
4090         * cp-support.c (inspect_type): Don't attempt substitutions
4091         of symbol with the same name.
4092
4093 2019-04-25  Tom Tromey  <tromey@adacore.com>
4094
4095         PR gdb/24475:
4096         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4097         static.
4098
4099 2019-04-25  Tom Tromey  <tromey@adacore.com>
4100
4101         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4102         rvalue reference.
4103         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4104         (gdb_xml_parser::parse): Use std::move.
4105         * python/python-internal.h (gdbpy_convert_exception): Take a const
4106         reference.
4107         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4108         std::move.
4109         * python/py-utils.c (gdbpy_convert_exception): Take a const
4110         reference.
4111         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4112         Use std::move.
4113         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4114         Use std::move.
4115         * mi/mi-main.c (mi_print_exception): Take a const reference.
4116         * main.c (handle_command_errors): Take a const reference.
4117         * linespec.c (parse_linespec): Use std::move.
4118         * infcall.c (run_inferior_call): Use std::move.
4119         (call_function_by_hand_dummy): Use std::move.
4120         * exec.c (try_open_exec_file): Use std::move.
4121         * exceptions.h (exception_print, exception_fprintf)
4122         (exception_print_same): Update.
4123         * exceptions.c (print_exception, exception_print)
4124         (exception_fprintf, exception_print_same): Change parameters to
4125         const reference.
4126         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4127         * common/new-op.c: Use std::move.
4128         * common/common-exceptions.h (struct gdb_exception): Add move
4129         constructor.
4130         (struct gdb_exception_error, struct gdb_exception_quit, struct
4131         gdb_quit_bad_alloc): Change constructor to move constructor.
4132         (throw_exception): Change parameter to rvalue reference.
4133         * common/common-exceptions.c (throw_exception): Take rvalue
4134         reference.
4135         * cli/cli-interp.c (safe_execute_command): Use std::move.
4136         * breakpoint.c (insert_bp_location, location_to_sals): Use
4137         std::move.
4138
4139 2019-04-25  Tom Tromey  <tromey@adacore.com>
4140
4141         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4142         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4143         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4144         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4145         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4146         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4147         guile/scm-value.c: Use unpack.
4148         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4149         gdbscm_gdb_exception.
4150         (gdbscm_throw_gdb_exception): Likewise.
4151         (struct gdbscm_gdb_exception): New.
4152         (unpack): New function.
4153         (gdbscm_wrap): Use unpack.
4154
4155 2019-04-25  Tom Tromey  <tromey@adacore.com>
4156
4157         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4158         (gdb_rl_callback_handler): Use std::move.
4159         * common/common-exceptions.h (struct gdb_exception): Add move
4160         assignment operator.
4161         (throw_exception_sjlj): Change "exception" to const reference.
4162         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4163         (throw_exception_sjlj): Change "exception" to const reference.
4164
4165 2019-04-25  Tom Tromey  <tromey@adacore.com>
4166
4167         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4168         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4169         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4170         Update.
4171         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4172         Update.
4173         * mi/mi-interp.c (mi_interp::exec): Update.
4174         * linespec.c (parse_linespec): Update.
4175         * infcall.c (run_inferior_call): Update.
4176         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4177         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4178         (gdbscm_lookup_global_symbol): Update.
4179         * guile/scm-param.c (gdbscm_parameter_value): Update.
4180         * guile/scm-frame.c (gdbscm_frame_read_register)
4181         (gdbscm_frame_read_var): Update.
4182         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4183         * exec.c (try_open_exec_file): Update.
4184         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4185         (gdb_rl_callback_handler): Update.
4186         * common/common-exceptions.h (exception_none): Don't declare.
4187         * common/common-exceptions.c (exception_none): Don't define.
4188         (struct catcher) <exception>: Update.
4189         * cli/cli-interp.c (safe_execute_command): Update.
4190         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4191
4192 2019-04-25  Ali Tamur  <tamur@google.com>
4193
4194         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4195         (read_attribute_value): Likewise.
4196         (dwarf2_read_addr_index): Update comment.
4197         (read_str_index): Add DW_FORM_strx.
4198         (dwarf2_string_attr): Likewise.
4199         (dwarf2_const_value_attr): Likewise.
4200         (dump_die_shallow): Likewise.
4201         (dwarf2_fetch_constant_bytes): Likewise.
4202         (skip_form_bytes): Likewise.
4203         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4204
4205 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4206
4207         PR corefiles/11608
4208         PR corefiles/18187
4209         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4210         OFFSET.  Verify if current mapping contains an ELF header.
4211         (linux_find_memory_regions_full): Adjust call to
4212         dump_mapping_p.
4213
4214 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4215             Kang Li <kanglictf@gmail.com>
4216
4217         PR gdb/21600
4218
4219         * dwarf2-frame.c (read_initial_length): Be consistent about using
4220         unsigned representation of length.
4221         (decode_frame_entry_1): Likewise.  Check for wraparound of
4222         end pointer as well as buffer overflow.
4223
4224 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4225
4226         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4227         "vq".
4228
4229 2019-04-24  Tom Tromey  <tromey@adacore.com>
4230
4231         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4232
4233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4234
4235         * s12z-tdep.c (s12z_unwind_pc): Delete.
4236         (s12z_unwind_sp): Delete.
4237         (s12z_gdbarch_init): Don't register deleted functions with
4238         gdbarch.
4239
4240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4241
4242         * rl78-tdep.c (rl78_unwind_sp): Delete.
4243         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4244
4245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4246
4247         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4248         (xstormy16_unwind_pc): Delete.
4249         (xstormy16_dummy_id): Delete.
4250         (xstormy16_gdbarch_init): Don't register deleted functions with
4251         gdbarch.
4252
4253 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4254
4255         * vax-tdep.c (vax_unwind_pc): Delete.
4256         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4257
4258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4259
4260         * v850-tdep.c (v850_unwind_sp): Delete.
4261         (v850_unwind_pc): Delete.
4262         (v850_dummy_id): Delete.
4263         (v850_gdbarch_init): Don't register deleted functions with
4264         gdbarch.
4265
4266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4267
4268         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4269         (tilegx_unwind_pc): Delete.
4270         (tilegx_unwind_dummy_id): Delete.
4271         (tilegx_gdbarch_init): Don't register deleted functions with
4272         gdbarch.
4273
4274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4275
4276         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4277         (tic6x_dummy_id): Delete.
4278         (tic6x_gdbarch_init): Don't register deleted functions with
4279         gdbarch.
4280
4281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4282
4283         * sparc-tdep.c (sparc_unwind_pc): Delete.
4284         (sparc32_gdbarch_init): Don't register deleted function with
4285         gdbarch.
4286
4287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4288
4289         * sh-tdep.c (sh_unwind_sp): Delete.
4290         (sh_unwind_pc): Delete.
4291         (sh_dummy_id): Delete.
4292         (sh_gdbarch_init): Don't register deleted functions with
4293         gdbarch.
4294
4295 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4296
4297         * score-tdep.c (score_unwind_sp): Delete.
4298         (score_unwind_pc): Delete.
4299         (score_dummy_id): Delete.
4300         (score_gdbarch_init): Don't register deleted functions with
4301         gdbarch.
4302
4303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4304
4305         * rx-tdep.c (rx_unwind_pc): Delete.
4306         (rx_unwind_sp): Delete.
4307         (rx_dummy_id): Delete.
4308         (rx_gdbarch_init): Don't register deleted functions with
4309         gdbarch.  Update comment.
4310
4311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4312
4313         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4314         (rs6000_dummy_id): Delete.
4315         (rs6000_gdbarch_init): Don't register deleted functions with
4316         gdbarch.
4317
4318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4319
4320         * or1k-tdep.c (or1k_dummy_id): Delete.
4321         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4322
4323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4324
4325         * nios2-tdep.c (nios2_dummy_id): Delete.
4326         (nios2_unwind_sp): Delete.
4327         (nios2_gdbarch_init): Don't register deleted functions with
4328         gdbarch.
4329
4330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4331
4332         * nds32-tdep.c (nds32_dummy_id): Delete.
4333         (nds32_unwind_pc): Delete.
4334         (nds32_unwind_sp): Delete.
4335         (nds32_gdbarch_init): Don't register deleted functions with
4336         gdbarch.
4337
4338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4339
4340         * msp430-tdep.c (msp430_unwind_pc): Delete.
4341         (msp430_unwind_sp): Delete.
4342         (msp430_dummy_id): Delete.
4343         (msp430_gdbarch_init): Don't register deleted functions with
4344         gdbarch.
4345
4346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4347
4348         * moxie-tdep.c (moxie_unwind_sp): Delete.
4349         (moxie_unwind_pc): Delete.
4350         (moxie_dummy_id): Delete.
4351         (moxie_gdbarch_init): Don't register deleted functions with
4352         gdbarch.
4353
4354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4355
4356         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4357         (mn10300_unwind_pc): Delete.
4358         (mn10300_unwind_sp): Delete.
4359         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4360         mn10300_unwind_sp.
4361         (mn10300_frame_unwind_init): Don't register deleted functions with
4362         gdbarch.
4363
4364 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4365
4366         * mep-tdep.c (mep_unwind_pc): Delete.
4367         (mep_unwind_sp): Delete.
4368         (mep_dummy_id): Delete.
4369         (mep_gdbarch_init): Don't register deleted functions with
4370         gdbarch.
4371
4372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4373
4374         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4375         (m68hc11_unwind_sp): Delete.
4376         (m68hc11_gdbarch_init): Don't register deleted functions with
4377         gdbarch.
4378
4379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4380
4381         * m32r-tdep.c (m32r_unwind_sp): Delete.
4382         (m32r_unwind_pc): Delete.
4383         (m32r_dummy_id): Delete.
4384         (m32r_gdbarch_init): Don't register deleted functions with
4385         gdbarch.
4386
4387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4388
4389         * m32c-tdep.c (m32c_unwind_pc): Delete.
4390         (m32c_unwind_sp): Delete.
4391         (m32c_dummy_id): Delete.
4392         (m32c_gdbarch_init): Don't register deleted functions with
4393         gdbarch.
4394
4395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4396
4397         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4398         (lm32_unwind_pc): Delete.
4399         (lm32_dummy_id): Delete.
4400         (lm32_gdbarch_init): Don't register deleted functions with
4401         gdbarch.
4402
4403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4404
4405         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4406         (iq2000_unwind_pc): Delete.
4407         (iq2000_dummy_id): Delete.
4408         (iq2000_gdbarch_init): Don't register deleted functions with
4409         gdbarch.
4410
4411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4412
4413         * nds32-tdep.c (nds32_type_align): Delete.
4414         (nds32_push_dummy_call): Use type_align instead.
4415
4416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4417
4418         * arm-tdep.c (arm_type_align): Only handle vector override case.
4419         (arm_push_dummy_call): Use type_align.
4420         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4421
4422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4423
4424         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4425         case.
4426         (pass_on_stack): Use type_align.
4427         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4428         function.
4429
4430 2019-04-23  Tom Tromey  <tromey@adacore.com>
4431
4432         * dwarf2read.c (line_header::file_name_at): Remove unused
4433         overload.
4434
4435 2019-04-23  Tom de Vries  <tdevries@suse.de>
4436
4437         PR gdb/24438
4438         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4439         invocation.
4440
4441
4442 2019-03-27  Ali Tamur  <tamur@google.com>
4443
4444         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4445         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4446         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4447         (dwarf_expr_context::get_addr_index): Likewise
4448         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4449         (symbol_needs_eval_context::get_addr_index): Likewise
4450         (disassemble_dwarf_expression): Add DW_OP_addrx
4451         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4452         (read_cutu_die_from_dwo): Update comment
4453         (skip_one_die): Add DW_FORM_addrx
4454         (read_attribute_value): Likewise
4455         (var_decode_location): Add DW_OP_addrx
4456         (dwarf2_const_value_attr): Add DW_FORM_addrx
4457         (dump_die_shallow): Likewise
4458         (dwarf2_fetch_constant_bytes): Likewise
4459         (decode_locdesc): Add DW_OP_addrx
4460         (skip_form_bytes): Add DW_FORM_addrx
4461
4462 2019-04-22  Ali Tamur  <tamur@google.com>
4463
4464         * MAINTAINERS (Write After Approval): Add self.
4465
4466 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4467
4468         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4469         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4470         (open_symbol_file_object): Likewise.
4471         (svr4_default_sos): Add info parameter.
4472         (svr4_read_so_list): Likewise.
4473         (svr4_current_sos_direct): Adjust functions calls to pass down
4474         info.
4475         (svr4_current_sos_1): Add info parameter.
4476         (svr4_current_sos): Call get_svr4_info, pass info down to
4477         svr4_current_sos_1.
4478         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4479         get_svr4_info.
4480         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4481         get_svr4_info.
4482         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4483         to get_svr4_info.
4484         (probes_table_remove_objfile_probes): Likewise.
4485         (register_solib_event_probe): Add info parameter.
4486         (solist_update_incremental): Pass info parameter down to
4487         svr4_read_so_list.
4488         (disable_probes_interface): Add info parameter.
4489         (svr4_handle_solib_event): Pass current_program_space to
4490         get_svr4_info.  Adjust disable_probes_interface cleanup.
4491         (svr4_create_probe_breakpoints): Add info parameter, pass it
4492         down to register_solib_event_probe.
4493         (svr4_create_solib_event_breakpoints): Add info parameter,
4494         pass it down to svr4_create_probe_breakpoints.
4495         (enable_break): Pass info down to
4496         svr4_create_solib_event_breakpoints.
4497         (svr4_solib_create_inferior_hook): Pass current_program_space to
4498         get_svr4_info.
4499         (svr4_clear_solib): Likewise.
4500
4501 2019-04-22  Pedro Alves  <palves@redhat.com>
4502
4503         * solib-svr4.c (svr4_free_objfile_observer): New.
4504         (probe_and_action::objfile): New field.
4505         (probes_table_htab_remove_objfile_probes)
4506         (probes_table_remove_objfile_probes): New functions.
4507         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4508         in the new probe_and_action.  Don't store the probe in 'lookup'.
4509         (svr4_create_probe_breakpoints): Pass objfile to
4510         register_solib_event_probe.
4511         (_initialize_svr4_solib): Register a free_objfile observer.
4512
4513 2019-04-19  Tom Tromey  <tom@tromey.com>
4514
4515         * common/queue.h: Remove.
4516
4517 2019-04-19  Tom Tromey  <tom@tromey.com>
4518
4519         * event-loop.c: Don't include "common/queue.h".
4520
4521 2019-04-19  Tom Tromey  <tom@tromey.com>
4522
4523         * remote.c (remote_target): Use delete.
4524         * remote-notif.h: Include <list>, not "common/queue.h".
4525         (notif_client_p): Remove typedef.
4526         (remote_notif_state): Add constructor, destructor, initializer.
4527         <notif_queue>: Now a std::list.
4528         (remote_notif_state_xfree): Don't declare.
4529         * remote-notif.c (remote_notif_process, handle_notification)
4530         (remote_notif_state_allocate): Update.
4531         (~remote_notif_state): Rename from remote_notif_state_xfree.
4532
4533 2019-04-19  Tom Tromey  <tom@tromey.com>
4534
4535         * symfile.c (reread_symbols): Update.
4536         * objfiles.c (objfile_register_static_link)
4537         (objfile_lookup_static_link): Update
4538         (~objfile) Don't delete static_links.
4539         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4540
4541 2019-04-19  Tom Tromey  <tom@tromey.com>
4542
4543         * type-stack.h (struct type_stack) <insert>: Constify string.
4544         * type-stack.c (type_stack::insert): Constify string.
4545         * gdbtypes.h (lookup_template_type): Update.
4546         (address_space_name_to_int): Update.
4547         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4548         const.
4549         (lookup_template_type): Make name const.
4550         * c-exp.y: Update rules.
4551         (lex_one_token, classify_name, classify_inner_name)
4552         (c_print_token): Update.
4553         * p-exp.y: Update rules.
4554         (yylex): Update.
4555         * f-exp.y: Update rules.
4556         (yylex): Update.
4557         * d-exp.y: Update rules.
4558         (lex_one_token, classify_name, classify_inner_name): Update.
4559         * parse.c (write_dollar_variable, copy_name): Return std::string.
4560         * parser-defs.h (copy_name): Change return type.
4561         * m2-exp.y: Update rules.
4562         (yylex): Update.
4563         * go-exp.y (lex_one_token): Update.
4564         Update rules.
4565         (classify_unsafe_function, classify_packaged_name)
4566         (classify_name, yylex): Update.
4567
4568 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4569
4570         * configure.ac: add --enable-source-highlight switch.
4571         * configure: Regenerate.
4572         * top.c (print_gdb_version): plumb --enable-source-highlight
4573         status to "show configuration".
4574
4575 2019-04-19  Tom Tromey  <tromey@adacore.com>
4576
4577         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4578         Check ADA_TYPE_P.
4579         (empty_record, ada_template_to_fixed_record_type_1)
4580         (template_to_static_fixed_type)
4581         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4582         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4583         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4584         macros.
4585
4586 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4587
4588         PR symtab/24423:
4589         * source.c (print_source_lines_base): Advance "iter" when a
4590         control character is seen.
4591
4592 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4593
4594         * inferior.h (struct infcall_suspend_state_deleter):
4595         Catch exception in destructor to avoid crash.
4596
4597 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4598
4599         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4600         close to the add_com "shell".
4601
4602 2019-04-18  Tom Tromey  <tromey@adacore.com>
4603
4604         * process-stratum-target.h (class process_stratum_target)
4605         <stratum>: Add "final".
4606
4607 2019-04-17  Tom Tromey  <tromey@adacore.com>
4608
4609         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4610         against nullptr before use.
4611
4612 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4613
4614         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4615
4616 2019-04-17  Jim Wilson  <jimw@sifive.com>
4617             Andrew Burgess  <andrew.burgess@embecosm.com>
4618
4619         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4620         code read might fail, assume 4-byte breakpoint in that case.
4621
4622 2019-04-15  Leszek Swirski  <leszeks@google.com>
4623
4624         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4625         rather than a hand-rolled POD check when checking for forced MEMORY
4626         classification.
4627
4628 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4629
4630         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4631         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4632         function.
4633         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4634         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4635         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4636         declaration.
4637
4638 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4639
4640         * aarch64-linux-nat.c
4641         (aarch64_linux_nat_target::thread_architecture): Add override.
4642         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4643         each VQ.
4644
4645 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4646
4647         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4648
4649 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4650
4651         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4652         target types of size 96-bits, add some additional comments, and
4653         check that the builtin type we found was the correct size.
4654
4655 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4656
4657         * utils.c (prompt_for_continue): Don't restore the styling at the
4658         end, as applied_style has the wrong value.  This fixes styling in
4659         long lists of file names that are interrupted by the "Continue?"
4660         prompt.
4661
4662 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4663
4664         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4665         * c-lang.c (c_language_defn): Likewise.
4666         (cplus_language_defn): Likewise.
4667         (asm_language_defn): Likewise.
4668         (minimal_language_defn): Likewise.
4669         * d-lang.c (d_language_defn): Likewise.
4670         * f-lang.c (f_language_defn): Likewise.
4671         * go-lang.c (go_language_defn): Likewise.
4672         * language.c (unknown_language_defn): Likewise.
4673         (auto_language_defn): Likewise.
4674         * language.h (struct language_defn): Remove la_magic field.
4675         (LANG_MAGIC): Delete.
4676         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4677         * objc-lang.c (objc_language_defn): Likewise.
4678         * opencl-lang.c (opencl_language_defn): Likewise.
4679         * p-lang.c (pascal_language_defn): Likewise.
4680         * rust-lang.c (rust_language_defn): Likewise.
4681
4682 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4683
4684         * riscv-tdep.c (riscv_type_align): New function.
4685         (riscv_type_alignment): Delete.
4686         (riscv_arg_location): Use 'type_align'.
4687         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4688
4689 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4690
4691         * gdbtypes.c (type_align): A struct with no non-static fields also
4692         has alignment of 1.
4693
4694 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4695
4696         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4697         component to 0.
4698         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4699         member.
4700         (riscv_struct_info::analyse): New implementation using new
4701         analyse_inner member function.
4702         (riscv_struct_info::field_offset): New member function.
4703         (riscv_struct_info::m_offsets): New member variable.
4704         (riscv_struct_info::analyse_inner): New private member function,
4705         takes the old implementation of riscv_struct_info::analyse but
4706         extended to track field offsets.
4707         (riscv_call_arg_struct): Update the struct folding special cases
4708         to handle cases where empty C++ structs, which are non-zero
4709         length, are found.
4710         (riscv_arg_location): Initialise the length of each location, a
4711         non-zero length now indicates the location is in use.
4712         (riscv_push_dummy_call): Allow for the first location having a
4713         non-zero offset when setting up arguments.
4714         (riscv_return_value): Likewise, but for return values.
4715
4716 2019-04-11  Tom Tromey  <tromey@adacore.com>
4717
4718         * utils.c (internal_vproblem): Make "msg" const.
4719
4720 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4721
4722         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4723         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4724         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4725         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4726
4727 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4728
4729         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4730         function.
4731         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4732         of amd64_collect_native_gregset.
4733         (amd64_linux_nat_target::store_registers): Likewise.
4734
4735 2019-04-10  Tom Tromey  <tom@tromey.com>
4736
4737         * symtab.c (lookup_global_symbol_from_objfile)
4738         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4739         * objfiles.h (class separate_debug_iterator): New.
4740         (class separate_debug_range): New.
4741         (struct objfile) <separate_debug_objfiles>: New method.
4742         (objfile_separate_debug_iterate): Don't declare.
4743         * objfiles.c (separate_debug_iterator::operator++): Rename from
4744         objfile_separate_debug_iterate.
4745         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4746         iterator.
4747         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4748         iterator.
4749
4750 2019-04-10  Tom Tromey  <tom@tromey.com>
4751
4752         * symfile.c (reread_symbols): Remove old comment.
4753         * objfiles.c (free_all_objfiles): Fix a typo.
4754
4755 2019-04-10  Tom Tromey  <tom@tromey.com>
4756
4757         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4758         * minsyms.c (lookup_minimal_symbol): Use foreach.
4759         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4760         (lookup_minimal_symbol_solib_trampoline): Likewise.
4761         * symfile.c (reread_symbols): Use foreach.
4762
4763 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4764             Tom Tromey  <tromey@adacore.com>
4765
4766         PR rust/24414:
4767         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4768         (rust_lex_int_test): Change "value" to be LONGEST.
4769         (rust_lex_tests): Add test for long integer literal.
4770
4771 2019-04-09  Tom Tromey  <tromey@adacore.com>
4772
4773         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4774         to bool.
4775         (extended_remote_target::attach): Update.
4776         (remote_target::remote_notice_new_inferior): Update.
4777         (remote_target::add_current_inferior_and_thread): Update.
4778         * inferior.c (exit_inferior_1): Use "false".
4779         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4780
4781 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4782
4783         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4784         the "start" command.
4785
4786 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4787
4788         * python/py-inferior.c (infpy_thread_from_thread_handle):
4789         Adjust comments to reflect renaming of thread_from_thread_handle
4790         to thread_from_handle.  Adjust keywords.  Fix type error message.
4791         (inferior_object_methods): Add thread_from_handle.  Retain
4792         thread_from_thread_handle, but mark it as deprecated.
4793
4794 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4795
4796         * gdbthread.h (find_thread_by_handle): Revise declaration.
4797         * thread.c (find_thread_by_handle): Likewise.  Adjust
4798         implementation too.
4799         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4800         support for buffer objects as handles.
4801
4802 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4803
4804         * python/py-infthread.c (thpy_thread_handle): New function.
4805         (thread_object_methods): Register thpy_thread_handle.
4806
4807 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4808
4809         * gdbthread.h (thread_to_thread_handle): Declare.
4810         * thread.c (gdbtypes.h): Include.
4811         (thread_to_thread_handle): New function.
4812
4813         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4814         (target_thread_info_to_thread_handle): Declare.
4815         * target.c (target_thread_info_to_thread_handle): New function.
4816         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4817         * target-delegates.c: Regenerate.
4818
4819         * linux-thread-db.c (class thread_db_target): Add method
4820         thread_info_to_thread_handle.
4821         (thread_db_target::thread_info_to_thread_handle): Define.
4822         * remote.c (class remote_target): Add new method
4823         thread_info_to_thread_handle.
4824         (remote_target::thread_info_to_thread_handle): Define.
4825
4826 2019-04-08  Pedro Alves  <palves@redhat.com>
4827
4828         * common/common-exceptions.c (throw_exception): Don't create
4829         named object to throw; throw directly.
4830         (throw_it): Likewise.  Don't initialize gdb_exception::message
4831         here, with new; pass FMT and AP to the ctor instead.
4832         * common/common-exceptions.h: Include <string>.
4833         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4834         const char *, va_list)): New ctor.  Use std::make_shared.
4835         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4836         errors)): Delete.
4837         (gdb_exception_error::gdb_exception_error(enum errors, const char
4838         *, va_list)): New.
4839         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4840         Add assertion.
4841         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4842         errors)): Delete.
4843         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4844         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4845         Add assertion.
4846
4847 2019-04-08  Tom Tromey  <tom@tromey.com>
4848
4849         * valops.c (value_rtti_indirect_type): Replace throw_exception
4850         with throw.
4851         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4852         with throw.
4853         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4854         throw.
4855         * target.c (target_translate_tls_address): Replace throw_exception
4856         with throw.
4857         * stack.c (frame_apply_command_count): Replace throw_exception
4858         with throw.
4859         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4860         throw.
4861         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4862         with throw.
4863         * rs6000-tdep.c (rs6000_frame_cache)
4864         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4865         * remote.c: Replace throw_exception with throw.
4866         * record-full.c (record_full_message, record_full_wait_1)
4867         (record_full_restore): Replace throw_exception with throw.
4868         * record-btrace.c:
4869         (get_thread_current_frame_id, record_btrace_start_replaying)
4870         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4871         (cmd_record_btrace_start): Replace throw_exception with throw.
4872         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4873         throw.
4874         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4875         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4876         * linespec.c:
4877         (find_linespec_symbols): Replace throw_exception with throw.
4878         * infrun.c (displaced_step_prepare, resume): Replace
4879         throw_exception with throw.
4880         * infcmd.c (post_create_inferior): Replace throw_exception with
4881         throw.
4882         * inf-loop.c (inferior_event_handler): Replace throw_exception
4883         with throw.
4884         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4885         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4886         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4887         (get_prev_frame_always, get_frame_pc_if_available)
4888         (get_frame_address_in_block_if_available, get_frame_language):
4889         Replace throw_exception with throw.
4890         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4891         throw_exception with throw.
4892         * eval.c (fetch_subexp_value, evaluate_var_value)
4893         (evaluate_funcall, evaluate_subexp_standard): Replace
4894         throw_exception with throw.
4895         * dwarf2loc.c (call_site_find_chain)
4896         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4897         Replace throw_exception with throw.
4898         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4899         with throw.
4900         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4901         throw.
4902         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4903         * completer.c (complete_line_internal): Replace throw_exception
4904         with throw.
4905         * compile/compile-object-run.c (compile_object_run): Replace
4906         throw_exception with throw.
4907         * cli/cli-script.c (process_next_line): Replace throw_exception
4908         with throw.
4909         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4910         (btrace_enable, btrace_maint_update_pt_packets): Replace
4911         throw_exception with throw.
4912         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4913         throw_exception with throw.
4914         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4915         throw_exception with throw.
4916         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4917         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4918         * aarch64-tdep.c (aarch64_make_prologue_cache)
4919         (aarch64_make_stub_cache): Replace throw_exception with throw.
4920
4921 2019-04-08  Tom Tromey  <tom@tromey.com>
4922
4923         * common/common-exceptions.c (throw_exception): Rename from
4924         throw_exception_cxx.  Remove old copy.  Make argument const.
4925         (throw_it): Create and throw exception objects directly.
4926         * common/common-exceptions.h (throw_exception): Make argument
4927         const.
4928         (struct gdb_exception_error): Add constructor.
4929         (struct gdb_exception_quit): Add constructor.
4930
4931 2019-04-08  Tom Tromey  <tom@tromey.com>
4932
4933         * common/common-exceptions.h (exception_rethrow): Don't declare.
4934         (TRY_SJLJ): Update comment.
4935         (TRY, CATCH, END_CATCH): Remove.
4936         * common/common-exceptions.c (exception_rethrow): Remove.
4937
4938 2019-04-08  Tom Tromey  <tom@tromey.com>
4939
4940         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4941         Remove.
4942         (gdb_exception_error): Rename from
4943         gdb_exception_RETURN_MASK_ERROR.
4944         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4945         (gdb_quit_bad_alloc): Update.
4946         * aarch64-tdep.c: Update.
4947         * ada-lang.c: Update.
4948         * ada-typeprint.c: Update.
4949         * ada-valprint.c: Update.
4950         * amd64-tdep.c: Update.
4951         * arch-utils.c: Update.
4952         * break-catch-throw.c: Update.
4953         * breakpoint.c: Update.
4954         * btrace.c: Update.
4955         * c-varobj.c: Update.
4956         * cli/cli-cmds.c: Update.
4957         * cli/cli-interp.c: Update.
4958         * cli/cli-script.c: Update.
4959         * common/common-exceptions.c: Update.
4960         * common/new-op.c: Update.
4961         * common/selftest.c: Update.
4962         * compile/compile-c-symbols.c: Update.
4963         * compile/compile-cplus-symbols.c: Update.
4964         * compile/compile-object-load.c: Update.
4965         * compile/compile-object-run.c: Update.
4966         * completer.c: Update.
4967         * corelow.c: Update.
4968         * cp-abi.c: Update.
4969         * cp-support.c: Update.
4970         * cp-valprint.c: Update.
4971         * darwin-nat.c: Update.
4972         * disasm-selftests.c: Update.
4973         * dtrace-probe.c: Update.
4974         * dwarf-index-cache.c: Update.
4975         * dwarf-index-write.c: Update.
4976         * dwarf2-frame-tailcall.c: Update.
4977         * dwarf2-frame.c: Update.
4978         * dwarf2loc.c: Update.
4979         * dwarf2read.c: Update.
4980         * eval.c: Update.
4981         * event-loop.c: Update.
4982         * event-top.c: Update.
4983         * exec.c: Update.
4984         * f-valprint.c: Update.
4985         * fbsd-tdep.c: Update.
4986         * frame-unwind.c: Update.
4987         * frame.c: Update.
4988         * gdbtypes.c: Update.
4989         * gnu-v3-abi.c: Update.
4990         * guile/guile-internal.h: Update.
4991         * guile/scm-block.c: Update.
4992         * guile/scm-breakpoint.c: Update.
4993         * guile/scm-cmd.c: Update.
4994         * guile/scm-disasm.c: Update.
4995         * guile/scm-frame.c: Update.
4996         * guile/scm-lazy-string.c: Update.
4997         * guile/scm-math.c: Update.
4998         * guile/scm-param.c: Update.
4999         * guile/scm-ports.c: Update.
5000         * guile/scm-pretty-print.c: Update.
5001         * guile/scm-symbol.c: Update.
5002         * guile/scm-symtab.c: Update.
5003         * guile/scm-type.c: Update.
5004         * guile/scm-value.c: Update.
5005         * i386-linux-tdep.c: Update.
5006         * i386-tdep.c: Update.
5007         * inf-loop.c: Update.
5008         * infcall.c: Update.
5009         * infcmd.c: Update.
5010         * infrun.c: Update.
5011         * jit.c: Update.
5012         * language.c: Update.
5013         * linespec.c: Update.
5014         * linux-fork.c: Update.
5015         * linux-nat.c: Update.
5016         * linux-tdep.c: Update.
5017         * linux-thread-db.c: Update.
5018         * main.c: Update.
5019         * mi/mi-cmd-break.c: Update.
5020         * mi/mi-cmd-stack.c: Update.
5021         * mi/mi-interp.c: Update.
5022         * mi/mi-main.c: Update.
5023         * objc-lang.c: Update.
5024         * p-valprint.c: Update.
5025         * parse.c: Update.
5026         * ppc-linux-tdep.c: Update.
5027         * printcmd.c: Update.
5028         * python/py-arch.c: Update.
5029         * python/py-breakpoint.c: Update.
5030         * python/py-cmd.c: Update.
5031         * python/py-finishbreakpoint.c: Update.
5032         * python/py-frame.c: Update.
5033         * python/py-framefilter.c: Update.
5034         * python/py-gdb-readline.c: Update.
5035         * python/py-inferior.c: Update.
5036         * python/py-infthread.c: Update.
5037         * python/py-lazy-string.c: Update.
5038         * python/py-linetable.c: Update.
5039         * python/py-objfile.c: Update.
5040         * python/py-param.c: Update.
5041         * python/py-prettyprint.c: Update.
5042         * python/py-progspace.c: Update.
5043         * python/py-record-btrace.c: Update.
5044         * python/py-record.c: Update.
5045         * python/py-symbol.c: Update.
5046         * python/py-type.c: Update.
5047         * python/py-unwind.c: Update.
5048         * python/py-utils.c: Update.
5049         * python/py-value.c: Update.
5050         * python/python.c: Update.
5051         * record-btrace.c: Update.
5052         * record-full.c: Update.
5053         * remote-fileio.c: Update.
5054         * remote.c: Update.
5055         * riscv-tdep.c: Update.
5056         * rs6000-aix-tdep.c: Update.
5057         * rs6000-tdep.c: Update.
5058         * rust-exp.y: Update.
5059         * rust-lang.c: Update.
5060         * s390-tdep.c: Update.
5061         * selftest-arch.c: Update.
5062         * solib-dsbt.c: Update.
5063         * solib-frv.c: Update.
5064         * solib-spu.c: Update.
5065         * solib-svr4.c: Update.
5066         * solib.c: Update.
5067         * sparc64-linux-tdep.c: Update.
5068         * stack.c: Update.
5069         * symfile-mem.c: Update.
5070         * symmisc.c: Update.
5071         * target.c: Update.
5072         * thread.c: Update.
5073         * top.c: Update.
5074         * tracefile-tfile.c: Update.
5075         * tui/tui.c: Update.
5076         * typeprint.c: Update.
5077         * unittests/cli-utils-selftests.c: Update.
5078         * unittests/parse-connection-spec-selftests.c: Update.
5079         * valops.c: Update.
5080         * valprint.c: Update.
5081         * value.c: Update.
5082         * varobj.c: Update.
5083         * windows-nat.c: Update.
5084         * x86-linux-nat.c: Update.
5085         * xml-support.c: Update.
5086
5087 2019-04-08  Tom Tromey  <tom@tromey.com>
5088
5089         * xml-support.c: Use C++ exception handling.
5090         * x86-linux-nat.c: Use C++ exception handling.
5091         * windows-nat.c: Use C++ exception handling.
5092         * varobj.c: Use C++ exception handling.
5093         * value.c: Use C++ exception handling.
5094         * valprint.c: Use C++ exception handling.
5095         * valops.c: Use C++ exception handling.
5096         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5097         handling.
5098         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5099         * typeprint.c: Use C++ exception handling.
5100         * tui/tui.c: Use C++ exception handling.
5101         * tracefile-tfile.c: Use C++ exception handling.
5102         * top.c: Use C++ exception handling.
5103         * thread.c: Use C++ exception handling.
5104         * target.c: Use C++ exception handling.
5105         * symmisc.c: Use C++ exception handling.
5106         * symfile-mem.c: Use C++ exception handling.
5107         * stack.c: Use C++ exception handling.
5108         * sparc64-linux-tdep.c: Use C++ exception handling.
5109         * solib.c: Use C++ exception handling.
5110         * solib-svr4.c: Use C++ exception handling.
5111         * solib-spu.c: Use C++ exception handling.
5112         * solib-frv.c: Use C++ exception handling.
5113         * solib-dsbt.c: Use C++ exception handling.
5114         * selftest-arch.c: Use C++ exception handling.
5115         * s390-tdep.c: Use C++ exception handling.
5116         * rust-lang.c: Use C++ exception handling.
5117         * rust-exp.y: Use C++ exception handling.
5118         * rs6000-tdep.c: Use C++ exception handling.
5119         * rs6000-aix-tdep.c: Use C++ exception handling.
5120         * riscv-tdep.c: Use C++ exception handling.
5121         * remote.c: Use C++ exception handling.
5122         * remote-fileio.c: Use C++ exception handling.
5123         * record-full.c: Use C++ exception handling.
5124         * record-btrace.c: Use C++ exception handling.
5125         * python/python.c: Use C++ exception handling.
5126         * python/py-value.c: Use C++ exception handling.
5127         * python/py-utils.c: Use C++ exception handling.
5128         * python/py-unwind.c: Use C++ exception handling.
5129         * python/py-type.c: Use C++ exception handling.
5130         * python/py-symbol.c: Use C++ exception handling.
5131         * python/py-record.c: Use C++ exception handling.
5132         * python/py-record-btrace.c: Use C++ exception handling.
5133         * python/py-progspace.c: Use C++ exception handling.
5134         * python/py-prettyprint.c: Use C++ exception handling.
5135         * python/py-param.c: Use C++ exception handling.
5136         * python/py-objfile.c: Use C++ exception handling.
5137         * python/py-linetable.c: Use C++ exception handling.
5138         * python/py-lazy-string.c: Use C++ exception handling.
5139         * python/py-infthread.c: Use C++ exception handling.
5140         * python/py-inferior.c: Use C++ exception handling.
5141         * python/py-gdb-readline.c: Use C++ exception handling.
5142         * python/py-framefilter.c: Use C++ exception handling.
5143         * python/py-frame.c: Use C++ exception handling.
5144         * python/py-finishbreakpoint.c: Use C++ exception handling.
5145         * python/py-cmd.c: Use C++ exception handling.
5146         * python/py-breakpoint.c: Use C++ exception handling.
5147         * python/py-arch.c: Use C++ exception handling.
5148         * printcmd.c: Use C++ exception handling.
5149         * ppc-linux-tdep.c: Use C++ exception handling.
5150         * parse.c: Use C++ exception handling.
5151         * p-valprint.c: Use C++ exception handling.
5152         * objc-lang.c: Use C++ exception handling.
5153         * mi/mi-main.c: Use C++ exception handling.
5154         * mi/mi-interp.c: Use C++ exception handling.
5155         * mi/mi-cmd-stack.c: Use C++ exception handling.
5156         * mi/mi-cmd-break.c: Use C++ exception handling.
5157         * main.c: Use C++ exception handling.
5158         * linux-thread-db.c: Use C++ exception handling.
5159         * linux-tdep.c: Use C++ exception handling.
5160         * linux-nat.c: Use C++ exception handling.
5161         * linux-fork.c: Use C++ exception handling.
5162         * linespec.c: Use C++ exception handling.
5163         * language.c: Use C++ exception handling.
5164         * jit.c: Use C++ exception handling.
5165         * infrun.c: Use C++ exception handling.
5166         * infcmd.c: Use C++ exception handling.
5167         * infcall.c: Use C++ exception handling.
5168         * inf-loop.c: Use C++ exception handling.
5169         * i386-tdep.c: Use C++ exception handling.
5170         * i386-linux-tdep.c: Use C++ exception handling.
5171         * guile/scm-value.c: Use C++ exception handling.
5172         * guile/scm-type.c: Use C++ exception handling.
5173         * guile/scm-symtab.c: Use C++ exception handling.
5174         * guile/scm-symbol.c: Use C++ exception handling.
5175         * guile/scm-pretty-print.c: Use C++ exception handling.
5176         * guile/scm-ports.c: Use C++ exception handling.
5177         * guile/scm-param.c: Use C++ exception handling.
5178         * guile/scm-math.c: Use C++ exception handling.
5179         * guile/scm-lazy-string.c: Use C++ exception handling.
5180         * guile/scm-frame.c: Use C++ exception handling.
5181         * guile/scm-disasm.c: Use C++ exception handling.
5182         * guile/scm-cmd.c: Use C++ exception handling.
5183         * guile/scm-breakpoint.c: Use C++ exception handling.
5184         * guile/scm-block.c: Use C++ exception handling.
5185         * guile/guile-internal.h: Use C++ exception handling.
5186         * gnu-v3-abi.c: Use C++ exception handling.
5187         * gdbtypes.c: Use C++ exception handling.
5188         * frame.c: Use C++ exception handling.
5189         * frame-unwind.c: Use C++ exception handling.
5190         * fbsd-tdep.c: Use C++ exception handling.
5191         * f-valprint.c: Use C++ exception handling.
5192         * exec.c: Use C++ exception handling.
5193         * event-top.c: Use C++ exception handling.
5194         * event-loop.c: Use C++ exception handling.
5195         * eval.c: Use C++ exception handling.
5196         * dwarf2read.c: Use C++ exception handling.
5197         * dwarf2loc.c: Use C++ exception handling.
5198         * dwarf2-frame.c: Use C++ exception handling.
5199         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5200         * dwarf-index-write.c: Use C++ exception handling.
5201         * dwarf-index-cache.c: Use C++ exception handling.
5202         * dtrace-probe.c: Use C++ exception handling.
5203         * disasm-selftests.c: Use C++ exception handling.
5204         * darwin-nat.c: Use C++ exception handling.
5205         * cp-valprint.c: Use C++ exception handling.
5206         * cp-support.c: Use C++ exception handling.
5207         * cp-abi.c: Use C++ exception handling.
5208         * corelow.c: Use C++ exception handling.
5209         * completer.c: Use C++ exception handling.
5210         * compile/compile-object-run.c: Use C++ exception handling.
5211         * compile/compile-object-load.c: Use C++ exception handling.
5212         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5213         * compile/compile-c-symbols.c: Use C++ exception handling.
5214         * common/selftest.c: Use C++ exception handling.
5215         * common/new-op.c: Use C++ exception handling.
5216         * cli/cli-script.c: Use C++ exception handling.
5217         * cli/cli-interp.c: Use C++ exception handling.
5218         * cli/cli-cmds.c: Use C++ exception handling.
5219         * c-varobj.c: Use C++ exception handling.
5220         * btrace.c: Use C++ exception handling.
5221         * breakpoint.c: Use C++ exception handling.
5222         * break-catch-throw.c: Use C++ exception handling.
5223         * arch-utils.c: Use C++ exception handling.
5224         * amd64-tdep.c: Use C++ exception handling.
5225         * ada-valprint.c: Use C++ exception handling.
5226         * ada-typeprint.c: Use C++ exception handling.
5227         * ada-lang.c: Use C++ exception handling.
5228         * aarch64-tdep.c: Use C++ exception handling.
5229
5230 2019-04-08  Tom Tromey  <tom@tromey.com>
5231
5232         * xml-support.c (gdb_xml_parser::parse): Update.
5233         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5234         * value.c (show_convenience): Update.
5235         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5236         (test_parse_flags_qcs): Update.
5237         * thread.c (thr_try_catch_cmd): Update.
5238         * target.c (target_translate_tls_address): Update.
5239         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5240         (info_frame_command_core, frame_apply_command_count): Update.
5241         * rust-exp.y (rust_lex_exception_test): Update.
5242         * riscv-tdep.c (riscv_print_one_register_info): Update.
5243         * remote.c (remote_target::enable_btrace): Update.
5244         * record-btrace.c (record_btrace_enable_warn): Update.
5245         * python/py-utils.c (gdbpy_convert_exception): Update.
5246         * printcmd.c (do_one_display, print_variable_and_value): Update.
5247         * mi/mi-main.c (mi_print_exception): Update.
5248         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5249         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5250         * linux-nat.c (linux_nat_target::attach): Update.
5251         * linux-fork.c (class scoped_switch_fork_info): Update.
5252         * infrun.c (displaced_step_prepare): Update.
5253         * infcall.c (call_function_by_hand_dummy): Update.
5254         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5255         * gnu-v3-abi.c (print_one_vtable): Update.
5256         * frame.c (get_prev_frame_always): Update.
5257         * f-valprint.c (info_common_command_for_block): Update.
5258         * exec.c (try_open_exec_file): Update.
5259         * exceptions.c (print_exception, exception_print)
5260         (exception_fprintf, exception_print_same): Update.
5261         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5262         * dwarf-index-cache.c (index_cache::store)
5263         (index_cache::lookup_gdb_index): Update.
5264         * darwin-nat.c (maybe_cache_shell): Update.
5265         * cp-valprint.c (cp_print_value_fields): Update.
5266         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5267         (gcc_cplus_symbol_address): Update.
5268         * compile/compile-c-symbols.c (gcc_convert_symbol)
5269         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5270         * common/selftest.c: Update.
5271         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5272         a std::string.
5273         (exception_try_scope_entry, exception_try_scope_exit): Don't
5274         declare.
5275         (struct exception_try_scope): Remove.
5276         (TRY): Don't use exception_try_scope.
5277         (struct gdb_exception): Add constructor, operator=.
5278         <what>: New method.
5279         (struct gdb_exception_RETURN_MASK_ALL)
5280         (struct gdb_exception_RETURN_MASK_ERROR)
5281         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5282         (struct gdb_quit_bad_alloc): Update.
5283         * common/common-exceptions.c (exception_none): Change
5284         initializer.
5285         (struct catcher) <state, exception>: Initialize inline.
5286         <prev>: Remove member.
5287         (current_catcher): Remove.
5288         (catchers): New global.
5289         (exceptions_state_mc_init): Simplify.
5290         (catcher_pop): Remove.
5291         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5292         (try_scope_depth, exception_try_scope_entry)
5293         (exception_try_scope_exit): Remove.
5294         (throw_exception_sjlj): Update.
5295         (exception_messages, exception_messages_size): Remove.
5296         (throw_it): Simplify.
5297         (gdb_exception_sliced_copy): Remove.
5298         (throw_exception_cxx): Update.
5299         * cli/cli-script.c (script_from_file): Update.
5300         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5301         Update.
5302         * ada-valprint.c (ada_val_print): Update.
5303         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5304         (create_excep_cond_exprs): Update.
5305
5306 2019-04-08  Tom Tromey  <tom@tromey.com>
5307
5308         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5309         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5310         (TRY, CATCH, END_CATCH): Remove some definitions.
5311         * common/common-exceptions.c: Don't use GDB_XCPT.
5312         (catcher_list_size): Remove.
5313         (throw_exception, throw_it): Simplify.
5314
5315 2019-04-05  Tom Tromey  <tom@tromey.com>
5316
5317         Revert the header-sorting patch.
5318         * ft32-tdep.c: Revert.
5319         * frv-tdep.c: Revert.
5320         * frv-linux-tdep.c: Revert.
5321         * frame.c: Revert.
5322         * frame-unwind.c: Revert.
5323         * frame-base.c: Revert.
5324         * fork-child.c: Revert.
5325         * findvar.c: Revert.
5326         * findcmd.c: Revert.
5327         * filesystem.c: Revert.
5328         * filename-seen-cache.h: Revert.
5329         * filename-seen-cache.c: Revert.
5330         * fbsd-tdep.c: Revert.
5331         * fbsd-nat.h: Revert.
5332         * fbsd-nat.c: Revert.
5333         * f-valprint.c: Revert.
5334         * f-typeprint.c: Revert.
5335         * f-lang.c: Revert.
5336         * extension.h: Revert.
5337         * extension.c: Revert.
5338         * extension-priv.h: Revert.
5339         * expprint.c: Revert.
5340         * exec.h: Revert.
5341         * exec.c: Revert.
5342         * exceptions.c: Revert.
5343         * event-top.c: Revert.
5344         * event-loop.c: Revert.
5345         * eval.c: Revert.
5346         * elfread.c: Revert.
5347         * dwarf2read.h: Revert.
5348         * dwarf2read.c: Revert.
5349         * dwarf2loc.c: Revert.
5350         * dwarf2expr.h: Revert.
5351         * dwarf2expr.c: Revert.
5352         * dwarf2-frame.c: Revert.
5353         * dwarf2-frame-tailcall.c: Revert.
5354         * dwarf-index-write.h: Revert.
5355         * dwarf-index-write.c: Revert.
5356         * dwarf-index-common.c: Revert.
5357         * dwarf-index-cache.h: Revert.
5358         * dwarf-index-cache.c: Revert.
5359         * dummy-frame.c: Revert.
5360         * dtrace-probe.c: Revert.
5361         * disasm.h: Revert.
5362         * disasm.c: Revert.
5363         * disasm-selftests.c: Revert.
5364         * dictionary.c: Revert.
5365         * dicos-tdep.c: Revert.
5366         * demangle.c: Revert.
5367         * dcache.h: Revert.
5368         * dcache.c: Revert.
5369         * darwin-nat.h: Revert.
5370         * darwin-nat.c: Revert.
5371         * darwin-nat-info.c: Revert.
5372         * d-valprint.c: Revert.
5373         * d-namespace.c: Revert.
5374         * d-lang.c: Revert.
5375         * ctf.c: Revert.
5376         * csky-tdep.c: Revert.
5377         * csky-linux-tdep.c: Revert.
5378         * cris-tdep.c: Revert.
5379         * cris-linux-tdep.c: Revert.
5380         * cp-valprint.c: Revert.
5381         * cp-support.c: Revert.
5382         * cp-namespace.c: Revert.
5383         * cp-abi.c: Revert.
5384         * corelow.c: Revert.
5385         * corefile.c: Revert.
5386         * continuations.c: Revert.
5387         * completer.h: Revert.
5388         * completer.c: Revert.
5389         * complaints.c: Revert.
5390         * coffread.c: Revert.
5391         * coff-pe-read.c: Revert.
5392         * cli-out.h: Revert.
5393         * cli-out.c: Revert.
5394         * charset.c: Revert.
5395         * c-varobj.c: Revert.
5396         * c-valprint.c: Revert.
5397         * c-typeprint.c: Revert.
5398         * c-lang.c: Revert.
5399         * buildsym.c: Revert.
5400         * buildsym-legacy.c: Revert.
5401         * build-id.h: Revert.
5402         * build-id.c: Revert.
5403         * btrace.c: Revert.
5404         * bsd-uthread.c: Revert.
5405         * breakpoint.h: Revert.
5406         * breakpoint.c: Revert.
5407         * break-catch-throw.c: Revert.
5408         * break-catch-syscall.c: Revert.
5409         * break-catch-sig.c: Revert.
5410         * blockframe.c: Revert.
5411         * block.c: Revert.
5412         * bfin-tdep.c: Revert.
5413         * bfin-linux-tdep.c: Revert.
5414         * bfd-target.c: Revert.
5415         * bcache.c: Revert.
5416         * ax-general.c: Revert.
5417         * ax-gdb.h: Revert.
5418         * ax-gdb.c: Revert.
5419         * avr-tdep.c: Revert.
5420         * auxv.c: Revert.
5421         * auto-load.c: Revert.
5422         * arm-wince-tdep.c: Revert.
5423         * arm-tdep.c: Revert.
5424         * arm-symbian-tdep.c: Revert.
5425         * arm-pikeos-tdep.c: Revert.
5426         * arm-obsd-tdep.c: Revert.
5427         * arm-nbsd-tdep.c: Revert.
5428         * arm-nbsd-nat.c: Revert.
5429         * arm-linux-tdep.c: Revert.
5430         * arm-linux-nat.c: Revert.
5431         * arm-fbsd-tdep.c: Revert.
5432         * arm-fbsd-nat.c: Revert.
5433         * arm-bsd-tdep.c: Revert.
5434         * arch-utils.c: Revert.
5435         * arc-tdep.c: Revert.
5436         * arc-newlib-tdep.c: Revert.
5437         * annotate.h: Revert.
5438         * annotate.c: Revert.
5439         * amd64-windows-tdep.c: Revert.
5440         * amd64-windows-nat.c: Revert.
5441         * amd64-tdep.c: Revert.
5442         * amd64-sol2-tdep.c: Revert.
5443         * amd64-obsd-tdep.c: Revert.
5444         * amd64-obsd-nat.c: Revert.
5445         * amd64-nbsd-tdep.c: Revert.
5446         * amd64-nbsd-nat.c: Revert.
5447         * amd64-nat.c: Revert.
5448         * amd64-linux-tdep.c: Revert.
5449         * amd64-linux-nat.c: Revert.
5450         * amd64-fbsd-tdep.c: Revert.
5451         * amd64-fbsd-nat.c: Revert.
5452         * amd64-dicos-tdep.c: Revert.
5453         * amd64-darwin-tdep.c: Revert.
5454         * amd64-bsd-nat.c: Revert.
5455         * alpha-tdep.c: Revert.
5456         * alpha-obsd-tdep.c: Revert.
5457         * alpha-nbsd-tdep.c: Revert.
5458         * alpha-mdebug-tdep.c: Revert.
5459         * alpha-linux-tdep.c: Revert.
5460         * alpha-linux-nat.c: Revert.
5461         * alpha-bsd-tdep.c: Revert.
5462         * alpha-bsd-nat.c: Revert.
5463         * aix-thread.c: Revert.
5464         * agent.c: Revert.
5465         * addrmap.c: Revert.
5466         * ada-varobj.c: Revert.
5467         * ada-valprint.c: Revert.
5468         * ada-typeprint.c: Revert.
5469         * ada-tasks.c: Revert.
5470         * ada-lang.c: Revert.
5471         * aarch64-tdep.c: Revert.
5472         * aarch64-ravenscar-thread.c: Revert.
5473         * aarch64-newlib-tdep.c: Revert.
5474         * aarch64-linux-tdep.c: Revert.
5475         * aarch64-linux-nat.c: Revert.
5476         * aarch64-fbsd-tdep.c: Revert.
5477         * aarch64-fbsd-nat.c: Revert.
5478         * aarch32-linux-nat.c: Revert.
5479
5480 2019-04-05  Tom Tromey  <tom@tromey.com>
5481
5482         * ft32-tdep.c: Sort headers.
5483         * frv-tdep.c: Sort headers.
5484         * frv-linux-tdep.c: Sort headers.
5485         * frame.c: Sort headers.
5486         * frame-unwind.c: Sort headers.
5487         * frame-base.c: Sort headers.
5488         * fork-child.c: Sort headers.
5489         * findvar.c: Sort headers.
5490         * findcmd.c: Sort headers.
5491         * filesystem.c: Sort headers.
5492         * filename-seen-cache.h: Sort headers.
5493         * filename-seen-cache.c: Sort headers.
5494         * fbsd-tdep.c: Sort headers.
5495         * fbsd-nat.h: Sort headers.
5496         * fbsd-nat.c: Sort headers.
5497         * f-valprint.c: Sort headers.
5498         * f-typeprint.c: Sort headers.
5499         * f-lang.c: Sort headers.
5500         * extension.h: Sort headers.
5501         * extension.c: Sort headers.
5502         * extension-priv.h: Sort headers.
5503         * expprint.c: Sort headers.
5504         * exec.h: Sort headers.
5505         * exec.c: Sort headers.
5506         * exceptions.c: Sort headers.
5507         * event-top.c: Sort headers.
5508         * event-loop.c: Sort headers.
5509         * eval.c: Sort headers.
5510         * elfread.c: Sort headers.
5511         * dwarf2read.h: Sort headers.
5512         * dwarf2read.c: Sort headers.
5513         * dwarf2loc.c: Sort headers.
5514         * dwarf2expr.h: Sort headers.
5515         * dwarf2expr.c: Sort headers.
5516         * dwarf2-frame.c: Sort headers.
5517         * dwarf2-frame-tailcall.c: Sort headers.
5518         * dwarf-index-write.h: Sort headers.
5519         * dwarf-index-write.c: Sort headers.
5520         * dwarf-index-common.c: Sort headers.
5521         * dwarf-index-cache.h: Sort headers.
5522         * dwarf-index-cache.c: Sort headers.
5523         * dummy-frame.c: Sort headers.
5524         * dtrace-probe.c: Sort headers.
5525         * disasm.h: Sort headers.
5526         * disasm.c: Sort headers.
5527         * disasm-selftests.c: Sort headers.
5528         * dictionary.c: Sort headers.
5529         * dicos-tdep.c: Sort headers.
5530         * demangle.c: Sort headers.
5531         * dcache.h: Sort headers.
5532         * dcache.c: Sort headers.
5533         * darwin-nat.h: Sort headers.
5534         * darwin-nat.c: Sort headers.
5535         * darwin-nat-info.c: Sort headers.
5536         * d-valprint.c: Sort headers.
5537         * d-namespace.c: Sort headers.
5538         * d-lang.c: Sort headers.
5539         * ctf.c: Sort headers.
5540         * csky-tdep.c: Sort headers.
5541         * csky-linux-tdep.c: Sort headers.
5542         * cris-tdep.c: Sort headers.
5543         * cris-linux-tdep.c: Sort headers.
5544         * cp-valprint.c: Sort headers.
5545         * cp-support.c: Sort headers.
5546         * cp-namespace.c: Sort headers.
5547         * cp-abi.c: Sort headers.
5548         * corelow.c: Sort headers.
5549         * corefile.c: Sort headers.
5550         * continuations.c: Sort headers.
5551         * completer.h: Sort headers.
5552         * completer.c: Sort headers.
5553         * complaints.c: Sort headers.
5554         * coffread.c: Sort headers.
5555         * coff-pe-read.c: Sort headers.
5556         * cli-out.h: Sort headers.
5557         * cli-out.c: Sort headers.
5558         * charset.c: Sort headers.
5559         * c-varobj.c: Sort headers.
5560         * c-valprint.c: Sort headers.
5561         * c-typeprint.c: Sort headers.
5562         * c-lang.c: Sort headers.
5563         * buildsym.c: Sort headers.
5564         * buildsym-legacy.c: Sort headers.
5565         * build-id.h: Sort headers.
5566         * build-id.c: Sort headers.
5567         * btrace.c: Sort headers.
5568         * bsd-uthread.c: Sort headers.
5569         * breakpoint.h: Sort headers.
5570         * breakpoint.c: Sort headers.
5571         * break-catch-throw.c: Sort headers.
5572         * break-catch-syscall.c: Sort headers.
5573         * break-catch-sig.c: Sort headers.
5574         * blockframe.c: Sort headers.
5575         * block.c: Sort headers.
5576         * bfin-tdep.c: Sort headers.
5577         * bfin-linux-tdep.c: Sort headers.
5578         * bfd-target.c: Sort headers.
5579         * bcache.c: Sort headers.
5580         * ax-general.c: Sort headers.
5581         * ax-gdb.h: Sort headers.
5582         * ax-gdb.c: Sort headers.
5583         * avr-tdep.c: Sort headers.
5584         * auxv.c: Sort headers.
5585         * auto-load.c: Sort headers.
5586         * arm-wince-tdep.c: Sort headers.
5587         * arm-tdep.c: Sort headers.
5588         * arm-symbian-tdep.c: Sort headers.
5589         * arm-pikeos-tdep.c: Sort headers.
5590         * arm-obsd-tdep.c: Sort headers.
5591         * arm-nbsd-tdep.c: Sort headers.
5592         * arm-nbsd-nat.c: Sort headers.
5593         * arm-linux-tdep.c: Sort headers.
5594         * arm-linux-nat.c: Sort headers.
5595         * arm-fbsd-tdep.c: Sort headers.
5596         * arm-fbsd-nat.c: Sort headers.
5597         * arm-bsd-tdep.c: Sort headers.
5598         * arch-utils.c: Sort headers.
5599         * arc-tdep.c: Sort headers.
5600         * arc-newlib-tdep.c: Sort headers.
5601         * annotate.h: Sort headers.
5602         * annotate.c: Sort headers.
5603         * amd64-windows-tdep.c: Sort headers.
5604         * amd64-windows-nat.c: Sort headers.
5605         * amd64-tdep.c: Sort headers.
5606         * amd64-sol2-tdep.c: Sort headers.
5607         * amd64-obsd-tdep.c: Sort headers.
5608         * amd64-obsd-nat.c: Sort headers.
5609         * amd64-nbsd-tdep.c: Sort headers.
5610         * amd64-nbsd-nat.c: Sort headers.
5611         * amd64-nat.c: Sort headers.
5612         * amd64-linux-tdep.c: Sort headers.
5613         * amd64-linux-nat.c: Sort headers.
5614         * amd64-fbsd-tdep.c: Sort headers.
5615         * amd64-fbsd-nat.c: Sort headers.
5616         * amd64-dicos-tdep.c: Sort headers.
5617         * amd64-darwin-tdep.c: Sort headers.
5618         * amd64-bsd-nat.c: Sort headers.
5619         * alpha-tdep.c: Sort headers.
5620         * alpha-obsd-tdep.c: Sort headers.
5621         * alpha-nbsd-tdep.c: Sort headers.
5622         * alpha-mdebug-tdep.c: Sort headers.
5623         * alpha-linux-tdep.c: Sort headers.
5624         * alpha-linux-nat.c: Sort headers.
5625         * alpha-bsd-tdep.c: Sort headers.
5626         * alpha-bsd-nat.c: Sort headers.
5627         * aix-thread.c: Sort headers.
5628         * agent.c: Sort headers.
5629         * addrmap.c: Sort headers.
5630         * ada-varobj.c: Sort headers.
5631         * ada-valprint.c: Sort headers.
5632         * ada-typeprint.c: Sort headers.
5633         * ada-tasks.c: Sort headers.
5634         * ada-lang.c: Sort headers.
5635         * aarch64-tdep.c: Sort headers.
5636         * aarch64-ravenscar-thread.c: Sort headers.
5637         * aarch64-newlib-tdep.c: Sort headers.
5638         * aarch64-linux-tdep.c: Sort headers.
5639         * aarch64-linux-nat.c: Sort headers.
5640         * aarch64-fbsd-tdep.c: Sort headers.
5641         * aarch64-fbsd-nat.c: Sort headers.
5642         * aarch32-linux-nat.c: Sort headers.
5643
5644 2019-04-04  Tom Tromey  <tom@tromey.com>
5645
5646         * varobj.c (varobj_create): Update.
5647         * rust-exp.y (struct rust_parser) <update_innermost_block,
5648         lookup_symbol>: New methods.
5649         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5650         Rename.
5651         (rust_parser::rust_lookup_type)
5652         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5653         * printcmd.c (display_command, do_one_display): Update.
5654         * parser-defs.h (struct parser_state) <parser_state>: Add
5655         "tracker" parameter.
5656         (block_tracker): New member.
5657         (class innermost_block_tracker) <innermost_block_tracker>: Add
5658         "types" parameter.
5659         <reset>: Remove method.
5660         (innermost_block): Don't declare.
5661         (null_post_parser): Update.
5662         * parse.c (innermost_block): Remove global.
5663         (write_dollar_variable): Update.
5664         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5665         Remove "tracker_types" parameter.
5666         (parse_expression): Add "tracker" parameter.
5667         (parse_expression_for_completion): Update.
5668         (null_post_parser): Add "tracker" parameter.
5669         * p-exp.y: Update rules.
5670         * m2-exp.y: Update rules.
5671         * language.h (struct language_defn) <la_post_parser>: Add
5672         "tracker" parameter.
5673         * go-exp.y: Update rules.
5674         * f-exp.y: Update rules.
5675         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5676         parameter.
5677         * d-exp.y: Update rules.
5678         * c-exp.y: Update rules.
5679         * breakpoint.c (set_breakpoint_condition): Create an
5680         innermost_block_tracker.
5681         (watch_command_1): Likewise.
5682         * ada-lang.c (resolve): Add "tracker" parameter.
5683         (resolve_subexp): Likewise.
5684         * ada-exp.y (write_var_from_sym): Update.
5685
5686 2019-04-04  Tom Tromey  <tom@tromey.com>
5687
5688         * type-stack.h: New file.
5689         * type-stack.c: New file.
5690         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5691         type-stack.h.
5692         (insert_into_type_stack, insert_type, push_type, push_type_int)
5693         (insert_type_address_space, pop_type, pop_type_int)
5694         (pop_typelist, pop_type_stack, append_type_stack)
5695         (push_type_stack, get_type_stack, push_typelist)
5696         (follow_type_instance_flags, follow_types): Don't declare.
5697         * parse.c (type_stack): Remove global.
5698         (parse_exp_in_context): Update.
5699         (insert_into_type_stack, insert_type, push_type, push_type_int)
5700         (insert_type_address_space, pop_type, pop_type_int)
5701         (pop_typelist, pop_type_stack, append_type_stack)
5702         (push_type_stack, get_type_stack, push_typelist)
5703         (follow_type_instance_flags, follow_types): Remove (moved to
5704         type-stack.c).
5705         * f-exp.y (type_stack): New global.
5706         Update rules.
5707         (push_kind_type, f_parse): Update.
5708         * d-exp.y (type_stack): New global.
5709         Update rules.
5710         (d_parse): Update.
5711         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5712         Update rules.
5713         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5714         (HFILES_NO_SRCDIR): Add type-stack.h.
5715
5716 2019-04-04  Tom Tromey  <tom@tromey.com>
5717
5718         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5719         (rust_parser::convert_ast_to_expression, rust_parse)
5720         (rust_lex_test_completion, rust_lex_tests): Update.
5721         * parser-defs.h (struct expr_completion_state): New.
5722         (struct parser_state) <parser_state>: Add completion parameter.
5723         <mark_struct_expression, mark_completion_tag>: New methods.
5724         <parse_completion, m_completion_state>: New members.
5725         (prefixify_expression, null_post_parser): Update.
5726         (mark_struct_expression, mark_completion_tag): Don't declare.
5727         * parse.c (parse_completion, expout_last_struct)
5728         (expout_tag_completion_type, expout_completion_name): Remove
5729         globals.
5730         (parser_state::mark_struct_expression)
5731         (parser_state::mark_completion_tag): Now methods.
5732         (prefixify_expression): Add last_struct parameter.
5733         (prefixify_subexp): Likewise.
5734         (parse_exp_1): Update.
5735         (parse_exp_in_context): Add cstate parameter.  Update.
5736         (parse_expression_for_completion): Create an
5737         expr_completion_state.
5738         (null_post_parser): Add "completion" parameter.
5739         * p-exp.y: Update rules.
5740         (yylex): Update.
5741         * language.h (struct language_defn) <la_post_parser>: Add
5742         "completing" parameter.
5743         * go-exp.y: Update rules.
5744         (lex_one_token): Update.
5745         * expression.h (parse_completion): Don't declare.
5746         * d-exp.y: Update rules.
5747         (lex_one_token): Update rules.
5748         * c-exp.y: Update rules.
5749         (lex_one_token): Update.
5750         * ada-lang.c (resolve): Add "parse_completion" parameter.
5751         (resolve_subexp): Likewise.
5752         (ada_resolve_function): Likewise.
5753
5754 2019-04-04  Tom Tromey  <tom@tromey.com>
5755
5756         * parser-defs.h (struct parser_state) <start_arglist,
5757         end_arglist>: New methods.
5758         <arglist_len, m_funcall_chain>: New members.
5759         (arglist_len, start_arglist, end_arglist): Don't declare.
5760         * parse.c (arglist_len, funcall_chain): Remove global.
5761         (start_arglist, end_arglist): Remove functions.
5762         (parse_exp_in_context): Update.
5763         * p-exp.y: Update rules.
5764         * m2-exp.y: Update rules.
5765         * go-exp.y: Update rules.
5766         * f-exp.y: Update rules.
5767         * d-exp.y: Update rules.
5768         * c-exp.y: Update rules.
5769
5770 2019-04-04  Tom Tromey  <tom@tromey.com>
5771
5772         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5773         lex_operator, push_back>: New methods.
5774         Update all rules.
5775         (rust_parser::lex_hex, lex_escape): Rename and update.
5776         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5777         (rust_parser::lex_operator): Rename and update.
5778         (rust_parser::lex_number, rustyylex, rustyyerror)
5779         (rust_lex_test_init, rust_lex_test_sequence)
5780         (rust_lex_test_push_back, rust_lex_tests): Update.
5781         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5782         parameter.
5783         <lexptr, prev_lexptr>: New members.
5784         (lexptr, prev_lexptr): Don't declare.
5785         * parse.c (lexptr, prev_lexptr): Remove globals.
5786         (parse_exp_in_context): Update.
5787         * p-exp.y (yylex, yyerror): Update.
5788         * m2-exp.y (parse_number, yylex, yyerror): Update.
5789         * go-exp.y (lex_one_token, yyerror): Update.
5790         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5791         * d-exp.y (lex_one_token, yyerror): Update.
5792         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5793         (lex_one_token, yyerror): Update.
5794         * ada-lex.l (YY_INPUT): Update.
5795         (rewind_to_char): Update.
5796         * ada-exp.y (yyerror): Update.
5797
5798 2019-04-04  Tom Tromey  <tom@tromey.com>
5799
5800         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5801         * parser-defs.h (struct parser_state) <parser_state>: Add new
5802         parameter.
5803         <comma_terminates>: New member.
5804         (comma_terminates): Don't declare global.
5805         * parse.c (comma_terminates): Remove global.
5806         (parse_exp_in_context): Update.
5807         * p-exp.y (yylex): Update.
5808         * m2-exp.y (yylex): Update.
5809         * go-exp.y (lex_one_token): Update.
5810         * f-exp.y (yylex): Update.
5811         * d-exp.y (lex_one_token): Update.
5812         * c-exp.y (lex_one_token): Update.
5813         * ada-lex.l: Update.
5814
5815 2019-04-04  Tom Tromey  <tom@tromey.com>
5816
5817         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5818         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5819         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5820         * parser-defs.h (paren_depth): Don't declare.
5821         * parse.c (paren_depth): Remove global.
5822         (parse_exp_in_context): Update.
5823         * p-exp.y (paren_depth): New global.
5824         (pascal_parse): Initialize it.
5825         * m2-exp.y (paren_depth): New global.
5826         (m2_parse): Initialize it.
5827         * go-exp.y (paren_depth): New global.
5828         (go_parse): Initialize it.
5829         * f-exp.y (paren_depth): New global.
5830         (f_parse): Initialize it.
5831         * d-exp.y (paren_depth): New global.
5832         (d_parse): Initialize it.
5833         * c-exp.y (paren_depth): New global.
5834         (c_parse): Initialize it.
5835         * ada-lex.l (paren_depth): New global.
5836         (lexer_init): Initialize it.
5837
5838 2019-04-04  Tom Tromey  <tom@tromey.com>
5839
5840         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5841         (rust_parser::convert_ast_to_type)
5842         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5843         * parser-defs.h (struct parser_state) <parser_state>: Add
5844         parameters.  Initialize new members.
5845         <expression_context_block, expression_context_pc>: New members.
5846         * parse.c (expression_context_block, expression_context_pc):
5847         Remove globals.
5848         (parse_exp_in_context): Update.
5849         * p-exp.y: Update all rules.
5850         (yylex): Update.
5851         * m2-exp.y: Update all rules.
5852         (yylex): Update.
5853         * go-exp.y (yylex): Update.
5854         * f-exp.y (yylex): Update.
5855         * d-exp.y: Update all rules.
5856         (yylex): Update.
5857         * c-exp.y: Update all rules.
5858         (lex_one_token, classify_name, yylex, c_parse): Update.
5859         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5860
5861 2019-04-04  Tom Tromey  <tom@tromey.com>
5862
5863         * gdbarch.h, gdbarch.c: Rebuild.
5864         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5865         * stap-probe.h:
5866         (struct stap_parse_info): Replace "parser_state" with
5867         "expr_builder".
5868         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5869         (parser_state): New class.
5870         * parse.c (expr_builder): Rename.
5871         (expr_builder::release): Rename.
5872         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5873         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5874         (write_exp_elt_longcst, write_exp_elt_floatcst)
5875         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5876         (write_exp_string_vector, write_exp_bitstring)
5877         (write_exp_msymbol, mark_struct_expression)
5878         (write_dollar_variable)
5879         (insert_type_address_space, increase_expout_size): Replace
5880         "parser_state" with "expr_builder".
5881         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5882         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5883         "parser_state" with "expr_builder".
5884
5885 2019-04-04  Tom Tromey  <tom@tromey.com>
5886
5887         * rust-exp.y: Replace "parse_language" with method call.
5888         * p-exp.y:
5889         (yylex): Replace "parse_language" with method call.
5890         * m2-exp.y:
5891         (yylex): Replace "parse_language" with method call.
5892         * go-exp.y (classify_name): Replace "parse_language" with method
5893         call.
5894         * f-exp.y (yylex): Replace "parse_language" with method call.
5895         * d-exp.y (lex_one_token): Replace "parse_language" with method
5896         call.
5897         * c-exp.y:
5898         (lex_one_token, classify_name, yylex): Replace "parse_language"
5899         with method call.
5900         * ada-exp.y (find_primitive_type, type_char)
5901         (type_system_address): Replace "parse_language" with method call.
5902
5903 2019-04-04  Tom Tromey  <tom@tromey.com>
5904
5905         * rust-exp.y: Replace "parse_gdbarch" with method call.
5906         * parse.c (write_dollar_variable, insert_type_address_space):
5907         Replace "parse_gdbarch" with method call.
5908         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5909         call.
5910         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5911         call.
5912         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5913         "parse_gdbarch" with method call.
5914         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5915         with method call.
5916         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5917         "parse_gdbarch" with method call.
5918         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5919         "parse_gdbarch" with method call.
5920         * c-exp.y (parse_type, parse_number, classify_name): Replace
5921         "parse_gdbarch" with method call.
5922         * ada-lex.l: Replace "parse_gdbarch" with method call.
5923         * ada-exp.y (parse_type, find_primitive_type, type_char)
5924         (type_system_address): Replace "parse_gdbarch" with method call.
5925
5926 2019-04-04  Tom Tromey  <tom@tromey.com>
5927
5928         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5929         * stap-probe.c (stap_parse_argument): Update.
5930         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5931         initial_size parameter.
5932         * rust-exp.y (rust_lex_tests): Update.
5933         * parse.c (parser_state): Update.
5934         (parse_exp_in_context): Update.
5935         * parser-defs.h (struct parser_state) <parser_state>: Remove
5936         "initial_size" parameter.
5937
5938 2019-04-04  Tom Tromey  <tom@tromey.com>
5939
5940         * parser-defs.h (increase_expout_size): Don't declare.
5941         * parse.c (increase_expout_size): Now static.
5942
5943 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5944
5945         * gnu-nat.c (gnu_nat_target::wait): Fix
5946         target_waitstatus_to_string call.
5947
5948 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5949
5950         * eval.c (evaluate_subexp_standard): Handle internal functions
5951         during Fortran function call handling.
5952
5953 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5954
5955         * NEWS: Mention new internal functions.
5956         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5957         (read_base_type): Use dwarf2_init_complex_target_type.
5958         * value.c (creal_internal_fn): New function.
5959         (cimag_internal_fn): New function.
5960         (_initialize_values): Register new internal functions.
5961
5962 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5963
5964         * infrun.c (stop_all_threads): If debug_infrun, always
5965         trace the wait status after wait_one, using
5966         target_waitstatus_to_string and target_pid_to_str.
5967         (handle_inferior_event): Replace various trace of
5968         wait status kind by a single trace.
5969         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5970         wait status kind image by target_waitstatus_to_string.
5971         * target/waitstatus.c (target_waitstatus_to_string): Fix
5972         obsolete comment.
5973
5974 2019-04-01  Tom Tromey  <tromey@adacore.com>
5975
5976         PR symtab/23331:
5977         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5978
5979 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5980             Pedro Alves  <palves@redhat.com>
5981
5982         * top.c (quit_force): Call 'finalize_values'.
5983         * value.c (finalize_values): New function.
5984         * value.h (finalize_values): Declare.
5985
5986 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5987
5988         * NEWS: Announce $_gdb_major and $_gdb_minor.
5989
5990         * top.c (init_gdb_version_vars): New function.
5991         (gdb_init): Call init_gdb_version_vars.
5992
5993 2019-03-29  Tom Tromey  <tromey@adacore.com>
5994
5995         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5996         help text.  Remove dead code.
5997
5998 2019-03-29  Keith Seitz  <keiths@redhat.com>
5999
6000         From Siddhesh Poyarekar:
6001         * f-lang.h (f77_get_upperbound): Return LONGEST.
6002         (f77_get_lowerbound): Likewise.
6003         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6004         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6005         print them.
6006         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6007         plongest to format print it.
6008         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6009         (f77_get_upperbound): Likewise.
6010         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6011         LOWER_BOUND to LONGEST.
6012         (f77_create_arrayprint_offset_tbl): Likewise.
6013
6014 2019-03-29  Keith Seitz  <keiths@redhat.com>
6015
6016         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6017         %s/pulongest for TYPE_LENGTH instead of %d in format
6018         strings.
6019         * ada-typerint.c (ada_print_type): Likewise.
6020         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6021         * compile/compile-c-support.c (generate_register_struct): Likewise.
6022         * gdbtypes.c (recursive_dump_type): Likewise.
6023         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6024         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6025         instead of %d in format strings.
6026         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6027         to std::min to ULONGEST.
6028         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6029         instead of %d in format strings.
6030         * tracepoint.c (info_scope_command): Likewise.
6031         * typeprint.c (print_offset_data::update)
6032         (print_offset_data::finish): Likewise.
6033         * xtensa-tdep.c (xtensa_store_return_value)
6034         (xtensa_push_dummy_call): Likewise.
6035
6036 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6037
6038         * windows-nat.c (display_selector): Fixed format specifications
6039         for 64-bit Cygwin.
6040
6041 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6042
6043         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6044
6045 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6046
6047         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6048         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6049         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6050         (nios2_linux_init_abi): Install it.
6051
6052 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6053
6054         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6055
6056 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6057
6058         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6059
6060 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6061             Tom Tromey  <tromey@adacore.com>
6062
6063         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6064
6065 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6066
6067         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6068         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6069         method to compute the bounds of range types. Also print "[evaluated]"
6070         if the bounds' values come from a dynamic evaluation.
6071
6072 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6073
6074         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6075         whitespace when pretty printing is on.
6076
6077 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6078
6079         * ppc-linux-nat.c: Add include.
6080
6081 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6082
6083         * NEWS: Mention AArch64 Pointer Authentication.
6084
6085 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6086
6087         * arm-linux-nat.c: Add include.
6088
6089 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6090
6091         * source-cache.c (source_cache::get_source_lines): Re-read
6092         fullname after calling open_source_file.
6093
6094 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6095
6096         * NEWS: Mention TLS support for FreeBSD.
6097
6098 2019-03-25  Tom Tromey  <tromey@adacore.com>
6099
6100         * minsyms.c (BUNCH_SIZE): Update comment.
6101         (~minimal_symbol_reader): Remove old comment.
6102         (compact_minimal_symbols): Update comment.
6103         (minimal_symbol_reader::install): Remove old comment.  Update
6104         other comments.
6105
6106 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6107
6108         * s390-linux-nat.c: Add include.
6109
6110 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6111
6112         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6113         Call linux_get_hwcap.
6114         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6115         Likewise.
6116         (aarch64_linux_get_hwcap): Remove function.
6117         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6118         declaration.
6119         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6120         linux_get_hwcap.
6121         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6122         * linux-tdep.c (linux_get_hwcap): Add function.
6123         (linux_get_hwcap2): Likewise.
6124         * linux-tdep.h (linux_get_hwcap): Add declaration.
6125         (linux_get_hwcap2): Likewise.
6126         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6127         (ppc_linux_get_hwcap2): Likewise.
6128         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6129         linux_get_hwcap.
6130         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6131         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6132         (ppc_linux_nat_target::read_description): Likewise.
6133         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6134         * s390-linux-nat.c: Likewise.
6135         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6136
6137 2019-03-24  Tom Tromey  <tom@tromey.com>
6138
6139         * ada-lang.c (standard_lookup): Simplify initialization.
6140         (ada_lookup_symbol_nonlocal): Simplify return.
6141         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6142         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6143         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6144         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6145         initialization.
6146         * solib.c (solib_global_lookup): Simplify.
6147         * symtab.c (null_block_symbol): Remove.
6148         (symbol_cache_lookup): Simplify returns.
6149         (lookup_language_this): Simplify returns.
6150         (lookup_symbol_aux): Simplify return.
6151         (lookup_local_symbol): Simplify returns.
6152         (lookup_global_symbol_from_objfile): Simplify return.
6153         (lookup_symbol_in_objfile_symtabs)
6154         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6155         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6156         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6157         * cp-namespace.c (cp_lookup_bare_symbol)
6158         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6159         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6160         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6161         (cp_lookup_symbol_via_imports): Simplify initialization.
6162         (find_symbol_in_baseclass): Likewise.
6163         * symtab.h (null_block_symbol): Remove.
6164         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6165         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6166         (d_lookup_symbol_module): Likewise.
6167         (find_symbol_in_baseclass): Simplify initialization.
6168
6169 2019-03-24  Tom Tromey  <tom@tromey.com>
6170
6171         * expression.h: Don't include symtab.h.
6172         (struct block): Forward declare.
6173
6174 2019-03-24  Tom Tromey  <tom@tromey.com>
6175
6176         * c-exp.y (typebase): Remove casts.
6177         * gdbtypes.c (lookup_unsigned_typename, )
6178         (lookup_signed_typename): Remove cast.
6179         * eval.c (parse_to_comma_and_eval): Remove cast.
6180         * parse.c (write_dollar_variable): Remove cast.
6181         * block.h (struct block) <superblock>: Now const.
6182         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6183         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6184         (map_block): Make "block" const.
6185         * symfile.h (struct quick_symbol_functions)
6186         <map_matching_symbols>: Constify block argument to "callback".
6187         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6188         const.
6189         (find_pc_sect_compunit_symtab): Make "b" const.
6190         (find_symbol_at_address): Likewise.
6191         (search_symbols): Likewise.
6192         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6193         (dw2_debug_names_lookup_symbol): Likewise.
6194         (dw2_map_matching_symbols): Update.
6195         * p-valprint.c (pascal_val_print): Remove "block".
6196         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6197         (aux_add_nonlocal_symbols): Make "block" const.
6198         (resolve_subexp): Remove cast.
6199         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6200         const.
6201         (iterate_over_file_blocks): Likewise.
6202         * f-exp.y (%union) <bval>: Remove.
6203         * coffread.c (patch_opaque_types): Make "b" const.
6204         * spu-tdep.c (spu_catch_start): Make "block" const.
6205         * c-valprint.c (print_unpacked_pointer): Remove "block".
6206         * symmisc.c (dump_symtab_1): Make "b" const.
6207         (block_depth): Make "block" const.
6208         * d-exp.y (%union) <bval>: Remove.
6209         * cp-support.h (cp_lookup_rtti_type): Update.
6210         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6211         * psymtab.c (psym_lookup_symbol): Make "block" const.
6212         (maintenance_check_psymtabs): Make "b" const.
6213         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6214         (enumerate_locals, enumerate_args): Update.
6215         * python/py-symtab.c (stpy_global_block): Make "block" const.
6216         (stpy_static_block): Likewise.
6217         * inline-frame.c (block_starting_point_at): Make "new_block"
6218         const.
6219         * block.c (find_block_in_blockvector): Make return type const.
6220         (blockvector_for_pc_sect): Make "b" const.
6221         (find_block_in_blockvector): Make "b" const.
6222
6223 2019-03-23  Tom Tromey  <tom@tromey.com>
6224
6225         * varobj.c (varobj_create): Update.
6226         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6227         * printcmd.c (display_command, do_one_display): Don't reset
6228         innermost_block.
6229         * parser-defs.h (enum innermost_block_tracker_type): Move to
6230         expression.h.
6231         (innermost_block): Update comment.
6232         * parse.c (parse_exp_1): Add tracker_types parameter.
6233         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6234         tracker_types parameter.  Reset innermost_block.
6235         (parse_exp_in_context): Remove.
6236         (parse_expression_for_completion): Update.
6237         * objfiles.c (~objfile): Don't reset expression_context_block or
6238         innermost_block.
6239         * expression.h (enum innermost_block_tracker_type): Move from
6240         parser-defs.h.
6241         (parse_exp_1): Add tracker_types parameter.
6242         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6243         reset innermost_block.
6244
6245 2019-03-23  Tom Tromey  <tom@tromey.com>
6246
6247         * objfiles.h: Include bcache.h.
6248
6249 2019-03-23  Tom Tromey  <tom@tromey.com>
6250
6251         * linespec.c (get_current_search_block): Use
6252         scoped_restore_current_language.
6253         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6254
6255 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6256             Jiong Wang  <jiong.wang@arm.com>
6257
6258         * aarch64-linux-tdep.c
6259         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6260         section.
6261         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6262
6263 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6264             Jiong Wang  <jiong.wang@arm.com>
6265
6266         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6267         instructions.
6268         (aarch64_analyze_prologue_test): Add PACIASP test.
6269         (aarch64_prologue_prev_register): Unmask PC value.
6270
6271 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6272             Jiong Wang  <jiong.wang@arm.com>
6273
6274         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6275         (aarch64_dwarf2_prev_register): Unmask PC value.
6276         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6277         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6278         DW_CFA_AARCH64_negate_ra_state.
6279         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6280
6281 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6282             Jiong Wang  <jiong.wang@arm.com>
6283
6284         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6285         registers.
6286         (aarch64_pseudo_register_name): Likewise.
6287         (aarch64_pseudo_register_type): Likewise.
6288         (aarch64_pseudo_register_reggroup_p): Likewise.
6289         (aarch64_gdbarch_init): Add pauth registers.
6290         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6291         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6292         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6293         (struct gdbarch_tdep): Add regnum for ra_state.
6294
6295 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6296             Jiong Wang  <jiong.wang@arm.com>
6297
6298         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6299
6300 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6301             Jiong Wang  <jiong.wang@arm.com>
6302
6303         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6304         function.
6305         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6306         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6307         (aarch64_gdbarch_init): Add puth registers.
6308         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6309         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6310         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6311
6312 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6313             Jiong Wang  <jiong.wang@arm.com>
6314
6315         * aarch64-linux-nat.c
6316         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6317         * aarch64-linux-tdep.c
6318         (aarch64_linux_core_read_description): Likewise.
6319         (aarch64_linux_get_hwcap): New function.
6320         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6321         (aarch64_linux_get_hwcap): New declaration.
6322
6323 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6324             Jiong Wang  <jiong.wang@arm.com>
6325
6326         * aarch64-linux-nat.c
6327         (aarch64_linux_nat_target::read_description): Add pauth param.
6328         * aarch64-linux-tdep.c
6329         (aarch64_linux_core_read_description): Likewise.
6330         * aarch64-tdep.c (struct target_desc): Add in pauth.
6331         (aarch64_read_description): Add pauth param.
6332         (aarch64_gdbarch_init): Likewise.
6333         * aarch64-tdep.h (aarch64_read_description): Likewise.
6334         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6335         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6336         * features/Makefile: Add new files.
6337         * features/aarch64-pauth.c: New file.
6338         * features/aarch64-pauth.xml: New file.
6339
6340 2019-03-20  Tom Tromey  <tromey@adacore.com>
6341
6342         * infrun.c (handle_inferior_event): Rename from
6343         handle_inferior_event_1.  Create a scoped_value_mark.
6344         (handle_inferior_event): Remove.
6345
6346 2019-03-19  Tom Tromey  <tromey@adacore.com>
6347
6348         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6349         * infrun.h (print_stop_event): Add "displays" parameter.
6350         * infrun.c (print_stop_event): Add "displays" parameter.
6351
6352 2019-03-19  Pedro Alves  <palves@redhat.com>
6353
6354         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6355         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6356         to -1.  Fix TABs vs spaces.
6357         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6358         * tui/tui-out.h (tui_ui_out) Add intro comments.
6359         <m_line, m_start_of_line>: In-class initialize, and add describing
6360         comment.
6361
6362 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6363
6364         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6365         variable names.
6366         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6367
6368 2019-03-18  Pedro Alves  <palves@redhat.com>
6369             Eli Zaretskii <eliz@gnu.org>
6370
6371         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6372         m_line and m_start_of_line.
6373
6374 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6375
6376         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6377         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6378         it returns a newline.  This fixes a regression in TU mode, whereby
6379         the next line is output on the same screen line as the user input.
6380
6381 2019-03-18  Tom Tromey  <tromey@adacore.com>
6382
6383         * minsyms.c (minimal_symbol_reader::install): Remove call to
6384         obstack_blank.
6385
6386 2019-03-18  Pedro Alves  <palves@redhat.com>
6387
6388         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6389         New globals.
6390         (apply_style): New, factored out from ...
6391         (apply_ansi_escape): ... this.  Handle reverse video mode.
6392         (tui_set_reverse_mode): New function.
6393         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6394         * tui/tui-winsource.c (tui_show_source_line): Use
6395         tui_set_reverse_mode instead of setting A_STANDOUT.
6396         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6397         New setter methods.
6398
6399 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6400
6401         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6402         Handle tabs.
6403
6404 2019-03-18  Tom Tromey  <tromey@adacore.com>
6405
6406         * ada-lang.c (empty_array): Add "high" parameter.
6407         (ada_evaluate_subexp): Update.
6408
6409 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6410
6411         * unittests/string_view-selftests.c: Define
6412         _initialize_string_view_selftests unconditionally.
6413
6414 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6415
6416         PR gdb/24350
6417         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6418
6419 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6420
6421         PR gdb/24351
6422         * windows-nat.c (display_selector): Fix format specifiers.
6423
6424 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6425
6426         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6427         tui_refill_source_window instead of tui_refresh_win, to update the
6428         current execution line.  This fixes redisplay of the current line
6429         when stepping through the code with "next" or "step".
6430
6431 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6432
6433         * source-cache.c (source_cache::get_source_lines): Call
6434         find_source_lines to initialize s->nlines.  This fixes vertical
6435         scrolling of TUI source window when the DOWN arrow is pressed.
6436
6437 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6438
6439         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6440         linux-thread-db.c (_initialize_thread_db): Likewise.
6441
6442 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6443
6444         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6445         wclrtoeol in tui_show_source_line".  This reverts changes made in
6446         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6447
6448 2019-03-15  Tom Tromey  <tom@tromey.com>
6449
6450         * symtab.h (struct minimal_symbol): Derive from
6451         general_symbol_info.
6452         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6453         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6454         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6455         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6456         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6457         (MSYMBOL_SEARCH_NAME): Update.
6458         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6459         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6460         * minsyms.c (minimal_symbol_reader::record_full): Update.
6461
6462 2019-03-15  Tom Tromey  <tom@tromey.com>
6463
6464         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6465
6466 2019-03-15  Tom Tromey  <tom@tromey.com>
6467
6468         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6469         unique_xmalloc_ptr.
6470         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6471         Update.
6472         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6473         (build_minimal_symbol_hash_tables)
6474         (minimal_symbol_reader::install): Update.
6475
6476 2019-03-15  Tom Tromey  <tom@tromey.com>
6477
6478         * symtab.c (create_demangled_names_hash): Update.
6479         (symbol_set_names): Update.
6480         * objfiles.h (struct objfile_per_bfd_storage)
6481         <demangled_names_hash>: Now an htab_up.
6482         * objfiles.c (objfile_per_bfd_storage): Simplify.
6483
6484 2019-03-15  Tom Tromey  <tom@tromey.com>
6485
6486         * objfiles.h (struct objfile_per_bfd_storage): Declare
6487         destructor.
6488         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6489         New.
6490         (get_objfile_bfd_data): Use new.  Don't initialize
6491         language_of_main.
6492         (free_objfile_per_bfd_storage): Remove.
6493         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6494
6495 2019-03-15  Tom Tromey  <tom@tromey.com>
6496
6497         * symfile.c (reread_symbols): Update.
6498         * objfiles.c (objfile::objfile): Update.
6499         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6500         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6501         comment.
6502         (minimal_symbol_reader::install): Update.
6503         (terminate_minimal_symbol_table): Remove.
6504         * jit.c (jit_object_close_impl): Update.
6505
6506 2019-03-15  Tom Tromey  <tom@tromey.com>
6507
6508         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6509         initializations.
6510
6511 2019-03-15  Tom Tromey  <tom@tromey.com>
6512
6513         * objfiles.h (struct objfile_per_bfd_storage)
6514         <demangled_hash_languages>: Now a bitset.
6515         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6516         (lookup_minimal_symbol): Update.
6517
6518 2019-03-15  Tom Tromey  <tom@tromey.com>
6519
6520         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6521         Don't return the symbol.
6522         * coffread.c (record_minimal_symbol): Use record_full.
6523
6524 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6525
6526         The MS-Windows port of ncurses fails to switch to a color pair if
6527         one or both of the colors are the implicit default colors.  This
6528         change records the default colors when TUI is initialized, and
6529         then specifies them explicitly when a color pair uses the default
6530         colors.  This allows color styling in TUI mode on MS-Windows.
6531
6532         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6533         ncurses_norm_attr.
6534         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6535         colors in ncurses_norm_attr.
6536         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6537         "none", replace it with the default color recorded in
6538         ncurses_norm_attr.
6539
6540 2019-03-14  Tom Tromey  <tromey@adacore.com>
6541
6542         * source-cache.h (class source_cache) <get_source_lines>: Return
6543         std::string.
6544         * source-cache.c (source_cache::extract_lines): Handle case where
6545         first_pos==npos.  Return std::string.
6546         (source_cache::get_source_lines): Update.
6547
6548 2019-03-14  Tom Tromey  <tromey@adacore.com>
6549
6550         * NEWS: Add item for "style sources" commands.
6551         * source-cache.c (source_cache::get_source_lines): Check
6552         source_styling.
6553         * cli/cli-style.c (source_styling): New global.
6554         (_initialize_cli_style): Add "style sources" commands.
6555         (show_style_sources): New function.
6556         * cli/cli-style.h (source_styling): Declare.
6557
6558 2019-03-14  Pedro Alves  <palves@redhat.com>
6559             Tom Tromey  <tromey@adacore.com>
6560
6561         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6562         * tui/tui-winsource.c (tui_refill_source_window): New function,
6563         from...
6564         (tui_horizontal_source_scroll): ... here.  Move some logic.
6565         * cli/cli-style.c (set_style_enabled): Notify new observable.
6566         * tui/tui-hooks.c (tui_redisplay_source): New function.
6567         (tui_attach_detach_observers): Attach or detach
6568         tui_redisplay_source.
6569         * observable.h (source_styling_changed): New observable.
6570         * observable.c: Define source_styling_changed observable.
6571
6572 2019-03-13  Tom Tromey  <tromey@adacore.com>
6573
6574         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6575         (i386_gnu_nat_target::store_registers): Update.
6576         * target-debug.h (target_debug_print_std_string): New macro.
6577         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6578         * windows-tdep.c (display_one_tib): Update.
6579         * tui/tui-stack.c (tui_make_status_line): Update.
6580         * top.c (print_inferior_quit_action): Update.
6581         * thread.c (thr_try_catch_cmd): Update.
6582         (add_thread_with_info): Update.
6583         (thread_target_id_str): Update.
6584         (thr_try_catch_cmd): Update.
6585         (thread_command): Update.
6586         (thread_find_command): Update.
6587         * record-btrace.c (record_btrace_target::info_record)
6588         (record_btrace_resume_thread, record_btrace_target::resume)
6589         (record_btrace_cancel_resume, record_btrace_step_thread)
6590         (record_btrace_target::wait, record_btrace_target::wait)
6591         (record_btrace_target::wait, record_btrace_target::stop): Update.
6592         * progspace.c (print_program_space): Update.
6593         * process-stratum-target.c
6594         (process_stratum_target::thread_address_space): Update.
6595         * linux-fork.c (linux_fork_mourn_inferior)
6596         (detach_checkpoint_command, info_checkpoints_command)
6597         (linux_fork_context): Update.
6598         (linux_fork_detach): Update.
6599         (class scoped_switch_fork_info): Update.
6600         (delete_checkpoint_command): Update.
6601         * infrun.c (follow_fork_inferior): Update.
6602         (follow_fork_inferior): Update.
6603         (proceed_after_vfork_done): Update.
6604         (handle_vfork_child_exec_or_exit): Update.
6605         (follow_exec): Update.
6606         (displaced_step_prepare_throw): Update.
6607         (displaced_step_restore): Update.
6608         (start_step_over): Update.
6609         (resume_1): Update.
6610         (clear_proceed_status_thread): Update.
6611         (proceed): Update.
6612         (print_target_wait_results): Update.
6613         (do_target_wait): Update.
6614         (context_switch): Update.
6615         (stop_all_threads): Update.
6616         (restart_threads): Update.
6617         (finish_step_over): Update.
6618         (handle_signal_stop): Update.
6619         (switch_back_to_stepped_thread): Update.
6620         (keep_going_pass_signal): Update.
6621         (print_exited_reason): Update.
6622         (normal_stop): Update.
6623         * inferior.c (inferior_pid_to_str): Change return type.
6624         (print_selected_inferior): Update.
6625         (add_inferior): Update.
6626         (detach_inferior): Update.
6627         * dummy-frame.c (fprint_dummy_frames): Update.
6628         * dcache.c (dcache_info_1): Update.
6629         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6630         (btrace_fetch, btrace_clear): Update.
6631         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6632         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6633         type.
6634         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6635         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6636         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6637         * gdbarch.c, gdbarch.h: Rebuild.
6638         * gdbarch.sh (core_pid_to_str): Change return type.
6639         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6640         return type.
6641         (windows_nat_target::pid_to_str): Change return type.
6642         (windows_delete_thread): Update.
6643         (windows_nat_target::attach): Update.
6644         (windows_nat_target::files_info): Update.
6645         * target-delegates.c: Rebuild.
6646         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6647         return type.
6648         (sol_thread_target::pid_to_str): Change return type.
6649         * remote.c (class remote_target) <pid_to_str>: Change return
6650         type.
6651         (remote_target::pid_to_str): Change return type.
6652         (extended_remote_target::attach, remote_target::remote_stop_ns)
6653         (remote_target::remote_notif_remove_queued_reply)
6654         (remote_target::push_stop_reply, remote_target::disable_btrace):
6655         Update.
6656         (extended_remote_target::attach): Update.
6657         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6658         type.
6659         (gdbsim_target::pid_to_str): Change return type.
6660         * ravenscar-thread.c (struct ravenscar_thread_target)
6661         <pid_to_str>: Change return type.
6662         (ravenscar_thread_target::pid_to_str): Change return type.
6663         * procfs.c (class procfs_target) <pid_to_str>: Change return
6664         type.
6665         (procfs_target::pid_to_str): Change return type.
6666         (procfs_target::attach): Update.
6667         (procfs_target::detach): Update.
6668         (procfs_target::fetch_registers): Update.
6669         (procfs_target::store_registers): Update.
6670         (procfs_target::wait): Update.
6671         (procfs_target::files_info): Update.
6672         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6673         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6674         return type.
6675         (nto_procfs_target::pid_to_str): Change return type.
6676         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6677         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6678         return type.
6679         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6680         (exit_lwp): Update.
6681         (attach_proc_task_lwp_callback, get_detach_signal)
6682         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6683         (linux_nat_target::resume, wait_lwp, stop_callback)
6684         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6685         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6686         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6687         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6688         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6689         type.
6690         (inf_ptrace_target::attach): Update.
6691         (inf_ptrace_target::files_info): Update.
6692         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6693         type.
6694         (go32_nat_target::pid_to_str): Change return type.
6695         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6696         (gnu_nat_target::wait): Update.
6697         (gnu_nat_target::wait): Update.
6698         (gnu_nat_target::resume): Update.
6699         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6700         (fbsd_nat_target::wait): Update.
6701         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6702         type.
6703         (darwin_nat_target::attach): Update.
6704         * corelow.c (class core_target) <pid_to_str>: Change return type.
6705         (core_target::pid_to_str): Change return type.
6706         * target.c (normal_pid_to_str): Change return type.
6707         (default_pid_to_str): Likewise.
6708         (target_pid_to_str): Change return type.
6709         (target_translate_tls_address): Update.
6710         (target_announce_detach): Update.
6711         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6712         return type.
6713         (bsd_uthread_target::pid_to_str): Change return type.
6714         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6715         type.
6716         (bsd_kvm_target::pid_to_str): Change return type.
6717         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6718         return type.
6719         (aix_thread_target::pid_to_str): Change return type.
6720         * target.h (struct target_ops) <pid_to_str>: Change return type.
6721         (target_pid_to_str, normal_pid_to_str): Likewise.
6722         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6723         type.
6724         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6725         type.
6726         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6727         return type.
6728         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6729         type.
6730         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6731         type.
6732         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6733         return type.
6734
6735 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6736
6737         * NEWS: Mention that the new default MI version is 3.  Mention
6738         changes to the output of commands and events that deal with
6739         multi-location breakpoints.
6740         * breakpoint.c: Include "mi/mi-out.h".
6741         (print_one_breakpoint): Change output syntax if using MI version
6742         >= 3.
6743         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6744         New.
6745         (mi_multi_location_breakpoint_output_fixed): New.
6746         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6747         (mi_cmd_fix_multi_location_breakpoint_output): New.
6748         (mi_multi_location_breakpoint_output_fixed): New.
6749         * mi/mi-cmds.c (mi_cmds): Register command
6750         -fix-multi-location-breakpoint-output.
6751         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6752         interpreter "mi".
6753
6754 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6755
6756         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6757         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6758         instantiate mi_ui_out based on interpreter name.
6759         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6760         * mi/mi-main.c (mi_load_progress): Likewise.
6761
6762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6763
6764         * NEWS: Combine separate "New targets" sections for 8.3.
6765
6766 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6767
6768         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6769         (ppcfbsd_init_abi): Install gdbarch
6770         "fetch_tls_load_module_address" and "get_thread_local_address"
6771         methods.
6772
6773 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6774
6775         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6776         (riscv_fbsd_init_abi): Install gdbarch
6777         "fetch_tls_load_module_address" and "get_thread_local_address"
6778         methods.
6779
6780 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6781
6782         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6783         (i386fbsd_init_abi): Install gdbarch
6784         "fetch_tls_load_module_address" and "get_thread_local_address"
6785         methods.
6786
6787 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6788
6789         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6790         (amd64fbsd_init_abi): Install gdbarch
6791         "fetch_tls_load_module_address" and "get_thread_local_address"
6792         methods.
6793
6794 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6795
6796         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6797         (struct fbsd_pspace_data): New type.
6798         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6799         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6800         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6801         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6802         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6803
6804 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6805
6806         * gdbtypes.c (lookup_struct_elt): New function.
6807         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6808         * gdbtypes.h (struct struct_elt): New type.
6809         (lookup_struct_elt): New prototype.
6810
6811 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6812
6813         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6814         remove disabled code block.
6815
6816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6817
6818         * gdbarch.sh (get_thread_local_address): New method.
6819         * gdbarch.h, gdbarch.c: Regenerate.
6820         * target.c (target_translate_tls_address): Use
6821         gdbarch_get_thread_local_address if present instead of
6822         target::get_thread_local_address.
6823
6824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6825
6826         * target.h (target::get_thread_local_address): Update comment.
6827
6828 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6829
6830         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6831         objfile->separate_debug_objfile_backlink if not NULL.
6832
6833 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6834
6835         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6836         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6837         (amd64bsd_store_inferior_registers): Likewise.
6838         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6839         Enable segment base registers.
6840         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6841         PT_GETFSBASE and PT_GETGSBASE.
6842         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6843         PT_SETGSBASE.
6844         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6845         segment base registers.
6846         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6847
6848 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6849
6850         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6851         Update calls to i386_target_description to add 'segments'
6852         parameter.
6853         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6854         add segment base registers.
6855         * arch/i386.c (i386_create_target_description): Add 'segments'
6856         parameter to enable segment base registers.
6857         * arch/i386.h (i386_create_target_description): Likewise.
6858         * features/i386/32bit-segments.xml: New file.
6859         * features/i386/32bit-segments.c: Generate.
6860         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6861         call to i386_target_description to add 'segments' parameter.
6862         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6863         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6864         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6865         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6866         if feature is present.
6867         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6868         Add 'segments' parameter to call to i386_target_description.
6869         (i386_target_description): Add 'segments' parameter to enable
6870         segment base registers.
6871         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6872         to call to i386_target_description.
6873         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6874         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6875         Define I386_NUM_REGS.
6876         (i386_target_description): Add 'segments' parameter to enable
6877         segment base registers.
6878
6879 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6880
6881         PR/24325
6882         * source-cache.c: #undef open and close, to avoid unresolved
6883         externals during linking.
6884
6885 2019-03-12  Tom Tromey  <tromey@adacore.com>
6886
6887         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6888         const.  Add initializers.
6889         (_initialize_remote): Don't initialize ptid globals.
6890
6891 2019-03-12  Pedro Alves  <palves@redhat.com>
6892
6893         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6894
6895 2019-03-12  Pedro Alves  <palves@redhat.com>
6896
6897         * cp-name-parser.y (main): Remove unused 'len' variable.
6898
6899 2019-03-12  Tom Tromey  <tromey@adacore.com>
6900
6901         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6902         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6903
6904 2019-03-12  Tom Tromey  <tromey@adacore.com>
6905
6906         * linux-nat.c (iterate_over_lwps): Update.
6907         (stop_callback): Remove parameter.
6908         (stop_wait_callback, detach_callback, resume_set_callback)
6909         (select_singlestep_lwp_callback, set_ignore_sigint)
6910         (status_callback, resumed_callback, resume_clear_callback)
6911         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6912         data parameter.
6913         (linux_nat_target::detach, linux_nat_target::resume)
6914         (linux_stop_and_wait_all_lwps, select_event_lwp)
6915         (linux_nat_filter_event, linux_nat_wait_1)
6916         (linux_nat_target::kill, linux_nat_target::stop)
6917         (linux_nat_target::stop): Update.
6918         (linux_nat_resume_callback): Change type.
6919         (resume_stopped_resumed_lwps, count_events_callback)
6920         (select_event_lwp_callback): Likewise.
6921         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6922         * arm-linux-nat.c (struct update_registers_data): Remove.
6923         (update_registers_callback): Change type.
6924         (arm_linux_insert_hw_breakpoint1): Update.
6925         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6926         parameter.
6927         (x86_linux_dr_set_addr): Update.
6928         (x86_linux_dr_set_control): Update.
6929         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6930         (iterate_over_lwps): Use gdb::function_view.
6931         * nat/aarch64-linux-hw-point.c (struct
6932         aarch64_dr_update_callback_param): Remove.
6933         (debug_reg_change_callback): Change type.
6934         (aarch64_notify_debug_reg_change): Update.
6935         * s390-linux-nat.c (s390_refresh_per_info): Update.
6936
6937 2019-03-11  Tom Tromey  <tromey@adacore.com>
6938
6939         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6940         redundant assignment to "this_cu".
6941
6942 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6943
6944         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6945
6946 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6947
6948         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6949         from...
6950         (rank_one_type): ... this.
6951
6952 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6953
6954         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6955         from...
6956         (rank_one_type): ... this.
6957
6958 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6959
6960         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6961         from...
6962         (rank_one_type): ... this.
6963
6964 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6965
6966         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6967         from...
6968         (rank_one_type): ... this.
6969
6970 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6971
6972         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6973         from...
6974         (rank_one_type): ... this.
6975
6976 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6977
6978         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6979         from...
6980         (rank_one_type): ... this.
6981
6982 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6983
6984         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6985         from...
6986         (rank_one_type): ... this.
6987
6988 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6989
6990         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6991         from...
6992         (rank_one_type): ... this.
6993
6994 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6995
6996         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6997         from...
6998         (rank_one_type): ... this.
6999
7000 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7001
7002         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7003         from...
7004         (rank_one_type): ... this.
7005
7006 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7007
7008         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7009         from...
7010         (rank_one_type): ... this.
7011
7012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7013
7014         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7015         from...
7016         (rank_one_type): ... this.
7017
7018 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7019
7020         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7021         inferior-events' shows the example events.
7022
7023 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7024
7025         Support styling on native MS-Windows console
7026
7027         PR/24315
7028         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7029         on MS-Windows if $TERM is not defined.
7030
7031         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7032
7033         * posix-hdep.c (gdb_console_fputs):
7034         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7035         functions.
7036         * ui-file.h (gdb_console_fputs): Add prototype.
7037
7038         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7039         back to fputs only if the former returns zero.
7040
7041 2019-03-07  Tom Tromey  <tom@tromey.com>
7042
7043         * symmisc.c (print_symbol_bcache_statistics): Update.
7044         (print_objfile_statistics): Update.
7045         * symfile.c (allocate_symtab): Update.
7046         * stabsread.c: Don't include bcache.h.
7047         * psymtab.h (struct psymbol_bcache): Don't declare.
7048         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7049         (psymbol_bcache_init, psymbol_bcache_free)
7050         (psymbol_bcache_get_bcache): Don't declare.
7051         * psymtab.c (struct psymbol_bcache): Remove.
7052         (psymtab_storage::psymtab_storage): Update.
7053         (psymtab_storage::~psymtab_storage): Update.
7054         (psymbol_bcache_init, psymbol_bcache_free)
7055         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7056         (add_psymbol_to_bcache): Update.
7057         (allocate_psymtab): Update.
7058         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7059         macro_cache>: No longer pointers.
7060         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7061         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7062         * macrotab.c (macro_bcache): Update.
7063         * macroexp.c: Don't include bcache.h.
7064         * gdbtypes.c (check_types_worklist): Update.
7065         (types_deeply_equal): Remove TRY/CATCH.  Update.
7066         * elfread.c (elf_symtab_read): Update.
7067         * dwarf2read.c: Don't include bcache.h.
7068         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7069         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7070         (print_bcache_statistics, bcache_memory_used): Don't declare.
7071         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7072         methods.  Rename all data members.
7073         * bcache.c (struct bcache): Move to bcache.h.
7074         (bcache::expand_hash_table): Rename from expand_hash_table.
7075         (bcache): Remove.
7076         (bcache::insert): Rename from bcache_full.
7077         (bcache::compare): Rename from bcache_compare.
7078         (bcache_xmalloc): Remove.
7079         (bcache::~bcache): Rename from bcache_xfree.
7080         (bcache::print_statistics): Rename from print_bcache_statistics.
7081         (bcache::memory_used): Rename from bcache_memory_used.
7082
7083 2019-03-07  Pedro Alves  <palves@redhat.com>
7084
7085         * infrun.c (normal_stop): Also check for
7086         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7087
7088 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7089
7090         * f-lang.c (value_from_host_double): Moved to...
7091         * value.c (value_from_host_double): ...here.
7092         * value.h (value_from_host_double): Declare.
7093         * guile/scm-math.c (vlscm_convert_typed_number): Use
7094         value_from_host_double.
7095         (vlscm_convert_number): Likewise.
7096         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7097         * python/py-value.c (convert_value_from_python): Likewise.
7098
7099 2019-03-06  Tom Tromey  <tom@tromey.com>
7100
7101         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7102
7103 2019-03-06  Tom Tromey  <tom@tromey.com>
7104
7105         * utils.h (free_current_contents): Don't declare.
7106         * utils.c (free_current_contents): Remove.
7107
7108 2019-03-06  Tom Tromey  <tom@tromey.com>
7109
7110         * top.c (quit_force): Update.
7111         * main.c (captured_command_loop): Update.
7112         * common/new-op.c (operator new): Update.
7113         * common/common-exceptions.c (struct catcher)
7114         <save_cleanup_chain>: Remove member.
7115         (exceptions_state_mc_init): Update.
7116         (exception_try_scope_entry): Return nullptr.
7117         (exception_try_scope_exit, exception_rethrow)
7118         (throw_exception_sjlj, throw_exception_cxx): Update.
7119         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7120         (all_cleanups, do_cleanups, discard_cleanups)
7121         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7122         (restore_cleanups, restore_final_cleanups): Don't declare.
7123         (do_final_cleanups): Remove parameter.
7124         * common/cleanups.c (cleanup_chain, make_cleanup)
7125         (make_cleanup_dtor, all_cleanups, do_cleanups)
7126         (discard_my_cleanups, discard_cleanups)
7127         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7128         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7129         (null_cleanup): Remove.
7130         (do_final_cleanups): Remove parameter.
7131
7132 2019-03-06  Tom Tromey  <tom@tromey.com>
7133
7134         * remote.c (remote_target::remote_parse_stop_reply): Use
7135         unique_xmalloc_ptr.
7136
7137 2019-03-06  Tom Tromey  <tom@tromey.com>
7138
7139         * stabsread.c (struct stabs_field_info): Rename from field_info.
7140         <list, fnlist>: Add initializers.
7141         <obstack>: New member.
7142         (read_member_functions, read_struct_fields, read_baseclasses):
7143         Allocate on obstack.  Don't use cleanups.
7144         (read_one_struct_field, read_member_functions, read_struct_fields)
7145         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7146         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7147         (read_struct_type): Update.
7148
7149 2019-03-06  Tom Tromey  <tom@tromey.com>
7150
7151         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7152         * common/filestuff.h (make_cleanup_close): Don't declare.
7153         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7154         Remove.
7155
7156 2019-03-06  Tom Tromey  <tom@tromey.com>
7157
7158         * solib-aix.c: Use make_scope_exit.
7159
7160 2019-03-06  Tom Tromey  <tom@tromey.com>
7161
7162         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7163         Use make_scope_exit.
7164
7165 2019-03-06  Tom Tromey  <tom@tromey.com>
7166
7167         * solib-svr4.c (disable_probes_interface): Remove parameter.
7168         (svr4_handle_solib_event): Use make_scope_exit.
7169
7170 2019-03-06  Tom Tromey  <tom@tromey.com>
7171
7172         * remote.c (struct stop_reply_deleter): Remove.
7173         (stop_reply_up): Update.
7174         (struct stop_reply): Derive from notif_event.  Don't typedef.
7175         <regcache>: Now a std::vector.
7176         (stop_reply_xfree): Remove.
7177         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7178         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7179         (remote_target::discard_pending_stop_replies): Use delete.
7180         (remote_target::remote_parse_stop_reply): Update.
7181         (remote_target::process_stop_reply): Update.
7182         * remote-notif.h (struct notif_event): Add virtual destructor.
7183         Remove "dtr" member.
7184         (struct notif_client) <alloc_event>: Return a unique_ptr.
7185         (notif_event_xfree): Don't declare.
7186         (notif_event_up): New typedef.
7187         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7188         (notif_event_xfree, do_notif_event_xfree): Remove.
7189         (remote_notif_state_xfree): Update.
7190
7191 2019-03-06  Tom Tromey  <tom@tromey.com>
7192
7193         * infrun.c (displaced_step_clear_cleanup): Now a
7194         forward_scope_exit type.
7195         (displaced_step_prepare_throw): Update.
7196         (displaced_step_fixup): Update.
7197
7198 2019-03-06  Tom Tromey  <tom@tromey.com>
7199
7200         * inferior.h (class inferior): Update comment.
7201         * gdbthread.h (class thread_info): Update comment.
7202
7203 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7204             Tom Tromey  <tom@tromey.com>
7205
7206         * stabsread.h (struct stab_section_list): Remove.
7207         (coffstab_build_psymtabs): Update.
7208         * dbxread.c (symbuf_sections): Now a std::vector.
7209         (sect_idx): New global.
7210         (fill_symbuf): Update.
7211         (coffstab_build_psymtabs): Change type of stabsects parameter.
7212         Update.
7213         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7214         std::vector.
7215         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7216         (coff_locate_sections): Update.
7217         (coff_symfile_read): Remove cleanups.  Update.
7218         (init_stringtab): Add storage parameter.
7219         (free_stringtab, free_stringtab_cleanup): Remove.
7220         (init_lineno): Add storage parameter.
7221         (free_linetab, free_linetab_cleanup): Remove.
7222
7223 2019-03-06  Pedro Alves  <palves@redhat.com>
7224
7225         * linux-fork.c (fork_info::clobber_regs): Delete.
7226         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7227         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7228         comment.  Adjust.
7229         (scoped_switch_fork_info::scoped_switch_fork_info)
7230         (checkpoint_command, linux_fork_context): Adjust
7231         fork_save_infrun_state calls.
7232
7233 2019-03-06  Pedro Alves  <palves@redhat.com>
7234
7235         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7236         (inf_has_multiple_threads): Return 'bool' and rewrite using
7237         inferior_info::threads().
7238
7239 2019-03-06  Pedro Alves  <palves@redhat.com>
7240
7241         * linux-fork.c: Include <list>.
7242         (fork_list): Now a std::list instance.
7243         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7244         (forks_exist_p, find_last_fork): Adjust.
7245         (new_fork): Delete.
7246         (one_fork_p): New.
7247         (add_fork): Adjust.
7248         (free_fork): Delete, folded into fork_info::~fork_info().
7249         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7250         Adjust.
7251         (init_fork_list): Delete.
7252         (linux_fork_killall, linux_fork_mourn_inferior)
7253         (linux_fork_detach, info_checkpoints_command): Adjust.
7254         (_initialize_linux_fork): No longer call init_fork_list.
7255
7256 2019-03-06  Pedro Alves  <palves@redhat.com>
7257
7258         * linux-fork.c (new_fork): New, split out of ...
7259         (add_fork): ... this.  Return void.  Move "first fork" special
7260         case from here, to ...
7261         (checkpoint_command): ... here.
7262         * linux-linux.h (add_fork): Return void.
7263
7264 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7265
7266         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7267
7268 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7269             Chris January  <chris.january@arm.com>
7270             David Lecomber  <david.lecomber@arm.com>
7271
7272         * f-exp.y: New token, UNOP_INTRINSIC.
7273         (exp): New pattern using UNOP_INTRINSIC token.
7274         (f77_keywords): Add 'abs' keyword.
7275         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7276         (value_from_host_double): New function.
7277         (evaluate_subexp_f): Support UNOP_ABS.
7278
7279 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7280
7281         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7282         types.
7283
7284 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7285
7286         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7287         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7288         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7289
7290 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7291
7292         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7293
7294 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7295             Chris January  <chris.january@arm.com>
7296
7297         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7298         * f-exp.y: Define 'KIND' token.
7299         (exp): New pattern for KIND expressions.
7300         (ptype): Handle types with a kind extension.
7301         (direct_abs_decl): Extend to spot kind extensions.
7302         (f77_keywords): Add 'kind' to the list.
7303         (push_kind_type): New function.
7304         (convert_to_kind_type): New function.
7305         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7306         * parse.c (operator_length_standard): Likewise.
7307         * parser-defs.h (enum type_pieces): Add tp_kind.
7308         * std-operator.def: Add UNOP_KIND.
7309
7310 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7311
7312         * f-exp.y (f_parse): Set yydebug.
7313
7314 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7315
7316         * f-lang.c (evaluate_subexp_f): New function.
7317         (exp_descriptor_f): New global.
7318         (f_language_defn): Use exp_descriptor_f instead of
7319         exp_descriptor_standard.
7320
7321 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7322
7323         * f-exp.y (struct token): Add comments.
7324         (dot_ops): Remove uppercase versions and the end marker.
7325         (f77_keywords): Likewise.
7326         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7327         entries in the dot_ops array are case insensitive, and use
7328         strncasecmp to compare strings.  Also some whitespace cleanup in
7329         this area.  Similar for the f77_keywords array, except entries in
7330         this list might be case sensitive.
7331
7332 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7333
7334         * f-exp.y (struct f77_boolean_val): Add comments.
7335         (boolean_values): Remove uppercase versions, and end marker.
7336         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7337         and use strncasecmp to achieve case insensitivity.  Additionally,
7338         perform whitespace cleanup around this code.
7339
7340 2019-03-06  Tom Tromey  <tromey@adacore.com>
7341
7342         * remote-sim.c (gdbsim_target_open): Use result of
7343         gdb_argv::release.
7344
7345 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7346         Dirk Schubert  <dirk.schubert@arm.com>
7347         Chris January  <chris.january@arm.com>
7348
7349         * eval.c (evaluate_subexp_standard): Call Fortran argument
7350         wrapping logic.
7351         * f-lang.c (struct value): A value which can be passed into a
7352         Fortran function call.
7353         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7354         where appropriate.
7355         (struct type): Value ready for a Fortran function call.
7356         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7357         is needed.
7358         * f-lang.h (fortran_argument_convert): Declaration.
7359         (fortran_preserve_arg_pointer): Declaration.
7360         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7361
7362 2019-03-05  Tom Tromey  <tromey@adacore.com>
7363
7364         * python/py-prettyprint.c (print_string_repr): Remove #if.
7365         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7366
7367 2019-03-05  Tom Tromey  <tromey@adacore.com>
7368
7369         * target.c (the_dummy_target): Move later.  Change type to
7370         "dummy_target".
7371         (initialize_targets): Don't initialize the_dummy_target.
7372
7373 2019-03-05  Tom Tromey  <tromey@adacore.com>
7374
7375         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7376         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7377
7378 2019-03-05  Tom Tromey  <tromey@adacore.com>
7379
7380         * windows-nat.c (windows_nat_target::attach)
7381         (windows_nat_target::detach): Don't call gdb_flush.
7382         * valprint.c (generic_val_print, val_print, val_print_string):
7383         Don't call gdb_flush.
7384         * utils.c (defaulted_query): Don't call gdb_flush.
7385         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7386         * target.c (target_announce_detach): Don't call gdb_flush.
7387         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7388         * remote.c (extended_remote_target::attach): Don't call
7389         gdb_flush.
7390         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7391         * printcmd.c (do_examine): Don't call gdb_flush.
7392         (info_display_command): Don't call gdb_flush.
7393         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7394         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7395         * memattr.c (info_mem_command): Don't call gdb_flush.
7396         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7397         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7398         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7399         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7400         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7401         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7402         (gnu_nat_target::detach): Don't call gdb_flush.
7403         * f-valprint.c (f_val_print): Don't call gdb_flush.
7404         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7405         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7406         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7407         gdb_flush.
7408         * c-valprint.c (c_val_print): Don't call gdb_flush.
7409         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7410
7411 2019-03-05  Tom Tromey  <tromey@adacore.com>
7412
7413         * varobj.c (update_dynamic_varobj_children): Update.
7414         (install_default_visualizer): Use reset, not release.
7415         * value.c (set_internalvar): Update.
7416         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7417         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7418         ATTRIBUTE_UNUSED_RESULT.
7419
7420 2019-03-05  Tom Tromey  <tromey@adacore.com>
7421
7422         * remote.c (class scoped_remote_fd) <release>: Add
7423         ATTRIBUTE_UNUSED_RESULT.
7424
7425 2019-03-05  Tom Tromey  <tromey@adacore.com>
7426
7427         * macroexp.c (struct macro_buffer) <release>: Add
7428         ATTRIBUTE_UNUSED_RESULT.
7429
7430 2019-03-05  Tom Tromey  <tromey@adacore.com>
7431
7432         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7433         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7434         ATTRIBUTE_UNUSED_RESULT.
7435
7436 2019-03-05  Tom Tromey  <tromey@adacore.com>
7437
7438         * common/scoped_fd.h (class scoped_fd) <release>: Add
7439         ATTRIBUTE_UNUSED_RESULT.
7440
7441 2019-03-05  Tom Tromey  <tromey@adacore.com>
7442
7443         * parser-defs.h (struct parser_state) <release>: Add
7444         ATTRIBUTE_UNUSED_RESULT.
7445
7446 2019-03-05  Tom Tromey  <tromey@adacore.com>
7447
7448         * utils.h (class gdb_argv) <release>: Add
7449         ATTRIBUTE_UNUSED_RESULT.
7450         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7451
7452 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7453
7454         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7455         for-loop range, to avoid compiler warnings.
7456
7457         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7458         avoid compiler warnings about unused variables.
7459
7460         * NEWS: Mention end of support for native debugging on MS-Windows
7461         before XP.
7462
7463         PR gdb/24292
7464         * common/netstuff.c:
7465         * gdbserver/gdbreplay.c
7466         * gdbserver/remote-utils.c:
7467         * ser-tcp.c:
7468         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7469         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7470         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7471         'getaddrinfo' and 'freeaddrinfo' were not available before
7472         Windows XP, and mingw.org's MinGW headers by default define
7473         _WIN32_WINNT to 0x500.
7474
7475 2019-03-01  Gary Benson <gbenson@redhat.com>
7476
7477         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7478
7479 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7480             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7481
7482         PR gdb/8527
7483         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7484         set_sigint_trap, clear_sigint_trap.
7485
7486 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7487
7488         * target.c (target_detach): Clear the regcache and the
7489         frame cache.
7490
7491 2019-02-27  Pedro Alves  <palves@redhat.com>
7492
7493         * utils.c (set_screen_size): When we cap the height/width sizes,
7494         tweak the corresponding command variable to show "unlimited":
7495
7496 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7497             Pedro Alves  <palves@redhat.com>
7498
7499         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7500         before calling rl_set_screen_size.
7501
7502 2019-02-27  Tom Tromey  <tromey@adacore.com>
7503
7504         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7505         define.
7506         * python/py-value.c: Remove Python 2.4 workaround.
7507         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7508         workaround.
7509         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7510         Python 2.4 workaround.
7511         * python/python-internal.h: Remove Python 2.4 comment.
7512         (Py_ssize_t): Don't define.
7513         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7514         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7515         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7516         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7517         * python/python.c (do_start_initialization): Remove Python 2.4
7518         workaround.
7519         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7520         (print_children): Remove Python 2.4 workaround.
7521         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7522         workaround.
7523         (CHARBUFFERPROC_NAME): Remove.
7524         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7525         Python 2.4 workaround.
7526
7527 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7528
7529         * NEWS: Note minimum Python version.
7530
7531 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7532
7533         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7534         code from these functions.  Remove corresponding ifdefs.  Use
7535         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7536         Remove gotos and target of gotos.
7537         (infpy_search_memory): Likewise.
7538
7539 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7540
7541         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7542         (hppa_gdbarch_init): Don't register deleted functions with
7543         gdbarch.
7544
7545 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7546
7547         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7548         (h8300_unwind_sp): Delete.
7549         (h8300_dummy_id): Delete.
7550         (h8300_gdbarch_init): Don't register deleted functions with
7551         gdbarch.
7552
7553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7554
7555         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7556         (ft32_unwind_pc): Delete.
7557         (ft32_unwind_sp): Delete.
7558         (ft32_gdbarch_init): Don't register deleted functions with
7559         gdbarch.
7560
7561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7562
7563         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7564         (frv_unwind_pc): Delete.
7565         (frv_unwind_sp): Delete.
7566         (frv_gdbarch_init): Don't register deleted functions with
7567         gdbarch.
7568
7569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7570
7571         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7572         (riscv_unwind_pc): Delete.
7573         (riscv_unwind_sp): Delete.
7574         (riscv_gdbarch_init): Don't register deleted functions with
7575         gdbarch.
7576
7577 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7578
7579         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7580         (csky_unwind_pc): Delete.
7581         (csky_unwind_sp): Delete.
7582         (csky_gdbarch_init): Don't register deleted functions with
7583         gdbarch.
7584
7585 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7586
7587         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7588         (cris_unwind_pc): Delete.
7589         (cris_unwind_sp): Delete.
7590         (cris_gdbarch_init): Don't register deleted functions with
7591         gdbarch.
7592
7593 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7594
7595         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7596         (bfin_unwind_pc): Delete.
7597         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7598
7599 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7600
7601         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7602         (arm_unwind_pc): Delete.
7603         (arm_unwind_sp): Delete.
7604         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7605
7606 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7607
7608         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7609         (arc_unwind_pc): Delete.
7610         (arc_unwind_sp): Delete.
7611         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7612
7613 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7614
7615         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7616         (alpha_unwind_pc): Delete.
7617         (alpha_gdbarch_init): Don't register deleted functions with
7618         gdbarch.
7619
7620 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7621
7622         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7623         (aarch64_unwind_pc): Delete.
7624         (aarch64_unwind_sp): Delete.
7625         (aarch64_gdbarch_init): Don't register deleted functions with
7626         gdbarch.
7627
7628 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7629
7630         * gdbtypes.c (type_align): Don't consider static members when
7631         computing structure alignment.
7632
7633 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7634
7635         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7636         return 0 for other types.
7637         * arch-utils.c (default_type_align): Always return 0.
7638         * gdbarch.h: Regenerate.
7639         * gdbarch.sh (type_align): Extend comment.
7640         * gdbtypes.c (type_align): Add additional comments, always call
7641         gdbarch_type_align before applying the default rules.
7642         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7643         generic code will then apply a suitable default.
7644         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7645         types, return 0 for other types.
7646
7647 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7648
7649         * NEWS: Create a new section for the next release branch.
7650         Rename the section of the current branch, now that it has
7651         been cut.
7652
7653 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7654
7655         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7656         * version.in: Bump version to 8.3.50.DATE-git.
7657
7658 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7659
7660         * aix-thread.c (ptid_cmp): Remove unused variable.
7661         (get_signaled_thread): Likewise.
7662         (store_regs_user_thread): Likewise.
7663         (store_regs_kernel_thread): Likewise.
7664         (fetch_regs_kernel_thread): Remove shadowed variable.
7665
7666 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7667
7668         * features/riscv/32bit-cpu.xml: Add register numbers.
7669         * features/riscv/32bit-fpu.c: Regenerate.
7670         * features/riscv/32bit-fpu.xml: Add register numbers.
7671         * features/riscv/64bit-cpu.xml: Add register numbers.
7672         * features/riscv/64bit-fpu.c: Regenerate.
7673         * features/riscv/64bit-fpu.xml: Add register numbers.
7674
7675 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7676
7677         * NEWS: Mention two argument form of gdb.Value constructor.
7678         * python/py-value.c (convert_buffer_and_type_to_value): New
7679         function.
7680         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7681         Add support for handling an optional second argument.  Call
7682         convert_buffer_and_type_to_value as appropriate.
7683         * python/python-internal.h (Py_buffer_deleter): New struct.
7684         (Py_buffer_up): New typedef.
7685
7686 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7687
7688         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7689         instead of releasing ownership.
7690
7691 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7692
7693         * dwarf2read.c (open_and_init_dwp_file): Call
7694         elf_numsections instead of bfd_count_sections to initialize
7695         dwp_file->num_sections.
7696
7697 2019-02-25  Tom Tromey  <tromey@adacore.com>
7698
7699         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7700
7701 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7702
7703         * gcore.in: Add '--readnever' option when invoking GDB.
7704
7705 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7706
7707         * MAINTAINERS: Update my email address.
7708
7709 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7710
7711         * build-id.c (build_id_to_debug_bfd_1): New function.
7712         (build_id_to_debug_bfd): Look for separate debug file in
7713         sysroot.
7714
7715 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7716
7717         * gdbarch.sh: Update the copyright year range that is placed into
7718         generated files.
7719
7720 2019-02-22  Keith Seitz  <keiths@redhat.com>
7721
7722         PR symtab/23853
7723         * linespec.c (create_sals_line_offset): Search for the default
7724         symtab's filename instead of its fullname.
7725
7726 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7727
7728         * NEWS: Update style defaults.
7729
7730 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7731
7732         * main.c (captured_main_1): Disable styling in batch mode.
7733
7734 2019-02-20  Tom Tromey  <tom@tromey.com>
7735
7736         * symtab.c (symtab_symbol_info): Fix typos.
7737
7738 2019-02-20  Tom Tromey  <tromey@adacore.com>
7739
7740         * findcmd.c (_initialize_mem_search): Use upper case for
7741         metasyntactic variables.
7742
7743 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7744
7745         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7746         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7747
7748 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7749
7750         * top.h (source_file_name): Change to std::string.
7751         * top.c (source_file_name): Likewise.
7752         (command_line_input): Adjust.
7753         * cli/cli-script.c (script_from_file): Adjust.
7754
7755 2019-02-19  Tom Tromey  <tromey@adacore.com>
7756
7757         * ravenscar-thread.c
7758         (ravenscar_thread_target::update_thread_list): Don't call
7759         ada_build_task_list.
7760         * ada-lang.h (ada_build_task_list): Don't declare.
7761         * ada-tasks.c (struct ada_tasks_inferior_data)
7762         <task_list_valid_p>: Now bool.
7763         (read_known_tasks, ada_task_list_changed)
7764         (ada_tasks_invalidate_inferior_data): Update.
7765         (read_known_tasks_array): Return bool.
7766         (read_known_tasks_list): Likewise.
7767         (read_known_tasks): Return void.
7768         (ada_build_task_list): Now static.
7769
7770 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7771
7772         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7773         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7774
7775 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7776
7777         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7778         variant for ada_tasks_pspace_data_handle and
7779         ada_tasks_inferior_data_handle.
7780         (ada_tasks_pspace_data_cleanup): New function.
7781         (ada_tasks_inferior_data_cleanup): New function.
7782
7783 2019-02-17  Tom Tromey  <tom@tromey.com>
7784
7785         * macrotab.h (macro_source_fullname): Return a std::string.
7786         * macrotab.c (macro_include, check_for_redefinition)
7787         (macro_undef, macro_lookup_definition, foreach_macro)
7788         (foreach_macro_in_scope): Update.
7789         (macro_source_fullname): Return a std::string.
7790         * macrocmd.c (show_pp_source_pos): Update.
7791
7792 2019-02-17  Tom Tromey  <tom@tromey.com>
7793
7794         * macrocmd.c (show_pp_source_pos): Style the file names.
7795
7796 2019-02-17  Tom Tromey  <tom@tromey.com>
7797
7798         PR tui/24197:
7799         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7800
7801 2019-02-17  Tom Tromey  <tom@tromey.com>
7802
7803         * ada-lang.c (user_select_syms): Use filtered printing.
7804         * utils.c (wrap_style): New global.
7805         (desired_style): Remove.
7806         (emit_style_escape): Add stream parameter.
7807         (set_output_style, reset_terminal_style, prompt_for_continue):
7808         Update.
7809         (flush_wrap_buffer): Only flush gdb_stdout.
7810         (wrap_here): Set wrap_style.
7811         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7812         treat escape sequences as a character.  Change when wrap buffer is
7813         flushed.
7814         (fputs_styled): Do not set the output style when the default is
7815         requested.
7816         * ui-style.h (struct ui_file_style) <is_default>: New method.
7817         * source.c (print_source_lines_base): Emit escape sequences in one
7818         piece.
7819
7820 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7821
7822         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7823         integers and enumeration types.
7824
7825 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7826
7827         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7828         instead of lookup_symbol_in_language
7829         (do_exact_match): New function.
7830         (ada_get_symbol_name_matcher): Return do_exact_match when
7831         doing a verbatim match.
7832
7833 2019-02-15  Tom Tromey  <tromey@adacore.com>
7834
7835         * ravenscar-thread.c (ravenscar_thread_target::resume)
7836         (ravenscar_thread_target::wait): Special case wildcard requests.
7837
7838 2019-02-15  Tom Tromey  <tromey@adacore.com>
7839
7840         * ravenscar-thread.c (base_ptid): Remove.
7841         (struct ravenscar_thread_target) <close>: New method.
7842         <m_base_ptid>: New member.
7843         <update_inferior_ptid, active_task, task_is_currently_active,
7844         runtime_initialized>: Declare methods.
7845         <ravenscar_thread_target>: Add constructor.
7846         (ravenscar_thread_target::task_is_currently_active)
7847         (ravenscar_thread_target::update_inferior_ptid)
7848         (ravenscar_runtime_initialized): Rename.  Now methods.
7849         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7850         (ravenscar_thread_target::update_thread_list): Update.
7851         (ravenscar_thread_target::active_task): Now method.
7852         (ravenscar_thread_target::store_registers)
7853         (ravenscar_thread_target::prepare_to_store)
7854         (ravenscar_thread_target::prepare_to_store)
7855         (ravenscar_thread_target::mourn_inferior): Update.
7856         (ravenscar_inferior_created): Use "new" to create target.
7857         (ravenscar_thread_target::get_ada_task_ptid): Update.
7858         (_initialize_ravenscar): Don't initialize base_ptid.
7859         (ravenscar_ops): Remove global.
7860
7861 2019-02-15  Tom Tromey  <tromey@adacore.com>
7862
7863         * target.h (push_target): Declare new overload.
7864         * target.c (push_target): New overload, taking an rvalue reference.
7865         * remote.c (remote_target::open_1): Use push_target overload.
7866         * corelow.c (core_target_open): Use push_target overload.
7867
7868 2019-02-15  Tom Tromey  <tromey@adacore.com>
7869
7870         * ravenscar-thread.c (is_ravenscar_task)
7871         (ravenscar_task_is_currently_active): Return bool.
7872         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7873         (_initialize_ravenscar): Remove "(void)".
7874         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7875         Return bool.
7876
7877 2019-02-15  Tom Tromey  <tromey@adacore.com>
7878
7879         * ravenscar-thread.c (ravenscar_runtime_initializer)
7880         (has_ravenscar_runtime, get_running_thread_id)
7881         (ravenscar_thread_target::resume): Fix indentation.
7882
7883 2019-02-15  Tom Tromey  <tromey@adacore.com>
7884
7885         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7886         from ravenscar_arch_ops.
7887         (sparc_ravenscar_ops::fetch_registers)
7888         (sparc_ravenscar_ops::store_registers): Now methods.
7889         (sparc_ravenscar_prepare_to_store): Remove.
7890         (sparc_ravenscar_ops): Redefine.
7891         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7892         methods and destructor.  Remove members.
7893         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7894         (ravenscar_thread_target::store_registers)
7895         (ravenscar_thread_target::prepare_to_store): Update.
7896         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7897         Remove.
7898         (struct ppc_ravenscar_powerpc_ops): Derive from
7899         ravenscar_arch_ops.
7900         (ppc_ravenscar_powerpc_ops::fetch_registers)
7901         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7902         (ppc_ravenscar_powerpc_ops): Redefine.
7903         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7904         (ppc_ravenscar_e500_ops::fetch_registers)
7905         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7906         (ppc_ravenscar_e500_ops): Redefine.
7907         * aarch64-ravenscar-thread.c
7908         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7909         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7910         (aarch64_ravenscar_fetch_registers)
7911         (aarch64_ravenscar_store_registers): Now methods.
7912         (aarch64_ravenscar_ops): Redefine.
7913
7914 2019-02-15  Tom Tromey  <tromey@adacore.com>
7915
7916         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7917         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7918         (ravenscar_thread_target::stopped_by_watchpoint)
7919         (ravenscar_thread_target::stopped_data_address)
7920         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7921
7922 2019-02-15  Tom Tromey  <tromey@adacore.com>
7923
7924         * ravenscar-thread.c: Fix some typos.
7925
7926 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7927             Tom Tromey  <tromey@adacore.com>
7928
7929         * ada-lang.c (ada_exception_sal): Change addr_string to a
7930         std::string.
7931         (create_ada_exception_catchpoint): Update.
7932
7933 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7934             Tom Tromey  <tromey@adacore.com>
7935
7936         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7937         (bp_location_ops): Remove.
7938         (base_breakpoint_allocate_location): Update.
7939         (free_bp_location): Update.
7940         * ada-lang.c (class ada_catchpoint_location)
7941         <ada_catchpoint_location>: Remove ops parameter.
7942         (ada_catchpoint_location_dtor): Remove.
7943         (ada_catchpoint_location_ops): Remove.
7944         (allocate_location_exception): Update.
7945         * breakpoint.h (struct bp_location_ops): Remove.
7946         (class bp_location) <bp_location>: Remove bp_location_ops
7947         parameter.
7948         <~bp_location>: Add destructor.
7949         <ops>: Remove.
7950
7951 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7952             Pedro Alves  <palves@redhat.com>
7953
7954         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7955         'PATH_MAX'.
7956
7957 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7958             Samuel Thibault  <samuel.thibault@gnu.org>
7959             Thomas Schwinge  <thomas@codesourcery.com>
7960
7961         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7962         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7963
7964 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7965
7966         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7967         (check_empty): Use "const char *".
7968
7969         * gnu-nat.c (gnu_nat_target::detach): Instead of
7970         'detach_inferior (pid)' call
7971         'detach_inferior (find_inferior_pid (pid))'.
7972
7973         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7974         'nat/fork-inferior.o'.
7975         * gnu-nat.c: #include "nat/fork-inferior.h".
7976
7977         * gnu-nat.c (gnu_nat_target::detach): Instead of
7978         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7979         * gnu-nat.h: #include "inf-child.h".
7980         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7981         'i386_gnu_nat_target::fetch_registers'.
7982         (gnu_store_registers): Rename/move to
7983         'i386_gnu_nat_target::store_registers'.
7984
7985         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7986         * gnu-nat.h (mach_thread_info): New function.
7987         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7988
7989         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7990
7991 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7992
7993         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7994
7995 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7996
7997         * windows-nat.c (windows_add_thread): Add new parameter
7998         "main_thread_p" with default value set to false.  Update
7999         function documentation as well as all callers.
8000         (windows_delete_thread): Likewise.
8001         (fake_create_process): Update call to windows_add_thread.
8002         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8003         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8004         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8005         call to windows_delete_thread.
8006
8007 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8008
8009         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8010
8011 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8012
8013         * symfile.c (find_separate_debug_file): Use canonical path of
8014         sysroot with child_path instead of gdb_sysroot if it is valid.
8015
8016 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8017
8018         * symfile.c (find_separate_debug_file): Use child_path to
8019         determine if an object file is under a sysroot.
8020
8021 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8022
8023         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8024         unittests/child-path-selftests.c.
8025         * common/pathstuff.c (child_path): New function.
8026         * common/pathstuff.h (child_path): New prototype.
8027         * unittests/child-path-selftests.c: New file.
8028
8029 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8030
8031         * symfile.c (find_separate_debug_file): Look for separate debug
8032         files in debug directories under the sysroot.
8033
8034 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8035
8036         * symtab.h (struct minimal_symbol data_p): New const method.
8037         (struct minimal_symbol text_p): Likewise.
8038         * symtab.c (output_source_filename): Use file name style
8039         to print file name.
8040         (print_symbol_info): Likewise.
8041         (print_msymbol_info): Use address style to print addresses.
8042         Use function name style to print executable text symbols.
8043         (expand_symtab_containing_pc): Use data_p.
8044         (find_pc_sect_compunit_symtab): Likewise.
8045
8046 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8047
8048         * breakpoint.c (describe_other_breakpoints): Use address style
8049         to print addresses.
8050         (say_where): Likewise.
8051
8052 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8053
8054         * ada-typeprint.c (print_func_type): Print function name
8055         style to print function name.
8056         * c-typeprint.c (c_print_type_1): Likewise.
8057
8058 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8059
8060         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8061         for execve.
8062
8063 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8064
8065         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8066         type_stack.
8067
8068 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8069
8070         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8071         TYPE_CODE_REF types.
8072
8073 2019-02-08  Jim Wilson  <jimw@sifive.com>
8074
8075         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8076         (riscv_linux_fregset): New.
8077         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8078
8079 2019-02-07  Tom Tromey  <tom@tromey.com>
8080
8081         * thread.c (thread_cancel_execution_command): Update.
8082         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8083         methods.
8084         (struct thread_fsm_ops): Remove.
8085         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8086         (thread_fsm_should_stop, thread_fsm_return_value)
8087         (thread_fsm_set_finished, thread_fsm_finished_p)
8088         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8089         Don't declare.
8090         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8091         * infrun.c (clear_proceed_status_thread)
8092         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8093         (print_stop_event): Update.
8094         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8095         Add constructor.
8096         (step_command_fsm_ops): Remove.
8097         (new_step_command_fsm): Remove.
8098         (step_1): Update.
8099         (step_command_fsm::should_stop): Rename from
8100         step_command_fsm_should_stop.
8101         (step_command_fsm::clean_up): Rename from
8102         step_command_fsm_clean_up.
8103         (step_command_fsm::do_async_reply_reason): Rename from
8104         step_command_fsm_async_reply_reason.
8105         (struct until_next_fsm): Inherit from thread_fsm.  Add
8106         constructor.
8107         (until_next_fsm_ops): Remove.
8108         (new_until_next_fsm): Remove.
8109         (until_next_fsm::should_stop): Rename from
8110         until_next_fsm_should_stop.
8111         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8112         (until_next_fsm::do_async_reply_reason): Rename from
8113         until_next_fsm_async_reply_reason.
8114         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8115         constructor.  Change type of breakpoint.
8116         (finish_command_fsm_ops): Remove.
8117         (new_finish_command_fsm): Remove.
8118         (finish_command_fsm::should_stop): Rename from
8119         finish_command_fsm_should_stop.
8120         (finish_command_fsm::clean_up): Rename from
8121         finish_command_fsm_clean_up.
8122         (finish_command_fsm::return_value): Rename from
8123         finish_command_fsm_return_value.
8124         (finish_command_fsm::do_async_reply_reason): Rename from
8125         finish_command_fsm_async_reply_reason.
8126         (finish_command): Update.
8127         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8128         Add constructor.
8129         (call_thread_fsm_ops): Remove.
8130         (call_thread_fsm::call_thread_fsm): Rename from
8131         new_call_thread_fsm.
8132         (call_thread_fsm::should_stop): Rename from
8133         call_thread_fsm_should_stop.
8134         (call_thread_fsm::should_notify_stop): Rename from
8135         call_thread_fsm_should_notify_stop.
8136         (run_inferior_call, call_function_by_hand_dummy): Update.
8137         * cli/cli-interp.c (should_print_stop_to_console): Update.
8138         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8139         Add constructor.  Change type of location_breakpoint,
8140         caller_breakpoint.
8141         (until_break_fsm_ops): Remove.
8142         (new_until_break_fsm): Remove.
8143         (until_break_fsm::should_stop): Rename from
8144         until_break_fsm_should_stop.
8145         (until_break_fsm::clean_up): Rename from
8146         until_break_fsm_clean_up.
8147         (until_break_fsm::do_async_reply_reason): Rename from
8148         until_break_fsm_async_reply_reason.
8149         (until_break_command): Update.
8150         * thread-fsm.c: Remove.
8151         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8152
8153 2019-02-07  Tom Tromey  <tom@tromey.com>
8154
8155         * yy-remap.h: Add include guard.
8156         * xtensa-tdep.h: Add include guard.
8157         * xcoffread.h: Rename include guard.
8158         * varobj-iter.h: Add include guard.
8159         * tui/tui.h: Rename include guard.
8160         * tui/tui-winsource.h: Rename include guard.
8161         * tui/tui-wingeneral.h: Rename include guard.
8162         * tui/tui-windata.h: Rename include guard.
8163         * tui/tui-win.h: Rename include guard.
8164         * tui/tui-stack.h: Rename include guard.
8165         * tui/tui-source.h: Rename include guard.
8166         * tui/tui-regs.h: Rename include guard.
8167         * tui/tui-out.h: Rename include guard.
8168         * tui/tui-layout.h: Rename include guard.
8169         * tui/tui-io.h: Rename include guard.
8170         * tui/tui-hooks.h: Rename include guard.
8171         * tui/tui-file.h: Rename include guard.
8172         * tui/tui-disasm.h: Rename include guard.
8173         * tui/tui-data.h: Rename include guard.
8174         * tui/tui-command.h: Rename include guard.
8175         * tic6x-tdep.h: Add include guard.
8176         * target/waitstatus.h: Rename include guard.
8177         * target/wait.h: Rename include guard.
8178         * target/target.h: Rename include guard.
8179         * target/resume.h: Rename include guard.
8180         * target-float.h: Rename include guard.
8181         * stabsread.h: Add include guard.
8182         * rs6000-tdep.h: Add include guard.
8183         * riscv-fbsd-tdep.h: Add include guard.
8184         * regformats/regdef.h: Rename include guard.
8185         * record.h: Rename include guard.
8186         * python/python.h: Rename include guard.
8187         * python/python-internal.h: Rename include guard.
8188         * python/py-stopevent.h: Rename include guard.
8189         * python/py-ref.h: Rename include guard.
8190         * python/py-record.h: Rename include guard.
8191         * python/py-record-full.h: Rename include guard.
8192         * python/py-record-btrace.h: Rename include guard.
8193         * python/py-instruction.h: Rename include guard.
8194         * python/py-events.h: Rename include guard.
8195         * python/py-event.h: Rename include guard.
8196         * procfs.h: Add include guard.
8197         * proc-utils.h: Add include guard.
8198         * p-lang.h: Add include guard.
8199         * or1k-tdep.h: Rename include guard.
8200         * observable.h: Rename include guard.
8201         * nto-tdep.h: Rename include guard.
8202         * nat/x86-linux.h: Rename include guard.
8203         * nat/x86-linux-dregs.h: Rename include guard.
8204         * nat/x86-gcc-cpuid.h: Add include guard.
8205         * nat/x86-dregs.h: Rename include guard.
8206         * nat/x86-cpuid.h: Rename include guard.
8207         * nat/ppc-linux.h: Rename include guard.
8208         * nat/mips-linux-watch.h: Rename include guard.
8209         * nat/linux-waitpid.h: Rename include guard.
8210         * nat/linux-ptrace.h: Rename include guard.
8211         * nat/linux-procfs.h: Rename include guard.
8212         * nat/linux-osdata.h: Rename include guard.
8213         * nat/linux-nat.h: Rename include guard.
8214         * nat/linux-namespaces.h: Rename include guard.
8215         * nat/linux-btrace.h: Rename include guard.
8216         * nat/glibc_thread_db.h: Rename include guard.
8217         * nat/gdb_thread_db.h: Rename include guard.
8218         * nat/gdb_ptrace.h: Rename include guard.
8219         * nat/fork-inferior.h: Rename include guard.
8220         * nat/amd64-linux-siginfo.h: Rename include guard.
8221         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8222         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8223         * nat/aarch64-linux.h: Rename include guard.
8224         * nat/aarch64-linux-hw-point.h: Rename include guard.
8225         * mn10300-tdep.h: Add include guard.
8226         * mips-linux-tdep.h: Add include guard.
8227         * mi/mi-parse.h: Rename include guard.
8228         * mi/mi-out.h: Rename include guard.
8229         * mi/mi-main.h: Rename include guard.
8230         * mi/mi-interp.h: Rename include guard.
8231         * mi/mi-getopt.h: Rename include guard.
8232         * mi/mi-console.h: Rename include guard.
8233         * mi/mi-common.h: Rename include guard.
8234         * mi/mi-cmds.h: Rename include guard.
8235         * mi/mi-cmd-break.h: Rename include guard.
8236         * m2-lang.h: Add include guard.
8237         * location.h: Rename include guard.
8238         * linux-record.h: Rename include guard.
8239         * linux-nat.h: Add include guard.
8240         * linux-fork.h: Add include guard.
8241         * i386-darwin-tdep.h: Rename include guard.
8242         * hppa-linux-offsets.h: Add include guard.
8243         * guile/guile.h: Rename include guard.
8244         * guile/guile-internal.h: Rename include guard.
8245         * gnu-nat.h: Rename include guard.
8246         * gdb-stabs.h: Rename include guard.
8247         * frv-tdep.h: Add include guard.
8248         * f-lang.h: Add include guard.
8249         * event-loop.h: Add include guard.
8250         * darwin-nat.h: Rename include guard.
8251         * cp-abi.h: Rename include guard.
8252         * config/sparc/nm-sol2.h: Rename include guard.
8253         * config/nm-nto.h: Rename include guard.
8254         * config/nm-linux.h: Add include guard.
8255         * config/i386/nm-i386gnu.h: Rename include guard.
8256         * config/djgpp/nl_types.h: Rename include guard.
8257         * config/djgpp/langinfo.h: Rename include guard.
8258         * compile/gcc-cp-plugin.h: Add include guard.
8259         * compile/gcc-c-plugin.h: Add include guard.
8260         * compile/compile.h: Rename include guard.
8261         * compile/compile-object-run.h: Rename include guard.
8262         * compile/compile-object-load.h: Rename include guard.
8263         * compile/compile-internal.h: Rename include guard.
8264         * compile/compile-cplus.h: Rename include guard.
8265         * compile/compile-c.h: Rename include guard.
8266         * common/xml-utils.h: Rename include guard.
8267         * common/x86-xstate.h: Rename include guard.
8268         * common/version.h: Rename include guard.
8269         * common/vec.h: Rename include guard.
8270         * common/tdesc.h: Rename include guard.
8271         * common/selftest.h: Rename include guard.
8272         * common/scoped_restore.h: Rename include guard.
8273         * common/scoped_mmap.h: Rename include guard.
8274         * common/scoped_fd.h: Rename include guard.
8275         * common/safe-iterator.h: Rename include guard.
8276         * common/run-time-clock.h: Rename include guard.
8277         * common/refcounted-object.h: Rename include guard.
8278         * common/queue.h: Rename include guard.
8279         * common/ptid.h: Rename include guard.
8280         * common/print-utils.h: Rename include guard.
8281         * common/preprocessor.h: Rename include guard.
8282         * common/pathstuff.h: Rename include guard.
8283         * common/observable.h: Rename include guard.
8284         * common/netstuff.h: Rename include guard.
8285         * common/job-control.h: Rename include guard.
8286         * common/host-defs.h: Rename include guard.
8287         * common/gdb_wait.h: Rename include guard.
8288         * common/gdb_vecs.h: Rename include guard.
8289         * common/gdb_unlinker.h: Rename include guard.
8290         * common/gdb_unique_ptr.h: Rename include guard.
8291         * common/gdb_tilde_expand.h: Rename include guard.
8292         * common/gdb_sys_time.h: Rename include guard.
8293         * common/gdb_string_view.h: Rename include guard.
8294         * common/gdb_splay_tree.h: Rename include guard.
8295         * common/gdb_setjmp.h: Rename include guard.
8296         * common/gdb_ref_ptr.h: Rename include guard.
8297         * common/gdb_optional.h: Rename include guard.
8298         * common/gdb_locale.h: Rename include guard.
8299         * common/gdb_assert.h: Rename include guard.
8300         * common/filtered-iterator.h: Rename include guard.
8301         * common/filestuff.h: Rename include guard.
8302         * common/fileio.h: Rename include guard.
8303         * common/environ.h: Rename include guard.
8304         * common/common-utils.h: Rename include guard.
8305         * common/common-types.h: Rename include guard.
8306         * common/common-regcache.h: Rename include guard.
8307         * common/common-inferior.h: Rename include guard.
8308         * common/common-gdbthread.h: Rename include guard.
8309         * common/common-exceptions.h: Rename include guard.
8310         * common/common-defs.h: Rename include guard.
8311         * common/common-debug.h: Rename include guard.
8312         * common/cleanups.h: Rename include guard.
8313         * common/buffer.h: Rename include guard.
8314         * common/btrace-common.h: Rename include guard.
8315         * common/break-common.h: Rename include guard.
8316         * cli/cli-utils.h: Rename include guard.
8317         * cli/cli-style.h: Rename include guard.
8318         * cli/cli-setshow.h: Rename include guard.
8319         * cli/cli-script.h: Rename include guard.
8320         * cli/cli-interp.h: Rename include guard.
8321         * cli/cli-decode.h: Rename include guard.
8322         * cli/cli-cmds.h: Rename include guard.
8323         * charset-list.h: Add include guard.
8324         * buildsym-legacy.h: Rename include guard.
8325         * bfin-tdep.h: Add include guard.
8326         * ax.h: Rename include guard.
8327         * arm-linux-tdep.h: Add include guard.
8328         * arm-fbsd-tdep.h: Add include guard.
8329         * arch/xtensa.h: Rename include guard.
8330         * arch/tic6x.h: Add include guard.
8331         * arch/i386.h: Add include guard.
8332         * arch/arm.h: Rename include guard.
8333         * arch/arm-linux.h: Rename include guard.
8334         * arch/arm-get-next-pcs.h: Rename include guard.
8335         * arch/amd64.h: Add include guard.
8336         * arch/aarch64-insn.h: Rename include guard.
8337         * arch-utils.h: Rename include guard.
8338         * annotate.h: Add include guard.
8339         * amd64-darwin-tdep.h: Rename include guard.
8340         * aarch64-linux-tdep.h: Add include guard.
8341         * aarch64-fbsd-tdep.h: Add include guard.
8342         * aarch32-linux-nat.h: Add include guard.
8343
8344 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8345
8346         * macrotab.c (macro_define_internal): New function that
8347         factorizes macro_define_object_internal and macro_define_function
8348         code.
8349         (macro_define_object_internal): Use macro_define_internal.
8350         (macro_define_function): Likewise.
8351
8352 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8353
8354         * macrocmd.c (extract_identifier): Return
8355         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8356         callers.
8357
8358 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8359
8360         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8361
8362 2019-02-05  Tom Tromey  <tom@tromey.com>
8363
8364         * target.c (target_stack::unpush): Move assertion earlier.
8365
8366 2019-01-30  Tom Tromey  <tom@tromey.com>
8367
8368         PR python/23615:
8369         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8370         (gdbpy_parse_and_eval): Likewise.
8371         * python/python-internal.h (gdbpy_allow_threads): New class.
8372
8373 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8374
8375         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8376         (aarch64_fbsd_fpregmap): Move earlier.
8377         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8378         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8379         instead of individual calls to trad_frame_set_reg_addr.
8380         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8381         earlier.
8382         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8383         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8384         instead of individual calls to trad_frame_set_reg_addr.
8385
8386 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8387
8388         * CONTRIBUTE: Replace contribution list with wiki link.
8389
8390 2019-01-25  Tom Tromey  <tom@tromey.com>
8391
8392         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8393
8394 2019-01-25  Tom Tromey  <tom@tromey.com>
8395
8396         * xtensa-linux-nat.c: Fix common/ includes.
8397         * xml-support.h: Fix common/ includes.
8398         * xml-support.c: Fix common/ includes.
8399         * x86-linux-nat.c: Fix common/ includes.
8400         * windows-nat.c: Fix common/ includes.
8401         * varobj.h: Fix common/ includes.
8402         * varobj.c: Fix common/ includes.
8403         * value.c: Fix common/ includes.
8404         * valops.c: Fix common/ includes.
8405         * utils.c: Fix common/ includes.
8406         * unittests/xml-utils-selftests.c: Fix common/ includes.
8407         * unittests/utils-selftests.c: Fix common/ includes.
8408         * unittests/unpack-selftests.c: Fix common/ includes.
8409         * unittests/tracepoint-selftests.c: Fix common/ includes.
8410         * unittests/style-selftests.c: Fix common/ includes.
8411         * unittests/string_view-selftests.c: Fix common/ includes.
8412         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8413         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8414         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8415         * unittests/rsp-low-selftests.c: Fix common/ includes.
8416         * unittests/parse-connection-spec-selftests.c: Fix common/
8417         includes.
8418         * unittests/optional-selftests.c: Fix common/ includes.
8419         * unittests/offset-type-selftests.c: Fix common/ includes.
8420         * unittests/observable-selftests.c: Fix common/ includes.
8421         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8422         * unittests/memrange-selftests.c: Fix common/ includes.
8423         * unittests/memory-map-selftests.c: Fix common/ includes.
8424         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8425         * unittests/function-view-selftests.c: Fix common/ includes.
8426         * unittests/environ-selftests.c: Fix common/ includes.
8427         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8428         * unittests/common-utils-selftests.c: Fix common/ includes.
8429         * unittests/cli-utils-selftests.c: Fix common/ includes.
8430         * unittests/array-view-selftests.c: Fix common/ includes.
8431         * ui-file.c: Fix common/ includes.
8432         * tui/tui-io.c: Fix common/ includes.
8433         * tracepoint.h: Fix common/ includes.
8434         * tracepoint.c: Fix common/ includes.
8435         * tracefile-tfile.c: Fix common/ includes.
8436         * top.h: Fix common/ includes.
8437         * top.c: Fix common/ includes.
8438         * thread.c: Fix common/ includes.
8439         * target/waitstatus.h: Fix common/ includes.
8440         * target/waitstatus.c: Fix common/ includes.
8441         * target.h: Fix common/ includes.
8442         * target.c: Fix common/ includes.
8443         * target-memory.c: Fix common/ includes.
8444         * target-descriptions.c: Fix common/ includes.
8445         * symtab.h: Fix common/ includes.
8446         * symfile.c: Fix common/ includes.
8447         * stap-probe.c: Fix common/ includes.
8448         * spu-linux-nat.c: Fix common/ includes.
8449         * sparc-nat.c: Fix common/ includes.
8450         * source.c: Fix common/ includes.
8451         * solib.c: Fix common/ includes.
8452         * solib-target.c: Fix common/ includes.
8453         * ser-unix.c: Fix common/ includes.
8454         * ser-tcp.c: Fix common/ includes.
8455         * ser-pipe.c: Fix common/ includes.
8456         * ser-base.c: Fix common/ includes.
8457         * selftest-arch.c: Fix common/ includes.
8458         * s12z-tdep.c: Fix common/ includes.
8459         * rust-exp.y: Fix common/ includes.
8460         * rs6000-aix-tdep.c: Fix common/ includes.
8461         * riscv-tdep.c: Fix common/ includes.
8462         * remote.c: Fix common/ includes.
8463         * remote-notif.h: Fix common/ includes.
8464         * remote-fileio.h: Fix common/ includes.
8465         * remote-fileio.c: Fix common/ includes.
8466         * regcache.h: Fix common/ includes.
8467         * regcache.c: Fix common/ includes.
8468         * record-btrace.c: Fix common/ includes.
8469         * python/python.c: Fix common/ includes.
8470         * python/py-type.c: Fix common/ includes.
8471         * python/py-inferior.c: Fix common/ includes.
8472         * progspace.h: Fix common/ includes.
8473         * producer.c: Fix common/ includes.
8474         * procfs.c: Fix common/ includes.
8475         * proc-api.c: Fix common/ includes.
8476         * printcmd.c: Fix common/ includes.
8477         * ppc-linux-nat.c: Fix common/ includes.
8478         * parser-defs.h: Fix common/ includes.
8479         * osdata.c: Fix common/ includes.
8480         * obsd-nat.c: Fix common/ includes.
8481         * nat/x86-linux.c: Fix common/ includes.
8482         * nat/x86-linux-dregs.c: Fix common/ includes.
8483         * nat/x86-dregs.h: Fix common/ includes.
8484         * nat/x86-dregs.c: Fix common/ includes.
8485         * nat/ppc-linux.c: Fix common/ includes.
8486         * nat/mips-linux-watch.h: Fix common/ includes.
8487         * nat/mips-linux-watch.c: Fix common/ includes.
8488         * nat/linux-waitpid.c: Fix common/ includes.
8489         * nat/linux-ptrace.h: Fix common/ includes.
8490         * nat/linux-ptrace.c: Fix common/ includes.
8491         * nat/linux-procfs.c: Fix common/ includes.
8492         * nat/linux-personality.c: Fix common/ includes.
8493         * nat/linux-osdata.c: Fix common/ includes.
8494         * nat/linux-namespaces.c: Fix common/ includes.
8495         * nat/linux-btrace.h: Fix common/ includes.
8496         * nat/linux-btrace.c: Fix common/ includes.
8497         * nat/fork-inferior.c: Fix common/ includes.
8498         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8499         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8500         * nat/aarch64-linux.c: Fix common/ includes.
8501         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8502         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8503         * namespace.h: Fix common/ includes.
8504         * mips-linux-tdep.c: Fix common/ includes.
8505         * minsyms.c: Fix common/ includes.
8506         * mi/mi-parse.h: Fix common/ includes.
8507         * mi/mi-main.c: Fix common/ includes.
8508         * mi/mi-cmd-env.c: Fix common/ includes.
8509         * memrange.h: Fix common/ includes.
8510         * memattr.c: Fix common/ includes.
8511         * maint.h: Fix common/ includes.
8512         * maint.c: Fix common/ includes.
8513         * main.c: Fix common/ includes.
8514         * machoread.c: Fix common/ includes.
8515         * location.c: Fix common/ includes.
8516         * linux-thread-db.c: Fix common/ includes.
8517         * linux-nat.c: Fix common/ includes.
8518         * linux-fork.c: Fix common/ includes.
8519         * inline-frame.c: Fix common/ includes.
8520         * infrun.c: Fix common/ includes.
8521         * inflow.c: Fix common/ includes.
8522         * inferior.h: Fix common/ includes.
8523         * inferior.c: Fix common/ includes.
8524         * infcmd.c: Fix common/ includes.
8525         * inf-ptrace.c: Fix common/ includes.
8526         * inf-child.c: Fix common/ includes.
8527         * ia64-linux-nat.c: Fix common/ includes.
8528         * i387-tdep.c: Fix common/ includes.
8529         * i386-tdep.c: Fix common/ includes.
8530         * i386-linux-tdep.c: Fix common/ includes.
8531         * i386-linux-nat.c: Fix common/ includes.
8532         * i386-go32-tdep.c: Fix common/ includes.
8533         * i386-fbsd-tdep.c: Fix common/ includes.
8534         * i386-fbsd-nat.c: Fix common/ includes.
8535         * guile/scm-type.c: Fix common/ includes.
8536         * guile/guile.c: Fix common/ includes.
8537         * go32-nat.c: Fix common/ includes.
8538         * gnu-nat.c: Fix common/ includes.
8539         * gdbthread.h: Fix common/ includes.
8540         * gdbarch-selftests.c: Fix common/ includes.
8541         * gdb_usleep.c: Fix common/ includes.
8542         * gdb_select.h: Fix common/ includes.
8543         * gdb_bfd.c: Fix common/ includes.
8544         * gcore.c: Fix common/ includes.
8545         * fork-child.c: Fix common/ includes.
8546         * findvar.c: Fix common/ includes.
8547         * fbsd-nat.c: Fix common/ includes.
8548         * event-top.c: Fix common/ includes.
8549         * event-loop.c: Fix common/ includes.
8550         * dwarf2read.c: Fix common/ includes.
8551         * dwarf2loc.c: Fix common/ includes.
8552         * dwarf2-frame.c: Fix common/ includes.
8553         * dwarf-index-cache.c: Fix common/ includes.
8554         * dtrace-probe.c: Fix common/ includes.
8555         * disasm-selftests.c: Fix common/ includes.
8556         * defs.h: Fix common/ includes.
8557         * csky-tdep.c: Fix common/ includes.
8558         * cp-valprint.c: Fix common/ includes.
8559         * cp-support.h: Fix common/ includes.
8560         * cp-support.c: Fix common/ includes.
8561         * corelow.c: Fix common/ includes.
8562         * completer.h: Fix common/ includes.
8563         * completer.c: Fix common/ includes.
8564         * compile/compile.c: Fix common/ includes.
8565         * compile/compile-loc2c.c: Fix common/ includes.
8566         * compile/compile-cplus-types.c: Fix common/ includes.
8567         * compile/compile-cplus-symbols.c: Fix common/ includes.
8568         * command.h: Fix common/ includes.
8569         * cli/cli-dump.c: Fix common/ includes.
8570         * cli/cli-cmds.c: Fix common/ includes.
8571         * charset.c: Fix common/ includes.
8572         * build-id.c: Fix common/ includes.
8573         * btrace.h: Fix common/ includes.
8574         * btrace.c: Fix common/ includes.
8575         * breakpoint.h: Fix common/ includes.
8576         * breakpoint.c: Fix common/ includes.
8577         * ax.h:
8578         (enum agent_op): Fix common/ includes.
8579         * ax-general.c (struct aop_map): Fix common/ includes.
8580         * ax-gdb.c: Fix common/ includes.
8581         * auxv.c: Fix common/ includes.
8582         * auto-load.c: Fix common/ includes.
8583         * arm-tdep.c: Fix common/ includes.
8584         * arch/riscv.c: Fix common/ includes.
8585         * arch/ppc-linux-common.c: Fix common/ includes.
8586         * arch/i386.c: Fix common/ includes.
8587         * arch/arm.c: Fix common/ includes.
8588         * arch/arm-linux.c: Fix common/ includes.
8589         * arch/arm-get-next-pcs.c: Fix common/ includes.
8590         * arch/amd64.c: Fix common/ includes.
8591         * arch/aarch64.c: Fix common/ includes.
8592         * arch/aarch64-insn.c: Fix common/ includes.
8593         * arch-utils.c: Fix common/ includes.
8594         * amd64-windows-tdep.c: Fix common/ includes.
8595         * amd64-tdep.c: Fix common/ includes.
8596         * amd64-sol2-tdep.c: Fix common/ includes.
8597         * amd64-obsd-tdep.c: Fix common/ includes.
8598         * amd64-nbsd-tdep.c: Fix common/ includes.
8599         * amd64-linux-tdep.c: Fix common/ includes.
8600         * amd64-linux-nat.c: Fix common/ includes.
8601         * amd64-fbsd-tdep.c: Fix common/ includes.
8602         * amd64-fbsd-nat.c: Fix common/ includes.
8603         * amd64-dicos-tdep.c: Fix common/ includes.
8604         * amd64-darwin-tdep.c: Fix common/ includes.
8605         * agent.c: Fix common/ includes.
8606         * ada-lang.h: Fix common/ includes.
8607         * ada-lang.c: Fix common/ includes.
8608         * aarch64-tdep.c: Fix common/ includes.
8609
8610 2019-01-25  Tom Tromey  <tom@tromey.com>
8611
8612         * common/create-version.sh: Use common/version.h.
8613
8614 2019-01-24  Pedro Alves  <palves@redhat.com>
8615
8616         * infrun.c (signal_stop, signal_print, signal_program)
8617         (signal_catch, signal_pass): Now arrays instead of pointers.
8618         (update_signals_program_target, do_target_resume)
8619         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8620         * linux-nat.c (linux_nat_target::pass_signals)
8621         (linux_nat_target::create_inferior, linux_nat_target::attach):
8622         Adjust.
8623         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8624         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8625         * procfs.c (procfs_target::pass_signals): Adjust.
8626         * record-full.c (record_full_target::resume): Adjust.
8627         * remote.c (remote_target::pass_signals)
8628         (remote_target::program_signals): Adjust.
8629         * target-debug.h (target_debug_print_signals): Now takes a
8630         gdb::array_view as parameter.  Adjust.
8631         * target.h (target_ops) <pass_signals, program_signals>: Replace
8632         pointer and length parameters with gdb::array_view.
8633         (target_pass_signals, target_program_signals): Likewise.
8634         * target-delegates.c: Regenerate.
8635
8636 2019-01-24  Pedro Alves  <palves@redhat.com>
8637
8638         * common/forward-scope-exit.h
8639         (forward_scope_exit::forward_scope_exit): Pass arguments to
8640         m_bind_function directly, instead of creating a std::bind and
8641         copying that.
8642
8643 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8644
8645         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8646         for static members.
8647         (pass_in_v_vfp_candidate): Likewise.
8648
8649 2019-01-23  Tom Tromey  <tom@tromey.com>
8650             Pedro Alves  <palves@redhat.com>
8651
8652         * regcache.c (class regcache_invalidator): Remove.
8653         (regcache::raw_write): Use make_scope_exit.
8654
8655 2019-01-23  Tom Tromey  <tom@tromey.com>
8656
8657         * ui-out.h (class ui_out_emit_type): Update comment.
8658
8659 2019-01-23  Tom Tromey  <tom@tromey.com>
8660
8661         * infrun.c (fetch_inferior_event): Update comment.
8662
8663 2019-01-23  Tom Tromey  <tom@tromey.com>
8664             Pedro Alves  <palves@redhat.com>
8665
8666         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8667         parameter.
8668         (fetch_inferior_event): Use SCOPE_EXIT.
8669
8670
8671 2019-01-23  Tom Tromey  <tom@tromey.com>
8672             Pedro Alves  <palves@redhat.com>
8673
8674         * infrun.c (disable_thread_events): Delete.
8675         (stop_all_threads): Use SCOPE_EXIT.
8676
8677 2019-01-23  Tom Tromey  <tom@tromey.com>
8678             Pedro Alves  <palves@redhat.com>
8679
8680         * symfile.c: Include forward-scope-exit.h.
8681         (clear_symtab_users_cleanup): Replace forward declaration with
8682         a FORWARD_SCOPE_EXIT.
8683         (syms_from_objfile_1): Use the forward_scope_exit and
8684         gdb::optional instead of cleanup_function.
8685         (reread_symbols): Use the forward_scope_exit instead of
8686         cleanup_function.
8687         (clear_symtab_users_cleanup): Remove function.
8688
8689 2019-01-23  Tom Tromey  <tom@tromey.com>
8690             Pedro Alves  <palves@redhat.com>
8691
8692         * linux-nat.c: Include scope-exit.h.
8693         (cleanup_target_stop): Remove.
8694         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8695         SCOPE_EXIT.
8696
8697 2019-01-23  Tom Tromey  <tom@tromey.com>
8698             Pedro Alves  <palves@redhat.com>
8699
8700         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8701         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8702
8703 2019-01-23  Tom Tromey  <tom@tromey.com>
8704             Andrew Burgess  <andrew.burgess@embecosm.com>
8705             Pedro Alves  <palves@redhat.com>
8706
8707         * infrun.c (fetch_inferior_event): Use scope_exit.
8708         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8709         * top.c (execute_command): Use scope_exit.
8710         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8711         * utils.c (do_bpstat_clear_actions_cleanup)
8712         (make_bpstat_clear_actions_cleanup): Remove.
8713
8714 2019-01-23  Tom Tromey  <tom@tromey.com>
8715             Pedro Alves  <palves@redhat.com>
8716
8717         * infrun.c: Include "common/scope-exit.h"
8718         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8719         (wait_for_inferior): Use SCOPE_EXIT.
8720         (fetch_inferior_event): Use scope_exit.
8721
8722 2019-01-23  Tom Tromey  <tom@tromey.com>
8723             Pedro Alves  <palves@redhat.com>
8724
8725         * breakpoint.c (create_breakpoint): Remove cleanup.
8726
8727 2019-01-23  Tom Tromey  <tom@tromey.com>
8728             Andrew Burgess  <andrew.burgess@embecosm.com>
8729             Pedro Alves  <palves@redhat.com>
8730
8731 2019-01-23  Pedro Alves  <palves@redhat.com>
8732
8733         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8734
8735 2019-01-23  Pedro Alves  <palves@redhat.com>
8736             Andrew Burgess  <andrew.burgess@embecosm.com>
8737
8738         * gdbthread.h: Include "common/forward-scope-exit.h".
8739         (scoped_finish_thread_state): Redefine custom class in terms of
8740         forward_scope_exit.
8741
8742 2019-01-23  Pedro Alves  <palves@redhat.com>
8743             Andrew Burgess  <andrew.burgess@embecosm.com>
8744
8745         * common/forward-scope-exit.h: New file.
8746
8747 2019-01-23  Pedro Alves  <palves@redhat.com>
8748             Andrew Burgess  <andrew.burgess@embecosm.com>
8749             Tom Tromey  <tom@tromey.com>
8750
8751         * common/scope-exit.h: New file.
8752
8753 2019-01-23  Pedro Alves  <palves@redhat.com>
8754
8755         * common/preprocessor.h (ESC): Rename to ...
8756         (ESC_PARENS): ... this.
8757         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8758         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8759
8760 2019-01-23  Tom Tromey  <tom@tromey.com>
8761
8762         * language.h (class scoped_switch_to_sym_language_if_auto):
8763         Initialize m_lang in both cases.
8764
8765 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8766
8767         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8768         with XCNEW.
8769
8770 2019-01-22  Tom Tromey  <tom@tromey.com>
8771
8772         * corelow.c: Do not include sys/file.h.
8773
8774 2019-01-22  Tom Tromey  <tom@tromey.com>
8775
8776         * tui/tui-wingeneral.h: Include gdb_curses.h.
8777
8778 2019-01-22  Tom Tromey  <tom@tromey.com>
8779
8780         * source-cache.h (class source_cache) <get_source_lines,
8781         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8782
8783 2019-01-22  Tom Tromey  <tom@tromey.com>
8784
8785         * remote-fileio.h (struct remote_target): Declare.
8786
8787 2019-01-22  Tom Tromey  <tom@tromey.com>
8788
8789         * python/py-arch.c: Do not include py-ref.h.
8790         * python/py-bpevent.c: Do not include py-ref.h.
8791         * python/py-cmd.c: Do not include py-ref.h.
8792         * python/py-continueevent.c: Do not include py-ref.h.
8793         * python/py-event.h: Do not include py-ref.h.
8794         * python/py-evtregistry.c: Do not include py-ref.h.
8795         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8796         * python/py-frame.c: Do not include py-ref.h.
8797         * python/py-framefilter.c: Do not include py-ref.h.
8798         * python/py-function.c: Do not include py-ref.h.
8799         * python/py-infevents.c: Do not include py-ref.h.
8800         * python/py-linetable.c: Do not include py-ref.h.
8801         * python/py-objfile.c: Do not include py-ref.h.
8802         * python/py-param.c: Do not include py-ref.h.
8803         * python/py-prettyprint.c: Do not include py-ref.h.
8804         * python/py-progspace.c: Do not include py-ref.h.
8805         * python/py-symbol.c: Do not include py-ref.h.
8806         * python/py-symtab.c: Do not include py-ref.h.
8807         * python/py-type.c: Do not include py-ref.h.
8808         * python/py-unwind.c: Do not include py-ref.h.
8809         * python/py-utils.c: Do not include py-ref.h.
8810         * python/py-value.c: Do not include py-ref.h.
8811         * python/py-varobj.c: Do not include py-ref.h.
8812         * python/py-xmethods.c: Do not include py-ref.h.
8813         * python/python.c: Do not include py-ref.h.
8814         * varobj.c: Do not include py-ref.h.
8815
8816 2019-01-22  Tom Tromey  <tom@tromey.com>
8817
8818         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8819         keyword for bcache.
8820
8821 2019-01-22  Tom Tromey  <tom@tromey.com>
8822
8823         * compile/compile-cplus-types.c: Remove a comment by #include.
8824
8825 2019-01-22  Tom Tromey  <tom@tromey.com>
8826
8827         * compile/gcc-c-plugin.h: Include compile-internal.h.
8828
8829 2019-01-22  Tom Tromey  <tom@tromey.com>
8830
8831         * stabsread.c (EXTERN): Do not define.
8832         (symnum, next_symbol_text_func, processing_gcc_compilation)
8833         (within_function, global_sym_chain, global_stabs)
8834         (previous_stab_code, this_object_header_files)
8835         (n_this_object_header_files)
8836         (n_allocated_this_object_header_files): Define.
8837         * stabsread.h (EXTERN): Never define.  Use "extern".
8838
8839 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8840
8841         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8842         history_value.
8843
8844 2019-01-21  Tom Tromey  <tom@tromey.com>
8845
8846         * ui-out.c: Fix includes.
8847         * tui/tui-source.c: Fix includes.
8848         * target.c: Fix includes.
8849         * remote.c: Fix includes.
8850         * regcache.c: Fix includes.
8851         * python/py-block.c: Fix includes.
8852         * printcmd.c: Fix includes.
8853         * or1k-tdep.c: Fix includes.
8854         * mi/mi-main.c: Fix includes.
8855         * m32r-tdep.c: Fix includes.
8856         * csky-tdep.c: Fix includes.
8857         * compile/compile-cplus-types.c: Fix includes.
8858         * cli/cli-interp.c: Fix includes.
8859
8860 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8861
8862         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8863         for padding.
8864
8865 2019-01-16  Tom Tromey  <tom@tromey.com>
8866
8867         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8868         earlier.
8869         (struct objfile) <msymbols_range>: Move from top level.
8870         <msymbols>: New method.
8871         (class objfile_msymbols): Remove.
8872         * symtab.c (default_collect_symbol_completion_matches_break_on):
8873         Update.
8874         * symmisc.c (dump_msymbols): Update.
8875         * stabsread.c (scan_file_globals): Update.
8876         * objc-lang.c (info_selectors_command, info_classes_command)
8877         (find_methods): Update.
8878         * minsyms.c (find_solib_trampoline_target): Update.
8879         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8880         * coffread.c (coff_symfile_read): Update.
8881         * ada-lang.c (ada_lookup_simple_minsym)
8882         (ada_collect_symbol_completion_matches): Update.
8883
8884 2019-01-16  Tom Tromey  <tom@tromey.com>
8885
8886         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8887         type.  Remove no-argument constructor.
8888         <iterator::operator++>: Simplify.
8889         <begin>: Update.
8890         <end>: Use minimal_symbol_count.
8891
8892 2019-01-16  Tom Tromey  <tom@tromey.com>
8893
8894         * objfiles.h (struct objfile) <psymtabs>: New method.
8895         (class objfile_psymtabs): Remove.
8896         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8897         typedef.
8898         <range>: New method.
8899         (require_partial_symbols): Change return type.
8900         * psymtab.c (require_partial_symbols)
8901         (psym_expand_symtabs_matching): Update.
8902         * mdebugread.c (parse_partial_symbols): Update.
8903         * dbxread.c (dbx_end_psymtab): Update.
8904
8905 2019-01-15  Tom Tromey  <tom@tromey.com>
8906
8907         * symtab.c (lookup_objfile_from_block)
8908         (lookup_symbol_in_objfile_symtabs)
8909         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8910         (find_line_symtab, info_sources_command)
8911         (default_collect_symbol_completion_matches_break_on)
8912         (make_source_files_completion_list): Update.
8913         * symmisc.c (print_objfile_statistics, dump_objfile)
8914         (maintenance_print_symbols, maintenance_info_symtabs)
8915         (maintenance_check_symtabs, maintenance_info_line_tables):
8916         Update.
8917         * source.c (select_source_symtab)
8918         (forget_cached_source_info_for_objfile): Update.
8919         * objfiles.h (class objfile_compunits): Remove.
8920         (struct objfile) <compunits_range>: New typedef.
8921         (compunits): New method.
8922         * objfiles.c (objfile_relocate1): Update.
8923         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8924         * maint.c (count_symtabs_and_blocks): Update.
8925         * linespec.c (iterate_over_all_matching_symtabs): Update.
8926         * cp-support.c (add_symbol_overload_list_qualified): Update.
8927         * coffread.c (coff_symtab_read): Update.
8928         * ada-lang.c (add_nonlocal_symbols)
8929         (ada_collect_symbol_completion_matches)
8930         (ada_add_global_exceptions): Update.
8931
8932 2019-01-15  Tom Tromey  <tom@tromey.com>
8933
8934         * progspace.h (program_space) <objfiles_safe_range>: New
8935         typedef.
8936         <objfiles_safe>: New method.
8937         * objfiles.h (class all_objfiles_safe): Remove.
8938         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8939         * jit.c (jit_inferior_exit_hook): Update.
8940
8941 2019-01-17  Tom Tromey  <tom@tromey.com>
8942
8943         * progspace.h (program_space) <objfiles_range>: New typedef.
8944         <objfiles>: New method.
8945         <objfiles_head>: Rename from objfiles.
8946         (object_files): Update.
8947         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8948         * guile/scm-pretty-print.c
8949         (ppscm_find_pretty_printer_from_objfiles): Update.
8950         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8951         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8952         Update.
8953         * python/py-progspace.c (pspy_get_objfiles): Update.
8954         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8955         Update.
8956         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8957         (objfpy_lookup_objfile_by_build_id): Update.
8958         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8959         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8960         Update.
8961         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8962         (expand_symtab_containing_pc, lookup_objfile_from_block)
8963         (lookup_static_symbol, basic_lookup_transparent_type)
8964         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8965         (find_line_symtab, info_sources_command)
8966         (default_collect_symbol_completion_matches_break_on)
8967         (make_source_files_completion_list, find_main_name): Update.
8968         * symmisc.c (print_symbol_bcache_statistics)
8969         (print_objfile_statistics, maintenance_print_symbols)
8970         (maintenance_print_msymbols, maintenance_print_objfiles)
8971         (maintenance_info_symtabs, maintenance_check_symtabs)
8972         (maintenance_expand_symtabs, maintenance_info_line_tables):
8973         Update.
8974         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8975         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8976         (map_overlay_command, unmap_overlay_command)
8977         (simple_overlay_update, expand_symtabs_matching)
8978         (map_symbol_filenames): Update.
8979         * symfile-debug.c (set_debug_symfile): Update.
8980         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8981         Update.
8982         * source.c (select_source_symtab, forget_cached_source_info):
8983         Update.
8984         * solib.c (solib_read_symbols): Update.
8985         * solib-spu.c (append_ocl_sos): Update.
8986         * psymtab.c (maintenance_print_psymbols)
8987         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8988         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8989         * printcmd.c (info_symbol_command): Update.
8990         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8991         Update.
8992         * objfiles.h (class all_objfiles): Remove.
8993         * objfiles.c (have_partial_symbols, have_full_symbols)
8994         (have_minimal_symbols, qsort_cmp, update_section_map)
8995         (shared_objfile_contains_address_p)
8996         (default_iterate_over_objfiles_in_search_order): Update.
8997         * objc-lang.c (info_selectors_command, info_classes_command)
8998         (find_methods): Update.
8999         * minsyms.c (find_solib_trampoline_target): Update.
9000         * maint.c (maintenance_info_sections)
9001         (maintenance_translate_address, count_symtabs_and_blocks):
9002         Update.
9003         * main.c (captured_main_1): Update.
9004         * linux-thread-db.c (try_thread_db_load_from_pdir)
9005         (has_libpthread): Update.
9006         * linespec.c (iterate_over_all_matching_symtabs)
9007         (search_minsyms_for_name): Update.
9008         * jit.c (jit_find_objf_with_entry_addr): Update.
9009         * hppa-tdep.c (find_unwind_entry)
9010         (hppa_lookup_stub_minimal_symbol): Update.
9011         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9012         Update.
9013         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9014         (elf_gnu_ifunc_resolve_by_got): Update.
9015         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9016         * dwarf-index-write.c (save_gdb_index_command): Update.
9017         * cp-support.c (add_symbol_overload_list_qualified): Update.
9018         * breakpoint.c (create_overlay_event_breakpoint)
9019         (create_longjmp_master_breakpoint)
9020         (create_std_terminate_master_breakpoint)
9021         (create_exception_master_breakpoint): Update.
9022         * blockframe.c (find_pc_partial_function): Update.
9023         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9024         (ada_collect_symbol_completion_matches)
9025         (ada_add_global_exceptions): Update.
9026
9027 2019-01-17  Tom Tromey  <tom@tromey.com>
9028
9029         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9030         declare VEC.
9031         (solib_target_parse_libraries): Change return type.
9032         (library_list_start_segment, library_list_start_section)
9033         (library_list_end_library, library_list_start_library); Update.
9034         (solib_target_free_library_list): Remove.
9035         (solib_target_parse_libraries): Remove cleanup.  Change return
9036         type.
9037         (solib_target_current_sos): Update.
9038
9039 2019-01-17  Tom Tromey  <tromey@bapiya>
9040
9041         * valprint.c: Replace "the the" with "the".
9042         * symtab.c: Replace "the the" with "the".
9043         * solib.c: Replace "the the" with "the".
9044         * solib-dsbt.c: Replace "the the" with "the".
9045         * linespec.c: Replace "the the" with "the".
9046         * dwarf2loc.h: Replace "the the" with "the".
9047         * amd64-windows-tdep.c: Replace "the the" with "the".
9048         * aarch64-tdep.c: Replace "the the" with "the".
9049
9050 2019-01-16  Keith Seitz  <keiths@redhat.com>
9051
9052         PR gdb/23773
9053         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9054         <builder>: Rename to ..
9055         <m_builder>: ... this and make private.
9056         (dwarf2_cu::get_builder): New method.  Change all users of
9057         `builder' to use this method.
9058         (dwarf2_start_symtab): Move to ...
9059         (dwarf2_cu::start_symtab): ... here.  Update all callers
9060         (setup_type_unit_groups): Move to ...
9061         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9062         callers.
9063         (dwarf2_cu::reset_builder): New method.
9064         (process_full_compunit, process_full_type_unit): Use
9065         dwarf2_cu::reset_builder.
9066         (follow_die_offset): Record the ancestor CU if it is different
9067         from the followed DIE's CU.
9068         (follow_die_sig_1): Likewise.
9069
9070 2019-01-15  Tom Tromey  <tom@tromey.com>
9071
9072         * remote.c (class remote_state) <buf>: Now a char_vector.
9073         <buf_size>: Remove.
9074         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9075         parameter.
9076         (remote_target::getpkt_or_notif_sane_1)
9077         (remote_target::getpkt_sane)
9078         (remote_target::getpkt_or_notif_sane): Likewise.
9079         (class remote_target) <putpkt>: New overload.
9080         (remote_target::read_frame): Change type of "buf_p".  Remove
9081         sizeof_p parameter.
9082         (packet_ok): New overload.
9083         (packet_check_result): New overload.
9084         Update all uses.
9085
9086 2019-01-14  Tom Tromey  <tom@tromey.com>
9087
9088         * remote-notif.c (handle_notification, remote_notif_ack)
9089         (remote_notif_parse): Make "buf" const.
9090         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9091         const.
9092         (remote_notif_parse, remote_notif_ack, handle_notification):
9093         Likewise.
9094         * remote.c (remote_notif_stop_parse): Make "buf" const.
9095         (remote_target::remote_parse_stop_reply): Make "buf" const.
9096         (remote_notif_stop_ack): Make "buf" const.
9097
9098 2019-01-14  Tom Tromey  <tom@tromey.com>
9099
9100         * remote.c (remote_console_output): Make parameter const.
9101
9102 2019-01-14  Tom Tromey  <tom@tromey.com>
9103
9104         * target-debug.h (target_debug_print_signals): Constify.
9105         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9106         * procfs.c (procfs_target::pass_signals): Update.
9107         * linux-nat.c (linux_nat_target::pass_signals): Update.
9108         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9109         * target-delegates.c: Rebuild.
9110         * remote.c (remote_target::program_signals): Update.
9111         (remote_target::pass_signals): Update.
9112         * target.c (target_pass_signals): Constify argument.
9113         (target_program_signals): Likewise.
9114         * target.h (struct target_ops) <pass_signals, program_signals>:
9115         Constify argument.
9116         (target_pass_signals, target_program_signals): Constify argument.
9117
9118 2019-01-14  Tom Tromey  <tom@tromey.com>
9119
9120         PR tui/28819:
9121         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9122
9123 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9124
9125         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9126         field.
9127         * rs6000-tdep.c: Include reggroups.h.
9128         (IS_V_ALIAS_PSEUDOREG): Define.
9129         (rs6000_register_name): Return names for the "vX" aliases.
9130         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9131         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9132         aliases.  Call default_register_reggroup_p for all other
9133         pseudo-registers.
9134         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9135         New functions.
9136         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9137         Handle "vX" aliases.
9138         (v_alias_pseudo_register_collect): New function.
9139         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9140         (rs6000_gdbarch_init): Initialize "vX" aliases as
9141         pseudo-registers.  Restore registration of
9142         rs6000_pseudo_register_reggroup_p with
9143         set_tdesc_pseudo_register_reggroup_p.
9144
9145 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9146
9147         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9148         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9149         set_gdbarch_num_pseudo_regs.
9150
9151 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9152
9153         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9154         Remove arg prefixname, add do_set and do_show.
9155         Add member functions set_list and show_list.
9156         * cli/cli-style.c (class cli_style_option): Update accordingly.
9157         (style_set_list): Move to file scope.
9158         (style_show_list): Likewise.
9159         (set_style): Call help_list.
9160         (show_style): Call cmd_show_list.
9161         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9162         Update to use the new macro.
9163
9164 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9165
9166         * ada-lang.c (_initialize_ada_language): Expand the help text
9167         for the "catch exception" command.
9168
9169 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9170
9171         * symtab.c (matching_obj_sections): Initialize obj,
9172         declare it closer to its usage.
9173
9174 2019-01-10  Tom Tromey  <tom@tromey.com>
9175
9176         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9177         (basic_inf_threads_range): Remove.
9178         (inf_threads_range, inf_non_exited_threads_range)
9179         (safe_inf_threads_range): Use next_adapter.
9180
9181 2019-01-10  Keith Seitz  <keiths@redhat.com>
9182
9183         PR gdb/23712
9184         PR symtab/23010
9185         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9186         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9187
9188 2019-01-10  Keith Seitz  <keiths@redhat.com>
9189
9190         PR gdb/23712
9191         PR symtab/23010
9192         * dictionary.c (pending_to_vector): Remove.
9193         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9194         Remove _1 suffix, replacing functions of the same name.  Update
9195         all callers.
9196         (dict_create_hashed, dict_create_hashed_expandable)
9197         (dict_create_linear, dict_create_linear_expandable, dict_free)
9198         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9199         Make functions static.
9200
9201 2019-01-10  Keith Seitz  <keiths@redhat.com>
9202
9203         PR gdb/23712
9204         PR symtab/23010
9205         * dictionary.h (struct dictionary): Replace declaration with
9206         multidictionary.
9207         (dict_create_hashed, dict_create_hashed_expandable)
9208         (dict_create_linear, dict_create_linear_expandable)
9209         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9210         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9211         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9212         taking multidictionary argument.
9213         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9214         * block.h (struct block) <dict>: Change to multidictionary
9215         and rename `multidict'.
9216         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9217         symmisc.c: Update all dictionary references to multidictionary.
9218
9219 2019-01-10  Keith Seitz  <keiths@redhat.com>
9220
9221         PR gdb/23712
9222         PR symtab/23010
9223         * dictionary.c: Include unordered_map.
9224         (pending_to_vector): New function.
9225         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9226         Rewrite the non-"_1" functions to take vector instead
9227         of linked list.
9228         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9229         "new" _1 versions of the same name.
9230         (multidictionary): Define.
9231         (std::hash<enum language): New definition.
9232         (collate_pending_symbols_by_language, mdict_create_hashed)
9233         (mdict_create_hashed_expandable, mdict_create_linear)
9234         (mdict_create_linear_expandable, mdict_free)
9235         (find_language_dictionary, create_new_language_dictionary)
9236         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9237         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9238         (mdict_size, mdict_empty): New functions.
9239         * dictionary.h (mdict_iterator): Define.
9240
9241 2019-01-10  Pedro Alves  <palves@redhat.com>
9242
9243         * breakpoint.c (read_uploaded_action)
9244         (create_tracepoint_from_upload): Adjust to use
9245         gdb::unique_xmalloc_ptr.
9246         * ctf.c (ctf_write_uploaded_tp):
9247         (SET_ARRAY_FIELD): Use emplace_back.
9248         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9249         * tracefile-tfile.c (tfile_write_uploaded_tp):
9250         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9251         gdb::unique_xmalloc_ptr.
9252         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9253         at_string, cond_string, cmd_strings>: Replace char pointers
9254         with gdb::unique_xmalloc_ptr.
9255
9256 2019-01-10  Pedro Alves  <palves@redhat.com>
9257
9258         * solib-target.c (library_list_start_library): Don't xstrdup name.
9259
9260 2019-01-10  Pedro Alves  <palves@redhat.com>
9261
9262         * mdebugread.c (parse_partial_symbols): Use
9263         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9264
9265 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9266
9267         * linux-fork.c (scoped_switch_fork_info)
9268         <~scoped_switch_fork_info>: Fix incorrect variable name.
9269
9270 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9271
9272         * linux-fork.c (scoped_switch_fork_info)
9273         <scoped_switch_fork_info>: Make explicit.
9274         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9275
9276 2019-01-10  Tom Tromey  <tom@tromey.com>
9277
9278         * objfiles.h (objfile::reset_psymtabs): Update.
9279         * objfiles.c (objfile::objfile): Update.
9280         * psymtab.h (psymtab_storage::obstack): Update.
9281         (psymtab_storage::m_obstack): Use gdb::optional.
9282         (class psymtab_storage): Update comment.  Remove objfile
9283         parameter.
9284         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9285
9286 2019-01-10  Tom Tromey  <tom@tromey.com>
9287
9288         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9289         <free_psymtabs>: Now private.
9290         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9291         (allocate_psymtab): Use new method.
9292
9293 2019-01-10  Tom Tromey  <tom@tromey.com>
9294
9295         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9296         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9297         * mdebugread.c (parse_partial_symbols): Use
9298         allocate_dependencies.
9299         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9300         allocate_dependencies.
9301         (process_psymtab_comp_unit_reader)
9302         (build_type_psymtab_dependencies): Likewise.
9303         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9304
9305 2019-01-10  Tom Tromey  <tom@tromey.com>
9306
9307         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9308         PSYMBOL_SET_LANGUAGE.
9309         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9310
9311 2019-01-10  Tom Tromey  <tom@tromey.com>
9312
9313         * psymtab.h (psymtab_storage::obstack): New method.
9314         <m_obstack>: Rename from obstack; now private.
9315         * psymtab.c (psymtab_storage): Update.
9316         * dwarf2read.c (create_addrmap_from_index)
9317         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9318         Update.
9319
9320 2019-01-10  Tom Tromey  <tom@tromey.com>
9321
9322         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9323         * objfiles.h (objfile::reset_psymtabs): New method.
9324
9325 2019-01-10  Tom Tromey  <tom@tromey.com>
9326
9327         * symmisc.c (print_symbol_bcache_statistics): Update.
9328         (print_objfile_statistics): Update.
9329         * symfile.c (reread_symbols): Update.
9330         * psymtab.h (class psymtab_storage): New.
9331         * psymtab.c (psymtab_storage): New constructor.
9332         (~psymtab_storage): New destructor.
9333         (require_partial_symbols): Update.
9334         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9335         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9336         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9337         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9338         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9339         (start_psymtab_common, end_psymtab_common)
9340         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9341         (allocate_psymtab): Update.
9342         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9343         Update.
9344         (dump_psymtab_addrmap, maintenance_print_psymbols)
9345         (maintenance_check_psymtabs): Update.
9346         (class objfile_psymtabs): Move to objfiles.h.
9347         * psympriv.h (discard_psymtab): Now inline.
9348         (psymtab_discarder::psymtab_discarder): Update.
9349         (psymtab_discarder::~psymtab_discarder): Update.
9350         (ALL_OBJFILE_PSYMTABS): Rewrite.
9351         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9352         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9353         Remove fields.
9354         <partial_symtabs>: New field.
9355         (class objfile_psymtabs): Move from psymtab.h.  Update.
9356         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9357         psymbol_cache.
9358         (objfile::~objfile): Don't destroy psymbol_cache.
9359         * mdebugread.c (parse_partial_symbols): Update.
9360         * dwarf2read.c (create_addrmap_from_index)
9361         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9362         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9363         (add_partial_subprogram, dwarf2_ranges_read): Update.
9364         * dwarf-index-write.c (write_address_map)
9365         (write_one_signatured_type, recursively_write_psymbols)
9366         (class debug_names, class debug_names, write_psymtabs_to_index):
9367         Update.
9368
9369 2019-01-10  Tom Tromey  <tom@tromey.com>
9370
9371         * symtab.h (SYMBOL_SET_NAMES): Update.
9372         (symbol_set_names): Update.
9373         (MSYMBOL_SET_NAMES): Update.
9374         * symtab.c (symbol_set_names): Change argument to be an
9375         objfile_per_bfd_storage.
9376         * psymtab.c (add_psymbol_to_bcache): Update.
9377         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9378
9379 2019-01-10  Tom Tromey  <tom@tromey.com>
9380
9381         * symtab.c (create_demangled_names_hash): Change argument to be an
9382         objfile_per_bfd_storage.
9383         (symbol_set_names): Update.
9384
9385 2019-01-10  Tom Tromey  <tom@tromey.com>
9386
9387         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9388         init_psymbol_list.
9389         * psymtab.c (init_psymbol_list): Do nothing if already called.
9390         * psympriv.h (init_psymbol_list): Add comment.
9391         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9392         init_psymbol_list.
9393         * dbxread.c (dbx_symfile_read): Unconditionally call
9394         init_psymbol_list.
9395
9396 2019-01-10  Tom Tromey  <tom@tromey.com>
9397
9398         * xcoffread.c (scan_xcoff_symtab): Update.
9399         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9400         "where".
9401         * mdebugread.c (parse_partial_symbols)
9402         (handle_psymbol_enumerators): Update.
9403         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9404         * dbxread.c (read_dbx_symtab): Update.
9405         * psympriv.h (psymbol_placement): New enum.
9406         (add_psymbol_to_list): Update.
9407
9408 2019-01-10  Tom Tromey  <tom@tromey.com>
9409
9410         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9411         static_psymbols parameters.
9412         (scan_xcoff_symtab): Update.
9413         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9414         static_psymbols parameters.
9415         * psympriv.h (start_psymtab_common): Update.
9416         * mdebugread.c (parse_partial_symbols): Update.
9417         * dwarf2read.c (create_partial_symtab): Update.
9418         * dbxread.c (read_dbx_symtab): Update.
9419         (start_psymtab): Remove global_psymbols and static_psymbols
9420         parameters.
9421
9422 2019-01-10  Tom Tromey  <tom@tromey.com>
9423
9424         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9425         * psymtab.c (allocate_psymtab): Add comment.
9426         * psympriv.h (allocate_psymtab): Add comment.
9427         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9428         initializations.
9429         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9430
9431 2019-01-10  Tom Tromey  <tom@tromey.com>
9432
9433         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9434         Don't declare.
9435         * mipsread.c: Include mdebugread.h.
9436         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9437         Declare.
9438         * elfread.c: Include mdebugread.h.
9439
9440 2019-01-09  Tom Tromey  <tom@tromey.com>
9441
9442         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9443         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9444         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9445         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9446         (psym_lookup_symbol, psym_find_last_source_symtab)
9447         (psym_forget_cached_source_info, psym_print_stats)
9448         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9449         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9450         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9451         (psym_find_compunit_symtab_by_address)
9452         (maintenance_print_psymbols, maintenance_info_psymtabs)
9453         (maintenance_check_psymtabs): Use ranged for.
9454         * psymtab.h (class objfile_psymtabs): New.
9455         (require_partial_symbols): Return objfile_psymtabs.
9456         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9457
9458 2019-01-09  Tom Tromey  <tom@tromey.com>
9459
9460         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9461         (find_pc_mapped_section, list_overlays_command)
9462         (map_overlay_command, unmap_overlay_command)
9463         (simple_overlay_update): Use all_objfiles.
9464         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9465         * printcmd.c (info_symbol_command): Use all_objfiles.
9466         * objfiles.h (ALL_OBJSECTIONS): Remove.
9467         * maint.c (maintenance_translate_address): Use all_objfiles.
9468         * gcore.c (gcore_create_callback): Use all_objfiles.
9469         (objfile_find_memory_regions): Likewise.
9470
9471 2019-01-09  Tom Tromey  <tom@tromey.com>
9472
9473         * symtab.c (find_line_symtab, info_sources_command)
9474         (make_source_files_completion_list): Use objfile_compunits.
9475         * source.c (select_source_symtab): Use objfile_compunits.
9476         * objfiles.h (struct objfile): Update comment.
9477         (ALL_OBJFILES): Remove.
9478         (ALL_FILETABS): Remove.
9479         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9480         objfile_compunits.
9481
9482 2019-01-09  Tom Tromey  <tom@tromey.com>
9483
9484         * symmisc.c (print_objfile_statistics, dump_objfile)
9485         (maintenance_print_symbols): Use compunit_filetabs.
9486         * source.c (forget_cached_source_info_for_objfile): Use
9487         compunit_filetabs.
9488         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9489         (ALL_FILETABS): Use compunit_filetabs.
9490         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9491         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9492
9493 2019-01-09  Tom Tromey  <tom@tromey.com>
9494
9495         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9496         (compunit_filetabs): New.
9497         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9498         compunit_filetabs.
9499         (info_sources_command, make_source_files_completion_list): Remove
9500         declaration.
9501         * symmisc.c (print_objfile_statistics, dump_objfile)
9502         (maintenance_print_symbols): Remove declaration.
9503         (maintenance_info_symtabs): Use compunit_filetabs.
9504         (maintenance_info_line_tables): Likewise.
9505         * source.c (select_source_symtab): Change local variable name.
9506         (forget_cached_source_info_for_objfile): Remove declaration.
9507         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9508         * objfiles.c (objfile_relocate1): Remove declaration.
9509         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9510         declaration.
9511         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9512         * coffread.c (coff_symtab_read): Remove declaration.
9513         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9514         compunit_filetabs.
9515
9516 2019-01-09  Tom Tromey  <tom@tromey.com>
9517
9518         * symtab.c (lookup_objfile_from_block)
9519         (find_pc_sect_compunit_symtab, search_symbols)
9520         (default_collect_symbol_completion_matches_break_on): Use
9521         objfile_compunits.
9522         * objfiles.h (ALL_COMPUNITS): Remove.
9523         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9524         * cp-support.c (add_symbol_overload_list_qualified): Use
9525         objfile_compunits.
9526         * ada-lang.c (ada_collect_symbol_completion_matches)
9527         (ada_add_global_exceptions): Use objfile_compunits.
9528
9529 2019-01-09  Tom Tromey  <tom@tromey.com>
9530
9531         * source.c (select_source_symtab)
9532         (forget_cached_source_info_for_objfile): Remove declaration.
9533         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9534         declaration.
9535         * maint.c (count_symtabs_and_blocks): Remove declaration.
9536         * cp-support.c (add_symbol_overload_list_qualified): Remove
9537         declaration.
9538         * coffread.c (coff_symtab_read): Remove declaration.
9539         * symtab.c (lookup_symbol_in_objfile_symtabs)
9540         (basic_lookup_transparent_type_1): Use objfile_compunits.
9541         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9542         (info_sources_command, search_symbols)
9543         (default_collect_symbol_completion_matches_break_on)
9544         (make_source_files_completion_list): Remove declaration.
9545         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9546         (ada_collect_symbol_completion_matches)
9547         (ada_add_global_exceptions): Remove declaration.
9548         * linespec.c (iterate_over_all_matching_symtabs): Use
9549         objfile_compunits.
9550         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9551         (class objfile_compunits): New.
9552         (ALL_COMPUNITS): Use objfile_compunits.
9553         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9554         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9555         objfile_compunits.
9556         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9557
9558 2019-01-09  Tom Tromey  <tom@tromey.com>
9559
9560         * symtab.c (search_symbols)
9561         (default_collect_symbol_completion_matches_break_on): Use
9562         objfile_msymbols.
9563         * ada-lang.c (ada_lookup_simple_minsym)
9564         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9565         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9566         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9567         objfile_msymbols.
9568         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9569         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9570         * objc-lang.c (find_methods): Use objfile_msymbols.
9571         (info_selectors_command, info_classes_command): Likewise.
9572         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9573         * objfiles.h (class objfile_msymbols): New.
9574         (ALL_OBJFILE_MSYMBOLS): Remove.
9575         (ALL_MSYMBOLS): Remove.
9576
9577 2019-01-09  Tom Tromey  <tom@tromey.com>
9578
9579         * common/next-iterator.h (next_adapter): Add Iterator template
9580         parameter.
9581         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9582         (class all_objfiles_safe): New.
9583         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9584         * objfiles.c (put_objfile_before): Update comment.
9585         (add_separate_debug_objfile): Likewise.
9586         (free_all_objfiles): Use all_objfiles_safe.
9587         (objfile_purge_solibs): Likewise.
9588
9589 2019-01-09  Tom Tromey  <tom@tromey.com>
9590
9591         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9592         (expand_symtab_containing_pc, lookup_static_symbol)
9593         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9594         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9595         all_objfiles.
9596         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9597         * breakpoint.c (create_overlay_event_breakpoint)
9598         (create_longjmp_master_breakpoint)
9599         (create_std_terminate_master_breakpoint)
9600         (create_exception_master_breakpoint): Use all_objfiles.
9601         * linux-thread-db.c (try_thread_db_load_from_pdir)
9602         (has_libpthread): Use all_objfiles.
9603         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9604         * linespec.c (iterate_over_all_matching_symtabs)
9605         (search_minsyms_for_name): Use all_objfiles.
9606         * maint.c (maintenance_info_sections): Use all_objfiles.
9607         * main.c (captured_main_1): Use all_objfiles.
9608         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9609         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9610         * guile/scm-pretty-print.c
9611         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9612         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9613         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9614         (maintenance_print_msymbols): Use all_objfiles.
9615         * source.c (select_source_symtab): Use all_objfiles.
9616         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9617         * symfile.c (remove_symbol_file_command)
9618         (expand_symtabs_matching, map_symbol_filenames): Use
9619         all_objfiles.
9620         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9621         all_objfiles.
9622         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9623         * objc-lang.c (find_methods): Use all_objfiles.
9624         * objfiles.c (have_partial_symbols, have_full_symbols)
9625         (have_minimal_symbols, qsort_cmp)
9626         (default_iterate_over_objfiles_in_search_order): Use
9627         all_objfiles.
9628         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9629         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9630         (maintenance_check_psymtabs): Use all_objfiles.
9631         (ALL_PSYMTABS): Remove.
9632         * compile/compile-object-run.c (do_module_cleanup): Use
9633         all_objfiles.
9634         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9635         * cp-support.c (add_symbol_overload_list_qualified): Use
9636         all_objfiles.
9637         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9638         Use all_objfiles.
9639         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9640         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9641         all_objfiles.
9642         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9643         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9644         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9645         Uses all_objfiles.
9646         * solib.c (solib_read_symbols): Use all_objfiles
9647
9648 2019-01-09  Tom Tromey  <tom@tromey.com>
9649
9650         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9651         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9652         all_objfiles.
9653         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9654         * symmisc.c (print_symbol_bcache_statistics)
9655         (print_objfile_statistics, maintenance_print_objfiles)
9656         (maintenance_info_symtabs, maintenance_check_symtabs)
9657         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9658         all_objfiles.
9659         * source.c (forget_cached_source_info): Use all_objfiles.
9660         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9661         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9662         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9663         * objfiles.c (update_section_map): Use all_objfiles.
9664         (shared_objfile_contains_address_p): Likewise.
9665         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9666         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9667
9668 2019-01-09  Tom Tromey  <tom@tromey.com>
9669
9670         * common/next-iterator.h: New file.
9671         * objfiles.h (class all_objfiles): New.
9672         (struct objfile_iterator): New.
9673
9674 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9675
9676         * NEWS: Move the description of the changed "frame", "select-frame",
9677          and "info frame" commands to the Changed commands section.
9678
9679 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9680
9681         * gdbtypes.c (check_stub_method_group): Remove handling of old
9682         mangling schemes.
9683         * linespec.c (find_methods): Likewise.
9684         * stabsread.c (read_member_functions): Likewise.
9685         * valops.c (search_struct_method): Likewise.
9686         (value_struct_elt_for_reference): Likewise.
9687         * NEWS: Mention this change.
9688
9689 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9690
9691         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9692         print_source_lines.
9693         * source.c (print_source_lines_base): Update line number check.
9694         (print_source_lines): New function.
9695         (source_lines_range::source_lines_range): New function.
9696         * source.h (class source_lines_range): New class.
9697         (print_source_lines): New declaration.
9698
9699 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9700
9701         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9702
9703 2019-01-08  Tom Tromey  <tom@tromey.com>
9704             Simon Marchi  <simon.marchi@ericsson.com>
9705
9706         PR gdb/24060
9707         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9708         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9709         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9710         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9711         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9712         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9713
9714 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9715
9716         * source.c (select_source_symtab): Move header comment to
9717         declaration in source.h.
9718         (forget_cached_source_info_for_objfile): Likewise.
9719         (forget_cached_source_info): Likewise.
9720         (identify_source_line): Likewise.
9721         * source.h (identify_source_line): Move declaration from symtab.h
9722         and add comment from source.c
9723         (print_source_lines): Likewise.
9724         (forget_cached_source_info_for_objfile): Likewise.
9725         (forget_cached_source_info): Likewise.
9726         (select_source_symtab): Likewise.
9727         (enum print_source_lines_flag): Move definition from symtab.h.
9728         * symtab.h (identify_source_line): Move declaration to source.h.
9729         (print_source_lines): Likewise.
9730         (forget_cached_source_info_for_objfile): Likewise.
9731         (forget_cached_source_info): Likewise.
9732         (select_source_symtab): Likewise.
9733         (enum print_source_lines_flag): Move definition to source.h.
9734         * tui/tui-hooks.c: Add 'source.h' include.
9735
9736 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9737
9738         * source.c (print_source_lines_base): Handle requests to print
9739         reverse line number sequences, and guard against empty lines
9740         string.
9741
9742 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9743
9744         * source.c (print_source_lines_base): Fix skip of '\r' if next
9745         character is '\n'.
9746
9747 2019-01-06  Tom Tromey  <tom@tromey.com>
9748
9749         * c-exp.y (struct c_parse_state) <macro_original_text,
9750         expansion_obstack>: New member.
9751         (macro_original_text, expansion_obstack): Remove globals.
9752         (scan_macro_expansion, scanning_macro_expansion)
9753         (finished_macro_expansion): Update.
9754         (scan_macro_cleanup): Remove.
9755         (yylex, c_parse): Update.
9756
9757 2019-01-06  Tom Tromey  <tom@tromey.com>
9758
9759         * c-exp.y (struct c_parse_state) <strings>: New member.
9760         (operator_stoken): Update.
9761
9762 2019-01-06  Tom Tromey  <tom@tromey.com>
9763
9764         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9765         (union type_stack_elt) <typelist_val>: Now a pointer to
9766         std::vector.
9767         (type_stack_cleanup): Don't declare.
9768         (push_typelist): Update.
9769         * parse.c (pop_typelist): Return a std::vector.
9770         (push_typelist): Take a std::vector.
9771         (follow_types): Update.  Do not free args.
9772         (type_stack_cleanup): Remove.
9773         * c-exp.y (struct c_parse_state): New.
9774         (cpstate): New global.
9775         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9776         (nonempty_typelist): Update.
9777         (func_mod): Create a new vector.
9778         (c_parse): Create a c_parse_state.
9779         (check_parameter_typelist): Do not delete params.
9780         (function_method): Update.  Do not delete type_list.
9781
9782 2019-01-06  Tom Tromey  <tom@tromey.com>
9783
9784         PR gdb/28155:
9785         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9786         check_typedef.
9787         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9788         (print_return_value): Likewise.
9789
9790 2019-01-05  Tom Tromey  <tom@tromey.com>
9791
9792         * contrib/cleanup_check.py: Remove.
9793         * contrib/gcc-with-excheck: Remove.
9794         * contrib/exsummary.py: Remove.
9795         * contrib/excheck.py: Remove.
9796
9797 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9798
9799         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9800         NULL. Initialize tpprev to NULL instead of assigning it
9801         to NULL on the next statement.
9802         * windows-nat.c (windows_delete_thread): Remove check for
9803         main_thread_id before printing thread exit notifications.
9804         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9805         Remove thread ID check against main_thread_id.
9806         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9807         windows_delete_thread.
9808         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9809
9810 2019-01-04  Tom Tromey  <tom@tromey.com>
9811
9812         * compile/compile.c (_initialize_compile): Use upper case for
9813         metasyntactic variables.
9814         * symmisc.c (_initialize_symmisc): Use upper case for
9815         metasyntactic variables.
9816         * psymtab.c (_initialize_psymtab): Use upper case for
9817         metasyntactic variables.
9818         * demangle.c (demangle_command): Use upper case for metasyntactic
9819         variables.
9820         (_initialize_demangler): Likewise.
9821         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9822         variables.
9823
9824 2019-01-03  Tom Tromey  <tom@tromey.com>
9825
9826         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9827
9828 2019-01-03  Tom Tromey  <tom@tromey.com>
9829
9830         * python/py-symtab.c (salpy_str): Update.
9831         (struct salpy_sal_object) <symtab>: Now a PyObject.
9832         (salpy_dealloc): Update.
9833         (del_objfile_sal): Use gdbpy_ref.
9834
9835 2019-01-03  Tom Tromey  <tom@tromey.com>
9836
9837         * python/py-type.c (convert_field): Use new_reference.  Return
9838         gdbpy_ref.
9839         (make_fielditem): Return gdbpy_ref.
9840         (typy_fields): Update.
9841         (typy_getitem): Update.
9842         (field_name): Return gdbpy_ref.  Use new_reference.
9843         (typy_iterator_iternext): Update.
9844
9845 2019-01-03  Tom Tromey  <tom@tromey.com>
9846
9847         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9848
9849 2019-01-03  Tom Tromey  <tom@tromey.com>
9850
9851         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9852         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9853         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9854         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9855         (pspy_set_type_printers): Likewise.
9856         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9857         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9858         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9859         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9860         (objfpy_set_type_printers): Likewise.
9861
9862 2019-01-03  Tom Tromey  <tom@tromey.com>
9863
9864         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9865         (gdbpy_print_stack): Use gdbpy_err_fetch.
9866         * python/python-internal.h (class gdbpy_err_fetch): New class.
9867         (class gdbpy_enter) <m_error_type, m_error_value,
9868         m_error_traceback>: Remove.
9869         <m_error>: New member.
9870         (gdbpy_exception_to_string): Don't declare.
9871         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9872         * python/py-value.c (convert_value_from_python): Use
9873         gdbpy_err_fetch.
9874         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9875         gdbpy_exception_to_string.
9876         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9877         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9878         gdbpy_err_fetch.
9879
9880 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9881
9882         * linux-nat.c (delete_lwp_cleanup): Delete.
9883         (struct lwp_deleter): New struct.
9884         (lwp_info_up): New typedef.
9885         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9886         lwp_info_up.
9887
9888 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9889
9890         * linux-fork.c (class scoped_switch_fork_info): New class.
9891         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9892
9893 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9894
9895         * valops.c (find_overload_match): Remove use of null_cleanup, and
9896         calls to do_cleanups.
9897
9898 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9899
9900         * compile/compile-cplus-types.c
9901         (compile_cplus_instance::decl_name): Handle changes to
9902         cp_func_name.
9903         * cp-support.c (cp_func_name): Update header comment, update
9904         return type.
9905         * cp-support.h (cp_func_name): Update return type in declaration.
9906         * valops.c (find_overload_match): Move temp_func local to top
9907         level of function and change its type.  Use temp_func to hold and
9908         delete temporary string obtained from cp_func_name.
9909
9910 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9911
9912         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9913         gdb::char_vector, remove cleanup, and update uses of `msg`.
9914
9915 2019-01-03  Jim Wilson  <jimw@sifive.com>
9916
9917         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9918
9919 2019-01-02  Tom Tromey  <tom@tromey.com>
9920
9921         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9922         (tdesc_parse_xml): Remove cleanups.
9923         * target-descriptions.h (make_cleanup_free_target_description):
9924         Don't declare.
9925         (target_desc_deleter): New struct.
9926         (target_desc_up): New typedef.
9927         * target-descriptions.c (target_desc_deleter::operator()): Rename
9928         from free_target_description.
9929         (make_cleanup_free_target_description): Remove.
9930
9931 2019-01-02  Tom Tromey  <tom@tromey.com>
9932
9933         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9934         constructor, destructor.
9935         (linespec_parser): Remove typedef.
9936         (~linespec_parser): Rename from linespec_parser_delete.
9937         (linespec_lex_to_end, linespec_complete_label)
9938         (linespec_complete): Update.
9939         (decode_line_full): Remove cleanups.
9940         (decode_line_1): Update.
9941
9942 2019-01-02  Tom Tromey  <tom@tromey.com>
9943
9944         * python/python-internal.h (inferior_to_inferior_object): Change
9945         return type.
9946         * python/py-exitedevent.c (create_exited_event_object): Update.
9947         * python/py-inferior.c (inferior_to_inferior_object): Return
9948         gdbpy_ref.
9949         (python_new_inferior, python_inferior_deleted)
9950         (thread_to_thread_object, delete_thread_object)
9951         (build_inferior_list, gdbpy_selected_inferior): Update.
9952         * python/py-infthread.c (create_thread_object): Update.  Also fail
9953         if inferior_to_inferior_object fails.
9954
9955 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9956
9957         * inferior.h (class inferior) <displaced_step_state>: New field.
9958         * infrun.h (struct displaced_step_state): Move here from
9959         infrun.c.  Initialize fields, add constructor.
9960         <inf>: Remove field.
9961         <reset>: New method.
9962         * infrun.c (struct displaced_step_inferior_state): Move to
9963         infrun.h.
9964         (displaced_step_inferior_states): Remove.
9965         (get_displaced_stepping_state): Adust.
9966         (displaced_step_in_progress_any_inferior): Adjust.
9967         (displaced_step_in_progress_thread): Adjust.
9968         (displaced_step_in_progress): Adjust.
9969         (add_displaced_stepping_state): Remove.
9970         (get_displaced_step_closure_by_addr): Adjust.
9971         (remove_displaced_stepping_state): Remove.
9972         (infrun_inferior_exit): Call displaced_step_state.reset.
9973         (use_displaced_stepping): Don't check for NULL.
9974         (displaced_step_prepare_throw): Call
9975         get_displaced_stepping_state.
9976         (displaced_step_fixup): Don't check for NULL.
9977         (prepare_for_detach): Don't check for NULL.
9978
9979 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9980
9981         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9982          in case of call that did not complete.
9983
9984 2019-01-02  Andrey Utkin  <autkin@undo.io>
9985
9986         * symfile.c (find_separate_debug_file): Fix search of debug files for
9987         remote debuggee.
9988
9989 2019-01-02  Tom Tromey  <tom@tromey.com>
9990
9991         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9992         indentation.
9993         * python/py-frame.c (frapy_older): Remove cast.
9994         (frapy_newer): Likewise.
9995         * python/py-breakpoint.c (local_setattro): Remove cast.
9996         * python/py-arch.c (archpy_name): Remove local variable.
9997         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9998
9999 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10000
10001         * unittests/basic_string_view/element_access/char/empty.cc:
10002         Fix year range in copyright header.
10003
10004 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10005
10006         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10007         Delete.
10008         <operator==>: Update with for removed field.
10009         <hash>: Likewise.
10010         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10011         <isa_features>: ...this.
10012         <abi_features>: New field.
10013         (riscv_isa_flen): Update comment.
10014         (riscv_abi_xlen): New declaration.
10015         (riscv_abi_flen): New declaration.
10016         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10017         isa_features.
10018         (riscv_abi_xlen): New function.
10019         (riscv_isa_flen): Update to get answer from isa_features.
10020         (riscv_abi_flen): New function.
10021         (riscv_has_fp_abi): Update to get answer from abi_features.
10022         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10023         xlen and flen.
10024         (riscv_call_info) <xlen, flen>: Update comment.
10025         (riscv_call_arg_struct): Remove invalid assertions
10026         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10027         is removed.
10028         (riscv_gdbarch_init): Gather isa features and abi features
10029         separately, ensure both match on the gdbarch when reusing an old
10030         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10031         a target with 64-bit float hardware.
10032
10033 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10034
10035         * source.c (search_command_helper): Stop reverse search
10036         when line 1 has been searched.
10037
10038 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10039
10040         * record-full.c (record_full_base_target::close): Rewrite
10041         record_full_core_buf_list free logic.
10042
10043 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10044
10045         * break-catch-syscall.c (print_one_catch_syscall): xfree
10046         the last text.
10047
10048 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10049
10050         * top.c (print_gdb_version): Update Copyright year in version
10051         message.
10052
10053 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10054
10055         Update copyright year range in all GDB files.
10056
10057 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10058
10059         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10060
10061 For older changes see ChangeLog-2018.
10062 \f
10063 Local Variables:
10064 mode: change-log
10065 left-margin: 8
10066 fill-column: 74
10067 version-control: never
10068 coding: utf-8
10069 End:
10070