gdb/ChangeLog

   1 2019-04-04  Tom Tromey  <tom@tromey.com>
   2
   3         * parser-defs.h (struct parser_state) <start_arglist,
   4         end_arglist>: New methods.
   5         <arglist_len, m_funcall_chain>: New members.
   6         (arglist_len, start_arglist, end_arglist): Don't declare.
   7         * parse.c (arglist_len, funcall_chain): Remove global.
   8         (start_arglist, end_arglist): Remove functions.
   9         (parse_exp_in_context): Update.
  10         * p-exp.y: Update rules.
  11         * m2-exp.y: Update rules.
  12         * go-exp.y: Update rules.
  13         * f-exp.y: Update rules.
  14         * d-exp.y: Update rules.
  15         * c-exp.y: Update rules.
  16
  17 2019-04-04  Tom Tromey  <tom@tromey.com>
  18
  19         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
  20         lex_operator, push_back>: New methods.
  21         Update all rules.
  22         (rust_parser::lex_hex, lex_escape): Rename and update.
  23         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
  24         (rust_parser::lex_operator): Rename and update.
  25         (rust_parser::lex_number, rustyylex, rustyyerror)
  26         (rust_lex_test_init, rust_lex_test_sequence)
  27         (rust_lex_test_push_back, rust_lex_tests): Update.
  28         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
  29         parameter.
  30         <lexptr, prev_lexptr>: New members.
  31         (lexptr, prev_lexptr): Don't declare.
  32         * parse.c (lexptr, prev_lexptr): Remove globals.
  33         (parse_exp_in_context): Update.
  34         * p-exp.y (yylex, yyerror): Update.
  35         * m2-exp.y (parse_number, yylex, yyerror): Update.
  36         * go-exp.y (lex_one_token, yyerror): Update.
  37         * f-exp.y (match_string_literal, yylex, yyerror): Update.
  38         * d-exp.y (lex_one_token, yyerror): Update.
  39         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
  40         (lex_one_token, yyerror): Update.
  41         * ada-lex.l (YY_INPUT): Update.
  42         (rewind_to_char): Update.
  43         * ada-exp.y (yyerror): Update.
  44
  45 2019-04-04  Tom Tromey  <tom@tromey.com>
  46
  47         * rust-exp.y (rustyylex, rust_lex_tests): Update.
  48         * parser-defs.h (struct parser_state) <parser_state>: Add new
  49         parameter.
  50         <comma_terminates>: New member.
  51         (comma_terminates): Don't declare global.
  52         * parse.c (comma_terminates): Remove global.
  53         (parse_exp_in_context): Update.
  54         * p-exp.y (yylex): Update.
  55         * m2-exp.y (yylex): Update.
  56         * go-exp.y (lex_one_token): Update.
  57         * f-exp.y (yylex): Update.
  58         * d-exp.y (lex_one_token): Update.
  59         * c-exp.y (lex_one_token): Update.
  60         * ada-lex.l: Update.
  61
  62 2019-04-04  Tom Tromey  <tom@tromey.com>
  63
  64         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
  65         (rustyylex, rust_lex_test_init, rust_lex_test_one)
  66         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
  67         * parser-defs.h (paren_depth): Don't declare.
  68         * parse.c (paren_depth): Remove global.
  69         (parse_exp_in_context): Update.
  70         * p-exp.y (paren_depth): New global.
  71         (pascal_parse): Initialize it.
  72         * m2-exp.y (paren_depth): New global.
  73         (m2_parse): Initialize it.
  74         * go-exp.y (paren_depth): New global.
  75         (go_parse): Initialize it.
  76         * f-exp.y (paren_depth): New global.
  77         (f_parse): Initialize it.
  78         * d-exp.y (paren_depth): New global.
  79         (d_parse): Initialize it.
  80         * c-exp.y (paren_depth): New global.
  81         (c_parse): Initialize it.
  82         * ada-lex.l (paren_depth): New global.
  83         (lexer_init): Initialize it.
  84
  85 2019-04-04  Tom Tromey  <tom@tromey.com>
  86
  87         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
  88         (rust_parser::convert_ast_to_type)
  89         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
  90         * parser-defs.h (struct parser_state) <parser_state>: Add
  91         parameters.  Initialize new members.
  92         <expression_context_block, expression_context_pc>: New members.
  93         * parse.c (expression_context_block, expression_context_pc):
  94         Remove globals.
  95         (parse_exp_in_context): Update.
  96         * p-exp.y: Update all rules.
  97         (yylex): Update.
  98         * m2-exp.y: Update all rules.
  99         (yylex): Update.
 100         * go-exp.y (yylex): Update.
 101         * f-exp.y (yylex): Update.
 102         * d-exp.y: Update all rules.
 103         (yylex): Update.
 104         * c-exp.y: Update all rules.
 105         (lex_one_token, classify_name, yylex, c_parse): Update.
 106         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
 107
 108 2019-04-04  Tom Tromey  <tom@tromey.com>
 109
 110         * gdbarch.h, gdbarch.c: Rebuild.
 111         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
 112         * stap-probe.h:
 113         (struct stap_parse_info): Replace "parser_state" with
 114         "expr_builder".
 115         * parser-defs.h (struct expr_builder): Rename from "parser_state".
 116         (parser_state): New class.
 117         * parse.c (expr_builder): Rename.
 118         (expr_builder::release): Rename.
 119         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
 120         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
 121         (write_exp_elt_longcst, write_exp_elt_floatcst)
 122         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
 123         (write_exp_string_vector, write_exp_bitstring)
 124         (write_exp_msymbol, mark_struct_expression)
 125         (write_dollar_variable)
 126         (insert_type_address_space, increase_expout_size): Replace
 127         "parser_state" with "expr_builder".
 128         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
 129         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
 130         "parser_state" with "expr_builder".
 131
 132 2019-04-04  Tom Tromey  <tom@tromey.com>
 133
 134         * rust-exp.y: Replace "parse_language" with method call.
 135         * p-exp.y:
 136         (yylex): Replace "parse_language" with method call.
 137         * m2-exp.y:
 138         (yylex): Replace "parse_language" with method call.
 139         * go-exp.y (classify_name): Replace "parse_language" with method
 140         call.
 141         * f-exp.y (yylex): Replace "parse_language" with method call.
 142         * d-exp.y (lex_one_token): Replace "parse_language" with method
 143         call.
 144         * c-exp.y:
 145         (lex_one_token, classify_name, yylex): Replace "parse_language"
 146         with method call.
 147         * ada-exp.y (find_primitive_type, type_char)
 148         (type_system_address): Replace "parse_language" with method call.
 149
 150 2019-04-04  Tom Tromey  <tom@tromey.com>
 151
 152         * rust-exp.y: Replace "parse_gdbarch" with method call.
 153         * parse.c (write_dollar_variable, insert_type_address_space):
 154         Replace "parse_gdbarch" with method call.
 155         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
 156         call.
 157         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
 158         call.
 159         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
 160         "parse_gdbarch" with method call.
 161         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
 162         with method call.
 163         * f-exp.y (parse_type, parse_f_type, yylex): Replace
 164         "parse_gdbarch" with method call.
 165         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
 166         "parse_gdbarch" with method call.
 167         * c-exp.y (parse_type, parse_number, classify_name): Replace
 168         "parse_gdbarch" with method call.
 169         * ada-lex.l: Replace "parse_gdbarch" with method call.
 170         * ada-exp.y (parse_type, find_primitive_type, type_char)
 171         (type_system_address): Replace "parse_gdbarch" with method call.
 172
 173 2019-04-04  Tom Tromey  <tom@tromey.com>
 174
 175         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
 176         * stap-probe.c (stap_parse_argument): Update.
 177         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
 178         initial_size parameter.
 179         * rust-exp.y (rust_lex_tests): Update.
 180         * parse.c (parser_state): Update.
 181         (parse_exp_in_context): Update.
 182         * parser-defs.h (struct parser_state) <parser_state>: Remove
 183         "initial_size" parameter.
 184
 185 2019-04-04  Tom Tromey  <tom@tromey.com>
 186
 187         * parser-defs.h (increase_expout_size): Don't declare.
 188         * parse.c (increase_expout_size): Now static.
 189
 190 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
 191
 192         * gnu-nat.c (gnu_nat_target::wait): Fix
 193         target_waitstatus_to_string call.
 194
 195 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 196
 197         * eval.c (evaluate_subexp_standard): Handle internal functions
 198         during Fortran function call handling.
 199
 200 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 201
 202         * NEWS: Mention new internal functions.
 203         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
 204         (read_base_type): Use dwarf2_init_complex_target_type.
 205         * value.c (creal_internal_fn): New function.
 206         (cimag_internal_fn): New function.
 207         (_initialize_values): Register new internal functions.
 208
 209 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 210
 211         * infrun.c (stop_all_threads): If debug_infrun, always
 212         trace the wait status after wait_one, using
 213         target_waitstatus_to_string and target_pid_to_str.
 214         (handle_inferior_event): Replace various trace of
 215         wait status kind by a single trace.
 216         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
 217         wait status kind image by target_waitstatus_to_string.
 218         * target/waitstatus.c (target_waitstatus_to_string): Fix
 219         obsolete comment.
 220
 221 2019-04-01  Tom Tromey  <tromey@adacore.com>
 222
 223         PR symtab/23331:
 224         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
 225
 226 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
 227             Pedro Alves  <palves@redhat.com>
 228
 229         * top.c (quit_force): Call 'finalize_values'.
 230         * value.c (finalize_values): New function.
 231         * value.h (finalize_values): Declare.
 232
 233 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
 234
 235         * NEWS: Announce $_gdb_major and $_gdb_minor.
 236
 237         * top.c (init_gdb_version_vars): New function.
 238         (gdb_init): Call init_gdb_version_vars.
 239
 240 2019-03-29  Tom Tromey  <tromey@adacore.com>
 241
 242         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
 243         help text.  Remove dead code.
 244
 245 2019-03-29  Keith Seitz  <keiths@redhat.com>
 246
 247         From Siddhesh Poyarekar:
 248         * f-lang.h (f77_get_upperbound): Return LONGEST.
 249         (f77_get_lowerbound): Likewise.
 250         * f-typeprint.c (f_type_print_varspec_suffix): Expand
 251         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
 252         print them.
 253         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
 254         plongest to format print it.
 255         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
 256         (f77_get_upperbound): Likewise.
 257         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
 258         LOWER_BOUND to LONGEST.
 259         (f77_create_arrayprint_offset_tbl): Likewise.
 260
 261 2019-03-29  Keith Seitz  <keiths@redhat.com>
 262
 263         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
 264         %s/pulongest for TYPE_LENGTH instead of %d in format
 265         strings.
 266         * ada-typerint.c (ada_print_type): Likewise.
 267         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
 268         * compile/compile-c-support.c (generate_register_struct): Likewise.
 269         * gdbtypes.c (recursive_dump_type): Likewise.
 270         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
 271         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
 272         instead of %d in format strings.
 273         * riscv-tdep.c (riscv_type_alignment): Cast second argument
 274         to std::min to ULONGEST.
 275         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
 276         instead of %d in format strings.
 277         * tracepoint.c (info_scope_command): Likewise.
 278         * typeprint.c (print_offset_data::update)
 279         (print_offset_data::finish): Likewise.
 280         * xtensa-tdep.c (xtensa_store_return_value)
 281         (xtensa_push_dummy_call): Likewise.
 282
 283 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 284
 285         * windows-nat.c (display_selector): Fixed format specifications
 286         for 64-bit Cygwin.
 287
 288 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 289
 290         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 291
 292 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 293
 294         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 295         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 296         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 297         (nios2_linux_init_abi): Install it.
 298
 299 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 300
 301         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 302
 303 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 304
 305         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 306
 307 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 308             Tom Tromey  <tromey@adacore.com>
 309
 310         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 311
 312 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 313
 314         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 315         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 316         method to compute the bounds of range types. Also print "[evaluated]"
 317         if the bounds' values come from a dynamic evaluation.
 318
 319 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 320
 321         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 322         whitespace when pretty printing is on.
 323
 324 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 325
 326         * ppc-linux-nat.c: Add include.
 327
 328 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 329
 330         * NEWS: Mention AArch64 Pointer Authentication.
 331
 332 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 333
 334         * arm-linux-nat.c: Add include.
 335
 336 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 337
 338         * source-cache.c (source_cache::get_source_lines): Re-read
 339         fullname after calling open_source_file.
 340
 341 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 342
 343         * NEWS: Mention TLS support for FreeBSD.
 344
 345 2019-03-25  Tom Tromey  <tromey@adacore.com>
 346
 347         * minsyms.c (BUNCH_SIZE): Update comment.
 348         (~minimal_symbol_reader): Remove old comment.
 349         (compact_minimal_symbols): Update comment.
 350         (minimal_symbol_reader::install): Remove old comment.  Update
 351         other comments.
 352
 353 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 354
 355         * s390-linux-nat.c: Add include.
 356
 357 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 358
 359         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 360         Call linux_get_hwcap.
 361         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 362         Likewise.
 363         (aarch64_linux_get_hwcap): Remove function.
 364         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 365         declaration.
 366         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 367         linux_get_hwcap.
 368         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 369         * linux-tdep.c (linux_get_hwcap): Add function.
 370         (linux_get_hwcap2): Likewise.
 371         * linux-tdep.h (linux_get_hwcap): Add declaration.
 372         (linux_get_hwcap2): Likewise.
 373         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 374         (ppc_linux_get_hwcap2): Likewise.
 375         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 376         linux_get_hwcap.
 377         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 378         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 379         (ppc_linux_nat_target::read_description): Likewise.
 380         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 381         * s390-linux-nat.c: Likewise.
 382         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 383
 384 2019-03-24  Tom Tromey  <tom@tromey.com>
 385
 386         * ada-lang.c (standard_lookup): Simplify initialization.
 387         (ada_lookup_symbol_nonlocal): Simplify return.
 388         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 389         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 390         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 391         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 392         initialization.
 393         * solib.c (solib_global_lookup): Simplify.
 394         * symtab.c (null_block_symbol): Remove.
 395         (symbol_cache_lookup): Simplify returns.
 396         (lookup_language_this): Simplify returns.
 397         (lookup_symbol_aux): Simplify return.
 398         (lookup_local_symbol): Simplify returns.
 399         (lookup_global_symbol_from_objfile): Simplify return.
 400         (lookup_symbol_in_objfile_symtabs)
 401         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 402         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 403         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 404         * cp-namespace.c (cp_lookup_bare_symbol)
 405         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 406         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 407         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 408         (cp_lookup_symbol_via_imports): Simplify initialization.
 409         (find_symbol_in_baseclass): Likewise.
 410         * symtab.h (null_block_symbol): Remove.
 411         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 412         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 413         (d_lookup_symbol_module): Likewise.
 414         (find_symbol_in_baseclass): Simplify initialization.
 415
 416 2019-03-24  Tom Tromey  <tom@tromey.com>
 417
 418         * expression.h: Don't include symtab.h.
 419         (struct block): Forward declare.
 420
 421 2019-03-24  Tom Tromey  <tom@tromey.com>
 422
 423         * c-exp.y (typebase): Remove casts.
 424         * gdbtypes.c (lookup_unsigned_typename, )
 425         (lookup_signed_typename): Remove cast.
 426         * eval.c (parse_to_comma_and_eval): Remove cast.
 427         * parse.c (write_dollar_variable): Remove cast.
 428         * block.h (struct block) <superblock>: Now const.
 429         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 430         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 431         (map_block): Make "block" const.
 432         * symfile.h (struct quick_symbol_functions)
 433         <map_matching_symbols>: Constify block argument to "callback".
 434         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 435         const.
 436         (find_pc_sect_compunit_symtab): Make "b" const.
 437         (find_symbol_at_address): Likewise.
 438         (search_symbols): Likewise.
 439         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 440         (dw2_debug_names_lookup_symbol): Likewise.
 441         (dw2_map_matching_symbols): Update.
 442         * p-valprint.c (pascal_val_print): Remove "block".
 443         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 444         (aux_add_nonlocal_symbols): Make "block" const.
 445         (resolve_subexp): Remove cast.
 446         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 447         const.
 448         (iterate_over_file_blocks): Likewise.
 449         * f-exp.y (%union) <bval>: Remove.
 450         * coffread.c (patch_opaque_types): Make "b" const.
 451         * spu-tdep.c (spu_catch_start): Make "block" const.
 452         * c-valprint.c (print_unpacked_pointer): Remove "block".
 453         * symmisc.c (dump_symtab_1): Make "b" const.
 454         (block_depth): Make "block" const.
 455         * d-exp.y (%union) <bval>: Remove.
 456         * cp-support.h (cp_lookup_rtti_type): Update.
 457         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 458         * psymtab.c (psym_lookup_symbol): Make "block" const.
 459         (maintenance_check_psymtabs): Make "b" const.
 460         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 461         (enumerate_locals, enumerate_args): Update.
 462         * python/py-symtab.c (stpy_global_block): Make "block" const.
 463         (stpy_static_block): Likewise.
 464         * inline-frame.c (block_starting_point_at): Make "new_block"
 465         const.
 466         * block.c (find_block_in_blockvector): Make return type const.
 467         (blockvector_for_pc_sect): Make "b" const.
 468         (find_block_in_blockvector): Make "b" const.
 469
 470 2019-03-23  Tom Tromey  <tom@tromey.com>
 471
 472         * varobj.c (varobj_create): Update.
 473         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 474         * printcmd.c (display_command, do_one_display): Don't reset
 475         innermost_block.
 476         * parser-defs.h (enum innermost_block_tracker_type): Move to
 477         expression.h.
 478         (innermost_block): Update comment.
 479         * parse.c (parse_exp_1): Add tracker_types parameter.
 480         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 481         tracker_types parameter.  Reset innermost_block.
 482         (parse_exp_in_context): Remove.
 483         (parse_expression_for_completion): Update.
 484         * objfiles.c (~objfile): Don't reset expression_context_block or
 485         innermost_block.
 486         * expression.h (enum innermost_block_tracker_type): Move from
 487         parser-defs.h.
 488         (parse_exp_1): Add tracker_types parameter.
 489         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 490         reset innermost_block.
 491
 492 2019-03-23  Tom Tromey  <tom@tromey.com>
 493
 494         * objfiles.h: Include bcache.h.
 495
 496 2019-03-23  Tom Tromey  <tom@tromey.com>
 497
 498         * linespec.c (get_current_search_block): Use
 499         scoped_restore_current_language.
 500         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 501
 502 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 503             Jiong Wang  <jiong.wang@arm.com>
 504
 505         * aarch64-linux-tdep.c
 506         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 507         section.
 508         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 509
 510 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 511             Jiong Wang  <jiong.wang@arm.com>
 512
 513         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 514         instructions.
 515         (aarch64_analyze_prologue_test): Add PACIASP test.
 516         (aarch64_prologue_prev_register): Unmask PC value.
 517
 518 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 519             Jiong Wang  <jiong.wang@arm.com>
 520
 521         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 522         (aarch64_dwarf2_prev_register): Unmask PC value.
 523         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 524         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 525         DW_CFA_AARCH64_negate_ra_state.
 526         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 527
 528 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 529             Jiong Wang  <jiong.wang@arm.com>
 530
 531         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 532         registers.
 533         (aarch64_pseudo_register_name): Likewise.
 534         (aarch64_pseudo_register_type): Likewise.
 535         (aarch64_pseudo_register_reggroup_p): Likewise.
 536         (aarch64_gdbarch_init): Add pauth registers.
 537         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 538         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 539         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 540         (struct gdbarch_tdep): Add regnum for ra_state.
 541
 542 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 543             Jiong Wang  <jiong.wang@arm.com>
 544
 545         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 546
 547 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 548             Jiong Wang  <jiong.wang@arm.com>
 549
 550         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 551         function.
 552         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 553         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 554         (aarch64_gdbarch_init): Add puth registers.
 555         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 556         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 557         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 558
 559 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 560             Jiong Wang  <jiong.wang@arm.com>
 561
 562         * aarch64-linux-nat.c
 563         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 564         * aarch64-linux-tdep.c
 565         (aarch64_linux_core_read_description): Likewise.
 566         (aarch64_linux_get_hwcap): New function.
 567         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 568         (aarch64_linux_get_hwcap): New declaration.
 569
 570 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 571             Jiong Wang  <jiong.wang@arm.com>
 572
 573         * aarch64-linux-nat.c
 574         (aarch64_linux_nat_target::read_description): Add pauth param.
 575         * aarch64-linux-tdep.c
 576         (aarch64_linux_core_read_description): Likewise.
 577         * aarch64-tdep.c (struct target_desc): Add in pauth.
 578         (aarch64_read_description): Add pauth param.
 579         (aarch64_gdbarch_init): Likewise.
 580         * aarch64-tdep.h (aarch64_read_description): Likewise.
 581         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 582         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 583         * features/Makefile: Add new files.
 584         * features/aarch64-pauth.c: New file.
 585         * features/aarch64-pauth.xml: New file.
 586
 587 2019-03-20  Tom Tromey  <tromey@adacore.com>
 588
 589         * infrun.c (handle_inferior_event): Rename from
 590         handle_inferior_event_1.  Create a scoped_value_mark.
 591         (handle_inferior_event): Remove.
 592
 593 2019-03-19  Tom Tromey  <tromey@adacore.com>
 594
 595         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 596         * infrun.h (print_stop_event): Add "displays" parameter.
 597         * infrun.c (print_stop_event): Add "displays" parameter.
 598
 599 2019-03-19  Pedro Alves  <palves@redhat.com>
 600
 601         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 602         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 603         to -1.  Fix TABs vs spaces.
 604         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 605         * tui/tui-out.h (tui_ui_out) Add intro comments.
 606         <m_line, m_start_of_line>: In-class initialize, and add describing
 607         comment.
 608
 609 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 610
 611         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 612         variable names.
 613         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 614
 615 2019-03-18  Pedro Alves  <palves@redhat.com>
 616             Eli Zaretskii <eliz@gnu.org>
 617
 618         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 619         m_line and m_start_of_line.
 620
 621 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 622
 623         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 624         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 625         it returns a newline.  This fixes a regression in TU mode, whereby
 626         the next line is output on the same screen line as the user input.
 627
 628 2019-03-18  Tom Tromey  <tromey@adacore.com>
 629
 630         * minsyms.c (minimal_symbol_reader::install): Remove call to
 631         obstack_blank.
 632
 633 2019-03-18  Pedro Alves  <palves@redhat.com>
 634
 635         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 636         New globals.
 637         (apply_style): New, factored out from ...
 638         (apply_ansi_escape): ... this.  Handle reverse video mode.
 639         (tui_set_reverse_mode): New function.
 640         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 641         * tui/tui-winsource.c (tui_show_source_line): Use
 642         tui_set_reverse_mode instead of setting A_STANDOUT.
 643         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 644         New setter methods.
 645
 646 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 647
 648         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 649         Handle tabs.
 650
 651 2019-03-18  Tom Tromey  <tromey@adacore.com>
 652
 653         * ada-lang.c (empty_array): Add "high" parameter.
 654         (ada_evaluate_subexp): Update.
 655
 656 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 657
 658         * unittests/string_view-selftests.c: Define
 659         _initialize_string_view_selftests unconditionally.
 660
 661 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 662
 663         PR gdb/24350
 664         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 665
 666 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 667
 668         PR gdb/24351
 669         * windows-nat.c (display_selector): Fix format specifiers.
 670
 671 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 672
 673         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 674         tui_refill_source_window instead of tui_refresh_win, to update the
 675         current execution line.  This fixes redisplay of the current line
 676         when stepping through the code with "next" or "step".
 677
 678 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 679
 680         * source-cache.c (source_cache::get_source_lines): Call
 681         find_source_lines to initialize s->nlines.  This fixes vertical
 682         scrolling of TUI source window when the DOWN arrow is pressed.
 683
 684 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 685
 686         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 687         linux-thread-db.c (_initialize_thread_db): Likewise.
 688
 689 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 690
 691         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 692         wclrtoeol in tui_show_source_line".  This reverts changes made in
 693         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 694
 695 2019-03-15  Tom Tromey  <tom@tromey.com>
 696
 697         * symtab.h (struct minimal_symbol): Derive from
 698         general_symbol_info.
 699         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 700         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 701         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 702         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 703         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 704         (MSYMBOL_SEARCH_NAME): Update.
 705         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 706         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 707         * minsyms.c (minimal_symbol_reader::record_full): Update.
 708
 709 2019-03-15  Tom Tromey  <tom@tromey.com>
 710
 711         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 712
 713 2019-03-15  Tom Tromey  <tom@tromey.com>
 714
 715         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 716         unique_xmalloc_ptr.
 717         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 718         Update.
 719         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 720         (build_minimal_symbol_hash_tables)
 721         (minimal_symbol_reader::install): Update.
 722
 723 2019-03-15  Tom Tromey  <tom@tromey.com>
 724
 725         * symtab.c (create_demangled_names_hash): Update.
 726         (symbol_set_names): Update.
 727         * objfiles.h (struct objfile_per_bfd_storage)
 728         <demangled_names_hash>: Now an htab_up.
 729         * objfiles.c (objfile_per_bfd_storage): Simplify.
 730
 731 2019-03-15  Tom Tromey  <tom@tromey.com>
 732
 733         * objfiles.h (struct objfile_per_bfd_storage): Declare
 734         destructor.
 735         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 736         New.
 737         (get_objfile_bfd_data): Use new.  Don't initialize
 738         language_of_main.
 739         (free_objfile_per_bfd_storage): Remove.
 740         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 741
 742 2019-03-15  Tom Tromey  <tom@tromey.com>
 743
 744         * symfile.c (reread_symbols): Update.
 745         * objfiles.c (objfile::objfile): Update.
 746         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 747         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 748         comment.
 749         (minimal_symbol_reader::install): Update.
 750         (terminate_minimal_symbol_table): Remove.
 751         * jit.c (jit_object_close_impl): Update.
 752
 753 2019-03-15  Tom Tromey  <tom@tromey.com>
 754
 755         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 756         initializations.
 757
 758 2019-03-15  Tom Tromey  <tom@tromey.com>
 759
 760         * objfiles.h (struct objfile_per_bfd_storage)
 761         <demangled_hash_languages>: Now a bitset.
 762         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 763         (lookup_minimal_symbol): Update.
 764
 765 2019-03-15  Tom Tromey  <tom@tromey.com>
 766
 767         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 768         Don't return the symbol.
 769         * coffread.c (record_minimal_symbol): Use record_full.
 770
 771 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 772
 773         The MS-Windows port of ncurses fails to switch to a color pair if
 774         one or both of the colors are the implicit default colors.  This
 775         change records the default colors when TUI is initialized, and
 776         then specifies them explicitly when a color pair uses the default
 777         colors.  This allows color styling in TUI mode on MS-Windows.
 778
 779         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 780         ncurses_norm_attr.
 781         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 782         colors in ncurses_norm_attr.
 783         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 784         "none", replace it with the default color recorded in
 785         ncurses_norm_attr.
 786
 787 2019-03-14  Tom Tromey  <tromey@adacore.com>
 788
 789         * source-cache.h (class source_cache) <get_source_lines>: Return
 790         std::string.
 791         * source-cache.c (source_cache::extract_lines): Handle case where
 792         first_pos==npos.  Return std::string.
 793         (source_cache::get_source_lines): Update.
 794
 795 2019-03-14  Tom Tromey  <tromey@adacore.com>
 796
 797         * NEWS: Add item for "style sources" commands.
 798         * source-cache.c (source_cache::get_source_lines): Check
 799         source_styling.
 800         * cli/cli-style.c (source_styling): New global.
 801         (_initialize_cli_style): Add "style sources" commands.
 802         (show_style_sources): New function.
 803         * cli/cli-style.h (source_styling): Declare.
 804
 805 2019-03-14  Pedro Alves  <palves@redhat.com>
 806             Tom Tromey  <tromey@adacore.com>
 807
 808         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 809         * tui/tui-winsource.c (tui_refill_source_window): New function,
 810         from...
 811         (tui_horizontal_source_scroll): ... here.  Move some logic.
 812         * cli/cli-style.c (set_style_enabled): Notify new observable.
 813         * tui/tui-hooks.c (tui_redisplay_source): New function.
 814         (tui_attach_detach_observers): Attach or detach
 815         tui_redisplay_source.
 816         * observable.h (source_styling_changed): New observable.
 817         * observable.c: Define source_styling_changed observable.
 818
 819 2019-03-13  Tom Tromey  <tromey@adacore.com>
 820
 821         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 822         (i386_gnu_nat_target::store_registers): Update.
 823         * target-debug.h (target_debug_print_std_string): New macro.
 824         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 825         * windows-tdep.c (display_one_tib): Update.
 826         * tui/tui-stack.c (tui_make_status_line): Update.
 827         * top.c (print_inferior_quit_action): Update.
 828         * thread.c (thr_try_catch_cmd): Update.
 829         (add_thread_with_info): Update.
 830         (thread_target_id_str): Update.
 831         (thr_try_catch_cmd): Update.
 832         (thread_command): Update.
 833         (thread_find_command): Update.
 834         * record-btrace.c (record_btrace_target::info_record)
 835         (record_btrace_resume_thread, record_btrace_target::resume)
 836         (record_btrace_cancel_resume, record_btrace_step_thread)
 837         (record_btrace_target::wait, record_btrace_target::wait)
 838         (record_btrace_target::wait, record_btrace_target::stop): Update.
 839         * progspace.c (print_program_space): Update.
 840         * process-stratum-target.c
 841         (process_stratum_target::thread_address_space): Update.
 842         * linux-fork.c (linux_fork_mourn_inferior)
 843         (detach_checkpoint_command, info_checkpoints_command)
 844         (linux_fork_context): Update.
 845         (linux_fork_detach): Update.
 846         (class scoped_switch_fork_info): Update.
 847         (delete_checkpoint_command): Update.
 848         * infrun.c (follow_fork_inferior): Update.
 849         (follow_fork_inferior): Update.
 850         (proceed_after_vfork_done): Update.
 851         (handle_vfork_child_exec_or_exit): Update.
 852         (follow_exec): Update.
 853         (displaced_step_prepare_throw): Update.
 854         (displaced_step_restore): Update.
 855         (start_step_over): Update.
 856         (resume_1): Update.
 857         (clear_proceed_status_thread): Update.
 858         (proceed): Update.
 859         (print_target_wait_results): Update.
 860         (do_target_wait): Update.
 861         (context_switch): Update.
 862         (stop_all_threads): Update.
 863         (restart_threads): Update.
 864         (finish_step_over): Update.
 865         (handle_signal_stop): Update.
 866         (switch_back_to_stepped_thread): Update.
 867         (keep_going_pass_signal): Update.
 868         (print_exited_reason): Update.
 869         (normal_stop): Update.
 870         * inferior.c (inferior_pid_to_str): Change return type.
 871         (print_selected_inferior): Update.
 872         (add_inferior): Update.
 873         (detach_inferior): Update.
 874         * dummy-frame.c (fprint_dummy_frames): Update.
 875         * dcache.c (dcache_info_1): Update.
 876         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 877         (btrace_fetch, btrace_clear): Update.
 878         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 879         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 880         type.
 881         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 882         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 883         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 884         * gdbarch.c, gdbarch.h: Rebuild.
 885         * gdbarch.sh (core_pid_to_str): Change return type.
 886         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 887         return type.
 888         (windows_nat_target::pid_to_str): Change return type.
 889         (windows_delete_thread): Update.
 890         (windows_nat_target::attach): Update.
 891         (windows_nat_target::files_info): Update.
 892         * target-delegates.c: Rebuild.
 893         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 894         return type.
 895         (sol_thread_target::pid_to_str): Change return type.
 896         * remote.c (class remote_target) <pid_to_str>: Change return
 897         type.
 898         (remote_target::pid_to_str): Change return type.
 899         (extended_remote_target::attach, remote_target::remote_stop_ns)
 900         (remote_target::remote_notif_remove_queued_reply)
 901         (remote_target::push_stop_reply, remote_target::disable_btrace):
 902         Update.
 903         (extended_remote_target::attach): Update.
 904         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 905         type.
 906         (gdbsim_target::pid_to_str): Change return type.
 907         * ravenscar-thread.c (struct ravenscar_thread_target)
 908         <pid_to_str>: Change return type.
 909         (ravenscar_thread_target::pid_to_str): Change return type.
 910         * procfs.c (class procfs_target) <pid_to_str>: Change return
 911         type.
 912         (procfs_target::pid_to_str): Change return type.
 913         (procfs_target::attach): Update.
 914         (procfs_target::detach): Update.
 915         (procfs_target::fetch_registers): Update.
 916         (procfs_target::store_registers): Update.
 917         (procfs_target::wait): Update.
 918         (procfs_target::files_info): Update.
 919         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 920         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 921         return type.
 922         (nto_procfs_target::pid_to_str): Change return type.
 923         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 924         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 925         return type.
 926         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 927         (exit_lwp): Update.
 928         (attach_proc_task_lwp_callback, get_detach_signal)
 929         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 930         (linux_nat_target::resume, wait_lwp, stop_callback)
 931         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 932         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 933         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 934         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 935         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 936         type.
 937         (inf_ptrace_target::attach): Update.
 938         (inf_ptrace_target::files_info): Update.
 939         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 940         type.
 941         (go32_nat_target::pid_to_str): Change return type.
 942         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 943         (gnu_nat_target::wait): Update.
 944         (gnu_nat_target::wait): Update.
 945         (gnu_nat_target::resume): Update.
 946         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 947         (fbsd_nat_target::wait): Update.
 948         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 949         type.
 950         (darwin_nat_target::attach): Update.
 951         * corelow.c (class core_target) <pid_to_str>: Change return type.
 952         (core_target::pid_to_str): Change return type.
 953         * target.c (normal_pid_to_str): Change return type.
 954         (default_pid_to_str): Likewise.
 955         (target_pid_to_str): Change return type.
 956         (target_translate_tls_address): Update.
 957         (target_announce_detach): Update.
 958         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 959         return type.
 960         (bsd_uthread_target::pid_to_str): Change return type.
 961         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 962         type.
 963         (bsd_kvm_target::pid_to_str): Change return type.
 964         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 965         return type.
 966         (aix_thread_target::pid_to_str): Change return type.
 967         * target.h (struct target_ops) <pid_to_str>: Change return type.
 968         (target_pid_to_str, normal_pid_to_str): Likewise.
 969         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 970         type.
 971         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 972         type.
 973         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 974         return type.
 975         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 976         type.
 977         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 978         type.
 979         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 980         return type.
 981
 982 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 983
 984         * NEWS: Mention that the new default MI version is 3.  Mention
 985         changes to the output of commands and events that deal with
 986         multi-location breakpoints.
 987         * breakpoint.c: Include "mi/mi-out.h".
 988         (print_one_breakpoint): Change output syntax if using MI version
 989         >= 3.
 990         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 991         New.
 992         (mi_multi_location_breakpoint_output_fixed): New.
 993         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 994         (mi_cmd_fix_multi_location_breakpoint_output): New.
 995         (mi_multi_location_breakpoint_output_fixed): New.
 996         * mi/mi-cmds.c (mi_cmds): Register command
 997         -fix-multi-location-breakpoint-output.
 998         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 999         interpreter "mi".
1000
1001 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1002
1003         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1004         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1005         instantiate mi_ui_out based on interpreter name.
1006         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1007         * mi/mi-main.c (mi_load_progress): Likewise.
1008
1009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1010
1011         * NEWS: Combine separate "New targets" sections for 8.3.
1012
1013 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1014
1015         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1016         (ppcfbsd_init_abi): Install gdbarch
1017         "fetch_tls_load_module_address" and "get_thread_local_address"
1018         methods.
1019
1020 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1021
1022         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1023         (riscv_fbsd_init_abi): Install gdbarch
1024         "fetch_tls_load_module_address" and "get_thread_local_address"
1025         methods.
1026
1027 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1028
1029         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1030         (i386fbsd_init_abi): Install gdbarch
1031         "fetch_tls_load_module_address" and "get_thread_local_address"
1032         methods.
1033
1034 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1035
1036         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1037         (amd64fbsd_init_abi): Install gdbarch
1038         "fetch_tls_load_module_address" and "get_thread_local_address"
1039         methods.
1040
1041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1042
1043         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1044         (struct fbsd_pspace_data): New type.
1045         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1046         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1047         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1048         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1049         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1050
1051 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1052
1053         * gdbtypes.c (lookup_struct_elt): New function.
1054         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1055         * gdbtypes.h (struct struct_elt): New type.
1056         (lookup_struct_elt): New prototype.
1057
1058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1059
1060         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1061         remove disabled code block.
1062
1063 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1064
1065         * gdbarch.sh (get_thread_local_address): New method.
1066         * gdbarch.h, gdbarch.c: Regenerate.
1067         * target.c (target_translate_tls_address): Use
1068         gdbarch_get_thread_local_address if present instead of
1069         target::get_thread_local_address.
1070
1071 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1072
1073         * target.h (target::get_thread_local_address): Update comment.
1074
1075 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1076
1077         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1078         objfile->separate_debug_objfile_backlink if not NULL.
1079
1080 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1081
1082         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1083         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1084         (amd64bsd_store_inferior_registers): Likewise.
1085         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1086         Enable segment base registers.
1087         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1088         PT_GETFSBASE and PT_GETGSBASE.
1089         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1090         PT_SETGSBASE.
1091         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1092         segment base registers.
1093         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1094
1095 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1096
1097         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1098         Update calls to i386_target_description to add 'segments'
1099         parameter.
1100         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1101         add segment base registers.
1102         * arch/i386.c (i386_create_target_description): Add 'segments'
1103         parameter to enable segment base registers.
1104         * arch/i386.h (i386_create_target_description): Likewise.
1105         * features/i386/32bit-segments.xml: New file.
1106         * features/i386/32bit-segments.c: Generate.
1107         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1108         call to i386_target_description to add 'segments' parameter.
1109         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1110         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1111         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1112         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1113         if feature is present.
1114         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1115         Add 'segments' parameter to call to i386_target_description.
1116         (i386_target_description): Add 'segments' parameter to enable
1117         segment base registers.
1118         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1119         to call to i386_target_description.
1120         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1121         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1122         Define I386_NUM_REGS.
1123         (i386_target_description): Add 'segments' parameter to enable
1124         segment base registers.
1125
1126 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1127
1128         PR/24325
1129         * source-cache.c: #undef open and close, to avoid unresolved
1130         externals during linking.
1131
1132 2019-03-12  Tom Tromey  <tromey@adacore.com>
1133
1134         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1135         const.  Add initializers.
1136         (_initialize_remote): Don't initialize ptid globals.
1137
1138 2019-03-12  Pedro Alves  <palves@redhat.com>
1139
1140         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1141
1142 2019-03-12  Pedro Alves  <palves@redhat.com>
1143
1144         * cp-name-parser.y (main): Remove unused 'len' variable.
1145
1146 2019-03-12  Tom Tromey  <tromey@adacore.com>
1147
1148         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1149         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1150
1151 2019-03-12  Tom Tromey  <tromey@adacore.com>
1152
1153         * linux-nat.c (iterate_over_lwps): Update.
1154         (stop_callback): Remove parameter.
1155         (stop_wait_callback, detach_callback, resume_set_callback)
1156         (select_singlestep_lwp_callback, set_ignore_sigint)
1157         (status_callback, resumed_callback, resume_clear_callback)
1158         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1159         data parameter.
1160         (linux_nat_target::detach, linux_nat_target::resume)
1161         (linux_stop_and_wait_all_lwps, select_event_lwp)
1162         (linux_nat_filter_event, linux_nat_wait_1)
1163         (linux_nat_target::kill, linux_nat_target::stop)
1164         (linux_nat_target::stop): Update.
1165         (linux_nat_resume_callback): Change type.
1166         (resume_stopped_resumed_lwps, count_events_callback)
1167         (select_event_lwp_callback): Likewise.
1168         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1169         * arm-linux-nat.c (struct update_registers_data): Remove.
1170         (update_registers_callback): Change type.
1171         (arm_linux_insert_hw_breakpoint1): Update.
1172         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1173         parameter.
1174         (x86_linux_dr_set_addr): Update.
1175         (x86_linux_dr_set_control): Update.
1176         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1177         (iterate_over_lwps): Use gdb::function_view.
1178         * nat/aarch64-linux-hw-point.c (struct
1179         aarch64_dr_update_callback_param): Remove.
1180         (debug_reg_change_callback): Change type.
1181         (aarch64_notify_debug_reg_change): Update.
1182         * s390-linux-nat.c (s390_refresh_per_info): Update.
1183
1184 2019-03-11  Tom Tromey  <tromey@adacore.com>
1185
1186         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1187         redundant assignment to "this_cu".
1188
1189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1190
1191         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1192
1193 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1194
1195         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1196         from...
1197         (rank_one_type): ... this.
1198
1199 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1200
1201         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1202         from...
1203         (rank_one_type): ... this.
1204
1205 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1206
1207         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1208         from...
1209         (rank_one_type): ... this.
1210
1211 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1212
1213         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1214         from...
1215         (rank_one_type): ... this.
1216
1217 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1218
1219         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1220         from...
1221         (rank_one_type): ... this.
1222
1223 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1224
1225         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1226         from...
1227         (rank_one_type): ... this.
1228
1229 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1230
1231         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1232         from...
1233         (rank_one_type): ... this.
1234
1235 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1236
1237         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1238         from...
1239         (rank_one_type): ... this.
1240
1241 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1242
1243         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1244         from...
1245         (rank_one_type): ... this.
1246
1247 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1248
1249         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1250         from...
1251         (rank_one_type): ... this.
1252
1253 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1254
1255         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1256         from...
1257         (rank_one_type): ... this.
1258
1259 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1260
1261         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1262         from...
1263         (rank_one_type): ... this.
1264
1265 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1266
1267         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1268         inferior-events' shows the example events.
1269
1270 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1271
1272         Support styling on native MS-Windows console
1273
1274         PR/24315
1275         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1276         on MS-Windows if $TERM is not defined.
1277
1278         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1279
1280         * posix-hdep.c (gdb_console_fputs):
1281         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1282         functions.
1283         * ui-file.h (gdb_console_fputs): Add prototype.
1284
1285         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1286         back to fputs only if the former returns zero.
1287
1288 2019-03-07  Tom Tromey  <tom@tromey.com>
1289
1290         * symmisc.c (print_symbol_bcache_statistics): Update.
1291         (print_objfile_statistics): Update.
1292         * symfile.c (allocate_symtab): Update.
1293         * stabsread.c: Don't include bcache.h.
1294         * psymtab.h (struct psymbol_bcache): Don't declare.
1295         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1296         (psymbol_bcache_init, psymbol_bcache_free)
1297         (psymbol_bcache_get_bcache): Don't declare.
1298         * psymtab.c (struct psymbol_bcache): Remove.
1299         (psymtab_storage::psymtab_storage): Update.
1300         (psymtab_storage::~psymtab_storage): Update.
1301         (psymbol_bcache_init, psymbol_bcache_free)
1302         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1303         (add_psymbol_to_bcache): Update.
1304         (allocate_psymtab): Update.
1305         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1306         macro_cache>: No longer pointers.
1307         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1308         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1309         * macrotab.c (macro_bcache): Update.
1310         * macroexp.c: Don't include bcache.h.
1311         * gdbtypes.c (check_types_worklist): Update.
1312         (types_deeply_equal): Remove TRY/CATCH.  Update.
1313         * elfread.c (elf_symtab_read): Update.
1314         * dwarf2read.c: Don't include bcache.h.
1315         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1316         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1317         (print_bcache_statistics, bcache_memory_used): Don't declare.
1318         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1319         methods.  Rename all data members.
1320         * bcache.c (struct bcache): Move to bcache.h.
1321         (bcache::expand_hash_table): Rename from expand_hash_table.
1322         (bcache): Remove.
1323         (bcache::insert): Rename from bcache_full.
1324         (bcache::compare): Rename from bcache_compare.
1325         (bcache_xmalloc): Remove.
1326         (bcache::~bcache): Rename from bcache_xfree.
1327         (bcache::print_statistics): Rename from print_bcache_statistics.
1328         (bcache::memory_used): Rename from bcache_memory_used.
1329
1330 2019-03-07  Pedro Alves  <palves@redhat.com>
1331
1332         * infrun.c (normal_stop): Also check for
1333         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1334
1335 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1336
1337         * f-lang.c (value_from_host_double): Moved to...
1338         * value.c (value_from_host_double): ...here.
1339         * value.h (value_from_host_double): Declare.
1340         * guile/scm-math.c (vlscm_convert_typed_number): Use
1341         value_from_host_double.
1342         (vlscm_convert_number): Likewise.
1343         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1344         * python/py-value.c (convert_value_from_python): Likewise.
1345
1346 2019-03-06  Tom Tromey  <tom@tromey.com>
1347
1348         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1349
1350 2019-03-06  Tom Tromey  <tom@tromey.com>
1351
1352         * utils.h (free_current_contents): Don't declare.
1353         * utils.c (free_current_contents): Remove.
1354
1355 2019-03-06  Tom Tromey  <tom@tromey.com>
1356
1357         * top.c (quit_force): Update.
1358         * main.c (captured_command_loop): Update.
1359         * common/new-op.c (operator new): Update.
1360         * common/common-exceptions.c (struct catcher)
1361         <save_cleanup_chain>: Remove member.
1362         (exceptions_state_mc_init): Update.
1363         (exception_try_scope_entry): Return nullptr.
1364         (exception_try_scope_exit, exception_rethrow)
1365         (throw_exception_sjlj, throw_exception_cxx): Update.
1366         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1367         (all_cleanups, do_cleanups, discard_cleanups)
1368         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1369         (restore_cleanups, restore_final_cleanups): Don't declare.
1370         (do_final_cleanups): Remove parameter.
1371         * common/cleanups.c (cleanup_chain, make_cleanup)
1372         (make_cleanup_dtor, all_cleanups, do_cleanups)
1373         (discard_my_cleanups, discard_cleanups)
1374         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1375         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1376         (null_cleanup): Remove.
1377         (do_final_cleanups): Remove parameter.
1378
1379 2019-03-06  Tom Tromey  <tom@tromey.com>
1380
1381         * remote.c (remote_target::remote_parse_stop_reply): Use
1382         unique_xmalloc_ptr.
1383
1384 2019-03-06  Tom Tromey  <tom@tromey.com>
1385
1386         * stabsread.c (struct stabs_field_info): Rename from field_info.
1387         <list, fnlist>: Add initializers.
1388         <obstack>: New member.
1389         (read_member_functions, read_struct_fields, read_baseclasses):
1390         Allocate on obstack.  Don't use cleanups.
1391         (read_one_struct_field, read_member_functions, read_struct_fields)
1392         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1393         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1394         (read_struct_type): Update.
1395
1396 2019-03-06  Tom Tromey  <tom@tromey.com>
1397
1398         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1399         * common/filestuff.h (make_cleanup_close): Don't declare.
1400         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1401         Remove.
1402
1403 2019-03-06  Tom Tromey  <tom@tromey.com>
1404
1405         * solib-aix.c: Use make_scope_exit.
1406
1407 2019-03-06  Tom Tromey  <tom@tromey.com>
1408
1409         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1410         Use make_scope_exit.
1411
1412 2019-03-06  Tom Tromey  <tom@tromey.com>
1413
1414         * solib-svr4.c (disable_probes_interface): Remove parameter.
1415         (svr4_handle_solib_event): Use make_scope_exit.
1416
1417 2019-03-06  Tom Tromey  <tom@tromey.com>
1418
1419         * remote.c (struct stop_reply_deleter): Remove.
1420         (stop_reply_up): Update.
1421         (struct stop_reply): Derive from notif_event.  Don't typedef.
1422         <regcache>: Now a std::vector.
1423         (stop_reply_xfree): Remove.
1424         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1425         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1426         (remote_target::discard_pending_stop_replies): Use delete.
1427         (remote_target::remote_parse_stop_reply): Update.
1428         (remote_target::process_stop_reply): Update.
1429         * remote-notif.h (struct notif_event): Add virtual destructor.
1430         Remove "dtr" member.
1431         (struct notif_client) <alloc_event>: Return a unique_ptr.
1432         (notif_event_xfree): Don't declare.
1433         (notif_event_up): New typedef.
1434         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1435         (notif_event_xfree, do_notif_event_xfree): Remove.
1436         (remote_notif_state_xfree): Update.
1437
1438 2019-03-06  Tom Tromey  <tom@tromey.com>
1439
1440         * infrun.c (displaced_step_clear_cleanup): Now a
1441         forward_scope_exit type.
1442         (displaced_step_prepare_throw): Update.
1443         (displaced_step_fixup): Update.
1444
1445 2019-03-06  Tom Tromey  <tom@tromey.com>
1446
1447         * inferior.h (class inferior): Update comment.
1448         * gdbthread.h (class thread_info): Update comment.
1449
1450 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1451             Tom Tromey  <tom@tromey.com>
1452
1453         * stabsread.h (struct stab_section_list): Remove.
1454         (coffstab_build_psymtabs): Update.
1455         * dbxread.c (symbuf_sections): Now a std::vector.
1456         (sect_idx): New global.
1457         (fill_symbuf): Update.
1458         (coffstab_build_psymtabs): Change type of stabsects parameter.
1459         Update.
1460         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1461         std::vector.
1462         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1463         (coff_locate_sections): Update.
1464         (coff_symfile_read): Remove cleanups.  Update.
1465         (init_stringtab): Add storage parameter.
1466         (free_stringtab, free_stringtab_cleanup): Remove.
1467         (init_lineno): Add storage parameter.
1468         (free_linetab, free_linetab_cleanup): Remove.
1469
1470 2019-03-06  Pedro Alves  <palves@redhat.com>
1471
1472         * linux-fork.c (fork_info::clobber_regs): Delete.
1473         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1474         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1475         comment.  Adjust.
1476         (scoped_switch_fork_info::scoped_switch_fork_info)
1477         (checkpoint_command, linux_fork_context): Adjust
1478         fork_save_infrun_state calls.
1479
1480 2019-03-06  Pedro Alves  <palves@redhat.com>
1481
1482         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1483         (inf_has_multiple_threads): Return 'bool' and rewrite using
1484         inferior_info::threads().
1485
1486 2019-03-06  Pedro Alves  <palves@redhat.com>
1487
1488         * linux-fork.c: Include <list>.
1489         (fork_list): Now a std::list instance.
1490         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1491         (forks_exist_p, find_last_fork): Adjust.
1492         (new_fork): Delete.
1493         (one_fork_p): New.
1494         (add_fork): Adjust.
1495         (free_fork): Delete, folded into fork_info::~fork_info().
1496         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1497         Adjust.
1498         (init_fork_list): Delete.
1499         (linux_fork_killall, linux_fork_mourn_inferior)
1500         (linux_fork_detach, info_checkpoints_command): Adjust.
1501         (_initialize_linux_fork): No longer call init_fork_list.
1502
1503 2019-03-06  Pedro Alves  <palves@redhat.com>
1504
1505         * linux-fork.c (new_fork): New, split out of ...
1506         (add_fork): ... this.  Return void.  Move "first fork" special
1507         case from here, to ...
1508         (checkpoint_command): ... here.
1509         * linux-linux.h (add_fork): Return void.
1510
1511 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1512
1513         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1514
1515 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1516             Chris January  <chris.january@arm.com>
1517             David Lecomber  <david.lecomber@arm.com>
1518
1519         * f-exp.y: New token, UNOP_INTRINSIC.
1520         (exp): New pattern using UNOP_INTRINSIC token.
1521         (f77_keywords): Add 'abs' keyword.
1522         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1523         (value_from_host_double): New function.
1524         (evaluate_subexp_f): Support UNOP_ABS.
1525
1526 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1527
1528         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1529         types.
1530
1531 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1532
1533         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1534         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1535         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1536
1537 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1540
1541 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1542             Chris January  <chris.january@arm.com>
1543
1544         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1545         * f-exp.y: Define 'KIND' token.
1546         (exp): New pattern for KIND expressions.
1547         (ptype): Handle types with a kind extension.
1548         (direct_abs_decl): Extend to spot kind extensions.
1549         (f77_keywords): Add 'kind' to the list.
1550         (push_kind_type): New function.
1551         (convert_to_kind_type): New function.
1552         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1553         * parse.c (operator_length_standard): Likewise.
1554         * parser-defs.h (enum type_pieces): Add tp_kind.
1555         * std-operator.def: Add UNOP_KIND.
1556
1557 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1558
1559         * f-exp.y (f_parse): Set yydebug.
1560
1561 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1562
1563         * f-lang.c (evaluate_subexp_f): New function.
1564         (exp_descriptor_f): New global.
1565         (f_language_defn): Use exp_descriptor_f instead of
1566         exp_descriptor_standard.
1567
1568 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1569
1570         * f-exp.y (struct token): Add comments.
1571         (dot_ops): Remove uppercase versions and the end marker.
1572         (f77_keywords): Likewise.
1573         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1574         entries in the dot_ops array are case insensitive, and use
1575         strncasecmp to compare strings.  Also some whitespace cleanup in
1576         this area.  Similar for the f77_keywords array, except entries in
1577         this list might be case sensitive.
1578
1579 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1580
1581         * f-exp.y (struct f77_boolean_val): Add comments.
1582         (boolean_values): Remove uppercase versions, and end marker.
1583         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1584         and use strncasecmp to achieve case insensitivity.  Additionally,
1585         perform whitespace cleanup around this code.
1586
1587 2019-03-06  Tom Tromey  <tromey@adacore.com>
1588
1589         * remote-sim.c (gdbsim_target_open): Use result of
1590         gdb_argv::release.
1591
1592 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1593         Dirk Schubert  <dirk.schubert@arm.com>
1594         Chris January  <chris.january@arm.com>
1595
1596         * eval.c (evaluate_subexp_standard): Call Fortran argument
1597         wrapping logic.
1598         * f-lang.c (struct value): A value which can be passed into a
1599         Fortran function call.
1600         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1601         where appropriate.
1602         (struct type): Value ready for a Fortran function call.
1603         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1604         is needed.
1605         * f-lang.h (fortran_argument_convert): Declaration.
1606         (fortran_preserve_arg_pointer): Declaration.
1607         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1608
1609 2019-03-05  Tom Tromey  <tromey@adacore.com>
1610
1611         * python/py-prettyprint.c (print_string_repr): Remove #if.
1612         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1613
1614 2019-03-05  Tom Tromey  <tromey@adacore.com>
1615
1616         * target.c (the_dummy_target): Move later.  Change type to
1617         "dummy_target".
1618         (initialize_targets): Don't initialize the_dummy_target.
1619
1620 2019-03-05  Tom Tromey  <tromey@adacore.com>
1621
1622         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1623         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1624
1625 2019-03-05  Tom Tromey  <tromey@adacore.com>
1626
1627         * windows-nat.c (windows_nat_target::attach)
1628         (windows_nat_target::detach): Don't call gdb_flush.
1629         * valprint.c (generic_val_print, val_print, val_print_string):
1630         Don't call gdb_flush.
1631         * utils.c (defaulted_query): Don't call gdb_flush.
1632         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1633         * target.c (target_announce_detach): Don't call gdb_flush.
1634         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1635         * remote.c (extended_remote_target::attach): Don't call
1636         gdb_flush.
1637         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1638         * printcmd.c (do_examine): Don't call gdb_flush.
1639         (info_display_command): Don't call gdb_flush.
1640         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1641         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1642         * memattr.c (info_mem_command): Don't call gdb_flush.
1643         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1644         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1645         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1646         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1647         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1648         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1649         (gnu_nat_target::detach): Don't call gdb_flush.
1650         * f-valprint.c (f_val_print): Don't call gdb_flush.
1651         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1652         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1653         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1654         gdb_flush.
1655         * c-valprint.c (c_val_print): Don't call gdb_flush.
1656         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1657
1658 2019-03-05  Tom Tromey  <tromey@adacore.com>
1659
1660         * varobj.c (update_dynamic_varobj_children): Update.
1661         (install_default_visualizer): Use reset, not release.
1662         * value.c (set_internalvar): Update.
1663         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1664         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1665         ATTRIBUTE_UNUSED_RESULT.
1666
1667 2019-03-05  Tom Tromey  <tromey@adacore.com>
1668
1669         * remote.c (class scoped_remote_fd) <release>: Add
1670         ATTRIBUTE_UNUSED_RESULT.
1671
1672 2019-03-05  Tom Tromey  <tromey@adacore.com>
1673
1674         * macroexp.c (struct macro_buffer) <release>: Add
1675         ATTRIBUTE_UNUSED_RESULT.
1676
1677 2019-03-05  Tom Tromey  <tromey@adacore.com>
1678
1679         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1680         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1681         ATTRIBUTE_UNUSED_RESULT.
1682
1683 2019-03-05  Tom Tromey  <tromey@adacore.com>
1684
1685         * common/scoped_fd.h (class scoped_fd) <release>: Add
1686         ATTRIBUTE_UNUSED_RESULT.
1687
1688 2019-03-05  Tom Tromey  <tromey@adacore.com>
1689
1690         * parser-defs.h (struct parser_state) <release>: Add
1691         ATTRIBUTE_UNUSED_RESULT.
1692
1693 2019-03-05  Tom Tromey  <tromey@adacore.com>
1694
1695         * utils.h (class gdb_argv) <release>: Add
1696         ATTRIBUTE_UNUSED_RESULT.
1697         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1698
1699 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1700
1701         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1702         for-loop range, to avoid compiler warnings.
1703
1704         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1705         avoid compiler warnings about unused variables.
1706
1707         * NEWS: Mention end of support for native debugging on MS-Windows
1708         before XP.
1709
1710         PR gdb/24292
1711         * common/netstuff.c:
1712         * gdbserver/gdbreplay.c
1713         * gdbserver/remote-utils.c:
1714         * ser-tcp.c:
1715         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1716         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1717         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1718         'getaddrinfo' and 'freeaddrinfo' were not available before
1719         Windows XP, and mingw.org's MinGW headers by default define
1720         _WIN32_WINNT to 0x500.
1721
1722 2019-03-01  Gary Benson <gbenson@redhat.com>
1723
1724         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1725
1726 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1727             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1728
1729         PR gdb/8527
1730         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1731         set_sigint_trap, clear_sigint_trap.
1732
1733 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1734
1735         * target.c (target_detach): Clear the regcache and the
1736         frame cache.
1737
1738 2019-02-27  Pedro Alves  <palves@redhat.com>
1739
1740         * utils.c (set_screen_size): When we cap the height/width sizes,
1741         tweak the corresponding command variable to show "unlimited":
1742
1743 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1744             Pedro Alves  <palves@redhat.com>
1745
1746         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1747         before calling rl_set_screen_size.
1748
1749 2019-02-27  Tom Tromey  <tromey@adacore.com>
1750
1751         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1752         define.
1753         * python/py-value.c: Remove Python 2.4 workaround.
1754         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1755         workaround.
1756         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1757         Python 2.4 workaround.
1758         * python/python-internal.h: Remove Python 2.4 comment.
1759         (Py_ssize_t): Don't define.
1760         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1761         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1762         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1763         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1764         * python/python.c (do_start_initialization): Remove Python 2.4
1765         workaround.
1766         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1767         (print_children): Remove Python 2.4 workaround.
1768         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1769         workaround.
1770         (CHARBUFFERPROC_NAME): Remove.
1771         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1772         Python 2.4 workaround.
1773
1774 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1775
1776         * NEWS: Note minimum Python version.
1777
1778 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1779
1780         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1781         code from these functions.  Remove corresponding ifdefs.  Use
1782         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1783         Remove gotos and target of gotos.
1784         (infpy_search_memory): Likewise.
1785
1786 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1787
1788         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1789         (hppa_gdbarch_init): Don't register deleted functions with
1790         gdbarch.
1791
1792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1793
1794         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1795         (h8300_unwind_sp): Delete.
1796         (h8300_dummy_id): Delete.
1797         (h8300_gdbarch_init): Don't register deleted functions with
1798         gdbarch.
1799
1800 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1801
1802         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1803         (ft32_unwind_pc): Delete.
1804         (ft32_unwind_sp): Delete.
1805         (ft32_gdbarch_init): Don't register deleted functions with
1806         gdbarch.
1807
1808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1809
1810         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1811         (frv_unwind_pc): Delete.
1812         (frv_unwind_sp): Delete.
1813         (frv_gdbarch_init): Don't register deleted functions with
1814         gdbarch.
1815
1816 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1817
1818         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1819         (riscv_unwind_pc): Delete.
1820         (riscv_unwind_sp): Delete.
1821         (riscv_gdbarch_init): Don't register deleted functions with
1822         gdbarch.
1823
1824 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1825
1826         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1827         (csky_unwind_pc): Delete.
1828         (csky_unwind_sp): Delete.
1829         (csky_gdbarch_init): Don't register deleted functions with
1830         gdbarch.
1831
1832 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1833
1834         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1835         (cris_unwind_pc): Delete.
1836         (cris_unwind_sp): Delete.
1837         (cris_gdbarch_init): Don't register deleted functions with
1838         gdbarch.
1839
1840 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1841
1842         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1843         (bfin_unwind_pc): Delete.
1844         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1845
1846 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1847
1848         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1849         (arm_unwind_pc): Delete.
1850         (arm_unwind_sp): Delete.
1851         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1852
1853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1856         (arc_unwind_pc): Delete.
1857         (arc_unwind_sp): Delete.
1858         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1859
1860 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1861
1862         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1863         (alpha_unwind_pc): Delete.
1864         (alpha_gdbarch_init): Don't register deleted functions with
1865         gdbarch.
1866
1867 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1868
1869         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1870         (aarch64_unwind_pc): Delete.
1871         (aarch64_unwind_sp): Delete.
1872         (aarch64_gdbarch_init): Don't register deleted functions with
1873         gdbarch.
1874
1875 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1876
1877         * gdbtypes.c (type_align): Don't consider static members when
1878         computing structure alignment.
1879
1880 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1881
1882         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1883         return 0 for other types.
1884         * arch-utils.c (default_type_align): Always return 0.
1885         * gdbarch.h: Regenerate.
1886         * gdbarch.sh (type_align): Extend comment.
1887         * gdbtypes.c (type_align): Add additional comments, always call
1888         gdbarch_type_align before applying the default rules.
1889         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1890         generic code will then apply a suitable default.
1891         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1892         types, return 0 for other types.
1893
1894 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1895
1896         * NEWS: Create a new section for the next release branch.
1897         Rename the section of the current branch, now that it has
1898         been cut.
1899
1900 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1901
1902         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1903         * version.in: Bump version to 8.3.50.DATE-git.
1904
1905 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1906
1907         * aix-thread.c (ptid_cmp): Remove unused variable.
1908         (get_signaled_thread): Likewise.
1909         (store_regs_user_thread): Likewise.
1910         (store_regs_kernel_thread): Likewise.
1911         (fetch_regs_kernel_thread): Remove shadowed variable.
1912
1913 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1914
1915         * features/riscv/32bit-cpu.xml: Add register numbers.
1916         * features/riscv/32bit-fpu.c: Regenerate.
1917         * features/riscv/32bit-fpu.xml: Add register numbers.
1918         * features/riscv/64bit-cpu.xml: Add register numbers.
1919         * features/riscv/64bit-fpu.c: Regenerate.
1920         * features/riscv/64bit-fpu.xml: Add register numbers.
1921
1922 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1923
1924         * NEWS: Mention two argument form of gdb.Value constructor.
1925         * python/py-value.c (convert_buffer_and_type_to_value): New
1926         function.
1927         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1928         Add support for handling an optional second argument.  Call
1929         convert_buffer_and_type_to_value as appropriate.
1930         * python/python-internal.h (Py_buffer_deleter): New struct.
1931         (Py_buffer_up): New typedef.
1932
1933 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1934
1935         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1936         instead of releasing ownership.
1937
1938 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1939
1940         * dwarf2read.c (open_and_init_dwp_file): Call
1941         elf_numsections instead of bfd_count_sections to initialize
1942         dwp_file->num_sections.
1943
1944 2019-02-25  Tom Tromey  <tromey@adacore.com>
1945
1946         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1947
1948 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1949
1950         * gcore.in: Add '--readnever' option when invoking GDB.
1951
1952 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1953
1954         * MAINTAINERS: Update my email address.
1955
1956 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1957
1958         * build-id.c (build_id_to_debug_bfd_1): New function.
1959         (build_id_to_debug_bfd): Look for separate debug file in
1960         sysroot.
1961
1962 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1963
1964         * gdbarch.sh: Update the copyright year range that is placed into
1965         generated files.
1966
1967 2019-02-22  Keith Seitz  <keiths@redhat.com>
1968
1969         PR symtab/23853
1970         * linespec.c (create_sals_line_offset): Search for the default
1971         symtab's filename instead of its fullname.
1972
1973 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1974
1975         * NEWS: Update style defaults.
1976
1977 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1978
1979         * main.c (captured_main_1): Disable styling in batch mode.
1980
1981 2019-02-20  Tom Tromey  <tom@tromey.com>
1982
1983         * symtab.c (symtab_symbol_info): Fix typos.
1984
1985 2019-02-20  Tom Tromey  <tromey@adacore.com>
1986
1987         * findcmd.c (_initialize_mem_search): Use upper case for
1988         metasyntactic variables.
1989
1990 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1991
1992         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1993         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1994
1995 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1996
1997         * top.h (source_file_name): Change to std::string.
1998         * top.c (source_file_name): Likewise.
1999         (command_line_input): Adjust.
2000         * cli/cli-script.c (script_from_file): Adjust.
2001
2002 2019-02-19  Tom Tromey  <tromey@adacore.com>
2003
2004         * ravenscar-thread.c
2005         (ravenscar_thread_target::update_thread_list): Don't call
2006         ada_build_task_list.
2007         * ada-lang.h (ada_build_task_list): Don't declare.
2008         * ada-tasks.c (struct ada_tasks_inferior_data)
2009         <task_list_valid_p>: Now bool.
2010         (read_known_tasks, ada_task_list_changed)
2011         (ada_tasks_invalidate_inferior_data): Update.
2012         (read_known_tasks_array): Return bool.
2013         (read_known_tasks_list): Likewise.
2014         (read_known_tasks): Return void.
2015         (ada_build_task_list): Now static.
2016
2017 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2018
2019         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2020         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2021
2022 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2023
2024         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2025         variant for ada_tasks_pspace_data_handle and
2026         ada_tasks_inferior_data_handle.
2027         (ada_tasks_pspace_data_cleanup): New function.
2028         (ada_tasks_inferior_data_cleanup): New function.
2029
2030 2019-02-17  Tom Tromey  <tom@tromey.com>
2031
2032         * macrotab.h (macro_source_fullname): Return a std::string.
2033         * macrotab.c (macro_include, check_for_redefinition)
2034         (macro_undef, macro_lookup_definition, foreach_macro)
2035         (foreach_macro_in_scope): Update.
2036         (macro_source_fullname): Return a std::string.
2037         * macrocmd.c (show_pp_source_pos): Update.
2038
2039 2019-02-17  Tom Tromey  <tom@tromey.com>
2040
2041         * macrocmd.c (show_pp_source_pos): Style the file names.
2042
2043 2019-02-17  Tom Tromey  <tom@tromey.com>
2044
2045         PR tui/24197:
2046         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2047
2048 2019-02-17  Tom Tromey  <tom@tromey.com>
2049
2050         * ada-lang.c (user_select_syms): Use filtered printing.
2051         * utils.c (wrap_style): New global.
2052         (desired_style): Remove.
2053         (emit_style_escape): Add stream parameter.
2054         (set_output_style, reset_terminal_style, prompt_for_continue):
2055         Update.
2056         (flush_wrap_buffer): Only flush gdb_stdout.
2057         (wrap_here): Set wrap_style.
2058         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2059         treat escape sequences as a character.  Change when wrap buffer is
2060         flushed.
2061         (fputs_styled): Do not set the output style when the default is
2062         requested.
2063         * ui-style.h (struct ui_file_style) <is_default>: New method.
2064         * source.c (print_source_lines_base): Emit escape sequences in one
2065         piece.
2066
2067 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2068
2069         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2070         integers and enumeration types.
2071
2072 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2073
2074         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2075         instead of lookup_symbol_in_language
2076         (do_exact_match): New function.
2077         (ada_get_symbol_name_matcher): Return do_exact_match when
2078         doing a verbatim match.
2079
2080 2019-02-15  Tom Tromey  <tromey@adacore.com>
2081
2082         * ravenscar-thread.c (ravenscar_thread_target::resume)
2083         (ravenscar_thread_target::wait): Special case wildcard requests.
2084
2085 2019-02-15  Tom Tromey  <tromey@adacore.com>
2086
2087         * ravenscar-thread.c (base_ptid): Remove.
2088         (struct ravenscar_thread_target) <close>: New method.
2089         <m_base_ptid>: New member.
2090         <update_inferior_ptid, active_task, task_is_currently_active,
2091         runtime_initialized>: Declare methods.
2092         <ravenscar_thread_target>: Add constructor.
2093         (ravenscar_thread_target::task_is_currently_active)
2094         (ravenscar_thread_target::update_inferior_ptid)
2095         (ravenscar_runtime_initialized): Rename.  Now methods.
2096         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2097         (ravenscar_thread_target::update_thread_list): Update.
2098         (ravenscar_thread_target::active_task): Now method.
2099         (ravenscar_thread_target::store_registers)
2100         (ravenscar_thread_target::prepare_to_store)
2101         (ravenscar_thread_target::prepare_to_store)
2102         (ravenscar_thread_target::mourn_inferior): Update.
2103         (ravenscar_inferior_created): Use "new" to create target.
2104         (ravenscar_thread_target::get_ada_task_ptid): Update.
2105         (_initialize_ravenscar): Don't initialize base_ptid.
2106         (ravenscar_ops): Remove global.
2107
2108 2019-02-15  Tom Tromey  <tromey@adacore.com>
2109
2110         * target.h (push_target): Declare new overload.
2111         * target.c (push_target): New overload, taking an rvalue reference.
2112         * remote.c (remote_target::open_1): Use push_target overload.
2113         * corelow.c (core_target_open): Use push_target overload.
2114
2115 2019-02-15  Tom Tromey  <tromey@adacore.com>
2116
2117         * ravenscar-thread.c (is_ravenscar_task)
2118         (ravenscar_task_is_currently_active): Return bool.
2119         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2120         (_initialize_ravenscar): Remove "(void)".
2121         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2122         Return bool.
2123
2124 2019-02-15  Tom Tromey  <tromey@adacore.com>
2125
2126         * ravenscar-thread.c (ravenscar_runtime_initializer)
2127         (has_ravenscar_runtime, get_running_thread_id)
2128         (ravenscar_thread_target::resume): Fix indentation.
2129
2130 2019-02-15  Tom Tromey  <tromey@adacore.com>
2131
2132         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2133         from ravenscar_arch_ops.
2134         (sparc_ravenscar_ops::fetch_registers)
2135         (sparc_ravenscar_ops::store_registers): Now methods.
2136         (sparc_ravenscar_prepare_to_store): Remove.
2137         (sparc_ravenscar_ops): Redefine.
2138         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2139         methods and destructor.  Remove members.
2140         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2141         (ravenscar_thread_target::store_registers)
2142         (ravenscar_thread_target::prepare_to_store): Update.
2143         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2144         Remove.
2145         (struct ppc_ravenscar_powerpc_ops): Derive from
2146         ravenscar_arch_ops.
2147         (ppc_ravenscar_powerpc_ops::fetch_registers)
2148         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2149         (ppc_ravenscar_powerpc_ops): Redefine.
2150         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2151         (ppc_ravenscar_e500_ops::fetch_registers)
2152         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2153         (ppc_ravenscar_e500_ops): Redefine.
2154         * aarch64-ravenscar-thread.c
2155         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2156         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2157         (aarch64_ravenscar_fetch_registers)
2158         (aarch64_ravenscar_store_registers): Now methods.
2159         (aarch64_ravenscar_ops): Redefine.
2160
2161 2019-02-15  Tom Tromey  <tromey@adacore.com>
2162
2163         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2164         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2165         (ravenscar_thread_target::stopped_by_watchpoint)
2166         (ravenscar_thread_target::stopped_data_address)
2167         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2168
2169 2019-02-15  Tom Tromey  <tromey@adacore.com>
2170
2171         * ravenscar-thread.c: Fix some typos.
2172
2173 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2174             Tom Tromey  <tromey@adacore.com>
2175
2176         * ada-lang.c (ada_exception_sal): Change addr_string to a
2177         std::string.
2178         (create_ada_exception_catchpoint): Update.
2179
2180 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2181             Tom Tromey  <tromey@adacore.com>
2182
2183         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2184         (bp_location_ops): Remove.
2185         (base_breakpoint_allocate_location): Update.
2186         (free_bp_location): Update.
2187         * ada-lang.c (class ada_catchpoint_location)
2188         <ada_catchpoint_location>: Remove ops parameter.
2189         (ada_catchpoint_location_dtor): Remove.
2190         (ada_catchpoint_location_ops): Remove.
2191         (allocate_location_exception): Update.
2192         * breakpoint.h (struct bp_location_ops): Remove.
2193         (class bp_location) <bp_location>: Remove bp_location_ops
2194         parameter.
2195         <~bp_location>: Add destructor.
2196         <ops>: Remove.
2197
2198 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2199             Pedro Alves  <palves@redhat.com>
2200
2201         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2202         'PATH_MAX'.
2203
2204 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2205             Samuel Thibault  <samuel.thibault@gnu.org>
2206             Thomas Schwinge  <thomas@codesourcery.com>
2207
2208         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2209         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2210
2211 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2212
2213         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2214         (check_empty): Use "const char *".
2215
2216         * gnu-nat.c (gnu_nat_target::detach): Instead of
2217         'detach_inferior (pid)' call
2218         'detach_inferior (find_inferior_pid (pid))'.
2219
2220         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2221         'nat/fork-inferior.o'.
2222         * gnu-nat.c: #include "nat/fork-inferior.h".
2223
2224         * gnu-nat.c (gnu_nat_target::detach): Instead of
2225         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2226         * gnu-nat.h: #include "inf-child.h".
2227         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2228         'i386_gnu_nat_target::fetch_registers'.
2229         (gnu_store_registers): Rename/move to
2230         'i386_gnu_nat_target::store_registers'.
2231
2232         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2233         * gnu-nat.h (mach_thread_info): New function.
2234         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2235
2236         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2237
2238 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2239
2240         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2241
2242 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2243
2244         * windows-nat.c (windows_add_thread): Add new parameter
2245         "main_thread_p" with default value set to false.  Update
2246         function documentation as well as all callers.
2247         (windows_delete_thread): Likewise.
2248         (fake_create_process): Update call to windows_add_thread.
2249         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2250         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2251         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2252         call to windows_delete_thread.
2253
2254 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2255
2256         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2257
2258 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2259
2260         * symfile.c (find_separate_debug_file): Use canonical path of
2261         sysroot with child_path instead of gdb_sysroot if it is valid.
2262
2263 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2264
2265         * symfile.c (find_separate_debug_file): Use child_path to
2266         determine if an object file is under a sysroot.
2267
2268 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2269
2270         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2271         unittests/child-path-selftests.c.
2272         * common/pathstuff.c (child_path): New function.
2273         * common/pathstuff.h (child_path): New prototype.
2274         * unittests/child-path-selftests.c: New file.
2275
2276 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2277
2278         * symfile.c (find_separate_debug_file): Look for separate debug
2279         files in debug directories under the sysroot.
2280
2281 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2282
2283         * symtab.h (struct minimal_symbol data_p): New const method.
2284         (struct minimal_symbol text_p): Likewise.
2285         * symtab.c (output_source_filename): Use file name style
2286         to print file name.
2287         (print_symbol_info): Likewise.
2288         (print_msymbol_info): Use address style to print addresses.
2289         Use function name style to print executable text symbols.
2290         (expand_symtab_containing_pc): Use data_p.
2291         (find_pc_sect_compunit_symtab): Likewise.
2292
2293 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2294
2295         * breakpoint.c (describe_other_breakpoints): Use address style
2296         to print addresses.
2297         (say_where): Likewise.
2298
2299 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2300
2301         * ada-typeprint.c (print_func_type): Print function name
2302         style to print function name.
2303         * c-typeprint.c (c_print_type_1): Likewise.
2304
2305 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2306
2307         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2308         for execve.
2309
2310 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2311
2312         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2313         type_stack.
2314
2315 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2316
2317         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2318         TYPE_CODE_REF types.
2319
2320 2019-02-08  Jim Wilson  <jimw@sifive.com>
2321
2322         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2323         (riscv_linux_fregset): New.
2324         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2325
2326 2019-02-07  Tom Tromey  <tom@tromey.com>
2327
2328         * thread.c (thread_cancel_execution_command): Update.
2329         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2330         methods.
2331         (struct thread_fsm_ops): Remove.
2332         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2333         (thread_fsm_should_stop, thread_fsm_return_value)
2334         (thread_fsm_set_finished, thread_fsm_finished_p)
2335         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2336         Don't declare.
2337         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2338         * infrun.c (clear_proceed_status_thread)
2339         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2340         (print_stop_event): Update.
2341         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2342         Add constructor.
2343         (step_command_fsm_ops): Remove.
2344         (new_step_command_fsm): Remove.
2345         (step_1): Update.
2346         (step_command_fsm::should_stop): Rename from
2347         step_command_fsm_should_stop.
2348         (step_command_fsm::clean_up): Rename from
2349         step_command_fsm_clean_up.
2350         (step_command_fsm::do_async_reply_reason): Rename from
2351         step_command_fsm_async_reply_reason.
2352         (struct until_next_fsm): Inherit from thread_fsm.  Add
2353         constructor.
2354         (until_next_fsm_ops): Remove.
2355         (new_until_next_fsm): Remove.
2356         (until_next_fsm::should_stop): Rename from
2357         until_next_fsm_should_stop.
2358         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2359         (until_next_fsm::do_async_reply_reason): Rename from
2360         until_next_fsm_async_reply_reason.
2361         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2362         constructor.  Change type of breakpoint.
2363         (finish_command_fsm_ops): Remove.
2364         (new_finish_command_fsm): Remove.
2365         (finish_command_fsm::should_stop): Rename from
2366         finish_command_fsm_should_stop.
2367         (finish_command_fsm::clean_up): Rename from
2368         finish_command_fsm_clean_up.
2369         (finish_command_fsm::return_value): Rename from
2370         finish_command_fsm_return_value.
2371         (finish_command_fsm::do_async_reply_reason): Rename from
2372         finish_command_fsm_async_reply_reason.
2373         (finish_command): Update.
2374         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2375         Add constructor.
2376         (call_thread_fsm_ops): Remove.
2377         (call_thread_fsm::call_thread_fsm): Rename from
2378         new_call_thread_fsm.
2379         (call_thread_fsm::should_stop): Rename from
2380         call_thread_fsm_should_stop.
2381         (call_thread_fsm::should_notify_stop): Rename from
2382         call_thread_fsm_should_notify_stop.
2383         (run_inferior_call, call_function_by_hand_dummy): Update.
2384         * cli/cli-interp.c (should_print_stop_to_console): Update.
2385         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2386         Add constructor.  Change type of location_breakpoint,
2387         caller_breakpoint.
2388         (until_break_fsm_ops): Remove.
2389         (new_until_break_fsm): Remove.
2390         (until_break_fsm::should_stop): Rename from
2391         until_break_fsm_should_stop.
2392         (until_break_fsm::clean_up): Rename from
2393         until_break_fsm_clean_up.
2394         (until_break_fsm::do_async_reply_reason): Rename from
2395         until_break_fsm_async_reply_reason.
2396         (until_break_command): Update.
2397         * thread-fsm.c: Remove.
2398         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2399
2400 2019-02-07  Tom Tromey  <tom@tromey.com>
2401
2402         * yy-remap.h: Add include guard.
2403         * xtensa-tdep.h: Add include guard.
2404         * xcoffread.h: Rename include guard.
2405         * varobj-iter.h: Add include guard.
2406         * tui/tui.h: Rename include guard.
2407         * tui/tui-winsource.h: Rename include guard.
2408         * tui/tui-wingeneral.h: Rename include guard.
2409         * tui/tui-windata.h: Rename include guard.
2410         * tui/tui-win.h: Rename include guard.
2411         * tui/tui-stack.h: Rename include guard.
2412         * tui/tui-source.h: Rename include guard.
2413         * tui/tui-regs.h: Rename include guard.
2414         * tui/tui-out.h: Rename include guard.
2415         * tui/tui-layout.h: Rename include guard.
2416         * tui/tui-io.h: Rename include guard.
2417         * tui/tui-hooks.h: Rename include guard.
2418         * tui/tui-file.h: Rename include guard.
2419         * tui/tui-disasm.h: Rename include guard.
2420         * tui/tui-data.h: Rename include guard.
2421         * tui/tui-command.h: Rename include guard.
2422         * tic6x-tdep.h: Add include guard.
2423         * target/waitstatus.h: Rename include guard.
2424         * target/wait.h: Rename include guard.
2425         * target/target.h: Rename include guard.
2426         * target/resume.h: Rename include guard.
2427         * target-float.h: Rename include guard.
2428         * stabsread.h: Add include guard.
2429         * rs6000-tdep.h: Add include guard.
2430         * riscv-fbsd-tdep.h: Add include guard.
2431         * regformats/regdef.h: Rename include guard.
2432         * record.h: Rename include guard.
2433         * python/python.h: Rename include guard.
2434         * python/python-internal.h: Rename include guard.
2435         * python/py-stopevent.h: Rename include guard.
2436         * python/py-ref.h: Rename include guard.
2437         * python/py-record.h: Rename include guard.
2438         * python/py-record-full.h: Rename include guard.
2439         * python/py-record-btrace.h: Rename include guard.
2440         * python/py-instruction.h: Rename include guard.
2441         * python/py-events.h: Rename include guard.
2442         * python/py-event.h: Rename include guard.
2443         * procfs.h: Add include guard.
2444         * proc-utils.h: Add include guard.
2445         * p-lang.h: Add include guard.
2446         * or1k-tdep.h: Rename include guard.
2447         * observable.h: Rename include guard.
2448         * nto-tdep.h: Rename include guard.
2449         * nat/x86-linux.h: Rename include guard.
2450         * nat/x86-linux-dregs.h: Rename include guard.
2451         * nat/x86-gcc-cpuid.h: Add include guard.
2452         * nat/x86-dregs.h: Rename include guard.
2453         * nat/x86-cpuid.h: Rename include guard.
2454         * nat/ppc-linux.h: Rename include guard.
2455         * nat/mips-linux-watch.h: Rename include guard.
2456         * nat/linux-waitpid.h: Rename include guard.
2457         * nat/linux-ptrace.h: Rename include guard.
2458         * nat/linux-procfs.h: Rename include guard.
2459         * nat/linux-osdata.h: Rename include guard.
2460         * nat/linux-nat.h: Rename include guard.
2461         * nat/linux-namespaces.h: Rename include guard.
2462         * nat/linux-btrace.h: Rename include guard.
2463         * nat/glibc_thread_db.h: Rename include guard.
2464         * nat/gdb_thread_db.h: Rename include guard.
2465         * nat/gdb_ptrace.h: Rename include guard.
2466         * nat/fork-inferior.h: Rename include guard.
2467         * nat/amd64-linux-siginfo.h: Rename include guard.
2468         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2469         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2470         * nat/aarch64-linux.h: Rename include guard.
2471         * nat/aarch64-linux-hw-point.h: Rename include guard.
2472         * mn10300-tdep.h: Add include guard.
2473         * mips-linux-tdep.h: Add include guard.
2474         * mi/mi-parse.h: Rename include guard.
2475         * mi/mi-out.h: Rename include guard.
2476         * mi/mi-main.h: Rename include guard.
2477         * mi/mi-interp.h: Rename include guard.
2478         * mi/mi-getopt.h: Rename include guard.
2479         * mi/mi-console.h: Rename include guard.
2480         * mi/mi-common.h: Rename include guard.
2481         * mi/mi-cmds.h: Rename include guard.
2482         * mi/mi-cmd-break.h: Rename include guard.
2483         * m2-lang.h: Add include guard.
2484         * location.h: Rename include guard.
2485         * linux-record.h: Rename include guard.
2486         * linux-nat.h: Add include guard.
2487         * linux-fork.h: Add include guard.
2488         * i386-darwin-tdep.h: Rename include guard.
2489         * hppa-linux-offsets.h: Add include guard.
2490         * guile/guile.h: Rename include guard.
2491         * guile/guile-internal.h: Rename include guard.
2492         * gnu-nat.h: Rename include guard.
2493         * gdb-stabs.h: Rename include guard.
2494         * frv-tdep.h: Add include guard.
2495         * f-lang.h: Add include guard.
2496         * event-loop.h: Add include guard.
2497         * darwin-nat.h: Rename include guard.
2498         * cp-abi.h: Rename include guard.
2499         * config/sparc/nm-sol2.h: Rename include guard.
2500         * config/nm-nto.h: Rename include guard.
2501         * config/nm-linux.h: Add include guard.
2502         * config/i386/nm-i386gnu.h: Rename include guard.
2503         * config/djgpp/nl_types.h: Rename include guard.
2504         * config/djgpp/langinfo.h: Rename include guard.
2505         * compile/gcc-cp-plugin.h: Add include guard.
2506         * compile/gcc-c-plugin.h: Add include guard.
2507         * compile/compile.h: Rename include guard.
2508         * compile/compile-object-run.h: Rename include guard.
2509         * compile/compile-object-load.h: Rename include guard.
2510         * compile/compile-internal.h: Rename include guard.
2511         * compile/compile-cplus.h: Rename include guard.
2512         * compile/compile-c.h: Rename include guard.
2513         * common/xml-utils.h: Rename include guard.
2514         * common/x86-xstate.h: Rename include guard.
2515         * common/version.h: Rename include guard.
2516         * common/vec.h: Rename include guard.
2517         * common/tdesc.h: Rename include guard.
2518         * common/selftest.h: Rename include guard.
2519         * common/scoped_restore.h: Rename include guard.
2520         * common/scoped_mmap.h: Rename include guard.
2521         * common/scoped_fd.h: Rename include guard.
2522         * common/safe-iterator.h: Rename include guard.
2523         * common/run-time-clock.h: Rename include guard.
2524         * common/refcounted-object.h: Rename include guard.
2525         * common/queue.h: Rename include guard.
2526         * common/ptid.h: Rename include guard.
2527         * common/print-utils.h: Rename include guard.
2528         * common/preprocessor.h: Rename include guard.
2529         * common/pathstuff.h: Rename include guard.
2530         * common/observable.h: Rename include guard.
2531         * common/netstuff.h: Rename include guard.
2532         * common/job-control.h: Rename include guard.
2533         * common/host-defs.h: Rename include guard.
2534         * common/gdb_wait.h: Rename include guard.
2535         * common/gdb_vecs.h: Rename include guard.
2536         * common/gdb_unlinker.h: Rename include guard.
2537         * common/gdb_unique_ptr.h: Rename include guard.
2538         * common/gdb_tilde_expand.h: Rename include guard.
2539         * common/gdb_sys_time.h: Rename include guard.
2540         * common/gdb_string_view.h: Rename include guard.
2541         * common/gdb_splay_tree.h: Rename include guard.
2542         * common/gdb_setjmp.h: Rename include guard.
2543         * common/gdb_ref_ptr.h: Rename include guard.
2544         * common/gdb_optional.h: Rename include guard.
2545         * common/gdb_locale.h: Rename include guard.
2546         * common/gdb_assert.h: Rename include guard.
2547         * common/filtered-iterator.h: Rename include guard.
2548         * common/filestuff.h: Rename include guard.
2549         * common/fileio.h: Rename include guard.
2550         * common/environ.h: Rename include guard.
2551         * common/common-utils.h: Rename include guard.
2552         * common/common-types.h: Rename include guard.
2553         * common/common-regcache.h: Rename include guard.
2554         * common/common-inferior.h: Rename include guard.
2555         * common/common-gdbthread.h: Rename include guard.
2556         * common/common-exceptions.h: Rename include guard.
2557         * common/common-defs.h: Rename include guard.
2558         * common/common-debug.h: Rename include guard.
2559         * common/cleanups.h: Rename include guard.
2560         * common/buffer.h: Rename include guard.
2561         * common/btrace-common.h: Rename include guard.
2562         * common/break-common.h: Rename include guard.
2563         * cli/cli-utils.h: Rename include guard.
2564         * cli/cli-style.h: Rename include guard.
2565         * cli/cli-setshow.h: Rename include guard.
2566         * cli/cli-script.h: Rename include guard.
2567         * cli/cli-interp.h: Rename include guard.
2568         * cli/cli-decode.h: Rename include guard.
2569         * cli/cli-cmds.h: Rename include guard.
2570         * charset-list.h: Add include guard.
2571         * buildsym-legacy.h: Rename include guard.
2572         * bfin-tdep.h: Add include guard.
2573         * ax.h: Rename include guard.
2574         * arm-linux-tdep.h: Add include guard.
2575         * arm-fbsd-tdep.h: Add include guard.
2576         * arch/xtensa.h: Rename include guard.
2577         * arch/tic6x.h: Add include guard.
2578         * arch/i386.h: Add include guard.
2579         * arch/arm.h: Rename include guard.
2580         * arch/arm-linux.h: Rename include guard.
2581         * arch/arm-get-next-pcs.h: Rename include guard.
2582         * arch/amd64.h: Add include guard.
2583         * arch/aarch64-insn.h: Rename include guard.
2584         * arch-utils.h: Rename include guard.
2585         * annotate.h: Add include guard.
2586         * amd64-darwin-tdep.h: Rename include guard.
2587         * aarch64-linux-tdep.h: Add include guard.
2588         * aarch64-fbsd-tdep.h: Add include guard.
2589         * aarch32-linux-nat.h: Add include guard.
2590
2591 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2592
2593         * macrotab.c (macro_define_internal): New function that
2594         factorizes macro_define_object_internal and macro_define_function
2595         code.
2596         (macro_define_object_internal): Use macro_define_internal.
2597         (macro_define_function): Likewise.
2598
2599 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2600
2601         * macrocmd.c (extract_identifier): Return
2602         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2603         callers.
2604
2605 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2606
2607         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2608
2609 2019-02-05  Tom Tromey  <tom@tromey.com>
2610
2611         * target.c (target_stack::unpush): Move assertion earlier.
2612
2613 2019-01-30  Tom Tromey  <tom@tromey.com>
2614
2615         PR python/23615:
2616         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2617         (gdbpy_parse_and_eval): Likewise.
2618         * python/python-internal.h (gdbpy_allow_threads): New class.
2619
2620 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2621
2622         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2623         (aarch64_fbsd_fpregmap): Move earlier.
2624         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2625         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2626         instead of individual calls to trad_frame_set_reg_addr.
2627         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2628         earlier.
2629         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2630         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2631         instead of individual calls to trad_frame_set_reg_addr.
2632
2633 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2634
2635         * CONTRIBUTE: Replace contribution list with wiki link.
2636
2637 2019-01-25  Tom Tromey  <tom@tromey.com>
2638
2639         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2640
2641 2019-01-25  Tom Tromey  <tom@tromey.com>
2642
2643         * xtensa-linux-nat.c: Fix common/ includes.
2644         * xml-support.h: Fix common/ includes.
2645         * xml-support.c: Fix common/ includes.
2646         * x86-linux-nat.c: Fix common/ includes.
2647         * windows-nat.c: Fix common/ includes.
2648         * varobj.h: Fix common/ includes.
2649         * varobj.c: Fix common/ includes.
2650         * value.c: Fix common/ includes.
2651         * valops.c: Fix common/ includes.
2652         * utils.c: Fix common/ includes.
2653         * unittests/xml-utils-selftests.c: Fix common/ includes.
2654         * unittests/utils-selftests.c: Fix common/ includes.
2655         * unittests/unpack-selftests.c: Fix common/ includes.
2656         * unittests/tracepoint-selftests.c: Fix common/ includes.
2657         * unittests/style-selftests.c: Fix common/ includes.
2658         * unittests/string_view-selftests.c: Fix common/ includes.
2659         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2660         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2661         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2662         * unittests/rsp-low-selftests.c: Fix common/ includes.
2663         * unittests/parse-connection-spec-selftests.c: Fix common/
2664         includes.
2665         * unittests/optional-selftests.c: Fix common/ includes.
2666         * unittests/offset-type-selftests.c: Fix common/ includes.
2667         * unittests/observable-selftests.c: Fix common/ includes.
2668         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2669         * unittests/memrange-selftests.c: Fix common/ includes.
2670         * unittests/memory-map-selftests.c: Fix common/ includes.
2671         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2672         * unittests/function-view-selftests.c: Fix common/ includes.
2673         * unittests/environ-selftests.c: Fix common/ includes.
2674         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2675         * unittests/common-utils-selftests.c: Fix common/ includes.
2676         * unittests/cli-utils-selftests.c: Fix common/ includes.
2677         * unittests/array-view-selftests.c: Fix common/ includes.
2678         * ui-file.c: Fix common/ includes.
2679         * tui/tui-io.c: Fix common/ includes.
2680         * tracepoint.h: Fix common/ includes.
2681         * tracepoint.c: Fix common/ includes.
2682         * tracefile-tfile.c: Fix common/ includes.
2683         * top.h: Fix common/ includes.
2684         * top.c: Fix common/ includes.
2685         * thread.c: Fix common/ includes.
2686         * target/waitstatus.h: Fix common/ includes.
2687         * target/waitstatus.c: Fix common/ includes.
2688         * target.h: Fix common/ includes.
2689         * target.c: Fix common/ includes.
2690         * target-memory.c: Fix common/ includes.
2691         * target-descriptions.c: Fix common/ includes.
2692         * symtab.h: Fix common/ includes.
2693         * symfile.c: Fix common/ includes.
2694         * stap-probe.c: Fix common/ includes.
2695         * spu-linux-nat.c: Fix common/ includes.
2696         * sparc-nat.c: Fix common/ includes.
2697         * source.c: Fix common/ includes.
2698         * solib.c: Fix common/ includes.
2699         * solib-target.c: Fix common/ includes.
2700         * ser-unix.c: Fix common/ includes.
2701         * ser-tcp.c: Fix common/ includes.
2702         * ser-pipe.c: Fix common/ includes.
2703         * ser-base.c: Fix common/ includes.
2704         * selftest-arch.c: Fix common/ includes.
2705         * s12z-tdep.c: Fix common/ includes.
2706         * rust-exp.y: Fix common/ includes.
2707         * rs6000-aix-tdep.c: Fix common/ includes.
2708         * riscv-tdep.c: Fix common/ includes.
2709         * remote.c: Fix common/ includes.
2710         * remote-notif.h: Fix common/ includes.
2711         * remote-fileio.h: Fix common/ includes.
2712         * remote-fileio.c: Fix common/ includes.
2713         * regcache.h: Fix common/ includes.
2714         * regcache.c: Fix common/ includes.
2715         * record-btrace.c: Fix common/ includes.
2716         * python/python.c: Fix common/ includes.
2717         * python/py-type.c: Fix common/ includes.
2718         * python/py-inferior.c: Fix common/ includes.
2719         * progspace.h: Fix common/ includes.
2720         * producer.c: Fix common/ includes.
2721         * procfs.c: Fix common/ includes.
2722         * proc-api.c: Fix common/ includes.
2723         * printcmd.c: Fix common/ includes.
2724         * ppc-linux-nat.c: Fix common/ includes.
2725         * parser-defs.h: Fix common/ includes.
2726         * osdata.c: Fix common/ includes.
2727         * obsd-nat.c: Fix common/ includes.
2728         * nat/x86-linux.c: Fix common/ includes.
2729         * nat/x86-linux-dregs.c: Fix common/ includes.
2730         * nat/x86-dregs.h: Fix common/ includes.
2731         * nat/x86-dregs.c: Fix common/ includes.
2732         * nat/ppc-linux.c: Fix common/ includes.
2733         * nat/mips-linux-watch.h: Fix common/ includes.
2734         * nat/mips-linux-watch.c: Fix common/ includes.
2735         * nat/linux-waitpid.c: Fix common/ includes.
2736         * nat/linux-ptrace.h: Fix common/ includes.
2737         * nat/linux-ptrace.c: Fix common/ includes.
2738         * nat/linux-procfs.c: Fix common/ includes.
2739         * nat/linux-personality.c: Fix common/ includes.
2740         * nat/linux-osdata.c: Fix common/ includes.
2741         * nat/linux-namespaces.c: Fix common/ includes.
2742         * nat/linux-btrace.h: Fix common/ includes.
2743         * nat/linux-btrace.c: Fix common/ includes.
2744         * nat/fork-inferior.c: Fix common/ includes.
2745         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2746         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2747         * nat/aarch64-linux.c: Fix common/ includes.
2748         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2749         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2750         * namespace.h: Fix common/ includes.
2751         * mips-linux-tdep.c: Fix common/ includes.
2752         * minsyms.c: Fix common/ includes.
2753         * mi/mi-parse.h: Fix common/ includes.
2754         * mi/mi-main.c: Fix common/ includes.
2755         * mi/mi-cmd-env.c: Fix common/ includes.
2756         * memrange.h: Fix common/ includes.
2757         * memattr.c: Fix common/ includes.
2758         * maint.h: Fix common/ includes.
2759         * maint.c: Fix common/ includes.
2760         * main.c: Fix common/ includes.
2761         * machoread.c: Fix common/ includes.
2762         * location.c: Fix common/ includes.
2763         * linux-thread-db.c: Fix common/ includes.
2764         * linux-nat.c: Fix common/ includes.
2765         * linux-fork.c: Fix common/ includes.
2766         * inline-frame.c: Fix common/ includes.
2767         * infrun.c: Fix common/ includes.
2768         * inflow.c: Fix common/ includes.
2769         * inferior.h: Fix common/ includes.
2770         * inferior.c: Fix common/ includes.
2771         * infcmd.c: Fix common/ includes.
2772         * inf-ptrace.c: Fix common/ includes.
2773         * inf-child.c: Fix common/ includes.
2774         * ia64-linux-nat.c: Fix common/ includes.
2775         * i387-tdep.c: Fix common/ includes.
2776         * i386-tdep.c: Fix common/ includes.
2777         * i386-linux-tdep.c: Fix common/ includes.
2778         * i386-linux-nat.c: Fix common/ includes.
2779         * i386-go32-tdep.c: Fix common/ includes.
2780         * i386-fbsd-tdep.c: Fix common/ includes.
2781         * i386-fbsd-nat.c: Fix common/ includes.
2782         * guile/scm-type.c: Fix common/ includes.
2783         * guile/guile.c: Fix common/ includes.
2784         * go32-nat.c: Fix common/ includes.
2785         * gnu-nat.c: Fix common/ includes.
2786         * gdbthread.h: Fix common/ includes.
2787         * gdbarch-selftests.c: Fix common/ includes.
2788         * gdb_usleep.c: Fix common/ includes.
2789         * gdb_select.h: Fix common/ includes.
2790         * gdb_bfd.c: Fix common/ includes.
2791         * gcore.c: Fix common/ includes.
2792         * fork-child.c: Fix common/ includes.
2793         * findvar.c: Fix common/ includes.
2794         * fbsd-nat.c: Fix common/ includes.
2795         * event-top.c: Fix common/ includes.
2796         * event-loop.c: Fix common/ includes.
2797         * dwarf2read.c: Fix common/ includes.
2798         * dwarf2loc.c: Fix common/ includes.
2799         * dwarf2-frame.c: Fix common/ includes.
2800         * dwarf-index-cache.c: Fix common/ includes.
2801         * dtrace-probe.c: Fix common/ includes.
2802         * disasm-selftests.c: Fix common/ includes.
2803         * defs.h: Fix common/ includes.
2804         * csky-tdep.c: Fix common/ includes.
2805         * cp-valprint.c: Fix common/ includes.
2806         * cp-support.h: Fix common/ includes.
2807         * cp-support.c: Fix common/ includes.
2808         * corelow.c: Fix common/ includes.
2809         * completer.h: Fix common/ includes.
2810         * completer.c: Fix common/ includes.
2811         * compile/compile.c: Fix common/ includes.
2812         * compile/compile-loc2c.c: Fix common/ includes.
2813         * compile/compile-cplus-types.c: Fix common/ includes.
2814         * compile/compile-cplus-symbols.c: Fix common/ includes.
2815         * command.h: Fix common/ includes.
2816         * cli/cli-dump.c: Fix common/ includes.
2817         * cli/cli-cmds.c: Fix common/ includes.
2818         * charset.c: Fix common/ includes.
2819         * build-id.c: Fix common/ includes.
2820         * btrace.h: Fix common/ includes.
2821         * btrace.c: Fix common/ includes.
2822         * breakpoint.h: Fix common/ includes.
2823         * breakpoint.c: Fix common/ includes.
2824         * ax.h:
2825         (enum agent_op): Fix common/ includes.
2826         * ax-general.c (struct aop_map): Fix common/ includes.
2827         * ax-gdb.c: Fix common/ includes.
2828         * auxv.c: Fix common/ includes.
2829         * auto-load.c: Fix common/ includes.
2830         * arm-tdep.c: Fix common/ includes.
2831         * arch/riscv.c: Fix common/ includes.
2832         * arch/ppc-linux-common.c: Fix common/ includes.
2833         * arch/i386.c: Fix common/ includes.
2834         * arch/arm.c: Fix common/ includes.
2835         * arch/arm-linux.c: Fix common/ includes.
2836         * arch/arm-get-next-pcs.c: Fix common/ includes.
2837         * arch/amd64.c: Fix common/ includes.
2838         * arch/aarch64.c: Fix common/ includes.
2839         * arch/aarch64-insn.c: Fix common/ includes.
2840         * arch-utils.c: Fix common/ includes.
2841         * amd64-windows-tdep.c: Fix common/ includes.
2842         * amd64-tdep.c: Fix common/ includes.
2843         * amd64-sol2-tdep.c: Fix common/ includes.
2844         * amd64-obsd-tdep.c: Fix common/ includes.
2845         * amd64-nbsd-tdep.c: Fix common/ includes.
2846         * amd64-linux-tdep.c: Fix common/ includes.
2847         * amd64-linux-nat.c: Fix common/ includes.
2848         * amd64-fbsd-tdep.c: Fix common/ includes.
2849         * amd64-fbsd-nat.c: Fix common/ includes.
2850         * amd64-dicos-tdep.c: Fix common/ includes.
2851         * amd64-darwin-tdep.c: Fix common/ includes.
2852         * agent.c: Fix common/ includes.
2853         * ada-lang.h: Fix common/ includes.
2854         * ada-lang.c: Fix common/ includes.
2855         * aarch64-tdep.c: Fix common/ includes.
2856
2857 2019-01-25  Tom Tromey  <tom@tromey.com>
2858
2859         * common/create-version.sh: Use common/version.h.
2860
2861 2019-01-24  Pedro Alves  <palves@redhat.com>
2862
2863         * infrun.c (signal_stop, signal_print, signal_program)
2864         (signal_catch, signal_pass): Now arrays instead of pointers.
2865         (update_signals_program_target, do_target_resume)
2866         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2867         * linux-nat.c (linux_nat_target::pass_signals)
2868         (linux_nat_target::create_inferior, linux_nat_target::attach):
2869         Adjust.
2870         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2871         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2872         * procfs.c (procfs_target::pass_signals): Adjust.
2873         * record-full.c (record_full_target::resume): Adjust.
2874         * remote.c (remote_target::pass_signals)
2875         (remote_target::program_signals): Adjust.
2876         * target-debug.h (target_debug_print_signals): Now takes a
2877         gdb::array_view as parameter.  Adjust.
2878         * target.h (target_ops) <pass_signals, program_signals>: Replace
2879         pointer and length parameters with gdb::array_view.
2880         (target_pass_signals, target_program_signals): Likewise.
2881         * target-delegates.c: Regenerate.
2882
2883 2019-01-24  Pedro Alves  <palves@redhat.com>
2884
2885         * common/forward-scope-exit.h
2886         (forward_scope_exit::forward_scope_exit): Pass arguments to
2887         m_bind_function directly, instead of creating a std::bind and
2888         copying that.
2889
2890 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2891
2892         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2893         for static members.
2894         (pass_in_v_vfp_candidate): Likewise.
2895
2896 2019-01-23  Tom Tromey  <tom@tromey.com>
2897             Pedro Alves  <palves@redhat.com>
2898
2899         * regcache.c (class regcache_invalidator): Remove.
2900         (regcache::raw_write): Use make_scope_exit.
2901
2902 2019-01-23  Tom Tromey  <tom@tromey.com>
2903
2904         * ui-out.h (class ui_out_emit_type): Update comment.
2905
2906 2019-01-23  Tom Tromey  <tom@tromey.com>
2907
2908         * infrun.c (fetch_inferior_event): Update comment.
2909
2910 2019-01-23  Tom Tromey  <tom@tromey.com>
2911             Pedro Alves  <palves@redhat.com>
2912
2913         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2914         parameter.
2915         (fetch_inferior_event): Use SCOPE_EXIT.
2916
2917
2918 2019-01-23  Tom Tromey  <tom@tromey.com>
2919             Pedro Alves  <palves@redhat.com>
2920
2921         * infrun.c (disable_thread_events): Delete.
2922         (stop_all_threads): Use SCOPE_EXIT.
2923
2924 2019-01-23  Tom Tromey  <tom@tromey.com>
2925             Pedro Alves  <palves@redhat.com>
2926
2927         * symfile.c: Include forward-scope-exit.h.
2928         (clear_symtab_users_cleanup): Replace forward declaration with
2929         a FORWARD_SCOPE_EXIT.
2930         (syms_from_objfile_1): Use the forward_scope_exit and
2931         gdb::optional instead of cleanup_function.
2932         (reread_symbols): Use the forward_scope_exit instead of
2933         cleanup_function.
2934         (clear_symtab_users_cleanup): Remove function.
2935
2936 2019-01-23  Tom Tromey  <tom@tromey.com>
2937             Pedro Alves  <palves@redhat.com>
2938
2939         * linux-nat.c: Include scope-exit.h.
2940         (cleanup_target_stop): Remove.
2941         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2942         SCOPE_EXIT.
2943
2944 2019-01-23  Tom Tromey  <tom@tromey.com>
2945             Pedro Alves  <palves@redhat.com>
2946
2947         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2948         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2949
2950 2019-01-23  Tom Tromey  <tom@tromey.com>
2951             Andrew Burgess  <andrew.burgess@embecosm.com>
2952             Pedro Alves  <palves@redhat.com>
2953
2954         * infrun.c (fetch_inferior_event): Use scope_exit.
2955         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2956         * top.c (execute_command): Use scope_exit.
2957         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2958         * utils.c (do_bpstat_clear_actions_cleanup)
2959         (make_bpstat_clear_actions_cleanup): Remove.
2960
2961 2019-01-23  Tom Tromey  <tom@tromey.com>
2962             Pedro Alves  <palves@redhat.com>
2963
2964         * infrun.c: Include "common/scope-exit.h"
2965         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2966         (wait_for_inferior): Use SCOPE_EXIT.
2967         (fetch_inferior_event): Use scope_exit.
2968
2969 2019-01-23  Tom Tromey  <tom@tromey.com>
2970             Pedro Alves  <palves@redhat.com>
2971
2972         * breakpoint.c (create_breakpoint): Remove cleanup.
2973
2974 2019-01-23  Tom Tromey  <tom@tromey.com>
2975             Andrew Burgess  <andrew.burgess@embecosm.com>
2976             Pedro Alves  <palves@redhat.com>
2977
2978 2019-01-23  Pedro Alves  <palves@redhat.com>
2979
2980         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2981
2982 2019-01-23  Pedro Alves  <palves@redhat.com>
2983             Andrew Burgess  <andrew.burgess@embecosm.com>
2984
2985         * gdbthread.h: Include "common/forward-scope-exit.h".
2986         (scoped_finish_thread_state): Redefine custom class in terms of
2987         forward_scope_exit.
2988
2989 2019-01-23  Pedro Alves  <palves@redhat.com>
2990             Andrew Burgess  <andrew.burgess@embecosm.com>
2991
2992         * common/forward-scope-exit.h: New file.
2993
2994 2019-01-23  Pedro Alves  <palves@redhat.com>
2995             Andrew Burgess  <andrew.burgess@embecosm.com>
2996             Tom Tromey  <tom@tromey.com>
2997
2998         * common/scope-exit.h: New file.
2999
3000 2019-01-23  Pedro Alves  <palves@redhat.com>
3001
3002         * common/preprocessor.h (ESC): Rename to ...
3003         (ESC_PARENS): ... this.
3004         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3005         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3006
3007 2019-01-23  Tom Tromey  <tom@tromey.com>
3008
3009         * language.h (class scoped_switch_to_sym_language_if_auto):
3010         Initialize m_lang in both cases.
3011
3012 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3013
3014         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3015         with XCNEW.
3016
3017 2019-01-22  Tom Tromey  <tom@tromey.com>
3018
3019         * corelow.c: Do not include sys/file.h.
3020
3021 2019-01-22  Tom Tromey  <tom@tromey.com>
3022
3023         * tui/tui-wingeneral.h: Include gdb_curses.h.
3024
3025 2019-01-22  Tom Tromey  <tom@tromey.com>
3026
3027         * source-cache.h (class source_cache) <get_source_lines,
3028         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3029
3030 2019-01-22  Tom Tromey  <tom@tromey.com>
3031
3032         * remote-fileio.h (struct remote_target): Declare.
3033
3034 2019-01-22  Tom Tromey  <tom@tromey.com>
3035
3036         * python/py-arch.c: Do not include py-ref.h.
3037         * python/py-bpevent.c: Do not include py-ref.h.
3038         * python/py-cmd.c: Do not include py-ref.h.
3039         * python/py-continueevent.c: Do not include py-ref.h.
3040         * python/py-event.h: Do not include py-ref.h.
3041         * python/py-evtregistry.c: Do not include py-ref.h.
3042         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3043         * python/py-frame.c: Do not include py-ref.h.
3044         * python/py-framefilter.c: Do not include py-ref.h.
3045         * python/py-function.c: Do not include py-ref.h.
3046         * python/py-infevents.c: Do not include py-ref.h.
3047         * python/py-linetable.c: Do not include py-ref.h.
3048         * python/py-objfile.c: Do not include py-ref.h.
3049         * python/py-param.c: Do not include py-ref.h.
3050         * python/py-prettyprint.c: Do not include py-ref.h.
3051         * python/py-progspace.c: Do not include py-ref.h.
3052         * python/py-symbol.c: Do not include py-ref.h.
3053         * python/py-symtab.c: Do not include py-ref.h.
3054         * python/py-type.c: Do not include py-ref.h.
3055         * python/py-unwind.c: Do not include py-ref.h.
3056         * python/py-utils.c: Do not include py-ref.h.
3057         * python/py-value.c: Do not include py-ref.h.
3058         * python/py-varobj.c: Do not include py-ref.h.
3059         * python/py-xmethods.c: Do not include py-ref.h.
3060         * python/python.c: Do not include py-ref.h.
3061         * varobj.c: Do not include py-ref.h.
3062
3063 2019-01-22  Tom Tromey  <tom@tromey.com>
3064
3065         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3066         keyword for bcache.
3067
3068 2019-01-22  Tom Tromey  <tom@tromey.com>
3069
3070         * compile/compile-cplus-types.c: Remove a comment by #include.
3071
3072 2019-01-22  Tom Tromey  <tom@tromey.com>
3073
3074         * compile/gcc-c-plugin.h: Include compile-internal.h.
3075
3076 2019-01-22  Tom Tromey  <tom@tromey.com>
3077
3078         * stabsread.c (EXTERN): Do not define.
3079         (symnum, next_symbol_text_func, processing_gcc_compilation)
3080         (within_function, global_sym_chain, global_stabs)
3081         (previous_stab_code, this_object_header_files)
3082         (n_this_object_header_files)
3083         (n_allocated_this_object_header_files): Define.
3084         * stabsread.h (EXTERN): Never define.  Use "extern".
3085
3086 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3087
3088         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3089         history_value.
3090
3091 2019-01-21  Tom Tromey  <tom@tromey.com>
3092
3093         * ui-out.c: Fix includes.
3094         * tui/tui-source.c: Fix includes.
3095         * target.c: Fix includes.
3096         * remote.c: Fix includes.
3097         * regcache.c: Fix includes.
3098         * python/py-block.c: Fix includes.
3099         * printcmd.c: Fix includes.
3100         * or1k-tdep.c: Fix includes.
3101         * mi/mi-main.c: Fix includes.
3102         * m32r-tdep.c: Fix includes.
3103         * csky-tdep.c: Fix includes.
3104         * compile/compile-cplus-types.c: Fix includes.
3105         * cli/cli-interp.c: Fix includes.
3106
3107 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3108
3109         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3110         for padding.
3111
3112 2019-01-16  Tom Tromey  <tom@tromey.com>
3113
3114         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3115         earlier.
3116         (struct objfile) <msymbols_range>: Move from top level.
3117         <msymbols>: New method.
3118         (class objfile_msymbols): Remove.
3119         * symtab.c (default_collect_symbol_completion_matches_break_on):
3120         Update.
3121         * symmisc.c (dump_msymbols): Update.
3122         * stabsread.c (scan_file_globals): Update.
3123         * objc-lang.c (info_selectors_command, info_classes_command)
3124         (find_methods): Update.
3125         * minsyms.c (find_solib_trampoline_target): Update.
3126         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3127         * coffread.c (coff_symfile_read): Update.
3128         * ada-lang.c (ada_lookup_simple_minsym)
3129         (ada_collect_symbol_completion_matches): Update.
3130
3131 2019-01-16  Tom Tromey  <tom@tromey.com>
3132
3133         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3134         type.  Remove no-argument constructor.
3135         <iterator::operator++>: Simplify.
3136         <begin>: Update.
3137         <end>: Use minimal_symbol_count.
3138
3139 2019-01-16  Tom Tromey  <tom@tromey.com>
3140
3141         * objfiles.h (struct objfile) <psymtabs>: New method.
3142         (class objfile_psymtabs): Remove.
3143         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3144         typedef.
3145         <range>: New method.
3146         (require_partial_symbols): Change return type.
3147         * psymtab.c (require_partial_symbols)
3148         (psym_expand_symtabs_matching): Update.
3149         * mdebugread.c (parse_partial_symbols): Update.
3150         * dbxread.c (dbx_end_psymtab): Update.
3151
3152 2019-01-15  Tom Tromey  <tom@tromey.com>
3153
3154         * symtab.c (lookup_objfile_from_block)
3155         (lookup_symbol_in_objfile_symtabs)
3156         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3157         (find_line_symtab, info_sources_command)
3158         (default_collect_symbol_completion_matches_break_on)
3159         (make_source_files_completion_list): Update.
3160         * symmisc.c (print_objfile_statistics, dump_objfile)
3161         (maintenance_print_symbols, maintenance_info_symtabs)
3162         (maintenance_check_symtabs, maintenance_info_line_tables):
3163         Update.
3164         * source.c (select_source_symtab)
3165         (forget_cached_source_info_for_objfile): Update.
3166         * objfiles.h (class objfile_compunits): Remove.
3167         (struct objfile) <compunits_range>: New typedef.
3168         (compunits): New method.
3169         * objfiles.c (objfile_relocate1): Update.
3170         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3171         * maint.c (count_symtabs_and_blocks): Update.
3172         * linespec.c (iterate_over_all_matching_symtabs): Update.
3173         * cp-support.c (add_symbol_overload_list_qualified): Update.
3174         * coffread.c (coff_symtab_read): Update.
3175         * ada-lang.c (add_nonlocal_symbols)
3176         (ada_collect_symbol_completion_matches)
3177         (ada_add_global_exceptions): Update.
3178
3179 2019-01-15  Tom Tromey  <tom@tromey.com>
3180
3181         * progspace.h (program_space) <objfiles_safe_range>: New
3182         typedef.
3183         <objfiles_safe>: New method.
3184         * objfiles.h (class all_objfiles_safe): Remove.
3185         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3186         * jit.c (jit_inferior_exit_hook): Update.
3187
3188 2019-01-17  Tom Tromey  <tom@tromey.com>
3189
3190         * progspace.h (program_space) <objfiles_range>: New typedef.
3191         <objfiles>: New method.
3192         <objfiles_head>: Rename from objfiles.
3193         (object_files): Update.
3194         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3195         * guile/scm-pretty-print.c
3196         (ppscm_find_pretty_printer_from_objfiles): Update.
3197         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3198         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3199         Update.
3200         * python/py-progspace.c (pspy_get_objfiles): Update.
3201         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3202         Update.
3203         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3204         (objfpy_lookup_objfile_by_build_id): Update.
3205         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3206         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3207         Update.
3208         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3209         (expand_symtab_containing_pc, lookup_objfile_from_block)
3210         (lookup_static_symbol, basic_lookup_transparent_type)
3211         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3212         (find_line_symtab, info_sources_command)
3213         (default_collect_symbol_completion_matches_break_on)
3214         (make_source_files_completion_list, find_main_name): Update.
3215         * symmisc.c (print_symbol_bcache_statistics)
3216         (print_objfile_statistics, maintenance_print_symbols)
3217         (maintenance_print_msymbols, maintenance_print_objfiles)
3218         (maintenance_info_symtabs, maintenance_check_symtabs)
3219         (maintenance_expand_symtabs, maintenance_info_line_tables):
3220         Update.
3221         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3222         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3223         (map_overlay_command, unmap_overlay_command)
3224         (simple_overlay_update, expand_symtabs_matching)
3225         (map_symbol_filenames): Update.
3226         * symfile-debug.c (set_debug_symfile): Update.
3227         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3228         Update.
3229         * source.c (select_source_symtab, forget_cached_source_info):
3230         Update.
3231         * solib.c (solib_read_symbols): Update.
3232         * solib-spu.c (append_ocl_sos): Update.
3233         * psymtab.c (maintenance_print_psymbols)
3234         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3235         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3236         * printcmd.c (info_symbol_command): Update.
3237         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3238         Update.
3239         * objfiles.h (class all_objfiles): Remove.
3240         * objfiles.c (have_partial_symbols, have_full_symbols)
3241         (have_minimal_symbols, qsort_cmp, update_section_map)
3242         (shared_objfile_contains_address_p)
3243         (default_iterate_over_objfiles_in_search_order): Update.
3244         * objc-lang.c (info_selectors_command, info_classes_command)
3245         (find_methods): Update.
3246         * minsyms.c (find_solib_trampoline_target): Update.
3247         * maint.c (maintenance_info_sections)
3248         (maintenance_translate_address, count_symtabs_and_blocks):
3249         Update.
3250         * main.c (captured_main_1): Update.
3251         * linux-thread-db.c (try_thread_db_load_from_pdir)
3252         (has_libpthread): Update.
3253         * linespec.c (iterate_over_all_matching_symtabs)
3254         (search_minsyms_for_name): Update.
3255         * jit.c (jit_find_objf_with_entry_addr): Update.
3256         * hppa-tdep.c (find_unwind_entry)
3257         (hppa_lookup_stub_minimal_symbol): Update.
3258         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3259         Update.
3260         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3261         (elf_gnu_ifunc_resolve_by_got): Update.
3262         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3263         * dwarf-index-write.c (save_gdb_index_command): Update.
3264         * cp-support.c (add_symbol_overload_list_qualified): Update.
3265         * breakpoint.c (create_overlay_event_breakpoint)
3266         (create_longjmp_master_breakpoint)
3267         (create_std_terminate_master_breakpoint)
3268         (create_exception_master_breakpoint): Update.
3269         * blockframe.c (find_pc_partial_function): Update.
3270         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3271         (ada_collect_symbol_completion_matches)
3272         (ada_add_global_exceptions): Update.
3273
3274 2019-01-17  Tom Tromey  <tom@tromey.com>
3275
3276         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3277         declare VEC.
3278         (solib_target_parse_libraries): Change return type.
3279         (library_list_start_segment, library_list_start_section)
3280         (library_list_end_library, library_list_start_library); Update.
3281         (solib_target_free_library_list): Remove.
3282         (solib_target_parse_libraries): Remove cleanup.  Change return
3283         type.
3284         (solib_target_current_sos): Update.
3285
3286 2019-01-17  Tom Tromey  <tromey@bapiya>
3287
3288         * valprint.c: Replace "the the" with "the".
3289         * symtab.c: Replace "the the" with "the".
3290         * solib.c: Replace "the the" with "the".
3291         * solib-dsbt.c: Replace "the the" with "the".
3292         * linespec.c: Replace "the the" with "the".
3293         * dwarf2loc.h: Replace "the the" with "the".
3294         * amd64-windows-tdep.c: Replace "the the" with "the".
3295         * aarch64-tdep.c: Replace "the the" with "the".
3296
3297 2019-01-16  Keith Seitz  <keiths@redhat.com>
3298
3299         PR gdb/23773
3300         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3301         <builder>: Rename to ..
3302         <m_builder>: ... this and make private.
3303         (dwarf2_cu::get_builder): New method.  Change all users of
3304         `builder' to use this method.
3305         (dwarf2_start_symtab): Move to ...
3306         (dwarf2_cu::start_symtab): ... here.  Update all callers
3307         (setup_type_unit_groups): Move to ...
3308         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3309         callers.
3310         (dwarf2_cu::reset_builder): New method.
3311         (process_full_compunit, process_full_type_unit): Use
3312         dwarf2_cu::reset_builder.
3313         (follow_die_offset): Record the ancestor CU if it is different
3314         from the followed DIE's CU.
3315         (follow_die_sig_1): Likewise.
3316
3317 2019-01-15  Tom Tromey  <tom@tromey.com>
3318
3319         * remote.c (class remote_state) <buf>: Now a char_vector.
3320         <buf_size>: Remove.
3321         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3322         parameter.
3323         (remote_target::getpkt_or_notif_sane_1)
3324         (remote_target::getpkt_sane)
3325         (remote_target::getpkt_or_notif_sane): Likewise.
3326         (class remote_target) <putpkt>: New overload.
3327         (remote_target::read_frame): Change type of "buf_p".  Remove
3328         sizeof_p parameter.
3329         (packet_ok): New overload.
3330         (packet_check_result): New overload.
3331         Update all uses.
3332
3333 2019-01-14  Tom Tromey  <tom@tromey.com>
3334
3335         * remote-notif.c (handle_notification, remote_notif_ack)
3336         (remote_notif_parse): Make "buf" const.
3337         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3338         const.
3339         (remote_notif_parse, remote_notif_ack, handle_notification):
3340         Likewise.
3341         * remote.c (remote_notif_stop_parse): Make "buf" const.
3342         (remote_target::remote_parse_stop_reply): Make "buf" const.
3343         (remote_notif_stop_ack): Make "buf" const.
3344
3345 2019-01-14  Tom Tromey  <tom@tromey.com>
3346
3347         * remote.c (remote_console_output): Make parameter const.
3348
3349 2019-01-14  Tom Tromey  <tom@tromey.com>
3350
3351         * target-debug.h (target_debug_print_signals): Constify.
3352         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3353         * procfs.c (procfs_target::pass_signals): Update.
3354         * linux-nat.c (linux_nat_target::pass_signals): Update.
3355         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3356         * target-delegates.c: Rebuild.
3357         * remote.c (remote_target::program_signals): Update.
3358         (remote_target::pass_signals): Update.
3359         * target.c (target_pass_signals): Constify argument.
3360         (target_program_signals): Likewise.
3361         * target.h (struct target_ops) <pass_signals, program_signals>:
3362         Constify argument.
3363         (target_pass_signals, target_program_signals): Constify argument.
3364
3365 2019-01-14  Tom Tromey  <tom@tromey.com>
3366
3367         PR tui/28819:
3368         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3369
3370 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3371
3372         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3373         field.
3374         * rs6000-tdep.c: Include reggroups.h.
3375         (IS_V_ALIAS_PSEUDOREG): Define.
3376         (rs6000_register_name): Return names for the "vX" aliases.
3377         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3378         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3379         aliases.  Call default_register_reggroup_p for all other
3380         pseudo-registers.
3381         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3382         New functions.
3383         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3384         Handle "vX" aliases.
3385         (v_alias_pseudo_register_collect): New function.
3386         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3387         (rs6000_gdbarch_init): Initialize "vX" aliases as
3388         pseudo-registers.  Restore registration of
3389         rs6000_pseudo_register_reggroup_p with
3390         set_tdesc_pseudo_register_reggroup_p.
3391
3392 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3393
3394         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3395         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3396         set_gdbarch_num_pseudo_regs.
3397
3398 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3399
3400         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3401         Remove arg prefixname, add do_set and do_show.
3402         Add member functions set_list and show_list.
3403         * cli/cli-style.c (class cli_style_option): Update accordingly.
3404         (style_set_list): Move to file scope.
3405         (style_show_list): Likewise.
3406         (set_style): Call help_list.
3407         (show_style): Call cmd_show_list.
3408         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3409         Update to use the new macro.
3410
3411 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3412
3413         * ada-lang.c (_initialize_ada_language): Expand the help text
3414         for the "catch exception" command.
3415
3416 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3417
3418         * symtab.c (matching_obj_sections): Initialize obj,
3419         declare it closer to its usage.
3420
3421 2019-01-10  Tom Tromey  <tom@tromey.com>
3422
3423         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3424         (basic_inf_threads_range): Remove.
3425         (inf_threads_range, inf_non_exited_threads_range)
3426         (safe_inf_threads_range): Use next_adapter.
3427
3428 2019-01-10  Keith Seitz  <keiths@redhat.com>
3429
3430         PR gdb/23712
3431         PR symtab/23010
3432         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3433         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3434
3435 2019-01-10  Keith Seitz  <keiths@redhat.com>
3436
3437         PR gdb/23712
3438         PR symtab/23010
3439         * dictionary.c (pending_to_vector): Remove.
3440         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3441         Remove _1 suffix, replacing functions of the same name.  Update
3442         all callers.
3443         (dict_create_hashed, dict_create_hashed_expandable)
3444         (dict_create_linear, dict_create_linear_expandable, dict_free)
3445         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3446         Make functions static.
3447
3448 2019-01-10  Keith Seitz  <keiths@redhat.com>
3449
3450         PR gdb/23712
3451         PR symtab/23010
3452         * dictionary.h (struct dictionary): Replace declaration with
3453         multidictionary.
3454         (dict_create_hashed, dict_create_hashed_expandable)
3455         (dict_create_linear, dict_create_linear_expandable)
3456         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3457         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3458         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3459         taking multidictionary argument.
3460         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3461         * block.h (struct block) <dict>: Change to multidictionary
3462         and rename `multidict'.
3463         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3464         symmisc.c: Update all dictionary references to multidictionary.
3465
3466 2019-01-10  Keith Seitz  <keiths@redhat.com>
3467
3468         PR gdb/23712
3469         PR symtab/23010
3470         * dictionary.c: Include unordered_map.
3471         (pending_to_vector): New function.
3472         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3473         Rewrite the non-"_1" functions to take vector instead
3474         of linked list.
3475         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3476         "new" _1 versions of the same name.
3477         (multidictionary): Define.
3478         (std::hash<enum language): New definition.
3479         (collate_pending_symbols_by_language, mdict_create_hashed)
3480         (mdict_create_hashed_expandable, mdict_create_linear)
3481         (mdict_create_linear_expandable, mdict_free)
3482         (find_language_dictionary, create_new_language_dictionary)
3483         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3484         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3485         (mdict_size, mdict_empty): New functions.
3486         * dictionary.h (mdict_iterator): Define.
3487
3488 2019-01-10  Pedro Alves  <palves@redhat.com>
3489
3490         * breakpoint.c (read_uploaded_action)
3491         (create_tracepoint_from_upload): Adjust to use
3492         gdb::unique_xmalloc_ptr.
3493         * ctf.c (ctf_write_uploaded_tp):
3494         (SET_ARRAY_FIELD): Use emplace_back.
3495         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3496         * tracefile-tfile.c (tfile_write_uploaded_tp):
3497         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3498         gdb::unique_xmalloc_ptr.
3499         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3500         at_string, cond_string, cmd_strings>: Replace char pointers
3501         with gdb::unique_xmalloc_ptr.
3502
3503 2019-01-10  Pedro Alves  <palves@redhat.com>
3504
3505         * solib-target.c (library_list_start_library): Don't xstrdup name.
3506
3507 2019-01-10  Pedro Alves  <palves@redhat.com>
3508
3509         * mdebugread.c (parse_partial_symbols): Use
3510         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3511
3512 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3513
3514         * linux-fork.c (scoped_switch_fork_info)
3515         <~scoped_switch_fork_info>: Fix incorrect variable name.
3516
3517 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3518
3519         * linux-fork.c (scoped_switch_fork_info)
3520         <scoped_switch_fork_info>: Make explicit.
3521         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3522
3523 2019-01-10  Tom Tromey  <tom@tromey.com>
3524
3525         * objfiles.h (objfile::reset_psymtabs): Update.
3526         * objfiles.c (objfile::objfile): Update.
3527         * psymtab.h (psymtab_storage::obstack): Update.
3528         (psymtab_storage::m_obstack): Use gdb::optional.
3529         (class psymtab_storage): Update comment.  Remove objfile
3530         parameter.
3531         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3532
3533 2019-01-10  Tom Tromey  <tom@tromey.com>
3534
3535         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3536         <free_psymtabs>: Now private.
3537         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3538         (allocate_psymtab): Use new method.
3539
3540 2019-01-10  Tom Tromey  <tom@tromey.com>
3541
3542         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3543         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3544         * mdebugread.c (parse_partial_symbols): Use
3545         allocate_dependencies.
3546         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3547         allocate_dependencies.
3548         (process_psymtab_comp_unit_reader)
3549         (build_type_psymtab_dependencies): Likewise.
3550         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3551
3552 2019-01-10  Tom Tromey  <tom@tromey.com>
3553
3554         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3555         PSYMBOL_SET_LANGUAGE.
3556         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3557
3558 2019-01-10  Tom Tromey  <tom@tromey.com>
3559
3560         * psymtab.h (psymtab_storage::obstack): New method.
3561         <m_obstack>: Rename from obstack; now private.
3562         * psymtab.c (psymtab_storage): Update.
3563         * dwarf2read.c (create_addrmap_from_index)
3564         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3565         Update.
3566
3567 2019-01-10  Tom Tromey  <tom@tromey.com>
3568
3569         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3570         * objfiles.h (objfile::reset_psymtabs): New method.
3571
3572 2019-01-10  Tom Tromey  <tom@tromey.com>
3573
3574         * symmisc.c (print_symbol_bcache_statistics): Update.
3575         (print_objfile_statistics): Update.
3576         * symfile.c (reread_symbols): Update.
3577         * psymtab.h (class psymtab_storage): New.
3578         * psymtab.c (psymtab_storage): New constructor.
3579         (~psymtab_storage): New destructor.
3580         (require_partial_symbols): Update.
3581         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3582         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3583         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3584         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3585         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3586         (start_psymtab_common, end_psymtab_common)
3587         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3588         (allocate_psymtab): Update.
3589         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3590         Update.
3591         (dump_psymtab_addrmap, maintenance_print_psymbols)
3592         (maintenance_check_psymtabs): Update.
3593         (class objfile_psymtabs): Move to objfiles.h.
3594         * psympriv.h (discard_psymtab): Now inline.
3595         (psymtab_discarder::psymtab_discarder): Update.
3596         (psymtab_discarder::~psymtab_discarder): Update.
3597         (ALL_OBJFILE_PSYMTABS): Rewrite.
3598         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3599         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3600         Remove fields.
3601         <partial_symtabs>: New field.
3602         (class objfile_psymtabs): Move from psymtab.h.  Update.
3603         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3604         psymbol_cache.
3605         (objfile::~objfile): Don't destroy psymbol_cache.
3606         * mdebugread.c (parse_partial_symbols): Update.
3607         * dwarf2read.c (create_addrmap_from_index)
3608         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3609         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3610         (add_partial_subprogram, dwarf2_ranges_read): Update.
3611         * dwarf-index-write.c (write_address_map)
3612         (write_one_signatured_type, recursively_write_psymbols)
3613         (class debug_names, class debug_names, write_psymtabs_to_index):
3614         Update.
3615
3616 2019-01-10  Tom Tromey  <tom@tromey.com>
3617
3618         * symtab.h (SYMBOL_SET_NAMES): Update.
3619         (symbol_set_names): Update.
3620         (MSYMBOL_SET_NAMES): Update.
3621         * symtab.c (symbol_set_names): Change argument to be an
3622         objfile_per_bfd_storage.
3623         * psymtab.c (add_psymbol_to_bcache): Update.
3624         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3625
3626 2019-01-10  Tom Tromey  <tom@tromey.com>
3627
3628         * symtab.c (create_demangled_names_hash): Change argument to be an
3629         objfile_per_bfd_storage.
3630         (symbol_set_names): Update.
3631
3632 2019-01-10  Tom Tromey  <tom@tromey.com>
3633
3634         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3635         init_psymbol_list.
3636         * psymtab.c (init_psymbol_list): Do nothing if already called.
3637         * psympriv.h (init_psymbol_list): Add comment.
3638         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3639         init_psymbol_list.
3640         * dbxread.c (dbx_symfile_read): Unconditionally call
3641         init_psymbol_list.
3642
3643 2019-01-10  Tom Tromey  <tom@tromey.com>
3644
3645         * xcoffread.c (scan_xcoff_symtab): Update.
3646         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3647         "where".
3648         * mdebugread.c (parse_partial_symbols)
3649         (handle_psymbol_enumerators): Update.
3650         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3651         * dbxread.c (read_dbx_symtab): Update.
3652         * psympriv.h (psymbol_placement): New enum.
3653         (add_psymbol_to_list): Update.
3654
3655 2019-01-10  Tom Tromey  <tom@tromey.com>
3656
3657         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3658         static_psymbols parameters.
3659         (scan_xcoff_symtab): Update.
3660         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3661         static_psymbols parameters.
3662         * psympriv.h (start_psymtab_common): Update.
3663         * mdebugread.c (parse_partial_symbols): Update.
3664         * dwarf2read.c (create_partial_symtab): Update.
3665         * dbxread.c (read_dbx_symtab): Update.
3666         (start_psymtab): Remove global_psymbols and static_psymbols
3667         parameters.
3668
3669 2019-01-10  Tom Tromey  <tom@tromey.com>
3670
3671         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3672         * psymtab.c (allocate_psymtab): Add comment.
3673         * psympriv.h (allocate_psymtab): Add comment.
3674         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3675         initializations.
3676         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3677
3678 2019-01-10  Tom Tromey  <tom@tromey.com>
3679
3680         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3681         Don't declare.
3682         * mipsread.c: Include mdebugread.h.
3683         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3684         Declare.
3685         * elfread.c: Include mdebugread.h.
3686
3687 2019-01-09  Tom Tromey  <tom@tromey.com>
3688
3689         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3690         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3691         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3692         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3693         (psym_lookup_symbol, psym_find_last_source_symtab)
3694         (psym_forget_cached_source_info, psym_print_stats)
3695         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3696         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3697         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3698         (psym_find_compunit_symtab_by_address)
3699         (maintenance_print_psymbols, maintenance_info_psymtabs)
3700         (maintenance_check_psymtabs): Use ranged for.
3701         * psymtab.h (class objfile_psymtabs): New.
3702         (require_partial_symbols): Return objfile_psymtabs.
3703         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3704
3705 2019-01-09  Tom Tromey  <tom@tromey.com>
3706
3707         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3708         (find_pc_mapped_section, list_overlays_command)
3709         (map_overlay_command, unmap_overlay_command)
3710         (simple_overlay_update): Use all_objfiles.
3711         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3712         * printcmd.c (info_symbol_command): Use all_objfiles.
3713         * objfiles.h (ALL_OBJSECTIONS): Remove.
3714         * maint.c (maintenance_translate_address): Use all_objfiles.
3715         * gcore.c (gcore_create_callback): Use all_objfiles.
3716         (objfile_find_memory_regions): Likewise.
3717
3718 2019-01-09  Tom Tromey  <tom@tromey.com>
3719
3720         * symtab.c (find_line_symtab, info_sources_command)
3721         (make_source_files_completion_list): Use objfile_compunits.
3722         * source.c (select_source_symtab): Use objfile_compunits.
3723         * objfiles.h (struct objfile): Update comment.
3724         (ALL_OBJFILES): Remove.
3725         (ALL_FILETABS): Remove.
3726         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3727         objfile_compunits.
3728
3729 2019-01-09  Tom Tromey  <tom@tromey.com>
3730
3731         * symmisc.c (print_objfile_statistics, dump_objfile)
3732         (maintenance_print_symbols): Use compunit_filetabs.
3733         * source.c (forget_cached_source_info_for_objfile): Use
3734         compunit_filetabs.
3735         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3736         (ALL_FILETABS): Use compunit_filetabs.
3737         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3738         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3739
3740 2019-01-09  Tom Tromey  <tom@tromey.com>
3741
3742         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3743         (compunit_filetabs): New.
3744         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3745         compunit_filetabs.
3746         (info_sources_command, make_source_files_completion_list): Remove
3747         declaration.
3748         * symmisc.c (print_objfile_statistics, dump_objfile)
3749         (maintenance_print_symbols): Remove declaration.
3750         (maintenance_info_symtabs): Use compunit_filetabs.
3751         (maintenance_info_line_tables): Likewise.
3752         * source.c (select_source_symtab): Change local variable name.
3753         (forget_cached_source_info_for_objfile): Remove declaration.
3754         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3755         * objfiles.c (objfile_relocate1): Remove declaration.
3756         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3757         declaration.
3758         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3759         * coffread.c (coff_symtab_read): Remove declaration.
3760         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3761         compunit_filetabs.
3762
3763 2019-01-09  Tom Tromey  <tom@tromey.com>
3764
3765         * symtab.c (lookup_objfile_from_block)
3766         (find_pc_sect_compunit_symtab, search_symbols)
3767         (default_collect_symbol_completion_matches_break_on): Use
3768         objfile_compunits.
3769         * objfiles.h (ALL_COMPUNITS): Remove.
3770         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3771         * cp-support.c (add_symbol_overload_list_qualified): Use
3772         objfile_compunits.
3773         * ada-lang.c (ada_collect_symbol_completion_matches)
3774         (ada_add_global_exceptions): Use objfile_compunits.
3775
3776 2019-01-09  Tom Tromey  <tom@tromey.com>
3777
3778         * source.c (select_source_symtab)
3779         (forget_cached_source_info_for_objfile): Remove declaration.
3780         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3781         declaration.
3782         * maint.c (count_symtabs_and_blocks): Remove declaration.
3783         * cp-support.c (add_symbol_overload_list_qualified): Remove
3784         declaration.
3785         * coffread.c (coff_symtab_read): Remove declaration.
3786         * symtab.c (lookup_symbol_in_objfile_symtabs)
3787         (basic_lookup_transparent_type_1): Use objfile_compunits.
3788         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3789         (info_sources_command, search_symbols)
3790         (default_collect_symbol_completion_matches_break_on)
3791         (make_source_files_completion_list): Remove declaration.
3792         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3793         (ada_collect_symbol_completion_matches)
3794         (ada_add_global_exceptions): Remove declaration.
3795         * linespec.c (iterate_over_all_matching_symtabs): Use
3796         objfile_compunits.
3797         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3798         (class objfile_compunits): New.
3799         (ALL_COMPUNITS): Use objfile_compunits.
3800         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3801         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3802         objfile_compunits.
3803         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3804
3805 2019-01-09  Tom Tromey  <tom@tromey.com>
3806
3807         * symtab.c (search_symbols)
3808         (default_collect_symbol_completion_matches_break_on): Use
3809         objfile_msymbols.
3810         * ada-lang.c (ada_lookup_simple_minsym)
3811         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3812         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3813         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3814         objfile_msymbols.
3815         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3816         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3817         * objc-lang.c (find_methods): Use objfile_msymbols.
3818         (info_selectors_command, info_classes_command): Likewise.
3819         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3820         * objfiles.h (class objfile_msymbols): New.
3821         (ALL_OBJFILE_MSYMBOLS): Remove.
3822         (ALL_MSYMBOLS): Remove.
3823
3824 2019-01-09  Tom Tromey  <tom@tromey.com>
3825
3826         * common/next-iterator.h (next_adapter): Add Iterator template
3827         parameter.
3828         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3829         (class all_objfiles_safe): New.
3830         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3831         * objfiles.c (put_objfile_before): Update comment.
3832         (add_separate_debug_objfile): Likewise.
3833         (free_all_objfiles): Use all_objfiles_safe.
3834         (objfile_purge_solibs): Likewise.
3835
3836 2019-01-09  Tom Tromey  <tom@tromey.com>
3837
3838         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3839         (expand_symtab_containing_pc, lookup_static_symbol)
3840         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3841         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3842         all_objfiles.
3843         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3844         * breakpoint.c (create_overlay_event_breakpoint)
3845         (create_longjmp_master_breakpoint)
3846         (create_std_terminate_master_breakpoint)
3847         (create_exception_master_breakpoint): Use all_objfiles.
3848         * linux-thread-db.c (try_thread_db_load_from_pdir)
3849         (has_libpthread): Use all_objfiles.
3850         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3851         * linespec.c (iterate_over_all_matching_symtabs)
3852         (search_minsyms_for_name): Use all_objfiles.
3853         * maint.c (maintenance_info_sections): Use all_objfiles.
3854         * main.c (captured_main_1): Use all_objfiles.
3855         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3856         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3857         * guile/scm-pretty-print.c
3858         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3859         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3860         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3861         (maintenance_print_msymbols): Use all_objfiles.
3862         * source.c (select_source_symtab): Use all_objfiles.
3863         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3864         * symfile.c (remove_symbol_file_command)
3865         (expand_symtabs_matching, map_symbol_filenames): Use
3866         all_objfiles.
3867         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3868         all_objfiles.
3869         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3870         * objc-lang.c (find_methods): Use all_objfiles.
3871         * objfiles.c (have_partial_symbols, have_full_symbols)
3872         (have_minimal_symbols, qsort_cmp)
3873         (default_iterate_over_objfiles_in_search_order): Use
3874         all_objfiles.
3875         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3876         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3877         (maintenance_check_psymtabs): Use all_objfiles.
3878         (ALL_PSYMTABS): Remove.
3879         * compile/compile-object-run.c (do_module_cleanup): Use
3880         all_objfiles.
3881         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3882         * cp-support.c (add_symbol_overload_list_qualified): Use
3883         all_objfiles.
3884         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3885         Use all_objfiles.
3886         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3887         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3888         all_objfiles.
3889         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3890         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3891         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3892         Uses all_objfiles.
3893         * solib.c (solib_read_symbols): Use all_objfiles
3894
3895 2019-01-09  Tom Tromey  <tom@tromey.com>
3896
3897         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3898         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3899         all_objfiles.
3900         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3901         * symmisc.c (print_symbol_bcache_statistics)
3902         (print_objfile_statistics, maintenance_print_objfiles)
3903         (maintenance_info_symtabs, maintenance_check_symtabs)
3904         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3905         all_objfiles.
3906         * source.c (forget_cached_source_info): Use all_objfiles.
3907         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3908         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3909         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3910         * objfiles.c (update_section_map): Use all_objfiles.
3911         (shared_objfile_contains_address_p): Likewise.
3912         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3913         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3914
3915 2019-01-09  Tom Tromey  <tom@tromey.com>
3916
3917         * common/next-iterator.h: New file.
3918         * objfiles.h (class all_objfiles): New.
3919         (struct objfile_iterator): New.
3920
3921 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3922
3923         * NEWS: Move the description of the changed "frame", "select-frame",
3924          and "info frame" commands to the Changed commands section.
3925
3926 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3927
3928         * gdbtypes.c (check_stub_method_group): Remove handling of old
3929         mangling schemes.
3930         * linespec.c (find_methods): Likewise.
3931         * stabsread.c (read_member_functions): Likewise.
3932         * valops.c (search_struct_method): Likewise.
3933         (value_struct_elt_for_reference): Likewise.
3934         * NEWS: Mention this change.
3935
3936 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3937
3938         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3939         print_source_lines.
3940         * source.c (print_source_lines_base): Update line number check.
3941         (print_source_lines): New function.
3942         (source_lines_range::source_lines_range): New function.
3943         * source.h (class source_lines_range): New class.
3944         (print_source_lines): New declaration.
3945
3946 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3947
3948         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3949
3950 2019-01-08  Tom Tromey  <tom@tromey.com>
3951             Simon Marchi  <simon.marchi@ericsson.com>
3952
3953         PR gdb/24060
3954         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3955         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3956         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3957         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3958         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3959         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3960
3961 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3962
3963         * source.c (select_source_symtab): Move header comment to
3964         declaration in source.h.
3965         (forget_cached_source_info_for_objfile): Likewise.
3966         (forget_cached_source_info): Likewise.
3967         (identify_source_line): Likewise.
3968         * source.h (identify_source_line): Move declaration from symtab.h
3969         and add comment from source.c
3970         (print_source_lines): Likewise.
3971         (forget_cached_source_info_for_objfile): Likewise.
3972         (forget_cached_source_info): Likewise.
3973         (select_source_symtab): Likewise.
3974         (enum print_source_lines_flag): Move definition from symtab.h.
3975         * symtab.h (identify_source_line): Move declaration to source.h.
3976         (print_source_lines): Likewise.
3977         (forget_cached_source_info_for_objfile): Likewise.
3978         (forget_cached_source_info): Likewise.
3979         (select_source_symtab): Likewise.
3980         (enum print_source_lines_flag): Move definition to source.h.
3981         * tui/tui-hooks.c: Add 'source.h' include.
3982
3983 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3984
3985         * source.c (print_source_lines_base): Handle requests to print
3986         reverse line number sequences, and guard against empty lines
3987         string.
3988
3989 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3990
3991         * source.c (print_source_lines_base): Fix skip of '\r' if next
3992         character is '\n'.
3993
3994 2019-01-06  Tom Tromey  <tom@tromey.com>
3995
3996         * c-exp.y (struct c_parse_state) <macro_original_text,
3997         expansion_obstack>: New member.
3998         (macro_original_text, expansion_obstack): Remove globals.
3999         (scan_macro_expansion, scanning_macro_expansion)
4000         (finished_macro_expansion): Update.
4001         (scan_macro_cleanup): Remove.
4002         (yylex, c_parse): Update.
4003
4004 2019-01-06  Tom Tromey  <tom@tromey.com>
4005
4006         * c-exp.y (struct c_parse_state) <strings>: New member.
4007         (operator_stoken): Update.
4008
4009 2019-01-06  Tom Tromey  <tom@tromey.com>
4010
4011         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4012         (union type_stack_elt) <typelist_val>: Now a pointer to
4013         std::vector.
4014         (type_stack_cleanup): Don't declare.
4015         (push_typelist): Update.
4016         * parse.c (pop_typelist): Return a std::vector.
4017         (push_typelist): Take a std::vector.
4018         (follow_types): Update.  Do not free args.
4019         (type_stack_cleanup): Remove.
4020         * c-exp.y (struct c_parse_state): New.
4021         (cpstate): New global.
4022         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4023         (nonempty_typelist): Update.
4024         (func_mod): Create a new vector.
4025         (c_parse): Create a c_parse_state.
4026         (check_parameter_typelist): Do not delete params.
4027         (function_method): Update.  Do not delete type_list.
4028
4029 2019-01-06  Tom Tromey  <tom@tromey.com>
4030
4031         PR gdb/28155:
4032         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4033         check_typedef.
4034         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4035         (print_return_value): Likewise.
4036
4037 2019-01-05  Tom Tromey  <tom@tromey.com>
4038
4039         * contrib/cleanup_check.py: Remove.
4040         * contrib/gcc-with-excheck: Remove.
4041         * contrib/exsummary.py: Remove.
4042         * contrib/excheck.py: Remove.
4043
4044 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4045
4046         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4047         NULL. Initialize tpprev to NULL instead of assigning it
4048         to NULL on the next statement.
4049         * windows-nat.c (windows_delete_thread): Remove check for
4050         main_thread_id before printing thread exit notifications.
4051         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4052         Remove thread ID check against main_thread_id.
4053         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4054         windows_delete_thread.
4055         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4056
4057 2019-01-04  Tom Tromey  <tom@tromey.com>
4058
4059         * compile/compile.c (_initialize_compile): Use upper case for
4060         metasyntactic variables.
4061         * symmisc.c (_initialize_symmisc): Use upper case for
4062         metasyntactic variables.
4063         * psymtab.c (_initialize_psymtab): Use upper case for
4064         metasyntactic variables.
4065         * demangle.c (demangle_command): Use upper case for metasyntactic
4066         variables.
4067         (_initialize_demangler): Likewise.
4068         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4069         variables.
4070
4071 2019-01-03  Tom Tromey  <tom@tromey.com>
4072
4073         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4074
4075 2019-01-03  Tom Tromey  <tom@tromey.com>
4076
4077         * python/py-symtab.c (salpy_str): Update.
4078         (struct salpy_sal_object) <symtab>: Now a PyObject.
4079         (salpy_dealloc): Update.
4080         (del_objfile_sal): Use gdbpy_ref.
4081
4082 2019-01-03  Tom Tromey  <tom@tromey.com>
4083
4084         * python/py-type.c (convert_field): Use new_reference.  Return
4085         gdbpy_ref.
4086         (make_fielditem): Return gdbpy_ref.
4087         (typy_fields): Update.
4088         (typy_getitem): Update.
4089         (field_name): Return gdbpy_ref.  Use new_reference.
4090         (typy_iterator_iternext): Update.
4091
4092 2019-01-03  Tom Tromey  <tom@tromey.com>
4093
4094         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4095
4096 2019-01-03  Tom Tromey  <tom@tromey.com>
4097
4098         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4099         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4100         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4101         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4102         (pspy_set_type_printers): Likewise.
4103         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4104         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4105         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4106         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4107         (objfpy_set_type_printers): Likewise.
4108
4109 2019-01-03  Tom Tromey  <tom@tromey.com>
4110
4111         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4112         (gdbpy_print_stack): Use gdbpy_err_fetch.
4113         * python/python-internal.h (class gdbpy_err_fetch): New class.
4114         (class gdbpy_enter) <m_error_type, m_error_value,
4115         m_error_traceback>: Remove.
4116         <m_error>: New member.
4117         (gdbpy_exception_to_string): Don't declare.
4118         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4119         * python/py-value.c (convert_value_from_python): Use
4120         gdbpy_err_fetch.
4121         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4122         gdbpy_exception_to_string.
4123         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4124         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4125         gdbpy_err_fetch.
4126
4127 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4128
4129         * linux-nat.c (delete_lwp_cleanup): Delete.
4130         (struct lwp_deleter): New struct.
4131         (lwp_info_up): New typedef.
4132         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4133         lwp_info_up.
4134
4135 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4136
4137         * linux-fork.c (class scoped_switch_fork_info): New class.
4138         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4139
4140 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4141
4142         * valops.c (find_overload_match): Remove use of null_cleanup, and
4143         calls to do_cleanups.
4144
4145 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4146
4147         * compile/compile-cplus-types.c
4148         (compile_cplus_instance::decl_name): Handle changes to
4149         cp_func_name.
4150         * cp-support.c (cp_func_name): Update header comment, update
4151         return type.
4152         * cp-support.h (cp_func_name): Update return type in declaration.
4153         * valops.c (find_overload_match): Move temp_func local to top
4154         level of function and change its type.  Use temp_func to hold and
4155         delete temporary string obtained from cp_func_name.
4156
4157 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4160         gdb::char_vector, remove cleanup, and update uses of `msg`.
4161
4162 2019-01-03  Jim Wilson  <jimw@sifive.com>
4163
4164         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4165
4166 2019-01-02  Tom Tromey  <tom@tromey.com>
4167
4168         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4169         (tdesc_parse_xml): Remove cleanups.
4170         * target-descriptions.h (make_cleanup_free_target_description):
4171         Don't declare.
4172         (target_desc_deleter): New struct.
4173         (target_desc_up): New typedef.
4174         * target-descriptions.c (target_desc_deleter::operator()): Rename
4175         from free_target_description.
4176         (make_cleanup_free_target_description): Remove.
4177
4178 2019-01-02  Tom Tromey  <tom@tromey.com>
4179
4180         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4181         constructor, destructor.
4182         (linespec_parser): Remove typedef.
4183         (~linespec_parser): Rename from linespec_parser_delete.
4184         (linespec_lex_to_end, linespec_complete_label)
4185         (linespec_complete): Update.
4186         (decode_line_full): Remove cleanups.
4187         (decode_line_1): Update.
4188
4189 2019-01-02  Tom Tromey  <tom@tromey.com>
4190
4191         * python/python-internal.h (inferior_to_inferior_object): Change
4192         return type.
4193         * python/py-exitedevent.c (create_exited_event_object): Update.
4194         * python/py-inferior.c (inferior_to_inferior_object): Return
4195         gdbpy_ref.
4196         (python_new_inferior, python_inferior_deleted)
4197         (thread_to_thread_object, delete_thread_object)
4198         (build_inferior_list, gdbpy_selected_inferior): Update.
4199         * python/py-infthread.c (create_thread_object): Update.  Also fail
4200         if inferior_to_inferior_object fails.
4201
4202 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4203
4204         * inferior.h (class inferior) <displaced_step_state>: New field.
4205         * infrun.h (struct displaced_step_state): Move here from
4206         infrun.c.  Initialize fields, add constructor.
4207         <inf>: Remove field.
4208         <reset>: New method.
4209         * infrun.c (struct displaced_step_inferior_state): Move to
4210         infrun.h.
4211         (displaced_step_inferior_states): Remove.
4212         (get_displaced_stepping_state): Adust.
4213         (displaced_step_in_progress_any_inferior): Adjust.
4214         (displaced_step_in_progress_thread): Adjust.
4215         (displaced_step_in_progress): Adjust.
4216         (add_displaced_stepping_state): Remove.
4217         (get_displaced_step_closure_by_addr): Adjust.
4218         (remove_displaced_stepping_state): Remove.
4219         (infrun_inferior_exit): Call displaced_step_state.reset.
4220         (use_displaced_stepping): Don't check for NULL.
4221         (displaced_step_prepare_throw): Call
4222         get_displaced_stepping_state.
4223         (displaced_step_fixup): Don't check for NULL.
4224         (prepare_for_detach): Don't check for NULL.
4225
4226 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4227
4228         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4229          in case of call that did not complete.
4230
4231 2019-01-02  Andrey Utkin  <autkin@undo.io>
4232
4233         * symfile.c (find_separate_debug_file): Fix search of debug files for
4234         remote debuggee.
4235
4236 2019-01-02  Tom Tromey  <tom@tromey.com>
4237
4238         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4239         indentation.
4240         * python/py-frame.c (frapy_older): Remove cast.
4241         (frapy_newer): Likewise.
4242         * python/py-breakpoint.c (local_setattro): Remove cast.
4243         * python/py-arch.c (archpy_name): Remove local variable.
4244         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4245
4246 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4247
4248         * unittests/basic_string_view/element_access/char/empty.cc:
4249         Fix year range in copyright header.
4250
4251 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4252
4253         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4254         Delete.
4255         <operator==>: Update with for removed field.
4256         <hash>: Likewise.
4257         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4258         <isa_features>: ...this.
4259         <abi_features>: New field.
4260         (riscv_isa_flen): Update comment.
4261         (riscv_abi_xlen): New declaration.
4262         (riscv_abi_flen): New declaration.
4263         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4264         isa_features.
4265         (riscv_abi_xlen): New function.
4266         (riscv_isa_flen): Update to get answer from isa_features.
4267         (riscv_abi_flen): New function.
4268         (riscv_has_fp_abi): Update to get answer from abi_features.
4269         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4270         xlen and flen.
4271         (riscv_call_info) <xlen, flen>: Update comment.
4272         (riscv_call_arg_struct): Remove invalid assertions
4273         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4274         is removed.
4275         (riscv_gdbarch_init): Gather isa features and abi features
4276         separately, ensure both match on the gdbarch when reusing an old
4277         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4278         a target with 64-bit float hardware.
4279
4280 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4281
4282         * source.c (search_command_helper): Stop reverse search
4283         when line 1 has been searched.
4284
4285 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4286
4287         * record-full.c (record_full_base_target::close): Rewrite
4288         record_full_core_buf_list free logic.
4289
4290 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4291
4292         * break-catch-syscall.c (print_one_catch_syscall): xfree
4293         the last text.
4294
4295 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4296
4297         * top.c (print_gdb_version): Update Copyright year in version
4298         message.
4299
4300 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4301
4302         Update copyright year range in all GDB files.
4303
4304 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4305
4306         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4307
4308 For older changes see ChangeLog-2018.
4309 \f
4310 Local Variables:
4311 mode: change-log
4312 left-margin: 8
4313 fill-column: 74
4314 version-control: never
4315 coding: utf-8
4316 End:
4317