gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
   4         Don't declare.
   5         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
   6         Remove.
   7         * tui/tui-win.c (tui_source_window_base::set_new_height)
   8         (tui_source_window_base::set_new_height)
   9         (make_invisible_and_set_new_height)
  10         (tui_source_window_base::do_make_visible_with_new_height)
  11         (tui_source_window_base::do_make_visible_with_new_height):
  12         Update.
  13         * tui/tui-layout.c (show_source_disasm_command, show_data)
  14         (show_source_or_disasm_and_command): Update.
  15         * tui/tui-layout.c (show_layout): Update.
  16
  17 2019-07-17  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-layout.c (make_data_window): Remove.
  20         (show_data): Unify creation and re-initialization cases.
  21
  22 2019-07-17  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-layout.c (make_source_window, make_disasm_window):
  25         Remove.
  26         (show_data): Unify creation and re-initialization cases.
  27
  28 2019-07-17  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-layout.c (make_command_window): Remove.
  31         (show_source_disasm_command, show_source_or_disasm_and_command):
  32         Unify creation and re-initialization cases.
  33
  34 2019-07-17  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
  37         creation and re-initialization cases.
  38
  39 2019-07-17  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-regs.c (tui_get_register): Return void.
  42
  43 2019-07-17  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
  46         Simplify.
  47
  48 2019-07-17  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-layout.c (show_source_disasm_command): Simplify window
  51         resetting.
  52
  53 2019-07-17  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui.h (tui_set_layout_by_name): Don't declare.
  56         * tui/tui-regs.c (tui_reg_layout): New function.
  57         (tui_show_registers, tui_reg_command): Use it.
  58         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
  59         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
  60         parameters.
  61         (tui_layout_command): Remove.
  62
  63 2019-07-17  Tom Tromey  <tom@tromey.com>
  64
  65         * tui/tui-layout.h (tui/tui-layout): Return void.
  66         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
  67
  68 2019-07-17  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-layout.c (show_source_disasm_command, show_data):
  71         Update.
  72         (reset_locator): Remove.
  73         (show_source_or_disasm_and_command): Update.
  74
  75 2019-07-17  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-source.c (tui_source_window_base::reset): Remove
  78         win_type parameter.
  79         * tui/tui-layout.c (make_command_window, make_source_window)
  80         (make_disasm_window, make_data_window)
  81         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
  82         (reset_locator, show_source_or_disasm_and_command): Update.
  83         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  84         win_type parameter.
  85         (struct tui_source_window_base) <reset>: Likewise.
  86
  87 2019-07-17  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-layout.c (show_source_disasm_command): Use
  90         reset_locator.
  91         (reset_locator): New function.
  92         (init_and_make_win): Remove.
  93         (show_source_or_disasm_and_command): Use reset_locator.
  94
  95 2019-07-17  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
  98         condition.
  99         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 100         Remove condition.
 101         * tui/tui-source.c (tui_source_window_base::reset): New method.
 102         * tui/tui-layout.c (make_command_window): Don't call
 103         init_and_make_win.
 104         (make_source_window, make_disasm_window): Don't call
 105         make_source_or_disasm_window.
 106         (make_data_window): Don't call init_and_make_win.  Change calling
 107         convention.
 108         (show_source_disasm_command, show_data): Simplify.
 109         (make_source_or_disasm_window): Remove.
 110         (show_source_or_disasm_and_command): Simplify.
 111         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 112         (struct tui_source_window_base) <reset>: Likewise.
 113         <execution_info>: Remove initializer.
 114         * tui/tui-data.c (tui_source_window_base): Initialize
 115         execution_info.
 116
 117 2019-07-17  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 120         variable.
 121
 122 2019-07-17  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui.c (tui_rl_other_window): Update.
 125         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 126         superclass method first.  Always iterate over regs_content.
 127         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 128         method.
 129         * tui/tui-win.c (tui_set_focus_command): Update.
 130
 131 2019-07-17  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-win.c (tui_set_focus_command): Rename from
 134         tui_set_focus.  Call tui_enable.
 135         (tui_set_focus_command): Remove.
 136
 137 2019-07-17  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 140         refresh_window.
 141         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 142         touchwin.
 143         (tui_data_window::refresh_window): Call refresh_window on data
 144         items.  Always call superclass refresh_window.
 145         (tui_win_info::refresh): Remove.
 146         (tui_source_window_base::refresh_window): Update.
 147         (tui_refresh_all): Update.
 148         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 149         refresh_window.
 150         (show_source_or_disasm_and_command): Likewise.
 151         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 152         (struct tui_source_window_base) <refresh>: Likewise.
 153
 154 2019-07-17  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-winsource.c (tui_clear_source_content)
 157         (tui_show_source_content): Update.
 158         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 159         whether content is empty.
 160         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 161         Remove.
 162
 163 2019-07-17  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 166         window's contents.
 167         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 168         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 169
 170 2019-07-17  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 173         (struct tui_data_item_window): Update.
 174
 175 2019-07-17  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 178         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 179         defines.
 180
 181 2019-07-17  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-winsource.h (tui_erase_source_content)
 184         (tui_clear_source_content): Remove "display_prompt" parameter.
 185         * tui/tui-winsource.c (tui_update_source_window_as_is)
 186         (tui_update_source_windows_with_addr): Update.
 187         (tui_clear_source_content): Remove "display_prompt" parameter.
 188         (tui_erase_source_content): Likewise.  Simplify.
 189         (tui_show_source_content): Update.
 190         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 191         * tui/tui-stack.c (tui_show_frame_info): Update.
 192         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 193         Remove defines.
 194
 195 2019-07-17  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 198         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 199         parameter.
 200         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 201         parameter.
 202
 203 2019-07-17  Tom Tromey  <tom@tromey.com>
 204
 205         * tui/tui-winsource.c (tui_clear_source_content)
 206         (tui_show_source_content, tui_show_exec_info_content)
 207         (tui_clear_exec_info_content): Update.
 208         * tui/tui-stack.c (tui_show_locator_content): Update.
 209         (tui_show_frame_info): Update.
 210         * tui/tui-source.h (tui_source_window): Don't declare.
 211         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 212         from tui_source_is_displayed.
 213         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 214         Remove field.
 215         (struct tui_source_window_base) <content_in_use>: New field.  Now
 216         bool.
 217         (struct tui_source_window) <showing_source_p>: New method.
 218         (TUI_SRC_WIN): Change cast.
 219         * tui/tui-data.c (tui_initialize_static_data): Update.
 220
 221 2019-07-17  Tom Tromey  <tom@tromey.com>
 222
 223         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 224         location_matches_p.
 225         * tui/tui-source.c (tui_source_window::location_matches_p): New
 226         method.
 227         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 228         method.
 229         * tui/tui-data.h (struct tui_source_window_base)
 230         <location_matches_p>: New method.
 231         (struct tui_source_window, struct tui_disasm_window)
 232         <location_matches_p>: Likewise.
 233
 234 2019-07-17  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-win.c (tui_set_win_height_command): Rename from
 237         tui_set_win_height.
 238         (tui_set_win_height_command): Remove.
 239
 240 2019-07-17  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-source.c (tui_source_window): New constructor.  Add
 243         observer.
 244         (~tui_source_window): New destructor.
 245         (tui_source_window::style_changed): New method.
 246         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 247         (tui_attach_detach_observers): Update.
 248         * tui/tui-data.h (struct tui_source_window): Make constructor not
 249         inline.  Add destructor.
 250         (struct tui_source_window) <style_changed>: New method.
 251         <m_observable>: New member.
 252
 253 2019-07-17  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 256         * tui/tui-win.c (tui_resize_all): Fix typo.
 257
 258 2019-07-17  Tom Tromey  <tom@tromey.com>
 259
 260         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 261         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 262         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 263         * tui/tui-win.c (window_name_completer): Use foreach.
 264         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 265         (update_tab_width): Likewise.
 266         * tui/tui-layout.c (show_layout): Update.
 267         * tui/tui-data.h (class tui_window_iterator): New.
 268         (struct all_tui_windows): New.
 269         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 274         parameter.  Don't reference globals.
 275         (tui_reg_command): Update.
 276
 277 2019-07-17  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-regs.c (tui_show_registers): Simplify.
 280
 281 2019-07-17  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui-regs.c (tui_show_registers): Update.
 284         (tui_show_register_group): Add win_info parameter.
 285
 286 2019-07-17  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 289         Rename from tui_display_reg_element_at_line.
 290         (tui_data_window::display_registers_from_line): Update.
 291         * tui/tui-data.h (struct tui_data_window)
 292         <display_reg_element_at_line>: New method.
 293
 294 2019-07-17  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-regs.h (tui_display_registers_from)
 297         (tui_display_registers_from_line): Don't declare.
 298         * tui/tui-windata.c (tui_data_window::display_all_data)
 299         (tui_data_window::refresh_all)
 300         (tui_data_window::do_scroll_vertical): Update.
 301         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 302         from tui_display_registers_from.
 303         (tui_display_reg_element_at_line): Update.
 304         (tui_data_window::display_registers_from_line): Rename from
 305         tui_display_registers_from_line.
 306         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 307         display_registers_from_line>: New methods.
 308
 309 2019-07-17  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 312         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 313         from tui_erase_data_content.
 314         (tui_data_window::display_all_data)
 315         (tui_data_window::refresh_all)
 316         (tui_data_window::do_scroll_vertical): Update.
 317         * tui/tui-regs.c (tui_show_registers): Update.
 318         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 319         New method.
 320
 321 2019-07-17  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 324         declare.
 325         * tui/tui-windata.c
 326         (tui_data_window::delete_data_content_windows): Rename from
 327         tui_delete_data_content_windows.
 328         (tui_data_window::display_all_data)
 329         (tui_data_window::do_scroll_vertical): Update.
 330         * tui/tui-data.h (struct tui_data_window)
 331         <delete_data_content_windows>: New method.
 332
 333 2019-07-17  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 336         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 337
 338 2019-07-17  Tom Tromey  <tom@tromey.com>
 339
 340         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 341         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 342         from tui_display_all_data.
 343         * tui/tui-win.c
 344         (tui_data_window::do_make_visible_with_new_height): Update.
 345         * tui/tui-regs.c (tui_show_registers): Update.
 346         * tui/tui-layout.c (tui_set_layout): Update.
 347         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 348         method.
 349
 350 2019-07-17  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 353         * tui/tui-windata.c (tui_display_data_from): Remove.
 354         (tui_data_window::refresh_all): Update.
 355
 356 2019-07-17  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 359         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 360         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 361         tui_display_registers_from_line.
 362         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 363         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 364         "force_display" parameter.
 365
 366 2019-07-17  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 369         declare.
 370         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 371         Rename from tui_first_reg_element_no_inline.
 372         (tui_display_reg_element_at_line)
 373         (tui_display_registers_from_line): Update.
 374         * tui/tui-data.h (struct tui_data_window)
 375         <first_reg_element_no_inline>: New method.
 376
 377 2019-07-17  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-windata.c (tui_display_data_from)
 380         (tui_data_window::do_scroll_vertical): Update.
 381         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 382         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 383         Rename from tui_line_from_reg_element_no.
 384         (tui_display_registers_from_line): Update.
 385         * tui/tui-data.h (struct tui_data_window)
 386         <line_from_reg_element_no>: New method.
 387
 388 2019-07-17  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 391         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 392         tui_last_regs_line_no.
 393         (tui_display_reg_element_at_line)
 394         (tui_display_registers_from_line): Update.
 395         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 396         method.
 397
 398 2019-07-17  Tom Tromey  <tom@tromey.com>
 399
 400         PR tui/24722:
 401         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 402         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 403         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 404         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 405         (tui_update_breakpoint_info): Likewise.
 406         * tui/tui-hooks.c (tui_event_create_breakpoint)
 407         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 408         Update.
 409
 410 2019-07-17  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 413
 414 2019-07-17  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-winsource.c (tui_update_source_window_as_is)
 417         (tui_update_source_windows_with_addr): Update.
 418         * tui/tui-source.h (tui_set_source_content)
 419         (tui_show_symtab_source): Add "win_info" parameter.
 420         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 421         parameter.
 422         (tui_show_symtab_source): Likewise.
 423
 424 2019-07-17  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui-wingeneral.c
 427         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 428
 429 2019-07-17  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 432         (struct tui_cmd_window) <can_scroll>: New method.
 433         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 434         method.
 435
 436 2019-07-17  Tom Tromey  <tromey@adacore.com>
 437
 438         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 439         do_field_signed>: Rename.  Change type of "value".
 440         * ui-out.c (ui_out::field_signed): Rename from field_int.
 441         Change type of "value".
 442         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 443         type of "value".
 444         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 445         do_field_int.  Change type of "value".
 446         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 447         do_field_int.  Change type of "value".
 448         * tracepoint.c (trace_status_mi, tfind_1)
 449         (print_one_static_tracepoint_marker): Update.
 450         * thread.c (print_thread_info_1, print_selected_thread_frame):
 451         Update.
 452         * stack.c (print_frame, print_frame_info): Update.
 453         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 454         Update.
 455         * source.c (print_source_lines_base): Update.
 456         * skip.c (info_skip_command): Update.
 457         * record-btrace.c (btrace_ui_out_decode_error)
 458         (btrace_call_history_src_line): Update.
 459         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 460         Update.
 461         * progspace.c (print_program_space): Update.
 462         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 463         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 464         do_field_int.  Change type of "value".
 465         * mi/mi-out.c (mi_ui_out::do_table_begin)
 466         (mi_ui_out::do_table_header): Update.
 467         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 468         type of "value".
 469         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 470         (mi_cmd_data_list_changed_registers, output_register)
 471         (mi_cmd_data_read_memory, mi_load_progress)
 472         (mi_cmd_trace_frame_collected): Update.
 473         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 474         Update.
 475         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 476         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 477         (mi_cmd_var_list_children, varobj_update_one): Update.
 478         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 479         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 480         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 481         * inferior.c (print_inferior): Update.
 482         * gdb_bfd.c (print_one_bfd): Update.
 483         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 484         Update.
 485         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 486         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 487         do_field_int.  Change type of "value".
 488         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 489         do_field_int.  Change type of "value".
 490         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 491         (print_one_breakpoint_location, print_it_catch_fork)
 492         (print_one_catch_fork, print_it_catch_vfork)
 493         (print_one_catch_vfork, print_it_catch_solib)
 494         (print_it_catch_exec, print_it_ranged_breakpoint)
 495         (print_mention_watchpoint, print_mention_masked_watchpoint)
 496         (bkpt_print_it, update_static_tracepoint): Update.
 497         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 498         * break-catch-syscall.c (print_it_catch_syscall): Update.
 499         * ada-tasks.c (print_ada_task_info): Update.
 500         * ada-lang.c (print_it_exception, print_mention_exception):
 501         Update.
 502
 503 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 504
 505         PR breakpoints/24541
 506         * gdbarch.c: Regenerate.
 507         * gdbarch.h: Regenerate.
 508         * gdbarch.sh: Adjust return type and parameter types for
 509         'stap_adjust_register'.
 510         (i386_stap_adjust_register): Adjust signature and return new
 511         register name.
 512         * stap-probe.c (stap_parse_register_operand): Adjust use of
 513         'gdbarch_stap_adjust_register'.
 514
 515 2019-07-17  Tom Tromey  <tromey@adacore.com>
 516
 517         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 518         declare VEC.
 519         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 520         std::vector.
 521         (struct s390_process_info): Add initializers.
 522         (s390_add_process): Use new.
 523         (s390_linux_nat_target::low_forget_process): Use delete.
 524         (s390_linux_nat_target::low_new_fork)
 525         (s390_linux_nat_target::stopped_by_watchpoint)
 526         (s390_linux_nat_target::low_prepare_to_resume)
 527         (s390_linux_nat_target::insert_watchpoint)
 528         (s390_linux_nat_target::insert_hw_breakpoint)
 529         (s390_linux_nat_target::remove_watchpoint)
 530         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 531
 532 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 533
 534         * aarch64-fbsd-nat.c: Include regcache.h.
 535         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 536         argument.
 537         (aarch64_fbsd_nat_target::fetch_registers)
 538         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 539         variable.
 540         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 541
 542 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 543
 544         * fbsd-nat.c: Include gdbarch.h.
 545
 546 2019-07-15  Tom Tromey  <tromey@adacore.com>
 547
 548         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 549
 550 2019-07-15  Tom Tromey  <tromey@adacore.com>
 551
 552         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 553         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 554         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 555         * cli-out.c (cli_ui_out::do_field_int): New method.
 556         * ui-out.c (ui_out::field_unsigned): New method.
 557         * symfile.c (generic_load): Use field_unsigned.
 558         (print_transfer_performance): Likewise.
 559         * record-btrace.c (ui_out_field_uint): Remove.
 560         (btrace_call_history_insn_range, btrace_call_history): Use
 561         field_unsigned.
 562         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 563         field_unsigned.
 564         * ui-out.h (class ui_out) <field_unsigned>: New method.
 565         <do_field_unsigned>: Likewise.
 566
 567 2019-07-15  Tom Tromey  <tromey@adacore.com>
 568
 569         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 570         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 571         * target.c (flash_erase_command): Use field_string.
 572         * infrun.c (print_signal_received_reason): Use field_string.
 573         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 574         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 575         field_string.
 576         * ada-tasks.c (print_ada_task_info): Use field_string.
 577
 578 2019-07-15  Tom Tromey  <tromey@adacore.com>
 579
 580         * target.c (flash_erase_command): Use field_core_addr.
 581         * symfile.c (generic_load): Use field_core_addr.
 582         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 583         Use field_core_addr.
 584         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 585         field_core_addr.
 586
 587 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 588
 589         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 590         value if its desired type is smaller than a CORE_ADDR and signed.
 591
 592 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 593
 594         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 595         of changes to field names, and use new is_reference field to
 596         decide if a property is a reference or not.
 597         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 598         field.
 599         (struct dwarf2_property_baton): Update header comment, rename
 600         'referenced_type' to 'property_type' and update comments.
 601         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 602         default property type, store in property baton, update to take
 603         accound of renamed field.
 604         (read_func_scope): Update call to attr_to_dynamic_prop.
 605         (read_array_type): Likewise.
 606         (dwarf2_per_cu_addr_sized_int_type): New function.
 607         (read_subrange_index_type): Move type finding code to
 608         dwarf2_per_cu_addr_sized_int_type.
 609         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 610         (dwarf2_per_cu_addr_type): New function.
 611         (set_die_type): Update calls to attr_to_dynamic_prop.
 612
 613 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 614
 615         * dwarf2read.c (read_subrange_index_type): New function.
 616         (read_subrange_type): Move code into new function and call it.
 617         * gdbtypes.c (create_range_type): Add some asserts.
 618
 619 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 620
 621         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 622         update return statements.
 623         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 624         declaration, and update comment to match.
 625         * gdbtypes.c (resolve_dynamic_array): Update call to
 626         dwarf2_evaluate_property to match new return type.
 627
 628 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 629
 630         * valarith.c (value_subscripted_rvalue): Change lowerbound
 631         parameter type from int to LONGEST.
 632         * value.h (value_subscripted_rvalue): Likewise in declaration.
 633
 634 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 635
 636         * cli/cli-utils.c (info_print_command_completer): New function.
 637         * cli/cli-utils.h: Add 'completer.h' include, and forward
 638         declaration for 'struct cmd_list_element'.
 639         (info_print_command_completer): Declare.
 640         * stack.c (_initialize_stack): Add completer for 'info locals' and
 641         'info args'.
 642         * symtab.c (_initialize_symtab): Add completer for 'info
 643         variables' and 'info functions'.
 644         * NEWS: Mention completion for additional info commands.
 645
 646 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 647
 648         * cli/cli-utils.c (extract_info_print_args): Delete.
 649         (extract_arg_maybe_quoted): Delete.
 650         (info_print_options_defs): New variable.
 651         (make_info_print_options_def_group): New function.
 652         (extract_info_print_options): Define new function.
 653         * cli/cli-utils.h (extract_info_print_args): Delete.
 654         (struct info_print_options): New structure.
 655         (extract_info_print_options): Declare new function.
 656         * stack.c (info_locals_command): Update to use new
 657         extract_info_print_options, also add a header comment.
 658         (info_args_command): Likewise.
 659         * symtab.c (info_variables_command): Likewise.
 660         (info_functions_command): Likewise.
 661
 662 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 663
 664         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 665         to extract string arguments.
 666         * common/common-utils.c (extract_string_maybe_quoted): New function.
 667         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 668
 669 2019-07-11  Tom Tromey  <tromey@adacore.com>
 670
 671         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 672         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 673         * top.h (gdbinit): Don't declare.
 674         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 675         into...
 676         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 677         * top.c (gdb_init): Don't call init_cli_cmds.
 678         (gdbinit): Remove.
 679         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 680
 681 2019-07-11  Tom Tromey  <tromey@adacore.com>
 682
 683         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 684         after it has been moved.
 685
 686 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 687
 688         * valops.c (value_must_coerce_to_target): Change return type to
 689         bool.
 690         * value.h (value_must_coerce_to_target): Likewise.
 691
 692 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 693
 694         * breakpoint.c (is_hardware_watchpoint): Remove
 695         forward-declaration.
 696         (is_masked_watchpoint): Change return type to bool.
 697         (is_tracepoint): Likewise.
 698         (is_breakpoint): Likewise.
 699         (is_hardware_watchpoint): Likewise.
 700         (is_watchpoint): Likewise.
 701         (is_no_memory_software_watchpoint): Likewise.
 702         (is_catchpoint): Likewise.
 703         (breakpoint_1): Make FILTER parameter's return type bool.
 704         is_masked_watchpoint): Change return type to bool.
 705         (save_breakpoints): Make FILTER parameter's return type bool.
 706         * breakpoint.h (is_breakpoint): Change return type to bool.
 707         (is_watchpoint): Likewise.
 708         (is_catchpoint): Likewise.
 709         (is_tracepoint): Likewise.
 710
 711 2019-07-10  Tom Tromey  <tom@tromey.com>
 712
 713         * defs.h: Don't include gdbarch.h.
 714         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 715         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 716         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 717         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 718         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 719         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 720         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 721         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 722         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 723         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 724         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 725         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 726         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 727         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 728         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 729         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 730         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 731         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 732         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 733         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 734         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 735         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 736         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 737         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 738         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 739         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 740         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 741
 742 2019-07-10  Tom Tromey  <tromey@adacore.com>
 743
 744         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 745         * breakpoint.c (init_ada_exception_breakpoint): Register as
 746         bp_catchpoint.
 747         (print_one_breakpoint_location, print_one_breakpoint): Use
 748         is_ada_exception_catchpoint.
 749         * ada-lang.c (class ada_catchpoint_location): Pass
 750         bp_loc_software_breakpoint to bp_location constructor.
 751         (is_ada_exception_catchpoint): New function.
 752
 753 2019-07-10  Tom Tromey  <tromey@adacore.com>
 754
 755         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 756         VEC.
 757         (struct arm_exidx_entry): New method operator<.
 758         (struct arm_exidx_data) <section_maps>: Change type.
 759         (arm_exidx_data_free): Remove.
 760         (arm_exidx_data_key): Change type.  Move lower.
 761         (arm_exidx_new_objfile): Update.
 762         (arm_compare_exidx_entries): Remove.
 763         (arm_find_exidx_entry, _initialize_arm_tdep)
 764
 765 2019-07-10  Tom Tromey  <tromey@adacore.com>
 766
 767         * solib-spu.c (ocl_program_data_key): Change type.
 768         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 769         Update.
 770
 771 2019-07-10  Tom Tromey  <tromey@adacore.com>
 772
 773         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 774         (struct solib_aix_inferior_data) <library_list>: Change type.
 775         (solib_aix_inferior_data_handle): Change type.
 776         (get_solib_aix_inferior_data): Update.
 777         (solib_aix_free_library_list): Remove.
 778         (library_list_start_library): Update.
 779         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 780         return type.
 781         (solib_aix_get_library_list)
 782         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 783         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 784
 785 2019-07-10  Tom Tromey  <tromey@adacore.com>
 786
 787         * solib-dsbt.c (struct dsbt_info): Add initializers.
 788         (solib_dsbt_pspace_data): Change type.
 789         (dsbt_pspace_data_cleanup): Remove.
 790         (get_dsbt_info, _initialize_dsbt_solib): Update.
 791
 792 2019-07-10  Tom Tromey  <tromey@adacore.com>
 793
 794         * spu-tdep.c (spu_overlay_data): Change type.
 795         (spu_get_overlay_table, spu_overlay_new_objfile)
 796         (_initialize_spu_tdep): Update.
 797
 798 2019-07-10  Tom Tromey  <tromey@adacore.com>
 799
 800         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 801         destructor.
 802         (dbx_objfile_data_key): Change type and declare later.
 803         (DBX_SYMFILE_INFO): Rewrite.
 804         * dbxread.c (dbx_objfile_data_key): Change type.
 805         (dbx_symfile_init): Update.
 806         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 807         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 808         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 809
 810 2019-07-10  Tom Tromey  <tromey@adacore.com>
 811
 812         * jit.c (jit_program_space_key): Change type.  Move lower.
 813         (get_jit_program_space_data): Update.
 814         (jit_program_space_data_cleanup): Remove.
 815         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 816         Update.
 817         (struct jit_program_space_data): Add initializers.
 818
 819 2019-07-10  Tom Tromey  <tromey@adacore.com>
 820
 821         * solib-darwin.c (struct darwin_info): Add initializers.
 822         (solib_darwin_pspace_data): Change type.
 823         (darwin_pspace_data_cleanup): Remove.
 824         (get_darwin_info, _initialize_darwin_solib): Update.
 825
 826 2019-07-10  Tom Tromey  <tromey@adacore.com>
 827
 828         * remote-sim.c (struct sim_inferior_data): Add initializers,
 829         constructor, and destructor.
 830         (sim_inferior_data_key): Change type.  Move lower.
 831         (check_for_duplicate_sim_descriptor): Update.
 832         (get_sim_inferior_data): Use new.  Update.
 833         (~sim_inferior_data_cleanup): Rename from
 834         sim_inferior_data_cleanup.  Simplify.
 835         (gdbsim_close_inferior, simulator_command)
 836         (sim_command_completer, _initialize_remote_sim): Update.
 837         (next_pid, INITIAL_PID): Move earlier.
 838
 839 2019-07-10  Tom Tromey  <tromey@adacore.com>
 840
 841         * python/python-internal.h (create_thread_object): Return
 842         gdbpy_ref.
 843         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 844         * python/py-inferior.c (struct threadlist_entry): Add
 845         constructor.
 846         <thread_obj>: Now a gdbpy_ref.
 847         (thread_to_thread_object): Update.
 848         (add_thread_object): Use new.
 849         (delete_thread_object): Use delete.
 850         (infpy_threads): Update.
 851         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 852         GIL.
 853
 854 2019-07-10  Tom Tromey  <tromey@adacore.com>
 855
 856         * valops.c (value_cast): Specialize error message for Ada.
 857
 858 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 859
 860         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 861
 862 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 863
 864         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 865         bpstat_should_step): Return bool, adjust comments.
 866         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 867         bpstat_should_step): Likewise.
 868
 869 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 870
 871         * features/Makefile: Use feature target descriptions for Arm.
 872         * features/arm/arm-core.c: Generate new file.
 873         * features/arm/arm-fpa.c: Likewise.
 874         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 875         * features/arm/arm-m-profile.c: Likewise.
 876         * features/arm/arm-vfpv2.c: Likewise.
 877         * features/arm/arm-vfpv3.c: Likewise.
 878         * features/arm/xscale-iwmmxt.c: Likewise.
 879         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 880
 881 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 882
 883         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 884         ptrace earlier.
 885
 886 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 887
 888         * features/aarch64-pauth.c: Regenerate.
 889
 890 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 891
 892         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 893         bool.
 894         (bpstat_what): Use false instead of 0.
 895
 896 2019-07-09  Pedro Alves  <palves@redhat.com>
 897
 898         * break-catch-throw.c (is_exception_catchpoint): New.
 899         * breakpoint.c (print_one_breakpoint_location): New parameter
 900         'raw_loc'.  Handle it.  Use
 901         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 902         looking at the breakpoint's type.
 903         (print_one_breakpoint): If handling "maint info breakpoints", also
 904         print locations of exception catchpoints.
 905         * breakpoint.h (is_exception_catchpoint): Declare.
 906
 907 2019-07-09  Pedro Alves  <palves@redhat.com>
 908
 909         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 910         "addr" field.
 911         (allocate_location_exception_catchpoint): New.
 912         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 913         (initialize_throw_catchpoint_ops): Install
 914         allocate_location_exception_catchpoint as allocate_location
 915         method.
 916         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 917         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 918         bp_loc_other.
 919         (breakpoint_address_is_meaningful): Delete.
 920         (bl_address_is_meaningful): New.
 921         (breakpoint_locations_match): Adjust comment.
 922         (bp_location_from_bp_type): New, factored out of...
 923         (bp_location::bp_location(breakpoint *)): ... this.
 924         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 925         factored out of...
 926         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 927         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 928         breakpoint_address_is_meaningful.
 929         (bp_locations_compare): Adjust comment.
 930         (update_global_location_list): Use bl_address_is_meaningful
 931         instead of breakpoint_address_is_meaningful.
 932         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 933         explicit.
 934         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 935         * python/py-breakpoint.c (bppy_get_location): No longer check
 936         whether location is null.
 937
 938 2019-07-09  Pedro Alves  <palves@redhat.com>
 939
 940         PR c++/15468
 941         * breakpoint.c (print_one_breakpoint_location): Remove
 942         single-location assert.
 943
 944 2019-07-09  Tom Tromey  <tom@tromey.com>
 945
 946         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 947         * configure: Rebuild.
 948         * configure.ac: Change common to gdbsupport.
 949         * gdbsupport: Rename from common.
 950         * acinclude.m4: Change common to gdbsupport.
 951         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 952         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 953         gdbsupport.
 954         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 955         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 956         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 957         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 958         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 959         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 960         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 961         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 962         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 963         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 964         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 965         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 966         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 967         coff-pe-read.c, command.h, compile/compile-c-support.c,
 968         compile/compile-c.h, compile/compile-cplus-symbols.c,
 969         compile/compile-cplus-types.c, compile/compile-cplus.h,
 970         compile/compile-loc2c.c, compile/compile.c, completer.c,
 971         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 972         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 973         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 974         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 975         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 976         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 977         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 978         features/aarch64-core.c, features/aarch64-fpu.c,
 979         features/aarch64-pauth.c, features/aarch64-sve.c,
 980         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 981         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 982         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 983         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 984         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 985         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 986         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 987         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 988         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 989         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 990         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 991         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 992         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 993         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 994         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 995         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 996         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 997         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 998         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 999         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1000         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1001         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1002         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1003         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1004         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1005         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1006         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1007         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1008         minsyms.c, mips-linux-tdep.c, namespace.h,
1009         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1010         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1011         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1012         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1013         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1014         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1015         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1016         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1017         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1018         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1019         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1020         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1021         procfs.c, producer.c, progspace.h, psymtab.h,
1022         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1023         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1024         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1025         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1026         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1027         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1028         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1029         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1030         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1031         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1032         target-memory.c, target.c, target.h, target/waitstatus.c,
1033         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1034         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1035         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1036         unittests/array-view-selftests.c,
1037         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1038         unittests/common-utils-selftests.c,
1039         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1040         unittests/format_pieces-selftests.c,
1041         unittests/function-view-selftests.c,
1042         unittests/lookup_name_info-selftests.c,
1043         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1044         unittests/mkdir-recursive-selftests.c,
1045         unittests/observable-selftests.c,
1046         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1047         unittests/parse-connection-spec-selftests.c,
1048         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1049         unittests/scoped_fd-selftests.c,
1050         unittests/scoped_mmap-selftests.c,
1051         unittests/scoped_restore-selftests.c,
1052         unittests/string_view-selftests.c, unittests/style-selftests.c,
1053         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1054         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1055         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1056         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1057         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1058         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1059
1060 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1061
1062         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1063         bool value.
1064         (decode_digits_ordinary): Set explicit_line field in sal.
1065         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1066         symtab_and_line that was set on an explicit line number in
1067         assembler code.  Do always update the recorded symtab and line if
1068         we do skip the prologue.
1069
1070 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * breakpoint.c (set_breakpoint_location_function): Remove
1073         explicit_loc parameter.
1074         (momentary_breakpoint_from_master): Update call to
1075         set_breakpoint_location_function.
1076         (add_location_to_breakpoint): Likewise.
1077
1078 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1081         required features based on default bfd type when no specific bfd
1082         is present.
1083
1084 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1085
1086         * NEWS: Mention that GDB printf and eval commands can now print
1087         C-style and Ada-style convenience var strings without
1088         calling the inferior.
1089         * printcmd.c (printf_c_string): Locally print GDB internal var
1090         instead of transiting via the inferior.
1091         (printf_wide_c_string): Likewise.
1092
1093 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1094
1095         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1096
1097 2019-07-04  Tom Tromey  <tom@tromey.com>
1098
1099         PR tui/24724:
1100         * tui/tui-winsource.c (tui_clear_source_content): Update.
1101         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1102         (tui_update_breakpoint_info): Update.
1103         (tui_set_exec_info_content): Update.
1104         * tui/tui-source.c (tui_set_source_content_nil): Update.
1105         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1106         has_break.
1107         * tui/tui-data.h (enum tui_bp_flag): New.
1108         (tui_bp_flags): New enum flags type.
1109         (struct tui_source_element) <break_mode>: Change type.  Rename
1110         from has_break.
1111         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1112         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1113         constants.
1114         * tui/tui-winsource.h: Fix comment.
1115
1116 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1117
1118         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1119         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1120         (store_fpregs_to_thread)
1121         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1122         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1123         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1124         (IWMMXT_REGS_SIZE): Add define.
1125         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1126         (fetch_vfp_regs, store_vfp_regs)
1127         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1128         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1129
1130 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1131
1132         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1133         defines.
1134         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1135         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1136         (ARM_INT_REGISTER_SIZE): ...to this.
1137         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1138         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1139         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1140         (arm_linux_collect_gregset, supply_nwfpe_register)
1141         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1142         defines.
1143         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1144         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1145         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1146         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1147         (arm_return_in_memory, arm_store_return_value)
1148         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1149         (arm_record_ld_st_multiple): Likewise.
1150         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1151         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1152
1153 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1154
1155         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1156         AARCH64_DISPLACED_MODIFIED_INSNS.
1157         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1158         (aarch64_displaced_step_copy_insn): Likewise.
1159         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1160         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1161         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1162         ARM_DISPLACED_MODIFIED_INSNS.
1163         * arm-tdep.c (arm_gdbarch_init): Likewise.
1164         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1165         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1166         (struct arm_displaced_step_closure): Use
1167         ARM_DISPLACED_MODIFIED_INSNS.
1168
1169 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1170
1171         * features/Makefile: Remove unused xml files.
1172         * features/aarch64.xml: Remove.
1173         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1174         * features/i386/amd64-avx-avx512.xml: Remove.
1175         * features/i386/amd64-avx-linux.xml: Remove.
1176         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1177         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1178         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1179         * features/i386/amd64-avx-mpx.xml: Remove.
1180         * features/i386/amd64-avx.xml: Remove.
1181         * features/i386/amd64-linux.xml: Remove.
1182         * features/i386/amd64-mpx-linux.xml: Remove.
1183         * features/i386/amd64-mpx.xml: Remove.
1184         * features/i386/amd64.xml: Remove.
1185         * features/i386/i386-avx-avx512-linux.xml: Remove.
1186         * features/i386/i386-avx-avx512.xml: Remove.
1187         * features/i386/i386-avx-linux.xml: Remove.
1188         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1189         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1190         * features/i386/i386-avx-mpx-linux.xml: Remove.
1191         * features/i386/i386-avx-mpx.xml: Remove.
1192         * features/i386/i386-avx.xml: Remove.
1193         * features/i386/i386-linux.xml: Remove.
1194         * features/i386/i386-mmx-linux.xml: Remove.
1195         * features/i386/i386-mmx.xml: Remove.
1196         * features/i386/i386-mpx-linux.xml: Remove.
1197         * features/i386/i386-mpx.xml: Remove.
1198         * features/i386/i386.xml: Remove.
1199         * features/i386/x32-avx-avx512-linux.xml: Remove.
1200         * features/i386/x32-avx-linux.xml: Remove.
1201         * features/i386/x32-linux.xml: Remove.
1202
1203 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1204
1205         * regformats/aarch64.dat: Remove.
1206         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1207         * regformats/i386/amd64-avx-linux.dat: Remove.
1208         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1209         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1210         * regformats/i386/amd64-linux.dat: Remove.
1211         * regformats/i386/amd64-mpx-linux.dat: Remove.
1212         * regformats/i386/amd64.dat: Remove.
1213         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1214         * regformats/i386/i386-avx-linux.dat: Remove.
1215         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1216         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1217         * regformats/i386/i386-linux.dat: Remove.
1218         * regformats/i386/i386-mmx-linux.dat: Remove.
1219         * regformats/i386/i386-mpx-linux.dat: Remove.
1220         * regformats/i386/i386.dat: Remove.
1221         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1222         * regformats/i386/x32-avx-linux.dat: Remove.
1223         * regformats/i386/x32-linux.dat: Remove.
1224
1225 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1226
1227         * aarch64-tdep.c: Remove xml self tests.
1228         * amd64-linux-tdep.c: Likewise.
1229         * amd64-tdep.c: Likewise.
1230         * i386-linux-tdep.c: Likewise.
1231         * i386-tdep.c: Likewise.
1232
1233 2019-07-03  Pedro Alves  <palves@redhat.com>
1234
1235         PR cli/24732
1236         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1237         (pipe_cmd_option_defs): New.
1238         (make_pipe_cmd_options_def_group): New.
1239         (pipe_command): Use gdb::option::process_options.
1240         (pipe_command_completer): New function.
1241         (_initialize_cli_cmds): Install completer for "pipe" command.
1242
1243 2019-07-03  Pedro Alves  <palves@redhat.com>
1244
1245         * cli/cli-option.c (union option_value) <string>: New field.
1246         (struct option_def_and_value): Add ctor, move ctor, dtor and
1247         use DISABLE_COPY_AND_ASSIGN.
1248         (option_def_and_value::clear_value): New.
1249         (parse_option, save_option_value_in_ctx, get_val_type_str)
1250         (add_setshow_cmds_for_options): Handle var_string.
1251         * cli-option.h (union option_def::var_address) <string>: New
1252         field.
1253         (struct string_option_def): New.
1254         * maint-test-options.c (struct test_options_opts): Add default
1255         ctor and use DISABLE_COPY_AND_ASSIGN.
1256         <string_opt>: New field.
1257         (test_options_opts::~test_options_opts): New.
1258         (test_options_opts::dump): Also dump "-string".
1259         (test_options_option_defs): Install "string.
1260
1261 2019-07-03  Pedro Alves  <palves@redhat.com>
1262
1263         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1264         option_value with a null enumeration.
1265         (complete_options): Save the option values in the context.
1266         (save_option_value_in_ctx): New, factored out from ...
1267         (process_options): ... here.
1268         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1269         of the function.
1270         * maint-test-options.c (test_options_opts::dump): New, factored
1271         out from ...
1272         (maintenance_test_options_command_mode): ... here.
1273         (maintenance_test_options_command_completion_result): Delete.
1274         (maintenance_test_options_command_completion_text): Update
1275         comment.
1276         (maintenance_show_test_options_completion_result): Change
1277         prototype.  Just print
1278         maintenance_test_options_command_completion_text.
1279         (save_completion_result): New.
1280         (maintenance_test_options_completer_mode): Pass options context to
1281         complete_options, and then save a dump.
1282         (_initialize_maint_test_options): Use add_cmd to install "maint
1283         show test-options-completion-result".
1284
1285 2019-07-03  Pedro Alves  <palves@redhat.com>
1286
1287         * NEWS (New commands): Mention "with" and "maint with".
1288         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1289         (with_command, with_command_completer): New.
1290         (pipe_command): Adjust to new repeat_previous
1291         interface.
1292         (_initialize_cli_cmds): Install the "with" command and its "w"
1293         alias.
1294         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1295         declarations.
1296         * cli/cli-setshow.c (parse_cli_var_uinteger)
1297         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1298         argument strings for all var_types.
1299         (get_setshow_command_value_string): New, factored out from ...
1300         (do_show_command): ... this.
1301         * cli/cli-setshow.h: Include <string>.
1302         (get_setshow_command_value_string): Declare.
1303         * command.h (repeat_previous): Now returns const char *.  Adjust
1304         comment.
1305         * maint.c: Include "cli/cli-cmds.h".
1306         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1307         (_initialize_maint_cmds): Register the "maintenance with" command.
1308         * top.c (repeat_previous): Move bits from pipe_command here:
1309         Return the saved command line, if any; error out if there's no
1310         command to relaunch.
1311
1312 2019-07-03  Pedro Alves  <palves@redhat.com>
1313
1314         * NEWS (New commands): Mention "maint set/show test-settings"
1315         instead of "maint test-settings".
1316         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1317         (maintenance_test_settings_set_list): Rename to ...
1318         (maintenance_set_test_settings_list): ... this.
1319         (maintenance_test_settings_show_list): Rename to  ...
1320         (maintenance_show_test_settings_list): ... this.
1321         (maintenance_test_settings_cmd): Delete.
1322         (maintenance_test_settings_set_cmd): ...
1323         (maintenance_set_test_settings_cmd): ... this.
1324         (maintenance_test_settings_show_cmd): ...
1325         (maintenance_show_test_settings_cmd): ... this.
1326         (maintenance_test_settings_show_value_cmd):
1327         (maintenance_show_test_settings_value_cmd): ... this.
1328         (_initialize_maint_test_settings): No longer install the "maint
1329         test-settings" prefix command.  Rename "maint test-settings set"
1330         to "maint set test-settings", and "maint test-settings show" to
1331         "maint show test-settings".  Adjust all subcommands.
1332
1333 2019-07-03  Pedro Alves  <palves@redhat.com>
1334
1335         * maint-test-settings.c: Fix file's intro comment.  Replace all
1336         references to "test-options" with references to "test-settings",
1337         in comments.
1338
1339 2019-07-03  Pedro Alves  <palves@redhat.com>
1340
1341         * maint-test-settings.c (maintenance_test_settings_xxx)
1342         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1343         New.
1344         (maintenance_test_settings_enums): Use them.
1345         (maintenance_test_settings_enum): Default to
1346         maintenance_test_settings_xxx.
1347         (_initialize_maint_test_settings): Initialize
1348         MAINTENANCE_TEST_SETTINGS_FILENAME.
1349
1350 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1351
1352         * breakpoint.h (remove_breakpoints_inf): Change return type to
1353         void, move function documentation here.
1354         * breakpoint.c (remove_breakpoints_inf): Change return type to
1355         void, move function documentation to header.
1356
1357 2019-07-02  Pedro Alves  <palves@redhat.com>
1358
1359         * NEWS (Completion improvements): Mention "info threads".
1360         * thread.c (struct info_threads_opts, info_threads_option_defs)
1361         (make_info_threads_options_def_group): New.
1362         (info_threads_command): Use gdb::option::process_options.
1363         (info_threads_command_completer): New.
1364         (_initialize_thread): Use gdb::option::build_help to build the
1365         help text for "info threads".
1366
1367 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1368
1369         * defs.h (generic_load): Move from here...
1370         * symfile.h (generic_load): ... to here.  Rename name parameter
1371         to args.
1372         * symfile.c (generic_load): Add comment.
1373
1374 2019-07-01  Tom Tromey  <tromey@adacore.com>
1375
1376         * dwarf2read.c
1377         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1378         declaration of without_params.  Fix formatting.
1379
1380 2019-07-01  Tom Tromey  <tromey@adacore.com>
1381
1382         * ada-exp.y (find_primitive_type): Update.
1383         * ada-lang.h (ada_lookup_symbol): Update.
1384         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1385         parameter.
1386         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1387
1388 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1389
1390         PR breakpoints/24541
1391         * gdbarch.c: Regenerate.
1392         * gdbarch.h: Regenerate.
1393         * gdbarch.sh: Add 'stap_adjust_register'.
1394         * i386-tdep.c: Include '<unordered_set>'.
1395         (i386_stap_adjust_register): New function.
1396         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1397         * stap-probe.c (stap_parse_register_operand): Call
1398         'gdbarch_stap_adjust_register'.
1399
1400 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1401
1402         PR python/24742
1403         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1404         * python/python.c (do_start_initialization): Use 'xmalloc'
1405         instead of 'PyMem_Malloc'.
1406
1407 2019-06-28  Tom Tromey  <tromey@adacore.com>
1408
1409         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1410         for Ada.
1411
1412 2019-06-27  Tom Tromey  <tromey@adacore.com>
1413
1414         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1415         objfile_key.
1416         (arm_find_mapping_symbol, arm_record_special_symbol)
1417         (_initialize_arm_tdep): Update.
1418         (arm_objfile_data_free): Remove.
1419
1420 2019-06-27  Tom Tromey  <tromey@adacore.com>
1421
1422         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1423         to cp_print_static_field.
1424
1425 2019-06-26  Tom Tromey  <tromey@adacore.com>
1426
1427         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1428         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1429         declare.
1430
1431 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1432
1433         * features/aarch64-core.c (create_feature_aarch64_core):
1434         Regenerate.
1435         * features/aarch64-core.xml: Add cpsr flags.
1436
1437 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1438
1439         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1440         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1441
1442 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1443
1444         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1445         field.
1446         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1447         use.
1448         (arm_record_special_symbol): Don't insert new symbol in sorted
1449         position, push it at the end.
1450
1451 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1452
1453         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1454         (arm_mapping_symbol_s): Remove.
1455         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1456         (arm_mapping_symbol_vec): New typedef.
1457         (struct arm_per_objfile): Add constructor.
1458         <section_maps>: Change type to
1459         std::unique_ptr<arm_mapping_symbol_vec[]>.
1460         (arm_compare_mapping_symbols): Remove.
1461         (arm_find_mapping_symbol): Adjust to section_maps type change.
1462         (arm_objfile_data_free): Call delete on arm_per_objfile.
1463         (arm_record_special_symbol): Adjust to section_maps type change.
1464         Allocate arm_per_objfile with new.
1465
1466 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1467
1468         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1469         with the command prefix.
1470
1471 2019-06-25  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1474         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1475
1476 2019-06-25  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1479         type.
1480         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1481         protected.
1482
1483 2019-06-25  Tom Tromey  <tom@tromey.com>
1484
1485         * tui/tui-winsource.c
1486         (tui_source_window_base::set_is_exec_point_at): Add check against
1487         LOA_ADDRESS.
1488
1489 2019-06-25  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-source.c (tui_set_source_content): Don't check before
1492         xfree.
1493         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1494
1495 2019-06-25  Tom Tromey  <tom@tromey.com>
1496
1497         * tui/tui-winsource.h (tui_update_source_window_as_is)
1498         (tui_alloc_source_buffer, tui_line_is_displayed)
1499         (tui_addr_is_displayed): Change type of win_info.
1500         * tui/tui-winsource.c (tui_update_source_window_as_is)
1501         (tui_clear_source_content, tui_show_source_line)
1502         (tui_show_source_content, tui_source_window_base::refill)
1503         (tui_source_window_base::set_is_exec_point_at)
1504         (tui_source_window_base::set_is_exec_point_at)
1505         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1506         (tui_alloc_source_buffer, tui_line_is_displayed)
1507         (tui_addr_is_displayed): Change type of win_info.  Update.
1508         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1509         (tui_source_window_base::do_make_visible_with_new_height):
1510         Update.
1511         * tui/tui-source.c (tui_set_source_content)
1512         (tui_set_source_content_nil)
1513         (tui_source_window::do_scroll_vertical): Update.
1514         * tui/tui-layout.c (show_layout): Update.
1515         * tui/tui-disasm.c (tui_set_disassem_content)
1516         (tui_disasm_window::do_scroll_vertical): Update.
1517         * tui/tui-data.h (tui_win_content): Remove.
1518         (struct tui_gen_win_info) <content, content_size>: Remove.
1519         (struct tui_source_element): Add initializers and destructor.
1520         (union tui_which_element, struct tui_win_element): Remove.
1521         (struct tui_source_window_base) <content>: New field.
1522         (struct tui_data_window): Remove destructor.
1523         (tui_alloc_content, tui_free_win_content)
1524         (tui_free_all_source_wins_content): Don't declare.
1525         * tui/tui-data.c (tui_initialize_static_data): Update.
1526         (init_content_element, tui_alloc_content): Remove.
1527         (~tui_gen_win_info): Update.
1528         (~tui_data_window, tui_free_all_source_wins_content)
1529         (tui_free_win_content, free_content, free_content_elements):
1530         Remove.
1531
1532 2019-06-25  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-winsource.h (tui_clear_source_content)
1535         (tui_erase_source_content, tui_show_source_content): Change type
1536         of win_info.
1537         * tui/tui-winsource.c (tui_clear_source_content)
1538         (tui_erase_source_content, tui_show_source_content): Change type
1539         of win_info.
1540         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1541         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1542         win_info.
1543         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1544         win_info.
1545         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1546
1547 2019-06-25  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui-winsource.c (tui_clear_source_content)
1550         (tui_source_window_base::set_is_exec_point_at): Update.
1551         * tui/tui-source.c (tui_set_source_content_nil): Update.
1552         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1553         a bool.
1554         * tui/tui-data.c (init_content_element): Update.
1555
1556 2019-06-25  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1559         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1560         * tui/tui-layout.c (init_and_make_win): Update.
1561         * tui/tui.h (enum tui_win_type): Update.
1562         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1563         tui_win_is_auxillary.
1564         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1565         tui_win_is_auxillary.
1566
1567 2019-06-25  Tom Tromey  <tom@tromey.com>
1568
1569         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1570         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1571         (tui_delete_data_content_windows, tui_display_all_data)
1572         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1573         Update.
1574         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1575         * tui/tui-regs.c (tui_last_regs_line_no)
1576         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1577         (tui_show_registers): Update.
1578         (tui_show_register_group): Return void.  Update.
1579         (tui_display_registers_from, tui_display_reg_element_at_line)
1580         (tui_display_registers_from_line, tui_check_register_values):
1581         Update.
1582         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1583         member.
1584         (struct tui_data_window) <regs_content>: Now a std::vector.
1585         <regs_content_count>: Remove.
1586         (tui_add_content_elements, tui_free_data_content): Don't declare.
1587         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1588         (init_content_element): Remove DATA_WIN case.  Add assert.
1589         (tui_add_content_elements): Remove.
1590         (tui_data_window): Update.
1591         (tui_free_data_content): Remove.
1592         (free_content_elements): Remove DATA_WIN case.
1593
1594 2019-06-25  Tom Tromey  <tom@tromey.com>
1595
1596         * tui/tui-data.c (tui_data_item_window): Update.
1597         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1598         * tui/tui-windata.c (tui_display_all_data)
1599         (tui_display_data_from_line): Update.
1600         (tui_check_data_values): Remove.
1601         * tui/tui-regs.c (tui_show_register_group)
1602         (tui_display_reg_element_at_line): Update.
1603         * tui/tui-hooks.c (tui_register_changed)
1604         (tui_refresh_frame_and_register_information): Call
1605         tui_check_register_values.
1606         * tui/tui-data.h (struct tui_data_window) <data_content,
1607         data_content_count, data_type>: Remove.
1608         (enum tui_data_type): Remove.
1609
1610         * tui/tui-data.c (tui_data_window::clear_detail)
1611         (~tui_data_window): Update.
1612
1613 2019-06-25  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1616         declare.
1617         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1618         Rename from tui_first_data_item_displayed.  Update.
1619         (tui_data_window::refresh_all)
1620         (tui_data_window::do_scroll_vertical): Update.
1621         * tui/tui-data.h (struct tui_data_window)
1622         <first_data_item_displayed>: Declare new method.
1623
1624 2019-06-25  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1627         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1628         contents...
1629         (tui_initialize_static_data): ...here.
1630
1631 2019-06-25  Tom Tromey  <tom@tromey.com>
1632
1633         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1634         (tui_display_registers_from, tui_check_register_values): Update.
1635         (tui_display_register): Remove win_info parameter; update.
1636         (tui_get_register): Change type of parameters.
1637         * tui/tui-data.h (struct tui_data_element): Remove.
1638         (union tui_which_element) <data>: Remove.
1639         <data_window>: Change type.
1640         (struct tui_data_item_window): New.
1641         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1642         case.  Add assert.
1643         (~tui_data_item_window): New destructor.
1644         (free_content_elements): Remove DATA_ITEM_WIN case.
1645
1646 2019-06-25  Tom Tromey  <tom@tromey.com>
1647
1648         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1649         Remove.
1650
1651 2019-06-25  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-data.h (struct tui_command_element): Remove.
1654         (union tui_which_element) <command>: Remove.
1655         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1656         assert.
1657         (free_content_elements): Remove CMD_WIN case.
1658
1659 2019-06-25  Tom Tromey  <tom@tromey.com>
1660
1661         * tui/tui-layout.c (tui_set_layout): Update.
1662         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1663         * tui/tui-data.c (layout_def): Update.
1664
1665 2019-06-25  Tom Tromey  <tom@tromey.com>
1666
1667         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1668         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1669         (tui_source_window_base::set_new_height): Update.
1670         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1671         Update.
1672         (tui_set_locator_fullname, tui_set_locator_info)
1673         (tui_show_frame_info): Update.
1674         * tui/tui-source.c (tui_set_source_content)
1675         (tui_source_is_displayed): Update.
1676         * tui/tui-layout.c (show_source_disasm_command, show_data)
1677         (show_source_or_disasm_and_command): Update.
1678         * tui/tui-disasm.c (tui_set_disassem_content)
1679         (tui_get_begin_asm_address): Update.
1680         * tui/tui-data.h (struct tui_locator_element): Remove.
1681         (union tui_which_element) <locator>: Remove.
1682         (struct tui_locator_window): New.
1683         (tui_locator_win_info_ptr): Change return type.
1684         * tui/tui-data.c (_locator): Change type.
1685         (tui_locator_win_info_ptr): Change return type.
1686         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1687         (tui_alloc_content): Add assert.
1688
1689 2019-06-25  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-winsource.c
1692         (tui_exec_info_window::maybe_allocate_content): New method.
1693         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1694         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1695         (make_source_or_disasm_window): Add cast.
1696         * tui/tui-data.h (union tui_which_element) <simple_string>:
1697         Remove.
1698         (struct tui_source_info): New.
1699         (struct tui_source_window_base) <execution_info>: Change type.
1700         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1701         case, and add assert.
1702         (tui_alloc_content): Add assert.
1703
1704 2019-06-25  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1707         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1708         * tui/tui-data.c (tui_alloc_win_info): Remove.
1709
1710 2019-06-25  Tom Tromey  <tom@tromey.com>
1711
1712         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1713         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1714         can_highlight.
1715
1716 2019-06-25  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1719         make_visible_with_new_height method.
1720         (tui_win_info::make_visible_with_new_height): New method.
1721         (tui_source_window_base::do_make_visible_with_new_height)
1722         (tui_data_window::do_make_visible_with_new_height)
1723         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1724         (make_visible_with_new_height): Remove.
1725         (tui_resize_all, tui_adjust_win_heights): Use
1726         make_visible_with_new_height method.
1727         * tui/tui-data.h (struct tui_win_info)
1728         <do_make_visible_with_new_height, make_visible_with_new_height>:
1729         New methods.
1730         (struct tui_source_window_base, struct tui_data_window)
1731         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1732         methods.
1733
1734 2019-06-25  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1737         method.
1738         (update_tab_width): Call update_tab_width method.
1739         * tui/tui-data.h (struct tui_win_info)
1740         (struct tui_source_window_base) <update_tab_width>: New methods.
1741
1742 2019-06-25  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1745         parameter.
1746         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1747         parameter.
1748         (tui_gen_win_info::make_visible): Update.
1749         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1750         parameter.
1751         * tui/tui-data.h (enum tui_box): New enum.
1752         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1753
1754 2019-06-25  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1757         init_and_make_win for EXEC_INFO_WIN.
1758         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1759         longer inline.
1760         (struct tui_win_info) <~tui_win_info>: Inline.
1761         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1762         Don't declare.
1763         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1764         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1765         Remove.
1766         (tui_initialize_static_data): Update.
1767         (~tui_gen_win_info): Handle more cleanup here.
1768         (~tui_source_window_base): Delete "execution_info".
1769         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1770
1771 2019-06-25  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-layout.c (make_command_window): Don't set
1774         can_highlight.
1775         (show_source_disasm_command): Call the reset method.
1776         (show_data): Don't set can_highlight.  Call the reset method.
1777         (tui_gen_win_info::reset): Rename from init_gen_win_info
1778         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1779         (show_source_or_disasm_and_command): Call the reset method.
1780         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1781         (struct tui_cmd_window): Set can_highlight.
1782
1783 2019-06-25  Tom Tromey  <tom@tromey.com>
1784
1785         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1786         from make_visible.
1787         (tui_make_visible, tui_make_invisible): Rewrite.
1788         (tui_win_info::make_visible): Remove.
1789         (tui_source_window_base::make_visible): Update.
1790         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1791         method.  Moved from...
1792         (struct tui_win_info) <make_visible>: ...here.
1793
1794 2019-06-25  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-winsource.c
1797         (tui_source_window_base::do_scroll_horizontal): Remove direction
1798         parameter.
1799         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1800         direction parameter.
1801         * tui/tui-win.c (tui_win_info::forward_scroll)
1802         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1803         (tui_win_info::right_scroll): Update.
1804         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1805         direction parameter.
1806         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1807         direction parameter.
1808         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1809         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1810         Remove direction parameter.
1811         (struct tui_source_window_base, struct tui_source_window)
1812         (struct tui_disasm_window, struct tui_data_window)
1813         (struct tui_cmd_window): Update.
1814
1815 2019-06-25  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-winsource.h (tui_set_exec_info_content)
1818         (tui_show_exec_info_content, tui_erase_exec_info_content)
1819         (tui_clear_exec_info_content, tui_update_exec_info): Change
1820         argument to tui_source_window_base.
1821         * tui/tui-winsource.c (tui_set_exec_info_content)
1822         (tui_show_exec_info_content, tui_erase_exec_info_content)
1823         (tui_clear_exec_info_content, tui_update_exec_info): Change
1824         argument to tui_source_window_base.
1825
1826 2019-06-25  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1829         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1830
1831 2019-06-25  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1834         check.
1835
1836 2019-06-25  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1839         type to void.
1840         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1841         type to void.
1842         * tui/tui-source.c (tui_set_source_content): Update.
1843         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1844
1845 2019-06-25  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-win.c (window_name_completer, tui_set_focus)
1848         (tui_all_windows_info): Use name method.
1849         * tui/tui-data.h (struct tui_gen_win_info)
1850         (struct tui_source_window, struct tui_disasm_window)
1851         (struct tui_data_window, struct tui_cmd_window) <name>: New
1852         method.
1853         (tui_win_name): Don't declare.
1854         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1855         (tui_win_name): Remove.
1856
1857 2019-06-25  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-winsource.h (tui_update_source_window)
1860         (tui_update_source_window_as_is): Change parameter type.
1861         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1862         to be a tui_source_window_base.
1863         (tui_update_source_window_as_is): Likewise.
1864         * tui/tui-win.c (make_visible_with_new_height): Update.
1865
1866 2019-06-25  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-winsource.c (tui_erase_source_content)
1869         (tui_show_source_content, tui_show_exec_info_content)
1870         (tui_erase_exec_info_content): Use refresh_window method.
1871         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1872         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1873         from tui_refresh_win.
1874         (tui_data_window::refresh_window): New method.
1875         (tui_win_info::refresh, tui_source_window_base::refresh)
1876         (tui_refresh_all): Use refresh_window method.
1877         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1878         method.
1879         * tui/tui-regs.c (tui_display_register): Call refresh_window
1880         method.
1881         * tui/tui-layout.c (show_source_disasm_command)
1882         (show_source_or_disasm_and_command): Call refresh_window method.
1883         * tui/tui-data.h (struct tui_gen_win_info)
1884         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1885         New method.
1886
1887 2019-06-25  Tom Tromey  <tom@tromey.com>
1888
1889         * tui/tui.c (tui_rl_other_window, tui_enable)
1890         (tui_is_window_visible, tui_get_command_dimension): Update.
1891         * tui/tui-winsource.c (tui_update_source_window_as_is)
1892         (tui_clear_source_content, tui_erase_source_content)
1893         (tui_show_source_line, tui_source_window_base::refill)
1894         (tui_source_window_base::do_scroll_horizontal)
1895         (tui_source_window_base::set_is_exec_point_at)
1896         (tui_update_breakpoint_info, tui_set_exec_info_content)
1897         (tui_alloc_source_buffer, tui_line_is_displayed)
1898         (tui_addr_is_displayed): Update.
1899         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1900         (tui_check_and_display_highlight_if_needed)
1901         (tui_win_info::make_visible, tui_win_info::refresh)
1902         (tui_refresh_all): Update.
1903         * tui/tui-windata.c (tui_first_data_item_displayed)
1904         (tui_delete_data_content_windows, tui_erase_data_content)
1905         (tui_display_all_data, tui_data_window::refresh_all)
1906         (tui_check_data_values): Update.
1907         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1908         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1909         (tui_win_info::backward_scroll, tui_refresh_all_win)
1910         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1911         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1912         (tui_source_window_base::set_new_height)
1913         (tui_data_window::set_new_height)
1914         (make_invisible_and_set_new_height)
1915         (make_visible_with_new_height, new_height_ok)
1916         (parse_scrolling_args): Update.
1917         * tui/tui-stack.c (tui_show_frame_info): Update.
1918         * tui/tui-source.c (tui_set_source_content)
1919         (tui_set_source_content_nil, tui_source_is_displayed)
1920         (tui_source_window::do_scroll_vertical): Update.
1921         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1922         (tui_display_registers_from, tui_display_reg_element_at_line)
1923         (tui_check_register_values, tui_reg_command): Update.
1924         * tui/tui-layout.c (tui_default_win_height)
1925         (show_source_disasm_command, show_data, init_and_make_win)
1926         (show_source_or_disasm_and_command): Update.
1927         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1928         (tui_redisplay_readline, tui_mld_flush)
1929         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1930         (tui_getc): Update.
1931         * tui/tui-disasm.c (tui_set_disassem_content)
1932         (tui_disasm_window::do_scroll_vertical): Update.
1933         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1934         Now virtual.
1935         (struct tui_win_info): Derive from tui_gen_win_info.
1936         <~tui_win_info>: Mark as override.
1937         <generic>: Remove member.
1938         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1939         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1940         (~tui_data_window, ~tui_win_info)
1941         (tui_free_all_source_wins_content): Update.
1942         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1943
1944 2019-06-25  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-layout.c (init_and_make_win): Use new.
1947         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1948         destructor, initializers.
1949         (tui_alloc_generic_win_info): Don't declare.
1950         * tui/tui-data.c (_locator): Add argument to constructor.
1951         (source_win, disasm_win): New globals.
1952         (exec_info): Remove.
1953         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1954         Update.
1955         (tui_alloc_generic_win_info): Remove.
1956         (init_content_element): Use new.
1957         (tui_win_info::tui_win_info): Update.
1958         (free_content_elements) <case DATA_WIN>: Use delete.
1959
1960 2019-06-25  Tom Tromey  <tom@tromey.com>
1961
1962         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1963         * tui/tui-windata.c (tui_first_data_item_displayed)
1964         (tui_delete_data_content_windows): Update.
1965         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1966         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1967         (tui_display_registers_from, tui_check_register_values): Update.
1968         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1969         pointer.
1970         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1971         window.
1972         (tui_free_data_content): Update.
1973         (free_content_elements) <case DATA_WIN>: Free the window.
1974
1975 2019-06-25  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1978         Update.
1979         * tui/tui-layout.c (make_command_window)
1980         (show_source_disasm_command, show_data, init_and_make_win)
1981         (show_source_or_disasm_and_command): Update.
1982         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1983         method.
1984         <can_highight, is_highlighted>: Now bool.
1985         (tui_set_win_highlight): Don't declare.
1986         * tui/tui-data.c (tui_set_win_highlight): Remove.
1987
1988 2019-06-25  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-wingeneral.c (make_visible): Remove check of window
1991         type.
1992
1993 2019-06-25  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-win.c (tui_win_info::max_height)
1996         (tui_cmd_window::max_height): New methods.
1997         (new_height_ok): Call max_height.
1998         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1999         <max_height>: New method.
2000
2001 2019-06-25  Tom Tromey  <tom@tromey.com>
2002
2003         * tui/tui-win.c (tui_source_window_base::set_new_height)
2004         (tui_data_window::set_new_height): New methods.
2005         (make_invisible_and_set_new_height): Call set_new_height method.
2006         * tui/tui-data.h (struct tui_win_info)
2007         (struct tui_source_window_base, struct tui_data_window)
2008         <set_new_height>: New method.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2013         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2014         tui_refresh_data_win.
2015         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2016         method.
2017         (tui_refresh_all_win): Call the refresh_all method.
2018         (tui_set_focus): Likewise.
2019         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2020         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2021         Likewise.
2022
2023 2019-06-25  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-winsource.h (tui_refill_source_window)
2026         (tui_set_is_exec_point_at): Don't declare.
2027         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2028         (tui_source_window_base::refill): Rename from
2029         tui_refill_source_window.
2030         (tui_source_window_base::do_scroll_horizontal): Update.
2031         (tui_source_window_base::set_is_exec_point_at): Rename from
2032         tui_set_is_exec_point_at.
2033         (tui_update_all_breakpoint_info): Update.
2034         * tui/tui-stack.c (tui_show_frame_info): Update.
2035         * tui/tui-layout.c (show_data): Add cast.
2036         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2037         * tui/tui-data.h (struct tui_source_window_base) <refill,
2038         set_is_exec_point_at>: New methods.
2039         (tui_source_windows, tui_add_to_source_windows): Update types.
2040         (tui_add_to_source_windows): Remove redundant declaration.
2041         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2042         (tui_source_windows): Change return type.
2043         (tui_clear_source_windows_detail): Update.
2044         (tui_add_to_source_windows): Change type of parameter.
2045         (tui_free_all_source_wins_content): Update.
2046
2047 2019-06-25  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-wingeneral.c (tui_win_info::refresh)
2050         (tui_source_window_base::refresh): New methods.
2051         (tui_refresh_all): Call the refresh method.
2052         * tui/tui-data.h (struct tui_win_info)
2053         (struct tui_source_window_base) <refresh>: New method.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui.h (tui_is_window_visible): Return bool.
2058         * tui/tui.c (tui_is_window_visible): Return bool.
2059         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2060         (tui_make_visible, tui_make_invisible)
2061         (tui_win_info::make_visible)
2062         (tui_source_window_base::make_visible, make_all_visible)
2063         (tui_make_all_visible, tui_make_all_invisible): Update.
2064         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2065         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2066         bool.
2067         (struct tui_win_info, struct tui_source_window_base)
2068         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2069         * tui/tui-data.c (tui_init_generic_part): Update.
2070
2071 2019-06-25  Tom Tromey  <tom@tromey.com>
2072
2073         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2074         (tui_source_window_base::make_visible): New methods.
2075         (make_all_visible): Make method call.
2076         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2077         (struct tui_source_window_base, struct tui_cmd_window): Override
2078         make_visible.
2079         (tui_win_is_source_type): Don't declare.
2080         * tui/tui-data.c (tui_win_is_source_type): Remove.
2081
2082 2019-06-25  Tom Tromey  <tom@tromey.com>
2083
2084         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2085         NULL check.
2086
2087 2019-06-25  Tom Tromey  <tom@tromey.com>
2088
2089         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2090         Inline constructor.  Add initializers for members.
2091         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2092         constructors; now inline in class.
2093
2094 2019-06-25  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-regs.c (tui_show_registers): Update.
2097         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2098         bool.
2099         * tui/tui-data.c (tui_data_window::clear_detail)
2100         (tui_data_window): Update.
2101
2102 2019-06-25  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-windata.c (tui_display_all_data)
2105         (tui_display_data_from_line, tui_display_data_from)
2106         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2107         Update.
2108         * tui/tui-regs.c (tui_last_regs_line_no)
2109         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2110         (tui_show_registers, tui_show_register_group)
2111         (tui_display_registers_from, tui_display_reg_element_at_line)
2112         (tui_display_registers_from_line, tui_check_register_values)
2113         (tui_reg_next, tui_reg_prev): Update.
2114         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2115         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2116         tui_data_window.
2117         (struct tui_win_info) <detail>: Remove.  Add new fields from
2118         tui_data_info.
2119         (TUI_DATA_WIN): Add cast.
2120         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2121         (~tui_data_window): Simplify.
2122
2123 2019-06-25  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui-layout.c (show_source_disasm_command)
2126         (show_source_or_disasm_and_command): Update.
2127         * tui/tui-io.c (update_cmdwin_start_line)
2128         (tui_redisplay_readline): Update.
2129         * tui/tui-data.h (struct tui_command_info): Remove.
2130         (struct tui_win_info) <detail>: Remove command_info member.
2131         (struct tui_data_window) <start_line>: New member, from
2132         tui_command_info.
2133         (TUI_CMD_WIN): Add casts.
2134
2135 2019-06-25  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-winsource.c (tui_update_source_window)
2138         (tui_refill_source_window)
2139         (tui_source_window_base::do_scroll_horizontal)
2140         (tui_update_breakpoint_info, tui_set_exec_info_content)
2141         (tui_show_exec_info_content, tui_erase_exec_info_content)
2142         (tui_clear_exec_info_content): Update.
2143         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2144         Update.
2145         * tui/tui-win.c (make_invisible_and_set_new_height)
2146         (make_visible_with_new_height): Update.
2147         * tui/tui-source.c (tui_set_source_content)
2148         (tui_show_symtab_source): Update.
2149         * tui/tui-layout.c (extract_display_start_addr)
2150         (show_source_disasm_command, show_data)
2151         (make_source_or_disasm_window)
2152         (show_source_or_disasm_and_command): Update.
2153         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2154         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2155         "gdbarch".
2156         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2157         to tui_source_window_base.
2158         (struct tui_win_info) <detail>: Remove source_info member.
2159         (struct tui_source_window_base) <has_locator>: Inline.
2160         Move contents from tui_source_info; rename has_locator member to
2161         m_has_locator.
2162         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2163         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2164         header file.
2165         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2166         Simplify.
2167         (tui_free_all_source_wins_content): Cast to
2168         tui_source_window_base.
2169
2170 2019-06-25  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-win.c (make_invisible_and_set_new_height)
2173         (make_visible_with_new_height): Call has_locator method.
2174         * tui/tui-layout.c (show_source_disasm_command, show_data)
2175         (show_source_or_disasm_and_command): Update for bool change.
2176         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2177         (tui_win_info) <has_locator>: New method.
2178         (struct tui_source_window_base) <has_locator>: New method.
2179         (tui_win_has_locator): Don't declare.
2180         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2181         from tui_win_has_locator.
2182         (tui_source_window_base): Use false, not FALSE.
2183
2184 2019-06-25  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2187         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2188         clear_detail method directly.
2189         (tui_clear_win_detail): Remove.
2190
2191 2019-06-25  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2194         "this", not TUI_DISASM_WIN.
2195
2196 2019-06-25  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2199         declare.
2200         * tui/tui-winsource.c
2201         (tui_source_window_base::do_scroll_horizontal): Rename from
2202         tui_horizontal_source_scroll.
2203         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2204         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2205         from tui_vertical_data_scroll.
2206         * tui/tui-win.h (tui_scroll): Don't declare.
2207         * tui/tui-win.c (tui_win_info::forward_scroll)
2208         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2209         (tui_win_info::right_scroll): Rename and update.
2210         (tui_scroll_forward_command, tui_scroll_backward_command)
2211         (tui_scroll_left_command, tui_scroll_right_command): Update.
2212         (tui_scroll): Remove.
2213         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2214         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2215         from tui_vertical_source_scroll.
2216         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2217         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2218         from tui_vertical_disassem_scroll.
2219         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2220         do_scroll_horizontal>: New methods.
2221         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2222         Likewise.
2223         (struct tui_source_window_base): Add do_scroll_horizontal.
2224         (struct tui_source_window, struct tui_disasm_window): Add
2225         do_scroll_vertical.
2226         (struct tui_data_window, struct tui_cmd_window): Add
2227         do_scroll_horizontal and do_scroll_vertical.
2228         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2229
2230 2019-06-25  Tom Tromey  <tom@tromey.com>
2231
2232         * tui/tui-data.h (struct tui_source_window_base): New struct.
2233         (struct tui_source_window): Derive from tui_source_window_base.
2234         (struct tui_disasm_window): New struct.
2235         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2236         from tui_source_window::clear_detail.
2237         (tui_source_window_base): Rename from tui_source_window.
2238         (~tui_source_window_base): Rename from ~tui_source_window.
2239         (tui_alloc_win_info): Create a tui_disasm_window.
2240
2241 2019-06-25  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-data.h (struct tui_source_window)
2244         (struct tui_data_window): Declare destructors.
2245         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2246         destructors.
2247         (tui_win_info): Simplify.
2248
2249 2019-06-25  Tom Tromey  <tom@tromey.com>
2250
2251         * tui/tui-winsource.c (tui_display_main)
2252         (tui_update_source_windows_with_addr)
2253         (tui_update_all_breakpoint_info): Update.
2254         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2255         (new_height_ok, parse_scrolling_args): Update.
2256         * tui/tui-stack.c (tui_show_frame_info): Update.
2257         * tui/tui-data.h (struct tui_list): Remove.
2258         (tui_source_windows): Return a reference to a std::vector.
2259         * tui/tui-data.c (source_windows): Now a std::vector.
2260         (tui_source_windows): Change return type.
2261         (tui_clear_source_windows): Rewrite.
2262         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2263         (tui_free_all_source_wins_content): Rewrite.
2264
2265 2019-06-25  Tom Tromey  <tom@tromey.com>
2266
2267         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2268         (struct tui_data_window, struct tui_cmd_window): Declare
2269         clear_detail method.
2270         * tui/tui-data.c (tui_source_window::clear_detail)
2271         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2272         methods.
2273         (tui_clear_win_detail): Simplify.
2274
2275 2019-06-25  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-layout.c (make_source_window, make_disasm_window)
2278         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2279         Return the new window.
2280         (show_source_disasm_command, show_data)
2281         (show_source_or_disasm_and_command): Update.
2282
2283 2019-06-25  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2286         parameter.  Return the new window.
2287         (show_source_disasm_command): Update and remove NULL check.
2288         (show_source_or_disasm_and_command): Update.
2289
2290 2019-06-25  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2293
2294 2019-06-25  Tom Tromey  <tom@tromey.com>
2295
2296         * tui/tui-data.h (struct tui_win_info): Make constructor
2297         protected.  Make destructor virtual.  Add initializers.
2298         (tui_source_window, tui_data_window, tui_cmd_window): New
2299         classes.
2300         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2301         constructor.  Add "type" parameter.
2302         (tui_source_window, tui_data_window, tui_cmd_window): New
2303         constructors.
2304         (tui_alloc_win_info): Instantiate the appropriate subclass.
2305
2306 2019-06-25  Tom Tromey  <tom@tromey.com>
2307
2308         * tui/tui-win.c (tui_resize_all): Use delete.
2309         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2310         destructor.
2311         (tui_free_window): Don't declare.
2312         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2313         Update.
2314
2315 2019-06-25  Tom Tromey  <tom@tromey.com>
2316
2317         * tui/tui-data.h (struct tui_win_info): Add constructor.
2318         * tui/tui-data.c (tui_alloc_win_info): Use new.
2319         (tui_free_window): Use delete.
2320
2321 2019-06-22  Tom Tromey  <tom@tromey.com>
2322
2323         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2324         declare.
2325         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2326
2327 2019-06-22  Tom Tromey  <tom@tromey.com>
2328
2329         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2330         declare.
2331         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2332
2333 2019-06-22  Tom de Vries  <tdevries@suse.de>
2334
2335         * dwarf2read.c (create_addrmap_from_aranges)
2336         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2337         instead of '%zu'.
2338
2339 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2340
2341         * dwarf2read.h (dwarf2_section_info_def): Remove.
2342         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2343         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2344         std::vector<dwarf2_section_info>.
2345         (struct dwo_file) <~dwo_file>: Remove.
2346         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2347         types field.
2348         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2349         (dwarf2_read_debug_names): Likewise.
2350         (create_debug_types_hash_table): Change parameter type to
2351         array_view, adjust code accordingly.
2352         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2353         (partial_die_info::fixup): Likewise.
2354         (determine_prefix): Likewise.
2355         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2356
2357 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2358
2359         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2360         gdb_bfd_ref_ptr.
2361         <~dwo_file>: Remove call to gdb_bfd_unref.
2362         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2363         gdb_bfd_ref_ptr::get.
2364
2365 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2366
2367         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2368         type to htab_up.
2369         * dwarf2read.c (struct dwo_file): Initialize fields.
2370         <~dwo_file>: New.
2371         (free_dwo_file): Remove, move content to ~dwo_file.
2372         (struct dwo_file_deleter): Remove.
2373         (dwo_file_up>: Remove custom deleter.
2374         (free_dwo_files): Remove.
2375         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2376         dwo_files.
2377         (process_skeletonless_type_units): Call unique_ptr::get.
2378         (allocate_dwo_file_hash_table): Add deleter to created hash
2379         table.  Change return type to htab_up.
2380         (lookup_dwo_file_slot): Don't memset dwo_file, call
2381         unique_ptr::get.
2382         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2383         (create_dwo_unit_in_dwp_v2): Likewise.
2384         (open_and_init_dwo_file): Likewise.
2385         (free_dwo_file_from_slot): Remove.
2386
2387 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2388
2389         * dwarf2read.h (struct dwarf2_section_info) <readin,
2390         is_virtual>: Change type to bool.
2391         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2392         true instead of 1.
2393
2394 2019-06-19  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui-data.h (tui_init_content_element): Don't declare.
2397
2398 2019-06-19  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-data.h (tui_init_win_info): Don't declare.
2401
2402 2019-06-19  Tom de Vries  <tdevries@suse.de>
2403
2404         * dwarf2read.h (abstract_to_concrete): Change type to
2405         std::unordered_map<sect_offset, std::vector<sect_offset>,
2406         gdb::hash_enum<sect_offset>>.
2407
2408 2019-06-19  Tom Tromey  <tromey@adacore.com>
2409
2410         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2411         EVAL_AVOID_SIDE_EFFECTS specially.
2412
2413 2019-06-19  Tom Tromey  <tromey@adacore.com>
2414
2415         * source-cache.c (highlighter): New global.
2416         (source_cache::get_source_lines): Create a highlighter on demand.
2417
2418 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2419
2420         * defs.h (deprecated_interactive_hook): Delete declaration.
2421         * interps.c (clear_interpreter_hooks): Remove use of
2422         deprecated_interactive_hook.
2423         * top.c (deprecated_interactive_hook): Delete definition.
2424         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2425
2426 2019-06-18  Tom de Vries  <tdevries@suse.de>
2427
2428         PR gdb/24515
2429         * dwarf2read.h (abstract_to_concrete): Change type from
2430         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2431         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2432         * dwarf2read.c (read_variable): Update.
2433         (dwarf2_fetch_die_loc_sect_off): Update.
2434
2435 2019-06-17  Tom de Vries  <tdevries@suse.de>
2436
2437         PR gdb/24617
2438         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2439         accessing parent[parent_len - 1].
2440
2441 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2442
2443         PR gdb/24364
2444         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2445         call dtrace_process_dof with NULL dof.
2446
2447 2019-06-16  Tom de Vries  <tdevries@suse.de>
2448
2449         PR gdb/24445
2450         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2451
2452 2019-06-16  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2455         (make_all_visible): Use address of member.
2456
2457 2019-06-16  Tom Tromey  <tom@tromey.com>
2458
2459         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2460         (tui_free_window, free_content, free_content_elements): Remove
2461         unnecessary cast.
2462         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2463         cast.
2464         * tui/tui-regs.c (tui_show_register_group)
2465         (tui_display_registers_from, tui_display_reg_element_at_line):
2466         Remove unnecessary cast.
2467
2468 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2469
2470         * linux-nat.c (normal_mask): Delete.
2471         (_initialize_linux_nat): Don't initialise normal_mask.
2472
2473 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2474
2475         PR gdb/24445
2476         * dwarf-index-write.h (write_psymtabs_to_index): Add
2477         dwz_basename parameter.
2478         * dwarf-index-write.c (write_gdbindex): Move file writing to
2479         write_gdbindex_1.  Change return type void.
2480         (assert_file_size): Move up, remove filename parameter.
2481         (write_gdbindex_1): New function.
2482         (write_debug_names): Change return type to void, call
2483         assert_file_size.
2484         (struct index_wip_file): New struct.
2485         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2486         file logic to index_wip_file.  Write index for dwz file if
2487         needed.
2488         (save_gdb_index_command): Pass basename of dwz file, if present.
2489         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2490         build-id of dwz file, if present.
2491         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2492         (dwarf2_get_dwz_file): Likewise.
2493         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2494         (dwarf2_get_dwz_file): Likewise.
2495
2496 2019-06-16  Tom Tromey  <tom@tromey.com>
2497
2498         * coffread.c (process_coff_symbol): Use xstrdup.
2499         * value.c (create_internalvar): Use xstrdup.
2500
2501 2019-06-16  Tom Tromey  <tom@tromey.com>
2502
2503         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2504         * breakpoint.c (stopin_command, stopat_command)
2505         (until_break_command, decode_location_default): Remove unnecessary
2506         cast.
2507         * utils.c (subset_compare): Remove unnecessary cast.
2508         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2509         cast.
2510         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2511         cast.
2512         * infcmd.c (path_command): Remove unnecessary cast.
2513         * coffread.c (decode_type): Remove unnecessary cast.
2514         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2515         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2516         * tui/tui-stack.c (tui_show_locator_content)
2517         (tui_show_frame_info): Remove unnecessary cast.
2518         * tui/tui-win.c (tui_scroll_forward_command)
2519         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2520         (parse_scrolling_args): Remove unnecessary cast.
2521         * tui/tui-data.c (init_win_info, tui_del_window)
2522         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2523         (free_content_elements): Remove unnecessary cast.
2524         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2525         unnecessary cast.
2526         * tui/tui-source.c (tui_set_source_content)
2527         (tui_vertical_source_scroll): Remove unnecessary cast.
2528         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2529         cast.
2530         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2531         * tui/tui-regs.c (tui_display_registers_from)
2532         (tui_display_register): Remove unnecessary cast.
2533         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2534         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2535         (make_visible): Remove unnecessary cast.
2536         * tui/tui-winsource.c (tui_erase_source_content)
2537         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2538         unnecessary cast.
2539         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2540         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2541         * stabsread.c (read_type, read_array_type, read_range_type):
2542         Remove unnecessary cast.
2543         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2544         (parse_symbol, parse_type, upgrade_type, parse_external)
2545         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2546         unnecessary cast.
2547         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2548
2549 2019-06-16  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui-data.c (tui_alloc_generic_win_info)
2552         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2553         checks.
2554
2555 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2556             Andrew Burgess  <andrew.burgess@embecosm.com>
2557
2558         * f-typeprint.c (f_print_type): Don't return early for not
2559         associated or not allocated types.
2560         (f_type_print_varspec_suffix): Add print_rank parameter and print
2561         ranks of array types in case they dangling.
2562         (f_type_print_base): Add print_rank parameter.
2563
2564 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2565
2566         * NEWS: Mention new MI commands.
2567         * break-catch-throw.c (enum exception_event_kind): Move to
2568         breakpoint.h.
2569         (print_mention_exception_catchpoint): Output text as a single
2570         message.
2571         (catch_exception_command_1): Rename to...
2572         (catch_exception_event): ...this, make non-static, update header
2573         command, and change some parameter types.
2574         (catch_catch_command): Update for changes to
2575         catch_exception_command_1.
2576         (catch_throw_command): Likewise.
2577         (catch_rethrow_command): Likewise.
2578         * breakpoint.c (enum exception_event_kind): Delete.
2579         * breakpoint.h (enum exception_event_kind): Moved here from
2580         break-catch-throw.c.
2581         (catch_exception_event): Declare.
2582         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2583         (mi_cmd_catch_throw): New function.
2584         (mi_cmd_catch_rethrow): New function.
2585         (mi_cmd_catch_catch): New function.
2586         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2587         'catch-catch' entries.
2588         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2589         (mi_cmd_catch_rethrow): Declare.
2590         (mi_cmd_catch_catch): Declare.
2591
2592 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2593
2594         * annotate.c (annotate_source_line): Change return type to void,
2595         update implementation to match.
2596         * annotate.h (annotate_source_line): Change return type to void,
2597         update header comment.
2598         * stack.c (print_frame_info): Don't change what frame information
2599         is printed based on whether annotations are on or not.
2600
2601 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2602
2603         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2604         (annotate_source): Make static.
2605         (annotate_source_line): Moved from source.c and renamed from
2606         identify_source_line.  Update the return type.
2607         * annotate.h (annotate_source): Delete declaration.
2608         (annotate_source_line): Declaration moved from source.h, and
2609         renamed from identify_source_line.  Return type updated.
2610         * source.c (identify_source_line): Moved to annotate.c and renamed
2611         to annotate_source_line.
2612         (info_line_command): Remove check of annotation_level.
2613         * source.h (identify_source_line): Move declaration to annotate.h
2614         and rename to annotate_source_line.
2615         * stack.c: Add 'annotate.h' include.
2616         (print_frame_info): Remove check of annotation_level before
2617         calling annotate_source_line.
2618
2619 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2620
2621         * source-cache.c (source_cache::get_plain_source_lines): Use
2622         open_source_file_with_line_charpos instead of just
2623         open_source_file, remove call to find_source_lines.
2624         (source_cache::get_source_lines): Likewise.
2625         * source.c (find_source_lines): Make static.
2626         (get_filename_and_charpos): Renamed into...
2627         (open_source_file_with_line_charpos): ..this along with changes to
2628         return a scoped_fd, and some other minor clean ups.
2629         (identify_source_line): Use open_source_file_with_line_charpos.
2630         (search_command_helper): Use open_source_file_with_line_charpos
2631         instead of just open_source_file, remove call to
2632         find_source_lines.
2633         * source.h (open_source_file_with_line_charpos): Declare new
2634         function.
2635         (find_source_lines): Delete declaration.
2636
2637 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2638
2639         * source.c (get_filename_and_charpos): Remove fullname
2640         parameter.
2641         (identify_source_line): Update call to get_filename_and_charpos.
2642
2643 2019-06-14  Tom Tromey  <tromey@adacore.com>
2644
2645         PR gdb/24502:
2646         * ui-style.h (skip_ansi_escape): Update comment.
2647         * ui-file.h (class no_terminal_escape_file): New class.
2648         * ui-file.c (no_terminal_escape_file::write)
2649         (no_terminal_escape_file::puts): New methods.
2650         * cli/cli-logging.c (handle_redirections): Use
2651         no_terminal_escape_file.
2652
2653 2019-06-14  Tom Tromey  <tromey@adacore.com>
2654
2655         * NEWS: Move convenience variable news above Python news.
2656
2657 2019-06-14  Tom Tromey  <tom@tromey.com>
2658
2659         * gnulib: Move directory to top-level.
2660         * configure.ac: Don't configure gnulib.
2661         * configure: Rebuild.
2662         * common/common-defs.h: Use new path to gnulib.
2663         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2664         (GNULIB_H): Remove.
2665         (INCGNU): Look in new gnulib location.
2666         (HFILES_NO_SRCDIR): Remove gnulib files.
2667         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2668         (generated_files): Remove GNULIB_H.
2669         ($(LIBGNU), all-lib): Remove targets.
2670         (distclean): Don't mention GNULIB_BUILDDIR.
2671         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2672
2673 2019-06-14  Tom Tromey  <tromey@adacore.com>
2674
2675         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2676         Warn if symbol file does not provide any symbols.
2677
2678 2019-06-14  Tom Tromey  <tromey@adacore.com>
2679
2680         * source.c (find_and_open_source): Respect basenames_may_differ.
2681
2682 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2683
2684         * annotate.c (annotate_breakpoints_invalid): Make use of
2685         scoped_restore_terminal_state.
2686         (annotate_frames_invalid): Likewise.
2687
2688 2019-06-14  Tom Tromey  <tromey@adacore.com>
2689
2690         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2691         allow assignment to an internalvar.
2692
2693 2019-06-14  Tom Tromey  <tromey@adacore.com>
2694
2695         * ada-lex.l: Allow "_" in attribute names.
2696
2697 2019-06-14  Tom Tromey  <tromey@adacore.com>
2698
2699         PR gdb/24653:
2700         * regcache.c (registers_changed): Don't call alloca.
2701         * top.c (execute_command): Don't call alloca.
2702
2703 2019-06-13  Pedro Alves  <palves@redhat.com>
2704
2705         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2706         'expression'.  When parsing an expression, error out if there's
2707         junk after "unlimited".
2708         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2709         (do_set_command): Adjust calls to is_unlimited_literal.
2710
2711 2019-06-13  Pedro Alves  <palves@redhat.com>
2712
2713         * compile/compile.c (make_compile_options_def_group): Add braces
2714         around array_view initializer.
2715         * thread.c (make_thread_apply_all_options_def_group)
2716         (make_thread_apply_all_options_def_group): Likewise.
2717
2718 2019-06-13  Pedro Alves  <palves@redhat.com>
2719
2720         * NEWS (New commands): Mention "maint test-options
2721         require-delimiter", "maint test-options unknown-is-error", "maint
2722         test-options unknown-is-operand" and "maint show
2723         test-options-completion-result".
2724         (New command options, command completion): New section.
2725         (Completion improvements): New section.
2726         Mention that you can abbreviate "unlimited".
2727
2728 2019-06-13  Pedro Alves  <palves@redhat.com>
2729
2730         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2731         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2732         * unittests/cli-utils-selftests.c (test_parse_flags)
2733         (test_parse_flags_qcs): Delete.
2734         (test_cli_utils): Don't call deleted functions.
2735
2736 2019-06-13  Pedro Alves  <palves@redhat.com>
2737
2738         * thread.c: Include "cli/cli-option.h".
2739         (tp_array_compar_ascending): Global.
2740         (tp_array_compar): Delete function.
2741         (tp_array_compar_ascending, tp_array_compar_descending): New
2742         functions.
2743         (ascending_option_def, qcs_flag_option_def)
2744         (thr_qcs_flags_option_defs)
2745         (make_thread_apply_all_options_def_group)
2746         (make_thread_apply_options_def_group): New.
2747         (thread_apply_all_command): Use gdb::option::process_options.
2748         (thread_apply_command_completer)
2749         (thread_apply_all_command_completer): New.
2750         (thread_apply_command): Use gdb::option::process_options.
2751         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2752         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2753         to generate help text of "thread apply".  Adjust "taas"'s help.
2754         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2755         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2756
2757 2019-06-13  Pedro Alves  <palves@redhat.com>
2758
2759         * thread.c (thread_apply_command): Check for invalid TID with
2760         isdigit instead of !isalpha.
2761
2762 2019-06-13  Pedro Alves  <palves@redhat.com>
2763
2764         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2765         (validate_flags_qcs): New.
2766         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2767         (validate_flags_qcs): Declare.
2768         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2769         (make_frame_apply_options_def_group): New.
2770         (frame_apply_command_count): Process options with
2771         gdb::option::process_options.
2772         (frame_apply_completer): New.
2773         (frame_apply_level_completer, frame_apply_all_completer)
2774         (frame_apply_completer): New.
2775         (_initialize_stack): Update help of "frame apply", "frame apply
2776         level", "frame apply all" and "faas" to mention supported options
2777         and install command completers.
2778         * stack.h (frame_apply_all_completer): Declare.
2779         * thread.c: Include "stack.h".
2780         (tfaas_command): Add "--".
2781         (_initialize_thread): Update help "tfaas" to mention supported
2782         options and install command completer.
2783
2784 2019-06-13  Pedro Alves  <palves@redhat.com>
2785
2786         * completer.c (complete_nested_command_line): New.
2787         (gdb_completion_word_break_characters_throw): Add assertion.
2788         * completer.h (complete_nested_command_line): Declare.
2789
2790 2019-06-13  Pedro Alves  <palves@redhat.com>
2791
2792         * stack.c (parse_backtrace_qualifiers): New.
2793         (backtrace_command): Use it.
2794         (backtrace_command_completer): Complete on qualifiers.
2795
2796 2019-06-13  Pedro Alves  <palves@redhat.com>
2797
2798         * frame.c: Include "cli/cli-option.h.
2799         (user_set_backtrace_options): New.
2800         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2801         Delete.
2802         (get_prev_frame): Adjust.
2803         (boolean_option_def, uinteger_option_def)
2804         (set_backtrace_option_defs): New.
2805         (_initialize_frame): Adjust and use
2806         gdb::option::add_setshow_cmds_for_options to install "set
2807         backtrace past-main" and "set backtrace past-entry".
2808         * frame.h: Include "cli/cli-option.h".
2809         (struct frame_print_options): Forward declare.
2810         (print_frame_arguments_all, print_frame_arguments_scalars)
2811         (print_frame_arguments_none): Declare.
2812         (print_entry_values): Delete declaration.
2813         (struct frame_print_options, user_frame_print_options): New.
2814         (struct set_backtrace_options): New.
2815         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2816         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2817         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2818         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2819         (list_args_or_locals): Add frame_print_options parameter.
2820         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2821         * python/py-framefilter.c (enumerate_args): Pass down
2822         USER_FRAME_PRINT_OPTIONS.
2823         * stack.c: Include "cli/cli-option.h".
2824         (print_frame_arguments_all, print_frame_arguments_scalars)
2825         (print_frame_arguments_none): Declare.
2826         (print_raw_frame_arguments, print_entry_values): Delete.
2827         (user_frame_print_options): New.
2828         (boolean_option_def, enum_option_def, frame_print_option_defs):
2829         New.
2830         (struct backtrace_cmd_options): New.
2831         (bt_flag_option_def): New.
2832         (backtrace_command_option_defs): New.
2833         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2834         (print_frame_arg, read_frame_arg, print_frame_args)
2835         (print_frame_info, print_frame): Add frame_print_options parameter
2836         and use it.
2837         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2838         (backtrace_command_1): Add frame_print_options and
2839         backtrace_cmd_options parameters and use them.
2840         (make_backtrace_options_def_group): New.
2841         (backtrace_command): Process command options with
2842         gdb::option::process_options.
2843         (backtrace_command_completer): New.
2844         (_initialize_stack): Extend "backtrace"'s help to mention
2845         supported options.  Install completer for "backtrace".
2846         Install some settings commands with add_setshow_cmds_for_options.
2847
2848 2019-06-13  Pedro Alves  <palves@redhat.com>
2849
2850         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2851         and that "set/show print raw frame-arguments" are now deprecated.
2852
2853         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2854         command.
2855         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2856         * stack.c (_initialize_stack): Install "set/show print
2857         raw-frame-arguments", and deprecate "set/show print raw
2858         frame-arguments".
2859         * valprint.c (_initialize_valprint): Deprecate "set/show print
2860         raw".
2861
2862 2019-06-13  Pedro Alves  <palves@redhat.com>
2863
2864         * compile/compile.c (struct compile_options): New.
2865         (compile_flag_option_def, compile_command_option_defs)
2866         (make_compile_options_def_group): New.
2867         (compile_file_command): Handle options with
2868         gdb::option::process_options.
2869         (compile_file_command_completer): New function.
2870         (compile_code_command): Handle options with
2871         gdb::option::process_options.
2872         (compile_code_command_completer): New function.
2873         (_initialize_compiler): Install completers for "compile code" and
2874         "compile file".  Mention available options in "compile code" and
2875         "compile code"'s help.
2876         * completer.c (advance_to_completion_word): New, factored out from
2877         ...
2878         (advance_to_expression_complete_word_point): ... this.
2879         (advance_to_filename_complete_word_point): New.
2880         * completer.h (advance_to_filename_complete_word_point): New
2881         declaration.
2882
2883 2019-06-13  Pedro Alves  <palves@redhat.com>
2884
2885         * compile/compile.c: Include "cli/cli-option.h".
2886         (compile_print_value): Scope data pointer is now a
2887         value_print_options pointer; adjust.
2888         (compile_print_command): Process options.  Scope data pointer is
2889         now a value_print_options pointer; adjust.
2890         (_initialize_compile): Update "compile print"'s help to include
2891         supported options.  Install a completer for "compile print".
2892         * cp-valprint.c (show_vtblprint, show_objectprint)
2893         (show_static_field_print): Delete.
2894         (_initialize_cp_valprint): Don't install "set print
2895         static-members", "set print vtbl", "set print object" here.
2896         * printcmd.c: Include "cli/cli-option.h" and
2897         "common/gdb_optional.h".
2898         (print_command_parse_format): Rework to fill in a
2899         value_print_options instead of a format_data.
2900         (print_value): Change parameter type from format_data pointer to
2901         value_print_options reference.  Adjust.
2902         (print_command_1): Process options.  Adjust to pass down a
2903         value_print_options.
2904         (print_command_completer): New.
2905         (_initialize_printcmd): Install print_command_completer as
2906         handle_brkchars completer for the "print" command.  Update
2907         "print"'s help to include supported options.
2908         * valprint.c: Include "cli/cli-option.h".
2909         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2910         here from cp-valprint.c.
2911         (boolean_option_def, uinteger_option_def)
2912         (value_print_option_defs, make_value_print_options_def_group):
2913         New.  Use gdb::option::add_setshow_cmds_for_options to install
2914         "set print elements", "set print null-stop", "set print repeats",
2915         "set print pretty", "set print union", "set print array", "set
2916         print address", "set print symbol", "set print array-indexes".
2917         * valprint.h: Include <string> and "cli/cli-option.h".
2918         (make_value_print_options_def_group): Declare.
2919         (print_value): Change parameter type from format_data pointer to
2920         value_print_options reference.
2921         (print_command_completer): Declare.
2922
2923 2019-06-13  Pedro Alves  <palves@redhat.com>
2924
2925         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2926         (COMMON_SFILES): Add maint-test-settings.c.
2927         * cli/cli-decode.c (boolean_enums): New global, factored out from
2928         ...
2929         (add_setshow_boolean_cmd): ... here.
2930         * cli/cli-decode.h (boolean_enums): Declare.
2931         * cli/cli-option.c: New file.
2932         * cli/cli-option.h: New file.
2933         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2934         factored out from ...
2935         (parse_cli_boolean_value(const char *)): ... this.
2936         (is_unlimited_literal): Change parameter type to pointer to
2937         pointer.  Adjust and advance ARG pointer.
2938         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2939         (parse_cli_var_enum): New, factored out from ...
2940         (do_set_command): ... this.  Adjust.
2941         * cli/cli-setshow.h (parse_cli_boolean_value)
2942         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2943         (parse_cli_var_enum): Declare.
2944         * cli/cli-utils.c: Include "cli/cli-option.h".
2945         (get_ulongest): New.
2946         * cli/cli-utils.h (get_ulongest): Declare.
2947         (check_for_argument): New overloads.
2948         * maint-test-options.c: New file.
2949
2950 2019-06-13  Pedro Alves  <palves@redhat.com>
2951
2952         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2953         parse a range if "-" is at the end of the string.
2954
2955 2019-06-13  Pedro Alves  <palves@redhat.com>
2956
2957         * cli/cli-setshow.c (parse_auto_binary_operation)
2958         (parse_cli_boolean_value): Don't allow "o".
2959
2960 2019-06-13  Pedro Alves  <palves@redhat.com>
2961
2962         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2963         * NEWS: Mention maint test-settings KIND.
2964         * maint-test-settings.c: New file.
2965
2966 2019-06-13  Pedro Alves  <palves@redhat.com>
2967
2968         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2969         completer.
2970         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2971         "set" completers.
2972
2973 2019-06-13  Pedro Alves  <palves@redhat.com>
2974
2975         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2976         after item.
2977
2978 2019-06-13  Pedro Alves  <palves@redhat.com>
2979
2980         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2981
2982 2019-06-13  Pedro Alves <palves@redhat.com>
2983
2984         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2985         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2986         call.
2987         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2988         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2989         calls.
2990         (check_for_argument): Skip spaces after argument.
2991
2992 2019-06-13  Pedro Alves  <palves@redhat.com>
2993
2994         * thread.c (thread_apply_command): Adjust TID parsing.
2995         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2996         detected before end of string.
2997         (tid_is_in_list): Error out if LIST is invalid.
2998
2999 2019-06-13  Pedro Alves  <palves@redhat.com>
3000
3001         * completer.c (complete_line_internal_1): Rewind completion word
3002         point.
3003         (completion_tracker::advance_custom_word_point_by): Change
3004         parameter type to int.
3005         * completer.h (completion_tracker::advance_custom_word_point_by):
3006         Likewise.
3007
3008 2019-06-13  Pedro Alves  <palves@redhat.com>
3009
3010         * completer.c (advance_to_completion_word): Handle delimiters.
3011
3012 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3013
3014         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3015
3016 2019-06-11  Tom Tromey  <tom@tromey.com>
3017
3018         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3019         (xmalloc_failed): Move to alloc.c.
3020         * alloc.c: New file.
3021         * Makefile.in (COMMON_SFILES): Add alloc.c.
3022
3023 2019-06-11  Tom Tromey  <tom@tromey.com>
3024
3025         * nat/linux-waitpid.c: Don't include server.h.
3026         (linux_debug): Remove.
3027         (my_waitpid): Update.
3028
3029 2019-06-11  Tom Tromey  <tromey@adacore.com>
3030
3031         * infcall.c (_initialize_infcall): Remove trailing newline from
3032         help.
3033         * user-regs.c (_initialize_user_regs): Remove trailing newline
3034         from help.
3035         * typeprint.c (_initialize_typeprint): Remove trailing newline
3036         from help.
3037         * reverse.c (_initialize_reverse): Remove trailing newlines from
3038         help.
3039         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3040         from help.
3041         * language.c (add_set_language_command): Remove trailing newline
3042         from help.
3043         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3044         help.
3045         * disasm.c (_initialize_disasm): Remove trailing newline from
3046         help.
3047         * top.c (init_main): Remove trailing newline from help.
3048         * interps.c (_initialize_interpreter): Remove trailing newline
3049         from help.
3050         * btrace.c (_initialize_btrace): Remove trailing newlines from
3051         help.
3052         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3053         from help.
3054         * python/python.c (_initialize_python): Remove trailing newline
3055         from help.
3056         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3057         help.
3058         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3059         from help.  Reformat some text.
3060         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3061         from help.
3062         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3063         newline from help.
3064
3065 2019-06-11  Tom Tromey  <tromey@adacore.com>
3066
3067         * darwin-nat.c (darwin_decode_exception_message)
3068         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3069
3070 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3071
3072         * valops.c (value_slice): Check for not allocated or not
3073         associated values.
3074
3075 2019-06-10  Tom de Vries  <tdevries@suse.de>
3076
3077         PR gdb/24618
3078         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3079         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3080         invalid.
3081
3082 2019-06-10  Tom de Vries  <tdevries@suse.de>
3083
3084         PR gdb/24611
3085         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3086         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3087
3088 2019-06-10  Tom de Vries  <tdevries@suse.de>
3089
3090         PR symtab/24545
3091         * symtab.c (struct demangled_name_entry): Add language field.
3092         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3093         static minimal symbol".  Set and use language field.
3094
3095 2019-06-10  Tom Tromey  <tromey@adacore.com>
3096
3097         * ada-lang.c (_initialize_ada_language): Update help text.
3098
3099 2019-06-10  Tom Tromey  <tromey@adacore.com>
3100
3101         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3102         with a newline.
3103         * guile/guile.c (handle_boot_error): Don't end warning with a
3104         newline.
3105         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3106         warning with a newline.
3107         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3108         newline.
3109         (s12z_frame_cache): Likewise.
3110         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3111         a newline.
3112         * solib-svr4.c (disable_probes_interface): Don't end warning with
3113         a newline.
3114         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3115         newline.
3116         * python/python.c (do_finish_initialization): Don't end warning
3117         with a newline.
3118
3119 2019-06-10  Tom Tromey  <tom@tromey.com>
3120
3121         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3122         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3123         gdbpy_enter.
3124
3125 2019-06-10  Tom Tromey  <tromey@adacore.com>
3126
3127         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3128         data.
3129         (elf_new_init): Don't call stabsread_new_init.
3130         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3131         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3132         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3133
3134 2019-06-10  Tom de Vries  <tdevries@suse.de>
3135
3136         PR symtab/16264
3137         PR symtab/24517
3138         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3139
3140 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3141
3142         * source.c (find_and_open_source): Also rewrite relative file
3143         names.
3144
3145 2019-04-26  Amos Bird  <amosbird@gmail.com>
3146
3147         * annotate.c (annotate_thread_exited): Add "thread-exited"
3148         annotation.
3149
3150 2019-06-06  Tom Tromey  <tromey@adacore.com>
3151
3152         * maint.h (class scoped_command_stats): Use
3153         DISABLE_COPY_AND_ASSIGN.
3154         <print_time>: New method.
3155         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3156         print_time.
3157         (scoped_command_stats::print_time): New method.
3158
3159 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3160
3161         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3162         instructions of lengths 6 or 8 bytes.
3163
3164 2019-06-04  Pedro Alves  <palves@redhat.com>
3165
3166         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3167
3168         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3169         * breakpoint.c (condition_completer): Likewise.
3170         * cli/cli-dump.c (scan_expression): Likewise.
3171         * common/filestuff.c (mkdir_recursive): Likewise.
3172         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3173         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3174         (gdb_abspath): Likewise.
3175         * compile/compile-cplus-types.c
3176         (compile_cplus_instance::decl_name): Likewise.
3177         * completer.c (complete_explicit_location):
3178         (signal_completer, reg_or_group_completer_1): Likewise.
3179         * cp-support.c (cp_remove_params_if_any): Likewise.
3180         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3181         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3182         * infcmd.c (strip_bg_char): Likewise.
3183         * linespec.c (copy_token_string): Likewise.
3184         * mi/mi-main.c (output_cores): Likewise.
3185         * psymtab.c (psymtab_search_name):
3186         * symfile.c (test_set_ext_lang_command): Likewise.
3187         * target.c (target_fileio_read_stralloc): Likewise.
3188         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3189         * value.c (complete_internalvar): Likewise.
3190
3191 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3192
3193         Add objfile property to gdb.Type.
3194         * NEWS: Mention Python API addition.
3195         * python/py-type.c (typy_get_objfile): New method.
3196
3197 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3198
3199         * NEWS: Mention the new set|show style [title|highlight].
3200         Mention changes to "show style", "help" and "apropos".
3201
3202 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3203
3204         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3205         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3206         instead of print_help_for_command.
3207         (print_doc_of_command): New function.
3208         (help_list): Add 'apropos -v word' suggestion.
3209         (print_help_for_command): Style the command name using title style.
3210         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3211         (_initialize_cli_cmds): Describe -v in apropos_command help.
3212
3213 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3214
3215         * cli/cli-style.h (cli_style_option): Add name in constructor,
3216         add m_name class member, add constructor with intensity,
3217         add name class function.
3218         (cli_style_option::add_setshow_commands): Remove name argument.
3219         (highlight_style, title_style): New styles.
3220         * cli/cli-style.c (do_show): New function that shows a style
3221         characteristic styling the style name with itself.
3222         (set_style_name): New function.
3223         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3224         Update all callers according to the changes in cli/cli-style.h.
3225         * utils.h (fputs_highlighted): New function.
3226         * utils.c (fputs_highlighted): Likewise.
3227
3228 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3229
3230         * NEWS: Mention new pipe command and new convenience variables.
3231
3232 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3233
3234         * cli/cli-cmds.c (pipe_command): New function.
3235         (_initialize_cli_cmds): Call add_com for pipe_command.
3236         Define | as an alias for pipe.
3237         (exit_status_set_internal_vars): New function.
3238         (shell_escape): Call exit_status_set_internal_vars.
3239         cli/cli-decode.c (find_command_name_length): Recognize | as
3240         a single character command.
3241
3242 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3243
3244         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3245         top.c (execute_command_to_ui_file): New function, mostly a copy
3246         of execute_command_to_string.
3247         (execute_command_to_string): Implement by calling
3248         execute_command_to_ui_file.
3249
3250 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3251
3252         * top.h (saved_command_line): Remove declaration.
3253         * top.c (previous_saved_command_line, previous_repeat_arguments):
3254         New variables.
3255         (saved_command_line): Make static, define together with other
3256         'repeat variables'.
3257         (dont_repeat): Clear repeat_arguments.
3258         (repeat_previous, get_saved_command_line, save_command_line):
3259         New functions.
3260         (gdb_init): Initialize saved_command_line
3261         and previous_saved_command_line.
3262         * main.c (captured_main_1): Remove saved_command_line initialization.
3263         * event-top.c (handle_line_of_input): Update to use
3264         the new 'repeat' related functions instead of direct access to
3265         saved_command_line.
3266         * command.h (repeat_previous, get_saved_command_line,
3267         save_command_line): New declarations.
3268         (dont_repeat): Add comment.
3269
3270 2019-05-30  Tom Tromey  <tromey@adacore.com>
3271
3272         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3273         Fix comment.
3274         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3275
3276 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3277
3278         PR cli/24587
3279         * completer.c (complete): Initialize variable word.
3280
3281 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3282
3283         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3284         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3285         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3286         'body' is NULL to the outter 'if', protecting the '!is_define'
3287         situation as well.
3288
3289 2019-05-29  Tom Tromey  <tromey@adacore.com>
3290
3291         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3292         (dwarf_unknown): New function.
3293         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3294         (dwarf_type_encoding_name): Use dwarf_unknown.
3295
3296 2019-05-29  Tom Tromey  <tromey@adacore.com>
3297
3298         PR c++/20020:
3299         * cp-valprint.c (cp_print_value_fields): Call
3300         cp_print_static_field inside "try".
3301
3302 2019-05-29  Tom Tromey  <tromey@adacore.com>
3303
3304         * inflow.c (struct terminal_info): Add default operator=.
3305         * configure: Rebuild.
3306         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3307         -Wdeprecated-copy-dtor, -Wredundant-move.
3308
3309 2019-05-29  Tom Tromey  <tromey@adacore.com>
3310
3311         * NEWS: Add entry.
3312         * infcmd.c (print_return_value_1): Handle finish_print
3313         option.
3314         (show_print_finish): New function.
3315         (_initialize_infcmd): Add "set/show print finish" commands.
3316         * valprint.c (user_print_options): Initialize new member.
3317         * valprint.h (struct value_print_options) <finish_print>: New
3318         member.
3319
3320 2019-05-28  Tom Tromey  <tromey@adacore.com>
3321
3322         * ada-lang.c (ada_remove_Xbn_suffix)
3323         (find_old_style_renaming_symbol)
3324         (parse_old_style_renaming): Remove.
3325         (ada_find_renaming_symbol): Don't call
3326         find_old_style_renaming_symbol.
3327         (ada_is_renaming_symbol): Rename from
3328         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3329         bool.  Now static.
3330         (ada_read_var_value): Update and simplify.
3331         * ada-exp.y (write_var_or_type): Remove old code.
3332
3333 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3334
3335         * event-top.c: Remove include comment.
3336         * inflow.c (class scoped_ignore_sigttou): Move from here...
3337         * inflow.h (class scoped_ignore_sigttou): ...to here.
3338         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3339         * top.c:  Remove include comment.
3340
3341 2019-05-27  Tom Tromey  <tom@tromey.com>
3342
3343         * NEWS: Fix typo.
3344
3345 2019-05-22  Tom Tromey  <tromey@adacore.com>
3346
3347         * target.c (target_follow_exec): Constify parameter.
3348         * target-delegates.c: Rebuild.
3349         * remote.c (remote_target::follow_exec): Constify parameter.
3350         * infrun.c (follow_exec): Constify parameter.
3351         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3352         (target_follow_exec): Likewise.
3353
3354 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3355
3356         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3357         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3358
3359 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3360
3361         * NEWS: Add debugredirect and testsuite sections.
3362
3363 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3364
3365         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3366         target descriptions using exclusively floating point register name
3367         aliases.
3368
3369 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3370
3371         PR gdb/18644:
3372         * f-lang.c (build_fortran_types): Handle the case where
3373         gdbarch_floatformat_for_type returns a nullptr.
3374
3375 2019-05-21  Tom de Vries  <tdevries@suse.de>
3376
3377         PR cli/24587
3378         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3379
3380 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3381
3382         PR gdb/18644:
3383         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3384         16-byte floats.
3385         * i386-tdep.c (i386_floatformat_for_type): Use
3386         floatformats_ia64_quad for the 16-byte floating point component
3387         within a fortran 32-byte complex number.
3388
3389 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3390
3391         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3392         delete default constructor.
3393         (find_partial_die): Update to return const struct.
3394         (partial_die_parent_scope): Move variable declaration into scope
3395         of its use and change its type to auto.
3396         (guess_partial_die_structure_name): Likewise.
3397         (partial_die_info::fixup): Likewise.
3398
3399 2019-05-17  Tom Tromey  <tromey@adacore.com>
3400
3401         * source.c (find_and_open_source): Remove cast.
3402
3403 2019-05-17  Tom Tromey  <tromey@adacore.com>
3404
3405         * annotate.c (annotate_source): Make "filename" const.
3406         * annotate.h (annotate_source): Use const.
3407
3408 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3409
3410         * disasm.c (set_disassembler_options): Send errors to stderr.
3411
3412 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3413
3414         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3415         (cli_interp_base::set_logging): Check debug_redirect.
3416         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3417         * cli/cli-logging.c (debug_redirect): Add static variable.
3418         (pop_output_files): Add default param.
3419         (handle_redirections): Print debug setting.
3420         (show_logging_command): Likewise.
3421         (_initialize_cli_logging): Add debugredirect command.
3422         * interps.c (current_interp_set_logging): Add debug_redirect
3423         parameter.
3424         * interps.h (set_logging): Add debug_redirect parameter.
3425         (current_interp_set_logging): Likewise.
3426         * mi/mi-common.h: Likewise.
3427         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3428
3429 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3430             Tom Tromey  <tromey@adacore.com>
3431
3432         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3433         directly.
3434         * cli/cli-interp.h (make_logging_output): Remove declaration.
3435         * cli/cli-logging.c (make_logging_output): Remove function.
3436         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3437         directly.
3438         * ui-file.c (tee_file::tee_file): Remove bools.
3439         (tee_file::~tee_file): Remove deletes.
3440         * ui-file.h (tee_file): Remove bools.
3441
3442 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3443
3444         * mi/mi-cmds.h (mi_cmd_complete): New function.
3445         * mi/mi-main.c (mi_cmd_complete): Likewise.
3446         * mi/mi-cmds.c: Define new MI command -complete.
3447         * NEWS: Mention new -complete command.
3448
3449 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3450
3451         * completer.h (complete): New function.
3452         * completer.c (complete): Likewise.
3453         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3454         function defined in completer.h.
3455
3456 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3457
3458         * MAINTAINERS (Write After Approval): Add myself.
3459
3460 2019-05-17  Tom de Vries  <tdevries@suse.de>
3461
3462         PR gdb/24094
3463         * dwarf2read.c (struct cu_partial_die_info): New struct.
3464         (find_partial_die): Return cu_partial_die_info.
3465         (partial_die_parent_scope, guess_partial_die_structure_name)
3466         (partial_die_info::fixup): Handle new return type of find_partial_die.
3467
3468 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3469
3470         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3471         "std::string", simplifying the algorithm.
3472
3473 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3474
3475         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3476         (stap_static_probe_ops::get_probes): Likewise.
3477
3478 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3479
3480         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3481         '-')" and "else if".
3482         (stap_parse_single_operand): Join checks for
3483         "gdbarch_stap_parse_special_token_p" and
3484         "gdbarch_stap_parse_special_token" in the same "if" statement.
3485         Invert check when verifying for operation on register
3486         displacement.
3487
3488 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3489
3490         * stap-probe.c (stap_get_opcode): Update comment.
3491         (stap_get_expected_argument_type): Likewise.
3492         (handle_stap_probe): Likewise.
3493
3494 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3495
3496         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3497         return type to 'bool'.  Adjust comment.  Use 'bool' when
3498         appropriate.
3499         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3500         * stap-probe.c (stap_parse_argument_1): Likewise.
3501         (stap_is_operator): Likewise.
3502         (stap_is_generic_prefix): Likewise.
3503         (stap_is_register_prefix): Likewise.
3504         (stap_is_register_indirection_prefix): Likewise.
3505         (stap_is_integer_prefix): Likewise.
3506         (stap_generic_check_suffix): Likewise.
3507         (stap_check_integer_suffix): Likewise.
3508         (stap_check_register_suffix): Likewise.
3509         (stap_check_register_indirection_suffix): Likewise.
3510         (stap_parse_register_operand): Likewise.
3511         (stap_parse_single_operand): Likewise.
3512         (stap_parse_argument_1): Likewise.
3513         (stap_probe::get_argument_count): Likewise.
3514         (stap_is_operator): Likewise.
3515
3516 2019-05-16  Tom Tromey  <tromey@adacore.com>
3517
3518         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3519         keyword to foreach.
3520
3521 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3522
3523         * linux-thread-db.c (try_thread_db_load_1): Change return type
3524         to bool.
3525         (try_thread_db_load): Likewise.
3526         (try_thread_db_load_from_pdir_1): Likewise.
3527         (try_thread_db_load_from_pdir): Likewise.
3528         (try_thread_db_load_from_sdir): Likewise.
3529         (try_thread_db_load_from_dir): Likewise.
3530         (thread_db_load_search): Likewise.
3531         (has_libpthread): Likewise.
3532         (thread_db_load): Likewise.
3533
3534 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3535
3536         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3537         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3538         NULL, and complain/return if that's the case.
3539
3540 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3541
3542         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3543         (advance, posn, abstract_read_memory): New functions.
3544         [struct mem_read_abstraction]: New struct.
3545         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3546
3547 2019-05-14  Tom Tromey  <tromey@adacore.com>
3548
3549         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3550         value is not lval_memory.
3551
3552 2019-05-14  Tom Tromey  <tromey@adacore.com>
3553
3554         * solib.c (info_sharedlibrary_command): Style the file name.
3555
3556 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3557
3558         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3559         (aarch64_vnv_type): Likewise.
3560         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3561         * common/tdesc.c: Likewise.
3562         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3563         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3564         * features/aarch64-fpu.xml: Add ieee half view.
3565         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3566         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3567         * gdbtypes.h (struct builtin_type): Likewise.
3568         (struct objfile_type): Likewise.
3569
3570 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3571
3572         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3573         typo.
3574         * location.h (string_to_event_location): Likewise.
3575
3576 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3577
3578         GDB 8.3 released.
3579
3580 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3581
3582         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3583         New variable declaration.
3584         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3585         New variable.
3586         (print_one_breakpoint): Use ui_out::test_flags and new global
3587         variable to compute use_fixed_output.
3588         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3589         Remove.
3590         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3591         (mi_multi_location_breakpoint_output_fixed): Remove.
3592         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3593         new variable.
3594         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3595         fix_multi_location_breakpoint_output flag if version >= 3.
3596         * ui-out.h (enum ui_out_flag)
3597         <fix_multi_location_breakpoint_output>: New enumerator.
3598
3599 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3600
3601         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3602
3603 2019-05-10  Tom Tromey  <tromey@adacore.com>
3604
3605         * ada-lang.c (catch_ada_completer): New function.
3606         (_initialize_ada_language): Use it.
3607
3608 2019-05-10  Tom Tromey  <tromey@adacore.com>
3609
3610         * thread.c (print_thread_info): Make "requested_threads" const.
3611         * gdbthread.h (print_thread_info): Make "requested_threads"
3612         const.
3613         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3614         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3615
3616 2019-05-08  Tom Tromey  <tom@tromey.com>
3617
3618         * gdbtypes.c (objfile_type_data): Change type.
3619         (objfile_type, _initialize_gdbtypes): Update.
3620
3621 2019-05-08  Tom Tromey  <tom@tromey.com>
3622
3623         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3624         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3625         (_initialize_dwarf2_frame): Update.
3626
3627 2019-05-08  Tom Tromey  <tom@tromey.com>
3628
3629         * objc-lang.c (objc_objfile_data): Change type.
3630         (find_methods): Update.
3631         (_initialize_objc_lang): Remove.
3632
3633 2019-05-08  Tom Tromey  <tom@tromey.com>
3634
3635         * stabsread.c (rs6000_builtin_type_data): Change type.
3636         (rs6000_builtin_type, _initialize_stabsread): Update.
3637
3638 2019-05-08  Tom Tromey  <tom@tromey.com>
3639
3640         * mips-tdep.c (mips_pdr_data): Remove.
3641         (_initialize_mips_tdep): Update.
3642
3643 2019-05-08  Tom Tromey  <tom@tromey.com>
3644
3645         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3646         (hppa_init_objfile_priv_data, read_unwind_info)
3647         (find_unwind_entry, _initialize_hppa_tdep): Update.
3648
3649 2019-05-08  Tom Tromey  <tom@tromey.com>
3650
3651         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3652         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3653         on obstack.
3654         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3655
3656 2019-05-08  Tom Tromey  <tom@tromey.com>
3657
3658         * mdebugread.c (basic_type_data): Change type.
3659         (basic_type, _initialize_mdebugread): Update.
3660
3661 2019-05-08  Tom Tromey  <tom@tromey.com>
3662
3663         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3664
3665 2019-05-08  Tom Tromey  <tom@tromey.com>
3666
3667         * nto-tdep.c (nto_inferior_data_reg): Change type.
3668         (nto_inferior_data): Update.
3669         (nto_inferior_data_cleanup, nto_new_inferior_data)
3670         (_initialize_nto_tdep): Remove.
3671         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3672
3673 2019-05-08  Tom Tromey  <tom@tromey.com>
3674
3675         * ada-lang.c (struct ada_inferior_data): Add initializers.
3676         (ada_inferior_data): Change type.
3677         (ada_inferior_data_cleanup): Remove.
3678         (get_ada_inferior_data, ada_inferior_exit)
3679         (struct ada_pspace_data): Add initializers, destructor.
3680         (ada_pspace_data_handle): Change type.
3681         (get_ada_pspace_data): Update.
3682         (ada_pspace_data_cleanup): Remove.
3683
3684 2019-05-08  Tom Tromey  <tom@tromey.com>
3685
3686         * coffread.c (struct coff_symfile_info): Add initializers.
3687         (coff_objfile_data_key): Move lower.  Change type.
3688         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3689         Update.
3690         (coff_free_info): Remove.
3691
3692 2019-05-08  Tom Tromey  <tom@tromey.com>
3693
3694         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3695         (fbsd_pspace_data_handle): Move lower.  Change type.
3696         (get_fbsd_pspace_data): Update.
3697         (fbsd_pspace_data_cleanup): Remove.
3698         (_initialize_fbsd_tdep): Update.
3699
3700 2019-05-08  Tom Tromey  <tom@tromey.com>
3701
3702         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3703         (get_ada_tasks_pspace_data): Update.
3704         (ada_tasks_pspace_data_cleanup): Remove.
3705         (_initialize_tasks): Update.
3706         (ada_tasks_inferior_data_handle): Change type.
3707         (get_ada_tasks_inferior_data): Update.
3708         (ada_tasks_inferior_data_cleanup): Remove.
3709         (struct ada_tasks_pspace_data): Add initializers.
3710
3711 2019-05-08  Tom Tromey  <tom@tromey.com>
3712
3713         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3714         * symfile-debug.c (debug_sym_get_probes): Change type.
3715         * stap-probe.c (handle_stap_probe):
3716         (stap_static_probe_ops::get_probes): Change type.
3717         * probe.h (class static_probe_ops) <get_probes>: Change type.
3718         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3719         (parse_probes_in_pspace): Update.
3720         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3721         Update.
3722         (any_static_probe_ops::get_probes): Change type.
3723         * elfread.c (elfread_data): New typedef.
3724         (probe_key): Change type.
3725         (elf_get_probes): Likewise.  Update.
3726         (probe_key_free): Remove.
3727         (_initialize_elfread): Update.
3728         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3729         Change type.
3730         (dtrace_process_dof_probe, dtrace_process_dof)
3731         (dtrace_static_probe_ops::get_probe): Change type.
3732
3733 2019-05-08  Tom Tromey  <tom@tromey.com>
3734
3735         * xcoffread.c (struct xcoff_symfile_info): Rename from
3736         coff_symfile_info.  Add initializers.
3737         (xcoff_objfile_data_key): Move lower.  Change type.
3738         (XCOFF_DATA): Rewrite.
3739         (xcoff_free_info): Remove.
3740         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3741         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3742         (xcoff_initial_scan): Update.
3743
3744 2019-05-08  Tom Tromey  <tom@tromey.com>
3745
3746         * solib-svr4.c (struct svr4_info): Add initializers and
3747         destructor.
3748         <probes_table>: Now an htab_up.
3749         (solib_svr4_pspace_data): Change type.
3750         (free_probes_table): Simplify.
3751         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3752         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3753         (probes_table_remove_objfile_probes, register_solib_event_probe)
3754         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3755         (_initialize_svr4_solib): Update.
3756
3757 2019-05-08  Tom Tromey  <tom@tromey.com>
3758
3759         * remote.c (remote_pspace_data): Change type.
3760         (remote_pspace_data_cleanup): Remove.
3761         (get_remote_exec_file, set_pspace_remote_exec_file)
3762         (_initialize_remote): Update.
3763
3764 2019-05-08  Tom Tromey  <tom@tromey.com>
3765
3766         * breakpoint.c (breakpoint_objfile_key): Change type.
3767         (get_breakpoint_objfile_data): Update.
3768         (free_breakpoint_objfile_data): Remove.
3769         (_initialize_breakpoint): Update.
3770
3771 2019-05-08  Tom Tromey  <tom@tromey.com>
3772
3773         * linux-tdep.c (struct linux_info): Add initializers.
3774         (linux_inferior_data): Move.  Change type.
3775         (invalidate_linux_cache_inf): Update.
3776         (linux_inferior_data_cleanup): Remove.
3777         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3778
3779 2019-05-08  Tom Tromey  <tom@tromey.com>
3780
3781         * auxv.c (auxv_inferior_data): Move.  Change type.
3782         (auxv_inferior_data_cleanup): Remove.
3783         (invalidate_auxv_cache_inf): Rewrite.
3784         (get_auxv_inferior_data, _initialize_auxv): Update.
3785
3786 2019-05-08  Tom Tromey  <tom@tromey.com>
3787
3788         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3789         (symfile_debug_objfile_data_key): Change type.
3790         (symfile_debug_installed, debug_qf_has_symbols)
3791         (debug_qf_find_last_source_symtab)
3792         (debug_qf_forget_cached_source_info)
3793         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3794         (debug_qf_print_stats, debug_qf_dump)
3795         (debug_qf_expand_symtabs_for_function)
3796         (debug_qf_expand_all_symtabs)
3797         (debug_qf_expand_symtabs_with_fullname)
3798         (debug_qf_map_matching_symbols)
3799         (debug_qf_expand_symtabs_matching)
3800         (debug_qf_find_pc_sect_compunit_symtab)
3801         (debug_qf_map_symbol_filenames)
3802         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3803         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3804         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3805         (debug_sym_read_linetable, debug_sym_relocate): Update.
3806         (symfile_debug_free_objfile): Remove.
3807         (install_symfile_debug_logging, _initialize_symfile_debug):
3808         Update.
3809
3810 2019-05-08  Tom Tromey  <tom@tromey.com>
3811
3812         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3813         allocate_on_obstack.
3814         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3815         (get_dwarf2_per_objfile): Update.
3816         (set_dwarf2_per_objfile): Remove.
3817         (dwarf2_has_info, dwarf2_get_section_info): Update.
3818         (dwarf2_free_objfile): Remove.
3819         (_initialize_dwarf2_read): Update.
3820
3821 2019-05-08  Tom Tromey  <tom@tromey.com>
3822
3823         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3824         initializers.
3825         <unsupported_script_warning_printed,
3826         script_not_found_warning_printed>: Now bool.
3827         (auto_load_pspace_data): Change type.
3828         (~auto_load_pspace_info): Rename from
3829         auto_load_pspace_data_cleanup.
3830         (get_auto_load_pspace_data, init_loaded_scripts_info)
3831         (clear_section_scripts, maybe_print_unsupported_script_warning)
3832         (maybe_print_script_not_found_warning, _initialize_auto_load):
3833         Update.
3834
3835 2019-05-08  Tom Tromey  <tom@tromey.com>
3836
3837         * objfiles.c (objfile_pspace_info): Add destructor and
3838         initializers.
3839         (objfiles_pspace_data): Change type.
3840         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3841         (get_objfile_pspace_data): Update.
3842         (objfiles_bfd_data): Change type.
3843         (get_objfile_bfd_data): Update.
3844         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3845
3846 2019-05-08  Tom Tromey  <tom@tromey.com>
3847
3848         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3849         Change type.
3850         (get_catch_syscall_inferior_data): Update.
3851         (catch_syscall_inferior_data_cleanup): Remove.
3852         (_initialize_break_catch_syscall): Update.
3853
3854 2019-05-08  Tom Tromey  <tom@tromey.com>
3855
3856         * inflow.c (struct terminal_info): Add destructor and
3857         initializers.
3858         (inflow_inferior_data): Change type.
3859         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3860         (get_inflow_inferior_data, inflow_inferior_exit)
3861         (swap_terminal_info, _initialize_inflow): Update.
3862
3863 2019-05-08  Tom Tromey  <tom@tromey.com>
3864
3865         * target-dcache.c (target_dcache_cleanup): Remove.
3866         (target_dcache_aspace_key): Change type.
3867         (target_dcache_init_p, target_dcache_invalidate)
3868         (target_dcache_get, target_dcache_get_or_init)
3869         (_initialize_target_dcache): Update.
3870         * dcache.h (struct dcache_deleter): New.
3871
3872 2019-05-08  Tom Tromey  <tom@tromey.com>
3873
3874         * symtab.c (struct symbol_cache): Add destructor and
3875         initializers.
3876         (symbol_cache_key): Move.  Change type.
3877         (make_symbol_cache, free_symbol_cache): Remove.
3878         (get_symbol_cache): Update.
3879         (symbol_cache_cleanup): Remove.
3880         (ALL_PSPACES, symbol_cache_flush)
3881         (maintenance_print_symbol_cache)
3882         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3883         Update.
3884
3885 2019-05-08  Tom Tromey  <tom@tromey.com>
3886
3887         * symtab.c (struct main_info): Add destructor and initializers.
3888         (main_progspace_key): Move.  Change type.
3889         (get_main_info): Update.
3890         (main_info_cleanup): Remove.
3891         (_initialize_symtab): Update.
3892
3893 2019-05-08  Tom Tromey  <tom@tromey.com>
3894
3895         * registry.h (DECLARE_REGISTRY): Define the _key class.
3896
3897 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3898
3899         * NEWS: Merge two 'New commands' sections.
3900
3901 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3902
3903         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3904         parameter and use Ada language definition instead.
3905         (ada_val_print_ptr): Remove unused language parameter.
3906         (ada_val_print_num): Remove language parameter and use Ada language
3907         definition instead.
3908         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3909         parameter.
3910         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3911         parameter and use Ada language definition instead.
3912         (ada_val_print_1): Update all ada_val_print_xxx calls.
3913         Remove language parameter.
3914         (ada_val_print): Update ada_val_print_1 call.
3915
3916 2019-05-08  Tom Tromey  <tromey@adacore.com>
3917
3918         * remote.c (remote_hw_watchpoint_limit)
3919         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3920         Now static.
3921
3922 2019-05-08  Tom Tromey  <tromey@adacore.com>
3923
3924         * maint.c (_initialize_maint_cmds): Move initialization code to
3925         remote.c.
3926         (watchdog, show_watchdog): Move to remote.c.
3927         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3928         "watchdog" static.
3929         (_initialize_remote): Move initialization code from maint.c.
3930         * defs.h (watchdog): Don't declare.
3931
3932 2019-05-08  Tom Tromey  <tromey@adacore.com>
3933
3934         * tui/tui-interp.c: Include main.h.
3935         * interps.c: Include main.h.
3936         * main.h (interpreter_p): Declare.
3937         * defs.h (interpreter_p): Don't declare.
3938
3939 2019-05-08  Tom Tromey  <tromey@adacore.com>
3940
3941         * dwarf2loc.c: Include dwarf2read.h.
3942         * defs.h (read_unsigned_leb128): Don't declare.
3943         * dwarf2read.h (read_unsigned_leb128): Declare.
3944
3945 2019-05-08  Tom Tromey  <tromey@adacore.com>
3946
3947         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3948         method.
3949
3950 2019-05-08  Tom Tromey  <tromey@adacore.com>
3951
3952         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3953         when no wrap column is set.
3954
3955 2019-05-08  Tom Tromey  <tromey@adacore.com>
3956
3957         * c-lang.c (c_get_string): Handle non-C-style arrays.
3958
3959 2019-05-08  Tom Tromey  <tromey@adacore.com>
3960
3961         * typeprint.c (print_offset_data::update): Print the bit offset,
3962         not the number of bits remaining.
3963
3964 2019-05-08  Tom Tromey  <tromey@adacore.com>
3965
3966         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3967         padding at end of comment.
3968
3969 2019-05-08  Tom Tromey  <tromey@adacore.com>
3970
3971         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3972         Compare main types.
3973
3974 2019-05-06  Tom Tromey  <tom@tromey.com>
3975
3976         * common/scoped_mmap.c: Include common-defs.h.
3977         * common/scoped_mmap.h: Don't include config.h.
3978
3979 2019-05-04  Tom Tromey  <tom@tromey.com>
3980
3981         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3982         (struct aarch64_call_info): Add initializers.
3983         <si>: Now a std::vector.
3984         (pass_on_stack, aarch64_push_dummy_call): Update.
3985
3986 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3987             Tom Tromey  <tom@tromey.com>
3988
3989         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3990         (ppc_threads): Now a std::vector.  Now static.
3991         (hwdebug_find_thread_points_by_tid)
3992         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3993         Update.
3994
3995 2019-05-04  Tom Tromey  <tom@tromey.com>
3996
3997         * arc-tdep.c (arc_tdesc_init): Return bool.
3998
3999 2019-05-04  Tom Tromey  <tom@tromey.com>
4000
4001         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4002         Use gdb_assert_not_reached.
4003
4004 2019-05-04  Tom Tromey  <tom@tromey.com>
4005
4006         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4007         "false".
4008
4009 2019-05-04  Tom Tromey  <tom@tromey.com>
4010
4011         * arc-tdep.c (arc_tdesc_init): Use bool.
4012
4013 2019-05-04  Tom Tromey  <tom@tromey.com>
4014
4015         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4016
4017 2019-05-04  Tom Tromey  <tom@tromey.com>
4018
4019         * cli/cli-cmds.c (valid_command_p): Return bool.
4020
4021 2019-05-04  Tom Tromey  <tom@tromey.com>
4022
4023         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4024         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4025
4026 2019-05-04  Raul Tambre  <raul@tambre.ee>
4027
4028         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4029         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4030         operator for comparison.
4031
4032 2019-05-04  Tom Tromey  <tom@tromey.com>
4033
4034         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4035         (lookup_partial_symbol, print_partial_symbols)
4036         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4037         (psymbol_compare): Update.
4038         (add_psymbol_to_bcache): Clear the entire psymbol.
4039         (maintenance_check_psymtabs): Update.
4040         * psympriv.h (struct partial_symbol): Don't derive from
4041         general_symbol_info.
4042         <obj_section, unrelocated_address, address,
4043         set_unrelocated_address>: Update.
4044         <ginfo>: New member.
4045         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4046         (debug_names::write_psymbols): Update.
4047
4048 2019-05-04  Tom de Vries  <tdevries@suse.de>
4049
4050         * contrib/cc-with-tweaks.sh: Support -n arg.
4051
4052 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4053
4054         * corelow.c (core_target::detach): Ensure frame cache and
4055         register caches are cleared.
4056         inferior.c (exit_inferior_1): Likewise.
4057
4058 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4059             Tom Tromey  <tom@tromey.com>
4060
4061         * dictionary.c (collate_pending_symbols_by_language): Remove
4062         "struct" from foreach.
4063         * symtab.c (lookup_global_symbol_from_objfile)
4064         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4065         foreach.
4066         * ser-tcp.c (net_open): Remove "struct" from foreach.
4067         * objfiles.c (objfile_relocate, objfile_rebase)
4068         (objfile_has_symbols): Remove "struct" from foreach.
4069         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4070         from foreach.
4071         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4072         foreach.
4073         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4074         "struct" from foreach.
4075         * ada-lang.c (create_excep_cond_exprs)
4076         (ada_exception_catchpoint_cond_string): Remove "struct" from
4077         foreach.
4078
4079 2019-05-03  Tom Tromey  <tromey@adacore.com>
4080
4081         * ada-exp.y (convert_char_literal): Check suffix of each
4082         enumerator.
4083
4084 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4085
4086         PR ada/21406:
4087         * ada-exp.y (yywrap): Don't define.
4088         * ada-lex.l (%option): Add noyywrap
4089         (yywrap): Remove.
4090
4091 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4092
4093         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4094         _WIN32_WINNT to the XP level, unless already defined to a higher
4095         level.
4096
4097         * unittests/parse-connection-spec-selftests.c:
4098         * ser-tcp.c:
4099         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4100         override.
4101
4102         * symfile.c (find_separate_debug_file): Remove colon from the
4103         drive spec of DOS/Windows file names of the target, so that the
4104         file name produced from DEBUGDIR and the target's directory will
4105         be valid on DOS/Windows systems.
4106
4107 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4108
4109         * rust-lang.c (val_print_struct): Handle printing structures
4110         containing strings.
4111
4112 2019-05-02  Tom Tromey  <tromey@adacore.com>
4113
4114         * valarith.c (_initialize_valarith): Remove.
4115
4116 2019-05-01  Tom Tromey  <tromey@adacore.com>
4117
4118         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4119         bitfields.
4120
4121 2019-05-01  Tom Tromey  <tromey@adacore.com>
4122
4123         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4124         for big-endian copies.
4125
4126 2019-04-30  Ali Tamur  <tamur@google.com>
4127         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4128         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4129         (read_3_bytes): New function.
4130
4131 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4132
4133         * windows-nat.c (main_thread_id): Delete.
4134         (handle_output_debug_string): Replace main_thread_id by
4135         current_event.dwThreadId.
4136         (fake_create_process): Likewise.
4137         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4138         Do not set main_thread_id.
4139         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4140         current_event.dwThreadId.
4141         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4142
4143 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4144
4145         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4146         Use current_event.dwThreadId instead of main_thread_id.
4147
4148 2019-04-30  Tom Tromey  <tromey@adacore.com>
4149
4150         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4151         (create_excep_cond_exprs): Iterate over program spaces.
4152         (ada_exception_catchpoint_cond_string): Examine all minimal
4153         symbols for exception types.
4154
4155 2019-04-30  Tom Tromey  <tromey@adacore.com>
4156
4157         PR c++/24470:
4158         * dwarf2read.c (process_structure_scope): Handle case where type
4159         has template parameters but no symbol was created.
4160
4161 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4162             Chris January  <chris.january@arm.com>
4163
4164         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4165         qualifier.
4166         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4167
4168 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4169
4170         * f-typeprint.c (f_print_type): Update rules for printing
4171         whitespace.
4172         (f_type_print_varspec_suffix): Likewise.
4173
4174 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4175             Chris January  <chris.january@arm.com>
4176
4177         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4178         function arguments.
4179
4180 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4181
4182         * f-lang.c (build_fortran_types): Change name of void type to
4183         lower case.
4184         * f-typeprint.c (f_type_print_base): Print the name of the void
4185         type, rather than a fixed string.
4186         * f-valprint.c (f_decorations): Use lower case void string.
4187
4188 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4189             Chris January  <chris.january@arm.com>
4190
4191         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4192         types for Fortran.
4193
4194 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4195             Chris January  <chris.january@arm.com>
4196             David Lecomber  <david.lecomber@arm.com>
4197
4198         * f-exp.y (BINOP_INTRINSIC): New token.
4199         (exp): New parser rule handling BINOP_INTRINSIC.
4200         (f77_keywords): Add new builtin procedures.
4201         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4202         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4203         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4204         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4205         (print_unop_subexp_f): New function.
4206         (print_binop_subexp_f): New function.
4207         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4208         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4209         (dump_subexp_body_f): Likewise.
4210         (operator_check_f): Likewise.
4211         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4212         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4213
4214 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4215
4216         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4217         UNOP_KIND.
4218         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4219         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4220         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4221         (operator_length_f): New fuction.
4222         (print_subexp_f): New function.
4223         (op_name_f): New function.
4224         (dump_subexp_body_f): New function.
4225         (operator_check_f): New function.
4226         (exp_descriptor_f): Replace standard expression handling functions
4227         with new functions.
4228         * gdb/fortran-operator.def: New file.
4229         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4230         * gdb/std-operator.def: Remove UNOP_KIND.
4231
4232 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4233
4234         * std-operator.def: Remove unbalanced, stray double quote
4235         character.
4236
4237 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4238             Chris January  <chris.january@arm.com>
4239             Daniel Everett  <daniel.everett@arm.com>
4240             Nick Forrington  <nick.forrington@arm.com>
4241             Richard Bunt  <richard.bunt@arm.com>
4242
4243         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4244         of depth when printing anonymous structs or unions.
4245         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4246         Don't print either the top-level value, or the children if the
4247         max-depth is exceeded.
4248         (ppscm_print_children): When printing the key of a map, allow one
4249         extra level of depth.
4250         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4251         print either the top-level value, or the children if the max-depth
4252         is exceeded.
4253         (print_children): When printing the key of a map, allow one extra
4254         level of depth.
4255         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4256         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4257         (user_print_options): Initialise max_depth field.
4258         (val_print_scalar_or_string_type_p): New function.
4259         (val_print): Check to see if the max depth has been reached.
4260         (val_print_check_max_depth): Define new function.
4261         (show_print_max_depth): New function.
4262         (_initialize_valprint): Add 'print max-depth' option.
4263         * valprint.h (struct value_print_options) <max_depth>: New field.
4264         (val_print_check_max_depth): Declare new function.
4265         * NEWS: Document new feature.
4266
4267 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4268
4269         * ada-lang.c (ada_language_defn): Initialise new field.
4270         * c-lang.c (c_is_string_type_p): New function.
4271         (c_language_defn): Initialise new field.
4272         (cplus_language_defn): Initialise new field.
4273         (asm_language_defn): Initialise new field.
4274         (minimal_language_defn): Initialise new field.
4275         * c-lang.h (c_is_string_type_p): Declare new function.
4276         * d-lang.c (d_language_defn): Initialise new field.
4277         * f-lang.c (f_is_string_type_p): New function.
4278         (f_language_defn): Initialise new field.
4279         * go-lang.c (go_is_string_type_p): New function.
4280         (go_language_defn): Initialise new field.
4281         * language.c (default_is_string_type_p): New function.
4282         (unknown_language_defn): Initialise new field.
4283         (auto_language_defn): Initialise new field.
4284         * language.h (struct language_defn) <la_is_string_type_p>: New
4285         member variable.
4286         (default_is_string_type_p): Declare new function.
4287         * m2-lang.c (m2_language_defn): Initialise new field.
4288         * objc-lang.c (objc_language_defn): Initialise new field.
4289         * opencl-lang.c (opencl_language_defn): Initialise new field.
4290         * p-lang.c (pascal_is_string_type_p): New function.
4291         (pascal_language_defn): Initialise new field.
4292         * rust-lang.c (rust_is_string_type_p): New function.
4293         (rust_language_defn): Initialise new field.
4294
4295 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4296
4297         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4298         New field.
4299         * ada-lang.c (ada_language_defn): Initialise new field.
4300         * c-lang.c (c_language_defn): Likewise.
4301         (cplus_language_defn): Likewise.
4302         (asm_language_defn): Likewise.
4303         (minimal_language_defn): Likewise.
4304         * d-lang.c (d_language_defn): Likewise.
4305         * f-lang.c (f_language_defn): Likewise.
4306         * go-lang.c (go_language_defn): Likewise.
4307         * language.c (unknown_language_defn): Likewise.
4308         (auto_language_defn): Likewise.
4309         * m2-lang.c (m2_language_defn): Likewise.
4310         * objc-lang.c (objc_language_defn): Likewise.
4311         * opencl-lang.c (opencl_language_defn): Likewise.
4312         * p-lang.c (pascal_language_defn): Likewise.
4313         * rust-lang.c (rust_language_defn): Likewise.
4314
4315 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4316
4317         * ada-lang.c (ada_is_character_type): Change return type to bool.
4318         (ada_is_string_type): Likewise.
4319         * ada-lang.h (ada_is_character_type): Update declaration
4320         (ada_is_string_type): Likewise.
4321
4322 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4323
4324         Support style in 'frame|thread apply'
4325
4326         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4327         * record.c (record_start, record_stop): Update callers of
4328         execute_command_to_string with false.
4329         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4330         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4331         methods.
4332         (class string_file): New constructor with term_out parameter.
4333         Override methods term_out and can_emit_style_escape.  New member
4334         term_out.
4335         (class stdio_file): Override can_emit_style_escape.
4336         (class tee_file): Override term_out and can_emit_style_escape.
4337         * utils.h (can_emit_style_escape): Remove.
4338         * utils.c (can_emit_style_escape): Likewise.
4339         Update all callers of can_emit_style_escape (SOMESTREAM) to
4340         SOMESTREAM->can_emit_style_escape.
4341         * source-cache.c (source_cache::get_source_lines): Likewise.
4342         * stack.c (frame_apply_command_count): Call execute_command_to_string
4343         passing the term_out characteristic of the current gdb_stdout.
4344         * thread.c (thr_try_catch_cmd): Likewise.
4345         * top.c (execute_command_to_string): pass term_out parameter
4346         to construct the string_file for the command output.
4347         * ui-file.c (term_cli_styling): New function (most code moved
4348         from utils.c can_emit_style_escape).
4349         (string_file::string_file, string_file::can_emit_style_escape,
4350         stdio_file::can_emit_style_escape, tee_file::term_out,
4351         tee_file::can_emit_style_escape): New functions.
4352
4353 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4354
4355         * NEWS: Mention the new set|show may-call-functions.
4356         * infcall.c (may_call_functions_p): New variable.
4357         (show_may_call_functions_p): New function.
4358         (call_function_by_hand_dummy): Throws an error if not
4359         may-call-functions.
4360         (_initialize_infcall): Call add_setshow_boolean_cmd for
4361         may-call-functions.
4362
4363 2019-04-25  Keith Seitz  <keiths@redhat.com>
4364
4365         PR c++/24367
4366         * cp-support.c (inspect_type): Don't attempt substitutions
4367         of symbol with the same name.
4368
4369 2019-04-25  Tom Tromey  <tromey@adacore.com>
4370
4371         PR gdb/24475:
4372         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4373         static.
4374
4375 2019-04-25  Tom Tromey  <tromey@adacore.com>
4376
4377         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4378         rvalue reference.
4379         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4380         (gdb_xml_parser::parse): Use std::move.
4381         * python/python-internal.h (gdbpy_convert_exception): Take a const
4382         reference.
4383         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4384         std::move.
4385         * python/py-utils.c (gdbpy_convert_exception): Take a const
4386         reference.
4387         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4388         Use std::move.
4389         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4390         Use std::move.
4391         * mi/mi-main.c (mi_print_exception): Take a const reference.
4392         * main.c (handle_command_errors): Take a const reference.
4393         * linespec.c (parse_linespec): Use std::move.
4394         * infcall.c (run_inferior_call): Use std::move.
4395         (call_function_by_hand_dummy): Use std::move.
4396         * exec.c (try_open_exec_file): Use std::move.
4397         * exceptions.h (exception_print, exception_fprintf)
4398         (exception_print_same): Update.
4399         * exceptions.c (print_exception, exception_print)
4400         (exception_fprintf, exception_print_same): Change parameters to
4401         const reference.
4402         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4403         * common/new-op.c: Use std::move.
4404         * common/common-exceptions.h (struct gdb_exception): Add move
4405         constructor.
4406         (struct gdb_exception_error, struct gdb_exception_quit, struct
4407         gdb_quit_bad_alloc): Change constructor to move constructor.
4408         (throw_exception): Change parameter to rvalue reference.
4409         * common/common-exceptions.c (throw_exception): Take rvalue
4410         reference.
4411         * cli/cli-interp.c (safe_execute_command): Use std::move.
4412         * breakpoint.c (insert_bp_location, location_to_sals): Use
4413         std::move.
4414
4415 2019-04-25  Tom Tromey  <tromey@adacore.com>
4416
4417         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4418         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4419         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4420         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4421         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4422         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4423         guile/scm-value.c: Use unpack.
4424         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4425         gdbscm_gdb_exception.
4426         (gdbscm_throw_gdb_exception): Likewise.
4427         (struct gdbscm_gdb_exception): New.
4428         (unpack): New function.
4429         (gdbscm_wrap): Use unpack.
4430
4431 2019-04-25  Tom Tromey  <tromey@adacore.com>
4432
4433         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4434         (gdb_rl_callback_handler): Use std::move.
4435         * common/common-exceptions.h (struct gdb_exception): Add move
4436         assignment operator.
4437         (throw_exception_sjlj): Change "exception" to const reference.
4438         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4439         (throw_exception_sjlj): Change "exception" to const reference.
4440
4441 2019-04-25  Tom Tromey  <tromey@adacore.com>
4442
4443         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4444         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4445         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4446         Update.
4447         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4448         Update.
4449         * mi/mi-interp.c (mi_interp::exec): Update.
4450         * linespec.c (parse_linespec): Update.
4451         * infcall.c (run_inferior_call): Update.
4452         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4453         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4454         (gdbscm_lookup_global_symbol): Update.
4455         * guile/scm-param.c (gdbscm_parameter_value): Update.
4456         * guile/scm-frame.c (gdbscm_frame_read_register)
4457         (gdbscm_frame_read_var): Update.
4458         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4459         * exec.c (try_open_exec_file): Update.
4460         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4461         (gdb_rl_callback_handler): Update.
4462         * common/common-exceptions.h (exception_none): Don't declare.
4463         * common/common-exceptions.c (exception_none): Don't define.
4464         (struct catcher) <exception>: Update.
4465         * cli/cli-interp.c (safe_execute_command): Update.
4466         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4467
4468 2019-04-25  Ali Tamur  <tamur@google.com>
4469
4470         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4471         (read_attribute_value): Likewise.
4472         (dwarf2_read_addr_index): Update comment.
4473         (read_str_index): Add DW_FORM_strx.
4474         (dwarf2_string_attr): Likewise.
4475         (dwarf2_const_value_attr): Likewise.
4476         (dump_die_shallow): Likewise.
4477         (dwarf2_fetch_constant_bytes): Likewise.
4478         (skip_form_bytes): Likewise.
4479         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4480
4481 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4482
4483         PR corefiles/11608
4484         PR corefiles/18187
4485         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4486         OFFSET.  Verify if current mapping contains an ELF header.
4487         (linux_find_memory_regions_full): Adjust call to
4488         dump_mapping_p.
4489
4490 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4491             Kang Li <kanglictf@gmail.com>
4492
4493         PR gdb/21600
4494
4495         * dwarf2-frame.c (read_initial_length): Be consistent about using
4496         unsigned representation of length.
4497         (decode_frame_entry_1): Likewise.  Check for wraparound of
4498         end pointer as well as buffer overflow.
4499
4500 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4501
4502         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4503         "vq".
4504
4505 2019-04-24  Tom Tromey  <tromey@adacore.com>
4506
4507         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4508
4509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4510
4511         * s12z-tdep.c (s12z_unwind_pc): Delete.
4512         (s12z_unwind_sp): Delete.
4513         (s12z_gdbarch_init): Don't register deleted functions with
4514         gdbarch.
4515
4516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4517
4518         * rl78-tdep.c (rl78_unwind_sp): Delete.
4519         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4520
4521 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4524         (xstormy16_unwind_pc): Delete.
4525         (xstormy16_dummy_id): Delete.
4526         (xstormy16_gdbarch_init): Don't register deleted functions with
4527         gdbarch.
4528
4529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4530
4531         * vax-tdep.c (vax_unwind_pc): Delete.
4532         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4533
4534 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4535
4536         * v850-tdep.c (v850_unwind_sp): Delete.
4537         (v850_unwind_pc): Delete.
4538         (v850_dummy_id): Delete.
4539         (v850_gdbarch_init): Don't register deleted functions with
4540         gdbarch.
4541
4542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4543
4544         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4545         (tilegx_unwind_pc): Delete.
4546         (tilegx_unwind_dummy_id): Delete.
4547         (tilegx_gdbarch_init): Don't register deleted functions with
4548         gdbarch.
4549
4550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4551
4552         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4553         (tic6x_dummy_id): Delete.
4554         (tic6x_gdbarch_init): Don't register deleted functions with
4555         gdbarch.
4556
4557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4558
4559         * sparc-tdep.c (sparc_unwind_pc): Delete.
4560         (sparc32_gdbarch_init): Don't register deleted function with
4561         gdbarch.
4562
4563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4564
4565         * sh-tdep.c (sh_unwind_sp): Delete.
4566         (sh_unwind_pc): Delete.
4567         (sh_dummy_id): Delete.
4568         (sh_gdbarch_init): Don't register deleted functions with
4569         gdbarch.
4570
4571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4572
4573         * score-tdep.c (score_unwind_sp): Delete.
4574         (score_unwind_pc): Delete.
4575         (score_dummy_id): Delete.
4576         (score_gdbarch_init): Don't register deleted functions with
4577         gdbarch.
4578
4579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4580
4581         * rx-tdep.c (rx_unwind_pc): Delete.
4582         (rx_unwind_sp): Delete.
4583         (rx_dummy_id): Delete.
4584         (rx_gdbarch_init): Don't register deleted functions with
4585         gdbarch.  Update comment.
4586
4587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4588
4589         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4590         (rs6000_dummy_id): Delete.
4591         (rs6000_gdbarch_init): Don't register deleted functions with
4592         gdbarch.
4593
4594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4595
4596         * or1k-tdep.c (or1k_dummy_id): Delete.
4597         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4598
4599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4600
4601         * nios2-tdep.c (nios2_dummy_id): Delete.
4602         (nios2_unwind_sp): Delete.
4603         (nios2_gdbarch_init): Don't register deleted functions with
4604         gdbarch.
4605
4606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4607
4608         * nds32-tdep.c (nds32_dummy_id): Delete.
4609         (nds32_unwind_pc): Delete.
4610         (nds32_unwind_sp): Delete.
4611         (nds32_gdbarch_init): Don't register deleted functions with
4612         gdbarch.
4613
4614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4615
4616         * msp430-tdep.c (msp430_unwind_pc): Delete.
4617         (msp430_unwind_sp): Delete.
4618         (msp430_dummy_id): Delete.
4619         (msp430_gdbarch_init): Don't register deleted functions with
4620         gdbarch.
4621
4622 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4623
4624         * moxie-tdep.c (moxie_unwind_sp): Delete.
4625         (moxie_unwind_pc): Delete.
4626         (moxie_dummy_id): Delete.
4627         (moxie_gdbarch_init): Don't register deleted functions with
4628         gdbarch.
4629
4630 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4631
4632         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4633         (mn10300_unwind_pc): Delete.
4634         (mn10300_unwind_sp): Delete.
4635         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4636         mn10300_unwind_sp.
4637         (mn10300_frame_unwind_init): Don't register deleted functions with
4638         gdbarch.
4639
4640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * mep-tdep.c (mep_unwind_pc): Delete.
4643         (mep_unwind_sp): Delete.
4644         (mep_dummy_id): Delete.
4645         (mep_gdbarch_init): Don't register deleted functions with
4646         gdbarch.
4647
4648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4649
4650         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4651         (m68hc11_unwind_sp): Delete.
4652         (m68hc11_gdbarch_init): Don't register deleted functions with
4653         gdbarch.
4654
4655 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4656
4657         * m32r-tdep.c (m32r_unwind_sp): Delete.
4658         (m32r_unwind_pc): Delete.
4659         (m32r_dummy_id): Delete.
4660         (m32r_gdbarch_init): Don't register deleted functions with
4661         gdbarch.
4662
4663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4664
4665         * m32c-tdep.c (m32c_unwind_pc): Delete.
4666         (m32c_unwind_sp): Delete.
4667         (m32c_dummy_id): Delete.
4668         (m32c_gdbarch_init): Don't register deleted functions with
4669         gdbarch.
4670
4671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4672
4673         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4674         (lm32_unwind_pc): Delete.
4675         (lm32_dummy_id): Delete.
4676         (lm32_gdbarch_init): Don't register deleted functions with
4677         gdbarch.
4678
4679 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4680
4681         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4682         (iq2000_unwind_pc): Delete.
4683         (iq2000_dummy_id): Delete.
4684         (iq2000_gdbarch_init): Don't register deleted functions with
4685         gdbarch.
4686
4687 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4688
4689         * nds32-tdep.c (nds32_type_align): Delete.
4690         (nds32_push_dummy_call): Use type_align instead.
4691
4692 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4693
4694         * arm-tdep.c (arm_type_align): Only handle vector override case.
4695         (arm_push_dummy_call): Use type_align.
4696         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4697
4698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4699
4700         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4701         case.
4702         (pass_on_stack): Use type_align.
4703         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4704         function.
4705
4706 2019-04-23  Tom Tromey  <tromey@adacore.com>
4707
4708         * dwarf2read.c (line_header::file_name_at): Remove unused
4709         overload.
4710
4711 2019-04-23  Tom de Vries  <tdevries@suse.de>
4712
4713         PR gdb/24438
4714         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4715         invocation.
4716
4717
4718 2019-03-27  Ali Tamur  <tamur@google.com>
4719
4720         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4721         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4722         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4723         (dwarf_expr_context::get_addr_index): Likewise
4724         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4725         (symbol_needs_eval_context::get_addr_index): Likewise
4726         (disassemble_dwarf_expression): Add DW_OP_addrx
4727         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4728         (read_cutu_die_from_dwo): Update comment
4729         (skip_one_die): Add DW_FORM_addrx
4730         (read_attribute_value): Likewise
4731         (var_decode_location): Add DW_OP_addrx
4732         (dwarf2_const_value_attr): Add DW_FORM_addrx
4733         (dump_die_shallow): Likewise
4734         (dwarf2_fetch_constant_bytes): Likewise
4735         (decode_locdesc): Add DW_OP_addrx
4736         (skip_form_bytes): Add DW_FORM_addrx
4737
4738 2019-04-22  Ali Tamur  <tamur@google.com>
4739
4740         * MAINTAINERS (Write After Approval): Add self.
4741
4742 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4743
4744         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4745         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4746         (open_symbol_file_object): Likewise.
4747         (svr4_default_sos): Add info parameter.
4748         (svr4_read_so_list): Likewise.
4749         (svr4_current_sos_direct): Adjust functions calls to pass down
4750         info.
4751         (svr4_current_sos_1): Add info parameter.
4752         (svr4_current_sos): Call get_svr4_info, pass info down to
4753         svr4_current_sos_1.
4754         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4755         get_svr4_info.
4756         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4757         get_svr4_info.
4758         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4759         to get_svr4_info.
4760         (probes_table_remove_objfile_probes): Likewise.
4761         (register_solib_event_probe): Add info parameter.
4762         (solist_update_incremental): Pass info parameter down to
4763         svr4_read_so_list.
4764         (disable_probes_interface): Add info parameter.
4765         (svr4_handle_solib_event): Pass current_program_space to
4766         get_svr4_info.  Adjust disable_probes_interface cleanup.
4767         (svr4_create_probe_breakpoints): Add info parameter, pass it
4768         down to register_solib_event_probe.
4769         (svr4_create_solib_event_breakpoints): Add info parameter,
4770         pass it down to svr4_create_probe_breakpoints.
4771         (enable_break): Pass info down to
4772         svr4_create_solib_event_breakpoints.
4773         (svr4_solib_create_inferior_hook): Pass current_program_space to
4774         get_svr4_info.
4775         (svr4_clear_solib): Likewise.
4776
4777 2019-04-22  Pedro Alves  <palves@redhat.com>
4778
4779         * solib-svr4.c (svr4_free_objfile_observer): New.
4780         (probe_and_action::objfile): New field.
4781         (probes_table_htab_remove_objfile_probes)
4782         (probes_table_remove_objfile_probes): New functions.
4783         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4784         in the new probe_and_action.  Don't store the probe in 'lookup'.
4785         (svr4_create_probe_breakpoints): Pass objfile to
4786         register_solib_event_probe.
4787         (_initialize_svr4_solib): Register a free_objfile observer.
4788
4789 2019-04-19  Tom Tromey  <tom@tromey.com>
4790
4791         * common/queue.h: Remove.
4792
4793 2019-04-19  Tom Tromey  <tom@tromey.com>
4794
4795         * event-loop.c: Don't include "common/queue.h".
4796
4797 2019-04-19  Tom Tromey  <tom@tromey.com>
4798
4799         * remote.c (remote_target): Use delete.
4800         * remote-notif.h: Include <list>, not "common/queue.h".
4801         (notif_client_p): Remove typedef.
4802         (remote_notif_state): Add constructor, destructor, initializer.
4803         <notif_queue>: Now a std::list.
4804         (remote_notif_state_xfree): Don't declare.
4805         * remote-notif.c (remote_notif_process, handle_notification)
4806         (remote_notif_state_allocate): Update.
4807         (~remote_notif_state): Rename from remote_notif_state_xfree.
4808
4809 2019-04-19  Tom Tromey  <tom@tromey.com>
4810
4811         * symfile.c (reread_symbols): Update.
4812         * objfiles.c (objfile_register_static_link)
4813         (objfile_lookup_static_link): Update
4814         (~objfile) Don't delete static_links.
4815         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4816
4817 2019-04-19  Tom Tromey  <tom@tromey.com>
4818
4819         * type-stack.h (struct type_stack) <insert>: Constify string.
4820         * type-stack.c (type_stack::insert): Constify string.
4821         * gdbtypes.h (lookup_template_type): Update.
4822         (address_space_name_to_int): Update.
4823         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4824         const.
4825         (lookup_template_type): Make name const.
4826         * c-exp.y: Update rules.
4827         (lex_one_token, classify_name, classify_inner_name)
4828         (c_print_token): Update.
4829         * p-exp.y: Update rules.
4830         (yylex): Update.
4831         * f-exp.y: Update rules.
4832         (yylex): Update.
4833         * d-exp.y: Update rules.
4834         (lex_one_token, classify_name, classify_inner_name): Update.
4835         * parse.c (write_dollar_variable, copy_name): Return std::string.
4836         * parser-defs.h (copy_name): Change return type.
4837         * m2-exp.y: Update rules.
4838         (yylex): Update.
4839         * go-exp.y (lex_one_token): Update.
4840         Update rules.
4841         (classify_unsafe_function, classify_packaged_name)
4842         (classify_name, yylex): Update.
4843
4844 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4845
4846         * configure.ac: add --enable-source-highlight switch.
4847         * configure: Regenerate.
4848         * top.c (print_gdb_version): plumb --enable-source-highlight
4849         status to "show configuration".
4850
4851 2019-04-19  Tom Tromey  <tromey@adacore.com>
4852
4853         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4854         Check ADA_TYPE_P.
4855         (empty_record, ada_template_to_fixed_record_type_1)
4856         (template_to_static_fixed_type)
4857         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4858         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4859         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4860         macros.
4861
4862 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4863
4864         PR symtab/24423:
4865         * source.c (print_source_lines_base): Advance "iter" when a
4866         control character is seen.
4867
4868 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4869
4870         * inferior.h (struct infcall_suspend_state_deleter):
4871         Catch exception in destructor to avoid crash.
4872
4873 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4874
4875         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4876         close to the add_com "shell".
4877
4878 2019-04-18  Tom Tromey  <tromey@adacore.com>
4879
4880         * process-stratum-target.h (class process_stratum_target)
4881         <stratum>: Add "final".
4882
4883 2019-04-17  Tom Tromey  <tromey@adacore.com>
4884
4885         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4886         against nullptr before use.
4887
4888 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4889
4890         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4891
4892 2019-04-17  Jim Wilson  <jimw@sifive.com>
4893             Andrew Burgess  <andrew.burgess@embecosm.com>
4894
4895         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4896         code read might fail, assume 4-byte breakpoint in that case.
4897
4898 2019-04-15  Leszek Swirski  <leszeks@google.com>
4899
4900         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4901         rather than a hand-rolled POD check when checking for forced MEMORY
4902         classification.
4903
4904 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4905
4906         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4907         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4908         function.
4909         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4910         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4911         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4912         declaration.
4913
4914 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4915
4916         * aarch64-linux-nat.c
4917         (aarch64_linux_nat_target::thread_architecture): Add override.
4918         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4919         each VQ.
4920
4921 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4922
4923         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4924
4925 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4926
4927         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4928         target types of size 96-bits, add some additional comments, and
4929         check that the builtin type we found was the correct size.
4930
4931 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4932
4933         * utils.c (prompt_for_continue): Don't restore the styling at the
4934         end, as applied_style has the wrong value.  This fixes styling in
4935         long lists of file names that are interrupted by the "Continue?"
4936         prompt.
4937
4938 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4939
4940         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4941         * c-lang.c (c_language_defn): Likewise.
4942         (cplus_language_defn): Likewise.
4943         (asm_language_defn): Likewise.
4944         (minimal_language_defn): Likewise.
4945         * d-lang.c (d_language_defn): Likewise.
4946         * f-lang.c (f_language_defn): Likewise.
4947         * go-lang.c (go_language_defn): Likewise.
4948         * language.c (unknown_language_defn): Likewise.
4949         (auto_language_defn): Likewise.
4950         * language.h (struct language_defn): Remove la_magic field.
4951         (LANG_MAGIC): Delete.
4952         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4953         * objc-lang.c (objc_language_defn): Likewise.
4954         * opencl-lang.c (opencl_language_defn): Likewise.
4955         * p-lang.c (pascal_language_defn): Likewise.
4956         * rust-lang.c (rust_language_defn): Likewise.
4957
4958 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4959
4960         * riscv-tdep.c (riscv_type_align): New function.
4961         (riscv_type_alignment): Delete.
4962         (riscv_arg_location): Use 'type_align'.
4963         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4964
4965 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4966
4967         * gdbtypes.c (type_align): A struct with no non-static fields also
4968         has alignment of 1.
4969
4970 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4971
4972         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4973         component to 0.
4974         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4975         member.
4976         (riscv_struct_info::analyse): New implementation using new
4977         analyse_inner member function.
4978         (riscv_struct_info::field_offset): New member function.
4979         (riscv_struct_info::m_offsets): New member variable.
4980         (riscv_struct_info::analyse_inner): New private member function,
4981         takes the old implementation of riscv_struct_info::analyse but
4982         extended to track field offsets.
4983         (riscv_call_arg_struct): Update the struct folding special cases
4984         to handle cases where empty C++ structs, which are non-zero
4985         length, are found.
4986         (riscv_arg_location): Initialise the length of each location, a
4987         non-zero length now indicates the location is in use.
4988         (riscv_push_dummy_call): Allow for the first location having a
4989         non-zero offset when setting up arguments.
4990         (riscv_return_value): Likewise, but for return values.
4991
4992 2019-04-11  Tom Tromey  <tromey@adacore.com>
4993
4994         * utils.c (internal_vproblem): Make "msg" const.
4995
4996 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4997
4998         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4999         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5000         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5001         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5002
5003 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5004
5005         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5006         function.
5007         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5008         of amd64_collect_native_gregset.
5009         (amd64_linux_nat_target::store_registers): Likewise.
5010
5011 2019-04-10  Tom Tromey  <tom@tromey.com>
5012
5013         * symtab.c (lookup_global_symbol_from_objfile)
5014         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5015         * objfiles.h (class separate_debug_iterator): New.
5016         (class separate_debug_range): New.
5017         (struct objfile) <separate_debug_objfiles>: New method.
5018         (objfile_separate_debug_iterate): Don't declare.
5019         * objfiles.c (separate_debug_iterator::operator++): Rename from
5020         objfile_separate_debug_iterate.
5021         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5022         iterator.
5023         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5024         iterator.
5025
5026 2019-04-10  Tom Tromey  <tom@tromey.com>
5027
5028         * symfile.c (reread_symbols): Remove old comment.
5029         * objfiles.c (free_all_objfiles): Fix a typo.
5030
5031 2019-04-10  Tom Tromey  <tom@tromey.com>
5032
5033         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5034         * minsyms.c (lookup_minimal_symbol): Use foreach.
5035         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5036         (lookup_minimal_symbol_solib_trampoline): Likewise.
5037         * symfile.c (reread_symbols): Use foreach.
5038
5039 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5040             Tom Tromey  <tromey@adacore.com>
5041
5042         PR rust/24414:
5043         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5044         (rust_lex_int_test): Change "value" to be LONGEST.
5045         (rust_lex_tests): Add test for long integer literal.
5046
5047 2019-04-09  Tom Tromey  <tromey@adacore.com>
5048
5049         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5050         to bool.
5051         (extended_remote_target::attach): Update.
5052         (remote_target::remote_notice_new_inferior): Update.
5053         (remote_target::add_current_inferior_and_thread): Update.
5054         * inferior.c (exit_inferior_1): Use "false".
5055         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5056
5057 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5058
5059         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5060         the "start" command.
5061
5062 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5063
5064         * python/py-inferior.c (infpy_thread_from_thread_handle):
5065         Adjust comments to reflect renaming of thread_from_thread_handle
5066         to thread_from_handle.  Adjust keywords.  Fix type error message.
5067         (inferior_object_methods): Add thread_from_handle.  Retain
5068         thread_from_thread_handle, but mark it as deprecated.
5069
5070 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5071
5072         * gdbthread.h (find_thread_by_handle): Revise declaration.
5073         * thread.c (find_thread_by_handle): Likewise.  Adjust
5074         implementation too.
5075         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5076         support for buffer objects as handles.
5077
5078 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5079
5080         * python/py-infthread.c (thpy_thread_handle): New function.
5081         (thread_object_methods): Register thpy_thread_handle.
5082
5083 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5084
5085         * gdbthread.h (thread_to_thread_handle): Declare.
5086         * thread.c (gdbtypes.h): Include.
5087         (thread_to_thread_handle): New function.
5088
5089         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5090         (target_thread_info_to_thread_handle): Declare.
5091         * target.c (target_thread_info_to_thread_handle): New function.
5092         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5093         * target-delegates.c: Regenerate.
5094
5095         * linux-thread-db.c (class thread_db_target): Add method
5096         thread_info_to_thread_handle.
5097         (thread_db_target::thread_info_to_thread_handle): Define.
5098         * remote.c (class remote_target): Add new method
5099         thread_info_to_thread_handle.
5100         (remote_target::thread_info_to_thread_handle): Define.
5101
5102 2019-04-08  Pedro Alves  <palves@redhat.com>
5103
5104         * common/common-exceptions.c (throw_exception): Don't create
5105         named object to throw; throw directly.
5106         (throw_it): Likewise.  Don't initialize gdb_exception::message
5107         here, with new; pass FMT and AP to the ctor instead.
5108         * common/common-exceptions.h: Include <string>.
5109         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5110         const char *, va_list)): New ctor.  Use std::make_shared.
5111         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5112         errors)): Delete.
5113         (gdb_exception_error::gdb_exception_error(enum errors, const char
5114         *, va_list)): New.
5115         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5116         Add assertion.
5117         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5118         errors)): Delete.
5119         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5120         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5121         Add assertion.
5122
5123 2019-04-08  Tom Tromey  <tom@tromey.com>
5124
5125         * valops.c (value_rtti_indirect_type): Replace throw_exception
5126         with throw.
5127         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5128         with throw.
5129         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5130         throw.
5131         * target.c (target_translate_tls_address): Replace throw_exception
5132         with throw.
5133         * stack.c (frame_apply_command_count): Replace throw_exception
5134         with throw.
5135         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5136         throw.
5137         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5138         with throw.
5139         * rs6000-tdep.c (rs6000_frame_cache)
5140         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5141         * remote.c: Replace throw_exception with throw.
5142         * record-full.c (record_full_message, record_full_wait_1)
5143         (record_full_restore): Replace throw_exception with throw.
5144         * record-btrace.c:
5145         (get_thread_current_frame_id, record_btrace_start_replaying)
5146         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5147         (cmd_record_btrace_start): Replace throw_exception with throw.
5148         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5149         throw.
5150         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5151         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5152         * linespec.c:
5153         (find_linespec_symbols): Replace throw_exception with throw.
5154         * infrun.c (displaced_step_prepare, resume): Replace
5155         throw_exception with throw.
5156         * infcmd.c (post_create_inferior): Replace throw_exception with
5157         throw.
5158         * inf-loop.c (inferior_event_handler): Replace throw_exception
5159         with throw.
5160         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5161         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5162         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5163         (get_prev_frame_always, get_frame_pc_if_available)
5164         (get_frame_address_in_block_if_available, get_frame_language):
5165         Replace throw_exception with throw.
5166         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5167         throw_exception with throw.
5168         * eval.c (fetch_subexp_value, evaluate_var_value)
5169         (evaluate_funcall, evaluate_subexp_standard): Replace
5170         throw_exception with throw.
5171         * dwarf2loc.c (call_site_find_chain)
5172         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5173         Replace throw_exception with throw.
5174         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5175         with throw.
5176         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5177         throw.
5178         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5179         * completer.c (complete_line_internal): Replace throw_exception
5180         with throw.
5181         * compile/compile-object-run.c (compile_object_run): Replace
5182         throw_exception with throw.
5183         * cli/cli-script.c (process_next_line): Replace throw_exception
5184         with throw.
5185         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5186         (btrace_enable, btrace_maint_update_pt_packets): Replace
5187         throw_exception with throw.
5188         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5189         throw_exception with throw.
5190         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5191         throw_exception with throw.
5192         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5193         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5194         * aarch64-tdep.c (aarch64_make_prologue_cache)
5195         (aarch64_make_stub_cache): Replace throw_exception with throw.
5196
5197 2019-04-08  Tom Tromey  <tom@tromey.com>
5198
5199         * common/common-exceptions.c (throw_exception): Rename from
5200         throw_exception_cxx.  Remove old copy.  Make argument const.
5201         (throw_it): Create and throw exception objects directly.
5202         * common/common-exceptions.h (throw_exception): Make argument
5203         const.
5204         (struct gdb_exception_error): Add constructor.
5205         (struct gdb_exception_quit): Add constructor.
5206
5207 2019-04-08  Tom Tromey  <tom@tromey.com>
5208
5209         * common/common-exceptions.h (exception_rethrow): Don't declare.
5210         (TRY_SJLJ): Update comment.
5211         (TRY, CATCH, END_CATCH): Remove.
5212         * common/common-exceptions.c (exception_rethrow): Remove.
5213
5214 2019-04-08  Tom Tromey  <tom@tromey.com>
5215
5216         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5217         Remove.
5218         (gdb_exception_error): Rename from
5219         gdb_exception_RETURN_MASK_ERROR.
5220         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5221         (gdb_quit_bad_alloc): Update.
5222         * aarch64-tdep.c: Update.
5223         * ada-lang.c: Update.
5224         * ada-typeprint.c: Update.
5225         * ada-valprint.c: Update.
5226         * amd64-tdep.c: Update.
5227         * arch-utils.c: Update.
5228         * break-catch-throw.c: Update.
5229         * breakpoint.c: Update.
5230         * btrace.c: Update.
5231         * c-varobj.c: Update.
5232         * cli/cli-cmds.c: Update.
5233         * cli/cli-interp.c: Update.
5234         * cli/cli-script.c: Update.
5235         * common/common-exceptions.c: Update.
5236         * common/new-op.c: Update.
5237         * common/selftest.c: Update.
5238         * compile/compile-c-symbols.c: Update.
5239         * compile/compile-cplus-symbols.c: Update.
5240         * compile/compile-object-load.c: Update.
5241         * compile/compile-object-run.c: Update.
5242         * completer.c: Update.
5243         * corelow.c: Update.
5244         * cp-abi.c: Update.
5245         * cp-support.c: Update.
5246         * cp-valprint.c: Update.
5247         * darwin-nat.c: Update.
5248         * disasm-selftests.c: Update.
5249         * dtrace-probe.c: Update.
5250         * dwarf-index-cache.c: Update.
5251         * dwarf-index-write.c: Update.
5252         * dwarf2-frame-tailcall.c: Update.
5253         * dwarf2-frame.c: Update.
5254         * dwarf2loc.c: Update.
5255         * dwarf2read.c: Update.
5256         * eval.c: Update.
5257         * event-loop.c: Update.
5258         * event-top.c: Update.
5259         * exec.c: Update.
5260         * f-valprint.c: Update.
5261         * fbsd-tdep.c: Update.
5262         * frame-unwind.c: Update.
5263         * frame.c: Update.
5264         * gdbtypes.c: Update.
5265         * gnu-v3-abi.c: Update.
5266         * guile/guile-internal.h: Update.
5267         * guile/scm-block.c: Update.
5268         * guile/scm-breakpoint.c: Update.
5269         * guile/scm-cmd.c: Update.
5270         * guile/scm-disasm.c: Update.
5271         * guile/scm-frame.c: Update.
5272         * guile/scm-lazy-string.c: Update.
5273         * guile/scm-math.c: Update.
5274         * guile/scm-param.c: Update.
5275         * guile/scm-ports.c: Update.
5276         * guile/scm-pretty-print.c: Update.
5277         * guile/scm-symbol.c: Update.
5278         * guile/scm-symtab.c: Update.
5279         * guile/scm-type.c: Update.
5280         * guile/scm-value.c: Update.
5281         * i386-linux-tdep.c: Update.
5282         * i386-tdep.c: Update.
5283         * inf-loop.c: Update.
5284         * infcall.c: Update.
5285         * infcmd.c: Update.
5286         * infrun.c: Update.
5287         * jit.c: Update.
5288         * language.c: Update.
5289         * linespec.c: Update.
5290         * linux-fork.c: Update.
5291         * linux-nat.c: Update.
5292         * linux-tdep.c: Update.
5293         * linux-thread-db.c: Update.
5294         * main.c: Update.
5295         * mi/mi-cmd-break.c: Update.
5296         * mi/mi-cmd-stack.c: Update.
5297         * mi/mi-interp.c: Update.
5298         * mi/mi-main.c: Update.
5299         * objc-lang.c: Update.
5300         * p-valprint.c: Update.
5301         * parse.c: Update.
5302         * ppc-linux-tdep.c: Update.
5303         * printcmd.c: Update.
5304         * python/py-arch.c: Update.
5305         * python/py-breakpoint.c: Update.
5306         * python/py-cmd.c: Update.
5307         * python/py-finishbreakpoint.c: Update.
5308         * python/py-frame.c: Update.
5309         * python/py-framefilter.c: Update.
5310         * python/py-gdb-readline.c: Update.
5311         * python/py-inferior.c: Update.
5312         * python/py-infthread.c: Update.
5313         * python/py-lazy-string.c: Update.
5314         * python/py-linetable.c: Update.
5315         * python/py-objfile.c: Update.
5316         * python/py-param.c: Update.
5317         * python/py-prettyprint.c: Update.
5318         * python/py-progspace.c: Update.
5319         * python/py-record-btrace.c: Update.
5320         * python/py-record.c: Update.
5321         * python/py-symbol.c: Update.
5322         * python/py-type.c: Update.
5323         * python/py-unwind.c: Update.
5324         * python/py-utils.c: Update.
5325         * python/py-value.c: Update.
5326         * python/python.c: Update.
5327         * record-btrace.c: Update.
5328         * record-full.c: Update.
5329         * remote-fileio.c: Update.
5330         * remote.c: Update.
5331         * riscv-tdep.c: Update.
5332         * rs6000-aix-tdep.c: Update.
5333         * rs6000-tdep.c: Update.
5334         * rust-exp.y: Update.
5335         * rust-lang.c: Update.
5336         * s390-tdep.c: Update.
5337         * selftest-arch.c: Update.
5338         * solib-dsbt.c: Update.
5339         * solib-frv.c: Update.
5340         * solib-spu.c: Update.
5341         * solib-svr4.c: Update.
5342         * solib.c: Update.
5343         * sparc64-linux-tdep.c: Update.
5344         * stack.c: Update.
5345         * symfile-mem.c: Update.
5346         * symmisc.c: Update.
5347         * target.c: Update.
5348         * thread.c: Update.
5349         * top.c: Update.
5350         * tracefile-tfile.c: Update.
5351         * tui/tui.c: Update.
5352         * typeprint.c: Update.
5353         * unittests/cli-utils-selftests.c: Update.
5354         * unittests/parse-connection-spec-selftests.c: Update.
5355         * valops.c: Update.
5356         * valprint.c: Update.
5357         * value.c: Update.
5358         * varobj.c: Update.
5359         * windows-nat.c: Update.
5360         * x86-linux-nat.c: Update.
5361         * xml-support.c: Update.
5362
5363 2019-04-08  Tom Tromey  <tom@tromey.com>
5364
5365         * xml-support.c: Use C++ exception handling.
5366         * x86-linux-nat.c: Use C++ exception handling.
5367         * windows-nat.c: Use C++ exception handling.
5368         * varobj.c: Use C++ exception handling.
5369         * value.c: Use C++ exception handling.
5370         * valprint.c: Use C++ exception handling.
5371         * valops.c: Use C++ exception handling.
5372         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5373         handling.
5374         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5375         * typeprint.c: Use C++ exception handling.
5376         * tui/tui.c: Use C++ exception handling.
5377         * tracefile-tfile.c: Use C++ exception handling.
5378         * top.c: Use C++ exception handling.
5379         * thread.c: Use C++ exception handling.
5380         * target.c: Use C++ exception handling.
5381         * symmisc.c: Use C++ exception handling.
5382         * symfile-mem.c: Use C++ exception handling.
5383         * stack.c: Use C++ exception handling.
5384         * sparc64-linux-tdep.c: Use C++ exception handling.
5385         * solib.c: Use C++ exception handling.
5386         * solib-svr4.c: Use C++ exception handling.
5387         * solib-spu.c: Use C++ exception handling.
5388         * solib-frv.c: Use C++ exception handling.
5389         * solib-dsbt.c: Use C++ exception handling.
5390         * selftest-arch.c: Use C++ exception handling.
5391         * s390-tdep.c: Use C++ exception handling.
5392         * rust-lang.c: Use C++ exception handling.
5393         * rust-exp.y: Use C++ exception handling.
5394         * rs6000-tdep.c: Use C++ exception handling.
5395         * rs6000-aix-tdep.c: Use C++ exception handling.
5396         * riscv-tdep.c: Use C++ exception handling.
5397         * remote.c: Use C++ exception handling.
5398         * remote-fileio.c: Use C++ exception handling.
5399         * record-full.c: Use C++ exception handling.
5400         * record-btrace.c: Use C++ exception handling.
5401         * python/python.c: Use C++ exception handling.
5402         * python/py-value.c: Use C++ exception handling.
5403         * python/py-utils.c: Use C++ exception handling.
5404         * python/py-unwind.c: Use C++ exception handling.
5405         * python/py-type.c: Use C++ exception handling.
5406         * python/py-symbol.c: Use C++ exception handling.
5407         * python/py-record.c: Use C++ exception handling.
5408         * python/py-record-btrace.c: Use C++ exception handling.
5409         * python/py-progspace.c: Use C++ exception handling.
5410         * python/py-prettyprint.c: Use C++ exception handling.
5411         * python/py-param.c: Use C++ exception handling.
5412         * python/py-objfile.c: Use C++ exception handling.
5413         * python/py-linetable.c: Use C++ exception handling.
5414         * python/py-lazy-string.c: Use C++ exception handling.
5415         * python/py-infthread.c: Use C++ exception handling.
5416         * python/py-inferior.c: Use C++ exception handling.
5417         * python/py-gdb-readline.c: Use C++ exception handling.
5418         * python/py-framefilter.c: Use C++ exception handling.
5419         * python/py-frame.c: Use C++ exception handling.
5420         * python/py-finishbreakpoint.c: Use C++ exception handling.
5421         * python/py-cmd.c: Use C++ exception handling.
5422         * python/py-breakpoint.c: Use C++ exception handling.
5423         * python/py-arch.c: Use C++ exception handling.
5424         * printcmd.c: Use C++ exception handling.
5425         * ppc-linux-tdep.c: Use C++ exception handling.
5426         * parse.c: Use C++ exception handling.
5427         * p-valprint.c: Use C++ exception handling.
5428         * objc-lang.c: Use C++ exception handling.
5429         * mi/mi-main.c: Use C++ exception handling.
5430         * mi/mi-interp.c: Use C++ exception handling.
5431         * mi/mi-cmd-stack.c: Use C++ exception handling.
5432         * mi/mi-cmd-break.c: Use C++ exception handling.
5433         * main.c: Use C++ exception handling.
5434         * linux-thread-db.c: Use C++ exception handling.
5435         * linux-tdep.c: Use C++ exception handling.
5436         * linux-nat.c: Use C++ exception handling.
5437         * linux-fork.c: Use C++ exception handling.
5438         * linespec.c: Use C++ exception handling.
5439         * language.c: Use C++ exception handling.
5440         * jit.c: Use C++ exception handling.
5441         * infrun.c: Use C++ exception handling.
5442         * infcmd.c: Use C++ exception handling.
5443         * infcall.c: Use C++ exception handling.
5444         * inf-loop.c: Use C++ exception handling.
5445         * i386-tdep.c: Use C++ exception handling.
5446         * i386-linux-tdep.c: Use C++ exception handling.
5447         * guile/scm-value.c: Use C++ exception handling.
5448         * guile/scm-type.c: Use C++ exception handling.
5449         * guile/scm-symtab.c: Use C++ exception handling.
5450         * guile/scm-symbol.c: Use C++ exception handling.
5451         * guile/scm-pretty-print.c: Use C++ exception handling.
5452         * guile/scm-ports.c: Use C++ exception handling.
5453         * guile/scm-param.c: Use C++ exception handling.
5454         * guile/scm-math.c: Use C++ exception handling.
5455         * guile/scm-lazy-string.c: Use C++ exception handling.
5456         * guile/scm-frame.c: Use C++ exception handling.
5457         * guile/scm-disasm.c: Use C++ exception handling.
5458         * guile/scm-cmd.c: Use C++ exception handling.
5459         * guile/scm-breakpoint.c: Use C++ exception handling.
5460         * guile/scm-block.c: Use C++ exception handling.
5461         * guile/guile-internal.h: Use C++ exception handling.
5462         * gnu-v3-abi.c: Use C++ exception handling.
5463         * gdbtypes.c: Use C++ exception handling.
5464         * frame.c: Use C++ exception handling.
5465         * frame-unwind.c: Use C++ exception handling.
5466         * fbsd-tdep.c: Use C++ exception handling.
5467         * f-valprint.c: Use C++ exception handling.
5468         * exec.c: Use C++ exception handling.
5469         * event-top.c: Use C++ exception handling.
5470         * event-loop.c: Use C++ exception handling.
5471         * eval.c: Use C++ exception handling.
5472         * dwarf2read.c: Use C++ exception handling.
5473         * dwarf2loc.c: Use C++ exception handling.
5474         * dwarf2-frame.c: Use C++ exception handling.
5475         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5476         * dwarf-index-write.c: Use C++ exception handling.
5477         * dwarf-index-cache.c: Use C++ exception handling.
5478         * dtrace-probe.c: Use C++ exception handling.
5479         * disasm-selftests.c: Use C++ exception handling.
5480         * darwin-nat.c: Use C++ exception handling.
5481         * cp-valprint.c: Use C++ exception handling.
5482         * cp-support.c: Use C++ exception handling.
5483         * cp-abi.c: Use C++ exception handling.
5484         * corelow.c: Use C++ exception handling.
5485         * completer.c: Use C++ exception handling.
5486         * compile/compile-object-run.c: Use C++ exception handling.
5487         * compile/compile-object-load.c: Use C++ exception handling.
5488         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5489         * compile/compile-c-symbols.c: Use C++ exception handling.
5490         * common/selftest.c: Use C++ exception handling.
5491         * common/new-op.c: Use C++ exception handling.
5492         * cli/cli-script.c: Use C++ exception handling.
5493         * cli/cli-interp.c: Use C++ exception handling.
5494         * cli/cli-cmds.c: Use C++ exception handling.
5495         * c-varobj.c: Use C++ exception handling.
5496         * btrace.c: Use C++ exception handling.
5497         * breakpoint.c: Use C++ exception handling.
5498         * break-catch-throw.c: Use C++ exception handling.
5499         * arch-utils.c: Use C++ exception handling.
5500         * amd64-tdep.c: Use C++ exception handling.
5501         * ada-valprint.c: Use C++ exception handling.
5502         * ada-typeprint.c: Use C++ exception handling.
5503         * ada-lang.c: Use C++ exception handling.
5504         * aarch64-tdep.c: Use C++ exception handling.
5505
5506 2019-04-08  Tom Tromey  <tom@tromey.com>
5507
5508         * xml-support.c (gdb_xml_parser::parse): Update.
5509         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5510         * value.c (show_convenience): Update.
5511         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5512         (test_parse_flags_qcs): Update.
5513         * thread.c (thr_try_catch_cmd): Update.
5514         * target.c (target_translate_tls_address): Update.
5515         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5516         (info_frame_command_core, frame_apply_command_count): Update.
5517         * rust-exp.y (rust_lex_exception_test): Update.
5518         * riscv-tdep.c (riscv_print_one_register_info): Update.
5519         * remote.c (remote_target::enable_btrace): Update.
5520         * record-btrace.c (record_btrace_enable_warn): Update.
5521         * python/py-utils.c (gdbpy_convert_exception): Update.
5522         * printcmd.c (do_one_display, print_variable_and_value): Update.
5523         * mi/mi-main.c (mi_print_exception): Update.
5524         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5525         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5526         * linux-nat.c (linux_nat_target::attach): Update.
5527         * linux-fork.c (class scoped_switch_fork_info): Update.
5528         * infrun.c (displaced_step_prepare): Update.
5529         * infcall.c (call_function_by_hand_dummy): Update.
5530         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5531         * gnu-v3-abi.c (print_one_vtable): Update.
5532         * frame.c (get_prev_frame_always): Update.
5533         * f-valprint.c (info_common_command_for_block): Update.
5534         * exec.c (try_open_exec_file): Update.
5535         * exceptions.c (print_exception, exception_print)
5536         (exception_fprintf, exception_print_same): Update.
5537         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5538         * dwarf-index-cache.c (index_cache::store)
5539         (index_cache::lookup_gdb_index): Update.
5540         * darwin-nat.c (maybe_cache_shell): Update.
5541         * cp-valprint.c (cp_print_value_fields): Update.
5542         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5543         (gcc_cplus_symbol_address): Update.
5544         * compile/compile-c-symbols.c (gcc_convert_symbol)
5545         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5546         * common/selftest.c: Update.
5547         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5548         a std::string.
5549         (exception_try_scope_entry, exception_try_scope_exit): Don't
5550         declare.
5551         (struct exception_try_scope): Remove.
5552         (TRY): Don't use exception_try_scope.
5553         (struct gdb_exception): Add constructor, operator=.
5554         <what>: New method.
5555         (struct gdb_exception_RETURN_MASK_ALL)
5556         (struct gdb_exception_RETURN_MASK_ERROR)
5557         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5558         (struct gdb_quit_bad_alloc): Update.
5559         * common/common-exceptions.c (exception_none): Change
5560         initializer.
5561         (struct catcher) <state, exception>: Initialize inline.
5562         <prev>: Remove member.
5563         (current_catcher): Remove.
5564         (catchers): New global.
5565         (exceptions_state_mc_init): Simplify.
5566         (catcher_pop): Remove.
5567         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5568         (try_scope_depth, exception_try_scope_entry)
5569         (exception_try_scope_exit): Remove.
5570         (throw_exception_sjlj): Update.
5571         (exception_messages, exception_messages_size): Remove.
5572         (throw_it): Simplify.
5573         (gdb_exception_sliced_copy): Remove.
5574         (throw_exception_cxx): Update.
5575         * cli/cli-script.c (script_from_file): Update.
5576         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5577         Update.
5578         * ada-valprint.c (ada_val_print): Update.
5579         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5580         (create_excep_cond_exprs): Update.
5581
5582 2019-04-08  Tom Tromey  <tom@tromey.com>
5583
5584         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5585         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5586         (TRY, CATCH, END_CATCH): Remove some definitions.
5587         * common/common-exceptions.c: Don't use GDB_XCPT.
5588         (catcher_list_size): Remove.
5589         (throw_exception, throw_it): Simplify.
5590
5591 2019-04-05  Tom Tromey  <tom@tromey.com>
5592
5593         Revert the header-sorting patch.
5594         * ft32-tdep.c: Revert.
5595         * frv-tdep.c: Revert.
5596         * frv-linux-tdep.c: Revert.
5597         * frame.c: Revert.
5598         * frame-unwind.c: Revert.
5599         * frame-base.c: Revert.
5600         * fork-child.c: Revert.
5601         * findvar.c: Revert.
5602         * findcmd.c: Revert.
5603         * filesystem.c: Revert.
5604         * filename-seen-cache.h: Revert.
5605         * filename-seen-cache.c: Revert.
5606         * fbsd-tdep.c: Revert.
5607         * fbsd-nat.h: Revert.
5608         * fbsd-nat.c: Revert.
5609         * f-valprint.c: Revert.
5610         * f-typeprint.c: Revert.
5611         * f-lang.c: Revert.
5612         * extension.h: Revert.
5613         * extension.c: Revert.
5614         * extension-priv.h: Revert.
5615         * expprint.c: Revert.
5616         * exec.h: Revert.
5617         * exec.c: Revert.
5618         * exceptions.c: Revert.
5619         * event-top.c: Revert.
5620         * event-loop.c: Revert.
5621         * eval.c: Revert.
5622         * elfread.c: Revert.
5623         * dwarf2read.h: Revert.
5624         * dwarf2read.c: Revert.
5625         * dwarf2loc.c: Revert.
5626         * dwarf2expr.h: Revert.
5627         * dwarf2expr.c: Revert.
5628         * dwarf2-frame.c: Revert.
5629         * dwarf2-frame-tailcall.c: Revert.
5630         * dwarf-index-write.h: Revert.
5631         * dwarf-index-write.c: Revert.
5632         * dwarf-index-common.c: Revert.
5633         * dwarf-index-cache.h: Revert.
5634         * dwarf-index-cache.c: Revert.
5635         * dummy-frame.c: Revert.
5636         * dtrace-probe.c: Revert.
5637         * disasm.h: Revert.
5638         * disasm.c: Revert.
5639         * disasm-selftests.c: Revert.
5640         * dictionary.c: Revert.
5641         * dicos-tdep.c: Revert.
5642         * demangle.c: Revert.
5643         * dcache.h: Revert.
5644         * dcache.c: Revert.
5645         * darwin-nat.h: Revert.
5646         * darwin-nat.c: Revert.
5647         * darwin-nat-info.c: Revert.
5648         * d-valprint.c: Revert.
5649         * d-namespace.c: Revert.
5650         * d-lang.c: Revert.
5651         * ctf.c: Revert.
5652         * csky-tdep.c: Revert.
5653         * csky-linux-tdep.c: Revert.
5654         * cris-tdep.c: Revert.
5655         * cris-linux-tdep.c: Revert.
5656         * cp-valprint.c: Revert.
5657         * cp-support.c: Revert.
5658         * cp-namespace.c: Revert.
5659         * cp-abi.c: Revert.
5660         * corelow.c: Revert.
5661         * corefile.c: Revert.
5662         * continuations.c: Revert.
5663         * completer.h: Revert.
5664         * completer.c: Revert.
5665         * complaints.c: Revert.
5666         * coffread.c: Revert.
5667         * coff-pe-read.c: Revert.
5668         * cli-out.h: Revert.
5669         * cli-out.c: Revert.
5670         * charset.c: Revert.
5671         * c-varobj.c: Revert.
5672         * c-valprint.c: Revert.
5673         * c-typeprint.c: Revert.
5674         * c-lang.c: Revert.
5675         * buildsym.c: Revert.
5676         * buildsym-legacy.c: Revert.
5677         * build-id.h: Revert.
5678         * build-id.c: Revert.
5679         * btrace.c: Revert.
5680         * bsd-uthread.c: Revert.
5681         * breakpoint.h: Revert.
5682         * breakpoint.c: Revert.
5683         * break-catch-throw.c: Revert.
5684         * break-catch-syscall.c: Revert.
5685         * break-catch-sig.c: Revert.
5686         * blockframe.c: Revert.
5687         * block.c: Revert.
5688         * bfin-tdep.c: Revert.
5689         * bfin-linux-tdep.c: Revert.
5690         * bfd-target.c: Revert.
5691         * bcache.c: Revert.
5692         * ax-general.c: Revert.
5693         * ax-gdb.h: Revert.
5694         * ax-gdb.c: Revert.
5695         * avr-tdep.c: Revert.
5696         * auxv.c: Revert.
5697         * auto-load.c: Revert.
5698         * arm-wince-tdep.c: Revert.
5699         * arm-tdep.c: Revert.
5700         * arm-symbian-tdep.c: Revert.
5701         * arm-pikeos-tdep.c: Revert.
5702         * arm-obsd-tdep.c: Revert.
5703         * arm-nbsd-tdep.c: Revert.
5704         * arm-nbsd-nat.c: Revert.
5705         * arm-linux-tdep.c: Revert.
5706         * arm-linux-nat.c: Revert.
5707         * arm-fbsd-tdep.c: Revert.
5708         * arm-fbsd-nat.c: Revert.
5709         * arm-bsd-tdep.c: Revert.
5710         * arch-utils.c: Revert.
5711         * arc-tdep.c: Revert.
5712         * arc-newlib-tdep.c: Revert.
5713         * annotate.h: Revert.
5714         * annotate.c: Revert.
5715         * amd64-windows-tdep.c: Revert.
5716         * amd64-windows-nat.c: Revert.
5717         * amd64-tdep.c: Revert.
5718         * amd64-sol2-tdep.c: Revert.
5719         * amd64-obsd-tdep.c: Revert.
5720         * amd64-obsd-nat.c: Revert.
5721         * amd64-nbsd-tdep.c: Revert.
5722         * amd64-nbsd-nat.c: Revert.
5723         * amd64-nat.c: Revert.
5724         * amd64-linux-tdep.c: Revert.
5725         * amd64-linux-nat.c: Revert.
5726         * amd64-fbsd-tdep.c: Revert.
5727         * amd64-fbsd-nat.c: Revert.
5728         * amd64-dicos-tdep.c: Revert.
5729         * amd64-darwin-tdep.c: Revert.
5730         * amd64-bsd-nat.c: Revert.
5731         * alpha-tdep.c: Revert.
5732         * alpha-obsd-tdep.c: Revert.
5733         * alpha-nbsd-tdep.c: Revert.
5734         * alpha-mdebug-tdep.c: Revert.
5735         * alpha-linux-tdep.c: Revert.
5736         * alpha-linux-nat.c: Revert.
5737         * alpha-bsd-tdep.c: Revert.
5738         * alpha-bsd-nat.c: Revert.
5739         * aix-thread.c: Revert.
5740         * agent.c: Revert.
5741         * addrmap.c: Revert.
5742         * ada-varobj.c: Revert.
5743         * ada-valprint.c: Revert.
5744         * ada-typeprint.c: Revert.
5745         * ada-tasks.c: Revert.
5746         * ada-lang.c: Revert.
5747         * aarch64-tdep.c: Revert.
5748         * aarch64-ravenscar-thread.c: Revert.
5749         * aarch64-newlib-tdep.c: Revert.
5750         * aarch64-linux-tdep.c: Revert.
5751         * aarch64-linux-nat.c: Revert.
5752         * aarch64-fbsd-tdep.c: Revert.
5753         * aarch64-fbsd-nat.c: Revert.
5754         * aarch32-linux-nat.c: Revert.
5755
5756 2019-04-05  Tom Tromey  <tom@tromey.com>
5757
5758         * ft32-tdep.c: Sort headers.
5759         * frv-tdep.c: Sort headers.
5760         * frv-linux-tdep.c: Sort headers.
5761         * frame.c: Sort headers.
5762         * frame-unwind.c: Sort headers.
5763         * frame-base.c: Sort headers.
5764         * fork-child.c: Sort headers.
5765         * findvar.c: Sort headers.
5766         * findcmd.c: Sort headers.
5767         * filesystem.c: Sort headers.
5768         * filename-seen-cache.h: Sort headers.
5769         * filename-seen-cache.c: Sort headers.
5770         * fbsd-tdep.c: Sort headers.
5771         * fbsd-nat.h: Sort headers.
5772         * fbsd-nat.c: Sort headers.
5773         * f-valprint.c: Sort headers.
5774         * f-typeprint.c: Sort headers.
5775         * f-lang.c: Sort headers.
5776         * extension.h: Sort headers.
5777         * extension.c: Sort headers.
5778         * extension-priv.h: Sort headers.
5779         * expprint.c: Sort headers.
5780         * exec.h: Sort headers.
5781         * exec.c: Sort headers.
5782         * exceptions.c: Sort headers.
5783         * event-top.c: Sort headers.
5784         * event-loop.c: Sort headers.
5785         * eval.c: Sort headers.
5786         * elfread.c: Sort headers.
5787         * dwarf2read.h: Sort headers.
5788         * dwarf2read.c: Sort headers.
5789         * dwarf2loc.c: Sort headers.
5790         * dwarf2expr.h: Sort headers.
5791         * dwarf2expr.c: Sort headers.
5792         * dwarf2-frame.c: Sort headers.
5793         * dwarf2-frame-tailcall.c: Sort headers.
5794         * dwarf-index-write.h: Sort headers.
5795         * dwarf-index-write.c: Sort headers.
5796         * dwarf-index-common.c: Sort headers.
5797         * dwarf-index-cache.h: Sort headers.
5798         * dwarf-index-cache.c: Sort headers.
5799         * dummy-frame.c: Sort headers.
5800         * dtrace-probe.c: Sort headers.
5801         * disasm.h: Sort headers.
5802         * disasm.c: Sort headers.
5803         * disasm-selftests.c: Sort headers.
5804         * dictionary.c: Sort headers.
5805         * dicos-tdep.c: Sort headers.
5806         * demangle.c: Sort headers.
5807         * dcache.h: Sort headers.
5808         * dcache.c: Sort headers.
5809         * darwin-nat.h: Sort headers.
5810         * darwin-nat.c: Sort headers.
5811         * darwin-nat-info.c: Sort headers.
5812         * d-valprint.c: Sort headers.
5813         * d-namespace.c: Sort headers.
5814         * d-lang.c: Sort headers.
5815         * ctf.c: Sort headers.
5816         * csky-tdep.c: Sort headers.
5817         * csky-linux-tdep.c: Sort headers.
5818         * cris-tdep.c: Sort headers.
5819         * cris-linux-tdep.c: Sort headers.
5820         * cp-valprint.c: Sort headers.
5821         * cp-support.c: Sort headers.
5822         * cp-namespace.c: Sort headers.
5823         * cp-abi.c: Sort headers.
5824         * corelow.c: Sort headers.
5825         * corefile.c: Sort headers.
5826         * continuations.c: Sort headers.
5827         * completer.h: Sort headers.
5828         * completer.c: Sort headers.
5829         * complaints.c: Sort headers.
5830         * coffread.c: Sort headers.
5831         * coff-pe-read.c: Sort headers.
5832         * cli-out.h: Sort headers.
5833         * cli-out.c: Sort headers.
5834         * charset.c: Sort headers.
5835         * c-varobj.c: Sort headers.
5836         * c-valprint.c: Sort headers.
5837         * c-typeprint.c: Sort headers.
5838         * c-lang.c: Sort headers.
5839         * buildsym.c: Sort headers.
5840         * buildsym-legacy.c: Sort headers.
5841         * build-id.h: Sort headers.
5842         * build-id.c: Sort headers.
5843         * btrace.c: Sort headers.
5844         * bsd-uthread.c: Sort headers.
5845         * breakpoint.h: Sort headers.
5846         * breakpoint.c: Sort headers.
5847         * break-catch-throw.c: Sort headers.
5848         * break-catch-syscall.c: Sort headers.
5849         * break-catch-sig.c: Sort headers.
5850         * blockframe.c: Sort headers.
5851         * block.c: Sort headers.
5852         * bfin-tdep.c: Sort headers.
5853         * bfin-linux-tdep.c: Sort headers.
5854         * bfd-target.c: Sort headers.
5855         * bcache.c: Sort headers.
5856         * ax-general.c: Sort headers.
5857         * ax-gdb.h: Sort headers.
5858         * ax-gdb.c: Sort headers.
5859         * avr-tdep.c: Sort headers.
5860         * auxv.c: Sort headers.
5861         * auto-load.c: Sort headers.
5862         * arm-wince-tdep.c: Sort headers.
5863         * arm-tdep.c: Sort headers.
5864         * arm-symbian-tdep.c: Sort headers.
5865         * arm-pikeos-tdep.c: Sort headers.
5866         * arm-obsd-tdep.c: Sort headers.
5867         * arm-nbsd-tdep.c: Sort headers.
5868         * arm-nbsd-nat.c: Sort headers.
5869         * arm-linux-tdep.c: Sort headers.
5870         * arm-linux-nat.c: Sort headers.
5871         * arm-fbsd-tdep.c: Sort headers.
5872         * arm-fbsd-nat.c: Sort headers.
5873         * arm-bsd-tdep.c: Sort headers.
5874         * arch-utils.c: Sort headers.
5875         * arc-tdep.c: Sort headers.
5876         * arc-newlib-tdep.c: Sort headers.
5877         * annotate.h: Sort headers.
5878         * annotate.c: Sort headers.
5879         * amd64-windows-tdep.c: Sort headers.
5880         * amd64-windows-nat.c: Sort headers.
5881         * amd64-tdep.c: Sort headers.
5882         * amd64-sol2-tdep.c: Sort headers.
5883         * amd64-obsd-tdep.c: Sort headers.
5884         * amd64-obsd-nat.c: Sort headers.
5885         * amd64-nbsd-tdep.c: Sort headers.
5886         * amd64-nbsd-nat.c: Sort headers.
5887         * amd64-nat.c: Sort headers.
5888         * amd64-linux-tdep.c: Sort headers.
5889         * amd64-linux-nat.c: Sort headers.
5890         * amd64-fbsd-tdep.c: Sort headers.
5891         * amd64-fbsd-nat.c: Sort headers.
5892         * amd64-dicos-tdep.c: Sort headers.
5893         * amd64-darwin-tdep.c: Sort headers.
5894         * amd64-bsd-nat.c: Sort headers.
5895         * alpha-tdep.c: Sort headers.
5896         * alpha-obsd-tdep.c: Sort headers.
5897         * alpha-nbsd-tdep.c: Sort headers.
5898         * alpha-mdebug-tdep.c: Sort headers.
5899         * alpha-linux-tdep.c: Sort headers.
5900         * alpha-linux-nat.c: Sort headers.
5901         * alpha-bsd-tdep.c: Sort headers.
5902         * alpha-bsd-nat.c: Sort headers.
5903         * aix-thread.c: Sort headers.
5904         * agent.c: Sort headers.
5905         * addrmap.c: Sort headers.
5906         * ada-varobj.c: Sort headers.
5907         * ada-valprint.c: Sort headers.
5908         * ada-typeprint.c: Sort headers.
5909         * ada-tasks.c: Sort headers.
5910         * ada-lang.c: Sort headers.
5911         * aarch64-tdep.c: Sort headers.
5912         * aarch64-ravenscar-thread.c: Sort headers.
5913         * aarch64-newlib-tdep.c: Sort headers.
5914         * aarch64-linux-tdep.c: Sort headers.
5915         * aarch64-linux-nat.c: Sort headers.
5916         * aarch64-fbsd-tdep.c: Sort headers.
5917         * aarch64-fbsd-nat.c: Sort headers.
5918         * aarch32-linux-nat.c: Sort headers.
5919
5920 2019-04-04  Tom Tromey  <tom@tromey.com>
5921
5922         * varobj.c (varobj_create): Update.
5923         * rust-exp.y (struct rust_parser) <update_innermost_block,
5924         lookup_symbol>: New methods.
5925         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5926         Rename.
5927         (rust_parser::rust_lookup_type)
5928         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5929         * printcmd.c (display_command, do_one_display): Update.
5930         * parser-defs.h (struct parser_state) <parser_state>: Add
5931         "tracker" parameter.
5932         (block_tracker): New member.
5933         (class innermost_block_tracker) <innermost_block_tracker>: Add
5934         "types" parameter.
5935         <reset>: Remove method.
5936         (innermost_block): Don't declare.
5937         (null_post_parser): Update.
5938         * parse.c (innermost_block): Remove global.
5939         (write_dollar_variable): Update.
5940         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5941         Remove "tracker_types" parameter.
5942         (parse_expression): Add "tracker" parameter.
5943         (parse_expression_for_completion): Update.
5944         (null_post_parser): Add "tracker" parameter.
5945         * p-exp.y: Update rules.
5946         * m2-exp.y: Update rules.
5947         * language.h (struct language_defn) <la_post_parser>: Add
5948         "tracker" parameter.
5949         * go-exp.y: Update rules.
5950         * f-exp.y: Update rules.
5951         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5952         parameter.
5953         * d-exp.y: Update rules.
5954         * c-exp.y: Update rules.
5955         * breakpoint.c (set_breakpoint_condition): Create an
5956         innermost_block_tracker.
5957         (watch_command_1): Likewise.
5958         * ada-lang.c (resolve): Add "tracker" parameter.
5959         (resolve_subexp): Likewise.
5960         * ada-exp.y (write_var_from_sym): Update.
5961
5962 2019-04-04  Tom Tromey  <tom@tromey.com>
5963
5964         * type-stack.h: New file.
5965         * type-stack.c: New file.
5966         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5967         type-stack.h.
5968         (insert_into_type_stack, insert_type, push_type, push_type_int)
5969         (insert_type_address_space, pop_type, pop_type_int)
5970         (pop_typelist, pop_type_stack, append_type_stack)
5971         (push_type_stack, get_type_stack, push_typelist)
5972         (follow_type_instance_flags, follow_types): Don't declare.
5973         * parse.c (type_stack): Remove global.
5974         (parse_exp_in_context): Update.
5975         (insert_into_type_stack, insert_type, push_type, push_type_int)
5976         (insert_type_address_space, pop_type, pop_type_int)
5977         (pop_typelist, pop_type_stack, append_type_stack)
5978         (push_type_stack, get_type_stack, push_typelist)
5979         (follow_type_instance_flags, follow_types): Remove (moved to
5980         type-stack.c).
5981         * f-exp.y (type_stack): New global.
5982         Update rules.
5983         (push_kind_type, f_parse): Update.
5984         * d-exp.y (type_stack): New global.
5985         Update rules.
5986         (d_parse): Update.
5987         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5988         Update rules.
5989         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5990         (HFILES_NO_SRCDIR): Add type-stack.h.
5991
5992 2019-04-04  Tom Tromey  <tom@tromey.com>
5993
5994         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5995         (rust_parser::convert_ast_to_expression, rust_parse)
5996         (rust_lex_test_completion, rust_lex_tests): Update.
5997         * parser-defs.h (struct expr_completion_state): New.
5998         (struct parser_state) <parser_state>: Add completion parameter.
5999         <mark_struct_expression, mark_completion_tag>: New methods.
6000         <parse_completion, m_completion_state>: New members.
6001         (prefixify_expression, null_post_parser): Update.
6002         (mark_struct_expression, mark_completion_tag): Don't declare.
6003         * parse.c (parse_completion, expout_last_struct)
6004         (expout_tag_completion_type, expout_completion_name): Remove
6005         globals.
6006         (parser_state::mark_struct_expression)
6007         (parser_state::mark_completion_tag): Now methods.
6008         (prefixify_expression): Add last_struct parameter.
6009         (prefixify_subexp): Likewise.
6010         (parse_exp_1): Update.
6011         (parse_exp_in_context): Add cstate parameter.  Update.
6012         (parse_expression_for_completion): Create an
6013         expr_completion_state.
6014         (null_post_parser): Add "completion" parameter.
6015         * p-exp.y: Update rules.
6016         (yylex): Update.
6017         * language.h (struct language_defn) <la_post_parser>: Add
6018         "completing" parameter.
6019         * go-exp.y: Update rules.
6020         (lex_one_token): Update.
6021         * expression.h (parse_completion): Don't declare.
6022         * d-exp.y: Update rules.
6023         (lex_one_token): Update rules.
6024         * c-exp.y: Update rules.
6025         (lex_one_token): Update.
6026         * ada-lang.c (resolve): Add "parse_completion" parameter.
6027         (resolve_subexp): Likewise.
6028         (ada_resolve_function): Likewise.
6029
6030 2019-04-04  Tom Tromey  <tom@tromey.com>
6031
6032         * parser-defs.h (struct parser_state) <start_arglist,
6033         end_arglist>: New methods.
6034         <arglist_len, m_funcall_chain>: New members.
6035         (arglist_len, start_arglist, end_arglist): Don't declare.
6036         * parse.c (arglist_len, funcall_chain): Remove global.
6037         (start_arglist, end_arglist): Remove functions.
6038         (parse_exp_in_context): Update.
6039         * p-exp.y: Update rules.
6040         * m2-exp.y: Update rules.
6041         * go-exp.y: Update rules.
6042         * f-exp.y: Update rules.
6043         * d-exp.y: Update rules.
6044         * c-exp.y: Update rules.
6045
6046 2019-04-04  Tom Tromey  <tom@tromey.com>
6047
6048         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6049         lex_operator, push_back>: New methods.
6050         Update all rules.
6051         (rust_parser::lex_hex, lex_escape): Rename and update.
6052         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6053         (rust_parser::lex_operator): Rename and update.
6054         (rust_parser::lex_number, rustyylex, rustyyerror)
6055         (rust_lex_test_init, rust_lex_test_sequence)
6056         (rust_lex_test_push_back, rust_lex_tests): Update.
6057         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6058         parameter.
6059         <lexptr, prev_lexptr>: New members.
6060         (lexptr, prev_lexptr): Don't declare.
6061         * parse.c (lexptr, prev_lexptr): Remove globals.
6062         (parse_exp_in_context): Update.
6063         * p-exp.y (yylex, yyerror): Update.
6064         * m2-exp.y (parse_number, yylex, yyerror): Update.
6065         * go-exp.y (lex_one_token, yyerror): Update.
6066         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6067         * d-exp.y (lex_one_token, yyerror): Update.
6068         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6069         (lex_one_token, yyerror): Update.
6070         * ada-lex.l (YY_INPUT): Update.
6071         (rewind_to_char): Update.
6072         * ada-exp.y (yyerror): Update.
6073
6074 2019-04-04  Tom Tromey  <tom@tromey.com>
6075
6076         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6077         * parser-defs.h (struct parser_state) <parser_state>: Add new
6078         parameter.
6079         <comma_terminates>: New member.
6080         (comma_terminates): Don't declare global.
6081         * parse.c (comma_terminates): Remove global.
6082         (parse_exp_in_context): Update.
6083         * p-exp.y (yylex): Update.
6084         * m2-exp.y (yylex): Update.
6085         * go-exp.y (lex_one_token): Update.
6086         * f-exp.y (yylex): Update.
6087         * d-exp.y (lex_one_token): Update.
6088         * c-exp.y (lex_one_token): Update.
6089         * ada-lex.l: Update.
6090
6091 2019-04-04  Tom Tromey  <tom@tromey.com>
6092
6093         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6094         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6095         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6096         * parser-defs.h (paren_depth): Don't declare.
6097         * parse.c (paren_depth): Remove global.
6098         (parse_exp_in_context): Update.
6099         * p-exp.y (paren_depth): New global.
6100         (pascal_parse): Initialize it.
6101         * m2-exp.y (paren_depth): New global.
6102         (m2_parse): Initialize it.
6103         * go-exp.y (paren_depth): New global.
6104         (go_parse): Initialize it.
6105         * f-exp.y (paren_depth): New global.
6106         (f_parse): Initialize it.
6107         * d-exp.y (paren_depth): New global.
6108         (d_parse): Initialize it.
6109         * c-exp.y (paren_depth): New global.
6110         (c_parse): Initialize it.
6111         * ada-lex.l (paren_depth): New global.
6112         (lexer_init): Initialize it.
6113
6114 2019-04-04  Tom Tromey  <tom@tromey.com>
6115
6116         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6117         (rust_parser::convert_ast_to_type)
6118         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6119         * parser-defs.h (struct parser_state) <parser_state>: Add
6120         parameters.  Initialize new members.
6121         <expression_context_block, expression_context_pc>: New members.
6122         * parse.c (expression_context_block, expression_context_pc):
6123         Remove globals.
6124         (parse_exp_in_context): Update.
6125         * p-exp.y: Update all rules.
6126         (yylex): Update.
6127         * m2-exp.y: Update all rules.
6128         (yylex): Update.
6129         * go-exp.y (yylex): Update.
6130         * f-exp.y (yylex): Update.
6131         * d-exp.y: Update all rules.
6132         (yylex): Update.
6133         * c-exp.y: Update all rules.
6134         (lex_one_token, classify_name, yylex, c_parse): Update.
6135         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6136
6137 2019-04-04  Tom Tromey  <tom@tromey.com>
6138
6139         * gdbarch.h, gdbarch.c: Rebuild.
6140         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6141         * stap-probe.h:
6142         (struct stap_parse_info): Replace "parser_state" with
6143         "expr_builder".
6144         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6145         (parser_state): New class.
6146         * parse.c (expr_builder): Rename.
6147         (expr_builder::release): Rename.
6148         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6149         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6150         (write_exp_elt_longcst, write_exp_elt_floatcst)
6151         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6152         (write_exp_string_vector, write_exp_bitstring)
6153         (write_exp_msymbol, mark_struct_expression)
6154         (write_dollar_variable)
6155         (insert_type_address_space, increase_expout_size): Replace
6156         "parser_state" with "expr_builder".
6157         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6158         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6159         "parser_state" with "expr_builder".
6160
6161 2019-04-04  Tom Tromey  <tom@tromey.com>
6162
6163         * rust-exp.y: Replace "parse_language" with method call.
6164         * p-exp.y:
6165         (yylex): Replace "parse_language" with method call.
6166         * m2-exp.y:
6167         (yylex): Replace "parse_language" with method call.
6168         * go-exp.y (classify_name): Replace "parse_language" with method
6169         call.
6170         * f-exp.y (yylex): Replace "parse_language" with method call.
6171         * d-exp.y (lex_one_token): Replace "parse_language" with method
6172         call.
6173         * c-exp.y:
6174         (lex_one_token, classify_name, yylex): Replace "parse_language"
6175         with method call.
6176         * ada-exp.y (find_primitive_type, type_char)
6177         (type_system_address): Replace "parse_language" with method call.
6178
6179 2019-04-04  Tom Tromey  <tom@tromey.com>
6180
6181         * rust-exp.y: Replace "parse_gdbarch" with method call.
6182         * parse.c (write_dollar_variable, insert_type_address_space):
6183         Replace "parse_gdbarch" with method call.
6184         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6185         call.
6186         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6187         call.
6188         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6189         "parse_gdbarch" with method call.
6190         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6191         with method call.
6192         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6193         "parse_gdbarch" with method call.
6194         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6195         "parse_gdbarch" with method call.
6196         * c-exp.y (parse_type, parse_number, classify_name): Replace
6197         "parse_gdbarch" with method call.
6198         * ada-lex.l: Replace "parse_gdbarch" with method call.
6199         * ada-exp.y (parse_type, find_primitive_type, type_char)
6200         (type_system_address): Replace "parse_gdbarch" with method call.
6201
6202 2019-04-04  Tom Tromey  <tom@tromey.com>
6203
6204         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6205         * stap-probe.c (stap_parse_argument): Update.
6206         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6207         initial_size parameter.
6208         * rust-exp.y (rust_lex_tests): Update.
6209         * parse.c (parser_state): Update.
6210         (parse_exp_in_context): Update.
6211         * parser-defs.h (struct parser_state) <parser_state>: Remove
6212         "initial_size" parameter.
6213
6214 2019-04-04  Tom Tromey  <tom@tromey.com>
6215
6216         * parser-defs.h (increase_expout_size): Don't declare.
6217         * parse.c (increase_expout_size): Now static.
6218
6219 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6220
6221         * gnu-nat.c (gnu_nat_target::wait): Fix
6222         target_waitstatus_to_string call.
6223
6224 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6225
6226         * eval.c (evaluate_subexp_standard): Handle internal functions
6227         during Fortran function call handling.
6228
6229 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6230
6231         * NEWS: Mention new internal functions.
6232         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6233         (read_base_type): Use dwarf2_init_complex_target_type.
6234         * value.c (creal_internal_fn): New function.
6235         (cimag_internal_fn): New function.
6236         (_initialize_values): Register new internal functions.
6237
6238 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6239
6240         * infrun.c (stop_all_threads): If debug_infrun, always
6241         trace the wait status after wait_one, using
6242         target_waitstatus_to_string and target_pid_to_str.
6243         (handle_inferior_event): Replace various trace of
6244         wait status kind by a single trace.
6245         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6246         wait status kind image by target_waitstatus_to_string.
6247         * target/waitstatus.c (target_waitstatus_to_string): Fix
6248         obsolete comment.
6249
6250 2019-04-01  Tom Tromey  <tromey@adacore.com>
6251
6252         PR symtab/23331:
6253         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6254
6255 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6256             Pedro Alves  <palves@redhat.com>
6257
6258         * top.c (quit_force): Call 'finalize_values'.
6259         * value.c (finalize_values): New function.
6260         * value.h (finalize_values): Declare.
6261
6262 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6263
6264         * NEWS: Announce $_gdb_major and $_gdb_minor.
6265
6266         * top.c (init_gdb_version_vars): New function.
6267         (gdb_init): Call init_gdb_version_vars.
6268
6269 2019-03-29  Tom Tromey  <tromey@adacore.com>
6270
6271         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6272         help text.  Remove dead code.
6273
6274 2019-03-29  Keith Seitz  <keiths@redhat.com>
6275
6276         From Siddhesh Poyarekar:
6277         * f-lang.h (f77_get_upperbound): Return LONGEST.
6278         (f77_get_lowerbound): Likewise.
6279         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6280         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6281         print them.
6282         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6283         plongest to format print it.
6284         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6285         (f77_get_upperbound): Likewise.
6286         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6287         LOWER_BOUND to LONGEST.
6288         (f77_create_arrayprint_offset_tbl): Likewise.
6289
6290 2019-03-29  Keith Seitz  <keiths@redhat.com>
6291
6292         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6293         %s/pulongest for TYPE_LENGTH instead of %d in format
6294         strings.
6295         * ada-typerint.c (ada_print_type): Likewise.
6296         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6297         * compile/compile-c-support.c (generate_register_struct): Likewise.
6298         * gdbtypes.c (recursive_dump_type): Likewise.
6299         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6300         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6301         instead of %d in format strings.
6302         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6303         to std::min to ULONGEST.
6304         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6305         instead of %d in format strings.
6306         * tracepoint.c (info_scope_command): Likewise.
6307         * typeprint.c (print_offset_data::update)
6308         (print_offset_data::finish): Likewise.
6309         * xtensa-tdep.c (xtensa_store_return_value)
6310         (xtensa_push_dummy_call): Likewise.
6311
6312 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6313
6314         * windows-nat.c (display_selector): Fixed format specifications
6315         for 64-bit Cygwin.
6316
6317 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6318
6319         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6320
6321 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6322
6323         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6324         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6325         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6326         (nios2_linux_init_abi): Install it.
6327
6328 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6329
6330         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6331
6332 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6333
6334         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6335
6336 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6337             Tom Tromey  <tromey@adacore.com>
6338
6339         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6340
6341 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6342
6343         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6344         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6345         method to compute the bounds of range types. Also print "[evaluated]"
6346         if the bounds' values come from a dynamic evaluation.
6347
6348 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6349
6350         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6351         whitespace when pretty printing is on.
6352
6353 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6354
6355         * ppc-linux-nat.c: Add include.
6356
6357 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6358
6359         * NEWS: Mention AArch64 Pointer Authentication.
6360
6361 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6362
6363         * arm-linux-nat.c: Add include.
6364
6365 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6366
6367         * source-cache.c (source_cache::get_source_lines): Re-read
6368         fullname after calling open_source_file.
6369
6370 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6371
6372         * NEWS: Mention TLS support for FreeBSD.
6373
6374 2019-03-25  Tom Tromey  <tromey@adacore.com>
6375
6376         * minsyms.c (BUNCH_SIZE): Update comment.
6377         (~minimal_symbol_reader): Remove old comment.
6378         (compact_minimal_symbols): Update comment.
6379         (minimal_symbol_reader::install): Remove old comment.  Update
6380         other comments.
6381
6382 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6383
6384         * s390-linux-nat.c: Add include.
6385
6386 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6387
6388         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6389         Call linux_get_hwcap.
6390         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6391         Likewise.
6392         (aarch64_linux_get_hwcap): Remove function.
6393         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6394         declaration.
6395         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6396         linux_get_hwcap.
6397         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6398         * linux-tdep.c (linux_get_hwcap): Add function.
6399         (linux_get_hwcap2): Likewise.
6400         * linux-tdep.h (linux_get_hwcap): Add declaration.
6401         (linux_get_hwcap2): Likewise.
6402         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6403         (ppc_linux_get_hwcap2): Likewise.
6404         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6405         linux_get_hwcap.
6406         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6407         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6408         (ppc_linux_nat_target::read_description): Likewise.
6409         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6410         * s390-linux-nat.c: Likewise.
6411         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6412
6413 2019-03-24  Tom Tromey  <tom@tromey.com>
6414
6415         * ada-lang.c (standard_lookup): Simplify initialization.
6416         (ada_lookup_symbol_nonlocal): Simplify return.
6417         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6418         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6419         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6420         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6421         initialization.
6422         * solib.c (solib_global_lookup): Simplify.
6423         * symtab.c (null_block_symbol): Remove.
6424         (symbol_cache_lookup): Simplify returns.
6425         (lookup_language_this): Simplify returns.
6426         (lookup_symbol_aux): Simplify return.
6427         (lookup_local_symbol): Simplify returns.
6428         (lookup_global_symbol_from_objfile): Simplify return.
6429         (lookup_symbol_in_objfile_symtabs)
6430         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6431         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6432         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6433         * cp-namespace.c (cp_lookup_bare_symbol)
6434         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6435         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6436         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6437         (cp_lookup_symbol_via_imports): Simplify initialization.
6438         (find_symbol_in_baseclass): Likewise.
6439         * symtab.h (null_block_symbol): Remove.
6440         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6441         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6442         (d_lookup_symbol_module): Likewise.
6443         (find_symbol_in_baseclass): Simplify initialization.
6444
6445 2019-03-24  Tom Tromey  <tom@tromey.com>
6446
6447         * expression.h: Don't include symtab.h.
6448         (struct block): Forward declare.
6449
6450 2019-03-24  Tom Tromey  <tom@tromey.com>
6451
6452         * c-exp.y (typebase): Remove casts.
6453         * gdbtypes.c (lookup_unsigned_typename, )
6454         (lookup_signed_typename): Remove cast.
6455         * eval.c (parse_to_comma_and_eval): Remove cast.
6456         * parse.c (write_dollar_variable): Remove cast.
6457         * block.h (struct block) <superblock>: Now const.
6458         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6459         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6460         (map_block): Make "block" const.
6461         * symfile.h (struct quick_symbol_functions)
6462         <map_matching_symbols>: Constify block argument to "callback".
6463         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6464         const.
6465         (find_pc_sect_compunit_symtab): Make "b" const.
6466         (find_symbol_at_address): Likewise.
6467         (search_symbols): Likewise.
6468         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6469         (dw2_debug_names_lookup_symbol): Likewise.
6470         (dw2_map_matching_symbols): Update.
6471         * p-valprint.c (pascal_val_print): Remove "block".
6472         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6473         (aux_add_nonlocal_symbols): Make "block" const.
6474         (resolve_subexp): Remove cast.
6475         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6476         const.
6477         (iterate_over_file_blocks): Likewise.
6478         * f-exp.y (%union) <bval>: Remove.
6479         * coffread.c (patch_opaque_types): Make "b" const.
6480         * spu-tdep.c (spu_catch_start): Make "block" const.
6481         * c-valprint.c (print_unpacked_pointer): Remove "block".
6482         * symmisc.c (dump_symtab_1): Make "b" const.
6483         (block_depth): Make "block" const.
6484         * d-exp.y (%union) <bval>: Remove.
6485         * cp-support.h (cp_lookup_rtti_type): Update.
6486         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6487         * psymtab.c (psym_lookup_symbol): Make "block" const.
6488         (maintenance_check_psymtabs): Make "b" const.
6489         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6490         (enumerate_locals, enumerate_args): Update.
6491         * python/py-symtab.c (stpy_global_block): Make "block" const.
6492         (stpy_static_block): Likewise.
6493         * inline-frame.c (block_starting_point_at): Make "new_block"
6494         const.
6495         * block.c (find_block_in_blockvector): Make return type const.
6496         (blockvector_for_pc_sect): Make "b" const.
6497         (find_block_in_blockvector): Make "b" const.
6498
6499 2019-03-23  Tom Tromey  <tom@tromey.com>
6500
6501         * varobj.c (varobj_create): Update.
6502         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6503         * printcmd.c (display_command, do_one_display): Don't reset
6504         innermost_block.
6505         * parser-defs.h (enum innermost_block_tracker_type): Move to
6506         expression.h.
6507         (innermost_block): Update comment.
6508         * parse.c (parse_exp_1): Add tracker_types parameter.
6509         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6510         tracker_types parameter.  Reset innermost_block.
6511         (parse_exp_in_context): Remove.
6512         (parse_expression_for_completion): Update.
6513         * objfiles.c (~objfile): Don't reset expression_context_block or
6514         innermost_block.
6515         * expression.h (enum innermost_block_tracker_type): Move from
6516         parser-defs.h.
6517         (parse_exp_1): Add tracker_types parameter.
6518         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6519         reset innermost_block.
6520
6521 2019-03-23  Tom Tromey  <tom@tromey.com>
6522
6523         * objfiles.h: Include bcache.h.
6524
6525 2019-03-23  Tom Tromey  <tom@tromey.com>
6526
6527         * linespec.c (get_current_search_block): Use
6528         scoped_restore_current_language.
6529         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6530
6531 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6532             Jiong Wang  <jiong.wang@arm.com>
6533
6534         * aarch64-linux-tdep.c
6535         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6536         section.
6537         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6538
6539 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6540             Jiong Wang  <jiong.wang@arm.com>
6541
6542         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6543         instructions.
6544         (aarch64_analyze_prologue_test): Add PACIASP test.
6545         (aarch64_prologue_prev_register): Unmask PC value.
6546
6547 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6548             Jiong Wang  <jiong.wang@arm.com>
6549
6550         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6551         (aarch64_dwarf2_prev_register): Unmask PC value.
6552         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6553         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6554         DW_CFA_AARCH64_negate_ra_state.
6555         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6556
6557 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6558             Jiong Wang  <jiong.wang@arm.com>
6559
6560         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6561         registers.
6562         (aarch64_pseudo_register_name): Likewise.
6563         (aarch64_pseudo_register_type): Likewise.
6564         (aarch64_pseudo_register_reggroup_p): Likewise.
6565         (aarch64_gdbarch_init): Add pauth registers.
6566         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6567         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6568         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6569         (struct gdbarch_tdep): Add regnum for ra_state.
6570
6571 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6572             Jiong Wang  <jiong.wang@arm.com>
6573
6574         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6575
6576 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6577             Jiong Wang  <jiong.wang@arm.com>
6578
6579         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6580         function.
6581         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6582         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6583         (aarch64_gdbarch_init): Add puth registers.
6584         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6585         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6586         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6587
6588 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6589             Jiong Wang  <jiong.wang@arm.com>
6590
6591         * aarch64-linux-nat.c
6592         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6593         * aarch64-linux-tdep.c
6594         (aarch64_linux_core_read_description): Likewise.
6595         (aarch64_linux_get_hwcap): New function.
6596         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6597         (aarch64_linux_get_hwcap): New declaration.
6598
6599 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6600             Jiong Wang  <jiong.wang@arm.com>
6601
6602         * aarch64-linux-nat.c
6603         (aarch64_linux_nat_target::read_description): Add pauth param.
6604         * aarch64-linux-tdep.c
6605         (aarch64_linux_core_read_description): Likewise.
6606         * aarch64-tdep.c (struct target_desc): Add in pauth.
6607         (aarch64_read_description): Add pauth param.
6608         (aarch64_gdbarch_init): Likewise.
6609         * aarch64-tdep.h (aarch64_read_description): Likewise.
6610         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6611         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6612         * features/Makefile: Add new files.
6613         * features/aarch64-pauth.c: New file.
6614         * features/aarch64-pauth.xml: New file.
6615
6616 2019-03-20  Tom Tromey  <tromey@adacore.com>
6617
6618         * infrun.c (handle_inferior_event): Rename from
6619         handle_inferior_event_1.  Create a scoped_value_mark.
6620         (handle_inferior_event): Remove.
6621
6622 2019-03-19  Tom Tromey  <tromey@adacore.com>
6623
6624         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6625         * infrun.h (print_stop_event): Add "displays" parameter.
6626         * infrun.c (print_stop_event): Add "displays" parameter.
6627
6628 2019-03-19  Pedro Alves  <palves@redhat.com>
6629
6630         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6631         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6632         to -1.  Fix TABs vs spaces.
6633         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6634         * tui/tui-out.h (tui_ui_out) Add intro comments.
6635         <m_line, m_start_of_line>: In-class initialize, and add describing
6636         comment.
6637
6638 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6639
6640         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6641         variable names.
6642         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6643
6644 2019-03-18  Pedro Alves  <palves@redhat.com>
6645             Eli Zaretskii <eliz@gnu.org>
6646
6647         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6648         m_line and m_start_of_line.
6649
6650 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6651
6652         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6653         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6654         it returns a newline.  This fixes a regression in TU mode, whereby
6655         the next line is output on the same screen line as the user input.
6656
6657 2019-03-18  Tom Tromey  <tromey@adacore.com>
6658
6659         * minsyms.c (minimal_symbol_reader::install): Remove call to
6660         obstack_blank.
6661
6662 2019-03-18  Pedro Alves  <palves@redhat.com>
6663
6664         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6665         New globals.
6666         (apply_style): New, factored out from ...
6667         (apply_ansi_escape): ... this.  Handle reverse video mode.
6668         (tui_set_reverse_mode): New function.
6669         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6670         * tui/tui-winsource.c (tui_show_source_line): Use
6671         tui_set_reverse_mode instead of setting A_STANDOUT.
6672         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6673         New setter methods.
6674
6675 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6676
6677         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6678         Handle tabs.
6679
6680 2019-03-18  Tom Tromey  <tromey@adacore.com>
6681
6682         * ada-lang.c (empty_array): Add "high" parameter.
6683         (ada_evaluate_subexp): Update.
6684
6685 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6686
6687         * unittests/string_view-selftests.c: Define
6688         _initialize_string_view_selftests unconditionally.
6689
6690 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6691
6692         PR gdb/24350
6693         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6694
6695 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6696
6697         PR gdb/24351
6698         * windows-nat.c (display_selector): Fix format specifiers.
6699
6700 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6701
6702         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6703         tui_refill_source_window instead of tui_refresh_win, to update the
6704         current execution line.  This fixes redisplay of the current line
6705         when stepping through the code with "next" or "step".
6706
6707 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6708
6709         * source-cache.c (source_cache::get_source_lines): Call
6710         find_source_lines to initialize s->nlines.  This fixes vertical
6711         scrolling of TUI source window when the DOWN arrow is pressed.
6712
6713 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6714
6715         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6716         linux-thread-db.c (_initialize_thread_db): Likewise.
6717
6718 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6719
6720         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6721         wclrtoeol in tui_show_source_line".  This reverts changes made in
6722         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6723
6724 2019-03-15  Tom Tromey  <tom@tromey.com>
6725
6726         * symtab.h (struct minimal_symbol): Derive from
6727         general_symbol_info.
6728         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6729         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6730         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6731         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6732         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6733         (MSYMBOL_SEARCH_NAME): Update.
6734         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6735         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6736         * minsyms.c (minimal_symbol_reader::record_full): Update.
6737
6738 2019-03-15  Tom Tromey  <tom@tromey.com>
6739
6740         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6741
6742 2019-03-15  Tom Tromey  <tom@tromey.com>
6743
6744         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6745         unique_xmalloc_ptr.
6746         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6747         Update.
6748         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6749         (build_minimal_symbol_hash_tables)
6750         (minimal_symbol_reader::install): Update.
6751
6752 2019-03-15  Tom Tromey  <tom@tromey.com>
6753
6754         * symtab.c (create_demangled_names_hash): Update.
6755         (symbol_set_names): Update.
6756         * objfiles.h (struct objfile_per_bfd_storage)
6757         <demangled_names_hash>: Now an htab_up.
6758         * objfiles.c (objfile_per_bfd_storage): Simplify.
6759
6760 2019-03-15  Tom Tromey  <tom@tromey.com>
6761
6762         * objfiles.h (struct objfile_per_bfd_storage): Declare
6763         destructor.
6764         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6765         New.
6766         (get_objfile_bfd_data): Use new.  Don't initialize
6767         language_of_main.
6768         (free_objfile_per_bfd_storage): Remove.
6769         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6770
6771 2019-03-15  Tom Tromey  <tom@tromey.com>
6772
6773         * symfile.c (reread_symbols): Update.
6774         * objfiles.c (objfile::objfile): Update.
6775         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6776         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6777         comment.
6778         (minimal_symbol_reader::install): Update.
6779         (terminate_minimal_symbol_table): Remove.
6780         * jit.c (jit_object_close_impl): Update.
6781
6782 2019-03-15  Tom Tromey  <tom@tromey.com>
6783
6784         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6785         initializations.
6786
6787 2019-03-15  Tom Tromey  <tom@tromey.com>
6788
6789         * objfiles.h (struct objfile_per_bfd_storage)
6790         <demangled_hash_languages>: Now a bitset.
6791         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6792         (lookup_minimal_symbol): Update.
6793
6794 2019-03-15  Tom Tromey  <tom@tromey.com>
6795
6796         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6797         Don't return the symbol.
6798         * coffread.c (record_minimal_symbol): Use record_full.
6799
6800 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6801
6802         The MS-Windows port of ncurses fails to switch to a color pair if
6803         one or both of the colors are the implicit default colors.  This
6804         change records the default colors when TUI is initialized, and
6805         then specifies them explicitly when a color pair uses the default
6806         colors.  This allows color styling in TUI mode on MS-Windows.
6807
6808         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6809         ncurses_norm_attr.
6810         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6811         colors in ncurses_norm_attr.
6812         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6813         "none", replace it with the default color recorded in
6814         ncurses_norm_attr.
6815
6816 2019-03-14  Tom Tromey  <tromey@adacore.com>
6817
6818         * source-cache.h (class source_cache) <get_source_lines>: Return
6819         std::string.
6820         * source-cache.c (source_cache::extract_lines): Handle case where
6821         first_pos==npos.  Return std::string.
6822         (source_cache::get_source_lines): Update.
6823
6824 2019-03-14  Tom Tromey  <tromey@adacore.com>
6825
6826         * NEWS: Add item for "style sources" commands.
6827         * source-cache.c (source_cache::get_source_lines): Check
6828         source_styling.
6829         * cli/cli-style.c (source_styling): New global.
6830         (_initialize_cli_style): Add "style sources" commands.
6831         (show_style_sources): New function.
6832         * cli/cli-style.h (source_styling): Declare.
6833
6834 2019-03-14  Pedro Alves  <palves@redhat.com>
6835             Tom Tromey  <tromey@adacore.com>
6836
6837         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6838         * tui/tui-winsource.c (tui_refill_source_window): New function,
6839         from...
6840         (tui_horizontal_source_scroll): ... here.  Move some logic.
6841         * cli/cli-style.c (set_style_enabled): Notify new observable.
6842         * tui/tui-hooks.c (tui_redisplay_source): New function.
6843         (tui_attach_detach_observers): Attach or detach
6844         tui_redisplay_source.
6845         * observable.h (source_styling_changed): New observable.
6846         * observable.c: Define source_styling_changed observable.
6847
6848 2019-03-13  Tom Tromey  <tromey@adacore.com>
6849
6850         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6851         (i386_gnu_nat_target::store_registers): Update.
6852         * target-debug.h (target_debug_print_std_string): New macro.
6853         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6854         * windows-tdep.c (display_one_tib): Update.
6855         * tui/tui-stack.c (tui_make_status_line): Update.
6856         * top.c (print_inferior_quit_action): Update.
6857         * thread.c (thr_try_catch_cmd): Update.
6858         (add_thread_with_info): Update.
6859         (thread_target_id_str): Update.
6860         (thr_try_catch_cmd): Update.
6861         (thread_command): Update.
6862         (thread_find_command): Update.
6863         * record-btrace.c (record_btrace_target::info_record)
6864         (record_btrace_resume_thread, record_btrace_target::resume)
6865         (record_btrace_cancel_resume, record_btrace_step_thread)
6866         (record_btrace_target::wait, record_btrace_target::wait)
6867         (record_btrace_target::wait, record_btrace_target::stop): Update.
6868         * progspace.c (print_program_space): Update.
6869         * process-stratum-target.c
6870         (process_stratum_target::thread_address_space): Update.
6871         * linux-fork.c (linux_fork_mourn_inferior)
6872         (detach_checkpoint_command, info_checkpoints_command)
6873         (linux_fork_context): Update.
6874         (linux_fork_detach): Update.
6875         (class scoped_switch_fork_info): Update.
6876         (delete_checkpoint_command): Update.
6877         * infrun.c (follow_fork_inferior): Update.
6878         (follow_fork_inferior): Update.
6879         (proceed_after_vfork_done): Update.
6880         (handle_vfork_child_exec_or_exit): Update.
6881         (follow_exec): Update.
6882         (displaced_step_prepare_throw): Update.
6883         (displaced_step_restore): Update.
6884         (start_step_over): Update.
6885         (resume_1): Update.
6886         (clear_proceed_status_thread): Update.
6887         (proceed): Update.
6888         (print_target_wait_results): Update.
6889         (do_target_wait): Update.
6890         (context_switch): Update.
6891         (stop_all_threads): Update.
6892         (restart_threads): Update.
6893         (finish_step_over): Update.
6894         (handle_signal_stop): Update.
6895         (switch_back_to_stepped_thread): Update.
6896         (keep_going_pass_signal): Update.
6897         (print_exited_reason): Update.
6898         (normal_stop): Update.
6899         * inferior.c (inferior_pid_to_str): Change return type.
6900         (print_selected_inferior): Update.
6901         (add_inferior): Update.
6902         (detach_inferior): Update.
6903         * dummy-frame.c (fprint_dummy_frames): Update.
6904         * dcache.c (dcache_info_1): Update.
6905         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6906         (btrace_fetch, btrace_clear): Update.
6907         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6908         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6909         type.
6910         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6911         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6912         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6913         * gdbarch.c, gdbarch.h: Rebuild.
6914         * gdbarch.sh (core_pid_to_str): Change return type.
6915         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6916         return type.
6917         (windows_nat_target::pid_to_str): Change return type.
6918         (windows_delete_thread): Update.
6919         (windows_nat_target::attach): Update.
6920         (windows_nat_target::files_info): Update.
6921         * target-delegates.c: Rebuild.
6922         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6923         return type.
6924         (sol_thread_target::pid_to_str): Change return type.
6925         * remote.c (class remote_target) <pid_to_str>: Change return
6926         type.
6927         (remote_target::pid_to_str): Change return type.
6928         (extended_remote_target::attach, remote_target::remote_stop_ns)
6929         (remote_target::remote_notif_remove_queued_reply)
6930         (remote_target::push_stop_reply, remote_target::disable_btrace):
6931         Update.
6932         (extended_remote_target::attach): Update.
6933         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6934         type.
6935         (gdbsim_target::pid_to_str): Change return type.
6936         * ravenscar-thread.c (struct ravenscar_thread_target)
6937         <pid_to_str>: Change return type.
6938         (ravenscar_thread_target::pid_to_str): Change return type.
6939         * procfs.c (class procfs_target) <pid_to_str>: Change return
6940         type.
6941         (procfs_target::pid_to_str): Change return type.
6942         (procfs_target::attach): Update.
6943         (procfs_target::detach): Update.
6944         (procfs_target::fetch_registers): Update.
6945         (procfs_target::store_registers): Update.
6946         (procfs_target::wait): Update.
6947         (procfs_target::files_info): Update.
6948         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6949         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6950         return type.
6951         (nto_procfs_target::pid_to_str): Change return type.
6952         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6953         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6954         return type.
6955         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6956         (exit_lwp): Update.
6957         (attach_proc_task_lwp_callback, get_detach_signal)
6958         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6959         (linux_nat_target::resume, wait_lwp, stop_callback)
6960         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6961         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6962         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6963         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6964         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6965         type.
6966         (inf_ptrace_target::attach): Update.
6967         (inf_ptrace_target::files_info): Update.
6968         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6969         type.
6970         (go32_nat_target::pid_to_str): Change return type.
6971         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6972         (gnu_nat_target::wait): Update.
6973         (gnu_nat_target::wait): Update.
6974         (gnu_nat_target::resume): Update.
6975         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6976         (fbsd_nat_target::wait): Update.
6977         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6978         type.
6979         (darwin_nat_target::attach): Update.
6980         * corelow.c (class core_target) <pid_to_str>: Change return type.
6981         (core_target::pid_to_str): Change return type.
6982         * target.c (normal_pid_to_str): Change return type.
6983         (default_pid_to_str): Likewise.
6984         (target_pid_to_str): Change return type.
6985         (target_translate_tls_address): Update.
6986         (target_announce_detach): Update.
6987         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6988         return type.
6989         (bsd_uthread_target::pid_to_str): Change return type.
6990         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6991         type.
6992         (bsd_kvm_target::pid_to_str): Change return type.
6993         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6994         return type.
6995         (aix_thread_target::pid_to_str): Change return type.
6996         * target.h (struct target_ops) <pid_to_str>: Change return type.
6997         (target_pid_to_str, normal_pid_to_str): Likewise.
6998         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6999         type.
7000         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7001         type.
7002         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7003         return type.
7004         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7005         type.
7006         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7007         type.
7008         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7009         return type.
7010
7011 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7012
7013         * NEWS: Mention that the new default MI version is 3.  Mention
7014         changes to the output of commands and events that deal with
7015         multi-location breakpoints.
7016         * breakpoint.c: Include "mi/mi-out.h".
7017         (print_one_breakpoint): Change output syntax if using MI version
7018         >= 3.
7019         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7020         New.
7021         (mi_multi_location_breakpoint_output_fixed): New.
7022         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7023         (mi_cmd_fix_multi_location_breakpoint_output): New.
7024         (mi_multi_location_breakpoint_output_fixed): New.
7025         * mi/mi-cmds.c (mi_cmds): Register command
7026         -fix-multi-location-breakpoint-output.
7027         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7028         interpreter "mi".
7029
7030 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7031
7032         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7033         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7034         instantiate mi_ui_out based on interpreter name.
7035         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7036         * mi/mi-main.c (mi_load_progress): Likewise.
7037
7038 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7039
7040         * NEWS: Combine separate "New targets" sections for 8.3.
7041
7042 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7043
7044         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7045         (ppcfbsd_init_abi): Install gdbarch
7046         "fetch_tls_load_module_address" and "get_thread_local_address"
7047         methods.
7048
7049 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7050
7051         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7052         (riscv_fbsd_init_abi): Install gdbarch
7053         "fetch_tls_load_module_address" and "get_thread_local_address"
7054         methods.
7055
7056 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7057
7058         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7059         (i386fbsd_init_abi): Install gdbarch
7060         "fetch_tls_load_module_address" and "get_thread_local_address"
7061         methods.
7062
7063 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7064
7065         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7066         (amd64fbsd_init_abi): Install gdbarch
7067         "fetch_tls_load_module_address" and "get_thread_local_address"
7068         methods.
7069
7070 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7071
7072         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7073         (struct fbsd_pspace_data): New type.
7074         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7075         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7076         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7077         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7078         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7079
7080 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7081
7082         * gdbtypes.c (lookup_struct_elt): New function.
7083         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7084         * gdbtypes.h (struct struct_elt): New type.
7085         (lookup_struct_elt): New prototype.
7086
7087 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7088
7089         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7090         remove disabled code block.
7091
7092 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7093
7094         * gdbarch.sh (get_thread_local_address): New method.
7095         * gdbarch.h, gdbarch.c: Regenerate.
7096         * target.c (target_translate_tls_address): Use
7097         gdbarch_get_thread_local_address if present instead of
7098         target::get_thread_local_address.
7099
7100 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7101
7102         * target.h (target::get_thread_local_address): Update comment.
7103
7104 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7105
7106         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7107         objfile->separate_debug_objfile_backlink if not NULL.
7108
7109 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7110
7111         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7112         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7113         (amd64bsd_store_inferior_registers): Likewise.
7114         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7115         Enable segment base registers.
7116         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7117         PT_GETFSBASE and PT_GETGSBASE.
7118         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7119         PT_SETGSBASE.
7120         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7121         segment base registers.
7122         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7123
7124 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7125
7126         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7127         Update calls to i386_target_description to add 'segments'
7128         parameter.
7129         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7130         add segment base registers.
7131         * arch/i386.c (i386_create_target_description): Add 'segments'
7132         parameter to enable segment base registers.
7133         * arch/i386.h (i386_create_target_description): Likewise.
7134         * features/i386/32bit-segments.xml: New file.
7135         * features/i386/32bit-segments.c: Generate.
7136         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7137         call to i386_target_description to add 'segments' parameter.
7138         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7139         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7140         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7141         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7142         if feature is present.
7143         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7144         Add 'segments' parameter to call to i386_target_description.
7145         (i386_target_description): Add 'segments' parameter to enable
7146         segment base registers.
7147         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7148         to call to i386_target_description.
7149         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7150         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7151         Define I386_NUM_REGS.
7152         (i386_target_description): Add 'segments' parameter to enable
7153         segment base registers.
7154
7155 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7156
7157         PR/24325
7158         * source-cache.c: #undef open and close, to avoid unresolved
7159         externals during linking.
7160
7161 2019-03-12  Tom Tromey  <tromey@adacore.com>
7162
7163         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7164         const.  Add initializers.
7165         (_initialize_remote): Don't initialize ptid globals.
7166
7167 2019-03-12  Pedro Alves  <palves@redhat.com>
7168
7169         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7170
7171 2019-03-12  Pedro Alves  <palves@redhat.com>
7172
7173         * cp-name-parser.y (main): Remove unused 'len' variable.
7174
7175 2019-03-12  Tom Tromey  <tromey@adacore.com>
7176
7177         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7178         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7179
7180 2019-03-12  Tom Tromey  <tromey@adacore.com>
7181
7182         * linux-nat.c (iterate_over_lwps): Update.
7183         (stop_callback): Remove parameter.
7184         (stop_wait_callback, detach_callback, resume_set_callback)
7185         (select_singlestep_lwp_callback, set_ignore_sigint)
7186         (status_callback, resumed_callback, resume_clear_callback)
7187         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7188         data parameter.
7189         (linux_nat_target::detach, linux_nat_target::resume)
7190         (linux_stop_and_wait_all_lwps, select_event_lwp)
7191         (linux_nat_filter_event, linux_nat_wait_1)
7192         (linux_nat_target::kill, linux_nat_target::stop)
7193         (linux_nat_target::stop): Update.
7194         (linux_nat_resume_callback): Change type.
7195         (resume_stopped_resumed_lwps, count_events_callback)
7196         (select_event_lwp_callback): Likewise.
7197         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7198         * arm-linux-nat.c (struct update_registers_data): Remove.
7199         (update_registers_callback): Change type.
7200         (arm_linux_insert_hw_breakpoint1): Update.
7201         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7202         parameter.
7203         (x86_linux_dr_set_addr): Update.
7204         (x86_linux_dr_set_control): Update.
7205         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7206         (iterate_over_lwps): Use gdb::function_view.
7207         * nat/aarch64-linux-hw-point.c (struct
7208         aarch64_dr_update_callback_param): Remove.
7209         (debug_reg_change_callback): Change type.
7210         (aarch64_notify_debug_reg_change): Update.
7211         * s390-linux-nat.c (s390_refresh_per_info): Update.
7212
7213 2019-03-11  Tom Tromey  <tromey@adacore.com>
7214
7215         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7216         redundant assignment to "this_cu".
7217
7218 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7219
7220         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7221
7222 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7223
7224         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7225         from...
7226         (rank_one_type): ... this.
7227
7228 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7229
7230         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7231         from...
7232         (rank_one_type): ... this.
7233
7234 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7235
7236         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7237         from...
7238         (rank_one_type): ... this.
7239
7240 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7241
7242         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7243         from...
7244         (rank_one_type): ... this.
7245
7246 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7247
7248         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7249         from...
7250         (rank_one_type): ... this.
7251
7252 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7253
7254         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7255         from...
7256         (rank_one_type): ... this.
7257
7258 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7259
7260         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7261         from...
7262         (rank_one_type): ... this.
7263
7264 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7265
7266         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7267         from...
7268         (rank_one_type): ... this.
7269
7270 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7271
7272         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7273         from...
7274         (rank_one_type): ... this.
7275
7276 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7277
7278         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7279         from...
7280         (rank_one_type): ... this.
7281
7282 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7283
7284         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7285         from...
7286         (rank_one_type): ... this.
7287
7288 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7289
7290         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7291         from...
7292         (rank_one_type): ... this.
7293
7294 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7295
7296         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7297         inferior-events' shows the example events.
7298
7299 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7300
7301         Support styling on native MS-Windows console
7302
7303         PR/24315
7304         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7305         on MS-Windows if $TERM is not defined.
7306
7307         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7308
7309         * posix-hdep.c (gdb_console_fputs):
7310         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7311         functions.
7312         * ui-file.h (gdb_console_fputs): Add prototype.
7313
7314         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7315         back to fputs only if the former returns zero.
7316
7317 2019-03-07  Tom Tromey  <tom@tromey.com>
7318
7319         * symmisc.c (print_symbol_bcache_statistics): Update.
7320         (print_objfile_statistics): Update.
7321         * symfile.c (allocate_symtab): Update.
7322         * stabsread.c: Don't include bcache.h.
7323         * psymtab.h (struct psymbol_bcache): Don't declare.
7324         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7325         (psymbol_bcache_init, psymbol_bcache_free)
7326         (psymbol_bcache_get_bcache): Don't declare.
7327         * psymtab.c (struct psymbol_bcache): Remove.
7328         (psymtab_storage::psymtab_storage): Update.
7329         (psymtab_storage::~psymtab_storage): Update.
7330         (psymbol_bcache_init, psymbol_bcache_free)
7331         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7332         (add_psymbol_to_bcache): Update.
7333         (allocate_psymtab): Update.
7334         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7335         macro_cache>: No longer pointers.
7336         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7337         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7338         * macrotab.c (macro_bcache): Update.
7339         * macroexp.c: Don't include bcache.h.
7340         * gdbtypes.c (check_types_worklist): Update.
7341         (types_deeply_equal): Remove TRY/CATCH.  Update.
7342         * elfread.c (elf_symtab_read): Update.
7343         * dwarf2read.c: Don't include bcache.h.
7344         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7345         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7346         (print_bcache_statistics, bcache_memory_used): Don't declare.
7347         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7348         methods.  Rename all data members.
7349         * bcache.c (struct bcache): Move to bcache.h.
7350         (bcache::expand_hash_table): Rename from expand_hash_table.
7351         (bcache): Remove.
7352         (bcache::insert): Rename from bcache_full.
7353         (bcache::compare): Rename from bcache_compare.
7354         (bcache_xmalloc): Remove.
7355         (bcache::~bcache): Rename from bcache_xfree.
7356         (bcache::print_statistics): Rename from print_bcache_statistics.
7357         (bcache::memory_used): Rename from bcache_memory_used.
7358
7359 2019-03-07  Pedro Alves  <palves@redhat.com>
7360
7361         * infrun.c (normal_stop): Also check for
7362         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7363
7364 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7365
7366         * f-lang.c (value_from_host_double): Moved to...
7367         * value.c (value_from_host_double): ...here.
7368         * value.h (value_from_host_double): Declare.
7369         * guile/scm-math.c (vlscm_convert_typed_number): Use
7370         value_from_host_double.
7371         (vlscm_convert_number): Likewise.
7372         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7373         * python/py-value.c (convert_value_from_python): Likewise.
7374
7375 2019-03-06  Tom Tromey  <tom@tromey.com>
7376
7377         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7378
7379 2019-03-06  Tom Tromey  <tom@tromey.com>
7380
7381         * utils.h (free_current_contents): Don't declare.
7382         * utils.c (free_current_contents): Remove.
7383
7384 2019-03-06  Tom Tromey  <tom@tromey.com>
7385
7386         * top.c (quit_force): Update.
7387         * main.c (captured_command_loop): Update.
7388         * common/new-op.c (operator new): Update.
7389         * common/common-exceptions.c (struct catcher)
7390         <save_cleanup_chain>: Remove member.
7391         (exceptions_state_mc_init): Update.
7392         (exception_try_scope_entry): Return nullptr.
7393         (exception_try_scope_exit, exception_rethrow)
7394         (throw_exception_sjlj, throw_exception_cxx): Update.
7395         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7396         (all_cleanups, do_cleanups, discard_cleanups)
7397         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7398         (restore_cleanups, restore_final_cleanups): Don't declare.
7399         (do_final_cleanups): Remove parameter.
7400         * common/cleanups.c (cleanup_chain, make_cleanup)
7401         (make_cleanup_dtor, all_cleanups, do_cleanups)
7402         (discard_my_cleanups, discard_cleanups)
7403         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7404         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7405         (null_cleanup): Remove.
7406         (do_final_cleanups): Remove parameter.
7407
7408 2019-03-06  Tom Tromey  <tom@tromey.com>
7409
7410         * remote.c (remote_target::remote_parse_stop_reply): Use
7411         unique_xmalloc_ptr.
7412
7413 2019-03-06  Tom Tromey  <tom@tromey.com>
7414
7415         * stabsread.c (struct stabs_field_info): Rename from field_info.
7416         <list, fnlist>: Add initializers.
7417         <obstack>: New member.
7418         (read_member_functions, read_struct_fields, read_baseclasses):
7419         Allocate on obstack.  Don't use cleanups.
7420         (read_one_struct_field, read_member_functions, read_struct_fields)
7421         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7422         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7423         (read_struct_type): Update.
7424
7425 2019-03-06  Tom Tromey  <tom@tromey.com>
7426
7427         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7428         * common/filestuff.h (make_cleanup_close): Don't declare.
7429         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7430         Remove.
7431
7432 2019-03-06  Tom Tromey  <tom@tromey.com>
7433
7434         * solib-aix.c: Use make_scope_exit.
7435
7436 2019-03-06  Tom Tromey  <tom@tromey.com>
7437
7438         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7439         Use make_scope_exit.
7440
7441 2019-03-06  Tom Tromey  <tom@tromey.com>
7442
7443         * solib-svr4.c (disable_probes_interface): Remove parameter.
7444         (svr4_handle_solib_event): Use make_scope_exit.
7445
7446 2019-03-06  Tom Tromey  <tom@tromey.com>
7447
7448         * remote.c (struct stop_reply_deleter): Remove.
7449         (stop_reply_up): Update.
7450         (struct stop_reply): Derive from notif_event.  Don't typedef.
7451         <regcache>: Now a std::vector.
7452         (stop_reply_xfree): Remove.
7453         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7454         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7455         (remote_target::discard_pending_stop_replies): Use delete.
7456         (remote_target::remote_parse_stop_reply): Update.
7457         (remote_target::process_stop_reply): Update.
7458         * remote-notif.h (struct notif_event): Add virtual destructor.
7459         Remove "dtr" member.
7460         (struct notif_client) <alloc_event>: Return a unique_ptr.
7461         (notif_event_xfree): Don't declare.
7462         (notif_event_up): New typedef.
7463         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7464         (notif_event_xfree, do_notif_event_xfree): Remove.
7465         (remote_notif_state_xfree): Update.
7466
7467 2019-03-06  Tom Tromey  <tom@tromey.com>
7468
7469         * infrun.c (displaced_step_clear_cleanup): Now a
7470         forward_scope_exit type.
7471         (displaced_step_prepare_throw): Update.
7472         (displaced_step_fixup): Update.
7473
7474 2019-03-06  Tom Tromey  <tom@tromey.com>
7475
7476         * inferior.h (class inferior): Update comment.
7477         * gdbthread.h (class thread_info): Update comment.
7478
7479 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7480             Tom Tromey  <tom@tromey.com>
7481
7482         * stabsread.h (struct stab_section_list): Remove.
7483         (coffstab_build_psymtabs): Update.
7484         * dbxread.c (symbuf_sections): Now a std::vector.
7485         (sect_idx): New global.
7486         (fill_symbuf): Update.
7487         (coffstab_build_psymtabs): Change type of stabsects parameter.
7488         Update.
7489         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7490         std::vector.
7491         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7492         (coff_locate_sections): Update.
7493         (coff_symfile_read): Remove cleanups.  Update.
7494         (init_stringtab): Add storage parameter.
7495         (free_stringtab, free_stringtab_cleanup): Remove.
7496         (init_lineno): Add storage parameter.
7497         (free_linetab, free_linetab_cleanup): Remove.
7498
7499 2019-03-06  Pedro Alves  <palves@redhat.com>
7500
7501         * linux-fork.c (fork_info::clobber_regs): Delete.
7502         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7503         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7504         comment.  Adjust.
7505         (scoped_switch_fork_info::scoped_switch_fork_info)
7506         (checkpoint_command, linux_fork_context): Adjust
7507         fork_save_infrun_state calls.
7508
7509 2019-03-06  Pedro Alves  <palves@redhat.com>
7510
7511         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7512         (inf_has_multiple_threads): Return 'bool' and rewrite using
7513         inferior_info::threads().
7514
7515 2019-03-06  Pedro Alves  <palves@redhat.com>
7516
7517         * linux-fork.c: Include <list>.
7518         (fork_list): Now a std::list instance.
7519         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7520         (forks_exist_p, find_last_fork): Adjust.
7521         (new_fork): Delete.
7522         (one_fork_p): New.
7523         (add_fork): Adjust.
7524         (free_fork): Delete, folded into fork_info::~fork_info().
7525         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7526         Adjust.
7527         (init_fork_list): Delete.
7528         (linux_fork_killall, linux_fork_mourn_inferior)
7529         (linux_fork_detach, info_checkpoints_command): Adjust.
7530         (_initialize_linux_fork): No longer call init_fork_list.
7531
7532 2019-03-06  Pedro Alves  <palves@redhat.com>
7533
7534         * linux-fork.c (new_fork): New, split out of ...
7535         (add_fork): ... this.  Return void.  Move "first fork" special
7536         case from here, to ...
7537         (checkpoint_command): ... here.
7538         * linux-linux.h (add_fork): Return void.
7539
7540 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7541
7542         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7543
7544 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7545             Chris January  <chris.january@arm.com>
7546             David Lecomber  <david.lecomber@arm.com>
7547
7548         * f-exp.y: New token, UNOP_INTRINSIC.
7549         (exp): New pattern using UNOP_INTRINSIC token.
7550         (f77_keywords): Add 'abs' keyword.
7551         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7552         (value_from_host_double): New function.
7553         (evaluate_subexp_f): Support UNOP_ABS.
7554
7555 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7556
7557         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7558         types.
7559
7560 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7561
7562         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7563         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7564         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7565
7566 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7567
7568         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7569
7570 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7571             Chris January  <chris.january@arm.com>
7572
7573         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7574         * f-exp.y: Define 'KIND' token.
7575         (exp): New pattern for KIND expressions.
7576         (ptype): Handle types with a kind extension.
7577         (direct_abs_decl): Extend to spot kind extensions.
7578         (f77_keywords): Add 'kind' to the list.
7579         (push_kind_type): New function.
7580         (convert_to_kind_type): New function.
7581         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7582         * parse.c (operator_length_standard): Likewise.
7583         * parser-defs.h (enum type_pieces): Add tp_kind.
7584         * std-operator.def: Add UNOP_KIND.
7585
7586 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7587
7588         * f-exp.y (f_parse): Set yydebug.
7589
7590 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7591
7592         * f-lang.c (evaluate_subexp_f): New function.
7593         (exp_descriptor_f): New global.
7594         (f_language_defn): Use exp_descriptor_f instead of
7595         exp_descriptor_standard.
7596
7597 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7598
7599         * f-exp.y (struct token): Add comments.
7600         (dot_ops): Remove uppercase versions and the end marker.
7601         (f77_keywords): Likewise.
7602         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7603         entries in the dot_ops array are case insensitive, and use
7604         strncasecmp to compare strings.  Also some whitespace cleanup in
7605         this area.  Similar for the f77_keywords array, except entries in
7606         this list might be case sensitive.
7607
7608 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7609
7610         * f-exp.y (struct f77_boolean_val): Add comments.
7611         (boolean_values): Remove uppercase versions, and end marker.
7612         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7613         and use strncasecmp to achieve case insensitivity.  Additionally,
7614         perform whitespace cleanup around this code.
7615
7616 2019-03-06  Tom Tromey  <tromey@adacore.com>
7617
7618         * remote-sim.c (gdbsim_target_open): Use result of
7619         gdb_argv::release.
7620
7621 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7622         Dirk Schubert  <dirk.schubert@arm.com>
7623         Chris January  <chris.january@arm.com>
7624
7625         * eval.c (evaluate_subexp_standard): Call Fortran argument
7626         wrapping logic.
7627         * f-lang.c (struct value): A value which can be passed into a
7628         Fortran function call.
7629         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7630         where appropriate.
7631         (struct type): Value ready for a Fortran function call.
7632         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7633         is needed.
7634         * f-lang.h (fortran_argument_convert): Declaration.
7635         (fortran_preserve_arg_pointer): Declaration.
7636         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7637
7638 2019-03-05  Tom Tromey  <tromey@adacore.com>
7639
7640         * python/py-prettyprint.c (print_string_repr): Remove #if.
7641         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7642
7643 2019-03-05  Tom Tromey  <tromey@adacore.com>
7644
7645         * target.c (the_dummy_target): Move later.  Change type to
7646         "dummy_target".
7647         (initialize_targets): Don't initialize the_dummy_target.
7648
7649 2019-03-05  Tom Tromey  <tromey@adacore.com>
7650
7651         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7652         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7653
7654 2019-03-05  Tom Tromey  <tromey@adacore.com>
7655
7656         * windows-nat.c (windows_nat_target::attach)
7657         (windows_nat_target::detach): Don't call gdb_flush.
7658         * valprint.c (generic_val_print, val_print, val_print_string):
7659         Don't call gdb_flush.
7660         * utils.c (defaulted_query): Don't call gdb_flush.
7661         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7662         * target.c (target_announce_detach): Don't call gdb_flush.
7663         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7664         * remote.c (extended_remote_target::attach): Don't call
7665         gdb_flush.
7666         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7667         * printcmd.c (do_examine): Don't call gdb_flush.
7668         (info_display_command): Don't call gdb_flush.
7669         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7670         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7671         * memattr.c (info_mem_command): Don't call gdb_flush.
7672         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7673         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7674         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7675         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7676         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7677         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7678         (gnu_nat_target::detach): Don't call gdb_flush.
7679         * f-valprint.c (f_val_print): Don't call gdb_flush.
7680         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7681         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7682         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7683         gdb_flush.
7684         * c-valprint.c (c_val_print): Don't call gdb_flush.
7685         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7686
7687 2019-03-05  Tom Tromey  <tromey@adacore.com>
7688
7689         * varobj.c (update_dynamic_varobj_children): Update.
7690         (install_default_visualizer): Use reset, not release.
7691         * value.c (set_internalvar): Update.
7692         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7693         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7694         ATTRIBUTE_UNUSED_RESULT.
7695
7696 2019-03-05  Tom Tromey  <tromey@adacore.com>
7697
7698         * remote.c (class scoped_remote_fd) <release>: Add
7699         ATTRIBUTE_UNUSED_RESULT.
7700
7701 2019-03-05  Tom Tromey  <tromey@adacore.com>
7702
7703         * macroexp.c (struct macro_buffer) <release>: Add
7704         ATTRIBUTE_UNUSED_RESULT.
7705
7706 2019-03-05  Tom Tromey  <tromey@adacore.com>
7707
7708         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7709         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7710         ATTRIBUTE_UNUSED_RESULT.
7711
7712 2019-03-05  Tom Tromey  <tromey@adacore.com>
7713
7714         * common/scoped_fd.h (class scoped_fd) <release>: Add
7715         ATTRIBUTE_UNUSED_RESULT.
7716
7717 2019-03-05  Tom Tromey  <tromey@adacore.com>
7718
7719         * parser-defs.h (struct parser_state) <release>: Add
7720         ATTRIBUTE_UNUSED_RESULT.
7721
7722 2019-03-05  Tom Tromey  <tromey@adacore.com>
7723
7724         * utils.h (class gdb_argv) <release>: Add
7725         ATTRIBUTE_UNUSED_RESULT.
7726         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7727
7728 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7729
7730         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7731         for-loop range, to avoid compiler warnings.
7732
7733         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7734         avoid compiler warnings about unused variables.
7735
7736         * NEWS: Mention end of support for native debugging on MS-Windows
7737         before XP.
7738
7739         PR gdb/24292
7740         * common/netstuff.c:
7741         * gdbserver/gdbreplay.c
7742         * gdbserver/remote-utils.c:
7743         * ser-tcp.c:
7744         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7745         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7746         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7747         'getaddrinfo' and 'freeaddrinfo' were not available before
7748         Windows XP, and mingw.org's MinGW headers by default define
7749         _WIN32_WINNT to 0x500.
7750
7751 2019-03-01  Gary Benson <gbenson@redhat.com>
7752
7753         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7754
7755 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7756             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7757
7758         PR gdb/8527
7759         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7760         set_sigint_trap, clear_sigint_trap.
7761
7762 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7763
7764         * target.c (target_detach): Clear the regcache and the
7765         frame cache.
7766
7767 2019-02-27  Pedro Alves  <palves@redhat.com>
7768
7769         * utils.c (set_screen_size): When we cap the height/width sizes,
7770         tweak the corresponding command variable to show "unlimited":
7771
7772 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7773             Pedro Alves  <palves@redhat.com>
7774
7775         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7776         before calling rl_set_screen_size.
7777
7778 2019-02-27  Tom Tromey  <tromey@adacore.com>
7779
7780         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7781         define.
7782         * python/py-value.c: Remove Python 2.4 workaround.
7783         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7784         workaround.
7785         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7786         Python 2.4 workaround.
7787         * python/python-internal.h: Remove Python 2.4 comment.
7788         (Py_ssize_t): Don't define.
7789         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7790         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7791         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7792         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7793         * python/python.c (do_start_initialization): Remove Python 2.4
7794         workaround.
7795         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7796         (print_children): Remove Python 2.4 workaround.
7797         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7798         workaround.
7799         (CHARBUFFERPROC_NAME): Remove.
7800         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7801         Python 2.4 workaround.
7802
7803 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7804
7805         * NEWS: Note minimum Python version.
7806
7807 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7808
7809         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7810         code from these functions.  Remove corresponding ifdefs.  Use
7811         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7812         Remove gotos and target of gotos.
7813         (infpy_search_memory): Likewise.
7814
7815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7816
7817         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7818         (hppa_gdbarch_init): Don't register deleted functions with
7819         gdbarch.
7820
7821 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7822
7823         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7824         (h8300_unwind_sp): Delete.
7825         (h8300_dummy_id): Delete.
7826         (h8300_gdbarch_init): Don't register deleted functions with
7827         gdbarch.
7828
7829 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7830
7831         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7832         (ft32_unwind_pc): Delete.
7833         (ft32_unwind_sp): Delete.
7834         (ft32_gdbarch_init): Don't register deleted functions with
7835         gdbarch.
7836
7837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7838
7839         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7840         (frv_unwind_pc): Delete.
7841         (frv_unwind_sp): Delete.
7842         (frv_gdbarch_init): Don't register deleted functions with
7843         gdbarch.
7844
7845 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7846
7847         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7848         (riscv_unwind_pc): Delete.
7849         (riscv_unwind_sp): Delete.
7850         (riscv_gdbarch_init): Don't register deleted functions with
7851         gdbarch.
7852
7853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7854
7855         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7856         (csky_unwind_pc): Delete.
7857         (csky_unwind_sp): Delete.
7858         (csky_gdbarch_init): Don't register deleted functions with
7859         gdbarch.
7860
7861 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7862
7863         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7864         (cris_unwind_pc): Delete.
7865         (cris_unwind_sp): Delete.
7866         (cris_gdbarch_init): Don't register deleted functions with
7867         gdbarch.
7868
7869 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7870
7871         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7872         (bfin_unwind_pc): Delete.
7873         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7874
7875 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7876
7877         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7878         (arm_unwind_pc): Delete.
7879         (arm_unwind_sp): Delete.
7880         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7881
7882 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7883
7884         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7885         (arc_unwind_pc): Delete.
7886         (arc_unwind_sp): Delete.
7887         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7888
7889 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7890
7891         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7892         (alpha_unwind_pc): Delete.
7893         (alpha_gdbarch_init): Don't register deleted functions with
7894         gdbarch.
7895
7896 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7897
7898         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7899         (aarch64_unwind_pc): Delete.
7900         (aarch64_unwind_sp): Delete.
7901         (aarch64_gdbarch_init): Don't register deleted functions with
7902         gdbarch.
7903
7904 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7905
7906         * gdbtypes.c (type_align): Don't consider static members when
7907         computing structure alignment.
7908
7909 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7910
7911         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7912         return 0 for other types.
7913         * arch-utils.c (default_type_align): Always return 0.
7914         * gdbarch.h: Regenerate.
7915         * gdbarch.sh (type_align): Extend comment.
7916         * gdbtypes.c (type_align): Add additional comments, always call
7917         gdbarch_type_align before applying the default rules.
7918         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7919         generic code will then apply a suitable default.
7920         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7921         types, return 0 for other types.
7922
7923 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7924
7925         * NEWS: Create a new section for the next release branch.
7926         Rename the section of the current branch, now that it has
7927         been cut.
7928
7929 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7930
7931         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7932         * version.in: Bump version to 8.3.50.DATE-git.
7933
7934 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7935
7936         * aix-thread.c (ptid_cmp): Remove unused variable.
7937         (get_signaled_thread): Likewise.
7938         (store_regs_user_thread): Likewise.
7939         (store_regs_kernel_thread): Likewise.
7940         (fetch_regs_kernel_thread): Remove shadowed variable.
7941
7942 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7943
7944         * features/riscv/32bit-cpu.xml: Add register numbers.
7945         * features/riscv/32bit-fpu.c: Regenerate.
7946         * features/riscv/32bit-fpu.xml: Add register numbers.
7947         * features/riscv/64bit-cpu.xml: Add register numbers.
7948         * features/riscv/64bit-fpu.c: Regenerate.
7949         * features/riscv/64bit-fpu.xml: Add register numbers.
7950
7951 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7952
7953         * NEWS: Mention two argument form of gdb.Value constructor.
7954         * python/py-value.c (convert_buffer_and_type_to_value): New
7955         function.
7956         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7957         Add support for handling an optional second argument.  Call
7958         convert_buffer_and_type_to_value as appropriate.
7959         * python/python-internal.h (Py_buffer_deleter): New struct.
7960         (Py_buffer_up): New typedef.
7961
7962 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7963
7964         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7965         instead of releasing ownership.
7966
7967 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7968
7969         * dwarf2read.c (open_and_init_dwp_file): Call
7970         elf_numsections instead of bfd_count_sections to initialize
7971         dwp_file->num_sections.
7972
7973 2019-02-25  Tom Tromey  <tromey@adacore.com>
7974
7975         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7976
7977 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7978
7979         * gcore.in: Add '--readnever' option when invoking GDB.
7980
7981 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7982
7983         * MAINTAINERS: Update my email address.
7984
7985 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7986
7987         * build-id.c (build_id_to_debug_bfd_1): New function.
7988         (build_id_to_debug_bfd): Look for separate debug file in
7989         sysroot.
7990
7991 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7992
7993         * gdbarch.sh: Update the copyright year range that is placed into
7994         generated files.
7995
7996 2019-02-22  Keith Seitz  <keiths@redhat.com>
7997
7998         PR symtab/23853
7999         * linespec.c (create_sals_line_offset): Search for the default
8000         symtab's filename instead of its fullname.
8001
8002 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8003
8004         * NEWS: Update style defaults.
8005
8006 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8007
8008         * main.c (captured_main_1): Disable styling in batch mode.
8009
8010 2019-02-20  Tom Tromey  <tom@tromey.com>
8011
8012         * symtab.c (symtab_symbol_info): Fix typos.
8013
8014 2019-02-20  Tom Tromey  <tromey@adacore.com>
8015
8016         * findcmd.c (_initialize_mem_search): Use upper case for
8017         metasyntactic variables.
8018
8019 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8020
8021         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8022         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8023
8024 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8025
8026         * top.h (source_file_name): Change to std::string.
8027         * top.c (source_file_name): Likewise.
8028         (command_line_input): Adjust.
8029         * cli/cli-script.c (script_from_file): Adjust.
8030
8031 2019-02-19  Tom Tromey  <tromey@adacore.com>
8032
8033         * ravenscar-thread.c
8034         (ravenscar_thread_target::update_thread_list): Don't call
8035         ada_build_task_list.
8036         * ada-lang.h (ada_build_task_list): Don't declare.
8037         * ada-tasks.c (struct ada_tasks_inferior_data)
8038         <task_list_valid_p>: Now bool.
8039         (read_known_tasks, ada_task_list_changed)
8040         (ada_tasks_invalidate_inferior_data): Update.
8041         (read_known_tasks_array): Return bool.
8042         (read_known_tasks_list): Likewise.
8043         (read_known_tasks): Return void.
8044         (ada_build_task_list): Now static.
8045
8046 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8047
8048         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8049         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8050
8051 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8052
8053         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8054         variant for ada_tasks_pspace_data_handle and
8055         ada_tasks_inferior_data_handle.
8056         (ada_tasks_pspace_data_cleanup): New function.
8057         (ada_tasks_inferior_data_cleanup): New function.
8058
8059 2019-02-17  Tom Tromey  <tom@tromey.com>
8060
8061         * macrotab.h (macro_source_fullname): Return a std::string.
8062         * macrotab.c (macro_include, check_for_redefinition)
8063         (macro_undef, macro_lookup_definition, foreach_macro)
8064         (foreach_macro_in_scope): Update.
8065         (macro_source_fullname): Return a std::string.
8066         * macrocmd.c (show_pp_source_pos): Update.
8067
8068 2019-02-17  Tom Tromey  <tom@tromey.com>
8069
8070         * macrocmd.c (show_pp_source_pos): Style the file names.
8071
8072 2019-02-17  Tom Tromey  <tom@tromey.com>
8073
8074         PR tui/24197:
8075         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8076
8077 2019-02-17  Tom Tromey  <tom@tromey.com>
8078
8079         * ada-lang.c (user_select_syms): Use filtered printing.
8080         * utils.c (wrap_style): New global.
8081         (desired_style): Remove.
8082         (emit_style_escape): Add stream parameter.
8083         (set_output_style, reset_terminal_style, prompt_for_continue):
8084         Update.
8085         (flush_wrap_buffer): Only flush gdb_stdout.
8086         (wrap_here): Set wrap_style.
8087         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8088         treat escape sequences as a character.  Change when wrap buffer is
8089         flushed.
8090         (fputs_styled): Do not set the output style when the default is
8091         requested.
8092         * ui-style.h (struct ui_file_style) <is_default>: New method.
8093         * source.c (print_source_lines_base): Emit escape sequences in one
8094         piece.
8095
8096 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8097
8098         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8099         integers and enumeration types.
8100
8101 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8102
8103         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8104         instead of lookup_symbol_in_language
8105         (do_exact_match): New function.
8106         (ada_get_symbol_name_matcher): Return do_exact_match when
8107         doing a verbatim match.
8108
8109 2019-02-15  Tom Tromey  <tromey@adacore.com>
8110
8111         * ravenscar-thread.c (ravenscar_thread_target::resume)
8112         (ravenscar_thread_target::wait): Special case wildcard requests.
8113
8114 2019-02-15  Tom Tromey  <tromey@adacore.com>
8115
8116         * ravenscar-thread.c (base_ptid): Remove.
8117         (struct ravenscar_thread_target) <close>: New method.
8118         <m_base_ptid>: New member.
8119         <update_inferior_ptid, active_task, task_is_currently_active,
8120         runtime_initialized>: Declare methods.
8121         <ravenscar_thread_target>: Add constructor.
8122         (ravenscar_thread_target::task_is_currently_active)
8123         (ravenscar_thread_target::update_inferior_ptid)
8124         (ravenscar_runtime_initialized): Rename.  Now methods.
8125         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8126         (ravenscar_thread_target::update_thread_list): Update.
8127         (ravenscar_thread_target::active_task): Now method.
8128         (ravenscar_thread_target::store_registers)
8129         (ravenscar_thread_target::prepare_to_store)
8130         (ravenscar_thread_target::prepare_to_store)
8131         (ravenscar_thread_target::mourn_inferior): Update.
8132         (ravenscar_inferior_created): Use "new" to create target.
8133         (ravenscar_thread_target::get_ada_task_ptid): Update.
8134         (_initialize_ravenscar): Don't initialize base_ptid.
8135         (ravenscar_ops): Remove global.
8136
8137 2019-02-15  Tom Tromey  <tromey@adacore.com>
8138
8139         * target.h (push_target): Declare new overload.
8140         * target.c (push_target): New overload, taking an rvalue reference.
8141         * remote.c (remote_target::open_1): Use push_target overload.
8142         * corelow.c (core_target_open): Use push_target overload.
8143
8144 2019-02-15  Tom Tromey  <tromey@adacore.com>
8145
8146         * ravenscar-thread.c (is_ravenscar_task)
8147         (ravenscar_task_is_currently_active): Return bool.
8148         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8149         (_initialize_ravenscar): Remove "(void)".
8150         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8151         Return bool.
8152
8153 2019-02-15  Tom Tromey  <tromey@adacore.com>
8154
8155         * ravenscar-thread.c (ravenscar_runtime_initializer)
8156         (has_ravenscar_runtime, get_running_thread_id)
8157         (ravenscar_thread_target::resume): Fix indentation.
8158
8159 2019-02-15  Tom Tromey  <tromey@adacore.com>
8160
8161         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8162         from ravenscar_arch_ops.
8163         (sparc_ravenscar_ops::fetch_registers)
8164         (sparc_ravenscar_ops::store_registers): Now methods.
8165         (sparc_ravenscar_prepare_to_store): Remove.
8166         (sparc_ravenscar_ops): Redefine.
8167         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8168         methods and destructor.  Remove members.
8169         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8170         (ravenscar_thread_target::store_registers)
8171         (ravenscar_thread_target::prepare_to_store): Update.
8172         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8173         Remove.
8174         (struct ppc_ravenscar_powerpc_ops): Derive from
8175         ravenscar_arch_ops.
8176         (ppc_ravenscar_powerpc_ops::fetch_registers)
8177         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8178         (ppc_ravenscar_powerpc_ops): Redefine.
8179         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8180         (ppc_ravenscar_e500_ops::fetch_registers)
8181         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8182         (ppc_ravenscar_e500_ops): Redefine.
8183         * aarch64-ravenscar-thread.c
8184         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8185         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8186         (aarch64_ravenscar_fetch_registers)
8187         (aarch64_ravenscar_store_registers): Now methods.
8188         (aarch64_ravenscar_ops): Redefine.
8189
8190 2019-02-15  Tom Tromey  <tromey@adacore.com>
8191
8192         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8193         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8194         (ravenscar_thread_target::stopped_by_watchpoint)
8195         (ravenscar_thread_target::stopped_data_address)
8196         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8197
8198 2019-02-15  Tom Tromey  <tromey@adacore.com>
8199
8200         * ravenscar-thread.c: Fix some typos.
8201
8202 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8203             Tom Tromey  <tromey@adacore.com>
8204
8205         * ada-lang.c (ada_exception_sal): Change addr_string to a
8206         std::string.
8207         (create_ada_exception_catchpoint): Update.
8208
8209 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8210             Tom Tromey  <tromey@adacore.com>
8211
8212         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8213         (bp_location_ops): Remove.
8214         (base_breakpoint_allocate_location): Update.
8215         (free_bp_location): Update.
8216         * ada-lang.c (class ada_catchpoint_location)
8217         <ada_catchpoint_location>: Remove ops parameter.
8218         (ada_catchpoint_location_dtor): Remove.
8219         (ada_catchpoint_location_ops): Remove.
8220         (allocate_location_exception): Update.
8221         * breakpoint.h (struct bp_location_ops): Remove.
8222         (class bp_location) <bp_location>: Remove bp_location_ops
8223         parameter.
8224         <~bp_location>: Add destructor.
8225         <ops>: Remove.
8226
8227 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8228             Pedro Alves  <palves@redhat.com>
8229
8230         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8231         'PATH_MAX'.
8232
8233 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8234             Samuel Thibault  <samuel.thibault@gnu.org>
8235             Thomas Schwinge  <thomas@codesourcery.com>
8236
8237         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8238         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8239
8240 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8241
8242         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8243         (check_empty): Use "const char *".
8244
8245         * gnu-nat.c (gnu_nat_target::detach): Instead of
8246         'detach_inferior (pid)' call
8247         'detach_inferior (find_inferior_pid (pid))'.
8248
8249         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8250         'nat/fork-inferior.o'.
8251         * gnu-nat.c: #include "nat/fork-inferior.h".
8252
8253         * gnu-nat.c (gnu_nat_target::detach): Instead of
8254         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8255         * gnu-nat.h: #include "inf-child.h".
8256         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8257         'i386_gnu_nat_target::fetch_registers'.
8258         (gnu_store_registers): Rename/move to
8259         'i386_gnu_nat_target::store_registers'.
8260
8261         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8262         * gnu-nat.h (mach_thread_info): New function.
8263         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8264
8265         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8266
8267 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8268
8269         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8270
8271 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8272
8273         * windows-nat.c (windows_add_thread): Add new parameter
8274         "main_thread_p" with default value set to false.  Update
8275         function documentation as well as all callers.
8276         (windows_delete_thread): Likewise.
8277         (fake_create_process): Update call to windows_add_thread.
8278         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8279         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8280         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8281         call to windows_delete_thread.
8282
8283 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8284
8285         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8286
8287 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8288
8289         * symfile.c (find_separate_debug_file): Use canonical path of
8290         sysroot with child_path instead of gdb_sysroot if it is valid.
8291
8292 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8293
8294         * symfile.c (find_separate_debug_file): Use child_path to
8295         determine if an object file is under a sysroot.
8296
8297 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8298
8299         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8300         unittests/child-path-selftests.c.
8301         * common/pathstuff.c (child_path): New function.
8302         * common/pathstuff.h (child_path): New prototype.
8303         * unittests/child-path-selftests.c: New file.
8304
8305 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8306
8307         * symfile.c (find_separate_debug_file): Look for separate debug
8308         files in debug directories under the sysroot.
8309
8310 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8311
8312         * symtab.h (struct minimal_symbol data_p): New const method.
8313         (struct minimal_symbol text_p): Likewise.
8314         * symtab.c (output_source_filename): Use file name style
8315         to print file name.
8316         (print_symbol_info): Likewise.
8317         (print_msymbol_info): Use address style to print addresses.
8318         Use function name style to print executable text symbols.
8319         (expand_symtab_containing_pc): Use data_p.
8320         (find_pc_sect_compunit_symtab): Likewise.
8321
8322 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8323
8324         * breakpoint.c (describe_other_breakpoints): Use address style
8325         to print addresses.
8326         (say_where): Likewise.
8327
8328 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8329
8330         * ada-typeprint.c (print_func_type): Print function name
8331         style to print function name.
8332         * c-typeprint.c (c_print_type_1): Likewise.
8333
8334 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8335
8336         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8337         for execve.
8338
8339 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8340
8341         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8342         type_stack.
8343
8344 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8345
8346         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8347         TYPE_CODE_REF types.
8348
8349 2019-02-08  Jim Wilson  <jimw@sifive.com>
8350
8351         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8352         (riscv_linux_fregset): New.
8353         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8354
8355 2019-02-07  Tom Tromey  <tom@tromey.com>
8356
8357         * thread.c (thread_cancel_execution_command): Update.
8358         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8359         methods.
8360         (struct thread_fsm_ops): Remove.
8361         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8362         (thread_fsm_should_stop, thread_fsm_return_value)
8363         (thread_fsm_set_finished, thread_fsm_finished_p)
8364         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8365         Don't declare.
8366         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8367         * infrun.c (clear_proceed_status_thread)
8368         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8369         (print_stop_event): Update.
8370         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8371         Add constructor.
8372         (step_command_fsm_ops): Remove.
8373         (new_step_command_fsm): Remove.
8374         (step_1): Update.
8375         (step_command_fsm::should_stop): Rename from
8376         step_command_fsm_should_stop.
8377         (step_command_fsm::clean_up): Rename from
8378         step_command_fsm_clean_up.
8379         (step_command_fsm::do_async_reply_reason): Rename from
8380         step_command_fsm_async_reply_reason.
8381         (struct until_next_fsm): Inherit from thread_fsm.  Add
8382         constructor.
8383         (until_next_fsm_ops): Remove.
8384         (new_until_next_fsm): Remove.
8385         (until_next_fsm::should_stop): Rename from
8386         until_next_fsm_should_stop.
8387         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8388         (until_next_fsm::do_async_reply_reason): Rename from
8389         until_next_fsm_async_reply_reason.
8390         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8391         constructor.  Change type of breakpoint.
8392         (finish_command_fsm_ops): Remove.
8393         (new_finish_command_fsm): Remove.
8394         (finish_command_fsm::should_stop): Rename from
8395         finish_command_fsm_should_stop.
8396         (finish_command_fsm::clean_up): Rename from
8397         finish_command_fsm_clean_up.
8398         (finish_command_fsm::return_value): Rename from
8399         finish_command_fsm_return_value.
8400         (finish_command_fsm::do_async_reply_reason): Rename from
8401         finish_command_fsm_async_reply_reason.
8402         (finish_command): Update.
8403         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8404         Add constructor.
8405         (call_thread_fsm_ops): Remove.
8406         (call_thread_fsm::call_thread_fsm): Rename from
8407         new_call_thread_fsm.
8408         (call_thread_fsm::should_stop): Rename from
8409         call_thread_fsm_should_stop.
8410         (call_thread_fsm::should_notify_stop): Rename from
8411         call_thread_fsm_should_notify_stop.
8412         (run_inferior_call, call_function_by_hand_dummy): Update.
8413         * cli/cli-interp.c (should_print_stop_to_console): Update.
8414         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8415         Add constructor.  Change type of location_breakpoint,
8416         caller_breakpoint.
8417         (until_break_fsm_ops): Remove.
8418         (new_until_break_fsm): Remove.
8419         (until_break_fsm::should_stop): Rename from
8420         until_break_fsm_should_stop.
8421         (until_break_fsm::clean_up): Rename from
8422         until_break_fsm_clean_up.
8423         (until_break_fsm::do_async_reply_reason): Rename from
8424         until_break_fsm_async_reply_reason.
8425         (until_break_command): Update.
8426         * thread-fsm.c: Remove.
8427         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8428
8429 2019-02-07  Tom Tromey  <tom@tromey.com>
8430
8431         * yy-remap.h: Add include guard.
8432         * xtensa-tdep.h: Add include guard.
8433         * xcoffread.h: Rename include guard.
8434         * varobj-iter.h: Add include guard.
8435         * tui/tui.h: Rename include guard.
8436         * tui/tui-winsource.h: Rename include guard.
8437         * tui/tui-wingeneral.h: Rename include guard.
8438         * tui/tui-windata.h: Rename include guard.
8439         * tui/tui-win.h: Rename include guard.
8440         * tui/tui-stack.h: Rename include guard.
8441         * tui/tui-source.h: Rename include guard.
8442         * tui/tui-regs.h: Rename include guard.
8443         * tui/tui-out.h: Rename include guard.
8444         * tui/tui-layout.h: Rename include guard.
8445         * tui/tui-io.h: Rename include guard.
8446         * tui/tui-hooks.h: Rename include guard.
8447         * tui/tui-file.h: Rename include guard.
8448         * tui/tui-disasm.h: Rename include guard.
8449         * tui/tui-data.h: Rename include guard.
8450         * tui/tui-command.h: Rename include guard.
8451         * tic6x-tdep.h: Add include guard.
8452         * target/waitstatus.h: Rename include guard.
8453         * target/wait.h: Rename include guard.
8454         * target/target.h: Rename include guard.
8455         * target/resume.h: Rename include guard.
8456         * target-float.h: Rename include guard.
8457         * stabsread.h: Add include guard.
8458         * rs6000-tdep.h: Add include guard.
8459         * riscv-fbsd-tdep.h: Add include guard.
8460         * regformats/regdef.h: Rename include guard.
8461         * record.h: Rename include guard.
8462         * python/python.h: Rename include guard.
8463         * python/python-internal.h: Rename include guard.
8464         * python/py-stopevent.h: Rename include guard.
8465         * python/py-ref.h: Rename include guard.
8466         * python/py-record.h: Rename include guard.
8467         * python/py-record-full.h: Rename include guard.
8468         * python/py-record-btrace.h: Rename include guard.
8469         * python/py-instruction.h: Rename include guard.
8470         * python/py-events.h: Rename include guard.
8471         * python/py-event.h: Rename include guard.
8472         * procfs.h: Add include guard.
8473         * proc-utils.h: Add include guard.
8474         * p-lang.h: Add include guard.
8475         * or1k-tdep.h: Rename include guard.
8476         * observable.h: Rename include guard.
8477         * nto-tdep.h: Rename include guard.
8478         * nat/x86-linux.h: Rename include guard.
8479         * nat/x86-linux-dregs.h: Rename include guard.
8480         * nat/x86-gcc-cpuid.h: Add include guard.
8481         * nat/x86-dregs.h: Rename include guard.
8482         * nat/x86-cpuid.h: Rename include guard.
8483         * nat/ppc-linux.h: Rename include guard.
8484         * nat/mips-linux-watch.h: Rename include guard.
8485         * nat/linux-waitpid.h: Rename include guard.
8486         * nat/linux-ptrace.h: Rename include guard.
8487         * nat/linux-procfs.h: Rename include guard.
8488         * nat/linux-osdata.h: Rename include guard.
8489         * nat/linux-nat.h: Rename include guard.
8490         * nat/linux-namespaces.h: Rename include guard.
8491         * nat/linux-btrace.h: Rename include guard.
8492         * nat/glibc_thread_db.h: Rename include guard.
8493         * nat/gdb_thread_db.h: Rename include guard.
8494         * nat/gdb_ptrace.h: Rename include guard.
8495         * nat/fork-inferior.h: Rename include guard.
8496         * nat/amd64-linux-siginfo.h: Rename include guard.
8497         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8498         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8499         * nat/aarch64-linux.h: Rename include guard.
8500         * nat/aarch64-linux-hw-point.h: Rename include guard.
8501         * mn10300-tdep.h: Add include guard.
8502         * mips-linux-tdep.h: Add include guard.
8503         * mi/mi-parse.h: Rename include guard.
8504         * mi/mi-out.h: Rename include guard.
8505         * mi/mi-main.h: Rename include guard.
8506         * mi/mi-interp.h: Rename include guard.
8507         * mi/mi-getopt.h: Rename include guard.
8508         * mi/mi-console.h: Rename include guard.
8509         * mi/mi-common.h: Rename include guard.
8510         * mi/mi-cmds.h: Rename include guard.
8511         * mi/mi-cmd-break.h: Rename include guard.
8512         * m2-lang.h: Add include guard.
8513         * location.h: Rename include guard.
8514         * linux-record.h: Rename include guard.
8515         * linux-nat.h: Add include guard.
8516         * linux-fork.h: Add include guard.
8517         * i386-darwin-tdep.h: Rename include guard.
8518         * hppa-linux-offsets.h: Add include guard.
8519         * guile/guile.h: Rename include guard.
8520         * guile/guile-internal.h: Rename include guard.
8521         * gnu-nat.h: Rename include guard.
8522         * gdb-stabs.h: Rename include guard.
8523         * frv-tdep.h: Add include guard.
8524         * f-lang.h: Add include guard.
8525         * event-loop.h: Add include guard.
8526         * darwin-nat.h: Rename include guard.
8527         * cp-abi.h: Rename include guard.
8528         * config/sparc/nm-sol2.h: Rename include guard.
8529         * config/nm-nto.h: Rename include guard.
8530         * config/nm-linux.h: Add include guard.
8531         * config/i386/nm-i386gnu.h: Rename include guard.
8532         * config/djgpp/nl_types.h: Rename include guard.
8533         * config/djgpp/langinfo.h: Rename include guard.
8534         * compile/gcc-cp-plugin.h: Add include guard.
8535         * compile/gcc-c-plugin.h: Add include guard.
8536         * compile/compile.h: Rename include guard.
8537         * compile/compile-object-run.h: Rename include guard.
8538         * compile/compile-object-load.h: Rename include guard.
8539         * compile/compile-internal.h: Rename include guard.
8540         * compile/compile-cplus.h: Rename include guard.
8541         * compile/compile-c.h: Rename include guard.
8542         * common/xml-utils.h: Rename include guard.
8543         * common/x86-xstate.h: Rename include guard.
8544         * common/version.h: Rename include guard.
8545         * common/vec.h: Rename include guard.
8546         * common/tdesc.h: Rename include guard.
8547         * common/selftest.h: Rename include guard.
8548         * common/scoped_restore.h: Rename include guard.
8549         * common/scoped_mmap.h: Rename include guard.
8550         * common/scoped_fd.h: Rename include guard.
8551         * common/safe-iterator.h: Rename include guard.
8552         * common/run-time-clock.h: Rename include guard.
8553         * common/refcounted-object.h: Rename include guard.
8554         * common/queue.h: Rename include guard.
8555         * common/ptid.h: Rename include guard.
8556         * common/print-utils.h: Rename include guard.
8557         * common/preprocessor.h: Rename include guard.
8558         * common/pathstuff.h: Rename include guard.
8559         * common/observable.h: Rename include guard.
8560         * common/netstuff.h: Rename include guard.
8561         * common/job-control.h: Rename include guard.
8562         * common/host-defs.h: Rename include guard.
8563         * common/gdb_wait.h: Rename include guard.
8564         * common/gdb_vecs.h: Rename include guard.
8565         * common/gdb_unlinker.h: Rename include guard.
8566         * common/gdb_unique_ptr.h: Rename include guard.
8567         * common/gdb_tilde_expand.h: Rename include guard.
8568         * common/gdb_sys_time.h: Rename include guard.
8569         * common/gdb_string_view.h: Rename include guard.
8570         * common/gdb_splay_tree.h: Rename include guard.
8571         * common/gdb_setjmp.h: Rename include guard.
8572         * common/gdb_ref_ptr.h: Rename include guard.
8573         * common/gdb_optional.h: Rename include guard.
8574         * common/gdb_locale.h: Rename include guard.
8575         * common/gdb_assert.h: Rename include guard.
8576         * common/filtered-iterator.h: Rename include guard.
8577         * common/filestuff.h: Rename include guard.
8578         * common/fileio.h: Rename include guard.
8579         * common/environ.h: Rename include guard.
8580         * common/common-utils.h: Rename include guard.
8581         * common/common-types.h: Rename include guard.
8582         * common/common-regcache.h: Rename include guard.
8583         * common/common-inferior.h: Rename include guard.
8584         * common/common-gdbthread.h: Rename include guard.
8585         * common/common-exceptions.h: Rename include guard.
8586         * common/common-defs.h: Rename include guard.
8587         * common/common-debug.h: Rename include guard.
8588         * common/cleanups.h: Rename include guard.
8589         * common/buffer.h: Rename include guard.
8590         * common/btrace-common.h: Rename include guard.
8591         * common/break-common.h: Rename include guard.
8592         * cli/cli-utils.h: Rename include guard.
8593         * cli/cli-style.h: Rename include guard.
8594         * cli/cli-setshow.h: Rename include guard.
8595         * cli/cli-script.h: Rename include guard.
8596         * cli/cli-interp.h: Rename include guard.
8597         * cli/cli-decode.h: Rename include guard.
8598         * cli/cli-cmds.h: Rename include guard.
8599         * charset-list.h: Add include guard.
8600         * buildsym-legacy.h: Rename include guard.
8601         * bfin-tdep.h: Add include guard.
8602         * ax.h: Rename include guard.
8603         * arm-linux-tdep.h: Add include guard.
8604         * arm-fbsd-tdep.h: Add include guard.
8605         * arch/xtensa.h: Rename include guard.
8606         * arch/tic6x.h: Add include guard.
8607         * arch/i386.h: Add include guard.
8608         * arch/arm.h: Rename include guard.
8609         * arch/arm-linux.h: Rename include guard.
8610         * arch/arm-get-next-pcs.h: Rename include guard.
8611         * arch/amd64.h: Add include guard.
8612         * arch/aarch64-insn.h: Rename include guard.
8613         * arch-utils.h: Rename include guard.
8614         * annotate.h: Add include guard.
8615         * amd64-darwin-tdep.h: Rename include guard.
8616         * aarch64-linux-tdep.h: Add include guard.
8617         * aarch64-fbsd-tdep.h: Add include guard.
8618         * aarch32-linux-nat.h: Add include guard.
8619
8620 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8621
8622         * macrotab.c (macro_define_internal): New function that
8623         factorizes macro_define_object_internal and macro_define_function
8624         code.
8625         (macro_define_object_internal): Use macro_define_internal.
8626         (macro_define_function): Likewise.
8627
8628 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8629
8630         * macrocmd.c (extract_identifier): Return
8631         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8632         callers.
8633
8634 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8635
8636         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8637
8638 2019-02-05  Tom Tromey  <tom@tromey.com>
8639
8640         * target.c (target_stack::unpush): Move assertion earlier.
8641
8642 2019-01-30  Tom Tromey  <tom@tromey.com>
8643
8644         PR python/23615:
8645         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8646         (gdbpy_parse_and_eval): Likewise.
8647         * python/python-internal.h (gdbpy_allow_threads): New class.
8648
8649 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8650
8651         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8652         (aarch64_fbsd_fpregmap): Move earlier.
8653         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8654         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8655         instead of individual calls to trad_frame_set_reg_addr.
8656         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8657         earlier.
8658         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8659         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8660         instead of individual calls to trad_frame_set_reg_addr.
8661
8662 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8663
8664         * CONTRIBUTE: Replace contribution list with wiki link.
8665
8666 2019-01-25  Tom Tromey  <tom@tromey.com>
8667
8668         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8669
8670 2019-01-25  Tom Tromey  <tom@tromey.com>
8671
8672         * xtensa-linux-nat.c: Fix common/ includes.
8673         * xml-support.h: Fix common/ includes.
8674         * xml-support.c: Fix common/ includes.
8675         * x86-linux-nat.c: Fix common/ includes.
8676         * windows-nat.c: Fix common/ includes.
8677         * varobj.h: Fix common/ includes.
8678         * varobj.c: Fix common/ includes.
8679         * value.c: Fix common/ includes.
8680         * valops.c: Fix common/ includes.
8681         * utils.c: Fix common/ includes.
8682         * unittests/xml-utils-selftests.c: Fix common/ includes.
8683         * unittests/utils-selftests.c: Fix common/ includes.
8684         * unittests/unpack-selftests.c: Fix common/ includes.
8685         * unittests/tracepoint-selftests.c: Fix common/ includes.
8686         * unittests/style-selftests.c: Fix common/ includes.
8687         * unittests/string_view-selftests.c: Fix common/ includes.
8688         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8689         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8690         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8691         * unittests/rsp-low-selftests.c: Fix common/ includes.
8692         * unittests/parse-connection-spec-selftests.c: Fix common/
8693         includes.
8694         * unittests/optional-selftests.c: Fix common/ includes.
8695         * unittests/offset-type-selftests.c: Fix common/ includes.
8696         * unittests/observable-selftests.c: Fix common/ includes.
8697         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8698         * unittests/memrange-selftests.c: Fix common/ includes.
8699         * unittests/memory-map-selftests.c: Fix common/ includes.
8700         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8701         * unittests/function-view-selftests.c: Fix common/ includes.
8702         * unittests/environ-selftests.c: Fix common/ includes.
8703         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8704         * unittests/common-utils-selftests.c: Fix common/ includes.
8705         * unittests/cli-utils-selftests.c: Fix common/ includes.
8706         * unittests/array-view-selftests.c: Fix common/ includes.
8707         * ui-file.c: Fix common/ includes.
8708         * tui/tui-io.c: Fix common/ includes.
8709         * tracepoint.h: Fix common/ includes.
8710         * tracepoint.c: Fix common/ includes.
8711         * tracefile-tfile.c: Fix common/ includes.
8712         * top.h: Fix common/ includes.
8713         * top.c: Fix common/ includes.
8714         * thread.c: Fix common/ includes.
8715         * target/waitstatus.h: Fix common/ includes.
8716         * target/waitstatus.c: Fix common/ includes.
8717         * target.h: Fix common/ includes.
8718         * target.c: Fix common/ includes.
8719         * target-memory.c: Fix common/ includes.
8720         * target-descriptions.c: Fix common/ includes.
8721         * symtab.h: Fix common/ includes.
8722         * symfile.c: Fix common/ includes.
8723         * stap-probe.c: Fix common/ includes.
8724         * spu-linux-nat.c: Fix common/ includes.
8725         * sparc-nat.c: Fix common/ includes.
8726         * source.c: Fix common/ includes.
8727         * solib.c: Fix common/ includes.
8728         * solib-target.c: Fix common/ includes.
8729         * ser-unix.c: Fix common/ includes.
8730         * ser-tcp.c: Fix common/ includes.
8731         * ser-pipe.c: Fix common/ includes.
8732         * ser-base.c: Fix common/ includes.
8733         * selftest-arch.c: Fix common/ includes.
8734         * s12z-tdep.c: Fix common/ includes.
8735         * rust-exp.y: Fix common/ includes.
8736         * rs6000-aix-tdep.c: Fix common/ includes.
8737         * riscv-tdep.c: Fix common/ includes.
8738         * remote.c: Fix common/ includes.
8739         * remote-notif.h: Fix common/ includes.
8740         * remote-fileio.h: Fix common/ includes.
8741         * remote-fileio.c: Fix common/ includes.
8742         * regcache.h: Fix common/ includes.
8743         * regcache.c: Fix common/ includes.
8744         * record-btrace.c: Fix common/ includes.
8745         * python/python.c: Fix common/ includes.
8746         * python/py-type.c: Fix common/ includes.
8747         * python/py-inferior.c: Fix common/ includes.
8748         * progspace.h: Fix common/ includes.
8749         * producer.c: Fix common/ includes.
8750         * procfs.c: Fix common/ includes.
8751         * proc-api.c: Fix common/ includes.
8752         * printcmd.c: Fix common/ includes.
8753         * ppc-linux-nat.c: Fix common/ includes.
8754         * parser-defs.h: Fix common/ includes.
8755         * osdata.c: Fix common/ includes.
8756         * obsd-nat.c: Fix common/ includes.
8757         * nat/x86-linux.c: Fix common/ includes.
8758         * nat/x86-linux-dregs.c: Fix common/ includes.
8759         * nat/x86-dregs.h: Fix common/ includes.
8760         * nat/x86-dregs.c: Fix common/ includes.
8761         * nat/ppc-linux.c: Fix common/ includes.
8762         * nat/mips-linux-watch.h: Fix common/ includes.
8763         * nat/mips-linux-watch.c: Fix common/ includes.
8764         * nat/linux-waitpid.c: Fix common/ includes.
8765         * nat/linux-ptrace.h: Fix common/ includes.
8766         * nat/linux-ptrace.c: Fix common/ includes.
8767         * nat/linux-procfs.c: Fix common/ includes.
8768         * nat/linux-personality.c: Fix common/ includes.
8769         * nat/linux-osdata.c: Fix common/ includes.
8770         * nat/linux-namespaces.c: Fix common/ includes.
8771         * nat/linux-btrace.h: Fix common/ includes.
8772         * nat/linux-btrace.c: Fix common/ includes.
8773         * nat/fork-inferior.c: Fix common/ includes.
8774         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8775         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8776         * nat/aarch64-linux.c: Fix common/ includes.
8777         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8778         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8779         * namespace.h: Fix common/ includes.
8780         * mips-linux-tdep.c: Fix common/ includes.
8781         * minsyms.c: Fix common/ includes.
8782         * mi/mi-parse.h: Fix common/ includes.
8783         * mi/mi-main.c: Fix common/ includes.
8784         * mi/mi-cmd-env.c: Fix common/ includes.
8785         * memrange.h: Fix common/ includes.
8786         * memattr.c: Fix common/ includes.
8787         * maint.h: Fix common/ includes.
8788         * maint.c: Fix common/ includes.
8789         * main.c: Fix common/ includes.
8790         * machoread.c: Fix common/ includes.
8791         * location.c: Fix common/ includes.
8792         * linux-thread-db.c: Fix common/ includes.
8793         * linux-nat.c: Fix common/ includes.
8794         * linux-fork.c: Fix common/ includes.
8795         * inline-frame.c: Fix common/ includes.
8796         * infrun.c: Fix common/ includes.
8797         * inflow.c: Fix common/ includes.
8798         * inferior.h: Fix common/ includes.
8799         * inferior.c: Fix common/ includes.
8800         * infcmd.c: Fix common/ includes.
8801         * inf-ptrace.c: Fix common/ includes.
8802         * inf-child.c: Fix common/ includes.
8803         * ia64-linux-nat.c: Fix common/ includes.
8804         * i387-tdep.c: Fix common/ includes.
8805         * i386-tdep.c: Fix common/ includes.
8806         * i386-linux-tdep.c: Fix common/ includes.
8807         * i386-linux-nat.c: Fix common/ includes.
8808         * i386-go32-tdep.c: Fix common/ includes.
8809         * i386-fbsd-tdep.c: Fix common/ includes.
8810         * i386-fbsd-nat.c: Fix common/ includes.
8811         * guile/scm-type.c: Fix common/ includes.
8812         * guile/guile.c: Fix common/ includes.
8813         * go32-nat.c: Fix common/ includes.
8814         * gnu-nat.c: Fix common/ includes.
8815         * gdbthread.h: Fix common/ includes.
8816         * gdbarch-selftests.c: Fix common/ includes.
8817         * gdb_usleep.c: Fix common/ includes.
8818         * gdb_select.h: Fix common/ includes.
8819         * gdb_bfd.c: Fix common/ includes.
8820         * gcore.c: Fix common/ includes.
8821         * fork-child.c: Fix common/ includes.
8822         * findvar.c: Fix common/ includes.
8823         * fbsd-nat.c: Fix common/ includes.
8824         * event-top.c: Fix common/ includes.
8825         * event-loop.c: Fix common/ includes.
8826         * dwarf2read.c: Fix common/ includes.
8827         * dwarf2loc.c: Fix common/ includes.
8828         * dwarf2-frame.c: Fix common/ includes.
8829         * dwarf-index-cache.c: Fix common/ includes.
8830         * dtrace-probe.c: Fix common/ includes.
8831         * disasm-selftests.c: Fix common/ includes.
8832         * defs.h: Fix common/ includes.
8833         * csky-tdep.c: Fix common/ includes.
8834         * cp-valprint.c: Fix common/ includes.
8835         * cp-support.h: Fix common/ includes.
8836         * cp-support.c: Fix common/ includes.
8837         * corelow.c: Fix common/ includes.
8838         * completer.h: Fix common/ includes.
8839         * completer.c: Fix common/ includes.
8840         * compile/compile.c: Fix common/ includes.
8841         * compile/compile-loc2c.c: Fix common/ includes.
8842         * compile/compile-cplus-types.c: Fix common/ includes.
8843         * compile/compile-cplus-symbols.c: Fix common/ includes.
8844         * command.h: Fix common/ includes.
8845         * cli/cli-dump.c: Fix common/ includes.
8846         * cli/cli-cmds.c: Fix common/ includes.
8847         * charset.c: Fix common/ includes.
8848         * build-id.c: Fix common/ includes.
8849         * btrace.h: Fix common/ includes.
8850         * btrace.c: Fix common/ includes.
8851         * breakpoint.h: Fix common/ includes.
8852         * breakpoint.c: Fix common/ includes.
8853         * ax.h:
8854         (enum agent_op): Fix common/ includes.
8855         * ax-general.c (struct aop_map): Fix common/ includes.
8856         * ax-gdb.c: Fix common/ includes.
8857         * auxv.c: Fix common/ includes.
8858         * auto-load.c: Fix common/ includes.
8859         * arm-tdep.c: Fix common/ includes.
8860         * arch/riscv.c: Fix common/ includes.
8861         * arch/ppc-linux-common.c: Fix common/ includes.
8862         * arch/i386.c: Fix common/ includes.
8863         * arch/arm.c: Fix common/ includes.
8864         * arch/arm-linux.c: Fix common/ includes.
8865         * arch/arm-get-next-pcs.c: Fix common/ includes.
8866         * arch/amd64.c: Fix common/ includes.
8867         * arch/aarch64.c: Fix common/ includes.
8868         * arch/aarch64-insn.c: Fix common/ includes.
8869         * arch-utils.c: Fix common/ includes.
8870         * amd64-windows-tdep.c: Fix common/ includes.
8871         * amd64-tdep.c: Fix common/ includes.
8872         * amd64-sol2-tdep.c: Fix common/ includes.
8873         * amd64-obsd-tdep.c: Fix common/ includes.
8874         * amd64-nbsd-tdep.c: Fix common/ includes.
8875         * amd64-linux-tdep.c: Fix common/ includes.
8876         * amd64-linux-nat.c: Fix common/ includes.
8877         * amd64-fbsd-tdep.c: Fix common/ includes.
8878         * amd64-fbsd-nat.c: Fix common/ includes.
8879         * amd64-dicos-tdep.c: Fix common/ includes.
8880         * amd64-darwin-tdep.c: Fix common/ includes.
8881         * agent.c: Fix common/ includes.
8882         * ada-lang.h: Fix common/ includes.
8883         * ada-lang.c: Fix common/ includes.
8884         * aarch64-tdep.c: Fix common/ includes.
8885
8886 2019-01-25  Tom Tromey  <tom@tromey.com>
8887
8888         * common/create-version.sh: Use common/version.h.
8889
8890 2019-01-24  Pedro Alves  <palves@redhat.com>
8891
8892         * infrun.c (signal_stop, signal_print, signal_program)
8893         (signal_catch, signal_pass): Now arrays instead of pointers.
8894         (update_signals_program_target, do_target_resume)
8895         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8896         * linux-nat.c (linux_nat_target::pass_signals)
8897         (linux_nat_target::create_inferior, linux_nat_target::attach):
8898         Adjust.
8899         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8900         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8901         * procfs.c (procfs_target::pass_signals): Adjust.
8902         * record-full.c (record_full_target::resume): Adjust.
8903         * remote.c (remote_target::pass_signals)
8904         (remote_target::program_signals): Adjust.
8905         * target-debug.h (target_debug_print_signals): Now takes a
8906         gdb::array_view as parameter.  Adjust.
8907         * target.h (target_ops) <pass_signals, program_signals>: Replace
8908         pointer and length parameters with gdb::array_view.
8909         (target_pass_signals, target_program_signals): Likewise.
8910         * target-delegates.c: Regenerate.
8911
8912 2019-01-24  Pedro Alves  <palves@redhat.com>
8913
8914         * common/forward-scope-exit.h
8915         (forward_scope_exit::forward_scope_exit): Pass arguments to
8916         m_bind_function directly, instead of creating a std::bind and
8917         copying that.
8918
8919 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8920
8921         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8922         for static members.
8923         (pass_in_v_vfp_candidate): Likewise.
8924
8925 2019-01-23  Tom Tromey  <tom@tromey.com>
8926             Pedro Alves  <palves@redhat.com>
8927
8928         * regcache.c (class regcache_invalidator): Remove.
8929         (regcache::raw_write): Use make_scope_exit.
8930
8931 2019-01-23  Tom Tromey  <tom@tromey.com>
8932
8933         * ui-out.h (class ui_out_emit_type): Update comment.
8934
8935 2019-01-23  Tom Tromey  <tom@tromey.com>
8936
8937         * infrun.c (fetch_inferior_event): Update comment.
8938
8939 2019-01-23  Tom Tromey  <tom@tromey.com>
8940             Pedro Alves  <palves@redhat.com>
8941
8942         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8943         parameter.
8944         (fetch_inferior_event): Use SCOPE_EXIT.
8945
8946
8947 2019-01-23  Tom Tromey  <tom@tromey.com>
8948             Pedro Alves  <palves@redhat.com>
8949
8950         * infrun.c (disable_thread_events): Delete.
8951         (stop_all_threads): Use SCOPE_EXIT.
8952
8953 2019-01-23  Tom Tromey  <tom@tromey.com>
8954             Pedro Alves  <palves@redhat.com>
8955
8956         * symfile.c: Include forward-scope-exit.h.
8957         (clear_symtab_users_cleanup): Replace forward declaration with
8958         a FORWARD_SCOPE_EXIT.
8959         (syms_from_objfile_1): Use the forward_scope_exit and
8960         gdb::optional instead of cleanup_function.
8961         (reread_symbols): Use the forward_scope_exit instead of
8962         cleanup_function.
8963         (clear_symtab_users_cleanup): Remove function.
8964
8965 2019-01-23  Tom Tromey  <tom@tromey.com>
8966             Pedro Alves  <palves@redhat.com>
8967
8968         * linux-nat.c: Include scope-exit.h.
8969         (cleanup_target_stop): Remove.
8970         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8971         SCOPE_EXIT.
8972
8973 2019-01-23  Tom Tromey  <tom@tromey.com>
8974             Pedro Alves  <palves@redhat.com>
8975
8976         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8977         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8978
8979 2019-01-23  Tom Tromey  <tom@tromey.com>
8980             Andrew Burgess  <andrew.burgess@embecosm.com>
8981             Pedro Alves  <palves@redhat.com>
8982
8983         * infrun.c (fetch_inferior_event): Use scope_exit.
8984         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8985         * top.c (execute_command): Use scope_exit.
8986         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8987         * utils.c (do_bpstat_clear_actions_cleanup)
8988         (make_bpstat_clear_actions_cleanup): Remove.
8989
8990 2019-01-23  Tom Tromey  <tom@tromey.com>
8991             Pedro Alves  <palves@redhat.com>
8992
8993         * infrun.c: Include "common/scope-exit.h"
8994         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8995         (wait_for_inferior): Use SCOPE_EXIT.
8996         (fetch_inferior_event): Use scope_exit.
8997
8998 2019-01-23  Tom Tromey  <tom@tromey.com>
8999             Pedro Alves  <palves@redhat.com>
9000
9001         * breakpoint.c (create_breakpoint): Remove cleanup.
9002
9003 2019-01-23  Tom Tromey  <tom@tromey.com>
9004             Andrew Burgess  <andrew.burgess@embecosm.com>
9005             Pedro Alves  <palves@redhat.com>
9006
9007 2019-01-23  Pedro Alves  <palves@redhat.com>
9008
9009         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9010
9011 2019-01-23  Pedro Alves  <palves@redhat.com>
9012             Andrew Burgess  <andrew.burgess@embecosm.com>
9013
9014         * gdbthread.h: Include "common/forward-scope-exit.h".
9015         (scoped_finish_thread_state): Redefine custom class in terms of
9016         forward_scope_exit.
9017
9018 2019-01-23  Pedro Alves  <palves@redhat.com>
9019             Andrew Burgess  <andrew.burgess@embecosm.com>
9020
9021         * common/forward-scope-exit.h: New file.
9022
9023 2019-01-23  Pedro Alves  <palves@redhat.com>
9024             Andrew Burgess  <andrew.burgess@embecosm.com>
9025             Tom Tromey  <tom@tromey.com>
9026
9027         * common/scope-exit.h: New file.
9028
9029 2019-01-23  Pedro Alves  <palves@redhat.com>
9030
9031         * common/preprocessor.h (ESC): Rename to ...
9032         (ESC_PARENS): ... this.
9033         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9034         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9035
9036 2019-01-23  Tom Tromey  <tom@tromey.com>
9037
9038         * language.h (class scoped_switch_to_sym_language_if_auto):
9039         Initialize m_lang in both cases.
9040
9041 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9042
9043         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9044         with XCNEW.
9045
9046 2019-01-22  Tom Tromey  <tom@tromey.com>
9047
9048         * corelow.c: Do not include sys/file.h.
9049
9050 2019-01-22  Tom Tromey  <tom@tromey.com>
9051
9052         * tui/tui-wingeneral.h: Include gdb_curses.h.
9053
9054 2019-01-22  Tom Tromey  <tom@tromey.com>
9055
9056         * source-cache.h (class source_cache) <get_source_lines,
9057         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9058
9059 2019-01-22  Tom Tromey  <tom@tromey.com>
9060
9061         * remote-fileio.h (struct remote_target): Declare.
9062
9063 2019-01-22  Tom Tromey  <tom@tromey.com>
9064
9065         * python/py-arch.c: Do not include py-ref.h.
9066         * python/py-bpevent.c: Do not include py-ref.h.
9067         * python/py-cmd.c: Do not include py-ref.h.
9068         * python/py-continueevent.c: Do not include py-ref.h.
9069         * python/py-event.h: Do not include py-ref.h.
9070         * python/py-evtregistry.c: Do not include py-ref.h.
9071         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9072         * python/py-frame.c: Do not include py-ref.h.
9073         * python/py-framefilter.c: Do not include py-ref.h.
9074         * python/py-function.c: Do not include py-ref.h.
9075         * python/py-infevents.c: Do not include py-ref.h.
9076         * python/py-linetable.c: Do not include py-ref.h.
9077         * python/py-objfile.c: Do not include py-ref.h.
9078         * python/py-param.c: Do not include py-ref.h.
9079         * python/py-prettyprint.c: Do not include py-ref.h.
9080         * python/py-progspace.c: Do not include py-ref.h.
9081         * python/py-symbol.c: Do not include py-ref.h.
9082         * python/py-symtab.c: Do not include py-ref.h.
9083         * python/py-type.c: Do not include py-ref.h.
9084         * python/py-unwind.c: Do not include py-ref.h.
9085         * python/py-utils.c: Do not include py-ref.h.
9086         * python/py-value.c: Do not include py-ref.h.
9087         * python/py-varobj.c: Do not include py-ref.h.
9088         * python/py-xmethods.c: Do not include py-ref.h.
9089         * python/python.c: Do not include py-ref.h.
9090         * varobj.c: Do not include py-ref.h.
9091
9092 2019-01-22  Tom Tromey  <tom@tromey.com>
9093
9094         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9095         keyword for bcache.
9096
9097 2019-01-22  Tom Tromey  <tom@tromey.com>
9098
9099         * compile/compile-cplus-types.c: Remove a comment by #include.
9100
9101 2019-01-22  Tom Tromey  <tom@tromey.com>
9102
9103         * compile/gcc-c-plugin.h: Include compile-internal.h.
9104
9105 2019-01-22  Tom Tromey  <tom@tromey.com>
9106
9107         * stabsread.c (EXTERN): Do not define.
9108         (symnum, next_symbol_text_func, processing_gcc_compilation)
9109         (within_function, global_sym_chain, global_stabs)
9110         (previous_stab_code, this_object_header_files)
9111         (n_this_object_header_files)
9112         (n_allocated_this_object_header_files): Define.
9113         * stabsread.h (EXTERN): Never define.  Use "extern".
9114
9115 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9116
9117         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9118         history_value.
9119
9120 2019-01-21  Tom Tromey  <tom@tromey.com>
9121
9122         * ui-out.c: Fix includes.
9123         * tui/tui-source.c: Fix includes.
9124         * target.c: Fix includes.
9125         * remote.c: Fix includes.
9126         * regcache.c: Fix includes.
9127         * python/py-block.c: Fix includes.
9128         * printcmd.c: Fix includes.
9129         * or1k-tdep.c: Fix includes.
9130         * mi/mi-main.c: Fix includes.
9131         * m32r-tdep.c: Fix includes.
9132         * csky-tdep.c: Fix includes.
9133         * compile/compile-cplus-types.c: Fix includes.
9134         * cli/cli-interp.c: Fix includes.
9135
9136 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9137
9138         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9139         for padding.
9140
9141 2019-01-16  Tom Tromey  <tom@tromey.com>
9142
9143         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9144         earlier.
9145         (struct objfile) <msymbols_range>: Move from top level.
9146         <msymbols>: New method.
9147         (class objfile_msymbols): Remove.
9148         * symtab.c (default_collect_symbol_completion_matches_break_on):
9149         Update.
9150         * symmisc.c (dump_msymbols): Update.
9151         * stabsread.c (scan_file_globals): Update.
9152         * objc-lang.c (info_selectors_command, info_classes_command)
9153         (find_methods): Update.
9154         * minsyms.c (find_solib_trampoline_target): Update.
9155         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9156         * coffread.c (coff_symfile_read): Update.
9157         * ada-lang.c (ada_lookup_simple_minsym)
9158         (ada_collect_symbol_completion_matches): Update.
9159
9160 2019-01-16  Tom Tromey  <tom@tromey.com>
9161
9162         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9163         type.  Remove no-argument constructor.
9164         <iterator::operator++>: Simplify.
9165         <begin>: Update.
9166         <end>: Use minimal_symbol_count.
9167
9168 2019-01-16  Tom Tromey  <tom@tromey.com>
9169
9170         * objfiles.h (struct objfile) <psymtabs>: New method.
9171         (class objfile_psymtabs): Remove.
9172         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9173         typedef.
9174         <range>: New method.
9175         (require_partial_symbols): Change return type.
9176         * psymtab.c (require_partial_symbols)
9177         (psym_expand_symtabs_matching): Update.
9178         * mdebugread.c (parse_partial_symbols): Update.
9179         * dbxread.c (dbx_end_psymtab): Update.
9180
9181 2019-01-15  Tom Tromey  <tom@tromey.com>
9182
9183         * symtab.c (lookup_objfile_from_block)
9184         (lookup_symbol_in_objfile_symtabs)
9185         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9186         (find_line_symtab, info_sources_command)
9187         (default_collect_symbol_completion_matches_break_on)
9188         (make_source_files_completion_list): Update.
9189         * symmisc.c (print_objfile_statistics, dump_objfile)
9190         (maintenance_print_symbols, maintenance_info_symtabs)
9191         (maintenance_check_symtabs, maintenance_info_line_tables):
9192         Update.
9193         * source.c (select_source_symtab)
9194         (forget_cached_source_info_for_objfile): Update.
9195         * objfiles.h (class objfile_compunits): Remove.
9196         (struct objfile) <compunits_range>: New typedef.
9197         (compunits): New method.
9198         * objfiles.c (objfile_relocate1): Update.
9199         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9200         * maint.c (count_symtabs_and_blocks): Update.
9201         * linespec.c (iterate_over_all_matching_symtabs): Update.
9202         * cp-support.c (add_symbol_overload_list_qualified): Update.
9203         * coffread.c (coff_symtab_read): Update.
9204         * ada-lang.c (add_nonlocal_symbols)
9205         (ada_collect_symbol_completion_matches)
9206         (ada_add_global_exceptions): Update.
9207
9208 2019-01-15  Tom Tromey  <tom@tromey.com>
9209
9210         * progspace.h (program_space) <objfiles_safe_range>: New
9211         typedef.
9212         <objfiles_safe>: New method.
9213         * objfiles.h (class all_objfiles_safe): Remove.
9214         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9215         * jit.c (jit_inferior_exit_hook): Update.
9216
9217 2019-01-17  Tom Tromey  <tom@tromey.com>
9218
9219         * progspace.h (program_space) <objfiles_range>: New typedef.
9220         <objfiles>: New method.
9221         <objfiles_head>: Rename from objfiles.
9222         (object_files): Update.
9223         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9224         * guile/scm-pretty-print.c
9225         (ppscm_find_pretty_printer_from_objfiles): Update.
9226         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9227         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9228         Update.
9229         * python/py-progspace.c (pspy_get_objfiles): Update.
9230         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9231         Update.
9232         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9233         (objfpy_lookup_objfile_by_build_id): Update.
9234         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9235         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9236         Update.
9237         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9238         (expand_symtab_containing_pc, lookup_objfile_from_block)
9239         (lookup_static_symbol, basic_lookup_transparent_type)
9240         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9241         (find_line_symtab, info_sources_command)
9242         (default_collect_symbol_completion_matches_break_on)
9243         (make_source_files_completion_list, find_main_name): Update.
9244         * symmisc.c (print_symbol_bcache_statistics)
9245         (print_objfile_statistics, maintenance_print_symbols)
9246         (maintenance_print_msymbols, maintenance_print_objfiles)
9247         (maintenance_info_symtabs, maintenance_check_symtabs)
9248         (maintenance_expand_symtabs, maintenance_info_line_tables):
9249         Update.
9250         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9251         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9252         (map_overlay_command, unmap_overlay_command)
9253         (simple_overlay_update, expand_symtabs_matching)
9254         (map_symbol_filenames): Update.
9255         * symfile-debug.c (set_debug_symfile): Update.
9256         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9257         Update.
9258         * source.c (select_source_symtab, forget_cached_source_info):
9259         Update.
9260         * solib.c (solib_read_symbols): Update.
9261         * solib-spu.c (append_ocl_sos): Update.
9262         * psymtab.c (maintenance_print_psymbols)
9263         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9264         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9265         * printcmd.c (info_symbol_command): Update.
9266         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9267         Update.
9268         * objfiles.h (class all_objfiles): Remove.
9269         * objfiles.c (have_partial_symbols, have_full_symbols)
9270         (have_minimal_symbols, qsort_cmp, update_section_map)
9271         (shared_objfile_contains_address_p)
9272         (default_iterate_over_objfiles_in_search_order): Update.
9273         * objc-lang.c (info_selectors_command, info_classes_command)
9274         (find_methods): Update.
9275         * minsyms.c (find_solib_trampoline_target): Update.
9276         * maint.c (maintenance_info_sections)
9277         (maintenance_translate_address, count_symtabs_and_blocks):
9278         Update.
9279         * main.c (captured_main_1): Update.
9280         * linux-thread-db.c (try_thread_db_load_from_pdir)
9281         (has_libpthread): Update.
9282         * linespec.c (iterate_over_all_matching_symtabs)
9283         (search_minsyms_for_name): Update.
9284         * jit.c (jit_find_objf_with_entry_addr): Update.
9285         * hppa-tdep.c (find_unwind_entry)
9286         (hppa_lookup_stub_minimal_symbol): Update.
9287         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9288         Update.
9289         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9290         (elf_gnu_ifunc_resolve_by_got): Update.
9291         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9292         * dwarf-index-write.c (save_gdb_index_command): Update.
9293         * cp-support.c (add_symbol_overload_list_qualified): Update.
9294         * breakpoint.c (create_overlay_event_breakpoint)
9295         (create_longjmp_master_breakpoint)
9296         (create_std_terminate_master_breakpoint)
9297         (create_exception_master_breakpoint): Update.
9298         * blockframe.c (find_pc_partial_function): Update.
9299         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9300         (ada_collect_symbol_completion_matches)
9301         (ada_add_global_exceptions): Update.
9302
9303 2019-01-17  Tom Tromey  <tom@tromey.com>
9304
9305         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9306         declare VEC.
9307         (solib_target_parse_libraries): Change return type.
9308         (library_list_start_segment, library_list_start_section)
9309         (library_list_end_library, library_list_start_library); Update.
9310         (solib_target_free_library_list): Remove.
9311         (solib_target_parse_libraries): Remove cleanup.  Change return
9312         type.
9313         (solib_target_current_sos): Update.
9314
9315 2019-01-17  Tom Tromey  <tromey@bapiya>
9316
9317         * valprint.c: Replace "the the" with "the".
9318         * symtab.c: Replace "the the" with "the".
9319         * solib.c: Replace "the the" with "the".
9320         * solib-dsbt.c: Replace "the the" with "the".
9321         * linespec.c: Replace "the the" with "the".
9322         * dwarf2loc.h: Replace "the the" with "the".
9323         * amd64-windows-tdep.c: Replace "the the" with "the".
9324         * aarch64-tdep.c: Replace "the the" with "the".
9325
9326 2019-01-16  Keith Seitz  <keiths@redhat.com>
9327
9328         PR gdb/23773
9329         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9330         <builder>: Rename to ..
9331         <m_builder>: ... this and make private.
9332         (dwarf2_cu::get_builder): New method.  Change all users of
9333         `builder' to use this method.
9334         (dwarf2_start_symtab): Move to ...
9335         (dwarf2_cu::start_symtab): ... here.  Update all callers
9336         (setup_type_unit_groups): Move to ...
9337         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9338         callers.
9339         (dwarf2_cu::reset_builder): New method.
9340         (process_full_compunit, process_full_type_unit): Use
9341         dwarf2_cu::reset_builder.
9342         (follow_die_offset): Record the ancestor CU if it is different
9343         from the followed DIE's CU.
9344         (follow_die_sig_1): Likewise.
9345
9346 2019-01-15  Tom Tromey  <tom@tromey.com>
9347
9348         * remote.c (class remote_state) <buf>: Now a char_vector.
9349         <buf_size>: Remove.
9350         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9351         parameter.
9352         (remote_target::getpkt_or_notif_sane_1)
9353         (remote_target::getpkt_sane)
9354         (remote_target::getpkt_or_notif_sane): Likewise.
9355         (class remote_target) <putpkt>: New overload.
9356         (remote_target::read_frame): Change type of "buf_p".  Remove
9357         sizeof_p parameter.
9358         (packet_ok): New overload.
9359         (packet_check_result): New overload.
9360         Update all uses.
9361
9362 2019-01-14  Tom Tromey  <tom@tromey.com>
9363
9364         * remote-notif.c (handle_notification, remote_notif_ack)
9365         (remote_notif_parse): Make "buf" const.
9366         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9367         const.
9368         (remote_notif_parse, remote_notif_ack, handle_notification):
9369         Likewise.
9370         * remote.c (remote_notif_stop_parse): Make "buf" const.
9371         (remote_target::remote_parse_stop_reply): Make "buf" const.
9372         (remote_notif_stop_ack): Make "buf" const.
9373
9374 2019-01-14  Tom Tromey  <tom@tromey.com>
9375
9376         * remote.c (remote_console_output): Make parameter const.
9377
9378 2019-01-14  Tom Tromey  <tom@tromey.com>
9379
9380         * target-debug.h (target_debug_print_signals): Constify.
9381         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9382         * procfs.c (procfs_target::pass_signals): Update.
9383         * linux-nat.c (linux_nat_target::pass_signals): Update.
9384         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9385         * target-delegates.c: Rebuild.
9386         * remote.c (remote_target::program_signals): Update.
9387         (remote_target::pass_signals): Update.
9388         * target.c (target_pass_signals): Constify argument.
9389         (target_program_signals): Likewise.
9390         * target.h (struct target_ops) <pass_signals, program_signals>:
9391         Constify argument.
9392         (target_pass_signals, target_program_signals): Constify argument.
9393
9394 2019-01-14  Tom Tromey  <tom@tromey.com>
9395
9396         PR tui/28819:
9397         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9398
9399 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9400
9401         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9402         field.
9403         * rs6000-tdep.c: Include reggroups.h.
9404         (IS_V_ALIAS_PSEUDOREG): Define.
9405         (rs6000_register_name): Return names for the "vX" aliases.
9406         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9407         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9408         aliases.  Call default_register_reggroup_p for all other
9409         pseudo-registers.
9410         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9411         New functions.
9412         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9413         Handle "vX" aliases.
9414         (v_alias_pseudo_register_collect): New function.
9415         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9416         (rs6000_gdbarch_init): Initialize "vX" aliases as
9417         pseudo-registers.  Restore registration of
9418         rs6000_pseudo_register_reggroup_p with
9419         set_tdesc_pseudo_register_reggroup_p.
9420
9421 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9422
9423         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9424         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9425         set_gdbarch_num_pseudo_regs.
9426
9427 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9428
9429         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9430         Remove arg prefixname, add do_set and do_show.
9431         Add member functions set_list and show_list.
9432         * cli/cli-style.c (class cli_style_option): Update accordingly.
9433         (style_set_list): Move to file scope.
9434         (style_show_list): Likewise.
9435         (set_style): Call help_list.
9436         (show_style): Call cmd_show_list.
9437         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9438         Update to use the new macro.
9439
9440 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9441
9442         * ada-lang.c (_initialize_ada_language): Expand the help text
9443         for the "catch exception" command.
9444
9445 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9446
9447         * symtab.c (matching_obj_sections): Initialize obj,
9448         declare it closer to its usage.
9449
9450 2019-01-10  Tom Tromey  <tom@tromey.com>
9451
9452         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9453         (basic_inf_threads_range): Remove.
9454         (inf_threads_range, inf_non_exited_threads_range)
9455         (safe_inf_threads_range): Use next_adapter.
9456
9457 2019-01-10  Keith Seitz  <keiths@redhat.com>
9458
9459         PR gdb/23712
9460         PR symtab/23010
9461         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9462         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9463
9464 2019-01-10  Keith Seitz  <keiths@redhat.com>
9465
9466         PR gdb/23712
9467         PR symtab/23010
9468         * dictionary.c (pending_to_vector): Remove.
9469         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9470         Remove _1 suffix, replacing functions of the same name.  Update
9471         all callers.
9472         (dict_create_hashed, dict_create_hashed_expandable)
9473         (dict_create_linear, dict_create_linear_expandable, dict_free)
9474         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9475         Make functions static.
9476
9477 2019-01-10  Keith Seitz  <keiths@redhat.com>
9478
9479         PR gdb/23712
9480         PR symtab/23010
9481         * dictionary.h (struct dictionary): Replace declaration with
9482         multidictionary.
9483         (dict_create_hashed, dict_create_hashed_expandable)
9484         (dict_create_linear, dict_create_linear_expandable)
9485         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9486         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9487         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9488         taking multidictionary argument.
9489         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9490         * block.h (struct block) <dict>: Change to multidictionary
9491         and rename `multidict'.
9492         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9493         symmisc.c: Update all dictionary references to multidictionary.
9494
9495 2019-01-10  Keith Seitz  <keiths@redhat.com>
9496
9497         PR gdb/23712
9498         PR symtab/23010
9499         * dictionary.c: Include unordered_map.
9500         (pending_to_vector): New function.
9501         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9502         Rewrite the non-"_1" functions to take vector instead
9503         of linked list.
9504         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9505         "new" _1 versions of the same name.
9506         (multidictionary): Define.
9507         (std::hash<enum language): New definition.
9508         (collate_pending_symbols_by_language, mdict_create_hashed)
9509         (mdict_create_hashed_expandable, mdict_create_linear)
9510         (mdict_create_linear_expandable, mdict_free)
9511         (find_language_dictionary, create_new_language_dictionary)
9512         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9513         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9514         (mdict_size, mdict_empty): New functions.
9515         * dictionary.h (mdict_iterator): Define.
9516
9517 2019-01-10  Pedro Alves  <palves@redhat.com>
9518
9519         * breakpoint.c (read_uploaded_action)
9520         (create_tracepoint_from_upload): Adjust to use
9521         gdb::unique_xmalloc_ptr.
9522         * ctf.c (ctf_write_uploaded_tp):
9523         (SET_ARRAY_FIELD): Use emplace_back.
9524         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9525         * tracefile-tfile.c (tfile_write_uploaded_tp):
9526         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9527         gdb::unique_xmalloc_ptr.
9528         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9529         at_string, cond_string, cmd_strings>: Replace char pointers
9530         with gdb::unique_xmalloc_ptr.
9531
9532 2019-01-10  Pedro Alves  <palves@redhat.com>
9533
9534         * solib-target.c (library_list_start_library): Don't xstrdup name.
9535
9536 2019-01-10  Pedro Alves  <palves@redhat.com>
9537
9538         * mdebugread.c (parse_partial_symbols): Use
9539         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9540
9541 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9542
9543         * linux-fork.c (scoped_switch_fork_info)
9544         <~scoped_switch_fork_info>: Fix incorrect variable name.
9545
9546 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9547
9548         * linux-fork.c (scoped_switch_fork_info)
9549         <scoped_switch_fork_info>: Make explicit.
9550         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9551
9552 2019-01-10  Tom Tromey  <tom@tromey.com>
9553
9554         * objfiles.h (objfile::reset_psymtabs): Update.
9555         * objfiles.c (objfile::objfile): Update.
9556         * psymtab.h (psymtab_storage::obstack): Update.
9557         (psymtab_storage::m_obstack): Use gdb::optional.
9558         (class psymtab_storage): Update comment.  Remove objfile
9559         parameter.
9560         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9561
9562 2019-01-10  Tom Tromey  <tom@tromey.com>
9563
9564         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9565         <free_psymtabs>: Now private.
9566         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9567         (allocate_psymtab): Use new method.
9568
9569 2019-01-10  Tom Tromey  <tom@tromey.com>
9570
9571         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9572         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9573         * mdebugread.c (parse_partial_symbols): Use
9574         allocate_dependencies.
9575         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9576         allocate_dependencies.
9577         (process_psymtab_comp_unit_reader)
9578         (build_type_psymtab_dependencies): Likewise.
9579         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9580
9581 2019-01-10  Tom Tromey  <tom@tromey.com>
9582
9583         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9584         PSYMBOL_SET_LANGUAGE.
9585         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9586
9587 2019-01-10  Tom Tromey  <tom@tromey.com>
9588
9589         * psymtab.h (psymtab_storage::obstack): New method.
9590         <m_obstack>: Rename from obstack; now private.
9591         * psymtab.c (psymtab_storage): Update.
9592         * dwarf2read.c (create_addrmap_from_index)
9593         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9594         Update.
9595
9596 2019-01-10  Tom Tromey  <tom@tromey.com>
9597
9598         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9599         * objfiles.h (objfile::reset_psymtabs): New method.
9600
9601 2019-01-10  Tom Tromey  <tom@tromey.com>
9602
9603         * symmisc.c (print_symbol_bcache_statistics): Update.
9604         (print_objfile_statistics): Update.
9605         * symfile.c (reread_symbols): Update.
9606         * psymtab.h (class psymtab_storage): New.
9607         * psymtab.c (psymtab_storage): New constructor.
9608         (~psymtab_storage): New destructor.
9609         (require_partial_symbols): Update.
9610         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9611         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9612         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9613         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9614         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9615         (start_psymtab_common, end_psymtab_common)
9616         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9617         (allocate_psymtab): Update.
9618         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9619         Update.
9620         (dump_psymtab_addrmap, maintenance_print_psymbols)
9621         (maintenance_check_psymtabs): Update.
9622         (class objfile_psymtabs): Move to objfiles.h.
9623         * psympriv.h (discard_psymtab): Now inline.
9624         (psymtab_discarder::psymtab_discarder): Update.
9625         (psymtab_discarder::~psymtab_discarder): Update.
9626         (ALL_OBJFILE_PSYMTABS): Rewrite.
9627         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9628         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9629         Remove fields.
9630         <partial_symtabs>: New field.
9631         (class objfile_psymtabs): Move from psymtab.h.  Update.
9632         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9633         psymbol_cache.
9634         (objfile::~objfile): Don't destroy psymbol_cache.
9635         * mdebugread.c (parse_partial_symbols): Update.
9636         * dwarf2read.c (create_addrmap_from_index)
9637         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9638         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9639         (add_partial_subprogram, dwarf2_ranges_read): Update.
9640         * dwarf-index-write.c (write_address_map)
9641         (write_one_signatured_type, recursively_write_psymbols)
9642         (class debug_names, class debug_names, write_psymtabs_to_index):
9643         Update.
9644
9645 2019-01-10  Tom Tromey  <tom@tromey.com>
9646
9647         * symtab.h (SYMBOL_SET_NAMES): Update.
9648         (symbol_set_names): Update.
9649         (MSYMBOL_SET_NAMES): Update.
9650         * symtab.c (symbol_set_names): Change argument to be an
9651         objfile_per_bfd_storage.
9652         * psymtab.c (add_psymbol_to_bcache): Update.
9653         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9654
9655 2019-01-10  Tom Tromey  <tom@tromey.com>
9656
9657         * symtab.c (create_demangled_names_hash): Change argument to be an
9658         objfile_per_bfd_storage.
9659         (symbol_set_names): Update.
9660
9661 2019-01-10  Tom Tromey  <tom@tromey.com>
9662
9663         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9664         init_psymbol_list.
9665         * psymtab.c (init_psymbol_list): Do nothing if already called.
9666         * psympriv.h (init_psymbol_list): Add comment.
9667         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9668         init_psymbol_list.
9669         * dbxread.c (dbx_symfile_read): Unconditionally call
9670         init_psymbol_list.
9671
9672 2019-01-10  Tom Tromey  <tom@tromey.com>
9673
9674         * xcoffread.c (scan_xcoff_symtab): Update.
9675         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9676         "where".
9677         * mdebugread.c (parse_partial_symbols)
9678         (handle_psymbol_enumerators): Update.
9679         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9680         * dbxread.c (read_dbx_symtab): Update.
9681         * psympriv.h (psymbol_placement): New enum.
9682         (add_psymbol_to_list): Update.
9683
9684 2019-01-10  Tom Tromey  <tom@tromey.com>
9685
9686         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9687         static_psymbols parameters.
9688         (scan_xcoff_symtab): Update.
9689         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9690         static_psymbols parameters.
9691         * psympriv.h (start_psymtab_common): Update.
9692         * mdebugread.c (parse_partial_symbols): Update.
9693         * dwarf2read.c (create_partial_symtab): Update.
9694         * dbxread.c (read_dbx_symtab): Update.
9695         (start_psymtab): Remove global_psymbols and static_psymbols
9696         parameters.
9697
9698 2019-01-10  Tom Tromey  <tom@tromey.com>
9699
9700         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9701         * psymtab.c (allocate_psymtab): Add comment.
9702         * psympriv.h (allocate_psymtab): Add comment.
9703         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9704         initializations.
9705         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9706
9707 2019-01-10  Tom Tromey  <tom@tromey.com>
9708
9709         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9710         Don't declare.
9711         * mipsread.c: Include mdebugread.h.
9712         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9713         Declare.
9714         * elfread.c: Include mdebugread.h.
9715
9716 2019-01-09  Tom Tromey  <tom@tromey.com>
9717
9718         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9719         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9720         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9721         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9722         (psym_lookup_symbol, psym_find_last_source_symtab)
9723         (psym_forget_cached_source_info, psym_print_stats)
9724         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9725         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9726         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9727         (psym_find_compunit_symtab_by_address)
9728         (maintenance_print_psymbols, maintenance_info_psymtabs)
9729         (maintenance_check_psymtabs): Use ranged for.
9730         * psymtab.h (class objfile_psymtabs): New.
9731         (require_partial_symbols): Return objfile_psymtabs.
9732         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9733
9734 2019-01-09  Tom Tromey  <tom@tromey.com>
9735
9736         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9737         (find_pc_mapped_section, list_overlays_command)
9738         (map_overlay_command, unmap_overlay_command)
9739         (simple_overlay_update): Use all_objfiles.
9740         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9741         * printcmd.c (info_symbol_command): Use all_objfiles.
9742         * objfiles.h (ALL_OBJSECTIONS): Remove.
9743         * maint.c (maintenance_translate_address): Use all_objfiles.
9744         * gcore.c (gcore_create_callback): Use all_objfiles.
9745         (objfile_find_memory_regions): Likewise.
9746
9747 2019-01-09  Tom Tromey  <tom@tromey.com>
9748
9749         * symtab.c (find_line_symtab, info_sources_command)
9750         (make_source_files_completion_list): Use objfile_compunits.
9751         * source.c (select_source_symtab): Use objfile_compunits.
9752         * objfiles.h (struct objfile): Update comment.
9753         (ALL_OBJFILES): Remove.
9754         (ALL_FILETABS): Remove.
9755         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9756         objfile_compunits.
9757
9758 2019-01-09  Tom Tromey  <tom@tromey.com>
9759
9760         * symmisc.c (print_objfile_statistics, dump_objfile)
9761         (maintenance_print_symbols): Use compunit_filetabs.
9762         * source.c (forget_cached_source_info_for_objfile): Use
9763         compunit_filetabs.
9764         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9765         (ALL_FILETABS): Use compunit_filetabs.
9766         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9767         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9768
9769 2019-01-09  Tom Tromey  <tom@tromey.com>
9770
9771         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9772         (compunit_filetabs): New.
9773         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9774         compunit_filetabs.
9775         (info_sources_command, make_source_files_completion_list): Remove
9776         declaration.
9777         * symmisc.c (print_objfile_statistics, dump_objfile)
9778         (maintenance_print_symbols): Remove declaration.
9779         (maintenance_info_symtabs): Use compunit_filetabs.
9780         (maintenance_info_line_tables): Likewise.
9781         * source.c (select_source_symtab): Change local variable name.
9782         (forget_cached_source_info_for_objfile): Remove declaration.
9783         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9784         * objfiles.c (objfile_relocate1): Remove declaration.
9785         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9786         declaration.
9787         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9788         * coffread.c (coff_symtab_read): Remove declaration.
9789         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9790         compunit_filetabs.
9791
9792 2019-01-09  Tom Tromey  <tom@tromey.com>
9793
9794         * symtab.c (lookup_objfile_from_block)
9795         (find_pc_sect_compunit_symtab, search_symbols)
9796         (default_collect_symbol_completion_matches_break_on): Use
9797         objfile_compunits.
9798         * objfiles.h (ALL_COMPUNITS): Remove.
9799         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9800         * cp-support.c (add_symbol_overload_list_qualified): Use
9801         objfile_compunits.
9802         * ada-lang.c (ada_collect_symbol_completion_matches)
9803         (ada_add_global_exceptions): Use objfile_compunits.
9804
9805 2019-01-09  Tom Tromey  <tom@tromey.com>
9806
9807         * source.c (select_source_symtab)
9808         (forget_cached_source_info_for_objfile): Remove declaration.
9809         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9810         declaration.
9811         * maint.c (count_symtabs_and_blocks): Remove declaration.
9812         * cp-support.c (add_symbol_overload_list_qualified): Remove
9813         declaration.
9814         * coffread.c (coff_symtab_read): Remove declaration.
9815         * symtab.c (lookup_symbol_in_objfile_symtabs)
9816         (basic_lookup_transparent_type_1): Use objfile_compunits.
9817         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9818         (info_sources_command, search_symbols)
9819         (default_collect_symbol_completion_matches_break_on)
9820         (make_source_files_completion_list): Remove declaration.
9821         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9822         (ada_collect_symbol_completion_matches)
9823         (ada_add_global_exceptions): Remove declaration.
9824         * linespec.c (iterate_over_all_matching_symtabs): Use
9825         objfile_compunits.
9826         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9827         (class objfile_compunits): New.
9828         (ALL_COMPUNITS): Use objfile_compunits.
9829         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9830         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9831         objfile_compunits.
9832         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9833
9834 2019-01-09  Tom Tromey  <tom@tromey.com>
9835
9836         * symtab.c (search_symbols)
9837         (default_collect_symbol_completion_matches_break_on): Use
9838         objfile_msymbols.
9839         * ada-lang.c (ada_lookup_simple_minsym)
9840         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9841         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9842         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9843         objfile_msymbols.
9844         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9845         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9846         * objc-lang.c (find_methods): Use objfile_msymbols.
9847         (info_selectors_command, info_classes_command): Likewise.
9848         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9849         * objfiles.h (class objfile_msymbols): New.
9850         (ALL_OBJFILE_MSYMBOLS): Remove.
9851         (ALL_MSYMBOLS): Remove.
9852
9853 2019-01-09  Tom Tromey  <tom@tromey.com>
9854
9855         * common/next-iterator.h (next_adapter): Add Iterator template
9856         parameter.
9857         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9858         (class all_objfiles_safe): New.
9859         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9860         * objfiles.c (put_objfile_before): Update comment.
9861         (add_separate_debug_objfile): Likewise.
9862         (free_all_objfiles): Use all_objfiles_safe.
9863         (objfile_purge_solibs): Likewise.
9864
9865 2019-01-09  Tom Tromey  <tom@tromey.com>
9866
9867         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9868         (expand_symtab_containing_pc, lookup_static_symbol)
9869         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9870         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9871         all_objfiles.
9872         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9873         * breakpoint.c (create_overlay_event_breakpoint)
9874         (create_longjmp_master_breakpoint)
9875         (create_std_terminate_master_breakpoint)
9876         (create_exception_master_breakpoint): Use all_objfiles.
9877         * linux-thread-db.c (try_thread_db_load_from_pdir)
9878         (has_libpthread): Use all_objfiles.
9879         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9880         * linespec.c (iterate_over_all_matching_symtabs)
9881         (search_minsyms_for_name): Use all_objfiles.
9882         * maint.c (maintenance_info_sections): Use all_objfiles.
9883         * main.c (captured_main_1): Use all_objfiles.
9884         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9885         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9886         * guile/scm-pretty-print.c
9887         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9888         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9889         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9890         (maintenance_print_msymbols): Use all_objfiles.
9891         * source.c (select_source_symtab): Use all_objfiles.
9892         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9893         * symfile.c (remove_symbol_file_command)
9894         (expand_symtabs_matching, map_symbol_filenames): Use
9895         all_objfiles.
9896         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9897         all_objfiles.
9898         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9899         * objc-lang.c (find_methods): Use all_objfiles.
9900         * objfiles.c (have_partial_symbols, have_full_symbols)
9901         (have_minimal_symbols, qsort_cmp)
9902         (default_iterate_over_objfiles_in_search_order): Use
9903         all_objfiles.
9904         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9905         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9906         (maintenance_check_psymtabs): Use all_objfiles.
9907         (ALL_PSYMTABS): Remove.
9908         * compile/compile-object-run.c (do_module_cleanup): Use
9909         all_objfiles.
9910         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9911         * cp-support.c (add_symbol_overload_list_qualified): Use
9912         all_objfiles.
9913         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9914         Use all_objfiles.
9915         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9916         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9917         all_objfiles.
9918         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9919         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9920         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9921         Uses all_objfiles.
9922         * solib.c (solib_read_symbols): Use all_objfiles
9923
9924 2019-01-09  Tom Tromey  <tom@tromey.com>
9925
9926         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9927         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9928         all_objfiles.
9929         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9930         * symmisc.c (print_symbol_bcache_statistics)
9931         (print_objfile_statistics, maintenance_print_objfiles)
9932         (maintenance_info_symtabs, maintenance_check_symtabs)
9933         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9934         all_objfiles.
9935         * source.c (forget_cached_source_info): Use all_objfiles.
9936         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9937         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9938         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9939         * objfiles.c (update_section_map): Use all_objfiles.
9940         (shared_objfile_contains_address_p): Likewise.
9941         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9942         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9943
9944 2019-01-09  Tom Tromey  <tom@tromey.com>
9945
9946         * common/next-iterator.h: New file.
9947         * objfiles.h (class all_objfiles): New.
9948         (struct objfile_iterator): New.
9949
9950 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9951
9952         * NEWS: Move the description of the changed "frame", "select-frame",
9953          and "info frame" commands to the Changed commands section.
9954
9955 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9956
9957         * gdbtypes.c (check_stub_method_group): Remove handling of old
9958         mangling schemes.
9959         * linespec.c (find_methods): Likewise.
9960         * stabsread.c (read_member_functions): Likewise.
9961         * valops.c (search_struct_method): Likewise.
9962         (value_struct_elt_for_reference): Likewise.
9963         * NEWS: Mention this change.
9964
9965 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9966
9967         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9968         print_source_lines.
9969         * source.c (print_source_lines_base): Update line number check.
9970         (print_source_lines): New function.
9971         (source_lines_range::source_lines_range): New function.
9972         * source.h (class source_lines_range): New class.
9973         (print_source_lines): New declaration.
9974
9975 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9976
9977         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9978
9979 2019-01-08  Tom Tromey  <tom@tromey.com>
9980             Simon Marchi  <simon.marchi@ericsson.com>
9981
9982         PR gdb/24060
9983         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9984         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9985         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9986         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9987         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9988         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9989
9990 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9991
9992         * source.c (select_source_symtab): Move header comment to
9993         declaration in source.h.
9994         (forget_cached_source_info_for_objfile): Likewise.
9995         (forget_cached_source_info): Likewise.
9996         (identify_source_line): Likewise.
9997         * source.h (identify_source_line): Move declaration from symtab.h
9998         and add comment from source.c
9999         (print_source_lines): Likewise.
10000         (forget_cached_source_info_for_objfile): Likewise.
10001         (forget_cached_source_info): Likewise.
10002         (select_source_symtab): Likewise.
10003         (enum print_source_lines_flag): Move definition from symtab.h.
10004         * symtab.h (identify_source_line): Move declaration to source.h.
10005         (print_source_lines): Likewise.
10006         (forget_cached_source_info_for_objfile): Likewise.
10007         (forget_cached_source_info): Likewise.
10008         (select_source_symtab): Likewise.
10009         (enum print_source_lines_flag): Move definition to source.h.
10010         * tui/tui-hooks.c: Add 'source.h' include.
10011
10012 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10013
10014         * source.c (print_source_lines_base): Handle requests to print
10015         reverse line number sequences, and guard against empty lines
10016         string.
10017
10018 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10019
10020         * source.c (print_source_lines_base): Fix skip of '\r' if next
10021         character is '\n'.
10022
10023 2019-01-06  Tom Tromey  <tom@tromey.com>
10024
10025         * c-exp.y (struct c_parse_state) <macro_original_text,
10026         expansion_obstack>: New member.
10027         (macro_original_text, expansion_obstack): Remove globals.
10028         (scan_macro_expansion, scanning_macro_expansion)
10029         (finished_macro_expansion): Update.
10030         (scan_macro_cleanup): Remove.
10031         (yylex, c_parse): Update.
10032
10033 2019-01-06  Tom Tromey  <tom@tromey.com>
10034
10035         * c-exp.y (struct c_parse_state) <strings>: New member.
10036         (operator_stoken): Update.
10037
10038 2019-01-06  Tom Tromey  <tom@tromey.com>
10039
10040         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10041         (union type_stack_elt) <typelist_val>: Now a pointer to
10042         std::vector.
10043         (type_stack_cleanup): Don't declare.
10044         (push_typelist): Update.
10045         * parse.c (pop_typelist): Return a std::vector.
10046         (push_typelist): Take a std::vector.
10047         (follow_types): Update.  Do not free args.
10048         (type_stack_cleanup): Remove.
10049         * c-exp.y (struct c_parse_state): New.
10050         (cpstate): New global.
10051         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10052         (nonempty_typelist): Update.
10053         (func_mod): Create a new vector.
10054         (c_parse): Create a c_parse_state.
10055         (check_parameter_typelist): Do not delete params.
10056         (function_method): Update.  Do not delete type_list.
10057
10058 2019-01-06  Tom Tromey  <tom@tromey.com>
10059
10060         PR gdb/28155:
10061         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10062         check_typedef.
10063         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10064         (print_return_value): Likewise.
10065
10066 2019-01-05  Tom Tromey  <tom@tromey.com>
10067
10068         * contrib/cleanup_check.py: Remove.
10069         * contrib/gcc-with-excheck: Remove.
10070         * contrib/exsummary.py: Remove.
10071         * contrib/excheck.py: Remove.
10072
10073 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10074
10075         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10076         NULL. Initialize tpprev to NULL instead of assigning it
10077         to NULL on the next statement.
10078         * windows-nat.c (windows_delete_thread): Remove check for
10079         main_thread_id before printing thread exit notifications.
10080         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10081         Remove thread ID check against main_thread_id.
10082         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10083         windows_delete_thread.
10084         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10085
10086 2019-01-04  Tom Tromey  <tom@tromey.com>
10087
10088         * compile/compile.c (_initialize_compile): Use upper case for
10089         metasyntactic variables.
10090         * symmisc.c (_initialize_symmisc): Use upper case for
10091         metasyntactic variables.
10092         * psymtab.c (_initialize_psymtab): Use upper case for
10093         metasyntactic variables.
10094         * demangle.c (demangle_command): Use upper case for metasyntactic
10095         variables.
10096         (_initialize_demangler): Likewise.
10097         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10098         variables.
10099
10100 2019-01-03  Tom Tromey  <tom@tromey.com>
10101
10102         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10103
10104 2019-01-03  Tom Tromey  <tom@tromey.com>
10105
10106         * python/py-symtab.c (salpy_str): Update.
10107         (struct salpy_sal_object) <symtab>: Now a PyObject.
10108         (salpy_dealloc): Update.
10109         (del_objfile_sal): Use gdbpy_ref.
10110
10111 2019-01-03  Tom Tromey  <tom@tromey.com>
10112
10113         * python/py-type.c (convert_field): Use new_reference.  Return
10114         gdbpy_ref.
10115         (make_fielditem): Return gdbpy_ref.
10116         (typy_fields): Update.
10117         (typy_getitem): Update.
10118         (field_name): Return gdbpy_ref.  Use new_reference.
10119         (typy_iterator_iternext): Update.
10120
10121 2019-01-03  Tom Tromey  <tom@tromey.com>
10122
10123         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10124
10125 2019-01-03  Tom Tromey  <tom@tromey.com>
10126
10127         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10128         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10129         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10130         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10131         (pspy_set_type_printers): Likewise.
10132         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10133         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10134         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10135         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10136         (objfpy_set_type_printers): Likewise.
10137
10138 2019-01-03  Tom Tromey  <tom@tromey.com>
10139
10140         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10141         (gdbpy_print_stack): Use gdbpy_err_fetch.
10142         * python/python-internal.h (class gdbpy_err_fetch): New class.
10143         (class gdbpy_enter) <m_error_type, m_error_value,
10144         m_error_traceback>: Remove.
10145         <m_error>: New member.
10146         (gdbpy_exception_to_string): Don't declare.
10147         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10148         * python/py-value.c (convert_value_from_python): Use
10149         gdbpy_err_fetch.
10150         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10151         gdbpy_exception_to_string.
10152         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10153         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10154         gdbpy_err_fetch.
10155
10156 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10157
10158         * linux-nat.c (delete_lwp_cleanup): Delete.
10159         (struct lwp_deleter): New struct.
10160         (lwp_info_up): New typedef.
10161         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10162         lwp_info_up.
10163
10164 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10165
10166         * linux-fork.c (class scoped_switch_fork_info): New class.
10167         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10168
10169 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10170
10171         * valops.c (find_overload_match): Remove use of null_cleanup, and
10172         calls to do_cleanups.
10173
10174 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10175
10176         * compile/compile-cplus-types.c
10177         (compile_cplus_instance::decl_name): Handle changes to
10178         cp_func_name.
10179         * cp-support.c (cp_func_name): Update header comment, update
10180         return type.
10181         * cp-support.h (cp_func_name): Update return type in declaration.
10182         * valops.c (find_overload_match): Move temp_func local to top
10183         level of function and change its type.  Use temp_func to hold and
10184         delete temporary string obtained from cp_func_name.
10185
10186 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10187
10188         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10189         gdb::char_vector, remove cleanup, and update uses of `msg`.
10190
10191 2019-01-03  Jim Wilson  <jimw@sifive.com>
10192
10193         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10194
10195 2019-01-02  Tom Tromey  <tom@tromey.com>
10196
10197         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10198         (tdesc_parse_xml): Remove cleanups.
10199         * target-descriptions.h (make_cleanup_free_target_description):
10200         Don't declare.
10201         (target_desc_deleter): New struct.
10202         (target_desc_up): New typedef.
10203         * target-descriptions.c (target_desc_deleter::operator()): Rename
10204         from free_target_description.
10205         (make_cleanup_free_target_description): Remove.
10206
10207 2019-01-02  Tom Tromey  <tom@tromey.com>
10208
10209         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10210         constructor, destructor.
10211         (linespec_parser): Remove typedef.
10212         (~linespec_parser): Rename from linespec_parser_delete.
10213         (linespec_lex_to_end, linespec_complete_label)
10214         (linespec_complete): Update.
10215         (decode_line_full): Remove cleanups.
10216         (decode_line_1): Update.
10217
10218 2019-01-02  Tom Tromey  <tom@tromey.com>
10219
10220         * python/python-internal.h (inferior_to_inferior_object): Change
10221         return type.
10222         * python/py-exitedevent.c (create_exited_event_object): Update.
10223         * python/py-inferior.c (inferior_to_inferior_object): Return
10224         gdbpy_ref.
10225         (python_new_inferior, python_inferior_deleted)
10226         (thread_to_thread_object, delete_thread_object)
10227         (build_inferior_list, gdbpy_selected_inferior): Update.
10228         * python/py-infthread.c (create_thread_object): Update.  Also fail
10229         if inferior_to_inferior_object fails.
10230
10231 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10232
10233         * inferior.h (class inferior) <displaced_step_state>: New field.
10234         * infrun.h (struct displaced_step_state): Move here from
10235         infrun.c.  Initialize fields, add constructor.
10236         <inf>: Remove field.
10237         <reset>: New method.
10238         * infrun.c (struct displaced_step_inferior_state): Move to
10239         infrun.h.
10240         (displaced_step_inferior_states): Remove.
10241         (get_displaced_stepping_state): Adust.
10242         (displaced_step_in_progress_any_inferior): Adjust.
10243         (displaced_step_in_progress_thread): Adjust.
10244         (displaced_step_in_progress): Adjust.
10245         (add_displaced_stepping_state): Remove.
10246         (get_displaced_step_closure_by_addr): Adjust.
10247         (remove_displaced_stepping_state): Remove.
10248         (infrun_inferior_exit): Call displaced_step_state.reset.
10249         (use_displaced_stepping): Don't check for NULL.
10250         (displaced_step_prepare_throw): Call
10251         get_displaced_stepping_state.
10252         (displaced_step_fixup): Don't check for NULL.
10253         (prepare_for_detach): Don't check for NULL.
10254
10255 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10256
10257         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10258          in case of call that did not complete.
10259
10260 2019-01-02  Andrey Utkin  <autkin@undo.io>
10261
10262         * symfile.c (find_separate_debug_file): Fix search of debug files for
10263         remote debuggee.
10264
10265 2019-01-02  Tom Tromey  <tom@tromey.com>
10266
10267         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10268         indentation.
10269         * python/py-frame.c (frapy_older): Remove cast.
10270         (frapy_newer): Likewise.
10271         * python/py-breakpoint.c (local_setattro): Remove cast.
10272         * python/py-arch.c (archpy_name): Remove local variable.
10273         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10274
10275 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10276
10277         * unittests/basic_string_view/element_access/char/empty.cc:
10278         Fix year range in copyright header.
10279
10280 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10281
10282         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10283         Delete.
10284         <operator==>: Update with for removed field.
10285         <hash>: Likewise.
10286         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10287         <isa_features>: ...this.
10288         <abi_features>: New field.
10289         (riscv_isa_flen): Update comment.
10290         (riscv_abi_xlen): New declaration.
10291         (riscv_abi_flen): New declaration.
10292         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10293         isa_features.
10294         (riscv_abi_xlen): New function.
10295         (riscv_isa_flen): Update to get answer from isa_features.
10296         (riscv_abi_flen): New function.
10297         (riscv_has_fp_abi): Update to get answer from abi_features.
10298         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10299         xlen and flen.
10300         (riscv_call_info) <xlen, flen>: Update comment.
10301         (riscv_call_arg_struct): Remove invalid assertions
10302         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10303         is removed.
10304         (riscv_gdbarch_init): Gather isa features and abi features
10305         separately, ensure both match on the gdbarch when reusing an old
10306         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10307         a target with 64-bit float hardware.
10308
10309 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10310
10311         * source.c (search_command_helper): Stop reverse search
10312         when line 1 has been searched.
10313
10314 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10315
10316         * record-full.c (record_full_base_target::close): Rewrite
10317         record_full_core_buf_list free logic.
10318
10319 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10320
10321         * break-catch-syscall.c (print_one_catch_syscall): xfree
10322         the last text.
10323
10324 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10325
10326         * top.c (print_gdb_version): Update Copyright year in version
10327         message.
10328
10329 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10330
10331         Update copyright year range in all GDB files.
10332
10333 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10334
10335         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10336
10337 For older changes see ChangeLog-2018.
10338 \f
10339 Local Variables:
10340 mode: change-log
10341 left-margin: 8
10342 fill-column: 74
10343 version-control: never
10344 coding: utf-8
10345 End:
10346