gdb/ChangeLog

   1 2020-04-01  Tom Tromey  <tom@tromey.com>
   2
   3         * valprint.c (generic_value_print_complex): Use accessors.
   4         * value.h (value_real_part, value_imaginary_part): Declare.
   5         * valops.c (value_real_part, value_imaginary_part): New
   6         functions.
   7         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
   8
   9 2020-04-01  Tom Tromey  <tom@tromey.com>
  10
  11         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
  12         (read_range_type): Update.
  13         * mdebugread.c (basic_type): Update.
  14         * go-lang.c (build_go_types): Use init_complex_type.
  15         * gdbtypes.h (struct main_type) <complex_type>: New member.
  16         (init_complex_type): Update.
  17         (arch_complex_type): Don't declare.
  18         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
  19         Make name if none given.  Use alloc_type_copy.  Look for cached
  20         complex type.
  21         (arch_complex_type): Remove.
  22         (gdbtypes_post_init): Use init_complex_type.
  23         * f-lang.c (build_fortran_types): Use init_complex_type.
  24         * dwarf2/read.c (read_base_type): Update.
  25         * d-lang.c (build_d_types): Use init_complex_type.
  26         * ctfread.c (read_base_type): Update.
  27
  28 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  29
  30         * infrun.c (stop_all_threads): Update assertion, plus when
  31         stopping threads, take into account that we might be trying
  32         to stop an all-stop target.
  33         (stop_waiting): Call 'stop_all_threads' if there exists a
  34         non-stop target.
  35
  36 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  37
  38         * target.h (exists_non_stop_target): New function declaration.
  39         * target.c (exists_non_stop_target): New function.
  40
  41 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
  42
  43         PR gdb/24789
  44         * eval.c (is_integral_or_integral_reference): New function.
  45         (evaluate_subexp_standard): Allow integer references in
  46         pointer arithmetic.
  47
  48 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  49
  50         * remote.c (remote_target::remote_parse_stop_reply): Remove the
  51         check for no ptid in the stop reply when the target is non-stop.
  52
  53 2020-04-01  Tom Tromey  <tromey@adacore.com>
  54
  55         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
  56         "name" parameter to rvalue reference.  Initialize m_name_holder.
  57         <lookup_name_info>: New overloads.
  58         <name>: Return gdb::string_view.
  59         <c_str>: New method.
  60         <make_ignore_params>: Update.
  61         <search_name_hash>: Update.
  62         <language_lookup_name>: Return const char *.
  63         <m_name>: Change type.
  64         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
  65         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
  66         (lookup_name_info::match_any): Update.
  67         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
  68         Update.
  69         * minsyms.c (linkage_name_str): Update.
  70         * language.c (default_symbol_name_matcher): Update.
  71         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
  72         Update.
  73         * ada-lang.c (ada_fold_name): Change parameter to string_view.
  74         (ada_lookup_name_info::ada_lookup_name_info): Update.
  75         (literal_symbol_name_matcher): Update.
  76
  77 2020-04-01  Tom Tromey  <tromey@adacore.com>
  78
  79         * psymtab.c (psymtab_search_name): Remove function.
  80         (psym_lookup_symbol): Create search name and lookup name here.
  81         (lookup_partial_symbol): Remove "name" parameter; add
  82         lookup_name.
  83         (psym_expand_symtabs_for_function): Update.
  84
  85 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
  86
  87         PR tui/25597:
  88         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
  89
  90 2020-03-31  Tom Tromey  <tromey@adacore.com>
  91
  92         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
  93         memcpy.
  94
  95 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
  96
  97         * features/riscv/32bit-csr.xml: Regenerated.
  98         * features/riscv/64bit-csr.xml: Regenerated.
  99
 100 2020-03-30  Tom Tromey  <tromey@adacore.com>
 101
 102         * ada-valprint.c (print_variant_part): Update.
 103         * ada-lang.h (ada_which_variant_applies): Update.
 104         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
 105         outer_valaddr parameters; replace with "outer" value parameter.
 106         (to_fixed_variant_branch_type): Update.
 107
 108 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 109
 110         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
 111         <list>.  Remove inclusion of observable.h.
 112         (PPC_DEBUG_CURRENT_VERSION): Move up define.
 113         (struct arch_lwp_info): New struct.
 114         (class ppc_linux_dreg_interface): New class.
 115         (struct ppc_linux_process_info): New struct.
 116         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
 117         <low_new_clone, low_forget_process, low_prepare_to_resume>
 118         <copy_thread_dreg_state, mark_thread_stale>
 119         <mark_debug_registers_changed, register_hw_breakpoint>
 120         <clear_hw_breakpoint, register_wp, clear_wp>
 121         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
 122         <num_memory_accesses, get_trigger_type>
 123         <create_watchpoint_request, hwdebug_point_cmp>
 124         <init_arch_lwp_info, get_arch_lwp_info>
 125         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
 126         methods.
 127         <struct ptid_hash>: New inner struct.
 128         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
 129         members.
 130         (saved_dabr_value, hwdebug_info, max_slots_number)
 131         (struct hw_break_tuple, struct thread_points, ppc_threads)
 132         (have_ptrace_hwdebug_interface)
 133         (hwdebug_find_thread_points_by_tid)
 134         (hwdebug_insert_point, hwdebug_remove_point): Remove.
 135         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
 136         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
 137         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
 138         use m_dreg_interface.
 139         (hwdebug_point_cmp): Change to...
 140         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
 141         reference arguments instead of pointers.
 142         (ppc_linux_nat_target::ranged_break_num_registers): Use
 143         m_dreg_interface.
 144         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
 145         m_dreg_interface.  Call register_hw_breakpoint.
 146         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
 147         m_dreg_interface.  Call clear_hw_breakpoint.
 148         (get_trigger_type): Change to...
 149         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
 150         comment.
 151         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
 152         use m_dreg_interface.  Call register_hw_breakpoint.
 153         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
 154         use m_dreg_interface.  Call clear_hw_breakpoint.
 155         (can_use_watchpoint_cond_accel): Change to...
 156         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
 157         method.  Update comment, use m_dreg_interface and
 158         m_process_info.
 159         (calculate_dvc): Change to...
 160         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
 161         m_dreg_interface.
 162         (num_memory_accesses): Change to...
 163         (ppc_linux_nat_target::num_memory_accesses): ...this method.
 164         (check_condition): Change to...
 165         (ppc_linux_nat_target::check_condition): ...this method.
 166         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
 167         comment, use m_dreg_interface.
 168         (create_watchpoint_request): Change to...
 169         (ppc_linux_nat_target::create_watchpoint_request): ...this
 170         method.  Use m_dreg_interface.
 171         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
 172         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
 173         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
 174         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
 175         (ppc_linux_nat_target::low_forget_process)
 176         (ppc_linux_nat_target::low_new_fork)
 177         (ppc_linux_nat_target::low_new_clone)
 178         (ppc_linux_nat_target::low_delete_thread)
 179         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
 180         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
 181         only call mark_thread_stale.
 182         (ppc_linux_thread_exit): Remove.
 183         (ppc_linux_nat_target::stopped_data_address): Change to...
 184         (ppc_linux_nat_target::low_stopped_data_address): This. Add
 185         comment, use m_dreg_interface and m_thread_hw_breakpoints.
 186         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
 187         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
 188         comment.  Call low_stopped_data_address.
 189         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
 190         m_dreg_interface.
 191         (ppc_linux_nat_target::masked_watch_num_registers): Use
 192         m_dreg_interface.
 193         (ppc_linux_nat_target::copy_thread_dreg_state)
 194         (ppc_linux_nat_target::mark_thread_stale)
 195         (ppc_linux_nat_target::mark_debug_registers_changed)
 196         (ppc_linux_nat_target::register_hw_breakpoint)
 197         (ppc_linux_nat_target::clear_hw_breakpoint)
 198         (ppc_linux_nat_target::register_wp)
 199         (ppc_linux_nat_target::clear_wp)
 200         (ppc_linux_nat_target::init_arch_lwp_info)
 201         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
 202         (_initialize_ppc_linux_nat): Remove observer callback.
 203
 204 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 205
 206         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
 207         (ppc_linux_nat_target::auxv_parse)
 208         (ppc_linux_nat_target::read_description)
 209         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
 210         Move up.
 211
 212 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 213
 214         * linux-nat.h (low_new_clone): New method.
 215         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
 216
 217 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
 218
 219         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
 220         (dbx_expand_psymtab): ... this.
 221         (start_psymtab): Update.
 222         * mdebugread.c (psymtab_to_symtab_1): Rename to...
 223         (mdebug_expand_psymtab): ... this.
 224         (parse_partial_symbols): Update.
 225         (new_psymtab): Update.
 226         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
 227         (xcoff_expand_psymtab): ... this.
 228         (xcoff_start_psymtab): Update.
 229
 230 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
 231
 232         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
 233         <expand_dependencies>: ... this.
 234         * psymtab.c (partial_symtab::read_dependencies): Rename to...
 235         (partial_symtab::expand_dependencies): ... this.
 236         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
 237         Update.
 238         (dwarf2_psymtab::expand_psymtab): Update.
 239         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
 240         * mdebugread.c (psymtab_to_symtab_1): Update.
 241         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
 242
 243 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
 244
 245         * psympriv.h (discard_psymtab): Remove.
 246         * dbxread.c (dbx_end_psymtab): Update.
 247         * xcoffread.c (xcoff_end_psymtab): Update.
 248
 249 2020-03-28  Tom Tromey  <tom@tromey.com>
 250
 251         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
 252         comment.
 253
 254 2020-03-28  Tom Tromey  <tom@tromey.com>
 255
 256         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
 257
 258 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
 259
 260         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
 261
 262 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
 263
 264         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
 265
 266 2020-03-26  Tom Tromey  <tom@tromey.com>
 267
 268         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
 269         (mark_common_block_symbol_computed, read_tag_string_type)
 270         (attr_to_dynamic_prop, read_subrange_type): Update.
 271         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
 272         to be methods on struct attribute.
 273         (skip_one_die, process_imported_unit_die, read_namespace_alias)
 274         (read_call_site_scope, partial_die_info::read)
 275         (partial_die_info::read, lookup_die_type, follow_die_ref):
 276         Update.
 277         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
 278         from dwarf2_get_ref_die_offset.
 279         (attribute::constant_value): New method, from
 280         dwarf2_get_attr_constant_value.
 281         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
 282         Declare method.
 283         <constant_value>: New method.
 284
 285 2020-03-26  Tom Tromey  <tom@tromey.com>
 286
 287         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
 288         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
 289         (dwarf_type_encoding_name): Move to stringify.c.
 290         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
 291         * dwarf2/stringify.c: New file.
 292         * dwarf2/stringify.h: New file.
 293
 294 2020-03-26  Tom Tromey  <tom@tromey.com>
 295
 296         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
 297         Rewrite.
 298
 299 2020-03-26  Tom Tromey  <tom@tromey.com>
 300
 301         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
 302         methods.
 303         * dwarf2/read.c (lookup_addr_base): Move to die.h.
 304         (lookup_ranges_base): Likewise.
 305         (read_cutu_die_from_dwo, read_full_die_1): Update.
 306
 307 2020-03-26  Tom Tromey  <tom@tromey.com>
 308
 309         * dwarf2/read.c (read_import_statement, read_file_scope)
 310         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
 311         (read_lexical_block_scope, read_call_site_scope)
 312         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
 313         (handle_struct_member_die, process_structure_scope)
 314         (update_enumeration_type_from_children)
 315         (process_enumeration_scope, read_array_type, read_common_block)
 316         (read_namespace, read_module, read_subroutine_type): Update.
 317         (sibling_die): Remove.
 318
 319 2020-03-26  Tom Tromey  <tom@tromey.com>
 320
 321         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
 322         (build_type_psymtabs_reader, read_structure_type)
 323         (read_enumeration_type, read_full_die_1): Update.
 324         (dwarf2_attr_no_follow): Move to die.h.
 325         * dwarf2/die.h (struct die_info) <attr>: New method.
 326
 327 2020-03-26  Tom Tromey  <tom@tromey.com>
 328
 329         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
 330         <base_address>: Now an optional.
 331         (dwarf2_find_base_address, dwarf2_rnglists_process)
 332         (dwarf2_ranges_process, fill_in_loclist_baton)
 333         (dwarf2_symbol_mark_computed): Update.
 334
 335 2020-03-26  Tom Tromey  <tom@tromey.com>
 336
 337         * dwarf2/read.c (struct die_info): Move to die.h.
 338         * dwarf2/die.h: New file.
 339
 340 2020-03-26  Tom Tromey  <tom@tromey.com>
 341
 342         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
 343         * dwarf2/read.c
 344         (dwarf2_statement_list_fits_in_line_number_section_complaint):
 345         Move to line-header.c.
 346         (read_checked_initial_length_and_offset, read_formatted_entries):
 347         Likewise.
 348         (dwarf_decode_line_header): Split into two.
 349         * dwarf2/line-header.c
 350         (dwarf2_statement_list_fits_in_line_number_section_complaint):
 351         Move from read.c.
 352         (read_checked_initial_length_and_offset, read_formatted_entries):
 353         Likewise.
 354         (dwarf_decode_line_header): New function, split from read.c.
 355
 356 2020-03-26  Tom Tromey  <tom@tromey.com>
 357
 358         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
 359         Declare method.
 360         * dwarf2/read.c (read_attribute_value): Update.
 361         (dwarf2_per_objfile::read_line_string): Rename from
 362         read_indirect_line_string.
 363         (read_formatted_entries): Update.
 364
 365 2020-03-26  Tom Tromey  <tom@tromey.com>
 366
 367         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
 368         variable.
 369
 370 2020-03-26  Tom Tromey  <tom@tromey.com>
 371
 372         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
 373         const.
 374         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
 375         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
 376         parameter const.
 377
 378 2020-03-26  Tom Tromey  <tom@tromey.com>
 379
 380         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
 381         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
 382         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
 383         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
 384
 385 2020-03-26  Tom Tromey  <tom@tromey.com>
 386
 387         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
 388         file_names_size, file_full_name, file_file_name>: Use const.
 389         <file_name_at, file_names>: Add const overload.
 390         * dwarf2/line-header.c (line_header::file_file_name)
 391         (line_header::file_full_name): Update.
 392
 393 2020-03-26  Tom Tromey  <tom@tromey.com>
 394
 395         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
 396         (macro_start_file, consume_improper_spaces)
 397         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
 398         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
 399         (dwarf_decode_macros): Move to macro.c.
 400         * dwarf2/macro.c: New file.
 401         * dwarf2/macro.h: New file.
 402         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
 403
 404 2020-03-26  Tom Tromey  <tom@tromey.com>
 405
 406         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
 407         method.
 408         * dwarf2/section.c: New method.  From
 409         read_indirect_string_at_offset_from.
 410         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
 411         (read_indirect_string_at_offset_from): Move to section.c.
 412         (read_indirect_string_at_offset): Rewrite.
 413         (read_indirect_line_string_at_offset): Remove.
 414         (read_indirect_string, read_indirect_line_string)
 415         (dwarf_decode_macro_bytes): Update.
 416
 417 2020-03-26  Tom Tromey  <tom@tromey.com>
 418
 419         * dwarf2/section.h (struct dwarf2_section_info)
 420         <overload_complaint>: Declare.
 421         (dwarf2_section_buffer_overflow_complaint): Don't declare.
 422         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
 423         Rename from dwarf2_section_buffer_overflow_complaint.
 424         * dwarf2/read.c (skip_one_die, partial_die_info::read)
 425         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
 426
 427 2020-03-26  Tom Tromey  <tom@tromey.com>
 428
 429         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
 430         Declare.
 431         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
 432         Move from read.c.
 433         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
 434         to section.c.
 435
 436 2020-03-26  Tom Tromey  <tom@tromey.com>
 437
 438         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
 439
 440 2020-03-26  Tom Tromey  <tom@tromey.com>
 441
 442         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
 443         "builder".
 444         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
 445         parameter.
 446         (dwarf_decode_macros): Update.
 447
 448 2020-03-26  Tom Tromey  <tom@tromey.com>
 449
 450         * dwarf2/read.c (read_attribute_value): Update.
 451         (read_indirect_string_from_dwz): Move to dwz.c; change into
 452         method.
 453         (dwarf_decode_macro_bytes): Update.
 454         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
 455         * dwarf2/dwz.c: New file.
 456         * Makefile.in (COMMON_SFILES): Add dwz.c.
 457
 458 2020-03-26  Tom Tromey  <tom@tromey.com>
 459
 460         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
 461         * dwarf2/read.c: Add include.
 462         * dwarf2/index-write.c: Add include.
 463         * dwarf2/index-cache.c: Add include.
 464         * dwarf2/dwz.h: New file.
 465
 466 2020-03-25  Tom Tromey  <tom@tromey.com>
 467
 468         * compile/compile-object-load.c (get_out_value_type): Mention
 469         correct symbol name in error message.
 470
 471 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
 472
 473         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
 474
 475 2020-03-25  Tom de Vries  <tdevries@suse.de>
 476
 477         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
 478         * symmisc.c (dump_symtab_1): Print user and includes fields.
 479         (maintenance_info_symtabs): Same.
 480
 481 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 482
 483         PR gdb/25534
 484         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
 485         (riscv_regcache_cooked_write): New function.
 486         (riscv_push_dummy_call): Use new function.
 487         (riscv_return_value): Likewise.
 488
 489 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
 490
 491         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
 492         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
 493         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
 494         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
 495         * infrun.c (follow_fork): Likewise.
 496         (follow_fork_inferior): Likewise.
 497         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
 498         * linux-nat.h (class linux_nat_target): Likewise.
 499         * remote.c (class remote_target) <follow_fork>: Likewise.
 500         (remote_target::follow_fork): Likewise.
 501         * target-delegates.c: Re-generate.
 502         * target.c (default_follow_fork): Likewise.
 503         (target_follow_fork): Likewise.
 504         * target.h (struct target_ops) <follow_fork>: Likewise.
 505         (target_follow_fork): Likewise.
 506
 507 2020-03-24  Tom de Vries  <tdevries@suse.de>
 508
 509         * psymtab.c (maintenance_info_psymtabs): Print user field.
 510
 511 2020-03-20  Tom Tromey  <tromey@adacore.com>
 512
 513         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
 514         const.
 515         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
 516         const.
 517
 518 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
 519
 520         * ptrace.m4: Don't check for ptrace declaration.
 521         * config.in: Re-generate.
 522         * configure: Re-generate.
 523         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
 524         not defined.
 525
 526 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
 527
 528         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
 529         `PTRACE_TYPE_RET'.
 530         * i386-bsd-nat.c (gdb_ptrace): Likewise.
 531         * sparc-nat.c (gdb_ptrace): Likewise.
 532         * x86-bsd-nat.c (gdb_ptrace): Likewise.
 533
 534 2020-03-20  Tom Tromey  <tromey@adacore.com>
 535
 536         * c-exp.y (lex_one_token): Fix assert.
 537
 538 2020-03-20  Tom Tromey  <tromey@adacore.com>
 539
 540         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
 541         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
 542         strncpy call.
 543
 544 2020-03-20  Tom Tromey  <tromey@adacore.com>
 545
 546         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
 547
 548 2020-03-20  Tom Tromey  <tromey@adacore.com>
 549
 550         * ada-valprint.c (print_variant_part): Remove parameters; switch
 551         to value-based API.
 552         (print_field_values): Likewise.
 553         (ada_val_print_struct_union): Likewise.
 554         (ada_value_print_1): Update.
 555
 556 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
 557
 558         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
 559         nbsd_nat_target instead of inf_ptrace_target.
 560         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
 561         nbsd_nat_target.
 562
 563 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
 564
 565         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
 566         it to the ptrace call.
 567         * (store_registers): Likewise.
 568
 569 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
 570
 571         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
 572         it to the ptrace call.
 573         * (store_registers): Likewise.
 574
 575 2020-03-19  Luis Machado  <luis.machado@linaro.org>
 576
 577         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
 578         valid, fetch vg value from ptrace.
 579
 580 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
 581         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
 582         * inf-ptrace.c: Likewise.
 583         * (gdb_ptrace): Add.
 584         * (inf_ptrace_target::resume): Update.
 585         * (inf_ptrace_target::xfer_partial): Likewise.
 586         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
 587         * (inf_ptrace_peek_poke): Update.
 588
 589 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
 590
 591         * x86-bsd-nat.c (gdb_ptrace): New.
 592         * (x86bsd_dr_set): Add new argument `ptid'.
 593         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
 594         x86bsd_dr_set_addr): Update.
 595
 596 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 597
 598         * remote.c (remote_target::process_stop_reply): Handle events for
 599         all threads differently.
 600
 601 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 602
 603         * completer.c (completion_tracker::remove_completion): Define new
 604         function.
 605         * completer.h (completion_tracker::remove_completion): Declare new
 606         function.
 607         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
 608         when adding a C++ function symbol.
 609
 610 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 611
 612         * completer.c (completion_tracker::completion_hash_entry): Define
 613         new class.
 614         (advance_to_filename_complete_word_point): Call
 615         recompute_lowest_common_denominator.
 616         (completion_tracker::completion_tracker): Call discard_completions
 617         to setup the hash table.
 618         (completion_tracker::discard_completions): Allow for being called
 619         from the constructor, pass new equal function, and element deleter
 620         when constructing the hash table.  Initialise new class member
 621         variables.
 622         (completion_tracker::maybe_add_completion): Remove use of
 623         m_entries_vec, and store more information into m_entries_hash.
 624         (completion_tracker::recompute_lcd_visitor): New function, most
 625         content taken from...
 626         (completion_tracker::recompute_lowest_common_denominator):
 627         ...here, this now just visits each item in the hash calling the
 628         above visitor.
 629         (completion_tracker::build_completion_result): Remove use of
 630         m_entries_vec, call recompute_lowest_common_denominator.
 631         * completer.h (completion_tracker::have_completions): Remove use
 632         of m_entries_vec.
 633         (completion_tracker::completion_hash_entry): Declare new class.
 634         (completion_tracker::recompute_lowest_common_denominator): Change
 635         function signature.
 636         (completion_tracker::recompute_lcd_visitor): Declare new function.
 637         (completion_tracker::m_entries_vec): Delete.
 638         (completion_tracker::m_entries_hash): Initialize to NULL.
 639         (completion_tracker::m_lowest_common_denominator_valid): New
 640         member variable.
 641         (completion_tracker::m_lowest_common_denominator_max_length): New
 642         member variable.
 643
 644 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 645
 646         * regformats/regdef.h: Put reg in gdb namespace.
 647
 648 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 649
 650         * i386-bsd-nat.c (gdb_ptrace): New.
 651         * (i386bsd_fetch_inferior_registers,
 652         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
 653         * (i386bsd_fetch_inferior_registers,
 654         i386bsd_store_inferior_registers) Use gdb_ptrace.
 655
 656 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 657
 658         * amd64-bsd-nat.c (gdb_ptrace): New.
 659         * (amd64bsd_fetch_inferior_registers,
 660         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
 661         * (amd64bsd_fetch_inferior_registers,
 662         amd64bsd_store_inferior_registers) Use gdb_ptrace.
 663
 664 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 665
 666         * user-regs.c (user_reg::read): Rename to...
 667         (user_reg::xread): ...this.
 668         * (append_user_reg): Rename argument `read' to `xread'.
 669         * (user_reg_add_builtin): Likewise.
 670         * (user_reg_add): Likewise.
 671         * (value_of_user_reg): Likewise.
 672
 673 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 674
 675         * sparc-nat.c (gdb_ptrace): New.
 676         * sparc-nat.c (sparc_fetch_inferior_registers)
 677         (sparc_store_inferior_registers) Remove obsolete comment.
 678         * sparc-nat.c (sparc_fetch_inferior_registers)
 679         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
 680         * sparc-nat.c (sparc_fetch_inferior_registers)
 681         (sparc_store_inferior_registers) Use gdb_ptrace.
 682
 683 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 684
 685         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
 686         it to the ptrace call.
 687         * sh-nbsd-nat.c (store_registers): Likewise.
 688
 689 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 690
 691         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
 692         nbsd_nat_target instead of inf_ptrace_target.
 693         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
 694         nbsd_nat_target.
 695
 696 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 697
 698         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
 699
 700 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
 701
 702         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
 703         <sys/sysctl.h>.
 704         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
 705
 706 2020-03-17  Tom de Vries  <tdevries@suse.de>
 707
 708         PR gdb/23710
 709         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
 710         fields.
 711         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
 712         fields.
 713         (process_imported_unit_die): Skip import of c++ CUs.
 714
 715 2020-03-16  Tom Tromey  <tom@tromey.com>
 716
 717         * p-valprint.c (pascal_object_print_value): Initialize
 718         base_value.
 719
 720 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
 721             Shahab Vahedi  <shahab@synopsys.com>
 722
 723         * Makefile.in: Add arch/arc.o
 724         * configure.tgt: Likewise.
 725         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
 726         (_initialize_arc_tdep): Don't initialize old target descriptions.
 727         (arc_read_description): New function to cache target descriptions.
 728         * arc-tdep.h (arc_read_description): Add proto type.
 729         * arch/arc.c: New file.
 730         * arch/arc.h: Likewise.
 731         * features/Makefile: Replace old target descriptions with new.
 732         * features/arc-arcompact.c: Remove.
 733         * features/arc-arcompact.xml: Likewise.
 734         * features/arc-v2.c: Likewise
 735         * features/arc-v2.xml: Likewise
 736         * features/arc/aux-arcompact.xml: New file.
 737         * features/arc/aux-v2.xml: Likewise.
 738         * features/arc/core-arcompact.xml: Likewise.
 739         * features/arc/core-v2.xml: Likewise.
 740         * features/arc/aux-arcompact.c: Generate.
 741         * features/arc/aux-v2.c: Likewise.
 742         * features/arc/core-arcompact.c: Likewise.
 743         * features/arc/core-v2.c: Likewise.
 744         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
 745
 746 2020-03-16  Tom Tromey  <tromey@adacore.com>
 747
 748         PR gdb/25663:
 749         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
 750         putting value into bcache.
 751
 752 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 753
 754         PR gdb/21500
 755         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
 756         to...
 757         (amd64_windows_init_abi_common): ... this.  Don't set size of
 758         long type.
 759         (amd64_windows_init_abi): New function.
 760         (amd64_cygwin_init_abi): New function.
 761         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
 762         the Cygwin OS ABI.
 763         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
 764         comment.
 765
 766 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 767
 768         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
 769         * windows-tdep.c (CYGWIN_DLL_NAME): New.
 770         (pe_import_directory_entry): New struct type.
 771         (is_linked_with_cygwin_dll): New function.
 772         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
 773         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
 774         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
 775
 776 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 777
 778         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
 779         i386_cygwin_core_osabi_sniffer.
 780
 781 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 782
 783         * i386-cygwin-tdep.c: Rename to...
 784         * i386-windows-tdep.c: ... this.
 785         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
 786         i386-windows-tdep.c.
 787         * configure.tgt: Likewise.
 788
 789 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 790
 791         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
 792         * osabi.c (gdb_osabi_names): Add "Windows".
 793         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
 794         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
 795         (i386_cygwin_core_osabi_sniffer): New function, extracted from
 796         i386_cygwin_osabi_sniffer.
 797         (_initialize_i386_cygwin_tdep): Register OS ABI
 798         GDB_OSABI_WINDOWS for i386.
 799         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
 800         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
 801         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
 802         for x86-64.
 803         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
 804         when the target matches '*-*-mingw*'.
 805
 806 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 807
 808         * defs.h (enum gdb_osabi): Move to...
 809         * osabi.h (enum gdb_osabi): ... here.
 810         * gdbarch.sh: Include osabi.h in gdbarch.h.
 811         * gdbarch.h: Re-generate.
 812
 813 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
 814
 815         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
 816         function.
 817         (_initialize_amd64_windows_tdep): Register osabi sniffer.
 818
 819 2020-03-14  Tom Tromey  <tom@tromey.com>
 820
 821         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
 822         for C++.
 823         (c_type_print_modifier): Likewise.  Add "language" parameter.
 824         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
 825         (c_type_print_base_1): Update.
 826         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
 827         constants.
 828         * type-stack.c (type_stack::insert): Handle tp_atomic and
 829         tp_restrict.
 830         (type_stack::follow_type_instance_flags): Likewise.
 831         (type_stack::follow_types): Likewise.  Merge type-following code.
 832         * c-exp.y (RESTRICT, ATOMIC): New tokens.
 833         (space_identifier, cv_with_space_id)
 834         (const_or_volatile_or_space_identifier_noopt)
 835         (const_or_volatile_or_space_identifier): Remove.
 836         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
 837         rules.
 838         (ptr_operator, typebase): Update.
 839         (enum token_flag) <FLAG_C>: New constant.
 840         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
 841         "_Atomic".
 842         (lex_one_token): Handle FLAG_C.
 843
 844 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 845
 846         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
 847         it to the ptrace call.
 848         * m68k-bsd-nat.c (store_registers): Likewise.
 849
 850 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 851
 852         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
 853         gdb_byte *.
 854         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
 855         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
 856         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
 857
 858 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 859
 860         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
 861         nbsd_nat_target instead of inf_ptrace_target.
 862         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
 863         nbsd_nat_target.
 864
 865 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 866
 867         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
 868         register_t.
 869
 870 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 871
 872         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
 873         it to the ptrace call.
 874         * alpha-bsd-nat.c (store_registers): Likewise.
 875
 876 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 877
 878         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
 879         includes.
 880         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
 881         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
 882         fill_fpregset): Likewise.
 883
 884 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 885
 886         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
 887         nbsd_nat_target instead of inf_ptrace_target.
 888         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
 889         nbsd_nat_target.
 890
 891 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 892
 893         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
 894         register_t.
 895
 896 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 897
 898         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
 899         it to the ptrace call.
 900         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
 901         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
 902         * arm-nbsd-nat.c (store_register): Likewise.
 903         * arm-nbsd-nat.c (store_regs): Likewise.
 904         * arm-nbsd-nat.c (store_fp_register): Likewise.
 905         * arm-nbsd-nat.c (store_fp_regs): Likewise.
 906
 907 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 908
 909         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
 910         nbsd_nat_target instead of inf_ptrace_target.
 911         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
 912         nbsd_nat_target.
 913
 914 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 915
 916         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
 917         it to the ptrace call.
 918         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
 919
 920 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 921
 922         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
 923         it to the ptrace call.
 924         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
 925
 926 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 927
 928         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
 929         gdb_byte *.
 930         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
 931
 932 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 933
 934         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
 935         instead of inf_ptrace_target.
 936         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
 937         nbsd_nat_target.
 938
 939 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 940
 941         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
 942         register_t.
 943
 944 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 945
 946         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
 947         register_t.
 948
 949 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 950
 951         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
 952         register_t.
 953
 954 2020-03-13  Tom Tromey  <tom@tromey.com>
 955
 956         * value.h (val_print): Don't declare.
 957         * valprint.h (val_print_array_elements)
 958         (val_print_scalar_formatted, generic_val_print): Don't declare.
 959         * valprint.c (generic_val_print_array): Take a struct value.
 960         (generic_val_print_ptr, generic_val_print_memberptr)
 961         (generic_val_print_bool, generic_val_print_int)
 962         (generic_val_print_char, generic_val_print_complex)
 963         (generic_val_print): Remove.
 964         (generic_value_print): Update.
 965         (do_val_print): Remove unused parameters.  Don't call
 966         la_val_print.
 967         (val_print): Remove.
 968         (common_val_print): Update.  Don't call value_check_printable.
 969         (val_print_scalar_formatted, val_print_array_elements): Remove.
 970         * rust-lang.c (rust_val_print): Remove.
 971         (rust_language_defn): Update.
 972         * p-valprint.c (pascal_val_print): Remove.
 973         (pascal_value_print_inner): Update.
 974         (pascal_object_print_val_fields, pascal_object_print_val):
 975         Remove.
 976         (pascal_object_print_static_field): Update.
 977         * p-lang.h (pascal_val_print): Don't declare.
 978         * p-lang.c (pascal_language_defn): Update.
 979         * opencl-lang.c (opencl_language_defn): Update.
 980         * objc-lang.c (objc_language_defn): Update.
 981         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
 982         * m2-lang.h (m2_val_print): Don't declare.
 983         * m2-lang.c (m2_language_defn): Update.
 984         * language.h (struct language_defn) <la_val_print>: Remove.
 985         * language.c (unk_lang_value_print_inner): Rename.  Change
 986         argument types.
 987         (unknown_language_defn, auto_language_defn): Update.
 988         * go-valprint.c (go_val_print): Remove.
 989         * go-lang.h (go_val_print): Don't declare.
 990         * go-lang.c (go_language_defn): Update.
 991         * f-valprint.c (f_val_print): Remove.
 992         * f-lang.h (f_value_print): Don't declare.
 993         * f-lang.c (f_language_defn): Update.
 994         * d-valprint.c (d_val_print): Remove.
 995         * d-lang.h (d_value_print): Don't declare.
 996         * d-lang.c (d_language_defn): Update.
 997         * cp-valprint.c (cp_print_value_fields)
 998         (cp_print_value_fields_rtti, cp_print_value): Remove.
 999         (cp_print_static_field): Update.
1000         * c-valprint.c (c_val_print_array, c_val_print_ptr)
1001         (c_val_print_struct, c_val_print_union, c_val_print_int)
1002         (c_val_print_memberptr, c_val_print): Remove.
1003         * c-lang.h (c_val_print_array, cp_print_value_fields)
1004         (cp_print_value_fields_rtti): Don't declare.
1005         * c-lang.c (c_language_defn, cplus_language_defn)
1006         (asm_language_defn, minimal_language_defn): Update.
1007         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
1008         (ada_val_print_enum): Take a struct value.
1009         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
1010         (ada_val_print): Remove.
1011         (ada_value_print_1): Update.
1012         (printable_val_type): Remove.
1013         * ada-lang.h (ada_val_print): Don't declare.
1014         * ada-lang.c (ada_language_defn): Update.
1015
1016 2020-03-13  Tom Tromey  <tom@tromey.com>
1017
1018         * valprint.c (do_val_print): Update.
1019         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
1020         a struct value.
1021         (value_to_value_object_no_release): Declare.
1022         * python/py-value.c (value_to_value_object_no_release): New
1023         function.
1024         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
1025         struct value.
1026         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
1027         function.
1028         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
1029         a struct value.
1030         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
1031         Declare.
1032         (gdbscm_apply_val_pretty_printer): Take a struct value.
1033         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
1034         value.
1035         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
1036         value.
1037         * extension-priv.h (struct extension_language_ops)
1038         <apply_val_pretty_printer>: Take a struct value.
1039         * cp-valprint.c (cp_print_value): Create a struct value.
1040         (cp_print_value): Update.
1041
1042 2020-03-13  Tom Tromey  <tom@tromey.com>
1043
1044         * ada-valprint.c (print_field_values): Call common_val_print.
1045
1046 2020-03-13  Tom Tromey  <tom@tromey.com>
1047
1048         * ada-valprint.c (val_print_packed_array_elements): Remove
1049         bitoffset and val parameters.  Call common_val_print.
1050         (ada_val_print_string): Remove offset, address, and original_value
1051         parameters.
1052         (ada_val_print_array): Update.
1053         (ada_value_print_array): New function.
1054         (ada_value_print_1): Call it.
1055
1056 2020-03-13  Tom Tromey  <tom@tromey.com>
1057
1058         * ada-valprint.c (ada_value_print): Use common_val_print.
1059
1060 2020-03-13  Tom Tromey  <tom@tromey.com>
1061
1062         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
1063
1064 2020-03-13  Tom Tromey  <tom@tromey.com>
1065
1066         * ada-valprint.c (ada_value_print_num): New function.
1067         (ada_value_print_1): Use it.
1068
1069 2020-03-13  Tom Tromey  <tom@tromey.com>
1070
1071         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
1072
1073 2020-03-13  Tom Tromey  <tom@tromey.com>
1074
1075         * ada-valprint.c (ada_value_print_ptr): New function.
1076         (ada_value_print_1): Use it.
1077
1078 2020-03-13  Tom Tromey  <tom@tromey.com>
1079
1080         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
1081         call common_val_print.
1082         (ada_val_print_1): Update.
1083         (ada_value_print_1): New function.
1084         (ada_value_print_inner): Rewrite.
1085
1086 2020-03-13  Tom Tromey  <tom@tromey.com>
1087
1088         * cp-valprint.c (cp_print_value_fields): Update.
1089         (cp_print_value): New function.
1090
1091 2020-03-13  Tom Tromey  <tom@tromey.com>
1092
1093         * m2-valprint.c (m2_value_print_inner): Use
1094         cp_print_value_fields.
1095         * cp-valprint.c (cp_print_value_fields): New function.
1096         * c-valprint.c (c_value_print_struct): New function.
1097         (c_value_print_inner): Use c_value_print_struct.
1098         * c-lang.h (cp_print_value_fields): Declare.
1099
1100 2020-03-13  Tom Tromey  <tom@tromey.com>
1101
1102         * c-valprint.c (c_value_print_array): New function.
1103         (c_value_print_inner): Use it.
1104
1105 2020-03-13  Tom Tromey  <tom@tromey.com>
1106
1107         * c-valprint.c (c_value_print_memberptr): New function.
1108         (c_value_print_inner): Use it.
1109
1110 2020-03-13  Tom Tromey  <tom@tromey.com>
1111
1112         * c-valprint.c (c_value_print_int): New function.
1113         (c_value_print_inner): Use it.
1114
1115 2020-03-13  Tom Tromey  <tom@tromey.com>
1116
1117         * c-valprint.c (c_value_print_ptr): New function.
1118         (c_value_print_inner): Use it.
1119
1120 2020-03-13  Tom Tromey  <tom@tromey.com>
1121
1122         * c-valprint.c (c_value_print_inner): Rewrite.
1123
1124 2020-03-13  Tom Tromey  <tom@tromey.com>
1125
1126         * valprint.c (generic_value_print_complex): New function.
1127         (generic_value_print): Use it.
1128
1129 2020-03-13  Tom Tromey  <tom@tromey.com>
1130
1131         * valprint.c (generic_val_print_float): Don't call
1132         val_print_scalar_formatted.
1133         (generic_val_print, generic_value_print): Update.
1134
1135 2020-03-13  Tom Tromey  <tom@tromey.com>
1136
1137         * valprint.c (generic_value_print_char): New function
1138         (generic_value_print): Use it.
1139
1140 2020-03-13  Tom Tromey  <tom@tromey.com>
1141
1142         * valprint.c (generic_value_print_int): New function.
1143         (generic_value_print): Use it.
1144
1145 2020-03-13  Tom Tromey  <tom@tromey.com>
1146
1147         * valprint.c (generic_value_print_bool): New function.
1148         (generic_value_print): Use it.
1149
1150 2020-03-13  Tom Tromey  <tom@tromey.com>
1151
1152         * valprint.c (generic_val_print_func): Simplify.
1153         (generic_val_print, generic_value_print): Update.
1154
1155 2020-03-13  Tom Tromey  <tom@tromey.com>
1156
1157         * valprint.c (generic_val_print_flags): Remove.
1158         (generic_val_print, generic_value_print): Update.
1159         (val_print_type_code_flags): Add original_value parameter.
1160
1161 2020-03-13  Tom Tromey  <tom@tromey.com>
1162
1163         * valprint.c (generic_val_print): Update.
1164         (generic_value_print): Update.
1165         * valprint.c (generic_val_print_enum): Don't call
1166         val_print_scalar_formatted.
1167
1168 2020-03-13  Tom Tromey  <tom@tromey.com>
1169
1170         * valprint.c (generic_value_print): Call generic_value_print_ptr.
1171         * valprint.c (generic_value_print_ptr): New function.
1172
1173 2020-03-13  Tom Tromey  <tom@tromey.com>
1174
1175         * valprint.c (generic_value_print): Rewrite.
1176
1177 2020-03-13  Tom Tromey  <tom@tromey.com>
1178
1179         * p-valprint.c (pascal_object_print_value_fields)
1180         (pascal_object_print_value): New functions.
1181
1182 2020-03-13  Tom Tromey  <tom@tromey.com>
1183
1184         * p-valprint.c (pascal_value_print_inner): Rewrite.
1185
1186 2020-03-13  Tom Tromey  <tom@tromey.com>
1187
1188         * f-valprint.c (f_value_print_innner): Rewrite.
1189
1190 2020-03-13  Tom Tromey  <tom@tromey.com>
1191
1192         * m2-valprint.c (m2_print_unbounded_array): New overload.
1193         (m2_print_unbounded_array): Update.
1194         (m2_print_array_contents): Take a struct value.
1195         (m2_value_print_inner): Rewrite.
1196
1197 2020-03-13  Tom Tromey  <tom@tromey.com>
1198
1199         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
1200         (d_value_print_inner): New function.
1201         * d-lang.h (d_value_print_inner): Declare.
1202         * d-lang.c (d_language_defn): Use d_value_print_inner.
1203
1204 2020-03-13  Tom Tromey  <tom@tromey.com>
1205
1206         * go-valprint.c (go_value_print_inner): New function.
1207         * go-lang.h (go_value_print_inner): Declare.
1208         * go-lang.c (go_language_defn): Use go_value_print_inner.
1209
1210 2020-03-13  Tom Tromey  <tom@tromey.com>
1211
1212         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
1213         API.
1214         (rust_val_print): Rewrite.
1215         (rust_value_print_inner): New function, from rust_val_print.
1216         (rust_language_defn): Use rust_value_print_inner.
1217
1218 2020-03-13  Tom Tromey  <tom@tromey.com>
1219
1220         * ada-valprint.c (ada_value_print_inner): New function.
1221         * ada-lang.h (ada_value_print_inner): Declare.
1222         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
1223
1224 2020-03-13  Tom Tromey  <tom@tromey.com>
1225
1226         * f-valprint.c (f_value_print_innner): New function.
1227         * f-lang.h (f_value_print_innner): Declare.
1228         * f-lang.c (f_language_defn): Use f_value_print_innner.
1229
1230 2020-03-13  Tom Tromey  <tom@tromey.com>
1231
1232         * p-valprint.c (pascal_value_print_inner): New function.
1233         * p-lang.h (pascal_value_print_inner): Declare.
1234         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
1235
1236 2020-03-13  Tom Tromey  <tom@tromey.com>
1237
1238         * m2-valprint.c (m2_value_print_inner): New function.
1239         * m2-lang.h (m2_value_print_inner): Declare.
1240         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
1241
1242 2020-03-13  Tom Tromey  <tom@tromey.com>
1243
1244         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
1245         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
1246         * c-valprint.c (c_value_print_inner): New function.
1247         * c-lang.h (c_value_print_inner): Declare.
1248         * c-lang.c (c_language_defn, cplus_language_defn)
1249         (asm_language_defn, minimal_language_defn): Use
1250         c_value_print_inner.
1251
1252 2020-03-13  Tom Tromey  <tom@tromey.com>
1253
1254         * p-valprint.c (pascal_object_print_value_fields): Now static.
1255         * p-lang.h (pascal_object_print_value_fields): Don't declare.
1256
1257 2020-03-13  Tom Tromey  <tom@tromey.com>
1258
1259         * c-valprint.c (c_val_print_array): Simplify.
1260
1261 2020-03-13  Tom Tromey  <tom@tromey.com>
1262
1263         * valprint.c (value_print_array_elements): New function.
1264         * valprint.h (value_print_array_elements): Declare.
1265
1266 2020-03-13  Tom Tromey  <tom@tromey.com>
1267
1268         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
1269         * mips-tdep.c (mips_print_register): Use
1270         value_print_scalar_formatted.
1271
1272 2020-03-13  Tom Tromey  <tom@tromey.com>
1273
1274         * valprint.h (value_print_scalar_formatted): Declare.
1275         * valprint.c (value_print_scalar_formatted): New function.
1276
1277 2020-03-13  Tom Tromey  <tom@tromey.com>
1278
1279         * valprint.h (generic_value_print): Declare.
1280         * valprint.c (generic_value_print): New function.
1281
1282 2020-03-13  Tom Tromey  <tom@tromey.com>
1283
1284         * valprint.c (do_val_print): Call la_value_print_inner, if
1285         available.
1286         * rust-lang.c (rust_language_defn): Update.
1287         * p-lang.c (pascal_language_defn): Update.
1288         * opencl-lang.c (opencl_language_defn): Update.
1289         * objc-lang.c (objc_language_defn): Update.
1290         * m2-lang.c (m2_language_defn): Update.
1291         * language.h (struct language_defn) <la_value_print_inner>: New
1292         member.
1293         * language.c (unknown_language_defn, auto_language_defn): Update.
1294         * go-lang.c (go_language_defn): Update.
1295         * f-lang.c (f_language_defn): Update.
1296         * d-lang.c (d_language_defn): Update.
1297         * c-lang.c (c_language_defn, cplus_language_defn)
1298         (asm_language_defn, minimal_language_defn): Update.
1299         * ada-lang.c (ada_language_defn): Update.
1300
1301 2020-03-13  Tom Tromey  <tom@tromey.com>
1302
1303         * c-valprint.c (c_value_print): Use common_val_print.
1304
1305 2020-03-13  Tom Tromey  <tom@tromey.com>
1306
1307         * cp-valprint.c (cp_print_static_field): Use common_val_print.
1308
1309 2020-03-13  Tom Tromey  <tom@tromey.com>
1310
1311         * f-valprint.c (f77_print_array_1, f_val_print): Use
1312         common_val_print.
1313
1314 2020-03-13  Tom Tromey  <tom@tromey.com>
1315
1316         * riscv-tdep.c (riscv_print_one_register_info): Use
1317         common_val_print.
1318
1319 2020-03-13  Tom Tromey  <tom@tromey.com>
1320
1321         * mi/mi-main.c (output_register): Use common_val_print.
1322
1323 2020-03-13  Tom Tromey  <tom@tromey.com>
1324
1325         * infcmd.c (default_print_one_register_info): Use
1326         common_val_print.
1327
1328 2020-03-13  Tom Tromey  <tom@tromey.com>
1329
1330         * valprint.h (common_val_print_checked): Declare.
1331         * valprint.c (common_val_print_checked): New function.
1332         * stack.c (print_frame_arg): Use common_val_print_checked.
1333
1334 2020-03-13  Tom Tromey  <tom@tromey.com>
1335
1336         * valprint.c (do_val_print): New function, from val_print.
1337         (val_print): Use do_val_print.
1338         (common_val_print): Use do_val_print.
1339
1340 2020-03-13  Tom Tromey  <tom@tromey.com>
1341
1342         * valprint.c (value_print): Use scoped_value_mark.
1343
1344 2020-03-13  Tom de Vries  <tdevries@suse.de>
1345
1346         PR symtab/25646
1347         * psymtab.c (partial_symtab::partial_symtab): Don't set
1348         globals_offset and statics_offset.  Push element onto
1349         current_global_psymbols and current_static_psymbols stacks.
1350         (concat): New function.
1351         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
1352         element from current_global_psymbols and current_static_psymbols
1353         stacks.  Concat popped elements to global_psymbols and
1354         static_symbols.
1355         (add_psymbol_to_list): Use current_global_psymbols and
1356         current_static_psymbols stacks.
1357         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
1358         current_static_psymbols fields.
1359
1360 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
1361
1362         * corelow.c (sniff_core_bfd): Remove.
1363         (class core_target) <m_core_vec>: Remove.
1364         (core_target::core_target): Update.
1365         (core_file_fns): Remove.
1366         (deprecated_add_core_fns): Remove.
1367         (default_core_sniffer): Remove.
1368         (sniff_core_bfd): Remove.
1369         (default_check_format): Remove.
1370         (gdb_check_format): Remove.
1371         (core_target_open): Update.
1372         (core_target::get_core_register_section): Update.
1373         (get_core_registers_cb): Update.
1374         (core_target::fetch_registers): Update.
1375         * gdbcore.h (struct core_fns): Remove.
1376         (deprecated_add_core_fns): Remove.
1377         (default_core_sniffer): Remove.
1378         (default_check_format): Remove.
1379
1380 2020-03-12  Tom Tromey  <tom@tromey.com>
1381
1382         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
1383         CORE_ADDR.
1384         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
1385
1386 2020-03-12  Tom Tromey  <tom@tromey.com>
1387
1388         * remote.c (remote_target::download_tracepoint)
1389         (remote_target::enable_tracepoint)
1390         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
1391         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
1392         sprintf_vma.
1393
1394 2020-03-12  Tom Tromey  <tom@tromey.com>
1395
1396         * symfile-mem.c: Update CORE_ADDR size assert.
1397
1398 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1399
1400         * selftest.m4: Move to gdbsupport/.
1401         * acinclude.m4: Update path to selftest.m4.
1402
1403 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1404
1405         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
1406         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
1407         gdbarch-selfselftests.c and selftest-arch.c.
1408         (SUBDIR_UNITTESTS_OBS): Rename to...
1409         (SELFTESTS_OBS): ... this.
1410         (COMMON_SFILES): Remove disasm-selftests.c and
1411         gdbarch-selftests.c.
1412         * configure.ac: Don't add selftest-arch.{c,o} to
1413         CONFIG_{SRCS,OBS}.
1414         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
1415         preprocessor conditions.
1416
1417 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1418
1419         * configure.ac: Don't source bfd/development.sh.
1420         * selftest.m4: Modify comment.
1421         * configure: Re-generate.
1422
1423 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
1424
1425         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
1426         not "true" or "false".
1427         * configure: Re-generate.
1428
1429 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
1430
1431         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
1432         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
1433         renamed to arm_nbsd_supply_gregset.
1434         (fetch_register): Update to call arm_nbsd_supply_gregset.
1435         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
1436         (arm_netbsd_nat_target::fetch_registers): Update.
1437         (fetch_elfcore_registers): Removed.
1438         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
1439         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
1440         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
1441         not require NetBSD system headers.
1442         (arm_nbsd_regset): New struct.
1443         (arm_nbsd_iterate_over_regset_sections): New function.
1444         (arm_netbsd_init_abi_common): Updated to call
1445         set_gdbarch_iterate_over_regset_sections.
1446         * arm-nbsd-tdep.h: New file.
1447
1448 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
1449
1450         * symtab.c (find_pc_sect_line): Add check which prevents infinite
1451         recursion.
1452
1453 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
1454
1455         * configure: Re-generate.
1456
1457 2020-03-11  Tom Tromey  <tromey@adacore.com>
1458
1459         * ada-typeprint.c (print_choices): Fix comment.
1460
1461 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1462
1463         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
1464         previous item in the list, when the list has no items.
1465
1466 2020-03-11  Tom de Vries  <tdevries@suse.de>
1467
1468         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
1469         PROP_LOCLIST handling code.
1470
1471 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1472
1473         * buildsym-legacy.c (record_line): Pass extra parameter to
1474         record_line.
1475         * buildsym.c (buildsym_compunit::record_line): Take an extra
1476         parameter, reduce duplication in the line table, and record the
1477         is_stmt flag in the line table.
1478         * buildsym.h (buildsym_compunit::record_line): Add extra
1479         parameter.
1480         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
1481         non-statement lines.
1482         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
1483         this to the symtab builder.
1484         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
1485         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
1486         through to dwarf_record_line_1.
1487         * infrun.c (process_event_stop_test): When stepping, don't stop at
1488         a non-statement instruction, and only refresh the step info when
1489         we land in the middle of a line's range.  Also add an extra
1490         comment.
1491         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
1492         field.
1493         * record-btrace.c (btrace_find_line_range): Only record lines
1494         marked as is-statement.
1495         * stack.c (frame_show_address): Show the frame address if we are
1496         in a non-statement sal.
1497         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
1498         (maintenance_print_one_line_table): Print a header for the is_stmt
1499         column, and include is_stmt information in the output.
1500         * symtab.c (find_pc_sect_line): Find lines marked as statements in
1501         preference to non-statements.
1502         (find_pcs_for_symtab_line): Prefer is-statement entries.
1503         (find_line_common): Likewise.
1504         * symtab.h (struct linetable_entry): Add is_stmt field.
1505         (struct symtab_and_line): Likewise.
1506         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
1507         arranging the line table.
1508
1509 2020-03-07  Tom de Vries  <tdevries@suse.de>
1510
1511         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
1512         DIE.
1513
1514 2020-03-07  Tom Tromey  <tom@tromey.com>
1515
1516         * valops.c (value_literal_complex): Remove obsolete comment.
1517         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
1518         comment.
1519
1520 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
1521
1522         * infrun.h: Forward-declare thread_info.
1523         (set_step_info): Add thread_info parameter, add doc.
1524         * infrun.c (set_step_info): Add thread_info parameter, move doc
1525         to header.
1526         * infrun.c (process_event_stop_test): Pass thread to
1527         set_step_info call.
1528         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
1529         set_step_info.
1530         (prepare_one_step): Add thread_info parameter, pass it to
1531         set_step_frame and prepare_one_step (recursive) call.
1532         (step_1): Pass thread to prepare_one_step call.
1533         (step_command_fsm::should_stop): Pass thread to
1534         prepare_one_step.
1535         (until_next_fsm): Pass thread to set_step_frame call.
1536         (finish_command): Pass thread to set_step_info call.
1537
1538 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
1539
1540         * windows-tdep.c (windows_solib_create_inferior_hook):
1541         Check if inferior is running.
1542
1543 2020-03-06  Tom de Vries  <tdevries@suse.de>
1544
1545         * NEWS: Fix "the the".
1546         * ctfread.c: Same.
1547
1548 2020-03-06  Tom de Vries  <tdevries@suse.de>
1549
1550         * psymtab.c (psymtab_to_symtab): Don't print "done.".
1551
1552 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1553
1554         * .dir-locals.el: Add a comment referencing the other copies of
1555         this file.
1556
1557 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
1558
1559         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
1560         psargs.
1561
1562 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1563
1564         * .gitattributes: New file.
1565
1566 2020-03-04  Tom Tromey  <tom@tromey.com>
1567
1568         * symmisc.c (print_symbol_bcache_statistics)
1569         (print_objfile_statistics): Update.
1570         * symfile.c (allocate_symtab): Use intern.
1571         * psymtab.c (partial_symtab::partial_symtab): Use intern.
1572         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1573         macro_cache>: Remove.
1574         <string_cache>: New member.
1575         (struct objfile) <intern>: New methods.
1576         * elfread.c (elf_symtab_read): Use intern.
1577         * dwarf2/read.c (fixup_go_packaging): Intern package name.
1578         (dwarf2_compute_name, dwarf2_physname)
1579         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
1580         names.
1581         (guess_partial_die_structure_name): Update.
1582         (partial_die_info::fixup): Intern name.
1583         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
1584         name.
1585         (dwarf2_name): Intern name.  Update.
1586         * buildsym.c (buildsym_compunit::get_macro_table): Use
1587         string_cache.
1588
1589 2020-03-04  Tom Tromey  <tom@tromey.com>
1590
1591         * jit.c (bfd_open_from_target_memory): Make "target" const.
1592         * corefile.c (gnutarget): Now const.
1593         * gdbcore.h (gnutarget): Now const.
1594
1595 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
1596
1597         * NEWS: Mention support for WOW64 processes.
1598         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
1599         (amd64_windows_segment_register_p): Remove static.
1600         (_initialize_amd64_windows_nat): Update.
1601         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
1602         * i386-windows-nat.c (context_offset): Update.
1603         (i386_mappings): Rename and remove static.
1604         (i386_windows_segment_register_p): Remove static.
1605         (_initialize_i386_windows_nat): Update.
1606         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
1607         (STATUS_WX86_SINGLE_STEP): New macro.
1608         (EnumProcessModulesEx): New macro.
1609         (Wow64SuspendThread): New macro.
1610         (Wow64GetThreadContext): New macro.
1611         (Wow64SetThreadContext): New macro.
1612         (Wow64GetThreadSelectorEntry): New macro.
1613         (windows_set_context_register_offsets): Add static.
1614         (windows_set_segment_register_p): Likewise.
1615         (windows_add_thread): Adapt for WOW64 processes.
1616         (windows_fetch_one_register): Likewise.
1617         (windows_nat_target::fetch_registers): Likewise.
1618         (windows_store_one_register): Likewise.
1619         (display_selector): Likewise.
1620         (display_selectors): Likewise.
1621         (handle_exception): Likewise.
1622         (windows_continue): Likewise.
1623         (windows_nat_target::resume): Likewise.
1624         (windows_add_all_dlls): Likewise.
1625         (do_initial_windows_stuff): Likewise.
1626         (windows_nat_target::attach): Likewise.
1627         (windows_get_exec_module_filename): Likewise.
1628         (windows_nat_target::create_inferior): Likewise.
1629         (windows_xfer_siginfo): Likewise.
1630         (_initialize_loadable): Initialize Wow64SuspendThread,
1631         Wow64GetThreadContext, Wow64SetThreadContext,
1632         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
1633         * windows-nat.h (windows_set_context_register_offsets):
1634         Remove declaration.
1635         (windows_set_segment_register_p): Likewise.
1636         (i386_windows_segment_register_p): Add declaration.
1637         (amd64_windows_segment_register_p): Likewise.
1638
1639 2020-03-04  Luis Machado  <luis.machado@linaro.org>
1640
1641         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
1642         in "info registers" for AArch64/ARM.
1643
1644         The change caused "info registers" to not print GPR's.
1645
1646         gdb/ChangeLog:
1647
1648         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
1649
1650         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
1651         when reg->group is empty and reggroup is not.
1652
1653 2020-03-03  Tom Tromey  <tromey@adacore.com>
1654
1655         * dwarf2/frame.c (struct dwarf2_frame_cache)
1656         <checked_tailcall_bottom, entry_cfa_sp_offset,
1657         entry_cfa_sp_offset_p>: Remove members.
1658         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
1659         (dwarf2_frame_prev_register): Don't call
1660         dwarf2_tailcall_sniffer_first.
1661         (dwarf2_append_unwinders): Don't append tailcall unwinder.
1662         * frame-unwind.c (add_unwinder): New fuction.
1663         (frame_unwind_init): Use it.  Add tailcall unwinder.
1664
1665 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1666             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1667
1668         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
1669         value should be printed as true.
1670
1671 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
1672
1673         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
1674         (windows_init_abi): Set and use windows_so_ops.
1675
1676 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
1677
1678         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
1679         when verifying if dealing with a convenience variable.
1680
1681 2020-03-03  Luis Machado  <luis.machado@linaro.org>
1682
1683         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
1684
1685 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
1686
1687         * infrun.c (gdbarch_supports_displaced_stepping): New.
1688         (use_displaced_stepping): Break up conditions in smaller pieces.
1689         Use gdbarch_supports_displaced_stepping.
1690         (displaced_step_prepare_throw): Use
1691         gdbarch_supports_displaced_stepping.
1692
1693 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1694
1695         * NEWS: Mention new behaviour of the history filename.
1696         * top.c (write_history_p): Add comment.
1697         (show_write_history_p): Add header comment, give a different
1698         message when history writing is on, but the history filename is
1699         empty.
1700         (history_filename): Add comment.
1701         (history_filename_empty): New function.
1702         (show_history_filename): Add header comment, give a different
1703         message when the filename is empty.
1704         (init_history): Compare history_filename against nullptr, and only
1705         read history if the filename is not empty.
1706         (set_history_filename): Add header comment, and only make
1707         non-empty filenames absolute.
1708         (init_main): Make the filename argument to 'set history filename'
1709         optional.
1710
1711 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
1712
1713         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
1714         (arm_supply_vfpregset): ...this, and update to use VFP registers.
1715         (fetch_fp_register): Update.
1716         (fetch_fp_regs): Update.
1717         (store_fp_register): Update.
1718         (store_fp_regs): Update.
1719         (arm_netbsd_nat_target::read_description): New function.
1720         (fetch_elfcore_registers): Update.
1721
1722 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1723
1724         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
1725         general_thread if the stop reply is missing a thread-id.
1726         (remote_target::process_stop_reply): Use the first non-exited
1727         thread if the target didn't pass a thread-id.
1728         * infrun.c (do_target_wait): Move call to
1729         switch_to_inferior_no_thread to ....
1730         (do_target_wait_1): ... here.
1731
1732 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
1733
1734         * debuginfod-support.c: Include defs.h first.
1735
1736 2020-02-28  Tom de Vries  <tdevries@suse.de>
1737
1738         * symfile.c (set_initial_language): Use default language for lookup.
1739
1740 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
1741
1742         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
1743         reader variable, pass `this` to read_cutu_die_from_dwo.
1744
1745 2020-02-27  Aaron Merey  <amerey@redhat.com>
1746
1747         * source.c (open_source_file): Check for nullptr when computing
1748         srcpath.
1749
1750 2020-02-27  Tom Tromey  <tromey@adacore.com>
1751
1752         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
1753         member.
1754         (dwarf2_add_field): Don't update nfields.
1755         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
1756
1757 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1758
1759         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
1760         abs.
1761
1762 2020-02-26  Tom Tromey  <tom@tromey.com>
1763
1764         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
1765         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
1766         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
1767         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
1768         per_cu_data.
1769
1770 2020-02-26  Tom Tromey  <tom@tromey.com>
1771
1772         * dwarf2/index-write.c (psym_index_map): Change type.
1773         (add_address_entry_worker, write_one_signatured_type)
1774         (recursively_count_psymbols, recursively_write_psymbols)
1775         (class debug_names, psyms_seen_size, write_gdbindex)
1776         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
1777
1778 2020-02-26  Aaron Merey  <amerey@redhat.com>
1779
1780         * Makefile.in: Handle optional debuginfod support.
1781         * NEWS: Update.
1782         * README: Add --with-debuginfod summary.
1783         * config.in: Regenerate.
1784         * configure: Regenerate.
1785         * configure.ac: Handle optional debuginfod support.
1786         * debuginfod-support.c: debuginfod helper functions.
1787         * debuginfod-support.h: Ditto.
1788         * doc/gdb.texinfo: Add --with-debuginfod to configure options
1789         summary.
1790         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
1791         when a dwz file cannot be found.
1792         * elfread.c (elf_symfile_read): Query debuginfod servers when a
1793         debuginfo file cannot be found.
1794         * source.c (open_source_file): Query debuginfod servers when a
1795         source file cannot be found.
1796         * top.c (print_gdb_configuration): Include
1797         --{with,without}-debuginfod in the output.
1798
1799 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
1800
1801         * thread.c (thr_try_catch_cmd): Print thread name.
1802
1803 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
1804
1805         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
1806         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1807         dwarf2_fetch_die_type_sect_off): Move to...
1808         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
1809         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1810         dwarf2_fetch_die_type_sect_off): ... here.
1811         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
1812         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1813         dwarf2_fetch_die_type_sect_off): Move doc to header file.
1814
1815 2020-02-26  Tom de Vries  <tdevries@suse.de>
1816
1817         PR gdb/25603
1818         * symfile.c (set_initial_language): Exit-early if
1819         language_mode == language_mode_manual.
1820
1821 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
1822
1823         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
1824         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
1825         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
1826
1827 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1828
1829         * gdbtypes.c (create_array_type_with_stride): Handle negative
1830         array strides.
1831         * valarith.c (value_subscripted_rvalue): Likewise.
1832
1833 2020-02-25  Luis Machado  <luis.machado@linaro.org>
1834
1835         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
1836
1837 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
1838
1839         * loc.h (dwarf2_get_die_type): Move to...
1840         * read.h (dwarf2_get_die_type): ... here.
1841         * read.c (dwarf2_get_die_type): Move doc to header.
1842
1843 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
1844
1845         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
1846         'gnulib/Makefile.in' to the list.
1847
1848 2020-02-24  Tom Tromey  <tom@tromey.com>
1849
1850         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
1851         Remove.
1852         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
1853         XOBNEWVEC.
1854
1855 2020-02-24  Tom Tromey  <tom@tromey.com>
1856
1857         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
1858         New method.
1859         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
1860         (dw2_do_instantiate_symtab, dw2_get_file_names)
1861         (build_type_psymtab_dependencies, load_full_type_unit): Update.
1862
1863 2020-02-24  Tom Tromey  <tom@tromey.com>
1864
1865         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
1866         make_scoped_restore.
1867         (dwarf2_psymtab::read_symtab): Don't clear
1868         reading_partial_symbols.
1869
1870 2020-02-24  Tom de Vries  <tdevries@suse.de>
1871
1872         PR gdb/25592
1873         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
1874
1875 2020-02-24  Tom de Vries  <tdevries@suse.de>
1876
1877         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
1878         commands layout next/prev/regs.
1879
1880 2020-02-22  Tom Tromey  <tom@tromey.com>
1881
1882         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
1883         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
1884
1885 2020-02-22  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
1888
1889 2020-02-22  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-win.c (_initialize_tui_win): Add usage text.
1892         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
1893         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
1894         * tui/tui.c (_initialize_tui): Add usage text.
1895
1896 2020-02-22  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-win.c (tui_set_focus_command)
1899         (tui_set_win_height_command): Use error_no_arg.
1900         (_initialize_tui_win): Update help text.
1901         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
1902
1903 2020-02-22  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
1906         * tui/tui-disasm.h (struct tui_disasm_window)
1907         <display_start_addr>: Declare.
1908         * tui/tui-source.h (struct tui_source_window)
1909         <display_start_addr>: Declare.
1910         * tui/tui-winsource.h (struct tui_source_window_base)
1911         <show_source_line, display_start_addr>: New methods.
1912         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
1913         Rename and move to protected section.
1914         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
1915         (tui_source_window_base::do_erase_source_content): Update.
1916         (tui_source_window_base::show_source_line): Now a method.
1917         (tui_source_window_base::show_source_content)
1918         (tui_source_window_base::tui_source_window_base)
1919         (tui_source_window_base::rerender)
1920         (tui_source_window_base::refill)
1921         (tui_source_window_base::do_scroll_horizontal)
1922         (tui_source_window_base::set_is_exec_point_at)
1923         (tui_source_window_base::update_breakpoint_info)
1924         (tui_source_window_base::update_exec_info): Update.
1925         * tui/tui-source.c (tui_source_window::set_contents)
1926         (tui_source_window::showing_source_p)
1927         (tui_source_window::do_scroll_vertical)
1928         (tui_source_window::location_matches_p)
1929         (tui_source_window::line_is_displayed): Update.
1930         (tui_source_window::display_start_addr): New method.
1931         * tui/tui-disasm.c (tui_disasm_window::set_contents)
1932         (tui_disasm_window::do_scroll_vertical)
1933         (tui_disasm_window::location_matches_p): Update.
1934         (tui_disasm_window::display_start_addr): New method.
1935
1936 2020-02-22  Tom Tromey  <tom@tromey.com>
1937
1938         * NEWS: Add entry for gdb.register_window_type.
1939         * tui/tui-layout.h (window_factory): New typedef.
1940         (tui_register_window): Declare.
1941         * tui/tui-layout.c (saved_tui_windows): New global.
1942         (tui_apply_current_layout): Use it.
1943         (tui_register_window): New function.
1944         * python/python.c (do_start_initialization): Call
1945         gdbpy_initialize_tui.
1946         (python_GdbMethods): Add "register_window_type" function.
1947         * python/python-internal.h (gdbpy_register_tui_window)
1948         (gdbpy_initialize_tui): Declare.
1949         * python/py-tui.c: New file.
1950         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
1951
1952 2020-02-22  Tom Tromey  <tom@tromey.com>
1953
1954         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
1955
1956 2020-02-22  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
1959         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
1960         * tui/tui-data.c (tui_set_win_with_focus): Remove.
1961         (tui_set_win_focus_to): Move from tui-win.c.
1962
1963 2020-02-22  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-layout.c (make_standard_window, get_locator_window): New
1966         functions.
1967         (known_window_types): New global.
1968         (tui_get_window_by_name): Reimplement.
1969         (initialize_known_windows): New function.
1970         (validate_window_name): Rewrite.
1971         (_initialize_tui_layout): Call initialize_known_windows.
1972
1973 2020-02-22  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
1976         Remove constants.
1977         * tui/tui-winsource.h (struct tui_source_window_base)
1978         <tui_source_window_base>: Remove parameter.
1979         * tui/tui-winsource.c
1980         (tui_source_window_base::tui_source_window_base): Remove
1981         parameter.
1982         (tui_source_window_base::refill): Update.
1983         * tui/tui-stack.h (struct tui_locator_window)
1984         <tui_locator_window>: Update.
1985         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
1986         Default the constructor.
1987         * tui/tui-regs.h (struct tui_data_item_window)
1988         <tui_data_item_window>: Default the constructor.
1989         (struct tui_data_window) <tui_data_window>: Likewise.
1990         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
1991         Default the constructor.
1992         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
1993         Default the constructor.
1994         <type>: Remove.
1995         (struct tui_win_info) <tui_win_info>: Default the constructor.
1996         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
1997         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1998         Default the constructor.
1999
2000 2020-02-22  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
2003         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
2004         * tui/tui-win.c (tui_resize_all): Don't call
2005         tui_delete_invisible_windows.
2006         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
2007         done.
2008         (tui_set_layout): Update.
2009         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
2010         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
2011         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
2012
2013 2020-02-22  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
2016         correctly.
2017
2018 2020-02-22  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
2021
2022 2020-02-22  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-winsource.h (struct tui_source_window_iterator)
2025         <inner_iterator>: New etytypedef.
2026         <tui_source_window_iterator>: Take "end" parameter.
2027         <tui_source_window_iterator>: Take iterator.
2028         <operator*, advance>: Update.
2029         <m_iter>: Change type.
2030         <m_end>: New field.
2031         (struct tui_source_windows) <begin, end>: Update.
2032         * tui/tui-layout.c (tui_windows): New global.
2033         (tui_apply_current_layout): Clear tui_windows.
2034         (tui_layout_window::apply): Update tui_windows.
2035         * tui/tui-data.h (tui_windows): Declare.
2036         (all_tui_windows): Now inline function.
2037         (class tui_window_iterator, struct all_tui_windows): Remove.
2038
2039 2020-02-22  Tom Tromey  <tom@tromey.com>
2040
2041         PR tui/17850:
2042         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
2043         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
2044         "height" argument.
2045         (class tui_layout_window) <get_sizes>: Likewise.
2046         (class tui_layout_split) <tui_layout_split>: Add "vertical"
2047         argument.
2048         <get_sizes>: Add "height" argument.
2049         <m_vertical>: New field.
2050         * tui/tui-layout.c (tui_layout_split::clone): Update.
2051         (tui_layout_split::get_sizes): Add "height" argument.
2052         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
2053         (tui_new_layout_command): Parse "-horizontal".
2054         (_initialize_tui_layout): Update help string.
2055         (tui_layout_split::specification): Add "-horizontal" when needed.
2056         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
2057         argument.
2058         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
2059         New methods.
2060
2061 2020-02-22  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-layout.h (enum tui_adjust_result): New.
2064         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
2065         (class tui_layout_window) <adjust_size>: Return
2066         tui_adjust_result.  Rewrite.
2067         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
2068         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
2069
2070 2020-02-22  Tom Tromey  <tom@tromey.com>
2071
2072         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
2073         parameter and return types.
2074         (class tui_layout_base) <specification>: Add "depth".
2075         (class tui_layout_window) <specification>: Add "depth".
2076         (class tui_layout_split) <specification>: Add "depth".
2077         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
2078         and return types.
2079         (tui_new_layout_command): Parse sub-layouts.
2080         (_initialize_tui_layout): Update help string.
2081         (tui_layout_window::specification): Add "depth".
2082         (add_layout_command): Update.
2083
2084 2020-02-22  Tom Tromey  <tom@tromey.com>
2085
2086         * NEWS: Add "tui new-layout" item.
2087         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
2088         Add new-layout command to help text.
2089         (validate_window_name): New function.
2090         (tui_new_layout_command): New function.
2091         (_initialize_tui_layout): Register "new-layout".
2092         (tui_layout_window::specification): New method.
2093         (tui_layout_window::specification): New method.
2094         * tui/tui-layout.h (class tui_layout_base) <specification>: New
2095         method.
2096         (class tui_layout_window) <specification>: New method.
2097         (class tui_layout_split) <specification>: New method.
2098
2099 2020-02-22  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
2102         * tui/tui-win.c (window_name_completer): Update comment.
2103         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
2104         Declare method.
2105         (class tui_layout_window) <replace_window>: Likewise.
2106         (class tui_layout_split) <replace_window>: Likewise.
2107         (tui_set_layout): Don't declare.
2108         (tui_set_initial_layout): Declare function.
2109         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
2110         (asm_regs_layout): New globals.
2111         (tui_current_layout, show_layout): Remove.
2112         (tui_set_layout, tui_add_win_to_layout): Rewrite.
2113         (find_layout, tui_apply_layout): New function.
2114         (layout_completer): Remove.
2115         (tui_next_layout): Reimplement.
2116         (tui_next_layout_command): New function.
2117         (tui_set_initial_layout, tui_prev_layout_command): New functions.
2118         (tui_regs_layout): Reimplement.
2119         (tui_regs_layout_command): New function.
2120         (extract_display_start_addr): Rewrite.
2121         (next_layout, prev_layout): Remove.
2122         (tui_layout_window::replace_window): New method.
2123         (tui_layout_split::replace_window): New method.
2124         (destroy_layout): New function.
2125         (layout_list): New global.
2126         (add_layout_command): New function.
2127         (initialize_layouts): Update.
2128         (tui_layout_command): New function.
2129         (_initialize_tui_layout): Install "layout" commands.
2130         * tui/tui-data.h (enum tui_layout_type): Remove.
2131         (tui_current_layout): Don't declare.
2132
2133 2020-02-22  Tom Tromey  <tom@tromey.com>
2134
2135         * tui/tui-regs.c (tui_reg_layout): Remove.
2136         (tui_reg_command): Use tui_regs_layout.
2137         * tui/tui-layout.h (tui_reg_command): Declare.
2138         * tui/tui-layout.c (tui_reg_command): New function.
2139
2140 2020-02-22  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui.c (tui_rl_delete_other_windows): Call
2143         tui_remove_some_windows.
2144         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
2145         Declare method.
2146         (class tui_layout_window) <remove_windows>: New method.
2147         (class tui_layout_split) <remove_windows>: Declare.
2148         (tui_remove_some_windows): Declare.
2149         * tui/tui-layout.c (tui_remove_some_windows): New function.
2150         (tui_layout_split::remove_windows): New method.
2151
2152 2020-02-22  Tom Tromey  <tom@tromey.com>
2153
2154         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
2155         * tui/tui-layout.h (tui_next_layout): Declare.
2156         * tui/tui-layout.c (tui_next_layout): New function.
2157
2158 2020-02-22  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
2161         correct coordinates.
2162
2163 2020-02-22  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
2166         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
2167         DATA_WIN case.
2168
2169 2020-02-22  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
2172         TUI_DISASM_WIN, not tui_win_list.
2173
2174 2020-02-22  Tom Tromey  <tom@tromey.com>
2175
2176         * valprint.c (generic_val_print_enum_1)
2177         (val_print_type_code_flags): Style member names.
2178         * rust-lang.c (val_print_struct, rust_print_enum)
2179         (rust_print_struct_def, rust_internal_print_type): Style member
2180         names.
2181         * p-valprint.c (pascal_object_print_value_fields): Style member
2182         names.  Only call fprintf_symbol_filtered for static members.
2183         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
2184         * f-valprint.c (f_val_print): Style member names.
2185         * f-typeprint.c (f_type_print_base): Style member names.
2186         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
2187         call fprintf_symbol_filtered for static members.
2188         (cp_print_class_member): Style member names.
2189         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
2190         member names.
2191         * ada-valprint.c (ada_print_scalar): Style enum names.
2192         (ada_val_print_enum): Likewise.
2193         * ada-typeprint.c (print_enum_type): Style enum names.
2194
2195 2020-02-21  Tom Tromey  <tom@tromey.com>
2196
2197         * psympriv.h (struct partial_symtab): Update comment.
2198
2199 2020-02-21  Tom Tromey  <tromey@adacore.com>
2200
2201         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
2202         type is CORE_ADDR.
2203
2204 2020-02-21  Tom de Vries  <tdevries@suse.de>
2205
2206         PR gdb/25534
2207         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
2208         if dependencies[i]->user != NULL.
2209
2210 2020-02-21  Ali Tamur  <tamur@google.com>
2211
2212         * dwarf2/read.c (dwarf2_name): Add null check.
2213
2214 2020-02-20  Tom Tromey  <tom@tromey.com>
2215
2216         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
2217         ">=", in binary search.
2218         (dwarf2_find_containing_comp_unit): New overload.
2219         (run_test): New self-test.
2220         (_initialize_dwarf2_read): Register new test.
2221
2222 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
2223
2224         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
2225         * riscv-tdep.h: Likewise.
2226         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
2227         rv32-only CSR.
2228         * features/riscv/64bit-csr.xml: Regenerated.
2229
2230 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
2231             Tom Tromey  <tom@tromey.com>
2232
2233         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
2234         of 'fputc_unfiltered'.
2235         (putchar_unfiltered): Call 'fputc_unfiltered'.
2236         (fputc_unfiltered): Call 'fputs_unfiltered'.
2237
2238 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
2239
2240         * config.in: Regenerate.
2241         * configure: Regenerate.
2242         * configure.ac: Add --with-python-libdir option.
2243         * main.c: Use WITH_PYTHON_LIBDIR.
2244
2245 2020-02-19  Tom Tromey  <tom@tromey.com>
2246
2247         * symtab.c (general_symbol_info::compute_and_set_names): Use
2248         obstack_strndup.  Simplify call to symbol_set_demangled_name.
2249
2250 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
2251
2252         * dwarf2/read.c (allocate_signatured_type_table,
2253         allocate_dwo_unit_table, allocate_type_unit_groups_table,
2254         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
2255         Remove objfile parameter, update all callers.
2256
2257 2020-02-19  Doug Evans  <dje@google.com>
2258
2259         PR rust/25535
2260         * rust-lang.c (rust_print_enum): Apply embedded_offset to
2261         rust_enum_variant calculation.
2262
2263 2020-02-19  Tom Tromey  <tromey@adacore.com>
2264
2265         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
2266
2267 2020-02-19  Tom Tromey  <tromey@adacore.com>
2268
2269         * ada-lang.c (cache_symbol): Use obstack_strdup.
2270
2271 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2272
2273         * configure: Regenerate.
2274
2275 2020-02-19  Tom Tromey  <tromey@adacore.com>
2276
2277         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
2278         NULL check.
2279
2280 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
2281
2282         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
2283
2284 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2285
2286         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
2287         if GDBSERVER is not defined.
2288         (riscv_tdesc_cache): Likewise, also store const target_desc.
2289         (STATIC_IN_GDB): Define.
2290         (riscv_create_target_description): Update declaration with
2291         STATIC_IN_GDB.
2292         (riscv_lookup_target_description): New function, only define if
2293         GDBSERVER is not defined.
2294         * arch/riscv.h (riscv_create_target_description): Declare only
2295         when GDBSERVER is defined.
2296         (riscv_lookup_target_description): New declaration when GDBSERVER
2297         is not defined.
2298         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
2299         (riscv_linux_read_features): ...this, and return
2300         riscv_gdbarch_features instead of target_desc.
2301         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
2302         (riscv_linux_read_description): Rename to...
2303         (riscv_linux_read_features): ...this.
2304         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
2305         Update to use riscv_gdbarch_features and
2306         riscv_lookup_target_description.
2307         * riscv-tdep.c (riscv_find_default_target_description): Use
2308         riscv_lookup_target_description instead of
2309         riscv_create_target_description.
2310
2311 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2312
2313         * valprint.c (generic_val_print_enum_1): When printing a flag
2314         enum with value 0 and there is no enumerator with value 0, print
2315         just "0" instead of "(unknown: 0x0)".
2316
2317 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2318
2319         * valprint.c (generic_val_print_enum_1): Print unknown part of
2320         flag enum in hex.
2321
2322 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2323
2324         * dwarf2/read.c (update_enumeration_type_from_children): Allow
2325         flag enums to contain duplicate enumerators.
2326         * valprint.c (generic_val_print_enum_1): Update comment.
2327
2328 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2329
2330         * dwarf2/read.c: Include "count-one-bits.h".
2331         (update_enumeration_type_from_children): If an enumerator has
2332         multiple bits set, don't treat the enumeration as a "flag enum".
2333         * valprint.c (generic_val_print_enum_1): Assert that enumerators
2334         of flag enums have 0 or 1 bit set.
2335
2336 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2337
2338         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
2339         conversion.
2340         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
2341         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
2342         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
2343         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
2344         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
2345
2346 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
2347
2348         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
2349
2350 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2351
2352         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
2353         displaced_step_closure_up.
2354         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
2355         (struct displaced_step_closure_up):
2356         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
2357         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
2358         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
2359         Likewise.
2360         * gdbarch.sh (displaced_step_copy_insn): Likewise.
2361         * gdbarch.c, gdbarch.h: Re-generate.
2362         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
2363         displaced_step_closure_up.
2364         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
2365         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
2366         * infrun.h (displaced_step_closure_up): New type alias.
2367         (struct displaced_step_inferior_state) <step_closure>: Change
2368         type to displaced_step_closure_up.
2369         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
2370         displaced_step_closure_up.
2371         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
2372
2373 2020-02-14  Tom Tromey  <tom@tromey.com>
2374
2375         * minidebug.c (gnu_debug_key): New global.
2376         (find_separate_debug_file_in_section): Use it.
2377
2378 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2379
2380         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
2381         std::unique_ptr.
2382         * gdbarch.c: Re-generate.
2383         * gdbarch.h: Re-generate.
2384         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
2385         change.
2386         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
2387         type to std::unique_ptr.
2388         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
2389         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
2390         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
2391         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
2392         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
2393         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
2394         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
2395         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
2396         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
2397
2398 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2399
2400         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
2401         std::unique_ptr.
2402         (displaced_step_clear): Rename to...
2403         (displaced_step_reset): ... this.  Just call displaced->reset ().
2404         (displaced_step_clear_cleanup): Rename to...
2405         (displaced_step_reset_cleanup): ... this.
2406         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
2407         (displaced_step_fixup): Likewise.
2408         (resume_1): Likewise.
2409         (handle_inferior_event): Restore child's memory before calling
2410         displaced_step_fixup on the parent.
2411         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
2412         to std::unique_ptr.
2413         <step_closure>: Change type to std::unique_ptr.
2414
2415 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
2416
2417         * arm-tdep.c: Include count-one-bits.h.
2418         (cleanup_block_store_pc): Use count_one_bits.
2419         (cleanup_block_load_pc): Use count_one_bits.
2420         (arm_copy_block_xfer): Use count_one_bits.
2421         (thumb2_copy_block_xfer): Use count_one_bits.
2422         (thumb_copy_pop_pc_16bit): Use count_one_bits.
2423         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
2424         (thumb_get_next_pcs_raw): Use count_one_bits.
2425         (arm_get_next_pcs_raw): Use count_one_bits_l.
2426         * arch/arm.c (bitcount): Remove.
2427         * arch/arm.h (bitcount): Remove.
2428
2429 2020-02-14  Tom Tromey  <tromey@adacore.com>
2430
2431         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
2432         Update.
2433         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
2434         * dwarf2/loc.c (call_site_find_chain_1): Return
2435         unique_xmalloc_ptr.
2436         (call_site_find_chain): Likewise.
2437
2438 2020-02-14  Richard Biener  <rguenther@suse.de>
2439
2440         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
2441         on expression with division operators.
2442
2443 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
2444
2445         * MAINTAINERS (Write After Approval): Adding myself.
2446
2447 2020-02-12  Tom Tromey  <tom@tromey.com>
2448
2449         * event-loop.c (event_data, gdb_event, event_handler_func):
2450         Remove.
2451
2452 2020-02-12  Tom Tromey  <tom@tromey.com>
2453
2454         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
2455         (dwarf2_frame_objfile_data): Add comment.
2456         (find_comp_unit, set_comp_unit): New functions.
2457         (dwarf2_frame_find_fde): Use find_comp_unit.
2458         (dwarf2_build_frame_info): Use set_comp_unit.
2459
2460 2020-02-12  Tom Tromey  <tom@tromey.com>
2461
2462         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
2463         (comp_unit): Don't initialize objfile.
2464         (execute_cfa_program): Add text_offset parameter.
2465         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
2466         (dwarf2_frame_cache): Update.
2467         (dwarf2_build_frame_info): Don't set "objfile" member.
2468
2469 2020-02-12  Tom Tromey  <tom@tromey.com>
2470
2471         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
2472         (decode_frame_entry): Likewise.
2473         (dwarf2_build_frame_info): Update.
2474
2475 2020-02-12  Tom Tromey  <tom@tromey.com>
2476
2477         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
2478         (decode_frame_entry_1): Use the comp_unit obstack.
2479
2480 2020-02-12  Tom Tromey  <tom@tromey.com>
2481
2482         * dwarf2/frame.c (struct comp_unit): Add initializers and
2483         constructor.
2484         (dwarf2_frame_objfile_data): Store a comp_unit.
2485         (dwarf2_frame_find_fde): Update.
2486         (dwarf2_build_frame_info): Use "new".
2487
2488 2020-02-12  Tom Tromey  <tom@tromey.com>
2489
2490         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
2491         (dwarf2_fde_table): Typedef for std::vector.
2492         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
2493         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
2494         (decode_frame_entry): Update.
2495         (dwarf2_build_frame_info): Use "new".
2496
2497 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
2498
2499         * arm-tdep.c (arm_gdbarch_init): Update.
2500         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
2501         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
2502         have_neon, is_m>: Change to bool.
2503
2504 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
2505
2506         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
2507
2508 2020-02-12  Tom Tromey  <tom@tromey.com>
2509
2510         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
2511
2512 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
2513
2514         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
2515         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
2516
2517 2020-02-11  Tom Tromey  <tom@tromey.com>
2518
2519         * psymtab.h: Update comment.
2520
2521 2020-02-11  Tom Tromey  <tom@tromey.com>
2522
2523         * gdb_obstack.h (struct auto_obstack): Use
2524         DISABLE_COPY_AND_ASSIGN.
2525
2526 2020-02-11  Tom Tromey  <tom@tromey.com>
2527
2528         * dwarf2/frame.h (struct objfile): Don't forward declare.
2529
2530 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
2531
2532         * cris-tdep.c (cris_supply_gregset): Change signature to match
2533         what struct regset expects.
2534         (cris_regset): New struct.
2535         (fetch_core_registers): Remove.
2536         (cris_iterate_over_regset_sections): New function.
2537         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
2538         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
2539
2540 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
2541
2542         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
2543         registers.
2544
2545 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
2546
2547         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
2548
2549 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
2550
2551         * configure: Re-generate.
2552
2553 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
2554
2555         * configure: Re-generate.
2556
2557 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
2558
2559         * acinclude: Update warning.m4 path.
2560         * warning.m4: Move to gdbsupport.
2561
2562 2020-02-11  Tom Tromey  <tromey@adacore.com>
2563
2564         * remote.c (remote_console_output): Update.
2565         * printcmd.c (printf_command): Update.
2566         * event-loop.c (gdb_wait_for_event): Update.
2567         * linux-nat.c (sigchld_handler): Update.
2568         * remote-sim.c (gdb_os_write_stdout): Update.
2569         (gdb_os_flush_stdout): Update.
2570         (gdb_os_flush_stderr): Update.
2571         (gdb_os_write_stderr): Update.
2572         * exceptions.c (print_exception): Update.
2573         * remote-fileio.c (remote_fileio_func_read): Update.
2574         (remote_fileio_func_write): Update.
2575         * tui/tui.c (tui_enable): Update.
2576         * tui/tui-interp.c (tui_interp::init): Update.
2577         * utils.c (init_page_info): Update.
2578         (putchar_unfiltered, fputc_unfiltered): Update.
2579         (gdb_flush): Update.
2580         (emit_style_escape): Update.
2581         (flush_wrap_buffer, fputs_maybe_filtered): Update.
2582         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
2583         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
2584         (stderr_file::write): Update.
2585         (stderr_file::puts): Update.
2586         * ui-file.h (ui_file_isatty, ui_file_write)
2587         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
2588         (ui_file_puts): Don't declare.
2589
2590 2020-02-10  Tom de Vries  <tdevries@suse.de>
2591
2592         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
2593         sentinel to char *.
2594
2595 2020-02-09  Tom de Vries  <tdevries@suse.de>
2596
2597         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
2598         filename if it matches "<artificial>".
2599
2600 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
2601
2602         * windows-tdep.c (struct enum_value_name): New struct.
2603         (create_enum): New function.
2604         (windows_get_siginfo_type): Create and use enum types.
2605
2606 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
2607
2608         * NEWS: Mention $_siginfo support for Windows.
2609         * windows-nat.c (handle_exception): Set siginfo_er.
2610         (windows_nat_target::mourn_inferior): Reset siginfo_er.
2611         (windows_xfer_siginfo): New function.
2612         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
2613         * windows-tdep.c (struct windows_gdbarch_data): New struct.
2614         (init_windows_gdbarch_data): New function.
2615         (get_windows_gdbarch_data): New function.
2616         (windows_get_siginfo_type): New function.
2617         (windows_init_abi): Register windows_get_siginfo_type.
2618         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
2619
2620 2020-02-08  Tom Tromey  <tom@tromey.com>
2621
2622         * dwarf2/read.c (class cutu_reader) <cutu_reader,
2623         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
2624         <keep>: Declare method.
2625         <m_keep>: Remove member.
2626         <~cutu_reader>: Remove.
2627         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2628         (cutu_reader::cutu_reader): Update.
2629         (cutu_reader::keep): Rename from ~cutu_reader.
2630         (process_psymtab_comp_unit, build_type_psymtabs_1)
2631         (process_skeletonless_type_unit, load_partial_comp_unit)
2632         (load_full_comp_unit, dwarf2_read_addr_index)
2633         (read_signatured_type): Update.
2634
2635 2020-02-08  Tom Tromey  <tom@tromey.com>
2636
2637         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
2638         "want_partial_unit" parameter.
2639         (process_psymtab_comp_unit): Change want_partial_unit to bool.
2640         Inline check for DW_TAG_partial_unit.
2641         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
2642
2643 2020-02-08  Tom Tromey  <tom@tromey.com>
2644
2645         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
2646         read.c.
2647         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
2648         read.c.
2649
2650 2020-02-08  Tom Tromey  <tom@tromey.com>
2651
2652         * dwarf2/read.c (read_address): Move to comp-unit.c.
2653         (dwarf2_rnglists_process, dwarf2_ranges_process)
2654         (read_attribute_value, dwarf_decode_lines_1)
2655         (var_decode_location, decode_locdesc): Update.
2656         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
2657         read.c.  Remove "cu" parameter.
2658         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
2659         method.
2660
2661 2020-02-08  Tom Tromey  <tom@tromey.com>
2662
2663         * dwarf2/read.c (read_attribute_value, read_indirect_string)
2664         (read_indirect_line_string): Update.
2665         * dwarf2/comp-unit.c (read_offset): Remove.
2666         (read_comp_unit_head): Update.
2667         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
2668         method.
2669         (read_offset): Don't declare.
2670
2671 2020-02-08  Tom Tromey  <tom@tromey.com>
2672
2673         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
2674         * dwarf2/read.c (struct comp_unit_head): Move to
2675         dwarf2/comp-unit.h.
2676         (enum class rcuh_kind): Move to comp-unit.h.
2677         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
2678         (read_comp_unit_head, error_check_comp_unit_head)
2679         (read_and_check_comp_unit_head): Move to comp-unit.c.
2680         (read_offset, dwarf_unit_type_name): Likewise.
2681         (create_debug_type_hash_table, read_cutu_die_from_dwo)
2682         (cutu_reader::cutu_reader, read_call_site_scope)
2683         (find_partial_die, follow_die_offset): Update.
2684         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
2685
2686 2020-02-08  Tom Tromey  <tom@tromey.com>
2687
2688         * dwarf2/read.c (read_offset_1): Move to leb.c.
2689         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
2690         (dwarf_decode_macro_bytes): Update.
2691         * dwarf2/leb.c (read_offset): Rename; move from read.c.
2692         * dwarf2/leb.h (read_offset): Declare.
2693
2694 2020-02-08  Tom Tromey  <tom@tromey.com>
2695
2696         * dwarf2/read.c (dwarf2_section_size): Remove.
2697         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
2698         Update.
2699         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
2700
2701 2020-02-08  Tom Tromey  <tom@tromey.com>
2702
2703         * dwarf2/read.c (read_initial_length): Move to leb.c.
2704         * dwarf2/leb.h (read_initial_length): Declare.
2705         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
2706         handle_nonstd parameter.
2707         * dwarf2/frame.c (read_initial_length): Remove.
2708         (decode_frame_entry_1): Update.
2709
2710 2020-02-08  Tom Tromey  <tom@tromey.com>
2711
2712         * dwarf2/loc.c (dwarf2_find_location_expression)
2713         (dwarf_evaluate_loc_desc::get_tls_address)
2714         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
2715         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
2716         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
2717         (dwarf2_compile_property_to_c)
2718         (dwarf2_loc_desc_get_symbol_read_needs)
2719         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
2720         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
2721         (loclist_describe_location, loclist_tracepoint_var_ref)
2722         (loclist_generate_c_location): Update.
2723         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
2724         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
2725         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
2726         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
2727         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
2728         (dwarf2_per_cu_data::addr_size)
2729         (dwarf2_per_cu_data::ref_addr_size)
2730         (dwarf2_per_cu_data::text_offset)
2731         (dwarf2_per_cu_data::addr_type): Now methods.
2732         (per_cu_header_read_in): Make per_cu "const".
2733         (dwarf2_version): Remove.
2734         (dwarf2_per_cu_data::int_type): Now a method.
2735         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
2736         (set_die_type, read_array_type, read_subrange_index_type)
2737         (read_tag_string_type, read_subrange_type): Update.
2738         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
2739         offset_size, ref_addr_size, text_offset, addr_type, version,
2740         objfile, int_type, addr_sized_int_type>: Declare methods.
2741
2742 2020-02-08  Tom Tromey  <tom@tromey.com>
2743
2744         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
2745         Move earlier.
2746
2747 2020-02-08  Tom Tromey  <tom@tromey.com>
2748
2749         * dwarf2/read.h (dwarf_line_debug): Declare.
2750         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
2751         * dwarf2/read.c: Move line_header code to new files.
2752         (dwarf_line_debug): No longer static.
2753         * dwarf2/line-header.c: New file.
2754         * dwarf2/line-header.h: New file.
2755
2756 2020-02-08  Tom Tromey  <tom@tromey.com>
2757
2758         * dwarf2/read.c (struct line_header) <file_full_name,
2759         file_file_name>: Return unique_xmalloc_ptr.
2760         (line_header::file_file_name): Update.
2761         (line_header::file_full_name): Update.
2762         (dw2_get_file_names_reader): Update.
2763         (macro_start_file): Update.
2764
2765 2020-02-08  Tom Tromey  <tom@tromey.com>
2766
2767         * dwarf2/read.c (struct line_header) <file_full_name,
2768         file_file_name>: Declare methods.
2769         (dw2_get_file_names_reader): Update.
2770         (file_file_name): Now a method.
2771         (file_full_name): Likewise.
2772         (macro_start_file): Update.
2773
2774 2020-02-08  Tom Tromey  <tom@tromey.com>
2775
2776         * dwarf2/read.c (dwarf_always_disassemble)
2777         (show_dwarf_always_disassemble): Move to loc.c.
2778         (_initialize_dwarf2_read): Move "always-disassemble" registration
2779         to loc.c.
2780         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
2781         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
2782         static.
2783         (show_dwarf_always_disassemble): Move from read.c.
2784         (_initialize_dwarf2loc): Move always-disassemble from read.c.
2785
2786 2020-02-08  Tom Tromey  <tom@tromey.com>
2787
2788         * dwarf2/read.c (~dwarf2_per_objfile): Update.
2789         (create_quick_file_names_table): Return htab_up.
2790         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
2791         Update.
2792         * dwarf2/read.h (struct dwarf2_per_objfile)
2793         <quick_file_names_table>: Now htab_up.
2794
2795 2020-02-08  Tom Tromey  <tom@tromey.com>
2796
2797         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
2798
2799 2020-02-08  Tom Tromey  <tom@tromey.com>
2800
2801         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
2802         Rewrite.
2803         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
2804         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
2805         (abbrev_table::abbrev_table): No longer inline.
2806         (ABBREV_HASH_SIZE): Remove.
2807         (abbrev_table::m_abbrevs): Now an htab_up.
2808
2809 2020-02-08  Tom Tromey  <tom@tromey.com>
2810
2811         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
2812         (cutu_reader): Update.
2813         (build_type_psymtabs_1): Update.
2814         * dwarf2/abbrev.c (abbrev_table::read): Rename.
2815         (abbrev_table::alloc_abbrev): Update.
2816         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
2817         (abbrev_table::read): New static method, renamed from
2818         abbrev_table_read_table.
2819         (abbrev_table::alloc_abbrev)
2820         (abbrev_table::add_abbrev): Now private.
2821         (abbrev_table::abbrev_table): Now private.
2822         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
2823
2824 2020-02-08  Tom Tromey  <tom@tromey.com>
2825
2826         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
2827         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
2828         htab_up.
2829
2830 2020-02-08  Tom Tromey  <tom@tromey.com>
2831
2832         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
2833         htab_up.
2834         (lookup_dwo_unit_in_dwp): Update.
2835         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
2836         on obstack.
2837
2838 2020-02-08  Tom Tromey  <tom@tromey.com>
2839
2840         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
2841         obstack.
2842
2843 2020-02-08  Tom Tromey  <tom@tromey.com>
2844
2845         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
2846         line_header_hash.
2847         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
2848         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
2849         Change type to htab_up.
2850
2851 2020-02-08  Tom Tromey  <tom@tromey.com>
2852
2853         * dwarf2/read.c (allocate_type_unit_groups_table): Return
2854         htab_up.  Don't allocate on obstack.
2855         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
2856         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
2857         Change type to htab_up.
2858
2859 2020-02-08  Tom Tromey  <tom@tromey.com>
2860
2861         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
2862         Change type to htab_up.
2863         * dwarf2/read.c (create_signatured_type_table_from_index)
2864         (create_signatured_type_table_from_debug_names)
2865         (create_all_type_units, add_type_unit)
2866         (lookup_dwo_signatured_type, lookup_signatured_type)
2867         (process_skeletonless_type_unit): Update.
2868         (create_debug_type_hash_table, create_debug_types_hash_table):
2869         Change type of types_htab.
2870         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
2871         htab_up.  Don't allocate on obstack.
2872         (create_cus_hash_table): Change type of cus_htab parameter.
2873         (struct dwo_file) <cus, tus>: Now htab_up.
2874         (lookup_dwo_signatured_type, lookup_dwo_cutu)
2875         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
2876         (queue_and_load_all_dwo_tus): Update.
2877         * dwarf2/index-write.c (write_gdbindex): Update.
2878         (write_debug_names): Update.
2879
2880 2020-02-08  Tom Tromey  <tom@tromey.com>
2881
2882         * dwarf2/read.h (struct dwarf2_queue_item): Move from
2883         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
2884         destructor.
2885         (struct dwarf2_per_objfile) <queue>: New member.
2886         * dwarf2/read.c (struct dwarf2_queue_item): Move to
2887         dwarf2/read.h.
2888         (dwarf2_queue, dwarf2_queue_tail): Remove.
2889         (class dwarf2_queue_guard): Add parameter to constructor.  Use
2890         DISABLE_COPY_AND_ASSIGN.
2891         <m_per_objfile>: New member.
2892         <~dwarf2_queue_guard>: Rewrite.
2893         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
2894         Update.
2895         (~dwarf2_queue_item): New.
2896
2897 2020-02-08  Tom Tromey  <tom@tromey.com>
2898
2899         * dwarf2/read.c (struct die_info) <has_children>: New member.
2900         (dw2_get_file_names_reader): Remove has_children.
2901         (dw2_get_file_names): Update.
2902         (read_cutu_die_from_dwo): Remove has_children.
2903         (cutu_reader::init_tu_and_read_dwo_dies)
2904         (cutu_reader::cutu_reader): Update.
2905         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
2906         Remove has_children.
2907         (build_type_psymtabs_1, process_skeletonless_type_unit)
2908         (load_partial_comp_unit, load_full_comp_unit): Update.
2909         (create_dwo_cu_reader): Remove has_children.
2910         (create_cus_hash_table, read_die_and_children): Update.
2911         (read_full_die_1,read_full_die): Remove has_children.
2912         (read_signatured_type): Update.
2913         (class cutu_reader) <has_children>: Remove.
2914
2915 2020-02-08  Tom Tromey  <tom@tromey.com>
2916
2917         * dwarf2/expr.c: Rename from dwarf2expr.c.
2918         * dwarf2/expr.h: Rename from dwarf2expr.h.
2919         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
2920         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
2921         * dwarf2/frame.c: Rename from dwarf2-frame.c.
2922         * dwarf2/frame.h: Rename from dwarf2-frame.h.
2923         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
2924         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
2925         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
2926         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
2927         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
2928         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
2929         * dwarf2/loc.c: Rename from dwarf2loc.c.
2930         * dwarf2/loc.h: Rename from dwarf2loc.h.
2931         * dwarf2/read.c: Rename from dwarf2read.c.
2932         * dwarf2/read.h: Rename from dwarf2read.h.
2933         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
2934         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
2935         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
2936         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
2937         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
2938         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
2939         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
2940         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
2941         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
2942         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
2943         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
2944         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
2945         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
2946         Update.
2947         * Makefile.in (COMMON_SFILES): Update.
2948         (HFILES_NO_SRCDIR): Update.
2949
2950 2020-02-08  Tom Tromey  <tom@tromey.com>
2951
2952         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
2953         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
2954
2955 2020-02-08  Tom Tromey  <tom@tromey.com>
2956
2957         * dwarf2read.h (struct die_info): Don't declare.
2958
2959 2020-02-08  Tom Tromey  <tom@tromey.com>
2960
2961         * dwarf2read.h (die_info_ptr): Remove typedef.
2962
2963 2020-02-08  Tom Tromey  <tom@tromey.com>
2964
2965         * dwarf2read.c (read_call_site_scope)
2966         (handle_data_member_location, dwarf2_add_member_fn)
2967         (mark_common_block_symbol_computed, read_common_block)
2968         (attr_to_dynamic_prop, partial_die_info::read)
2969         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
2970         (dwarf2_symbol_mark_computed, set_die_type): Update.
2971         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
2972         method.
2973         (attr_form_is_block): Don't declare.
2974         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
2975
2976 2020-02-08  Tom Tromey  <tom@tromey.com>
2977
2978         * dwarf2read.c (dwarf2_find_base_address, )
2979         (read_call_site_scope, rust_containing_type)
2980         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
2981         (handle_data_member_location, dwarf2_add_member_fn)
2982         (get_alignment, read_structure_type, process_structure_scope)
2983         (mark_common_block_symbol_computed, read_common_block)
2984         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
2985         (partial_die_info::read, read_attribute_value, new_symbol)
2986         (lookup_die_type, dwarf2_get_ref_die_offset)
2987         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
2988         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
2989         (dwarf2_symbol_mark_computed): Update.
2990         * dwarf2/attribute.h (struct attribute) <value_as_address,
2991         form_is_section_offset, form_is_constant, form_is_ref>: Declare
2992         methods.
2993         (value_as_address, attr_form_is_section_offset)
2994         (attr_form_is_constant, attr_form_is_ref): Don't declare.
2995         * dwarf2/attribute.c (attribute::value_as_address)
2996         (attribute::form_is_section_offset, attribute::form_is_constant)
2997         (attribute::form_is_ref): Now methods.
2998
2999 2020-02-08  Tom Tromey  <tom@tromey.com>
3000
3001         * dwarf2read.c (struct attribute, DW_STRING)
3002         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
3003         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
3004         (attr_form_is_block, attr_form_is_section_offset)
3005         (attr_form_is_constant, attr_form_is_ref): Move.
3006         * dwarf2/attribute.h: New file.
3007         * dwarf2/attribute.c: New file, from dwarf2read.c.
3008         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
3009
3010 2020-02-08  Tom Tromey  <tom@tromey.com>
3011
3012         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
3013         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
3014         Move.
3015         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
3016         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
3017         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
3018         abbrev.c.
3019         * dwarf2/abbrev.h: New file.
3020         * dwarf2/abbrev.c: New file, from dwarf2read.c.
3021         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
3022
3023 2020-02-08  Tom Tromey  <tom@tromey.com>
3024
3025         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
3026         (dwarf2_section_size, dwarf2_get_section_info)
3027         (create_signatured_type_table_from_debug_names)
3028         (create_addrmap_from_aranges, read_debug_names_from_section)
3029         (get_gdb_index_contents_from_section, read_comp_unit_head)
3030         (error_check_comp_unit_head, read_abbrev_offset)
3031         (create_debug_type_hash_table, init_cu_die_reader)
3032         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
3033         (read_comp_units_from_section, create_cus_hash_table)
3034         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
3035         (create_dwp_v2_section, dwarf2_rnglists_process)
3036         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
3037         (abbrev_table_read_table, read_indirect_string_at_offset_from)
3038         (read_indirect_string_from_dwz, read_addr_index_1)
3039         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
3040         (dwarf_decode_macro_bytes, dwarf_decode_macros)
3041         (fill_in_loclist_baton): Update.
3042         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
3043         get_containing_section, get_bfd_owner, get_bfd_section,
3044         get_file_name, get_id, get_flags, empty, read>: Declare methods.
3045         (dwarf2_read_section, get_section_name, get_section_file_name)
3046         (get_containing_section, get_section_bfd_owner)
3047         (get_section_bfd_section, get_section_name, get_section_file_name)
3048         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
3049         declare.
3050         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
3051         (dwarf2_section_info::get_bfd_owner)
3052         (dwarf2_section_info::get_bfd_section)
3053         (dwarf2_section_info::get_name)
3054         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
3055         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
3056         (dwarf2_section_info::read): Now methods.
3057         * dwarf-index-write.c (class debug_names): Update.
3058
3059 2020-02-08  Tom Tromey  <tom@tromey.com>
3060
3061         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
3062         Move to dwarf2/section.h.
3063         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
3064         (get_section_bfd_section, get_section_name)
3065         (get_section_file_name, get_section_id, get_section_flags)
3066         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
3067         dwarf2/section.c.
3068         * dwarf2/section.h: New file.
3069         * dwarf2/section.c: New file, from dwarf2read.c.
3070         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
3071
3072 2020-02-08  Tom Tromey  <tom@tromey.com>
3073
3074         * dwarf2read.h (read_unsigned_leb128): Don't declare.
3075         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
3076         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
3077         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
3078         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
3079         * dwarf2/leb.h: New file, from dwarf2read.c.
3080         * dwarf2/leb.c: New file, from dwarf2read.c.
3081         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
3082         Remove.
3083         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
3084         (COMMON_SFILES): Add dwarf2/leb.c.
3085
3086 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
3087
3088         GDB 9.1 released.
3089
3090 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
3091
3092         PR gdb/25190:
3093         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
3094         * gdb/remote.c (remote_console_output): Update.
3095         * gdb/ui-file.c (fputs_unfiltered): Rename to...
3096         (ui_file_puts): ...this.
3097         * gdb/ui-file.h (ui_file_puts): Add declaration.
3098         * gdb/utils.c (emit_style_escape): Update.
3099         (flush_wrap_buffer): Update.
3100         (fputs_maybe_filtered): Update.
3101         (fputs_unfiltered): Add function.
3102
3103 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
3104
3105         * gdb/event-loop.c (gdb_wait_for_event): Update.
3106         * gdb/printcmd.c (printf_command): Update.
3107         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
3108         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
3109         (gdb_os_flush_stderr): Update.
3110         * gdb/remote.c (remote_console_output): Update.
3111         * gdb/ui-file.c (gdb_flush): Rename to...
3112         (ui_file_flush): ...this.
3113         (stderr_file::write): Update.
3114         (stderr_file::puts): Update.
3115         * gdb/ui-file.h (gdb_flush): Rename to...
3116         (ui_file_flush): ...this.
3117         * gdb/utils.c (gdb_flush): Add function.
3118         * gdb/utils.h (gdb_flush): Add declaration.
3119
3120 2020-02-07  Tom Tromey  <tromey@adacore.com>
3121
3122         PR breakpoints/24915:
3123         * source.c (find_and_open_source): Do not check basenames_may_differ.
3124
3125 2020-02-07  Tom Tromey  <tom@tromey.com>
3126
3127         * README: Update gdbserver documentation.
3128         * gdbserver: Move to top level.
3129         * configure.tgt (build_gdbserver): Remove.
3130         * configure.ac: Remove --enable-gdbserver.
3131         * configure: Rebuild.
3132         * Makefile.in (distclean): Don't mention gdbserver.
3133
3134 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
3135
3136         * source-cache.c (source_cache::ensure): Surround
3137         get_plain_source_lines with a try/catch.
3138         (source_cache::get_line_charpos): Get rid of try/catch
3139         and only check for the return value of "ensure".
3140         * tui/tui-source.c (tui_source_window::set_contents):
3141         Simplify "nlines" calculation.
3142
3143 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
3144
3145         * MAINTAINERS (Write After Approval): Add myself.
3146
3147 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
3148
3149         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
3150         function call.
3151
3152 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
3153
3154         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
3155
3156 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
3157
3158         * nat/riscv-linux-tdesc.h: New file.
3159         * nat/riscv-linux-tdesc.c: New file, taking code from...
3160         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
3161         ... here.
3162         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
3163         NATDEPFILES.
3164
3165 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
3166
3167         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
3168         we don't set the fake simulator ptid to the null_ptid.
3169
3170 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
3171
3172         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
3173         * gdbthread.h (class thread_info) <resumed>: Likewise.
3174         * infrun.c (resume_1): Likewise.
3175         (proceed): Likewise.
3176         (infrun_thread_stop_requested): Likewise.
3177         (stop_all_threads): Likewise.
3178         (handle_inferior_event): Likewise.
3179         (restart_threads): Likewise.
3180         (finish_step_over): Likewise.
3181         (keep_going_stepped_thread): Likewise.
3182         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
3183         (linux_handle_extended_wait): Likewise.
3184         * record-btrace.c (get_thread_current_frame_id): Likewise.
3185         * record-full.c (record_full_wait_1): Likewise.
3186         * remote.c (remote_target::process_initial_stop_replies): Likewise.
3187         * target.c (target_resume): Likewise.
3188         * thread.c (set_running_thread): Likewise.
3189
3190 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3191
3192         * f-valprint.c (f77_print_array_1): Changed datatype of index
3193         variable to LONGEST from int to enable it to contain bound
3194         values correctly.
3195
3196 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
3197
3198         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
3199         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
3200         offsets according to FLEN determined.
3201         (riscv_linux_nat_target::read_description): Determine FLEN
3202         dynamically.
3203         (riscv_linux_nat_target::fetch_registers): Size regset buffer
3204         according to FLEN determined.
3205         (riscv_linux_nat_target::store_registers): Likewise.
3206
3207 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3208
3209         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3210         when reg->group is empty and reggroup is not.
3211
3212 2020-01-31  Tom Tromey  <tromey@adacore.com>
3213
3214         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
3215         Call beneath target's mourn_inferior after unpushing.
3216
3217 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
3218
3219         PR tui/9765
3220         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
3221         have enough lines to fill the screen, still return the lowest
3222         address we found.
3223
3224 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
3225
3226         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
3227         '-', '<', and '>' commands.
3228
3229 2020-01-29  Pedro Alves  <palves@redhat.com>
3230             Sergio Durigan Junior  <sergiodj@redhat.com>
3231
3232         * infcmd.c (construct_inferior_arguments): Assert that
3233         'argc' is greater than 0.
3234
3235 2020-01-29  Luis Machado  <luis.machado@linaro.org>
3236
3237         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
3238         (BRK_INSN_MASK): Define to 0xd4200000.
3239         (aarch64_program_breakpoint_here_p): New function.
3240         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
3241         * arch-utils.c (default_program_breakpoint_here_p): Moved from
3242         breakpoint.c.
3243         * arch-utils.h (default_program_breakpoint_here_p): Moved from
3244         breakpoint.h
3245         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
3246         call gdbarch_program_breakpoint_here_p.
3247         (program_breakpoint_here): Moved to arch-utils.c, renamed to
3248         default_program_breakpoint_here_p, changed return type to bool and
3249         simplified.
3250         * breakpoint.h (program_breakpoint_here): Moved prototype to
3251         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
3252         return type to bool.
3253         * gdbarch.c: Regenerate.
3254         * gdbarch.h: Regenerate.
3255         * gdbarch.sh (program_breakpoint_here_p): New method.
3256         * infrun.c (handle_signal_stop): Call
3257         gdbarch_program_breakpoint_here_p.
3258
3259 2020-01-26  Tom Tromey  <tom@tromey.com>
3260
3261         * ctfread.c (struct ctf_fp_info): Reindent.
3262         (_initialize_ctfread): Remove.
3263
3264 2020-01-26  Tom Tromey  <tom@tromey.com>
3265
3266         * psymtab.c (partial_map_expand_apply)
3267         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
3268         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
3269         (psym_print_stats, psym_expand_symtabs_for_function)
3270         (psym_map_symbol_filenames, psym_map_matching_symbols)
3271         (psym_expand_symtabs_matching)
3272         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
3273         (maintenance_check_psymtabs): Use new methods.
3274         * psympriv.h (struct partial_symtab) <readin_p,
3275         get_compunit_symtab>: New methods.
3276         <readin, compunit_symtab>: Remove members.
3277         (struct standard_psymtab): New.
3278         (struct legacy_psymtab): Derive from standard_psymtab.
3279         * dwarf2read.h (struct dwarf2_psymtab): Derive from
3280         standard_psymtab.
3281         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
3282
3283 2020-01-26  Tom Tromey  <tom@tromey.com>
3284
3285         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
3286         read_dependencies.  Add assert.
3287         * psymtab.c (partial_symtab::read_dependencies): New method.
3288         * psympriv.h (struct partial_symtab) <read_dependencies>: New
3289         method.
3290         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
3291         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
3292         read_dependencies.
3293         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
3294         Add assert.
3295
3296 2020-01-26  Tom Tromey  <tom@tromey.com>
3297
3298         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
3299         Call expand_psymtab.
3300         (xcoff_read_symtab): Call expand_psymtab.
3301         (xcoff_start_psymtab, xcoff_end_psymtab): Set
3302         legacy_expand_psymtab.
3303         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
3304         method.
3305         (struct legacy_psymtab) <expand_psymtab>: Implement.
3306         <legacy_expand_psymtab>: New member.
3307         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
3308         (parse_partial_symbols): Set legacy_expand_psymtab.
3309         (psymtab_to_symtab_1): Change argument order.  Call
3310         expand_psymtab.
3311         (new_psymtab): Set legacy_expand_psymtab.
3312         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
3313         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
3314         expand_psymtab.
3315         (dwarf2_psymtab::expand_psymtab): Rename from
3316         psymtab_to_symtab_1.  Call expand_psymtab.
3317         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
3318         (dbx_end_psymtab): Likewise.
3319         (dbx_psymtab_to_symtab_1): Change argument order. Call
3320         expand_psymtab.
3321         (dbx_read_symtab): Call expand_psymtab.
3322         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
3323         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
3324         (ctf_psymtab::read_symtab): Call expand_psymtab.
3325
3326 2020-01-26  Tom Tromey  <tom@tromey.com>
3327
3328         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
3329         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
3330         messages.
3331         * mdebugread.c (mdebug_read_symtab): Remove prints.
3332         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
3333         assert.
3334         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
3335
3336 2020-01-26  Tom Tromey  <tom@tromey.com>
3337
3338         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
3339         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
3340         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
3341         legacy_symtab.
3342         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
3343         * psymtab.c (psymtab_to_symtab): Call method.
3344         (dump_psymtab): Update.
3345         * psympriv.h (struct partial_symtab): Add virtual destructor.
3346         <read_symtab>: New method.
3347         (struct legacy_symtab): New.
3348         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
3349         (struct pst_map) <pst>: Now a legacy_psymtab.
3350         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
3351         (new_psymtab): Use legacy_psymtab.
3352         * dwarf2read.h (struct dwarf2_psymtab): New.
3353         (struct dwarf2_per_cu_data) <psymtab>: Use it.
3354         * dwarf2read.c (dwarf2_create_include_psymtab)
3355         (dwarf2_build_include_psymtabs, create_type_unit_group)
3356         (create_partial_symtab, process_psymtab_comp_unit_reader)
3357         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
3358         (set_partial_user): Use dwarf2_psymtab.
3359         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
3360         (psymtab_to_symtab_1, process_full_comp_unit)
3361         (process_full_type_unit, dwarf2_ranges_read)
3362         (dwarf2_get_pc_bounds, psymtab_include_file_name)
3363         (dwarf_decode_lines): Use dwarf2_psymtab.
3364         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
3365         (add_address_entry_worker, write_one_signatured_type)
3366         (recursively_count_psymbols, recursively_write_psymbols)
3367         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
3368         (write_debug_names): Likewise.
3369         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
3370         <pst>: Now a legacy_psymtab.
3371         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
3372         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
3373         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
3374         * ctfread.c (struct ctf_psymtab): New.
3375         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
3376         ctf_psymtab.
3377         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
3378         (create_partial_symtab): Return a ctf_psymtab.
3379         (scan_partial_symbols): Update.
3380
3381 2020-01-26  Tom Tromey  <tom@tromey.com>
3382
3383         * xcoffread.c (xcoff_start_psymtab): Use new.
3384         * psymtab.c (partial_symtab::partial_symtab): New constructor,
3385         renamed from start_psymtab_common.
3386         * psympriv.h (struct partial_symtab): Add new constructor.
3387         (start_psymtab_common): Don't declare.
3388         * mdebugread.c (parse_partial_symbols): Use new.
3389         * dwarf2read.c (create_partial_symtab): Use new.
3390         * dbxread.c (start_psymtab): Use new.
3391         * ctfread.c (create_partial_symtab): Use new.
3392
3393 2020-01-26  Tom Tromey  <tom@tromey.com>
3394
3395         * xcoffread.c (xcoff_end_psymtab): Use new.
3396         * psymtab.c (start_psymtab_common): Use new.
3397         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
3398         Update.
3399         * psympriv.h (struct partial_symtab): Add parameters to
3400         constructor.  Don't inline.
3401         (allocate_psymtab): Don't declare.
3402         * mdebugread.c (new_psymtab): Use new.
3403         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
3404         * dbxread.c (dbx_end_psymtab): Use new.
3405
3406 2020-01-26  Tom Tromey  <tom@tromey.com>
3407
3408         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
3409         allocate_psymtab.  Update documentation.
3410         * psymtab.c (psymtab_storage::install_psymtab): Rename from
3411         allocate_psymtab.  Do not use new.
3412         (allocate_psymtab): Use new.  Update.
3413
3414 2020-01-26  Tom Tromey  <tom@tromey.com>
3415
3416         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
3417         * psymtab.c (psym_print_stats): Update.
3418         * psympriv.h (struct partial_symtab) <readin,
3419         psymtabs_addrmap_supported, anonymous>: Now bool.
3420         * mdebugread.c (psymtab_to_symtab_1): Update.
3421         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
3422         (build_type_psymtabs_reader, psymtab_to_symtab_1)
3423         (process_full_comp_unit, process_full_type_unit): Update.
3424         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
3425         * ctfread.c (psymtab_to_symtab): Update.
3426
3427 2020-01-26  Tom Tromey  <tom@tromey.com>
3428
3429         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
3430         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
3431         * psymtab.c (psymtab_storage): Delete psymtabs.
3432         (psymtab_storage::allocate_psymtab): Use new.
3433         (psymtab_storage::discard_psymtab): Use delete.
3434         * psympriv.h (struct partial_symtab): Add constructor and
3435         initializers.
3436
3437 2020-01-26  Tom Tromey  <tom@tromey.com>
3438
3439         * machoread.c: Do not include psympriv.h.
3440
3441 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3442
3443         * NEWS: Mention the new option and the set/show commands.
3444
3445 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3446
3447         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
3448         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
3449         (validate_exec_file): New variables, enums, functions.
3450         (exec_file_locate_attach, print_section_info): Style the filenames.
3451         (_initialize_exec): Install show_exec_file_mismatch_command and
3452          set_exec_file_mismatch_command.
3453         * gdbcore.h (validate_exec_file): Declare.
3454         * infcmd.c (attach_command): Call validate_exec_file.
3455         * remote.c ( remote_target::remote_add_inferior): Likewise.
3456
3457 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3458
3459         * frame.c (find_frame_sal): Move call to get_next_frame into more
3460         inner scope.
3461         * inline-frame.c (inilne_state) <inline_state>: Update argument
3462         types.
3463         (inilne_state) <skipped_symbol>: Rename to...
3464         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
3465         (skip_inline_frames): Build vector of skipped symbols and use this
3466         to reate the inline_state.
3467         (inline_skipped_symbol): Add a comment and some assertions, fetch
3468         skipped symbol from the list.
3469
3470 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3471
3472         * buildsym.c (lte_is_less_than): Delete.
3473         (buildsym_compunit::end_symtab_with_blockvector): Create local
3474         lambda function to sort line table entries, and use
3475         std::stable_sort instead of std::sort.
3476         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
3477         markers when looking for a previous line.
3478
3479 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3480
3481         * dwarf2read.c (lnp_state_machine::record_line): Include
3482         end_sequence parameter in debug print out.  Record the line if we
3483         are at an end_sequence marker even if it's not the start of a
3484         statement.
3485         * symmisc.c (maintenance_print_one_line_table): Print end of
3486         sequence markers with 'END' not '0'.
3487
3488 2020-01-24  Pedro Alves  <palves@redhat.com>
3489
3490         PR gdb/25410
3491         * thread.c (scoped_restore_current_thread::restore): Use
3492         switch_to_inferior_no_thread.
3493         * exec.c: Include "progspace-and-thread.h".
3494         (add_target_sections, remove_target_sections):
3495         scoped_restore_current_pspace_and_thread instead of
3496         scoped_restore_current_thread.
3497         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
3498         and aspace to the inferior before calling clone_program_space.
3499         Remove stale comment.
3500
3501 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3502
3503         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
3504         (arm_netbsd_nat_target::fetch_registers): ...this.
3505         (arm_nbsd_nat_target::store_registers): Rename to...
3506         (arm_netbsd_nat_target::store_registers): ...this.
3507
3508 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3509
3510         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
3511         register_t.
3512
3513 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
3514
3515         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
3516         Update comment.
3517         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
3518         Likewise.
3519         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
3520         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
3521         the correct replacement (iterate_over_regset_sections).
3522         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
3523         Update comment.
3524
3525 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
3526
3527         PR gdb/23718
3528         * gdb/python/python.c (execute_gdb_command): Call
3529         async_enable_stdin in catch block.
3530
3531 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3532
3533         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
3534         SWITCH_THRU_ALL_UIS.
3535
3536 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3537
3538         PR tui/9765
3539         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
3540         comment, add extra parameter, and update to store previous symbol
3541         when appropriate.
3542         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
3543         add extra parameter.
3544         * tui/tui-disasm.c (tui_disassemble): Update header comment,
3545         remove unneeded parameter, add try/catch around gdb_print_insn,
3546         rewrite to add items to asm_lines vector.
3547         (tui_find_backward_disassembly_start_address): New function.
3548         (tui_find_disassembly_address): Updated throughout.
3549         (tui_disasm_window::set_contents): Update for changes to
3550         tui_disassemble.
3551         (tui_disasm_window::do_scroll_vertical): No need to adjust the
3552         number of lines to scroll.
3553
3554 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
3555
3556         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
3557         (SECT_OFF_DATA): Likewise.
3558         (SECT_OFF_RODATA): Likewise.
3559         (SECT_OFF_TEXT): Likewise.
3560         (SECT_OFF_BSS): Likewise.
3561         (struct objfile) <text_section_offset, data_section_offset>: New
3562         methods.
3563         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
3564         objfile::text_section_offset.
3565         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
3566         * coffread.c (coff_symtab_read): Likewise.
3567         (enter_linenos): Likewise.
3568         (process_coff_symbol): Likewise.
3569         * ctfread.c (get_objfile_text_range): Likewise.
3570         * dtrace-probe.c (dtrace_probe::get_relocated_address):
3571         Use objfile::data_section_offset.
3572         * dwarf2-frame.c (execute_cfa_program): Use
3573         objfile::text_section_offset.
3574         (dwarf2_frame_find_fde): Likewise.
3575         * dwarf2read.c (create_addrmap_from_index): Likewise.
3576         (create_addrmap_from_aranges): Likewise.
3577         (dw2_find_pc_sect_compunit_symtab): Likewise.
3578         (process_psymtab_comp_unit_reader): Likewise.
3579         (add_partial_symbol): Likewise.
3580         (add_partial_subprogram): Likewise.
3581         (process_full_comp_unit): Likewise.
3582         (read_file_scope): Likewise.
3583         (read_func_scope): Likewise.
3584         (read_lexical_block_scope): Likewise.
3585         (read_call_site_scope): Likewise.
3586         (dwarf2_rnglists_process): Likewise.
3587         (dwarf2_ranges_process): Likewise.
3588         (dwarf2_ranges_read): Likewise.
3589         (dwarf_decode_lines_1): Likewise.
3590         (new_symbol): Likewise.
3591         (dwarf2_fetch_die_loc_sect_off): Likewise.
3592         (dwarf2_per_cu_text_offset): Likewise.
3593         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
3594         * hppa-tdep.c (read_unwind_info): Likewise.
3595         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
3596         * psympriv.h (struct partial_symtab): Likewise.
3597         * psymtab.c (find_pc_sect_psymtab): Likewise.
3598         * solib-svr4.c (enable_break): Likewise.
3599         * stap-probe.c (relocate_address): Use
3600         objfile::data_section_offset.
3601         * xcoffread.c (enter_line_range): Use
3602         objfile::text_section_offset.
3603         (read_xcoff_symtab): Likewise.
3604
3605 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
3606
3607         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
3608         declaration to narrower scopes.
3609
3610 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
3611
3612         * darwin-nat.h (struct darwin_exception_msg, enum
3613         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
3614         Move up.
3615         (class darwin_nat_target) <wait_1, check_new_threads,
3616         decode_exception_message, decode_message, stop_inferior,
3617         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
3618         * darwin-nat.c (darwin_check_new_threads): Rename to...
3619         (darwin_nat_target::check_new_threads): ... this.
3620         (darwin_suspend_inferior_it): Remove.
3621         (darwin_decode_exception_message): Rename to...
3622         (darwin_nat_target::decode_exception_message): ... this.
3623         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
3624         (darwin_decode_message): Rename to...
3625         (darwin_nat_target::decode_message): ... this.
3626         (cancel_breakpoint): Rename to...
3627         (darwin_nat_target::cancel_breakpoint): ... this.
3628         (darwin_wait): Rename to...
3629         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
3630         instead of iterate_over_inferiors.
3631         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
3632         (darwin_stop_inferior): Rename to...
3633         (darwin_nat_target::stop_inferior): ... this.
3634         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
3635         (darwin_init_thread_list): Rename to...
3636         (darwin_nat_target::init_thread_list): ... this.
3637         (darwin_ptrace_him): Rename to...
3638         (darwin_nat_target::ptrace_him): ... this.
3639         (darwin_nat_target::create_inferior): Pass lambda function to
3640         fork_inferior.
3641         (darwin_nat_target::detach): Call stop_inferior instead of
3642         darwin_stop_inferior.
3643         * fork-inferior.h (fork_inferior): Change init_trace_fun
3644         parameter to gdb::function_view.
3645         * fork-inferior.c (fork_inferior): Likewise.
3646
3647 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
3648
3649         * i386-cygwin-tdep.c (core_process_module_section): Update.
3650         * windows-nat.c (struct lm_info_windows): Add text_offset.
3651         (windows_xfer_shared_libraries): Update.
3652         * windows-tdep.c (windows_xfer_shared_library):
3653         Add text_offset_cached argument.
3654         * windows-tdep.h (windows_xfer_shared_library): Update.
3655
3656 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
3657
3658         * gdbarch.sh: Add declaration for _initialize_gdbarch.
3659
3660 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
3661
3662         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
3663         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
3664         replace with range-based for.
3665         (gdbsim_interrupt_inferior): Remove.
3666         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
3667         with a range-based for.  Inline code from
3668         gdbsim_interrupt_inferior.
3669
3670 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
3671
3672         * infrun.c (proceed): Fix indentation.
3673
3674 2020-01-21  Tom Tromey  <tromey@adacore.com>
3675
3676         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
3677         * python/python.c (python_extension_ops): Update.
3678         (gdbpy_colorize): New function.
3679         * python/lib/gdb/__init__.py (colorize): New function.
3680         * extension.h (ext_lang_colorize): Declare.
3681         * extension.c (ext_lang_colorize): New function.
3682         * extension-priv.h (struct extension_language_ops) <colorize>: New
3683         member.
3684         * cli/cli-style.c (_initialize_cli_style): Update help text.
3685
3686 2020-01-21  Luis Machado  <luis.machado@linaro.org>
3687
3688         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
3689         <cond>: Change type to bool.
3690         (aarch64_displaced_step_b_cond): Update cond to use bool type.
3691         (aarch64_displaced_step_cb): Likewise.
3692         (aarch64_displaced_step_tb): Likewise.
3693
3694 2020-01-21  Luis Machado  <luis.machado@linaro.org>
3695
3696         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
3697         output.
3698
3699 2020-01-21  Luis Machado  <luis.machado@linaro.org>
3700
3701         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
3702         <pc_adjust>: Adjust the documentation.
3703         (aarch64_displaced_step_fixup): Check if PC really moved before
3704         adjusting it.
3705
3706 2020-01-19  Tom Tromey  <tom@tromey.com>
3707
3708         * disasm.c (~gdb_disassembler): New destructor.
3709         (gdb_buffered_insn_length): Call disassemble_free_target.
3710         * disasm.h (class gdb_disassembler): Declare destructor.  Use
3711         DISABLE_COPY_AND_ASSIGN.
3712
3713 2020-01-19  Tom Tromey  <tom@tromey.com>
3714
3715         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
3716         (die_reader_func_ftype): Remove.
3717         (cutu_reader): New class.
3718         (dw2_get_file_names_reader): Remove "data" parameter.
3719         (dw2_get_file_names): Use cutu_reader.
3720         (create_debug_type_hash_table): Update.
3721         (read_cutu_die_from_dwo): Update comment.
3722         (lookup_dwo_unit): Add dwo_name parameter.
3723         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
3724         die_reader_func_ftype and data parameters.
3725         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
3726         Remove die_reader_func_ftype and data parameters.
3727         (~cutu_reader): New; from init_cutu_and_read_dies.
3728         (cutu_reader::cutu_reader): Rename from
3729         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
3730         and data parameters.
3731         (init_cutu_and_read_dies_simple): Remove.
3732         (struct process_psymtab_comp_unit_data): Remove.
3733         (process_psymtab_comp_unit_reader): Remove data parameter; add
3734         want_partial_unit and pretend_language parameters.
3735         (process_psymtab_comp_unit): Use cutu_reader.
3736         (build_type_psymtabs_reader): Remove data parameter.
3737         (build_type_psymtabs_1): Use cutu_reader.
3738         (process_skeletonless_type_unit): Likewise.
3739         (load_partial_comp_unit_reader): Remove.
3740         (load_partial_comp_unit): Use cutu_reader.
3741         (load_full_comp_unit_reader): Remove.
3742         (load_full_comp_unit): Use cutu_reader.
3743         (struct create_dwo_cu_data): Remove.
3744         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
3745         dwo_unit parameters.
3746         (create_cus_hash_table): Use cutu_reader.
3747         (struct dwarf2_read_addr_index_data): Remove.
3748         (dwarf2_read_addr_index_reader): Remove.
3749         (dwarf2_read_addr_index): Use cutu_reader.
3750         (read_signatured_type_reader): Remove.
3751         (read_signatured_type): Use cutu_reader.
3752
3753 2020-01-19  Tom Tromey  <tom@tromey.com>
3754
3755         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
3756         * tui/tui-wingeneral.h (class tui_suppress_output): New.
3757         (tui_wrefresh): Declare.
3758         * tui/tui-wingeneral.c (suppress_output): New global.
3759         (tui_suppress_output, ~tui_suppress_output): New constructor and
3760         destructor.
3761         (tui_wrefresh): New function.
3762         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
3763         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
3764         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
3765         method.
3766         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
3767         tui_wrefresh.
3768         (tui_data_window::no_refresh): New method.
3769         (tui_data_item_window::refresh_window): Call tui_wrefresh.
3770         (tui_reg_command): Use tui_suppress_output
3771         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
3772         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
3773         method.
3774         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
3775
3776 2020-01-19  Tom Tromey  <tom@tromey.com>
3777
3778         * tui/tui-winsource.c (tui_update_source_windows_with_line):
3779         Handle case where symtab is null.
3780
3781 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
3782
3783         * linux-fork.c (one_fork_p): Simplify.
3784
3785 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
3786
3787         * top.c (struct qt_args): Remove.
3788         (kill_or_detach): Change return type to void, replace `void *`
3789         parameter with a proper one.
3790         (print_inferior_quit_action):  Likewise.
3791         (quit_confirm): Use range-based for loop to iterate over inferiors.
3792         (quit_force): Likewise.
3793
3794 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
3795
3796         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
3797         `void *` parameter with proper parameters.
3798         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
3799         (print_one_inferior): Change return type to void, replace `void *`
3800         parameter with proper parameters.
3801         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
3802         inferiors.
3803         (get_other_inferior): Remove.
3804         (mi_cmd_remove_inferior): Use range-based loop to iterate over
3805         inferiors.
3806
3807 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
3808
3809         * mi/mi-interp.c (report_initial_inferior): Remove.
3810         (mi_interp::init): Use range-based for to iterate over inferiors.
3811
3812 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
3813
3814         * python/py-inferior.c (build_inferior_list): Remove.
3815         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
3816
3817 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
3818
3819         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
3820         (btrace_stitch_trace): Likewise.
3821         * charset.c (intermediate_encoding): Likewise (vaild).
3822         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
3823         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
3824         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
3825
3826 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
3827
3828         * windows-tdep.c (windows_get_tlb_type):
3829         Add rtl_user_process_parameters type.
3830
3831 2020-01-16  Pedro Alves  <palves@redhat.com>
3832             Norbert Lange  <nolange79@gmail.com>
3833
3834         PR build/24805
3835         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
3836         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
3837         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
3838         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
3839         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
3840         (ps_plog): Redeclare exported functions with default visibility.
3841
3842 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
3843
3844         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
3845         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
3846
3847 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
3848
3849         * infcmd.c (post_create_inferior): Use get_thread_regcache
3850         instead of get_current_regcache.
3851
3852 2020-01-14  Tom Tromey  <tom@tromey.com>
3853
3854         PR symtab/12535:
3855         * python/python.c (gdbpy_decode_line): Treat empty string the same
3856         as no argument.
3857
3858 2020-01-14  Tom Tromey  <tom@tromey.com>
3859
3860         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
3861
3862 2020-01-14  Tom Tromey  <tom@tromey.com>
3863
3864         * nat/linux-btrace.c: Don't include <config.h>.
3865         * nat/linux-ptrace.c: Don't include <config.h>.
3866         * nat/x86-linux-dregs.c: Don't include <config.h>.
3867
3868 2020-01-14  Tom Tromey  <tom@tromey.com>
3869
3870         * configure: Rebuild.
3871         * configure.ac: Move many checks to ../gdbsupport/common.m4.
3872
3873 2020-01-14  Tom Tromey  <tom@tromey.com>
3874
3875         * nat/x86-linux-dregs.c: Include configh.h.
3876         * nat/linux-ptrace.c: Include configh.h.
3877         * nat/linux-btrace.c: Include configh.h.
3878         * defs.h: Include config.h, bfd.h.
3879         * configure.ac: Don't source common.host.
3880         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
3881         * configure: Rebuild.
3882         * acinclude.m4: Update path.
3883         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
3884         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
3885         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
3886         (CLIBS): Add LIBSUPPORT.
3887         (CDEPS): Likewise.
3888         (COMMON_SFILES): Remove gdbsupport files.
3889         (HFILES_NO_SRCDIR): Likewise.
3890         (stamp-version): Update path to create-version.sh.
3891         (ALLDEPFILES): Remove gdbsupport files.
3892
3893 2020-01-14  Tom Tromey  <tom@tromey.com>
3894
3895         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
3896         USE_WIN32API when needed.
3897         * configure.ac (USE_WIN32API): Don't define.
3898         (WIN32LIBS): Use WIN32APILIBS.
3899         * configure: Rebuild.
3900
3901 2020-01-14  Tom Tromey  <tom@tromey.com>
3902
3903         * configure: Rebuild.
3904         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
3905
3906 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3907
3908         * skip.c (skip_function_command): Make skip w/o arguments use the
3909         name of the inlined function if pc is inside any inlined function.
3910
3911 2020-01-14  Luis Machado  <luis.machado@linaro.org>
3912
3913         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
3914         * infrun.c (resume_1): Likewise.
3915         (handle_inferior_event): Remove stale comment.
3916         * linux-nat.c (linux_nat_target::resume): Update comments.
3917         (save_stop_reason): Likewise.
3918         (linux_nat_filter_event): Likewise.
3919         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
3920
3921 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3922
3923         * elfread.c (record_minimal_symbol): Set section index to 0 for
3924         non-allocatable sections.
3925
3926
3927 2020-01-13  Ali Tamur <tamur@google.com>
3928
3929         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
3930         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
3931         to gdb::optional.  Update comments.
3932         (dwo_file): Update comments.
3933         (read_attribute): Update API to take an additional out parameter,
3934         need_reprocess.  This is used to mark attributes that need other
3935         attributes (e.g. str_offsets_base) for correct computation which may not
3936         have been read yet.
3937         (read_attribute_reprocess): New function declaration.
3938         (read_addr_index): Likewise.
3939         (read_dwo_str_index): Likewise.
3940         (read_stub_str_index): Likewise.
3941         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
3942         (lookup_addr_base): New function definition.
3943         (lookup_ranges_base): Likewise.
3944         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
3945         lookup_ranges_base.
3946         (init_cutu_and_read_dies): Update comments.
3947         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
3948         unit.  This is used to inherit parent's str_offsets_base and addr_base.
3949         Update comments.
3950         (init_cutu_and_read_dies_simple): Reflect API changes.
3951         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
3952         (create_cus_hash_table): Change API to take parent compile unit.
3953         Reflect API changes.
3954         (open_and_init_dwo_file): Reflect API changes.
3955         (dwarf2_get_pc_bounds): Update comments.
3956         (dwarf2_record_block_ranges): Likewise.
3957         (read_full_die_1): Change implementation to reprocess attributes that
3958         need str_offsets_base and addr_base.
3959         (partial_die_info::read): Likewise.
3960         (read_attribute_reprocess): New function definition.
3961         (read_attribute_value): Change API to take an additional out parameter,
3962         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
3963         when a non-dwo compile unit has index based attributes.
3964         (read_attribute): Reflect API changes.
3965         (read_addr_index_1): Reflect API changes.  Update comments.
3966         (dwarf2_read_addr_index_data): Reflect API changes.
3967         (dwarf2_read_addr_index): Likewise.
3968         (read_str_index): Change API and implementation.  This becomes a helper
3969         to be used by the new string index related methods.  Update error
3970         message and comments.
3971         (read_dwo_str_index): New function definition.
3972         (read_stub_str_index): Likewise.
3973         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
3974         * symfile.h (dwarf2_debug_sections): Likewise.
3975         * xcoffread.c (dwarf2_debug_sections): Likewise.
3976
3977 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
3978
3979         * gdbcore.h (struct core_fns) <core_read_registers>: Change
3980         core_reg_sect type to gdb_byte *.
3981         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
3982         * cris-tdep.c (fetch_core_registers): Likewise.
3983         * corelow.c (core_target::get_core_register_section): Change
3984         type of `contents` to gdb::byte_vector.
3985
3986 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3987
3988         * tui/tui-wingeneral.c (box_win): Position the title in the center
3989         of the border.
3990
3991 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3992
3993         * corelow.c (core_target::get_core_register_section): Use
3994           std::vector instead of alloca.
3995
3996 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
3997
3998         * warning.m4: Add -Wmissing-declarations to build_warnings.
3999         * configure: Re-generate.
4000
4001 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4002
4003         * python/python.c (init__gdb_module): Add declaration.
4004
4005 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
4006
4007         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
4008         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
4009         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
4010         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
4011         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
4012         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
4013         * ada-exp.y (_initialize_ada_exp): Add declaration.
4014         * ada-lang.c (_initialize_ada_language): Add declaration.
4015         * ada-tasks.c (_initialize_tasks): Add declaration.
4016         * agent.c (_initialize_agent): Add declaration.
4017         * aix-thread.c (_initialize_aix_thread): Add declaration.
4018         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
4019         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
4020         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
4021         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
4022         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
4023         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
4024         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
4025         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
4026         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
4027         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
4028         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
4029         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
4030         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
4031         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
4032         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
4033         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
4034         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
4035         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
4036         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
4037         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
4038         * annotate.c (_initialize_annotate): Add declaration.
4039         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
4040         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
4041         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
4042         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
4043         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
4044         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
4045         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
4046         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
4047         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
4048         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
4049         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
4050         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
4051         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
4052         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
4053         * auto-load.c (_initialize_auto_load): Add declaration.
4054         * auxv.c (_initialize_auxv): Add declaration.
4055         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
4056         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
4057         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
4058         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
4059         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
4060         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
4061         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
4062         * breakpoint.c (_initialize_breakpoint): Add declaration.
4063         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
4064         * btrace.c (_initialize_btrace): Add declaration.
4065         * charset.c (_initialize_charset): Add declaration.
4066         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
4067         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
4068         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
4069         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
4070         * cli/cli-script.c (_initialize_cli_script): Add declaration.
4071         * cli/cli-style.c (_initialize_cli_style): Add declaration.
4072         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
4073         * coffread.c (_initialize_coffread): Add declaration.
4074         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
4075         * compile/compile.c (_initialize_compile): Add declaration.
4076         * complaints.c (_initialize_complaints): Add declaration.
4077         * completer.c (_initialize_completer): Add declaration.
4078         * copying.c (_initialize_copying): Add declaration.
4079         * corefile.c (_initialize_core): Add declaration.
4080         * corelow.c (_initialize_corelow): Add declaration.
4081         * cp-abi.c (_initialize_cp_abi): Add declaration.
4082         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
4083         * cp-support.c (_initialize_cp_support): Add declaration.
4084         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
4085         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
4086         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
4087         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
4088         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
4089         * ctfread.c (_initialize_ctfread): Add declaration.
4090         * d-lang.c (_initialize_d_language): Add declaration.
4091         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
4092         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
4093         * dbxread.c (_initialize_dbxread): Add declaration.
4094         * dcache.c (_initialize_dcache): Add declaration.
4095         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
4096         * disasm.c (_initialize_disasm): Add declaration.
4097         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
4098         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
4099         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
4100         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
4101         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
4102         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
4103         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
4104         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
4105         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
4106         * elfread.c (_initialize_elfread): Add declaration.
4107         * exec.c (_initialize_exec): Add declaration.
4108         * extension.c (_initialize_extension): Add declaration.
4109         * f-lang.c (_initialize_f_language): Add declaration.
4110         * f-valprint.c (_initialize_f_valprint): Add declaration.
4111         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
4112         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
4113         * filesystem.c (_initialize_filesystem): Add declaration.
4114         * findcmd.c (_initialize_mem_search): Add declaration.
4115         * findvar.c (_initialize_findvar): Add declaration.
4116         * fork-child.c (_initialize_fork_child): Add declaration.
4117         * frame-base.c (_initialize_frame_base): Add declaration.
4118         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
4119         * frame.c (_initialize_frame): Add declaration.
4120         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
4121         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
4122         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
4123         * gcore.c (_initialize_gcore): Add declaration.
4124         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
4125         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
4126         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
4127         * gdbarch.c (_initialize_gdbarch): Add declaration.
4128         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
4129         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
4130         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
4131         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
4132         * go-lang.c (_initialize_go_language): Add declaration.
4133         * go32-nat.c (_initialize_go32_nat): Add declaration.
4134         * guile/guile.c (_initialize_guile): Add declaration.
4135         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
4136         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
4137         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
4138         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
4139         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
4140         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
4141         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
4142         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
4143         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
4144         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
4145         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
4146         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
4147         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
4148         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
4149         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
4150         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
4151         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
4152         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
4153         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
4154         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
4155         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
4156         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
4157         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
4158         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
4159         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
4160         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
4161         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
4162         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
4163         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
4164         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
4165         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
4166         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
4167         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
4168         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
4169         * infcall.c (_initialize_infcall): Add declaration.
4170         * infcmd.c (_initialize_infcmd): Add declaration.
4171         * inflow.c (_initialize_inflow): Add declaration.
4172         * infrun.c (_initialize_infrun): Add declaration.
4173         * interps.c (_initialize_interpreter): Add declaration.
4174         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
4175         * jit.c (_initialize_jit): Add declaration.
4176         * language.c (_initialize_language): Add declaration.
4177         * linux-fork.c (_initialize_linux_fork): Add declaration.
4178         * linux-nat.c (_initialize_linux_nat): Add declaration.
4179         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
4180         * linux-thread-db.c (_initialize_thread_db): Add declaration.
4181         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
4182         * m2-lang.c (_initialize_m2_language): Add declaration.
4183         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
4184         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
4185         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
4186         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
4187         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
4188         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
4189         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
4190         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
4191         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
4192         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
4193         * machoread.c (_initialize_machoread): Add declaration.
4194         * macrocmd.c (_initialize_macrocmd): Add declaration.
4195         * macroscope.c (_initialize_macroscope): Add declaration.
4196         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
4197         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
4198         * maint.c (_initialize_maint_cmds): Add declaration.
4199         * mdebugread.c (_initialize_mdebugread): Add declaration.
4200         * memattr.c (_initialize_mem): Add declaration.
4201         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
4202         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
4203         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
4204         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
4205         * mi/mi-main.c (_initialize_mi_main): Add declaration.
4206         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
4207         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
4208         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
4209         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
4210         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
4211         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
4212         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
4213         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
4214         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
4215         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
4216         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
4217         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
4218         * mipsread.c (_initialize_mipsread): Add declaration.
4219         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
4220         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
4221         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
4222         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
4223         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
4224         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
4225         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
4226         * nto-procfs.c (_initialize_procfs): Add declaration.
4227         * objc-lang.c (_initialize_objc_language): Add declaration.
4228         * observable.c (_initialize_observer): Add declaration.
4229         * opencl-lang.c (_initialize_opencl_language): Add declaration.
4230         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
4231         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
4232         * osabi.c (_initialize_gdb_osabi): Add declaration.
4233         * osdata.c (_initialize_osdata): Add declaration.
4234         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
4235         * parse.c (_initialize_parse): Add declaration.
4236         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
4237         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
4238         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
4239         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
4240         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
4241         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
4242         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
4243         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
4244         * printcmd.c (_initialize_printcmd): Add declaration.
4245         * probe.c (_initialize_probe): Add declaration.
4246         * proc-api.c (_initialize_proc_api): Add declaration.
4247         * proc-events.c (_initialize_proc_events): Add declaration.
4248         * proc-service.c (_initialize_proc_service): Add declaration.
4249         * procfs.c (_initialize_procfs): Add declaration.
4250         * producer.c (_initialize_producer): Add declaration.
4251         * psymtab.c (_initialize_psymtab): Add declaration.
4252         * python/python.c (_initialize_python): Add declaration.
4253         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
4254         * record-btrace.c (_initialize_record_btrace): Add declaration.
4255         * record-full.c (_initialize_record_full): Add declaration.
4256         * record.c (_initialize_record): Add declaration.
4257         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
4258         * regcache.c (_initialize_regcache): Add declaration.
4259         * reggroups.c (_initialize_reggroup): Add declaration.
4260         * remote-notif.c (_initialize_notif): Add declaration.
4261         * remote-sim.c (_initialize_remote_sim): Add declaration.
4262         * remote.c (_initialize_remote): Add declaration.
4263         * reverse.c (_initialize_reverse): Add declaration.
4264         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
4265         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
4266         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
4267         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
4268         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
4269         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
4270         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
4271         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
4272         Add declaration.
4273         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
4274         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
4275         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
4276         * rust-exp.y (_initialize_rust_exp): Add declaration.
4277         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
4278         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
4279         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
4280         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
4281         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
4282         * score-tdep.c (_initialize_score_tdep): Add declaration.
4283         * ser-go32.c (_initialize_ser_dos): Add declaration.
4284         * ser-mingw.c (_initialize_ser_windows): Add declaration.
4285         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
4286         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
4287         * ser-uds.c (_initialize_ser_socket): Add declaration.
4288         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
4289         * serial.c (_initialize_serial): Add declaration.
4290         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
4291         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
4292         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
4293         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
4294         * skip.c (_initialize_step_skip): Add declaration.
4295         * sol-thread.c (_initialize_sol_thread): Add declaration.
4296         * solib-aix.c (_initialize_solib_aix): Add declaration.
4297         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
4298         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
4299         * solib-frv.c (_initialize_frv_solib): Add declaration.
4300         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
4301         * solib-target.c (_initialize_solib_target): Add declaration.
4302         * solib.c (_initialize_solib): Add declaration.
4303         * source-cache.c (_initialize_source_cache): Add declaration.
4304         * source.c (_initialize_source): Add declaration.
4305         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
4306         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
4307         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
4308         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
4309         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
4310         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
4311         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
4312         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
4313         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
4314         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
4315         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
4316         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
4317         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
4318         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
4319         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
4320         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
4321         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
4322         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
4323         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
4324         * stabsread.c (_initialize_stabsread): Add declaration.
4325         * stack.c (_initialize_stack): Add declaration.
4326         * stap-probe.c (_initialize_stap_probe): Add declaration.
4327         * std-regs.c (_initialize_frame_reg): Add declaration.
4328         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
4329         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
4330         * symfile.c (_initialize_symfile): Add declaration.
4331         * symmisc.c (_initialize_symmisc): Add declaration.
4332         * symtab.c (_initialize_symtab): Add declaration.
4333         * target.c (_initialize_target): Add declaration.
4334         * target-connection.c (_initialize_target_connection): Add
4335         declaration.
4336         * target-dcache.c (_initialize_target_dcache): Add declaration.
4337         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
4338         * thread.c (_initialize_thread): Add declaration.
4339         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
4340         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
4341         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
4342         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
4343         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
4344         * tracectf.c (_initialize_ctf): Add declaration.
4345         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
4346         * tracefile.c (_initialize_tracefile): Add declaration.
4347         * tracepoint.c (_initialize_tracepoint): Add declaration.
4348         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
4349         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
4350         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
4351         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
4352         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
4353         * tui/tui-win.c (_initialize_tui_win): Add declaration.
4354         * tui/tui.c (_initialize_tui): Add declaration.
4355         * typeprint.c (_initialize_typeprint): Add declaration.
4356         * ui-style.c (_initialize_ui_style): Add declaration.
4357         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
4358         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
4359         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
4360         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
4361         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
4362         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
4363         * unittests/filtered_iterator-selftests.c
4364         (_initialize_filtered_iterator_selftests): Add declaration.
4365         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
4366         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
4367         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
4368         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
4369         * unittests/main-thread-selftests.c
4370         (_initialize_main_thread_selftests): Add declaration.
4371         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
4372         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
4373         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
4374         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
4375         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
4376         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
4377         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
4378         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
4379         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
4380         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
4381         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
4382         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
4383         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
4384         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
4385         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
4386         declaration.
4387         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
4388         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
4389         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
4390         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
4391         * user-regs.c (_initialize_user_regs): Add declaration.
4392         * utils.c (_initialize_utils): Add declaration.
4393         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
4394         * valops.c (_initialize_valops): Add declaration.
4395         * valprint.c (_initialize_valprint): Add declaration.
4396         * value.c (_initialize_values): Add declaration.
4397         * varobj.c (_initialize_varobj): Add declaration.
4398         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
4399         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
4400         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
4401         * windows-nat.c (_initialize_windows_nat): Add declaration.
4402         (_initialize_check_for_gdb_ini): Add declaration.
4403         (_initialize_loadable): Add declaration.
4404         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
4405         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
4406         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
4407         * xcoffread.c (_initialize_xcoffread): Add declaration.
4408         * xml-support.c (_initialize_xml_support): Add declaration.
4409         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
4410         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
4411         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
4412         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
4413
4414 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
4415
4416         * regformats/regdat.sh: Generate declaration for init function.
4417
4418 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
4419
4420         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
4421         up.
4422         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
4423         close_one_inferior>: New methods.
4424         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
4425         pass down target to find_inferior_pid.
4426         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
4427         Pass down target to find_inferior_ptid.
4428         (gdbsim_target::create_inferior): Pass down target to
4429         add_thread_silent.
4430         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
4431         target down to find_inferior_ptid and switch_to_thread.
4432         (gdbsim_target::close): Update to call close_one_inferior.
4433         (struct resume_data): Remove.
4434         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
4435         directly, rather than through a void pointer.
4436         (gdbsim_target::resume): Update to call resume_one_inferior.
4437
4438 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
4439
4440         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
4441
4442 2020-01-12  Pedro Alves  <palves@redhat.com>
4443
4444         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
4445         directly for the current inferior instead of
4446         discard_all_inferiors.
4447         (discard_all_inferiors): Delete.
4448
4449 2020-01-11  Tom Tromey  <tom@tromey.com>
4450
4451         * tui/tui-wingeneral.c (box_win): Check cli_styling.
4452         * tui/tui-winsource.c (tui_source_window_base::refill): Use
4453         deprecated_safe_get_selected_frame.
4454
4455 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4456
4457         * inferior.c (print_inferior): Switch inferior before printing it.
4458
4459 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
4460             Pedro Alves  <palves@redhat.com>
4461
4462         * progspace-and-thread.c (switch_to_program_space_and_thread):
4463         Assert there's an inferior for PSPACE.  Use
4464         switch_to_inferior_no_thread to switch the inferior too.
4465         * progspace.c (program_space::~program_space): Call
4466         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
4467         (program_space::free_all_objfiles): Don't call clear_symtab_users
4468         here.
4469         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
4470
4471 2020-01-10  Pedro Alves  <palves@redhat.com>
4472
4473         * NEWS: Mention multi-target debugging, "info connections", and
4474         "add-inferior -no-connection".
4475
4476 2020-01-10  Pedro Alves  <palves@redhat.com>
4477
4478         * infrun.c: Include "target-connection.h".
4479         (check_multi_target_resumption): New.
4480         (proceed): Call it.
4481         * target-connection.c (make_target_connection_string): Make
4482         extern.
4483         * target-connection.h (make_target_connection_string): Declare.
4484
4485 2020-01-10  Pedro Alves  <palves@redhat.com>
4486
4487         * Makefile.in (COMMON_SFILES): Add target-connection.c.
4488         * inferior.c (uiout_field_connection): New function.
4489         (print_inferior): Add new "connection-id" column.
4490         (add_inferior_command): Show connection number/string of added
4491         inferior.
4492         * process-stratum-target.h
4493         (process_stratum_target::connection_string): New virtual method.
4494         (process_stratum_target::connection_number): New field.
4495         * remote.c (remote_target::connection_string): New override.
4496         * target-connection.c: New file.
4497         * target-connection.h: New file.
4498         * target.c (decref_target): Remove process_stratum targets from
4499         the connection list.
4500         (target_stack::push): Add process_stratum targets to the
4501         connection list.
4502
4503 2020-01-10  Pedro Alves  <palves@redhat.com>
4504
4505         Revert:
4506         2016-04-12  Pedro Alves  <palves@redhat.com>
4507         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
4508         Remove references to name.
4509         * serial.h (struct serial) <name>: Delete.
4510
4511 2020-01-10  Pedro Alves  <palves@redhat.com>
4512
4513         * gdbarch-selftests.c (register_to_value_test): Remove "target
4514         already pushed" check.
4515
4516 2020-01-10  Pedro Alves  <palves@redhat.com>
4517             John Baldwin  <jhb@FreeBSD.org>
4518
4519         * aarch64-linux-nat.c
4520         (aarch64_linux_nat_target::thread_architecture): Adjust.
4521         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
4522         (task_command_1): Likewise.
4523         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
4524         (aix_thread_target::wait, aix_thread_target::fetch_registers)
4525         (aix_thread_target::store_registers)
4526         (aix_thread_target::thread_alive): Adjust.
4527         * amd64-fbsd-tdep.c: Include "inferior.h".
4528         (amd64fbsd_get_thread_local_address): Pass down target.
4529         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
4530         thread's gdbarch instead of target_gdbarch.
4531         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
4532         get_last_target_status.
4533         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
4534         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
4535         inferiors.
4536         (update_inserted_breakpoint_locations): Skip if inferiors with no
4537         execution.
4538         (update_global_location_list): When handling moribund locations,
4539         find representative inferior for location's pspace, and use thread
4540         count of its process_stratum target.
4541         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
4542         * bsd-uthread.c (bsd_uthread_target::wait): Use
4543         as_process_stratum_target and adjust thread_change_ptid and
4544         add_thread calls.
4545         (bsd_uthread_target::update_thread_list): Use
4546         as_process_stratum_target and adjust find_thread_ptid,
4547         thread_change_ptid and add_thread calls.
4548         * btrace.c (maint_btrace_packet_history_cmd): Adjust
4549         find_thread_ptid call.
4550         * corelow.c (add_to_thread_list): Adjust add_thread call.
4551         (core_target_open): Adjust add_thread_silent and thread_count
4552         calls.
4553         (core_target::pid_to_str): Adjust find_inferior_ptid call.
4554         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
4555         * event-top.c (async_disconnect): Pop targets from all inferiors.
4556         * exec.c (add_target_sections): Push exec target on all inferiors
4557         sharing the program space.
4558         (remove_target_sections): Remove the exec target from all
4559         inferiors sharing the program space.
4560         (exec_on_vfork): New.
4561         * exec.h (exec_on_vfork): Declare.
4562         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
4563         Pass it down.
4564         (fbsd_nat_target::update_thread_list): Adjust.
4565         (fbsd_nat_target::resume): Adjust.
4566         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
4567         down.
4568         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
4569         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
4570         get_thread_arch_regcache call.
4571         * fork-child.c (gdb_startup_inferior): Pass target down to
4572         startup_inferior and set_executing.
4573         * gdbthread.h (struct process_stratum_target): Forward declare.
4574         (add_thread, add_thread_silent, add_thread_with_info)
4575         (in_thread_list): Add process_stratum_target parameter.
4576         (find_thread_ptid(inferior*, ptid_t)): New overload.
4577         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
4578         parameter.
4579         (all_threads()): Delete overload.
4580         (all_threads, all_non_exited_threads): Add process_stratum_target
4581         parameter.
4582         (all_threads_safe): Use brace initialization.
4583         (thread_count): Add process_stratum_target parameter.
4584         (set_resumed, set_running, set_stop_requested, set_executing)
4585         (threads_are_executing, finish_thread_state): Add
4586         process_stratum_target parameter.
4587         (switch_to_thread): Use is_current_thread.
4588         * i386-fbsd-tdep.c: Include "inferior.h".
4589         (i386fbsd_get_thread_local_address): Pass down target.
4590         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
4591         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
4592         have_inferiors check.
4593         * inf-ptrace.c (inf_ptrace_target::create_inferior)
4594         (inf_ptrace_target::attach): Adjust.
4595         * infcall.c (run_inferior_call): Adjust.
4596         * infcmd.c (run_command_1): Pass target to
4597         scoped_finish_thread_state.
4598         (proceed_thread_callback): Skip inferiors with no execution.
4599         (continue_command): Rename 'all_threads' local to avoid hiding
4600         'all_threads' function.  Adjust get_last_target_status call.
4601         (prepare_one_step): Adjust set_running call.
4602         (signal_command): Use user_visible_resume_target.  Compare thread
4603         pointers instead of inferior_ptid.
4604         (info_program_command): Adjust to pass down target.
4605         (attach_command): Mark target's 'thread_executing' flag.
4606         (stop_current_target_threads_ns): New, factored out from ...
4607         (interrupt_target_1): ... this.  Switch inferior before making
4608         target calls.
4609         * inferior-iter.h
4610         (struct all_inferiors_iterator, struct all_inferiors_range)
4611         (struct all_inferiors_safe_range)
4612         (struct all_non_exited_inferiors_range): Filter on
4613         process_stratum_target too.  Remove explicit.
4614         * inferior.c (inferior::inferior): Push dummy target on target
4615         stack.
4616         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
4617         Add process_stratum_target parameter, and pass it down.
4618         (have_live_inferiors): Adjust.
4619         (switch_to_inferior_and_push_target): New.
4620         (add_inferior_command, clone_inferior_command): Handle
4621         "-no-connection" parameter.  Use
4622         switch_to_inferior_and_push_target.
4623         (_initialize_inferior): Mention "-no-connection" option in
4624         the help of "add-inferior" and "clone-inferior" commands.
4625         * inferior.h: Include "process-stratum-target.h".
4626         (interrupt_target_1): Use bool.
4627         (struct inferior) <push_target, unpush_target, target_is_pushed,
4628         find_target_beneath, top_target, process_target, target_at,
4629         m_stack>: New.
4630         (discard_all_inferiors): Delete.
4631         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
4632         (all_inferiors, all_non_exited_inferiors): Add
4633         process_stratum_target parameter.
4634         * infrun.c: Include "gdb_select.h" and <unordered_map>.
4635         (target_last_proc_target): New global.
4636         (follow_fork_inferior): Push target on new inferior.  Pass target
4637         to add_thread_silent.  Call exec_on_vfork.  Handle target's
4638         reference count.
4639         (follow_fork): Adjust get_last_target_status call.  Also consider
4640         target.
4641         (follow_exec): Push target on new inferior.
4642         (struct execution_control_state) <target>: New field.
4643         (user_visible_resume_target): New.
4644         (do_target_resume): Call target_async.
4645         (resume_1): Set target's threads_executing flag.  Consider resume
4646         target.
4647         (commit_resume_all_targets): New.
4648         (proceed): Also consider resume target.  Skip threads of inferiors
4649         with no execution.  Commit resumtion in all targets.
4650         (start_remote): Pass current inferior to wait_for_inferior.
4651         (infrun_thread_stop_requested): Consider target as well.  Pass
4652         thread_info pointer to clear_inline_frame_state instead of ptid.
4653         (infrun_thread_thread_exit): Consider target as well.
4654         (random_pending_event_thread): New inferior parameter.  Use it.
4655         (do_target_wait): Rename to ...
4656         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
4657         down.
4658         (threads_are_resumed_pending_p, do_target_wait): New.
4659         (prepare_for_detach): Adjust calls.
4660         (wait_for_inferior): New inferior parameter.  Handle it.  Use
4661         do_target_wait_1 instead of do_target_wait.
4662         (fetch_inferior_event): Adjust.  Switch to representative
4663         inferior.  Pass target down.
4664         (set_last_target_status): Add process_stratum_target parameter.
4665         Save target in global.
4666         (get_last_target_status): Add process_stratum_target parameter and
4667         handle it.
4668         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
4669         (context_switch): Check inferior_ptid == null_ptid before calling
4670         inferior_thread().
4671         (get_inferior_stop_soon): Pass down target.
4672         (wait_one): Rename to ...
4673         (poll_one_curr_target): ... this.
4674         (struct wait_one_event): New.
4675         (wait_one): New.
4676         (stop_all_threads): Adjust.
4677         (handle_no_resumed, handle_inferior_event): Adjust to consider the
4678         event's target.
4679         (switch_back_to_stepped_thread): Also consider target.
4680         (print_stop_event): Update.
4681         (normal_stop): Update.  Also consider the resume target.
4682         * infrun.h (wait_for_inferior): Remove declaration.
4683         (user_visible_resume_target): New declaration.
4684         (get_last_target_status, set_last_target_status): New
4685         process_stratum_target parameter.
4686         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
4687         process_stratum_target parameter, and use it.
4688         (clear_inline_frame_state (thread_info*)): New.
4689         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
4690         process_stratum_target parameter.
4691         (clear_inline_frame_state (thread_info*)): Declare.
4692         * linux-fork.c (delete_checkpoint_command): Pass target down to
4693         find_thread_ptid.
4694         (checkpoint_command): Adjust.
4695         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
4696         instead of just tweaking inferior_ptid.
4697         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
4698         (exit_lwp): Pass target down to find_thread_ptid.
4699         (attach_proc_task_lwp_callback): Pass target down to
4700         add_thread/set_running/set_executing.
4701         (linux_nat_target::attach): Pass target down to
4702         thread_change_ptid.
4703         (get_detach_signal): Pass target down to find_thread_ptid.
4704         Consider last target status's target.
4705         (linux_resume_one_lwp_throw, resume_lwp)
4706         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
4707         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
4708         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
4709         (linux_nat_target::async_wait_fd): New.
4710         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
4711         target down.
4712         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
4713         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
4714         * linux-thread-db.c (struct thread_db_info::process_target): New
4715         field.
4716         (add_thread_db_info): Save target.
4717         (get_thread_db_info): New process_stratum_target parameter.  Also
4718         match target.
4719         (delete_thread_db_info): New process_stratum_target parameter.
4720         Also match target.
4721         (thread_from_lwp): Adjust to pass down target.
4722         (thread_db_notice_clone): Pass down target.
4723         (check_thread_db_callback): Pass down target.
4724         (try_thread_db_load_1): Always push the thread_db target.
4725         (try_thread_db_load, record_thread): Pass target down.
4726         (thread_db_target::detach): Pass target down.  Always unpush the
4727         thread_db target.
4728         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
4729         target down.  Always unpush the thread_db target.
4730         (find_new_threads_callback, thread_db_find_new_threads_2)
4731         (thread_db_target::update_thread_list): Pass target down.
4732         (thread_db_target::pid_to_str): Pass current inferior down.
4733         (thread_db_target::get_thread_local_address): Pass target down.
4734         (thread_db_target::resume, maintenance_check_libthread_db): Pass
4735         target down.
4736         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
4737         * procfs.c (procfs_target::procfs_init_inferior): Declare.
4738         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
4739         (procfs_init_inferior): Rename to ...
4740         (procfs_target::procfs_init_inferior): ... this and adjust.
4741         (procfs_target::create_inferior, procfs_notice_thread)
4742         (procfs_do_thread_registers): Adjust.
4743         * ppc-fbsd-tdep.c: Include "inferior.h".
4744         (ppcfbsd_get_thread_local_address): Pass down target.
4745         * proc-service.c (ps_xfer_memory): Switch current inferior and
4746         program space as well.
4747         (get_ps_regcache): Pass target down.
4748         * process-stratum-target.c
4749         (process_stratum_target::thread_address_space)
4750         (process_stratum_target::thread_architecture): Pass target down.
4751         * process-stratum-target.h
4752         (process_stratum_target::threads_executing): New field.
4753         (as_process_stratum_target): New.
4754         * ravenscar-thread.c
4755         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
4756         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
4757         down.
4758         * record-btrace.c (record_btrace_target::info_record): Adjust.
4759         (record_btrace_target::record_method)
4760         (record_btrace_target::record_is_replaying)
4761         (record_btrace_target::fetch_registers)
4762         (get_thread_current_frame_id, record_btrace_target::resume)
4763         (record_btrace_target::wait, record_btrace_target::stop): Pass
4764         target down.
4765         * record-full.c (record_full_wait_1): Switch to event thread.
4766         Pass target down.
4767         * regcache.c (regcache::regcache)
4768         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
4769         process_stratum_target parameter and handle it.
4770         (current_thread_target): New global.
4771         (get_thread_regcache): Add process_stratum_target parameter and
4772         handle it.  Switch inferior before calling target method.
4773         (get_thread_regcache): Pass target down.
4774         (get_thread_regcache_for_ptid): Pass target down.
4775         (registers_changed_ptid): Add process_stratum_target parameter and
4776         handle it.
4777         (registers_changed_thread, registers_changed): Pass target down.
4778         (test_get_thread_arch_aspace_regcache): New.
4779         (current_regcache_test): Define a couple local test_target_ops
4780         instances and use them for testing.
4781         (readwrite_regcache): Pass process_stratum_target parameter.
4782         (cooked_read_test, cooked_write_test): Pass mock_target down.
4783         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
4784         (get_thread_arch_aspace_regcache): Add process_stratum_target
4785         parameter.
4786         (regcache::target): New method.
4787         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
4788         (regcache::registers_changed_ptid): Add process_stratum_target
4789         parameter.
4790         (regcache::m_target): New field.
4791         (registers_changed_ptid): Add process_stratum_target parameter.
4792         * remote.c (remote_state::supports_vCont_probed): New field.
4793         (remote_target::async_wait_fd): New method.
4794         (remote_unpush_and_throw): Add remote_target parameter.
4795         (get_current_remote_target): Adjust.
4796         (remote_target::remote_add_inferior): Push target.
4797         (remote_target::remote_add_thread)
4798         (remote_target::remote_notice_new_inferior)
4799         (get_remote_thread_info): Pass target down.
4800         (remote_target::update_thread_list): Skip threads of inferiors
4801         bound to other targets.  (remote_target::close): Don't discard
4802         inferiors.  (remote_target::add_current_inferior_and_thread)
4803         (remote_target::process_initial_stop_replies)
4804         (remote_target::start_remote)
4805         (remote_target::remote_serial_quit_handler): Pass down target.
4806         (remote_target::remote_unpush_target): New remote_target
4807         parameter.  Unpush the target from all inferiors.
4808         (remote_target::remote_unpush_and_throw): New remote_target
4809         parameter.  Pass it down.
4810         (remote_target::open_1): Check whether the current inferior has
4811         execution instead of checking whether any inferior is live.  Pass
4812         target down.
4813         (remote_target::remote_detach_1): Pass down target.  Use
4814         remote_unpush_target.
4815         (extended_remote_target::attach): Pass down target.
4816         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
4817         (remote_target::append_resumption): Pass down target.
4818         (remote_target::append_pending_thread_resumptions)
4819         (remote_target::remote_resume_with_hc, remote_target::resume)
4820         (remote_target::commit_resume): Pass down target.
4821         (remote_target::remote_stop_ns): Check supports_vCont_probed.
4822         (remote_target::interrupt_query)
4823         (remote_target::remove_new_fork_children)
4824         (remote_target::check_pending_events_prevent_wildcard_vcont)
4825         (remote_target::remote_parse_stop_reply)
4826         (remote_target::process_stop_reply): Pass down target.
4827         (first_remote_resumed_thread): New remote_target parameter.  Pass
4828         it down.
4829         (remote_target::wait_as): Pass down target.
4830         (unpush_and_perror): New remote_target parameter.  Pass it down.
4831         (remote_target::readchar, remote_target::remote_serial_write)
4832         (remote_target::getpkt_or_notif_sane_1)
4833         (remote_target::kill_new_fork_children, remote_target::kill): Pass
4834         down target.
4835         (remote_target::mourn_inferior): Pass down target.  Use
4836         remote_unpush_target.
4837         (remote_target::core_of_thread)
4838         (remote_target::remote_btrace_maybe_reopen): Pass down target.
4839         (remote_target::pid_to_exec_file)
4840         (remote_target::thread_handle_to_thread_info): Pass down target.
4841         (remote_target::async_wait_fd): New.
4842         * riscv-fbsd-tdep.c: Include "inferior.h".
4843         (riscv_fbsd_get_thread_local_address): Pass down target.
4844         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
4845         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
4846         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
4847         Adjust.
4848         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
4849         * solib-svr4.c (enable_break): Pass down target.
4850         * spu-multiarch.c (parse_spufs_run): Pass down target.
4851         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
4852         * target-delegates.c: Regenerate.
4853         * target.c (g_target_stack): Delete.
4854         (current_top_target): Return the current inferior's top target.
4855         (target_has_execution_1): Refer to the passed-in inferior's top
4856         target.
4857         (target_supports_terminal_ours): Check whether the initial
4858         inferior was already created.
4859         (decref_target): New.
4860         (target_stack::push): Incref/decref the target.
4861         (push_target, push_target, unpush_target): Adjust.
4862         (target_stack::unpush): Defref target.
4863         (target_is_pushed): Return bool.  Adjust to refer to the current
4864         inferior's target stack.
4865         (dispose_inferior): Delete, and inline parts ...
4866         (target_preopen): ... here.  Only dispose of the current inferior.
4867         (target_detach): Hold strong target reference while detaching.
4868         Pass target down.
4869         (target_thread_name): Add assertion.
4870         (target_resume): Pass down target.
4871         (target_ops::beneath, find_target_at): Adjust to refer to the
4872         current inferior's target stack.
4873         (get_dummy_target): New.
4874         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
4875         has a thread running.
4876         (initialize_targets): Rename to ...
4877         (_initialize_target): ... this.
4878         * target.h: Include "gdbsupport/refcounted-object.h".
4879         (struct target_ops): Inherit refcounted_object.
4880         (target_ops::shortname, target_ops::longname): Make const.
4881         (target_ops::async_wait_fd): New method.
4882         (decref_target): Declare.
4883         (struct target_ops_ref_policy): New.
4884         (target_ops_ref): New typedef.
4885         (get_dummy_target): Declare function.
4886         (target_is_pushed): Return bool.
4887         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
4888         (all_matching_threads_iterator::all_matching_threads_iterator):
4889         Handle filter target.
4890         * thread-iter.h (struct all_matching_threads_iterator, struct
4891         all_matching_threads_range, class all_non_exited_threads_range):
4892         Filter by target too.  Remove explicit.
4893         * thread.c (threads_executing): Delete.
4894         (inferior_thread): Pass down current inferior.
4895         (clear_thread_inferior_resources): Pass down thread pointer
4896         instead of ptid_t.
4897         (add_thread_silent, add_thread_with_info, add_thread): Add
4898         process_stratum_target parameter.  Use it for thread and inferior
4899         searches.
4900         (is_current_thread): New.
4901         (thread_info::deletable): Use it.
4902         (find_thread_ptid, thread_count, in_thread_list)
4903         (thread_change_ptid, set_resumed, set_running): New
4904         process_stratum_target parameter.  Pass it down.
4905         (set_executing): New process_stratum_target parameter.  Pass it
4906         down.  Adjust reference to 'threads_executing'.
4907         (threads_are_executing): New process_stratum_target parameter.
4908         Adjust reference to 'threads_executing'.
4909         (set_stop_requested, finish_thread_state): New
4910         process_stratum_target parameter.  Pass it down.
4911         (switch_to_thread): Also match inferior.
4912         (switch_to_thread): New process_stratum_target parameter.  Pass it
4913         down.
4914         (update_threads_executing): Reimplement.
4915         * top.c (quit_force): Pop targets from all inferior.
4916         (gdb_init): Don't call initialize_targets.
4917         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
4918         Declare.
4919         (windows_add_thread, windows_delete_thread): Adjust.
4920         (get_windows_debug_event): Rename to ...
4921         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
4922         * tracefile-tfile.c (tfile_target_open): Pass down target.
4923         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
4924         Forward declare.
4925         (switch_to_thread): Add process_stratum_target parameter.
4926         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
4927         parameter.  Use it.
4928         (mi_on_resume): Pass target down.
4929         * nat/fork-inferior.c (startup_inferior): Add
4930         process_stratum_target parameter.  Pass it down.
4931         * nat/fork-inferior.h (startup_inferior): Add
4932         process_stratum_target parameter.
4933         * python/py-threadevent.c (py_get_event_thread): Pass target down.
4934
4935 2020-01-10  Pedro Alves  <palves@redhat.com>
4936
4937         * remote.c (remote_target::start_remote): Don't set inferior_ptid
4938         directly.  Instead find the first thread in the thread list and
4939         use switch_to_thread.
4940
4941 2020-01-10  Pedro Alves  <palves@redhat.com>
4942
4943         * remote.c (remote_target::remote_add_inferior): Don't bind a
4944         process to the current inferior if the current inferior is already
4945         bound to a process.
4946
4947 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4948             Pedro Alves  <palves@redhat.com>
4949
4950         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
4951         If no process is specified, return null_ptid instead of
4952         inferior_ptid.
4953         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
4954         TARGET_WAITKIND_SIGNALLED with no pid.
4955
4956 2020-01-10  Pedro Alves  <palves@redhat.com>
4957
4958         * remote.c (first_remote_resumed_thread): New.
4959         (remote_target::wait_as): Use it as default event_ptid instead of
4960         inferior_ptid.
4961
4962 2020-01-10  Pedro Alves  <palves@redhat.com>
4963
4964         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
4965
4966 2020-01-10  Pedro Alves  <palves@redhat.com>
4967
4968         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
4969         not -1.
4970
4971 2020-01-10  Pedro Alves  <palves@redhat.com>
4972
4973         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
4974         ptid to get_last_target_status.
4975         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
4976         ptid to get_last_target_status.
4977         * infcmd.c (continue_command): Don't pass a target_waitstatus to
4978         get_last_target_status.
4979         (info_program_command): Don't pass a target_waitstatus to
4980         get_last_target_status.
4981         * infrun.c (init_wait_for_inferior): Use
4982         nullify_last_target_wait_ptid.
4983         (get_last_target_status): Handle nullptr arguments.
4984         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
4985         (print_stop_event): Don't pass a ptid to get_last_target_status.
4986         (normal_stop): Don't pass a ptid to get_last_target_status.
4987         * infrun.h (get_last_target_status, set_last_target_status): Move
4988         comments here and update.
4989         (nullify_last_target_wait_ptid): Declare.
4990         * linux-fork.c (fork_load_infrun_state): Remove local extern
4991         declaration of nullify_last_target_wait_ptid.
4992         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
4993         to get_last_target_status.
4994
4995 2020-01-10  Pedro Alves  <palves@redhat.com>
4996
4997         * gdbthread.h (scoped_restore_current_thread)
4998         <dont_restore, restore, m_dont_restore>: Declare.
4999         * thread.c (thread_alive): Add assertion.  Return bool.
5000         (switch_to_thread_if_alive): New.
5001         (prune_threads): Switch inferior/thread.
5002         (print_thread_info_1): Switch thread before calling target methods.
5003         (scoped_restore_current_thread::restore): New, factored out from
5004         ...
5005         (scoped_restore_current_thread::~scoped_restore_current_thread):
5006         ... this.
5007         (scoped_restore_current_thread::scoped_restore_current_thread):
5008         Add assertion.
5009         (thread_apply_all_command, thread_select): Use
5010         switch_to_thread_if_alive.
5011         * infrun.c (proceed, restart_threads, handle_signal_stop)
5012         (switch_back_to_stepped_thread): Switch current thread before
5013         calling target methods.
5014
5015 2020-01-10  Pedro Alves <palves@redhat.com>
5016
5017         * inferior.c (switch_to_inferior_no_thread): New function,
5018         factored out from ...
5019         (inferior_command): ... here.
5020         * inferior.h (switch_to_inferior_no_thread): Declare.
5021         * mi/mi-main.c (run_one_inferior): Use
5022         switch_to_inferior_no_thread.
5023
5024 2020-01-10  Pedro Alves  <palves@redhat.com>
5025
5026         * infcmd.c (kill_command): Remove dead code.
5027
5028 2020-01-10  Pedro Alves  <palves@redhat.com>
5029
5030         * remote.c (remote_target::mourn_inferior): No longer check
5031         whether the target is running.
5032
5033 2020-01-10  Pedro Alves  <palves@redhat.com>
5034
5035         * corelow.c (core_target::has_execution): Change parameter type to
5036         inferior pointer.
5037         * inferior.c (number_of_live_inferiors): Use
5038         inferior::has_execution instead of target_has_execution_1.
5039         * inferior.h (inferior::has_execution): New.
5040         * linux-thread-db.c (thread_db_target::update_thread_list): Use
5041         inferior::has_execution instead of target_has_execution_1.
5042         * process-stratum-target.c
5043         (process_stratum_target::has_execution): Change parameter type to
5044         inferior pointer.  Check the inferior's PID instead of
5045         inferior_ptid.
5046         * process-stratum-target.h
5047         (process_stratum_target::has_execution): Change parameter type to
5048         inferior pointer.
5049         * record-full.c (record_full_core_target::has_execution): Change
5050         parameter type to inferior pointer.
5051         * target.c (target_has_execution_1): Change parameter type to
5052         inferior pointer.
5053         (target_has_execution_current): Adjust.
5054         * target.h (target_ops::has_execution): Change parameter type to
5055         inferior pointer.
5056         (target_has_execution_1): Change parameter type to inferior
5057         pointer.  Change return type to bool.
5058         * tracefile.h (tracefile_target::has_execution): Change parameter
5059         type to inferior pointer.
5060
5061 2020-01-10  Pedro Alves  <palves@redhat.com>
5062
5063         * exceptions.c (print_flush): Remove current_top_target() check.
5064
5065 2020-01-10  Pedro Alves  <palves@redhat.com>
5066
5067         * remote.c (show_remote_exec_file): Show the current inferior's
5068         exec-file instead of the command variable's value.
5069
5070 2020-01-10  Pedro Alves  <palves@redhat.com>
5071
5072         * record-full.c (record_full_resume_ptid): New global.
5073         (record_full_target::resume): Set it.
5074         (record_full_wait_1): Use record_full_resume_ptid instead of
5075         inferior_ptid.
5076
5077 2020-01-10  Pedro Alves  <palves@redhat.com>
5078
5079         * gdbthread.h (scoped_restore_current_thread)
5080         <dont_restore, restore, m_dont_restore>: Declare.
5081         * thread.c (thread_alive): Add assertion.  Return bool.
5082         (switch_to_thread_if_alive): New.
5083         (prune_threads): Switch inferior/thread.
5084         (print_thread_info_1): Switch thread before calling target methods.
5085         (scoped_restore_current_thread::restore): New, factored out from
5086         ...
5087         (scoped_restore_current_thread::~scoped_restore_current_thread):
5088         ... this.
5089         (scoped_restore_current_thread::scoped_restore_current_thread):
5090         Add assertion.
5091         (thread_apply_all_command, thread_select): Use
5092         switch_to_thread_if_alive.
5093
5094 2020-01-10  George Barrett  <bob@bob131.so>
5095
5096         * stap-probe.c (stap_modify_semaphore): Don't check for null
5097         semaphores.
5098         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
5099         for null semaphores.
5100
5101 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5102
5103         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
5104         all source windows, and maintain horizontal scroll status while
5105         doing so.
5106
5107 2020-01-09  Tom Tromey  <tom@tromey.com>
5108
5109         PR tui/18932:
5110         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
5111         update_source_window, not print_source_lines.
5112
5113 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5114
5115         * tui/tui.c (tui_enable): Register tui hooks after calling
5116         tui_display_main.
5117
5118 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
5119
5120         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
5121
5122 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
5123
5124         * thread.c (print_thread_info_1): Fix indentation.
5125
5126 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
5127
5128         * symtab.c (general_symbol_info::compute_and_set_names): Move the
5129         unique_xmalloc_ptr outside the if to always free the demangled name.
5130
5131 2020-01-08  Tom Tromey  <tromey@adacore.com>
5132
5133         * xcoffread.c (enter_line_range, read_xcoff_symtab)
5134         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
5135         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
5136         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
5137         Remove.
5138         (section_offsets): New typedef.
5139         * symtab.c (fixup_section, get_msymbol_address): Update.
5140         * symmisc.c (dump_msymbols): Update.
5141         * symfile.h (relative_addr_info_to_section_offsets)
5142         (symfile_map_offsets_to_segments): Update.
5143         * symfile.c (build_section_addr_info_from_objfile)
5144         (init_objfile_sect_indices): Update.
5145         (struct place_section_arg): Change type of "offsets".
5146         (place_section): Update.
5147         (relative_addr_info_to_section_offsets): Change type of
5148         "section_offsets".  Remove "num_sections" parameter.
5149         (default_symfile_offsets, syms_from_objfile_1)
5150         (set_objfile_default_section_offset): Update.
5151         (reread_symbols): No need to preserve section offsets by hand.
5152         (symfile_map_offsets_to_segments): Change type of "offsets".
5153         * stap-probe.c (relocate_address): Update.
5154         * stabsread.h (process_one_symbol): Update.
5155         * solib-target.c (struct lm_info_target) <offsets>: Change type.
5156         (solib_target_relocate_section_addresses): Update.
5157         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
5158         Update.
5159         * solib-frv.c (frv_relocate_main_executable): Update.
5160         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
5161         * solib-aix.c (solib_aix_get_section_offsets): Change return
5162         type.
5163         (solib_aix_solib_create_inferior_hook): Update.
5164         * remote.c (remote_target::get_offsets): Update.
5165         * psymtab.c (find_pc_sect_psymtab): Update.
5166         * psympriv.h (struct partial_symbol) <address, text_low,
5167         text_high>: Update.
5168         * objfiles.h (obj_section_offset): Update.
5169         (struct objfile) <section_offsets>: Change type.
5170         <num_sections>: Remove.
5171         (objfile_relocate): Update.
5172         * objfiles.c (entry_point_address_query): Update
5173         (relocate_one_symbol): Change type of "section_offsets".
5174         (objfile_relocate1, objfile_relocate1): Change type of
5175         "new_offsets".
5176         (objfile_rebase1): Update.
5177         * mipsread.c (mipscoff_symfile_read): Update.
5178         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
5179         parameter.
5180         * mdebugread.c (parse_symbol): Change type of "section_offsets".
5181         (parse_external, psymtab_to_symtab_1): Update.
5182         * machoread.c (macho_symfile_offsets): Update.
5183         * ia64-tdep.c (ia64_find_unwind_table): Update.
5184         * hppa-tdep.c (read_unwind_info): Update.
5185         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
5186         * dwarf2read.c (create_addrmap_from_index)
5187         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5188         (process_psymtab_comp_unit_reader, add_partial_symbol)
5189         (add_partial_subprogram, process_full_comp_unit)
5190         (read_file_scope, read_func_scope, read_lexical_block_scope)
5191         (read_call_site_scope, dwarf2_rnglists_process)
5192         (dwarf2_ranges_process, dwarf2_ranges_read)
5193         (dwarf_decode_lines_1, var_decode_location, new_symbol)
5194         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
5195         Update.
5196         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
5197         Update.
5198         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
5199         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
5200         (process_one_symbol): Change type of "section_offsets".
5201         * ctfread.c (get_objfile_text_range): Update.
5202         * coffread.c (coff_symtab_read, enter_linenos)
5203         (process_coff_symbol): Update.
5204         * coff-pe-read.c (add_pe_forwarded_sym): Update.
5205         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
5206
5207 2020-01-08  Tom Tromey  <tromey@adacore.com>
5208
5209         * dwarf2read.c (parse_macro_definition): Use std::string.
5210         (parse_macro_definition): Likewise.
5211
5212 2020-01-08  Tom Tromey  <tromey@adacore.com>
5213
5214         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
5215         (ATTR_ALLOC_CHUNK): Remove.
5216
5217 2020-01-08  Tom Tromey  <tromey@adacore.com>
5218
5219         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
5220
5221 2020-01-08  Tom Tromey  <tromey@adacore.com>
5222
5223         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
5224         (dwarf2_compute_name, open_dwo_file): Likewise.
5225         (process_enumeration_scope): Use std::vector.
5226         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
5227         (partial_die_info::fixup, dwarf2_start_subfile)
5228         (guess_full_die_structure_name, dwarf2_name): Likewise.
5229         (determine_prefix): Update.
5230         (guess_full_die_structure_name): Make return type const.
5231         (partial_die_full_name): Return unique_xmalloc_ptr.
5232         (DW_FIELD_ALLOC_CHUNK): Remove.
5233
5234 2020-01-07  Tom Tromey  <tromey@adacore.com>
5235
5236         PR build/24937:
5237         * stap-probe.c (class stap_static_probe_ops): Add constructor.
5238
5239 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
5240
5241         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
5242
5243 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5244
5245         * stack.c (print_frame_info): Move disassemble_next_line code
5246         inside source_print block.
5247
5248 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5249
5250         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
5251         gdb/signals.h, as we are now using native signal symbols.
5252
5253 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
5254
5255         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
5256         overflow by an early check of content vs threshold.
5257         * tui/tui-source.c (tui_source_window::line_is_displayed):
5258         Likewise.
5259
5260 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5261
5262         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
5263
5264 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
5265
5266         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
5267         export table if no section contains it's RVA.
5268
5269 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5270
5271         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
5272
5273 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
5274
5275         * source.c (print_source_lines_base): Set last_line_listed.
5276
5277 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
5278
5279         * tui/tui-disasm.c: Remove trailing spaces.
5280
5281 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
5282             Pedro Alves  <palves@redhat.com>
5283
5284         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
5285         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
5286         (windows_gdb_signal_to_target): New function, uses the above
5287         enumeration to convert GDB internal signal codes to equivalent
5288         Windows codes.
5289         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
5290         * windows-nat.c: Include "gdb_wait.h".
5291         (get_windows_debug_event): Extract the fatal exception from the
5292         exit status and convert to the equivalent Posix signal number.
5293         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
5294         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
5295         * gdbsupport/gdb_wait.c: New file, implements
5296         windows_status_to_termsig.
5297         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
5298         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
5299
5300 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5301
5302         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
5303         show_layout.
5304
5305 2020-01-05  Luis Machado  <luis.machado@linaro.org>
5306
5307         * aarch64-linux-nat.c
5308         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
5309         and bfd_mach_aarch64.
5310
5311 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5312
5313         * ui-file.c (stdio_file::can_emit_style_escape)
5314         (tee_file::can_emit_style_escape): Ensure style is used also on
5315         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
5316         to gdb_stdout.
5317         * main.c (set_gdb_data_directory): Use file style to output the
5318         warning that the given pathname is not a directory.
5319         * top.c (show_history_filename, gdb_safe_append_history)
5320         (show_gdb_datadir): Use file style.
5321
5322 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
5323
5324         * solib-target.c (struct lm_info_target):
5325         Change offsets to be a unique_xmalloc_ptr.
5326         (solib_target_relocate_section_addresses): Update.
5327
5328 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
5329
5330         * windows-nat.c (windows_clear_solib): Free so_list linked list.
5331
5332 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5333
5334         * MAINTAINERS (Write After Approval): Add myself.
5335
5336 2020-01-02  Luis Machado  <luis.machado@linaro.org>
5337
5338         * proc-service.c (get_ps_regcache): Remove reference to obsolete
5339         Cell BE architecture.
5340         * target.h (struct target_ops) <thread_architecture>: Likewise.
5341
5342 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
5343
5344         * Makefile.in: Use INSTALL_PROGRAM_ENV.
5345
5346 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
5347
5348         * MAINTAINERS (Write After Approval): Add myself.
5349
5350 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5351
5352         * gdbarch.sh: Update copyright year range of generated files.
5353
5354 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5355
5356         Update copyright year range in all GDB files.
5357
5358 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5359
5360         * copyright.py: Convert to Python 3.
5361
5362 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5363
5364         * copyright.py: Adapt after move of gnulib directory from gdb
5365         directory to toplevel directory.
5366
5367 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5368
5369         * copyright.py (main): Exit if run from the wrong directory.
5370
5371 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5372
5373         * top.c (print_gdb_version): Change copyright year to 2020.
5374
5375 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
5376
5377         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
5378
5379 For older changes see ChangeLog-2019.
5380 \f
5381 Local Variables:
5382 mode: change-log
5383 left-margin: 8
5384 fill-column: 74
5385 version-control: never
5386 coding: utf-8
5387 End: