gdb/ChangeLog

   1 2019-10-03  Tom de Vries  <tdevries@suse.de>
   2
   3         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
   4         the first line of the help text for set/show style metadata.
   5
   6 2019-10-02  Tom Tromey  <tromey@adacore.com>
   7
   8         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
   9         * gdbsupport/common-inferior.c: New file.
  10         * infcmd.c (startup_with_shell): Don't define.
  11         * nat/fork-inferior.h (startup_with_shell): Don't declare.
  12         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
  13         * inferior.h (startup_with_shell): Don't declare.
  14
  15 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
  16
  17         * gdbsupport/gdb_assert.h: Include errors.h.
  18         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
  19
  20 2019-10-02  Tom Tromey  <tromey@adacore.com>
  21
  22         * NEWS: Add $_ada_exception entry.
  23         * ada-lang.c (struct ada_catchpoint): Add constructor.
  24         <m_kind>: New member.
  25         (allocate_location_exception, re_set_exception): Remove
  26         "ex" parameter.
  27         (should_stop_exception): Compute $_ada_exception.
  28         (check_status_exception, print_it_exception)
  29         (print_one_exception, print_mention_exception): Remove
  30         "ex" parameter.
  31         (allocate_location_catch_exception, re_set_catch_exception)
  32         (check_status_exception, print_it_catch_exception)
  33         (print_one_catch_exception, print_mention_catch_exception)
  34         (print_recreate_catch_exception)
  35         (allocate_location_catch_exception_unhandled)
  36         (re_set_catch_exception_unhandled)
  37         (check_status_exception, print_it_catch_exception_unhandled)
  38         (print_one_catch_exception_unhandled)
  39         (print_mention_catch_exception_unhandled)
  40         (print_recreate_catch_exception_unhandled)
  41         (allocate_location_catch_assert, re_set_catch_assert)
  42         (check_status_assert, print_it_catch_assert)
  43         (print_one_catch_assert, print_mention_catch_assert)
  44         (print_recreate_catch_assert)
  45         (allocate_location_catch_handlers, re_set_catch_handlers)
  46         (check_status_handlers, print_it_catch_handlers)
  47         (print_one_catch_handlers, print_mention_catch_handlers)
  48         (print_recreate_catch_handlers): Remove.
  49         (create_ada_exception_catchpoint): Update.
  50         (initialize_ada_catchpoint_ops): Update.
  51
  52 2019-10-02  Tom Tromey  <tromey@adacore.com>
  53
  54         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
  55         (create_excep_cond_exprs): Simplify exception string computation.
  56         (ada_exception_catchpoint_cond_string): Likewise.
  57
  58 2019-10-02  Tom Tromey  <tromey@adacore.com>
  59
  60         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
  61         * ada-lang.c (lesseq_defined_than): Handle
  62         LOC_STATIC.
  63         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
  64         parameter.
  65         (dwarf2_has_info): Likewise.
  66         (new_symbol): Set maybe_copied on symbol when
  67         appropriate.
  68         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
  69         parameter.
  70         <can_copy>: New member.
  71         * elfread.c (record_minimal_symbol): Set maybe_copied
  72         on symbol when appropriate.
  73         (elf_symfile_read): Update call to dwarf2_has_info.
  74         * minsyms.c (lookup_minimal_symbol_linkage): New
  75         function.
  76         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
  77         * symtab.c (get_symbol_address, get_msymbol_address):
  78         New functions.
  79         * symtab.h (get_symbol_address, get_msymbol_address):
  80         Declare.
  81         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
  82         maybe_copied.
  83         (struct symbol, struct minimal_symbol) <maybe_copied>:
  84         New member.
  85
  86 2019-10-02  Tom Tromey  <tromey@adacore.com>
  87
  88         * source.c (struct current_source_location): New.
  89         (current_source_key): New global.
  90         (current_source_symtab, current_source_line)
  91         (current_source_pspace): Remove.
  92         (get_source_location): New function.
  93         (get_current_source_symtab_and_line)
  94         (set_default_source_symtab_and_line)
  95         (set_current_source_symtab_and_line)
  96         (clear_current_source_symtab_and_line, select_source_symtab)
  97         (info_source_command, print_source_lines_base)
  98         (info_line_command, search_command_helper, _initialize_source):
  99         Update.
 100
 101 2019-10-02  Tom Tromey  <tromey@adacore.com>
 102
 103         * source.c (select_source_symtab): Don't call
 104         decode_line_with_current_source.
 105
 106 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 107
 108         * symtab.c (lookup_global_symbol): Search global block.
 109
 110 2019-10-02  Tom Tromey  <tromey@adacore.com>
 111
 112         * coffread.c (process_coff_symbol): Update.
 113         * dwarf2read.c (var_decode_location, new_symbol): Update.
 114         * mdebugread.c (parse_symbol): Update.
 115         * objfiles.c (relocate_one_symbol): Update.
 116         * stabsread.c (define_symbol, fix_common_block)
 117         (scan_file_globals): Update.
 118         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 119         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 120         * xcoffread.c (process_xcoff_symbol): Update.
 121
 122 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 123
 124         * MAINTAINERS: Update my email address.
 125
 126 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 127
 128         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 129         std::vector.
 130         (build_type_psymtabs_reader): Update for std::vector.
 131         (build_type_psymtab_dependencies): Likewise.
 132         * dwarf2read.h: Remove use of DEF_VEC_P.
 133         (typedef sig_type_ptr): Delete.
 134
 135 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 136
 137         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 138         to std::vector.
 139         (btrace_maint_decode_pt): Likewise, and move allocation of the
 140         vector outside of the loop.
 141         (btrace_maint_update_packets): Update to handle change from VEC to
 142         std::vector.
 143         (btrace_maint_print_packets): Likewise.
 144         (maint_info_btrace_cmd): Likewise.
 145         * btrace.h: Remove use of DEF_VEC_O.
 146         (typedef btrace_pt_packet_s): Delete.
 147         (struct btrace_maint_info) <packets>: Change fromm VEC to
 148         std::vector.
 149         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 150
 151 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 152
 153         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 154         make accesses into the vector constant references.
 155         (btrace_add_pc): Update for std::vector.
 156         (btrace_stitch_bts): Likewise.
 157         (parse_xml_btrace_block): Likewise.
 158         (btrace_maint_update_packets): Likewise.
 159         (btrace_maint_print_packets): Likewise.
 160         (maint_info_btrace_cmd): Likewise.
 161         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 162         std::vector.
 163         (btrace_data::empty): Likewise.
 164         (btrace_data_append): Likewise.
 165         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 166         (typedef btrace_block_s): Delete.
 167         (struct btrace_block): Add constructor.
 168         (struct btrace_data_bts) <blocks>: Change to std::vector.
 169         * nat/linux-btrace.c (perf_event_read_bts): Update for
 170         std::vector.
 171         (linux_read_bts): Likewise.
 172
 173 2019-10-01  Tom Tromey  <tom@tromey.com>
 174
 175         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 176
 177 2019-10-01  Tom Tromey  <tom@tromey.com>
 178
 179         * stack.c (print_frame, info_frame_command_core): Use
 180         styled_string.
 181         * linux-thread-db.c (try_thread_db_load_1)
 182         (try_thread_db_load_from_pdir_1): Use styled_string.
 183         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 184         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 185         (maybe_print_unsupported_script_warning)
 186         (maybe_print_script_not_found_warning): Use styled_string.
 187         * ada-lang.c (user_select_syms): Use styled_string.
 188
 189 2019-10-01  Tom Tromey  <tom@tromey.com>
 190
 191         * p-lang.c (pascal_printstr): Use metadata style.
 192         * value.c (show_convenience): Use metadata style.
 193         * valprint.c (valprint_check_validity, val_print_optimized_out)
 194         (val_print_not_saved, val_print_unavailable)
 195         (val_print_invalid_address, generic_val_print, val_print)
 196         (value_check_printable, val_print_array_elements): Use metadata
 197         style.
 198         * ui-out.h (class ui_out) <field_fmt>: New overload.
 199         <do_field_fmt>: Add style parameter.
 200         * ui-out.c (ui_out::field_fmt): New overload.
 201         * typeprint.c (type_print_unknown_return_type)
 202         (val_print_not_allocated, val_print_not_associated): Use metadata
 203         style.
 204         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 205         parameter.
 206         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 207         * tracepoint.c (tvariables_info_1): Use metadata style.
 208         * stack.c (print_frame_arg, print_frame_info, print_frame)
 209         (info_frame_command_core): Use metadata style.
 210         * skip.c (info_skip_command): Use metadata style.
 211         * rust-lang.c (rust_print_enum): Use metadata style.
 212         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 213         metadata style.
 214         * python/py-framefilter.c (py_print_single_arg): Use metadata
 215         style.
 216         * printcmd.c (do_one_display, print_variable_and_value): Use
 217         metadata style.
 218         * p-valprint.c (pascal_val_print)
 219         (pascal_object_print_value_fields): Use metadata style.
 220         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 221         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 222         parameter.
 223         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 224         * m2-valprint.c (m2_print_long_set): Use metadata style.
 225         * m2-typeprint.c (m2_print_type): Use metadata style.
 226         * infcmd.c (print_return_value_1): Use metadata style.
 227         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 228         * f-valprint.c (info_common_command_for_block): Use metadata
 229         style.
 230         * f-typeprint.c (f_type_print_base): Use metadata style.
 231         * expprint.c (print_subexp_standard): Use metadata style.
 232         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 233         * cli/cli-style.h (class cli_style_option): Add constructor.
 234         (metadata_style): Declare.
 235         * cli/cli-style.c (metadata_style): New global.
 236         (_initialize_cli_style): Register metadata style.
 237         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 238         parameter.
 239         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 240         * c-typeprint.c (c_type_print_base_struct_union)
 241         (c_type_print_base_1): Use metadata style.
 242         * breakpoint.c (watchpoint_value_print)
 243         (print_one_breakpoint_location): Use metadata style.
 244         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 245         style.
 246         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 247         style.
 248         * ada-valprint.c (val_print_packed_array_elements, printstr)
 249         (print_field_values, ada_val_print_ref, ada_val_print): Use
 250         metadata style.
 251         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 252         style.
 253         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 254         style.
 255         * ada-lang.c (user_select_syms): Use metadata style.
 256
 257 2019-10-01  Tom Tromey  <tom@tromey.com>
 258
 259         * cli/cli-cmds.c (pwd_command): Style output.
 260
 261 2019-10-01  Pedro Alves  <palves@redhat.com>
 262             Tom Tromey  <tom@tromey.com>
 263
 264         * symtab.c (print_symbol_info): Use %ps.
 265         (print_msymbol_info): Use %ps.
 266         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 267         * printcmd.c (print_variable_and_value): Use %ps.
 268         * macrocmd.c (show_pp_source_pos): Use %ps.
 269         * infrun.c (print_exited_reason): Use ui_out::message.
 270         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 271         (describe_other_breakpoints): Use ui_out::message and new
 272         formats.
 273         (say_where): Use new formats.
 274         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 275         and new formats.
 276
 277 2019-10-01  Pedro Alves  <palves@redhat.com>
 278             Tom Tromey  <tom@tromey.com>
 279
 280         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 281         (test_gdb_formats): New function.
 282         (run_tests): Call it.
 283         (test_format_specifier): Update.
 284         * utils.h (fputs_filtered): Update comment.
 285         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 286         (fputs_styled_unfiltered): Declare.
 287         * utils.c (fputs_styled_unfiltered): New function.
 288         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 289         (vfprintf_filtered): Update.
 290         (vfprintf_unfiltered, vprintf_filtered): Update.
 291         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 292         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 293         disallow_ui_out_field>: New constants.
 294         (enum class field_kind): New.
 295         (struct base_field_s, struct signed_field_s): New.
 296         (signed_field): New function.
 297         (struct string_field_s): New.
 298         (string_field): New function.
 299         (struct styled_string_s): New.
 300         (styled_string): New function.
 301         (class ui_out) <message>: Add comment.
 302         <vmessage, call_do_message>: New methods.
 303         <do_message>: Add style parameter.
 304         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 305         methods.
 306         (ui_out::message): Rewrite.
 307         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 308         parameter.
 309         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 310         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 311         gdb_extensions parameter.
 312         (class format_piece): Add parameter to constructor.
 313         (n_int_args): New field.
 314         * gdbsupport/format.c (format_pieces::format_pieces): Add
 315         gdb_extensions parameter.  Handle '*'.
 316         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 317         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 318         vfprintf_styled_no_gdbfmt.
 319         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 320         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 321         unfiltered output.
 322         * ui-style.h (struct ui_file_style) <ptr>: New method.
 323
 324 2019-10-01  Tom Tromey  <tom@tromey.com>
 325
 326         * unittests/format_pieces-selftests.c: Update.  Add final format.
 327         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 328         empty literal pieces.
 329
 330 2019-10-01  Tom Tromey  <tom@tromey.com>
 331
 332         * ui-out.h (enum class ui_out_style_kind): Remove.
 333         (class ui_out) <field_string, field_stsream, do_field_string>:
 334         Change type of "style".
 335         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 336         (ui_out::field_string): Update.
 337         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 338         of "style".
 339         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 340         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 341         * stack.c (print_frame_arg, print_frame_info, print_frame):
 342         Update.
 343         * source.c (print_source_lines_base): Update.
 344         * solib.c (info_sharedlibrary_command): Update.
 345         * skip.c (info_skip_command): Update.
 346         * record-btrace.c (btrace_call_history_src_line)
 347         (btrace_call_history): Update.
 348         * python/py-framefilter.c (py_print_frame): Update.
 349         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 350         "style".
 351         * mi/mi-out.c (mi_ui_out::do_table_header)
 352         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 353         (mi_ui_out::do_field_string): Update.
 354         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 355         Update.
 356         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 357         "style".
 358         * cli-out.c (cli_ui_out::do_table_header)
 359         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 360         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 361         (cli_ui_out::do_field_fmt): Update.
 362         * breakpoint.c (print_breakpoint_location): Update.
 363         (update_static_tracepoint): Update.
 364
 365 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 366
 367         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 368         conversion of gdb_datadir.
 369         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 370         remove not needed c_str ().
 371
 372 2019-09-30  Ali Tamur <tamur@google.com>
 373
 374         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 375         (dwarf2_string_attr): Likewise.
 376
 377 2019-09-30  Ali Tamur <tamur@google.com>
 378
 379         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 380         (process_full_type_unit): Likewise.
 381         (dump_die_shallow): Likewise.
 382         (cu_debug_loc_section): Likewise.
 383
 384 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 385
 386         * minsyms.c (compare_minimal_symbols): Rename to...
 387         (minimal_symbol_is_less_than): ...this, and adjust to STL
 388         conventions (return bool, take arguments as references)
 389         (minimal_symbol_reader::install): Call std::sort instead
 390         of qsort.
 391
 392 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 393
 394         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 395         hash and why.
 396         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 397         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 398
 399 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 400
 401         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 402         * psympriv.h (add_psymbol_to_list): Move comment here and update
 403         it.
 404
 405 2019-09-29  Tom de Vries  <tdevries@suse.de>
 406
 407         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 408         Use $tmpdir/$(basename "$output_file").dwz instead of
 409         "${output_file}.dwz".
 410
 411 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 412
 413         PR gdb/25045
 414         * hppa-linux-nat.c: Include gdbarch.h.
 415
 416 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 417
 418         * blockframe.c (find_pc_partial_function): Change return type to bool.
 419         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 420         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 421         (stub_gnu_ifunc_resolve_name): Likewise.
 422         * symtab.c (compare_filenames_for_search): Likewise.
 423         (compare_glob_filenames_for_search): Likewise.
 424         (matching_obj_sections): Likewise.
 425         (symbol_matches_domain): Likewise.
 426         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 427         (find_line_pc): Change return type to bool.
 428         (find_line_pc_range): Likewise.
 429         (producer_is_realview): Likewise.
 430         * symtab.h (symbol_matches_domain): Likewise.
 431         (find_pc_partial_function): Likewise.
 432         (find_pc_line_pc_range): Likewise.
 433         (in_gnu_ifunc_stub): Likewise.
 434         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 435         (find_line_pc): Likewise.
 436         (find_line_pc_range): Likewise.
 437         (matching_obj_sections): Likewise.
 438         (find_line_symtab): Change out parameter to bool.
 439         (producer_is_realview): Change return type to bool.
 440         (compare_filenames_for_search): Likewise.
 441         (compare_glob_filenames_for_search): Likewise.
 442
 443 2019-09-26  Tom Tromey  <tom@tromey.com>
 444
 445         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 446         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 447         * gdb_usleep.h: Remove.
 448         * gdb_usleep.c: Remove.
 449         * utils.c: Don't include gdb_usleep.h.
 450
 451 2019-09-26  Tom Tromey  <tromey@adacore.com>
 452
 453         * python/py-type.c (type_to_type_object): Call check_typedef
 454         for stub types.
 455
 456 2019-09-26  Tom Tromey  <tom@tromey.com>
 457
 458         * utils.h (initialize_utils): Don't declare.
 459         * top.c (gdb_init): Don't call initialize_utils.
 460         * utils.c (initialize_utils): Remove.  Move contents...
 461         (_initialize_utils): ... here.
 462
 463 2019-09-25  Tom Tromey  <tom@tromey.com>
 464
 465         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 466         * utils.h (make_hex_string): Don't declare.
 467         * utils.c (make_hex_string): Remove.
 468
 469 2019-09-24  Tom de Vries  <tdevries@suse.de>
 470
 471         PR gdb/23815
 472         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 473         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 474
 475 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 476
 477         * NEWS: Mention new simulator port for PRU.
 478
 479 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 480
 481         * ada-exp.y (write_object_remaining): Update.
 482         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 483         and eliminate the static buffer.
 484         (ada_decode_symbol): Update.
 485         (ada_la_decode): Update.
 486         (ada_sniff_from_mangled_name): Update.
 487         (is_valid_name_for_wild_match): Update.
 488         (ada_lookup_name_info::matches): Update and simplify.
 489         (name_matches_regex): Update.
 490         (ada_add_global_exceptions): Update.
 491         * ada-lang.h (ada_decode): Update signature.
 492         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 493         * dwarf-index-write.c (debug_names::insert): Update.
 494
 495 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 496
 497         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 498         formatting.
 499
 500 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 501
 502         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 503         Change "nonzero" to "true" in documentation.
 504
 505 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 506
 507         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 508         (_initialize_darwin_solib): Don't set
 509         darwin_so_ops.lookup_lib_global_symbol.
 510         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 511         set_gdbarch_iterate_over_objfiles_in_search_order.
 512         (elf_lookup_lib_symbol): Rename to...
 513         (svr4_iterate_over_objfiles_in_search_order): this, and update
 514         to iterate semantics.
 515         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 516         * solib.c (solib_global_lookup): Remove.
 517         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 518         (solib_global_lookup): Remove.
 519         * symtab.c (lookup_global_or_static_symbol): Remove call to
 520         solib_global_lookup.
 521
 522 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 523
 524         * NEWS: Move entries about default MI version now being
 525         version 3, and about the GDB/MI fix for multi-location
 526         breakpoints to the "since GDB 8.3" section.
 527
 528 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 529
 530         GDB 8.3.1 released.
 531
 532 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 533
 534         * NEWS: Mention that Cell/B.E. debugging support was removed.
 535         * MAINTAINERS: Remove spu target.
 536
 537         * config/djgpp/fnchange.lst: Remove entries for removed files.
 538
 539         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 540         spu-multiarch.o, and spu-tdep.o.
 541         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 542         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 543         spu-multiarch.c, and spu-tdep.c.
 544         * spu-linux-nat.c: Remove file.
 545         * spu-multiarch.c: Remove file.
 546         * spu-tdep.c: Remove file.
 547         * spu-tdep.h: Remove file.
 548         * solib-spu.c: Remove file.
 549         * solib-spu.h: Remove file.
 550
 551         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 552         * configure.nat (spu-linux): Remove.
 553         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 554         solib-multiarch.o from gdb_target_obs.
 555         (spu*-*-*): Remove.
 556
 557         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 558         feature flag.
 559         (ppc_linux_no_features): Update.
 560         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 561         Cell/B.E. support.
 562         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 563         (tdesc_powerpc_cell64l): Likewise.
 564         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 565         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 566         Cell/B.E. support.
 567         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 568         Do not include "features/rs6000/powerpc-cell32l.c" or
 569         "features/rs6000/powerpc-cell64l.c".
 570         (ppc_linux_spu_section): Remove.
 571         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 572         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 573         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 574         (ppc_linux_spe_context_lookup): Remove.
 575         (ppc_linux_spe_context_inferior_created): Remove.
 576         (ppc_linux_spe_context_solib_loaded): Remove.
 577         (ppc_linux_spe_context_solib_unloaded): Remove.
 578         (ppc_linux_spe_context): Remove.
 579         (struct ppu2spu_cache): Remove.
 580         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 581         (struct ppu2spu_data): Remove.
 582         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 583         ppu2spu_unwind): Remove.
 584         (ppc_linux_init_abi): Remove Cell/B.E. support.
 585         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 586
 587         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 588         (rs6000/powerpc-cell64l-expedite): Likewise
 589         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 590         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 591         rs6000/powerpc-cell64l.xml.
 592         * features/rs6000/powerpc-cell32l.xml: Remove.
 593         * features/rs6000/powerpc-cell64l.xml: Likewise.
 594         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 595         * features/rs6000/powerpc-cell64l.c: Likewise.
 596         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 597         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 598         * regformats/reg-spu.dat: Remove.
 599
 600         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 601         * corelow.c (struct spuid_list): Remove.
 602         (add_to_spuid_list): Remove.
 603         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 604         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 605         (remote_protocol_features): Remove associated entries.
 606         (_initialize_remote): No longer initialize them.
 607         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 608         * linux-nat.c (SPUFS_MAGIC): Remove.
 609         (linux_proc_xfer_spu): Remove.
 610         (spu_enumerate_spu_ids): Remove.
 611         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 612         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 613         (linux_make_corefile_notes): No longer call it.
 614
 615         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 616         (cooked_write_test): Likewise.
 617
 618 2019-09-20  Tom Tromey  <tom@tromey.com>
 619
 620         * NEWS: Mention case-sensitivity of TUI commands.
 621         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 622         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 623         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 624
 625 2019-09-20  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui-source.c (tui_source_window::set_contents): Use
 628         make_unique_xstrdup.
 629         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 630         make_unique_xstrdup.
 631
 632 2019-09-20  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-data.c: Remove separator comments.
 635         * tui/tui-layout.c: Remove separator comments.
 636         * tui/tui-win.c: Remove separator comments.
 637         * tui/tui-wingeneral.c: Remove separator comments.
 638
 639 2019-09-20  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui.h (strcat_to_buf): Don't declare.
 642         * tui/tui.c (strcat_to_buf): Remove.
 643
 644 2019-09-20  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 647         from "fullname".
 648         * tui/tui-source.c (tui_source_window::set_contents)
 649         (tui_source_window::location_matches_p)
 650         (tui_source_window::maybe_update): Update.
 651
 652 2019-09-20  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 655         Update.
 656         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 657         prefix.
 658         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 659         (tui_data_window::line_from_reg_element_no)
 660         (tui_data_window::first_reg_element_no_inline)
 661         (tui_data_window::show_registers)
 662         (tui_data_window::show_register_group)
 663         (tui_data_window::display_registers_from)
 664         (tui_data_window::display_registers_from_line)
 665         (tui_data_window::first_data_item_displayed)
 666         (tui_data_window::delete_data_content_windows)
 667         (tui_data_window::erase_data_content)
 668         (tui_data_window::do_scroll_vertical)
 669         (tui_data_window::refresh_window)
 670         (tui_data_window::check_register_values): Update.
 671
 672 2019-09-20  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 675         (struct tui_locator_window) <full_name, proc_name>: Now
 676         std::string.
 677         * tui/tui-stack.c (tui_locator_window::make_status_line)
 678         (tui_locator_window::set_locator_fullname)
 679         (tui_locator_window::set_locator_info): Update.
 680         * tui/tui-source.c (tui_source_window::set_contents)
 681         (tui_source_window::showing_source_p): Update.
 682
 683 2019-09-20  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 686         Don't call tui_locator_win_info_ptr.
 687
 688 2019-09-20  Tom Tromey  <tom@tromey.com>
 689
 690         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 691
 692 2019-09-20  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 695         height for locator.
 696         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 697         * tui/tui-layout.c (show_source_disasm_command, show_data)
 698         (show_source_or_disasm_and_command): Use 1 as height for locator.
 699
 700 2019-09-20  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui.c (tui_enable): Update.
 703         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 704         Update.
 705         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 706         Update.
 707         * tui/tui-data.c (win_resized): Now bool.
 708         (tui_win_resized): Return bool.
 709         (tui_set_win_resized_to): Accept a bool.
 710
 711 2019-09-20  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 714         Change type of "refresh_values_only".
 715         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 716         type of "refresh_values_only".
 717
 718 2019-09-20  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 721         std::string.
 722         (tui_disassemble): Add "pos" parameter.
 723         (tui_disasm_window::set_contents): Simplify.
 724
 725 2019-09-20  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-winsource.h (struct tui_source_window_base)
 728         <show_source_content>: Now private.
 729         * tui/tui-winsource.c
 730         (tui_source_window_base::show_source_content): Don't handle empty
 731         content case.
 732
 733 2019-09-20  Tom Tromey  <tom@tromey.com>
 734
 735         * tui/tui-layout.c (show_source_disasm_command)
 736         (show_source_or_disasm_and_command): Don't call
 737         show_source_content.
 738
 739 2019-09-20  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 742         Declare.
 743         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 744         from tui_make_status_line.
 745         (tui_locator_window::rerender): Update.
 746
 747 2019-09-20  Tom Tromey  <tom@tromey.com>
 748
 749         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 750         (tui_locator_window::rerender): Update.
 751
 752 2019-09-20  Tom Tromey  <tom@tromey.com>
 753
 754         * tui/tui-winsource.h (struct tui_source_window_base)
 755         <~tui_source_window_base>: Don't declare.
 756         <fullname>: Remove.
 757         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 758         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 759         member.
 760         * tui/tui-source.c (tui_source_window::set_contents): Update.
 761         (tui_source_window::location_matches_p)
 762         (tui_source_window::maybe_update): Update.
 763
 764 2019-09-20  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-winsource.h (~tui_source_element): Remove.
 767         (tui_source_element): Update.
 768         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 769         * tui/tui-winsource.c (tui_show_source_line): Update.
 770         * tui/tui-source.c (tui_source_window::set_contents): Update.
 771         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 772
 773 2019-09-20  Tom Tromey  <tom@tromey.com>
 774
 775         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 776         declare.
 777         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 778         tui_clear_source_windows_detail.
 779         * tui/tui-winsource.h (struct tui_source_window_base)
 780         <clear_detail>: Don't declare.
 781         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 782         Remove.
 783         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 784
 785 2019-09-20  Tom Tromey  <tromey@adacore.com>
 786
 787         PR ada/24919:
 788         * block.c (contained_in): Fix final return value.
 789
 790 2019-09-20  Alan Modra  <amodra@gmail.com>
 791
 792         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 793         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 794         (read_indirect_string_from_dwz): Use bfd accessor.
 795         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 796         * machoread.c (macho_symfile_read_all_oso): Likewise.
 797         * solib.c (solib_bfd_open): Likewise.
 798
 799 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 800
 801         * eval.c: Move declaration of overload_resolution to...
 802         * value.h: ...here.
 803
 804 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 805
 806         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 807         * arm-linux-tdep.c: Likewise.
 808         * arm-nbsd-nat.c: Likewise.
 809         * arm-tdep.h: Declare arm_apcs_32.
 810         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 811
 812 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 813
 814         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 815         * dwarf2read.h: Declare dwarf_always_disassemble.
 816
 817 2019-09-19  Tom de Vries  <tdevries@suse.de>
 818
 819         PR gdb/25009
 820         * source-cache.c (source_cache::ensure): Catch exception thrown during
 821         construction of the highlighter.
 822
 823 2019-09-18  Alan Modra  <amodra@gmail.com>
 824
 825         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 826         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 827         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 828         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 829         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 830         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 831         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 832         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 833         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 834         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 835         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 836         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 837         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 838         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 839         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 840         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 841         * mi/mi-interp.c: Update throughout for bfd section macro and
 842         function changes.
 843         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 844         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 845
 846 2019-09-18  Tom Tromey  <tom@tromey.com>
 847
 848         * NEWS: Add entry.
 849         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 850         call rl_initialize.
 851         (tui_enable): Do not call rl_initialize.
 852
 853 2019-09-18  Christian Groessler  <chris@groessler.org>
 854
 855         * alpha-linux-nat.c: Include gdbarch.h.
 856
 857 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 858
 859         * ui-file.c: Include cli/cli-style.h.
 860         (term_cli_styling): Remove cli_styling declaration.
 861
 862 2019-09-18  Alan Modra  <amodra@gmail.com>
 863
 864         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 865         to bfd_asymbol_section.
 866
 867 2019-09-18  Alan Modra  <amodra@gmail.com>
 868
 869         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 870         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 871         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 872
 873 2019-09-18  Alan Modra  <amodra@gmail.com>
 874
 875         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 876         * spu-linux-nat.c (spu_bfd_open): Likewise.
 877
 878 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 879
 880         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 881         to bool to match definition in dwarf2read.c.
 882
 883 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 884
 885         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 886         (print_signatures): Likewise.
 887         (trust_pad_over_xvs): Likewise.
 888         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 889         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 890         * arm-linux-nat.c (arm_apcs_32): Likewise.
 891         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 892         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 893         * arm-tdep.c (arm_debug): Likewise.
 894         (arm_apcs_32): Likewise.
 895         * auto-load.c (debug_auto_load): Likewise.
 896         (auto_load_gdb_scripts): Likewise.
 897         (global_auto_load): Likewise.
 898         (auto_load_local_gdbinit): Likewise.
 899         (auto_load_local_gdbinit_loaded): Likewise.
 900         * auto-load.h (global_auto_load): Likewise.
 901         (auto_load_local_gdbinit): Likewise.
 902         (auto_load_local_gdbinit_loaded): Likewise.
 903         * breakpoint.c (disconnected_dprintf): Likewise.
 904         (breakpoint_proceeded): Likewise.
 905         (automatic_hardware_breakpoints): Likewise.
 906         (always_inserted_mode): Likewise.
 907         (target_exact_watchpoints): Likewise.
 908         (_initialize_breakpoint): Update.
 909         * breakpoint.h (target_exact_watchpoints): Change to bool.
 910         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 911         * cli/cli-cmds.c (trace_commands): Likewise.
 912         * cli/cli-cmds.h (trace_commands): Likewise.
 913         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 914         to bool*.
 915         * cli/cli-logging.c (logging_overwrite): Change to bool.
 916         (logging_redirect): Likewise.
 917         (debug_redirect): Likewise.
 918         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 919         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 920         to bool.
 921         <boolean_option_def>: Update.
 922         (struct flag_option_def): Change default type of Context to bool
 923         from int.
 924         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 925         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 926         (get_setshow_command_value_string): Likewise.
 927         * cli/cli-style.c (cli_styling): Change to bool.
 928         (source_styling): Likewise.
 929         * cli/cli-style.h (source_styling): Likewise.
 930         (cli_styling): Likewise.
 931         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 932         to bool.
 933         * command.h (var_types): Update comment.
 934         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 935         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 936         bool.
 937         (debug_compile_cplus_scopes): Likewise.
 938         * compile/compile-internal.h (compile_debug): Likewise.
 939         * compile/compile.c (compile_debug): Likewise.
 940         (struct compile_options) <raw>: Likewise.
 941         * cp-support.c (catch_demangler_crashes): Likewise.
 942         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 943         (usr_cmd_cris_dwarf2_cfi): Likewise.
 944         * csky-tdep.c (csky_debug): Likewise.
 945         * darwin-nat.c (enable_mach_exceptions): Likewise.
 946         * dcache.c (dcache_enabled_p): Likewise.
 947         * defs.h (info_verbose): Likewise.
 948         * demangle.c (demangle): Likewise.
 949         (asm_demangle): Likewise.
 950         * dwarf-index-cache.c (debug_index_cache): Likewise.
 951         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 952         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 953         * dwarf2read.c (check_physname): Likewise.
 954         (use_deprecated_index_sections): Likewise.
 955         (dwarf_always_disassemble): Likewise.
 956         * eval.c (overload_resolution): Likewise.
 957         * event-top.c (set_editing_cmd_var): Likewise.
 958         (exec_done_display_p): Likewise.
 959         * event-top.h (set_editing_cmd_var): Likewise.
 960         (exec_done_display_p): Likewise.
 961         * exec.c (write_files): Likewise.
 962         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 963         (debug_fbsd_nat): Likewise.
 964         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 965         Likewise.
 966         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 967         <backtrace_past_entry> Likewise.
 968         * gdb-demangle.h (demangle): Likewise.
 969         (asm_demangle): Likewise.
 970         * gdb_bfd.c (bfd_sharing): Likewise.
 971         * gdbcore.h (write_files): Likewise.
 972         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 973         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 974         * gdbthread.h (print_thread_events): Likewise.
 975         * gdbtypes.c (opaque_type_resolution): Likewise.
 976         (strict_type_checking): Likewise.
 977         * gnu-nat.c (gnu_debug_flag): Likewise.
 978         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 979         * guile/scm-param.c (pascm_variable): Add boolval.
 980         (add_setshow_generic): Update.
 981         (pascm_param_value): Update.
 982         (pascm_set_param_value_x): Update.
 983         * hppa-tdep.c (hppa_debug): Change to bool..
 984         * infcall.c (may_call_functions_p): Likewise.
 985         (coerce_float_to_double_p): Likewise.
 986         (unwind_on_signal_p): Likewise.
 987         (unwind_on_terminating_exception_p): Likewise.
 988         * infcmd.c (startup_with_shell): Likewise.
 989         * inferior.c (print_inferior_events): Likewise.
 990         * inferior.h (startup_with_shell): Likewise.
 991         (print_inferior_events): Likewise.
 992         * infrun.c (step_stop_if_no_debug): Likewise.
 993         (detach_fork): Likewise.
 994         (debug_displaced): Likewise.
 995         (disable_randomization): Likewise.
 996         (non_stop): Likewise.
 997         (non_stop_1): Likewise.
 998         (observer_mode): Likewise.
 999         (observer_mode_1): Likewise.
1000         (set_observer_mode): Update.
1001         (sched_multi): Change to bool.
1002         * infrun.h (debug_displaced): Likewise.
1003         (sched_multi): Likewise.
1004         (step_stop_if_no_debug): Likewise.
1005         (non_stop): Likewise.
1006         (disable_randomization): Likewise.
1007         * linux-tdep.c (use_coredump_filter): Likewise.
1008         (dump_excluded_mappings): Likewise.
1009         * linux-thread-db.c (auto_load_thread_db): Likewise.
1010         (check_thread_db_on_load): Likewise.
1011         * main.c (captured_main_1): Update.
1012         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1013         xx2_opt, boolean_opt>: Change to bool.
1014         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1015         * maint.c (maintenance_profile_p): Likewise.
1016         (per_command_time): Likewise.
1017         (per_command_space): Likewise.
1018         (per_command_symtab): Likewise.
1019         * memattr.c (inaccessible_by_default): Likewise.
1020         * mi/mi-main.c (mi_async): Likewise.
1021         (mi_async_1): Likewise.
1022         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1023         * nat/fork-inferior.h (startup_with_shell): Likewise.
1024         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1025         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1026         * nios2-tdep.c (nios2_debug): Likewise.
1027         * or1k-tdep.c (or1k_debug): Likewise.
1028         * parse.c (parser_debug): Likewise.
1029         * parser-defs.h (parser_debug): Likewise.
1030         * printcmd.c (print_symbol_filename): Likewise.
1031         * proc-api.c (procfs_trace): Likewise.
1032         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1033         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1034         (set_parameter_value): Update.
1035         (add_setshow_generic): Update.
1036         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1037         to bool*.
1038         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1039         int*.
1040         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1041         * record-btrace.c (record_btrace_target::store_registers): Update.
1042         * record-full.c (record_full_memory_query): Change to bool.
1043         (record_full_stop_at_limit): Likewise.
1044         * record-full.h (record_full_memory_query): Likewise.
1045         * remote-notif.c (notif_debug): Likewise.
1046         * remote-notif.h (notif_debug): Likewise.
1047         * remote.c (use_range_stepping): Likewise.
1048         (interrupt_on_connect): Likewise.
1049         (remote_break): Likewise.
1050         * ser-tcp.c (tcp_auto_retry): Likewise.
1051         * ser-unix.c (serial_hwflow): Likewise.
1052         * skip.c (debug_skip): Likewise.
1053         * solib-aix.c (solib_aix_debug): Likewise.
1054         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1055         (spu_auto_flush_cache_p): Likewise.
1056         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1057         Likewise.
1058         (struct info_print_options) <quiet>: Likewise.
1059         * symfile-debug.c (debug_symfile): Likewise.
1060         * symfile.c (auto_solib_add): Likewise.
1061         (separate_debug_file_debug): Likewise.
1062         * symfile.h (auto_solib_add): Likewise.
1063         (separate_debug_file_debug): Likewise.
1064         * symtab.c (basenames_may_differ): Likewise.
1065         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1066         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1067         (struct info_types_options) <quiet>: Likewise.
1068         * symtab.h (demangle): Likewise.
1069         (basenames_may_differ): Likewise.
1070         * target-dcache.c (stack_cache_enabled_1): Likewise.
1071         (code_cache_enabled_1): Likewise.
1072         * target.c (trust_readonly): Likewise.
1073         (may_write_registers): Likewise.
1074         (may_write_memory): Likewise.
1075         (may_insert_breakpoints): Likewise.
1076         (may_insert_tracepoints): Likewise.
1077         (may_insert_fast_tracepoints): Likewise.
1078         (may_stop): Likewise.
1079         (auto_connect_native_target): Likewise.
1080         (target_stop_and_wait): Update.
1081         (target_async_permitted): Change to bool.
1082         (target_async_permitted_1): Likewise.
1083         (may_write_registers_1): Likewise.
1084         (may_write_memory_1): Likewise.
1085         (may_insert_breakpoints_1): Likewise.
1086         (may_insert_tracepoints_1): Likewise.
1087         (may_insert_fast_tracepoints_1): Likewise.
1088         (may_stop_1): Likewise.
1089         * target.h (target_async_permitted): Likewise.
1090         (may_write_registers): Likewise.
1091         (may_write_memory): Likewise.
1092         (may_insert_breakpoints): Likewise.
1093         (may_insert_tracepoints): Likewise.
1094         (may_insert_fast_tracepoints): Likewise.
1095         (may_stop): Likewise.
1096         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1097         (make_thread_apply_all_options_def_group): Change argument from int*
1098         to bool*.
1099         (thread_apply_all_command): Update.
1100         (print_thread_events): Change to bool.
1101         * top.c (confirm): Likewise.
1102         (command_editing_p): Likewise.
1103         (history_expansion_p): Likewise.
1104         (write_history_p): Likewise.
1105         (info_verbose): Likewise.
1106         * top.h (confirm): Likewise.
1107         (history_expansion_p): Likewise.
1108         * tracepoint.c (disconnected_tracing): Likewise.
1109         (circular_trace_buffer): Likewise.
1110         * typeprint.c (print_methods): Likewise.
1111         (print_typedefs): Likewise.
1112         * utils.c (debug_timestamp): Likewise.
1113         (sevenbit_strings): Likewise.
1114         (pagination_enabled): Likewise.
1115         * utils.h (sevenbit_strings): Likewise.
1116         (pagination_enabled): Likewise.
1117         * valops.c (overload_resolution): Likewise.
1118         * valprint.h (struct value_print_options) <prettyformat_arrays,
1119         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1120         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1121         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1122         Likewise.
1123         * windows-nat.c (new_console): Likewise.
1124         (cygwin_exceptions): Likewise.
1125         (new_group): Likewise.
1126         (debug_exec): Likewise.
1127         (debug_events): Likewise.
1128         (debug_memory): Likewise.
1129         (debug_exceptions): Likewise.
1130         (useshell): Likewise.
1131         * windows-tdep.c (maint_display_all_tib): Likewise.
1132         * xml-support.c (debug_xml): Likewise.
1133
1134 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1135
1136         * source.c (prepare_path_for_appending): New function.
1137         (openp): Make use of new function.
1138         (find_and_open_source): Search for the compilation directory and
1139         source file as a relative path beneath the directory search path.
1140
1141 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1142
1143         * source-cache.c (source_cache::get_line_charpos): Catch
1144         exceptions and return false, this matches the behaviour documented
1145         in the header file.
1146
1147 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1148
1149         * ada-tasks.c (info_task): Remove quoting of the task's name.
1150
1151 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1152
1153         * symfile.c (auto_solib_add): Replace comment with a reference
1154         to the header file.
1155
1156 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1157
1158         * NEWS: Mention that gdb can now be compiled with Python 3
1159         on Windows.
1160
1161 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1162
1163         * maint.c (maint_print_section_data::maint_print_section_data):
1164         Force use of 'float log10 (float)' by casting the argument to
1165         float.
1166
1167 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1168
1169         * maint.c: Add 'cmath' include.
1170         (struct maint_print_section_data): New structure.
1171         (print_section_index): New function.
1172         (print_bfd_section_info): Add header comment, small whitespace
1173         cleanup, and update to call new print_section_index function.
1174         (print_objfile_section_info): Likewise.
1175         (maint_obj_section_from_bfd_section): New function.
1176         (print_bfd_section_info_maybe_relocated): New function.
1177         (maintenance_info_sections): Add header comment, always use
1178         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1179
1180 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1183         inner scope, add check that the objfile has psymtabs before
1184         checking psymtabs_addrmap.
1185         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1186
1187 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1188
1189         * NEWS: Announce that Ada task names are now shown at more places,
1190         and between quotes (except in info task output).
1191         * gdb/ada-tasks.c (task_to_str): New function.
1192         (display_current_task_id): Call task_to_str.
1193         (task_command_1): Likewise.
1194         (print_ada_task_info): In non-mi mode, Properly align headers and data
1195         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1196
1197 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1198
1199         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1200         prstatus.pr_lwp.pr_info instead of making it up.
1201
1202 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1203
1204         * auto-load.c (auto_load_expand_dir_vars): Update.
1205         * defs.h (gdb_datadir): Change to std::string.
1206         (python_libdir): Likewise.
1207         (relocate_gdb_directory): Change return type to std::string.
1208         * guile/guile.c (gdbscm_data_directory): Update.
1209         (initialize_scheme_side): Update.
1210         * jit.c (jit_reader_dir): Change to std::string.
1211         (jit_reader_load_command): Update.
1212         * main.c (gdb_datadir): Change to std::string.
1213         (python_libdir): Likewise.
1214         (set_gdb_data_directory): Update.
1215         (relocate_path): Change to return std::string.
1216         (relocate_gdb_directory): Change to return std::string.
1217         (relocate_gdbinit_path_maybe_in_datadir): Update.
1218         (captured_main_1): Update.
1219         * python/python.c (do_start_initialization): Update.
1220         * top.c (show_gdb_datadir): Update.
1221         * xml-syscall.c (xml_init_syscalls_info): Update.
1222         (init_syscalls_info): Update.
1223
1224 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1225
1226         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1227         out of get_init_files.
1228         (get_init_files): Update.
1229
1230 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1231
1232         * main.c (get_init_files): Change to use std::string.
1233         (captured_main_1): Update.
1234         (print_gdb_help): Update.
1235
1236 2019-09-11  Ali Tamur  <tamur@google.com>
1237
1238         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1239         implementation.
1240
1241 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1242
1243         * dbxread.c (read_dbx_symtab): Update.
1244         * dwarf2read.c (load_partial_dies): Update.
1245         * mdebugread.c (parse_partial_symbols): Update.
1246         (handle_psymbol_enumerators): Update.
1247         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1248         * psymtab.c (add_psymbol_to_bcache): Likewise.
1249         (add_psymbol_to_list): Likewise.
1250         * symtab.c (symbol_set_names): Likewise.
1251         * symtab.h (symbol_set_names): Likewise.
1252         * xcoffread.c (scan_xcoff_symtab): Update.
1253
1254 2019-09-11  Tom Tromey  <tom@tromey.com>
1255
1256         * symfile-mem.c (symbol_file_add_from_memory): Use
1257         bfd_set_filename.
1258         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1259         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1260
1261 2019-09-10  Tom Tromey  <tromey@adacore.com>
1262
1263         * dwarf-index-write.c (write_psymbols): Extend error message.
1264         (debug_names::insert): Add Ada code.
1265         (debug_names::write_psymbols): Remove Ada check.
1266         (debug_names) <m_string_obstack>: New member.
1267         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1268         (gdb_index_symbol_name_matcher::matches): Remove.
1269         (mapped_index_base::find_name_components_bounds): Add "lang"
1270         parameter.
1271         (mapped_index_base::build_name_components): Also split names
1272         according to Ada syntax.
1273         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1274         type of "match_callback".
1275         (check_match, check_find_bounds_finds)
1276         (dw2_expand_symtabs_matching): Update.
1277         (dw2_debug_names_iterator): Add new constructor.
1278         (dw2_debug_names_map_matching_symbols): New function.
1279         (dw2_debug_names_expand_symtabs_matching): Update.
1280         (dwarf2_debug_names_functions): Use
1281         dw2_debug_names_map_matching_symbols.
1282
1283 2019-09-10  Tom Tromey  <tromey@adacore.com>
1284
1285         * dwarf2read.c (dw2_get_file_names_reader): Add the
1286         CU's file name to the results.
1287
1288 2019-09-10  Tom Tromey  <tromey@adacore.com>
1289
1290         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1291         map_matching_symbols.  Update.
1292         * dwarf2read.c (dw2_map_matching_symbols): Update.
1293         * psymtab.c (match_partial_symbol): Change type; update.
1294         (psym_map_matching_symbols): Likewise.
1295         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1296         type; update.
1297         * symfile.h (struct quick_symbol_functions)
1298         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1299         Remove "match".
1300
1301 2019-09-10  Tom Tromey  <tromey@adacore.com>
1302
1303         * psymtab.c (map_block): Remove.
1304         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1305         * symtab.c (iterate_over_symbols_terminated): New function.
1306         * symtab.c (iterate_over_symbols_terminated): Declare.
1307
1308 2019-09-10  Tom Tromey  <tromey@adacore.com>
1309
1310         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1311         * language.h (struct language_defn) <la_iterate_over_symbols>:
1312         Return bool.
1313         * symtab.c (iterate_over_symbols): Return bool.
1314         * symtab.h (iterate_over_symbols): Return bool.
1315
1316 2019-09-10  Tom Tromey  <tromey@adacore.com>
1317
1318         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1319         (add_nonlocal_symbols): Update.
1320         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1321         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1322         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1323         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1324         Change type of "callback".  Remove "data".
1325
1326
1327 2019-09-09  Ali Tamur  <tamur@google.com>
1328
1329         * dwarf2read.c (comp_unit_head): Update comment.
1330         (dwarf2_dwo_name): New function declaration.
1331         (dwarf_unit_type_name): New function declaration.
1332         (read_comp_unit_head): Add support for new compilation units,
1333         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1334         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1335         (currently named as "signature") in their header. Also clarify error
1336         messages.
1337         (lookup_dwo_id): New function. Returns the dwo id of the given
1338         compile unit.
1339         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1340         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1341         functions.
1342         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1343         (dwarf2_dwo_name): Get the dwo name if present.
1344         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1345         purposes.
1346
1347 2019-09-09  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1350
1351 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1352
1353         * python/python.c (do_start_initialization): Make progname_copy static,
1354         to avoid a leak report.
1355
1356 2019-09-08  Tom Tromey  <tom@tromey.com>
1357
1358         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1359
1360 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1361
1362         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1363         Change type to gdb::optional<block_enum>.
1364         (dw2_symtab_iter_init): Change block_index parameter type
1365         to gdb::optional<block_enum>.
1366         (dw2_lookup_symbol): Change block_index parameter
1367         type to block_enum.c
1368         (dw2_debug_names_lookup_symbol): Likewise.
1369         * psymtab.c (psym_lookup_symbol): Likewise.
1370         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1371         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1372         Likewise.
1373
1374 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1375
1376         * defs.h (relocate_gdb_directory): Change int to bool in
1377         signature and rename flag to relocatable.
1378         * main.c (relocate_path): Likewise.
1379         (relocate_gdb_directory): Likewise.
1380
1381 2019-09-06  Alan Modra  <amodra@gmail.com>
1382
1383         * coffread.c (coff_symfile_read): Constify filename variable.
1384         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1385         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1386         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1387         * solib.c (reload_shared_libraries_1): Likewise.
1388         * symfile.c (reread_symbols): Likewise.
1389         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1390         * solib-darwin.c (darwin_bfd_open): Likewise.
1391         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1392
1393 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1394
1395         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1396         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1397
1398 2019-09-03  Tom Tromey  <tromey@adacore.com>
1399
1400         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1401         types.
1402         (has_negatives): Unbias a range type bound.
1403         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1404         * gdbtypes.c (operator==): Handle new field.
1405         (create_range_type): Add "bias" parameter.
1406         (create_static_range_type, resolve_dynamic_range): Update.
1407         * gdbtypes.h (struct range_bounds) <bias>: New member.
1408         (create_range_type): Add bias parameter.
1409         * printcmd.c (print_scalar_formatted): Unbias range types.
1410         * value.c (unpack_long): Unbias range types.
1411         (pack_long): Bias range types.
1412
1413 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1414
1415         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1416         probe arguments.
1417
1418 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1419
1420         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1421         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1422         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1423         (compile_probe_arg): Likewise.
1424         * probe.h (get_argument_count): Likewise.
1425         * solib-svr4.c (solib_event_probe_action): Likewise.
1426         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1427
1428 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1429
1430         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1431         code to here...
1432         (svr4_create_solib_event_breakpoints): ...from here.
1433
1434 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1435
1436         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1437         suffix from warning message.
1438
1439 2019-08-30  Tom Tromey  <tom@tromey.com>
1440
1441         * tui/tui-winsource.h (struct tui_source_window_base)
1442         <refresh_all>: Don't declare.
1443         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1444         Remove.
1445         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1446         tui_show_locator_content.
1447         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1448         declare.
1449         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1450         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1451         declare.
1452
1453 2019-08-30  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1456
1457 2019-08-30  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1460         Remove unnecessary forward declarations.
1461
1462 2019-08-30  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1465         rerender.
1466         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1467         tui_show_locator_content.
1468
1469 2019-08-30  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1472         (tui_locator_window::rerender): Rewrite using body of previous
1473         tui_show_locator_content.
1474
1475 2019-08-30  Tom Tromey  <tom@tromey.com>
1476
1477         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1478         set_locator_fullname>: New methods.
1479         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1480         Rename from tui_set_locator_fullname.
1481         (tui_locator_window::set_locator_info): Rename from
1482         tui_set_locator_info.  Return bool.
1483         (tui_update_locator_fullname, tui_show_frame_info): Update.
1484
1485 2019-08-30  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1488
1489 2019-08-30  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1492         call touchwin.
1493
1494 2019-08-30  Tom Tromey  <tom@tromey.com>
1495
1496         * tui/tui-wingeneral.c (box_win): Assume win_info and
1497         win_info->handle cannot be NULL.
1498
1499 2019-08-30  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1502         refresh_window>: Declare.
1503         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1504         resize.
1505         (tui_data_item_window::rerender): Rename from
1506         tui_display_register.
1507         (tui_data_item_window::refresh_window): New method.
1508         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1509         no-op.
1510
1511 2019-08-30  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1514         regs_column_count, current_group>: Move later.  Now private.
1515         <get_current_group>: New method.
1516         * tui/tui-regs.c (tui_reg_command): Update.
1517         * tui/tui-layout.c (tui_set_layout): Update.
1518
1519 2019-08-30  Tom Tromey  <tom@tromey.com>
1520
1521         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1522         (tui_data_window::rerender): Don't call
1523         check_and_display_highlight_if_needed.
1524         (tui_data_window::refresh_all): Remove call to
1525         erase_data_content.
1526
1527 2019-08-30  Tom Tromey  <tom@tromey.com>
1528
1529         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1530         (tui_data_window::display_registers_from)
1531         (tui_data_window::display_reg_element_at_line)
1532         (tui_data_window::display_registers_from_line): Remove checks of
1533         "empty".
1534
1535 2019-08-30  Tom Tromey  <tom@tromey.com>
1536
1537         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1538         Don't declare.
1539         * tui/tui-regs.c (tui_data_window::show_registers): Call
1540         rerender.
1541         (tui_data_window::rerender): Rename from display_all_data.
1542         (tui_data_window::rerender): Remove old implementation.
1543
1544 2019-08-30  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1547         text.
1548         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1549
1550 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1551             Sergio Durigan Junior  <sergiodj@redhat.com>
1552
1553         PR win32/24284
1554         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1555
1556 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1557
1558         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1559         when searching for types.
1560
1561 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1562
1563         * f-lang.c (f_language_defn): Use f_print_typedef.
1564         * f-lang.h (f_print_typedef): Declare.
1565         * f-typeprint.c (f_print_typedef): Define.
1566
1567 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1568
1569         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1570
1571 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1572
1573         * cli/cli-utils.c (info_print_options_defs): Delete.
1574         (make_info_print_options_def_group): Delete.
1575         (extract_info_print_options): Delete.
1576         (info_print_command_completer): Delete.
1577         (info_print_args_help): Add extra parameter, and optionally
1578         include text about -n flag.
1579         * cli/cli-utils.h (struct info_print_options): Delete.
1580         (extract_info_print_options): Delete declaration.
1581         (info_print_command_completer): Delete declaration.
1582         (info_print_args_help): Add extra parameter, extend header
1583         comment.
1584         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1585         search_symbols.
1586         * stack.c (struct info_print_options): New type.
1587         (info_print_options_defs): New file scoped variable.
1588         (make_info_print_options_def_group): New static function.
1589         (info_print_command_completer): New static function.
1590         (info_locals_command): Update to use new local functions.
1591         (info_args_command): Likewise.
1592         (_initialize_stack): Add extra parameter to calls to
1593         info_print_args_help.
1594         * symtab.c (search_symbols): Add extra parameter, use this to
1595         possibly excluse non-debug symbols.
1596         (symtab_symbol_info): Add extra parameter, which is passed on to
1597         search_symbols.
1598         (struct info_print_options): New type.
1599         (info_print_options_defs): New file scoped variable.
1600         (make_info_print_options_def_group): New static function.
1601         (info_print_command_completer): New static function.
1602         (info_variables_command): Update to use local functions, and pass
1603         extra parameter through to symtab_symbol_info.
1604         (info_functions_command): Likewise.
1605         (info_types_command): Pass additional argument through to
1606         symtab_symbol_info.
1607         (rbreak_command): Pass extra argument to search_symbols.
1608         (_initialize_symtab): Add extra arguments for calls to
1609         info_print_args_help, and update help text for 'info variables',
1610         'whereis', and 'info functions' commands.
1611         * symtab.h (search_symbols): Add extra argument to declaration.
1612         * NEWS: Mention new flags.
1613
1614 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1615
1616         * symtab.c (lookup_static_symbol): Call the new function (and move
1617         it down to be next to lookup_global_symbol).
1618         (struct global_sym_lookup_data): Add block_enum member and rename to...
1619         (struct global_or_static_sym_lookup_data): ...this.
1620         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1621         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1622         (lookup_symbol_global_or_static_iterator_cb): ...this.
1623         (lookup_global_or_static_symbol): New function.
1624         (lookup_global_symbol): Call new function.
1625
1626 2019-08-26  Tom de Vries  <tdevries@suse.de>
1627
1628         PR c++/24852
1629         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1630         when pc_probe.prob == NULL.
1631
1632 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1633
1634         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1635         variable symbol_linkage to symbol_linkage_.
1636
1637 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1638
1639         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1640         represent whether the symbol is static, dynamic, or we don't
1641         know.
1642
1643 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1644
1645         * gdb/rx-tdep.c (rx_register_names): New.
1646         (rx_register_name): Delete.
1647         (rx_psw_type): Delete.
1648         (rx_fpsw_type): Delete.
1649         (rx_register_type): Delete.
1650         (rx_gdbarch_init): Convert target-descriptions.
1651         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1652         * gdb/features/Makefile: Add rx.xml.
1653         * gdb/features/rx.xml: New.
1654         * gdb/features/rx.c: Generated.
1655         * gdb/NEWS: Mention target description support.
1656
1657 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1658
1659         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1660         *slot_ptr.
1661
1662 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1663
1664         * configure.ac: Don't check for 'dlfcn.h' (moved to
1665         gdbsupport/common.m4).
1666         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1667         'gdbsupport/'.
1668         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1669         * compile/compile-c-support.c: Include
1670         'gdbsupport/gdb-dlfcn.h'.
1671         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1672         * gdb-dlfcn.c: Move to...
1673         * gdbsupport/gdb-dlfcn.c: ... here.
1674         * gdb-dlfcn.h: Move to...
1675         * gdbsupport/gdb-dlfcn.h: ... here.
1676
1677 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1678
1679         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1680         the offset field signed.
1681
1682 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1683
1684         * python/lib/gdb/__init__.py (_execute_file): New function.
1685         * python/python.c (python_run_simple_file): Call gdb._execute_file
1686         on Windows.
1687
1688 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1689
1690         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1691         all uses as this was never set to anything but a zero value.
1692
1693 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1694
1695         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1696
1697 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1698
1699         * tui/tui-data.h (tui_gen_win_info): Add an =default
1700         move constructor, required by some GCC versions.
1701
1702 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1703
1704         * go32-nat.c (go32_sysinfo): Add hygon_p.
1705
1706 2019-08-20  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1709         line_from_reg_element_no, first_reg_element_no_inline,
1710         display_all_data, delete_data_content_windows,
1711         erase_data_content>: Now private.
1712
1713 2019-08-20  Tom Tromey  <tom@tromey.com>
1714
1715         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1716         (tui_unhighlight_win, tui_highlight_win)
1717         (tui_win_info::make_window): Update.
1718         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1719
1720 2019-08-20  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1723         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1724         (MAX_PID_WIDTH): Move to tui-stack.c.
1725         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1726         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1727         (MAX_PID_WIDTH): Move from tui-data.h.
1728
1729 2019-08-20  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1732         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1733         (box_win): Update.
1734         (tui_gen_win_info::make_window): Rename from tui_make_window.
1735         (tui_win_info::make_window): New method.
1736         (tui_gen_win_info::make_visible): Update.
1737         * tui/tui-source.c (tui_source_window::set_contents): Update.
1738         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1739         (tui_data_window::display_registers_from): Update.
1740         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1741         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1742         Declare.
1743         <can_box>: Remove.
1744         <title>: Remove.
1745         (struct tui_win_info) <make_window>: Declare.
1746         <can_box>: Now virtual.
1747         <title>: New member.
1748         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1749         * tui/tui-command.c (tui_cmd_window::resize): Update.
1750
1751 2019-08-20  Tom Tromey  <tom@tromey.com>
1752
1753         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1754         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1755         (tui_data_window::check_register_values): Update.
1756
1757 2019-08-20  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-regs.h (struct tui_data_window): Use
1760         DISABLE_COPY_AND_ASSIGN.
1761         <regs_content>: Change type, removing unique_ptr.
1762         <tui_data_window>: Add move constructor.
1763         * tui/tui-regs.c (tui_data_window::show_registers)
1764         (tui_data_window::show_register_group)
1765         (tui_data_window::display_registers_from)
1766         (tui_data_window::display_registers_from)
1767         (tui_data_window::first_data_item_displayed)
1768         (tui_data_window::delete_data_content_windows)
1769         (tui_data_window::rerender, tui_data_window::refresh_window)
1770         (tui_data_window::check_register_values): Update.
1771
1772 2019-08-20  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1775         show_register_group>: Declare.
1776         (tui_show_register_group): Don't declare.
1777         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1778         tui_show_registers.
1779         (tui_data_window::show_register_group): Rename from
1780         tui_show_register_group.
1781         (tui_data_window::check_register_values, tui_reg_command):
1782         Update.
1783         * tui/tui-layout.c (tui_set_layout): Update.
1784
1785 2019-08-20  Tom Tromey  <tom@tromey.com>
1786
1787         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1788         Declare.
1789         (tui_check_register_values): Don't declare.
1790         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1791         from tui_check_register_values.
1792         * tui/tui-hooks.c (tui_register_changed): Update.
1793
1794 2019-08-20  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-regs.c (tui_reg_layout): Move later.
1797         (tui_show_registers): Don't enable TUI mode or change layout.
1798
1799 2019-08-20  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-regs.h (struct tui_data_item_window)
1802         <~tui_data_item_window>: Remove.
1803         <content>: Now a unique_xmalloc_ptr.
1804         * tui/tui-regs.c (tui_register_format): Return a
1805         unique_xmalloc_ptr.
1806         (tui_get_register): Update.
1807         (~tui_data_item_window): Remove.
1808         (tui_data_window::display_registers_from, tui_display_register):
1809         Update.
1810         * tui/tui-io.h (tui_expand_tabs): Update.
1811         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1812         Remove "col" parameter.
1813
1814 2019-08-20  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1817         field.
1818         * tui/tui-regs.c (~tui_data_item_window): Update.
1819
1820 2019-08-20  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1823         earlier.
1824
1825 2019-08-20  Tom Tromey  <tom@tromey.com>
1826
1827         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1828
1829 2019-08-20  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-source.h (struct tui_source_window): Update.
1832         * tui/tui-regs.c (tui_show_registers): Update.
1833         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1834         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1835         (NO_REGS_STRING): Remove defines.
1836
1837 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1838
1839         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1840         unnecessary thread walk if remote doesn't support the packet.
1841
1842 2019-08-19  Tom Tromey  <tromey@adacore.com>
1843
1844         * python/py-value.c (value_has_field): Fix indentation.
1845
1846 2019-08-19  Tom Tromey  <tromey@adacore.com>
1847
1848         * printcmd.c (do_one_display, info_display_command): Update.
1849         * block.h (contained_in): Return bool.  Add allow_nested
1850         parameter.
1851         * block.c (contained_in): Return bool.  Add allow_nested
1852         parameter.
1853
1854 2019-08-19  Tom Tromey  <tom@tromey.com>
1855
1856         * configure: Rebuild.
1857         * configure.ac: Disallow the combination of -static-libstdc++ and
1858         source highlight.
1859         * source-cache.c (get_language_name): Handle rust.
1860         (source_cache::get_source_lines): Ignore highlighting exceptions.
1861
1862 2019-08-16  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1865         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1866         (struct tui_source_window_base) <make_visible, refresh_window,
1867         resize>: Remove methods.
1868         <execution_info>: Remove field.
1869         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1870         (tui_show_source_line, tui_source_window_base)
1871         (~tui_source_window_base): Update.
1872         (tui_source_window_base::resize)
1873         (tui_source_window_base::make_visible)
1874         (tui_source_window_base::refresh_window): Remove.
1875         (tui_source_window_base::update_exec_info): Update.
1876         * tui/tui-source.c (tui_source_window::set_contents): Update.
1877         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1878
1879 2019-08-16  Tom Tromey  <tom@tromey.com>
1880
1881         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1882         deprecated_query_hook.
1883
1884 2019-08-16  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1887         (tui_update_source_windows_with_line): Update.
1888         * tui/tui-source.h (struct tui_source_window)
1889         <show_symtab_source>: Declare.
1890         (tui_show_symtab_source): Don't declare.
1891         * tui/tui-source.c (tui_show_symtab_source): Rename from
1892         tui_show_symtab_source.
1893
1894 2019-08-16  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-winsource.h (struct tui_source_window_base)
1897         <set_contents>: Declare.
1898         * tui/tui-winsource.c
1899         (tui_source_window_base::update_source_window_as_is): Update.
1900         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1901         Declare.
1902         (tui_set_source_content): Don't declare.
1903         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1904         tui_set_source_content.
1905         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1906         Declare.
1907         (tui_set_disassem_content): Don't declare.
1908         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1909         tui_set_disassem_content.
1910
1911 2019-08-16  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-winsource.h (struct tui_source_window_base)
1914         <update_breakpoint_info>: Declare.
1915         (tui_update_breakpoint_info): Don't declare.
1916         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1917         (tui_update_all_breakpoint_info): Update.
1918         (tui_source_window_base::update_breakpoint_info): Rename from
1919         tui_update_breakpoint_info.
1920         (tui_source_window_base::update_exec_info): Update.
1921
1922 2019-08-16  Tom Tromey  <tom@tromey.com>
1923
1924         * tui/tui-winsource.h (struct tui_source_window_base)
1925         <update_source_window>: Declare.
1926         (tui_update_source_window): Don't declare.
1927         * tui/tui-winsource.c
1928         (tui_source_window_base::update_source_window): Rename from
1929         tui_update_source_window.
1930         (tui_source_window_base::rerender): Update.
1931         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1932         * tui/tui-disasm.c (tui_show_disassem)
1933         (tui_show_disassem_and_update_source)
1934         (tui_disasm_window::maybe_update): Update.
1935
1936 2019-08-16  Tom Tromey  <tom@tromey.com>
1937
1938         * tui/tui-winsource.h (struct tui_source_window_base)
1939         <update_source_window_as_is>: Declare.
1940         (tui_update_source_window_as_is): Don't declare.
1941         * tui/tui-winsource.c (tui_update_source_window): Update
1942         (tui_source_window_base::update_source_window_as_is): Rename from
1943         tui_update_source_window_as_is.
1944         (tui_source_window_base::refill): Update.
1945         * tui/tui-source.c (tui_show_symtab_source): Update.
1946         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1947         Update.
1948
1949 2019-08-16  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-winsource.h (tui_update_source_window)
1952         (tui_update_source_window_as_is): Remove "noerror" parameter.
1953         * tui/tui-winsource.c (tui_update_source_window)
1954         (tui_update_source_window_as_is): Remove "noerror" parameter.
1955         (tui_update_source_windows_with_addr)
1956         (tui_update_source_windows_with_line)
1957         (tui_source_window_base::rerender)
1958         (tui_source_window_base::refill): Update.
1959         * tui/tui-source.h (tui_set_source_content)
1960         (tui_show_symtab_source): Remove "noerror" parameter.
1961         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1962         parameter.
1963         (tui_show_symtab_source): Likewise.
1964         (tui_source_window::maybe_update): Update.
1965         * tui/tui-disasm.c (tui_show_disassem)
1966         (tui_show_disassem_and_update_source)
1967         (tui_disasm_window::do_scroll_vertical)
1968         (tui_disasm_window::maybe_update): Update.
1969
1970 2019-08-16  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui.c (tui_is_window_visible): Update.
1973         * tui/tui-wingeneral.c (tui_make_window)
1974         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1975         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1976         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1977         (tui_set_win_height_command, parse_scrolling_args): Update.
1978         * tui/tui-source.c (tui_source_window::style_changed): Update.
1979         * tui/tui-regs.c (tui_show_registers)
1980         (tui_data_window::first_data_item_displayed)
1981         (tui_data_window::delete_data_content_windows)
1982         (tui_check_register_values, tui_reg_command): Update.
1983         * tui/tui-disasm.c (tui_show_disassem): Update.
1984         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1985         method.
1986         <is_visible>: Remove field.
1987         * tui/tui-data.c (tui_next_win, tui_prev_win)
1988         (tui_delete_invisible_windows): Update.
1989
1990 2019-08-16  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-winsource.h (struct tui_source_window_base)
1993         <m_has_locator>: Remove.
1994         * tui/tui-layout.c (show_source_disasm_command, show_data)
1995         (show_source_or_disasm_and_command): Update.
1996
1997 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1998
1999         * NEWS (Other MI changes): New subsection.
2000         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2001         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2002         * arch-utils.c (default_get_pc_address_flags): New function.
2003         * arch-utils.h (default_get_pc_address_flags): New declaration.
2004         * gdbarch.sh: Add get_pc_address_flags.
2005         * gdbarch.c: Regenerate.
2006         * gdbarch.h: Likewise.
2007         * stack.c (print_pc): New function.
2008         (print_frame_info) (print_frame): Call print_pc.
2009
2010 2019-08-16  Tom de Vries  <tdevries@suse.de>
2011
2012         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2013         print_objfile_section_info.
2014
2015 2019-08-15  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2018         calling update_cmdwin_start_line.
2019         * tui/tui-winsource.h (struct tui_source_window_base)
2020         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2021         <rerender>: Declare.
2022         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2023         Call rerender.
2024         (tui_source_window_base::set_new_height): Remove.
2025         (tui_source_window_base::rerender): Rename from
2026         do_make_visible_with_new_height.
2027         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2028         resize method.
2029         (tui_win_info::make_invisible_and_set_new_height)
2030         (tui_win_info::make_visible_with_new_height): Remove.
2031         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2032         Declare.
2033         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2034         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2035         do_make_visible_with_new_height>: Don't declare.
2036         <rerender>: Declare.
2037         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2038         set_new_height.
2039         (tui_data_window::do_make_visible_with_new_height): Remove.
2040         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2041         call tui_show_locator_content.
2042         (tui_gen_win_info::resize): Call rerender.
2043         (show_source_or_disasm_and_command): Don't call
2044         tui_show_locator_content.
2045         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2046         method.
2047         (struct tui_win_info) <rerender>: Declare.
2048         <set_new_height, make_invisible_and_set_new_height,
2049         make_visible_with_new_height>: Don't declare.
2050         * tui/tui-data.c (tui_win_list::rerender): New method.
2051         * tui/tui-command.h (struct tui_cmd_window)
2052         <do_make_visible_with_new_height>: Don't declare.
2053         * tui/tui-command.c
2054         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2055
2056 2019-08-15  Tom Tromey  <tromey@adacore.com>
2057
2058         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2059         * ada-lang.c (ada_enum_name): Likewise.
2060
2061 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2062
2063         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2064         leading underscore.
2065         (GdbOutputErrorFile): Likewise.
2066         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2067         accordingly.
2068         (execute_unwinders): Rename to have a leading underscore.
2069         (auto_load_packages): Likewise.
2070         (global scope): Adjust call to auto_load_packages accordingly.
2071         (GdbSetPythonDirectory): Likewise.
2072         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2073         instead of execute_unwinders.
2074
2075 2019-08-15  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2078         (show_data): Don't change window visibility.
2079         (tui_gen_win_info::resize): Remove special case for command
2080         window.  Use wresize, when available.
2081         (show_source_or_disasm_and_command): Don't change window
2082         visibility.
2083         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2084         <make_visible>: New method.
2085         * tui/tui-command.c (tui_cmd_window::resize): New method.
2086
2087 2019-08-15  Tom Tromey  <tom@tromey.com>
2088
2089         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2090         (struct tui_source_windows): New.
2091         * tui/tui-winsource.c (tui_display_main): Update.
2092         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2093         (new_height_ok, parse_scrolling_args): Update.
2094         * tui/tui-layout.c (show_layout, show_data): Update.
2095         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2096         (tui_add_to_source_windows): Don't declare.
2097         * tui/tui-data.c (source_windows, tui_source_windows)
2098         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2099
2100 2019-08-15  Tom Tromey  <tom@tromey.com>
2101
2102         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2103         Rename from reset.
2104         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2105         * tui/tui-layout.c (show_source_disasm_command, show_data):
2106         Update.
2107         (tui_gen_win_info::resize): Rename.
2108         (show_source_or_disasm_and_command): Update.
2109         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2110         reset.
2111
2112 2019-08-15  Tom Tromey  <tom@tromey.com>
2113
2114         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2115         * tui/tui-interp.c (tui_interp::init): Don't call
2116         tui_initialize_static_data.
2117         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2118
2119 2019-08-15  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2122         examine tui_win_list.
2123
2124 2019-08-15  Tom Tromey  <tom@tromey.com>
2125
2126         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2127         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2128         tui_clear_source_content.
2129         (tui_clear_source_content): Remove.
2130         (tui_source_window_base::do_erase_source_content): Hoist call to
2131         content.clear().
2132         * tui/tui-stack.c (tui_show_frame_info): Don't call
2133         tui_clear_source_content.
2134
2135 2019-08-15  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-winsource.h (struct tui_source_window_base)
2138         <do_erase_source_content>: New method.
2139         <erase_source_content>: New method.
2140         (tui_erase_source_content): Don't declare.
2141         * tui/tui-winsource.c (tui_clear_source_content): Update.
2142         (tui_source_window_base::do_erase_source_content): Rename from
2143         tui_erase_source_content.
2144         (tui_source_window_base::show_source_content): Update.
2145         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2146         * tui/tui-source.h (struct tui_source_window)
2147         <erase_source_content>: New method.
2148         * tui/tui-disasm.h (struct tui_disasm_window)
2149         <erase_source_content>: New method.
2150
2151 2019-08-15  Tom Tromey  <tom@tromey.com>
2152
2153         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2154         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2155         constructor.
2156         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2157         * tui/tui-source.c (tui_set_source_content): Update.
2158         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2159
2160 2019-08-15  Tom Tromey  <tom@tromey.com>
2161
2162         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2163         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2164         tui-source.c.
2165         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2166         Declare.
2167         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2168         method.
2169         (tui_source_window::maybe_update): Update.
2170
2171 2019-08-15  Tom Tromey  <tom@tromey.com>
2172
2173         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2174         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2175         tui-disasm.c.
2176         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2177         Declare.
2178         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2179         method.
2180         (tui_disasm_window::maybe_update): Update.
2181
2182 2019-08-15  Tom Tromey  <tom@tromey.com>
2183
2184         * tui/tui-winsource.h (struct tui_source_window_base)
2185         <maybe_update>: Declare.
2186         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2187         method.
2188         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2189         Declare.
2190         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2191         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2192         Declare.
2193         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2194
2195 2019-08-15  Tom Tromey  <tom@tromey.com>
2196
2197         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2198
2199 2019-08-15  Tom Tromey  <tom@tromey.com>
2200
2201         * tui/tui-wingeneral.c: Include tui-stack.h.
2202         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2203         (struct tui_locator_window): Move from tui-data.h.
2204         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2205         (tui_initialize_static_data): Move from tui-data.c.
2206         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2207         (struct tui_locator_window): Move to tui-stack.c.
2208         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2209         (tui_initialize_static_data): Move to tui-stack.c.
2210
2211 2019-08-15  Tom Tromey  <tom@tromey.com>
2212
2213         * tui/tui-layout.c (show_source_disasm_command)
2214         (show_source_or_disasm_and_command): Use make_visible method, not
2215         tui_make_window.
2216         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2217         Remove.
2218
2219 2019-08-15  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-wingeneral.h (tui_make_window): Update.
2222         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2223         parameter.
2224         (tui_gen_win_info::make_visible): Update.
2225         * tui/tui-regs.c (tui_data_window::display_registers_from):
2226         Update.
2227         * tui/tui-layout.c (show_source_disasm_command)
2228         (show_source_or_disasm_and_command): Update.
2229         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2230         (enum tui_box): Remove.
2231         (struct tui_win_info) <can_box>: New method.
2232         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2233         method.
2234
2235 2019-08-15  Tom de Vries  <tdevries@suse.de>
2236
2237         * linux-nat-trad.c: Include gdbarch.h.
2238
2239 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2240
2241         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2242         register sizes.
2243
2244 2019-08-14  Tom Tromey  <tromey@adacore.com>
2245
2246         * darwin-nat.c: Include gdbarch.h.
2247         * darwin-nat-info.c: Include gdbarch.h.
2248
2249 2019-08-13  Tom Tromey  <tom@tromey.com>
2250
2251         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2252         Remove.
2253         * tui/tui-data.c (tui_initialize_static_data): Update.
2254
2255 2019-08-13  Tom Tromey  <tom@tromey.com>
2256
2257         * tui/tui-winsource.h (struct tui_exec_info_window)
2258         <~tui_exec_info_window, maybe_allocate_content, get_content,
2259         m_content>: Remove.
2260         (struct tui_source_window_base) <set_exec_info_content,
2261         show_exec_info_content>: Don't declare.
2262         * tui/tui-winsource.c
2263         (tui_exec_info_window::maybe_allocate_content): Remove.
2264         (tui_source_window_base::update_exec_info): Rename from
2265         set_exec_info_content.
2266         (tui_source_window_base::show_exec_info_content)
2267         (tui_source_window_base::update_exec_info): Remove.
2268
2269 2019-08-13  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2272         declare.
2273         * tui/tui-winsource.c (tui_update_source_window_as_is)
2274         (tui_update_source_windows_with_addr, tui_erase_source_content):
2275         Update.
2276         (tui_clear_exec_info_content): Remove.
2277
2278 2019-08-13  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2281         declare.
2282         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2283         call tui_erase_exec_info_content.
2284         (tui_clear_exec_info_content): Rename from
2285         tui_erase_exec_info_content.
2286         (tui_clear_exec_info_content): Delete.
2287
2288 2019-08-13  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui-winsource.h (struct tui_source_window_base)
2291         <show_exec_info_content>: Declare.
2292         (tui_show_exec_info_content): Don't declare.
2293         * tui/tui-winsource.c
2294         (tui_source_window_base::show_exec_info_content): Rename from
2295         tui_show_exec_info_content.
2296         (tui_source_window_base::update_exec_info): Update.
2297
2298 2019-08-13  Tom Tromey  <tom@tromey.com>
2299
2300         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2301         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2302         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2303         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2304         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2305         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2306         ... here.
2307
2308 2019-08-13  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-winsource.h (struct tui_source_window_base)
2311         <update_exec_info>: Declare.
2312         (tui_update_exec_info): Don't declare.
2313         * tui/tui-winsource.c (tui_update_source_window_as_is)
2314         (tui_source_window_base::refresh_all)
2315         (tui_update_all_breakpoint_info): Update.
2316         (tui_source_window_base::update_exec_info): Rename from
2317         tui_update_exec_info.
2318         * tui/tui-stack.c (tui_show_frame_info): Update.
2319
2320 2019-08-13  Tom Tromey  <tom@tromey.com>
2321
2322         * tui/tui-winsource.h (struct tui_source_window_base)
2323         <set_exec_info_content>: Declare.
2324         (tui_set_exec_info_content): Don't declare.
2325         * tui/tui-winsource.c
2326         (tui_source_window_base::set_exec_info_content): Rename from
2327         tui_set_exec_info_content.
2328         (tui_update_exec_info): Update.
2329
2330 2019-08-13  Tom Tromey  <tom@tromey.com>
2331
2332         * tui/tui-winsource.h (struct tui_source_window_base)
2333         <show_source_content>: Declare.
2334         (tui_show_source_content): Don't declare.
2335         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2336         (tui_source_window_base::show_source_content): Rename from
2337         tui_show_source_content.
2338         (tui_source_window_base::refresh_all): Update.
2339         * tui/tui-layout.c (show_source_disasm_command)
2340         (show_source_or_disasm_and_command): Update.
2341
2342 2019-08-13  Tom Tromey  <tom@tromey.com>
2343
2344         * tui/tui-winsource.c (tui_erase_source_content)
2345         (tui_show_source_content, tui_source_window_base::refresh_all):
2346         Update.
2347         * tui/tui-wingeneral.h
2348         (tui_check_and_display_highlight_if_needed): Don't declare.
2349         * tui/tui-wingeneral.c
2350         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2351         check_and_display_highlight_if_needed.
2352         * tui/tui-win.c (tui_rehighlight_all)
2353         (tui_win_info::make_visible_with_new_height): Update.
2354         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2355         (tui_data_window::erase_data_content)
2356         (tui_data_window::display_all_data): Update.
2357         * tui/tui-data.h (struct tui_win_info)
2358         <check_and_display_highlight_if_needed>: Declare.
2359
2360 2019-08-13  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-win.c (tui_resize_all): Call
2363         tui_delete_invisible_windows.
2364         * tui/tui-layout.c (show_layout): Call
2365         tui_delete_invisible_windows.
2366         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2367         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2368
2369 2019-08-13  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2372         tui_add_win_to_layout.
2373
2374 2019-08-13  Tom Tromey  <tom@tromey.com>
2375
2376         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2377         * tui/tui-layout.c (tui_default_win_height): Now static.
2378
2379 2019-08-13  Tom Tromey  <tom@tromey.com>
2380
2381         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2382         single switch.
2383         (show_source_disasm_command, show_source_or_disasm_and_command):
2384         Don't check current layout.
2385
2386 2019-08-13  Tom Tromey  <tom@tromey.com>
2387
2388         * tui/tui-wingeneral.c (make_all_visible): Remove.
2389         (tui_make_all_invisible): Simplify.
2390         * tui/tui-layout.c (tui_make_all_invisible): Move from
2391         tui-wingeneral.c; simplify.
2392         (show_layout): Hoist call to tui_make_all_invisible.
2393         (show_data): Don't call tui_make_all_invisible.
2394
2395 2019-08-13  Tom Tromey  <tom@tromey.com>
2396
2397         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2398         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2399
2400 2019-08-13  Tom Tromey  <tom@tromey.com>
2401
2402         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2403         tui-data.c.
2404         (show_source_disasm_command, show_data)
2405         (show_source_or_disasm_and_command): Don't use
2406         tui_set_current_layout_to.
2407         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2408         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2409         tui-layout.c.
2410         (tui_set_current_layout_to): Remove.
2411
2412 2019-08-13  Tom Tromey  <tom@tromey.com>
2413
2414         * tui/tui-layout.c (tui_set_layout): Update.
2415         * tui/tui-data.h (struct tui_layout_def): Remove.
2416         (tui_layout_def): Don't declare.
2417         * tui/tui-data.c (layout_def): Remove.
2418         (tui_layout_def): Remove.
2419
2420 2019-08-13  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui-winsource.h (struct tui_source_window_base)
2423         <clear_detail>: No longer "override".
2424         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2425         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2426         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2427         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2428         Remove.
2429         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2430
2431 2019-08-13  Tom Tromey  <tromey@adacore.com>
2432
2433         * tracepoint.c: Don't include readline.h or history.h.
2434
2435 2019-08-12  Tom Tromey  <tom@tromey.com>
2436
2437         * configure: Rebuild.
2438         * configure.ac: Check for readline 7.
2439         * NEWS: Mention readline 7 requirement.
2440         * README: Update.
2441
2442 2019-08-12  Tom Tromey  <tom@tromey.com>
2443
2444         * mingw-hdep.c (gdb_select): Remove readline hack.
2445
2446 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2447
2448         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2449         when the function fails.
2450
2451 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2452
2453         * s390-tdep.c (s390_type_align): New function.
2454         (s390_gdbarch_init): Set it as type_align gdbarch method.
2455
2456 2019-08-09  Tom de Vries  <tdevries@suse.de>
2457
2458         PR gdb/24591
2459         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2460         pc_low with relocation offset.
2461
2462 2019-08-07  Tom Tromey  <tromey@adacore.com>
2463
2464         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2465         (print_frame_args): Update.
2466         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2467         Update.
2468         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2469         * frame.h (struct frame_arg): Add initializers.
2470         <error>: Now a unique_xmalloc_ptr.
2471
2472 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2473
2474         * NEWS: Expand the Pointer Authentication entry.
2475         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2476         (aarch64_frame_unmask_lr): ... to this.
2477         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2478         Call aarch64_frame_unmask_lr.
2479         * frame.c (struct frame_info): Add "masked" variable.
2480         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2481         (fprint_frame): Check for masked pc.
2482         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2483         declarations.
2484         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2485         * stack.c (print_frame): Check for masked pc.
2486
2487 2019-08-06  Tom Tromey  <tom@tromey.com>
2488
2489         * stabsread.c (patch_block_stabs, read_one_struct_field)
2490         (read_enum_type): Use obstack_strndup.
2491         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2492         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2493         * dwarf2read.c (guess_full_die_structure_name)
2494         (anonymous_struct_prefix): Use obstack_strndup.
2495         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2496         * c-exp.y (yylex): Use obstack_strndup.
2497         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2498         (write_var_or_type): Use obstack_strndup.
2499
2500 2019-08-06  Tom Tromey  <tom@tromey.com>
2501
2502         * symfile.c (reread_symbols): Use obstack_strdup.
2503         * stabsread.c (read_type): Use obstack_strdup.
2504         * gdb_obstack.h (obstack_strdup): New overload.
2505         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2506         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2507         (dwarf2_canonicalize_name): Use obstack_strdup.
2508         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2509         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2510         Use obstack_strdup.
2511
2512 2019-08-06  Tom Tromey  <tom@tromey.com>
2513
2514         * gdb_obstack.h (obstack_strdup): Define.
2515         * gdb_obstack.c (obstack_strdup): Don't define.
2516
2517 2019-08-06  Tom Tromey  <tom@tromey.com>
2518
2519         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2520         obstack_strdup.
2521         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2522         obstack_strdup.
2523         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2524         * stabsread.c (common_block_start): Use obstack_strdup.
2525         * objfiles.c (set_objfile_main_name, objfile): Use
2526         obstack_strdup.
2527         * namespace.c (add_using_directive): Use obstack_strdup.
2528         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2529         * jit.c (finalize_symtab): Use obstack_strdup.
2530         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2531         (guess_partial_die_structure_name, partial_die_info::fixup)
2532         (dwarf2_name): Use obstack_strdup.
2533         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2534         obstack_strdup.
2535         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2536         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2537         obstack_strdup.
2538         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2539
2540 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2541
2542         * unittests/help-doc-selftests.c: New file.
2543         * Makefile.in: Add the new file.
2544
2545 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2546
2547         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2548         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2549         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2550         the trailing '.' is not output, and the first character is uppercased.
2551         (print_help_for_command): Update call to print_doc_line.
2552         (print_doc_of_command): Likewise.
2553         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2554         * cli/cli-option.c (append_indented_doc): Do not append newline.
2555         (build_help_option): Append newline after first appended_indented_doc
2556         only if a second call is done.
2557         (build_help): Append 2 new lines before each option, except the first
2558         one.
2559         * compile/compile.c (_initialize_compile): Add new lines after
2560         %OPTIONS%, when not at the end of the help.
2561         Change help doc or code
2562         producing the help doc to respect the invariants.
2563         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2564         Also removed the new line after 'Options:', as all other commands
2565         do not put an empty line between 'Options:' and the first option.
2566         * printcmd.c (_initialize_printcmd): Likewise.
2567         * stack.c (_initialize_stack): Likewise.
2568         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2569         incorrectly telling COMMAND is optional.
2570         * ada-lang.c (_initialize_ada_language): Change help doc or code
2571         producing the help doc to respect the invariants.
2572         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2573         * breakpoint.c (_initialize_breakpoint): Likewise.
2574         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2575         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2576         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2577         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2578         _initialize_cli_style): Likewise.
2579         * corelow.c (core_target_info): Likewise.
2580         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2581         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2582         * filesystem.c (_initialize_filesystem): Likewise.
2583         * frame.c (_initialize_frame): Likewise.
2584         * gnu-nat.c (add_task_commands): Likewise.
2585         * infcall.c (_initialize_infcall): Likewise.
2586         * infcmd.c (_initialize_infcmd): Likewise.
2587         * interps.c (_initialize_interpreter): Likewise.
2588         * language.c (_initialize_language): Likewise.
2589         * linux-fork.c (_initialize_linux_fork): Likewise.
2590         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2591         * maint.c (_initialize_maint_cmds): Likewise.
2592         * memattr.c (_initialize_mem): Likewise.
2593         * printcmd.c (_initialize_printcmd): Likewise.
2594         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2595         _RegEx): Likewise.
2596         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2597         * record-btrace.c (_initialize_record_btrace): Likewise.
2598         * record-full.c (_initialize_record_full): Likewise.
2599         * record.c (_initialize_record): Likewise.
2600         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2601         * regcache.c (_initialize_regcache): Likewise.
2602         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2603         _initialize_remote): Likewise.
2604         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2605         * serial.c (_initialize_serial): Likewise.
2606         * skip.c (_initialize_step_skip): Likewise.
2607         * source.c (_initialize_source): Likewise.
2608         * stack.c (_initialize_stack): Likewise.
2609         * symfile.c (_initialize_symfile): Likewise.
2610         * symtab.c (_initialize_symtab): Likewise.
2611         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2612         * top.c (init_main): Likewise.
2613         * tracefile-tfile.c (tfile_target_info): Likewise.
2614         * tracepoint.c (_initialize_tracepoint): Likewise.
2615         * tui/tui-win.c (_initialize_tui_win): Likewise.
2616         * utils.c (add_internal_problem_command): Likewise.
2617         * valprint.c (value_print_option_defs): Likewise.
2618
2619 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2620
2621         PR build/24886
2622         * configure.ac: Drop enable-libmcheck support.
2623         * configure, config.in: Rebuild.
2624         * libmcheck.m4: Remove.
2625         * acinclude.m4: Don't include it.
2626         * Makefile.in: Don't distribute it.
2627         * top.c (print_gdb_configuration): Don't mention it.
2628
2629 2019-08-06  Tom Tromey  <tom@tromey.com>
2630
2631         * utils.c (set_output_style): Sometimes pass stream to
2632         emit_style_escape.
2633         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2634         * record-btrace.c (btrace_insn_history): Update.
2635         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2636         method.
2637         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2638         Update initializers.
2639         <m_uiout>: New field.
2640         <m_di>: Move lower.
2641         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2642         Remove "uiout" parameter.
2643         (dump_insns): Update.
2644         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2645         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2646
2647 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2648
2649         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2650         (error_in_psymtab_expansion): Likewise.
2651         (lookup_symbol_via_quick_fns): Likewise.
2652         (basic_lookup_transparent_type_quick): Likewise.
2653         (basic_lookup_transparent_type_1): Likewise.
2654
2655 2019-08-06  Tom Tromey  <tromey@adacore.com>
2656
2657         * source.c (last_source_error): Now bool.
2658         (print_source_lines_base): Make "noprint" bool.  Only open
2659         source file when last_source_visited changes.
2660
2661 2019-08-06  Tom Tromey  <tromey@adacore.com>
2662
2663         * annotate.c (annotate_source_line): Use g_source_cache.
2664         * source-cache.c (source_cache::get_plain_source_lines): Change
2665         parameters.  Populate m_offset_cache.
2666         (source_cache::ensure): New method.
2667         (source_cache::get_line_charpos): New method.
2668         (extract_lines): Move lower.  Change parameters.
2669         (source_cache::get_source_lines): Move lower.
2670         * source-cache.h (class source_cache): Update comment.
2671         <get_line_charpos>: New method.
2672         <get_source_lines>: Update comment.
2673         <clear>: Clear m_offset_cache.
2674         <get_plain_source_lines>: Change parameters.
2675         <ensure>: New method
2676         <m_offset_cache>: New member.
2677         * source.c (forget_cached_source_info_for_objfile): Update.
2678         (info_source_command): Use g_source_cache.
2679         (find_source_lines, open_source_file_with_line_charpos): Remove.
2680         (print_source_lines_base, search_command_helper): Use g_source_cache.
2681         * source.h (open_source_file_with_line_charpos): Don't declare.
2682         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2683         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2684         Use g_source_cache.
2685
2686 2019-08-06  Tom Tromey  <tromey@adacore.com>
2687
2688         * source-cache.c (source_cache::get_plain_source_lines):
2689         Remove "first_line" and "last_line" parameters.
2690         (source_cache::get_source_lines): Cache plain text.
2691         * source-cache.h (class source_cache)
2692         <get_plain_source_lines>: Update.
2693
2694 2019-08-06  Tom Tromey  <tromey@adacore.com>
2695
2696         * source-cache.c (extract_lines): No longer a method.
2697         Changed type of parameter.  Include final newline.
2698         (selftests::extract_lines_test): New function.
2699         (_initialize_source_cache): Likewise.
2700         * source-cache.h (class source_cache)
2701         <extract_lines>: Don't declare.
2702
2703 2019-08-06  Tom Tromey  <tromey@adacore.com>
2704
2705         * breakpoint.c (init_breakpoint_sal): Update.
2706         (breakpoint): Update.
2707         * breakpoint.h (struct breakpoint) <filter>: Now a
2708         unique_xmalloc_ptr.
2709
2710 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2711
2712         * NEWS: Mention dictionary access on blocks.
2713         * python/py-block.c (blpy_getitem): New function.
2714         (block_object_as_mapping): New struct.
2715         (block_object_type): Use new struct for tp_as_mapping field.
2716
2717 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2718
2719         * objfiles.h (objfile): Add a comment describing partial symbols.
2720
2721 2019-08-05  Tom Tromey  <tromey@adacore.com>
2722
2723         * compile/compile.c (_initialize_compile): Use _(), not N_().
2724         * thread.c (_initialize_thread): Use _(), not N_().
2725         * stack.c (_initialize_stack): Use _(), not N_().
2726         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2727
2728 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2729
2730         * dwarf2read.c (struct dw2_symtab_iterator):
2731         <want_specific_block>: Remove.
2732         <block_index>: Change type to gdb::optional.
2733         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2734         change type of BLOCK_INDEX parameter to gdb::optional.
2735         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2736         (dw2_lookup_symbol): Don't pass argument for
2737         WANT_SPECIFIC_BLOCK.
2738         (dw2_expand_symtabs_for_function): Don't pass argument for
2739         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2740         (class dw2_debug_names_iterator)
2741         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2742         parameter, change BLOCK_INDEX type to gdb::optional.
2743         <m_want_specific_block>: Remove.
2744         <m_block_index>: Change type to gdb::optional.
2745         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2746         gdb::optional.  Re-write in function of gdb::optional.
2747         (dw2_debug_names_lookup_symbol): Don't pass argument for
2748         WANT_SPECIFIC_BLOCK.
2749         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2750         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2751         BLOCK_INDEX.
2752
2753 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2754
2755         * NEWS: Mention changes to "info sources" command.
2756
2757 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2758
2759         * symtab.c (filename_partial_match_opts): New struct type.
2760         (struct output_source_filename_data): New members
2761         regexp, c_regexp, partial_match.
2762         (output_source_filename): Use new members to decide to print file.
2763         (info_sources_option_defs): New variable.
2764         (make_info_sources_options_def_group, print_info_sources_header,
2765         info_sources_command_completer):
2766         New functions.
2767         (info_sources_command): Read new optional arguments.
2768         (_initialize_symtab): Update info sources help.
2769
2770 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2771
2772         * ada-lang.c (exception_support_info_v0): Renamed from...
2773         (default_exception_support_info): ... this.  Create new
2774         definition for v1.
2775         (ada_has_this_exception_support): Look up catch_handlers_sym.
2776         (ada_exception_support_info_sniffer): Try v0 after default.
2777
2778 2019-08-01  Tom Tromey  <tromey@adacore.com>
2779
2780         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2781         gdbarch.h.
2782
2783 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2784
2785         * s12z-tdep.c: Fix include path for s12z-opc.h.
2786
2787 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2788
2789         * NEWS: Require GNU make 3.82.
2790
2791 2019-07-16  Tom Tromey  <tom@tromey.com>
2792
2793         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2794         declare.
2795
2796 2019-07-30  Tom Tromey  <tromey@adacore.com>
2797
2798         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2799
2800 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2801
2802         * printcmd.c (print_address_symbolic): Print negative offsets.
2803         (build_address_symbolic): Force signed arithmetic when computing
2804         offset.
2805
2806 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2807
2808         PR/24474: Add a function to lookup static variables.
2809         * NEWS: Mention this new function.
2810         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2811         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2812         * python/python.c (python_GdbMethods): Add new function.
2813
2814 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2815
2816         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2817         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2818         (objfpy_lookup_static_symbol): New function.
2819         (objfile_object_methods): Add new functions.
2820
2821 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2822
2823         * NEWS: Mention 'set|show print frame-info'.  Mention new
2824         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2825         backtrace argument.  Mention that python frame filtering code
2826         is now consistent with what 'backtrace' command prints.
2827
2828 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2829
2830         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2831         comments.
2832         (print_frame_info_auto, print_frame_info_source_line,
2833         print_frame_info_location, print_frame_info_source_and_location,
2834         print_frame_info_location_and_address, print_frame_info_short_location):
2835         New declarations.
2836         (struct frame_print_options): New member print_frame_info.
2837         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2838         * stack.h (get_user_print_what_frame_info): New declaration.
2839         (frame_show_address): New declaration.
2840         * stack.c (print_frame_arguments_choices): New value 'presence'.
2841         (print_frame_info_auto, print_frame_info_source_line,
2842         print_frame_info_location, print_frame_info_source_and_location,
2843         print_frame_info_location_and_address, print_frame_info_short_location,
2844         print_frame_info_choices, print_frame_info_print_what): New definitions.
2845         (print_frame_args): Only print dots for args if print frame-arguments
2846         is 'presence'.
2847         (frame_print_option_defs): New element for "frame-info".
2848         (get_user_print_what_frame_info): New function.
2849         (frame_show_address): Make non static.  Move comment to stack.h.
2850         (print_frame_info_to_print_what): New function.
2851         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2852         to decide what to print.
2853         (backtrace_command_1): Handle the new print_frame_arguments_presence
2854         value.
2855         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2856         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2857         (py_print_frame): In non-mi mode, use LOCATION as default for
2858         print_what, similarly to frame information printed directly by
2859         backtrace command. Handle frame-info user option in non MI mode.
2860
2861 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2862
2863         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2864         Add case for debugging 32-bit target on 64-bit host.  Revise
2865         comment.
2866
2867 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2868
2869         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2870         instead of find_function_entry_range_from_pc.
2871
2872 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2873
2874         * stack.c (find_frame_funname): Remove code which preferred
2875         minsym over symtab sym in "certain pathological cases".
2876
2877         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2878         parameter.  Change type of "do_demangle" to bool.
2879         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2880         Pass suitable "prefer_sym_over_minsym" flag to
2881         build_address_symbolic().  Don't output "+" for negative offsets.
2882         * printcmd.c (print_address_symbolic): Update invocation of
2883         build_address_symbolic to include a "prefer_sym_over_minsym"
2884         flag.
2885         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2886         Restrict cases in which use of minimal symbol is preferred to that
2887         of a found symbol.  Update comments.
2888
2889         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2890         for entry pc when entry pc is out of range for that FDE.
2891
2892 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2893
2894         PR gdb/24839:
2895         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2896         type.
2897
2898 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2899
2900         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2901         this function's Python signature.
2902
2903
2904 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2905
2906         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2907         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2908         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2909         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2910         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2911
2912
2913 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2914
2915         * h8300-tdep.c (h8300_register_name_common): New.
2916         h8300_register_name): Use h8300_register_name_common.
2917         (h8300s_register_name): Likewise.
2918         (h8300sx_register_name): Likewise.
2919         (h8300h_register_nam): New.
2920         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2921
2922
2923 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2924
2925         * arm-tdep.c (arm_skip_cmse_entry): New function.
2926         (arm_is_sgstubs_section): New function.
2927         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2928
2929 2019-07-22  Tom Tromey  <tom@tromey.com>
2930
2931         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2932         Don't self-assign.
2933
2934 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2935
2936         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2937         type_print.
2938
2939 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2940
2941         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2942         so that GDB doesn't match any msymbols when searching in the
2943         TYPES_DOMAIN.
2944         (print_symbol_info): Print using typedef_print or type_print based
2945         on the type of the symbol.  Add updated FIXME comment moved from...
2946         (_initialize_symtab): ... move and update FIXME comment to above.
2947
2948 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2949
2950         * NEWS: Mention adding -q option to "info types".
2951         * symtab.c (struct info_types_options): New struct.
2952         (info_types_options_defs): New variable.
2953         (make_info_types_options_def_group): New function.
2954         (info_types_command): Use gdb::option framework to parse options.
2955         (info_types_command_completer): New function.
2956         (_initialize_symtab): Extend the help text on "info types" and
2957         register command completer.
2958
2959 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2960
2961         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2962         (lookup_symbol_in_objfile): Change int to block_enum and add a
2963         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2964
2965 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2966
2967         * MAINTAINERS (Write After Approval): Add self.
2968
2969 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2970
2971         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2972         instruction to the dummy code region.
2973
2974 2019-07-19  Tom Tromey  <tromey@adacore.com>
2975
2976         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2977         (ARGSUSED, PARAMS, __func__): Remove rules.
2978
2979 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2980
2981         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2982         * features/arm/arm-with-iwmmxt.c: Remove.
2983         * features/arm/arm-with-iwmmxt.xml: Remove.
2984         * features/arm/arm-with-m-fpa-layout.c: Remove.
2985         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2986         * features/arm/arm-with-m-vfp-d16.c: Remove.
2987         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2988         * features/arm/arm-with-m.c: Remove.
2989         * features/arm/arm-with-m.xml: Remove.
2990         * features/arm/arm-with-neon.c: Remove.
2991         * features/arm/arm-with-neon.xml: Remove.
2992         * features/arm/arm-with-vfpv2.c: Remove.
2993         * features/arm/arm-with-vfpv2.xml: Remove.
2994         * features/arm/arm-with-vfpv3.c: Remove.
2995         * features/arm/arm-with-vfpv3.xml: Remove.
2996
2997 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2998
2999         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3000
3001 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3002
3003         * arch/aarch32.c (aarch32_create_target_description): Create
3004         target descriptions using features.
3005         * arch/arm.c (arm_create_target_description)
3006         (arm_create_mprofile_target_description): Likewise.
3007         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3008
3009 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3010
3011         * Makefile.in: Add new files.
3012         * aarch32-tdep.c: New file.
3013         * aarch32-tdep.h: New file.
3014         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3015         Call aarch32_read_description.
3016         * arch/aarch32.c: New file.
3017         * arch/aarch32.h: New file.
3018         * arch/arm.c (arm_create_target_description)
3019         (arm_create_mprofile_target_description): New function.
3020         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3021         (arm_create_target_description)
3022         (arm_create_mprofile_target_description): New declaration.
3023         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3024         read_description functions.
3025         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3026         Likewise.
3027         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3028         * arm-tdep.c (tdesc_arm_list): New variable.
3029         (arm_register_g_packet_guesses): Call create description functions.
3030         (arm_read_description) (arm_read_mprofile_description): New
3031         function.
3032         * arm-tdep.h (arm_read_description)
3033         (arm_read_mprofile_description): Add declaration.
3034         * configure.tgt: Add new files.
3035
3036 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3037
3038         * top.c (new_ui_command): Open specified terminal just once.
3039
3040 2019-07-18  Tom Tromey  <tromey@adacore.com>
3041
3042         * symtab.c (main_name): Constify return type.
3043         * symfile.c (set_initial_language): Update.
3044         * symtab.h (main_name): Constify return type.
3045
3046 2019-07-17  Tom Tromey  <tom@tromey.com>
3047
3048         * tui/tui-winsource.c (tui_update_source_window)
3049         (tui_update_source_window_as_is)
3050         (tui_update_source_windows_with_line): Remove return.
3051         * tui/tui-disasm.c (tui_show_disassem)
3052         (tui_show_disassem_and_update_source): Remove return.
3053         * tui/tui.c (tui_reset): Remove return.
3054         * tui/tui-wingeneral.c
3055         (tui_check_and_display_highlight_if_needed): Remove return.
3056
3057 2019-07-17  Tom Tromey  <tom@tromey.com>
3058
3059         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3060
3061 2019-07-17  Tom Tromey  <tom@tromey.com>
3062
3063         * tui/tui-winsource.h (struct tui_exec_info_window)
3064         (struct tui_source_window_base): Move from tui-data.h.
3065         * tui/tui-winsource.c: Move many method definitions from
3066         elsewhere.  Remove "structuring" comments.
3067         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3068         (tui_source_window_base::refresh_window): Move to
3069         tui-winsource.c.
3070         * tui/tui-win.c (tui_source_window_base::refresh_all)
3071         (tui_source_window_base::update_tab_width)
3072         (tui_source_window_base::set_new_height)
3073         (tui_source_window_base::do_make_visible_with_new_height): Move to
3074         tui-winsource.c.
3075         * tui/tui-source.h: Update.
3076         * tui/tui-source.c (tui_source_window_base::reset): Move to
3077         tui-winsource.c.
3078         * tui/tui-disasm.h: Update.
3079         * tui/tui-data.h (struct tui_exec_info_window): Move to
3080         tui-winsource.h.
3081         (struct tui_source_window_base): Likewise.
3082         * tui/tui-data.c (tui_source_window_base::clear_detail)
3083         (tui_source_window_base, ~tui_source_window_base): Move to
3084         tui-winsource.c.
3085
3086 2019-07-17  Tom Tromey  <tom@tromey.com>
3087
3088         * tui/tui-win.c (tui_resize_all)
3089         (tui_source_window_base::update_tab_width)
3090         (tui_adjust_win_heights): Update.
3091         (tui_win_info::make_invisible_and_set_new_height): Rename from
3092         make_invisible_and_set_new_height.
3093         * tui/tui-data.h (struct tui_win_info)
3094         <make_invisible_and_set_new_height>: New method.
3095
3096 2019-07-17  Tom Tromey  <tom@tromey.com>
3097
3098         * tui/tui.c: Update.
3099         * tui/tui-source.h (struct tui_source_window): Move from
3100         tui-data.h.
3101         * tui/tui-layout.c: Update.
3102         * tui/tui-disasm.c: Update.
3103         * tui/tui-data.h (struct tui_source_window): Move to
3104         tui-source.h.
3105
3106 2019-07-17  Tom Tromey  <tom@tromey.com>
3107
3108         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3109         tui-data.h.
3110         * tui/tui-data.h (struct tui_disasm_window): Move to
3111         tui-disasm.h.
3112
3113 2019-07-17  Tom Tromey  <tom@tromey.com>
3114
3115         * tui/tui-regs.h (struct tui_data_item_window): Move from
3116         tui-data.h.
3117         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3118         * tui/tui-data.h (struct tui_data_item_window): Move to
3119         tui-regs.h.
3120         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3121
3122 2019-07-17  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui.c: Update.
3125         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3126         (tui_cmd_window::max_height): Move to tui-command.c.
3127         * tui/tui-layout.c: Update.
3128         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3129         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3130         tui-command.c.
3131         * tui/tui-command.h (struct tui_cmd_window): Move from
3132         tui-data.h.
3133         * tui/tui-command.c: Remove "structuring" comments.
3134         (tui_cmd_window::clear_detail)
3135         (tui_cmd_window::do_make_visible_with_new_height)
3136         (tui_cmd_window::max_height): Move from elsewhere.
3137
3138 2019-07-17  Tom Tromey  <tom@tromey.com>
3139
3140         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3141         Now static.
3142         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3143         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3144
3145 2019-07-17  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui.c: Update.
3148         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3149         tui-regs.c.
3150         * tui/tui-windata.h: Remove file.
3151         * tui/tui-windata.c: Remove file.
3152         * tui/tui-win.c (tui_data_window::set_new_height)
3153         (tui_data_window::do_make_visible_with_new_height): Move to
3154         tui-regs.c.
3155         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3156         * tui/tui-regs.c: Remove "structuring" comments.
3157         (tui_data_window::first_data_item_displayed)
3158         (tui_data_window::delete_data_content_windows)
3159         (tui_data_window::erase_data_content)
3160         (tui_data_window::display_all_data)
3161         (tui_data_window::refresh_all)
3162         (tui_data_window::do_scroll_vertical)
3163         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3164         (tui_data_window::do_make_visible_with_new_height)
3165         (tui_data_window::refresh_window): Move from elsewhere.
3166         (_initialize_tui_regs): Move to end of file.
3167         * tui/tui-layout.c: Update.
3168         * tui/tui-hooks.c: Update.
3169         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3170         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3171         tui-regs.c.
3172         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3173
3174 2019-07-17  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3177         seen.
3178
3179 2019-07-17  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui-win.c (tui_source_window_base::set_new_height)
3182         (tui_source_window_base::do_make_visible_with_new_height): Use
3183         m_has_locator field directly.
3184         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3185         method.
3186         (struct tui_source_window_base) <has_locator>: Likewise.
3187
3188 2019-07-17  Tom Tromey  <tom@tromey.com>
3189
3190         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3191         Don't declare.
3192         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3193         Remove.
3194         * tui/tui-win.c (tui_source_window_base::set_new_height)
3195         (tui_source_window_base::set_new_height)
3196         (make_invisible_and_set_new_height)
3197         (tui_source_window_base::do_make_visible_with_new_height)
3198         (tui_source_window_base::do_make_visible_with_new_height):
3199         Update.
3200         * tui/tui-layout.c (show_source_disasm_command, show_data)
3201         (show_source_or_disasm_and_command): Update.
3202         * tui/tui-layout.c (show_layout): Update.
3203
3204 2019-07-17  Tom Tromey  <tom@tromey.com>
3205
3206         * tui/tui-layout.c (make_data_window): Remove.
3207         (show_data): Unify creation and re-initialization cases.
3208
3209 2019-07-17  Tom Tromey  <tom@tromey.com>
3210
3211         * tui/tui-layout.c (make_source_window, make_disasm_window):
3212         Remove.
3213         (show_data): Unify creation and re-initialization cases.
3214
3215 2019-07-17  Tom Tromey  <tom@tromey.com>
3216
3217         * tui/tui-layout.c (make_command_window): Remove.
3218         (show_source_disasm_command, show_source_or_disasm_and_command):
3219         Unify creation and re-initialization cases.
3220
3221 2019-07-17  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3224         creation and re-initialization cases.
3225
3226 2019-07-17  Tom Tromey  <tom@tromey.com>
3227
3228         * tui/tui-regs.c (tui_get_register): Return void.
3229
3230 2019-07-17  Tom Tromey  <tom@tromey.com>
3231
3232         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3233         Simplify.
3234
3235 2019-07-17  Tom Tromey  <tom@tromey.com>
3236
3237         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3238         resetting.
3239
3240 2019-07-17  Tom Tromey  <tom@tromey.com>
3241
3242         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3243         * tui/tui-regs.c (tui_reg_layout): New function.
3244         (tui_show_registers, tui_reg_command): Use it.
3245         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3246         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3247         parameters.
3248         (tui_layout_command): Remove.
3249
3250 2019-07-17  Tom Tromey  <tom@tromey.com>
3251
3252         * tui/tui-layout.h (tui/tui-layout): Return void.
3253         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3254
3255 2019-07-17  Tom Tromey  <tom@tromey.com>
3256
3257         * tui/tui-layout.c (show_source_disasm_command, show_data):
3258         Update.
3259         (reset_locator): Remove.
3260         (show_source_or_disasm_and_command): Update.
3261
3262 2019-07-17  Tom Tromey  <tom@tromey.com>
3263
3264         * tui/tui-source.c (tui_source_window_base::reset): Remove
3265         win_type parameter.
3266         * tui/tui-layout.c (make_command_window, make_source_window)
3267         (make_disasm_window, make_data_window)
3268         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3269         (reset_locator, show_source_or_disasm_and_command): Update.
3270         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3271         win_type parameter.
3272         (struct tui_source_window_base) <reset>: Likewise.
3273
3274 2019-07-17  Tom Tromey  <tom@tromey.com>
3275
3276         * tui/tui-layout.c (show_source_disasm_command): Use
3277         reset_locator.
3278         (reset_locator): New function.
3279         (init_and_make_win): Remove.
3280         (show_source_or_disasm_and_command): Use reset_locator.
3281
3282 2019-07-17  Tom Tromey  <tom@tromey.com>
3283
3284         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3285         condition.
3286         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3287         Remove condition.
3288         * tui/tui-source.c (tui_source_window_base::reset): New method.
3289         * tui/tui-layout.c (make_command_window): Don't call
3290         init_and_make_win.
3291         (make_source_window, make_disasm_window): Don't call
3292         make_source_or_disasm_window.
3293         (make_data_window): Don't call init_and_make_win.  Change calling
3294         convention.
3295         (show_source_disasm_command, show_data): Simplify.
3296         (make_source_or_disasm_window): Remove.
3297         (show_source_or_disasm_and_command): Simplify.
3298         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3299         (struct tui_source_window_base) <reset>: Likewise.
3300         <execution_info>: Remove initializer.
3301         * tui/tui-data.c (tui_source_window_base): Initialize
3302         execution_info.
3303
3304 2019-07-17  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3307         variable.
3308
3309 2019-07-17  Tom Tromey  <tom@tromey.com>
3310
3311         * tui/tui.c (tui_rl_other_window): Update.
3312         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3313         superclass method first.  Always iterate over regs_content.
3314         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3315         method.
3316         * tui/tui-win.c (tui_set_focus_command): Update.
3317
3318 2019-07-17  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-win.c (tui_set_focus_command): Rename from
3321         tui_set_focus.  Call tui_enable.
3322         (tui_set_focus_command): Remove.
3323
3324 2019-07-17  Tom Tromey  <tom@tromey.com>
3325
3326         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3327         refresh_window.
3328         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3329         touchwin.
3330         (tui_data_window::refresh_window): Call refresh_window on data
3331         items.  Always call superclass refresh_window.
3332         (tui_win_info::refresh): Remove.
3333         (tui_source_window_base::refresh_window): Update.
3334         (tui_refresh_all): Update.
3335         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3336         refresh_window.
3337         (show_source_or_disasm_and_command): Likewise.
3338         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3339         (struct tui_source_window_base) <refresh>: Likewise.
3340
3341 2019-07-17  Tom Tromey  <tom@tromey.com>
3342
3343         * tui/tui-winsource.c (tui_clear_source_content)
3344         (tui_show_source_content): Update.
3345         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3346         whether content is empty.
3347         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3348         Remove.
3349
3350 2019-07-17  Tom Tromey  <tom@tromey.com>
3351
3352         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3353         window's contents.
3354         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3355         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3356
3357 2019-07-17  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3360         (struct tui_data_item_window): Update.
3361
3362 2019-07-17  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3365         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3366         defines.
3367
3368 2019-07-17  Tom Tromey  <tom@tromey.com>
3369
3370         * tui/tui-winsource.h (tui_erase_source_content)
3371         (tui_clear_source_content): Remove "display_prompt" parameter.
3372         * tui/tui-winsource.c (tui_update_source_window_as_is)
3373         (tui_update_source_windows_with_addr): Update.
3374         (tui_clear_source_content): Remove "display_prompt" parameter.
3375         (tui_erase_source_content): Likewise.  Simplify.
3376         (tui_show_source_content): Update.
3377         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3378         * tui/tui-stack.c (tui_show_frame_info): Update.
3379         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3380         Remove defines.
3381
3382 2019-07-17  Tom Tromey  <tom@tromey.com>
3383
3384         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3385         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3386         parameter.
3387         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3388         parameter.
3389
3390 2019-07-17  Tom Tromey  <tom@tromey.com>
3391
3392         * tui/tui-winsource.c (tui_clear_source_content)
3393         (tui_show_source_content, tui_show_exec_info_content)
3394         (tui_clear_exec_info_content): Update.
3395         * tui/tui-stack.c (tui_show_locator_content): Update.
3396         (tui_show_frame_info): Update.
3397         * tui/tui-source.h (tui_source_window): Don't declare.
3398         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3399         from tui_source_is_displayed.
3400         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3401         Remove field.
3402         (struct tui_source_window_base) <content_in_use>: New field.  Now
3403         bool.
3404         (struct tui_source_window) <showing_source_p>: New method.
3405         (TUI_SRC_WIN): Change cast.
3406         * tui/tui-data.c (tui_initialize_static_data): Update.
3407
3408 2019-07-17  Tom Tromey  <tom@tromey.com>
3409
3410         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3411         location_matches_p.
3412         * tui/tui-source.c (tui_source_window::location_matches_p): New
3413         method.
3414         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3415         method.
3416         * tui/tui-data.h (struct tui_source_window_base)
3417         <location_matches_p>: New method.
3418         (struct tui_source_window, struct tui_disasm_window)
3419         <location_matches_p>: Likewise.
3420
3421 2019-07-17  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-win.c (tui_set_win_height_command): Rename from
3424         tui_set_win_height.
3425         (tui_set_win_height_command): Remove.
3426
3427 2019-07-17  Tom Tromey  <tom@tromey.com>
3428
3429         * tui/tui-source.c (tui_source_window): New constructor.  Add
3430         observer.
3431         (~tui_source_window): New destructor.
3432         (tui_source_window::style_changed): New method.
3433         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3434         (tui_attach_detach_observers): Update.
3435         * tui/tui-data.h (struct tui_source_window): Make constructor not
3436         inline.  Add destructor.
3437         (struct tui_source_window) <style_changed>: New method.
3438         <m_observable>: New member.
3439
3440 2019-07-17  Tom Tromey  <tom@tromey.com>
3441
3442         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3443         * tui/tui-win.c (tui_resize_all): Fix typo.
3444
3445 2019-07-17  Tom Tromey  <tom@tromey.com>
3446
3447         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3448         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3449         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3450         * tui/tui-win.c (window_name_completer): Use foreach.
3451         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3452         (update_tab_width): Likewise.
3453         * tui/tui-layout.c (show_layout): Update.
3454         * tui/tui-data.h (class tui_window_iterator): New.
3455         (struct all_tui_windows): New.
3456         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3457
3458 2019-07-17  Tom Tromey  <tom@tromey.com>
3459
3460         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3461         parameter.  Don't reference globals.
3462         (tui_reg_command): Update.
3463
3464 2019-07-17  Tom Tromey  <tom@tromey.com>
3465
3466         * tui/tui-regs.c (tui_show_registers): Simplify.
3467
3468 2019-07-17  Tom Tromey  <tom@tromey.com>
3469
3470         * tui/tui-regs.c (tui_show_registers): Update.
3471         (tui_show_register_group): Add win_info parameter.
3472
3473 2019-07-17  Tom Tromey  <tom@tromey.com>
3474
3475         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3476         Rename from tui_display_reg_element_at_line.
3477         (tui_data_window::display_registers_from_line): Update.
3478         * tui/tui-data.h (struct tui_data_window)
3479         <display_reg_element_at_line>: New method.
3480
3481 2019-07-17  Tom Tromey  <tom@tromey.com>
3482
3483         * tui/tui-regs.h (tui_display_registers_from)
3484         (tui_display_registers_from_line): Don't declare.
3485         * tui/tui-windata.c (tui_data_window::display_all_data)
3486         (tui_data_window::refresh_all)
3487         (tui_data_window::do_scroll_vertical): Update.
3488         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3489         from tui_display_registers_from.
3490         (tui_display_reg_element_at_line): Update.
3491         (tui_data_window::display_registers_from_line): Rename from
3492         tui_display_registers_from_line.
3493         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3494         display_registers_from_line>: New methods.
3495
3496 2019-07-17  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3499         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3500         from tui_erase_data_content.
3501         (tui_data_window::display_all_data)
3502         (tui_data_window::refresh_all)
3503         (tui_data_window::do_scroll_vertical): Update.
3504         * tui/tui-regs.c (tui_show_registers): Update.
3505         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3506         New method.
3507
3508 2019-07-17  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3511         declare.
3512         * tui/tui-windata.c
3513         (tui_data_window::delete_data_content_windows): Rename from
3514         tui_delete_data_content_windows.
3515         (tui_data_window::display_all_data)
3516         (tui_data_window::do_scroll_vertical): Update.
3517         * tui/tui-data.h (struct tui_data_window)
3518         <delete_data_content_windows>: New method.
3519
3520 2019-07-17  Tom Tromey  <tom@tromey.com>
3521
3522         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3523         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3524
3525 2019-07-17  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3528         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3529         from tui_display_all_data.
3530         * tui/tui-win.c
3531         (tui_data_window::do_make_visible_with_new_height): Update.
3532         * tui/tui-regs.c (tui_show_registers): Update.
3533         * tui/tui-layout.c (tui_set_layout): Update.
3534         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3535         method.
3536
3537 2019-07-17  Tom Tromey  <tom@tromey.com>
3538
3539         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3540         * tui/tui-windata.c (tui_display_data_from): Remove.
3541         (tui_data_window::refresh_all): Update.
3542
3543 2019-07-17  Tom Tromey  <tom@tromey.com>
3544
3545         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3546         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3547         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3548         tui_display_registers_from_line.
3549         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3550         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3551         "force_display" parameter.
3552
3553 2019-07-17  Tom Tromey  <tom@tromey.com>
3554
3555         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3556         declare.
3557         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3558         Rename from tui_first_reg_element_no_inline.
3559         (tui_display_reg_element_at_line)
3560         (tui_display_registers_from_line): Update.
3561         * tui/tui-data.h (struct tui_data_window)
3562         <first_reg_element_no_inline>: New method.
3563
3564 2019-07-17  Tom Tromey  <tom@tromey.com>
3565
3566         * tui/tui-windata.c (tui_display_data_from)
3567         (tui_data_window::do_scroll_vertical): Update.
3568         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3569         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3570         Rename from tui_line_from_reg_element_no.
3571         (tui_display_registers_from_line): Update.
3572         * tui/tui-data.h (struct tui_data_window)
3573         <line_from_reg_element_no>: New method.
3574
3575 2019-07-17  Tom Tromey  <tom@tromey.com>
3576
3577         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3578         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3579         tui_last_regs_line_no.
3580         (tui_display_reg_element_at_line)
3581         (tui_display_registers_from_line): Update.
3582         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3583         method.
3584
3585 2019-07-17  Tom Tromey  <tom@tromey.com>
3586
3587         PR tui/24722:
3588         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3589         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3590         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3591         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3592         (tui_update_breakpoint_info): Likewise.
3593         * tui/tui-hooks.c (tui_event_create_breakpoint)
3594         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3595         Update.
3596
3597 2019-07-17  Tom Tromey  <tom@tromey.com>
3598
3599         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3600
3601 2019-07-17  Tom Tromey  <tom@tromey.com>
3602
3603         * tui/tui-winsource.c (tui_update_source_window_as_is)
3604         (tui_update_source_windows_with_addr): Update.
3605         * tui/tui-source.h (tui_set_source_content)
3606         (tui_show_symtab_source): Add "win_info" parameter.
3607         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3608         parameter.
3609         (tui_show_symtab_source): Likewise.
3610
3611 2019-07-17  Tom Tromey  <tom@tromey.com>
3612
3613         * tui/tui-wingeneral.c
3614         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3615
3616 2019-07-17  Tom Tromey  <tom@tromey.com>
3617
3618         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3619         (struct tui_cmd_window) <can_scroll>: New method.
3620         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3621         method.
3622
3623 2019-07-17  Tom Tromey  <tromey@adacore.com>
3624
3625         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3626         do_field_signed>: Rename.  Change type of "value".
3627         * ui-out.c (ui_out::field_signed): Rename from field_int.
3628         Change type of "value".
3629         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3630         type of "value".
3631         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3632         do_field_int.  Change type of "value".
3633         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3634         do_field_int.  Change type of "value".
3635         * tracepoint.c (trace_status_mi, tfind_1)
3636         (print_one_static_tracepoint_marker): Update.
3637         * thread.c (print_thread_info_1, print_selected_thread_frame):
3638         Update.
3639         * stack.c (print_frame, print_frame_info): Update.
3640         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3641         Update.
3642         * source.c (print_source_lines_base): Update.
3643         * skip.c (info_skip_command): Update.
3644         * record-btrace.c (btrace_ui_out_decode_error)
3645         (btrace_call_history_src_line): Update.
3646         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3647         Update.
3648         * progspace.c (print_program_space): Update.
3649         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3650         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3651         do_field_int.  Change type of "value".
3652         * mi/mi-out.c (mi_ui_out::do_table_begin)
3653         (mi_ui_out::do_table_header): Update.
3654         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3655         type of "value".
3656         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3657         (mi_cmd_data_list_changed_registers, output_register)
3658         (mi_cmd_data_read_memory, mi_load_progress)
3659         (mi_cmd_trace_frame_collected): Update.
3660         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3661         Update.
3662         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3663         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3664         (mi_cmd_var_list_children, varobj_update_one): Update.
3665         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3666         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3667         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3668         * inferior.c (print_inferior): Update.
3669         * gdb_bfd.c (print_one_bfd): Update.
3670         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3671         Update.
3672         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3673         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3674         do_field_int.  Change type of "value".
3675         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3676         do_field_int.  Change type of "value".
3677         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3678         (print_one_breakpoint_location, print_it_catch_fork)
3679         (print_one_catch_fork, print_it_catch_vfork)
3680         (print_one_catch_vfork, print_it_catch_solib)
3681         (print_it_catch_exec, print_it_ranged_breakpoint)
3682         (print_mention_watchpoint, print_mention_masked_watchpoint)
3683         (bkpt_print_it, update_static_tracepoint): Update.
3684         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3685         * break-catch-syscall.c (print_it_catch_syscall): Update.
3686         * ada-tasks.c (print_ada_task_info): Update.
3687         * ada-lang.c (print_it_exception, print_mention_exception):
3688         Update.
3689
3690 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3691
3692         PR breakpoints/24541
3693         * gdbarch.c: Regenerate.
3694         * gdbarch.h: Regenerate.
3695         * gdbarch.sh: Adjust return type and parameter types for
3696         'stap_adjust_register'.
3697         (i386_stap_adjust_register): Adjust signature and return new
3698         register name.
3699         * stap-probe.c (stap_parse_register_operand): Adjust use of
3700         'gdbarch_stap_adjust_register'.
3701
3702 2019-07-17  Tom Tromey  <tromey@adacore.com>
3703
3704         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3705         declare VEC.
3706         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3707         std::vector.
3708         (struct s390_process_info): Add initializers.
3709         (s390_add_process): Use new.
3710         (s390_linux_nat_target::low_forget_process): Use delete.
3711         (s390_linux_nat_target::low_new_fork)
3712         (s390_linux_nat_target::stopped_by_watchpoint)
3713         (s390_linux_nat_target::low_prepare_to_resume)
3714         (s390_linux_nat_target::insert_watchpoint)
3715         (s390_linux_nat_target::insert_hw_breakpoint)
3716         (s390_linux_nat_target::remove_watchpoint)
3717         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3718
3719 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3720
3721         * aarch64-fbsd-nat.c: Include regcache.h.
3722         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3723         argument.
3724         (aarch64_fbsd_nat_target::fetch_registers)
3725         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3726         variable.
3727         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3728
3729 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3730
3731         * fbsd-nat.c: Include gdbarch.h.
3732
3733 2019-07-15  Tom Tromey  <tromey@adacore.com>
3734
3735         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3736
3737 2019-07-15  Tom Tromey  <tromey@adacore.com>
3738
3739         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3740         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3741         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3742         * cli-out.c (cli_ui_out::do_field_int): New method.
3743         * ui-out.c (ui_out::field_unsigned): New method.
3744         * symfile.c (generic_load): Use field_unsigned.
3745         (print_transfer_performance): Likewise.
3746         * record-btrace.c (ui_out_field_uint): Remove.
3747         (btrace_call_history_insn_range, btrace_call_history): Use
3748         field_unsigned.
3749         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3750         field_unsigned.
3751         * ui-out.h (class ui_out) <field_unsigned>: New method.
3752         <do_field_unsigned>: Likewise.
3753
3754 2019-07-15  Tom Tromey  <tromey@adacore.com>
3755
3756         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3757         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3758         * target.c (flash_erase_command): Use field_string.
3759         * infrun.c (print_signal_received_reason): Use field_string.
3760         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3761         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3762         field_string.
3763         * ada-tasks.c (print_ada_task_info): Use field_string.
3764
3765 2019-07-15  Tom Tromey  <tromey@adacore.com>
3766
3767         * target.c (flash_erase_command): Use field_core_addr.
3768         * symfile.c (generic_load): Use field_core_addr.
3769         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3770         Use field_core_addr.
3771         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3772         field_core_addr.
3773
3774 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3775
3776         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3777         value if its desired type is smaller than a CORE_ADDR and signed.
3778
3779 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3780
3781         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3782         of changes to field names, and use new is_reference field to
3783         decide if a property is a reference or not.
3784         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3785         field.
3786         (struct dwarf2_property_baton): Update header comment, rename
3787         'referenced_type' to 'property_type' and update comments.
3788         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3789         default property type, store in property baton, update to take
3790         accound of renamed field.
3791         (read_func_scope): Update call to attr_to_dynamic_prop.
3792         (read_array_type): Likewise.
3793         (dwarf2_per_cu_addr_sized_int_type): New function.
3794         (read_subrange_index_type): Move type finding code to
3795         dwarf2_per_cu_addr_sized_int_type.
3796         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3797         (dwarf2_per_cu_addr_type): New function.
3798         (set_die_type): Update calls to attr_to_dynamic_prop.
3799
3800 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3801
3802         * dwarf2read.c (read_subrange_index_type): New function.
3803         (read_subrange_type): Move code into new function and call it.
3804         * gdbtypes.c (create_range_type): Add some asserts.
3805
3806 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3807
3808         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3809         update return statements.
3810         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3811         declaration, and update comment to match.
3812         * gdbtypes.c (resolve_dynamic_array): Update call to
3813         dwarf2_evaluate_property to match new return type.
3814
3815 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3816
3817         * valarith.c (value_subscripted_rvalue): Change lowerbound
3818         parameter type from int to LONGEST.
3819         * value.h (value_subscripted_rvalue): Likewise in declaration.
3820
3821 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3822
3823         * cli/cli-utils.c (info_print_command_completer): New function.
3824         * cli/cli-utils.h: Add 'completer.h' include, and forward
3825         declaration for 'struct cmd_list_element'.
3826         (info_print_command_completer): Declare.
3827         * stack.c (_initialize_stack): Add completer for 'info locals' and
3828         'info args'.
3829         * symtab.c (_initialize_symtab): Add completer for 'info
3830         variables' and 'info functions'.
3831         * NEWS: Mention completion for additional info commands.
3832
3833 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3834
3835         * cli/cli-utils.c (extract_info_print_args): Delete.
3836         (extract_arg_maybe_quoted): Delete.
3837         (info_print_options_defs): New variable.
3838         (make_info_print_options_def_group): New function.
3839         (extract_info_print_options): Define new function.
3840         * cli/cli-utils.h (extract_info_print_args): Delete.
3841         (struct info_print_options): New structure.
3842         (extract_info_print_options): Declare new function.
3843         * stack.c (info_locals_command): Update to use new
3844         extract_info_print_options, also add a header comment.
3845         (info_args_command): Likewise.
3846         * symtab.c (info_variables_command): Likewise.
3847         (info_functions_command): Likewise.
3848
3849 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3850
3851         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3852         to extract string arguments.
3853         * common/common-utils.c (extract_string_maybe_quoted): New function.
3854         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3855
3856 2019-07-11  Tom Tromey  <tromey@adacore.com>
3857
3858         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3859         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3860         * top.h (gdbinit): Don't declare.
3861         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3862         into...
3863         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3864         * top.c (gdb_init): Don't call init_cli_cmds.
3865         (gdbinit): Remove.
3866         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3867
3868 2019-07-11  Tom Tromey  <tromey@adacore.com>
3869
3870         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3871         after it has been moved.
3872
3873 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3874
3875         * valops.c (value_must_coerce_to_target): Change return type to
3876         bool.
3877         * value.h (value_must_coerce_to_target): Likewise.
3878
3879 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3880
3881         * breakpoint.c (is_hardware_watchpoint): Remove
3882         forward-declaration.
3883         (is_masked_watchpoint): Change return type to bool.
3884         (is_tracepoint): Likewise.
3885         (is_breakpoint): Likewise.
3886         (is_hardware_watchpoint): Likewise.
3887         (is_watchpoint): Likewise.
3888         (is_no_memory_software_watchpoint): Likewise.
3889         (is_catchpoint): Likewise.
3890         (breakpoint_1): Make FILTER parameter's return type bool.
3891         is_masked_watchpoint): Change return type to bool.
3892         (save_breakpoints): Make FILTER parameter's return type bool.
3893         * breakpoint.h (is_breakpoint): Change return type to bool.
3894         (is_watchpoint): Likewise.
3895         (is_catchpoint): Likewise.
3896         (is_tracepoint): Likewise.
3897
3898 2019-07-10  Tom Tromey  <tom@tromey.com>
3899
3900         * defs.h: Don't include gdbarch.h.
3901         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3902         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3903         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3904         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3905         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3906         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3907         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3908         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3909         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3910         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3911         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3912         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3913         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3914         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3915         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3916         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3917         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3918         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3919         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3920         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3921         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3922         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3923         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3924         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3925         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3926         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3927         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3928
3929 2019-07-10  Tom Tromey  <tromey@adacore.com>
3930
3931         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3932         * breakpoint.c (init_ada_exception_breakpoint): Register as
3933         bp_catchpoint.
3934         (print_one_breakpoint_location, print_one_breakpoint): Use
3935         is_ada_exception_catchpoint.
3936         * ada-lang.c (class ada_catchpoint_location): Pass
3937         bp_loc_software_breakpoint to bp_location constructor.
3938         (is_ada_exception_catchpoint): New function.
3939
3940 2019-07-10  Tom Tromey  <tromey@adacore.com>
3941
3942         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3943         VEC.
3944         (struct arm_exidx_entry): New method operator<.
3945         (struct arm_exidx_data) <section_maps>: Change type.
3946         (arm_exidx_data_free): Remove.
3947         (arm_exidx_data_key): Change type.  Move lower.
3948         (arm_exidx_new_objfile): Update.
3949         (arm_compare_exidx_entries): Remove.
3950         (arm_find_exidx_entry, _initialize_arm_tdep)
3951
3952 2019-07-10  Tom Tromey  <tromey@adacore.com>
3953
3954         * solib-spu.c (ocl_program_data_key): Change type.
3955         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3956         Update.
3957
3958 2019-07-10  Tom Tromey  <tromey@adacore.com>
3959
3960         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3961         (struct solib_aix_inferior_data) <library_list>: Change type.
3962         (solib_aix_inferior_data_handle): Change type.
3963         (get_solib_aix_inferior_data): Update.
3964         (solib_aix_free_library_list): Remove.
3965         (library_list_start_library): Update.
3966         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3967         return type.
3968         (solib_aix_get_library_list)
3969         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3970         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3971
3972 2019-07-10  Tom Tromey  <tromey@adacore.com>
3973
3974         * solib-dsbt.c (struct dsbt_info): Add initializers.
3975         (solib_dsbt_pspace_data): Change type.
3976         (dsbt_pspace_data_cleanup): Remove.
3977         (get_dsbt_info, _initialize_dsbt_solib): Update.
3978
3979 2019-07-10  Tom Tromey  <tromey@adacore.com>
3980
3981         * spu-tdep.c (spu_overlay_data): Change type.
3982         (spu_get_overlay_table, spu_overlay_new_objfile)
3983         (_initialize_spu_tdep): Update.
3984
3985 2019-07-10  Tom Tromey  <tromey@adacore.com>
3986
3987         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3988         destructor.
3989         (dbx_objfile_data_key): Change type and declare later.
3990         (DBX_SYMFILE_INFO): Rewrite.
3991         * dbxread.c (dbx_objfile_data_key): Change type.
3992         (dbx_symfile_init): Update.
3993         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3994         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3995         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3996
3997 2019-07-10  Tom Tromey  <tromey@adacore.com>
3998
3999         * jit.c (jit_program_space_key): Change type.  Move lower.
4000         (get_jit_program_space_data): Update.
4001         (jit_program_space_data_cleanup): Remove.
4002         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4003         Update.
4004         (struct jit_program_space_data): Add initializers.
4005
4006 2019-07-10  Tom Tromey  <tromey@adacore.com>
4007
4008         * solib-darwin.c (struct darwin_info): Add initializers.
4009         (solib_darwin_pspace_data): Change type.
4010         (darwin_pspace_data_cleanup): Remove.
4011         (get_darwin_info, _initialize_darwin_solib): Update.
4012
4013 2019-07-10  Tom Tromey  <tromey@adacore.com>
4014
4015         * remote-sim.c (struct sim_inferior_data): Add initializers,
4016         constructor, and destructor.
4017         (sim_inferior_data_key): Change type.  Move lower.
4018         (check_for_duplicate_sim_descriptor): Update.
4019         (get_sim_inferior_data): Use new.  Update.
4020         (~sim_inferior_data_cleanup): Rename from
4021         sim_inferior_data_cleanup.  Simplify.
4022         (gdbsim_close_inferior, simulator_command)
4023         (sim_command_completer, _initialize_remote_sim): Update.
4024         (next_pid, INITIAL_PID): Move earlier.
4025
4026 2019-07-10  Tom Tromey  <tromey@adacore.com>
4027
4028         * python/python-internal.h (create_thread_object): Return
4029         gdbpy_ref.
4030         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4031         * python/py-inferior.c (struct threadlist_entry): Add
4032         constructor.
4033         <thread_obj>: Now a gdbpy_ref.
4034         (thread_to_thread_object): Update.
4035         (add_thread_object): Use new.
4036         (delete_thread_object): Use delete.
4037         (infpy_threads): Update.
4038         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4039         GIL.
4040
4041 2019-07-10  Tom Tromey  <tromey@adacore.com>
4042
4043         * valops.c (value_cast): Specialize error message for Ada.
4044
4045 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4046
4047         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4048
4049 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4050
4051         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4052         bpstat_should_step): Return bool, adjust comments.
4053         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4054         bpstat_should_step): Likewise.
4055
4056 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4057
4058         * features/Makefile: Use feature target descriptions for Arm.
4059         * features/arm/arm-core.c: Generate new file.
4060         * features/arm/arm-fpa.c: Likewise.
4061         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4062         * features/arm/arm-m-profile.c: Likewise.
4063         * features/arm/arm-vfpv2.c: Likewise.
4064         * features/arm/arm-vfpv3.c: Likewise.
4065         * features/arm/xscale-iwmmxt.c: Likewise.
4066         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4067
4068 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4069
4070         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4071         ptrace earlier.
4072
4073 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4074
4075         * features/aarch64-pauth.c: Regenerate.
4076
4077 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4078
4079         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4080         bool.
4081         (bpstat_what): Use false instead of 0.
4082
4083 2019-07-09  Pedro Alves  <palves@redhat.com>
4084
4085         * break-catch-throw.c (is_exception_catchpoint): New.
4086         * breakpoint.c (print_one_breakpoint_location): New parameter
4087         'raw_loc'.  Handle it.  Use
4088         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4089         looking at the breakpoint's type.
4090         (print_one_breakpoint): If handling "maint info breakpoints", also
4091         print locations of exception catchpoints.
4092         * breakpoint.h (is_exception_catchpoint): Declare.
4093
4094 2019-07-09  Pedro Alves  <palves@redhat.com>
4095
4096         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4097         "addr" field.
4098         (allocate_location_exception_catchpoint): New.
4099         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4100         (initialize_throw_catchpoint_ops): Install
4101         allocate_location_exception_catchpoint as allocate_location
4102         method.
4103         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4104         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4105         bp_loc_other.
4106         (breakpoint_address_is_meaningful): Delete.
4107         (bl_address_is_meaningful): New.
4108         (breakpoint_locations_match): Adjust comment.
4109         (bp_location_from_bp_type): New, factored out of...
4110         (bp_location::bp_location(breakpoint *)): ... this.
4111         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4112         factored out of...
4113         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4114         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4115         breakpoint_address_is_meaningful.
4116         (bp_locations_compare): Adjust comment.
4117         (update_global_location_list): Use bl_address_is_meaningful
4118         instead of breakpoint_address_is_meaningful.
4119         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4120         explicit.
4121         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4122         * python/py-breakpoint.c (bppy_get_location): No longer check
4123         whether location is null.
4124
4125 2019-07-09  Pedro Alves  <palves@redhat.com>
4126
4127         PR c++/15468
4128         * breakpoint.c (print_one_breakpoint_location): Remove
4129         single-location assert.
4130
4131 2019-07-09  Tom Tromey  <tom@tromey.com>
4132
4133         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4134         * configure: Rebuild.
4135         * configure.ac: Change common to gdbsupport.
4136         * gdbsupport: Rename from common.
4137         * acinclude.m4: Change common to gdbsupport.
4138         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4139         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4140         gdbsupport.
4141         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4142         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4143         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4144         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4145         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4146         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4147         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4148         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4149         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4150         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4151         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4152         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4153         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4154         coff-pe-read.c, command.h, compile/compile-c-support.c,
4155         compile/compile-c.h, compile/compile-cplus-symbols.c,
4156         compile/compile-cplus-types.c, compile/compile-cplus.h,
4157         compile/compile-loc2c.c, compile/compile.c, completer.c,
4158         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4159         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4160         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4161         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4162         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4163         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4164         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4165         features/aarch64-core.c, features/aarch64-fpu.c,
4166         features/aarch64-pauth.c, features/aarch64-sve.c,
4167         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4168         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4169         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4170         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4171         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4172         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4173         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4174         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4175         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4176         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4177         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4178         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4179         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4180         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4181         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4182         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4183         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4184         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4185         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4186         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4187         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4188         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4189         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4190         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4191         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4192         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4193         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4194         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4195         minsyms.c, mips-linux-tdep.c, namespace.h,
4196         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4197         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4198         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4199         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4200         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4201         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4202         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4203         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4204         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4205         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4206         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4207         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4208         procfs.c, producer.c, progspace.h, psymtab.h,
4209         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4210         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4211         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4212         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4213         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4214         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4215         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4216         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4217         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4218         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4219         target-memory.c, target.c, target.h, target/waitstatus.c,
4220         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4221         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4222         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4223         unittests/array-view-selftests.c,
4224         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4225         unittests/common-utils-selftests.c,
4226         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4227         unittests/format_pieces-selftests.c,
4228         unittests/function-view-selftests.c,
4229         unittests/lookup_name_info-selftests.c,
4230         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4231         unittests/mkdir-recursive-selftests.c,
4232         unittests/observable-selftests.c,
4233         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4234         unittests/parse-connection-spec-selftests.c,
4235         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4236         unittests/scoped_fd-selftests.c,
4237         unittests/scoped_mmap-selftests.c,
4238         unittests/scoped_restore-selftests.c,
4239         unittests/string_view-selftests.c, unittests/style-selftests.c,
4240         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4241         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4242         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4243         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4244         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4245         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4246
4247 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4248
4249         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4250         bool value.
4251         (decode_digits_ordinary): Set explicit_line field in sal.
4252         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4253         symtab_and_line that was set on an explicit line number in
4254         assembler code.  Do always update the recorded symtab and line if
4255         we do skip the prologue.
4256
4257 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * breakpoint.c (set_breakpoint_location_function): Remove
4260         explicit_loc parameter.
4261         (momentary_breakpoint_from_master): Update call to
4262         set_breakpoint_location_function.
4263         (add_location_to_breakpoint): Likewise.
4264
4265 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4266
4267         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4268         required features based on default bfd type when no specific bfd
4269         is present.
4270
4271 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4272
4273         * NEWS: Mention that GDB printf and eval commands can now print
4274         C-style and Ada-style convenience var strings without
4275         calling the inferior.
4276         * printcmd.c (printf_c_string): Locally print GDB internal var
4277         instead of transiting via the inferior.
4278         (printf_wide_c_string): Likewise.
4279
4280 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4281
4282         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4283
4284 2019-07-04  Tom Tromey  <tom@tromey.com>
4285
4286         PR tui/24724:
4287         * tui/tui-winsource.c (tui_clear_source_content): Update.
4288         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4289         (tui_update_breakpoint_info): Update.
4290         (tui_set_exec_info_content): Update.
4291         * tui/tui-source.c (tui_set_source_content_nil): Update.
4292         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4293         has_break.
4294         * tui/tui-data.h (enum tui_bp_flag): New.
4295         (tui_bp_flags): New enum flags type.
4296         (struct tui_source_element) <break_mode>: Change type.  Rename
4297         from has_break.
4298         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4299         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4300         constants.
4301         * tui/tui-winsource.h: Fix comment.
4302
4303 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4304
4305         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4306         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4307         (store_fpregs_to_thread)
4308         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4309         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4310         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4311         (IWMMXT_REGS_SIZE): Add define.
4312         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4313         (fetch_vfp_regs, store_vfp_regs)
4314         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4315         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4316
4317 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4318
4319         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4320         defines.
4321         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4322         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4323         (ARM_INT_REGISTER_SIZE): ...to this.
4324         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4325         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4326         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4327         (arm_linux_collect_gregset, supply_nwfpe_register)
4328         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4329         defines.
4330         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4331         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4332         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4333         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4334         (arm_return_in_memory, arm_store_return_value)
4335         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4336         (arm_record_ld_st_multiple): Likewise.
4337         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4338         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4339
4340 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4341
4342         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4343         AARCH64_DISPLACED_MODIFIED_INSNS.
4344         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4345         (aarch64_displaced_step_copy_insn): Likewise.
4346         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4347         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4348         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4349         ARM_DISPLACED_MODIFIED_INSNS.
4350         * arm-tdep.c (arm_gdbarch_init): Likewise.
4351         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4352         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4353         (struct arm_displaced_step_closure): Use
4354         ARM_DISPLACED_MODIFIED_INSNS.
4355
4356 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4357
4358         * features/Makefile: Remove unused xml files.
4359         * features/aarch64.xml: Remove.
4360         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4361         * features/i386/amd64-avx-avx512.xml: Remove.
4362         * features/i386/amd64-avx-linux.xml: Remove.
4363         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4364         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4365         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4366         * features/i386/amd64-avx-mpx.xml: Remove.
4367         * features/i386/amd64-avx.xml: Remove.
4368         * features/i386/amd64-linux.xml: Remove.
4369         * features/i386/amd64-mpx-linux.xml: Remove.
4370         * features/i386/amd64-mpx.xml: Remove.
4371         * features/i386/amd64.xml: Remove.
4372         * features/i386/i386-avx-avx512-linux.xml: Remove.
4373         * features/i386/i386-avx-avx512.xml: Remove.
4374         * features/i386/i386-avx-linux.xml: Remove.
4375         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4376         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4377         * features/i386/i386-avx-mpx-linux.xml: Remove.
4378         * features/i386/i386-avx-mpx.xml: Remove.
4379         * features/i386/i386-avx.xml: Remove.
4380         * features/i386/i386-linux.xml: Remove.
4381         * features/i386/i386-mmx-linux.xml: Remove.
4382         * features/i386/i386-mmx.xml: Remove.
4383         * features/i386/i386-mpx-linux.xml: Remove.
4384         * features/i386/i386-mpx.xml: Remove.
4385         * features/i386/i386.xml: Remove.
4386         * features/i386/x32-avx-avx512-linux.xml: Remove.
4387         * features/i386/x32-avx-linux.xml: Remove.
4388         * features/i386/x32-linux.xml: Remove.
4389
4390 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4391
4392         * regformats/aarch64.dat: Remove.
4393         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4394         * regformats/i386/amd64-avx-linux.dat: Remove.
4395         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4396         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4397         * regformats/i386/amd64-linux.dat: Remove.
4398         * regformats/i386/amd64-mpx-linux.dat: Remove.
4399         * regformats/i386/amd64.dat: Remove.
4400         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4401         * regformats/i386/i386-avx-linux.dat: Remove.
4402         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4403         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4404         * regformats/i386/i386-linux.dat: Remove.
4405         * regformats/i386/i386-mmx-linux.dat: Remove.
4406         * regformats/i386/i386-mpx-linux.dat: Remove.
4407         * regformats/i386/i386.dat: Remove.
4408         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4409         * regformats/i386/x32-avx-linux.dat: Remove.
4410         * regformats/i386/x32-linux.dat: Remove.
4411
4412 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4413
4414         * aarch64-tdep.c: Remove xml self tests.
4415         * amd64-linux-tdep.c: Likewise.
4416         * amd64-tdep.c: Likewise.
4417         * i386-linux-tdep.c: Likewise.
4418         * i386-tdep.c: Likewise.
4419
4420 2019-07-03  Pedro Alves  <palves@redhat.com>
4421
4422         PR cli/24732
4423         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4424         (pipe_cmd_option_defs): New.
4425         (make_pipe_cmd_options_def_group): New.
4426         (pipe_command): Use gdb::option::process_options.
4427         (pipe_command_completer): New function.
4428         (_initialize_cli_cmds): Install completer for "pipe" command.
4429
4430 2019-07-03  Pedro Alves  <palves@redhat.com>
4431
4432         * cli/cli-option.c (union option_value) <string>: New field.
4433         (struct option_def_and_value): Add ctor, move ctor, dtor and
4434         use DISABLE_COPY_AND_ASSIGN.
4435         (option_def_and_value::clear_value): New.
4436         (parse_option, save_option_value_in_ctx, get_val_type_str)
4437         (add_setshow_cmds_for_options): Handle var_string.
4438         * cli-option.h (union option_def::var_address) <string>: New
4439         field.
4440         (struct string_option_def): New.
4441         * maint-test-options.c (struct test_options_opts): Add default
4442         ctor and use DISABLE_COPY_AND_ASSIGN.
4443         <string_opt>: New field.
4444         (test_options_opts::~test_options_opts): New.
4445         (test_options_opts::dump): Also dump "-string".
4446         (test_options_option_defs): Install "string.
4447
4448 2019-07-03  Pedro Alves  <palves@redhat.com>
4449
4450         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4451         option_value with a null enumeration.
4452         (complete_options): Save the option values in the context.
4453         (save_option_value_in_ctx): New, factored out from ...
4454         (process_options): ... here.
4455         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4456         of the function.
4457         * maint-test-options.c (test_options_opts::dump): New, factored
4458         out from ...
4459         (maintenance_test_options_command_mode): ... here.
4460         (maintenance_test_options_command_completion_result): Delete.
4461         (maintenance_test_options_command_completion_text): Update
4462         comment.
4463         (maintenance_show_test_options_completion_result): Change
4464         prototype.  Just print
4465         maintenance_test_options_command_completion_text.
4466         (save_completion_result): New.
4467         (maintenance_test_options_completer_mode): Pass options context to
4468         complete_options, and then save a dump.
4469         (_initialize_maint_test_options): Use add_cmd to install "maint
4470         show test-options-completion-result".
4471
4472 2019-07-03  Pedro Alves  <palves@redhat.com>
4473
4474         * NEWS (New commands): Mention "with" and "maint with".
4475         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4476         (with_command, with_command_completer): New.
4477         (pipe_command): Adjust to new repeat_previous
4478         interface.
4479         (_initialize_cli_cmds): Install the "with" command and its "w"
4480         alias.
4481         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4482         declarations.
4483         * cli/cli-setshow.c (parse_cli_var_uinteger)
4484         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4485         argument strings for all var_types.
4486         (get_setshow_command_value_string): New, factored out from ...
4487         (do_show_command): ... this.
4488         * cli/cli-setshow.h: Include <string>.
4489         (get_setshow_command_value_string): Declare.
4490         * command.h (repeat_previous): Now returns const char *.  Adjust
4491         comment.
4492         * maint.c: Include "cli/cli-cmds.h".
4493         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4494         (_initialize_maint_cmds): Register the "maintenance with" command.
4495         * top.c (repeat_previous): Move bits from pipe_command here:
4496         Return the saved command line, if any; error out if there's no
4497         command to relaunch.
4498
4499 2019-07-03  Pedro Alves  <palves@redhat.com>
4500
4501         * NEWS (New commands): Mention "maint set/show test-settings"
4502         instead of "maint test-settings".
4503         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4504         (maintenance_test_settings_set_list): Rename to ...
4505         (maintenance_set_test_settings_list): ... this.
4506         (maintenance_test_settings_show_list): Rename to  ...
4507         (maintenance_show_test_settings_list): ... this.
4508         (maintenance_test_settings_cmd): Delete.
4509         (maintenance_test_settings_set_cmd): ...
4510         (maintenance_set_test_settings_cmd): ... this.
4511         (maintenance_test_settings_show_cmd): ...
4512         (maintenance_show_test_settings_cmd): ... this.
4513         (maintenance_test_settings_show_value_cmd):
4514         (maintenance_show_test_settings_value_cmd): ... this.
4515         (_initialize_maint_test_settings): No longer install the "maint
4516         test-settings" prefix command.  Rename "maint test-settings set"
4517         to "maint set test-settings", and "maint test-settings show" to
4518         "maint show test-settings".  Adjust all subcommands.
4519
4520 2019-07-03  Pedro Alves  <palves@redhat.com>
4521
4522         * maint-test-settings.c: Fix file's intro comment.  Replace all
4523         references to "test-options" with references to "test-settings",
4524         in comments.
4525
4526 2019-07-03  Pedro Alves  <palves@redhat.com>
4527
4528         * maint-test-settings.c (maintenance_test_settings_xxx)
4529         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4530         New.
4531         (maintenance_test_settings_enums): Use them.
4532         (maintenance_test_settings_enum): Default to
4533         maintenance_test_settings_xxx.
4534         (_initialize_maint_test_settings): Initialize
4535         MAINTENANCE_TEST_SETTINGS_FILENAME.
4536
4537 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4538
4539         * breakpoint.h (remove_breakpoints_inf): Change return type to
4540         void, move function documentation here.
4541         * breakpoint.c (remove_breakpoints_inf): Change return type to
4542         void, move function documentation to header.
4543
4544 2019-07-02  Pedro Alves  <palves@redhat.com>
4545
4546         * NEWS (Completion improvements): Mention "info threads".
4547         * thread.c (struct info_threads_opts, info_threads_option_defs)
4548         (make_info_threads_options_def_group): New.
4549         (info_threads_command): Use gdb::option::process_options.
4550         (info_threads_command_completer): New.
4551         (_initialize_thread): Use gdb::option::build_help to build the
4552         help text for "info threads".
4553
4554 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4555
4556         * defs.h (generic_load): Move from here...
4557         * symfile.h (generic_load): ... to here.  Rename name parameter
4558         to args.
4559         * symfile.c (generic_load): Add comment.
4560
4561 2019-07-01  Tom Tromey  <tromey@adacore.com>
4562
4563         * dwarf2read.c
4564         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4565         declaration of without_params.  Fix formatting.
4566
4567 2019-07-01  Tom Tromey  <tromey@adacore.com>
4568
4569         * ada-exp.y (find_primitive_type): Update.
4570         * ada-lang.h (ada_lookup_symbol): Update.
4571         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4572         parameter.
4573         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4574
4575 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4576
4577         PR breakpoints/24541
4578         * gdbarch.c: Regenerate.
4579         * gdbarch.h: Regenerate.
4580         * gdbarch.sh: Add 'stap_adjust_register'.
4581         * i386-tdep.c: Include '<unordered_set>'.
4582         (i386_stap_adjust_register): New function.
4583         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4584         * stap-probe.c (stap_parse_register_operand): Call
4585         'gdbarch_stap_adjust_register'.
4586
4587 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4588
4589         PR python/24742
4590         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4591         * python/python.c (do_start_initialization): Use 'xmalloc'
4592         instead of 'PyMem_Malloc'.
4593
4594 2019-06-28  Tom Tromey  <tromey@adacore.com>
4595
4596         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4597         for Ada.
4598
4599 2019-06-27  Tom Tromey  <tromey@adacore.com>
4600
4601         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4602         objfile_key.
4603         (arm_find_mapping_symbol, arm_record_special_symbol)
4604         (_initialize_arm_tdep): Update.
4605         (arm_objfile_data_free): Remove.
4606
4607 2019-06-27  Tom Tromey  <tromey@adacore.com>
4608
4609         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4610         to cp_print_static_field.
4611
4612 2019-06-26  Tom Tromey  <tromey@adacore.com>
4613
4614         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4615         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4616         declare.
4617
4618 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4619
4620         * features/aarch64-core.c (create_feature_aarch64_core):
4621         Regenerate.
4622         * features/aarch64-core.xml: Add cpsr flags.
4623
4624 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4625
4626         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4627         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4628
4629 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4630
4631         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4632         field.
4633         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4634         use.
4635         (arm_record_special_symbol): Don't insert new symbol in sorted
4636         position, push it at the end.
4637
4638 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4639
4640         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4641         (arm_mapping_symbol_s): Remove.
4642         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4643         (arm_mapping_symbol_vec): New typedef.
4644         (struct arm_per_objfile): Add constructor.
4645         <section_maps>: Change type to
4646         std::unique_ptr<arm_mapping_symbol_vec[]>.
4647         (arm_compare_mapping_symbols): Remove.
4648         (arm_find_mapping_symbol): Adjust to section_maps type change.
4649         (arm_objfile_data_free): Call delete on arm_per_objfile.
4650         (arm_record_special_symbol): Adjust to section_maps type change.
4651         Allocate arm_per_objfile with new.
4652
4653 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4654
4655         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4656         with the command prefix.
4657
4658 2019-06-25  Tom Tromey  <tom@tromey.com>
4659
4660         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4661         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4662
4663 2019-06-25  Tom Tromey  <tom@tromey.com>
4664
4665         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4666         type.
4667         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4668         protected.
4669
4670 2019-06-25  Tom Tromey  <tom@tromey.com>
4671
4672         * tui/tui-winsource.c
4673         (tui_source_window_base::set_is_exec_point_at): Add check against
4674         LOA_ADDRESS.
4675
4676 2019-06-25  Tom Tromey  <tom@tromey.com>
4677
4678         * tui/tui-source.c (tui_set_source_content): Don't check before
4679         xfree.
4680         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4681
4682 2019-06-25  Tom Tromey  <tom@tromey.com>
4683
4684         * tui/tui-winsource.h (tui_update_source_window_as_is)
4685         (tui_alloc_source_buffer, tui_line_is_displayed)
4686         (tui_addr_is_displayed): Change type of win_info.
4687         * tui/tui-winsource.c (tui_update_source_window_as_is)
4688         (tui_clear_source_content, tui_show_source_line)
4689         (tui_show_source_content, tui_source_window_base::refill)
4690         (tui_source_window_base::set_is_exec_point_at)
4691         (tui_source_window_base::set_is_exec_point_at)
4692         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4693         (tui_alloc_source_buffer, tui_line_is_displayed)
4694         (tui_addr_is_displayed): Change type of win_info.  Update.
4695         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4696         (tui_source_window_base::do_make_visible_with_new_height):
4697         Update.
4698         * tui/tui-source.c (tui_set_source_content)
4699         (tui_set_source_content_nil)
4700         (tui_source_window::do_scroll_vertical): Update.
4701         * tui/tui-layout.c (show_layout): Update.
4702         * tui/tui-disasm.c (tui_set_disassem_content)
4703         (tui_disasm_window::do_scroll_vertical): Update.
4704         * tui/tui-data.h (tui_win_content): Remove.
4705         (struct tui_gen_win_info) <content, content_size>: Remove.
4706         (struct tui_source_element): Add initializers and destructor.
4707         (union tui_which_element, struct tui_win_element): Remove.
4708         (struct tui_source_window_base) <content>: New field.
4709         (struct tui_data_window): Remove destructor.
4710         (tui_alloc_content, tui_free_win_content)
4711         (tui_free_all_source_wins_content): Don't declare.
4712         * tui/tui-data.c (tui_initialize_static_data): Update.
4713         (init_content_element, tui_alloc_content): Remove.
4714         (~tui_gen_win_info): Update.
4715         (~tui_data_window, tui_free_all_source_wins_content)
4716         (tui_free_win_content, free_content, free_content_elements):
4717         Remove.
4718
4719 2019-06-25  Tom Tromey  <tom@tromey.com>
4720
4721         * tui/tui-winsource.h (tui_clear_source_content)
4722         (tui_erase_source_content, tui_show_source_content): Change type
4723         of win_info.
4724         * tui/tui-winsource.c (tui_clear_source_content)
4725         (tui_erase_source_content, tui_show_source_content): Change type
4726         of win_info.
4727         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4728         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4729         win_info.
4730         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4731         win_info.
4732         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4733
4734 2019-06-25  Tom Tromey  <tom@tromey.com>
4735
4736         * tui/tui-winsource.c (tui_clear_source_content)
4737         (tui_source_window_base::set_is_exec_point_at): Update.
4738         * tui/tui-source.c (tui_set_source_content_nil): Update.
4739         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4740         a bool.
4741         * tui/tui-data.c (init_content_element): Update.
4742
4743 2019-06-25  Tom Tromey  <tom@tromey.com>
4744
4745         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4746         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4747         * tui/tui-layout.c (init_and_make_win): Update.
4748         * tui/tui.h (enum tui_win_type): Update.
4749         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4750         tui_win_is_auxillary.
4751         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4752         tui_win_is_auxillary.
4753
4754 2019-06-25  Tom Tromey  <tom@tromey.com>
4755
4756         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4757         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4758         (tui_delete_data_content_windows, tui_display_all_data)
4759         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4760         Update.
4761         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4762         * tui/tui-regs.c (tui_last_regs_line_no)
4763         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4764         (tui_show_registers): Update.
4765         (tui_show_register_group): Return void.  Update.
4766         (tui_display_registers_from, tui_display_reg_element_at_line)
4767         (tui_display_registers_from_line, tui_check_register_values):
4768         Update.
4769         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4770         member.
4771         (struct tui_data_window) <regs_content>: Now a std::vector.
4772         <regs_content_count>: Remove.
4773         (tui_add_content_elements, tui_free_data_content): Don't declare.
4774         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4775         (init_content_element): Remove DATA_WIN case.  Add assert.
4776         (tui_add_content_elements): Remove.
4777         (tui_data_window): Update.
4778         (tui_free_data_content): Remove.
4779         (free_content_elements): Remove DATA_WIN case.
4780
4781 2019-06-25  Tom Tromey  <tom@tromey.com>
4782
4783         * tui/tui-data.c (tui_data_item_window): Update.
4784         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4785         * tui/tui-windata.c (tui_display_all_data)
4786         (tui_display_data_from_line): Update.
4787         (tui_check_data_values): Remove.
4788         * tui/tui-regs.c (tui_show_register_group)
4789         (tui_display_reg_element_at_line): Update.
4790         * tui/tui-hooks.c (tui_register_changed)
4791         (tui_refresh_frame_and_register_information): Call
4792         tui_check_register_values.
4793         * tui/tui-data.h (struct tui_data_window) <data_content,
4794         data_content_count, data_type>: Remove.
4795         (enum tui_data_type): Remove.
4796
4797         * tui/tui-data.c (tui_data_window::clear_detail)
4798         (~tui_data_window): Update.
4799
4800 2019-06-25  Tom Tromey  <tom@tromey.com>
4801
4802         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4803         declare.
4804         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4805         Rename from tui_first_data_item_displayed.  Update.
4806         (tui_data_window::refresh_all)
4807         (tui_data_window::do_scroll_vertical): Update.
4808         * tui/tui-data.h (struct tui_data_window)
4809         <first_data_item_displayed>: Declare new method.
4810
4811 2019-06-25  Tom Tromey  <tom@tromey.com>
4812
4813         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4814         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4815         contents...
4816         (tui_initialize_static_data): ...here.
4817
4818 2019-06-25  Tom Tromey  <tom@tromey.com>
4819
4820         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4821         (tui_display_registers_from, tui_check_register_values): Update.
4822         (tui_display_register): Remove win_info parameter; update.
4823         (tui_get_register): Change type of parameters.
4824         * tui/tui-data.h (struct tui_data_element): Remove.
4825         (union tui_which_element) <data>: Remove.
4826         <data_window>: Change type.
4827         (struct tui_data_item_window): New.
4828         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4829         case.  Add assert.
4830         (~tui_data_item_window): New destructor.
4831         (free_content_elements): Remove DATA_ITEM_WIN case.
4832
4833 2019-06-25  Tom Tromey  <tom@tromey.com>
4834
4835         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4836         Remove.
4837
4838 2019-06-25  Tom Tromey  <tom@tromey.com>
4839
4840         * tui/tui-data.h (struct tui_command_element): Remove.
4841         (union tui_which_element) <command>: Remove.
4842         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4843         assert.
4844         (free_content_elements): Remove CMD_WIN case.
4845
4846 2019-06-25  Tom Tromey  <tom@tromey.com>
4847
4848         * tui/tui-layout.c (tui_set_layout): Update.
4849         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4850         * tui/tui-data.c (layout_def): Update.
4851
4852 2019-06-25  Tom Tromey  <tom@tromey.com>
4853
4854         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4855         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4856         (tui_source_window_base::set_new_height): Update.
4857         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4858         Update.
4859         (tui_set_locator_fullname, tui_set_locator_info)
4860         (tui_show_frame_info): Update.
4861         * tui/tui-source.c (tui_set_source_content)
4862         (tui_source_is_displayed): Update.
4863         * tui/tui-layout.c (show_source_disasm_command, show_data)
4864         (show_source_or_disasm_and_command): Update.
4865         * tui/tui-disasm.c (tui_set_disassem_content)
4866         (tui_get_begin_asm_address): Update.
4867         * tui/tui-data.h (struct tui_locator_element): Remove.
4868         (union tui_which_element) <locator>: Remove.
4869         (struct tui_locator_window): New.
4870         (tui_locator_win_info_ptr): Change return type.
4871         * tui/tui-data.c (_locator): Change type.
4872         (tui_locator_win_info_ptr): Change return type.
4873         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4874         (tui_alloc_content): Add assert.
4875
4876 2019-06-25  Tom Tromey  <tom@tromey.com>
4877
4878         * tui/tui-winsource.c
4879         (tui_exec_info_window::maybe_allocate_content): New method.
4880         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4881         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4882         (make_source_or_disasm_window): Add cast.
4883         * tui/tui-data.h (union tui_which_element) <simple_string>:
4884         Remove.
4885         (struct tui_source_info): New.
4886         (struct tui_source_window_base) <execution_info>: Change type.
4887         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4888         case, and add assert.
4889         (tui_alloc_content): Add assert.
4890
4891 2019-06-25  Tom Tromey  <tom@tromey.com>
4892
4893         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4894         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4895         * tui/tui-data.c (tui_alloc_win_info): Remove.
4896
4897 2019-06-25  Tom Tromey  <tom@tromey.com>
4898
4899         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4900         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4901         can_highlight.
4902
4903 2019-06-25  Tom Tromey  <tom@tromey.com>
4904
4905         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4906         make_visible_with_new_height method.
4907         (tui_win_info::make_visible_with_new_height): New method.
4908         (tui_source_window_base::do_make_visible_with_new_height)
4909         (tui_data_window::do_make_visible_with_new_height)
4910         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4911         (make_visible_with_new_height): Remove.
4912         (tui_resize_all, tui_adjust_win_heights): Use
4913         make_visible_with_new_height method.
4914         * tui/tui-data.h (struct tui_win_info)
4915         <do_make_visible_with_new_height, make_visible_with_new_height>:
4916         New methods.
4917         (struct tui_source_window_base, struct tui_data_window)
4918         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4919         methods.
4920
4921 2019-06-25  Tom Tromey  <tom@tromey.com>
4922
4923         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4924         method.
4925         (update_tab_width): Call update_tab_width method.
4926         * tui/tui-data.h (struct tui_win_info)
4927         (struct tui_source_window_base) <update_tab_width>: New methods.
4928
4929 2019-06-25  Tom Tromey  <tom@tromey.com>
4930
4931         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4932         parameter.
4933         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4934         parameter.
4935         (tui_gen_win_info::make_visible): Update.
4936         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4937         parameter.
4938         * tui/tui-data.h (enum tui_box): New enum.
4939         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4940
4941 2019-06-25  Tom Tromey  <tom@tromey.com>
4942
4943         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4944         init_and_make_win for EXEC_INFO_WIN.
4945         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4946         longer inline.
4947         (struct tui_win_info) <~tui_win_info>: Inline.
4948         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4949         Don't declare.
4950         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4951         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4952         Remove.
4953         (tui_initialize_static_data): Update.
4954         (~tui_gen_win_info): Handle more cleanup here.
4955         (~tui_source_window_base): Delete "execution_info".
4956         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4957
4958 2019-06-25  Tom Tromey  <tom@tromey.com>
4959
4960         * tui/tui-layout.c (make_command_window): Don't set
4961         can_highlight.
4962         (show_source_disasm_command): Call the reset method.
4963         (show_data): Don't set can_highlight.  Call the reset method.
4964         (tui_gen_win_info::reset): Rename from init_gen_win_info
4965         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4966         (show_source_or_disasm_and_command): Call the reset method.
4967         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4968         (struct tui_cmd_window): Set can_highlight.
4969
4970 2019-06-25  Tom Tromey  <tom@tromey.com>
4971
4972         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4973         from make_visible.
4974         (tui_make_visible, tui_make_invisible): Rewrite.
4975         (tui_win_info::make_visible): Remove.
4976         (tui_source_window_base::make_visible): Update.
4977         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4978         method.  Moved from...
4979         (struct tui_win_info) <make_visible>: ...here.
4980
4981 2019-06-25  Tom Tromey  <tom@tromey.com>
4982
4983         * tui/tui-winsource.c
4984         (tui_source_window_base::do_scroll_horizontal): Remove direction
4985         parameter.
4986         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4987         direction parameter.
4988         * tui/tui-win.c (tui_win_info::forward_scroll)
4989         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4990         (tui_win_info::right_scroll): Update.
4991         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4992         direction parameter.
4993         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4994         direction parameter.
4995         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4996         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4997         Remove direction parameter.
4998         (struct tui_source_window_base, struct tui_source_window)
4999         (struct tui_disasm_window, struct tui_data_window)
5000         (struct tui_cmd_window): Update.
5001
5002 2019-06-25  Tom Tromey  <tom@tromey.com>
5003
5004         * tui/tui-winsource.h (tui_set_exec_info_content)
5005         (tui_show_exec_info_content, tui_erase_exec_info_content)
5006         (tui_clear_exec_info_content, tui_update_exec_info): Change
5007         argument to tui_source_window_base.
5008         * tui/tui-winsource.c (tui_set_exec_info_content)
5009         (tui_show_exec_info_content, tui_erase_exec_info_content)
5010         (tui_clear_exec_info_content, tui_update_exec_info): Change
5011         argument to tui_source_window_base.
5012
5013 2019-06-25  Tom Tromey  <tom@tromey.com>
5014
5015         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5016         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5017
5018 2019-06-25  Tom Tromey  <tom@tromey.com>
5019
5020         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5021         check.
5022
5023 2019-06-25  Tom Tromey  <tom@tromey.com>
5024
5025         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5026         type to void.
5027         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5028         type to void.
5029         * tui/tui-source.c (tui_set_source_content): Update.
5030         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5031
5032 2019-06-25  Tom Tromey  <tom@tromey.com>
5033
5034         * tui/tui-win.c (window_name_completer, tui_set_focus)
5035         (tui_all_windows_info): Use name method.
5036         * tui/tui-data.h (struct tui_gen_win_info)
5037         (struct tui_source_window, struct tui_disasm_window)
5038         (struct tui_data_window, struct tui_cmd_window) <name>: New
5039         method.
5040         (tui_win_name): Don't declare.
5041         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5042         (tui_win_name): Remove.
5043
5044 2019-06-25  Tom Tromey  <tom@tromey.com>
5045
5046         * tui/tui-winsource.h (tui_update_source_window)
5047         (tui_update_source_window_as_is): Change parameter type.
5048         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5049         to be a tui_source_window_base.
5050         (tui_update_source_window_as_is): Likewise.
5051         * tui/tui-win.c (make_visible_with_new_height): Update.
5052
5053 2019-06-25  Tom Tromey  <tom@tromey.com>
5054
5055         * tui/tui-winsource.c (tui_erase_source_content)
5056         (tui_show_source_content, tui_show_exec_info_content)
5057         (tui_erase_exec_info_content): Use refresh_window method.
5058         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5059         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5060         from tui_refresh_win.
5061         (tui_data_window::refresh_window): New method.
5062         (tui_win_info::refresh, tui_source_window_base::refresh)
5063         (tui_refresh_all): Use refresh_window method.
5064         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5065         method.
5066         * tui/tui-regs.c (tui_display_register): Call refresh_window
5067         method.
5068         * tui/tui-layout.c (show_source_disasm_command)
5069         (show_source_or_disasm_and_command): Call refresh_window method.
5070         * tui/tui-data.h (struct tui_gen_win_info)
5071         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5072         New method.
5073
5074 2019-06-25  Tom Tromey  <tom@tromey.com>
5075
5076         * tui/tui.c (tui_rl_other_window, tui_enable)
5077         (tui_is_window_visible, tui_get_command_dimension): Update.
5078         * tui/tui-winsource.c (tui_update_source_window_as_is)
5079         (tui_clear_source_content, tui_erase_source_content)
5080         (tui_show_source_line, tui_source_window_base::refill)
5081         (tui_source_window_base::do_scroll_horizontal)
5082         (tui_source_window_base::set_is_exec_point_at)
5083         (tui_update_breakpoint_info, tui_set_exec_info_content)
5084         (tui_alloc_source_buffer, tui_line_is_displayed)
5085         (tui_addr_is_displayed): Update.
5086         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5087         (tui_check_and_display_highlight_if_needed)
5088         (tui_win_info::make_visible, tui_win_info::refresh)
5089         (tui_refresh_all): Update.
5090         * tui/tui-windata.c (tui_first_data_item_displayed)
5091         (tui_delete_data_content_windows, tui_erase_data_content)
5092         (tui_display_all_data, tui_data_window::refresh_all)
5093         (tui_check_data_values): Update.
5094         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5095         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5096         (tui_win_info::backward_scroll, tui_refresh_all_win)
5097         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5098         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5099         (tui_source_window_base::set_new_height)
5100         (tui_data_window::set_new_height)
5101         (make_invisible_and_set_new_height)
5102         (make_visible_with_new_height, new_height_ok)
5103         (parse_scrolling_args): Update.
5104         * tui/tui-stack.c (tui_show_frame_info): Update.
5105         * tui/tui-source.c (tui_set_source_content)
5106         (tui_set_source_content_nil, tui_source_is_displayed)
5107         (tui_source_window::do_scroll_vertical): Update.
5108         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5109         (tui_display_registers_from, tui_display_reg_element_at_line)
5110         (tui_check_register_values, tui_reg_command): Update.
5111         * tui/tui-layout.c (tui_default_win_height)
5112         (show_source_disasm_command, show_data, init_and_make_win)
5113         (show_source_or_disasm_and_command): Update.
5114         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5115         (tui_redisplay_readline, tui_mld_flush)
5116         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5117         (tui_getc): Update.
5118         * tui/tui-disasm.c (tui_set_disassem_content)
5119         (tui_disasm_window::do_scroll_vertical): Update.
5120         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5121         Now virtual.
5122         (struct tui_win_info): Derive from tui_gen_win_info.
5123         <~tui_win_info>: Mark as override.
5124         <generic>: Remove member.
5125         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5126         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5127         (~tui_data_window, ~tui_win_info)
5128         (tui_free_all_source_wins_content): Update.
5129         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5130
5131 2019-06-25  Tom Tromey  <tom@tromey.com>
5132
5133         * tui/tui-layout.c (init_and_make_win): Use new.
5134         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5135         destructor, initializers.
5136         (tui_alloc_generic_win_info): Don't declare.
5137         * tui/tui-data.c (_locator): Add argument to constructor.
5138         (source_win, disasm_win): New globals.
5139         (exec_info): Remove.
5140         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5141         Update.
5142         (tui_alloc_generic_win_info): Remove.
5143         (init_content_element): Use new.
5144         (tui_win_info::tui_win_info): Update.
5145         (free_content_elements) <case DATA_WIN>: Use delete.
5146
5147 2019-06-25  Tom Tromey  <tom@tromey.com>
5148
5149         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5150         * tui/tui-windata.c (tui_first_data_item_displayed)
5151         (tui_delete_data_content_windows): Update.
5152         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5153         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5154         (tui_display_registers_from, tui_check_register_values): Update.
5155         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5156         pointer.
5157         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5158         window.
5159         (tui_free_data_content): Update.
5160         (free_content_elements) <case DATA_WIN>: Free the window.
5161
5162 2019-06-25  Tom Tromey  <tom@tromey.com>
5163
5164         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5165         Update.
5166         * tui/tui-layout.c (make_command_window)
5167         (show_source_disasm_command, show_data, init_and_make_win)
5168         (show_source_or_disasm_and_command): Update.
5169         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5170         method.
5171         <can_highight, is_highlighted>: Now bool.
5172         (tui_set_win_highlight): Don't declare.
5173         * tui/tui-data.c (tui_set_win_highlight): Remove.
5174
5175 2019-06-25  Tom Tromey  <tom@tromey.com>
5176
5177         * tui/tui-wingeneral.c (make_visible): Remove check of window
5178         type.
5179
5180 2019-06-25  Tom Tromey  <tom@tromey.com>
5181
5182         * tui/tui-win.c (tui_win_info::max_height)
5183         (tui_cmd_window::max_height): New methods.
5184         (new_height_ok): Call max_height.
5185         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5186         <max_height>: New method.
5187
5188 2019-06-25  Tom Tromey  <tom@tromey.com>
5189
5190         * tui/tui-win.c (tui_source_window_base::set_new_height)
5191         (tui_data_window::set_new_height): New methods.
5192         (make_invisible_and_set_new_height): Call set_new_height method.
5193         * tui/tui-data.h (struct tui_win_info)
5194         (struct tui_source_window_base, struct tui_data_window)
5195         <set_new_height>: New method.
5196
5197 2019-06-25  Tom Tromey  <tom@tromey.com>
5198
5199         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5200         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5201         tui_refresh_data_win.
5202         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5203         method.
5204         (tui_refresh_all_win): Call the refresh_all method.
5205         (tui_set_focus): Likewise.
5206         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5207         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5208         Likewise.
5209
5210 2019-06-25  Tom Tromey  <tom@tromey.com>
5211
5212         * tui/tui-winsource.h (tui_refill_source_window)
5213         (tui_set_is_exec_point_at): Don't declare.
5214         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5215         (tui_source_window_base::refill): Rename from
5216         tui_refill_source_window.
5217         (tui_source_window_base::do_scroll_horizontal): Update.
5218         (tui_source_window_base::set_is_exec_point_at): Rename from
5219         tui_set_is_exec_point_at.
5220         (tui_update_all_breakpoint_info): Update.
5221         * tui/tui-stack.c (tui_show_frame_info): Update.
5222         * tui/tui-layout.c (show_data): Add cast.
5223         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5224         * tui/tui-data.h (struct tui_source_window_base) <refill,
5225         set_is_exec_point_at>: New methods.
5226         (tui_source_windows, tui_add_to_source_windows): Update types.
5227         (tui_add_to_source_windows): Remove redundant declaration.
5228         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5229         (tui_source_windows): Change return type.
5230         (tui_clear_source_windows_detail): Update.
5231         (tui_add_to_source_windows): Change type of parameter.
5232         (tui_free_all_source_wins_content): Update.
5233
5234 2019-06-25  Tom Tromey  <tom@tromey.com>
5235
5236         * tui/tui-wingeneral.c (tui_win_info::refresh)
5237         (tui_source_window_base::refresh): New methods.
5238         (tui_refresh_all): Call the refresh method.
5239         * tui/tui-data.h (struct tui_win_info)
5240         (struct tui_source_window_base) <refresh>: New method.
5241
5242 2019-06-25  Tom Tromey  <tom@tromey.com>
5243
5244         * tui/tui.h (tui_is_window_visible): Return bool.
5245         * tui/tui.c (tui_is_window_visible): Return bool.
5246         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5247         (tui_make_visible, tui_make_invisible)
5248         (tui_win_info::make_visible)
5249         (tui_source_window_base::make_visible, make_all_visible)
5250         (tui_make_all_visible, tui_make_all_invisible): Update.
5251         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5252         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5253         bool.
5254         (struct tui_win_info, struct tui_source_window_base)
5255         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5256         * tui/tui-data.c (tui_init_generic_part): Update.
5257
5258 2019-06-25  Tom Tromey  <tom@tromey.com>
5259
5260         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5261         (tui_source_window_base::make_visible): New methods.
5262         (make_all_visible): Make method call.
5263         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5264         (struct tui_source_window_base, struct tui_cmd_window): Override
5265         make_visible.
5266         (tui_win_is_source_type): Don't declare.
5267         * tui/tui-data.c (tui_win_is_source_type): Remove.
5268
5269 2019-06-25  Tom Tromey  <tom@tromey.com>
5270
5271         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5272         NULL check.
5273
5274 2019-06-25  Tom Tromey  <tom@tromey.com>
5275
5276         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5277         Inline constructor.  Add initializers for members.
5278         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5279         constructors; now inline in class.
5280
5281 2019-06-25  Tom Tromey  <tom@tromey.com>
5282
5283         * tui/tui-regs.c (tui_show_registers): Update.
5284         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5285         bool.
5286         * tui/tui-data.c (tui_data_window::clear_detail)
5287         (tui_data_window): Update.
5288
5289 2019-06-25  Tom Tromey  <tom@tromey.com>
5290
5291         * tui/tui-windata.c (tui_display_all_data)
5292         (tui_display_data_from_line, tui_display_data_from)
5293         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5294         Update.
5295         * tui/tui-regs.c (tui_last_regs_line_no)
5296         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5297         (tui_show_registers, tui_show_register_group)
5298         (tui_display_registers_from, tui_display_reg_element_at_line)
5299         (tui_display_registers_from_line, tui_check_register_values)
5300         (tui_reg_next, tui_reg_prev): Update.
5301         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5302         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5303         tui_data_window.
5304         (struct tui_win_info) <detail>: Remove.  Add new fields from
5305         tui_data_info.
5306         (TUI_DATA_WIN): Add cast.
5307         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5308         (~tui_data_window): Simplify.
5309
5310 2019-06-25  Tom Tromey  <tom@tromey.com>
5311
5312         * tui/tui-layout.c (show_source_disasm_command)
5313         (show_source_or_disasm_and_command): Update.
5314         * tui/tui-io.c (update_cmdwin_start_line)
5315         (tui_redisplay_readline): Update.
5316         * tui/tui-data.h (struct tui_command_info): Remove.
5317         (struct tui_win_info) <detail>: Remove command_info member.
5318         (struct tui_data_window) <start_line>: New member, from
5319         tui_command_info.
5320         (TUI_CMD_WIN): Add casts.
5321
5322 2019-06-25  Tom Tromey  <tom@tromey.com>
5323
5324         * tui/tui-winsource.c (tui_update_source_window)
5325         (tui_refill_source_window)
5326         (tui_source_window_base::do_scroll_horizontal)
5327         (tui_update_breakpoint_info, tui_set_exec_info_content)
5328         (tui_show_exec_info_content, tui_erase_exec_info_content)
5329         (tui_clear_exec_info_content): Update.
5330         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5331         Update.
5332         * tui/tui-win.c (make_invisible_and_set_new_height)
5333         (make_visible_with_new_height): Update.
5334         * tui/tui-source.c (tui_set_source_content)
5335         (tui_show_symtab_source): Update.
5336         * tui/tui-layout.c (extract_display_start_addr)
5337         (show_source_disasm_command, show_data)
5338         (make_source_or_disasm_window)
5339         (show_source_or_disasm_and_command): Update.
5340         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5341         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5342         "gdbarch".
5343         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5344         to tui_source_window_base.
5345         (struct tui_win_info) <detail>: Remove source_info member.
5346         (struct tui_source_window_base) <has_locator>: Inline.
5347         Move contents from tui_source_info; rename has_locator member to
5348         m_has_locator.
5349         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5350         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5351         header file.
5352         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5353         Simplify.
5354         (tui_free_all_source_wins_content): Cast to
5355         tui_source_window_base.
5356
5357 2019-06-25  Tom Tromey  <tom@tromey.com>
5358
5359         * tui/tui-win.c (make_invisible_and_set_new_height)
5360         (make_visible_with_new_height): Call has_locator method.
5361         * tui/tui-layout.c (show_source_disasm_command, show_data)
5362         (show_source_or_disasm_and_command): Update for bool change.
5363         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5364         (tui_win_info) <has_locator>: New method.
5365         (struct tui_source_window_base) <has_locator>: New method.
5366         (tui_win_has_locator): Don't declare.
5367         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5368         from tui_win_has_locator.
5369         (tui_source_window_base): Use false, not FALSE.
5370
5371 2019-06-25  Tom Tromey  <tom@tromey.com>
5372
5373         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5374         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5375         clear_detail method directly.
5376         (tui_clear_win_detail): Remove.
5377
5378 2019-06-25  Tom Tromey  <tom@tromey.com>
5379
5380         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5381         "this", not TUI_DISASM_WIN.
5382
5383 2019-06-25  Tom Tromey  <tom@tromey.com>
5384
5385         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5386         declare.
5387         * tui/tui-winsource.c
5388         (tui_source_window_base::do_scroll_horizontal): Rename from
5389         tui_horizontal_source_scroll.
5390         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5391         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5392         from tui_vertical_data_scroll.
5393         * tui/tui-win.h (tui_scroll): Don't declare.
5394         * tui/tui-win.c (tui_win_info::forward_scroll)
5395         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5396         (tui_win_info::right_scroll): Rename and update.
5397         (tui_scroll_forward_command, tui_scroll_backward_command)
5398         (tui_scroll_left_command, tui_scroll_right_command): Update.
5399         (tui_scroll): Remove.
5400         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5401         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5402         from tui_vertical_source_scroll.
5403         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5404         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5405         from tui_vertical_disassem_scroll.
5406         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5407         do_scroll_horizontal>: New methods.
5408         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5409         Likewise.
5410         (struct tui_source_window_base): Add do_scroll_horizontal.
5411         (struct tui_source_window, struct tui_disasm_window): Add
5412         do_scroll_vertical.
5413         (struct tui_data_window, struct tui_cmd_window): Add
5414         do_scroll_horizontal and do_scroll_vertical.
5415         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5416
5417 2019-06-25  Tom Tromey  <tom@tromey.com>
5418
5419         * tui/tui-data.h (struct tui_source_window_base): New struct.
5420         (struct tui_source_window): Derive from tui_source_window_base.
5421         (struct tui_disasm_window): New struct.
5422         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5423         from tui_source_window::clear_detail.
5424         (tui_source_window_base): Rename from tui_source_window.
5425         (~tui_source_window_base): Rename from ~tui_source_window.
5426         (tui_alloc_win_info): Create a tui_disasm_window.
5427
5428 2019-06-25  Tom Tromey  <tom@tromey.com>
5429
5430         * tui/tui-data.h (struct tui_source_window)
5431         (struct tui_data_window): Declare destructors.
5432         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5433         destructors.
5434         (tui_win_info): Simplify.
5435
5436 2019-06-25  Tom Tromey  <tom@tromey.com>
5437
5438         * tui/tui-winsource.c (tui_display_main)
5439         (tui_update_source_windows_with_addr)
5440         (tui_update_all_breakpoint_info): Update.
5441         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5442         (new_height_ok, parse_scrolling_args): Update.
5443         * tui/tui-stack.c (tui_show_frame_info): Update.
5444         * tui/tui-data.h (struct tui_list): Remove.
5445         (tui_source_windows): Return a reference to a std::vector.
5446         * tui/tui-data.c (source_windows): Now a std::vector.
5447         (tui_source_windows): Change return type.
5448         (tui_clear_source_windows): Rewrite.
5449         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5450         (tui_free_all_source_wins_content): Rewrite.
5451
5452 2019-06-25  Tom Tromey  <tom@tromey.com>
5453
5454         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5455         (struct tui_data_window, struct tui_cmd_window): Declare
5456         clear_detail method.
5457         * tui/tui-data.c (tui_source_window::clear_detail)
5458         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5459         methods.
5460         (tui_clear_win_detail): Simplify.
5461
5462 2019-06-25  Tom Tromey  <tom@tromey.com>
5463
5464         * tui/tui-layout.c (make_source_window, make_disasm_window)
5465         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5466         Return the new window.
5467         (show_source_disasm_command, show_data)
5468         (show_source_or_disasm_and_command): Update.
5469
5470 2019-06-25  Tom Tromey  <tom@tromey.com>
5471
5472         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5473         parameter.  Return the new window.
5474         (show_source_disasm_command): Update and remove NULL check.
5475         (show_source_or_disasm_and_command): Update.
5476
5477 2019-06-25  Tom Tromey  <tom@tromey.com>
5478
5479         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5480
5481 2019-06-25  Tom Tromey  <tom@tromey.com>
5482
5483         * tui/tui-data.h (struct tui_win_info): Make constructor
5484         protected.  Make destructor virtual.  Add initializers.
5485         (tui_source_window, tui_data_window, tui_cmd_window): New
5486         classes.
5487         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5488         constructor.  Add "type" parameter.
5489         (tui_source_window, tui_data_window, tui_cmd_window): New
5490         constructors.
5491         (tui_alloc_win_info): Instantiate the appropriate subclass.
5492
5493 2019-06-25  Tom Tromey  <tom@tromey.com>
5494
5495         * tui/tui-win.c (tui_resize_all): Use delete.
5496         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5497         destructor.
5498         (tui_free_window): Don't declare.
5499         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5500         Update.
5501
5502 2019-06-25  Tom Tromey  <tom@tromey.com>
5503
5504         * tui/tui-data.h (struct tui_win_info): Add constructor.
5505         * tui/tui-data.c (tui_alloc_win_info): Use new.
5506         (tui_free_window): Use delete.
5507
5508 2019-06-22  Tom Tromey  <tom@tromey.com>
5509
5510         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5511         declare.
5512         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5513
5514 2019-06-22  Tom Tromey  <tom@tromey.com>
5515
5516         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5517         declare.
5518         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5519
5520 2019-06-22  Tom de Vries  <tdevries@suse.de>
5521
5522         * dwarf2read.c (create_addrmap_from_aranges)
5523         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5524         instead of '%zu'.
5525
5526 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5527
5528         * dwarf2read.h (dwarf2_section_info_def): Remove.
5529         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5530         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5531         std::vector<dwarf2_section_info>.
5532         (struct dwo_file) <~dwo_file>: Remove.
5533         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5534         types field.
5535         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5536         (dwarf2_read_debug_names): Likewise.
5537         (create_debug_types_hash_table): Change parameter type to
5538         array_view, adjust code accordingly.
5539         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5540         (partial_die_info::fixup): Likewise.
5541         (determine_prefix): Likewise.
5542         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5543
5544 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5545
5546         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5547         gdb_bfd_ref_ptr.
5548         <~dwo_file>: Remove call to gdb_bfd_unref.
5549         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5550         gdb_bfd_ref_ptr::get.
5551
5552 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5553
5554         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5555         type to htab_up.
5556         * dwarf2read.c (struct dwo_file): Initialize fields.
5557         <~dwo_file>: New.
5558         (free_dwo_file): Remove, move content to ~dwo_file.
5559         (struct dwo_file_deleter): Remove.
5560         (dwo_file_up>: Remove custom deleter.
5561         (free_dwo_files): Remove.
5562         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5563         dwo_files.
5564         (process_skeletonless_type_units): Call unique_ptr::get.
5565         (allocate_dwo_file_hash_table): Add deleter to created hash
5566         table.  Change return type to htab_up.
5567         (lookup_dwo_file_slot): Don't memset dwo_file, call
5568         unique_ptr::get.
5569         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5570         (create_dwo_unit_in_dwp_v2): Likewise.
5571         (open_and_init_dwo_file): Likewise.
5572         (free_dwo_file_from_slot): Remove.
5573
5574 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5575
5576         * dwarf2read.h (struct dwarf2_section_info) <readin,
5577         is_virtual>: Change type to bool.
5578         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5579         true instead of 1.
5580
5581 2019-06-19  Tom Tromey  <tom@tromey.com>
5582
5583         * tui/tui-data.h (tui_init_content_element): Don't declare.
5584
5585 2019-06-19  Tom Tromey  <tom@tromey.com>
5586
5587         * tui/tui-data.h (tui_init_win_info): Don't declare.
5588
5589 2019-06-19  Tom de Vries  <tdevries@suse.de>
5590
5591         * dwarf2read.h (abstract_to_concrete): Change type to
5592         std::unordered_map<sect_offset, std::vector<sect_offset>,
5593         gdb::hash_enum<sect_offset>>.
5594
5595 2019-06-19  Tom Tromey  <tromey@adacore.com>
5596
5597         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5598         EVAL_AVOID_SIDE_EFFECTS specially.
5599
5600 2019-06-19  Tom Tromey  <tromey@adacore.com>
5601
5602         * source-cache.c (highlighter): New global.
5603         (source_cache::get_source_lines): Create a highlighter on demand.
5604
5605 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5606
5607         * defs.h (deprecated_interactive_hook): Delete declaration.
5608         * interps.c (clear_interpreter_hooks): Remove use of
5609         deprecated_interactive_hook.
5610         * top.c (deprecated_interactive_hook): Delete definition.
5611         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5612
5613 2019-06-18  Tom de Vries  <tdevries@suse.de>
5614
5615         PR gdb/24515
5616         * dwarf2read.h (abstract_to_concrete): Change type from
5617         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5618         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5619         * dwarf2read.c (read_variable): Update.
5620         (dwarf2_fetch_die_loc_sect_off): Update.
5621
5622 2019-06-17  Tom de Vries  <tdevries@suse.de>
5623
5624         PR gdb/24617
5625         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5626         accessing parent[parent_len - 1].
5627
5628 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5629
5630         PR gdb/24364
5631         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5632         call dtrace_process_dof with NULL dof.
5633
5634 2019-06-16  Tom de Vries  <tdevries@suse.de>
5635
5636         PR gdb/24445
5637         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5638
5639 2019-06-16  Tom Tromey  <tom@tromey.com>
5640
5641         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5642         (make_all_visible): Use address of member.
5643
5644 2019-06-16  Tom Tromey  <tom@tromey.com>
5645
5646         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5647         (tui_free_window, free_content, free_content_elements): Remove
5648         unnecessary cast.
5649         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5650         cast.
5651         * tui/tui-regs.c (tui_show_register_group)
5652         (tui_display_registers_from, tui_display_reg_element_at_line):
5653         Remove unnecessary cast.
5654
5655 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5656
5657         * linux-nat.c (normal_mask): Delete.
5658         (_initialize_linux_nat): Don't initialise normal_mask.
5659
5660 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5661
5662         PR gdb/24445
5663         * dwarf-index-write.h (write_psymtabs_to_index): Add
5664         dwz_basename parameter.
5665         * dwarf-index-write.c (write_gdbindex): Move file writing to
5666         write_gdbindex_1.  Change return type void.
5667         (assert_file_size): Move up, remove filename parameter.
5668         (write_gdbindex_1): New function.
5669         (write_debug_names): Change return type to void, call
5670         assert_file_size.
5671         (struct index_wip_file): New struct.
5672         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5673         file logic to index_wip_file.  Write index for dwz file if
5674         needed.
5675         (save_gdb_index_command): Pass basename of dwz file, if present.
5676         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5677         build-id of dwz file, if present.
5678         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5679         (dwarf2_get_dwz_file): Likewise.
5680         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5681         (dwarf2_get_dwz_file): Likewise.
5682
5683 2019-06-16  Tom Tromey  <tom@tromey.com>
5684
5685         * coffread.c (process_coff_symbol): Use xstrdup.
5686         * value.c (create_internalvar): Use xstrdup.
5687
5688 2019-06-16  Tom Tromey  <tom@tromey.com>
5689
5690         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5691         * breakpoint.c (stopin_command, stopat_command)
5692         (until_break_command, decode_location_default): Remove unnecessary
5693         cast.
5694         * utils.c (subset_compare): Remove unnecessary cast.
5695         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5696         cast.
5697         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5698         cast.
5699         * infcmd.c (path_command): Remove unnecessary cast.
5700         * coffread.c (decode_type): Remove unnecessary cast.
5701         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5702         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5703         * tui/tui-stack.c (tui_show_locator_content)
5704         (tui_show_frame_info): Remove unnecessary cast.
5705         * tui/tui-win.c (tui_scroll_forward_command)
5706         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5707         (parse_scrolling_args): Remove unnecessary cast.
5708         * tui/tui-data.c (init_win_info, tui_del_window)
5709         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5710         (free_content_elements): Remove unnecessary cast.
5711         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5712         unnecessary cast.
5713         * tui/tui-source.c (tui_set_source_content)
5714         (tui_vertical_source_scroll): Remove unnecessary cast.
5715         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5716         cast.
5717         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5718         * tui/tui-regs.c (tui_display_registers_from)
5719         (tui_display_register): Remove unnecessary cast.
5720         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5721         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5722         (make_visible): Remove unnecessary cast.
5723         * tui/tui-winsource.c (tui_erase_source_content)
5724         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5725         unnecessary cast.
5726         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5727         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5728         * stabsread.c (read_type, read_array_type, read_range_type):
5729         Remove unnecessary cast.
5730         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5731         (parse_symbol, parse_type, upgrade_type, parse_external)
5732         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5733         unnecessary cast.
5734         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5735
5736 2019-06-16  Tom Tromey  <tom@tromey.com>
5737
5738         * tui/tui-data.c (tui_alloc_generic_win_info)
5739         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5740         checks.
5741
5742 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5743             Andrew Burgess  <andrew.burgess@embecosm.com>
5744
5745         * f-typeprint.c (f_print_type): Don't return early for not
5746         associated or not allocated types.
5747         (f_type_print_varspec_suffix): Add print_rank parameter and print
5748         ranks of array types in case they dangling.
5749         (f_type_print_base): Add print_rank parameter.
5750
5751 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5752
5753         * NEWS: Mention new MI commands.
5754         * break-catch-throw.c (enum exception_event_kind): Move to
5755         breakpoint.h.
5756         (print_mention_exception_catchpoint): Output text as a single
5757         message.
5758         (catch_exception_command_1): Rename to...
5759         (catch_exception_event): ...this, make non-static, update header
5760         command, and change some parameter types.
5761         (catch_catch_command): Update for changes to
5762         catch_exception_command_1.
5763         (catch_throw_command): Likewise.
5764         (catch_rethrow_command): Likewise.
5765         * breakpoint.c (enum exception_event_kind): Delete.
5766         * breakpoint.h (enum exception_event_kind): Moved here from
5767         break-catch-throw.c.
5768         (catch_exception_event): Declare.
5769         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5770         (mi_cmd_catch_throw): New function.
5771         (mi_cmd_catch_rethrow): New function.
5772         (mi_cmd_catch_catch): New function.
5773         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5774         'catch-catch' entries.
5775         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5776         (mi_cmd_catch_rethrow): Declare.
5777         (mi_cmd_catch_catch): Declare.
5778
5779 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5780
5781         * annotate.c (annotate_source_line): Change return type to void,
5782         update implementation to match.
5783         * annotate.h (annotate_source_line): Change return type to void,
5784         update header comment.
5785         * stack.c (print_frame_info): Don't change what frame information
5786         is printed based on whether annotations are on or not.
5787
5788 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5789
5790         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5791         (annotate_source): Make static.
5792         (annotate_source_line): Moved from source.c and renamed from
5793         identify_source_line.  Update the return type.
5794         * annotate.h (annotate_source): Delete declaration.
5795         (annotate_source_line): Declaration moved from source.h, and
5796         renamed from identify_source_line.  Return type updated.
5797         * source.c (identify_source_line): Moved to annotate.c and renamed
5798         to annotate_source_line.
5799         (info_line_command): Remove check of annotation_level.
5800         * source.h (identify_source_line): Move declaration to annotate.h
5801         and rename to annotate_source_line.
5802         * stack.c: Add 'annotate.h' include.
5803         (print_frame_info): Remove check of annotation_level before
5804         calling annotate_source_line.
5805
5806 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5807
5808         * source-cache.c (source_cache::get_plain_source_lines): Use
5809         open_source_file_with_line_charpos instead of just
5810         open_source_file, remove call to find_source_lines.
5811         (source_cache::get_source_lines): Likewise.
5812         * source.c (find_source_lines): Make static.
5813         (get_filename_and_charpos): Renamed into...
5814         (open_source_file_with_line_charpos): ..this along with changes to
5815         return a scoped_fd, and some other minor clean ups.
5816         (identify_source_line): Use open_source_file_with_line_charpos.
5817         (search_command_helper): Use open_source_file_with_line_charpos
5818         instead of just open_source_file, remove call to
5819         find_source_lines.
5820         * source.h (open_source_file_with_line_charpos): Declare new
5821         function.
5822         (find_source_lines): Delete declaration.
5823
5824 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5825
5826         * source.c (get_filename_and_charpos): Remove fullname
5827         parameter.
5828         (identify_source_line): Update call to get_filename_and_charpos.
5829
5830 2019-06-14  Tom Tromey  <tromey@adacore.com>
5831
5832         PR gdb/24502:
5833         * ui-style.h (skip_ansi_escape): Update comment.
5834         * ui-file.h (class no_terminal_escape_file): New class.
5835         * ui-file.c (no_terminal_escape_file::write)
5836         (no_terminal_escape_file::puts): New methods.
5837         * cli/cli-logging.c (handle_redirections): Use
5838         no_terminal_escape_file.
5839
5840 2019-06-14  Tom Tromey  <tromey@adacore.com>
5841
5842         * NEWS: Move convenience variable news above Python news.
5843
5844 2019-06-14  Tom Tromey  <tom@tromey.com>
5845
5846         * gnulib: Move directory to top-level.
5847         * configure.ac: Don't configure gnulib.
5848         * configure: Rebuild.
5849         * common/common-defs.h: Use new path to gnulib.
5850         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5851         (GNULIB_H): Remove.
5852         (INCGNU): Look in new gnulib location.
5853         (HFILES_NO_SRCDIR): Remove gnulib files.
5854         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5855         (generated_files): Remove GNULIB_H.
5856         ($(LIBGNU), all-lib): Remove targets.
5857         (distclean): Don't mention GNULIB_BUILDDIR.
5858         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5859
5860 2019-06-14  Tom Tromey  <tromey@adacore.com>
5861
5862         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5863         Warn if symbol file does not provide any symbols.
5864
5865 2019-06-14  Tom Tromey  <tromey@adacore.com>
5866
5867         * source.c (find_and_open_source): Respect basenames_may_differ.
5868
5869 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5870
5871         * annotate.c (annotate_breakpoints_invalid): Make use of
5872         scoped_restore_terminal_state.
5873         (annotate_frames_invalid): Likewise.
5874
5875 2019-06-14  Tom Tromey  <tromey@adacore.com>
5876
5877         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5878         allow assignment to an internalvar.
5879
5880 2019-06-14  Tom Tromey  <tromey@adacore.com>
5881
5882         * ada-lex.l: Allow "_" in attribute names.
5883
5884 2019-06-14  Tom Tromey  <tromey@adacore.com>
5885
5886         PR gdb/24653:
5887         * regcache.c (registers_changed): Don't call alloca.
5888         * top.c (execute_command): Don't call alloca.
5889
5890 2019-06-13  Pedro Alves  <palves@redhat.com>
5891
5892         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5893         'expression'.  When parsing an expression, error out if there's
5894         junk after "unlimited".
5895         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5896         (do_set_command): Adjust calls to is_unlimited_literal.
5897
5898 2019-06-13  Pedro Alves  <palves@redhat.com>
5899
5900         * compile/compile.c (make_compile_options_def_group): Add braces
5901         around array_view initializer.
5902         * thread.c (make_thread_apply_all_options_def_group)
5903         (make_thread_apply_all_options_def_group): Likewise.
5904
5905 2019-06-13  Pedro Alves  <palves@redhat.com>
5906
5907         * NEWS (New commands): Mention "maint test-options
5908         require-delimiter", "maint test-options unknown-is-error", "maint
5909         test-options unknown-is-operand" and "maint show
5910         test-options-completion-result".
5911         (New command options, command completion): New section.
5912         (Completion improvements): New section.
5913         Mention that you can abbreviate "unlimited".
5914
5915 2019-06-13  Pedro Alves  <palves@redhat.com>
5916
5917         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5918         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5919         * unittests/cli-utils-selftests.c (test_parse_flags)
5920         (test_parse_flags_qcs): Delete.
5921         (test_cli_utils): Don't call deleted functions.
5922
5923 2019-06-13  Pedro Alves  <palves@redhat.com>
5924
5925         * thread.c: Include "cli/cli-option.h".
5926         (tp_array_compar_ascending): Global.
5927         (tp_array_compar): Delete function.
5928         (tp_array_compar_ascending, tp_array_compar_descending): New
5929         functions.
5930         (ascending_option_def, qcs_flag_option_def)
5931         (thr_qcs_flags_option_defs)
5932         (make_thread_apply_all_options_def_group)
5933         (make_thread_apply_options_def_group): New.
5934         (thread_apply_all_command): Use gdb::option::process_options.
5935         (thread_apply_command_completer)
5936         (thread_apply_all_command_completer): New.
5937         (thread_apply_command): Use gdb::option::process_options.
5938         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5939         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5940         to generate help text of "thread apply".  Adjust "taas"'s help.
5941         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5942         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5943
5944 2019-06-13  Pedro Alves  <palves@redhat.com>
5945
5946         * thread.c (thread_apply_command): Check for invalid TID with
5947         isdigit instead of !isalpha.
5948
5949 2019-06-13  Pedro Alves  <palves@redhat.com>
5950
5951         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5952         (validate_flags_qcs): New.
5953         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5954         (validate_flags_qcs): Declare.
5955         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5956         (make_frame_apply_options_def_group): New.
5957         (frame_apply_command_count): Process options with
5958         gdb::option::process_options.
5959         (frame_apply_completer): New.
5960         (frame_apply_level_completer, frame_apply_all_completer)
5961         (frame_apply_completer): New.
5962         (_initialize_stack): Update help of "frame apply", "frame apply
5963         level", "frame apply all" and "faas" to mention supported options
5964         and install command completers.
5965         * stack.h (frame_apply_all_completer): Declare.
5966         * thread.c: Include "stack.h".
5967         (tfaas_command): Add "--".
5968         (_initialize_thread): Update help "tfaas" to mention supported
5969         options and install command completer.
5970
5971 2019-06-13  Pedro Alves  <palves@redhat.com>
5972
5973         * completer.c (complete_nested_command_line): New.
5974         (gdb_completion_word_break_characters_throw): Add assertion.
5975         * completer.h (complete_nested_command_line): Declare.
5976
5977 2019-06-13  Pedro Alves  <palves@redhat.com>
5978
5979         * stack.c (parse_backtrace_qualifiers): New.
5980         (backtrace_command): Use it.
5981         (backtrace_command_completer): Complete on qualifiers.
5982
5983 2019-06-13  Pedro Alves  <palves@redhat.com>
5984
5985         * frame.c: Include "cli/cli-option.h.
5986         (user_set_backtrace_options): New.
5987         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5988         Delete.
5989         (get_prev_frame): Adjust.
5990         (boolean_option_def, uinteger_option_def)
5991         (set_backtrace_option_defs): New.
5992         (_initialize_frame): Adjust and use
5993         gdb::option::add_setshow_cmds_for_options to install "set
5994         backtrace past-main" and "set backtrace past-entry".
5995         * frame.h: Include "cli/cli-option.h".
5996         (struct frame_print_options): Forward declare.
5997         (print_frame_arguments_all, print_frame_arguments_scalars)
5998         (print_frame_arguments_none): Declare.
5999         (print_entry_values): Delete declaration.
6000         (struct frame_print_options, user_frame_print_options): New.
6001         (struct set_backtrace_options): New.
6002         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6003         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6004         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6005         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6006         (list_args_or_locals): Add frame_print_options parameter.
6007         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6008         * python/py-framefilter.c (enumerate_args): Pass down
6009         USER_FRAME_PRINT_OPTIONS.
6010         * stack.c: Include "cli/cli-option.h".
6011         (print_frame_arguments_all, print_frame_arguments_scalars)
6012         (print_frame_arguments_none): Declare.
6013         (print_raw_frame_arguments, print_entry_values): Delete.
6014         (user_frame_print_options): New.
6015         (boolean_option_def, enum_option_def, frame_print_option_defs):
6016         New.
6017         (struct backtrace_cmd_options): New.
6018         (bt_flag_option_def): New.
6019         (backtrace_command_option_defs): New.
6020         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6021         (print_frame_arg, read_frame_arg, print_frame_args)
6022         (print_frame_info, print_frame): Add frame_print_options parameter
6023         and use it.
6024         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6025         (backtrace_command_1): Add frame_print_options and
6026         backtrace_cmd_options parameters and use them.
6027         (make_backtrace_options_def_group): New.
6028         (backtrace_command): Process command options with
6029         gdb::option::process_options.
6030         (backtrace_command_completer): New.
6031         (_initialize_stack): Extend "backtrace"'s help to mention
6032         supported options.  Install completer for "backtrace".
6033         Install some settings commands with add_setshow_cmds_for_options.
6034
6035 2019-06-13  Pedro Alves  <palves@redhat.com>
6036
6037         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6038         and that "set/show print raw frame-arguments" are now deprecated.
6039
6040         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6041         command.
6042         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6043         * stack.c (_initialize_stack): Install "set/show print
6044         raw-frame-arguments", and deprecate "set/show print raw
6045         frame-arguments".
6046         * valprint.c (_initialize_valprint): Deprecate "set/show print
6047         raw".
6048
6049 2019-06-13  Pedro Alves  <palves@redhat.com>
6050
6051         * compile/compile.c (struct compile_options): New.
6052         (compile_flag_option_def, compile_command_option_defs)
6053         (make_compile_options_def_group): New.
6054         (compile_file_command): Handle options with
6055         gdb::option::process_options.
6056         (compile_file_command_completer): New function.
6057         (compile_code_command): Handle options with
6058         gdb::option::process_options.
6059         (compile_code_command_completer): New function.
6060         (_initialize_compiler): Install completers for "compile code" and
6061         "compile file".  Mention available options in "compile code" and
6062         "compile code"'s help.
6063         * completer.c (advance_to_completion_word): New, factored out from
6064         ...
6065         (advance_to_expression_complete_word_point): ... this.
6066         (advance_to_filename_complete_word_point): New.
6067         * completer.h (advance_to_filename_complete_word_point): New
6068         declaration.
6069
6070 2019-06-13  Pedro Alves  <palves@redhat.com>
6071
6072         * compile/compile.c: Include "cli/cli-option.h".
6073         (compile_print_value): Scope data pointer is now a
6074         value_print_options pointer; adjust.
6075         (compile_print_command): Process options.  Scope data pointer is
6076         now a value_print_options pointer; adjust.
6077         (_initialize_compile): Update "compile print"'s help to include
6078         supported options.  Install a completer for "compile print".
6079         * cp-valprint.c (show_vtblprint, show_objectprint)
6080         (show_static_field_print): Delete.
6081         (_initialize_cp_valprint): Don't install "set print
6082         static-members", "set print vtbl", "set print object" here.
6083         * printcmd.c: Include "cli/cli-option.h" and
6084         "common/gdb_optional.h".
6085         (print_command_parse_format): Rework to fill in a
6086         value_print_options instead of a format_data.
6087         (print_value): Change parameter type from format_data pointer to
6088         value_print_options reference.  Adjust.
6089         (print_command_1): Process options.  Adjust to pass down a
6090         value_print_options.
6091         (print_command_completer): New.
6092         (_initialize_printcmd): Install print_command_completer as
6093         handle_brkchars completer for the "print" command.  Update
6094         "print"'s help to include supported options.
6095         * valprint.c: Include "cli/cli-option.h".
6096         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6097         here from cp-valprint.c.
6098         (boolean_option_def, uinteger_option_def)
6099         (value_print_option_defs, make_value_print_options_def_group):
6100         New.  Use gdb::option::add_setshow_cmds_for_options to install
6101         "set print elements", "set print null-stop", "set print repeats",
6102         "set print pretty", "set print union", "set print array", "set
6103         print address", "set print symbol", "set print array-indexes".
6104         * valprint.h: Include <string> and "cli/cli-option.h".
6105         (make_value_print_options_def_group): Declare.
6106         (print_value): Change parameter type from format_data pointer to
6107         value_print_options reference.
6108         (print_command_completer): Declare.
6109
6110 2019-06-13  Pedro Alves  <palves@redhat.com>
6111
6112         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6113         (COMMON_SFILES): Add maint-test-settings.c.
6114         * cli/cli-decode.c (boolean_enums): New global, factored out from
6115         ...
6116         (add_setshow_boolean_cmd): ... here.
6117         * cli/cli-decode.h (boolean_enums): Declare.
6118         * cli/cli-option.c: New file.
6119         * cli/cli-option.h: New file.
6120         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6121         factored out from ...
6122         (parse_cli_boolean_value(const char *)): ... this.
6123         (is_unlimited_literal): Change parameter type to pointer to
6124         pointer.  Adjust and advance ARG pointer.
6125         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6126         (parse_cli_var_enum): New, factored out from ...
6127         (do_set_command): ... this.  Adjust.
6128         * cli/cli-setshow.h (parse_cli_boolean_value)
6129         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6130         (parse_cli_var_enum): Declare.
6131         * cli/cli-utils.c: Include "cli/cli-option.h".
6132         (get_ulongest): New.
6133         * cli/cli-utils.h (get_ulongest): Declare.
6134         (check_for_argument): New overloads.
6135         * maint-test-options.c: New file.
6136
6137 2019-06-13  Pedro Alves  <palves@redhat.com>
6138
6139         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6140         parse a range if "-" is at the end of the string.
6141
6142 2019-06-13  Pedro Alves  <palves@redhat.com>
6143
6144         * cli/cli-setshow.c (parse_auto_binary_operation)
6145         (parse_cli_boolean_value): Don't allow "o".
6146
6147 2019-06-13  Pedro Alves  <palves@redhat.com>
6148
6149         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6150         * NEWS: Mention maint test-settings KIND.
6151         * maint-test-settings.c: New file.
6152
6153 2019-06-13  Pedro Alves  <palves@redhat.com>
6154
6155         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6156         completer.
6157         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6158         "set" completers.
6159
6160 2019-06-13  Pedro Alves  <palves@redhat.com>
6161
6162         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6163         after item.
6164
6165 2019-06-13  Pedro Alves  <palves@redhat.com>
6166
6167         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6168
6169 2019-06-13  Pedro Alves <palves@redhat.com>
6170
6171         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6172         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6173         call.
6174         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6175         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6176         calls.
6177         (check_for_argument): Skip spaces after argument.
6178
6179 2019-06-13  Pedro Alves  <palves@redhat.com>
6180
6181         * thread.c (thread_apply_command): Adjust TID parsing.
6182         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6183         detected before end of string.
6184         (tid_is_in_list): Error out if LIST is invalid.
6185
6186 2019-06-13  Pedro Alves  <palves@redhat.com>
6187
6188         * completer.c (complete_line_internal_1): Rewind completion word
6189         point.
6190         (completion_tracker::advance_custom_word_point_by): Change
6191         parameter type to int.
6192         * completer.h (completion_tracker::advance_custom_word_point_by):
6193         Likewise.
6194
6195 2019-06-13  Pedro Alves  <palves@redhat.com>
6196
6197         * completer.c (advance_to_completion_word): Handle delimiters.
6198
6199 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6200
6201         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6202
6203 2019-06-11  Tom Tromey  <tom@tromey.com>
6204
6205         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6206         (xmalloc_failed): Move to alloc.c.
6207         * alloc.c: New file.
6208         * Makefile.in (COMMON_SFILES): Add alloc.c.
6209
6210 2019-06-11  Tom Tromey  <tom@tromey.com>
6211
6212         * nat/linux-waitpid.c: Don't include server.h.
6213         (linux_debug): Remove.
6214         (my_waitpid): Update.
6215
6216 2019-06-11  Tom Tromey  <tromey@adacore.com>
6217
6218         * infcall.c (_initialize_infcall): Remove trailing newline from
6219         help.
6220         * user-regs.c (_initialize_user_regs): Remove trailing newline
6221         from help.
6222         * typeprint.c (_initialize_typeprint): Remove trailing newline
6223         from help.
6224         * reverse.c (_initialize_reverse): Remove trailing newlines from
6225         help.
6226         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6227         from help.
6228         * language.c (add_set_language_command): Remove trailing newline
6229         from help.
6230         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6231         help.
6232         * disasm.c (_initialize_disasm): Remove trailing newline from
6233         help.
6234         * top.c (init_main): Remove trailing newline from help.
6235         * interps.c (_initialize_interpreter): Remove trailing newline
6236         from help.
6237         * btrace.c (_initialize_btrace): Remove trailing newlines from
6238         help.
6239         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6240         from help.
6241         * python/python.c (_initialize_python): Remove trailing newline
6242         from help.
6243         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6244         help.
6245         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6246         from help.  Reformat some text.
6247         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6248         from help.
6249         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6250         newline from help.
6251
6252 2019-06-11  Tom Tromey  <tromey@adacore.com>
6253
6254         * darwin-nat.c (darwin_decode_exception_message)
6255         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6256
6257 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6258
6259         * valops.c (value_slice): Check for not allocated or not
6260         associated values.
6261
6262 2019-06-10  Tom de Vries  <tdevries@suse.de>
6263
6264         PR gdb/24618
6265         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6266         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6267         invalid.
6268
6269 2019-06-10  Tom de Vries  <tdevries@suse.de>
6270
6271         PR gdb/24611
6272         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6273         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6274
6275 2019-06-10  Tom de Vries  <tdevries@suse.de>
6276
6277         PR symtab/24545
6278         * symtab.c (struct demangled_name_entry): Add language field.
6279         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6280         static minimal symbol".  Set and use language field.
6281
6282 2019-06-10  Tom Tromey  <tromey@adacore.com>
6283
6284         * ada-lang.c (_initialize_ada_language): Update help text.
6285
6286 2019-06-10  Tom Tromey  <tromey@adacore.com>
6287
6288         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6289         with a newline.
6290         * guile/guile.c (handle_boot_error): Don't end warning with a
6291         newline.
6292         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6293         warning with a newline.
6294         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6295         newline.
6296         (s12z_frame_cache): Likewise.
6297         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6298         a newline.
6299         * solib-svr4.c (disable_probes_interface): Don't end warning with
6300         a newline.
6301         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6302         newline.
6303         * python/python.c (do_finish_initialization): Don't end warning
6304         with a newline.
6305
6306 2019-06-10  Tom Tromey  <tom@tromey.com>
6307
6308         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6309         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6310         gdbpy_enter.
6311
6312 2019-06-10  Tom Tromey  <tromey@adacore.com>
6313
6314         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6315         data.
6316         (elf_new_init): Don't call stabsread_new_init.
6317         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6318         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6319         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6320
6321 2019-06-10  Tom de Vries  <tdevries@suse.de>
6322
6323         PR symtab/16264
6324         PR symtab/24517
6325         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6326
6327 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6328
6329         * source.c (find_and_open_source): Also rewrite relative file
6330         names.
6331
6332 2019-04-26  Amos Bird  <amosbird@gmail.com>
6333
6334         * annotate.c (annotate_thread_exited): Add "thread-exited"
6335         annotation.
6336
6337 2019-06-06  Tom Tromey  <tromey@adacore.com>
6338
6339         * maint.h (class scoped_command_stats): Use
6340         DISABLE_COPY_AND_ASSIGN.
6341         <print_time>: New method.
6342         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6343         print_time.
6344         (scoped_command_stats::print_time): New method.
6345
6346 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6347
6348         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6349         instructions of lengths 6 or 8 bytes.
6350
6351 2019-06-04  Pedro Alves  <palves@redhat.com>
6352
6353         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6354
6355         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6356         * breakpoint.c (condition_completer): Likewise.
6357         * cli/cli-dump.c (scan_expression): Likewise.
6358         * common/filestuff.c (mkdir_recursive): Likewise.
6359         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6360         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6361         (gdb_abspath): Likewise.
6362         * compile/compile-cplus-types.c
6363         (compile_cplus_instance::decl_name): Likewise.
6364         * completer.c (complete_explicit_location):
6365         (signal_completer, reg_or_group_completer_1): Likewise.
6366         * cp-support.c (cp_remove_params_if_any): Likewise.
6367         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6368         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6369         * infcmd.c (strip_bg_char): Likewise.
6370         * linespec.c (copy_token_string): Likewise.
6371         * mi/mi-main.c (output_cores): Likewise.
6372         * psymtab.c (psymtab_search_name):
6373         * symfile.c (test_set_ext_lang_command): Likewise.
6374         * target.c (target_fileio_read_stralloc): Likewise.
6375         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6376         * value.c (complete_internalvar): Likewise.
6377
6378 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6379
6380         Add objfile property to gdb.Type.
6381         * NEWS: Mention Python API addition.
6382         * python/py-type.c (typy_get_objfile): New method.
6383
6384 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6385
6386         * NEWS: Mention the new set|show style [title|highlight].
6387         Mention changes to "show style", "help" and "apropos".
6388
6389 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6390
6391         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6392         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6393         instead of print_help_for_command.
6394         (print_doc_of_command): New function.
6395         (help_list): Add 'apropos -v word' suggestion.
6396         (print_help_for_command): Style the command name using title style.
6397         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6398         (_initialize_cli_cmds): Describe -v in apropos_command help.
6399
6400 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6401
6402         * cli/cli-style.h (cli_style_option): Add name in constructor,
6403         add m_name class member, add constructor with intensity,
6404         add name class function.
6405         (cli_style_option::add_setshow_commands): Remove name argument.
6406         (highlight_style, title_style): New styles.
6407         * cli/cli-style.c (do_show): New function that shows a style
6408         characteristic styling the style name with itself.
6409         (set_style_name): New function.
6410         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6411         Update all callers according to the changes in cli/cli-style.h.
6412         * utils.h (fputs_highlighted): New function.
6413         * utils.c (fputs_highlighted): Likewise.
6414
6415 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6416
6417         * NEWS: Mention new pipe command and new convenience variables.
6418
6419 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6420
6421         * cli/cli-cmds.c (pipe_command): New function.
6422         (_initialize_cli_cmds): Call add_com for pipe_command.
6423         Define | as an alias for pipe.
6424         (exit_status_set_internal_vars): New function.
6425         (shell_escape): Call exit_status_set_internal_vars.
6426         cli/cli-decode.c (find_command_name_length): Recognize | as
6427         a single character command.
6428
6429 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6430
6431         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6432         top.c (execute_command_to_ui_file): New function, mostly a copy
6433         of execute_command_to_string.
6434         (execute_command_to_string): Implement by calling
6435         execute_command_to_ui_file.
6436
6437 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6438
6439         * top.h (saved_command_line): Remove declaration.
6440         * top.c (previous_saved_command_line, previous_repeat_arguments):
6441         New variables.
6442         (saved_command_line): Make static, define together with other
6443         'repeat variables'.
6444         (dont_repeat): Clear repeat_arguments.
6445         (repeat_previous, get_saved_command_line, save_command_line):
6446         New functions.
6447         (gdb_init): Initialize saved_command_line
6448         and previous_saved_command_line.
6449         * main.c (captured_main_1): Remove saved_command_line initialization.
6450         * event-top.c (handle_line_of_input): Update to use
6451         the new 'repeat' related functions instead of direct access to
6452         saved_command_line.
6453         * command.h (repeat_previous, get_saved_command_line,
6454         save_command_line): New declarations.
6455         (dont_repeat): Add comment.
6456
6457 2019-05-30  Tom Tromey  <tromey@adacore.com>
6458
6459         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6460         Fix comment.
6461         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6462
6463 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6464
6465         PR cli/24587
6466         * completer.c (complete): Initialize variable word.
6467
6468 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6469
6470         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6471         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6472         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6473         'body' is NULL to the outter 'if', protecting the '!is_define'
6474         situation as well.
6475
6476 2019-05-29  Tom Tromey  <tromey@adacore.com>
6477
6478         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6479         (dwarf_unknown): New function.
6480         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6481         (dwarf_type_encoding_name): Use dwarf_unknown.
6482
6483 2019-05-29  Tom Tromey  <tromey@adacore.com>
6484
6485         PR c++/20020:
6486         * cp-valprint.c (cp_print_value_fields): Call
6487         cp_print_static_field inside "try".
6488
6489 2019-05-29  Tom Tromey  <tromey@adacore.com>
6490
6491         * inflow.c (struct terminal_info): Add default operator=.
6492         * configure: Rebuild.
6493         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6494         -Wdeprecated-copy-dtor, -Wredundant-move.
6495
6496 2019-05-29  Tom Tromey  <tromey@adacore.com>
6497
6498         * NEWS: Add entry.
6499         * infcmd.c (print_return_value_1): Handle finish_print
6500         option.
6501         (show_print_finish): New function.
6502         (_initialize_infcmd): Add "set/show print finish" commands.
6503         * valprint.c (user_print_options): Initialize new member.
6504         * valprint.h (struct value_print_options) <finish_print>: New
6505         member.
6506
6507 2019-05-28  Tom Tromey  <tromey@adacore.com>
6508
6509         * ada-lang.c (ada_remove_Xbn_suffix)
6510         (find_old_style_renaming_symbol)
6511         (parse_old_style_renaming): Remove.
6512         (ada_find_renaming_symbol): Don't call
6513         find_old_style_renaming_symbol.
6514         (ada_is_renaming_symbol): Rename from
6515         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6516         bool.  Now static.
6517         (ada_read_var_value): Update and simplify.
6518         * ada-exp.y (write_var_or_type): Remove old code.
6519
6520 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6521
6522         * event-top.c: Remove include comment.
6523         * inflow.c (class scoped_ignore_sigttou): Move from here...
6524         * inflow.h (class scoped_ignore_sigttou): ...to here.
6525         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6526         * top.c:  Remove include comment.
6527
6528 2019-05-27  Tom Tromey  <tom@tromey.com>
6529
6530         * NEWS: Fix typo.
6531
6532 2019-05-22  Tom Tromey  <tromey@adacore.com>
6533
6534         * target.c (target_follow_exec): Constify parameter.
6535         * target-delegates.c: Rebuild.
6536         * remote.c (remote_target::follow_exec): Constify parameter.
6537         * infrun.c (follow_exec): Constify parameter.
6538         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6539         (target_follow_exec): Likewise.
6540
6541 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6542
6543         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6544         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6545
6546 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6547
6548         * NEWS: Add debugredirect and testsuite sections.
6549
6550 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6551
6552         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6553         target descriptions using exclusively floating point register name
6554         aliases.
6555
6556 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6557
6558         PR gdb/18644:
6559         * f-lang.c (build_fortran_types): Handle the case where
6560         gdbarch_floatformat_for_type returns a nullptr.
6561
6562 2019-05-21  Tom de Vries  <tdevries@suse.de>
6563
6564         PR cli/24587
6565         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6566
6567 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6568
6569         PR gdb/18644:
6570         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6571         16-byte floats.
6572         * i386-tdep.c (i386_floatformat_for_type): Use
6573         floatformats_ia64_quad for the 16-byte floating point component
6574         within a fortran 32-byte complex number.
6575
6576 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6577
6578         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6579         delete default constructor.
6580         (find_partial_die): Update to return const struct.
6581         (partial_die_parent_scope): Move variable declaration into scope
6582         of its use and change its type to auto.
6583         (guess_partial_die_structure_name): Likewise.
6584         (partial_die_info::fixup): Likewise.
6585
6586 2019-05-17  Tom Tromey  <tromey@adacore.com>
6587
6588         * source.c (find_and_open_source): Remove cast.
6589
6590 2019-05-17  Tom Tromey  <tromey@adacore.com>
6591
6592         * annotate.c (annotate_source): Make "filename" const.
6593         * annotate.h (annotate_source): Use const.
6594
6595 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6596
6597         * disasm.c (set_disassembler_options): Send errors to stderr.
6598
6599 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6600
6601         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6602         (cli_interp_base::set_logging): Check debug_redirect.
6603         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6604         * cli/cli-logging.c (debug_redirect): Add static variable.
6605         (pop_output_files): Add default param.
6606         (handle_redirections): Print debug setting.
6607         (show_logging_command): Likewise.
6608         (_initialize_cli_logging): Add debugredirect command.
6609         * interps.c (current_interp_set_logging): Add debug_redirect
6610         parameter.
6611         * interps.h (set_logging): Add debug_redirect parameter.
6612         (current_interp_set_logging): Likewise.
6613         * mi/mi-common.h: Likewise.
6614         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6615
6616 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6617             Tom Tromey  <tromey@adacore.com>
6618
6619         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6620         directly.
6621         * cli/cli-interp.h (make_logging_output): Remove declaration.
6622         * cli/cli-logging.c (make_logging_output): Remove function.
6623         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6624         directly.
6625         * ui-file.c (tee_file::tee_file): Remove bools.
6626         (tee_file::~tee_file): Remove deletes.
6627         * ui-file.h (tee_file): Remove bools.
6628
6629 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6630
6631         * mi/mi-cmds.h (mi_cmd_complete): New function.
6632         * mi/mi-main.c (mi_cmd_complete): Likewise.
6633         * mi/mi-cmds.c: Define new MI command -complete.
6634         * NEWS: Mention new -complete command.
6635
6636 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6637
6638         * completer.h (complete): New function.
6639         * completer.c (complete): Likewise.
6640         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6641         function defined in completer.h.
6642
6643 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6644
6645         * MAINTAINERS (Write After Approval): Add myself.
6646
6647 2019-05-17  Tom de Vries  <tdevries@suse.de>
6648
6649         PR gdb/24094
6650         * dwarf2read.c (struct cu_partial_die_info): New struct.
6651         (find_partial_die): Return cu_partial_die_info.
6652         (partial_die_parent_scope, guess_partial_die_structure_name)
6653         (partial_die_info::fixup): Handle new return type of find_partial_die.
6654
6655 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6656
6657         PR breakpoints/24541
6658         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6659         "std::string", simplifying the algorithm.
6660
6661 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6662
6663         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6664         (stap_static_probe_ops::get_probes): Likewise.
6665
6666 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6667
6668         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6669         '-')" and "else if".
6670         (stap_parse_single_operand): Join checks for
6671         "gdbarch_stap_parse_special_token_p" and
6672         "gdbarch_stap_parse_special_token" in the same "if" statement.
6673         Invert check when verifying for operation on register
6674         displacement.
6675
6676 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6677
6678         * stap-probe.c (stap_get_opcode): Update comment.
6679         (stap_get_expected_argument_type): Likewise.
6680         (handle_stap_probe): Likewise.
6681
6682 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6683
6684         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6685         return type to 'bool'.  Adjust comment.  Use 'bool' when
6686         appropriate.
6687         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6688         * stap-probe.c (stap_parse_argument_1): Likewise.
6689         (stap_is_operator): Likewise.
6690         (stap_is_generic_prefix): Likewise.
6691         (stap_is_register_prefix): Likewise.
6692         (stap_is_register_indirection_prefix): Likewise.
6693         (stap_is_integer_prefix): Likewise.
6694         (stap_generic_check_suffix): Likewise.
6695         (stap_check_integer_suffix): Likewise.
6696         (stap_check_register_suffix): Likewise.
6697         (stap_check_register_indirection_suffix): Likewise.
6698         (stap_parse_register_operand): Likewise.
6699         (stap_parse_single_operand): Likewise.
6700         (stap_parse_argument_1): Likewise.
6701         (stap_probe::get_argument_count): Likewise.
6702         (stap_is_operator): Likewise.
6703
6704 2019-05-16  Tom Tromey  <tromey@adacore.com>
6705
6706         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6707         keyword to foreach.
6708
6709 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6710
6711         * linux-thread-db.c (try_thread_db_load_1): Change return type
6712         to bool.
6713         (try_thread_db_load): Likewise.
6714         (try_thread_db_load_from_pdir_1): Likewise.
6715         (try_thread_db_load_from_pdir): Likewise.
6716         (try_thread_db_load_from_sdir): Likewise.
6717         (try_thread_db_load_from_dir): Likewise.
6718         (thread_db_load_search): Likewise.
6719         (has_libpthread): Likewise.
6720         (thread_db_load): Likewise.
6721
6722 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6723
6724         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6725         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6726         NULL, and complain/return if that's the case.
6727
6728 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6729
6730         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6731         (advance, posn, abstract_read_memory): New functions.
6732         [struct mem_read_abstraction]: New struct.
6733         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6734
6735 2019-05-14  Tom Tromey  <tromey@adacore.com>
6736
6737         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6738         value is not lval_memory.
6739
6740 2019-05-14  Tom Tromey  <tromey@adacore.com>
6741
6742         * solib.c (info_sharedlibrary_command): Style the file name.
6743
6744 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6745
6746         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6747         (aarch64_vnv_type): Likewise.
6748         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6749         * common/tdesc.c: Likewise.
6750         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6751         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6752         * features/aarch64-fpu.xml: Add ieee half view.
6753         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6754         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6755         * gdbtypes.h (struct builtin_type): Likewise.
6756         (struct objfile_type): Likewise.
6757
6758 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6759
6760         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6761         typo.
6762         * location.h (string_to_event_location): Likewise.
6763
6764 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6765
6766         GDB 8.3 released.
6767
6768 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6769
6770         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6771         New variable declaration.
6772         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6773         New variable.
6774         (print_one_breakpoint): Use ui_out::test_flags and new global
6775         variable to compute use_fixed_output.
6776         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6777         Remove.
6778         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6779         (mi_multi_location_breakpoint_output_fixed): Remove.
6780         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6781         new variable.
6782         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6783         fix_multi_location_breakpoint_output flag if version >= 3.
6784         * ui-out.h (enum ui_out_flag)
6785         <fix_multi_location_breakpoint_output>: New enumerator.
6786
6787 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6788
6789         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6790
6791 2019-05-10  Tom Tromey  <tromey@adacore.com>
6792
6793         * ada-lang.c (catch_ada_completer): New function.
6794         (_initialize_ada_language): Use it.
6795
6796 2019-05-10  Tom Tromey  <tromey@adacore.com>
6797
6798         * thread.c (print_thread_info): Make "requested_threads" const.
6799         * gdbthread.h (print_thread_info): Make "requested_threads"
6800         const.
6801         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6802         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6803
6804 2019-05-08  Tom Tromey  <tom@tromey.com>
6805
6806         * gdbtypes.c (objfile_type_data): Change type.
6807         (objfile_type, _initialize_gdbtypes): Update.
6808
6809 2019-05-08  Tom Tromey  <tom@tromey.com>
6810
6811         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6812         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6813         (_initialize_dwarf2_frame): Update.
6814
6815 2019-05-08  Tom Tromey  <tom@tromey.com>
6816
6817         * objc-lang.c (objc_objfile_data): Change type.
6818         (find_methods): Update.
6819         (_initialize_objc_lang): Remove.
6820
6821 2019-05-08  Tom Tromey  <tom@tromey.com>
6822
6823         * stabsread.c (rs6000_builtin_type_data): Change type.
6824         (rs6000_builtin_type, _initialize_stabsread): Update.
6825
6826 2019-05-08  Tom Tromey  <tom@tromey.com>
6827
6828         * mips-tdep.c (mips_pdr_data): Remove.
6829         (_initialize_mips_tdep): Update.
6830
6831 2019-05-08  Tom Tromey  <tom@tromey.com>
6832
6833         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6834         (hppa_init_objfile_priv_data, read_unwind_info)
6835         (find_unwind_entry, _initialize_hppa_tdep): Update.
6836
6837 2019-05-08  Tom Tromey  <tom@tromey.com>
6838
6839         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6840         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6841         on obstack.
6842         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6843
6844 2019-05-08  Tom Tromey  <tom@tromey.com>
6845
6846         * mdebugread.c (basic_type_data): Change type.
6847         (basic_type, _initialize_mdebugread): Update.
6848
6849 2019-05-08  Tom Tromey  <tom@tromey.com>
6850
6851         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6852
6853 2019-05-08  Tom Tromey  <tom@tromey.com>
6854
6855         * nto-tdep.c (nto_inferior_data_reg): Change type.
6856         (nto_inferior_data): Update.
6857         (nto_inferior_data_cleanup, nto_new_inferior_data)
6858         (_initialize_nto_tdep): Remove.
6859         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6860
6861 2019-05-08  Tom Tromey  <tom@tromey.com>
6862
6863         * ada-lang.c (struct ada_inferior_data): Add initializers.
6864         (ada_inferior_data): Change type.
6865         (ada_inferior_data_cleanup): Remove.
6866         (get_ada_inferior_data, ada_inferior_exit)
6867         (struct ada_pspace_data): Add initializers, destructor.
6868         (ada_pspace_data_handle): Change type.
6869         (get_ada_pspace_data): Update.
6870         (ada_pspace_data_cleanup): Remove.
6871
6872 2019-05-08  Tom Tromey  <tom@tromey.com>
6873
6874         * coffread.c (struct coff_symfile_info): Add initializers.
6875         (coff_objfile_data_key): Move lower.  Change type.
6876         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6877         Update.
6878         (coff_free_info): Remove.
6879
6880 2019-05-08  Tom Tromey  <tom@tromey.com>
6881
6882         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6883         (fbsd_pspace_data_handle): Move lower.  Change type.
6884         (get_fbsd_pspace_data): Update.
6885         (fbsd_pspace_data_cleanup): Remove.
6886         (_initialize_fbsd_tdep): Update.
6887
6888 2019-05-08  Tom Tromey  <tom@tromey.com>
6889
6890         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6891         (get_ada_tasks_pspace_data): Update.
6892         (ada_tasks_pspace_data_cleanup): Remove.
6893         (_initialize_tasks): Update.
6894         (ada_tasks_inferior_data_handle): Change type.
6895         (get_ada_tasks_inferior_data): Update.
6896         (ada_tasks_inferior_data_cleanup): Remove.
6897         (struct ada_tasks_pspace_data): Add initializers.
6898
6899 2019-05-08  Tom Tromey  <tom@tromey.com>
6900
6901         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6902         * symfile-debug.c (debug_sym_get_probes): Change type.
6903         * stap-probe.c (handle_stap_probe):
6904         (stap_static_probe_ops::get_probes): Change type.
6905         * probe.h (class static_probe_ops) <get_probes>: Change type.
6906         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6907         (parse_probes_in_pspace): Update.
6908         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6909         Update.
6910         (any_static_probe_ops::get_probes): Change type.
6911         * elfread.c (elfread_data): New typedef.
6912         (probe_key): Change type.
6913         (elf_get_probes): Likewise.  Update.
6914         (probe_key_free): Remove.
6915         (_initialize_elfread): Update.
6916         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6917         Change type.
6918         (dtrace_process_dof_probe, dtrace_process_dof)
6919         (dtrace_static_probe_ops::get_probe): Change type.
6920
6921 2019-05-08  Tom Tromey  <tom@tromey.com>
6922
6923         * xcoffread.c (struct xcoff_symfile_info): Rename from
6924         coff_symfile_info.  Add initializers.
6925         (xcoff_objfile_data_key): Move lower.  Change type.
6926         (XCOFF_DATA): Rewrite.
6927         (xcoff_free_info): Remove.
6928         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6929         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6930         (xcoff_initial_scan): Update.
6931
6932 2019-05-08  Tom Tromey  <tom@tromey.com>
6933
6934         * solib-svr4.c (struct svr4_info): Add initializers and
6935         destructor.
6936         <probes_table>: Now an htab_up.
6937         (solib_svr4_pspace_data): Change type.
6938         (free_probes_table): Simplify.
6939         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6940         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6941         (probes_table_remove_objfile_probes, register_solib_event_probe)
6942         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6943         (_initialize_svr4_solib): Update.
6944
6945 2019-05-08  Tom Tromey  <tom@tromey.com>
6946
6947         * remote.c (remote_pspace_data): Change type.
6948         (remote_pspace_data_cleanup): Remove.
6949         (get_remote_exec_file, set_pspace_remote_exec_file)
6950         (_initialize_remote): Update.
6951
6952 2019-05-08  Tom Tromey  <tom@tromey.com>
6953
6954         * breakpoint.c (breakpoint_objfile_key): Change type.
6955         (get_breakpoint_objfile_data): Update.
6956         (free_breakpoint_objfile_data): Remove.
6957         (_initialize_breakpoint): Update.
6958
6959 2019-05-08  Tom Tromey  <tom@tromey.com>
6960
6961         * linux-tdep.c (struct linux_info): Add initializers.
6962         (linux_inferior_data): Move.  Change type.
6963         (invalidate_linux_cache_inf): Update.
6964         (linux_inferior_data_cleanup): Remove.
6965         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6966
6967 2019-05-08  Tom Tromey  <tom@tromey.com>
6968
6969         * auxv.c (auxv_inferior_data): Move.  Change type.
6970         (auxv_inferior_data_cleanup): Remove.
6971         (invalidate_auxv_cache_inf): Rewrite.
6972         (get_auxv_inferior_data, _initialize_auxv): Update.
6973
6974 2019-05-08  Tom Tromey  <tom@tromey.com>
6975
6976         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6977         (symfile_debug_objfile_data_key): Change type.
6978         (symfile_debug_installed, debug_qf_has_symbols)
6979         (debug_qf_find_last_source_symtab)
6980         (debug_qf_forget_cached_source_info)
6981         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6982         (debug_qf_print_stats, debug_qf_dump)
6983         (debug_qf_expand_symtabs_for_function)
6984         (debug_qf_expand_all_symtabs)
6985         (debug_qf_expand_symtabs_with_fullname)
6986         (debug_qf_map_matching_symbols)
6987         (debug_qf_expand_symtabs_matching)
6988         (debug_qf_find_pc_sect_compunit_symtab)
6989         (debug_qf_map_symbol_filenames)
6990         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6991         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6992         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6993         (debug_sym_read_linetable, debug_sym_relocate): Update.
6994         (symfile_debug_free_objfile): Remove.
6995         (install_symfile_debug_logging, _initialize_symfile_debug):
6996         Update.
6997
6998 2019-05-08  Tom Tromey  <tom@tromey.com>
6999
7000         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7001         allocate_on_obstack.
7002         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7003         (get_dwarf2_per_objfile): Update.
7004         (set_dwarf2_per_objfile): Remove.
7005         (dwarf2_has_info, dwarf2_get_section_info): Update.
7006         (dwarf2_free_objfile): Remove.
7007         (_initialize_dwarf2_read): Update.
7008
7009 2019-05-08  Tom Tromey  <tom@tromey.com>
7010
7011         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7012         initializers.
7013         <unsupported_script_warning_printed,
7014         script_not_found_warning_printed>: Now bool.
7015         (auto_load_pspace_data): Change type.
7016         (~auto_load_pspace_info): Rename from
7017         auto_load_pspace_data_cleanup.
7018         (get_auto_load_pspace_data, init_loaded_scripts_info)
7019         (clear_section_scripts, maybe_print_unsupported_script_warning)
7020         (maybe_print_script_not_found_warning, _initialize_auto_load):
7021         Update.
7022
7023 2019-05-08  Tom Tromey  <tom@tromey.com>
7024
7025         * objfiles.c (objfile_pspace_info): Add destructor and
7026         initializers.
7027         (objfiles_pspace_data): Change type.
7028         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7029         (get_objfile_pspace_data): Update.
7030         (objfiles_bfd_data): Change type.
7031         (get_objfile_bfd_data): Update.
7032         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7033
7034 2019-05-08  Tom Tromey  <tom@tromey.com>
7035
7036         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7037         Change type.
7038         (get_catch_syscall_inferior_data): Update.
7039         (catch_syscall_inferior_data_cleanup): Remove.
7040         (_initialize_break_catch_syscall): Update.
7041
7042 2019-05-08  Tom Tromey  <tom@tromey.com>
7043
7044         * inflow.c (struct terminal_info): Add destructor and
7045         initializers.
7046         (inflow_inferior_data): Change type.
7047         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7048         (get_inflow_inferior_data, inflow_inferior_exit)
7049         (swap_terminal_info, _initialize_inflow): Update.
7050
7051 2019-05-08  Tom Tromey  <tom@tromey.com>
7052
7053         * target-dcache.c (target_dcache_cleanup): Remove.
7054         (target_dcache_aspace_key): Change type.
7055         (target_dcache_init_p, target_dcache_invalidate)
7056         (target_dcache_get, target_dcache_get_or_init)
7057         (_initialize_target_dcache): Update.
7058         * dcache.h (struct dcache_deleter): New.
7059
7060 2019-05-08  Tom Tromey  <tom@tromey.com>
7061
7062         * symtab.c (struct symbol_cache): Add destructor and
7063         initializers.
7064         (symbol_cache_key): Move.  Change type.
7065         (make_symbol_cache, free_symbol_cache): Remove.
7066         (get_symbol_cache): Update.
7067         (symbol_cache_cleanup): Remove.
7068         (ALL_PSPACES, symbol_cache_flush)
7069         (maintenance_print_symbol_cache)
7070         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7071         Update.
7072
7073 2019-05-08  Tom Tromey  <tom@tromey.com>
7074
7075         * symtab.c (struct main_info): Add destructor and initializers.
7076         (main_progspace_key): Move.  Change type.
7077         (get_main_info): Update.
7078         (main_info_cleanup): Remove.
7079         (_initialize_symtab): Update.
7080
7081 2019-05-08  Tom Tromey  <tom@tromey.com>
7082
7083         * registry.h (DECLARE_REGISTRY): Define the _key class.
7084
7085 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7086
7087         * NEWS: Merge two 'New commands' sections.
7088
7089 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7090
7091         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7092         parameter and use Ada language definition instead.
7093         (ada_val_print_ptr): Remove unused language parameter.
7094         (ada_val_print_num): Remove language parameter and use Ada language
7095         definition instead.
7096         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7097         parameter.
7098         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7099         parameter and use Ada language definition instead.
7100         (ada_val_print_1): Update all ada_val_print_xxx calls.
7101         Remove language parameter.
7102         (ada_val_print): Update ada_val_print_1 call.
7103
7104 2019-05-08  Tom Tromey  <tromey@adacore.com>
7105
7106         * remote.c (remote_hw_watchpoint_limit)
7107         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7108         Now static.
7109
7110 2019-05-08  Tom Tromey  <tromey@adacore.com>
7111
7112         * maint.c (_initialize_maint_cmds): Move initialization code to
7113         remote.c.
7114         (watchdog, show_watchdog): Move to remote.c.
7115         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7116         "watchdog" static.
7117         (_initialize_remote): Move initialization code from maint.c.
7118         * defs.h (watchdog): Don't declare.
7119
7120 2019-05-08  Tom Tromey  <tromey@adacore.com>
7121
7122         * tui/tui-interp.c: Include main.h.
7123         * interps.c: Include main.h.
7124         * main.h (interpreter_p): Declare.
7125         * defs.h (interpreter_p): Don't declare.
7126
7127 2019-05-08  Tom Tromey  <tromey@adacore.com>
7128
7129         * dwarf2loc.c: Include dwarf2read.h.
7130         * defs.h (read_unsigned_leb128): Don't declare.
7131         * dwarf2read.h (read_unsigned_leb128): Declare.
7132
7133 2019-05-08  Tom Tromey  <tromey@adacore.com>
7134
7135         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7136         method.
7137
7138 2019-05-08  Tom Tromey  <tromey@adacore.com>
7139
7140         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7141         when no wrap column is set.
7142
7143 2019-05-08  Tom Tromey  <tromey@adacore.com>
7144
7145         * c-lang.c (c_get_string): Handle non-C-style arrays.
7146
7147 2019-05-08  Tom Tromey  <tromey@adacore.com>
7148
7149         * typeprint.c (print_offset_data::update): Print the bit offset,
7150         not the number of bits remaining.
7151
7152 2019-05-08  Tom Tromey  <tromey@adacore.com>
7153
7154         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7155         padding at end of comment.
7156
7157 2019-05-08  Tom Tromey  <tromey@adacore.com>
7158
7159         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7160         Compare main types.
7161
7162 2019-05-06  Tom Tromey  <tom@tromey.com>
7163
7164         * common/scoped_mmap.c: Include common-defs.h.
7165         * common/scoped_mmap.h: Don't include config.h.
7166
7167 2019-05-04  Tom Tromey  <tom@tromey.com>
7168
7169         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7170         (struct aarch64_call_info): Add initializers.
7171         <si>: Now a std::vector.
7172         (pass_on_stack, aarch64_push_dummy_call): Update.
7173
7174 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7175             Tom Tromey  <tom@tromey.com>
7176
7177         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7178         (ppc_threads): Now a std::vector.  Now static.
7179         (hwdebug_find_thread_points_by_tid)
7180         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7181         Update.
7182
7183 2019-05-04  Tom Tromey  <tom@tromey.com>
7184
7185         * arc-tdep.c (arc_tdesc_init): Return bool.
7186
7187 2019-05-04  Tom Tromey  <tom@tromey.com>
7188
7189         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7190         Use gdb_assert_not_reached.
7191
7192 2019-05-04  Tom Tromey  <tom@tromey.com>
7193
7194         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7195         "false".
7196
7197 2019-05-04  Tom Tromey  <tom@tromey.com>
7198
7199         * arc-tdep.c (arc_tdesc_init): Use bool.
7200
7201 2019-05-04  Tom Tromey  <tom@tromey.com>
7202
7203         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7204
7205 2019-05-04  Tom Tromey  <tom@tromey.com>
7206
7207         * cli/cli-cmds.c (valid_command_p): Return bool.
7208
7209 2019-05-04  Tom Tromey  <tom@tromey.com>
7210
7211         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7212         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7213
7214 2019-05-04  Raul Tambre  <raul@tambre.ee>
7215
7216         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7217         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7218         operator for comparison.
7219
7220 2019-05-04  Tom Tromey  <tom@tromey.com>
7221
7222         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7223         (lookup_partial_symbol, print_partial_symbols)
7224         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7225         (psymbol_compare): Update.
7226         (add_psymbol_to_bcache): Clear the entire psymbol.
7227         (maintenance_check_psymtabs): Update.
7228         * psympriv.h (struct partial_symbol): Don't derive from
7229         general_symbol_info.
7230         <obj_section, unrelocated_address, address,
7231         set_unrelocated_address>: Update.
7232         <ginfo>: New member.
7233         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7234         (debug_names::write_psymbols): Update.
7235
7236 2019-05-04  Tom de Vries  <tdevries@suse.de>
7237
7238         * contrib/cc-with-tweaks.sh: Support -n arg.
7239
7240 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7241
7242         * corelow.c (core_target::detach): Ensure frame cache and
7243         register caches are cleared.
7244         inferior.c (exit_inferior_1): Likewise.
7245
7246 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7247             Tom Tromey  <tom@tromey.com>
7248
7249         * dictionary.c (collate_pending_symbols_by_language): Remove
7250         "struct" from foreach.
7251         * symtab.c (lookup_global_symbol_from_objfile)
7252         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7253         foreach.
7254         * ser-tcp.c (net_open): Remove "struct" from foreach.
7255         * objfiles.c (objfile_relocate, objfile_rebase)
7256         (objfile_has_symbols): Remove "struct" from foreach.
7257         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7258         from foreach.
7259         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7260         foreach.
7261         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7262         "struct" from foreach.
7263         * ada-lang.c (create_excep_cond_exprs)
7264         (ada_exception_catchpoint_cond_string): Remove "struct" from
7265         foreach.
7266
7267 2019-05-03  Tom Tromey  <tromey@adacore.com>
7268
7269         * ada-exp.y (convert_char_literal): Check suffix of each
7270         enumerator.
7271
7272 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7273
7274         PR ada/21406:
7275         * ada-exp.y (yywrap): Don't define.
7276         * ada-lex.l (%option): Add noyywrap
7277         (yywrap): Remove.
7278
7279 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7280
7281         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7282         _WIN32_WINNT to the XP level, unless already defined to a higher
7283         level.
7284
7285         * unittests/parse-connection-spec-selftests.c:
7286         * ser-tcp.c:
7287         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7288         override.
7289
7290         * symfile.c (find_separate_debug_file): Remove colon from the
7291         drive spec of DOS/Windows file names of the target, so that the
7292         file name produced from DEBUGDIR and the target's directory will
7293         be valid on DOS/Windows systems.
7294
7295 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7296
7297         * rust-lang.c (val_print_struct): Handle printing structures
7298         containing strings.
7299
7300 2019-05-02  Tom Tromey  <tromey@adacore.com>
7301
7302         * valarith.c (_initialize_valarith): Remove.
7303
7304 2019-05-01  Tom Tromey  <tromey@adacore.com>
7305
7306         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7307         bitfields.
7308
7309 2019-05-01  Tom Tromey  <tromey@adacore.com>
7310
7311         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7312         for big-endian copies.
7313
7314 2019-04-30  Ali Tamur  <tamur@google.com>
7315         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7316         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7317         (read_3_bytes): New function.
7318
7319 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7320
7321         * windows-nat.c (main_thread_id): Delete.
7322         (handle_output_debug_string): Replace main_thread_id by
7323         current_event.dwThreadId.
7324         (fake_create_process): Likewise.
7325         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7326         Do not set main_thread_id.
7327         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7328         current_event.dwThreadId.
7329         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7330
7331 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7332
7333         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7334         Use current_event.dwThreadId instead of main_thread_id.
7335
7336 2019-04-30  Tom Tromey  <tromey@adacore.com>
7337
7338         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7339         (create_excep_cond_exprs): Iterate over program spaces.
7340         (ada_exception_catchpoint_cond_string): Examine all minimal
7341         symbols for exception types.
7342
7343 2019-04-30  Tom Tromey  <tromey@adacore.com>
7344
7345         PR c++/24470:
7346         * dwarf2read.c (process_structure_scope): Handle case where type
7347         has template parameters but no symbol was created.
7348
7349 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7350             Chris January  <chris.january@arm.com>
7351
7352         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7353         qualifier.
7354         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7355
7356 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7357
7358         * f-typeprint.c (f_print_type): Update rules for printing
7359         whitespace.
7360         (f_type_print_varspec_suffix): Likewise.
7361
7362 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7363             Chris January  <chris.january@arm.com>
7364
7365         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7366         function arguments.
7367
7368 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7369
7370         * f-lang.c (build_fortran_types): Change name of void type to
7371         lower case.
7372         * f-typeprint.c (f_type_print_base): Print the name of the void
7373         type, rather than a fixed string.
7374         * f-valprint.c (f_decorations): Use lower case void string.
7375
7376 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7377             Chris January  <chris.january@arm.com>
7378
7379         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7380         types for Fortran.
7381
7382 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7383             Chris January  <chris.january@arm.com>
7384             David Lecomber  <david.lecomber@arm.com>
7385
7386         * f-exp.y (BINOP_INTRINSIC): New token.
7387         (exp): New parser rule handling BINOP_INTRINSIC.
7388         (f77_keywords): Add new builtin procedures.
7389         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7390         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7391         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7392         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7393         (print_unop_subexp_f): New function.
7394         (print_binop_subexp_f): New function.
7395         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7396         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7397         (dump_subexp_body_f): Likewise.
7398         (operator_check_f): Likewise.
7399         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7400         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7401
7402 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7403
7404         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7405         UNOP_KIND.
7406         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7407         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7408         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7409         (operator_length_f): New fuction.
7410         (print_subexp_f): New function.
7411         (op_name_f): New function.
7412         (dump_subexp_body_f): New function.
7413         (operator_check_f): New function.
7414         (exp_descriptor_f): Replace standard expression handling functions
7415         with new functions.
7416         * gdb/fortran-operator.def: New file.
7417         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7418         * gdb/std-operator.def: Remove UNOP_KIND.
7419
7420 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7421
7422         * std-operator.def: Remove unbalanced, stray double quote
7423         character.
7424
7425 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7426             Chris January  <chris.january@arm.com>
7427             Daniel Everett  <daniel.everett@arm.com>
7428             Nick Forrington  <nick.forrington@arm.com>
7429             Richard Bunt  <richard.bunt@arm.com>
7430
7431         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7432         of depth when printing anonymous structs or unions.
7433         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7434         Don't print either the top-level value, or the children if the
7435         max-depth is exceeded.
7436         (ppscm_print_children): When printing the key of a map, allow one
7437         extra level of depth.
7438         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7439         print either the top-level value, or the children if the max-depth
7440         is exceeded.
7441         (print_children): When printing the key of a map, allow one extra
7442         level of depth.
7443         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7444         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7445         (user_print_options): Initialise max_depth field.
7446         (val_print_scalar_or_string_type_p): New function.
7447         (val_print): Check to see if the max depth has been reached.
7448         (val_print_check_max_depth): Define new function.
7449         (show_print_max_depth): New function.
7450         (_initialize_valprint): Add 'print max-depth' option.
7451         * valprint.h (struct value_print_options) <max_depth>: New field.
7452         (val_print_check_max_depth): Declare new function.
7453         * NEWS: Document new feature.
7454
7455 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7456
7457         * ada-lang.c (ada_language_defn): Initialise new field.
7458         * c-lang.c (c_is_string_type_p): New function.
7459         (c_language_defn): Initialise new field.
7460         (cplus_language_defn): Initialise new field.
7461         (asm_language_defn): Initialise new field.
7462         (minimal_language_defn): Initialise new field.
7463         * c-lang.h (c_is_string_type_p): Declare new function.
7464         * d-lang.c (d_language_defn): Initialise new field.
7465         * f-lang.c (f_is_string_type_p): New function.
7466         (f_language_defn): Initialise new field.
7467         * go-lang.c (go_is_string_type_p): New function.
7468         (go_language_defn): Initialise new field.
7469         * language.c (default_is_string_type_p): New function.
7470         (unknown_language_defn): Initialise new field.
7471         (auto_language_defn): Initialise new field.
7472         * language.h (struct language_defn) <la_is_string_type_p>: New
7473         member variable.
7474         (default_is_string_type_p): Declare new function.
7475         * m2-lang.c (m2_language_defn): Initialise new field.
7476         * objc-lang.c (objc_language_defn): Initialise new field.
7477         * opencl-lang.c (opencl_language_defn): Initialise new field.
7478         * p-lang.c (pascal_is_string_type_p): New function.
7479         (pascal_language_defn): Initialise new field.
7480         * rust-lang.c (rust_is_string_type_p): New function.
7481         (rust_language_defn): Initialise new field.
7482
7483 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7484
7485         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7486         New field.
7487         * ada-lang.c (ada_language_defn): Initialise new field.
7488         * c-lang.c (c_language_defn): Likewise.
7489         (cplus_language_defn): Likewise.
7490         (asm_language_defn): Likewise.
7491         (minimal_language_defn): Likewise.
7492         * d-lang.c (d_language_defn): Likewise.
7493         * f-lang.c (f_language_defn): Likewise.
7494         * go-lang.c (go_language_defn): Likewise.
7495         * language.c (unknown_language_defn): Likewise.
7496         (auto_language_defn): Likewise.
7497         * m2-lang.c (m2_language_defn): Likewise.
7498         * objc-lang.c (objc_language_defn): Likewise.
7499         * opencl-lang.c (opencl_language_defn): Likewise.
7500         * p-lang.c (pascal_language_defn): Likewise.
7501         * rust-lang.c (rust_language_defn): Likewise.
7502
7503 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7504
7505         * ada-lang.c (ada_is_character_type): Change return type to bool.
7506         (ada_is_string_type): Likewise.
7507         * ada-lang.h (ada_is_character_type): Update declaration
7508         (ada_is_string_type): Likewise.
7509
7510 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7511
7512         Support style in 'frame|thread apply'
7513
7514         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7515         * record.c (record_start, record_stop): Update callers of
7516         execute_command_to_string with false.
7517         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7518         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7519         methods.
7520         (class string_file): New constructor with term_out parameter.
7521         Override methods term_out and can_emit_style_escape.  New member
7522         term_out.
7523         (class stdio_file): Override can_emit_style_escape.
7524         (class tee_file): Override term_out and can_emit_style_escape.
7525         * utils.h (can_emit_style_escape): Remove.
7526         * utils.c (can_emit_style_escape): Likewise.
7527         Update all callers of can_emit_style_escape (SOMESTREAM) to
7528         SOMESTREAM->can_emit_style_escape.
7529         * source-cache.c (source_cache::get_source_lines): Likewise.
7530         * stack.c (frame_apply_command_count): Call execute_command_to_string
7531         passing the term_out characteristic of the current gdb_stdout.
7532         * thread.c (thr_try_catch_cmd): Likewise.
7533         * top.c (execute_command_to_string): pass term_out parameter
7534         to construct the string_file for the command output.
7535         * ui-file.c (term_cli_styling): New function (most code moved
7536         from utils.c can_emit_style_escape).
7537         (string_file::string_file, string_file::can_emit_style_escape,
7538         stdio_file::can_emit_style_escape, tee_file::term_out,
7539         tee_file::can_emit_style_escape): New functions.
7540
7541 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7542
7543         * NEWS: Mention the new set|show may-call-functions.
7544         * infcall.c (may_call_functions_p): New variable.
7545         (show_may_call_functions_p): New function.
7546         (call_function_by_hand_dummy): Throws an error if not
7547         may-call-functions.
7548         (_initialize_infcall): Call add_setshow_boolean_cmd for
7549         may-call-functions.
7550
7551 2019-04-25  Keith Seitz  <keiths@redhat.com>
7552
7553         PR c++/24367
7554         * cp-support.c (inspect_type): Don't attempt substitutions
7555         of symbol with the same name.
7556
7557 2019-04-25  Tom Tromey  <tromey@adacore.com>
7558
7559         PR gdb/24475:
7560         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7561         static.
7562
7563 2019-04-25  Tom Tromey  <tromey@adacore.com>
7564
7565         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7566         rvalue reference.
7567         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7568         (gdb_xml_parser::parse): Use std::move.
7569         * python/python-internal.h (gdbpy_convert_exception): Take a const
7570         reference.
7571         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7572         std::move.
7573         * python/py-utils.c (gdbpy_convert_exception): Take a const
7574         reference.
7575         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7576         Use std::move.
7577         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7578         Use std::move.
7579         * mi/mi-main.c (mi_print_exception): Take a const reference.
7580         * main.c (handle_command_errors): Take a const reference.
7581         * linespec.c (parse_linespec): Use std::move.
7582         * infcall.c (run_inferior_call): Use std::move.
7583         (call_function_by_hand_dummy): Use std::move.
7584         * exec.c (try_open_exec_file): Use std::move.
7585         * exceptions.h (exception_print, exception_fprintf)
7586         (exception_print_same): Update.
7587         * exceptions.c (print_exception, exception_print)
7588         (exception_fprintf, exception_print_same): Change parameters to
7589         const reference.
7590         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7591         * common/new-op.c: Use std::move.
7592         * common/common-exceptions.h (struct gdb_exception): Add move
7593         constructor.
7594         (struct gdb_exception_error, struct gdb_exception_quit, struct
7595         gdb_quit_bad_alloc): Change constructor to move constructor.
7596         (throw_exception): Change parameter to rvalue reference.
7597         * common/common-exceptions.c (throw_exception): Take rvalue
7598         reference.
7599         * cli/cli-interp.c (safe_execute_command): Use std::move.
7600         * breakpoint.c (insert_bp_location, location_to_sals): Use
7601         std::move.
7602
7603 2019-04-25  Tom Tromey  <tromey@adacore.com>
7604
7605         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7606         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7607         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7608         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7609         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7610         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7611         guile/scm-value.c: Use unpack.
7612         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7613         gdbscm_gdb_exception.
7614         (gdbscm_throw_gdb_exception): Likewise.
7615         (struct gdbscm_gdb_exception): New.
7616         (unpack): New function.
7617         (gdbscm_wrap): Use unpack.
7618
7619 2019-04-25  Tom Tromey  <tromey@adacore.com>
7620
7621         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7622         (gdb_rl_callback_handler): Use std::move.
7623         * common/common-exceptions.h (struct gdb_exception): Add move
7624         assignment operator.
7625         (throw_exception_sjlj): Change "exception" to const reference.
7626         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7627         (throw_exception_sjlj): Change "exception" to const reference.
7628
7629 2019-04-25  Tom Tromey  <tromey@adacore.com>
7630
7631         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7632         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7633         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7634         Update.
7635         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7636         Update.
7637         * mi/mi-interp.c (mi_interp::exec): Update.
7638         * linespec.c (parse_linespec): Update.
7639         * infcall.c (run_inferior_call): Update.
7640         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7641         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7642         (gdbscm_lookup_global_symbol): Update.
7643         * guile/scm-param.c (gdbscm_parameter_value): Update.
7644         * guile/scm-frame.c (gdbscm_frame_read_register)
7645         (gdbscm_frame_read_var): Update.
7646         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7647         * exec.c (try_open_exec_file): Update.
7648         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7649         (gdb_rl_callback_handler): Update.
7650         * common/common-exceptions.h (exception_none): Don't declare.
7651         * common/common-exceptions.c (exception_none): Don't define.
7652         (struct catcher) <exception>: Update.
7653         * cli/cli-interp.c (safe_execute_command): Update.
7654         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7655
7656 2019-04-25  Ali Tamur  <tamur@google.com>
7657
7658         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7659         (read_attribute_value): Likewise.
7660         (dwarf2_read_addr_index): Update comment.
7661         (read_str_index): Add DW_FORM_strx.
7662         (dwarf2_string_attr): Likewise.
7663         (dwarf2_const_value_attr): Likewise.
7664         (dump_die_shallow): Likewise.
7665         (dwarf2_fetch_constant_bytes): Likewise.
7666         (skip_form_bytes): Likewise.
7667         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7668
7669 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7670
7671         PR corefiles/11608
7672         PR corefiles/18187
7673         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7674         OFFSET.  Verify if current mapping contains an ELF header.
7675         (linux_find_memory_regions_full): Adjust call to
7676         dump_mapping_p.
7677
7678 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7679             Kang Li <kanglictf@gmail.com>
7680
7681         PR gdb/21600
7682
7683         * dwarf2-frame.c (read_initial_length): Be consistent about using
7684         unsigned representation of length.
7685         (decode_frame_entry_1): Likewise.  Check for wraparound of
7686         end pointer as well as buffer overflow.
7687
7688 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7689
7690         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7691         "vq".
7692
7693 2019-04-24  Tom Tromey  <tromey@adacore.com>
7694
7695         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7696
7697 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7698
7699         * s12z-tdep.c (s12z_unwind_pc): Delete.
7700         (s12z_unwind_sp): Delete.
7701         (s12z_gdbarch_init): Don't register deleted functions with
7702         gdbarch.
7703
7704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7705
7706         * rl78-tdep.c (rl78_unwind_sp): Delete.
7707         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7708
7709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7710
7711         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7712         (xstormy16_unwind_pc): Delete.
7713         (xstormy16_dummy_id): Delete.
7714         (xstormy16_gdbarch_init): Don't register deleted functions with
7715         gdbarch.
7716
7717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7718
7719         * vax-tdep.c (vax_unwind_pc): Delete.
7720         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7721
7722 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7723
7724         * v850-tdep.c (v850_unwind_sp): Delete.
7725         (v850_unwind_pc): Delete.
7726         (v850_dummy_id): Delete.
7727         (v850_gdbarch_init): Don't register deleted functions with
7728         gdbarch.
7729
7730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7731
7732         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7733         (tilegx_unwind_pc): Delete.
7734         (tilegx_unwind_dummy_id): Delete.
7735         (tilegx_gdbarch_init): Don't register deleted functions with
7736         gdbarch.
7737
7738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7739
7740         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7741         (tic6x_dummy_id): Delete.
7742         (tic6x_gdbarch_init): Don't register deleted functions with
7743         gdbarch.
7744
7745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7746
7747         * sparc-tdep.c (sparc_unwind_pc): Delete.
7748         (sparc32_gdbarch_init): Don't register deleted function with
7749         gdbarch.
7750
7751 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7752
7753         * sh-tdep.c (sh_unwind_sp): Delete.
7754         (sh_unwind_pc): Delete.
7755         (sh_dummy_id): Delete.
7756         (sh_gdbarch_init): Don't register deleted functions with
7757         gdbarch.
7758
7759 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7760
7761         * score-tdep.c (score_unwind_sp): Delete.
7762         (score_unwind_pc): Delete.
7763         (score_dummy_id): Delete.
7764         (score_gdbarch_init): Don't register deleted functions with
7765         gdbarch.
7766
7767 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7768
7769         * rx-tdep.c (rx_unwind_pc): Delete.
7770         (rx_unwind_sp): Delete.
7771         (rx_dummy_id): Delete.
7772         (rx_gdbarch_init): Don't register deleted functions with
7773         gdbarch.  Update comment.
7774
7775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7776
7777         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7778         (rs6000_dummy_id): Delete.
7779         (rs6000_gdbarch_init): Don't register deleted functions with
7780         gdbarch.
7781
7782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7783
7784         * or1k-tdep.c (or1k_dummy_id): Delete.
7785         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7786
7787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7788
7789         * nios2-tdep.c (nios2_dummy_id): Delete.
7790         (nios2_unwind_sp): Delete.
7791         (nios2_gdbarch_init): Don't register deleted functions with
7792         gdbarch.
7793
7794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7795
7796         * nds32-tdep.c (nds32_dummy_id): Delete.
7797         (nds32_unwind_pc): Delete.
7798         (nds32_unwind_sp): Delete.
7799         (nds32_gdbarch_init): Don't register deleted functions with
7800         gdbarch.
7801
7802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7803
7804         * msp430-tdep.c (msp430_unwind_pc): Delete.
7805         (msp430_unwind_sp): Delete.
7806         (msp430_dummy_id): Delete.
7807         (msp430_gdbarch_init): Don't register deleted functions with
7808         gdbarch.
7809
7810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7811
7812         * moxie-tdep.c (moxie_unwind_sp): Delete.
7813         (moxie_unwind_pc): Delete.
7814         (moxie_dummy_id): Delete.
7815         (moxie_gdbarch_init): Don't register deleted functions with
7816         gdbarch.
7817
7818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7819
7820         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7821         (mn10300_unwind_pc): Delete.
7822         (mn10300_unwind_sp): Delete.
7823         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7824         mn10300_unwind_sp.
7825         (mn10300_frame_unwind_init): Don't register deleted functions with
7826         gdbarch.
7827
7828 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7829
7830         * mep-tdep.c (mep_unwind_pc): Delete.
7831         (mep_unwind_sp): Delete.
7832         (mep_dummy_id): Delete.
7833         (mep_gdbarch_init): Don't register deleted functions with
7834         gdbarch.
7835
7836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7837
7838         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7839         (m68hc11_unwind_sp): Delete.
7840         (m68hc11_gdbarch_init): Don't register deleted functions with
7841         gdbarch.
7842
7843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7844
7845         * m32r-tdep.c (m32r_unwind_sp): Delete.
7846         (m32r_unwind_pc): Delete.
7847         (m32r_dummy_id): Delete.
7848         (m32r_gdbarch_init): Don't register deleted functions with
7849         gdbarch.
7850
7851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7852
7853         * m32c-tdep.c (m32c_unwind_pc): Delete.
7854         (m32c_unwind_sp): Delete.
7855         (m32c_dummy_id): Delete.
7856         (m32c_gdbarch_init): Don't register deleted functions with
7857         gdbarch.
7858
7859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7860
7861         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7862         (lm32_unwind_pc): Delete.
7863         (lm32_dummy_id): Delete.
7864         (lm32_gdbarch_init): Don't register deleted functions with
7865         gdbarch.
7866
7867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7868
7869         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7870         (iq2000_unwind_pc): Delete.
7871         (iq2000_dummy_id): Delete.
7872         (iq2000_gdbarch_init): Don't register deleted functions with
7873         gdbarch.
7874
7875 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7876
7877         * nds32-tdep.c (nds32_type_align): Delete.
7878         (nds32_push_dummy_call): Use type_align instead.
7879
7880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7881
7882         * arm-tdep.c (arm_type_align): Only handle vector override case.
7883         (arm_push_dummy_call): Use type_align.
7884         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7885
7886 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7887
7888         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7889         case.
7890         (pass_on_stack): Use type_align.
7891         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7892         function.
7893
7894 2019-04-23  Tom Tromey  <tromey@adacore.com>
7895
7896         * dwarf2read.c (line_header::file_name_at): Remove unused
7897         overload.
7898
7899 2019-04-23  Tom de Vries  <tdevries@suse.de>
7900
7901         PR gdb/24438
7902         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7903         invocation.
7904
7905
7906 2019-03-27  Ali Tamur  <tamur@google.com>
7907
7908         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7909         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7910         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7911         (dwarf_expr_context::get_addr_index): Likewise
7912         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7913         (symbol_needs_eval_context::get_addr_index): Likewise
7914         (disassemble_dwarf_expression): Add DW_OP_addrx
7915         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7916         (read_cutu_die_from_dwo): Update comment
7917         (skip_one_die): Add DW_FORM_addrx
7918         (read_attribute_value): Likewise
7919         (var_decode_location): Add DW_OP_addrx
7920         (dwarf2_const_value_attr): Add DW_FORM_addrx
7921         (dump_die_shallow): Likewise
7922         (dwarf2_fetch_constant_bytes): Likewise
7923         (decode_locdesc): Add DW_OP_addrx
7924         (skip_form_bytes): Add DW_FORM_addrx
7925
7926 2019-04-22  Ali Tamur  <tamur@google.com>
7927
7928         * MAINTAINERS (Write After Approval): Add self.
7929
7930 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7931
7932         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7933         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7934         (open_symbol_file_object): Likewise.
7935         (svr4_default_sos): Add info parameter.
7936         (svr4_read_so_list): Likewise.
7937         (svr4_current_sos_direct): Adjust functions calls to pass down
7938         info.
7939         (svr4_current_sos_1): Add info parameter.
7940         (svr4_current_sos): Call get_svr4_info, pass info down to
7941         svr4_current_sos_1.
7942         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7943         get_svr4_info.
7944         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7945         get_svr4_info.
7946         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7947         to get_svr4_info.
7948         (probes_table_remove_objfile_probes): Likewise.
7949         (register_solib_event_probe): Add info parameter.
7950         (solist_update_incremental): Pass info parameter down to
7951         svr4_read_so_list.
7952         (disable_probes_interface): Add info parameter.
7953         (svr4_handle_solib_event): Pass current_program_space to
7954         get_svr4_info.  Adjust disable_probes_interface cleanup.
7955         (svr4_create_probe_breakpoints): Add info parameter, pass it
7956         down to register_solib_event_probe.
7957         (svr4_create_solib_event_breakpoints): Add info parameter,
7958         pass it down to svr4_create_probe_breakpoints.
7959         (enable_break): Pass info down to
7960         svr4_create_solib_event_breakpoints.
7961         (svr4_solib_create_inferior_hook): Pass current_program_space to
7962         get_svr4_info.
7963         (svr4_clear_solib): Likewise.
7964
7965 2019-04-22  Pedro Alves  <palves@redhat.com>
7966
7967         * solib-svr4.c (svr4_free_objfile_observer): New.
7968         (probe_and_action::objfile): New field.
7969         (probes_table_htab_remove_objfile_probes)
7970         (probes_table_remove_objfile_probes): New functions.
7971         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7972         in the new probe_and_action.  Don't store the probe in 'lookup'.
7973         (svr4_create_probe_breakpoints): Pass objfile to
7974         register_solib_event_probe.
7975         (_initialize_svr4_solib): Register a free_objfile observer.
7976
7977 2019-04-19  Tom Tromey  <tom@tromey.com>
7978
7979         * common/queue.h: Remove.
7980
7981 2019-04-19  Tom Tromey  <tom@tromey.com>
7982
7983         * event-loop.c: Don't include "common/queue.h".
7984
7985 2019-04-19  Tom Tromey  <tom@tromey.com>
7986
7987         * remote.c (remote_target): Use delete.
7988         * remote-notif.h: Include <list>, not "common/queue.h".
7989         (notif_client_p): Remove typedef.
7990         (remote_notif_state): Add constructor, destructor, initializer.
7991         <notif_queue>: Now a std::list.
7992         (remote_notif_state_xfree): Don't declare.
7993         * remote-notif.c (remote_notif_process, handle_notification)
7994         (remote_notif_state_allocate): Update.
7995         (~remote_notif_state): Rename from remote_notif_state_xfree.
7996
7997 2019-04-19  Tom Tromey  <tom@tromey.com>
7998
7999         * symfile.c (reread_symbols): Update.
8000         * objfiles.c (objfile_register_static_link)
8001         (objfile_lookup_static_link): Update
8002         (~objfile) Don't delete static_links.
8003         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8004
8005 2019-04-19  Tom Tromey  <tom@tromey.com>
8006
8007         * type-stack.h (struct type_stack) <insert>: Constify string.
8008         * type-stack.c (type_stack::insert): Constify string.
8009         * gdbtypes.h (lookup_template_type): Update.
8010         (address_space_name_to_int): Update.
8011         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8012         const.
8013         (lookup_template_type): Make name const.
8014         * c-exp.y: Update rules.
8015         (lex_one_token, classify_name, classify_inner_name)
8016         (c_print_token): Update.
8017         * p-exp.y: Update rules.
8018         (yylex): Update.
8019         * f-exp.y: Update rules.
8020         (yylex): Update.
8021         * d-exp.y: Update rules.
8022         (lex_one_token, classify_name, classify_inner_name): Update.
8023         * parse.c (write_dollar_variable, copy_name): Return std::string.
8024         * parser-defs.h (copy_name): Change return type.
8025         * m2-exp.y: Update rules.
8026         (yylex): Update.
8027         * go-exp.y (lex_one_token): Update.
8028         Update rules.
8029         (classify_unsafe_function, classify_packaged_name)
8030         (classify_name, yylex): Update.
8031
8032 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8033
8034         * configure.ac: add --enable-source-highlight switch.
8035         * configure: Regenerate.
8036         * top.c (print_gdb_version): plumb --enable-source-highlight
8037         status to "show configuration".
8038
8039 2019-04-19  Tom Tromey  <tromey@adacore.com>
8040
8041         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8042         Check ADA_TYPE_P.
8043         (empty_record, ada_template_to_fixed_record_type_1)
8044         (template_to_static_fixed_type)
8045         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8046         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8047         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8048         macros.
8049
8050 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8051
8052         PR symtab/24423:
8053         * source.c (print_source_lines_base): Advance "iter" when a
8054         control character is seen.
8055
8056 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8057
8058         * inferior.h (struct infcall_suspend_state_deleter):
8059         Catch exception in destructor to avoid crash.
8060
8061 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8062
8063         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8064         close to the add_com "shell".
8065
8066 2019-04-18  Tom Tromey  <tromey@adacore.com>
8067
8068         * process-stratum-target.h (class process_stratum_target)
8069         <stratum>: Add "final".
8070
8071 2019-04-17  Tom Tromey  <tromey@adacore.com>
8072
8073         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8074         against nullptr before use.
8075
8076 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8077
8078         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8079
8080 2019-04-17  Jim Wilson  <jimw@sifive.com>
8081             Andrew Burgess  <andrew.burgess@embecosm.com>
8082
8083         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8084         code read might fail, assume 4-byte breakpoint in that case.
8085
8086 2019-04-15  Leszek Swirski  <leszeks@google.com>
8087
8088         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8089         rather than a hand-rolled POD check when checking for forced MEMORY
8090         classification.
8091
8092 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8093
8094         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8095         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8096         function.
8097         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8098         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8099         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8100         declaration.
8101
8102 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8103
8104         * aarch64-linux-nat.c
8105         (aarch64_linux_nat_target::thread_architecture): Add override.
8106         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8107         each VQ.
8108
8109 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8110
8111         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8112
8113 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8114
8115         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8116         target types of size 96-bits, add some additional comments, and
8117         check that the builtin type we found was the correct size.
8118
8119 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8120
8121         * utils.c (prompt_for_continue): Don't restore the styling at the
8122         end, as applied_style has the wrong value.  This fixes styling in
8123         long lists of file names that are interrupted by the "Continue?"
8124         prompt.
8125
8126 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8127
8128         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8129         * c-lang.c (c_language_defn): Likewise.
8130         (cplus_language_defn): Likewise.
8131         (asm_language_defn): Likewise.
8132         (minimal_language_defn): Likewise.
8133         * d-lang.c (d_language_defn): Likewise.
8134         * f-lang.c (f_language_defn): Likewise.
8135         * go-lang.c (go_language_defn): Likewise.
8136         * language.c (unknown_language_defn): Likewise.
8137         (auto_language_defn): Likewise.
8138         * language.h (struct language_defn): Remove la_magic field.
8139         (LANG_MAGIC): Delete.
8140         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8141         * objc-lang.c (objc_language_defn): Likewise.
8142         * opencl-lang.c (opencl_language_defn): Likewise.
8143         * p-lang.c (pascal_language_defn): Likewise.
8144         * rust-lang.c (rust_language_defn): Likewise.
8145
8146 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8147
8148         * riscv-tdep.c (riscv_type_align): New function.
8149         (riscv_type_alignment): Delete.
8150         (riscv_arg_location): Use 'type_align'.
8151         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8152
8153 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8154
8155         * gdbtypes.c (type_align): A struct with no non-static fields also
8156         has alignment of 1.
8157
8158 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8159
8160         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8161         component to 0.
8162         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8163         member.
8164         (riscv_struct_info::analyse): New implementation using new
8165         analyse_inner member function.
8166         (riscv_struct_info::field_offset): New member function.
8167         (riscv_struct_info::m_offsets): New member variable.
8168         (riscv_struct_info::analyse_inner): New private member function,
8169         takes the old implementation of riscv_struct_info::analyse but
8170         extended to track field offsets.
8171         (riscv_call_arg_struct): Update the struct folding special cases
8172         to handle cases where empty C++ structs, which are non-zero
8173         length, are found.
8174         (riscv_arg_location): Initialise the length of each location, a
8175         non-zero length now indicates the location is in use.
8176         (riscv_push_dummy_call): Allow for the first location having a
8177         non-zero offset when setting up arguments.
8178         (riscv_return_value): Likewise, but for return values.
8179
8180 2019-04-11  Tom Tromey  <tromey@adacore.com>
8181
8182         * utils.c (internal_vproblem): Make "msg" const.
8183
8184 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8185
8186         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8187         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8188         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8189         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8190
8191 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8192
8193         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8194         function.
8195         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8196         of amd64_collect_native_gregset.
8197         (amd64_linux_nat_target::store_registers): Likewise.
8198
8199 2019-04-10  Tom Tromey  <tom@tromey.com>
8200
8201         * symtab.c (lookup_global_symbol_from_objfile)
8202         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8203         * objfiles.h (class separate_debug_iterator): New.
8204         (class separate_debug_range): New.
8205         (struct objfile) <separate_debug_objfiles>: New method.
8206         (objfile_separate_debug_iterate): Don't declare.
8207         * objfiles.c (separate_debug_iterator::operator++): Rename from
8208         objfile_separate_debug_iterate.
8209         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8210         iterator.
8211         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8212         iterator.
8213
8214 2019-04-10  Tom Tromey  <tom@tromey.com>
8215
8216         * symfile.c (reread_symbols): Remove old comment.
8217         * objfiles.c (free_all_objfiles): Fix a typo.
8218
8219 2019-04-10  Tom Tromey  <tom@tromey.com>
8220
8221         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8222         * minsyms.c (lookup_minimal_symbol): Use foreach.
8223         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8224         (lookup_minimal_symbol_solib_trampoline): Likewise.
8225         * symfile.c (reread_symbols): Use foreach.
8226
8227 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8228             Tom Tromey  <tromey@adacore.com>
8229
8230         PR rust/24414:
8231         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8232         (rust_lex_int_test): Change "value" to be LONGEST.
8233         (rust_lex_tests): Add test for long integer literal.
8234
8235 2019-04-09  Tom Tromey  <tromey@adacore.com>
8236
8237         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8238         to bool.
8239         (extended_remote_target::attach): Update.
8240         (remote_target::remote_notice_new_inferior): Update.
8241         (remote_target::add_current_inferior_and_thread): Update.
8242         * inferior.c (exit_inferior_1): Use "false".
8243         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8244
8245 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8246
8247         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8248         the "start" command.
8249
8250 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8251
8252         * python/py-inferior.c (infpy_thread_from_thread_handle):
8253         Adjust comments to reflect renaming of thread_from_thread_handle
8254         to thread_from_handle.  Adjust keywords.  Fix type error message.
8255         (inferior_object_methods): Add thread_from_handle.  Retain
8256         thread_from_thread_handle, but mark it as deprecated.
8257
8258 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8259
8260         * gdbthread.h (find_thread_by_handle): Revise declaration.
8261         * thread.c (find_thread_by_handle): Likewise.  Adjust
8262         implementation too.
8263         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8264         support for buffer objects as handles.
8265
8266 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8267
8268         * python/py-infthread.c (thpy_thread_handle): New function.
8269         (thread_object_methods): Register thpy_thread_handle.
8270
8271 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8272
8273         * gdbthread.h (thread_to_thread_handle): Declare.
8274         * thread.c (gdbtypes.h): Include.
8275         (thread_to_thread_handle): New function.
8276
8277         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8278         (target_thread_info_to_thread_handle): Declare.
8279         * target.c (target_thread_info_to_thread_handle): New function.
8280         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8281         * target-delegates.c: Regenerate.
8282
8283         * linux-thread-db.c (class thread_db_target): Add method
8284         thread_info_to_thread_handle.
8285         (thread_db_target::thread_info_to_thread_handle): Define.
8286         * remote.c (class remote_target): Add new method
8287         thread_info_to_thread_handle.
8288         (remote_target::thread_info_to_thread_handle): Define.
8289
8290 2019-04-08  Pedro Alves  <palves@redhat.com>
8291
8292         * common/common-exceptions.c (throw_exception): Don't create
8293         named object to throw; throw directly.
8294         (throw_it): Likewise.  Don't initialize gdb_exception::message
8295         here, with new; pass FMT and AP to the ctor instead.
8296         * common/common-exceptions.h: Include <string>.
8297         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8298         const char *, va_list)): New ctor.  Use std::make_shared.
8299         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8300         errors)): Delete.
8301         (gdb_exception_error::gdb_exception_error(enum errors, const char
8302         *, va_list)): New.
8303         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8304         Add assertion.
8305         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8306         errors)): Delete.
8307         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8308         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8309         Add assertion.
8310
8311 2019-04-08  Tom Tromey  <tom@tromey.com>
8312
8313         * valops.c (value_rtti_indirect_type): Replace throw_exception
8314         with throw.
8315         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8316         with throw.
8317         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8318         throw.
8319         * target.c (target_translate_tls_address): Replace throw_exception
8320         with throw.
8321         * stack.c (frame_apply_command_count): Replace throw_exception
8322         with throw.
8323         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8324         throw.
8325         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8326         with throw.
8327         * rs6000-tdep.c (rs6000_frame_cache)
8328         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8329         * remote.c: Replace throw_exception with throw.
8330         * record-full.c (record_full_message, record_full_wait_1)
8331         (record_full_restore): Replace throw_exception with throw.
8332         * record-btrace.c:
8333         (get_thread_current_frame_id, record_btrace_start_replaying)
8334         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8335         (cmd_record_btrace_start): Replace throw_exception with throw.
8336         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8337         throw.
8338         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8339         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8340         * linespec.c:
8341         (find_linespec_symbols): Replace throw_exception with throw.
8342         * infrun.c (displaced_step_prepare, resume): Replace
8343         throw_exception with throw.
8344         * infcmd.c (post_create_inferior): Replace throw_exception with
8345         throw.
8346         * inf-loop.c (inferior_event_handler): Replace throw_exception
8347         with throw.
8348         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8349         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8350         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8351         (get_prev_frame_always, get_frame_pc_if_available)
8352         (get_frame_address_in_block_if_available, get_frame_language):
8353         Replace throw_exception with throw.
8354         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8355         throw_exception with throw.
8356         * eval.c (fetch_subexp_value, evaluate_var_value)
8357         (evaluate_funcall, evaluate_subexp_standard): Replace
8358         throw_exception with throw.
8359         * dwarf2loc.c (call_site_find_chain)
8360         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8361         Replace throw_exception with throw.
8362         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8363         with throw.
8364         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8365         throw.
8366         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8367         * completer.c (complete_line_internal): Replace throw_exception
8368         with throw.
8369         * compile/compile-object-run.c (compile_object_run): Replace
8370         throw_exception with throw.
8371         * cli/cli-script.c (process_next_line): Replace throw_exception
8372         with throw.
8373         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8374         (btrace_enable, btrace_maint_update_pt_packets): Replace
8375         throw_exception with throw.
8376         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8377         throw_exception with throw.
8378         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8379         throw_exception with throw.
8380         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8381         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8382         * aarch64-tdep.c (aarch64_make_prologue_cache)
8383         (aarch64_make_stub_cache): Replace throw_exception with throw.
8384
8385 2019-04-08  Tom Tromey  <tom@tromey.com>
8386
8387         * common/common-exceptions.c (throw_exception): Rename from
8388         throw_exception_cxx.  Remove old copy.  Make argument const.
8389         (throw_it): Create and throw exception objects directly.
8390         * common/common-exceptions.h (throw_exception): Make argument
8391         const.
8392         (struct gdb_exception_error): Add constructor.
8393         (struct gdb_exception_quit): Add constructor.
8394
8395 2019-04-08  Tom Tromey  <tom@tromey.com>
8396
8397         * common/common-exceptions.h (exception_rethrow): Don't declare.
8398         (TRY_SJLJ): Update comment.
8399         (TRY, CATCH, END_CATCH): Remove.
8400         * common/common-exceptions.c (exception_rethrow): Remove.
8401
8402 2019-04-08  Tom Tromey  <tom@tromey.com>
8403
8404         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8405         Remove.
8406         (gdb_exception_error): Rename from
8407         gdb_exception_RETURN_MASK_ERROR.
8408         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8409         (gdb_quit_bad_alloc): Update.
8410         * aarch64-tdep.c: Update.
8411         * ada-lang.c: Update.
8412         * ada-typeprint.c: Update.
8413         * ada-valprint.c: Update.
8414         * amd64-tdep.c: Update.
8415         * arch-utils.c: Update.
8416         * break-catch-throw.c: Update.
8417         * breakpoint.c: Update.
8418         * btrace.c: Update.
8419         * c-varobj.c: Update.
8420         * cli/cli-cmds.c: Update.
8421         * cli/cli-interp.c: Update.
8422         * cli/cli-script.c: Update.
8423         * common/common-exceptions.c: Update.
8424         * common/new-op.c: Update.
8425         * common/selftest.c: Update.
8426         * compile/compile-c-symbols.c: Update.
8427         * compile/compile-cplus-symbols.c: Update.
8428         * compile/compile-object-load.c: Update.
8429         * compile/compile-object-run.c: Update.
8430         * completer.c: Update.
8431         * corelow.c: Update.
8432         * cp-abi.c: Update.
8433         * cp-support.c: Update.
8434         * cp-valprint.c: Update.
8435         * darwin-nat.c: Update.
8436         * disasm-selftests.c: Update.
8437         * dtrace-probe.c: Update.
8438         * dwarf-index-cache.c: Update.
8439         * dwarf-index-write.c: Update.
8440         * dwarf2-frame-tailcall.c: Update.
8441         * dwarf2-frame.c: Update.
8442         * dwarf2loc.c: Update.
8443         * dwarf2read.c: Update.
8444         * eval.c: Update.
8445         * event-loop.c: Update.
8446         * event-top.c: Update.
8447         * exec.c: Update.
8448         * f-valprint.c: Update.
8449         * fbsd-tdep.c: Update.
8450         * frame-unwind.c: Update.
8451         * frame.c: Update.
8452         * gdbtypes.c: Update.
8453         * gnu-v3-abi.c: Update.
8454         * guile/guile-internal.h: Update.
8455         * guile/scm-block.c: Update.
8456         * guile/scm-breakpoint.c: Update.
8457         * guile/scm-cmd.c: Update.
8458         * guile/scm-disasm.c: Update.
8459         * guile/scm-frame.c: Update.
8460         * guile/scm-lazy-string.c: Update.
8461         * guile/scm-math.c: Update.
8462         * guile/scm-param.c: Update.
8463         * guile/scm-ports.c: Update.
8464         * guile/scm-pretty-print.c: Update.
8465         * guile/scm-symbol.c: Update.
8466         * guile/scm-symtab.c: Update.
8467         * guile/scm-type.c: Update.
8468         * guile/scm-value.c: Update.
8469         * i386-linux-tdep.c: Update.
8470         * i386-tdep.c: Update.
8471         * inf-loop.c: Update.
8472         * infcall.c: Update.
8473         * infcmd.c: Update.
8474         * infrun.c: Update.
8475         * jit.c: Update.
8476         * language.c: Update.
8477         * linespec.c: Update.
8478         * linux-fork.c: Update.
8479         * linux-nat.c: Update.
8480         * linux-tdep.c: Update.
8481         * linux-thread-db.c: Update.
8482         * main.c: Update.
8483         * mi/mi-cmd-break.c: Update.
8484         * mi/mi-cmd-stack.c: Update.
8485         * mi/mi-interp.c: Update.
8486         * mi/mi-main.c: Update.
8487         * objc-lang.c: Update.
8488         * p-valprint.c: Update.
8489         * parse.c: Update.
8490         * ppc-linux-tdep.c: Update.
8491         * printcmd.c: Update.
8492         * python/py-arch.c: Update.
8493         * python/py-breakpoint.c: Update.
8494         * python/py-cmd.c: Update.
8495         * python/py-finishbreakpoint.c: Update.
8496         * python/py-frame.c: Update.
8497         * python/py-framefilter.c: Update.
8498         * python/py-gdb-readline.c: Update.
8499         * python/py-inferior.c: Update.
8500         * python/py-infthread.c: Update.
8501         * python/py-lazy-string.c: Update.
8502         * python/py-linetable.c: Update.
8503         * python/py-objfile.c: Update.
8504         * python/py-param.c: Update.
8505         * python/py-prettyprint.c: Update.
8506         * python/py-progspace.c: Update.
8507         * python/py-record-btrace.c: Update.
8508         * python/py-record.c: Update.
8509         * python/py-symbol.c: Update.
8510         * python/py-type.c: Update.
8511         * python/py-unwind.c: Update.
8512         * python/py-utils.c: Update.
8513         * python/py-value.c: Update.
8514         * python/python.c: Update.
8515         * record-btrace.c: Update.
8516         * record-full.c: Update.
8517         * remote-fileio.c: Update.
8518         * remote.c: Update.
8519         * riscv-tdep.c: Update.
8520         * rs6000-aix-tdep.c: Update.
8521         * rs6000-tdep.c: Update.
8522         * rust-exp.y: Update.
8523         * rust-lang.c: Update.
8524         * s390-tdep.c: Update.
8525         * selftest-arch.c: Update.
8526         * solib-dsbt.c: Update.
8527         * solib-frv.c: Update.
8528         * solib-spu.c: Update.
8529         * solib-svr4.c: Update.
8530         * solib.c: Update.
8531         * sparc64-linux-tdep.c: Update.
8532         * stack.c: Update.
8533         * symfile-mem.c: Update.
8534         * symmisc.c: Update.
8535         * target.c: Update.
8536         * thread.c: Update.
8537         * top.c: Update.
8538         * tracefile-tfile.c: Update.
8539         * tui/tui.c: Update.
8540         * typeprint.c: Update.
8541         * unittests/cli-utils-selftests.c: Update.
8542         * unittests/parse-connection-spec-selftests.c: Update.
8543         * valops.c: Update.
8544         * valprint.c: Update.
8545         * value.c: Update.
8546         * varobj.c: Update.
8547         * windows-nat.c: Update.
8548         * x86-linux-nat.c: Update.
8549         * xml-support.c: Update.
8550
8551 2019-04-08  Tom Tromey  <tom@tromey.com>
8552
8553         * xml-support.c: Use C++ exception handling.
8554         * x86-linux-nat.c: Use C++ exception handling.
8555         * windows-nat.c: Use C++ exception handling.
8556         * varobj.c: Use C++ exception handling.
8557         * value.c: Use C++ exception handling.
8558         * valprint.c: Use C++ exception handling.
8559         * valops.c: Use C++ exception handling.
8560         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8561         handling.
8562         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8563         * typeprint.c: Use C++ exception handling.
8564         * tui/tui.c: Use C++ exception handling.
8565         * tracefile-tfile.c: Use C++ exception handling.
8566         * top.c: Use C++ exception handling.
8567         * thread.c: Use C++ exception handling.
8568         * target.c: Use C++ exception handling.
8569         * symmisc.c: Use C++ exception handling.
8570         * symfile-mem.c: Use C++ exception handling.
8571         * stack.c: Use C++ exception handling.
8572         * sparc64-linux-tdep.c: Use C++ exception handling.
8573         * solib.c: Use C++ exception handling.
8574         * solib-svr4.c: Use C++ exception handling.
8575         * solib-spu.c: Use C++ exception handling.
8576         * solib-frv.c: Use C++ exception handling.
8577         * solib-dsbt.c: Use C++ exception handling.
8578         * selftest-arch.c: Use C++ exception handling.
8579         * s390-tdep.c: Use C++ exception handling.
8580         * rust-lang.c: Use C++ exception handling.
8581         * rust-exp.y: Use C++ exception handling.
8582         * rs6000-tdep.c: Use C++ exception handling.
8583         * rs6000-aix-tdep.c: Use C++ exception handling.
8584         * riscv-tdep.c: Use C++ exception handling.
8585         * remote.c: Use C++ exception handling.
8586         * remote-fileio.c: Use C++ exception handling.
8587         * record-full.c: Use C++ exception handling.
8588         * record-btrace.c: Use C++ exception handling.
8589         * python/python.c: Use C++ exception handling.
8590         * python/py-value.c: Use C++ exception handling.
8591         * python/py-utils.c: Use C++ exception handling.
8592         * python/py-unwind.c: Use C++ exception handling.
8593         * python/py-type.c: Use C++ exception handling.
8594         * python/py-symbol.c: Use C++ exception handling.
8595         * python/py-record.c: Use C++ exception handling.
8596         * python/py-record-btrace.c: Use C++ exception handling.
8597         * python/py-progspace.c: Use C++ exception handling.
8598         * python/py-prettyprint.c: Use C++ exception handling.
8599         * python/py-param.c: Use C++ exception handling.
8600         * python/py-objfile.c: Use C++ exception handling.
8601         * python/py-linetable.c: Use C++ exception handling.
8602         * python/py-lazy-string.c: Use C++ exception handling.
8603         * python/py-infthread.c: Use C++ exception handling.
8604         * python/py-inferior.c: Use C++ exception handling.
8605         * python/py-gdb-readline.c: Use C++ exception handling.
8606         * python/py-framefilter.c: Use C++ exception handling.
8607         * python/py-frame.c: Use C++ exception handling.
8608         * python/py-finishbreakpoint.c: Use C++ exception handling.
8609         * python/py-cmd.c: Use C++ exception handling.
8610         * python/py-breakpoint.c: Use C++ exception handling.
8611         * python/py-arch.c: Use C++ exception handling.
8612         * printcmd.c: Use C++ exception handling.
8613         * ppc-linux-tdep.c: Use C++ exception handling.
8614         * parse.c: Use C++ exception handling.
8615         * p-valprint.c: Use C++ exception handling.
8616         * objc-lang.c: Use C++ exception handling.
8617         * mi/mi-main.c: Use C++ exception handling.
8618         * mi/mi-interp.c: Use C++ exception handling.
8619         * mi/mi-cmd-stack.c: Use C++ exception handling.
8620         * mi/mi-cmd-break.c: Use C++ exception handling.
8621         * main.c: Use C++ exception handling.
8622         * linux-thread-db.c: Use C++ exception handling.
8623         * linux-tdep.c: Use C++ exception handling.
8624         * linux-nat.c: Use C++ exception handling.
8625         * linux-fork.c: Use C++ exception handling.
8626         * linespec.c: Use C++ exception handling.
8627         * language.c: Use C++ exception handling.
8628         * jit.c: Use C++ exception handling.
8629         * infrun.c: Use C++ exception handling.
8630         * infcmd.c: Use C++ exception handling.
8631         * infcall.c: Use C++ exception handling.
8632         * inf-loop.c: Use C++ exception handling.
8633         * i386-tdep.c: Use C++ exception handling.
8634         * i386-linux-tdep.c: Use C++ exception handling.
8635         * guile/scm-value.c: Use C++ exception handling.
8636         * guile/scm-type.c: Use C++ exception handling.
8637         * guile/scm-symtab.c: Use C++ exception handling.
8638         * guile/scm-symbol.c: Use C++ exception handling.
8639         * guile/scm-pretty-print.c: Use C++ exception handling.
8640         * guile/scm-ports.c: Use C++ exception handling.
8641         * guile/scm-param.c: Use C++ exception handling.
8642         * guile/scm-math.c: Use C++ exception handling.
8643         * guile/scm-lazy-string.c: Use C++ exception handling.
8644         * guile/scm-frame.c: Use C++ exception handling.
8645         * guile/scm-disasm.c: Use C++ exception handling.
8646         * guile/scm-cmd.c: Use C++ exception handling.
8647         * guile/scm-breakpoint.c: Use C++ exception handling.
8648         * guile/scm-block.c: Use C++ exception handling.
8649         * guile/guile-internal.h: Use C++ exception handling.
8650         * gnu-v3-abi.c: Use C++ exception handling.
8651         * gdbtypes.c: Use C++ exception handling.
8652         * frame.c: Use C++ exception handling.
8653         * frame-unwind.c: Use C++ exception handling.
8654         * fbsd-tdep.c: Use C++ exception handling.
8655         * f-valprint.c: Use C++ exception handling.
8656         * exec.c: Use C++ exception handling.
8657         * event-top.c: Use C++ exception handling.
8658         * event-loop.c: Use C++ exception handling.
8659         * eval.c: Use C++ exception handling.
8660         * dwarf2read.c: Use C++ exception handling.
8661         * dwarf2loc.c: Use C++ exception handling.
8662         * dwarf2-frame.c: Use C++ exception handling.
8663         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8664         * dwarf-index-write.c: Use C++ exception handling.
8665         * dwarf-index-cache.c: Use C++ exception handling.
8666         * dtrace-probe.c: Use C++ exception handling.
8667         * disasm-selftests.c: Use C++ exception handling.
8668         * darwin-nat.c: Use C++ exception handling.
8669         * cp-valprint.c: Use C++ exception handling.
8670         * cp-support.c: Use C++ exception handling.
8671         * cp-abi.c: Use C++ exception handling.
8672         * corelow.c: Use C++ exception handling.
8673         * completer.c: Use C++ exception handling.
8674         * compile/compile-object-run.c: Use C++ exception handling.
8675         * compile/compile-object-load.c: Use C++ exception handling.
8676         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8677         * compile/compile-c-symbols.c: Use C++ exception handling.
8678         * common/selftest.c: Use C++ exception handling.
8679         * common/new-op.c: Use C++ exception handling.
8680         * cli/cli-script.c: Use C++ exception handling.
8681         * cli/cli-interp.c: Use C++ exception handling.
8682         * cli/cli-cmds.c: Use C++ exception handling.
8683         * c-varobj.c: Use C++ exception handling.
8684         * btrace.c: Use C++ exception handling.
8685         * breakpoint.c: Use C++ exception handling.
8686         * break-catch-throw.c: Use C++ exception handling.
8687         * arch-utils.c: Use C++ exception handling.
8688         * amd64-tdep.c: Use C++ exception handling.
8689         * ada-valprint.c: Use C++ exception handling.
8690         * ada-typeprint.c: Use C++ exception handling.
8691         * ada-lang.c: Use C++ exception handling.
8692         * aarch64-tdep.c: Use C++ exception handling.
8693
8694 2019-04-08  Tom Tromey  <tom@tromey.com>
8695
8696         * xml-support.c (gdb_xml_parser::parse): Update.
8697         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8698         * value.c (show_convenience): Update.
8699         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8700         (test_parse_flags_qcs): Update.
8701         * thread.c (thr_try_catch_cmd): Update.
8702         * target.c (target_translate_tls_address): Update.
8703         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8704         (info_frame_command_core, frame_apply_command_count): Update.
8705         * rust-exp.y (rust_lex_exception_test): Update.
8706         * riscv-tdep.c (riscv_print_one_register_info): Update.
8707         * remote.c (remote_target::enable_btrace): Update.
8708         * record-btrace.c (record_btrace_enable_warn): Update.
8709         * python/py-utils.c (gdbpy_convert_exception): Update.
8710         * printcmd.c (do_one_display, print_variable_and_value): Update.
8711         * mi/mi-main.c (mi_print_exception): Update.
8712         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8713         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8714         * linux-nat.c (linux_nat_target::attach): Update.
8715         * linux-fork.c (class scoped_switch_fork_info): Update.
8716         * infrun.c (displaced_step_prepare): Update.
8717         * infcall.c (call_function_by_hand_dummy): Update.
8718         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8719         * gnu-v3-abi.c (print_one_vtable): Update.
8720         * frame.c (get_prev_frame_always): Update.
8721         * f-valprint.c (info_common_command_for_block): Update.
8722         * exec.c (try_open_exec_file): Update.
8723         * exceptions.c (print_exception, exception_print)
8724         (exception_fprintf, exception_print_same): Update.
8725         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8726         * dwarf-index-cache.c (index_cache::store)
8727         (index_cache::lookup_gdb_index): Update.
8728         * darwin-nat.c (maybe_cache_shell): Update.
8729         * cp-valprint.c (cp_print_value_fields): Update.
8730         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8731         (gcc_cplus_symbol_address): Update.
8732         * compile/compile-c-symbols.c (gcc_convert_symbol)
8733         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8734         * common/selftest.c: Update.
8735         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8736         a std::string.
8737         (exception_try_scope_entry, exception_try_scope_exit): Don't
8738         declare.
8739         (struct exception_try_scope): Remove.
8740         (TRY): Don't use exception_try_scope.
8741         (struct gdb_exception): Add constructor, operator=.
8742         <what>: New method.
8743         (struct gdb_exception_RETURN_MASK_ALL)
8744         (struct gdb_exception_RETURN_MASK_ERROR)
8745         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8746         (struct gdb_quit_bad_alloc): Update.
8747         * common/common-exceptions.c (exception_none): Change
8748         initializer.
8749         (struct catcher) <state, exception>: Initialize inline.
8750         <prev>: Remove member.
8751         (current_catcher): Remove.
8752         (catchers): New global.
8753         (exceptions_state_mc_init): Simplify.
8754         (catcher_pop): Remove.
8755         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8756         (try_scope_depth, exception_try_scope_entry)
8757         (exception_try_scope_exit): Remove.
8758         (throw_exception_sjlj): Update.
8759         (exception_messages, exception_messages_size): Remove.
8760         (throw_it): Simplify.
8761         (gdb_exception_sliced_copy): Remove.
8762         (throw_exception_cxx): Update.
8763         * cli/cli-script.c (script_from_file): Update.
8764         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8765         Update.
8766         * ada-valprint.c (ada_val_print): Update.
8767         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8768         (create_excep_cond_exprs): Update.
8769
8770 2019-04-08  Tom Tromey  <tom@tromey.com>
8771
8772         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8773         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8774         (TRY, CATCH, END_CATCH): Remove some definitions.
8775         * common/common-exceptions.c: Don't use GDB_XCPT.
8776         (catcher_list_size): Remove.
8777         (throw_exception, throw_it): Simplify.
8778
8779 2019-04-05  Tom Tromey  <tom@tromey.com>
8780
8781         Revert the header-sorting patch.
8782         * ft32-tdep.c: Revert.
8783         * frv-tdep.c: Revert.
8784         * frv-linux-tdep.c: Revert.
8785         * frame.c: Revert.
8786         * frame-unwind.c: Revert.
8787         * frame-base.c: Revert.
8788         * fork-child.c: Revert.
8789         * findvar.c: Revert.
8790         * findcmd.c: Revert.
8791         * filesystem.c: Revert.
8792         * filename-seen-cache.h: Revert.
8793         * filename-seen-cache.c: Revert.
8794         * fbsd-tdep.c: Revert.
8795         * fbsd-nat.h: Revert.
8796         * fbsd-nat.c: Revert.
8797         * f-valprint.c: Revert.
8798         * f-typeprint.c: Revert.
8799         * f-lang.c: Revert.
8800         * extension.h: Revert.
8801         * extension.c: Revert.
8802         * extension-priv.h: Revert.
8803         * expprint.c: Revert.
8804         * exec.h: Revert.
8805         * exec.c: Revert.
8806         * exceptions.c: Revert.
8807         * event-top.c: Revert.
8808         * event-loop.c: Revert.
8809         * eval.c: Revert.
8810         * elfread.c: Revert.
8811         * dwarf2read.h: Revert.
8812         * dwarf2read.c: Revert.
8813         * dwarf2loc.c: Revert.
8814         * dwarf2expr.h: Revert.
8815         * dwarf2expr.c: Revert.
8816         * dwarf2-frame.c: Revert.
8817         * dwarf2-frame-tailcall.c: Revert.
8818         * dwarf-index-write.h: Revert.
8819         * dwarf-index-write.c: Revert.
8820         * dwarf-index-common.c: Revert.
8821         * dwarf-index-cache.h: Revert.
8822         * dwarf-index-cache.c: Revert.
8823         * dummy-frame.c: Revert.
8824         * dtrace-probe.c: Revert.
8825         * disasm.h: Revert.
8826         * disasm.c: Revert.
8827         * disasm-selftests.c: Revert.
8828         * dictionary.c: Revert.
8829         * dicos-tdep.c: Revert.
8830         * demangle.c: Revert.
8831         * dcache.h: Revert.
8832         * dcache.c: Revert.
8833         * darwin-nat.h: Revert.
8834         * darwin-nat.c: Revert.
8835         * darwin-nat-info.c: Revert.
8836         * d-valprint.c: Revert.
8837         * d-namespace.c: Revert.
8838         * d-lang.c: Revert.
8839         * ctf.c: Revert.
8840         * csky-tdep.c: Revert.
8841         * csky-linux-tdep.c: Revert.
8842         * cris-tdep.c: Revert.
8843         * cris-linux-tdep.c: Revert.
8844         * cp-valprint.c: Revert.
8845         * cp-support.c: Revert.
8846         * cp-namespace.c: Revert.
8847         * cp-abi.c: Revert.
8848         * corelow.c: Revert.
8849         * corefile.c: Revert.
8850         * continuations.c: Revert.
8851         * completer.h: Revert.
8852         * completer.c: Revert.
8853         * complaints.c: Revert.
8854         * coffread.c: Revert.
8855         * coff-pe-read.c: Revert.
8856         * cli-out.h: Revert.
8857         * cli-out.c: Revert.
8858         * charset.c: Revert.
8859         * c-varobj.c: Revert.
8860         * c-valprint.c: Revert.
8861         * c-typeprint.c: Revert.
8862         * c-lang.c: Revert.
8863         * buildsym.c: Revert.
8864         * buildsym-legacy.c: Revert.
8865         * build-id.h: Revert.
8866         * build-id.c: Revert.
8867         * btrace.c: Revert.
8868         * bsd-uthread.c: Revert.
8869         * breakpoint.h: Revert.
8870         * breakpoint.c: Revert.
8871         * break-catch-throw.c: Revert.
8872         * break-catch-syscall.c: Revert.
8873         * break-catch-sig.c: Revert.
8874         * blockframe.c: Revert.
8875         * block.c: Revert.
8876         * bfin-tdep.c: Revert.
8877         * bfin-linux-tdep.c: Revert.
8878         * bfd-target.c: Revert.
8879         * bcache.c: Revert.
8880         * ax-general.c: Revert.
8881         * ax-gdb.h: Revert.
8882         * ax-gdb.c: Revert.
8883         * avr-tdep.c: Revert.
8884         * auxv.c: Revert.
8885         * auto-load.c: Revert.
8886         * arm-wince-tdep.c: Revert.
8887         * arm-tdep.c: Revert.
8888         * arm-symbian-tdep.c: Revert.
8889         * arm-pikeos-tdep.c: Revert.
8890         * arm-obsd-tdep.c: Revert.
8891         * arm-nbsd-tdep.c: Revert.
8892         * arm-nbsd-nat.c: Revert.
8893         * arm-linux-tdep.c: Revert.
8894         * arm-linux-nat.c: Revert.
8895         * arm-fbsd-tdep.c: Revert.
8896         * arm-fbsd-nat.c: Revert.
8897         * arm-bsd-tdep.c: Revert.
8898         * arch-utils.c: Revert.
8899         * arc-tdep.c: Revert.
8900         * arc-newlib-tdep.c: Revert.
8901         * annotate.h: Revert.
8902         * annotate.c: Revert.
8903         * amd64-windows-tdep.c: Revert.
8904         * amd64-windows-nat.c: Revert.
8905         * amd64-tdep.c: Revert.
8906         * amd64-sol2-tdep.c: Revert.
8907         * amd64-obsd-tdep.c: Revert.
8908         * amd64-obsd-nat.c: Revert.
8909         * amd64-nbsd-tdep.c: Revert.
8910         * amd64-nbsd-nat.c: Revert.
8911         * amd64-nat.c: Revert.
8912         * amd64-linux-tdep.c: Revert.
8913         * amd64-linux-nat.c: Revert.
8914         * amd64-fbsd-tdep.c: Revert.
8915         * amd64-fbsd-nat.c: Revert.
8916         * amd64-dicos-tdep.c: Revert.
8917         * amd64-darwin-tdep.c: Revert.
8918         * amd64-bsd-nat.c: Revert.
8919         * alpha-tdep.c: Revert.
8920         * alpha-obsd-tdep.c: Revert.
8921         * alpha-nbsd-tdep.c: Revert.
8922         * alpha-mdebug-tdep.c: Revert.
8923         * alpha-linux-tdep.c: Revert.
8924         * alpha-linux-nat.c: Revert.
8925         * alpha-bsd-tdep.c: Revert.
8926         * alpha-bsd-nat.c: Revert.
8927         * aix-thread.c: Revert.
8928         * agent.c: Revert.
8929         * addrmap.c: Revert.
8930         * ada-varobj.c: Revert.
8931         * ada-valprint.c: Revert.
8932         * ada-typeprint.c: Revert.
8933         * ada-tasks.c: Revert.
8934         * ada-lang.c: Revert.
8935         * aarch64-tdep.c: Revert.
8936         * aarch64-ravenscar-thread.c: Revert.
8937         * aarch64-newlib-tdep.c: Revert.
8938         * aarch64-linux-tdep.c: Revert.
8939         * aarch64-linux-nat.c: Revert.
8940         * aarch64-fbsd-tdep.c: Revert.
8941         * aarch64-fbsd-nat.c: Revert.
8942         * aarch32-linux-nat.c: Revert.
8943
8944 2019-04-05  Tom Tromey  <tom@tromey.com>
8945
8946         * ft32-tdep.c: Sort headers.
8947         * frv-tdep.c: Sort headers.
8948         * frv-linux-tdep.c: Sort headers.
8949         * frame.c: Sort headers.
8950         * frame-unwind.c: Sort headers.
8951         * frame-base.c: Sort headers.
8952         * fork-child.c: Sort headers.
8953         * findvar.c: Sort headers.
8954         * findcmd.c: Sort headers.
8955         * filesystem.c: Sort headers.
8956         * filename-seen-cache.h: Sort headers.
8957         * filename-seen-cache.c: Sort headers.
8958         * fbsd-tdep.c: Sort headers.
8959         * fbsd-nat.h: Sort headers.
8960         * fbsd-nat.c: Sort headers.
8961         * f-valprint.c: Sort headers.
8962         * f-typeprint.c: Sort headers.
8963         * f-lang.c: Sort headers.
8964         * extension.h: Sort headers.
8965         * extension.c: Sort headers.
8966         * extension-priv.h: Sort headers.
8967         * expprint.c: Sort headers.
8968         * exec.h: Sort headers.
8969         * exec.c: Sort headers.
8970         * exceptions.c: Sort headers.
8971         * event-top.c: Sort headers.
8972         * event-loop.c: Sort headers.
8973         * eval.c: Sort headers.
8974         * elfread.c: Sort headers.
8975         * dwarf2read.h: Sort headers.
8976         * dwarf2read.c: Sort headers.
8977         * dwarf2loc.c: Sort headers.
8978         * dwarf2expr.h: Sort headers.
8979         * dwarf2expr.c: Sort headers.
8980         * dwarf2-frame.c: Sort headers.
8981         * dwarf2-frame-tailcall.c: Sort headers.
8982         * dwarf-index-write.h: Sort headers.
8983         * dwarf-index-write.c: Sort headers.
8984         * dwarf-index-common.c: Sort headers.
8985         * dwarf-index-cache.h: Sort headers.
8986         * dwarf-index-cache.c: Sort headers.
8987         * dummy-frame.c: Sort headers.
8988         * dtrace-probe.c: Sort headers.
8989         * disasm.h: Sort headers.
8990         * disasm.c: Sort headers.
8991         * disasm-selftests.c: Sort headers.
8992         * dictionary.c: Sort headers.
8993         * dicos-tdep.c: Sort headers.
8994         * demangle.c: Sort headers.
8995         * dcache.h: Sort headers.
8996         * dcache.c: Sort headers.
8997         * darwin-nat.h: Sort headers.
8998         * darwin-nat.c: Sort headers.
8999         * darwin-nat-info.c: Sort headers.
9000         * d-valprint.c: Sort headers.
9001         * d-namespace.c: Sort headers.
9002         * d-lang.c: Sort headers.
9003         * ctf.c: Sort headers.
9004         * csky-tdep.c: Sort headers.
9005         * csky-linux-tdep.c: Sort headers.
9006         * cris-tdep.c: Sort headers.
9007         * cris-linux-tdep.c: Sort headers.
9008         * cp-valprint.c: Sort headers.
9009         * cp-support.c: Sort headers.
9010         * cp-namespace.c: Sort headers.
9011         * cp-abi.c: Sort headers.
9012         * corelow.c: Sort headers.
9013         * corefile.c: Sort headers.
9014         * continuations.c: Sort headers.
9015         * completer.h: Sort headers.
9016         * completer.c: Sort headers.
9017         * complaints.c: Sort headers.
9018         * coffread.c: Sort headers.
9019         * coff-pe-read.c: Sort headers.
9020         * cli-out.h: Sort headers.
9021         * cli-out.c: Sort headers.
9022         * charset.c: Sort headers.
9023         * c-varobj.c: Sort headers.
9024         * c-valprint.c: Sort headers.
9025         * c-typeprint.c: Sort headers.
9026         * c-lang.c: Sort headers.
9027         * buildsym.c: Sort headers.
9028         * buildsym-legacy.c: Sort headers.
9029         * build-id.h: Sort headers.
9030         * build-id.c: Sort headers.
9031         * btrace.c: Sort headers.
9032         * bsd-uthread.c: Sort headers.
9033         * breakpoint.h: Sort headers.
9034         * breakpoint.c: Sort headers.
9035         * break-catch-throw.c: Sort headers.
9036         * break-catch-syscall.c: Sort headers.
9037         * break-catch-sig.c: Sort headers.
9038         * blockframe.c: Sort headers.
9039         * block.c: Sort headers.
9040         * bfin-tdep.c: Sort headers.
9041         * bfin-linux-tdep.c: Sort headers.
9042         * bfd-target.c: Sort headers.
9043         * bcache.c: Sort headers.
9044         * ax-general.c: Sort headers.
9045         * ax-gdb.h: Sort headers.
9046         * ax-gdb.c: Sort headers.
9047         * avr-tdep.c: Sort headers.
9048         * auxv.c: Sort headers.
9049         * auto-load.c: Sort headers.
9050         * arm-wince-tdep.c: Sort headers.
9051         * arm-tdep.c: Sort headers.
9052         * arm-symbian-tdep.c: Sort headers.
9053         * arm-pikeos-tdep.c: Sort headers.
9054         * arm-obsd-tdep.c: Sort headers.
9055         * arm-nbsd-tdep.c: Sort headers.
9056         * arm-nbsd-nat.c: Sort headers.
9057         * arm-linux-tdep.c: Sort headers.
9058         * arm-linux-nat.c: Sort headers.
9059         * arm-fbsd-tdep.c: Sort headers.
9060         * arm-fbsd-nat.c: Sort headers.
9061         * arm-bsd-tdep.c: Sort headers.
9062         * arch-utils.c: Sort headers.
9063         * arc-tdep.c: Sort headers.
9064         * arc-newlib-tdep.c: Sort headers.
9065         * annotate.h: Sort headers.
9066         * annotate.c: Sort headers.
9067         * amd64-windows-tdep.c: Sort headers.
9068         * amd64-windows-nat.c: Sort headers.
9069         * amd64-tdep.c: Sort headers.
9070         * amd64-sol2-tdep.c: Sort headers.
9071         * amd64-obsd-tdep.c: Sort headers.
9072         * amd64-obsd-nat.c: Sort headers.
9073         * amd64-nbsd-tdep.c: Sort headers.
9074         * amd64-nbsd-nat.c: Sort headers.
9075         * amd64-nat.c: Sort headers.
9076         * amd64-linux-tdep.c: Sort headers.
9077         * amd64-linux-nat.c: Sort headers.
9078         * amd64-fbsd-tdep.c: Sort headers.
9079         * amd64-fbsd-nat.c: Sort headers.
9080         * amd64-dicos-tdep.c: Sort headers.
9081         * amd64-darwin-tdep.c: Sort headers.
9082         * amd64-bsd-nat.c: Sort headers.
9083         * alpha-tdep.c: Sort headers.
9084         * alpha-obsd-tdep.c: Sort headers.
9085         * alpha-nbsd-tdep.c: Sort headers.
9086         * alpha-mdebug-tdep.c: Sort headers.
9087         * alpha-linux-tdep.c: Sort headers.
9088         * alpha-linux-nat.c: Sort headers.
9089         * alpha-bsd-tdep.c: Sort headers.
9090         * alpha-bsd-nat.c: Sort headers.
9091         * aix-thread.c: Sort headers.
9092         * agent.c: Sort headers.
9093         * addrmap.c: Sort headers.
9094         * ada-varobj.c: Sort headers.
9095         * ada-valprint.c: Sort headers.
9096         * ada-typeprint.c: Sort headers.
9097         * ada-tasks.c: Sort headers.
9098         * ada-lang.c: Sort headers.
9099         * aarch64-tdep.c: Sort headers.
9100         * aarch64-ravenscar-thread.c: Sort headers.
9101         * aarch64-newlib-tdep.c: Sort headers.
9102         * aarch64-linux-tdep.c: Sort headers.
9103         * aarch64-linux-nat.c: Sort headers.
9104         * aarch64-fbsd-tdep.c: Sort headers.
9105         * aarch64-fbsd-nat.c: Sort headers.
9106         * aarch32-linux-nat.c: Sort headers.
9107
9108 2019-04-04  Tom Tromey  <tom@tromey.com>
9109
9110         * varobj.c (varobj_create): Update.
9111         * rust-exp.y (struct rust_parser) <update_innermost_block,
9112         lookup_symbol>: New methods.
9113         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9114         Rename.
9115         (rust_parser::rust_lookup_type)
9116         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9117         * printcmd.c (display_command, do_one_display): Update.
9118         * parser-defs.h (struct parser_state) <parser_state>: Add
9119         "tracker" parameter.
9120         (block_tracker): New member.
9121         (class innermost_block_tracker) <innermost_block_tracker>: Add
9122         "types" parameter.
9123         <reset>: Remove method.
9124         (innermost_block): Don't declare.
9125         (null_post_parser): Update.
9126         * parse.c (innermost_block): Remove global.
9127         (write_dollar_variable): Update.
9128         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9129         Remove "tracker_types" parameter.
9130         (parse_expression): Add "tracker" parameter.
9131         (parse_expression_for_completion): Update.
9132         (null_post_parser): Add "tracker" parameter.
9133         * p-exp.y: Update rules.
9134         * m2-exp.y: Update rules.
9135         * language.h (struct language_defn) <la_post_parser>: Add
9136         "tracker" parameter.
9137         * go-exp.y: Update rules.
9138         * f-exp.y: Update rules.
9139         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9140         parameter.
9141         * d-exp.y: Update rules.
9142         * c-exp.y: Update rules.
9143         * breakpoint.c (set_breakpoint_condition): Create an
9144         innermost_block_tracker.
9145         (watch_command_1): Likewise.
9146         * ada-lang.c (resolve): Add "tracker" parameter.
9147         (resolve_subexp): Likewise.
9148         * ada-exp.y (write_var_from_sym): Update.
9149
9150 2019-04-04  Tom Tromey  <tom@tromey.com>
9151
9152         * type-stack.h: New file.
9153         * type-stack.c: New file.
9154         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9155         type-stack.h.
9156         (insert_into_type_stack, insert_type, push_type, push_type_int)
9157         (insert_type_address_space, pop_type, pop_type_int)
9158         (pop_typelist, pop_type_stack, append_type_stack)
9159         (push_type_stack, get_type_stack, push_typelist)
9160         (follow_type_instance_flags, follow_types): Don't declare.
9161         * parse.c (type_stack): Remove global.
9162         (parse_exp_in_context): Update.
9163         (insert_into_type_stack, insert_type, push_type, push_type_int)
9164         (insert_type_address_space, pop_type, pop_type_int)
9165         (pop_typelist, pop_type_stack, append_type_stack)
9166         (push_type_stack, get_type_stack, push_typelist)
9167         (follow_type_instance_flags, follow_types): Remove (moved to
9168         type-stack.c).
9169         * f-exp.y (type_stack): New global.
9170         Update rules.
9171         (push_kind_type, f_parse): Update.
9172         * d-exp.y (type_stack): New global.
9173         Update rules.
9174         (d_parse): Update.
9175         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9176         Update rules.
9177         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9178         (HFILES_NO_SRCDIR): Add type-stack.h.
9179
9180 2019-04-04  Tom Tromey  <tom@tromey.com>
9181
9182         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9183         (rust_parser::convert_ast_to_expression, rust_parse)
9184         (rust_lex_test_completion, rust_lex_tests): Update.
9185         * parser-defs.h (struct expr_completion_state): New.
9186         (struct parser_state) <parser_state>: Add completion parameter.
9187         <mark_struct_expression, mark_completion_tag>: New methods.
9188         <parse_completion, m_completion_state>: New members.
9189         (prefixify_expression, null_post_parser): Update.
9190         (mark_struct_expression, mark_completion_tag): Don't declare.
9191         * parse.c (parse_completion, expout_last_struct)
9192         (expout_tag_completion_type, expout_completion_name): Remove
9193         globals.
9194         (parser_state::mark_struct_expression)
9195         (parser_state::mark_completion_tag): Now methods.
9196         (prefixify_expression): Add last_struct parameter.
9197         (prefixify_subexp): Likewise.
9198         (parse_exp_1): Update.
9199         (parse_exp_in_context): Add cstate parameter.  Update.
9200         (parse_expression_for_completion): Create an
9201         expr_completion_state.
9202         (null_post_parser): Add "completion" parameter.
9203         * p-exp.y: Update rules.
9204         (yylex): Update.
9205         * language.h (struct language_defn) <la_post_parser>: Add
9206         "completing" parameter.
9207         * go-exp.y: Update rules.
9208         (lex_one_token): Update.
9209         * expression.h (parse_completion): Don't declare.
9210         * d-exp.y: Update rules.
9211         (lex_one_token): Update rules.
9212         * c-exp.y: Update rules.
9213         (lex_one_token): Update.
9214         * ada-lang.c (resolve): Add "parse_completion" parameter.
9215         (resolve_subexp): Likewise.
9216         (ada_resolve_function): Likewise.
9217
9218 2019-04-04  Tom Tromey  <tom@tromey.com>
9219
9220         * parser-defs.h (struct parser_state) <start_arglist,
9221         end_arglist>: New methods.
9222         <arglist_len, m_funcall_chain>: New members.
9223         (arglist_len, start_arglist, end_arglist): Don't declare.
9224         * parse.c (arglist_len, funcall_chain): Remove global.
9225         (start_arglist, end_arglist): Remove functions.
9226         (parse_exp_in_context): Update.
9227         * p-exp.y: Update rules.
9228         * m2-exp.y: Update rules.
9229         * go-exp.y: Update rules.
9230         * f-exp.y: Update rules.
9231         * d-exp.y: Update rules.
9232         * c-exp.y: Update rules.
9233
9234 2019-04-04  Tom Tromey  <tom@tromey.com>
9235
9236         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9237         lex_operator, push_back>: New methods.
9238         Update all rules.
9239         (rust_parser::lex_hex, lex_escape): Rename and update.
9240         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9241         (rust_parser::lex_operator): Rename and update.
9242         (rust_parser::lex_number, rustyylex, rustyyerror)
9243         (rust_lex_test_init, rust_lex_test_sequence)
9244         (rust_lex_test_push_back, rust_lex_tests): Update.
9245         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9246         parameter.
9247         <lexptr, prev_lexptr>: New members.
9248         (lexptr, prev_lexptr): Don't declare.
9249         * parse.c (lexptr, prev_lexptr): Remove globals.
9250         (parse_exp_in_context): Update.
9251         * p-exp.y (yylex, yyerror): Update.
9252         * m2-exp.y (parse_number, yylex, yyerror): Update.
9253         * go-exp.y (lex_one_token, yyerror): Update.
9254         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9255         * d-exp.y (lex_one_token, yyerror): Update.
9256         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9257         (lex_one_token, yyerror): Update.
9258         * ada-lex.l (YY_INPUT): Update.
9259         (rewind_to_char): Update.
9260         * ada-exp.y (yyerror): Update.
9261
9262 2019-04-04  Tom Tromey  <tom@tromey.com>
9263
9264         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9265         * parser-defs.h (struct parser_state) <parser_state>: Add new
9266         parameter.
9267         <comma_terminates>: New member.
9268         (comma_terminates): Don't declare global.
9269         * parse.c (comma_terminates): Remove global.
9270         (parse_exp_in_context): Update.
9271         * p-exp.y (yylex): Update.
9272         * m2-exp.y (yylex): Update.
9273         * go-exp.y (lex_one_token): Update.
9274         * f-exp.y (yylex): Update.
9275         * d-exp.y (lex_one_token): Update.
9276         * c-exp.y (lex_one_token): Update.
9277         * ada-lex.l: Update.
9278
9279 2019-04-04  Tom Tromey  <tom@tromey.com>
9280
9281         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9282         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9283         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9284         * parser-defs.h (paren_depth): Don't declare.
9285         * parse.c (paren_depth): Remove global.
9286         (parse_exp_in_context): Update.
9287         * p-exp.y (paren_depth): New global.
9288         (pascal_parse): Initialize it.
9289         * m2-exp.y (paren_depth): New global.
9290         (m2_parse): Initialize it.
9291         * go-exp.y (paren_depth): New global.
9292         (go_parse): Initialize it.
9293         * f-exp.y (paren_depth): New global.
9294         (f_parse): Initialize it.
9295         * d-exp.y (paren_depth): New global.
9296         (d_parse): Initialize it.
9297         * c-exp.y (paren_depth): New global.
9298         (c_parse): Initialize it.
9299         * ada-lex.l (paren_depth): New global.
9300         (lexer_init): Initialize it.
9301
9302 2019-04-04  Tom Tromey  <tom@tromey.com>
9303
9304         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9305         (rust_parser::convert_ast_to_type)
9306         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9307         * parser-defs.h (struct parser_state) <parser_state>: Add
9308         parameters.  Initialize new members.
9309         <expression_context_block, expression_context_pc>: New members.
9310         * parse.c (expression_context_block, expression_context_pc):
9311         Remove globals.
9312         (parse_exp_in_context): Update.
9313         * p-exp.y: Update all rules.
9314         (yylex): Update.
9315         * m2-exp.y: Update all rules.
9316         (yylex): Update.
9317         * go-exp.y (yylex): Update.
9318         * f-exp.y (yylex): Update.
9319         * d-exp.y: Update all rules.
9320         (yylex): Update.
9321         * c-exp.y: Update all rules.
9322         (lex_one_token, classify_name, yylex, c_parse): Update.
9323         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9324
9325 2019-04-04  Tom Tromey  <tom@tromey.com>
9326
9327         * gdbarch.h, gdbarch.c: Rebuild.
9328         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9329         * stap-probe.h:
9330         (struct stap_parse_info): Replace "parser_state" with
9331         "expr_builder".
9332         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9333         (parser_state): New class.
9334         * parse.c (expr_builder): Rename.
9335         (expr_builder::release): Rename.
9336         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9337         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9338         (write_exp_elt_longcst, write_exp_elt_floatcst)
9339         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9340         (write_exp_string_vector, write_exp_bitstring)
9341         (write_exp_msymbol, mark_struct_expression)
9342         (write_dollar_variable)
9343         (insert_type_address_space, increase_expout_size): Replace
9344         "parser_state" with "expr_builder".
9345         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9346         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9347         "parser_state" with "expr_builder".
9348
9349 2019-04-04  Tom Tromey  <tom@tromey.com>
9350
9351         * rust-exp.y: Replace "parse_language" with method call.
9352         * p-exp.y:
9353         (yylex): Replace "parse_language" with method call.
9354         * m2-exp.y:
9355         (yylex): Replace "parse_language" with method call.
9356         * go-exp.y (classify_name): Replace "parse_language" with method
9357         call.
9358         * f-exp.y (yylex): Replace "parse_language" with method call.
9359         * d-exp.y (lex_one_token): Replace "parse_language" with method
9360         call.
9361         * c-exp.y:
9362         (lex_one_token, classify_name, yylex): Replace "parse_language"
9363         with method call.
9364         * ada-exp.y (find_primitive_type, type_char)
9365         (type_system_address): Replace "parse_language" with method call.
9366
9367 2019-04-04  Tom Tromey  <tom@tromey.com>
9368
9369         * rust-exp.y: Replace "parse_gdbarch" with method call.
9370         * parse.c (write_dollar_variable, insert_type_address_space):
9371         Replace "parse_gdbarch" with method call.
9372         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9373         call.
9374         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9375         call.
9376         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9377         "parse_gdbarch" with method call.
9378         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9379         with method call.
9380         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9381         "parse_gdbarch" with method call.
9382         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9383         "parse_gdbarch" with method call.
9384         * c-exp.y (parse_type, parse_number, classify_name): Replace
9385         "parse_gdbarch" with method call.
9386         * ada-lex.l: Replace "parse_gdbarch" with method call.
9387         * ada-exp.y (parse_type, find_primitive_type, type_char)
9388         (type_system_address): Replace "parse_gdbarch" with method call.
9389
9390 2019-04-04  Tom Tromey  <tom@tromey.com>
9391
9392         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9393         * stap-probe.c (stap_parse_argument): Update.
9394         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9395         initial_size parameter.
9396         * rust-exp.y (rust_lex_tests): Update.
9397         * parse.c (parser_state): Update.
9398         (parse_exp_in_context): Update.
9399         * parser-defs.h (struct parser_state) <parser_state>: Remove
9400         "initial_size" parameter.
9401
9402 2019-04-04  Tom Tromey  <tom@tromey.com>
9403
9404         * parser-defs.h (increase_expout_size): Don't declare.
9405         * parse.c (increase_expout_size): Now static.
9406
9407 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9408
9409         * gnu-nat.c (gnu_nat_target::wait): Fix
9410         target_waitstatus_to_string call.
9411
9412 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9413
9414         * eval.c (evaluate_subexp_standard): Handle internal functions
9415         during Fortran function call handling.
9416
9417 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9418
9419         * NEWS: Mention new internal functions.
9420         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9421         (read_base_type): Use dwarf2_init_complex_target_type.
9422         * value.c (creal_internal_fn): New function.
9423         (cimag_internal_fn): New function.
9424         (_initialize_values): Register new internal functions.
9425
9426 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9427
9428         * infrun.c (stop_all_threads): If debug_infrun, always
9429         trace the wait status after wait_one, using
9430         target_waitstatus_to_string and target_pid_to_str.
9431         (handle_inferior_event): Replace various trace of
9432         wait status kind by a single trace.
9433         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9434         wait status kind image by target_waitstatus_to_string.
9435         * target/waitstatus.c (target_waitstatus_to_string): Fix
9436         obsolete comment.
9437
9438 2019-04-01  Tom Tromey  <tromey@adacore.com>
9439
9440         PR symtab/23331:
9441         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9442
9443 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9444             Pedro Alves  <palves@redhat.com>
9445
9446         * top.c (quit_force): Call 'finalize_values'.
9447         * value.c (finalize_values): New function.
9448         * value.h (finalize_values): Declare.
9449
9450 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9451
9452         * NEWS: Announce $_gdb_major and $_gdb_minor.
9453
9454         * top.c (init_gdb_version_vars): New function.
9455         (gdb_init): Call init_gdb_version_vars.
9456
9457 2019-03-29  Tom Tromey  <tromey@adacore.com>
9458
9459         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9460         help text.  Remove dead code.
9461
9462 2019-03-29  Keith Seitz  <keiths@redhat.com>
9463
9464         From Siddhesh Poyarekar:
9465         * f-lang.h (f77_get_upperbound): Return LONGEST.
9466         (f77_get_lowerbound): Likewise.
9467         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9468         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9469         print them.
9470         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9471         plongest to format print it.
9472         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9473         (f77_get_upperbound): Likewise.
9474         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9475         LOWER_BOUND to LONGEST.
9476         (f77_create_arrayprint_offset_tbl): Likewise.
9477
9478 2019-03-29  Keith Seitz  <keiths@redhat.com>
9479
9480         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9481         %s/pulongest for TYPE_LENGTH instead of %d in format
9482         strings.
9483         * ada-typerint.c (ada_print_type): Likewise.
9484         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9485         * compile/compile-c-support.c (generate_register_struct): Likewise.
9486         * gdbtypes.c (recursive_dump_type): Likewise.
9487         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9488         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9489         instead of %d in format strings.
9490         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9491         to std::min to ULONGEST.
9492         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9493         instead of %d in format strings.
9494         * tracepoint.c (info_scope_command): Likewise.
9495         * typeprint.c (print_offset_data::update)
9496         (print_offset_data::finish): Likewise.
9497         * xtensa-tdep.c (xtensa_store_return_value)
9498         (xtensa_push_dummy_call): Likewise.
9499
9500 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9501
9502         * windows-nat.c (display_selector): Fixed format specifications
9503         for 64-bit Cygwin.
9504
9505 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9506
9507         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9508
9509 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9510
9511         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9512         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9513         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9514         (nios2_linux_init_abi): Install it.
9515
9516 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9517
9518         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9519
9520 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9521
9522         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9523
9524 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9525             Tom Tromey  <tromey@adacore.com>
9526
9527         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9528
9529 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9530
9531         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9532         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9533         method to compute the bounds of range types. Also print "[evaluated]"
9534         if the bounds' values come from a dynamic evaluation.
9535
9536 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9537
9538         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9539         whitespace when pretty printing is on.
9540
9541 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9542
9543         * ppc-linux-nat.c: Add include.
9544
9545 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9546
9547         * NEWS: Mention AArch64 Pointer Authentication.
9548
9549 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9550
9551         * arm-linux-nat.c: Add include.
9552
9553 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9554
9555         * source-cache.c (source_cache::get_source_lines): Re-read
9556         fullname after calling open_source_file.
9557
9558 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9559
9560         * NEWS: Mention TLS support for FreeBSD.
9561
9562 2019-03-25  Tom Tromey  <tromey@adacore.com>
9563
9564         * minsyms.c (BUNCH_SIZE): Update comment.
9565         (~minimal_symbol_reader): Remove old comment.
9566         (compact_minimal_symbols): Update comment.
9567         (minimal_symbol_reader::install): Remove old comment.  Update
9568         other comments.
9569
9570 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9571
9572         * s390-linux-nat.c: Add include.
9573
9574 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9575
9576         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9577         Call linux_get_hwcap.
9578         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9579         Likewise.
9580         (aarch64_linux_get_hwcap): Remove function.
9581         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9582         declaration.
9583         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9584         linux_get_hwcap.
9585         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9586         * linux-tdep.c (linux_get_hwcap): Add function.
9587         (linux_get_hwcap2): Likewise.
9588         * linux-tdep.h (linux_get_hwcap): Add declaration.
9589         (linux_get_hwcap2): Likewise.
9590         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9591         (ppc_linux_get_hwcap2): Likewise.
9592         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9593         linux_get_hwcap.
9594         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9595         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9596         (ppc_linux_nat_target::read_description): Likewise.
9597         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9598         * s390-linux-nat.c: Likewise.
9599         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9600
9601 2019-03-24  Tom Tromey  <tom@tromey.com>
9602
9603         * ada-lang.c (standard_lookup): Simplify initialization.
9604         (ada_lookup_symbol_nonlocal): Simplify return.
9605         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9606         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9607         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9608         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9609         initialization.
9610         * solib.c (solib_global_lookup): Simplify.
9611         * symtab.c (null_block_symbol): Remove.
9612         (symbol_cache_lookup): Simplify returns.
9613         (lookup_language_this): Simplify returns.
9614         (lookup_symbol_aux): Simplify return.
9615         (lookup_local_symbol): Simplify returns.
9616         (lookup_global_symbol_from_objfile): Simplify return.
9617         (lookup_symbol_in_objfile_symtabs)
9618         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9619         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9620         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9621         * cp-namespace.c (cp_lookup_bare_symbol)
9622         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9623         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9624         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9625         (cp_lookup_symbol_via_imports): Simplify initialization.
9626         (find_symbol_in_baseclass): Likewise.
9627         * symtab.h (null_block_symbol): Remove.
9628         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9629         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9630         (d_lookup_symbol_module): Likewise.
9631         (find_symbol_in_baseclass): Simplify initialization.
9632
9633 2019-03-24  Tom Tromey  <tom@tromey.com>
9634
9635         * expression.h: Don't include symtab.h.
9636         (struct block): Forward declare.
9637
9638 2019-03-24  Tom Tromey  <tom@tromey.com>
9639
9640         * c-exp.y (typebase): Remove casts.
9641         * gdbtypes.c (lookup_unsigned_typename, )
9642         (lookup_signed_typename): Remove cast.
9643         * eval.c (parse_to_comma_and_eval): Remove cast.
9644         * parse.c (write_dollar_variable): Remove cast.
9645         * block.h (struct block) <superblock>: Now const.
9646         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9647         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9648         (map_block): Make "block" const.
9649         * symfile.h (struct quick_symbol_functions)
9650         <map_matching_symbols>: Constify block argument to "callback".
9651         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9652         const.
9653         (find_pc_sect_compunit_symtab): Make "b" const.
9654         (find_symbol_at_address): Likewise.
9655         (search_symbols): Likewise.
9656         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9657         (dw2_debug_names_lookup_symbol): Likewise.
9658         (dw2_map_matching_symbols): Update.
9659         * p-valprint.c (pascal_val_print): Remove "block".
9660         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9661         (aux_add_nonlocal_symbols): Make "block" const.
9662         (resolve_subexp): Remove cast.
9663         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9664         const.
9665         (iterate_over_file_blocks): Likewise.
9666         * f-exp.y (%union) <bval>: Remove.
9667         * coffread.c (patch_opaque_types): Make "b" const.
9668         * spu-tdep.c (spu_catch_start): Make "block" const.
9669         * c-valprint.c (print_unpacked_pointer): Remove "block".
9670         * symmisc.c (dump_symtab_1): Make "b" const.
9671         (block_depth): Make "block" const.
9672         * d-exp.y (%union) <bval>: Remove.
9673         * cp-support.h (cp_lookup_rtti_type): Update.
9674         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9675         * psymtab.c (psym_lookup_symbol): Make "block" const.
9676         (maintenance_check_psymtabs): Make "b" const.
9677         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9678         (enumerate_locals, enumerate_args): Update.
9679         * python/py-symtab.c (stpy_global_block): Make "block" const.
9680         (stpy_static_block): Likewise.
9681         * inline-frame.c (block_starting_point_at): Make "new_block"
9682         const.
9683         * block.c (find_block_in_blockvector): Make return type const.
9684         (blockvector_for_pc_sect): Make "b" const.
9685         (find_block_in_blockvector): Make "b" const.
9686
9687 2019-03-23  Tom Tromey  <tom@tromey.com>
9688
9689         * varobj.c (varobj_create): Update.
9690         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9691         * printcmd.c (display_command, do_one_display): Don't reset
9692         innermost_block.
9693         * parser-defs.h (enum innermost_block_tracker_type): Move to
9694         expression.h.
9695         (innermost_block): Update comment.
9696         * parse.c (parse_exp_1): Add tracker_types parameter.
9697         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9698         tracker_types parameter.  Reset innermost_block.
9699         (parse_exp_in_context): Remove.
9700         (parse_expression_for_completion): Update.
9701         * objfiles.c (~objfile): Don't reset expression_context_block or
9702         innermost_block.
9703         * expression.h (enum innermost_block_tracker_type): Move from
9704         parser-defs.h.
9705         (parse_exp_1): Add tracker_types parameter.
9706         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9707         reset innermost_block.
9708
9709 2019-03-23  Tom Tromey  <tom@tromey.com>
9710
9711         * objfiles.h: Include bcache.h.
9712
9713 2019-03-23  Tom Tromey  <tom@tromey.com>
9714
9715         * linespec.c (get_current_search_block): Use
9716         scoped_restore_current_language.
9717         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9718
9719 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9720             Jiong Wang  <jiong.wang@arm.com>
9721
9722         * aarch64-linux-tdep.c
9723         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9724         section.
9725         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9726
9727 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9728             Jiong Wang  <jiong.wang@arm.com>
9729
9730         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9731         instructions.
9732         (aarch64_analyze_prologue_test): Add PACIASP test.
9733         (aarch64_prologue_prev_register): Unmask PC value.
9734
9735 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9736             Jiong Wang  <jiong.wang@arm.com>
9737
9738         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9739         (aarch64_dwarf2_prev_register): Unmask PC value.
9740         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9741         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9742         DW_CFA_AARCH64_negate_ra_state.
9743         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9744
9745 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9746             Jiong Wang  <jiong.wang@arm.com>
9747
9748         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9749         registers.
9750         (aarch64_pseudo_register_name): Likewise.
9751         (aarch64_pseudo_register_type): Likewise.
9752         (aarch64_pseudo_register_reggroup_p): Likewise.
9753         (aarch64_gdbarch_init): Add pauth registers.
9754         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9755         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9756         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9757         (struct gdbarch_tdep): Add regnum for ra_state.
9758
9759 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9760             Jiong Wang  <jiong.wang@arm.com>
9761
9762         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9763
9764 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9765             Jiong Wang  <jiong.wang@arm.com>
9766
9767         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9768         function.
9769         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9770         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9771         (aarch64_gdbarch_init): Add puth registers.
9772         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9773         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9774         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9775
9776 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9777             Jiong Wang  <jiong.wang@arm.com>
9778
9779         * aarch64-linux-nat.c
9780         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9781         * aarch64-linux-tdep.c
9782         (aarch64_linux_core_read_description): Likewise.
9783         (aarch64_linux_get_hwcap): New function.
9784         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9785         (aarch64_linux_get_hwcap): New declaration.
9786
9787 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9788             Jiong Wang  <jiong.wang@arm.com>
9789
9790         * aarch64-linux-nat.c
9791         (aarch64_linux_nat_target::read_description): Add pauth param.
9792         * aarch64-linux-tdep.c
9793         (aarch64_linux_core_read_description): Likewise.
9794         * aarch64-tdep.c (struct target_desc): Add in pauth.
9795         (aarch64_read_description): Add pauth param.
9796         (aarch64_gdbarch_init): Likewise.
9797         * aarch64-tdep.h (aarch64_read_description): Likewise.
9798         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9799         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9800         * features/Makefile: Add new files.
9801         * features/aarch64-pauth.c: New file.
9802         * features/aarch64-pauth.xml: New file.
9803
9804 2019-03-20  Tom Tromey  <tromey@adacore.com>
9805
9806         * infrun.c (handle_inferior_event): Rename from
9807         handle_inferior_event_1.  Create a scoped_value_mark.
9808         (handle_inferior_event): Remove.
9809
9810 2019-03-19  Tom Tromey  <tromey@adacore.com>
9811
9812         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9813         * infrun.h (print_stop_event): Add "displays" parameter.
9814         * infrun.c (print_stop_event): Add "displays" parameter.
9815
9816 2019-03-19  Pedro Alves  <palves@redhat.com>
9817
9818         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9819         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9820         to -1.  Fix TABs vs spaces.
9821         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9822         * tui/tui-out.h (tui_ui_out) Add intro comments.
9823         <m_line, m_start_of_line>: In-class initialize, and add describing
9824         comment.
9825
9826 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9827
9828         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9829         variable names.
9830         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9831
9832 2019-03-18  Pedro Alves  <palves@redhat.com>
9833             Eli Zaretskii <eliz@gnu.org>
9834
9835         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9836         m_line and m_start_of_line.
9837
9838 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9839
9840         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9841         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9842         it returns a newline.  This fixes a regression in TU mode, whereby
9843         the next line is output on the same screen line as the user input.
9844
9845 2019-03-18  Tom Tromey  <tromey@adacore.com>
9846
9847         * minsyms.c (minimal_symbol_reader::install): Remove call to
9848         obstack_blank.
9849
9850 2019-03-18  Pedro Alves  <palves@redhat.com>
9851
9852         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9853         New globals.
9854         (apply_style): New, factored out from ...
9855         (apply_ansi_escape): ... this.  Handle reverse video mode.
9856         (tui_set_reverse_mode): New function.
9857         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9858         * tui/tui-winsource.c (tui_show_source_line): Use
9859         tui_set_reverse_mode instead of setting A_STANDOUT.
9860         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9861         New setter methods.
9862
9863 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9864
9865         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9866         Handle tabs.
9867
9868 2019-03-18  Tom Tromey  <tromey@adacore.com>
9869
9870         * ada-lang.c (empty_array): Add "high" parameter.
9871         (ada_evaluate_subexp): Update.
9872
9873 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9874
9875         * unittests/string_view-selftests.c: Define
9876         _initialize_string_view_selftests unconditionally.
9877
9878 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9879
9880         PR gdb/24350
9881         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9882
9883 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9884
9885         PR gdb/24351
9886         * windows-nat.c (display_selector): Fix format specifiers.
9887
9888 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9889
9890         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9891         tui_refill_source_window instead of tui_refresh_win, to update the
9892         current execution line.  This fixes redisplay of the current line
9893         when stepping through the code with "next" or "step".
9894
9895 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9896
9897         * source-cache.c (source_cache::get_source_lines): Call
9898         find_source_lines to initialize s->nlines.  This fixes vertical
9899         scrolling of TUI source window when the DOWN arrow is pressed.
9900
9901 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9902
9903         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9904         linux-thread-db.c (_initialize_thread_db): Likewise.
9905
9906 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9907
9908         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9909         wclrtoeol in tui_show_source_line".  This reverts changes made in
9910         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9911
9912 2019-03-15  Tom Tromey  <tom@tromey.com>
9913
9914         * symtab.h (struct minimal_symbol): Derive from
9915         general_symbol_info.
9916         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9917         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9918         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9919         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9920         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9921         (MSYMBOL_SEARCH_NAME): Update.
9922         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9923         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9924         * minsyms.c (minimal_symbol_reader::record_full): Update.
9925
9926 2019-03-15  Tom Tromey  <tom@tromey.com>
9927
9928         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9929
9930 2019-03-15  Tom Tromey  <tom@tromey.com>
9931
9932         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9933         unique_xmalloc_ptr.
9934         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9935         Update.
9936         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9937         (build_minimal_symbol_hash_tables)
9938         (minimal_symbol_reader::install): Update.
9939
9940 2019-03-15  Tom Tromey  <tom@tromey.com>
9941
9942         * symtab.c (create_demangled_names_hash): Update.
9943         (symbol_set_names): Update.
9944         * objfiles.h (struct objfile_per_bfd_storage)
9945         <demangled_names_hash>: Now an htab_up.
9946         * objfiles.c (objfile_per_bfd_storage): Simplify.
9947
9948 2019-03-15  Tom Tromey  <tom@tromey.com>
9949
9950         * objfiles.h (struct objfile_per_bfd_storage): Declare
9951         destructor.
9952         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9953         New.
9954         (get_objfile_bfd_data): Use new.  Don't initialize
9955         language_of_main.
9956         (free_objfile_per_bfd_storage): Remove.
9957         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9958
9959 2019-03-15  Tom Tromey  <tom@tromey.com>
9960
9961         * symfile.c (reread_symbols): Update.
9962         * objfiles.c (objfile::objfile): Update.
9963         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9964         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9965         comment.
9966         (minimal_symbol_reader::install): Update.
9967         (terminate_minimal_symbol_table): Remove.
9968         * jit.c (jit_object_close_impl): Update.
9969
9970 2019-03-15  Tom Tromey  <tom@tromey.com>
9971
9972         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9973         initializations.
9974
9975 2019-03-15  Tom Tromey  <tom@tromey.com>
9976
9977         * objfiles.h (struct objfile_per_bfd_storage)
9978         <demangled_hash_languages>: Now a bitset.
9979         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9980         (lookup_minimal_symbol): Update.
9981
9982 2019-03-15  Tom Tromey  <tom@tromey.com>
9983
9984         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9985         Don't return the symbol.
9986         * coffread.c (record_minimal_symbol): Use record_full.
9987
9988 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9989
9990         The MS-Windows port of ncurses fails to switch to a color pair if
9991         one or both of the colors are the implicit default colors.  This
9992         change records the default colors when TUI is initialized, and
9993         then specifies them explicitly when a color pair uses the default
9994         colors.  This allows color styling in TUI mode on MS-Windows.
9995
9996         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9997         ncurses_norm_attr.
9998         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9999         colors in ncurses_norm_attr.
10000         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10001         "none", replace it with the default color recorded in
10002         ncurses_norm_attr.
10003
10004 2019-03-14  Tom Tromey  <tromey@adacore.com>
10005
10006         * source-cache.h (class source_cache) <get_source_lines>: Return
10007         std::string.
10008         * source-cache.c (source_cache::extract_lines): Handle case where
10009         first_pos==npos.  Return std::string.
10010         (source_cache::get_source_lines): Update.
10011
10012 2019-03-14  Tom Tromey  <tromey@adacore.com>
10013
10014         * NEWS: Add item for "style sources" commands.
10015         * source-cache.c (source_cache::get_source_lines): Check
10016         source_styling.
10017         * cli/cli-style.c (source_styling): New global.
10018         (_initialize_cli_style): Add "style sources" commands.
10019         (show_style_sources): New function.
10020         * cli/cli-style.h (source_styling): Declare.
10021
10022 2019-03-14  Pedro Alves  <palves@redhat.com>
10023             Tom Tromey  <tromey@adacore.com>
10024
10025         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10026         * tui/tui-winsource.c (tui_refill_source_window): New function,
10027         from...
10028         (tui_horizontal_source_scroll): ... here.  Move some logic.
10029         * cli/cli-style.c (set_style_enabled): Notify new observable.
10030         * tui/tui-hooks.c (tui_redisplay_source): New function.
10031         (tui_attach_detach_observers): Attach or detach
10032         tui_redisplay_source.
10033         * observable.h (source_styling_changed): New observable.
10034         * observable.c: Define source_styling_changed observable.
10035
10036 2019-03-13  Tom Tromey  <tromey@adacore.com>
10037
10038         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10039         (i386_gnu_nat_target::store_registers): Update.
10040         * target-debug.h (target_debug_print_std_string): New macro.
10041         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10042         * windows-tdep.c (display_one_tib): Update.
10043         * tui/tui-stack.c (tui_make_status_line): Update.
10044         * top.c (print_inferior_quit_action): Update.
10045         * thread.c (thr_try_catch_cmd): Update.
10046         (add_thread_with_info): Update.
10047         (thread_target_id_str): Update.
10048         (thr_try_catch_cmd): Update.
10049         (thread_command): Update.
10050         (thread_find_command): Update.
10051         * record-btrace.c (record_btrace_target::info_record)
10052         (record_btrace_resume_thread, record_btrace_target::resume)
10053         (record_btrace_cancel_resume, record_btrace_step_thread)
10054         (record_btrace_target::wait, record_btrace_target::wait)
10055         (record_btrace_target::wait, record_btrace_target::stop): Update.
10056         * progspace.c (print_program_space): Update.
10057         * process-stratum-target.c
10058         (process_stratum_target::thread_address_space): Update.
10059         * linux-fork.c (linux_fork_mourn_inferior)
10060         (detach_checkpoint_command, info_checkpoints_command)
10061         (linux_fork_context): Update.
10062         (linux_fork_detach): Update.
10063         (class scoped_switch_fork_info): Update.
10064         (delete_checkpoint_command): Update.
10065         * infrun.c (follow_fork_inferior): Update.
10066         (follow_fork_inferior): Update.
10067         (proceed_after_vfork_done): Update.
10068         (handle_vfork_child_exec_or_exit): Update.
10069         (follow_exec): Update.
10070         (displaced_step_prepare_throw): Update.
10071         (displaced_step_restore): Update.
10072         (start_step_over): Update.
10073         (resume_1): Update.
10074         (clear_proceed_status_thread): Update.
10075         (proceed): Update.
10076         (print_target_wait_results): Update.
10077         (do_target_wait): Update.
10078         (context_switch): Update.
10079         (stop_all_threads): Update.
10080         (restart_threads): Update.
10081         (finish_step_over): Update.
10082         (handle_signal_stop): Update.
10083         (switch_back_to_stepped_thread): Update.
10084         (keep_going_pass_signal): Update.
10085         (print_exited_reason): Update.
10086         (normal_stop): Update.
10087         * inferior.c (inferior_pid_to_str): Change return type.
10088         (print_selected_inferior): Update.
10089         (add_inferior): Update.
10090         (detach_inferior): Update.
10091         * dummy-frame.c (fprint_dummy_frames): Update.
10092         * dcache.c (dcache_info_1): Update.
10093         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10094         (btrace_fetch, btrace_clear): Update.
10095         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10096         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10097         type.
10098         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10099         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10100         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10101         * gdbarch.c, gdbarch.h: Rebuild.
10102         * gdbarch.sh (core_pid_to_str): Change return type.
10103         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10104         return type.
10105         (windows_nat_target::pid_to_str): Change return type.
10106         (windows_delete_thread): Update.
10107         (windows_nat_target::attach): Update.
10108         (windows_nat_target::files_info): Update.
10109         * target-delegates.c: Rebuild.
10110         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10111         return type.
10112         (sol_thread_target::pid_to_str): Change return type.
10113         * remote.c (class remote_target) <pid_to_str>: Change return
10114         type.
10115         (remote_target::pid_to_str): Change return type.
10116         (extended_remote_target::attach, remote_target::remote_stop_ns)
10117         (remote_target::remote_notif_remove_queued_reply)
10118         (remote_target::push_stop_reply, remote_target::disable_btrace):
10119         Update.
10120         (extended_remote_target::attach): Update.
10121         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10122         type.
10123         (gdbsim_target::pid_to_str): Change return type.
10124         * ravenscar-thread.c (struct ravenscar_thread_target)
10125         <pid_to_str>: Change return type.
10126         (ravenscar_thread_target::pid_to_str): Change return type.
10127         * procfs.c (class procfs_target) <pid_to_str>: Change return
10128         type.
10129         (procfs_target::pid_to_str): Change return type.
10130         (procfs_target::attach): Update.
10131         (procfs_target::detach): Update.
10132         (procfs_target::fetch_registers): Update.
10133         (procfs_target::store_registers): Update.
10134         (procfs_target::wait): Update.
10135         (procfs_target::files_info): Update.
10136         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10137         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10138         return type.
10139         (nto_procfs_target::pid_to_str): Change return type.
10140         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10141         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10142         return type.
10143         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10144         (exit_lwp): Update.
10145         (attach_proc_task_lwp_callback, get_detach_signal)
10146         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10147         (linux_nat_target::resume, wait_lwp, stop_callback)
10148         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10149         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10150         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10151         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10152         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10153         type.
10154         (inf_ptrace_target::attach): Update.
10155         (inf_ptrace_target::files_info): Update.
10156         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10157         type.
10158         (go32_nat_target::pid_to_str): Change return type.
10159         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10160         (gnu_nat_target::wait): Update.
10161         (gnu_nat_target::wait): Update.
10162         (gnu_nat_target::resume): Update.
10163         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10164         (fbsd_nat_target::wait): Update.
10165         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10166         type.
10167         (darwin_nat_target::attach): Update.
10168         * corelow.c (class core_target) <pid_to_str>: Change return type.
10169         (core_target::pid_to_str): Change return type.
10170         * target.c (normal_pid_to_str): Change return type.
10171         (default_pid_to_str): Likewise.
10172         (target_pid_to_str): Change return type.
10173         (target_translate_tls_address): Update.
10174         (target_announce_detach): Update.
10175         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10176         return type.
10177         (bsd_uthread_target::pid_to_str): Change return type.
10178         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10179         type.
10180         (bsd_kvm_target::pid_to_str): Change return type.
10181         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10182         return type.
10183         (aix_thread_target::pid_to_str): Change return type.
10184         * target.h (struct target_ops) <pid_to_str>: Change return type.
10185         (target_pid_to_str, normal_pid_to_str): Likewise.
10186         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10187         type.
10188         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10189         type.
10190         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10191         return type.
10192         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10193         type.
10194         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10195         type.
10196         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10197         return type.
10198
10199 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10200
10201         * NEWS: Mention that the new default MI version is 3.  Mention
10202         changes to the output of commands and events that deal with
10203         multi-location breakpoints.
10204         * breakpoint.c: Include "mi/mi-out.h".
10205         (print_one_breakpoint): Change output syntax if using MI version
10206         >= 3.
10207         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10208         New.
10209         (mi_multi_location_breakpoint_output_fixed): New.
10210         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10211         (mi_cmd_fix_multi_location_breakpoint_output): New.
10212         (mi_multi_location_breakpoint_output_fixed): New.
10213         * mi/mi-cmds.c (mi_cmds): Register command
10214         -fix-multi-location-breakpoint-output.
10215         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10216         interpreter "mi".
10217
10218 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10219
10220         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10221         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10222         instantiate mi_ui_out based on interpreter name.
10223         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10224         * mi/mi-main.c (mi_load_progress): Likewise.
10225
10226 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10227
10228         * NEWS: Combine separate "New targets" sections for 8.3.
10229
10230 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10231
10232         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10233         (ppcfbsd_init_abi): Install gdbarch
10234         "fetch_tls_load_module_address" and "get_thread_local_address"
10235         methods.
10236
10237 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10238
10239         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10240         (riscv_fbsd_init_abi): Install gdbarch
10241         "fetch_tls_load_module_address" and "get_thread_local_address"
10242         methods.
10243
10244 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10245
10246         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10247         (i386fbsd_init_abi): Install gdbarch
10248         "fetch_tls_load_module_address" and "get_thread_local_address"
10249         methods.
10250
10251 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10252
10253         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10254         (amd64fbsd_init_abi): Install gdbarch
10255         "fetch_tls_load_module_address" and "get_thread_local_address"
10256         methods.
10257
10258 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10259
10260         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10261         (struct fbsd_pspace_data): New type.
10262         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10263         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10264         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10265         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10266         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10267
10268 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10269
10270         * gdbtypes.c (lookup_struct_elt): New function.
10271         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10272         * gdbtypes.h (struct struct_elt): New type.
10273         (lookup_struct_elt): New prototype.
10274
10275 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10276
10277         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10278         remove disabled code block.
10279
10280 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10281
10282         * gdbarch.sh (get_thread_local_address): New method.
10283         * gdbarch.h, gdbarch.c: Regenerate.
10284         * target.c (target_translate_tls_address): Use
10285         gdbarch_get_thread_local_address if present instead of
10286         target::get_thread_local_address.
10287
10288 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10289
10290         * target.h (target::get_thread_local_address): Update comment.
10291
10292 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10293
10294         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10295         objfile->separate_debug_objfile_backlink if not NULL.
10296
10297 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10298
10299         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10300         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10301         (amd64bsd_store_inferior_registers): Likewise.
10302         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10303         Enable segment base registers.
10304         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10305         PT_GETFSBASE and PT_GETGSBASE.
10306         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10307         PT_SETGSBASE.
10308         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10309         segment base registers.
10310         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10311
10312 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10313
10314         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10315         Update calls to i386_target_description to add 'segments'
10316         parameter.
10317         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10318         add segment base registers.
10319         * arch/i386.c (i386_create_target_description): Add 'segments'
10320         parameter to enable segment base registers.
10321         * arch/i386.h (i386_create_target_description): Likewise.
10322         * features/i386/32bit-segments.xml: New file.
10323         * features/i386/32bit-segments.c: Generate.
10324         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10325         call to i386_target_description to add 'segments' parameter.
10326         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10327         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10328         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10329         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10330         if feature is present.
10331         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10332         Add 'segments' parameter to call to i386_target_description.
10333         (i386_target_description): Add 'segments' parameter to enable
10334         segment base registers.
10335         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10336         to call to i386_target_description.
10337         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10338         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10339         Define I386_NUM_REGS.
10340         (i386_target_description): Add 'segments' parameter to enable
10341         segment base registers.
10342
10343 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10344
10345         PR/24325
10346         * source-cache.c: #undef open and close, to avoid unresolved
10347         externals during linking.
10348
10349 2019-03-12  Tom Tromey  <tromey@adacore.com>
10350
10351         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10352         const.  Add initializers.
10353         (_initialize_remote): Don't initialize ptid globals.
10354
10355 2019-03-12  Pedro Alves  <palves@redhat.com>
10356
10357         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10358
10359 2019-03-12  Pedro Alves  <palves@redhat.com>
10360
10361         * cp-name-parser.y (main): Remove unused 'len' variable.
10362
10363 2019-03-12  Tom Tromey  <tromey@adacore.com>
10364
10365         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10366         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10367
10368 2019-03-12  Tom Tromey  <tromey@adacore.com>
10369
10370         * linux-nat.c (iterate_over_lwps): Update.
10371         (stop_callback): Remove parameter.
10372         (stop_wait_callback, detach_callback, resume_set_callback)
10373         (select_singlestep_lwp_callback, set_ignore_sigint)
10374         (status_callback, resumed_callback, resume_clear_callback)
10375         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10376         data parameter.
10377         (linux_nat_target::detach, linux_nat_target::resume)
10378         (linux_stop_and_wait_all_lwps, select_event_lwp)
10379         (linux_nat_filter_event, linux_nat_wait_1)
10380         (linux_nat_target::kill, linux_nat_target::stop)
10381         (linux_nat_target::stop): Update.
10382         (linux_nat_resume_callback): Change type.
10383         (resume_stopped_resumed_lwps, count_events_callback)
10384         (select_event_lwp_callback): Likewise.
10385         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10386         * arm-linux-nat.c (struct update_registers_data): Remove.
10387         (update_registers_callback): Change type.
10388         (arm_linux_insert_hw_breakpoint1): Update.
10389         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10390         parameter.
10391         (x86_linux_dr_set_addr): Update.
10392         (x86_linux_dr_set_control): Update.
10393         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10394         (iterate_over_lwps): Use gdb::function_view.
10395         * nat/aarch64-linux-hw-point.c (struct
10396         aarch64_dr_update_callback_param): Remove.
10397         (debug_reg_change_callback): Change type.
10398         (aarch64_notify_debug_reg_change): Update.
10399         * s390-linux-nat.c (s390_refresh_per_info): Update.
10400
10401 2019-03-11  Tom Tromey  <tromey@adacore.com>
10402
10403         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10404         redundant assignment to "this_cu".
10405
10406 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10407
10408         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10409
10410 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10411
10412         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10413         from...
10414         (rank_one_type): ... this.
10415
10416 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10417
10418         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10419         from...
10420         (rank_one_type): ... this.
10421
10422 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10423
10424         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10425         from...
10426         (rank_one_type): ... this.
10427
10428 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10429
10430         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10431         from...
10432         (rank_one_type): ... this.
10433
10434 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10435
10436         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10437         from...
10438         (rank_one_type): ... this.
10439
10440 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10441
10442         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10443         from...
10444         (rank_one_type): ... this.
10445
10446 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10447
10448         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10449         from...
10450         (rank_one_type): ... this.
10451
10452 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10453
10454         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10455         from...
10456         (rank_one_type): ... this.
10457
10458 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10459
10460         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10461         from...
10462         (rank_one_type): ... this.
10463
10464 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10465
10466         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10467         from...
10468         (rank_one_type): ... this.
10469
10470 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10471
10472         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10473         from...
10474         (rank_one_type): ... this.
10475
10476 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10477
10478         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10479         from...
10480         (rank_one_type): ... this.
10481
10482 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10483
10484         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10485         inferior-events' shows the example events.
10486
10487 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10488
10489         Support styling on native MS-Windows console
10490
10491         PR/24315
10492         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10493         on MS-Windows if $TERM is not defined.
10494
10495         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10496
10497         * posix-hdep.c (gdb_console_fputs):
10498         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10499         functions.
10500         * ui-file.h (gdb_console_fputs): Add prototype.
10501
10502         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10503         back to fputs only if the former returns zero.
10504
10505 2019-03-07  Tom Tromey  <tom@tromey.com>
10506
10507         * symmisc.c (print_symbol_bcache_statistics): Update.
10508         (print_objfile_statistics): Update.
10509         * symfile.c (allocate_symtab): Update.
10510         * stabsread.c: Don't include bcache.h.
10511         * psymtab.h (struct psymbol_bcache): Don't declare.
10512         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10513         (psymbol_bcache_init, psymbol_bcache_free)
10514         (psymbol_bcache_get_bcache): Don't declare.
10515         * psymtab.c (struct psymbol_bcache): Remove.
10516         (psymtab_storage::psymtab_storage): Update.
10517         (psymtab_storage::~psymtab_storage): Update.
10518         (psymbol_bcache_init, psymbol_bcache_free)
10519         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10520         (add_psymbol_to_bcache): Update.
10521         (allocate_psymtab): Update.
10522         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10523         macro_cache>: No longer pointers.
10524         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10525         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10526         * macrotab.c (macro_bcache): Update.
10527         * macroexp.c: Don't include bcache.h.
10528         * gdbtypes.c (check_types_worklist): Update.
10529         (types_deeply_equal): Remove TRY/CATCH.  Update.
10530         * elfread.c (elf_symtab_read): Update.
10531         * dwarf2read.c: Don't include bcache.h.
10532         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10533         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10534         (print_bcache_statistics, bcache_memory_used): Don't declare.
10535         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10536         methods.  Rename all data members.
10537         * bcache.c (struct bcache): Move to bcache.h.
10538         (bcache::expand_hash_table): Rename from expand_hash_table.
10539         (bcache): Remove.
10540         (bcache::insert): Rename from bcache_full.
10541         (bcache::compare): Rename from bcache_compare.
10542         (bcache_xmalloc): Remove.
10543         (bcache::~bcache): Rename from bcache_xfree.
10544         (bcache::print_statistics): Rename from print_bcache_statistics.
10545         (bcache::memory_used): Rename from bcache_memory_used.
10546
10547 2019-03-07  Pedro Alves  <palves@redhat.com>
10548
10549         * infrun.c (normal_stop): Also check for
10550         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10551
10552 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10553
10554         * f-lang.c (value_from_host_double): Moved to...
10555         * value.c (value_from_host_double): ...here.
10556         * value.h (value_from_host_double): Declare.
10557         * guile/scm-math.c (vlscm_convert_typed_number): Use
10558         value_from_host_double.
10559         (vlscm_convert_number): Likewise.
10560         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10561         * python/py-value.c (convert_value_from_python): Likewise.
10562
10563 2019-03-06  Tom Tromey  <tom@tromey.com>
10564
10565         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10566
10567 2019-03-06  Tom Tromey  <tom@tromey.com>
10568
10569         * utils.h (free_current_contents): Don't declare.
10570         * utils.c (free_current_contents): Remove.
10571
10572 2019-03-06  Tom Tromey  <tom@tromey.com>
10573
10574         * top.c (quit_force): Update.
10575         * main.c (captured_command_loop): Update.
10576         * common/new-op.c (operator new): Update.
10577         * common/common-exceptions.c (struct catcher)
10578         <save_cleanup_chain>: Remove member.
10579         (exceptions_state_mc_init): Update.
10580         (exception_try_scope_entry): Return nullptr.
10581         (exception_try_scope_exit, exception_rethrow)
10582         (throw_exception_sjlj, throw_exception_cxx): Update.
10583         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10584         (all_cleanups, do_cleanups, discard_cleanups)
10585         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10586         (restore_cleanups, restore_final_cleanups): Don't declare.
10587         (do_final_cleanups): Remove parameter.
10588         * common/cleanups.c (cleanup_chain, make_cleanup)
10589         (make_cleanup_dtor, all_cleanups, do_cleanups)
10590         (discard_my_cleanups, discard_cleanups)
10591         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10592         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10593         (null_cleanup): Remove.
10594         (do_final_cleanups): Remove parameter.
10595
10596 2019-03-06  Tom Tromey  <tom@tromey.com>
10597
10598         * remote.c (remote_target::remote_parse_stop_reply): Use
10599         unique_xmalloc_ptr.
10600
10601 2019-03-06  Tom Tromey  <tom@tromey.com>
10602
10603         * stabsread.c (struct stabs_field_info): Rename from field_info.
10604         <list, fnlist>: Add initializers.
10605         <obstack>: New member.
10606         (read_member_functions, read_struct_fields, read_baseclasses):
10607         Allocate on obstack.  Don't use cleanups.
10608         (read_one_struct_field, read_member_functions, read_struct_fields)
10609         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10610         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10611         (read_struct_type): Update.
10612
10613 2019-03-06  Tom Tromey  <tom@tromey.com>
10614
10615         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10616         * common/filestuff.h (make_cleanup_close): Don't declare.
10617         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10618         Remove.
10619
10620 2019-03-06  Tom Tromey  <tom@tromey.com>
10621
10622         * solib-aix.c: Use make_scope_exit.
10623
10624 2019-03-06  Tom Tromey  <tom@tromey.com>
10625
10626         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10627         Use make_scope_exit.
10628
10629 2019-03-06  Tom Tromey  <tom@tromey.com>
10630
10631         * solib-svr4.c (disable_probes_interface): Remove parameter.
10632         (svr4_handle_solib_event): Use make_scope_exit.
10633
10634 2019-03-06  Tom Tromey  <tom@tromey.com>
10635
10636         * remote.c (struct stop_reply_deleter): Remove.
10637         (stop_reply_up): Update.
10638         (struct stop_reply): Derive from notif_event.  Don't typedef.
10639         <regcache>: Now a std::vector.
10640         (stop_reply_xfree): Remove.
10641         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10642         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10643         (remote_target::discard_pending_stop_replies): Use delete.
10644         (remote_target::remote_parse_stop_reply): Update.
10645         (remote_target::process_stop_reply): Update.
10646         * remote-notif.h (struct notif_event): Add virtual destructor.
10647         Remove "dtr" member.
10648         (struct notif_client) <alloc_event>: Return a unique_ptr.
10649         (notif_event_xfree): Don't declare.
10650         (notif_event_up): New typedef.
10651         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10652         (notif_event_xfree, do_notif_event_xfree): Remove.
10653         (remote_notif_state_xfree): Update.
10654
10655 2019-03-06  Tom Tromey  <tom@tromey.com>
10656
10657         * infrun.c (displaced_step_clear_cleanup): Now a
10658         forward_scope_exit type.
10659         (displaced_step_prepare_throw): Update.
10660         (displaced_step_fixup): Update.
10661
10662 2019-03-06  Tom Tromey  <tom@tromey.com>
10663
10664         * inferior.h (class inferior): Update comment.
10665         * gdbthread.h (class thread_info): Update comment.
10666
10667 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10668             Tom Tromey  <tom@tromey.com>
10669
10670         * stabsread.h (struct stab_section_list): Remove.
10671         (coffstab_build_psymtabs): Update.
10672         * dbxread.c (symbuf_sections): Now a std::vector.
10673         (sect_idx): New global.
10674         (fill_symbuf): Update.
10675         (coffstab_build_psymtabs): Change type of stabsects parameter.
10676         Update.
10677         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10678         std::vector.
10679         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10680         (coff_locate_sections): Update.
10681         (coff_symfile_read): Remove cleanups.  Update.
10682         (init_stringtab): Add storage parameter.
10683         (free_stringtab, free_stringtab_cleanup): Remove.
10684         (init_lineno): Add storage parameter.
10685         (free_linetab, free_linetab_cleanup): Remove.
10686
10687 2019-03-06  Pedro Alves  <palves@redhat.com>
10688
10689         * linux-fork.c (fork_info::clobber_regs): Delete.
10690         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10691         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10692         comment.  Adjust.
10693         (scoped_switch_fork_info::scoped_switch_fork_info)
10694         (checkpoint_command, linux_fork_context): Adjust
10695         fork_save_infrun_state calls.
10696
10697 2019-03-06  Pedro Alves  <palves@redhat.com>
10698
10699         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10700         (inf_has_multiple_threads): Return 'bool' and rewrite using
10701         inferior_info::threads().
10702
10703 2019-03-06  Pedro Alves  <palves@redhat.com>
10704
10705         * linux-fork.c: Include <list>.
10706         (fork_list): Now a std::list instance.
10707         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10708         (forks_exist_p, find_last_fork): Adjust.
10709         (new_fork): Delete.
10710         (one_fork_p): New.
10711         (add_fork): Adjust.
10712         (free_fork): Delete, folded into fork_info::~fork_info().
10713         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10714         Adjust.
10715         (init_fork_list): Delete.
10716         (linux_fork_killall, linux_fork_mourn_inferior)
10717         (linux_fork_detach, info_checkpoints_command): Adjust.
10718         (_initialize_linux_fork): No longer call init_fork_list.
10719
10720 2019-03-06  Pedro Alves  <palves@redhat.com>
10721
10722         * linux-fork.c (new_fork): New, split out of ...
10723         (add_fork): ... this.  Return void.  Move "first fork" special
10724         case from here, to ...
10725         (checkpoint_command): ... here.
10726         * linux-linux.h (add_fork): Return void.
10727
10728 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10729
10730         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10731
10732 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10733             Chris January  <chris.january@arm.com>
10734             David Lecomber  <david.lecomber@arm.com>
10735
10736         * f-exp.y: New token, UNOP_INTRINSIC.
10737         (exp): New pattern using UNOP_INTRINSIC token.
10738         (f77_keywords): Add 'abs' keyword.
10739         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10740         (value_from_host_double): New function.
10741         (evaluate_subexp_f): Support UNOP_ABS.
10742
10743 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10744
10745         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10746         types.
10747
10748 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10749
10750         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10751         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10752         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10753
10754 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10755
10756         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10757
10758 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10759             Chris January  <chris.january@arm.com>
10760
10761         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10762         * f-exp.y: Define 'KIND' token.
10763         (exp): New pattern for KIND expressions.
10764         (ptype): Handle types with a kind extension.
10765         (direct_abs_decl): Extend to spot kind extensions.
10766         (f77_keywords): Add 'kind' to the list.
10767         (push_kind_type): New function.
10768         (convert_to_kind_type): New function.
10769         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10770         * parse.c (operator_length_standard): Likewise.
10771         * parser-defs.h (enum type_pieces): Add tp_kind.
10772         * std-operator.def: Add UNOP_KIND.
10773
10774 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10775
10776         * f-exp.y (f_parse): Set yydebug.
10777
10778 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10779
10780         * f-lang.c (evaluate_subexp_f): New function.
10781         (exp_descriptor_f): New global.
10782         (f_language_defn): Use exp_descriptor_f instead of
10783         exp_descriptor_standard.
10784
10785 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10786
10787         * f-exp.y (struct token): Add comments.
10788         (dot_ops): Remove uppercase versions and the end marker.
10789         (f77_keywords): Likewise.
10790         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10791         entries in the dot_ops array are case insensitive, and use
10792         strncasecmp to compare strings.  Also some whitespace cleanup in
10793         this area.  Similar for the f77_keywords array, except entries in
10794         this list might be case sensitive.
10795
10796 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10797
10798         * f-exp.y (struct f77_boolean_val): Add comments.
10799         (boolean_values): Remove uppercase versions, and end marker.
10800         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10801         and use strncasecmp to achieve case insensitivity.  Additionally,
10802         perform whitespace cleanup around this code.
10803
10804 2019-03-06  Tom Tromey  <tromey@adacore.com>
10805
10806         * remote-sim.c (gdbsim_target_open): Use result of
10807         gdb_argv::release.
10808
10809 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10810         Dirk Schubert  <dirk.schubert@arm.com>
10811         Chris January  <chris.january@arm.com>
10812
10813         * eval.c (evaluate_subexp_standard): Call Fortran argument
10814         wrapping logic.
10815         * f-lang.c (struct value): A value which can be passed into a
10816         Fortran function call.
10817         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10818         where appropriate.
10819         (struct type): Value ready for a Fortran function call.
10820         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10821         is needed.
10822         * f-lang.h (fortran_argument_convert): Declaration.
10823         (fortran_preserve_arg_pointer): Declaration.
10824         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10825
10826 2019-03-05  Tom Tromey  <tromey@adacore.com>
10827
10828         * python/py-prettyprint.c (print_string_repr): Remove #if.
10829         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10830
10831 2019-03-05  Tom Tromey  <tromey@adacore.com>
10832
10833         * target.c (the_dummy_target): Move later.  Change type to
10834         "dummy_target".
10835         (initialize_targets): Don't initialize the_dummy_target.
10836
10837 2019-03-05  Tom Tromey  <tromey@adacore.com>
10838
10839         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10840         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10841
10842 2019-03-05  Tom Tromey  <tromey@adacore.com>
10843
10844         * windows-nat.c (windows_nat_target::attach)
10845         (windows_nat_target::detach): Don't call gdb_flush.
10846         * valprint.c (generic_val_print, val_print, val_print_string):
10847         Don't call gdb_flush.
10848         * utils.c (defaulted_query): Don't call gdb_flush.
10849         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10850         * target.c (target_announce_detach): Don't call gdb_flush.
10851         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10852         * remote.c (extended_remote_target::attach): Don't call
10853         gdb_flush.
10854         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10855         * printcmd.c (do_examine): Don't call gdb_flush.
10856         (info_display_command): Don't call gdb_flush.
10857         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10858         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10859         * memattr.c (info_mem_command): Don't call gdb_flush.
10860         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10861         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10862         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10863         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10864         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10865         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10866         (gnu_nat_target::detach): Don't call gdb_flush.
10867         * f-valprint.c (f_val_print): Don't call gdb_flush.
10868         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10869         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10870         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10871         gdb_flush.
10872         * c-valprint.c (c_val_print): Don't call gdb_flush.
10873         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10874
10875 2019-03-05  Tom Tromey  <tromey@adacore.com>
10876
10877         * varobj.c (update_dynamic_varobj_children): Update.
10878         (install_default_visualizer): Use reset, not release.
10879         * value.c (set_internalvar): Update.
10880         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10881         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10882         ATTRIBUTE_UNUSED_RESULT.
10883
10884 2019-03-05  Tom Tromey  <tromey@adacore.com>
10885
10886         * remote.c (class scoped_remote_fd) <release>: Add
10887         ATTRIBUTE_UNUSED_RESULT.
10888
10889 2019-03-05  Tom Tromey  <tromey@adacore.com>
10890
10891         * macroexp.c (struct macro_buffer) <release>: Add
10892         ATTRIBUTE_UNUSED_RESULT.
10893
10894 2019-03-05  Tom Tromey  <tromey@adacore.com>
10895
10896         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10897         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10898         ATTRIBUTE_UNUSED_RESULT.
10899
10900 2019-03-05  Tom Tromey  <tromey@adacore.com>
10901
10902         * common/scoped_fd.h (class scoped_fd) <release>: Add
10903         ATTRIBUTE_UNUSED_RESULT.
10904
10905 2019-03-05  Tom Tromey  <tromey@adacore.com>
10906
10907         * parser-defs.h (struct parser_state) <release>: Add
10908         ATTRIBUTE_UNUSED_RESULT.
10909
10910 2019-03-05  Tom Tromey  <tromey@adacore.com>
10911
10912         * utils.h (class gdb_argv) <release>: Add
10913         ATTRIBUTE_UNUSED_RESULT.
10914         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10915
10916 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10917
10918         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10919         for-loop range, to avoid compiler warnings.
10920
10921         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10922         avoid compiler warnings about unused variables.
10923
10924         * NEWS: Mention end of support for native debugging on MS-Windows
10925         before XP.
10926
10927         PR gdb/24292
10928         * common/netstuff.c:
10929         * gdbserver/gdbreplay.c
10930         * gdbserver/remote-utils.c:
10931         * ser-tcp.c:
10932         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10933         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10934         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10935         'getaddrinfo' and 'freeaddrinfo' were not available before
10936         Windows XP, and mingw.org's MinGW headers by default define
10937         _WIN32_WINNT to 0x500.
10938
10939 2019-03-01  Gary Benson <gbenson@redhat.com>
10940
10941         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10942
10943 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10944             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10945
10946         PR gdb/8527
10947         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10948         set_sigint_trap, clear_sigint_trap.
10949
10950 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10951
10952         * target.c (target_detach): Clear the regcache and the
10953         frame cache.
10954
10955 2019-02-27  Pedro Alves  <palves@redhat.com>
10956
10957         * utils.c (set_screen_size): When we cap the height/width sizes,
10958         tweak the corresponding command variable to show "unlimited":
10959
10960 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10961             Pedro Alves  <palves@redhat.com>
10962
10963         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10964         before calling rl_set_screen_size.
10965
10966 2019-02-27  Tom Tromey  <tromey@adacore.com>
10967
10968         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10969         define.
10970         * python/py-value.c: Remove Python 2.4 workaround.
10971         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10972         workaround.
10973         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10974         Python 2.4 workaround.
10975         * python/python-internal.h: Remove Python 2.4 comment.
10976         (Py_ssize_t): Don't define.
10977         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10978         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10979         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10980         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10981         * python/python.c (do_start_initialization): Remove Python 2.4
10982         workaround.
10983         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10984         (print_children): Remove Python 2.4 workaround.
10985         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10986         workaround.
10987         (CHARBUFFERPROC_NAME): Remove.
10988         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10989         Python 2.4 workaround.
10990
10991 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10992
10993         * NEWS: Note minimum Python version.
10994
10995 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10996
10997         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10998         code from these functions.  Remove corresponding ifdefs.  Use
10999         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11000         Remove gotos and target of gotos.
11001         (infpy_search_memory): Likewise.
11002
11003 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11004
11005         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11006         (hppa_gdbarch_init): Don't register deleted functions with
11007         gdbarch.
11008
11009 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11010
11011         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11012         (h8300_unwind_sp): Delete.
11013         (h8300_dummy_id): Delete.
11014         (h8300_gdbarch_init): Don't register deleted functions with
11015         gdbarch.
11016
11017 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11018
11019         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11020         (ft32_unwind_pc): Delete.
11021         (ft32_unwind_sp): Delete.
11022         (ft32_gdbarch_init): Don't register deleted functions with
11023         gdbarch.
11024
11025 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11026
11027         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11028         (frv_unwind_pc): Delete.
11029         (frv_unwind_sp): Delete.
11030         (frv_gdbarch_init): Don't register deleted functions with
11031         gdbarch.
11032
11033 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11034
11035         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11036         (riscv_unwind_pc): Delete.
11037         (riscv_unwind_sp): Delete.
11038         (riscv_gdbarch_init): Don't register deleted functions with
11039         gdbarch.
11040
11041 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11042
11043         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11044         (csky_unwind_pc): Delete.
11045         (csky_unwind_sp): Delete.
11046         (csky_gdbarch_init): Don't register deleted functions with
11047         gdbarch.
11048
11049 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11050
11051         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11052         (cris_unwind_pc): Delete.
11053         (cris_unwind_sp): Delete.
11054         (cris_gdbarch_init): Don't register deleted functions with
11055         gdbarch.
11056
11057 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11058
11059         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11060         (bfin_unwind_pc): Delete.
11061         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11062
11063 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11064
11065         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11066         (arm_unwind_pc): Delete.
11067         (arm_unwind_sp): Delete.
11068         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11069
11070 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11071
11072         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11073         (arc_unwind_pc): Delete.
11074         (arc_unwind_sp): Delete.
11075         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11076
11077 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11078
11079         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11080         (alpha_unwind_pc): Delete.
11081         (alpha_gdbarch_init): Don't register deleted functions with
11082         gdbarch.
11083
11084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11085
11086         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11087         (aarch64_unwind_pc): Delete.
11088         (aarch64_unwind_sp): Delete.
11089         (aarch64_gdbarch_init): Don't register deleted functions with
11090         gdbarch.
11091
11092 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11093
11094         * gdbtypes.c (type_align): Don't consider static members when
11095         computing structure alignment.
11096
11097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11098
11099         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11100         return 0 for other types.
11101         * arch-utils.c (default_type_align): Always return 0.
11102         * gdbarch.h: Regenerate.
11103         * gdbarch.sh (type_align): Extend comment.
11104         * gdbtypes.c (type_align): Add additional comments, always call
11105         gdbarch_type_align before applying the default rules.
11106         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11107         generic code will then apply a suitable default.
11108         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11109         types, return 0 for other types.
11110
11111 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11112
11113         * NEWS: Create a new section for the next release branch.
11114         Rename the section of the current branch, now that it has
11115         been cut.
11116
11117 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11118
11119         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11120         * version.in: Bump version to 8.3.50.DATE-git.
11121
11122 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11123
11124         * aix-thread.c (ptid_cmp): Remove unused variable.
11125         (get_signaled_thread): Likewise.
11126         (store_regs_user_thread): Likewise.
11127         (store_regs_kernel_thread): Likewise.
11128         (fetch_regs_kernel_thread): Remove shadowed variable.
11129
11130 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11131
11132         * features/riscv/32bit-cpu.xml: Add register numbers.
11133         * features/riscv/32bit-fpu.c: Regenerate.
11134         * features/riscv/32bit-fpu.xml: Add register numbers.
11135         * features/riscv/64bit-cpu.xml: Add register numbers.
11136         * features/riscv/64bit-fpu.c: Regenerate.
11137         * features/riscv/64bit-fpu.xml: Add register numbers.
11138
11139 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11140
11141         * NEWS: Mention two argument form of gdb.Value constructor.
11142         * python/py-value.c (convert_buffer_and_type_to_value): New
11143         function.
11144         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11145         Add support for handling an optional second argument.  Call
11146         convert_buffer_and_type_to_value as appropriate.
11147         * python/python-internal.h (Py_buffer_deleter): New struct.
11148         (Py_buffer_up): New typedef.
11149
11150 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11151
11152         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11153         instead of releasing ownership.
11154
11155 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11156
11157         * dwarf2read.c (open_and_init_dwp_file): Call
11158         elf_numsections instead of bfd_count_sections to initialize
11159         dwp_file->num_sections.
11160
11161 2019-02-25  Tom Tromey  <tromey@adacore.com>
11162
11163         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11164
11165 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11166
11167         * gcore.in: Add '--readnever' option when invoking GDB.
11168
11169 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11170
11171         * MAINTAINERS: Update my email address.
11172
11173 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11174
11175         * build-id.c (build_id_to_debug_bfd_1): New function.
11176         (build_id_to_debug_bfd): Look for separate debug file in
11177         sysroot.
11178
11179 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11180
11181         * gdbarch.sh: Update the copyright year range that is placed into
11182         generated files.
11183
11184 2019-02-22  Keith Seitz  <keiths@redhat.com>
11185
11186         PR symtab/23853
11187         * linespec.c (create_sals_line_offset): Search for the default
11188         symtab's filename instead of its fullname.
11189
11190 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11191
11192         * NEWS: Update style defaults.
11193
11194 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11195
11196         * main.c (captured_main_1): Disable styling in batch mode.
11197
11198 2019-02-20  Tom Tromey  <tom@tromey.com>
11199
11200         * symtab.c (symtab_symbol_info): Fix typos.
11201
11202 2019-02-20  Tom Tromey  <tromey@adacore.com>
11203
11204         * findcmd.c (_initialize_mem_search): Use upper case for
11205         metasyntactic variables.
11206
11207 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11208
11209         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11210         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11211
11212 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11213
11214         * top.h (source_file_name): Change to std::string.
11215         * top.c (source_file_name): Likewise.
11216         (command_line_input): Adjust.
11217         * cli/cli-script.c (script_from_file): Adjust.
11218
11219 2019-02-19  Tom Tromey  <tromey@adacore.com>
11220
11221         * ravenscar-thread.c
11222         (ravenscar_thread_target::update_thread_list): Don't call
11223         ada_build_task_list.
11224         * ada-lang.h (ada_build_task_list): Don't declare.
11225         * ada-tasks.c (struct ada_tasks_inferior_data)
11226         <task_list_valid_p>: Now bool.
11227         (read_known_tasks, ada_task_list_changed)
11228         (ada_tasks_invalidate_inferior_data): Update.
11229         (read_known_tasks_array): Return bool.
11230         (read_known_tasks_list): Likewise.
11231         (read_known_tasks): Return void.
11232         (ada_build_task_list): Now static.
11233
11234 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11235
11236         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11237         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11238
11239 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11240
11241         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11242         variant for ada_tasks_pspace_data_handle and
11243         ada_tasks_inferior_data_handle.
11244         (ada_tasks_pspace_data_cleanup): New function.
11245         (ada_tasks_inferior_data_cleanup): New function.
11246
11247 2019-02-17  Tom Tromey  <tom@tromey.com>
11248
11249         * macrotab.h (macro_source_fullname): Return a std::string.
11250         * macrotab.c (macro_include, check_for_redefinition)
11251         (macro_undef, macro_lookup_definition, foreach_macro)
11252         (foreach_macro_in_scope): Update.
11253         (macro_source_fullname): Return a std::string.
11254         * macrocmd.c (show_pp_source_pos): Update.
11255
11256 2019-02-17  Tom Tromey  <tom@tromey.com>
11257
11258         * macrocmd.c (show_pp_source_pos): Style the file names.
11259
11260 2019-02-17  Tom Tromey  <tom@tromey.com>
11261
11262         PR tui/24197:
11263         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11264
11265 2019-02-17  Tom Tromey  <tom@tromey.com>
11266
11267         * ada-lang.c (user_select_syms): Use filtered printing.
11268         * utils.c (wrap_style): New global.
11269         (desired_style): Remove.
11270         (emit_style_escape): Add stream parameter.
11271         (set_output_style, reset_terminal_style, prompt_for_continue):
11272         Update.
11273         (flush_wrap_buffer): Only flush gdb_stdout.
11274         (wrap_here): Set wrap_style.
11275         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11276         treat escape sequences as a character.  Change when wrap buffer is
11277         flushed.
11278         (fputs_styled): Do not set the output style when the default is
11279         requested.
11280         * ui-style.h (struct ui_file_style) <is_default>: New method.
11281         * source.c (print_source_lines_base): Emit escape sequences in one
11282         piece.
11283
11284 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11285
11286         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11287         integers and enumeration types.
11288
11289 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11290
11291         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11292         instead of lookup_symbol_in_language
11293         (do_exact_match): New function.
11294         (ada_get_symbol_name_matcher): Return do_exact_match when
11295         doing a verbatim match.
11296
11297 2019-02-15  Tom Tromey  <tromey@adacore.com>
11298
11299         * ravenscar-thread.c (ravenscar_thread_target::resume)
11300         (ravenscar_thread_target::wait): Special case wildcard requests.
11301
11302 2019-02-15  Tom Tromey  <tromey@adacore.com>
11303
11304         * ravenscar-thread.c (base_ptid): Remove.
11305         (struct ravenscar_thread_target) <close>: New method.
11306         <m_base_ptid>: New member.
11307         <update_inferior_ptid, active_task, task_is_currently_active,
11308         runtime_initialized>: Declare methods.
11309         <ravenscar_thread_target>: Add constructor.
11310         (ravenscar_thread_target::task_is_currently_active)
11311         (ravenscar_thread_target::update_inferior_ptid)
11312         (ravenscar_runtime_initialized): Rename.  Now methods.
11313         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11314         (ravenscar_thread_target::update_thread_list): Update.
11315         (ravenscar_thread_target::active_task): Now method.
11316         (ravenscar_thread_target::store_registers)
11317         (ravenscar_thread_target::prepare_to_store)
11318         (ravenscar_thread_target::prepare_to_store)
11319         (ravenscar_thread_target::mourn_inferior): Update.
11320         (ravenscar_inferior_created): Use "new" to create target.
11321         (ravenscar_thread_target::get_ada_task_ptid): Update.
11322         (_initialize_ravenscar): Don't initialize base_ptid.
11323         (ravenscar_ops): Remove global.
11324
11325 2019-02-15  Tom Tromey  <tromey@adacore.com>
11326
11327         * target.h (push_target): Declare new overload.
11328         * target.c (push_target): New overload, taking an rvalue reference.
11329         * remote.c (remote_target::open_1): Use push_target overload.
11330         * corelow.c (core_target_open): Use push_target overload.
11331
11332 2019-02-15  Tom Tromey  <tromey@adacore.com>
11333
11334         * ravenscar-thread.c (is_ravenscar_task)
11335         (ravenscar_task_is_currently_active): Return bool.
11336         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11337         (_initialize_ravenscar): Remove "(void)".
11338         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11339         Return bool.
11340
11341 2019-02-15  Tom Tromey  <tromey@adacore.com>
11342
11343         * ravenscar-thread.c (ravenscar_runtime_initializer)
11344         (has_ravenscar_runtime, get_running_thread_id)
11345         (ravenscar_thread_target::resume): Fix indentation.
11346
11347 2019-02-15  Tom Tromey  <tromey@adacore.com>
11348
11349         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11350         from ravenscar_arch_ops.
11351         (sparc_ravenscar_ops::fetch_registers)
11352         (sparc_ravenscar_ops::store_registers): Now methods.
11353         (sparc_ravenscar_prepare_to_store): Remove.
11354         (sparc_ravenscar_ops): Redefine.
11355         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11356         methods and destructor.  Remove members.
11357         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11358         (ravenscar_thread_target::store_registers)
11359         (ravenscar_thread_target::prepare_to_store): Update.
11360         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11361         Remove.
11362         (struct ppc_ravenscar_powerpc_ops): Derive from
11363         ravenscar_arch_ops.
11364         (ppc_ravenscar_powerpc_ops::fetch_registers)
11365         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11366         (ppc_ravenscar_powerpc_ops): Redefine.
11367         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11368         (ppc_ravenscar_e500_ops::fetch_registers)
11369         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11370         (ppc_ravenscar_e500_ops): Redefine.
11371         * aarch64-ravenscar-thread.c
11372         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11373         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11374         (aarch64_ravenscar_fetch_registers)
11375         (aarch64_ravenscar_store_registers): Now methods.
11376         (aarch64_ravenscar_ops): Redefine.
11377
11378 2019-02-15  Tom Tromey  <tromey@adacore.com>
11379
11380         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11381         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11382         (ravenscar_thread_target::stopped_by_watchpoint)
11383         (ravenscar_thread_target::stopped_data_address)
11384         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11385
11386 2019-02-15  Tom Tromey  <tromey@adacore.com>
11387
11388         * ravenscar-thread.c: Fix some typos.
11389
11390 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11391             Tom Tromey  <tromey@adacore.com>
11392
11393         * ada-lang.c (ada_exception_sal): Change addr_string to a
11394         std::string.
11395         (create_ada_exception_catchpoint): Update.
11396
11397 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11398             Tom Tromey  <tromey@adacore.com>
11399
11400         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11401         (bp_location_ops): Remove.
11402         (base_breakpoint_allocate_location): Update.
11403         (free_bp_location): Update.
11404         * ada-lang.c (class ada_catchpoint_location)
11405         <ada_catchpoint_location>: Remove ops parameter.
11406         (ada_catchpoint_location_dtor): Remove.
11407         (ada_catchpoint_location_ops): Remove.
11408         (allocate_location_exception): Update.
11409         * breakpoint.h (struct bp_location_ops): Remove.
11410         (class bp_location) <bp_location>: Remove bp_location_ops
11411         parameter.
11412         <~bp_location>: Add destructor.
11413         <ops>: Remove.
11414
11415 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11416             Pedro Alves  <palves@redhat.com>
11417
11418         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11419         'PATH_MAX'.
11420
11421 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11422             Samuel Thibault  <samuel.thibault@gnu.org>
11423             Thomas Schwinge  <thomas@codesourcery.com>
11424
11425         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11426         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11427
11428 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11429
11430         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11431         (check_empty): Use "const char *".
11432
11433         * gnu-nat.c (gnu_nat_target::detach): Instead of
11434         'detach_inferior (pid)' call
11435         'detach_inferior (find_inferior_pid (pid))'.
11436
11437         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11438         'nat/fork-inferior.o'.
11439         * gnu-nat.c: #include "nat/fork-inferior.h".
11440
11441         * gnu-nat.c (gnu_nat_target::detach): Instead of
11442         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11443         * gnu-nat.h: #include "inf-child.h".
11444         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11445         'i386_gnu_nat_target::fetch_registers'.
11446         (gnu_store_registers): Rename/move to
11447         'i386_gnu_nat_target::store_registers'.
11448
11449         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11450         * gnu-nat.h (mach_thread_info): New function.
11451         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11452
11453         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11454
11455 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11456
11457         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11458
11459 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11460
11461         * windows-nat.c (windows_add_thread): Add new parameter
11462         "main_thread_p" with default value set to false.  Update
11463         function documentation as well as all callers.
11464         (windows_delete_thread): Likewise.
11465         (fake_create_process): Update call to windows_add_thread.
11466         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11467         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11468         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11469         call to windows_delete_thread.
11470
11471 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11472
11473         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11474
11475 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11476
11477         * symfile.c (find_separate_debug_file): Use canonical path of
11478         sysroot with child_path instead of gdb_sysroot if it is valid.
11479
11480 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11481
11482         * symfile.c (find_separate_debug_file): Use child_path to
11483         determine if an object file is under a sysroot.
11484
11485 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11486
11487         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11488         unittests/child-path-selftests.c.
11489         * common/pathstuff.c (child_path): New function.
11490         * common/pathstuff.h (child_path): New prototype.
11491         * unittests/child-path-selftests.c: New file.
11492
11493 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11494
11495         * symfile.c (find_separate_debug_file): Look for separate debug
11496         files in debug directories under the sysroot.
11497
11498 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11499
11500         * symtab.h (struct minimal_symbol data_p): New const method.
11501         (struct minimal_symbol text_p): Likewise.
11502         * symtab.c (output_source_filename): Use file name style
11503         to print file name.
11504         (print_symbol_info): Likewise.
11505         (print_msymbol_info): Use address style to print addresses.
11506         Use function name style to print executable text symbols.
11507         (expand_symtab_containing_pc): Use data_p.
11508         (find_pc_sect_compunit_symtab): Likewise.
11509
11510 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11511
11512         * breakpoint.c (describe_other_breakpoints): Use address style
11513         to print addresses.
11514         (say_where): Likewise.
11515
11516 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11517
11518         * ada-typeprint.c (print_func_type): Print function name
11519         style to print function name.
11520         * c-typeprint.c (c_print_type_1): Likewise.
11521
11522 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11523
11524         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11525         for execve.
11526
11527 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11528
11529         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11530         type_stack.
11531
11532 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11533
11534         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11535         TYPE_CODE_REF types.
11536
11537 2019-02-08  Jim Wilson  <jimw@sifive.com>
11538
11539         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11540         (riscv_linux_fregset): New.
11541         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11542
11543 2019-02-07  Tom Tromey  <tom@tromey.com>
11544
11545         * thread.c (thread_cancel_execution_command): Update.
11546         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11547         methods.
11548         (struct thread_fsm_ops): Remove.
11549         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11550         (thread_fsm_should_stop, thread_fsm_return_value)
11551         (thread_fsm_set_finished, thread_fsm_finished_p)
11552         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11553         Don't declare.
11554         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11555         * infrun.c (clear_proceed_status_thread)
11556         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11557         (print_stop_event): Update.
11558         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11559         Add constructor.
11560         (step_command_fsm_ops): Remove.
11561         (new_step_command_fsm): Remove.
11562         (step_1): Update.
11563         (step_command_fsm::should_stop): Rename from
11564         step_command_fsm_should_stop.
11565         (step_command_fsm::clean_up): Rename from
11566         step_command_fsm_clean_up.
11567         (step_command_fsm::do_async_reply_reason): Rename from
11568         step_command_fsm_async_reply_reason.
11569         (struct until_next_fsm): Inherit from thread_fsm.  Add
11570         constructor.
11571         (until_next_fsm_ops): Remove.
11572         (new_until_next_fsm): Remove.
11573         (until_next_fsm::should_stop): Rename from
11574         until_next_fsm_should_stop.
11575         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11576         (until_next_fsm::do_async_reply_reason): Rename from
11577         until_next_fsm_async_reply_reason.
11578         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11579         constructor.  Change type of breakpoint.
11580         (finish_command_fsm_ops): Remove.
11581         (new_finish_command_fsm): Remove.
11582         (finish_command_fsm::should_stop): Rename from
11583         finish_command_fsm_should_stop.
11584         (finish_command_fsm::clean_up): Rename from
11585         finish_command_fsm_clean_up.
11586         (finish_command_fsm::return_value): Rename from
11587         finish_command_fsm_return_value.
11588         (finish_command_fsm::do_async_reply_reason): Rename from
11589         finish_command_fsm_async_reply_reason.
11590         (finish_command): Update.
11591         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11592         Add constructor.
11593         (call_thread_fsm_ops): Remove.
11594         (call_thread_fsm::call_thread_fsm): Rename from
11595         new_call_thread_fsm.
11596         (call_thread_fsm::should_stop): Rename from
11597         call_thread_fsm_should_stop.
11598         (call_thread_fsm::should_notify_stop): Rename from
11599         call_thread_fsm_should_notify_stop.
11600         (run_inferior_call, call_function_by_hand_dummy): Update.
11601         * cli/cli-interp.c (should_print_stop_to_console): Update.
11602         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11603         Add constructor.  Change type of location_breakpoint,
11604         caller_breakpoint.
11605         (until_break_fsm_ops): Remove.
11606         (new_until_break_fsm): Remove.
11607         (until_break_fsm::should_stop): Rename from
11608         until_break_fsm_should_stop.
11609         (until_break_fsm::clean_up): Rename from
11610         until_break_fsm_clean_up.
11611         (until_break_fsm::do_async_reply_reason): Rename from
11612         until_break_fsm_async_reply_reason.
11613         (until_break_command): Update.
11614         * thread-fsm.c: Remove.
11615         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11616
11617 2019-02-07  Tom Tromey  <tom@tromey.com>
11618
11619         * yy-remap.h: Add include guard.
11620         * xtensa-tdep.h: Add include guard.
11621         * xcoffread.h: Rename include guard.
11622         * varobj-iter.h: Add include guard.
11623         * tui/tui.h: Rename include guard.
11624         * tui/tui-winsource.h: Rename include guard.
11625         * tui/tui-wingeneral.h: Rename include guard.
11626         * tui/tui-windata.h: Rename include guard.
11627         * tui/tui-win.h: Rename include guard.
11628         * tui/tui-stack.h: Rename include guard.
11629         * tui/tui-source.h: Rename include guard.
11630         * tui/tui-regs.h: Rename include guard.
11631         * tui/tui-out.h: Rename include guard.
11632         * tui/tui-layout.h: Rename include guard.
11633         * tui/tui-io.h: Rename include guard.
11634         * tui/tui-hooks.h: Rename include guard.
11635         * tui/tui-file.h: Rename include guard.
11636         * tui/tui-disasm.h: Rename include guard.
11637         * tui/tui-data.h: Rename include guard.
11638         * tui/tui-command.h: Rename include guard.
11639         * tic6x-tdep.h: Add include guard.
11640         * target/waitstatus.h: Rename include guard.
11641         * target/wait.h: Rename include guard.
11642         * target/target.h: Rename include guard.
11643         * target/resume.h: Rename include guard.
11644         * target-float.h: Rename include guard.
11645         * stabsread.h: Add include guard.
11646         * rs6000-tdep.h: Add include guard.
11647         * riscv-fbsd-tdep.h: Add include guard.
11648         * regformats/regdef.h: Rename include guard.
11649         * record.h: Rename include guard.
11650         * python/python.h: Rename include guard.
11651         * python/python-internal.h: Rename include guard.
11652         * python/py-stopevent.h: Rename include guard.
11653         * python/py-ref.h: Rename include guard.
11654         * python/py-record.h: Rename include guard.
11655         * python/py-record-full.h: Rename include guard.
11656         * python/py-record-btrace.h: Rename include guard.
11657         * python/py-instruction.h: Rename include guard.
11658         * python/py-events.h: Rename include guard.
11659         * python/py-event.h: Rename include guard.
11660         * procfs.h: Add include guard.
11661         * proc-utils.h: Add include guard.
11662         * p-lang.h: Add include guard.
11663         * or1k-tdep.h: Rename include guard.
11664         * observable.h: Rename include guard.
11665         * nto-tdep.h: Rename include guard.
11666         * nat/x86-linux.h: Rename include guard.
11667         * nat/x86-linux-dregs.h: Rename include guard.
11668         * nat/x86-gcc-cpuid.h: Add include guard.
11669         * nat/x86-dregs.h: Rename include guard.
11670         * nat/x86-cpuid.h: Rename include guard.
11671         * nat/ppc-linux.h: Rename include guard.
11672         * nat/mips-linux-watch.h: Rename include guard.
11673         * nat/linux-waitpid.h: Rename include guard.
11674         * nat/linux-ptrace.h: Rename include guard.
11675         * nat/linux-procfs.h: Rename include guard.
11676         * nat/linux-osdata.h: Rename include guard.
11677         * nat/linux-nat.h: Rename include guard.
11678         * nat/linux-namespaces.h: Rename include guard.
11679         * nat/linux-btrace.h: Rename include guard.
11680         * nat/glibc_thread_db.h: Rename include guard.
11681         * nat/gdb_thread_db.h: Rename include guard.
11682         * nat/gdb_ptrace.h: Rename include guard.
11683         * nat/fork-inferior.h: Rename include guard.
11684         * nat/amd64-linux-siginfo.h: Rename include guard.
11685         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11686         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11687         * nat/aarch64-linux.h: Rename include guard.
11688         * nat/aarch64-linux-hw-point.h: Rename include guard.
11689         * mn10300-tdep.h: Add include guard.
11690         * mips-linux-tdep.h: Add include guard.
11691         * mi/mi-parse.h: Rename include guard.
11692         * mi/mi-out.h: Rename include guard.
11693         * mi/mi-main.h: Rename include guard.
11694         * mi/mi-interp.h: Rename include guard.
11695         * mi/mi-getopt.h: Rename include guard.
11696         * mi/mi-console.h: Rename include guard.
11697         * mi/mi-common.h: Rename include guard.
11698         * mi/mi-cmds.h: Rename include guard.
11699         * mi/mi-cmd-break.h: Rename include guard.
11700         * m2-lang.h: Add include guard.
11701         * location.h: Rename include guard.
11702         * linux-record.h: Rename include guard.
11703         * linux-nat.h: Add include guard.
11704         * linux-fork.h: Add include guard.
11705         * i386-darwin-tdep.h: Rename include guard.
11706         * hppa-linux-offsets.h: Add include guard.
11707         * guile/guile.h: Rename include guard.
11708         * guile/guile-internal.h: Rename include guard.
11709         * gnu-nat.h: Rename include guard.
11710         * gdb-stabs.h: Rename include guard.
11711         * frv-tdep.h: Add include guard.
11712         * f-lang.h: Add include guard.
11713         * event-loop.h: Add include guard.
11714         * darwin-nat.h: Rename include guard.
11715         * cp-abi.h: Rename include guard.
11716         * config/sparc/nm-sol2.h: Rename include guard.
11717         * config/nm-nto.h: Rename include guard.
11718         * config/nm-linux.h: Add include guard.
11719         * config/i386/nm-i386gnu.h: Rename include guard.
11720         * config/djgpp/nl_types.h: Rename include guard.
11721         * config/djgpp/langinfo.h: Rename include guard.
11722         * compile/gcc-cp-plugin.h: Add include guard.
11723         * compile/gcc-c-plugin.h: Add include guard.
11724         * compile/compile.h: Rename include guard.
11725         * compile/compile-object-run.h: Rename include guard.
11726         * compile/compile-object-load.h: Rename include guard.
11727         * compile/compile-internal.h: Rename include guard.
11728         * compile/compile-cplus.h: Rename include guard.
11729         * compile/compile-c.h: Rename include guard.
11730         * common/xml-utils.h: Rename include guard.
11731         * common/x86-xstate.h: Rename include guard.
11732         * common/version.h: Rename include guard.
11733         * common/vec.h: Rename include guard.
11734         * common/tdesc.h: Rename include guard.
11735         * common/selftest.h: Rename include guard.
11736         * common/scoped_restore.h: Rename include guard.
11737         * common/scoped_mmap.h: Rename include guard.
11738         * common/scoped_fd.h: Rename include guard.
11739         * common/safe-iterator.h: Rename include guard.
11740         * common/run-time-clock.h: Rename include guard.
11741         * common/refcounted-object.h: Rename include guard.
11742         * common/queue.h: Rename include guard.
11743         * common/ptid.h: Rename include guard.
11744         * common/print-utils.h: Rename include guard.
11745         * common/preprocessor.h: Rename include guard.
11746         * common/pathstuff.h: Rename include guard.
11747         * common/observable.h: Rename include guard.
11748         * common/netstuff.h: Rename include guard.
11749         * common/job-control.h: Rename include guard.
11750         * common/host-defs.h: Rename include guard.
11751         * common/gdb_wait.h: Rename include guard.
11752         * common/gdb_vecs.h: Rename include guard.
11753         * common/gdb_unlinker.h: Rename include guard.
11754         * common/gdb_unique_ptr.h: Rename include guard.
11755         * common/gdb_tilde_expand.h: Rename include guard.
11756         * common/gdb_sys_time.h: Rename include guard.
11757         * common/gdb_string_view.h: Rename include guard.
11758         * common/gdb_splay_tree.h: Rename include guard.
11759         * common/gdb_setjmp.h: Rename include guard.
11760         * common/gdb_ref_ptr.h: Rename include guard.
11761         * common/gdb_optional.h: Rename include guard.
11762         * common/gdb_locale.h: Rename include guard.
11763         * common/gdb_assert.h: Rename include guard.
11764         * common/filtered-iterator.h: Rename include guard.
11765         * common/filestuff.h: Rename include guard.
11766         * common/fileio.h: Rename include guard.
11767         * common/environ.h: Rename include guard.
11768         * common/common-utils.h: Rename include guard.
11769         * common/common-types.h: Rename include guard.
11770         * common/common-regcache.h: Rename include guard.
11771         * common/common-inferior.h: Rename include guard.
11772         * common/common-gdbthread.h: Rename include guard.
11773         * common/common-exceptions.h: Rename include guard.
11774         * common/common-defs.h: Rename include guard.
11775         * common/common-debug.h: Rename include guard.
11776         * common/cleanups.h: Rename include guard.
11777         * common/buffer.h: Rename include guard.
11778         * common/btrace-common.h: Rename include guard.
11779         * common/break-common.h: Rename include guard.
11780         * cli/cli-utils.h: Rename include guard.
11781         * cli/cli-style.h: Rename include guard.
11782         * cli/cli-setshow.h: Rename include guard.
11783         * cli/cli-script.h: Rename include guard.
11784         * cli/cli-interp.h: Rename include guard.
11785         * cli/cli-decode.h: Rename include guard.
11786         * cli/cli-cmds.h: Rename include guard.
11787         * charset-list.h: Add include guard.
11788         * buildsym-legacy.h: Rename include guard.
11789         * bfin-tdep.h: Add include guard.
11790         * ax.h: Rename include guard.
11791         * arm-linux-tdep.h: Add include guard.
11792         * arm-fbsd-tdep.h: Add include guard.
11793         * arch/xtensa.h: Rename include guard.
11794         * arch/tic6x.h: Add include guard.
11795         * arch/i386.h: Add include guard.
11796         * arch/arm.h: Rename include guard.
11797         * arch/arm-linux.h: Rename include guard.
11798         * arch/arm-get-next-pcs.h: Rename include guard.
11799         * arch/amd64.h: Add include guard.
11800         * arch/aarch64-insn.h: Rename include guard.
11801         * arch-utils.h: Rename include guard.
11802         * annotate.h: Add include guard.
11803         * amd64-darwin-tdep.h: Rename include guard.
11804         * aarch64-linux-tdep.h: Add include guard.
11805         * aarch64-fbsd-tdep.h: Add include guard.
11806         * aarch32-linux-nat.h: Add include guard.
11807
11808 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11809
11810         * macrotab.c (macro_define_internal): New function that
11811         factorizes macro_define_object_internal and macro_define_function
11812         code.
11813         (macro_define_object_internal): Use macro_define_internal.
11814         (macro_define_function): Likewise.
11815
11816 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11817
11818         * macrocmd.c (extract_identifier): Return
11819         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11820         callers.
11821
11822 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11823
11824         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11825
11826 2019-02-05  Tom Tromey  <tom@tromey.com>
11827
11828         * target.c (target_stack::unpush): Move assertion earlier.
11829
11830 2019-01-30  Tom Tromey  <tom@tromey.com>
11831
11832         PR python/23615:
11833         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11834         (gdbpy_parse_and_eval): Likewise.
11835         * python/python-internal.h (gdbpy_allow_threads): New class.
11836
11837 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11838
11839         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11840         (aarch64_fbsd_fpregmap): Move earlier.
11841         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11842         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11843         instead of individual calls to trad_frame_set_reg_addr.
11844         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11845         earlier.
11846         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11847         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11848         instead of individual calls to trad_frame_set_reg_addr.
11849
11850 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11851
11852         * CONTRIBUTE: Replace contribution list with wiki link.
11853
11854 2019-01-25  Tom Tromey  <tom@tromey.com>
11855
11856         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11857
11858 2019-01-25  Tom Tromey  <tom@tromey.com>
11859
11860         * xtensa-linux-nat.c: Fix common/ includes.
11861         * xml-support.h: Fix common/ includes.
11862         * xml-support.c: Fix common/ includes.
11863         * x86-linux-nat.c: Fix common/ includes.
11864         * windows-nat.c: Fix common/ includes.
11865         * varobj.h: Fix common/ includes.
11866         * varobj.c: Fix common/ includes.
11867         * value.c: Fix common/ includes.
11868         * valops.c: Fix common/ includes.
11869         * utils.c: Fix common/ includes.
11870         * unittests/xml-utils-selftests.c: Fix common/ includes.
11871         * unittests/utils-selftests.c: Fix common/ includes.
11872         * unittests/unpack-selftests.c: Fix common/ includes.
11873         * unittests/tracepoint-selftests.c: Fix common/ includes.
11874         * unittests/style-selftests.c: Fix common/ includes.
11875         * unittests/string_view-selftests.c: Fix common/ includes.
11876         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11877         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11878         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11879         * unittests/rsp-low-selftests.c: Fix common/ includes.
11880         * unittests/parse-connection-spec-selftests.c: Fix common/
11881         includes.
11882         * unittests/optional-selftests.c: Fix common/ includes.
11883         * unittests/offset-type-selftests.c: Fix common/ includes.
11884         * unittests/observable-selftests.c: Fix common/ includes.
11885         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11886         * unittests/memrange-selftests.c: Fix common/ includes.
11887         * unittests/memory-map-selftests.c: Fix common/ includes.
11888         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11889         * unittests/function-view-selftests.c: Fix common/ includes.
11890         * unittests/environ-selftests.c: Fix common/ includes.
11891         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11892         * unittests/common-utils-selftests.c: Fix common/ includes.
11893         * unittests/cli-utils-selftests.c: Fix common/ includes.
11894         * unittests/array-view-selftests.c: Fix common/ includes.
11895         * ui-file.c: Fix common/ includes.
11896         * tui/tui-io.c: Fix common/ includes.
11897         * tracepoint.h: Fix common/ includes.
11898         * tracepoint.c: Fix common/ includes.
11899         * tracefile-tfile.c: Fix common/ includes.
11900         * top.h: Fix common/ includes.
11901         * top.c: Fix common/ includes.
11902         * thread.c: Fix common/ includes.
11903         * target/waitstatus.h: Fix common/ includes.
11904         * target/waitstatus.c: Fix common/ includes.
11905         * target.h: Fix common/ includes.
11906         * target.c: Fix common/ includes.
11907         * target-memory.c: Fix common/ includes.
11908         * target-descriptions.c: Fix common/ includes.
11909         * symtab.h: Fix common/ includes.
11910         * symfile.c: Fix common/ includes.
11911         * stap-probe.c: Fix common/ includes.
11912         * spu-linux-nat.c: Fix common/ includes.
11913         * sparc-nat.c: Fix common/ includes.
11914         * source.c: Fix common/ includes.
11915         * solib.c: Fix common/ includes.
11916         * solib-target.c: Fix common/ includes.
11917         * ser-unix.c: Fix common/ includes.
11918         * ser-tcp.c: Fix common/ includes.
11919         * ser-pipe.c: Fix common/ includes.
11920         * ser-base.c: Fix common/ includes.
11921         * selftest-arch.c: Fix common/ includes.
11922         * s12z-tdep.c: Fix common/ includes.
11923         * rust-exp.y: Fix common/ includes.
11924         * rs6000-aix-tdep.c: Fix common/ includes.
11925         * riscv-tdep.c: Fix common/ includes.
11926         * remote.c: Fix common/ includes.
11927         * remote-notif.h: Fix common/ includes.
11928         * remote-fileio.h: Fix common/ includes.
11929         * remote-fileio.c: Fix common/ includes.
11930         * regcache.h: Fix common/ includes.
11931         * regcache.c: Fix common/ includes.
11932         * record-btrace.c: Fix common/ includes.
11933         * python/python.c: Fix common/ includes.
11934         * python/py-type.c: Fix common/ includes.
11935         * python/py-inferior.c: Fix common/ includes.
11936         * progspace.h: Fix common/ includes.
11937         * producer.c: Fix common/ includes.
11938         * procfs.c: Fix common/ includes.
11939         * proc-api.c: Fix common/ includes.
11940         * printcmd.c: Fix common/ includes.
11941         * ppc-linux-nat.c: Fix common/ includes.
11942         * parser-defs.h: Fix common/ includes.
11943         * osdata.c: Fix common/ includes.
11944         * obsd-nat.c: Fix common/ includes.
11945         * nat/x86-linux.c: Fix common/ includes.
11946         * nat/x86-linux-dregs.c: Fix common/ includes.
11947         * nat/x86-dregs.h: Fix common/ includes.
11948         * nat/x86-dregs.c: Fix common/ includes.
11949         * nat/ppc-linux.c: Fix common/ includes.
11950         * nat/mips-linux-watch.h: Fix common/ includes.
11951         * nat/mips-linux-watch.c: Fix common/ includes.
11952         * nat/linux-waitpid.c: Fix common/ includes.
11953         * nat/linux-ptrace.h: Fix common/ includes.
11954         * nat/linux-ptrace.c: Fix common/ includes.
11955         * nat/linux-procfs.c: Fix common/ includes.
11956         * nat/linux-personality.c: Fix common/ includes.
11957         * nat/linux-osdata.c: Fix common/ includes.
11958         * nat/linux-namespaces.c: Fix common/ includes.
11959         * nat/linux-btrace.h: Fix common/ includes.
11960         * nat/linux-btrace.c: Fix common/ includes.
11961         * nat/fork-inferior.c: Fix common/ includes.
11962         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11963         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11964         * nat/aarch64-linux.c: Fix common/ includes.
11965         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11966         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11967         * namespace.h: Fix common/ includes.
11968         * mips-linux-tdep.c: Fix common/ includes.
11969         * minsyms.c: Fix common/ includes.
11970         * mi/mi-parse.h: Fix common/ includes.
11971         * mi/mi-main.c: Fix common/ includes.
11972         * mi/mi-cmd-env.c: Fix common/ includes.
11973         * memrange.h: Fix common/ includes.
11974         * memattr.c: Fix common/ includes.
11975         * maint.h: Fix common/ includes.
11976         * maint.c: Fix common/ includes.
11977         * main.c: Fix common/ includes.
11978         * machoread.c: Fix common/ includes.
11979         * location.c: Fix common/ includes.
11980         * linux-thread-db.c: Fix common/ includes.
11981         * linux-nat.c: Fix common/ includes.
11982         * linux-fork.c: Fix common/ includes.
11983         * inline-frame.c: Fix common/ includes.
11984         * infrun.c: Fix common/ includes.
11985         * inflow.c: Fix common/ includes.
11986         * inferior.h: Fix common/ includes.
11987         * inferior.c: Fix common/ includes.
11988         * infcmd.c: Fix common/ includes.
11989         * inf-ptrace.c: Fix common/ includes.
11990         * inf-child.c: Fix common/ includes.
11991         * ia64-linux-nat.c: Fix common/ includes.
11992         * i387-tdep.c: Fix common/ includes.
11993         * i386-tdep.c: Fix common/ includes.
11994         * i386-linux-tdep.c: Fix common/ includes.
11995         * i386-linux-nat.c: Fix common/ includes.
11996         * i386-go32-tdep.c: Fix common/ includes.
11997         * i386-fbsd-tdep.c: Fix common/ includes.
11998         * i386-fbsd-nat.c: Fix common/ includes.
11999         * guile/scm-type.c: Fix common/ includes.
12000         * guile/guile.c: Fix common/ includes.
12001         * go32-nat.c: Fix common/ includes.
12002         * gnu-nat.c: Fix common/ includes.
12003         * gdbthread.h: Fix common/ includes.
12004         * gdbarch-selftests.c: Fix common/ includes.
12005         * gdb_usleep.c: Fix common/ includes.
12006         * gdb_select.h: Fix common/ includes.
12007         * gdb_bfd.c: Fix common/ includes.
12008         * gcore.c: Fix common/ includes.
12009         * fork-child.c: Fix common/ includes.
12010         * findvar.c: Fix common/ includes.
12011         * fbsd-nat.c: Fix common/ includes.
12012         * event-top.c: Fix common/ includes.
12013         * event-loop.c: Fix common/ includes.
12014         * dwarf2read.c: Fix common/ includes.
12015         * dwarf2loc.c: Fix common/ includes.
12016         * dwarf2-frame.c: Fix common/ includes.
12017         * dwarf-index-cache.c: Fix common/ includes.
12018         * dtrace-probe.c: Fix common/ includes.
12019         * disasm-selftests.c: Fix common/ includes.
12020         * defs.h: Fix common/ includes.
12021         * csky-tdep.c: Fix common/ includes.
12022         * cp-valprint.c: Fix common/ includes.
12023         * cp-support.h: Fix common/ includes.
12024         * cp-support.c: Fix common/ includes.
12025         * corelow.c: Fix common/ includes.
12026         * completer.h: Fix common/ includes.
12027         * completer.c: Fix common/ includes.
12028         * compile/compile.c: Fix common/ includes.
12029         * compile/compile-loc2c.c: Fix common/ includes.
12030         * compile/compile-cplus-types.c: Fix common/ includes.
12031         * compile/compile-cplus-symbols.c: Fix common/ includes.
12032         * command.h: Fix common/ includes.
12033         * cli/cli-dump.c: Fix common/ includes.
12034         * cli/cli-cmds.c: Fix common/ includes.
12035         * charset.c: Fix common/ includes.
12036         * build-id.c: Fix common/ includes.
12037         * btrace.h: Fix common/ includes.
12038         * btrace.c: Fix common/ includes.
12039         * breakpoint.h: Fix common/ includes.
12040         * breakpoint.c: Fix common/ includes.
12041         * ax.h:
12042         (enum agent_op): Fix common/ includes.
12043         * ax-general.c (struct aop_map): Fix common/ includes.
12044         * ax-gdb.c: Fix common/ includes.
12045         * auxv.c: Fix common/ includes.
12046         * auto-load.c: Fix common/ includes.
12047         * arm-tdep.c: Fix common/ includes.
12048         * arch/riscv.c: Fix common/ includes.
12049         * arch/ppc-linux-common.c: Fix common/ includes.
12050         * arch/i386.c: Fix common/ includes.
12051         * arch/arm.c: Fix common/ includes.
12052         * arch/arm-linux.c: Fix common/ includes.
12053         * arch/arm-get-next-pcs.c: Fix common/ includes.
12054         * arch/amd64.c: Fix common/ includes.
12055         * arch/aarch64.c: Fix common/ includes.
12056         * arch/aarch64-insn.c: Fix common/ includes.
12057         * arch-utils.c: Fix common/ includes.
12058         * amd64-windows-tdep.c: Fix common/ includes.
12059         * amd64-tdep.c: Fix common/ includes.
12060         * amd64-sol2-tdep.c: Fix common/ includes.
12061         * amd64-obsd-tdep.c: Fix common/ includes.
12062         * amd64-nbsd-tdep.c: Fix common/ includes.
12063         * amd64-linux-tdep.c: Fix common/ includes.
12064         * amd64-linux-nat.c: Fix common/ includes.
12065         * amd64-fbsd-tdep.c: Fix common/ includes.
12066         * amd64-fbsd-nat.c: Fix common/ includes.
12067         * amd64-dicos-tdep.c: Fix common/ includes.
12068         * amd64-darwin-tdep.c: Fix common/ includes.
12069         * agent.c: Fix common/ includes.
12070         * ada-lang.h: Fix common/ includes.
12071         * ada-lang.c: Fix common/ includes.
12072         * aarch64-tdep.c: Fix common/ includes.
12073
12074 2019-01-25  Tom Tromey  <tom@tromey.com>
12075
12076         * common/create-version.sh: Use common/version.h.
12077
12078 2019-01-24  Pedro Alves  <palves@redhat.com>
12079
12080         * infrun.c (signal_stop, signal_print, signal_program)
12081         (signal_catch, signal_pass): Now arrays instead of pointers.
12082         (update_signals_program_target, do_target_resume)
12083         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12084         * linux-nat.c (linux_nat_target::pass_signals)
12085         (linux_nat_target::create_inferior, linux_nat_target::attach):
12086         Adjust.
12087         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12088         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12089         * procfs.c (procfs_target::pass_signals): Adjust.
12090         * record-full.c (record_full_target::resume): Adjust.
12091         * remote.c (remote_target::pass_signals)
12092         (remote_target::program_signals): Adjust.
12093         * target-debug.h (target_debug_print_signals): Now takes a
12094         gdb::array_view as parameter.  Adjust.
12095         * target.h (target_ops) <pass_signals, program_signals>: Replace
12096         pointer and length parameters with gdb::array_view.
12097         (target_pass_signals, target_program_signals): Likewise.
12098         * target-delegates.c: Regenerate.
12099
12100 2019-01-24  Pedro Alves  <palves@redhat.com>
12101
12102         * common/forward-scope-exit.h
12103         (forward_scope_exit::forward_scope_exit): Pass arguments to
12104         m_bind_function directly, instead of creating a std::bind and
12105         copying that.
12106
12107 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12108
12109         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12110         for static members.
12111         (pass_in_v_vfp_candidate): Likewise.
12112
12113 2019-01-23  Tom Tromey  <tom@tromey.com>
12114             Pedro Alves  <palves@redhat.com>
12115
12116         * regcache.c (class regcache_invalidator): Remove.
12117         (regcache::raw_write): Use make_scope_exit.
12118
12119 2019-01-23  Tom Tromey  <tom@tromey.com>
12120
12121         * ui-out.h (class ui_out_emit_type): Update comment.
12122
12123 2019-01-23  Tom Tromey  <tom@tromey.com>
12124
12125         * infrun.c (fetch_inferior_event): Update comment.
12126
12127 2019-01-23  Tom Tromey  <tom@tromey.com>
12128             Pedro Alves  <palves@redhat.com>
12129
12130         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12131         parameter.
12132         (fetch_inferior_event): Use SCOPE_EXIT.
12133
12134
12135 2019-01-23  Tom Tromey  <tom@tromey.com>
12136             Pedro Alves  <palves@redhat.com>
12137
12138         * infrun.c (disable_thread_events): Delete.
12139         (stop_all_threads): Use SCOPE_EXIT.
12140
12141 2019-01-23  Tom Tromey  <tom@tromey.com>
12142             Pedro Alves  <palves@redhat.com>
12143
12144         * symfile.c: Include forward-scope-exit.h.
12145         (clear_symtab_users_cleanup): Replace forward declaration with
12146         a FORWARD_SCOPE_EXIT.
12147         (syms_from_objfile_1): Use the forward_scope_exit and
12148         gdb::optional instead of cleanup_function.
12149         (reread_symbols): Use the forward_scope_exit instead of
12150         cleanup_function.
12151         (clear_symtab_users_cleanup): Remove function.
12152
12153 2019-01-23  Tom Tromey  <tom@tromey.com>
12154             Pedro Alves  <palves@redhat.com>
12155
12156         * linux-nat.c: Include scope-exit.h.
12157         (cleanup_target_stop): Remove.
12158         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12159         SCOPE_EXIT.
12160
12161 2019-01-23  Tom Tromey  <tom@tromey.com>
12162             Pedro Alves  <palves@redhat.com>
12163
12164         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12165         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12166
12167 2019-01-23  Tom Tromey  <tom@tromey.com>
12168             Andrew Burgess  <andrew.burgess@embecosm.com>
12169             Pedro Alves  <palves@redhat.com>
12170
12171         * infrun.c (fetch_inferior_event): Use scope_exit.
12172         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12173         * top.c (execute_command): Use scope_exit.
12174         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12175         * utils.c (do_bpstat_clear_actions_cleanup)
12176         (make_bpstat_clear_actions_cleanup): Remove.
12177
12178 2019-01-23  Tom Tromey  <tom@tromey.com>
12179             Pedro Alves  <palves@redhat.com>
12180
12181         * infrun.c: Include "common/scope-exit.h"
12182         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12183         (wait_for_inferior): Use SCOPE_EXIT.
12184         (fetch_inferior_event): Use scope_exit.
12185
12186 2019-01-23  Tom Tromey  <tom@tromey.com>
12187             Pedro Alves  <palves@redhat.com>
12188
12189         * breakpoint.c (create_breakpoint): Remove cleanup.
12190
12191 2019-01-23  Tom Tromey  <tom@tromey.com>
12192             Andrew Burgess  <andrew.burgess@embecosm.com>
12193             Pedro Alves  <palves@redhat.com>
12194
12195 2019-01-23  Pedro Alves  <palves@redhat.com>
12196
12197         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12198
12199 2019-01-23  Pedro Alves  <palves@redhat.com>
12200             Andrew Burgess  <andrew.burgess@embecosm.com>
12201
12202         * gdbthread.h: Include "common/forward-scope-exit.h".
12203         (scoped_finish_thread_state): Redefine custom class in terms of
12204         forward_scope_exit.
12205
12206 2019-01-23  Pedro Alves  <palves@redhat.com>
12207             Andrew Burgess  <andrew.burgess@embecosm.com>
12208
12209         * common/forward-scope-exit.h: New file.
12210
12211 2019-01-23  Pedro Alves  <palves@redhat.com>
12212             Andrew Burgess  <andrew.burgess@embecosm.com>
12213             Tom Tromey  <tom@tromey.com>
12214
12215         * common/scope-exit.h: New file.
12216
12217 2019-01-23  Pedro Alves  <palves@redhat.com>
12218
12219         * common/preprocessor.h (ESC): Rename to ...
12220         (ESC_PARENS): ... this.
12221         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12222         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12223
12224 2019-01-23  Tom Tromey  <tom@tromey.com>
12225
12226         * language.h (class scoped_switch_to_sym_language_if_auto):
12227         Initialize m_lang in both cases.
12228
12229 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12230
12231         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12232         with XCNEW.
12233
12234 2019-01-22  Tom Tromey  <tom@tromey.com>
12235
12236         * corelow.c: Do not include sys/file.h.
12237
12238 2019-01-22  Tom Tromey  <tom@tromey.com>
12239
12240         * tui/tui-wingeneral.h: Include gdb_curses.h.
12241
12242 2019-01-22  Tom Tromey  <tom@tromey.com>
12243
12244         * source-cache.h (class source_cache) <get_source_lines,
12245         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12246
12247 2019-01-22  Tom Tromey  <tom@tromey.com>
12248
12249         * remote-fileio.h (struct remote_target): Declare.
12250
12251 2019-01-22  Tom Tromey  <tom@tromey.com>
12252
12253         * python/py-arch.c: Do not include py-ref.h.
12254         * python/py-bpevent.c: Do not include py-ref.h.
12255         * python/py-cmd.c: Do not include py-ref.h.
12256         * python/py-continueevent.c: Do not include py-ref.h.
12257         * python/py-event.h: Do not include py-ref.h.
12258         * python/py-evtregistry.c: Do not include py-ref.h.
12259         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12260         * python/py-frame.c: Do not include py-ref.h.
12261         * python/py-framefilter.c: Do not include py-ref.h.
12262         * python/py-function.c: Do not include py-ref.h.
12263         * python/py-infevents.c: Do not include py-ref.h.
12264         * python/py-linetable.c: Do not include py-ref.h.
12265         * python/py-objfile.c: Do not include py-ref.h.
12266         * python/py-param.c: Do not include py-ref.h.
12267         * python/py-prettyprint.c: Do not include py-ref.h.
12268         * python/py-progspace.c: Do not include py-ref.h.
12269         * python/py-symbol.c: Do not include py-ref.h.
12270         * python/py-symtab.c: Do not include py-ref.h.
12271         * python/py-type.c: Do not include py-ref.h.
12272         * python/py-unwind.c: Do not include py-ref.h.
12273         * python/py-utils.c: Do not include py-ref.h.
12274         * python/py-value.c: Do not include py-ref.h.
12275         * python/py-varobj.c: Do not include py-ref.h.
12276         * python/py-xmethods.c: Do not include py-ref.h.
12277         * python/python.c: Do not include py-ref.h.
12278         * varobj.c: Do not include py-ref.h.
12279
12280 2019-01-22  Tom Tromey  <tom@tromey.com>
12281
12282         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12283         keyword for bcache.
12284
12285 2019-01-22  Tom Tromey  <tom@tromey.com>
12286
12287         * compile/compile-cplus-types.c: Remove a comment by #include.
12288
12289 2019-01-22  Tom Tromey  <tom@tromey.com>
12290
12291         * compile/gcc-c-plugin.h: Include compile-internal.h.
12292
12293 2019-01-22  Tom Tromey  <tom@tromey.com>
12294
12295         * stabsread.c (EXTERN): Do not define.
12296         (symnum, next_symbol_text_func, processing_gcc_compilation)
12297         (within_function, global_sym_chain, global_stabs)
12298         (previous_stab_code, this_object_header_files)
12299         (n_this_object_header_files)
12300         (n_allocated_this_object_header_files): Define.
12301         * stabsread.h (EXTERN): Never define.  Use "extern".
12302
12303 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12304
12305         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12306         history_value.
12307
12308 2019-01-21  Tom Tromey  <tom@tromey.com>
12309
12310         * ui-out.c: Fix includes.
12311         * tui/tui-source.c: Fix includes.
12312         * target.c: Fix includes.
12313         * remote.c: Fix includes.
12314         * regcache.c: Fix includes.
12315         * python/py-block.c: Fix includes.
12316         * printcmd.c: Fix includes.
12317         * or1k-tdep.c: Fix includes.
12318         * mi/mi-main.c: Fix includes.
12319         * m32r-tdep.c: Fix includes.
12320         * csky-tdep.c: Fix includes.
12321         * compile/compile-cplus-types.c: Fix includes.
12322         * cli/cli-interp.c: Fix includes.
12323
12324 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12325
12326         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12327         for padding.
12328
12329 2019-01-16  Tom Tromey  <tom@tromey.com>
12330
12331         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12332         earlier.
12333         (struct objfile) <msymbols_range>: Move from top level.
12334         <msymbols>: New method.
12335         (class objfile_msymbols): Remove.
12336         * symtab.c (default_collect_symbol_completion_matches_break_on):
12337         Update.
12338         * symmisc.c (dump_msymbols): Update.
12339         * stabsread.c (scan_file_globals): Update.
12340         * objc-lang.c (info_selectors_command, info_classes_command)
12341         (find_methods): Update.
12342         * minsyms.c (find_solib_trampoline_target): Update.
12343         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12344         * coffread.c (coff_symfile_read): Update.
12345         * ada-lang.c (ada_lookup_simple_minsym)
12346         (ada_collect_symbol_completion_matches): Update.
12347
12348 2019-01-16  Tom Tromey  <tom@tromey.com>
12349
12350         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12351         type.  Remove no-argument constructor.
12352         <iterator::operator++>: Simplify.
12353         <begin>: Update.
12354         <end>: Use minimal_symbol_count.
12355
12356 2019-01-16  Tom Tromey  <tom@tromey.com>
12357
12358         * objfiles.h (struct objfile) <psymtabs>: New method.
12359         (class objfile_psymtabs): Remove.
12360         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12361         typedef.
12362         <range>: New method.
12363         (require_partial_symbols): Change return type.
12364         * psymtab.c (require_partial_symbols)
12365         (psym_expand_symtabs_matching): Update.
12366         * mdebugread.c (parse_partial_symbols): Update.
12367         * dbxread.c (dbx_end_psymtab): Update.
12368
12369 2019-01-15  Tom Tromey  <tom@tromey.com>
12370
12371         * symtab.c (lookup_objfile_from_block)
12372         (lookup_symbol_in_objfile_symtabs)
12373         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12374         (find_line_symtab, info_sources_command)
12375         (default_collect_symbol_completion_matches_break_on)
12376         (make_source_files_completion_list): Update.
12377         * symmisc.c (print_objfile_statistics, dump_objfile)
12378         (maintenance_print_symbols, maintenance_info_symtabs)
12379         (maintenance_check_symtabs, maintenance_info_line_tables):
12380         Update.
12381         * source.c (select_source_symtab)
12382         (forget_cached_source_info_for_objfile): Update.
12383         * objfiles.h (class objfile_compunits): Remove.
12384         (struct objfile) <compunits_range>: New typedef.
12385         (compunits): New method.
12386         * objfiles.c (objfile_relocate1): Update.
12387         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12388         * maint.c (count_symtabs_and_blocks): Update.
12389         * linespec.c (iterate_over_all_matching_symtabs): Update.
12390         * cp-support.c (add_symbol_overload_list_qualified): Update.
12391         * coffread.c (coff_symtab_read): Update.
12392         * ada-lang.c (add_nonlocal_symbols)
12393         (ada_collect_symbol_completion_matches)
12394         (ada_add_global_exceptions): Update.
12395
12396 2019-01-15  Tom Tromey  <tom@tromey.com>
12397
12398         * progspace.h (program_space) <objfiles_safe_range>: New
12399         typedef.
12400         <objfiles_safe>: New method.
12401         * objfiles.h (class all_objfiles_safe): Remove.
12402         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12403         * jit.c (jit_inferior_exit_hook): Update.
12404
12405 2019-01-17  Tom Tromey  <tom@tromey.com>
12406
12407         * progspace.h (program_space) <objfiles_range>: New typedef.
12408         <objfiles>: New method.
12409         <objfiles_head>: Rename from objfiles.
12410         (object_files): Update.
12411         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12412         * guile/scm-pretty-print.c
12413         (ppscm_find_pretty_printer_from_objfiles): Update.
12414         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12415         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12416         Update.
12417         * python/py-progspace.c (pspy_get_objfiles): Update.
12418         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12419         Update.
12420         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12421         (objfpy_lookup_objfile_by_build_id): Update.
12422         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12423         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12424         Update.
12425         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12426         (expand_symtab_containing_pc, lookup_objfile_from_block)
12427         (lookup_static_symbol, basic_lookup_transparent_type)
12428         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12429         (find_line_symtab, info_sources_command)
12430         (default_collect_symbol_completion_matches_break_on)
12431         (make_source_files_completion_list, find_main_name): Update.
12432         * symmisc.c (print_symbol_bcache_statistics)
12433         (print_objfile_statistics, maintenance_print_symbols)
12434         (maintenance_print_msymbols, maintenance_print_objfiles)
12435         (maintenance_info_symtabs, maintenance_check_symtabs)
12436         (maintenance_expand_symtabs, maintenance_info_line_tables):
12437         Update.
12438         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12439         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12440         (map_overlay_command, unmap_overlay_command)
12441         (simple_overlay_update, expand_symtabs_matching)
12442         (map_symbol_filenames): Update.
12443         * symfile-debug.c (set_debug_symfile): Update.
12444         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12445         Update.
12446         * source.c (select_source_symtab, forget_cached_source_info):
12447         Update.
12448         * solib.c (solib_read_symbols): Update.
12449         * solib-spu.c (append_ocl_sos): Update.
12450         * psymtab.c (maintenance_print_psymbols)
12451         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12452         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12453         * printcmd.c (info_symbol_command): Update.
12454         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12455         Update.
12456         * objfiles.h (class all_objfiles): Remove.
12457         * objfiles.c (have_partial_symbols, have_full_symbols)
12458         (have_minimal_symbols, qsort_cmp, update_section_map)
12459         (shared_objfile_contains_address_p)
12460         (default_iterate_over_objfiles_in_search_order): Update.
12461         * objc-lang.c (info_selectors_command, info_classes_command)
12462         (find_methods): Update.
12463         * minsyms.c (find_solib_trampoline_target): Update.
12464         * maint.c (maintenance_info_sections)
12465         (maintenance_translate_address, count_symtabs_and_blocks):
12466         Update.
12467         * main.c (captured_main_1): Update.
12468         * linux-thread-db.c (try_thread_db_load_from_pdir)
12469         (has_libpthread): Update.
12470         * linespec.c (iterate_over_all_matching_symtabs)
12471         (search_minsyms_for_name): Update.
12472         * jit.c (jit_find_objf_with_entry_addr): Update.
12473         * hppa-tdep.c (find_unwind_entry)
12474         (hppa_lookup_stub_minimal_symbol): Update.
12475         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12476         Update.
12477         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12478         (elf_gnu_ifunc_resolve_by_got): Update.
12479         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12480         * dwarf-index-write.c (save_gdb_index_command): Update.
12481         * cp-support.c (add_symbol_overload_list_qualified): Update.
12482         * breakpoint.c (create_overlay_event_breakpoint)
12483         (create_longjmp_master_breakpoint)
12484         (create_std_terminate_master_breakpoint)
12485         (create_exception_master_breakpoint): Update.
12486         * blockframe.c (find_pc_partial_function): Update.
12487         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12488         (ada_collect_symbol_completion_matches)
12489         (ada_add_global_exceptions): Update.
12490
12491 2019-01-17  Tom Tromey  <tom@tromey.com>
12492
12493         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12494         declare VEC.
12495         (solib_target_parse_libraries): Change return type.
12496         (library_list_start_segment, library_list_start_section)
12497         (library_list_end_library, library_list_start_library); Update.
12498         (solib_target_free_library_list): Remove.
12499         (solib_target_parse_libraries): Remove cleanup.  Change return
12500         type.
12501         (solib_target_current_sos): Update.
12502
12503 2019-01-17  Tom Tromey  <tromey@bapiya>
12504
12505         * valprint.c: Replace "the the" with "the".
12506         * symtab.c: Replace "the the" with "the".
12507         * solib.c: Replace "the the" with "the".
12508         * solib-dsbt.c: Replace "the the" with "the".
12509         * linespec.c: Replace "the the" with "the".
12510         * dwarf2loc.h: Replace "the the" with "the".
12511         * amd64-windows-tdep.c: Replace "the the" with "the".
12512         * aarch64-tdep.c: Replace "the the" with "the".
12513
12514 2019-01-16  Keith Seitz  <keiths@redhat.com>
12515
12516         PR gdb/23773
12517         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12518         <builder>: Rename to ..
12519         <m_builder>: ... this and make private.
12520         (dwarf2_cu::get_builder): New method.  Change all users of
12521         `builder' to use this method.
12522         (dwarf2_start_symtab): Move to ...
12523         (dwarf2_cu::start_symtab): ... here.  Update all callers
12524         (setup_type_unit_groups): Move to ...
12525         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12526         callers.
12527         (dwarf2_cu::reset_builder): New method.
12528         (process_full_compunit, process_full_type_unit): Use
12529         dwarf2_cu::reset_builder.
12530         (follow_die_offset): Record the ancestor CU if it is different
12531         from the followed DIE's CU.
12532         (follow_die_sig_1): Likewise.
12533
12534 2019-01-15  Tom Tromey  <tom@tromey.com>
12535
12536         * remote.c (class remote_state) <buf>: Now a char_vector.
12537         <buf_size>: Remove.
12538         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12539         parameter.
12540         (remote_target::getpkt_or_notif_sane_1)
12541         (remote_target::getpkt_sane)
12542         (remote_target::getpkt_or_notif_sane): Likewise.
12543         (class remote_target) <putpkt>: New overload.
12544         (remote_target::read_frame): Change type of "buf_p".  Remove
12545         sizeof_p parameter.
12546         (packet_ok): New overload.
12547         (packet_check_result): New overload.
12548         Update all uses.
12549
12550 2019-01-14  Tom Tromey  <tom@tromey.com>
12551
12552         * remote-notif.c (handle_notification, remote_notif_ack)
12553         (remote_notif_parse): Make "buf" const.
12554         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12555         const.
12556         (remote_notif_parse, remote_notif_ack, handle_notification):
12557         Likewise.
12558         * remote.c (remote_notif_stop_parse): Make "buf" const.
12559         (remote_target::remote_parse_stop_reply): Make "buf" const.
12560         (remote_notif_stop_ack): Make "buf" const.
12561
12562 2019-01-14  Tom Tromey  <tom@tromey.com>
12563
12564         * remote.c (remote_console_output): Make parameter const.
12565
12566 2019-01-14  Tom Tromey  <tom@tromey.com>
12567
12568         * target-debug.h (target_debug_print_signals): Constify.
12569         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12570         * procfs.c (procfs_target::pass_signals): Update.
12571         * linux-nat.c (linux_nat_target::pass_signals): Update.
12572         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12573         * target-delegates.c: Rebuild.
12574         * remote.c (remote_target::program_signals): Update.
12575         (remote_target::pass_signals): Update.
12576         * target.c (target_pass_signals): Constify argument.
12577         (target_program_signals): Likewise.
12578         * target.h (struct target_ops) <pass_signals, program_signals>:
12579         Constify argument.
12580         (target_pass_signals, target_program_signals): Constify argument.
12581
12582 2019-01-14  Tom Tromey  <tom@tromey.com>
12583
12584         PR tui/28819:
12585         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12586
12587 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12588
12589         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12590         field.
12591         * rs6000-tdep.c: Include reggroups.h.
12592         (IS_V_ALIAS_PSEUDOREG): Define.
12593         (rs6000_register_name): Return names for the "vX" aliases.
12594         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12595         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12596         aliases.  Call default_register_reggroup_p for all other
12597         pseudo-registers.
12598         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12599         New functions.
12600         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12601         Handle "vX" aliases.
12602         (v_alias_pseudo_register_collect): New function.
12603         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12604         (rs6000_gdbarch_init): Initialize "vX" aliases as
12605         pseudo-registers.  Restore registration of
12606         rs6000_pseudo_register_reggroup_p with
12607         set_tdesc_pseudo_register_reggroup_p.
12608
12609 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12610
12611         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12612         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12613         set_gdbarch_num_pseudo_regs.
12614
12615 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12616
12617         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12618         Remove arg prefixname, add do_set and do_show.
12619         Add member functions set_list and show_list.
12620         * cli/cli-style.c (class cli_style_option): Update accordingly.
12621         (style_set_list): Move to file scope.
12622         (style_show_list): Likewise.
12623         (set_style): Call help_list.
12624         (show_style): Call cmd_show_list.
12625         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12626         Update to use the new macro.
12627
12628 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12629
12630         * ada-lang.c (_initialize_ada_language): Expand the help text
12631         for the "catch exception" command.
12632
12633 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12634
12635         * symtab.c (matching_obj_sections): Initialize obj,
12636         declare it closer to its usage.
12637
12638 2019-01-10  Tom Tromey  <tom@tromey.com>
12639
12640         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12641         (basic_inf_threads_range): Remove.
12642         (inf_threads_range, inf_non_exited_threads_range)
12643         (safe_inf_threads_range): Use next_adapter.
12644
12645 2019-01-10  Keith Seitz  <keiths@redhat.com>
12646
12647         PR gdb/23712
12648         PR symtab/23010
12649         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12650         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12651
12652 2019-01-10  Keith Seitz  <keiths@redhat.com>
12653
12654         PR gdb/23712
12655         PR symtab/23010
12656         * dictionary.c (pending_to_vector): Remove.
12657         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12658         Remove _1 suffix, replacing functions of the same name.  Update
12659         all callers.
12660         (dict_create_hashed, dict_create_hashed_expandable)
12661         (dict_create_linear, dict_create_linear_expandable, dict_free)
12662         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12663         Make functions static.
12664
12665 2019-01-10  Keith Seitz  <keiths@redhat.com>
12666
12667         PR gdb/23712
12668         PR symtab/23010
12669         * dictionary.h (struct dictionary): Replace declaration with
12670         multidictionary.
12671         (dict_create_hashed, dict_create_hashed_expandable)
12672         (dict_create_linear, dict_create_linear_expandable)
12673         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12674         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12675         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12676         taking multidictionary argument.
12677         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12678         * block.h (struct block) <dict>: Change to multidictionary
12679         and rename `multidict'.
12680         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12681         symmisc.c: Update all dictionary references to multidictionary.
12682
12683 2019-01-10  Keith Seitz  <keiths@redhat.com>
12684
12685         PR gdb/23712
12686         PR symtab/23010
12687         * dictionary.c: Include unordered_map.
12688         (pending_to_vector): New function.
12689         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12690         Rewrite the non-"_1" functions to take vector instead
12691         of linked list.
12692         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12693         "new" _1 versions of the same name.
12694         (multidictionary): Define.
12695         (std::hash<enum language): New definition.
12696         (collate_pending_symbols_by_language, mdict_create_hashed)
12697         (mdict_create_hashed_expandable, mdict_create_linear)
12698         (mdict_create_linear_expandable, mdict_free)
12699         (find_language_dictionary, create_new_language_dictionary)
12700         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12701         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12702         (mdict_size, mdict_empty): New functions.
12703         * dictionary.h (mdict_iterator): Define.
12704
12705 2019-01-10  Pedro Alves  <palves@redhat.com>
12706
12707         * breakpoint.c (read_uploaded_action)
12708         (create_tracepoint_from_upload): Adjust to use
12709         gdb::unique_xmalloc_ptr.
12710         * ctf.c (ctf_write_uploaded_tp):
12711         (SET_ARRAY_FIELD): Use emplace_back.
12712         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12713         * tracefile-tfile.c (tfile_write_uploaded_tp):
12714         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12715         gdb::unique_xmalloc_ptr.
12716         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12717         at_string, cond_string, cmd_strings>: Replace char pointers
12718         with gdb::unique_xmalloc_ptr.
12719
12720 2019-01-10  Pedro Alves  <palves@redhat.com>
12721
12722         * solib-target.c (library_list_start_library): Don't xstrdup name.
12723
12724 2019-01-10  Pedro Alves  <palves@redhat.com>
12725
12726         * mdebugread.c (parse_partial_symbols): Use
12727         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12728
12729 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12730
12731         * linux-fork.c (scoped_switch_fork_info)
12732         <~scoped_switch_fork_info>: Fix incorrect variable name.
12733
12734 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12735
12736         * linux-fork.c (scoped_switch_fork_info)
12737         <scoped_switch_fork_info>: Make explicit.
12738         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12739
12740 2019-01-10  Tom Tromey  <tom@tromey.com>
12741
12742         * objfiles.h (objfile::reset_psymtabs): Update.
12743         * objfiles.c (objfile::objfile): Update.
12744         * psymtab.h (psymtab_storage::obstack): Update.
12745         (psymtab_storage::m_obstack): Use gdb::optional.
12746         (class psymtab_storage): Update comment.  Remove objfile
12747         parameter.
12748         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12749
12750 2019-01-10  Tom Tromey  <tom@tromey.com>
12751
12752         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12753         <free_psymtabs>: Now private.
12754         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12755         (allocate_psymtab): Use new method.
12756
12757 2019-01-10  Tom Tromey  <tom@tromey.com>
12758
12759         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12760         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12761         * mdebugread.c (parse_partial_symbols): Use
12762         allocate_dependencies.
12763         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12764         allocate_dependencies.
12765         (process_psymtab_comp_unit_reader)
12766         (build_type_psymtab_dependencies): Likewise.
12767         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12768
12769 2019-01-10  Tom Tromey  <tom@tromey.com>
12770
12771         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12772         PSYMBOL_SET_LANGUAGE.
12773         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12774
12775 2019-01-10  Tom Tromey  <tom@tromey.com>
12776
12777         * psymtab.h (psymtab_storage::obstack): New method.
12778         <m_obstack>: Rename from obstack; now private.
12779         * psymtab.c (psymtab_storage): Update.
12780         * dwarf2read.c (create_addrmap_from_index)
12781         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12782         Update.
12783
12784 2019-01-10  Tom Tromey  <tom@tromey.com>
12785
12786         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12787         * objfiles.h (objfile::reset_psymtabs): New method.
12788
12789 2019-01-10  Tom Tromey  <tom@tromey.com>
12790
12791         * symmisc.c (print_symbol_bcache_statistics): Update.
12792         (print_objfile_statistics): Update.
12793         * symfile.c (reread_symbols): Update.
12794         * psymtab.h (class psymtab_storage): New.
12795         * psymtab.c (psymtab_storage): New constructor.
12796         (~psymtab_storage): New destructor.
12797         (require_partial_symbols): Update.
12798         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12799         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12800         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12801         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12802         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12803         (start_psymtab_common, end_psymtab_common)
12804         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12805         (allocate_psymtab): Update.
12806         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12807         Update.
12808         (dump_psymtab_addrmap, maintenance_print_psymbols)
12809         (maintenance_check_psymtabs): Update.
12810         (class objfile_psymtabs): Move to objfiles.h.
12811         * psympriv.h (discard_psymtab): Now inline.
12812         (psymtab_discarder::psymtab_discarder): Update.
12813         (psymtab_discarder::~psymtab_discarder): Update.
12814         (ALL_OBJFILE_PSYMTABS): Rewrite.
12815         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12816         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12817         Remove fields.
12818         <partial_symtabs>: New field.
12819         (class objfile_psymtabs): Move from psymtab.h.  Update.
12820         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12821         psymbol_cache.
12822         (objfile::~objfile): Don't destroy psymbol_cache.
12823         * mdebugread.c (parse_partial_symbols): Update.
12824         * dwarf2read.c (create_addrmap_from_index)
12825         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12826         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12827         (add_partial_subprogram, dwarf2_ranges_read): Update.
12828         * dwarf-index-write.c (write_address_map)
12829         (write_one_signatured_type, recursively_write_psymbols)
12830         (class debug_names, class debug_names, write_psymtabs_to_index):
12831         Update.
12832
12833 2019-01-10  Tom Tromey  <tom@tromey.com>
12834
12835         * symtab.h (SYMBOL_SET_NAMES): Update.
12836         (symbol_set_names): Update.
12837         (MSYMBOL_SET_NAMES): Update.
12838         * symtab.c (symbol_set_names): Change argument to be an
12839         objfile_per_bfd_storage.
12840         * psymtab.c (add_psymbol_to_bcache): Update.
12841         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12842
12843 2019-01-10  Tom Tromey  <tom@tromey.com>
12844
12845         * symtab.c (create_demangled_names_hash): Change argument to be an
12846         objfile_per_bfd_storage.
12847         (symbol_set_names): Update.
12848
12849 2019-01-10  Tom Tromey  <tom@tromey.com>
12850
12851         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12852         init_psymbol_list.
12853         * psymtab.c (init_psymbol_list): Do nothing if already called.
12854         * psympriv.h (init_psymbol_list): Add comment.
12855         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12856         init_psymbol_list.
12857         * dbxread.c (dbx_symfile_read): Unconditionally call
12858         init_psymbol_list.
12859
12860 2019-01-10  Tom Tromey  <tom@tromey.com>
12861
12862         * xcoffread.c (scan_xcoff_symtab): Update.
12863         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12864         "where".
12865         * mdebugread.c (parse_partial_symbols)
12866         (handle_psymbol_enumerators): Update.
12867         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12868         * dbxread.c (read_dbx_symtab): Update.
12869         * psympriv.h (psymbol_placement): New enum.
12870         (add_psymbol_to_list): Update.
12871
12872 2019-01-10  Tom Tromey  <tom@tromey.com>
12873
12874         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12875         static_psymbols parameters.
12876         (scan_xcoff_symtab): Update.
12877         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12878         static_psymbols parameters.
12879         * psympriv.h (start_psymtab_common): Update.
12880         * mdebugread.c (parse_partial_symbols): Update.
12881         * dwarf2read.c (create_partial_symtab): Update.
12882         * dbxread.c (read_dbx_symtab): Update.
12883         (start_psymtab): Remove global_psymbols and static_psymbols
12884         parameters.
12885
12886 2019-01-10  Tom Tromey  <tom@tromey.com>
12887
12888         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12889         * psymtab.c (allocate_psymtab): Add comment.
12890         * psympriv.h (allocate_psymtab): Add comment.
12891         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12892         initializations.
12893         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12894
12895 2019-01-10  Tom Tromey  <tom@tromey.com>
12896
12897         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12898         Don't declare.
12899         * mipsread.c: Include mdebugread.h.
12900         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12901         Declare.
12902         * elfread.c: Include mdebugread.h.
12903
12904 2019-01-09  Tom Tromey  <tom@tromey.com>
12905
12906         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12907         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12908         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12909         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12910         (psym_lookup_symbol, psym_find_last_source_symtab)
12911         (psym_forget_cached_source_info, psym_print_stats)
12912         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12913         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12914         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12915         (psym_find_compunit_symtab_by_address)
12916         (maintenance_print_psymbols, maintenance_info_psymtabs)
12917         (maintenance_check_psymtabs): Use ranged for.
12918         * psymtab.h (class objfile_psymtabs): New.
12919         (require_partial_symbols): Return objfile_psymtabs.
12920         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12921
12922 2019-01-09  Tom Tromey  <tom@tromey.com>
12923
12924         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12925         (find_pc_mapped_section, list_overlays_command)
12926         (map_overlay_command, unmap_overlay_command)
12927         (simple_overlay_update): Use all_objfiles.
12928         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12929         * printcmd.c (info_symbol_command): Use all_objfiles.
12930         * objfiles.h (ALL_OBJSECTIONS): Remove.
12931         * maint.c (maintenance_translate_address): Use all_objfiles.
12932         * gcore.c (gcore_create_callback): Use all_objfiles.
12933         (objfile_find_memory_regions): Likewise.
12934
12935 2019-01-09  Tom Tromey  <tom@tromey.com>
12936
12937         * symtab.c (find_line_symtab, info_sources_command)
12938         (make_source_files_completion_list): Use objfile_compunits.
12939         * source.c (select_source_symtab): Use objfile_compunits.
12940         * objfiles.h (struct objfile): Update comment.
12941         (ALL_OBJFILES): Remove.
12942         (ALL_FILETABS): Remove.
12943         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12944         objfile_compunits.
12945
12946 2019-01-09  Tom Tromey  <tom@tromey.com>
12947
12948         * symmisc.c (print_objfile_statistics, dump_objfile)
12949         (maintenance_print_symbols): Use compunit_filetabs.
12950         * source.c (forget_cached_source_info_for_objfile): Use
12951         compunit_filetabs.
12952         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12953         (ALL_FILETABS): Use compunit_filetabs.
12954         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12955         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12956
12957 2019-01-09  Tom Tromey  <tom@tromey.com>
12958
12959         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12960         (compunit_filetabs): New.
12961         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12962         compunit_filetabs.
12963         (info_sources_command, make_source_files_completion_list): Remove
12964         declaration.
12965         * symmisc.c (print_objfile_statistics, dump_objfile)
12966         (maintenance_print_symbols): Remove declaration.
12967         (maintenance_info_symtabs): Use compunit_filetabs.
12968         (maintenance_info_line_tables): Likewise.
12969         * source.c (select_source_symtab): Change local variable name.
12970         (forget_cached_source_info_for_objfile): Remove declaration.
12971         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12972         * objfiles.c (objfile_relocate1): Remove declaration.
12973         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12974         declaration.
12975         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12976         * coffread.c (coff_symtab_read): Remove declaration.
12977         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12978         compunit_filetabs.
12979
12980 2019-01-09  Tom Tromey  <tom@tromey.com>
12981
12982         * symtab.c (lookup_objfile_from_block)
12983         (find_pc_sect_compunit_symtab, search_symbols)
12984         (default_collect_symbol_completion_matches_break_on): Use
12985         objfile_compunits.
12986         * objfiles.h (ALL_COMPUNITS): Remove.
12987         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12988         * cp-support.c (add_symbol_overload_list_qualified): Use
12989         objfile_compunits.
12990         * ada-lang.c (ada_collect_symbol_completion_matches)
12991         (ada_add_global_exceptions): Use objfile_compunits.
12992
12993 2019-01-09  Tom Tromey  <tom@tromey.com>
12994
12995         * source.c (select_source_symtab)
12996         (forget_cached_source_info_for_objfile): Remove declaration.
12997         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12998         declaration.
12999         * maint.c (count_symtabs_and_blocks): Remove declaration.
13000         * cp-support.c (add_symbol_overload_list_qualified): Remove
13001         declaration.
13002         * coffread.c (coff_symtab_read): Remove declaration.
13003         * symtab.c (lookup_symbol_in_objfile_symtabs)
13004         (basic_lookup_transparent_type_1): Use objfile_compunits.
13005         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13006         (info_sources_command, search_symbols)
13007         (default_collect_symbol_completion_matches_break_on)
13008         (make_source_files_completion_list): Remove declaration.
13009         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13010         (ada_collect_symbol_completion_matches)
13011         (ada_add_global_exceptions): Remove declaration.
13012         * linespec.c (iterate_over_all_matching_symtabs): Use
13013         objfile_compunits.
13014         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13015         (class objfile_compunits): New.
13016         (ALL_COMPUNITS): Use objfile_compunits.
13017         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13018         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13019         objfile_compunits.
13020         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13021
13022 2019-01-09  Tom Tromey  <tom@tromey.com>
13023
13024         * symtab.c (search_symbols)
13025         (default_collect_symbol_completion_matches_break_on): Use
13026         objfile_msymbols.
13027         * ada-lang.c (ada_lookup_simple_minsym)
13028         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13029         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13030         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13031         objfile_msymbols.
13032         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13033         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13034         * objc-lang.c (find_methods): Use objfile_msymbols.
13035         (info_selectors_command, info_classes_command): Likewise.
13036         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13037         * objfiles.h (class objfile_msymbols): New.
13038         (ALL_OBJFILE_MSYMBOLS): Remove.
13039         (ALL_MSYMBOLS): Remove.
13040
13041 2019-01-09  Tom Tromey  <tom@tromey.com>
13042
13043         * common/next-iterator.h (next_adapter): Add Iterator template
13044         parameter.
13045         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13046         (class all_objfiles_safe): New.
13047         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13048         * objfiles.c (put_objfile_before): Update comment.
13049         (add_separate_debug_objfile): Likewise.
13050         (free_all_objfiles): Use all_objfiles_safe.
13051         (objfile_purge_solibs): Likewise.
13052
13053 2019-01-09  Tom Tromey  <tom@tromey.com>
13054
13055         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13056         (expand_symtab_containing_pc, lookup_static_symbol)
13057         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13058         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13059         all_objfiles.
13060         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13061         * breakpoint.c (create_overlay_event_breakpoint)
13062         (create_longjmp_master_breakpoint)
13063         (create_std_terminate_master_breakpoint)
13064         (create_exception_master_breakpoint): Use all_objfiles.
13065         * linux-thread-db.c (try_thread_db_load_from_pdir)
13066         (has_libpthread): Use all_objfiles.
13067         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13068         * linespec.c (iterate_over_all_matching_symtabs)
13069         (search_minsyms_for_name): Use all_objfiles.
13070         * maint.c (maintenance_info_sections): Use all_objfiles.
13071         * main.c (captured_main_1): Use all_objfiles.
13072         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13073         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13074         * guile/scm-pretty-print.c
13075         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13076         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13077         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13078         (maintenance_print_msymbols): Use all_objfiles.
13079         * source.c (select_source_symtab): Use all_objfiles.
13080         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13081         * symfile.c (remove_symbol_file_command)
13082         (expand_symtabs_matching, map_symbol_filenames): Use
13083         all_objfiles.
13084         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13085         all_objfiles.
13086         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13087         * objc-lang.c (find_methods): Use all_objfiles.
13088         * objfiles.c (have_partial_symbols, have_full_symbols)
13089         (have_minimal_symbols, qsort_cmp)
13090         (default_iterate_over_objfiles_in_search_order): Use
13091         all_objfiles.
13092         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13093         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13094         (maintenance_check_psymtabs): Use all_objfiles.
13095         (ALL_PSYMTABS): Remove.
13096         * compile/compile-object-run.c (do_module_cleanup): Use
13097         all_objfiles.
13098         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13099         * cp-support.c (add_symbol_overload_list_qualified): Use
13100         all_objfiles.
13101         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13102         Use all_objfiles.
13103         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13104         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13105         all_objfiles.
13106         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13107         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13108         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13109         Uses all_objfiles.
13110         * solib.c (solib_read_symbols): Use all_objfiles
13111
13112 2019-01-09  Tom Tromey  <tom@tromey.com>
13113
13114         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13115         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13116         all_objfiles.
13117         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13118         * symmisc.c (print_symbol_bcache_statistics)
13119         (print_objfile_statistics, maintenance_print_objfiles)
13120         (maintenance_info_symtabs, maintenance_check_symtabs)
13121         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13122         all_objfiles.
13123         * source.c (forget_cached_source_info): Use all_objfiles.
13124         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13125         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13126         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13127         * objfiles.c (update_section_map): Use all_objfiles.
13128         (shared_objfile_contains_address_p): Likewise.
13129         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13130         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13131
13132 2019-01-09  Tom Tromey  <tom@tromey.com>
13133
13134         * common/next-iterator.h: New file.
13135         * objfiles.h (class all_objfiles): New.
13136         (struct objfile_iterator): New.
13137
13138 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13139
13140         * NEWS: Move the description of the changed "frame", "select-frame",
13141          and "info frame" commands to the Changed commands section.
13142
13143 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13144
13145         * gdbtypes.c (check_stub_method_group): Remove handling of old
13146         mangling schemes.
13147         * linespec.c (find_methods): Likewise.
13148         * stabsread.c (read_member_functions): Likewise.
13149         * valops.c (search_struct_method): Likewise.
13150         (value_struct_elt_for_reference): Likewise.
13151         * NEWS: Mention this change.
13152
13153 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13154
13155         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13156         print_source_lines.
13157         * source.c (print_source_lines_base): Update line number check.
13158         (print_source_lines): New function.
13159         (source_lines_range::source_lines_range): New function.
13160         * source.h (class source_lines_range): New class.
13161         (print_source_lines): New declaration.
13162
13163 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13164
13165         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13166
13167 2019-01-08  Tom Tromey  <tom@tromey.com>
13168             Simon Marchi  <simon.marchi@ericsson.com>
13169
13170         PR gdb/24060
13171         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13172         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13173         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13174         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13175         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13176         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13177
13178 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13179
13180         * source.c (select_source_symtab): Move header comment to
13181         declaration in source.h.
13182         (forget_cached_source_info_for_objfile): Likewise.
13183         (forget_cached_source_info): Likewise.
13184         (identify_source_line): Likewise.
13185         * source.h (identify_source_line): Move declaration from symtab.h
13186         and add comment from source.c
13187         (print_source_lines): Likewise.
13188         (forget_cached_source_info_for_objfile): Likewise.
13189         (forget_cached_source_info): Likewise.
13190         (select_source_symtab): Likewise.
13191         (enum print_source_lines_flag): Move definition from symtab.h.
13192         * symtab.h (identify_source_line): Move declaration to source.h.
13193         (print_source_lines): Likewise.
13194         (forget_cached_source_info_for_objfile): Likewise.
13195         (forget_cached_source_info): Likewise.
13196         (select_source_symtab): Likewise.
13197         (enum print_source_lines_flag): Move definition to source.h.
13198         * tui/tui-hooks.c: Add 'source.h' include.
13199
13200 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13201
13202         * source.c (print_source_lines_base): Handle requests to print
13203         reverse line number sequences, and guard against empty lines
13204         string.
13205
13206 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13207
13208         * source.c (print_source_lines_base): Fix skip of '\r' if next
13209         character is '\n'.
13210
13211 2019-01-06  Tom Tromey  <tom@tromey.com>
13212
13213         * c-exp.y (struct c_parse_state) <macro_original_text,
13214         expansion_obstack>: New member.
13215         (macro_original_text, expansion_obstack): Remove globals.
13216         (scan_macro_expansion, scanning_macro_expansion)
13217         (finished_macro_expansion): Update.
13218         (scan_macro_cleanup): Remove.
13219         (yylex, c_parse): Update.
13220
13221 2019-01-06  Tom Tromey  <tom@tromey.com>
13222
13223         * c-exp.y (struct c_parse_state) <strings>: New member.
13224         (operator_stoken): Update.
13225
13226 2019-01-06  Tom Tromey  <tom@tromey.com>
13227
13228         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13229         (union type_stack_elt) <typelist_val>: Now a pointer to
13230         std::vector.
13231         (type_stack_cleanup): Don't declare.
13232         (push_typelist): Update.
13233         * parse.c (pop_typelist): Return a std::vector.
13234         (push_typelist): Take a std::vector.
13235         (follow_types): Update.  Do not free args.
13236         (type_stack_cleanup): Remove.
13237         * c-exp.y (struct c_parse_state): New.
13238         (cpstate): New global.
13239         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13240         (nonempty_typelist): Update.
13241         (func_mod): Create a new vector.
13242         (c_parse): Create a c_parse_state.
13243         (check_parameter_typelist): Do not delete params.
13244         (function_method): Update.  Do not delete type_list.
13245
13246 2019-01-06  Tom Tromey  <tom@tromey.com>
13247
13248         PR gdb/28155:
13249         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13250         check_typedef.
13251         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13252         (print_return_value): Likewise.
13253
13254 2019-01-05  Tom Tromey  <tom@tromey.com>
13255
13256         * contrib/cleanup_check.py: Remove.
13257         * contrib/gcc-with-excheck: Remove.
13258         * contrib/exsummary.py: Remove.
13259         * contrib/excheck.py: Remove.
13260
13261 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13262
13263         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13264         NULL. Initialize tpprev to NULL instead of assigning it
13265         to NULL on the next statement.
13266         * windows-nat.c (windows_delete_thread): Remove check for
13267         main_thread_id before printing thread exit notifications.
13268         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13269         Remove thread ID check against main_thread_id.
13270         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13271         windows_delete_thread.
13272         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13273
13274 2019-01-04  Tom Tromey  <tom@tromey.com>
13275
13276         * compile/compile.c (_initialize_compile): Use upper case for
13277         metasyntactic variables.
13278         * symmisc.c (_initialize_symmisc): Use upper case for
13279         metasyntactic variables.
13280         * psymtab.c (_initialize_psymtab): Use upper case for
13281         metasyntactic variables.
13282         * demangle.c (demangle_command): Use upper case for metasyntactic
13283         variables.
13284         (_initialize_demangler): Likewise.
13285         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13286         variables.
13287
13288 2019-01-03  Tom Tromey  <tom@tromey.com>
13289
13290         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13291
13292 2019-01-03  Tom Tromey  <tom@tromey.com>
13293
13294         * python/py-symtab.c (salpy_str): Update.
13295         (struct salpy_sal_object) <symtab>: Now a PyObject.
13296         (salpy_dealloc): Update.
13297         (del_objfile_sal): Use gdbpy_ref.
13298
13299 2019-01-03  Tom Tromey  <tom@tromey.com>
13300
13301         * python/py-type.c (convert_field): Use new_reference.  Return
13302         gdbpy_ref.
13303         (make_fielditem): Return gdbpy_ref.
13304         (typy_fields): Update.
13305         (typy_getitem): Update.
13306         (field_name): Return gdbpy_ref.  Use new_reference.
13307         (typy_iterator_iternext): Update.
13308
13309 2019-01-03  Tom Tromey  <tom@tromey.com>
13310
13311         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13312
13313 2019-01-03  Tom Tromey  <tom@tromey.com>
13314
13315         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13316         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13317         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13318         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13319         (pspy_set_type_printers): Likewise.
13320         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13321         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13322         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13323         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13324         (objfpy_set_type_printers): Likewise.
13325
13326 2019-01-03  Tom Tromey  <tom@tromey.com>
13327
13328         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13329         (gdbpy_print_stack): Use gdbpy_err_fetch.
13330         * python/python-internal.h (class gdbpy_err_fetch): New class.
13331         (class gdbpy_enter) <m_error_type, m_error_value,
13332         m_error_traceback>: Remove.
13333         <m_error>: New member.
13334         (gdbpy_exception_to_string): Don't declare.
13335         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13336         * python/py-value.c (convert_value_from_python): Use
13337         gdbpy_err_fetch.
13338         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13339         gdbpy_exception_to_string.
13340         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13341         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13342         gdbpy_err_fetch.
13343
13344 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13345
13346         * linux-nat.c (delete_lwp_cleanup): Delete.
13347         (struct lwp_deleter): New struct.
13348         (lwp_info_up): New typedef.
13349         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13350         lwp_info_up.
13351
13352 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13353
13354         * linux-fork.c (class scoped_switch_fork_info): New class.
13355         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13356
13357 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13358
13359         * valops.c (find_overload_match): Remove use of null_cleanup, and
13360         calls to do_cleanups.
13361
13362 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13363
13364         * compile/compile-cplus-types.c
13365         (compile_cplus_instance::decl_name): Handle changes to
13366         cp_func_name.
13367         * cp-support.c (cp_func_name): Update header comment, update
13368         return type.
13369         * cp-support.h (cp_func_name): Update return type in declaration.
13370         * valops.c (find_overload_match): Move temp_func local to top
13371         level of function and change its type.  Use temp_func to hold and
13372         delete temporary string obtained from cp_func_name.
13373
13374 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13375
13376         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13377         gdb::char_vector, remove cleanup, and update uses of `msg`.
13378
13379 2019-01-03  Jim Wilson  <jimw@sifive.com>
13380
13381         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13382
13383 2019-01-02  Tom Tromey  <tom@tromey.com>
13384
13385         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13386         (tdesc_parse_xml): Remove cleanups.
13387         * target-descriptions.h (make_cleanup_free_target_description):
13388         Don't declare.
13389         (target_desc_deleter): New struct.
13390         (target_desc_up): New typedef.
13391         * target-descriptions.c (target_desc_deleter::operator()): Rename
13392         from free_target_description.
13393         (make_cleanup_free_target_description): Remove.
13394
13395 2019-01-02  Tom Tromey  <tom@tromey.com>
13396
13397         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13398         constructor, destructor.
13399         (linespec_parser): Remove typedef.
13400         (~linespec_parser): Rename from linespec_parser_delete.
13401         (linespec_lex_to_end, linespec_complete_label)
13402         (linespec_complete): Update.
13403         (decode_line_full): Remove cleanups.
13404         (decode_line_1): Update.
13405
13406 2019-01-02  Tom Tromey  <tom@tromey.com>
13407
13408         * python/python-internal.h (inferior_to_inferior_object): Change
13409         return type.
13410         * python/py-exitedevent.c (create_exited_event_object): Update.
13411         * python/py-inferior.c (inferior_to_inferior_object): Return
13412         gdbpy_ref.
13413         (python_new_inferior, python_inferior_deleted)
13414         (thread_to_thread_object, delete_thread_object)
13415         (build_inferior_list, gdbpy_selected_inferior): Update.
13416         * python/py-infthread.c (create_thread_object): Update.  Also fail
13417         if inferior_to_inferior_object fails.
13418
13419 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13420
13421         * inferior.h (class inferior) <displaced_step_state>: New field.
13422         * infrun.h (struct displaced_step_state): Move here from
13423         infrun.c.  Initialize fields, add constructor.
13424         <inf>: Remove field.
13425         <reset>: New method.
13426         * infrun.c (struct displaced_step_inferior_state): Move to
13427         infrun.h.
13428         (displaced_step_inferior_states): Remove.
13429         (get_displaced_stepping_state): Adust.
13430         (displaced_step_in_progress_any_inferior): Adjust.
13431         (displaced_step_in_progress_thread): Adjust.
13432         (displaced_step_in_progress): Adjust.
13433         (add_displaced_stepping_state): Remove.
13434         (get_displaced_step_closure_by_addr): Adjust.
13435         (remove_displaced_stepping_state): Remove.
13436         (infrun_inferior_exit): Call displaced_step_state.reset.
13437         (use_displaced_stepping): Don't check for NULL.
13438         (displaced_step_prepare_throw): Call
13439         get_displaced_stepping_state.
13440         (displaced_step_fixup): Don't check for NULL.
13441         (prepare_for_detach): Don't check for NULL.
13442
13443 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13444
13445         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13446          in case of call that did not complete.
13447
13448 2019-01-02  Andrey Utkin  <autkin@undo.io>
13449
13450         * symfile.c (find_separate_debug_file): Fix search of debug files for
13451         remote debuggee.
13452
13453 2019-01-02  Tom Tromey  <tom@tromey.com>
13454
13455         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13456         indentation.
13457         * python/py-frame.c (frapy_older): Remove cast.
13458         (frapy_newer): Likewise.
13459         * python/py-breakpoint.c (local_setattro): Remove cast.
13460         * python/py-arch.c (archpy_name): Remove local variable.
13461         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13462
13463 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13464
13465         * unittests/basic_string_view/element_access/char/empty.cc:
13466         Fix year range in copyright header.
13467
13468 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13469
13470         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13471         Delete.
13472         <operator==>: Update with for removed field.
13473         <hash>: Likewise.
13474         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13475         <isa_features>: ...this.
13476         <abi_features>: New field.
13477         (riscv_isa_flen): Update comment.
13478         (riscv_abi_xlen): New declaration.
13479         (riscv_abi_flen): New declaration.
13480         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13481         isa_features.
13482         (riscv_abi_xlen): New function.
13483         (riscv_isa_flen): Update to get answer from isa_features.
13484         (riscv_abi_flen): New function.
13485         (riscv_has_fp_abi): Update to get answer from abi_features.
13486         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13487         xlen and flen.
13488         (riscv_call_info) <xlen, flen>: Update comment.
13489         (riscv_call_arg_struct): Remove invalid assertions
13490         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13491         is removed.
13492         (riscv_gdbarch_init): Gather isa features and abi features
13493         separately, ensure both match on the gdbarch when reusing an old
13494         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13495         a target with 64-bit float hardware.
13496
13497 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13498
13499         * source.c (search_command_helper): Stop reverse search
13500         when line 1 has been searched.
13501
13502 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13503
13504         * record-full.c (record_full_base_target::close): Rewrite
13505         record_full_core_buf_list free logic.
13506
13507 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13508
13509         * break-catch-syscall.c (print_one_catch_syscall): xfree
13510         the last text.
13511
13512 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13513
13514         * top.c (print_gdb_version): Update Copyright year in version
13515         message.
13516
13517 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13518
13519         Update copyright year range in all GDB files.
13520
13521 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13522
13523         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13524
13525 For older changes see ChangeLog-2018.
13526 \f
13527 Local Variables:
13528 mode: change-log
13529 left-margin: 8
13530 fill-column: 74
13531 version-control: never
13532 coding: utf-8
13533 End:
13534