gdb/ChangeLog

   1 2011-01-13  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * ada-valprint.c (ada_emit_char): Remove strange code.
   4         Check that c is <= UCHAR_MAX before passing it to isascii.
   5         (char_at): Do not assume that TYPE_LEN is either 1 or 2.
   6
   7 2011-01-13  Joel Brobecker  <brobecker@adacore.com>
   8
   9         * top.c (input_from_terminal_p): Restrict the use of interactive_mode
  10         to the case where instream is stdin.
  11
  12 2011-01-13  Joel Brobecker  <brobecker@adacore.com>
  13
  14         * ia64-tdep.h (struct regcache): Forward declare.
  15         (struct ia64_infcall_ops): New struct type.
  16         (struct gdbarch_tdep): New fields "find_global_pointer_from_solib"
  17         and "infcall_ops".
  18         * ia64-tdep.c (ia64_find_global_pointer_from_dynamic_section):
  19         Renames ia64_find_global_pointer.
  20         (ia64_find_global_pointer, ia64_allocate_new_rse_frame)
  21         (ia64_store_argument_in_slot, ia64_set_function_addr: New function.
  22         (ia64_push_dummy_call): Adjust to use the new tdep ia64_infocall_ops
  23         methods.
  24         (ia64_infcall_ops): New static global constant.
  25         (ia64_gdbarch_init): Set tdep->infcall_ops.
  26         * ia64-hpux-nat.c (ia64_hpux_xfer_solib_got): New function.
  27         (ia64_hpux_xfer_partial): Add TARGET_OBJECT_HPUX_SOLIB_GOT handing.
  28         * ia64-hpux-tdep.c: Include "regcache.h", "gdbcore.h" and "inferior.h".
  29         (ia64_hpux_dummy_code): New static global constant.
  30         (ia64_hpux_push_dummy_code, ia64_hpux_allocate_new_rse_frame)
  31         (ia64_hpux_store_argument_in_slot, ia64_hpux_set_function_addr)
  32         (ia64_hpux_dummy_id, ia64_hpux_find_global_pointer_from_solib):
  33         New function.
  34         (ia64_hpux_infcall_ops): New static global constant.
  35         (ia64_hpux_init_abi): Install gdbarch and tdep methods needed
  36         for inferior function calls to work properly on ia64-hpux.
  37
  38 2011-01-13  Joel Brobecker  <brobecker@adacore.com>
  39
  40         * target.h (enum target_object): Add TARGET_OBJECT_HPUX_UREGS.
  41         * ia64-tdep.h (struct frame_info): forward declaration.
  42         (struct gdbarch_tdep): Add field size_of_register_frame.
  43         * ia64-tdep.c (ia64_access_reg): Use tdep->size_of_register_frame
  44         to determine the size of the register frame.
  45         (ia64_size_of_register_frame): New function.
  46         (ia64_gdbarch_init): Set tdep->size_of_register_frame.
  47         * ia64-hpux-tdep.c: Include "target.h" and "frame.h".
  48         (IA64_HPUX_UREG_REASON): New macro.
  49         (ia64_hpux_stopped_in_syscall, ia64_hpux_size_of_register_frame):
  50         New functions.
  51         (ia64_hpux_init_abi): Set tdep->size_of_register_frame.
  52         * ia64-hpux-nat.c (ia64_hpux_xfer_uregs): New function.
  53         (ia64_hpux_xfer_partial): Add handling of TARGET_OBJECT_HPUX_UREGS
  54         objects.
  55
  56 2011-01-13  Joel Brobecker  <brobecker@adacore.com>
  57
  58         Add support for ia64-hpux.
  59         * config/ia64/hpux.mh, ia64-hpux-nat.c, ia64-hpux-tdep.c,
  60         ia64-hpux-tdep.h, solib-ia64-hpux.c, solib-ia64-hpux.h: New files.
  61
  62         * configure.host: Add handling for ia64-hpux hosts.  Add associated
  63         floatformats.
  64         * configure.tgt: Add handling for ia64-hpux targets.
  65         * Makefile.in (ALL_64_TARGET_OBS): Add ia64-hpux-tdep.o.
  66         (HFILES_NO_SRCDIR): Add ia64-hpux-tdep.h.
  67         (ALLDEPFILES): Add ia64-hpux-nat.c ia64-hpux-tdep.c.
  68
  69 2011-01-13  Joel Brobecker  <brobecker@adacore.com>
  70
  71         [ttrace] Compute thread list immediately after attach.
  72         * inf_ttrace_attach (inf_ttrace_create_threads_after_attach):
  73         New subprogram.
  74         (inf_ttrace_attach): Use it.
  75
  76 2011-01-13  Joel Brobecker  <brobecker@adacore.com>
  77
  78         * libunwind-frame.c (libunwind_frame_cache): Do not return NULL
  79         if we could not determine the frame's function address.  Instead,
  80         use the frame's PC, and then continue.
  81
  82 2011-01-13  Joel Brobecker  <brobecker@adacore.com>
  83
  84         * libunwind-frame.c (__LITTLE_ENDIAN, __BIG_ENDIAN): Define if
  85         not already defined.
  86
  87 2011-01-13  Joel Brobecker  <brobecker@adacore.com>
  88
  89         * ia64-tdep.c (ia64_struct_type_p): New function.
  90         (ia64_extract_return_value): Handle integral values that are
  91         less than 8 bytes long.
  92         (ia64_push_dummy_call): Likewise.
  93
  94 2011-01-13  Joel Brobecker  <brobecker@adacore.com>
  95
  96         * ia64-tdep.c (floatformat_ia64_ext_little): Renames
  97         floatformat_ia64_ext.
  98         (floatformat_ia64_ext_big): New static const.
  99         (floatformats_ia64_ext): Set first entry to &floatformat_ia64_ext_big.
 100
 101 2011-01-12  Tom Tromey  <tromey@redhat.com>
 102
 103         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Fix error
 104         messages.
 105         * mi/mi-main.c (mi_cmd_thread_select): Fix error messages.
 106         (mi_cmd_thread_list_ids): Likewise.
 107         (mi_cmd_data_list_changed_registers): Likewise.
 108         (mi_cmd_data_list_register_values): Likewise.
 109         (mi_cmd_data_write_register_values): Likewise.
 110         (mi_cmd_data_evaluate_expression): Likewise.
 111         (mi_cmd_data_read_memory): Likewise.
 112         (mi_cmd_data_read_memory_bytes): Likewise.
 113         (mi_cmd_data_write_memory): Likewise.
 114         (mi_cmd_enable_timings): Likewise.
 115         * mi/mi-interp.c (mi_cmd_interpreter_exec): Fix error messages.
 116         * mi/mi-cmd-var.c (mi_cmd_var_create): Fix error messages.
 117         (mi_cmd_var_delete): Likewise.
 118         (mi_cmd_var_set_format): Likewise.
 119         (mi_cmd_var_show_format): Likewise.
 120         (mi_cmd_var_info_num_children): Likewise.
 121         (mi_cmd_var_list_children): Likewise.
 122         (mi_cmd_var_info_type): Likewise.
 123         (mi_cmd_var_info_expression): Likewise.
 124         (mi_cmd_var_show_attributes): Likewise.
 125         (mi_cmd_var_assign): Likewise.
 126         (mi_cmd_var_update): Likewise.
 127         (mi_cmd_enable_pretty_printing): Likewise.
 128         (mi_cmd_var_set_update_range): Likewise.
 129         * mi/mi-cmd-target.c (mi_cmd_target_file_get): Fix error
 130         messages.
 131         (mi_cmd_target_file_put): Likewise.
 132         (mi_cmd_target_file_delete): Likewise.
 133         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames): Fix error
 134         messages.
 135         (mi_cmd_stack_info_depth): Likewise.
 136         (mi_cmd_stack_list_locals): Likewise.
 137         (mi_cmd_stack_list_args): Likewise.
 138         (mi_cmd_stack_select_frame): Likewise.
 139         (mi_cmd_stack_select_frame): Likewise.
 140         (mi_cmd_stack_info_frame): Likewise.
 141         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Fix error
 142         messages.
 143         (mi_cmd_file_list_exec_source_files): Likewise.
 144         * mi/mi-cmd-env.c (mi_cmd_env_pwd): Fix error messages.
 145         (mi_cmd_env_cd): Likewise.
 146         (mi_cmd_env_path): Likewise.
 147         (mi_cmd_env_dir): Likewise.
 148         (mi_cmd_inferior_tty_show): Likewise.
 149         * mi/mi-cmd-disas.c (mi_cmd_disassemble): Fix error messages.
 150         * mi/mi-cmd-break.c (mi_cmd_break_insert): Fix error messages.
 151         (mi_cmd_break_watch): Likewise.
 152
 153 2011-01-12  Thiago Jung Bauermann  <bauerman@br.ibm.com>
 154
 155         * ppc-linux-nat.c (booke_cmp_hw_point): Fix whitespace.
 156         (ppc_linux_insert_hw_breakpoint): Likewise.
 157         (ppc_linux_remove_hw_breakpoint): Likewise.
 158         (ppc_linux_insert_watchpoint): Likewise.
 159
 160 2011-01-12  Andrew Burgess  <aburgess@broadcom.com>
 161             Jan Kratochvil  <jan.kratochvil@redhat.com>
 162
 163         PR fortran/11104 and DWARF unbound arrays detection.
 164         * dwarf2read.c (read_subrange_type): Set zero length on unspecified
 165         upper bound.  Set TYPE_HIGH_BOUND_UNDEFINED if not language_ada on
 166         unspecified upper bound.
 167         * eval.c (evaluate_subexp_standard) <multi_f77_subscript>: Remove
 168         variables array_size_array, tmp_type and offset_item.  New variable
 169         array.  Remove call to f77_get_upperbound.  New variables array_type
 170         and index.  Call value_subscripted_rvalue for each dimenasion.  Remove
 171         the final call to deprecated_set_value_type.
 172
 173 2011-01-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
 174
 175         Make value allocations more lazy.
 176         * ada-lang.c (coerce_unspec_val_to_type): Use allocate_value_lazy
 177         instead of allocate_value and set_value_lazy when possible.
 178         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use allocate_value_lazy
 179         instead of allocate_value and set_value_lazy.
 180         * findvar.c (value_of_register_lazy): Likewise.
 181         (read_var_value): Remove V preallocation, call just check_typedef in
 182         advance.  Move allocate_value to LOC_CONST, LOC_LABEL,
 183         LOC_CONST_BYTES.  Use allocate_value_lazy in LOC_STATIC, LOC_ARG,
 184         LOC_REF_ARG, LOC_LOCAL, LOC_BLOCK.  Set ADDR instead of
 185         set_value_address and break in LOC_BLOCK.  Use allocate_value_lazy and
 186         remove lval_memory set in LOC_REGPARM_ADDR.  Use allocate_value_lazy
 187         in LOC_UNRESOLVED and LOC_OPTIMIZED_OUT.  Add setting lval_memory at
 188         the end, remove set_value_lazy there.
 189         * valarith.c (value_subscripted_rvalue): Use allocate_value_lazy
 190         instead of allocate_value and set_value_lazy when possible.
 191         * valops.c (value_fetch_lazy): Do nop for value_optimized_out VAL.
 192         * value.c (allocate_computed_value): Use allocate_value_lazy instead
 193         of allocate_value and set_value_lazy.
 194         (value_from_contents_and_address): Use allocate_value_lazy instead of
 195         allocate_value and set_value_lazy when possible.
 196
 197 2011-01-12  Andrew Burgess  <aburgess@broadcom.com>
 198
 199         * disasm.c (dump_insns): Support dumping opcodes for MI.
 200         * mi/mi-cmd-disas.c (mi_cmd_disassemble): Allow mode to control
 201         dumping of instruction opcodes.
 202
 203 2011-01-09  Robert Millan  <rmh@gnu.org>  (tiny patch)
 204
 205         * configure.tgt: Detect GNU/kFreeBSD and set `gdb_osabi'
 206         appropiately.
 207
 208 2011-01-11  Tom Tromey  <tromey@redhat.com>
 209
 210         * thread.c (do_captured_thread_select): Emit newline before
 211         printing frame.
 212
 213 2011-01-11  Michael Snyder  <msnyder@vmware.com>
 214
 215         * s390-tdep.c: Comment cleanup, mostly periods and spaces.
 216         * score-tdep.c: Ditto.
 217         * score-tdep.h: Ditto.
 218         * ser-base.c: Ditto.
 219         * ser-go32.c: Ditto.
 220         * serial.c: Ditto.
 221         * serial.h: Ditto.
 222         * ser-mingw.c: Ditto.
 223         * ser-pipe.c: Ditto.
 224         * ser-tcp.c: Ditto.
 225         * ser-unix.c: Ditto.
 226         * sh64-tdep.c: Ditto.
 227         * shnbsd-nat.c: Ditto.
 228         * sh-tdep.c: Ditto.
 229         * sh-tdep.h: Ditto.
 230         * solib.c: Ditto.
 231         * solib-darwin.c: Ditto.
 232         * solib-frv.c: Ditto.
 233         * solib.h: Ditto.
 234         * solib-irix.c: Ditto.
 235         * solib-osf.c: Ditto.
 236         * solib-pa64.c: Ditto.
 237         * solib-som.c: Ditto.
 238         * solib-spu.c: Ditto.
 239         * solib-sunos.c: Ditto.
 240         * solib-svr4.c: Ditto.
 241         * solist.h: Ditto.
 242         * sol-thread.c: Ditto.
 243         * somread.c: Ditto.
 244         * source.c: Ditto.
 245         * source.h: Ditto.
 246         * sparc64-linux-tdep.c: Ditto.
 247         * sparc64-tdep.c: Ditto.
 248         * sparc-linux-nat.c: Ditto.
 249         * sparc-linux-tdep.c: Ditto.
 250         * sparc-sol2-nat.c: Ditto.
 251         * sparc-sol2-tdep.c: Ditto.
 252         * sparc-tdep.c: Ditto.
 253         * sparc-tdep.h: Ditto.
 254         * spu-tdep.c: Ditto.
 255         * stabsread.c: Ditto.
 256         * stabsread.h: Ditto.
 257         * stack.c: Ditto.
 258         * symfile.c: Ditto.
 259         * symfile.h: Ditto.
 260         * symmisc.c: Ditto.
 261         * symtab.c: Ditto.
 262         * symtab.h: Ditto.
 263         * target.c: Ditto.
 264         * target-descriptions.c: Ditto.
 265         * target-descriptions.h: Ditto.
 266         * target.h: Ditto.
 267         * target-memory.c: Ditto.
 268         * terminal.h: Ditto.
 269         * thread.c: Ditto.
 270         * top.c: Ditto.
 271         * tracepoint.c: Ditto.
 272         * tracepoint.h: Ditto.
 273         * trad-frame.h: Ditto.
 274         * typeprint.c: Ditto.
 275
 276 2011-01-11  Michael Snyder  <msnyder@vmware.com>
 277
 278         * ui-file.c: Comment cleanup, mostly periods and spaces.
 279         * ui-file.h: Ditto.
 280         * ui-out.c: Ditto.
 281         * ui-out.h: Ditto.
 282         * utils.c: Ditto.
 283         * v850-tdep.c: Ditto.
 284         * valarith.c: Ditto.
 285         * valops.c: Ditto.
 286         * valprint.c: Ditto.
 287         * valprint.h: Ditto.
 288         * value.c: Ditto.
 289         * value.h: Ditto.
 290         * varobj.c: Ditto.
 291         * varobj.h: Ditto.
 292         * vax-tdep.c: Ditto.
 293         * vec.c: Ditto.
 294         * vec.h: Ditto.
 295         * version.h: Ditto.
 296         * windows-nat.c: Ditto.
 297         * windows-tdep.c: Ditto.
 298         * xcoffread.c: Ditto.
 299         * xcoffsolib.c: Ditto.
 300         * xml-support.c: Ditto.
 301         * xstormy16-tdep.c: Ditto.
 302         * xtensa-tdep.c: Ditto.
 303         * xtensa-tdep.h: Ditto.
 304
 305 2011-01-11  Thiago Jung Bauermann  <bauerman@br.ibm.com>
 306
 307         * breakpoint.c (resources_needed_watchpoint): Fix indentation.
 308         * gdbtypes.c (is_scalar_type_recursive): Fix formatting.
 309
 310 2011-01-11  Sergio Durigan Junior  <sergiodj@linux.vnet.ibm.com>
 311             Thiago Jung Bauermann  <bauerman@br.ibm.com>
 312
 313         Implement support for PowerPC BookE ranged watchpoints.
 314         * breakpoint.h
 315         (struct breakpoint_ops) <resources_needed>: New method.
 316         Initialize to NULL in all existing breakpoint_ops instances.
 317         (struct breakpoint) <exact>: New field.
 318         (target_exact_watchpoints): Declare external global.
 319         * breakpoint.c (target_exact_watchpoints): New global flag.
 320         (update_watchpoint): Set b->type to bp_hardware_watchpoint and
 321         b->enable_state to bp_enabled before calling
 322         hw_watchpoint_used_count.
 323         (hw_watchpoint_used_count): Iterate over all bp_locations in a
 324         watchpoint.  Call breakpoint's breakpoint_ops.resources_needed
 325         if available.
 326         (insert_watchpoint, remove_watchpoint): Use fixed length of 1 byte
 327         if the watchpoint is exact.
 328         (resources_needed_watchpoint): New function.
 329         (watchpoint_breakpoint_ops): Add resources_needed_watchpoint.
 330         (watch_command_1): Set b->exact if the user asked for an exact
 331         watchpoint and one can be set.
 332         (can_use_hardware_watchpoint): Add exact_watchpoints argument.
 333         Pass fixed length of 1 to target_region_ok_for_hw_watchpoint if
 334         the user asks for an exact watchpoint and one can be set.  Return
 335         number of needed debug registers to watch the expression.
 336         * gdbtypes.c (is_scalar_type): New function, based on
 337         valprint.c:scalar_type_p.
 338         (is_scalar_type_recursive): New function.
 339         * gdbtypes.h (is_scalar_type_recursive): Declare.
 340         * ppc-linux-nat.c (ppc_linux_region_ok_for_hw_watchpoint): Always
 341         handle regions when ranged watchpoints are available.
 342         (create_watchpoint_request): New function.
 343         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint): Use
 344         create_watchpoint_request.
 345         * rs6000-tdep.c (show_powerpc_exact_watchpoints): New function.
 346         (_initialize_rs6000_tdep): Add `exact-watchpoints' boolean to the
 347         `set powerpc' and `show powerpc' commands.
 348         * target.h (struct target_ops) <to_region_ok_for_hw_watchpoint>:
 349         Mention documentation comment in the target macro.
 350         (target_region_ok_for_hw_watchpoint): Document return value.
 351
 352 2011-01-11  Thiago Jung Bauermann  <bauerman@br.ibm.com>
 353
 354         * breakpoint.c (update_watchpoint): Decide on using a software or
 355         hardware watchpoint after the bp_locations are created.
 356
 357 2010-01-11  Thiago Jung Bauermann  <bauerman@br.ibm.com>
 358
 359         Convert hardware watchpoints to use breakpoint_ops.
 360         * breakpoint.h (breakpoint_ops) <insert>: Rename to...
 361         <insert_location>: ... this.  Return int instead of void.
 362         Accept pointer to struct bp_location instead of pointer to
 363         struct breakpoint.  Adapt all implementations.
 364         (breakpoint_ops) <remove>: Rename to...
 365         <remove_location>: ... this.  Accept pointer to struct bp_location
 366         instead of pointer to struct breakpoint.  Adapt all implementations.
 367         * breakpoint.c (insert_catchpoint): Delete function.
 368         (insert_bp_location): Call the watchpoint or catchpoint's
 369         breakpoint_ops.insert method.
 370         (remove_breakpoint_1): Call the watchpoint or catchpoint's
 371         breakpoint_ops.remove method.
 372         (insert_watchpoint, remove_watchpoint): New functions.
 373         (watchpoint_breakpoint_ops): New structure.
 374         (watch_command_1): Initialize the OPS field.
 375         * inf-child.c (inf_child_insert_fork_catchpoint)
 376         (inf_child_remove_fork_catchpoint, inf_child_insert_vfork_catchpoint)
 377         (inf_child_remove_vfork_catchpoint, inf_child_insert_exec_catchpoint)
 378         (inf_child_remove_exec_catchpoint, inf_child_set_syscall_catchpoint):
 379         Delete functions.
 380         (inf_child_target): Remove initialization of to_insert_fork_catchpoint,
 381         to_remove_fork_catchpoint, to_insert_vfork_catchpoint,
 382         to_remove_vfork_catchpoint, to_insert_exec_catchpoint,
 383         to_remove_exec_catchpoint and to_set_syscall_catchpoint.
 384         * target.c (update_current_target): Change default implementation of
 385         to_insert_fork_catchpoint, to_remove_fork_catchpoint,
 386         to_insert_vfork_catchpoint, to_remove_vfork_catchpoint,
 387         to_insert_exec_catchpoint, to_remove_exec_catchpoint and
 388         to_set_syscall_catchpoint to return_one.
 389         (debug_to_insert_fork_catchpoint, debug_to_insert_vfork_catchpoint)
 390         (debug_to_insert_exec_catchpoint): Report return value.
 391         * target.h (to_insert_fork_catchpoint, to_insert_vfork_catchpoint)
 392         (to_insert_exec_catchpoint): Change declaration to return int instead
 393         of void.
 394
 395 2011-01-11  Michael Snyder  <msnyder@vmware.com>
 396
 397         * arm-tdep.c: Internationalization.
 398         * c-lang.c: Ditto.
 399         * charset.c: Ditto.
 400         * fork-child.c: Ditto.
 401         * nto-procfs.c: Ditto.
 402         * ppc-sysv-tdep.c: Ditto.
 403         * procfs.c: Ditto.
 404         * remote-mips.c: Ditto.
 405         * remote.c: Ditto.
 406         * rs6000-nat.c: Ditto.
 407         * rs6000-tdep.c: Ditto.
 408         * target.c: Ditto.
 409         * valops.c: Ditto.
 410         * value.c: Ditto.
 411         * xml-support.c: Ditto.
 412         * mi/mi-cmd-break.c: Ditto.
 413         * mi/mi-cmd-var.c: Ditto.
 414         * mi/mi-interp.c: Ditto.
 415         * mi/mi-main.c: Ditto.
 416
 417 2011-01-11  Andrew Burgess  <aburgess@broadcom.com>
 418
 419         * remote-sim.c (gdbsim_store_register): Update API to
 420         sim_store_register to check more error conditions.
 421
 422 2011-01-10  Michael Snyder  <msnyder@vmware.com>
 423
 424         * nto-procfs.c: Comment cleanup, mostly periods and spaces.
 425         * nto-tdep.c: Ditto.
 426         * nto-tdep.h: Ditto.
 427         * objc-exp.y: Ditto.
 428         * objc-lang.c: Ditto.
 429         * objfiles.c: Ditto.
 430         * objfiles.h: Ditto.
 431         * observer.c: Ditto.
 432         * opencl-lang.c: Ditto.
 433         * osabi.c: Ditto.
 434         * parse.c: Ditto.
 435         * parser-defs.h: Ditto.
 436         * p-exp.y: Ditto.
 437         * p-lang.c: Ditto.
 438         * posix-hdep.c: Ditto.
 439         * ppcbug-rom.c: Ditto.
 440         * ppc-linux-nat.c: Ditto.
 441         * ppc-linux-tdep.c: Ditto.
 442         * ppc-linux-tdep.h: Ditto.
 443         * ppcnbsd-tdep.c: Ditto.
 444         * ppcobsd-tdep.c: Ditto.
 445         * ppcobsd-tdep.h: Ditto.
 446         * ppc-sysv-tdep.c: Ditto.
 447         * ppc-tdep.h: Ditto.
 448         * printcmd.c: Ditto.
 449         * proc-abi.c: Ditto.
 450         * proc-flags.c: Ditto.
 451         * procfs.c: Ditto.
 452         * proc-utils.h: Ditto.
 453         * progspace.h: Ditto.
 454         * prologue-value.c: Ditto.
 455         * prologue-value.h: Ditto.
 456         * psympriv.h: Ditto.
 457         * psymtab.c: Ditto.
 458         * p-typeprint.c: Ditto.
 459         * p-valprint.c: Ditto.
 460         * ravenscar-sparc-thread.c: Ditto.
 461         * ravenscar-thread.c: Ditto.
 462         * ravenscar-thread.h: Ditto.
 463         * record.c: Ditto.
 464         * regcache.c: Ditto.
 465         * regcache.h: Ditto.
 466         * remote.c: Ditto.
 467         * remote-fileio.c: Ditto.
 468         * remote-fileio.h: Ditto.
 469         * remote.h: Ditto.
 470         * remote-m32r-sdi.c: Ditto.
 471         * remote-mips.c: Ditto.
 472         * remote-sim.c: Ditto.
 473         * rs6000-aix-tdep.c: Ditto.
 474         * rs6000-nat.c: Ditto.
 475         * rs6000-tdep.c: Ditto.
 476
 477 2011-01-10  Michael Snyder  <msnyder@vmware.com>
 478
 479         * charset.c (validate): Internationalization.
 480         * coffread.c (read_one_sym): Ditto.
 481         * dwarf2read.c (dwarf2_attach_fields_to_type): Ditto.
 482         * h8300-tdep.c (H8300_extract_return_value): Ditto.
 483         * inflow.c (new_tty): Ditto.
 484         * iq2000-tdep.c (iq2000_breakpoint_from_pc): Ditto.
 485         * m32c-tdep.c (m32c_return_value): Ditto.
 486         * mep-tdep.c (mep_store_return_value): Ditto.
 487         * score-tdep.c (score7_fetch_insn): Ditto.
 488         * ser-mingw.c (pipe_windows_open): Ditto.
 489         * sh64-tdep.c (sh64_extract_return_value): Ditto.
 490         * spu-tdep.c (spu_register_type): Ditto.
 491         * tracepoint.c (trace_find_command): Ditto.
 492         * valarith.c (value_pos): Ditto.
 493
 494 2011-01-10  Joel Brobecker  <brobecker@adacore.com>
 495
 496         * ada-valprint.c (printstr): Minor comment reformatting.
 497
 498 2011-01-08  Michael Snyder  <msnyder@vmware.com>
 499
 500         * m32r-rom.c (m32r_upload_command): Fix up ARI warnings for _
 501         markup.
 502
 503 2011-01-08  Michael Snyder  <msnyder@vmware.com>
 504
 505         * h8300-tdep.c: Comment cleanup, mostly periods and spaces.
 506         * hppa-hpux-tdep.c: Ditto.
 507         * hppa-linux-nat.c: Ditto.
 508         * hppa-linux-tdep.c: Ditto.
 509         * hppanbsd-tdep.c: Ditto.
 510         * hppa-tdep.c: Ditto.
 511         * hppa-tdep.h: Ditto.
 512         * hpux-thread.c: Ditto.
 513         * i386-cygwin-tdep.c: Ditto.
 514         * i386-darwin-nat.c: Ditto.
 515         * i386gnu-nat.c: Ditto.
 516         * i386-linux-nat.c: Ditto.
 517         * i386-linux-tdep.c: Ditto.
 518         * i386-nat.c: Ditto.
 519         * i386-nat.h: Ditto.
 520         * i386nbsd-tdep.c: Ditto.
 521         * i386-sol2-nat.c: Ditto.
 522         * i386-stub.c: Ditto.
 523         * i386-tdep.c: Ditto.
 524         * i386-tdep.h: Ditto.
 525         * i387-tdep.c: Ditto.
 526         * ia64-linux-nat.c: Ditto.
 527         * ia64-linux-tdep.c: Ditto.
 528         * ia64-tdep.c: Ditto.
 529         * infcall.c: Ditto.
 530         * infcall.h: Ditto.
 531         * infcmd.c: Ditto.
 532         * inferior.c: Ditto.
 533         * inferior.h: Ditto.
 534         * infloop.c: Ditto.
 535         * inflow.c: Ditto.
 536         * infrun.c: Ditto.
 537         * interps.c: Ditto.
 538         * interps.h: Ditto.
 539         * iq2000-tdep.c: Ditto.
 540         * irix5-nat.c: Ditto.
 541         * jit.c: Ditto.
 542         * jit.h: Ditto.
 543         * jv-exp.y: Ditto.
 544         * jv-lang.c: Ditto.
 545         * jv-lang.h: Ditto.
 546         * jv-typeprint.c: Ditto.
 547         * jv-valprint.c: Ditto.
 548         * language.c: Ditto.
 549         * language.h: Ditto.
 550         * linespec.c: Ditto.
 551         * linux-fork.c: Ditto.
 552         * linux-nat.c: Ditto.
 553         * linux-thread-db.c: Ditto.
 554         * lm32-tdep.c: Ditto.
 555
 556 2011-01-08  Michael Snyder  <msnyder@vmware.com>
 557
 558         * m2-exp.y: Comment cleanup, mostly periods and spaces.
 559         * m2-lang.c: Ditto.
 560         * m2-typeprint.c: Ditto.
 561         * m2-valprint.c: Ditto.
 562         * m32c-tdep.c: Ditto.
 563         * m32r-linux-nat.c: Ditto.
 564         * m32r-rom.c: Ditto.
 565         * m32r-tdep.c: Ditto.
 566         * m32r-tdep.h: Ditto.
 567         * m68hc11-tdep.c: Ditto.
 568         * m58klinux-nat.c: Ditto.
 569         * m68k-tdep.c: Ditto.
 570         * m88k-tdep.c: Ditto.
 571         * m88k-tdep.h: Ditto.
 572         * machoread.c: Ditto.
 573         * macrocmd.c: Ditto.
 574         * macroexp.c: Ditto.
 575         * macrotab.c: Ditto.
 576         * main.c: Ditto.
 577         * maint.c: Ditto.
 578         * mdebugread.c: Ditto.
 579         * mdebugread.h: Ditto.
 580         * memattr.c: Ditto.
 581         * memattr.h: Ditto.
 582         * memory-map.h: Ditto.
 583         * mep-tdep.c: Ditto.
 584         * microblaze-rom.c: Ditto.
 585         * microblaze-tdep.c: Ditto.
 586         * minsyms.c: Ditto.
 587         * mips-irix-tdep.c: Ditto.
 588         * mips-linux-nat.c: Ditto.
 589         * mips-linux-tdep.c: Ditto.
 590         * mips-linux-tdep.h: Ditto.
 591         * mipsnbsd-nat.c: Ditto.
 592         * mipsnbsd-tdep.c: Ditto.
 593         * mipsread.c: Ditto.
 594         * mips-tdep.c: Ditto.
 595         * mips-tdep.h: Ditto.
 596         * mn10300-linux-tdep.c: Ditto.
 597         * mn10300-tdep.c: Ditto.
 598         * mn10300-tdep.h: Ditto.
 599         * monitor.c: Ditto.
 600         * monitor.h: Ditto.
 601         * moxie-tdep.c: Ditto.
 602         * moxie-tdep.h: Ditto.
 603         * mt-tdep.c: Ditto.
 604
 605 2011-01-08  Mike Frysinger  <vapier@gentoo.org>
 606
 607         * bfin-tdep.h (BFIN_A0_DOT_W_REGNUM): Fix typo in name.
 608
 609 2011-01-08  Robert Millan  <rmh@gnu.org>
 610
 611         * fbsd-nat.c (fbsd_find_memory_regions): Fix typo.
 612
 613 2011-01-07  Michael Snyder  <msnyder@vmware.com>
 614
 615         * charset.c (_initialize_charset): Fix typo in string.
 616
 617 2011-01-07  Michael Snyder  <msnyder@vmware.com>
 618
 619         * mi/mi-cmd-disas.c (mi_cmd_disassemble): Mark up error message
 620         for i18n.
 621         * tui/tui-layout.c (tui_set_layout_for_display_command):
 622         Split line so that operator goes to beginning of line.
 623         * tui/tui-winsource.c (tui_horizontal_source_scroll): Move
 624         assignment out of if statement.
 625
 626 2011-01-07  Michael Snyder  <msnyder@vmware.com>
 627
 628         * ada-lang.c: Comment cleanup, mostly periods and spaces.
 629         * ada-lang.h: Ditto.
 630         * ada-tasks.c: Ditto.
 631         * ada-valprint.c: Ditto.
 632         * aix-threads.c: Ditto.
 633         * alpha-linux-nat.c: Ditto.
 634         * alpha-linux-tdep.c: Ditto.
 635         * alpha-mdebug-tdep.c: Ditto.
 636         * alpha-nat.c: Ditto.
 637         * alpha-osf1-tdep.c: Ditto.
 638         * alpha-tdep.c: Ditto.
 639         * alphabsd-nat.c: Ditto.
 640         * alphabsd-tdep.c: Ditto.
 641         * amd64-darwin-tdep.c: Ditto.
 642         * amd64-linux-nat.c: Ditto.
 643         * amd64-linux-tdep.c: Ditto.
 644         * amd64-sol2-tdep.c: Ditto.
 645         * amd64-tdep.c: Ditto.
 646         * amd64-fbsd-tdep.c: Ditto.
 647         * amd64-nbsd-tdep.c: Ditto.
 648         * amd64-obsd-tdep.c: Ditto.
 649         * amd64-linux-nat.c: Ditto.
 650         * amd64-linux-tdep.c: Ditto.
 651         * arm-tdep.c: Ditto.
 652         * arm-tdep.h: Ditto.
 653         * armnbsd-nat.c: Ditto.
 654         * avr-tdep.c: Ditto.
 655         * bfin-tdep.c: Ditto.
 656         * bsd-kvm.c: Ditto.
 657         * c-typeprintc: Ditto.
 658         * c-valprint.c: Ditto.
 659         * coff-pe-read.h: Ditto.
 660         * coffreead.c: Ditto.
 661         * cris-tdep.c: Ditto.
 662         * d-lang.c: Ditto.
 663         * darwin-nat-info.c: Ditto.
 664         * darwin-nat.c: Ditto.
 665         * dbug-rom.c: Ditto.
 666         * dbxread.c: Ditto.
 667         * dcache.c: Ditto.
 668         * dcache.h: Ditto.
 669         * dec-thread.c: Ditto.
 670         * defs.h: Ditto.
 671         * demangle.c: Ditto.
 672         * dicos-tdep.c: Ditto.
 673         * dictionary.c: Ditto.
 674         * dictionary.h: Ditto.
 675         * dink32-rom.c: Ditto.
 676         * disasm.c: Ditto.
 677         * doublest.c: Ditto.
 678         * dsrec.c: Ditto.
 679         * dummy-frame.c: Ditto.
 680         * dwarf2-frame.c: Ditto.
 681         * dwarf2expr.c: Ditto.
 682         * dwarf2loc.c: Ditto.
 683         * dwarf2read.c: Ditto.
 684         * elfread.c: Ditto.
 685         * environ.c: Ditto.
 686         * eval.c: Ditto.
 687         * event-top.h: Ditto.
 688         * exceptions.c: Ditto.
 689         * exceptions.h: Ditto.
 690         * exec.c: Ditto.
 691         * expprint.c: Ditto.
 692         * expression.h: Ditto.
 693         * f-exp.y: Ditto.
 694         * f-lang.c: Ditto.
 695         * f-lang.h: Ditto.
 696         * f-typeprint.c: Ditto.
 697         * f-valprint.c: Ditto.
 698         * fbsd-nat.c: Ditto.
 699         * findvar.c: Ditto.
 700         * fork-child.c: Ditto.
 701         * frame.c: Ditto.
 702         * frame.h: Ditto.
 703         * frv-linux-tdep.c: Ditto.
 704         * frv-tdep.c: Ditto.
 705         * gcore.c: Ditto.
 706         * gdb-stabs.h: Ditto.
 707         * gdb_assert.h: Ditto.
 708         * gdb_string.h: Ditto.
 709         * gdb_thread_db.h: Ditto.
 710         * gdb_wait.h: Ditto.
 711         * gdbarch.sh: Ditto.
 712         * gdbcore.h: Ditto.
 713         * gdbthread.h: Ditto.
 714         * gdbtypes.c: Ditto.
 715         * gdbtypes.h: Ditto.
 716         * gnu-nat.c: Ditto.
 717         * gnu-nat.h: Ditto.
 718         * gnu-v2-abi.c: Ditto.
 719         * gnu-v3-abi.c: Ditto.
 720         * go32-nat.c: Ditto.
 721         * gdbarch.c: Regenerate.
 722         * gdbarch.h: Regenerate.
 723
 724 2011-01-07  Michael Snyder  <msnyder@vmware.com>
 725
 726         * ax-gdb.c: Adjust some long output strings.
 727         * breakpoint.c: Ditto.
 728         * charset.c: Ditto.
 729         * cp-abi.c: Ditto.
 730         * infcall.c: Ditto.
 731         * infrun.c: Ditto.
 732         * linux-nat.c: Ditto.
 733         * solib-pa64.c: Ditto.
 734         * solib-som.c: Ditto.
 735
 736 2011-01-06  Tom Tromey  <tromey@redhat.com>
 737
 738         PR python/12367:
 739         * NEWS: Add item.
 740         * python/python.c (GdbMethods): Add "newest_frame" method.
 741         * python/python-internal.h (gdbpy_newest_frame): Declare.
 742         * python/py-frame.c (gdbpy_newest_frame): New function.
 743
 744 2010-01-06  Paul Pluzhnikov  <ppluzhnikov@google.com>
 745
 746         * jit.h (struct jit_code_entry): use ULONGEST for symfile_size.
 747         * jit.c (jit_debug): New variable.
 748         (show_jit_debug): New function.
 749         (struct target_buffer): Use ULONGEST.
 750         (bfd_open_from_target_memory): Likewise.
 751         (jit_register_code, jit_inferior_init): Add debug output.
 752         (_initialize_jit): Register "debug jit" command.
 753
 754 2011-01-06  Tom Tromey  <tromey@redhat.com>
 755
 756         * frame.h (enum frame_type) <INLINE_FRAME>: Fix comment.
 757         * python/py-frame.c (gdbpy_initialize_frames): Add INLINE_FRAME
 758         and ARCH_FRAME.
 759
 760 2011-01-06  Tom Tromey  <tromey@redhat.com>
 761
 762         * python/py-frame.c (frapy_block): Use get_frame_block.
 763
 764 2011-01-06  Joel Brobecker  <brobecker@adacore.com>
 765
 766         Do not stop on SIGPRIO signals by default
 767         * infrun.c (_initialize_infrun): Unset signal_stop and
 768         signal_print for TARGET_SIGNAL_PRIO.
 769
 770 2011-01-06  Joel Brobecker  <brobecker@adacore.com>
 771
 772         * ada-tasks.c: Fix style violation in comment.
 773
 774 2011-01-06  Joel Brobecker  <brobecker@adacore.com>
 775
 776         * linespec.c (decode_compound, find_method): Remove trailing \n
 777         at end of error string.
 778         * solib-irix.c (irix_current_sos): Likewise.
 779         * varobj.c (uninstall_variable): Likewise.
 780
 781 2011-01-06  Joel Brobecker  <brobecker@adacore.com>
 782
 783         * copyright.py: New script.
 784         * copyright.sh (byhand): Add *.ads, *.adb, *.gpr and *.inc.
 785         Launch emacs without exec'ing. Call copyright.py afterwards.
 786
 787 2011-01-05  Michael Snyder  <msnyder@vmware.com>
 788
 789         * addrmap.c: Shorten lines of >= 80 columns.
 790         * arch-utils.c: Ditto.
 791         * arch-utils.h: Ditto.
 792         * ax-gdb.c: Ditto.
 793         * ax-general.c: Ditto.
 794         * bcache.c: Ditto.
 795         * blockframe.c: Ditto.
 796         * breakpoint.c: Ditto.
 797         * buildsym.c: Ditto.
 798         * c-lang.c: Ditto.
 799         * c-typeprint.c: Ditto.
 800         * charset.c: Ditto.
 801         * coffread.c: Ditto.
 802         * command.h: Ditto.
 803         * corelow.c: Ditto.
 804         * cp-abi.c: Ditto.
 805         * cp-namespace.c: Ditto.
 806         * cp-support.c: Ditto.
 807         * dbug-rom.c: Ditto.
 808         * dbxread.c: Ditto.
 809         * defs.h: Ditto.
 810         * dfp.c: Ditto.
 811         * dfp.h: Ditto.
 812         * dictionary.c: Ditto.
 813         * disasm.c: Ditto.
 814         * doublest.c: Ditto.
 815         * dwarf2-frame.c: Ditto.
 816         * dwarf2expr.c: Ditto.
 817         * dwarf2loc.c: Ditto.
 818         * dwarf2read.c: Ditto.
 819         * elfread.c: Ditto.
 820         * eval.c: Ditto.
 821         * event-loop.c: Ditto.
 822         * event-loop.h: Ditto.
 823         * exceptions.h: Ditto.
 824         * exec.c: Ditto.
 825         * expprint.c: Ditto.
 826         * expression.h: Ditto.
 827         * f-lang.c: Ditto.
 828         * f-valprint.c: Ditto.
 829         * findcmd.c: Ditto.
 830         * frame-base.c: Ditto.
 831         * frame-unwind.c: Ditto.
 832         * frame-unwind.h: Ditto.
 833         * frame.c: Ditto.
 834         * frame.h: Ditto.
 835         * gcore.c: Ditto.
 836         * gdb-stabs.h: Ditto.
 837         * gdb_assert.h: Ditto.
 838         * gdb_dirent.h: Ditto.
 839         * gdb_obstack.h: Ditto.
 840         * gdbcore.h: Ditto.
 841         * gdbtypes.c: Ditto.
 842         * gdbtypes.h: Ditto.
 843         * inf-ttrace.c: Ditto.
 844         * infcall.c: Ditto.
 845         * infcmd.c: Ditto.
 846         * inflow.c: Ditto.
 847         * infrun.c: Ditto.
 848         * inline-frame.h: Ditto.
 849         * language.c: Ditto.
 850         * language.h: Ditto.
 851         * libunwind-frame.c: Ditto.
 852         * libunwind-frame.h: Ditto.
 853         * linespec.c: Ditto.
 854         * linux-nat.c: Ditto.
 855         * linux-nat.h: Ditto.
 856         * linux-thread-db.c: Ditto.
 857         * machoread.c: Ditto.
 858         * macroexp.c: Ditto.
 859         * macrotab.c: Ditto.
 860         * main.c: Ditto.
 861         * maint.c: Ditto.
 862         * mdebugread.c: Ditto.
 863         * memattr.c: Ditto.
 864         * minsyms.c: Ditto.
 865         * monitor.c: Ditto.
 866         * monitor.h: Ditto.
 867         * objfiles.c: Ditto.
 868         * objfiles.h: Ditto.
 869         * osabi.c: Ditto.
 870         * p-typeprint.c: Ditto.
 871         * p-valprint.c: Ditto.
 872         * parse.c: Ditto.
 873         * printcmd.c: Ditto.
 874         * proc-events.c: Ditto.
 875         * procfs.c: Ditto.
 876         * progspace.c: Ditto.
 877         * progspace.h: Ditto.
 878         * psympriv.h: Ditto.
 879         * psymtab.c: Ditto.
 880         * record.c: Ditto.
 881         * regcache.c: Ditto.
 882         * regcache.h: Ditto.
 883         * remote-fileio.c: Ditto.
 884         * remote.c: Ditto.
 885         * ser-mingw.c: Ditto.
 886         * ser-tcp.c: Ditto.
 887         * ser-unix.c: Ditto.
 888         * serial.c: Ditto.
 889         * serial.h: Ditto.
 890         * solib-frv.c: Ditto.
 891         * solib-irix.c: Ditto.
 892         * solib-osf.c: Ditto.
 893         * solib-pa64.c: Ditto.
 894         * solib-som.c: Ditto.
 895         * solib-sunos.c: Ditto.
 896         * solib-svr4.c: Ditto.
 897         * solib-target.c: Ditto.
 898         * solib.c: Ditto.
 899         * somread.c: Ditto.
 900         * source.c: Ditto.
 901         * stabsread.c: Ditto.
 902         * stabsread.c: Ditto.
 903         * stack.c: Ditto.
 904         * stack.h: Ditto.
 905         * symfile-mem.c: Ditto.
 906         * symfile.c: Ditto.
 907         * symfile.h: Ditto.
 908         * symmisc.c: Ditto.
 909         * symtab.c: Ditto.
 910         * symtab.h: Ditto.
 911         * target-descriptions.c: Ditto.
 912         * target-memory.c: Ditto.
 913         * target.c: Ditto.
 914         * target.h: Ditto.
 915         * terminal.h: Ditto.
 916         * thread.c: Ditto.
 917         * top.c: Ditto.
 918         * tracepoint.c: Ditto.
 919         * tracepoint.h: Ditto.
 920         * ui-file.c: Ditto.
 921         * ui-file.h: Ditto.
 922         * ui-out.h: Ditto.
 923         * user-regs.c: Ditto.
 924         * user-regs.h: Ditto.
 925         * utils.c: Ditto.
 926         * valarith.c: Ditto.
 927         * valops.c: Ditto.
 928         * valprint.c: Ditto.
 929         * valprint.h: Ditto.
 930         * value.c: Ditto.
 931         * varobj.c: Ditto.
 932         * varobj.h: Ditto.
 933         * vec.h: Ditto.
 934         * xcoffread.c: Ditto.
 935         * xcoffsolib.c: Ditto.
 936         * xcoffsolib.h: Ditto.
 937         * xml-syscall.c: Ditto.
 938         * xml-tdesc.c: Ditto.
 939
 940 2011-01-05  Michael Snyder  <msnyder@vmware.com>
 941
 942         * cli/cli-cmds.c: Shorten lines of >= 80 columns.
 943         * cli/cli-decode.c: Ditto.
 944         * cli/cli-dump.c: Ditto.
 945         * cli/cli-logging.c: Ditto.
 946         * cli/cli-script.c: Ditto.
 947         * cli/cli-setshow.c: Ditto.
 948         * common/signals.c: Ditto.
 949         * mi/mi-cmd-break.c: Ditto.
 950         * mi/mi-cmd-disas.c: Ditto.
 951         * mi/mi-cmd-stack.c: Ditto.
 952         * mi/mi-cmd-var.c: Ditto.
 953         * mi/mi-cmds.c: Ditto.
 954         * mi/mi-common.h: Ditto.
 955         * mi/mi-console.c: Ditto.
 956         * mi/mi-interp.c: Ditto.
 957         * mi/mi-main.c: Ditto.
 958         * osf-share/cma_attr.c: Ditto.
 959         * osf-share/cma_deb_core.h: Ditto.
 960         * osf-share/cma_debug_client.h: Ditto.
 961         * osf-share/cma_handle.h: Ditto.
 962         * osf-share/cma_mutex.h: Ditto.
 963         * osf-share/cma_stack_int.h: Ditto.
 964         * osf-share/cma_tcb_defs.h: Ditto.
 965         * python/py-auto-load.c: Ditto.
 966         * python/py-breakpoint.c: Ditto.
 967         * python/py-cmd.c: Ditto.
 968         * python/py-frame.c: Ditto.
 969         * python/py-objfile.c: Ditto.
 970         * python/py-param.c: Ditto.
 971         * python/py-progspace.c: Ditto.
 972         * python/py-symbol.c: Ditto.
 973         * python/py-value.c: Ditto.
 974         * python/python-internal.h: Ditto.
 975         * python/python.c: Ditto.
 976         * tui/tui-data.c: Ditto.
 977         * tui/tui-disasm.c: Ditto.
 978         * tui/tui-hooks.c: Ditto.
 979         * tui/tui-io.c: Ditto.
 980         * tui/tui-layout.c: Ditto.
 981         * tui/tui-regs.c: Ditto.
 982         * tui/tui-source.c: Ditto.
 983         * tui/tui-stack.c: Ditto.
 984         * tui/tui-win.c: Ditto.
 985         * tui/tui-windata.c: Ditto.
 986         * tui/tui-winsource.c: Ditto.
 987
 988 2011-01-05  Joel Brobecker  <brobecker@adacore.com>
 989
 990         * configure.ac, gdb.1: Copyright year update.
 991
 992 2011-01-03  Jan Kratochvil  <jan.kratochvil@redhat.com>
 993
 994         * frame.c (get_prev_frame_1) <UNWIND_INNER_ID>: New variables
 995         this_pc_in_block, morestack_msym and morestack_name.  Check for
 996         "__morestack" minimal symbol there.
 997
 998 2011-01-03  Joel Brobecker  <brobecker@adacore.com>
 999
1000         * symfile.c (find_sym_fns): Add call to dont_repeat.
1001
1002 2011-01-01  Joel Brobecker  <brobecker@adacore.com>
1003
1004         Copyright year update in most files (performed by copyright.sh).
1005
1006 2011-01-01  Joel Brobecker  <brobecker@adacore.com>
1007
1008         * top.c (print_gdb_version): Update copyright year in version output.
1009
1010 For older changes see ChangeLog-2010.
1011 \f
1012 Local Variables:
1013 mode: change-log
1014 left-margin: 8
1015 fill-column: 74
1016 version-control: never
1017 coding: utf-8
1018 End: