gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (tui_display_registers_from)
   4         (tui_display_registers_from_line): Don't declare.
   5         * tui/tui-windata.c (tui_data_window::display_all_data)
   6         (tui_data_window::refresh_all)
   7         (tui_data_window::do_scroll_vertical): Update.
   8         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
   9         from tui_display_registers_from.
  10         (tui_display_reg_element_at_line): Update.
  11         (tui_data_window::display_registers_from_line): Rename from
  12         tui_display_registers_from_line.
  13         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
  14         display_registers_from_line>: New methods.
  15
  16 2019-07-17  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
  19         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
  20         from tui_erase_data_content.
  21         (tui_data_window::display_all_data)
  22         (tui_data_window::refresh_all)
  23         (tui_data_window::do_scroll_vertical): Update.
  24         * tui/tui-regs.c (tui_show_registers): Update.
  25         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
  26         New method.
  27
  28 2019-07-17  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
  31         declare.
  32         * tui/tui-windata.c
  33         (tui_data_window::delete_data_content_windows): Rename from
  34         tui_delete_data_content_windows.
  35         (tui_data_window::display_all_data)
  36         (tui_data_window::do_scroll_vertical): Update.
  37         * tui/tui-data.h (struct tui_data_window)
  38         <delete_data_content_windows>: New method.
  39
  40 2019-07-17  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
  43         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
  44
  45 2019-07-17  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-windata.h (tui_display_all_data): Don't declare.
  48         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
  49         from tui_display_all_data.
  50         * tui/tui-win.c
  51         (tui_data_window::do_make_visible_with_new_height): Update.
  52         * tui/tui-regs.c (tui_show_registers): Update.
  53         * tui/tui-layout.c (tui_set_layout): Update.
  54         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
  55         method.
  56
  57 2019-07-17  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-windata.h (tui_display_data_from): Don't declare.
  60         * tui/tui-windata.c (tui_display_data_from): Remove.
  61         (tui_data_window::refresh_all): Update.
  62
  63 2019-07-17  Tom Tromey  <tom@tromey.com>
  64
  65         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
  66         * tui/tui-windata.c (tui_display_data_from_line): Remove.
  67         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
  68         tui_display_registers_from_line.
  69         * tui/tui-regs.h (tui_display_registers_from_line): Update.
  70         * tui/tui-regs.c (tui_display_registers_from_line): Remove
  71         "force_display" parameter.
  72
  73 2019-07-17  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
  76         declare.
  77         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
  78         Rename from tui_first_reg_element_no_inline.
  79         (tui_display_reg_element_at_line)
  80         (tui_display_registers_from_line): Update.
  81         * tui/tui-data.h (struct tui_data_window)
  82         <first_reg_element_no_inline>: New method.
  83
  84 2019-07-17  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-windata.c (tui_display_data_from)
  87         (tui_data_window::do_scroll_vertical): Update.
  88         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
  89         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
  90         Rename from tui_line_from_reg_element_no.
  91         (tui_display_registers_from_line): Update.
  92         * tui/tui-data.h (struct tui_data_window)
  93         <line_from_reg_element_no>: New method.
  94
  95 2019-07-17  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
  98         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
  99         tui_last_regs_line_no.
 100         (tui_display_reg_element_at_line)
 101         (tui_display_registers_from_line): Update.
 102         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 103         method.
 104
 105 2019-07-17  Tom Tromey  <tom@tromey.com>
 106
 107         PR tui/24722:
 108         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 109         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 110         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 111         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 112         (tui_update_breakpoint_info): Likewise.
 113         * tui/tui-hooks.c (tui_event_create_breakpoint)
 114         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 115         Update.
 116
 117 2019-07-17  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 120
 121 2019-07-17  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-winsource.c (tui_update_source_window_as_is)
 124         (tui_update_source_windows_with_addr): Update.
 125         * tui/tui-source.h (tui_set_source_content)
 126         (tui_show_symtab_source): Add "win_info" parameter.
 127         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 128         parameter.
 129         (tui_show_symtab_source): Likewise.
 130
 131 2019-07-17  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-wingeneral.c
 134         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 135
 136 2019-07-17  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 139         (struct tui_cmd_window) <can_scroll>: New method.
 140         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 141         method.
 142
 143 2019-07-17  Tom Tromey  <tromey@adacore.com>
 144
 145         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 146         do_field_signed>: Rename.  Change type of "value".
 147         * ui-out.c (ui_out::field_signed): Rename from field_int.
 148         Change type of "value".
 149         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 150         type of "value".
 151         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 152         do_field_int.  Change type of "value".
 153         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 154         do_field_int.  Change type of "value".
 155         * tracepoint.c (trace_status_mi, tfind_1)
 156         (print_one_static_tracepoint_marker): Update.
 157         * thread.c (print_thread_info_1, print_selected_thread_frame):
 158         Update.
 159         * stack.c (print_frame, print_frame_info): Update.
 160         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 161         Update.
 162         * source.c (print_source_lines_base): Update.
 163         * skip.c (info_skip_command): Update.
 164         * record-btrace.c (btrace_ui_out_decode_error)
 165         (btrace_call_history_src_line): Update.
 166         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 167         Update.
 168         * progspace.c (print_program_space): Update.
 169         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 170         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 171         do_field_int.  Change type of "value".
 172         * mi/mi-out.c (mi_ui_out::do_table_begin)
 173         (mi_ui_out::do_table_header): Update.
 174         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 175         type of "value".
 176         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 177         (mi_cmd_data_list_changed_registers, output_register)
 178         (mi_cmd_data_read_memory, mi_load_progress)
 179         (mi_cmd_trace_frame_collected): Update.
 180         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 181         Update.
 182         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 183         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 184         (mi_cmd_var_list_children, varobj_update_one): Update.
 185         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 186         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 187         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 188         * inferior.c (print_inferior): Update.
 189         * gdb_bfd.c (print_one_bfd): Update.
 190         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 191         Update.
 192         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 193         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 194         do_field_int.  Change type of "value".
 195         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 196         do_field_int.  Change type of "value".
 197         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 198         (print_one_breakpoint_location, print_it_catch_fork)
 199         (print_one_catch_fork, print_it_catch_vfork)
 200         (print_one_catch_vfork, print_it_catch_solib)
 201         (print_it_catch_exec, print_it_ranged_breakpoint)
 202         (print_mention_watchpoint, print_mention_masked_watchpoint)
 203         (bkpt_print_it, update_static_tracepoint): Update.
 204         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 205         * break-catch-syscall.c (print_it_catch_syscall): Update.
 206         * ada-tasks.c (print_ada_task_info): Update.
 207         * ada-lang.c (print_it_exception, print_mention_exception):
 208         Update.
 209
 210 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 211
 212         PR breakpoints/24541
 213         * gdbarch.c: Regenerate.
 214         * gdbarch.h: Regenerate.
 215         * gdbarch.sh: Adjust return type and parameter types for
 216         'stap_adjust_register'.
 217         (i386_stap_adjust_register): Adjust signature and return new
 218         register name.
 219         * stap-probe.c (stap_parse_register_operand): Adjust use of
 220         'gdbarch_stap_adjust_register'.
 221
 222 2019-07-17  Tom Tromey  <tromey@adacore.com>
 223
 224         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 225         declare VEC.
 226         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 227         std::vector.
 228         (struct s390_process_info): Add initializers.
 229         (s390_add_process): Use new.
 230         (s390_linux_nat_target::low_forget_process): Use delete.
 231         (s390_linux_nat_target::low_new_fork)
 232         (s390_linux_nat_target::stopped_by_watchpoint)
 233         (s390_linux_nat_target::low_prepare_to_resume)
 234         (s390_linux_nat_target::insert_watchpoint)
 235         (s390_linux_nat_target::insert_hw_breakpoint)
 236         (s390_linux_nat_target::remove_watchpoint)
 237         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 238
 239 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 240
 241         * aarch64-fbsd-nat.c: Include regcache.h.
 242         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 243         argument.
 244         (aarch64_fbsd_nat_target::fetch_registers)
 245         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 246         variable.
 247         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 248
 249 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 250
 251         * fbsd-nat.c: Include gdbarch.h.
 252
 253 2019-07-15  Tom Tromey  <tromey@adacore.com>
 254
 255         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 256
 257 2019-07-15  Tom Tromey  <tromey@adacore.com>
 258
 259         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 260         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 261         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 262         * cli-out.c (cli_ui_out::do_field_int): New method.
 263         * ui-out.c (ui_out::field_unsigned): New method.
 264         * symfile.c (generic_load): Use field_unsigned.
 265         (print_transfer_performance): Likewise.
 266         * record-btrace.c (ui_out_field_uint): Remove.
 267         (btrace_call_history_insn_range, btrace_call_history): Use
 268         field_unsigned.
 269         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 270         field_unsigned.
 271         * ui-out.h (class ui_out) <field_unsigned>: New method.
 272         <do_field_unsigned>: Likewise.
 273
 274 2019-07-15  Tom Tromey  <tromey@adacore.com>
 275
 276         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 277         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 278         * target.c (flash_erase_command): Use field_string.
 279         * infrun.c (print_signal_received_reason): Use field_string.
 280         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 281         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 282         field_string.
 283         * ada-tasks.c (print_ada_task_info): Use field_string.
 284
 285 2019-07-15  Tom Tromey  <tromey@adacore.com>
 286
 287         * target.c (flash_erase_command): Use field_core_addr.
 288         * symfile.c (generic_load): Use field_core_addr.
 289         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 290         Use field_core_addr.
 291         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 292         field_core_addr.
 293
 294 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 295
 296         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 297         value if its desired type is smaller than a CORE_ADDR and signed.
 298
 299 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 300
 301         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 302         of changes to field names, and use new is_reference field to
 303         decide if a property is a reference or not.
 304         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 305         field.
 306         (struct dwarf2_property_baton): Update header comment, rename
 307         'referenced_type' to 'property_type' and update comments.
 308         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 309         default property type, store in property baton, update to take
 310         accound of renamed field.
 311         (read_func_scope): Update call to attr_to_dynamic_prop.
 312         (read_array_type): Likewise.
 313         (dwarf2_per_cu_addr_sized_int_type): New function.
 314         (read_subrange_index_type): Move type finding code to
 315         dwarf2_per_cu_addr_sized_int_type.
 316         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 317         (dwarf2_per_cu_addr_type): New function.
 318         (set_die_type): Update calls to attr_to_dynamic_prop.
 319
 320 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 321
 322         * dwarf2read.c (read_subrange_index_type): New function.
 323         (read_subrange_type): Move code into new function and call it.
 324         * gdbtypes.c (create_range_type): Add some asserts.
 325
 326 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 327
 328         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 329         update return statements.
 330         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 331         declaration, and update comment to match.
 332         * gdbtypes.c (resolve_dynamic_array): Update call to
 333         dwarf2_evaluate_property to match new return type.
 334
 335 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 336
 337         * valarith.c (value_subscripted_rvalue): Change lowerbound
 338         parameter type from int to LONGEST.
 339         * value.h (value_subscripted_rvalue): Likewise in declaration.
 340
 341 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 342
 343         * cli/cli-utils.c (info_print_command_completer): New function.
 344         * cli/cli-utils.h: Add 'completer.h' include, and forward
 345         declaration for 'struct cmd_list_element'.
 346         (info_print_command_completer): Declare.
 347         * stack.c (_initialize_stack): Add completer for 'info locals' and
 348         'info args'.
 349         * symtab.c (_initialize_symtab): Add completer for 'info
 350         variables' and 'info functions'.
 351         * NEWS: Mention completion for additional info commands.
 352
 353 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 354
 355         * cli/cli-utils.c (extract_info_print_args): Delete.
 356         (extract_arg_maybe_quoted): Delete.
 357         (info_print_options_defs): New variable.
 358         (make_info_print_options_def_group): New function.
 359         (extract_info_print_options): Define new function.
 360         * cli/cli-utils.h (extract_info_print_args): Delete.
 361         (struct info_print_options): New structure.
 362         (extract_info_print_options): Declare new function.
 363         * stack.c (info_locals_command): Update to use new
 364         extract_info_print_options, also add a header comment.
 365         (info_args_command): Likewise.
 366         * symtab.c (info_variables_command): Likewise.
 367         (info_functions_command): Likewise.
 368
 369 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 370
 371         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 372         to extract string arguments.
 373         * common/common-utils.c (extract_string_maybe_quoted): New function.
 374         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 375
 376 2019-07-11  Tom Tromey  <tromey@adacore.com>
 377
 378         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 379         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 380         * top.h (gdbinit): Don't declare.
 381         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 382         into...
 383         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 384         * top.c (gdb_init): Don't call init_cli_cmds.
 385         (gdbinit): Remove.
 386         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 387
 388 2019-07-11  Tom Tromey  <tromey@adacore.com>
 389
 390         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 391         after it has been moved.
 392
 393 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 394
 395         * valops.c (value_must_coerce_to_target): Change return type to
 396         bool.
 397         * value.h (value_must_coerce_to_target): Likewise.
 398
 399 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 400
 401         * breakpoint.c (is_hardware_watchpoint): Remove
 402         forward-declaration.
 403         (is_masked_watchpoint): Change return type to bool.
 404         (is_tracepoint): Likewise.
 405         (is_breakpoint): Likewise.
 406         (is_hardware_watchpoint): Likewise.
 407         (is_watchpoint): Likewise.
 408         (is_no_memory_software_watchpoint): Likewise.
 409         (is_catchpoint): Likewise.
 410         (breakpoint_1): Make FILTER parameter's return type bool.
 411         is_masked_watchpoint): Change return type to bool.
 412         (save_breakpoints): Make FILTER parameter's return type bool.
 413         * breakpoint.h (is_breakpoint): Change return type to bool.
 414         (is_watchpoint): Likewise.
 415         (is_catchpoint): Likewise.
 416         (is_tracepoint): Likewise.
 417
 418 2019-07-10  Tom Tromey  <tom@tromey.com>
 419
 420         * defs.h: Don't include gdbarch.h.
 421         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 422         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 423         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 424         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 425         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 426         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 427         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 428         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 429         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 430         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 431         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 432         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 433         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 434         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 435         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 436         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 437         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 438         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 439         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 440         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 441         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 442         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 443         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 444         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 445         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 446         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 447         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 448
 449 2019-07-10  Tom Tromey  <tromey@adacore.com>
 450
 451         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 452         * breakpoint.c (init_ada_exception_breakpoint): Register as
 453         bp_catchpoint.
 454         (print_one_breakpoint_location, print_one_breakpoint): Use
 455         is_ada_exception_catchpoint.
 456         * ada-lang.c (class ada_catchpoint_location): Pass
 457         bp_loc_software_breakpoint to bp_location constructor.
 458         (is_ada_exception_catchpoint): New function.
 459
 460 2019-07-10  Tom Tromey  <tromey@adacore.com>
 461
 462         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 463         VEC.
 464         (struct arm_exidx_entry): New method operator<.
 465         (struct arm_exidx_data) <section_maps>: Change type.
 466         (arm_exidx_data_free): Remove.
 467         (arm_exidx_data_key): Change type.  Move lower.
 468         (arm_exidx_new_objfile): Update.
 469         (arm_compare_exidx_entries): Remove.
 470         (arm_find_exidx_entry, _initialize_arm_tdep)
 471
 472 2019-07-10  Tom Tromey  <tromey@adacore.com>
 473
 474         * solib-spu.c (ocl_program_data_key): Change type.
 475         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 476         Update.
 477
 478 2019-07-10  Tom Tromey  <tromey@adacore.com>
 479
 480         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 481         (struct solib_aix_inferior_data) <library_list>: Change type.
 482         (solib_aix_inferior_data_handle): Change type.
 483         (get_solib_aix_inferior_data): Update.
 484         (solib_aix_free_library_list): Remove.
 485         (library_list_start_library): Update.
 486         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 487         return type.
 488         (solib_aix_get_library_list)
 489         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 490         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 491
 492 2019-07-10  Tom Tromey  <tromey@adacore.com>
 493
 494         * solib-dsbt.c (struct dsbt_info): Add initializers.
 495         (solib_dsbt_pspace_data): Change type.
 496         (dsbt_pspace_data_cleanup): Remove.
 497         (get_dsbt_info, _initialize_dsbt_solib): Update.
 498
 499 2019-07-10  Tom Tromey  <tromey@adacore.com>
 500
 501         * spu-tdep.c (spu_overlay_data): Change type.
 502         (spu_get_overlay_table, spu_overlay_new_objfile)
 503         (_initialize_spu_tdep): Update.
 504
 505 2019-07-10  Tom Tromey  <tromey@adacore.com>
 506
 507         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 508         destructor.
 509         (dbx_objfile_data_key): Change type and declare later.
 510         (DBX_SYMFILE_INFO): Rewrite.
 511         * dbxread.c (dbx_objfile_data_key): Change type.
 512         (dbx_symfile_init): Update.
 513         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 514         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 515         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 516
 517 2019-07-10  Tom Tromey  <tromey@adacore.com>
 518
 519         * jit.c (jit_program_space_key): Change type.  Move lower.
 520         (get_jit_program_space_data): Update.
 521         (jit_program_space_data_cleanup): Remove.
 522         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 523         Update.
 524         (struct jit_program_space_data): Add initializers.
 525
 526 2019-07-10  Tom Tromey  <tromey@adacore.com>
 527
 528         * solib-darwin.c (struct darwin_info): Add initializers.
 529         (solib_darwin_pspace_data): Change type.
 530         (darwin_pspace_data_cleanup): Remove.
 531         (get_darwin_info, _initialize_darwin_solib): Update.
 532
 533 2019-07-10  Tom Tromey  <tromey@adacore.com>
 534
 535         * remote-sim.c (struct sim_inferior_data): Add initializers,
 536         constructor, and destructor.
 537         (sim_inferior_data_key): Change type.  Move lower.
 538         (check_for_duplicate_sim_descriptor): Update.
 539         (get_sim_inferior_data): Use new.  Update.
 540         (~sim_inferior_data_cleanup): Rename from
 541         sim_inferior_data_cleanup.  Simplify.
 542         (gdbsim_close_inferior, simulator_command)
 543         (sim_command_completer, _initialize_remote_sim): Update.
 544         (next_pid, INITIAL_PID): Move earlier.
 545
 546 2019-07-10  Tom Tromey  <tromey@adacore.com>
 547
 548         * python/python-internal.h (create_thread_object): Return
 549         gdbpy_ref.
 550         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 551         * python/py-inferior.c (struct threadlist_entry): Add
 552         constructor.
 553         <thread_obj>: Now a gdbpy_ref.
 554         (thread_to_thread_object): Update.
 555         (add_thread_object): Use new.
 556         (delete_thread_object): Use delete.
 557         (infpy_threads): Update.
 558         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 559         GIL.
 560
 561 2019-07-10  Tom Tromey  <tromey@adacore.com>
 562
 563         * valops.c (value_cast): Specialize error message for Ada.
 564
 565 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 566
 567         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 568
 569 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 570
 571         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 572         bpstat_should_step): Return bool, adjust comments.
 573         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 574         bpstat_should_step): Likewise.
 575
 576 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 577
 578         * features/Makefile: Use feature target descriptions for Arm.
 579         * features/arm/arm-core.c: Generate new file.
 580         * features/arm/arm-fpa.c: Likewise.
 581         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 582         * features/arm/arm-m-profile.c: Likewise.
 583         * features/arm/arm-vfpv2.c: Likewise.
 584         * features/arm/arm-vfpv3.c: Likewise.
 585         * features/arm/xscale-iwmmxt.c: Likewise.
 586         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 587
 588 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 589
 590         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 591         ptrace earlier.
 592
 593 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 594
 595         * features/aarch64-pauth.c: Regenerate.
 596
 597 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 598
 599         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 600         bool.
 601         (bpstat_what): Use false instead of 0.
 602
 603 2019-07-09  Pedro Alves  <palves@redhat.com>
 604
 605         * break-catch-throw.c (is_exception_catchpoint): New.
 606         * breakpoint.c (print_one_breakpoint_location): New parameter
 607         'raw_loc'.  Handle it.  Use
 608         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 609         looking at the breakpoint's type.
 610         (print_one_breakpoint): If handling "maint info breakpoints", also
 611         print locations of exception catchpoints.
 612         * breakpoint.h (is_exception_catchpoint): Declare.
 613
 614 2019-07-09  Pedro Alves  <palves@redhat.com>
 615
 616         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 617         "addr" field.
 618         (allocate_location_exception_catchpoint): New.
 619         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 620         (initialize_throw_catchpoint_ops): Install
 621         allocate_location_exception_catchpoint as allocate_location
 622         method.
 623         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 624         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 625         bp_loc_other.
 626         (breakpoint_address_is_meaningful): Delete.
 627         (bl_address_is_meaningful): New.
 628         (breakpoint_locations_match): Adjust comment.
 629         (bp_location_from_bp_type): New, factored out of...
 630         (bp_location::bp_location(breakpoint *)): ... this.
 631         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 632         factored out of...
 633         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 634         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 635         breakpoint_address_is_meaningful.
 636         (bp_locations_compare): Adjust comment.
 637         (update_global_location_list): Use bl_address_is_meaningful
 638         instead of breakpoint_address_is_meaningful.
 639         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 640         explicit.
 641         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 642         * python/py-breakpoint.c (bppy_get_location): No longer check
 643         whether location is null.
 644
 645 2019-07-09  Pedro Alves  <palves@redhat.com>
 646
 647         PR c++/15468
 648         * breakpoint.c (print_one_breakpoint_location): Remove
 649         single-location assert.
 650
 651 2019-07-09  Tom Tromey  <tom@tromey.com>
 652
 653         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 654         * configure: Rebuild.
 655         * configure.ac: Change common to gdbsupport.
 656         * gdbsupport: Rename from common.
 657         * acinclude.m4: Change common to gdbsupport.
 658         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 659         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 660         gdbsupport.
 661         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 662         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 663         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 664         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 665         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 666         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 667         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 668         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 669         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 670         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 671         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 672         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 673         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 674         coff-pe-read.c, command.h, compile/compile-c-support.c,
 675         compile/compile-c.h, compile/compile-cplus-symbols.c,
 676         compile/compile-cplus-types.c, compile/compile-cplus.h,
 677         compile/compile-loc2c.c, compile/compile.c, completer.c,
 678         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 679         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 680         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 681         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 682         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 683         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 684         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 685         features/aarch64-core.c, features/aarch64-fpu.c,
 686         features/aarch64-pauth.c, features/aarch64-sve.c,
 687         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 688         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 689         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 690         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 691         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 692         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 693         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 694         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 695         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 696         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 697         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 698         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 699         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 700         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 701         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 702         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 703         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 704         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 705         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 706         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 707         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 708         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 709         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 710         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 711         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 712         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 713         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 714         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 715         minsyms.c, mips-linux-tdep.c, namespace.h,
 716         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 717         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 718         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 719         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 720         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 721         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 722         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 723         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 724         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 725         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 726         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 727         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 728         procfs.c, producer.c, progspace.h, psymtab.h,
 729         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 730         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 731         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 732         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 733         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 734         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 735         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 736         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 737         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 738         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 739         target-memory.c, target.c, target.h, target/waitstatus.c,
 740         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 741         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 742         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 743         unittests/array-view-selftests.c,
 744         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 745         unittests/common-utils-selftests.c,
 746         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 747         unittests/format_pieces-selftests.c,
 748         unittests/function-view-selftests.c,
 749         unittests/lookup_name_info-selftests.c,
 750         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 751         unittests/mkdir-recursive-selftests.c,
 752         unittests/observable-selftests.c,
 753         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 754         unittests/parse-connection-spec-selftests.c,
 755         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 756         unittests/scoped_fd-selftests.c,
 757         unittests/scoped_mmap-selftests.c,
 758         unittests/scoped_restore-selftests.c,
 759         unittests/string_view-selftests.c, unittests/style-selftests.c,
 760         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 761         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 762         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 763         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 764         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 765         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 766
 767 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 768
 769         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 770         bool value.
 771         (decode_digits_ordinary): Set explicit_line field in sal.
 772         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 773         symtab_and_line that was set on an explicit line number in
 774         assembler code.  Do always update the recorded symtab and line if
 775         we do skip the prologue.
 776
 777 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 778
 779         * breakpoint.c (set_breakpoint_location_function): Remove
 780         explicit_loc parameter.
 781         (momentary_breakpoint_from_master): Update call to
 782         set_breakpoint_location_function.
 783         (add_location_to_breakpoint): Likewise.
 784
 785 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 786
 787         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 788         required features based on default bfd type when no specific bfd
 789         is present.
 790
 791 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 792
 793         * NEWS: Mention that GDB printf and eval commands can now print
 794         C-style and Ada-style convenience var strings without
 795         calling the inferior.
 796         * printcmd.c (printf_c_string): Locally print GDB internal var
 797         instead of transiting via the inferior.
 798         (printf_wide_c_string): Likewise.
 799
 800 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 801
 802         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 803
 804 2019-07-04  Tom Tromey  <tom@tromey.com>
 805
 806         PR tui/24724:
 807         * tui/tui-winsource.c (tui_clear_source_content): Update.
 808         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 809         (tui_update_breakpoint_info): Update.
 810         (tui_set_exec_info_content): Update.
 811         * tui/tui-source.c (tui_set_source_content_nil): Update.
 812         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 813         has_break.
 814         * tui/tui-data.h (enum tui_bp_flag): New.
 815         (tui_bp_flags): New enum flags type.
 816         (struct tui_source_element) <break_mode>: Change type.  Rename
 817         from has_break.
 818         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 819         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 820         constants.
 821         * tui/tui-winsource.h: Fix comment.
 822
 823 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 824
 825         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 826         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 827         (store_fpregs_to_thread)
 828         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 829         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 830         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 831         (IWMMXT_REGS_SIZE): Add define.
 832         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 833         (fetch_vfp_regs, store_vfp_regs)
 834         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 835         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 836
 837 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 838
 839         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 840         defines.
 841         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 842         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 843         (ARM_INT_REGISTER_SIZE): ...to this.
 844         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 845         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 846         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 847         (arm_linux_collect_gregset, supply_nwfpe_register)
 848         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 849         defines.
 850         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 851         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 852         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 853         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 854         (arm_return_in_memory, arm_store_return_value)
 855         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 856         (arm_record_ld_st_multiple): Likewise.
 857         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 858         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 859
 860 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 861
 862         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 863         AARCH64_DISPLACED_MODIFIED_INSNS.
 864         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 865         (aarch64_displaced_step_copy_insn): Likewise.
 866         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 867         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 868         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 869         ARM_DISPLACED_MODIFIED_INSNS.
 870         * arm-tdep.c (arm_gdbarch_init): Likewise.
 871         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 872         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 873         (struct arm_displaced_step_closure): Use
 874         ARM_DISPLACED_MODIFIED_INSNS.
 875
 876 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 877
 878         * features/Makefile: Remove unused xml files.
 879         * features/aarch64.xml: Remove.
 880         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 881         * features/i386/amd64-avx-avx512.xml: Remove.
 882         * features/i386/amd64-avx-linux.xml: Remove.
 883         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 884         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 885         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 886         * features/i386/amd64-avx-mpx.xml: Remove.
 887         * features/i386/amd64-avx.xml: Remove.
 888         * features/i386/amd64-linux.xml: Remove.
 889         * features/i386/amd64-mpx-linux.xml: Remove.
 890         * features/i386/amd64-mpx.xml: Remove.
 891         * features/i386/amd64.xml: Remove.
 892         * features/i386/i386-avx-avx512-linux.xml: Remove.
 893         * features/i386/i386-avx-avx512.xml: Remove.
 894         * features/i386/i386-avx-linux.xml: Remove.
 895         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 896         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 897         * features/i386/i386-avx-mpx-linux.xml: Remove.
 898         * features/i386/i386-avx-mpx.xml: Remove.
 899         * features/i386/i386-avx.xml: Remove.
 900         * features/i386/i386-linux.xml: Remove.
 901         * features/i386/i386-mmx-linux.xml: Remove.
 902         * features/i386/i386-mmx.xml: Remove.
 903         * features/i386/i386-mpx-linux.xml: Remove.
 904         * features/i386/i386-mpx.xml: Remove.
 905         * features/i386/i386.xml: Remove.
 906         * features/i386/x32-avx-avx512-linux.xml: Remove.
 907         * features/i386/x32-avx-linux.xml: Remove.
 908         * features/i386/x32-linux.xml: Remove.
 909
 910 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 911
 912         * regformats/aarch64.dat: Remove.
 913         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 914         * regformats/i386/amd64-avx-linux.dat: Remove.
 915         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 916         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 917         * regformats/i386/amd64-linux.dat: Remove.
 918         * regformats/i386/amd64-mpx-linux.dat: Remove.
 919         * regformats/i386/amd64.dat: Remove.
 920         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 921         * regformats/i386/i386-avx-linux.dat: Remove.
 922         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 923         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 924         * regformats/i386/i386-linux.dat: Remove.
 925         * regformats/i386/i386-mmx-linux.dat: Remove.
 926         * regformats/i386/i386-mpx-linux.dat: Remove.
 927         * regformats/i386/i386.dat: Remove.
 928         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 929         * regformats/i386/x32-avx-linux.dat: Remove.
 930         * regformats/i386/x32-linux.dat: Remove.
 931
 932 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 933
 934         * aarch64-tdep.c: Remove xml self tests.
 935         * amd64-linux-tdep.c: Likewise.
 936         * amd64-tdep.c: Likewise.
 937         * i386-linux-tdep.c: Likewise.
 938         * i386-tdep.c: Likewise.
 939
 940 2019-07-03  Pedro Alves  <palves@redhat.com>
 941
 942         PR cli/24732
 943         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 944         (pipe_cmd_option_defs): New.
 945         (make_pipe_cmd_options_def_group): New.
 946         (pipe_command): Use gdb::option::process_options.
 947         (pipe_command_completer): New function.
 948         (_initialize_cli_cmds): Install completer for "pipe" command.
 949
 950 2019-07-03  Pedro Alves  <palves@redhat.com>
 951
 952         * cli/cli-option.c (union option_value) <string>: New field.
 953         (struct option_def_and_value): Add ctor, move ctor, dtor and
 954         use DISABLE_COPY_AND_ASSIGN.
 955         (option_def_and_value::clear_value): New.
 956         (parse_option, save_option_value_in_ctx, get_val_type_str)
 957         (add_setshow_cmds_for_options): Handle var_string.
 958         * cli-option.h (union option_def::var_address) <string>: New
 959         field.
 960         (struct string_option_def): New.
 961         * maint-test-options.c (struct test_options_opts): Add default
 962         ctor and use DISABLE_COPY_AND_ASSIGN.
 963         <string_opt>: New field.
 964         (test_options_opts::~test_options_opts): New.
 965         (test_options_opts::dump): Also dump "-string".
 966         (test_options_option_defs): Install "string.
 967
 968 2019-07-03  Pedro Alves  <palves@redhat.com>
 969
 970         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 971         option_value with a null enumeration.
 972         (complete_options): Save the option values in the context.
 973         (save_option_value_in_ctx): New, factored out from ...
 974         (process_options): ... here.
 975         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 976         of the function.
 977         * maint-test-options.c (test_options_opts::dump): New, factored
 978         out from ...
 979         (maintenance_test_options_command_mode): ... here.
 980         (maintenance_test_options_command_completion_result): Delete.
 981         (maintenance_test_options_command_completion_text): Update
 982         comment.
 983         (maintenance_show_test_options_completion_result): Change
 984         prototype.  Just print
 985         maintenance_test_options_command_completion_text.
 986         (save_completion_result): New.
 987         (maintenance_test_options_completer_mode): Pass options context to
 988         complete_options, and then save a dump.
 989         (_initialize_maint_test_options): Use add_cmd to install "maint
 990         show test-options-completion-result".
 991
 992 2019-07-03  Pedro Alves  <palves@redhat.com>
 993
 994         * NEWS (New commands): Mention "with" and "maint with".
 995         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 996         (with_command, with_command_completer): New.
 997         (pipe_command): Adjust to new repeat_previous
 998         interface.
 999         (_initialize_cli_cmds): Install the "with" command and its "w"
1000         alias.
1001         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1002         declarations.
1003         * cli/cli-setshow.c (parse_cli_var_uinteger)
1004         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1005         argument strings for all var_types.
1006         (get_setshow_command_value_string): New, factored out from ...
1007         (do_show_command): ... this.
1008         * cli/cli-setshow.h: Include <string>.
1009         (get_setshow_command_value_string): Declare.
1010         * command.h (repeat_previous): Now returns const char *.  Adjust
1011         comment.
1012         * maint.c: Include "cli/cli-cmds.h".
1013         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1014         (_initialize_maint_cmds): Register the "maintenance with" command.
1015         * top.c (repeat_previous): Move bits from pipe_command here:
1016         Return the saved command line, if any; error out if there's no
1017         command to relaunch.
1018
1019 2019-07-03  Pedro Alves  <palves@redhat.com>
1020
1021         * NEWS (New commands): Mention "maint set/show test-settings"
1022         instead of "maint test-settings".
1023         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1024         (maintenance_test_settings_set_list): Rename to ...
1025         (maintenance_set_test_settings_list): ... this.
1026         (maintenance_test_settings_show_list): Rename to  ...
1027         (maintenance_show_test_settings_list): ... this.
1028         (maintenance_test_settings_cmd): Delete.
1029         (maintenance_test_settings_set_cmd): ...
1030         (maintenance_set_test_settings_cmd): ... this.
1031         (maintenance_test_settings_show_cmd): ...
1032         (maintenance_show_test_settings_cmd): ... this.
1033         (maintenance_test_settings_show_value_cmd):
1034         (maintenance_show_test_settings_value_cmd): ... this.
1035         (_initialize_maint_test_settings): No longer install the "maint
1036         test-settings" prefix command.  Rename "maint test-settings set"
1037         to "maint set test-settings", and "maint test-settings show" to
1038         "maint show test-settings".  Adjust all subcommands.
1039
1040 2019-07-03  Pedro Alves  <palves@redhat.com>
1041
1042         * maint-test-settings.c: Fix file's intro comment.  Replace all
1043         references to "test-options" with references to "test-settings",
1044         in comments.
1045
1046 2019-07-03  Pedro Alves  <palves@redhat.com>
1047
1048         * maint-test-settings.c (maintenance_test_settings_xxx)
1049         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1050         New.
1051         (maintenance_test_settings_enums): Use them.
1052         (maintenance_test_settings_enum): Default to
1053         maintenance_test_settings_xxx.
1054         (_initialize_maint_test_settings): Initialize
1055         MAINTENANCE_TEST_SETTINGS_FILENAME.
1056
1057 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1058
1059         * breakpoint.h (remove_breakpoints_inf): Change return type to
1060         void, move function documentation here.
1061         * breakpoint.c (remove_breakpoints_inf): Change return type to
1062         void, move function documentation to header.
1063
1064 2019-07-02  Pedro Alves  <palves@redhat.com>
1065
1066         * NEWS (Completion improvements): Mention "info threads".
1067         * thread.c (struct info_threads_opts, info_threads_option_defs)
1068         (make_info_threads_options_def_group): New.
1069         (info_threads_command): Use gdb::option::process_options.
1070         (info_threads_command_completer): New.
1071         (_initialize_thread): Use gdb::option::build_help to build the
1072         help text for "info threads".
1073
1074 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1075
1076         * defs.h (generic_load): Move from here...
1077         * symfile.h (generic_load): ... to here.  Rename name parameter
1078         to args.
1079         * symfile.c (generic_load): Add comment.
1080
1081 2019-07-01  Tom Tromey  <tromey@adacore.com>
1082
1083         * dwarf2read.c
1084         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1085         declaration of without_params.  Fix formatting.
1086
1087 2019-07-01  Tom Tromey  <tromey@adacore.com>
1088
1089         * ada-exp.y (find_primitive_type): Update.
1090         * ada-lang.h (ada_lookup_symbol): Update.
1091         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1092         parameter.
1093         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1094
1095 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1096
1097         PR breakpoints/24541
1098         * gdbarch.c: Regenerate.
1099         * gdbarch.h: Regenerate.
1100         * gdbarch.sh: Add 'stap_adjust_register'.
1101         * i386-tdep.c: Include '<unordered_set>'.
1102         (i386_stap_adjust_register): New function.
1103         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1104         * stap-probe.c (stap_parse_register_operand): Call
1105         'gdbarch_stap_adjust_register'.
1106
1107 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1108
1109         PR python/24742
1110         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1111         * python/python.c (do_start_initialization): Use 'xmalloc'
1112         instead of 'PyMem_Malloc'.
1113
1114 2019-06-28  Tom Tromey  <tromey@adacore.com>
1115
1116         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1117         for Ada.
1118
1119 2019-06-27  Tom Tromey  <tromey@adacore.com>
1120
1121         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1122         objfile_key.
1123         (arm_find_mapping_symbol, arm_record_special_symbol)
1124         (_initialize_arm_tdep): Update.
1125         (arm_objfile_data_free): Remove.
1126
1127 2019-06-27  Tom Tromey  <tromey@adacore.com>
1128
1129         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1130         to cp_print_static_field.
1131
1132 2019-06-26  Tom Tromey  <tromey@adacore.com>
1133
1134         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1135         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1136         declare.
1137
1138 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1139
1140         * features/aarch64-core.c (create_feature_aarch64_core):
1141         Regenerate.
1142         * features/aarch64-core.xml: Add cpsr flags.
1143
1144 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1145
1146         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1147         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1148
1149 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1150
1151         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1152         field.
1153         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1154         use.
1155         (arm_record_special_symbol): Don't insert new symbol in sorted
1156         position, push it at the end.
1157
1158 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1159
1160         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1161         (arm_mapping_symbol_s): Remove.
1162         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1163         (arm_mapping_symbol_vec): New typedef.
1164         (struct arm_per_objfile): Add constructor.
1165         <section_maps>: Change type to
1166         std::unique_ptr<arm_mapping_symbol_vec[]>.
1167         (arm_compare_mapping_symbols): Remove.
1168         (arm_find_mapping_symbol): Adjust to section_maps type change.
1169         (arm_objfile_data_free): Call delete on arm_per_objfile.
1170         (arm_record_special_symbol): Adjust to section_maps type change.
1171         Allocate arm_per_objfile with new.
1172
1173 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1174
1175         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1176         with the command prefix.
1177
1178 2019-06-25  Tom Tromey  <tom@tromey.com>
1179
1180         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1181         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1182
1183 2019-06-25  Tom Tromey  <tom@tromey.com>
1184
1185         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1186         type.
1187         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1188         protected.
1189
1190 2019-06-25  Tom Tromey  <tom@tromey.com>
1191
1192         * tui/tui-winsource.c
1193         (tui_source_window_base::set_is_exec_point_at): Add check against
1194         LOA_ADDRESS.
1195
1196 2019-06-25  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-source.c (tui_set_source_content): Don't check before
1199         xfree.
1200         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1201
1202 2019-06-25  Tom Tromey  <tom@tromey.com>
1203
1204         * tui/tui-winsource.h (tui_update_source_window_as_is)
1205         (tui_alloc_source_buffer, tui_line_is_displayed)
1206         (tui_addr_is_displayed): Change type of win_info.
1207         * tui/tui-winsource.c (tui_update_source_window_as_is)
1208         (tui_clear_source_content, tui_show_source_line)
1209         (tui_show_source_content, tui_source_window_base::refill)
1210         (tui_source_window_base::set_is_exec_point_at)
1211         (tui_source_window_base::set_is_exec_point_at)
1212         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1213         (tui_alloc_source_buffer, tui_line_is_displayed)
1214         (tui_addr_is_displayed): Change type of win_info.  Update.
1215         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1216         (tui_source_window_base::do_make_visible_with_new_height):
1217         Update.
1218         * tui/tui-source.c (tui_set_source_content)
1219         (tui_set_source_content_nil)
1220         (tui_source_window::do_scroll_vertical): Update.
1221         * tui/tui-layout.c (show_layout): Update.
1222         * tui/tui-disasm.c (tui_set_disassem_content)
1223         (tui_disasm_window::do_scroll_vertical): Update.
1224         * tui/tui-data.h (tui_win_content): Remove.
1225         (struct tui_gen_win_info) <content, content_size>: Remove.
1226         (struct tui_source_element): Add initializers and destructor.
1227         (union tui_which_element, struct tui_win_element): Remove.
1228         (struct tui_source_window_base) <content>: New field.
1229         (struct tui_data_window): Remove destructor.
1230         (tui_alloc_content, tui_free_win_content)
1231         (tui_free_all_source_wins_content): Don't declare.
1232         * tui/tui-data.c (tui_initialize_static_data): Update.
1233         (init_content_element, tui_alloc_content): Remove.
1234         (~tui_gen_win_info): Update.
1235         (~tui_data_window, tui_free_all_source_wins_content)
1236         (tui_free_win_content, free_content, free_content_elements):
1237         Remove.
1238
1239 2019-06-25  Tom Tromey  <tom@tromey.com>
1240
1241         * tui/tui-winsource.h (tui_clear_source_content)
1242         (tui_erase_source_content, tui_show_source_content): Change type
1243         of win_info.
1244         * tui/tui-winsource.c (tui_clear_source_content)
1245         (tui_erase_source_content, tui_show_source_content): Change type
1246         of win_info.
1247         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1248         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1249         win_info.
1250         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1251         win_info.
1252         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1253
1254 2019-06-25  Tom Tromey  <tom@tromey.com>
1255
1256         * tui/tui-winsource.c (tui_clear_source_content)
1257         (tui_source_window_base::set_is_exec_point_at): Update.
1258         * tui/tui-source.c (tui_set_source_content_nil): Update.
1259         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1260         a bool.
1261         * tui/tui-data.c (init_content_element): Update.
1262
1263 2019-06-25  Tom Tromey  <tom@tromey.com>
1264
1265         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1266         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1267         * tui/tui-layout.c (init_and_make_win): Update.
1268         * tui/tui.h (enum tui_win_type): Update.
1269         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1270         tui_win_is_auxillary.
1271         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1272         tui_win_is_auxillary.
1273
1274 2019-06-25  Tom Tromey  <tom@tromey.com>
1275
1276         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1277         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1278         (tui_delete_data_content_windows, tui_display_all_data)
1279         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1280         Update.
1281         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1282         * tui/tui-regs.c (tui_last_regs_line_no)
1283         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1284         (tui_show_registers): Update.
1285         (tui_show_register_group): Return void.  Update.
1286         (tui_display_registers_from, tui_display_reg_element_at_line)
1287         (tui_display_registers_from_line, tui_check_register_values):
1288         Update.
1289         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1290         member.
1291         (struct tui_data_window) <regs_content>: Now a std::vector.
1292         <regs_content_count>: Remove.
1293         (tui_add_content_elements, tui_free_data_content): Don't declare.
1294         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1295         (init_content_element): Remove DATA_WIN case.  Add assert.
1296         (tui_add_content_elements): Remove.
1297         (tui_data_window): Update.
1298         (tui_free_data_content): Remove.
1299         (free_content_elements): Remove DATA_WIN case.
1300
1301 2019-06-25  Tom Tromey  <tom@tromey.com>
1302
1303         * tui/tui-data.c (tui_data_item_window): Update.
1304         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1305         * tui/tui-windata.c (tui_display_all_data)
1306         (tui_display_data_from_line): Update.
1307         (tui_check_data_values): Remove.
1308         * tui/tui-regs.c (tui_show_register_group)
1309         (tui_display_reg_element_at_line): Update.
1310         * tui/tui-hooks.c (tui_register_changed)
1311         (tui_refresh_frame_and_register_information): Call
1312         tui_check_register_values.
1313         * tui/tui-data.h (struct tui_data_window) <data_content,
1314         data_content_count, data_type>: Remove.
1315         (enum tui_data_type): Remove.
1316
1317         * tui/tui-data.c (tui_data_window::clear_detail)
1318         (~tui_data_window): Update.
1319
1320 2019-06-25  Tom Tromey  <tom@tromey.com>
1321
1322         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1323         declare.
1324         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1325         Rename from tui_first_data_item_displayed.  Update.
1326         (tui_data_window::refresh_all)
1327         (tui_data_window::do_scroll_vertical): Update.
1328         * tui/tui-data.h (struct tui_data_window)
1329         <first_data_item_displayed>: Declare new method.
1330
1331 2019-06-25  Tom Tromey  <tom@tromey.com>
1332
1333         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1334         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1335         contents...
1336         (tui_initialize_static_data): ...here.
1337
1338 2019-06-25  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1341         (tui_display_registers_from, tui_check_register_values): Update.
1342         (tui_display_register): Remove win_info parameter; update.
1343         (tui_get_register): Change type of parameters.
1344         * tui/tui-data.h (struct tui_data_element): Remove.
1345         (union tui_which_element) <data>: Remove.
1346         <data_window>: Change type.
1347         (struct tui_data_item_window): New.
1348         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1349         case.  Add assert.
1350         (~tui_data_item_window): New destructor.
1351         (free_content_elements): Remove DATA_ITEM_WIN case.
1352
1353 2019-06-25  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1356         Remove.
1357
1358 2019-06-25  Tom Tromey  <tom@tromey.com>
1359
1360         * tui/tui-data.h (struct tui_command_element): Remove.
1361         (union tui_which_element) <command>: Remove.
1362         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1363         assert.
1364         (free_content_elements): Remove CMD_WIN case.
1365
1366 2019-06-25  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui-layout.c (tui_set_layout): Update.
1369         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1370         * tui/tui-data.c (layout_def): Update.
1371
1372 2019-06-25  Tom Tromey  <tom@tromey.com>
1373
1374         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1375         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1376         (tui_source_window_base::set_new_height): Update.
1377         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1378         Update.
1379         (tui_set_locator_fullname, tui_set_locator_info)
1380         (tui_show_frame_info): Update.
1381         * tui/tui-source.c (tui_set_source_content)
1382         (tui_source_is_displayed): Update.
1383         * tui/tui-layout.c (show_source_disasm_command, show_data)
1384         (show_source_or_disasm_and_command): Update.
1385         * tui/tui-disasm.c (tui_set_disassem_content)
1386         (tui_get_begin_asm_address): Update.
1387         * tui/tui-data.h (struct tui_locator_element): Remove.
1388         (union tui_which_element) <locator>: Remove.
1389         (struct tui_locator_window): New.
1390         (tui_locator_win_info_ptr): Change return type.
1391         * tui/tui-data.c (_locator): Change type.
1392         (tui_locator_win_info_ptr): Change return type.
1393         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1394         (tui_alloc_content): Add assert.
1395
1396 2019-06-25  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-winsource.c
1399         (tui_exec_info_window::maybe_allocate_content): New method.
1400         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1401         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1402         (make_source_or_disasm_window): Add cast.
1403         * tui/tui-data.h (union tui_which_element) <simple_string>:
1404         Remove.
1405         (struct tui_source_info): New.
1406         (struct tui_source_window_base) <execution_info>: Change type.
1407         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1408         case, and add assert.
1409         (tui_alloc_content): Add assert.
1410
1411 2019-06-25  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1414         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1415         * tui/tui-data.c (tui_alloc_win_info): Remove.
1416
1417 2019-06-25  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1420         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1421         can_highlight.
1422
1423 2019-06-25  Tom Tromey  <tom@tromey.com>
1424
1425         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1426         make_visible_with_new_height method.
1427         (tui_win_info::make_visible_with_new_height): New method.
1428         (tui_source_window_base::do_make_visible_with_new_height)
1429         (tui_data_window::do_make_visible_with_new_height)
1430         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1431         (make_visible_with_new_height): Remove.
1432         (tui_resize_all, tui_adjust_win_heights): Use
1433         make_visible_with_new_height method.
1434         * tui/tui-data.h (struct tui_win_info)
1435         <do_make_visible_with_new_height, make_visible_with_new_height>:
1436         New methods.
1437         (struct tui_source_window_base, struct tui_data_window)
1438         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1439         methods.
1440
1441 2019-06-25  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1444         method.
1445         (update_tab_width): Call update_tab_width method.
1446         * tui/tui-data.h (struct tui_win_info)
1447         (struct tui_source_window_base) <update_tab_width>: New methods.
1448
1449 2019-06-25  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1452         parameter.
1453         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1454         parameter.
1455         (tui_gen_win_info::make_visible): Update.
1456         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1457         parameter.
1458         * tui/tui-data.h (enum tui_box): New enum.
1459         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1460
1461 2019-06-25  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1464         init_and_make_win for EXEC_INFO_WIN.
1465         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1466         longer inline.
1467         (struct tui_win_info) <~tui_win_info>: Inline.
1468         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1469         Don't declare.
1470         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1471         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1472         Remove.
1473         (tui_initialize_static_data): Update.
1474         (~tui_gen_win_info): Handle more cleanup here.
1475         (~tui_source_window_base): Delete "execution_info".
1476         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1477
1478 2019-06-25  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-layout.c (make_command_window): Don't set
1481         can_highlight.
1482         (show_source_disasm_command): Call the reset method.
1483         (show_data): Don't set can_highlight.  Call the reset method.
1484         (tui_gen_win_info::reset): Rename from init_gen_win_info
1485         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1486         (show_source_or_disasm_and_command): Call the reset method.
1487         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1488         (struct tui_cmd_window): Set can_highlight.
1489
1490 2019-06-25  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1493         from make_visible.
1494         (tui_make_visible, tui_make_invisible): Rewrite.
1495         (tui_win_info::make_visible): Remove.
1496         (tui_source_window_base::make_visible): Update.
1497         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1498         method.  Moved from...
1499         (struct tui_win_info) <make_visible>: ...here.
1500
1501 2019-06-25  Tom Tromey  <tom@tromey.com>
1502
1503         * tui/tui-winsource.c
1504         (tui_source_window_base::do_scroll_horizontal): Remove direction
1505         parameter.
1506         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1507         direction parameter.
1508         * tui/tui-win.c (tui_win_info::forward_scroll)
1509         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1510         (tui_win_info::right_scroll): Update.
1511         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1512         direction parameter.
1513         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1514         direction parameter.
1515         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1516         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1517         Remove direction parameter.
1518         (struct tui_source_window_base, struct tui_source_window)
1519         (struct tui_disasm_window, struct tui_data_window)
1520         (struct tui_cmd_window): Update.
1521
1522 2019-06-25  Tom Tromey  <tom@tromey.com>
1523
1524         * tui/tui-winsource.h (tui_set_exec_info_content)
1525         (tui_show_exec_info_content, tui_erase_exec_info_content)
1526         (tui_clear_exec_info_content, tui_update_exec_info): Change
1527         argument to tui_source_window_base.
1528         * tui/tui-winsource.c (tui_set_exec_info_content)
1529         (tui_show_exec_info_content, tui_erase_exec_info_content)
1530         (tui_clear_exec_info_content, tui_update_exec_info): Change
1531         argument to tui_source_window_base.
1532
1533 2019-06-25  Tom Tromey  <tom@tromey.com>
1534
1535         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1536         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1537
1538 2019-06-25  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1541         check.
1542
1543 2019-06-25  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1546         type to void.
1547         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1548         type to void.
1549         * tui/tui-source.c (tui_set_source_content): Update.
1550         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1551
1552 2019-06-25  Tom Tromey  <tom@tromey.com>
1553
1554         * tui/tui-win.c (window_name_completer, tui_set_focus)
1555         (tui_all_windows_info): Use name method.
1556         * tui/tui-data.h (struct tui_gen_win_info)
1557         (struct tui_source_window, struct tui_disasm_window)
1558         (struct tui_data_window, struct tui_cmd_window) <name>: New
1559         method.
1560         (tui_win_name): Don't declare.
1561         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1562         (tui_win_name): Remove.
1563
1564 2019-06-25  Tom Tromey  <tom@tromey.com>
1565
1566         * tui/tui-winsource.h (tui_update_source_window)
1567         (tui_update_source_window_as_is): Change parameter type.
1568         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1569         to be a tui_source_window_base.
1570         (tui_update_source_window_as_is): Likewise.
1571         * tui/tui-win.c (make_visible_with_new_height): Update.
1572
1573 2019-06-25  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-winsource.c (tui_erase_source_content)
1576         (tui_show_source_content, tui_show_exec_info_content)
1577         (tui_erase_exec_info_content): Use refresh_window method.
1578         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1579         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1580         from tui_refresh_win.
1581         (tui_data_window::refresh_window): New method.
1582         (tui_win_info::refresh, tui_source_window_base::refresh)
1583         (tui_refresh_all): Use refresh_window method.
1584         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1585         method.
1586         * tui/tui-regs.c (tui_display_register): Call refresh_window
1587         method.
1588         * tui/tui-layout.c (show_source_disasm_command)
1589         (show_source_or_disasm_and_command): Call refresh_window method.
1590         * tui/tui-data.h (struct tui_gen_win_info)
1591         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1592         New method.
1593
1594 2019-06-25  Tom Tromey  <tom@tromey.com>
1595
1596         * tui/tui.c (tui_rl_other_window, tui_enable)
1597         (tui_is_window_visible, tui_get_command_dimension): Update.
1598         * tui/tui-winsource.c (tui_update_source_window_as_is)
1599         (tui_clear_source_content, tui_erase_source_content)
1600         (tui_show_source_line, tui_source_window_base::refill)
1601         (tui_source_window_base::do_scroll_horizontal)
1602         (tui_source_window_base::set_is_exec_point_at)
1603         (tui_update_breakpoint_info, tui_set_exec_info_content)
1604         (tui_alloc_source_buffer, tui_line_is_displayed)
1605         (tui_addr_is_displayed): Update.
1606         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1607         (tui_check_and_display_highlight_if_needed)
1608         (tui_win_info::make_visible, tui_win_info::refresh)
1609         (tui_refresh_all): Update.
1610         * tui/tui-windata.c (tui_first_data_item_displayed)
1611         (tui_delete_data_content_windows, tui_erase_data_content)
1612         (tui_display_all_data, tui_data_window::refresh_all)
1613         (tui_check_data_values): Update.
1614         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1615         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1616         (tui_win_info::backward_scroll, tui_refresh_all_win)
1617         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1618         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1619         (tui_source_window_base::set_new_height)
1620         (tui_data_window::set_new_height)
1621         (make_invisible_and_set_new_height)
1622         (make_visible_with_new_height, new_height_ok)
1623         (parse_scrolling_args): Update.
1624         * tui/tui-stack.c (tui_show_frame_info): Update.
1625         * tui/tui-source.c (tui_set_source_content)
1626         (tui_set_source_content_nil, tui_source_is_displayed)
1627         (tui_source_window::do_scroll_vertical): Update.
1628         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1629         (tui_display_registers_from, tui_display_reg_element_at_line)
1630         (tui_check_register_values, tui_reg_command): Update.
1631         * tui/tui-layout.c (tui_default_win_height)
1632         (show_source_disasm_command, show_data, init_and_make_win)
1633         (show_source_or_disasm_and_command): Update.
1634         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1635         (tui_redisplay_readline, tui_mld_flush)
1636         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1637         (tui_getc): Update.
1638         * tui/tui-disasm.c (tui_set_disassem_content)
1639         (tui_disasm_window::do_scroll_vertical): Update.
1640         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1641         Now virtual.
1642         (struct tui_win_info): Derive from tui_gen_win_info.
1643         <~tui_win_info>: Mark as override.
1644         <generic>: Remove member.
1645         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1646         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1647         (~tui_data_window, ~tui_win_info)
1648         (tui_free_all_source_wins_content): Update.
1649         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1650
1651 2019-06-25  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-layout.c (init_and_make_win): Use new.
1654         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1655         destructor, initializers.
1656         (tui_alloc_generic_win_info): Don't declare.
1657         * tui/tui-data.c (_locator): Add argument to constructor.
1658         (source_win, disasm_win): New globals.
1659         (exec_info): Remove.
1660         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1661         Update.
1662         (tui_alloc_generic_win_info): Remove.
1663         (init_content_element): Use new.
1664         (tui_win_info::tui_win_info): Update.
1665         (free_content_elements) <case DATA_WIN>: Use delete.
1666
1667 2019-06-25  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1670         * tui/tui-windata.c (tui_first_data_item_displayed)
1671         (tui_delete_data_content_windows): Update.
1672         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1673         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1674         (tui_display_registers_from, tui_check_register_values): Update.
1675         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1676         pointer.
1677         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1678         window.
1679         (tui_free_data_content): Update.
1680         (free_content_elements) <case DATA_WIN>: Free the window.
1681
1682 2019-06-25  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1685         Update.
1686         * tui/tui-layout.c (make_command_window)
1687         (show_source_disasm_command, show_data, init_and_make_win)
1688         (show_source_or_disasm_and_command): Update.
1689         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1690         method.
1691         <can_highight, is_highlighted>: Now bool.
1692         (tui_set_win_highlight): Don't declare.
1693         * tui/tui-data.c (tui_set_win_highlight): Remove.
1694
1695 2019-06-25  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-wingeneral.c (make_visible): Remove check of window
1698         type.
1699
1700 2019-06-25  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-win.c (tui_win_info::max_height)
1703         (tui_cmd_window::max_height): New methods.
1704         (new_height_ok): Call max_height.
1705         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1706         <max_height>: New method.
1707
1708 2019-06-25  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-win.c (tui_source_window_base::set_new_height)
1711         (tui_data_window::set_new_height): New methods.
1712         (make_invisible_and_set_new_height): Call set_new_height method.
1713         * tui/tui-data.h (struct tui_win_info)
1714         (struct tui_source_window_base, struct tui_data_window)
1715         <set_new_height>: New method.
1716
1717 2019-06-25  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1720         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1721         tui_refresh_data_win.
1722         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1723         method.
1724         (tui_refresh_all_win): Call the refresh_all method.
1725         (tui_set_focus): Likewise.
1726         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1727         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1728         Likewise.
1729
1730 2019-06-25  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-winsource.h (tui_refill_source_window)
1733         (tui_set_is_exec_point_at): Don't declare.
1734         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1735         (tui_source_window_base::refill): Rename from
1736         tui_refill_source_window.
1737         (tui_source_window_base::do_scroll_horizontal): Update.
1738         (tui_source_window_base::set_is_exec_point_at): Rename from
1739         tui_set_is_exec_point_at.
1740         (tui_update_all_breakpoint_info): Update.
1741         * tui/tui-stack.c (tui_show_frame_info): Update.
1742         * tui/tui-layout.c (show_data): Add cast.
1743         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1744         * tui/tui-data.h (struct tui_source_window_base) <refill,
1745         set_is_exec_point_at>: New methods.
1746         (tui_source_windows, tui_add_to_source_windows): Update types.
1747         (tui_add_to_source_windows): Remove redundant declaration.
1748         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1749         (tui_source_windows): Change return type.
1750         (tui_clear_source_windows_detail): Update.
1751         (tui_add_to_source_windows): Change type of parameter.
1752         (tui_free_all_source_wins_content): Update.
1753
1754 2019-06-25  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui-wingeneral.c (tui_win_info::refresh)
1757         (tui_source_window_base::refresh): New methods.
1758         (tui_refresh_all): Call the refresh method.
1759         * tui/tui-data.h (struct tui_win_info)
1760         (struct tui_source_window_base) <refresh>: New method.
1761
1762 2019-06-25  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui.h (tui_is_window_visible): Return bool.
1765         * tui/tui.c (tui_is_window_visible): Return bool.
1766         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1767         (tui_make_visible, tui_make_invisible)
1768         (tui_win_info::make_visible)
1769         (tui_source_window_base::make_visible, make_all_visible)
1770         (tui_make_all_visible, tui_make_all_invisible): Update.
1771         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1772         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1773         bool.
1774         (struct tui_win_info, struct tui_source_window_base)
1775         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1776         * tui/tui-data.c (tui_init_generic_part): Update.
1777
1778 2019-06-25  Tom Tromey  <tom@tromey.com>
1779
1780         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1781         (tui_source_window_base::make_visible): New methods.
1782         (make_all_visible): Make method call.
1783         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1784         (struct tui_source_window_base, struct tui_cmd_window): Override
1785         make_visible.
1786         (tui_win_is_source_type): Don't declare.
1787         * tui/tui-data.c (tui_win_is_source_type): Remove.
1788
1789 2019-06-25  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1792         NULL check.
1793
1794 2019-06-25  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1797         Inline constructor.  Add initializers for members.
1798         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1799         constructors; now inline in class.
1800
1801 2019-06-25  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-regs.c (tui_show_registers): Update.
1804         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1805         bool.
1806         * tui/tui-data.c (tui_data_window::clear_detail)
1807         (tui_data_window): Update.
1808
1809 2019-06-25  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui-windata.c (tui_display_all_data)
1812         (tui_display_data_from_line, tui_display_data_from)
1813         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1814         Update.
1815         * tui/tui-regs.c (tui_last_regs_line_no)
1816         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1817         (tui_show_registers, tui_show_register_group)
1818         (tui_display_registers_from, tui_display_reg_element_at_line)
1819         (tui_display_registers_from_line, tui_check_register_values)
1820         (tui_reg_next, tui_reg_prev): Update.
1821         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1822         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1823         tui_data_window.
1824         (struct tui_win_info) <detail>: Remove.  Add new fields from
1825         tui_data_info.
1826         (TUI_DATA_WIN): Add cast.
1827         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1828         (~tui_data_window): Simplify.
1829
1830 2019-06-25  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-layout.c (show_source_disasm_command)
1833         (show_source_or_disasm_and_command): Update.
1834         * tui/tui-io.c (update_cmdwin_start_line)
1835         (tui_redisplay_readline): Update.
1836         * tui/tui-data.h (struct tui_command_info): Remove.
1837         (struct tui_win_info) <detail>: Remove command_info member.
1838         (struct tui_data_window) <start_line>: New member, from
1839         tui_command_info.
1840         (TUI_CMD_WIN): Add casts.
1841
1842 2019-06-25  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-winsource.c (tui_update_source_window)
1845         (tui_refill_source_window)
1846         (tui_source_window_base::do_scroll_horizontal)
1847         (tui_update_breakpoint_info, tui_set_exec_info_content)
1848         (tui_show_exec_info_content, tui_erase_exec_info_content)
1849         (tui_clear_exec_info_content): Update.
1850         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1851         Update.
1852         * tui/tui-win.c (make_invisible_and_set_new_height)
1853         (make_visible_with_new_height): Update.
1854         * tui/tui-source.c (tui_set_source_content)
1855         (tui_show_symtab_source): Update.
1856         * tui/tui-layout.c (extract_display_start_addr)
1857         (show_source_disasm_command, show_data)
1858         (make_source_or_disasm_window)
1859         (show_source_or_disasm_and_command): Update.
1860         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1861         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1862         "gdbarch".
1863         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1864         to tui_source_window_base.
1865         (struct tui_win_info) <detail>: Remove source_info member.
1866         (struct tui_source_window_base) <has_locator>: Inline.
1867         Move contents from tui_source_info; rename has_locator member to
1868         m_has_locator.
1869         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1870         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1871         header file.
1872         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1873         Simplify.
1874         (tui_free_all_source_wins_content): Cast to
1875         tui_source_window_base.
1876
1877 2019-06-25  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-win.c (make_invisible_and_set_new_height)
1880         (make_visible_with_new_height): Call has_locator method.
1881         * tui/tui-layout.c (show_source_disasm_command, show_data)
1882         (show_source_or_disasm_and_command): Update for bool change.
1883         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1884         (tui_win_info) <has_locator>: New method.
1885         (struct tui_source_window_base) <has_locator>: New method.
1886         (tui_win_has_locator): Don't declare.
1887         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1888         from tui_win_has_locator.
1889         (tui_source_window_base): Use false, not FALSE.
1890
1891 2019-06-25  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1894         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1895         clear_detail method directly.
1896         (tui_clear_win_detail): Remove.
1897
1898 2019-06-25  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1901         "this", not TUI_DISASM_WIN.
1902
1903 2019-06-25  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1906         declare.
1907         * tui/tui-winsource.c
1908         (tui_source_window_base::do_scroll_horizontal): Rename from
1909         tui_horizontal_source_scroll.
1910         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1911         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1912         from tui_vertical_data_scroll.
1913         * tui/tui-win.h (tui_scroll): Don't declare.
1914         * tui/tui-win.c (tui_win_info::forward_scroll)
1915         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1916         (tui_win_info::right_scroll): Rename and update.
1917         (tui_scroll_forward_command, tui_scroll_backward_command)
1918         (tui_scroll_left_command, tui_scroll_right_command): Update.
1919         (tui_scroll): Remove.
1920         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1921         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1922         from tui_vertical_source_scroll.
1923         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1924         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1925         from tui_vertical_disassem_scroll.
1926         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1927         do_scroll_horizontal>: New methods.
1928         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1929         Likewise.
1930         (struct tui_source_window_base): Add do_scroll_horizontal.
1931         (struct tui_source_window, struct tui_disasm_window): Add
1932         do_scroll_vertical.
1933         (struct tui_data_window, struct tui_cmd_window): Add
1934         do_scroll_horizontal and do_scroll_vertical.
1935         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1936
1937 2019-06-25  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-data.h (struct tui_source_window_base): New struct.
1940         (struct tui_source_window): Derive from tui_source_window_base.
1941         (struct tui_disasm_window): New struct.
1942         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1943         from tui_source_window::clear_detail.
1944         (tui_source_window_base): Rename from tui_source_window.
1945         (~tui_source_window_base): Rename from ~tui_source_window.
1946         (tui_alloc_win_info): Create a tui_disasm_window.
1947
1948 2019-06-25  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-data.h (struct tui_source_window)
1951         (struct tui_data_window): Declare destructors.
1952         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1953         destructors.
1954         (tui_win_info): Simplify.
1955
1956 2019-06-25  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-winsource.c (tui_display_main)
1959         (tui_update_source_windows_with_addr)
1960         (tui_update_all_breakpoint_info): Update.
1961         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1962         (new_height_ok, parse_scrolling_args): Update.
1963         * tui/tui-stack.c (tui_show_frame_info): Update.
1964         * tui/tui-data.h (struct tui_list): Remove.
1965         (tui_source_windows): Return a reference to a std::vector.
1966         * tui/tui-data.c (source_windows): Now a std::vector.
1967         (tui_source_windows): Change return type.
1968         (tui_clear_source_windows): Rewrite.
1969         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1970         (tui_free_all_source_wins_content): Rewrite.
1971
1972 2019-06-25  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1975         (struct tui_data_window, struct tui_cmd_window): Declare
1976         clear_detail method.
1977         * tui/tui-data.c (tui_source_window::clear_detail)
1978         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1979         methods.
1980         (tui_clear_win_detail): Simplify.
1981
1982 2019-06-25  Tom Tromey  <tom@tromey.com>
1983
1984         * tui/tui-layout.c (make_source_window, make_disasm_window)
1985         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1986         Return the new window.
1987         (show_source_disasm_command, show_data)
1988         (show_source_or_disasm_and_command): Update.
1989
1990 2019-06-25  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1993         parameter.  Return the new window.
1994         (show_source_disasm_command): Update and remove NULL check.
1995         (show_source_or_disasm_and_command): Update.
1996
1997 2019-06-25  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2000
2001 2019-06-25  Tom Tromey  <tom@tromey.com>
2002
2003         * tui/tui-data.h (struct tui_win_info): Make constructor
2004         protected.  Make destructor virtual.  Add initializers.
2005         (tui_source_window, tui_data_window, tui_cmd_window): New
2006         classes.
2007         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2008         constructor.  Add "type" parameter.
2009         (tui_source_window, tui_data_window, tui_cmd_window): New
2010         constructors.
2011         (tui_alloc_win_info): Instantiate the appropriate subclass.
2012
2013 2019-06-25  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-win.c (tui_resize_all): Use delete.
2016         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2017         destructor.
2018         (tui_free_window): Don't declare.
2019         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2020         Update.
2021
2022 2019-06-25  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-data.h (struct tui_win_info): Add constructor.
2025         * tui/tui-data.c (tui_alloc_win_info): Use new.
2026         (tui_free_window): Use delete.
2027
2028 2019-06-22  Tom Tromey  <tom@tromey.com>
2029
2030         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2031         declare.
2032         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2033
2034 2019-06-22  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2037         declare.
2038         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2039
2040 2019-06-22  Tom de Vries  <tdevries@suse.de>
2041
2042         * dwarf2read.c (create_addrmap_from_aranges)
2043         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2044         instead of '%zu'.
2045
2046 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2047
2048         * dwarf2read.h (dwarf2_section_info_def): Remove.
2049         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2050         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2051         std::vector<dwarf2_section_info>.
2052         (struct dwo_file) <~dwo_file>: Remove.
2053         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2054         types field.
2055         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2056         (dwarf2_read_debug_names): Likewise.
2057         (create_debug_types_hash_table): Change parameter type to
2058         array_view, adjust code accordingly.
2059         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2060         (partial_die_info::fixup): Likewise.
2061         (determine_prefix): Likewise.
2062         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2063
2064 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2065
2066         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2067         gdb_bfd_ref_ptr.
2068         <~dwo_file>: Remove call to gdb_bfd_unref.
2069         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2070         gdb_bfd_ref_ptr::get.
2071
2072 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2073
2074         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2075         type to htab_up.
2076         * dwarf2read.c (struct dwo_file): Initialize fields.
2077         <~dwo_file>: New.
2078         (free_dwo_file): Remove, move content to ~dwo_file.
2079         (struct dwo_file_deleter): Remove.
2080         (dwo_file_up>: Remove custom deleter.
2081         (free_dwo_files): Remove.
2082         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2083         dwo_files.
2084         (process_skeletonless_type_units): Call unique_ptr::get.
2085         (allocate_dwo_file_hash_table): Add deleter to created hash
2086         table.  Change return type to htab_up.
2087         (lookup_dwo_file_slot): Don't memset dwo_file, call
2088         unique_ptr::get.
2089         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2090         (create_dwo_unit_in_dwp_v2): Likewise.
2091         (open_and_init_dwo_file): Likewise.
2092         (free_dwo_file_from_slot): Remove.
2093
2094 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2095
2096         * dwarf2read.h (struct dwarf2_section_info) <readin,
2097         is_virtual>: Change type to bool.
2098         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2099         true instead of 1.
2100
2101 2019-06-19  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-data.h (tui_init_content_element): Don't declare.
2104
2105 2019-06-19  Tom Tromey  <tom@tromey.com>
2106
2107         * tui/tui-data.h (tui_init_win_info): Don't declare.
2108
2109 2019-06-19  Tom de Vries  <tdevries@suse.de>
2110
2111         * dwarf2read.h (abstract_to_concrete): Change type to
2112         std::unordered_map<sect_offset, std::vector<sect_offset>,
2113         gdb::hash_enum<sect_offset>>.
2114
2115 2019-06-19  Tom Tromey  <tromey@adacore.com>
2116
2117         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2118         EVAL_AVOID_SIDE_EFFECTS specially.
2119
2120 2019-06-19  Tom Tromey  <tromey@adacore.com>
2121
2122         * source-cache.c (highlighter): New global.
2123         (source_cache::get_source_lines): Create a highlighter on demand.
2124
2125 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2126
2127         * defs.h (deprecated_interactive_hook): Delete declaration.
2128         * interps.c (clear_interpreter_hooks): Remove use of
2129         deprecated_interactive_hook.
2130         * top.c (deprecated_interactive_hook): Delete definition.
2131         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2132
2133 2019-06-18  Tom de Vries  <tdevries@suse.de>
2134
2135         PR gdb/24515
2136         * dwarf2read.h (abstract_to_concrete): Change type from
2137         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2138         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2139         * dwarf2read.c (read_variable): Update.
2140         (dwarf2_fetch_die_loc_sect_off): Update.
2141
2142 2019-06-17  Tom de Vries  <tdevries@suse.de>
2143
2144         PR gdb/24617
2145         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2146         accessing parent[parent_len - 1].
2147
2148 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2149
2150         PR gdb/24364
2151         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2152         call dtrace_process_dof with NULL dof.
2153
2154 2019-06-16  Tom de Vries  <tdevries@suse.de>
2155
2156         PR gdb/24445
2157         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2158
2159 2019-06-16  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2162         (make_all_visible): Use address of member.
2163
2164 2019-06-16  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2167         (tui_free_window, free_content, free_content_elements): Remove
2168         unnecessary cast.
2169         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2170         cast.
2171         * tui/tui-regs.c (tui_show_register_group)
2172         (tui_display_registers_from, tui_display_reg_element_at_line):
2173         Remove unnecessary cast.
2174
2175 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2176
2177         * linux-nat.c (normal_mask): Delete.
2178         (_initialize_linux_nat): Don't initialise normal_mask.
2179
2180 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2181
2182         PR gdb/24445
2183         * dwarf-index-write.h (write_psymtabs_to_index): Add
2184         dwz_basename parameter.
2185         * dwarf-index-write.c (write_gdbindex): Move file writing to
2186         write_gdbindex_1.  Change return type void.
2187         (assert_file_size): Move up, remove filename parameter.
2188         (write_gdbindex_1): New function.
2189         (write_debug_names): Change return type to void, call
2190         assert_file_size.
2191         (struct index_wip_file): New struct.
2192         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2193         file logic to index_wip_file.  Write index for dwz file if
2194         needed.
2195         (save_gdb_index_command): Pass basename of dwz file, if present.
2196         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2197         build-id of dwz file, if present.
2198         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2199         (dwarf2_get_dwz_file): Likewise.
2200         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2201         (dwarf2_get_dwz_file): Likewise.
2202
2203 2019-06-16  Tom Tromey  <tom@tromey.com>
2204
2205         * coffread.c (process_coff_symbol): Use xstrdup.
2206         * value.c (create_internalvar): Use xstrdup.
2207
2208 2019-06-16  Tom Tromey  <tom@tromey.com>
2209
2210         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2211         * breakpoint.c (stopin_command, stopat_command)
2212         (until_break_command, decode_location_default): Remove unnecessary
2213         cast.
2214         * utils.c (subset_compare): Remove unnecessary cast.
2215         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2216         cast.
2217         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2218         cast.
2219         * infcmd.c (path_command): Remove unnecessary cast.
2220         * coffread.c (decode_type): Remove unnecessary cast.
2221         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2222         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2223         * tui/tui-stack.c (tui_show_locator_content)
2224         (tui_show_frame_info): Remove unnecessary cast.
2225         * tui/tui-win.c (tui_scroll_forward_command)
2226         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2227         (parse_scrolling_args): Remove unnecessary cast.
2228         * tui/tui-data.c (init_win_info, tui_del_window)
2229         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2230         (free_content_elements): Remove unnecessary cast.
2231         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2232         unnecessary cast.
2233         * tui/tui-source.c (tui_set_source_content)
2234         (tui_vertical_source_scroll): Remove unnecessary cast.
2235         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2236         cast.
2237         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2238         * tui/tui-regs.c (tui_display_registers_from)
2239         (tui_display_register): Remove unnecessary cast.
2240         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2241         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2242         (make_visible): Remove unnecessary cast.
2243         * tui/tui-winsource.c (tui_erase_source_content)
2244         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2245         unnecessary cast.
2246         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2247         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2248         * stabsread.c (read_type, read_array_type, read_range_type):
2249         Remove unnecessary cast.
2250         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2251         (parse_symbol, parse_type, upgrade_type, parse_external)
2252         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2253         unnecessary cast.
2254         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2255
2256 2019-06-16  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-data.c (tui_alloc_generic_win_info)
2259         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2260         checks.
2261
2262 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2263             Andrew Burgess  <andrew.burgess@embecosm.com>
2264
2265         * f-typeprint.c (f_print_type): Don't return early for not
2266         associated or not allocated types.
2267         (f_type_print_varspec_suffix): Add print_rank parameter and print
2268         ranks of array types in case they dangling.
2269         (f_type_print_base): Add print_rank parameter.
2270
2271 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2272
2273         * NEWS: Mention new MI commands.
2274         * break-catch-throw.c (enum exception_event_kind): Move to
2275         breakpoint.h.
2276         (print_mention_exception_catchpoint): Output text as a single
2277         message.
2278         (catch_exception_command_1): Rename to...
2279         (catch_exception_event): ...this, make non-static, update header
2280         command, and change some parameter types.
2281         (catch_catch_command): Update for changes to
2282         catch_exception_command_1.
2283         (catch_throw_command): Likewise.
2284         (catch_rethrow_command): Likewise.
2285         * breakpoint.c (enum exception_event_kind): Delete.
2286         * breakpoint.h (enum exception_event_kind): Moved here from
2287         break-catch-throw.c.
2288         (catch_exception_event): Declare.
2289         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2290         (mi_cmd_catch_throw): New function.
2291         (mi_cmd_catch_rethrow): New function.
2292         (mi_cmd_catch_catch): New function.
2293         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2294         'catch-catch' entries.
2295         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2296         (mi_cmd_catch_rethrow): Declare.
2297         (mi_cmd_catch_catch): Declare.
2298
2299 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2300
2301         * annotate.c (annotate_source_line): Change return type to void,
2302         update implementation to match.
2303         * annotate.h (annotate_source_line): Change return type to void,
2304         update header comment.
2305         * stack.c (print_frame_info): Don't change what frame information
2306         is printed based on whether annotations are on or not.
2307
2308 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2309
2310         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2311         (annotate_source): Make static.
2312         (annotate_source_line): Moved from source.c and renamed from
2313         identify_source_line.  Update the return type.
2314         * annotate.h (annotate_source): Delete declaration.
2315         (annotate_source_line): Declaration moved from source.h, and
2316         renamed from identify_source_line.  Return type updated.
2317         * source.c (identify_source_line): Moved to annotate.c and renamed
2318         to annotate_source_line.
2319         (info_line_command): Remove check of annotation_level.
2320         * source.h (identify_source_line): Move declaration to annotate.h
2321         and rename to annotate_source_line.
2322         * stack.c: Add 'annotate.h' include.
2323         (print_frame_info): Remove check of annotation_level before
2324         calling annotate_source_line.
2325
2326 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2327
2328         * source-cache.c (source_cache::get_plain_source_lines): Use
2329         open_source_file_with_line_charpos instead of just
2330         open_source_file, remove call to find_source_lines.
2331         (source_cache::get_source_lines): Likewise.
2332         * source.c (find_source_lines): Make static.
2333         (get_filename_and_charpos): Renamed into...
2334         (open_source_file_with_line_charpos): ..this along with changes to
2335         return a scoped_fd, and some other minor clean ups.
2336         (identify_source_line): Use open_source_file_with_line_charpos.
2337         (search_command_helper): Use open_source_file_with_line_charpos
2338         instead of just open_source_file, remove call to
2339         find_source_lines.
2340         * source.h (open_source_file_with_line_charpos): Declare new
2341         function.
2342         (find_source_lines): Delete declaration.
2343
2344 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2345
2346         * source.c (get_filename_and_charpos): Remove fullname
2347         parameter.
2348         (identify_source_line): Update call to get_filename_and_charpos.
2349
2350 2019-06-14  Tom Tromey  <tromey@adacore.com>
2351
2352         PR gdb/24502:
2353         * ui-style.h (skip_ansi_escape): Update comment.
2354         * ui-file.h (class no_terminal_escape_file): New class.
2355         * ui-file.c (no_terminal_escape_file::write)
2356         (no_terminal_escape_file::puts): New methods.
2357         * cli/cli-logging.c (handle_redirections): Use
2358         no_terminal_escape_file.
2359
2360 2019-06-14  Tom Tromey  <tromey@adacore.com>
2361
2362         * NEWS: Move convenience variable news above Python news.
2363
2364 2019-06-14  Tom Tromey  <tom@tromey.com>
2365
2366         * gnulib: Move directory to top-level.
2367         * configure.ac: Don't configure gnulib.
2368         * configure: Rebuild.
2369         * common/common-defs.h: Use new path to gnulib.
2370         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2371         (GNULIB_H): Remove.
2372         (INCGNU): Look in new gnulib location.
2373         (HFILES_NO_SRCDIR): Remove gnulib files.
2374         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2375         (generated_files): Remove GNULIB_H.
2376         ($(LIBGNU), all-lib): Remove targets.
2377         (distclean): Don't mention GNULIB_BUILDDIR.
2378         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2379
2380 2019-06-14  Tom Tromey  <tromey@adacore.com>
2381
2382         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2383         Warn if symbol file does not provide any symbols.
2384
2385 2019-06-14  Tom Tromey  <tromey@adacore.com>
2386
2387         * source.c (find_and_open_source): Respect basenames_may_differ.
2388
2389 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2390
2391         * annotate.c (annotate_breakpoints_invalid): Make use of
2392         scoped_restore_terminal_state.
2393         (annotate_frames_invalid): Likewise.
2394
2395 2019-06-14  Tom Tromey  <tromey@adacore.com>
2396
2397         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2398         allow assignment to an internalvar.
2399
2400 2019-06-14  Tom Tromey  <tromey@adacore.com>
2401
2402         * ada-lex.l: Allow "_" in attribute names.
2403
2404 2019-06-14  Tom Tromey  <tromey@adacore.com>
2405
2406         PR gdb/24653:
2407         * regcache.c (registers_changed): Don't call alloca.
2408         * top.c (execute_command): Don't call alloca.
2409
2410 2019-06-13  Pedro Alves  <palves@redhat.com>
2411
2412         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2413         'expression'.  When parsing an expression, error out if there's
2414         junk after "unlimited".
2415         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2416         (do_set_command): Adjust calls to is_unlimited_literal.
2417
2418 2019-06-13  Pedro Alves  <palves@redhat.com>
2419
2420         * compile/compile.c (make_compile_options_def_group): Add braces
2421         around array_view initializer.
2422         * thread.c (make_thread_apply_all_options_def_group)
2423         (make_thread_apply_all_options_def_group): Likewise.
2424
2425 2019-06-13  Pedro Alves  <palves@redhat.com>
2426
2427         * NEWS (New commands): Mention "maint test-options
2428         require-delimiter", "maint test-options unknown-is-error", "maint
2429         test-options unknown-is-operand" and "maint show
2430         test-options-completion-result".
2431         (New command options, command completion): New section.
2432         (Completion improvements): New section.
2433         Mention that you can abbreviate "unlimited".
2434
2435 2019-06-13  Pedro Alves  <palves@redhat.com>
2436
2437         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2438         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2439         * unittests/cli-utils-selftests.c (test_parse_flags)
2440         (test_parse_flags_qcs): Delete.
2441         (test_cli_utils): Don't call deleted functions.
2442
2443 2019-06-13  Pedro Alves  <palves@redhat.com>
2444
2445         * thread.c: Include "cli/cli-option.h".
2446         (tp_array_compar_ascending): Global.
2447         (tp_array_compar): Delete function.
2448         (tp_array_compar_ascending, tp_array_compar_descending): New
2449         functions.
2450         (ascending_option_def, qcs_flag_option_def)
2451         (thr_qcs_flags_option_defs)
2452         (make_thread_apply_all_options_def_group)
2453         (make_thread_apply_options_def_group): New.
2454         (thread_apply_all_command): Use gdb::option::process_options.
2455         (thread_apply_command_completer)
2456         (thread_apply_all_command_completer): New.
2457         (thread_apply_command): Use gdb::option::process_options.
2458         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2459         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2460         to generate help text of "thread apply".  Adjust "taas"'s help.
2461         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2462         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2463
2464 2019-06-13  Pedro Alves  <palves@redhat.com>
2465
2466         * thread.c (thread_apply_command): Check for invalid TID with
2467         isdigit instead of !isalpha.
2468
2469 2019-06-13  Pedro Alves  <palves@redhat.com>
2470
2471         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2472         (validate_flags_qcs): New.
2473         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2474         (validate_flags_qcs): Declare.
2475         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2476         (make_frame_apply_options_def_group): New.
2477         (frame_apply_command_count): Process options with
2478         gdb::option::process_options.
2479         (frame_apply_completer): New.
2480         (frame_apply_level_completer, frame_apply_all_completer)
2481         (frame_apply_completer): New.
2482         (_initialize_stack): Update help of "frame apply", "frame apply
2483         level", "frame apply all" and "faas" to mention supported options
2484         and install command completers.
2485         * stack.h (frame_apply_all_completer): Declare.
2486         * thread.c: Include "stack.h".
2487         (tfaas_command): Add "--".
2488         (_initialize_thread): Update help "tfaas" to mention supported
2489         options and install command completer.
2490
2491 2019-06-13  Pedro Alves  <palves@redhat.com>
2492
2493         * completer.c (complete_nested_command_line): New.
2494         (gdb_completion_word_break_characters_throw): Add assertion.
2495         * completer.h (complete_nested_command_line): Declare.
2496
2497 2019-06-13  Pedro Alves  <palves@redhat.com>
2498
2499         * stack.c (parse_backtrace_qualifiers): New.
2500         (backtrace_command): Use it.
2501         (backtrace_command_completer): Complete on qualifiers.
2502
2503 2019-06-13  Pedro Alves  <palves@redhat.com>
2504
2505         * frame.c: Include "cli/cli-option.h.
2506         (user_set_backtrace_options): New.
2507         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2508         Delete.
2509         (get_prev_frame): Adjust.
2510         (boolean_option_def, uinteger_option_def)
2511         (set_backtrace_option_defs): New.
2512         (_initialize_frame): Adjust and use
2513         gdb::option::add_setshow_cmds_for_options to install "set
2514         backtrace past-main" and "set backtrace past-entry".
2515         * frame.h: Include "cli/cli-option.h".
2516         (struct frame_print_options): Forward declare.
2517         (print_frame_arguments_all, print_frame_arguments_scalars)
2518         (print_frame_arguments_none): Declare.
2519         (print_entry_values): Delete declaration.
2520         (struct frame_print_options, user_frame_print_options): New.
2521         (struct set_backtrace_options): New.
2522         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2523         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2524         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2525         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2526         (list_args_or_locals): Add frame_print_options parameter.
2527         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2528         * python/py-framefilter.c (enumerate_args): Pass down
2529         USER_FRAME_PRINT_OPTIONS.
2530         * stack.c: Include "cli/cli-option.h".
2531         (print_frame_arguments_all, print_frame_arguments_scalars)
2532         (print_frame_arguments_none): Declare.
2533         (print_raw_frame_arguments, print_entry_values): Delete.
2534         (user_frame_print_options): New.
2535         (boolean_option_def, enum_option_def, frame_print_option_defs):
2536         New.
2537         (struct backtrace_cmd_options): New.
2538         (bt_flag_option_def): New.
2539         (backtrace_command_option_defs): New.
2540         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2541         (print_frame_arg, read_frame_arg, print_frame_args)
2542         (print_frame_info, print_frame): Add frame_print_options parameter
2543         and use it.
2544         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2545         (backtrace_command_1): Add frame_print_options and
2546         backtrace_cmd_options parameters and use them.
2547         (make_backtrace_options_def_group): New.
2548         (backtrace_command): Process command options with
2549         gdb::option::process_options.
2550         (backtrace_command_completer): New.
2551         (_initialize_stack): Extend "backtrace"'s help to mention
2552         supported options.  Install completer for "backtrace".
2553         Install some settings commands with add_setshow_cmds_for_options.
2554
2555 2019-06-13  Pedro Alves  <palves@redhat.com>
2556
2557         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2558         and that "set/show print raw frame-arguments" are now deprecated.
2559
2560         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2561         command.
2562         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2563         * stack.c (_initialize_stack): Install "set/show print
2564         raw-frame-arguments", and deprecate "set/show print raw
2565         frame-arguments".
2566         * valprint.c (_initialize_valprint): Deprecate "set/show print
2567         raw".
2568
2569 2019-06-13  Pedro Alves  <palves@redhat.com>
2570
2571         * compile/compile.c (struct compile_options): New.
2572         (compile_flag_option_def, compile_command_option_defs)
2573         (make_compile_options_def_group): New.
2574         (compile_file_command): Handle options with
2575         gdb::option::process_options.
2576         (compile_file_command_completer): New function.
2577         (compile_code_command): Handle options with
2578         gdb::option::process_options.
2579         (compile_code_command_completer): New function.
2580         (_initialize_compiler): Install completers for "compile code" and
2581         "compile file".  Mention available options in "compile code" and
2582         "compile code"'s help.
2583         * completer.c (advance_to_completion_word): New, factored out from
2584         ...
2585         (advance_to_expression_complete_word_point): ... this.
2586         (advance_to_filename_complete_word_point): New.
2587         * completer.h (advance_to_filename_complete_word_point): New
2588         declaration.
2589
2590 2019-06-13  Pedro Alves  <palves@redhat.com>
2591
2592         * compile/compile.c: Include "cli/cli-option.h".
2593         (compile_print_value): Scope data pointer is now a
2594         value_print_options pointer; adjust.
2595         (compile_print_command): Process options.  Scope data pointer is
2596         now a value_print_options pointer; adjust.
2597         (_initialize_compile): Update "compile print"'s help to include
2598         supported options.  Install a completer for "compile print".
2599         * cp-valprint.c (show_vtblprint, show_objectprint)
2600         (show_static_field_print): Delete.
2601         (_initialize_cp_valprint): Don't install "set print
2602         static-members", "set print vtbl", "set print object" here.
2603         * printcmd.c: Include "cli/cli-option.h" and
2604         "common/gdb_optional.h".
2605         (print_command_parse_format): Rework to fill in a
2606         value_print_options instead of a format_data.
2607         (print_value): Change parameter type from format_data pointer to
2608         value_print_options reference.  Adjust.
2609         (print_command_1): Process options.  Adjust to pass down a
2610         value_print_options.
2611         (print_command_completer): New.
2612         (_initialize_printcmd): Install print_command_completer as
2613         handle_brkchars completer for the "print" command.  Update
2614         "print"'s help to include supported options.
2615         * valprint.c: Include "cli/cli-option.h".
2616         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2617         here from cp-valprint.c.
2618         (boolean_option_def, uinteger_option_def)
2619         (value_print_option_defs, make_value_print_options_def_group):
2620         New.  Use gdb::option::add_setshow_cmds_for_options to install
2621         "set print elements", "set print null-stop", "set print repeats",
2622         "set print pretty", "set print union", "set print array", "set
2623         print address", "set print symbol", "set print array-indexes".
2624         * valprint.h: Include <string> and "cli/cli-option.h".
2625         (make_value_print_options_def_group): Declare.
2626         (print_value): Change parameter type from format_data pointer to
2627         value_print_options reference.
2628         (print_command_completer): Declare.
2629
2630 2019-06-13  Pedro Alves  <palves@redhat.com>
2631
2632         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2633         (COMMON_SFILES): Add maint-test-settings.c.
2634         * cli/cli-decode.c (boolean_enums): New global, factored out from
2635         ...
2636         (add_setshow_boolean_cmd): ... here.
2637         * cli/cli-decode.h (boolean_enums): Declare.
2638         * cli/cli-option.c: New file.
2639         * cli/cli-option.h: New file.
2640         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2641         factored out from ...
2642         (parse_cli_boolean_value(const char *)): ... this.
2643         (is_unlimited_literal): Change parameter type to pointer to
2644         pointer.  Adjust and advance ARG pointer.
2645         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2646         (parse_cli_var_enum): New, factored out from ...
2647         (do_set_command): ... this.  Adjust.
2648         * cli/cli-setshow.h (parse_cli_boolean_value)
2649         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2650         (parse_cli_var_enum): Declare.
2651         * cli/cli-utils.c: Include "cli/cli-option.h".
2652         (get_ulongest): New.
2653         * cli/cli-utils.h (get_ulongest): Declare.
2654         (check_for_argument): New overloads.
2655         * maint-test-options.c: New file.
2656
2657 2019-06-13  Pedro Alves  <palves@redhat.com>
2658
2659         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2660         parse a range if "-" is at the end of the string.
2661
2662 2019-06-13  Pedro Alves  <palves@redhat.com>
2663
2664         * cli/cli-setshow.c (parse_auto_binary_operation)
2665         (parse_cli_boolean_value): Don't allow "o".
2666
2667 2019-06-13  Pedro Alves  <palves@redhat.com>
2668
2669         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2670         * NEWS: Mention maint test-settings KIND.
2671         * maint-test-settings.c: New file.
2672
2673 2019-06-13  Pedro Alves  <palves@redhat.com>
2674
2675         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2676         completer.
2677         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2678         "set" completers.
2679
2680 2019-06-13  Pedro Alves  <palves@redhat.com>
2681
2682         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2683         after item.
2684
2685 2019-06-13  Pedro Alves  <palves@redhat.com>
2686
2687         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2688
2689 2019-06-13  Pedro Alves <palves@redhat.com>
2690
2691         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2692         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2693         call.
2694         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2695         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2696         calls.
2697         (check_for_argument): Skip spaces after argument.
2698
2699 2019-06-13  Pedro Alves  <palves@redhat.com>
2700
2701         * thread.c (thread_apply_command): Adjust TID parsing.
2702         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2703         detected before end of string.
2704         (tid_is_in_list): Error out if LIST is invalid.
2705
2706 2019-06-13  Pedro Alves  <palves@redhat.com>
2707
2708         * completer.c (complete_line_internal_1): Rewind completion word
2709         point.
2710         (completion_tracker::advance_custom_word_point_by): Change
2711         parameter type to int.
2712         * completer.h (completion_tracker::advance_custom_word_point_by):
2713         Likewise.
2714
2715 2019-06-13  Pedro Alves  <palves@redhat.com>
2716
2717         * completer.c (advance_to_completion_word): Handle delimiters.
2718
2719 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2720
2721         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2722
2723 2019-06-11  Tom Tromey  <tom@tromey.com>
2724
2725         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2726         (xmalloc_failed): Move to alloc.c.
2727         * alloc.c: New file.
2728         * Makefile.in (COMMON_SFILES): Add alloc.c.
2729
2730 2019-06-11  Tom Tromey  <tom@tromey.com>
2731
2732         * nat/linux-waitpid.c: Don't include server.h.
2733         (linux_debug): Remove.
2734         (my_waitpid): Update.
2735
2736 2019-06-11  Tom Tromey  <tromey@adacore.com>
2737
2738         * infcall.c (_initialize_infcall): Remove trailing newline from
2739         help.
2740         * user-regs.c (_initialize_user_regs): Remove trailing newline
2741         from help.
2742         * typeprint.c (_initialize_typeprint): Remove trailing newline
2743         from help.
2744         * reverse.c (_initialize_reverse): Remove trailing newlines from
2745         help.
2746         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2747         from help.
2748         * language.c (add_set_language_command): Remove trailing newline
2749         from help.
2750         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2751         help.
2752         * disasm.c (_initialize_disasm): Remove trailing newline from
2753         help.
2754         * top.c (init_main): Remove trailing newline from help.
2755         * interps.c (_initialize_interpreter): Remove trailing newline
2756         from help.
2757         * btrace.c (_initialize_btrace): Remove trailing newlines from
2758         help.
2759         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2760         from help.
2761         * python/python.c (_initialize_python): Remove trailing newline
2762         from help.
2763         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2764         help.
2765         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2766         from help.  Reformat some text.
2767         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2768         from help.
2769         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2770         newline from help.
2771
2772 2019-06-11  Tom Tromey  <tromey@adacore.com>
2773
2774         * darwin-nat.c (darwin_decode_exception_message)
2775         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2776
2777 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2778
2779         * valops.c (value_slice): Check for not allocated or not
2780         associated values.
2781
2782 2019-06-10  Tom de Vries  <tdevries@suse.de>
2783
2784         PR gdb/24618
2785         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2786         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2787         invalid.
2788
2789 2019-06-10  Tom de Vries  <tdevries@suse.de>
2790
2791         PR gdb/24611
2792         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2793         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2794
2795 2019-06-10  Tom de Vries  <tdevries@suse.de>
2796
2797         PR symtab/24545
2798         * symtab.c (struct demangled_name_entry): Add language field.
2799         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2800         static minimal symbol".  Set and use language field.
2801
2802 2019-06-10  Tom Tromey  <tromey@adacore.com>
2803
2804         * ada-lang.c (_initialize_ada_language): Update help text.
2805
2806 2019-06-10  Tom Tromey  <tromey@adacore.com>
2807
2808         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2809         with a newline.
2810         * guile/guile.c (handle_boot_error): Don't end warning with a
2811         newline.
2812         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2813         warning with a newline.
2814         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2815         newline.
2816         (s12z_frame_cache): Likewise.
2817         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2818         a newline.
2819         * solib-svr4.c (disable_probes_interface): Don't end warning with
2820         a newline.
2821         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2822         newline.
2823         * python/python.c (do_finish_initialization): Don't end warning
2824         with a newline.
2825
2826 2019-06-10  Tom Tromey  <tom@tromey.com>
2827
2828         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2829         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2830         gdbpy_enter.
2831
2832 2019-06-10  Tom Tromey  <tromey@adacore.com>
2833
2834         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2835         data.
2836         (elf_new_init): Don't call stabsread_new_init.
2837         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2838         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2839         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2840
2841 2019-06-10  Tom de Vries  <tdevries@suse.de>
2842
2843         PR symtab/16264
2844         PR symtab/24517
2845         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2846
2847 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2848
2849         * source.c (find_and_open_source): Also rewrite relative file
2850         names.
2851
2852 2019-04-26  Amos Bird  <amosbird@gmail.com>
2853
2854         * annotate.c (annotate_thread_exited): Add "thread-exited"
2855         annotation.
2856
2857 2019-06-06  Tom Tromey  <tromey@adacore.com>
2858
2859         * maint.h (class scoped_command_stats): Use
2860         DISABLE_COPY_AND_ASSIGN.
2861         <print_time>: New method.
2862         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2863         print_time.
2864         (scoped_command_stats::print_time): New method.
2865
2866 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2867
2868         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2869         instructions of lengths 6 or 8 bytes.
2870
2871 2019-06-04  Pedro Alves  <palves@redhat.com>
2872
2873         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2874
2875         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2876         * breakpoint.c (condition_completer): Likewise.
2877         * cli/cli-dump.c (scan_expression): Likewise.
2878         * common/filestuff.c (mkdir_recursive): Likewise.
2879         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2880         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2881         (gdb_abspath): Likewise.
2882         * compile/compile-cplus-types.c
2883         (compile_cplus_instance::decl_name): Likewise.
2884         * completer.c (complete_explicit_location):
2885         (signal_completer, reg_or_group_completer_1): Likewise.
2886         * cp-support.c (cp_remove_params_if_any): Likewise.
2887         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2888         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2889         * infcmd.c (strip_bg_char): Likewise.
2890         * linespec.c (copy_token_string): Likewise.
2891         * mi/mi-main.c (output_cores): Likewise.
2892         * psymtab.c (psymtab_search_name):
2893         * symfile.c (test_set_ext_lang_command): Likewise.
2894         * target.c (target_fileio_read_stralloc): Likewise.
2895         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2896         * value.c (complete_internalvar): Likewise.
2897
2898 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2899
2900         Add objfile property to gdb.Type.
2901         * NEWS: Mention Python API addition.
2902         * python/py-type.c (typy_get_objfile): New method.
2903
2904 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2905
2906         * NEWS: Mention the new set|show style [title|highlight].
2907         Mention changes to "show style", "help" and "apropos".
2908
2909 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2910
2911         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2912         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2913         instead of print_help_for_command.
2914         (print_doc_of_command): New function.
2915         (help_list): Add 'apropos -v word' suggestion.
2916         (print_help_for_command): Style the command name using title style.
2917         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2918         (_initialize_cli_cmds): Describe -v in apropos_command help.
2919
2920 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2921
2922         * cli/cli-style.h (cli_style_option): Add name in constructor,
2923         add m_name class member, add constructor with intensity,
2924         add name class function.
2925         (cli_style_option::add_setshow_commands): Remove name argument.
2926         (highlight_style, title_style): New styles.
2927         * cli/cli-style.c (do_show): New function that shows a style
2928         characteristic styling the style name with itself.
2929         (set_style_name): New function.
2930         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2931         Update all callers according to the changes in cli/cli-style.h.
2932         * utils.h (fputs_highlighted): New function.
2933         * utils.c (fputs_highlighted): Likewise.
2934
2935 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2936
2937         * NEWS: Mention new pipe command and new convenience variables.
2938
2939 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2940
2941         * cli/cli-cmds.c (pipe_command): New function.
2942         (_initialize_cli_cmds): Call add_com for pipe_command.
2943         Define | as an alias for pipe.
2944         (exit_status_set_internal_vars): New function.
2945         (shell_escape): Call exit_status_set_internal_vars.
2946         cli/cli-decode.c (find_command_name_length): Recognize | as
2947         a single character command.
2948
2949 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2950
2951         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2952         top.c (execute_command_to_ui_file): New function, mostly a copy
2953         of execute_command_to_string.
2954         (execute_command_to_string): Implement by calling
2955         execute_command_to_ui_file.
2956
2957 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2958
2959         * top.h (saved_command_line): Remove declaration.
2960         * top.c (previous_saved_command_line, previous_repeat_arguments):
2961         New variables.
2962         (saved_command_line): Make static, define together with other
2963         'repeat variables'.
2964         (dont_repeat): Clear repeat_arguments.
2965         (repeat_previous, get_saved_command_line, save_command_line):
2966         New functions.
2967         (gdb_init): Initialize saved_command_line
2968         and previous_saved_command_line.
2969         * main.c (captured_main_1): Remove saved_command_line initialization.
2970         * event-top.c (handle_line_of_input): Update to use
2971         the new 'repeat' related functions instead of direct access to
2972         saved_command_line.
2973         * command.h (repeat_previous, get_saved_command_line,
2974         save_command_line): New declarations.
2975         (dont_repeat): Add comment.
2976
2977 2019-05-30  Tom Tromey  <tromey@adacore.com>
2978
2979         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2980         Fix comment.
2981         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2982
2983 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2984
2985         PR cli/24587
2986         * completer.c (complete): Initialize variable word.
2987
2988 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2989
2990         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2991         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2992         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2993         'body' is NULL to the outter 'if', protecting the '!is_define'
2994         situation as well.
2995
2996 2019-05-29  Tom Tromey  <tromey@adacore.com>
2997
2998         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2999         (dwarf_unknown): New function.
3000         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3001         (dwarf_type_encoding_name): Use dwarf_unknown.
3002
3003 2019-05-29  Tom Tromey  <tromey@adacore.com>
3004
3005         PR c++/20020:
3006         * cp-valprint.c (cp_print_value_fields): Call
3007         cp_print_static_field inside "try".
3008
3009 2019-05-29  Tom Tromey  <tromey@adacore.com>
3010
3011         * inflow.c (struct terminal_info): Add default operator=.
3012         * configure: Rebuild.
3013         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3014         -Wdeprecated-copy-dtor, -Wredundant-move.
3015
3016 2019-05-29  Tom Tromey  <tromey@adacore.com>
3017
3018         * NEWS: Add entry.
3019         * infcmd.c (print_return_value_1): Handle finish_print
3020         option.
3021         (show_print_finish): New function.
3022         (_initialize_infcmd): Add "set/show print finish" commands.
3023         * valprint.c (user_print_options): Initialize new member.
3024         * valprint.h (struct value_print_options) <finish_print>: New
3025         member.
3026
3027 2019-05-28  Tom Tromey  <tromey@adacore.com>
3028
3029         * ada-lang.c (ada_remove_Xbn_suffix)
3030         (find_old_style_renaming_symbol)
3031         (parse_old_style_renaming): Remove.
3032         (ada_find_renaming_symbol): Don't call
3033         find_old_style_renaming_symbol.
3034         (ada_is_renaming_symbol): Rename from
3035         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3036         bool.  Now static.
3037         (ada_read_var_value): Update and simplify.
3038         * ada-exp.y (write_var_or_type): Remove old code.
3039
3040 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3041
3042         * event-top.c: Remove include comment.
3043         * inflow.c (class scoped_ignore_sigttou): Move from here...
3044         * inflow.h (class scoped_ignore_sigttou): ...to here.
3045         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3046         * top.c:  Remove include comment.
3047
3048 2019-05-27  Tom Tromey  <tom@tromey.com>
3049
3050         * NEWS: Fix typo.
3051
3052 2019-05-22  Tom Tromey  <tromey@adacore.com>
3053
3054         * target.c (target_follow_exec): Constify parameter.
3055         * target-delegates.c: Rebuild.
3056         * remote.c (remote_target::follow_exec): Constify parameter.
3057         * infrun.c (follow_exec): Constify parameter.
3058         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3059         (target_follow_exec): Likewise.
3060
3061 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3062
3063         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3064         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3065
3066 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3067
3068         * NEWS: Add debugredirect and testsuite sections.
3069
3070 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3071
3072         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3073         target descriptions using exclusively floating point register name
3074         aliases.
3075
3076 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3077
3078         PR gdb/18644:
3079         * f-lang.c (build_fortran_types): Handle the case where
3080         gdbarch_floatformat_for_type returns a nullptr.
3081
3082 2019-05-21  Tom de Vries  <tdevries@suse.de>
3083
3084         PR cli/24587
3085         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3086
3087 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3088
3089         PR gdb/18644:
3090         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3091         16-byte floats.
3092         * i386-tdep.c (i386_floatformat_for_type): Use
3093         floatformats_ia64_quad for the 16-byte floating point component
3094         within a fortran 32-byte complex number.
3095
3096 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3097
3098         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3099         delete default constructor.
3100         (find_partial_die): Update to return const struct.
3101         (partial_die_parent_scope): Move variable declaration into scope
3102         of its use and change its type to auto.
3103         (guess_partial_die_structure_name): Likewise.
3104         (partial_die_info::fixup): Likewise.
3105
3106 2019-05-17  Tom Tromey  <tromey@adacore.com>
3107
3108         * source.c (find_and_open_source): Remove cast.
3109
3110 2019-05-17  Tom Tromey  <tromey@adacore.com>
3111
3112         * annotate.c (annotate_source): Make "filename" const.
3113         * annotate.h (annotate_source): Use const.
3114
3115 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3116
3117         * disasm.c (set_disassembler_options): Send errors to stderr.
3118
3119 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3120
3121         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3122         (cli_interp_base::set_logging): Check debug_redirect.
3123         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3124         * cli/cli-logging.c (debug_redirect): Add static variable.
3125         (pop_output_files): Add default param.
3126         (handle_redirections): Print debug setting.
3127         (show_logging_command): Likewise.
3128         (_initialize_cli_logging): Add debugredirect command.
3129         * interps.c (current_interp_set_logging): Add debug_redirect
3130         parameter.
3131         * interps.h (set_logging): Add debug_redirect parameter.
3132         (current_interp_set_logging): Likewise.
3133         * mi/mi-common.h: Likewise.
3134         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3135
3136 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3137             Tom Tromey  <tromey@adacore.com>
3138
3139         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3140         directly.
3141         * cli/cli-interp.h (make_logging_output): Remove declaration.
3142         * cli/cli-logging.c (make_logging_output): Remove function.
3143         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3144         directly.
3145         * ui-file.c (tee_file::tee_file): Remove bools.
3146         (tee_file::~tee_file): Remove deletes.
3147         * ui-file.h (tee_file): Remove bools.
3148
3149 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3150
3151         * mi/mi-cmds.h (mi_cmd_complete): New function.
3152         * mi/mi-main.c (mi_cmd_complete): Likewise.
3153         * mi/mi-cmds.c: Define new MI command -complete.
3154         * NEWS: Mention new -complete command.
3155
3156 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3157
3158         * completer.h (complete): New function.
3159         * completer.c (complete): Likewise.
3160         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3161         function defined in completer.h.
3162
3163 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3164
3165         * MAINTAINERS (Write After Approval): Add myself.
3166
3167 2019-05-17  Tom de Vries  <tdevries@suse.de>
3168
3169         PR gdb/24094
3170         * dwarf2read.c (struct cu_partial_die_info): New struct.
3171         (find_partial_die): Return cu_partial_die_info.
3172         (partial_die_parent_scope, guess_partial_die_structure_name)
3173         (partial_die_info::fixup): Handle new return type of find_partial_die.
3174
3175 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3176
3177         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3178         "std::string", simplifying the algorithm.
3179
3180 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3181
3182         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3183         (stap_static_probe_ops::get_probes): Likewise.
3184
3185 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3186
3187         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3188         '-')" and "else if".
3189         (stap_parse_single_operand): Join checks for
3190         "gdbarch_stap_parse_special_token_p" and
3191         "gdbarch_stap_parse_special_token" in the same "if" statement.
3192         Invert check when verifying for operation on register
3193         displacement.
3194
3195 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3196
3197         * stap-probe.c (stap_get_opcode): Update comment.
3198         (stap_get_expected_argument_type): Likewise.
3199         (handle_stap_probe): Likewise.
3200
3201 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3202
3203         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3204         return type to 'bool'.  Adjust comment.  Use 'bool' when
3205         appropriate.
3206         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3207         * stap-probe.c (stap_parse_argument_1): Likewise.
3208         (stap_is_operator): Likewise.
3209         (stap_is_generic_prefix): Likewise.
3210         (stap_is_register_prefix): Likewise.
3211         (stap_is_register_indirection_prefix): Likewise.
3212         (stap_is_integer_prefix): Likewise.
3213         (stap_generic_check_suffix): Likewise.
3214         (stap_check_integer_suffix): Likewise.
3215         (stap_check_register_suffix): Likewise.
3216         (stap_check_register_indirection_suffix): Likewise.
3217         (stap_parse_register_operand): Likewise.
3218         (stap_parse_single_operand): Likewise.
3219         (stap_parse_argument_1): Likewise.
3220         (stap_probe::get_argument_count): Likewise.
3221         (stap_is_operator): Likewise.
3222
3223 2019-05-16  Tom Tromey  <tromey@adacore.com>
3224
3225         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3226         keyword to foreach.
3227
3228 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3229
3230         * linux-thread-db.c (try_thread_db_load_1): Change return type
3231         to bool.
3232         (try_thread_db_load): Likewise.
3233         (try_thread_db_load_from_pdir_1): Likewise.
3234         (try_thread_db_load_from_pdir): Likewise.
3235         (try_thread_db_load_from_sdir): Likewise.
3236         (try_thread_db_load_from_dir): Likewise.
3237         (thread_db_load_search): Likewise.
3238         (has_libpthread): Likewise.
3239         (thread_db_load): Likewise.
3240
3241 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3242
3243         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3244         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3245         NULL, and complain/return if that's the case.
3246
3247 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3248
3249         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3250         (advance, posn, abstract_read_memory): New functions.
3251         [struct mem_read_abstraction]: New struct.
3252         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3253
3254 2019-05-14  Tom Tromey  <tromey@adacore.com>
3255
3256         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3257         value is not lval_memory.
3258
3259 2019-05-14  Tom Tromey  <tromey@adacore.com>
3260
3261         * solib.c (info_sharedlibrary_command): Style the file name.
3262
3263 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3264
3265         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3266         (aarch64_vnv_type): Likewise.
3267         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3268         * common/tdesc.c: Likewise.
3269         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3270         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3271         * features/aarch64-fpu.xml: Add ieee half view.
3272         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3273         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3274         * gdbtypes.h (struct builtin_type): Likewise.
3275         (struct objfile_type): Likewise.
3276
3277 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3278
3279         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3280         typo.
3281         * location.h (string_to_event_location): Likewise.
3282
3283 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3284
3285         GDB 8.3 released.
3286
3287 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3288
3289         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3290         New variable declaration.
3291         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3292         New variable.
3293         (print_one_breakpoint): Use ui_out::test_flags and new global
3294         variable to compute use_fixed_output.
3295         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3296         Remove.
3297         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3298         (mi_multi_location_breakpoint_output_fixed): Remove.
3299         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3300         new variable.
3301         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3302         fix_multi_location_breakpoint_output flag if version >= 3.
3303         * ui-out.h (enum ui_out_flag)
3304         <fix_multi_location_breakpoint_output>: New enumerator.
3305
3306 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3307
3308         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3309
3310 2019-05-10  Tom Tromey  <tromey@adacore.com>
3311
3312         * ada-lang.c (catch_ada_completer): New function.
3313         (_initialize_ada_language): Use it.
3314
3315 2019-05-10  Tom Tromey  <tromey@adacore.com>
3316
3317         * thread.c (print_thread_info): Make "requested_threads" const.
3318         * gdbthread.h (print_thread_info): Make "requested_threads"
3319         const.
3320         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3321         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3322
3323 2019-05-08  Tom Tromey  <tom@tromey.com>
3324
3325         * gdbtypes.c (objfile_type_data): Change type.
3326         (objfile_type, _initialize_gdbtypes): Update.
3327
3328 2019-05-08  Tom Tromey  <tom@tromey.com>
3329
3330         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3331         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3332         (_initialize_dwarf2_frame): Update.
3333
3334 2019-05-08  Tom Tromey  <tom@tromey.com>
3335
3336         * objc-lang.c (objc_objfile_data): Change type.
3337         (find_methods): Update.
3338         (_initialize_objc_lang): Remove.
3339
3340 2019-05-08  Tom Tromey  <tom@tromey.com>
3341
3342         * stabsread.c (rs6000_builtin_type_data): Change type.
3343         (rs6000_builtin_type, _initialize_stabsread): Update.
3344
3345 2019-05-08  Tom Tromey  <tom@tromey.com>
3346
3347         * mips-tdep.c (mips_pdr_data): Remove.
3348         (_initialize_mips_tdep): Update.
3349
3350 2019-05-08  Tom Tromey  <tom@tromey.com>
3351
3352         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3353         (hppa_init_objfile_priv_data, read_unwind_info)
3354         (find_unwind_entry, _initialize_hppa_tdep): Update.
3355
3356 2019-05-08  Tom Tromey  <tom@tromey.com>
3357
3358         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3359         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3360         on obstack.
3361         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3362
3363 2019-05-08  Tom Tromey  <tom@tromey.com>
3364
3365         * mdebugread.c (basic_type_data): Change type.
3366         (basic_type, _initialize_mdebugread): Update.
3367
3368 2019-05-08  Tom Tromey  <tom@tromey.com>
3369
3370         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3371
3372 2019-05-08  Tom Tromey  <tom@tromey.com>
3373
3374         * nto-tdep.c (nto_inferior_data_reg): Change type.
3375         (nto_inferior_data): Update.
3376         (nto_inferior_data_cleanup, nto_new_inferior_data)
3377         (_initialize_nto_tdep): Remove.
3378         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3379
3380 2019-05-08  Tom Tromey  <tom@tromey.com>
3381
3382         * ada-lang.c (struct ada_inferior_data): Add initializers.
3383         (ada_inferior_data): Change type.
3384         (ada_inferior_data_cleanup): Remove.
3385         (get_ada_inferior_data, ada_inferior_exit)
3386         (struct ada_pspace_data): Add initializers, destructor.
3387         (ada_pspace_data_handle): Change type.
3388         (get_ada_pspace_data): Update.
3389         (ada_pspace_data_cleanup): Remove.
3390
3391 2019-05-08  Tom Tromey  <tom@tromey.com>
3392
3393         * coffread.c (struct coff_symfile_info): Add initializers.
3394         (coff_objfile_data_key): Move lower.  Change type.
3395         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3396         Update.
3397         (coff_free_info): Remove.
3398
3399 2019-05-08  Tom Tromey  <tom@tromey.com>
3400
3401         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3402         (fbsd_pspace_data_handle): Move lower.  Change type.
3403         (get_fbsd_pspace_data): Update.
3404         (fbsd_pspace_data_cleanup): Remove.
3405         (_initialize_fbsd_tdep): Update.
3406
3407 2019-05-08  Tom Tromey  <tom@tromey.com>
3408
3409         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3410         (get_ada_tasks_pspace_data): Update.
3411         (ada_tasks_pspace_data_cleanup): Remove.
3412         (_initialize_tasks): Update.
3413         (ada_tasks_inferior_data_handle): Change type.
3414         (get_ada_tasks_inferior_data): Update.
3415         (ada_tasks_inferior_data_cleanup): Remove.
3416         (struct ada_tasks_pspace_data): Add initializers.
3417
3418 2019-05-08  Tom Tromey  <tom@tromey.com>
3419
3420         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3421         * symfile-debug.c (debug_sym_get_probes): Change type.
3422         * stap-probe.c (handle_stap_probe):
3423         (stap_static_probe_ops::get_probes): Change type.
3424         * probe.h (class static_probe_ops) <get_probes>: Change type.
3425         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3426         (parse_probes_in_pspace): Update.
3427         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3428         Update.
3429         (any_static_probe_ops::get_probes): Change type.
3430         * elfread.c (elfread_data): New typedef.
3431         (probe_key): Change type.
3432         (elf_get_probes): Likewise.  Update.
3433         (probe_key_free): Remove.
3434         (_initialize_elfread): Update.
3435         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3436         Change type.
3437         (dtrace_process_dof_probe, dtrace_process_dof)
3438         (dtrace_static_probe_ops::get_probe): Change type.
3439
3440 2019-05-08  Tom Tromey  <tom@tromey.com>
3441
3442         * xcoffread.c (struct xcoff_symfile_info): Rename from
3443         coff_symfile_info.  Add initializers.
3444         (xcoff_objfile_data_key): Move lower.  Change type.
3445         (XCOFF_DATA): Rewrite.
3446         (xcoff_free_info): Remove.
3447         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3448         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3449         (xcoff_initial_scan): Update.
3450
3451 2019-05-08  Tom Tromey  <tom@tromey.com>
3452
3453         * solib-svr4.c (struct svr4_info): Add initializers and
3454         destructor.
3455         <probes_table>: Now an htab_up.
3456         (solib_svr4_pspace_data): Change type.
3457         (free_probes_table): Simplify.
3458         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3459         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3460         (probes_table_remove_objfile_probes, register_solib_event_probe)
3461         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3462         (_initialize_svr4_solib): Update.
3463
3464 2019-05-08  Tom Tromey  <tom@tromey.com>
3465
3466         * remote.c (remote_pspace_data): Change type.
3467         (remote_pspace_data_cleanup): Remove.
3468         (get_remote_exec_file, set_pspace_remote_exec_file)
3469         (_initialize_remote): Update.
3470
3471 2019-05-08  Tom Tromey  <tom@tromey.com>
3472
3473         * breakpoint.c (breakpoint_objfile_key): Change type.
3474         (get_breakpoint_objfile_data): Update.
3475         (free_breakpoint_objfile_data): Remove.
3476         (_initialize_breakpoint): Update.
3477
3478 2019-05-08  Tom Tromey  <tom@tromey.com>
3479
3480         * linux-tdep.c (struct linux_info): Add initializers.
3481         (linux_inferior_data): Move.  Change type.
3482         (invalidate_linux_cache_inf): Update.
3483         (linux_inferior_data_cleanup): Remove.
3484         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3485
3486 2019-05-08  Tom Tromey  <tom@tromey.com>
3487
3488         * auxv.c (auxv_inferior_data): Move.  Change type.
3489         (auxv_inferior_data_cleanup): Remove.
3490         (invalidate_auxv_cache_inf): Rewrite.
3491         (get_auxv_inferior_data, _initialize_auxv): Update.
3492
3493 2019-05-08  Tom Tromey  <tom@tromey.com>
3494
3495         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3496         (symfile_debug_objfile_data_key): Change type.
3497         (symfile_debug_installed, debug_qf_has_symbols)
3498         (debug_qf_find_last_source_symtab)
3499         (debug_qf_forget_cached_source_info)
3500         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3501         (debug_qf_print_stats, debug_qf_dump)
3502         (debug_qf_expand_symtabs_for_function)
3503         (debug_qf_expand_all_symtabs)
3504         (debug_qf_expand_symtabs_with_fullname)
3505         (debug_qf_map_matching_symbols)
3506         (debug_qf_expand_symtabs_matching)
3507         (debug_qf_find_pc_sect_compunit_symtab)
3508         (debug_qf_map_symbol_filenames)
3509         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3510         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3511         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3512         (debug_sym_read_linetable, debug_sym_relocate): Update.
3513         (symfile_debug_free_objfile): Remove.
3514         (install_symfile_debug_logging, _initialize_symfile_debug):
3515         Update.
3516
3517 2019-05-08  Tom Tromey  <tom@tromey.com>
3518
3519         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3520         allocate_on_obstack.
3521         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3522         (get_dwarf2_per_objfile): Update.
3523         (set_dwarf2_per_objfile): Remove.
3524         (dwarf2_has_info, dwarf2_get_section_info): Update.
3525         (dwarf2_free_objfile): Remove.
3526         (_initialize_dwarf2_read): Update.
3527
3528 2019-05-08  Tom Tromey  <tom@tromey.com>
3529
3530         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3531         initializers.
3532         <unsupported_script_warning_printed,
3533         script_not_found_warning_printed>: Now bool.
3534         (auto_load_pspace_data): Change type.
3535         (~auto_load_pspace_info): Rename from
3536         auto_load_pspace_data_cleanup.
3537         (get_auto_load_pspace_data, init_loaded_scripts_info)
3538         (clear_section_scripts, maybe_print_unsupported_script_warning)
3539         (maybe_print_script_not_found_warning, _initialize_auto_load):
3540         Update.
3541
3542 2019-05-08  Tom Tromey  <tom@tromey.com>
3543
3544         * objfiles.c (objfile_pspace_info): Add destructor and
3545         initializers.
3546         (objfiles_pspace_data): Change type.
3547         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3548         (get_objfile_pspace_data): Update.
3549         (objfiles_bfd_data): Change type.
3550         (get_objfile_bfd_data): Update.
3551         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3552
3553 2019-05-08  Tom Tromey  <tom@tromey.com>
3554
3555         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3556         Change type.
3557         (get_catch_syscall_inferior_data): Update.
3558         (catch_syscall_inferior_data_cleanup): Remove.
3559         (_initialize_break_catch_syscall): Update.
3560
3561 2019-05-08  Tom Tromey  <tom@tromey.com>
3562
3563         * inflow.c (struct terminal_info): Add destructor and
3564         initializers.
3565         (inflow_inferior_data): Change type.
3566         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3567         (get_inflow_inferior_data, inflow_inferior_exit)
3568         (swap_terminal_info, _initialize_inflow): Update.
3569
3570 2019-05-08  Tom Tromey  <tom@tromey.com>
3571
3572         * target-dcache.c (target_dcache_cleanup): Remove.
3573         (target_dcache_aspace_key): Change type.
3574         (target_dcache_init_p, target_dcache_invalidate)
3575         (target_dcache_get, target_dcache_get_or_init)
3576         (_initialize_target_dcache): Update.
3577         * dcache.h (struct dcache_deleter): New.
3578
3579 2019-05-08  Tom Tromey  <tom@tromey.com>
3580
3581         * symtab.c (struct symbol_cache): Add destructor and
3582         initializers.
3583         (symbol_cache_key): Move.  Change type.
3584         (make_symbol_cache, free_symbol_cache): Remove.
3585         (get_symbol_cache): Update.
3586         (symbol_cache_cleanup): Remove.
3587         (ALL_PSPACES, symbol_cache_flush)
3588         (maintenance_print_symbol_cache)
3589         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3590         Update.
3591
3592 2019-05-08  Tom Tromey  <tom@tromey.com>
3593
3594         * symtab.c (struct main_info): Add destructor and initializers.
3595         (main_progspace_key): Move.  Change type.
3596         (get_main_info): Update.
3597         (main_info_cleanup): Remove.
3598         (_initialize_symtab): Update.
3599
3600 2019-05-08  Tom Tromey  <tom@tromey.com>
3601
3602         * registry.h (DECLARE_REGISTRY): Define the _key class.
3603
3604 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3605
3606         * NEWS: Merge two 'New commands' sections.
3607
3608 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3609
3610         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3611         parameter and use Ada language definition instead.
3612         (ada_val_print_ptr): Remove unused language parameter.
3613         (ada_val_print_num): Remove language parameter and use Ada language
3614         definition instead.
3615         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3616         parameter.
3617         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3618         parameter and use Ada language definition instead.
3619         (ada_val_print_1): Update all ada_val_print_xxx calls.
3620         Remove language parameter.
3621         (ada_val_print): Update ada_val_print_1 call.
3622
3623 2019-05-08  Tom Tromey  <tromey@adacore.com>
3624
3625         * remote.c (remote_hw_watchpoint_limit)
3626         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3627         Now static.
3628
3629 2019-05-08  Tom Tromey  <tromey@adacore.com>
3630
3631         * maint.c (_initialize_maint_cmds): Move initialization code to
3632         remote.c.
3633         (watchdog, show_watchdog): Move to remote.c.
3634         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3635         "watchdog" static.
3636         (_initialize_remote): Move initialization code from maint.c.
3637         * defs.h (watchdog): Don't declare.
3638
3639 2019-05-08  Tom Tromey  <tromey@adacore.com>
3640
3641         * tui/tui-interp.c: Include main.h.
3642         * interps.c: Include main.h.
3643         * main.h (interpreter_p): Declare.
3644         * defs.h (interpreter_p): Don't declare.
3645
3646 2019-05-08  Tom Tromey  <tromey@adacore.com>
3647
3648         * dwarf2loc.c: Include dwarf2read.h.
3649         * defs.h (read_unsigned_leb128): Don't declare.
3650         * dwarf2read.h (read_unsigned_leb128): Declare.
3651
3652 2019-05-08  Tom Tromey  <tromey@adacore.com>
3653
3654         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3655         method.
3656
3657 2019-05-08  Tom Tromey  <tromey@adacore.com>
3658
3659         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3660         when no wrap column is set.
3661
3662 2019-05-08  Tom Tromey  <tromey@adacore.com>
3663
3664         * c-lang.c (c_get_string): Handle non-C-style arrays.
3665
3666 2019-05-08  Tom Tromey  <tromey@adacore.com>
3667
3668         * typeprint.c (print_offset_data::update): Print the bit offset,
3669         not the number of bits remaining.
3670
3671 2019-05-08  Tom Tromey  <tromey@adacore.com>
3672
3673         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3674         padding at end of comment.
3675
3676 2019-05-08  Tom Tromey  <tromey@adacore.com>
3677
3678         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3679         Compare main types.
3680
3681 2019-05-06  Tom Tromey  <tom@tromey.com>
3682
3683         * common/scoped_mmap.c: Include common-defs.h.
3684         * common/scoped_mmap.h: Don't include config.h.
3685
3686 2019-05-04  Tom Tromey  <tom@tromey.com>
3687
3688         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3689         (struct aarch64_call_info): Add initializers.
3690         <si>: Now a std::vector.
3691         (pass_on_stack, aarch64_push_dummy_call): Update.
3692
3693 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3694             Tom Tromey  <tom@tromey.com>
3695
3696         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3697         (ppc_threads): Now a std::vector.  Now static.
3698         (hwdebug_find_thread_points_by_tid)
3699         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3700         Update.
3701
3702 2019-05-04  Tom Tromey  <tom@tromey.com>
3703
3704         * arc-tdep.c (arc_tdesc_init): Return bool.
3705
3706 2019-05-04  Tom Tromey  <tom@tromey.com>
3707
3708         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3709         Use gdb_assert_not_reached.
3710
3711 2019-05-04  Tom Tromey  <tom@tromey.com>
3712
3713         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3714         "false".
3715
3716 2019-05-04  Tom Tromey  <tom@tromey.com>
3717
3718         * arc-tdep.c (arc_tdesc_init): Use bool.
3719
3720 2019-05-04  Tom Tromey  <tom@tromey.com>
3721
3722         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3723
3724 2019-05-04  Tom Tromey  <tom@tromey.com>
3725
3726         * cli/cli-cmds.c (valid_command_p): Return bool.
3727
3728 2019-05-04  Tom Tromey  <tom@tromey.com>
3729
3730         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3731         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3732
3733 2019-05-04  Raul Tambre  <raul@tambre.ee>
3734
3735         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3736         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3737         operator for comparison.
3738
3739 2019-05-04  Tom Tromey  <tom@tromey.com>
3740
3741         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3742         (lookup_partial_symbol, print_partial_symbols)
3743         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3744         (psymbol_compare): Update.
3745         (add_psymbol_to_bcache): Clear the entire psymbol.
3746         (maintenance_check_psymtabs): Update.
3747         * psympriv.h (struct partial_symbol): Don't derive from
3748         general_symbol_info.
3749         <obj_section, unrelocated_address, address,
3750         set_unrelocated_address>: Update.
3751         <ginfo>: New member.
3752         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3753         (debug_names::write_psymbols): Update.
3754
3755 2019-05-04  Tom de Vries  <tdevries@suse.de>
3756
3757         * contrib/cc-with-tweaks.sh: Support -n arg.
3758
3759 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3760
3761         * corelow.c (core_target::detach): Ensure frame cache and
3762         register caches are cleared.
3763         inferior.c (exit_inferior_1): Likewise.
3764
3765 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3766             Tom Tromey  <tom@tromey.com>
3767
3768         * dictionary.c (collate_pending_symbols_by_language): Remove
3769         "struct" from foreach.
3770         * symtab.c (lookup_global_symbol_from_objfile)
3771         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3772         foreach.
3773         * ser-tcp.c (net_open): Remove "struct" from foreach.
3774         * objfiles.c (objfile_relocate, objfile_rebase)
3775         (objfile_has_symbols): Remove "struct" from foreach.
3776         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3777         from foreach.
3778         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3779         foreach.
3780         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3781         "struct" from foreach.
3782         * ada-lang.c (create_excep_cond_exprs)
3783         (ada_exception_catchpoint_cond_string): Remove "struct" from
3784         foreach.
3785
3786 2019-05-03  Tom Tromey  <tromey@adacore.com>
3787
3788         * ada-exp.y (convert_char_literal): Check suffix of each
3789         enumerator.
3790
3791 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3792
3793         PR ada/21406:
3794         * ada-exp.y (yywrap): Don't define.
3795         * ada-lex.l (%option): Add noyywrap
3796         (yywrap): Remove.
3797
3798 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3799
3800         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3801         _WIN32_WINNT to the XP level, unless already defined to a higher
3802         level.
3803
3804         * unittests/parse-connection-spec-selftests.c:
3805         * ser-tcp.c:
3806         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3807         override.
3808
3809         * symfile.c (find_separate_debug_file): Remove colon from the
3810         drive spec of DOS/Windows file names of the target, so that the
3811         file name produced from DEBUGDIR and the target's directory will
3812         be valid on DOS/Windows systems.
3813
3814 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3815
3816         * rust-lang.c (val_print_struct): Handle printing structures
3817         containing strings.
3818
3819 2019-05-02  Tom Tromey  <tromey@adacore.com>
3820
3821         * valarith.c (_initialize_valarith): Remove.
3822
3823 2019-05-01  Tom Tromey  <tromey@adacore.com>
3824
3825         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3826         bitfields.
3827
3828 2019-05-01  Tom Tromey  <tromey@adacore.com>
3829
3830         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3831         for big-endian copies.
3832
3833 2019-04-30  Ali Tamur  <tamur@google.com>
3834         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3835         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3836         (read_3_bytes): New function.
3837
3838 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3839
3840         * windows-nat.c (main_thread_id): Delete.
3841         (handle_output_debug_string): Replace main_thread_id by
3842         current_event.dwThreadId.
3843         (fake_create_process): Likewise.
3844         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3845         Do not set main_thread_id.
3846         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3847         current_event.dwThreadId.
3848         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3849
3850 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3851
3852         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3853         Use current_event.dwThreadId instead of main_thread_id.
3854
3855 2019-04-30  Tom Tromey  <tromey@adacore.com>
3856
3857         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3858         (create_excep_cond_exprs): Iterate over program spaces.
3859         (ada_exception_catchpoint_cond_string): Examine all minimal
3860         symbols for exception types.
3861
3862 2019-04-30  Tom Tromey  <tromey@adacore.com>
3863
3864         PR c++/24470:
3865         * dwarf2read.c (process_structure_scope): Handle case where type
3866         has template parameters but no symbol was created.
3867
3868 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3869             Chris January  <chris.january@arm.com>
3870
3871         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3872         qualifier.
3873         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3874
3875 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3876
3877         * f-typeprint.c (f_print_type): Update rules for printing
3878         whitespace.
3879         (f_type_print_varspec_suffix): Likewise.
3880
3881 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3882             Chris January  <chris.january@arm.com>
3883
3884         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3885         function arguments.
3886
3887 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3888
3889         * f-lang.c (build_fortran_types): Change name of void type to
3890         lower case.
3891         * f-typeprint.c (f_type_print_base): Print the name of the void
3892         type, rather than a fixed string.
3893         * f-valprint.c (f_decorations): Use lower case void string.
3894
3895 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3896             Chris January  <chris.january@arm.com>
3897
3898         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3899         types for Fortran.
3900
3901 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3902             Chris January  <chris.january@arm.com>
3903             David Lecomber  <david.lecomber@arm.com>
3904
3905         * f-exp.y (BINOP_INTRINSIC): New token.
3906         (exp): New parser rule handling BINOP_INTRINSIC.
3907         (f77_keywords): Add new builtin procedures.
3908         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3909         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3910         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3911         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3912         (print_unop_subexp_f): New function.
3913         (print_binop_subexp_f): New function.
3914         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3915         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3916         (dump_subexp_body_f): Likewise.
3917         (operator_check_f): Likewise.
3918         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3919         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3920
3921 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3922
3923         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3924         UNOP_KIND.
3925         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3926         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3927         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3928         (operator_length_f): New fuction.
3929         (print_subexp_f): New function.
3930         (op_name_f): New function.
3931         (dump_subexp_body_f): New function.
3932         (operator_check_f): New function.
3933         (exp_descriptor_f): Replace standard expression handling functions
3934         with new functions.
3935         * gdb/fortran-operator.def: New file.
3936         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3937         * gdb/std-operator.def: Remove UNOP_KIND.
3938
3939 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3940
3941         * std-operator.def: Remove unbalanced, stray double quote
3942         character.
3943
3944 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3945             Chris January  <chris.january@arm.com>
3946             Daniel Everett  <daniel.everett@arm.com>
3947             Nick Forrington  <nick.forrington@arm.com>
3948             Richard Bunt  <richard.bunt@arm.com>
3949
3950         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3951         of depth when printing anonymous structs or unions.
3952         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3953         Don't print either the top-level value, or the children if the
3954         max-depth is exceeded.
3955         (ppscm_print_children): When printing the key of a map, allow one
3956         extra level of depth.
3957         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3958         print either the top-level value, or the children if the max-depth
3959         is exceeded.
3960         (print_children): When printing the key of a map, allow one extra
3961         level of depth.
3962         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3963         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3964         (user_print_options): Initialise max_depth field.
3965         (val_print_scalar_or_string_type_p): New function.
3966         (val_print): Check to see if the max depth has been reached.
3967         (val_print_check_max_depth): Define new function.
3968         (show_print_max_depth): New function.
3969         (_initialize_valprint): Add 'print max-depth' option.
3970         * valprint.h (struct value_print_options) <max_depth>: New field.
3971         (val_print_check_max_depth): Declare new function.
3972         * NEWS: Document new feature.
3973
3974 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3975
3976         * ada-lang.c (ada_language_defn): Initialise new field.
3977         * c-lang.c (c_is_string_type_p): New function.
3978         (c_language_defn): Initialise new field.
3979         (cplus_language_defn): Initialise new field.
3980         (asm_language_defn): Initialise new field.
3981         (minimal_language_defn): Initialise new field.
3982         * c-lang.h (c_is_string_type_p): Declare new function.
3983         * d-lang.c (d_language_defn): Initialise new field.
3984         * f-lang.c (f_is_string_type_p): New function.
3985         (f_language_defn): Initialise new field.
3986         * go-lang.c (go_is_string_type_p): New function.
3987         (go_language_defn): Initialise new field.
3988         * language.c (default_is_string_type_p): New function.
3989         (unknown_language_defn): Initialise new field.
3990         (auto_language_defn): Initialise new field.
3991         * language.h (struct language_defn) <la_is_string_type_p>: New
3992         member variable.
3993         (default_is_string_type_p): Declare new function.
3994         * m2-lang.c (m2_language_defn): Initialise new field.
3995         * objc-lang.c (objc_language_defn): Initialise new field.
3996         * opencl-lang.c (opencl_language_defn): Initialise new field.
3997         * p-lang.c (pascal_is_string_type_p): New function.
3998         (pascal_language_defn): Initialise new field.
3999         * rust-lang.c (rust_is_string_type_p): New function.
4000         (rust_language_defn): Initialise new field.
4001
4002 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4003
4004         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4005         New field.
4006         * ada-lang.c (ada_language_defn): Initialise new field.
4007         * c-lang.c (c_language_defn): Likewise.
4008         (cplus_language_defn): Likewise.
4009         (asm_language_defn): Likewise.
4010         (minimal_language_defn): Likewise.
4011         * d-lang.c (d_language_defn): Likewise.
4012         * f-lang.c (f_language_defn): Likewise.
4013         * go-lang.c (go_language_defn): Likewise.
4014         * language.c (unknown_language_defn): Likewise.
4015         (auto_language_defn): Likewise.
4016         * m2-lang.c (m2_language_defn): Likewise.
4017         * objc-lang.c (objc_language_defn): Likewise.
4018         * opencl-lang.c (opencl_language_defn): Likewise.
4019         * p-lang.c (pascal_language_defn): Likewise.
4020         * rust-lang.c (rust_language_defn): Likewise.
4021
4022 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4023
4024         * ada-lang.c (ada_is_character_type): Change return type to bool.
4025         (ada_is_string_type): Likewise.
4026         * ada-lang.h (ada_is_character_type): Update declaration
4027         (ada_is_string_type): Likewise.
4028
4029 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4030
4031         Support style in 'frame|thread apply'
4032
4033         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4034         * record.c (record_start, record_stop): Update callers of
4035         execute_command_to_string with false.
4036         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4037         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4038         methods.
4039         (class string_file): New constructor with term_out parameter.
4040         Override methods term_out and can_emit_style_escape.  New member
4041         term_out.
4042         (class stdio_file): Override can_emit_style_escape.
4043         (class tee_file): Override term_out and can_emit_style_escape.
4044         * utils.h (can_emit_style_escape): Remove.
4045         * utils.c (can_emit_style_escape): Likewise.
4046         Update all callers of can_emit_style_escape (SOMESTREAM) to
4047         SOMESTREAM->can_emit_style_escape.
4048         * source-cache.c (source_cache::get_source_lines): Likewise.
4049         * stack.c (frame_apply_command_count): Call execute_command_to_string
4050         passing the term_out characteristic of the current gdb_stdout.
4051         * thread.c (thr_try_catch_cmd): Likewise.
4052         * top.c (execute_command_to_string): pass term_out parameter
4053         to construct the string_file for the command output.
4054         * ui-file.c (term_cli_styling): New function (most code moved
4055         from utils.c can_emit_style_escape).
4056         (string_file::string_file, string_file::can_emit_style_escape,
4057         stdio_file::can_emit_style_escape, tee_file::term_out,
4058         tee_file::can_emit_style_escape): New functions.
4059
4060 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4061
4062         * NEWS: Mention the new set|show may-call-functions.
4063         * infcall.c (may_call_functions_p): New variable.
4064         (show_may_call_functions_p): New function.
4065         (call_function_by_hand_dummy): Throws an error if not
4066         may-call-functions.
4067         (_initialize_infcall): Call add_setshow_boolean_cmd for
4068         may-call-functions.
4069
4070 2019-04-25  Keith Seitz  <keiths@redhat.com>
4071
4072         PR c++/24367
4073         * cp-support.c (inspect_type): Don't attempt substitutions
4074         of symbol with the same name.
4075
4076 2019-04-25  Tom Tromey  <tromey@adacore.com>
4077
4078         PR gdb/24475:
4079         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4080         static.
4081
4082 2019-04-25  Tom Tromey  <tromey@adacore.com>
4083
4084         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4085         rvalue reference.
4086         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4087         (gdb_xml_parser::parse): Use std::move.
4088         * python/python-internal.h (gdbpy_convert_exception): Take a const
4089         reference.
4090         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4091         std::move.
4092         * python/py-utils.c (gdbpy_convert_exception): Take a const
4093         reference.
4094         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4095         Use std::move.
4096         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4097         Use std::move.
4098         * mi/mi-main.c (mi_print_exception): Take a const reference.
4099         * main.c (handle_command_errors): Take a const reference.
4100         * linespec.c (parse_linespec): Use std::move.
4101         * infcall.c (run_inferior_call): Use std::move.
4102         (call_function_by_hand_dummy): Use std::move.
4103         * exec.c (try_open_exec_file): Use std::move.
4104         * exceptions.h (exception_print, exception_fprintf)
4105         (exception_print_same): Update.
4106         * exceptions.c (print_exception, exception_print)
4107         (exception_fprintf, exception_print_same): Change parameters to
4108         const reference.
4109         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4110         * common/new-op.c: Use std::move.
4111         * common/common-exceptions.h (struct gdb_exception): Add move
4112         constructor.
4113         (struct gdb_exception_error, struct gdb_exception_quit, struct
4114         gdb_quit_bad_alloc): Change constructor to move constructor.
4115         (throw_exception): Change parameter to rvalue reference.
4116         * common/common-exceptions.c (throw_exception): Take rvalue
4117         reference.
4118         * cli/cli-interp.c (safe_execute_command): Use std::move.
4119         * breakpoint.c (insert_bp_location, location_to_sals): Use
4120         std::move.
4121
4122 2019-04-25  Tom Tromey  <tromey@adacore.com>
4123
4124         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4125         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4126         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4127         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4128         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4129         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4130         guile/scm-value.c: Use unpack.
4131         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4132         gdbscm_gdb_exception.
4133         (gdbscm_throw_gdb_exception): Likewise.
4134         (struct gdbscm_gdb_exception): New.
4135         (unpack): New function.
4136         (gdbscm_wrap): Use unpack.
4137
4138 2019-04-25  Tom Tromey  <tromey@adacore.com>
4139
4140         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4141         (gdb_rl_callback_handler): Use std::move.
4142         * common/common-exceptions.h (struct gdb_exception): Add move
4143         assignment operator.
4144         (throw_exception_sjlj): Change "exception" to const reference.
4145         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4146         (throw_exception_sjlj): Change "exception" to const reference.
4147
4148 2019-04-25  Tom Tromey  <tromey@adacore.com>
4149
4150         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4151         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4152         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4153         Update.
4154         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4155         Update.
4156         * mi/mi-interp.c (mi_interp::exec): Update.
4157         * linespec.c (parse_linespec): Update.
4158         * infcall.c (run_inferior_call): Update.
4159         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4160         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4161         (gdbscm_lookup_global_symbol): Update.
4162         * guile/scm-param.c (gdbscm_parameter_value): Update.
4163         * guile/scm-frame.c (gdbscm_frame_read_register)
4164         (gdbscm_frame_read_var): Update.
4165         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4166         * exec.c (try_open_exec_file): Update.
4167         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4168         (gdb_rl_callback_handler): Update.
4169         * common/common-exceptions.h (exception_none): Don't declare.
4170         * common/common-exceptions.c (exception_none): Don't define.
4171         (struct catcher) <exception>: Update.
4172         * cli/cli-interp.c (safe_execute_command): Update.
4173         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4174
4175 2019-04-25  Ali Tamur  <tamur@google.com>
4176
4177         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4178         (read_attribute_value): Likewise.
4179         (dwarf2_read_addr_index): Update comment.
4180         (read_str_index): Add DW_FORM_strx.
4181         (dwarf2_string_attr): Likewise.
4182         (dwarf2_const_value_attr): Likewise.
4183         (dump_die_shallow): Likewise.
4184         (dwarf2_fetch_constant_bytes): Likewise.
4185         (skip_form_bytes): Likewise.
4186         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4187
4188 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4189
4190         PR corefiles/11608
4191         PR corefiles/18187
4192         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4193         OFFSET.  Verify if current mapping contains an ELF header.
4194         (linux_find_memory_regions_full): Adjust call to
4195         dump_mapping_p.
4196
4197 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4198             Kang Li <kanglictf@gmail.com>
4199
4200         PR gdb/21600
4201
4202         * dwarf2-frame.c (read_initial_length): Be consistent about using
4203         unsigned representation of length.
4204         (decode_frame_entry_1): Likewise.  Check for wraparound of
4205         end pointer as well as buffer overflow.
4206
4207 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4208
4209         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4210         "vq".
4211
4212 2019-04-24  Tom Tromey  <tromey@adacore.com>
4213
4214         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4215
4216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4217
4218         * s12z-tdep.c (s12z_unwind_pc): Delete.
4219         (s12z_unwind_sp): Delete.
4220         (s12z_gdbarch_init): Don't register deleted functions with
4221         gdbarch.
4222
4223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4224
4225         * rl78-tdep.c (rl78_unwind_sp): Delete.
4226         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4227
4228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4231         (xstormy16_unwind_pc): Delete.
4232         (xstormy16_dummy_id): Delete.
4233         (xstormy16_gdbarch_init): Don't register deleted functions with
4234         gdbarch.
4235
4236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4237
4238         * vax-tdep.c (vax_unwind_pc): Delete.
4239         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4240
4241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4242
4243         * v850-tdep.c (v850_unwind_sp): Delete.
4244         (v850_unwind_pc): Delete.
4245         (v850_dummy_id): Delete.
4246         (v850_gdbarch_init): Don't register deleted functions with
4247         gdbarch.
4248
4249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4250
4251         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4252         (tilegx_unwind_pc): Delete.
4253         (tilegx_unwind_dummy_id): Delete.
4254         (tilegx_gdbarch_init): Don't register deleted functions with
4255         gdbarch.
4256
4257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4260         (tic6x_dummy_id): Delete.
4261         (tic6x_gdbarch_init): Don't register deleted functions with
4262         gdbarch.
4263
4264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4265
4266         * sparc-tdep.c (sparc_unwind_pc): Delete.
4267         (sparc32_gdbarch_init): Don't register deleted function with
4268         gdbarch.
4269
4270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         * sh-tdep.c (sh_unwind_sp): Delete.
4273         (sh_unwind_pc): Delete.
4274         (sh_dummy_id): Delete.
4275         (sh_gdbarch_init): Don't register deleted functions with
4276         gdbarch.
4277
4278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4279
4280         * score-tdep.c (score_unwind_sp): Delete.
4281         (score_unwind_pc): Delete.
4282         (score_dummy_id): Delete.
4283         (score_gdbarch_init): Don't register deleted functions with
4284         gdbarch.
4285
4286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4287
4288         * rx-tdep.c (rx_unwind_pc): Delete.
4289         (rx_unwind_sp): Delete.
4290         (rx_dummy_id): Delete.
4291         (rx_gdbarch_init): Don't register deleted functions with
4292         gdbarch.  Update comment.
4293
4294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4295
4296         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4297         (rs6000_dummy_id): Delete.
4298         (rs6000_gdbarch_init): Don't register deleted functions with
4299         gdbarch.
4300
4301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4302
4303         * or1k-tdep.c (or1k_dummy_id): Delete.
4304         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4305
4306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4307
4308         * nios2-tdep.c (nios2_dummy_id): Delete.
4309         (nios2_unwind_sp): Delete.
4310         (nios2_gdbarch_init): Don't register deleted functions with
4311         gdbarch.
4312
4313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4314
4315         * nds32-tdep.c (nds32_dummy_id): Delete.
4316         (nds32_unwind_pc): Delete.
4317         (nds32_unwind_sp): Delete.
4318         (nds32_gdbarch_init): Don't register deleted functions with
4319         gdbarch.
4320
4321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4322
4323         * msp430-tdep.c (msp430_unwind_pc): Delete.
4324         (msp430_unwind_sp): Delete.
4325         (msp430_dummy_id): Delete.
4326         (msp430_gdbarch_init): Don't register deleted functions with
4327         gdbarch.
4328
4329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4330
4331         * moxie-tdep.c (moxie_unwind_sp): Delete.
4332         (moxie_unwind_pc): Delete.
4333         (moxie_dummy_id): Delete.
4334         (moxie_gdbarch_init): Don't register deleted functions with
4335         gdbarch.
4336
4337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4338
4339         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4340         (mn10300_unwind_pc): Delete.
4341         (mn10300_unwind_sp): Delete.
4342         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4343         mn10300_unwind_sp.
4344         (mn10300_frame_unwind_init): Don't register deleted functions with
4345         gdbarch.
4346
4347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4348
4349         * mep-tdep.c (mep_unwind_pc): Delete.
4350         (mep_unwind_sp): Delete.
4351         (mep_dummy_id): Delete.
4352         (mep_gdbarch_init): Don't register deleted functions with
4353         gdbarch.
4354
4355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4358         (m68hc11_unwind_sp): Delete.
4359         (m68hc11_gdbarch_init): Don't register deleted functions with
4360         gdbarch.
4361
4362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4363
4364         * m32r-tdep.c (m32r_unwind_sp): Delete.
4365         (m32r_unwind_pc): Delete.
4366         (m32r_dummy_id): Delete.
4367         (m32r_gdbarch_init): Don't register deleted functions with
4368         gdbarch.
4369
4370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4371
4372         * m32c-tdep.c (m32c_unwind_pc): Delete.
4373         (m32c_unwind_sp): Delete.
4374         (m32c_dummy_id): Delete.
4375         (m32c_gdbarch_init): Don't register deleted functions with
4376         gdbarch.
4377
4378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4379
4380         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4381         (lm32_unwind_pc): Delete.
4382         (lm32_dummy_id): Delete.
4383         (lm32_gdbarch_init): Don't register deleted functions with
4384         gdbarch.
4385
4386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4387
4388         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4389         (iq2000_unwind_pc): Delete.
4390         (iq2000_dummy_id): Delete.
4391         (iq2000_gdbarch_init): Don't register deleted functions with
4392         gdbarch.
4393
4394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4395
4396         * nds32-tdep.c (nds32_type_align): Delete.
4397         (nds32_push_dummy_call): Use type_align instead.
4398
4399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4400
4401         * arm-tdep.c (arm_type_align): Only handle vector override case.
4402         (arm_push_dummy_call): Use type_align.
4403         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4404
4405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4406
4407         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4408         case.
4409         (pass_on_stack): Use type_align.
4410         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4411         function.
4412
4413 2019-04-23  Tom Tromey  <tromey@adacore.com>
4414
4415         * dwarf2read.c (line_header::file_name_at): Remove unused
4416         overload.
4417
4418 2019-04-23  Tom de Vries  <tdevries@suse.de>
4419
4420         PR gdb/24438
4421         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4422         invocation.
4423
4424
4425 2019-03-27  Ali Tamur  <tamur@google.com>
4426
4427         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4428         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4429         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4430         (dwarf_expr_context::get_addr_index): Likewise
4431         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4432         (symbol_needs_eval_context::get_addr_index): Likewise
4433         (disassemble_dwarf_expression): Add DW_OP_addrx
4434         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4435         (read_cutu_die_from_dwo): Update comment
4436         (skip_one_die): Add DW_FORM_addrx
4437         (read_attribute_value): Likewise
4438         (var_decode_location): Add DW_OP_addrx
4439         (dwarf2_const_value_attr): Add DW_FORM_addrx
4440         (dump_die_shallow): Likewise
4441         (dwarf2_fetch_constant_bytes): Likewise
4442         (decode_locdesc): Add DW_OP_addrx
4443         (skip_form_bytes): Add DW_FORM_addrx
4444
4445 2019-04-22  Ali Tamur  <tamur@google.com>
4446
4447         * MAINTAINERS (Write After Approval): Add self.
4448
4449 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4450
4451         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4452         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4453         (open_symbol_file_object): Likewise.
4454         (svr4_default_sos): Add info parameter.
4455         (svr4_read_so_list): Likewise.
4456         (svr4_current_sos_direct): Adjust functions calls to pass down
4457         info.
4458         (svr4_current_sos_1): Add info parameter.
4459         (svr4_current_sos): Call get_svr4_info, pass info down to
4460         svr4_current_sos_1.
4461         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4462         get_svr4_info.
4463         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4464         get_svr4_info.
4465         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4466         to get_svr4_info.
4467         (probes_table_remove_objfile_probes): Likewise.
4468         (register_solib_event_probe): Add info parameter.
4469         (solist_update_incremental): Pass info parameter down to
4470         svr4_read_so_list.
4471         (disable_probes_interface): Add info parameter.
4472         (svr4_handle_solib_event): Pass current_program_space to
4473         get_svr4_info.  Adjust disable_probes_interface cleanup.
4474         (svr4_create_probe_breakpoints): Add info parameter, pass it
4475         down to register_solib_event_probe.
4476         (svr4_create_solib_event_breakpoints): Add info parameter,
4477         pass it down to svr4_create_probe_breakpoints.
4478         (enable_break): Pass info down to
4479         svr4_create_solib_event_breakpoints.
4480         (svr4_solib_create_inferior_hook): Pass current_program_space to
4481         get_svr4_info.
4482         (svr4_clear_solib): Likewise.
4483
4484 2019-04-22  Pedro Alves  <palves@redhat.com>
4485
4486         * solib-svr4.c (svr4_free_objfile_observer): New.
4487         (probe_and_action::objfile): New field.
4488         (probes_table_htab_remove_objfile_probes)
4489         (probes_table_remove_objfile_probes): New functions.
4490         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4491         in the new probe_and_action.  Don't store the probe in 'lookup'.
4492         (svr4_create_probe_breakpoints): Pass objfile to
4493         register_solib_event_probe.
4494         (_initialize_svr4_solib): Register a free_objfile observer.
4495
4496 2019-04-19  Tom Tromey  <tom@tromey.com>
4497
4498         * common/queue.h: Remove.
4499
4500 2019-04-19  Tom Tromey  <tom@tromey.com>
4501
4502         * event-loop.c: Don't include "common/queue.h".
4503
4504 2019-04-19  Tom Tromey  <tom@tromey.com>
4505
4506         * remote.c (remote_target): Use delete.
4507         * remote-notif.h: Include <list>, not "common/queue.h".
4508         (notif_client_p): Remove typedef.
4509         (remote_notif_state): Add constructor, destructor, initializer.
4510         <notif_queue>: Now a std::list.
4511         (remote_notif_state_xfree): Don't declare.
4512         * remote-notif.c (remote_notif_process, handle_notification)
4513         (remote_notif_state_allocate): Update.
4514         (~remote_notif_state): Rename from remote_notif_state_xfree.
4515
4516 2019-04-19  Tom Tromey  <tom@tromey.com>
4517
4518         * symfile.c (reread_symbols): Update.
4519         * objfiles.c (objfile_register_static_link)
4520         (objfile_lookup_static_link): Update
4521         (~objfile) Don't delete static_links.
4522         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4523
4524 2019-04-19  Tom Tromey  <tom@tromey.com>
4525
4526         * type-stack.h (struct type_stack) <insert>: Constify string.
4527         * type-stack.c (type_stack::insert): Constify string.
4528         * gdbtypes.h (lookup_template_type): Update.
4529         (address_space_name_to_int): Update.
4530         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4531         const.
4532         (lookup_template_type): Make name const.
4533         * c-exp.y: Update rules.
4534         (lex_one_token, classify_name, classify_inner_name)
4535         (c_print_token): Update.
4536         * p-exp.y: Update rules.
4537         (yylex): Update.
4538         * f-exp.y: Update rules.
4539         (yylex): Update.
4540         * d-exp.y: Update rules.
4541         (lex_one_token, classify_name, classify_inner_name): Update.
4542         * parse.c (write_dollar_variable, copy_name): Return std::string.
4543         * parser-defs.h (copy_name): Change return type.
4544         * m2-exp.y: Update rules.
4545         (yylex): Update.
4546         * go-exp.y (lex_one_token): Update.
4547         Update rules.
4548         (classify_unsafe_function, classify_packaged_name)
4549         (classify_name, yylex): Update.
4550
4551 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4552
4553         * configure.ac: add --enable-source-highlight switch.
4554         * configure: Regenerate.
4555         * top.c (print_gdb_version): plumb --enable-source-highlight
4556         status to "show configuration".
4557
4558 2019-04-19  Tom Tromey  <tromey@adacore.com>
4559
4560         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4561         Check ADA_TYPE_P.
4562         (empty_record, ada_template_to_fixed_record_type_1)
4563         (template_to_static_fixed_type)
4564         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4565         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4566         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4567         macros.
4568
4569 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4570
4571         PR symtab/24423:
4572         * source.c (print_source_lines_base): Advance "iter" when a
4573         control character is seen.
4574
4575 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4576
4577         * inferior.h (struct infcall_suspend_state_deleter):
4578         Catch exception in destructor to avoid crash.
4579
4580 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4581
4582         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4583         close to the add_com "shell".
4584
4585 2019-04-18  Tom Tromey  <tromey@adacore.com>
4586
4587         * process-stratum-target.h (class process_stratum_target)
4588         <stratum>: Add "final".
4589
4590 2019-04-17  Tom Tromey  <tromey@adacore.com>
4591
4592         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4593         against nullptr before use.
4594
4595 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4596
4597         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4598
4599 2019-04-17  Jim Wilson  <jimw@sifive.com>
4600             Andrew Burgess  <andrew.burgess@embecosm.com>
4601
4602         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4603         code read might fail, assume 4-byte breakpoint in that case.
4604
4605 2019-04-15  Leszek Swirski  <leszeks@google.com>
4606
4607         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4608         rather than a hand-rolled POD check when checking for forced MEMORY
4609         classification.
4610
4611 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4612
4613         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4614         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4615         function.
4616         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4617         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4618         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4619         declaration.
4620
4621 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4622
4623         * aarch64-linux-nat.c
4624         (aarch64_linux_nat_target::thread_architecture): Add override.
4625         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4626         each VQ.
4627
4628 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4629
4630         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4631
4632 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4633
4634         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4635         target types of size 96-bits, add some additional comments, and
4636         check that the builtin type we found was the correct size.
4637
4638 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4639
4640         * utils.c (prompt_for_continue): Don't restore the styling at the
4641         end, as applied_style has the wrong value.  This fixes styling in
4642         long lists of file names that are interrupted by the "Continue?"
4643         prompt.
4644
4645 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4646
4647         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4648         * c-lang.c (c_language_defn): Likewise.
4649         (cplus_language_defn): Likewise.
4650         (asm_language_defn): Likewise.
4651         (minimal_language_defn): Likewise.
4652         * d-lang.c (d_language_defn): Likewise.
4653         * f-lang.c (f_language_defn): Likewise.
4654         * go-lang.c (go_language_defn): Likewise.
4655         * language.c (unknown_language_defn): Likewise.
4656         (auto_language_defn): Likewise.
4657         * language.h (struct language_defn): Remove la_magic field.
4658         (LANG_MAGIC): Delete.
4659         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4660         * objc-lang.c (objc_language_defn): Likewise.
4661         * opencl-lang.c (opencl_language_defn): Likewise.
4662         * p-lang.c (pascal_language_defn): Likewise.
4663         * rust-lang.c (rust_language_defn): Likewise.
4664
4665 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4666
4667         * riscv-tdep.c (riscv_type_align): New function.
4668         (riscv_type_alignment): Delete.
4669         (riscv_arg_location): Use 'type_align'.
4670         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4671
4672 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4673
4674         * gdbtypes.c (type_align): A struct with no non-static fields also
4675         has alignment of 1.
4676
4677 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4678
4679         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4680         component to 0.
4681         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4682         member.
4683         (riscv_struct_info::analyse): New implementation using new
4684         analyse_inner member function.
4685         (riscv_struct_info::field_offset): New member function.
4686         (riscv_struct_info::m_offsets): New member variable.
4687         (riscv_struct_info::analyse_inner): New private member function,
4688         takes the old implementation of riscv_struct_info::analyse but
4689         extended to track field offsets.
4690         (riscv_call_arg_struct): Update the struct folding special cases
4691         to handle cases where empty C++ structs, which are non-zero
4692         length, are found.
4693         (riscv_arg_location): Initialise the length of each location, a
4694         non-zero length now indicates the location is in use.
4695         (riscv_push_dummy_call): Allow for the first location having a
4696         non-zero offset when setting up arguments.
4697         (riscv_return_value): Likewise, but for return values.
4698
4699 2019-04-11  Tom Tromey  <tromey@adacore.com>
4700
4701         * utils.c (internal_vproblem): Make "msg" const.
4702
4703 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4704
4705         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4706         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4707         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4708         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4709
4710 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4711
4712         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4713         function.
4714         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4715         of amd64_collect_native_gregset.
4716         (amd64_linux_nat_target::store_registers): Likewise.
4717
4718 2019-04-10  Tom Tromey  <tom@tromey.com>
4719
4720         * symtab.c (lookup_global_symbol_from_objfile)
4721         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4722         * objfiles.h (class separate_debug_iterator): New.
4723         (class separate_debug_range): New.
4724         (struct objfile) <separate_debug_objfiles>: New method.
4725         (objfile_separate_debug_iterate): Don't declare.
4726         * objfiles.c (separate_debug_iterator::operator++): Rename from
4727         objfile_separate_debug_iterate.
4728         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4729         iterator.
4730         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4731         iterator.
4732
4733 2019-04-10  Tom Tromey  <tom@tromey.com>
4734
4735         * symfile.c (reread_symbols): Remove old comment.
4736         * objfiles.c (free_all_objfiles): Fix a typo.
4737
4738 2019-04-10  Tom Tromey  <tom@tromey.com>
4739
4740         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4741         * minsyms.c (lookup_minimal_symbol): Use foreach.
4742         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4743         (lookup_minimal_symbol_solib_trampoline): Likewise.
4744         * symfile.c (reread_symbols): Use foreach.
4745
4746 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4747             Tom Tromey  <tromey@adacore.com>
4748
4749         PR rust/24414:
4750         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4751         (rust_lex_int_test): Change "value" to be LONGEST.
4752         (rust_lex_tests): Add test for long integer literal.
4753
4754 2019-04-09  Tom Tromey  <tromey@adacore.com>
4755
4756         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4757         to bool.
4758         (extended_remote_target::attach): Update.
4759         (remote_target::remote_notice_new_inferior): Update.
4760         (remote_target::add_current_inferior_and_thread): Update.
4761         * inferior.c (exit_inferior_1): Use "false".
4762         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4763
4764 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4765
4766         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4767         the "start" command.
4768
4769 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4770
4771         * python/py-inferior.c (infpy_thread_from_thread_handle):
4772         Adjust comments to reflect renaming of thread_from_thread_handle
4773         to thread_from_handle.  Adjust keywords.  Fix type error message.
4774         (inferior_object_methods): Add thread_from_handle.  Retain
4775         thread_from_thread_handle, but mark it as deprecated.
4776
4777 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4778
4779         * gdbthread.h (find_thread_by_handle): Revise declaration.
4780         * thread.c (find_thread_by_handle): Likewise.  Adjust
4781         implementation too.
4782         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4783         support for buffer objects as handles.
4784
4785 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4786
4787         * python/py-infthread.c (thpy_thread_handle): New function.
4788         (thread_object_methods): Register thpy_thread_handle.
4789
4790 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4791
4792         * gdbthread.h (thread_to_thread_handle): Declare.
4793         * thread.c (gdbtypes.h): Include.
4794         (thread_to_thread_handle): New function.
4795
4796         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4797         (target_thread_info_to_thread_handle): Declare.
4798         * target.c (target_thread_info_to_thread_handle): New function.
4799         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4800         * target-delegates.c: Regenerate.
4801
4802         * linux-thread-db.c (class thread_db_target): Add method
4803         thread_info_to_thread_handle.
4804         (thread_db_target::thread_info_to_thread_handle): Define.
4805         * remote.c (class remote_target): Add new method
4806         thread_info_to_thread_handle.
4807         (remote_target::thread_info_to_thread_handle): Define.
4808
4809 2019-04-08  Pedro Alves  <palves@redhat.com>
4810
4811         * common/common-exceptions.c (throw_exception): Don't create
4812         named object to throw; throw directly.
4813         (throw_it): Likewise.  Don't initialize gdb_exception::message
4814         here, with new; pass FMT and AP to the ctor instead.
4815         * common/common-exceptions.h: Include <string>.
4816         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4817         const char *, va_list)): New ctor.  Use std::make_shared.
4818         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4819         errors)): Delete.
4820         (gdb_exception_error::gdb_exception_error(enum errors, const char
4821         *, va_list)): New.
4822         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4823         Add assertion.
4824         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4825         errors)): Delete.
4826         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4827         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4828         Add assertion.
4829
4830 2019-04-08  Tom Tromey  <tom@tromey.com>
4831
4832         * valops.c (value_rtti_indirect_type): Replace throw_exception
4833         with throw.
4834         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4835         with throw.
4836         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4837         throw.
4838         * target.c (target_translate_tls_address): Replace throw_exception
4839         with throw.
4840         * stack.c (frame_apply_command_count): Replace throw_exception
4841         with throw.
4842         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4843         throw.
4844         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4845         with throw.
4846         * rs6000-tdep.c (rs6000_frame_cache)
4847         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4848         * remote.c: Replace throw_exception with throw.
4849         * record-full.c (record_full_message, record_full_wait_1)
4850         (record_full_restore): Replace throw_exception with throw.
4851         * record-btrace.c:
4852         (get_thread_current_frame_id, record_btrace_start_replaying)
4853         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4854         (cmd_record_btrace_start): Replace throw_exception with throw.
4855         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4856         throw.
4857         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4858         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4859         * linespec.c:
4860         (find_linespec_symbols): Replace throw_exception with throw.
4861         * infrun.c (displaced_step_prepare, resume): Replace
4862         throw_exception with throw.
4863         * infcmd.c (post_create_inferior): Replace throw_exception with
4864         throw.
4865         * inf-loop.c (inferior_event_handler): Replace throw_exception
4866         with throw.
4867         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4868         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4869         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4870         (get_prev_frame_always, get_frame_pc_if_available)
4871         (get_frame_address_in_block_if_available, get_frame_language):
4872         Replace throw_exception with throw.
4873         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4874         throw_exception with throw.
4875         * eval.c (fetch_subexp_value, evaluate_var_value)
4876         (evaluate_funcall, evaluate_subexp_standard): Replace
4877         throw_exception with throw.
4878         * dwarf2loc.c (call_site_find_chain)
4879         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4880         Replace throw_exception with throw.
4881         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4882         with throw.
4883         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4884         throw.
4885         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4886         * completer.c (complete_line_internal): Replace throw_exception
4887         with throw.
4888         * compile/compile-object-run.c (compile_object_run): Replace
4889         throw_exception with throw.
4890         * cli/cli-script.c (process_next_line): Replace throw_exception
4891         with throw.
4892         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4893         (btrace_enable, btrace_maint_update_pt_packets): Replace
4894         throw_exception with throw.
4895         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4896         throw_exception with throw.
4897         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4898         throw_exception with throw.
4899         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4900         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4901         * aarch64-tdep.c (aarch64_make_prologue_cache)
4902         (aarch64_make_stub_cache): Replace throw_exception with throw.
4903
4904 2019-04-08  Tom Tromey  <tom@tromey.com>
4905
4906         * common/common-exceptions.c (throw_exception): Rename from
4907         throw_exception_cxx.  Remove old copy.  Make argument const.
4908         (throw_it): Create and throw exception objects directly.
4909         * common/common-exceptions.h (throw_exception): Make argument
4910         const.
4911         (struct gdb_exception_error): Add constructor.
4912         (struct gdb_exception_quit): Add constructor.
4913
4914 2019-04-08  Tom Tromey  <tom@tromey.com>
4915
4916         * common/common-exceptions.h (exception_rethrow): Don't declare.
4917         (TRY_SJLJ): Update comment.
4918         (TRY, CATCH, END_CATCH): Remove.
4919         * common/common-exceptions.c (exception_rethrow): Remove.
4920
4921 2019-04-08  Tom Tromey  <tom@tromey.com>
4922
4923         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4924         Remove.
4925         (gdb_exception_error): Rename from
4926         gdb_exception_RETURN_MASK_ERROR.
4927         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4928         (gdb_quit_bad_alloc): Update.
4929         * aarch64-tdep.c: Update.
4930         * ada-lang.c: Update.
4931         * ada-typeprint.c: Update.
4932         * ada-valprint.c: Update.
4933         * amd64-tdep.c: Update.
4934         * arch-utils.c: Update.
4935         * break-catch-throw.c: Update.
4936         * breakpoint.c: Update.
4937         * btrace.c: Update.
4938         * c-varobj.c: Update.
4939         * cli/cli-cmds.c: Update.
4940         * cli/cli-interp.c: Update.
4941         * cli/cli-script.c: Update.
4942         * common/common-exceptions.c: Update.
4943         * common/new-op.c: Update.
4944         * common/selftest.c: Update.
4945         * compile/compile-c-symbols.c: Update.
4946         * compile/compile-cplus-symbols.c: Update.
4947         * compile/compile-object-load.c: Update.
4948         * compile/compile-object-run.c: Update.
4949         * completer.c: Update.
4950         * corelow.c: Update.
4951         * cp-abi.c: Update.
4952         * cp-support.c: Update.
4953         * cp-valprint.c: Update.
4954         * darwin-nat.c: Update.
4955         * disasm-selftests.c: Update.
4956         * dtrace-probe.c: Update.
4957         * dwarf-index-cache.c: Update.
4958         * dwarf-index-write.c: Update.
4959         * dwarf2-frame-tailcall.c: Update.
4960         * dwarf2-frame.c: Update.
4961         * dwarf2loc.c: Update.
4962         * dwarf2read.c: Update.
4963         * eval.c: Update.
4964         * event-loop.c: Update.
4965         * event-top.c: Update.
4966         * exec.c: Update.
4967         * f-valprint.c: Update.
4968         * fbsd-tdep.c: Update.
4969         * frame-unwind.c: Update.
4970         * frame.c: Update.
4971         * gdbtypes.c: Update.
4972         * gnu-v3-abi.c: Update.
4973         * guile/guile-internal.h: Update.
4974         * guile/scm-block.c: Update.
4975         * guile/scm-breakpoint.c: Update.
4976         * guile/scm-cmd.c: Update.
4977         * guile/scm-disasm.c: Update.
4978         * guile/scm-frame.c: Update.
4979         * guile/scm-lazy-string.c: Update.
4980         * guile/scm-math.c: Update.
4981         * guile/scm-param.c: Update.
4982         * guile/scm-ports.c: Update.
4983         * guile/scm-pretty-print.c: Update.
4984         * guile/scm-symbol.c: Update.
4985         * guile/scm-symtab.c: Update.
4986         * guile/scm-type.c: Update.
4987         * guile/scm-value.c: Update.
4988         * i386-linux-tdep.c: Update.
4989         * i386-tdep.c: Update.
4990         * inf-loop.c: Update.
4991         * infcall.c: Update.
4992         * infcmd.c: Update.
4993         * infrun.c: Update.
4994         * jit.c: Update.
4995         * language.c: Update.
4996         * linespec.c: Update.
4997         * linux-fork.c: Update.
4998         * linux-nat.c: Update.
4999         * linux-tdep.c: Update.
5000         * linux-thread-db.c: Update.
5001         * main.c: Update.
5002         * mi/mi-cmd-break.c: Update.
5003         * mi/mi-cmd-stack.c: Update.
5004         * mi/mi-interp.c: Update.
5005         * mi/mi-main.c: Update.
5006         * objc-lang.c: Update.
5007         * p-valprint.c: Update.
5008         * parse.c: Update.
5009         * ppc-linux-tdep.c: Update.
5010         * printcmd.c: Update.
5011         * python/py-arch.c: Update.
5012         * python/py-breakpoint.c: Update.
5013         * python/py-cmd.c: Update.
5014         * python/py-finishbreakpoint.c: Update.
5015         * python/py-frame.c: Update.
5016         * python/py-framefilter.c: Update.
5017         * python/py-gdb-readline.c: Update.
5018         * python/py-inferior.c: Update.
5019         * python/py-infthread.c: Update.
5020         * python/py-lazy-string.c: Update.
5021         * python/py-linetable.c: Update.
5022         * python/py-objfile.c: Update.
5023         * python/py-param.c: Update.
5024         * python/py-prettyprint.c: Update.
5025         * python/py-progspace.c: Update.
5026         * python/py-record-btrace.c: Update.
5027         * python/py-record.c: Update.
5028         * python/py-symbol.c: Update.
5029         * python/py-type.c: Update.
5030         * python/py-unwind.c: Update.
5031         * python/py-utils.c: Update.
5032         * python/py-value.c: Update.
5033         * python/python.c: Update.
5034         * record-btrace.c: Update.
5035         * record-full.c: Update.
5036         * remote-fileio.c: Update.
5037         * remote.c: Update.
5038         * riscv-tdep.c: Update.
5039         * rs6000-aix-tdep.c: Update.
5040         * rs6000-tdep.c: Update.
5041         * rust-exp.y: Update.
5042         * rust-lang.c: Update.
5043         * s390-tdep.c: Update.
5044         * selftest-arch.c: Update.
5045         * solib-dsbt.c: Update.
5046         * solib-frv.c: Update.
5047         * solib-spu.c: Update.
5048         * solib-svr4.c: Update.
5049         * solib.c: Update.
5050         * sparc64-linux-tdep.c: Update.
5051         * stack.c: Update.
5052         * symfile-mem.c: Update.
5053         * symmisc.c: Update.
5054         * target.c: Update.
5055         * thread.c: Update.
5056         * top.c: Update.
5057         * tracefile-tfile.c: Update.
5058         * tui/tui.c: Update.
5059         * typeprint.c: Update.
5060         * unittests/cli-utils-selftests.c: Update.
5061         * unittests/parse-connection-spec-selftests.c: Update.
5062         * valops.c: Update.
5063         * valprint.c: Update.
5064         * value.c: Update.
5065         * varobj.c: Update.
5066         * windows-nat.c: Update.
5067         * x86-linux-nat.c: Update.
5068         * xml-support.c: Update.
5069
5070 2019-04-08  Tom Tromey  <tom@tromey.com>
5071
5072         * xml-support.c: Use C++ exception handling.
5073         * x86-linux-nat.c: Use C++ exception handling.
5074         * windows-nat.c: Use C++ exception handling.
5075         * varobj.c: Use C++ exception handling.
5076         * value.c: Use C++ exception handling.
5077         * valprint.c: Use C++ exception handling.
5078         * valops.c: Use C++ exception handling.
5079         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5080         handling.
5081         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5082         * typeprint.c: Use C++ exception handling.
5083         * tui/tui.c: Use C++ exception handling.
5084         * tracefile-tfile.c: Use C++ exception handling.
5085         * top.c: Use C++ exception handling.
5086         * thread.c: Use C++ exception handling.
5087         * target.c: Use C++ exception handling.
5088         * symmisc.c: Use C++ exception handling.
5089         * symfile-mem.c: Use C++ exception handling.
5090         * stack.c: Use C++ exception handling.
5091         * sparc64-linux-tdep.c: Use C++ exception handling.
5092         * solib.c: Use C++ exception handling.
5093         * solib-svr4.c: Use C++ exception handling.
5094         * solib-spu.c: Use C++ exception handling.
5095         * solib-frv.c: Use C++ exception handling.
5096         * solib-dsbt.c: Use C++ exception handling.
5097         * selftest-arch.c: Use C++ exception handling.
5098         * s390-tdep.c: Use C++ exception handling.
5099         * rust-lang.c: Use C++ exception handling.
5100         * rust-exp.y: Use C++ exception handling.
5101         * rs6000-tdep.c: Use C++ exception handling.
5102         * rs6000-aix-tdep.c: Use C++ exception handling.
5103         * riscv-tdep.c: Use C++ exception handling.
5104         * remote.c: Use C++ exception handling.
5105         * remote-fileio.c: Use C++ exception handling.
5106         * record-full.c: Use C++ exception handling.
5107         * record-btrace.c: Use C++ exception handling.
5108         * python/python.c: Use C++ exception handling.
5109         * python/py-value.c: Use C++ exception handling.
5110         * python/py-utils.c: Use C++ exception handling.
5111         * python/py-unwind.c: Use C++ exception handling.
5112         * python/py-type.c: Use C++ exception handling.
5113         * python/py-symbol.c: Use C++ exception handling.
5114         * python/py-record.c: Use C++ exception handling.
5115         * python/py-record-btrace.c: Use C++ exception handling.
5116         * python/py-progspace.c: Use C++ exception handling.
5117         * python/py-prettyprint.c: Use C++ exception handling.
5118         * python/py-param.c: Use C++ exception handling.
5119         * python/py-objfile.c: Use C++ exception handling.
5120         * python/py-linetable.c: Use C++ exception handling.
5121         * python/py-lazy-string.c: Use C++ exception handling.
5122         * python/py-infthread.c: Use C++ exception handling.
5123         * python/py-inferior.c: Use C++ exception handling.
5124         * python/py-gdb-readline.c: Use C++ exception handling.
5125         * python/py-framefilter.c: Use C++ exception handling.
5126         * python/py-frame.c: Use C++ exception handling.
5127         * python/py-finishbreakpoint.c: Use C++ exception handling.
5128         * python/py-cmd.c: Use C++ exception handling.
5129         * python/py-breakpoint.c: Use C++ exception handling.
5130         * python/py-arch.c: Use C++ exception handling.
5131         * printcmd.c: Use C++ exception handling.
5132         * ppc-linux-tdep.c: Use C++ exception handling.
5133         * parse.c: Use C++ exception handling.
5134         * p-valprint.c: Use C++ exception handling.
5135         * objc-lang.c: Use C++ exception handling.
5136         * mi/mi-main.c: Use C++ exception handling.
5137         * mi/mi-interp.c: Use C++ exception handling.
5138         * mi/mi-cmd-stack.c: Use C++ exception handling.
5139         * mi/mi-cmd-break.c: Use C++ exception handling.
5140         * main.c: Use C++ exception handling.
5141         * linux-thread-db.c: Use C++ exception handling.
5142         * linux-tdep.c: Use C++ exception handling.
5143         * linux-nat.c: Use C++ exception handling.
5144         * linux-fork.c: Use C++ exception handling.
5145         * linespec.c: Use C++ exception handling.
5146         * language.c: Use C++ exception handling.
5147         * jit.c: Use C++ exception handling.
5148         * infrun.c: Use C++ exception handling.
5149         * infcmd.c: Use C++ exception handling.
5150         * infcall.c: Use C++ exception handling.
5151         * inf-loop.c: Use C++ exception handling.
5152         * i386-tdep.c: Use C++ exception handling.
5153         * i386-linux-tdep.c: Use C++ exception handling.
5154         * guile/scm-value.c: Use C++ exception handling.
5155         * guile/scm-type.c: Use C++ exception handling.
5156         * guile/scm-symtab.c: Use C++ exception handling.
5157         * guile/scm-symbol.c: Use C++ exception handling.
5158         * guile/scm-pretty-print.c: Use C++ exception handling.
5159         * guile/scm-ports.c: Use C++ exception handling.
5160         * guile/scm-param.c: Use C++ exception handling.
5161         * guile/scm-math.c: Use C++ exception handling.
5162         * guile/scm-lazy-string.c: Use C++ exception handling.
5163         * guile/scm-frame.c: Use C++ exception handling.
5164         * guile/scm-disasm.c: Use C++ exception handling.
5165         * guile/scm-cmd.c: Use C++ exception handling.
5166         * guile/scm-breakpoint.c: Use C++ exception handling.
5167         * guile/scm-block.c: Use C++ exception handling.
5168         * guile/guile-internal.h: Use C++ exception handling.
5169         * gnu-v3-abi.c: Use C++ exception handling.
5170         * gdbtypes.c: Use C++ exception handling.
5171         * frame.c: Use C++ exception handling.
5172         * frame-unwind.c: Use C++ exception handling.
5173         * fbsd-tdep.c: Use C++ exception handling.
5174         * f-valprint.c: Use C++ exception handling.
5175         * exec.c: Use C++ exception handling.
5176         * event-top.c: Use C++ exception handling.
5177         * event-loop.c: Use C++ exception handling.
5178         * eval.c: Use C++ exception handling.
5179         * dwarf2read.c: Use C++ exception handling.
5180         * dwarf2loc.c: Use C++ exception handling.
5181         * dwarf2-frame.c: Use C++ exception handling.
5182         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5183         * dwarf-index-write.c: Use C++ exception handling.
5184         * dwarf-index-cache.c: Use C++ exception handling.
5185         * dtrace-probe.c: Use C++ exception handling.
5186         * disasm-selftests.c: Use C++ exception handling.
5187         * darwin-nat.c: Use C++ exception handling.
5188         * cp-valprint.c: Use C++ exception handling.
5189         * cp-support.c: Use C++ exception handling.
5190         * cp-abi.c: Use C++ exception handling.
5191         * corelow.c: Use C++ exception handling.
5192         * completer.c: Use C++ exception handling.
5193         * compile/compile-object-run.c: Use C++ exception handling.
5194         * compile/compile-object-load.c: Use C++ exception handling.
5195         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5196         * compile/compile-c-symbols.c: Use C++ exception handling.
5197         * common/selftest.c: Use C++ exception handling.
5198         * common/new-op.c: Use C++ exception handling.
5199         * cli/cli-script.c: Use C++ exception handling.
5200         * cli/cli-interp.c: Use C++ exception handling.
5201         * cli/cli-cmds.c: Use C++ exception handling.
5202         * c-varobj.c: Use C++ exception handling.
5203         * btrace.c: Use C++ exception handling.
5204         * breakpoint.c: Use C++ exception handling.
5205         * break-catch-throw.c: Use C++ exception handling.
5206         * arch-utils.c: Use C++ exception handling.
5207         * amd64-tdep.c: Use C++ exception handling.
5208         * ada-valprint.c: Use C++ exception handling.
5209         * ada-typeprint.c: Use C++ exception handling.
5210         * ada-lang.c: Use C++ exception handling.
5211         * aarch64-tdep.c: Use C++ exception handling.
5212
5213 2019-04-08  Tom Tromey  <tom@tromey.com>
5214
5215         * xml-support.c (gdb_xml_parser::parse): Update.
5216         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5217         * value.c (show_convenience): Update.
5218         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5219         (test_parse_flags_qcs): Update.
5220         * thread.c (thr_try_catch_cmd): Update.
5221         * target.c (target_translate_tls_address): Update.
5222         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5223         (info_frame_command_core, frame_apply_command_count): Update.
5224         * rust-exp.y (rust_lex_exception_test): Update.
5225         * riscv-tdep.c (riscv_print_one_register_info): Update.
5226         * remote.c (remote_target::enable_btrace): Update.
5227         * record-btrace.c (record_btrace_enable_warn): Update.
5228         * python/py-utils.c (gdbpy_convert_exception): Update.
5229         * printcmd.c (do_one_display, print_variable_and_value): Update.
5230         * mi/mi-main.c (mi_print_exception): Update.
5231         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5232         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5233         * linux-nat.c (linux_nat_target::attach): Update.
5234         * linux-fork.c (class scoped_switch_fork_info): Update.
5235         * infrun.c (displaced_step_prepare): Update.
5236         * infcall.c (call_function_by_hand_dummy): Update.
5237         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5238         * gnu-v3-abi.c (print_one_vtable): Update.
5239         * frame.c (get_prev_frame_always): Update.
5240         * f-valprint.c (info_common_command_for_block): Update.
5241         * exec.c (try_open_exec_file): Update.
5242         * exceptions.c (print_exception, exception_print)
5243         (exception_fprintf, exception_print_same): Update.
5244         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5245         * dwarf-index-cache.c (index_cache::store)
5246         (index_cache::lookup_gdb_index): Update.
5247         * darwin-nat.c (maybe_cache_shell): Update.
5248         * cp-valprint.c (cp_print_value_fields): Update.
5249         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5250         (gcc_cplus_symbol_address): Update.
5251         * compile/compile-c-symbols.c (gcc_convert_symbol)
5252         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5253         * common/selftest.c: Update.
5254         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5255         a std::string.
5256         (exception_try_scope_entry, exception_try_scope_exit): Don't
5257         declare.
5258         (struct exception_try_scope): Remove.
5259         (TRY): Don't use exception_try_scope.
5260         (struct gdb_exception): Add constructor, operator=.
5261         <what>: New method.
5262         (struct gdb_exception_RETURN_MASK_ALL)
5263         (struct gdb_exception_RETURN_MASK_ERROR)
5264         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5265         (struct gdb_quit_bad_alloc): Update.
5266         * common/common-exceptions.c (exception_none): Change
5267         initializer.
5268         (struct catcher) <state, exception>: Initialize inline.
5269         <prev>: Remove member.
5270         (current_catcher): Remove.
5271         (catchers): New global.
5272         (exceptions_state_mc_init): Simplify.
5273         (catcher_pop): Remove.
5274         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5275         (try_scope_depth, exception_try_scope_entry)
5276         (exception_try_scope_exit): Remove.
5277         (throw_exception_sjlj): Update.
5278         (exception_messages, exception_messages_size): Remove.
5279         (throw_it): Simplify.
5280         (gdb_exception_sliced_copy): Remove.
5281         (throw_exception_cxx): Update.
5282         * cli/cli-script.c (script_from_file): Update.
5283         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5284         Update.
5285         * ada-valprint.c (ada_val_print): Update.
5286         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5287         (create_excep_cond_exprs): Update.
5288
5289 2019-04-08  Tom Tromey  <tom@tromey.com>
5290
5291         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5292         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5293         (TRY, CATCH, END_CATCH): Remove some definitions.
5294         * common/common-exceptions.c: Don't use GDB_XCPT.
5295         (catcher_list_size): Remove.
5296         (throw_exception, throw_it): Simplify.
5297
5298 2019-04-05  Tom Tromey  <tom@tromey.com>
5299
5300         Revert the header-sorting patch.
5301         * ft32-tdep.c: Revert.
5302         * frv-tdep.c: Revert.
5303         * frv-linux-tdep.c: Revert.
5304         * frame.c: Revert.
5305         * frame-unwind.c: Revert.
5306         * frame-base.c: Revert.
5307         * fork-child.c: Revert.
5308         * findvar.c: Revert.
5309         * findcmd.c: Revert.
5310         * filesystem.c: Revert.
5311         * filename-seen-cache.h: Revert.
5312         * filename-seen-cache.c: Revert.
5313         * fbsd-tdep.c: Revert.
5314         * fbsd-nat.h: Revert.
5315         * fbsd-nat.c: Revert.
5316         * f-valprint.c: Revert.
5317         * f-typeprint.c: Revert.
5318         * f-lang.c: Revert.
5319         * extension.h: Revert.
5320         * extension.c: Revert.
5321         * extension-priv.h: Revert.
5322         * expprint.c: Revert.
5323         * exec.h: Revert.
5324         * exec.c: Revert.
5325         * exceptions.c: Revert.
5326         * event-top.c: Revert.
5327         * event-loop.c: Revert.
5328         * eval.c: Revert.
5329         * elfread.c: Revert.
5330         * dwarf2read.h: Revert.
5331         * dwarf2read.c: Revert.
5332         * dwarf2loc.c: Revert.
5333         * dwarf2expr.h: Revert.
5334         * dwarf2expr.c: Revert.
5335         * dwarf2-frame.c: Revert.
5336         * dwarf2-frame-tailcall.c: Revert.
5337         * dwarf-index-write.h: Revert.
5338         * dwarf-index-write.c: Revert.
5339         * dwarf-index-common.c: Revert.
5340         * dwarf-index-cache.h: Revert.
5341         * dwarf-index-cache.c: Revert.
5342         * dummy-frame.c: Revert.
5343         * dtrace-probe.c: Revert.
5344         * disasm.h: Revert.
5345         * disasm.c: Revert.
5346         * disasm-selftests.c: Revert.
5347         * dictionary.c: Revert.
5348         * dicos-tdep.c: Revert.
5349         * demangle.c: Revert.
5350         * dcache.h: Revert.
5351         * dcache.c: Revert.
5352         * darwin-nat.h: Revert.
5353         * darwin-nat.c: Revert.
5354         * darwin-nat-info.c: Revert.
5355         * d-valprint.c: Revert.
5356         * d-namespace.c: Revert.
5357         * d-lang.c: Revert.
5358         * ctf.c: Revert.
5359         * csky-tdep.c: Revert.
5360         * csky-linux-tdep.c: Revert.
5361         * cris-tdep.c: Revert.
5362         * cris-linux-tdep.c: Revert.
5363         * cp-valprint.c: Revert.
5364         * cp-support.c: Revert.
5365         * cp-namespace.c: Revert.
5366         * cp-abi.c: Revert.
5367         * corelow.c: Revert.
5368         * corefile.c: Revert.
5369         * continuations.c: Revert.
5370         * completer.h: Revert.
5371         * completer.c: Revert.
5372         * complaints.c: Revert.
5373         * coffread.c: Revert.
5374         * coff-pe-read.c: Revert.
5375         * cli-out.h: Revert.
5376         * cli-out.c: Revert.
5377         * charset.c: Revert.
5378         * c-varobj.c: Revert.
5379         * c-valprint.c: Revert.
5380         * c-typeprint.c: Revert.
5381         * c-lang.c: Revert.
5382         * buildsym.c: Revert.
5383         * buildsym-legacy.c: Revert.
5384         * build-id.h: Revert.
5385         * build-id.c: Revert.
5386         * btrace.c: Revert.
5387         * bsd-uthread.c: Revert.
5388         * breakpoint.h: Revert.
5389         * breakpoint.c: Revert.
5390         * break-catch-throw.c: Revert.
5391         * break-catch-syscall.c: Revert.
5392         * break-catch-sig.c: Revert.
5393         * blockframe.c: Revert.
5394         * block.c: Revert.
5395         * bfin-tdep.c: Revert.
5396         * bfin-linux-tdep.c: Revert.
5397         * bfd-target.c: Revert.
5398         * bcache.c: Revert.
5399         * ax-general.c: Revert.
5400         * ax-gdb.h: Revert.
5401         * ax-gdb.c: Revert.
5402         * avr-tdep.c: Revert.
5403         * auxv.c: Revert.
5404         * auto-load.c: Revert.
5405         * arm-wince-tdep.c: Revert.
5406         * arm-tdep.c: Revert.
5407         * arm-symbian-tdep.c: Revert.
5408         * arm-pikeos-tdep.c: Revert.
5409         * arm-obsd-tdep.c: Revert.
5410         * arm-nbsd-tdep.c: Revert.
5411         * arm-nbsd-nat.c: Revert.
5412         * arm-linux-tdep.c: Revert.
5413         * arm-linux-nat.c: Revert.
5414         * arm-fbsd-tdep.c: Revert.
5415         * arm-fbsd-nat.c: Revert.
5416         * arm-bsd-tdep.c: Revert.
5417         * arch-utils.c: Revert.
5418         * arc-tdep.c: Revert.
5419         * arc-newlib-tdep.c: Revert.
5420         * annotate.h: Revert.
5421         * annotate.c: Revert.
5422         * amd64-windows-tdep.c: Revert.
5423         * amd64-windows-nat.c: Revert.
5424         * amd64-tdep.c: Revert.
5425         * amd64-sol2-tdep.c: Revert.
5426         * amd64-obsd-tdep.c: Revert.
5427         * amd64-obsd-nat.c: Revert.
5428         * amd64-nbsd-tdep.c: Revert.
5429         * amd64-nbsd-nat.c: Revert.
5430         * amd64-nat.c: Revert.
5431         * amd64-linux-tdep.c: Revert.
5432         * amd64-linux-nat.c: Revert.
5433         * amd64-fbsd-tdep.c: Revert.
5434         * amd64-fbsd-nat.c: Revert.
5435         * amd64-dicos-tdep.c: Revert.
5436         * amd64-darwin-tdep.c: Revert.
5437         * amd64-bsd-nat.c: Revert.
5438         * alpha-tdep.c: Revert.
5439         * alpha-obsd-tdep.c: Revert.
5440         * alpha-nbsd-tdep.c: Revert.
5441         * alpha-mdebug-tdep.c: Revert.
5442         * alpha-linux-tdep.c: Revert.
5443         * alpha-linux-nat.c: Revert.
5444         * alpha-bsd-tdep.c: Revert.
5445         * alpha-bsd-nat.c: Revert.
5446         * aix-thread.c: Revert.
5447         * agent.c: Revert.
5448         * addrmap.c: Revert.
5449         * ada-varobj.c: Revert.
5450         * ada-valprint.c: Revert.
5451         * ada-typeprint.c: Revert.
5452         * ada-tasks.c: Revert.
5453         * ada-lang.c: Revert.
5454         * aarch64-tdep.c: Revert.
5455         * aarch64-ravenscar-thread.c: Revert.
5456         * aarch64-newlib-tdep.c: Revert.
5457         * aarch64-linux-tdep.c: Revert.
5458         * aarch64-linux-nat.c: Revert.
5459         * aarch64-fbsd-tdep.c: Revert.
5460         * aarch64-fbsd-nat.c: Revert.
5461         * aarch32-linux-nat.c: Revert.
5462
5463 2019-04-05  Tom Tromey  <tom@tromey.com>
5464
5465         * ft32-tdep.c: Sort headers.
5466         * frv-tdep.c: Sort headers.
5467         * frv-linux-tdep.c: Sort headers.
5468         * frame.c: Sort headers.
5469         * frame-unwind.c: Sort headers.
5470         * frame-base.c: Sort headers.
5471         * fork-child.c: Sort headers.
5472         * findvar.c: Sort headers.
5473         * findcmd.c: Sort headers.
5474         * filesystem.c: Sort headers.
5475         * filename-seen-cache.h: Sort headers.
5476         * filename-seen-cache.c: Sort headers.
5477         * fbsd-tdep.c: Sort headers.
5478         * fbsd-nat.h: Sort headers.
5479         * fbsd-nat.c: Sort headers.
5480         * f-valprint.c: Sort headers.
5481         * f-typeprint.c: Sort headers.
5482         * f-lang.c: Sort headers.
5483         * extension.h: Sort headers.
5484         * extension.c: Sort headers.
5485         * extension-priv.h: Sort headers.
5486         * expprint.c: Sort headers.
5487         * exec.h: Sort headers.
5488         * exec.c: Sort headers.
5489         * exceptions.c: Sort headers.
5490         * event-top.c: Sort headers.
5491         * event-loop.c: Sort headers.
5492         * eval.c: Sort headers.
5493         * elfread.c: Sort headers.
5494         * dwarf2read.h: Sort headers.
5495         * dwarf2read.c: Sort headers.
5496         * dwarf2loc.c: Sort headers.
5497         * dwarf2expr.h: Sort headers.
5498         * dwarf2expr.c: Sort headers.
5499         * dwarf2-frame.c: Sort headers.
5500         * dwarf2-frame-tailcall.c: Sort headers.
5501         * dwarf-index-write.h: Sort headers.
5502         * dwarf-index-write.c: Sort headers.
5503         * dwarf-index-common.c: Sort headers.
5504         * dwarf-index-cache.h: Sort headers.
5505         * dwarf-index-cache.c: Sort headers.
5506         * dummy-frame.c: Sort headers.
5507         * dtrace-probe.c: Sort headers.
5508         * disasm.h: Sort headers.
5509         * disasm.c: Sort headers.
5510         * disasm-selftests.c: Sort headers.
5511         * dictionary.c: Sort headers.
5512         * dicos-tdep.c: Sort headers.
5513         * demangle.c: Sort headers.
5514         * dcache.h: Sort headers.
5515         * dcache.c: Sort headers.
5516         * darwin-nat.h: Sort headers.
5517         * darwin-nat.c: Sort headers.
5518         * darwin-nat-info.c: Sort headers.
5519         * d-valprint.c: Sort headers.
5520         * d-namespace.c: Sort headers.
5521         * d-lang.c: Sort headers.
5522         * ctf.c: Sort headers.
5523         * csky-tdep.c: Sort headers.
5524         * csky-linux-tdep.c: Sort headers.
5525         * cris-tdep.c: Sort headers.
5526         * cris-linux-tdep.c: Sort headers.
5527         * cp-valprint.c: Sort headers.
5528         * cp-support.c: Sort headers.
5529         * cp-namespace.c: Sort headers.
5530         * cp-abi.c: Sort headers.
5531         * corelow.c: Sort headers.
5532         * corefile.c: Sort headers.
5533         * continuations.c: Sort headers.
5534         * completer.h: Sort headers.
5535         * completer.c: Sort headers.
5536         * complaints.c: Sort headers.
5537         * coffread.c: Sort headers.
5538         * coff-pe-read.c: Sort headers.
5539         * cli-out.h: Sort headers.
5540         * cli-out.c: Sort headers.
5541         * charset.c: Sort headers.
5542         * c-varobj.c: Sort headers.
5543         * c-valprint.c: Sort headers.
5544         * c-typeprint.c: Sort headers.
5545         * c-lang.c: Sort headers.
5546         * buildsym.c: Sort headers.
5547         * buildsym-legacy.c: Sort headers.
5548         * build-id.h: Sort headers.
5549         * build-id.c: Sort headers.
5550         * btrace.c: Sort headers.
5551         * bsd-uthread.c: Sort headers.
5552         * breakpoint.h: Sort headers.
5553         * breakpoint.c: Sort headers.
5554         * break-catch-throw.c: Sort headers.
5555         * break-catch-syscall.c: Sort headers.
5556         * break-catch-sig.c: Sort headers.
5557         * blockframe.c: Sort headers.
5558         * block.c: Sort headers.
5559         * bfin-tdep.c: Sort headers.
5560         * bfin-linux-tdep.c: Sort headers.
5561         * bfd-target.c: Sort headers.
5562         * bcache.c: Sort headers.
5563         * ax-general.c: Sort headers.
5564         * ax-gdb.h: Sort headers.
5565         * ax-gdb.c: Sort headers.
5566         * avr-tdep.c: Sort headers.
5567         * auxv.c: Sort headers.
5568         * auto-load.c: Sort headers.
5569         * arm-wince-tdep.c: Sort headers.
5570         * arm-tdep.c: Sort headers.
5571         * arm-symbian-tdep.c: Sort headers.
5572         * arm-pikeos-tdep.c: Sort headers.
5573         * arm-obsd-tdep.c: Sort headers.
5574         * arm-nbsd-tdep.c: Sort headers.
5575         * arm-nbsd-nat.c: Sort headers.
5576         * arm-linux-tdep.c: Sort headers.
5577         * arm-linux-nat.c: Sort headers.
5578         * arm-fbsd-tdep.c: Sort headers.
5579         * arm-fbsd-nat.c: Sort headers.
5580         * arm-bsd-tdep.c: Sort headers.
5581         * arch-utils.c: Sort headers.
5582         * arc-tdep.c: Sort headers.
5583         * arc-newlib-tdep.c: Sort headers.
5584         * annotate.h: Sort headers.
5585         * annotate.c: Sort headers.
5586         * amd64-windows-tdep.c: Sort headers.
5587         * amd64-windows-nat.c: Sort headers.
5588         * amd64-tdep.c: Sort headers.
5589         * amd64-sol2-tdep.c: Sort headers.
5590         * amd64-obsd-tdep.c: Sort headers.
5591         * amd64-obsd-nat.c: Sort headers.
5592         * amd64-nbsd-tdep.c: Sort headers.
5593         * amd64-nbsd-nat.c: Sort headers.
5594         * amd64-nat.c: Sort headers.
5595         * amd64-linux-tdep.c: Sort headers.
5596         * amd64-linux-nat.c: Sort headers.
5597         * amd64-fbsd-tdep.c: Sort headers.
5598         * amd64-fbsd-nat.c: Sort headers.
5599         * amd64-dicos-tdep.c: Sort headers.
5600         * amd64-darwin-tdep.c: Sort headers.
5601         * amd64-bsd-nat.c: Sort headers.
5602         * alpha-tdep.c: Sort headers.
5603         * alpha-obsd-tdep.c: Sort headers.
5604         * alpha-nbsd-tdep.c: Sort headers.
5605         * alpha-mdebug-tdep.c: Sort headers.
5606         * alpha-linux-tdep.c: Sort headers.
5607         * alpha-linux-nat.c: Sort headers.
5608         * alpha-bsd-tdep.c: Sort headers.
5609         * alpha-bsd-nat.c: Sort headers.
5610         * aix-thread.c: Sort headers.
5611         * agent.c: Sort headers.
5612         * addrmap.c: Sort headers.
5613         * ada-varobj.c: Sort headers.
5614         * ada-valprint.c: Sort headers.
5615         * ada-typeprint.c: Sort headers.
5616         * ada-tasks.c: Sort headers.
5617         * ada-lang.c: Sort headers.
5618         * aarch64-tdep.c: Sort headers.
5619         * aarch64-ravenscar-thread.c: Sort headers.
5620         * aarch64-newlib-tdep.c: Sort headers.
5621         * aarch64-linux-tdep.c: Sort headers.
5622         * aarch64-linux-nat.c: Sort headers.
5623         * aarch64-fbsd-tdep.c: Sort headers.
5624         * aarch64-fbsd-nat.c: Sort headers.
5625         * aarch32-linux-nat.c: Sort headers.
5626
5627 2019-04-04  Tom Tromey  <tom@tromey.com>
5628
5629         * varobj.c (varobj_create): Update.
5630         * rust-exp.y (struct rust_parser) <update_innermost_block,
5631         lookup_symbol>: New methods.
5632         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5633         Rename.
5634         (rust_parser::rust_lookup_type)
5635         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5636         * printcmd.c (display_command, do_one_display): Update.
5637         * parser-defs.h (struct parser_state) <parser_state>: Add
5638         "tracker" parameter.
5639         (block_tracker): New member.
5640         (class innermost_block_tracker) <innermost_block_tracker>: Add
5641         "types" parameter.
5642         <reset>: Remove method.
5643         (innermost_block): Don't declare.
5644         (null_post_parser): Update.
5645         * parse.c (innermost_block): Remove global.
5646         (write_dollar_variable): Update.
5647         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5648         Remove "tracker_types" parameter.
5649         (parse_expression): Add "tracker" parameter.
5650         (parse_expression_for_completion): Update.
5651         (null_post_parser): Add "tracker" parameter.
5652         * p-exp.y: Update rules.
5653         * m2-exp.y: Update rules.
5654         * language.h (struct language_defn) <la_post_parser>: Add
5655         "tracker" parameter.
5656         * go-exp.y: Update rules.
5657         * f-exp.y: Update rules.
5658         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5659         parameter.
5660         * d-exp.y: Update rules.
5661         * c-exp.y: Update rules.
5662         * breakpoint.c (set_breakpoint_condition): Create an
5663         innermost_block_tracker.
5664         (watch_command_1): Likewise.
5665         * ada-lang.c (resolve): Add "tracker" parameter.
5666         (resolve_subexp): Likewise.
5667         * ada-exp.y (write_var_from_sym): Update.
5668
5669 2019-04-04  Tom Tromey  <tom@tromey.com>
5670
5671         * type-stack.h: New file.
5672         * type-stack.c: New file.
5673         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5674         type-stack.h.
5675         (insert_into_type_stack, insert_type, push_type, push_type_int)
5676         (insert_type_address_space, pop_type, pop_type_int)
5677         (pop_typelist, pop_type_stack, append_type_stack)
5678         (push_type_stack, get_type_stack, push_typelist)
5679         (follow_type_instance_flags, follow_types): Don't declare.
5680         * parse.c (type_stack): Remove global.
5681         (parse_exp_in_context): Update.
5682         (insert_into_type_stack, insert_type, push_type, push_type_int)
5683         (insert_type_address_space, pop_type, pop_type_int)
5684         (pop_typelist, pop_type_stack, append_type_stack)
5685         (push_type_stack, get_type_stack, push_typelist)
5686         (follow_type_instance_flags, follow_types): Remove (moved to
5687         type-stack.c).
5688         * f-exp.y (type_stack): New global.
5689         Update rules.
5690         (push_kind_type, f_parse): Update.
5691         * d-exp.y (type_stack): New global.
5692         Update rules.
5693         (d_parse): Update.
5694         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5695         Update rules.
5696         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5697         (HFILES_NO_SRCDIR): Add type-stack.h.
5698
5699 2019-04-04  Tom Tromey  <tom@tromey.com>
5700
5701         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5702         (rust_parser::convert_ast_to_expression, rust_parse)
5703         (rust_lex_test_completion, rust_lex_tests): Update.
5704         * parser-defs.h (struct expr_completion_state): New.
5705         (struct parser_state) <parser_state>: Add completion parameter.
5706         <mark_struct_expression, mark_completion_tag>: New methods.
5707         <parse_completion, m_completion_state>: New members.
5708         (prefixify_expression, null_post_parser): Update.
5709         (mark_struct_expression, mark_completion_tag): Don't declare.
5710         * parse.c (parse_completion, expout_last_struct)
5711         (expout_tag_completion_type, expout_completion_name): Remove
5712         globals.
5713         (parser_state::mark_struct_expression)
5714         (parser_state::mark_completion_tag): Now methods.
5715         (prefixify_expression): Add last_struct parameter.
5716         (prefixify_subexp): Likewise.
5717         (parse_exp_1): Update.
5718         (parse_exp_in_context): Add cstate parameter.  Update.
5719         (parse_expression_for_completion): Create an
5720         expr_completion_state.
5721         (null_post_parser): Add "completion" parameter.
5722         * p-exp.y: Update rules.
5723         (yylex): Update.
5724         * language.h (struct language_defn) <la_post_parser>: Add
5725         "completing" parameter.
5726         * go-exp.y: Update rules.
5727         (lex_one_token): Update.
5728         * expression.h (parse_completion): Don't declare.
5729         * d-exp.y: Update rules.
5730         (lex_one_token): Update rules.
5731         * c-exp.y: Update rules.
5732         (lex_one_token): Update.
5733         * ada-lang.c (resolve): Add "parse_completion" parameter.
5734         (resolve_subexp): Likewise.
5735         (ada_resolve_function): Likewise.
5736
5737 2019-04-04  Tom Tromey  <tom@tromey.com>
5738
5739         * parser-defs.h (struct parser_state) <start_arglist,
5740         end_arglist>: New methods.
5741         <arglist_len, m_funcall_chain>: New members.
5742         (arglist_len, start_arglist, end_arglist): Don't declare.
5743         * parse.c (arglist_len, funcall_chain): Remove global.
5744         (start_arglist, end_arglist): Remove functions.
5745         (parse_exp_in_context): Update.
5746         * p-exp.y: Update rules.
5747         * m2-exp.y: Update rules.
5748         * go-exp.y: Update rules.
5749         * f-exp.y: Update rules.
5750         * d-exp.y: Update rules.
5751         * c-exp.y: Update rules.
5752
5753 2019-04-04  Tom Tromey  <tom@tromey.com>
5754
5755         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5756         lex_operator, push_back>: New methods.
5757         Update all rules.
5758         (rust_parser::lex_hex, lex_escape): Rename and update.
5759         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5760         (rust_parser::lex_operator): Rename and update.
5761         (rust_parser::lex_number, rustyylex, rustyyerror)
5762         (rust_lex_test_init, rust_lex_test_sequence)
5763         (rust_lex_test_push_back, rust_lex_tests): Update.
5764         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5765         parameter.
5766         <lexptr, prev_lexptr>: New members.
5767         (lexptr, prev_lexptr): Don't declare.
5768         * parse.c (lexptr, prev_lexptr): Remove globals.
5769         (parse_exp_in_context): Update.
5770         * p-exp.y (yylex, yyerror): Update.
5771         * m2-exp.y (parse_number, yylex, yyerror): Update.
5772         * go-exp.y (lex_one_token, yyerror): Update.
5773         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5774         * d-exp.y (lex_one_token, yyerror): Update.
5775         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5776         (lex_one_token, yyerror): Update.
5777         * ada-lex.l (YY_INPUT): Update.
5778         (rewind_to_char): Update.
5779         * ada-exp.y (yyerror): Update.
5780
5781 2019-04-04  Tom Tromey  <tom@tromey.com>
5782
5783         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5784         * parser-defs.h (struct parser_state) <parser_state>: Add new
5785         parameter.
5786         <comma_terminates>: New member.
5787         (comma_terminates): Don't declare global.
5788         * parse.c (comma_terminates): Remove global.
5789         (parse_exp_in_context): Update.
5790         * p-exp.y (yylex): Update.
5791         * m2-exp.y (yylex): Update.
5792         * go-exp.y (lex_one_token): Update.
5793         * f-exp.y (yylex): Update.
5794         * d-exp.y (lex_one_token): Update.
5795         * c-exp.y (lex_one_token): Update.
5796         * ada-lex.l: Update.
5797
5798 2019-04-04  Tom Tromey  <tom@tromey.com>
5799
5800         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5801         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5802         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5803         * parser-defs.h (paren_depth): Don't declare.
5804         * parse.c (paren_depth): Remove global.
5805         (parse_exp_in_context): Update.
5806         * p-exp.y (paren_depth): New global.
5807         (pascal_parse): Initialize it.
5808         * m2-exp.y (paren_depth): New global.
5809         (m2_parse): Initialize it.
5810         * go-exp.y (paren_depth): New global.
5811         (go_parse): Initialize it.
5812         * f-exp.y (paren_depth): New global.
5813         (f_parse): Initialize it.
5814         * d-exp.y (paren_depth): New global.
5815         (d_parse): Initialize it.
5816         * c-exp.y (paren_depth): New global.
5817         (c_parse): Initialize it.
5818         * ada-lex.l (paren_depth): New global.
5819         (lexer_init): Initialize it.
5820
5821 2019-04-04  Tom Tromey  <tom@tromey.com>
5822
5823         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5824         (rust_parser::convert_ast_to_type)
5825         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5826         * parser-defs.h (struct parser_state) <parser_state>: Add
5827         parameters.  Initialize new members.
5828         <expression_context_block, expression_context_pc>: New members.
5829         * parse.c (expression_context_block, expression_context_pc):
5830         Remove globals.
5831         (parse_exp_in_context): Update.
5832         * p-exp.y: Update all rules.
5833         (yylex): Update.
5834         * m2-exp.y: Update all rules.
5835         (yylex): Update.
5836         * go-exp.y (yylex): Update.
5837         * f-exp.y (yylex): Update.
5838         * d-exp.y: Update all rules.
5839         (yylex): Update.
5840         * c-exp.y: Update all rules.
5841         (lex_one_token, classify_name, yylex, c_parse): Update.
5842         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5843
5844 2019-04-04  Tom Tromey  <tom@tromey.com>
5845
5846         * gdbarch.h, gdbarch.c: Rebuild.
5847         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5848         * stap-probe.h:
5849         (struct stap_parse_info): Replace "parser_state" with
5850         "expr_builder".
5851         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5852         (parser_state): New class.
5853         * parse.c (expr_builder): Rename.
5854         (expr_builder::release): Rename.
5855         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5856         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5857         (write_exp_elt_longcst, write_exp_elt_floatcst)
5858         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5859         (write_exp_string_vector, write_exp_bitstring)
5860         (write_exp_msymbol, mark_struct_expression)
5861         (write_dollar_variable)
5862         (insert_type_address_space, increase_expout_size): Replace
5863         "parser_state" with "expr_builder".
5864         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5865         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5866         "parser_state" with "expr_builder".
5867
5868 2019-04-04  Tom Tromey  <tom@tromey.com>
5869
5870         * rust-exp.y: Replace "parse_language" with method call.
5871         * p-exp.y:
5872         (yylex): Replace "parse_language" with method call.
5873         * m2-exp.y:
5874         (yylex): Replace "parse_language" with method call.
5875         * go-exp.y (classify_name): Replace "parse_language" with method
5876         call.
5877         * f-exp.y (yylex): Replace "parse_language" with method call.
5878         * d-exp.y (lex_one_token): Replace "parse_language" with method
5879         call.
5880         * c-exp.y:
5881         (lex_one_token, classify_name, yylex): Replace "parse_language"
5882         with method call.
5883         * ada-exp.y (find_primitive_type, type_char)
5884         (type_system_address): Replace "parse_language" with method call.
5885
5886 2019-04-04  Tom Tromey  <tom@tromey.com>
5887
5888         * rust-exp.y: Replace "parse_gdbarch" with method call.
5889         * parse.c (write_dollar_variable, insert_type_address_space):
5890         Replace "parse_gdbarch" with method call.
5891         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5892         call.
5893         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5894         call.
5895         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5896         "parse_gdbarch" with method call.
5897         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5898         with method call.
5899         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5900         "parse_gdbarch" with method call.
5901         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5902         "parse_gdbarch" with method call.
5903         * c-exp.y (parse_type, parse_number, classify_name): Replace
5904         "parse_gdbarch" with method call.
5905         * ada-lex.l: Replace "parse_gdbarch" with method call.
5906         * ada-exp.y (parse_type, find_primitive_type, type_char)
5907         (type_system_address): Replace "parse_gdbarch" with method call.
5908
5909 2019-04-04  Tom Tromey  <tom@tromey.com>
5910
5911         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5912         * stap-probe.c (stap_parse_argument): Update.
5913         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5914         initial_size parameter.
5915         * rust-exp.y (rust_lex_tests): Update.
5916         * parse.c (parser_state): Update.
5917         (parse_exp_in_context): Update.
5918         * parser-defs.h (struct parser_state) <parser_state>: Remove
5919         "initial_size" parameter.
5920
5921 2019-04-04  Tom Tromey  <tom@tromey.com>
5922
5923         * parser-defs.h (increase_expout_size): Don't declare.
5924         * parse.c (increase_expout_size): Now static.
5925
5926 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5927
5928         * gnu-nat.c (gnu_nat_target::wait): Fix
5929         target_waitstatus_to_string call.
5930
5931 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5932
5933         * eval.c (evaluate_subexp_standard): Handle internal functions
5934         during Fortran function call handling.
5935
5936 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5937
5938         * NEWS: Mention new internal functions.
5939         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5940         (read_base_type): Use dwarf2_init_complex_target_type.
5941         * value.c (creal_internal_fn): New function.
5942         (cimag_internal_fn): New function.
5943         (_initialize_values): Register new internal functions.
5944
5945 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5946
5947         * infrun.c (stop_all_threads): If debug_infrun, always
5948         trace the wait status after wait_one, using
5949         target_waitstatus_to_string and target_pid_to_str.
5950         (handle_inferior_event): Replace various trace of
5951         wait status kind by a single trace.
5952         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5953         wait status kind image by target_waitstatus_to_string.
5954         * target/waitstatus.c (target_waitstatus_to_string): Fix
5955         obsolete comment.
5956
5957 2019-04-01  Tom Tromey  <tromey@adacore.com>
5958
5959         PR symtab/23331:
5960         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5961
5962 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5963             Pedro Alves  <palves@redhat.com>
5964
5965         * top.c (quit_force): Call 'finalize_values'.
5966         * value.c (finalize_values): New function.
5967         * value.h (finalize_values): Declare.
5968
5969 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5970
5971         * NEWS: Announce $_gdb_major and $_gdb_minor.
5972
5973         * top.c (init_gdb_version_vars): New function.
5974         (gdb_init): Call init_gdb_version_vars.
5975
5976 2019-03-29  Tom Tromey  <tromey@adacore.com>
5977
5978         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5979         help text.  Remove dead code.
5980
5981 2019-03-29  Keith Seitz  <keiths@redhat.com>
5982
5983         From Siddhesh Poyarekar:
5984         * f-lang.h (f77_get_upperbound): Return LONGEST.
5985         (f77_get_lowerbound): Likewise.
5986         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5987         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5988         print them.
5989         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5990         plongest to format print it.
5991         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5992         (f77_get_upperbound): Likewise.
5993         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5994         LOWER_BOUND to LONGEST.
5995         (f77_create_arrayprint_offset_tbl): Likewise.
5996
5997 2019-03-29  Keith Seitz  <keiths@redhat.com>
5998
5999         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6000         %s/pulongest for TYPE_LENGTH instead of %d in format
6001         strings.
6002         * ada-typerint.c (ada_print_type): Likewise.
6003         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6004         * compile/compile-c-support.c (generate_register_struct): Likewise.
6005         * gdbtypes.c (recursive_dump_type): Likewise.
6006         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6007         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6008         instead of %d in format strings.
6009         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6010         to std::min to ULONGEST.
6011         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6012         instead of %d in format strings.
6013         * tracepoint.c (info_scope_command): Likewise.
6014         * typeprint.c (print_offset_data::update)
6015         (print_offset_data::finish): Likewise.
6016         * xtensa-tdep.c (xtensa_store_return_value)
6017         (xtensa_push_dummy_call): Likewise.
6018
6019 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6020
6021         * windows-nat.c (display_selector): Fixed format specifications
6022         for 64-bit Cygwin.
6023
6024 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6025
6026         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6027
6028 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6029
6030         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6031         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6032         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6033         (nios2_linux_init_abi): Install it.
6034
6035 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6036
6037         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6038
6039 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6040
6041         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6042
6043 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6044             Tom Tromey  <tromey@adacore.com>
6045
6046         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6047
6048 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6049
6050         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6051         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6052         method to compute the bounds of range types. Also print "[evaluated]"
6053         if the bounds' values come from a dynamic evaluation.
6054
6055 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6056
6057         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6058         whitespace when pretty printing is on.
6059
6060 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6061
6062         * ppc-linux-nat.c: Add include.
6063
6064 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6065
6066         * NEWS: Mention AArch64 Pointer Authentication.
6067
6068 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6069
6070         * arm-linux-nat.c: Add include.
6071
6072 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6073
6074         * source-cache.c (source_cache::get_source_lines): Re-read
6075         fullname after calling open_source_file.
6076
6077 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6078
6079         * NEWS: Mention TLS support for FreeBSD.
6080
6081 2019-03-25  Tom Tromey  <tromey@adacore.com>
6082
6083         * minsyms.c (BUNCH_SIZE): Update comment.
6084         (~minimal_symbol_reader): Remove old comment.
6085         (compact_minimal_symbols): Update comment.
6086         (minimal_symbol_reader::install): Remove old comment.  Update
6087         other comments.
6088
6089 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6090
6091         * s390-linux-nat.c: Add include.
6092
6093 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6094
6095         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6096         Call linux_get_hwcap.
6097         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6098         Likewise.
6099         (aarch64_linux_get_hwcap): Remove function.
6100         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6101         declaration.
6102         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6103         linux_get_hwcap.
6104         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6105         * linux-tdep.c (linux_get_hwcap): Add function.
6106         (linux_get_hwcap2): Likewise.
6107         * linux-tdep.h (linux_get_hwcap): Add declaration.
6108         (linux_get_hwcap2): Likewise.
6109         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6110         (ppc_linux_get_hwcap2): Likewise.
6111         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6112         linux_get_hwcap.
6113         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6114         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6115         (ppc_linux_nat_target::read_description): Likewise.
6116         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6117         * s390-linux-nat.c: Likewise.
6118         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6119
6120 2019-03-24  Tom Tromey  <tom@tromey.com>
6121
6122         * ada-lang.c (standard_lookup): Simplify initialization.
6123         (ada_lookup_symbol_nonlocal): Simplify return.
6124         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6125         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6126         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6127         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6128         initialization.
6129         * solib.c (solib_global_lookup): Simplify.
6130         * symtab.c (null_block_symbol): Remove.
6131         (symbol_cache_lookup): Simplify returns.
6132         (lookup_language_this): Simplify returns.
6133         (lookup_symbol_aux): Simplify return.
6134         (lookup_local_symbol): Simplify returns.
6135         (lookup_global_symbol_from_objfile): Simplify return.
6136         (lookup_symbol_in_objfile_symtabs)
6137         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6138         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6139         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6140         * cp-namespace.c (cp_lookup_bare_symbol)
6141         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6142         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6143         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6144         (cp_lookup_symbol_via_imports): Simplify initialization.
6145         (find_symbol_in_baseclass): Likewise.
6146         * symtab.h (null_block_symbol): Remove.
6147         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6148         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6149         (d_lookup_symbol_module): Likewise.
6150         (find_symbol_in_baseclass): Simplify initialization.
6151
6152 2019-03-24  Tom Tromey  <tom@tromey.com>
6153
6154         * expression.h: Don't include symtab.h.
6155         (struct block): Forward declare.
6156
6157 2019-03-24  Tom Tromey  <tom@tromey.com>
6158
6159         * c-exp.y (typebase): Remove casts.
6160         * gdbtypes.c (lookup_unsigned_typename, )
6161         (lookup_signed_typename): Remove cast.
6162         * eval.c (parse_to_comma_and_eval): Remove cast.
6163         * parse.c (write_dollar_variable): Remove cast.
6164         * block.h (struct block) <superblock>: Now const.
6165         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6166         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6167         (map_block): Make "block" const.
6168         * symfile.h (struct quick_symbol_functions)
6169         <map_matching_symbols>: Constify block argument to "callback".
6170         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6171         const.
6172         (find_pc_sect_compunit_symtab): Make "b" const.
6173         (find_symbol_at_address): Likewise.
6174         (search_symbols): Likewise.
6175         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6176         (dw2_debug_names_lookup_symbol): Likewise.
6177         (dw2_map_matching_symbols): Update.
6178         * p-valprint.c (pascal_val_print): Remove "block".
6179         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6180         (aux_add_nonlocal_symbols): Make "block" const.
6181         (resolve_subexp): Remove cast.
6182         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6183         const.
6184         (iterate_over_file_blocks): Likewise.
6185         * f-exp.y (%union) <bval>: Remove.
6186         * coffread.c (patch_opaque_types): Make "b" const.
6187         * spu-tdep.c (spu_catch_start): Make "block" const.
6188         * c-valprint.c (print_unpacked_pointer): Remove "block".
6189         * symmisc.c (dump_symtab_1): Make "b" const.
6190         (block_depth): Make "block" const.
6191         * d-exp.y (%union) <bval>: Remove.
6192         * cp-support.h (cp_lookup_rtti_type): Update.
6193         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6194         * psymtab.c (psym_lookup_symbol): Make "block" const.
6195         (maintenance_check_psymtabs): Make "b" const.
6196         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6197         (enumerate_locals, enumerate_args): Update.
6198         * python/py-symtab.c (stpy_global_block): Make "block" const.
6199         (stpy_static_block): Likewise.
6200         * inline-frame.c (block_starting_point_at): Make "new_block"
6201         const.
6202         * block.c (find_block_in_blockvector): Make return type const.
6203         (blockvector_for_pc_sect): Make "b" const.
6204         (find_block_in_blockvector): Make "b" const.
6205
6206 2019-03-23  Tom Tromey  <tom@tromey.com>
6207
6208         * varobj.c (varobj_create): Update.
6209         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6210         * printcmd.c (display_command, do_one_display): Don't reset
6211         innermost_block.
6212         * parser-defs.h (enum innermost_block_tracker_type): Move to
6213         expression.h.
6214         (innermost_block): Update comment.
6215         * parse.c (parse_exp_1): Add tracker_types parameter.
6216         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6217         tracker_types parameter.  Reset innermost_block.
6218         (parse_exp_in_context): Remove.
6219         (parse_expression_for_completion): Update.
6220         * objfiles.c (~objfile): Don't reset expression_context_block or
6221         innermost_block.
6222         * expression.h (enum innermost_block_tracker_type): Move from
6223         parser-defs.h.
6224         (parse_exp_1): Add tracker_types parameter.
6225         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6226         reset innermost_block.
6227
6228 2019-03-23  Tom Tromey  <tom@tromey.com>
6229
6230         * objfiles.h: Include bcache.h.
6231
6232 2019-03-23  Tom Tromey  <tom@tromey.com>
6233
6234         * linespec.c (get_current_search_block): Use
6235         scoped_restore_current_language.
6236         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6237
6238 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6239             Jiong Wang  <jiong.wang@arm.com>
6240
6241         * aarch64-linux-tdep.c
6242         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6243         section.
6244         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6245
6246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6247             Jiong Wang  <jiong.wang@arm.com>
6248
6249         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6250         instructions.
6251         (aarch64_analyze_prologue_test): Add PACIASP test.
6252         (aarch64_prologue_prev_register): Unmask PC value.
6253
6254 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6255             Jiong Wang  <jiong.wang@arm.com>
6256
6257         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6258         (aarch64_dwarf2_prev_register): Unmask PC value.
6259         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6260         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6261         DW_CFA_AARCH64_negate_ra_state.
6262         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6263
6264 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6265             Jiong Wang  <jiong.wang@arm.com>
6266
6267         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6268         registers.
6269         (aarch64_pseudo_register_name): Likewise.
6270         (aarch64_pseudo_register_type): Likewise.
6271         (aarch64_pseudo_register_reggroup_p): Likewise.
6272         (aarch64_gdbarch_init): Add pauth registers.
6273         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6274         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6275         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6276         (struct gdbarch_tdep): Add regnum for ra_state.
6277
6278 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6279             Jiong Wang  <jiong.wang@arm.com>
6280
6281         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6282
6283 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6284             Jiong Wang  <jiong.wang@arm.com>
6285
6286         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6287         function.
6288         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6289         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6290         (aarch64_gdbarch_init): Add puth registers.
6291         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6292         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6293         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6294
6295 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6296             Jiong Wang  <jiong.wang@arm.com>
6297
6298         * aarch64-linux-nat.c
6299         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6300         * aarch64-linux-tdep.c
6301         (aarch64_linux_core_read_description): Likewise.
6302         (aarch64_linux_get_hwcap): New function.
6303         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6304         (aarch64_linux_get_hwcap): New declaration.
6305
6306 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6307             Jiong Wang  <jiong.wang@arm.com>
6308
6309         * aarch64-linux-nat.c
6310         (aarch64_linux_nat_target::read_description): Add pauth param.
6311         * aarch64-linux-tdep.c
6312         (aarch64_linux_core_read_description): Likewise.
6313         * aarch64-tdep.c (struct target_desc): Add in pauth.
6314         (aarch64_read_description): Add pauth param.
6315         (aarch64_gdbarch_init): Likewise.
6316         * aarch64-tdep.h (aarch64_read_description): Likewise.
6317         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6318         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6319         * features/Makefile: Add new files.
6320         * features/aarch64-pauth.c: New file.
6321         * features/aarch64-pauth.xml: New file.
6322
6323 2019-03-20  Tom Tromey  <tromey@adacore.com>
6324
6325         * infrun.c (handle_inferior_event): Rename from
6326         handle_inferior_event_1.  Create a scoped_value_mark.
6327         (handle_inferior_event): Remove.
6328
6329 2019-03-19  Tom Tromey  <tromey@adacore.com>
6330
6331         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6332         * infrun.h (print_stop_event): Add "displays" parameter.
6333         * infrun.c (print_stop_event): Add "displays" parameter.
6334
6335 2019-03-19  Pedro Alves  <palves@redhat.com>
6336
6337         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6338         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6339         to -1.  Fix TABs vs spaces.
6340         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6341         * tui/tui-out.h (tui_ui_out) Add intro comments.
6342         <m_line, m_start_of_line>: In-class initialize, and add describing
6343         comment.
6344
6345 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6346
6347         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6348         variable names.
6349         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6350
6351 2019-03-18  Pedro Alves  <palves@redhat.com>
6352             Eli Zaretskii <eliz@gnu.org>
6353
6354         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6355         m_line and m_start_of_line.
6356
6357 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6358
6359         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6360         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6361         it returns a newline.  This fixes a regression in TU mode, whereby
6362         the next line is output on the same screen line as the user input.
6363
6364 2019-03-18  Tom Tromey  <tromey@adacore.com>
6365
6366         * minsyms.c (minimal_symbol_reader::install): Remove call to
6367         obstack_blank.
6368
6369 2019-03-18  Pedro Alves  <palves@redhat.com>
6370
6371         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6372         New globals.
6373         (apply_style): New, factored out from ...
6374         (apply_ansi_escape): ... this.  Handle reverse video mode.
6375         (tui_set_reverse_mode): New function.
6376         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6377         * tui/tui-winsource.c (tui_show_source_line): Use
6378         tui_set_reverse_mode instead of setting A_STANDOUT.
6379         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6380         New setter methods.
6381
6382 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6383
6384         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6385         Handle tabs.
6386
6387 2019-03-18  Tom Tromey  <tromey@adacore.com>
6388
6389         * ada-lang.c (empty_array): Add "high" parameter.
6390         (ada_evaluate_subexp): Update.
6391
6392 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6393
6394         * unittests/string_view-selftests.c: Define
6395         _initialize_string_view_selftests unconditionally.
6396
6397 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6398
6399         PR gdb/24350
6400         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6401
6402 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6403
6404         PR gdb/24351
6405         * windows-nat.c (display_selector): Fix format specifiers.
6406
6407 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6408
6409         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6410         tui_refill_source_window instead of tui_refresh_win, to update the
6411         current execution line.  This fixes redisplay of the current line
6412         when stepping through the code with "next" or "step".
6413
6414 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6415
6416         * source-cache.c (source_cache::get_source_lines): Call
6417         find_source_lines to initialize s->nlines.  This fixes vertical
6418         scrolling of TUI source window when the DOWN arrow is pressed.
6419
6420 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6421
6422         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6423         linux-thread-db.c (_initialize_thread_db): Likewise.
6424
6425 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6426
6427         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6428         wclrtoeol in tui_show_source_line".  This reverts changes made in
6429         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6430
6431 2019-03-15  Tom Tromey  <tom@tromey.com>
6432
6433         * symtab.h (struct minimal_symbol): Derive from
6434         general_symbol_info.
6435         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6436         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6437         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6438         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6439         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6440         (MSYMBOL_SEARCH_NAME): Update.
6441         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6442         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6443         * minsyms.c (minimal_symbol_reader::record_full): Update.
6444
6445 2019-03-15  Tom Tromey  <tom@tromey.com>
6446
6447         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6448
6449 2019-03-15  Tom Tromey  <tom@tromey.com>
6450
6451         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6452         unique_xmalloc_ptr.
6453         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6454         Update.
6455         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6456         (build_minimal_symbol_hash_tables)
6457         (minimal_symbol_reader::install): Update.
6458
6459 2019-03-15  Tom Tromey  <tom@tromey.com>
6460
6461         * symtab.c (create_demangled_names_hash): Update.
6462         (symbol_set_names): Update.
6463         * objfiles.h (struct objfile_per_bfd_storage)
6464         <demangled_names_hash>: Now an htab_up.
6465         * objfiles.c (objfile_per_bfd_storage): Simplify.
6466
6467 2019-03-15  Tom Tromey  <tom@tromey.com>
6468
6469         * objfiles.h (struct objfile_per_bfd_storage): Declare
6470         destructor.
6471         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6472         New.
6473         (get_objfile_bfd_data): Use new.  Don't initialize
6474         language_of_main.
6475         (free_objfile_per_bfd_storage): Remove.
6476         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6477
6478 2019-03-15  Tom Tromey  <tom@tromey.com>
6479
6480         * symfile.c (reread_symbols): Update.
6481         * objfiles.c (objfile::objfile): Update.
6482         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6483         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6484         comment.
6485         (minimal_symbol_reader::install): Update.
6486         (terminate_minimal_symbol_table): Remove.
6487         * jit.c (jit_object_close_impl): Update.
6488
6489 2019-03-15  Tom Tromey  <tom@tromey.com>
6490
6491         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6492         initializations.
6493
6494 2019-03-15  Tom Tromey  <tom@tromey.com>
6495
6496         * objfiles.h (struct objfile_per_bfd_storage)
6497         <demangled_hash_languages>: Now a bitset.
6498         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6499         (lookup_minimal_symbol): Update.
6500
6501 2019-03-15  Tom Tromey  <tom@tromey.com>
6502
6503         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6504         Don't return the symbol.
6505         * coffread.c (record_minimal_symbol): Use record_full.
6506
6507 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6508
6509         The MS-Windows port of ncurses fails to switch to a color pair if
6510         one or both of the colors are the implicit default colors.  This
6511         change records the default colors when TUI is initialized, and
6512         then specifies them explicitly when a color pair uses the default
6513         colors.  This allows color styling in TUI mode on MS-Windows.
6514
6515         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6516         ncurses_norm_attr.
6517         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6518         colors in ncurses_norm_attr.
6519         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6520         "none", replace it with the default color recorded in
6521         ncurses_norm_attr.
6522
6523 2019-03-14  Tom Tromey  <tromey@adacore.com>
6524
6525         * source-cache.h (class source_cache) <get_source_lines>: Return
6526         std::string.
6527         * source-cache.c (source_cache::extract_lines): Handle case where
6528         first_pos==npos.  Return std::string.
6529         (source_cache::get_source_lines): Update.
6530
6531 2019-03-14  Tom Tromey  <tromey@adacore.com>
6532
6533         * NEWS: Add item for "style sources" commands.
6534         * source-cache.c (source_cache::get_source_lines): Check
6535         source_styling.
6536         * cli/cli-style.c (source_styling): New global.
6537         (_initialize_cli_style): Add "style sources" commands.
6538         (show_style_sources): New function.
6539         * cli/cli-style.h (source_styling): Declare.
6540
6541 2019-03-14  Pedro Alves  <palves@redhat.com>
6542             Tom Tromey  <tromey@adacore.com>
6543
6544         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6545         * tui/tui-winsource.c (tui_refill_source_window): New function,
6546         from...
6547         (tui_horizontal_source_scroll): ... here.  Move some logic.
6548         * cli/cli-style.c (set_style_enabled): Notify new observable.
6549         * tui/tui-hooks.c (tui_redisplay_source): New function.
6550         (tui_attach_detach_observers): Attach or detach
6551         tui_redisplay_source.
6552         * observable.h (source_styling_changed): New observable.
6553         * observable.c: Define source_styling_changed observable.
6554
6555 2019-03-13  Tom Tromey  <tromey@adacore.com>
6556
6557         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6558         (i386_gnu_nat_target::store_registers): Update.
6559         * target-debug.h (target_debug_print_std_string): New macro.
6560         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6561         * windows-tdep.c (display_one_tib): Update.
6562         * tui/tui-stack.c (tui_make_status_line): Update.
6563         * top.c (print_inferior_quit_action): Update.
6564         * thread.c (thr_try_catch_cmd): Update.
6565         (add_thread_with_info): Update.
6566         (thread_target_id_str): Update.
6567         (thr_try_catch_cmd): Update.
6568         (thread_command): Update.
6569         (thread_find_command): Update.
6570         * record-btrace.c (record_btrace_target::info_record)
6571         (record_btrace_resume_thread, record_btrace_target::resume)
6572         (record_btrace_cancel_resume, record_btrace_step_thread)
6573         (record_btrace_target::wait, record_btrace_target::wait)
6574         (record_btrace_target::wait, record_btrace_target::stop): Update.
6575         * progspace.c (print_program_space): Update.
6576         * process-stratum-target.c
6577         (process_stratum_target::thread_address_space): Update.
6578         * linux-fork.c (linux_fork_mourn_inferior)
6579         (detach_checkpoint_command, info_checkpoints_command)
6580         (linux_fork_context): Update.
6581         (linux_fork_detach): Update.
6582         (class scoped_switch_fork_info): Update.
6583         (delete_checkpoint_command): Update.
6584         * infrun.c (follow_fork_inferior): Update.
6585         (follow_fork_inferior): Update.
6586         (proceed_after_vfork_done): Update.
6587         (handle_vfork_child_exec_or_exit): Update.
6588         (follow_exec): Update.
6589         (displaced_step_prepare_throw): Update.
6590         (displaced_step_restore): Update.
6591         (start_step_over): Update.
6592         (resume_1): Update.
6593         (clear_proceed_status_thread): Update.
6594         (proceed): Update.
6595         (print_target_wait_results): Update.
6596         (do_target_wait): Update.
6597         (context_switch): Update.
6598         (stop_all_threads): Update.
6599         (restart_threads): Update.
6600         (finish_step_over): Update.
6601         (handle_signal_stop): Update.
6602         (switch_back_to_stepped_thread): Update.
6603         (keep_going_pass_signal): Update.
6604         (print_exited_reason): Update.
6605         (normal_stop): Update.
6606         * inferior.c (inferior_pid_to_str): Change return type.
6607         (print_selected_inferior): Update.
6608         (add_inferior): Update.
6609         (detach_inferior): Update.
6610         * dummy-frame.c (fprint_dummy_frames): Update.
6611         * dcache.c (dcache_info_1): Update.
6612         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6613         (btrace_fetch, btrace_clear): Update.
6614         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6615         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6616         type.
6617         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6618         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6619         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6620         * gdbarch.c, gdbarch.h: Rebuild.
6621         * gdbarch.sh (core_pid_to_str): Change return type.
6622         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6623         return type.
6624         (windows_nat_target::pid_to_str): Change return type.
6625         (windows_delete_thread): Update.
6626         (windows_nat_target::attach): Update.
6627         (windows_nat_target::files_info): Update.
6628         * target-delegates.c: Rebuild.
6629         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6630         return type.
6631         (sol_thread_target::pid_to_str): Change return type.
6632         * remote.c (class remote_target) <pid_to_str>: Change return
6633         type.
6634         (remote_target::pid_to_str): Change return type.
6635         (extended_remote_target::attach, remote_target::remote_stop_ns)
6636         (remote_target::remote_notif_remove_queued_reply)
6637         (remote_target::push_stop_reply, remote_target::disable_btrace):
6638         Update.
6639         (extended_remote_target::attach): Update.
6640         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6641         type.
6642         (gdbsim_target::pid_to_str): Change return type.
6643         * ravenscar-thread.c (struct ravenscar_thread_target)
6644         <pid_to_str>: Change return type.
6645         (ravenscar_thread_target::pid_to_str): Change return type.
6646         * procfs.c (class procfs_target) <pid_to_str>: Change return
6647         type.
6648         (procfs_target::pid_to_str): Change return type.
6649         (procfs_target::attach): Update.
6650         (procfs_target::detach): Update.
6651         (procfs_target::fetch_registers): Update.
6652         (procfs_target::store_registers): Update.
6653         (procfs_target::wait): Update.
6654         (procfs_target::files_info): Update.
6655         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6656         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6657         return type.
6658         (nto_procfs_target::pid_to_str): Change return type.
6659         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6660         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6661         return type.
6662         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6663         (exit_lwp): Update.
6664         (attach_proc_task_lwp_callback, get_detach_signal)
6665         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6666         (linux_nat_target::resume, wait_lwp, stop_callback)
6667         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6668         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6669         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6670         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6671         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6672         type.
6673         (inf_ptrace_target::attach): Update.
6674         (inf_ptrace_target::files_info): Update.
6675         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6676         type.
6677         (go32_nat_target::pid_to_str): Change return type.
6678         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6679         (gnu_nat_target::wait): Update.
6680         (gnu_nat_target::wait): Update.
6681         (gnu_nat_target::resume): Update.
6682         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6683         (fbsd_nat_target::wait): Update.
6684         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6685         type.
6686         (darwin_nat_target::attach): Update.
6687         * corelow.c (class core_target) <pid_to_str>: Change return type.
6688         (core_target::pid_to_str): Change return type.
6689         * target.c (normal_pid_to_str): Change return type.
6690         (default_pid_to_str): Likewise.
6691         (target_pid_to_str): Change return type.
6692         (target_translate_tls_address): Update.
6693         (target_announce_detach): Update.
6694         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6695         return type.
6696         (bsd_uthread_target::pid_to_str): Change return type.
6697         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6698         type.
6699         (bsd_kvm_target::pid_to_str): Change return type.
6700         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6701         return type.
6702         (aix_thread_target::pid_to_str): Change return type.
6703         * target.h (struct target_ops) <pid_to_str>: Change return type.
6704         (target_pid_to_str, normal_pid_to_str): Likewise.
6705         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6706         type.
6707         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6708         type.
6709         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6710         return type.
6711         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6712         type.
6713         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6714         type.
6715         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6716         return type.
6717
6718 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6719
6720         * NEWS: Mention that the new default MI version is 3.  Mention
6721         changes to the output of commands and events that deal with
6722         multi-location breakpoints.
6723         * breakpoint.c: Include "mi/mi-out.h".
6724         (print_one_breakpoint): Change output syntax if using MI version
6725         >= 3.
6726         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6727         New.
6728         (mi_multi_location_breakpoint_output_fixed): New.
6729         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6730         (mi_cmd_fix_multi_location_breakpoint_output): New.
6731         (mi_multi_location_breakpoint_output_fixed): New.
6732         * mi/mi-cmds.c (mi_cmds): Register command
6733         -fix-multi-location-breakpoint-output.
6734         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6735         interpreter "mi".
6736
6737 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6738
6739         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6740         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6741         instantiate mi_ui_out based on interpreter name.
6742         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6743         * mi/mi-main.c (mi_load_progress): Likewise.
6744
6745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6746
6747         * NEWS: Combine separate "New targets" sections for 8.3.
6748
6749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6750
6751         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6752         (ppcfbsd_init_abi): Install gdbarch
6753         "fetch_tls_load_module_address" and "get_thread_local_address"
6754         methods.
6755
6756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6757
6758         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6759         (riscv_fbsd_init_abi): Install gdbarch
6760         "fetch_tls_load_module_address" and "get_thread_local_address"
6761         methods.
6762
6763 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6764
6765         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6766         (i386fbsd_init_abi): Install gdbarch
6767         "fetch_tls_load_module_address" and "get_thread_local_address"
6768         methods.
6769
6770 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6771
6772         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6773         (amd64fbsd_init_abi): Install gdbarch
6774         "fetch_tls_load_module_address" and "get_thread_local_address"
6775         methods.
6776
6777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6778
6779         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6780         (struct fbsd_pspace_data): New type.
6781         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6782         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6783         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6784         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6785         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6786
6787 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6788
6789         * gdbtypes.c (lookup_struct_elt): New function.
6790         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6791         * gdbtypes.h (struct struct_elt): New type.
6792         (lookup_struct_elt): New prototype.
6793
6794 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6795
6796         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6797         remove disabled code block.
6798
6799 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6800
6801         * gdbarch.sh (get_thread_local_address): New method.
6802         * gdbarch.h, gdbarch.c: Regenerate.
6803         * target.c (target_translate_tls_address): Use
6804         gdbarch_get_thread_local_address if present instead of
6805         target::get_thread_local_address.
6806
6807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6808
6809         * target.h (target::get_thread_local_address): Update comment.
6810
6811 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6812
6813         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6814         objfile->separate_debug_objfile_backlink if not NULL.
6815
6816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6817
6818         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6819         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6820         (amd64bsd_store_inferior_registers): Likewise.
6821         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6822         Enable segment base registers.
6823         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6824         PT_GETFSBASE and PT_GETGSBASE.
6825         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6826         PT_SETGSBASE.
6827         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6828         segment base registers.
6829         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6830
6831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6832
6833         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6834         Update calls to i386_target_description to add 'segments'
6835         parameter.
6836         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6837         add segment base registers.
6838         * arch/i386.c (i386_create_target_description): Add 'segments'
6839         parameter to enable segment base registers.
6840         * arch/i386.h (i386_create_target_description): Likewise.
6841         * features/i386/32bit-segments.xml: New file.
6842         * features/i386/32bit-segments.c: Generate.
6843         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6844         call to i386_target_description to add 'segments' parameter.
6845         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6846         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6847         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6848         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6849         if feature is present.
6850         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6851         Add 'segments' parameter to call to i386_target_description.
6852         (i386_target_description): Add 'segments' parameter to enable
6853         segment base registers.
6854         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6855         to call to i386_target_description.
6856         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6857         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6858         Define I386_NUM_REGS.
6859         (i386_target_description): Add 'segments' parameter to enable
6860         segment base registers.
6861
6862 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6863
6864         PR/24325
6865         * source-cache.c: #undef open and close, to avoid unresolved
6866         externals during linking.
6867
6868 2019-03-12  Tom Tromey  <tromey@adacore.com>
6869
6870         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6871         const.  Add initializers.
6872         (_initialize_remote): Don't initialize ptid globals.
6873
6874 2019-03-12  Pedro Alves  <palves@redhat.com>
6875
6876         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6877
6878 2019-03-12  Pedro Alves  <palves@redhat.com>
6879
6880         * cp-name-parser.y (main): Remove unused 'len' variable.
6881
6882 2019-03-12  Tom Tromey  <tromey@adacore.com>
6883
6884         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6885         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6886
6887 2019-03-12  Tom Tromey  <tromey@adacore.com>
6888
6889         * linux-nat.c (iterate_over_lwps): Update.
6890         (stop_callback): Remove parameter.
6891         (stop_wait_callback, detach_callback, resume_set_callback)
6892         (select_singlestep_lwp_callback, set_ignore_sigint)
6893         (status_callback, resumed_callback, resume_clear_callback)
6894         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6895         data parameter.
6896         (linux_nat_target::detach, linux_nat_target::resume)
6897         (linux_stop_and_wait_all_lwps, select_event_lwp)
6898         (linux_nat_filter_event, linux_nat_wait_1)
6899         (linux_nat_target::kill, linux_nat_target::stop)
6900         (linux_nat_target::stop): Update.
6901         (linux_nat_resume_callback): Change type.
6902         (resume_stopped_resumed_lwps, count_events_callback)
6903         (select_event_lwp_callback): Likewise.
6904         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6905         * arm-linux-nat.c (struct update_registers_data): Remove.
6906         (update_registers_callback): Change type.
6907         (arm_linux_insert_hw_breakpoint1): Update.
6908         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6909         parameter.
6910         (x86_linux_dr_set_addr): Update.
6911         (x86_linux_dr_set_control): Update.
6912         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6913         (iterate_over_lwps): Use gdb::function_view.
6914         * nat/aarch64-linux-hw-point.c (struct
6915         aarch64_dr_update_callback_param): Remove.
6916         (debug_reg_change_callback): Change type.
6917         (aarch64_notify_debug_reg_change): Update.
6918         * s390-linux-nat.c (s390_refresh_per_info): Update.
6919
6920 2019-03-11  Tom Tromey  <tromey@adacore.com>
6921
6922         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6923         redundant assignment to "this_cu".
6924
6925 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6926
6927         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6928
6929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6930
6931         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6932         from...
6933         (rank_one_type): ... this.
6934
6935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6936
6937         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6938         from...
6939         (rank_one_type): ... this.
6940
6941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6942
6943         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6944         from...
6945         (rank_one_type): ... this.
6946
6947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6948
6949         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6950         from...
6951         (rank_one_type): ... this.
6952
6953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6954
6955         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6956         from...
6957         (rank_one_type): ... this.
6958
6959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6960
6961         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6962         from...
6963         (rank_one_type): ... this.
6964
6965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6966
6967         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6968         from...
6969         (rank_one_type): ... this.
6970
6971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6972
6973         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6974         from...
6975         (rank_one_type): ... this.
6976
6977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6978
6979         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6980         from...
6981         (rank_one_type): ... this.
6982
6983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6984
6985         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6986         from...
6987         (rank_one_type): ... this.
6988
6989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6990
6991         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6992         from...
6993         (rank_one_type): ... this.
6994
6995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6996
6997         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6998         from...
6999         (rank_one_type): ... this.
7000
7001 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7002
7003         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7004         inferior-events' shows the example events.
7005
7006 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7007
7008         Support styling on native MS-Windows console
7009
7010         PR/24315
7011         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7012         on MS-Windows if $TERM is not defined.
7013
7014         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7015
7016         * posix-hdep.c (gdb_console_fputs):
7017         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7018         functions.
7019         * ui-file.h (gdb_console_fputs): Add prototype.
7020
7021         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7022         back to fputs only if the former returns zero.
7023
7024 2019-03-07  Tom Tromey  <tom@tromey.com>
7025
7026         * symmisc.c (print_symbol_bcache_statistics): Update.
7027         (print_objfile_statistics): Update.
7028         * symfile.c (allocate_symtab): Update.
7029         * stabsread.c: Don't include bcache.h.
7030         * psymtab.h (struct psymbol_bcache): Don't declare.
7031         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7032         (psymbol_bcache_init, psymbol_bcache_free)
7033         (psymbol_bcache_get_bcache): Don't declare.
7034         * psymtab.c (struct psymbol_bcache): Remove.
7035         (psymtab_storage::psymtab_storage): Update.
7036         (psymtab_storage::~psymtab_storage): Update.
7037         (psymbol_bcache_init, psymbol_bcache_free)
7038         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7039         (add_psymbol_to_bcache): Update.
7040         (allocate_psymtab): Update.
7041         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7042         macro_cache>: No longer pointers.
7043         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7044         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7045         * macrotab.c (macro_bcache): Update.
7046         * macroexp.c: Don't include bcache.h.
7047         * gdbtypes.c (check_types_worklist): Update.
7048         (types_deeply_equal): Remove TRY/CATCH.  Update.
7049         * elfread.c (elf_symtab_read): Update.
7050         * dwarf2read.c: Don't include bcache.h.
7051         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7052         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7053         (print_bcache_statistics, bcache_memory_used): Don't declare.
7054         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7055         methods.  Rename all data members.
7056         * bcache.c (struct bcache): Move to bcache.h.
7057         (bcache::expand_hash_table): Rename from expand_hash_table.
7058         (bcache): Remove.
7059         (bcache::insert): Rename from bcache_full.
7060         (bcache::compare): Rename from bcache_compare.
7061         (bcache_xmalloc): Remove.
7062         (bcache::~bcache): Rename from bcache_xfree.
7063         (bcache::print_statistics): Rename from print_bcache_statistics.
7064         (bcache::memory_used): Rename from bcache_memory_used.
7065
7066 2019-03-07  Pedro Alves  <palves@redhat.com>
7067
7068         * infrun.c (normal_stop): Also check for
7069         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7070
7071 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7072
7073         * f-lang.c (value_from_host_double): Moved to...
7074         * value.c (value_from_host_double): ...here.
7075         * value.h (value_from_host_double): Declare.
7076         * guile/scm-math.c (vlscm_convert_typed_number): Use
7077         value_from_host_double.
7078         (vlscm_convert_number): Likewise.
7079         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7080         * python/py-value.c (convert_value_from_python): Likewise.
7081
7082 2019-03-06  Tom Tromey  <tom@tromey.com>
7083
7084         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7085
7086 2019-03-06  Tom Tromey  <tom@tromey.com>
7087
7088         * utils.h (free_current_contents): Don't declare.
7089         * utils.c (free_current_contents): Remove.
7090
7091 2019-03-06  Tom Tromey  <tom@tromey.com>
7092
7093         * top.c (quit_force): Update.
7094         * main.c (captured_command_loop): Update.
7095         * common/new-op.c (operator new): Update.
7096         * common/common-exceptions.c (struct catcher)
7097         <save_cleanup_chain>: Remove member.
7098         (exceptions_state_mc_init): Update.
7099         (exception_try_scope_entry): Return nullptr.
7100         (exception_try_scope_exit, exception_rethrow)
7101         (throw_exception_sjlj, throw_exception_cxx): Update.
7102         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7103         (all_cleanups, do_cleanups, discard_cleanups)
7104         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7105         (restore_cleanups, restore_final_cleanups): Don't declare.
7106         (do_final_cleanups): Remove parameter.
7107         * common/cleanups.c (cleanup_chain, make_cleanup)
7108         (make_cleanup_dtor, all_cleanups, do_cleanups)
7109         (discard_my_cleanups, discard_cleanups)
7110         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7111         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7112         (null_cleanup): Remove.
7113         (do_final_cleanups): Remove parameter.
7114
7115 2019-03-06  Tom Tromey  <tom@tromey.com>
7116
7117         * remote.c (remote_target::remote_parse_stop_reply): Use
7118         unique_xmalloc_ptr.
7119
7120 2019-03-06  Tom Tromey  <tom@tromey.com>
7121
7122         * stabsread.c (struct stabs_field_info): Rename from field_info.
7123         <list, fnlist>: Add initializers.
7124         <obstack>: New member.
7125         (read_member_functions, read_struct_fields, read_baseclasses):
7126         Allocate on obstack.  Don't use cleanups.
7127         (read_one_struct_field, read_member_functions, read_struct_fields)
7128         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7129         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7130         (read_struct_type): Update.
7131
7132 2019-03-06  Tom Tromey  <tom@tromey.com>
7133
7134         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7135         * common/filestuff.h (make_cleanup_close): Don't declare.
7136         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7137         Remove.
7138
7139 2019-03-06  Tom Tromey  <tom@tromey.com>
7140
7141         * solib-aix.c: Use make_scope_exit.
7142
7143 2019-03-06  Tom Tromey  <tom@tromey.com>
7144
7145         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7146         Use make_scope_exit.
7147
7148 2019-03-06  Tom Tromey  <tom@tromey.com>
7149
7150         * solib-svr4.c (disable_probes_interface): Remove parameter.
7151         (svr4_handle_solib_event): Use make_scope_exit.
7152
7153 2019-03-06  Tom Tromey  <tom@tromey.com>
7154
7155         * remote.c (struct stop_reply_deleter): Remove.
7156         (stop_reply_up): Update.
7157         (struct stop_reply): Derive from notif_event.  Don't typedef.
7158         <regcache>: Now a std::vector.
7159         (stop_reply_xfree): Remove.
7160         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7161         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7162         (remote_target::discard_pending_stop_replies): Use delete.
7163         (remote_target::remote_parse_stop_reply): Update.
7164         (remote_target::process_stop_reply): Update.
7165         * remote-notif.h (struct notif_event): Add virtual destructor.
7166         Remove "dtr" member.
7167         (struct notif_client) <alloc_event>: Return a unique_ptr.
7168         (notif_event_xfree): Don't declare.
7169         (notif_event_up): New typedef.
7170         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7171         (notif_event_xfree, do_notif_event_xfree): Remove.
7172         (remote_notif_state_xfree): Update.
7173
7174 2019-03-06  Tom Tromey  <tom@tromey.com>
7175
7176         * infrun.c (displaced_step_clear_cleanup): Now a
7177         forward_scope_exit type.
7178         (displaced_step_prepare_throw): Update.
7179         (displaced_step_fixup): Update.
7180
7181 2019-03-06  Tom Tromey  <tom@tromey.com>
7182
7183         * inferior.h (class inferior): Update comment.
7184         * gdbthread.h (class thread_info): Update comment.
7185
7186 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7187             Tom Tromey  <tom@tromey.com>
7188
7189         * stabsread.h (struct stab_section_list): Remove.
7190         (coffstab_build_psymtabs): Update.
7191         * dbxread.c (symbuf_sections): Now a std::vector.
7192         (sect_idx): New global.
7193         (fill_symbuf): Update.
7194         (coffstab_build_psymtabs): Change type of stabsects parameter.
7195         Update.
7196         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7197         std::vector.
7198         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7199         (coff_locate_sections): Update.
7200         (coff_symfile_read): Remove cleanups.  Update.
7201         (init_stringtab): Add storage parameter.
7202         (free_stringtab, free_stringtab_cleanup): Remove.
7203         (init_lineno): Add storage parameter.
7204         (free_linetab, free_linetab_cleanup): Remove.
7205
7206 2019-03-06  Pedro Alves  <palves@redhat.com>
7207
7208         * linux-fork.c (fork_info::clobber_regs): Delete.
7209         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7210         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7211         comment.  Adjust.
7212         (scoped_switch_fork_info::scoped_switch_fork_info)
7213         (checkpoint_command, linux_fork_context): Adjust
7214         fork_save_infrun_state calls.
7215
7216 2019-03-06  Pedro Alves  <palves@redhat.com>
7217
7218         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7219         (inf_has_multiple_threads): Return 'bool' and rewrite using
7220         inferior_info::threads().
7221
7222 2019-03-06  Pedro Alves  <palves@redhat.com>
7223
7224         * linux-fork.c: Include <list>.
7225         (fork_list): Now a std::list instance.
7226         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7227         (forks_exist_p, find_last_fork): Adjust.
7228         (new_fork): Delete.
7229         (one_fork_p): New.
7230         (add_fork): Adjust.
7231         (free_fork): Delete, folded into fork_info::~fork_info().
7232         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7233         Adjust.
7234         (init_fork_list): Delete.
7235         (linux_fork_killall, linux_fork_mourn_inferior)
7236         (linux_fork_detach, info_checkpoints_command): Adjust.
7237         (_initialize_linux_fork): No longer call init_fork_list.
7238
7239 2019-03-06  Pedro Alves  <palves@redhat.com>
7240
7241         * linux-fork.c (new_fork): New, split out of ...
7242         (add_fork): ... this.  Return void.  Move "first fork" special
7243         case from here, to ...
7244         (checkpoint_command): ... here.
7245         * linux-linux.h (add_fork): Return void.
7246
7247 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7248
7249         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7250
7251 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7252             Chris January  <chris.january@arm.com>
7253             David Lecomber  <david.lecomber@arm.com>
7254
7255         * f-exp.y: New token, UNOP_INTRINSIC.
7256         (exp): New pattern using UNOP_INTRINSIC token.
7257         (f77_keywords): Add 'abs' keyword.
7258         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7259         (value_from_host_double): New function.
7260         (evaluate_subexp_f): Support UNOP_ABS.
7261
7262 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7263
7264         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7265         types.
7266
7267 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7268
7269         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7270         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7271         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7272
7273 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7274
7275         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7276
7277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7278             Chris January  <chris.january@arm.com>
7279
7280         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7281         * f-exp.y: Define 'KIND' token.
7282         (exp): New pattern for KIND expressions.
7283         (ptype): Handle types with a kind extension.
7284         (direct_abs_decl): Extend to spot kind extensions.
7285         (f77_keywords): Add 'kind' to the list.
7286         (push_kind_type): New function.
7287         (convert_to_kind_type): New function.
7288         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7289         * parse.c (operator_length_standard): Likewise.
7290         * parser-defs.h (enum type_pieces): Add tp_kind.
7291         * std-operator.def: Add UNOP_KIND.
7292
7293 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7294
7295         * f-exp.y (f_parse): Set yydebug.
7296
7297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7298
7299         * f-lang.c (evaluate_subexp_f): New function.
7300         (exp_descriptor_f): New global.
7301         (f_language_defn): Use exp_descriptor_f instead of
7302         exp_descriptor_standard.
7303
7304 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7305
7306         * f-exp.y (struct token): Add comments.
7307         (dot_ops): Remove uppercase versions and the end marker.
7308         (f77_keywords): Likewise.
7309         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7310         entries in the dot_ops array are case insensitive, and use
7311         strncasecmp to compare strings.  Also some whitespace cleanup in
7312         this area.  Similar for the f77_keywords array, except entries in
7313         this list might be case sensitive.
7314
7315 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7316
7317         * f-exp.y (struct f77_boolean_val): Add comments.
7318         (boolean_values): Remove uppercase versions, and end marker.
7319         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7320         and use strncasecmp to achieve case insensitivity.  Additionally,
7321         perform whitespace cleanup around this code.
7322
7323 2019-03-06  Tom Tromey  <tromey@adacore.com>
7324
7325         * remote-sim.c (gdbsim_target_open): Use result of
7326         gdb_argv::release.
7327
7328 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7329         Dirk Schubert  <dirk.schubert@arm.com>
7330         Chris January  <chris.january@arm.com>
7331
7332         * eval.c (evaluate_subexp_standard): Call Fortran argument
7333         wrapping logic.
7334         * f-lang.c (struct value): A value which can be passed into a
7335         Fortran function call.
7336         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7337         where appropriate.
7338         (struct type): Value ready for a Fortran function call.
7339         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7340         is needed.
7341         * f-lang.h (fortran_argument_convert): Declaration.
7342         (fortran_preserve_arg_pointer): Declaration.
7343         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7344
7345 2019-03-05  Tom Tromey  <tromey@adacore.com>
7346
7347         * python/py-prettyprint.c (print_string_repr): Remove #if.
7348         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7349
7350 2019-03-05  Tom Tromey  <tromey@adacore.com>
7351
7352         * target.c (the_dummy_target): Move later.  Change type to
7353         "dummy_target".
7354         (initialize_targets): Don't initialize the_dummy_target.
7355
7356 2019-03-05  Tom Tromey  <tromey@adacore.com>
7357
7358         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7359         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7360
7361 2019-03-05  Tom Tromey  <tromey@adacore.com>
7362
7363         * windows-nat.c (windows_nat_target::attach)
7364         (windows_nat_target::detach): Don't call gdb_flush.
7365         * valprint.c (generic_val_print, val_print, val_print_string):
7366         Don't call gdb_flush.
7367         * utils.c (defaulted_query): Don't call gdb_flush.
7368         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7369         * target.c (target_announce_detach): Don't call gdb_flush.
7370         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7371         * remote.c (extended_remote_target::attach): Don't call
7372         gdb_flush.
7373         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7374         * printcmd.c (do_examine): Don't call gdb_flush.
7375         (info_display_command): Don't call gdb_flush.
7376         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7377         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7378         * memattr.c (info_mem_command): Don't call gdb_flush.
7379         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7380         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7381         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7382         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7383         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7384         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7385         (gnu_nat_target::detach): Don't call gdb_flush.
7386         * f-valprint.c (f_val_print): Don't call gdb_flush.
7387         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7388         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7389         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7390         gdb_flush.
7391         * c-valprint.c (c_val_print): Don't call gdb_flush.
7392         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7393
7394 2019-03-05  Tom Tromey  <tromey@adacore.com>
7395
7396         * varobj.c (update_dynamic_varobj_children): Update.
7397         (install_default_visualizer): Use reset, not release.
7398         * value.c (set_internalvar): Update.
7399         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7400         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7401         ATTRIBUTE_UNUSED_RESULT.
7402
7403 2019-03-05  Tom Tromey  <tromey@adacore.com>
7404
7405         * remote.c (class scoped_remote_fd) <release>: Add
7406         ATTRIBUTE_UNUSED_RESULT.
7407
7408 2019-03-05  Tom Tromey  <tromey@adacore.com>
7409
7410         * macroexp.c (struct macro_buffer) <release>: Add
7411         ATTRIBUTE_UNUSED_RESULT.
7412
7413 2019-03-05  Tom Tromey  <tromey@adacore.com>
7414
7415         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7416         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7417         ATTRIBUTE_UNUSED_RESULT.
7418
7419 2019-03-05  Tom Tromey  <tromey@adacore.com>
7420
7421         * common/scoped_fd.h (class scoped_fd) <release>: Add
7422         ATTRIBUTE_UNUSED_RESULT.
7423
7424 2019-03-05  Tom Tromey  <tromey@adacore.com>
7425
7426         * parser-defs.h (struct parser_state) <release>: Add
7427         ATTRIBUTE_UNUSED_RESULT.
7428
7429 2019-03-05  Tom Tromey  <tromey@adacore.com>
7430
7431         * utils.h (class gdb_argv) <release>: Add
7432         ATTRIBUTE_UNUSED_RESULT.
7433         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7434
7435 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7436
7437         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7438         for-loop range, to avoid compiler warnings.
7439
7440         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7441         avoid compiler warnings about unused variables.
7442
7443         * NEWS: Mention end of support for native debugging on MS-Windows
7444         before XP.
7445
7446         PR gdb/24292
7447         * common/netstuff.c:
7448         * gdbserver/gdbreplay.c
7449         * gdbserver/remote-utils.c:
7450         * ser-tcp.c:
7451         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7452         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7453         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7454         'getaddrinfo' and 'freeaddrinfo' were not available before
7455         Windows XP, and mingw.org's MinGW headers by default define
7456         _WIN32_WINNT to 0x500.
7457
7458 2019-03-01  Gary Benson <gbenson@redhat.com>
7459
7460         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7461
7462 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7463             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7464
7465         PR gdb/8527
7466         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7467         set_sigint_trap, clear_sigint_trap.
7468
7469 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7470
7471         * target.c (target_detach): Clear the regcache and the
7472         frame cache.
7473
7474 2019-02-27  Pedro Alves  <palves@redhat.com>
7475
7476         * utils.c (set_screen_size): When we cap the height/width sizes,
7477         tweak the corresponding command variable to show "unlimited":
7478
7479 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7480             Pedro Alves  <palves@redhat.com>
7481
7482         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7483         before calling rl_set_screen_size.
7484
7485 2019-02-27  Tom Tromey  <tromey@adacore.com>
7486
7487         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7488         define.
7489         * python/py-value.c: Remove Python 2.4 workaround.
7490         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7491         workaround.
7492         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7493         Python 2.4 workaround.
7494         * python/python-internal.h: Remove Python 2.4 comment.
7495         (Py_ssize_t): Don't define.
7496         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7497         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7498         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7499         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7500         * python/python.c (do_start_initialization): Remove Python 2.4
7501         workaround.
7502         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7503         (print_children): Remove Python 2.4 workaround.
7504         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7505         workaround.
7506         (CHARBUFFERPROC_NAME): Remove.
7507         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7508         Python 2.4 workaround.
7509
7510 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7511
7512         * NEWS: Note minimum Python version.
7513
7514 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7515
7516         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7517         code from these functions.  Remove corresponding ifdefs.  Use
7518         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7519         Remove gotos and target of gotos.
7520         (infpy_search_memory): Likewise.
7521
7522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7525         (hppa_gdbarch_init): Don't register deleted functions with
7526         gdbarch.
7527
7528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7529
7530         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7531         (h8300_unwind_sp): Delete.
7532         (h8300_dummy_id): Delete.
7533         (h8300_gdbarch_init): Don't register deleted functions with
7534         gdbarch.
7535
7536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7537
7538         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7539         (ft32_unwind_pc): Delete.
7540         (ft32_unwind_sp): Delete.
7541         (ft32_gdbarch_init): Don't register deleted functions with
7542         gdbarch.
7543
7544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7545
7546         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7547         (frv_unwind_pc): Delete.
7548         (frv_unwind_sp): Delete.
7549         (frv_gdbarch_init): Don't register deleted functions with
7550         gdbarch.
7551
7552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7553
7554         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7555         (riscv_unwind_pc): Delete.
7556         (riscv_unwind_sp): Delete.
7557         (riscv_gdbarch_init): Don't register deleted functions with
7558         gdbarch.
7559
7560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7561
7562         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7563         (csky_unwind_pc): Delete.
7564         (csky_unwind_sp): Delete.
7565         (csky_gdbarch_init): Don't register deleted functions with
7566         gdbarch.
7567
7568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7569
7570         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7571         (cris_unwind_pc): Delete.
7572         (cris_unwind_sp): Delete.
7573         (cris_gdbarch_init): Don't register deleted functions with
7574         gdbarch.
7575
7576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7577
7578         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7579         (bfin_unwind_pc): Delete.
7580         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7581
7582 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7583
7584         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7585         (arm_unwind_pc): Delete.
7586         (arm_unwind_sp): Delete.
7587         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7588
7589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7590
7591         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7592         (arc_unwind_pc): Delete.
7593         (arc_unwind_sp): Delete.
7594         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7595
7596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7597
7598         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7599         (alpha_unwind_pc): Delete.
7600         (alpha_gdbarch_init): Don't register deleted functions with
7601         gdbarch.
7602
7603 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7604
7605         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7606         (aarch64_unwind_pc): Delete.
7607         (aarch64_unwind_sp): Delete.
7608         (aarch64_gdbarch_init): Don't register deleted functions with
7609         gdbarch.
7610
7611 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7612
7613         * gdbtypes.c (type_align): Don't consider static members when
7614         computing structure alignment.
7615
7616 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7617
7618         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7619         return 0 for other types.
7620         * arch-utils.c (default_type_align): Always return 0.
7621         * gdbarch.h: Regenerate.
7622         * gdbarch.sh (type_align): Extend comment.
7623         * gdbtypes.c (type_align): Add additional comments, always call
7624         gdbarch_type_align before applying the default rules.
7625         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7626         generic code will then apply a suitable default.
7627         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7628         types, return 0 for other types.
7629
7630 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7631
7632         * NEWS: Create a new section for the next release branch.
7633         Rename the section of the current branch, now that it has
7634         been cut.
7635
7636 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7637
7638         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7639         * version.in: Bump version to 8.3.50.DATE-git.
7640
7641 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7642
7643         * aix-thread.c (ptid_cmp): Remove unused variable.
7644         (get_signaled_thread): Likewise.
7645         (store_regs_user_thread): Likewise.
7646         (store_regs_kernel_thread): Likewise.
7647         (fetch_regs_kernel_thread): Remove shadowed variable.
7648
7649 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7650
7651         * features/riscv/32bit-cpu.xml: Add register numbers.
7652         * features/riscv/32bit-fpu.c: Regenerate.
7653         * features/riscv/32bit-fpu.xml: Add register numbers.
7654         * features/riscv/64bit-cpu.xml: Add register numbers.
7655         * features/riscv/64bit-fpu.c: Regenerate.
7656         * features/riscv/64bit-fpu.xml: Add register numbers.
7657
7658 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7659
7660         * NEWS: Mention two argument form of gdb.Value constructor.
7661         * python/py-value.c (convert_buffer_and_type_to_value): New
7662         function.
7663         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7664         Add support for handling an optional second argument.  Call
7665         convert_buffer_and_type_to_value as appropriate.
7666         * python/python-internal.h (Py_buffer_deleter): New struct.
7667         (Py_buffer_up): New typedef.
7668
7669 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7670
7671         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7672         instead of releasing ownership.
7673
7674 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7675
7676         * dwarf2read.c (open_and_init_dwp_file): Call
7677         elf_numsections instead of bfd_count_sections to initialize
7678         dwp_file->num_sections.
7679
7680 2019-02-25  Tom Tromey  <tromey@adacore.com>
7681
7682         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7683
7684 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7685
7686         * gcore.in: Add '--readnever' option when invoking GDB.
7687
7688 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7689
7690         * MAINTAINERS: Update my email address.
7691
7692 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7693
7694         * build-id.c (build_id_to_debug_bfd_1): New function.
7695         (build_id_to_debug_bfd): Look for separate debug file in
7696         sysroot.
7697
7698 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7699
7700         * gdbarch.sh: Update the copyright year range that is placed into
7701         generated files.
7702
7703 2019-02-22  Keith Seitz  <keiths@redhat.com>
7704
7705         PR symtab/23853
7706         * linespec.c (create_sals_line_offset): Search for the default
7707         symtab's filename instead of its fullname.
7708
7709 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7710
7711         * NEWS: Update style defaults.
7712
7713 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7714
7715         * main.c (captured_main_1): Disable styling in batch mode.
7716
7717 2019-02-20  Tom Tromey  <tom@tromey.com>
7718
7719         * symtab.c (symtab_symbol_info): Fix typos.
7720
7721 2019-02-20  Tom Tromey  <tromey@adacore.com>
7722
7723         * findcmd.c (_initialize_mem_search): Use upper case for
7724         metasyntactic variables.
7725
7726 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7727
7728         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7729         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7730
7731 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7732
7733         * top.h (source_file_name): Change to std::string.
7734         * top.c (source_file_name): Likewise.
7735         (command_line_input): Adjust.
7736         * cli/cli-script.c (script_from_file): Adjust.
7737
7738 2019-02-19  Tom Tromey  <tromey@adacore.com>
7739
7740         * ravenscar-thread.c
7741         (ravenscar_thread_target::update_thread_list): Don't call
7742         ada_build_task_list.
7743         * ada-lang.h (ada_build_task_list): Don't declare.
7744         * ada-tasks.c (struct ada_tasks_inferior_data)
7745         <task_list_valid_p>: Now bool.
7746         (read_known_tasks, ada_task_list_changed)
7747         (ada_tasks_invalidate_inferior_data): Update.
7748         (read_known_tasks_array): Return bool.
7749         (read_known_tasks_list): Likewise.
7750         (read_known_tasks): Return void.
7751         (ada_build_task_list): Now static.
7752
7753 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7754
7755         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7756         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7757
7758 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7759
7760         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7761         variant for ada_tasks_pspace_data_handle and
7762         ada_tasks_inferior_data_handle.
7763         (ada_tasks_pspace_data_cleanup): New function.
7764         (ada_tasks_inferior_data_cleanup): New function.
7765
7766 2019-02-17  Tom Tromey  <tom@tromey.com>
7767
7768         * macrotab.h (macro_source_fullname): Return a std::string.
7769         * macrotab.c (macro_include, check_for_redefinition)
7770         (macro_undef, macro_lookup_definition, foreach_macro)
7771         (foreach_macro_in_scope): Update.
7772         (macro_source_fullname): Return a std::string.
7773         * macrocmd.c (show_pp_source_pos): Update.
7774
7775 2019-02-17  Tom Tromey  <tom@tromey.com>
7776
7777         * macrocmd.c (show_pp_source_pos): Style the file names.
7778
7779 2019-02-17  Tom Tromey  <tom@tromey.com>
7780
7781         PR tui/24197:
7782         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7783
7784 2019-02-17  Tom Tromey  <tom@tromey.com>
7785
7786         * ada-lang.c (user_select_syms): Use filtered printing.
7787         * utils.c (wrap_style): New global.
7788         (desired_style): Remove.
7789         (emit_style_escape): Add stream parameter.
7790         (set_output_style, reset_terminal_style, prompt_for_continue):
7791         Update.
7792         (flush_wrap_buffer): Only flush gdb_stdout.
7793         (wrap_here): Set wrap_style.
7794         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7795         treat escape sequences as a character.  Change when wrap buffer is
7796         flushed.
7797         (fputs_styled): Do not set the output style when the default is
7798         requested.
7799         * ui-style.h (struct ui_file_style) <is_default>: New method.
7800         * source.c (print_source_lines_base): Emit escape sequences in one
7801         piece.
7802
7803 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7804
7805         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7806         integers and enumeration types.
7807
7808 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7809
7810         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7811         instead of lookup_symbol_in_language
7812         (do_exact_match): New function.
7813         (ada_get_symbol_name_matcher): Return do_exact_match when
7814         doing a verbatim match.
7815
7816 2019-02-15  Tom Tromey  <tromey@adacore.com>
7817
7818         * ravenscar-thread.c (ravenscar_thread_target::resume)
7819         (ravenscar_thread_target::wait): Special case wildcard requests.
7820
7821 2019-02-15  Tom Tromey  <tromey@adacore.com>
7822
7823         * ravenscar-thread.c (base_ptid): Remove.
7824         (struct ravenscar_thread_target) <close>: New method.
7825         <m_base_ptid>: New member.
7826         <update_inferior_ptid, active_task, task_is_currently_active,
7827         runtime_initialized>: Declare methods.
7828         <ravenscar_thread_target>: Add constructor.
7829         (ravenscar_thread_target::task_is_currently_active)
7830         (ravenscar_thread_target::update_inferior_ptid)
7831         (ravenscar_runtime_initialized): Rename.  Now methods.
7832         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7833         (ravenscar_thread_target::update_thread_list): Update.
7834         (ravenscar_thread_target::active_task): Now method.
7835         (ravenscar_thread_target::store_registers)
7836         (ravenscar_thread_target::prepare_to_store)
7837         (ravenscar_thread_target::prepare_to_store)
7838         (ravenscar_thread_target::mourn_inferior): Update.
7839         (ravenscar_inferior_created): Use "new" to create target.
7840         (ravenscar_thread_target::get_ada_task_ptid): Update.
7841         (_initialize_ravenscar): Don't initialize base_ptid.
7842         (ravenscar_ops): Remove global.
7843
7844 2019-02-15  Tom Tromey  <tromey@adacore.com>
7845
7846         * target.h (push_target): Declare new overload.
7847         * target.c (push_target): New overload, taking an rvalue reference.
7848         * remote.c (remote_target::open_1): Use push_target overload.
7849         * corelow.c (core_target_open): Use push_target overload.
7850
7851 2019-02-15  Tom Tromey  <tromey@adacore.com>
7852
7853         * ravenscar-thread.c (is_ravenscar_task)
7854         (ravenscar_task_is_currently_active): Return bool.
7855         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7856         (_initialize_ravenscar): Remove "(void)".
7857         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7858         Return bool.
7859
7860 2019-02-15  Tom Tromey  <tromey@adacore.com>
7861
7862         * ravenscar-thread.c (ravenscar_runtime_initializer)
7863         (has_ravenscar_runtime, get_running_thread_id)
7864         (ravenscar_thread_target::resume): Fix indentation.
7865
7866 2019-02-15  Tom Tromey  <tromey@adacore.com>
7867
7868         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7869         from ravenscar_arch_ops.
7870         (sparc_ravenscar_ops::fetch_registers)
7871         (sparc_ravenscar_ops::store_registers): Now methods.
7872         (sparc_ravenscar_prepare_to_store): Remove.
7873         (sparc_ravenscar_ops): Redefine.
7874         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7875         methods and destructor.  Remove members.
7876         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7877         (ravenscar_thread_target::store_registers)
7878         (ravenscar_thread_target::prepare_to_store): Update.
7879         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7880         Remove.
7881         (struct ppc_ravenscar_powerpc_ops): Derive from
7882         ravenscar_arch_ops.
7883         (ppc_ravenscar_powerpc_ops::fetch_registers)
7884         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7885         (ppc_ravenscar_powerpc_ops): Redefine.
7886         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7887         (ppc_ravenscar_e500_ops::fetch_registers)
7888         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7889         (ppc_ravenscar_e500_ops): Redefine.
7890         * aarch64-ravenscar-thread.c
7891         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7892         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7893         (aarch64_ravenscar_fetch_registers)
7894         (aarch64_ravenscar_store_registers): Now methods.
7895         (aarch64_ravenscar_ops): Redefine.
7896
7897 2019-02-15  Tom Tromey  <tromey@adacore.com>
7898
7899         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7900         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7901         (ravenscar_thread_target::stopped_by_watchpoint)
7902         (ravenscar_thread_target::stopped_data_address)
7903         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7904
7905 2019-02-15  Tom Tromey  <tromey@adacore.com>
7906
7907         * ravenscar-thread.c: Fix some typos.
7908
7909 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7910             Tom Tromey  <tromey@adacore.com>
7911
7912         * ada-lang.c (ada_exception_sal): Change addr_string to a
7913         std::string.
7914         (create_ada_exception_catchpoint): Update.
7915
7916 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7917             Tom Tromey  <tromey@adacore.com>
7918
7919         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7920         (bp_location_ops): Remove.
7921         (base_breakpoint_allocate_location): Update.
7922         (free_bp_location): Update.
7923         * ada-lang.c (class ada_catchpoint_location)
7924         <ada_catchpoint_location>: Remove ops parameter.
7925         (ada_catchpoint_location_dtor): Remove.
7926         (ada_catchpoint_location_ops): Remove.
7927         (allocate_location_exception): Update.
7928         * breakpoint.h (struct bp_location_ops): Remove.
7929         (class bp_location) <bp_location>: Remove bp_location_ops
7930         parameter.
7931         <~bp_location>: Add destructor.
7932         <ops>: Remove.
7933
7934 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7935             Pedro Alves  <palves@redhat.com>
7936
7937         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7938         'PATH_MAX'.
7939
7940 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7941             Samuel Thibault  <samuel.thibault@gnu.org>
7942             Thomas Schwinge  <thomas@codesourcery.com>
7943
7944         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7945         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7946
7947 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7948
7949         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7950         (check_empty): Use "const char *".
7951
7952         * gnu-nat.c (gnu_nat_target::detach): Instead of
7953         'detach_inferior (pid)' call
7954         'detach_inferior (find_inferior_pid (pid))'.
7955
7956         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7957         'nat/fork-inferior.o'.
7958         * gnu-nat.c: #include "nat/fork-inferior.h".
7959
7960         * gnu-nat.c (gnu_nat_target::detach): Instead of
7961         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7962         * gnu-nat.h: #include "inf-child.h".
7963         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7964         'i386_gnu_nat_target::fetch_registers'.
7965         (gnu_store_registers): Rename/move to
7966         'i386_gnu_nat_target::store_registers'.
7967
7968         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7969         * gnu-nat.h (mach_thread_info): New function.
7970         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7971
7972         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7973
7974 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7975
7976         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7977
7978 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7979
7980         * windows-nat.c (windows_add_thread): Add new parameter
7981         "main_thread_p" with default value set to false.  Update
7982         function documentation as well as all callers.
7983         (windows_delete_thread): Likewise.
7984         (fake_create_process): Update call to windows_add_thread.
7985         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7986         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7987         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7988         call to windows_delete_thread.
7989
7990 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7991
7992         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7993
7994 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7995
7996         * symfile.c (find_separate_debug_file): Use canonical path of
7997         sysroot with child_path instead of gdb_sysroot if it is valid.
7998
7999 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8000
8001         * symfile.c (find_separate_debug_file): Use child_path to
8002         determine if an object file is under a sysroot.
8003
8004 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8005
8006         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8007         unittests/child-path-selftests.c.
8008         * common/pathstuff.c (child_path): New function.
8009         * common/pathstuff.h (child_path): New prototype.
8010         * unittests/child-path-selftests.c: New file.
8011
8012 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8013
8014         * symfile.c (find_separate_debug_file): Look for separate debug
8015         files in debug directories under the sysroot.
8016
8017 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8018
8019         * symtab.h (struct minimal_symbol data_p): New const method.
8020         (struct minimal_symbol text_p): Likewise.
8021         * symtab.c (output_source_filename): Use file name style
8022         to print file name.
8023         (print_symbol_info): Likewise.
8024         (print_msymbol_info): Use address style to print addresses.
8025         Use function name style to print executable text symbols.
8026         (expand_symtab_containing_pc): Use data_p.
8027         (find_pc_sect_compunit_symtab): Likewise.
8028
8029 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8030
8031         * breakpoint.c (describe_other_breakpoints): Use address style
8032         to print addresses.
8033         (say_where): Likewise.
8034
8035 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8036
8037         * ada-typeprint.c (print_func_type): Print function name
8038         style to print function name.
8039         * c-typeprint.c (c_print_type_1): Likewise.
8040
8041 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8042
8043         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8044         for execve.
8045
8046 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8047
8048         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8049         type_stack.
8050
8051 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8052
8053         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8054         TYPE_CODE_REF types.
8055
8056 2019-02-08  Jim Wilson  <jimw@sifive.com>
8057
8058         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8059         (riscv_linux_fregset): New.
8060         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8061
8062 2019-02-07  Tom Tromey  <tom@tromey.com>
8063
8064         * thread.c (thread_cancel_execution_command): Update.
8065         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8066         methods.
8067         (struct thread_fsm_ops): Remove.
8068         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8069         (thread_fsm_should_stop, thread_fsm_return_value)
8070         (thread_fsm_set_finished, thread_fsm_finished_p)
8071         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8072         Don't declare.
8073         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8074         * infrun.c (clear_proceed_status_thread)
8075         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8076         (print_stop_event): Update.
8077         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8078         Add constructor.
8079         (step_command_fsm_ops): Remove.
8080         (new_step_command_fsm): Remove.
8081         (step_1): Update.
8082         (step_command_fsm::should_stop): Rename from
8083         step_command_fsm_should_stop.
8084         (step_command_fsm::clean_up): Rename from
8085         step_command_fsm_clean_up.
8086         (step_command_fsm::do_async_reply_reason): Rename from
8087         step_command_fsm_async_reply_reason.
8088         (struct until_next_fsm): Inherit from thread_fsm.  Add
8089         constructor.
8090         (until_next_fsm_ops): Remove.
8091         (new_until_next_fsm): Remove.
8092         (until_next_fsm::should_stop): Rename from
8093         until_next_fsm_should_stop.
8094         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8095         (until_next_fsm::do_async_reply_reason): Rename from
8096         until_next_fsm_async_reply_reason.
8097         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8098         constructor.  Change type of breakpoint.
8099         (finish_command_fsm_ops): Remove.
8100         (new_finish_command_fsm): Remove.
8101         (finish_command_fsm::should_stop): Rename from
8102         finish_command_fsm_should_stop.
8103         (finish_command_fsm::clean_up): Rename from
8104         finish_command_fsm_clean_up.
8105         (finish_command_fsm::return_value): Rename from
8106         finish_command_fsm_return_value.
8107         (finish_command_fsm::do_async_reply_reason): Rename from
8108         finish_command_fsm_async_reply_reason.
8109         (finish_command): Update.
8110         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8111         Add constructor.
8112         (call_thread_fsm_ops): Remove.
8113         (call_thread_fsm::call_thread_fsm): Rename from
8114         new_call_thread_fsm.
8115         (call_thread_fsm::should_stop): Rename from
8116         call_thread_fsm_should_stop.
8117         (call_thread_fsm::should_notify_stop): Rename from
8118         call_thread_fsm_should_notify_stop.
8119         (run_inferior_call, call_function_by_hand_dummy): Update.
8120         * cli/cli-interp.c (should_print_stop_to_console): Update.
8121         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8122         Add constructor.  Change type of location_breakpoint,
8123         caller_breakpoint.
8124         (until_break_fsm_ops): Remove.
8125         (new_until_break_fsm): Remove.
8126         (until_break_fsm::should_stop): Rename from
8127         until_break_fsm_should_stop.
8128         (until_break_fsm::clean_up): Rename from
8129         until_break_fsm_clean_up.
8130         (until_break_fsm::do_async_reply_reason): Rename from
8131         until_break_fsm_async_reply_reason.
8132         (until_break_command): Update.
8133         * thread-fsm.c: Remove.
8134         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8135
8136 2019-02-07  Tom Tromey  <tom@tromey.com>
8137
8138         * yy-remap.h: Add include guard.
8139         * xtensa-tdep.h: Add include guard.
8140         * xcoffread.h: Rename include guard.
8141         * varobj-iter.h: Add include guard.
8142         * tui/tui.h: Rename include guard.
8143         * tui/tui-winsource.h: Rename include guard.
8144         * tui/tui-wingeneral.h: Rename include guard.
8145         * tui/tui-windata.h: Rename include guard.
8146         * tui/tui-win.h: Rename include guard.
8147         * tui/tui-stack.h: Rename include guard.
8148         * tui/tui-source.h: Rename include guard.
8149         * tui/tui-regs.h: Rename include guard.
8150         * tui/tui-out.h: Rename include guard.
8151         * tui/tui-layout.h: Rename include guard.
8152         * tui/tui-io.h: Rename include guard.
8153         * tui/tui-hooks.h: Rename include guard.
8154         * tui/tui-file.h: Rename include guard.
8155         * tui/tui-disasm.h: Rename include guard.
8156         * tui/tui-data.h: Rename include guard.
8157         * tui/tui-command.h: Rename include guard.
8158         * tic6x-tdep.h: Add include guard.
8159         * target/waitstatus.h: Rename include guard.
8160         * target/wait.h: Rename include guard.
8161         * target/target.h: Rename include guard.
8162         * target/resume.h: Rename include guard.
8163         * target-float.h: Rename include guard.
8164         * stabsread.h: Add include guard.
8165         * rs6000-tdep.h: Add include guard.
8166         * riscv-fbsd-tdep.h: Add include guard.
8167         * regformats/regdef.h: Rename include guard.
8168         * record.h: Rename include guard.
8169         * python/python.h: Rename include guard.
8170         * python/python-internal.h: Rename include guard.
8171         * python/py-stopevent.h: Rename include guard.
8172         * python/py-ref.h: Rename include guard.
8173         * python/py-record.h: Rename include guard.
8174         * python/py-record-full.h: Rename include guard.
8175         * python/py-record-btrace.h: Rename include guard.
8176         * python/py-instruction.h: Rename include guard.
8177         * python/py-events.h: Rename include guard.
8178         * python/py-event.h: Rename include guard.
8179         * procfs.h: Add include guard.
8180         * proc-utils.h: Add include guard.
8181         * p-lang.h: Add include guard.
8182         * or1k-tdep.h: Rename include guard.
8183         * observable.h: Rename include guard.
8184         * nto-tdep.h: Rename include guard.
8185         * nat/x86-linux.h: Rename include guard.
8186         * nat/x86-linux-dregs.h: Rename include guard.
8187         * nat/x86-gcc-cpuid.h: Add include guard.
8188         * nat/x86-dregs.h: Rename include guard.
8189         * nat/x86-cpuid.h: Rename include guard.
8190         * nat/ppc-linux.h: Rename include guard.
8191         * nat/mips-linux-watch.h: Rename include guard.
8192         * nat/linux-waitpid.h: Rename include guard.
8193         * nat/linux-ptrace.h: Rename include guard.
8194         * nat/linux-procfs.h: Rename include guard.
8195         * nat/linux-osdata.h: Rename include guard.
8196         * nat/linux-nat.h: Rename include guard.
8197         * nat/linux-namespaces.h: Rename include guard.
8198         * nat/linux-btrace.h: Rename include guard.
8199         * nat/glibc_thread_db.h: Rename include guard.
8200         * nat/gdb_thread_db.h: Rename include guard.
8201         * nat/gdb_ptrace.h: Rename include guard.
8202         * nat/fork-inferior.h: Rename include guard.
8203         * nat/amd64-linux-siginfo.h: Rename include guard.
8204         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8205         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8206         * nat/aarch64-linux.h: Rename include guard.
8207         * nat/aarch64-linux-hw-point.h: Rename include guard.
8208         * mn10300-tdep.h: Add include guard.
8209         * mips-linux-tdep.h: Add include guard.
8210         * mi/mi-parse.h: Rename include guard.
8211         * mi/mi-out.h: Rename include guard.
8212         * mi/mi-main.h: Rename include guard.
8213         * mi/mi-interp.h: Rename include guard.
8214         * mi/mi-getopt.h: Rename include guard.
8215         * mi/mi-console.h: Rename include guard.
8216         * mi/mi-common.h: Rename include guard.
8217         * mi/mi-cmds.h: Rename include guard.
8218         * mi/mi-cmd-break.h: Rename include guard.
8219         * m2-lang.h: Add include guard.
8220         * location.h: Rename include guard.
8221         * linux-record.h: Rename include guard.
8222         * linux-nat.h: Add include guard.
8223         * linux-fork.h: Add include guard.
8224         * i386-darwin-tdep.h: Rename include guard.
8225         * hppa-linux-offsets.h: Add include guard.
8226         * guile/guile.h: Rename include guard.
8227         * guile/guile-internal.h: Rename include guard.
8228         * gnu-nat.h: Rename include guard.
8229         * gdb-stabs.h: Rename include guard.
8230         * frv-tdep.h: Add include guard.
8231         * f-lang.h: Add include guard.
8232         * event-loop.h: Add include guard.
8233         * darwin-nat.h: Rename include guard.
8234         * cp-abi.h: Rename include guard.
8235         * config/sparc/nm-sol2.h: Rename include guard.
8236         * config/nm-nto.h: Rename include guard.
8237         * config/nm-linux.h: Add include guard.
8238         * config/i386/nm-i386gnu.h: Rename include guard.
8239         * config/djgpp/nl_types.h: Rename include guard.
8240         * config/djgpp/langinfo.h: Rename include guard.
8241         * compile/gcc-cp-plugin.h: Add include guard.
8242         * compile/gcc-c-plugin.h: Add include guard.
8243         * compile/compile.h: Rename include guard.
8244         * compile/compile-object-run.h: Rename include guard.
8245         * compile/compile-object-load.h: Rename include guard.
8246         * compile/compile-internal.h: Rename include guard.
8247         * compile/compile-cplus.h: Rename include guard.
8248         * compile/compile-c.h: Rename include guard.
8249         * common/xml-utils.h: Rename include guard.
8250         * common/x86-xstate.h: Rename include guard.
8251         * common/version.h: Rename include guard.
8252         * common/vec.h: Rename include guard.
8253         * common/tdesc.h: Rename include guard.
8254         * common/selftest.h: Rename include guard.
8255         * common/scoped_restore.h: Rename include guard.
8256         * common/scoped_mmap.h: Rename include guard.
8257         * common/scoped_fd.h: Rename include guard.
8258         * common/safe-iterator.h: Rename include guard.
8259         * common/run-time-clock.h: Rename include guard.
8260         * common/refcounted-object.h: Rename include guard.
8261         * common/queue.h: Rename include guard.
8262         * common/ptid.h: Rename include guard.
8263         * common/print-utils.h: Rename include guard.
8264         * common/preprocessor.h: Rename include guard.
8265         * common/pathstuff.h: Rename include guard.
8266         * common/observable.h: Rename include guard.
8267         * common/netstuff.h: Rename include guard.
8268         * common/job-control.h: Rename include guard.
8269         * common/host-defs.h: Rename include guard.
8270         * common/gdb_wait.h: Rename include guard.
8271         * common/gdb_vecs.h: Rename include guard.
8272         * common/gdb_unlinker.h: Rename include guard.
8273         * common/gdb_unique_ptr.h: Rename include guard.
8274         * common/gdb_tilde_expand.h: Rename include guard.
8275         * common/gdb_sys_time.h: Rename include guard.
8276         * common/gdb_string_view.h: Rename include guard.
8277         * common/gdb_splay_tree.h: Rename include guard.
8278         * common/gdb_setjmp.h: Rename include guard.
8279         * common/gdb_ref_ptr.h: Rename include guard.
8280         * common/gdb_optional.h: Rename include guard.
8281         * common/gdb_locale.h: Rename include guard.
8282         * common/gdb_assert.h: Rename include guard.
8283         * common/filtered-iterator.h: Rename include guard.
8284         * common/filestuff.h: Rename include guard.
8285         * common/fileio.h: Rename include guard.
8286         * common/environ.h: Rename include guard.
8287         * common/common-utils.h: Rename include guard.
8288         * common/common-types.h: Rename include guard.
8289         * common/common-regcache.h: Rename include guard.
8290         * common/common-inferior.h: Rename include guard.
8291         * common/common-gdbthread.h: Rename include guard.
8292         * common/common-exceptions.h: Rename include guard.
8293         * common/common-defs.h: Rename include guard.
8294         * common/common-debug.h: Rename include guard.
8295         * common/cleanups.h: Rename include guard.
8296         * common/buffer.h: Rename include guard.
8297         * common/btrace-common.h: Rename include guard.
8298         * common/break-common.h: Rename include guard.
8299         * cli/cli-utils.h: Rename include guard.
8300         * cli/cli-style.h: Rename include guard.
8301         * cli/cli-setshow.h: Rename include guard.
8302         * cli/cli-script.h: Rename include guard.
8303         * cli/cli-interp.h: Rename include guard.
8304         * cli/cli-decode.h: Rename include guard.
8305         * cli/cli-cmds.h: Rename include guard.
8306         * charset-list.h: Add include guard.
8307         * buildsym-legacy.h: Rename include guard.
8308         * bfin-tdep.h: Add include guard.
8309         * ax.h: Rename include guard.
8310         * arm-linux-tdep.h: Add include guard.
8311         * arm-fbsd-tdep.h: Add include guard.
8312         * arch/xtensa.h: Rename include guard.
8313         * arch/tic6x.h: Add include guard.
8314         * arch/i386.h: Add include guard.
8315         * arch/arm.h: Rename include guard.
8316         * arch/arm-linux.h: Rename include guard.
8317         * arch/arm-get-next-pcs.h: Rename include guard.
8318         * arch/amd64.h: Add include guard.
8319         * arch/aarch64-insn.h: Rename include guard.
8320         * arch-utils.h: Rename include guard.
8321         * annotate.h: Add include guard.
8322         * amd64-darwin-tdep.h: Rename include guard.
8323         * aarch64-linux-tdep.h: Add include guard.
8324         * aarch64-fbsd-tdep.h: Add include guard.
8325         * aarch32-linux-nat.h: Add include guard.
8326
8327 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8328
8329         * macrotab.c (macro_define_internal): New function that
8330         factorizes macro_define_object_internal and macro_define_function
8331         code.
8332         (macro_define_object_internal): Use macro_define_internal.
8333         (macro_define_function): Likewise.
8334
8335 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8336
8337         * macrocmd.c (extract_identifier): Return
8338         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8339         callers.
8340
8341 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8342
8343         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8344
8345 2019-02-05  Tom Tromey  <tom@tromey.com>
8346
8347         * target.c (target_stack::unpush): Move assertion earlier.
8348
8349 2019-01-30  Tom Tromey  <tom@tromey.com>
8350
8351         PR python/23615:
8352         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8353         (gdbpy_parse_and_eval): Likewise.
8354         * python/python-internal.h (gdbpy_allow_threads): New class.
8355
8356 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8357
8358         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8359         (aarch64_fbsd_fpregmap): Move earlier.
8360         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8361         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8362         instead of individual calls to trad_frame_set_reg_addr.
8363         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8364         earlier.
8365         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8366         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8367         instead of individual calls to trad_frame_set_reg_addr.
8368
8369 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8370
8371         * CONTRIBUTE: Replace contribution list with wiki link.
8372
8373 2019-01-25  Tom Tromey  <tom@tromey.com>
8374
8375         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8376
8377 2019-01-25  Tom Tromey  <tom@tromey.com>
8378
8379         * xtensa-linux-nat.c: Fix common/ includes.
8380         * xml-support.h: Fix common/ includes.
8381         * xml-support.c: Fix common/ includes.
8382         * x86-linux-nat.c: Fix common/ includes.
8383         * windows-nat.c: Fix common/ includes.
8384         * varobj.h: Fix common/ includes.
8385         * varobj.c: Fix common/ includes.
8386         * value.c: Fix common/ includes.
8387         * valops.c: Fix common/ includes.
8388         * utils.c: Fix common/ includes.
8389         * unittests/xml-utils-selftests.c: Fix common/ includes.
8390         * unittests/utils-selftests.c: Fix common/ includes.
8391         * unittests/unpack-selftests.c: Fix common/ includes.
8392         * unittests/tracepoint-selftests.c: Fix common/ includes.
8393         * unittests/style-selftests.c: Fix common/ includes.
8394         * unittests/string_view-selftests.c: Fix common/ includes.
8395         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8396         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8397         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8398         * unittests/rsp-low-selftests.c: Fix common/ includes.
8399         * unittests/parse-connection-spec-selftests.c: Fix common/
8400         includes.
8401         * unittests/optional-selftests.c: Fix common/ includes.
8402         * unittests/offset-type-selftests.c: Fix common/ includes.
8403         * unittests/observable-selftests.c: Fix common/ includes.
8404         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8405         * unittests/memrange-selftests.c: Fix common/ includes.
8406         * unittests/memory-map-selftests.c: Fix common/ includes.
8407         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8408         * unittests/function-view-selftests.c: Fix common/ includes.
8409         * unittests/environ-selftests.c: Fix common/ includes.
8410         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8411         * unittests/common-utils-selftests.c: Fix common/ includes.
8412         * unittests/cli-utils-selftests.c: Fix common/ includes.
8413         * unittests/array-view-selftests.c: Fix common/ includes.
8414         * ui-file.c: Fix common/ includes.
8415         * tui/tui-io.c: Fix common/ includes.
8416         * tracepoint.h: Fix common/ includes.
8417         * tracepoint.c: Fix common/ includes.
8418         * tracefile-tfile.c: Fix common/ includes.
8419         * top.h: Fix common/ includes.
8420         * top.c: Fix common/ includes.
8421         * thread.c: Fix common/ includes.
8422         * target/waitstatus.h: Fix common/ includes.
8423         * target/waitstatus.c: Fix common/ includes.
8424         * target.h: Fix common/ includes.
8425         * target.c: Fix common/ includes.
8426         * target-memory.c: Fix common/ includes.
8427         * target-descriptions.c: Fix common/ includes.
8428         * symtab.h: Fix common/ includes.
8429         * symfile.c: Fix common/ includes.
8430         * stap-probe.c: Fix common/ includes.
8431         * spu-linux-nat.c: Fix common/ includes.
8432         * sparc-nat.c: Fix common/ includes.
8433         * source.c: Fix common/ includes.
8434         * solib.c: Fix common/ includes.
8435         * solib-target.c: Fix common/ includes.
8436         * ser-unix.c: Fix common/ includes.
8437         * ser-tcp.c: Fix common/ includes.
8438         * ser-pipe.c: Fix common/ includes.
8439         * ser-base.c: Fix common/ includes.
8440         * selftest-arch.c: Fix common/ includes.
8441         * s12z-tdep.c: Fix common/ includes.
8442         * rust-exp.y: Fix common/ includes.
8443         * rs6000-aix-tdep.c: Fix common/ includes.
8444         * riscv-tdep.c: Fix common/ includes.
8445         * remote.c: Fix common/ includes.
8446         * remote-notif.h: Fix common/ includes.
8447         * remote-fileio.h: Fix common/ includes.
8448         * remote-fileio.c: Fix common/ includes.
8449         * regcache.h: Fix common/ includes.
8450         * regcache.c: Fix common/ includes.
8451         * record-btrace.c: Fix common/ includes.
8452         * python/python.c: Fix common/ includes.
8453         * python/py-type.c: Fix common/ includes.
8454         * python/py-inferior.c: Fix common/ includes.
8455         * progspace.h: Fix common/ includes.
8456         * producer.c: Fix common/ includes.
8457         * procfs.c: Fix common/ includes.
8458         * proc-api.c: Fix common/ includes.
8459         * printcmd.c: Fix common/ includes.
8460         * ppc-linux-nat.c: Fix common/ includes.
8461         * parser-defs.h: Fix common/ includes.
8462         * osdata.c: Fix common/ includes.
8463         * obsd-nat.c: Fix common/ includes.
8464         * nat/x86-linux.c: Fix common/ includes.
8465         * nat/x86-linux-dregs.c: Fix common/ includes.
8466         * nat/x86-dregs.h: Fix common/ includes.
8467         * nat/x86-dregs.c: Fix common/ includes.
8468         * nat/ppc-linux.c: Fix common/ includes.
8469         * nat/mips-linux-watch.h: Fix common/ includes.
8470         * nat/mips-linux-watch.c: Fix common/ includes.
8471         * nat/linux-waitpid.c: Fix common/ includes.
8472         * nat/linux-ptrace.h: Fix common/ includes.
8473         * nat/linux-ptrace.c: Fix common/ includes.
8474         * nat/linux-procfs.c: Fix common/ includes.
8475         * nat/linux-personality.c: Fix common/ includes.
8476         * nat/linux-osdata.c: Fix common/ includes.
8477         * nat/linux-namespaces.c: Fix common/ includes.
8478         * nat/linux-btrace.h: Fix common/ includes.
8479         * nat/linux-btrace.c: Fix common/ includes.
8480         * nat/fork-inferior.c: Fix common/ includes.
8481         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8482         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8483         * nat/aarch64-linux.c: Fix common/ includes.
8484         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8485         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8486         * namespace.h: Fix common/ includes.
8487         * mips-linux-tdep.c: Fix common/ includes.
8488         * minsyms.c: Fix common/ includes.
8489         * mi/mi-parse.h: Fix common/ includes.
8490         * mi/mi-main.c: Fix common/ includes.
8491         * mi/mi-cmd-env.c: Fix common/ includes.
8492         * memrange.h: Fix common/ includes.
8493         * memattr.c: Fix common/ includes.
8494         * maint.h: Fix common/ includes.
8495         * maint.c: Fix common/ includes.
8496         * main.c: Fix common/ includes.
8497         * machoread.c: Fix common/ includes.
8498         * location.c: Fix common/ includes.
8499         * linux-thread-db.c: Fix common/ includes.
8500         * linux-nat.c: Fix common/ includes.
8501         * linux-fork.c: Fix common/ includes.
8502         * inline-frame.c: Fix common/ includes.
8503         * infrun.c: Fix common/ includes.
8504         * inflow.c: Fix common/ includes.
8505         * inferior.h: Fix common/ includes.
8506         * inferior.c: Fix common/ includes.
8507         * infcmd.c: Fix common/ includes.
8508         * inf-ptrace.c: Fix common/ includes.
8509         * inf-child.c: Fix common/ includes.
8510         * ia64-linux-nat.c: Fix common/ includes.
8511         * i387-tdep.c: Fix common/ includes.
8512         * i386-tdep.c: Fix common/ includes.
8513         * i386-linux-tdep.c: Fix common/ includes.
8514         * i386-linux-nat.c: Fix common/ includes.
8515         * i386-go32-tdep.c: Fix common/ includes.
8516         * i386-fbsd-tdep.c: Fix common/ includes.
8517         * i386-fbsd-nat.c: Fix common/ includes.
8518         * guile/scm-type.c: Fix common/ includes.
8519         * guile/guile.c: Fix common/ includes.
8520         * go32-nat.c: Fix common/ includes.
8521         * gnu-nat.c: Fix common/ includes.
8522         * gdbthread.h: Fix common/ includes.
8523         * gdbarch-selftests.c: Fix common/ includes.
8524         * gdb_usleep.c: Fix common/ includes.
8525         * gdb_select.h: Fix common/ includes.
8526         * gdb_bfd.c: Fix common/ includes.
8527         * gcore.c: Fix common/ includes.
8528         * fork-child.c: Fix common/ includes.
8529         * findvar.c: Fix common/ includes.
8530         * fbsd-nat.c: Fix common/ includes.
8531         * event-top.c: Fix common/ includes.
8532         * event-loop.c: Fix common/ includes.
8533         * dwarf2read.c: Fix common/ includes.
8534         * dwarf2loc.c: Fix common/ includes.
8535         * dwarf2-frame.c: Fix common/ includes.
8536         * dwarf-index-cache.c: Fix common/ includes.
8537         * dtrace-probe.c: Fix common/ includes.
8538         * disasm-selftests.c: Fix common/ includes.
8539         * defs.h: Fix common/ includes.
8540         * csky-tdep.c: Fix common/ includes.
8541         * cp-valprint.c: Fix common/ includes.
8542         * cp-support.h: Fix common/ includes.
8543         * cp-support.c: Fix common/ includes.
8544         * corelow.c: Fix common/ includes.
8545         * completer.h: Fix common/ includes.
8546         * completer.c: Fix common/ includes.
8547         * compile/compile.c: Fix common/ includes.
8548         * compile/compile-loc2c.c: Fix common/ includes.
8549         * compile/compile-cplus-types.c: Fix common/ includes.
8550         * compile/compile-cplus-symbols.c: Fix common/ includes.
8551         * command.h: Fix common/ includes.
8552         * cli/cli-dump.c: Fix common/ includes.
8553         * cli/cli-cmds.c: Fix common/ includes.
8554         * charset.c: Fix common/ includes.
8555         * build-id.c: Fix common/ includes.
8556         * btrace.h: Fix common/ includes.
8557         * btrace.c: Fix common/ includes.
8558         * breakpoint.h: Fix common/ includes.
8559         * breakpoint.c: Fix common/ includes.
8560         * ax.h:
8561         (enum agent_op): Fix common/ includes.
8562         * ax-general.c (struct aop_map): Fix common/ includes.
8563         * ax-gdb.c: Fix common/ includes.
8564         * auxv.c: Fix common/ includes.
8565         * auto-load.c: Fix common/ includes.
8566         * arm-tdep.c: Fix common/ includes.
8567         * arch/riscv.c: Fix common/ includes.
8568         * arch/ppc-linux-common.c: Fix common/ includes.
8569         * arch/i386.c: Fix common/ includes.
8570         * arch/arm.c: Fix common/ includes.
8571         * arch/arm-linux.c: Fix common/ includes.
8572         * arch/arm-get-next-pcs.c: Fix common/ includes.
8573         * arch/amd64.c: Fix common/ includes.
8574         * arch/aarch64.c: Fix common/ includes.
8575         * arch/aarch64-insn.c: Fix common/ includes.
8576         * arch-utils.c: Fix common/ includes.
8577         * amd64-windows-tdep.c: Fix common/ includes.
8578         * amd64-tdep.c: Fix common/ includes.
8579         * amd64-sol2-tdep.c: Fix common/ includes.
8580         * amd64-obsd-tdep.c: Fix common/ includes.
8581         * amd64-nbsd-tdep.c: Fix common/ includes.
8582         * amd64-linux-tdep.c: Fix common/ includes.
8583         * amd64-linux-nat.c: Fix common/ includes.
8584         * amd64-fbsd-tdep.c: Fix common/ includes.
8585         * amd64-fbsd-nat.c: Fix common/ includes.
8586         * amd64-dicos-tdep.c: Fix common/ includes.
8587         * amd64-darwin-tdep.c: Fix common/ includes.
8588         * agent.c: Fix common/ includes.
8589         * ada-lang.h: Fix common/ includes.
8590         * ada-lang.c: Fix common/ includes.
8591         * aarch64-tdep.c: Fix common/ includes.
8592
8593 2019-01-25  Tom Tromey  <tom@tromey.com>
8594
8595         * common/create-version.sh: Use common/version.h.
8596
8597 2019-01-24  Pedro Alves  <palves@redhat.com>
8598
8599         * infrun.c (signal_stop, signal_print, signal_program)
8600         (signal_catch, signal_pass): Now arrays instead of pointers.
8601         (update_signals_program_target, do_target_resume)
8602         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8603         * linux-nat.c (linux_nat_target::pass_signals)
8604         (linux_nat_target::create_inferior, linux_nat_target::attach):
8605         Adjust.
8606         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8607         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8608         * procfs.c (procfs_target::pass_signals): Adjust.
8609         * record-full.c (record_full_target::resume): Adjust.
8610         * remote.c (remote_target::pass_signals)
8611         (remote_target::program_signals): Adjust.
8612         * target-debug.h (target_debug_print_signals): Now takes a
8613         gdb::array_view as parameter.  Adjust.
8614         * target.h (target_ops) <pass_signals, program_signals>: Replace
8615         pointer and length parameters with gdb::array_view.
8616         (target_pass_signals, target_program_signals): Likewise.
8617         * target-delegates.c: Regenerate.
8618
8619 2019-01-24  Pedro Alves  <palves@redhat.com>
8620
8621         * common/forward-scope-exit.h
8622         (forward_scope_exit::forward_scope_exit): Pass arguments to
8623         m_bind_function directly, instead of creating a std::bind and
8624         copying that.
8625
8626 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8627
8628         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8629         for static members.
8630         (pass_in_v_vfp_candidate): Likewise.
8631
8632 2019-01-23  Tom Tromey  <tom@tromey.com>
8633             Pedro Alves  <palves@redhat.com>
8634
8635         * regcache.c (class regcache_invalidator): Remove.
8636         (regcache::raw_write): Use make_scope_exit.
8637
8638 2019-01-23  Tom Tromey  <tom@tromey.com>
8639
8640         * ui-out.h (class ui_out_emit_type): Update comment.
8641
8642 2019-01-23  Tom Tromey  <tom@tromey.com>
8643
8644         * infrun.c (fetch_inferior_event): Update comment.
8645
8646 2019-01-23  Tom Tromey  <tom@tromey.com>
8647             Pedro Alves  <palves@redhat.com>
8648
8649         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8650         parameter.
8651         (fetch_inferior_event): Use SCOPE_EXIT.
8652
8653
8654 2019-01-23  Tom Tromey  <tom@tromey.com>
8655             Pedro Alves  <palves@redhat.com>
8656
8657         * infrun.c (disable_thread_events): Delete.
8658         (stop_all_threads): Use SCOPE_EXIT.
8659
8660 2019-01-23  Tom Tromey  <tom@tromey.com>
8661             Pedro Alves  <palves@redhat.com>
8662
8663         * symfile.c: Include forward-scope-exit.h.
8664         (clear_symtab_users_cleanup): Replace forward declaration with
8665         a FORWARD_SCOPE_EXIT.
8666         (syms_from_objfile_1): Use the forward_scope_exit and
8667         gdb::optional instead of cleanup_function.
8668         (reread_symbols): Use the forward_scope_exit instead of
8669         cleanup_function.
8670         (clear_symtab_users_cleanup): Remove function.
8671
8672 2019-01-23  Tom Tromey  <tom@tromey.com>
8673             Pedro Alves  <palves@redhat.com>
8674
8675         * linux-nat.c: Include scope-exit.h.
8676         (cleanup_target_stop): Remove.
8677         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8678         SCOPE_EXIT.
8679
8680 2019-01-23  Tom Tromey  <tom@tromey.com>
8681             Pedro Alves  <palves@redhat.com>
8682
8683         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8684         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8685
8686 2019-01-23  Tom Tromey  <tom@tromey.com>
8687             Andrew Burgess  <andrew.burgess@embecosm.com>
8688             Pedro Alves  <palves@redhat.com>
8689
8690         * infrun.c (fetch_inferior_event): Use scope_exit.
8691         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8692         * top.c (execute_command): Use scope_exit.
8693         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8694         * utils.c (do_bpstat_clear_actions_cleanup)
8695         (make_bpstat_clear_actions_cleanup): Remove.
8696
8697 2019-01-23  Tom Tromey  <tom@tromey.com>
8698             Pedro Alves  <palves@redhat.com>
8699
8700         * infrun.c: Include "common/scope-exit.h"
8701         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8702         (wait_for_inferior): Use SCOPE_EXIT.
8703         (fetch_inferior_event): Use scope_exit.
8704
8705 2019-01-23  Tom Tromey  <tom@tromey.com>
8706             Pedro Alves  <palves@redhat.com>
8707
8708         * breakpoint.c (create_breakpoint): Remove cleanup.
8709
8710 2019-01-23  Tom Tromey  <tom@tromey.com>
8711             Andrew Burgess  <andrew.burgess@embecosm.com>
8712             Pedro Alves  <palves@redhat.com>
8713
8714 2019-01-23  Pedro Alves  <palves@redhat.com>
8715
8716         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8717
8718 2019-01-23  Pedro Alves  <palves@redhat.com>
8719             Andrew Burgess  <andrew.burgess@embecosm.com>
8720
8721         * gdbthread.h: Include "common/forward-scope-exit.h".
8722         (scoped_finish_thread_state): Redefine custom class in terms of
8723         forward_scope_exit.
8724
8725 2019-01-23  Pedro Alves  <palves@redhat.com>
8726             Andrew Burgess  <andrew.burgess@embecosm.com>
8727
8728         * common/forward-scope-exit.h: New file.
8729
8730 2019-01-23  Pedro Alves  <palves@redhat.com>
8731             Andrew Burgess  <andrew.burgess@embecosm.com>
8732             Tom Tromey  <tom@tromey.com>
8733
8734         * common/scope-exit.h: New file.
8735
8736 2019-01-23  Pedro Alves  <palves@redhat.com>
8737
8738         * common/preprocessor.h (ESC): Rename to ...
8739         (ESC_PARENS): ... this.
8740         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8741         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8742
8743 2019-01-23  Tom Tromey  <tom@tromey.com>
8744
8745         * language.h (class scoped_switch_to_sym_language_if_auto):
8746         Initialize m_lang in both cases.
8747
8748 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8749
8750         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8751         with XCNEW.
8752
8753 2019-01-22  Tom Tromey  <tom@tromey.com>
8754
8755         * corelow.c: Do not include sys/file.h.
8756
8757 2019-01-22  Tom Tromey  <tom@tromey.com>
8758
8759         * tui/tui-wingeneral.h: Include gdb_curses.h.
8760
8761 2019-01-22  Tom Tromey  <tom@tromey.com>
8762
8763         * source-cache.h (class source_cache) <get_source_lines,
8764         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8765
8766 2019-01-22  Tom Tromey  <tom@tromey.com>
8767
8768         * remote-fileio.h (struct remote_target): Declare.
8769
8770 2019-01-22  Tom Tromey  <tom@tromey.com>
8771
8772         * python/py-arch.c: Do not include py-ref.h.
8773         * python/py-bpevent.c: Do not include py-ref.h.
8774         * python/py-cmd.c: Do not include py-ref.h.
8775         * python/py-continueevent.c: Do not include py-ref.h.
8776         * python/py-event.h: Do not include py-ref.h.
8777         * python/py-evtregistry.c: Do not include py-ref.h.
8778         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8779         * python/py-frame.c: Do not include py-ref.h.
8780         * python/py-framefilter.c: Do not include py-ref.h.
8781         * python/py-function.c: Do not include py-ref.h.
8782         * python/py-infevents.c: Do not include py-ref.h.
8783         * python/py-linetable.c: Do not include py-ref.h.
8784         * python/py-objfile.c: Do not include py-ref.h.
8785         * python/py-param.c: Do not include py-ref.h.
8786         * python/py-prettyprint.c: Do not include py-ref.h.
8787         * python/py-progspace.c: Do not include py-ref.h.
8788         * python/py-symbol.c: Do not include py-ref.h.
8789         * python/py-symtab.c: Do not include py-ref.h.
8790         * python/py-type.c: Do not include py-ref.h.
8791         * python/py-unwind.c: Do not include py-ref.h.
8792         * python/py-utils.c: Do not include py-ref.h.
8793         * python/py-value.c: Do not include py-ref.h.
8794         * python/py-varobj.c: Do not include py-ref.h.
8795         * python/py-xmethods.c: Do not include py-ref.h.
8796         * python/python.c: Do not include py-ref.h.
8797         * varobj.c: Do not include py-ref.h.
8798
8799 2019-01-22  Tom Tromey  <tom@tromey.com>
8800
8801         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8802         keyword for bcache.
8803
8804 2019-01-22  Tom Tromey  <tom@tromey.com>
8805
8806         * compile/compile-cplus-types.c: Remove a comment by #include.
8807
8808 2019-01-22  Tom Tromey  <tom@tromey.com>
8809
8810         * compile/gcc-c-plugin.h: Include compile-internal.h.
8811
8812 2019-01-22  Tom Tromey  <tom@tromey.com>
8813
8814         * stabsread.c (EXTERN): Do not define.
8815         (symnum, next_symbol_text_func, processing_gcc_compilation)
8816         (within_function, global_sym_chain, global_stabs)
8817         (previous_stab_code, this_object_header_files)
8818         (n_this_object_header_files)
8819         (n_allocated_this_object_header_files): Define.
8820         * stabsread.h (EXTERN): Never define.  Use "extern".
8821
8822 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8823
8824         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8825         history_value.
8826
8827 2019-01-21  Tom Tromey  <tom@tromey.com>
8828
8829         * ui-out.c: Fix includes.
8830         * tui/tui-source.c: Fix includes.
8831         * target.c: Fix includes.
8832         * remote.c: Fix includes.
8833         * regcache.c: Fix includes.
8834         * python/py-block.c: Fix includes.
8835         * printcmd.c: Fix includes.
8836         * or1k-tdep.c: Fix includes.
8837         * mi/mi-main.c: Fix includes.
8838         * m32r-tdep.c: Fix includes.
8839         * csky-tdep.c: Fix includes.
8840         * compile/compile-cplus-types.c: Fix includes.
8841         * cli/cli-interp.c: Fix includes.
8842
8843 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8844
8845         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8846         for padding.
8847
8848 2019-01-16  Tom Tromey  <tom@tromey.com>
8849
8850         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8851         earlier.
8852         (struct objfile) <msymbols_range>: Move from top level.
8853         <msymbols>: New method.
8854         (class objfile_msymbols): Remove.
8855         * symtab.c (default_collect_symbol_completion_matches_break_on):
8856         Update.
8857         * symmisc.c (dump_msymbols): Update.
8858         * stabsread.c (scan_file_globals): Update.
8859         * objc-lang.c (info_selectors_command, info_classes_command)
8860         (find_methods): Update.
8861         * minsyms.c (find_solib_trampoline_target): Update.
8862         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8863         * coffread.c (coff_symfile_read): Update.
8864         * ada-lang.c (ada_lookup_simple_minsym)
8865         (ada_collect_symbol_completion_matches): Update.
8866
8867 2019-01-16  Tom Tromey  <tom@tromey.com>
8868
8869         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8870         type.  Remove no-argument constructor.
8871         <iterator::operator++>: Simplify.
8872         <begin>: Update.
8873         <end>: Use minimal_symbol_count.
8874
8875 2019-01-16  Tom Tromey  <tom@tromey.com>
8876
8877         * objfiles.h (struct objfile) <psymtabs>: New method.
8878         (class objfile_psymtabs): Remove.
8879         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8880         typedef.
8881         <range>: New method.
8882         (require_partial_symbols): Change return type.
8883         * psymtab.c (require_partial_symbols)
8884         (psym_expand_symtabs_matching): Update.
8885         * mdebugread.c (parse_partial_symbols): Update.
8886         * dbxread.c (dbx_end_psymtab): Update.
8887
8888 2019-01-15  Tom Tromey  <tom@tromey.com>
8889
8890         * symtab.c (lookup_objfile_from_block)
8891         (lookup_symbol_in_objfile_symtabs)
8892         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8893         (find_line_symtab, info_sources_command)
8894         (default_collect_symbol_completion_matches_break_on)
8895         (make_source_files_completion_list): Update.
8896         * symmisc.c (print_objfile_statistics, dump_objfile)
8897         (maintenance_print_symbols, maintenance_info_symtabs)
8898         (maintenance_check_symtabs, maintenance_info_line_tables):
8899         Update.
8900         * source.c (select_source_symtab)
8901         (forget_cached_source_info_for_objfile): Update.
8902         * objfiles.h (class objfile_compunits): Remove.
8903         (struct objfile) <compunits_range>: New typedef.
8904         (compunits): New method.
8905         * objfiles.c (objfile_relocate1): Update.
8906         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8907         * maint.c (count_symtabs_and_blocks): Update.
8908         * linespec.c (iterate_over_all_matching_symtabs): Update.
8909         * cp-support.c (add_symbol_overload_list_qualified): Update.
8910         * coffread.c (coff_symtab_read): Update.
8911         * ada-lang.c (add_nonlocal_symbols)
8912         (ada_collect_symbol_completion_matches)
8913         (ada_add_global_exceptions): Update.
8914
8915 2019-01-15  Tom Tromey  <tom@tromey.com>
8916
8917         * progspace.h (program_space) <objfiles_safe_range>: New
8918         typedef.
8919         <objfiles_safe>: New method.
8920         * objfiles.h (class all_objfiles_safe): Remove.
8921         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8922         * jit.c (jit_inferior_exit_hook): Update.
8923
8924 2019-01-17  Tom Tromey  <tom@tromey.com>
8925
8926         * progspace.h (program_space) <objfiles_range>: New typedef.
8927         <objfiles>: New method.
8928         <objfiles_head>: Rename from objfiles.
8929         (object_files): Update.
8930         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8931         * guile/scm-pretty-print.c
8932         (ppscm_find_pretty_printer_from_objfiles): Update.
8933         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8934         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8935         Update.
8936         * python/py-progspace.c (pspy_get_objfiles): Update.
8937         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8938         Update.
8939         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8940         (objfpy_lookup_objfile_by_build_id): Update.
8941         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8942         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8943         Update.
8944         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8945         (expand_symtab_containing_pc, lookup_objfile_from_block)
8946         (lookup_static_symbol, basic_lookup_transparent_type)
8947         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8948         (find_line_symtab, info_sources_command)
8949         (default_collect_symbol_completion_matches_break_on)
8950         (make_source_files_completion_list, find_main_name): Update.
8951         * symmisc.c (print_symbol_bcache_statistics)
8952         (print_objfile_statistics, maintenance_print_symbols)
8953         (maintenance_print_msymbols, maintenance_print_objfiles)
8954         (maintenance_info_symtabs, maintenance_check_symtabs)
8955         (maintenance_expand_symtabs, maintenance_info_line_tables):
8956         Update.
8957         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8958         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8959         (map_overlay_command, unmap_overlay_command)
8960         (simple_overlay_update, expand_symtabs_matching)
8961         (map_symbol_filenames): Update.
8962         * symfile-debug.c (set_debug_symfile): Update.
8963         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8964         Update.
8965         * source.c (select_source_symtab, forget_cached_source_info):
8966         Update.
8967         * solib.c (solib_read_symbols): Update.
8968         * solib-spu.c (append_ocl_sos): Update.
8969         * psymtab.c (maintenance_print_psymbols)
8970         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8971         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8972         * printcmd.c (info_symbol_command): Update.
8973         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8974         Update.
8975         * objfiles.h (class all_objfiles): Remove.
8976         * objfiles.c (have_partial_symbols, have_full_symbols)
8977         (have_minimal_symbols, qsort_cmp, update_section_map)
8978         (shared_objfile_contains_address_p)
8979         (default_iterate_over_objfiles_in_search_order): Update.
8980         * objc-lang.c (info_selectors_command, info_classes_command)
8981         (find_methods): Update.
8982         * minsyms.c (find_solib_trampoline_target): Update.
8983         * maint.c (maintenance_info_sections)
8984         (maintenance_translate_address, count_symtabs_and_blocks):
8985         Update.
8986         * main.c (captured_main_1): Update.
8987         * linux-thread-db.c (try_thread_db_load_from_pdir)
8988         (has_libpthread): Update.
8989         * linespec.c (iterate_over_all_matching_symtabs)
8990         (search_minsyms_for_name): Update.
8991         * jit.c (jit_find_objf_with_entry_addr): Update.
8992         * hppa-tdep.c (find_unwind_entry)
8993         (hppa_lookup_stub_minimal_symbol): Update.
8994         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8995         Update.
8996         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8997         (elf_gnu_ifunc_resolve_by_got): Update.
8998         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8999         * dwarf-index-write.c (save_gdb_index_command): Update.
9000         * cp-support.c (add_symbol_overload_list_qualified): Update.
9001         * breakpoint.c (create_overlay_event_breakpoint)
9002         (create_longjmp_master_breakpoint)
9003         (create_std_terminate_master_breakpoint)
9004         (create_exception_master_breakpoint): Update.
9005         * blockframe.c (find_pc_partial_function): Update.
9006         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9007         (ada_collect_symbol_completion_matches)
9008         (ada_add_global_exceptions): Update.
9009
9010 2019-01-17  Tom Tromey  <tom@tromey.com>
9011
9012         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9013         declare VEC.
9014         (solib_target_parse_libraries): Change return type.
9015         (library_list_start_segment, library_list_start_section)
9016         (library_list_end_library, library_list_start_library); Update.
9017         (solib_target_free_library_list): Remove.
9018         (solib_target_parse_libraries): Remove cleanup.  Change return
9019         type.
9020         (solib_target_current_sos): Update.
9021
9022 2019-01-17  Tom Tromey  <tromey@bapiya>
9023
9024         * valprint.c: Replace "the the" with "the".
9025         * symtab.c: Replace "the the" with "the".
9026         * solib.c: Replace "the the" with "the".
9027         * solib-dsbt.c: Replace "the the" with "the".
9028         * linespec.c: Replace "the the" with "the".
9029         * dwarf2loc.h: Replace "the the" with "the".
9030         * amd64-windows-tdep.c: Replace "the the" with "the".
9031         * aarch64-tdep.c: Replace "the the" with "the".
9032
9033 2019-01-16  Keith Seitz  <keiths@redhat.com>
9034
9035         PR gdb/23773
9036         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9037         <builder>: Rename to ..
9038         <m_builder>: ... this and make private.
9039         (dwarf2_cu::get_builder): New method.  Change all users of
9040         `builder' to use this method.
9041         (dwarf2_start_symtab): Move to ...
9042         (dwarf2_cu::start_symtab): ... here.  Update all callers
9043         (setup_type_unit_groups): Move to ...
9044         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9045         callers.
9046         (dwarf2_cu::reset_builder): New method.
9047         (process_full_compunit, process_full_type_unit): Use
9048         dwarf2_cu::reset_builder.
9049         (follow_die_offset): Record the ancestor CU if it is different
9050         from the followed DIE's CU.
9051         (follow_die_sig_1): Likewise.
9052
9053 2019-01-15  Tom Tromey  <tom@tromey.com>
9054
9055         * remote.c (class remote_state) <buf>: Now a char_vector.
9056         <buf_size>: Remove.
9057         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9058         parameter.
9059         (remote_target::getpkt_or_notif_sane_1)
9060         (remote_target::getpkt_sane)
9061         (remote_target::getpkt_or_notif_sane): Likewise.
9062         (class remote_target) <putpkt>: New overload.
9063         (remote_target::read_frame): Change type of "buf_p".  Remove
9064         sizeof_p parameter.
9065         (packet_ok): New overload.
9066         (packet_check_result): New overload.
9067         Update all uses.
9068
9069 2019-01-14  Tom Tromey  <tom@tromey.com>
9070
9071         * remote-notif.c (handle_notification, remote_notif_ack)
9072         (remote_notif_parse): Make "buf" const.
9073         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9074         const.
9075         (remote_notif_parse, remote_notif_ack, handle_notification):
9076         Likewise.
9077         * remote.c (remote_notif_stop_parse): Make "buf" const.
9078         (remote_target::remote_parse_stop_reply): Make "buf" const.
9079         (remote_notif_stop_ack): Make "buf" const.
9080
9081 2019-01-14  Tom Tromey  <tom@tromey.com>
9082
9083         * remote.c (remote_console_output): Make parameter const.
9084
9085 2019-01-14  Tom Tromey  <tom@tromey.com>
9086
9087         * target-debug.h (target_debug_print_signals): Constify.
9088         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9089         * procfs.c (procfs_target::pass_signals): Update.
9090         * linux-nat.c (linux_nat_target::pass_signals): Update.
9091         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9092         * target-delegates.c: Rebuild.
9093         * remote.c (remote_target::program_signals): Update.
9094         (remote_target::pass_signals): Update.
9095         * target.c (target_pass_signals): Constify argument.
9096         (target_program_signals): Likewise.
9097         * target.h (struct target_ops) <pass_signals, program_signals>:
9098         Constify argument.
9099         (target_pass_signals, target_program_signals): Constify argument.
9100
9101 2019-01-14  Tom Tromey  <tom@tromey.com>
9102
9103         PR tui/28819:
9104         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9105
9106 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9107
9108         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9109         field.
9110         * rs6000-tdep.c: Include reggroups.h.
9111         (IS_V_ALIAS_PSEUDOREG): Define.
9112         (rs6000_register_name): Return names for the "vX" aliases.
9113         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9114         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9115         aliases.  Call default_register_reggroup_p for all other
9116         pseudo-registers.
9117         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9118         New functions.
9119         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9120         Handle "vX" aliases.
9121         (v_alias_pseudo_register_collect): New function.
9122         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9123         (rs6000_gdbarch_init): Initialize "vX" aliases as
9124         pseudo-registers.  Restore registration of
9125         rs6000_pseudo_register_reggroup_p with
9126         set_tdesc_pseudo_register_reggroup_p.
9127
9128 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9129
9130         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9131         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9132         set_gdbarch_num_pseudo_regs.
9133
9134 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9135
9136         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9137         Remove arg prefixname, add do_set and do_show.
9138         Add member functions set_list and show_list.
9139         * cli/cli-style.c (class cli_style_option): Update accordingly.
9140         (style_set_list): Move to file scope.
9141         (style_show_list): Likewise.
9142         (set_style): Call help_list.
9143         (show_style): Call cmd_show_list.
9144         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9145         Update to use the new macro.
9146
9147 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9148
9149         * ada-lang.c (_initialize_ada_language): Expand the help text
9150         for the "catch exception" command.
9151
9152 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9153
9154         * symtab.c (matching_obj_sections): Initialize obj,
9155         declare it closer to its usage.
9156
9157 2019-01-10  Tom Tromey  <tom@tromey.com>
9158
9159         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9160         (basic_inf_threads_range): Remove.
9161         (inf_threads_range, inf_non_exited_threads_range)
9162         (safe_inf_threads_range): Use next_adapter.
9163
9164 2019-01-10  Keith Seitz  <keiths@redhat.com>
9165
9166         PR gdb/23712
9167         PR symtab/23010
9168         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9169         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9170
9171 2019-01-10  Keith Seitz  <keiths@redhat.com>
9172
9173         PR gdb/23712
9174         PR symtab/23010
9175         * dictionary.c (pending_to_vector): Remove.
9176         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9177         Remove _1 suffix, replacing functions of the same name.  Update
9178         all callers.
9179         (dict_create_hashed, dict_create_hashed_expandable)
9180         (dict_create_linear, dict_create_linear_expandable, dict_free)
9181         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9182         Make functions static.
9183
9184 2019-01-10  Keith Seitz  <keiths@redhat.com>
9185
9186         PR gdb/23712
9187         PR symtab/23010
9188         * dictionary.h (struct dictionary): Replace declaration with
9189         multidictionary.
9190         (dict_create_hashed, dict_create_hashed_expandable)
9191         (dict_create_linear, dict_create_linear_expandable)
9192         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9193         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9194         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9195         taking multidictionary argument.
9196         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9197         * block.h (struct block) <dict>: Change to multidictionary
9198         and rename `multidict'.
9199         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9200         symmisc.c: Update all dictionary references to multidictionary.
9201
9202 2019-01-10  Keith Seitz  <keiths@redhat.com>
9203
9204         PR gdb/23712
9205         PR symtab/23010
9206         * dictionary.c: Include unordered_map.
9207         (pending_to_vector): New function.
9208         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9209         Rewrite the non-"_1" functions to take vector instead
9210         of linked list.
9211         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9212         "new" _1 versions of the same name.
9213         (multidictionary): Define.
9214         (std::hash<enum language): New definition.
9215         (collate_pending_symbols_by_language, mdict_create_hashed)
9216         (mdict_create_hashed_expandable, mdict_create_linear)
9217         (mdict_create_linear_expandable, mdict_free)
9218         (find_language_dictionary, create_new_language_dictionary)
9219         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9220         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9221         (mdict_size, mdict_empty): New functions.
9222         * dictionary.h (mdict_iterator): Define.
9223
9224 2019-01-10  Pedro Alves  <palves@redhat.com>
9225
9226         * breakpoint.c (read_uploaded_action)
9227         (create_tracepoint_from_upload): Adjust to use
9228         gdb::unique_xmalloc_ptr.
9229         * ctf.c (ctf_write_uploaded_tp):
9230         (SET_ARRAY_FIELD): Use emplace_back.
9231         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9232         * tracefile-tfile.c (tfile_write_uploaded_tp):
9233         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9234         gdb::unique_xmalloc_ptr.
9235         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9236         at_string, cond_string, cmd_strings>: Replace char pointers
9237         with gdb::unique_xmalloc_ptr.
9238
9239 2019-01-10  Pedro Alves  <palves@redhat.com>
9240
9241         * solib-target.c (library_list_start_library): Don't xstrdup name.
9242
9243 2019-01-10  Pedro Alves  <palves@redhat.com>
9244
9245         * mdebugread.c (parse_partial_symbols): Use
9246         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9247
9248 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9249
9250         * linux-fork.c (scoped_switch_fork_info)
9251         <~scoped_switch_fork_info>: Fix incorrect variable name.
9252
9253 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9254
9255         * linux-fork.c (scoped_switch_fork_info)
9256         <scoped_switch_fork_info>: Make explicit.
9257         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9258
9259 2019-01-10  Tom Tromey  <tom@tromey.com>
9260
9261         * objfiles.h (objfile::reset_psymtabs): Update.
9262         * objfiles.c (objfile::objfile): Update.
9263         * psymtab.h (psymtab_storage::obstack): Update.
9264         (psymtab_storage::m_obstack): Use gdb::optional.
9265         (class psymtab_storage): Update comment.  Remove objfile
9266         parameter.
9267         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9268
9269 2019-01-10  Tom Tromey  <tom@tromey.com>
9270
9271         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9272         <free_psymtabs>: Now private.
9273         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9274         (allocate_psymtab): Use new method.
9275
9276 2019-01-10  Tom Tromey  <tom@tromey.com>
9277
9278         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9279         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9280         * mdebugread.c (parse_partial_symbols): Use
9281         allocate_dependencies.
9282         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9283         allocate_dependencies.
9284         (process_psymtab_comp_unit_reader)
9285         (build_type_psymtab_dependencies): Likewise.
9286         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9287
9288 2019-01-10  Tom Tromey  <tom@tromey.com>
9289
9290         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9291         PSYMBOL_SET_LANGUAGE.
9292         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9293
9294 2019-01-10  Tom Tromey  <tom@tromey.com>
9295
9296         * psymtab.h (psymtab_storage::obstack): New method.
9297         <m_obstack>: Rename from obstack; now private.
9298         * psymtab.c (psymtab_storage): Update.
9299         * dwarf2read.c (create_addrmap_from_index)
9300         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9301         Update.
9302
9303 2019-01-10  Tom Tromey  <tom@tromey.com>
9304
9305         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9306         * objfiles.h (objfile::reset_psymtabs): New method.
9307
9308 2019-01-10  Tom Tromey  <tom@tromey.com>
9309
9310         * symmisc.c (print_symbol_bcache_statistics): Update.
9311         (print_objfile_statistics): Update.
9312         * symfile.c (reread_symbols): Update.
9313         * psymtab.h (class psymtab_storage): New.
9314         * psymtab.c (psymtab_storage): New constructor.
9315         (~psymtab_storage): New destructor.
9316         (require_partial_symbols): Update.
9317         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9318         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9319         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9320         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9321         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9322         (start_psymtab_common, end_psymtab_common)
9323         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9324         (allocate_psymtab): Update.
9325         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9326         Update.
9327         (dump_psymtab_addrmap, maintenance_print_psymbols)
9328         (maintenance_check_psymtabs): Update.
9329         (class objfile_psymtabs): Move to objfiles.h.
9330         * psympriv.h (discard_psymtab): Now inline.
9331         (psymtab_discarder::psymtab_discarder): Update.
9332         (psymtab_discarder::~psymtab_discarder): Update.
9333         (ALL_OBJFILE_PSYMTABS): Rewrite.
9334         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9335         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9336         Remove fields.
9337         <partial_symtabs>: New field.
9338         (class objfile_psymtabs): Move from psymtab.h.  Update.
9339         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9340         psymbol_cache.
9341         (objfile::~objfile): Don't destroy psymbol_cache.
9342         * mdebugread.c (parse_partial_symbols): Update.
9343         * dwarf2read.c (create_addrmap_from_index)
9344         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9345         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9346         (add_partial_subprogram, dwarf2_ranges_read): Update.
9347         * dwarf-index-write.c (write_address_map)
9348         (write_one_signatured_type, recursively_write_psymbols)
9349         (class debug_names, class debug_names, write_psymtabs_to_index):
9350         Update.
9351
9352 2019-01-10  Tom Tromey  <tom@tromey.com>
9353
9354         * symtab.h (SYMBOL_SET_NAMES): Update.
9355         (symbol_set_names): Update.
9356         (MSYMBOL_SET_NAMES): Update.
9357         * symtab.c (symbol_set_names): Change argument to be an
9358         objfile_per_bfd_storage.
9359         * psymtab.c (add_psymbol_to_bcache): Update.
9360         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9361
9362 2019-01-10  Tom Tromey  <tom@tromey.com>
9363
9364         * symtab.c (create_demangled_names_hash): Change argument to be an
9365         objfile_per_bfd_storage.
9366         (symbol_set_names): Update.
9367
9368 2019-01-10  Tom Tromey  <tom@tromey.com>
9369
9370         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9371         init_psymbol_list.
9372         * psymtab.c (init_psymbol_list): Do nothing if already called.
9373         * psympriv.h (init_psymbol_list): Add comment.
9374         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9375         init_psymbol_list.
9376         * dbxread.c (dbx_symfile_read): Unconditionally call
9377         init_psymbol_list.
9378
9379 2019-01-10  Tom Tromey  <tom@tromey.com>
9380
9381         * xcoffread.c (scan_xcoff_symtab): Update.
9382         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9383         "where".
9384         * mdebugread.c (parse_partial_symbols)
9385         (handle_psymbol_enumerators): Update.
9386         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9387         * dbxread.c (read_dbx_symtab): Update.
9388         * psympriv.h (psymbol_placement): New enum.
9389         (add_psymbol_to_list): Update.
9390
9391 2019-01-10  Tom Tromey  <tom@tromey.com>
9392
9393         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9394         static_psymbols parameters.
9395         (scan_xcoff_symtab): Update.
9396         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9397         static_psymbols parameters.
9398         * psympriv.h (start_psymtab_common): Update.
9399         * mdebugread.c (parse_partial_symbols): Update.
9400         * dwarf2read.c (create_partial_symtab): Update.
9401         * dbxread.c (read_dbx_symtab): Update.
9402         (start_psymtab): Remove global_psymbols and static_psymbols
9403         parameters.
9404
9405 2019-01-10  Tom Tromey  <tom@tromey.com>
9406
9407         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9408         * psymtab.c (allocate_psymtab): Add comment.
9409         * psympriv.h (allocate_psymtab): Add comment.
9410         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9411         initializations.
9412         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9413
9414 2019-01-10  Tom Tromey  <tom@tromey.com>
9415
9416         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9417         Don't declare.
9418         * mipsread.c: Include mdebugread.h.
9419         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9420         Declare.
9421         * elfread.c: Include mdebugread.h.
9422
9423 2019-01-09  Tom Tromey  <tom@tromey.com>
9424
9425         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9426         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9427         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9428         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9429         (psym_lookup_symbol, psym_find_last_source_symtab)
9430         (psym_forget_cached_source_info, psym_print_stats)
9431         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9432         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9433         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9434         (psym_find_compunit_symtab_by_address)
9435         (maintenance_print_psymbols, maintenance_info_psymtabs)
9436         (maintenance_check_psymtabs): Use ranged for.
9437         * psymtab.h (class objfile_psymtabs): New.
9438         (require_partial_symbols): Return objfile_psymtabs.
9439         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9440
9441 2019-01-09  Tom Tromey  <tom@tromey.com>
9442
9443         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9444         (find_pc_mapped_section, list_overlays_command)
9445         (map_overlay_command, unmap_overlay_command)
9446         (simple_overlay_update): Use all_objfiles.
9447         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9448         * printcmd.c (info_symbol_command): Use all_objfiles.
9449         * objfiles.h (ALL_OBJSECTIONS): Remove.
9450         * maint.c (maintenance_translate_address): Use all_objfiles.
9451         * gcore.c (gcore_create_callback): Use all_objfiles.
9452         (objfile_find_memory_regions): Likewise.
9453
9454 2019-01-09  Tom Tromey  <tom@tromey.com>
9455
9456         * symtab.c (find_line_symtab, info_sources_command)
9457         (make_source_files_completion_list): Use objfile_compunits.
9458         * source.c (select_source_symtab): Use objfile_compunits.
9459         * objfiles.h (struct objfile): Update comment.
9460         (ALL_OBJFILES): Remove.
9461         (ALL_FILETABS): Remove.
9462         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9463         objfile_compunits.
9464
9465 2019-01-09  Tom Tromey  <tom@tromey.com>
9466
9467         * symmisc.c (print_objfile_statistics, dump_objfile)
9468         (maintenance_print_symbols): Use compunit_filetabs.
9469         * source.c (forget_cached_source_info_for_objfile): Use
9470         compunit_filetabs.
9471         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9472         (ALL_FILETABS): Use compunit_filetabs.
9473         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9474         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9475
9476 2019-01-09  Tom Tromey  <tom@tromey.com>
9477
9478         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9479         (compunit_filetabs): New.
9480         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9481         compunit_filetabs.
9482         (info_sources_command, make_source_files_completion_list): Remove
9483         declaration.
9484         * symmisc.c (print_objfile_statistics, dump_objfile)
9485         (maintenance_print_symbols): Remove declaration.
9486         (maintenance_info_symtabs): Use compunit_filetabs.
9487         (maintenance_info_line_tables): Likewise.
9488         * source.c (select_source_symtab): Change local variable name.
9489         (forget_cached_source_info_for_objfile): Remove declaration.
9490         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9491         * objfiles.c (objfile_relocate1): Remove declaration.
9492         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9493         declaration.
9494         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9495         * coffread.c (coff_symtab_read): Remove declaration.
9496         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9497         compunit_filetabs.
9498
9499 2019-01-09  Tom Tromey  <tom@tromey.com>
9500
9501         * symtab.c (lookup_objfile_from_block)
9502         (find_pc_sect_compunit_symtab, search_symbols)
9503         (default_collect_symbol_completion_matches_break_on): Use
9504         objfile_compunits.
9505         * objfiles.h (ALL_COMPUNITS): Remove.
9506         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9507         * cp-support.c (add_symbol_overload_list_qualified): Use
9508         objfile_compunits.
9509         * ada-lang.c (ada_collect_symbol_completion_matches)
9510         (ada_add_global_exceptions): Use objfile_compunits.
9511
9512 2019-01-09  Tom Tromey  <tom@tromey.com>
9513
9514         * source.c (select_source_symtab)
9515         (forget_cached_source_info_for_objfile): Remove declaration.
9516         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9517         declaration.
9518         * maint.c (count_symtabs_and_blocks): Remove declaration.
9519         * cp-support.c (add_symbol_overload_list_qualified): Remove
9520         declaration.
9521         * coffread.c (coff_symtab_read): Remove declaration.
9522         * symtab.c (lookup_symbol_in_objfile_symtabs)
9523         (basic_lookup_transparent_type_1): Use objfile_compunits.
9524         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9525         (info_sources_command, search_symbols)
9526         (default_collect_symbol_completion_matches_break_on)
9527         (make_source_files_completion_list): Remove declaration.
9528         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9529         (ada_collect_symbol_completion_matches)
9530         (ada_add_global_exceptions): Remove declaration.
9531         * linespec.c (iterate_over_all_matching_symtabs): Use
9532         objfile_compunits.
9533         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9534         (class objfile_compunits): New.
9535         (ALL_COMPUNITS): Use objfile_compunits.
9536         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9537         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9538         objfile_compunits.
9539         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9540
9541 2019-01-09  Tom Tromey  <tom@tromey.com>
9542
9543         * symtab.c (search_symbols)
9544         (default_collect_symbol_completion_matches_break_on): Use
9545         objfile_msymbols.
9546         * ada-lang.c (ada_lookup_simple_minsym)
9547         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9548         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9549         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9550         objfile_msymbols.
9551         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9552         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9553         * objc-lang.c (find_methods): Use objfile_msymbols.
9554         (info_selectors_command, info_classes_command): Likewise.
9555         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9556         * objfiles.h (class objfile_msymbols): New.
9557         (ALL_OBJFILE_MSYMBOLS): Remove.
9558         (ALL_MSYMBOLS): Remove.
9559
9560 2019-01-09  Tom Tromey  <tom@tromey.com>
9561
9562         * common/next-iterator.h (next_adapter): Add Iterator template
9563         parameter.
9564         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9565         (class all_objfiles_safe): New.
9566         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9567         * objfiles.c (put_objfile_before): Update comment.
9568         (add_separate_debug_objfile): Likewise.
9569         (free_all_objfiles): Use all_objfiles_safe.
9570         (objfile_purge_solibs): Likewise.
9571
9572 2019-01-09  Tom Tromey  <tom@tromey.com>
9573
9574         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9575         (expand_symtab_containing_pc, lookup_static_symbol)
9576         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9577         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9578         all_objfiles.
9579         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9580         * breakpoint.c (create_overlay_event_breakpoint)
9581         (create_longjmp_master_breakpoint)
9582         (create_std_terminate_master_breakpoint)
9583         (create_exception_master_breakpoint): Use all_objfiles.
9584         * linux-thread-db.c (try_thread_db_load_from_pdir)
9585         (has_libpthread): Use all_objfiles.
9586         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9587         * linespec.c (iterate_over_all_matching_symtabs)
9588         (search_minsyms_for_name): Use all_objfiles.
9589         * maint.c (maintenance_info_sections): Use all_objfiles.
9590         * main.c (captured_main_1): Use all_objfiles.
9591         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9592         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9593         * guile/scm-pretty-print.c
9594         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9595         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9596         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9597         (maintenance_print_msymbols): Use all_objfiles.
9598         * source.c (select_source_symtab): Use all_objfiles.
9599         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9600         * symfile.c (remove_symbol_file_command)
9601         (expand_symtabs_matching, map_symbol_filenames): Use
9602         all_objfiles.
9603         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9604         all_objfiles.
9605         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9606         * objc-lang.c (find_methods): Use all_objfiles.
9607         * objfiles.c (have_partial_symbols, have_full_symbols)
9608         (have_minimal_symbols, qsort_cmp)
9609         (default_iterate_over_objfiles_in_search_order): Use
9610         all_objfiles.
9611         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9612         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9613         (maintenance_check_psymtabs): Use all_objfiles.
9614         (ALL_PSYMTABS): Remove.
9615         * compile/compile-object-run.c (do_module_cleanup): Use
9616         all_objfiles.
9617         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9618         * cp-support.c (add_symbol_overload_list_qualified): Use
9619         all_objfiles.
9620         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9621         Use all_objfiles.
9622         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9623         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9624         all_objfiles.
9625         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9626         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9627         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9628         Uses all_objfiles.
9629         * solib.c (solib_read_symbols): Use all_objfiles
9630
9631 2019-01-09  Tom Tromey  <tom@tromey.com>
9632
9633         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9634         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9635         all_objfiles.
9636         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9637         * symmisc.c (print_symbol_bcache_statistics)
9638         (print_objfile_statistics, maintenance_print_objfiles)
9639         (maintenance_info_symtabs, maintenance_check_symtabs)
9640         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9641         all_objfiles.
9642         * source.c (forget_cached_source_info): Use all_objfiles.
9643         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9644         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9645         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9646         * objfiles.c (update_section_map): Use all_objfiles.
9647         (shared_objfile_contains_address_p): Likewise.
9648         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9649         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9650
9651 2019-01-09  Tom Tromey  <tom@tromey.com>
9652
9653         * common/next-iterator.h: New file.
9654         * objfiles.h (class all_objfiles): New.
9655         (struct objfile_iterator): New.
9656
9657 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9658
9659         * NEWS: Move the description of the changed "frame", "select-frame",
9660          and "info frame" commands to the Changed commands section.
9661
9662 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9663
9664         * gdbtypes.c (check_stub_method_group): Remove handling of old
9665         mangling schemes.
9666         * linespec.c (find_methods): Likewise.
9667         * stabsread.c (read_member_functions): Likewise.
9668         * valops.c (search_struct_method): Likewise.
9669         (value_struct_elt_for_reference): Likewise.
9670         * NEWS: Mention this change.
9671
9672 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9673
9674         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9675         print_source_lines.
9676         * source.c (print_source_lines_base): Update line number check.
9677         (print_source_lines): New function.
9678         (source_lines_range::source_lines_range): New function.
9679         * source.h (class source_lines_range): New class.
9680         (print_source_lines): New declaration.
9681
9682 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9683
9684         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9685
9686 2019-01-08  Tom Tromey  <tom@tromey.com>
9687             Simon Marchi  <simon.marchi@ericsson.com>
9688
9689         PR gdb/24060
9690         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9691         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9692         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9693         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9694         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9695         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9696
9697 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9698
9699         * source.c (select_source_symtab): Move header comment to
9700         declaration in source.h.
9701         (forget_cached_source_info_for_objfile): Likewise.
9702         (forget_cached_source_info): Likewise.
9703         (identify_source_line): Likewise.
9704         * source.h (identify_source_line): Move declaration from symtab.h
9705         and add comment from source.c
9706         (print_source_lines): Likewise.
9707         (forget_cached_source_info_for_objfile): Likewise.
9708         (forget_cached_source_info): Likewise.
9709         (select_source_symtab): Likewise.
9710         (enum print_source_lines_flag): Move definition from symtab.h.
9711         * symtab.h (identify_source_line): Move declaration to source.h.
9712         (print_source_lines): Likewise.
9713         (forget_cached_source_info_for_objfile): Likewise.
9714         (forget_cached_source_info): Likewise.
9715         (select_source_symtab): Likewise.
9716         (enum print_source_lines_flag): Move definition to source.h.
9717         * tui/tui-hooks.c: Add 'source.h' include.
9718
9719 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9720
9721         * source.c (print_source_lines_base): Handle requests to print
9722         reverse line number sequences, and guard against empty lines
9723         string.
9724
9725 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9726
9727         * source.c (print_source_lines_base): Fix skip of '\r' if next
9728         character is '\n'.
9729
9730 2019-01-06  Tom Tromey  <tom@tromey.com>
9731
9732         * c-exp.y (struct c_parse_state) <macro_original_text,
9733         expansion_obstack>: New member.
9734         (macro_original_text, expansion_obstack): Remove globals.
9735         (scan_macro_expansion, scanning_macro_expansion)
9736         (finished_macro_expansion): Update.
9737         (scan_macro_cleanup): Remove.
9738         (yylex, c_parse): Update.
9739
9740 2019-01-06  Tom Tromey  <tom@tromey.com>
9741
9742         * c-exp.y (struct c_parse_state) <strings>: New member.
9743         (operator_stoken): Update.
9744
9745 2019-01-06  Tom Tromey  <tom@tromey.com>
9746
9747         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9748         (union type_stack_elt) <typelist_val>: Now a pointer to
9749         std::vector.
9750         (type_stack_cleanup): Don't declare.
9751         (push_typelist): Update.
9752         * parse.c (pop_typelist): Return a std::vector.
9753         (push_typelist): Take a std::vector.
9754         (follow_types): Update.  Do not free args.
9755         (type_stack_cleanup): Remove.
9756         * c-exp.y (struct c_parse_state): New.
9757         (cpstate): New global.
9758         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9759         (nonempty_typelist): Update.
9760         (func_mod): Create a new vector.
9761         (c_parse): Create a c_parse_state.
9762         (check_parameter_typelist): Do not delete params.
9763         (function_method): Update.  Do not delete type_list.
9764
9765 2019-01-06  Tom Tromey  <tom@tromey.com>
9766
9767         PR gdb/28155:
9768         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9769         check_typedef.
9770         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9771         (print_return_value): Likewise.
9772
9773 2019-01-05  Tom Tromey  <tom@tromey.com>
9774
9775         * contrib/cleanup_check.py: Remove.
9776         * contrib/gcc-with-excheck: Remove.
9777         * contrib/exsummary.py: Remove.
9778         * contrib/excheck.py: Remove.
9779
9780 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9781
9782         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9783         NULL. Initialize tpprev to NULL instead of assigning it
9784         to NULL on the next statement.
9785         * windows-nat.c (windows_delete_thread): Remove check for
9786         main_thread_id before printing thread exit notifications.
9787         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9788         Remove thread ID check against main_thread_id.
9789         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9790         windows_delete_thread.
9791         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9792
9793 2019-01-04  Tom Tromey  <tom@tromey.com>
9794
9795         * compile/compile.c (_initialize_compile): Use upper case for
9796         metasyntactic variables.
9797         * symmisc.c (_initialize_symmisc): Use upper case for
9798         metasyntactic variables.
9799         * psymtab.c (_initialize_psymtab): Use upper case for
9800         metasyntactic variables.
9801         * demangle.c (demangle_command): Use upper case for metasyntactic
9802         variables.
9803         (_initialize_demangler): Likewise.
9804         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9805         variables.
9806
9807 2019-01-03  Tom Tromey  <tom@tromey.com>
9808
9809         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9810
9811 2019-01-03  Tom Tromey  <tom@tromey.com>
9812
9813         * python/py-symtab.c (salpy_str): Update.
9814         (struct salpy_sal_object) <symtab>: Now a PyObject.
9815         (salpy_dealloc): Update.
9816         (del_objfile_sal): Use gdbpy_ref.
9817
9818 2019-01-03  Tom Tromey  <tom@tromey.com>
9819
9820         * python/py-type.c (convert_field): Use new_reference.  Return
9821         gdbpy_ref.
9822         (make_fielditem): Return gdbpy_ref.
9823         (typy_fields): Update.
9824         (typy_getitem): Update.
9825         (field_name): Return gdbpy_ref.  Use new_reference.
9826         (typy_iterator_iternext): Update.
9827
9828 2019-01-03  Tom Tromey  <tom@tromey.com>
9829
9830         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9831
9832 2019-01-03  Tom Tromey  <tom@tromey.com>
9833
9834         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9835         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9836         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9837         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9838         (pspy_set_type_printers): Likewise.
9839         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9840         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9841         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9842         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9843         (objfpy_set_type_printers): Likewise.
9844
9845 2019-01-03  Tom Tromey  <tom@tromey.com>
9846
9847         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9848         (gdbpy_print_stack): Use gdbpy_err_fetch.
9849         * python/python-internal.h (class gdbpy_err_fetch): New class.
9850         (class gdbpy_enter) <m_error_type, m_error_value,
9851         m_error_traceback>: Remove.
9852         <m_error>: New member.
9853         (gdbpy_exception_to_string): Don't declare.
9854         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9855         * python/py-value.c (convert_value_from_python): Use
9856         gdbpy_err_fetch.
9857         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9858         gdbpy_exception_to_string.
9859         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9860         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9861         gdbpy_err_fetch.
9862
9863 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9864
9865         * linux-nat.c (delete_lwp_cleanup): Delete.
9866         (struct lwp_deleter): New struct.
9867         (lwp_info_up): New typedef.
9868         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9869         lwp_info_up.
9870
9871 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9872
9873         * linux-fork.c (class scoped_switch_fork_info): New class.
9874         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9875
9876 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9877
9878         * valops.c (find_overload_match): Remove use of null_cleanup, and
9879         calls to do_cleanups.
9880
9881 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9882
9883         * compile/compile-cplus-types.c
9884         (compile_cplus_instance::decl_name): Handle changes to
9885         cp_func_name.
9886         * cp-support.c (cp_func_name): Update header comment, update
9887         return type.
9888         * cp-support.h (cp_func_name): Update return type in declaration.
9889         * valops.c (find_overload_match): Move temp_func local to top
9890         level of function and change its type.  Use temp_func to hold and
9891         delete temporary string obtained from cp_func_name.
9892
9893 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9894
9895         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9896         gdb::char_vector, remove cleanup, and update uses of `msg`.
9897
9898 2019-01-03  Jim Wilson  <jimw@sifive.com>
9899
9900         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9901
9902 2019-01-02  Tom Tromey  <tom@tromey.com>
9903
9904         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9905         (tdesc_parse_xml): Remove cleanups.
9906         * target-descriptions.h (make_cleanup_free_target_description):
9907         Don't declare.
9908         (target_desc_deleter): New struct.
9909         (target_desc_up): New typedef.
9910         * target-descriptions.c (target_desc_deleter::operator()): Rename
9911         from free_target_description.
9912         (make_cleanup_free_target_description): Remove.
9913
9914 2019-01-02  Tom Tromey  <tom@tromey.com>
9915
9916         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9917         constructor, destructor.
9918         (linespec_parser): Remove typedef.
9919         (~linespec_parser): Rename from linespec_parser_delete.
9920         (linespec_lex_to_end, linespec_complete_label)
9921         (linespec_complete): Update.
9922         (decode_line_full): Remove cleanups.
9923         (decode_line_1): Update.
9924
9925 2019-01-02  Tom Tromey  <tom@tromey.com>
9926
9927         * python/python-internal.h (inferior_to_inferior_object): Change
9928         return type.
9929         * python/py-exitedevent.c (create_exited_event_object): Update.
9930         * python/py-inferior.c (inferior_to_inferior_object): Return
9931         gdbpy_ref.
9932         (python_new_inferior, python_inferior_deleted)
9933         (thread_to_thread_object, delete_thread_object)
9934         (build_inferior_list, gdbpy_selected_inferior): Update.
9935         * python/py-infthread.c (create_thread_object): Update.  Also fail
9936         if inferior_to_inferior_object fails.
9937
9938 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9939
9940         * inferior.h (class inferior) <displaced_step_state>: New field.
9941         * infrun.h (struct displaced_step_state): Move here from
9942         infrun.c.  Initialize fields, add constructor.
9943         <inf>: Remove field.
9944         <reset>: New method.
9945         * infrun.c (struct displaced_step_inferior_state): Move to
9946         infrun.h.
9947         (displaced_step_inferior_states): Remove.
9948         (get_displaced_stepping_state): Adust.
9949         (displaced_step_in_progress_any_inferior): Adjust.
9950         (displaced_step_in_progress_thread): Adjust.
9951         (displaced_step_in_progress): Adjust.
9952         (add_displaced_stepping_state): Remove.
9953         (get_displaced_step_closure_by_addr): Adjust.
9954         (remove_displaced_stepping_state): Remove.
9955         (infrun_inferior_exit): Call displaced_step_state.reset.
9956         (use_displaced_stepping): Don't check for NULL.
9957         (displaced_step_prepare_throw): Call
9958         get_displaced_stepping_state.
9959         (displaced_step_fixup): Don't check for NULL.
9960         (prepare_for_detach): Don't check for NULL.
9961
9962 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9963
9964         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9965          in case of call that did not complete.
9966
9967 2019-01-02  Andrey Utkin  <autkin@undo.io>
9968
9969         * symfile.c (find_separate_debug_file): Fix search of debug files for
9970         remote debuggee.
9971
9972 2019-01-02  Tom Tromey  <tom@tromey.com>
9973
9974         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9975         indentation.
9976         * python/py-frame.c (frapy_older): Remove cast.
9977         (frapy_newer): Likewise.
9978         * python/py-breakpoint.c (local_setattro): Remove cast.
9979         * python/py-arch.c (archpy_name): Remove local variable.
9980         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9981
9982 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9983
9984         * unittests/basic_string_view/element_access/char/empty.cc:
9985         Fix year range in copyright header.
9986
9987 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9988
9989         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9990         Delete.
9991         <operator==>: Update with for removed field.
9992         <hash>: Likewise.
9993         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9994         <isa_features>: ...this.
9995         <abi_features>: New field.
9996         (riscv_isa_flen): Update comment.
9997         (riscv_abi_xlen): New declaration.
9998         (riscv_abi_flen): New declaration.
9999         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10000         isa_features.
10001         (riscv_abi_xlen): New function.
10002         (riscv_isa_flen): Update to get answer from isa_features.
10003         (riscv_abi_flen): New function.
10004         (riscv_has_fp_abi): Update to get answer from abi_features.
10005         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10006         xlen and flen.
10007         (riscv_call_info) <xlen, flen>: Update comment.
10008         (riscv_call_arg_struct): Remove invalid assertions
10009         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10010         is removed.
10011         (riscv_gdbarch_init): Gather isa features and abi features
10012         separately, ensure both match on the gdbarch when reusing an old
10013         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10014         a target with 64-bit float hardware.
10015
10016 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10017
10018         * source.c (search_command_helper): Stop reverse search
10019         when line 1 has been searched.
10020
10021 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10022
10023         * record-full.c (record_full_base_target::close): Rewrite
10024         record_full_core_buf_list free logic.
10025
10026 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10027
10028         * break-catch-syscall.c (print_one_catch_syscall): xfree
10029         the last text.
10030
10031 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10032
10033         * top.c (print_gdb_version): Update Copyright year in version
10034         message.
10035
10036 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10037
10038         Update copyright year range in all GDB files.
10039
10040 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10041
10042         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10043
10044 For older changes see ChangeLog-2018.
10045 \f
10046 Local Variables:
10047 mode: change-log
10048 left-margin: 8
10049 fill-column: 74
10050 version-control: never
10051 coding: utf-8
10052 End:
10053